a311b8290e40feb842771e6a459a12b06b0c7c8a
[external/binutils.git] / gdb / ChangeLog
1 2019-03-06  Tom Tromey  <tom@tromey.com>
2
3         * top.c (quit_force): Update.
4         * main.c (captured_command_loop): Update.
5         * common/new-op.c (operator new): Update.
6         * common/common-exceptions.c (struct catcher)
7         <save_cleanup_chain>: Remove member.
8         (exceptions_state_mc_init): Update.
9         (exception_try_scope_entry): Return nullptr.
10         (exception_try_scope_exit, exception_rethrow)
11         (throw_exception_sjlj, throw_exception_cxx): Update.
12         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13         (all_cleanups, do_cleanups, discard_cleanups)
14         (discard_final_cleanups, save_cleanups, save_final_cleanups)
15         (restore_cleanups, restore_final_cleanups): Don't declare.
16         (do_final_cleanups): Remove parameter.
17         * common/cleanups.c (cleanup_chain, make_cleanup)
18         (make_cleanup_dtor, all_cleanups, do_cleanups)
19         (discard_my_cleanups, discard_cleanups)
20         (discard_final_cleanups, save_my_cleanups, save_cleanups)
21         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
22         (null_cleanup): Remove.
23         (do_final_cleanups): Remove parameter.
24
25 2019-03-06  Tom Tromey  <tom@tromey.com>
26
27         * remote.c (remote_target::remote_parse_stop_reply): Use
28         unique_xmalloc_ptr.
29
30 2019-03-06  Tom Tromey  <tom@tromey.com>
31
32         * stabsread.c (struct stabs_field_info): Rename from field_info.
33         <list, fnlist>: Add initializers.
34         <obstack>: New member.
35         (read_member_functions, read_struct_fields, read_baseclasses):
36         Allocate on obstack.  Don't use cleanups.
37         (read_one_struct_field, read_member_functions, read_struct_fields)
38         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
39         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
40         (read_struct_type): Update.
41
42 2019-03-06  Tom Tromey  <tom@tromey.com>
43
44         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
45         * common/filestuff.h (make_cleanup_close): Don't declare.
46         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
47         Remove.
48
49 2019-03-06  Tom Tromey  <tom@tromey.com>
50
51         * solib-aix.c: Use make_scope_exit.
52
53 2019-03-06  Tom Tromey  <tom@tromey.com>
54
55         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
56         Use make_scope_exit.
57
58 2019-03-06  Tom Tromey  <tom@tromey.com>
59
60         * solib-svr4.c (disable_probes_interface): Remove parameter.
61         (svr4_handle_solib_event): Use make_scope_exit.
62
63 2019-03-06  Tom Tromey  <tom@tromey.com>
64
65         * remote.c (struct stop_reply_deleter): Remove.
66         (stop_reply_up): Update.
67         (struct stop_reply): Derive from notif_event.  Don't typedef.
68         <regcache>: Now a std::vector.
69         (stop_reply_xfree): Remove.
70         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
71         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
72         (remote_target::discard_pending_stop_replies): Use delete.
73         (remote_target::remote_parse_stop_reply): Update.
74         (remote_target::process_stop_reply): Update.
75         * remote-notif.h (struct notif_event): Add virtual destructor.
76         Remove "dtr" member.
77         (struct notif_client) <alloc_event>: Return a unique_ptr.
78         (notif_event_xfree): Don't declare.
79         (notif_event_up): New typedef.
80         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
81         (notif_event_xfree, do_notif_event_xfree): Remove.
82         (remote_notif_state_xfree): Update.
83
84 2019-03-06  Tom Tromey  <tom@tromey.com>
85
86         * infrun.c (displaced_step_clear_cleanup): Now a
87         forward_scope_exit type.
88         (displaced_step_prepare_throw): Update.
89         (displaced_step_fixup): Update.
90
91 2019-03-06  Tom Tromey  <tom@tromey.com>
92
93         * inferior.h (class inferior): Update comment.
94         * gdbthread.h (class thread_info): Update comment.
95
96 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
97             Tom Tromey  <tom@tromey.com>
98
99         * stabsread.h (struct stab_section_list): Remove.
100         (coffstab_build_psymtabs): Update.
101         * dbxread.c (symbuf_sections): Now a std::vector.
102         (sect_idx): New global.
103         (fill_symbuf): Update.
104         (coffstab_build_psymtabs): Change type of stabsects parameter.
105         Update.
106         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
107         std::vector.
108         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
109         (coff_locate_sections): Update.
110         (coff_symfile_read): Remove cleanups.  Update.
111         (init_stringtab): Add storage parameter.
112         (free_stringtab, free_stringtab_cleanup): Remove.
113         (init_lineno): Add storage parameter.
114         (free_linetab, free_linetab_cleanup): Remove.
115
116 2019-03-06  Pedro Alves  <palves@redhat.com>
117
118         * linux-fork.c (fork_info::clobber_regs): Delete.
119         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
120         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
121         comment.  Adjust.
122         (scoped_switch_fork_info::scoped_switch_fork_info)
123         (checkpoint_command, linux_fork_context): Adjust
124         fork_save_infrun_state calls.
125
126 2019-03-06  Pedro Alves  <palves@redhat.com>
127
128         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
129         (inf_has_multiple_threads): Return 'bool' and rewrite using
130         inferior_info::threads().
131
132 2019-03-06  Pedro Alves  <palves@redhat.com>
133
134         * linux-fork.c: Include <list>.
135         (fork_list): Now a std::list instance.
136         (fork_info): Add ctor, dtor, and in-class initialize all fields.
137         (forks_exist_p, find_last_fork): Adjust.
138         (new_fork): Delete.
139         (one_fork_p): New.
140         (add_fork): Adjust.
141         (free_fork): Delete, folded into fork_info::~fork_info().
142         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
143         Adjust.
144         (init_fork_list): Delete.
145         (linux_fork_killall, linux_fork_mourn_inferior)
146         (linux_fork_detach, info_checkpoints_command): Adjust.
147         (_initialize_linux_fork): No longer call init_fork_list.
148
149 2019-03-06  Pedro Alves  <palves@redhat.com>
150
151         * linux-fork.c (new_fork): New, split out of ...
152         (add_fork): ... this.  Return void.  Move "first fork" special
153         case from here, to ...
154         (checkpoint_command): ... here.
155         * linux-linux.h (add_fork): Return void.
156
157 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
158
159         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
160
161 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
162             Chris January  <chris.january@arm.com>
163             David Lecomber  <david.lecomber@arm.com>
164
165         * f-exp.y: New token, UNOP_INTRINSIC.
166         (exp): New pattern using UNOP_INTRINSIC token.
167         (f77_keywords): Add 'abs' keyword.
168         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
169         (value_from_host_double): New function.
170         (evaluate_subexp_f): Support UNOP_ABS.
171
172 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
173
174         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
175         types.
176
177 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
178
179         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
180         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
181         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
182
183 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
184
185         * f-exp.y (convert_to_kind_type): Handle more type kinds.
186
187 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
188             Chris January  <chris.january@arm.com>
189
190         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
191         * f-exp.y: Define 'KIND' token.
192         (exp): New pattern for KIND expressions.
193         (ptype): Handle types with a kind extension.
194         (direct_abs_decl): Extend to spot kind extensions.
195         (f77_keywords): Add 'kind' to the list.
196         (push_kind_type): New function.
197         (convert_to_kind_type): New function.
198         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
199         * parse.c (operator_length_standard): Likewise.
200         * parser-defs.h (enum type_pieces): Add tp_kind.
201         * std-operator.def: Add UNOP_KIND.
202
203 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
204
205         * f-exp.y (f_parse): Set yydebug.
206
207 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
208
209         * f-lang.c (evaluate_subexp_f): New function.
210         (exp_descriptor_f): New global.
211         (f_language_defn): Use exp_descriptor_f instead of
212         exp_descriptor_standard.
213
214 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
215
216         * f-exp.y (struct token): Add comments.
217         (dot_ops): Remove uppercase versions and the end marker.
218         (f77_keywords): Likewise.
219         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
220         entries in the dot_ops array are case insensitive, and use
221         strncasecmp to compare strings.  Also some whitespace cleanup in
222         this area.  Similar for the f77_keywords array, except entries in
223         this list might be case sensitive.
224
225 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
226
227         * f-exp.y (struct f77_boolean_val): Add comments.
228         (boolean_values): Remove uppercase versions, and end marker.
229         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
230         and use strncasecmp to achieve case insensitivity.  Additionally,
231         perform whitespace cleanup around this code.
232
233 2019-03-06  Tom Tromey  <tromey@adacore.com>
234
235         * remote-sim.c (gdbsim_target_open): Use result of
236         gdb_argv::release.
237
238 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
239         Dirk Schubert  <dirk.schubert@arm.com>
240         Chris January  <chris.january@arm.com>
241
242         * eval.c (evaluate_subexp_standard): Call Fortran argument
243         wrapping logic.
244         * f-lang.c (struct value): A value which can be passed into a
245         Fortran function call.
246         (fortran_argument_convert): Wrap Fortran arguments in a pointer
247         where appropriate.
248         (struct type): Value ready for a Fortran function call.
249         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
250         is needed.
251         * f-lang.h (fortran_argument_convert): Declaration.
252         (fortran_preserve_arg_pointer): Declaration.
253         * infcall.c (value_arg_coerce): Call Fortran argument logic.
254
255 2019-03-05  Tom Tromey  <tromey@adacore.com>
256
257         * python/py-prettyprint.c (print_string_repr): Remove #if.
258         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
259
260 2019-03-05  Tom Tromey  <tromey@adacore.com>
261
262         * target.c (the_dummy_target): Move later.  Change type to
263         "dummy_target".
264         (initialize_targets): Don't initialize the_dummy_target.
265
266 2019-03-05  Tom Tromey  <tromey@adacore.com>
267
268         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
269         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
270
271 2019-03-05  Tom Tromey  <tromey@adacore.com>
272
273         * windows-nat.c (windows_nat_target::attach)
274         (windows_nat_target::detach): Don't call gdb_flush.
275         * valprint.c (generic_val_print, val_print, val_print_string):
276         Don't call gdb_flush.
277         * utils.c (defaulted_query): Don't call gdb_flush.
278         * typeprint.c (print_type_scalar): Don't call gdb_flush.
279         * target.c (target_announce_detach): Don't call gdb_flush.
280         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
281         * remote.c (extended_remote_target::attach): Don't call
282         gdb_flush.
283         * procfs.c (procfs_target::detach): Don't call gdb_flush.
284         * printcmd.c (do_examine): Don't call gdb_flush.
285         (info_display_command): Don't call gdb_flush.
286         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
287         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
288         * memattr.c (info_mem_command): Don't call gdb_flush.
289         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
290         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
291         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
292         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
293         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
294         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
295         (gnu_nat_target::detach): Don't call gdb_flush.
296         * f-valprint.c (f_val_print): Don't call gdb_flush.
297         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
298         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
299         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
300         gdb_flush.
301         * c-valprint.c (c_val_print): Don't call gdb_flush.
302         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
303
304 2019-03-05  Tom Tromey  <tromey@adacore.com>
305
306         * varobj.c (update_dynamic_varobj_children): Update.
307         (install_default_visualizer): Use reset, not release.
308         * value.c (set_internalvar): Update.
309         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
310         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
311         ATTRIBUTE_UNUSED_RESULT.
312
313 2019-03-05  Tom Tromey  <tromey@adacore.com>
314
315         * remote.c (class scoped_remote_fd) <release>: Add
316         ATTRIBUTE_UNUSED_RESULT.
317
318 2019-03-05  Tom Tromey  <tromey@adacore.com>
319
320         * macroexp.c (struct macro_buffer) <release>: Add
321         ATTRIBUTE_UNUSED_RESULT.
322
323 2019-03-05  Tom Tromey  <tromey@adacore.com>
324
325         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
326         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
327         ATTRIBUTE_UNUSED_RESULT.
328
329 2019-03-05  Tom Tromey  <tromey@adacore.com>
330
331         * common/scoped_fd.h (class scoped_fd) <release>: Add
332         ATTRIBUTE_UNUSED_RESULT.
333
334 2019-03-05  Tom Tromey  <tromey@adacore.com>
335
336         * parser-defs.h (struct parser_state) <release>: Add
337         ATTRIBUTE_UNUSED_RESULT.
338
339 2019-03-05  Tom Tromey  <tromey@adacore.com>
340
341         * utils.h (class gdb_argv) <release>: Add
342         ATTRIBUTE_UNUSED_RESULT.
343         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
344
345 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
346
347         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
348         for-loop range, to avoid compiler warnings.
349
350         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
351         avoid compiler warnings about unused variables.
352
353         * NEWS: Mention end of support for native debugging on MS-Windows
354         before XP.
355
356         PR gdb/24292
357         * common/netstuff.c:
358         * gdbserver/gdbreplay.c
359         * gdbserver/remote-utils.c:
360         * ser-tcp.c:
361         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
362         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
363         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
364         'getaddrinfo' and 'freeaddrinfo' were not available before
365         Windows XP, and mingw.org's MinGW headers by default define
366         _WIN32_WINNT to 0x500.
367
368 2019-03-01  Gary Benson <gbenson@redhat.com>
369
370         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
371
372 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
373             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
374
375         PR gdb/8527
376         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
377         set_sigint_trap, clear_sigint_trap.
378
379 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
380
381         * target.c (target_detach): Clear the regcache and the
382         frame cache.
383
384 2019-02-27  Pedro Alves  <palves@redhat.com>
385
386         * utils.c (set_screen_size): When we cap the height/width sizes,
387         tweak the corresponding command variable to show "unlimited":
388
389 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
390             Pedro Alves  <palves@redhat.com>
391
392         * utils.c (set_screen_size): Reduce "infinite" rows and columns
393         before calling rl_set_screen_size.
394
395 2019-02-27  Tom Tromey  <tromey@adacore.com>
396
397         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
398         define.
399         * python/py-value.c: Remove Python 2.4 workaround.
400         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
401         workaround.
402         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
403         Python 2.4 workaround.
404         * python/python-internal.h: Remove Python 2.4 comment.
405         (Py_ssize_t): Don't define.
406         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
407         (gdb_Py_DECREF): Remove Python 2.4 workaround.
408         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
409         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
410         * python/python.c (do_start_initialization): Remove Python 2.4
411         workaround.
412         * python/py-prettyprint.c (class dummy_python_frame): Remove.
413         (print_children): Remove Python 2.4 workaround.
414         * python/py-inferior.c (buffer_procs): Remove Python 2.4
415         workaround.
416         (CHARBUFFERPROC_NAME): Remove.
417         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
418         Python 2.4 workaround.
419
420 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
421
422         * NEWS: Note minimum Python version.
423
424 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
425
426         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
427         code from these functions.  Remove corresponding ifdefs.  Use
428         Py_buffer_up instead of explicit calls to PyBuffer_Release.
429         Remove gotos and target of gotos.
430         (infpy_search_memory): Likewise.
431
432 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
433
434         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
435         (hppa_gdbarch_init): Don't register deleted functions with
436         gdbarch.
437
438 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
439
440         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
441         (h8300_unwind_sp): Delete.
442         (h8300_dummy_id): Delete.
443         (h8300_gdbarch_init): Don't register deleted functions with
444         gdbarch.
445
446 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
447
448         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
449         (ft32_unwind_pc): Delete.
450         (ft32_unwind_sp): Delete.
451         (ft32_gdbarch_init): Don't register deleted functions with
452         gdbarch.
453
454 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
455
456         * gdb/frv-tdep.c (frv_dummy_id): Delete.
457         (frv_unwind_pc): Delete.
458         (frv_unwind_sp): Delete.
459         (frv_gdbarch_init): Don't register deleted functions with
460         gdbarch.
461
462 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
463
464         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
465         (riscv_unwind_pc): Delete.
466         (riscv_unwind_sp): Delete.
467         (riscv_gdbarch_init): Don't register deleted functions with
468         gdbarch.
469
470 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
471
472         * gdb/csky-tdep.c (csky_dummy_id): Delete.
473         (csky_unwind_pc): Delete.
474         (csky_unwind_sp): Delete.
475         (csky_gdbarch_init): Don't register deleted functions with
476         gdbarch.
477
478 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
479
480         * gdb/cris-tdep.c (cris_dummy_id): Delete.
481         (cris_unwind_pc): Delete.
482         (cris_unwind_sp): Delete.
483         (cris_gdbarch_init): Don't register deleted functions with
484         gdbarch.
485
486 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
487
488         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
489         (bfin_unwind_pc): Delete.
490         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
491
492 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
493
494         * gdb/arm-tdep.c (arm_dummy_id): Delete.
495         (arm_unwind_pc): Delete.
496         (arm_unwind_sp): Delete.
497         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
498
499 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
500
501         * gdb/arc-tdep.c (arc_dummy_id): Delete.
502         (arc_unwind_pc): Delete.
503         (arc_unwind_sp): Delete.
504         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
505
506 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
507
508         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
509         (alpha_unwind_pc): Delete.
510         (alpha_gdbarch_init): Don't register deleted functions with
511         gdbarch.
512
513 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
514
515         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
516         (aarch64_unwind_pc): Delete.
517         (aarch64_unwind_sp): Delete.
518         (aarch64_gdbarch_init): Don't register deleted functions with
519         gdbarch.
520
521 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
522
523         * gdbtypes.c (type_align): Don't consider static members when
524         computing structure alignment.
525
526 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
527
528         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
529         return 0 for other types.
530         * arch-utils.c (default_type_align): Always return 0.
531         * gdbarch.h: Regenerate.
532         * gdbarch.sh (type_align): Extend comment.
533         * gdbtypes.c (type_align): Add additional comments, always call
534         gdbarch_type_align before applying the default rules.
535         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
536         generic code will then apply a suitable default.
537         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
538         types, return 0 for other types.
539
540 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
541
542         * NEWS: Create a new section for the next release branch.
543         Rename the section of the current branch, now that it has
544         been cut.
545
546 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
547
548         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
549         * version.in: Bump version to 8.3.50.DATE-git.
550
551 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
552
553         * aix-thread.c (ptid_cmp): Remove unused variable.
554         (get_signaled_thread): Likewise.
555         (store_regs_user_thread): Likewise.
556         (store_regs_kernel_thread): Likewise.
557         (fetch_regs_kernel_thread): Remove shadowed variable.
558
559 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
560
561         * features/riscv/32bit-cpu.xml: Add register numbers.
562         * features/riscv/32bit-fpu.c: Regenerate.
563         * features/riscv/32bit-fpu.xml: Add register numbers.
564         * features/riscv/64bit-cpu.xml: Add register numbers.
565         * features/riscv/64bit-fpu.c: Regenerate.
566         * features/riscv/64bit-fpu.xml: Add register numbers.
567
568 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
569
570         * NEWS: Mention two argument form of gdb.Value constructor.
571         * python/py-value.c (convert_buffer_and_type_to_value): New
572         function.
573         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
574         Add support for handling an optional second argument.  Call
575         convert_buffer_and_type_to_value as appropriate.
576         * python/python-internal.h (Py_buffer_deleter): New struct.
577         (Py_buffer_up): New typedef.
578
579 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
580
581         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
582         instead of releasing ownership.
583
584 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
585
586         * dwarf2read.c (open_and_init_dwp_file): Call
587         elf_numsections instead of bfd_count_sections to initialize
588         dwp_file->num_sections.
589
590 2019-02-25  Tom Tromey  <tromey@adacore.com>
591
592         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
593
594 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
595
596         * gcore.in: Add '--readnever' option when invoking GDB.
597
598 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
599
600         * MAINTAINERS: Update my email address.
601
602 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
603
604         * build-id.c (build_id_to_debug_bfd_1): New function.
605         (build_id_to_debug_bfd): Look for separate debug file in
606         sysroot.
607
608 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
609
610         * gdbarch.sh: Update the copyright year range that is placed into
611         generated files.
612
613 2019-02-22  Keith Seitz  <keiths@redhat.com>
614
615         PR symtab/23853
616         * linespec.c (create_sals_line_offset): Search for the default
617         symtab's filename instead of its fullname.
618
619 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
620
621         * NEWS: Update style defaults.
622
623 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
624
625         * main.c (captured_main_1): Disable styling in batch mode.
626
627 2019-02-20  Tom Tromey  <tom@tromey.com>
628
629         * symtab.c (symtab_symbol_info): Fix typos.
630
631 2019-02-20  Tom Tromey  <tromey@adacore.com>
632
633         * findcmd.c (_initialize_mem_search): Use upper case for
634         metasyntactic variables.
635
636 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
637
638         * aarch64-tdep.c (aarch64_add_reggroups): New function.
639         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
640
641 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
642
643         * top.h (source_file_name): Change to std::string.
644         * top.c (source_file_name): Likewise.
645         (command_line_input): Adjust.
646         * cli/cli-script.c (script_from_file): Adjust.
647
648 2019-02-19  Tom Tromey  <tromey@adacore.com>
649
650         * ravenscar-thread.c
651         (ravenscar_thread_target::update_thread_list): Don't call
652         ada_build_task_list.
653         * ada-lang.h (ada_build_task_list): Don't declare.
654         * ada-tasks.c (struct ada_tasks_inferior_data)
655         <task_list_valid_p>: Now bool.
656         (read_known_tasks, ada_task_list_changed)
657         (ada_tasks_invalidate_inferior_data): Update.
658         (read_known_tasks_array): Return bool.
659         (read_known_tasks_list): Likewise.
660         (read_known_tasks): Return void.
661         (ada_build_task_list): Now static.
662
663 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
664
665         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
666         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
667
668 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
669
670         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
671         variant for ada_tasks_pspace_data_handle and
672         ada_tasks_inferior_data_handle.
673         (ada_tasks_pspace_data_cleanup): New function.
674         (ada_tasks_inferior_data_cleanup): New function.
675
676 2019-02-17  Tom Tromey  <tom@tromey.com>
677
678         * macrotab.h (macro_source_fullname): Return a std::string.
679         * macrotab.c (macro_include, check_for_redefinition)
680         (macro_undef, macro_lookup_definition, foreach_macro)
681         (foreach_macro_in_scope): Update.
682         (macro_source_fullname): Return a std::string.
683         * macrocmd.c (show_pp_source_pos): Update.
684
685 2019-02-17  Tom Tromey  <tom@tromey.com>
686
687         * macrocmd.c (show_pp_source_pos): Style the file names.
688
689 2019-02-17  Tom Tromey  <tom@tromey.com>
690
691         PR tui/24197:
692         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
693
694 2019-02-17  Tom Tromey  <tom@tromey.com>
695
696         * ada-lang.c (user_select_syms): Use filtered printing.
697         * utils.c (wrap_style): New global.
698         (desired_style): Remove.
699         (emit_style_escape): Add stream parameter.
700         (set_output_style, reset_terminal_style, prompt_for_continue):
701         Update.
702         (flush_wrap_buffer): Only flush gdb_stdout.
703         (wrap_here): Set wrap_style.
704         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
705         treat escape sequences as a character.  Change when wrap buffer is
706         flushed.
707         (fputs_styled): Do not set the output style when the default is
708         requested.
709         * ui-style.h (struct ui_file_style) <is_default>: New method.
710         * source.c (print_source_lines_base): Emit escape sequences in one
711         piece.
712
713 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
714
715         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
716         integers and enumeration types.
717
718 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
719
720         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
721         instead of lookup_symbol_in_language
722         (do_exact_match): New function.
723         (ada_get_symbol_name_matcher): Return do_exact_match when
724         doing a verbatim match.
725
726 2019-02-15  Tom Tromey  <tromey@adacore.com>
727
728         * ravenscar-thread.c (ravenscar_thread_target::resume)
729         (ravenscar_thread_target::wait): Special case wildcard requests.
730
731 2019-02-15  Tom Tromey  <tromey@adacore.com>
732
733         * ravenscar-thread.c (base_ptid): Remove.
734         (struct ravenscar_thread_target) <close>: New method.
735         <m_base_ptid>: New member.
736         <update_inferior_ptid, active_task, task_is_currently_active,
737         runtime_initialized>: Declare methods.
738         <ravenscar_thread_target>: Add constructor.
739         (ravenscar_thread_target::task_is_currently_active)
740         (ravenscar_thread_target::update_inferior_ptid)
741         (ravenscar_runtime_initialized): Rename.  Now methods.
742         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
743         (ravenscar_thread_target::update_thread_list): Update.
744         (ravenscar_thread_target::active_task): Now method.
745         (ravenscar_thread_target::store_registers)
746         (ravenscar_thread_target::prepare_to_store)
747         (ravenscar_thread_target::prepare_to_store)
748         (ravenscar_thread_target::mourn_inferior): Update.
749         (ravenscar_inferior_created): Use "new" to create target.
750         (ravenscar_thread_target::get_ada_task_ptid): Update.
751         (_initialize_ravenscar): Don't initialize base_ptid.
752         (ravenscar_ops): Remove global.
753
754 2019-02-15  Tom Tromey  <tromey@adacore.com>
755
756         * target.h (push_target): Declare new overload.
757         * target.c (push_target): New overload, taking an rvalue reference.
758         * remote.c (remote_target::open_1): Use push_target overload.
759         * corelow.c (core_target_open): Use push_target overload.
760
761 2019-02-15  Tom Tromey  <tromey@adacore.com>
762
763         * ravenscar-thread.c (is_ravenscar_task)
764         (ravenscar_task_is_currently_active): Return bool.
765         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
766         (_initialize_ravenscar): Remove "(void)".
767         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
768         Return bool.
769
770 2019-02-15  Tom Tromey  <tromey@adacore.com>
771
772         * ravenscar-thread.c (ravenscar_runtime_initializer)
773         (has_ravenscar_runtime, get_running_thread_id)
774         (ravenscar_thread_target::resume): Fix indentation.
775
776 2019-02-15  Tom Tromey  <tromey@adacore.com>
777
778         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
779         from ravenscar_arch_ops.
780         (sparc_ravenscar_ops::fetch_registers)
781         (sparc_ravenscar_ops::store_registers): Now methods.
782         (sparc_ravenscar_prepare_to_store): Remove.
783         (sparc_ravenscar_ops): Redefine.
784         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
785         methods and destructor.  Remove members.
786         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
787         (ravenscar_thread_target::store_registers)
788         (ravenscar_thread_target::prepare_to_store): Update.
789         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
790         Remove.
791         (struct ppc_ravenscar_powerpc_ops): Derive from
792         ravenscar_arch_ops.
793         (ppc_ravenscar_powerpc_ops::fetch_registers)
794         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
795         (ppc_ravenscar_powerpc_ops): Redefine.
796         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
797         (ppc_ravenscar_e500_ops::fetch_registers)
798         (ppc_ravenscar_e500_ops::store_registers): Now methods.
799         (ppc_ravenscar_e500_ops): Redefine.
800         * aarch64-ravenscar-thread.c
801         (aarch64_ravenscar_generic_prepare_to_store): Remove.
802         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
803         (aarch64_ravenscar_fetch_registers)
804         (aarch64_ravenscar_store_registers): Now methods.
805         (aarch64_ravenscar_ops): Redefine.
806
807 2019-02-15  Tom Tromey  <tromey@adacore.com>
808
809         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
810         (ravenscar_thread_target::stopped_by_hw_breakpoint)
811         (ravenscar_thread_target::stopped_by_watchpoint)
812         (ravenscar_thread_target::stopped_data_address)
813         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
814
815 2019-02-15  Tom Tromey  <tromey@adacore.com>
816
817         * ravenscar-thread.c: Fix some typos.
818
819 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
820             Tom Tromey  <tromey@adacore.com>
821
822         * ada-lang.c (ada_exception_sal): Change addr_string to a
823         std::string.
824         (create_ada_exception_catchpoint): Update.
825
826 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
827             Tom Tromey  <tromey@adacore.com>
828
829         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
830         (bp_location_ops): Remove.
831         (base_breakpoint_allocate_location): Update.
832         (free_bp_location): Update.
833         * ada-lang.c (class ada_catchpoint_location)
834         <ada_catchpoint_location>: Remove ops parameter.
835         (ada_catchpoint_location_dtor): Remove.
836         (ada_catchpoint_location_ops): Remove.
837         (allocate_location_exception): Update.
838         * breakpoint.h (struct bp_location_ops): Remove.
839         (class bp_location) <bp_location>: Remove bp_location_ops
840         parameter.
841         <~bp_location>: Add destructor.
842         <ops>: Remove.
843
844 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
845             Pedro Alves  <palves@redhat.com>
846
847         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
848         'PATH_MAX'.
849
850 2019-02-14  David Michael  <fedora.dm0@gmail.com>
851             Samuel Thibault  <samuel.thibault@gnu.org>
852             Thomas Schwinge  <thomas@codesourcery.com>
853
854         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
855         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
856
857 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
858
859         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
860         (check_empty): Use "const char *".
861
862         * gnu-nat.c (gnu_nat_target::detach): Instead of
863         'detach_inferior (pid)' call
864         'detach_inferior (find_inferior_pid (pid))'.
865
866         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
867         'nat/fork-inferior.o'.
868         * gnu-nat.c: #include "nat/fork-inferior.h".
869
870         * gnu-nat.c (gnu_nat_target::detach): Instead of
871         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
872         * gnu-nat.h: #include "inf-child.h".
873         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
874         'i386_gnu_nat_target::fetch_registers'.
875         (gnu_store_registers): Rename/move to
876         'i386_gnu_nat_target::store_registers'.
877
878         * config/i386/nm-i386gnu.h: Don't "#include" any files.
879         * gnu-nat.h (mach_thread_info): New function.
880         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
881
882         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
883
884 2019-02-14  Frederic Konrad  <konrad@adacore.com>
885
886         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
887
888 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
889
890         * windows-nat.c (windows_add_thread): Add new parameter
891         "main_thread_p" with default value set to false.  Update
892         function documentation as well as all callers.
893         (windows_delete_thread): Likewise.
894         (fake_create_process): Update call to windows_add_thread.
895         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
896         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
897         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
898         call to windows_delete_thread.
899
900 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
901
902         * MAINTAINERS: Add Andrew Burgess as global maintainer.
903
904 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
905
906         * symfile.c (find_separate_debug_file): Use canonical path of
907         sysroot with child_path instead of gdb_sysroot if it is valid.
908
909 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
910
911         * symfile.c (find_separate_debug_file): Use child_path to
912         determine if an object file is under a sysroot.
913
914 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
915
916         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
917         unittests/child-path-selftests.c.
918         * common/pathstuff.c (child_path): New function.
919         * common/pathstuff.h (child_path): New prototype.
920         * unittests/child-path-selftests.c: New file.
921
922 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
923
924         * symfile.c (find_separate_debug_file): Look for separate debug
925         files in debug directories under the sysroot.
926
927 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
928
929         * symtab.h (struct minimal_symbol data_p): New const method.
930         (struct minimal_symbol text_p): Likewise.
931         * symtab.c (output_source_filename): Use file name style
932         to print file name.
933         (print_symbol_info): Likewise.
934         (print_msymbol_info): Use address style to print addresses.
935         Use function name style to print executable text symbols.
936         (expand_symtab_containing_pc): Use data_p.
937         (find_pc_sect_compunit_symtab): Likewise.
938
939 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
940
941         * breakpoint.c (describe_other_breakpoints): Use address style
942         to print addresses.
943         (say_where): Likewise.
944
945 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
946
947         * ada-typeprint.c (print_func_type): Print function name
948         style to print function name.
949         * c-typeprint.c (c_print_type_1): Likewise.
950
951 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
952
953         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
954         for execve.
955
956 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
957
958         * c-exp.y (direct_abs_decl): Use emplace_back to record the
959         type_stack.
960
961 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
962
963         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
964         TYPE_CODE_REF types.
965
966 2019-02-08  Jim Wilson  <jimw@sifive.com>
967
968         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
969         (riscv_linux_fregset): New.
970         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
971
972 2019-02-07  Tom Tromey  <tom@tromey.com>
973
974         * thread.c (thread_cancel_execution_command): Update.
975         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
976         methods.
977         (struct thread_fsm_ops): Remove.
978         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
979         (thread_fsm_should_stop, thread_fsm_return_value)
980         (thread_fsm_set_finished, thread_fsm_finished_p)
981         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
982         Don't declare.
983         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
984         * infrun.c (clear_proceed_status_thread)
985         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
986         (print_stop_event): Update.
987         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
988         Add constructor.
989         (step_command_fsm_ops): Remove.
990         (new_step_command_fsm): Remove.
991         (step_1): Update.
992         (step_command_fsm::should_stop): Rename from
993         step_command_fsm_should_stop.
994         (step_command_fsm::clean_up): Rename from
995         step_command_fsm_clean_up.
996         (step_command_fsm::do_async_reply_reason): Rename from
997         step_command_fsm_async_reply_reason.
998         (struct until_next_fsm): Inherit from thread_fsm.  Add
999         constructor.
1000         (until_next_fsm_ops): Remove.
1001         (new_until_next_fsm): Remove.
1002         (until_next_fsm::should_stop): Rename from
1003         until_next_fsm_should_stop.
1004         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
1005         (until_next_fsm::do_async_reply_reason): Rename from
1006         until_next_fsm_async_reply_reason.
1007         (struct finish_command_fsm): Inherit from thread_fsm.  Add
1008         constructor.  Change type of breakpoint.
1009         (finish_command_fsm_ops): Remove.
1010         (new_finish_command_fsm): Remove.
1011         (finish_command_fsm::should_stop): Rename from
1012         finish_command_fsm_should_stop.
1013         (finish_command_fsm::clean_up): Rename from
1014         finish_command_fsm_clean_up.
1015         (finish_command_fsm::return_value): Rename from
1016         finish_command_fsm_return_value.
1017         (finish_command_fsm::do_async_reply_reason): Rename from
1018         finish_command_fsm_async_reply_reason.
1019         (finish_command): Update.
1020         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
1021         Add constructor.
1022         (call_thread_fsm_ops): Remove.
1023         (call_thread_fsm::call_thread_fsm): Rename from
1024         new_call_thread_fsm.
1025         (call_thread_fsm::should_stop): Rename from
1026         call_thread_fsm_should_stop.
1027         (call_thread_fsm::should_notify_stop): Rename from
1028         call_thread_fsm_should_notify_stop.
1029         (run_inferior_call, call_function_by_hand_dummy): Update.
1030         * cli/cli-interp.c (should_print_stop_to_console): Update.
1031         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
1032         Add constructor.  Change type of location_breakpoint,
1033         caller_breakpoint.
1034         (until_break_fsm_ops): Remove.
1035         (new_until_break_fsm): Remove.
1036         (until_break_fsm::should_stop): Rename from
1037         until_break_fsm_should_stop.
1038         (until_break_fsm::clean_up): Rename from
1039         until_break_fsm_clean_up.
1040         (until_break_fsm::do_async_reply_reason): Rename from
1041         until_break_fsm_async_reply_reason.
1042         (until_break_command): Update.
1043         * thread-fsm.c: Remove.
1044         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
1045
1046 2019-02-07  Tom Tromey  <tom@tromey.com>
1047
1048         * yy-remap.h: Add include guard.
1049         * xtensa-tdep.h: Add include guard.
1050         * xcoffread.h: Rename include guard.
1051         * varobj-iter.h: Add include guard.
1052         * tui/tui.h: Rename include guard.
1053         * tui/tui-winsource.h: Rename include guard.
1054         * tui/tui-wingeneral.h: Rename include guard.
1055         * tui/tui-windata.h: Rename include guard.
1056         * tui/tui-win.h: Rename include guard.
1057         * tui/tui-stack.h: Rename include guard.
1058         * tui/tui-source.h: Rename include guard.
1059         * tui/tui-regs.h: Rename include guard.
1060         * tui/tui-out.h: Rename include guard.
1061         * tui/tui-layout.h: Rename include guard.
1062         * tui/tui-io.h: Rename include guard.
1063         * tui/tui-hooks.h: Rename include guard.
1064         * tui/tui-file.h: Rename include guard.
1065         * tui/tui-disasm.h: Rename include guard.
1066         * tui/tui-data.h: Rename include guard.
1067         * tui/tui-command.h: Rename include guard.
1068         * tic6x-tdep.h: Add include guard.
1069         * target/waitstatus.h: Rename include guard.
1070         * target/wait.h: Rename include guard.
1071         * target/target.h: Rename include guard.
1072         * target/resume.h: Rename include guard.
1073         * target-float.h: Rename include guard.
1074         * stabsread.h: Add include guard.
1075         * rs6000-tdep.h: Add include guard.
1076         * riscv-fbsd-tdep.h: Add include guard.
1077         * regformats/regdef.h: Rename include guard.
1078         * record.h: Rename include guard.
1079         * python/python.h: Rename include guard.
1080         * python/python-internal.h: Rename include guard.
1081         * python/py-stopevent.h: Rename include guard.
1082         * python/py-ref.h: Rename include guard.
1083         * python/py-record.h: Rename include guard.
1084         * python/py-record-full.h: Rename include guard.
1085         * python/py-record-btrace.h: Rename include guard.
1086         * python/py-instruction.h: Rename include guard.
1087         * python/py-events.h: Rename include guard.
1088         * python/py-event.h: Rename include guard.
1089         * procfs.h: Add include guard.
1090         * proc-utils.h: Add include guard.
1091         * p-lang.h: Add include guard.
1092         * or1k-tdep.h: Rename include guard.
1093         * observable.h: Rename include guard.
1094         * nto-tdep.h: Rename include guard.
1095         * nat/x86-linux.h: Rename include guard.
1096         * nat/x86-linux-dregs.h: Rename include guard.
1097         * nat/x86-gcc-cpuid.h: Add include guard.
1098         * nat/x86-dregs.h: Rename include guard.
1099         * nat/x86-cpuid.h: Rename include guard.
1100         * nat/ppc-linux.h: Rename include guard.
1101         * nat/mips-linux-watch.h: Rename include guard.
1102         * nat/linux-waitpid.h: Rename include guard.
1103         * nat/linux-ptrace.h: Rename include guard.
1104         * nat/linux-procfs.h: Rename include guard.
1105         * nat/linux-osdata.h: Rename include guard.
1106         * nat/linux-nat.h: Rename include guard.
1107         * nat/linux-namespaces.h: Rename include guard.
1108         * nat/linux-btrace.h: Rename include guard.
1109         * nat/glibc_thread_db.h: Rename include guard.
1110         * nat/gdb_thread_db.h: Rename include guard.
1111         * nat/gdb_ptrace.h: Rename include guard.
1112         * nat/fork-inferior.h: Rename include guard.
1113         * nat/amd64-linux-siginfo.h: Rename include guard.
1114         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
1115         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
1116         * nat/aarch64-linux.h: Rename include guard.
1117         * nat/aarch64-linux-hw-point.h: Rename include guard.
1118         * mn10300-tdep.h: Add include guard.
1119         * mips-linux-tdep.h: Add include guard.
1120         * mi/mi-parse.h: Rename include guard.
1121         * mi/mi-out.h: Rename include guard.
1122         * mi/mi-main.h: Rename include guard.
1123         * mi/mi-interp.h: Rename include guard.
1124         * mi/mi-getopt.h: Rename include guard.
1125         * mi/mi-console.h: Rename include guard.
1126         * mi/mi-common.h: Rename include guard.
1127         * mi/mi-cmds.h: Rename include guard.
1128         * mi/mi-cmd-break.h: Rename include guard.
1129         * m2-lang.h: Add include guard.
1130         * location.h: Rename include guard.
1131         * linux-record.h: Rename include guard.
1132         * linux-nat.h: Add include guard.
1133         * linux-fork.h: Add include guard.
1134         * i386-darwin-tdep.h: Rename include guard.
1135         * hppa-linux-offsets.h: Add include guard.
1136         * guile/guile.h: Rename include guard.
1137         * guile/guile-internal.h: Rename include guard.
1138         * gnu-nat.h: Rename include guard.
1139         * gdb-stabs.h: Rename include guard.
1140         * frv-tdep.h: Add include guard.
1141         * f-lang.h: Add include guard.
1142         * event-loop.h: Add include guard.
1143         * darwin-nat.h: Rename include guard.
1144         * cp-abi.h: Rename include guard.
1145         * config/sparc/nm-sol2.h: Rename include guard.
1146         * config/nm-nto.h: Rename include guard.
1147         * config/nm-linux.h: Add include guard.
1148         * config/i386/nm-i386gnu.h: Rename include guard.
1149         * config/djgpp/nl_types.h: Rename include guard.
1150         * config/djgpp/langinfo.h: Rename include guard.
1151         * compile/gcc-cp-plugin.h: Add include guard.
1152         * compile/gcc-c-plugin.h: Add include guard.
1153         * compile/compile.h: Rename include guard.
1154         * compile/compile-object-run.h: Rename include guard.
1155         * compile/compile-object-load.h: Rename include guard.
1156         * compile/compile-internal.h: Rename include guard.
1157         * compile/compile-cplus.h: Rename include guard.
1158         * compile/compile-c.h: Rename include guard.
1159         * common/xml-utils.h: Rename include guard.
1160         * common/x86-xstate.h: Rename include guard.
1161         * common/version.h: Rename include guard.
1162         * common/vec.h: Rename include guard.
1163         * common/tdesc.h: Rename include guard.
1164         * common/selftest.h: Rename include guard.
1165         * common/scoped_restore.h: Rename include guard.
1166         * common/scoped_mmap.h: Rename include guard.
1167         * common/scoped_fd.h: Rename include guard.
1168         * common/safe-iterator.h: Rename include guard.
1169         * common/run-time-clock.h: Rename include guard.
1170         * common/refcounted-object.h: Rename include guard.
1171         * common/queue.h: Rename include guard.
1172         * common/ptid.h: Rename include guard.
1173         * common/print-utils.h: Rename include guard.
1174         * common/preprocessor.h: Rename include guard.
1175         * common/pathstuff.h: Rename include guard.
1176         * common/observable.h: Rename include guard.
1177         * common/netstuff.h: Rename include guard.
1178         * common/job-control.h: Rename include guard.
1179         * common/host-defs.h: Rename include guard.
1180         * common/gdb_wait.h: Rename include guard.
1181         * common/gdb_vecs.h: Rename include guard.
1182         * common/gdb_unlinker.h: Rename include guard.
1183         * common/gdb_unique_ptr.h: Rename include guard.
1184         * common/gdb_tilde_expand.h: Rename include guard.
1185         * common/gdb_sys_time.h: Rename include guard.
1186         * common/gdb_string_view.h: Rename include guard.
1187         * common/gdb_splay_tree.h: Rename include guard.
1188         * common/gdb_setjmp.h: Rename include guard.
1189         * common/gdb_ref_ptr.h: Rename include guard.
1190         * common/gdb_optional.h: Rename include guard.
1191         * common/gdb_locale.h: Rename include guard.
1192         * common/gdb_assert.h: Rename include guard.
1193         * common/filtered-iterator.h: Rename include guard.
1194         * common/filestuff.h: Rename include guard.
1195         * common/fileio.h: Rename include guard.
1196         * common/environ.h: Rename include guard.
1197         * common/common-utils.h: Rename include guard.
1198         * common/common-types.h: Rename include guard.
1199         * common/common-regcache.h: Rename include guard.
1200         * common/common-inferior.h: Rename include guard.
1201         * common/common-gdbthread.h: Rename include guard.
1202         * common/common-exceptions.h: Rename include guard.
1203         * common/common-defs.h: Rename include guard.
1204         * common/common-debug.h: Rename include guard.
1205         * common/cleanups.h: Rename include guard.
1206         * common/buffer.h: Rename include guard.
1207         * common/btrace-common.h: Rename include guard.
1208         * common/break-common.h: Rename include guard.
1209         * cli/cli-utils.h: Rename include guard.
1210         * cli/cli-style.h: Rename include guard.
1211         * cli/cli-setshow.h: Rename include guard.
1212         * cli/cli-script.h: Rename include guard.
1213         * cli/cli-interp.h: Rename include guard.
1214         * cli/cli-decode.h: Rename include guard.
1215         * cli/cli-cmds.h: Rename include guard.
1216         * charset-list.h: Add include guard.
1217         * buildsym-legacy.h: Rename include guard.
1218         * bfin-tdep.h: Add include guard.
1219         * ax.h: Rename include guard.
1220         * arm-linux-tdep.h: Add include guard.
1221         * arm-fbsd-tdep.h: Add include guard.
1222         * arch/xtensa.h: Rename include guard.
1223         * arch/tic6x.h: Add include guard.
1224         * arch/i386.h: Add include guard.
1225         * arch/arm.h: Rename include guard.
1226         * arch/arm-linux.h: Rename include guard.
1227         * arch/arm-get-next-pcs.h: Rename include guard.
1228         * arch/amd64.h: Add include guard.
1229         * arch/aarch64-insn.h: Rename include guard.
1230         * arch-utils.h: Rename include guard.
1231         * annotate.h: Add include guard.
1232         * amd64-darwin-tdep.h: Rename include guard.
1233         * aarch64-linux-tdep.h: Add include guard.
1234         * aarch64-fbsd-tdep.h: Add include guard.
1235         * aarch32-linux-nat.h: Add include guard.
1236
1237 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1238
1239         * macrotab.c (macro_define_internal): New function that
1240         factorizes macro_define_object_internal and macro_define_function
1241         code.
1242         (macro_define_object_internal): Use macro_define_internal.
1243         (macro_define_function): Likewise.
1244
1245 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1246
1247         * macrocmd.c (extract_identifier): Return
1248         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
1249         callers.
1250
1251 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1252
1253         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1254
1255 2019-02-05  Tom Tromey  <tom@tromey.com>
1256
1257         * target.c (target_stack::unpush): Move assertion earlier.
1258
1259 2019-01-30  Tom Tromey  <tom@tromey.com>
1260
1261         PR python/23615:
1262         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1263         (gdbpy_parse_and_eval): Likewise.
1264         * python/python-internal.h (gdbpy_allow_threads): New class.
1265
1266 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1267
1268         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1269         (aarch64_fbsd_fpregmap): Move earlier.
1270         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1271         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1272         instead of individual calls to trad_frame_set_reg_addr.
1273         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1274         earlier.
1275         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1276         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1277         instead of individual calls to trad_frame_set_reg_addr.
1278
1279 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1280
1281         * CONTRIBUTE: Replace contribution list with wiki link.
1282
1283 2019-01-25  Tom Tromey  <tom@tromey.com>
1284
1285         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1286
1287 2019-01-25  Tom Tromey  <tom@tromey.com>
1288
1289         * xtensa-linux-nat.c: Fix common/ includes.
1290         * xml-support.h: Fix common/ includes.
1291         * xml-support.c: Fix common/ includes.
1292         * x86-linux-nat.c: Fix common/ includes.
1293         * windows-nat.c: Fix common/ includes.
1294         * varobj.h: Fix common/ includes.
1295         * varobj.c: Fix common/ includes.
1296         * value.c: Fix common/ includes.
1297         * valops.c: Fix common/ includes.
1298         * utils.c: Fix common/ includes.
1299         * unittests/xml-utils-selftests.c: Fix common/ includes.
1300         * unittests/utils-selftests.c: Fix common/ includes.
1301         * unittests/unpack-selftests.c: Fix common/ includes.
1302         * unittests/tracepoint-selftests.c: Fix common/ includes.
1303         * unittests/style-selftests.c: Fix common/ includes.
1304         * unittests/string_view-selftests.c: Fix common/ includes.
1305         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1306         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1307         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1308         * unittests/rsp-low-selftests.c: Fix common/ includes.
1309         * unittests/parse-connection-spec-selftests.c: Fix common/
1310         includes.
1311         * unittests/optional-selftests.c: Fix common/ includes.
1312         * unittests/offset-type-selftests.c: Fix common/ includes.
1313         * unittests/observable-selftests.c: Fix common/ includes.
1314         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1315         * unittests/memrange-selftests.c: Fix common/ includes.
1316         * unittests/memory-map-selftests.c: Fix common/ includes.
1317         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1318         * unittests/function-view-selftests.c: Fix common/ includes.
1319         * unittests/environ-selftests.c: Fix common/ includes.
1320         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1321         * unittests/common-utils-selftests.c: Fix common/ includes.
1322         * unittests/cli-utils-selftests.c: Fix common/ includes.
1323         * unittests/array-view-selftests.c: Fix common/ includes.
1324         * ui-file.c: Fix common/ includes.
1325         * tui/tui-io.c: Fix common/ includes.
1326         * tracepoint.h: Fix common/ includes.
1327         * tracepoint.c: Fix common/ includes.
1328         * tracefile-tfile.c: Fix common/ includes.
1329         * top.h: Fix common/ includes.
1330         * top.c: Fix common/ includes.
1331         * thread.c: Fix common/ includes.
1332         * target/waitstatus.h: Fix common/ includes.
1333         * target/waitstatus.c: Fix common/ includes.
1334         * target.h: Fix common/ includes.
1335         * target.c: Fix common/ includes.
1336         * target-memory.c: Fix common/ includes.
1337         * target-descriptions.c: Fix common/ includes.
1338         * symtab.h: Fix common/ includes.
1339         * symfile.c: Fix common/ includes.
1340         * stap-probe.c: Fix common/ includes.
1341         * spu-linux-nat.c: Fix common/ includes.
1342         * sparc-nat.c: Fix common/ includes.
1343         * source.c: Fix common/ includes.
1344         * solib.c: Fix common/ includes.
1345         * solib-target.c: Fix common/ includes.
1346         * ser-unix.c: Fix common/ includes.
1347         * ser-tcp.c: Fix common/ includes.
1348         * ser-pipe.c: Fix common/ includes.
1349         * ser-base.c: Fix common/ includes.
1350         * selftest-arch.c: Fix common/ includes.
1351         * s12z-tdep.c: Fix common/ includes.
1352         * rust-exp.y: Fix common/ includes.
1353         * rs6000-aix-tdep.c: Fix common/ includes.
1354         * riscv-tdep.c: Fix common/ includes.
1355         * remote.c: Fix common/ includes.
1356         * remote-notif.h: Fix common/ includes.
1357         * remote-fileio.h: Fix common/ includes.
1358         * remote-fileio.c: Fix common/ includes.
1359         * regcache.h: Fix common/ includes.
1360         * regcache.c: Fix common/ includes.
1361         * record-btrace.c: Fix common/ includes.
1362         * python/python.c: Fix common/ includes.
1363         * python/py-type.c: Fix common/ includes.
1364         * python/py-inferior.c: Fix common/ includes.
1365         * progspace.h: Fix common/ includes.
1366         * producer.c: Fix common/ includes.
1367         * procfs.c: Fix common/ includes.
1368         * proc-api.c: Fix common/ includes.
1369         * printcmd.c: Fix common/ includes.
1370         * ppc-linux-nat.c: Fix common/ includes.
1371         * parser-defs.h: Fix common/ includes.
1372         * osdata.c: Fix common/ includes.
1373         * obsd-nat.c: Fix common/ includes.
1374         * nat/x86-linux.c: Fix common/ includes.
1375         * nat/x86-linux-dregs.c: Fix common/ includes.
1376         * nat/x86-dregs.h: Fix common/ includes.
1377         * nat/x86-dregs.c: Fix common/ includes.
1378         * nat/ppc-linux.c: Fix common/ includes.
1379         * nat/mips-linux-watch.h: Fix common/ includes.
1380         * nat/mips-linux-watch.c: Fix common/ includes.
1381         * nat/linux-waitpid.c: Fix common/ includes.
1382         * nat/linux-ptrace.h: Fix common/ includes.
1383         * nat/linux-ptrace.c: Fix common/ includes.
1384         * nat/linux-procfs.c: Fix common/ includes.
1385         * nat/linux-personality.c: Fix common/ includes.
1386         * nat/linux-osdata.c: Fix common/ includes.
1387         * nat/linux-namespaces.c: Fix common/ includes.
1388         * nat/linux-btrace.h: Fix common/ includes.
1389         * nat/linux-btrace.c: Fix common/ includes.
1390         * nat/fork-inferior.c: Fix common/ includes.
1391         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1392         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1393         * nat/aarch64-linux.c: Fix common/ includes.
1394         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1395         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1396         * namespace.h: Fix common/ includes.
1397         * mips-linux-tdep.c: Fix common/ includes.
1398         * minsyms.c: Fix common/ includes.
1399         * mi/mi-parse.h: Fix common/ includes.
1400         * mi/mi-main.c: Fix common/ includes.
1401         * mi/mi-cmd-env.c: Fix common/ includes.
1402         * memrange.h: Fix common/ includes.
1403         * memattr.c: Fix common/ includes.
1404         * maint.h: Fix common/ includes.
1405         * maint.c: Fix common/ includes.
1406         * main.c: Fix common/ includes.
1407         * machoread.c: Fix common/ includes.
1408         * location.c: Fix common/ includes.
1409         * linux-thread-db.c: Fix common/ includes.
1410         * linux-nat.c: Fix common/ includes.
1411         * linux-fork.c: Fix common/ includes.
1412         * inline-frame.c: Fix common/ includes.
1413         * infrun.c: Fix common/ includes.
1414         * inflow.c: Fix common/ includes.
1415         * inferior.h: Fix common/ includes.
1416         * inferior.c: Fix common/ includes.
1417         * infcmd.c: Fix common/ includes.
1418         * inf-ptrace.c: Fix common/ includes.
1419         * inf-child.c: Fix common/ includes.
1420         * ia64-linux-nat.c: Fix common/ includes.
1421         * i387-tdep.c: Fix common/ includes.
1422         * i386-tdep.c: Fix common/ includes.
1423         * i386-linux-tdep.c: Fix common/ includes.
1424         * i386-linux-nat.c: Fix common/ includes.
1425         * i386-go32-tdep.c: Fix common/ includes.
1426         * i386-fbsd-tdep.c: Fix common/ includes.
1427         * i386-fbsd-nat.c: Fix common/ includes.
1428         * guile/scm-type.c: Fix common/ includes.
1429         * guile/guile.c: Fix common/ includes.
1430         * go32-nat.c: Fix common/ includes.
1431         * gnu-nat.c: Fix common/ includes.
1432         * gdbthread.h: Fix common/ includes.
1433         * gdbarch-selftests.c: Fix common/ includes.
1434         * gdb_usleep.c: Fix common/ includes.
1435         * gdb_select.h: Fix common/ includes.
1436         * gdb_bfd.c: Fix common/ includes.
1437         * gcore.c: Fix common/ includes.
1438         * fork-child.c: Fix common/ includes.
1439         * findvar.c: Fix common/ includes.
1440         * fbsd-nat.c: Fix common/ includes.
1441         * event-top.c: Fix common/ includes.
1442         * event-loop.c: Fix common/ includes.
1443         * dwarf2read.c: Fix common/ includes.
1444         * dwarf2loc.c: Fix common/ includes.
1445         * dwarf2-frame.c: Fix common/ includes.
1446         * dwarf-index-cache.c: Fix common/ includes.
1447         * dtrace-probe.c: Fix common/ includes.
1448         * disasm-selftests.c: Fix common/ includes.
1449         * defs.h: Fix common/ includes.
1450         * csky-tdep.c: Fix common/ includes.
1451         * cp-valprint.c: Fix common/ includes.
1452         * cp-support.h: Fix common/ includes.
1453         * cp-support.c: Fix common/ includes.
1454         * corelow.c: Fix common/ includes.
1455         * completer.h: Fix common/ includes.
1456         * completer.c: Fix common/ includes.
1457         * compile/compile.c: Fix common/ includes.
1458         * compile/compile-loc2c.c: Fix common/ includes.
1459         * compile/compile-cplus-types.c: Fix common/ includes.
1460         * compile/compile-cplus-symbols.c: Fix common/ includes.
1461         * command.h: Fix common/ includes.
1462         * cli/cli-dump.c: Fix common/ includes.
1463         * cli/cli-cmds.c: Fix common/ includes.
1464         * charset.c: Fix common/ includes.
1465         * build-id.c: Fix common/ includes.
1466         * btrace.h: Fix common/ includes.
1467         * btrace.c: Fix common/ includes.
1468         * breakpoint.h: Fix common/ includes.
1469         * breakpoint.c: Fix common/ includes.
1470         * ax.h: 
1471         (enum agent_op): Fix common/ includes.
1472         * ax-general.c (struct aop_map): Fix common/ includes.
1473         * ax-gdb.c: Fix common/ includes.
1474         * auxv.c: Fix common/ includes.
1475         * auto-load.c: Fix common/ includes.
1476         * arm-tdep.c: Fix common/ includes.
1477         * arch/riscv.c: Fix common/ includes.
1478         * arch/ppc-linux-common.c: Fix common/ includes.
1479         * arch/i386.c: Fix common/ includes.
1480         * arch/arm.c: Fix common/ includes.
1481         * arch/arm-linux.c: Fix common/ includes.
1482         * arch/arm-get-next-pcs.c: Fix common/ includes.
1483         * arch/amd64.c: Fix common/ includes.
1484         * arch/aarch64.c: Fix common/ includes.
1485         * arch/aarch64-insn.c: Fix common/ includes.
1486         * arch-utils.c: Fix common/ includes.
1487         * amd64-windows-tdep.c: Fix common/ includes.
1488         * amd64-tdep.c: Fix common/ includes.
1489         * amd64-sol2-tdep.c: Fix common/ includes.
1490         * amd64-obsd-tdep.c: Fix common/ includes.
1491         * amd64-nbsd-tdep.c: Fix common/ includes.
1492         * amd64-linux-tdep.c: Fix common/ includes.
1493         * amd64-linux-nat.c: Fix common/ includes.
1494         * amd64-fbsd-tdep.c: Fix common/ includes.
1495         * amd64-fbsd-nat.c: Fix common/ includes.
1496         * amd64-dicos-tdep.c: Fix common/ includes.
1497         * amd64-darwin-tdep.c: Fix common/ includes.
1498         * agent.c: Fix common/ includes.
1499         * ada-lang.h: Fix common/ includes.
1500         * ada-lang.c: Fix common/ includes.
1501         * aarch64-tdep.c: Fix common/ includes.
1502
1503 2019-01-25  Tom Tromey  <tom@tromey.com>
1504
1505         * common/create-version.sh: Use common/version.h.
1506
1507 2019-01-24  Pedro Alves  <palves@redhat.com>
1508
1509         * infrun.c (signal_stop, signal_print, signal_program)
1510         (signal_catch, signal_pass): Now arrays instead of pointers.
1511         (update_signals_program_target, do_target_resume)
1512         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1513         * linux-nat.c (linux_nat_target::pass_signals)
1514         (linux_nat_target::create_inferior, linux_nat_target::attach):
1515         Adjust.
1516         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1517         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1518         * procfs.c (procfs_target::pass_signals): Adjust.
1519         * record-full.c (record_full_target::resume): Adjust.
1520         * remote.c (remote_target::pass_signals)
1521         (remote_target::program_signals): Adjust.
1522         * target-debug.h (target_debug_print_signals): Now takes a
1523         gdb::array_view as parameter.  Adjust.
1524         * target.h (target_ops) <pass_signals, program_signals>: Replace
1525         pointer and length parameters with gdb::array_view.
1526         (target_pass_signals, target_program_signals): Likewise.
1527         * target-delegates.c: Regenerate.
1528
1529 2019-01-24  Pedro Alves  <palves@redhat.com>
1530
1531         * common/forward-scope-exit.h
1532         (forward_scope_exit::forward_scope_exit): Pass arguments to
1533         m_bind_function directly, instead of creating a std::bind and
1534         copying that.
1535
1536 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1537
1538         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1539         for static members.
1540         (pass_in_v_vfp_candidate): Likewise.
1541
1542 2019-01-23  Tom Tromey  <tom@tromey.com>
1543             Pedro Alves  <palves@redhat.com>
1544
1545         * regcache.c (class regcache_invalidator): Remove.
1546         (regcache::raw_write): Use make_scope_exit.
1547
1548 2019-01-23  Tom Tromey  <tom@tromey.com>
1549
1550         * ui-out.h (class ui_out_emit_type): Update comment.
1551
1552 2019-01-23  Tom Tromey  <tom@tromey.com>
1553
1554         * infrun.c (fetch_inferior_event): Update comment.
1555
1556 2019-01-23  Tom Tromey  <tom@tromey.com>
1557             Pedro Alves  <palves@redhat.com>
1558
1559         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1560         parameter.
1561         (fetch_inferior_event): Use SCOPE_EXIT.
1562
1563
1564 2019-01-23  Tom Tromey  <tom@tromey.com>
1565             Pedro Alves  <palves@redhat.com>
1566
1567         * infrun.c (disable_thread_events): Delete.
1568         (stop_all_threads): Use SCOPE_EXIT.
1569
1570 2019-01-23  Tom Tromey  <tom@tromey.com>
1571             Pedro Alves  <palves@redhat.com>
1572
1573         * symfile.c: Include forward-scope-exit.h.
1574         (clear_symtab_users_cleanup): Replace forward declaration with
1575         a FORWARD_SCOPE_EXIT.
1576         (syms_from_objfile_1): Use the forward_scope_exit and
1577         gdb::optional instead of cleanup_function.
1578         (reread_symbols): Use the forward_scope_exit instead of
1579         cleanup_function.
1580         (clear_symtab_users_cleanup): Remove function.
1581
1582 2019-01-23  Tom Tromey  <tom@tromey.com>
1583             Pedro Alves  <palves@redhat.com>
1584
1585         * linux-nat.c: Include scope-exit.h.
1586         (cleanup_target_stop): Remove.
1587         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1588         SCOPE_EXIT.
1589
1590 2019-01-23  Tom Tromey  <tom@tromey.com>
1591             Pedro Alves  <palves@redhat.com>
1592
1593         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1594         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1595
1596 2019-01-23  Tom Tromey  <tom@tromey.com>
1597             Andrew Burgess  <andrew.burgess@embecosm.com>
1598             Pedro Alves  <palves@redhat.com>
1599
1600         * infrun.c (fetch_inferior_event): Use scope_exit.
1601         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1602         * top.c (execute_command): Use scope_exit.
1603         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1604         * utils.c (do_bpstat_clear_actions_cleanup)
1605         (make_bpstat_clear_actions_cleanup): Remove.
1606
1607 2019-01-23  Tom Tromey  <tom@tromey.com>
1608             Pedro Alves  <palves@redhat.com>
1609
1610         * infrun.c: Include "common/scope-exit.h"
1611         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1612         (wait_for_inferior): Use SCOPE_EXIT.
1613         (fetch_inferior_event): Use scope_exit.
1614
1615 2019-01-23  Tom Tromey  <tom@tromey.com>
1616             Pedro Alves  <palves@redhat.com>
1617
1618         * breakpoint.c (create_breakpoint): Remove cleanup.
1619
1620 2019-01-23  Tom Tromey  <tom@tromey.com>
1621             Andrew Burgess  <andrew.burgess@embecosm.com>
1622             Pedro Alves  <palves@redhat.com>
1623
1624 2019-01-23  Pedro Alves  <palves@redhat.com>
1625
1626         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1627
1628 2019-01-23  Pedro Alves  <palves@redhat.com>
1629             Andrew Burgess  <andrew.burgess@embecosm.com>
1630
1631         * gdbthread.h: Include "common/forward-scope-exit.h".
1632         (scoped_finish_thread_state): Redefine custom class in terms of
1633         forward_scope_exit.
1634
1635 2019-01-23  Pedro Alves  <palves@redhat.com>
1636             Andrew Burgess  <andrew.burgess@embecosm.com>
1637
1638         * common/forward-scope-exit.h: New file.
1639
1640 2019-01-23  Pedro Alves  <palves@redhat.com>
1641             Andrew Burgess  <andrew.burgess@embecosm.com>
1642             Tom Tromey  <tom@tromey.com>
1643
1644         * common/scope-exit.h: New file.
1645
1646 2019-01-23  Pedro Alves  <palves@redhat.com>
1647
1648         * common/preprocessor.h (ESC): Rename to ...
1649         (ESC_PARENS): ... this.
1650         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1651         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1652
1653 2019-01-23  Tom Tromey  <tom@tromey.com>
1654
1655         * language.h (class scoped_switch_to_sym_language_if_auto):
1656         Initialize m_lang in both cases.
1657
1658 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1659
1660         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1661         with XCNEW.
1662
1663 2019-01-22  Tom Tromey  <tom@tromey.com>
1664
1665         * corelow.c: Do not include sys/file.h.
1666
1667 2019-01-22  Tom Tromey  <tom@tromey.com>
1668
1669         * tui/tui-wingeneral.h: Include gdb_curses.h.
1670
1671 2019-01-22  Tom Tromey  <tom@tromey.com>
1672
1673         * source-cache.h (class source_cache) <get_source_lines,
1674         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1675
1676 2019-01-22  Tom Tromey  <tom@tromey.com>
1677
1678         * remote-fileio.h (struct remote_target): Declare.
1679
1680 2019-01-22  Tom Tromey  <tom@tromey.com>
1681
1682         * python/py-arch.c: Do not include py-ref.h.
1683         * python/py-bpevent.c: Do not include py-ref.h.
1684         * python/py-cmd.c: Do not include py-ref.h.
1685         * python/py-continueevent.c: Do not include py-ref.h.
1686         * python/py-event.h: Do not include py-ref.h.
1687         * python/py-evtregistry.c: Do not include py-ref.h.
1688         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1689         * python/py-frame.c: Do not include py-ref.h.
1690         * python/py-framefilter.c: Do not include py-ref.h.
1691         * python/py-function.c: Do not include py-ref.h.
1692         * python/py-infevents.c: Do not include py-ref.h.
1693         * python/py-linetable.c: Do not include py-ref.h.
1694         * python/py-objfile.c: Do not include py-ref.h.
1695         * python/py-param.c: Do not include py-ref.h.
1696         * python/py-prettyprint.c: Do not include py-ref.h.
1697         * python/py-progspace.c: Do not include py-ref.h.
1698         * python/py-symbol.c: Do not include py-ref.h.
1699         * python/py-symtab.c: Do not include py-ref.h.
1700         * python/py-type.c: Do not include py-ref.h.
1701         * python/py-unwind.c: Do not include py-ref.h.
1702         * python/py-utils.c: Do not include py-ref.h.
1703         * python/py-value.c: Do not include py-ref.h.
1704         * python/py-varobj.c: Do not include py-ref.h.
1705         * python/py-xmethods.c: Do not include py-ref.h.
1706         * python/python.c: Do not include py-ref.h.
1707         * varobj.c: Do not include py-ref.h.
1708
1709 2019-01-22  Tom Tromey  <tom@tromey.com>
1710
1711         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1712         keyword for bcache.
1713
1714 2019-01-22  Tom Tromey  <tom@tromey.com>
1715
1716         * compile/compile-cplus-types.c: Remove a comment by #include.
1717
1718 2019-01-22  Tom Tromey  <tom@tromey.com>
1719
1720         * compile/gcc-c-plugin.h: Include compile-internal.h.
1721
1722 2019-01-22  Tom Tromey  <tom@tromey.com>
1723
1724         * stabsread.c (EXTERN): Do not define.
1725         (symnum, next_symbol_text_func, processing_gcc_compilation)
1726         (within_function, global_sym_chain, global_stabs)
1727         (previous_stab_code, this_object_header_files)
1728         (n_this_object_header_files)
1729         (n_allocated_this_object_header_files): Define.
1730         * stabsread.h (EXTERN): Never define.  Use "extern".
1731
1732 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1733
1734         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1735         history_value.
1736
1737 2019-01-21  Tom Tromey  <tom@tromey.com>
1738
1739         * ui-out.c: Fix includes.
1740         * tui/tui-source.c: Fix includes.
1741         * target.c: Fix includes.
1742         * remote.c: Fix includes.
1743         * regcache.c: Fix includes.
1744         * python/py-block.c: Fix includes.
1745         * printcmd.c: Fix includes.
1746         * or1k-tdep.c: Fix includes.
1747         * mi/mi-main.c: Fix includes.
1748         * m32r-tdep.c: Fix includes.
1749         * csky-tdep.c: Fix includes.
1750         * compile/compile-cplus-types.c: Fix includes.
1751         * cli/cli-interp.c: Fix includes.
1752
1753 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1754
1755         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1756         for padding.
1757
1758 2019-01-16  Tom Tromey  <tom@tromey.com>
1759
1760         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1761         earlier.
1762         (struct objfile) <msymbols_range>: Move from top level.
1763         <msymbols>: New method.
1764         (class objfile_msymbols): Remove.
1765         * symtab.c (default_collect_symbol_completion_matches_break_on):
1766         Update.
1767         * symmisc.c (dump_msymbols): Update.
1768         * stabsread.c (scan_file_globals): Update.
1769         * objc-lang.c (info_selectors_command, info_classes_command)
1770         (find_methods): Update.
1771         * minsyms.c (find_solib_trampoline_target): Update.
1772         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1773         * coffread.c (coff_symfile_read): Update.
1774         * ada-lang.c (ada_lookup_simple_minsym)
1775         (ada_collect_symbol_completion_matches): Update.
1776
1777 2019-01-16  Tom Tromey  <tom@tromey.com>
1778
1779         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1780         type.  Remove no-argument constructor.
1781         <iterator::operator++>: Simplify.
1782         <begin>: Update.
1783         <end>: Use minimal_symbol_count.
1784
1785 2019-01-16  Tom Tromey  <tom@tromey.com>
1786
1787         * objfiles.h (struct objfile) <psymtabs>: New method.
1788         (class objfile_psymtabs): Remove.
1789         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1790         typedef.
1791         <range>: New method.
1792         (require_partial_symbols): Change return type.
1793         * psymtab.c (require_partial_symbols)
1794         (psym_expand_symtabs_matching): Update.
1795         * mdebugread.c (parse_partial_symbols): Update.
1796         * dbxread.c (dbx_end_psymtab): Update.
1797
1798 2019-01-15  Tom Tromey  <tom@tromey.com>
1799
1800         * symtab.c (lookup_objfile_from_block)
1801         (lookup_symbol_in_objfile_symtabs)
1802         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1803         (find_line_symtab, info_sources_command)
1804         (default_collect_symbol_completion_matches_break_on)
1805         (make_source_files_completion_list): Update.
1806         * symmisc.c (print_objfile_statistics, dump_objfile)
1807         (maintenance_print_symbols, maintenance_info_symtabs)
1808         (maintenance_check_symtabs, maintenance_info_line_tables):
1809         Update.
1810         * source.c (select_source_symtab)
1811         (forget_cached_source_info_for_objfile): Update.
1812         * objfiles.h (class objfile_compunits): Remove.
1813         (struct objfile) <compunits_range>: New typedef.
1814         (compunits): New method.
1815         * objfiles.c (objfile_relocate1): Update.
1816         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1817         * maint.c (count_symtabs_and_blocks): Update.
1818         * linespec.c (iterate_over_all_matching_symtabs): Update.
1819         * cp-support.c (add_symbol_overload_list_qualified): Update.
1820         * coffread.c (coff_symtab_read): Update.
1821         * ada-lang.c (add_nonlocal_symbols)
1822         (ada_collect_symbol_completion_matches)
1823         (ada_add_global_exceptions): Update.
1824
1825 2019-01-15  Tom Tromey  <tom@tromey.com>
1826
1827         * progspace.h (program_space) <objfiles_safe_range>: New
1828         typedef.
1829         <objfiles_safe>: New method.
1830         * objfiles.h (class all_objfiles_safe): Remove.
1831         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1832         * jit.c (jit_inferior_exit_hook): Update.
1833
1834 2019-01-17  Tom Tromey  <tom@tromey.com>
1835
1836         * progspace.h (program_space) <objfiles_range>: New typedef.
1837         <objfiles>: New method.
1838         <objfiles_head>: Rename from objfiles.
1839         (object_files): Update.
1840         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1841         * guile/scm-pretty-print.c
1842         (ppscm_find_pretty_printer_from_objfiles): Update.
1843         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1844         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1845         Update.
1846         * python/py-progspace.c (pspy_get_objfiles): Update.
1847         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1848         Update.
1849         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1850         (objfpy_lookup_objfile_by_build_id): Update.
1851         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1852         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1853         Update.
1854         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1855         (expand_symtab_containing_pc, lookup_objfile_from_block)
1856         (lookup_static_symbol, basic_lookup_transparent_type)
1857         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1858         (find_line_symtab, info_sources_command)
1859         (default_collect_symbol_completion_matches_break_on)
1860         (make_source_files_completion_list, find_main_name): Update.
1861         * symmisc.c (print_symbol_bcache_statistics)
1862         (print_objfile_statistics, maintenance_print_symbols)
1863         (maintenance_print_msymbols, maintenance_print_objfiles)
1864         (maintenance_info_symtabs, maintenance_check_symtabs)
1865         (maintenance_expand_symtabs, maintenance_info_line_tables):
1866         Update.
1867         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1868         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1869         (map_overlay_command, unmap_overlay_command)
1870         (simple_overlay_update, expand_symtabs_matching)
1871         (map_symbol_filenames): Update.
1872         * symfile-debug.c (set_debug_symfile): Update.
1873         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1874         Update.
1875         * source.c (select_source_symtab, forget_cached_source_info):
1876         Update.
1877         * solib.c (solib_read_symbols): Update.
1878         * solib-spu.c (append_ocl_sos): Update.
1879         * psymtab.c (maintenance_print_psymbols)
1880         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1881         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1882         * printcmd.c (info_symbol_command): Update.
1883         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1884         Update.
1885         * objfiles.h (class all_objfiles): Remove.
1886         * objfiles.c (have_partial_symbols, have_full_symbols)
1887         (have_minimal_symbols, qsort_cmp, update_section_map)
1888         (shared_objfile_contains_address_p)
1889         (default_iterate_over_objfiles_in_search_order): Update.
1890         * objc-lang.c (info_selectors_command, info_classes_command)
1891         (find_methods): Update.
1892         * minsyms.c (find_solib_trampoline_target): Update.
1893         * maint.c (maintenance_info_sections)
1894         (maintenance_translate_address, count_symtabs_and_blocks):
1895         Update.
1896         * main.c (captured_main_1): Update.
1897         * linux-thread-db.c (try_thread_db_load_from_pdir)
1898         (has_libpthread): Update.
1899         * linespec.c (iterate_over_all_matching_symtabs)
1900         (search_minsyms_for_name): Update.
1901         * jit.c (jit_find_objf_with_entry_addr): Update.
1902         * hppa-tdep.c (find_unwind_entry)
1903         (hppa_lookup_stub_minimal_symbol): Update.
1904         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1905         Update.
1906         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1907         (elf_gnu_ifunc_resolve_by_got): Update.
1908         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1909         * dwarf-index-write.c (save_gdb_index_command): Update.
1910         * cp-support.c (add_symbol_overload_list_qualified): Update.
1911         * breakpoint.c (create_overlay_event_breakpoint)
1912         (create_longjmp_master_breakpoint)
1913         (create_std_terminate_master_breakpoint)
1914         (create_exception_master_breakpoint): Update.
1915         * blockframe.c (find_pc_partial_function): Update.
1916         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1917         (ada_collect_symbol_completion_matches)
1918         (ada_add_global_exceptions): Update.
1919
1920 2019-01-17  Tom Tromey  <tom@tromey.com>
1921
1922         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1923         declare VEC.
1924         (solib_target_parse_libraries): Change return type.
1925         (library_list_start_segment, library_list_start_section)
1926         (library_list_end_library, library_list_start_library); Update.
1927         (solib_target_free_library_list): Remove.
1928         (solib_target_parse_libraries): Remove cleanup.  Change return
1929         type.
1930         (solib_target_current_sos): Update.
1931
1932 2019-01-17  Tom Tromey  <tromey@bapiya>
1933
1934         * valprint.c: Replace "the the" with "the".
1935         * symtab.c: Replace "the the" with "the".
1936         * solib.c: Replace "the the" with "the".
1937         * solib-dsbt.c: Replace "the the" with "the".
1938         * linespec.c: Replace "the the" with "the".
1939         * dwarf2loc.h: Replace "the the" with "the".
1940         * amd64-windows-tdep.c: Replace "the the" with "the".
1941         * aarch64-tdep.c: Replace "the the" with "the".
1942
1943 2019-01-16  Keith Seitz  <keiths@redhat.com>
1944
1945         PR gdb/23773
1946         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1947         <builder>: Rename to ..
1948         <m_builder>: ... this and make private.
1949         (dwarf2_cu::get_builder): New method.  Change all users of
1950         `builder' to use this method.
1951         (dwarf2_start_symtab): Move to ...
1952         (dwarf2_cu::start_symtab): ... here.  Update all callers
1953         (setup_type_unit_groups): Move to ...
1954         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1955         callers.
1956         (dwarf2_cu::reset_builder): New method.
1957         (process_full_compunit, process_full_type_unit): Use
1958         dwarf2_cu::reset_builder.
1959         (follow_die_offset): Record the ancestor CU if it is different
1960         from the followed DIE's CU.
1961         (follow_die_sig_1): Likewise.
1962
1963 2019-01-15  Tom Tromey  <tom@tromey.com>
1964
1965         * remote.c (class remote_state) <buf>: Now a char_vector.
1966         <buf_size>: Remove.
1967         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1968         parameter.
1969         (remote_target::getpkt_or_notif_sane_1)
1970         (remote_target::getpkt_sane)
1971         (remote_target::getpkt_or_notif_sane): Likewise.
1972         (class remote_target) <putpkt>: New overload.
1973         (remote_target::read_frame): Change type of "buf_p".  Remove
1974         sizeof_p parameter.
1975         (packet_ok): New overload.
1976         (packet_check_result): New overload.
1977         Update all uses.
1978
1979 2019-01-14  Tom Tromey  <tom@tromey.com>
1980
1981         * remote-notif.c (handle_notification, remote_notif_ack)
1982         (remote_notif_parse): Make "buf" const.
1983         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1984         const.
1985         (remote_notif_parse, remote_notif_ack, handle_notification):
1986         Likewise.
1987         * remote.c (remote_notif_stop_parse): Make "buf" const.
1988         (remote_target::remote_parse_stop_reply): Make "buf" const.
1989         (remote_notif_stop_ack): Make "buf" const.
1990
1991 2019-01-14  Tom Tromey  <tom@tromey.com>
1992
1993         * remote.c (remote_console_output): Make parameter const.
1994
1995 2019-01-14  Tom Tromey  <tom@tromey.com>
1996
1997         * target-debug.h (target_debug_print_signals): Constify.
1998         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1999         * procfs.c (procfs_target::pass_signals): Update.
2000         * linux-nat.c (linux_nat_target::pass_signals): Update.
2001         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
2002         * target-delegates.c: Rebuild.
2003         * remote.c (remote_target::program_signals): Update.
2004         (remote_target::pass_signals): Update.
2005         * target.c (target_pass_signals): Constify argument.
2006         (target_program_signals): Likewise.
2007         * target.h (struct target_ops) <pass_signals, program_signals>:
2008         Constify argument.
2009         (target_pass_signals, target_program_signals): Constify argument.
2010
2011 2019-01-14  Tom Tromey  <tom@tromey.com>
2012
2013         PR tui/28819:
2014         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
2015
2016 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2017
2018         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
2019         field.
2020         * rs6000-tdep.c: Include reggroups.h.
2021         (IS_V_ALIAS_PSEUDOREG): Define.
2022         (rs6000_register_name): Return names for the "vX" aliases.
2023         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
2024         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
2025         aliases.  Call default_register_reggroup_p for all other
2026         pseudo-registers.
2027         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
2028         New functions.
2029         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
2030         Handle "vX" aliases.
2031         (v_alias_pseudo_register_collect): New function.
2032         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
2033         (rs6000_gdbarch_init): Initialize "vX" aliases as
2034         pseudo-registers.  Restore registration of
2035         rs6000_pseudo_register_reggroup_p with
2036         set_tdesc_pseudo_register_reggroup_p.
2037
2038 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
2039
2040         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
2041         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
2042         set_gdbarch_num_pseudo_regs.
2043
2044 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2045
2046         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
2047         Remove arg prefixname, add do_set and do_show.
2048         Add member functions set_list and show_list.
2049         * cli/cli-style.c (class cli_style_option): Update accordingly.
2050         (style_set_list): Move to file scope.
2051         (style_show_list): Likewise.
2052         (set_style): Call help_list.
2053         (show_style): Call cmd_show_list.
2054         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
2055         Update to use the new macro.
2056
2057 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
2058
2059         * ada-lang.c (_initialize_ada_language): Expand the help text
2060         for the "catch exception" command.
2061
2062 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2063
2064         * symtab.c (matching_obj_sections): Initialize obj,
2065         declare it closer to its usage.
2066
2067 2019-01-10  Tom Tromey  <tom@tromey.com>
2068
2069         * thread-iter.h (inf_threads_iterator): Use next_iterator.
2070         (basic_inf_threads_range): Remove.
2071         (inf_threads_range, inf_non_exited_threads_range)
2072         (safe_inf_threads_range): Use next_adapter.
2073
2074 2019-01-10  Keith Seitz  <keiths@redhat.com>
2075
2076         PR gdb/23712
2077         PR symtab/23010
2078         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
2079         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
2080
2081 2019-01-10  Keith Seitz  <keiths@redhat.com>
2082
2083         PR gdb/23712
2084         PR symtab/23010
2085         * dictionary.c (pending_to_vector): Remove.
2086         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2087         Remove _1 suffix, replacing functions of the same name.  Update
2088         all callers.
2089         (dict_create_hashed, dict_create_hashed_expandable)
2090         (dict_create_linear, dict_create_linear_expandable, dict_free)
2091         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
2092         Make functions static.
2093
2094 2019-01-10  Keith Seitz  <keiths@redhat.com>
2095
2096         PR gdb/23712
2097         PR symtab/23010
2098         * dictionary.h (struct dictionary): Replace declaration with
2099         multidictionary.
2100         (dict_create_hashed, dict_create_hashed_expandable)
2101         (dict_create_linear, dict_create_linear_expandable)
2102         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
2103         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
2104         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
2105         taking multidictionary argument.
2106         [ALL_DICT_SYMBOLS]: Update for multidictionary.
2107         * block.h (struct block) <dict>: Change to multidictionary
2108         and rename `multidict'.
2109         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
2110         symmisc.c: Update all dictionary references to multidictionary.
2111
2112 2019-01-10  Keith Seitz  <keiths@redhat.com>
2113
2114         PR gdb/23712
2115         PR symtab/23010
2116         * dictionary.c: Include unordered_map.
2117         (pending_to_vector): New function.
2118         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2119         Rewrite the non-"_1" functions to take vector instead
2120         of linked list.
2121         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
2122         "new" _1 versions of the same name.
2123         (multidictionary): Define.
2124         (std::hash<enum language): New definition.
2125         (collate_pending_symbols_by_language, mdict_create_hashed)
2126         (mdict_create_hashed_expandable, mdict_create_linear)
2127         (mdict_create_linear_expandable, mdict_free)
2128         (find_language_dictionary, create_new_language_dictionary)
2129         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
2130         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
2131         (mdict_size, mdict_empty): New functions.
2132         * dictionary.h (mdict_iterator): Define.
2133
2134 2019-01-10  Pedro Alves  <palves@redhat.com>
2135
2136         * breakpoint.c (read_uploaded_action)
2137         (create_tracepoint_from_upload): Adjust to use
2138         gdb::unique_xmalloc_ptr.
2139         * ctf.c (ctf_write_uploaded_tp):
2140         (SET_ARRAY_FIELD): Use emplace_back.
2141         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
2142         * tracefile-tfile.c (tfile_write_uploaded_tp):
2143         * tracepoint.c (parse_tracepoint_definition): Adjust to use
2144         gdb::unique_xmalloc_ptr.
2145         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
2146         at_string, cond_string, cmd_strings>: Replace char pointers
2147         with gdb::unique_xmalloc_ptr.
2148
2149 2019-01-10  Pedro Alves  <palves@redhat.com>
2150
2151         * solib-target.c (library_list_start_library): Don't xstrdup name.
2152
2153 2019-01-10  Pedro Alves  <palves@redhat.com>
2154
2155         * mdebugread.c (parse_partial_symbols): Use
2156         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
2157
2158 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2159
2160         * linux-fork.c (scoped_switch_fork_info)
2161         <~scoped_switch_fork_info>: Fix incorrect variable name.
2162
2163 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2164
2165         * linux-fork.c (scoped_switch_fork_info)
2166         <scoped_switch_fork_info>: Make explicit.
2167         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
2168
2169 2019-01-10  Tom Tromey  <tom@tromey.com>
2170
2171         * objfiles.h (objfile::reset_psymtabs): Update.
2172         * objfiles.c (objfile::objfile): Update.
2173         * psymtab.h (psymtab_storage::obstack): Update.
2174         (psymtab_storage::m_obstack): Use gdb::optional.
2175         (class psymtab_storage): Update comment.  Remove objfile
2176         parameter.
2177         * psymtab.c (psymtab_storage::psymtab_storage): Update.
2178
2179 2019-01-10  Tom Tromey  <tom@tromey.com>
2180
2181         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
2182         <free_psymtabs>: Now private.
2183         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
2184         (allocate_psymtab): Use new method.
2185
2186 2019-01-10  Tom Tromey  <tom@tromey.com>
2187
2188         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
2189         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
2190         * mdebugread.c (parse_partial_symbols): Use
2191         allocate_dependencies.
2192         * dwarf2read.c (dwarf2_create_include_psymtab): Use
2193         allocate_dependencies.
2194         (process_psymtab_comp_unit_reader)
2195         (build_type_psymtab_dependencies): Likewise.
2196         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
2197
2198 2019-01-10  Tom Tromey  <tom@tromey.com>
2199
2200         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
2201         PSYMBOL_SET_LANGUAGE.
2202         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
2203
2204 2019-01-10  Tom Tromey  <tom@tromey.com>
2205
2206         * psymtab.h (psymtab_storage::obstack): New method.
2207         <m_obstack>: Rename from obstack; now private.
2208         * psymtab.c (psymtab_storage): Update.
2209         * dwarf2read.c (create_addrmap_from_index)
2210         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
2211         Update.
2212
2213 2019-01-10  Tom Tromey  <tom@tromey.com>
2214
2215         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
2216         * objfiles.h (objfile::reset_psymtabs): New method.
2217
2218 2019-01-10  Tom Tromey  <tom@tromey.com>
2219
2220         * symmisc.c (print_symbol_bcache_statistics): Update.
2221         (print_objfile_statistics): Update.
2222         * symfile.c (reread_symbols): Update.
2223         * psymtab.h (class psymtab_storage): New.
2224         * psymtab.c (psymtab_storage): New constructor.
2225         (~psymtab_storage): New destructor.
2226         (require_partial_symbols): Update.
2227         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
2228         (find_pc_sect_psymtab, find_pc_sect_psymbol)
2229         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
2230         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
2231         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
2232         (start_psymtab_common, end_psymtab_common)
2233         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
2234         (allocate_psymtab): Update.
2235         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
2236         Update.
2237         (dump_psymtab_addrmap, maintenance_print_psymbols)
2238         (maintenance_check_psymtabs): Update.
2239         (class objfile_psymtabs): Move to objfiles.h.
2240         * psympriv.h (discard_psymtab): Now inline.
2241         (psymtab_discarder::psymtab_discarder): Update.
2242         (psymtab_discarder::~psymtab_discarder): Update.
2243         (ALL_OBJFILE_PSYMTABS): Rewrite.
2244         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
2245         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
2246         Remove fields.
2247         <partial_symtabs>: New field.
2248         (class objfile_psymtabs): Move from psymtab.h.  Update.
2249         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
2250         psymbol_cache.
2251         (objfile::~objfile): Don't destroy psymbol_cache.
2252         * mdebugread.c (parse_partial_symbols): Update.
2253         * dwarf2read.c (create_addrmap_from_index)
2254         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2255         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2256         (add_partial_subprogram, dwarf2_ranges_read): Update.
2257         * dwarf-index-write.c (write_address_map)
2258         (write_one_signatured_type, recursively_write_psymbols)
2259         (class debug_names, class debug_names, write_psymtabs_to_index):
2260         Update.
2261
2262 2019-01-10  Tom Tromey  <tom@tromey.com>
2263
2264         * symtab.h (SYMBOL_SET_NAMES): Update.
2265         (symbol_set_names): Update.
2266         (MSYMBOL_SET_NAMES): Update.
2267         * symtab.c (symbol_set_names): Change argument to be an
2268         objfile_per_bfd_storage.
2269         * psymtab.c (add_psymbol_to_bcache): Update.
2270         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2271
2272 2019-01-10  Tom Tromey  <tom@tromey.com>
2273
2274         * symtab.c (create_demangled_names_hash): Change argument to be an
2275         objfile_per_bfd_storage.
2276         (symbol_set_names): Update.
2277
2278 2019-01-10  Tom Tromey  <tom@tromey.com>
2279
2280         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2281         init_psymbol_list.
2282         * psymtab.c (init_psymbol_list): Do nothing if already called.
2283         * psympriv.h (init_psymbol_list): Add comment.
2284         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2285         init_psymbol_list.
2286         * dbxread.c (dbx_symfile_read): Unconditionally call
2287         init_psymbol_list.
2288
2289 2019-01-10  Tom Tromey  <tom@tromey.com>
2290
2291         * xcoffread.c (scan_xcoff_symtab): Update.
2292         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2293         "where".
2294         * mdebugread.c (parse_partial_symbols)
2295         (handle_psymbol_enumerators): Update.
2296         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2297         * dbxread.c (read_dbx_symtab): Update.
2298         * psympriv.h (psymbol_placement): New enum.
2299         (add_psymbol_to_list): Update.
2300
2301 2019-01-10  Tom Tromey  <tom@tromey.com>
2302
2303         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2304         static_psymbols parameters.
2305         (scan_xcoff_symtab): Update.
2306         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2307         static_psymbols parameters.
2308         * psympriv.h (start_psymtab_common): Update.
2309         * mdebugread.c (parse_partial_symbols): Update.
2310         * dwarf2read.c (create_partial_symtab): Update.
2311         * dbxread.c (read_dbx_symtab): Update.
2312         (start_psymtab): Remove global_psymbols and static_psymbols
2313         parameters.
2314
2315 2019-01-10  Tom Tromey  <tom@tromey.com>
2316
2317         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2318         * psymtab.c (allocate_psymtab): Add comment.
2319         * psympriv.h (allocate_psymtab): Add comment.
2320         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2321         initializations.
2322         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2323
2324 2019-01-10  Tom Tromey  <tom@tromey.com>
2325
2326         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2327         Don't declare.
2328         * mipsread.c: Include mdebugread.h.
2329         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2330         Declare.
2331         * elfread.c: Include mdebugread.h.
2332
2333 2019-01-09  Tom Tromey  <tom@tromey.com>
2334
2335         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2336         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2337         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2338         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2339         (psym_lookup_symbol, psym_find_last_source_symtab)
2340         (psym_forget_cached_source_info, psym_print_stats)
2341         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2342         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2343         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2344         (psym_find_compunit_symtab_by_address)
2345         (maintenance_print_psymbols, maintenance_info_psymtabs)
2346         (maintenance_check_psymtabs): Use ranged for.
2347         * psymtab.h (class objfile_psymtabs): New.
2348         (require_partial_symbols): Return objfile_psymtabs.
2349         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2350
2351 2019-01-09  Tom Tromey  <tom@tromey.com>
2352
2353         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2354         (find_pc_mapped_section, list_overlays_command)
2355         (map_overlay_command, unmap_overlay_command)
2356         (simple_overlay_update): Use all_objfiles.
2357         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2358         * printcmd.c (info_symbol_command): Use all_objfiles.
2359         * objfiles.h (ALL_OBJSECTIONS): Remove.
2360         * maint.c (maintenance_translate_address): Use all_objfiles.
2361         * gcore.c (gcore_create_callback): Use all_objfiles.
2362         (objfile_find_memory_regions): Likewise.
2363
2364 2019-01-09  Tom Tromey  <tom@tromey.com>
2365
2366         * symtab.c (find_line_symtab, info_sources_command)
2367         (make_source_files_completion_list): Use objfile_compunits.
2368         * source.c (select_source_symtab): Use objfile_compunits.
2369         * objfiles.h (struct objfile): Update comment.
2370         (ALL_OBJFILES): Remove.
2371         (ALL_FILETABS): Remove.
2372         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2373         objfile_compunits.
2374
2375 2019-01-09  Tom Tromey  <tom@tromey.com>
2376
2377         * symmisc.c (print_objfile_statistics, dump_objfile)
2378         (maintenance_print_symbols): Use compunit_filetabs.
2379         * source.c (forget_cached_source_info_for_objfile): Use
2380         compunit_filetabs.
2381         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2382         (ALL_FILETABS): Use compunit_filetabs.
2383         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2384         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2385
2386 2019-01-09  Tom Tromey  <tom@tromey.com>
2387
2388         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2389         (compunit_filetabs): New.
2390         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2391         compunit_filetabs.
2392         (info_sources_command, make_source_files_completion_list): Remove
2393         declaration.
2394         * symmisc.c (print_objfile_statistics, dump_objfile)
2395         (maintenance_print_symbols): Remove declaration.
2396         (maintenance_info_symtabs): Use compunit_filetabs.
2397         (maintenance_info_line_tables): Likewise.
2398         * source.c (select_source_symtab): Change local variable name.
2399         (forget_cached_source_info_for_objfile): Remove declaration.
2400         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2401         * objfiles.c (objfile_relocate1): Remove declaration.
2402         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2403         declaration.
2404         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2405         * coffread.c (coff_symtab_read): Remove declaration.
2406         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2407         compunit_filetabs.
2408
2409 2019-01-09  Tom Tromey  <tom@tromey.com>
2410
2411         * symtab.c (lookup_objfile_from_block)
2412         (find_pc_sect_compunit_symtab, search_symbols)
2413         (default_collect_symbol_completion_matches_break_on): Use
2414         objfile_compunits.
2415         * objfiles.h (ALL_COMPUNITS): Remove.
2416         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2417         * cp-support.c (add_symbol_overload_list_qualified): Use
2418         objfile_compunits.
2419         * ada-lang.c (ada_collect_symbol_completion_matches)
2420         (ada_add_global_exceptions): Use objfile_compunits.
2421
2422 2019-01-09  Tom Tromey  <tom@tromey.com>
2423
2424         * source.c (select_source_symtab)
2425         (forget_cached_source_info_for_objfile): Remove declaration.
2426         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2427         declaration.
2428         * maint.c (count_symtabs_and_blocks): Remove declaration.
2429         * cp-support.c (add_symbol_overload_list_qualified): Remove
2430         declaration.
2431         * coffread.c (coff_symtab_read): Remove declaration.
2432         * symtab.c (lookup_symbol_in_objfile_symtabs)
2433         (basic_lookup_transparent_type_1): Use objfile_compunits.
2434         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2435         (info_sources_command, search_symbols)
2436         (default_collect_symbol_completion_matches_break_on)
2437         (make_source_files_completion_list): Remove declaration.
2438         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2439         (ada_collect_symbol_completion_matches)
2440         (ada_add_global_exceptions): Remove declaration.
2441         * linespec.c (iterate_over_all_matching_symtabs): Use
2442         objfile_compunits.
2443         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2444         (class objfile_compunits): New.
2445         (ALL_COMPUNITS): Use objfile_compunits.
2446         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2447         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2448         objfile_compunits.
2449         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2450
2451 2019-01-09  Tom Tromey  <tom@tromey.com>
2452
2453         * symtab.c (search_symbols)
2454         (default_collect_symbol_completion_matches_break_on): Use
2455         objfile_msymbols.
2456         * ada-lang.c (ada_lookup_simple_minsym)
2457         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2458         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2459         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2460         objfile_msymbols.
2461         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2462         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2463         * objc-lang.c (find_methods): Use objfile_msymbols.
2464         (info_selectors_command, info_classes_command): Likewise.
2465         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2466         * objfiles.h (class objfile_msymbols): New.
2467         (ALL_OBJFILE_MSYMBOLS): Remove.
2468         (ALL_MSYMBOLS): Remove.
2469
2470 2019-01-09  Tom Tromey  <tom@tromey.com>
2471
2472         * common/next-iterator.h (next_adapter): Add Iterator template
2473         parameter.
2474         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2475         (class all_objfiles_safe): New.
2476         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2477         * objfiles.c (put_objfile_before): Update comment.
2478         (add_separate_debug_objfile): Likewise.
2479         (free_all_objfiles): Use all_objfiles_safe.
2480         (objfile_purge_solibs): Likewise.
2481
2482 2019-01-09  Tom Tromey  <tom@tromey.com>
2483
2484         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2485         (expand_symtab_containing_pc, lookup_static_symbol)
2486         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2487         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2488         all_objfiles.
2489         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2490         * breakpoint.c (create_overlay_event_breakpoint)
2491         (create_longjmp_master_breakpoint)
2492         (create_std_terminate_master_breakpoint)
2493         (create_exception_master_breakpoint): Use all_objfiles.
2494         * linux-thread-db.c (try_thread_db_load_from_pdir)
2495         (has_libpthread): Use all_objfiles.
2496         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2497         * linespec.c (iterate_over_all_matching_symtabs)
2498         (search_minsyms_for_name): Use all_objfiles.
2499         * maint.c (maintenance_info_sections): Use all_objfiles.
2500         * main.c (captured_main_1): Use all_objfiles.
2501         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2502         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2503         * guile/scm-pretty-print.c
2504         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2505         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2506         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2507         (maintenance_print_msymbols): Use all_objfiles.
2508         * source.c (select_source_symtab): Use all_objfiles.
2509         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2510         * symfile.c (remove_symbol_file_command)
2511         (expand_symtabs_matching, map_symbol_filenames): Use
2512         all_objfiles.
2513         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2514         all_objfiles.
2515         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2516         * objc-lang.c (find_methods): Use all_objfiles.
2517         * objfiles.c (have_partial_symbols, have_full_symbols)
2518         (have_minimal_symbols, qsort_cmp)
2519         (default_iterate_over_objfiles_in_search_order): Use
2520         all_objfiles.
2521         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2522         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2523         (maintenance_check_psymtabs): Use all_objfiles.
2524         (ALL_PSYMTABS): Remove.
2525         * compile/compile-object-run.c (do_module_cleanup): Use
2526         all_objfiles.
2527         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2528         * cp-support.c (add_symbol_overload_list_qualified): Use
2529         all_objfiles.
2530         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2531         Use all_objfiles.
2532         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2533         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2534         all_objfiles.
2535         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2536         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2537         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2538         Uses all_objfiles.
2539         * solib.c (solib_read_symbols): Use all_objfiles
2540
2541 2019-01-09  Tom Tromey  <tom@tromey.com>
2542
2543         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2544         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2545         all_objfiles.
2546         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2547         * symmisc.c (print_symbol_bcache_statistics)
2548         (print_objfile_statistics, maintenance_print_objfiles)
2549         (maintenance_info_symtabs, maintenance_check_symtabs)
2550         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2551         all_objfiles.
2552         * source.c (forget_cached_source_info): Use all_objfiles.
2553         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2554         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2555         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2556         * objfiles.c (update_section_map): Use all_objfiles.
2557         (shared_objfile_contains_address_p): Likewise.
2558         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2559         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2560
2561 2019-01-09  Tom Tromey  <tom@tromey.com>
2562
2563         * common/next-iterator.h: New file.
2564         * objfiles.h (class all_objfiles): New.
2565         (struct objfile_iterator): New.
2566
2567 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2568
2569         * NEWS: Move the description of the changed "frame", "select-frame",
2570          and "info frame" commands to the Changed commands section.
2571
2572 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2573
2574         * gdbtypes.c (check_stub_method_group): Remove handling of old
2575         mangling schemes.
2576         * linespec.c (find_methods): Likewise.
2577         * stabsread.c (read_member_functions): Likewise.
2578         * valops.c (search_struct_method): Likewise.
2579         (value_struct_elt_for_reference): Likewise.
2580         * NEWS: Mention this change.
2581
2582 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2583
2584         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2585         print_source_lines.
2586         * source.c (print_source_lines_base): Update line number check.
2587         (print_source_lines): New function.
2588         (source_lines_range::source_lines_range): New function.
2589         * source.h (class source_lines_range): New class.
2590         (print_source_lines): New declaration.
2591
2592 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2593
2594         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2595
2596 2019-01-08  Tom Tromey  <tom@tromey.com>
2597             Simon Marchi  <simon.marchi@ericsson.com>
2598
2599         PR gdb/24060
2600         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2601         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2602         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2603         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2604         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2605         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2606
2607 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2608
2609         * source.c (select_source_symtab): Move header comment to
2610         declaration in source.h.
2611         (forget_cached_source_info_for_objfile): Likewise.
2612         (forget_cached_source_info): Likewise.
2613         (identify_source_line): Likewise.
2614         * source.h (identify_source_line): Move declaration from symtab.h
2615         and add comment from source.c
2616         (print_source_lines): Likewise.
2617         (forget_cached_source_info_for_objfile): Likewise.
2618         (forget_cached_source_info): Likewise.
2619         (select_source_symtab): Likewise.
2620         (enum print_source_lines_flag): Move definition from symtab.h.
2621         * symtab.h (identify_source_line): Move declaration to source.h.
2622         (print_source_lines): Likewise.
2623         (forget_cached_source_info_for_objfile): Likewise.
2624         (forget_cached_source_info): Likewise.
2625         (select_source_symtab): Likewise.
2626         (enum print_source_lines_flag): Move definition to source.h.
2627         * tui/tui-hooks.c: Add 'source.h' include.
2628
2629 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2630
2631         * source.c (print_source_lines_base): Handle requests to print
2632         reverse line number sequences, and guard against empty lines
2633         string.
2634
2635 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2636
2637         * source.c (print_source_lines_base): Fix skip of '\r' if next
2638         character is '\n'.
2639
2640 2019-01-06  Tom Tromey  <tom@tromey.com>
2641
2642         * c-exp.y (struct c_parse_state) <macro_original_text,
2643         expansion_obstack>: New member.
2644         (macro_original_text, expansion_obstack): Remove globals.
2645         (scan_macro_expansion, scanning_macro_expansion)
2646         (finished_macro_expansion): Update.
2647         (scan_macro_cleanup): Remove.
2648         (yylex, c_parse): Update.
2649
2650 2019-01-06  Tom Tromey  <tom@tromey.com>
2651
2652         * c-exp.y (struct c_parse_state) <strings>: New member.
2653         (operator_stoken): Update.
2654
2655 2019-01-06  Tom Tromey  <tom@tromey.com>
2656
2657         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2658         (union type_stack_elt) <typelist_val>: Now a pointer to
2659         std::vector.
2660         (type_stack_cleanup): Don't declare.
2661         (push_typelist): Update.
2662         * parse.c (pop_typelist): Return a std::vector.
2663         (push_typelist): Take a std::vector.
2664         (follow_types): Update.  Do not free args.
2665         (type_stack_cleanup): Remove.
2666         * c-exp.y (struct c_parse_state): New.
2667         (cpstate): New global.
2668         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2669         (nonempty_typelist): Update.
2670         (func_mod): Create a new vector.
2671         (c_parse): Create a c_parse_state.
2672         (check_parameter_typelist): Do not delete params.
2673         (function_method): Update.  Do not delete type_list.
2674
2675 2019-01-06  Tom Tromey  <tom@tromey.com>
2676
2677         PR gdb/28155:
2678         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2679         check_typedef.
2680         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2681         (print_return_value): Likewise.
2682
2683 2019-01-05  Tom Tromey  <tom@tromey.com>
2684
2685         * contrib/cleanup_check.py: Remove.
2686         * contrib/gcc-with-excheck: Remove.
2687         * contrib/exsummary.py: Remove.
2688         * contrib/excheck.py: Remove.
2689
2690 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2691
2692         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2693         NULL. Initialize tpprev to NULL instead of assigning it
2694         to NULL on the next statement.
2695         * windows-nat.c (windows_delete_thread): Remove check for
2696         main_thread_id before printing thread exit notifications.
2697         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2698         Remove thread ID check against main_thread_id.
2699         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2700         windows_delete_thread.
2701         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2702
2703 2019-01-04  Tom Tromey  <tom@tromey.com>
2704
2705         * compile/compile.c (_initialize_compile): Use upper case for
2706         metasyntactic variables.
2707         * symmisc.c (_initialize_symmisc): Use upper case for
2708         metasyntactic variables.
2709         * psymtab.c (_initialize_psymtab): Use upper case for
2710         metasyntactic variables.
2711         * demangle.c (demangle_command): Use upper case for metasyntactic
2712         variables.
2713         (_initialize_demangler): Likewise.
2714         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2715         variables.
2716
2717 2019-01-03  Tom Tromey  <tom@tromey.com>
2718
2719         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2720
2721 2019-01-03  Tom Tromey  <tom@tromey.com>
2722
2723         * python/py-symtab.c (salpy_str): Update.
2724         (struct salpy_sal_object) <symtab>: Now a PyObject.
2725         (salpy_dealloc): Update.
2726         (del_objfile_sal): Use gdbpy_ref.
2727
2728 2019-01-03  Tom Tromey  <tom@tromey.com>
2729
2730         * python/py-type.c (convert_field): Use new_reference.  Return
2731         gdbpy_ref.
2732         (make_fielditem): Return gdbpy_ref.
2733         (typy_fields): Update.
2734         (typy_getitem): Update.
2735         (field_name): Return gdbpy_ref.  Use new_reference.
2736         (typy_iterator_iternext): Update.
2737
2738 2019-01-03  Tom Tromey  <tom@tromey.com>
2739
2740         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2741
2742 2019-01-03  Tom Tromey  <tom@tromey.com>
2743
2744         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2745         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2746         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2747         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2748         (pspy_set_type_printers): Likewise.
2749         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2750         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2751         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2752         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2753         (objfpy_set_type_printers): Likewise.
2754
2755 2019-01-03  Tom Tromey  <tom@tromey.com>
2756
2757         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2758         (gdbpy_print_stack): Use gdbpy_err_fetch.
2759         * python/python-internal.h (class gdbpy_err_fetch): New class.
2760         (class gdbpy_enter) <m_error_type, m_error_value,
2761         m_error_traceback>: Remove.
2762         <m_error>: New member.
2763         (gdbpy_exception_to_string): Don't declare.
2764         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2765         * python/py-value.c (convert_value_from_python): Use
2766         gdbpy_err_fetch.
2767         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2768         gdbpy_exception_to_string.
2769         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2770         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2771         gdbpy_err_fetch.
2772
2773 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2774
2775         * linux-nat.c (delete_lwp_cleanup): Delete.
2776         (struct lwp_deleter): New struct.
2777         (lwp_info_up): New typedef.
2778         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2779         lwp_info_up.
2780
2781 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2782
2783         * linux-fork.c (class scoped_switch_fork_info): New class.
2784         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2785
2786 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2787
2788         * valops.c (find_overload_match): Remove use of null_cleanup, and
2789         calls to do_cleanups.
2790
2791 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2792
2793         * compile/compile-cplus-types.c
2794         (compile_cplus_instance::decl_name): Handle changes to
2795         cp_func_name.
2796         * cp-support.c (cp_func_name): Update header comment, update
2797         return type.
2798         * cp-support.h (cp_func_name): Update return type in declaration.
2799         * valops.c (find_overload_match): Move temp_func local to top
2800         level of function and change its type.  Use temp_func to hold and
2801         delete temporary string obtained from cp_func_name.
2802
2803 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2804
2805         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2806         gdb::char_vector, remove cleanup, and update uses of `msg`.
2807
2808 2019-01-03  Jim Wilson  <jimw@sifive.com>
2809
2810         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2811
2812 2019-01-02  Tom Tromey  <tom@tromey.com>
2813
2814         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2815         (tdesc_parse_xml): Remove cleanups.
2816         * target-descriptions.h (make_cleanup_free_target_description):
2817         Don't declare.
2818         (target_desc_deleter): New struct.
2819         (target_desc_up): New typedef.
2820         * target-descriptions.c (target_desc_deleter::operator()): Rename
2821         from free_target_description.
2822         (make_cleanup_free_target_description): Remove.
2823
2824 2019-01-02  Tom Tromey  <tom@tromey.com>
2825
2826         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2827         constructor, destructor.
2828         (linespec_parser): Remove typedef.
2829         (~linespec_parser): Rename from linespec_parser_delete.
2830         (linespec_lex_to_end, linespec_complete_label)
2831         (linespec_complete): Update.
2832         (decode_line_full): Remove cleanups.
2833         (decode_line_1): Update.
2834
2835 2019-01-02  Tom Tromey  <tom@tromey.com>
2836
2837         * python/python-internal.h (inferior_to_inferior_object): Change
2838         return type.
2839         * python/py-exitedevent.c (create_exited_event_object): Update.
2840         * python/py-inferior.c (inferior_to_inferior_object): Return
2841         gdbpy_ref.
2842         (python_new_inferior, python_inferior_deleted)
2843         (thread_to_thread_object, delete_thread_object)
2844         (build_inferior_list, gdbpy_selected_inferior): Update.
2845         * python/py-infthread.c (create_thread_object): Update.  Also fail
2846         if inferior_to_inferior_object fails.
2847
2848 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2849
2850         * inferior.h (class inferior) <displaced_step_state>: New field.
2851         * infrun.h (struct displaced_step_state): Move here from
2852         infrun.c.  Initialize fields, add constructor.
2853         <inf>: Remove field.
2854         <reset>: New method.
2855         * infrun.c (struct displaced_step_inferior_state): Move to
2856         infrun.h.
2857         (displaced_step_inferior_states): Remove.
2858         (get_displaced_stepping_state): Adust.
2859         (displaced_step_in_progress_any_inferior): Adjust.
2860         (displaced_step_in_progress_thread): Adjust.
2861         (displaced_step_in_progress): Adjust.
2862         (add_displaced_stepping_state): Remove.
2863         (get_displaced_step_closure_by_addr): Adjust.
2864         (remove_displaced_stepping_state): Remove.
2865         (infrun_inferior_exit): Call displaced_step_state.reset.
2866         (use_displaced_stepping): Don't check for NULL.
2867         (displaced_step_prepare_throw): Call
2868         get_displaced_stepping_state.
2869         (displaced_step_fixup): Don't check for NULL.
2870         (prepare_for_detach): Don't check for NULL.
2871
2872 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2873
2874         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2875          in case of call that did not complete.
2876
2877 2019-01-02  Andrey Utkin  <autkin@undo.io>
2878
2879         * symfile.c (find_separate_debug_file): Fix search of debug files for
2880         remote debuggee.
2881
2882 2019-01-02  Tom Tromey  <tom@tromey.com>
2883
2884         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2885         indentation.
2886         * python/py-frame.c (frapy_older): Remove cast.
2887         (frapy_newer): Likewise.
2888         * python/py-breakpoint.c (local_setattro): Remove cast.
2889         * python/py-arch.c (archpy_name): Remove local variable.
2890         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2891
2892 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2893
2894         * unittests/basic_string_view/element_access/char/empty.cc:
2895         Fix year range in copyright header.
2896
2897 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2898
2899         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2900         Delete.
2901         <operator==>: Update with for removed field.
2902         <hash>: Likewise.
2903         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2904         <isa_features>: ...this.
2905         <abi_features>: New field.
2906         (riscv_isa_flen): Update comment.
2907         (riscv_abi_xlen): New declaration.
2908         (riscv_abi_flen): New declaration.
2909         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2910         isa_features.
2911         (riscv_abi_xlen): New function.
2912         (riscv_isa_flen): Update to get answer from isa_features.
2913         (riscv_abi_flen): New function.
2914         (riscv_has_fp_abi): Update to get answer from abi_features.
2915         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2916         xlen and flen.
2917         (riscv_call_info) <xlen, flen>: Update comment.
2918         (riscv_call_arg_struct): Remove invalid assertions
2919         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2920         is removed.
2921         (riscv_gdbarch_init): Gather isa features and abi features
2922         separately, ensure both match on the gdbarch when reusing an old
2923         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2924         a target with 64-bit float hardware.
2925
2926 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2927
2928         * source.c (search_command_helper): Stop reverse search
2929         when line 1 has been searched.
2930
2931 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2932
2933         * record-full.c (record_full_base_target::close): Rewrite
2934         record_full_core_buf_list free logic.
2935
2936 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2937
2938         * break-catch-syscall.c (print_one_catch_syscall): xfree
2939         the last text.
2940
2941 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2942
2943         * top.c (print_gdb_version): Update Copyright year in version
2944         message.
2945
2946 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2947
2948         Update copyright year range in all GDB files.
2949
2950 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2951
2952         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2953
2954 For older changes see ChangeLog-2018.
2955 \f
2956 Local Variables:
2957 mode: change-log
2958 left-margin: 8
2959 fill-column: 74
2960 version-control: never
2961 coding: utf-8
2962 End:
2963