961a2e24ba9421db36cbb7f0bda3207c094d7b35
[external/binutils.git] / gdb / ChangeLog
1 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
2
3         * version.in: Set GDB version number to 8.3.1.
4
5 2019-08-19  Tom Tromey  <tom@tromey.com>
6
7         PR gdb/25009
8         * configure: Rebuild.
9         * configure.ac: Disallow the combination of -static-libstdc++ and
10         source highlight.
11         * source-cache.c (get_language_name): Handle rust.
12         (source_cache::get_source_lines): Ignore highlighting exceptions.
13
14 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
15
16         PR breakpoints/24541
17         * gdbarch.c: Regenerate.
18         * gdbarch.h: Regenerate.
19         * gdbarch.sh: Add 'stap_adjust_register'.
20         * i386-tdep.c: Include '<unordered_set>'.
21         (i386_stap_adjust_register): New function.
22         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
23         * stap-probe.c (stap_parse_register_operand): Call
24         'gdbarch_stap_adjust_register'.
25
26 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
27
28         PR breakpoints/24541
29         * stap-probe.c (stap_parse_register_operand): Make "regname" an
30         "std::string", simplifying the algorithm.
31
32 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
33
34         PR gdb/25010
35         * event-top.c: Remove include comment.
36         * inflow.c (class scoped_ignore_sigttou): Move from here...
37         * inflow.h (class scoped_ignore_sigttou): ...to here.
38         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
39         * top.c:  Remove include comment.
40
41 2019-08-04  Alan Hayward  <alan.hayward@arm.com>
42
43         PR breakpoints/25011
44         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
45
46 2019-05-29  Tom Tromey  <tromey@adacore.com>
47
48         PR c++/20020:
49         * cp-valprint.c (cp_print_value_fields): Call
50         cp_print_static_field inside "try".
51
52 2019-06-10  Tom de Vries  <tdevries@suse.de>
53
54         PR symtab/24545
55         * symtab.c (struct demangled_name_entry): Add language field.
56         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
57         static minimal symbol".  Set and use language field.
58
59 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
60
61         PR gdb/24592
62         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
63         function.
64         (fill_gregset): Call amd64_linux_collect_native_gregset instead
65         of amd64_collect_native_gregset.
66         (amd64_linux_nat_target::store_registers): Likewise.
67
68 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
69
70         * version.in: Set GDB version number to 8.3.0.DATE-git.
71
72 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
73
74         GDB 8.3 released.
75
76 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
77
78         * version.in: Set GDB version number to 8.3.
79
80 2019-05-08  Tom Tromey  <tromey@adacore.com>
81
82         * utils.c (fputs_maybe_filtered): Reset style after paging, even
83         when no wrap column is set.
84
85 2019-05-04  Tom Tromey  <tom@tromey.com>
86
87         * psymtab.c (psymbol_name_matches, match_partial_symbol)
88         (lookup_partial_symbol, print_partial_symbols)
89         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
90         (psymbol_compare): Update.
91         (add_psymbol_to_bcache): Clear the entire psymbol.
92         (maintenance_check_psymtabs): Update.
93         * psympriv.h (struct partial_symbol): Don't derive from
94         general_symbol_info.
95         <obj_section, unrelocated_address, address,
96         set_unrelocated_address>: Update.
97         <ginfo>: New member.
98         * dwarf-index-write.c (write_psymbols, debug_names::insert)
99         (debug_names::write_psymbols): Update.
100
101 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
102
103         * windows-nat.c [_WIN32_WINNT]: Define _WIN32_WINNT to Windows XP
104         level, so that various Windows header files expose the necessary
105         declarations and definitions.
106
107         * symfile.c (find_separate_debug_file): Remove colon from the
108         drive spec of DOS/Windows file names of the target, so that the
109         file name produced from DEBUGDIR and the target's directory will
110         be valid on DOS/Windows systems.
111
112 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
113
114         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
115         Use current_event.dwThreadId instead of main_thread_id.
116
117 2019-04-30  Tom Tromey  <tromey@adacore.com>
118
119         PR c++/24470:
120         * dwarf2read.c (process_structure_scope): Handle case where type
121         has template parameters but no symbol was created.
122
123 2019-04-19  Sergei Trofimovich <siarheit@google.com>
124
125         * configure.ac: add --enable-source-highlight switch.
126         * configure: Regenerate.
127         * top.c (print_gdb_version): plumb --enable-source-highlight
128         status to "show configuration".
129
130 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
131
132         PR symtab/24423:
133         * source.c (print_source_lines_base): Advance "iter" when a
134         control character is seen.
135
136 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
137
138         * inferior.h (struct infcall_suspend_state_deleter):
139         Catch exception in destructor to avoid crash.
140
141 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
142
143         * utils.c (prompt_for_continue): Don't restore the styling at the
144         end, as applied_style has the wrong value.  This fixes styling in
145         long lists of file names that are interrupted by the "Continue?"
146         prompt.
147
148 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
149
150         * version.in: Set GDB version number to 8.2.91.DATE-git.
151
152 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
153
154         GDB 8.2.91 released.
155
156 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
157
158         * version.in: Set GDB version number to 8.2.91.
159
160 2019-03-20  Tom Tromey  <tromey@adacore.com>
161
162         PR gdb/24391
163         * infrun.c (handle_inferior_event): Rename from
164         handle_inferior_event_1.  Create a scoped_value_mark.
165         (handle_inferior_event): Remove.
166
167 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
168
169         * source-cache.c (source_cache::get_source_lines): Re-read
170         fullname after calling open_source_file.
171
172 2019-03-18  Pedro Alves  <palves@redhat.com>
173             Eli Zaretskii <eliz@gnu.org>
174
175         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
176         m_line and m_start_of_line.
177
178 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
179
180         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
181         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
182         it returns a newline.  This fixes a regression in TU mode, whereby
183         the next line is output on the same screen line as the user input.
184
185 2019-03-18  Pedro Alves  <palves@redhat.com>
186
187         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
188         New globals.
189         (apply_style): New, factored out from ...
190         (apply_ansi_escape): ... this.  Handle reverse video mode.
191         (tui_set_reverse_mode): New function.
192         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
193         * tui/tui-winsource.c (tui_show_source_line): Use
194         tui_set_reverse_mode instead of setting A_STANDOUT.
195         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
196         New setter methods.
197
198 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
199
200         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
201         Handle tabs.
202
203 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
204
205         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
206         tui_refill_source_window instead of tui_refresh_win, to update the
207         current execution line.  This fixes redisplay of the current line
208         when stepping through the code with "next" or "step".
209
210 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
211
212         * source-cache.c (source_cache::get_source_lines): Call
213         find_source_lines to initialize s->nlines.  This fixes vertical
214         scrolling of TUI source window when the DOWN arrow is pressed.
215
216 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
217
218         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
219         wclrtoeol in tui_show_source_line".  This reverts changes made in
220         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
221
222 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
223
224         * NEWS: Combine separate "New targets" sections for 8.3.
225
226 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
227
228         The MS-Windows port of ncurses fails to switch to a color pair if
229         one or both of the colors are the implicit default colors.  This
230         change records the default colors when TUI is initialized, and
231         then specifies them explicitly when a color pair uses the default
232         colors.  This allows color styling in TUI mode on MS-Windows.
233
234         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
235         ncurses_norm_attr.
236         (tui_initialize_io) [__MINGW32__]: Record the default terminal
237         colors in ncurses_norm_attr.
238         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
239         "none", replace it with the default color recorded in
240         ncurses_norm_attr.
241
242 2019-03-14  Tom Tromey  <tromey@adacore.com>
243
244         * source-cache.h (class source_cache) <get_source_lines>: Return
245         std::string.
246         * source-cache.c (source_cache::extract_lines): Handle case where
247         first_pos==npos.  Return std::string.
248         (source_cache::get_source_lines): Update.
249
250 2019-03-14  Tom Tromey  <tromey@adacore.com>
251
252         * NEWS: Add item for "style sources" commands.
253         * source-cache.c (source_cache::get_source_lines): Check
254         source_styling.
255         * cli/cli-style.c (source_styling): New global.
256         (_initialize_cli_style): Add "style sources" commands.
257         (show_style_sources): New function.
258         * cli/cli-style.h (source_styling): Declare.
259
260 2019-03-14  Pedro Alves  <palves@redhat.com>
261             Tom Tromey  <tromey@adacore.com>
262
263         * tui/tui-winsource.h (tui_refill_source_window): Declare.
264         * tui/tui-winsource.c (tui_refill_source_window): New function,
265         from...
266         (tui_horizontal_source_scroll): ... here.  Move some logic.
267         * cli/cli-style.c (set_style_enabled): Notify new observable.
268         * tui/tui-hooks.c (tui_redisplay_source): New function.
269         (tui_attach_detach_observers): Attach or detach
270         tui_redisplay_source.
271         * observable.h (source_styling_changed): New observable.
272         * observable.c: Define source_styling_changed observable.
273
274 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
275
276         PR/24325
277         * source-cache.c: #undef open and close, to avoid unresolved
278         externals during linking.
279
280 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
281
282         Support styling on native MS-Windows console
283
284         PR/24315
285         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
286         on MS-Windows if $TERM is not defined.
287
288         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
289
290         * posix-hdep.c (gdb_console_fputs):
291         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
292         functions.
293         * ui-file.h (gdb_console_fputs): Add prototype.
294
295         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
296         back to fputs only if the former returns zero.
297
298 2019-03-07  Brian Vandenberg  <phantall@gmail.com>
299             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
300
301         PR gdb/8527
302         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
303         set_sigint_trap, clear_sigint_trap.
304
305 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
306
307         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
308         for-loop range, to avoid compiler warnings.
309
310         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
311         avoid compiler warnings about unused variables.
312
313 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
314
315         * NEWS: Mention end of support for native debugging on MS-Windows
316         before XP.
317
318 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
319
320         PR gdb/24292
321         * common/netstuff.c:
322         * gdbserver/gdbreplay.c
323         * gdbserver/remote-utils.c:
324         * ser-tcp.c:
325         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
326         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
327         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
328         'getaddrinfo' and 'freeaddrinfo' were not available before
329         Windows XP, and mingw.org's MinGW headers by default define
330         _WIN32_WINNT to 0x500.
331
332 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
333     
334         * NEWS: Note minimum Python version.
335
336 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
337
338         * version.in: Set GDB version number to 8.2.90.DATE-git.
339
340 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
341
342         GDB 8.2.90 released.
343
344 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
345
346         * version.in: Set GDB version number to 8.2.90.
347
348 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
349
350         * NEWS: Change "Changes since GDB 8.2" into "Changes in GDB 8.3".
351
352 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
353
354         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
355         * version.in: Bump version to 8.2.90.DATE-git.
356
357 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
358
359         * aix-thread.c (ptid_cmp): Remove unused variable.
360         (get_signaled_thread): Likewise.
361         (store_regs_user_thread): Likewise.
362         (store_regs_kernel_thread): Likewise.
363         (fetch_regs_kernel_thread): Remove shadowed variable.
364
365 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
366
367         * features/riscv/32bit-cpu.xml: Add register numbers.
368         * features/riscv/32bit-fpu.c: Regenerate.
369         * features/riscv/32bit-fpu.xml: Add register numbers.
370         * features/riscv/64bit-cpu.xml: Add register numbers.
371         * features/riscv/64bit-fpu.c: Regenerate.
372         * features/riscv/64bit-fpu.xml: Add register numbers.
373
374 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
375
376         * NEWS: Mention two argument form of gdb.Value constructor.
377         * python/py-value.c (convert_buffer_and_type_to_value): New
378         function.
379         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
380         Add support for handling an optional second argument.  Call
381         convert_buffer_and_type_to_value as appropriate.
382         * python/python-internal.h (Py_buffer_deleter): New struct.
383         (Py_buffer_up): New typedef.
384
385 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
386
387         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
388         instead of releasing ownership.
389
390 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
391
392         * dwarf2read.c (open_and_init_dwp_file): Call
393         elf_numsections instead of bfd_count_sections to initialize
394         dwp_file->num_sections.
395
396 2019-02-25  Tom Tromey  <tromey@adacore.com>
397
398         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
399
400 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
401
402         * gcore.in: Add '--readnever' option when invoking GDB.
403
404 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
405
406         * MAINTAINERS: Update my email address.
407
408 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
409
410         * build-id.c (build_id_to_debug_bfd_1): New function.
411         (build_id_to_debug_bfd): Look for separate debug file in
412         sysroot.
413
414 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
415
416         * gdbarch.sh: Update the copyright year range that is placed into
417         generated files.
418
419 2019-02-22  Keith Seitz  <keiths@redhat.com>
420
421         PR symtab/23853
422         * linespec.c (create_sals_line_offset): Search for the default
423         symtab's filename instead of its fullname.
424
425 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
426
427         * NEWS: Update style defaults.
428
429 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
430
431         * main.c (captured_main_1): Disable styling in batch mode.
432
433 2019-02-20  Tom Tromey  <tom@tromey.com>
434
435         * symtab.c (symtab_symbol_info): Fix typos.
436
437 2019-02-20  Tom Tromey  <tromey@adacore.com>
438
439         * findcmd.c (_initialize_mem_search): Use upper case for
440         metasyntactic variables.
441
442 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
443
444         * aarch64-tdep.c (aarch64_add_reggroups): New function.
445         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
446
447 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
448
449         * top.h (source_file_name): Change to std::string.
450         * top.c (source_file_name): Likewise.
451         (command_line_input): Adjust.
452         * cli/cli-script.c (script_from_file): Adjust.
453
454 2019-02-19  Tom Tromey  <tromey@adacore.com>
455
456         * ravenscar-thread.c
457         (ravenscar_thread_target::update_thread_list): Don't call
458         ada_build_task_list.
459         * ada-lang.h (ada_build_task_list): Don't declare.
460         * ada-tasks.c (struct ada_tasks_inferior_data)
461         <task_list_valid_p>: Now bool.
462         (read_known_tasks, ada_task_list_changed)
463         (ada_tasks_invalidate_inferior_data): Update.
464         (read_known_tasks_array): Return bool.
465         (read_known_tasks_list): Likewise.
466         (read_known_tasks): Return void.
467         (ada_build_task_list): Now static.
468
469 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
470
471         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
472         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
473
474 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
475
476         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
477         variant for ada_tasks_pspace_data_handle and
478         ada_tasks_inferior_data_handle.
479         (ada_tasks_pspace_data_cleanup): New function.
480         (ada_tasks_inferior_data_cleanup): New function.
481
482 2019-02-17  Tom Tromey  <tom@tromey.com>
483
484         * macrotab.h (macro_source_fullname): Return a std::string.
485         * macrotab.c (macro_include, check_for_redefinition)
486         (macro_undef, macro_lookup_definition, foreach_macro)
487         (foreach_macro_in_scope): Update.
488         (macro_source_fullname): Return a std::string.
489         * macrocmd.c (show_pp_source_pos): Update.
490
491 2019-02-17  Tom Tromey  <tom@tromey.com>
492
493         * macrocmd.c (show_pp_source_pos): Style the file names.
494
495 2019-02-17  Tom Tromey  <tom@tromey.com>
496
497         PR tui/24197:
498         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
499
500 2019-02-17  Tom Tromey  <tom@tromey.com>
501
502         * ada-lang.c (user_select_syms): Use filtered printing.
503         * utils.c (wrap_style): New global.
504         (desired_style): Remove.
505         (emit_style_escape): Add stream parameter.
506         (set_output_style, reset_terminal_style, prompt_for_continue):
507         Update.
508         (flush_wrap_buffer): Only flush gdb_stdout.
509         (wrap_here): Set wrap_style.
510         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
511         treat escape sequences as a character.  Change when wrap buffer is
512         flushed.
513         (fputs_styled): Do not set the output style when the default is
514         requested.
515         * ui-style.h (struct ui_file_style) <is_default>: New method.
516         * source.c (print_source_lines_base): Emit escape sequences in one
517         piece.
518
519 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
520
521         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
522         integers and enumeration types.
523
524 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
525
526         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
527         instead of lookup_symbol_in_language
528         (do_exact_match): New function.
529         (ada_get_symbol_name_matcher): Return do_exact_match when
530         doing a verbatim match.
531
532 2019-02-15  Tom Tromey  <tromey@adacore.com>
533
534         * ravenscar-thread.c (ravenscar_thread_target::resume)
535         (ravenscar_thread_target::wait): Special case wildcard requests.
536
537 2019-02-15  Tom Tromey  <tromey@adacore.com>
538
539         * ravenscar-thread.c (base_ptid): Remove.
540         (struct ravenscar_thread_target) <close>: New method.
541         <m_base_ptid>: New member.
542         <update_inferior_ptid, active_task, task_is_currently_active,
543         runtime_initialized>: Declare methods.
544         <ravenscar_thread_target>: Add constructor.
545         (ravenscar_thread_target::task_is_currently_active)
546         (ravenscar_thread_target::update_inferior_ptid)
547         (ravenscar_runtime_initialized): Rename.  Now methods.
548         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
549         (ravenscar_thread_target::update_thread_list): Update.
550         (ravenscar_thread_target::active_task): Now method.
551         (ravenscar_thread_target::store_registers)
552         (ravenscar_thread_target::prepare_to_store)
553         (ravenscar_thread_target::prepare_to_store)
554         (ravenscar_thread_target::mourn_inferior): Update.
555         (ravenscar_inferior_created): Use "new" to create target.
556         (ravenscar_thread_target::get_ada_task_ptid): Update.
557         (_initialize_ravenscar): Don't initialize base_ptid.
558         (ravenscar_ops): Remove global.
559
560 2019-02-15  Tom Tromey  <tromey@adacore.com>
561
562         * target.h (push_target): Declare new overload.
563         * target.c (push_target): New overload, taking an rvalue reference.
564         * remote.c (remote_target::open_1): Use push_target overload.
565         * corelow.c (core_target_open): Use push_target overload.
566
567 2019-02-15  Tom Tromey  <tromey@adacore.com>
568
569         * ravenscar-thread.c (is_ravenscar_task)
570         (ravenscar_task_is_currently_active): Return bool.
571         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
572         (_initialize_ravenscar): Remove "(void)".
573         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
574         Return bool.
575
576 2019-02-15  Tom Tromey  <tromey@adacore.com>
577
578         * ravenscar-thread.c (ravenscar_runtime_initializer)
579         (has_ravenscar_runtime, get_running_thread_id)
580         (ravenscar_thread_target::resume): Fix indentation.
581
582 2019-02-15  Tom Tromey  <tromey@adacore.com>
583
584         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
585         from ravenscar_arch_ops.
586         (sparc_ravenscar_ops::fetch_registers)
587         (sparc_ravenscar_ops::store_registers): Now methods.
588         (sparc_ravenscar_prepare_to_store): Remove.
589         (sparc_ravenscar_ops): Redefine.
590         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
591         methods and destructor.  Remove members.
592         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
593         (ravenscar_thread_target::store_registers)
594         (ravenscar_thread_target::prepare_to_store): Update.
595         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
596         Remove.
597         (struct ppc_ravenscar_powerpc_ops): Derive from
598         ravenscar_arch_ops.
599         (ppc_ravenscar_powerpc_ops::fetch_registers)
600         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
601         (ppc_ravenscar_powerpc_ops): Redefine.
602         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
603         (ppc_ravenscar_e500_ops::fetch_registers)
604         (ppc_ravenscar_e500_ops::store_registers): Now methods.
605         (ppc_ravenscar_e500_ops): Redefine.
606         * aarch64-ravenscar-thread.c
607         (aarch64_ravenscar_generic_prepare_to_store): Remove.
608         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
609         (aarch64_ravenscar_fetch_registers)
610         (aarch64_ravenscar_store_registers): Now methods.
611         (aarch64_ravenscar_ops): Redefine.
612
613 2019-02-15  Tom Tromey  <tromey@adacore.com>
614
615         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
616         (ravenscar_thread_target::stopped_by_hw_breakpoint)
617         (ravenscar_thread_target::stopped_by_watchpoint)
618         (ravenscar_thread_target::stopped_data_address)
619         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
620
621 2019-02-15  Tom Tromey  <tromey@adacore.com>
622
623         * ravenscar-thread.c: Fix some typos.
624
625 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
626             Tom Tromey  <tromey@adacore.com>
627
628         * ada-lang.c (ada_exception_sal): Change addr_string to a
629         std::string.
630         (create_ada_exception_catchpoint): Update.
631
632 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
633             Tom Tromey  <tromey@adacore.com>
634
635         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
636         (bp_location_ops): Remove.
637         (base_breakpoint_allocate_location): Update.
638         (free_bp_location): Update.
639         * ada-lang.c (class ada_catchpoint_location)
640         <ada_catchpoint_location>: Remove ops parameter.
641         (ada_catchpoint_location_dtor): Remove.
642         (ada_catchpoint_location_ops): Remove.
643         (allocate_location_exception): Update.
644         * breakpoint.h (struct bp_location_ops): Remove.
645         (class bp_location) <bp_location>: Remove bp_location_ops
646         parameter.
647         <~bp_location>: Add destructor.
648         <ops>: Remove.
649
650 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
651             Pedro Alves  <palves@redhat.com>
652
653         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
654         'PATH_MAX'.
655
656 2019-02-14  David Michael  <fedora.dm0@gmail.com>
657             Samuel Thibault  <samuel.thibault@gnu.org>
658             Thomas Schwinge  <thomas@codesourcery.com>
659
660         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
661         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
662
663 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
664
665         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
666         (check_empty): Use "const char *".
667
668         * gnu-nat.c (gnu_nat_target::detach): Instead of
669         'detach_inferior (pid)' call
670         'detach_inferior (find_inferior_pid (pid))'.
671
672         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
673         'nat/fork-inferior.o'.
674         * gnu-nat.c: #include "nat/fork-inferior.h".
675
676         * gnu-nat.c (gnu_nat_target::detach): Instead of
677         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
678         * gnu-nat.h: #include "inf-child.h".
679         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
680         'i386_gnu_nat_target::fetch_registers'.
681         (gnu_store_registers): Rename/move to
682         'i386_gnu_nat_target::store_registers'.
683
684         * config/i386/nm-i386gnu.h: Don't "#include" any files.
685         * gnu-nat.h (mach_thread_info): New function.
686         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
687
688         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
689
690 2019-02-14  Frederic Konrad  <konrad@adacore.com>
691
692         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
693
694 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
695
696         * windows-nat.c (windows_add_thread): Add new parameter
697         "main_thread_p" with default value set to false.  Update
698         function documentation as well as all callers.
699         (windows_delete_thread): Likewise.
700         (fake_create_process): Update call to windows_add_thread.
701         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
702         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
703         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
704         call to windows_delete_thread.
705
706 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
707
708         * MAINTAINERS: Add Andrew Burgess as global maintainer.
709
710 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
711
712         * symfile.c (find_separate_debug_file): Use canonical path of
713         sysroot with child_path instead of gdb_sysroot if it is valid.
714
715 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
716
717         * symfile.c (find_separate_debug_file): Use child_path to
718         determine if an object file is under a sysroot.
719
720 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
721
722         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
723         unittests/child-path-selftests.c.
724         * common/pathstuff.c (child_path): New function.
725         * common/pathstuff.h (child_path): New prototype.
726         * unittests/child-path-selftests.c: New file.
727
728 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
729
730         * symfile.c (find_separate_debug_file): Look for separate debug
731         files in debug directories under the sysroot.
732
733 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
734
735         * symtab.h (struct minimal_symbol data_p): New const method.
736         (struct minimal_symbol text_p): Likewise.
737         * symtab.c (output_source_filename): Use file name style
738         to print file name.
739         (print_symbol_info): Likewise.
740         (print_msymbol_info): Use address style to print addresses.
741         Use function name style to print executable text symbols.
742         (expand_symtab_containing_pc): Use data_p.
743         (find_pc_sect_compunit_symtab): Likewise.
744
745 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
746
747         * breakpoint.c (describe_other_breakpoints): Use address style
748         to print addresses.
749         (say_where): Likewise.
750
751 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
752
753         * ada-typeprint.c (print_func_type): Print function name
754         style to print function name.
755         * c-typeprint.c (c_print_type_1): Likewise.
756
757 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
758
759         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
760         for execve.
761
762 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
763
764         * c-exp.y (direct_abs_decl): Use emplace_back to record the
765         type_stack.
766
767 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
768
769         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
770         TYPE_CODE_REF types.
771
772 2019-02-08  Jim Wilson  <jimw@sifive.com>
773
774         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
775         (riscv_linux_fregset): New.
776         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
777
778 2019-02-07  Tom Tromey  <tom@tromey.com>
779
780         * thread.c (thread_cancel_execution_command): Update.
781         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
782         methods.
783         (struct thread_fsm_ops): Remove.
784         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
785         (thread_fsm_should_stop, thread_fsm_return_value)
786         (thread_fsm_set_finished, thread_fsm_finished_p)
787         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
788         Don't declare.
789         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
790         * infrun.c (clear_proceed_status_thread)
791         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
792         (print_stop_event): Update.
793         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
794         Add constructor.
795         (step_command_fsm_ops): Remove.
796         (new_step_command_fsm): Remove.
797         (step_1): Update.
798         (step_command_fsm::should_stop): Rename from
799         step_command_fsm_should_stop.
800         (step_command_fsm::clean_up): Rename from
801         step_command_fsm_clean_up.
802         (step_command_fsm::do_async_reply_reason): Rename from
803         step_command_fsm_async_reply_reason.
804         (struct until_next_fsm): Inherit from thread_fsm.  Add
805         constructor.
806         (until_next_fsm_ops): Remove.
807         (new_until_next_fsm): Remove.
808         (until_next_fsm::should_stop): Rename from
809         until_next_fsm_should_stop.
810         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
811         (until_next_fsm::do_async_reply_reason): Rename from
812         until_next_fsm_async_reply_reason.
813         (struct finish_command_fsm): Inherit from thread_fsm.  Add
814         constructor.  Change type of breakpoint.
815         (finish_command_fsm_ops): Remove.
816         (new_finish_command_fsm): Remove.
817         (finish_command_fsm::should_stop): Rename from
818         finish_command_fsm_should_stop.
819         (finish_command_fsm::clean_up): Rename from
820         finish_command_fsm_clean_up.
821         (finish_command_fsm::return_value): Rename from
822         finish_command_fsm_return_value.
823         (finish_command_fsm::do_async_reply_reason): Rename from
824         finish_command_fsm_async_reply_reason.
825         (finish_command): Update.
826         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
827         Add constructor.
828         (call_thread_fsm_ops): Remove.
829         (call_thread_fsm::call_thread_fsm): Rename from
830         new_call_thread_fsm.
831         (call_thread_fsm::should_stop): Rename from
832         call_thread_fsm_should_stop.
833         (call_thread_fsm::should_notify_stop): Rename from
834         call_thread_fsm_should_notify_stop.
835         (run_inferior_call, call_function_by_hand_dummy): Update.
836         * cli/cli-interp.c (should_print_stop_to_console): Update.
837         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
838         Add constructor.  Change type of location_breakpoint,
839         caller_breakpoint.
840         (until_break_fsm_ops): Remove.
841         (new_until_break_fsm): Remove.
842         (until_break_fsm::should_stop): Rename from
843         until_break_fsm_should_stop.
844         (until_break_fsm::clean_up): Rename from
845         until_break_fsm_clean_up.
846         (until_break_fsm::do_async_reply_reason): Rename from
847         until_break_fsm_async_reply_reason.
848         (until_break_command): Update.
849         * thread-fsm.c: Remove.
850         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
851
852 2019-02-07  Tom Tromey  <tom@tromey.com>
853
854         * yy-remap.h: Add include guard.
855         * xtensa-tdep.h: Add include guard.
856         * xcoffread.h: Rename include guard.
857         * varobj-iter.h: Add include guard.
858         * tui/tui.h: Rename include guard.
859         * tui/tui-winsource.h: Rename include guard.
860         * tui/tui-wingeneral.h: Rename include guard.
861         * tui/tui-windata.h: Rename include guard.
862         * tui/tui-win.h: Rename include guard.
863         * tui/tui-stack.h: Rename include guard.
864         * tui/tui-source.h: Rename include guard.
865         * tui/tui-regs.h: Rename include guard.
866         * tui/tui-out.h: Rename include guard.
867         * tui/tui-layout.h: Rename include guard.
868         * tui/tui-io.h: Rename include guard.
869         * tui/tui-hooks.h: Rename include guard.
870         * tui/tui-file.h: Rename include guard.
871         * tui/tui-disasm.h: Rename include guard.
872         * tui/tui-data.h: Rename include guard.
873         * tui/tui-command.h: Rename include guard.
874         * tic6x-tdep.h: Add include guard.
875         * target/waitstatus.h: Rename include guard.
876         * target/wait.h: Rename include guard.
877         * target/target.h: Rename include guard.
878         * target/resume.h: Rename include guard.
879         * target-float.h: Rename include guard.
880         * stabsread.h: Add include guard.
881         * rs6000-tdep.h: Add include guard.
882         * riscv-fbsd-tdep.h: Add include guard.
883         * regformats/regdef.h: Rename include guard.
884         * record.h: Rename include guard.
885         * python/python.h: Rename include guard.
886         * python/python-internal.h: Rename include guard.
887         * python/py-stopevent.h: Rename include guard.
888         * python/py-ref.h: Rename include guard.
889         * python/py-record.h: Rename include guard.
890         * python/py-record-full.h: Rename include guard.
891         * python/py-record-btrace.h: Rename include guard.
892         * python/py-instruction.h: Rename include guard.
893         * python/py-events.h: Rename include guard.
894         * python/py-event.h: Rename include guard.
895         * procfs.h: Add include guard.
896         * proc-utils.h: Add include guard.
897         * p-lang.h: Add include guard.
898         * or1k-tdep.h: Rename include guard.
899         * observable.h: Rename include guard.
900         * nto-tdep.h: Rename include guard.
901         * nat/x86-linux.h: Rename include guard.
902         * nat/x86-linux-dregs.h: Rename include guard.
903         * nat/x86-gcc-cpuid.h: Add include guard.
904         * nat/x86-dregs.h: Rename include guard.
905         * nat/x86-cpuid.h: Rename include guard.
906         * nat/ppc-linux.h: Rename include guard.
907         * nat/mips-linux-watch.h: Rename include guard.
908         * nat/linux-waitpid.h: Rename include guard.
909         * nat/linux-ptrace.h: Rename include guard.
910         * nat/linux-procfs.h: Rename include guard.
911         * nat/linux-osdata.h: Rename include guard.
912         * nat/linux-nat.h: Rename include guard.
913         * nat/linux-namespaces.h: Rename include guard.
914         * nat/linux-btrace.h: Rename include guard.
915         * nat/glibc_thread_db.h: Rename include guard.
916         * nat/gdb_thread_db.h: Rename include guard.
917         * nat/gdb_ptrace.h: Rename include guard.
918         * nat/fork-inferior.h: Rename include guard.
919         * nat/amd64-linux-siginfo.h: Rename include guard.
920         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
921         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
922         * nat/aarch64-linux.h: Rename include guard.
923         * nat/aarch64-linux-hw-point.h: Rename include guard.
924         * mn10300-tdep.h: Add include guard.
925         * mips-linux-tdep.h: Add include guard.
926         * mi/mi-parse.h: Rename include guard.
927         * mi/mi-out.h: Rename include guard.
928         * mi/mi-main.h: Rename include guard.
929         * mi/mi-interp.h: Rename include guard.
930         * mi/mi-getopt.h: Rename include guard.
931         * mi/mi-console.h: Rename include guard.
932         * mi/mi-common.h: Rename include guard.
933         * mi/mi-cmds.h: Rename include guard.
934         * mi/mi-cmd-break.h: Rename include guard.
935         * m2-lang.h: Add include guard.
936         * location.h: Rename include guard.
937         * linux-record.h: Rename include guard.
938         * linux-nat.h: Add include guard.
939         * linux-fork.h: Add include guard.
940         * i386-darwin-tdep.h: Rename include guard.
941         * hppa-linux-offsets.h: Add include guard.
942         * guile/guile.h: Rename include guard.
943         * guile/guile-internal.h: Rename include guard.
944         * gnu-nat.h: Rename include guard.
945         * gdb-stabs.h: Rename include guard.
946         * frv-tdep.h: Add include guard.
947         * f-lang.h: Add include guard.
948         * event-loop.h: Add include guard.
949         * darwin-nat.h: Rename include guard.
950         * cp-abi.h: Rename include guard.
951         * config/sparc/nm-sol2.h: Rename include guard.
952         * config/nm-nto.h: Rename include guard.
953         * config/nm-linux.h: Add include guard.
954         * config/i386/nm-i386gnu.h: Rename include guard.
955         * config/djgpp/nl_types.h: Rename include guard.
956         * config/djgpp/langinfo.h: Rename include guard.
957         * compile/gcc-cp-plugin.h: Add include guard.
958         * compile/gcc-c-plugin.h: Add include guard.
959         * compile/compile.h: Rename include guard.
960         * compile/compile-object-run.h: Rename include guard.
961         * compile/compile-object-load.h: Rename include guard.
962         * compile/compile-internal.h: Rename include guard.
963         * compile/compile-cplus.h: Rename include guard.
964         * compile/compile-c.h: Rename include guard.
965         * common/xml-utils.h: Rename include guard.
966         * common/x86-xstate.h: Rename include guard.
967         * common/version.h: Rename include guard.
968         * common/vec.h: Rename include guard.
969         * common/tdesc.h: Rename include guard.
970         * common/selftest.h: Rename include guard.
971         * common/scoped_restore.h: Rename include guard.
972         * common/scoped_mmap.h: Rename include guard.
973         * common/scoped_fd.h: Rename include guard.
974         * common/safe-iterator.h: Rename include guard.
975         * common/run-time-clock.h: Rename include guard.
976         * common/refcounted-object.h: Rename include guard.
977         * common/queue.h: Rename include guard.
978         * common/ptid.h: Rename include guard.
979         * common/print-utils.h: Rename include guard.
980         * common/preprocessor.h: Rename include guard.
981         * common/pathstuff.h: Rename include guard.
982         * common/observable.h: Rename include guard.
983         * common/netstuff.h: Rename include guard.
984         * common/job-control.h: Rename include guard.
985         * common/host-defs.h: Rename include guard.
986         * common/gdb_wait.h: Rename include guard.
987         * common/gdb_vecs.h: Rename include guard.
988         * common/gdb_unlinker.h: Rename include guard.
989         * common/gdb_unique_ptr.h: Rename include guard.
990         * common/gdb_tilde_expand.h: Rename include guard.
991         * common/gdb_sys_time.h: Rename include guard.
992         * common/gdb_string_view.h: Rename include guard.
993         * common/gdb_splay_tree.h: Rename include guard.
994         * common/gdb_setjmp.h: Rename include guard.
995         * common/gdb_ref_ptr.h: Rename include guard.
996         * common/gdb_optional.h: Rename include guard.
997         * common/gdb_locale.h: Rename include guard.
998         * common/gdb_assert.h: Rename include guard.
999         * common/filtered-iterator.h: Rename include guard.
1000         * common/filestuff.h: Rename include guard.
1001         * common/fileio.h: Rename include guard.
1002         * common/environ.h: Rename include guard.
1003         * common/common-utils.h: Rename include guard.
1004         * common/common-types.h: Rename include guard.
1005         * common/common-regcache.h: Rename include guard.
1006         * common/common-inferior.h: Rename include guard.
1007         * common/common-gdbthread.h: Rename include guard.
1008         * common/common-exceptions.h: Rename include guard.
1009         * common/common-defs.h: Rename include guard.
1010         * common/common-debug.h: Rename include guard.
1011         * common/cleanups.h: Rename include guard.
1012         * common/buffer.h: Rename include guard.
1013         * common/btrace-common.h: Rename include guard.
1014         * common/break-common.h: Rename include guard.
1015         * cli/cli-utils.h: Rename include guard.
1016         * cli/cli-style.h: Rename include guard.
1017         * cli/cli-setshow.h: Rename include guard.
1018         * cli/cli-script.h: Rename include guard.
1019         * cli/cli-interp.h: Rename include guard.
1020         * cli/cli-decode.h: Rename include guard.
1021         * cli/cli-cmds.h: Rename include guard.
1022         * charset-list.h: Add include guard.
1023         * buildsym-legacy.h: Rename include guard.
1024         * bfin-tdep.h: Add include guard.
1025         * ax.h: Rename include guard.
1026         * arm-linux-tdep.h: Add include guard.
1027         * arm-fbsd-tdep.h: Add include guard.
1028         * arch/xtensa.h: Rename include guard.
1029         * arch/tic6x.h: Add include guard.
1030         * arch/i386.h: Add include guard.
1031         * arch/arm.h: Rename include guard.
1032         * arch/arm-linux.h: Rename include guard.
1033         * arch/arm-get-next-pcs.h: Rename include guard.
1034         * arch/amd64.h: Add include guard.
1035         * arch/aarch64-insn.h: Rename include guard.
1036         * arch-utils.h: Rename include guard.
1037         * annotate.h: Add include guard.
1038         * amd64-darwin-tdep.h: Rename include guard.
1039         * aarch64-linux-tdep.h: Add include guard.
1040         * aarch64-fbsd-tdep.h: Add include guard.
1041         * aarch32-linux-nat.h: Add include guard.
1042
1043 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1044
1045         * macrotab.c (macro_define_internal): New function that
1046         factorizes macro_define_object_internal and macro_define_function
1047         code.
1048         (macro_define_object_internal): Use macro_define_internal.
1049         (macro_define_function): Likewise.
1050
1051 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1052
1053         * macrocmd.c (extract_identifier): Return
1054         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
1055         callers.
1056
1057 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1058
1059         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1060
1061 2019-02-05  Tom Tromey  <tom@tromey.com>
1062
1063         * target.c (target_stack::unpush): Move assertion earlier.
1064
1065 2019-01-30  Tom Tromey  <tom@tromey.com>
1066
1067         PR python/23615:
1068         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1069         (gdbpy_parse_and_eval): Likewise.
1070         * python/python-internal.h (gdbpy_allow_threads): New class.
1071
1072 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1073
1074         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1075         (aarch64_fbsd_fpregmap): Move earlier.
1076         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1077         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1078         instead of individual calls to trad_frame_set_reg_addr.
1079         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1080         earlier.
1081         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1082         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1083         instead of individual calls to trad_frame_set_reg_addr.
1084
1085 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1086
1087         * CONTRIBUTE: Replace contribution list with wiki link.
1088
1089 2019-01-25  Tom Tromey  <tom@tromey.com>
1090
1091         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1092
1093 2019-01-25  Tom Tromey  <tom@tromey.com>
1094
1095         * xtensa-linux-nat.c: Fix common/ includes.
1096         * xml-support.h: Fix common/ includes.
1097         * xml-support.c: Fix common/ includes.
1098         * x86-linux-nat.c: Fix common/ includes.
1099         * windows-nat.c: Fix common/ includes.
1100         * varobj.h: Fix common/ includes.
1101         * varobj.c: Fix common/ includes.
1102         * value.c: Fix common/ includes.
1103         * valops.c: Fix common/ includes.
1104         * utils.c: Fix common/ includes.
1105         * unittests/xml-utils-selftests.c: Fix common/ includes.
1106         * unittests/utils-selftests.c: Fix common/ includes.
1107         * unittests/unpack-selftests.c: Fix common/ includes.
1108         * unittests/tracepoint-selftests.c: Fix common/ includes.
1109         * unittests/style-selftests.c: Fix common/ includes.
1110         * unittests/string_view-selftests.c: Fix common/ includes.
1111         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1112         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1113         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1114         * unittests/rsp-low-selftests.c: Fix common/ includes.
1115         * unittests/parse-connection-spec-selftests.c: Fix common/
1116         includes.
1117         * unittests/optional-selftests.c: Fix common/ includes.
1118         * unittests/offset-type-selftests.c: Fix common/ includes.
1119         * unittests/observable-selftests.c: Fix common/ includes.
1120         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1121         * unittests/memrange-selftests.c: Fix common/ includes.
1122         * unittests/memory-map-selftests.c: Fix common/ includes.
1123         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1124         * unittests/function-view-selftests.c: Fix common/ includes.
1125         * unittests/environ-selftests.c: Fix common/ includes.
1126         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1127         * unittests/common-utils-selftests.c: Fix common/ includes.
1128         * unittests/cli-utils-selftests.c: Fix common/ includes.
1129         * unittests/array-view-selftests.c: Fix common/ includes.
1130         * ui-file.c: Fix common/ includes.
1131         * tui/tui-io.c: Fix common/ includes.
1132         * tracepoint.h: Fix common/ includes.
1133         * tracepoint.c: Fix common/ includes.
1134         * tracefile-tfile.c: Fix common/ includes.
1135         * top.h: Fix common/ includes.
1136         * top.c: Fix common/ includes.
1137         * thread.c: Fix common/ includes.
1138         * target/waitstatus.h: Fix common/ includes.
1139         * target/waitstatus.c: Fix common/ includes.
1140         * target.h: Fix common/ includes.
1141         * target.c: Fix common/ includes.
1142         * target-memory.c: Fix common/ includes.
1143         * target-descriptions.c: Fix common/ includes.
1144         * symtab.h: Fix common/ includes.
1145         * symfile.c: Fix common/ includes.
1146         * stap-probe.c: Fix common/ includes.
1147         * spu-linux-nat.c: Fix common/ includes.
1148         * sparc-nat.c: Fix common/ includes.
1149         * source.c: Fix common/ includes.
1150         * solib.c: Fix common/ includes.
1151         * solib-target.c: Fix common/ includes.
1152         * ser-unix.c: Fix common/ includes.
1153         * ser-tcp.c: Fix common/ includes.
1154         * ser-pipe.c: Fix common/ includes.
1155         * ser-base.c: Fix common/ includes.
1156         * selftest-arch.c: Fix common/ includes.
1157         * s12z-tdep.c: Fix common/ includes.
1158         * rust-exp.y: Fix common/ includes.
1159         * rs6000-aix-tdep.c: Fix common/ includes.
1160         * riscv-tdep.c: Fix common/ includes.
1161         * remote.c: Fix common/ includes.
1162         * remote-notif.h: Fix common/ includes.
1163         * remote-fileio.h: Fix common/ includes.
1164         * remote-fileio.c: Fix common/ includes.
1165         * regcache.h: Fix common/ includes.
1166         * regcache.c: Fix common/ includes.
1167         * record-btrace.c: Fix common/ includes.
1168         * python/python.c: Fix common/ includes.
1169         * python/py-type.c: Fix common/ includes.
1170         * python/py-inferior.c: Fix common/ includes.
1171         * progspace.h: Fix common/ includes.
1172         * producer.c: Fix common/ includes.
1173         * procfs.c: Fix common/ includes.
1174         * proc-api.c: Fix common/ includes.
1175         * printcmd.c: Fix common/ includes.
1176         * ppc-linux-nat.c: Fix common/ includes.
1177         * parser-defs.h: Fix common/ includes.
1178         * osdata.c: Fix common/ includes.
1179         * obsd-nat.c: Fix common/ includes.
1180         * nat/x86-linux.c: Fix common/ includes.
1181         * nat/x86-linux-dregs.c: Fix common/ includes.
1182         * nat/x86-dregs.h: Fix common/ includes.
1183         * nat/x86-dregs.c: Fix common/ includes.
1184         * nat/ppc-linux.c: Fix common/ includes.
1185         * nat/mips-linux-watch.h: Fix common/ includes.
1186         * nat/mips-linux-watch.c: Fix common/ includes.
1187         * nat/linux-waitpid.c: Fix common/ includes.
1188         * nat/linux-ptrace.h: Fix common/ includes.
1189         * nat/linux-ptrace.c: Fix common/ includes.
1190         * nat/linux-procfs.c: Fix common/ includes.
1191         * nat/linux-personality.c: Fix common/ includes.
1192         * nat/linux-osdata.c: Fix common/ includes.
1193         * nat/linux-namespaces.c: Fix common/ includes.
1194         * nat/linux-btrace.h: Fix common/ includes.
1195         * nat/linux-btrace.c: Fix common/ includes.
1196         * nat/fork-inferior.c: Fix common/ includes.
1197         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1198         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1199         * nat/aarch64-linux.c: Fix common/ includes.
1200         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1201         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1202         * namespace.h: Fix common/ includes.
1203         * mips-linux-tdep.c: Fix common/ includes.
1204         * minsyms.c: Fix common/ includes.
1205         * mi/mi-parse.h: Fix common/ includes.
1206         * mi/mi-main.c: Fix common/ includes.
1207         * mi/mi-cmd-env.c: Fix common/ includes.
1208         * memrange.h: Fix common/ includes.
1209         * memattr.c: Fix common/ includes.
1210         * maint.h: Fix common/ includes.
1211         * maint.c: Fix common/ includes.
1212         * main.c: Fix common/ includes.
1213         * machoread.c: Fix common/ includes.
1214         * location.c: Fix common/ includes.
1215         * linux-thread-db.c: Fix common/ includes.
1216         * linux-nat.c: Fix common/ includes.
1217         * linux-fork.c: Fix common/ includes.
1218         * inline-frame.c: Fix common/ includes.
1219         * infrun.c: Fix common/ includes.
1220         * inflow.c: Fix common/ includes.
1221         * inferior.h: Fix common/ includes.
1222         * inferior.c: Fix common/ includes.
1223         * infcmd.c: Fix common/ includes.
1224         * inf-ptrace.c: Fix common/ includes.
1225         * inf-child.c: Fix common/ includes.
1226         * ia64-linux-nat.c: Fix common/ includes.
1227         * i387-tdep.c: Fix common/ includes.
1228         * i386-tdep.c: Fix common/ includes.
1229         * i386-linux-tdep.c: Fix common/ includes.
1230         * i386-linux-nat.c: Fix common/ includes.
1231         * i386-go32-tdep.c: Fix common/ includes.
1232         * i386-fbsd-tdep.c: Fix common/ includes.
1233         * i386-fbsd-nat.c: Fix common/ includes.
1234         * guile/scm-type.c: Fix common/ includes.
1235         * guile/guile.c: Fix common/ includes.
1236         * go32-nat.c: Fix common/ includes.
1237         * gnu-nat.c: Fix common/ includes.
1238         * gdbthread.h: Fix common/ includes.
1239         * gdbarch-selftests.c: Fix common/ includes.
1240         * gdb_usleep.c: Fix common/ includes.
1241         * gdb_select.h: Fix common/ includes.
1242         * gdb_bfd.c: Fix common/ includes.
1243         * gcore.c: Fix common/ includes.
1244         * fork-child.c: Fix common/ includes.
1245         * findvar.c: Fix common/ includes.
1246         * fbsd-nat.c: Fix common/ includes.
1247         * event-top.c: Fix common/ includes.
1248         * event-loop.c: Fix common/ includes.
1249         * dwarf2read.c: Fix common/ includes.
1250         * dwarf2loc.c: Fix common/ includes.
1251         * dwarf2-frame.c: Fix common/ includes.
1252         * dwarf-index-cache.c: Fix common/ includes.
1253         * dtrace-probe.c: Fix common/ includes.
1254         * disasm-selftests.c: Fix common/ includes.
1255         * defs.h: Fix common/ includes.
1256         * csky-tdep.c: Fix common/ includes.
1257         * cp-valprint.c: Fix common/ includes.
1258         * cp-support.h: Fix common/ includes.
1259         * cp-support.c: Fix common/ includes.
1260         * corelow.c: Fix common/ includes.
1261         * completer.h: Fix common/ includes.
1262         * completer.c: Fix common/ includes.
1263         * compile/compile.c: Fix common/ includes.
1264         * compile/compile-loc2c.c: Fix common/ includes.
1265         * compile/compile-cplus-types.c: Fix common/ includes.
1266         * compile/compile-cplus-symbols.c: Fix common/ includes.
1267         * command.h: Fix common/ includes.
1268         * cli/cli-dump.c: Fix common/ includes.
1269         * cli/cli-cmds.c: Fix common/ includes.
1270         * charset.c: Fix common/ includes.
1271         * build-id.c: Fix common/ includes.
1272         * btrace.h: Fix common/ includes.
1273         * btrace.c: Fix common/ includes.
1274         * breakpoint.h: Fix common/ includes.
1275         * breakpoint.c: Fix common/ includes.
1276         * ax.h: 
1277         (enum agent_op): Fix common/ includes.
1278         * ax-general.c (struct aop_map): Fix common/ includes.
1279         * ax-gdb.c: Fix common/ includes.
1280         * auxv.c: Fix common/ includes.
1281         * auto-load.c: Fix common/ includes.
1282         * arm-tdep.c: Fix common/ includes.
1283         * arch/riscv.c: Fix common/ includes.
1284         * arch/ppc-linux-common.c: Fix common/ includes.
1285         * arch/i386.c: Fix common/ includes.
1286         * arch/arm.c: Fix common/ includes.
1287         * arch/arm-linux.c: Fix common/ includes.
1288         * arch/arm-get-next-pcs.c: Fix common/ includes.
1289         * arch/amd64.c: Fix common/ includes.
1290         * arch/aarch64.c: Fix common/ includes.
1291         * arch/aarch64-insn.c: Fix common/ includes.
1292         * arch-utils.c: Fix common/ includes.
1293         * amd64-windows-tdep.c: Fix common/ includes.
1294         * amd64-tdep.c: Fix common/ includes.
1295         * amd64-sol2-tdep.c: Fix common/ includes.
1296         * amd64-obsd-tdep.c: Fix common/ includes.
1297         * amd64-nbsd-tdep.c: Fix common/ includes.
1298         * amd64-linux-tdep.c: Fix common/ includes.
1299         * amd64-linux-nat.c: Fix common/ includes.
1300         * amd64-fbsd-tdep.c: Fix common/ includes.
1301         * amd64-fbsd-nat.c: Fix common/ includes.
1302         * amd64-dicos-tdep.c: Fix common/ includes.
1303         * amd64-darwin-tdep.c: Fix common/ includes.
1304         * agent.c: Fix common/ includes.
1305         * ada-lang.h: Fix common/ includes.
1306         * ada-lang.c: Fix common/ includes.
1307         * aarch64-tdep.c: Fix common/ includes.
1308
1309 2019-01-25  Tom Tromey  <tom@tromey.com>
1310
1311         * common/create-version.sh: Use common/version.h.
1312
1313 2019-01-24  Pedro Alves  <palves@redhat.com>
1314
1315         * infrun.c (signal_stop, signal_print, signal_program)
1316         (signal_catch, signal_pass): Now arrays instead of pointers.
1317         (update_signals_program_target, do_target_resume)
1318         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1319         * linux-nat.c (linux_nat_target::pass_signals)
1320         (linux_nat_target::create_inferior, linux_nat_target::attach):
1321         Adjust.
1322         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1323         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1324         * procfs.c (procfs_target::pass_signals): Adjust.
1325         * record-full.c (record_full_target::resume): Adjust.
1326         * remote.c (remote_target::pass_signals)
1327         (remote_target::program_signals): Adjust.
1328         * target-debug.h (target_debug_print_signals): Now takes a
1329         gdb::array_view as parameter.  Adjust.
1330         * target.h (target_ops) <pass_signals, program_signals>: Replace
1331         pointer and length parameters with gdb::array_view.
1332         (target_pass_signals, target_program_signals): Likewise.
1333         * target-delegates.c: Regenerate.
1334
1335 2019-01-24  Pedro Alves  <palves@redhat.com>
1336
1337         * common/forward-scope-exit.h
1338         (forward_scope_exit::forward_scope_exit): Pass arguments to
1339         m_bind_function directly, instead of creating a std::bind and
1340         copying that.
1341
1342 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1343
1344         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1345         for static members.
1346         (pass_in_v_vfp_candidate): Likewise.
1347
1348 2019-01-23  Tom Tromey  <tom@tromey.com>
1349             Pedro Alves  <palves@redhat.com>
1350
1351         * regcache.c (class regcache_invalidator): Remove.
1352         (regcache::raw_write): Use make_scope_exit.
1353
1354 2019-01-23  Tom Tromey  <tom@tromey.com>
1355
1356         * ui-out.h (class ui_out_emit_type): Update comment.
1357
1358 2019-01-23  Tom Tromey  <tom@tromey.com>
1359
1360         * infrun.c (fetch_inferior_event): Update comment.
1361
1362 2019-01-23  Tom Tromey  <tom@tromey.com>
1363             Pedro Alves  <palves@redhat.com>
1364
1365         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1366         parameter.
1367         (fetch_inferior_event): Use SCOPE_EXIT.
1368
1369
1370 2019-01-23  Tom Tromey  <tom@tromey.com>
1371             Pedro Alves  <palves@redhat.com>
1372
1373         * infrun.c (disable_thread_events): Delete.
1374         (stop_all_threads): Use SCOPE_EXIT.
1375
1376 2019-01-23  Tom Tromey  <tom@tromey.com>
1377             Pedro Alves  <palves@redhat.com>
1378
1379         * symfile.c: Include forward-scope-exit.h.
1380         (clear_symtab_users_cleanup): Replace forward declaration with
1381         a FORWARD_SCOPE_EXIT.
1382         (syms_from_objfile_1): Use the forward_scope_exit and
1383         gdb::optional instead of cleanup_function.
1384         (reread_symbols): Use the forward_scope_exit instead of
1385         cleanup_function.
1386         (clear_symtab_users_cleanup): Remove function.
1387
1388 2019-01-23  Tom Tromey  <tom@tromey.com>
1389             Pedro Alves  <palves@redhat.com>
1390
1391         * linux-nat.c: Include scope-exit.h.
1392         (cleanup_target_stop): Remove.
1393         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1394         SCOPE_EXIT.
1395
1396 2019-01-23  Tom Tromey  <tom@tromey.com>
1397             Pedro Alves  <palves@redhat.com>
1398
1399         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1400         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1401
1402 2019-01-23  Tom Tromey  <tom@tromey.com>
1403             Andrew Burgess  <andrew.burgess@embecosm.com>
1404             Pedro Alves  <palves@redhat.com>
1405
1406         * infrun.c (fetch_inferior_event): Use scope_exit.
1407         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1408         * top.c (execute_command): Use scope_exit.
1409         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1410         * utils.c (do_bpstat_clear_actions_cleanup)
1411         (make_bpstat_clear_actions_cleanup): Remove.
1412
1413 2019-01-23  Tom Tromey  <tom@tromey.com>
1414             Pedro Alves  <palves@redhat.com>
1415
1416         * infrun.c: Include "common/scope-exit.h"
1417         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1418         (wait_for_inferior): Use SCOPE_EXIT.
1419         (fetch_inferior_event): Use scope_exit.
1420
1421 2019-01-23  Tom Tromey  <tom@tromey.com>
1422             Pedro Alves  <palves@redhat.com>
1423
1424         * breakpoint.c (create_breakpoint): Remove cleanup.
1425
1426 2019-01-23  Tom Tromey  <tom@tromey.com>
1427             Andrew Burgess  <andrew.burgess@embecosm.com>
1428             Pedro Alves  <palves@redhat.com>
1429
1430 2019-01-23  Pedro Alves  <palves@redhat.com>
1431
1432         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1433
1434 2019-01-23  Pedro Alves  <palves@redhat.com>
1435             Andrew Burgess  <andrew.burgess@embecosm.com>
1436
1437         * gdbthread.h: Include "common/forward-scope-exit.h".
1438         (scoped_finish_thread_state): Redefine custom class in terms of
1439         forward_scope_exit.
1440
1441 2019-01-23  Pedro Alves  <palves@redhat.com>
1442             Andrew Burgess  <andrew.burgess@embecosm.com>
1443
1444         * common/forward-scope-exit.h: New file.
1445
1446 2019-01-23  Pedro Alves  <palves@redhat.com>
1447             Andrew Burgess  <andrew.burgess@embecosm.com>
1448             Tom Tromey  <tom@tromey.com>
1449
1450         * common/scope-exit.h: New file.
1451
1452 2019-01-23  Pedro Alves  <palves@redhat.com>
1453
1454         * common/preprocessor.h (ESC): Rename to ...
1455         (ESC_PARENS): ... this.
1456         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1457         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1458
1459 2019-01-23  Tom Tromey  <tom@tromey.com>
1460
1461         * language.h (class scoped_switch_to_sym_language_if_auto):
1462         Initialize m_lang in both cases.
1463
1464 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1465
1466         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1467         with XCNEW.
1468
1469 2019-01-22  Tom Tromey  <tom@tromey.com>
1470
1471         * corelow.c: Do not include sys/file.h.
1472
1473 2019-01-22  Tom Tromey  <tom@tromey.com>
1474
1475         * tui/tui-wingeneral.h: Include gdb_curses.h.
1476
1477 2019-01-22  Tom Tromey  <tom@tromey.com>
1478
1479         * source-cache.h (class source_cache) <get_source_lines,
1480         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1481
1482 2019-01-22  Tom Tromey  <tom@tromey.com>
1483
1484         * remote-fileio.h (struct remote_target): Declare.
1485
1486 2019-01-22  Tom Tromey  <tom@tromey.com>
1487
1488         * python/py-arch.c: Do not include py-ref.h.
1489         * python/py-bpevent.c: Do not include py-ref.h.
1490         * python/py-cmd.c: Do not include py-ref.h.
1491         * python/py-continueevent.c: Do not include py-ref.h.
1492         * python/py-event.h: Do not include py-ref.h.
1493         * python/py-evtregistry.c: Do not include py-ref.h.
1494         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1495         * python/py-frame.c: Do not include py-ref.h.
1496         * python/py-framefilter.c: Do not include py-ref.h.
1497         * python/py-function.c: Do not include py-ref.h.
1498         * python/py-infevents.c: Do not include py-ref.h.
1499         * python/py-linetable.c: Do not include py-ref.h.
1500         * python/py-objfile.c: Do not include py-ref.h.
1501         * python/py-param.c: Do not include py-ref.h.
1502         * python/py-prettyprint.c: Do not include py-ref.h.
1503         * python/py-progspace.c: Do not include py-ref.h.
1504         * python/py-symbol.c: Do not include py-ref.h.
1505         * python/py-symtab.c: Do not include py-ref.h.
1506         * python/py-type.c: Do not include py-ref.h.
1507         * python/py-unwind.c: Do not include py-ref.h.
1508         * python/py-utils.c: Do not include py-ref.h.
1509         * python/py-value.c: Do not include py-ref.h.
1510         * python/py-varobj.c: Do not include py-ref.h.
1511         * python/py-xmethods.c: Do not include py-ref.h.
1512         * python/python.c: Do not include py-ref.h.
1513         * varobj.c: Do not include py-ref.h.
1514
1515 2019-01-22  Tom Tromey  <tom@tromey.com>
1516
1517         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1518         keyword for bcache.
1519
1520 2019-01-22  Tom Tromey  <tom@tromey.com>
1521
1522         * compile/compile-cplus-types.c: Remove a comment by #include.
1523
1524 2019-01-22  Tom Tromey  <tom@tromey.com>
1525
1526         * compile/gcc-c-plugin.h: Include compile-internal.h.
1527
1528 2019-01-22  Tom Tromey  <tom@tromey.com>
1529
1530         * stabsread.c (EXTERN): Do not define.
1531         (symnum, next_symbol_text_func, processing_gcc_compilation)
1532         (within_function, global_sym_chain, global_stabs)
1533         (previous_stab_code, this_object_header_files)
1534         (n_this_object_header_files)
1535         (n_allocated_this_object_header_files): Define.
1536         * stabsread.h (EXTERN): Never define.  Use "extern".
1537
1538 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1539
1540         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1541         history_value.
1542
1543 2019-01-21  Tom Tromey  <tom@tromey.com>
1544
1545         * ui-out.c: Fix includes.
1546         * tui/tui-source.c: Fix includes.
1547         * target.c: Fix includes.
1548         * remote.c: Fix includes.
1549         * regcache.c: Fix includes.
1550         * python/py-block.c: Fix includes.
1551         * printcmd.c: Fix includes.
1552         * or1k-tdep.c: Fix includes.
1553         * mi/mi-main.c: Fix includes.
1554         * m32r-tdep.c: Fix includes.
1555         * csky-tdep.c: Fix includes.
1556         * compile/compile-cplus-types.c: Fix includes.
1557         * cli/cli-interp.c: Fix includes.
1558
1559 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1560
1561         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1562         for padding.
1563
1564 2019-01-16  Tom Tromey  <tom@tromey.com>
1565
1566         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1567         earlier.
1568         (struct objfile) <msymbols_range>: Move from top level.
1569         <msymbols>: New method.
1570         (class objfile_msymbols): Remove.
1571         * symtab.c (default_collect_symbol_completion_matches_break_on):
1572         Update.
1573         * symmisc.c (dump_msymbols): Update.
1574         * stabsread.c (scan_file_globals): Update.
1575         * objc-lang.c (info_selectors_command, info_classes_command)
1576         (find_methods): Update.
1577         * minsyms.c (find_solib_trampoline_target): Update.
1578         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1579         * coffread.c (coff_symfile_read): Update.
1580         * ada-lang.c (ada_lookup_simple_minsym)
1581         (ada_collect_symbol_completion_matches): Update.
1582
1583 2019-01-16  Tom Tromey  <tom@tromey.com>
1584
1585         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1586         type.  Remove no-argument constructor.
1587         <iterator::operator++>: Simplify.
1588         <begin>: Update.
1589         <end>: Use minimal_symbol_count.
1590
1591 2019-01-16  Tom Tromey  <tom@tromey.com>
1592
1593         * objfiles.h (struct objfile) <psymtabs>: New method.
1594         (class objfile_psymtabs): Remove.
1595         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1596         typedef.
1597         <range>: New method.
1598         (require_partial_symbols): Change return type.
1599         * psymtab.c (require_partial_symbols)
1600         (psym_expand_symtabs_matching): Update.
1601         * mdebugread.c (parse_partial_symbols): Update.
1602         * dbxread.c (dbx_end_psymtab): Update.
1603
1604 2019-01-15  Tom Tromey  <tom@tromey.com>
1605
1606         * symtab.c (lookup_objfile_from_block)
1607         (lookup_symbol_in_objfile_symtabs)
1608         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1609         (find_line_symtab, info_sources_command)
1610         (default_collect_symbol_completion_matches_break_on)
1611         (make_source_files_completion_list): Update.
1612         * symmisc.c (print_objfile_statistics, dump_objfile)
1613         (maintenance_print_symbols, maintenance_info_symtabs)
1614         (maintenance_check_symtabs, maintenance_info_line_tables):
1615         Update.
1616         * source.c (select_source_symtab)
1617         (forget_cached_source_info_for_objfile): Update.
1618         * objfiles.h (class objfile_compunits): Remove.
1619         (struct objfile) <compunits_range>: New typedef.
1620         (compunits): New method.
1621         * objfiles.c (objfile_relocate1): Update.
1622         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1623         * maint.c (count_symtabs_and_blocks): Update.
1624         * linespec.c (iterate_over_all_matching_symtabs): Update.
1625         * cp-support.c (add_symbol_overload_list_qualified): Update.
1626         * coffread.c (coff_symtab_read): Update.
1627         * ada-lang.c (add_nonlocal_symbols)
1628         (ada_collect_symbol_completion_matches)
1629         (ada_add_global_exceptions): Update.
1630
1631 2019-01-15  Tom Tromey  <tom@tromey.com>
1632
1633         * progspace.h (program_space) <objfiles_safe_range>: New
1634         typedef.
1635         <objfiles_safe>: New method.
1636         * objfiles.h (class all_objfiles_safe): Remove.
1637         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1638         * jit.c (jit_inferior_exit_hook): Update.
1639
1640 2019-01-17  Tom Tromey  <tom@tromey.com>
1641
1642         * progspace.h (program_space) <objfiles_range>: New typedef.
1643         <objfiles>: New method.
1644         <objfiles_head>: Rename from objfiles.
1645         (object_files): Update.
1646         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1647         * guile/scm-pretty-print.c
1648         (ppscm_find_pretty_printer_from_objfiles): Update.
1649         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1650         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1651         Update.
1652         * python/py-progspace.c (pspy_get_objfiles): Update.
1653         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1654         Update.
1655         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1656         (objfpy_lookup_objfile_by_build_id): Update.
1657         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1658         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1659         Update.
1660         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1661         (expand_symtab_containing_pc, lookup_objfile_from_block)
1662         (lookup_static_symbol, basic_lookup_transparent_type)
1663         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1664         (find_line_symtab, info_sources_command)
1665         (default_collect_symbol_completion_matches_break_on)
1666         (make_source_files_completion_list, find_main_name): Update.
1667         * symmisc.c (print_symbol_bcache_statistics)
1668         (print_objfile_statistics, maintenance_print_symbols)
1669         (maintenance_print_msymbols, maintenance_print_objfiles)
1670         (maintenance_info_symtabs, maintenance_check_symtabs)
1671         (maintenance_expand_symtabs, maintenance_info_line_tables):
1672         Update.
1673         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1674         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1675         (map_overlay_command, unmap_overlay_command)
1676         (simple_overlay_update, expand_symtabs_matching)
1677         (map_symbol_filenames): Update.
1678         * symfile-debug.c (set_debug_symfile): Update.
1679         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1680         Update.
1681         * source.c (select_source_symtab, forget_cached_source_info):
1682         Update.
1683         * solib.c (solib_read_symbols): Update.
1684         * solib-spu.c (append_ocl_sos): Update.
1685         * psymtab.c (maintenance_print_psymbols)
1686         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1687         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1688         * printcmd.c (info_symbol_command): Update.
1689         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1690         Update.
1691         * objfiles.h (class all_objfiles): Remove.
1692         * objfiles.c (have_partial_symbols, have_full_symbols)
1693         (have_minimal_symbols, qsort_cmp, update_section_map)
1694         (shared_objfile_contains_address_p)
1695         (default_iterate_over_objfiles_in_search_order): Update.
1696         * objc-lang.c (info_selectors_command, info_classes_command)
1697         (find_methods): Update.
1698         * minsyms.c (find_solib_trampoline_target): Update.
1699         * maint.c (maintenance_info_sections)
1700         (maintenance_translate_address, count_symtabs_and_blocks):
1701         Update.
1702         * main.c (captured_main_1): Update.
1703         * linux-thread-db.c (try_thread_db_load_from_pdir)
1704         (has_libpthread): Update.
1705         * linespec.c (iterate_over_all_matching_symtabs)
1706         (search_minsyms_for_name): Update.
1707         * jit.c (jit_find_objf_with_entry_addr): Update.
1708         * hppa-tdep.c (find_unwind_entry)
1709         (hppa_lookup_stub_minimal_symbol): Update.
1710         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1711         Update.
1712         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1713         (elf_gnu_ifunc_resolve_by_got): Update.
1714         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1715         * dwarf-index-write.c (save_gdb_index_command): Update.
1716         * cp-support.c (add_symbol_overload_list_qualified): Update.
1717         * breakpoint.c (create_overlay_event_breakpoint)
1718         (create_longjmp_master_breakpoint)
1719         (create_std_terminate_master_breakpoint)
1720         (create_exception_master_breakpoint): Update.
1721         * blockframe.c (find_pc_partial_function): Update.
1722         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1723         (ada_collect_symbol_completion_matches)
1724         (ada_add_global_exceptions): Update.
1725
1726 2019-01-17  Tom Tromey  <tom@tromey.com>
1727
1728         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1729         declare VEC.
1730         (solib_target_parse_libraries): Change return type.
1731         (library_list_start_segment, library_list_start_section)
1732         (library_list_end_library, library_list_start_library); Update.
1733         (solib_target_free_library_list): Remove.
1734         (solib_target_parse_libraries): Remove cleanup.  Change return
1735         type.
1736         (solib_target_current_sos): Update.
1737
1738 2019-01-17  Tom Tromey  <tromey@bapiya>
1739
1740         * valprint.c: Replace "the the" with "the".
1741         * symtab.c: Replace "the the" with "the".
1742         * solib.c: Replace "the the" with "the".
1743         * solib-dsbt.c: Replace "the the" with "the".
1744         * linespec.c: Replace "the the" with "the".
1745         * dwarf2loc.h: Replace "the the" with "the".
1746         * amd64-windows-tdep.c: Replace "the the" with "the".
1747         * aarch64-tdep.c: Replace "the the" with "the".
1748
1749 2019-01-16  Keith Seitz  <keiths@redhat.com>
1750
1751         PR gdb/23773
1752         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1753         <builder>: Rename to ..
1754         <m_builder>: ... this and make private.
1755         (dwarf2_cu::get_builder): New method.  Change all users of
1756         `builder' to use this method.
1757         (dwarf2_start_symtab): Move to ...
1758         (dwarf2_cu::start_symtab): ... here.  Update all callers
1759         (setup_type_unit_groups): Move to ...
1760         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1761         callers.
1762         (dwarf2_cu::reset_builder): New method.
1763         (process_full_compunit, process_full_type_unit): Use
1764         dwarf2_cu::reset_builder.
1765         (follow_die_offset): Record the ancestor CU if it is different
1766         from the followed DIE's CU.
1767         (follow_die_sig_1): Likewise.
1768
1769 2019-01-15  Tom Tromey  <tom@tromey.com>
1770
1771         * remote.c (class remote_state) <buf>: Now a char_vector.
1772         <buf_size>: Remove.
1773         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1774         parameter.
1775         (remote_target::getpkt_or_notif_sane_1)
1776         (remote_target::getpkt_sane)
1777         (remote_target::getpkt_or_notif_sane): Likewise.
1778         (class remote_target) <putpkt>: New overload.
1779         (remote_target::read_frame): Change type of "buf_p".  Remove
1780         sizeof_p parameter.
1781         (packet_ok): New overload.
1782         (packet_check_result): New overload.
1783         Update all uses.
1784
1785 2019-01-14  Tom Tromey  <tom@tromey.com>
1786
1787         * remote-notif.c (handle_notification, remote_notif_ack)
1788         (remote_notif_parse): Make "buf" const.
1789         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1790         const.
1791         (remote_notif_parse, remote_notif_ack, handle_notification):
1792         Likewise.
1793         * remote.c (remote_notif_stop_parse): Make "buf" const.
1794         (remote_target::remote_parse_stop_reply): Make "buf" const.
1795         (remote_notif_stop_ack): Make "buf" const.
1796
1797 2019-01-14  Tom Tromey  <tom@tromey.com>
1798
1799         * remote.c (remote_console_output): Make parameter const.
1800
1801 2019-01-14  Tom Tromey  <tom@tromey.com>
1802
1803         * target-debug.h (target_debug_print_signals): Constify.
1804         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1805         * procfs.c (procfs_target::pass_signals): Update.
1806         * linux-nat.c (linux_nat_target::pass_signals): Update.
1807         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1808         * target-delegates.c: Rebuild.
1809         * remote.c (remote_target::program_signals): Update.
1810         (remote_target::pass_signals): Update.
1811         * target.c (target_pass_signals): Constify argument.
1812         (target_program_signals): Likewise.
1813         * target.h (struct target_ops) <pass_signals, program_signals>:
1814         Constify argument.
1815         (target_pass_signals, target_program_signals): Constify argument.
1816
1817 2019-01-14  Tom Tromey  <tom@tromey.com>
1818
1819         PR tui/28819:
1820         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1821
1822 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1823
1824         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1825         field.
1826         * rs6000-tdep.c: Include reggroups.h.
1827         (IS_V_ALIAS_PSEUDOREG): Define.
1828         (rs6000_register_name): Return names for the "vX" aliases.
1829         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1830         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1831         aliases.  Call default_register_reggroup_p for all other
1832         pseudo-registers.
1833         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1834         New functions.
1835         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1836         Handle "vX" aliases.
1837         (v_alias_pseudo_register_collect): New function.
1838         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1839         (rs6000_gdbarch_init): Initialize "vX" aliases as
1840         pseudo-registers.  Restore registration of
1841         rs6000_pseudo_register_reggroup_p with
1842         set_tdesc_pseudo_register_reggroup_p.
1843
1844 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1845
1846         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1847         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1848         set_gdbarch_num_pseudo_regs.
1849
1850 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1851
1852         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1853         Remove arg prefixname, add do_set and do_show.
1854         Add member functions set_list and show_list.
1855         * cli/cli-style.c (class cli_style_option): Update accordingly.
1856         (style_set_list): Move to file scope.
1857         (style_show_list): Likewise.
1858         (set_style): Call help_list.
1859         (show_style): Call cmd_show_list.
1860         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1861         Update to use the new macro.
1862
1863 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1864
1865         * ada-lang.c (_initialize_ada_language): Expand the help text
1866         for the "catch exception" command.
1867
1868 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1869
1870         * symtab.c (matching_obj_sections): Initialize obj,
1871         declare it closer to its usage.
1872
1873 2019-01-10  Tom Tromey  <tom@tromey.com>
1874
1875         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1876         (basic_inf_threads_range): Remove.
1877         (inf_threads_range, inf_non_exited_threads_range)
1878         (safe_inf_threads_range): Use next_adapter.
1879
1880 2019-01-10  Keith Seitz  <keiths@redhat.com>
1881
1882         PR gdb/23712
1883         PR symtab/23010
1884         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1885         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1886
1887 2019-01-10  Keith Seitz  <keiths@redhat.com>
1888
1889         PR gdb/23712
1890         PR symtab/23010
1891         * dictionary.c (pending_to_vector): Remove.
1892         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1893         Remove _1 suffix, replacing functions of the same name.  Update
1894         all callers.
1895         (dict_create_hashed, dict_create_hashed_expandable)
1896         (dict_create_linear, dict_create_linear_expandable, dict_free)
1897         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1898         Make functions static.
1899
1900 2019-01-10  Keith Seitz  <keiths@redhat.com>
1901
1902         PR gdb/23712
1903         PR symtab/23010
1904         * dictionary.h (struct dictionary): Replace declaration with
1905         multidictionary.
1906         (dict_create_hashed, dict_create_hashed_expandable)
1907         (dict_create_linear, dict_create_linear_expandable)
1908         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1909         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1910         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1911         taking multidictionary argument.
1912         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1913         * block.h (struct block) <dict>: Change to multidictionary
1914         and rename `multidict'.
1915         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1916         symmisc.c: Update all dictionary references to multidictionary.
1917
1918 2019-01-10  Keith Seitz  <keiths@redhat.com>
1919
1920         PR gdb/23712
1921         PR symtab/23010
1922         * dictionary.c: Include unordered_map.
1923         (pending_to_vector): New function.
1924         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1925         Rewrite the non-"_1" functions to take vector instead
1926         of linked list.
1927         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1928         "new" _1 versions of the same name.
1929         (multidictionary): Define.
1930         (std::hash<enum language): New definition.
1931         (collate_pending_symbols_by_language, mdict_create_hashed)
1932         (mdict_create_hashed_expandable, mdict_create_linear)
1933         (mdict_create_linear_expandable, mdict_free)
1934         (find_language_dictionary, create_new_language_dictionary)
1935         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1936         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1937         (mdict_size, mdict_empty): New functions.
1938         * dictionary.h (mdict_iterator): Define.
1939
1940 2019-01-10  Pedro Alves  <palves@redhat.com>
1941
1942         * breakpoint.c (read_uploaded_action)
1943         (create_tracepoint_from_upload): Adjust to use
1944         gdb::unique_xmalloc_ptr.
1945         * ctf.c (ctf_write_uploaded_tp):
1946         (SET_ARRAY_FIELD): Use emplace_back.
1947         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1948         * tracefile-tfile.c (tfile_write_uploaded_tp):
1949         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1950         gdb::unique_xmalloc_ptr.
1951         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1952         at_string, cond_string, cmd_strings>: Replace char pointers
1953         with gdb::unique_xmalloc_ptr.
1954
1955 2019-01-10  Pedro Alves  <palves@redhat.com>
1956
1957         * solib-target.c (library_list_start_library): Don't xstrdup name.
1958
1959 2019-01-10  Pedro Alves  <palves@redhat.com>
1960
1961         * mdebugread.c (parse_partial_symbols): Use
1962         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1963
1964 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1965
1966         * linux-fork.c (scoped_switch_fork_info)
1967         <~scoped_switch_fork_info>: Fix incorrect variable name.
1968
1969 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1970
1971         * linux-fork.c (scoped_switch_fork_info)
1972         <scoped_switch_fork_info>: Make explicit.
1973         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1974
1975 2019-01-10  Tom Tromey  <tom@tromey.com>
1976
1977         * objfiles.h (objfile::reset_psymtabs): Update.
1978         * objfiles.c (objfile::objfile): Update.
1979         * psymtab.h (psymtab_storage::obstack): Update.
1980         (psymtab_storage::m_obstack): Use gdb::optional.
1981         (class psymtab_storage): Update comment.  Remove objfile
1982         parameter.
1983         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1984
1985 2019-01-10  Tom Tromey  <tom@tromey.com>
1986
1987         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1988         <free_psymtabs>: Now private.
1989         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1990         (allocate_psymtab): Use new method.
1991
1992 2019-01-10  Tom Tromey  <tom@tromey.com>
1993
1994         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1995         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1996         * mdebugread.c (parse_partial_symbols): Use
1997         allocate_dependencies.
1998         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1999         allocate_dependencies.
2000         (process_psymtab_comp_unit_reader)
2001         (build_type_psymtab_dependencies): Likewise.
2002         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
2003
2004 2019-01-10  Tom Tromey  <tom@tromey.com>
2005
2006         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
2007         PSYMBOL_SET_LANGUAGE.
2008         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
2009
2010 2019-01-10  Tom Tromey  <tom@tromey.com>
2011
2012         * psymtab.h (psymtab_storage::obstack): New method.
2013         <m_obstack>: Rename from obstack; now private.
2014         * psymtab.c (psymtab_storage): Update.
2015         * dwarf2read.c (create_addrmap_from_index)
2016         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
2017         Update.
2018
2019 2019-01-10  Tom Tromey  <tom@tromey.com>
2020
2021         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
2022         * objfiles.h (objfile::reset_psymtabs): New method.
2023
2024 2019-01-10  Tom Tromey  <tom@tromey.com>
2025
2026         * symmisc.c (print_symbol_bcache_statistics): Update.
2027         (print_objfile_statistics): Update.
2028         * symfile.c (reread_symbols): Update.
2029         * psymtab.h (class psymtab_storage): New.
2030         * psymtab.c (psymtab_storage): New constructor.
2031         (~psymtab_storage): New destructor.
2032         (require_partial_symbols): Update.
2033         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
2034         (find_pc_sect_psymtab, find_pc_sect_psymbol)
2035         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
2036         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
2037         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
2038         (start_psymtab_common, end_psymtab_common)
2039         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
2040         (allocate_psymtab): Update.
2041         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
2042         Update.
2043         (dump_psymtab_addrmap, maintenance_print_psymbols)
2044         (maintenance_check_psymtabs): Update.
2045         (class objfile_psymtabs): Move to objfiles.h.
2046         * psympriv.h (discard_psymtab): Now inline.
2047         (psymtab_discarder::psymtab_discarder): Update.
2048         (psymtab_discarder::~psymtab_discarder): Update.
2049         (ALL_OBJFILE_PSYMTABS): Rewrite.
2050         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
2051         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
2052         Remove fields.
2053         <partial_symtabs>: New field.
2054         (class objfile_psymtabs): Move from psymtab.h.  Update.
2055         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
2056         psymbol_cache.
2057         (objfile::~objfile): Don't destroy psymbol_cache.
2058         * mdebugread.c (parse_partial_symbols): Update.
2059         * dwarf2read.c (create_addrmap_from_index)
2060         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2061         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2062         (add_partial_subprogram, dwarf2_ranges_read): Update.
2063         * dwarf-index-write.c (write_address_map)
2064         (write_one_signatured_type, recursively_write_psymbols)
2065         (class debug_names, class debug_names, write_psymtabs_to_index):
2066         Update.
2067
2068 2019-01-10  Tom Tromey  <tom@tromey.com>
2069
2070         * symtab.h (SYMBOL_SET_NAMES): Update.
2071         (symbol_set_names): Update.
2072         (MSYMBOL_SET_NAMES): Update.
2073         * symtab.c (symbol_set_names): Change argument to be an
2074         objfile_per_bfd_storage.
2075         * psymtab.c (add_psymbol_to_bcache): Update.
2076         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2077
2078 2019-01-10  Tom Tromey  <tom@tromey.com>
2079
2080         * symtab.c (create_demangled_names_hash): Change argument to be an
2081         objfile_per_bfd_storage.
2082         (symbol_set_names): Update.
2083
2084 2019-01-10  Tom Tromey  <tom@tromey.com>
2085
2086         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2087         init_psymbol_list.
2088         * psymtab.c (init_psymbol_list): Do nothing if already called.
2089         * psympriv.h (init_psymbol_list): Add comment.
2090         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2091         init_psymbol_list.
2092         * dbxread.c (dbx_symfile_read): Unconditionally call
2093         init_psymbol_list.
2094
2095 2019-01-10  Tom Tromey  <tom@tromey.com>
2096
2097         * xcoffread.c (scan_xcoff_symtab): Update.
2098         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2099         "where".
2100         * mdebugread.c (parse_partial_symbols)
2101         (handle_psymbol_enumerators): Update.
2102         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2103         * dbxread.c (read_dbx_symtab): Update.
2104         * psympriv.h (psymbol_placement): New enum.
2105         (add_psymbol_to_list): Update.
2106
2107 2019-01-10  Tom Tromey  <tom@tromey.com>
2108
2109         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2110         static_psymbols parameters.
2111         (scan_xcoff_symtab): Update.
2112         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2113         static_psymbols parameters.
2114         * psympriv.h (start_psymtab_common): Update.
2115         * mdebugread.c (parse_partial_symbols): Update.
2116         * dwarf2read.c (create_partial_symtab): Update.
2117         * dbxread.c (read_dbx_symtab): Update.
2118         (start_psymtab): Remove global_psymbols and static_psymbols
2119         parameters.
2120
2121 2019-01-10  Tom Tromey  <tom@tromey.com>
2122
2123         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2124         * psymtab.c (allocate_psymtab): Add comment.
2125         * psympriv.h (allocate_psymtab): Add comment.
2126         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2127         initializations.
2128         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2129
2130 2019-01-10  Tom Tromey  <tom@tromey.com>
2131
2132         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2133         Don't declare.
2134         * mipsread.c: Include mdebugread.h.
2135         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2136         Declare.
2137         * elfread.c: Include mdebugread.h.
2138
2139 2019-01-09  Tom Tromey  <tom@tromey.com>
2140
2141         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2142         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2143         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2144         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2145         (psym_lookup_symbol, psym_find_last_source_symtab)
2146         (psym_forget_cached_source_info, psym_print_stats)
2147         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2148         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2149         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2150         (psym_find_compunit_symtab_by_address)
2151         (maintenance_print_psymbols, maintenance_info_psymtabs)
2152         (maintenance_check_psymtabs): Use ranged for.
2153         * psymtab.h (class objfile_psymtabs): New.
2154         (require_partial_symbols): Return objfile_psymtabs.
2155         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2156
2157 2019-01-09  Tom Tromey  <tom@tromey.com>
2158
2159         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2160         (find_pc_mapped_section, list_overlays_command)
2161         (map_overlay_command, unmap_overlay_command)
2162         (simple_overlay_update): Use all_objfiles.
2163         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2164         * printcmd.c (info_symbol_command): Use all_objfiles.
2165         * objfiles.h (ALL_OBJSECTIONS): Remove.
2166         * maint.c (maintenance_translate_address): Use all_objfiles.
2167         * gcore.c (gcore_create_callback): Use all_objfiles.
2168         (objfile_find_memory_regions): Likewise.
2169
2170 2019-01-09  Tom Tromey  <tom@tromey.com>
2171
2172         * symtab.c (find_line_symtab, info_sources_command)
2173         (make_source_files_completion_list): Use objfile_compunits.
2174         * source.c (select_source_symtab): Use objfile_compunits.
2175         * objfiles.h (struct objfile): Update comment.
2176         (ALL_OBJFILES): Remove.
2177         (ALL_FILETABS): Remove.
2178         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2179         objfile_compunits.
2180
2181 2019-01-09  Tom Tromey  <tom@tromey.com>
2182
2183         * symmisc.c (print_objfile_statistics, dump_objfile)
2184         (maintenance_print_symbols): Use compunit_filetabs.
2185         * source.c (forget_cached_source_info_for_objfile): Use
2186         compunit_filetabs.
2187         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2188         (ALL_FILETABS): Use compunit_filetabs.
2189         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2190         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2191
2192 2019-01-09  Tom Tromey  <tom@tromey.com>
2193
2194         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2195         (compunit_filetabs): New.
2196         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2197         compunit_filetabs.
2198         (info_sources_command, make_source_files_completion_list): Remove
2199         declaration.
2200         * symmisc.c (print_objfile_statistics, dump_objfile)
2201         (maintenance_print_symbols): Remove declaration.
2202         (maintenance_info_symtabs): Use compunit_filetabs.
2203         (maintenance_info_line_tables): Likewise.
2204         * source.c (select_source_symtab): Change local variable name.
2205         (forget_cached_source_info_for_objfile): Remove declaration.
2206         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2207         * objfiles.c (objfile_relocate1): Remove declaration.
2208         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2209         declaration.
2210         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2211         * coffread.c (coff_symtab_read): Remove declaration.
2212         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2213         compunit_filetabs.
2214
2215 2019-01-09  Tom Tromey  <tom@tromey.com>
2216
2217         * symtab.c (lookup_objfile_from_block)
2218         (find_pc_sect_compunit_symtab, search_symbols)
2219         (default_collect_symbol_completion_matches_break_on): Use
2220         objfile_compunits.
2221         * objfiles.h (ALL_COMPUNITS): Remove.
2222         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2223         * cp-support.c (add_symbol_overload_list_qualified): Use
2224         objfile_compunits.
2225         * ada-lang.c (ada_collect_symbol_completion_matches)
2226         (ada_add_global_exceptions): Use objfile_compunits.
2227
2228 2019-01-09  Tom Tromey  <tom@tromey.com>
2229
2230         * source.c (select_source_symtab)
2231         (forget_cached_source_info_for_objfile): Remove declaration.
2232         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2233         declaration.
2234         * maint.c (count_symtabs_and_blocks): Remove declaration.
2235         * cp-support.c (add_symbol_overload_list_qualified): Remove
2236         declaration.
2237         * coffread.c (coff_symtab_read): Remove declaration.
2238         * symtab.c (lookup_symbol_in_objfile_symtabs)
2239         (basic_lookup_transparent_type_1): Use objfile_compunits.
2240         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2241         (info_sources_command, search_symbols)
2242         (default_collect_symbol_completion_matches_break_on)
2243         (make_source_files_completion_list): Remove declaration.
2244         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2245         (ada_collect_symbol_completion_matches)
2246         (ada_add_global_exceptions): Remove declaration.
2247         * linespec.c (iterate_over_all_matching_symtabs): Use
2248         objfile_compunits.
2249         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2250         (class objfile_compunits): New.
2251         (ALL_COMPUNITS): Use objfile_compunits.
2252         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2253         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2254         objfile_compunits.
2255         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2256
2257 2019-01-09  Tom Tromey  <tom@tromey.com>
2258
2259         * symtab.c (search_symbols)
2260         (default_collect_symbol_completion_matches_break_on): Use
2261         objfile_msymbols.
2262         * ada-lang.c (ada_lookup_simple_minsym)
2263         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2264         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2265         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2266         objfile_msymbols.
2267         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2268         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2269         * objc-lang.c (find_methods): Use objfile_msymbols.
2270         (info_selectors_command, info_classes_command): Likewise.
2271         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2272         * objfiles.h (class objfile_msymbols): New.
2273         (ALL_OBJFILE_MSYMBOLS): Remove.
2274         (ALL_MSYMBOLS): Remove.
2275
2276 2019-01-09  Tom Tromey  <tom@tromey.com>
2277
2278         * common/next-iterator.h (next_adapter): Add Iterator template
2279         parameter.
2280         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2281         (class all_objfiles_safe): New.
2282         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2283         * objfiles.c (put_objfile_before): Update comment.
2284         (add_separate_debug_objfile): Likewise.
2285         (free_all_objfiles): Use all_objfiles_safe.
2286         (objfile_purge_solibs): Likewise.
2287
2288 2019-01-09  Tom Tromey  <tom@tromey.com>
2289
2290         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2291         (expand_symtab_containing_pc, lookup_static_symbol)
2292         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2293         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2294         all_objfiles.
2295         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2296         * breakpoint.c (create_overlay_event_breakpoint)
2297         (create_longjmp_master_breakpoint)
2298         (create_std_terminate_master_breakpoint)
2299         (create_exception_master_breakpoint): Use all_objfiles.
2300         * linux-thread-db.c (try_thread_db_load_from_pdir)
2301         (has_libpthread): Use all_objfiles.
2302         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2303         * linespec.c (iterate_over_all_matching_symtabs)
2304         (search_minsyms_for_name): Use all_objfiles.
2305         * maint.c (maintenance_info_sections): Use all_objfiles.
2306         * main.c (captured_main_1): Use all_objfiles.
2307         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2308         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2309         * guile/scm-pretty-print.c
2310         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2311         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2312         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2313         (maintenance_print_msymbols): Use all_objfiles.
2314         * source.c (select_source_symtab): Use all_objfiles.
2315         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2316         * symfile.c (remove_symbol_file_command)
2317         (expand_symtabs_matching, map_symbol_filenames): Use
2318         all_objfiles.
2319         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2320         all_objfiles.
2321         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2322         * objc-lang.c (find_methods): Use all_objfiles.
2323         * objfiles.c (have_partial_symbols, have_full_symbols)
2324         (have_minimal_symbols, qsort_cmp)
2325         (default_iterate_over_objfiles_in_search_order): Use
2326         all_objfiles.
2327         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2328         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2329         (maintenance_check_psymtabs): Use all_objfiles.
2330         (ALL_PSYMTABS): Remove.
2331         * compile/compile-object-run.c (do_module_cleanup): Use
2332         all_objfiles.
2333         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2334         * cp-support.c (add_symbol_overload_list_qualified): Use
2335         all_objfiles.
2336         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2337         Use all_objfiles.
2338         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2339         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2340         all_objfiles.
2341         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2342         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2343         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2344         Uses all_objfiles.
2345         * solib.c (solib_read_symbols): Use all_objfiles
2346
2347 2019-01-09  Tom Tromey  <tom@tromey.com>
2348
2349         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2350         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2351         all_objfiles.
2352         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2353         * symmisc.c (print_symbol_bcache_statistics)
2354         (print_objfile_statistics, maintenance_print_objfiles)
2355         (maintenance_info_symtabs, maintenance_check_symtabs)
2356         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2357         all_objfiles.
2358         * source.c (forget_cached_source_info): Use all_objfiles.
2359         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2360         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2361         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2362         * objfiles.c (update_section_map): Use all_objfiles.
2363         (shared_objfile_contains_address_p): Likewise.
2364         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2365         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2366
2367 2019-01-09  Tom Tromey  <tom@tromey.com>
2368
2369         * common/next-iterator.h: New file.
2370         * objfiles.h (class all_objfiles): New.
2371         (struct objfile_iterator): New.
2372
2373 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2374
2375         * NEWS: Move the description of the changed "frame", "select-frame",
2376          and "info frame" commands to the Changed commands section.
2377
2378 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2379
2380         * gdbtypes.c (check_stub_method_group): Remove handling of old
2381         mangling schemes.
2382         * linespec.c (find_methods): Likewise.
2383         * stabsread.c (read_member_functions): Likewise.
2384         * valops.c (search_struct_method): Likewise.
2385         (value_struct_elt_for_reference): Likewise.
2386         * NEWS: Mention this change.
2387
2388 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2389
2390         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2391         print_source_lines.
2392         * source.c (print_source_lines_base): Update line number check.
2393         (print_source_lines): New function.
2394         (source_lines_range::source_lines_range): New function.
2395         * source.h (class source_lines_range): New class.
2396         (print_source_lines): New declaration.
2397
2398 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2399
2400         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2401
2402 2019-01-08  Tom Tromey  <tom@tromey.com>
2403             Simon Marchi  <simon.marchi@ericsson.com>
2404
2405         PR gdb/24060
2406         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2407         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2408         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2409         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2410         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2411         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2412
2413 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2414
2415         * source.c (select_source_symtab): Move header comment to
2416         declaration in source.h.
2417         (forget_cached_source_info_for_objfile): Likewise.
2418         (forget_cached_source_info): Likewise.
2419         (identify_source_line): Likewise.
2420         * source.h (identify_source_line): Move declaration from symtab.h
2421         and add comment from source.c
2422         (print_source_lines): Likewise.
2423         (forget_cached_source_info_for_objfile): Likewise.
2424         (forget_cached_source_info): Likewise.
2425         (select_source_symtab): Likewise.
2426         (enum print_source_lines_flag): Move definition from symtab.h.
2427         * symtab.h (identify_source_line): Move declaration to source.h.
2428         (print_source_lines): Likewise.
2429         (forget_cached_source_info_for_objfile): Likewise.
2430         (forget_cached_source_info): Likewise.
2431         (select_source_symtab): Likewise.
2432         (enum print_source_lines_flag): Move definition to source.h.
2433         * tui/tui-hooks.c: Add 'source.h' include.
2434
2435 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2436
2437         * source.c (print_source_lines_base): Handle requests to print
2438         reverse line number sequences, and guard against empty lines
2439         string.
2440
2441 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2442
2443         * source.c (print_source_lines_base): Fix skip of '\r' if next
2444         character is '\n'.
2445
2446 2019-01-06  Tom Tromey  <tom@tromey.com>
2447
2448         * c-exp.y (struct c_parse_state) <macro_original_text,
2449         expansion_obstack>: New member.
2450         (macro_original_text, expansion_obstack): Remove globals.
2451         (scan_macro_expansion, scanning_macro_expansion)
2452         (finished_macro_expansion): Update.
2453         (scan_macro_cleanup): Remove.
2454         (yylex, c_parse): Update.
2455
2456 2019-01-06  Tom Tromey  <tom@tromey.com>
2457
2458         * c-exp.y (struct c_parse_state) <strings>: New member.
2459         (operator_stoken): Update.
2460
2461 2019-01-06  Tom Tromey  <tom@tromey.com>
2462
2463         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2464         (union type_stack_elt) <typelist_val>: Now a pointer to
2465         std::vector.
2466         (type_stack_cleanup): Don't declare.
2467         (push_typelist): Update.
2468         * parse.c (pop_typelist): Return a std::vector.
2469         (push_typelist): Take a std::vector.
2470         (follow_types): Update.  Do not free args.
2471         (type_stack_cleanup): Remove.
2472         * c-exp.y (struct c_parse_state): New.
2473         (cpstate): New global.
2474         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2475         (nonempty_typelist): Update.
2476         (func_mod): Create a new vector.
2477         (c_parse): Create a c_parse_state.
2478         (check_parameter_typelist): Do not delete params.
2479         (function_method): Update.  Do not delete type_list.
2480
2481 2019-01-06  Tom Tromey  <tom@tromey.com>
2482
2483         PR gdb/28155:
2484         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2485         check_typedef.
2486         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2487         (print_return_value): Likewise.
2488
2489 2019-01-05  Tom Tromey  <tom@tromey.com>
2490
2491         * contrib/cleanup_check.py: Remove.
2492         * contrib/gcc-with-excheck: Remove.
2493         * contrib/exsummary.py: Remove.
2494         * contrib/excheck.py: Remove.
2495
2496 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2497
2498         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2499         NULL. Initialize tpprev to NULL instead of assigning it
2500         to NULL on the next statement.
2501         * windows-nat.c (windows_delete_thread): Remove check for
2502         main_thread_id before printing thread exit notifications.
2503         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2504         Remove thread ID check against main_thread_id.
2505         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2506         windows_delete_thread.
2507         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2508
2509 2019-01-04  Tom Tromey  <tom@tromey.com>
2510
2511         * compile/compile.c (_initialize_compile): Use upper case for
2512         metasyntactic variables.
2513         * symmisc.c (_initialize_symmisc): Use upper case for
2514         metasyntactic variables.
2515         * psymtab.c (_initialize_psymtab): Use upper case for
2516         metasyntactic variables.
2517         * demangle.c (demangle_command): Use upper case for metasyntactic
2518         variables.
2519         (_initialize_demangler): Likewise.
2520         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2521         variables.
2522
2523 2019-01-03  Tom Tromey  <tom@tromey.com>
2524
2525         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2526
2527 2019-01-03  Tom Tromey  <tom@tromey.com>
2528
2529         * python/py-symtab.c (salpy_str): Update.
2530         (struct salpy_sal_object) <symtab>: Now a PyObject.
2531         (salpy_dealloc): Update.
2532         (del_objfile_sal): Use gdbpy_ref.
2533
2534 2019-01-03  Tom Tromey  <tom@tromey.com>
2535
2536         * python/py-type.c (convert_field): Use new_reference.  Return
2537         gdbpy_ref.
2538         (make_fielditem): Return gdbpy_ref.
2539         (typy_fields): Update.
2540         (typy_getitem): Update.
2541         (field_name): Return gdbpy_ref.  Use new_reference.
2542         (typy_iterator_iternext): Update.
2543
2544 2019-01-03  Tom Tromey  <tom@tromey.com>
2545
2546         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2547
2548 2019-01-03  Tom Tromey  <tom@tromey.com>
2549
2550         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2551         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2552         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2553         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2554         (pspy_set_type_printers): Likewise.
2555         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2556         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2557         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2558         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2559         (objfpy_set_type_printers): Likewise.
2560
2561 2019-01-03  Tom Tromey  <tom@tromey.com>
2562
2563         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2564         (gdbpy_print_stack): Use gdbpy_err_fetch.
2565         * python/python-internal.h (class gdbpy_err_fetch): New class.
2566         (class gdbpy_enter) <m_error_type, m_error_value,
2567         m_error_traceback>: Remove.
2568         <m_error>: New member.
2569         (gdbpy_exception_to_string): Don't declare.
2570         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2571         * python/py-value.c (convert_value_from_python): Use
2572         gdbpy_err_fetch.
2573         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2574         gdbpy_exception_to_string.
2575         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2576         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2577         gdbpy_err_fetch.
2578
2579 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2580
2581         * linux-nat.c (delete_lwp_cleanup): Delete.
2582         (struct lwp_deleter): New struct.
2583         (lwp_info_up): New typedef.
2584         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2585         lwp_info_up.
2586
2587 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2588
2589         * linux-fork.c (class scoped_switch_fork_info): New class.
2590         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2591
2592 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2593
2594         * valops.c (find_overload_match): Remove use of null_cleanup, and
2595         calls to do_cleanups.
2596
2597 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2598
2599         * compile/compile-cplus-types.c
2600         (compile_cplus_instance::decl_name): Handle changes to
2601         cp_func_name.
2602         * cp-support.c (cp_func_name): Update header comment, update
2603         return type.
2604         * cp-support.h (cp_func_name): Update return type in declaration.
2605         * valops.c (find_overload_match): Move temp_func local to top
2606         level of function and change its type.  Use temp_func to hold and
2607         delete temporary string obtained from cp_func_name.
2608
2609 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2610
2611         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2612         gdb::char_vector, remove cleanup, and update uses of `msg`.
2613
2614 2019-01-03  Jim Wilson  <jimw@sifive.com>
2615
2616         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2617
2618 2019-01-02  Tom Tromey  <tom@tromey.com>
2619
2620         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2621         (tdesc_parse_xml): Remove cleanups.
2622         * target-descriptions.h (make_cleanup_free_target_description):
2623         Don't declare.
2624         (target_desc_deleter): New struct.
2625         (target_desc_up): New typedef.
2626         * target-descriptions.c (target_desc_deleter::operator()): Rename
2627         from free_target_description.
2628         (make_cleanup_free_target_description): Remove.
2629
2630 2019-01-02  Tom Tromey  <tom@tromey.com>
2631
2632         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2633         constructor, destructor.
2634         (linespec_parser): Remove typedef.
2635         (~linespec_parser): Rename from linespec_parser_delete.
2636         (linespec_lex_to_end, linespec_complete_label)
2637         (linespec_complete): Update.
2638         (decode_line_full): Remove cleanups.
2639         (decode_line_1): Update.
2640
2641 2019-01-02  Tom Tromey  <tom@tromey.com>
2642
2643         * python/python-internal.h (inferior_to_inferior_object): Change
2644         return type.
2645         * python/py-exitedevent.c (create_exited_event_object): Update.
2646         * python/py-inferior.c (inferior_to_inferior_object): Return
2647         gdbpy_ref.
2648         (python_new_inferior, python_inferior_deleted)
2649         (thread_to_thread_object, delete_thread_object)
2650         (build_inferior_list, gdbpy_selected_inferior): Update.
2651         * python/py-infthread.c (create_thread_object): Update.  Also fail
2652         if inferior_to_inferior_object fails.
2653
2654 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2655
2656         * inferior.h (class inferior) <displaced_step_state>: New field.
2657         * infrun.h (struct displaced_step_state): Move here from
2658         infrun.c.  Initialize fields, add constructor.
2659         <inf>: Remove field.
2660         <reset>: New method.
2661         * infrun.c (struct displaced_step_inferior_state): Move to
2662         infrun.h.
2663         (displaced_step_inferior_states): Remove.
2664         (get_displaced_stepping_state): Adust.
2665         (displaced_step_in_progress_any_inferior): Adjust.
2666         (displaced_step_in_progress_thread): Adjust.
2667         (displaced_step_in_progress): Adjust.
2668         (add_displaced_stepping_state): Remove.
2669         (get_displaced_step_closure_by_addr): Adjust.
2670         (remove_displaced_stepping_state): Remove.
2671         (infrun_inferior_exit): Call displaced_step_state.reset.
2672         (use_displaced_stepping): Don't check for NULL.
2673         (displaced_step_prepare_throw): Call
2674         get_displaced_stepping_state.
2675         (displaced_step_fixup): Don't check for NULL.
2676         (prepare_for_detach): Don't check for NULL.
2677
2678 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2679
2680         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2681          in case of call that did not complete.
2682
2683 2019-01-02  Andrey Utkin  <autkin@undo.io>
2684
2685         * symfile.c (find_separate_debug_file): Fix search of debug files for
2686         remote debuggee.
2687
2688 2019-01-02  Tom Tromey  <tom@tromey.com>
2689
2690         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2691         indentation.
2692         * python/py-frame.c (frapy_older): Remove cast.
2693         (frapy_newer): Likewise.
2694         * python/py-breakpoint.c (local_setattro): Remove cast.
2695         * python/py-arch.c (archpy_name): Remove local variable.
2696         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2697
2698 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2699
2700         * unittests/basic_string_view/element_access/char/empty.cc:
2701         Fix year range in copyright header.
2702
2703 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2704
2705         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2706         Delete.
2707         <operator==>: Update with for removed field.
2708         <hash>: Likewise.
2709         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2710         <isa_features>: ...this.
2711         <abi_features>: New field.
2712         (riscv_isa_flen): Update comment.
2713         (riscv_abi_xlen): New declaration.
2714         (riscv_abi_flen): New declaration.
2715         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2716         isa_features.
2717         (riscv_abi_xlen): New function.
2718         (riscv_isa_flen): Update to get answer from isa_features.
2719         (riscv_abi_flen): New function.
2720         (riscv_has_fp_abi): Update to get answer from abi_features.
2721         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2722         xlen and flen.
2723         (riscv_call_info) <xlen, flen>: Update comment.
2724         (riscv_call_arg_struct): Remove invalid assertions
2725         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2726         is removed.
2727         (riscv_gdbarch_init): Gather isa features and abi features
2728         separately, ensure both match on the gdbarch when reusing an old
2729         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2730         a target with 64-bit float hardware.
2731
2732 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2733
2734         * source.c (search_command_helper): Stop reverse search
2735         when line 1 has been searched.
2736
2737 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2738
2739         * record-full.c (record_full_base_target::close): Rewrite
2740         record_full_core_buf_list free logic.
2741
2742 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2743
2744         * break-catch-syscall.c (print_one_catch_syscall): xfree
2745         the last text.
2746
2747 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2748
2749         * top.c (print_gdb_version): Update Copyright year in version
2750         message.
2751
2752 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2753
2754         Update copyright year range in all GDB files.
2755
2756 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2757
2758         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2759
2760 For older changes see ChangeLog-2018.
2761 \f
2762 Local Variables:
2763 mode: change-log
2764 left-margin: 8
2765 fill-column: 74
2766 version-control: never
2767 coding: utf-8
2768 End:
2769