gdb/ChangeLog

   1 2019-05-21  Tom de Vries  <tdevries@suse.de>
   2
   3         PR cli/24587
   4         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
   5
   6 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
   7
   8         PR gdb/18644:
   9         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
  10         16-byte floats.
  11         * i386-tdep.c (i386_floatformat_for_type): Use
  12         floatformats_ia64_quad for the 16-byte floating point component
  13         within a fortran 32-byte complex number.
  14
  15 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
  16
  17         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
  18         delete default constructor.
  19         (find_partial_die): Update to return const struct.
  20         (partial_die_parent_scope): Move variable declaration into scope
  21         of its use and change its type to auto.
  22         (guess_partial_die_structure_name): Likewise.
  23         (partial_die_info::fixup): Likewise.
  24
  25 2019-05-17  Tom Tromey  <tromey@adacore.com>
  26
  27         * source.c (find_and_open_source): Remove cast.
  28
  29 2019-05-17  Tom Tromey  <tromey@adacore.com>
  30
  31         * annotate.c (annotate_source): Make "filename" const.
  32         * annotate.h (annotate_source): Use const.
  33
  34 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
  35
  36         * disasm.c (set_disassembler_options): Send errors to stderr.
  37
  38 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
  39
  40         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
  41         (cli_interp_base::set_logging): Check debug_redirect.
  42         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
  43         * cli/cli-logging.c (debug_redirect): Add static variable.
  44         (pop_output_files): Add default param.
  45         (handle_redirections): Print debug setting.
  46         (show_logging_command): Likewise.
  47         (_initialize_cli_logging): Add debugredirect command.
  48         * interps.c (current_interp_set_logging): Add debug_redirect
  49         parameter.
  50         * interps.h (set_logging): Add debug_redirect parameter.
  51         (current_interp_set_logging): Likewise.
  52         * mi/mi-common.h: Likewise.
  53         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
  54
  55 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
  56             Tom Tromey  <tromey@adacore.com>
  57
  58         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
  59         directly.
  60         * cli/cli-interp.h (make_logging_output): Remove declaration.
  61         * cli/cli-logging.c (make_logging_output): Remove function.
  62         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
  63         directly.
  64         * ui-file.c (tee_file::tee_file): Remove bools.
  65         (tee_file::~tee_file): Remove deletes.
  66         * ui-file.h (tee_file): Remove bools.
  67
  68 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
  69
  70         * mi/mi-cmds.h (mi_cmd_complete): New function.
  71         * mi/mi-main.c (mi_cmd_complete): Likewise.
  72         * mi/mi-cmds.c: Define new MI command -complete.
  73         * NEWS: Mention new -complete command.
  74
  75 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
  76
  77         * completer.h (complete): New function.
  78         * completer.c (complete): Likewise.
  79         * cli/cli-cmds.c: (complete_command): Update to use new complete()
  80         function defined in completer.h.
  81
  82 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
  83
  84        * MAINTAINERS (Write After Approval): Add myself.
  85
  86 2019-05-17  Tom de Vries  <tdevries@suse.de>
  87
  88         PR gdb/24094
  89         * dwarf2read.c (struct cu_partial_die_info): New struct.
  90         (find_partial_die): Return cu_partial_die_info.
  91         (partial_die_parent_scope, guess_partial_die_structure_name)
  92         (partial_die_info::fixup): Handle new return type of find_partial_die.
  93
  94 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
  95
  96         * stap-probe.c (stap_parse_register_operand): Make "regname" an
  97         "std::string", simplifying the algorithm.
  98
  99 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 100
 101         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
 102         (stap_static_probe_ops::get_probes): Likewise.
 103
 104 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 105
 106         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
 107         '-')" and "else if".
 108         (stap_parse_single_operand): Join checks for
 109         "gdbarch_stap_parse_special_token_p" and
 110         "gdbarch_stap_parse_special_token" in the same "if" statement.
 111         Invert check when verifying for operation on register
 112         displacement.
 113
 114 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 115
 116         * stap-probe.c (stap_get_opcode): Update comment.
 117         (stap_get_expected_argument_type): Likewise.
 118         (handle_stap_probe): Likewise.
 119
 120 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 121
 122         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
 123         return type to 'bool'.  Adjust comment.  Use 'bool' when
 124         appropriate.
 125         (i386_stap_parse_special_token_three_arg_disp): Likewise.
 126         * stap-probe.c (stap_parse_argument_1): Likewise.
 127         (stap_is_operator): Likewise.
 128         (stap_is_generic_prefix): Likewise.
 129         (stap_is_register_prefix): Likewise.
 130         (stap_is_register_indirection_prefix): Likewise.
 131         (stap_is_integer_prefix): Likewise.
 132         (stap_generic_check_suffix): Likewise.
 133         (stap_check_integer_suffix): Likewise.
 134         (stap_check_register_suffix): Likewise.
 135         (stap_check_register_indirection_suffix): Likewise.
 136         (stap_parse_register_operand): Likewise.
 137         (stap_parse_single_operand): Likewise.
 138         (stap_parse_argument_1): Likewise.
 139         (stap_probe::get_argument_count): Likewise.
 140         (stap_is_operator): Likewise.
 141
 142 2019-05-16  Tom Tromey  <tromey@adacore.com>
 143
 144         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
 145         keyword to foreach.
 146
 147 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
 148
 149         * linux-thread-db.c (try_thread_db_load_1): Change return type
 150         to bool.
 151         (try_thread_db_load): Likewise.
 152         (try_thread_db_load_from_pdir_1): Likewise.
 153         (try_thread_db_load_from_pdir): Likewise.
 154         (try_thread_db_load_from_sdir): Likewise.
 155         (try_thread_db_load_from_dir): Likewise.
 156         (thread_db_load_search): Likewise.
 157         (has_libpthread): Likewise.
 158         (thread_db_load): Likewise.
 159
 160 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
 161
 162         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 163         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
 164         NULL, and complain/return if that's the case.
 165
 166 2019-05-15  John Darrington <john@darrington.wattle.id.au>
 167
 168         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
 169         (advance, posn, abstract_read_memory): New functions.
 170         [struct mem_read_abstraction]: New struct.
 171         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
 172
 173 2019-05-14  Tom Tromey  <tromey@adacore.com>
 174
 175         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
 176         value is not lval_memory.
 177
 178 2019-05-14  Tom Tromey  <tromey@adacore.com>
 179
 180         * solib.c (info_sharedlibrary_command): Style the file name.
 181
 182 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
 183
 184         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
 185         (aarch64_vnv_type): Likewise.
 186         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
 187         * common/tdesc.c: Likewise.
 188         * common/tdesc.h (enum tdesc_type_kind): Likewise.
 189         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
 190         * features/aarch64-fpu.xml: Add ieee half view.
 191         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
 192         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
 193         * gdbtypes.h (struct builtin_type): Likewise.
 194         (struct objfile_type): Likewise.
 195
 196 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
 197
 198         * language.c (language_sniff_from_mangled_name): Fix "langauge"
 199         typo.
 200         * location.h (string_to_event_location): Likewise.
 201
 202 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
 203
 204         GDB 8.3 released.
 205
 206 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 207
 208         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
 209         New variable declaration.
 210         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
 211         New variable.
 212         (print_one_breakpoint): Use ui_out::test_flags and new global
 213         variable to compute use_fixed_output.
 214         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
 215         Remove.
 216         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
 217         (mi_multi_location_breakpoint_output_fixed): Remove.
 218         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
 219         new variable.
 220         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
 221         fix_multi_location_breakpoint_output flag if version >= 3.
 222         * ui-out.h (enum ui_out_flag)
 223         <fix_multi_location_breakpoint_output>: New enumerator.
 224
 225 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 226
 227         * contrib/cc-with-tweaks.sh: Validate dwz's work.
 228
 229 2019-05-10  Tom Tromey  <tromey@adacore.com>
 230
 231         * ada-lang.c (catch_ada_completer): New function.
 232         (_initialize_ada_language): Use it.
 233
 234 2019-05-10  Tom Tromey  <tromey@adacore.com>
 235
 236         * thread.c (print_thread_info): Make "requested_threads" const.
 237         * gdbthread.h (print_thread_info): Make "requested_threads"
 238         const.
 239         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
 240         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
 241
 242 2019-05-08  Tom Tromey  <tom@tromey.com>
 243
 244         * gdbtypes.c (objfile_type_data): Change type.
 245         (objfile_type, _initialize_gdbtypes): Update.
 246
 247 2019-05-08  Tom Tromey  <tom@tromey.com>
 248
 249         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
 250         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
 251         (_initialize_dwarf2_frame): Update.
 252
 253 2019-05-08  Tom Tromey  <tom@tromey.com>
 254
 255         * objc-lang.c (objc_objfile_data): Change type.
 256         (find_methods): Update.
 257         (_initialize_objc_lang): Remove.
 258
 259 2019-05-08  Tom Tromey  <tom@tromey.com>
 260
 261         * stabsread.c (rs6000_builtin_type_data): Change type.
 262         (rs6000_builtin_type, _initialize_stabsread): Update.
 263
 264 2019-05-08  Tom Tromey  <tom@tromey.com>
 265
 266         * mips-tdep.c (mips_pdr_data): Remove.
 267         (_initialize_mips_tdep): Update.
 268
 269 2019-05-08  Tom Tromey  <tom@tromey.com>
 270
 271         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
 272         (hppa_init_objfile_priv_data, read_unwind_info)
 273         (find_unwind_entry, _initialize_hppa_tdep): Update.
 274
 275 2019-05-08  Tom Tromey  <tom@tromey.com>
 276
 277         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
 278         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
 279         on obstack.
 280         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
 281
 282 2019-05-08  Tom Tromey  <tom@tromey.com>
 283
 284         * mdebugread.c (basic_type_data): Change type.
 285         (basic_type, _initialize_mdebugread): Update.
 286
 287 2019-05-08  Tom Tromey  <tom@tromey.com>
 288
 289         * common/gdb_unique_ptr.h (struct noop_deleter): New.
 290
 291 2019-05-08  Tom Tromey  <tom@tromey.com>
 292
 293         * nto-tdep.c (nto_inferior_data_reg): Change type.
 294         (nto_inferior_data): Update.
 295         (nto_inferior_data_cleanup, nto_new_inferior_data)
 296         (_initialize_nto_tdep): Remove.
 297         * nto-tdep.h (struct nto_inferior_data): Add initializers.
 298
 299 2019-05-08  Tom Tromey  <tom@tromey.com>
 300
 301         * ada-lang.c (struct ada_inferior_data): Add initializers.
 302         (ada_inferior_data): Change type.
 303         (ada_inferior_data_cleanup): Remove.
 304         (get_ada_inferior_data, ada_inferior_exit)
 305         (struct ada_pspace_data): Add initializers, destructor.
 306         (ada_pspace_data_handle): Change type.
 307         (get_ada_pspace_data): Update.
 308         (ada_pspace_data_cleanup): Remove.
 309
 310 2019-05-08  Tom Tromey  <tom@tromey.com>
 311
 312         * coffread.c (struct coff_symfile_info): Add initializers.
 313         (coff_objfile_data_key): Move lower.  Change type.
 314         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
 315         Update.
 316         (coff_free_info): Remove.
 317
 318 2019-05-08  Tom Tromey  <tom@tromey.com>
 319
 320         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
 321         (fbsd_pspace_data_handle): Move lower.  Change type.
 322         (get_fbsd_pspace_data): Update.
 323         (fbsd_pspace_data_cleanup): Remove.
 324         (_initialize_fbsd_tdep): Update.
 325
 326 2019-05-08  Tom Tromey  <tom@tromey.com>
 327
 328         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
 329         (get_ada_tasks_pspace_data): Update.
 330         (ada_tasks_pspace_data_cleanup): Remove.
 331         (_initialize_tasks): Update.
 332         (ada_tasks_inferior_data_handle): Change type.
 333         (get_ada_tasks_inferior_data): Update.
 334         (ada_tasks_inferior_data_cleanup): Remove.
 335         (struct ada_tasks_pspace_data): Add initializers.
 336
 337 2019-05-08  Tom Tromey  <tom@tromey.com>
 338
 339         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
 340         * symfile-debug.c (debug_sym_get_probes): Change type.
 341         * stap-probe.c (handle_stap_probe):
 342         (stap_static_probe_ops::get_probes): Change type.
 343         * probe.h (class static_probe_ops) <get_probes>: Change type.
 344         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
 345         (parse_probes_in_pspace): Update.
 346         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
 347         Update.
 348         (any_static_probe_ops::get_probes): Change type.
 349         * elfread.c (elfread_data): New typedef.
 350         (probe_key): Change type.
 351         (elf_get_probes): Likewise.  Update.
 352         (probe_key_free): Remove.
 353         (_initialize_elfread): Update.
 354         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
 355         Change type.
 356         (dtrace_process_dof_probe, dtrace_process_dof)
 357         (dtrace_static_probe_ops::get_probe): Change type.
 358
 359 2019-05-08  Tom Tromey  <tom@tromey.com>
 360
 361         * xcoffread.c (struct xcoff_symfile_info): Rename from
 362         coff_symfile_info.  Add initializers.
 363         (xcoff_objfile_data_key): Move lower.  Change type.
 364         (XCOFF_DATA): Rewrite.
 365         (xcoff_free_info): Remove.
 366         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
 367         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
 368         (xcoff_initial_scan): Update.
 369
 370 2019-05-08  Tom Tromey  <tom@tromey.com>
 371
 372         * solib-svr4.c (struct svr4_info): Add initializers and
 373         destructor.
 374         <probes_table>: Now an htab_up.
 375         (solib_svr4_pspace_data): Change type.
 376         (free_probes_table): Simplify.
 377         (~svr4_info): Rename from svr4_pspace_data_cleanup.
 378         (get_svr4_info, probes_table_htab_remove_objfile_probes)
 379         (probes_table_remove_objfile_probes, register_solib_event_probe)
 380         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
 381         (_initialize_svr4_solib): Update.
 382
 383 2019-05-08  Tom Tromey  <tom@tromey.com>
 384
 385         * remote.c (remote_pspace_data): Change type.
 386         (remote_pspace_data_cleanup): Remove.
 387         (get_remote_exec_file, set_pspace_remote_exec_file)
 388         (_initialize_remote): Update.
 389
 390 2019-05-08  Tom Tromey  <tom@tromey.com>
 391
 392         * breakpoint.c (breakpoint_objfile_key): Change type.
 393         (get_breakpoint_objfile_data): Update.
 394         (free_breakpoint_objfile_data): Remove.
 395         (_initialize_breakpoint): Update.
 396
 397 2019-05-08  Tom Tromey  <tom@tromey.com>
 398
 399         * linux-tdep.c (struct linux_info): Add initializers.
 400         (linux_inferior_data): Move.  Change type.
 401         (invalidate_linux_cache_inf): Update.
 402         (linux_inferior_data_cleanup): Remove.
 403         (get_linux_inferior_data, _initialize_linux_tdep): Update.
 404
 405 2019-05-08  Tom Tromey  <tom@tromey.com>
 406
 407         * auxv.c (auxv_inferior_data): Move.  Change type.
 408         (auxv_inferior_data_cleanup): Remove.
 409         (invalidate_auxv_cache_inf): Rewrite.
 410         (get_auxv_inferior_data, _initialize_auxv): Update.
 411
 412 2019-05-08  Tom Tromey  <tom@tromey.com>
 413
 414         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
 415         (symfile_debug_objfile_data_key): Change type.
 416         (symfile_debug_installed, debug_qf_has_symbols)
 417         (debug_qf_find_last_source_symtab)
 418         (debug_qf_forget_cached_source_info)
 419         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
 420         (debug_qf_print_stats, debug_qf_dump)
 421         (debug_qf_expand_symtabs_for_function)
 422         (debug_qf_expand_all_symtabs)
 423         (debug_qf_expand_symtabs_with_fullname)
 424         (debug_qf_map_matching_symbols)
 425         (debug_qf_expand_symtabs_matching)
 426         (debug_qf_find_pc_sect_compunit_symtab)
 427         (debug_qf_map_symbol_filenames)
 428         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
 429         (debug_sym_new_init, debug_sym_init, debug_sym_read)
 430         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
 431         (debug_sym_read_linetable, debug_sym_relocate): Update.
 432         (symfile_debug_free_objfile): Remove.
 433         (install_symfile_debug_logging, _initialize_symfile_debug):
 434         Update.
 435
 436 2019-05-08  Tom Tromey  <tom@tromey.com>
 437
 438         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
 439         allocate_on_obstack.
 440         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
 441         (get_dwarf2_per_objfile): Update.
 442         (set_dwarf2_per_objfile): Remove.
 443         (dwarf2_has_info, dwarf2_get_section_info): Update.
 444         (dwarf2_free_objfile): Remove.
 445         (_initialize_dwarf2_read): Update.
 446
 447 2019-05-08  Tom Tromey  <tom@tromey.com>
 448
 449         * auto-load.c (struct auto_load_pspace_info): Add destructor and
 450         initializers.
 451         <unsupported_script_warning_printed,
 452         script_not_found_warning_printed>: Now bool.
 453         (auto_load_pspace_data): Change type.
 454         (~auto_load_pspace_info): Rename from
 455         auto_load_pspace_data_cleanup.
 456         (get_auto_load_pspace_data, init_loaded_scripts_info)
 457         (clear_section_scripts, maybe_print_unsupported_script_warning)
 458         (maybe_print_script_not_found_warning, _initialize_auto_load):
 459         Update.
 460
 461 2019-05-08  Tom Tromey  <tom@tromey.com>
 462
 463         * objfiles.c (objfile_pspace_info): Add destructor and
 464         initializers.
 465         (objfiles_pspace_data): Change type.
 466         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
 467         (get_objfile_pspace_data): Update.
 468         (objfiles_bfd_data): Change type.
 469         (get_objfile_bfd_data): Update.
 470         (objfile_bfd_data_free, _initialize_objfiles): Remove.
 471
 472 2019-05-08  Tom Tromey  <tom@tromey.com>
 473
 474         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
 475         Change type.
 476         (get_catch_syscall_inferior_data): Update.
 477         (catch_syscall_inferior_data_cleanup): Remove.
 478         (_initialize_break_catch_syscall): Update.
 479
 480 2019-05-08  Tom Tromey  <tom@tromey.com>
 481
 482         * inflow.c (struct terminal_info): Add destructor and
 483         initializers.
 484         (inflow_inferior_data): Change type.
 485         (~terminal_info): Rename from inflow_inferior_data_cleanup.
 486         (get_inflow_inferior_data, inflow_inferior_exit)
 487         (swap_terminal_info, _initialize_inflow): Update.
 488
 489 2019-05-08  Tom Tromey  <tom@tromey.com>
 490
 491         * target-dcache.c (target_dcache_cleanup): Remove.
 492         (target_dcache_aspace_key): Change type.
 493         (target_dcache_init_p, target_dcache_invalidate)
 494         (target_dcache_get, target_dcache_get_or_init)
 495         (_initialize_target_dcache): Update.
 496         * dcache.h (struct dcache_deleter): New.
 497
 498 2019-05-08  Tom Tromey  <tom@tromey.com>
 499
 500         * symtab.c (struct symbol_cache): Add destructor and
 501         initializers.
 502         (symbol_cache_key): Move.  Change type.
 503         (make_symbol_cache, free_symbol_cache): Remove.
 504         (get_symbol_cache): Update.
 505         (symbol_cache_cleanup): Remove.
 506         (ALL_PSPACES, symbol_cache_flush)
 507         (maintenance_print_symbol_cache)
 508         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
 509         Update.
 510
 511 2019-05-08  Tom Tromey  <tom@tromey.com>
 512
 513         * symtab.c (struct main_info): Add destructor and initializers.
 514         (main_progspace_key): Move.  Change type.
 515         (get_main_info): Update.
 516         (main_info_cleanup): Remove.
 517         (_initialize_symtab): Update.
 518
 519 2019-05-08  Tom Tromey  <tom@tromey.com>
 520
 521         * registry.h (DECLARE_REGISTRY): Define the _key class.
 522
 523 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 524
 525         * NEWS: Merge two 'New commands' sections.
 526
 527 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 528
 529         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 530         parameter and use Ada language definition instead.
 531         (ada_val_print_ptr): Remove unused language parameter.
 532         (ada_val_print_num): Remove language parameter and use Ada language
 533         definition instead.
 534         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 535         parameter.
 536         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 537         parameter and use Ada language definition instead.
 538         (ada_val_print_1): Update all ada_val_print_xxx calls.
 539         Remove language parameter.
 540         (ada_val_print): Update ada_val_print_1 call.
 541
 542 2019-05-08  Tom Tromey  <tromey@adacore.com>
 543
 544         * remote.c (remote_hw_watchpoint_limit)
 545         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 546         Now static.
 547
 548 2019-05-08  Tom Tromey  <tromey@adacore.com>
 549
 550         * maint.c (_initialize_maint_cmds): Move initialization code to
 551         remote.c.
 552         (watchdog, show_watchdog): Move to remote.c.
 553         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 554         "watchdog" static.
 555         (_initialize_remote): Move initialization code from maint.c.
 556         * defs.h (watchdog): Don't declare.
 557
 558 2019-05-08  Tom Tromey  <tromey@adacore.com>
 559
 560         * tui/tui-interp.c: Include main.h.
 561         * interps.c: Include main.h.
 562         * main.h (interpreter_p): Declare.
 563         * defs.h (interpreter_p): Don't declare.
 564
 565 2019-05-08  Tom Tromey  <tromey@adacore.com>
 566
 567         * dwarf2loc.c: Include dwarf2read.h.
 568         * defs.h (read_unsigned_leb128): Don't declare.
 569         * dwarf2read.h (read_unsigned_leb128): Declare.
 570
 571 2019-05-08  Tom Tromey  <tromey@adacore.com>
 572
 573         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 574         method.
 575
 576 2019-05-08  Tom Tromey  <tromey@adacore.com>
 577
 578         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 579         when no wrap column is set.
 580
 581 2019-05-08  Tom Tromey  <tromey@adacore.com>
 582
 583         * c-lang.c (c_get_string): Handle non-C-style arrays.
 584
 585 2019-05-08  Tom Tromey  <tromey@adacore.com>
 586
 587         * typeprint.c (print_offset_data::update): Print the bit offset,
 588         not the number of bits remaining.
 589
 590 2019-05-08  Tom Tromey  <tromey@adacore.com>
 591
 592         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 593         padding at end of comment.
 594
 595 2019-05-08  Tom Tromey  <tromey@adacore.com>
 596
 597         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 598         Compare main types.
 599
 600 2019-05-06  Tom Tromey  <tom@tromey.com>
 601
 602         * common/scoped_mmap.c: Include common-defs.h.
 603         * common/scoped_mmap.h: Don't include config.h.
 604
 605 2019-05-04  Tom Tromey  <tom@tromey.com>
 606
 607         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 608         (struct aarch64_call_info): Add initializers.
 609         <si>: Now a std::vector.
 610         (pass_on_stack, aarch64_push_dummy_call): Update.
 611
 612 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 613             Tom Tromey  <tom@tromey.com>
 614
 615         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 616         (ppc_threads): Now a std::vector.  Now static.
 617         (hwdebug_find_thread_points_by_tid)
 618         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 619         Update.
 620
 621 2019-05-04  Tom Tromey  <tom@tromey.com>
 622
 623         * arc-tdep.c (arc_tdesc_init): Return bool.
 624
 625 2019-05-04  Tom Tromey  <tom@tromey.com>
 626
 627         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 628         Use gdb_assert_not_reached.
 629
 630 2019-05-04  Tom Tromey  <tom@tromey.com>
 631
 632         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 633         "false".
 634
 635 2019-05-04  Tom Tromey  <tom@tromey.com>
 636
 637         * arc-tdep.c (arc_tdesc_init): Use bool.
 638
 639 2019-05-04  Tom Tromey  <tom@tromey.com>
 640
 641         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 642
 643 2019-05-04  Tom Tromey  <tom@tromey.com>
 644
 645         * cli/cli-cmds.c (valid_command_p): Return bool.
 646
 647 2019-05-04  Tom Tromey  <tom@tromey.com>
 648
 649         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 650         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 651
 652 2019-05-04  Raul Tambre  <raul@tambre.ee>
 653
 654         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 655         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 656         operator for comparison.
 657
 658 2019-05-04  Tom Tromey  <tom@tromey.com>
 659
 660         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 661         (lookup_partial_symbol, print_partial_symbols)
 662         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 663         (psymbol_compare): Update.
 664         (add_psymbol_to_bcache): Clear the entire psymbol.
 665         (maintenance_check_psymtabs): Update.
 666         * psympriv.h (struct partial_symbol): Don't derive from
 667         general_symbol_info.
 668         <obj_section, unrelocated_address, address,
 669         set_unrelocated_address>: Update.
 670         <ginfo>: New member.
 671         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 672         (debug_names::write_psymbols): Update.
 673
 674 2019-05-04  Tom de Vries  <tdevries@suse.de>
 675
 676         * contrib/cc-with-tweaks.sh: Support -n arg.
 677
 678 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 679
 680         * corelow.c (core_target::detach): Ensure frame cache and
 681         register caches are cleared.
 682         inferior.c (exit_inferior_1): Likewise.
 683
 684 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 685             Tom Tromey  <tom@tromey.com>
 686
 687         * dictionary.c (collate_pending_symbols_by_language): Remove
 688         "struct" from foreach.
 689         * symtab.c (lookup_global_symbol_from_objfile)
 690         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 691         foreach.
 692         * ser-tcp.c (net_open): Remove "struct" from foreach.
 693         * objfiles.c (objfile_relocate, objfile_rebase)
 694         (objfile_has_symbols): Remove "struct" from foreach.
 695         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 696         from foreach.
 697         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 698         foreach.
 699         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 700         "struct" from foreach.
 701         * ada-lang.c (create_excep_cond_exprs)
 702         (ada_exception_catchpoint_cond_string): Remove "struct" from
 703         foreach.
 704
 705 2019-05-03  Tom Tromey  <tromey@adacore.com>
 706
 707         * ada-exp.y (convert_char_literal): Check suffix of each
 708         enumerator.
 709
 710 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 711
 712         PR ada/21406:
 713         * ada-exp.y (yywrap): Don't define.
 714         * ada-lex.l (%option): Add noyywrap
 715         (yywrap): Remove.
 716
 717 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 718
 719         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 720         _WIN32_WINNT to the XP level, unless already defined to a higher
 721         level.
 722
 723         * unittests/parse-connection-spec-selftests.c:
 724         * ser-tcp.c:
 725         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 726         override.
 727
 728         * symfile.c (find_separate_debug_file): Remove colon from the
 729         drive spec of DOS/Windows file names of the target, so that the
 730         file name produced from DEBUGDIR and the target's directory will
 731         be valid on DOS/Windows systems.
 732
 733 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 734
 735         * rust-lang.c (val_print_struct): Handle printing structures
 736         containing strings.
 737
 738 2019-05-02  Tom Tromey  <tromey@adacore.com>
 739
 740         * valarith.c (_initialize_valarith): Remove.
 741
 742 2019-05-01  Tom Tromey  <tromey@adacore.com>
 743
 744         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 745         bitfields.
 746
 747 2019-05-01  Tom Tromey  <tromey@adacore.com>
 748
 749         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 750         for big-endian copies.
 751
 752 2019-04-30  Ali Tamur  <tamur@google.com>
 753         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 754         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 755         (read_3_bytes): New function.
 756
 757 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 758
 759         * windows-nat.c (main_thread_id): Delete.
 760         (handle_output_debug_string): Replace main_thread_id by
 761         current_event.dwThreadId.
 762         (fake_create_process): Likewise.
 763         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 764         Do not set main_thread_id.
 765         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 766         current_event.dwThreadId.
 767         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 768
 769 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 770
 771         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 772         Use current_event.dwThreadId instead of main_thread_id.
 773
 774 2019-04-30  Tom Tromey  <tromey@adacore.com>
 775
 776         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 777         (create_excep_cond_exprs): Iterate over program spaces.
 778         (ada_exception_catchpoint_cond_string): Examine all minimal
 779         symbols for exception types.
 780
 781 2019-04-30  Tom Tromey  <tromey@adacore.com>
 782
 783         PR c++/24470:
 784         * dwarf2read.c (process_structure_scope): Handle case where type
 785         has template parameters but no symbol was created.
 786
 787 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 788             Chris January  <chris.january@arm.com>
 789
 790         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 791         qualifier.
 792         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 793
 794 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 795
 796         * f-typeprint.c (f_print_type): Update rules for printing
 797         whitespace.
 798         (f_type_print_varspec_suffix): Likewise.
 799
 800 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 801             Chris January  <chris.january@arm.com>
 802
 803         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 804         function arguments.
 805
 806 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 807
 808         * f-lang.c (build_fortran_types): Change name of void type to
 809         lower case.
 810         * f-typeprint.c (f_type_print_base): Print the name of the void
 811         type, rather than a fixed string.
 812         * f-valprint.c (f_decorations): Use lower case void string.
 813
 814 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 815             Chris January  <chris.january@arm.com>
 816
 817         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 818         types for Fortran.
 819
 820 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 821             Chris January  <chris.january@arm.com>
 822             David Lecomber  <david.lecomber@arm.com>
 823
 824         * f-exp.y (BINOP_INTRINSIC): New token.
 825         (exp): New parser rule handling BINOP_INTRINSIC.
 826         (f77_keywords): Add new builtin procedures.
 827         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 828         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 829         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 830         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 831         (print_unop_subexp_f): New function.
 832         (print_binop_subexp_f): New function.
 833         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 834         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 835         (dump_subexp_body_f): Likewise.
 836         (operator_check_f): Likewise.
 837         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 838         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 839
 840 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 841
 842         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 843         UNOP_KIND.
 844         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 845         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 846         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 847         (operator_length_f): New fuction.
 848         (print_subexp_f): New function.
 849         (op_name_f): New function.
 850         (dump_subexp_body_f): New function.
 851         (operator_check_f): New function.
 852         (exp_descriptor_f): Replace standard expression handling functions
 853         with new functions.
 854         * gdb/fortran-operator.def: New file.
 855         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 856         * gdb/std-operator.def: Remove UNOP_KIND.
 857
 858 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 859
 860         * std-operator.def: Remove unbalanced, stray double quote
 861         character.
 862
 863 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 864             Chris January  <chris.january@arm.com>
 865             Daniel Everett  <daniel.everett@arm.com>
 866             Nick Forrington  <nick.forrington@arm.com>
 867             Richard Bunt  <richard.bunt@arm.com>
 868
 869         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 870         of depth when printing anonymous structs or unions.
 871         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 872         Don't print either the top-level value, or the children if the
 873         max-depth is exceeded.
 874         (ppscm_print_children): When printing the key of a map, allow one
 875         extra level of depth.
 876         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 877         print either the top-level value, or the children if the max-depth
 878         is exceeded.
 879         (print_children): When printing the key of a map, allow one extra
 880         level of depth.
 881         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 882         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 883         (user_print_options): Initialise max_depth field.
 884         (val_print_scalar_or_string_type_p): New function.
 885         (val_print): Check to see if the max depth has been reached.
 886         (val_print_check_max_depth): Define new function.
 887         (show_print_max_depth): New function.
 888         (_initialize_valprint): Add 'print max-depth' option.
 889         * valprint.h (struct value_print_options) <max_depth>: New field.
 890         (val_print_check_max_depth): Declare new function.
 891         * NEWS: Document new feature.
 892
 893 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 894
 895         * ada-lang.c (ada_language_defn): Initialise new field.
 896         * c-lang.c (c_is_string_type_p): New function.
 897         (c_language_defn): Initialise new field.
 898         (cplus_language_defn): Initialise new field.
 899         (asm_language_defn): Initialise new field.
 900         (minimal_language_defn): Initialise new field.
 901         * c-lang.h (c_is_string_type_p): Declare new function.
 902         * d-lang.c (d_language_defn): Initialise new field.
 903         * f-lang.c (f_is_string_type_p): New function.
 904         (f_language_defn): Initialise new field.
 905         * go-lang.c (go_is_string_type_p): New function.
 906         (go_language_defn): Initialise new field.
 907         * language.c (default_is_string_type_p): New function.
 908         (unknown_language_defn): Initialise new field.
 909         (auto_language_defn): Initialise new field.
 910         * language.h (struct language_defn) <la_is_string_type_p>: New
 911         member variable.
 912         (default_is_string_type_p): Declare new function.
 913         * m2-lang.c (m2_language_defn): Initialise new field.
 914         * objc-lang.c (objc_language_defn): Initialise new field.
 915         * opencl-lang.c (opencl_language_defn): Initialise new field.
 916         * p-lang.c (pascal_is_string_type_p): New function.
 917         (pascal_language_defn): Initialise new field.
 918         * rust-lang.c (rust_is_string_type_p): New function.
 919         (rust_language_defn): Initialise new field.
 920
 921 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 922
 923         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 924         New field.
 925         * ada-lang.c (ada_language_defn): Initialise new field.
 926         * c-lang.c (c_language_defn): Likewise.
 927         (cplus_language_defn): Likewise.
 928         (asm_language_defn): Likewise.
 929         (minimal_language_defn): Likewise.
 930         * d-lang.c (d_language_defn): Likewise.
 931         * f-lang.c (f_language_defn): Likewise.
 932         * go-lang.c (go_language_defn): Likewise.
 933         * language.c (unknown_language_defn): Likewise.
 934         (auto_language_defn): Likewise.
 935         * m2-lang.c (m2_language_defn): Likewise.
 936         * objc-lang.c (objc_language_defn): Likewise.
 937         * opencl-lang.c (opencl_language_defn): Likewise.
 938         * p-lang.c (pascal_language_defn): Likewise.
 939         * rust-lang.c (rust_language_defn): Likewise.
 940
 941 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 942
 943         * ada-lang.c (ada_is_character_type): Change return type to bool.
 944         (ada_is_string_type): Likewise.
 945         * ada-lang.h (ada_is_character_type): Update declaration
 946         (ada_is_string_type): Likewise.
 947
 948 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 949
 950         Support style in 'frame|thread apply'
 951
 952         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 953         * record.c (record_start, record_stop): Update callers of
 954         execute_command_to_string with false.
 955         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 956         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 957         methods.
 958         (class string_file): New constructor with term_out parameter.
 959         Override methods term_out and can_emit_style_escape.  New member
 960         term_out.
 961         (class stdio_file): Override can_emit_style_escape.
 962         (class tee_file): Override term_out and can_emit_style_escape.
 963         * utils.h (can_emit_style_escape): Remove.
 964         * utils.c (can_emit_style_escape): Likewise.
 965         Update all callers of can_emit_style_escape (SOMESTREAM) to
 966         SOMESTREAM->can_emit_style_escape.
 967         * source-cache.c (source_cache::get_source_lines): Likewise.
 968         * stack.c (frame_apply_command_count): Call execute_command_to_string
 969         passing the term_out characteristic of the current gdb_stdout.
 970         * thread.c (thr_try_catch_cmd): Likewise.
 971         * top.c (execute_command_to_string): pass term_out parameter
 972         to construct the string_file for the command output.
 973         * ui-file.c (term_cli_styling): New function (most code moved
 974         from utils.c can_emit_style_escape).
 975         (string_file::string_file, string_file::can_emit_style_escape,
 976         stdio_file::can_emit_style_escape, tee_file::term_out,
 977         tee_file::can_emit_style_escape): New functions.
 978
 979 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 980
 981         * NEWS: Mention the new set|show may-call-functions.
 982         * infcall.c (may_call_functions_p): New variable.
 983         (show_may_call_functions_p): New function.
 984         (call_function_by_hand_dummy): Throws an error if not
 985         may-call-functions.
 986         (_initialize_infcall): Call add_setshow_boolean_cmd for
 987         may-call-functions.
 988
 989 2019-04-25  Keith Seitz  <keiths@redhat.com>
 990
 991         PR c++/24367
 992         * cp-support.c (inspect_type): Don't attempt substitutions
 993         of symbol with the same name.
 994
 995 2019-04-25  Tom Tromey  <tromey@adacore.com>
 996
 997         PR gdb/24475:
 998         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 999         static.
1000
1001 2019-04-25  Tom Tromey  <tromey@adacore.com>
1002
1003         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
1004         rvalue reference.
1005         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
1006         (gdb_xml_parser::parse): Use std::move.
1007         * python/python-internal.h (gdbpy_convert_exception): Take a const
1008         reference.
1009         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
1010         std::move.
1011         * python/py-utils.c (gdbpy_convert_exception): Take a const
1012         reference.
1013         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1014         Use std::move.
1015         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1016         Use std::move.
1017         * mi/mi-main.c (mi_print_exception): Take a const reference.
1018         * main.c (handle_command_errors): Take a const reference.
1019         * linespec.c (parse_linespec): Use std::move.
1020         * infcall.c (run_inferior_call): Use std::move.
1021         (call_function_by_hand_dummy): Use std::move.
1022         * exec.c (try_open_exec_file): Use std::move.
1023         * exceptions.h (exception_print, exception_fprintf)
1024         (exception_print_same): Update.
1025         * exceptions.c (print_exception, exception_print)
1026         (exception_fprintf, exception_print_same): Change parameters to
1027         const reference.
1028         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
1029         * common/new-op.c: Use std::move.
1030         * common/common-exceptions.h (struct gdb_exception): Add move
1031         constructor.
1032         (struct gdb_exception_error, struct gdb_exception_quit, struct
1033         gdb_quit_bad_alloc): Change constructor to move constructor.
1034         (throw_exception): Change parameter to rvalue reference.
1035         * common/common-exceptions.c (throw_exception): Take rvalue
1036         reference.
1037         * cli/cli-interp.c (safe_execute_command): Use std::move.
1038         * breakpoint.c (insert_bp_location, location_to_sals): Use
1039         std::move.
1040
1041 2019-04-25  Tom Tromey  <tromey@adacore.com>
1042
1043         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
1044         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
1045         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
1046         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
1047         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
1048         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
1049         guile/scm-value.c: Use unpack.
1050         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
1051         gdbscm_gdb_exception.
1052         (gdbscm_throw_gdb_exception): Likewise.
1053         (struct gdbscm_gdb_exception): New.
1054         (unpack): New function.
1055         (gdbscm_wrap): Use unpack.
1056
1057 2019-04-25  Tom Tromey  <tromey@adacore.com>
1058
1059         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1060         (gdb_rl_callback_handler): Use std::move.
1061         * common/common-exceptions.h (struct gdb_exception): Add move
1062         assignment operator.
1063         (throw_exception_sjlj): Change "exception" to const reference.
1064         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
1065         (throw_exception_sjlj): Change "exception" to const reference.
1066
1067 2019-04-25  Tom Tromey  <tromey@adacore.com>
1068
1069         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
1070         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
1071         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1072         Update.
1073         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1074         Update.
1075         * mi/mi-interp.c (mi_interp::exec): Update.
1076         * linespec.c (parse_linespec): Update.
1077         * infcall.c (run_inferior_call): Update.
1078         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
1079         * guile/scm-symbol.c (gdbscm_lookup_symbol)
1080         (gdbscm_lookup_global_symbol): Update.
1081         * guile/scm-param.c (gdbscm_parameter_value): Update.
1082         * guile/scm-frame.c (gdbscm_frame_read_register)
1083         (gdbscm_frame_read_var): Update.
1084         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
1085         * exec.c (try_open_exec_file): Update.
1086         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1087         (gdb_rl_callback_handler): Update.
1088         * common/common-exceptions.h (exception_none): Don't declare.
1089         * common/common-exceptions.c (exception_none): Don't define.
1090         (struct catcher) <exception>: Update.
1091         * cli/cli-interp.c (safe_execute_command): Update.
1092         * breakpoint.c (insert_bp_location, location_to_sals): Update.
1093
1094 2019-04-25  Ali Tamur  <tamur@google.com>
1095
1096         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
1097         (read_attribute_value): Likewise.
1098         (dwarf2_read_addr_index): Update comment.
1099         (read_str_index): Add DW_FORM_strx.
1100         (dwarf2_string_attr): Likewise.
1101         (dwarf2_const_value_attr): Likewise.
1102         (dump_die_shallow): Likewise.
1103         (dwarf2_fetch_constant_bytes): Likewise.
1104         (skip_form_bytes): Likewise.
1105         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
1106
1107 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
1108
1109         PR corefiles/11608
1110         PR corefiles/18187
1111         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
1112         OFFSET.  Verify if current mapping contains an ELF header.
1113         (linux_find_memory_regions_full): Adjust call to
1114         dump_mapping_p.
1115
1116 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
1117             Kang Li <kanglictf@gmail.com>
1118
1119         PR gdb/21600
1120
1121         * dwarf2-frame.c (read_initial_length): Be consistent about using
1122         unsigned representation of length.
1123         (decode_frame_entry_1): Likewise.  Check for wraparound of
1124         end pointer as well as buffer overflow.
1125
1126 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
1127
1128         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
1129         "vq".
1130
1131 2019-04-24  Tom Tromey  <tromey@adacore.com>
1132
1133         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
1134
1135 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1136
1137         * s12z-tdep.c (s12z_unwind_pc): Delete.
1138         (s12z_unwind_sp): Delete.
1139         (s12z_gdbarch_init): Don't register deleted functions with
1140         gdbarch.
1141
1142 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1143
1144         * rl78-tdep.c (rl78_unwind_sp): Delete.
1145         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
1146
1147 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1148
1149         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
1150         (xstormy16_unwind_pc): Delete.
1151         (xstormy16_dummy_id): Delete.
1152         (xstormy16_gdbarch_init): Don't register deleted functions with
1153         gdbarch.
1154
1155 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1156
1157         * vax-tdep.c (vax_unwind_pc): Delete.
1158         (vax_gdbarch_init): Don't register deleted function with gdbarch.
1159
1160 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1161
1162         * v850-tdep.c (v850_unwind_sp): Delete.
1163         (v850_unwind_pc): Delete.
1164         (v850_dummy_id): Delete.
1165         (v850_gdbarch_init): Don't register deleted functions with
1166         gdbarch.
1167
1168 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1169
1170         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
1171         (tilegx_unwind_pc): Delete.
1172         (tilegx_unwind_dummy_id): Delete.
1173         (tilegx_gdbarch_init): Don't register deleted functions with
1174         gdbarch.
1175
1176 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1177
1178         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
1179         (tic6x_dummy_id): Delete.
1180         (tic6x_gdbarch_init): Don't register deleted functions with
1181         gdbarch.
1182
1183 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1184
1185         * sparc-tdep.c (sparc_unwind_pc): Delete.
1186         (sparc32_gdbarch_init): Don't register deleted function with
1187         gdbarch.
1188
1189 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1190
1191         * sh-tdep.c (sh_unwind_sp): Delete.
1192         (sh_unwind_pc): Delete.
1193         (sh_dummy_id): Delete.
1194         (sh_gdbarch_init): Don't register deleted functions with
1195         gdbarch.
1196
1197 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1198
1199         * score-tdep.c (score_unwind_sp): Delete.
1200         (score_unwind_pc): Delete.
1201         (score_dummy_id): Delete.
1202         (score_gdbarch_init): Don't register deleted functions with
1203         gdbarch.
1204
1205 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1206
1207         * rx-tdep.c (rx_unwind_pc): Delete.
1208         (rx_unwind_sp): Delete.
1209         (rx_dummy_id): Delete.
1210         (rx_gdbarch_init): Don't register deleted functions with
1211         gdbarch.  Update comment.
1212
1213 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1214
1215         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
1216         (rs6000_dummy_id): Delete.
1217         (rs6000_gdbarch_init): Don't register deleted functions with
1218         gdbarch.
1219
1220 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1221
1222         * or1k-tdep.c (or1k_dummy_id): Delete.
1223         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
1224
1225 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1226
1227         * nios2-tdep.c (nios2_dummy_id): Delete.
1228         (nios2_unwind_sp): Delete.
1229         (nios2_gdbarch_init): Don't register deleted functions with
1230         gdbarch.
1231
1232 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1233
1234         * nds32-tdep.c (nds32_dummy_id): Delete.
1235         (nds32_unwind_pc): Delete.
1236         (nds32_unwind_sp): Delete.
1237         (nds32_gdbarch_init): Don't register deleted functions with
1238         gdbarch.
1239
1240 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1241
1242         * msp430-tdep.c (msp430_unwind_pc): Delete.
1243         (msp430_unwind_sp): Delete.
1244         (msp430_dummy_id): Delete.
1245         (msp430_gdbarch_init): Don't register deleted functions with
1246         gdbarch.
1247
1248 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1249
1250         * moxie-tdep.c (moxie_unwind_sp): Delete.
1251         (moxie_unwind_pc): Delete.
1252         (moxie_dummy_id): Delete.
1253         (moxie_gdbarch_init): Don't register deleted functions with
1254         gdbarch.
1255
1256 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1257
1258         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1259         (mn10300_unwind_pc): Delete.
1260         (mn10300_unwind_sp): Delete.
1261         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1262         mn10300_unwind_sp.
1263         (mn10300_frame_unwind_init): Don't register deleted functions with
1264         gdbarch.
1265
1266 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1267
1268         * mep-tdep.c (mep_unwind_pc): Delete.
1269         (mep_unwind_sp): Delete.
1270         (mep_dummy_id): Delete.
1271         (mep_gdbarch_init): Don't register deleted functions with
1272         gdbarch.
1273
1274 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1275
1276         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1277         (m68hc11_unwind_sp): Delete.
1278         (m68hc11_gdbarch_init): Don't register deleted functions with
1279         gdbarch.
1280
1281 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1282
1283         * m32r-tdep.c (m32r_unwind_sp): Delete.
1284         (m32r_unwind_pc): Delete.
1285         (m32r_dummy_id): Delete.
1286         (m32r_gdbarch_init): Don't register deleted functions with
1287         gdbarch.
1288
1289 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1290
1291         * m32c-tdep.c (m32c_unwind_pc): Delete.
1292         (m32c_unwind_sp): Delete.
1293         (m32c_dummy_id): Delete.
1294         (m32c_gdbarch_init): Don't register deleted functions with
1295         gdbarch.
1296
1297 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1298
1299         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1300         (lm32_unwind_pc): Delete.
1301         (lm32_dummy_id): Delete.
1302         (lm32_gdbarch_init): Don't register deleted functions with
1303         gdbarch.
1304
1305 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1306
1307         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1308         (iq2000_unwind_pc): Delete.
1309         (iq2000_dummy_id): Delete.
1310         (iq2000_gdbarch_init): Don't register deleted functions with
1311         gdbarch.
1312
1313 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1314
1315         * nds32-tdep.c (nds32_type_align): Delete.
1316         (nds32_push_dummy_call): Use type_align instead.
1317
1318 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1319
1320         * arm-tdep.c (arm_type_align): Only handle vector override case.
1321         (arm_push_dummy_call): Use type_align.
1322         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1323
1324 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1325
1326         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1327         case.
1328         (pass_on_stack): Use type_align.
1329         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1330         function.
1331
1332 2019-04-23  Tom Tromey  <tromey@adacore.com>
1333
1334         * dwarf2read.c (line_header::file_name_at): Remove unused
1335         overload.
1336
1337 2019-04-23  Tom de Vries  <tdevries@suse.de>
1338
1339         PR gdb/24438
1340         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1341         invocation.
1342
1343
1344 2019-03-27  Ali Tamur  <tamur@google.com>
1345
1346         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1347         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1348         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1349         (dwarf_expr_context::get_addr_index): Likewise
1350         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1351         (symbol_needs_eval_context::get_addr_index): Likewise
1352         (disassemble_dwarf_expression): Add DW_OP_addrx
1353         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1354         (read_cutu_die_from_dwo): Update comment
1355         (skip_one_die): Add DW_FORM_addrx
1356         (read_attribute_value): Likewise
1357         (var_decode_location): Add DW_OP_addrx
1358         (dwarf2_const_value_attr): Add DW_FORM_addrx
1359         (dump_die_shallow): Likewise
1360         (dwarf2_fetch_constant_bytes): Likewise
1361         (decode_locdesc): Add DW_OP_addrx
1362         (skip_form_bytes): Add DW_FORM_addrx
1363
1364 2019-04-22  Ali Tamur  <tamur@google.com>
1365
1366         * MAINTAINERS (Write After Approval): Add self.
1367
1368 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1369
1370         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1371         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1372         (open_symbol_file_object): Likewise.
1373         (svr4_default_sos): Add info parameter.
1374         (svr4_read_so_list): Likewise.
1375         (svr4_current_sos_direct): Adjust functions calls to pass down
1376         info.
1377         (svr4_current_sos_1): Add info parameter.
1378         (svr4_current_sos): Call get_svr4_info, pass info down to
1379         svr4_current_sos_1.
1380         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1381         get_svr4_info.
1382         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1383         get_svr4_info.
1384         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1385         to get_svr4_info.
1386         (probes_table_remove_objfile_probes): Likewise.
1387         (register_solib_event_probe): Add info parameter.
1388         (solist_update_incremental): Pass info parameter down to
1389         svr4_read_so_list.
1390         (disable_probes_interface): Add info parameter.
1391         (svr4_handle_solib_event): Pass current_program_space to
1392         get_svr4_info.  Adjust disable_probes_interface cleanup.
1393         (svr4_create_probe_breakpoints): Add info parameter, pass it
1394         down to register_solib_event_probe.
1395         (svr4_create_solib_event_breakpoints): Add info parameter,
1396         pass it down to svr4_create_probe_breakpoints.
1397         (enable_break): Pass info down to
1398         svr4_create_solib_event_breakpoints.
1399         (svr4_solib_create_inferior_hook): Pass current_program_space to
1400         get_svr4_info.
1401         (svr4_clear_solib): Likewise.
1402
1403 2019-04-22  Pedro Alves  <palves@redhat.com>
1404
1405         * solib-svr4.c (svr4_free_objfile_observer): New.
1406         (probe_and_action::objfile): New field.
1407         (probes_table_htab_remove_objfile_probes)
1408         (probes_table_remove_objfile_probes): New functions.
1409         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1410         in the new probe_and_action.  Don't store the probe in 'lookup'.
1411         (svr4_create_probe_breakpoints): Pass objfile to
1412         register_solib_event_probe.
1413         (_initialize_svr4_solib): Register a free_objfile observer.
1414
1415 2019-04-19  Tom Tromey  <tom@tromey.com>
1416
1417         * common/queue.h: Remove.
1418
1419 2019-04-19  Tom Tromey  <tom@tromey.com>
1420
1421         * event-loop.c: Don't include "common/queue.h".
1422
1423 2019-04-19  Tom Tromey  <tom@tromey.com>
1424
1425         * remote.c (remote_target): Use delete.
1426         * remote-notif.h: Include <list>, not "common/queue.h".
1427         (notif_client_p): Remove typedef.
1428         (remote_notif_state): Add constructor, destructor, initializer.
1429         <notif_queue>: Now a std::list.
1430         (remote_notif_state_xfree): Don't declare.
1431         * remote-notif.c (remote_notif_process, handle_notification)
1432         (remote_notif_state_allocate): Update.
1433         (~remote_notif_state): Rename from remote_notif_state_xfree.
1434
1435 2019-04-19  Tom Tromey  <tom@tromey.com>
1436
1437         * symfile.c (reread_symbols): Update.
1438         * objfiles.c (objfile_register_static_link)
1439         (objfile_lookup_static_link): Update
1440         (~objfile) Don't delete static_links.
1441         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1442
1443 2019-04-19  Tom Tromey  <tom@tromey.com>
1444
1445         * type-stack.h (struct type_stack) <insert>: Constify string.
1446         * type-stack.c (type_stack::insert): Constify string.
1447         * gdbtypes.h (lookup_template_type): Update.
1448         (address_space_name_to_int): Update.
1449         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1450         const.
1451         (lookup_template_type): Make name const.
1452         * c-exp.y: Update rules.
1453         (lex_one_token, classify_name, classify_inner_name)
1454         (c_print_token): Update.
1455         * p-exp.y: Update rules.
1456         (yylex): Update.
1457         * f-exp.y: Update rules.
1458         (yylex): Update.
1459         * d-exp.y: Update rules.
1460         (lex_one_token, classify_name, classify_inner_name): Update.
1461         * parse.c (write_dollar_variable, copy_name): Return std::string.
1462         * parser-defs.h (copy_name): Change return type.
1463         * m2-exp.y: Update rules.
1464         (yylex): Update.
1465         * go-exp.y (lex_one_token): Update.
1466         Update rules.
1467         (classify_unsafe_function, classify_packaged_name)
1468         (classify_name, yylex): Update.
1469
1470 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1471
1472         * configure.ac: add --enable-source-highlight switch.
1473         * configure: Regenerate.
1474         * top.c (print_gdb_version): plumb --enable-source-highlight
1475         status to "show configuration".
1476
1477 2019-04-19  Tom Tromey  <tromey@adacore.com>
1478
1479         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1480         Check ADA_TYPE_P.
1481         (empty_record, ada_template_to_fixed_record_type_1)
1482         (template_to_static_fixed_type)
1483         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1484         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1485         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1486         macros.
1487
1488 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1489
1490         PR symtab/24423:
1491         * source.c (print_source_lines_base): Advance "iter" when a
1492         control character is seen.
1493
1494 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1495
1496         * inferior.h (struct infcall_suspend_state_deleter):
1497         Catch exception in destructor to avoid crash.
1498
1499 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1500
1501         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1502         close to the add_com "shell".
1503
1504 2019-04-18  Tom Tromey  <tromey@adacore.com>
1505
1506         * process-stratum-target.h (class process_stratum_target)
1507         <stratum>: Add "final".
1508
1509 2019-04-17  Tom Tromey  <tromey@adacore.com>
1510
1511         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1512         against nullptr before use.
1513
1514 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1515
1516         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1517
1518 2019-04-17  Jim Wilson  <jimw@sifive.com>
1519             Andrew Burgess  <andrew.burgess@embecosm.com>
1520
1521         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1522         code read might fail, assume 4-byte breakpoint in that case.
1523
1524 2019-04-15  Leszek Swirski  <leszeks@google.com>
1525
1526         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1527         rather than a hand-rolled POD check when checking for forced MEMORY
1528         classification.
1529
1530 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1531
1532         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1533         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1534         function.
1535         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1536         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1537         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1538         declaration.
1539
1540 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1541
1542         * aarch64-linux-nat.c
1543         (aarch64_linux_nat_target::thread_architecture): Add override.
1544         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1545         each VQ.
1546
1547 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1548
1549         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1550
1551 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1552
1553         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1554         target types of size 96-bits, add some additional comments, and
1555         check that the builtin type we found was the correct size.
1556
1557 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1558
1559         * utils.c (prompt_for_continue): Don't restore the styling at the
1560         end, as applied_style has the wrong value.  This fixes styling in
1561         long lists of file names that are interrupted by the "Continue?"
1562         prompt.
1563
1564 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1565
1566         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1567         * c-lang.c (c_language_defn): Likewise.
1568         (cplus_language_defn): Likewise.
1569         (asm_language_defn): Likewise.
1570         (minimal_language_defn): Likewise.
1571         * d-lang.c (d_language_defn): Likewise.
1572         * f-lang.c (f_language_defn): Likewise.
1573         * go-lang.c (go_language_defn): Likewise.
1574         * language.c (unknown_language_defn): Likewise.
1575         (auto_language_defn): Likewise.
1576         * language.h (struct language_defn): Remove la_magic field.
1577         (LANG_MAGIC): Delete.
1578         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1579         * objc-lang.c (objc_language_defn): Likewise.
1580         * opencl-lang.c (opencl_language_defn): Likewise.
1581         * p-lang.c (pascal_language_defn): Likewise.
1582         * rust-lang.c (rust_language_defn): Likewise.
1583
1584 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1585
1586         * riscv-tdep.c (riscv_type_align): New function.
1587         (riscv_type_alignment): Delete.
1588         (riscv_arg_location): Use 'type_align'.
1589         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1590
1591 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1592
1593         * gdbtypes.c (type_align): A struct with no non-static fields also
1594         has alignment of 1.
1595
1596 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1597
1598         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1599         component to 0.
1600         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1601         member.
1602         (riscv_struct_info::analyse): New implementation using new
1603         analyse_inner member function.
1604         (riscv_struct_info::field_offset): New member function.
1605         (riscv_struct_info::m_offsets): New member variable.
1606         (riscv_struct_info::analyse_inner): New private member function,
1607         takes the old implementation of riscv_struct_info::analyse but
1608         extended to track field offsets.
1609         (riscv_call_arg_struct): Update the struct folding special cases
1610         to handle cases where empty C++ structs, which are non-zero
1611         length, are found.
1612         (riscv_arg_location): Initialise the length of each location, a
1613         non-zero length now indicates the location is in use.
1614         (riscv_push_dummy_call): Allow for the first location having a
1615         non-zero offset when setting up arguments.
1616         (riscv_return_value): Likewise, but for return values.
1617
1618 2019-04-11  Tom Tromey  <tromey@adacore.com>
1619
1620         * utils.c (internal_vproblem): Make "msg" const.
1621
1622 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1623
1624         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1625         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1626         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1627         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1628
1629 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1630
1631         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1632         function.
1633         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1634         of amd64_collect_native_gregset.
1635         (amd64_linux_nat_target::store_registers): Likewise.
1636
1637 2019-04-10  Tom Tromey  <tom@tromey.com>
1638
1639         * symtab.c (lookup_global_symbol_from_objfile)
1640         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1641         * objfiles.h (class separate_debug_iterator): New.
1642         (class separate_debug_range): New.
1643         (struct objfile) <separate_debug_objfiles>: New method.
1644         (objfile_separate_debug_iterate): Don't declare.
1645         * objfiles.c (separate_debug_iterator::operator++): Rename from
1646         objfile_separate_debug_iterate.
1647         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1648         iterator.
1649         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1650         iterator.
1651
1652 2019-04-10  Tom Tromey  <tom@tromey.com>
1653
1654         * symfile.c (reread_symbols): Remove old comment.
1655         * objfiles.c (free_all_objfiles): Fix a typo.
1656
1657 2019-04-10  Tom Tromey  <tom@tromey.com>
1658
1659         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1660         * minsyms.c (lookup_minimal_symbol): Use foreach.
1661         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1662         (lookup_minimal_symbol_solib_trampoline): Likewise.
1663         * symfile.c (reread_symbols): Use foreach.
1664
1665 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1666             Tom Tromey  <tromey@adacore.com>
1667
1668         PR rust/24414:
1669         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1670         (rust_lex_int_test): Change "value" to be LONGEST.
1671         (rust_lex_tests): Add test for long integer literal.
1672
1673 2019-04-09  Tom Tromey  <tromey@adacore.com>
1674
1675         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1676         to bool.
1677         (extended_remote_target::attach): Update.
1678         (remote_target::remote_notice_new_inferior): Update.
1679         (remote_target::add_current_inferior_and_thread): Update.
1680         * inferior.c (exit_inferior_1): Use "false".
1681         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1682
1683 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1684
1685         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1686         the "start" command.
1687
1688 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1689
1690         * python/py-inferior.c (infpy_thread_from_thread_handle):
1691         Adjust comments to reflect renaming of thread_from_thread_handle
1692         to thread_from_handle.  Adjust keywords.  Fix type error message.
1693         (inferior_object_methods): Add thread_from_handle.  Retain
1694         thread_from_thread_handle, but mark it as deprecated.
1695
1696 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1697
1698         * gdbthread.h (find_thread_by_handle): Revise declaration.
1699         * thread.c (find_thread_by_handle): Likewise.  Adjust
1700         implementation too.
1701         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1702         support for buffer objects as handles.
1703
1704 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1705
1706         * python/py-infthread.c (thpy_thread_handle): New function.
1707         (thread_object_methods): Register thpy_thread_handle.
1708
1709 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1710
1711         * gdbthread.h (thread_to_thread_handle): Declare.
1712         * thread.c (gdbtypes.h): Include.
1713         (thread_to_thread_handle): New function.
1714
1715         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1716         (target_thread_info_to_thread_handle): Declare.
1717         * target.c (target_thread_info_to_thread_handle): New function.
1718         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1719         * target-delegates.c: Regenerate.
1720
1721         * linux-thread-db.c (class thread_db_target): Add method
1722         thread_info_to_thread_handle.
1723         (thread_db_target::thread_info_to_thread_handle): Define.
1724         * remote.c (class remote_target): Add new method
1725         thread_info_to_thread_handle.
1726         (remote_target::thread_info_to_thread_handle): Define.
1727
1728 2019-04-08  Pedro Alves  <palves@redhat.com>
1729
1730         * common/common-exceptions.c (throw_exception): Don't create
1731         named object to throw; throw directly.
1732         (throw_it): Likewise.  Don't initialize gdb_exception::message
1733         here, with new; pass FMT and AP to the ctor instead.
1734         * common/common-exceptions.h: Include <string>.
1735         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1736         const char *, va_list)): New ctor.  Use std::make_shared.
1737         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1738         errors)): Delete.
1739         (gdb_exception_error::gdb_exception_error(enum errors, const char
1740         *, va_list)): New.
1741         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1742         Add assertion.
1743         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1744         errors)): Delete.
1745         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1746         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1747         Add assertion.
1748
1749 2019-04-08  Tom Tromey  <tom@tromey.com>
1750
1751         * valops.c (value_rtti_indirect_type): Replace throw_exception
1752         with throw.
1753         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1754         with throw.
1755         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1756         throw.
1757         * target.c (target_translate_tls_address): Replace throw_exception
1758         with throw.
1759         * stack.c (frame_apply_command_count): Replace throw_exception
1760         with throw.
1761         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1762         throw.
1763         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1764         with throw.
1765         * rs6000-tdep.c (rs6000_frame_cache)
1766         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1767         * remote.c: Replace throw_exception with throw.
1768         * record-full.c (record_full_message, record_full_wait_1)
1769         (record_full_restore): Replace throw_exception with throw.
1770         * record-btrace.c:
1771         (get_thread_current_frame_id, record_btrace_start_replaying)
1772         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1773         (cmd_record_btrace_start): Replace throw_exception with throw.
1774         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1775         throw.
1776         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1777         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1778         * linespec.c:
1779         (find_linespec_symbols): Replace throw_exception with throw.
1780         * infrun.c (displaced_step_prepare, resume): Replace
1781         throw_exception with throw.
1782         * infcmd.c (post_create_inferior): Replace throw_exception with
1783         throw.
1784         * inf-loop.c (inferior_event_handler): Replace throw_exception
1785         with throw.
1786         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1787         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1788         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1789         (get_prev_frame_always, get_frame_pc_if_available)
1790         (get_frame_address_in_block_if_available, get_frame_language):
1791         Replace throw_exception with throw.
1792         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1793         throw_exception with throw.
1794         * eval.c (fetch_subexp_value, evaluate_var_value)
1795         (evaluate_funcall, evaluate_subexp_standard): Replace
1796         throw_exception with throw.
1797         * dwarf2loc.c (call_site_find_chain)
1798         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1799         Replace throw_exception with throw.
1800         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1801         with throw.
1802         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1803         throw.
1804         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1805         * completer.c (complete_line_internal): Replace throw_exception
1806         with throw.
1807         * compile/compile-object-run.c (compile_object_run): Replace
1808         throw_exception with throw.
1809         * cli/cli-script.c (process_next_line): Replace throw_exception
1810         with throw.
1811         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1812         (btrace_enable, btrace_maint_update_pt_packets): Replace
1813         throw_exception with throw.
1814         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1815         throw_exception with throw.
1816         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1817         throw_exception with throw.
1818         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1819         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1820         * aarch64-tdep.c (aarch64_make_prologue_cache)
1821         (aarch64_make_stub_cache): Replace throw_exception with throw.
1822
1823 2019-04-08  Tom Tromey  <tom@tromey.com>
1824
1825         * common/common-exceptions.c (throw_exception): Rename from
1826         throw_exception_cxx.  Remove old copy.  Make argument const.
1827         (throw_it): Create and throw exception objects directly.
1828         * common/common-exceptions.h (throw_exception): Make argument
1829         const.
1830         (struct gdb_exception_error): Add constructor.
1831         (struct gdb_exception_quit): Add constructor.
1832
1833 2019-04-08  Tom Tromey  <tom@tromey.com>
1834
1835         * common/common-exceptions.h (exception_rethrow): Don't declare.
1836         (TRY_SJLJ): Update comment.
1837         (TRY, CATCH, END_CATCH): Remove.
1838         * common/common-exceptions.c (exception_rethrow): Remove.
1839
1840 2019-04-08  Tom Tromey  <tom@tromey.com>
1841
1842         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1843         Remove.
1844         (gdb_exception_error): Rename from
1845         gdb_exception_RETURN_MASK_ERROR.
1846         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1847         (gdb_quit_bad_alloc): Update.
1848         * aarch64-tdep.c: Update.
1849         * ada-lang.c: Update.
1850         * ada-typeprint.c: Update.
1851         * ada-valprint.c: Update.
1852         * amd64-tdep.c: Update.
1853         * arch-utils.c: Update.
1854         * break-catch-throw.c: Update.
1855         * breakpoint.c: Update.
1856         * btrace.c: Update.
1857         * c-varobj.c: Update.
1858         * cli/cli-cmds.c: Update.
1859         * cli/cli-interp.c: Update.
1860         * cli/cli-script.c: Update.
1861         * common/common-exceptions.c: Update.
1862         * common/new-op.c: Update.
1863         * common/selftest.c: Update.
1864         * compile/compile-c-symbols.c: Update.
1865         * compile/compile-cplus-symbols.c: Update.
1866         * compile/compile-object-load.c: Update.
1867         * compile/compile-object-run.c: Update.
1868         * completer.c: Update.
1869         * corelow.c: Update.
1870         * cp-abi.c: Update.
1871         * cp-support.c: Update.
1872         * cp-valprint.c: Update.
1873         * darwin-nat.c: Update.
1874         * disasm-selftests.c: Update.
1875         * dtrace-probe.c: Update.
1876         * dwarf-index-cache.c: Update.
1877         * dwarf-index-write.c: Update.
1878         * dwarf2-frame-tailcall.c: Update.
1879         * dwarf2-frame.c: Update.
1880         * dwarf2loc.c: Update.
1881         * dwarf2read.c: Update.
1882         * eval.c: Update.
1883         * event-loop.c: Update.
1884         * event-top.c: Update.
1885         * exec.c: Update.
1886         * f-valprint.c: Update.
1887         * fbsd-tdep.c: Update.
1888         * frame-unwind.c: Update.
1889         * frame.c: Update.
1890         * gdbtypes.c: Update.
1891         * gnu-v3-abi.c: Update.
1892         * guile/guile-internal.h: Update.
1893         * guile/scm-block.c: Update.
1894         * guile/scm-breakpoint.c: Update.
1895         * guile/scm-cmd.c: Update.
1896         * guile/scm-disasm.c: Update.
1897         * guile/scm-frame.c: Update.
1898         * guile/scm-lazy-string.c: Update.
1899         * guile/scm-math.c: Update.
1900         * guile/scm-param.c: Update.
1901         * guile/scm-ports.c: Update.
1902         * guile/scm-pretty-print.c: Update.
1903         * guile/scm-symbol.c: Update.
1904         * guile/scm-symtab.c: Update.
1905         * guile/scm-type.c: Update.
1906         * guile/scm-value.c: Update.
1907         * i386-linux-tdep.c: Update.
1908         * i386-tdep.c: Update.
1909         * inf-loop.c: Update.
1910         * infcall.c: Update.
1911         * infcmd.c: Update.
1912         * infrun.c: Update.
1913         * jit.c: Update.
1914         * language.c: Update.
1915         * linespec.c: Update.
1916         * linux-fork.c: Update.
1917         * linux-nat.c: Update.
1918         * linux-tdep.c: Update.
1919         * linux-thread-db.c: Update.
1920         * main.c: Update.
1921         * mi/mi-cmd-break.c: Update.
1922         * mi/mi-cmd-stack.c: Update.
1923         * mi/mi-interp.c: Update.
1924         * mi/mi-main.c: Update.
1925         * objc-lang.c: Update.
1926         * p-valprint.c: Update.
1927         * parse.c: Update.
1928         * ppc-linux-tdep.c: Update.
1929         * printcmd.c: Update.
1930         * python/py-arch.c: Update.
1931         * python/py-breakpoint.c: Update.
1932         * python/py-cmd.c: Update.
1933         * python/py-finishbreakpoint.c: Update.
1934         * python/py-frame.c: Update.
1935         * python/py-framefilter.c: Update.
1936         * python/py-gdb-readline.c: Update.
1937         * python/py-inferior.c: Update.
1938         * python/py-infthread.c: Update.
1939         * python/py-lazy-string.c: Update.
1940         * python/py-linetable.c: Update.
1941         * python/py-objfile.c: Update.
1942         * python/py-param.c: Update.
1943         * python/py-prettyprint.c: Update.
1944         * python/py-progspace.c: Update.
1945         * python/py-record-btrace.c: Update.
1946         * python/py-record.c: Update.
1947         * python/py-symbol.c: Update.
1948         * python/py-type.c: Update.
1949         * python/py-unwind.c: Update.
1950         * python/py-utils.c: Update.
1951         * python/py-value.c: Update.
1952         * python/python.c: Update.
1953         * record-btrace.c: Update.
1954         * record-full.c: Update.
1955         * remote-fileio.c: Update.
1956         * remote.c: Update.
1957         * riscv-tdep.c: Update.
1958         * rs6000-aix-tdep.c: Update.
1959         * rs6000-tdep.c: Update.
1960         * rust-exp.y: Update.
1961         * rust-lang.c: Update.
1962         * s390-tdep.c: Update.
1963         * selftest-arch.c: Update.
1964         * solib-dsbt.c: Update.
1965         * solib-frv.c: Update.
1966         * solib-spu.c: Update.
1967         * solib-svr4.c: Update.
1968         * solib.c: Update.
1969         * sparc64-linux-tdep.c: Update.
1970         * stack.c: Update.
1971         * symfile-mem.c: Update.
1972         * symmisc.c: Update.
1973         * target.c: Update.
1974         * thread.c: Update.
1975         * top.c: Update.
1976         * tracefile-tfile.c: Update.
1977         * tui/tui.c: Update.
1978         * typeprint.c: Update.
1979         * unittests/cli-utils-selftests.c: Update.
1980         * unittests/parse-connection-spec-selftests.c: Update.
1981         * valops.c: Update.
1982         * valprint.c: Update.
1983         * value.c: Update.
1984         * varobj.c: Update.
1985         * windows-nat.c: Update.
1986         * x86-linux-nat.c: Update.
1987         * xml-support.c: Update.
1988
1989 2019-04-08  Tom Tromey  <tom@tromey.com>
1990
1991         * xml-support.c: Use C++ exception handling.
1992         * x86-linux-nat.c: Use C++ exception handling.
1993         * windows-nat.c: Use C++ exception handling.
1994         * varobj.c: Use C++ exception handling.
1995         * value.c: Use C++ exception handling.
1996         * valprint.c: Use C++ exception handling.
1997         * valops.c: Use C++ exception handling.
1998         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1999         handling.
2000         * unittests/cli-utils-selftests.c: Use C++ exception handling.
2001         * typeprint.c: Use C++ exception handling.
2002         * tui/tui.c: Use C++ exception handling.
2003         * tracefile-tfile.c: Use C++ exception handling.
2004         * top.c: Use C++ exception handling.
2005         * thread.c: Use C++ exception handling.
2006         * target.c: Use C++ exception handling.
2007         * symmisc.c: Use C++ exception handling.
2008         * symfile-mem.c: Use C++ exception handling.
2009         * stack.c: Use C++ exception handling.
2010         * sparc64-linux-tdep.c: Use C++ exception handling.
2011         * solib.c: Use C++ exception handling.
2012         * solib-svr4.c: Use C++ exception handling.
2013         * solib-spu.c: Use C++ exception handling.
2014         * solib-frv.c: Use C++ exception handling.
2015         * solib-dsbt.c: Use C++ exception handling.
2016         * selftest-arch.c: Use C++ exception handling.
2017         * s390-tdep.c: Use C++ exception handling.
2018         * rust-lang.c: Use C++ exception handling.
2019         * rust-exp.y: Use C++ exception handling.
2020         * rs6000-tdep.c: Use C++ exception handling.
2021         * rs6000-aix-tdep.c: Use C++ exception handling.
2022         * riscv-tdep.c: Use C++ exception handling.
2023         * remote.c: Use C++ exception handling.
2024         * remote-fileio.c: Use C++ exception handling.
2025         * record-full.c: Use C++ exception handling.
2026         * record-btrace.c: Use C++ exception handling.
2027         * python/python.c: Use C++ exception handling.
2028         * python/py-value.c: Use C++ exception handling.
2029         * python/py-utils.c: Use C++ exception handling.
2030         * python/py-unwind.c: Use C++ exception handling.
2031         * python/py-type.c: Use C++ exception handling.
2032         * python/py-symbol.c: Use C++ exception handling.
2033         * python/py-record.c: Use C++ exception handling.
2034         * python/py-record-btrace.c: Use C++ exception handling.
2035         * python/py-progspace.c: Use C++ exception handling.
2036         * python/py-prettyprint.c: Use C++ exception handling.
2037         * python/py-param.c: Use C++ exception handling.
2038         * python/py-objfile.c: Use C++ exception handling.
2039         * python/py-linetable.c: Use C++ exception handling.
2040         * python/py-lazy-string.c: Use C++ exception handling.
2041         * python/py-infthread.c: Use C++ exception handling.
2042         * python/py-inferior.c: Use C++ exception handling.
2043         * python/py-gdb-readline.c: Use C++ exception handling.
2044         * python/py-framefilter.c: Use C++ exception handling.
2045         * python/py-frame.c: Use C++ exception handling.
2046         * python/py-finishbreakpoint.c: Use C++ exception handling.
2047         * python/py-cmd.c: Use C++ exception handling.
2048         * python/py-breakpoint.c: Use C++ exception handling.
2049         * python/py-arch.c: Use C++ exception handling.
2050         * printcmd.c: Use C++ exception handling.
2051         * ppc-linux-tdep.c: Use C++ exception handling.
2052         * parse.c: Use C++ exception handling.
2053         * p-valprint.c: Use C++ exception handling.
2054         * objc-lang.c: Use C++ exception handling.
2055         * mi/mi-main.c: Use C++ exception handling.
2056         * mi/mi-interp.c: Use C++ exception handling.
2057         * mi/mi-cmd-stack.c: Use C++ exception handling.
2058         * mi/mi-cmd-break.c: Use C++ exception handling.
2059         * main.c: Use C++ exception handling.
2060         * linux-thread-db.c: Use C++ exception handling.
2061         * linux-tdep.c: Use C++ exception handling.
2062         * linux-nat.c: Use C++ exception handling.
2063         * linux-fork.c: Use C++ exception handling.
2064         * linespec.c: Use C++ exception handling.
2065         * language.c: Use C++ exception handling.
2066         * jit.c: Use C++ exception handling.
2067         * infrun.c: Use C++ exception handling.
2068         * infcmd.c: Use C++ exception handling.
2069         * infcall.c: Use C++ exception handling.
2070         * inf-loop.c: Use C++ exception handling.
2071         * i386-tdep.c: Use C++ exception handling.
2072         * i386-linux-tdep.c: Use C++ exception handling.
2073         * guile/scm-value.c: Use C++ exception handling.
2074         * guile/scm-type.c: Use C++ exception handling.
2075         * guile/scm-symtab.c: Use C++ exception handling.
2076         * guile/scm-symbol.c: Use C++ exception handling.
2077         * guile/scm-pretty-print.c: Use C++ exception handling.
2078         * guile/scm-ports.c: Use C++ exception handling.
2079         * guile/scm-param.c: Use C++ exception handling.
2080         * guile/scm-math.c: Use C++ exception handling.
2081         * guile/scm-lazy-string.c: Use C++ exception handling.
2082         * guile/scm-frame.c: Use C++ exception handling.
2083         * guile/scm-disasm.c: Use C++ exception handling.
2084         * guile/scm-cmd.c: Use C++ exception handling.
2085         * guile/scm-breakpoint.c: Use C++ exception handling.
2086         * guile/scm-block.c: Use C++ exception handling.
2087         * guile/guile-internal.h: Use C++ exception handling.
2088         * gnu-v3-abi.c: Use C++ exception handling.
2089         * gdbtypes.c: Use C++ exception handling.
2090         * frame.c: Use C++ exception handling.
2091         * frame-unwind.c: Use C++ exception handling.
2092         * fbsd-tdep.c: Use C++ exception handling.
2093         * f-valprint.c: Use C++ exception handling.
2094         * exec.c: Use C++ exception handling.
2095         * event-top.c: Use C++ exception handling.
2096         * event-loop.c: Use C++ exception handling.
2097         * eval.c: Use C++ exception handling.
2098         * dwarf2read.c: Use C++ exception handling.
2099         * dwarf2loc.c: Use C++ exception handling.
2100         * dwarf2-frame.c: Use C++ exception handling.
2101         * dwarf2-frame-tailcall.c: Use C++ exception handling.
2102         * dwarf-index-write.c: Use C++ exception handling.
2103         * dwarf-index-cache.c: Use C++ exception handling.
2104         * dtrace-probe.c: Use C++ exception handling.
2105         * disasm-selftests.c: Use C++ exception handling.
2106         * darwin-nat.c: Use C++ exception handling.
2107         * cp-valprint.c: Use C++ exception handling.
2108         * cp-support.c: Use C++ exception handling.
2109         * cp-abi.c: Use C++ exception handling.
2110         * corelow.c: Use C++ exception handling.
2111         * completer.c: Use C++ exception handling.
2112         * compile/compile-object-run.c: Use C++ exception handling.
2113         * compile/compile-object-load.c: Use C++ exception handling.
2114         * compile/compile-cplus-symbols.c: Use C++ exception handling.
2115         * compile/compile-c-symbols.c: Use C++ exception handling.
2116         * common/selftest.c: Use C++ exception handling.
2117         * common/new-op.c: Use C++ exception handling.
2118         * cli/cli-script.c: Use C++ exception handling.
2119         * cli/cli-interp.c: Use C++ exception handling.
2120         * cli/cli-cmds.c: Use C++ exception handling.
2121         * c-varobj.c: Use C++ exception handling.
2122         * btrace.c: Use C++ exception handling.
2123         * breakpoint.c: Use C++ exception handling.
2124         * break-catch-throw.c: Use C++ exception handling.
2125         * arch-utils.c: Use C++ exception handling.
2126         * amd64-tdep.c: Use C++ exception handling.
2127         * ada-valprint.c: Use C++ exception handling.
2128         * ada-typeprint.c: Use C++ exception handling.
2129         * ada-lang.c: Use C++ exception handling.
2130         * aarch64-tdep.c: Use C++ exception handling.
2131
2132 2019-04-08  Tom Tromey  <tom@tromey.com>
2133
2134         * xml-support.c (gdb_xml_parser::parse): Update.
2135         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2136         * value.c (show_convenience): Update.
2137         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
2138         (test_parse_flags_qcs): Update.
2139         * thread.c (thr_try_catch_cmd): Update.
2140         * target.c (target_translate_tls_address): Update.
2141         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2142         (info_frame_command_core, frame_apply_command_count): Update.
2143         * rust-exp.y (rust_lex_exception_test): Update.
2144         * riscv-tdep.c (riscv_print_one_register_info): Update.
2145         * remote.c (remote_target::enable_btrace): Update.
2146         * record-btrace.c (record_btrace_enable_warn): Update.
2147         * python/py-utils.c (gdbpy_convert_exception): Update.
2148         * printcmd.c (do_one_display, print_variable_and_value): Update.
2149         * mi/mi-main.c (mi_print_exception): Update.
2150         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
2151         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2152         * linux-nat.c (linux_nat_target::attach): Update.
2153         * linux-fork.c (class scoped_switch_fork_info): Update.
2154         * infrun.c (displaced_step_prepare): Update.
2155         * infcall.c (call_function_by_hand_dummy): Update.
2156         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
2157         * gnu-v3-abi.c (print_one_vtable): Update.
2158         * frame.c (get_prev_frame_always): Update.
2159         * f-valprint.c (info_common_command_for_block): Update.
2160         * exec.c (try_open_exec_file): Update.
2161         * exceptions.c (print_exception, exception_print)
2162         (exception_fprintf, exception_print_same): Update.
2163         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
2164         * dwarf-index-cache.c (index_cache::store)
2165         (index_cache::lookup_gdb_index): Update.
2166         * darwin-nat.c (maybe_cache_shell): Update.
2167         * cp-valprint.c (cp_print_value_fields): Update.
2168         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
2169         (gcc_cplus_symbol_address): Update.
2170         * compile/compile-c-symbols.c (gcc_convert_symbol)
2171         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
2172         * common/selftest.c: Update.
2173         * common/common-exceptions.h (struct gdb_exception) <message>: Now
2174         a std::string.
2175         (exception_try_scope_entry, exception_try_scope_exit): Don't
2176         declare.
2177         (struct exception_try_scope): Remove.
2178         (TRY): Don't use exception_try_scope.
2179         (struct gdb_exception): Add constructor, operator=.
2180         <what>: New method.
2181         (struct gdb_exception_RETURN_MASK_ALL)
2182         (struct gdb_exception_RETURN_MASK_ERROR)
2183         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
2184         (struct gdb_quit_bad_alloc): Update.
2185         * common/common-exceptions.c (exception_none): Change
2186         initializer.
2187         (struct catcher) <state, exception>: Initialize inline.
2188         <prev>: Remove member.
2189         (current_catcher): Remove.
2190         (catchers): New global.
2191         (exceptions_state_mc_init): Simplify.
2192         (catcher_pop): Remove.
2193         (exceptions_state_mc, exceptions_state_mc_catch): Update.
2194         (try_scope_depth, exception_try_scope_entry)
2195         (exception_try_scope_exit): Remove.
2196         (throw_exception_sjlj): Update.
2197         (exception_messages, exception_messages_size): Remove.
2198         (throw_it): Simplify.
2199         (gdb_exception_sliced_copy): Remove.
2200         (throw_exception_cxx): Update.
2201         * cli/cli-script.c (script_from_file): Update.
2202         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
2203         Update.
2204         * ada-valprint.c (ada_val_print): Update.
2205         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
2206         (create_excep_cond_exprs): Update.
2207
2208 2019-04-08  Tom Tromey  <tom@tromey.com>
2209
2210         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
2211         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
2212         (TRY, CATCH, END_CATCH): Remove some definitions.
2213         * common/common-exceptions.c: Don't use GDB_XCPT.
2214         (catcher_list_size): Remove.
2215         (throw_exception, throw_it): Simplify.
2216
2217 2019-04-05  Tom Tromey  <tom@tromey.com>
2218
2219         Revert the header-sorting patch.
2220         * ft32-tdep.c: Revert.
2221         * frv-tdep.c: Revert.
2222         * frv-linux-tdep.c: Revert.
2223         * frame.c: Revert.
2224         * frame-unwind.c: Revert.
2225         * frame-base.c: Revert.
2226         * fork-child.c: Revert.
2227         * findvar.c: Revert.
2228         * findcmd.c: Revert.
2229         * filesystem.c: Revert.
2230         * filename-seen-cache.h: Revert.
2231         * filename-seen-cache.c: Revert.
2232         * fbsd-tdep.c: Revert.
2233         * fbsd-nat.h: Revert.
2234         * fbsd-nat.c: Revert.
2235         * f-valprint.c: Revert.
2236         * f-typeprint.c: Revert.
2237         * f-lang.c: Revert.
2238         * extension.h: Revert.
2239         * extension.c: Revert.
2240         * extension-priv.h: Revert.
2241         * expprint.c: Revert.
2242         * exec.h: Revert.
2243         * exec.c: Revert.
2244         * exceptions.c: Revert.
2245         * event-top.c: Revert.
2246         * event-loop.c: Revert.
2247         * eval.c: Revert.
2248         * elfread.c: Revert.
2249         * dwarf2read.h: Revert.
2250         * dwarf2read.c: Revert.
2251         * dwarf2loc.c: Revert.
2252         * dwarf2expr.h: Revert.
2253         * dwarf2expr.c: Revert.
2254         * dwarf2-frame.c: Revert.
2255         * dwarf2-frame-tailcall.c: Revert.
2256         * dwarf-index-write.h: Revert.
2257         * dwarf-index-write.c: Revert.
2258         * dwarf-index-common.c: Revert.
2259         * dwarf-index-cache.h: Revert.
2260         * dwarf-index-cache.c: Revert.
2261         * dummy-frame.c: Revert.
2262         * dtrace-probe.c: Revert.
2263         * disasm.h: Revert.
2264         * disasm.c: Revert.
2265         * disasm-selftests.c: Revert.
2266         * dictionary.c: Revert.
2267         * dicos-tdep.c: Revert.
2268         * demangle.c: Revert.
2269         * dcache.h: Revert.
2270         * dcache.c: Revert.
2271         * darwin-nat.h: Revert.
2272         * darwin-nat.c: Revert.
2273         * darwin-nat-info.c: Revert.
2274         * d-valprint.c: Revert.
2275         * d-namespace.c: Revert.
2276         * d-lang.c: Revert.
2277         * ctf.c: Revert.
2278         * csky-tdep.c: Revert.
2279         * csky-linux-tdep.c: Revert.
2280         * cris-tdep.c: Revert.
2281         * cris-linux-tdep.c: Revert.
2282         * cp-valprint.c: Revert.
2283         * cp-support.c: Revert.
2284         * cp-namespace.c: Revert.
2285         * cp-abi.c: Revert.
2286         * corelow.c: Revert.
2287         * corefile.c: Revert.
2288         * continuations.c: Revert.
2289         * completer.h: Revert.
2290         * completer.c: Revert.
2291         * complaints.c: Revert.
2292         * coffread.c: Revert.
2293         * coff-pe-read.c: Revert.
2294         * cli-out.h: Revert.
2295         * cli-out.c: Revert.
2296         * charset.c: Revert.
2297         * c-varobj.c: Revert.
2298         * c-valprint.c: Revert.
2299         * c-typeprint.c: Revert.
2300         * c-lang.c: Revert.
2301         * buildsym.c: Revert.
2302         * buildsym-legacy.c: Revert.
2303         * build-id.h: Revert.
2304         * build-id.c: Revert.
2305         * btrace.c: Revert.
2306         * bsd-uthread.c: Revert.
2307         * breakpoint.h: Revert.
2308         * breakpoint.c: Revert.
2309         * break-catch-throw.c: Revert.
2310         * break-catch-syscall.c: Revert.
2311         * break-catch-sig.c: Revert.
2312         * blockframe.c: Revert.
2313         * block.c: Revert.
2314         * bfin-tdep.c: Revert.
2315         * bfin-linux-tdep.c: Revert.
2316         * bfd-target.c: Revert.
2317         * bcache.c: Revert.
2318         * ax-general.c: Revert.
2319         * ax-gdb.h: Revert.
2320         * ax-gdb.c: Revert.
2321         * avr-tdep.c: Revert.
2322         * auxv.c: Revert.
2323         * auto-load.c: Revert.
2324         * arm-wince-tdep.c: Revert.
2325         * arm-tdep.c: Revert.
2326         * arm-symbian-tdep.c: Revert.
2327         * arm-pikeos-tdep.c: Revert.
2328         * arm-obsd-tdep.c: Revert.
2329         * arm-nbsd-tdep.c: Revert.
2330         * arm-nbsd-nat.c: Revert.
2331         * arm-linux-tdep.c: Revert.
2332         * arm-linux-nat.c: Revert.
2333         * arm-fbsd-tdep.c: Revert.
2334         * arm-fbsd-nat.c: Revert.
2335         * arm-bsd-tdep.c: Revert.
2336         * arch-utils.c: Revert.
2337         * arc-tdep.c: Revert.
2338         * arc-newlib-tdep.c: Revert.
2339         * annotate.h: Revert.
2340         * annotate.c: Revert.
2341         * amd64-windows-tdep.c: Revert.
2342         * amd64-windows-nat.c: Revert.
2343         * amd64-tdep.c: Revert.
2344         * amd64-sol2-tdep.c: Revert.
2345         * amd64-obsd-tdep.c: Revert.
2346         * amd64-obsd-nat.c: Revert.
2347         * amd64-nbsd-tdep.c: Revert.
2348         * amd64-nbsd-nat.c: Revert.
2349         * amd64-nat.c: Revert.
2350         * amd64-linux-tdep.c: Revert.
2351         * amd64-linux-nat.c: Revert.
2352         * amd64-fbsd-tdep.c: Revert.
2353         * amd64-fbsd-nat.c: Revert.
2354         * amd64-dicos-tdep.c: Revert.
2355         * amd64-darwin-tdep.c: Revert.
2356         * amd64-bsd-nat.c: Revert.
2357         * alpha-tdep.c: Revert.
2358         * alpha-obsd-tdep.c: Revert.
2359         * alpha-nbsd-tdep.c: Revert.
2360         * alpha-mdebug-tdep.c: Revert.
2361         * alpha-linux-tdep.c: Revert.
2362         * alpha-linux-nat.c: Revert.
2363         * alpha-bsd-tdep.c: Revert.
2364         * alpha-bsd-nat.c: Revert.
2365         * aix-thread.c: Revert.
2366         * agent.c: Revert.
2367         * addrmap.c: Revert.
2368         * ada-varobj.c: Revert.
2369         * ada-valprint.c: Revert.
2370         * ada-typeprint.c: Revert.
2371         * ada-tasks.c: Revert.
2372         * ada-lang.c: Revert.
2373         * aarch64-tdep.c: Revert.
2374         * aarch64-ravenscar-thread.c: Revert.
2375         * aarch64-newlib-tdep.c: Revert.
2376         * aarch64-linux-tdep.c: Revert.
2377         * aarch64-linux-nat.c: Revert.
2378         * aarch64-fbsd-tdep.c: Revert.
2379         * aarch64-fbsd-nat.c: Revert.
2380         * aarch32-linux-nat.c: Revert.
2381
2382 2019-04-05  Tom Tromey  <tom@tromey.com>
2383
2384         * ft32-tdep.c: Sort headers.
2385         * frv-tdep.c: Sort headers.
2386         * frv-linux-tdep.c: Sort headers.
2387         * frame.c: Sort headers.
2388         * frame-unwind.c: Sort headers.
2389         * frame-base.c: Sort headers.
2390         * fork-child.c: Sort headers.
2391         * findvar.c: Sort headers.
2392         * findcmd.c: Sort headers.
2393         * filesystem.c: Sort headers.
2394         * filename-seen-cache.h: Sort headers.
2395         * filename-seen-cache.c: Sort headers.
2396         * fbsd-tdep.c: Sort headers.
2397         * fbsd-nat.h: Sort headers.
2398         * fbsd-nat.c: Sort headers.
2399         * f-valprint.c: Sort headers.
2400         * f-typeprint.c: Sort headers.
2401         * f-lang.c: Sort headers.
2402         * extension.h: Sort headers.
2403         * extension.c: Sort headers.
2404         * extension-priv.h: Sort headers.
2405         * expprint.c: Sort headers.
2406         * exec.h: Sort headers.
2407         * exec.c: Sort headers.
2408         * exceptions.c: Sort headers.
2409         * event-top.c: Sort headers.
2410         * event-loop.c: Sort headers.
2411         * eval.c: Sort headers.
2412         * elfread.c: Sort headers.
2413         * dwarf2read.h: Sort headers.
2414         * dwarf2read.c: Sort headers.
2415         * dwarf2loc.c: Sort headers.
2416         * dwarf2expr.h: Sort headers.
2417         * dwarf2expr.c: Sort headers.
2418         * dwarf2-frame.c: Sort headers.
2419         * dwarf2-frame-tailcall.c: Sort headers.
2420         * dwarf-index-write.h: Sort headers.
2421         * dwarf-index-write.c: Sort headers.
2422         * dwarf-index-common.c: Sort headers.
2423         * dwarf-index-cache.h: Sort headers.
2424         * dwarf-index-cache.c: Sort headers.
2425         * dummy-frame.c: Sort headers.
2426         * dtrace-probe.c: Sort headers.
2427         * disasm.h: Sort headers.
2428         * disasm.c: Sort headers.
2429         * disasm-selftests.c: Sort headers.
2430         * dictionary.c: Sort headers.
2431         * dicos-tdep.c: Sort headers.
2432         * demangle.c: Sort headers.
2433         * dcache.h: Sort headers.
2434         * dcache.c: Sort headers.
2435         * darwin-nat.h: Sort headers.
2436         * darwin-nat.c: Sort headers.
2437         * darwin-nat-info.c: Sort headers.
2438         * d-valprint.c: Sort headers.
2439         * d-namespace.c: Sort headers.
2440         * d-lang.c: Sort headers.
2441         * ctf.c: Sort headers.
2442         * csky-tdep.c: Sort headers.
2443         * csky-linux-tdep.c: Sort headers.
2444         * cris-tdep.c: Sort headers.
2445         * cris-linux-tdep.c: Sort headers.
2446         * cp-valprint.c: Sort headers.
2447         * cp-support.c: Sort headers.
2448         * cp-namespace.c: Sort headers.
2449         * cp-abi.c: Sort headers.
2450         * corelow.c: Sort headers.
2451         * corefile.c: Sort headers.
2452         * continuations.c: Sort headers.
2453         * completer.h: Sort headers.
2454         * completer.c: Sort headers.
2455         * complaints.c: Sort headers.
2456         * coffread.c: Sort headers.
2457         * coff-pe-read.c: Sort headers.
2458         * cli-out.h: Sort headers.
2459         * cli-out.c: Sort headers.
2460         * charset.c: Sort headers.
2461         * c-varobj.c: Sort headers.
2462         * c-valprint.c: Sort headers.
2463         * c-typeprint.c: Sort headers.
2464         * c-lang.c: Sort headers.
2465         * buildsym.c: Sort headers.
2466         * buildsym-legacy.c: Sort headers.
2467         * build-id.h: Sort headers.
2468         * build-id.c: Sort headers.
2469         * btrace.c: Sort headers.
2470         * bsd-uthread.c: Sort headers.
2471         * breakpoint.h: Sort headers.
2472         * breakpoint.c: Sort headers.
2473         * break-catch-throw.c: Sort headers.
2474         * break-catch-syscall.c: Sort headers.
2475         * break-catch-sig.c: Sort headers.
2476         * blockframe.c: Sort headers.
2477         * block.c: Sort headers.
2478         * bfin-tdep.c: Sort headers.
2479         * bfin-linux-tdep.c: Sort headers.
2480         * bfd-target.c: Sort headers.
2481         * bcache.c: Sort headers.
2482         * ax-general.c: Sort headers.
2483         * ax-gdb.h: Sort headers.
2484         * ax-gdb.c: Sort headers.
2485         * avr-tdep.c: Sort headers.
2486         * auxv.c: Sort headers.
2487         * auto-load.c: Sort headers.
2488         * arm-wince-tdep.c: Sort headers.
2489         * arm-tdep.c: Sort headers.
2490         * arm-symbian-tdep.c: Sort headers.
2491         * arm-pikeos-tdep.c: Sort headers.
2492         * arm-obsd-tdep.c: Sort headers.
2493         * arm-nbsd-tdep.c: Sort headers.
2494         * arm-nbsd-nat.c: Sort headers.
2495         * arm-linux-tdep.c: Sort headers.
2496         * arm-linux-nat.c: Sort headers.
2497         * arm-fbsd-tdep.c: Sort headers.
2498         * arm-fbsd-nat.c: Sort headers.
2499         * arm-bsd-tdep.c: Sort headers.
2500         * arch-utils.c: Sort headers.
2501         * arc-tdep.c: Sort headers.
2502         * arc-newlib-tdep.c: Sort headers.
2503         * annotate.h: Sort headers.
2504         * annotate.c: Sort headers.
2505         * amd64-windows-tdep.c: Sort headers.
2506         * amd64-windows-nat.c: Sort headers.
2507         * amd64-tdep.c: Sort headers.
2508         * amd64-sol2-tdep.c: Sort headers.
2509         * amd64-obsd-tdep.c: Sort headers.
2510         * amd64-obsd-nat.c: Sort headers.
2511         * amd64-nbsd-tdep.c: Sort headers.
2512         * amd64-nbsd-nat.c: Sort headers.
2513         * amd64-nat.c: Sort headers.
2514         * amd64-linux-tdep.c: Sort headers.
2515         * amd64-linux-nat.c: Sort headers.
2516         * amd64-fbsd-tdep.c: Sort headers.
2517         * amd64-fbsd-nat.c: Sort headers.
2518         * amd64-dicos-tdep.c: Sort headers.
2519         * amd64-darwin-tdep.c: Sort headers.
2520         * amd64-bsd-nat.c: Sort headers.
2521         * alpha-tdep.c: Sort headers.
2522         * alpha-obsd-tdep.c: Sort headers.
2523         * alpha-nbsd-tdep.c: Sort headers.
2524         * alpha-mdebug-tdep.c: Sort headers.
2525         * alpha-linux-tdep.c: Sort headers.
2526         * alpha-linux-nat.c: Sort headers.
2527         * alpha-bsd-tdep.c: Sort headers.
2528         * alpha-bsd-nat.c: Sort headers.
2529         * aix-thread.c: Sort headers.
2530         * agent.c: Sort headers.
2531         * addrmap.c: Sort headers.
2532         * ada-varobj.c: Sort headers.
2533         * ada-valprint.c: Sort headers.
2534         * ada-typeprint.c: Sort headers.
2535         * ada-tasks.c: Sort headers.
2536         * ada-lang.c: Sort headers.
2537         * aarch64-tdep.c: Sort headers.
2538         * aarch64-ravenscar-thread.c: Sort headers.
2539         * aarch64-newlib-tdep.c: Sort headers.
2540         * aarch64-linux-tdep.c: Sort headers.
2541         * aarch64-linux-nat.c: Sort headers.
2542         * aarch64-fbsd-tdep.c: Sort headers.
2543         * aarch64-fbsd-nat.c: Sort headers.
2544         * aarch32-linux-nat.c: Sort headers.
2545
2546 2019-04-04  Tom Tromey  <tom@tromey.com>
2547
2548         * varobj.c (varobj_create): Update.
2549         * rust-exp.y (struct rust_parser) <update_innermost_block,
2550         lookup_symbol>: New methods.
2551         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2552         Rename.
2553         (rust_parser::rust_lookup_type)
2554         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2555         * printcmd.c (display_command, do_one_display): Update.
2556         * parser-defs.h (struct parser_state) <parser_state>: Add
2557         "tracker" parameter.
2558         (block_tracker): New member.
2559         (class innermost_block_tracker) <innermost_block_tracker>: Add
2560         "types" parameter.
2561         <reset>: Remove method.
2562         (innermost_block): Don't declare.
2563         (null_post_parser): Update.
2564         * parse.c (innermost_block): Remove global.
2565         (write_dollar_variable): Update.
2566         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2567         Remove "tracker_types" parameter.
2568         (parse_expression): Add "tracker" parameter.
2569         (parse_expression_for_completion): Update.
2570         (null_post_parser): Add "tracker" parameter.
2571         * p-exp.y: Update rules.
2572         * m2-exp.y: Update rules.
2573         * language.h (struct language_defn) <la_post_parser>: Add
2574         "tracker" parameter.
2575         * go-exp.y: Update rules.
2576         * f-exp.y: Update rules.
2577         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2578         parameter.
2579         * d-exp.y: Update rules.
2580         * c-exp.y: Update rules.
2581         * breakpoint.c (set_breakpoint_condition): Create an
2582         innermost_block_tracker.
2583         (watch_command_1): Likewise.
2584         * ada-lang.c (resolve): Add "tracker" parameter.
2585         (resolve_subexp): Likewise.
2586         * ada-exp.y (write_var_from_sym): Update.
2587
2588 2019-04-04  Tom Tromey  <tom@tromey.com>
2589
2590         * type-stack.h: New file.
2591         * type-stack.c: New file.
2592         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2593         type-stack.h.
2594         (insert_into_type_stack, insert_type, push_type, push_type_int)
2595         (insert_type_address_space, pop_type, pop_type_int)
2596         (pop_typelist, pop_type_stack, append_type_stack)
2597         (push_type_stack, get_type_stack, push_typelist)
2598         (follow_type_instance_flags, follow_types): Don't declare.
2599         * parse.c (type_stack): Remove global.
2600         (parse_exp_in_context): Update.
2601         (insert_into_type_stack, insert_type, push_type, push_type_int)
2602         (insert_type_address_space, pop_type, pop_type_int)
2603         (pop_typelist, pop_type_stack, append_type_stack)
2604         (push_type_stack, get_type_stack, push_typelist)
2605         (follow_type_instance_flags, follow_types): Remove (moved to
2606         type-stack.c).
2607         * f-exp.y (type_stack): New global.
2608         Update rules.
2609         (push_kind_type, f_parse): Update.
2610         * d-exp.y (type_stack): New global.
2611         Update rules.
2612         (d_parse): Update.
2613         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2614         Update rules.
2615         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2616         (HFILES_NO_SRCDIR): Add type-stack.h.
2617
2618 2019-04-04  Tom Tromey  <tom@tromey.com>
2619
2620         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2621         (rust_parser::convert_ast_to_expression, rust_parse)
2622         (rust_lex_test_completion, rust_lex_tests): Update.
2623         * parser-defs.h (struct expr_completion_state): New.
2624         (struct parser_state) <parser_state>: Add completion parameter.
2625         <mark_struct_expression, mark_completion_tag>: New methods.
2626         <parse_completion, m_completion_state>: New members.
2627         (prefixify_expression, null_post_parser): Update.
2628         (mark_struct_expression, mark_completion_tag): Don't declare.
2629         * parse.c (parse_completion, expout_last_struct)
2630         (expout_tag_completion_type, expout_completion_name): Remove
2631         globals.
2632         (parser_state::mark_struct_expression)
2633         (parser_state::mark_completion_tag): Now methods.
2634         (prefixify_expression): Add last_struct parameter.
2635         (prefixify_subexp): Likewise.
2636         (parse_exp_1): Update.
2637         (parse_exp_in_context): Add cstate parameter.  Update.
2638         (parse_expression_for_completion): Create an
2639         expr_completion_state.
2640         (null_post_parser): Add "completion" parameter.
2641         * p-exp.y: Update rules.
2642         (yylex): Update.
2643         * language.h (struct language_defn) <la_post_parser>: Add
2644         "completing" parameter.
2645         * go-exp.y: Update rules.
2646         (lex_one_token): Update.
2647         * expression.h (parse_completion): Don't declare.
2648         * d-exp.y: Update rules.
2649         (lex_one_token): Update rules.
2650         * c-exp.y: Update rules.
2651         (lex_one_token): Update.
2652         * ada-lang.c (resolve): Add "parse_completion" parameter.
2653         (resolve_subexp): Likewise.
2654         (ada_resolve_function): Likewise.
2655
2656 2019-04-04  Tom Tromey  <tom@tromey.com>
2657
2658         * parser-defs.h (struct parser_state) <start_arglist,
2659         end_arglist>: New methods.
2660         <arglist_len, m_funcall_chain>: New members.
2661         (arglist_len, start_arglist, end_arglist): Don't declare.
2662         * parse.c (arglist_len, funcall_chain): Remove global.
2663         (start_arglist, end_arglist): Remove functions.
2664         (parse_exp_in_context): Update.
2665         * p-exp.y: Update rules.
2666         * m2-exp.y: Update rules.
2667         * go-exp.y: Update rules.
2668         * f-exp.y: Update rules.
2669         * d-exp.y: Update rules.
2670         * c-exp.y: Update rules.
2671
2672 2019-04-04  Tom Tromey  <tom@tromey.com>
2673
2674         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2675         lex_operator, push_back>: New methods.
2676         Update all rules.
2677         (rust_parser::lex_hex, lex_escape): Rename and update.
2678         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2679         (rust_parser::lex_operator): Rename and update.
2680         (rust_parser::lex_number, rustyylex, rustyyerror)
2681         (rust_lex_test_init, rust_lex_test_sequence)
2682         (rust_lex_test_push_back, rust_lex_tests): Update.
2683         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2684         parameter.
2685         <lexptr, prev_lexptr>: New members.
2686         (lexptr, prev_lexptr): Don't declare.
2687         * parse.c (lexptr, prev_lexptr): Remove globals.
2688         (parse_exp_in_context): Update.
2689         * p-exp.y (yylex, yyerror): Update.
2690         * m2-exp.y (parse_number, yylex, yyerror): Update.
2691         * go-exp.y (lex_one_token, yyerror): Update.
2692         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2693         * d-exp.y (lex_one_token, yyerror): Update.
2694         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2695         (lex_one_token, yyerror): Update.
2696         * ada-lex.l (YY_INPUT): Update.
2697         (rewind_to_char): Update.
2698         * ada-exp.y (yyerror): Update.
2699
2700 2019-04-04  Tom Tromey  <tom@tromey.com>
2701
2702         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2703         * parser-defs.h (struct parser_state) <parser_state>: Add new
2704         parameter.
2705         <comma_terminates>: New member.
2706         (comma_terminates): Don't declare global.
2707         * parse.c (comma_terminates): Remove global.
2708         (parse_exp_in_context): Update.
2709         * p-exp.y (yylex): Update.
2710         * m2-exp.y (yylex): Update.
2711         * go-exp.y (lex_one_token): Update.
2712         * f-exp.y (yylex): Update.
2713         * d-exp.y (lex_one_token): Update.
2714         * c-exp.y (lex_one_token): Update.
2715         * ada-lex.l: Update.
2716
2717 2019-04-04  Tom Tromey  <tom@tromey.com>
2718
2719         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2720         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2721         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2722         * parser-defs.h (paren_depth): Don't declare.
2723         * parse.c (paren_depth): Remove global.
2724         (parse_exp_in_context): Update.
2725         * p-exp.y (paren_depth): New global.
2726         (pascal_parse): Initialize it.
2727         * m2-exp.y (paren_depth): New global.
2728         (m2_parse): Initialize it.
2729         * go-exp.y (paren_depth): New global.
2730         (go_parse): Initialize it.
2731         * f-exp.y (paren_depth): New global.
2732         (f_parse): Initialize it.
2733         * d-exp.y (paren_depth): New global.
2734         (d_parse): Initialize it.
2735         * c-exp.y (paren_depth): New global.
2736         (c_parse): Initialize it.
2737         * ada-lex.l (paren_depth): New global.
2738         (lexer_init): Initialize it.
2739
2740 2019-04-04  Tom Tromey  <tom@tromey.com>
2741
2742         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2743         (rust_parser::convert_ast_to_type)
2744         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2745         * parser-defs.h (struct parser_state) <parser_state>: Add
2746         parameters.  Initialize new members.
2747         <expression_context_block, expression_context_pc>: New members.
2748         * parse.c (expression_context_block, expression_context_pc):
2749         Remove globals.
2750         (parse_exp_in_context): Update.
2751         * p-exp.y: Update all rules.
2752         (yylex): Update.
2753         * m2-exp.y: Update all rules.
2754         (yylex): Update.
2755         * go-exp.y (yylex): Update.
2756         * f-exp.y (yylex): Update.
2757         * d-exp.y: Update all rules.
2758         (yylex): Update.
2759         * c-exp.y: Update all rules.
2760         (lex_one_token, classify_name, yylex, c_parse): Update.
2761         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2762
2763 2019-04-04  Tom Tromey  <tom@tromey.com>
2764
2765         * gdbarch.h, gdbarch.c: Rebuild.
2766         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2767         * stap-probe.h:
2768         (struct stap_parse_info): Replace "parser_state" with
2769         "expr_builder".
2770         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2771         (parser_state): New class.
2772         * parse.c (expr_builder): Rename.
2773         (expr_builder::release): Rename.
2774         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2775         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2776         (write_exp_elt_longcst, write_exp_elt_floatcst)
2777         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2778         (write_exp_string_vector, write_exp_bitstring)
2779         (write_exp_msymbol, mark_struct_expression)
2780         (write_dollar_variable)
2781         (insert_type_address_space, increase_expout_size): Replace
2782         "parser_state" with "expr_builder".
2783         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2784         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2785         "parser_state" with "expr_builder".
2786
2787 2019-04-04  Tom Tromey  <tom@tromey.com>
2788
2789         * rust-exp.y: Replace "parse_language" with method call.
2790         * p-exp.y:
2791         (yylex): Replace "parse_language" with method call.
2792         * m2-exp.y:
2793         (yylex): Replace "parse_language" with method call.
2794         * go-exp.y (classify_name): Replace "parse_language" with method
2795         call.
2796         * f-exp.y (yylex): Replace "parse_language" with method call.
2797         * d-exp.y (lex_one_token): Replace "parse_language" with method
2798         call.
2799         * c-exp.y:
2800         (lex_one_token, classify_name, yylex): Replace "parse_language"
2801         with method call.
2802         * ada-exp.y (find_primitive_type, type_char)
2803         (type_system_address): Replace "parse_language" with method call.
2804
2805 2019-04-04  Tom Tromey  <tom@tromey.com>
2806
2807         * rust-exp.y: Replace "parse_gdbarch" with method call.
2808         * parse.c (write_dollar_variable, insert_type_address_space):
2809         Replace "parse_gdbarch" with method call.
2810         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2811         call.
2812         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2813         call.
2814         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2815         "parse_gdbarch" with method call.
2816         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2817         with method call.
2818         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2819         "parse_gdbarch" with method call.
2820         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2821         "parse_gdbarch" with method call.
2822         * c-exp.y (parse_type, parse_number, classify_name): Replace
2823         "parse_gdbarch" with method call.
2824         * ada-lex.l: Replace "parse_gdbarch" with method call.
2825         * ada-exp.y (parse_type, find_primitive_type, type_char)
2826         (type_system_address): Replace "parse_gdbarch" with method call.
2827
2828 2019-04-04  Tom Tromey  <tom@tromey.com>
2829
2830         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2831         * stap-probe.c (stap_parse_argument): Update.
2832         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2833         initial_size parameter.
2834         * rust-exp.y (rust_lex_tests): Update.
2835         * parse.c (parser_state): Update.
2836         (parse_exp_in_context): Update.
2837         * parser-defs.h (struct parser_state) <parser_state>: Remove
2838         "initial_size" parameter.
2839
2840 2019-04-04  Tom Tromey  <tom@tromey.com>
2841
2842         * parser-defs.h (increase_expout_size): Don't declare.
2843         * parse.c (increase_expout_size): Now static.
2844
2845 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2846
2847         * gnu-nat.c (gnu_nat_target::wait): Fix
2848         target_waitstatus_to_string call.
2849
2850 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2851
2852         * eval.c (evaluate_subexp_standard): Handle internal functions
2853         during Fortran function call handling.
2854
2855 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2856
2857         * NEWS: Mention new internal functions.
2858         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2859         (read_base_type): Use dwarf2_init_complex_target_type.
2860         * value.c (creal_internal_fn): New function.
2861         (cimag_internal_fn): New function.
2862         (_initialize_values): Register new internal functions.
2863
2864 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2865
2866         * infrun.c (stop_all_threads): If debug_infrun, always
2867         trace the wait status after wait_one, using
2868         target_waitstatus_to_string and target_pid_to_str.
2869         (handle_inferior_event): Replace various trace of
2870         wait status kind by a single trace.
2871         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2872         wait status kind image by target_waitstatus_to_string.
2873         * target/waitstatus.c (target_waitstatus_to_string): Fix
2874         obsolete comment.
2875
2876 2019-04-01  Tom Tromey  <tromey@adacore.com>
2877
2878         PR symtab/23331:
2879         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2880
2881 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2882             Pedro Alves  <palves@redhat.com>
2883
2884         * top.c (quit_force): Call 'finalize_values'.
2885         * value.c (finalize_values): New function.
2886         * value.h (finalize_values): Declare.
2887
2888 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2889
2890         * NEWS: Announce $_gdb_major and $_gdb_minor.
2891
2892         * top.c (init_gdb_version_vars): New function.
2893         (gdb_init): Call init_gdb_version_vars.
2894
2895 2019-03-29  Tom Tromey  <tromey@adacore.com>
2896
2897         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2898         help text.  Remove dead code.
2899
2900 2019-03-29  Keith Seitz  <keiths@redhat.com>
2901
2902         From Siddhesh Poyarekar:
2903         * f-lang.h (f77_get_upperbound): Return LONGEST.
2904         (f77_get_lowerbound): Likewise.
2905         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2906         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2907         print them.
2908         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2909         plongest to format print it.
2910         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2911         (f77_get_upperbound): Likewise.
2912         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2913         LOWER_BOUND to LONGEST.
2914         (f77_create_arrayprint_offset_tbl): Likewise.
2915
2916 2019-03-29  Keith Seitz  <keiths@redhat.com>
2917
2918         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2919         %s/pulongest for TYPE_LENGTH instead of %d in format
2920         strings.
2921         * ada-typerint.c (ada_print_type): Likewise.
2922         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2923         * compile/compile-c-support.c (generate_register_struct): Likewise.
2924         * gdbtypes.c (recursive_dump_type): Likewise.
2925         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2926         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2927         instead of %d in format strings.
2928         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2929         to std::min to ULONGEST.
2930         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2931         instead of %d in format strings.
2932         * tracepoint.c (info_scope_command): Likewise.
2933         * typeprint.c (print_offset_data::update)
2934         (print_offset_data::finish): Likewise.
2935         * xtensa-tdep.c (xtensa_store_return_value)
2936         (xtensa_push_dummy_call): Likewise.
2937
2938 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2939
2940         * windows-nat.c (display_selector): Fixed format specifications
2941         for 64-bit Cygwin.
2942
2943 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2944
2945         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2946
2947 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2948
2949         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2950         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2951         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2952         (nios2_linux_init_abi): Install it.
2953
2954 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2955
2956         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2957
2958 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2959
2960         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2961
2962 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2963             Tom Tromey  <tromey@adacore.com>
2964
2965         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2966
2967 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2968
2969         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2970         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2971         method to compute the bounds of range types. Also print "[evaluated]"
2972         if the bounds' values come from a dynamic evaluation.
2973
2974 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2975
2976         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2977         whitespace when pretty printing is on.
2978
2979 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2980
2981         * ppc-linux-nat.c: Add include.
2982
2983 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2984
2985         * NEWS: Mention AArch64 Pointer Authentication.
2986
2987 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2988
2989         * arm-linux-nat.c: Add include.
2990
2991 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2992
2993         * source-cache.c (source_cache::get_source_lines): Re-read
2994         fullname after calling open_source_file.
2995
2996 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2997
2998         * NEWS: Mention TLS support for FreeBSD.
2999
3000 2019-03-25  Tom Tromey  <tromey@adacore.com>
3001
3002         * minsyms.c (BUNCH_SIZE): Update comment.
3003         (~minimal_symbol_reader): Remove old comment.
3004         (compact_minimal_symbols): Update comment.
3005         (minimal_symbol_reader::install): Remove old comment.  Update
3006         other comments.
3007
3008 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3009
3010         * s390-linux-nat.c: Add include.
3011
3012 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3013
3014         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3015         Call linux_get_hwcap.
3016         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3017         Likewise.
3018         (aarch64_linux_get_hwcap): Remove function.
3019         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
3020         declaration.
3021         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
3022         linux_get_hwcap.
3023         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3024         * linux-tdep.c (linux_get_hwcap): Add function.
3025         (linux_get_hwcap2): Likewise.
3026         * linux-tdep.h (linux_get_hwcap): Add declaration.
3027         (linux_get_hwcap2): Likewise.
3028         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
3029         (ppc_linux_get_hwcap2): Likewise.
3030         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
3031         linux_get_hwcap.
3032         (ppc_linux_nat_target::insert_watchpoint): Likewise.
3033         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
3034         (ppc_linux_nat_target::read_description): Likewise.
3035         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
3036         * s390-linux-nat.c: Likewise.
3037         * s390-linux-tdep.c (s390_core_read_description): Likewise.
3038
3039 2019-03-24  Tom Tromey  <tom@tromey.com>
3040
3041         * ada-lang.c (standard_lookup): Simplify initialization.
3042         (ada_lookup_symbol_nonlocal): Simplify return.
3043         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
3044         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
3045         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
3046         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
3047         initialization.
3048         * solib.c (solib_global_lookup): Simplify.
3049         * symtab.c (null_block_symbol): Remove.
3050         (symbol_cache_lookup): Simplify returns.
3051         (lookup_language_this): Simplify returns.
3052         (lookup_symbol_aux): Simplify return.
3053         (lookup_local_symbol): Simplify returns.
3054         (lookup_global_symbol_from_objfile): Simplify return.
3055         (lookup_symbol_in_objfile_symtabs)
3056         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
3057         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
3058         (lookup_static_symbol, lookup_global_symbol): Simplify return.
3059         * cp-namespace.c (cp_lookup_bare_symbol)
3060         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
3061         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
3062         (cp_lookup_nested_symbol): Don't use null_block_symbol.
3063         (cp_lookup_symbol_via_imports): Simplify initialization.
3064         (find_symbol_in_baseclass): Likewise.
3065         * symtab.h (null_block_symbol): Remove.
3066         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
3067         (d_lookup_nested_symbol, d_lookup_symbol_imports)
3068         (d_lookup_symbol_module): Likewise.
3069         (find_symbol_in_baseclass): Simplify initialization.
3070
3071 2019-03-24  Tom Tromey  <tom@tromey.com>
3072
3073         * expression.h: Don't include symtab.h.
3074         (struct block): Forward declare.
3075
3076 2019-03-24  Tom Tromey  <tom@tromey.com>
3077
3078         * c-exp.y (typebase): Remove casts.
3079         * gdbtypes.c (lookup_unsigned_typename, )
3080         (lookup_signed_typename): Remove cast.
3081         * eval.c (parse_to_comma_and_eval): Remove cast.
3082         * parse.c (write_dollar_variable): Remove cast.
3083         * block.h (struct block) <superblock>: Now const.
3084         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
3085         * psymtab.c (psym_map_matching_symbols): Make "block" const.
3086         (map_block): Make "block" const.
3087         * symfile.h (struct quick_symbol_functions)
3088         <map_matching_symbols>: Constify block argument to "callback".
3089         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
3090         const.
3091         (find_pc_sect_compunit_symtab): Make "b" const.
3092         (find_symbol_at_address): Likewise.
3093         (search_symbols): Likewise.
3094         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
3095         (dw2_debug_names_lookup_symbol): Likewise.
3096         (dw2_map_matching_symbols): Update.
3097         * p-valprint.c (pascal_val_print): Remove "block".
3098         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
3099         (aux_add_nonlocal_symbols): Make "block" const.
3100         (resolve_subexp): Remove cast.
3101         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
3102         const.
3103         (iterate_over_file_blocks): Likewise.
3104         * f-exp.y (%union) <bval>: Remove.
3105         * coffread.c (patch_opaque_types): Make "b" const.
3106         * spu-tdep.c (spu_catch_start): Make "block" const.
3107         * c-valprint.c (print_unpacked_pointer): Remove "block".
3108         * symmisc.c (dump_symtab_1): Make "b" const.
3109         (block_depth): Make "block" const.
3110         * d-exp.y (%union) <bval>: Remove.
3111         * cp-support.h (cp_lookup_rtti_type): Update.
3112         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
3113         * psymtab.c (psym_lookup_symbol): Make "block" const.
3114         (maintenance_check_psymtabs): Make "b" const.
3115         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
3116         (enumerate_locals, enumerate_args): Update.
3117         * python/py-symtab.c (stpy_global_block): Make "block" const.
3118         (stpy_static_block): Likewise.
3119         * inline-frame.c (block_starting_point_at): Make "new_block"
3120         const.
3121         * block.c (find_block_in_blockvector): Make return type const.
3122         (blockvector_for_pc_sect): Make "b" const.
3123         (find_block_in_blockvector): Make "b" const.
3124
3125 2019-03-23  Tom Tromey  <tom@tromey.com>
3126
3127         * varobj.c (varobj_create): Update.
3128         * symfile.c (clear_symtab_users): Don't reset innermost_block.
3129         * printcmd.c (display_command, do_one_display): Don't reset
3130         innermost_block.
3131         * parser-defs.h (enum innermost_block_tracker_type): Move to
3132         expression.h.
3133         (innermost_block): Update comment.
3134         * parse.c (parse_exp_1): Add tracker_types parameter.
3135         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
3136         tracker_types parameter.  Reset innermost_block.
3137         (parse_exp_in_context): Remove.
3138         (parse_expression_for_completion): Update.
3139         * objfiles.c (~objfile): Don't reset expression_context_block or
3140         innermost_block.
3141         * expression.h (enum innermost_block_tracker_type): Move from
3142         parser-defs.h.
3143         (parse_exp_1): Add tracker_types parameter.
3144         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
3145         reset innermost_block.
3146
3147 2019-03-23  Tom Tromey  <tom@tromey.com>
3148
3149         * objfiles.h: Include bcache.h.
3150
3151 2019-03-23  Tom Tromey  <tom@tromey.com>
3152
3153         * linespec.c (get_current_search_block): Use
3154         scoped_restore_current_language.
3155         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
3156
3157 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3158             Jiong Wang  <jiong.wang@arm.com>
3159
3160         * aarch64-linux-tdep.c
3161         (aarch64_linux_iterate_over_regset_sections): Check for pauth
3162         section.
3163         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
3164
3165 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3166             Jiong Wang  <jiong.wang@arm.com>
3167
3168         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
3169         instructions.
3170         (aarch64_analyze_prologue_test): Add PACIASP test.
3171         (aarch64_prologue_prev_register): Unmask PC value.
3172
3173 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3174             Jiong Wang  <jiong.wang@arm.com>
3175
3176         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
3177         (aarch64_dwarf2_prev_register): Unmask PC value.
3178         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
3179         (aarch64_execute_dwarf_cfa_vendor_op): Check for
3180         DW_CFA_AARCH64_negate_ra_state.
3181         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
3182
3183 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3184             Jiong Wang  <jiong.wang@arm.com>
3185
3186         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
3187         registers.
3188         (aarch64_pseudo_register_name): Likewise.
3189         (aarch64_pseudo_register_type): Likewise.
3190         (aarch64_pseudo_register_reggroup_p): Likewise.
3191         (aarch64_gdbarch_init): Add pauth registers.
3192         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
3193         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
3194         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
3195         (struct gdbarch_tdep): Add regnum for ra_state.
3196
3197 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3198             Jiong Wang  <jiong.wang@arm.com>
3199
3200         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
3201
3202 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3203             Jiong Wang  <jiong.wang@arm.com>
3204
3205         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
3206         function.
3207         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
3208         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
3209         (aarch64_gdbarch_init): Add puth registers.
3210         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
3211         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
3212         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
3213
3214 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3215             Jiong Wang  <jiong.wang@arm.com>
3216
3217         * aarch64-linux-nat.c
3218         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
3219         * aarch64-linux-tdep.c
3220         (aarch64_linux_core_read_description): Likewise.
3221         (aarch64_linux_get_hwcap): New function.
3222         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
3223         (aarch64_linux_get_hwcap): New declaration.
3224
3225 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3226             Jiong Wang  <jiong.wang@arm.com>
3227
3228         * aarch64-linux-nat.c
3229         (aarch64_linux_nat_target::read_description): Add pauth param.
3230         * aarch64-linux-tdep.c
3231         (aarch64_linux_core_read_description): Likewise.
3232         * aarch64-tdep.c (struct target_desc): Add in pauth.
3233         (aarch64_read_description): Add pauth param.
3234         (aarch64_gdbarch_init): Likewise.
3235         * aarch64-tdep.h (aarch64_read_description): Likewise.
3236         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3237         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3238         * features/Makefile: Add new files.
3239         * features/aarch64-pauth.c: New file.
3240         * features/aarch64-pauth.xml: New file.
3241
3242 2019-03-20  Tom Tromey  <tromey@adacore.com>
3243
3244         * infrun.c (handle_inferior_event): Rename from
3245         handle_inferior_event_1.  Create a scoped_value_mark.
3246         (handle_inferior_event): Remove.
3247
3248 2019-03-19  Tom Tromey  <tromey@adacore.com>
3249
3250         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3251         * infrun.h (print_stop_event): Add "displays" parameter.
3252         * infrun.c (print_stop_event): Add "displays" parameter.
3253
3254 2019-03-19  Pedro Alves  <palves@redhat.com>
3255
3256         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3257         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3258         to -1.  Fix TABs vs spaces.
3259         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3260         * tui/tui-out.h (tui_ui_out) Add intro comments.
3261         <m_line, m_start_of_line>: In-class initialize, and add describing
3262         comment.
3263
3264 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3265
3266         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3267         variable names.
3268         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3269
3270 2019-03-18  Pedro Alves  <palves@redhat.com>
3271             Eli Zaretskii <eliz@gnu.org>
3272
3273         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3274         m_line and m_start_of_line.
3275
3276 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3277
3278         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3279         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3280         it returns a newline.  This fixes a regression in TU mode, whereby
3281         the next line is output on the same screen line as the user input.
3282
3283 2019-03-18  Tom Tromey  <tromey@adacore.com>
3284
3285         * minsyms.c (minimal_symbol_reader::install): Remove call to
3286         obstack_blank.
3287
3288 2019-03-18  Pedro Alves  <palves@redhat.com>
3289
3290         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3291         New globals.
3292         (apply_style): New, factored out from ...
3293         (apply_ansi_escape): ... this.  Handle reverse video mode.
3294         (tui_set_reverse_mode): New function.
3295         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3296         * tui/tui-winsource.c (tui_show_source_line): Use
3297         tui_set_reverse_mode instead of setting A_STANDOUT.
3298         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3299         New setter methods.
3300
3301 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3302
3303         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3304         Handle tabs.
3305
3306 2019-03-18  Tom Tromey  <tromey@adacore.com>
3307
3308         * ada-lang.c (empty_array): Add "high" parameter.
3309         (ada_evaluate_subexp): Update.
3310
3311 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3312
3313         * unittests/string_view-selftests.c: Define
3314         _initialize_string_view_selftests unconditionally.
3315
3316 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3317
3318         PR gdb/24350
3319         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3320
3321 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3322
3323         PR gdb/24351
3324         * windows-nat.c (display_selector): Fix format specifiers.
3325
3326 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3327
3328         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3329         tui_refill_source_window instead of tui_refresh_win, to update the
3330         current execution line.  This fixes redisplay of the current line
3331         when stepping through the code with "next" or "step".
3332
3333 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3334
3335         * source-cache.c (source_cache::get_source_lines): Call
3336         find_source_lines to initialize s->nlines.  This fixes vertical
3337         scrolling of TUI source window when the DOWN arrow is pressed.
3338
3339 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3340
3341         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3342         linux-thread-db.c (_initialize_thread_db): Likewise.
3343
3344 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3345
3346         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3347         wclrtoeol in tui_show_source_line".  This reverts changes made in
3348         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3349
3350 2019-03-15  Tom Tromey  <tom@tromey.com>
3351
3352         * symtab.h (struct minimal_symbol): Derive from
3353         general_symbol_info.
3354         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3355         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3356         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3357         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3358         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3359         (MSYMBOL_SEARCH_NAME): Update.
3360         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3361         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3362         * minsyms.c (minimal_symbol_reader::record_full): Update.
3363
3364 2019-03-15  Tom Tromey  <tom@tromey.com>
3365
3366         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3367
3368 2019-03-15  Tom Tromey  <tom@tromey.com>
3369
3370         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3371         unique_xmalloc_ptr.
3372         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3373         Update.
3374         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3375         (build_minimal_symbol_hash_tables)
3376         (minimal_symbol_reader::install): Update.
3377
3378 2019-03-15  Tom Tromey  <tom@tromey.com>
3379
3380         * symtab.c (create_demangled_names_hash): Update.
3381         (symbol_set_names): Update.
3382         * objfiles.h (struct objfile_per_bfd_storage)
3383         <demangled_names_hash>: Now an htab_up.
3384         * objfiles.c (objfile_per_bfd_storage): Simplify.
3385
3386 2019-03-15  Tom Tromey  <tom@tromey.com>
3387
3388         * objfiles.h (struct objfile_per_bfd_storage): Declare
3389         destructor.
3390         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3391         New.
3392         (get_objfile_bfd_data): Use new.  Don't initialize
3393         language_of_main.
3394         (free_objfile_per_bfd_storage): Remove.
3395         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3396
3397 2019-03-15  Tom Tromey  <tom@tromey.com>
3398
3399         * symfile.c (reread_symbols): Update.
3400         * objfiles.c (objfile::objfile): Update.
3401         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3402         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3403         comment.
3404         (minimal_symbol_reader::install): Update.
3405         (terminate_minimal_symbol_table): Remove.
3406         * jit.c (jit_object_close_impl): Update.
3407
3408 2019-03-15  Tom Tromey  <tom@tromey.com>
3409
3410         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3411         initializations.
3412
3413 2019-03-15  Tom Tromey  <tom@tromey.com>
3414
3415         * objfiles.h (struct objfile_per_bfd_storage)
3416         <demangled_hash_languages>: Now a bitset.
3417         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3418         (lookup_minimal_symbol): Update.
3419
3420 2019-03-15  Tom Tromey  <tom@tromey.com>
3421
3422         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3423         Don't return the symbol.
3424         * coffread.c (record_minimal_symbol): Use record_full.
3425
3426 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3427
3428         The MS-Windows port of ncurses fails to switch to a color pair if
3429         one or both of the colors are the implicit default colors.  This
3430         change records the default colors when TUI is initialized, and
3431         then specifies them explicitly when a color pair uses the default
3432         colors.  This allows color styling in TUI mode on MS-Windows.
3433
3434         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3435         ncurses_norm_attr.
3436         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3437         colors in ncurses_norm_attr.
3438         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3439         "none", replace it with the default color recorded in
3440         ncurses_norm_attr.
3441
3442 2019-03-14  Tom Tromey  <tromey@adacore.com>
3443
3444         * source-cache.h (class source_cache) <get_source_lines>: Return
3445         std::string.
3446         * source-cache.c (source_cache::extract_lines): Handle case where
3447         first_pos==npos.  Return std::string.
3448         (source_cache::get_source_lines): Update.
3449
3450 2019-03-14  Tom Tromey  <tromey@adacore.com>
3451
3452         * NEWS: Add item for "style sources" commands.
3453         * source-cache.c (source_cache::get_source_lines): Check
3454         source_styling.
3455         * cli/cli-style.c (source_styling): New global.
3456         (_initialize_cli_style): Add "style sources" commands.
3457         (show_style_sources): New function.
3458         * cli/cli-style.h (source_styling): Declare.
3459
3460 2019-03-14  Pedro Alves  <palves@redhat.com>
3461             Tom Tromey  <tromey@adacore.com>
3462
3463         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3464         * tui/tui-winsource.c (tui_refill_source_window): New function,
3465         from...
3466         (tui_horizontal_source_scroll): ... here.  Move some logic.
3467         * cli/cli-style.c (set_style_enabled): Notify new observable.
3468         * tui/tui-hooks.c (tui_redisplay_source): New function.
3469         (tui_attach_detach_observers): Attach or detach
3470         tui_redisplay_source.
3471         * observable.h (source_styling_changed): New observable.
3472         * observable.c: Define source_styling_changed observable.
3473
3474 2019-03-13  Tom Tromey  <tromey@adacore.com>
3475
3476         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3477         (i386_gnu_nat_target::store_registers): Update.
3478         * target-debug.h (target_debug_print_std_string): New macro.
3479         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3480         * windows-tdep.c (display_one_tib): Update.
3481         * tui/tui-stack.c (tui_make_status_line): Update.
3482         * top.c (print_inferior_quit_action): Update.
3483         * thread.c (thr_try_catch_cmd): Update.
3484         (add_thread_with_info): Update.
3485         (thread_target_id_str): Update.
3486         (thr_try_catch_cmd): Update.
3487         (thread_command): Update.
3488         (thread_find_command): Update.
3489         * record-btrace.c (record_btrace_target::info_record)
3490         (record_btrace_resume_thread, record_btrace_target::resume)
3491         (record_btrace_cancel_resume, record_btrace_step_thread)
3492         (record_btrace_target::wait, record_btrace_target::wait)
3493         (record_btrace_target::wait, record_btrace_target::stop): Update.
3494         * progspace.c (print_program_space): Update.
3495         * process-stratum-target.c
3496         (process_stratum_target::thread_address_space): Update.
3497         * linux-fork.c (linux_fork_mourn_inferior)
3498         (detach_checkpoint_command, info_checkpoints_command)
3499         (linux_fork_context): Update.
3500         (linux_fork_detach): Update.
3501         (class scoped_switch_fork_info): Update.
3502         (delete_checkpoint_command): Update.
3503         * infrun.c (follow_fork_inferior): Update.
3504         (follow_fork_inferior): Update.
3505         (proceed_after_vfork_done): Update.
3506         (handle_vfork_child_exec_or_exit): Update.
3507         (follow_exec): Update.
3508         (displaced_step_prepare_throw): Update.
3509         (displaced_step_restore): Update.
3510         (start_step_over): Update.
3511         (resume_1): Update.
3512         (clear_proceed_status_thread): Update.
3513         (proceed): Update.
3514         (print_target_wait_results): Update.
3515         (do_target_wait): Update.
3516         (context_switch): Update.
3517         (stop_all_threads): Update.
3518         (restart_threads): Update.
3519         (finish_step_over): Update.
3520         (handle_signal_stop): Update.
3521         (switch_back_to_stepped_thread): Update.
3522         (keep_going_pass_signal): Update.
3523         (print_exited_reason): Update.
3524         (normal_stop): Update.
3525         * inferior.c (inferior_pid_to_str): Change return type.
3526         (print_selected_inferior): Update.
3527         (add_inferior): Update.
3528         (detach_inferior): Update.
3529         * dummy-frame.c (fprint_dummy_frames): Update.
3530         * dcache.c (dcache_info_1): Update.
3531         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3532         (btrace_fetch, btrace_clear): Update.
3533         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3534         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3535         type.
3536         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3537         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3538         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3539         * gdbarch.c, gdbarch.h: Rebuild.
3540         * gdbarch.sh (core_pid_to_str): Change return type.
3541         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3542         return type.
3543         (windows_nat_target::pid_to_str): Change return type.
3544         (windows_delete_thread): Update.
3545         (windows_nat_target::attach): Update.
3546         (windows_nat_target::files_info): Update.
3547         * target-delegates.c: Rebuild.
3548         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3549         return type.
3550         (sol_thread_target::pid_to_str): Change return type.
3551         * remote.c (class remote_target) <pid_to_str>: Change return
3552         type.
3553         (remote_target::pid_to_str): Change return type.
3554         (extended_remote_target::attach, remote_target::remote_stop_ns)
3555         (remote_target::remote_notif_remove_queued_reply)
3556         (remote_target::push_stop_reply, remote_target::disable_btrace):
3557         Update.
3558         (extended_remote_target::attach): Update.
3559         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3560         type.
3561         (gdbsim_target::pid_to_str): Change return type.
3562         * ravenscar-thread.c (struct ravenscar_thread_target)
3563         <pid_to_str>: Change return type.
3564         (ravenscar_thread_target::pid_to_str): Change return type.
3565         * procfs.c (class procfs_target) <pid_to_str>: Change return
3566         type.
3567         (procfs_target::pid_to_str): Change return type.
3568         (procfs_target::attach): Update.
3569         (procfs_target::detach): Update.
3570         (procfs_target::fetch_registers): Update.
3571         (procfs_target::store_registers): Update.
3572         (procfs_target::wait): Update.
3573         (procfs_target::files_info): Update.
3574         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3575         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3576         return type.
3577         (nto_procfs_target::pid_to_str): Change return type.
3578         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3579         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3580         return type.
3581         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3582         (exit_lwp): Update.
3583         (attach_proc_task_lwp_callback, get_detach_signal)
3584         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3585         (linux_nat_target::resume, wait_lwp, stop_callback)
3586         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3587         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3588         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3589         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3590         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3591         type.
3592         (inf_ptrace_target::attach): Update.
3593         (inf_ptrace_target::files_info): Update.
3594         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3595         type.
3596         (go32_nat_target::pid_to_str): Change return type.
3597         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3598         (gnu_nat_target::wait): Update.
3599         (gnu_nat_target::wait): Update.
3600         (gnu_nat_target::resume): Update.
3601         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3602         (fbsd_nat_target::wait): Update.
3603         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3604         type.
3605         (darwin_nat_target::attach): Update.
3606         * corelow.c (class core_target) <pid_to_str>: Change return type.
3607         (core_target::pid_to_str): Change return type.
3608         * target.c (normal_pid_to_str): Change return type.
3609         (default_pid_to_str): Likewise.
3610         (target_pid_to_str): Change return type.
3611         (target_translate_tls_address): Update.
3612         (target_announce_detach): Update.
3613         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3614         return type.
3615         (bsd_uthread_target::pid_to_str): Change return type.
3616         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3617         type.
3618         (bsd_kvm_target::pid_to_str): Change return type.
3619         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3620         return type.
3621         (aix_thread_target::pid_to_str): Change return type.
3622         * target.h (struct target_ops) <pid_to_str>: Change return type.
3623         (target_pid_to_str, normal_pid_to_str): Likewise.
3624         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3625         type.
3626         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3627         type.
3628         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3629         return type.
3630         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3631         type.
3632         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3633         type.
3634         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3635         return type.
3636
3637 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3638
3639         * NEWS: Mention that the new default MI version is 3.  Mention
3640         changes to the output of commands and events that deal with
3641         multi-location breakpoints.
3642         * breakpoint.c: Include "mi/mi-out.h".
3643         (print_one_breakpoint): Change output syntax if using MI version
3644         >= 3.
3645         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3646         New.
3647         (mi_multi_location_breakpoint_output_fixed): New.
3648         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3649         (mi_cmd_fix_multi_location_breakpoint_output): New.
3650         (mi_multi_location_breakpoint_output_fixed): New.
3651         * mi/mi-cmds.c (mi_cmds): Register command
3652         -fix-multi-location-breakpoint-output.
3653         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3654         interpreter "mi".
3655
3656 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3657
3658         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3659         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3660         instantiate mi_ui_out based on interpreter name.
3661         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3662         * mi/mi-main.c (mi_load_progress): Likewise.
3663
3664 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3665
3666         * NEWS: Combine separate "New targets" sections for 8.3.
3667
3668 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3669
3670         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3671         (ppcfbsd_init_abi): Install gdbarch
3672         "fetch_tls_load_module_address" and "get_thread_local_address"
3673         methods.
3674
3675 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3676
3677         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3678         (riscv_fbsd_init_abi): Install gdbarch
3679         "fetch_tls_load_module_address" and "get_thread_local_address"
3680         methods.
3681
3682 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3683
3684         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3685         (i386fbsd_init_abi): Install gdbarch
3686         "fetch_tls_load_module_address" and "get_thread_local_address"
3687         methods.
3688
3689 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3690
3691         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3692         (amd64fbsd_init_abi): Install gdbarch
3693         "fetch_tls_load_module_address" and "get_thread_local_address"
3694         methods.
3695
3696 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3697
3698         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3699         (struct fbsd_pspace_data): New type.
3700         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3701         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3702         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3703         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3704         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3705
3706 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3707
3708         * gdbtypes.c (lookup_struct_elt): New function.
3709         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3710         * gdbtypes.h (struct struct_elt): New type.
3711         (lookup_struct_elt): New prototype.
3712
3713 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3714
3715         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3716         remove disabled code block.
3717
3718 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3719
3720         * gdbarch.sh (get_thread_local_address): New method.
3721         * gdbarch.h, gdbarch.c: Regenerate.
3722         * target.c (target_translate_tls_address): Use
3723         gdbarch_get_thread_local_address if present instead of
3724         target::get_thread_local_address.
3725
3726 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3727
3728         * target.h (target::get_thread_local_address): Update comment.
3729
3730 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3731
3732         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3733         objfile->separate_debug_objfile_backlink if not NULL.
3734
3735 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3736
3737         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3738         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3739         (amd64bsd_store_inferior_registers): Likewise.
3740         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3741         Enable segment base registers.
3742         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3743         PT_GETFSBASE and PT_GETGSBASE.
3744         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3745         PT_SETGSBASE.
3746         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3747         segment base registers.
3748         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3749
3750 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3751
3752         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3753         Update calls to i386_target_description to add 'segments'
3754         parameter.
3755         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3756         add segment base registers.
3757         * arch/i386.c (i386_create_target_description): Add 'segments'
3758         parameter to enable segment base registers.
3759         * arch/i386.h (i386_create_target_description): Likewise.
3760         * features/i386/32bit-segments.xml: New file.
3761         * features/i386/32bit-segments.c: Generate.
3762         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3763         call to i386_target_description to add 'segments' parameter.
3764         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3765         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3766         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3767         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3768         if feature is present.
3769         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3770         Add 'segments' parameter to call to i386_target_description.
3771         (i386_target_description): Add 'segments' parameter to enable
3772         segment base registers.
3773         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3774         to call to i386_target_description.
3775         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3776         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3777         Define I386_NUM_REGS.
3778         (i386_target_description): Add 'segments' parameter to enable
3779         segment base registers.
3780
3781 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3782
3783         PR/24325
3784         * source-cache.c: #undef open and close, to avoid unresolved
3785         externals during linking.
3786
3787 2019-03-12  Tom Tromey  <tromey@adacore.com>
3788
3789         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3790         const.  Add initializers.
3791         (_initialize_remote): Don't initialize ptid globals.
3792
3793 2019-03-12  Pedro Alves  <palves@redhat.com>
3794
3795         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3796
3797 2019-03-12  Pedro Alves  <palves@redhat.com>
3798
3799         * cp-name-parser.y (main): Remove unused 'len' variable.
3800
3801 2019-03-12  Tom Tromey  <tromey@adacore.com>
3802
3803         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3804         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3805
3806 2019-03-12  Tom Tromey  <tromey@adacore.com>
3807
3808         * linux-nat.c (iterate_over_lwps): Update.
3809         (stop_callback): Remove parameter.
3810         (stop_wait_callback, detach_callback, resume_set_callback)
3811         (select_singlestep_lwp_callback, set_ignore_sigint)
3812         (status_callback, resumed_callback, resume_clear_callback)
3813         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3814         data parameter.
3815         (linux_nat_target::detach, linux_nat_target::resume)
3816         (linux_stop_and_wait_all_lwps, select_event_lwp)
3817         (linux_nat_filter_event, linux_nat_wait_1)
3818         (linux_nat_target::kill, linux_nat_target::stop)
3819         (linux_nat_target::stop): Update.
3820         (linux_nat_resume_callback): Change type.
3821         (resume_stopped_resumed_lwps, count_events_callback)
3822         (select_event_lwp_callback): Likewise.
3823         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3824         * arm-linux-nat.c (struct update_registers_data): Remove.
3825         (update_registers_callback): Change type.
3826         (arm_linux_insert_hw_breakpoint1): Update.
3827         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3828         parameter.
3829         (x86_linux_dr_set_addr): Update.
3830         (x86_linux_dr_set_control): Update.
3831         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3832         (iterate_over_lwps): Use gdb::function_view.
3833         * nat/aarch64-linux-hw-point.c (struct
3834         aarch64_dr_update_callback_param): Remove.
3835         (debug_reg_change_callback): Change type.
3836         (aarch64_notify_debug_reg_change): Update.
3837         * s390-linux-nat.c (s390_refresh_per_info): Update.
3838
3839 2019-03-11  Tom Tromey  <tromey@adacore.com>
3840
3841         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3842         redundant assignment to "this_cu".
3843
3844 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3845
3846         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3847
3848 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3849
3850         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3851         from...
3852         (rank_one_type): ... this.
3853
3854 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3855
3856         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3857         from...
3858         (rank_one_type): ... this.
3859
3860 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3861
3862         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3863         from...
3864         (rank_one_type): ... this.
3865
3866 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3867
3868         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3869         from...
3870         (rank_one_type): ... this.
3871
3872 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3873
3874         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3875         from...
3876         (rank_one_type): ... this.
3877
3878 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3879
3880         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3881         from...
3882         (rank_one_type): ... this.
3883
3884 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3885
3886         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3887         from...
3888         (rank_one_type): ... this.
3889
3890 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3891
3892         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3893         from...
3894         (rank_one_type): ... this.
3895
3896 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3897
3898         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3899         from...
3900         (rank_one_type): ... this.
3901
3902 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3903
3904         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3905         from...
3906         (rank_one_type): ... this.
3907
3908 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3909
3910         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3911         from...
3912         (rank_one_type): ... this.
3913
3914 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3915
3916         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3917         from...
3918         (rank_one_type): ... this.
3919
3920 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3921
3922         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3923         inferior-events' shows the example events.
3924
3925 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3926
3927         Support styling on native MS-Windows console
3928
3929         PR/24315
3930         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3931         on MS-Windows if $TERM is not defined.
3932
3933         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3934
3935         * posix-hdep.c (gdb_console_fputs):
3936         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3937         functions.
3938         * ui-file.h (gdb_console_fputs): Add prototype.
3939
3940         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3941         back to fputs only if the former returns zero.
3942
3943 2019-03-07  Tom Tromey  <tom@tromey.com>
3944
3945         * symmisc.c (print_symbol_bcache_statistics): Update.
3946         (print_objfile_statistics): Update.
3947         * symfile.c (allocate_symtab): Update.
3948         * stabsread.c: Don't include bcache.h.
3949         * psymtab.h (struct psymbol_bcache): Don't declare.
3950         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3951         (psymbol_bcache_init, psymbol_bcache_free)
3952         (psymbol_bcache_get_bcache): Don't declare.
3953         * psymtab.c (struct psymbol_bcache): Remove.
3954         (psymtab_storage::psymtab_storage): Update.
3955         (psymtab_storage::~psymtab_storage): Update.
3956         (psymbol_bcache_init, psymbol_bcache_free)
3957         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3958         (add_psymbol_to_bcache): Update.
3959         (allocate_psymtab): Update.
3960         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3961         macro_cache>: No longer pointers.
3962         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3963         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3964         * macrotab.c (macro_bcache): Update.
3965         * macroexp.c: Don't include bcache.h.
3966         * gdbtypes.c (check_types_worklist): Update.
3967         (types_deeply_equal): Remove TRY/CATCH.  Update.
3968         * elfread.c (elf_symtab_read): Update.
3969         * dwarf2read.c: Don't include bcache.h.
3970         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3971         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3972         (print_bcache_statistics, bcache_memory_used): Don't declare.
3973         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3974         methods.  Rename all data members.
3975         * bcache.c (struct bcache): Move to bcache.h.
3976         (bcache::expand_hash_table): Rename from expand_hash_table.
3977         (bcache): Remove.
3978         (bcache::insert): Rename from bcache_full.
3979         (bcache::compare): Rename from bcache_compare.
3980         (bcache_xmalloc): Remove.
3981         (bcache::~bcache): Rename from bcache_xfree.
3982         (bcache::print_statistics): Rename from print_bcache_statistics.
3983         (bcache::memory_used): Rename from bcache_memory_used.
3984
3985 2019-03-07  Pedro Alves  <palves@redhat.com>
3986
3987         * infrun.c (normal_stop): Also check for
3988         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3989
3990 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3991
3992         * f-lang.c (value_from_host_double): Moved to...
3993         * value.c (value_from_host_double): ...here.
3994         * value.h (value_from_host_double): Declare.
3995         * guile/scm-math.c (vlscm_convert_typed_number): Use
3996         value_from_host_double.
3997         (vlscm_convert_number): Likewise.
3998         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3999         * python/py-value.c (convert_value_from_python): Likewise.
4000
4001 2019-03-06  Tom Tromey  <tom@tromey.com>
4002
4003         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
4004
4005 2019-03-06  Tom Tromey  <tom@tromey.com>
4006
4007         * utils.h (free_current_contents): Don't declare.
4008         * utils.c (free_current_contents): Remove.
4009
4010 2019-03-06  Tom Tromey  <tom@tromey.com>
4011
4012         * top.c (quit_force): Update.
4013         * main.c (captured_command_loop): Update.
4014         * common/new-op.c (operator new): Update.
4015         * common/common-exceptions.c (struct catcher)
4016         <save_cleanup_chain>: Remove member.
4017         (exceptions_state_mc_init): Update.
4018         (exception_try_scope_entry): Return nullptr.
4019         (exception_try_scope_exit, exception_rethrow)
4020         (throw_exception_sjlj, throw_exception_cxx): Update.
4021         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
4022         (all_cleanups, do_cleanups, discard_cleanups)
4023         (discard_final_cleanups, save_cleanups, save_final_cleanups)
4024         (restore_cleanups, restore_final_cleanups): Don't declare.
4025         (do_final_cleanups): Remove parameter.
4026         * common/cleanups.c (cleanup_chain, make_cleanup)
4027         (make_cleanup_dtor, all_cleanups, do_cleanups)
4028         (discard_my_cleanups, discard_cleanups)
4029         (discard_final_cleanups, save_my_cleanups, save_cleanups)
4030         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
4031         (null_cleanup): Remove.
4032         (do_final_cleanups): Remove parameter.
4033
4034 2019-03-06  Tom Tromey  <tom@tromey.com>
4035
4036         * remote.c (remote_target::remote_parse_stop_reply): Use
4037         unique_xmalloc_ptr.
4038
4039 2019-03-06  Tom Tromey  <tom@tromey.com>
4040
4041         * stabsread.c (struct stabs_field_info): Rename from field_info.
4042         <list, fnlist>: Add initializers.
4043         <obstack>: New member.
4044         (read_member_functions, read_struct_fields, read_baseclasses):
4045         Allocate on obstack.  Don't use cleanups.
4046         (read_one_struct_field, read_member_functions, read_struct_fields)
4047         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
4048         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
4049         (read_struct_type): Update.
4050
4051 2019-03-06  Tom Tromey  <tom@tromey.com>
4052
4053         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
4054         * common/filestuff.h (make_cleanup_close): Don't declare.
4055         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
4056         Remove.
4057
4058 2019-03-06  Tom Tromey  <tom@tromey.com>
4059
4060         * solib-aix.c: Use make_scope_exit.
4061
4062 2019-03-06  Tom Tromey  <tom@tromey.com>
4063
4064         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
4065         Use make_scope_exit.
4066
4067 2019-03-06  Tom Tromey  <tom@tromey.com>
4068
4069         * solib-svr4.c (disable_probes_interface): Remove parameter.
4070         (svr4_handle_solib_event): Use make_scope_exit.
4071
4072 2019-03-06  Tom Tromey  <tom@tromey.com>
4073
4074         * remote.c (struct stop_reply_deleter): Remove.
4075         (stop_reply_up): Update.
4076         (struct stop_reply): Derive from notif_event.  Don't typedef.
4077         <regcache>: Now a std::vector.
4078         (stop_reply_xfree): Remove.
4079         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
4080         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
4081         (remote_target::discard_pending_stop_replies): Use delete.
4082         (remote_target::remote_parse_stop_reply): Update.
4083         (remote_target::process_stop_reply): Update.
4084         * remote-notif.h (struct notif_event): Add virtual destructor.
4085         Remove "dtr" member.
4086         (struct notif_client) <alloc_event>: Return a unique_ptr.
4087         (notif_event_xfree): Don't declare.
4088         (notif_event_up): New typedef.
4089         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
4090         (notif_event_xfree, do_notif_event_xfree): Remove.
4091         (remote_notif_state_xfree): Update.
4092
4093 2019-03-06  Tom Tromey  <tom@tromey.com>
4094
4095         * infrun.c (displaced_step_clear_cleanup): Now a
4096         forward_scope_exit type.
4097         (displaced_step_prepare_throw): Update.
4098         (displaced_step_fixup): Update.
4099
4100 2019-03-06  Tom Tromey  <tom@tromey.com>
4101
4102         * inferior.h (class inferior): Update comment.
4103         * gdbthread.h (class thread_info): Update comment.
4104
4105 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
4106             Tom Tromey  <tom@tromey.com>
4107
4108         * stabsread.h (struct stab_section_list): Remove.
4109         (coffstab_build_psymtabs): Update.
4110         * dbxread.c (symbuf_sections): Now a std::vector.
4111         (sect_idx): New global.
4112         (fill_symbuf): Update.
4113         (coffstab_build_psymtabs): Change type of stabsects parameter.
4114         Update.
4115         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
4116         std::vector.
4117         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
4118         (coff_locate_sections): Update.
4119         (coff_symfile_read): Remove cleanups.  Update.
4120         (init_stringtab): Add storage parameter.
4121         (free_stringtab, free_stringtab_cleanup): Remove.
4122         (init_lineno): Add storage parameter.
4123         (free_linetab, free_linetab_cleanup): Remove.
4124
4125 2019-03-06  Pedro Alves  <palves@redhat.com>
4126
4127         * linux-fork.c (fork_info::clobber_regs): Delete.
4128         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
4129         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
4130         comment.  Adjust.
4131         (scoped_switch_fork_info::scoped_switch_fork_info)
4132         (checkpoint_command, linux_fork_context): Adjust
4133         fork_save_infrun_state calls.
4134
4135 2019-03-06  Pedro Alves  <palves@redhat.com>
4136
4137         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
4138         (inf_has_multiple_threads): Return 'bool' and rewrite using
4139         inferior_info::threads().
4140
4141 2019-03-06  Pedro Alves  <palves@redhat.com>
4142
4143         * linux-fork.c: Include <list>.
4144         (fork_list): Now a std::list instance.
4145         (fork_info): Add ctor, dtor, and in-class initialize all fields.
4146         (forks_exist_p, find_last_fork): Adjust.
4147         (new_fork): Delete.
4148         (one_fork_p): New.
4149         (add_fork): Adjust.
4150         (free_fork): Delete, folded into fork_info::~fork_info().
4151         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
4152         Adjust.
4153         (init_fork_list): Delete.
4154         (linux_fork_killall, linux_fork_mourn_inferior)
4155         (linux_fork_detach, info_checkpoints_command): Adjust.
4156         (_initialize_linux_fork): No longer call init_fork_list.
4157
4158 2019-03-06  Pedro Alves  <palves@redhat.com>
4159
4160         * linux-fork.c (new_fork): New, split out of ...
4161         (add_fork): ... this.  Return void.  Move "first fork" special
4162         case from here, to ...
4163         (checkpoint_command): ... here.
4164         * linux-linux.h (add_fork): Return void.
4165
4166 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4167
4168         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
4169
4170 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4171             Chris January  <chris.january@arm.com>
4172             David Lecomber  <david.lecomber@arm.com>
4173
4174         * f-exp.y: New token, UNOP_INTRINSIC.
4175         (exp): New pattern using UNOP_INTRINSIC token.
4176         (f77_keywords): Add 'abs' keyword.
4177         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
4178         (value_from_host_double): New function.
4179         (evaluate_subexp_f): Support UNOP_ABS.
4180
4181 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4182
4183         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
4184         types.
4185
4186 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4187
4188         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
4189         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
4190         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
4191
4192 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4193
4194         * f-exp.y (convert_to_kind_type): Handle more type kinds.
4195
4196 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4197             Chris January  <chris.january@arm.com>
4198
4199         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
4200         * f-exp.y: Define 'KIND' token.
4201         (exp): New pattern for KIND expressions.
4202         (ptype): Handle types with a kind extension.
4203         (direct_abs_decl): Extend to spot kind extensions.
4204         (f77_keywords): Add 'kind' to the list.
4205         (push_kind_type): New function.
4206         (convert_to_kind_type): New function.
4207         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
4208         * parse.c (operator_length_standard): Likewise.
4209         * parser-defs.h (enum type_pieces): Add tp_kind.
4210         * std-operator.def: Add UNOP_KIND.
4211
4212 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4213
4214         * f-exp.y (f_parse): Set yydebug.
4215
4216 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4217
4218         * f-lang.c (evaluate_subexp_f): New function.
4219         (exp_descriptor_f): New global.
4220         (f_language_defn): Use exp_descriptor_f instead of
4221         exp_descriptor_standard.
4222
4223 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4224
4225         * f-exp.y (struct token): Add comments.
4226         (dot_ops): Remove uppercase versions and the end marker.
4227         (f77_keywords): Likewise.
4228         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
4229         entries in the dot_ops array are case insensitive, and use
4230         strncasecmp to compare strings.  Also some whitespace cleanup in
4231         this area.  Similar for the f77_keywords array, except entries in
4232         this list might be case sensitive.
4233
4234 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4235
4236         * f-exp.y (struct f77_boolean_val): Add comments.
4237         (boolean_values): Remove uppercase versions, and end marker.
4238         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
4239         and use strncasecmp to achieve case insensitivity.  Additionally,
4240         perform whitespace cleanup around this code.
4241
4242 2019-03-06  Tom Tromey  <tromey@adacore.com>
4243
4244         * remote-sim.c (gdbsim_target_open): Use result of
4245         gdb_argv::release.
4246
4247 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4248         Dirk Schubert  <dirk.schubert@arm.com>
4249         Chris January  <chris.january@arm.com>
4250
4251         * eval.c (evaluate_subexp_standard): Call Fortran argument
4252         wrapping logic.
4253         * f-lang.c (struct value): A value which can be passed into a
4254         Fortran function call.
4255         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4256         where appropriate.
4257         (struct type): Value ready for a Fortran function call.
4258         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4259         is needed.
4260         * f-lang.h (fortran_argument_convert): Declaration.
4261         (fortran_preserve_arg_pointer): Declaration.
4262         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4263
4264 2019-03-05  Tom Tromey  <tromey@adacore.com>
4265
4266         * python/py-prettyprint.c (print_string_repr): Remove #if.
4267         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4268
4269 2019-03-05  Tom Tromey  <tromey@adacore.com>
4270
4271         * target.c (the_dummy_target): Move later.  Change type to
4272         "dummy_target".
4273         (initialize_targets): Don't initialize the_dummy_target.
4274
4275 2019-03-05  Tom Tromey  <tromey@adacore.com>
4276
4277         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4278         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4279
4280 2019-03-05  Tom Tromey  <tromey@adacore.com>
4281
4282         * windows-nat.c (windows_nat_target::attach)
4283         (windows_nat_target::detach): Don't call gdb_flush.
4284         * valprint.c (generic_val_print, val_print, val_print_string):
4285         Don't call gdb_flush.
4286         * utils.c (defaulted_query): Don't call gdb_flush.
4287         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4288         * target.c (target_announce_detach): Don't call gdb_flush.
4289         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4290         * remote.c (extended_remote_target::attach): Don't call
4291         gdb_flush.
4292         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4293         * printcmd.c (do_examine): Don't call gdb_flush.
4294         (info_display_command): Don't call gdb_flush.
4295         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4296         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4297         * memattr.c (info_mem_command): Don't call gdb_flush.
4298         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4299         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4300         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4301         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4302         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4303         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4304         (gnu_nat_target::detach): Don't call gdb_flush.
4305         * f-valprint.c (f_val_print): Don't call gdb_flush.
4306         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4307         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4308         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4309         gdb_flush.
4310         * c-valprint.c (c_val_print): Don't call gdb_flush.
4311         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4312
4313 2019-03-05  Tom Tromey  <tromey@adacore.com>
4314
4315         * varobj.c (update_dynamic_varobj_children): Update.
4316         (install_default_visualizer): Use reset, not release.
4317         * value.c (set_internalvar): Update.
4318         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4319         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4320         ATTRIBUTE_UNUSED_RESULT.
4321
4322 2019-03-05  Tom Tromey  <tromey@adacore.com>
4323
4324         * remote.c (class scoped_remote_fd) <release>: Add
4325         ATTRIBUTE_UNUSED_RESULT.
4326
4327 2019-03-05  Tom Tromey  <tromey@adacore.com>
4328
4329         * macroexp.c (struct macro_buffer) <release>: Add
4330         ATTRIBUTE_UNUSED_RESULT.
4331
4332 2019-03-05  Tom Tromey  <tromey@adacore.com>
4333
4334         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4335         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4336         ATTRIBUTE_UNUSED_RESULT.
4337
4338 2019-03-05  Tom Tromey  <tromey@adacore.com>
4339
4340         * common/scoped_fd.h (class scoped_fd) <release>: Add
4341         ATTRIBUTE_UNUSED_RESULT.
4342
4343 2019-03-05  Tom Tromey  <tromey@adacore.com>
4344
4345         * parser-defs.h (struct parser_state) <release>: Add
4346         ATTRIBUTE_UNUSED_RESULT.
4347
4348 2019-03-05  Tom Tromey  <tromey@adacore.com>
4349
4350         * utils.h (class gdb_argv) <release>: Add
4351         ATTRIBUTE_UNUSED_RESULT.
4352         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4353
4354 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4355
4356         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4357         for-loop range, to avoid compiler warnings.
4358
4359         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4360         avoid compiler warnings about unused variables.
4361
4362         * NEWS: Mention end of support for native debugging on MS-Windows
4363         before XP.
4364
4365         PR gdb/24292
4366         * common/netstuff.c:
4367         * gdbserver/gdbreplay.c
4368         * gdbserver/remote-utils.c:
4369         * ser-tcp.c:
4370         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4371         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4372         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4373         'getaddrinfo' and 'freeaddrinfo' were not available before
4374         Windows XP, and mingw.org's MinGW headers by default define
4375         _WIN32_WINNT to 0x500.
4376
4377 2019-03-01  Gary Benson <gbenson@redhat.com>
4378
4379         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4380
4381 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4382             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4383
4384         PR gdb/8527
4385         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4386         set_sigint_trap, clear_sigint_trap.
4387
4388 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4389
4390         * target.c (target_detach): Clear the regcache and the
4391         frame cache.
4392
4393 2019-02-27  Pedro Alves  <palves@redhat.com>
4394
4395         * utils.c (set_screen_size): When we cap the height/width sizes,
4396         tweak the corresponding command variable to show "unlimited":
4397
4398 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4399             Pedro Alves  <palves@redhat.com>
4400
4401         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4402         before calling rl_set_screen_size.
4403
4404 2019-02-27  Tom Tromey  <tromey@adacore.com>
4405
4406         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4407         define.
4408         * python/py-value.c: Remove Python 2.4 workaround.
4409         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4410         workaround.
4411         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4412         Python 2.4 workaround.
4413         * python/python-internal.h: Remove Python 2.4 comment.
4414         (Py_ssize_t): Don't define.
4415         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4416         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4417         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4418         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4419         * python/python.c (do_start_initialization): Remove Python 2.4
4420         workaround.
4421         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4422         (print_children): Remove Python 2.4 workaround.
4423         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4424         workaround.
4425         (CHARBUFFERPROC_NAME): Remove.
4426         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4427         Python 2.4 workaround.
4428
4429 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4430
4431         * NEWS: Note minimum Python version.
4432
4433 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4434
4435         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4436         code from these functions.  Remove corresponding ifdefs.  Use
4437         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4438         Remove gotos and target of gotos.
4439         (infpy_search_memory): Likewise.
4440
4441 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4442
4443         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4444         (hppa_gdbarch_init): Don't register deleted functions with
4445         gdbarch.
4446
4447 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4448
4449         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4450         (h8300_unwind_sp): Delete.
4451         (h8300_dummy_id): Delete.
4452         (h8300_gdbarch_init): Don't register deleted functions with
4453         gdbarch.
4454
4455 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4456
4457         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4458         (ft32_unwind_pc): Delete.
4459         (ft32_unwind_sp): Delete.
4460         (ft32_gdbarch_init): Don't register deleted functions with
4461         gdbarch.
4462
4463 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4464
4465         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4466         (frv_unwind_pc): Delete.
4467         (frv_unwind_sp): Delete.
4468         (frv_gdbarch_init): Don't register deleted functions with
4469         gdbarch.
4470
4471 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4472
4473         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4474         (riscv_unwind_pc): Delete.
4475         (riscv_unwind_sp): Delete.
4476         (riscv_gdbarch_init): Don't register deleted functions with
4477         gdbarch.
4478
4479 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4480
4481         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4482         (csky_unwind_pc): Delete.
4483         (csky_unwind_sp): Delete.
4484         (csky_gdbarch_init): Don't register deleted functions with
4485         gdbarch.
4486
4487 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4488
4489         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4490         (cris_unwind_pc): Delete.
4491         (cris_unwind_sp): Delete.
4492         (cris_gdbarch_init): Don't register deleted functions with
4493         gdbarch.
4494
4495 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4496
4497         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4498         (bfin_unwind_pc): Delete.
4499         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4500
4501 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4502
4503         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4504         (arm_unwind_pc): Delete.
4505         (arm_unwind_sp): Delete.
4506         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4507
4508 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4509
4510         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4511         (arc_unwind_pc): Delete.
4512         (arc_unwind_sp): Delete.
4513         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4514
4515 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4516
4517         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4518         (alpha_unwind_pc): Delete.
4519         (alpha_gdbarch_init): Don't register deleted functions with
4520         gdbarch.
4521
4522 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4523
4524         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4525         (aarch64_unwind_pc): Delete.
4526         (aarch64_unwind_sp): Delete.
4527         (aarch64_gdbarch_init): Don't register deleted functions with
4528         gdbarch.
4529
4530 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4531
4532         * gdbtypes.c (type_align): Don't consider static members when
4533         computing structure alignment.
4534
4535 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4536
4537         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4538         return 0 for other types.
4539         * arch-utils.c (default_type_align): Always return 0.
4540         * gdbarch.h: Regenerate.
4541         * gdbarch.sh (type_align): Extend comment.
4542         * gdbtypes.c (type_align): Add additional comments, always call
4543         gdbarch_type_align before applying the default rules.
4544         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4545         generic code will then apply a suitable default.
4546         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4547         types, return 0 for other types.
4548
4549 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4550
4551         * NEWS: Create a new section for the next release branch.
4552         Rename the section of the current branch, now that it has
4553         been cut.
4554
4555 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4556
4557         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4558         * version.in: Bump version to 8.3.50.DATE-git.
4559
4560 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4561
4562         * aix-thread.c (ptid_cmp): Remove unused variable.
4563         (get_signaled_thread): Likewise.
4564         (store_regs_user_thread): Likewise.
4565         (store_regs_kernel_thread): Likewise.
4566         (fetch_regs_kernel_thread): Remove shadowed variable.
4567
4568 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4569
4570         * features/riscv/32bit-cpu.xml: Add register numbers.
4571         * features/riscv/32bit-fpu.c: Regenerate.
4572         * features/riscv/32bit-fpu.xml: Add register numbers.
4573         * features/riscv/64bit-cpu.xml: Add register numbers.
4574         * features/riscv/64bit-fpu.c: Regenerate.
4575         * features/riscv/64bit-fpu.xml: Add register numbers.
4576
4577 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4578
4579         * NEWS: Mention two argument form of gdb.Value constructor.
4580         * python/py-value.c (convert_buffer_and_type_to_value): New
4581         function.
4582         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4583         Add support for handling an optional second argument.  Call
4584         convert_buffer_and_type_to_value as appropriate.
4585         * python/python-internal.h (Py_buffer_deleter): New struct.
4586         (Py_buffer_up): New typedef.
4587
4588 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4589
4590         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4591         instead of releasing ownership.
4592
4593 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4594
4595         * dwarf2read.c (open_and_init_dwp_file): Call
4596         elf_numsections instead of bfd_count_sections to initialize
4597         dwp_file->num_sections.
4598
4599 2019-02-25  Tom Tromey  <tromey@adacore.com>
4600
4601         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4602
4603 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4604
4605         * gcore.in: Add '--readnever' option when invoking GDB.
4606
4607 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4608
4609         * MAINTAINERS: Update my email address.
4610
4611 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4612
4613         * build-id.c (build_id_to_debug_bfd_1): New function.
4614         (build_id_to_debug_bfd): Look for separate debug file in
4615         sysroot.
4616
4617 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4618
4619         * gdbarch.sh: Update the copyright year range that is placed into
4620         generated files.
4621
4622 2019-02-22  Keith Seitz  <keiths@redhat.com>
4623
4624         PR symtab/23853
4625         * linespec.c (create_sals_line_offset): Search for the default
4626         symtab's filename instead of its fullname.
4627
4628 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4629
4630         * NEWS: Update style defaults.
4631
4632 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4633
4634         * main.c (captured_main_1): Disable styling in batch mode.
4635
4636 2019-02-20  Tom Tromey  <tom@tromey.com>
4637
4638         * symtab.c (symtab_symbol_info): Fix typos.
4639
4640 2019-02-20  Tom Tromey  <tromey@adacore.com>
4641
4642         * findcmd.c (_initialize_mem_search): Use upper case for
4643         metasyntactic variables.
4644
4645 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4646
4647         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4648         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4649
4650 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4651
4652         * top.h (source_file_name): Change to std::string.
4653         * top.c (source_file_name): Likewise.
4654         (command_line_input): Adjust.
4655         * cli/cli-script.c (script_from_file): Adjust.
4656
4657 2019-02-19  Tom Tromey  <tromey@adacore.com>
4658
4659         * ravenscar-thread.c
4660         (ravenscar_thread_target::update_thread_list): Don't call
4661         ada_build_task_list.
4662         * ada-lang.h (ada_build_task_list): Don't declare.
4663         * ada-tasks.c (struct ada_tasks_inferior_data)
4664         <task_list_valid_p>: Now bool.
4665         (read_known_tasks, ada_task_list_changed)
4666         (ada_tasks_invalidate_inferior_data): Update.
4667         (read_known_tasks_array): Return bool.
4668         (read_known_tasks_list): Likewise.
4669         (read_known_tasks): Return void.
4670         (ada_build_task_list): Now static.
4671
4672 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4673
4674         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4675         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4676
4677 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4678
4679         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4680         variant for ada_tasks_pspace_data_handle and
4681         ada_tasks_inferior_data_handle.
4682         (ada_tasks_pspace_data_cleanup): New function.
4683         (ada_tasks_inferior_data_cleanup): New function.
4684
4685 2019-02-17  Tom Tromey  <tom@tromey.com>
4686
4687         * macrotab.h (macro_source_fullname): Return a std::string.
4688         * macrotab.c (macro_include, check_for_redefinition)
4689         (macro_undef, macro_lookup_definition, foreach_macro)
4690         (foreach_macro_in_scope): Update.
4691         (macro_source_fullname): Return a std::string.
4692         * macrocmd.c (show_pp_source_pos): Update.
4693
4694 2019-02-17  Tom Tromey  <tom@tromey.com>
4695
4696         * macrocmd.c (show_pp_source_pos): Style the file names.
4697
4698 2019-02-17  Tom Tromey  <tom@tromey.com>
4699
4700         PR tui/24197:
4701         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4702
4703 2019-02-17  Tom Tromey  <tom@tromey.com>
4704
4705         * ada-lang.c (user_select_syms): Use filtered printing.
4706         * utils.c (wrap_style): New global.
4707         (desired_style): Remove.
4708         (emit_style_escape): Add stream parameter.
4709         (set_output_style, reset_terminal_style, prompt_for_continue):
4710         Update.
4711         (flush_wrap_buffer): Only flush gdb_stdout.
4712         (wrap_here): Set wrap_style.
4713         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4714         treat escape sequences as a character.  Change when wrap buffer is
4715         flushed.
4716         (fputs_styled): Do not set the output style when the default is
4717         requested.
4718         * ui-style.h (struct ui_file_style) <is_default>: New method.
4719         * source.c (print_source_lines_base): Emit escape sequences in one
4720         piece.
4721
4722 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4723
4724         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4725         integers and enumeration types.
4726
4727 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4728
4729         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4730         instead of lookup_symbol_in_language
4731         (do_exact_match): New function.
4732         (ada_get_symbol_name_matcher): Return do_exact_match when
4733         doing a verbatim match.
4734
4735 2019-02-15  Tom Tromey  <tromey@adacore.com>
4736
4737         * ravenscar-thread.c (ravenscar_thread_target::resume)
4738         (ravenscar_thread_target::wait): Special case wildcard requests.
4739
4740 2019-02-15  Tom Tromey  <tromey@adacore.com>
4741
4742         * ravenscar-thread.c (base_ptid): Remove.
4743         (struct ravenscar_thread_target) <close>: New method.
4744         <m_base_ptid>: New member.
4745         <update_inferior_ptid, active_task, task_is_currently_active,
4746         runtime_initialized>: Declare methods.
4747         <ravenscar_thread_target>: Add constructor.
4748         (ravenscar_thread_target::task_is_currently_active)
4749         (ravenscar_thread_target::update_inferior_ptid)
4750         (ravenscar_runtime_initialized): Rename.  Now methods.
4751         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4752         (ravenscar_thread_target::update_thread_list): Update.
4753         (ravenscar_thread_target::active_task): Now method.
4754         (ravenscar_thread_target::store_registers)
4755         (ravenscar_thread_target::prepare_to_store)
4756         (ravenscar_thread_target::prepare_to_store)
4757         (ravenscar_thread_target::mourn_inferior): Update.
4758         (ravenscar_inferior_created): Use "new" to create target.
4759         (ravenscar_thread_target::get_ada_task_ptid): Update.
4760         (_initialize_ravenscar): Don't initialize base_ptid.
4761         (ravenscar_ops): Remove global.
4762
4763 2019-02-15  Tom Tromey  <tromey@adacore.com>
4764
4765         * target.h (push_target): Declare new overload.
4766         * target.c (push_target): New overload, taking an rvalue reference.
4767         * remote.c (remote_target::open_1): Use push_target overload.
4768         * corelow.c (core_target_open): Use push_target overload.
4769
4770 2019-02-15  Tom Tromey  <tromey@adacore.com>
4771
4772         * ravenscar-thread.c (is_ravenscar_task)
4773         (ravenscar_task_is_currently_active): Return bool.
4774         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4775         (_initialize_ravenscar): Remove "(void)".
4776         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4777         Return bool.
4778
4779 2019-02-15  Tom Tromey  <tromey@adacore.com>
4780
4781         * ravenscar-thread.c (ravenscar_runtime_initializer)
4782         (has_ravenscar_runtime, get_running_thread_id)
4783         (ravenscar_thread_target::resume): Fix indentation.
4784
4785 2019-02-15  Tom Tromey  <tromey@adacore.com>
4786
4787         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4788         from ravenscar_arch_ops.
4789         (sparc_ravenscar_ops::fetch_registers)
4790         (sparc_ravenscar_ops::store_registers): Now methods.
4791         (sparc_ravenscar_prepare_to_store): Remove.
4792         (sparc_ravenscar_ops): Redefine.
4793         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4794         methods and destructor.  Remove members.
4795         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4796         (ravenscar_thread_target::store_registers)
4797         (ravenscar_thread_target::prepare_to_store): Update.
4798         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4799         Remove.
4800         (struct ppc_ravenscar_powerpc_ops): Derive from
4801         ravenscar_arch_ops.
4802         (ppc_ravenscar_powerpc_ops::fetch_registers)
4803         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4804         (ppc_ravenscar_powerpc_ops): Redefine.
4805         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4806         (ppc_ravenscar_e500_ops::fetch_registers)
4807         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4808         (ppc_ravenscar_e500_ops): Redefine.
4809         * aarch64-ravenscar-thread.c
4810         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4811         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4812         (aarch64_ravenscar_fetch_registers)
4813         (aarch64_ravenscar_store_registers): Now methods.
4814         (aarch64_ravenscar_ops): Redefine.
4815
4816 2019-02-15  Tom Tromey  <tromey@adacore.com>
4817
4818         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4819         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4820         (ravenscar_thread_target::stopped_by_watchpoint)
4821         (ravenscar_thread_target::stopped_data_address)
4822         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4823
4824 2019-02-15  Tom Tromey  <tromey@adacore.com>
4825
4826         * ravenscar-thread.c: Fix some typos.
4827
4828 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4829             Tom Tromey  <tromey@adacore.com>
4830
4831         * ada-lang.c (ada_exception_sal): Change addr_string to a
4832         std::string.
4833         (create_ada_exception_catchpoint): Update.
4834
4835 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4836             Tom Tromey  <tromey@adacore.com>
4837
4838         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4839         (bp_location_ops): Remove.
4840         (base_breakpoint_allocate_location): Update.
4841         (free_bp_location): Update.
4842         * ada-lang.c (class ada_catchpoint_location)
4843         <ada_catchpoint_location>: Remove ops parameter.
4844         (ada_catchpoint_location_dtor): Remove.
4845         (ada_catchpoint_location_ops): Remove.
4846         (allocate_location_exception): Update.
4847         * breakpoint.h (struct bp_location_ops): Remove.
4848         (class bp_location) <bp_location>: Remove bp_location_ops
4849         parameter.
4850         <~bp_location>: Add destructor.
4851         <ops>: Remove.
4852
4853 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4854             Pedro Alves  <palves@redhat.com>
4855
4856         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4857         'PATH_MAX'.
4858
4859 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4860             Samuel Thibault  <samuel.thibault@gnu.org>
4861             Thomas Schwinge  <thomas@codesourcery.com>
4862
4863         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4864         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4865
4866 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4867
4868         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4869         (check_empty): Use "const char *".
4870
4871         * gnu-nat.c (gnu_nat_target::detach): Instead of
4872         'detach_inferior (pid)' call
4873         'detach_inferior (find_inferior_pid (pid))'.
4874
4875         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4876         'nat/fork-inferior.o'.
4877         * gnu-nat.c: #include "nat/fork-inferior.h".
4878
4879         * gnu-nat.c (gnu_nat_target::detach): Instead of
4880         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4881         * gnu-nat.h: #include "inf-child.h".
4882         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4883         'i386_gnu_nat_target::fetch_registers'.
4884         (gnu_store_registers): Rename/move to
4885         'i386_gnu_nat_target::store_registers'.
4886
4887         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4888         * gnu-nat.h (mach_thread_info): New function.
4889         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4890
4891         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4892
4893 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4894
4895         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4896
4897 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4898
4899         * windows-nat.c (windows_add_thread): Add new parameter
4900         "main_thread_p" with default value set to false.  Update
4901         function documentation as well as all callers.
4902         (windows_delete_thread): Likewise.
4903         (fake_create_process): Update call to windows_add_thread.
4904         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4905         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4906         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4907         call to windows_delete_thread.
4908
4909 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4910
4911         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4912
4913 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4914
4915         * symfile.c (find_separate_debug_file): Use canonical path of
4916         sysroot with child_path instead of gdb_sysroot if it is valid.
4917
4918 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4919
4920         * symfile.c (find_separate_debug_file): Use child_path to
4921         determine if an object file is under a sysroot.
4922
4923 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4924
4925         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4926         unittests/child-path-selftests.c.
4927         * common/pathstuff.c (child_path): New function.
4928         * common/pathstuff.h (child_path): New prototype.
4929         * unittests/child-path-selftests.c: New file.
4930
4931 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4932
4933         * symfile.c (find_separate_debug_file): Look for separate debug
4934         files in debug directories under the sysroot.
4935
4936 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4937
4938         * symtab.h (struct minimal_symbol data_p): New const method.
4939         (struct minimal_symbol text_p): Likewise.
4940         * symtab.c (output_source_filename): Use file name style
4941         to print file name.
4942         (print_symbol_info): Likewise.
4943         (print_msymbol_info): Use address style to print addresses.
4944         Use function name style to print executable text symbols.
4945         (expand_symtab_containing_pc): Use data_p.
4946         (find_pc_sect_compunit_symtab): Likewise.
4947
4948 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4949
4950         * breakpoint.c (describe_other_breakpoints): Use address style
4951         to print addresses.
4952         (say_where): Likewise.
4953
4954 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4955
4956         * ada-typeprint.c (print_func_type): Print function name
4957         style to print function name.
4958         * c-typeprint.c (c_print_type_1): Likewise.
4959
4960 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4961
4962         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4963         for execve.
4964
4965 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4966
4967         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4968         type_stack.
4969
4970 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4971
4972         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4973         TYPE_CODE_REF types.
4974
4975 2019-02-08  Jim Wilson  <jimw@sifive.com>
4976
4977         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4978         (riscv_linux_fregset): New.
4979         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4980
4981 2019-02-07  Tom Tromey  <tom@tromey.com>
4982
4983         * thread.c (thread_cancel_execution_command): Update.
4984         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4985         methods.
4986         (struct thread_fsm_ops): Remove.
4987         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4988         (thread_fsm_should_stop, thread_fsm_return_value)
4989         (thread_fsm_set_finished, thread_fsm_finished_p)
4990         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4991         Don't declare.
4992         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4993         * infrun.c (clear_proceed_status_thread)
4994         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4995         (print_stop_event): Update.
4996         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4997         Add constructor.
4998         (step_command_fsm_ops): Remove.
4999         (new_step_command_fsm): Remove.
5000         (step_1): Update.
5001         (step_command_fsm::should_stop): Rename from
5002         step_command_fsm_should_stop.
5003         (step_command_fsm::clean_up): Rename from
5004         step_command_fsm_clean_up.
5005         (step_command_fsm::do_async_reply_reason): Rename from
5006         step_command_fsm_async_reply_reason.
5007         (struct until_next_fsm): Inherit from thread_fsm.  Add
5008         constructor.
5009         (until_next_fsm_ops): Remove.
5010         (new_until_next_fsm): Remove.
5011         (until_next_fsm::should_stop): Rename from
5012         until_next_fsm_should_stop.
5013         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
5014         (until_next_fsm::do_async_reply_reason): Rename from
5015         until_next_fsm_async_reply_reason.
5016         (struct finish_command_fsm): Inherit from thread_fsm.  Add
5017         constructor.  Change type of breakpoint.
5018         (finish_command_fsm_ops): Remove.
5019         (new_finish_command_fsm): Remove.
5020         (finish_command_fsm::should_stop): Rename from
5021         finish_command_fsm_should_stop.
5022         (finish_command_fsm::clean_up): Rename from
5023         finish_command_fsm_clean_up.
5024         (finish_command_fsm::return_value): Rename from
5025         finish_command_fsm_return_value.
5026         (finish_command_fsm::do_async_reply_reason): Rename from
5027         finish_command_fsm_async_reply_reason.
5028         (finish_command): Update.
5029         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
5030         Add constructor.
5031         (call_thread_fsm_ops): Remove.
5032         (call_thread_fsm::call_thread_fsm): Rename from
5033         new_call_thread_fsm.
5034         (call_thread_fsm::should_stop): Rename from
5035         call_thread_fsm_should_stop.
5036         (call_thread_fsm::should_notify_stop): Rename from
5037         call_thread_fsm_should_notify_stop.
5038         (run_inferior_call, call_function_by_hand_dummy): Update.
5039         * cli/cli-interp.c (should_print_stop_to_console): Update.
5040         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
5041         Add constructor.  Change type of location_breakpoint,
5042         caller_breakpoint.
5043         (until_break_fsm_ops): Remove.
5044         (new_until_break_fsm): Remove.
5045         (until_break_fsm::should_stop): Rename from
5046         until_break_fsm_should_stop.
5047         (until_break_fsm::clean_up): Rename from
5048         until_break_fsm_clean_up.
5049         (until_break_fsm::do_async_reply_reason): Rename from
5050         until_break_fsm_async_reply_reason.
5051         (until_break_command): Update.
5052         * thread-fsm.c: Remove.
5053         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
5054
5055 2019-02-07  Tom Tromey  <tom@tromey.com>
5056
5057         * yy-remap.h: Add include guard.
5058         * xtensa-tdep.h: Add include guard.
5059         * xcoffread.h: Rename include guard.
5060         * varobj-iter.h: Add include guard.
5061         * tui/tui.h: Rename include guard.
5062         * tui/tui-winsource.h: Rename include guard.
5063         * tui/tui-wingeneral.h: Rename include guard.
5064         * tui/tui-windata.h: Rename include guard.
5065         * tui/tui-win.h: Rename include guard.
5066         * tui/tui-stack.h: Rename include guard.
5067         * tui/tui-source.h: Rename include guard.
5068         * tui/tui-regs.h: Rename include guard.
5069         * tui/tui-out.h: Rename include guard.
5070         * tui/tui-layout.h: Rename include guard.
5071         * tui/tui-io.h: Rename include guard.
5072         * tui/tui-hooks.h: Rename include guard.
5073         * tui/tui-file.h: Rename include guard.
5074         * tui/tui-disasm.h: Rename include guard.
5075         * tui/tui-data.h: Rename include guard.
5076         * tui/tui-command.h: Rename include guard.
5077         * tic6x-tdep.h: Add include guard.
5078         * target/waitstatus.h: Rename include guard.
5079         * target/wait.h: Rename include guard.
5080         * target/target.h: Rename include guard.
5081         * target/resume.h: Rename include guard.
5082         * target-float.h: Rename include guard.
5083         * stabsread.h: Add include guard.
5084         * rs6000-tdep.h: Add include guard.
5085         * riscv-fbsd-tdep.h: Add include guard.
5086         * regformats/regdef.h: Rename include guard.
5087         * record.h: Rename include guard.
5088         * python/python.h: Rename include guard.
5089         * python/python-internal.h: Rename include guard.
5090         * python/py-stopevent.h: Rename include guard.
5091         * python/py-ref.h: Rename include guard.
5092         * python/py-record.h: Rename include guard.
5093         * python/py-record-full.h: Rename include guard.
5094         * python/py-record-btrace.h: Rename include guard.
5095         * python/py-instruction.h: Rename include guard.
5096         * python/py-events.h: Rename include guard.
5097         * python/py-event.h: Rename include guard.
5098         * procfs.h: Add include guard.
5099         * proc-utils.h: Add include guard.
5100         * p-lang.h: Add include guard.
5101         * or1k-tdep.h: Rename include guard.
5102         * observable.h: Rename include guard.
5103         * nto-tdep.h: Rename include guard.
5104         * nat/x86-linux.h: Rename include guard.
5105         * nat/x86-linux-dregs.h: Rename include guard.
5106         * nat/x86-gcc-cpuid.h: Add include guard.
5107         * nat/x86-dregs.h: Rename include guard.
5108         * nat/x86-cpuid.h: Rename include guard.
5109         * nat/ppc-linux.h: Rename include guard.
5110         * nat/mips-linux-watch.h: Rename include guard.
5111         * nat/linux-waitpid.h: Rename include guard.
5112         * nat/linux-ptrace.h: Rename include guard.
5113         * nat/linux-procfs.h: Rename include guard.
5114         * nat/linux-osdata.h: Rename include guard.
5115         * nat/linux-nat.h: Rename include guard.
5116         * nat/linux-namespaces.h: Rename include guard.
5117         * nat/linux-btrace.h: Rename include guard.
5118         * nat/glibc_thread_db.h: Rename include guard.
5119         * nat/gdb_thread_db.h: Rename include guard.
5120         * nat/gdb_ptrace.h: Rename include guard.
5121         * nat/fork-inferior.h: Rename include guard.
5122         * nat/amd64-linux-siginfo.h: Rename include guard.
5123         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
5124         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
5125         * nat/aarch64-linux.h: Rename include guard.
5126         * nat/aarch64-linux-hw-point.h: Rename include guard.
5127         * mn10300-tdep.h: Add include guard.
5128         * mips-linux-tdep.h: Add include guard.
5129         * mi/mi-parse.h: Rename include guard.
5130         * mi/mi-out.h: Rename include guard.
5131         * mi/mi-main.h: Rename include guard.
5132         * mi/mi-interp.h: Rename include guard.
5133         * mi/mi-getopt.h: Rename include guard.
5134         * mi/mi-console.h: Rename include guard.
5135         * mi/mi-common.h: Rename include guard.
5136         * mi/mi-cmds.h: Rename include guard.
5137         * mi/mi-cmd-break.h: Rename include guard.
5138         * m2-lang.h: Add include guard.
5139         * location.h: Rename include guard.
5140         * linux-record.h: Rename include guard.
5141         * linux-nat.h: Add include guard.
5142         * linux-fork.h: Add include guard.
5143         * i386-darwin-tdep.h: Rename include guard.
5144         * hppa-linux-offsets.h: Add include guard.
5145         * guile/guile.h: Rename include guard.
5146         * guile/guile-internal.h: Rename include guard.
5147         * gnu-nat.h: Rename include guard.
5148         * gdb-stabs.h: Rename include guard.
5149         * frv-tdep.h: Add include guard.
5150         * f-lang.h: Add include guard.
5151         * event-loop.h: Add include guard.
5152         * darwin-nat.h: Rename include guard.
5153         * cp-abi.h: Rename include guard.
5154         * config/sparc/nm-sol2.h: Rename include guard.
5155         * config/nm-nto.h: Rename include guard.
5156         * config/nm-linux.h: Add include guard.
5157         * config/i386/nm-i386gnu.h: Rename include guard.
5158         * config/djgpp/nl_types.h: Rename include guard.
5159         * config/djgpp/langinfo.h: Rename include guard.
5160         * compile/gcc-cp-plugin.h: Add include guard.
5161         * compile/gcc-c-plugin.h: Add include guard.
5162         * compile/compile.h: Rename include guard.
5163         * compile/compile-object-run.h: Rename include guard.
5164         * compile/compile-object-load.h: Rename include guard.
5165         * compile/compile-internal.h: Rename include guard.
5166         * compile/compile-cplus.h: Rename include guard.
5167         * compile/compile-c.h: Rename include guard.
5168         * common/xml-utils.h: Rename include guard.
5169         * common/x86-xstate.h: Rename include guard.
5170         * common/version.h: Rename include guard.
5171         * common/vec.h: Rename include guard.
5172         * common/tdesc.h: Rename include guard.
5173         * common/selftest.h: Rename include guard.
5174         * common/scoped_restore.h: Rename include guard.
5175         * common/scoped_mmap.h: Rename include guard.
5176         * common/scoped_fd.h: Rename include guard.
5177         * common/safe-iterator.h: Rename include guard.
5178         * common/run-time-clock.h: Rename include guard.
5179         * common/refcounted-object.h: Rename include guard.
5180         * common/queue.h: Rename include guard.
5181         * common/ptid.h: Rename include guard.
5182         * common/print-utils.h: Rename include guard.
5183         * common/preprocessor.h: Rename include guard.
5184         * common/pathstuff.h: Rename include guard.
5185         * common/observable.h: Rename include guard.
5186         * common/netstuff.h: Rename include guard.
5187         * common/job-control.h: Rename include guard.
5188         * common/host-defs.h: Rename include guard.
5189         * common/gdb_wait.h: Rename include guard.
5190         * common/gdb_vecs.h: Rename include guard.
5191         * common/gdb_unlinker.h: Rename include guard.
5192         * common/gdb_unique_ptr.h: Rename include guard.
5193         * common/gdb_tilde_expand.h: Rename include guard.
5194         * common/gdb_sys_time.h: Rename include guard.
5195         * common/gdb_string_view.h: Rename include guard.
5196         * common/gdb_splay_tree.h: Rename include guard.
5197         * common/gdb_setjmp.h: Rename include guard.
5198         * common/gdb_ref_ptr.h: Rename include guard.
5199         * common/gdb_optional.h: Rename include guard.
5200         * common/gdb_locale.h: Rename include guard.
5201         * common/gdb_assert.h: Rename include guard.
5202         * common/filtered-iterator.h: Rename include guard.
5203         * common/filestuff.h: Rename include guard.
5204         * common/fileio.h: Rename include guard.
5205         * common/environ.h: Rename include guard.
5206         * common/common-utils.h: Rename include guard.
5207         * common/common-types.h: Rename include guard.
5208         * common/common-regcache.h: Rename include guard.
5209         * common/common-inferior.h: Rename include guard.
5210         * common/common-gdbthread.h: Rename include guard.
5211         * common/common-exceptions.h: Rename include guard.
5212         * common/common-defs.h: Rename include guard.
5213         * common/common-debug.h: Rename include guard.
5214         * common/cleanups.h: Rename include guard.
5215         * common/buffer.h: Rename include guard.
5216         * common/btrace-common.h: Rename include guard.
5217         * common/break-common.h: Rename include guard.
5218         * cli/cli-utils.h: Rename include guard.
5219         * cli/cli-style.h: Rename include guard.
5220         * cli/cli-setshow.h: Rename include guard.
5221         * cli/cli-script.h: Rename include guard.
5222         * cli/cli-interp.h: Rename include guard.
5223         * cli/cli-decode.h: Rename include guard.
5224         * cli/cli-cmds.h: Rename include guard.
5225         * charset-list.h: Add include guard.
5226         * buildsym-legacy.h: Rename include guard.
5227         * bfin-tdep.h: Add include guard.
5228         * ax.h: Rename include guard.
5229         * arm-linux-tdep.h: Add include guard.
5230         * arm-fbsd-tdep.h: Add include guard.
5231         * arch/xtensa.h: Rename include guard.
5232         * arch/tic6x.h: Add include guard.
5233         * arch/i386.h: Add include guard.
5234         * arch/arm.h: Rename include guard.
5235         * arch/arm-linux.h: Rename include guard.
5236         * arch/arm-get-next-pcs.h: Rename include guard.
5237         * arch/amd64.h: Add include guard.
5238         * arch/aarch64-insn.h: Rename include guard.
5239         * arch-utils.h: Rename include guard.
5240         * annotate.h: Add include guard.
5241         * amd64-darwin-tdep.h: Rename include guard.
5242         * aarch64-linux-tdep.h: Add include guard.
5243         * aarch64-fbsd-tdep.h: Add include guard.
5244         * aarch32-linux-nat.h: Add include guard.
5245
5246 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5247
5248         * macrotab.c (macro_define_internal): New function that
5249         factorizes macro_define_object_internal and macro_define_function
5250         code.
5251         (macro_define_object_internal): Use macro_define_internal.
5252         (macro_define_function): Likewise.
5253
5254 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5255
5256         * macrocmd.c (extract_identifier): Return
5257         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5258         callers.
5259
5260 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5261
5262         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5263
5264 2019-02-05  Tom Tromey  <tom@tromey.com>
5265
5266         * target.c (target_stack::unpush): Move assertion earlier.
5267
5268 2019-01-30  Tom Tromey  <tom@tromey.com>
5269
5270         PR python/23615:
5271         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5272         (gdbpy_parse_and_eval): Likewise.
5273         * python/python-internal.h (gdbpy_allow_threads): New class.
5274
5275 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5276
5277         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5278         (aarch64_fbsd_fpregmap): Move earlier.
5279         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5280         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5281         instead of individual calls to trad_frame_set_reg_addr.
5282         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5283         earlier.
5284         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5285         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5286         instead of individual calls to trad_frame_set_reg_addr.
5287
5288 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5289
5290         * CONTRIBUTE: Replace contribution list with wiki link.
5291
5292 2019-01-25  Tom Tromey  <tom@tromey.com>
5293
5294         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5295
5296 2019-01-25  Tom Tromey  <tom@tromey.com>
5297
5298         * xtensa-linux-nat.c: Fix common/ includes.
5299         * xml-support.h: Fix common/ includes.
5300         * xml-support.c: Fix common/ includes.
5301         * x86-linux-nat.c: Fix common/ includes.
5302         * windows-nat.c: Fix common/ includes.
5303         * varobj.h: Fix common/ includes.
5304         * varobj.c: Fix common/ includes.
5305         * value.c: Fix common/ includes.
5306         * valops.c: Fix common/ includes.
5307         * utils.c: Fix common/ includes.
5308         * unittests/xml-utils-selftests.c: Fix common/ includes.
5309         * unittests/utils-selftests.c: Fix common/ includes.
5310         * unittests/unpack-selftests.c: Fix common/ includes.
5311         * unittests/tracepoint-selftests.c: Fix common/ includes.
5312         * unittests/style-selftests.c: Fix common/ includes.
5313         * unittests/string_view-selftests.c: Fix common/ includes.
5314         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5315         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5316         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5317         * unittests/rsp-low-selftests.c: Fix common/ includes.
5318         * unittests/parse-connection-spec-selftests.c: Fix common/
5319         includes.
5320         * unittests/optional-selftests.c: Fix common/ includes.
5321         * unittests/offset-type-selftests.c: Fix common/ includes.
5322         * unittests/observable-selftests.c: Fix common/ includes.
5323         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5324         * unittests/memrange-selftests.c: Fix common/ includes.
5325         * unittests/memory-map-selftests.c: Fix common/ includes.
5326         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5327         * unittests/function-view-selftests.c: Fix common/ includes.
5328         * unittests/environ-selftests.c: Fix common/ includes.
5329         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5330         * unittests/common-utils-selftests.c: Fix common/ includes.
5331         * unittests/cli-utils-selftests.c: Fix common/ includes.
5332         * unittests/array-view-selftests.c: Fix common/ includes.
5333         * ui-file.c: Fix common/ includes.
5334         * tui/tui-io.c: Fix common/ includes.
5335         * tracepoint.h: Fix common/ includes.
5336         * tracepoint.c: Fix common/ includes.
5337         * tracefile-tfile.c: Fix common/ includes.
5338         * top.h: Fix common/ includes.
5339         * top.c: Fix common/ includes.
5340         * thread.c: Fix common/ includes.
5341         * target/waitstatus.h: Fix common/ includes.
5342         * target/waitstatus.c: Fix common/ includes.
5343         * target.h: Fix common/ includes.
5344         * target.c: Fix common/ includes.
5345         * target-memory.c: Fix common/ includes.
5346         * target-descriptions.c: Fix common/ includes.
5347         * symtab.h: Fix common/ includes.
5348         * symfile.c: Fix common/ includes.
5349         * stap-probe.c: Fix common/ includes.
5350         * spu-linux-nat.c: Fix common/ includes.
5351         * sparc-nat.c: Fix common/ includes.
5352         * source.c: Fix common/ includes.
5353         * solib.c: Fix common/ includes.
5354         * solib-target.c: Fix common/ includes.
5355         * ser-unix.c: Fix common/ includes.
5356         * ser-tcp.c: Fix common/ includes.
5357         * ser-pipe.c: Fix common/ includes.
5358         * ser-base.c: Fix common/ includes.
5359         * selftest-arch.c: Fix common/ includes.
5360         * s12z-tdep.c: Fix common/ includes.
5361         * rust-exp.y: Fix common/ includes.
5362         * rs6000-aix-tdep.c: Fix common/ includes.
5363         * riscv-tdep.c: Fix common/ includes.
5364         * remote.c: Fix common/ includes.
5365         * remote-notif.h: Fix common/ includes.
5366         * remote-fileio.h: Fix common/ includes.
5367         * remote-fileio.c: Fix common/ includes.
5368         * regcache.h: Fix common/ includes.
5369         * regcache.c: Fix common/ includes.
5370         * record-btrace.c: Fix common/ includes.
5371         * python/python.c: Fix common/ includes.
5372         * python/py-type.c: Fix common/ includes.
5373         * python/py-inferior.c: Fix common/ includes.
5374         * progspace.h: Fix common/ includes.
5375         * producer.c: Fix common/ includes.
5376         * procfs.c: Fix common/ includes.
5377         * proc-api.c: Fix common/ includes.
5378         * printcmd.c: Fix common/ includes.
5379         * ppc-linux-nat.c: Fix common/ includes.
5380         * parser-defs.h: Fix common/ includes.
5381         * osdata.c: Fix common/ includes.
5382         * obsd-nat.c: Fix common/ includes.
5383         * nat/x86-linux.c: Fix common/ includes.
5384         * nat/x86-linux-dregs.c: Fix common/ includes.
5385         * nat/x86-dregs.h: Fix common/ includes.
5386         * nat/x86-dregs.c: Fix common/ includes.
5387         * nat/ppc-linux.c: Fix common/ includes.
5388         * nat/mips-linux-watch.h: Fix common/ includes.
5389         * nat/mips-linux-watch.c: Fix common/ includes.
5390         * nat/linux-waitpid.c: Fix common/ includes.
5391         * nat/linux-ptrace.h: Fix common/ includes.
5392         * nat/linux-ptrace.c: Fix common/ includes.
5393         * nat/linux-procfs.c: Fix common/ includes.
5394         * nat/linux-personality.c: Fix common/ includes.
5395         * nat/linux-osdata.c: Fix common/ includes.
5396         * nat/linux-namespaces.c: Fix common/ includes.
5397         * nat/linux-btrace.h: Fix common/ includes.
5398         * nat/linux-btrace.c: Fix common/ includes.
5399         * nat/fork-inferior.c: Fix common/ includes.
5400         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5401         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5402         * nat/aarch64-linux.c: Fix common/ includes.
5403         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5404         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5405         * namespace.h: Fix common/ includes.
5406         * mips-linux-tdep.c: Fix common/ includes.
5407         * minsyms.c: Fix common/ includes.
5408         * mi/mi-parse.h: Fix common/ includes.
5409         * mi/mi-main.c: Fix common/ includes.
5410         * mi/mi-cmd-env.c: Fix common/ includes.
5411         * memrange.h: Fix common/ includes.
5412         * memattr.c: Fix common/ includes.
5413         * maint.h: Fix common/ includes.
5414         * maint.c: Fix common/ includes.
5415         * main.c: Fix common/ includes.
5416         * machoread.c: Fix common/ includes.
5417         * location.c: Fix common/ includes.
5418         * linux-thread-db.c: Fix common/ includes.
5419         * linux-nat.c: Fix common/ includes.
5420         * linux-fork.c: Fix common/ includes.
5421         * inline-frame.c: Fix common/ includes.
5422         * infrun.c: Fix common/ includes.
5423         * inflow.c: Fix common/ includes.
5424         * inferior.h: Fix common/ includes.
5425         * inferior.c: Fix common/ includes.
5426         * infcmd.c: Fix common/ includes.
5427         * inf-ptrace.c: Fix common/ includes.
5428         * inf-child.c: Fix common/ includes.
5429         * ia64-linux-nat.c: Fix common/ includes.
5430         * i387-tdep.c: Fix common/ includes.
5431         * i386-tdep.c: Fix common/ includes.
5432         * i386-linux-tdep.c: Fix common/ includes.
5433         * i386-linux-nat.c: Fix common/ includes.
5434         * i386-go32-tdep.c: Fix common/ includes.
5435         * i386-fbsd-tdep.c: Fix common/ includes.
5436         * i386-fbsd-nat.c: Fix common/ includes.
5437         * guile/scm-type.c: Fix common/ includes.
5438         * guile/guile.c: Fix common/ includes.
5439         * go32-nat.c: Fix common/ includes.
5440         * gnu-nat.c: Fix common/ includes.
5441         * gdbthread.h: Fix common/ includes.
5442         * gdbarch-selftests.c: Fix common/ includes.
5443         * gdb_usleep.c: Fix common/ includes.
5444         * gdb_select.h: Fix common/ includes.
5445         * gdb_bfd.c: Fix common/ includes.
5446         * gcore.c: Fix common/ includes.
5447         * fork-child.c: Fix common/ includes.
5448         * findvar.c: Fix common/ includes.
5449         * fbsd-nat.c: Fix common/ includes.
5450         * event-top.c: Fix common/ includes.
5451         * event-loop.c: Fix common/ includes.
5452         * dwarf2read.c: Fix common/ includes.
5453         * dwarf2loc.c: Fix common/ includes.
5454         * dwarf2-frame.c: Fix common/ includes.
5455         * dwarf-index-cache.c: Fix common/ includes.
5456         * dtrace-probe.c: Fix common/ includes.
5457         * disasm-selftests.c: Fix common/ includes.
5458         * defs.h: Fix common/ includes.
5459         * csky-tdep.c: Fix common/ includes.
5460         * cp-valprint.c: Fix common/ includes.
5461         * cp-support.h: Fix common/ includes.
5462         * cp-support.c: Fix common/ includes.
5463         * corelow.c: Fix common/ includes.
5464         * completer.h: Fix common/ includes.
5465         * completer.c: Fix common/ includes.
5466         * compile/compile.c: Fix common/ includes.
5467         * compile/compile-loc2c.c: Fix common/ includes.
5468         * compile/compile-cplus-types.c: Fix common/ includes.
5469         * compile/compile-cplus-symbols.c: Fix common/ includes.
5470         * command.h: Fix common/ includes.
5471         * cli/cli-dump.c: Fix common/ includes.
5472         * cli/cli-cmds.c: Fix common/ includes.
5473         * charset.c: Fix common/ includes.
5474         * build-id.c: Fix common/ includes.
5475         * btrace.h: Fix common/ includes.
5476         * btrace.c: Fix common/ includes.
5477         * breakpoint.h: Fix common/ includes.
5478         * breakpoint.c: Fix common/ includes.
5479         * ax.h:
5480         (enum agent_op): Fix common/ includes.
5481         * ax-general.c (struct aop_map): Fix common/ includes.
5482         * ax-gdb.c: Fix common/ includes.
5483         * auxv.c: Fix common/ includes.
5484         * auto-load.c: Fix common/ includes.
5485         * arm-tdep.c: Fix common/ includes.
5486         * arch/riscv.c: Fix common/ includes.
5487         * arch/ppc-linux-common.c: Fix common/ includes.
5488         * arch/i386.c: Fix common/ includes.
5489         * arch/arm.c: Fix common/ includes.
5490         * arch/arm-linux.c: Fix common/ includes.
5491         * arch/arm-get-next-pcs.c: Fix common/ includes.
5492         * arch/amd64.c: Fix common/ includes.
5493         * arch/aarch64.c: Fix common/ includes.
5494         * arch/aarch64-insn.c: Fix common/ includes.
5495         * arch-utils.c: Fix common/ includes.
5496         * amd64-windows-tdep.c: Fix common/ includes.
5497         * amd64-tdep.c: Fix common/ includes.
5498         * amd64-sol2-tdep.c: Fix common/ includes.
5499         * amd64-obsd-tdep.c: Fix common/ includes.
5500         * amd64-nbsd-tdep.c: Fix common/ includes.
5501         * amd64-linux-tdep.c: Fix common/ includes.
5502         * amd64-linux-nat.c: Fix common/ includes.
5503         * amd64-fbsd-tdep.c: Fix common/ includes.
5504         * amd64-fbsd-nat.c: Fix common/ includes.
5505         * amd64-dicos-tdep.c: Fix common/ includes.
5506         * amd64-darwin-tdep.c: Fix common/ includes.
5507         * agent.c: Fix common/ includes.
5508         * ada-lang.h: Fix common/ includes.
5509         * ada-lang.c: Fix common/ includes.
5510         * aarch64-tdep.c: Fix common/ includes.
5511
5512 2019-01-25  Tom Tromey  <tom@tromey.com>
5513
5514         * common/create-version.sh: Use common/version.h.
5515
5516 2019-01-24  Pedro Alves  <palves@redhat.com>
5517
5518         * infrun.c (signal_stop, signal_print, signal_program)
5519         (signal_catch, signal_pass): Now arrays instead of pointers.
5520         (update_signals_program_target, do_target_resume)
5521         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5522         * linux-nat.c (linux_nat_target::pass_signals)
5523         (linux_nat_target::create_inferior, linux_nat_target::attach):
5524         Adjust.
5525         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5526         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5527         * procfs.c (procfs_target::pass_signals): Adjust.
5528         * record-full.c (record_full_target::resume): Adjust.
5529         * remote.c (remote_target::pass_signals)
5530         (remote_target::program_signals): Adjust.
5531         * target-debug.h (target_debug_print_signals): Now takes a
5532         gdb::array_view as parameter.  Adjust.
5533         * target.h (target_ops) <pass_signals, program_signals>: Replace
5534         pointer and length parameters with gdb::array_view.
5535         (target_pass_signals, target_program_signals): Likewise.
5536         * target-delegates.c: Regenerate.
5537
5538 2019-01-24  Pedro Alves  <palves@redhat.com>
5539
5540         * common/forward-scope-exit.h
5541         (forward_scope_exit::forward_scope_exit): Pass arguments to
5542         m_bind_function directly, instead of creating a std::bind and
5543         copying that.
5544
5545 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5546
5547         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5548         for static members.
5549         (pass_in_v_vfp_candidate): Likewise.
5550
5551 2019-01-23  Tom Tromey  <tom@tromey.com>
5552             Pedro Alves  <palves@redhat.com>
5553
5554         * regcache.c (class regcache_invalidator): Remove.
5555         (regcache::raw_write): Use make_scope_exit.
5556
5557 2019-01-23  Tom Tromey  <tom@tromey.com>
5558
5559         * ui-out.h (class ui_out_emit_type): Update comment.
5560
5561 2019-01-23  Tom Tromey  <tom@tromey.com>
5562
5563         * infrun.c (fetch_inferior_event): Update comment.
5564
5565 2019-01-23  Tom Tromey  <tom@tromey.com>
5566             Pedro Alves  <palves@redhat.com>
5567
5568         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5569         parameter.
5570         (fetch_inferior_event): Use SCOPE_EXIT.
5571
5572
5573 2019-01-23  Tom Tromey  <tom@tromey.com>
5574             Pedro Alves  <palves@redhat.com>
5575
5576         * infrun.c (disable_thread_events): Delete.
5577         (stop_all_threads): Use SCOPE_EXIT.
5578
5579 2019-01-23  Tom Tromey  <tom@tromey.com>
5580             Pedro Alves  <palves@redhat.com>
5581
5582         * symfile.c: Include forward-scope-exit.h.
5583         (clear_symtab_users_cleanup): Replace forward declaration with
5584         a FORWARD_SCOPE_EXIT.
5585         (syms_from_objfile_1): Use the forward_scope_exit and
5586         gdb::optional instead of cleanup_function.
5587         (reread_symbols): Use the forward_scope_exit instead of
5588         cleanup_function.
5589         (clear_symtab_users_cleanup): Remove function.
5590
5591 2019-01-23  Tom Tromey  <tom@tromey.com>
5592             Pedro Alves  <palves@redhat.com>
5593
5594         * linux-nat.c: Include scope-exit.h.
5595         (cleanup_target_stop): Remove.
5596         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5597         SCOPE_EXIT.
5598
5599 2019-01-23  Tom Tromey  <tom@tromey.com>
5600             Pedro Alves  <palves@redhat.com>
5601
5602         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5603         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5604
5605 2019-01-23  Tom Tromey  <tom@tromey.com>
5606             Andrew Burgess  <andrew.burgess@embecosm.com>
5607             Pedro Alves  <palves@redhat.com>
5608
5609         * infrun.c (fetch_inferior_event): Use scope_exit.
5610         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5611         * top.c (execute_command): Use scope_exit.
5612         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5613         * utils.c (do_bpstat_clear_actions_cleanup)
5614         (make_bpstat_clear_actions_cleanup): Remove.
5615
5616 2019-01-23  Tom Tromey  <tom@tromey.com>
5617             Pedro Alves  <palves@redhat.com>
5618
5619         * infrun.c: Include "common/scope-exit.h"
5620         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5621         (wait_for_inferior): Use SCOPE_EXIT.
5622         (fetch_inferior_event): Use scope_exit.
5623
5624 2019-01-23  Tom Tromey  <tom@tromey.com>
5625             Pedro Alves  <palves@redhat.com>
5626
5627         * breakpoint.c (create_breakpoint): Remove cleanup.
5628
5629 2019-01-23  Tom Tromey  <tom@tromey.com>
5630             Andrew Burgess  <andrew.burgess@embecosm.com>
5631             Pedro Alves  <palves@redhat.com>
5632
5633 2019-01-23  Pedro Alves  <palves@redhat.com>
5634
5635         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5636
5637 2019-01-23  Pedro Alves  <palves@redhat.com>
5638             Andrew Burgess  <andrew.burgess@embecosm.com>
5639
5640         * gdbthread.h: Include "common/forward-scope-exit.h".
5641         (scoped_finish_thread_state): Redefine custom class in terms of
5642         forward_scope_exit.
5643
5644 2019-01-23  Pedro Alves  <palves@redhat.com>
5645             Andrew Burgess  <andrew.burgess@embecosm.com>
5646
5647         * common/forward-scope-exit.h: New file.
5648
5649 2019-01-23  Pedro Alves  <palves@redhat.com>
5650             Andrew Burgess  <andrew.burgess@embecosm.com>
5651             Tom Tromey  <tom@tromey.com>
5652
5653         * common/scope-exit.h: New file.
5654
5655 2019-01-23  Pedro Alves  <palves@redhat.com>
5656
5657         * common/preprocessor.h (ESC): Rename to ...
5658         (ESC_PARENS): ... this.
5659         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5660         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5661
5662 2019-01-23  Tom Tromey  <tom@tromey.com>
5663
5664         * language.h (class scoped_switch_to_sym_language_if_auto):
5665         Initialize m_lang in both cases.
5666
5667 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5668
5669         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5670         with XCNEW.
5671
5672 2019-01-22  Tom Tromey  <tom@tromey.com>
5673
5674         * corelow.c: Do not include sys/file.h.
5675
5676 2019-01-22  Tom Tromey  <tom@tromey.com>
5677
5678         * tui/tui-wingeneral.h: Include gdb_curses.h.
5679
5680 2019-01-22  Tom Tromey  <tom@tromey.com>
5681
5682         * source-cache.h (class source_cache) <get_source_lines,
5683         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5684
5685 2019-01-22  Tom Tromey  <tom@tromey.com>
5686
5687         * remote-fileio.h (struct remote_target): Declare.
5688
5689 2019-01-22  Tom Tromey  <tom@tromey.com>
5690
5691         * python/py-arch.c: Do not include py-ref.h.
5692         * python/py-bpevent.c: Do not include py-ref.h.
5693         * python/py-cmd.c: Do not include py-ref.h.
5694         * python/py-continueevent.c: Do not include py-ref.h.
5695         * python/py-event.h: Do not include py-ref.h.
5696         * python/py-evtregistry.c: Do not include py-ref.h.
5697         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5698         * python/py-frame.c: Do not include py-ref.h.
5699         * python/py-framefilter.c: Do not include py-ref.h.
5700         * python/py-function.c: Do not include py-ref.h.
5701         * python/py-infevents.c: Do not include py-ref.h.
5702         * python/py-linetable.c: Do not include py-ref.h.
5703         * python/py-objfile.c: Do not include py-ref.h.
5704         * python/py-param.c: Do not include py-ref.h.
5705         * python/py-prettyprint.c: Do not include py-ref.h.
5706         * python/py-progspace.c: Do not include py-ref.h.
5707         * python/py-symbol.c: Do not include py-ref.h.
5708         * python/py-symtab.c: Do not include py-ref.h.
5709         * python/py-type.c: Do not include py-ref.h.
5710         * python/py-unwind.c: Do not include py-ref.h.
5711         * python/py-utils.c: Do not include py-ref.h.
5712         * python/py-value.c: Do not include py-ref.h.
5713         * python/py-varobj.c: Do not include py-ref.h.
5714         * python/py-xmethods.c: Do not include py-ref.h.
5715         * python/python.c: Do not include py-ref.h.
5716         * varobj.c: Do not include py-ref.h.
5717
5718 2019-01-22  Tom Tromey  <tom@tromey.com>
5719
5720         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5721         keyword for bcache.
5722
5723 2019-01-22  Tom Tromey  <tom@tromey.com>
5724
5725         * compile/compile-cplus-types.c: Remove a comment by #include.
5726
5727 2019-01-22  Tom Tromey  <tom@tromey.com>
5728
5729         * compile/gcc-c-plugin.h: Include compile-internal.h.
5730
5731 2019-01-22  Tom Tromey  <tom@tromey.com>
5732
5733         * stabsread.c (EXTERN): Do not define.
5734         (symnum, next_symbol_text_func, processing_gcc_compilation)
5735         (within_function, global_sym_chain, global_stabs)
5736         (previous_stab_code, this_object_header_files)
5737         (n_this_object_header_files)
5738         (n_allocated_this_object_header_files): Define.
5739         * stabsread.h (EXTERN): Never define.  Use "extern".
5740
5741 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5742
5743         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5744         history_value.
5745
5746 2019-01-21  Tom Tromey  <tom@tromey.com>
5747
5748         * ui-out.c: Fix includes.
5749         * tui/tui-source.c: Fix includes.
5750         * target.c: Fix includes.
5751         * remote.c: Fix includes.
5752         * regcache.c: Fix includes.
5753         * python/py-block.c: Fix includes.
5754         * printcmd.c: Fix includes.
5755         * or1k-tdep.c: Fix includes.
5756         * mi/mi-main.c: Fix includes.
5757         * m32r-tdep.c: Fix includes.
5758         * csky-tdep.c: Fix includes.
5759         * compile/compile-cplus-types.c: Fix includes.
5760         * cli/cli-interp.c: Fix includes.
5761
5762 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5763
5764         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5765         for padding.
5766
5767 2019-01-16  Tom Tromey  <tom@tromey.com>
5768
5769         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5770         earlier.
5771         (struct objfile) <msymbols_range>: Move from top level.
5772         <msymbols>: New method.
5773         (class objfile_msymbols): Remove.
5774         * symtab.c (default_collect_symbol_completion_matches_break_on):
5775         Update.
5776         * symmisc.c (dump_msymbols): Update.
5777         * stabsread.c (scan_file_globals): Update.
5778         * objc-lang.c (info_selectors_command, info_classes_command)
5779         (find_methods): Update.
5780         * minsyms.c (find_solib_trampoline_target): Update.
5781         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5782         * coffread.c (coff_symfile_read): Update.
5783         * ada-lang.c (ada_lookup_simple_minsym)
5784         (ada_collect_symbol_completion_matches): Update.
5785
5786 2019-01-16  Tom Tromey  <tom@tromey.com>
5787
5788         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5789         type.  Remove no-argument constructor.
5790         <iterator::operator++>: Simplify.
5791         <begin>: Update.
5792         <end>: Use minimal_symbol_count.
5793
5794 2019-01-16  Tom Tromey  <tom@tromey.com>
5795
5796         * objfiles.h (struct objfile) <psymtabs>: New method.
5797         (class objfile_psymtabs): Remove.
5798         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5799         typedef.
5800         <range>: New method.
5801         (require_partial_symbols): Change return type.
5802         * psymtab.c (require_partial_symbols)
5803         (psym_expand_symtabs_matching): Update.
5804         * mdebugread.c (parse_partial_symbols): Update.
5805         * dbxread.c (dbx_end_psymtab): Update.
5806
5807 2019-01-15  Tom Tromey  <tom@tromey.com>
5808
5809         * symtab.c (lookup_objfile_from_block)
5810         (lookup_symbol_in_objfile_symtabs)
5811         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5812         (find_line_symtab, info_sources_command)
5813         (default_collect_symbol_completion_matches_break_on)
5814         (make_source_files_completion_list): Update.
5815         * symmisc.c (print_objfile_statistics, dump_objfile)
5816         (maintenance_print_symbols, maintenance_info_symtabs)
5817         (maintenance_check_symtabs, maintenance_info_line_tables):
5818         Update.
5819         * source.c (select_source_symtab)
5820         (forget_cached_source_info_for_objfile): Update.
5821         * objfiles.h (class objfile_compunits): Remove.
5822         (struct objfile) <compunits_range>: New typedef.
5823         (compunits): New method.
5824         * objfiles.c (objfile_relocate1): Update.
5825         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5826         * maint.c (count_symtabs_and_blocks): Update.
5827         * linespec.c (iterate_over_all_matching_symtabs): Update.
5828         * cp-support.c (add_symbol_overload_list_qualified): Update.
5829         * coffread.c (coff_symtab_read): Update.
5830         * ada-lang.c (add_nonlocal_symbols)
5831         (ada_collect_symbol_completion_matches)
5832         (ada_add_global_exceptions): Update.
5833
5834 2019-01-15  Tom Tromey  <tom@tromey.com>
5835
5836         * progspace.h (program_space) <objfiles_safe_range>: New
5837         typedef.
5838         <objfiles_safe>: New method.
5839         * objfiles.h (class all_objfiles_safe): Remove.
5840         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5841         * jit.c (jit_inferior_exit_hook): Update.
5842
5843 2019-01-17  Tom Tromey  <tom@tromey.com>
5844
5845         * progspace.h (program_space) <objfiles_range>: New typedef.
5846         <objfiles>: New method.
5847         <objfiles_head>: Rename from objfiles.
5848         (object_files): Update.
5849         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5850         * guile/scm-pretty-print.c
5851         (ppscm_find_pretty_printer_from_objfiles): Update.
5852         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5853         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5854         Update.
5855         * python/py-progspace.c (pspy_get_objfiles): Update.
5856         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5857         Update.
5858         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5859         (objfpy_lookup_objfile_by_build_id): Update.
5860         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5861         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5862         Update.
5863         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5864         (expand_symtab_containing_pc, lookup_objfile_from_block)
5865         (lookup_static_symbol, basic_lookup_transparent_type)
5866         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5867         (find_line_symtab, info_sources_command)
5868         (default_collect_symbol_completion_matches_break_on)
5869         (make_source_files_completion_list, find_main_name): Update.
5870         * symmisc.c (print_symbol_bcache_statistics)
5871         (print_objfile_statistics, maintenance_print_symbols)
5872         (maintenance_print_msymbols, maintenance_print_objfiles)
5873         (maintenance_info_symtabs, maintenance_check_symtabs)
5874         (maintenance_expand_symtabs, maintenance_info_line_tables):
5875         Update.
5876         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5877         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5878         (map_overlay_command, unmap_overlay_command)
5879         (simple_overlay_update, expand_symtabs_matching)
5880         (map_symbol_filenames): Update.
5881         * symfile-debug.c (set_debug_symfile): Update.
5882         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5883         Update.
5884         * source.c (select_source_symtab, forget_cached_source_info):
5885         Update.
5886         * solib.c (solib_read_symbols): Update.
5887         * solib-spu.c (append_ocl_sos): Update.
5888         * psymtab.c (maintenance_print_psymbols)
5889         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5890         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5891         * printcmd.c (info_symbol_command): Update.
5892         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5893         Update.
5894         * objfiles.h (class all_objfiles): Remove.
5895         * objfiles.c (have_partial_symbols, have_full_symbols)
5896         (have_minimal_symbols, qsort_cmp, update_section_map)
5897         (shared_objfile_contains_address_p)
5898         (default_iterate_over_objfiles_in_search_order): Update.
5899         * objc-lang.c (info_selectors_command, info_classes_command)
5900         (find_methods): Update.
5901         * minsyms.c (find_solib_trampoline_target): Update.
5902         * maint.c (maintenance_info_sections)
5903         (maintenance_translate_address, count_symtabs_and_blocks):
5904         Update.
5905         * main.c (captured_main_1): Update.
5906         * linux-thread-db.c (try_thread_db_load_from_pdir)
5907         (has_libpthread): Update.
5908         * linespec.c (iterate_over_all_matching_symtabs)
5909         (search_minsyms_for_name): Update.
5910         * jit.c (jit_find_objf_with_entry_addr): Update.
5911         * hppa-tdep.c (find_unwind_entry)
5912         (hppa_lookup_stub_minimal_symbol): Update.
5913         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5914         Update.
5915         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5916         (elf_gnu_ifunc_resolve_by_got): Update.
5917         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5918         * dwarf-index-write.c (save_gdb_index_command): Update.
5919         * cp-support.c (add_symbol_overload_list_qualified): Update.
5920         * breakpoint.c (create_overlay_event_breakpoint)
5921         (create_longjmp_master_breakpoint)
5922         (create_std_terminate_master_breakpoint)
5923         (create_exception_master_breakpoint): Update.
5924         * blockframe.c (find_pc_partial_function): Update.
5925         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5926         (ada_collect_symbol_completion_matches)
5927         (ada_add_global_exceptions): Update.
5928
5929 2019-01-17  Tom Tromey  <tom@tromey.com>
5930
5931         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5932         declare VEC.
5933         (solib_target_parse_libraries): Change return type.
5934         (library_list_start_segment, library_list_start_section)
5935         (library_list_end_library, library_list_start_library); Update.
5936         (solib_target_free_library_list): Remove.
5937         (solib_target_parse_libraries): Remove cleanup.  Change return
5938         type.
5939         (solib_target_current_sos): Update.
5940
5941 2019-01-17  Tom Tromey  <tromey@bapiya>
5942
5943         * valprint.c: Replace "the the" with "the".
5944         * symtab.c: Replace "the the" with "the".
5945         * solib.c: Replace "the the" with "the".
5946         * solib-dsbt.c: Replace "the the" with "the".
5947         * linespec.c: Replace "the the" with "the".
5948         * dwarf2loc.h: Replace "the the" with "the".
5949         * amd64-windows-tdep.c: Replace "the the" with "the".
5950         * aarch64-tdep.c: Replace "the the" with "the".
5951
5952 2019-01-16  Keith Seitz  <keiths@redhat.com>
5953
5954         PR gdb/23773
5955         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5956         <builder>: Rename to ..
5957         <m_builder>: ... this and make private.
5958         (dwarf2_cu::get_builder): New method.  Change all users of
5959         `builder' to use this method.
5960         (dwarf2_start_symtab): Move to ...
5961         (dwarf2_cu::start_symtab): ... here.  Update all callers
5962         (setup_type_unit_groups): Move to ...
5963         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5964         callers.
5965         (dwarf2_cu::reset_builder): New method.
5966         (process_full_compunit, process_full_type_unit): Use
5967         dwarf2_cu::reset_builder.
5968         (follow_die_offset): Record the ancestor CU if it is different
5969         from the followed DIE's CU.
5970         (follow_die_sig_1): Likewise.
5971
5972 2019-01-15  Tom Tromey  <tom@tromey.com>
5973
5974         * remote.c (class remote_state) <buf>: Now a char_vector.
5975         <buf_size>: Remove.
5976         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5977         parameter.
5978         (remote_target::getpkt_or_notif_sane_1)
5979         (remote_target::getpkt_sane)
5980         (remote_target::getpkt_or_notif_sane): Likewise.
5981         (class remote_target) <putpkt>: New overload.
5982         (remote_target::read_frame): Change type of "buf_p".  Remove
5983         sizeof_p parameter.
5984         (packet_ok): New overload.
5985         (packet_check_result): New overload.
5986         Update all uses.
5987
5988 2019-01-14  Tom Tromey  <tom@tromey.com>
5989
5990         * remote-notif.c (handle_notification, remote_notif_ack)
5991         (remote_notif_parse): Make "buf" const.
5992         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5993         const.
5994         (remote_notif_parse, remote_notif_ack, handle_notification):
5995         Likewise.
5996         * remote.c (remote_notif_stop_parse): Make "buf" const.
5997         (remote_target::remote_parse_stop_reply): Make "buf" const.
5998         (remote_notif_stop_ack): Make "buf" const.
5999
6000 2019-01-14  Tom Tromey  <tom@tromey.com>
6001
6002         * remote.c (remote_console_output): Make parameter const.
6003
6004 2019-01-14  Tom Tromey  <tom@tromey.com>
6005
6006         * target-debug.h (target_debug_print_signals): Constify.
6007         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
6008         * procfs.c (procfs_target::pass_signals): Update.
6009         * linux-nat.c (linux_nat_target::pass_signals): Update.
6010         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
6011         * target-delegates.c: Rebuild.
6012         * remote.c (remote_target::program_signals): Update.
6013         (remote_target::pass_signals): Update.
6014         * target.c (target_pass_signals): Constify argument.
6015         (target_program_signals): Likewise.
6016         * target.h (struct target_ops) <pass_signals, program_signals>:
6017         Constify argument.
6018         (target_pass_signals, target_program_signals): Constify argument.
6019
6020 2019-01-14  Tom Tromey  <tom@tromey.com>
6021
6022         PR tui/28819:
6023         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
6024
6025 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6026
6027         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
6028         field.
6029         * rs6000-tdep.c: Include reggroups.h.
6030         (IS_V_ALIAS_PSEUDOREG): Define.
6031         (rs6000_register_name): Return names for the "vX" aliases.
6032         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
6033         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
6034         aliases.  Call default_register_reggroup_p for all other
6035         pseudo-registers.
6036         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
6037         New functions.
6038         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
6039         Handle "vX" aliases.
6040         (v_alias_pseudo_register_collect): New function.
6041         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
6042         (rs6000_gdbarch_init): Initialize "vX" aliases as
6043         pseudo-registers.  Restore registration of
6044         rs6000_pseudo_register_reggroup_p with
6045         set_tdesc_pseudo_register_reggroup_p.
6046
6047 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
6048
6049         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
6050         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
6051         set_gdbarch_num_pseudo_regs.
6052
6053 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6054
6055         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
6056         Remove arg prefixname, add do_set and do_show.
6057         Add member functions set_list and show_list.
6058         * cli/cli-style.c (class cli_style_option): Update accordingly.
6059         (style_set_list): Move to file scope.
6060         (style_show_list): Likewise.
6061         (set_style): Call help_list.
6062         (show_style): Call cmd_show_list.
6063         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
6064         Update to use the new macro.
6065
6066 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
6067
6068         * ada-lang.c (_initialize_ada_language): Expand the help text
6069         for the "catch exception" command.
6070
6071 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6072
6073         * symtab.c (matching_obj_sections): Initialize obj,
6074         declare it closer to its usage.
6075
6076 2019-01-10  Tom Tromey  <tom@tromey.com>
6077
6078         * thread-iter.h (inf_threads_iterator): Use next_iterator.
6079         (basic_inf_threads_range): Remove.
6080         (inf_threads_range, inf_non_exited_threads_range)
6081         (safe_inf_threads_range): Use next_adapter.
6082
6083 2019-01-10  Keith Seitz  <keiths@redhat.com>
6084
6085         PR gdb/23712
6086         PR symtab/23010
6087         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
6088         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
6089
6090 2019-01-10  Keith Seitz  <keiths@redhat.com>
6091
6092         PR gdb/23712
6093         PR symtab/23010
6094         * dictionary.c (pending_to_vector): Remove.
6095         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6096         Remove _1 suffix, replacing functions of the same name.  Update
6097         all callers.
6098         (dict_create_hashed, dict_create_hashed_expandable)
6099         (dict_create_linear, dict_create_linear_expandable, dict_free)
6100         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
6101         Make functions static.
6102
6103 2019-01-10  Keith Seitz  <keiths@redhat.com>
6104
6105         PR gdb/23712
6106         PR symtab/23010
6107         * dictionary.h (struct dictionary): Replace declaration with
6108         multidictionary.
6109         (dict_create_hashed, dict_create_hashed_expandable)
6110         (dict_create_linear, dict_create_linear_expandable)
6111         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
6112         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
6113         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
6114         taking multidictionary argument.
6115         [ALL_DICT_SYMBOLS]: Update for multidictionary.
6116         * block.h (struct block) <dict>: Change to multidictionary
6117         and rename `multidict'.
6118         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
6119         symmisc.c: Update all dictionary references to multidictionary.
6120
6121 2019-01-10  Keith Seitz  <keiths@redhat.com>
6122
6123         PR gdb/23712
6124         PR symtab/23010
6125         * dictionary.c: Include unordered_map.
6126         (pending_to_vector): New function.
6127         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6128         Rewrite the non-"_1" functions to take vector instead
6129         of linked list.
6130         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
6131         "new" _1 versions of the same name.
6132         (multidictionary): Define.
6133         (std::hash<enum language): New definition.
6134         (collate_pending_symbols_by_language, mdict_create_hashed)
6135         (mdict_create_hashed_expandable, mdict_create_linear)
6136         (mdict_create_linear_expandable, mdict_free)
6137         (find_language_dictionary, create_new_language_dictionary)
6138         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
6139         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
6140         (mdict_size, mdict_empty): New functions.
6141         * dictionary.h (mdict_iterator): Define.
6142
6143 2019-01-10  Pedro Alves  <palves@redhat.com>
6144
6145         * breakpoint.c (read_uploaded_action)
6146         (create_tracepoint_from_upload): Adjust to use
6147         gdb::unique_xmalloc_ptr.
6148         * ctf.c (ctf_write_uploaded_tp):
6149         (SET_ARRAY_FIELD): Use emplace_back.
6150         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
6151         * tracefile-tfile.c (tfile_write_uploaded_tp):
6152         * tracepoint.c (parse_tracepoint_definition): Adjust to use
6153         gdb::unique_xmalloc_ptr.
6154         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
6155         at_string, cond_string, cmd_strings>: Replace char pointers
6156         with gdb::unique_xmalloc_ptr.
6157
6158 2019-01-10  Pedro Alves  <palves@redhat.com>
6159
6160         * solib-target.c (library_list_start_library): Don't xstrdup name.
6161
6162 2019-01-10  Pedro Alves  <palves@redhat.com>
6163
6164         * mdebugread.c (parse_partial_symbols): Use
6165         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
6166
6167 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6168
6169         * linux-fork.c (scoped_switch_fork_info)
6170         <~scoped_switch_fork_info>: Fix incorrect variable name.
6171
6172 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6173
6174         * linux-fork.c (scoped_switch_fork_info)
6175         <scoped_switch_fork_info>: Make explicit.
6176         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
6177
6178 2019-01-10  Tom Tromey  <tom@tromey.com>
6179
6180         * objfiles.h (objfile::reset_psymtabs): Update.
6181         * objfiles.c (objfile::objfile): Update.
6182         * psymtab.h (psymtab_storage::obstack): Update.
6183         (psymtab_storage::m_obstack): Use gdb::optional.
6184         (class psymtab_storage): Update comment.  Remove objfile
6185         parameter.
6186         * psymtab.c (psymtab_storage::psymtab_storage): Update.
6187
6188 2019-01-10  Tom Tromey  <tom@tromey.com>
6189
6190         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
6191         <free_psymtabs>: Now private.
6192         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
6193         (allocate_psymtab): Use new method.
6194
6195 2019-01-10  Tom Tromey  <tom@tromey.com>
6196
6197         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
6198         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
6199         * mdebugread.c (parse_partial_symbols): Use
6200         allocate_dependencies.
6201         * dwarf2read.c (dwarf2_create_include_psymtab): Use
6202         allocate_dependencies.
6203         (process_psymtab_comp_unit_reader)
6204         (build_type_psymtab_dependencies): Likewise.
6205         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
6206
6207 2019-01-10  Tom Tromey  <tom@tromey.com>
6208
6209         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
6210         PSYMBOL_SET_LANGUAGE.
6211         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
6212
6213 2019-01-10  Tom Tromey  <tom@tromey.com>
6214
6215         * psymtab.h (psymtab_storage::obstack): New method.
6216         <m_obstack>: Rename from obstack; now private.
6217         * psymtab.c (psymtab_storage): Update.
6218         * dwarf2read.c (create_addrmap_from_index)
6219         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
6220         Update.
6221
6222 2019-01-10  Tom Tromey  <tom@tromey.com>
6223
6224         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
6225         * objfiles.h (objfile::reset_psymtabs): New method.
6226
6227 2019-01-10  Tom Tromey  <tom@tromey.com>
6228
6229         * symmisc.c (print_symbol_bcache_statistics): Update.
6230         (print_objfile_statistics): Update.
6231         * symfile.c (reread_symbols): Update.
6232         * psymtab.h (class psymtab_storage): New.
6233         * psymtab.c (psymtab_storage): New constructor.
6234         (~psymtab_storage): New destructor.
6235         (require_partial_symbols): Update.
6236         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
6237         (find_pc_sect_psymtab, find_pc_sect_psymbol)
6238         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
6239         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
6240         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
6241         (start_psymtab_common, end_psymtab_common)
6242         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
6243         (allocate_psymtab): Update.
6244         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
6245         Update.
6246         (dump_psymtab_addrmap, maintenance_print_psymbols)
6247         (maintenance_check_psymtabs): Update.
6248         (class objfile_psymtabs): Move to objfiles.h.
6249         * psympriv.h (discard_psymtab): Now inline.
6250         (psymtab_discarder::psymtab_discarder): Update.
6251         (psymtab_discarder::~psymtab_discarder): Update.
6252         (ALL_OBJFILE_PSYMTABS): Rewrite.
6253         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6254         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6255         Remove fields.
6256         <partial_symtabs>: New field.
6257         (class objfile_psymtabs): Move from psymtab.h.  Update.
6258         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6259         psymbol_cache.
6260         (objfile::~objfile): Don't destroy psymbol_cache.
6261         * mdebugread.c (parse_partial_symbols): Update.
6262         * dwarf2read.c (create_addrmap_from_index)
6263         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6264         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6265         (add_partial_subprogram, dwarf2_ranges_read): Update.
6266         * dwarf-index-write.c (write_address_map)
6267         (write_one_signatured_type, recursively_write_psymbols)
6268         (class debug_names, class debug_names, write_psymtabs_to_index):
6269         Update.
6270
6271 2019-01-10  Tom Tromey  <tom@tromey.com>
6272
6273         * symtab.h (SYMBOL_SET_NAMES): Update.
6274         (symbol_set_names): Update.
6275         (MSYMBOL_SET_NAMES): Update.
6276         * symtab.c (symbol_set_names): Change argument to be an
6277         objfile_per_bfd_storage.
6278         * psymtab.c (add_psymbol_to_bcache): Update.
6279         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6280
6281 2019-01-10  Tom Tromey  <tom@tromey.com>
6282
6283         * symtab.c (create_demangled_names_hash): Change argument to be an
6284         objfile_per_bfd_storage.
6285         (symbol_set_names): Update.
6286
6287 2019-01-10  Tom Tromey  <tom@tromey.com>
6288
6289         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6290         init_psymbol_list.
6291         * psymtab.c (init_psymbol_list): Do nothing if already called.
6292         * psympriv.h (init_psymbol_list): Add comment.
6293         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6294         init_psymbol_list.
6295         * dbxread.c (dbx_symfile_read): Unconditionally call
6296         init_psymbol_list.
6297
6298 2019-01-10  Tom Tromey  <tom@tromey.com>
6299
6300         * xcoffread.c (scan_xcoff_symtab): Update.
6301         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6302         "where".
6303         * mdebugread.c (parse_partial_symbols)
6304         (handle_psymbol_enumerators): Update.
6305         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6306         * dbxread.c (read_dbx_symtab): Update.
6307         * psympriv.h (psymbol_placement): New enum.
6308         (add_psymbol_to_list): Update.
6309
6310 2019-01-10  Tom Tromey  <tom@tromey.com>
6311
6312         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6313         static_psymbols parameters.
6314         (scan_xcoff_symtab): Update.
6315         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6316         static_psymbols parameters.
6317         * psympriv.h (start_psymtab_common): Update.
6318         * mdebugread.c (parse_partial_symbols): Update.
6319         * dwarf2read.c (create_partial_symtab): Update.
6320         * dbxread.c (read_dbx_symtab): Update.
6321         (start_psymtab): Remove global_psymbols and static_psymbols
6322         parameters.
6323
6324 2019-01-10  Tom Tromey  <tom@tromey.com>
6325
6326         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6327         * psymtab.c (allocate_psymtab): Add comment.
6328         * psympriv.h (allocate_psymtab): Add comment.
6329         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6330         initializations.
6331         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6332
6333 2019-01-10  Tom Tromey  <tom@tromey.com>
6334
6335         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6336         Don't declare.
6337         * mipsread.c: Include mdebugread.h.
6338         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6339         Declare.
6340         * elfread.c: Include mdebugread.h.
6341
6342 2019-01-09  Tom Tromey  <tom@tromey.com>
6343
6344         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6345         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6346         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6347         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6348         (psym_lookup_symbol, psym_find_last_source_symtab)
6349         (psym_forget_cached_source_info, psym_print_stats)
6350         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6351         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6352         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6353         (psym_find_compunit_symtab_by_address)
6354         (maintenance_print_psymbols, maintenance_info_psymtabs)
6355         (maintenance_check_psymtabs): Use ranged for.
6356         * psymtab.h (class objfile_psymtabs): New.
6357         (require_partial_symbols): Return objfile_psymtabs.
6358         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6359
6360 2019-01-09  Tom Tromey  <tom@tromey.com>
6361
6362         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6363         (find_pc_mapped_section, list_overlays_command)
6364         (map_overlay_command, unmap_overlay_command)
6365         (simple_overlay_update): Use all_objfiles.
6366         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6367         * printcmd.c (info_symbol_command): Use all_objfiles.
6368         * objfiles.h (ALL_OBJSECTIONS): Remove.
6369         * maint.c (maintenance_translate_address): Use all_objfiles.
6370         * gcore.c (gcore_create_callback): Use all_objfiles.
6371         (objfile_find_memory_regions): Likewise.
6372
6373 2019-01-09  Tom Tromey  <tom@tromey.com>
6374
6375         * symtab.c (find_line_symtab, info_sources_command)
6376         (make_source_files_completion_list): Use objfile_compunits.
6377         * source.c (select_source_symtab): Use objfile_compunits.
6378         * objfiles.h (struct objfile): Update comment.
6379         (ALL_OBJFILES): Remove.
6380         (ALL_FILETABS): Remove.
6381         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6382         objfile_compunits.
6383
6384 2019-01-09  Tom Tromey  <tom@tromey.com>
6385
6386         * symmisc.c (print_objfile_statistics, dump_objfile)
6387         (maintenance_print_symbols): Use compunit_filetabs.
6388         * source.c (forget_cached_source_info_for_objfile): Use
6389         compunit_filetabs.
6390         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6391         (ALL_FILETABS): Use compunit_filetabs.
6392         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6393         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6394
6395 2019-01-09  Tom Tromey  <tom@tromey.com>
6396
6397         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6398         (compunit_filetabs): New.
6399         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6400         compunit_filetabs.
6401         (info_sources_command, make_source_files_completion_list): Remove
6402         declaration.
6403         * symmisc.c (print_objfile_statistics, dump_objfile)
6404         (maintenance_print_symbols): Remove declaration.
6405         (maintenance_info_symtabs): Use compunit_filetabs.
6406         (maintenance_info_line_tables): Likewise.
6407         * source.c (select_source_symtab): Change local variable name.
6408         (forget_cached_source_info_for_objfile): Remove declaration.
6409         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6410         * objfiles.c (objfile_relocate1): Remove declaration.
6411         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6412         declaration.
6413         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6414         * coffread.c (coff_symtab_read): Remove declaration.
6415         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6416         compunit_filetabs.
6417
6418 2019-01-09  Tom Tromey  <tom@tromey.com>
6419
6420         * symtab.c (lookup_objfile_from_block)
6421         (find_pc_sect_compunit_symtab, search_symbols)
6422         (default_collect_symbol_completion_matches_break_on): Use
6423         objfile_compunits.
6424         * objfiles.h (ALL_COMPUNITS): Remove.
6425         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6426         * cp-support.c (add_symbol_overload_list_qualified): Use
6427         objfile_compunits.
6428         * ada-lang.c (ada_collect_symbol_completion_matches)
6429         (ada_add_global_exceptions): Use objfile_compunits.
6430
6431 2019-01-09  Tom Tromey  <tom@tromey.com>
6432
6433         * source.c (select_source_symtab)
6434         (forget_cached_source_info_for_objfile): Remove declaration.
6435         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6436         declaration.
6437         * maint.c (count_symtabs_and_blocks): Remove declaration.
6438         * cp-support.c (add_symbol_overload_list_qualified): Remove
6439         declaration.
6440         * coffread.c (coff_symtab_read): Remove declaration.
6441         * symtab.c (lookup_symbol_in_objfile_symtabs)
6442         (basic_lookup_transparent_type_1): Use objfile_compunits.
6443         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6444         (info_sources_command, search_symbols)
6445         (default_collect_symbol_completion_matches_break_on)
6446         (make_source_files_completion_list): Remove declaration.
6447         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6448         (ada_collect_symbol_completion_matches)
6449         (ada_add_global_exceptions): Remove declaration.
6450         * linespec.c (iterate_over_all_matching_symtabs): Use
6451         objfile_compunits.
6452         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6453         (class objfile_compunits): New.
6454         (ALL_COMPUNITS): Use objfile_compunits.
6455         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6456         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6457         objfile_compunits.
6458         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6459
6460 2019-01-09  Tom Tromey  <tom@tromey.com>
6461
6462         * symtab.c (search_symbols)
6463         (default_collect_symbol_completion_matches_break_on): Use
6464         objfile_msymbols.
6465         * ada-lang.c (ada_lookup_simple_minsym)
6466         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6467         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6468         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6469         objfile_msymbols.
6470         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6471         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6472         * objc-lang.c (find_methods): Use objfile_msymbols.
6473         (info_selectors_command, info_classes_command): Likewise.
6474         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6475         * objfiles.h (class objfile_msymbols): New.
6476         (ALL_OBJFILE_MSYMBOLS): Remove.
6477         (ALL_MSYMBOLS): Remove.
6478
6479 2019-01-09  Tom Tromey  <tom@tromey.com>
6480
6481         * common/next-iterator.h (next_adapter): Add Iterator template
6482         parameter.
6483         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6484         (class all_objfiles_safe): New.
6485         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6486         * objfiles.c (put_objfile_before): Update comment.
6487         (add_separate_debug_objfile): Likewise.
6488         (free_all_objfiles): Use all_objfiles_safe.
6489         (objfile_purge_solibs): Likewise.
6490
6491 2019-01-09  Tom Tromey  <tom@tromey.com>
6492
6493         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6494         (expand_symtab_containing_pc, lookup_static_symbol)
6495         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6496         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6497         all_objfiles.
6498         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6499         * breakpoint.c (create_overlay_event_breakpoint)
6500         (create_longjmp_master_breakpoint)
6501         (create_std_terminate_master_breakpoint)
6502         (create_exception_master_breakpoint): Use all_objfiles.
6503         * linux-thread-db.c (try_thread_db_load_from_pdir)
6504         (has_libpthread): Use all_objfiles.
6505         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6506         * linespec.c (iterate_over_all_matching_symtabs)
6507         (search_minsyms_for_name): Use all_objfiles.
6508         * maint.c (maintenance_info_sections): Use all_objfiles.
6509         * main.c (captured_main_1): Use all_objfiles.
6510         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6511         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6512         * guile/scm-pretty-print.c
6513         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6514         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6515         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6516         (maintenance_print_msymbols): Use all_objfiles.
6517         * source.c (select_source_symtab): Use all_objfiles.
6518         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6519         * symfile.c (remove_symbol_file_command)
6520         (expand_symtabs_matching, map_symbol_filenames): Use
6521         all_objfiles.
6522         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6523         all_objfiles.
6524         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6525         * objc-lang.c (find_methods): Use all_objfiles.
6526         * objfiles.c (have_partial_symbols, have_full_symbols)
6527         (have_minimal_symbols, qsort_cmp)
6528         (default_iterate_over_objfiles_in_search_order): Use
6529         all_objfiles.
6530         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6531         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6532         (maintenance_check_psymtabs): Use all_objfiles.
6533         (ALL_PSYMTABS): Remove.
6534         * compile/compile-object-run.c (do_module_cleanup): Use
6535         all_objfiles.
6536         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6537         * cp-support.c (add_symbol_overload_list_qualified): Use
6538         all_objfiles.
6539         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6540         Use all_objfiles.
6541         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6542         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6543         all_objfiles.
6544         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6545         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6546         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6547         Uses all_objfiles.
6548         * solib.c (solib_read_symbols): Use all_objfiles
6549
6550 2019-01-09  Tom Tromey  <tom@tromey.com>
6551
6552         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6553         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6554         all_objfiles.
6555         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6556         * symmisc.c (print_symbol_bcache_statistics)
6557         (print_objfile_statistics, maintenance_print_objfiles)
6558         (maintenance_info_symtabs, maintenance_check_symtabs)
6559         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6560         all_objfiles.
6561         * source.c (forget_cached_source_info): Use all_objfiles.
6562         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6563         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6564         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6565         * objfiles.c (update_section_map): Use all_objfiles.
6566         (shared_objfile_contains_address_p): Likewise.
6567         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6568         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6569
6570 2019-01-09  Tom Tromey  <tom@tromey.com>
6571
6572         * common/next-iterator.h: New file.
6573         * objfiles.h (class all_objfiles): New.
6574         (struct objfile_iterator): New.
6575
6576 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6577
6578         * NEWS: Move the description of the changed "frame", "select-frame",
6579          and "info frame" commands to the Changed commands section.
6580
6581 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6582
6583         * gdbtypes.c (check_stub_method_group): Remove handling of old
6584         mangling schemes.
6585         * linespec.c (find_methods): Likewise.
6586         * stabsread.c (read_member_functions): Likewise.
6587         * valops.c (search_struct_method): Likewise.
6588         (value_struct_elt_for_reference): Likewise.
6589         * NEWS: Mention this change.
6590
6591 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6592
6593         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6594         print_source_lines.
6595         * source.c (print_source_lines_base): Update line number check.
6596         (print_source_lines): New function.
6597         (source_lines_range::source_lines_range): New function.
6598         * source.h (class source_lines_range): New class.
6599         (print_source_lines): New declaration.
6600
6601 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6602
6603         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6604
6605 2019-01-08  Tom Tromey  <tom@tromey.com>
6606             Simon Marchi  <simon.marchi@ericsson.com>
6607
6608         PR gdb/24060
6609         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6610         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6611         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6612         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6613         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6614         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6615
6616 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6617
6618         * source.c (select_source_symtab): Move header comment to
6619         declaration in source.h.
6620         (forget_cached_source_info_for_objfile): Likewise.
6621         (forget_cached_source_info): Likewise.
6622         (identify_source_line): Likewise.
6623         * source.h (identify_source_line): Move declaration from symtab.h
6624         and add comment from source.c
6625         (print_source_lines): Likewise.
6626         (forget_cached_source_info_for_objfile): Likewise.
6627         (forget_cached_source_info): Likewise.
6628         (select_source_symtab): Likewise.
6629         (enum print_source_lines_flag): Move definition from symtab.h.
6630         * symtab.h (identify_source_line): Move declaration to source.h.
6631         (print_source_lines): Likewise.
6632         (forget_cached_source_info_for_objfile): Likewise.
6633         (forget_cached_source_info): Likewise.
6634         (select_source_symtab): Likewise.
6635         (enum print_source_lines_flag): Move definition to source.h.
6636         * tui/tui-hooks.c: Add 'source.h' include.
6637
6638 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6639
6640         * source.c (print_source_lines_base): Handle requests to print
6641         reverse line number sequences, and guard against empty lines
6642         string.
6643
6644 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6645
6646         * source.c (print_source_lines_base): Fix skip of '\r' if next
6647         character is '\n'.
6648
6649 2019-01-06  Tom Tromey  <tom@tromey.com>
6650
6651         * c-exp.y (struct c_parse_state) <macro_original_text,
6652         expansion_obstack>: New member.
6653         (macro_original_text, expansion_obstack): Remove globals.
6654         (scan_macro_expansion, scanning_macro_expansion)
6655         (finished_macro_expansion): Update.
6656         (scan_macro_cleanup): Remove.
6657         (yylex, c_parse): Update.
6658
6659 2019-01-06  Tom Tromey  <tom@tromey.com>
6660
6661         * c-exp.y (struct c_parse_state) <strings>: New member.
6662         (operator_stoken): Update.
6663
6664 2019-01-06  Tom Tromey  <tom@tromey.com>
6665
6666         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6667         (union type_stack_elt) <typelist_val>: Now a pointer to
6668         std::vector.
6669         (type_stack_cleanup): Don't declare.
6670         (push_typelist): Update.
6671         * parse.c (pop_typelist): Return a std::vector.
6672         (push_typelist): Take a std::vector.
6673         (follow_types): Update.  Do not free args.
6674         (type_stack_cleanup): Remove.
6675         * c-exp.y (struct c_parse_state): New.
6676         (cpstate): New global.
6677         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6678         (nonempty_typelist): Update.
6679         (func_mod): Create a new vector.
6680         (c_parse): Create a c_parse_state.
6681         (check_parameter_typelist): Do not delete params.
6682         (function_method): Update.  Do not delete type_list.
6683
6684 2019-01-06  Tom Tromey  <tom@tromey.com>
6685
6686         PR gdb/28155:
6687         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6688         check_typedef.
6689         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6690         (print_return_value): Likewise.
6691
6692 2019-01-05  Tom Tromey  <tom@tromey.com>
6693
6694         * contrib/cleanup_check.py: Remove.
6695         * contrib/gcc-with-excheck: Remove.
6696         * contrib/exsummary.py: Remove.
6697         * contrib/excheck.py: Remove.
6698
6699 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6700
6701         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6702         NULL. Initialize tpprev to NULL instead of assigning it
6703         to NULL on the next statement.
6704         * windows-nat.c (windows_delete_thread): Remove check for
6705         main_thread_id before printing thread exit notifications.
6706         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6707         Remove thread ID check against main_thread_id.
6708         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6709         windows_delete_thread.
6710         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6711
6712 2019-01-04  Tom Tromey  <tom@tromey.com>
6713
6714         * compile/compile.c (_initialize_compile): Use upper case for
6715         metasyntactic variables.
6716         * symmisc.c (_initialize_symmisc): Use upper case for
6717         metasyntactic variables.
6718         * psymtab.c (_initialize_psymtab): Use upper case for
6719         metasyntactic variables.
6720         * demangle.c (demangle_command): Use upper case for metasyntactic
6721         variables.
6722         (_initialize_demangler): Likewise.
6723         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6724         variables.
6725
6726 2019-01-03  Tom Tromey  <tom@tromey.com>
6727
6728         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6729
6730 2019-01-03  Tom Tromey  <tom@tromey.com>
6731
6732         * python/py-symtab.c (salpy_str): Update.
6733         (struct salpy_sal_object) <symtab>: Now a PyObject.
6734         (salpy_dealloc): Update.
6735         (del_objfile_sal): Use gdbpy_ref.
6736
6737 2019-01-03  Tom Tromey  <tom@tromey.com>
6738
6739         * python/py-type.c (convert_field): Use new_reference.  Return
6740         gdbpy_ref.
6741         (make_fielditem): Return gdbpy_ref.
6742         (typy_fields): Update.
6743         (typy_getitem): Update.
6744         (field_name): Return gdbpy_ref.  Use new_reference.
6745         (typy_iterator_iternext): Update.
6746
6747 2019-01-03  Tom Tromey  <tom@tromey.com>
6748
6749         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6750
6751 2019-01-03  Tom Tromey  <tom@tromey.com>
6752
6753         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6754         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6755         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6756         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6757         (pspy_set_type_printers): Likewise.
6758         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6759         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6760         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6761         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6762         (objfpy_set_type_printers): Likewise.
6763
6764 2019-01-03  Tom Tromey  <tom@tromey.com>
6765
6766         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6767         (gdbpy_print_stack): Use gdbpy_err_fetch.
6768         * python/python-internal.h (class gdbpy_err_fetch): New class.
6769         (class gdbpy_enter) <m_error_type, m_error_value,
6770         m_error_traceback>: Remove.
6771         <m_error>: New member.
6772         (gdbpy_exception_to_string): Don't declare.
6773         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6774         * python/py-value.c (convert_value_from_python): Use
6775         gdbpy_err_fetch.
6776         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6777         gdbpy_exception_to_string.
6778         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6779         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6780         gdbpy_err_fetch.
6781
6782 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6783
6784         * linux-nat.c (delete_lwp_cleanup): Delete.
6785         (struct lwp_deleter): New struct.
6786         (lwp_info_up): New typedef.
6787         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6788         lwp_info_up.
6789
6790 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6791
6792         * linux-fork.c (class scoped_switch_fork_info): New class.
6793         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6794
6795 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6796
6797         * valops.c (find_overload_match): Remove use of null_cleanup, and
6798         calls to do_cleanups.
6799
6800 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6801
6802         * compile/compile-cplus-types.c
6803         (compile_cplus_instance::decl_name): Handle changes to
6804         cp_func_name.
6805         * cp-support.c (cp_func_name): Update header comment, update
6806         return type.
6807         * cp-support.h (cp_func_name): Update return type in declaration.
6808         * valops.c (find_overload_match): Move temp_func local to top
6809         level of function and change its type.  Use temp_func to hold and
6810         delete temporary string obtained from cp_func_name.
6811
6812 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6813
6814         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6815         gdb::char_vector, remove cleanup, and update uses of `msg`.
6816
6817 2019-01-03  Jim Wilson  <jimw@sifive.com>
6818
6819         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6820
6821 2019-01-02  Tom Tromey  <tom@tromey.com>
6822
6823         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6824         (tdesc_parse_xml): Remove cleanups.
6825         * target-descriptions.h (make_cleanup_free_target_description):
6826         Don't declare.
6827         (target_desc_deleter): New struct.
6828         (target_desc_up): New typedef.
6829         * target-descriptions.c (target_desc_deleter::operator()): Rename
6830         from free_target_description.
6831         (make_cleanup_free_target_description): Remove.
6832
6833 2019-01-02  Tom Tromey  <tom@tromey.com>
6834
6835         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6836         constructor, destructor.
6837         (linespec_parser): Remove typedef.
6838         (~linespec_parser): Rename from linespec_parser_delete.
6839         (linespec_lex_to_end, linespec_complete_label)
6840         (linespec_complete): Update.
6841         (decode_line_full): Remove cleanups.
6842         (decode_line_1): Update.
6843
6844 2019-01-02  Tom Tromey  <tom@tromey.com>
6845
6846         * python/python-internal.h (inferior_to_inferior_object): Change
6847         return type.
6848         * python/py-exitedevent.c (create_exited_event_object): Update.
6849         * python/py-inferior.c (inferior_to_inferior_object): Return
6850         gdbpy_ref.
6851         (python_new_inferior, python_inferior_deleted)
6852         (thread_to_thread_object, delete_thread_object)
6853         (build_inferior_list, gdbpy_selected_inferior): Update.
6854         * python/py-infthread.c (create_thread_object): Update.  Also fail
6855         if inferior_to_inferior_object fails.
6856
6857 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6858
6859         * inferior.h (class inferior) <displaced_step_state>: New field.
6860         * infrun.h (struct displaced_step_state): Move here from
6861         infrun.c.  Initialize fields, add constructor.
6862         <inf>: Remove field.
6863         <reset>: New method.
6864         * infrun.c (struct displaced_step_inferior_state): Move to
6865         infrun.h.
6866         (displaced_step_inferior_states): Remove.
6867         (get_displaced_stepping_state): Adust.
6868         (displaced_step_in_progress_any_inferior): Adjust.
6869         (displaced_step_in_progress_thread): Adjust.
6870         (displaced_step_in_progress): Adjust.
6871         (add_displaced_stepping_state): Remove.
6872         (get_displaced_step_closure_by_addr): Adjust.
6873         (remove_displaced_stepping_state): Remove.
6874         (infrun_inferior_exit): Call displaced_step_state.reset.
6875         (use_displaced_stepping): Don't check for NULL.
6876         (displaced_step_prepare_throw): Call
6877         get_displaced_stepping_state.
6878         (displaced_step_fixup): Don't check for NULL.
6879         (prepare_for_detach): Don't check for NULL.
6880
6881 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6882
6883         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6884          in case of call that did not complete.
6885
6886 2019-01-02  Andrey Utkin  <autkin@undo.io>
6887
6888         * symfile.c (find_separate_debug_file): Fix search of debug files for
6889         remote debuggee.
6890
6891 2019-01-02  Tom Tromey  <tom@tromey.com>
6892
6893         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6894         indentation.
6895         * python/py-frame.c (frapy_older): Remove cast.
6896         (frapy_newer): Likewise.
6897         * python/py-breakpoint.c (local_setattro): Remove cast.
6898         * python/py-arch.c (archpy_name): Remove local variable.
6899         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6900
6901 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6902
6903         * unittests/basic_string_view/element_access/char/empty.cc:
6904         Fix year range in copyright header.
6905
6906 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6907
6908         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6909         Delete.
6910         <operator==>: Update with for removed field.
6911         <hash>: Likewise.
6912         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6913         <isa_features>: ...this.
6914         <abi_features>: New field.
6915         (riscv_isa_flen): Update comment.
6916         (riscv_abi_xlen): New declaration.
6917         (riscv_abi_flen): New declaration.
6918         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6919         isa_features.
6920         (riscv_abi_xlen): New function.
6921         (riscv_isa_flen): Update to get answer from isa_features.
6922         (riscv_abi_flen): New function.
6923         (riscv_has_fp_abi): Update to get answer from abi_features.
6924         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6925         xlen and flen.
6926         (riscv_call_info) <xlen, flen>: Update comment.
6927         (riscv_call_arg_struct): Remove invalid assertions
6928         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6929         is removed.
6930         (riscv_gdbarch_init): Gather isa features and abi features
6931         separately, ensure both match on the gdbarch when reusing an old
6932         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6933         a target with 64-bit float hardware.
6934
6935 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6936
6937         * source.c (search_command_helper): Stop reverse search
6938         when line 1 has been searched.
6939
6940 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6941
6942         * record-full.c (record_full_base_target::close): Rewrite
6943         record_full_core_buf_list free logic.
6944
6945 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6946
6947         * break-catch-syscall.c (print_one_catch_syscall): xfree
6948         the last text.
6949
6950 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6951
6952         * top.c (print_gdb_version): Update Copyright year in version
6953         message.
6954
6955 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6956
6957         Update copyright year range in all GDB files.
6958
6959 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6960
6961         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6962
6963 For older changes see ChangeLog-2018.
6964 \f
6965 Local Variables:
6966 mode: change-log
6967 left-margin: 8
6968 fill-column: 74
6969 version-control: never
6970 coding: utf-8
6971 End:
6972