8454c09e94ffa5dfaaf9a4b240b0e8ef10523d90
[external/binutils.git] / gdb / ChangeLog
1 2017-05-24  Yao Qi  <yao.qi@linaro.org>
2
3         * Makefile.in (SFILES): Add gdbarch-selftests.c.
4         (COMMON_OBS): Add gdbarch-selftests.o.
5         * frame.c [GDB_SELF_TESTS] (create_new_frame): New function.
6         * frame.h [GDB_SELF_TESTS] (create_new_frame): Declare.
7         * gdbarch-selftests.c: New file.
8         * regcache.h (regcache) <~regcache>: Mark it virtual if
9         GDB_SELF_TEST.
10         <raw_write>: Likewise.
11
12 2017-05-24  Yao Qi  <yao.qi@linaro.org>
13
14         * regcache.c (current_regcache): Change it to
15         regcache::current_regcache.
16         (regcache_observer_target_changed): Update.
17         (regcache_thread_ptid_changed): Make it a regcache static
18         method.
19         (regcache_thread_ptid_changed): Update.
20         (class regcache_access): New.
21         (current_regcache_test): Update.
22         (_initialize_regcache): Update.
23         * regcache.h: Include forward_list.
24         (regcache): Declare regcache_thread_ptid_changed and declare
25         registers_changed_ptid as friend.
26
27 2017-05-24  Yao Qi  <yao.qi@linaro.org>
28
29         * i387-tdep.c (i387_register_to_value): Use register_size
30         instead of TYPE_LENGTH.
31         * m68k-tdep.c (m68k_register_to_value): Likewise.
32
33 2017-05-24  Yao Qi  <yao.qi@linaro.org>
34
35         * i387-tdep.c (i387_convert_register_p): Return false if type
36         code isn't TYPE_CODE_FLT.
37
38 2017-05-24  Yao Qi  <yao.qi@linaro.org>
39
40         * alpha-tdep.c (alpha_convert_register_p): Return true if type
41         length is 4.
42         (alpha_register_to_value): Remove type length check.
43         (alpha_value_to_register): Likewise.
44
45 2017-05-24  Yao Qi  <yao.qi@linaro.org>
46
47         * ia64-tdep.c (ia64_convert_register_p): Check type's code is
48         TYPE_CODE_FLT.
49
50 2017-05-24  Yao Qi  <yao.qi@linaro.org>
51
52         * m68k-tdep.c (m68k_convert_register_p): Check type's code is
53         TYPE_CODE_FLT or not.
54
55 2017-05-24  Yao Qi  <yao.qi@linaro.org>
56
57         * alpha-tdep.c (alpha_gdbarch_init): Use XCNEW instead of XNEW.
58         * avr-tdep.c (avr_gdbarch_init): Likewise.
59         * bfin-tdep.c (bfin_gdbarch_init): Likewise.
60         * cris-tdep.c (cris_gdbarch_init): Likewise.
61         * ft32-tdep.c (ft32_gdbarch_init): Likewise.
62         * lm32-tdep.c (lm32_gdbarch_init): Likewise.
63         * m32r-tdep.c (m32r_gdbarch_init): Likewise.
64         * m68hc11-tdep.c (m68hc11_gdbarch_init): Likewise.
65         * mep-tdep.c (mep_gdbarch_init): Likewise.
66         * microblaze-tdep.c (microblaze_gdbarch_init): Likewise.
67         * mips-tdep.c (mips_gdbarch_init): Likewise.
68         * mn10300-tdep.c (mn10300_gdbarch_init): Likewise.
69         * moxie-tdep.c (moxie_gdbarch_init): Likewise.
70         * msp430-tdep.c (msp430_gdbarch_init): Likewise.
71         * sh64-tdep.c (sh64_gdbarch_init): Likewise.
72         * v850-tdep.c (v850_gdbarch_init): Likewise.
73
74 2017-05-24  Yao Qi  <yao.qi@linaro.org>
75
76         * selftest-arch.c (tests_with_arch): Call registers_changed
77         and reinit_frame_cache.
78         * selftest.c (run_self_tests): Likewise.
79
80 2017-05-24  Yao Qi  <yao.qi@linaro.org>
81
82         * rs6000-tdep.c (gdb_print_insn_powerpc): Remove.
83         (rs6000_gdbarch_init): Don't call set_gdbarch_print_insn.
84
85 2017-05-24  Yao Qi  <yao.qi@linaro.org>
86
87         * rl78-tdep.c (rl78_gdbarch_init): Don't call
88         set_gdbarch_print_insn.
89
90 2017-05-24  Yao Qi  <yao.qi@linaro.org>
91
92         * h8300-tdep.c (h8300_gdbarch_init): Don't call
93         set_gdbarch_print_insn.
94
95 2017-05-24  Yao Qi  <yao.qi@linaro.org>
96
97         * alpha-tdep.c (alpha_gdbarch_init): Don't call
98         set_gdbarch_print_insn.
99         * arc-tdep.c (arc_gdbarch_init): Likewise.
100         * arch-utils.c: include dis-asm.h.
101         (default_print_insn): New function.
102         * arch-utils.h (default_print_insn): Declare.
103         * avr-tdep.c (avr_gdbarch_init): Don't call set_gdbarch_print_insn.
104         * bfin-tdep.c (bfin_gdbarch_init): Likewise.
105         * cris-tdep.c (cris_delayed_get_disassembler): Remove.
106         (cris_gdbarch_init): Don't call set_gdbarch_print_insn.
107         * frv-tdep.c (frv_gdbarch_init): Likewise.
108         * ft32-tdep.c (ft32_gdbarch_init): Likewise.
109         * gdbarch.sh (print_insn): Use default_print_insn.
110         * gdbarch.c: Regenerated.
111         * hppa-tdep.c (hppa_gdbarch_init): Likewise.
112         * iq2000-tdep.c (iq2000_gdbarch_init): Likewise.
113         * lm32-tdep.c (lm32_gdbarch_init): Likewise.
114         * m32c-tdep.c (m32c_gdbarch_init): Likewise.
115         * m32r-tdep.c (m32r_gdbarch_init): Likewise.
116         * m68hc11-tdep.c (gdb_print_insn_m68hc11): Remove.
117         (m68hc11_gdbarch_init): Don't call set_gdbarch_print_insn.
118         * m68k-tdep.c (m68k_gdbarch_init): Likewise.
119         * m88k-tdep.c (m88k_gdbarch_init): Likewise.
120         * microblaze-tdep.c (microblaze_gdbarch_init): Likewise.
121         * mn10300-tdep.c (mn10300_gdbarch_init): Likewise.
122         * moxie-tdep.c (moxie_gdbarch_init): Likewise.
123         * msp430-tdep.c (msp430_gdbarch_init): Likewise.
124         * mt-tdep.c (mt_gdbarch_init): Likewise.
125         * nds32-tdep.c (nds32_gdbarch_init): Likewise.
126         * nios2-tdep.c (nios2_print_insn): Remove.
127         (nios2_gdbarch_init): Don't call set_gdbarch_print_insn.
128         * rx-tdep.c (rx_gdbarch_init): Likewise.
129         * s390-linux-tdep.c (s390_gdbarch_init): Likewise.
130         * score-tdep.c (score_print_insn): Remove.
131         (score_gdbarch_init): Don't call set_gdbarch_print_insn.
132         * sh-tdep.c (sh_gdbarch_init): Likewise.
133         * sh64-tdep.c (sh64_gdbarch_init): Likewise.
134         * sparc-tdep.c (sparc32_gdbarch_init): Likewise.
135         * tic6x-tdep.c (tic6x_print_insn): Remove.
136         (tic6x_gdbarch_init): Don't call set_gdbarch_print_insn.
137         * tilegx-tdep.c (tilegx_gdbarch_init): Likewise.
138         * v850-tdep.c (v850_gdbarch_init): Likewise.
139         * vax-tdep.c (vax_gdbarch_init): Likewise.
140         * xstormy16-tdep.c (xstormy16_gdbarch_init): Likewise.
141         * xtensa-tdep.c (xtensa_gdbarch_init): Likewise.
142
143 2017-05-23  John Baldwin  <jhb@FreeBSD.org>
144
145         * mips-fbsd-tdep.c (MIPS_PC_REGNUM): Remove.
146         (MIPS_FP0_REGNUM): Remove.
147         (MIPS_FSR_REGNUM): Remove.
148         (mips_fbsd_supply_fpregs): Use mips_regnum.
149         (mips_fbsd_supply_gregs): Likewise.
150         (mips_fbsd_collect_fpregs): Likewise.
151         (mips_fbsd_collect_gregs): Likewise.
152
153 2017-05-23  John Baldwin  <jhb@FreeBSD.org>
154
155         * mips-fbsd-nat.c (getregs_supplies): Fix upper bound comparison.
156         (getpfpregs_supplies): New function.
157         (mips_fbsd_fetch_inferior_registers): Remove early exit and use
158         getfpregs_supplies.
159         (mips_fbsd_store_inferior_registers): Likewise.
160
161 2017-05-22  Pedro Alves <palves@redhat.com>
162
163         * MAINTAINERS (Host/Native): Add John Baldwin as FreeBSD
164         maintainer.
165
166 2017-05-22  Alan Hayward  <alan.hayward@arm.com>
167
168         * ppc-linux-nat.c (fetch_register): Use PPC_MAX_REGISTER_SIZE.
169         (store_register): Likewise.
170         * ppc-sysv-tdep.c (ppc_sysv_abi_push_dummy_call): Likewise.
171         (get_decimal_float_return_value): Likewise.
172         (do_ppc_sysv_return_value): Likewise.
173         (ppc64_sysv_abi_push_integer): Likewise.
174         (ppc64_sysv_abi_push_freg): Likewise.
175         (ppc64_sysv_abi_return_value_base): Likewise.
176         (ppc64_sysv_abi_return_value): Likewise.
177         * rs6000-aix-tdep.c (rs6000_push_dummy_call): Likewise.
178         * rs6000-lynx178-tdep.c (rs6000_lynx178_push_dummy_call): Likewise.
179         * rs6000-nat.c: Likewise.
180         * rs6000-tdep.c (rs6000_register_to_value): Likewise.
181         (rs6000_value_to_register): Likewise.
182         * ppc-tdep.h (PPC_MAX_REGISTER_SIZE): Add.
183
184 2017-05-21  Tom Tromey  <tom@tromey.com>
185
186         PR rust/21466:
187         * rust-lang.c (rust_print_type) <TYPE_CODE_ARRAY>: Print unsized
188         arrays as "[T]", not "[T; ]".
189
190 2017-05-19  Tom Tromey  <tom@tromey.com>
191
192         PR rust/21484:
193         * rust-lang.c (exp_descriptor_rust): New function.
194         (rust_language_defn): Use it.
195         * p-lang.c (pascal_language_defn): Update.
196         * opencl-lang.c (opencl_language_defn): Update.
197         * objc-lang.c (objc_language_defn): Update.
198         * m2-lang.c (m2_language_defn): Update.
199         * language.h (struct language_defn)
200         <la_watch_location_expression>: New member.
201         * language.c (unknown_language_defn, auto_language_defn)
202         (local_language_defn): Update.
203         * go-lang.c (go_language_defn): Update.
204         * f-lang.c (f_language_defn): Update.
205         * d-lang.c (d_language_defn): Update.
206         * c-lang.h (c_watch_location_expression): Declare.
207         * c-lang.c (c_watch_location_expression): New function.
208         (c_language_defn, cplus_language_defn, asm_language_defn)
209         (minimal_language_defn): Use it.
210         * breakpoint.c (watch_command_1): Call
211         la_watch_location_expression.
212         * ada-lang.c (ada_language_defn): Update.
213
214 2017-05-19  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
215
216         PR tui/21482
217         * gdb_curses.h (NOMACROS): Define.
218         (NCURSES_NOMACROS): Define.
219
220 2017-05-19  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
221
222         PR tui/21482
223         * tui/tui-windata.c (tui_erase_data_content): Cast last mvwaddstr
224         arg to char *.
225         * tui/tui-wingeneral.c (box_win): Likewise.
226         * tui/tui-winsource.c (tui_erase_source_content): Likewise.
227         (tui_show_source_line): Likewise.
228         (tui_show_exec_info_content): Likewise.
229
230 2017-05-19  Vladimir Mezentsev  <vladimir.mezentsev@oracle.com>
231
232         * sparc-tdep.c (sparc_structure_return_p)
233         (sparc_arg_on_registers_p): New functions.
234         (sparc32_store_arguments): Use them.
235         * sparc64-tdep.c (sparc64_16_byte_align_p)
236         (sparc64_store_floating_fields, sparc64_extract_floating_fields):
237         Handle TYPE_CODE_ARRAY.
238
239 2017-05-17  Yao Qi  <yao.qi@linaro.org>
240
241         * cli/cli-decode.c (add_alias_cmd): New function.
242         * command.h (add_alias_cmd): Declare.
243         * infcmd.c (_initialize_infcmd): Don't call add_com_alias,
244         instead call add_alias_cmd.
245
246 2017-05-17  Pedro Alves  <palves@redhat.com>
247
248         * Makefile.in (nat_extra_makefile_frag): Rename to ...
249         (nat_makefile_frag): ... this.  All references updated.
250         * configure.ac: Likewise.
251         * configure.nat: Likewise.  Enhance comments.
252         * configure: Regenerate.
253
254 2017-05-15  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
255
256         * procfs.c (procfs_create_inferior): Change prototype to match
257         definition.
258
259 2017-05-13  Eli Zaretskii  <eliz@gnu.org>
260
261         * tui/tui.c (tui_enable): Cast "unknown" to 'char *' to avoid a
262         C++ compiler warning.
263
264 2017-05-12  Tom Tromey  <tom@tromey.com>
265
266         PR rust/21483:
267         * rust-lang.c (rust_evaluate_subexp) <STRUCTOP_STRUCT>: Don't
268         recurse, just call value_struct_elt directly.
269
270 2017-05-12  Tom Tromey  <tom@tromey.com>
271
272         * rust-lang.c (rust_dump_subexp_body) <STRUCTOP_ANONYMOUS,
273         OP_RUST_ARRAY>: Fix.
274
275 2017-05-12  Tom Tromey  <tom@tromey.com>
276
277         * rust-lang.c (rust_print_subexp): Replace "return" with "break".
278
279 2017-05-09  Yao Qi  <yao.qi@linaro.org>
280
281         * regcache.c: Include <forward_list>.
282         (struct regcache_list): Remove.
283         (current_regcache): Update.
284         (get_thread_arch_aspace_regcache): Update for std::forward_list.
285         (regcache_thread_ptid_changed): Likewise.
286         (registers_changed_ptid): Likewise.
287         (current_regcache_size): Likewise.
288
289 2017-05-09  Yao Qi  <yao.qi@linaro.org>
290
291         * regcache.c [GDB_SELF_TEST]: Include selftest.h.
292         (current_regcache_size): New function.
293         (current_regcache_test): New function.
294         (_initialize_regcache) [GDB_SELF_TEST]: Register the unit test.
295
296 2017-05-08  Alan Hayward  <alan.hayward@arm.com>
297
298         * mips-tdep.c (mips_o32_return_value): Remove unused buffer.
299         (print_gp_register_row): Use get_frame_register_value.
300
301 2017-05-08  Alan Hayward  <alan.hayward@arm.com>
302
303         * mips-linux-tdep.c (mips_supply_gregset): Use raw_supply_zeroed.
304         (mips_supply_fpregset): Likewise.
305         (mips64_supply_gregset): Likewise.
306
307 2017-05-08  Alan Hayward  <alan.hayward@arm.com>
308
309         * mn10300-linux-tdep.c (am33_supply_gregset_method): Use 
310         regcache->raw_supply_zeroed.
311
312 2017-05-06  Sergio Durigan Junior  <sergiodj@redhat.com>
313
314         * configure.nat: Rearrange 'case' statements to match
315         host before cpu.
316
317 2017-05-06  Sergio Durigan Junior  <sergiodj@redhat.com>
318
319         * Makefile.in: Remove "@host_makefile_frag@".  Add variables
320         NAT_FILE, NATDEPFILES, NAT_CDEPS, LOADLIBES, MH_CFLAGS, XM_CLIBS,
321         NAT_GENERATED_FILES, HAVE_NATIVE_GCORE_HOST.  Add
322         "@nat_extra_makefile_frag@".
323         (Makefile): Remove dependency on "@frags@".
324         ($(GNULIB_BUILDDIR)/Makefile): Likewise.
325         (data-directory/Makefile): Likewise.
326         * config/aarch64/linux.mh: Deleted; moved contents to
327         "gdb/configure.nat".
328         * config/alpha/alpha-linux.mh: Likewise.
329         * config/alpha/nbsd.mh: Likewise.
330         * config/arm/linux.mh: Likewise.
331         * config/arm/nbsdelf.mh: Likewise.
332         * config/i386/cygwin.mh: Likewise.
333         * config/i386/cygwin64.mh: Likewise.
334         * config/i386/darwin.mh: Likewise.
335         * config/i386/fbsd.mh: Likewise.
336         * config/i386/fbsd64.mh: Likewise.
337         * config/i386/go32.mh: Likewise.
338         * config/i386/i386gnu.mh: Likewise.
339         * config/i386/i386sol2.mh: Likewise.
340         * config/i386/linux.mh: Likewise.
341         * config/i386/linux64.mh: Likewise.
342         * config/i386/mingw.mh: Likewise.
343         * config/i386/mingw64.mh: Likewise.
344         * config/i386/nbsd64.mh: Likewise.
345         * config/i386/nbsdelf.mh: Likewise.
346         * config/i386/nto.mh: Likewise.
347         * config/i386/obsd.mh: Likewise.
348         * config/i386/obsd64.mh: Likewise.
349         * config/i386/sol2-64.mh: Likewise.
350         * config/ia64/linux.mh: Likewise.
351         * config/m32r/linux.mh: Likewise.
352         * config/m68k/linux.mh: Likewise.
353         * config/m68k/nbsdelf.mh: Likewise.
354         * config/m68k/obsd.mh: Likewise.
355         * config/m88k/obsd.mh: Likewise.
356         * config/mips/fbsd.mh: Likewise.
357         * config/mips/linux.mh: Likewise.
358         * config/mips/nbsd.mh: Likewise.
359         * config/mips/obsd64.mh: Likewise.
360         * config/pa/linux.mh: Likewise.
361         * config/pa/nbsd.mh: Likewise.
362         * config/pa/obsd.mh: Likewise.
363         * config/powerpc/aix.mh: Likewise.
364         * config/powerpc/fbsd.mh: Likewise.
365         * config/powerpc/linux.mh: Likewise.
366         * config/powerpc/nbsd.mh: Likewise.
367         * config/powerpc/obsd.mh: Likewise.
368         * config/powerpc/ppc64-linux.mh: Likewise.
369         * config/powerpc/spu-linux.mh: Likewise.
370         * config/s390/linux.mh: Likewise.
371         * config/sh/nbsd.mh: Likewise.
372         * config/sparc/fbsd.mh: Likewise.
373         * config/sparc/linux.mh: Likewise.
374         * config/sparc/linux64.mh: Likewise.
375         * config/sparc/nbsd64.mh: Likewise.
376         * config/sparc/nbsdelf.mh: Likewise.
377         * config/sparc/obsd64.mh: Likewise.
378         * config/sparc/sol2.mh: Likewise.
379         * config/tilegx/linux.mh: Likewise.
380         * config/vax/nbsdelf.mh: Likewise.
381         * config/vax/obsd.mh: Likewise.
382         * config/xtensa/linux.mh: Likewise.
383         * config/i386/i386gnu.mn: New file, with excerpts from
384         "config/i386/i386gnu.mh".
385         * configure: Regenerate.
386         * configure.ac: Rewrite code to use "gdb/configure.nat" instead of
387         *.mh files under "gdb/config".
388         * configure.nat: New file, with contents from the
389         "gdb/config/*/*.mh" files.
390
391 2017-05-05  Tim Wiederhake  <tim.wiederhake@intel.com>
392
393         * btrace.c (btrace_clear): Free insn vector.
394
395 2017-05-05  Pedro Alves  <palves@redhat.com>
396
397         * warning.m4 (build_warnings): Add -Wno-error=maybe-uninitialized.
398         * configure: Regenerate.
399
400 2017-05-04  Pedro Alves  <palves@redhat.com>
401
402         * Makefile.in (SFILES): Add progspace-and-thread.c.
403         (HFILES_NO_SRCDIR): Add progspace-and-thread.h.
404         (COMMON_OBS): Add progspace-and-thread.o.
405         * breakpoint.c: Include "progspace-and-thread.h".
406         (update_inserted_breakpoint_locations)
407         (insert_breakpoint_locations, create_longjmp_master_breakpoint):
408         Use scoped_restore_current_pspace_and_thread.
409         (create_std_terminate_master_breakpoint): Use
410         scoped_restore_current_program_space.
411         (remove_breakpoint): Use scoped_restore_current_pspace_and_thread.
412         (print_breakpoint_location): Use
413         scoped_restore_current_program_space.
414         (bp_loc_is_permanent): Use
415         scoped_restore_current_pspace_and_thread.
416         (resolve_sal_pc): Use scoped_restore_current_pspace_and_thread.
417         (download_tracepoint_locations): Use
418         scoped_restore_current_pspace_and_thread.
419         (breakpoint_re_set): Use scoped_restore_current_pspace_and_thread.
420         * exec.c (exec_close_1): Use scoped_restore_current_program_space.
421         (enum step_over_calls_kind): Moved from inferior.h.
422         (class scoped_restore_current_thread): New class.
423         * gdbthread.h (make_cleanup_restore_current_thread): Delete
424         declaration.
425         (scoped_restore_current_thread): New class.
426         * infcmd.c: Include "common/gdb_optional.h".
427         (continue_1, proceed_after_attach): Use
428         scoped_restore_current_thread.
429         (notice_new_inferior): Use scoped_restore_current_thread.
430         * inferior.c: Include "progspace-and-thread.h".
431         (restore_inferior, save_current_inferior): Delete.
432         (add_inferior_command, clone_inferior_command): Use
433         scoped_restore_current_pspace_and_thread.
434         * inferior.h (scoped_restore_current_inferior): New class.
435         * infrun.c: Include "progspace-and-thread.h" and
436         "common/gdb_optional.h".
437         (follow_fork_inferior): Use
438         scoped_restore_current_pspace_and_thread.
439         (scoped_restore_exited_inferior): New class.
440         (handle_vfork_child_exec_or_exit): Use
441         scoped_restore_exited_inferior,
442         scoped_restore_current_pspace_and_thread,
443         scoped_restore_current_thread and scoped_restore.
444         (fetch_inferior_event): Use scoped_restore_current_thread.
445         * linespec.c (decode_line_full, decode_line_1): Use
446         scoped_restore_current_program_space.
447         * mi/mi-main.c: Include "progspace-and-thread.h".
448         (exec_continue): Use scoped_restore_current_thread.
449         (mi_cmd_exec_run): Use scoped_restore_current_pspace_and_thread.
450         (mi_cmd_trace_frame_collected): Use scoped_restore_current_thread.
451         * proc-service.c (ps_pglobal_lookup): Use
452         scoped_restore_current_program_space.
453         * progspace-and-thread.c: New file.
454         * progspace-and-thread.h: New file.
455         * progspace.c (release_program_space, clone_program_space): Use
456         scoped_restore_current_program_space.
457         (restore_program_space, save_current_program_space)
458         (save_current_space_and_thread): Delete.
459         (switch_to_program_space_and_thread): Moved to
460         progspace-and-thread.c.
461         * progspace.h (save_current_program_space)
462         (save_current_space_and_thread): Delete declarations.
463         (scoped_restore_current_program_space): New class.
464         * remote.c (remote_btrace_maybe_reopen): Use
465         scoped_restore_current_thread.
466         * symtab.c: Include "progspace-and-thread.h".
467         (skip_prologue_sal): Use scoped_restore_current_pspace_and_thread.
468         * thread.c (print_thread_info_1): Use
469         scoped_restore_current_thread.
470         (struct current_thread_cleanup): Delete.
471         (do_restore_current_thread_cleanup)
472         (restore_current_thread_cleanup_dtor): Rename/convert both to ...
473         (scoped_restore_current_thread::~scoped_restore_current_thread):
474         ... this new dtor.
475         (make_cleanup_restore_current_thread): Rename/convert to ...
476         (scoped_restore_current_thread::scoped_restore_current_thread):
477         ... this new ctor.
478         (thread_apply_all_command): Use scoped_restore_current_thread.
479         (thread_apply_command): Use scoped_restore_current_thread.
480         * tracepoint.c (tdump_command): Use scoped_restore_current_thread.
481         * varobj.c (value_of_root_1): Use scoped_restore_current_thread.
482
483 2017-05-04  Pedro Alves  <palves@redhat.com>
484
485         * thread.c (make_cleanup_restore_current_thread): Move
486         find_thread_ptid call before the is_stopped call.  Assert that the
487         thread is found.  Replace is_stopped call by checking the thread's
488         state directly.  Remove unnecessary NULL-thread check.
489
490 2017-05-04  Pedro Alves  <palves@redhat.com>
491
492         * corelow.c (thread_section_name): New class.
493         (get_core_register_section, get_core_siginfo): Use it.
494
495 2017-05-04  Andreas Arnez  <arnez@linux.vnet.ibm.com>
496
497         * corelow.c (sniff_core_bfd): Remove extra semicolon.
498         (get_core_register_section): Remove xfree of NULL pointer.
499
500 2017-05-03  Alan Hayward  <alan.hayward@arm.com>
501
502         * frv-linux-tdep.c (frv_linux_supply_gregset): Use raw_supply_zeroed.
503         * regcache.c (regcache::raw_supply_zeroed): New function.
504         * regcache.h (regcache::raw_supply_zeroed): New declaration.
505
506 2017-05-03  Simon Marchi  <simon.marchi@ericsson.com>
507
508         * gdbarch.sh: Remove commented out definition of
509         TARGET_CHAR_BIT.
510         * gdbarch.h: Re-generate.
511
512 2017-05-03  Sergio Durigan Junior  <sergiodj@redhat.com>
513
514         * configure: Regenerate.
515
516 2017-05-02  Simon Marchi  <simon.marchi@ericsson.com>
517
518         * solib-target.c (solib_target_relocate_section_addresses):
519         Remove num_section_bases, num_bases, segment_bases variables.
520
521 2017-05-02  Simon Marchi  <simon.marchi@polymtl.ca>
522
523         * common/gdb_vecs.h (DEF_VEC_I (CORE_ADDR)): Remove.
524
525 2017-05-02  Simon Marchi  <simon.marchi@polymtl.ca>
526
527         * solib-target.c: Include <vector>
528         (struct lm_info_target) <~lm_info_target>: Remove.
529         <segment_bases, section_bases>: Change type to
530         std::vector<CORE_ADDR>.
531         (library_list_start_segment, library_list_start_section,
532         library_list_end_library,
533         solib_target_relocate_section_addresses): Adjust.
534
535 2017-05-02  Simon Marchi  <simon.marchi@polymtl.ca>
536
537         * gdbarch.sh (software_single_step): Change return type to
538         std::vector<CORE_ADDR>.
539         * gdbarch.c, gdbarch.h: Re-generate.
540         * arch/arm-get-next-pcs.c (thumb_deal_with_atomic_sequence_raw):
541         Adjust.
542         (arm_deal_with_atomic_sequence_raw): Adjust.
543         (thumb_get_next_pcs_raw): Adjust.
544         (arm_get_next_pcs_raw): Adjust.
545         (arm_get_next_pcs): Adjust.
546         * arch/arm-get-next-pcs.h (arm_get_next_pcs): Adjust.
547         * aarch64-tdep.c (aarch64_software_single_step): Adjust.
548         * alpha-tdep.c (alpha_deal_with_atomic_sequence): Adjust.
549         (alpha_software_single_step): Adjust.
550         * alpha-tdep.h (alpha_software_single_step): Adjust.
551         * arm-linux-tdep.c (arm_linux_software_single_step): Adjust.
552         * arm-tdep.c (arm_software_single_step): Adjust.
553         (arm_breakpoint_kind_from_current_state): Adjust.
554         * arm-tdep.h (arm_software_single_step): Adjust.
555         * breakpoint.c (insert_single_step_breakpoint): Adjust.
556         * cris-tdep.c (cris_software_single_step): Adjust.
557         * mips-tdep.c (mips_deal_with_atomic_sequence): Adjust.
558         (micromips_deal_with_atomic_sequence): Adjust.
559         (deal_with_atomic_sequence): Adjust.
560         (mips_software_single_step): Adjust.
561         * mips-tdep.h (mips_software_single_step): Adjust.
562         * moxie-tdep.c (moxie_software_single_step): Adjust.
563         * nios2-tdep.c (nios2_software_single_step): Adjust.
564         * ppc-tdep.h (ppc_deal_with_atomic_sequence): Adjust.
565         * rs6000-aix-tdep.c (rs6000_software_single_step): Adjust.
566         * rs6000-tdep.c (ppc_deal_with_atomic_sequence): Adjust.
567         * s390-linux-tdep.c (s390_software_single_step): Adjust.
568         * sparc-tdep.c (sparc_software_single_step): Adjust.
569         * spu-tdep.c (spu_software_single_step): Adjust.
570         * tic6x-tdep.c (tic6x_software_single_step): Adjust.
571
572 2017-05-02  Simon Marchi  <simon.marchi@polymtl.ca>
573
574         * gdbarch.sh: Use semi-colon as field separator instead of colon.
575         * gdbarch.h: Re-generate.
576
577 2017-05-01  Tim Wiederhake  <tim.wiederhake@intel.com>
578
579         * Makefile.in (SUBDIR_PYTHON_OBS): Add py-instruction.o.
580         (SUBDIR_PYTHON_SRCS): Add py-instruction.c.
581         * python/py-instruction.c, python/py-instruction.h: New file.
582         * python/py-record.c: Add py-instruction.h include.
583         (gdbpy_initialize_record): Make gdb.Instruction a super class of
584         gdb.RecordInstruction.
585         * python/python-internal.h: Add gdbpy_initialize_instruction
586         declaration.
587         * python/python.c (do_start_initialization): Add
588         gdbpy_initialize_instruction.
589
590 2017-05-01  Tim Wiederhake  <tim.wiederhake@intel.com>
591
592         * python/py-record-btrace.c (BTPY_REQUIRE_VALID_CALL, btpy_call_type):
593         Remove.
594         (btrace_func_from_recpy_func): New function.
595         (btpy_call_new, btpy_number, btpy_hash, btpy_richcompare): Remove.
596         (btpy_call_level, btpy_call_symbol, btpy_call_instructions,
597         btpy_call_up, btpy_call_prev_sibling, btpy_call_next_sibling): Rename to ...
598         (recpy_bt_func_level, recpy_bt_func_symbol, recpy_bt_func_instructions,
599         recpy_bt_func_up, recpy_bt_func_prev, recpy_bt_func_next): This.
600         Also, use new helper functions.
601         (btpy_list_item): Use new helper functions.
602         (recpy_bt_function_call_history): Use new type name.
603         (btpy_call_getset): Remove.
604         (gdbpy_initialize_btrace): Remove code to initialize
605         gdb.BtraceFunctionCall.
606         * python/py-record-btrace.h (recpy_bt_func_number, recpy_btb_func_level,
607         recpy_btb_func_symbol, recpy_bt_func_instructions, recpy_bt_func_up,
608         recpy_bt_func_prev, recpy_bt_func_next): New export.
609         * python/py-record.c (recpy_func_type): New static object.
610         (recpy_func_new, recpy_func_level, recpy_func_symbol,
611         recpy_func_instructions, recpy_func_up, recpy_func_prev,
612         recpy_func_next): New function.
613         (recpy_element_hash, recpy_element_richcompare): Updated comment.
614         (recpy_func_getset): New static object.
615         (gdbpy_initialize_record): Add code to initialize gdb.RecordInstruction.
616         * python/py-record.h (recpy_func_type, recpy_func_new): New export.
617
618 2017-05-01  Tim Wiederhake  <tim.wiederhake@intel.com>
619
620         * python/py-record-btrace.c (BTPY_REQUIRE_VALID_INSN): Remove.
621         (btpy_object, btpy_insn_type, btpy_new): Remove.
622         (btpy_list_object): Use gdb.RecordInstruction type instead of
623         gdb.BtraceInstruction type.
624         (btrace_insn_from_recpy_insn): New function.
625         (btpy_insn_or_gap_new): Adjust comment. Use recpy_insn_new instead of
626         btpy_new.
627         (btpy_call_new, btpy_list_item): Do not use btpy_new anymore.
628         (btpy_number, btpy_hash, btpy_call_level, btpy_call_symbol,
629         btpy_call_instructions, btpy_call_up, btpy_call_prev_sibling,
630         btpy_call_next_sibling, btpy_richcompare): Use recpy_element_object
631         instead of btpy_object.
632         (btpy_insn_sal, btpy_insn_pc, btpy_insn_size, btpy_insn_is_speculative,
633         btpy_insn_data, btpy_insn_decode): Rename to ...
634         (recpy_bt_insn_sal, recpy_bt_insn_pc, recpy_bt_insn_size,
635         recpy_bt_insn_is_speculative, recpy_bt_insn_data,
636         recpy_bt_insn_decode): This.  Also, use new helper functions.
637         (btpy_list_position, recpy_bt_goto): Use recpy_element_object and
638         recpy_insn_type.
639         (btpy_insn_getset): Remove.
640         (gdbpy_initialize_btrace): Remove code to initialize
641         gdb.BtraceInstruction.  Use recpy_element_object.
642         * python/py-record-btrace.h (recpy_bt_insn_number, recpy_bt_insn_sal,
643         recpy_bt_insn_pc, recpy_bt_insn_data, recpy_bt_insn_decoded,
644         recpy_bt_insn_size, recpy_bt_insn_is_speculative): New export.
645         * python/py-record.c (recpy_insn_type): New static object.
646         (recpy_insn_new, recpy_insn_sal, recpy_insn_pc, recpy_insn_data,
647         recpy_insn_decoded, recpy_insn_size, recpy_insn_is_speculative,
648         recpy_element_number, recpy_element_hash, recpy_element_richcompare):
649         New function.
650         (recpy_insn_getset): New static object.
651         (gdbpy_initialize_record): Initialize gdb.RecordInstruction.
652         * python/py-record.h (recpy_element_object): New typedef.
653         (recpy_insn_type, recpy_insn_new): New export.
654
655 2017-05-01  Tim Wiederhake  <tim.wiederhake@intel.com>
656
657         * py-record-btrace.c (btpy_insn_new): Removed.
658         (btpy_insn_or_gap_new): New function.
659         (btpy_insn_error): Removed.
660         (btpy_insn_sal, btpy_insn_pc, btpy_insn_size, btpy_insn_is_speculative,
661         btpy_insn_data, btpy_insn_decode): Remove code path for gaps.
662         (recpy_bt_replay_position, recpy_bt_begin, recpy_bt_end): Call
663         btpy_insn_or_gap_new instead of btpy_insn_new.
664         (btpy_insn_getset): Remove btpy_insn_error.
665         * py-record.c (recpy_gap_type): New static object.
666         (recpy_gap_object): New typedef.
667         (recpy_gap_new, recpy_gap_number, recpy_gap_reason_code,
668         recpy_gap_reason_string): New function.
669         (recpy_gap_getset): New static object.
670         (gdbpy_initialize_record): Initialize gdb.RecordGap type.
671         * py-record.h (recpy_gap_new): New export.
672
673 2017-05-01  Tim Wiederhake  <tim.wiederhake@intel.com>
674
675         * python/py-record.c (recpy_ptid): Remove.
676         (recpy_record_getset): Remove recpy_ptid.
677
678 2017-05-01  Tim Wiederhake  <tim.wiederhake@intel.com>
679
680         * btrace.c (btrace_fetch): Set inferior_ptid.
681         * python/py-record-btrace.c: Add "py-record.h" include.
682         (recpy_bt_format, recpy_bt_replay_position, recpy_bt_begin,
683         recpy_bt_end, recpy_bt_instruction_history,
684         recpy_bt_function_call_history, recpy_bt_goto): Use ptid stored
685         in gdb.Record object instead of current ptid.
686         * python/py-record.c: Include new "py-record.h" file.
687         (recpy_record_object): Moved to py-record.h.
688         * python/py-record.h: New file.
689
690 2017-05-01  Tim Wiederhake  <tim.wiederhake@intel.com>
691
692         * python/py-record-btrace.c (BTPY_REQUIRE_VALID_INSN,
693         BTPY_REQUIRE_VALID_CALL, recpy_bt_function_call_history): Fix
694         indentation.
695
696 2017-05-01  Joel Brobecker  <brobecker@adacore.com>
697
698         * MAINTAINERS: Move Daniel Jacobowitz and Mark Kettenis to
699         the past maintainers section.
700
701 2017-04-28  Yao Qi  <yao.qi@linaro.org>
702
703         * infcmd.c (get_return_value): Use regcache ctor, and remove
704         cleanup.
705
706 2017-04-28  Yao Qi  <yao.qi@linaro.org>
707             Pedro Alves  <palves@redhat.com>
708
709         * regcache.c (regcache::regcache): New tag dispatch ctor.
710         (do_cooked_read): Moved above.
711         (regcache_dup): Use the tag dispatch ctor..
712         * regcache.h (regcache): Declare ctor, delete copy ctor and
713         assignment operator, remove friend regcache_dup.
714
715 2017-04-28  Yao Qi  <yao.qi@linaro.org>
716
717         * regcache.c (regcache_dup): Assert !src->m_readonly_p and
718         call method save instead of regcache_cpy.
719         * regcache.h (struct regcache): Make regcache_dup a friend.
720
721 2017-04-28  Yao Qi  <yao.qi@linaro.org>
722
723         * regcache.c (struct regcache): Move to regcache.h
724         (regcache::arch): New method.
725         (regcache_get_ptid): Update.
726         (get_regcache_arch): Call arch method.
727         (get_regcache_aspace): Call method aspace.
728         (register_buffer): Change it to method.
729         (regcache_save): Change it to regcache::save.
730         (regcache_restore): Likewise.
731         (regcache_cpy_no_passthrough): Remove the declaration.
732         (regcache_cpy): Call methods restore and cpy_no_passthrough.
733         (regcache_cpy_no_passthrough): Change it to method
734         cpy_no_passthrough.
735         (regcache_register_status): Change it to method
736         get_register_status.
737         (regcache_invalidate): Change it to method invalidate.
738         (regcache_thread_ptid_changed): Use methods ptid and set_ptid.
739         (regcache_raw_update): Change it to method raw_update.
740         (regcache_raw_read): Likewise.
741         (regcache_raw_read_signed): Likewise.
742         (regcache_raw_read_unsigned): Likewise.
743         (regcache_raw_write_signed): Likewise.
744         (regcache_raw_write_unsigned): Likewise.
745         (regcache_cooked_read): Likewise.
746         (regcache_cooked_read_value): Likewise.
747         (regcache_cooked_read_signed): Likewise.
748         (regcache_cooked_read_unsigned): Likewise.
749         (regcache_cooked_write_signed): Likewise.
750         (regcache_cooked_write_unsigned): Likewise.
751         (regcache_raw_set_cached_value): Likewise.
752         (regcache_raw_write): Likewise.
753         (regcache_cooked_write): Likewise.
754         (regcache_xfer_part): Likewise.
755         (regcache_raw_read_part): Likewise.
756         (regcache_raw_write_part): Likewise.
757         (regcache_cooked_read_part): Likewise.
758         (regcache_cooked_write_part): Likewise.
759         (regcache_raw_supply): Likewise.
760         (regcache_raw_collect): Likewise.
761         (regcache_transfer_regset): Likewise.
762         (regcache_supply_regset): Likewise.
763         (regcache_collect_regset): Likewise.
764         (regcache_debug_print_register): Likewise.
765         (enum regcache_dump_what): Move it to regcache.h.
766         (regcache_dump): Change it to method dump.
767         * regcache.h (enum regcache_dump_what): New.
768         (class regcache): New.
769         * target.c (target_fetch_registers): Call method
770         debug_print_register.
771         (target_store_registers): Likewise.
772
773 2017-04-28  Simon Marchi  <simon.marchi@ericsson.com>
774
775         * windows-nat.c (struct lm_info_windows): Initialize field.
776         (windows_make_so): Allocate lm_info_windows with new.
777         (windows_free_so): Free lm_info_windows with delete.
778
779 2017-04-28  Simon Marchi  <simon.marchi@ericsson.com>
780
781         * solib-darwin.c (struct lm_info_darwin): Initialize field.
782         (darwin_current_sos): Allocate lm_info_darwin with new, remove
783         cleanup.
784         (darwin_free_so): Free lm_info_darwin with delete.
785
786 2017-04-28  Simon Marchi  <simon.marchi@ericsson.com>
787
788         * solib-svr4.h (struct lm_info_svr4): Initialize fields.
789         <l_addr_p>: Change type to bool.
790         * solib-svr4.c (lm_info_read): Allocate lm_info_svr4 with new.
791         (svr4_free_so): Free lm_info_svr4 with delete.
792         (svr4_copy_library_list): Replace memcpy with call to copy
793         constructor.
794         (library_list_start_library, svr4_default_sos): Allocate
795         lm_info_svr4 with new.
796
797 2017-04-28  Simon Marchi  <simon.marchi@ericsson.com>
798
799         * solib-target.c (struct lm_info_target): Add destructor,
800         initialize fields.
801         <name>: Change type to std::string.
802         (library_list_start_library): Allocate lm_info_target with new.
803         (solib_target_free_library_list): Free lm_info_target with
804         delete.
805         (solib_target_current_sos): Adapt to std::string.
806         (solib_target_free_so): Free lm_info_target with delete.
807
808 2017-04-28  Simon Marchi  <simon.marchi@ericsson.com>
809
810         * solib-frv.c (struct lm_info_frv): Add destructor, initialize
811         fields.
812         (frv_current_sos): Allocate lm_info_frv with new.
813         (frv_relocate_main_executable): Free lm_info_frv with delete,
814         allocate with new.
815         (frv_clear_solib, frv_free_so): Free lm_info_frv with delete.
816
817 2017-04-28  Simon Marchi  <simon.marchi@ericsson.com>
818
819         * solib-frv.c (struct lm_info_frv): Fix indentation.
820
821 2017-04-28  Simon Marchi  <simon.marchi@ericsson.com>
822
823         * solib-dsbt.c (struct lm_info_dsbt): Add destructor, initialize
824         map field.
825         (dsbt_current_sos): Allocate lm_info_dsbt with new.
826         (dsbt_relocate_main_executable): Free lm_info_dsbt with delete
827         and allocate with new.
828         (dsbt_clear_solib, dsbt_free_so): Free lm_info_dsbt with delete.
829
830 2017-04-28  Simon Marchi  <simon.marchi@ericsson.com>
831
832         * solib-aix.c (struct lm_info_aix): Initialize fields in-class.
833         <filename, member_name>: Change type to std::string.
834         (solib_aix_new_lm_info, solib_aix_xfree_lm_info): Remove.
835         (library_list_start_library): Allocate lm_info_aix with new.
836         (solib_aix_free_library_list, solib_aix_free_so): Free with delete.
837         (solib_aix_current_sos): Adapt to std::string, copy lm_info_aix
838         with copy constructor.
839
840 2017-04-28  Simon Marchi  <simon.marchi@ericsson.com>
841
842         * solist.h (struct lm_info): Remove.
843         (struct lm_info_base): New class.
844         (struct so_list) <lm_info>: Change type to lm_info_base *.
845         * nto-tdep.c (struct lm_info): Remove.
846         (lm_addr): Adjust.
847         * solib-aix.c (struct lm_info): Rename to ...
848         (struct lm_info_aix): ... this.  Extend lm_info_base.
849         (lm_info_p): Rename to ...
850         (lm_info_aix_p): ... this, and adjust.
851         (solib_aix_new_lm_info, solib_aix_xfree_lm_info,
852         solib_aix_parse_libraries, library_list_start_library,
853         solib_aix_free_library_list, solib_aix_parse_libraries,
854         solib_aix_get_library_list,
855         solib_aix_relocate_section_addresses, solib_aix_free_so,
856         solib_aix_get_section_offsets,
857         solib_aix_solib_create_inferior_hook, solib_aix_current_sos):
858         Adjust.
859         (struct solib_aix_inferior_data) <library_list>: Adjust.
860         * solib-darwin.c (struct lm_info): Rename to ...
861         (struct lm_info_darwin): ... this.  Extend lm_info_base.
862         (darwin_current_sos, darwin_relocate_section_addresses): Adjust.
863         * solib-dsbt.c (struct lm_info): Rename to ...
864         (struct lm_info_dsbt): ... this.  Extend lm_info_base.
865         (struct dsbt_info) <main_executable_lm_info): Adjust.
866         (dsbt_current_sos, dsbt_relocate_main_executable, dsbt_free_so,
867         dsbt_relocate_section_addresses): Adjust.
868         * solib-frv.c (struct lm_info): Rename to ...
869         (struct lm_info_frv): ... this.  Extend lm_info_base.
870         (main_executable_lm_info): Adjust.
871         (frv_current_sos, frv_relocate_main_executable, frv_free_so,
872         frv_relocate_section_addresses, frv_fdpic_find_global_pointer,
873         find_canonical_descriptor_in_load_object,
874         frv_fdpic_find_canonical_descriptor): Adjust.
875         * solib-svr4.c (struct lm_info): Move to solib-svr4.h, renamed
876         to lm_info_svr4.
877         (lm_info_read, lm_addr_check, svr4_keep_data_in_core,
878         svr4_clear_so, svr4_copy_library_list,
879         library_list_start_library, svr4_default_sos, svr4_read_so_list,
880         svr4_current_sos, svr4_fetch_objfile_link_map,
881         solist_update_incremental): Adjust.
882         * solib-svr4.h (struct lm_info_svr4): Move here from
883         solib-svr4.c.
884         * solib-target.c (struct lm_info): Rename to ...
885         (struct lm_info_target): ... this.  Extend lm_info_base.
886         (lm_info_p): Rename to ...
887         (lm_info_target_p): ... this.
888         (solib_target_parse_libraries, library_list_start_segment,
889         library_list_start_section, library_list_start_library,
890         library_list_end_library, solib_target_free_library_list,
891         solib_target_current_sos, solib_target_free_so,
892         solib_target_relocate_section_addresses): Adjust.
893         * windows-nat.c (struct lm_info): Rename to ...
894         (struct lm_info_windows): ... this.  Extend lm_info_base.
895         (windows_make_so, handle_load_dll, handle_unload_dll,
896         windows_xfer_shared_libraries): Adjust.
897
898 2017-04-28  Simon Marchi  <simon.marchi@ericsson.com>
899
900         * solib-darwin.c (struct darwin_so_list): Remove.
901         (darwin_current_sos): Allocate an so_list object instead of a
902         darwin_so_list, separately allocate an lm_info object.
903         (darwin_free_so): Free lm_info.
904
905 2017-04-28  John Baldwin  <jhb@FreeBSD.org>
906
907         * mips-tdep.c (print_gp_register_row): Replace printf_filtered
908         with fprintf_filtered.
909
910 2017-04-28  Yao Qi  <yao.qi@linaro.org>
911
912         * regcache.c (regcache::regcache): New function.
913         (regcache::~regcache): New function.
914         (regcache_xmalloc_1): Remove.
915         (regcache_xmalloc): Call new regcache.
916         (regcache_xfree): Call delete regcache.
917         (get_thread_arch_aspace_regcache): Call new regcache.
918
919 2017-04-28  Yao Qi  <yao.qi@linaro.org>
920
921         * mips-linux-nat.c (mips_linux_new_thread): Use ptid method
922         lwp instead of ptid_get_lwp.
923
924 2017-04-28  Yao Qi  <yao.qi@linaro.org>
925
926         * mips-linux-nat.c (mips_linux_new_thread): Get lwpid from
927         lwp_info instead of getting from inferior_ptid.
928
929 2017-04-27  Keith Seitz  <keiths@redhat.com>
930
931         * gdbtypes.c (LVALUE_REFERENCE_TO_RVALUE_BINDING_BADNESS)
932         DIFFERENT_REFERENCE_TYPE_BADNESS): Remove.
933         (CV_CONVERSION_BADNESS): Define.
934         (rank_one_type): Remove overly restrictive rvalue reference
935         rank checks.
936         Add cv-qualifier checks and subranks for type equality.
937         * gdbtypes.h (REFERENCE_CONVERSION_RVALUE,
938         REFERENCE_CONVERSION_CONST_LVALUE, CV_CONVERSION_BADNESS,
939         CV_CONVERSION_CONST, CV_CONVERSION_VOLATILE): Declare.
940
941 2017-04-27  Simon Marchi  <simon.marchi@ericsson.com>
942
943         * python/py-inferior.c (inferior_to_inferior_object): Increment reference
944         count when creating the object.
945
946 2017-04-27  Sangamesh Mallayya  <sangamesh.swamy@in.ibm.com>
947             Ulrich Weigand  <uweigand@de.ibm.com>
948
949         * xcoffread.c (read_xcoff_symtab): Read correct function auxiliary
950         entry if xlc -qfuncsect or gcc -ffunction-sections compiler option
951         is used in AIX.
952         (read_xcoff_symtab): Handle C_WEAKEXT storage class.
953         (process_xcoff_symbol): Likewise.
954         (scan_xcoff_symtab): Likewise.
955
956 2017-04-26  Alan Hayward  <alan.hayward@arm.com>
957
958         * ia64-tdep.c (examine_prologue): Use get_frame_register_unsigned.
959         (ia64_sigtramp_frame_prev_register): Use read_memory_unsigned_integer.
960         (ia64_access_reg): Use get_frame_register_unsigned.
961         (ia64_access_rse_reg): Likewise.
962         (ia64_libunwind_frame_prev_register): Likewise.
963
964 2017-04-26  Jiong Wang  <jiong.wang@arm.com>
965
966         * gdbarch.sh: New gdbarch method execute_dwarf_cfa_vendor_op.
967         * gdbarch.c: Regenerated.
968         * gdbarch.h: Regenerated.
969         * dwarf2-frame.c (dwarf2_frame_state_alloc_regs): Made the
970         visibility external.
971         (execute_cfa_program): Call execute_dwarf_cfa_vendor_op for CFI
972         between DW_CFA_lo_user and DW_CFA_high_user inclusive.
973         (enum cfa_how_kind): Move to ...
974         (struct dwarf2_frame_state_reg_info): Likewise.
975         (struct dwarf2_frame_state): Likewise.
976         * dwarf2-frame.h: ... here.
977         (dwarf2_frame_state_alloc_regs): New declaration.
978         * sparc-tdep.c (sparc_execute_dwarf_cfa_vendor_op): New function.
979         (sparc32_gdbarch_init): Register execute_dwarf_cfa_vendor_op hook.
980
981 2017-04-26  Alan Hayward  <alan.hayward@arm.com>
982
983         * xtensa-tdep.c (xtensa_pseudo_register_read): Use
984         regcache_raw_read_unsigned.
985         (xtensa_pseudo_register_write): Likewise.
986
987 2017-04-26  Alan Hayward  <alan.hayward@arm.com>
988
989         * nds32-tdep.c (nds32_pseudo_register_read): Abort on errors.
990         (nds32_pseudo_register_write): Likewise.
991
992 2017-04-25  Yao Qi  <yao.qi@linaro.org>
993
994         * regcache.c (struct regcache) <readonly_p>: Change its type
995         to bool.
996         (regcache_xmalloc_1): Update parameter type and callers update.
997
998 2017-04-25  Yao Qi  <yao.qi@linaro.org>
999
1000         * aarch64-tdep.c (aarch64_gdbarch_init): Don't call
1001         set_gdbarch_wchar_bit.
1002         * arm-tdep.c (arm_gdbarch_init): Likewise.
1003
1004 2017-04-25  Pedro Alves  <palves@redhat.com>
1005
1006         * common/poison.h [!HAVE_IS_TRIVIALLY_COPYABLE] (IsRelocatable)
1007         (BothAreRelocatable, memcopy, memmove): Don't define.
1008         * common/traits.h (__has_feature, HAVE_IS_TRIVIALLY_COPYABLE): New
1009         macros.
1010
1011 2017-04-25  Pedro Alves  <palves@redhat.com>
1012
1013         * common/common-defs.h: Include "common/poison.h".
1014         * common/function-view.h: (Not, Or, Requires): Move to traits.h
1015         and adjust.
1016         * common/poison.h: New file.
1017         * common/traits.h: Include <type_traits>.
1018         (Not, Or, Requires): New, moved from common/function-view.h.
1019
1020 2017-04-25  Pedro Alves  <palves@redhat.com>
1021
1022         * breakpoint.h (struct breakpoint): In-class initialize all
1023         fields.  Make boolean fields "bool".
1024         * breakpoint.c (init_raw_breakpoint_without_location): Remove
1025         memset call and initializations no longer necessary.
1026
1027 2017-04-25  Pedro Alves  <palves@redhat.com>
1028
1029         * btrace.c (pt_btrace_insn_flags): Change parameter type to
1030         reference.
1031         (pt_btrace_insn): New function.
1032         (ftrace_add_pt): Remove memset call and use pt_btrace_insn.
1033
1034 2017-04-25  Pedro Alves  <palves@redhat.com>
1035
1036         * ada-lang.c (ada_catchpoint_location): Now a "class".  Remove
1037         "base" field and inherit from "bp_location" instead.  Add
1038         non-default ctor.
1039         (allocate_location_exception): Use new non-default ctor.
1040         * breakpoint.c (get_first_locp_gte_addr): Remove memset call.
1041         (init_bp_location): Convert to ...
1042         (bp_location::bp_location): ... this new ctor, and remove memset
1043         call.
1044         (base_breakpoint_allocate_location): Use the new non-default ctor.
1045         * breakpoint.h (bp_location): Now a class.  Declare default and
1046         non-default ctors.  In-class initialize all members.
1047         (init_bp_location): Remove declaration.
1048
1049 2017-04-25  Pedro Alves  <palves@redhat.com>
1050
1051         * common/enum-flags.h (enum_flags): Don't implement copy ctor and
1052         assignment operator.
1053
1054 2017-04-24  Yao Qi  <yao.qi@linaro.org>
1055
1056         * doublest.c (convert_doublest_to_floatformat): Call
1057         floatformat_totalsize_bytes.
1058
1059 2017-04-22  Tom Tromey  <tom@tromey.com>
1060
1061         * mi/mi-cmd-file.c (mi_cmd_file_list_shared_libraries): Use
1062         ui_out_emit_list.
1063         * stack.c (print_frame): Use ui_out_emit_list.
1064         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Use
1065         ui_out_emit_list.
1066         * mi/mi-main.c (print_one_inferior)
1067         (mi_cmd_data_list_register_names)
1068         (mi_cmd_data_list_register_values, mi_cmd_list_features)
1069         (mi_cmd_list_target_features, mi_cmd_trace_frame_collected): Use
1070         ui_out_emit_list.
1071         * mi/mi-interp.c (mi_on_normal_stop_1): Use ui_out_emit_list.
1072         (mi_output_solib_attribs): Use ui_out_emit_list,
1073         ui_out_emit_tuple.
1074         * mi/mi-cmd-var.c (varobj_update_one): Use ui_out_emit_list.
1075         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1076         (mi_cmd_stack_list_args, list_args_or_locals): Use
1077         ui_out_emit_list.
1078         * disasm.c (do_assembly_only): Use ui_out_emit_list.
1079         * breakpoint.c (print_solib_event, output_thread_groups): Use
1080         ui_out_emit_list.
1081
1082 2017-04-22  Tom Tromey  <tom@tromey.com>
1083
1084         * mi/mi-main.c (print_variable_or_computed): Use ui_out_emit_tuple.
1085         * mi/mi-cmd-var.c (varobj_update_one): Use ui_out_emit_tuple.
1086         * mi/mi-cmd-stack.c (list_arg_or_local): Use ui_out_emit_tuple.
1087
1088 2017-04-22  Tom Tromey  <tom@tromey.com>
1089
1090         * tracepoint.c (tvariables_info_1)
1091         (print_one_static_tracepoint_marker): Use ui_out_emit_tuple.
1092
1093 2017-04-22  Tom Tromey  <tom@tromey.com>
1094
1095         * stack.c (print_frame_arg): Use ui_out_emit_tuple,
1096         annotate_arg_emitter.
1097         * breakpoint.c (print_mention_watchpoint)
1098         (print_mention_masked_watchpoint): Use ui_out_emit_tuple.
1099         * annotate.h (struct annotate_arg_emitter): New.
1100
1101 2017-04-22  Tom Tromey  <tom@tromey.com>
1102
1103         * record-btrace.c (record_btrace_insn_history)
1104         (record_btrace_insn_history_range, record_btrace_call_history)
1105         (record_btrace_call_history_range): Use ui_out_emit_tuple.
1106         * thread.c (do_captured_list_thread_ids, print_thread_info_1): Use
1107         ui_out_emit_tuple.
1108         * stack.c (print_frame_info): Use ui_out_emit_tuple.
1109         * solib.c (info_sharedlibrary_command): Use ui_out_emit_tuple.
1110         * skip.c (skip_info): Use ui_out_emit_tuple.
1111         * remote.c (show_remote_cmd): Use ui_out_emit_tuple.
1112         * progspace.c (print_program_space): Use ui_out_emit_tuple.
1113         * probe.c (info_probes_for_ops): Use ui_out_emit_tuple.
1114         * osdata.c (info_osdata): Use ui_out_emit_tuple.
1115         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Use
1116         ui_out_emit_tuple.
1117         * mi/mi-main.c (print_one_inferior, list_available_thread_groups)
1118         (output_register, mi_cmd_data_read_memory)
1119         (mi_cmd_data_read_memory_bytes, mi_load_progress)
1120         (mi_cmd_trace_frame_collected): Use ui_out_emit_tuple.
1121         * mi/mi-cmd-var.c (mi_cmd_var_list_children, varobj_update_one):
1122         Use ui_out_emit_tuple.
1123         * mi/mi-cmd-stack.c (mi_cmd_stack_list_args): Use
1124         ui_out_emit_tuple.
1125         * mi/mi-cmd-info.c (mi_cmd_info_ada_exceptions)
1126         (mi_cmd_info_gdb_mi_command): Use ui_out_emit_tuple.
1127         * linux-thread-db.c (info_auto_load_libthread_db): Use
1128         ui_out_emit_tuple.
1129         * inferior.c (print_inferior): Use ui_out_emit_tuple.
1130         * gdb_bfd.c (print_one_bfd): Use ui_out_emit_tuple.
1131         * disasm.c (do_mixed_source_and_assembly_deprecated)
1132         (do_mixed_source_and_assembly): Use ui_out_emit_tuple.
1133         * cp-abi.c (list_cp_abis): Use ui_out_emit_tuple.
1134         * cli/cli-setshow.c (cmd_show_list): Use ui_out_emit_tuple.
1135         * breakpoint.c (print_one_breakpoint_location)
1136         (print_one_breakpoint): Use ui_out_emit_tuple.
1137         * auto-load.c (print_script, info_auto_load_cmd): Use
1138         ui_out_emit_tuple.
1139         * ada-tasks.c (print_ada_task_info): Use ui_out_emit_tuple.
1140
1141 2017-04-21  Simon Marchi  <simon.marchi@ericsson.com>
1142
1143         * thread.c (print_thread_info_1): Remove dead code.
1144
1145 2017-04-21  Jan Kratochvil  <jan.kratochvil@redhat.com>
1146
1147         * aarch64-tdep.c (selftests::aarch64_process_record_test): Make it #if
1148         GDB_SELF_TEST.
1149         * arm-tdep.c (selftests::arm_record_test): Likewise.
1150
1151 2017-04-21  Yao Qi  <yao.qi@linaro.org>
1152
1153         * regcache.c (regcache_restore): Remove argument 2.  Replace
1154         argument 3 with regcache.  Get register status from
1155         src->register_status and get register contents from
1156         register_buffer (src, regnum).
1157         (regcache_cpy): Update.
1158
1159 2017-04-19  Pedro Alves  <palves@redhat.com>
1160
1161         * gdbthread.h (thread): Add missing closing parenthesis in
1162         comment.
1163
1164 2017-04-19  Pedro Alves  <palves@redhat.com>
1165
1166         * common/refcounted-object.h: New file.
1167         * gdbthread.h: Include "common/refcounted-object.h".
1168         (thread_info): Inherit from refcounted_object and add comments.
1169         (thread_info::incref, thread_info::decref)
1170         (thread_info::m_refcount): Delete.
1171         (thread_info::deletable): Use the refcounted_object::refcount()
1172         method.
1173         * inferior.c (current_inferior_): Add comment.
1174         (set_current_inferior): Increment/decrement refcounts.
1175         (prune_inferiors, remove_inferior_command): Skip inferiors marked
1176         not-deletable instead of comparing with the current inferior.
1177         (initialize_inferiors): Increment the initial inferior's refcount.
1178         * inferior.h (struct inferior): Forward declare.
1179         Include "common/refcounted-object.h".
1180         (current_inferior, set_current_inferior): Move declaration to
1181         before struct inferior's definition, and fix comment.
1182         (inferior): Inherit from refcounted_object.  Add comments.
1183         * thread.c (switch_to_thread_no_regs): Reference the thread's
1184         inferior pointer directly instead of doing a ptid lookup.
1185         (switch_to_no_thread): New function.
1186         (switch_to_thread(thread_info *)): New function, factored out
1187         from ...
1188         (switch_to_thread(ptid_t)): ... this.
1189         (restore_current_thread): Delete.
1190         (current_thread_cleanup): Remove 'inf_id' and 'was_removable'
1191         fields, and add 'inf' field.
1192         (do_restore_current_thread_cleanup): Check whether old->inf is
1193         alive instead of looking up an inferior by ptid.  Use
1194         switch_to_thread and switch_to_no_thread.
1195         (restore_current_thread_cleanup_dtor): Use old->inf directly
1196         instead of lookup up an inferior by id.  Decref the inferior.
1197         Don't restore 'removable'.
1198         (make_cleanup_restore_current_thread): Same the inferior pointer
1199         in old, instead of the inferior number.  Incref the inferior.
1200         Don't save/clear 'removable'.
1201
1202 2017-04-19  Pedro Alves  <palves@redhat.com>
1203
1204         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1205         unittests/scoped_restore-selftests.c.
1206         (SUBDIR_UNITTESTS_OBS): Add scoped_restore-selftests.o.
1207         * common/scoped_restore.h (scoped_restore_base): Make "class".
1208         (scoped_restore_base::release): New public method.
1209         (scoped_restore_base::scoped_restore_base): New protected ctor.
1210         (scoped_restore_base::m_saved_var): New protected field.
1211         (scoped_restore_tmpl::scoped_restore_tmpl(T*)): Initialize the
1212         scoped_restore_base base class instead of m_saved_var directly.
1213         (scoped_restore_tmpl::scoped_restore_tmpl(T*, T2)): Likewise.
1214         (scoped_restore_tmpl::scoped_restore_tmpl(const
1215         scoped_restore_tmpl<T>&)): Likewise.
1216         (scoped_restore_tmpl::~scoped_restore_tmpl): Use the saved_var
1217         method.
1218         (scoped_restore_tmpl::saved_var): New method.
1219         (scoped_restore_tmpl::m_saved_var): Delete.
1220         * inferior.h (inferior::detaching): Now a bool.
1221         * infrun.c (prepare_for_detach): Use a scoped_restore instead of a
1222         cleanup.
1223         * unittests/scoped_restore-selftests.c: New file.
1224
1225 2017-04-19  Pedro Alves  <palves@redhat.com>
1226
1227         * Makefile.in (SUBDIR_UNITTESTS_SRCS, SUBDIR_UNITTESTS_OBS):
1228         Re-sort in alphabetic order.
1229
1230 2017-04-18  Pedro Alves  <palves@redhat.com>
1231
1232         * xml-support.c (obstack_xml_printf): Delete.
1233         * xml-support.h (obstack_xml_printf): Delete.
1234
1235 2017-04-18  Pedro Alves  <palves@redhat.com>
1236
1237         * xml-support.c (gdb_xml_parser) <use_dtd, dtd_name, parse,
1238         vdebug, verror, body_text, start_element, end_element, name,
1239         user_data, set_is_xinclude, set_error, expat_parser>: New methods.
1240         <name, user_data, expat_parser, scopes, error, last_line, dtd_name,
1241         is_xinclude>: Make private and add m_ prefix.
1242         (gdb_xml_parser::body_text): New method, based on ...
1243         (gdb_xml_body_text): ... this.  Adjust.
1244         (gdb_xml_parser::vdebug): New method, based on ...
1245         (gdb_xml_debug): ... this.  Adjust.
1246         (gdb_xml_parser::verror): New method, based on ...
1247         (gdb_xml_error): ... this.  Adjust.
1248         (gdb_xml_parser::start_element): New method, based on ...
1249         (gdb_xml_start_element): ... this.  Adjust.
1250         (gdb_xml_start_element_wrapper): Defer to
1251         gdb_xml_parser::start_element and gdb_xml_parser::set_error.
1252         (gdb_xml_parser::end_element): New method, based on ...
1253         (gdb_xml_end_element_wrapper): ... this.  Adjust.
1254         (gdb_xml_parser::~gdb_xml_parser): Adjust.
1255         (gdb_xml_parser::gdb_xml_parser): Adjust to field renames.
1256         (gdb_xml_parser::use_dtd): New method, based on ...
1257         (gdb_xml_use_dtd): ... this.  Adjust.
1258         (gdb_xml_parser::parse): New method, based on ...
1259         (gdb_xml_parse): ... this.  Adjust.
1260         (gdb_xml_parse_quick): Adjust to call the parser's parse method.
1261         (xinclude_start_include): Adjust to call the parser's name method.
1262         (xml_xinclude_default, xml_xinclude_start_doctype)
1263         (xml_xinclude_end_doctype): Adjust to call the parser's user_data
1264         method.
1265         (xml_process_xincludes): Adjust to call parser methods.
1266         * xml-support.h (gdb_xml_use_dtd, gdb_xml_parse): Delete
1267         declarations.
1268
1269 2017-04-18  Pedro Alves  <palves@redhat.com>
1270
1271         * tracefile-tfile.c (tfile_write_tdesc): Adjust to use
1272         gdb::optional<std::string>.
1273         * xml-support.c: Include <string>.
1274         (scope_level::scope_level(scope_level &&))
1275         (scope_level::~scope_level): Delete.
1276         (scope_level::body): Now a std::string.
1277         (gdb_xml_body_text, gdb_xml_end_element): Adjust.
1278         (xinclude_parsing_data::xinclude_parsing_data): Add 'output'
1279         parameter.
1280         (xinclude_parsing_data::~xinclude_parsing_data): Delete.
1281         (xinclude_parsing_data::output): Now a std::string reference.
1282         (xinclude_start_include): Adjust.
1283         (xml_xinclude_default): Adjust.
1284         (xml_process_xincludes): Add 'output' parameter, and return bool.
1285         * xml-support.h (xml_process_xincludes): Add 'output' parameter,
1286         and return bool.
1287         * xml-tdesc.c: Include <unordered_map> and <string>.
1288         (tdesc_xml_cache): Delete.
1289         (tdesc_xml_cache_s): Delete.
1290         (xml_cache): Now an std::unordered_map.
1291         (tdesc_parse_xml): Adjust to use std::string and unordered_map.
1292         (target_fetch_description_xml): Change return type to
1293         gdb::optional<std::string>, and adjust.
1294         * xml-tdesc.h: Include "common/gdb_optional.h" and <string>.
1295         (target_fetch_description_xml): Change return type to
1296         gdb::optional<std::string>.
1297
1298 2017-04-18  Pedro Alves  <palves@redhat.com>
1299
1300         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1301         unittests/optional-selftests.c.
1302         (SUBDIR_UNITTESTS_OBS): Add optional-selftests.o.
1303         * unittests/optional-selftests.c: New file.
1304         * unittests/optional/assignment/1.cc: New file.
1305         * unittests/optional/assignment/2.cc: New file.
1306         * unittests/optional/assignment/3.cc: New file.
1307         * unittests/optional/assignment/4.cc: New file.
1308         * unittests/optional/assignment/5.cc: New file.
1309         * unittests/optional/assignment/6.cc: New file.
1310         * unittests/optional/assignment/7.cc: New file.
1311         * unittests/optional/cons/copy.cc: New file.
1312         * unittests/optional/cons/default.cc: New file.
1313         * unittests/optional/cons/move.cc: New file.
1314         * unittests/optional/cons/value.cc: New file.
1315         * unittests/optional/in_place.cc: New file.
1316         * unittests/optional/observers/1.cc: New file.
1317         * unittests/optional/observers/2.cc: New file.
1318
1319 2017-04-18  Pedro Alves  <palves@redhat.com>
1320
1321         * common/gdb_optional.h: Include common/traits.h.
1322         (in_place_t): New type.
1323         (in_place): New constexpr variable.
1324         (optional::optional): Remove member initialization of
1325         m_instantiated.
1326         (optional::optional(in_place_t...)): New constructor.
1327         (optional::~optional): Use reset.
1328         (optional::optional(const optional&)): New.
1329         (optional::optional(const optional&&)): New.
1330         (optional::optional(T &)): New.
1331         (optional::optional(T &&)): New.
1332         (operator::operator=(const optional &)): New.
1333         (operator::operator=(optional &&)): New.
1334         (operator::operator= (const T &))
1335         (operator::operator= (T &&))
1336         (operator::emplace (Args &&... args)): Return a T&.  Use reset.
1337         (operator::reset): New.
1338         (operator::m_instantiated):: Add in-class initializer.
1339         * common/traits.h: Include <type_traits>.
1340         (struct And): New types.
1341
1342 2017-04-18  Pedro Alves  <palves@redhat.com>
1343
1344         * xml-support.c: Include <vector>.
1345         (scope_level::scope_level(const gdb_xml_element *))
1346         (scope_level::scope_level(scope_level&&)): New.
1347         (scope_level::~scope_level): New.
1348         (scope_level_s): Delete.
1349         (gdb_xml_parser::scopes): Now a std::vector.
1350         (gdb_xml_body_text, gdb_xml_start_element, gdb_xml_end_element):
1351         Use std::vector.
1352         (gdb_xml_parser::~gdb_xml_parser): Remove now unnecessary
1353         scope cleanup code.
1354         (gdb_xml_parser::gdb_xml_parser): Remove explicit initialization
1355         of the scopes member.  Use std::vector::emplace_back.
1356
1357 2017-04-18  Pedro Alves  <palves@redhat.com>
1358
1359         * xml-support.c (gdb_xml_parser): Add ctor/dtor.  Make is_xinclude
1360         a bool.
1361         (gdb_xml_end_element): Change type of first parameter.
1362         (gdb_xml_cleanup): Rename to ...
1363         (gdb_xml_parser::~gdb_xml_parser): ... this.
1364         (gdb_xml_create_parser_and_cleanup): Delete with ...
1365         (gdb_xml_parser::gdb_xml_parser): ... creation parts factored out
1366         to this new ctor.
1367         (gdb_xml_parse_quick): Create a local gdb_xml_parser instead of
1368         using gdb_xml_create_parser_and_cleanup.
1369         (xinclude_parsing_data): Add ctor/dtor.
1370         (xml_xinclude_cleanup): Delete.
1371         (xml_process_xincludes): Create a local xinclude_parsing_data
1372         instead of heap-allocating one.  Create a local gdb_xml_parser
1373         instead of heap-allocating one with
1374         gdb_xml_create_parser_and_cleanup.
1375
1376 2017-04-18  John Baldwin  <jhb@FreeBSD.org>
1377
1378         PR threads/20743
1379         * fbsd-nat.c (resume_one_thread_cb): Remove.
1380         (resume_all_threads_cb): Remove.
1381         (fbsd_resume): Use ALL_NON_EXITED_THREADS instead of
1382         iterate_over_threads.
1383
1384 2017-04-17  Joel Brobecker  <brobecker@adacore.com>
1385
1386         * NEWS: Create a new section for the next release branch.
1387         Rename the section of the current branch, now that it has
1388         been cut.
1389
1390 2017-04-17  Joel Brobecker  <brobecker@adacore.com>
1391
1392         GDB 8.0 branch created (725bf5cf125783c2a7ca4ab63d3768e220bab2db):
1393         * version.in: Bump version to 8.0.50.DATE-git.
1394
1395 2017-04-13  Sergio Durigan Junior  <sergiodj@redhat.com>
1396
1397         PR gdb/21385
1398         * windows-nat.c (windows_create_inferior): Declare 'allargs'
1399         independently of the host, and fix build breakage on Cygwin.
1400
1401 2017-04-13  Pedro Alves  <palves@redhat.com>
1402
1403         * inferior.c (free_inferior): Convert to ...
1404         (inferior::~inferior): ... this dtor.
1405         (inferior::inferior): New ctor, factored out from ...
1406         (add_inferior_silent): ... here.  Allocate the inferior with a new
1407         expression.
1408         (delete_inferior): Call delete instead of free_inferior.
1409         * inferior.h (gdb_environ, continuation): Forward declare.
1410         (inferior): Now a class.  Add in-class initialization to all
1411         members.  Make boolean fields bool, except 'detaching'.
1412         (inferior::inferior): New explicit ctor.
1413         (inferior::~inferior): New.
1414
1415 2017-04-13  Pedro Alves  <palves@redhat.com>
1416
1417         * inferior.c (init_inferior_list): Delete.
1418         * inferior.h (init_inferior_list): Delete.
1419
1420 2017-04-13  Pedro Alves  <palves@redhat.com>
1421
1422         PR threads/13217
1423         * gdb.threads/threadapply.exp (thr_apply_detach): New procedure.
1424         (top level): Call it twice, with different thread sets.
1425
1426 2017-04-13  Pedro Alves  <palves@redhat.com>
1427
1428         * thread.c: Include <algorithm>.
1429         (thread_array_cleanup): Delete.
1430         (scoped_inc_dec_ref): New class.
1431         (live_threads_count): New function.
1432         (set_thread_refcount): Delete.
1433         (tp_array_compar_ascending): Now a bool.
1434         (tp_array_compar): Convert to a std::sort comparison function.
1435         (thread_apply_all_command): Use std::vector and scoped_inc_dec_ref
1436         and live_threads_count.
1437
1438 2017-04-13  Pedro Alves  <palves@redhat.com>
1439
1440         * infrun.c (follow_fork_inferior): Also switch the current
1441         inferior.
1442
1443 2017-04-13  Pedro Alves  <palves@redhat.com>
1444
1445         * breakpoint.c (watch_command_1): Save watchpoint-frame info
1446         before calling create_internal_breakpoint.
1447
1448 2017-04-13  Pedro Alves  <palves@redhat.com>
1449
1450         * fork-child.c (execv_argv): New class.
1451         (breakup_args): Refactored as ...
1452         (execv_argv::init_for_no_shell): .. this method of execv_argv.
1453         Copy arguments to storage and replace separators with NULL
1454         terminators in place.
1455         (escape_bang_in_quoted_argument): Adjust to return bool.
1456         (execv_argv::execv_argv): New ctor.
1457         (execv_argv::init_for_shell): New method, factored out from
1458         fork_inferior.  Don't strdup strings into the vector.
1459         (fork_inferior): Eliminate "shell" local and use execv_argv.  Use
1460         Remove free_vector_argv call.
1461
1462 2017-04-13  Yao Qi  <yao.qi@linaro.org>
1463
1464         * rx-tdep.c (rx_fpsw_type): Check tdep->rx_fpsw_type instead of
1465         tdep->rx_psw_type.
1466
1467 2017-04-13  Yao Qi  <yao.qi@linaro.org>
1468
1469         * rl78-tdep.c (rl78_gdbarch_init): Use XCNEW instead of XNEW.
1470         * rx-tdep.c (rx_gdbarch_init): Likewise.
1471
1472 2017-04-13  Pedro Alves  <palves@redhat.com>
1473
1474         * breakpoint.h (struct breakpoint): Reindent.
1475
1476 2017-04-13  Pedro Alves  <palves@redhat.com>
1477
1478         * breakpoint.c (bp_location): Rename to ...
1479         (bp_locations): ... this.  All references updated.
1480         (bp_location_count): Rename to ...
1481         (bp_locations_count): ... this.  All references updated.
1482         (bp_location_placed_address_before_address_max): Rename to ...
1483         (bp_locations_placed_address_before_address_max): ... this.  All
1484         references updated.
1485         (bp_location_shadow_len_after_address_max): Rename to ...
1486         (bp_locations_shadow_len_after_address_max): ... this.  All
1487         references updated.
1488         (bp_location_compare_addrs): Rename to ...
1489         (bp_locations_compare_addrs): ... this.  All references updated.
1490         (bp_location_compare):Rename to ...
1491         (bp_locations_compare): ... this.  All references updated.
1492         (bp_location_target_extensions_update): Rename to ...
1493         (bp_locations_target_extensions_update): ... this.  All references
1494         updated.
1495
1496 2017-04-12  Sergio Durigan Junior  <sergiodj@redhat.com>
1497
1498         * Makefile.in (HFILES_NO_SRCDIR): Add "common/gdb_termios.h".
1499         * common/common.m4: Check headers 'termios.h', 'termio.h' and
1500         'sgtty.h'.
1501         * common/gdb_termios.h: New file, with parts of "terminal.h".
1502         * inflow.c: Include "gdb_termios.h".
1503         * ser-unix.c: Include "gdb_termios.h".
1504         * terminal.h: Move terminal-related defines to
1505         "common/gdb_termios.h".
1506
1507 2017-04-12  Tom Tromey  <tom@tromey.com>
1508
1509         * probe.c (parse_probes): Update.
1510         * location.h (delete_event_location): Don't declare.
1511         (event_location_deleter::operator()): Update.
1512         * location.c (event_location_deleter::operator()): Rename from
1513         delete_event_location.
1514         * linespec.h (linespec_result) <location>: Change type to
1515         event_location_up.
1516         * linespec.c (canonicalize_linespec, event_location_to_sals)
1517         (decode_objc): Update.
1518         (linespec_result): Don't call delete_event_location.
1519         * breakpoint.c (create_breakpoints_sal)
1520         (bkpt_probe_create_sals_from_location)
1521         (strace_marker_create_sals_from_location): Update.
1522
1523 2017-04-12  Tom Tromey  <tom@tromey.com>
1524
1525         * linespec.h (struct linespec_result): Add constructor and
1526         destructor.
1527         (init_linespec_result, destroy_linespec_result)
1528         (make_cleanup_destroy_linespec_result): Don't declare.
1529         * linespec.c (init_linespec_result): Remove.
1530         (linespec_result::~linespec_result): Rename from
1531         destroy_linespec_result.  Update.
1532         (cleanup_linespec_result, make_cleanup_destroy_linespec_result):
1533         Remove.
1534         * breakpoint.c (create_breakpoint, break_range_command)
1535         (decode_location_default): Update.
1536         * ax-gdb.c (agent_command_1): Update.
1537
1538 2017-04-12  Tom Tromey  <tom@tromey.com>
1539
1540         * remote.c (remote_download_tracepoint): Update.
1541         * python/py-breakpoint.c (bppy_get_location): Update.
1542         * guile/scm-breakpoint.c (bpscm_print_breakpoint_smob)
1543         (gdbscm_breakpoint_location): Update.
1544         * elfread.c (elf_gnu_ifunc_resolver_return_stop): Update.
1545         * breakpoint.h (struct breakpoint) <location, location_range_end>:
1546         Change type to event_location_up.
1547         * breakpoint.c (create_overlay_event_breakpoint)
1548         (create_longjmp_master_breakpoint)
1549         (create_std_terminate_master_breakpoint)
1550         (create_exception_master_breakpoint)
1551         (breakpoint_event_location_empty_p, print_breakpoint_location)
1552         (print_one_breakpoint_location, create_thread_event_breakpoint)
1553         (init_breakpoint_sal, create_breakpoint)
1554         (print_recreate_ranged_breakpoint, break_range_command)
1555         (init_ada_exception_breakpoint, say_where): Update.
1556         (base_breakpoint_dtor): Don't call delete_event_location.
1557         (bkpt_print_recreate, tracepoint_print_recreate)
1558         (dprintf_print_recreate, update_static_tracepoint)
1559         (breakpoint_re_set_default): Update.
1560
1561 2017-04-12  Tom Tromey  <tom@tromey.com>
1562
1563         * compile/compile-loc2c.c (compute_stack_depth_worker): Change
1564         type of "to_do".  Update.
1565         (compute_stack_depth): Use std::vector.
1566
1567 2017-04-12  Tom Tromey  <tom@tromey.com>
1568
1569         * printcmd.c (find_instruction_backward): Use std::vector.
1570
1571 2017-04-12  Tom Tromey  <tom@tromey.com>
1572
1573         * symfile.c (objfilep): Remove typedef.
1574         (reread_symbols): Use a std::vector.
1575
1576 2017-04-12  Tom Tromey  <tom@tromey.com>
1577
1578         * mi/mi-main.c (exec_direction_forward): Remove.
1579         (exec_reverse_continue, mi_execute_command): Use scoped_restore.
1580         * guile/scm-ports.c (ioscm_with_output_to_port_worker): Use
1581         scoped_restore.
1582         * guile/guile.c (guile_repl_command, guile_command)
1583         (gdbscm_execute_gdb_command): Use scoped_restore.
1584         * go-exp.y (go_parse): Use scoped_restore.
1585         * d-exp.y (d_parse): Use scoped_restore.
1586         * cli/cli-decode.c (cmd_func): Use scoped_restore.
1587         * c-exp.y (c_parse): Use scoped_restore.
1588
1589 2017-04-12  Tom Tromey  <tom@tromey.com>
1590
1591         * mi/mi-parse.h (struct mi_parse): Add constructor, destructor.
1592         (mi_parse): Update return type.
1593         (mi_parse_free): Remove.
1594         * mi/mi-parse.c (mi_parse::mi_parse): New constructor.
1595         (mi_parse::~mi_parse): Rename from mi_parse_free.
1596         (mi_parse_cleanup): Remove.
1597         (mi_parse): Return a unique_ptr.  Use new.
1598         * mi/mi-main.c (mi_execute_command): Update.
1599
1600 2017-04-12  Tom Tromey  <tom@tromey.com>
1601
1602         * location.c (explicit_location_lex_one): Return a
1603         unique_xmalloc_ptr.
1604         (string_to_explicit_location): Update.  Remove cleanups.
1605
1606 2017-04-12  Tom Tromey  <tom@tromey.com>
1607
1608         * gnu-v3-abi.c (value_and_voffset_p): Remove typedef.
1609         (compare_value_and_voffset): Change type.  Update.
1610         (compute_vtable_size): Change type of "offset_vec".
1611         (gnuv3_print_vtable): Use std::vector.  Remove cleanups.
1612         (gnuv3_get_typeid): Remove extraneous declaration.
1613
1614 2017-04-12  Tom Tromey  <tom@tromey.com>
1615
1616         * charset.h (wchar_iterator): Fix comment.
1617
1618 2017-04-12  Tom Tromey  <tom@tromey.com>
1619
1620         * charset.c (iconv_wrapper): New class.
1621         (cleanup_iconv): Remove.
1622         (convert_between_encodings): Use it.
1623
1624 2017-04-12  Tom Tromey  <tom@tromey.com>
1625
1626         * symfile.h (increment_reading_symtab): Update type.
1627         * symfile.c (decrement_reading_symtab): Remove.
1628         (increment_reading_symtab): Return a scoped_restore_tmpl<int>.
1629         * psymtab.c (psymtab_to_symtab): Update.
1630         * dwarf2read.c (dw2_instantiate_symtab): Update.
1631
1632 2017-04-12  Tom Tromey  <tom@tromey.com>
1633
1634         * jit.c (struct jit_reader): Declare separately.  Add constructor
1635         and destructor.  Change type of "handle".
1636         (loaded_jit_reader): Define separately.
1637         (jit_reader_load): Update.  New "new".
1638         (jit_reader_unload_command): Use "delete".
1639         * gdb-dlfcn.h (struct dlclose_deleter): New.
1640         (gdb_dlhandle_up): New typedef.
1641         (gdb_dlopen, gdb_dlsym): Update types.
1642         (gdb_dlclose): Remove.
1643         * gdb-dlfcn.c (gdb_dlopen): Return a gdb_dlhandle_up.
1644         (gdb_dlsym): Change type of "handle".
1645         (make_cleanup_dlclose): Remove.
1646         (dlclose_deleter::operator()): Rename from gdb_dlclose.
1647         * compile/compile-c-support.c (load_libcc): Update.
1648
1649 2017-04-12  Tom Tromey  <tom@tromey.com>
1650
1651         * symtab.h (find_pcs_for_symtab_line): Change return type.
1652         * symtab.c (find_pcs_for_symtab_line): Change return type.
1653         * python/py-linetable.c (build_line_table_tuple_from_pcs): Change
1654         type of "vec".  Update.
1655         (ltpy_get_pcs_for_line): Update.
1656         * linespec.c (decode_digits_ordinary): Update.
1657
1658 2017-04-12  Tom Tromey  <tom@tromey.com>
1659
1660         * tracepoint.c (actions_command): Update.
1661         * python/python.c (python_command, python_interactive_command):
1662         Update.
1663         * mi/mi-cmd-break.c (mi_cmd_break_commands): Update.
1664         * guile/guile.c (guile_command): Update.
1665         * defs.h (read_command_lines, read_command_lines_1): Return
1666         command_line_up.
1667         (command_lines_deleter): New struct.
1668         (command_line_up): New typedef.
1669         * compile/compile.c (compile_code_command)
1670         (compile_print_command): Update.
1671         * cli/cli-script.h (get_command_line, copy_command_lines): Return
1672         command_line_up.
1673         (make_cleanup_free_command_lines): Remove.
1674         * cli/cli-script.c (get_command_line, read_command_lines_1)
1675         (copy_command_lines): Return command_line_up.
1676         (while_command, if_command, read_command_lines, define_command)
1677         (document_command): Update.
1678         (do_free_command_lines_cleanup, make_cleanup_free_command_lines):
1679         Remove.
1680         * breakpoint.h (breakpoint_set_commands): Change type of
1681         "commands".
1682         * breakpoint.c (breakpoint_set_commands): Change type of
1683         "commands".  Update.
1684         (do_map_commands_command, update_dprintf_command_list)
1685         (create_tracepoint_from_upload): Update.
1686
1687 2017-04-12  Tom Tromey  <tom@tromey.com>
1688
1689         * tracepoint.c (scope_info): Update.
1690         * spu-tdep.c (spu_catch_start): Update.
1691         * python/python.c (gdbpy_decode_line): Update.
1692         * python/py-finishbreakpoint.c (bpfinishpy_init): Update.
1693         * python/py-breakpoint.c (bppy_init): Update.
1694         * probe.c (parse_probes): Update.
1695         * mi/mi-cmd-break.c (mi_cmd_break_insert_1): Update.
1696         * location.h (event_location_deleter): New struct.
1697         (event_location_up): New typedef.
1698         (new_linespec_location, new_address_location, new_probe_location)
1699         (new_explicit_location, copy_event_location)
1700         (string_to_event_location, string_to_event_location_basic)
1701         (string_to_explicit_location): Update return type.
1702         (make_cleanup_delete_event_location): Remove.
1703         * location.c (new_linespec_location, new_address_location)
1704         (new_probe_location, new_explicit_location, copy_event_location):
1705         Return event_location_up.
1706         (delete_event_location_cleanup)
1707         (make_cleanup_delete_event_location): Remove.
1708         (string_to_explicit_location, string_to_event_location_basic)
1709         (string_to_event_location): Return event_location_up.
1710         * linespec.c (canonicalize_linespec, event_location_to_sals)
1711         (decode_line_with_current_source)
1712         (decode_line_with_last_displayed, decode_objc): Update.
1713         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
1714         * completer.c (location_completer): Update.
1715         * cli/cli-cmds.c (edit_command, list_command): Update.
1716         * breakpoint.c (create_overlay_event_breakpoint)
1717         (create_longjmp_master_breakpoint)
1718         (create_std_terminate_master_breakpoint)
1719         (create_exception_master_breakpoint)
1720         (create_thread_event_breakpoint): Update.
1721         (init_breakpoint_sal): Update.  Remove some dead code.
1722         (create_breakpoint_sal): Change type of "location".  Update.
1723         (create_breakpoints_sal, create_breakpoint, break_command_1)
1724         (dprintf_command, break_range_command, until_break_command)
1725         (init_ada_exception_breakpoint)
1726         (strace_marker_create_sals_from_location)
1727         (update_static_tracepoint, trace_command, ftrace_command)
1728         (strace_command, create_tracepoint_from_upload): Update.
1729         * break-catch-throw.c (re_set_exception_catchpoint): Update.
1730         * ax-gdb.c (agent_command_1): Update.
1731
1732 2017-04-12  Pedro Alves  <palves@redhat.com>
1733
1734         * Makefile.in (ALL_TARGET_OBS): Add i386-go32-tdep.o.
1735         * configure.tgt: Handle i[34567]86-*-go32* and
1736         i[34567]86-*-msdosdjgpp*.
1737         * i386-tdep.c (i386_svr4_reg_to_regnum):
1738         Make extern.
1739         (i386_go32_init_abi, i386_coff_osabi_sniffer): Moved to
1740         i386-go32-tdep.c.
1741         (_initialize_i386_tdep): DJGPP bits moved to i386-go32-tdep.c.
1742         * i386-go32-tdep.c: New file.
1743         * i386-tdep.h (tdesc_i386_mmx, i386_svr4_reg_to_regnum): New
1744         declarations.
1745
1746 2017-04-12  Simon Marchi  <simon.marchi@ericsson.com>
1747
1748         * aix-thread.c (pd_status2str): Change return type to const char *.
1749
1750 2017-04-12  Pedro Alves  <palves@redhat.com>
1751
1752         * i386-tdep.c (i386_elf_init_abi, i386_go32_init_abi): Remove
1753         calls to set_gdbarch_gnu_triplet_regexp.
1754
1755 2017-04-12  Pedro Alves  <palves@redhat.com>
1756
1757         PR gdb/21323
1758         * c-lang.c (cplus_primitive_types) <cplus_primitive_type_wchar_t>:
1759         New enum value.
1760         (cplus_language_arch_info): Register cplus_primitive_type_wchar_t.
1761         * gdbtypes.h (struct builtin_type) <builtin_wchar>: New field.
1762         * gdbtypes.c (gdbtypes_post_init): Create the "wchar_t" type.
1763         * gdbarch.sh (wchar_bit, wchar_signed): New per-arch values.
1764         * gdbarch.h, gdbarch.c: Regenerate.
1765         * aarch64-tdep.c (aarch64_gdbarch_init): Override
1766         gdbarch_wchar_bit and gdbarch_wchar_signed.
1767         * alpha-tdep.c (alpha_gdbarch_init): Likewise.
1768         * arm-tdep.c (arm_gdbarch_init): Likewise.
1769         * avr-tdep.c (avr_gdbarch_init): Likewise.
1770         * h8300-tdep.c (h8300_gdbarch_init): Likewise.
1771         * i386-nto-tdep.c (i386nto_init_abi): Likewise.
1772         * i386-tdep.c (i386_go32_init_abi): Likewise.
1773         * m32r-tdep.c (m32r_gdbarch_init): Likewise.
1774         * moxie-tdep.c (moxie_gdbarch_init): Likewise.
1775         * nds32-tdep.c (nds32_gdbarch_init): Likewise.
1776         * rs6000-aix-tdep.c (rs6000_aix_init_osabi): Likewise.
1777         * sh-tdep.c (sh_gdbarch_init): Likewise.
1778         * sparc-tdep.c (sparc32_gdbarch_init): Likewise.
1779         * sparc64-tdep.c (sparc64_init_abi): Likewise.
1780         * windows-tdep.c (windows_init_abi): Likewise.
1781         * xstormy16-tdep.c (xstormy16_gdbarch_init): Likewise.
1782
1783 2017-04-12  Pedro Alves  <palves@redhat.com>
1784
1785         PR c++/21323
1786         * c-lang.c (cplus_primitive_types) <cplus_primitive_type_char16_t,
1787         cplus_primitive_type_char32_t>: New enum values.
1788         (cplus_language_arch_info): Register cplus_primitive_type_char16_t
1789         and cplus_primitive_type_char32_t.
1790         * dwarf2read.c (read_base_type) <DW_ATE_UTF>: If bit size is 16 or
1791         32, use the archtecture's built-in type for char16_t and char32_t,
1792         respectively.  Otherwise, fallback to init_integer_type as before,
1793         but make the type unsigned, and issue a complaint.
1794         * gdbtypes.c (gdbtypes_post_init): Make char16_t and char32_t unsigned.
1795
1796 2017-04-12  Alan Hayward  <alan.hayward@arm.com>
1797
1798         * m32r-tdep.c (M32R_ARG_REGISTER_SIZE): Added.
1799         (m32r_push_dummy_call): Use M32R_ARG_REGISTER_SIZE.
1800
1801 2017-04-12  Sergio Durigan Junior  <sergiodj@redhat.com>
1802
1803         * windows-nat.c (windows_create_inferior): Declare 'toexec' as
1804         'const char *'.
1805
1806 2017-04-12  Sergio Durigan Junior  <sergiodj@redhat.com>
1807
1808         * common/common-utils.c (free_vector_argv): New function.
1809         * common/common-utils.h: Include <vector>.
1810         (free_vector_argv): New prototype.
1811         * darwin-nat.c (darwin_create_inferior): Rewrite function
1812         prototype in order to constify "exec_file" and accept a
1813         "std::string" for "allargs".
1814         * fork-child.c: Include <vector>.
1815         (breakup_args): Rewrite function, using C++.
1816         (fork_inferior): Rewrite function header, constify "exec_file_arg"
1817         and accept "std::string" for "allargs".  Update the code to
1818         calculate "argv" based on "allargs".  Update calls to "exec_fun"
1819         and "execvp".
1820         * gnu-nat.c (gnu_create_inferior): Rewrite function prototype in
1821         order to constify "exec_file" and accept a "std::string" for
1822         "allargs".
1823         * go32-nat.c (go32_create_inferior): Likewise.
1824         * inf-ptrace.c (inf_ptrace_create_inferior): Likewise.
1825         * infcmd.c (run_command_1): Constify "exec_file".  Use
1826         "std::string" for inferior arguments.
1827         * inferior.h (fork_inferior): Update prototype.
1828         * linux-nat.c (linux_nat_create_inferior): Rewrite function
1829         prototype in order to constify "exec_file" and accept a
1830         "std::string" for "allargs".
1831         * nto-procfs.c (procfs_create_inferior): Likewise.
1832         * procfs.c (procfs_create_inferior): Likewise.
1833         * remote-sim.c (gdbsim_create_inferior): Likewise.
1834         * remote.c (extended_remote_run): Update code to accept
1835         "std::string" as argument.
1836         (extended_remote_create_inferior): Rewrite function prototype in
1837         order to constify "exec_file" and accept a "std::string" for
1838         "allargs".
1839         * rs6000-nat.c (super_create_inferior): Likewise.
1840         (rs6000_create_inferior): Likewise.
1841         * target.h (struct target_ops) <to_create_inferior>: Likewise.
1842         * windows-nat.c (windows_create_inferior): Likewise.
1843
1844 2017-04-11  Pedro Alves  <palves@redhat.com>
1845
1846         * thread.c: Fix whitespace throughout.
1847
1848 2017-04-11  Philipp Rudo  <prudo@linux.vnet.ibm.com>
1849
1850         * linux-nat.c (linux_nat_detach): Remove delete_lwp call.
1851
1852 2017-04-11  Alan Hayward  <alan.hayward@arm.com>
1853
1854         * arm-tdep.c (arm_store_return_value): Use FP_REGISTER_SIZE
1855
1856 2017-04-10  Sergio Durigan Junior  <sergiodj@redhat.com>
1857
1858         PR gdb/21364
1859         * osdata.c (info_osdata): Check if 'type' is an empty string
1860         instead of NULL.
1861
1862 2017-04-10  Pedro Alves  <palves@redhat.com>
1863
1864         * thread.c (add_thread_silent, delete_thread_1, find_thread_ptid)
1865         (ptid_to_global_thread_id, in_thread_list)
1866         (do_captured_list_thread_ids, set_resumed, set_running)
1867         (set_executing, set_stop_requested, finish_thread_state)
1868         (validate_registers_access, can_access_registers_ptid)
1869         (print_thread_info_1, switch_to_thread)
1870         (do_restore_current_thread_cleanup)
1871         (make_cleanup_restore_current_thread, thread_command)
1872         (thread_name_command): Use operator== instead of ptid_equal.
1873
1874 2017-04-10  Pedro Alves  <palves@redhat.com>
1875
1876         * thread.c (struct current_thread_cleanup) <next>: Delete field.
1877         (current_thread_cleanup_chain): Delete.
1878         (restore_current_thread_cleanup_dtor)
1879         (make_cleanup_restore_current_thread): Remove references to
1880         current_thread_cleanup_chain.
1881
1882 2017-04-10  Alan Hayward  <alan.hayward@arm.com>
1883
1884         * msp430-tdep.c (msp430_pseudo_register_read): Never return
1885         REG_UNKNOWN.
1886
1887 2017-04-10  Yao Qi  <yao.qi@linaro.org>
1888
1889         PR gdb/19942
1890         * gdbthread.h (thread_info::deletable): New method.
1891         (thread_info::incref): New method.
1892         (thread_info::decref): New method.
1893         (thread_info::refcount): Move it to private.
1894         * infrun.c (save_stop_context): Call inc_refcount.
1895         (release_stop_context_cleanup): Likewise.
1896         * thread.c (set_thread_exited): New function.
1897         (init_thread_list): Delete "tp" only it is deletable, otherwise
1898         call set_thread_exited.
1899         (delete_thread_1): Call set_thread_exited.
1900         (current_thread_cleanup) <inferior_pid>: Remove.
1901         <thread>: New field.
1902         (restore_current_thread_ptid_changed): Removed.
1903         (do_restore_current_thread_cleanup): Adjust.
1904         (restore_current_thread_cleanup_dtor): Don't call
1905         find_thread_ptid.
1906         (set_thread_refcount): Use dec_refcount.
1907         (make_cleanup_restore_current_thread): Adjust.
1908         (thread_apply_all_command): Call inc_refcount.
1909         (_initialize_thread): Don't call
1910         observer_attach_thread_ptid_changed.
1911
1912 2017-04-10  Yao Qi  <yao.qi@linaro.org>
1913
1914         * thread.c (delete_thread_1): Hoist code on marking thread as
1915         exited.
1916
1917 2017-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
1918
1919         * windows-nat.c (windows_detach): Initialize ptid with
1920         minus_one_ptid.
1921
1922 2017-04-07  Simon Marchi  <simon.marchi@ericsson.com>
1923
1924         * unittests/ptid-selftests.c: Fix erroneous assert messages.
1925
1926 2017-04-07  Alan Hayward  <alan.hayward@arm.com>
1927
1928         * bfin-tdep.c (BFIN_MAX_REGISTER_SIZE): Add.
1929         (bfin_pseudo_register_read): Use BFIN_MAX_REGISTER_SIZE.
1930         (bfin_pseudo_register_write): Likewise
1931
1932 2017-04-06  Simon Marchi  <simon.marchi@ericsson.com>
1933
1934         * common/ptid.h (struct ptid): Change to...
1935         (class ptid_t): ... this.
1936         <ptid_t>: New constructors.
1937         <pid, lwp_p, lwp, tid_p, tid, is_pid, operator==, operator!=,
1938         matches>: New methods.
1939         <make_null, make_minus_one>: New static methods.
1940         <pid>: Rename to...
1941         <m_pid>: ...this.
1942         <lwp>: Rename to...
1943         <m_lwp>: ...this.
1944         <tid>: Rename to...
1945         <m_tid>: ...this.
1946         (ptid_build, ptid_get_pid, ptid_get_lwp, ptid_get_tid, ptid_equal,
1947         ptid_is_pid, ptid_lwp_p, ptid_tid_p, ptid_match): Take ptid arguments
1948         as references, move comment to class ptid_t.
1949         * common/ptid.c (null_ptid, minus_one_ptid): Initialize with
1950         ptid_t static methods.
1951         (ptid_build, pid_to_ptid, ptid_get_pid, ptid_get_tid,
1952         ptid_equal, ptid_is_pid, ptid_lwp_p, ptid_tid_p, ptid_match):
1953         Take ptid arguments as references, implement using ptid_t methods.
1954         * unittests/ptid-selftests.c: New file.
1955         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1956         unittests/ptid-selftests.c.
1957         (SUBDIR_UNITTESTS_OBS): Add unittests/ptid-selftests.o.
1958
1959 2017-04-06  Thomas Preud'homme  <thomas.preudhomme@arm.com>
1960
1961         * python/python.c (python_run_simple_file): Cast mode literal to
1962         non-const char pointer as expected by PyFile_FromString.
1963
1964 2017-04-05  Simon Marchi  <simon.marchi@ericsson.com>
1965
1966         * common/ptid.c (ptid_lwp_p, ptid_tid_p): Remove comparison with
1967         minus_one_ptid and null_ptid.
1968
1969 2017-04-05  Pedro Alves  <palves@redhat.com>
1970
1971         * warning.m4 (build_warnings): Remove -Wno-write-strings.
1972         * configure: Regenerate.
1973
1974 2017-04-05  Pedro Alves  <palves@redhat.com>
1975
1976         * ada-exp.y (yyerror): Constify.
1977         * ada-lang.c (bound_name, get_selections)
1978         (ada_variant_discrim_type)
1979         (ada_variant_discrim_name, ada_value_struct_elt)
1980         (ada_lookup_struct_elt_type, is_unchecked_variant)
1981         (ada_which_variant_applies, standard_exc, ada_get_next_arg)
1982         (catch_ada_exception_command_split)
1983         (catch_ada_assert_command_split, catch_assert_command)
1984         (ada_op_name): Constify.
1985         * ada-lang.h (ada_yyerror, get_selections)
1986         (ada_variant_discrim_name, ada_value_struct_elt): Constify.
1987         * arc-tdep.c (arc_print_frame_cache): Constify.
1988         * arm-tdep.c (arm_skip_stub): Constify.
1989         * ax-gdb.c (gen_binop, gen_struct_ref_recursive, gen_struct_ref)
1990         (gen_aggregate_elt_ref): Constify.
1991         * bcache.c (print_bcache_statistics): Constify.
1992         * bcache.h (print_bcache_statistics): Constify.
1993         * break-catch-throw.c (catch_exception_command_1):
1994         * breakpoint.c (struct ep_type_description::description):
1995         Constify.
1996         (add_solib_catchpoint): Constify.
1997         (catch_fork_command_1): Add cast.
1998         (add_catch_command): Constify.
1999         * breakpoint.h (add_catch_command, add_solib_catchpoint):
2000         Constify.
2001         * bsd-uthread.c (bsd_uthread_state): Constify.
2002         * buildsym.c (patch_subfile_names): Constify.
2003         * buildsym.h (next_symbol_text_func, patch_subfile_names):
2004         Constify.
2005         * c-exp.y (yyerror): Constify.
2006         (token::oper): Constify.
2007         * c-lang.h (c_yyerror, cp_print_class_member): Constify.
2008         * c-varobj.c (cplus_describe_child): Constify.
2009         * charset.c (find_charset_names): Add cast.
2010         (find_charset_names): Constify array and add const_cast.
2011         * cli/cli-cmds.c (complete_command, cd_command): Constify.
2012         (edit_command): Constify.
2013         * cli/cli-decode.c (lookup_cmd): Constify.
2014         * cli/cli-dump.c (dump_memory_command, dump_value_command):
2015         Constify.
2016         (struct dump_context): Constify.
2017         (add_dump_command, restore_command): Constify.
2018         * cli/cli-script.c (get_command_line): Constify.
2019         * cli/cli-script.h (get_command_line): Constify.
2020         * cli/cli-utils.c (check_for_argument): Constify.
2021         * cli/cli-utils.h (check_for_argument): Constify.
2022         * coff-pe-read.c (struct read_pe_section_data): Constify.
2023         * command.h (lookup_cmd): Constify.
2024         * common/print-utils.c (decimal2str): Constify.
2025         * completer.c (gdb_print_filename): Constify.
2026         * corefile.c (set_gnutarget): Constify.
2027         * cp-name-parser.y (yyerror): Constify.
2028         * cp-valprint.c (cp_print_class_member): Constify.
2029         * cris-tdep.c (cris_register_name, crisv32_register_name):
2030         Constify.
2031         * d-exp.y (yyerror): Constify.
2032         (struct token::oper): Constify.
2033         * d-lang.h (d_yyerror): Constify.
2034         * dbxread.c (struct header_file_location::name): Constify.
2035         (add_old_header_file, add_new_header_file, last_function_name)
2036         (dbx_next_symbol_text, add_bincl_to_list)
2037         (find_corresponding_bincl_psymtab, set_namestring)
2038         (find_stab_function_addr, read_dbx_symtab, start_psymtab)
2039         (dbx_end_psymtab, read_ofile_symtab, process_one_symbol):
2040         * defs.h (command_line_input, print_address_symbolic)
2041         (deprecated_readline_begin_hook): Constify.
2042         * dwarf2read.c (anonymous_struct_prefix, dwarf_bool_name):
2043         Constify.
2044         * event-top.c (handle_line_of_input): Constify and add cast.
2045         * exceptions.c (catch_errors): Constify.
2046         * exceptions.h (catch_errors): Constify.
2047         * expprint.c (print_subexp_standard, op_string, op_name)
2048         (op_name_standard, dump_raw_expression, dump_raw_expression):
2049         * expression.h (op_name, op_string, dump_raw_expression):
2050         Constify.
2051         * f-exp.y (yyerror): Constify.
2052         (struct token::oper): Constify.
2053         (struct f77_boolean_val::name): Constify.
2054         * f-lang.c (f_word_break_characters): Constify.
2055         * f-lang.h (f_yyerror): Constify.
2056         * fork-child.c (fork_inferior): Add cast.
2057         * frv-tdep.c (struct gdbarch_tdep::register_names): Constify.
2058         (new_variant): Constify.
2059         * gdbarch.sh (pstring_ptr, pstring_list): Constify.
2060         * gdbarch.c: Regenerate.
2061         * gdbcore.h (set_gnutarget): Constify.
2062         * go-exp.y (yyerror): Constify.
2063         (token::oper): Constify.
2064         * go-lang.h (go_yyerror): Constify.
2065         * go32-nat.c (go32_sysinfo): Constify.
2066         * guile/scm-breakpoint.c (gdbscm_breakpoint_expression): Constify.
2067         * guile/scm-cmd.c (cmdscm_function): Constify.
2068         * guile/scm-param.c (pascm_param_value): Constify.
2069         * h8300-tdep.c (h8300_register_name, h8300s_register_name)
2070         (h8300sx_register_name): Constify.
2071         * hppa-tdep.c (hppa32_register_name, hppa64_register_name):
2072         Constify.
2073         * ia64-tdep.c (ia64_register_names): Constify.
2074         * infcmd.c (construct_inferior_arguments): Constify.
2075         (path_command, attach_post_wait): Constify.
2076         * language.c (show_range_command, show_case_command)
2077         (unk_lang_error): Constify.
2078         * language.h (language_defn::la_error)
2079         (language_defn::la_name_of_this): Constify.
2080         * linespec.c (decode_line_2): Constify.
2081         * linux-thread-db.c (thread_db_err_str): Constify.
2082         * lm32-tdep.c (lm32_register_name): Constify.
2083         * m2-exp.y (yyerror): Constify.
2084         * m2-lang.h (m2_yyerror): Constify.
2085         * m32r-tdep.c (m32r_register_names): Constify and make static.
2086         * m68hc11-tdep.c (m68hc11_register_names): Constify.
2087         * m88k-tdep.c (m88k_register_name): Constify.
2088         * macroexp.c (appendmem): Constify.
2089         * mdebugread.c (fdr_name, add_data_symbol, parse_type)
2090         (upgrade_type, parse_external, parse_partial_symbols)
2091         (mdebug_next_symbol_text, cross_ref, mylookup_symbol, new_psymtab)
2092         (new_symbol): Constify.
2093         * memattr.c (mem_info_command): Constify.
2094         * mep-tdep.c (register_name_from_keyword): Constify.
2095         * mi/mi-cmd-env.c (mi_cmd_env_path, _initialize_mi_cmd_env):
2096         Constify.
2097         * mi/mi-cmd-stack.c (list_args_or_locals): Constify.
2098         * mi/mi-cmd-var.c (mi_cmd_var_show_attributes): Constify.
2099         * mi/mi-main.c (captured_mi_execute_command): Constify and add
2100         cast.
2101         (mi_execute_async_cli_command): Constify.
2102         * mips-tdep.c (mips_register_name): Constify.
2103         * mn10300-tdep.c (register_name, mn10300_generic_register_name)
2104         (am33_register_name, am33_2_register_name)
2105         * moxie-tdep.c (moxie_register_names): Constify.
2106         * nat/linux-osdata.c (osdata_type): Constify fields.
2107         * nto-tdep.c (nto_parse_redirection): Constify.
2108         * objc-lang.c (lookup_struct_typedef, lookup_objc_class)
2109         (lookup_child_selector): Constify.
2110         (objc_methcall::name): Constify.
2111         * objc-lang.h (lookup_objc_class, lookup_child_selector)
2112         (lookup_struct_typedef): Constify.
2113         * objfiles.c (pc_in_section): Constify.
2114         * objfiles.h (pc_in_section): Constify.
2115         * p-exp.y (struct token::oper): Constify.
2116         (yyerror): Constify.
2117         * p-lang.h (pascal_yyerror): Constify.
2118         * parser-defs.h (op_name_standard): Constify.
2119         (op_print::string): Constify.
2120         (exp_descriptor::op_name): Constify.
2121         * printcmd.c (print_address_symbolic): Constify.
2122         * psymtab.c (print_partial_symbols): Constify.
2123         * python/py-breakpoint.c (stop_func): Constify.
2124         (bppy_get_expression): Constify.
2125         * python/py-cmd.c (cmdpy_completer::name): Constify.
2126         (cmdpy_function): Constify.
2127         * python/py-event.c (evpy_add_attribute)
2128         (gdbpy_initialize_event_generic): Constify.
2129         * python/py-event.h (evpy_add_attribute)
2130         (gdbpy_initialize_event_generic): Constify.
2131         * python/py-evts.c (add_new_registry): Constify.
2132         * python/py-finishbreakpoint.c (outofscope_func): Constify.
2133         * python/py-framefilter.c (get_py_iter_from_func): Constify.
2134         * python/py-inferior.c (get_buffer): Add cast.
2135         * python/py-param.c (parm_constant::name): Constify.
2136         * python/py-unwind.c (fprint_frame_id): Constify.
2137         * python/python.c (gdbpy_parameter_value): Constify.
2138         * remote-fileio.c (remote_fio_func_map): Make 'name' const.
2139         * remote.c (memory_packet_config::name): Constify.
2140         (show_packet_config_cmd, remote_write_bytes)
2141         (remote_buffer_add_string):
2142         * reverse.c (exec_reverse_once): Constify.
2143         * rs6000-tdep.c (variant::name, variant::description): Constify.
2144         * rust-exp.y (rustyyerror): Constify.
2145         * rust-lang.c (rust_op_name): Constify.
2146         * rust-lang.h (rustyyerror): Constify.
2147         * serial.h (serial_ops::name): Constify.
2148         * sh-tdep.c (sh_sh_register_name, sh_sh3_register_name)
2149         (sh_sh3e_register_name, sh_sh2e_register_name)
2150         (sh_sh2a_register_name, sh_sh2a_nofpu_register_name)
2151         (sh_sh_dsp_register_name, sh_sh3_dsp_register_name)
2152         (sh_sh4_register_name, sh_sh4_nofpu_register_name)
2153         (sh_sh4al_dsp_register_name): Constify.
2154         * sh64-tdep.c (sh64_register_name): Constify.
2155         * solib-darwin.c (lookup_symbol_from_bfd): Constify.
2156         * spu-tdep.c (spu_register_name, info_spu_dma_cmdlist): Constify.
2157         * stabsread.c (patch_block_stabs, read_type_number)
2158         (ref_map::stabs, ref_add, process_reference)
2159         (symbol_reference_defined, define_symbol, define_symbol)
2160         (error_type, read_type, read_member_functions, read_cpp_abbrev)
2161         (read_one_struct_field, read_struct_fields, read_baseclasses)
2162         (read_tilde_fields, read_struct_type, read_array_type)
2163         (read_enum_type, read_sun_builtin_type, read_sun_floating_type)
2164         (read_huge_number, read_range_type, read_args, common_block_start)
2165         (find_name_end): Constify.
2166         * stabsread.h (common_block_start, define_symbol)
2167         (process_one_symbol, symbol_reference_defined, ref_add):
2168         * symfile.c (get_section_index, add_symbol_file_command):
2169         * symfile.h (get_section_index): Constify.
2170         * target-descriptions.c (tdesc_type::name): Constify.
2171         (tdesc_free_type): Add cast.
2172         * target.c (find_default_run_target):
2173         (add_deprecated_target_alias, find_default_run_target)
2174         (target_announce_detach): Constify.
2175         (do_option): Constify.
2176         * target.h (add_deprecated_target_alias): Constify.
2177         * thread.c (print_thread_info_1): Constify.
2178         * top.c (deprecated_readline_begin_hook, command_line_input):
2179         Constify.
2180         (init_main): Add casts.
2181         * top.h (handle_line_of_input): Constify.
2182         * tracefile-tfile.c (tfile_write_uploaded_tsv): Constify.
2183         * tracepoint.c (tvariables_info_1, trace_status_mi): Constify.
2184         (tfind_command): Rename to ...
2185         (tfind_command_1): ... this and constify.
2186         (tfind_command): New function.
2187         (tfind_end_command, tfind_start_command): Adjust.
2188         (encode_source_string): Constify.
2189         * tracepoint.h (encode_source_string): Constify.
2190         * tui/tui-data.c (tui_partial_win_by_name): Constify.
2191         * tui/tui-data.h (tui_partial_win_by_name): Constify.
2192         * tui/tui-source.c (tui_set_source_content_nil): Constify.
2193         * tui/tui-source.h (tui_set_source_content_nil): Constify.
2194         * tui/tui-win.c (parse_scrolling_args): Constify.
2195         * tui/tui-windata.c (tui_erase_data_content): Constify.
2196         * tui/tui-windata.h (tui_erase_data_content): Constify.
2197         * tui/tui-winsource.c (tui_erase_source_content): Constify.
2198         * tui/tui.c (tui_enable): Add cast.
2199         * utils.c (defaulted_query): Constify.
2200         (init_page_info): Add cast.
2201         (puts_debug, subset_compare): Constify.
2202         * utils.h (subset_compare): Constify.
2203         * varobj.c (varobj_format_string): Constify.
2204         * varobj.h (varobj_format_string): Constify.
2205         * vax-tdep.c (vax_register_name): Constify.
2206         * windows-nat.c (windows_detach): Constify.
2207         * xcoffread.c (process_linenos, xcoff_next_symbol_text): Constify.
2208         * xml-support.c (gdb_xml_end_element): Constify.
2209         * xml-tdesc.c (tdesc_start_reg): Constify.
2210         * xstormy16-tdep.c (xstormy16_register_name): Constify.
2211         * xtensa-tdep.c (xtensa_find_register_by_name): Constify.
2212         * xtensa-tdep.h (xtensa_register_t::name): Constify.
2213
2214 2017-04-05  Pedro Alves  <palves@redhat.com>
2215
2216         * proc-api.c (struct trans): Constify.
2217         (procfs_note): Constify.
2218         * proc-events.c (struct trans, syscall_table):
2219         * proc-flags.c (struct trans): Constify.
2220         * proc-utils.h (procfs_note): Constify.
2221         * proc-why.c (struct trans): Constify.
2222         * procfs.c (dead_procinfo, find_syscall, proc_warn, proc_error)
2223         (procfs_detach): Constify.
2224         * sol-thread.c (struct string_map): Constify.
2225         (td_err_string, td_state_string): Constify.
2226
2227 2017-04-05  Pedro Alves  <palves@redhat.com>
2228
2229         * proc-api.c (procfs_filename): Don't initialize
2230         procfs_filename.
2231         (prepare_to_trace): Assume procfs_filename is non-NULL.
2232         (_initialize_proc_api): Give procfs_filename a default value here.
2233
2234 2017-04-05  Pedro Alves  <palves@redhat.com>
2235
2236         * break-catch-throw.c (handle_gnu_v3_exceptions): Constify
2237         'cond_string' parameter.
2238         (extract_exception_regexp): Constify 'string' parameter.
2239         (catch_exception_command_1): Constify.
2240         * breakpoint.c (init_catchpoint)
2241         (create_fork_vfork_event_catchpoint): Constify 'cond_string'
2242         parameter.
2243         (ep_parse_optional_if_clause, catch_fork_command_1)
2244         (catch_exec_command_1): Constify.
2245         * breakpoint.h (init_catchpoint): Constify 'cond_string'
2246         parameter.
2247         (ep_parse_optional_if_clause): Constify.
2248         * cli/cli-utils.c (remove_trailing_whitespace)
2249         (check_for_argument): Constify.
2250         * cli/cli-utils.h (remove_trailing_whitespace): Constify and add
2251         non-const overload.
2252         (check_for_argument): Likewise.
2253
2254 2017-04-05  Pedro Alves  <palves@redhat.com>
2255
2256         * event-top.c (command_line_handler): Add cast to execute_command
2257         call.
2258         * record-btrace.c (cmd_record_btrace_bts_start)
2259         (cmd_record_btrace_pt_start, cmd_record_btrace_start)
2260         (cmd_record_btrace_start): Add cast to execute_command call.
2261         * record-full.c (record_full_goto_insn):
2262         * record.c (record_start, record_stop): Add cast to
2263         execute_command_to_string calls.
2264         (cmd_record_start): Add cast to execute_command calls.
2265
2266 2017-04-05  Pedro Alves  <palves@redhat.com>
2267
2268         * python/python-internal.h (gdb_PyArg_ParseTupleAndKeywords): New
2269         static inline function.
2270         * python/py-arch.c (archpy_disassemble): Constify 'keywords'
2271         array and use gdb_PyArg_ParseTupleAndKeywords.
2272         * python/py-cmd.c (cmdpy_init): Likewise.
2273         * python/py-finishbreakpoint.c (bpfinishpy_init): Likewise.
2274         * python/py-inferior.c (infpy_read_memory, infpy_write_memory)
2275         (infpy_search_memory): Likewise.
2276         * python/py-objfile.c (objfpy_add_separate_debug_file)
2277         (gdbpy_lookup_objfile): Likewise.
2278         * python/py-symbol.c (gdbpy_lookup_symbol)
2279         (gdbpy_lookup_global_symbol): Likewise.
2280         * python/py-type.c (gdbpy_lookup_type): Likewise.
2281         * python/py-value.c (valpy_lazy_string, valpy_string): Likewise.
2282         * python/python.c (execute_gdb_command, gdbpy_write, gdbpy_flush):
2283         Likewise.
2284
2285 2017-04-05  Pedro Alves  <palves@redhat.com>
2286
2287         * python/python-internal.h (gdb_PyGetSetDef): New type.
2288         * python/py-block.c (block_object_getset)
2289         (breakpoint_object_getset): Now a gdb_PyGetSetDef array.
2290         * python/py-event.c (event_object_getset)
2291         (finish_breakpoint_object_getset): Likewise.
2292         * python/py-inferior.c (inferior_object_getset): Likewise.
2293         * python/py-infthread.c (thread_object_getset): Likewise.
2294         * python/py-lazy-string.c (lazy_string_object_getset): Likewise.
2295         * python/py-linetable.c (linetable_entry_object_getset): Likewise.
2296         * python/py-objfile.c (objfile_getset): Likewise.
2297         * python/py-progspace.c (pspace_getset): Likewise.
2298         * python/py-record-btrace.c (btpy_insn_getset, btpy_call_getset):
2299         Likewise.
2300         * python/py-record.c (recpy_record_getset): Likewise.
2301         * python/py-symbol.c (symbol_object_getset): Likewise.
2302         * python/py-symtab.c (symtab_object_getset, sal_object_getset):
2303         Likewise.
2304         * python/py-type.c (type_object_getset, field_object_getset):
2305         Likewise.
2306         * python/py-value.c (value_object_getset): Likewise.
2307
2308 2017-04-05  Pedro Alves  <palves@redhat.com>
2309
2310         * python/python-internal.h (gdb_PyObject_CallMethod)
2311         (gdb_PyErr_NewException, gdb_PySys_GetObject, gdb_PySys_SetPath):
2312         New functions.
2313         (GDB_PYSYS_SETPATH_CHAR, PyObject_CallMethod, PyErr_NewException)
2314         (PySys_GetObject, PySys_SetPath): New macros.
2315
2316 2017-04-05  Pedro Alves  <palves@redhat.com>
2317
2318         * mi/mi-cmd-info.c (mi_cmd_info_os): Call info_osdata instead of
2319         info_osdata_command.
2320         * osdata.c (info_osdata_command): Rename to ...
2321         (info_osdata): ... this.  Constify 'type' parameter, and remove
2322         the 'from_tty' parameter.  Accept NULL TYPE.
2323         (info_osdata_command): New function.
2324         * osdata.h (info_osdata_command): Remove declaration.
2325         (info_osdata): New declaration.
2326
2327 2017-04-05  Pedro Alves  <palves@redhat.com>
2328
2329         * mi/mi-cmd-break.c (mi_cmd_break_insert_1, mi_cmd_break_insert)
2330         (mi_cmd_dprintf_insert, mi_cmd_break_passcount)
2331         (mi_cmd_break_watch, mi_cmd_break_commands): Constify 'command'
2332         parameter.
2333         * mi/mi-cmd-catch.c (mi_cmd_catch_assert, mi_cmd_catch_exception)
2334         (mi_cmd_catch_load, mi_cmd_catch_unload): Constify cmd' parameter.
2335         * mi/mi-cmd-disas.c (mi_cmd_disassemble): Constify 'command'
2336         parameter.
2337         * mi/mi-cmd-env.c (mi_cmd_env_pwd, mi_cmd_env_cd, mi_cmd_env_path)
2338         (mi_cmd_env_dir, mi_cmd_inferior_tty_set, _cmd_inferior_tty_show)
2339         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file)
2340         (mi_cmd_file_list_exec_source_files)
2341         (mi_cmd_file_list_shared_libraries): Constify 'command' parameter.
2342         * mi/mi-cmd-info.c (mi_cmd_info_ada_exceptions)
2343         (mi_cmd_info_gdb_mi_command, mi_cmd_info_os): Constify 'command'
2344         parameter.
2345         * mi/mi-cmd-stack.c (mi_cmd_enable_frame_filters)
2346         (mi_cmd_stack_list_frames, mi_cmd_stack_info_depth)
2347         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2348         (mi_cmd_stack_list_variables, mi_cmd_stack_select_frame)
2349         (mi_cmd_stack_info_frame): Constify 'command' parameter.
2350         * mi/mi-cmd-target.c (mi_cmd_target_file_get)
2351         (mi_cmd_target_file_put, mi_cmd_target_file_delete): Constify
2352         'command' parameter.
2353         * mi/mi-cmd-var.c (mi_cmd_var_create, mi_cmd_var_delete)
2354         (mi_cmd_var_set_format, mi_cmd_var_set_visualizer)
2355         (mi_cmd_var_set_frozen, mi_cmd_var_show_format)
2356         (mi_cmd_var_info_num_children, mi_cmd_var_list_children)
2357         (mi_cmd_var_info_type, mi_cmd_var_info_path_expression)
2358         (mi_cmd_var_info_expression, mi_cmd_var_show_attributes)
2359         (mi_cmd_var_evaluate_expression, mi_cmd_var_assign)
2360         (mi_cmd_var_update, mi_cmd_enable_pretty_printing)
2361         (mi_cmd_var_set_update_range): Constify 'command' parameter.
2362         * mi/mi-cmds.h (mi_cmd_argv_ftype): Constify 'command' parameter.
2363         * mi/mi-interp.c (mi_cmd_interpreter_exec): Constify 'command'
2364         parameter.
2365         * mi/mi-main.c (mi_cmd_gdb_exit, mi_cmd_exec_next)
2366         (mi_cmd_exec_next_instruction, mi_cmd_exec_step)
2367         (mi_cmd_exec_step_instruction, mi_cmd_exec_finish)
2368         (mi_cmd_exec_return ,mi_cmd_exec_jump, mi_cmd_exec_continue)
2369         (mi_cmd_exec_interrupt, mi_cmd_exec_run, mi_cmd_target_detach)
2370         (mi_cmd_target_flash_erase, mi_cmd_thread_select)
2371         (mi_cmd_thread_list_ids, mi_cmd_thread_info)
2372         (mi_cmd_list_thread_groups, mi_cmd_data_list_register_names)
2373         (mi_cmd_data_list_changed_registers)
2374         (mi_cmd_data_write_register_values)
2375         (mi_cmd_data_evaluate_expression, mi_cmd_data_read_memory)
2376         (mi_cmd_data_read_memory_bytes, mi_cmd_data_write_memory)
2377         (mi_cmd_data_write_memory_bytes, mi_cmd_enable_timings)
2378         (mi_cmd_list_features, mi_cmd_list_target_features)
2379         (mi_cmd_add_inferior, mi_cmd_remove_inferior)
2380         (mi_cmd_trace_define_variable, mi_cmd_trace_list_variables)
2381         (mi_cmd_trace_find, mi_cmd_trace_save, mi_cmd_trace_start)
2382         (mi_cmd_trace_status, mi_cmd_trace_stop, mi_cmd_ada_task_info)
2383         (mi_cmd_trace_frame_collected): Constify 'command'
2384         parameter.
2385         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Constify
2386         'command' parameter.
2387
2388 2017-04-05  Pedro Alves  <palves@redhat.com>
2389
2390         * ada-lang.c (ada_completer_word_break_characters): Now a const
2391         array.
2392         (ada_get_gdb_completer_word_break_characters): Constify.
2393         * completer.c (gdb_completer_command_word_break_characters)
2394         (gdb_completer_file_name_break_characters)
2395         (gdb_completer_quote_characters): Now const arrays.
2396         (get_gdb_completer_quote_characters): Constify.
2397         (set_rl_completer_word_break_characters): New function.
2398         (set_gdb_completion_word_break_characters)
2399         (complete_line_internal): Use it.
2400         * completer.h (get_gdb_completer_quote_characters): Constify.
2401         (set_rl_completer_word_break_characters): Declare.
2402         * f-lang.c (f_word_break_characters): Constify.
2403         * language.c (default_word_break_characters): Constify.
2404         * language.h (language_defn::la_word_break_characters): Constify.
2405         (default_word_break_characters): Constify.
2406         * top.c (init_main): Use set_rl_completer_word_break_characters.
2407
2408 2017-04-05  Pedro Alves  <palves@redhat.com>
2409
2410         * aix-thread.c (aix_thread_pid_to_str)
2411         (aix_thread_extra_thread_info): Constify.
2412         * bsd-kvm.c (bsd_kvm_pid_to_str): Constify.
2413         * bsd-uthread.c (bsd_uthread_extra_thread_info)
2414         (bsd_uthread_pid_to_str): Constify.
2415         * corelow.c (core_pid_to_str): Constify.
2416         * darwin-nat.c (darwin_pid_to_str): Constify.
2417         * fbsd-nat.c (fbsd_pid_to_str): Constify.
2418         * fbsd-tdep.c (fbsd_core_pid_to_str, gdbarch_core_pid_to_str):
2419         Constify.
2420         * gnu-nat.c (gnu_pid_to_str): Constify.
2421         * go32-nat.c (go32_pid_to_str): Constify.
2422         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Constify.
2423         * inf-ptrace.c (inf_ptrace_pid_to_str): Constify.
2424         * inferior.c (inferior_pid_to_str): Constify.
2425         * linux-nat.c (linux_nat_pid_to_str): Constify.
2426         * linux-tdep.c (linux_core_pid_to_str): Constify.
2427         * linux-thread-db.c (thread_db_pid_to_str)
2428         (thread_db_extra_thread_info): Constify.
2429         * nto-tdep.c (nto_extra_thread_info): Constify.
2430         * nto-tdep.h (nto_extra_thread_info): Constify.
2431         * obsd-nat.c (obsd_pid_to_str): Constify.
2432         * procfs.c (procfs_pid_to_str): Constify.
2433         * ravenscar-thread.c (ravenscar_extra_thread_info)
2434         (ravenscar_pid_to_str): Constify.
2435         * remote-sim.c (gdbsim_pid_to_str): Constify.
2436         * remote.c (remote_threads_extra_info, remote_pid_to_str):
2437         Constify.
2438         * sol-thread.c (solaris_pid_to_str): Constify.
2439         * sol2-tdep.c (sol2_core_pid_to_str): Constify.
2440         * sol2-tdep.h (sol2_core_pid_to_str): Constify.
2441         * target.c (default_pid_to_str, target_pid_to_str)
2442         (normal_pid_to_str, default_pid_to_str): Constify.
2443         * target.h (target_ops::to_pid_to_str)
2444         (target_ops::to_extra_thread_info): Constify.
2445         (target_pid_to_str, normal_pid_to_str): Constify.
2446         * windows-nat.c (windows_pid_to_str): Constify.
2447         * gdbarch.sh (core_pid_to_str): Constify.
2448         * target-delegates.c: Regenerate.
2449         * gdbarch.h, gdbarch.c: Regenerate.
2450
2451 2017-04-05  Pedro Alves  <palves@redhat.com>
2452
2453         * main.c (captured_main_1): Use gdb::unique_xmalloc_ptr to manage
2454         the memory of the temporary warning_pre_print override.
2455         * utils.c (warning_pre_print): Constify.
2456         * utils.h (warning_pre_print): Constify.
2457
2458 2017-04-05  Pedro Alves  <palves@redhat.com>
2459
2460         * cli/cli-cmds.c (shell_escape): Constify 'arg' parameter.
2461         (shell_command): New function.
2462         (make_command): Use std::string.
2463         (init_cli_cmds): Register shell_command instead of shell_escape.
2464
2465 2017-04-05  Pedro Alves  <palves@redhat.com>
2466
2467         * breakpoint.c (dprintf_function, dprintf_channel): Don't initialize.
2468         * tracepoint.c (default_collect): Don't initialize.
2469
2470 2017-04-05  Pedro Alves  <palves@redhat.com>
2471
2472         * macroexp.c (macro_buffer::shared): Now a bool.
2473         (init_buffer): Update.
2474         (init_shared_buffer): Constify 'addr' parameter.
2475         (substitute_args, expand, macro_expand, macro_expand_next): Remove
2476         casts.
2477
2478 2017-04-05  Pedro Alves  <palves@redhat.com>
2479
2480         * arm-tdep.c (show_disassembly_style_sfunc): Constify local.
2481         * disasm.c (set_disassembler_options): Constify local.
2482         * i386-tdep.c (i386_print_insn): Remove cast and FIXME comment.
2483
2484 2017-04-05  Sergio Durigan Junior  <sergiodj@redhat.com>
2485
2486         PR gdb/21352
2487         * tracefile.c (tsave_command): Fix argument parsing for '-r'
2488         option.
2489
2490 2017-04-05  Yao Qi  <yao.qi@linaro.org>
2491
2492         * frame.c (frame_unwind_register_unsigned): Call
2493         frame_unwind_register_value.
2494
2495 2017-04-05  Yao Qi  <yao.qi@linaro.org>
2496
2497         * gdb.threads/thread-specific-bp.exp (check_thread_specific_breakpoint):
2498         Use gdb_test_multiple, and don't match anchor.
2499
2500 2017-04-05  Pedro Alves  <palves@redhat.com>
2501
2502         * MAINTAINERS (Global Maintainers): Add Simon Marchi.
2503         (Write After Approval): Remove Simon Marchi.
2504
2505 2017-04-05  Pedro Alves  <palves@redhat.com>
2506
2507         * common/gdb_optional.h (optional::optional): Make constexpr and
2508         initialize m_dummy.
2509
2510 2017-04-04  John Baldwin  <jhb@FreeBSD.org>
2511
2512         * amd64-fbsd-tdep.c: Remove "bsd-uthread.h" include.
2513         (amd64fbsd_jmp_buf_reg_offset): Remove.
2514         (amd64fbsd_supply_uthread): Remove function.
2515         (amd64fbsd_collect_uthread): Remove function.
2516         (amd64fbsd_init_abi): Don't set bsd-uthread callbacks.
2517         * configure.tgt (i[34567]86-*-freebsd*): Remove bsd-uthread.o.
2518         (x86_64-*-freebsd*): Remove bsd-uthread.o.
2519         (fbsd-nat.c): Update comment.
2520         * i386-fbsd-tdep.c: Remove "bsd-uthread.h" include.
2521         (i386fbsd_jmp_buf_reg_offset): Remove.
2522         (i386fbsd_supply_uthread): Remove function.
2523         (i386fbsd_collect_uthread): Remove function.
2524         (i386fbsd_init_abi): Don't set bsd-uthread callbacks.
2525
2526 2017-04-04  John Baldwin  <jhb@FreeBSD.org>
2527
2528         * Makefile.in (ALL_64_TARGET_OBS): Remove alpha-fbsd-tdep.o.
2529         (ALLDEPFILES): Remove alpha-fbsd-tdep.c
2530         * NEWS: Mention that support for FreeBSD/alpha was removed.
2531         * alpha-fbsd-tdep.c: Delete file.
2532         * config/alpha/fbsd.mh: Delete file.
2533         * configure.host: Delete alpha*-*-freebsd* and
2534         alpha*-*-kfreebsd*-gnu.
2535         * configure.tgt: Delete alpha*-*-freebsd* and
2536         alpha*-*-kfreebsd*-gnu.
2537
2538 2017-04-04  John Baldwin  <jhb@FreeBSD.org>
2539
2540         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers,
2541         amd64bsd_store_inferior_registers): Use ptid from regcache.
2542
2543 2017-04-04  Pedro Alves  <palves@redhat.com>
2544
2545         * dwarf2read.c (lnp_state_machine): Now a class.  Initialize all
2546         data fields, make them private and add "m_" prefixes.
2547         (lnp_state_machine::lnp_state_machine): New ctor.
2548         (record_line, check_line_address, handle_set_discriminator)
2549         (handle_set_address, handle_advance_pc, handle_special_opcode)
2550         (handle_advance_line, handle_set_file, handle_negate_stmt)
2551         (handle_const_add_pc, handle_fixed_advance_pc, handle_copy)
2552         (end_sequence, advance_line): New methods.
2553         (m_gdbarch, m_record_lines_p): New fields.
2554         (lnp_reader_state): Delete.
2555         (dwarf_record_line): Rename to ...
2556         (lnp_state_machine::record_line): ... adjust.
2557         (init_lnp_state_machine): Delete.
2558         (lnp_state_machine::lnp_state_machine): New.
2559         (check_line_address): Rename to ...
2560         (lnp_state_machine::check_line_address): This.
2561         (dwarf_decode_lines_1): Remove reference to "reader_state".
2562         Adjust lnp_state_machine having a non-default ctor.  Use bool.
2563         State machine internal state manipulation moved to
2564         lnp_state_machine methods.
2565
2566 2017-04-04  Pedro Alves  <palves@redhat.com>
2567
2568         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
2569         unittests/offset-type-selftests.c.
2570         (SUBDIR_UNITTESTS_OBS): Add offset-type-selftests.o.
2571         * common/offset-type.h: New file.
2572         * common/preprocessor.h: New file.
2573         * common/traits.h: New file.
2574         * common/valid-expr.h: New file.
2575         * dwarf2expr.c: Include "common/underlying.h".  Adjust to use
2576         sect_offset and cu_offset strong typedefs throughout.
2577         * dwarf2expr.h: Adjust to use sect_offset and cu_offset strong
2578         typedefs throughout.
2579         * dwarf2loc.c: Include "common/underlying.h".  Adjust to use
2580         sect_offset and cu_offset strong typedefs throughout.
2581         * dwarf2read.c: Adjust to use sect_offset and cu_offset strong
2582         typedefs throughout.
2583         * gdbtypes.h: Include "common/offset-type.h".
2584         (cu_offset): Now an offset type (strong typedef) instead of a
2585         struct.
2586         (sect_offset): Likewise.
2587         (union call_site_parameter_u): Rename "param_offset" field to
2588         "param_cu_off".
2589         * unittests/offset-type-selftests.c: New file.
2590
2591 2017-04-04  Pedro Alves  <palves@redhat.com>
2592
2593         * common/underlying.h: New file.
2594         * dwarf2read.c: Include "common/gdb_optional.h" and
2595         "common/underlying.h".
2596         (dir_index, file_name_index): New types.
2597         (file_entry): Use them.
2598         (file_entry::include): Use to_underlying.
2599         (line_header::add_file_name): Use dir_index.
2600         (read_formatted_entries): Use gdb::optional.  Read form before
2601         writting to file_entry.
2602         (dwarf_decode_line_header): Use dir_index.
2603         (lnp_state_machine::current_file): Use to_underlying.
2604         (lnp_state_machine::file): Change type to file_name_index.
2605         (dwarf_record_line): Use to_underlying.
2606         (init_lnp_state_machine): Use file_name_index.
2607         (dwarf_decode_lines_1): Use dir_index and file_name_index.
2608
2609 2017-04-04  Pedro Alves  <palves@redhat.com>
2610
2611         * common/gdb_optional.h (gdb::optiona): Add operator->, operator*,
2612         operator bool, has_value and get methods.
2613
2614 2017-04-04  Pedro Alves  <palves@redhat.com>
2615
2616         * dwarf2read.c (struct file_entry): Add ctors, and initialize all
2617         fields.
2618         (line_header): Initialize all data fields.  Change type of
2619         standard_opcode_lengths to std::unique_ptr<unsigned char[]>.
2620         Change type of include_dirs to std::vector<const char *>.  Remove
2621         num_include_dirs, include_dirs_size.  Change type of file_names to
2622         std::vector<file_entry>.  Remove num_file_names, file_names_size.
2623         (line_header::line_header): New.
2624         (line_header::add_include_dir, line_header::add_file_name): New
2625         methods.
2626         (line_header::include_dir_at): Remove NULL check.
2627         (line_header::file_name_at): Add const overload.
2628         (line_header_up): New unique_ptr typedef.
2629         (dw2_get_file_names_reader): Use line_header_up.  Adjust to use
2630         std::vector.  Remove free_line_header call.
2631         (dwarf2_build_include_psymtabs): Use line_header_up.  Remove
2632         free_line_header call.
2633         (free_cu_line_header): Delete.
2634         (handle_DW_AT_stmt_list, handle_DW_AT_stmt_list)
2635         (setup_type_unit_groups): Use line_header_up instead of cleanups.
2636         Adjust to use std::vector.
2637         (free_line_header): Delete.
2638         (free_line_header_voidp): Use delete.
2639         (add_include_dir): Replace with ...
2640         (line_header::add_include_dir): ... this method.  Use std::vector.
2641         (add_file_name): Replace with ...
2642         (line_header::add_file_name): ... this method.  Use std::vector.
2643         (add_include_dir_stub): Delete.
2644         (read_formatted_entries): Remove memset.
2645         (dwarf_decode_line_header): Return a line_header_up instead of a
2646         raw pointer.  Remove cleanup handling.  Pass lambdas to
2647         read_formatted_entries.  Adjust to use line_header methods.
2648         (dwarf_decode_lines_1): Adjust to use line_header methods.
2649         (dwarf_decode_lines, file_file_name, file_full_name): Adjust to
2650         use std::vector.
2651
2652 2017-04-04  Simon Marchi  <simon.marchi@polymtl.ca>
2653
2654         * remote.c (set_general_thread, set_continue_thread): Use ptid_t
2655         instead of struct ptid.
2656
2657 2017-05-04  Alan Hayward  <alan.hayward@arm.com>
2658
2659         * frame.c (get_frame_register_bytes): Unwind using value.
2660         (put_frame_register_bytes): Likewise.
2661
2662 2017-03-30  Iain Buclaw  <ibuclaw@gdcproject.org>
2663
2664         * d-exp.y (type_aggregate_p): Treat TYPE_CODE_MODULE as being
2665         aggregate-like.
2666
2667 2017-03-29  Jan Kratochvil  <jan.kratochvil@redhat.com>
2668
2669         * auto-load.c (auto_load_section_scripts): Check SEC_HAS_CONTENTS.
2670
2671 2017-03-29  Yao Qi  <yao.qi@linaro.org>
2672
2673         * gdbthread.h (struct thread_info): Declare constructor and
2674         destructor.  Add some in-class member initializers.
2675         * thread.c (free_thread): Remove.
2676         (init_thread_list): Call delete instead of free_thread.
2677         (new_thread): Call thread_info constructor.
2678         (thread_info::thread_info): New function.
2679         (thread_info::~thread_info): New function.
2680         (delete_thread_1): Call delete instead of free_thread.
2681         (make_cleanup_restore_current_thread): Move tp and frame to
2682         inner block.
2683
2684 2017-03-28  Anton Kolesov  <anton.kolesov@synopsys.com>
2685
2686         * arc-tdep.c (arc_frame_cache): Add support for prologue analysis.
2687         (arc_skip_prologue): Likewise.
2688         (arc_make_frame_cache): Likewise.
2689         (arc_pv_get_operand): New function.
2690         (arc_is_in_prologue): Likewise.
2691         (arc_analyze_prologue): Likewise.
2692         (arc_print_frame_cache): Likewise.
2693         (MAX_PROLOGUE_LENGTH): New constant.
2694
2695 2017-03-28  Anton Kolesov  <anton.kolesov@synopsys.com>
2696
2697         * configure.tgt: Add arc-insn.o.
2698         * arc-tdep.c (arc_delayed_print_insn): Make non-static.
2699         (dump_arc_instruction_command): New function.
2700         (arc_fprintf_disasm): Likewise.
2701         (arc_disassemble_info): Likewise.
2702         (arc_insn_get_operand_value): Likewise.
2703         (arc_insn_get_operand_value_signed): Likewise.
2704         (arc_insn_get_memory_base_reg): Likewise.
2705         (arc_insn_get_memory_offset): Likewise.
2706         (arc_insn_get_branch_target): Likewise.
2707         (arc_insn_dump): Likewise.
2708         (arc_insn_get_linear_next_pc): Likewise.
2709         * arc-tdep.h (arc_delayed_print_insn): Add function declaration.
2710         (arc_disassemble_info): Likewise.
2711         (arc_insn_get_branch_target): Likewise.
2712         (arc_insn_get_linear_next_pc): Likewise.
2713         * NEWS: Mention new "maint print arc arc-instruction".
2714
2715 2017-03-28  Anton Kolesov  <anton.kolesov@synopsys.com>
2716
2717         * arc-tdep (maintenance_print_arc_list): New variable.
2718         (maintenance_print_arc_command): New function.
2719
2720 2017-03-28  Anton Kolesov  <anton.kolesov@synopsys.com>
2721
2722         * arc-tdep.c (core_v2_register_names, core_arcompact_register_names)
2723         Add "limm" and "reserved".
2724         (arc_cannot_fetch_register, arc_cannot_store_register): Add
2725         ARC_RESERVED_REGNUM and ARC_LIMM_REGNUM.
2726         * arc-tdep.h (arc_regnum): Likewise.
2727
2728 2017-03-27  Max Filippov  <jcmvbkbc@gmail.com>
2729
2730         * xtensa-linux-nat.c (fill_gregset): Call regcache_raw_collect
2731         for THREADPTR register.
2732         (supply_gregset_reg): Call regcache_raw_supply for THREADPTR
2733         register.
2734         * xtensa-tdep.c (XTENSA_DBREGN_UREG): New definition.
2735         (xtensa_derive_tdep): Initialize tdep->threadptr_regnum.
2736         * xtensa-tdep.h (gdbarch_tdep::threadptr_regnum): New field.
2737
2738 2017-03-27  Max Filippov  <jcmvbkbc@gmail.com>
2739
2740         * xtensa-tdep.c (xtensa_pseudo_register_read): Treat all
2741         registers above gdbarch_num_regs (gdbarch) as privileged in
2742         call0 ABI.
2743
2744 2017-03-27  Max Filippov  <jcmvbkbc@gmail.com>
2745
2746         * xtensa-linux-nat.c (fill_gregset): Call regcache_raw_collect
2747         for a single specified register or for all registers in
2748         a0_base..a0_base + C0_NREGS range.
2749         (supply_gregset_reg): Call regcache_raw_supply for a single
2750         specified register or for all registers in a0_base..a0_base +
2751         C0_NREGS range.
2752
2753 2017-03-27  Max Filippov  <jcmvbkbc@gmail.com>
2754
2755         * arch/xtensa.h (C0_NREGS): Add definition.
2756         * xtensa-tdep.c (C0_NREGS): Remove definition.
2757
2758 2017-03-27  Max Filippov  <jcmvbkbc@gmail.com>
2759
2760         * xtensa-tdep.c (xtensa_scan_prologue, call0_analyze_prologue):
2761         Drop xtensa_default_isa initialization.
2762         (xtensa_gdbarch_init): Initialize xtensa_default_isa.
2763
2764 2017-03-27  Pedro Alves  <palves@redhat.com>
2765
2766         * dwarf2read.c (file_entry) <dir_index>: Add comment.
2767         (file_entry::include_dir): New method.
2768         (line_header::include_dir_at, line_header::file_name_at): New
2769         methods.
2770         (setup_type_unit_groups, setup_type_unit_groups)
2771         (psymtab_include_file_name): Simplify using the new methods.
2772         (lnp_state_machine) <the_line_header>: New field.
2773         <file>: Add comment.
2774         (lnp_state_machine::current_file): New method.
2775         (dwarf_record_line): Simplify using the new methods.
2776         (init_lnp_state_machine): Initialize the "the_line_header" field.
2777         (dwarf_decode_lines_1, dwarf_decode_lines, file_file_name):
2778         Simplify using the new methods.
2779
2780 2017-03-27  Pedro Alves  <palves@redhat.com>
2781
2782         * cp-name-parser.y (make_empty): Delete.
2783         (demangler_special, nested_name, ptr_operator, array_indicator)
2784         (direct_declarator, declarator_1): Use fill_comp instead of
2785         make_empty.
2786
2787 2017-03-27  Pedro Alves  <palves@redhat.com>
2788
2789         * xml-support.h (gdb_xml_debug): Pass a "first-to-check" argument
2790         to ATTRIBUTE_PRINTF.
2791         * solib-target.c (library_list_start_list): Print "string" not
2792         "version".
2793         * xml-tdesc.c (tdesc_start_field): Pass "field_name" to
2794         gdb_xml_error call.
2795
2796 2017-03-27  Pedro Alves  <palves@redhat.com>
2797
2798         * dwarf2read.c (struct file_and_directory): New.
2799         (dwarf2_get_dwz_file): Adjust to use std::string.
2800         (dw2_get_file_names_reader): Adjust to use file_and_directory.
2801         (find_file_and_directory): Adjust to return a file_and_directory
2802         object.
2803         (read_file_scope): Adjust to use file_and_directory.  Remove
2804         make_cleanup/do_cleanups calls.
2805         (open_and_init_dwp_file): Adjust to use std::string.  Remove
2806         make_cleanup/do_cleanups calls.
2807         * python/python.c (do_start_initialization): Adjust to ldirname
2808         returning a std::string.
2809         * utils.c (ldirname): Now returns a std::string.
2810         * utils.h (ldirname): Change return type to std::string.
2811         * xml-syscall.c (xml_init_syscalls_info): Adjust to ldirname
2812         returning a std::string.
2813         * xml-tdesc.c (file_read_description_xml): Likewise.
2814
2815 2017-03-24  Alan Hayward  <alan.hayward@arm.com>
2816
2817         * regcache.c (regcache_debug_print_register): New function.
2818         * regcache.h (regcache_debug_print_register): New declaration.
2819         * target.c (debug_print_register): Remove.
2820         (target_fetch_registers): Call regcache_debug_print_register.
2821         (target_store_registers): Likewise.
2822
2823 2017-03-24  Pádraig Brady  <pbrady@fb.com>
2824
2825         * dwarf2read.c (setup_type_unit_groups): Ensure dir_index doesn't
2826         reference beyond the 'lh->include_dirs' array before accessing to
2827         it.
2828         (psymtab_include_file_name): Likewise.
2829         (dwarf_decode_lines_1): Likewise.
2830         (dwarf_decode_lines): Likewise.
2831         (file_file_name): Likewise.
2832
2833 2017-03-23  Simon Marchi  <simon.marchi@ericsson.com>
2834
2835         * fbsd-tdep.c (fbsd_corefile_thread): Don't set/restore
2836         inferior_ptid.
2837         * proc-service.c (ps_lgetregs, ps_lsetregs, ps_lgetfpregs,
2838         ps_lsetfpregs): Likewise.
2839         * regcache.c (regcache_raw_update, regcache_raw_write): Likewise.
2840         * sol-thread.c (ps_lgetregs, ps_lsetregs, ps_lgetfpregs,
2841         ps_lsetfpregs): Likewise.
2842         * target.c (target_fetch_registers, target_store_registers):
2843         Remove asserts.
2844
2845 2017-03-23  Alan Hayward  <alan.hayward@arm.com>
2846
2847         * sol-thread.c (sol_thread_store_registers): Remove regcache calls.
2848
2849 2017-03-23  Yao Qi  <yao.qi@linaro.org>
2850
2851         * aarch64-tdep.c (aarch64_process_record_test): Declare.
2852         (_initialize_aarch64_tdep): Register it.
2853         (aarch64_record_load_store): Handle PRFM instruction.
2854         (aarch64_process_record_test): New function.
2855
2856 2017-03-23  Yao Qi  <yao.qi@linaro.org>
2857
2858         * aarch64-tdep.c (aarch64_record_load_store): Fix code
2859         indentation.
2860
2861 2017-03-23  Yao Qi  <yao.qi@linaro.org>
2862
2863         * aarch64-tdep.c: Remove AARCH64_RECORD_FAILURE.
2864
2865 2017-03-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
2866
2867         python/python.c (do_start_initialization): Fix memory leak.
2868
2869 2017-03-22  Simon Marchi  <simon.marchi@polymtl.ca>
2870
2871         * inf-ptrace.c (inf_ptrace_xfer_partial): Get pid from ptid
2872         using get_ptrace_pid.
2873         * linux-nat.c (linux_nat_xfer_partial): Don't set/restore
2874         inferior_ptid.
2875         (linux_proc_xfer_partial, linux_proc_xfer_spu): Use lwp of
2876         inferior_ptid instead of pid.
2877
2878 2017-03-22  Yao Qi  <yao.qi@linaro.org>
2879
2880         * aarch64-tdep.c: Wrap locally used classes in anonymous
2881         namespace.
2882         * arm-tdep.c: Likewise.
2883         * linespec.c: Likewise.
2884         * ui-out.c: Likewise.
2885
2886 2017-03-22  Jonah Graham  <jonah@kichwacoders.com>
2887
2888         PR gdb/19637
2889         * python/lib/gdb/printer/bound_registers.py: Import sys.
2890
2891 2017-03-21  Simon Marchi  <simon.marchi@ericsson.com>
2892
2893         * windows-nat.c (do_windows_fetch_inferior_registers): Add
2894         windows_thread_info parameter and use it instead of
2895         current_thread.
2896         (windows_fetch_inferior_registers): Don't set current_thread,
2897         pass the thread to do_windows_fetch_inferior_registers.  Use
2898         ptid from regcache instead of inferior_ptid.
2899         (do_windows_store_inferior_registers): Add windows_thread_info
2900         parameter and use it instead of current_thread.
2901         (windows_store_inferior_registers): Don't set current_thread,
2902         pass the thread to do_windows_store_inferior_registers.  Use
2903         ptid from regcache instead of inferior_ptid.
2904
2905 2017-03-21  Simon Marchi  <simon.marchi@ericsson.com>
2906
2907         * ser-mingw.c (ser_windows_raw): Remove reference to
2908         struct serial::current_timeout.
2909
2910 2017-03-21  Ivo Raisr  <ivo.raisr@oracle.com>
2911
2912         PR tdep/20928
2913         * gdb/sparc-tdep.h (gdbarch_tdep) <sparc64_ccr_type>: New field.
2914         * gdb/sparc64-tdep.c (sparc64_ccr_type): New function.
2915         (sparc64_fsr_type): Fix %fsr decoding.
2916
2917 2017-03-21  Tim Wiederhake  <tim.wiederhake@intel.com>
2918
2919         * python/py-record-btrace.c (btpy_insn_data): Change return type
2920         for Python 2.
2921
2922 2017-03-20  Simon Marchi  <simon.marchi@polymtl.ca>
2923
2924         * spu-linux-nat.c (spu_fetch_inferior_registers,
2925         spu_store_inferior_registers): Use ptid from regcache, set and
2926         restore inferior_ptid.
2927         * spu-multiarch.c (spu_fetch_registers, spu_store_registers):
2928         Likewise.
2929
2930 2017-03-20  Simon Marchi  <simon.marchi@polymtl.ca>
2931
2932         * i386-linux-nat.c (fetch_register, store_register,
2933         i386_linux_fetch_inferior_registers,
2934         i386_linux_store_inferior_registers): Use ptid from regcache.
2935         * ia64-linux-nat.c (ia64_linux_fetch_register,
2936         ia64_linux_store_register): Likewise.
2937         * inf-ptrace.c (inf_ptrace_fetch_register,
2938         inf_ptrace_store_register): Likewise.
2939         * m32r-linux-nat.c (m32r_linux_fetch_inferior_registers,
2940         m32r_linux_store_inferior_registers): Likewise.
2941         * m68k-bsd-nat.c (m68kbsd_fetch_inferior_registers,
2942         m68kbsd_store_inferior_registers): Likewise.
2943         * m68k-linux-nat.c (fetch_register, store_register,
2944         m68k_linux_fetch_inferior_registers,
2945         m68k_linux_store_inferior_registers): Likewise.
2946         * m88k-bsd-nat.c (m88kbsd_fetch_inferior_registers,
2947         m88kbsd_store_inferior_registers): Likewise.
2948         * mips-fbsd-nat.c (mips_fbsd_fetch_inferior_registers,
2949         mips_fbsd_store_inferior_registers): Likewise.
2950         * mips-linux-nat.c (mips64_linux_regsets_fetch_registers,
2951         mips64_linux_regsets_store_registers): Likewise.
2952         * mips-nbsd-nat.c (mipsnbsd_fetch_inferior_registers,
2953         mipsnbsd_store_inferior_registers): Likewise.
2954         * mips-obsd-nat.c (mips64obsd_fetch_inferior_registers,
2955         mips64obsd_store_inferior_registers): Likewise.
2956         * nto-procfs.c (procfs_fetch_registers, procfs_store_registers):
2957         Likewise.
2958         * ppc-fbsd-nat.c (ppcfbsd_fetch_inferior_registers,
2959         ppcfbsd_store_inferior_registers): Likewise.
2960         * ppc-linux-nat.c (ppc_linux_fetch_inferior_registers,
2961         ppc_linux_store_inferior_registers): Likewise.
2962         * ppc-nbsd-nat.c (ppcnbsd_fetch_inferior_registers,
2963         ppcnbsd_store_inferior_registers): Likewise.
2964         * ppc-obsd-nat.c (ppcobsd_fetch_registers,
2965         ppcobsd_store_registers): Likewise.
2966         * procfs.c (procfs_fetch_registers, procfs_store_registers):
2967         Likewise.
2968         * ravenscar-thread.c (ravenscar_fetch_registers,
2969         ravenscar_store_registers, ravenscar_prepare_to_store):
2970         Likewise.
2971         * record-btrace.c (record_btrace_fetch_registers,
2972         record_btrace_store_registers, record_btrace_prepare_to_store):
2973         Likewise.
2974         * remote-sim.c (gdbsim_fetch_register, gdbsim_store_register):
2975         Lookup inferior using ptid from regcache, instead of
2976         current_inferior.
2977         * remote.c (remote_fetch_registers, remote_store_registers): Use
2978         ptid from regcache.
2979         * rs6000-nat.c (fetch_register, store_register): Likewise.
2980         * s390-linux-nat.c (s390_linux_fetch_inferior_registers,
2981         s390_linux_store_inferior_registers): Likewise.
2982         * sh-nbsd-nat.c (shnbsd_fetch_inferior_registers,
2983         shnbsd_store_inferior_registers): Likewise.
2984         * sol-thread.c (sol_thread_fetch_registers,
2985         sol_thread_store_registers): Likewise.
2986         * sparc-nat.c (sparc_fetch_inferior_registers,
2987         sparc_store_inferior_registers): Likewise.
2988         * tilegx-linux-nat.c (fetch_inferior_registers,
2989         store_inferior_registers): Likewise.
2990         * vax-bsd-nat.c (vaxbsd_fetch_inferior_registers,
2991         vaxbsd_store_inferior_registers): Likewise.
2992         * xtensa-linux-nat.c (fetch_gregs, store_gregs, fetch_xtregs,
2993         store_xtregs): Likewise.
2994
2995 2017-03-20  Artemiy Volkov  <artemiyv@acm.org>
2996
2997         PR gdb/14441
2998         * NEWS: Mention support for rvalue references in GDB and python.
2999         * doc/gdb.texinfo (C Plus Plus Expressions): Mention that GDB
3000         supports both lvalue and rvalue references.
3001
3002 2017-03-20  Artemiy Volkov  <artemiyv@acm.org>
3003
3004         PR gdb/14441
3005         * gdbtypes.c (rank_one_type): Implement overloading
3006         resolution rules regarding rvalue references.
3007
3008 2017-03-20  Artemiy Volkov  <artemiyv@acm.org>
3009
3010         PR gdb/14441
3011         * aarch64-tdep.c (aarch64_type_align)
3012         (aarch64_extract_return_value, aarch64_store_return_value): Change
3013         lvalue reference type checks to general reference type checks.
3014         * amd64-tdep.c (amd64_classify): Likewise.
3015         * amd64-windows-tdep.c (amd64_windows_passed_by_integer_register):
3016         Likewise.
3017         * arm-tdep.c (arm_type_align, arm_extract_return_value)
3018         (arm_store_return_value): Likewise.
3019         * ax-gdb.c (gen_fetch, gen_cast): Likewise.
3020         * c-typeprint.c (c_print_type): Likewise.
3021         * c-varobj.c (adjust_value_for_child_access, c_value_of_variable)
3022         (cplus_number_of_children, cplus_describe_child): Likewise.
3023         * compile/compile-c-symbols.c (generate_vla_size): Likewise.
3024         * completer.c (expression_completer): Likewise.
3025         * cp-support.c (make_symbol_overload_list_adl_namespace):
3026         Likewise.
3027         * darwin-nat-info.c (info_mach_region_command): Likewise.
3028         * dwarf2loc.c (entry_data_value_coerce_ref)
3029         (value_of_dwarf_reg_entry): Likewise.
3030         * eval.c (ptrmath_type_p, evaluate_subexp_standard)
3031         (evaluate_subexp_for_address, evaluate_subexp_for_sizeof):
3032         Likewise.
3033         * findvar.c (extract_typed_address, store_typed_address):
3034         Likewise.
3035         * gdbtypes.c (rank_one_type): Likewise.
3036         * hppa-tdep.c (hppa64_integral_or_pointer_p): Likewise.
3037         * infcall.c (value_arg_coerce): Likewise.
3038         * language.c (pointer_type): Likewise.
3039         * m32c-tdep.c (m32c_reg_arg_type, m32c_m16c_address_to_pointer):
3040         Likewise.
3041         * m88k-tdep.c (m88k_integral_or_pointer_p): Likewise.
3042         * mn10300-tdep.c (mn10300_type_align): Likewise.
3043         * msp430-tdep.c (msp430_push_dummy_call): Likewise.
3044         * ppc-sysv-tdep.c (do_ppc_sysv_return_value)
3045         (ppc64_sysv_abi_push_param, ppc64_sysv_abi_return_value):
3046         Likewise.
3047         * printcmd.c (print_formatted, x_command): Likewise.
3048         * python/py-type.c (typy_get_composite, typy_template_argument):
3049         Likewise.
3050         * python/py-value.c (valpy_referenced_value)
3051         (valpy_get_dynamic_type, value_has_field): Likewise.
3052         * s390-linux-tdep.c (s390_function_arg_integer): Likewise.
3053         * sparc-tdep.c (sparc_integral_or_pointer_p): Likewise.
3054         * sparc64-tdep.c (sparc64_integral_or_pointer_p): Likewise.
3055         * spu-tdep.c (spu_scalar_value_p): Likewise.
3056         * symtab.c (lookup_symbol_aux): Likewise.
3057         * typeprint.c (whatis_exp, print_type_scalar): Likewise.
3058         * valarith.c (binop_types_user_defined_p, unop_user_defined_p):
3059         Likewise.
3060         * valops.c (value_cast_pointers, value_cast)
3061         (value_reinterpret_cast, value_dynamic_cast, value_addr, typecmp)
3062         (value_struct_elt, value_struct_elt_bitpos)
3063         (value_find_oload_method_list, find_overload_match)
3064         (value_rtti_indirect_type): Likewise.
3065         * valprint.c (val_print_scalar_type_p, generic_val_print):
3066         Likewise.
3067         * value.c (value_actual_type, value_as_address, unpack_long)
3068         (pack_long, pack_unsigned_long, coerce_ref_if_computed)
3069         (coerce_ref): Likewise.
3070         * varobj.c (varobj_get_value_type): Likewise.
3071
3072 2017-03-20  Artemiy Volkov  <artemiyv@acm.org>
3073
3074         PR gdb/14441
3075         * doc/python.texi (Types in Python): Add TYPE_CODE_RVALUE_REF to
3076         table of constants.
3077         * python/lib/gdb/command/explore.py: Support exploring values
3078         of rvalue reference types.
3079         * python/lib/gdb/types.py: Implement get_basic_type() for
3080         rvalue reference types.
3081         * python/py-type.c (pyty_codes) <TYPE_CODE_RVALUE_REF>: New
3082         constant.
3083         * python/py-value.c (valpy_getitem): Add an rvalue reference
3084         check.
3085         (valpy_reference_value): Add new parameter "refcode".
3086         (valpy_lvalue_reference_value, valpy_rvalue_reference_value):
3087         New wrappers for valpy_reference_value().
3088         * python/py-xmethods.c (gdbpy_get_xmethod_result_type)
3089         (gdbpy_invoke_xmethod): Likewise.
3090
3091 2017-03-20  Artemiy Volkov  <artemiyv@acm.org>
3092
3093         PR gdb/14441
3094         * dwarf2read.c (process_die, read_type_die_1): Handle the
3095         DW_TAG_rvalue_reference_type DIE.
3096         (read_tag_reference_type): Add new parameter "refcode".
3097
3098 2017-03-20  Artemiy Volkov  <artemiyv@acm.org>
3099
3100         PR gdb/14441
3101         * c-typeprint.c (c_print_type, c_type_print_varspec_prefix)
3102         (c_type_print_modifier, c_type_print_varspec_suffix)
3103         (c_type_print_base): Support printing rvalue reference types.
3104         * c-valprint.c (c_val_print, c_value_print): Support printing
3105         rvalue reference values.
3106
3107 2017-03-20  Artemiy Volkov  <artemiyv@acm.org>
3108
3109         PR gdb/14441
3110         * cp-name-parser.y (ptr_operator): Handle the '&&' token in
3111         typename.
3112         * cp-support.c (replace_typedefs): Handle
3113         DEMANGLE_COMPONENT_RVALUE_REFERENCE.
3114         * python/py-type.c (typy_lookup_type): Likewise.
3115
3116 2017-03-20  Artemiy Volkov  <artemiyv@acm.org>
3117
3118         PR gdb/14441
3119         * c-exp.y (ptr_operator): Handle the '&&' token in the typename.
3120         * parse.c (insert_type): Change assert statement.
3121         (follow_types): Handle rvalue reference types.
3122         * parser-defs.h (enum type_pieces) <tp_rvalue_reference>: New
3123         constant.
3124
3125 2017-03-20  Artemiy Volkov  <artemiyv@acm.org>
3126
3127         PR gdb/14441
3128         * ada-lang.c (ada_evaluate_subexp): Adhere to the new
3129         value_ref() interface.
3130         * c-valprint.c (c_value_print): Likewise.
3131         * infcall.c (value_arg_coerce): Likewise.
3132         * python/py-value.c (valpy_reference_value): Likewise.
3133         * valops.c (value_cast, value_reinterpret_cast)
3134         (value_dynamic_cast, typecmp): Likewise.
3135         (value_ref): Parameterize by kind of return value reference type.
3136         * value.h (value_ref): Add new parameter "refcode".
3137
3138 2017-03-20  Artemiy Volkov  <artemiyv@acm.org>
3139
3140         PR gdb/14441
3141         * dwarf2read.c (read_tag_reference_type): Use
3142         lookup_lvalue_reference_type() instead of lookup_reference_type().
3143         * eval.c (evaluate_subexp_standard): Likewise.
3144         * f-exp.y: Likewise.
3145         * gdbtypes.c (make_reference_type, lookup_reference_type):
3146         Generalize with rvalue reference types.
3147         (lookup_lvalue_reference_type, lookup_rvalue_reference_type): New
3148         convenience wrappers for lookup_reference_type().
3149         * gdbtypes.h (make_reference_type, lookup_reference_type): Add a
3150         reference kind parameter.
3151         (lookup_lvalue_reference_type, lookup_rvalue_reference_type): Add
3152         wrappers for lookup_reference_type().
3153         * guile/scm-type.c (gdbscm_type_reference): Use
3154         lookup_lvalue_reference_type() instead of lookup_reference_type().
3155         * guile/scm-value.c (gdbscm_value_dynamic_type): Likewise.
3156         * parse.c (follow_types): Likewise.
3157         * python/py-type.c (typy_reference, typy_lookup_type): Likewise.
3158         * python/py-value.c (valpy_get_dynamic_type, valpy_getitem):
3159         Likewise.
3160         * python/py-xmethods.c (gdbpy_get_xmethod_result_type)
3161         (gdbpy_invoke_xmethod): Likewise.
3162         * stabsread.c: Provide extra argument to make_reference_type()
3163         call.
3164         * valops.c (value_ref, value_rtti_indirect_type): Use
3165         lookup_lvalue_reference_type() instead of lookup_reference_type().
3166
3167 2017-03-20  Artemiy Volkov  <artemiyv@acm.org>
3168
3169         PR gdb/14441
3170         * gdbtypes.h (enum type_code) <TYPE_CODE_RVALUE_REF>: New constant.
3171         (TYPE_IS_REFERENCE): New macro.
3172         (struct type): Add rvalue_reference_type field.
3173         (TYPE_RVALUE_REFERENCE_TYPE): New macro.
3174
3175 2017-03-20  Marc-Andre Laperle  <marc-andre.laperle@ericsson.com>
3176
3177         * NEWS: Add an entry about new '-file-list-shared-libraries' command.
3178         * mi/mi-cmd-file.c (mi_cmd_file_list_shared_libraries):
3179         New function definition.
3180         * mi/mi-cmds.c (mi_cmds): Add -file-list-shared-libraries command.
3181         * mi/mi-cmds.h (mi_cmd_file_list_shared_libraries):
3182         New function declaration.
3183         * mi/mi-interp.c (mi_output_solib_attribs): New Function.
3184         * mi/mi-interp.h: New file.
3185         * solib.c (info_sharedlibrary_command): Replace for loop with
3186         ALL_SO_LIBS macro
3187         * solib.h (update_solib_list): New function declaration.
3188         (so_list_head): Move macro.
3189         * solist.h (ALL_SO_LIBS): New macro.
3190
3191 2017-03-20  Marc-Andre Laperle  <marc-andre.laperle@ericsson.com>
3192
3193         * infcmd.c (post_create_inferior): Remove unused argument in
3194         call to solib_add.
3195         * remote.c (remote_start_remote): Likewise.
3196         * solib-frv.c (frv_fetch_objfile_link_map): Likewise.
3197         * solib-svr4.c: (svr4_fetch_objfile_link_map): Likewise.
3198         (enable_break): Likewise.
3199         * solib.c (update_solib_list): Remove unused target argument
3200         and its documentation.
3201         (solib_add): Remove unused target argument.  Remove unused
3202         argument in call to update_solib_list.
3203         (info_sharedlibrary_command): Remove unused argument in call
3204         to update_solib_list.
3205         (sharedlibrary_command): Remove unused argument in call to
3206         solib_add.
3207         (handle_solib_event): Likewise.
3208         (reload_shared_libraries): Likewise.
3209         * solib.h (solib_add): Remove unused target argument.
3210
3211 2017-03-20  Andreas Arnez  <arnez@linux.vnet.ibm.com>
3212
3213         * s390-linux-tdep.c (is_rsi, is_rie): Remove functions.
3214         (s390_displaced_step_fixup): Cover relative branches with the
3215         default fixup handling.  This fixes lack of support for some
3216         relative branch instructions.
3217
3218 2017-03-17  Simon Marchi  <simon.marchi@polymtl.ca>
3219
3220         * i386-gnu-nat.c (gnu_fetch_registers, gnu_store_registers): Use
3221         ptid from regcache.
3222
3223 2017-03-17  Simon Marchi  <simon.marchi@polymtl.ca>
3224
3225         * i386-darwin-nat.c (i386_darwin_fetch_inferior_registers,
3226         i386_darwin_store_inferior_registers): Use ptid from regcache.
3227
3228 2017-03-17  Simon Marchi  <simon.marchi@polymtl.ca>
3229
3230         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers,
3231         i386bsd_store_inferior_registers): Use ptid from regcache.
3232
3233 2017-03-17  Simon Marchi  <simon.marchi@polymtl.ca>
3234
3235         * hppa-obsd-nat.c (hppaobsd_fetch_registers,
3236         hppaobsd_store_registers): Use ptid from regcache.
3237
3238 2017-03-17  Simon Marchi  <simon.marchi@polymtl.ca>
3239
3240         * hppa-nbsd-nat.c (hppanbsd_fetch_registers,
3241         hppanbsd_store_registers): Use ptid from regcache.
3242
3243 2017-03-17  Simon Marchi  <simon.marchi@polymtl.ca>
3244
3245         * hppa-linux-nat.c (fetch_register, store_register): Use ptid
3246         from regcache.  Use get_ptrace_pid.
3247
3248 2017-03-17  Simon Marchi  <simon.marchi@polymtl.ca>
3249
3250         * corelow.c (get_core_register_section): Use ptid from regcache,
3251         update doc.
3252
3253 2017-03-17  Simon Marchi  <simon.marchi@polymtl.ca>
3254
3255         * bsd-uthread.c (bsd_uthread_fetch_registers,
3256         bsd_uthread_store_registers): Use ptid from regcache, set and
3257         restore inferior_ptid.
3258
3259 2017-03-17  Simon Marchi  <simon.marchi@polymtl.ca>
3260
3261         * arm-nbsd-nat.c (fetch_register, fetch_regs, fetch_fp_register,
3262         fetch_fp_regs, store_register, store_regs, store_fp_register,
3263         store_fp_regs): Use ptid from regcache.
3264
3265 2017-03-17  Simon Marchi  <simon.marchi@polymtl.ca>
3266
3267         * arm-linux-nat.c (fetch_fpregs, store_fpregs, fetch_regs,
3268         store_regs, fetch_wmmx_regs, store_wmmx_regs, fetch_vfp_regs,
3269         store_vfp_regs): Use ptid from regcache.
3270
3271 2017-03-17  Pedro Alves  <palves@redhat.com>
3272
3273         PR remote/21188
3274         * ser-base.c (ser_base_wait_for): Add comment.
3275         (do_ser_base_readchar): Improve comment based on the ser-unix.c's
3276         version.
3277         * ser-unix.c (hardwire_raw): Remove reference to
3278         scb->current_timeout.
3279         (wait_for, do_hardwire_readchar, hardwire_readchar): Delete.
3280         (hardwire_ops): Install ser_base_readchar instead of
3281         hardwire_readchar.
3282         * serial.h (struct serial) <current_timeout, timeout_remaining>:
3283         Remove fields.
3284
3285 2017-03-17  Jonah Graham  <jonah@kichwacoders.com>
3286
3287         PR gdb/19637
3288         * python/lib/gdb/printer/bound_registers.py: Add support for
3289         Python 3.
3290
3291 2017-03-16  Andreas Arnez  <arnez@linux.vnet.ibm.com>
3292
3293         * dwarf2loc.c (indirect_synthetic_pointer): Get data type of
3294         pointed-to DIE and pass it to dwarf2_evaluate_loc_desc_full.
3295         (dwarf2_evaluate_loc_desc_full): New parameter subobj_type; rename
3296         byte_offset to subobj_byte_offset.  Fix the handling of
3297         DWARF_VALUE_STACK on big-endian targets when coming via an
3298         implicit pointer.
3299         (dwarf2_evaluate_loc_desc): Adjust call to
3300         dwarf2_evaluate_loc_desc_full.
3301         * dwarf2loc.h (dwarf2_fetch_die_type_sect_off): New declaration.
3302         * dwarf2read.c (dwarf2_fetch_die_type_sect_off): New function.
3303
3304 2017-03-16  Yao Qi  <yao.qi@linaro.org>
3305
3306         * arm-tdep.c (thumb_record_misc): Decode CBNZ, CBZ, REV16,
3307         and REVSH instructions.
3308
3309 2017-03-16  Yao Qi  <yao.qi@linaro.org>
3310
3311         * arm-tdep.c [GDB_SELF_TEST]: include "selftests.h".
3312         (arm_record_test): Declare.
3313         (_initialize_arm_tdep) [GDB_SELF_TEST]: call register_self_test.
3314         (thumb_record_ld_st_reg_offset): Rewrite the opcode matching to
3315         align with the manual.
3316         (thumb_record_misc): Adjust the code order to align with the
3317         manual.
3318         (thumb2_record_decode_insn_handler): Fix instruction matching.
3319         (instruction_reader_thumb): New class.
3320         (arm_record_test): New function.
3321
3322 2017-03-16  Yao Qi  <yao.qi@linaro.org>
3323
3324         * arm-tdep.c (abstract_memory_reader): New class.
3325         (instruction_reader): New class.
3326         (extract_arm_insn): Add argument 'reader'.  Callers updated.
3327         (decode_insn): Likewise.
3328
3329 2017-03-16  Doug Evans  <dje@google.com>
3330
3331         * guile/scm-lazy-string.c (lazy_string_smob): Clarify use of LENGTH
3332         member.  Change type of TYPE member to SCM.  All uses updated.
3333         (lsscm_make_lazy_string_smob): Add assert.
3334         (lsscm_make_lazy_string): Flag bad length values.
3335         (lsscm_elt_type): New function.
3336         (gdbscm_lazy_string_to_value): Rewrite to use
3337         lsscm_safe_lazy_string_to_value.
3338         (lsscm_safe_lazy_string_to_value): Fix handling of TYPE_CODE_PTR.
3339         * guile/scm-value.c (gdbscm_value_to_lazy_string): Flag bad length
3340         values.  Fix TYPE_CODE_PTR.  Handle TYPE_CODE_ARRAY.  Handle typedefs
3341         in incoming type.
3342         * guile/guile-internal.h (tyscm_scm_to_type): Declare.
3343         * guile/scm-type.c (tyscm_scm_to_type): New function.
3344
3345 2017-03-15  Doug Evans  <dje@google.com>
3346
3347         PR python/17728, python/18439, python/18779
3348         * python/py-lazy-string.c (lazy_string_object): Clarify use of LENGTH
3349         member.  Change type of TYPE member to PyObject *.  All uses updated.
3350         (stpy_convert_to_value): Fix handling of TYPE_CODE_PTR.
3351         (gdbpy_create_lazy_string_object): Flag bad length values.
3352         Handle TYPE_CODE_ARRAY with possibly different user-provided length.
3353         Handle typedefs in incoming type.
3354         (stpy_lazy_string_elt_type): New function.
3355         (gdbpy_extract_lazy_string): Call it.
3356         * python/py-value.c (valpy_lazy_string): Flag bad length values.
3357         Fix handling of TYPE_CODE_PTR.  Handle TYPE_CODE_ARRAY.  Handle
3358         typedefs in incoming type.
3359
3360 2017-03-16  Doug Evans  <dje@google.com>
3361
3362         * guile/guile-internal.h (tyscm_scm_to_type): Declare.
3363         * guile/scm-type.c (tyscm_scm_to_type): New function.
3364
3365 2017-03-16  Jiong Wang  <jiong.wang@arm.com>
3366
3367         * inf-ptrace.c (inf_ptrace_peek_poke): Change the type to
3368         "ULONGEST" for "skip".
3369
3370 2017-03-14  Andreas Arnez  <arnez@linux.vnet.ibm.com>
3371
3372         PR gdb/21220
3373         * inf-ptrace.c (inf_ptrace_xfer_partial): In "case
3374         TARGET_OBJECT_MEMORY", extract the logic for ptrace peek/poke...
3375         (inf_ptrace_peek_poke): ...here.  New function.  Now also loop
3376         over ptrace peek/poke until end of buffer or error.
3377
3378 2017-03-14  Simon Marchi  <simon.marchi@ericsson.com>
3379
3380         * parse.c (length_of_subexp): Make static.
3381         * parser-defs.h (length_of_subexp): Remove.
3382
3383 2017-03-14  Andreas Arnez  <arnez@linux.vnet.ibm.com>
3384
3385         * linux-nat.c (linux_proc_xfer_partial): Handle write operations
3386         as well.
3387
3388 2017-03-14  Pedro Alves  <palves@redhat.com>
3389
3390         * cp-name-parser.y (cp_demangled_name_to_comp): Update comment.
3391         (main): Use std::unique_ptr.  Remove calls to
3392         cp_demangled_name_parse_free.
3393
3394 2017-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3395
3396         * alpha-bsd-nat.c (alphabsd_fetch_inferior_registers,
3397         alphabsd_store_inferior_registers): Use regcache->ptid instead
3398         of inferior_ptid.
3399
3400 2017-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3401
3402         * aix-thread.c (aix_thread_fetch_registers,
3403         aix_thread_store_registers): Use regcache->ptid instead of
3404         inferior_ptid.
3405
3406 2017-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3407
3408         * aarch64-linux-nat.c (fetch_gregs_from_thread,
3409         store_gregs_to_thread, fetch_fpregs_from_thread,
3410         store_fpregs_to_thread): Use regcache->ptid instead of
3411         inferior_ptid.
3412
3413 2017-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3414
3415         * amd64-linux-nat.c (amd64_linux_fetch_inferior_registers,
3416         amd64_linux_fetch_inferior_registers): Use regcache->ptid
3417         instead of inferior_ptid.
3418
3419 2017-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3420
3421         * target.c (target_fetch_registers, target_store_registers): Add
3422         assert.
3423
3424 2017-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3425
3426         * regcache.h (regcache_get_ptid): New function.
3427         * regcache.c (regcache_get_ptid): New function.
3428
3429 2017-03-13  Mark Wielaard  <mark@klomp.org>
3430
3431         * cp-name-parser.y (make_empty): Initialize d_printing to zero.
3432
3433 2017-03-10  Keith Seitz  <keiths@redhat.com>
3434
3435         PR c++/8218
3436         * c-typeprint.c (cp_type_print_method_args): Skip artificial arguments.
3437
3438 2017-03-08  Pedro Alves  <palves@redhat.com>
3439
3440         PR gdb/18360
3441         * infrun.c (start_step_over, do_target_resume, resume)
3442         (restart_threads): Assert we're not resuming a thread that is
3443         meant to be stopped.
3444         (infrun_thread_stop_requested_callback): Delete.
3445         (infrun_thread_stop_requested): If the thread is internally
3446         stopped, queue a pending stop event and clear the thread's
3447         inline-frame state.
3448         (handle_stop_requested): New function.
3449         (handle_syscall_event, handle_inferior_event_1): Use
3450         handle_stop_requested.
3451         (handle_stop_requested): New function.
3452         (handle_signal_stop): Set the thread's stop_signal here instead of
3453         at caller.
3454         (finish_step_over): Clear step over info unconditionally.
3455         (handle_signal_stop): If the user had interrupted the event
3456         thread, consider the stop a random signal.
3457         (handle_signal_stop) <signal arrived while stepping over
3458         breakpoint>: Don't restart threads here.
3459         (stop_waiting): Don't clear step-over info here.
3460
3461 2017-03-08  Pedro Alves  <palves@redhat.com>
3462
3463         PR 21206
3464         * common/gdb_unlinker.h (unlinker::unlinker): Attribute nonnull
3465         goes to argument 2, not 1.
3466
3467 2017-03-08  Pedro Alves  <palves@redhat.com>
3468
3469         PR cli/21218
3470         * top.c (gdb_readline_wrapper): Avoid passing NULL to
3471         display_gdb_prompt.
3472         (command_line_input): Add comment.
3473
3474 2017-03-08  Pedro Alves  <palves@redhat.com>
3475
3476         PR tui/21216
3477         * tui/tui-file.c (tui_file::write): New.
3478         * tui/tui-file.h (tui_file): Override "write".
3479         * tui/tui-io.c (do_tui_putc, update_start_line): New functions,
3480         factored out from ...
3481         (tui_puts): ... here.
3482         (tui_putc): Use them.
3483         (tui_write): New function.
3484         * tui/tui-io.h (tui_write): Declare.
3485
3486 2017-03-07  Sergio Durigan Junior  <sergiodj@redhat.com>
3487
3488         * Makefile.in (SFILES): Replace "environ.c" with
3489         "common/environ.c".
3490         (HFILES_NO_SRCDIR): Likewise, for "environ.h".
3491         * environ.c: Include "common-defs.h" instead of "defs.h.  Moved
3492         to...
3493         * common/environ.c: ... here.
3494         * environ.h: Moved to...
3495         * common/environ.h: ... here.
3496
3497 2017-03-07  Peter Bergner  <bergner@vnet.ibm.com>
3498
3499         * gdbarch.sh (pstring_ptr): New static function.
3500         (gdbarch_disassembler_options): Use it.
3501         (gdbarch_verify_disassembler_options): Print valid_disassembler_options,
3502         not valid_disassembler_option->name.
3503         * gdbarch.c: Regenerate.
3504
3505 2017-03-07  Peter Bergner  <bergner@vnet.ibm.com>
3506
3507         * config/powerpc/ppc64-linux.mh (MH_CFLAGS): Delete.
3508
3509 2017-03-07  Pedro Alves  <palves@redhat.com>
3510
3511         * tui/tui-regs.c (tui_restore_gdbout): Don't delete gdb_stdout.
3512
3513 2017-03-07  Walfred Tedeschi  <walfred.tedeschi@intel.com>
3514
3515         * i387-tdep.h (i387_reset_bnd_regs): Add function definition.
3516         * i387-tdep.c (i387_reset_bnd_regs): Add function implementation.
3517         * i386-tdep.c (i386_push_dummy_call): Call i387_reset_bnd_regs.
3518         * amd64-tdep.c (amd64_push_dummy_call): Call i387_reset_bnd_regs.
3519
3520 2017-03-06  Simon Marchi  <simon.marchi@ericsson.com>
3521
3522         * xtensa-linux-nat.c (fetch_gregs): Remove const.
3523
3524 2017-03-03  Simon Marchi  <simon.marchi@ericsson.com>
3525
3526         * remote.c (remote_add_target_side_commands): Use range-based
3527         for loop.
3528
3529 2017-03-03  Yao Qi  <yao.qi@linaro.org>
3530
3531         PR gdb/21165
3532         * ada-valprint.c (ada_val_print_ref): Call value_fetch_lazy if
3533         value is lazy.
3534         * valprint.c (common_val_print): Likewise.
3535
3536 2017-02-28  Peter Bergner  <bergner@vnet.ibm.com>
3537
3538         * NEWS: Mention new set/show disassembler-options commands.
3539         * doc/gdb.texinfo: Document new set/show disassembler-options commands.
3540         * disasm.c: Include "arch-utils.h", "gdbcmd.h" and "safe-ctype.h".
3541         (prospective_options): New static variable.
3542         (gdb_disassembler::gdb_disassembler): Initialize
3543         m_di.disassembler_options.
3544         (gdb_buffered_insn_length_init_dis): Initilize di->disassembler_options.
3545         (get_disassembler_options): New function.
3546         (set_disassembler_options): Likewise.
3547         (set_disassembler_options_sfunc): Likewise.
3548         (show_disassembler_options_sfunc): Likewise.
3549         (disassembler_options_completer): Likewise.
3550         (_initialize_disasm): Likewise.
3551         * disasm.h (get_disassembler_options): New prototype.
3552         (set_disassembler_options): Likewise.
3553         * gdbarch.sh (gdbarch_disassembler_options): New variable.
3554         (gdbarch_verify_disassembler_options): Likewise.
3555         * gdbarch.c: Regenerate.
3556         * gdbarch.h: Likewise.
3557         * arm-tdep.c (num_disassembly_options): Delete.
3558         (set_disassembly_style): Likewise.
3559         (arm_disassembler_options): New static variable.
3560         (set_disassembly_style_sfunc): Convert short style name into long
3561         option name.  Call set_disassembler_options.
3562         (show_disassembly_style_sfunc): New function.
3563         (arm_gdbarch_init): Call set_gdbarch_disassembler_options and
3564         set_gdbarch_verify_disassembler_options.
3565         (_initialize_arm_tdep): Delete regnames variable and update callers.
3566         (arm_disassembler_options): Initialize.
3567         (disasm_options): New variable.
3568         (num_disassembly_options): Rename from this...
3569         (num_disassembly_styles): ...to this.  Compute by scanning through
3570         disasm_options.
3571         (valid_disassembly_styles): Initialize using disasm_options.
3572         Remove calls to parse_arm_disassembler_option, get_arm_regnames and
3573         set_arm_regname_option.
3574         Pass show_disassembly_style_sfunc to the "disassembler" setshow command.
3575         * rs6000-tdep.c (powerpc_disassembler_options): New static variable.
3576         (rs6000_gdbarch_init): Call set_gdbarch_disassembler_options and
3577         set_gdbarch_verify_disassembler_options.
3578         * s390-tdep.c (s390_disassembler_options): New static variable.
3579         (s390_gdbarch_init):all set_gdbarch_disassembler_options and
3580         set_gdbarch_verify_disassembler_options.
3581
3582 2017-02-27  Simon Marchi  <simon.marchi@ericsson.com>
3583
3584         * remote.c (remote_add_target_side_condition): Remove "struct"
3585         keyword from range-based for loop.
3586
3587 2017-02-27  Simon Marchi  <simon.marchi@ericsson.com>
3588
3589         * remote.c (remote_add_target_side_condition): Use range-based
3590         for loop.  Update comment.
3591
3592 2017-02-27  Yao Qi  <yao.qi@linaro.org>
3593
3594         * f-typeprint.c (f_print_type): Check "varstring" is empty first.
3595
3596 2017-02-26  Alan Hayward  <alan.hayward@arm.com>
3597
3598         * regcache.c (regcache_raw_update): New function.
3599         (regcache_raw_read): Move code to regcache_raw_update.
3600         * regcache.h (regcache_raw_update): New declaration.
3601         * remote.c (remote_prepare_to_store): Call regcache_raw_update.
3602
3603 2017-02-26  Jan Kratochvil  <jan.kratochvil@redhat.com>
3604
3605         * dwarf2read.c (create_debug_type_hash_table): Initialize
3606         header.signature and header.type_offset_in_tu.
3607
3608 2017-02-24  Pedro Alves  <palves@redhat.com>
3609
3610         * symtab.c (make_file_symbol_completion_list_1): Use
3611         add_symtab_completions.
3612
3613 2017-02-24  Alan Hayward  <alan.hayward@arm.com>
3614
3615         * stack.c (frame_info): Use frame_unwind_register_value to avoid buf.
3616
3617 2017-02-24  Alan Hayward  <alan.hayward@arm.com>
3618
3619         * i386-tdep.c (i386_pseudo_register_read_into_value): Use
3620         I386_MAX_REGISTER_SIZE.
3621         (i386_pseudo_register_write): Likewise.
3622         (i386_process_record): Likewise.
3623         * i387-tdep.c (i387_supply_xsave): Likewise.
3624         * m68k-linux-nat.c (fetch_register): Use M68K_MAX_REGISTER_SIZE.
3625         (store_register): Likewise.
3626
3627 2017-02-23  Pedro Alves  <palves@redhat.com>
3628
3629         * ada-lang.c: Include "common/function-view.h".
3630         (ada_iterate_over_symbols): Adjust to use function_view as
3631         callback type.
3632         (struct add_partial_datum, ada_complete_symbol_matcher): Delete.
3633         (ada_make_symbol_completion_list): Use a lambda.
3634         (ada_exc_search_name_matches): Delete.
3635         (name_matches_regex): New.
3636         (ada_add_global_exceptions): Use a lambda and name_matches_regex.
3637         * compile/compile-c-support.c: Include "common/function-view.h".
3638         (print_one_macro): Change prototype to accept a ui_file pointer.
3639         (write_macro_definitions): Use a lambda.
3640         * dwarf2read.c: Include "common/function-view.h".
3641         (dw2_map_expand_apply, dw2_map_symtabs_matching_filename)
3642         (dw2_expand_symtabs_matching): Adjust to use function_view as
3643         callback type.
3644         * language.h: Include "common/function-view.h".
3645         (struct language_defn) <la_iterate_over_symbols>: Adjust to use
3646         function_view as callback type.
3647         (LA_ITERATE_OVER_SYMBOLS): Remove DATA parameter.
3648         * linespec.c: Include "common/function-view.h".
3649         (collect_info::add_symbol): New method.
3650         (struct symbol_and_data_callback, iterate_inline_only, struct
3651         symbol_matcher_data, iterate_name_matcher): Delete.
3652         (iterate_over_all_matching_symtabs): Adjust to use function_view
3653         as callback type and lambdas.
3654         (iterate_over_file_blocks): Adjust to use function_view as
3655         callback type.
3656         (decode_compound_collector): Now a class with private fields.
3657         (decode_compound_collector::release_symbols): New method.
3658         (collect_one_symbol): Rename to...
3659         (decode_compound_collector::operator()): ... this and adjust.
3660         (lookup_prefix_sym): decode_compound_collector construction bits
3661         move to decode_compound_collector ctor.  Pass the
3662         decode_compound_collector object directly as callback.  Remove
3663         cleanups and use decode_compound_collector::release_symbols
3664         instead.
3665         (symtab_collector): Now a class with private fields.
3666         (symtab_collector::release_symtabs): New method.
3667         (add_symtabs_to_list): Rename to...
3668         (symtab_collector::operator()): ... this and adjust.
3669         (collect_symtabs_from_filename): symtab_collector construction
3670         bits move to symtab_collector ctor.  Pass the symtab_collector
3671         object directly as callback.  Remove cleanups and use
3672         symtab_collector::release_symtabs instead.
3673         (collect_symbols): Delete.
3674         (add_matching_symbols_to_info): Use lambdas.
3675         * macrocmd.c (print_macro_callback): Delete.
3676         (info_macro_command): Use a lambda.
3677         (info_macros_command): Pass print_macro_definition as callable
3678         directly.
3679         (print_one_macro): Remove 'ignore' parameter.
3680         (macro_list_command): Adjust.
3681         * macrotab.c (macro_for_each_data::fn): Now a function_view.
3682         (macro_for_each_data::user_data): Delete field.
3683         (foreach_macro): Adjust to call the function_view.
3684         (macro_for_each): Adjust to use function_view as callback type.
3685         (foreach_macro_in_scope): Adjust to call the function_view.
3686         (macro_for_each_in_scope): Adjust to use function_view as callback
3687         type.
3688         * macrotab.h: Include "common/function-view.h".
3689         (macro_callback_fn): Declare a prototype instead of a pointer.
3690         Remove "user_data" parameter.
3691         (macro_for_each, macro_for_each_in_scope): Adjust to use
3692         function_view as callback type.
3693         * psymtab.c (partial_map_expand_apply)
3694         (psym_map_symtabs_matching_filename, recursively_search_psymtabs):
3695         Adjust to use function_view as callback type and to return bool.
3696         (psym_expand_symtabs_matching): Adjust to use function_view as
3697         callback types.
3698         * symfile-debug.c (debug_qf_map_symtabs_matching_filename): Adjust
3699         to use function_view as callback type and to return bool.
3700         (debug_qf_expand_symtabs_matching): Adjust to use function_view as
3701         callback types.
3702         * symfile.c (expand_symtabs_matching): Adjust to use function_view
3703         as callback types.
3704         * symfile.h: Include "common/function-view.h".
3705         (expand_symtabs_file_matcher_ftype)
3706         (expand_symtabs_symbol_matcher_ftype)
3707         (expand_symtabs_exp_notify_ftype): Remove "data" parameter and
3708         return bool.
3709         (quick_symbol_functions::map_symtabs_matching_filename)
3710         (quick_symbol_functions::expand_symtabs_matching): Adjust to use
3711         function_view as callback type and return bool.
3712         (expand_symtabs_matching): Adjust to use function_view as callback
3713         type.
3714         (maintenance_expand_name_matcher)
3715         (maintenance_expand_file_matcher): Delete.
3716         (maintenance_expand_symtabs): Use lambdas.
3717         * symtab.c (iterate_over_some_symtabs): Adjust to use
3718         function_view as callback types and return bool.
3719         (iterate_over_symtabs): Likewise.  Use unique_xmalloc_ptr instead
3720         of a cleanup.
3721         (lookup_symtab_callback): Delete.
3722         (lookup_symtab): Use a lambda.
3723         (iterate_over_symbols): Adjust to use function_view as callback
3724         type.
3725         (struct search_symbols_data, search_symbols_file_matches)
3726         (search_symbols_name_matches): Delete.
3727         (search_symbols): Use a pair of lambdas.
3728         (struct add_name_data, add_macro_name, symbol_completion_matcher)
3729         (symtab_expansion_callback): Delete.
3730         (default_make_symbol_completion_list_break_on_1): Use lambdas.
3731         * symtab.h: Include "common/function-view.h".
3732         (iterate_over_some_symtabs): Adjust to use function_view as
3733         callback type and return bool.
3734         (iterate_over_symtabs): Adjust to use function_view as callback
3735         type.
3736         (symbol_found_callback_ftype): Remove 'data' parameter and return
3737         bool.
3738         (iterate_over_symbols): Adjust to use function_view as callback
3739         type.
3740
3741 2017-02-23  Pedro Alves  <palves@redhat.com>
3742
3743         * Makefile.in (SUBDIR_UNITTESTS_SRCS, SUBDIR_UNITTESTS_OBS): New.
3744         (%.o) <unittests/%.c>: New pattern.
3745         * configure.ac ($development): Add $(SUBDIR_UNITTESTS_OBS) to
3746         CONFIG_OBS, and $(SUBDIR_UNITTESTS_SRCS) to CONFIG_SRCS.
3747         * common/function-view.h: New file.
3748         * unittests/function-view-selftests.c: New file.
3749         * configure: Regenerate.
3750
3751 2017-02-23  Simon Marchi  <simon.marchi@ericsson.com>
3752
3753         * bsd-uthread.c (bsd_uthread_thread_alive): Use ptid instead of
3754         inferior_ptid.
3755         * go32-nat.c (go32_thread_alive): Likewise.
3756
3757 2017-02-23  Yao Qi  <yao.qi@linaro.org>
3758
3759         * varobj-iter.h (varobj_iter_delete): Call xfree instead of
3760         delete.
3761
3762 2017-02-23  Yao Qi  <yao.qi@linaro.org>
3763
3764         * varobj.c (varobj_clear_saved_item): Use delete instead of
3765         xfree.
3766         (update_dynamic_varobj_children): Likewise.
3767
3768 2017-02-21  Jan Kratochvil  <jan.kratochvil@redhat.com>
3769
3770         * dwarf2read.c (dwarf2_record_block_ranges): Add forgotten BASEADDR.
3771
3772 2017-02-21  Simon Marchi  <simon.marchi@ericsson.com>
3773
3774         * common/enum-flags.h (enum_flags::enum_flags): Initialize
3775         m_enum_value to 0 in default constructor.
3776
3777 2017-02-21  Edjunior Barbosa Machado  <emachado@linux.vnet.ibm.com>
3778
3779         * rs6000-tdep.c (LOAD_AND_RESERVE_MASK): Rename from LWARX_MASK.
3780         (STORE_CONDITIONAL_MASK): Rename from STWCX_MASK.
3781         (LBARX_INSTRUCTION, LHARX_INSTRUCTION, LQARX_INSTRUCTION,
3782         STBCX_INSTRUCTION, STHCX_INSTRUCTION, STQCX_INSTRUCTION): New defines.
3783         (IS_LOAD_AND_RESERVE_INSN, IS_STORE_CONDITIONAL_INSN): New macros.
3784         (ppc_displaced_step_copy_insn): Use IS_LOAD_AND_RESERVE_INSN.
3785         (ppc_deal_with_atomic_sequence): Use IS_LOAD_AND_RESERVE_INSN and
3786         IS_STORE_CONDITIONAL_INSN.
3787
3788 2017-02-21  Jan Kratochvil  <jan.kratochvil@redhat.com>
3789
3790         * dwarf2_rnglists_process: Initialize range_beginning and range_end.
3791
3792 2017-02-20  Jan Kratochvil  <jan.kratochvil@redhat.com>
3793
3794         * NEWS (Changes since GDB 7.12): Add DWARF-5.
3795
3796 2017-02-20  Jan Kratochvil  <jan.kratochvil@redhat.com>
3797
3798         * dwarf2read.c (skip_one_die, read_attribute_value)
3799         (dwarf2_const_value_attr, dump_die_shallow)
3800         (dwarf2_get_attr_constant_value, dwarf2_fetch_constant_bytes)
3801         (skip_form_bytes, attr_form_is_constant): Handle DW_FORM_data16.
3802
3803 2017-02-20  Jan Kratochvil  <jan.kratochvil@redhat.com>
3804
3805         * dwarf2read.c (read_file_scope): Rename DW_MACRO_GNU_*.
3806         (dwarf_parse_macro_header): Accept DWARF version 5.
3807         (dwarf_decode_macro_bytes, dwarf_decode_macros): Rename DW_MACRO_GNU_*.
3808
3809 2017-02-20  Jan Kratochvil  <jan.kratochvil@redhat.com>
3810
3811         * block.c (call_site_for_pc): Rename DW_OP_GNU_*, DW_TAG_GNU_* and
3812         DW_AT_GNU_*.
3813         * common/common-exceptions.h (enum errors): Likewise.
3814         * dwarf2-frame.c (class dwarf_expr_executor): Likewise.
3815         * dwarf2expr.c (dwarf_block_to_dwarf_reg)
3816         (dwarf_expr_context::execute_stack_op): Likewise.
3817         * dwarf2expr.h (struct dwarf_expr_context, struct dwarf_expr_piece):
3818         Likewise.
3819         * dwarf2loc.c (dwarf_evaluate_loc_desc::get_base_type)
3820         (dwarf_evaluate_loc_desc::push_dwarf_reg_entry_value)
3821         (show_entry_values_debug, call_site_to_target_addr)
3822         (func_addr_to_tail_call_list, func_verify_no_selftailcall)
3823         (dwarf_expr_reg_to_entry_parameter, dwarf_entry_parameter_to_value)
3824         (entry_data_value_free_closure, value_of_dwarf_reg_entry)
3825         (value_of_dwarf_block_entry, indirect_pieced_value)
3826         (symbol_needs_eval_context::push_dwarf_reg_entry_value):
3827         (disassemble_dwarf_expression): Likewise.
3828         * dwarf2read.c (process_die, inherit_abstract_dies)
3829         (read_call_site_scope): Likewise.
3830         * gdbtypes.h (struct func_type, struct call_site_parameter)
3831         (struct call_site): Likewise.
3832         * stack.c (read_frame_arg): Likewise.
3833         * std-operator.def (OP_VAR_ENTRY_VALUE): Likewise.
3834
3835 2017-02-20  Jan Kratochvil  <jan.kratochvil@redhat.com>
3836
3837         * defs.h (read_unsigned_leb128): New declaration.
3838         * dwarf2loc.c (decode_debug_loclists_addresses): New function.
3839         (decode_debug_loc_dwo_addresses): Update DEBUG_LOC_* to DW_LLE_*.
3840         (dwarf2_find_location_expression): Call also
3841         decode_debug_loclists_addresses.  Handle DWARF-5 ULEB128 length.
3842         * dwarf2loc.h (dwarf2_version): New declaration.
3843         * dwarf2read.c (struct dwarf2_per_objfile): Add loclists, line_str,
3844         rnglists.
3845         (dwarf2_elf_names): Add .debug_loclists, .debug_line_str,
3846         .debug_rnglists.
3847         (struct dwop_section_names): Add loclists_dwo.
3848         (dwop_section_names): Add .debug_loclists.dwo.
3849         (struct comp_unit_head): Add unit_type, signature, type_offset_in_tu.
3850         (struct dwarf2_per_cu_data): Add dwarf_version.
3851         (struct dwo_sections): Add loclists.
3852         (struct attr_abbrev): Add implicit_const.
3853         (read_indirect_line_string): New declaration.
3854         (read_unsigned_leb128): Delete declaration.
3855         (rcuh_kind): New definition.
3856         (read_and_check_comp_unit_head): Change parameter
3857         is_debug_types_section to section_kind.
3858         (dwarf2_locate_sections): Handle loclists, line_str and rnglists.
3859         (read_comp_unit_head): Change parameter abfd to section, add parameter
3860         section_kind.  Handle DWARF-5.
3861         (error_check_comp_unit_head): Accept also DWARF version 5.
3862         (read_and_check_comp_unit_head): Change parameter
3863         is_debug_types_section to section_kind.
3864         (read_and_check_type_unit_head): Delete function.
3865         (read_abbrev_offset): Handle DWARF-5.
3866         (create_debug_type_hash_table): Add parameter section_kind.  Process
3867         only DW_UT_type.  Use signature and type_offset_in_tu from struct
3868         comp_unit_head.
3869         (create_debug_types_hash_table): Update create_debug_type_hash_table
3870         caller.
3871         (create_all_type_units): Call create_debug_type_hash_table.
3872         (read_cutu_die_from_dwo, init_cutu_and_read_dies): Change
3873         read_and_check_type_unit_head caller to read_and_check_comp_unit_head
3874         caller.
3875         (skip_one_die): Handle DW_FORM_implicit_const.
3876         (dwarf2_rnglists_process): New function.
3877         (dwarf2_ranges_process): Call dwarf2_rnglists_process for DWARF-5.
3878         (abbrev_table_read_table): Handle DW_FORM_implicit_const.
3879         (read_attribute_value): Handle DW_FORM_implicit_const,
3880         DW_FORM_line_strp.
3881         (read_attribute): Handle DW_FORM_implicit_const.
3882         (read_indirect_string_at_offset_from): New function from
3883         read_indirect_string_at_offset.
3884         (read_indirect_string_at_offset): Call
3885         read_indirect_string_at_offset_from.
3886         (read_indirect_line_string_at_offset): New function.
3887         (read_indirect_string): New function comment.
3888         (read_indirect_line_string): New function.
3889         (read_unsigned_leb128): Make it global.
3890         (dwarf2_string_attr): Handle DWARF-5.
3891         (add_include_dir_stub, read_formatted_entries): New functions.
3892         (dwarf_decode_line_header, dump_die_shallow, cu_debug_loc_section):
3893         Handle DWARF-5.
3894         (per_cu_header_read_in): Update read_comp_unit_head caller.
3895         (dwarf2_version): New function.
3896         * symfile.h (struct dwarf2_debug_sections): Add loclists, line_str and
3897         rnglists.
3898         * xcoffread.c (dwarf2_xcoff_names): Update struct dwarf2_debug_sections
3899         fields.
3900
3901 2017-02-20  Jan Kratochvil  <jan.kratochvil@redhat.com>
3902
3903         * dwarf2read.c (abbrev_table_read_table): Read the data only once.
3904
3905 2017-02-20  Jan Kratochvil  <jan.kratochvil@redhat.com>
3906
3907         * dwarf2read.c (dwarf2_ranges_process): New function from
3908         dwarf2_ranges_read.
3909         (dwarf2_ranges_read, dwarf2_record_block_ranges): Use
3910         dwarf2_ranges_process.
3911
3912 2017-02-20  Jan Kratochvil  <jan.kratochvil@redhat.com>
3913
3914         * dwarf2read.c (create_debug_type_hash_table): New function from
3915         create_debug_types_hash_table.
3916         (create_debug_types_hash_table): Call create_debug_type_hash_table.
3917         (create_all_type_units, open_and_init_dwo_file): Update
3918         create_debug_types_hash_table callers.
3919
3920 2017-02-20  Sergio Durigan Junior  <sergiodj@redhat.com>
3921
3922         PR gdb/16188
3923         * fork-child.c (trace_start_error): Fix thinko.  va_end should
3924         refer to 'ap', not 'args'.
3925
3926 2017-02-20  Sergio Durigan Junior  <sergiodj@redhat.com>
3927             Pedro Alves  <palves@redhat.com>
3928
3929         PR gdb/16188
3930         * darwin-nat.c (darwin_ptrace_me): Check if calls to system
3931         calls succeeded.
3932         * fork-child.c (trace_start_error): New function.
3933         (trace_start_error_with_name): Likewise.
3934         * gnu-nat.c (gnu_ptrace_me): Check if call to PTRACE succeeded.
3935         * inf-ptrace.c (inf_ptrace_me): Likewise.
3936         * inferior.h (trace_start_error): New prototype.
3937         (trace_start_error_with_name): Likewise.
3938
3939 2017-02-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3940
3941         PR gdb/21164
3942         * psymtab.c (maintenance_print_psymbols): Verify if 'argv' is not
3943         NULL before using it.
3944         * symmisc.c (maintenance_print_symbols): Likewise.
3945         (maintenance_print_msymbols): Likewise.
3946
3947 2017-02-14  Tim Wiederhake  <tim.wiederhake@intel.com>
3948
3949         * NEWS: Add record Python bindings entry.
3950
3951 2017-02-14  Tim Wiederhake  <tim.wiederhake@intel.com>
3952
3953         * Makefile.in (SUBDIR_PYTHON_OBS): Add py-record-btrace.o,
3954         py-record-full.o.
3955         (SUBDIR_PYTHON_SRCS): Add py-record-btrace.c, py-record-full.c.
3956         * python/py-record-btrace.c, python/py-record-btrace.h,
3957         python/py-record-full.c, python/py-record-full.h: New file.
3958         * python/py-record.c: Add include for py-record-btrace.h and
3959         py-record-full.h.
3960         (recpy_method, recpy_format, recpy_goto, recpy_replay_position,
3961         recpy_instruction_history, recpy_function_call_history, recpy_begin,
3962         recpy_end): Use functions from py-record-btrace.c and py-record-full.c.
3963         * python/python-internal.h (PyInt_FromSsize_t, PyInt_AsSsize_t):
3964         New definition.
3965         (gdbpy_initialize_btrace): New export.
3966         * python/python.c (_initialize_python): Add gdbpy_initialize_btrace.
3967
3968 2017-02-14  Tim Wiederhake  <tim.wiederhake@intel.com>
3969
3970         * Makefile.in (SUBDIR_PYTHON_OBS): Add python/py-record.o.
3971         (SUBDIR_PYTHON_SRCS): Add python/py-record.c.
3972         * python/py-record.c: New file.
3973         * python/python-internal.h (gdbpy_start_recording,
3974         gdbpy_current_recording, gdpy_stop_recording,
3975         gdbpy_initialize_record): New export.
3976         * python/python.c (_initialize_python): Add gdbpy_initialize_record.
3977         (python_GdbMethods): Add gdbpy_start_recording,
3978         gdbpy_current_recording and gdbpy_stop_recording.
3979
3980 2017-02-14  Tim Wiederhake  <tim.wiederhake@intel.com>
3981
3982         * record-btrace.c (record_btrace_record_method): New function.
3983         (init_record_btrace_ops): Initialize to_record_method.
3984         * record-full.c (record_full_record_method): New function.
3985         (init_record_full_ops, init_record_full_core_ops): Add
3986         record_full_record_method.
3987         * record.h (enum record_method): New enum.
3988         * target-debug.h (target_debug_print_enum_record_method: New define.
3989         * target-delegates.c: Regenerate.
3990         * target.c (target_record_method): New function.
3991         * target.h: Include record.h.
3992         (struct target_ops) <to_record_method>: New field.
3993         (target_record_method): New export.
3994
3995 2017-02-14  Tim Wiederhake  <tim.wiederhake@intel.com>
3996
3997         * record.h (record_start, record_stop): New export.
3998         * record.c (record_start, record_stop): New function.
3999
4000 2017-02-14  Tim Wiederhake  <tim.wiederhake@intel.com>
4001
4002         * btrace.c (btrace_fetch): Copy function call segments pointer
4003         into a vector.
4004         (btrace_clear): Clear the vector.
4005         (btrace_find_insn_by_number): Use binary search to find the correct
4006         function call segment.
4007         * btrace.h (brace_fun_p): New typedef.
4008         (struct btrace_thread_info) <functions>: New field.
4009
4010 2017-02-14  Tim Wiederhake  <tim.wiederhake@intel.com>
4011
4012         * record-btrace.c (btrace_ui_out_decode_error): Move most of it ...
4013         * btrace.c (btrace_decode_error): ... here.  New function.
4014         * btrace.h (btrace_decode_error): New export.
4015
4016 2017-02-14  Tim Wiederhake  <tim.wiederhake@intel.com>
4017
4018         * btrace.c (ftrace_call_num_insn, btrace_insn_get_error): New function.
4019         (ftrace_new_function, btrace_insn_number, btrace_insn_cmp,
4020         btrace_find_insn_by_number): Remove special case for gaps.
4021         * btrace.h (btrace_insn_get_error): New export.
4022         (btrace_insn_number, btrace_find_insn_by_number): Adjust comment.
4023         * record-btrace.c (btrace_insn_history): Print number for gaps.
4024         (record_btrace_info, record_btrace_goto): Handle gaps.
4025
4026 2017-02-14  Tom Tromey  <tom@tromey.com>
4027
4028         PR python/13598:
4029         * python/python.c (gdbpy_before_prompt_hook): Emit before_prompt
4030         event.
4031         * python/py-evts.c (gdbpy_initialize_py_events): Add
4032         before_prompt registry.
4033         * python/py-events.h (events_object) <before_prompt>: New field.
4034
4035 2017-02-14  Markus Metzger  <markus.t.metzger@intel.com>
4036
4037         * btrace.c (ftrace_new_switch): Preserve up link and flags.
4038
4039 2017-02-13  Luis Machado  <lgustavo@codesourcery.com>
4040
4041         * symfile (_initialize_symfile): Add usage text to the load command's
4042         help text.
4043
4044 2017-02-10  Simon Marchi  <simon.marchi@ericsson.com>
4045
4046         * utils.c (defaulted_query): Don't query on secondary UIs.
4047
4048 2017-02-10  Tom Tromey  <tom@tromey.com>
4049
4050         * rust-lang.c (rust_get_disr_info): Remove unused variable.
4051
4052 2017-02-10  Tom Tromey  <tom@tromey.com>
4053
4054         * python/py-value.c (valpy_richcompare_throw): Remove unnecessary
4055         "cleanup" local.
4056         * python/py-type.c (typy_legacy_template_argument): Remove
4057         unnecessary "cleanup" local.
4058
4059 2017-02-10  Tom Tromey  <tom@tromey.com>
4060
4061         * python/python.c (do_start_initialization): New function, from
4062         _initialize_python.
4063         (_initialize_python): Call do_start_initialization.
4064         * python/py-linetable.c (ltpy_iternext): Use explicit returns, not
4065         goto.
4066
4067 2017-02-10  Tom Tromey  <tom@tromey.com>
4068
4069         * python/py-prettyprint.c (pretty_print_one_value): Use
4070         gdbpy_ref.
4071
4072 2017-02-10  Tom Tromey  <tom@tromey.com>
4073
4074         * python/py-cmd.c (cmdpy_destroyer): Use gdbpy_ref.
4075         * python/py-breakpoint.c (gdbpy_breakpoint_deleted): Use
4076         gdbpy_ref.
4077         * python/py-type.c (field_new): Use gdbpy_ref.
4078         * python/py-symtab.c (symtab_and_line_to_sal_object): Use
4079         gdbpy_ref.
4080         * python/py-progspace.c (pspy_new): Use gdbpy_ref.
4081         (py_free_pspace): Likewise.
4082         (pspace_to_pspace_object): Likewise.
4083         * python/py-objfile.c (objfpy_new): Use gdbpy_ref.
4084         (py_free_objfile): Likewise.
4085         (objfile_to_objfile_object): Likewise.
4086         * python/py-inferior.c (delete_thread_object): Use
4087         gdbpy_ref.
4088         (infpy_read_memory): Likewise.
4089         (py_free_inferior): Likewise.
4090         * python/py-evtregistry.c (create_eventregistry_object): Use
4091         gdbpy_ref.
4092         * python/py-event.c (create_event_object): Use gdbpy_ref.
4093
4094 2017-02-10  Tom Tromey  <tom@tromey.com>
4095
4096         * python/py-ref.h (gdbpy_ref_policy): Now a template.
4097         (gdbpy_ref): Now a template; allow subclasses of PyObject to be
4098         used.
4099         * python/py-arch.c, python/py-bpevent.c, python/py-breakpoint.c,
4100         python/py-cmd.c, python/py-continueevent.c, python/py-event.c,
4101         python/py-exitedevent.c, python/py-finishbreakpoint.c,
4102         python/py-framefilter.c, python/py-function.c,
4103         python/py-inferior.c, python/py-infevents.c,
4104         python/py-linetable.c, python/py-newobjfileevent.c,
4105         python/py-param.c, python/py-prettyprint.c, python/py-ref.h,
4106         python/py-signalevent.c, python/py-stopevent.c,
4107         python/py-symbol.c, python/py-threadevent.c, python/py-type.c,
4108         python/py-unwind.c, python/py-utils.c, python/py-value.c,
4109         python/py-varobj.c, python/py-xmethods.c, python/python.c,
4110         varobj.c: Change gdbpy_ref to gdbpy_ref<>.
4111
4112 2017-02-10  Tom Tromey  <tom@tromey.com>
4113
4114         * ui-out.h (ui_out_emit_type): New class.
4115         (ui_out_emit_tuple, ui_out_emit_list): New typedefs.
4116         * python/py-framefilter.c (py_print_single_arg): Use gdb::optional
4117         and ui_out_emit_tuple.
4118         (enumerate_locals): Likewise.
4119         (py_mi_print_variables, py_print_locals, py_print_args): Use
4120         ui_out_emit_list.
4121         (py_print_frame): Use gdb::optional, ui_out_emit_tuple,
4122         ui_out_emit_list.
4123         * common/gdb_optional.h: New file.
4124
4125 2017-02-10  Martin Galvan  <martingalvan@sourceware.org>
4126
4127         * MAINTAINERS (Write After Approval): Update my e-mail address.
4128
4129 2017-02-10  Martin Galvan  <martingalvan@sourceware.org>
4130
4131         PR gdb/21122
4132         * breakpoint.c (_initialize_breakpoint): Update the help description
4133         of the 'commands' command to indicate that it takes a list argument.
4134
4135 2017-02-09  Simon Marchi  <simon.marchi@ericsson.com>
4136
4137         * interps.c (current_interp_set_logging): Remove "return".
4138
4139 2017-02-09  Gary Benson  <gbenson@redhat.com>
4140
4141         * symtab.c (add_symtab_completions): Prevent NULL pointer
4142         dereference.
4143
4144 2017-02-08  Pedro Alves  <palves@redhat.com>
4145
4146         * interps.c (interp::interp): Remove reference to quiet_p.
4147         (interp_set): Make static.  Remove dead "Switching to" output
4148         code.
4149         (interp_quiet_p, interp_set_quiet): Delete.
4150         (interpreter_exec_cmd): Don't set the interpreter quiet.
4151         * interps.h (interp_quiet_p): Make static.
4152         (class interp) <quiet_p>: Remove field
4153
4154 2017-02-08  Jerome Guitton  <guitton@adacore.com>
4155
4156         * cli/cli-decode.c (find_command_name_length): Make it extern.
4157         * cli/cli-decode.h (find_command_name_length): Declare.
4158         * cli/cli-script.c (command_name_equals, line_first_arg):
4159         New functions.
4160         (process_next_line): Use cli-decode to parse command names.
4161         (build_command_line): Make args a constant pointer.
4162
4163 2017-02-08  Jerome Guitton  <guitton@adacore.com>
4164
4165         * cli-decode.c (lookup_cmd_1, lookup_cmd_composition):
4166         Remove case-insensitive search.
4167
4168 2017-02-07  Jose E. Marchesi  <jose.marchesi@oracle.com>
4169
4170         * sparc-tdep.c (sparc32_gdbarch_init): Do not place a + operator
4171         at the end of the line.  Avoids an ARI warning.
4172
4173 2017-02-06  Luis Machado  <lgustavo@codesourcery.com>
4174
4175         * NEWS: Mention support for record/replay of Intel 64 rdrand and
4176         rdseed instructions.
4177         i386-tdep.c (i386_process_record): Handle Intel 64 rdrand and rseed.
4178
4179 2017-02-06  Ivo Raisr  <ivo.raisr@oracle.com>
4180
4181         PR tdep/20936
4182         Provide and use sparc32 and sparc64 target description XML files.
4183         * features/sparc/sparc32-cp0.xml, features/sparc/sparc32-cpu.xml,
4184         features/sparc/sparc32-fpu.xml: New files for sparc 32-bit.
4185         * features/sparc/sparc64-cp0.xml, features/sparc/sparc64-cpu.xml,
4186         features/sparc/sparc64-fpu.xml: New files for sparc 64-bit.
4187         * features/sparc/sparc32-solaris.xml: New file.
4188         * features/sparc/sparc64-solaris.xml: New file.
4189         * features/sparc/sparc32-solaris.c: Generated.
4190         * features/sparc/sparc64-solaris.c: Generated.
4191         * sparc-tdep.h: Account for differences in target descriptions.
4192         * sparc-tdep.c (sparc32_register_name): Use target provided registers.
4193         (sparc32_register_type): Use target provided registers.
4194         (validate_tdesc_registers): New function.
4195         (sparc32_gdbarch_init): Use tdesc_has_registers.
4196         Set pseudoregister functions.
4197         * sparc64-tdep.c (sparc64_register_name): Use target provided registers.
4198         (sparc64_register_type): Use target provided registers.
4199         (sparc64_init_abi): Set pseudoregister functions.
4200
4201 2017-02-03  Tom Tromey  <tom@tromey.com>
4202
4203         PR rust/21097:
4204         * rust-lang.c (rust_print_type) <TYPE_CODE_UNION>: Handle enums
4205         with a single member.
4206
4207 2017-02-03  Pedro Alves  <palves@redhat.com>
4208
4209         * cli/cli-interp.c (cli_interp_base::cli_interp_base)
4210         (cli_interp_base::~cli_interp_base): New.
4211         (cli_interp): New struct.
4212         (as_cli_interp): Cast the interp itself to cli_interp.
4213         (cli_interpreter_pre_command_loop): Rename to ...
4214         (cli_interp_base::pre_command_loop): ... this.  Remove 'self'
4215         parameter.
4216         (cli_interpreter_init): Rename to ...
4217         (cli_interp::init): ... this.  Remove 'self' parameter.  Use
4218         boolean.  Make extern.
4219         (cli_interpreter_resume): Rename to ...
4220         (cli_interp::resume): ... this.  Remove 'data' parameter.  Make
4221         extern.
4222         (cli_interpreter_suspend): Rename to ...
4223         (cli_interp::suspend): ... this.  Remove 'data' parameter.  Make
4224         extern.
4225         (cli_interpreter_exec): Rename to ...
4226         (cli_interp::exec): ... this.  Remove 'data' parameter.  Make
4227         extern.
4228         (cli_interpreter_supports_command_editing): Rename to ...
4229         (cli_interp_base::supports_command_editing): ... this.  Remove
4230         'interp' parameter.  Make extern.
4231         (cli_ui_out): Rename to ...
4232         (cli_interp::interp_ui_out): ... this.  Remove 'interp' parameter.
4233         Make extern.
4234         (cli_set_logging): Rename to ...
4235         (cli_interp_base::set_logging): ... this.  Remove 'interp'
4236         parameter.  Make extern.
4237         (cli_interp_procs): Delete.
4238         (cli_interp_factory): Adjust to use "new".
4239         * cli/cli-interp.h: Include "interps.h".
4240         (struct cli_interp_base): New struct.
4241         * interps.c (struct interp): Delete.  Fields moved to interps.h.
4242         (interp_new): Delete.
4243         (interp::interp, interp::~interp): New.
4244         (interp_set): Use bool, and return void.  Assume the interpreter
4245         has suspend, init and resume methods, and that the all return
4246         void.
4247         (set_top_level_interpreter): interp_set returns void.
4248         (interp_ui_out): Adapt.
4249         (current_interp_set_logging): Adapt.
4250         (interp_data): Delete.
4251         (interp_pre_command_loop, interp_supports_command_editing): Adapt.
4252         (interp_exec): Adapt.
4253         (top_level_interpreter_data): Delete.
4254         * interps.h (interp_init_ftype, interp_resume_ftype)
4255         (interp_suspend_ftype, interp_exec_ftype)
4256         (interp_pre_command_loop_ftype, interp_ui_out_ftype): Delete.
4257         (class interp): New.
4258         (interp_new): Delete.
4259         (interp_set): Now returns void.  Use bool.
4260         (interp_data, top_level_interpreter_data): Delete.
4261         * mi/mi-common.h: Include interps.h.
4262         (class mi_interp): Inherit from interp.  Define a ctor.  Declare
4263         init, resume, suspect, exec, interp_ui_out, set_logging and
4264         pre_command_loop methods.
4265         * mi/mi-interp.c (as_mi_interp): Cast the interp itself.
4266         (mi_interpreter_init): Rename to ...
4267         (mi_interp::init): ... this.  Remove the 'interp' parameter, use
4268         bool, return void and make extern.  Adjust.
4269         (mi_interpreter_resume): ... Rename to ...
4270         (mi_interp::resume): ... this.  Remove the 'data' parameter,
4271         return void and make extern.  Adjust.
4272         (mi_interpreter_suspend): ... Rename to ...
4273         (mi_interp::suspend): ... this.  Remove the 'data' parameter,
4274         return void and make extern.  Adjust.
4275         (mi_interpreter_exec): ... Rename to ...
4276         (mi_interp::exec): ... this.  Remove the 'data' parameter and make
4277         extern.  Adjust.
4278         (mi_interpreter_pre_command_loop): ... Rename to ...
4279         (mi_interp::pre_command_loop): ... this.  Remove the 'self'
4280         parameter and make extern.
4281         (mi_on_normal_stop_1): Adjust.
4282         (mi_ui_out): Rename to ...
4283         (mi_interp::interp_ui_out): ... this.  Remove the 'interp'
4284         parameter and make extern.  Adjust.
4285         (mi_set_logging): Rename to ...
4286         (mi_interp::set_logging): ... this.  Remove the 'interp'
4287         parameter and make extern.  Adjust.
4288         (mi_interp_procs): Delete.
4289         (mi_interp_factory): Adjust to use 'new'.
4290         * mi/mi-main.c (mi_cmd_gdb_exit, captured_mi_execute_command)
4291         (mi_print_exception, mi_execute_command, mi_load_progress):
4292         Adjust.
4293         * tui/tui-interp.c (tui_interp): New class.
4294         (as_tui_interp): Return a tui_interp pointer.
4295         (tui_on_normal_stop, tui_on_signal_received)
4296         (tui_on_end_stepping_range, tui_on_signal_exited, tui_on_exited)
4297         (tui_on_no_history, tui_on_user_selected_context_changed): Adjust
4298         to use interp::interp_ui_out.
4299         (tui_init): Rename to ...
4300         (tui_interp::init): ... this.  Remove the 'self' parameter, use
4301         bool, return void and make extern.  Adjust.
4302         (tui_resume): Rename to ...
4303         (tui_interp::resume): ... this.  Remove the 'data' parameter,
4304         return void and make extern.  Adjust.
4305         (tui_suspend): Rename to ...
4306         (tui_interp::suspend): ... this.  Remove the 'data' parameter,
4307         return void and make extern.  Adjust.
4308         (tui_ui_out): Rename to ...
4309         (tui_interp::interp_ui_out): ... this.  Remove the 'self'
4310         parameter, and make extern.  Adjust.
4311         (tui_exec): Rename to ...
4312         (tui_interp::exec): ... this.  Remove the 'data' parameter and
4313         make extern.
4314         (tui_interp_procs): Delete.
4315         (tui_interp_factory): Use "new".
4316
4317 2017-02-02  Tom Tromey  <tom@tromey.com>
4318
4319         * rust-exp.y (ends_raw_string, space_then_number)
4320         (rust_identifier_start_p): Return bool.
4321         * rust-lang.c (rust_tuple_type_p, rust_underscore_fields)
4322         (rust_tuple_struct_type_p, rust_tuple_variant_type_p)
4323         (rust_slice_type_p, rust_range_type_p, rust_u8_type_p)
4324         (rust_chartype_p): Return bool.
4325         (val_print_struct, rust_print_struct_def, rust_print_type):
4326         Update.
4327         * rust-lang.h (rust_tuple_type_p, rust_tuple_struct_type_p):
4328         Return bool.
4329
4330 2017-02-02  Tom Tromey  <tom@tromey.com>
4331
4332         * rust-lang.c: Reindent.
4333
4334 2017-02-02  Tom Tromey  <tom@tromey.com>
4335
4336         * rust-lang.h (rust_crate_for_block): Update.
4337         * rust-lang.c (rust_crate_for_block): Return std::string.
4338         (rust_get_disr_info): Use std:;string, not
4339         gdb::unique_xmalloc_ptr.
4340         * rust-exp.y (crate_name): Update.
4341
4342 2017-02-02  Pedro Alves  <palves@redhat.com>
4343
4344         * disasm-selftests.c (print_one_insn_test): Move the "verbose"
4345         field out of gdb_disassembler_test and make it static.
4346
4347 2017-02-02  Pedro Alves  <palves@redhat.com>
4348
4349         * mi/mi-common.h (struct mi_interp): Delete the mi2_interp,
4350         mi1_interp and mi_interp fields.
4351
4352 2017-02-02  Pedro Alves  <palves@redhat.com>
4353
4354         * cli/cli-interp.c (struct saved_output_files, saved_output):
4355         Moved from cli/cli-logging.c.
4356         (cli_set_logging): New function.
4357         (cli_interp_procs): Install cli_set_logging.
4358         * cli/cli-interp.h (make_logging_output, cli_set_logging):
4359         Declare.
4360         * cli/cli-logging.c (struct saved_output_files, saved_output):
4361         Moved to cli/cli-interp.c.
4362         (pop_output_files): Don't save outputs here.
4363         (make_logging_output): New function.
4364         (handle_redirections): Don't build tee nor save previous outputs
4365         here.
4366         * interps.c (current_interp_set_logging): Change prototype.
4367         Assume there's always a set_logging_proc method installed.
4368         * interps.h (interp_set_logging_ftype): Change prototype.
4369         (current_interp_set_logging): Change prototype and adjust comment.
4370         * mi/mi-interp.c (mi_set_logging): Change protototype.  Adjust to
4371         use make_logging_output.
4372         * tui/tui-interp.c (tui_interp_procs): Install cli_set_logging.
4373 2017-02-02  Pedro Alves  <palves@redhat.com>
4374
4375         * cli/cli-logging.c (maybe_warn_already_logging): New factored out
4376         from ...
4377         (set_logging_overwrite): ... here.
4378         (logging_no_redirect_file): Delete.
4379         (set_logging_redirect): Don't handle redirection on the fly.
4380         Instead warn that "logging off" / "logging on" is necessary.
4381         (pop_output_files): Delete references to logging_no_redirect_file.
4382         (show_logging_command): Always speak in terms of what will happen
4383         once logging is reenabled.
4384
4385 2017-02-02  Pedro Alves  <palves@redhat.com>
4386
4387         * disasm.h (gdb_pretty_print_disassembler): Tweak intro comment.
4388
4389 2017-02-02  Pedro Alves  <palves@redhat.com>
4390
4391         * disasm.c (gdb_pretty_print_insn): Rename to ...
4392         (gdb_pretty_print_disassembler::pretty_print_insn): ... this.
4393         Remove gdbarch parameter.  Adapt to clear the object's buffers
4394         instead of allocating new buffers, and to print using the object's
4395         gdb_disassembler instead of calling gdb_print_insn.
4396         (dump_insns): Use gdb_pretty_print_disassembler.
4397         * disasm.h (gdb_pretty_print_insn): Delete declaration.
4398         (gdb_pretty_print_disassembler): New class.
4399         * record-btrace.c (btrace_insn_history): Use
4400         gdb_pretty_print_disassembler.
4401
4402 2017-02-02  Pedro Alves  <palves@redhat.com>
4403
4404         * ada-lang.c (type_as_string): Use string_file.
4405         * ada-valprint.c (ada_print_floating): Use string_file.
4406         * ada-varobj.c (ada_varobj_scalar_image)
4407         (ada_varobj_get_value_image): Use string_file.
4408         * aix-thread.c (aix_thread_extra_thread_info): Use string_file.
4409         * arm-tdep.c (_initialize_arm_tdep): Use string_printf.
4410         * breakpoint.c (update_inserted_breakpoint_locations)
4411         (insert_breakpoint_locations, reattach_breakpoints)
4412         (print_breakpoint_location, print_one_detail_ranged_breakpoint)
4413         (print_it_watchpoint): Use string_file.
4414         (save_breakpoints): Use stdio_file.
4415         * c-exp.y (oper): Use string_file.
4416         * cli/cli-logging.c (set_logging_redirect): Use ui_file_up and
4417         tee_file.
4418         (pop_output_files): Use delete.
4419         (handle_redirections): Use stdio_file and tee_file.
4420         * cli/cli-setshow.c (do_show_command): Use string_file.
4421         * compile/compile-c-support.c (c_compute_program): Use
4422         string_file.
4423         * compile/compile-c-symbols.c (generate_vla_size): Take a
4424         'string_file &' instead of a 'ui_file *'.
4425         (generate_c_for_for_one_variable): Take a 'string_file &' instead
4426         of a 'ui_file *'.  Use string_file.
4427         (generate_c_for_variable_locations): Take a 'string_file &'
4428         instead of a 'ui_file *'.
4429         * compile/compile-internal.h (generate_c_for_for_one_variable):
4430         Take a 'string_file &' instead of a 'ui_file *'.
4431         * compile/compile-loc2c.c (push, pushf, unary, binary)
4432         (print_label, pushf_register_address, pushf_register)
4433         (do_compile_dwarf_expr_to_c): Take a 'string_file &' instead of a
4434         'ui_file *'.  Adjust.
4435         * compile/compile.c (compile_to_object): Use string_file.
4436         * compile/compile.h (compile_dwarf_expr_to_c)
4437         (compile_dwarf_bounds_to_c): Take a 'string_file &' instead of a
4438         'ui_file *'.
4439         * cp-support.c (inspect_type): Use string_file and obstack_copy0.
4440         (replace_typedefs_qualified_name): Use string_file and
4441         obstack_copy0.
4442         * disasm.c (gdb_pretty_print_insn): Use string_file.
4443         (gdb_disassembly): Adjust reference the null_stream global.
4444         (do_ui_file_delete): Delete.
4445         (gdb_insn_length): Use null_stream.
4446         * dummy-frame.c (maintenance_print_dummy_frames): Use stdio_file.
4447         * dwarf2loc.c (dwarf2_compile_property_to_c)
4448         (locexpr_generate_c_location, loclist_generate_c_location): Take a
4449         'string_file &' instead of a 'ui_file *'.
4450         * dwarf2loc.h (dwarf2_compile_property_to_c): Likewise.
4451         * dwarf2read.c (do_ui_file_peek_last): Delete.
4452         (dwarf2_compute_name): Use string_file.
4453         * event-top.c (gdb_setup_readline): Use stdio_file.
4454         * gdbarch.sh (verify_gdbarch): Use string_file.
4455         * gdbtypes.c (safe_parse_type): Use null_stream.
4456         * guile/scm-breakpoint.c (gdbscm_breakpoint_commands): Use
4457         string_file.
4458         * guile/scm-disasm.c (gdbscm_print_insn_from_port): Take a
4459         'string_file *' instead of a 'ui_file *'.
4460         (gdbscm_arch_disassemble): Use string_file.
4461         * guile/scm-frame.c (frscm_print_frame_smob): Use string_file.
4462         * guile/scm-ports.c (class ioscm_file_port): Now a class that
4463         inherits from ui_file.
4464         (ioscm_file_port_delete, ioscm_file_port_rewind)
4465         (ioscm_file_port_put): Delete.
4466         (ioscm_file_port_write): Rename to ...
4467         (ioscm_file_port::write): ... this.  Remove file_port_magic
4468         checks.
4469         (ioscm_file_port_new): Delete.
4470         (ioscm_with_output_to_port_worker): Use ioscm_file_port and
4471         ui_file_up.
4472         * guile/scm-type.c (tyscm_type_name): Use string_file.
4473         * guile/scm-value.c (vlscm_print_value_smob, gdbscm_value_print):
4474         Use string_file.
4475         * infcmd.c (print_return_value_1): Use string_file.
4476         * infrun.c (print_target_wait_results): Use string_file.
4477         * language.c (add_language): Use string_file.
4478         * location.c (explicit_to_string_internal): Use string_file.
4479         * main.c (captured_main_1): Use null_file.
4480         * maint.c (maintenance_print_architecture): Use stdio_file.
4481         * mi/mi-cmd-stack.c (list_arg_or_local): Use string_file.
4482         * mi/mi-common.h (struct mi_interp) <out, err, log, targ,
4483         event_channel>: Change type to mi_console_file pointer.
4484         * mi/mi-console.c (mi_console_file_fputs, mi_console_file_flush)
4485         (mi_console_file_delete): Delete.
4486         (struct mi_console_file): Delete.
4487         (mi_console_file_magic): Delete.
4488         (mi_console_file_new): Delete.
4489         (mi_console_file::mi_console_file): New.
4490         (mi_console_file_delete): Delete.
4491         (mi_console_file_fputs): Delete.
4492         (mi_console_file::write): New.
4493         (mi_console_raw_packet): Delete.
4494         (mi_console_file::flush): New.
4495         (mi_console_file_flush): Delete.
4496         (mi_console_set_raw): Rename to ...
4497         (mi_console_file::set_raw): ... this.
4498         * mi/mi-console.h (class mi_console_file): New class.
4499         (mi_console_file_new, mi_console_set_raw): Delete.
4500         * mi/mi-interp.c (mi_interpreter_init): Use mi_console_file.
4501         (mi_set_logging): Use delete and tee_file.  Adjust.
4502         * mi/mi-main.c (output_register): Use string_file.
4503         (mi_cmd_data_evaluate_expression): Use string_file.
4504         (mi_cmd_data_read_memory): Use string_file.
4505         (mi_cmd_execute, print_variable_or_computed): Use string_file.
4506         * mi/mi-out.c (mi_ui_out::main_stream): New.
4507         (mi_ui_out::rewind): Use main_stream and
4508         string_file.
4509         (mi_ui_out::put): Use main_stream and string_file.
4510         (mi_ui_out::mi_ui_out): Remove 'stream' parameter.
4511         Allocate a 'string_file' instead.
4512         (mi_out_new): Don't allocate a mem_fileopen stream here.
4513         * mi/mi-out.h (mi_ui_out::mi_ui_out): Remove 'stream' parameter.
4514         (mi_ui_out::main_stream): Declare method.
4515         * printcmd.c (eval_command): Use string_file.
4516         * psymtab.c (maintenance_print_psymbols): Use stdio_file.
4517         * python/py-arch.c (archpy_disassemble): Use string_file.
4518         * python/py-breakpoint.c (bppy_get_commands): Use string_file.
4519         * python/py-frame.c (frapy_str): Use string_file.
4520         * python/py-framefilter.c (py_print_type, py_print_single_arg):
4521         Use string_file.
4522         * python/py-type.c (typy_str): Use string_file.
4523         * python/py-unwind.c (unwind_infopy_str): Use string_file.
4524         * python/py-value.c (valpy_str): Use string_file.
4525         * record-btrace.c (btrace_insn_history): Use string_file.
4526         * regcache.c (regcache_print): Use stdio_file.
4527         * reggroups.c (maintenance_print_reggroups): Use stdio_file.
4528         * remote.c (escape_buffer): Use string_file.
4529         * rust-lang.c (rust_get_disr_info): Use string_file.
4530         * serial.c (serial_open_ops_1): Use stdio_file.
4531         (do_serial_close): Use delete.
4532         * stack.c (print_frame_arg): Use string_file.
4533         (print_frame_args): Remove local mem_fileopen stream, not used.
4534         (print_frame): Use string_file.
4535         * symmisc.c (maintenance_print_symbols): Use stdio_file.
4536         * symtab.h (struct symbol_computed_ops) <generate_c_location>:
4537         Take a 'string_file *' instead of a 'ui_file *'.
4538         * top.c (new_ui): Use stdio_file and stderr_file.
4539         (free_ui): Use delete.
4540         (execute_command_to_string): Use string_file.
4541         (quit_confirm): Use string_file.
4542         * tracepoint.c (collection_list::append_exp): Use string_file.
4543         * tui/tui-disasm.c (tui_disassemble): Use string_file.
4544         * tui/tui-file.c: Don't include "ui-file.h".
4545         (enum streamtype, struct tui_stream): Delete.
4546         (tui_file_new, tui_file_delete, tui_fileopen, tui_sfileopen)
4547         (tui_file_isatty, tui_file_rewind, tui_file_put): Delete.
4548         (tui_file::tui_file): New method.
4549         (tui_file_fputs): Delete.
4550         (tui_file_get_strbuf): Delete.
4551         (tui_file::puts): New method.
4552         (tui_file_adjust_strbuf): Delete.
4553         (tui_file_flush): Delete.
4554         (tui_file::flush): New method.
4555         * tui/tui-file.h: Tweak intro comment.
4556         Include ui-file.h.
4557         (tui_fileopen, tui_sfileopen, tui_file_get_strbuf)
4558         (tui_file_adjust_strbuf): Delete declarations.
4559         (class tui_file): New class.
4560         * tui/tui-io.c (tui_initialize_io): Use tui_file.
4561         * tui/tui-regs.c (tui_restore_gdbout): Use delete.
4562         (tui_register_format): Use string_stream.
4563         * tui/tui-stack.c (tui_make_status_line): Use string_file.
4564         (tui_get_function_from_frame): Use string_file.
4565         * typeprint.c (type_to_string): Use string_file.
4566         * ui-file.c (struct ui_file, ui_file_magic, ui_file_new): Delete.
4567         (null_stream): New global.
4568         (ui_file_delete): Delete.
4569         (ui_file::ui_file): New.
4570         (null_file_isatty): Delete.
4571         (ui_file::~ui_file): New.
4572         (null_file_rewind): Delete.
4573         (ui_file::printf): New.
4574         (null_file_put): Delete.
4575         (null_file_flush): Delete.
4576         (ui_file::putstr): New.
4577         (null_file_write): Delete.
4578         (ui_file::putstrn): New.
4579         (null_file_read): Delete.
4580         (ui_file::putc): New.
4581         (null_file_fputs): Delete.
4582         (null_file_write_async_safe): Delete.
4583         (ui_file::vprintf): New.
4584         (null_file_delete): Delete.
4585         (null_file::write): New.
4586         (null_file_fseek): Delete.
4587         (null_file::puts): New.
4588         (ui_file_data): Delete.
4589         (null_file::write_async_safe): New.
4590         (gdb_flush, ui_file_isatty): Adjust.
4591         (ui_file_put, ui_file_rewind): Delete.
4592         (ui_file_write): Adjust.
4593         (ui_file_write_for_put): Delete.
4594         (ui_file_write_async_safe, ui_file_read): Adjust.
4595         (ui_file_fseek): Delete.
4596         (fputs_unfiltered): Adjust.
4597         (set_ui_file_flush, set_ui_file_isatty, set_ui_file_rewind)
4598         (set_ui_file_put, set_ui_file_write, set_ui_file_write_async_safe)
4599         (set_ui_file_read, set_ui_file_fputs, set_ui_file_fseek)
4600         (set_ui_file_data): Delete.
4601         (string_file::~string_file, string_file::write)
4602         (struct accumulated_ui_file, do_ui_file_xstrdup, ui_file_xstrdup)
4603         (do_ui_file_as_string, ui_file_as_string): Delete.
4604         (do_ui_file_obsavestring, ui_file_obsavestring): Delete.
4605         (struct mem_file): Delete.
4606         (mem_file_new): Delete.
4607         (stdio_file::stdio_file): New.
4608         (mem_file_delete): Delete.
4609         (stdio_file::stdio_file): New.
4610         (mem_fileopen): Delete.
4611         (stdio_file::~stdio_file): New.
4612         (mem_file_rewind): Delete.
4613         (stdio_file::set_stream): New.
4614         (mem_file_put): Delete.
4615         (stdio_file::open): New.
4616         (mem_file_write): Delete.
4617         (stdio_file_magic, struct stdio_file): Delete.
4618         (stdio_file_new, stdio_file_delete, stdio_file_flush): Delete.
4619         (stdio_file::flush): New.
4620         (stdio_file_read): Rename to ...
4621         (stdio_file::read): ... this.  Adjust.
4622         (stdio_file_write): Rename to ...
4623         (stdio_file::write): ... this.  Adjust.
4624         (stdio_file_write_async_safe): Rename to ...
4625         (stdio_file::write_async_safe) ... this.  Adjust.
4626         (stdio_file_fputs): Rename to ...
4627         (stdio_file::puts) ... this.  Adjust.
4628         (stdio_file_isatty): Delete.
4629         (stdio_file_fseek): Delete.
4630         (stdio_file::isatty): New.
4631         (stderr_file_write): Rename to ...
4632         (stderr_file::write) ... this.  Adjust.
4633         (stderr_file_fputs): Rename to ...
4634         (stderr_file::puts) ... this.  Adjust.
4635         (stderr_fileopen, stdio_fileopen, gdb_fopen): Delete.
4636         (stderr_file::stderr_file): New.
4637         (tee_file_magic): Delete.
4638         (struct tee_file): Delete.
4639         (tee_file::tee_file): New.
4640         (tee_file_new): Delete.
4641         (tee_file::~tee_file): New.
4642         (tee_file_delete): Delete.
4643         (tee_file_flush): Rename to ...
4644         (tee_file::flush): ... this.  Adjust.
4645         (tee_file_write): Rename to ...
4646         (tee_file::write): ... this.  Adjust.
4647         (tee_file::write_async_safe): New.
4648         (tee_file_fputs): Rename to ...
4649         (tee_file::puts): ... this.  Adjust.
4650         (tee_file_isatty): Rename to ...
4651         (tee_file::isatty): ... this.  Adjust.
4652         * ui-file.h (struct obstack, struct ui_file): Don't
4653         forward-declare.
4654         (ui_file_new, ui_file_flush_ftype, set_ui_file_flush)
4655         (ui_file_write_ftype)
4656         (set_ui_file_write, ui_file_fputs_ftype, set_ui_file_fputs)
4657         (ui_file_write_async_safe_ftype, set_ui_file_write_async_safe)
4658         (ui_file_read_ftype, set_ui_file_read, ui_file_isatty_ftype)
4659         (set_ui_file_isatty, ui_file_rewind_ftype, set_ui_file_rewind)
4660         (ui_file_put_method_ftype, ui_file_put_ftype, set_ui_file_put)
4661         (ui_file_delete_ftype, set_ui_file_data, ui_file_fseek_ftype)
4662         (set_ui_file_fseek): Delete.
4663         (ui_file_data, ui_file_delete, ui_file_rewind)
4664         (struct ui_file): New.
4665         (ui_file_up): New.
4666         (class null_file): New.
4667         (null_stream): Declare.
4668         (ui_file_write_for_put, ui_file_put): Delete.
4669         (ui_file_xstrdup, ui_file_as_string, ui_file_obsavestring):
4670         Delete.
4671         (ui_file_fseek, mem_fileopen, stdio_fileopen, stderr_fileopen)
4672         (gdb_fopen, tee_file_new): Delete.
4673         (struct string_file): New.
4674         (struct stdio_file): New.
4675         (stdio_file_up): New.
4676         (struct stderr_file): New.
4677         (class tee_file): New.
4678         * ui-out.c (ui_out::field_stream): Take a 'string_file &' instead
4679         of a 'ui_file *'.  Adjust.
4680         * ui-out.h (class ui_out) <field_stream>: Likewise.
4681         * utils.c (do_ui_file_delete, make_cleanup_ui_file_delete)
4682         (null_stream): Delete.
4683         (error_stream): Take a 'string_file &' instead of a 'ui_file *'.
4684         Adjust.
4685         * utils.h (struct ui_file): Delete forward declaration..
4686         (make_cleanup_ui_file_delete, null_stream): Delete declarations.
4687         (error_stream): Take a 'string_file &' instead of a
4688         'ui_file *'.
4689         * varobj.c (varobj_value_get_print_value): Use string_file.
4690         * xtensa-tdep.c (xtensa_verify_config): Use string_file.
4691         * gdbarch.c: Regenerate.
4692
4693 2017-02-02  Pedro Alves  <palves@redhat.com>
4694
4695         * disasm.c (gdb_disassembler::pretty_print_insn): Rename to...
4696         (gdb_pretty_print_insn): ... this.  Now a free function.  Add back
4697         a 'gdbarch' parameter.  Allocate a mem_fileopen stream here.
4698         Adjust to call gdb_print_insn instead of
4699         gdb_disassembler::print_insn.
4700         (dump_insns, do_mixed_source_and_assembly_deprecated)
4701         (do_mixed_source_and_assembly, do_assembly_only): Add back a
4702         'gdbarch' parameter.  Remove gdb_disassembler parameter.
4703         (gdb_disassembly): Don't allocate a gdb_disassembler here.
4704         * disasm.h (gdb_disassembler::pretty_print_insn): Delete
4705         declaration.
4706         (gdb_pretty_print_insn): Re-add declaration.
4707         * record-btrace.c (btrace_insn_history): Don't allocate a
4708         gdb_disassembler here.  Adjust to call gdb_pretty_print_insn.
4709
4710 2017-02-01  Simon Marchi  <simon.marchi@polymtl.ca>
4711
4712         * disasm.h (gdb_disassembly): Remove file_string parameter.
4713         * disasm.c (gdb_disassembly): Likewise.
4714         * cli/cli-cmds.c (print_disassembly): Adapt.
4715         * mi/mi-cmd-disas.c (mi_cmd_disassemble): Likewise.
4716         * stack.c (do_gdb_disassembly): Likewise.
4717
4718 2017-02-01  Andreas Arnez  <arnez@linux.vnet.ibm.com>
4719
4720         * dwarf2loc.c (dwarf2_evaluate_loc_desc_full): For
4721         DWARF_VALUE_LITERAL, no longer ignore the offset on big-endian
4722         targets.  And if the implicit value is longer than needed, extract
4723         the first bytes instead of the "least significant" ones.
4724
4725 2017-02-01  Markus Metzger  <markus.t.metzger@intel.com>
4726
4727         * btrace.c (btrace_enable): Do not call btrace_add_pc for
4728         BTRACE_FORMAT_PT or if can_access_registers_ptid returns false.
4729         (btrace_fetch): Assert can_access_registers_ptid.
4730         * record-btrace.c (require_btrace_thread, record_btrace_info): Call
4731         validate_registers_access.
4732
4733 2017-02-01  Markus Metzger  <markus.t.metzger@intel.com>
4734
4735         * gdbthread.h (can_access_registers_ptid): New.
4736         * thread.c (can_access_registers_ptid): New.
4737
4738 2017-02-01  Pedro Alves  <palves@redhat.com>
4739
4740         * i386-tdep.c (i386_fast_tracepoint_valid_at): Use gdb_insn_length.
4741
4742 2017-01-31  Pedro Alves  <palves@redhat.com>
4743
4744         * mi/mi-interp.c (mi_breakpoint_created, mi_breakpoint_modified):
4745         Fix typos.
4746
4747 2017-01-31  Pedro Alves  <palves@redhat.com>
4748
4749         * stack.c (print_frame_args): Remove local mem_fileopen stream,
4750         not used.
4751
4752 2017-01-31  Pedro Alves  <palves@redhat.com>
4753
4754         * varobj.c (varobj_value_get_print_value): Remove xstrdup call.
4755
4756 2017-01-31  Pedro Alves  <palves@redhat.com>
4757
4758         * common/scoped_restore.h
4759         (scoped_restore_tmpl::scoped_restore_tmpl): Template on T2, and
4760         change the value's parameter type to T2.
4761         (make_scoped_restore): Likewise.
4762
4763 2017-01-27  Walfred Tedeschi  <walfred.tedeschi@intel.com>
4764             Richard Henderson  <rth@redhat.com>
4765
4766         * amd64-linux-nat.c (PTRACE_ARCH_PRCTL): New define.
4767         (amd64_linux_fetch_inferior_registers): Add case to fetch FS_BASE
4768         GS_BASE for older kernels.
4769         (amd64_linux_store_inferior_registers): Add case to store FS_BASE
4770         GS_BASE for older kernels.
4771         * amd64-linux-tdep.c (amd64_linux_gregset_reg_offset): Add FS_BASE
4772         and GS_BASE to the offset table.
4773         (amd64_linux_register_reggroup_p): Add FS_BASE and GS_BASE to the
4774         system register group.
4775         * amd64-nat.c (amd64_native_gregset_reg_offset): Implements case
4776         for older kernels.
4777         * amd64-tdep.c (amd64_init_abi): Add segment registers for the
4778         amd64 ABI.
4779         * amd64-tdep.h (amd64_regnum): Add AMD64_FSBASE_REGNUM and
4780         AMD64_GSBASE_REGNUM.
4781         (AMD64_NUM_REGS): Set to AMD64_GSBASE_REGNUM + 1.
4782         * features/Makefile (amd64-linux.dat, amd64-avx-linux.dat)
4783         (amd64-mpx-linux.dat, amd64-avx512-linux.dat, x32-linux.dat)
4784         (x32-avx-linux.dat, x32-avx512-linux.dat): Add
4785         i386/64bit-segments.xml in those rules.
4786         * features/i386/64bit-segments.xml: New file.
4787         * features/i386/amd64-avx-mpx-linux.xml: Add 64bit-segments.xml.
4788         * features/i386/amd64-avx-linux.xml: Add 64bit-segments.xml.
4789         * features/i386/amd64-avx512-linux.xml: Add 64bit-segments.xml.
4790         * features/i386/amd64-mpx-linux.xml: Add 64bit-segments.xml.
4791         * features/i386/x32-avx512-linux.xml: Add 64bit-segments.xml.
4792         * features/i386/x32-avx-linux.xml: Add 64bit-segments.xml.
4793         * features/i386/amd64-linux.xml: Add 64bit-segments.xml.
4794         * features/i386/amd64-avx-linux.c: Regenerated.
4795         * features/i386/amd64-avx-mpx-linux.c: Regenerated.
4796         * features/i386/amd64-avx-mpx.c: Regenerated.
4797         * features/i386/amd64-avx512-linux.c: Regenerated.
4798         * features/i386/amd64-linux.c: Regenerated.
4799         * features/i386/amd64-mpx-linux.c: Regenerated.
4800         * features/i386/i386-avx-mpx-linux.c: Regenerated.
4801         * features/i386/i386-avx-mpx.c: Regenerated.
4802         * features/i386/x32-avx-linux.c: Regenerated.
4803         * features/i386/x32-avx512-linux.c: Regenerated.
4804         * regformats/i386/amd64-avx-linux.dat: Regenerated.
4805         * regformats/i386/amd64-avx-mpx-linux.dat: Regenerated.
4806         * regformats/i386/amd64-avx512-linux.dat: Regenerated.
4807         * regformats/i386/amd64-linux.dat: Regenerated.
4808         * regformats/i386/amd64-mpx-linux.dat: Regenerated.
4809         * regformats/i386/x32-avx-linux.dat: Regenerated.
4810         * regformats/i386/x32-avx512-linux.dat: Regenerated.
4811         * regformats/i386/x32-linux.dat: Regenerated.
4812
4813 2017-01-27  Walfred Tedeschi  <walfred.tedeschi@intel.com>
4814
4815         * amd64-linux-tdep.h (AMD64_LINUX_ORIG_RAX_REGNUM):
4816         Set to AMD64_NUM_REGS.
4817
4818 2017-01-27  Walfred Tedeschi  <walfred.tedeschi@intel.com>
4819
4820         * amd64-nat.c (amd64_native_gregset_reg_offset): Simplify logic
4821         that checks validity of a register number.
4822
4823 2017-01-27  Kees Cook  <keescook@google.com>
4824
4825         * gdb/arm-linux-nat.c (arm_linux_fetch_inferior_registers): Call
4826         fetch_fpregs if target has fpa registers.
4827         (arm_linux_store_inferior_registers): Call store_fpregs if target
4828         has fpa registers.
4829
4830 2017-01-26  Andreas Arnez  <arnez@linux.vnet.ibm.com>
4831
4832         * cris-tdep.c (cris_gdbarch_init): Remove check for
4833         info.byte_order and force it to BFD_ENDIAN_LITTLE.
4834
4835 2017-01-26  Antoine Tremblay  <antoine.tremblay@ericsson.com>
4836
4837         * corelow.c (get_core_register_section): Check for regset
4838         existence before checking for REGSET_VARIABLE_SIZE.
4839
4840 2017-01-26  Yao Qi  <yao.qi@linaro.org>
4841             Pedro Alves  <palves@redhat.com>
4842
4843         PR gdb/20939
4844         * disasm.c (gdb_disassembler::dis_asm_memory_error): Don't
4845         call memory_error, save memaddr instead.
4846         (gdb_disassembler::print_insn): If gdbarch_print_insn returns
4847         negative, cal memory_error.
4848         * disasm.h (gdb_disassembler) <m_err_memaddr>: New field.
4849
4850 2017-01-26  Yao Qi  <yao.qi@linaro.org>
4851
4852         * disasm-selftests.c (memory_error_test): New function.
4853         (_initialize_disasm_selftests): Register memory_error_test.
4854
4855 2017-01-26  Yao Qi  <yao.qi@linaro.org>
4856
4857         * Makefile.in (SFILES): Add disasm-selftests.c and
4858         selftest-arch.c.
4859         (COMMON_OBS): Add disasm-selftests.o and selftest-arch.o.
4860         * disasm-selftests.c: New file.
4861         * selftest-arch.c: New file.
4862         * selftest-arch.h: New file.
4863
4864 2017-01-26  Yao Qi  <yao.qi@linaro.org>
4865
4866         * mep-tdep.c (mep_gdb_print_insn): Set info->arch
4867         to bfd_arch_mep.  Don't return 0 if section is not
4868         found.  Call print_insn_mep.
4869
4870 2017-01-26  Pedro Alves  <palves@redhat.com>
4871             Yao Qi  <yao.qi@linaro.org>
4872
4873         * arm-tdep.c: Include "disasm.h".
4874         (gdb_print_insn_arm): Update code to get gdbarch.
4875         * disasm.c (dis_asm_read_memory): Change it to
4876         gdb_disassembler::dis_asm_read_memory.
4877         (dis_asm_memory_error): Likewise.
4878         (dis_asm_print_address): Likewise.
4879         (gdb_pretty_print_insn): Change it to
4880         gdb_disassembler::pretty_print_insn.
4881         (dump_insns): Add one argument gdb_disassemlber.  All
4882         callers updated.
4883         (do_mixed_source_and_assembly_deprecated): Likewise.
4884         (do_mixed_source_and_assembly): Likewise.
4885         (do_assembly_only): Likewise.
4886         (gdb_disassembler::gdb_disassembler): New.
4887         (gdb_disassembler::print_insn): New.
4888         * disasm.h (class gdb_disassembler): New.
4889         (gdb_pretty_print_insn): Remove declaration.
4890         (gdb_disassemble_info): Likewise.
4891         * guile/scm-disasm.c (class gdbscm_disassembler): New.
4892         (gdbscm_disasm_read_memory_worker): Update.
4893         (gdbscm_disasm_read_memory): Update.
4894         (gdbscm_disasm_memory_error): Remove.
4895         (gdbscm_disasm_print_address): Remove.
4896         (gdbscm_disassembler::gdbscm_disassembler): New.
4897         (gdbscm_print_insn_from_port): Update.
4898         * mips-tdep.c: Include disasm.h.
4899         (gdb_print_insn_mips): Update code to get gdbarch.
4900         * record-btrace.c (btrace_insn_history): Update.
4901         * spu-tdep.c: Include disasm.h.
4902         (struct spu_dis_asm_data): Remove.
4903         (struct spu_dis_asm_info): New.
4904         (spu_dis_asm_print_address): Use spu_dis_asm_info to get
4905         SPU id.
4906         (gdb_print_insn_spu): Cast disassemble_info to
4907         spu_dis_asm_info.
4908
4909 2017-01-26  Yao Qi  <yao.qi@linaro.org>
4910
4911         * disasm.c (do_ui_file_delete): Delete.
4912         (gdb_insn_length): Move code creating stream to ...
4913         * utils.c (null_stream): ... here.  New function.
4914         * utils.h (null_stream): Declare.
4915
4916 2017-01-23  Simon Marchi  <simon.marchi@polymtl.ca>
4917
4918         * python/py-inferior.c (find_thread_object): Return directly
4919         from the loop.  Remove "found" variable.
4920
4921 2017-01-21  Joel Brobecker  <brobecker@adacore.com>
4922
4923         GDB 7.12.1 released.
4924
4925 2017-01-20  Simon Marchi  <simon.marchi@ericsson.com>
4926
4927         * python/py-function.c (fnpy_call): Reorder declarations to have
4928         the gdbpy_enter object declared first.
4929         * python/py-xmethods.c (gdbpy_get_xmethod_arg_types): Likewise.
4930
4931 2017-01-20  Simon Marchi  <simon.marchi@ericsson.com>
4932
4933         PR python/21068
4934         * python/python-internal.h (PyMem_RawMalloc): Define for
4935         Python < 3.4.
4936         * python/py-gdb-readline.c (gdbpy_readline_wrapper): Use
4937         PyMem_RawMalloc instead of PyMem_Malloc.
4938
4939 2017-01-20  Mike Wrighton  <mike_wrighton@codesourcery.com>
4940             Luis Machado  <lgustavo@codesourcery.com>
4941
4942         * NEWS (New commands): Mention flash-erase.
4943         (New MI commands): Mention target-flash-erase.
4944         * mi/mi-cmds.c (mi_cmd_target_flash_erase): Add target-flash-erase MI
4945         command.
4946         * mi/mi-cmds.h (mi_cmd_target_flash_erase): New declaration.
4947         * mi/mi-main.c (mi_cmd_target_flash_erase): New function.
4948         * target.c (flash_erase_command): New function.
4949         (initialize_targets): Add new flash-erase command.
4950         * target.h (flash_erase_command): New declaration.
4951
4952 2017-01-20  Joel Brobecker  <brobecker@adacore.com>
4953
4954         * nat/linux-ptrace.c: Only include <sys/procfs.h> if
4955         HAVE_SYS_PROCFS_H is defined.
4956
4957 2017-01-18  Alan Hayward  <alan.hayward@arm.com>
4958
4959         * remote.c (struct cached_reg): Change data into a pointer.
4960         * (stop_reply_dtr): Free data pointers before deleting vector.
4961         (process_stop_reply): Likewise.
4962         (remote_parse_stop_reply): Allocate space for data
4963
4964 2017-01-18  Alan Hayward  <alan.hayward@arm.com>
4965
4966         * amd64-tdep.c (amd64_pseudo_register_read_value): remove
4967         MAX_REGISTER_SIZE.
4968         (amd64_pseudo_register_read_value): Likewise.
4969         * remote.c (fetch_register_using_p): Remove MAX_REGISTER_SIZE.
4970         (store_register_using_P): Likewise.
4971         * regcache.c (regcache_xfer_part): Likewise.
4972
4973 2017-01-16  Ivo Raisr  <ivo.raisr@oracle.com>
4974
4975         Split real and pseudo registers.
4976         * sparc-tdep.h (SPARC_CORE_REGISTERS): New macro.
4977         (sparc32_pseudo_regnum): New enum.
4978         * sparc64-tdep.h (sparc64_pseudo_regnum): New enum.
4979         * sparc-tdep.c (SPARC32_FPU_REGISTERS): New macro.
4980         (SPARC32_CP0_REGISTERS): New macro.
4981         (sparc32_pseudo_register_name): New function.
4982         (sparc32_register_name): Use sparc32_pseudo_register_name.
4983         (sparc32_pseudo_register_type): New function.
4984         (sparc32_register_type): Use sparc32_pseudo_register_type.
4985         (sparc32_pseudo_register_read, sparc32_pseudo_register_write): Handle
4986         pseudo register numbers.
4987         * sparc64-tdep.c SPARC64_FPU_REGISTERS): New macro.
4988         (SPARC64_CP0_REGISTERS): New macro.
4989         (sparc64_pseudo_register_name): New function.
4990         (sparc64_register_name): Use sparc64_pseudo_register_name.
4991         (sparc64_pseudo_register_type): New function.
4992         (sparc64_register_type): Use sparc64_pseudo_register_type.
4993         (sparc64_pseudo_register_read, sparc64_pseudo_register_write): Handle
4994         pseudo register numbers.
4995         (sparc64_store_floating_fields, sparc64_extract_floating_fields,
4996         sparc64_store_arguments): Handle pseudo register numbers.
4997
4998 2017-01-13  Yao Qi  <yao.qi@linaro.org>
4999
5000         * remote.c (REMOTE_DEBUG_MAX_CHAR): New macro.
5001         (putpkt_binary): Print only REMOTE_DEBUG_MAX_CHAR chars in debug
5002         output.
5003         (getpkt_or_notif_sane_1): Likewise.
5004
5005 2017-01-13  Yao Qi  <yao.qi@linaro.org>
5006
5007         * Makefile.in (checker-headers): Use CXX and CXX_DIALET instead
5008         of CC.  Pass "-x c++-header" instead of "-x c".
5009
5010 2017-01-12  Simon Marchi  <simon.marchi@ericsson.com>
5011
5012         * remote.c (remote_can_async_p): Update comment.
5013
5014 2017-01-12  Simon Marchi  <simon.marchi@ericsson.com>
5015
5016         * linux-nat.c (linux_nat_can_async_p): Update comment.
5017
5018 2017-01-12  Simon Marchi  <simon.marchi@ericsson.com>
5019
5020         * serial.c (serial_open): Forget about "pc" and "lpt" serial interface.
5021
5022 2017-01-11  Simon Marchi  <simon.marchi@ericsson.com>
5023
5024         * cli/cli-decode.c (lookup_cmd_1): Fix typo in comment.
5025
5026 2017-01-10  Tom Tromey  <tom@tromey.com>
5027
5028         * python/py-type.c (typy_legacy_template_argument): Update.
5029         * cp-support.h (struct demangle_parse_info) (demangle_parse_info,
5030         ~demangle_parse_info): Declare new members.
5031         (cp_demangled_name_to_comp): Return unique_ptr.
5032         (cp_demangled_name_parse_free)
5033         (make_cleanup_cp_demangled_name_parse_free)
5034         (cp_new_demangle_parse_info): Remove.
5035         * cp-support.c (do_demangled_name_parse_free_cleanup)
5036         (make_cleanup_cp_demangled_name_parse_free): Remove.
5037         (inspect_type, cp_canonicalize_string_full)
5038         (cp_canonicalize_string): Update.
5039         (mangled_name_to_comp): Change return type.
5040         (cp_class_name_from_physname, method_name_from_physname)
5041         (cp_func_name, cp_remove_params): Update.
5042         * cp-name-parser.y (demangle_parse_info): New constructor, from
5043         cp_new_demangle_parse_info.
5044         (~demangle_parse_info): New destructor, from
5045         cp_demangled_name_parse_free.
5046         (cp_merge_demangle_parse_infos): Update.
5047         (cp_demangled_name_to_comp): Change return type.
5048
5049 2017-01-10  Tom Tromey  <tom@tromey.com>
5050
5051         * top.c (prevent_dont_repeat): Change return type.
5052         * python/python.c (execute_gdb_command): Use std::string.
5053         Update.
5054         * guile/guile.c (gdbscm_execute_gdb_command): Update.
5055         * command.h (prevent_dont_repeat): Change return type.
5056         * breakpoint.c (bpstat_do_actions_1): Update.
5057
5058 2017-01-10  Tom Tromey  <tom@tromey.com>
5059
5060         * value.h (scoped_value_mark::~scoped_value_mark): Call
5061         free_to_mark.
5062         (scoped_value_mark::free_to_mark): New method.
5063         * dwarf2loc.c (dwarf2_evaluate_loc_desc_full): Use
5064         scoped_value_mark.
5065
5066 2017-01-10  Tom Tromey  <tom@tromey.com>
5067
5068         * python/py-value.c (valpy_dereference, valpy_referenced_value)
5069         (valpy_reference_value, valpy_const_value, valpy_get_address)
5070         (valpy_get_dynamic_type, valpy_lazy_string, valpy_do_cast)
5071         (valpy_getitem, valpy_call, valpy_binop_throw, valpy_negative)
5072         (valpy_absolute, valpy_richcompare_throw): Use scoped_value_mark.
5073         * dwarf2loc.c (dwarf2_loc_desc_get_symbol_read_needs): Use
5074         scoped_value_mark.
5075         * dwarf2-frame.c (execute_stack_op): Use scoped_value_mark.
5076         * value.h (scoped_value_mark): New class.
5077
5078 2017-01-10  Tom Tromey  <tom@tromey.com>
5079
5080         * dwarf2read.c (dwarf2_build_psymtabs): Use psymtab_discarder.
5081         * psympriv.h (make_cleanup_discard_psymtabs): Don't declare.
5082         * psymtab.c (discard_psymtabs_upto): Remove.
5083         (make_cleanup_discard_psymtabs): Remove.
5084         (struct psymtab_state): Remove.
5085
5086 2017-01-10  Tom Tromey  <tom@tromey.com>
5087
5088         * record-full.c (record_full_save_cleanups): Remove.
5089         (record_full_save): Use gdb::unlinker.
5090         * gcore.c (do_bfd_delete_cleanup): Remove.
5091         (gcore_command): Use gdb::unlinker, unique_xmalloc_ptr.  Remove
5092         cleanups.
5093         * dwarf2read.c (unlink_if_set): Remove.
5094         (write_psymtabs_to_index): Use gdb::unlinker.
5095         * common/gdb_unlinker.h: New file.
5096
5097 2017-01-10  Tom Tromey  <tom@tromey.com>
5098
5099         * windows-tdep.c (windows_xfer_shared_library): Update.
5100         * windows-nat.c (windows_make_so): Update.
5101         * utils.h (make_cleanup_bfd_unref): Remove.
5102         * utils.c (do_bfd_close_cleanup, make_cleanup_bfd_unref): Remove.
5103         * symfile.h (symfile_bfd_open)
5104         (find_separate_debug_file_in_section): Return gdb_bfd_ref_ptr.
5105         * symfile.c (read_symbols, symbol_file_add)
5106         (separate_debug_file_exists): Update.
5107         (symfile_bfd_open): Return gdb_bfd_ref_ptr.
5108         (generic_load, reread_symbols): Update.
5109         * symfile-mem.c (symbol_file_add_from_memory): Update.
5110         * spu-linux-nat.c (spu_bfd_open): Return gdb_bfd_ref_ptr.
5111         (spu_symbol_file_add_from_memory): Update.
5112         * solist.h (struct target_so_ops) <bfd_open>: Return
5113         gdb_bfd_ref_ptr.
5114         (solib_bfd_fopen, solib_bfd_open): Return gdb_bfd_ref_ptr.
5115         * solib.c (solib_bfd_fopen, solib_bfd_open): Return
5116         gdb_bfd_ref_ptr.
5117         (solib_map_sections, reload_shared_libraries_1): Update.
5118         * solib-svr4.c (enable_break): Update.
5119         * solib-spu.c (spu_bfd_fopen): Return gdb_bfd_ref_ptr.
5120         * solib-frv.c (enable_break2): Update.
5121         * solib-dsbt.c (enable_break): Update.
5122         * solib-darwin.c (gdb_bfd_mach_o_fat_extract): Return
5123         gdb_bfd_ref_ptr.
5124         (darwin_solib_get_all_image_info_addr_at_init): Update.
5125         (darwin_bfd_open): Return gdb_bfd_ref_ptr.
5126         * solib-aix.c (solib_aix_bfd_open): Return gdb_bfd_ref_ptr.
5127         * record-full.c (record_full_save): Update.
5128         * python/py-objfile.c (objfpy_add_separate_debug_file): Update.
5129         * procfs.c (insert_dbx_link_bpt_in_file): Update.
5130         * minidebug.c (find_separate_debug_file_in_section): Return
5131         gdb_bfd_ref_ptr.
5132         * machoread.c (macho_add_oso_symfile): Change abfd to
5133         gdb_bfd_ref_ptr.
5134         (macho_symfile_read_all_oso): Update.
5135         (macho_check_dsym): Return gdb_bfd_ref_ptr.
5136         (macho_symfile_read): Update.
5137         * jit.c (bfd_open_from_target_memory): Return gdb_bfd_ref_ptr.
5138         (jit_bfd_try_read_symtab): Update.
5139         * gdb_bfd.h (gdb_bfd_open, gdb_bfd_fopen, gdb_bfd_openr)
5140         (gdb_bfd_openw, gdb_bfd_openr_iovec)
5141         (gdb_bfd_openr_next_archived_file, gdb_bfd_fdopenr): Return
5142         gdb_bfd_ref_ptr.
5143         (gdb_bfd_ref_policy): New struct.
5144         (gdb_bfd_ref_ptr): New typedef.
5145         * gdb_bfd.c (gdb_bfd_open, gdb_bfd_fopen, gdb_bfd_openr)
5146         (gdb_bfd_openw, gdb_bfd_openr_iovec)
5147         (gdb_bfd_openr_next_archived_file, gdb_bfd_fdopenr): Return
5148         gdb_bfd_ref_ptr.
5149         * gcore.h (create_gcore_bfd): Return gdb_bfd_ref_ptr.
5150         * gcore.c (create_gcore_bfd): Return gdb_bfd_ref_ptr.
5151         (gcore_command): Update.
5152         * exec.c (exec_file_attach): Update.
5153         * elfread.c (elf_symfile_read): Update.
5154         * dwarf2read.c (dwarf2_get_dwz_file): Update.
5155         (try_open_dwop_file, open_dwo_file): Return gdb_bfd_ref_ptr.
5156         (open_and_init_dwo_file): Update.
5157         (open_dwp_file): Return gdb_bfd_ref_ptr.
5158         (open_and_init_dwp_file): Update.
5159         * corelow.c (core_open): Update.
5160         * compile/compile-object-load.c (compile_object_load): Update.
5161         * common/gdb_ref_ptr.h (ref_ptr::operator->): New operator.
5162         * coffread.c (coff_symfile_read): Update.
5163         * cli/cli-dump.c (bfd_openr_or_error, bfd_openw_or_error): Return
5164         gdb_bfd_ref_ptr.  Rename.
5165         (dump_bfd_file, restore_command): Update.
5166         * build-id.h (build_id_to_debug_bfd): Return gdb_bfd_ref_ptr.
5167         * build-id.c (build_id_to_debug_bfd): Return gdb_bfd_ref_ptr.
5168         (find_separate_debug_file_by_buildid): Update.
5169
5170 2017-01-10  Tom Tromey  <tom@tromey.com>
5171
5172         * common/gdb_ref_ptr.h: New file.
5173         * python/py-ref.h (struct gdbpy_ref_policy): New.
5174         (gdbpy_ref): Now a typedef.
5175
5176 2017-01-10  Tom Tromey  <tom@tromey.com>
5177
5178         * utils.h (make_cleanup_htab_delete): Don't declare.
5179         * utils.c (do_htab_delete_cleanup, make_cleanup_htab_delete):
5180         Remove.
5181         * linespec.c (decode_compound_collector): Add constructor,
5182         destructor.
5183         (lookup_prefix_sym): Remove cleanup.
5184         (symtab_collector): Add constructor, destructor.
5185         (collect_symtabs_from_filename): Remove cleanup.
5186         * disasm.c (do_mixed_source_and_assembly): Use htab_up.
5187         * compile/compile-c-symbols.c (generate_c_for_variable_locations):
5188         Use htab_up.
5189         * gnu-v3-abi.c (gnuv3_print_vtable): Use htab_up.
5190         * dwarf2read.c (dw2_expand_symtabs_matching)
5191         (dw2_map_symbol_filenames, dwarf_decode_macros)
5192         (write_psymtabs_to_index): Use htab_up.
5193         * dwarf2loc.c (func_verify_no_selftailcall)
5194         (call_site_find_chain_1, func_verify_no_selftailcall)
5195         (chain_candidate, call_site_find_chain_1): Use std::unordered_set,
5196         std::vector, gdb::unique_xmalloc_ptr.
5197         (call_sitep): Remove typedef.
5198         (dwarf2_locexpr_baton_eval): Remove unused variable.
5199
5200 2017-01-10  Tom Tromey  <tom@tromey.com>
5201
5202         * python/python-internal.h (make_cleanup_py_decref)
5203         (make_cleanup_py_xdecref): Don't declare.
5204         * python/py-utils.c (py_decref, make_cleanup_py_decref)
5205         (py_xdecref, make_cleanup_py_xdecref): Remove.
5206
5207 2017-01-10  Tom Tromey  <tom@tromey.com>
5208
5209         * python/py-framefilter.c (py_mi_print_variables): Use gdbpy_ref.
5210         (py_print_locals, enumerate_locals, py_print_args): Use gdbpy_ref.
5211
5212 2017-01-10  Tom Tromey  <tom@tromey.com>
5213
5214         * python/py-framefilter.c (enumerate_args): Use gdbpy_ref.
5215
5216 2017-01-10  Tom Tromey  <tom@tromey.com>
5217
5218         * python/py-utils.c (unicode_to_encoded_string)
5219         (python_string_to_target_string)
5220         (python_string_to_target_python_string)
5221         (python_string_to_host_string, gdbpy_obj_to_string)
5222         (get_addr_from_python): Use gdbpy_ref.
5223
5224 2017-01-10  Tom Tromey  <tom@tromey.com>
5225
5226         * python/py-unwind.c (pyuw_object_attribute_to_pointer): Use
5227         gdbpy_ref.
5228
5229 2017-01-10  Tom Tromey  <tom@tromey.com>
5230
5231         * python/python.c (eval_python_command, gdbpy_decode_line)
5232         (gdbpy_run_events, gdbpy_start_type_printers)
5233         (gdbpy_apply_type_printers): Use gdbpy_ref.
5234
5235 2017-01-10  Tom Tromey  <tom@tromey.com>
5236
5237         * python/py-param.c (get_doc_string, compute_enum_values): Use
5238         gdbpy_ref.
5239
5240 2017-01-10  Tom Tromey  <tom@tromey.com>
5241
5242         * python/py-inferior.c (find_thread_object, build_inferior_list):
5243         Use gdbpy_ref.
5244
5245 2017-01-10  Tom Tromey  <tom@tromey.com>
5246
5247         * python/py-framefilter.c (py_print_frame): Use gdbpy_ref.
5248
5249 2017-01-10  Tom Tromey  <tom@tromey.com>
5250
5251         * python/py-finishbreakpoint.c (bpfinishpy_out_of_scope): Use
5252         gdbpy_ref.
5253
5254 2017-01-10  Tom Tromey  <tom@tromey.com>
5255
5256         * python/py-cmd.c (cmdpy_completer_helper): Use gdbpy_ref.  Remove
5257         extra incref.
5258         (cmdpy_completer_handle_brkchars, cmdpy_completer, cmdpy_init):
5259         Use gdbpy_ref.
5260
5261 2017-01-10  Tom Tromey  <tom@tromey.com>
5262
5263         * python/py-breakpoint.c (gdbpy_breakpoint_cond_says_stop): Use
5264         gdbpy_ref.
5265
5266 2017-01-10  Tom Tromey  <tom@tromey.com>
5267
5268         * python/py-arch.c (archpy_disassemble): Use gdbpy_ref.  Don't
5269         decref results of PyArg_ParseTupleAndKeywords.
5270
5271 2017-01-10  Tom Tromey  <tom@tromey.com>
5272
5273         * python/python.c (python_run_simple_file): Use
5274         unique_xmalloc_ptr, gdbpy_ref.
5275
5276 2017-01-10  Tom Tromey  <tom@tromey.com>
5277
5278         * python/py-prettyprint.c (print_stack_unless_memory_error)
5279         (print_string_repr, print_children): Use gdbpy_ref.
5280         (dummy_python_frame): New class.
5281         (dummy_python_frame::dummy_python_frame): Rename from
5282         push_dummy_python_frame.
5283         (py_restore_tstate): Remove.
5284
5285 2017-01-10  Tom Tromey  <tom@tromey.com>
5286
5287         * python/py-framefilter.c (py_print_frame): Use gdbpy_ref.
5288
5289 2017-01-10  Tom Tromey  <tom@tromey.com>
5290
5291         * python/python.c (ensure_python_env, restore_python_env):
5292         Remove.
5293         * python/python-internal.h (ensure_python_env): Don't declare.
5294         * varobj.h (varobj_ensure_python_env): Don't declare.
5295         * varobj.c (varobj_ensure_python_env): Remove.
5296
5297 2017-01-10  Tom Tromey  <tom@tromey.com>
5298
5299         * varobj.c (varobj_value_get_print_value): Use
5300         gdbpy_enter_varobj.
5301
5302 2017-01-10  Tom Tromey  <tom@tromey.com>
5303
5304         * python/py-prettyprint.c (print_string_repr, print_children):
5305         Update.
5306         * python/py-lazy-string.c (gdbpy_extract_lazy_string): Change type
5307         of "encoding".
5308         * varobj.c (varobj_value_get_print_value): Update.
5309         * python/python-internal.h (gdbpy_extract_lazy_string): Update.
5310
5311 2017-01-10  Tom Tromey  <tom@tromey.com>
5312
5313         * varobj.c (varobj_get_display_hint)
5314         (dynamic_varobj_has_child_method, install_new_value_visualizer)
5315         (varobj_set_visualizer, free_variable): Use
5316         gdbpy_enter_varobj.
5317
5318 2017-01-10  Tom Tromey  <tom@tromey.com>
5319
5320         * python/python.c (python_command): Use gdbpy_enter, gdbpy_ref.
5321         (do_finish_initialization): New function.  Use gdbpy_ref.
5322         (gdbpy_finish_initialization): Use gdbpy_enter.  Call
5323         do_finish_initialization.
5324
5325 2017-01-10  Tom Tromey  <tom@tromey.com>
5326
5327         * python/py-param.c (get_set_value, get_show_value): Use
5328         gdbpy_enter, gdbpy_ref.
5329
5330 2017-01-10  Tom Tromey  <tom@tromey.com>
5331
5332         * python/py-function.c (fnpy_call): Use gdbpy_enter, gdbpy_ref.
5333
5334 2017-01-10  Tom Tromey  <tom@tromey.com>
5335
5336         * python/py-cmd.c (cmdpy_function): Use gdbpy_enter, gdbpy_ref.
5337
5338 2017-01-10  Tom Tromey  <tom@tromey.com>
5339
5340         * python/py-varobj.c (py_varobj_iter_dtor, py_varobj_iter_next):
5341         Use gdbpy_enter_varobj.
5342
5343 2017-01-10  Tom Tromey  <tom@tromey.com>
5344
5345         * varobj.c (gdbpy_enter_varobj): New constructor.
5346         * python/python-internal.h (gdbpy_enter_varobj): New class.
5347         * python/py-varobj.c (py_varobj_get_iterator): Use
5348         gdbpy_enter_varobj.
5349
5350 2017-01-10  Tom Tromey  <tom@tromey.com>
5351
5352         * python/py-xmethods.c (gdbpy_get_xmethod_result_type): Use
5353         gdbpy_enter, gdbpy_ref, unique_xmalloc_ptr.
5354         (gdbpy_invoke_xmethod): Use gdbpy_ref, gdbpy_enter.
5355         (gdbpy_get_xmethod_arg_types): Use gdbpy_ref,
5356         unique_xmalloc_ptr.
5357         (gdbpy_get_xmethod_arg_types): Use gdbpy_ref, gdbpy_enter.
5358
5359 2017-01-10  Tom Tromey  <tom@tromey.com>
5360
5361         * python/py-xmethods.c (invoke_match_method): Use
5362         gdbpy_ref.
5363
5364 2017-01-10  Tom Tromey  <tom@tromey.com>
5365
5366         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): use
5367         gdbpy_enter, gdbpy_ref.
5368
5369 2017-01-10  Tom Tromey  <tom@tromey.com>
5370
5371         * python/python.c (python_interactive_command): Use gdbpy_enter.
5372
5373 2017-01-10  Tom Tromey  <tom@tromey.com>
5374
5375         * python/python.c (gdbpy_before_prompt_hook): Use gdbpy_enter,
5376         gdbpy_ref.
5377
5378 2017-01-10  Tom Tromey  <tom@tromey.com>
5379
5380         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Use
5381         gdbpy_enter, gdbpy_ref, unique_xmalloc_ptr.
5382
5383 2017-01-10  Tom Tromey  <tom@tromey.com>
5384
5385         * utils.h (htab_deleter): New struct.
5386         (htab_up): New typedef.
5387         * python/py-framefilter.c (gdbpy_apply_frame_filter): Use
5388         gdbpy_enter, gdbpy_ref, htab_up.
5389
5390 2017-01-10  Tom Tromey  <tom@tromey.com>
5391
5392         * python/py-unwind.c (pending_frame_invalidate): Remove.
5393         (pyuw_sniffer): Use gdbpy_enter and gdbpy_ref.
5394
5395 2017-01-10  Tom Tromey  <tom@tromey.com>
5396
5397         * python/py-xmethods.c (gdbpy_free_xmethod_worker_data)
5398         (gdbpy_clone_xmethod_worker_data): Use gdbpy_enter.
5399
5400 2017-01-10  Tom Tromey  <tom@tromey.com>
5401
5402         * python/py-type.c (save_objfile_types): Use gdbpy_enter.
5403
5404 2017-01-10  Tom Tromey  <tom@tromey.com>
5405
5406         * python/python.c (gdbpy_eval_from_control_command)
5407         (gdbpy_source_script, gdbpy_run_events)
5408         (gdbpy_source_objfile_script, gdbpy_execute_objfile_script)
5409         (gdbpy_free_type_printers, gdbpy_finish_initialization): Use
5410         gdbpy_enter.
5411
5412 2017-01-10  Tom Tromey  <tom@tromey.com>
5413
5414         * python/py-progspace.c (py_free_pspace): Use gdbpy_enter.
5415
5416 2017-01-10  Tom Tromey  <tom@tromey.com>
5417
5418         * python/py-objfile.c (py_free_objfile): Use gdbpy_enter.
5419
5420 2017-01-10  Tom Tromey  <tom@tromey.com>
5421
5422         * python/py-inferior.c (python_on_normal_stop, python_on_resume)
5423         (python_on_inferior_call_pre, python_on_inferior_call_post)
5424         (python_on_memory_change, python_on_register_change)
5425         (python_inferior_exit, python_new_objfile, add_thread_object)
5426         (delete_thread_object, py_free_inferior): Use gdbpy_enter.
5427
5428 2017-01-10  Tom Tromey  <tom@tromey.com>
5429
5430         * python/py-finishbreakpoint.c (bpfinishpy_handle_stop)
5431         (bpfinishpy_handle_exit): Use gdbpy_enter.
5432
5433 2017-01-10  Tom Tromey  <tom@tromey.com>
5434
5435         * python/py-cmd.c (cmdpy_destroyer)
5436         (cmdpy_completer_handle_brkchars, cmdpy_completer): Use
5437         gdbpy_enter.
5438
5439 2017-01-10  Tom Tromey  <tom@tromey.com>
5440
5441         * python/py-breakpoint.c (gdbpy_breakpoint_cond_says_stop): Use
5442         gdbpy_enter.
5443         (gdbpy_breakpoint_has_cond): Likewise.
5444
5445 2017-01-10  Tom Tromey  <tom@tromey.com>
5446
5447         * python/python.c (gdbpy_enter): New constructor.
5448         (~gdbpy_enter): New destructor.
5449         (restore_python_env, ensure_python_env): Rewrite.
5450         * python/python-internal.h (gdbpy_enter): New class.
5451
5452 2017-01-10  Tom Tromey  <tom@tromey.com>
5453
5454         * python/py-symbol.c (gdbpy_lookup_symbol): Use gdbpy_ref.
5455
5456 2017-01-10  Tom Tromey  <tom@tromey.com>
5457
5458         * python/py-value.c (value_has_field, get_field_flag)
5459         (get_field_type, valpy_getitem, convert_value_from_python): Use
5460         gdbpy_ref.
5461
5462 2017-01-10  Tom Tromey  <tom@tromey.com>
5463
5464         * python/python.c (gdbpy_progspaces, gdbpy_objfiles): Use
5465         gdbpy_ref.
5466
5467 2017-01-10  Tom Tromey  <tom@tromey.com>
5468
5469         * python/py-prettyprint.c (search_pp_list)
5470         (find_pretty_printer_from_objfiles)
5471         (find_pretty_printer_from_progspace)
5472         (find_pretty_printer_from_gdb, find_pretty_printer)
5473         (gdbpy_get_display_hint, gdbpy_get_varobj_pretty_printer): Use
5474         gdbpy_ref.
5475
5476 2017-01-10  Tom Tromey  <tom@tromey.com>
5477
5478         * python/py-param.c (call_doc_function): Use gdbpy_ref.
5479
5480 2017-01-10  Tom Tromey  <tom@tromey.com>
5481
5482         * python/py-linetable.c (build_line_table_tuple_from_pcs)
5483         (ltpy_get_all_source_lines): Use gdbpy_ref.
5484
5485 2017-01-10  Tom Tromey  <tom@tromey.com>
5486
5487         * python/py-framefilter.c (extract_sym, extract_value)
5488         (get_py_iter_from_func, bootstrap_python_frame_filters): Use
5489         gdbpy_ref.
5490
5491 2017-01-10  Tom Tromey  <tom@tromey.com>
5492
5493         * python/py-breakpoint.c (gdbpy_breakpoints): Use gdbpy_ref.
5494
5495 2017-01-10  Tom Tromey  <tom@tromey.com>
5496
5497         * python/py-inferior.c (gdbpy_inferiors): Use gdbpy_ref.
5498
5499 2017-01-10  Tom Tromey  <tom@tromey.com>
5500
5501         * python/py-function.c (convert_values_to_python, fnpy_init): Use
5502         gdbpy_ref.
5503
5504 2017-01-10  Tom Tromey  <tom@tromey.com>
5505
5506         * python/py-cmd.c (gdbpy_string_to_argv): Use gdbpy_ref.
5507
5508 2017-01-10  Tom Tromey  <tom@tromey.com>
5509
5510         * python/py-type.c (convert_field, make_fielditem, typy_fields)
5511         (typy_range): Use gdbpy_ref.
5512
5513 2017-01-10  Tom Tromey  <tom@tromey.com>
5514
5515         * python/py-threadevent.c (create_thread_event_object): Use
5516         gdbpy_ref.
5517         * python/py-stopevent.c (create_stop_event_object): Simplify.
5518         (emit_stop_event): Use gdbpy_ref.
5519         * python/py-signalevent.c (create_signal_event_object): Use
5520         gdbpy_ref.
5521         * python/py-newobjfileevent.c (create_new_objfile_event_object)
5522         (emit_new_objfile_event, create_clear_objfiles_event_object)
5523         (emit_clear_objfiles_event): Use gdbpy_ref.
5524         * python/py-infevents.c (create_inferior_call_event_object)
5525         (create_register_changed_event_object)
5526         (create_memory_changed_event_object, emit_inferior_call_event)
5527         (emit_memory_changed_event, emit_register_changed_event): Use
5528         gdbpy_ref.
5529         * python/py-exitedevent.c (create_exited_event_object)
5530         (emit_exited_event): Use gdbpy_ref.
5531         * python/py-event.h (evpy_emit_event): Remove
5532         CPYCHECKER_STEALS_REFERENCE_TO_ARG annotation.
5533         * python/py-event.c (evpy_emit_event): Use gdbpy_ref.
5534         * python/py-continueevent.c (emit_continue_event): Use
5535         gdbpy_ref.
5536         * python/py-breakpoint.c (gdbpy_breakpoint_created)
5537         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
5538         gdbpy_ref.
5539         * python/py-bpevent.c (create_breakpoint_event_object): Use
5540         gdbpy_ref.
5541
5542 2017-01-10  Tom Tromey  <tom@tromey.com>
5543
5544         * python/py-ref.h: New file.
5545
5546 2017-01-10  Simon Marchi  <simon.marchi@ericsson.com>
5547
5548         * cli-out.c (cli_ui_out::do_redirect): Change return type to
5549         void.
5550         * cli-out.h (cli_ui_out::do_redirect): Likewise.
5551         * mi/mi-out.c (mi_ui_out::do_redirect): Likewise.
5552         * mi/mi-out.h (mi_ui_out::do_redirect): Likewise.
5553         * ui-out.c (ui_out::redirect): Likewise.
5554         * ui-out.h (ui_out::redirect, ui_out::do_redirect): Likewise.
5555         * cli/cli-logging.c (set_logging_redirect): Update call site of
5556         ui_out::redirect.
5557         (handle_redirections): Likewise.
5558         * scm-ports.c (ioscm_with_output_to_port_worker): Likewise.
5559         * top.c (execute_command_to_string): Likewise.
5560         * utils.c (do_ui_out_redirect_pop): Likewise.
5561
5562 2017-01-10  Simon Marchi  <simon.marchi@ericsson.com>
5563
5564         * stack.c (_initialize_stack): Update "frame" command help message.
5565
5566 2017-01-08  Iain Buclaw  <ibuclaw@gdcproject.org>
5567
5568         * d-exp.y (CastExpression): Emit UNOP_CAST_TYPE.
5569
5570 2017-01-06  Yao Qi  <yao.qi@linaro.org>
5571
5572         * x86-linux-nat.h: Include gdb_proc_service.h.
5573
5574 2017-01-06  Yao Qi  <yao.qi@linaro.org>
5575
5576         * ser-base.h: Include serial.h.
5577
5578 2017-01-06  Yao Qi  <yao.qi@linaro.org>
5579
5580         * ppc-linux-tdep.h: Include ppc-tdep.h.
5581
5582 2017-01-06  Yao Qi  <yao.qi@linaro.org>
5583
5584         * nat/amd64-linux-siginfo.h: Include signal.h.
5585
5586 2017-01-06  Yao Qi  <yao.qi@linaro.org>
5587
5588         * nat/aarch64-linux-hw-point.h: Include break-common.h.
5589
5590 2017-01-06  Yao Qi  <yao.qi@linaro.org>
5591
5592         * mi/mi-parse.h: Include mi-cmds.h.
5593
5594 2017-01-06  Yao Qi  <yao.qi@linaro.org>
5595
5596         * inf-loop.c: Don't include "target.h".
5597         * inf-loop.h: Include it here.
5598
5599 2017-01-06  Yao Qi  <yao.qi@linaro.org>
5600
5601         * dfp.h: Include "dboulest.h" and "expression.h".
5602
5603 2017-01-06  Yao Qi  <yao.qi@linaro.org>
5604
5605         * ax-gdb.h: Include "ax.h".
5606
5607 2017-01-06  Yao Qi  <yao.qi@linaro.org>
5608
5609         * Makefile.in (HFILES_NO_SRCDIR): Replace gdb_ptrace.h
5610         with nat/gdb_ptrace.h.
5611
5612 2017-01-05  Yao Qi  <yao.qi@linaro.org>
5613
5614         * mips-fbsd-tdep.c (mips_fbsd_sigframe_init): Move && to
5615         new line.
5616         (mips64_fbsd_sigframe_init): Likewise.
5617
5618 2017-01-04  John Baldwin  <jhb@FreeBSD.org>
5619
5620         * mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Use
5621         GDB_OSABI_FREEBSD instead of GDB_OSABI_FREEBSD_ELF.
5622
5623 2017-01-04  John Baldwin  <jhb@FreeBSD.org>
5624
5625         * Makefile.in (ALLDEPFILES): Add mips-fbsd-nat.c.
5626         * NEWS: Mention new FreeBSD/mips native configuration.
5627         * config/mips/fbsd.mh: New file.
5628         * configure.host: Add mips*-*-freebsd*.
5629         * mips-fbsd-nat.c: New file.
5630
5631 2017-01-04  John Baldwin  <jhb@FreeBSD.org>
5632
5633         * Makefile.in (ALL_TARGET_OBS): Add mips-fbsd-tdep.o.
5634         (ALLDEPFILES): Add mips-fbsd-tdep.c.
5635         * NEWS: Mention new FreeBSD/mips target.
5636         * configure.tgt: Add mips*-*-freebsd*.
5637         * mips-fbsd-tdep.c: New file.
5638         * mips-fbsd-tdep.h: New file.
5639
5640 2017-01-04  Yao Qi  <yao.qi@linaro.org>
5641
5642         * dwarf2loc.c (write_pieced_value): Don't use VALUE_FRAME_ID (to),
5643         use c->frame_id when the piece location is DWARF_VALUE_REGISTER.
5644
5645 2017-01-01  Joel Brobecker  <brobecker@adacore.com>
5646
5647         Update copyright year range in all GDB files.
5648
5649 2017-01-01  Joel Brobecker  <brobecker@adacore.com>
5650
5651         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2016.
5652
5653 For older changes see ChangeLog-2016.
5654 \f
5655 Local Variables:
5656 mode: change-log
5657 left-margin: 8
5658 fill-column: 74
5659 version-control: never
5660 coding: utf-8
5661 End: