Make stap-probe.c:stap_parse_register_operand's "regname" an std::string
[external/binutils.git] / gdb / ChangeLog
1 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2
3         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4         "std::string", simplifying the algorithm.
5
6 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
7
8         * event-top.c: Remove include comment.
9         * inflow.c (class scoped_ignore_sigttou): Move from here...
10         * inflow.h (class scoped_ignore_sigttou): ...to here.
11         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
12         * top.c:  Remove include comment.
13
14 2019-08-04  Alan Hayward  <alan.hayward@arm.com>
15
16         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
17
18 2019-05-29  Tom Tromey  <tromey@adacore.com>
19
20         PR c++/20020:
21         * cp-valprint.c (cp_print_value_fields): Call
22         cp_print_static_field inside "try".
23
24 2019-06-10  Tom de Vries  <tdevries@suse.de>
25
26         PR symtab/24545
27         * symtab.c (struct demangled_name_entry): Add language field.
28         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
29         static minimal symbol".  Set and use language field.
30
31 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
32
33         PR gdb/24592
34         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
35         function.
36         (fill_gregset): Call amd64_linux_collect_native_gregset instead
37         of amd64_collect_native_gregset.
38         (amd64_linux_nat_target::store_registers): Likewise.
39
40 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
41
42         * version.in: Set GDB version number to 8.3.0.DATE-git.
43
44 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
45
46         GDB 8.3 released.
47
48 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
49
50         * version.in: Set GDB version number to 8.3.
51
52 2019-05-08  Tom Tromey  <tromey@adacore.com>
53
54         * utils.c (fputs_maybe_filtered): Reset style after paging, even
55         when no wrap column is set.
56
57 2019-05-04  Tom Tromey  <tom@tromey.com>
58
59         * psymtab.c (psymbol_name_matches, match_partial_symbol)
60         (lookup_partial_symbol, print_partial_symbols)
61         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
62         (psymbol_compare): Update.
63         (add_psymbol_to_bcache): Clear the entire psymbol.
64         (maintenance_check_psymtabs): Update.
65         * psympriv.h (struct partial_symbol): Don't derive from
66         general_symbol_info.
67         <obj_section, unrelocated_address, address,
68         set_unrelocated_address>: Update.
69         <ginfo>: New member.
70         * dwarf-index-write.c (write_psymbols, debug_names::insert)
71         (debug_names::write_psymbols): Update.
72
73 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
74
75         * windows-nat.c [_WIN32_WINNT]: Define _WIN32_WINNT to Windows XP
76         level, so that various Windows header files expose the necessary
77         declarations and definitions.
78
79         * symfile.c (find_separate_debug_file): Remove colon from the
80         drive spec of DOS/Windows file names of the target, so that the
81         file name produced from DEBUGDIR and the target's directory will
82         be valid on DOS/Windows systems.
83
84 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
85
86         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
87         Use current_event.dwThreadId instead of main_thread_id.
88
89 2019-04-30  Tom Tromey  <tromey@adacore.com>
90
91         PR c++/24470:
92         * dwarf2read.c (process_structure_scope): Handle case where type
93         has template parameters but no symbol was created.
94
95 2019-04-19  Sergei Trofimovich <siarheit@google.com>
96
97         * configure.ac: add --enable-source-highlight switch.
98         * configure: Regenerate.
99         * top.c (print_gdb_version): plumb --enable-source-highlight
100         status to "show configuration".
101
102 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
103
104         PR symtab/24423:
105         * source.c (print_source_lines_base): Advance "iter" when a
106         control character is seen.
107
108 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
109
110         * inferior.h (struct infcall_suspend_state_deleter):
111         Catch exception in destructor to avoid crash.
112
113 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
114
115         * utils.c (prompt_for_continue): Don't restore the styling at the
116         end, as applied_style has the wrong value.  This fixes styling in
117         long lists of file names that are interrupted by the "Continue?"
118         prompt.
119
120 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
121
122         * version.in: Set GDB version number to 8.2.91.DATE-git.
123
124 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
125
126         GDB 8.2.91 released.
127
128 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
129
130         * version.in: Set GDB version number to 8.2.91.
131
132 2019-03-20  Tom Tromey  <tromey@adacore.com>
133
134         PR gdb/24391
135         * infrun.c (handle_inferior_event): Rename from
136         handle_inferior_event_1.  Create a scoped_value_mark.
137         (handle_inferior_event): Remove.
138
139 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
140
141         * source-cache.c (source_cache::get_source_lines): Re-read
142         fullname after calling open_source_file.
143
144 2019-03-18  Pedro Alves  <palves@redhat.com>
145             Eli Zaretskii <eliz@gnu.org>
146
147         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
148         m_line and m_start_of_line.
149
150 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
151
152         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
153         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
154         it returns a newline.  This fixes a regression in TU mode, whereby
155         the next line is output on the same screen line as the user input.
156
157 2019-03-18  Pedro Alves  <palves@redhat.com>
158
159         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
160         New globals.
161         (apply_style): New, factored out from ...
162         (apply_ansi_escape): ... this.  Handle reverse video mode.
163         (tui_set_reverse_mode): New function.
164         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
165         * tui/tui-winsource.c (tui_show_source_line): Use
166         tui_set_reverse_mode instead of setting A_STANDOUT.
167         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
168         New setter methods.
169
170 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
171
172         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
173         Handle tabs.
174
175 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
176
177         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
178         tui_refill_source_window instead of tui_refresh_win, to update the
179         current execution line.  This fixes redisplay of the current line
180         when stepping through the code with "next" or "step".
181
182 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
183
184         * source-cache.c (source_cache::get_source_lines): Call
185         find_source_lines to initialize s->nlines.  This fixes vertical
186         scrolling of TUI source window when the DOWN arrow is pressed.
187
188 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
189
190         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
191         wclrtoeol in tui_show_source_line".  This reverts changes made in
192         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
193
194 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
195
196         * NEWS: Combine separate "New targets" sections for 8.3.
197
198 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
199
200         The MS-Windows port of ncurses fails to switch to a color pair if
201         one or both of the colors are the implicit default colors.  This
202         change records the default colors when TUI is initialized, and
203         then specifies them explicitly when a color pair uses the default
204         colors.  This allows color styling in TUI mode on MS-Windows.
205
206         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
207         ncurses_norm_attr.
208         (tui_initialize_io) [__MINGW32__]: Record the default terminal
209         colors in ncurses_norm_attr.
210         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
211         "none", replace it with the default color recorded in
212         ncurses_norm_attr.
213
214 2019-03-14  Tom Tromey  <tromey@adacore.com>
215
216         * source-cache.h (class source_cache) <get_source_lines>: Return
217         std::string.
218         * source-cache.c (source_cache::extract_lines): Handle case where
219         first_pos==npos.  Return std::string.
220         (source_cache::get_source_lines): Update.
221
222 2019-03-14  Tom Tromey  <tromey@adacore.com>
223
224         * NEWS: Add item for "style sources" commands.
225         * source-cache.c (source_cache::get_source_lines): Check
226         source_styling.
227         * cli/cli-style.c (source_styling): New global.
228         (_initialize_cli_style): Add "style sources" commands.
229         (show_style_sources): New function.
230         * cli/cli-style.h (source_styling): Declare.
231
232 2019-03-14  Pedro Alves  <palves@redhat.com>
233             Tom Tromey  <tromey@adacore.com>
234
235         * tui/tui-winsource.h (tui_refill_source_window): Declare.
236         * tui/tui-winsource.c (tui_refill_source_window): New function,
237         from...
238         (tui_horizontal_source_scroll): ... here.  Move some logic.
239         * cli/cli-style.c (set_style_enabled): Notify new observable.
240         * tui/tui-hooks.c (tui_redisplay_source): New function.
241         (tui_attach_detach_observers): Attach or detach
242         tui_redisplay_source.
243         * observable.h (source_styling_changed): New observable.
244         * observable.c: Define source_styling_changed observable.
245
246 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
247
248         PR/24325
249         * source-cache.c: #undef open and close, to avoid unresolved
250         externals during linking.
251
252 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
253
254         Support styling on native MS-Windows console
255
256         PR/24315
257         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
258         on MS-Windows if $TERM is not defined.
259
260         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
261
262         * posix-hdep.c (gdb_console_fputs):
263         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
264         functions.
265         * ui-file.h (gdb_console_fputs): Add prototype.
266
267         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
268         back to fputs only if the former returns zero.
269
270 2019-03-07  Brian Vandenberg  <phantall@gmail.com>
271             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
272
273         PR gdb/8527
274         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
275         set_sigint_trap, clear_sigint_trap.
276
277 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
278
279         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
280         for-loop range, to avoid compiler warnings.
281
282         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
283         avoid compiler warnings about unused variables.
284
285 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
286
287         * NEWS: Mention end of support for native debugging on MS-Windows
288         before XP.
289
290 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
291
292         PR gdb/24292
293         * common/netstuff.c:
294         * gdbserver/gdbreplay.c
295         * gdbserver/remote-utils.c:
296         * ser-tcp.c:
297         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
298         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
299         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
300         'getaddrinfo' and 'freeaddrinfo' were not available before
301         Windows XP, and mingw.org's MinGW headers by default define
302         _WIN32_WINNT to 0x500.
303
304 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
305     
306         * NEWS: Note minimum Python version.
307
308 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
309
310         * version.in: Set GDB version number to 8.2.90.DATE-git.
311
312 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
313
314         GDB 8.2.90 released.
315
316 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
317
318         * version.in: Set GDB version number to 8.2.90.
319
320 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
321
322         * NEWS: Change "Changes since GDB 8.2" into "Changes in GDB 8.3".
323
324 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
325
326         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
327         * version.in: Bump version to 8.2.90.DATE-git.
328
329 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
330
331         * aix-thread.c (ptid_cmp): Remove unused variable.
332         (get_signaled_thread): Likewise.
333         (store_regs_user_thread): Likewise.
334         (store_regs_kernel_thread): Likewise.
335         (fetch_regs_kernel_thread): Remove shadowed variable.
336
337 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
338
339         * features/riscv/32bit-cpu.xml: Add register numbers.
340         * features/riscv/32bit-fpu.c: Regenerate.
341         * features/riscv/32bit-fpu.xml: Add register numbers.
342         * features/riscv/64bit-cpu.xml: Add register numbers.
343         * features/riscv/64bit-fpu.c: Regenerate.
344         * features/riscv/64bit-fpu.xml: Add register numbers.
345
346 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
347
348         * NEWS: Mention two argument form of gdb.Value constructor.
349         * python/py-value.c (convert_buffer_and_type_to_value): New
350         function.
351         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
352         Add support for handling an optional second argument.  Call
353         convert_buffer_and_type_to_value as appropriate.
354         * python/python-internal.h (Py_buffer_deleter): New struct.
355         (Py_buffer_up): New typedef.
356
357 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
358
359         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
360         instead of releasing ownership.
361
362 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
363
364         * dwarf2read.c (open_and_init_dwp_file): Call
365         elf_numsections instead of bfd_count_sections to initialize
366         dwp_file->num_sections.
367
368 2019-02-25  Tom Tromey  <tromey@adacore.com>
369
370         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
371
372 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
373
374         * gcore.in: Add '--readnever' option when invoking GDB.
375
376 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
377
378         * MAINTAINERS: Update my email address.
379
380 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
381
382         * build-id.c (build_id_to_debug_bfd_1): New function.
383         (build_id_to_debug_bfd): Look for separate debug file in
384         sysroot.
385
386 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
387
388         * gdbarch.sh: Update the copyright year range that is placed into
389         generated files.
390
391 2019-02-22  Keith Seitz  <keiths@redhat.com>
392
393         PR symtab/23853
394         * linespec.c (create_sals_line_offset): Search for the default
395         symtab's filename instead of its fullname.
396
397 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
398
399         * NEWS: Update style defaults.
400
401 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
402
403         * main.c (captured_main_1): Disable styling in batch mode.
404
405 2019-02-20  Tom Tromey  <tom@tromey.com>
406
407         * symtab.c (symtab_symbol_info): Fix typos.
408
409 2019-02-20  Tom Tromey  <tromey@adacore.com>
410
411         * findcmd.c (_initialize_mem_search): Use upper case for
412         metasyntactic variables.
413
414 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
415
416         * aarch64-tdep.c (aarch64_add_reggroups): New function.
417         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
418
419 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
420
421         * top.h (source_file_name): Change to std::string.
422         * top.c (source_file_name): Likewise.
423         (command_line_input): Adjust.
424         * cli/cli-script.c (script_from_file): Adjust.
425
426 2019-02-19  Tom Tromey  <tromey@adacore.com>
427
428         * ravenscar-thread.c
429         (ravenscar_thread_target::update_thread_list): Don't call
430         ada_build_task_list.
431         * ada-lang.h (ada_build_task_list): Don't declare.
432         * ada-tasks.c (struct ada_tasks_inferior_data)
433         <task_list_valid_p>: Now bool.
434         (read_known_tasks, ada_task_list_changed)
435         (ada_tasks_invalidate_inferior_data): Update.
436         (read_known_tasks_array): Return bool.
437         (read_known_tasks_list): Likewise.
438         (read_known_tasks): Return void.
439         (ada_build_task_list): Now static.
440
441 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
442
443         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
444         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
445
446 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
447
448         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
449         variant for ada_tasks_pspace_data_handle and
450         ada_tasks_inferior_data_handle.
451         (ada_tasks_pspace_data_cleanup): New function.
452         (ada_tasks_inferior_data_cleanup): New function.
453
454 2019-02-17  Tom Tromey  <tom@tromey.com>
455
456         * macrotab.h (macro_source_fullname): Return a std::string.
457         * macrotab.c (macro_include, check_for_redefinition)
458         (macro_undef, macro_lookup_definition, foreach_macro)
459         (foreach_macro_in_scope): Update.
460         (macro_source_fullname): Return a std::string.
461         * macrocmd.c (show_pp_source_pos): Update.
462
463 2019-02-17  Tom Tromey  <tom@tromey.com>
464
465         * macrocmd.c (show_pp_source_pos): Style the file names.
466
467 2019-02-17  Tom Tromey  <tom@tromey.com>
468
469         PR tui/24197:
470         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
471
472 2019-02-17  Tom Tromey  <tom@tromey.com>
473
474         * ada-lang.c (user_select_syms): Use filtered printing.
475         * utils.c (wrap_style): New global.
476         (desired_style): Remove.
477         (emit_style_escape): Add stream parameter.
478         (set_output_style, reset_terminal_style, prompt_for_continue):
479         Update.
480         (flush_wrap_buffer): Only flush gdb_stdout.
481         (wrap_here): Set wrap_style.
482         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
483         treat escape sequences as a character.  Change when wrap buffer is
484         flushed.
485         (fputs_styled): Do not set the output style when the default is
486         requested.
487         * ui-style.h (struct ui_file_style) <is_default>: New method.
488         * source.c (print_source_lines_base): Emit escape sequences in one
489         piece.
490
491 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
492
493         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
494         integers and enumeration types.
495
496 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
497
498         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
499         instead of lookup_symbol_in_language
500         (do_exact_match): New function.
501         (ada_get_symbol_name_matcher): Return do_exact_match when
502         doing a verbatim match.
503
504 2019-02-15  Tom Tromey  <tromey@adacore.com>
505
506         * ravenscar-thread.c (ravenscar_thread_target::resume)
507         (ravenscar_thread_target::wait): Special case wildcard requests.
508
509 2019-02-15  Tom Tromey  <tromey@adacore.com>
510
511         * ravenscar-thread.c (base_ptid): Remove.
512         (struct ravenscar_thread_target) <close>: New method.
513         <m_base_ptid>: New member.
514         <update_inferior_ptid, active_task, task_is_currently_active,
515         runtime_initialized>: Declare methods.
516         <ravenscar_thread_target>: Add constructor.
517         (ravenscar_thread_target::task_is_currently_active)
518         (ravenscar_thread_target::update_inferior_ptid)
519         (ravenscar_runtime_initialized): Rename.  Now methods.
520         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
521         (ravenscar_thread_target::update_thread_list): Update.
522         (ravenscar_thread_target::active_task): Now method.
523         (ravenscar_thread_target::store_registers)
524         (ravenscar_thread_target::prepare_to_store)
525         (ravenscar_thread_target::prepare_to_store)
526         (ravenscar_thread_target::mourn_inferior): Update.
527         (ravenscar_inferior_created): Use "new" to create target.
528         (ravenscar_thread_target::get_ada_task_ptid): Update.
529         (_initialize_ravenscar): Don't initialize base_ptid.
530         (ravenscar_ops): Remove global.
531
532 2019-02-15  Tom Tromey  <tromey@adacore.com>
533
534         * target.h (push_target): Declare new overload.
535         * target.c (push_target): New overload, taking an rvalue reference.
536         * remote.c (remote_target::open_1): Use push_target overload.
537         * corelow.c (core_target_open): Use push_target overload.
538
539 2019-02-15  Tom Tromey  <tromey@adacore.com>
540
541         * ravenscar-thread.c (is_ravenscar_task)
542         (ravenscar_task_is_currently_active): Return bool.
543         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
544         (_initialize_ravenscar): Remove "(void)".
545         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
546         Return bool.
547
548 2019-02-15  Tom Tromey  <tromey@adacore.com>
549
550         * ravenscar-thread.c (ravenscar_runtime_initializer)
551         (has_ravenscar_runtime, get_running_thread_id)
552         (ravenscar_thread_target::resume): Fix indentation.
553
554 2019-02-15  Tom Tromey  <tromey@adacore.com>
555
556         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
557         from ravenscar_arch_ops.
558         (sparc_ravenscar_ops::fetch_registers)
559         (sparc_ravenscar_ops::store_registers): Now methods.
560         (sparc_ravenscar_prepare_to_store): Remove.
561         (sparc_ravenscar_ops): Redefine.
562         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
563         methods and destructor.  Remove members.
564         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
565         (ravenscar_thread_target::store_registers)
566         (ravenscar_thread_target::prepare_to_store): Update.
567         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
568         Remove.
569         (struct ppc_ravenscar_powerpc_ops): Derive from
570         ravenscar_arch_ops.
571         (ppc_ravenscar_powerpc_ops::fetch_registers)
572         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
573         (ppc_ravenscar_powerpc_ops): Redefine.
574         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
575         (ppc_ravenscar_e500_ops::fetch_registers)
576         (ppc_ravenscar_e500_ops::store_registers): Now methods.
577         (ppc_ravenscar_e500_ops): Redefine.
578         * aarch64-ravenscar-thread.c
579         (aarch64_ravenscar_generic_prepare_to_store): Remove.
580         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
581         (aarch64_ravenscar_fetch_registers)
582         (aarch64_ravenscar_store_registers): Now methods.
583         (aarch64_ravenscar_ops): Redefine.
584
585 2019-02-15  Tom Tromey  <tromey@adacore.com>
586
587         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
588         (ravenscar_thread_target::stopped_by_hw_breakpoint)
589         (ravenscar_thread_target::stopped_by_watchpoint)
590         (ravenscar_thread_target::stopped_data_address)
591         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
592
593 2019-02-15  Tom Tromey  <tromey@adacore.com>
594
595         * ravenscar-thread.c: Fix some typos.
596
597 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
598             Tom Tromey  <tromey@adacore.com>
599
600         * ada-lang.c (ada_exception_sal): Change addr_string to a
601         std::string.
602         (create_ada_exception_catchpoint): Update.
603
604 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
605             Tom Tromey  <tromey@adacore.com>
606
607         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
608         (bp_location_ops): Remove.
609         (base_breakpoint_allocate_location): Update.
610         (free_bp_location): Update.
611         * ada-lang.c (class ada_catchpoint_location)
612         <ada_catchpoint_location>: Remove ops parameter.
613         (ada_catchpoint_location_dtor): Remove.
614         (ada_catchpoint_location_ops): Remove.
615         (allocate_location_exception): Update.
616         * breakpoint.h (struct bp_location_ops): Remove.
617         (class bp_location) <bp_location>: Remove bp_location_ops
618         parameter.
619         <~bp_location>: Add destructor.
620         <ops>: Remove.
621
622 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
623             Pedro Alves  <palves@redhat.com>
624
625         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
626         'PATH_MAX'.
627
628 2019-02-14  David Michael  <fedora.dm0@gmail.com>
629             Samuel Thibault  <samuel.thibault@gnu.org>
630             Thomas Schwinge  <thomas@codesourcery.com>
631
632         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
633         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
634
635 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
636
637         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
638         (check_empty): Use "const char *".
639
640         * gnu-nat.c (gnu_nat_target::detach): Instead of
641         'detach_inferior (pid)' call
642         'detach_inferior (find_inferior_pid (pid))'.
643
644         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
645         'nat/fork-inferior.o'.
646         * gnu-nat.c: #include "nat/fork-inferior.h".
647
648         * gnu-nat.c (gnu_nat_target::detach): Instead of
649         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
650         * gnu-nat.h: #include "inf-child.h".
651         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
652         'i386_gnu_nat_target::fetch_registers'.
653         (gnu_store_registers): Rename/move to
654         'i386_gnu_nat_target::store_registers'.
655
656         * config/i386/nm-i386gnu.h: Don't "#include" any files.
657         * gnu-nat.h (mach_thread_info): New function.
658         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
659
660         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
661
662 2019-02-14  Frederic Konrad  <konrad@adacore.com>
663
664         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
665
666 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
667
668         * windows-nat.c (windows_add_thread): Add new parameter
669         "main_thread_p" with default value set to false.  Update
670         function documentation as well as all callers.
671         (windows_delete_thread): Likewise.
672         (fake_create_process): Update call to windows_add_thread.
673         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
674         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
675         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
676         call to windows_delete_thread.
677
678 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
679
680         * MAINTAINERS: Add Andrew Burgess as global maintainer.
681
682 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
683
684         * symfile.c (find_separate_debug_file): Use canonical path of
685         sysroot with child_path instead of gdb_sysroot if it is valid.
686
687 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
688
689         * symfile.c (find_separate_debug_file): Use child_path to
690         determine if an object file is under a sysroot.
691
692 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
693
694         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
695         unittests/child-path-selftests.c.
696         * common/pathstuff.c (child_path): New function.
697         * common/pathstuff.h (child_path): New prototype.
698         * unittests/child-path-selftests.c: New file.
699
700 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
701
702         * symfile.c (find_separate_debug_file): Look for separate debug
703         files in debug directories under the sysroot.
704
705 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
706
707         * symtab.h (struct minimal_symbol data_p): New const method.
708         (struct minimal_symbol text_p): Likewise.
709         * symtab.c (output_source_filename): Use file name style
710         to print file name.
711         (print_symbol_info): Likewise.
712         (print_msymbol_info): Use address style to print addresses.
713         Use function name style to print executable text symbols.
714         (expand_symtab_containing_pc): Use data_p.
715         (find_pc_sect_compunit_symtab): Likewise.
716
717 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
718
719         * breakpoint.c (describe_other_breakpoints): Use address style
720         to print addresses.
721         (say_where): Likewise.
722
723 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
724
725         * ada-typeprint.c (print_func_type): Print function name
726         style to print function name.
727         * c-typeprint.c (c_print_type_1): Likewise.
728
729 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
730
731         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
732         for execve.
733
734 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
735
736         * c-exp.y (direct_abs_decl): Use emplace_back to record the
737         type_stack.
738
739 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
740
741         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
742         TYPE_CODE_REF types.
743
744 2019-02-08  Jim Wilson  <jimw@sifive.com>
745
746         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
747         (riscv_linux_fregset): New.
748         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
749
750 2019-02-07  Tom Tromey  <tom@tromey.com>
751
752         * thread.c (thread_cancel_execution_command): Update.
753         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
754         methods.
755         (struct thread_fsm_ops): Remove.
756         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
757         (thread_fsm_should_stop, thread_fsm_return_value)
758         (thread_fsm_set_finished, thread_fsm_finished_p)
759         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
760         Don't declare.
761         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
762         * infrun.c (clear_proceed_status_thread)
763         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
764         (print_stop_event): Update.
765         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
766         Add constructor.
767         (step_command_fsm_ops): Remove.
768         (new_step_command_fsm): Remove.
769         (step_1): Update.
770         (step_command_fsm::should_stop): Rename from
771         step_command_fsm_should_stop.
772         (step_command_fsm::clean_up): Rename from
773         step_command_fsm_clean_up.
774         (step_command_fsm::do_async_reply_reason): Rename from
775         step_command_fsm_async_reply_reason.
776         (struct until_next_fsm): Inherit from thread_fsm.  Add
777         constructor.
778         (until_next_fsm_ops): Remove.
779         (new_until_next_fsm): Remove.
780         (until_next_fsm::should_stop): Rename from
781         until_next_fsm_should_stop.
782         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
783         (until_next_fsm::do_async_reply_reason): Rename from
784         until_next_fsm_async_reply_reason.
785         (struct finish_command_fsm): Inherit from thread_fsm.  Add
786         constructor.  Change type of breakpoint.
787         (finish_command_fsm_ops): Remove.
788         (new_finish_command_fsm): Remove.
789         (finish_command_fsm::should_stop): Rename from
790         finish_command_fsm_should_stop.
791         (finish_command_fsm::clean_up): Rename from
792         finish_command_fsm_clean_up.
793         (finish_command_fsm::return_value): Rename from
794         finish_command_fsm_return_value.
795         (finish_command_fsm::do_async_reply_reason): Rename from
796         finish_command_fsm_async_reply_reason.
797         (finish_command): Update.
798         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
799         Add constructor.
800         (call_thread_fsm_ops): Remove.
801         (call_thread_fsm::call_thread_fsm): Rename from
802         new_call_thread_fsm.
803         (call_thread_fsm::should_stop): Rename from
804         call_thread_fsm_should_stop.
805         (call_thread_fsm::should_notify_stop): Rename from
806         call_thread_fsm_should_notify_stop.
807         (run_inferior_call, call_function_by_hand_dummy): Update.
808         * cli/cli-interp.c (should_print_stop_to_console): Update.
809         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
810         Add constructor.  Change type of location_breakpoint,
811         caller_breakpoint.
812         (until_break_fsm_ops): Remove.
813         (new_until_break_fsm): Remove.
814         (until_break_fsm::should_stop): Rename from
815         until_break_fsm_should_stop.
816         (until_break_fsm::clean_up): Rename from
817         until_break_fsm_clean_up.
818         (until_break_fsm::do_async_reply_reason): Rename from
819         until_break_fsm_async_reply_reason.
820         (until_break_command): Update.
821         * thread-fsm.c: Remove.
822         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
823
824 2019-02-07  Tom Tromey  <tom@tromey.com>
825
826         * yy-remap.h: Add include guard.
827         * xtensa-tdep.h: Add include guard.
828         * xcoffread.h: Rename include guard.
829         * varobj-iter.h: Add include guard.
830         * tui/tui.h: Rename include guard.
831         * tui/tui-winsource.h: Rename include guard.
832         * tui/tui-wingeneral.h: Rename include guard.
833         * tui/tui-windata.h: Rename include guard.
834         * tui/tui-win.h: Rename include guard.
835         * tui/tui-stack.h: Rename include guard.
836         * tui/tui-source.h: Rename include guard.
837         * tui/tui-regs.h: Rename include guard.
838         * tui/tui-out.h: Rename include guard.
839         * tui/tui-layout.h: Rename include guard.
840         * tui/tui-io.h: Rename include guard.
841         * tui/tui-hooks.h: Rename include guard.
842         * tui/tui-file.h: Rename include guard.
843         * tui/tui-disasm.h: Rename include guard.
844         * tui/tui-data.h: Rename include guard.
845         * tui/tui-command.h: Rename include guard.
846         * tic6x-tdep.h: Add include guard.
847         * target/waitstatus.h: Rename include guard.
848         * target/wait.h: Rename include guard.
849         * target/target.h: Rename include guard.
850         * target/resume.h: Rename include guard.
851         * target-float.h: Rename include guard.
852         * stabsread.h: Add include guard.
853         * rs6000-tdep.h: Add include guard.
854         * riscv-fbsd-tdep.h: Add include guard.
855         * regformats/regdef.h: Rename include guard.
856         * record.h: Rename include guard.
857         * python/python.h: Rename include guard.
858         * python/python-internal.h: Rename include guard.
859         * python/py-stopevent.h: Rename include guard.
860         * python/py-ref.h: Rename include guard.
861         * python/py-record.h: Rename include guard.
862         * python/py-record-full.h: Rename include guard.
863         * python/py-record-btrace.h: Rename include guard.
864         * python/py-instruction.h: Rename include guard.
865         * python/py-events.h: Rename include guard.
866         * python/py-event.h: Rename include guard.
867         * procfs.h: Add include guard.
868         * proc-utils.h: Add include guard.
869         * p-lang.h: Add include guard.
870         * or1k-tdep.h: Rename include guard.
871         * observable.h: Rename include guard.
872         * nto-tdep.h: Rename include guard.
873         * nat/x86-linux.h: Rename include guard.
874         * nat/x86-linux-dregs.h: Rename include guard.
875         * nat/x86-gcc-cpuid.h: Add include guard.
876         * nat/x86-dregs.h: Rename include guard.
877         * nat/x86-cpuid.h: Rename include guard.
878         * nat/ppc-linux.h: Rename include guard.
879         * nat/mips-linux-watch.h: Rename include guard.
880         * nat/linux-waitpid.h: Rename include guard.
881         * nat/linux-ptrace.h: Rename include guard.
882         * nat/linux-procfs.h: Rename include guard.
883         * nat/linux-osdata.h: Rename include guard.
884         * nat/linux-nat.h: Rename include guard.
885         * nat/linux-namespaces.h: Rename include guard.
886         * nat/linux-btrace.h: Rename include guard.
887         * nat/glibc_thread_db.h: Rename include guard.
888         * nat/gdb_thread_db.h: Rename include guard.
889         * nat/gdb_ptrace.h: Rename include guard.
890         * nat/fork-inferior.h: Rename include guard.
891         * nat/amd64-linux-siginfo.h: Rename include guard.
892         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
893         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
894         * nat/aarch64-linux.h: Rename include guard.
895         * nat/aarch64-linux-hw-point.h: Rename include guard.
896         * mn10300-tdep.h: Add include guard.
897         * mips-linux-tdep.h: Add include guard.
898         * mi/mi-parse.h: Rename include guard.
899         * mi/mi-out.h: Rename include guard.
900         * mi/mi-main.h: Rename include guard.
901         * mi/mi-interp.h: Rename include guard.
902         * mi/mi-getopt.h: Rename include guard.
903         * mi/mi-console.h: Rename include guard.
904         * mi/mi-common.h: Rename include guard.
905         * mi/mi-cmds.h: Rename include guard.
906         * mi/mi-cmd-break.h: Rename include guard.
907         * m2-lang.h: Add include guard.
908         * location.h: Rename include guard.
909         * linux-record.h: Rename include guard.
910         * linux-nat.h: Add include guard.
911         * linux-fork.h: Add include guard.
912         * i386-darwin-tdep.h: Rename include guard.
913         * hppa-linux-offsets.h: Add include guard.
914         * guile/guile.h: Rename include guard.
915         * guile/guile-internal.h: Rename include guard.
916         * gnu-nat.h: Rename include guard.
917         * gdb-stabs.h: Rename include guard.
918         * frv-tdep.h: Add include guard.
919         * f-lang.h: Add include guard.
920         * event-loop.h: Add include guard.
921         * darwin-nat.h: Rename include guard.
922         * cp-abi.h: Rename include guard.
923         * config/sparc/nm-sol2.h: Rename include guard.
924         * config/nm-nto.h: Rename include guard.
925         * config/nm-linux.h: Add include guard.
926         * config/i386/nm-i386gnu.h: Rename include guard.
927         * config/djgpp/nl_types.h: Rename include guard.
928         * config/djgpp/langinfo.h: Rename include guard.
929         * compile/gcc-cp-plugin.h: Add include guard.
930         * compile/gcc-c-plugin.h: Add include guard.
931         * compile/compile.h: Rename include guard.
932         * compile/compile-object-run.h: Rename include guard.
933         * compile/compile-object-load.h: Rename include guard.
934         * compile/compile-internal.h: Rename include guard.
935         * compile/compile-cplus.h: Rename include guard.
936         * compile/compile-c.h: Rename include guard.
937         * common/xml-utils.h: Rename include guard.
938         * common/x86-xstate.h: Rename include guard.
939         * common/version.h: Rename include guard.
940         * common/vec.h: Rename include guard.
941         * common/tdesc.h: Rename include guard.
942         * common/selftest.h: Rename include guard.
943         * common/scoped_restore.h: Rename include guard.
944         * common/scoped_mmap.h: Rename include guard.
945         * common/scoped_fd.h: Rename include guard.
946         * common/safe-iterator.h: Rename include guard.
947         * common/run-time-clock.h: Rename include guard.
948         * common/refcounted-object.h: Rename include guard.
949         * common/queue.h: Rename include guard.
950         * common/ptid.h: Rename include guard.
951         * common/print-utils.h: Rename include guard.
952         * common/preprocessor.h: Rename include guard.
953         * common/pathstuff.h: Rename include guard.
954         * common/observable.h: Rename include guard.
955         * common/netstuff.h: Rename include guard.
956         * common/job-control.h: Rename include guard.
957         * common/host-defs.h: Rename include guard.
958         * common/gdb_wait.h: Rename include guard.
959         * common/gdb_vecs.h: Rename include guard.
960         * common/gdb_unlinker.h: Rename include guard.
961         * common/gdb_unique_ptr.h: Rename include guard.
962         * common/gdb_tilde_expand.h: Rename include guard.
963         * common/gdb_sys_time.h: Rename include guard.
964         * common/gdb_string_view.h: Rename include guard.
965         * common/gdb_splay_tree.h: Rename include guard.
966         * common/gdb_setjmp.h: Rename include guard.
967         * common/gdb_ref_ptr.h: Rename include guard.
968         * common/gdb_optional.h: Rename include guard.
969         * common/gdb_locale.h: Rename include guard.
970         * common/gdb_assert.h: Rename include guard.
971         * common/filtered-iterator.h: Rename include guard.
972         * common/filestuff.h: Rename include guard.
973         * common/fileio.h: Rename include guard.
974         * common/environ.h: Rename include guard.
975         * common/common-utils.h: Rename include guard.
976         * common/common-types.h: Rename include guard.
977         * common/common-regcache.h: Rename include guard.
978         * common/common-inferior.h: Rename include guard.
979         * common/common-gdbthread.h: Rename include guard.
980         * common/common-exceptions.h: Rename include guard.
981         * common/common-defs.h: Rename include guard.
982         * common/common-debug.h: Rename include guard.
983         * common/cleanups.h: Rename include guard.
984         * common/buffer.h: Rename include guard.
985         * common/btrace-common.h: Rename include guard.
986         * common/break-common.h: Rename include guard.
987         * cli/cli-utils.h: Rename include guard.
988         * cli/cli-style.h: Rename include guard.
989         * cli/cli-setshow.h: Rename include guard.
990         * cli/cli-script.h: Rename include guard.
991         * cli/cli-interp.h: Rename include guard.
992         * cli/cli-decode.h: Rename include guard.
993         * cli/cli-cmds.h: Rename include guard.
994         * charset-list.h: Add include guard.
995         * buildsym-legacy.h: Rename include guard.
996         * bfin-tdep.h: Add include guard.
997         * ax.h: Rename include guard.
998         * arm-linux-tdep.h: Add include guard.
999         * arm-fbsd-tdep.h: Add include guard.
1000         * arch/xtensa.h: Rename include guard.
1001         * arch/tic6x.h: Add include guard.
1002         * arch/i386.h: Add include guard.
1003         * arch/arm.h: Rename include guard.
1004         * arch/arm-linux.h: Rename include guard.
1005         * arch/arm-get-next-pcs.h: Rename include guard.
1006         * arch/amd64.h: Add include guard.
1007         * arch/aarch64-insn.h: Rename include guard.
1008         * arch-utils.h: Rename include guard.
1009         * annotate.h: Add include guard.
1010         * amd64-darwin-tdep.h: Rename include guard.
1011         * aarch64-linux-tdep.h: Add include guard.
1012         * aarch64-fbsd-tdep.h: Add include guard.
1013         * aarch32-linux-nat.h: Add include guard.
1014
1015 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1016
1017         * macrotab.c (macro_define_internal): New function that
1018         factorizes macro_define_object_internal and macro_define_function
1019         code.
1020         (macro_define_object_internal): Use macro_define_internal.
1021         (macro_define_function): Likewise.
1022
1023 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1024
1025         * macrocmd.c (extract_identifier): Return
1026         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
1027         callers.
1028
1029 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1030
1031         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1032
1033 2019-02-05  Tom Tromey  <tom@tromey.com>
1034
1035         * target.c (target_stack::unpush): Move assertion earlier.
1036
1037 2019-01-30  Tom Tromey  <tom@tromey.com>
1038
1039         PR python/23615:
1040         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1041         (gdbpy_parse_and_eval): Likewise.
1042         * python/python-internal.h (gdbpy_allow_threads): New class.
1043
1044 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1045
1046         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1047         (aarch64_fbsd_fpregmap): Move earlier.
1048         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1049         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1050         instead of individual calls to trad_frame_set_reg_addr.
1051         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1052         earlier.
1053         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1054         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1055         instead of individual calls to trad_frame_set_reg_addr.
1056
1057 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1058
1059         * CONTRIBUTE: Replace contribution list with wiki link.
1060
1061 2019-01-25  Tom Tromey  <tom@tromey.com>
1062
1063         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1064
1065 2019-01-25  Tom Tromey  <tom@tromey.com>
1066
1067         * xtensa-linux-nat.c: Fix common/ includes.
1068         * xml-support.h: Fix common/ includes.
1069         * xml-support.c: Fix common/ includes.
1070         * x86-linux-nat.c: Fix common/ includes.
1071         * windows-nat.c: Fix common/ includes.
1072         * varobj.h: Fix common/ includes.
1073         * varobj.c: Fix common/ includes.
1074         * value.c: Fix common/ includes.
1075         * valops.c: Fix common/ includes.
1076         * utils.c: Fix common/ includes.
1077         * unittests/xml-utils-selftests.c: Fix common/ includes.
1078         * unittests/utils-selftests.c: Fix common/ includes.
1079         * unittests/unpack-selftests.c: Fix common/ includes.
1080         * unittests/tracepoint-selftests.c: Fix common/ includes.
1081         * unittests/style-selftests.c: Fix common/ includes.
1082         * unittests/string_view-selftests.c: Fix common/ includes.
1083         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1084         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1085         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1086         * unittests/rsp-low-selftests.c: Fix common/ includes.
1087         * unittests/parse-connection-spec-selftests.c: Fix common/
1088         includes.
1089         * unittests/optional-selftests.c: Fix common/ includes.
1090         * unittests/offset-type-selftests.c: Fix common/ includes.
1091         * unittests/observable-selftests.c: Fix common/ includes.
1092         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1093         * unittests/memrange-selftests.c: Fix common/ includes.
1094         * unittests/memory-map-selftests.c: Fix common/ includes.
1095         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1096         * unittests/function-view-selftests.c: Fix common/ includes.
1097         * unittests/environ-selftests.c: Fix common/ includes.
1098         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1099         * unittests/common-utils-selftests.c: Fix common/ includes.
1100         * unittests/cli-utils-selftests.c: Fix common/ includes.
1101         * unittests/array-view-selftests.c: Fix common/ includes.
1102         * ui-file.c: Fix common/ includes.
1103         * tui/tui-io.c: Fix common/ includes.
1104         * tracepoint.h: Fix common/ includes.
1105         * tracepoint.c: Fix common/ includes.
1106         * tracefile-tfile.c: Fix common/ includes.
1107         * top.h: Fix common/ includes.
1108         * top.c: Fix common/ includes.
1109         * thread.c: Fix common/ includes.
1110         * target/waitstatus.h: Fix common/ includes.
1111         * target/waitstatus.c: Fix common/ includes.
1112         * target.h: Fix common/ includes.
1113         * target.c: Fix common/ includes.
1114         * target-memory.c: Fix common/ includes.
1115         * target-descriptions.c: Fix common/ includes.
1116         * symtab.h: Fix common/ includes.
1117         * symfile.c: Fix common/ includes.
1118         * stap-probe.c: Fix common/ includes.
1119         * spu-linux-nat.c: Fix common/ includes.
1120         * sparc-nat.c: Fix common/ includes.
1121         * source.c: Fix common/ includes.
1122         * solib.c: Fix common/ includes.
1123         * solib-target.c: Fix common/ includes.
1124         * ser-unix.c: Fix common/ includes.
1125         * ser-tcp.c: Fix common/ includes.
1126         * ser-pipe.c: Fix common/ includes.
1127         * ser-base.c: Fix common/ includes.
1128         * selftest-arch.c: Fix common/ includes.
1129         * s12z-tdep.c: Fix common/ includes.
1130         * rust-exp.y: Fix common/ includes.
1131         * rs6000-aix-tdep.c: Fix common/ includes.
1132         * riscv-tdep.c: Fix common/ includes.
1133         * remote.c: Fix common/ includes.
1134         * remote-notif.h: Fix common/ includes.
1135         * remote-fileio.h: Fix common/ includes.
1136         * remote-fileio.c: Fix common/ includes.
1137         * regcache.h: Fix common/ includes.
1138         * regcache.c: Fix common/ includes.
1139         * record-btrace.c: Fix common/ includes.
1140         * python/python.c: Fix common/ includes.
1141         * python/py-type.c: Fix common/ includes.
1142         * python/py-inferior.c: Fix common/ includes.
1143         * progspace.h: Fix common/ includes.
1144         * producer.c: Fix common/ includes.
1145         * procfs.c: Fix common/ includes.
1146         * proc-api.c: Fix common/ includes.
1147         * printcmd.c: Fix common/ includes.
1148         * ppc-linux-nat.c: Fix common/ includes.
1149         * parser-defs.h: Fix common/ includes.
1150         * osdata.c: Fix common/ includes.
1151         * obsd-nat.c: Fix common/ includes.
1152         * nat/x86-linux.c: Fix common/ includes.
1153         * nat/x86-linux-dregs.c: Fix common/ includes.
1154         * nat/x86-dregs.h: Fix common/ includes.
1155         * nat/x86-dregs.c: Fix common/ includes.
1156         * nat/ppc-linux.c: Fix common/ includes.
1157         * nat/mips-linux-watch.h: Fix common/ includes.
1158         * nat/mips-linux-watch.c: Fix common/ includes.
1159         * nat/linux-waitpid.c: Fix common/ includes.
1160         * nat/linux-ptrace.h: Fix common/ includes.
1161         * nat/linux-ptrace.c: Fix common/ includes.
1162         * nat/linux-procfs.c: Fix common/ includes.
1163         * nat/linux-personality.c: Fix common/ includes.
1164         * nat/linux-osdata.c: Fix common/ includes.
1165         * nat/linux-namespaces.c: Fix common/ includes.
1166         * nat/linux-btrace.h: Fix common/ includes.
1167         * nat/linux-btrace.c: Fix common/ includes.
1168         * nat/fork-inferior.c: Fix common/ includes.
1169         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1170         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1171         * nat/aarch64-linux.c: Fix common/ includes.
1172         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1173         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1174         * namespace.h: Fix common/ includes.
1175         * mips-linux-tdep.c: Fix common/ includes.
1176         * minsyms.c: Fix common/ includes.
1177         * mi/mi-parse.h: Fix common/ includes.
1178         * mi/mi-main.c: Fix common/ includes.
1179         * mi/mi-cmd-env.c: Fix common/ includes.
1180         * memrange.h: Fix common/ includes.
1181         * memattr.c: Fix common/ includes.
1182         * maint.h: Fix common/ includes.
1183         * maint.c: Fix common/ includes.
1184         * main.c: Fix common/ includes.
1185         * machoread.c: Fix common/ includes.
1186         * location.c: Fix common/ includes.
1187         * linux-thread-db.c: Fix common/ includes.
1188         * linux-nat.c: Fix common/ includes.
1189         * linux-fork.c: Fix common/ includes.
1190         * inline-frame.c: Fix common/ includes.
1191         * infrun.c: Fix common/ includes.
1192         * inflow.c: Fix common/ includes.
1193         * inferior.h: Fix common/ includes.
1194         * inferior.c: Fix common/ includes.
1195         * infcmd.c: Fix common/ includes.
1196         * inf-ptrace.c: Fix common/ includes.
1197         * inf-child.c: Fix common/ includes.
1198         * ia64-linux-nat.c: Fix common/ includes.
1199         * i387-tdep.c: Fix common/ includes.
1200         * i386-tdep.c: Fix common/ includes.
1201         * i386-linux-tdep.c: Fix common/ includes.
1202         * i386-linux-nat.c: Fix common/ includes.
1203         * i386-go32-tdep.c: Fix common/ includes.
1204         * i386-fbsd-tdep.c: Fix common/ includes.
1205         * i386-fbsd-nat.c: Fix common/ includes.
1206         * guile/scm-type.c: Fix common/ includes.
1207         * guile/guile.c: Fix common/ includes.
1208         * go32-nat.c: Fix common/ includes.
1209         * gnu-nat.c: Fix common/ includes.
1210         * gdbthread.h: Fix common/ includes.
1211         * gdbarch-selftests.c: Fix common/ includes.
1212         * gdb_usleep.c: Fix common/ includes.
1213         * gdb_select.h: Fix common/ includes.
1214         * gdb_bfd.c: Fix common/ includes.
1215         * gcore.c: Fix common/ includes.
1216         * fork-child.c: Fix common/ includes.
1217         * findvar.c: Fix common/ includes.
1218         * fbsd-nat.c: Fix common/ includes.
1219         * event-top.c: Fix common/ includes.
1220         * event-loop.c: Fix common/ includes.
1221         * dwarf2read.c: Fix common/ includes.
1222         * dwarf2loc.c: Fix common/ includes.
1223         * dwarf2-frame.c: Fix common/ includes.
1224         * dwarf-index-cache.c: Fix common/ includes.
1225         * dtrace-probe.c: Fix common/ includes.
1226         * disasm-selftests.c: Fix common/ includes.
1227         * defs.h: Fix common/ includes.
1228         * csky-tdep.c: Fix common/ includes.
1229         * cp-valprint.c: Fix common/ includes.
1230         * cp-support.h: Fix common/ includes.
1231         * cp-support.c: Fix common/ includes.
1232         * corelow.c: Fix common/ includes.
1233         * completer.h: Fix common/ includes.
1234         * completer.c: Fix common/ includes.
1235         * compile/compile.c: Fix common/ includes.
1236         * compile/compile-loc2c.c: Fix common/ includes.
1237         * compile/compile-cplus-types.c: Fix common/ includes.
1238         * compile/compile-cplus-symbols.c: Fix common/ includes.
1239         * command.h: Fix common/ includes.
1240         * cli/cli-dump.c: Fix common/ includes.
1241         * cli/cli-cmds.c: Fix common/ includes.
1242         * charset.c: Fix common/ includes.
1243         * build-id.c: Fix common/ includes.
1244         * btrace.h: Fix common/ includes.
1245         * btrace.c: Fix common/ includes.
1246         * breakpoint.h: Fix common/ includes.
1247         * breakpoint.c: Fix common/ includes.
1248         * ax.h: 
1249         (enum agent_op): Fix common/ includes.
1250         * ax-general.c (struct aop_map): Fix common/ includes.
1251         * ax-gdb.c: Fix common/ includes.
1252         * auxv.c: Fix common/ includes.
1253         * auto-load.c: Fix common/ includes.
1254         * arm-tdep.c: Fix common/ includes.
1255         * arch/riscv.c: Fix common/ includes.
1256         * arch/ppc-linux-common.c: Fix common/ includes.
1257         * arch/i386.c: Fix common/ includes.
1258         * arch/arm.c: Fix common/ includes.
1259         * arch/arm-linux.c: Fix common/ includes.
1260         * arch/arm-get-next-pcs.c: Fix common/ includes.
1261         * arch/amd64.c: Fix common/ includes.
1262         * arch/aarch64.c: Fix common/ includes.
1263         * arch/aarch64-insn.c: Fix common/ includes.
1264         * arch-utils.c: Fix common/ includes.
1265         * amd64-windows-tdep.c: Fix common/ includes.
1266         * amd64-tdep.c: Fix common/ includes.
1267         * amd64-sol2-tdep.c: Fix common/ includes.
1268         * amd64-obsd-tdep.c: Fix common/ includes.
1269         * amd64-nbsd-tdep.c: Fix common/ includes.
1270         * amd64-linux-tdep.c: Fix common/ includes.
1271         * amd64-linux-nat.c: Fix common/ includes.
1272         * amd64-fbsd-tdep.c: Fix common/ includes.
1273         * amd64-fbsd-nat.c: Fix common/ includes.
1274         * amd64-dicos-tdep.c: Fix common/ includes.
1275         * amd64-darwin-tdep.c: Fix common/ includes.
1276         * agent.c: Fix common/ includes.
1277         * ada-lang.h: Fix common/ includes.
1278         * ada-lang.c: Fix common/ includes.
1279         * aarch64-tdep.c: Fix common/ includes.
1280
1281 2019-01-25  Tom Tromey  <tom@tromey.com>
1282
1283         * common/create-version.sh: Use common/version.h.
1284
1285 2019-01-24  Pedro Alves  <palves@redhat.com>
1286
1287         * infrun.c (signal_stop, signal_print, signal_program)
1288         (signal_catch, signal_pass): Now arrays instead of pointers.
1289         (update_signals_program_target, do_target_resume)
1290         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1291         * linux-nat.c (linux_nat_target::pass_signals)
1292         (linux_nat_target::create_inferior, linux_nat_target::attach):
1293         Adjust.
1294         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1295         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1296         * procfs.c (procfs_target::pass_signals): Adjust.
1297         * record-full.c (record_full_target::resume): Adjust.
1298         * remote.c (remote_target::pass_signals)
1299         (remote_target::program_signals): Adjust.
1300         * target-debug.h (target_debug_print_signals): Now takes a
1301         gdb::array_view as parameter.  Adjust.
1302         * target.h (target_ops) <pass_signals, program_signals>: Replace
1303         pointer and length parameters with gdb::array_view.
1304         (target_pass_signals, target_program_signals): Likewise.
1305         * target-delegates.c: Regenerate.
1306
1307 2019-01-24  Pedro Alves  <palves@redhat.com>
1308
1309         * common/forward-scope-exit.h
1310         (forward_scope_exit::forward_scope_exit): Pass arguments to
1311         m_bind_function directly, instead of creating a std::bind and
1312         copying that.
1313
1314 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1315
1316         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1317         for static members.
1318         (pass_in_v_vfp_candidate): Likewise.
1319
1320 2019-01-23  Tom Tromey  <tom@tromey.com>
1321             Pedro Alves  <palves@redhat.com>
1322
1323         * regcache.c (class regcache_invalidator): Remove.
1324         (regcache::raw_write): Use make_scope_exit.
1325
1326 2019-01-23  Tom Tromey  <tom@tromey.com>
1327
1328         * ui-out.h (class ui_out_emit_type): Update comment.
1329
1330 2019-01-23  Tom Tromey  <tom@tromey.com>
1331
1332         * infrun.c (fetch_inferior_event): Update comment.
1333
1334 2019-01-23  Tom Tromey  <tom@tromey.com>
1335             Pedro Alves  <palves@redhat.com>
1336
1337         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1338         parameter.
1339         (fetch_inferior_event): Use SCOPE_EXIT.
1340
1341
1342 2019-01-23  Tom Tromey  <tom@tromey.com>
1343             Pedro Alves  <palves@redhat.com>
1344
1345         * infrun.c (disable_thread_events): Delete.
1346         (stop_all_threads): Use SCOPE_EXIT.
1347
1348 2019-01-23  Tom Tromey  <tom@tromey.com>
1349             Pedro Alves  <palves@redhat.com>
1350
1351         * symfile.c: Include forward-scope-exit.h.
1352         (clear_symtab_users_cleanup): Replace forward declaration with
1353         a FORWARD_SCOPE_EXIT.
1354         (syms_from_objfile_1): Use the forward_scope_exit and
1355         gdb::optional instead of cleanup_function.
1356         (reread_symbols): Use the forward_scope_exit instead of
1357         cleanup_function.
1358         (clear_symtab_users_cleanup): Remove function.
1359
1360 2019-01-23  Tom Tromey  <tom@tromey.com>
1361             Pedro Alves  <palves@redhat.com>
1362
1363         * linux-nat.c: Include scope-exit.h.
1364         (cleanup_target_stop): Remove.
1365         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1366         SCOPE_EXIT.
1367
1368 2019-01-23  Tom Tromey  <tom@tromey.com>
1369             Pedro Alves  <palves@redhat.com>
1370
1371         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1372         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1373
1374 2019-01-23  Tom Tromey  <tom@tromey.com>
1375             Andrew Burgess  <andrew.burgess@embecosm.com>
1376             Pedro Alves  <palves@redhat.com>
1377
1378         * infrun.c (fetch_inferior_event): Use scope_exit.
1379         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1380         * top.c (execute_command): Use scope_exit.
1381         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1382         * utils.c (do_bpstat_clear_actions_cleanup)
1383         (make_bpstat_clear_actions_cleanup): Remove.
1384
1385 2019-01-23  Tom Tromey  <tom@tromey.com>
1386             Pedro Alves  <palves@redhat.com>
1387
1388         * infrun.c: Include "common/scope-exit.h"
1389         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1390         (wait_for_inferior): Use SCOPE_EXIT.
1391         (fetch_inferior_event): Use scope_exit.
1392
1393 2019-01-23  Tom Tromey  <tom@tromey.com>
1394             Pedro Alves  <palves@redhat.com>
1395
1396         * breakpoint.c (create_breakpoint): Remove cleanup.
1397
1398 2019-01-23  Tom Tromey  <tom@tromey.com>
1399             Andrew Burgess  <andrew.burgess@embecosm.com>
1400             Pedro Alves  <palves@redhat.com>
1401
1402 2019-01-23  Pedro Alves  <palves@redhat.com>
1403
1404         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1405
1406 2019-01-23  Pedro Alves  <palves@redhat.com>
1407             Andrew Burgess  <andrew.burgess@embecosm.com>
1408
1409         * gdbthread.h: Include "common/forward-scope-exit.h".
1410         (scoped_finish_thread_state): Redefine custom class in terms of
1411         forward_scope_exit.
1412
1413 2019-01-23  Pedro Alves  <palves@redhat.com>
1414             Andrew Burgess  <andrew.burgess@embecosm.com>
1415
1416         * common/forward-scope-exit.h: New file.
1417
1418 2019-01-23  Pedro Alves  <palves@redhat.com>
1419             Andrew Burgess  <andrew.burgess@embecosm.com>
1420             Tom Tromey  <tom@tromey.com>
1421
1422         * common/scope-exit.h: New file.
1423
1424 2019-01-23  Pedro Alves  <palves@redhat.com>
1425
1426         * common/preprocessor.h (ESC): Rename to ...
1427         (ESC_PARENS): ... this.
1428         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1429         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1430
1431 2019-01-23  Tom Tromey  <tom@tromey.com>
1432
1433         * language.h (class scoped_switch_to_sym_language_if_auto):
1434         Initialize m_lang in both cases.
1435
1436 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1437
1438         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1439         with XCNEW.
1440
1441 2019-01-22  Tom Tromey  <tom@tromey.com>
1442
1443         * corelow.c: Do not include sys/file.h.
1444
1445 2019-01-22  Tom Tromey  <tom@tromey.com>
1446
1447         * tui/tui-wingeneral.h: Include gdb_curses.h.
1448
1449 2019-01-22  Tom Tromey  <tom@tromey.com>
1450
1451         * source-cache.h (class source_cache) <get_source_lines,
1452         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1453
1454 2019-01-22  Tom Tromey  <tom@tromey.com>
1455
1456         * remote-fileio.h (struct remote_target): Declare.
1457
1458 2019-01-22  Tom Tromey  <tom@tromey.com>
1459
1460         * python/py-arch.c: Do not include py-ref.h.
1461         * python/py-bpevent.c: Do not include py-ref.h.
1462         * python/py-cmd.c: Do not include py-ref.h.
1463         * python/py-continueevent.c: Do not include py-ref.h.
1464         * python/py-event.h: Do not include py-ref.h.
1465         * python/py-evtregistry.c: Do not include py-ref.h.
1466         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1467         * python/py-frame.c: Do not include py-ref.h.
1468         * python/py-framefilter.c: Do not include py-ref.h.
1469         * python/py-function.c: Do not include py-ref.h.
1470         * python/py-infevents.c: Do not include py-ref.h.
1471         * python/py-linetable.c: Do not include py-ref.h.
1472         * python/py-objfile.c: Do not include py-ref.h.
1473         * python/py-param.c: Do not include py-ref.h.
1474         * python/py-prettyprint.c: Do not include py-ref.h.
1475         * python/py-progspace.c: Do not include py-ref.h.
1476         * python/py-symbol.c: Do not include py-ref.h.
1477         * python/py-symtab.c: Do not include py-ref.h.
1478         * python/py-type.c: Do not include py-ref.h.
1479         * python/py-unwind.c: Do not include py-ref.h.
1480         * python/py-utils.c: Do not include py-ref.h.
1481         * python/py-value.c: Do not include py-ref.h.
1482         * python/py-varobj.c: Do not include py-ref.h.
1483         * python/py-xmethods.c: Do not include py-ref.h.
1484         * python/python.c: Do not include py-ref.h.
1485         * varobj.c: Do not include py-ref.h.
1486
1487 2019-01-22  Tom Tromey  <tom@tromey.com>
1488
1489         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1490         keyword for bcache.
1491
1492 2019-01-22  Tom Tromey  <tom@tromey.com>
1493
1494         * compile/compile-cplus-types.c: Remove a comment by #include.
1495
1496 2019-01-22  Tom Tromey  <tom@tromey.com>
1497
1498         * compile/gcc-c-plugin.h: Include compile-internal.h.
1499
1500 2019-01-22  Tom Tromey  <tom@tromey.com>
1501
1502         * stabsread.c (EXTERN): Do not define.
1503         (symnum, next_symbol_text_func, processing_gcc_compilation)
1504         (within_function, global_sym_chain, global_stabs)
1505         (previous_stab_code, this_object_header_files)
1506         (n_this_object_header_files)
1507         (n_allocated_this_object_header_files): Define.
1508         * stabsread.h (EXTERN): Never define.  Use "extern".
1509
1510 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1511
1512         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1513         history_value.
1514
1515 2019-01-21  Tom Tromey  <tom@tromey.com>
1516
1517         * ui-out.c: Fix includes.
1518         * tui/tui-source.c: Fix includes.
1519         * target.c: Fix includes.
1520         * remote.c: Fix includes.
1521         * regcache.c: Fix includes.
1522         * python/py-block.c: Fix includes.
1523         * printcmd.c: Fix includes.
1524         * or1k-tdep.c: Fix includes.
1525         * mi/mi-main.c: Fix includes.
1526         * m32r-tdep.c: Fix includes.
1527         * csky-tdep.c: Fix includes.
1528         * compile/compile-cplus-types.c: Fix includes.
1529         * cli/cli-interp.c: Fix includes.
1530
1531 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1532
1533         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1534         for padding.
1535
1536 2019-01-16  Tom Tromey  <tom@tromey.com>
1537
1538         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1539         earlier.
1540         (struct objfile) <msymbols_range>: Move from top level.
1541         <msymbols>: New method.
1542         (class objfile_msymbols): Remove.
1543         * symtab.c (default_collect_symbol_completion_matches_break_on):
1544         Update.
1545         * symmisc.c (dump_msymbols): Update.
1546         * stabsread.c (scan_file_globals): Update.
1547         * objc-lang.c (info_selectors_command, info_classes_command)
1548         (find_methods): Update.
1549         * minsyms.c (find_solib_trampoline_target): Update.
1550         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1551         * coffread.c (coff_symfile_read): Update.
1552         * ada-lang.c (ada_lookup_simple_minsym)
1553         (ada_collect_symbol_completion_matches): Update.
1554
1555 2019-01-16  Tom Tromey  <tom@tromey.com>
1556
1557         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1558         type.  Remove no-argument constructor.
1559         <iterator::operator++>: Simplify.
1560         <begin>: Update.
1561         <end>: Use minimal_symbol_count.
1562
1563 2019-01-16  Tom Tromey  <tom@tromey.com>
1564
1565         * objfiles.h (struct objfile) <psymtabs>: New method.
1566         (class objfile_psymtabs): Remove.
1567         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1568         typedef.
1569         <range>: New method.
1570         (require_partial_symbols): Change return type.
1571         * psymtab.c (require_partial_symbols)
1572         (psym_expand_symtabs_matching): Update.
1573         * mdebugread.c (parse_partial_symbols): Update.
1574         * dbxread.c (dbx_end_psymtab): Update.
1575
1576 2019-01-15  Tom Tromey  <tom@tromey.com>
1577
1578         * symtab.c (lookup_objfile_from_block)
1579         (lookup_symbol_in_objfile_symtabs)
1580         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1581         (find_line_symtab, info_sources_command)
1582         (default_collect_symbol_completion_matches_break_on)
1583         (make_source_files_completion_list): Update.
1584         * symmisc.c (print_objfile_statistics, dump_objfile)
1585         (maintenance_print_symbols, maintenance_info_symtabs)
1586         (maintenance_check_symtabs, maintenance_info_line_tables):
1587         Update.
1588         * source.c (select_source_symtab)
1589         (forget_cached_source_info_for_objfile): Update.
1590         * objfiles.h (class objfile_compunits): Remove.
1591         (struct objfile) <compunits_range>: New typedef.
1592         (compunits): New method.
1593         * objfiles.c (objfile_relocate1): Update.
1594         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1595         * maint.c (count_symtabs_and_blocks): Update.
1596         * linespec.c (iterate_over_all_matching_symtabs): Update.
1597         * cp-support.c (add_symbol_overload_list_qualified): Update.
1598         * coffread.c (coff_symtab_read): Update.
1599         * ada-lang.c (add_nonlocal_symbols)
1600         (ada_collect_symbol_completion_matches)
1601         (ada_add_global_exceptions): Update.
1602
1603 2019-01-15  Tom Tromey  <tom@tromey.com>
1604
1605         * progspace.h (program_space) <objfiles_safe_range>: New
1606         typedef.
1607         <objfiles_safe>: New method.
1608         * objfiles.h (class all_objfiles_safe): Remove.
1609         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1610         * jit.c (jit_inferior_exit_hook): Update.
1611
1612 2019-01-17  Tom Tromey  <tom@tromey.com>
1613
1614         * progspace.h (program_space) <objfiles_range>: New typedef.
1615         <objfiles>: New method.
1616         <objfiles_head>: Rename from objfiles.
1617         (object_files): Update.
1618         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1619         * guile/scm-pretty-print.c
1620         (ppscm_find_pretty_printer_from_objfiles): Update.
1621         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1622         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1623         Update.
1624         * python/py-progspace.c (pspy_get_objfiles): Update.
1625         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1626         Update.
1627         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1628         (objfpy_lookup_objfile_by_build_id): Update.
1629         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1630         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1631         Update.
1632         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1633         (expand_symtab_containing_pc, lookup_objfile_from_block)
1634         (lookup_static_symbol, basic_lookup_transparent_type)
1635         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1636         (find_line_symtab, info_sources_command)
1637         (default_collect_symbol_completion_matches_break_on)
1638         (make_source_files_completion_list, find_main_name): Update.
1639         * symmisc.c (print_symbol_bcache_statistics)
1640         (print_objfile_statistics, maintenance_print_symbols)
1641         (maintenance_print_msymbols, maintenance_print_objfiles)
1642         (maintenance_info_symtabs, maintenance_check_symtabs)
1643         (maintenance_expand_symtabs, maintenance_info_line_tables):
1644         Update.
1645         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1646         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1647         (map_overlay_command, unmap_overlay_command)
1648         (simple_overlay_update, expand_symtabs_matching)
1649         (map_symbol_filenames): Update.
1650         * symfile-debug.c (set_debug_symfile): Update.
1651         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1652         Update.
1653         * source.c (select_source_symtab, forget_cached_source_info):
1654         Update.
1655         * solib.c (solib_read_symbols): Update.
1656         * solib-spu.c (append_ocl_sos): Update.
1657         * psymtab.c (maintenance_print_psymbols)
1658         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1659         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1660         * printcmd.c (info_symbol_command): Update.
1661         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1662         Update.
1663         * objfiles.h (class all_objfiles): Remove.
1664         * objfiles.c (have_partial_symbols, have_full_symbols)
1665         (have_minimal_symbols, qsort_cmp, update_section_map)
1666         (shared_objfile_contains_address_p)
1667         (default_iterate_over_objfiles_in_search_order): Update.
1668         * objc-lang.c (info_selectors_command, info_classes_command)
1669         (find_methods): Update.
1670         * minsyms.c (find_solib_trampoline_target): Update.
1671         * maint.c (maintenance_info_sections)
1672         (maintenance_translate_address, count_symtabs_and_blocks):
1673         Update.
1674         * main.c (captured_main_1): Update.
1675         * linux-thread-db.c (try_thread_db_load_from_pdir)
1676         (has_libpthread): Update.
1677         * linespec.c (iterate_over_all_matching_symtabs)
1678         (search_minsyms_for_name): Update.
1679         * jit.c (jit_find_objf_with_entry_addr): Update.
1680         * hppa-tdep.c (find_unwind_entry)
1681         (hppa_lookup_stub_minimal_symbol): Update.
1682         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1683         Update.
1684         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1685         (elf_gnu_ifunc_resolve_by_got): Update.
1686         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1687         * dwarf-index-write.c (save_gdb_index_command): Update.
1688         * cp-support.c (add_symbol_overload_list_qualified): Update.
1689         * breakpoint.c (create_overlay_event_breakpoint)
1690         (create_longjmp_master_breakpoint)
1691         (create_std_terminate_master_breakpoint)
1692         (create_exception_master_breakpoint): Update.
1693         * blockframe.c (find_pc_partial_function): Update.
1694         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1695         (ada_collect_symbol_completion_matches)
1696         (ada_add_global_exceptions): Update.
1697
1698 2019-01-17  Tom Tromey  <tom@tromey.com>
1699
1700         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1701         declare VEC.
1702         (solib_target_parse_libraries): Change return type.
1703         (library_list_start_segment, library_list_start_section)
1704         (library_list_end_library, library_list_start_library); Update.
1705         (solib_target_free_library_list): Remove.
1706         (solib_target_parse_libraries): Remove cleanup.  Change return
1707         type.
1708         (solib_target_current_sos): Update.
1709
1710 2019-01-17  Tom Tromey  <tromey@bapiya>
1711
1712         * valprint.c: Replace "the the" with "the".
1713         * symtab.c: Replace "the the" with "the".
1714         * solib.c: Replace "the the" with "the".
1715         * solib-dsbt.c: Replace "the the" with "the".
1716         * linespec.c: Replace "the the" with "the".
1717         * dwarf2loc.h: Replace "the the" with "the".
1718         * amd64-windows-tdep.c: Replace "the the" with "the".
1719         * aarch64-tdep.c: Replace "the the" with "the".
1720
1721 2019-01-16  Keith Seitz  <keiths@redhat.com>
1722
1723         PR gdb/23773
1724         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1725         <builder>: Rename to ..
1726         <m_builder>: ... this and make private.
1727         (dwarf2_cu::get_builder): New method.  Change all users of
1728         `builder' to use this method.
1729         (dwarf2_start_symtab): Move to ...
1730         (dwarf2_cu::start_symtab): ... here.  Update all callers
1731         (setup_type_unit_groups): Move to ...
1732         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1733         callers.
1734         (dwarf2_cu::reset_builder): New method.
1735         (process_full_compunit, process_full_type_unit): Use
1736         dwarf2_cu::reset_builder.
1737         (follow_die_offset): Record the ancestor CU if it is different
1738         from the followed DIE's CU.
1739         (follow_die_sig_1): Likewise.
1740
1741 2019-01-15  Tom Tromey  <tom@tromey.com>
1742
1743         * remote.c (class remote_state) <buf>: Now a char_vector.
1744         <buf_size>: Remove.
1745         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1746         parameter.
1747         (remote_target::getpkt_or_notif_sane_1)
1748         (remote_target::getpkt_sane)
1749         (remote_target::getpkt_or_notif_sane): Likewise.
1750         (class remote_target) <putpkt>: New overload.
1751         (remote_target::read_frame): Change type of "buf_p".  Remove
1752         sizeof_p parameter.
1753         (packet_ok): New overload.
1754         (packet_check_result): New overload.
1755         Update all uses.
1756
1757 2019-01-14  Tom Tromey  <tom@tromey.com>
1758
1759         * remote-notif.c (handle_notification, remote_notif_ack)
1760         (remote_notif_parse): Make "buf" const.
1761         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1762         const.
1763         (remote_notif_parse, remote_notif_ack, handle_notification):
1764         Likewise.
1765         * remote.c (remote_notif_stop_parse): Make "buf" const.
1766         (remote_target::remote_parse_stop_reply): Make "buf" const.
1767         (remote_notif_stop_ack): Make "buf" const.
1768
1769 2019-01-14  Tom Tromey  <tom@tromey.com>
1770
1771         * remote.c (remote_console_output): Make parameter const.
1772
1773 2019-01-14  Tom Tromey  <tom@tromey.com>
1774
1775         * target-debug.h (target_debug_print_signals): Constify.
1776         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1777         * procfs.c (procfs_target::pass_signals): Update.
1778         * linux-nat.c (linux_nat_target::pass_signals): Update.
1779         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1780         * target-delegates.c: Rebuild.
1781         * remote.c (remote_target::program_signals): Update.
1782         (remote_target::pass_signals): Update.
1783         * target.c (target_pass_signals): Constify argument.
1784         (target_program_signals): Likewise.
1785         * target.h (struct target_ops) <pass_signals, program_signals>:
1786         Constify argument.
1787         (target_pass_signals, target_program_signals): Constify argument.
1788
1789 2019-01-14  Tom Tromey  <tom@tromey.com>
1790
1791         PR tui/28819:
1792         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1793
1794 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1795
1796         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1797         field.
1798         * rs6000-tdep.c: Include reggroups.h.
1799         (IS_V_ALIAS_PSEUDOREG): Define.
1800         (rs6000_register_name): Return names for the "vX" aliases.
1801         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1802         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1803         aliases.  Call default_register_reggroup_p for all other
1804         pseudo-registers.
1805         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1806         New functions.
1807         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1808         Handle "vX" aliases.
1809         (v_alias_pseudo_register_collect): New function.
1810         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1811         (rs6000_gdbarch_init): Initialize "vX" aliases as
1812         pseudo-registers.  Restore registration of
1813         rs6000_pseudo_register_reggroup_p with
1814         set_tdesc_pseudo_register_reggroup_p.
1815
1816 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1817
1818         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1819         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1820         set_gdbarch_num_pseudo_regs.
1821
1822 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1823
1824         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1825         Remove arg prefixname, add do_set and do_show.
1826         Add member functions set_list and show_list.
1827         * cli/cli-style.c (class cli_style_option): Update accordingly.
1828         (style_set_list): Move to file scope.
1829         (style_show_list): Likewise.
1830         (set_style): Call help_list.
1831         (show_style): Call cmd_show_list.
1832         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1833         Update to use the new macro.
1834
1835 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1836
1837         * ada-lang.c (_initialize_ada_language): Expand the help text
1838         for the "catch exception" command.
1839
1840 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1841
1842         * symtab.c (matching_obj_sections): Initialize obj,
1843         declare it closer to its usage.
1844
1845 2019-01-10  Tom Tromey  <tom@tromey.com>
1846
1847         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1848         (basic_inf_threads_range): Remove.
1849         (inf_threads_range, inf_non_exited_threads_range)
1850         (safe_inf_threads_range): Use next_adapter.
1851
1852 2019-01-10  Keith Seitz  <keiths@redhat.com>
1853
1854         PR gdb/23712
1855         PR symtab/23010
1856         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1857         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1858
1859 2019-01-10  Keith Seitz  <keiths@redhat.com>
1860
1861         PR gdb/23712
1862         PR symtab/23010
1863         * dictionary.c (pending_to_vector): Remove.
1864         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1865         Remove _1 suffix, replacing functions of the same name.  Update
1866         all callers.
1867         (dict_create_hashed, dict_create_hashed_expandable)
1868         (dict_create_linear, dict_create_linear_expandable, dict_free)
1869         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1870         Make functions static.
1871
1872 2019-01-10  Keith Seitz  <keiths@redhat.com>
1873
1874         PR gdb/23712
1875         PR symtab/23010
1876         * dictionary.h (struct dictionary): Replace declaration with
1877         multidictionary.
1878         (dict_create_hashed, dict_create_hashed_expandable)
1879         (dict_create_linear, dict_create_linear_expandable)
1880         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1881         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1882         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1883         taking multidictionary argument.
1884         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1885         * block.h (struct block) <dict>: Change to multidictionary
1886         and rename `multidict'.
1887         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1888         symmisc.c: Update all dictionary references to multidictionary.
1889
1890 2019-01-10  Keith Seitz  <keiths@redhat.com>
1891
1892         PR gdb/23712
1893         PR symtab/23010
1894         * dictionary.c: Include unordered_map.
1895         (pending_to_vector): New function.
1896         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1897         Rewrite the non-"_1" functions to take vector instead
1898         of linked list.
1899         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1900         "new" _1 versions of the same name.
1901         (multidictionary): Define.
1902         (std::hash<enum language): New definition.
1903         (collate_pending_symbols_by_language, mdict_create_hashed)
1904         (mdict_create_hashed_expandable, mdict_create_linear)
1905         (mdict_create_linear_expandable, mdict_free)
1906         (find_language_dictionary, create_new_language_dictionary)
1907         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1908         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1909         (mdict_size, mdict_empty): New functions.
1910         * dictionary.h (mdict_iterator): Define.
1911
1912 2019-01-10  Pedro Alves  <palves@redhat.com>
1913
1914         * breakpoint.c (read_uploaded_action)
1915         (create_tracepoint_from_upload): Adjust to use
1916         gdb::unique_xmalloc_ptr.
1917         * ctf.c (ctf_write_uploaded_tp):
1918         (SET_ARRAY_FIELD): Use emplace_back.
1919         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1920         * tracefile-tfile.c (tfile_write_uploaded_tp):
1921         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1922         gdb::unique_xmalloc_ptr.
1923         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1924         at_string, cond_string, cmd_strings>: Replace char pointers
1925         with gdb::unique_xmalloc_ptr.
1926
1927 2019-01-10  Pedro Alves  <palves@redhat.com>
1928
1929         * solib-target.c (library_list_start_library): Don't xstrdup name.
1930
1931 2019-01-10  Pedro Alves  <palves@redhat.com>
1932
1933         * mdebugread.c (parse_partial_symbols): Use
1934         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1935
1936 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1937
1938         * linux-fork.c (scoped_switch_fork_info)
1939         <~scoped_switch_fork_info>: Fix incorrect variable name.
1940
1941 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1942
1943         * linux-fork.c (scoped_switch_fork_info)
1944         <scoped_switch_fork_info>: Make explicit.
1945         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1946
1947 2019-01-10  Tom Tromey  <tom@tromey.com>
1948
1949         * objfiles.h (objfile::reset_psymtabs): Update.
1950         * objfiles.c (objfile::objfile): Update.
1951         * psymtab.h (psymtab_storage::obstack): Update.
1952         (psymtab_storage::m_obstack): Use gdb::optional.
1953         (class psymtab_storage): Update comment.  Remove objfile
1954         parameter.
1955         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1956
1957 2019-01-10  Tom Tromey  <tom@tromey.com>
1958
1959         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1960         <free_psymtabs>: Now private.
1961         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1962         (allocate_psymtab): Use new method.
1963
1964 2019-01-10  Tom Tromey  <tom@tromey.com>
1965
1966         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1967         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1968         * mdebugread.c (parse_partial_symbols): Use
1969         allocate_dependencies.
1970         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1971         allocate_dependencies.
1972         (process_psymtab_comp_unit_reader)
1973         (build_type_psymtab_dependencies): Likewise.
1974         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1975
1976 2019-01-10  Tom Tromey  <tom@tromey.com>
1977
1978         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1979         PSYMBOL_SET_LANGUAGE.
1980         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1981
1982 2019-01-10  Tom Tromey  <tom@tromey.com>
1983
1984         * psymtab.h (psymtab_storage::obstack): New method.
1985         <m_obstack>: Rename from obstack; now private.
1986         * psymtab.c (psymtab_storage): Update.
1987         * dwarf2read.c (create_addrmap_from_index)
1988         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1989         Update.
1990
1991 2019-01-10  Tom Tromey  <tom@tromey.com>
1992
1993         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1994         * objfiles.h (objfile::reset_psymtabs): New method.
1995
1996 2019-01-10  Tom Tromey  <tom@tromey.com>
1997
1998         * symmisc.c (print_symbol_bcache_statistics): Update.
1999         (print_objfile_statistics): Update.
2000         * symfile.c (reread_symbols): Update.
2001         * psymtab.h (class psymtab_storage): New.
2002         * psymtab.c (psymtab_storage): New constructor.
2003         (~psymtab_storage): New destructor.
2004         (require_partial_symbols): Update.
2005         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
2006         (find_pc_sect_psymtab, find_pc_sect_psymbol)
2007         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
2008         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
2009         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
2010         (start_psymtab_common, end_psymtab_common)
2011         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
2012         (allocate_psymtab): Update.
2013         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
2014         Update.
2015         (dump_psymtab_addrmap, maintenance_print_psymbols)
2016         (maintenance_check_psymtabs): Update.
2017         (class objfile_psymtabs): Move to objfiles.h.
2018         * psympriv.h (discard_psymtab): Now inline.
2019         (psymtab_discarder::psymtab_discarder): Update.
2020         (psymtab_discarder::~psymtab_discarder): Update.
2021         (ALL_OBJFILE_PSYMTABS): Rewrite.
2022         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
2023         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
2024         Remove fields.
2025         <partial_symtabs>: New field.
2026         (class objfile_psymtabs): Move from psymtab.h.  Update.
2027         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
2028         psymbol_cache.
2029         (objfile::~objfile): Don't destroy psymbol_cache.
2030         * mdebugread.c (parse_partial_symbols): Update.
2031         * dwarf2read.c (create_addrmap_from_index)
2032         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2033         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2034         (add_partial_subprogram, dwarf2_ranges_read): Update.
2035         * dwarf-index-write.c (write_address_map)
2036         (write_one_signatured_type, recursively_write_psymbols)
2037         (class debug_names, class debug_names, write_psymtabs_to_index):
2038         Update.
2039
2040 2019-01-10  Tom Tromey  <tom@tromey.com>
2041
2042         * symtab.h (SYMBOL_SET_NAMES): Update.
2043         (symbol_set_names): Update.
2044         (MSYMBOL_SET_NAMES): Update.
2045         * symtab.c (symbol_set_names): Change argument to be an
2046         objfile_per_bfd_storage.
2047         * psymtab.c (add_psymbol_to_bcache): Update.
2048         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2049
2050 2019-01-10  Tom Tromey  <tom@tromey.com>
2051
2052         * symtab.c (create_demangled_names_hash): Change argument to be an
2053         objfile_per_bfd_storage.
2054         (symbol_set_names): Update.
2055
2056 2019-01-10  Tom Tromey  <tom@tromey.com>
2057
2058         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2059         init_psymbol_list.
2060         * psymtab.c (init_psymbol_list): Do nothing if already called.
2061         * psympriv.h (init_psymbol_list): Add comment.
2062         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2063         init_psymbol_list.
2064         * dbxread.c (dbx_symfile_read): Unconditionally call
2065         init_psymbol_list.
2066
2067 2019-01-10  Tom Tromey  <tom@tromey.com>
2068
2069         * xcoffread.c (scan_xcoff_symtab): Update.
2070         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2071         "where".
2072         * mdebugread.c (parse_partial_symbols)
2073         (handle_psymbol_enumerators): Update.
2074         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2075         * dbxread.c (read_dbx_symtab): Update.
2076         * psympriv.h (psymbol_placement): New enum.
2077         (add_psymbol_to_list): Update.
2078
2079 2019-01-10  Tom Tromey  <tom@tromey.com>
2080
2081         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2082         static_psymbols parameters.
2083         (scan_xcoff_symtab): Update.
2084         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2085         static_psymbols parameters.
2086         * psympriv.h (start_psymtab_common): Update.
2087         * mdebugread.c (parse_partial_symbols): Update.
2088         * dwarf2read.c (create_partial_symtab): Update.
2089         * dbxread.c (read_dbx_symtab): Update.
2090         (start_psymtab): Remove global_psymbols and static_psymbols
2091         parameters.
2092
2093 2019-01-10  Tom Tromey  <tom@tromey.com>
2094
2095         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2096         * psymtab.c (allocate_psymtab): Add comment.
2097         * psympriv.h (allocate_psymtab): Add comment.
2098         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2099         initializations.
2100         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2101
2102 2019-01-10  Tom Tromey  <tom@tromey.com>
2103
2104         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2105         Don't declare.
2106         * mipsread.c: Include mdebugread.h.
2107         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2108         Declare.
2109         * elfread.c: Include mdebugread.h.
2110
2111 2019-01-09  Tom Tromey  <tom@tromey.com>
2112
2113         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2114         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2115         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2116         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2117         (psym_lookup_symbol, psym_find_last_source_symtab)
2118         (psym_forget_cached_source_info, psym_print_stats)
2119         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2120         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2121         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2122         (psym_find_compunit_symtab_by_address)
2123         (maintenance_print_psymbols, maintenance_info_psymtabs)
2124         (maintenance_check_psymtabs): Use ranged for.
2125         * psymtab.h (class objfile_psymtabs): New.
2126         (require_partial_symbols): Return objfile_psymtabs.
2127         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2128
2129 2019-01-09  Tom Tromey  <tom@tromey.com>
2130
2131         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2132         (find_pc_mapped_section, list_overlays_command)
2133         (map_overlay_command, unmap_overlay_command)
2134         (simple_overlay_update): Use all_objfiles.
2135         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2136         * printcmd.c (info_symbol_command): Use all_objfiles.
2137         * objfiles.h (ALL_OBJSECTIONS): Remove.
2138         * maint.c (maintenance_translate_address): Use all_objfiles.
2139         * gcore.c (gcore_create_callback): Use all_objfiles.
2140         (objfile_find_memory_regions): Likewise.
2141
2142 2019-01-09  Tom Tromey  <tom@tromey.com>
2143
2144         * symtab.c (find_line_symtab, info_sources_command)
2145         (make_source_files_completion_list): Use objfile_compunits.
2146         * source.c (select_source_symtab): Use objfile_compunits.
2147         * objfiles.h (struct objfile): Update comment.
2148         (ALL_OBJFILES): Remove.
2149         (ALL_FILETABS): Remove.
2150         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2151         objfile_compunits.
2152
2153 2019-01-09  Tom Tromey  <tom@tromey.com>
2154
2155         * symmisc.c (print_objfile_statistics, dump_objfile)
2156         (maintenance_print_symbols): Use compunit_filetabs.
2157         * source.c (forget_cached_source_info_for_objfile): Use
2158         compunit_filetabs.
2159         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2160         (ALL_FILETABS): Use compunit_filetabs.
2161         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2162         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2163
2164 2019-01-09  Tom Tromey  <tom@tromey.com>
2165
2166         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2167         (compunit_filetabs): New.
2168         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2169         compunit_filetabs.
2170         (info_sources_command, make_source_files_completion_list): Remove
2171         declaration.
2172         * symmisc.c (print_objfile_statistics, dump_objfile)
2173         (maintenance_print_symbols): Remove declaration.
2174         (maintenance_info_symtabs): Use compunit_filetabs.
2175         (maintenance_info_line_tables): Likewise.
2176         * source.c (select_source_symtab): Change local variable name.
2177         (forget_cached_source_info_for_objfile): Remove declaration.
2178         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2179         * objfiles.c (objfile_relocate1): Remove declaration.
2180         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2181         declaration.
2182         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2183         * coffread.c (coff_symtab_read): Remove declaration.
2184         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2185         compunit_filetabs.
2186
2187 2019-01-09  Tom Tromey  <tom@tromey.com>
2188
2189         * symtab.c (lookup_objfile_from_block)
2190         (find_pc_sect_compunit_symtab, search_symbols)
2191         (default_collect_symbol_completion_matches_break_on): Use
2192         objfile_compunits.
2193         * objfiles.h (ALL_COMPUNITS): Remove.
2194         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2195         * cp-support.c (add_symbol_overload_list_qualified): Use
2196         objfile_compunits.
2197         * ada-lang.c (ada_collect_symbol_completion_matches)
2198         (ada_add_global_exceptions): Use objfile_compunits.
2199
2200 2019-01-09  Tom Tromey  <tom@tromey.com>
2201
2202         * source.c (select_source_symtab)
2203         (forget_cached_source_info_for_objfile): Remove declaration.
2204         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2205         declaration.
2206         * maint.c (count_symtabs_and_blocks): Remove declaration.
2207         * cp-support.c (add_symbol_overload_list_qualified): Remove
2208         declaration.
2209         * coffread.c (coff_symtab_read): Remove declaration.
2210         * symtab.c (lookup_symbol_in_objfile_symtabs)
2211         (basic_lookup_transparent_type_1): Use objfile_compunits.
2212         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2213         (info_sources_command, search_symbols)
2214         (default_collect_symbol_completion_matches_break_on)
2215         (make_source_files_completion_list): Remove declaration.
2216         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2217         (ada_collect_symbol_completion_matches)
2218         (ada_add_global_exceptions): Remove declaration.
2219         * linespec.c (iterate_over_all_matching_symtabs): Use
2220         objfile_compunits.
2221         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2222         (class objfile_compunits): New.
2223         (ALL_COMPUNITS): Use objfile_compunits.
2224         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2225         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2226         objfile_compunits.
2227         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2228
2229 2019-01-09  Tom Tromey  <tom@tromey.com>
2230
2231         * symtab.c (search_symbols)
2232         (default_collect_symbol_completion_matches_break_on): Use
2233         objfile_msymbols.
2234         * ada-lang.c (ada_lookup_simple_minsym)
2235         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2236         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2237         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2238         objfile_msymbols.
2239         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2240         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2241         * objc-lang.c (find_methods): Use objfile_msymbols.
2242         (info_selectors_command, info_classes_command): Likewise.
2243         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2244         * objfiles.h (class objfile_msymbols): New.
2245         (ALL_OBJFILE_MSYMBOLS): Remove.
2246         (ALL_MSYMBOLS): Remove.
2247
2248 2019-01-09  Tom Tromey  <tom@tromey.com>
2249
2250         * common/next-iterator.h (next_adapter): Add Iterator template
2251         parameter.
2252         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2253         (class all_objfiles_safe): New.
2254         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2255         * objfiles.c (put_objfile_before): Update comment.
2256         (add_separate_debug_objfile): Likewise.
2257         (free_all_objfiles): Use all_objfiles_safe.
2258         (objfile_purge_solibs): Likewise.
2259
2260 2019-01-09  Tom Tromey  <tom@tromey.com>
2261
2262         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2263         (expand_symtab_containing_pc, lookup_static_symbol)
2264         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2265         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2266         all_objfiles.
2267         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2268         * breakpoint.c (create_overlay_event_breakpoint)
2269         (create_longjmp_master_breakpoint)
2270         (create_std_terminate_master_breakpoint)
2271         (create_exception_master_breakpoint): Use all_objfiles.
2272         * linux-thread-db.c (try_thread_db_load_from_pdir)
2273         (has_libpthread): Use all_objfiles.
2274         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2275         * linespec.c (iterate_over_all_matching_symtabs)
2276         (search_minsyms_for_name): Use all_objfiles.
2277         * maint.c (maintenance_info_sections): Use all_objfiles.
2278         * main.c (captured_main_1): Use all_objfiles.
2279         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2280         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2281         * guile/scm-pretty-print.c
2282         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2283         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2284         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2285         (maintenance_print_msymbols): Use all_objfiles.
2286         * source.c (select_source_symtab): Use all_objfiles.
2287         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2288         * symfile.c (remove_symbol_file_command)
2289         (expand_symtabs_matching, map_symbol_filenames): Use
2290         all_objfiles.
2291         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2292         all_objfiles.
2293         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2294         * objc-lang.c (find_methods): Use all_objfiles.
2295         * objfiles.c (have_partial_symbols, have_full_symbols)
2296         (have_minimal_symbols, qsort_cmp)
2297         (default_iterate_over_objfiles_in_search_order): Use
2298         all_objfiles.
2299         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2300         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2301         (maintenance_check_psymtabs): Use all_objfiles.
2302         (ALL_PSYMTABS): Remove.
2303         * compile/compile-object-run.c (do_module_cleanup): Use
2304         all_objfiles.
2305         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2306         * cp-support.c (add_symbol_overload_list_qualified): Use
2307         all_objfiles.
2308         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2309         Use all_objfiles.
2310         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2311         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2312         all_objfiles.
2313         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2314         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2315         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2316         Uses all_objfiles.
2317         * solib.c (solib_read_symbols): Use all_objfiles
2318
2319 2019-01-09  Tom Tromey  <tom@tromey.com>
2320
2321         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2322         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2323         all_objfiles.
2324         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2325         * symmisc.c (print_symbol_bcache_statistics)
2326         (print_objfile_statistics, maintenance_print_objfiles)
2327         (maintenance_info_symtabs, maintenance_check_symtabs)
2328         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2329         all_objfiles.
2330         * source.c (forget_cached_source_info): Use all_objfiles.
2331         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2332         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2333         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2334         * objfiles.c (update_section_map): Use all_objfiles.
2335         (shared_objfile_contains_address_p): Likewise.
2336         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2337         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2338
2339 2019-01-09  Tom Tromey  <tom@tromey.com>
2340
2341         * common/next-iterator.h: New file.
2342         * objfiles.h (class all_objfiles): New.
2343         (struct objfile_iterator): New.
2344
2345 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2346
2347         * NEWS: Move the description of the changed "frame", "select-frame",
2348          and "info frame" commands to the Changed commands section.
2349
2350 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2351
2352         * gdbtypes.c (check_stub_method_group): Remove handling of old
2353         mangling schemes.
2354         * linespec.c (find_methods): Likewise.
2355         * stabsread.c (read_member_functions): Likewise.
2356         * valops.c (search_struct_method): Likewise.
2357         (value_struct_elt_for_reference): Likewise.
2358         * NEWS: Mention this change.
2359
2360 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2361
2362         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2363         print_source_lines.
2364         * source.c (print_source_lines_base): Update line number check.
2365         (print_source_lines): New function.
2366         (source_lines_range::source_lines_range): New function.
2367         * source.h (class source_lines_range): New class.
2368         (print_source_lines): New declaration.
2369
2370 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2371
2372         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2373
2374 2019-01-08  Tom Tromey  <tom@tromey.com>
2375             Simon Marchi  <simon.marchi@ericsson.com>
2376
2377         PR gdb/24060
2378         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2379         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2380         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2381         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2382         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2383         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2384
2385 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2386
2387         * source.c (select_source_symtab): Move header comment to
2388         declaration in source.h.
2389         (forget_cached_source_info_for_objfile): Likewise.
2390         (forget_cached_source_info): Likewise.
2391         (identify_source_line): Likewise.
2392         * source.h (identify_source_line): Move declaration from symtab.h
2393         and add comment from source.c
2394         (print_source_lines): Likewise.
2395         (forget_cached_source_info_for_objfile): Likewise.
2396         (forget_cached_source_info): Likewise.
2397         (select_source_symtab): Likewise.
2398         (enum print_source_lines_flag): Move definition from symtab.h.
2399         * symtab.h (identify_source_line): Move declaration to source.h.
2400         (print_source_lines): Likewise.
2401         (forget_cached_source_info_for_objfile): Likewise.
2402         (forget_cached_source_info): Likewise.
2403         (select_source_symtab): Likewise.
2404         (enum print_source_lines_flag): Move definition to source.h.
2405         * tui/tui-hooks.c: Add 'source.h' include.
2406
2407 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2408
2409         * source.c (print_source_lines_base): Handle requests to print
2410         reverse line number sequences, and guard against empty lines
2411         string.
2412
2413 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2414
2415         * source.c (print_source_lines_base): Fix skip of '\r' if next
2416         character is '\n'.
2417
2418 2019-01-06  Tom Tromey  <tom@tromey.com>
2419
2420         * c-exp.y (struct c_parse_state) <macro_original_text,
2421         expansion_obstack>: New member.
2422         (macro_original_text, expansion_obstack): Remove globals.
2423         (scan_macro_expansion, scanning_macro_expansion)
2424         (finished_macro_expansion): Update.
2425         (scan_macro_cleanup): Remove.
2426         (yylex, c_parse): Update.
2427
2428 2019-01-06  Tom Tromey  <tom@tromey.com>
2429
2430         * c-exp.y (struct c_parse_state) <strings>: New member.
2431         (operator_stoken): Update.
2432
2433 2019-01-06  Tom Tromey  <tom@tromey.com>
2434
2435         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2436         (union type_stack_elt) <typelist_val>: Now a pointer to
2437         std::vector.
2438         (type_stack_cleanup): Don't declare.
2439         (push_typelist): Update.
2440         * parse.c (pop_typelist): Return a std::vector.
2441         (push_typelist): Take a std::vector.
2442         (follow_types): Update.  Do not free args.
2443         (type_stack_cleanup): Remove.
2444         * c-exp.y (struct c_parse_state): New.
2445         (cpstate): New global.
2446         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2447         (nonempty_typelist): Update.
2448         (func_mod): Create a new vector.
2449         (c_parse): Create a c_parse_state.
2450         (check_parameter_typelist): Do not delete params.
2451         (function_method): Update.  Do not delete type_list.
2452
2453 2019-01-06  Tom Tromey  <tom@tromey.com>
2454
2455         PR gdb/28155:
2456         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2457         check_typedef.
2458         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2459         (print_return_value): Likewise.
2460
2461 2019-01-05  Tom Tromey  <tom@tromey.com>
2462
2463         * contrib/cleanup_check.py: Remove.
2464         * contrib/gcc-with-excheck: Remove.
2465         * contrib/exsummary.py: Remove.
2466         * contrib/excheck.py: Remove.
2467
2468 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2469
2470         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2471         NULL. Initialize tpprev to NULL instead of assigning it
2472         to NULL on the next statement.
2473         * windows-nat.c (windows_delete_thread): Remove check for
2474         main_thread_id before printing thread exit notifications.
2475         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2476         Remove thread ID check against main_thread_id.
2477         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2478         windows_delete_thread.
2479         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2480
2481 2019-01-04  Tom Tromey  <tom@tromey.com>
2482
2483         * compile/compile.c (_initialize_compile): Use upper case for
2484         metasyntactic variables.
2485         * symmisc.c (_initialize_symmisc): Use upper case for
2486         metasyntactic variables.
2487         * psymtab.c (_initialize_psymtab): Use upper case for
2488         metasyntactic variables.
2489         * demangle.c (demangle_command): Use upper case for metasyntactic
2490         variables.
2491         (_initialize_demangler): Likewise.
2492         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2493         variables.
2494
2495 2019-01-03  Tom Tromey  <tom@tromey.com>
2496
2497         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2498
2499 2019-01-03  Tom Tromey  <tom@tromey.com>
2500
2501         * python/py-symtab.c (salpy_str): Update.
2502         (struct salpy_sal_object) <symtab>: Now a PyObject.
2503         (salpy_dealloc): Update.
2504         (del_objfile_sal): Use gdbpy_ref.
2505
2506 2019-01-03  Tom Tromey  <tom@tromey.com>
2507
2508         * python/py-type.c (convert_field): Use new_reference.  Return
2509         gdbpy_ref.
2510         (make_fielditem): Return gdbpy_ref.
2511         (typy_fields): Update.
2512         (typy_getitem): Update.
2513         (field_name): Return gdbpy_ref.  Use new_reference.
2514         (typy_iterator_iternext): Update.
2515
2516 2019-01-03  Tom Tromey  <tom@tromey.com>
2517
2518         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2519
2520 2019-01-03  Tom Tromey  <tom@tromey.com>
2521
2522         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2523         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2524         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2525         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2526         (pspy_set_type_printers): Likewise.
2527         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2528         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2529         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2530         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2531         (objfpy_set_type_printers): Likewise.
2532
2533 2019-01-03  Tom Tromey  <tom@tromey.com>
2534
2535         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2536         (gdbpy_print_stack): Use gdbpy_err_fetch.
2537         * python/python-internal.h (class gdbpy_err_fetch): New class.
2538         (class gdbpy_enter) <m_error_type, m_error_value,
2539         m_error_traceback>: Remove.
2540         <m_error>: New member.
2541         (gdbpy_exception_to_string): Don't declare.
2542         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2543         * python/py-value.c (convert_value_from_python): Use
2544         gdbpy_err_fetch.
2545         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2546         gdbpy_exception_to_string.
2547         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2548         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2549         gdbpy_err_fetch.
2550
2551 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2552
2553         * linux-nat.c (delete_lwp_cleanup): Delete.
2554         (struct lwp_deleter): New struct.
2555         (lwp_info_up): New typedef.
2556         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2557         lwp_info_up.
2558
2559 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2560
2561         * linux-fork.c (class scoped_switch_fork_info): New class.
2562         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2563
2564 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2565
2566         * valops.c (find_overload_match): Remove use of null_cleanup, and
2567         calls to do_cleanups.
2568
2569 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2570
2571         * compile/compile-cplus-types.c
2572         (compile_cplus_instance::decl_name): Handle changes to
2573         cp_func_name.
2574         * cp-support.c (cp_func_name): Update header comment, update
2575         return type.
2576         * cp-support.h (cp_func_name): Update return type in declaration.
2577         * valops.c (find_overload_match): Move temp_func local to top
2578         level of function and change its type.  Use temp_func to hold and
2579         delete temporary string obtained from cp_func_name.
2580
2581 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2582
2583         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2584         gdb::char_vector, remove cleanup, and update uses of `msg`.
2585
2586 2019-01-03  Jim Wilson  <jimw@sifive.com>
2587
2588         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2589
2590 2019-01-02  Tom Tromey  <tom@tromey.com>
2591
2592         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2593         (tdesc_parse_xml): Remove cleanups.
2594         * target-descriptions.h (make_cleanup_free_target_description):
2595         Don't declare.
2596         (target_desc_deleter): New struct.
2597         (target_desc_up): New typedef.
2598         * target-descriptions.c (target_desc_deleter::operator()): Rename
2599         from free_target_description.
2600         (make_cleanup_free_target_description): Remove.
2601
2602 2019-01-02  Tom Tromey  <tom@tromey.com>
2603
2604         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2605         constructor, destructor.
2606         (linespec_parser): Remove typedef.
2607         (~linespec_parser): Rename from linespec_parser_delete.
2608         (linespec_lex_to_end, linespec_complete_label)
2609         (linespec_complete): Update.
2610         (decode_line_full): Remove cleanups.
2611         (decode_line_1): Update.
2612
2613 2019-01-02  Tom Tromey  <tom@tromey.com>
2614
2615         * python/python-internal.h (inferior_to_inferior_object): Change
2616         return type.
2617         * python/py-exitedevent.c (create_exited_event_object): Update.
2618         * python/py-inferior.c (inferior_to_inferior_object): Return
2619         gdbpy_ref.
2620         (python_new_inferior, python_inferior_deleted)
2621         (thread_to_thread_object, delete_thread_object)
2622         (build_inferior_list, gdbpy_selected_inferior): Update.
2623         * python/py-infthread.c (create_thread_object): Update.  Also fail
2624         if inferior_to_inferior_object fails.
2625
2626 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2627
2628         * inferior.h (class inferior) <displaced_step_state>: New field.
2629         * infrun.h (struct displaced_step_state): Move here from
2630         infrun.c.  Initialize fields, add constructor.
2631         <inf>: Remove field.
2632         <reset>: New method.
2633         * infrun.c (struct displaced_step_inferior_state): Move to
2634         infrun.h.
2635         (displaced_step_inferior_states): Remove.
2636         (get_displaced_stepping_state): Adust.
2637         (displaced_step_in_progress_any_inferior): Adjust.
2638         (displaced_step_in_progress_thread): Adjust.
2639         (displaced_step_in_progress): Adjust.
2640         (add_displaced_stepping_state): Remove.
2641         (get_displaced_step_closure_by_addr): Adjust.
2642         (remove_displaced_stepping_state): Remove.
2643         (infrun_inferior_exit): Call displaced_step_state.reset.
2644         (use_displaced_stepping): Don't check for NULL.
2645         (displaced_step_prepare_throw): Call
2646         get_displaced_stepping_state.
2647         (displaced_step_fixup): Don't check for NULL.
2648         (prepare_for_detach): Don't check for NULL.
2649
2650 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2651
2652         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2653          in case of call that did not complete.
2654
2655 2019-01-02  Andrey Utkin  <autkin@undo.io>
2656
2657         * symfile.c (find_separate_debug_file): Fix search of debug files for
2658         remote debuggee.
2659
2660 2019-01-02  Tom Tromey  <tom@tromey.com>
2661
2662         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2663         indentation.
2664         * python/py-frame.c (frapy_older): Remove cast.
2665         (frapy_newer): Likewise.
2666         * python/py-breakpoint.c (local_setattro): Remove cast.
2667         * python/py-arch.c (archpy_name): Remove local variable.
2668         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2669
2670 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2671
2672         * unittests/basic_string_view/element_access/char/empty.cc:
2673         Fix year range in copyright header.
2674
2675 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2676
2677         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2678         Delete.
2679         <operator==>: Update with for removed field.
2680         <hash>: Likewise.
2681         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2682         <isa_features>: ...this.
2683         <abi_features>: New field.
2684         (riscv_isa_flen): Update comment.
2685         (riscv_abi_xlen): New declaration.
2686         (riscv_abi_flen): New declaration.
2687         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2688         isa_features.
2689         (riscv_abi_xlen): New function.
2690         (riscv_isa_flen): Update to get answer from isa_features.
2691         (riscv_abi_flen): New function.
2692         (riscv_has_fp_abi): Update to get answer from abi_features.
2693         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2694         xlen and flen.
2695         (riscv_call_info) <xlen, flen>: Update comment.
2696         (riscv_call_arg_struct): Remove invalid assertions
2697         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2698         is removed.
2699         (riscv_gdbarch_init): Gather isa features and abi features
2700         separately, ensure both match on the gdbarch when reusing an old
2701         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2702         a target with 64-bit float hardware.
2703
2704 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2705
2706         * source.c (search_command_helper): Stop reverse search
2707         when line 1 has been searched.
2708
2709 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2710
2711         * record-full.c (record_full_base_target::close): Rewrite
2712         record_full_core_buf_list free logic.
2713
2714 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2715
2716         * break-catch-syscall.c (print_one_catch_syscall): xfree
2717         the last text.
2718
2719 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2720
2721         * top.c (print_gdb_version): Update Copyright year in version
2722         message.
2723
2724 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2725
2726         Update copyright year range in all GDB files.
2727
2728 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2729
2730         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2731
2732 For older changes see ChangeLog-2018.
2733 \f
2734 Local Variables:
2735 mode: change-log
2736 left-margin: 8
2737 fill-column: 74
2738 version-control: never
2739 coding: utf-8
2740 End:
2741