gdb/ChangeLog

   1 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
   2
   3         * source.c (get_filename_and_charpos): Remove fullname
   4         parameter.
   5         (identify_source_line): Update call to get_filename_and_charpos.
   6
   7 2019-06-14  Tom Tromey  <tromey@adacore.com>
   8
   9         PR gdb/24502:
  10         * ui-style.h (skip_ansi_escape): Update comment.
  11         * ui-file.h (class no_terminal_escape_file): New class.
  12         * ui-file.c (no_terminal_escape_file::write)
  13         (no_terminal_escape_file::puts): New methods.
  14         * cli/cli-logging.c (handle_redirections): Use
  15         no_terminal_escape_file.
  16
  17 2019-06-14  Tom Tromey  <tromey@adacore.com>
  18
  19         * NEWS: Move convenience variable news above Python news.
  20
  21 2019-06-14  Tom Tromey  <tom@tromey.com>
  22
  23         * gnulib: Move directory to top-level.
  24         * configure.ac: Don't configure gnulib.
  25         * configure: Rebuild.
  26         * common/common-defs.h: Use new path to gnulib.
  27         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
  28         (GNULIB_H): Remove.
  29         (INCGNU): Look in new gnulib location.
  30         (HFILES_NO_SRCDIR): Remove gnulib files.
  31         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
  32         (generated_files): Remove GNULIB_H.
  33         ($(LIBGNU), all-lib): Remove targets.
  34         (distclean): Don't mention GNULIB_BUILDDIR.
  35         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
  36
  37 2019-06-14  Tom Tromey  <tromey@adacore.com>
  38
  39         * symfile.c (add_symbol_file_command): Remove obsolete comment.
  40         Warn if symbol file does not provide any symbols.
  41
  42 2019-06-14  Tom Tromey  <tromey@adacore.com>
  43
  44         * source.c (find_and_open_source): Respect basenames_may_differ.
  45
  46 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
  47
  48         * annotate.c (annotate_breakpoints_invalid): Make use of
  49         scoped_restore_terminal_state.
  50         (annotate_frames_invalid): Likewise.
  51
  52 2019-06-14  Tom Tromey  <tromey@adacore.com>
  53
  54         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
  55         allow assignment to an internalvar.
  56
  57 2019-06-14  Tom Tromey  <tromey@adacore.com>
  58
  59         * ada-lex.l: Allow "_" in attribute names.
  60
  61 2019-06-14  Tom Tromey  <tromey@adacore.com>
  62
  63         PR gdb/24653:
  64         * regcache.c (registers_changed): Don't call alloca.
  65         * top.c (execute_command): Don't call alloca.
  66
  67 2019-06-13  Pedro Alves  <palves@redhat.com>
  68
  69         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
  70         'expression'.  When parsing an expression, error out if there's
  71         junk after "unlimited".
  72         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
  73         (do_set_command): Adjust calls to is_unlimited_literal.
  74
  75 2019-06-13  Pedro Alves  <palves@redhat.com>
  76
  77         * compile/compile.c (make_compile_options_def_group): Add braces
  78         around array_view initializer.
  79         * thread.c (make_thread_apply_all_options_def_group)
  80         (make_thread_apply_all_options_def_group): Likewise.
  81
  82 2019-06-13  Pedro Alves  <palves@redhat.com>
  83
  84         * NEWS (New commands): Mention "maint test-options
  85         require-delimiter", "maint test-options unknown-is-error", "maint
  86         test-options unknown-is-operand" and "maint show
  87         test-options-completion-result".
  88         (New command options, command completion): New section.
  89         (Completion improvements): New section.
  90         Mention that you can abbreviate "unlimited".
  91
  92 2019-06-13  Pedro Alves  <palves@redhat.com>
  93
  94         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
  95         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
  96         * unittests/cli-utils-selftests.c (test_parse_flags)
  97         (test_parse_flags_qcs): Delete.
  98         (test_cli_utils): Don't call deleted functions.
  99
 100 2019-06-13  Pedro Alves  <palves@redhat.com>
 101
 102         * thread.c: Include "cli/cli-option.h".
 103         (tp_array_compar_ascending): Global.
 104         (tp_array_compar): Delete function.
 105         (tp_array_compar_ascending, tp_array_compar_descending): New
 106         functions.
 107         (ascending_option_def, qcs_flag_option_def)
 108         (thr_qcs_flags_option_defs)
 109         (make_thread_apply_all_options_def_group)
 110         (make_thread_apply_options_def_group): New.
 111         (thread_apply_all_command): Use gdb::option::process_options.
 112         (thread_apply_command_completer)
 113         (thread_apply_all_command_completer): New.
 114         (thread_apply_command): Use gdb::option::process_options.
 115         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
 116         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
 117         to generate help text of "thread apply".  Adjust "taas"'s help.
 118         * tid-parse.c (tid_range_parser::in_thread_range): New method.
 119         * tid-parse.h (tid_range_parser::in_thread_range): New method.
 120
 121 2019-06-13  Pedro Alves  <palves@redhat.com>
 122
 123         * thread.c (thread_apply_command): Check for invalid TID with
 124         isdigit instead of !isalpha.
 125
 126 2019-06-13  Pedro Alves  <palves@redhat.com>
 127
 128         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
 129         (validate_flags_qcs): New.
 130         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
 131         (validate_flags_qcs): Declare.
 132         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
 133         (make_frame_apply_options_def_group): New.
 134         (frame_apply_command_count): Process options with
 135         gdb::option::process_options.
 136         (frame_apply_completer): New.
 137         (frame_apply_level_completer, frame_apply_all_completer)
 138         (frame_apply_completer): New.
 139         (_initialize_stack): Update help of "frame apply", "frame apply
 140         level", "frame apply all" and "faas" to mention supported options
 141         and install command completers.
 142         * stack.h (frame_apply_all_completer): Declare.
 143         * thread.c: Include "stack.h".
 144         (tfaas_command): Add "--".
 145         (_initialize_thread): Update help "tfaas" to mention supported
 146         options and install command completer.
 147
 148 2019-06-13  Pedro Alves  <palves@redhat.com>
 149
 150         * completer.c (complete_nested_command_line): New.
 151         (gdb_completion_word_break_characters_throw): Add assertion.
 152         * completer.h (complete_nested_command_line): Declare.
 153
 154 2019-06-13  Pedro Alves  <palves@redhat.com>
 155
 156         * stack.c (parse_backtrace_qualifiers): New.
 157         (backtrace_command): Use it.
 158         (backtrace_command_completer): Complete on qualifiers.
 159
 160 2019-06-13  Pedro Alves  <palves@redhat.com>
 161
 162         * frame.c: Include "cli/cli-option.h.
 163         (user_set_backtrace_options): New.
 164         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
 165         Delete.
 166         (get_prev_frame): Adjust.
 167         (boolean_option_def, uinteger_option_def)
 168         (set_backtrace_option_defs): New.
 169         (_initialize_frame): Adjust and use
 170         gdb::option::add_setshow_cmds_for_options to install "set
 171         backtrace past-main" and "set backtrace past-entry".
 172         * frame.h: Include "cli/cli-option.h".
 173         (struct frame_print_options): Forward declare.
 174         (print_frame_arguments_all, print_frame_arguments_scalars)
 175         (print_frame_arguments_none): Declare.
 176         (print_entry_values): Delete declaration.
 177         (struct frame_print_options, user_frame_print_options): New.
 178         (struct set_backtrace_options): New.
 179         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
 180         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
 181         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
 182         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
 183         (list_args_or_locals): Add frame_print_options parameter.
 184         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 185         * python/py-framefilter.c (enumerate_args): Pass down
 186         USER_FRAME_PRINT_OPTIONS.
 187         * stack.c: Include "cli/cli-option.h".
 188         (print_frame_arguments_all, print_frame_arguments_scalars)
 189         (print_frame_arguments_none): Declare.
 190         (print_raw_frame_arguments, print_entry_values): Delete.
 191         (user_frame_print_options): New.
 192         (boolean_option_def, enum_option_def, frame_print_option_defs):
 193         New.
 194         (struct backtrace_cmd_options): New.
 195         (bt_flag_option_def): New.
 196         (backtrace_command_option_defs): New.
 197         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 198         (print_frame_arg, read_frame_arg, print_frame_args)
 199         (print_frame_info, print_frame): Add frame_print_options parameter
 200         and use it.
 201         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
 202         (backtrace_command_1): Add frame_print_options and
 203         backtrace_cmd_options parameters and use them.
 204         (make_backtrace_options_def_group): New.
 205         (backtrace_command): Process command options with
 206         gdb::option::process_options.
 207         (backtrace_command_completer): New.
 208         (_initialize_stack): Extend "backtrace"'s help to mention
 209         supported options.  Install completer for "backtrace".
 210         Install some settings commands with add_setshow_cmds_for_options.
 211
 212 2019-06-13  Pedro Alves  <palves@redhat.com>
 213
 214         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
 215         and that "set/show print raw frame-arguments" are now deprecated.
 216
 217         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
 218         command.
 219         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
 220         * stack.c (_initialize_stack): Install "set/show print
 221         raw-frame-arguments", and deprecate "set/show print raw
 222         frame-arguments".
 223         * valprint.c (_initialize_valprint): Deprecate "set/show print
 224         raw".
 225
 226 2019-06-13  Pedro Alves  <palves@redhat.com>
 227
 228         * compile/compile.c (struct compile_options): New.
 229         (compile_flag_option_def, compile_command_option_defs)
 230         (make_compile_options_def_group): New.
 231         (compile_file_command): Handle options with
 232         gdb::option::process_options.
 233         (compile_file_command_completer): New function.
 234         (compile_code_command): Handle options with
 235         gdb::option::process_options.
 236         (compile_code_command_completer): New function.
 237         (_initialize_compiler): Install completers for "compile code" and
 238         "compile file".  Mention available options in "compile code" and
 239         "compile code"'s help.
 240         * completer.c (advance_to_completion_word): New, factored out from
 241         ...
 242         (advance_to_expression_complete_word_point): ... this.
 243         (advance_to_filename_complete_word_point): New.
 244         * completer.h (advance_to_filename_complete_word_point): New
 245         declaration.
 246
 247 2019-06-13  Pedro Alves  <palves@redhat.com>
 248
 249         * compile/compile.c: Include "cli/cli-option.h".
 250         (compile_print_value): Scope data pointer is now a
 251         value_print_options pointer; adjust.
 252         (compile_print_command): Process options.  Scope data pointer is
 253         now a value_print_options pointer; adjust.
 254         (_initialize_compile): Update "compile print"'s help to include
 255         supported options.  Install a completer for "compile print".
 256         * cp-valprint.c (show_vtblprint, show_objectprint)
 257         (show_static_field_print): Delete.
 258         (_initialize_cp_valprint): Don't install "set print
 259         static-members", "set print vtbl", "set print object" here.
 260         * printcmd.c: Include "cli/cli-option.h" and
 261         "common/gdb_optional.h".
 262         (print_command_parse_format): Rework to fill in a
 263         value_print_options instead of a format_data.
 264         (print_value): Change parameter type from format_data pointer to
 265         value_print_options reference.  Adjust.
 266         (print_command_1): Process options.  Adjust to pass down a
 267         value_print_options.
 268         (print_command_completer): New.
 269         (_initialize_printcmd): Install print_command_completer as
 270         handle_brkchars completer for the "print" command.  Update
 271         "print"'s help to include supported options.
 272         * valprint.c: Include "cli/cli-option.h".
 273         (show_vtblprint, show_objectprint, show_static_field_print): Moved
 274         here from cp-valprint.c.
 275         (boolean_option_def, uinteger_option_def)
 276         (value_print_option_defs, make_value_print_options_def_group):
 277         New.  Use gdb::option::add_setshow_cmds_for_options to install
 278         "set print elements", "set print null-stop", "set print repeats",
 279         "set print pretty", "set print union", "set print array", "set
 280         print address", "set print symbol", "set print array-indexes".
 281         * valprint.h: Include <string> and "cli/cli-option.h".
 282         (make_value_print_options_def_group): Declare.
 283         (print_value): Change parameter type from format_data pointer to
 284         value_print_options reference.
 285         (print_command_completer): Declare.
 286
 287 2019-06-13  Pedro Alves  <palves@redhat.com>
 288
 289         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
 290         (COMMON_SFILES): Add maint-test-settings.c.
 291         * cli/cli-decode.c (boolean_enums): New global, factored out from
 292         ...
 293         (add_setshow_boolean_cmd): ... here.
 294         * cli/cli-decode.h (boolean_enums): Declare.
 295         * cli/cli-option.c: New file.
 296         * cli/cli-option.h: New file.
 297         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
 298         factored out from ...
 299         (parse_cli_boolean_value(const char *)): ... this.
 300         (is_unlimited_literal): Change parameter type to pointer to
 301         pointer.  Adjust and advance ARG pointer.
 302         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 303         (parse_cli_var_enum): New, factored out from ...
 304         (do_set_command): ... this.  Adjust.
 305         * cli/cli-setshow.h (parse_cli_boolean_value)
 306         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 307         (parse_cli_var_enum): Declare.
 308         * cli/cli-utils.c: Include "cli/cli-option.h".
 309         (get_ulongest): New.
 310         * cli/cli-utils.h (get_ulongest): Declare.
 311         (check_for_argument): New overloads.
 312         * maint-test-options.c: New file.
 313
 314 2019-06-13  Pedro Alves  <palves@redhat.com>
 315
 316         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
 317         parse a range if "-" is at the end of the string.
 318
 319 2019-06-13  Pedro Alves  <palves@redhat.com>
 320
 321         * cli/cli-setshow.c (parse_auto_binary_operation)
 322         (parse_cli_boolean_value): Don't allow "o".
 323
 324 2019-06-13  Pedro Alves  <palves@redhat.com>
 325
 326         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
 327         * NEWS: Mention maint test-settings KIND.
 328         * maint-test-settings.c: New file.
 329
 330 2019-06-13  Pedro Alves  <palves@redhat.com>
 331
 332         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
 333         completer.
 334         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
 335         "set" completers.
 336
 337 2019-06-13  Pedro Alves  <palves@redhat.com>
 338
 339         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
 340         after item.
 341
 342 2019-06-13  Pedro Alves  <palves@redhat.com>
 343
 344         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
 345
 346 2019-06-13  Pedro Alves <palves@redhat.com>
 347
 348         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
 349         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
 350         call.
 351         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
 352         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
 353         calls.
 354         (check_for_argument): Skip spaces after argument.
 355
 356 2019-06-13  Pedro Alves  <palves@redhat.com>
 357
 358         * thread.c (thread_apply_command): Adjust TID parsing.
 359         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
 360         detected before end of string.
 361         (tid_is_in_list): Error out if LIST is invalid.
 362
 363 2019-06-13  Pedro Alves  <palves@redhat.com>
 364
 365         * completer.c (complete_line_internal_1): Rewind completion word
 366         point.
 367         (completion_tracker::advance_custom_word_point_by): Change
 368         parameter type to int.
 369         * completer.h (completion_tracker::advance_custom_word_point_by):
 370         Likewise.
 371
 372 2019-06-13  Pedro Alves  <palves@redhat.com>
 373
 374         * completer.c (advance_to_completion_word): Handle delimiters.
 375
 376 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
 377
 378         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
 379
 380 2019-06-11  Tom Tromey  <tom@tromey.com>
 381
 382         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
 383         (xmalloc_failed): Move to alloc.c.
 384         * alloc.c: New file.
 385         * Makefile.in (COMMON_SFILES): Add alloc.c.
 386
 387 2019-06-11  Tom Tromey  <tom@tromey.com>
 388
 389         * nat/linux-waitpid.c: Don't include server.h.
 390         (linux_debug): Remove.
 391         (my_waitpid): Update.
 392
 393 2019-06-11  Tom Tromey  <tromey@adacore.com>
 394
 395         * infcall.c (_initialize_infcall): Remove trailing newline from
 396         help.
 397         * user-regs.c (_initialize_user_regs): Remove trailing newline
 398         from help.
 399         * typeprint.c (_initialize_typeprint): Remove trailing newline
 400         from help.
 401         * reverse.c (_initialize_reverse): Remove trailing newlines from
 402         help.
 403         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
 404         from help.
 405         * language.c (add_set_language_command): Remove trailing newline
 406         from help.
 407         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
 408         help.
 409         * disasm.c (_initialize_disasm): Remove trailing newline from
 410         help.
 411         * top.c (init_main): Remove trailing newline from help.
 412         * interps.c (_initialize_interpreter): Remove trailing newline
 413         from help.
 414         * btrace.c (_initialize_btrace): Remove trailing newlines from
 415         help.
 416         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
 417         from help.
 418         * python/python.c (_initialize_python): Remove trailing newline
 419         from help.
 420         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
 421         help.
 422         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
 423         from help.  Reformat some text.
 424         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
 425         from help.
 426         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
 427         newline from help.
 428
 429 2019-06-11  Tom Tromey  <tromey@adacore.com>
 430
 431         * darwin-nat.c (darwin_decode_exception_message)
 432         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
 433
 434 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 435
 436         * valops.c (value_slice): Check for not allocated or not
 437         associated values.
 438
 439 2019-06-10  Tom de Vries  <tdevries@suse.de>
 440
 441         PR gdb/24618
 442         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
 443         sure an empty slot (defined by a 32-bit zero pair) is recognized as
 444         invalid.
 445
 446 2019-06-10  Tom de Vries  <tdevries@suse.de>
 447
 448         PR gdb/24611
 449         * linespec.c (linespec_lexer_lex_string): Remove incorrect
 450         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
 451
 452 2019-06-10  Tom de Vries  <tdevries@suse.de>
 453
 454         PR symtab/24545
 455         * symtab.c (struct demangled_name_entry): Add language field.
 456         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
 457         static minimal symbol".  Set and use language field.
 458
 459 2019-06-10  Tom Tromey  <tromey@adacore.com>
 460
 461         * ada-lang.c (_initialize_ada_language): Update help text.
 462
 463 2019-06-10  Tom Tromey  <tromey@adacore.com>
 464
 465         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
 466         with a newline.
 467         * guile/guile.c (handle_boot_error): Don't end warning with a
 468         newline.
 469         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
 470         warning with a newline.
 471         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
 472         newline.
 473         (s12z_frame_cache): Likewise.
 474         * dwarf-index-cache.c (index_cache::store): Don't end warning with
 475         a newline.
 476         * solib-svr4.c (disable_probes_interface): Don't end warning with
 477         a newline.
 478         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
 479         newline.
 480         * python/python.c (do_finish_initialization): Don't end warning
 481         with a newline.
 482
 483 2019-06-10  Tom Tromey  <tom@tromey.com>
 484
 485         * python/py-breakpoint.c (gdbpy_breakpoint_created)
 486         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
 487         gdbpy_enter.
 488
 489 2019-06-10  Tom Tromey  <tromey@adacore.com>
 490
 491         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
 492         data.
 493         (elf_new_init): Don't call stabsread_new_init.
 494         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
 495         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
 496         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
 497
 498 2019-06-10  Tom de Vries  <tdevries@suse.de>
 499
 500         PR symtab/16264
 501         PR symtab/24517
 502         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
 503
 504 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
 505
 506         * source.c (find_and_open_source): Also rewrite relative file
 507         names.
 508
 509 2019-04-26  Amos Bird  <amosbird@gmail.com>
 510
 511         * annotate.c (annotate_thread_exited): Add "thread-exited"
 512         annotation.
 513
 514 2019-06-06  Tom Tromey  <tromey@adacore.com>
 515
 516         * maint.h (class scoped_command_stats): Use
 517         DISABLE_COPY_AND_ASSIGN.
 518         <print_time>: New method.
 519         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
 520         print_time.
 521         (scoped_command_stats::print_time): New method.
 522
 523 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 524
 525         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
 526         instructions of lengths 6 or 8 bytes.
 527
 528 2019-06-04  Pedro Alves  <palves@redhat.com>
 529
 530         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
 531
 532         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
 533         * breakpoint.c (condition_completer): Likewise.
 534         * cli/cli-dump.c (scan_expression): Likewise.
 535         * common/filestuff.c (mkdir_recursive): Likewise.
 536         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
 537         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
 538         (gdb_abspath): Likewise.
 539         * compile/compile-cplus-types.c
 540         (compile_cplus_instance::decl_name): Likewise.
 541         * completer.c (complete_explicit_location):
 542         (signal_completer, reg_or_group_completer_1): Likewise.
 543         * cp-support.c (cp_remove_params_if_any): Likewise.
 544         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
 545         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
 546         * infcmd.c (strip_bg_char): Likewise.
 547         * linespec.c (copy_token_string): Likewise.
 548         * mi/mi-main.c (output_cores): Likewise.
 549         * psymtab.c (psymtab_search_name):
 550         * symfile.c (test_set_ext_lang_command): Likewise.
 551         * target.c (target_fileio_read_stralloc): Likewise.
 552         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
 553         * value.c (complete_internalvar): Likewise.
 554
 555 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
 556
 557         Add objfile property to gdb.Type.
 558         * NEWS: Mention Python API addition.
 559         * python/py-type.c (typy_get_objfile): New method.
 560
 561 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 562
 563         * NEWS: Mention the new set|show style [title|highlight].
 564         Mention changes to "show style", "help" and "apropos".
 565
 566 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 567
 568         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
 569         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
 570         instead of print_help_for_command.
 571         (print_doc_of_command): New function.
 572         (help_list): Add 'apropos -v word' suggestion.
 573         (print_help_for_command): Style the command name using title style.
 574         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
 575         (_initialize_cli_cmds): Describe -v in apropos_command help.
 576
 577 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 578
 579         * cli/cli-style.h (cli_style_option): Add name in constructor,
 580         add m_name class member, add constructor with intensity,
 581         add name class function.
 582         (cli_style_option::add_setshow_commands): Remove name argument.
 583         (highlight_style, title_style): New styles.
 584         * cli/cli-style.c (do_show): New function that shows a style
 585         characteristic styling the style name with itself.
 586         (set_style_name): New function.
 587         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
 588         Update all callers according to the changes in cli/cli-style.h.
 589         * utils.h (fputs_highlighted): New function.
 590         * utils.c (fputs_highlighted): Likewise.
 591
 592 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 593
 594         * NEWS: Mention new pipe command and new convenience variables.
 595
 596 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 597
 598         * cli/cli-cmds.c (pipe_command): New function.
 599         (_initialize_cli_cmds): Call add_com for pipe_command.
 600         Define | as an alias for pipe.
 601         (exit_status_set_internal_vars): New function.
 602         (shell_escape): Call exit_status_set_internal_vars.
 603         cli/cli-decode.c (find_command_name_length): Recognize | as
 604         a single character command.
 605
 606 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 607
 608         * gdbcmd.h (execute_command_to_ui_file): New declaration.
 609         top.c (execute_command_to_ui_file): New function, mostly a copy
 610         of execute_command_to_string.
 611         (execute_command_to_string): Implement by calling
 612         execute_command_to_ui_file.
 613
 614 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 615
 616         * top.h (saved_command_line): Remove declaration.
 617         * top.c (previous_saved_command_line, previous_repeat_arguments):
 618         New variables.
 619         (saved_command_line): Make static, define together with other
 620         'repeat variables'.
 621         (dont_repeat): Clear repeat_arguments.
 622         (repeat_previous, get_saved_command_line, save_command_line):
 623         New functions.
 624         (gdb_init): Initialize saved_command_line
 625         and previous_saved_command_line.
 626         * main.c (captured_main_1): Remove saved_command_line initialization.
 627         * event-top.c (handle_line_of_input): Update to use
 628         the new 'repeat' related functions instead of direct access to
 629         saved_command_line.
 630         * command.h (repeat_previous, get_saved_command_line,
 631         save_command_line): New declarations.
 632         (dont_repeat): Add comment.
 633
 634 2019-05-30  Tom Tromey  <tromey@adacore.com>
 635
 636         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
 637         Fix comment.
 638         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
 639
 640 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
 641
 642         PR cli/24587
 643         * completer.c (complete): Initialize variable word.
 644
 645 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
 646
 647         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 648         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
 649         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
 650         'body' is NULL to the outter 'if', protecting the '!is_define'
 651         situation as well.
 652
 653 2019-05-29  Tom Tromey  <tromey@adacore.com>
 654
 655         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
 656         (dwarf_unknown): New function.
 657         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
 658         (dwarf_type_encoding_name): Use dwarf_unknown.
 659
 660 2019-05-29  Tom Tromey  <tromey@adacore.com>
 661
 662         PR c++/20020:
 663         * cp-valprint.c (cp_print_value_fields): Call
 664         cp_print_static_field inside "try".
 665
 666 2019-05-29  Tom Tromey  <tromey@adacore.com>
 667
 668         * inflow.c (struct terminal_info): Add default operator=.
 669         * configure: Rebuild.
 670         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
 671         -Wdeprecated-copy-dtor, -Wredundant-move.
 672
 673 2019-05-29  Tom Tromey  <tromey@adacore.com>
 674
 675         * NEWS: Add entry.
 676         * infcmd.c (print_return_value_1): Handle finish_print
 677         option.
 678         (show_print_finish): New function.
 679         (_initialize_infcmd): Add "set/show print finish" commands.
 680         * valprint.c (user_print_options): Initialize new member.
 681         * valprint.h (struct value_print_options) <finish_print>: New
 682         member.
 683
 684 2019-05-28  Tom Tromey  <tromey@adacore.com>
 685
 686         * ada-lang.c (ada_remove_Xbn_suffix)
 687         (find_old_style_renaming_symbol)
 688         (parse_old_style_renaming): Remove.
 689         (ada_find_renaming_symbol): Don't call
 690         find_old_style_renaming_symbol.
 691         (ada_is_renaming_symbol): Rename from
 692         ada_find_renaming_symbol.  Remove "block" parameter.  Return
 693         bool.  Now static.
 694         (ada_read_var_value): Update and simplify.
 695         * ada-exp.y (write_var_or_type): Remove old code.
 696
 697 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
 698
 699         * event-top.c: Remove include comment.
 700         * inflow.c (class scoped_ignore_sigttou): Move from here...
 701         * inflow.h (class scoped_ignore_sigttou): ...to here.
 702         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
 703         * top.c:  Remove include comment.
 704
 705 2019-05-27  Tom Tromey  <tom@tromey.com>
 706
 707         * NEWS: Fix typo.
 708
 709 2019-05-22  Tom Tromey  <tromey@adacore.com>
 710
 711         * target.c (target_follow_exec): Constify parameter.
 712         * target-delegates.c: Rebuild.
 713         * remote.c (remote_target::follow_exec): Constify parameter.
 714         * infrun.c (follow_exec): Constify parameter.
 715         * target.h (struct target_ops) <follow_exec>: Constify parameter.
 716         (target_follow_exec): Likewise.
 717
 718 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 719
 720         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
 721         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
 722
 723 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 724
 725         * NEWS: Add debugredirect and testsuite sections.
 726
 727 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
 728
 729         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
 730         target descriptions using exclusively floating point register name
 731         aliases.
 732
 733 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 734
 735         PR gdb/18644:
 736         * f-lang.c (build_fortran_types): Handle the case where
 737         gdbarch_floatformat_for_type returns a nullptr.
 738
 739 2019-05-21  Tom de Vries  <tdevries@suse.de>
 740
 741         PR cli/24587
 742         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
 743
 744 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 745
 746         PR gdb/18644:
 747         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
 748         16-byte floats.
 749         * i386-tdep.c (i386_floatformat_for_type): Use
 750         floatformats_ia64_quad for the 16-byte floating point component
 751         within a fortran 32-byte complex number.
 752
 753 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 754
 755         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
 756         delete default constructor.
 757         (find_partial_die): Update to return const struct.
 758         (partial_die_parent_scope): Move variable declaration into scope
 759         of its use and change its type to auto.
 760         (guess_partial_die_structure_name): Likewise.
 761         (partial_die_info::fixup): Likewise.
 762
 763 2019-05-17  Tom Tromey  <tromey@adacore.com>
 764
 765         * source.c (find_and_open_source): Remove cast.
 766
 767 2019-05-17  Tom Tromey  <tromey@adacore.com>
 768
 769         * annotate.c (annotate_source): Make "filename" const.
 770         * annotate.h (annotate_source): Use const.
 771
 772 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 773
 774         * disasm.c (set_disassembler_options): Send errors to stderr.
 775
 776 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 777
 778         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
 779         (cli_interp_base::set_logging): Check debug_redirect.
 780         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
 781         * cli/cli-logging.c (debug_redirect): Add static variable.
 782         (pop_output_files): Add default param.
 783         (handle_redirections): Print debug setting.
 784         (show_logging_command): Likewise.
 785         (_initialize_cli_logging): Add debugredirect command.
 786         * interps.c (current_interp_set_logging): Add debug_redirect
 787         parameter.
 788         * interps.h (set_logging): Add debug_redirect parameter.
 789         (current_interp_set_logging): Likewise.
 790         * mi/mi-common.h: Likewise.
 791         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
 792
 793 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 794             Tom Tromey  <tromey@adacore.com>
 795
 796         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
 797         directly.
 798         * cli/cli-interp.h (make_logging_output): Remove declaration.
 799         * cli/cli-logging.c (make_logging_output): Remove function.
 800         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
 801         directly.
 802         * ui-file.c (tee_file::tee_file): Remove bools.
 803         (tee_file::~tee_file): Remove deletes.
 804         * ui-file.h (tee_file): Remove bools.
 805
 806 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
 807
 808         * mi/mi-cmds.h (mi_cmd_complete): New function.
 809         * mi/mi-main.c (mi_cmd_complete): Likewise.
 810         * mi/mi-cmds.c: Define new MI command -complete.
 811         * NEWS: Mention new -complete command.
 812
 813 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
 814
 815         * completer.h (complete): New function.
 816         * completer.c (complete): Likewise.
 817         * cli/cli-cmds.c: (complete_command): Update to use new complete()
 818         function defined in completer.h.
 819
 820 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
 821
 822        * MAINTAINERS (Write After Approval): Add myself.
 823
 824 2019-05-17  Tom de Vries  <tdevries@suse.de>
 825
 826         PR gdb/24094
 827         * dwarf2read.c (struct cu_partial_die_info): New struct.
 828         (find_partial_die): Return cu_partial_die_info.
 829         (partial_die_parent_scope, guess_partial_die_structure_name)
 830         (partial_die_info::fixup): Handle new return type of find_partial_die.
 831
 832 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 833
 834         * stap-probe.c (stap_parse_register_operand): Make "regname" an
 835         "std::string", simplifying the algorithm.
 836
 837 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 838
 839         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
 840         (stap_static_probe_ops::get_probes): Likewise.
 841
 842 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 843
 844         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
 845         '-')" and "else if".
 846         (stap_parse_single_operand): Join checks for
 847         "gdbarch_stap_parse_special_token_p" and
 848         "gdbarch_stap_parse_special_token" in the same "if" statement.
 849         Invert check when verifying for operation on register
 850         displacement.
 851
 852 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 853
 854         * stap-probe.c (stap_get_opcode): Update comment.
 855         (stap_get_expected_argument_type): Likewise.
 856         (handle_stap_probe): Likewise.
 857
 858 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 859
 860         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
 861         return type to 'bool'.  Adjust comment.  Use 'bool' when
 862         appropriate.
 863         (i386_stap_parse_special_token_three_arg_disp): Likewise.
 864         * stap-probe.c (stap_parse_argument_1): Likewise.
 865         (stap_is_operator): Likewise.
 866         (stap_is_generic_prefix): Likewise.
 867         (stap_is_register_prefix): Likewise.
 868         (stap_is_register_indirection_prefix): Likewise.
 869         (stap_is_integer_prefix): Likewise.
 870         (stap_generic_check_suffix): Likewise.
 871         (stap_check_integer_suffix): Likewise.
 872         (stap_check_register_suffix): Likewise.
 873         (stap_check_register_indirection_suffix): Likewise.
 874         (stap_parse_register_operand): Likewise.
 875         (stap_parse_single_operand): Likewise.
 876         (stap_parse_argument_1): Likewise.
 877         (stap_probe::get_argument_count): Likewise.
 878         (stap_is_operator): Likewise.
 879
 880 2019-05-16  Tom Tromey  <tromey@adacore.com>
 881
 882         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
 883         keyword to foreach.
 884
 885 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
 886
 887         * linux-thread-db.c (try_thread_db_load_1): Change return type
 888         to bool.
 889         (try_thread_db_load): Likewise.
 890         (try_thread_db_load_from_pdir_1): Likewise.
 891         (try_thread_db_load_from_pdir): Likewise.
 892         (try_thread_db_load_from_sdir): Likewise.
 893         (try_thread_db_load_from_dir): Likewise.
 894         (thread_db_load_search): Likewise.
 895         (has_libpthread): Likewise.
 896         (thread_db_load): Likewise.
 897
 898 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
 899
 900         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 901         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
 902         NULL, and complain/return if that's the case.
 903
 904 2019-05-15  John Darrington <john@darrington.wattle.id.au>
 905
 906         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
 907         (advance, posn, abstract_read_memory): New functions.
 908         [struct mem_read_abstraction]: New struct.
 909         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
 910
 911 2019-05-14  Tom Tromey  <tromey@adacore.com>
 912
 913         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
 914         value is not lval_memory.
 915
 916 2019-05-14  Tom Tromey  <tromey@adacore.com>
 917
 918         * solib.c (info_sharedlibrary_command): Style the file name.
 919
 920 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
 921
 922         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
 923         (aarch64_vnv_type): Likewise.
 924         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
 925         * common/tdesc.c: Likewise.
 926         * common/tdesc.h (enum tdesc_type_kind): Likewise.
 927         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
 928         * features/aarch64-fpu.xml: Add ieee half view.
 929         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
 930         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
 931         * gdbtypes.h (struct builtin_type): Likewise.
 932         (struct objfile_type): Likewise.
 933
 934 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
 935
 936         * language.c (language_sniff_from_mangled_name): Fix "langauge"
 937         typo.
 938         * location.h (string_to_event_location): Likewise.
 939
 940 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
 941
 942         GDB 8.3 released.
 943
 944 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 945
 946         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
 947         New variable declaration.
 948         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
 949         New variable.
 950         (print_one_breakpoint): Use ui_out::test_flags and new global
 951         variable to compute use_fixed_output.
 952         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
 953         Remove.
 954         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
 955         (mi_multi_location_breakpoint_output_fixed): Remove.
 956         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
 957         new variable.
 958         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
 959         fix_multi_location_breakpoint_output flag if version >= 3.
 960         * ui-out.h (enum ui_out_flag)
 961         <fix_multi_location_breakpoint_output>: New enumerator.
 962
 963 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 964
 965         * contrib/cc-with-tweaks.sh: Validate dwz's work.
 966
 967 2019-05-10  Tom Tromey  <tromey@adacore.com>
 968
 969         * ada-lang.c (catch_ada_completer): New function.
 970         (_initialize_ada_language): Use it.
 971
 972 2019-05-10  Tom Tromey  <tromey@adacore.com>
 973
 974         * thread.c (print_thread_info): Make "requested_threads" const.
 975         * gdbthread.h (print_thread_info): Make "requested_threads"
 976         const.
 977         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
 978         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
 979
 980 2019-05-08  Tom Tromey  <tom@tromey.com>
 981
 982         * gdbtypes.c (objfile_type_data): Change type.
 983         (objfile_type, _initialize_gdbtypes): Update.
 984
 985 2019-05-08  Tom Tromey  <tom@tromey.com>
 986
 987         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
 988         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
 989         (_initialize_dwarf2_frame): Update.
 990
 991 2019-05-08  Tom Tromey  <tom@tromey.com>
 992
 993         * objc-lang.c (objc_objfile_data): Change type.
 994         (find_methods): Update.
 995         (_initialize_objc_lang): Remove.
 996
 997 2019-05-08  Tom Tromey  <tom@tromey.com>
 998
 999         * stabsread.c (rs6000_builtin_type_data): Change type.
1000         (rs6000_builtin_type, _initialize_stabsread): Update.
1001
1002 2019-05-08  Tom Tromey  <tom@tromey.com>
1003
1004         * mips-tdep.c (mips_pdr_data): Remove.
1005         (_initialize_mips_tdep): Update.
1006
1007 2019-05-08  Tom Tromey  <tom@tromey.com>
1008
1009         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
1010         (hppa_init_objfile_priv_data, read_unwind_info)
1011         (find_unwind_entry, _initialize_hppa_tdep): Update.
1012
1013 2019-05-08  Tom Tromey  <tom@tromey.com>
1014
1015         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
1016         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
1017         on obstack.
1018         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
1019
1020 2019-05-08  Tom Tromey  <tom@tromey.com>
1021
1022         * mdebugread.c (basic_type_data): Change type.
1023         (basic_type, _initialize_mdebugread): Update.
1024
1025 2019-05-08  Tom Tromey  <tom@tromey.com>
1026
1027         * common/gdb_unique_ptr.h (struct noop_deleter): New.
1028
1029 2019-05-08  Tom Tromey  <tom@tromey.com>
1030
1031         * nto-tdep.c (nto_inferior_data_reg): Change type.
1032         (nto_inferior_data): Update.
1033         (nto_inferior_data_cleanup, nto_new_inferior_data)
1034         (_initialize_nto_tdep): Remove.
1035         * nto-tdep.h (struct nto_inferior_data): Add initializers.
1036
1037 2019-05-08  Tom Tromey  <tom@tromey.com>
1038
1039         * ada-lang.c (struct ada_inferior_data): Add initializers.
1040         (ada_inferior_data): Change type.
1041         (ada_inferior_data_cleanup): Remove.
1042         (get_ada_inferior_data, ada_inferior_exit)
1043         (struct ada_pspace_data): Add initializers, destructor.
1044         (ada_pspace_data_handle): Change type.
1045         (get_ada_pspace_data): Update.
1046         (ada_pspace_data_cleanup): Remove.
1047
1048 2019-05-08  Tom Tromey  <tom@tromey.com>
1049
1050         * coffread.c (struct coff_symfile_info): Add initializers.
1051         (coff_objfile_data_key): Move lower.  Change type.
1052         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
1053         Update.
1054         (coff_free_info): Remove.
1055
1056 2019-05-08  Tom Tromey  <tom@tromey.com>
1057
1058         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
1059         (fbsd_pspace_data_handle): Move lower.  Change type.
1060         (get_fbsd_pspace_data): Update.
1061         (fbsd_pspace_data_cleanup): Remove.
1062         (_initialize_fbsd_tdep): Update.
1063
1064 2019-05-08  Tom Tromey  <tom@tromey.com>
1065
1066         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
1067         (get_ada_tasks_pspace_data): Update.
1068         (ada_tasks_pspace_data_cleanup): Remove.
1069         (_initialize_tasks): Update.
1070         (ada_tasks_inferior_data_handle): Change type.
1071         (get_ada_tasks_inferior_data): Update.
1072         (ada_tasks_inferior_data_cleanup): Remove.
1073         (struct ada_tasks_pspace_data): Add initializers.
1074
1075 2019-05-08  Tom Tromey  <tom@tromey.com>
1076
1077         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
1078         * symfile-debug.c (debug_sym_get_probes): Change type.
1079         * stap-probe.c (handle_stap_probe):
1080         (stap_static_probe_ops::get_probes): Change type.
1081         * probe.h (class static_probe_ops) <get_probes>: Change type.
1082         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1083         (parse_probes_in_pspace): Update.
1084         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1085         Update.
1086         (any_static_probe_ops::get_probes): Change type.
1087         * elfread.c (elfread_data): New typedef.
1088         (probe_key): Change type.
1089         (elf_get_probes): Likewise.  Update.
1090         (probe_key_free): Remove.
1091         (_initialize_elfread): Update.
1092         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1093         Change type.
1094         (dtrace_process_dof_probe, dtrace_process_dof)
1095         (dtrace_static_probe_ops::get_probe): Change type.
1096
1097 2019-05-08  Tom Tromey  <tom@tromey.com>
1098
1099         * xcoffread.c (struct xcoff_symfile_info): Rename from
1100         coff_symfile_info.  Add initializers.
1101         (xcoff_objfile_data_key): Move lower.  Change type.
1102         (XCOFF_DATA): Rewrite.
1103         (xcoff_free_info): Remove.
1104         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1105         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1106         (xcoff_initial_scan): Update.
1107
1108 2019-05-08  Tom Tromey  <tom@tromey.com>
1109
1110         * solib-svr4.c (struct svr4_info): Add initializers and
1111         destructor.
1112         <probes_table>: Now an htab_up.
1113         (solib_svr4_pspace_data): Change type.
1114         (free_probes_table): Simplify.
1115         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1116         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1117         (probes_table_remove_objfile_probes, register_solib_event_probe)
1118         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1119         (_initialize_svr4_solib): Update.
1120
1121 2019-05-08  Tom Tromey  <tom@tromey.com>
1122
1123         * remote.c (remote_pspace_data): Change type.
1124         (remote_pspace_data_cleanup): Remove.
1125         (get_remote_exec_file, set_pspace_remote_exec_file)
1126         (_initialize_remote): Update.
1127
1128 2019-05-08  Tom Tromey  <tom@tromey.com>
1129
1130         * breakpoint.c (breakpoint_objfile_key): Change type.
1131         (get_breakpoint_objfile_data): Update.
1132         (free_breakpoint_objfile_data): Remove.
1133         (_initialize_breakpoint): Update.
1134
1135 2019-05-08  Tom Tromey  <tom@tromey.com>
1136
1137         * linux-tdep.c (struct linux_info): Add initializers.
1138         (linux_inferior_data): Move.  Change type.
1139         (invalidate_linux_cache_inf): Update.
1140         (linux_inferior_data_cleanup): Remove.
1141         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1142
1143 2019-05-08  Tom Tromey  <tom@tromey.com>
1144
1145         * auxv.c (auxv_inferior_data): Move.  Change type.
1146         (auxv_inferior_data_cleanup): Remove.
1147         (invalidate_auxv_cache_inf): Rewrite.
1148         (get_auxv_inferior_data, _initialize_auxv): Update.
1149
1150 2019-05-08  Tom Tromey  <tom@tromey.com>
1151
1152         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1153         (symfile_debug_objfile_data_key): Change type.
1154         (symfile_debug_installed, debug_qf_has_symbols)
1155         (debug_qf_find_last_source_symtab)
1156         (debug_qf_forget_cached_source_info)
1157         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1158         (debug_qf_print_stats, debug_qf_dump)
1159         (debug_qf_expand_symtabs_for_function)
1160         (debug_qf_expand_all_symtabs)
1161         (debug_qf_expand_symtabs_with_fullname)
1162         (debug_qf_map_matching_symbols)
1163         (debug_qf_expand_symtabs_matching)
1164         (debug_qf_find_pc_sect_compunit_symtab)
1165         (debug_qf_map_symbol_filenames)
1166         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1167         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1168         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1169         (debug_sym_read_linetable, debug_sym_relocate): Update.
1170         (symfile_debug_free_objfile): Remove.
1171         (install_symfile_debug_logging, _initialize_symfile_debug):
1172         Update.
1173
1174 2019-05-08  Tom Tromey  <tom@tromey.com>
1175
1176         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1177         allocate_on_obstack.
1178         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1179         (get_dwarf2_per_objfile): Update.
1180         (set_dwarf2_per_objfile): Remove.
1181         (dwarf2_has_info, dwarf2_get_section_info): Update.
1182         (dwarf2_free_objfile): Remove.
1183         (_initialize_dwarf2_read): Update.
1184
1185 2019-05-08  Tom Tromey  <tom@tromey.com>
1186
1187         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1188         initializers.
1189         <unsupported_script_warning_printed,
1190         script_not_found_warning_printed>: Now bool.
1191         (auto_load_pspace_data): Change type.
1192         (~auto_load_pspace_info): Rename from
1193         auto_load_pspace_data_cleanup.
1194         (get_auto_load_pspace_data, init_loaded_scripts_info)
1195         (clear_section_scripts, maybe_print_unsupported_script_warning)
1196         (maybe_print_script_not_found_warning, _initialize_auto_load):
1197         Update.
1198
1199 2019-05-08  Tom Tromey  <tom@tromey.com>
1200
1201         * objfiles.c (objfile_pspace_info): Add destructor and
1202         initializers.
1203         (objfiles_pspace_data): Change type.
1204         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
1205         (get_objfile_pspace_data): Update.
1206         (objfiles_bfd_data): Change type.
1207         (get_objfile_bfd_data): Update.
1208         (objfile_bfd_data_free, _initialize_objfiles): Remove.
1209
1210 2019-05-08  Tom Tromey  <tom@tromey.com>
1211
1212         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1213         Change type.
1214         (get_catch_syscall_inferior_data): Update.
1215         (catch_syscall_inferior_data_cleanup): Remove.
1216         (_initialize_break_catch_syscall): Update.
1217
1218 2019-05-08  Tom Tromey  <tom@tromey.com>
1219
1220         * inflow.c (struct terminal_info): Add destructor and
1221         initializers.
1222         (inflow_inferior_data): Change type.
1223         (~terminal_info): Rename from inflow_inferior_data_cleanup.
1224         (get_inflow_inferior_data, inflow_inferior_exit)
1225         (swap_terminal_info, _initialize_inflow): Update.
1226
1227 2019-05-08  Tom Tromey  <tom@tromey.com>
1228
1229         * target-dcache.c (target_dcache_cleanup): Remove.
1230         (target_dcache_aspace_key): Change type.
1231         (target_dcache_init_p, target_dcache_invalidate)
1232         (target_dcache_get, target_dcache_get_or_init)
1233         (_initialize_target_dcache): Update.
1234         * dcache.h (struct dcache_deleter): New.
1235
1236 2019-05-08  Tom Tromey  <tom@tromey.com>
1237
1238         * symtab.c (struct symbol_cache): Add destructor and
1239         initializers.
1240         (symbol_cache_key): Move.  Change type.
1241         (make_symbol_cache, free_symbol_cache): Remove.
1242         (get_symbol_cache): Update.
1243         (symbol_cache_cleanup): Remove.
1244         (ALL_PSPACES, symbol_cache_flush)
1245         (maintenance_print_symbol_cache)
1246         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1247         Update.
1248
1249 2019-05-08  Tom Tromey  <tom@tromey.com>
1250
1251         * symtab.c (struct main_info): Add destructor and initializers.
1252         (main_progspace_key): Move.  Change type.
1253         (get_main_info): Update.
1254         (main_info_cleanup): Remove.
1255         (_initialize_symtab): Update.
1256
1257 2019-05-08  Tom Tromey  <tom@tromey.com>
1258
1259         * registry.h (DECLARE_REGISTRY): Define the _key class.
1260
1261 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1262
1263         * NEWS: Merge two 'New commands' sections.
1264
1265 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
1266
1267         * ada-valprint.c (ada_val_print_gnat_array): Remove language
1268         parameter and use Ada language definition instead.
1269         (ada_val_print_ptr): Remove unused language parameter.
1270         (ada_val_print_num): Remove language parameter and use Ada language
1271         definition instead.
1272         (ada_val_print_enum, ada_val_print_flt): Remove unused language
1273         parameter.
1274         (ada_val_print_struct_union, ada_val_print_ref): Remove language
1275         parameter and use Ada language definition instead.
1276         (ada_val_print_1): Update all ada_val_print_xxx calls.
1277         Remove language parameter.
1278         (ada_val_print): Update ada_val_print_1 call.
1279
1280 2019-05-08  Tom Tromey  <tromey@adacore.com>
1281
1282         * remote.c (remote_hw_watchpoint_limit)
1283         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
1284         Now static.
1285
1286 2019-05-08  Tom Tromey  <tromey@adacore.com>
1287
1288         * maint.c (_initialize_maint_cmds): Move initialization code to
1289         remote.c.
1290         (watchdog, show_watchdog): Move to remote.c.
1291         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1292         "watchdog" static.
1293         (_initialize_remote): Move initialization code from maint.c.
1294         * defs.h (watchdog): Don't declare.
1295
1296 2019-05-08  Tom Tromey  <tromey@adacore.com>
1297
1298         * tui/tui-interp.c: Include main.h.
1299         * interps.c: Include main.h.
1300         * main.h (interpreter_p): Declare.
1301         * defs.h (interpreter_p): Don't declare.
1302
1303 2019-05-08  Tom Tromey  <tromey@adacore.com>
1304
1305         * dwarf2loc.c: Include dwarf2read.h.
1306         * defs.h (read_unsigned_leb128): Don't declare.
1307         * dwarf2read.h (read_unsigned_leb128): Declare.
1308
1309 2019-05-08  Tom Tromey  <tromey@adacore.com>
1310
1311         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1312         method.
1313
1314 2019-05-08  Tom Tromey  <tromey@adacore.com>
1315
1316         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1317         when no wrap column is set.
1318
1319 2019-05-08  Tom Tromey  <tromey@adacore.com>
1320
1321         * c-lang.c (c_get_string): Handle non-C-style arrays.
1322
1323 2019-05-08  Tom Tromey  <tromey@adacore.com>
1324
1325         * typeprint.c (print_offset_data::update): Print the bit offset,
1326         not the number of bits remaining.
1327
1328 2019-05-08  Tom Tromey  <tromey@adacore.com>
1329
1330         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1331         padding at end of comment.
1332
1333 2019-05-08  Tom Tromey  <tromey@adacore.com>
1334
1335         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1336         Compare main types.
1337
1338 2019-05-06  Tom Tromey  <tom@tromey.com>
1339
1340         * common/scoped_mmap.c: Include common-defs.h.
1341         * common/scoped_mmap.h: Don't include config.h.
1342
1343 2019-05-04  Tom Tromey  <tom@tromey.com>
1344
1345         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1346         (struct aarch64_call_info): Add initializers.
1347         <si>: Now a std::vector.
1348         (pass_on_stack, aarch64_push_dummy_call): Update.
1349
1350 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1351             Tom Tromey  <tom@tromey.com>
1352
1353         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1354         (ppc_threads): Now a std::vector.  Now static.
1355         (hwdebug_find_thread_points_by_tid)
1356         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1357         Update.
1358
1359 2019-05-04  Tom Tromey  <tom@tromey.com>
1360
1361         * arc-tdep.c (arc_tdesc_init): Return bool.
1362
1363 2019-05-04  Tom Tromey  <tom@tromey.com>
1364
1365         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1366         Use gdb_assert_not_reached.
1367
1368 2019-05-04  Tom Tromey  <tom@tromey.com>
1369
1370         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1371         "false".
1372
1373 2019-05-04  Tom Tromey  <tom@tromey.com>
1374
1375         * arc-tdep.c (arc_tdesc_init): Use bool.
1376
1377 2019-05-04  Tom Tromey  <tom@tromey.com>
1378
1379         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1380
1381 2019-05-04  Tom Tromey  <tom@tromey.com>
1382
1383         * cli/cli-cmds.c (valid_command_p): Return bool.
1384
1385 2019-05-04  Tom Tromey  <tom@tromey.com>
1386
1387         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
1388         * command.h (valid_user_defined_cmd_name_p): Channge return type.
1389
1390 2019-05-04  Raul Tambre  <raul@tambre.ee>
1391
1392         * python/lib/gdb/prompt.py (_ExtendedPrompt)
1393         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
1394         operator for comparison.
1395
1396 2019-05-04  Tom Tromey  <tom@tromey.com>
1397
1398         * psymtab.c (psymbol_name_matches, match_partial_symbol)
1399         (lookup_partial_symbol, print_partial_symbols)
1400         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
1401         (psymbol_compare): Update.
1402         (add_psymbol_to_bcache): Clear the entire psymbol.
1403         (maintenance_check_psymtabs): Update.
1404         * psympriv.h (struct partial_symbol): Don't derive from
1405         general_symbol_info.
1406         <obj_section, unrelocated_address, address,
1407         set_unrelocated_address>: Update.
1408         <ginfo>: New member.
1409         * dwarf-index-write.c (write_psymbols, debug_names::insert)
1410         (debug_names::write_psymbols): Update.
1411
1412 2019-05-04  Tom de Vries  <tdevries@suse.de>
1413
1414         * contrib/cc-with-tweaks.sh: Support -n arg.
1415
1416 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1417
1418         * corelow.c (core_target::detach): Ensure frame cache and
1419         register caches are cleared.
1420         inferior.c (exit_inferior_1): Likewise.
1421
1422 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
1423             Tom Tromey  <tom@tromey.com>
1424
1425         * dictionary.c (collate_pending_symbols_by_language): Remove
1426         "struct" from foreach.
1427         * symtab.c (lookup_global_symbol_from_objfile)
1428         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
1429         foreach.
1430         * ser-tcp.c (net_open): Remove "struct" from foreach.
1431         * objfiles.c (objfile_relocate, objfile_rebase)
1432         (objfile_has_symbols): Remove "struct" from foreach.
1433         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
1434         from foreach.
1435         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
1436         foreach.
1437         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1438         "struct" from foreach.
1439         * ada-lang.c (create_excep_cond_exprs)
1440         (ada_exception_catchpoint_cond_string): Remove "struct" from
1441         foreach.
1442
1443 2019-05-03  Tom Tromey  <tromey@adacore.com>
1444
1445         * ada-exp.y (convert_char_literal): Check suffix of each
1446         enumerator.
1447
1448 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
1449
1450         PR ada/21406:
1451         * ada-exp.y (yywrap): Don't define.
1452         * ada-lex.l (%option): Add noyywrap
1453         (yywrap): Remove.
1454
1455 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
1456
1457         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
1458         _WIN32_WINNT to the XP level, unless already defined to a higher
1459         level.
1460
1461         * unittests/parse-connection-spec-selftests.c:
1462         * ser-tcp.c:
1463         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
1464         override.
1465
1466         * symfile.c (find_separate_debug_file): Remove colon from the
1467         drive spec of DOS/Windows file names of the target, so that the
1468         file name produced from DEBUGDIR and the target's directory will
1469         be valid on DOS/Windows systems.
1470
1471 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1472
1473         * rust-lang.c (val_print_struct): Handle printing structures
1474         containing strings.
1475
1476 2019-05-02  Tom Tromey  <tromey@adacore.com>
1477
1478         * valarith.c (_initialize_valarith): Remove.
1479
1480 2019-05-01  Tom Tromey  <tromey@adacore.com>
1481
1482         * ada-lang.c (ada_value_primitive_field): Treat more fields as
1483         bitfields.
1484
1485 2019-05-01  Tom Tromey  <tromey@adacore.com>
1486
1487         * ada-lang.c (ada_value_assign): Correctly compute starting offset
1488         for big-endian copies.
1489
1490 2019-04-30  Ali Tamur  <tamur@google.com>
1491         * gdb/dwarf2read.c (read_3_bytes): New declaration.
1492         (read_attribute_value): Added DW_FORM_strx1-4 cases.
1493         (read_3_bytes): New function.
1494
1495 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1496
1497         * windows-nat.c (main_thread_id): Delete.
1498         (handle_output_debug_string): Replace main_thread_id by
1499         current_event.dwThreadId.
1500         (fake_create_process): Likewise.
1501         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
1502         Do not set main_thread_id.
1503         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
1504         current_event.dwThreadId.
1505         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
1506
1507 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1508
1509         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
1510         Use current_event.dwThreadId instead of main_thread_id.
1511
1512 2019-04-30  Tom Tromey  <tromey@adacore.com>
1513
1514         * ada-lang.c (ada_lookup_simple_minsyms): New function.
1515         (create_excep_cond_exprs): Iterate over program spaces.
1516         (ada_exception_catchpoint_cond_string): Examine all minimal
1517         symbols for exception types.
1518
1519 2019-04-30  Tom Tromey  <tromey@adacore.com>
1520
1521         PR c++/24470:
1522         * dwarf2read.c (process_structure_scope): Handle case where type
1523         has template parameters but no symbol was created.
1524
1525 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1526             Chris January  <chris.january@arm.com>
1527
1528         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
1529         qualifier.
1530         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
1531
1532 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1533
1534         * f-typeprint.c (f_print_type): Update rules for printing
1535         whitespace.
1536         (f_type_print_varspec_suffix): Likewise.
1537
1538 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1539             Chris January  <chris.january@arm.com>
1540
1541         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
1542         function arguments.
1543
1544 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1545
1546         * f-lang.c (build_fortran_types): Change name of void type to
1547         lower case.
1548         * f-typeprint.c (f_type_print_base): Print the name of the void
1549         type, rather than a fixed string.
1550         * f-valprint.c (f_decorations): Use lower case void string.
1551
1552 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1553             Chris January  <chris.january@arm.com>
1554
1555         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
1556         types for Fortran.
1557
1558 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1559             Chris January  <chris.january@arm.com>
1560             David Lecomber  <david.lecomber@arm.com>
1561
1562         * f-exp.y (BINOP_INTRINSIC): New token.
1563         (exp): New parser rule handling BINOP_INTRINSIC.
1564         (f77_keywords): Add new builtin procedures.
1565         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
1566         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1567         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
1568         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1569         (print_unop_subexp_f): New function.
1570         (print_binop_subexp_f): New function.
1571         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1572         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1573         (dump_subexp_body_f): Likewise.
1574         (operator_check_f): Likewise.
1575         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1576         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
1577
1578 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1579
1580         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
1581         UNOP_KIND.
1582         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
1583         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
1584         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
1585         (operator_length_f): New fuction.
1586         (print_subexp_f): New function.
1587         (op_name_f): New function.
1588         (dump_subexp_body_f): New function.
1589         (operator_check_f): New function.
1590         (exp_descriptor_f): Replace standard expression handling functions
1591         with new functions.
1592         * gdb/fortran-operator.def: New file.
1593         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
1594         * gdb/std-operator.def: Remove UNOP_KIND.
1595
1596 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1597
1598         * std-operator.def: Remove unbalanced, stray double quote
1599         character.
1600
1601 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1602             Chris January  <chris.january@arm.com>
1603             Daniel Everett  <daniel.everett@arm.com>
1604             Nick Forrington  <nick.forrington@arm.com>
1605             Richard Bunt  <richard.bunt@arm.com>
1606
1607         * cp-valprint.c (cp_print_value_fields): Allow an additional level
1608         of depth when printing anonymous structs or unions.
1609         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
1610         Don't print either the top-level value, or the children if the
1611         max-depth is exceeded.
1612         (ppscm_print_children): When printing the key of a map, allow one
1613         extra level of depth.
1614         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
1615         print either the top-level value, or the children if the max-depth
1616         is exceeded.
1617         (print_children): When printing the key of a map, allow one extra
1618         level of depth.
1619         * python/py-value.c (valpy_format_string): Add max_depth keyword.
1620         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
1621         (user_print_options): Initialise max_depth field.
1622         (val_print_scalar_or_string_type_p): New function.
1623         (val_print): Check to see if the max depth has been reached.
1624         (val_print_check_max_depth): Define new function.
1625         (show_print_max_depth): New function.
1626         (_initialize_valprint): Add 'print max-depth' option.
1627         * valprint.h (struct value_print_options) <max_depth>: New field.
1628         (val_print_check_max_depth): Declare new function.
1629         * NEWS: Document new feature.
1630
1631 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1632
1633         * ada-lang.c (ada_language_defn): Initialise new field.
1634         * c-lang.c (c_is_string_type_p): New function.
1635         (c_language_defn): Initialise new field.
1636         (cplus_language_defn): Initialise new field.
1637         (asm_language_defn): Initialise new field.
1638         (minimal_language_defn): Initialise new field.
1639         * c-lang.h (c_is_string_type_p): Declare new function.
1640         * d-lang.c (d_language_defn): Initialise new field.
1641         * f-lang.c (f_is_string_type_p): New function.
1642         (f_language_defn): Initialise new field.
1643         * go-lang.c (go_is_string_type_p): New function.
1644         (go_language_defn): Initialise new field.
1645         * language.c (default_is_string_type_p): New function.
1646         (unknown_language_defn): Initialise new field.
1647         (auto_language_defn): Initialise new field.
1648         * language.h (struct language_defn) <la_is_string_type_p>: New
1649         member variable.
1650         (default_is_string_type_p): Declare new function.
1651         * m2-lang.c (m2_language_defn): Initialise new field.
1652         * objc-lang.c (objc_language_defn): Initialise new field.
1653         * opencl-lang.c (opencl_language_defn): Initialise new field.
1654         * p-lang.c (pascal_is_string_type_p): New function.
1655         (pascal_language_defn): Initialise new field.
1656         * rust-lang.c (rust_is_string_type_p): New function.
1657         (rust_language_defn): Initialise new field.
1658
1659 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1660
1661         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
1662         New field.
1663         * ada-lang.c (ada_language_defn): Initialise new field.
1664         * c-lang.c (c_language_defn): Likewise.
1665         (cplus_language_defn): Likewise.
1666         (asm_language_defn): Likewise.
1667         (minimal_language_defn): Likewise.
1668         * d-lang.c (d_language_defn): Likewise.
1669         * f-lang.c (f_language_defn): Likewise.
1670         * go-lang.c (go_language_defn): Likewise.
1671         * language.c (unknown_language_defn): Likewise.
1672         (auto_language_defn): Likewise.
1673         * m2-lang.c (m2_language_defn): Likewise.
1674         * objc-lang.c (objc_language_defn): Likewise.
1675         * opencl-lang.c (opencl_language_defn): Likewise.
1676         * p-lang.c (pascal_language_defn): Likewise.
1677         * rust-lang.c (rust_language_defn): Likewise.
1678
1679 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1680
1681         * ada-lang.c (ada_is_character_type): Change return type to bool.
1682         (ada_is_string_type): Likewise.
1683         * ada-lang.h (ada_is_character_type): Update declaration
1684         (ada_is_string_type): Likewise.
1685
1686 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1687
1688         Support style in 'frame|thread apply'
1689
1690         * gdbcmd.h (execute_command_to_string): New term_out parameter.
1691         * record.c (record_start, record_stop): Update callers of
1692         execute_command_to_string with false.
1693         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
1694         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
1695         methods.
1696         (class string_file): New constructor with term_out parameter.
1697         Override methods term_out and can_emit_style_escape.  New member
1698         term_out.
1699         (class stdio_file): Override can_emit_style_escape.
1700         (class tee_file): Override term_out and can_emit_style_escape.
1701         * utils.h (can_emit_style_escape): Remove.
1702         * utils.c (can_emit_style_escape): Likewise.
1703         Update all callers of can_emit_style_escape (SOMESTREAM) to
1704         SOMESTREAM->can_emit_style_escape.
1705         * source-cache.c (source_cache::get_source_lines): Likewise.
1706         * stack.c (frame_apply_command_count): Call execute_command_to_string
1707         passing the term_out characteristic of the current gdb_stdout.
1708         * thread.c (thr_try_catch_cmd): Likewise.
1709         * top.c (execute_command_to_string): pass term_out parameter
1710         to construct the string_file for the command output.
1711         * ui-file.c (term_cli_styling): New function (most code moved
1712         from utils.c can_emit_style_escape).
1713         (string_file::string_file, string_file::can_emit_style_escape,
1714         stdio_file::can_emit_style_escape, tee_file::term_out,
1715         tee_file::can_emit_style_escape): New functions.
1716
1717 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1718
1719         * NEWS: Mention the new set|show may-call-functions.
1720         * infcall.c (may_call_functions_p): New variable.
1721         (show_may_call_functions_p): New function.
1722         (call_function_by_hand_dummy): Throws an error if not
1723         may-call-functions.
1724         (_initialize_infcall): Call add_setshow_boolean_cmd for
1725         may-call-functions.
1726
1727 2019-04-25  Keith Seitz  <keiths@redhat.com>
1728
1729         PR c++/24367
1730         * cp-support.c (inspect_type): Don't attempt substitutions
1731         of symbol with the same name.
1732
1733 2019-04-25  Tom Tromey  <tromey@adacore.com>
1734
1735         PR gdb/24475:
1736         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
1737         static.
1738
1739 2019-04-25  Tom Tromey  <tromey@adacore.com>
1740
1741         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
1742         rvalue reference.
1743         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
1744         (gdb_xml_parser::parse): Use std::move.
1745         * python/python-internal.h (gdbpy_convert_exception): Take a const
1746         reference.
1747         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
1748         std::move.
1749         * python/py-utils.c (gdbpy_convert_exception): Take a const
1750         reference.
1751         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1752         Use std::move.
1753         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1754         Use std::move.
1755         * mi/mi-main.c (mi_print_exception): Take a const reference.
1756         * main.c (handle_command_errors): Take a const reference.
1757         * linespec.c (parse_linespec): Use std::move.
1758         * infcall.c (run_inferior_call): Use std::move.
1759         (call_function_by_hand_dummy): Use std::move.
1760         * exec.c (try_open_exec_file): Use std::move.
1761         * exceptions.h (exception_print, exception_fprintf)
1762         (exception_print_same): Update.
1763         * exceptions.c (print_exception, exception_print)
1764         (exception_fprintf, exception_print_same): Change parameters to
1765         const reference.
1766         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
1767         * common/new-op.c: Use std::move.
1768         * common/common-exceptions.h (struct gdb_exception): Add move
1769         constructor.
1770         (struct gdb_exception_error, struct gdb_exception_quit, struct
1771         gdb_quit_bad_alloc): Change constructor to move constructor.
1772         (throw_exception): Change parameter to rvalue reference.
1773         * common/common-exceptions.c (throw_exception): Take rvalue
1774         reference.
1775         * cli/cli-interp.c (safe_execute_command): Use std::move.
1776         * breakpoint.c (insert_bp_location, location_to_sals): Use
1777         std::move.
1778
1779 2019-04-25  Tom Tromey  <tromey@adacore.com>
1780
1781         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
1782         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
1783         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
1784         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
1785         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
1786         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
1787         guile/scm-value.c: Use unpack.
1788         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
1789         gdbscm_gdb_exception.
1790         (gdbscm_throw_gdb_exception): Likewise.
1791         (struct gdbscm_gdb_exception): New.
1792         (unpack): New function.
1793         (gdbscm_wrap): Use unpack.
1794
1795 2019-04-25  Tom Tromey  <tromey@adacore.com>
1796
1797         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1798         (gdb_rl_callback_handler): Use std::move.
1799         * common/common-exceptions.h (struct gdb_exception): Add move
1800         assignment operator.
1801         (throw_exception_sjlj): Change "exception" to const reference.
1802         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
1803         (throw_exception_sjlj): Change "exception" to const reference.
1804
1805 2019-04-25  Tom Tromey  <tromey@adacore.com>
1806
1807         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
1808         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
1809         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1810         Update.
1811         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1812         Update.
1813         * mi/mi-interp.c (mi_interp::exec): Update.
1814         * linespec.c (parse_linespec): Update.
1815         * infcall.c (run_inferior_call): Update.
1816         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
1817         * guile/scm-symbol.c (gdbscm_lookup_symbol)
1818         (gdbscm_lookup_global_symbol): Update.
1819         * guile/scm-param.c (gdbscm_parameter_value): Update.
1820         * guile/scm-frame.c (gdbscm_frame_read_register)
1821         (gdbscm_frame_read_var): Update.
1822         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
1823         * exec.c (try_open_exec_file): Update.
1824         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1825         (gdb_rl_callback_handler): Update.
1826         * common/common-exceptions.h (exception_none): Don't declare.
1827         * common/common-exceptions.c (exception_none): Don't define.
1828         (struct catcher) <exception>: Update.
1829         * cli/cli-interp.c (safe_execute_command): Update.
1830         * breakpoint.c (insert_bp_location, location_to_sals): Update.
1831
1832 2019-04-25  Ali Tamur  <tamur@google.com>
1833
1834         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
1835         (read_attribute_value): Likewise.
1836         (dwarf2_read_addr_index): Update comment.
1837         (read_str_index): Add DW_FORM_strx.
1838         (dwarf2_string_attr): Likewise.
1839         (dwarf2_const_value_attr): Likewise.
1840         (dump_die_shallow): Likewise.
1841         (dwarf2_fetch_constant_bytes): Likewise.
1842         (skip_form_bytes): Likewise.
1843         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
1844
1845 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
1846
1847         PR corefiles/11608
1848         PR corefiles/18187
1849         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
1850         OFFSET.  Verify if current mapping contains an ELF header.
1851         (linux_find_memory_regions_full): Adjust call to
1852         dump_mapping_p.
1853
1854 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
1855             Kang Li <kanglictf@gmail.com>
1856
1857         PR gdb/21600
1858
1859         * dwarf2-frame.c (read_initial_length): Be consistent about using
1860         unsigned representation of length.
1861         (decode_frame_entry_1): Likewise.  Check for wraparound of
1862         end pointer as well as buffer overflow.
1863
1864 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
1865
1866         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
1867         "vq".
1868
1869 2019-04-24  Tom Tromey  <tromey@adacore.com>
1870
1871         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
1872
1873 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1874
1875         * s12z-tdep.c (s12z_unwind_pc): Delete.
1876         (s12z_unwind_sp): Delete.
1877         (s12z_gdbarch_init): Don't register deleted functions with
1878         gdbarch.
1879
1880 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1881
1882         * rl78-tdep.c (rl78_unwind_sp): Delete.
1883         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
1884
1885 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1886
1887         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
1888         (xstormy16_unwind_pc): Delete.
1889         (xstormy16_dummy_id): Delete.
1890         (xstormy16_gdbarch_init): Don't register deleted functions with
1891         gdbarch.
1892
1893 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1894
1895         * vax-tdep.c (vax_unwind_pc): Delete.
1896         (vax_gdbarch_init): Don't register deleted function with gdbarch.
1897
1898 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1899
1900         * v850-tdep.c (v850_unwind_sp): Delete.
1901         (v850_unwind_pc): Delete.
1902         (v850_dummy_id): Delete.
1903         (v850_gdbarch_init): Don't register deleted functions with
1904         gdbarch.
1905
1906 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1907
1908         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
1909         (tilegx_unwind_pc): Delete.
1910         (tilegx_unwind_dummy_id): Delete.
1911         (tilegx_gdbarch_init): Don't register deleted functions with
1912         gdbarch.
1913
1914 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1915
1916         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
1917         (tic6x_dummy_id): Delete.
1918         (tic6x_gdbarch_init): Don't register deleted functions with
1919         gdbarch.
1920
1921 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1922
1923         * sparc-tdep.c (sparc_unwind_pc): Delete.
1924         (sparc32_gdbarch_init): Don't register deleted function with
1925         gdbarch.
1926
1927 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1928
1929         * sh-tdep.c (sh_unwind_sp): Delete.
1930         (sh_unwind_pc): Delete.
1931         (sh_dummy_id): Delete.
1932         (sh_gdbarch_init): Don't register deleted functions with
1933         gdbarch.
1934
1935 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1936
1937         * score-tdep.c (score_unwind_sp): Delete.
1938         (score_unwind_pc): Delete.
1939         (score_dummy_id): Delete.
1940         (score_gdbarch_init): Don't register deleted functions with
1941         gdbarch.
1942
1943 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1944
1945         * rx-tdep.c (rx_unwind_pc): Delete.
1946         (rx_unwind_sp): Delete.
1947         (rx_dummy_id): Delete.
1948         (rx_gdbarch_init): Don't register deleted functions with
1949         gdbarch.  Update comment.
1950
1951 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1952
1953         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
1954         (rs6000_dummy_id): Delete.
1955         (rs6000_gdbarch_init): Don't register deleted functions with
1956         gdbarch.
1957
1958 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1959
1960         * or1k-tdep.c (or1k_dummy_id): Delete.
1961         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
1962
1963 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1964
1965         * nios2-tdep.c (nios2_dummy_id): Delete.
1966         (nios2_unwind_sp): Delete.
1967         (nios2_gdbarch_init): Don't register deleted functions with
1968         gdbarch.
1969
1970 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1971
1972         * nds32-tdep.c (nds32_dummy_id): Delete.
1973         (nds32_unwind_pc): Delete.
1974         (nds32_unwind_sp): Delete.
1975         (nds32_gdbarch_init): Don't register deleted functions with
1976         gdbarch.
1977
1978 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1979
1980         * msp430-tdep.c (msp430_unwind_pc): Delete.
1981         (msp430_unwind_sp): Delete.
1982         (msp430_dummy_id): Delete.
1983         (msp430_gdbarch_init): Don't register deleted functions with
1984         gdbarch.
1985
1986 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1987
1988         * moxie-tdep.c (moxie_unwind_sp): Delete.
1989         (moxie_unwind_pc): Delete.
1990         (moxie_dummy_id): Delete.
1991         (moxie_gdbarch_init): Don't register deleted functions with
1992         gdbarch.
1993
1994 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1995
1996         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1997         (mn10300_unwind_pc): Delete.
1998         (mn10300_unwind_sp): Delete.
1999         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
2000         mn10300_unwind_sp.
2001         (mn10300_frame_unwind_init): Don't register deleted functions with
2002         gdbarch.
2003
2004 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2005
2006         * mep-tdep.c (mep_unwind_pc): Delete.
2007         (mep_unwind_sp): Delete.
2008         (mep_dummy_id): Delete.
2009         (mep_gdbarch_init): Don't register deleted functions with
2010         gdbarch.
2011
2012 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2013
2014         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
2015         (m68hc11_unwind_sp): Delete.
2016         (m68hc11_gdbarch_init): Don't register deleted functions with
2017         gdbarch.
2018
2019 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2020
2021         * m32r-tdep.c (m32r_unwind_sp): Delete.
2022         (m32r_unwind_pc): Delete.
2023         (m32r_dummy_id): Delete.
2024         (m32r_gdbarch_init): Don't register deleted functions with
2025         gdbarch.
2026
2027 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2028
2029         * m32c-tdep.c (m32c_unwind_pc): Delete.
2030         (m32c_unwind_sp): Delete.
2031         (m32c_dummy_id): Delete.
2032         (m32c_gdbarch_init): Don't register deleted functions with
2033         gdbarch.
2034
2035 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2036
2037         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
2038         (lm32_unwind_pc): Delete.
2039         (lm32_dummy_id): Delete.
2040         (lm32_gdbarch_init): Don't register deleted functions with
2041         gdbarch.
2042
2043 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2044
2045         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2046         (iq2000_unwind_pc): Delete.
2047         (iq2000_dummy_id): Delete.
2048         (iq2000_gdbarch_init): Don't register deleted functions with
2049         gdbarch.
2050
2051 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2052
2053         * nds32-tdep.c (nds32_type_align): Delete.
2054         (nds32_push_dummy_call): Use type_align instead.
2055
2056 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2057
2058         * arm-tdep.c (arm_type_align): Only handle vector override case.
2059         (arm_push_dummy_call): Use type_align.
2060         (arm_gdbarch_init): Register arm_type_align gdbarch function.
2061
2062 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2063
2064         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
2065         case.
2066         (pass_on_stack): Use type_align.
2067         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
2068         function.
2069
2070 2019-04-23  Tom Tromey  <tromey@adacore.com>
2071
2072         * dwarf2read.c (line_header::file_name_at): Remove unused
2073         overload.
2074
2075 2019-04-23  Tom de Vries  <tdevries@suse.de>
2076
2077         PR gdb/24438
2078         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
2079         invocation.
2080
2081
2082 2019-03-27  Ali Tamur  <tamur@google.com>
2083
2084         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2085         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2086         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2087         (dwarf_expr_context::get_addr_index): Likewise
2088         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2089         (symbol_needs_eval_context::get_addr_index): Likewise
2090         (disassemble_dwarf_expression): Add DW_OP_addrx
2091         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2092         (read_cutu_die_from_dwo): Update comment
2093         (skip_one_die): Add DW_FORM_addrx
2094         (read_attribute_value): Likewise
2095         (var_decode_location): Add DW_OP_addrx
2096         (dwarf2_const_value_attr): Add DW_FORM_addrx
2097         (dump_die_shallow): Likewise
2098         (dwarf2_fetch_constant_bytes): Likewise
2099         (decode_locdesc): Add DW_OP_addrx
2100         (skip_form_bytes): Add DW_FORM_addrx
2101
2102 2019-04-22  Ali Tamur  <tamur@google.com>
2103
2104         * MAINTAINERS (Write After Approval): Add self.
2105
2106 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2107
2108         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2109         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2110         (open_symbol_file_object): Likewise.
2111         (svr4_default_sos): Add info parameter.
2112         (svr4_read_so_list): Likewise.
2113         (svr4_current_sos_direct): Adjust functions calls to pass down
2114         info.
2115         (svr4_current_sos_1): Add info parameter.
2116         (svr4_current_sos): Call get_svr4_info, pass info down to
2117         svr4_current_sos_1.
2118         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2119         get_svr4_info.
2120         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2121         get_svr4_info.
2122         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2123         to get_svr4_info.
2124         (probes_table_remove_objfile_probes): Likewise.
2125         (register_solib_event_probe): Add info parameter.
2126         (solist_update_incremental): Pass info parameter down to
2127         svr4_read_so_list.
2128         (disable_probes_interface): Add info parameter.
2129         (svr4_handle_solib_event): Pass current_program_space to
2130         get_svr4_info.  Adjust disable_probes_interface cleanup.
2131         (svr4_create_probe_breakpoints): Add info parameter, pass it
2132         down to register_solib_event_probe.
2133         (svr4_create_solib_event_breakpoints): Add info parameter,
2134         pass it down to svr4_create_probe_breakpoints.
2135         (enable_break): Pass info down to
2136         svr4_create_solib_event_breakpoints.
2137         (svr4_solib_create_inferior_hook): Pass current_program_space to
2138         get_svr4_info.
2139         (svr4_clear_solib): Likewise.
2140
2141 2019-04-22  Pedro Alves  <palves@redhat.com>
2142
2143         * solib-svr4.c (svr4_free_objfile_observer): New.
2144         (probe_and_action::objfile): New field.
2145         (probes_table_htab_remove_objfile_probes)
2146         (probes_table_remove_objfile_probes): New functions.
2147         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2148         in the new probe_and_action.  Don't store the probe in 'lookup'.
2149         (svr4_create_probe_breakpoints): Pass objfile to
2150         register_solib_event_probe.
2151         (_initialize_svr4_solib): Register a free_objfile observer.
2152
2153 2019-04-19  Tom Tromey  <tom@tromey.com>
2154
2155         * common/queue.h: Remove.
2156
2157 2019-04-19  Tom Tromey  <tom@tromey.com>
2158
2159         * event-loop.c: Don't include "common/queue.h".
2160
2161 2019-04-19  Tom Tromey  <tom@tromey.com>
2162
2163         * remote.c (remote_target): Use delete.
2164         * remote-notif.h: Include <list>, not "common/queue.h".
2165         (notif_client_p): Remove typedef.
2166         (remote_notif_state): Add constructor, destructor, initializer.
2167         <notif_queue>: Now a std::list.
2168         (remote_notif_state_xfree): Don't declare.
2169         * remote-notif.c (remote_notif_process, handle_notification)
2170         (remote_notif_state_allocate): Update.
2171         (~remote_notif_state): Rename from remote_notif_state_xfree.
2172
2173 2019-04-19  Tom Tromey  <tom@tromey.com>
2174
2175         * symfile.c (reread_symbols): Update.
2176         * objfiles.c (objfile_register_static_link)
2177         (objfile_lookup_static_link): Update
2178         (~objfile) Don't delete static_links.
2179         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2180
2181 2019-04-19  Tom Tromey  <tom@tromey.com>
2182
2183         * type-stack.h (struct type_stack) <insert>: Constify string.
2184         * type-stack.c (type_stack::insert): Constify string.
2185         * gdbtypes.h (lookup_template_type): Update.
2186         (address_space_name_to_int): Update.
2187         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2188         const.
2189         (lookup_template_type): Make name const.
2190         * c-exp.y: Update rules.
2191         (lex_one_token, classify_name, classify_inner_name)
2192         (c_print_token): Update.
2193         * p-exp.y: Update rules.
2194         (yylex): Update.
2195         * f-exp.y: Update rules.
2196         (yylex): Update.
2197         * d-exp.y: Update rules.
2198         (lex_one_token, classify_name, classify_inner_name): Update.
2199         * parse.c (write_dollar_variable, copy_name): Return std::string.
2200         * parser-defs.h (copy_name): Change return type.
2201         * m2-exp.y: Update rules.
2202         (yylex): Update.
2203         * go-exp.y (lex_one_token): Update.
2204         Update rules.
2205         (classify_unsafe_function, classify_packaged_name)
2206         (classify_name, yylex): Update.
2207
2208 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2209
2210         * configure.ac: add --enable-source-highlight switch.
2211         * configure: Regenerate.
2212         * top.c (print_gdb_version): plumb --enable-source-highlight
2213         status to "show configuration".
2214
2215 2019-04-19  Tom Tromey  <tromey@adacore.com>
2216
2217         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2218         Check ADA_TYPE_P.
2219         (empty_record, ada_template_to_fixed_record_type_1)
2220         (template_to_static_fixed_type)
2221         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
2222         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
2223         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
2224         macros.
2225
2226 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2227
2228         PR symtab/24423:
2229         * source.c (print_source_lines_base): Advance "iter" when a
2230         control character is seen.
2231
2232 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2233
2234         * inferior.h (struct infcall_suspend_state_deleter):
2235         Catch exception in destructor to avoid crash.
2236
2237 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2238
2239         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
2240         close to the add_com "shell".
2241
2242 2019-04-18  Tom Tromey  <tromey@adacore.com>
2243
2244         * process-stratum-target.h (class process_stratum_target)
2245         <stratum>: Add "final".
2246
2247 2019-04-17  Tom Tromey  <tromey@adacore.com>
2248
2249         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
2250         against nullptr before use.
2251
2252 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2253
2254         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
2255
2256 2019-04-17  Jim Wilson  <jimw@sifive.com>
2257             Andrew Burgess  <andrew.burgess@embecosm.com>
2258
2259         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
2260         code read might fail, assume 4-byte breakpoint in that case.
2261
2262 2019-04-15  Leszek Swirski  <leszeks@google.com>
2263
2264         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
2265         rather than a hand-rolled POD check when checking for forced MEMORY
2266         classification.
2267
2268 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2269
2270         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
2271         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
2272         function.
2273         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
2274         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
2275         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
2276         declaration.
2277
2278 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2279
2280         * aarch64-linux-nat.c
2281         (aarch64_linux_nat_target::thread_architecture): Add override.
2282         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
2283         each VQ.
2284
2285 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2286
2287         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2288
2289 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2290
2291         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2292         target types of size 96-bits, add some additional comments, and
2293         check that the builtin type we found was the correct size.
2294
2295 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2296
2297         * utils.c (prompt_for_continue): Don't restore the styling at the
2298         end, as applied_style has the wrong value.  This fixes styling in
2299         long lists of file names that are interrupted by the "Continue?"
2300         prompt.
2301
2302 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2303
2304         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2305         * c-lang.c (c_language_defn): Likewise.
2306         (cplus_language_defn): Likewise.
2307         (asm_language_defn): Likewise.
2308         (minimal_language_defn): Likewise.
2309         * d-lang.c (d_language_defn): Likewise.
2310         * f-lang.c (f_language_defn): Likewise.
2311         * go-lang.c (go_language_defn): Likewise.
2312         * language.c (unknown_language_defn): Likewise.
2313         (auto_language_defn): Likewise.
2314         * language.h (struct language_defn): Remove la_magic field.
2315         (LANG_MAGIC): Delete.
2316         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2317         * objc-lang.c (objc_language_defn): Likewise.
2318         * opencl-lang.c (opencl_language_defn): Likewise.
2319         * p-lang.c (pascal_language_defn): Likewise.
2320         * rust-lang.c (rust_language_defn): Likewise.
2321
2322 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2323
2324         * riscv-tdep.c (riscv_type_align): New function.
2325         (riscv_type_alignment): Delete.
2326         (riscv_arg_location): Use 'type_align'.
2327         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2328
2329 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2330
2331         * gdbtypes.c (type_align): A struct with no non-static fields also
2332         has alignment of 1.
2333
2334 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2335
2336         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2337         component to 0.
2338         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2339         member.
2340         (riscv_struct_info::analyse): New implementation using new
2341         analyse_inner member function.
2342         (riscv_struct_info::field_offset): New member function.
2343         (riscv_struct_info::m_offsets): New member variable.
2344         (riscv_struct_info::analyse_inner): New private member function,
2345         takes the old implementation of riscv_struct_info::analyse but
2346         extended to track field offsets.
2347         (riscv_call_arg_struct): Update the struct folding special cases
2348         to handle cases where empty C++ structs, which are non-zero
2349         length, are found.
2350         (riscv_arg_location): Initialise the length of each location, a
2351         non-zero length now indicates the location is in use.
2352         (riscv_push_dummy_call): Allow for the first location having a
2353         non-zero offset when setting up arguments.
2354         (riscv_return_value): Likewise, but for return values.
2355
2356 2019-04-11  Tom Tromey  <tromey@adacore.com>
2357
2358         * utils.c (internal_vproblem): Make "msg" const.
2359
2360 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2361
2362         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2363         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2364         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2365         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2366
2367 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2368
2369         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2370         function.
2371         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2372         of amd64_collect_native_gregset.
2373         (amd64_linux_nat_target::store_registers): Likewise.
2374
2375 2019-04-10  Tom Tromey  <tom@tromey.com>
2376
2377         * symtab.c (lookup_global_symbol_from_objfile)
2378         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2379         * objfiles.h (class separate_debug_iterator): New.
2380         (class separate_debug_range): New.
2381         (struct objfile) <separate_debug_objfiles>: New method.
2382         (objfile_separate_debug_iterate): Don't declare.
2383         * objfiles.c (separate_debug_iterator::operator++): Rename from
2384         objfile_separate_debug_iterate.
2385         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
2386         iterator.
2387         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
2388         iterator.
2389
2390 2019-04-10  Tom Tromey  <tom@tromey.com>
2391
2392         * symfile.c (reread_symbols): Remove old comment.
2393         * objfiles.c (free_all_objfiles): Fix a typo.
2394
2395 2019-04-10  Tom Tromey  <tom@tromey.com>
2396
2397         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
2398         * minsyms.c (lookup_minimal_symbol): Use foreach.
2399         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
2400         (lookup_minimal_symbol_solib_trampoline): Likewise.
2401         * symfile.c (reread_symbols): Use foreach.
2402
2403 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
2404             Tom Tromey  <tromey@adacore.com>
2405
2406         PR rust/24414:
2407         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
2408         (rust_lex_int_test): Change "value" to be LONGEST.
2409         (rust_lex_tests): Add test for long integer literal.
2410
2411 2019-04-09  Tom Tromey  <tromey@adacore.com>
2412
2413         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
2414         to bool.
2415         (extended_remote_target::attach): Update.
2416         (remote_target::remote_notice_new_inferior): Update.
2417         (remote_target::add_current_inferior_and_thread): Update.
2418         * inferior.c (exit_inferior_1): Use "false".
2419         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
2420
2421 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
2422
2423         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
2424         the "start" command.
2425
2426 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2427
2428         * python/py-inferior.c (infpy_thread_from_thread_handle):
2429         Adjust comments to reflect renaming of thread_from_thread_handle
2430         to thread_from_handle.  Adjust keywords.  Fix type error message.
2431         (inferior_object_methods): Add thread_from_handle.  Retain
2432         thread_from_thread_handle, but mark it as deprecated.
2433
2434 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2435
2436         * gdbthread.h (find_thread_by_handle): Revise declaration.
2437         * thread.c (find_thread_by_handle): Likewise.  Adjust
2438         implementation too.
2439         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2440         support for buffer objects as handles.
2441
2442 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2443
2444         * python/py-infthread.c (thpy_thread_handle): New function.
2445         (thread_object_methods): Register thpy_thread_handle.
2446
2447 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2448
2449         * gdbthread.h (thread_to_thread_handle): Declare.
2450         * thread.c (gdbtypes.h): Include.
2451         (thread_to_thread_handle): New function.
2452
2453         * target.h (struct target_ops): Add thread_info_to_thread_handle.
2454         (target_thread_info_to_thread_handle): Declare.
2455         * target.c (target_thread_info_to_thread_handle): New function.
2456         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
2457         * target-delegates.c: Regenerate.
2458
2459         * linux-thread-db.c (class thread_db_target): Add method
2460         thread_info_to_thread_handle.
2461         (thread_db_target::thread_info_to_thread_handle): Define.
2462         * remote.c (class remote_target): Add new method
2463         thread_info_to_thread_handle.
2464         (remote_target::thread_info_to_thread_handle): Define.
2465
2466 2019-04-08  Pedro Alves  <palves@redhat.com>
2467
2468         * common/common-exceptions.c (throw_exception): Don't create
2469         named object to throw; throw directly.
2470         (throw_it): Likewise.  Don't initialize gdb_exception::message
2471         here, with new; pass FMT and AP to the ctor instead.
2472         * common/common-exceptions.h: Include <string>.
2473         (gdb_exception::gdb_exception(enum return_reason, enum errors,
2474         const char *, va_list)): New ctor.  Use std::make_shared.
2475         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
2476         errors)): Delete.
2477         (gdb_exception_error::gdb_exception_error(enum errors, const char
2478         *, va_list)): New.
2479         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
2480         Add assertion.
2481         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
2482         errors)): Delete.
2483         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
2484         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
2485         Add assertion.
2486
2487 2019-04-08  Tom Tromey  <tom@tromey.com>
2488
2489         * valops.c (value_rtti_indirect_type): Replace throw_exception
2490         with throw.
2491         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
2492         with throw.
2493         * thread.c (thr_try_catch_cmd): Replace throw_exception with
2494         throw.
2495         * target.c (target_translate_tls_address): Replace throw_exception
2496         with throw.
2497         * stack.c (frame_apply_command_count): Replace throw_exception
2498         with throw.
2499         * solib-spu.c (append_ocl_sos): Replace throw_exception with
2500         throw.
2501         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
2502         with throw.
2503         * rs6000-tdep.c (rs6000_frame_cache)
2504         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
2505         * remote.c: Replace throw_exception with throw.
2506         * record-full.c (record_full_message, record_full_wait_1)
2507         (record_full_restore): Replace throw_exception with throw.
2508         * record-btrace.c:
2509         (get_thread_current_frame_id, record_btrace_start_replaying)
2510         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
2511         (cmd_record_btrace_start): Replace throw_exception with throw.
2512         * parse.c (parse_exp_in_context_1): Replace throw_exception with
2513         throw.
2514         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
2515         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
2516         * linespec.c:
2517         (find_linespec_symbols): Replace throw_exception with throw.
2518         * infrun.c (displaced_step_prepare, resume): Replace
2519         throw_exception with throw.
2520         * infcmd.c (post_create_inferior): Replace throw_exception with
2521         throw.
2522         * inf-loop.c (inferior_event_handler): Replace throw_exception
2523         with throw.
2524         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
2525         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
2526         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
2527         (get_prev_frame_always, get_frame_pc_if_available)
2528         (get_frame_address_in_block_if_available, get_frame_language):
2529         Replace throw_exception with throw.
2530         * frame-unwind.c (frame_unwind_try_unwinder): Replace
2531         throw_exception with throw.
2532         * eval.c (fetch_subexp_value, evaluate_var_value)
2533         (evaluate_funcall, evaluate_subexp_standard): Replace
2534         throw_exception with throw.
2535         * dwarf2loc.c (call_site_find_chain)
2536         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
2537         Replace throw_exception with throw.
2538         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
2539         with throw.
2540         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
2541         throw.
2542         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
2543         * completer.c (complete_line_internal): Replace throw_exception
2544         with throw.
2545         * compile/compile-object-run.c (compile_object_run): Replace
2546         throw_exception with throw.
2547         * cli/cli-script.c (process_next_line): Replace throw_exception
2548         with throw.
2549         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
2550         (btrace_enable, btrace_maint_update_pt_packets): Replace
2551         throw_exception with throw.
2552         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
2553         throw_exception with throw.
2554         * break-catch-throw.c (re_set_exception_catchpoint): Replace
2555         throw_exception with throw.
2556         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
2557         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
2558         * aarch64-tdep.c (aarch64_make_prologue_cache)
2559         (aarch64_make_stub_cache): Replace throw_exception with throw.
2560
2561 2019-04-08  Tom Tromey  <tom@tromey.com>
2562
2563         * common/common-exceptions.c (throw_exception): Rename from
2564         throw_exception_cxx.  Remove old copy.  Make argument const.
2565         (throw_it): Create and throw exception objects directly.
2566         * common/common-exceptions.h (throw_exception): Make argument
2567         const.
2568         (struct gdb_exception_error): Add constructor.
2569         (struct gdb_exception_quit): Add constructor.
2570
2571 2019-04-08  Tom Tromey  <tom@tromey.com>
2572
2573         * common/common-exceptions.h (exception_rethrow): Don't declare.
2574         (TRY_SJLJ): Update comment.
2575         (TRY, CATCH, END_CATCH): Remove.
2576         * common/common-exceptions.c (exception_rethrow): Remove.
2577
2578 2019-04-08  Tom Tromey  <tom@tromey.com>
2579
2580         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
2581         Remove.
2582         (gdb_exception_error): Rename from
2583         gdb_exception_RETURN_MASK_ERROR.
2584         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
2585         (gdb_quit_bad_alloc): Update.
2586         * aarch64-tdep.c: Update.
2587         * ada-lang.c: Update.
2588         * ada-typeprint.c: Update.
2589         * ada-valprint.c: Update.
2590         * amd64-tdep.c: Update.
2591         * arch-utils.c: Update.
2592         * break-catch-throw.c: Update.
2593         * breakpoint.c: Update.
2594         * btrace.c: Update.
2595         * c-varobj.c: Update.
2596         * cli/cli-cmds.c: Update.
2597         * cli/cli-interp.c: Update.
2598         * cli/cli-script.c: Update.
2599         * common/common-exceptions.c: Update.
2600         * common/new-op.c: Update.
2601         * common/selftest.c: Update.
2602         * compile/compile-c-symbols.c: Update.
2603         * compile/compile-cplus-symbols.c: Update.
2604         * compile/compile-object-load.c: Update.
2605         * compile/compile-object-run.c: Update.
2606         * completer.c: Update.
2607         * corelow.c: Update.
2608         * cp-abi.c: Update.
2609         * cp-support.c: Update.
2610         * cp-valprint.c: Update.
2611         * darwin-nat.c: Update.
2612         * disasm-selftests.c: Update.
2613         * dtrace-probe.c: Update.
2614         * dwarf-index-cache.c: Update.
2615         * dwarf-index-write.c: Update.
2616         * dwarf2-frame-tailcall.c: Update.
2617         * dwarf2-frame.c: Update.
2618         * dwarf2loc.c: Update.
2619         * dwarf2read.c: Update.
2620         * eval.c: Update.
2621         * event-loop.c: Update.
2622         * event-top.c: Update.
2623         * exec.c: Update.
2624         * f-valprint.c: Update.
2625         * fbsd-tdep.c: Update.
2626         * frame-unwind.c: Update.
2627         * frame.c: Update.
2628         * gdbtypes.c: Update.
2629         * gnu-v3-abi.c: Update.
2630         * guile/guile-internal.h: Update.
2631         * guile/scm-block.c: Update.
2632         * guile/scm-breakpoint.c: Update.
2633         * guile/scm-cmd.c: Update.
2634         * guile/scm-disasm.c: Update.
2635         * guile/scm-frame.c: Update.
2636         * guile/scm-lazy-string.c: Update.
2637         * guile/scm-math.c: Update.
2638         * guile/scm-param.c: Update.
2639         * guile/scm-ports.c: Update.
2640         * guile/scm-pretty-print.c: Update.
2641         * guile/scm-symbol.c: Update.
2642         * guile/scm-symtab.c: Update.
2643         * guile/scm-type.c: Update.
2644         * guile/scm-value.c: Update.
2645         * i386-linux-tdep.c: Update.
2646         * i386-tdep.c: Update.
2647         * inf-loop.c: Update.
2648         * infcall.c: Update.
2649         * infcmd.c: Update.
2650         * infrun.c: Update.
2651         * jit.c: Update.
2652         * language.c: Update.
2653         * linespec.c: Update.
2654         * linux-fork.c: Update.
2655         * linux-nat.c: Update.
2656         * linux-tdep.c: Update.
2657         * linux-thread-db.c: Update.
2658         * main.c: Update.
2659         * mi/mi-cmd-break.c: Update.
2660         * mi/mi-cmd-stack.c: Update.
2661         * mi/mi-interp.c: Update.
2662         * mi/mi-main.c: Update.
2663         * objc-lang.c: Update.
2664         * p-valprint.c: Update.
2665         * parse.c: Update.
2666         * ppc-linux-tdep.c: Update.
2667         * printcmd.c: Update.
2668         * python/py-arch.c: Update.
2669         * python/py-breakpoint.c: Update.
2670         * python/py-cmd.c: Update.
2671         * python/py-finishbreakpoint.c: Update.
2672         * python/py-frame.c: Update.
2673         * python/py-framefilter.c: Update.
2674         * python/py-gdb-readline.c: Update.
2675         * python/py-inferior.c: Update.
2676         * python/py-infthread.c: Update.
2677         * python/py-lazy-string.c: Update.
2678         * python/py-linetable.c: Update.
2679         * python/py-objfile.c: Update.
2680         * python/py-param.c: Update.
2681         * python/py-prettyprint.c: Update.
2682         * python/py-progspace.c: Update.
2683         * python/py-record-btrace.c: Update.
2684         * python/py-record.c: Update.
2685         * python/py-symbol.c: Update.
2686         * python/py-type.c: Update.
2687         * python/py-unwind.c: Update.
2688         * python/py-utils.c: Update.
2689         * python/py-value.c: Update.
2690         * python/python.c: Update.
2691         * record-btrace.c: Update.
2692         * record-full.c: Update.
2693         * remote-fileio.c: Update.
2694         * remote.c: Update.
2695         * riscv-tdep.c: Update.
2696         * rs6000-aix-tdep.c: Update.
2697         * rs6000-tdep.c: Update.
2698         * rust-exp.y: Update.
2699         * rust-lang.c: Update.
2700         * s390-tdep.c: Update.
2701         * selftest-arch.c: Update.
2702         * solib-dsbt.c: Update.
2703         * solib-frv.c: Update.
2704         * solib-spu.c: Update.
2705         * solib-svr4.c: Update.
2706         * solib.c: Update.
2707         * sparc64-linux-tdep.c: Update.
2708         * stack.c: Update.
2709         * symfile-mem.c: Update.
2710         * symmisc.c: Update.
2711         * target.c: Update.
2712         * thread.c: Update.
2713         * top.c: Update.
2714         * tracefile-tfile.c: Update.
2715         * tui/tui.c: Update.
2716         * typeprint.c: Update.
2717         * unittests/cli-utils-selftests.c: Update.
2718         * unittests/parse-connection-spec-selftests.c: Update.
2719         * valops.c: Update.
2720         * valprint.c: Update.
2721         * value.c: Update.
2722         * varobj.c: Update.
2723         * windows-nat.c: Update.
2724         * x86-linux-nat.c: Update.
2725         * xml-support.c: Update.
2726
2727 2019-04-08  Tom Tromey  <tom@tromey.com>
2728
2729         * xml-support.c: Use C++ exception handling.
2730         * x86-linux-nat.c: Use C++ exception handling.
2731         * windows-nat.c: Use C++ exception handling.
2732         * varobj.c: Use C++ exception handling.
2733         * value.c: Use C++ exception handling.
2734         * valprint.c: Use C++ exception handling.
2735         * valops.c: Use C++ exception handling.
2736         * unittests/parse-connection-spec-selftests.c: Use C++ exception
2737         handling.
2738         * unittests/cli-utils-selftests.c: Use C++ exception handling.
2739         * typeprint.c: Use C++ exception handling.
2740         * tui/tui.c: Use C++ exception handling.
2741         * tracefile-tfile.c: Use C++ exception handling.
2742         * top.c: Use C++ exception handling.
2743         * thread.c: Use C++ exception handling.
2744         * target.c: Use C++ exception handling.
2745         * symmisc.c: Use C++ exception handling.
2746         * symfile-mem.c: Use C++ exception handling.
2747         * stack.c: Use C++ exception handling.
2748         * sparc64-linux-tdep.c: Use C++ exception handling.
2749         * solib.c: Use C++ exception handling.
2750         * solib-svr4.c: Use C++ exception handling.
2751         * solib-spu.c: Use C++ exception handling.
2752         * solib-frv.c: Use C++ exception handling.
2753         * solib-dsbt.c: Use C++ exception handling.
2754         * selftest-arch.c: Use C++ exception handling.
2755         * s390-tdep.c: Use C++ exception handling.
2756         * rust-lang.c: Use C++ exception handling.
2757         * rust-exp.y: Use C++ exception handling.
2758         * rs6000-tdep.c: Use C++ exception handling.
2759         * rs6000-aix-tdep.c: Use C++ exception handling.
2760         * riscv-tdep.c: Use C++ exception handling.
2761         * remote.c: Use C++ exception handling.
2762         * remote-fileio.c: Use C++ exception handling.
2763         * record-full.c: Use C++ exception handling.
2764         * record-btrace.c: Use C++ exception handling.
2765         * python/python.c: Use C++ exception handling.
2766         * python/py-value.c: Use C++ exception handling.
2767         * python/py-utils.c: Use C++ exception handling.
2768         * python/py-unwind.c: Use C++ exception handling.
2769         * python/py-type.c: Use C++ exception handling.
2770         * python/py-symbol.c: Use C++ exception handling.
2771         * python/py-record.c: Use C++ exception handling.
2772         * python/py-record-btrace.c: Use C++ exception handling.
2773         * python/py-progspace.c: Use C++ exception handling.
2774         * python/py-prettyprint.c: Use C++ exception handling.
2775         * python/py-param.c: Use C++ exception handling.
2776         * python/py-objfile.c: Use C++ exception handling.
2777         * python/py-linetable.c: Use C++ exception handling.
2778         * python/py-lazy-string.c: Use C++ exception handling.
2779         * python/py-infthread.c: Use C++ exception handling.
2780         * python/py-inferior.c: Use C++ exception handling.
2781         * python/py-gdb-readline.c: Use C++ exception handling.
2782         * python/py-framefilter.c: Use C++ exception handling.
2783         * python/py-frame.c: Use C++ exception handling.
2784         * python/py-finishbreakpoint.c: Use C++ exception handling.
2785         * python/py-cmd.c: Use C++ exception handling.
2786         * python/py-breakpoint.c: Use C++ exception handling.
2787         * python/py-arch.c: Use C++ exception handling.
2788         * printcmd.c: Use C++ exception handling.
2789         * ppc-linux-tdep.c: Use C++ exception handling.
2790         * parse.c: Use C++ exception handling.
2791         * p-valprint.c: Use C++ exception handling.
2792         * objc-lang.c: Use C++ exception handling.
2793         * mi/mi-main.c: Use C++ exception handling.
2794         * mi/mi-interp.c: Use C++ exception handling.
2795         * mi/mi-cmd-stack.c: Use C++ exception handling.
2796         * mi/mi-cmd-break.c: Use C++ exception handling.
2797         * main.c: Use C++ exception handling.
2798         * linux-thread-db.c: Use C++ exception handling.
2799         * linux-tdep.c: Use C++ exception handling.
2800         * linux-nat.c: Use C++ exception handling.
2801         * linux-fork.c: Use C++ exception handling.
2802         * linespec.c: Use C++ exception handling.
2803         * language.c: Use C++ exception handling.
2804         * jit.c: Use C++ exception handling.
2805         * infrun.c: Use C++ exception handling.
2806         * infcmd.c: Use C++ exception handling.
2807         * infcall.c: Use C++ exception handling.
2808         * inf-loop.c: Use C++ exception handling.
2809         * i386-tdep.c: Use C++ exception handling.
2810         * i386-linux-tdep.c: Use C++ exception handling.
2811         * guile/scm-value.c: Use C++ exception handling.
2812         * guile/scm-type.c: Use C++ exception handling.
2813         * guile/scm-symtab.c: Use C++ exception handling.
2814         * guile/scm-symbol.c: Use C++ exception handling.
2815         * guile/scm-pretty-print.c: Use C++ exception handling.
2816         * guile/scm-ports.c: Use C++ exception handling.
2817         * guile/scm-param.c: Use C++ exception handling.
2818         * guile/scm-math.c: Use C++ exception handling.
2819         * guile/scm-lazy-string.c: Use C++ exception handling.
2820         * guile/scm-frame.c: Use C++ exception handling.
2821         * guile/scm-disasm.c: Use C++ exception handling.
2822         * guile/scm-cmd.c: Use C++ exception handling.
2823         * guile/scm-breakpoint.c: Use C++ exception handling.
2824         * guile/scm-block.c: Use C++ exception handling.
2825         * guile/guile-internal.h: Use C++ exception handling.
2826         * gnu-v3-abi.c: Use C++ exception handling.
2827         * gdbtypes.c: Use C++ exception handling.
2828         * frame.c: Use C++ exception handling.
2829         * frame-unwind.c: Use C++ exception handling.
2830         * fbsd-tdep.c: Use C++ exception handling.
2831         * f-valprint.c: Use C++ exception handling.
2832         * exec.c: Use C++ exception handling.
2833         * event-top.c: Use C++ exception handling.
2834         * event-loop.c: Use C++ exception handling.
2835         * eval.c: Use C++ exception handling.
2836         * dwarf2read.c: Use C++ exception handling.
2837         * dwarf2loc.c: Use C++ exception handling.
2838         * dwarf2-frame.c: Use C++ exception handling.
2839         * dwarf2-frame-tailcall.c: Use C++ exception handling.
2840         * dwarf-index-write.c: Use C++ exception handling.
2841         * dwarf-index-cache.c: Use C++ exception handling.
2842         * dtrace-probe.c: Use C++ exception handling.
2843         * disasm-selftests.c: Use C++ exception handling.
2844         * darwin-nat.c: Use C++ exception handling.
2845         * cp-valprint.c: Use C++ exception handling.
2846         * cp-support.c: Use C++ exception handling.
2847         * cp-abi.c: Use C++ exception handling.
2848         * corelow.c: Use C++ exception handling.
2849         * completer.c: Use C++ exception handling.
2850         * compile/compile-object-run.c: Use C++ exception handling.
2851         * compile/compile-object-load.c: Use C++ exception handling.
2852         * compile/compile-cplus-symbols.c: Use C++ exception handling.
2853         * compile/compile-c-symbols.c: Use C++ exception handling.
2854         * common/selftest.c: Use C++ exception handling.
2855         * common/new-op.c: Use C++ exception handling.
2856         * cli/cli-script.c: Use C++ exception handling.
2857         * cli/cli-interp.c: Use C++ exception handling.
2858         * cli/cli-cmds.c: Use C++ exception handling.
2859         * c-varobj.c: Use C++ exception handling.
2860         * btrace.c: Use C++ exception handling.
2861         * breakpoint.c: Use C++ exception handling.
2862         * break-catch-throw.c: Use C++ exception handling.
2863         * arch-utils.c: Use C++ exception handling.
2864         * amd64-tdep.c: Use C++ exception handling.
2865         * ada-valprint.c: Use C++ exception handling.
2866         * ada-typeprint.c: Use C++ exception handling.
2867         * ada-lang.c: Use C++ exception handling.
2868         * aarch64-tdep.c: Use C++ exception handling.
2869
2870 2019-04-08  Tom Tromey  <tom@tromey.com>
2871
2872         * xml-support.c (gdb_xml_parser::parse): Update.
2873         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2874         * value.c (show_convenience): Update.
2875         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
2876         (test_parse_flags_qcs): Update.
2877         * thread.c (thr_try_catch_cmd): Update.
2878         * target.c (target_translate_tls_address): Update.
2879         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2880         (info_frame_command_core, frame_apply_command_count): Update.
2881         * rust-exp.y (rust_lex_exception_test): Update.
2882         * riscv-tdep.c (riscv_print_one_register_info): Update.
2883         * remote.c (remote_target::enable_btrace): Update.
2884         * record-btrace.c (record_btrace_enable_warn): Update.
2885         * python/py-utils.c (gdbpy_convert_exception): Update.
2886         * printcmd.c (do_one_display, print_variable_and_value): Update.
2887         * mi/mi-main.c (mi_print_exception): Update.
2888         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
2889         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2890         * linux-nat.c (linux_nat_target::attach): Update.
2891         * linux-fork.c (class scoped_switch_fork_info): Update.
2892         * infrun.c (displaced_step_prepare): Update.
2893         * infcall.c (call_function_by_hand_dummy): Update.
2894         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
2895         * gnu-v3-abi.c (print_one_vtable): Update.
2896         * frame.c (get_prev_frame_always): Update.
2897         * f-valprint.c (info_common_command_for_block): Update.
2898         * exec.c (try_open_exec_file): Update.
2899         * exceptions.c (print_exception, exception_print)
2900         (exception_fprintf, exception_print_same): Update.
2901         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
2902         * dwarf-index-cache.c (index_cache::store)
2903         (index_cache::lookup_gdb_index): Update.
2904         * darwin-nat.c (maybe_cache_shell): Update.
2905         * cp-valprint.c (cp_print_value_fields): Update.
2906         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
2907         (gcc_cplus_symbol_address): Update.
2908         * compile/compile-c-symbols.c (gcc_convert_symbol)
2909         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
2910         * common/selftest.c: Update.
2911         * common/common-exceptions.h (struct gdb_exception) <message>: Now
2912         a std::string.
2913         (exception_try_scope_entry, exception_try_scope_exit): Don't
2914         declare.
2915         (struct exception_try_scope): Remove.
2916         (TRY): Don't use exception_try_scope.
2917         (struct gdb_exception): Add constructor, operator=.
2918         <what>: New method.
2919         (struct gdb_exception_RETURN_MASK_ALL)
2920         (struct gdb_exception_RETURN_MASK_ERROR)
2921         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
2922         (struct gdb_quit_bad_alloc): Update.
2923         * common/common-exceptions.c (exception_none): Change
2924         initializer.
2925         (struct catcher) <state, exception>: Initialize inline.
2926         <prev>: Remove member.
2927         (current_catcher): Remove.
2928         (catchers): New global.
2929         (exceptions_state_mc_init): Simplify.
2930         (catcher_pop): Remove.
2931         (exceptions_state_mc, exceptions_state_mc_catch): Update.
2932         (try_scope_depth, exception_try_scope_entry)
2933         (exception_try_scope_exit): Remove.
2934         (throw_exception_sjlj): Update.
2935         (exception_messages, exception_messages_size): Remove.
2936         (throw_it): Simplify.
2937         (gdb_exception_sliced_copy): Remove.
2938         (throw_exception_cxx): Update.
2939         * cli/cli-script.c (script_from_file): Update.
2940         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
2941         Update.
2942         * ada-valprint.c (ada_val_print): Update.
2943         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
2944         (create_excep_cond_exprs): Update.
2945
2946 2019-04-08  Tom Tromey  <tom@tromey.com>
2947
2948         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
2949         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
2950         (TRY, CATCH, END_CATCH): Remove some definitions.
2951         * common/common-exceptions.c: Don't use GDB_XCPT.
2952         (catcher_list_size): Remove.
2953         (throw_exception, throw_it): Simplify.
2954
2955 2019-04-05  Tom Tromey  <tom@tromey.com>
2956
2957         Revert the header-sorting patch.
2958         * ft32-tdep.c: Revert.
2959         * frv-tdep.c: Revert.
2960         * frv-linux-tdep.c: Revert.
2961         * frame.c: Revert.
2962         * frame-unwind.c: Revert.
2963         * frame-base.c: Revert.
2964         * fork-child.c: Revert.
2965         * findvar.c: Revert.
2966         * findcmd.c: Revert.
2967         * filesystem.c: Revert.
2968         * filename-seen-cache.h: Revert.
2969         * filename-seen-cache.c: Revert.
2970         * fbsd-tdep.c: Revert.
2971         * fbsd-nat.h: Revert.
2972         * fbsd-nat.c: Revert.
2973         * f-valprint.c: Revert.
2974         * f-typeprint.c: Revert.
2975         * f-lang.c: Revert.
2976         * extension.h: Revert.
2977         * extension.c: Revert.
2978         * extension-priv.h: Revert.
2979         * expprint.c: Revert.
2980         * exec.h: Revert.
2981         * exec.c: Revert.
2982         * exceptions.c: Revert.
2983         * event-top.c: Revert.
2984         * event-loop.c: Revert.
2985         * eval.c: Revert.
2986         * elfread.c: Revert.
2987         * dwarf2read.h: Revert.
2988         * dwarf2read.c: Revert.
2989         * dwarf2loc.c: Revert.
2990         * dwarf2expr.h: Revert.
2991         * dwarf2expr.c: Revert.
2992         * dwarf2-frame.c: Revert.
2993         * dwarf2-frame-tailcall.c: Revert.
2994         * dwarf-index-write.h: Revert.
2995         * dwarf-index-write.c: Revert.
2996         * dwarf-index-common.c: Revert.
2997         * dwarf-index-cache.h: Revert.
2998         * dwarf-index-cache.c: Revert.
2999         * dummy-frame.c: Revert.
3000         * dtrace-probe.c: Revert.
3001         * disasm.h: Revert.
3002         * disasm.c: Revert.
3003         * disasm-selftests.c: Revert.
3004         * dictionary.c: Revert.
3005         * dicos-tdep.c: Revert.
3006         * demangle.c: Revert.
3007         * dcache.h: Revert.
3008         * dcache.c: Revert.
3009         * darwin-nat.h: Revert.
3010         * darwin-nat.c: Revert.
3011         * darwin-nat-info.c: Revert.
3012         * d-valprint.c: Revert.
3013         * d-namespace.c: Revert.
3014         * d-lang.c: Revert.
3015         * ctf.c: Revert.
3016         * csky-tdep.c: Revert.
3017         * csky-linux-tdep.c: Revert.
3018         * cris-tdep.c: Revert.
3019         * cris-linux-tdep.c: Revert.
3020         * cp-valprint.c: Revert.
3021         * cp-support.c: Revert.
3022         * cp-namespace.c: Revert.
3023         * cp-abi.c: Revert.
3024         * corelow.c: Revert.
3025         * corefile.c: Revert.
3026         * continuations.c: Revert.
3027         * completer.h: Revert.
3028         * completer.c: Revert.
3029         * complaints.c: Revert.
3030         * coffread.c: Revert.
3031         * coff-pe-read.c: Revert.
3032         * cli-out.h: Revert.
3033         * cli-out.c: Revert.
3034         * charset.c: Revert.
3035         * c-varobj.c: Revert.
3036         * c-valprint.c: Revert.
3037         * c-typeprint.c: Revert.
3038         * c-lang.c: Revert.
3039         * buildsym.c: Revert.
3040         * buildsym-legacy.c: Revert.
3041         * build-id.h: Revert.
3042         * build-id.c: Revert.
3043         * btrace.c: Revert.
3044         * bsd-uthread.c: Revert.
3045         * breakpoint.h: Revert.
3046         * breakpoint.c: Revert.
3047         * break-catch-throw.c: Revert.
3048         * break-catch-syscall.c: Revert.
3049         * break-catch-sig.c: Revert.
3050         * blockframe.c: Revert.
3051         * block.c: Revert.
3052         * bfin-tdep.c: Revert.
3053         * bfin-linux-tdep.c: Revert.
3054         * bfd-target.c: Revert.
3055         * bcache.c: Revert.
3056         * ax-general.c: Revert.
3057         * ax-gdb.h: Revert.
3058         * ax-gdb.c: Revert.
3059         * avr-tdep.c: Revert.
3060         * auxv.c: Revert.
3061         * auto-load.c: Revert.
3062         * arm-wince-tdep.c: Revert.
3063         * arm-tdep.c: Revert.
3064         * arm-symbian-tdep.c: Revert.
3065         * arm-pikeos-tdep.c: Revert.
3066         * arm-obsd-tdep.c: Revert.
3067         * arm-nbsd-tdep.c: Revert.
3068         * arm-nbsd-nat.c: Revert.
3069         * arm-linux-tdep.c: Revert.
3070         * arm-linux-nat.c: Revert.
3071         * arm-fbsd-tdep.c: Revert.
3072         * arm-fbsd-nat.c: Revert.
3073         * arm-bsd-tdep.c: Revert.
3074         * arch-utils.c: Revert.
3075         * arc-tdep.c: Revert.
3076         * arc-newlib-tdep.c: Revert.
3077         * annotate.h: Revert.
3078         * annotate.c: Revert.
3079         * amd64-windows-tdep.c: Revert.
3080         * amd64-windows-nat.c: Revert.
3081         * amd64-tdep.c: Revert.
3082         * amd64-sol2-tdep.c: Revert.
3083         * amd64-obsd-tdep.c: Revert.
3084         * amd64-obsd-nat.c: Revert.
3085         * amd64-nbsd-tdep.c: Revert.
3086         * amd64-nbsd-nat.c: Revert.
3087         * amd64-nat.c: Revert.
3088         * amd64-linux-tdep.c: Revert.
3089         * amd64-linux-nat.c: Revert.
3090         * amd64-fbsd-tdep.c: Revert.
3091         * amd64-fbsd-nat.c: Revert.
3092         * amd64-dicos-tdep.c: Revert.
3093         * amd64-darwin-tdep.c: Revert.
3094         * amd64-bsd-nat.c: Revert.
3095         * alpha-tdep.c: Revert.
3096         * alpha-obsd-tdep.c: Revert.
3097         * alpha-nbsd-tdep.c: Revert.
3098         * alpha-mdebug-tdep.c: Revert.
3099         * alpha-linux-tdep.c: Revert.
3100         * alpha-linux-nat.c: Revert.
3101         * alpha-bsd-tdep.c: Revert.
3102         * alpha-bsd-nat.c: Revert.
3103         * aix-thread.c: Revert.
3104         * agent.c: Revert.
3105         * addrmap.c: Revert.
3106         * ada-varobj.c: Revert.
3107         * ada-valprint.c: Revert.
3108         * ada-typeprint.c: Revert.
3109         * ada-tasks.c: Revert.
3110         * ada-lang.c: Revert.
3111         * aarch64-tdep.c: Revert.
3112         * aarch64-ravenscar-thread.c: Revert.
3113         * aarch64-newlib-tdep.c: Revert.
3114         * aarch64-linux-tdep.c: Revert.
3115         * aarch64-linux-nat.c: Revert.
3116         * aarch64-fbsd-tdep.c: Revert.
3117         * aarch64-fbsd-nat.c: Revert.
3118         * aarch32-linux-nat.c: Revert.
3119
3120 2019-04-05  Tom Tromey  <tom@tromey.com>
3121
3122         * ft32-tdep.c: Sort headers.
3123         * frv-tdep.c: Sort headers.
3124         * frv-linux-tdep.c: Sort headers.
3125         * frame.c: Sort headers.
3126         * frame-unwind.c: Sort headers.
3127         * frame-base.c: Sort headers.
3128         * fork-child.c: Sort headers.
3129         * findvar.c: Sort headers.
3130         * findcmd.c: Sort headers.
3131         * filesystem.c: Sort headers.
3132         * filename-seen-cache.h: Sort headers.
3133         * filename-seen-cache.c: Sort headers.
3134         * fbsd-tdep.c: Sort headers.
3135         * fbsd-nat.h: Sort headers.
3136         * fbsd-nat.c: Sort headers.
3137         * f-valprint.c: Sort headers.
3138         * f-typeprint.c: Sort headers.
3139         * f-lang.c: Sort headers.
3140         * extension.h: Sort headers.
3141         * extension.c: Sort headers.
3142         * extension-priv.h: Sort headers.
3143         * expprint.c: Sort headers.
3144         * exec.h: Sort headers.
3145         * exec.c: Sort headers.
3146         * exceptions.c: Sort headers.
3147         * event-top.c: Sort headers.
3148         * event-loop.c: Sort headers.
3149         * eval.c: Sort headers.
3150         * elfread.c: Sort headers.
3151         * dwarf2read.h: Sort headers.
3152         * dwarf2read.c: Sort headers.
3153         * dwarf2loc.c: Sort headers.
3154         * dwarf2expr.h: Sort headers.
3155         * dwarf2expr.c: Sort headers.
3156         * dwarf2-frame.c: Sort headers.
3157         * dwarf2-frame-tailcall.c: Sort headers.
3158         * dwarf-index-write.h: Sort headers.
3159         * dwarf-index-write.c: Sort headers.
3160         * dwarf-index-common.c: Sort headers.
3161         * dwarf-index-cache.h: Sort headers.
3162         * dwarf-index-cache.c: Sort headers.
3163         * dummy-frame.c: Sort headers.
3164         * dtrace-probe.c: Sort headers.
3165         * disasm.h: Sort headers.
3166         * disasm.c: Sort headers.
3167         * disasm-selftests.c: Sort headers.
3168         * dictionary.c: Sort headers.
3169         * dicos-tdep.c: Sort headers.
3170         * demangle.c: Sort headers.
3171         * dcache.h: Sort headers.
3172         * dcache.c: Sort headers.
3173         * darwin-nat.h: Sort headers.
3174         * darwin-nat.c: Sort headers.
3175         * darwin-nat-info.c: Sort headers.
3176         * d-valprint.c: Sort headers.
3177         * d-namespace.c: Sort headers.
3178         * d-lang.c: Sort headers.
3179         * ctf.c: Sort headers.
3180         * csky-tdep.c: Sort headers.
3181         * csky-linux-tdep.c: Sort headers.
3182         * cris-tdep.c: Sort headers.
3183         * cris-linux-tdep.c: Sort headers.
3184         * cp-valprint.c: Sort headers.
3185         * cp-support.c: Sort headers.
3186         * cp-namespace.c: Sort headers.
3187         * cp-abi.c: Sort headers.
3188         * corelow.c: Sort headers.
3189         * corefile.c: Sort headers.
3190         * continuations.c: Sort headers.
3191         * completer.h: Sort headers.
3192         * completer.c: Sort headers.
3193         * complaints.c: Sort headers.
3194         * coffread.c: Sort headers.
3195         * coff-pe-read.c: Sort headers.
3196         * cli-out.h: Sort headers.
3197         * cli-out.c: Sort headers.
3198         * charset.c: Sort headers.
3199         * c-varobj.c: Sort headers.
3200         * c-valprint.c: Sort headers.
3201         * c-typeprint.c: Sort headers.
3202         * c-lang.c: Sort headers.
3203         * buildsym.c: Sort headers.
3204         * buildsym-legacy.c: Sort headers.
3205         * build-id.h: Sort headers.
3206         * build-id.c: Sort headers.
3207         * btrace.c: Sort headers.
3208         * bsd-uthread.c: Sort headers.
3209         * breakpoint.h: Sort headers.
3210         * breakpoint.c: Sort headers.
3211         * break-catch-throw.c: Sort headers.
3212         * break-catch-syscall.c: Sort headers.
3213         * break-catch-sig.c: Sort headers.
3214         * blockframe.c: Sort headers.
3215         * block.c: Sort headers.
3216         * bfin-tdep.c: Sort headers.
3217         * bfin-linux-tdep.c: Sort headers.
3218         * bfd-target.c: Sort headers.
3219         * bcache.c: Sort headers.
3220         * ax-general.c: Sort headers.
3221         * ax-gdb.h: Sort headers.
3222         * ax-gdb.c: Sort headers.
3223         * avr-tdep.c: Sort headers.
3224         * auxv.c: Sort headers.
3225         * auto-load.c: Sort headers.
3226         * arm-wince-tdep.c: Sort headers.
3227         * arm-tdep.c: Sort headers.
3228         * arm-symbian-tdep.c: Sort headers.
3229         * arm-pikeos-tdep.c: Sort headers.
3230         * arm-obsd-tdep.c: Sort headers.
3231         * arm-nbsd-tdep.c: Sort headers.
3232         * arm-nbsd-nat.c: Sort headers.
3233         * arm-linux-tdep.c: Sort headers.
3234         * arm-linux-nat.c: Sort headers.
3235         * arm-fbsd-tdep.c: Sort headers.
3236         * arm-fbsd-nat.c: Sort headers.
3237         * arm-bsd-tdep.c: Sort headers.
3238         * arch-utils.c: Sort headers.
3239         * arc-tdep.c: Sort headers.
3240         * arc-newlib-tdep.c: Sort headers.
3241         * annotate.h: Sort headers.
3242         * annotate.c: Sort headers.
3243         * amd64-windows-tdep.c: Sort headers.
3244         * amd64-windows-nat.c: Sort headers.
3245         * amd64-tdep.c: Sort headers.
3246         * amd64-sol2-tdep.c: Sort headers.
3247         * amd64-obsd-tdep.c: Sort headers.
3248         * amd64-obsd-nat.c: Sort headers.
3249         * amd64-nbsd-tdep.c: Sort headers.
3250         * amd64-nbsd-nat.c: Sort headers.
3251         * amd64-nat.c: Sort headers.
3252         * amd64-linux-tdep.c: Sort headers.
3253         * amd64-linux-nat.c: Sort headers.
3254         * amd64-fbsd-tdep.c: Sort headers.
3255         * amd64-fbsd-nat.c: Sort headers.
3256         * amd64-dicos-tdep.c: Sort headers.
3257         * amd64-darwin-tdep.c: Sort headers.
3258         * amd64-bsd-nat.c: Sort headers.
3259         * alpha-tdep.c: Sort headers.
3260         * alpha-obsd-tdep.c: Sort headers.
3261         * alpha-nbsd-tdep.c: Sort headers.
3262         * alpha-mdebug-tdep.c: Sort headers.
3263         * alpha-linux-tdep.c: Sort headers.
3264         * alpha-linux-nat.c: Sort headers.
3265         * alpha-bsd-tdep.c: Sort headers.
3266         * alpha-bsd-nat.c: Sort headers.
3267         * aix-thread.c: Sort headers.
3268         * agent.c: Sort headers.
3269         * addrmap.c: Sort headers.
3270         * ada-varobj.c: Sort headers.
3271         * ada-valprint.c: Sort headers.
3272         * ada-typeprint.c: Sort headers.
3273         * ada-tasks.c: Sort headers.
3274         * ada-lang.c: Sort headers.
3275         * aarch64-tdep.c: Sort headers.
3276         * aarch64-ravenscar-thread.c: Sort headers.
3277         * aarch64-newlib-tdep.c: Sort headers.
3278         * aarch64-linux-tdep.c: Sort headers.
3279         * aarch64-linux-nat.c: Sort headers.
3280         * aarch64-fbsd-tdep.c: Sort headers.
3281         * aarch64-fbsd-nat.c: Sort headers.
3282         * aarch32-linux-nat.c: Sort headers.
3283
3284 2019-04-04  Tom Tromey  <tom@tromey.com>
3285
3286         * varobj.c (varobj_create): Update.
3287         * rust-exp.y (struct rust_parser) <update_innermost_block,
3288         lookup_symbol>: New methods.
3289         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3290         Rename.
3291         (rust_parser::rust_lookup_type)
3292         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3293         * printcmd.c (display_command, do_one_display): Update.
3294         * parser-defs.h (struct parser_state) <parser_state>: Add
3295         "tracker" parameter.
3296         (block_tracker): New member.
3297         (class innermost_block_tracker) <innermost_block_tracker>: Add
3298         "types" parameter.
3299         <reset>: Remove method.
3300         (innermost_block): Don't declare.
3301         (null_post_parser): Update.
3302         * parse.c (innermost_block): Remove global.
3303         (write_dollar_variable): Update.
3304         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3305         Remove "tracker_types" parameter.
3306         (parse_expression): Add "tracker" parameter.
3307         (parse_expression_for_completion): Update.
3308         (null_post_parser): Add "tracker" parameter.
3309         * p-exp.y: Update rules.
3310         * m2-exp.y: Update rules.
3311         * language.h (struct language_defn) <la_post_parser>: Add
3312         "tracker" parameter.
3313         * go-exp.y: Update rules.
3314         * f-exp.y: Update rules.
3315         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3316         parameter.
3317         * d-exp.y: Update rules.
3318         * c-exp.y: Update rules.
3319         * breakpoint.c (set_breakpoint_condition): Create an
3320         innermost_block_tracker.
3321         (watch_command_1): Likewise.
3322         * ada-lang.c (resolve): Add "tracker" parameter.
3323         (resolve_subexp): Likewise.
3324         * ada-exp.y (write_var_from_sym): Update.
3325
3326 2019-04-04  Tom Tromey  <tom@tromey.com>
3327
3328         * type-stack.h: New file.
3329         * type-stack.c: New file.
3330         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3331         type-stack.h.
3332         (insert_into_type_stack, insert_type, push_type, push_type_int)
3333         (insert_type_address_space, pop_type, pop_type_int)
3334         (pop_typelist, pop_type_stack, append_type_stack)
3335         (push_type_stack, get_type_stack, push_typelist)
3336         (follow_type_instance_flags, follow_types): Don't declare.
3337         * parse.c (type_stack): Remove global.
3338         (parse_exp_in_context): Update.
3339         (insert_into_type_stack, insert_type, push_type, push_type_int)
3340         (insert_type_address_space, pop_type, pop_type_int)
3341         (pop_typelist, pop_type_stack, append_type_stack)
3342         (push_type_stack, get_type_stack, push_typelist)
3343         (follow_type_instance_flags, follow_types): Remove (moved to
3344         type-stack.c).
3345         * f-exp.y (type_stack): New global.
3346         Update rules.
3347         (push_kind_type, f_parse): Update.
3348         * d-exp.y (type_stack): New global.
3349         Update rules.
3350         (d_parse): Update.
3351         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3352         Update rules.
3353         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3354         (HFILES_NO_SRCDIR): Add type-stack.h.
3355
3356 2019-04-04  Tom Tromey  <tom@tromey.com>
3357
3358         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3359         (rust_parser::convert_ast_to_expression, rust_parse)
3360         (rust_lex_test_completion, rust_lex_tests): Update.
3361         * parser-defs.h (struct expr_completion_state): New.
3362         (struct parser_state) <parser_state>: Add completion parameter.
3363         <mark_struct_expression, mark_completion_tag>: New methods.
3364         <parse_completion, m_completion_state>: New members.
3365         (prefixify_expression, null_post_parser): Update.
3366         (mark_struct_expression, mark_completion_tag): Don't declare.
3367         * parse.c (parse_completion, expout_last_struct)
3368         (expout_tag_completion_type, expout_completion_name): Remove
3369         globals.
3370         (parser_state::mark_struct_expression)
3371         (parser_state::mark_completion_tag): Now methods.
3372         (prefixify_expression): Add last_struct parameter.
3373         (prefixify_subexp): Likewise.
3374         (parse_exp_1): Update.
3375         (parse_exp_in_context): Add cstate parameter.  Update.
3376         (parse_expression_for_completion): Create an
3377         expr_completion_state.
3378         (null_post_parser): Add "completion" parameter.
3379         * p-exp.y: Update rules.
3380         (yylex): Update.
3381         * language.h (struct language_defn) <la_post_parser>: Add
3382         "completing" parameter.
3383         * go-exp.y: Update rules.
3384         (lex_one_token): Update.
3385         * expression.h (parse_completion): Don't declare.
3386         * d-exp.y: Update rules.
3387         (lex_one_token): Update rules.
3388         * c-exp.y: Update rules.
3389         (lex_one_token): Update.
3390         * ada-lang.c (resolve): Add "parse_completion" parameter.
3391         (resolve_subexp): Likewise.
3392         (ada_resolve_function): Likewise.
3393
3394 2019-04-04  Tom Tromey  <tom@tromey.com>
3395
3396         * parser-defs.h (struct parser_state) <start_arglist,
3397         end_arglist>: New methods.
3398         <arglist_len, m_funcall_chain>: New members.
3399         (arglist_len, start_arglist, end_arglist): Don't declare.
3400         * parse.c (arglist_len, funcall_chain): Remove global.
3401         (start_arglist, end_arglist): Remove functions.
3402         (parse_exp_in_context): Update.
3403         * p-exp.y: Update rules.
3404         * m2-exp.y: Update rules.
3405         * go-exp.y: Update rules.
3406         * f-exp.y: Update rules.
3407         * d-exp.y: Update rules.
3408         * c-exp.y: Update rules.
3409
3410 2019-04-04  Tom Tromey  <tom@tromey.com>
3411
3412         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
3413         lex_operator, push_back>: New methods.
3414         Update all rules.
3415         (rust_parser::lex_hex, lex_escape): Rename and update.
3416         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
3417         (rust_parser::lex_operator): Rename and update.
3418         (rust_parser::lex_number, rustyylex, rustyyerror)
3419         (rust_lex_test_init, rust_lex_test_sequence)
3420         (rust_lex_test_push_back, rust_lex_tests): Update.
3421         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
3422         parameter.
3423         <lexptr, prev_lexptr>: New members.
3424         (lexptr, prev_lexptr): Don't declare.
3425         * parse.c (lexptr, prev_lexptr): Remove globals.
3426         (parse_exp_in_context): Update.
3427         * p-exp.y (yylex, yyerror): Update.
3428         * m2-exp.y (parse_number, yylex, yyerror): Update.
3429         * go-exp.y (lex_one_token, yyerror): Update.
3430         * f-exp.y (match_string_literal, yylex, yyerror): Update.
3431         * d-exp.y (lex_one_token, yyerror): Update.
3432         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
3433         (lex_one_token, yyerror): Update.
3434         * ada-lex.l (YY_INPUT): Update.
3435         (rewind_to_char): Update.
3436         * ada-exp.y (yyerror): Update.
3437
3438 2019-04-04  Tom Tromey  <tom@tromey.com>
3439
3440         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3441         * parser-defs.h (struct parser_state) <parser_state>: Add new
3442         parameter.
3443         <comma_terminates>: New member.
3444         (comma_terminates): Don't declare global.
3445         * parse.c (comma_terminates): Remove global.
3446         (parse_exp_in_context): Update.
3447         * p-exp.y (yylex): Update.
3448         * m2-exp.y (yylex): Update.
3449         * go-exp.y (lex_one_token): Update.
3450         * f-exp.y (yylex): Update.
3451         * d-exp.y (lex_one_token): Update.
3452         * c-exp.y (lex_one_token): Update.
3453         * ada-lex.l: Update.
3454
3455 2019-04-04  Tom Tromey  <tom@tromey.com>
3456
3457         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
3458         (rustyylex, rust_lex_test_init, rust_lex_test_one)
3459         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
3460         * parser-defs.h (paren_depth): Don't declare.
3461         * parse.c (paren_depth): Remove global.
3462         (parse_exp_in_context): Update.
3463         * p-exp.y (paren_depth): New global.
3464         (pascal_parse): Initialize it.
3465         * m2-exp.y (paren_depth): New global.
3466         (m2_parse): Initialize it.
3467         * go-exp.y (paren_depth): New global.
3468         (go_parse): Initialize it.
3469         * f-exp.y (paren_depth): New global.
3470         (f_parse): Initialize it.
3471         * d-exp.y (paren_depth): New global.
3472         (d_parse): Initialize it.
3473         * c-exp.y (paren_depth): New global.
3474         (c_parse): Initialize it.
3475         * ada-lex.l (paren_depth): New global.
3476         (lexer_init): Initialize it.
3477
3478 2019-04-04  Tom Tromey  <tom@tromey.com>
3479
3480         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
3481         (rust_parser::convert_ast_to_type)
3482         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3483         * parser-defs.h (struct parser_state) <parser_state>: Add
3484         parameters.  Initialize new members.
3485         <expression_context_block, expression_context_pc>: New members.
3486         * parse.c (expression_context_block, expression_context_pc):
3487         Remove globals.
3488         (parse_exp_in_context): Update.
3489         * p-exp.y: Update all rules.
3490         (yylex): Update.
3491         * m2-exp.y: Update all rules.
3492         (yylex): Update.
3493         * go-exp.y (yylex): Update.
3494         * f-exp.y (yylex): Update.
3495         * d-exp.y: Update all rules.
3496         (yylex): Update.
3497         * c-exp.y: Update all rules.
3498         (lex_one_token, classify_name, yylex, c_parse): Update.
3499         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
3500
3501 2019-04-04  Tom Tromey  <tom@tromey.com>
3502
3503         * gdbarch.h, gdbarch.c: Rebuild.
3504         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
3505         * stap-probe.h:
3506         (struct stap_parse_info): Replace "parser_state" with
3507         "expr_builder".
3508         * parser-defs.h (struct expr_builder): Rename from "parser_state".
3509         (parser_state): New class.
3510         * parse.c (expr_builder): Rename.
3511         (expr_builder::release): Rename.
3512         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
3513         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
3514         (write_exp_elt_longcst, write_exp_elt_floatcst)
3515         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
3516         (write_exp_string_vector, write_exp_bitstring)
3517         (write_exp_msymbol, mark_struct_expression)
3518         (write_dollar_variable)
3519         (insert_type_address_space, increase_expout_size): Replace
3520         "parser_state" with "expr_builder".
3521         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
3522         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
3523         "parser_state" with "expr_builder".
3524
3525 2019-04-04  Tom Tromey  <tom@tromey.com>
3526
3527         * rust-exp.y: Replace "parse_language" with method call.
3528         * p-exp.y:
3529         (yylex): Replace "parse_language" with method call.
3530         * m2-exp.y:
3531         (yylex): Replace "parse_language" with method call.
3532         * go-exp.y (classify_name): Replace "parse_language" with method
3533         call.
3534         * f-exp.y (yylex): Replace "parse_language" with method call.
3535         * d-exp.y (lex_one_token): Replace "parse_language" with method
3536         call.
3537         * c-exp.y:
3538         (lex_one_token, classify_name, yylex): Replace "parse_language"
3539         with method call.
3540         * ada-exp.y (find_primitive_type, type_char)
3541         (type_system_address): Replace "parse_language" with method call.
3542
3543 2019-04-04  Tom Tromey  <tom@tromey.com>
3544
3545         * rust-exp.y: Replace "parse_gdbarch" with method call.
3546         * parse.c (write_dollar_variable, insert_type_address_space):
3547         Replace "parse_gdbarch" with method call.
3548         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
3549         call.
3550         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
3551         call.
3552         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
3553         "parse_gdbarch" with method call.
3554         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
3555         with method call.
3556         * f-exp.y (parse_type, parse_f_type, yylex): Replace
3557         "parse_gdbarch" with method call.
3558         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
3559         "parse_gdbarch" with method call.
3560         * c-exp.y (parse_type, parse_number, classify_name): Replace
3561         "parse_gdbarch" with method call.
3562         * ada-lex.l: Replace "parse_gdbarch" with method call.
3563         * ada-exp.y (parse_type, find_primitive_type, type_char)
3564         (type_system_address): Replace "parse_gdbarch" with method call.
3565
3566 2019-04-04  Tom Tromey  <tom@tromey.com>
3567
3568         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
3569         * stap-probe.c (stap_parse_argument): Update.
3570         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
3571         initial_size parameter.
3572         * rust-exp.y (rust_lex_tests): Update.
3573         * parse.c (parser_state): Update.
3574         (parse_exp_in_context): Update.
3575         * parser-defs.h (struct parser_state) <parser_state>: Remove
3576         "initial_size" parameter.
3577
3578 2019-04-04  Tom Tromey  <tom@tromey.com>
3579
3580         * parser-defs.h (increase_expout_size): Don't declare.
3581         * parse.c (increase_expout_size): Now static.
3582
3583 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
3584
3585         * gnu-nat.c (gnu_nat_target::wait): Fix
3586         target_waitstatus_to_string call.
3587
3588 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3589
3590         * eval.c (evaluate_subexp_standard): Handle internal functions
3591         during Fortran function call handling.
3592
3593 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3594
3595         * NEWS: Mention new internal functions.
3596         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
3597         (read_base_type): Use dwarf2_init_complex_target_type.
3598         * value.c (creal_internal_fn): New function.
3599         (cimag_internal_fn): New function.
3600         (_initialize_values): Register new internal functions.
3601
3602 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3603
3604         * infrun.c (stop_all_threads): If debug_infrun, always
3605         trace the wait status after wait_one, using
3606         target_waitstatus_to_string and target_pid_to_str.
3607         (handle_inferior_event): Replace various trace of
3608         wait status kind by a single trace.
3609         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
3610         wait status kind image by target_waitstatus_to_string.
3611         * target/waitstatus.c (target_waitstatus_to_string): Fix
3612         obsolete comment.
3613
3614 2019-04-01  Tom Tromey  <tromey@adacore.com>
3615
3616         PR symtab/23331:
3617         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
3618
3619 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
3620             Pedro Alves  <palves@redhat.com>
3621
3622         * top.c (quit_force): Call 'finalize_values'.
3623         * value.c (finalize_values): New function.
3624         * value.h (finalize_values): Declare.
3625
3626 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
3627
3628         * NEWS: Announce $_gdb_major and $_gdb_minor.
3629
3630         * top.c (init_gdb_version_vars): New function.
3631         (gdb_init): Call init_gdb_version_vars.
3632
3633 2019-03-29  Tom Tromey  <tromey@adacore.com>
3634
3635         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
3636         help text.  Remove dead code.
3637
3638 2019-03-29  Keith Seitz  <keiths@redhat.com>
3639
3640         From Siddhesh Poyarekar:
3641         * f-lang.h (f77_get_upperbound): Return LONGEST.
3642         (f77_get_lowerbound): Likewise.
3643         * f-typeprint.c (f_type_print_varspec_suffix): Expand
3644         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
3645         print them.
3646         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
3647         plongest to format print it.
3648         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
3649         (f77_get_upperbound): Likewise.
3650         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
3651         LOWER_BOUND to LONGEST.
3652         (f77_create_arrayprint_offset_tbl): Likewise.
3653
3654 2019-03-29  Keith Seitz  <keiths@redhat.com>
3655
3656         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
3657         %s/pulongest for TYPE_LENGTH instead of %d in format
3658         strings.
3659         * ada-typerint.c (ada_print_type): Likewise.
3660         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
3661         * compile/compile-c-support.c (generate_register_struct): Likewise.
3662         * gdbtypes.c (recursive_dump_type): Likewise.
3663         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
3664         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
3665         instead of %d in format strings.
3666         * riscv-tdep.c (riscv_type_alignment): Cast second argument
3667         to std::min to ULONGEST.
3668         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
3669         instead of %d in format strings.
3670         * tracepoint.c (info_scope_command): Likewise.
3671         * typeprint.c (print_offset_data::update)
3672         (print_offset_data::finish): Likewise.
3673         * xtensa-tdep.c (xtensa_store_return_value)
3674         (xtensa_push_dummy_call): Likewise.
3675
3676 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
3677
3678         * windows-nat.c (display_selector): Fixed format specifications
3679         for 64-bit Cygwin.
3680
3681 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3682
3683         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
3684
3685 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
3686
3687         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
3688         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
3689         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
3690         (nios2_linux_init_abi): Install it.
3691
3692 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3693
3694         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
3695
3696 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3697
3698         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
3699
3700 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3701             Tom Tromey  <tromey@adacore.com>
3702
3703         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
3704
3705 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
3706
3707         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
3708         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
3709         method to compute the bounds of range types. Also print "[evaluated]"
3710         if the bounds' values come from a dynamic evaluation.
3711
3712 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3713
3714         * cp-valprint.c (cp_print_value_fields): Don't print trailing
3715         whitespace when pretty printing is on.
3716
3717 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3718
3719         * ppc-linux-nat.c: Add include.
3720
3721 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3722
3723         * NEWS: Mention AArch64 Pointer Authentication.
3724
3725 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3726
3727         * arm-linux-nat.c: Add include.
3728
3729 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
3730
3731         * source-cache.c (source_cache::get_source_lines): Re-read
3732         fullname after calling open_source_file.
3733
3734 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
3735
3736         * NEWS: Mention TLS support for FreeBSD.
3737
3738 2019-03-25  Tom Tromey  <tromey@adacore.com>
3739
3740         * minsyms.c (BUNCH_SIZE): Update comment.
3741         (~minimal_symbol_reader): Remove old comment.
3742         (compact_minimal_symbols): Update comment.
3743         (minimal_symbol_reader::install): Remove old comment.  Update
3744         other comments.
3745
3746 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3747
3748         * s390-linux-nat.c: Add include.
3749
3750 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3751
3752         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3753         Call linux_get_hwcap.
3754         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3755         Likewise.
3756         (aarch64_linux_get_hwcap): Remove function.
3757         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
3758         declaration.
3759         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
3760         linux_get_hwcap.
3761         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3762         * linux-tdep.c (linux_get_hwcap): Add function.
3763         (linux_get_hwcap2): Likewise.
3764         * linux-tdep.h (linux_get_hwcap): Add declaration.
3765         (linux_get_hwcap2): Likewise.
3766         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
3767         (ppc_linux_get_hwcap2): Likewise.
3768         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
3769         linux_get_hwcap.
3770         (ppc_linux_nat_target::insert_watchpoint): Likewise.
3771         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
3772         (ppc_linux_nat_target::read_description): Likewise.
3773         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
3774         * s390-linux-nat.c: Likewise.
3775         * s390-linux-tdep.c (s390_core_read_description): Likewise.
3776
3777 2019-03-24  Tom Tromey  <tom@tromey.com>
3778
3779         * ada-lang.c (standard_lookup): Simplify initialization.
3780         (ada_lookup_symbol_nonlocal): Simplify return.
3781         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
3782         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
3783         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
3784         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
3785         initialization.
3786         * solib.c (solib_global_lookup): Simplify.
3787         * symtab.c (null_block_symbol): Remove.
3788         (symbol_cache_lookup): Simplify returns.
3789         (lookup_language_this): Simplify returns.
3790         (lookup_symbol_aux): Simplify return.
3791         (lookup_local_symbol): Simplify returns.
3792         (lookup_global_symbol_from_objfile): Simplify return.
3793         (lookup_symbol_in_objfile_symtabs)
3794         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
3795         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
3796         (lookup_static_symbol, lookup_global_symbol): Simplify return.
3797         * cp-namespace.c (cp_lookup_bare_symbol)
3798         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
3799         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
3800         (cp_lookup_nested_symbol): Don't use null_block_symbol.
3801         (cp_lookup_symbol_via_imports): Simplify initialization.
3802         (find_symbol_in_baseclass): Likewise.
3803         * symtab.h (null_block_symbol): Remove.
3804         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
3805         (d_lookup_nested_symbol, d_lookup_symbol_imports)
3806         (d_lookup_symbol_module): Likewise.
3807         (find_symbol_in_baseclass): Simplify initialization.
3808
3809 2019-03-24  Tom Tromey  <tom@tromey.com>
3810
3811         * expression.h: Don't include symtab.h.
3812         (struct block): Forward declare.
3813
3814 2019-03-24  Tom Tromey  <tom@tromey.com>
3815
3816         * c-exp.y (typebase): Remove casts.
3817         * gdbtypes.c (lookup_unsigned_typename, )
3818         (lookup_signed_typename): Remove cast.
3819         * eval.c (parse_to_comma_and_eval): Remove cast.
3820         * parse.c (write_dollar_variable): Remove cast.
3821         * block.h (struct block) <superblock>: Now const.
3822         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
3823         * psymtab.c (psym_map_matching_symbols): Make "block" const.
3824         (map_block): Make "block" const.
3825         * symfile.h (struct quick_symbol_functions)
3826         <map_matching_symbols>: Constify block argument to "callback".
3827         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
3828         const.
3829         (find_pc_sect_compunit_symtab): Make "b" const.
3830         (find_symbol_at_address): Likewise.
3831         (search_symbols): Likewise.
3832         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
3833         (dw2_debug_names_lookup_symbol): Likewise.
3834         (dw2_map_matching_symbols): Update.
3835         * p-valprint.c (pascal_val_print): Remove "block".
3836         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
3837         (aux_add_nonlocal_symbols): Make "block" const.
3838         (resolve_subexp): Remove cast.
3839         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
3840         const.
3841         (iterate_over_file_blocks): Likewise.
3842         * f-exp.y (%union) <bval>: Remove.
3843         * coffread.c (patch_opaque_types): Make "b" const.
3844         * spu-tdep.c (spu_catch_start): Make "block" const.
3845         * c-valprint.c (print_unpacked_pointer): Remove "block".
3846         * symmisc.c (dump_symtab_1): Make "b" const.
3847         (block_depth): Make "block" const.
3848         * d-exp.y (%union) <bval>: Remove.
3849         * cp-support.h (cp_lookup_rtti_type): Update.
3850         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
3851         * psymtab.c (psym_lookup_symbol): Make "block" const.
3852         (maintenance_check_psymtabs): Make "b" const.
3853         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
3854         (enumerate_locals, enumerate_args): Update.
3855         * python/py-symtab.c (stpy_global_block): Make "block" const.
3856         (stpy_static_block): Likewise.
3857         * inline-frame.c (block_starting_point_at): Make "new_block"
3858         const.
3859         * block.c (find_block_in_blockvector): Make return type const.
3860         (blockvector_for_pc_sect): Make "b" const.
3861         (find_block_in_blockvector): Make "b" const.
3862
3863 2019-03-23  Tom Tromey  <tom@tromey.com>
3864
3865         * varobj.c (varobj_create): Update.
3866         * symfile.c (clear_symtab_users): Don't reset innermost_block.
3867         * printcmd.c (display_command, do_one_display): Don't reset
3868         innermost_block.
3869         * parser-defs.h (enum innermost_block_tracker_type): Move to
3870         expression.h.
3871         (innermost_block): Update comment.
3872         * parse.c (parse_exp_1): Add tracker_types parameter.
3873         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
3874         tracker_types parameter.  Reset innermost_block.
3875         (parse_exp_in_context): Remove.
3876         (parse_expression_for_completion): Update.
3877         * objfiles.c (~objfile): Don't reset expression_context_block or
3878         innermost_block.
3879         * expression.h (enum innermost_block_tracker_type): Move from
3880         parser-defs.h.
3881         (parse_exp_1): Add tracker_types parameter.
3882         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
3883         reset innermost_block.
3884
3885 2019-03-23  Tom Tromey  <tom@tromey.com>
3886
3887         * objfiles.h: Include bcache.h.
3888
3889 2019-03-23  Tom Tromey  <tom@tromey.com>
3890
3891         * linespec.c (get_current_search_block): Use
3892         scoped_restore_current_language.
3893         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
3894
3895 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3896             Jiong Wang  <jiong.wang@arm.com>
3897
3898         * aarch64-linux-tdep.c
3899         (aarch64_linux_iterate_over_regset_sections): Check for pauth
3900         section.
3901         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
3902
3903 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3904             Jiong Wang  <jiong.wang@arm.com>
3905
3906         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
3907         instructions.
3908         (aarch64_analyze_prologue_test): Add PACIASP test.
3909         (aarch64_prologue_prev_register): Unmask PC value.
3910
3911 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3912             Jiong Wang  <jiong.wang@arm.com>
3913
3914         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
3915         (aarch64_dwarf2_prev_register): Unmask PC value.
3916         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
3917         (aarch64_execute_dwarf_cfa_vendor_op): Check for
3918         DW_CFA_AARCH64_negate_ra_state.
3919         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
3920
3921 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3922             Jiong Wang  <jiong.wang@arm.com>
3923
3924         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
3925         registers.
3926         (aarch64_pseudo_register_name): Likewise.
3927         (aarch64_pseudo_register_type): Likewise.
3928         (aarch64_pseudo_register_reggroup_p): Likewise.
3929         (aarch64_gdbarch_init): Add pauth registers.
3930         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
3931         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
3932         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
3933         (struct gdbarch_tdep): Add regnum for ra_state.
3934
3935 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3936             Jiong Wang  <jiong.wang@arm.com>
3937
3938         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
3939
3940 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3941             Jiong Wang  <jiong.wang@arm.com>
3942
3943         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
3944         function.
3945         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
3946         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
3947         (aarch64_gdbarch_init): Add puth registers.
3948         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
3949         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
3950         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
3951
3952 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3953             Jiong Wang  <jiong.wang@arm.com>
3954
3955         * aarch64-linux-nat.c
3956         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
3957         * aarch64-linux-tdep.c
3958         (aarch64_linux_core_read_description): Likewise.
3959         (aarch64_linux_get_hwcap): New function.
3960         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
3961         (aarch64_linux_get_hwcap): New declaration.
3962
3963 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3964             Jiong Wang  <jiong.wang@arm.com>
3965
3966         * aarch64-linux-nat.c
3967         (aarch64_linux_nat_target::read_description): Add pauth param.
3968         * aarch64-linux-tdep.c
3969         (aarch64_linux_core_read_description): Likewise.
3970         * aarch64-tdep.c (struct target_desc): Add in pauth.
3971         (aarch64_read_description): Add pauth param.
3972         (aarch64_gdbarch_init): Likewise.
3973         * aarch64-tdep.h (aarch64_read_description): Likewise.
3974         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3975         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3976         * features/Makefile: Add new files.
3977         * features/aarch64-pauth.c: New file.
3978         * features/aarch64-pauth.xml: New file.
3979
3980 2019-03-20  Tom Tromey  <tromey@adacore.com>
3981
3982         * infrun.c (handle_inferior_event): Rename from
3983         handle_inferior_event_1.  Create a scoped_value_mark.
3984         (handle_inferior_event): Remove.
3985
3986 2019-03-19  Tom Tromey  <tromey@adacore.com>
3987
3988         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3989         * infrun.h (print_stop_event): Add "displays" parameter.
3990         * infrun.c (print_stop_event): Add "displays" parameter.
3991
3992 2019-03-19  Pedro Alves  <palves@redhat.com>
3993
3994         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3995         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3996         to -1.  Fix TABs vs spaces.
3997         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3998         * tui/tui-out.h (tui_ui_out) Add intro comments.
3999         <m_line, m_start_of_line>: In-class initialize, and add describing
4000         comment.
4001
4002 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
4003
4004         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
4005         variable names.
4006         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
4007
4008 2019-03-18  Pedro Alves  <palves@redhat.com>
4009             Eli Zaretskii <eliz@gnu.org>
4010
4011         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
4012         m_line and m_start_of_line.
4013
4014 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
4015
4016         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
4017         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
4018         it returns a newline.  This fixes a regression in TU mode, whereby
4019         the next line is output on the same screen line as the user input.
4020
4021 2019-03-18  Tom Tromey  <tromey@adacore.com>
4022
4023         * minsyms.c (minimal_symbol_reader::install): Remove call to
4024         obstack_blank.
4025
4026 2019-03-18  Pedro Alves  <palves@redhat.com>
4027
4028         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
4029         New globals.
4030         (apply_style): New, factored out from ...
4031         (apply_ansi_escape): ... this.  Handle reverse video mode.
4032         (tui_set_reverse_mode): New function.
4033         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
4034         * tui/tui-winsource.c (tui_show_source_line): Use
4035         tui_set_reverse_mode instead of setting A_STANDOUT.
4036         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
4037         New setter methods.
4038
4039 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
4040
4041         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4042         Handle tabs.
4043
4044 2019-03-18  Tom Tromey  <tromey@adacore.com>
4045
4046         * ada-lang.c (empty_array): Add "high" parameter.
4047         (ada_evaluate_subexp): Update.
4048
4049 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4050
4051         * unittests/string_view-selftests.c: Define
4052         _initialize_string_view_selftests unconditionally.
4053
4054 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4055
4056         PR gdb/24350
4057         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
4058
4059 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4060
4061         PR gdb/24351
4062         * windows-nat.c (display_selector): Fix format specifiers.
4063
4064 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
4065
4066         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
4067         tui_refill_source_window instead of tui_refresh_win, to update the
4068         current execution line.  This fixes redisplay of the current line
4069         when stepping through the code with "next" or "step".
4070
4071 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4072
4073         * source-cache.c (source_cache::get_source_lines): Call
4074         find_source_lines to initialize s->nlines.  This fixes vertical
4075         scrolling of TUI source window when the DOWN arrow is pressed.
4076
4077 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4078
4079         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
4080         linux-thread-db.c (_initialize_thread_db): Likewise.
4081
4082 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4083
4084         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4085         wclrtoeol in tui_show_source_line".  This reverts changes made in
4086         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4087
4088 2019-03-15  Tom Tromey  <tom@tromey.com>
4089
4090         * symtab.h (struct minimal_symbol): Derive from
4091         general_symbol_info.
4092         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4093         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4094         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4095         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4096         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4097         (MSYMBOL_SEARCH_NAME): Update.
4098         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4099         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4100         * minsyms.c (minimal_symbol_reader::record_full): Update.
4101
4102 2019-03-15  Tom Tromey  <tom@tromey.com>
4103
4104         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4105
4106 2019-03-15  Tom Tromey  <tom@tromey.com>
4107
4108         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4109         unique_xmalloc_ptr.
4110         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4111         Update.
4112         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4113         (build_minimal_symbol_hash_tables)
4114         (minimal_symbol_reader::install): Update.
4115
4116 2019-03-15  Tom Tromey  <tom@tromey.com>
4117
4118         * symtab.c (create_demangled_names_hash): Update.
4119         (symbol_set_names): Update.
4120         * objfiles.h (struct objfile_per_bfd_storage)
4121         <demangled_names_hash>: Now an htab_up.
4122         * objfiles.c (objfile_per_bfd_storage): Simplify.
4123
4124 2019-03-15  Tom Tromey  <tom@tromey.com>
4125
4126         * objfiles.h (struct objfile_per_bfd_storage): Declare
4127         destructor.
4128         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4129         New.
4130         (get_objfile_bfd_data): Use new.  Don't initialize
4131         language_of_main.
4132         (free_objfile_per_bfd_storage): Remove.
4133         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4134
4135 2019-03-15  Tom Tromey  <tom@tromey.com>
4136
4137         * symfile.c (reread_symbols): Update.
4138         * objfiles.c (objfile::objfile): Update.
4139         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4140         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4141         comment.
4142         (minimal_symbol_reader::install): Update.
4143         (terminate_minimal_symbol_table): Remove.
4144         * jit.c (jit_object_close_impl): Update.
4145
4146 2019-03-15  Tom Tromey  <tom@tromey.com>
4147
4148         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4149         initializations.
4150
4151 2019-03-15  Tom Tromey  <tom@tromey.com>
4152
4153         * objfiles.h (struct objfile_per_bfd_storage)
4154         <demangled_hash_languages>: Now a bitset.
4155         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4156         (lookup_minimal_symbol): Update.
4157
4158 2019-03-15  Tom Tromey  <tom@tromey.com>
4159
4160         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4161         Don't return the symbol.
4162         * coffread.c (record_minimal_symbol): Use record_full.
4163
4164 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4165
4166         The MS-Windows port of ncurses fails to switch to a color pair if
4167         one or both of the colors are the implicit default colors.  This
4168         change records the default colors when TUI is initialized, and
4169         then specifies them explicitly when a color pair uses the default
4170         colors.  This allows color styling in TUI mode on MS-Windows.
4171
4172         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4173         ncurses_norm_attr.
4174         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4175         colors in ncurses_norm_attr.
4176         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4177         "none", replace it with the default color recorded in
4178         ncurses_norm_attr.
4179
4180 2019-03-14  Tom Tromey  <tromey@adacore.com>
4181
4182         * source-cache.h (class source_cache) <get_source_lines>: Return
4183         std::string.
4184         * source-cache.c (source_cache::extract_lines): Handle case where
4185         first_pos==npos.  Return std::string.
4186         (source_cache::get_source_lines): Update.
4187
4188 2019-03-14  Tom Tromey  <tromey@adacore.com>
4189
4190         * NEWS: Add item for "style sources" commands.
4191         * source-cache.c (source_cache::get_source_lines): Check
4192         source_styling.
4193         * cli/cli-style.c (source_styling): New global.
4194         (_initialize_cli_style): Add "style sources" commands.
4195         (show_style_sources): New function.
4196         * cli/cli-style.h (source_styling): Declare.
4197
4198 2019-03-14  Pedro Alves  <palves@redhat.com>
4199             Tom Tromey  <tromey@adacore.com>
4200
4201         * tui/tui-winsource.h (tui_refill_source_window): Declare.
4202         * tui/tui-winsource.c (tui_refill_source_window): New function,
4203         from...
4204         (tui_horizontal_source_scroll): ... here.  Move some logic.
4205         * cli/cli-style.c (set_style_enabled): Notify new observable.
4206         * tui/tui-hooks.c (tui_redisplay_source): New function.
4207         (tui_attach_detach_observers): Attach or detach
4208         tui_redisplay_source.
4209         * observable.h (source_styling_changed): New observable.
4210         * observable.c: Define source_styling_changed observable.
4211
4212 2019-03-13  Tom Tromey  <tromey@adacore.com>
4213
4214         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4215         (i386_gnu_nat_target::store_registers): Update.
4216         * target-debug.h (target_debug_print_std_string): New macro.
4217         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4218         * windows-tdep.c (display_one_tib): Update.
4219         * tui/tui-stack.c (tui_make_status_line): Update.
4220         * top.c (print_inferior_quit_action): Update.
4221         * thread.c (thr_try_catch_cmd): Update.
4222         (add_thread_with_info): Update.
4223         (thread_target_id_str): Update.
4224         (thr_try_catch_cmd): Update.
4225         (thread_command): Update.
4226         (thread_find_command): Update.
4227         * record-btrace.c (record_btrace_target::info_record)
4228         (record_btrace_resume_thread, record_btrace_target::resume)
4229         (record_btrace_cancel_resume, record_btrace_step_thread)
4230         (record_btrace_target::wait, record_btrace_target::wait)
4231         (record_btrace_target::wait, record_btrace_target::stop): Update.
4232         * progspace.c (print_program_space): Update.
4233         * process-stratum-target.c
4234         (process_stratum_target::thread_address_space): Update.
4235         * linux-fork.c (linux_fork_mourn_inferior)
4236         (detach_checkpoint_command, info_checkpoints_command)
4237         (linux_fork_context): Update.
4238         (linux_fork_detach): Update.
4239         (class scoped_switch_fork_info): Update.
4240         (delete_checkpoint_command): Update.
4241         * infrun.c (follow_fork_inferior): Update.
4242         (follow_fork_inferior): Update.
4243         (proceed_after_vfork_done): Update.
4244         (handle_vfork_child_exec_or_exit): Update.
4245         (follow_exec): Update.
4246         (displaced_step_prepare_throw): Update.
4247         (displaced_step_restore): Update.
4248         (start_step_over): Update.
4249         (resume_1): Update.
4250         (clear_proceed_status_thread): Update.
4251         (proceed): Update.
4252         (print_target_wait_results): Update.
4253         (do_target_wait): Update.
4254         (context_switch): Update.
4255         (stop_all_threads): Update.
4256         (restart_threads): Update.
4257         (finish_step_over): Update.
4258         (handle_signal_stop): Update.
4259         (switch_back_to_stepped_thread): Update.
4260         (keep_going_pass_signal): Update.
4261         (print_exited_reason): Update.
4262         (normal_stop): Update.
4263         * inferior.c (inferior_pid_to_str): Change return type.
4264         (print_selected_inferior): Update.
4265         (add_inferior): Update.
4266         (detach_inferior): Update.
4267         * dummy-frame.c (fprint_dummy_frames): Update.
4268         * dcache.c (dcache_info_1): Update.
4269         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
4270         (btrace_fetch, btrace_clear): Update.
4271         * linux-tdep.c (linux_core_pid_to_str): Change return type.
4272         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
4273         type.
4274         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
4275         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
4276         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
4277         * gdbarch.c, gdbarch.h: Rebuild.
4278         * gdbarch.sh (core_pid_to_str): Change return type.
4279         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
4280         return type.
4281         (windows_nat_target::pid_to_str): Change return type.
4282         (windows_delete_thread): Update.
4283         (windows_nat_target::attach): Update.
4284         (windows_nat_target::files_info): Update.
4285         * target-delegates.c: Rebuild.
4286         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4287         return type.
4288         (sol_thread_target::pid_to_str): Change return type.
4289         * remote.c (class remote_target) <pid_to_str>: Change return
4290         type.
4291         (remote_target::pid_to_str): Change return type.
4292         (extended_remote_target::attach, remote_target::remote_stop_ns)
4293         (remote_target::remote_notif_remove_queued_reply)
4294         (remote_target::push_stop_reply, remote_target::disable_btrace):
4295         Update.
4296         (extended_remote_target::attach): Update.
4297         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4298         type.
4299         (gdbsim_target::pid_to_str): Change return type.
4300         * ravenscar-thread.c (struct ravenscar_thread_target)
4301         <pid_to_str>: Change return type.
4302         (ravenscar_thread_target::pid_to_str): Change return type.
4303         * procfs.c (class procfs_target) <pid_to_str>: Change return
4304         type.
4305         (procfs_target::pid_to_str): Change return type.
4306         (procfs_target::attach): Update.
4307         (procfs_target::detach): Update.
4308         (procfs_target::fetch_registers): Update.
4309         (procfs_target::store_registers): Update.
4310         (procfs_target::wait): Update.
4311         (procfs_target::files_info): Update.
4312         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4313         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4314         return type.
4315         (nto_procfs_target::pid_to_str): Change return type.
4316         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4317         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4318         return type.
4319         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4320         (exit_lwp): Update.
4321         (attach_proc_task_lwp_callback, get_detach_signal)
4322         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4323         (linux_nat_target::resume, wait_lwp, stop_callback)
4324         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4325         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4326         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4327         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4328         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4329         type.
4330         (inf_ptrace_target::attach): Update.
4331         (inf_ptrace_target::files_info): Update.
4332         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4333         type.
4334         (go32_nat_target::pid_to_str): Change return type.
4335         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4336         (gnu_nat_target::wait): Update.
4337         (gnu_nat_target::wait): Update.
4338         (gnu_nat_target::resume): Update.
4339         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4340         (fbsd_nat_target::wait): Update.
4341         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4342         type.
4343         (darwin_nat_target::attach): Update.
4344         * corelow.c (class core_target) <pid_to_str>: Change return type.
4345         (core_target::pid_to_str): Change return type.
4346         * target.c (normal_pid_to_str): Change return type.
4347         (default_pid_to_str): Likewise.
4348         (target_pid_to_str): Change return type.
4349         (target_translate_tls_address): Update.
4350         (target_announce_detach): Update.
4351         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4352         return type.
4353         (bsd_uthread_target::pid_to_str): Change return type.
4354         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4355         type.
4356         (bsd_kvm_target::pid_to_str): Change return type.
4357         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4358         return type.
4359         (aix_thread_target::pid_to_str): Change return type.
4360         * target.h (struct target_ops) <pid_to_str>: Change return type.
4361         (target_pid_to_str, normal_pid_to_str): Likewise.
4362         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4363         type.
4364         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4365         type.
4366         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4367         return type.
4368         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4369         type.
4370         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4371         type.
4372         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
4373         return type.
4374
4375 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
4376
4377         * NEWS: Mention that the new default MI version is 3.  Mention
4378         changes to the output of commands and events that deal with
4379         multi-location breakpoints.
4380         * breakpoint.c: Include "mi/mi-out.h".
4381         (print_one_breakpoint): Change output syntax if using MI version
4382         >= 3.
4383         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4384         New.
4385         (mi_multi_location_breakpoint_output_fixed): New.
4386         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
4387         (mi_cmd_fix_multi_location_breakpoint_output): New.
4388         (mi_multi_location_breakpoint_output_fixed): New.
4389         * mi/mi-cmds.c (mi_cmds): Register command
4390         -fix-multi-location-breakpoint-output.
4391         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
4392         interpreter "mi".
4393
4394 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
4395
4396         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
4397         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
4398         instantiate mi_ui_out based on interpreter name.
4399         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
4400         * mi/mi-main.c (mi_load_progress): Likewise.
4401
4402 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4403
4404         * NEWS: Combine separate "New targets" sections for 8.3.
4405
4406 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4407
4408         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
4409         (ppcfbsd_init_abi): Install gdbarch
4410         "fetch_tls_load_module_address" and "get_thread_local_address"
4411         methods.
4412
4413 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4414
4415         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
4416         (riscv_fbsd_init_abi): Install gdbarch
4417         "fetch_tls_load_module_address" and "get_thread_local_address"
4418         methods.
4419
4420 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4421
4422         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
4423         (i386fbsd_init_abi): Install gdbarch
4424         "fetch_tls_load_module_address" and "get_thread_local_address"
4425         methods.
4426
4427 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4428
4429         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
4430         (amd64fbsd_init_abi): Install gdbarch
4431         "fetch_tls_load_module_address" and "get_thread_local_address"
4432         methods.
4433
4434 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4435
4436         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
4437         (struct fbsd_pspace_data): New type.
4438         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4439         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4440         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4441         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4442         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4443
4444 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4445
4446         * gdbtypes.c (lookup_struct_elt): New function.
4447         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
4448         * gdbtypes.h (struct struct_elt): New type.
4449         (lookup_struct_elt): New prototype.
4450
4451 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4452
4453         * gdbtypes.c (lookup_struct_elt_type): Update comment and
4454         remove disabled code block.
4455
4456 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4457
4458         * gdbarch.sh (get_thread_local_address): New method.
4459         * gdbarch.h, gdbarch.c: Regenerate.
4460         * target.c (target_translate_tls_address): Use
4461         gdbarch_get_thread_local_address if present instead of
4462         target::get_thread_local_address.
4463
4464 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4465
4466         * target.h (target::get_thread_local_address): Update comment.
4467
4468 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4469
4470         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
4471         objfile->separate_debug_objfile_backlink if not NULL.
4472
4473 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4474
4475         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
4476         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
4477         (amd64bsd_store_inferior_registers): Likewise.
4478         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4479         Enable segment base registers.
4480         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
4481         PT_GETFSBASE and PT_GETGSBASE.
4482         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
4483         PT_SETGSBASE.
4484         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
4485         segment base registers.
4486         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4487
4488 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4489
4490         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4491         Update calls to i386_target_description to add 'segments'
4492         parameter.
4493         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
4494         add segment base registers.
4495         * arch/i386.c (i386_create_target_description): Add 'segments'
4496         parameter to enable segment base registers.
4497         * arch/i386.h (i386_create_target_description): Likewise.
4498         * features/i386/32bit-segments.xml: New file.
4499         * features/i386/32bit-segments.c: Generate.
4500         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
4501         call to i386_target_description to add 'segments' parameter.
4502         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4503         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
4504         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
4505         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
4506         if feature is present.
4507         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
4508         Add 'segments' parameter to call to i386_target_description.
4509         (i386_target_description): Add 'segments' parameter to enable
4510         segment base registers.
4511         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
4512         to call to i386_target_description.
4513         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
4514         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
4515         Define I386_NUM_REGS.
4516         (i386_target_description): Add 'segments' parameter to enable
4517         segment base registers.
4518
4519 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
4520
4521         PR/24325
4522         * source-cache.c: #undef open and close, to avoid unresolved
4523         externals during linking.
4524
4525 2019-03-12  Tom Tromey  <tromey@adacore.com>
4526
4527         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
4528         const.  Add initializers.
4529         (_initialize_remote): Don't initialize ptid globals.
4530
4531 2019-03-12  Pedro Alves  <palves@redhat.com>
4532
4533         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
4534
4535 2019-03-12  Pedro Alves  <palves@redhat.com>
4536
4537         * cp-name-parser.y (main): Remove unused 'len' variable.
4538
4539 2019-03-12  Tom Tromey  <tromey@adacore.com>
4540
4541         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
4542         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
4543
4544 2019-03-12  Tom Tromey  <tromey@adacore.com>
4545
4546         * linux-nat.c (iterate_over_lwps): Update.
4547         (stop_callback): Remove parameter.
4548         (stop_wait_callback, detach_callback, resume_set_callback)
4549         (select_singlestep_lwp_callback, set_ignore_sigint)
4550         (status_callback, resumed_callback, resume_clear_callback)
4551         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
4552         data parameter.
4553         (linux_nat_target::detach, linux_nat_target::resume)
4554         (linux_stop_and_wait_all_lwps, select_event_lwp)
4555         (linux_nat_filter_event, linux_nat_wait_1)
4556         (linux_nat_target::kill, linux_nat_target::stop)
4557         (linux_nat_target::stop): Update.
4558         (linux_nat_resume_callback): Change type.
4559         (resume_stopped_resumed_lwps, count_events_callback)
4560         (select_event_lwp_callback): Likewise.
4561         (linux_stop_lwp, linux_nat_stop_lwp): Update.
4562         * arm-linux-nat.c (struct update_registers_data): Remove.
4563         (update_registers_callback): Change type.
4564         (arm_linux_insert_hw_breakpoint1): Update.
4565         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
4566         parameter.
4567         (x86_linux_dr_set_addr): Update.
4568         (x86_linux_dr_set_control): Update.
4569         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
4570         (iterate_over_lwps): Use gdb::function_view.
4571         * nat/aarch64-linux-hw-point.c (struct
4572         aarch64_dr_update_callback_param): Remove.
4573         (debug_reg_change_callback): Change type.
4574         (aarch64_notify_debug_reg_change): Update.
4575         * s390-linux-nat.c (s390_refresh_per_info): Update.
4576
4577 2019-03-11  Tom Tromey  <tromey@adacore.com>
4578
4579         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
4580         redundant assignment to "this_cu".
4581
4582 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4583
4584         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
4585
4586 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4587
4588         * gdbtypes.c (rank_one_type_parm_set): New function extracted
4589         from...
4590         (rank_one_type): ... this.
4591
4592 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4593
4594         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
4595         from...
4596         (rank_one_type): ... this.
4597
4598 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4599
4600         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
4601         from...
4602         (rank_one_type): ... this.
4603
4604 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4605
4606         * gdbtypes.c (rank_one_type_parm_float): New function extracted
4607         from...
4608         (rank_one_type): ... this.
4609
4610 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4611
4612         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
4613         from...
4614         (rank_one_type): ... this.
4615
4616 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4617
4618         * gdbtypes.c (rank_one_type_parm_range): New function extracted
4619         from...
4620         (rank_one_type): ... this.
4621
4622 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4623
4624         * gdbtypes.c (rank_one_type_parm_char): New function extracted
4625         from...
4626         (rank_one_type): ... this.
4627
4628 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4629
4630         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
4631         from...
4632         (rank_one_type): ... this.
4633
4634 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4635
4636         * gdbtypes.c (rank_one_type_parm_int): New function extracted
4637         from...
4638         (rank_one_type): ... this.
4639
4640 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4641
4642         * gdbtypes.c (rank_one_type_parm_func): New function extracted
4643         from...
4644         (rank_one_type): ... this.
4645
4646 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4647
4648         * gdbtypes.c (rank_one_type_parm_array): New function extracted
4649         from...
4650         (rank_one_type): ... this.
4651
4652 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4653
4654         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
4655         from...
4656         (rank_one_type): ... this.
4657
4658 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4659
4660         * inferior.c (initialize_inferiors): Ensure 'help set/show print
4661         inferior-events' shows the example events.
4662
4663 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
4664
4665         Support styling on native MS-Windows console
4666
4667         PR/24315
4668         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
4669         on MS-Windows if $TERM is not defined.
4670
4671         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
4672
4673         * posix-hdep.c (gdb_console_fputs):
4674         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
4675         functions.
4676         * ui-file.h (gdb_console_fputs): Add prototype.
4677
4678         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
4679         back to fputs only if the former returns zero.
4680
4681 2019-03-07  Tom Tromey  <tom@tromey.com>
4682
4683         * symmisc.c (print_symbol_bcache_statistics): Update.
4684         (print_objfile_statistics): Update.
4685         * symfile.c (allocate_symtab): Update.
4686         * stabsread.c: Don't include bcache.h.
4687         * psymtab.h (struct psymbol_bcache): Don't declare.
4688         (class psymtab_storage) <psymbol_cache>: Now a bcache.
4689         (psymbol_bcache_init, psymbol_bcache_free)
4690         (psymbol_bcache_get_bcache): Don't declare.
4691         * psymtab.c (struct psymbol_bcache): Remove.
4692         (psymtab_storage::psymtab_storage): Update.
4693         (psymtab_storage::~psymtab_storage): Update.
4694         (psymbol_bcache_init, psymbol_bcache_free)
4695         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
4696         (add_psymbol_to_bcache): Update.
4697         (allocate_psymtab): Update.
4698         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
4699         macro_cache>: No longer pointers.
4700         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
4701         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
4702         * macrotab.c (macro_bcache): Update.
4703         * macroexp.c: Don't include bcache.h.
4704         * gdbtypes.c (check_types_worklist): Update.
4705         (types_deeply_equal): Remove TRY/CATCH.  Update.
4706         * elfread.c (elf_symtab_read): Update.
4707         * dwarf2read.c: Don't include bcache.h.
4708         * buildsym.c (buildsym_compunit::get_macro_table): Update.
4709         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
4710         (print_bcache_statistics, bcache_memory_used): Don't declare.
4711         (struct bcache): Move from bcache.c.  Add constructor, destructor,
4712         methods.  Rename all data members.
4713         * bcache.c (struct bcache): Move to bcache.h.
4714         (bcache::expand_hash_table): Rename from expand_hash_table.
4715         (bcache): Remove.
4716         (bcache::insert): Rename from bcache_full.
4717         (bcache::compare): Rename from bcache_compare.
4718         (bcache_xmalloc): Remove.
4719         (bcache::~bcache): Rename from bcache_xfree.
4720         (bcache::print_statistics): Rename from print_bcache_statistics.
4721         (bcache::memory_used): Rename from bcache_memory_used.
4722
4723 2019-03-07  Pedro Alves  <palves@redhat.com>
4724
4725         * infrun.c (normal_stop): Also check for
4726         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
4727
4728 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4729
4730         * f-lang.c (value_from_host_double): Moved to...
4731         * value.c (value_from_host_double): ...here.
4732         * value.h (value_from_host_double): Declare.
4733         * guile/scm-math.c (vlscm_convert_typed_number): Use
4734         value_from_host_double.
4735         (vlscm_convert_number): Likewise.
4736         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
4737         * python/py-value.c (convert_value_from_python): Likewise.
4738
4739 2019-03-06  Tom Tromey  <tom@tromey.com>
4740
4741         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
4742
4743 2019-03-06  Tom Tromey  <tom@tromey.com>
4744
4745         * utils.h (free_current_contents): Don't declare.
4746         * utils.c (free_current_contents): Remove.
4747
4748 2019-03-06  Tom Tromey  <tom@tromey.com>
4749
4750         * top.c (quit_force): Update.
4751         * main.c (captured_command_loop): Update.
4752         * common/new-op.c (operator new): Update.
4753         * common/common-exceptions.c (struct catcher)
4754         <save_cleanup_chain>: Remove member.
4755         (exceptions_state_mc_init): Update.
4756         (exception_try_scope_entry): Return nullptr.
4757         (exception_try_scope_exit, exception_rethrow)
4758         (throw_exception_sjlj, throw_exception_cxx): Update.
4759         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
4760         (all_cleanups, do_cleanups, discard_cleanups)
4761         (discard_final_cleanups, save_cleanups, save_final_cleanups)
4762         (restore_cleanups, restore_final_cleanups): Don't declare.
4763         (do_final_cleanups): Remove parameter.
4764         * common/cleanups.c (cleanup_chain, make_cleanup)
4765         (make_cleanup_dtor, all_cleanups, do_cleanups)
4766         (discard_my_cleanups, discard_cleanups)
4767         (discard_final_cleanups, save_my_cleanups, save_cleanups)
4768         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
4769         (null_cleanup): Remove.
4770         (do_final_cleanups): Remove parameter.
4771
4772 2019-03-06  Tom Tromey  <tom@tromey.com>
4773
4774         * remote.c (remote_target::remote_parse_stop_reply): Use
4775         unique_xmalloc_ptr.
4776
4777 2019-03-06  Tom Tromey  <tom@tromey.com>
4778
4779         * stabsread.c (struct stabs_field_info): Rename from field_info.
4780         <list, fnlist>: Add initializers.
4781         <obstack>: New member.
4782         (read_member_functions, read_struct_fields, read_baseclasses):
4783         Allocate on obstack.  Don't use cleanups.
4784         (read_one_struct_field, read_member_functions, read_struct_fields)
4785         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
4786         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
4787         (read_struct_type): Update.
4788
4789 2019-03-06  Tom Tromey  <tom@tromey.com>
4790
4791         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
4792         * common/filestuff.h (make_cleanup_close): Don't declare.
4793         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
4794         Remove.
4795
4796 2019-03-06  Tom Tromey  <tom@tromey.com>
4797
4798         * solib-aix.c: Use make_scope_exit.
4799
4800 2019-03-06  Tom Tromey  <tom@tromey.com>
4801
4802         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
4803         Use make_scope_exit.
4804
4805 2019-03-06  Tom Tromey  <tom@tromey.com>
4806
4807         * solib-svr4.c (disable_probes_interface): Remove parameter.
4808         (svr4_handle_solib_event): Use make_scope_exit.
4809
4810 2019-03-06  Tom Tromey  <tom@tromey.com>
4811
4812         * remote.c (struct stop_reply_deleter): Remove.
4813         (stop_reply_up): Update.
4814         (struct stop_reply): Derive from notif_event.  Don't typedef.
4815         <regcache>: Now a std::vector.
4816         (stop_reply_xfree): Remove.
4817         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
4818         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
4819         (remote_target::discard_pending_stop_replies): Use delete.
4820         (remote_target::remote_parse_stop_reply): Update.
4821         (remote_target::process_stop_reply): Update.
4822         * remote-notif.h (struct notif_event): Add virtual destructor.
4823         Remove "dtr" member.
4824         (struct notif_client) <alloc_event>: Return a unique_ptr.
4825         (notif_event_xfree): Don't declare.
4826         (notif_event_up): New typedef.
4827         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
4828         (notif_event_xfree, do_notif_event_xfree): Remove.
4829         (remote_notif_state_xfree): Update.
4830
4831 2019-03-06  Tom Tromey  <tom@tromey.com>
4832
4833         * infrun.c (displaced_step_clear_cleanup): Now a
4834         forward_scope_exit type.
4835         (displaced_step_prepare_throw): Update.
4836         (displaced_step_fixup): Update.
4837
4838 2019-03-06  Tom Tromey  <tom@tromey.com>
4839
4840         * inferior.h (class inferior): Update comment.
4841         * gdbthread.h (class thread_info): Update comment.
4842
4843 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
4844             Tom Tromey  <tom@tromey.com>
4845
4846         * stabsread.h (struct stab_section_list): Remove.
4847         (coffstab_build_psymtabs): Update.
4848         * dbxread.c (symbuf_sections): Now a std::vector.
4849         (sect_idx): New global.
4850         (fill_symbuf): Update.
4851         (coffstab_build_psymtabs): Change type of stabsects parameter.
4852         Update.
4853         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
4854         std::vector.
4855         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
4856         (coff_locate_sections): Update.
4857         (coff_symfile_read): Remove cleanups.  Update.
4858         (init_stringtab): Add storage parameter.
4859         (free_stringtab, free_stringtab_cleanup): Remove.
4860         (init_lineno): Add storage parameter.
4861         (free_linetab, free_linetab_cleanup): Remove.
4862
4863 2019-03-06  Pedro Alves  <palves@redhat.com>
4864
4865         * linux-fork.c (fork_info::clobber_regs): Delete.
4866         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
4867         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
4868         comment.  Adjust.
4869         (scoped_switch_fork_info::scoped_switch_fork_info)
4870         (checkpoint_command, linux_fork_context): Adjust
4871         fork_save_infrun_state calls.
4872
4873 2019-03-06  Pedro Alves  <palves@redhat.com>
4874
4875         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
4876         (inf_has_multiple_threads): Return 'bool' and rewrite using
4877         inferior_info::threads().
4878
4879 2019-03-06  Pedro Alves  <palves@redhat.com>
4880
4881         * linux-fork.c: Include <list>.
4882         (fork_list): Now a std::list instance.
4883         (fork_info): Add ctor, dtor, and in-class initialize all fields.
4884         (forks_exist_p, find_last_fork): Adjust.
4885         (new_fork): Delete.
4886         (one_fork_p): New.
4887         (add_fork): Adjust.
4888         (free_fork): Delete, folded into fork_info::~fork_info().
4889         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
4890         Adjust.
4891         (init_fork_list): Delete.
4892         (linux_fork_killall, linux_fork_mourn_inferior)
4893         (linux_fork_detach, info_checkpoints_command): Adjust.
4894         (_initialize_linux_fork): No longer call init_fork_list.
4895
4896 2019-03-06  Pedro Alves  <palves@redhat.com>
4897
4898         * linux-fork.c (new_fork): New, split out of ...
4899         (add_fork): ... this.  Return void.  Move "first fork" special
4900         case from here, to ...
4901         (checkpoint_command): ... here.
4902         * linux-linux.h (add_fork): Return void.
4903
4904 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4905
4906         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
4907
4908 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4909             Chris January  <chris.january@arm.com>
4910             David Lecomber  <david.lecomber@arm.com>
4911
4912         * f-exp.y: New token, UNOP_INTRINSIC.
4913         (exp): New pattern using UNOP_INTRINSIC token.
4914         (f77_keywords): Add 'abs' keyword.
4915         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
4916         (value_from_host_double): New function.
4917         (evaluate_subexp_f): Support UNOP_ABS.
4918
4919 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4920
4921         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
4922         types.
4923
4924 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4925
4926         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
4927         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
4928         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
4929
4930 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4931
4932         * f-exp.y (convert_to_kind_type): Handle more type kinds.
4933
4934 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4935             Chris January  <chris.january@arm.com>
4936
4937         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
4938         * f-exp.y: Define 'KIND' token.
4939         (exp): New pattern for KIND expressions.
4940         (ptype): Handle types with a kind extension.
4941         (direct_abs_decl): Extend to spot kind extensions.
4942         (f77_keywords): Add 'kind' to the list.
4943         (push_kind_type): New function.
4944         (convert_to_kind_type): New function.
4945         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
4946         * parse.c (operator_length_standard): Likewise.
4947         * parser-defs.h (enum type_pieces): Add tp_kind.
4948         * std-operator.def: Add UNOP_KIND.
4949
4950 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4951
4952         * f-exp.y (f_parse): Set yydebug.
4953
4954 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4955
4956         * f-lang.c (evaluate_subexp_f): New function.
4957         (exp_descriptor_f): New global.
4958         (f_language_defn): Use exp_descriptor_f instead of
4959         exp_descriptor_standard.
4960
4961 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4962
4963         * f-exp.y (struct token): Add comments.
4964         (dot_ops): Remove uppercase versions and the end marker.
4965         (f77_keywords): Likewise.
4966         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
4967         entries in the dot_ops array are case insensitive, and use
4968         strncasecmp to compare strings.  Also some whitespace cleanup in
4969         this area.  Similar for the f77_keywords array, except entries in
4970         this list might be case sensitive.
4971
4972 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4973
4974         * f-exp.y (struct f77_boolean_val): Add comments.
4975         (boolean_values): Remove uppercase versions, and end marker.
4976         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
4977         and use strncasecmp to achieve case insensitivity.  Additionally,
4978         perform whitespace cleanup around this code.
4979
4980 2019-03-06  Tom Tromey  <tromey@adacore.com>
4981
4982         * remote-sim.c (gdbsim_target_open): Use result of
4983         gdb_argv::release.
4984
4985 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4986         Dirk Schubert  <dirk.schubert@arm.com>
4987         Chris January  <chris.january@arm.com>
4988
4989         * eval.c (evaluate_subexp_standard): Call Fortran argument
4990         wrapping logic.
4991         * f-lang.c (struct value): A value which can be passed into a
4992         Fortran function call.
4993         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4994         where appropriate.
4995         (struct type): Value ready for a Fortran function call.
4996         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4997         is needed.
4998         * f-lang.h (fortran_argument_convert): Declaration.
4999         (fortran_preserve_arg_pointer): Declaration.
5000         * infcall.c (value_arg_coerce): Call Fortran argument logic.
5001
5002 2019-03-05  Tom Tromey  <tromey@adacore.com>
5003
5004         * python/py-prettyprint.c (print_string_repr): Remove #if.
5005         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
5006
5007 2019-03-05  Tom Tromey  <tromey@adacore.com>
5008
5009         * target.c (the_dummy_target): Move later.  Change type to
5010         "dummy_target".
5011         (initialize_targets): Don't initialize the_dummy_target.
5012
5013 2019-03-05  Tom Tromey  <tromey@adacore.com>
5014
5015         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
5016         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
5017
5018 2019-03-05  Tom Tromey  <tromey@adacore.com>
5019
5020         * windows-nat.c (windows_nat_target::attach)
5021         (windows_nat_target::detach): Don't call gdb_flush.
5022         * valprint.c (generic_val_print, val_print, val_print_string):
5023         Don't call gdb_flush.
5024         * utils.c (defaulted_query): Don't call gdb_flush.
5025         * typeprint.c (print_type_scalar): Don't call gdb_flush.
5026         * target.c (target_announce_detach): Don't call gdb_flush.
5027         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
5028         * remote.c (extended_remote_target::attach): Don't call
5029         gdb_flush.
5030         * procfs.c (procfs_target::detach): Don't call gdb_flush.
5031         * printcmd.c (do_examine): Don't call gdb_flush.
5032         (info_display_command): Don't call gdb_flush.
5033         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
5034         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
5035         * memattr.c (info_mem_command): Don't call gdb_flush.
5036         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
5037         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
5038         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
5039         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
5040         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5041         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5042         (gnu_nat_target::detach): Don't call gdb_flush.
5043         * f-valprint.c (f_val_print): Don't call gdb_flush.
5044         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5045         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5046         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5047         gdb_flush.
5048         * c-valprint.c (c_val_print): Don't call gdb_flush.
5049         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5050
5051 2019-03-05  Tom Tromey  <tromey@adacore.com>
5052
5053         * varobj.c (update_dynamic_varobj_children): Update.
5054         (install_default_visualizer): Use reset, not release.
5055         * value.c (set_internalvar): Update.
5056         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
5057         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
5058         ATTRIBUTE_UNUSED_RESULT.
5059
5060 2019-03-05  Tom Tromey  <tromey@adacore.com>
5061
5062         * remote.c (class scoped_remote_fd) <release>: Add
5063         ATTRIBUTE_UNUSED_RESULT.
5064
5065 2019-03-05  Tom Tromey  <tromey@adacore.com>
5066
5067         * macroexp.c (struct macro_buffer) <release>: Add
5068         ATTRIBUTE_UNUSED_RESULT.
5069
5070 2019-03-05  Tom Tromey  <tromey@adacore.com>
5071
5072         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
5073         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
5074         ATTRIBUTE_UNUSED_RESULT.
5075
5076 2019-03-05  Tom Tromey  <tromey@adacore.com>
5077
5078         * common/scoped_fd.h (class scoped_fd) <release>: Add
5079         ATTRIBUTE_UNUSED_RESULT.
5080
5081 2019-03-05  Tom Tromey  <tromey@adacore.com>
5082
5083         * parser-defs.h (struct parser_state) <release>: Add
5084         ATTRIBUTE_UNUSED_RESULT.
5085
5086 2019-03-05  Tom Tromey  <tromey@adacore.com>
5087
5088         * utils.h (class gdb_argv) <release>: Add
5089         ATTRIBUTE_UNUSED_RESULT.
5090         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5091
5092 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5093
5094         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5095         for-loop range, to avoid compiler warnings.
5096
5097         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5098         avoid compiler warnings about unused variables.
5099
5100         * NEWS: Mention end of support for native debugging on MS-Windows
5101         before XP.
5102
5103         PR gdb/24292
5104         * common/netstuff.c:
5105         * gdbserver/gdbreplay.c
5106         * gdbserver/remote-utils.c:
5107         * ser-tcp.c:
5108         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5109         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5110         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5111         'getaddrinfo' and 'freeaddrinfo' were not available before
5112         Windows XP, and mingw.org's MinGW headers by default define
5113         _WIN32_WINNT to 0x500.
5114
5115 2019-03-01  Gary Benson <gbenson@redhat.com>
5116
5117         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5118
5119 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5120             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5121
5122         PR gdb/8527
5123         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5124         set_sigint_trap, clear_sigint_trap.
5125
5126 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5127
5128         * target.c (target_detach): Clear the regcache and the
5129         frame cache.
5130
5131 2019-02-27  Pedro Alves  <palves@redhat.com>
5132
5133         * utils.c (set_screen_size): When we cap the height/width sizes,
5134         tweak the corresponding command variable to show "unlimited":
5135
5136 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5137             Pedro Alves  <palves@redhat.com>
5138
5139         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5140         before calling rl_set_screen_size.
5141
5142 2019-02-27  Tom Tromey  <tromey@adacore.com>
5143
5144         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5145         define.
5146         * python/py-value.c: Remove Python 2.4 workaround.
5147         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5148         workaround.
5149         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5150         Python 2.4 workaround.
5151         * python/python-internal.h: Remove Python 2.4 comment.
5152         (Py_ssize_t): Don't define.
5153         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5154         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5155         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5156         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5157         * python/python.c (do_start_initialization): Remove Python 2.4
5158         workaround.
5159         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5160         (print_children): Remove Python 2.4 workaround.
5161         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5162         workaround.
5163         (CHARBUFFERPROC_NAME): Remove.
5164         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5165         Python 2.4 workaround.
5166
5167 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5168
5169         * NEWS: Note minimum Python version.
5170
5171 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5172
5173         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5174         code from these functions.  Remove corresponding ifdefs.  Use
5175         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5176         Remove gotos and target of gotos.
5177         (infpy_search_memory): Likewise.
5178
5179 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5180
5181         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5182         (hppa_gdbarch_init): Don't register deleted functions with
5183         gdbarch.
5184
5185 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5186
5187         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5188         (h8300_unwind_sp): Delete.
5189         (h8300_dummy_id): Delete.
5190         (h8300_gdbarch_init): Don't register deleted functions with
5191         gdbarch.
5192
5193 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5194
5195         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
5196         (ft32_unwind_pc): Delete.
5197         (ft32_unwind_sp): Delete.
5198         (ft32_gdbarch_init): Don't register deleted functions with
5199         gdbarch.
5200
5201 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5202
5203         * gdb/frv-tdep.c (frv_dummy_id): Delete.
5204         (frv_unwind_pc): Delete.
5205         (frv_unwind_sp): Delete.
5206         (frv_gdbarch_init): Don't register deleted functions with
5207         gdbarch.
5208
5209 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5210
5211         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5212         (riscv_unwind_pc): Delete.
5213         (riscv_unwind_sp): Delete.
5214         (riscv_gdbarch_init): Don't register deleted functions with
5215         gdbarch.
5216
5217 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5218
5219         * gdb/csky-tdep.c (csky_dummy_id): Delete.
5220         (csky_unwind_pc): Delete.
5221         (csky_unwind_sp): Delete.
5222         (csky_gdbarch_init): Don't register deleted functions with
5223         gdbarch.
5224
5225 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5226
5227         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5228         (cris_unwind_pc): Delete.
5229         (cris_unwind_sp): Delete.
5230         (cris_gdbarch_init): Don't register deleted functions with
5231         gdbarch.
5232
5233 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5234
5235         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
5236         (bfin_unwind_pc): Delete.
5237         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
5238
5239 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5240
5241         * gdb/arm-tdep.c (arm_dummy_id): Delete.
5242         (arm_unwind_pc): Delete.
5243         (arm_unwind_sp): Delete.
5244         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
5245
5246 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5247
5248         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5249         (arc_unwind_pc): Delete.
5250         (arc_unwind_sp): Delete.
5251         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
5252
5253 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5254
5255         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
5256         (alpha_unwind_pc): Delete.
5257         (alpha_gdbarch_init): Don't register deleted functions with
5258         gdbarch.
5259
5260 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5261
5262         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
5263         (aarch64_unwind_pc): Delete.
5264         (aarch64_unwind_sp): Delete.
5265         (aarch64_gdbarch_init): Don't register deleted functions with
5266         gdbarch.
5267
5268 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5269
5270         * gdbtypes.c (type_align): Don't consider static members when
5271         computing structure alignment.
5272
5273 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5274
5275         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
5276         return 0 for other types.
5277         * arch-utils.c (default_type_align): Always return 0.
5278         * gdbarch.h: Regenerate.
5279         * gdbarch.sh (type_align): Extend comment.
5280         * gdbtypes.c (type_align): Add additional comments, always call
5281         gdbarch_type_align before applying the default rules.
5282         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
5283         generic code will then apply a suitable default.
5284         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
5285         types, return 0 for other types.
5286
5287 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5288
5289         * NEWS: Create a new section for the next release branch.
5290         Rename the section of the current branch, now that it has
5291         been cut.
5292
5293 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5294
5295         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5296         * version.in: Bump version to 8.3.50.DATE-git.
5297
5298 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5299
5300         * aix-thread.c (ptid_cmp): Remove unused variable.
5301         (get_signaled_thread): Likewise.
5302         (store_regs_user_thread): Likewise.
5303         (store_regs_kernel_thread): Likewise.
5304         (fetch_regs_kernel_thread): Remove shadowed variable.
5305
5306 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5307
5308         * features/riscv/32bit-cpu.xml: Add register numbers.
5309         * features/riscv/32bit-fpu.c: Regenerate.
5310         * features/riscv/32bit-fpu.xml: Add register numbers.
5311         * features/riscv/64bit-cpu.xml: Add register numbers.
5312         * features/riscv/64bit-fpu.c: Regenerate.
5313         * features/riscv/64bit-fpu.xml: Add register numbers.
5314
5315 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5316
5317         * NEWS: Mention two argument form of gdb.Value constructor.
5318         * python/py-value.c (convert_buffer_and_type_to_value): New
5319         function.
5320         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5321         Add support for handling an optional second argument.  Call
5322         convert_buffer_and_type_to_value as appropriate.
5323         * python/python-internal.h (Py_buffer_deleter): New struct.
5324         (Py_buffer_up): New typedef.
5325
5326 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5327
5328         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5329         instead of releasing ownership.
5330
5331 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5332
5333         * dwarf2read.c (open_and_init_dwp_file): Call
5334         elf_numsections instead of bfd_count_sections to initialize
5335         dwp_file->num_sections.
5336
5337 2019-02-25  Tom Tromey  <tromey@adacore.com>
5338
5339         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5340
5341 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5342
5343         * gcore.in: Add '--readnever' option when invoking GDB.
5344
5345 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5346
5347         * MAINTAINERS: Update my email address.
5348
5349 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5350
5351         * build-id.c (build_id_to_debug_bfd_1): New function.
5352         (build_id_to_debug_bfd): Look for separate debug file in
5353         sysroot.
5354
5355 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5356
5357         * gdbarch.sh: Update the copyright year range that is placed into
5358         generated files.
5359
5360 2019-02-22  Keith Seitz  <keiths@redhat.com>
5361
5362         PR symtab/23853
5363         * linespec.c (create_sals_line_offset): Search for the default
5364         symtab's filename instead of its fullname.
5365
5366 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5367
5368         * NEWS: Update style defaults.
5369
5370 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5371
5372         * main.c (captured_main_1): Disable styling in batch mode.
5373
5374 2019-02-20  Tom Tromey  <tom@tromey.com>
5375
5376         * symtab.c (symtab_symbol_info): Fix typos.
5377
5378 2019-02-20  Tom Tromey  <tromey@adacore.com>
5379
5380         * findcmd.c (_initialize_mem_search): Use upper case for
5381         metasyntactic variables.
5382
5383 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5384
5385         * aarch64-tdep.c (aarch64_add_reggroups): New function.
5386         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
5387
5388 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
5389
5390         * top.h (source_file_name): Change to std::string.
5391         * top.c (source_file_name): Likewise.
5392         (command_line_input): Adjust.
5393         * cli/cli-script.c (script_from_file): Adjust.
5394
5395 2019-02-19  Tom Tromey  <tromey@adacore.com>
5396
5397         * ravenscar-thread.c
5398         (ravenscar_thread_target::update_thread_list): Don't call
5399         ada_build_task_list.
5400         * ada-lang.h (ada_build_task_list): Don't declare.
5401         * ada-tasks.c (struct ada_tasks_inferior_data)
5402         <task_list_valid_p>: Now bool.
5403         (read_known_tasks, ada_task_list_changed)
5404         (ada_tasks_invalidate_inferior_data): Update.
5405         (read_known_tasks_array): Return bool.
5406         (read_known_tasks_list): Likewise.
5407         (read_known_tasks): Return void.
5408         (ada_build_task_list): Now static.
5409
5410 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5411
5412         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
5413         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
5414
5415 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5416
5417         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
5418         variant for ada_tasks_pspace_data_handle and
5419         ada_tasks_inferior_data_handle.
5420         (ada_tasks_pspace_data_cleanup): New function.
5421         (ada_tasks_inferior_data_cleanup): New function.
5422
5423 2019-02-17  Tom Tromey  <tom@tromey.com>
5424
5425         * macrotab.h (macro_source_fullname): Return a std::string.
5426         * macrotab.c (macro_include, check_for_redefinition)
5427         (macro_undef, macro_lookup_definition, foreach_macro)
5428         (foreach_macro_in_scope): Update.
5429         (macro_source_fullname): Return a std::string.
5430         * macrocmd.c (show_pp_source_pos): Update.
5431
5432 2019-02-17  Tom Tromey  <tom@tromey.com>
5433
5434         * macrocmd.c (show_pp_source_pos): Style the file names.
5435
5436 2019-02-17  Tom Tromey  <tom@tromey.com>
5437
5438         PR tui/24197:
5439         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5440
5441 2019-02-17  Tom Tromey  <tom@tromey.com>
5442
5443         * ada-lang.c (user_select_syms): Use filtered printing.
5444         * utils.c (wrap_style): New global.
5445         (desired_style): Remove.
5446         (emit_style_escape): Add stream parameter.
5447         (set_output_style, reset_terminal_style, prompt_for_continue):
5448         Update.
5449         (flush_wrap_buffer): Only flush gdb_stdout.
5450         (wrap_here): Set wrap_style.
5451         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
5452         treat escape sequences as a character.  Change when wrap buffer is
5453         flushed.
5454         (fputs_styled): Do not set the output style when the default is
5455         requested.
5456         * ui-style.h (struct ui_file_style) <is_default>: New method.
5457         * source.c (print_source_lines_base): Emit escape sequences in one
5458         piece.
5459
5460 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5461
5462         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
5463         integers and enumeration types.
5464
5465 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5466
5467         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
5468         instead of lookup_symbol_in_language
5469         (do_exact_match): New function.
5470         (ada_get_symbol_name_matcher): Return do_exact_match when
5471         doing a verbatim match.
5472
5473 2019-02-15  Tom Tromey  <tromey@adacore.com>
5474
5475         * ravenscar-thread.c (ravenscar_thread_target::resume)
5476         (ravenscar_thread_target::wait): Special case wildcard requests.
5477
5478 2019-02-15  Tom Tromey  <tromey@adacore.com>
5479
5480         * ravenscar-thread.c (base_ptid): Remove.
5481         (struct ravenscar_thread_target) <close>: New method.
5482         <m_base_ptid>: New member.
5483         <update_inferior_ptid, active_task, task_is_currently_active,
5484         runtime_initialized>: Declare methods.
5485         <ravenscar_thread_target>: Add constructor.
5486         (ravenscar_thread_target::task_is_currently_active)
5487         (ravenscar_thread_target::update_inferior_ptid)
5488         (ravenscar_runtime_initialized): Rename.  Now methods.
5489         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
5490         (ravenscar_thread_target::update_thread_list): Update.
5491         (ravenscar_thread_target::active_task): Now method.
5492         (ravenscar_thread_target::store_registers)
5493         (ravenscar_thread_target::prepare_to_store)
5494         (ravenscar_thread_target::prepare_to_store)
5495         (ravenscar_thread_target::mourn_inferior): Update.
5496         (ravenscar_inferior_created): Use "new" to create target.
5497         (ravenscar_thread_target::get_ada_task_ptid): Update.
5498         (_initialize_ravenscar): Don't initialize base_ptid.
5499         (ravenscar_ops): Remove global.
5500
5501 2019-02-15  Tom Tromey  <tromey@adacore.com>
5502
5503         * target.h (push_target): Declare new overload.
5504         * target.c (push_target): New overload, taking an rvalue reference.
5505         * remote.c (remote_target::open_1): Use push_target overload.
5506         * corelow.c (core_target_open): Use push_target overload.
5507
5508 2019-02-15  Tom Tromey  <tromey@adacore.com>
5509
5510         * ravenscar-thread.c (is_ravenscar_task)
5511         (ravenscar_task_is_currently_active): Return bool.
5512         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
5513         (_initialize_ravenscar): Remove "(void)".
5514         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
5515         Return bool.
5516
5517 2019-02-15  Tom Tromey  <tromey@adacore.com>
5518
5519         * ravenscar-thread.c (ravenscar_runtime_initializer)
5520         (has_ravenscar_runtime, get_running_thread_id)
5521         (ravenscar_thread_target::resume): Fix indentation.
5522
5523 2019-02-15  Tom Tromey  <tromey@adacore.com>
5524
5525         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
5526         from ravenscar_arch_ops.
5527         (sparc_ravenscar_ops::fetch_registers)
5528         (sparc_ravenscar_ops::store_registers): Now methods.
5529         (sparc_ravenscar_prepare_to_store): Remove.
5530         (sparc_ravenscar_ops): Redefine.
5531         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
5532         methods and destructor.  Remove members.
5533         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
5534         (ravenscar_thread_target::store_registers)
5535         (ravenscar_thread_target::prepare_to_store): Update.
5536         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
5537         Remove.
5538         (struct ppc_ravenscar_powerpc_ops): Derive from
5539         ravenscar_arch_ops.
5540         (ppc_ravenscar_powerpc_ops::fetch_registers)
5541         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
5542         (ppc_ravenscar_powerpc_ops): Redefine.
5543         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
5544         (ppc_ravenscar_e500_ops::fetch_registers)
5545         (ppc_ravenscar_e500_ops::store_registers): Now methods.
5546         (ppc_ravenscar_e500_ops): Redefine.
5547         * aarch64-ravenscar-thread.c
5548         (aarch64_ravenscar_generic_prepare_to_store): Remove.
5549         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
5550         (aarch64_ravenscar_fetch_registers)
5551         (aarch64_ravenscar_store_registers): Now methods.
5552         (aarch64_ravenscar_ops): Redefine.
5553
5554 2019-02-15  Tom Tromey  <tromey@adacore.com>
5555
5556         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
5557         (ravenscar_thread_target::stopped_by_hw_breakpoint)
5558         (ravenscar_thread_target::stopped_by_watchpoint)
5559         (ravenscar_thread_target::stopped_data_address)
5560         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
5561
5562 2019-02-15  Tom Tromey  <tromey@adacore.com>
5563
5564         * ravenscar-thread.c: Fix some typos.
5565
5566 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5567             Tom Tromey  <tromey@adacore.com>
5568
5569         * ada-lang.c (ada_exception_sal): Change addr_string to a
5570         std::string.
5571         (create_ada_exception_catchpoint): Update.
5572
5573 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5574             Tom Tromey  <tromey@adacore.com>
5575
5576         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
5577         (bp_location_ops): Remove.
5578         (base_breakpoint_allocate_location): Update.
5579         (free_bp_location): Update.
5580         * ada-lang.c (class ada_catchpoint_location)
5581         <ada_catchpoint_location>: Remove ops parameter.
5582         (ada_catchpoint_location_dtor): Remove.
5583         (ada_catchpoint_location_ops): Remove.
5584         (allocate_location_exception): Update.
5585         * breakpoint.h (struct bp_location_ops): Remove.
5586         (class bp_location) <bp_location>: Remove bp_location_ops
5587         parameter.
5588         <~bp_location>: Add destructor.
5589         <ops>: Remove.
5590
5591 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5592             Pedro Alves  <palves@redhat.com>
5593
5594         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
5595         'PATH_MAX'.
5596
5597 2019-02-14  David Michael  <fedora.dm0@gmail.com>
5598             Samuel Thibault  <samuel.thibault@gnu.org>
5599             Thomas Schwinge  <thomas@codesourcery.com>
5600
5601         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
5602         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
5603
5604 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5605
5606         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
5607         (check_empty): Use "const char *".
5608
5609         * gnu-nat.c (gnu_nat_target::detach): Instead of
5610         'detach_inferior (pid)' call
5611         'detach_inferior (find_inferior_pid (pid))'.
5612
5613         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
5614         'nat/fork-inferior.o'.
5615         * gnu-nat.c: #include "nat/fork-inferior.h".
5616
5617         * gnu-nat.c (gnu_nat_target::detach): Instead of
5618         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
5619         * gnu-nat.h: #include "inf-child.h".
5620         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
5621         'i386_gnu_nat_target::fetch_registers'.
5622         (gnu_store_registers): Rename/move to
5623         'i386_gnu_nat_target::store_registers'.
5624
5625         * config/i386/nm-i386gnu.h: Don't "#include" any files.
5626         * gnu-nat.h (mach_thread_info): New function.
5627         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
5628
5629         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
5630
5631 2019-02-14  Frederic Konrad  <konrad@adacore.com>
5632
5633         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
5634
5635 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
5636
5637         * windows-nat.c (windows_add_thread): Add new parameter
5638         "main_thread_p" with default value set to false.  Update
5639         function documentation as well as all callers.
5640         (windows_delete_thread): Likewise.
5641         (fake_create_process): Update call to windows_add_thread.
5642         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
5643         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
5644         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
5645         call to windows_delete_thread.
5646
5647 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
5648
5649         * MAINTAINERS: Add Andrew Burgess as global maintainer.
5650
5651 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5652
5653         * symfile.c (find_separate_debug_file): Use canonical path of
5654         sysroot with child_path instead of gdb_sysroot if it is valid.
5655
5656 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5657
5658         * symfile.c (find_separate_debug_file): Use child_path to
5659         determine if an object file is under a sysroot.
5660
5661 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5662
5663         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5664         unittests/child-path-selftests.c.
5665         * common/pathstuff.c (child_path): New function.
5666         * common/pathstuff.h (child_path): New prototype.
5667         * unittests/child-path-selftests.c: New file.
5668
5669 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5670
5671         * symfile.c (find_separate_debug_file): Look for separate debug
5672         files in debug directories under the sysroot.
5673
5674 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5675
5676         * symtab.h (struct minimal_symbol data_p): New const method.
5677         (struct minimal_symbol text_p): Likewise.
5678         * symtab.c (output_source_filename): Use file name style
5679         to print file name.
5680         (print_symbol_info): Likewise.
5681         (print_msymbol_info): Use address style to print addresses.
5682         Use function name style to print executable text symbols.
5683         (expand_symtab_containing_pc): Use data_p.
5684         (find_pc_sect_compunit_symtab): Likewise.
5685
5686 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5687
5688         * breakpoint.c (describe_other_breakpoints): Use address style
5689         to print addresses.
5690         (say_where): Likewise.
5691
5692 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5693
5694         * ada-typeprint.c (print_func_type): Print function name
5695         style to print function name.
5696         * c-typeprint.c (c_print_type_1): Likewise.
5697
5698 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
5699
5700         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
5701         for execve.
5702
5703 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5704
5705         * c-exp.y (direct_abs_decl): Use emplace_back to record the
5706         type_stack.
5707
5708 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
5709
5710         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
5711         TYPE_CODE_REF types.
5712
5713 2019-02-08  Jim Wilson  <jimw@sifive.com>
5714
5715         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
5716         (riscv_linux_fregset): New.
5717         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
5718
5719 2019-02-07  Tom Tromey  <tom@tromey.com>
5720
5721         * thread.c (thread_cancel_execution_command): Update.
5722         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
5723         methods.
5724         (struct thread_fsm_ops): Remove.
5725         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
5726         (thread_fsm_should_stop, thread_fsm_return_value)
5727         (thread_fsm_set_finished, thread_fsm_finished_p)
5728         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
5729         Don't declare.
5730         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
5731         * infrun.c (clear_proceed_status_thread)
5732         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
5733         (print_stop_event): Update.
5734         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
5735         Add constructor.
5736         (step_command_fsm_ops): Remove.
5737         (new_step_command_fsm): Remove.
5738         (step_1): Update.
5739         (step_command_fsm::should_stop): Rename from
5740         step_command_fsm_should_stop.
5741         (step_command_fsm::clean_up): Rename from
5742         step_command_fsm_clean_up.
5743         (step_command_fsm::do_async_reply_reason): Rename from
5744         step_command_fsm_async_reply_reason.
5745         (struct until_next_fsm): Inherit from thread_fsm.  Add
5746         constructor.
5747         (until_next_fsm_ops): Remove.
5748         (new_until_next_fsm): Remove.
5749         (until_next_fsm::should_stop): Rename from
5750         until_next_fsm_should_stop.
5751         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
5752         (until_next_fsm::do_async_reply_reason): Rename from
5753         until_next_fsm_async_reply_reason.
5754         (struct finish_command_fsm): Inherit from thread_fsm.  Add
5755         constructor.  Change type of breakpoint.
5756         (finish_command_fsm_ops): Remove.
5757         (new_finish_command_fsm): Remove.
5758         (finish_command_fsm::should_stop): Rename from
5759         finish_command_fsm_should_stop.
5760         (finish_command_fsm::clean_up): Rename from
5761         finish_command_fsm_clean_up.
5762         (finish_command_fsm::return_value): Rename from
5763         finish_command_fsm_return_value.
5764         (finish_command_fsm::do_async_reply_reason): Rename from
5765         finish_command_fsm_async_reply_reason.
5766         (finish_command): Update.
5767         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
5768         Add constructor.
5769         (call_thread_fsm_ops): Remove.
5770         (call_thread_fsm::call_thread_fsm): Rename from
5771         new_call_thread_fsm.
5772         (call_thread_fsm::should_stop): Rename from
5773         call_thread_fsm_should_stop.
5774         (call_thread_fsm::should_notify_stop): Rename from
5775         call_thread_fsm_should_notify_stop.
5776         (run_inferior_call, call_function_by_hand_dummy): Update.
5777         * cli/cli-interp.c (should_print_stop_to_console): Update.
5778         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
5779         Add constructor.  Change type of location_breakpoint,
5780         caller_breakpoint.
5781         (until_break_fsm_ops): Remove.
5782         (new_until_break_fsm): Remove.
5783         (until_break_fsm::should_stop): Rename from
5784         until_break_fsm_should_stop.
5785         (until_break_fsm::clean_up): Rename from
5786         until_break_fsm_clean_up.
5787         (until_break_fsm::do_async_reply_reason): Rename from
5788         until_break_fsm_async_reply_reason.
5789         (until_break_command): Update.
5790         * thread-fsm.c: Remove.
5791         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
5792
5793 2019-02-07  Tom Tromey  <tom@tromey.com>
5794
5795         * yy-remap.h: Add include guard.
5796         * xtensa-tdep.h: Add include guard.
5797         * xcoffread.h: Rename include guard.
5798         * varobj-iter.h: Add include guard.
5799         * tui/tui.h: Rename include guard.
5800         * tui/tui-winsource.h: Rename include guard.
5801         * tui/tui-wingeneral.h: Rename include guard.
5802         * tui/tui-windata.h: Rename include guard.
5803         * tui/tui-win.h: Rename include guard.
5804         * tui/tui-stack.h: Rename include guard.
5805         * tui/tui-source.h: Rename include guard.
5806         * tui/tui-regs.h: Rename include guard.
5807         * tui/tui-out.h: Rename include guard.
5808         * tui/tui-layout.h: Rename include guard.
5809         * tui/tui-io.h: Rename include guard.
5810         * tui/tui-hooks.h: Rename include guard.
5811         * tui/tui-file.h: Rename include guard.
5812         * tui/tui-disasm.h: Rename include guard.
5813         * tui/tui-data.h: Rename include guard.
5814         * tui/tui-command.h: Rename include guard.
5815         * tic6x-tdep.h: Add include guard.
5816         * target/waitstatus.h: Rename include guard.
5817         * target/wait.h: Rename include guard.
5818         * target/target.h: Rename include guard.
5819         * target/resume.h: Rename include guard.
5820         * target-float.h: Rename include guard.
5821         * stabsread.h: Add include guard.
5822         * rs6000-tdep.h: Add include guard.
5823         * riscv-fbsd-tdep.h: Add include guard.
5824         * regformats/regdef.h: Rename include guard.
5825         * record.h: Rename include guard.
5826         * python/python.h: Rename include guard.
5827         * python/python-internal.h: Rename include guard.
5828         * python/py-stopevent.h: Rename include guard.
5829         * python/py-ref.h: Rename include guard.
5830         * python/py-record.h: Rename include guard.
5831         * python/py-record-full.h: Rename include guard.
5832         * python/py-record-btrace.h: Rename include guard.
5833         * python/py-instruction.h: Rename include guard.
5834         * python/py-events.h: Rename include guard.
5835         * python/py-event.h: Rename include guard.
5836         * procfs.h: Add include guard.
5837         * proc-utils.h: Add include guard.
5838         * p-lang.h: Add include guard.
5839         * or1k-tdep.h: Rename include guard.
5840         * observable.h: Rename include guard.
5841         * nto-tdep.h: Rename include guard.
5842         * nat/x86-linux.h: Rename include guard.
5843         * nat/x86-linux-dregs.h: Rename include guard.
5844         * nat/x86-gcc-cpuid.h: Add include guard.
5845         * nat/x86-dregs.h: Rename include guard.
5846         * nat/x86-cpuid.h: Rename include guard.
5847         * nat/ppc-linux.h: Rename include guard.
5848         * nat/mips-linux-watch.h: Rename include guard.
5849         * nat/linux-waitpid.h: Rename include guard.
5850         * nat/linux-ptrace.h: Rename include guard.
5851         * nat/linux-procfs.h: Rename include guard.
5852         * nat/linux-osdata.h: Rename include guard.
5853         * nat/linux-nat.h: Rename include guard.
5854         * nat/linux-namespaces.h: Rename include guard.
5855         * nat/linux-btrace.h: Rename include guard.
5856         * nat/glibc_thread_db.h: Rename include guard.
5857         * nat/gdb_thread_db.h: Rename include guard.
5858         * nat/gdb_ptrace.h: Rename include guard.
5859         * nat/fork-inferior.h: Rename include guard.
5860         * nat/amd64-linux-siginfo.h: Rename include guard.
5861         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
5862         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
5863         * nat/aarch64-linux.h: Rename include guard.
5864         * nat/aarch64-linux-hw-point.h: Rename include guard.
5865         * mn10300-tdep.h: Add include guard.
5866         * mips-linux-tdep.h: Add include guard.
5867         * mi/mi-parse.h: Rename include guard.
5868         * mi/mi-out.h: Rename include guard.
5869         * mi/mi-main.h: Rename include guard.
5870         * mi/mi-interp.h: Rename include guard.
5871         * mi/mi-getopt.h: Rename include guard.
5872         * mi/mi-console.h: Rename include guard.
5873         * mi/mi-common.h: Rename include guard.
5874         * mi/mi-cmds.h: Rename include guard.
5875         * mi/mi-cmd-break.h: Rename include guard.
5876         * m2-lang.h: Add include guard.
5877         * location.h: Rename include guard.
5878         * linux-record.h: Rename include guard.
5879         * linux-nat.h: Add include guard.
5880         * linux-fork.h: Add include guard.
5881         * i386-darwin-tdep.h: Rename include guard.
5882         * hppa-linux-offsets.h: Add include guard.
5883         * guile/guile.h: Rename include guard.
5884         * guile/guile-internal.h: Rename include guard.
5885         * gnu-nat.h: Rename include guard.
5886         * gdb-stabs.h: Rename include guard.
5887         * frv-tdep.h: Add include guard.
5888         * f-lang.h: Add include guard.
5889         * event-loop.h: Add include guard.
5890         * darwin-nat.h: Rename include guard.
5891         * cp-abi.h: Rename include guard.
5892         * config/sparc/nm-sol2.h: Rename include guard.
5893         * config/nm-nto.h: Rename include guard.
5894         * config/nm-linux.h: Add include guard.
5895         * config/i386/nm-i386gnu.h: Rename include guard.
5896         * config/djgpp/nl_types.h: Rename include guard.
5897         * config/djgpp/langinfo.h: Rename include guard.
5898         * compile/gcc-cp-plugin.h: Add include guard.
5899         * compile/gcc-c-plugin.h: Add include guard.
5900         * compile/compile.h: Rename include guard.
5901         * compile/compile-object-run.h: Rename include guard.
5902         * compile/compile-object-load.h: Rename include guard.
5903         * compile/compile-internal.h: Rename include guard.
5904         * compile/compile-cplus.h: Rename include guard.
5905         * compile/compile-c.h: Rename include guard.
5906         * common/xml-utils.h: Rename include guard.
5907         * common/x86-xstate.h: Rename include guard.
5908         * common/version.h: Rename include guard.
5909         * common/vec.h: Rename include guard.
5910         * common/tdesc.h: Rename include guard.
5911         * common/selftest.h: Rename include guard.
5912         * common/scoped_restore.h: Rename include guard.
5913         * common/scoped_mmap.h: Rename include guard.
5914         * common/scoped_fd.h: Rename include guard.
5915         * common/safe-iterator.h: Rename include guard.
5916         * common/run-time-clock.h: Rename include guard.
5917         * common/refcounted-object.h: Rename include guard.
5918         * common/queue.h: Rename include guard.
5919         * common/ptid.h: Rename include guard.
5920         * common/print-utils.h: Rename include guard.
5921         * common/preprocessor.h: Rename include guard.
5922         * common/pathstuff.h: Rename include guard.
5923         * common/observable.h: Rename include guard.
5924         * common/netstuff.h: Rename include guard.
5925         * common/job-control.h: Rename include guard.
5926         * common/host-defs.h: Rename include guard.
5927         * common/gdb_wait.h: Rename include guard.
5928         * common/gdb_vecs.h: Rename include guard.
5929         * common/gdb_unlinker.h: Rename include guard.
5930         * common/gdb_unique_ptr.h: Rename include guard.
5931         * common/gdb_tilde_expand.h: Rename include guard.
5932         * common/gdb_sys_time.h: Rename include guard.
5933         * common/gdb_string_view.h: Rename include guard.
5934         * common/gdb_splay_tree.h: Rename include guard.
5935         * common/gdb_setjmp.h: Rename include guard.
5936         * common/gdb_ref_ptr.h: Rename include guard.
5937         * common/gdb_optional.h: Rename include guard.
5938         * common/gdb_locale.h: Rename include guard.
5939         * common/gdb_assert.h: Rename include guard.
5940         * common/filtered-iterator.h: Rename include guard.
5941         * common/filestuff.h: Rename include guard.
5942         * common/fileio.h: Rename include guard.
5943         * common/environ.h: Rename include guard.
5944         * common/common-utils.h: Rename include guard.
5945         * common/common-types.h: Rename include guard.
5946         * common/common-regcache.h: Rename include guard.
5947         * common/common-inferior.h: Rename include guard.
5948         * common/common-gdbthread.h: Rename include guard.
5949         * common/common-exceptions.h: Rename include guard.
5950         * common/common-defs.h: Rename include guard.
5951         * common/common-debug.h: Rename include guard.
5952         * common/cleanups.h: Rename include guard.
5953         * common/buffer.h: Rename include guard.
5954         * common/btrace-common.h: Rename include guard.
5955         * common/break-common.h: Rename include guard.
5956         * cli/cli-utils.h: Rename include guard.
5957         * cli/cli-style.h: Rename include guard.
5958         * cli/cli-setshow.h: Rename include guard.
5959         * cli/cli-script.h: Rename include guard.
5960         * cli/cli-interp.h: Rename include guard.
5961         * cli/cli-decode.h: Rename include guard.
5962         * cli/cli-cmds.h: Rename include guard.
5963         * charset-list.h: Add include guard.
5964         * buildsym-legacy.h: Rename include guard.
5965         * bfin-tdep.h: Add include guard.
5966         * ax.h: Rename include guard.
5967         * arm-linux-tdep.h: Add include guard.
5968         * arm-fbsd-tdep.h: Add include guard.
5969         * arch/xtensa.h: Rename include guard.
5970         * arch/tic6x.h: Add include guard.
5971         * arch/i386.h: Add include guard.
5972         * arch/arm.h: Rename include guard.
5973         * arch/arm-linux.h: Rename include guard.
5974         * arch/arm-get-next-pcs.h: Rename include guard.
5975         * arch/amd64.h: Add include guard.
5976         * arch/aarch64-insn.h: Rename include guard.
5977         * arch-utils.h: Rename include guard.
5978         * annotate.h: Add include guard.
5979         * amd64-darwin-tdep.h: Rename include guard.
5980         * aarch64-linux-tdep.h: Add include guard.
5981         * aarch64-fbsd-tdep.h: Add include guard.
5982         * aarch32-linux-nat.h: Add include guard.
5983
5984 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5985
5986         * macrotab.c (macro_define_internal): New function that
5987         factorizes macro_define_object_internal and macro_define_function
5988         code.
5989         (macro_define_object_internal): Use macro_define_internal.
5990         (macro_define_function): Likewise.
5991
5992 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5993
5994         * macrocmd.c (extract_identifier): Return
5995         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5996         callers.
5997
5998 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5999
6000         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
6001
6002 2019-02-05  Tom Tromey  <tom@tromey.com>
6003
6004         * target.c (target_stack::unpush): Move assertion earlier.
6005
6006 2019-01-30  Tom Tromey  <tom@tromey.com>
6007
6008         PR python/23615:
6009         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
6010         (gdbpy_parse_and_eval): Likewise.
6011         * python/python-internal.h (gdbpy_allow_threads): New class.
6012
6013 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
6014
6015         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
6016         (aarch64_fbsd_fpregmap): Move earlier.
6017         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
6018         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6019         instead of individual calls to trad_frame_set_reg_addr.
6020         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6021         earlier.
6022         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
6023         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6024         instead of individual calls to trad_frame_set_reg_addr.
6025
6026 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
6027
6028         * CONTRIBUTE: Replace contribution list with wiki link.
6029
6030 2019-01-25  Tom Tromey  <tom@tromey.com>
6031
6032         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
6033
6034 2019-01-25  Tom Tromey  <tom@tromey.com>
6035
6036         * xtensa-linux-nat.c: Fix common/ includes.
6037         * xml-support.h: Fix common/ includes.
6038         * xml-support.c: Fix common/ includes.
6039         * x86-linux-nat.c: Fix common/ includes.
6040         * windows-nat.c: Fix common/ includes.
6041         * varobj.h: Fix common/ includes.
6042         * varobj.c: Fix common/ includes.
6043         * value.c: Fix common/ includes.
6044         * valops.c: Fix common/ includes.
6045         * utils.c: Fix common/ includes.
6046         * unittests/xml-utils-selftests.c: Fix common/ includes.
6047         * unittests/utils-selftests.c: Fix common/ includes.
6048         * unittests/unpack-selftests.c: Fix common/ includes.
6049         * unittests/tracepoint-selftests.c: Fix common/ includes.
6050         * unittests/style-selftests.c: Fix common/ includes.
6051         * unittests/string_view-selftests.c: Fix common/ includes.
6052         * unittests/scoped_restore-selftests.c: Fix common/ includes.
6053         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
6054         * unittests/scoped_fd-selftests.c: Fix common/ includes.
6055         * unittests/rsp-low-selftests.c: Fix common/ includes.
6056         * unittests/parse-connection-spec-selftests.c: Fix common/
6057         includes.
6058         * unittests/optional-selftests.c: Fix common/ includes.
6059         * unittests/offset-type-selftests.c: Fix common/ includes.
6060         * unittests/observable-selftests.c: Fix common/ includes.
6061         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
6062         * unittests/memrange-selftests.c: Fix common/ includes.
6063         * unittests/memory-map-selftests.c: Fix common/ includes.
6064         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
6065         * unittests/function-view-selftests.c: Fix common/ includes.
6066         * unittests/environ-selftests.c: Fix common/ includes.
6067         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
6068         * unittests/common-utils-selftests.c: Fix common/ includes.
6069         * unittests/cli-utils-selftests.c: Fix common/ includes.
6070         * unittests/array-view-selftests.c: Fix common/ includes.
6071         * ui-file.c: Fix common/ includes.
6072         * tui/tui-io.c: Fix common/ includes.
6073         * tracepoint.h: Fix common/ includes.
6074         * tracepoint.c: Fix common/ includes.
6075         * tracefile-tfile.c: Fix common/ includes.
6076         * top.h: Fix common/ includes.
6077         * top.c: Fix common/ includes.
6078         * thread.c: Fix common/ includes.
6079         * target/waitstatus.h: Fix common/ includes.
6080         * target/waitstatus.c: Fix common/ includes.
6081         * target.h: Fix common/ includes.
6082         * target.c: Fix common/ includes.
6083         * target-memory.c: Fix common/ includes.
6084         * target-descriptions.c: Fix common/ includes.
6085         * symtab.h: Fix common/ includes.
6086         * symfile.c: Fix common/ includes.
6087         * stap-probe.c: Fix common/ includes.
6088         * spu-linux-nat.c: Fix common/ includes.
6089         * sparc-nat.c: Fix common/ includes.
6090         * source.c: Fix common/ includes.
6091         * solib.c: Fix common/ includes.
6092         * solib-target.c: Fix common/ includes.
6093         * ser-unix.c: Fix common/ includes.
6094         * ser-tcp.c: Fix common/ includes.
6095         * ser-pipe.c: Fix common/ includes.
6096         * ser-base.c: Fix common/ includes.
6097         * selftest-arch.c: Fix common/ includes.
6098         * s12z-tdep.c: Fix common/ includes.
6099         * rust-exp.y: Fix common/ includes.
6100         * rs6000-aix-tdep.c: Fix common/ includes.
6101         * riscv-tdep.c: Fix common/ includes.
6102         * remote.c: Fix common/ includes.
6103         * remote-notif.h: Fix common/ includes.
6104         * remote-fileio.h: Fix common/ includes.
6105         * remote-fileio.c: Fix common/ includes.
6106         * regcache.h: Fix common/ includes.
6107         * regcache.c: Fix common/ includes.
6108         * record-btrace.c: Fix common/ includes.
6109         * python/python.c: Fix common/ includes.
6110         * python/py-type.c: Fix common/ includes.
6111         * python/py-inferior.c: Fix common/ includes.
6112         * progspace.h: Fix common/ includes.
6113         * producer.c: Fix common/ includes.
6114         * procfs.c: Fix common/ includes.
6115         * proc-api.c: Fix common/ includes.
6116         * printcmd.c: Fix common/ includes.
6117         * ppc-linux-nat.c: Fix common/ includes.
6118         * parser-defs.h: Fix common/ includes.
6119         * osdata.c: Fix common/ includes.
6120         * obsd-nat.c: Fix common/ includes.
6121         * nat/x86-linux.c: Fix common/ includes.
6122         * nat/x86-linux-dregs.c: Fix common/ includes.
6123         * nat/x86-dregs.h: Fix common/ includes.
6124         * nat/x86-dregs.c: Fix common/ includes.
6125         * nat/ppc-linux.c: Fix common/ includes.
6126         * nat/mips-linux-watch.h: Fix common/ includes.
6127         * nat/mips-linux-watch.c: Fix common/ includes.
6128         * nat/linux-waitpid.c: Fix common/ includes.
6129         * nat/linux-ptrace.h: Fix common/ includes.
6130         * nat/linux-ptrace.c: Fix common/ includes.
6131         * nat/linux-procfs.c: Fix common/ includes.
6132         * nat/linux-personality.c: Fix common/ includes.
6133         * nat/linux-osdata.c: Fix common/ includes.
6134         * nat/linux-namespaces.c: Fix common/ includes.
6135         * nat/linux-btrace.h: Fix common/ includes.
6136         * nat/linux-btrace.c: Fix common/ includes.
6137         * nat/fork-inferior.c: Fix common/ includes.
6138         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6139         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6140         * nat/aarch64-linux.c: Fix common/ includes.
6141         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6142         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6143         * namespace.h: Fix common/ includes.
6144         * mips-linux-tdep.c: Fix common/ includes.
6145         * minsyms.c: Fix common/ includes.
6146         * mi/mi-parse.h: Fix common/ includes.
6147         * mi/mi-main.c: Fix common/ includes.
6148         * mi/mi-cmd-env.c: Fix common/ includes.
6149         * memrange.h: Fix common/ includes.
6150         * memattr.c: Fix common/ includes.
6151         * maint.h: Fix common/ includes.
6152         * maint.c: Fix common/ includes.
6153         * main.c: Fix common/ includes.
6154         * machoread.c: Fix common/ includes.
6155         * location.c: Fix common/ includes.
6156         * linux-thread-db.c: Fix common/ includes.
6157         * linux-nat.c: Fix common/ includes.
6158         * linux-fork.c: Fix common/ includes.
6159         * inline-frame.c: Fix common/ includes.
6160         * infrun.c: Fix common/ includes.
6161         * inflow.c: Fix common/ includes.
6162         * inferior.h: Fix common/ includes.
6163         * inferior.c: Fix common/ includes.
6164         * infcmd.c: Fix common/ includes.
6165         * inf-ptrace.c: Fix common/ includes.
6166         * inf-child.c: Fix common/ includes.
6167         * ia64-linux-nat.c: Fix common/ includes.
6168         * i387-tdep.c: Fix common/ includes.
6169         * i386-tdep.c: Fix common/ includes.
6170         * i386-linux-tdep.c: Fix common/ includes.
6171         * i386-linux-nat.c: Fix common/ includes.
6172         * i386-go32-tdep.c: Fix common/ includes.
6173         * i386-fbsd-tdep.c: Fix common/ includes.
6174         * i386-fbsd-nat.c: Fix common/ includes.
6175         * guile/scm-type.c: Fix common/ includes.
6176         * guile/guile.c: Fix common/ includes.
6177         * go32-nat.c: Fix common/ includes.
6178         * gnu-nat.c: Fix common/ includes.
6179         * gdbthread.h: Fix common/ includes.
6180         * gdbarch-selftests.c: Fix common/ includes.
6181         * gdb_usleep.c: Fix common/ includes.
6182         * gdb_select.h: Fix common/ includes.
6183         * gdb_bfd.c: Fix common/ includes.
6184         * gcore.c: Fix common/ includes.
6185         * fork-child.c: Fix common/ includes.
6186         * findvar.c: Fix common/ includes.
6187         * fbsd-nat.c: Fix common/ includes.
6188         * event-top.c: Fix common/ includes.
6189         * event-loop.c: Fix common/ includes.
6190         * dwarf2read.c: Fix common/ includes.
6191         * dwarf2loc.c: Fix common/ includes.
6192         * dwarf2-frame.c: Fix common/ includes.
6193         * dwarf-index-cache.c: Fix common/ includes.
6194         * dtrace-probe.c: Fix common/ includes.
6195         * disasm-selftests.c: Fix common/ includes.
6196         * defs.h: Fix common/ includes.
6197         * csky-tdep.c: Fix common/ includes.
6198         * cp-valprint.c: Fix common/ includes.
6199         * cp-support.h: Fix common/ includes.
6200         * cp-support.c: Fix common/ includes.
6201         * corelow.c: Fix common/ includes.
6202         * completer.h: Fix common/ includes.
6203         * completer.c: Fix common/ includes.
6204         * compile/compile.c: Fix common/ includes.
6205         * compile/compile-loc2c.c: Fix common/ includes.
6206         * compile/compile-cplus-types.c: Fix common/ includes.
6207         * compile/compile-cplus-symbols.c: Fix common/ includes.
6208         * command.h: Fix common/ includes.
6209         * cli/cli-dump.c: Fix common/ includes.
6210         * cli/cli-cmds.c: Fix common/ includes.
6211         * charset.c: Fix common/ includes.
6212         * build-id.c: Fix common/ includes.
6213         * btrace.h: Fix common/ includes.
6214         * btrace.c: Fix common/ includes.
6215         * breakpoint.h: Fix common/ includes.
6216         * breakpoint.c: Fix common/ includes.
6217         * ax.h:
6218         (enum agent_op): Fix common/ includes.
6219         * ax-general.c (struct aop_map): Fix common/ includes.
6220         * ax-gdb.c: Fix common/ includes.
6221         * auxv.c: Fix common/ includes.
6222         * auto-load.c: Fix common/ includes.
6223         * arm-tdep.c: Fix common/ includes.
6224         * arch/riscv.c: Fix common/ includes.
6225         * arch/ppc-linux-common.c: Fix common/ includes.
6226         * arch/i386.c: Fix common/ includes.
6227         * arch/arm.c: Fix common/ includes.
6228         * arch/arm-linux.c: Fix common/ includes.
6229         * arch/arm-get-next-pcs.c: Fix common/ includes.
6230         * arch/amd64.c: Fix common/ includes.
6231         * arch/aarch64.c: Fix common/ includes.
6232         * arch/aarch64-insn.c: Fix common/ includes.
6233         * arch-utils.c: Fix common/ includes.
6234         * amd64-windows-tdep.c: Fix common/ includes.
6235         * amd64-tdep.c: Fix common/ includes.
6236         * amd64-sol2-tdep.c: Fix common/ includes.
6237         * amd64-obsd-tdep.c: Fix common/ includes.
6238         * amd64-nbsd-tdep.c: Fix common/ includes.
6239         * amd64-linux-tdep.c: Fix common/ includes.
6240         * amd64-linux-nat.c: Fix common/ includes.
6241         * amd64-fbsd-tdep.c: Fix common/ includes.
6242         * amd64-fbsd-nat.c: Fix common/ includes.
6243         * amd64-dicos-tdep.c: Fix common/ includes.
6244         * amd64-darwin-tdep.c: Fix common/ includes.
6245         * agent.c: Fix common/ includes.
6246         * ada-lang.h: Fix common/ includes.
6247         * ada-lang.c: Fix common/ includes.
6248         * aarch64-tdep.c: Fix common/ includes.
6249
6250 2019-01-25  Tom Tromey  <tom@tromey.com>
6251
6252         * common/create-version.sh: Use common/version.h.
6253
6254 2019-01-24  Pedro Alves  <palves@redhat.com>
6255
6256         * infrun.c (signal_stop, signal_print, signal_program)
6257         (signal_catch, signal_pass): Now arrays instead of pointers.
6258         (update_signals_program_target, do_target_resume)
6259         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
6260         * linux-nat.c (linux_nat_target::pass_signals)
6261         (linux_nat_target::create_inferior, linux_nat_target::attach):
6262         Adjust.
6263         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
6264         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
6265         * procfs.c (procfs_target::pass_signals): Adjust.
6266         * record-full.c (record_full_target::resume): Adjust.
6267         * remote.c (remote_target::pass_signals)
6268         (remote_target::program_signals): Adjust.
6269         * target-debug.h (target_debug_print_signals): Now takes a
6270         gdb::array_view as parameter.  Adjust.
6271         * target.h (target_ops) <pass_signals, program_signals>: Replace
6272         pointer and length parameters with gdb::array_view.
6273         (target_pass_signals, target_program_signals): Likewise.
6274         * target-delegates.c: Regenerate.
6275
6276 2019-01-24  Pedro Alves  <palves@redhat.com>
6277
6278         * common/forward-scope-exit.h
6279         (forward_scope_exit::forward_scope_exit): Pass arguments to
6280         m_bind_function directly, instead of creating a std::bind and
6281         copying that.
6282
6283 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
6284
6285         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6286         for static members.
6287         (pass_in_v_vfp_candidate): Likewise.
6288
6289 2019-01-23  Tom Tromey  <tom@tromey.com>
6290             Pedro Alves  <palves@redhat.com>
6291
6292         * regcache.c (class regcache_invalidator): Remove.
6293         (regcache::raw_write): Use make_scope_exit.
6294
6295 2019-01-23  Tom Tromey  <tom@tromey.com>
6296
6297         * ui-out.h (class ui_out_emit_type): Update comment.
6298
6299 2019-01-23  Tom Tromey  <tom@tromey.com>
6300
6301         * infrun.c (fetch_inferior_event): Update comment.
6302
6303 2019-01-23  Tom Tromey  <tom@tromey.com>
6304             Pedro Alves  <palves@redhat.com>
6305
6306         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6307         parameter.
6308         (fetch_inferior_event): Use SCOPE_EXIT.
6309
6310
6311 2019-01-23  Tom Tromey  <tom@tromey.com>
6312             Pedro Alves  <palves@redhat.com>
6313
6314         * infrun.c (disable_thread_events): Delete.
6315         (stop_all_threads): Use SCOPE_EXIT.
6316
6317 2019-01-23  Tom Tromey  <tom@tromey.com>
6318             Pedro Alves  <palves@redhat.com>
6319
6320         * symfile.c: Include forward-scope-exit.h.
6321         (clear_symtab_users_cleanup): Replace forward declaration with
6322         a FORWARD_SCOPE_EXIT.
6323         (syms_from_objfile_1): Use the forward_scope_exit and
6324         gdb::optional instead of cleanup_function.
6325         (reread_symbols): Use the forward_scope_exit instead of
6326         cleanup_function.
6327         (clear_symtab_users_cleanup): Remove function.
6328
6329 2019-01-23  Tom Tromey  <tom@tromey.com>
6330             Pedro Alves  <palves@redhat.com>
6331
6332         * linux-nat.c: Include scope-exit.h.
6333         (cleanup_target_stop): Remove.
6334         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6335         SCOPE_EXIT.
6336
6337 2019-01-23  Tom Tromey  <tom@tromey.com>
6338             Pedro Alves  <palves@redhat.com>
6339
6340         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6341         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6342
6343 2019-01-23  Tom Tromey  <tom@tromey.com>
6344             Andrew Burgess  <andrew.burgess@embecosm.com>
6345             Pedro Alves  <palves@redhat.com>
6346
6347         * infrun.c (fetch_inferior_event): Use scope_exit.
6348         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6349         * top.c (execute_command): Use scope_exit.
6350         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6351         * utils.c (do_bpstat_clear_actions_cleanup)
6352         (make_bpstat_clear_actions_cleanup): Remove.
6353
6354 2019-01-23  Tom Tromey  <tom@tromey.com>
6355             Pedro Alves  <palves@redhat.com>
6356
6357         * infrun.c: Include "common/scope-exit.h"
6358         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6359         (wait_for_inferior): Use SCOPE_EXIT.
6360         (fetch_inferior_event): Use scope_exit.
6361
6362 2019-01-23  Tom Tromey  <tom@tromey.com>
6363             Pedro Alves  <palves@redhat.com>
6364
6365         * breakpoint.c (create_breakpoint): Remove cleanup.
6366
6367 2019-01-23  Tom Tromey  <tom@tromey.com>
6368             Andrew Burgess  <andrew.burgess@embecosm.com>
6369             Pedro Alves  <palves@redhat.com>
6370
6371 2019-01-23  Pedro Alves  <palves@redhat.com>
6372
6373         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
6374
6375 2019-01-23  Pedro Alves  <palves@redhat.com>
6376             Andrew Burgess  <andrew.burgess@embecosm.com>
6377
6378         * gdbthread.h: Include "common/forward-scope-exit.h".
6379         (scoped_finish_thread_state): Redefine custom class in terms of
6380         forward_scope_exit.
6381
6382 2019-01-23  Pedro Alves  <palves@redhat.com>
6383             Andrew Burgess  <andrew.burgess@embecosm.com>
6384
6385         * common/forward-scope-exit.h: New file.
6386
6387 2019-01-23  Pedro Alves  <palves@redhat.com>
6388             Andrew Burgess  <andrew.burgess@embecosm.com>
6389             Tom Tromey  <tom@tromey.com>
6390
6391         * common/scope-exit.h: New file.
6392
6393 2019-01-23  Pedro Alves  <palves@redhat.com>
6394
6395         * common/preprocessor.h (ESC): Rename to ...
6396         (ESC_PARENS): ... this.
6397         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
6398         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
6399
6400 2019-01-23  Tom Tromey  <tom@tromey.com>
6401
6402         * language.h (class scoped_switch_to_sym_language_if_auto):
6403         Initialize m_lang in both cases.
6404
6405 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
6406
6407         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
6408         with XCNEW.
6409
6410 2019-01-22  Tom Tromey  <tom@tromey.com>
6411
6412         * corelow.c: Do not include sys/file.h.
6413
6414 2019-01-22  Tom Tromey  <tom@tromey.com>
6415
6416         * tui/tui-wingeneral.h: Include gdb_curses.h.
6417
6418 2019-01-22  Tom Tromey  <tom@tromey.com>
6419
6420         * source-cache.h (class source_cache) <get_source_lines,
6421         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
6422
6423 2019-01-22  Tom Tromey  <tom@tromey.com>
6424
6425         * remote-fileio.h (struct remote_target): Declare.
6426
6427 2019-01-22  Tom Tromey  <tom@tromey.com>
6428
6429         * python/py-arch.c: Do not include py-ref.h.
6430         * python/py-bpevent.c: Do not include py-ref.h.
6431         * python/py-cmd.c: Do not include py-ref.h.
6432         * python/py-continueevent.c: Do not include py-ref.h.
6433         * python/py-event.h: Do not include py-ref.h.
6434         * python/py-evtregistry.c: Do not include py-ref.h.
6435         * python/py-finishbreakpoint.c: Do not include py-ref.h.
6436         * python/py-frame.c: Do not include py-ref.h.
6437         * python/py-framefilter.c: Do not include py-ref.h.
6438         * python/py-function.c: Do not include py-ref.h.
6439         * python/py-infevents.c: Do not include py-ref.h.
6440         * python/py-linetable.c: Do not include py-ref.h.
6441         * python/py-objfile.c: Do not include py-ref.h.
6442         * python/py-param.c: Do not include py-ref.h.
6443         * python/py-prettyprint.c: Do not include py-ref.h.
6444         * python/py-progspace.c: Do not include py-ref.h.
6445         * python/py-symbol.c: Do not include py-ref.h.
6446         * python/py-symtab.c: Do not include py-ref.h.
6447         * python/py-type.c: Do not include py-ref.h.
6448         * python/py-unwind.c: Do not include py-ref.h.
6449         * python/py-utils.c: Do not include py-ref.h.
6450         * python/py-value.c: Do not include py-ref.h.
6451         * python/py-varobj.c: Do not include py-ref.h.
6452         * python/py-xmethods.c: Do not include py-ref.h.
6453         * python/python.c: Do not include py-ref.h.
6454         * varobj.c: Do not include py-ref.h.
6455
6456 2019-01-22  Tom Tromey  <tom@tromey.com>
6457
6458         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
6459         keyword for bcache.
6460
6461 2019-01-22  Tom Tromey  <tom@tromey.com>
6462
6463         * compile/compile-cplus-types.c: Remove a comment by #include.
6464
6465 2019-01-22  Tom Tromey  <tom@tromey.com>
6466
6467         * compile/gcc-c-plugin.h: Include compile-internal.h.
6468
6469 2019-01-22  Tom Tromey  <tom@tromey.com>
6470
6471         * stabsread.c (EXTERN): Do not define.
6472         (symnum, next_symbol_text_func, processing_gcc_compilation)
6473         (within_function, global_sym_chain, global_stabs)
6474         (previous_stab_code, this_object_header_files)
6475         (n_this_object_header_files)
6476         (n_allocated_this_object_header_files): Define.
6477         * stabsread.h (EXTERN): Never define.  Use "extern".
6478
6479 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6480
6481         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
6482         history_value.
6483
6484 2019-01-21  Tom Tromey  <tom@tromey.com>
6485
6486         * ui-out.c: Fix includes.
6487         * tui/tui-source.c: Fix includes.
6488         * target.c: Fix includes.
6489         * remote.c: Fix includes.
6490         * regcache.c: Fix includes.
6491         * python/py-block.c: Fix includes.
6492         * printcmd.c: Fix includes.
6493         * or1k-tdep.c: Fix includes.
6494         * mi/mi-main.c: Fix includes.
6495         * m32r-tdep.c: Fix includes.
6496         * csky-tdep.c: Fix includes.
6497         * compile/compile-cplus-types.c: Fix includes.
6498         * cli/cli-interp.c: Fix includes.
6499
6500 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
6501
6502         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6503         for padding.
6504
6505 2019-01-16  Tom Tromey  <tom@tromey.com>
6506
6507         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
6508         earlier.
6509         (struct objfile) <msymbols_range>: Move from top level.
6510         <msymbols>: New method.
6511         (class objfile_msymbols): Remove.
6512         * symtab.c (default_collect_symbol_completion_matches_break_on):
6513         Update.
6514         * symmisc.c (dump_msymbols): Update.
6515         * stabsread.c (scan_file_globals): Update.
6516         * objc-lang.c (info_selectors_command, info_classes_command)
6517         (find_methods): Update.
6518         * minsyms.c (find_solib_trampoline_target): Update.
6519         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
6520         * coffread.c (coff_symfile_read): Update.
6521         * ada-lang.c (ada_lookup_simple_minsym)
6522         (ada_collect_symbol_completion_matches): Update.
6523
6524 2019-01-16  Tom Tromey  <tom@tromey.com>
6525
6526         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
6527         type.  Remove no-argument constructor.
6528         <iterator::operator++>: Simplify.
6529         <begin>: Update.
6530         <end>: Use minimal_symbol_count.
6531
6532 2019-01-16  Tom Tromey  <tom@tromey.com>
6533
6534         * objfiles.h (struct objfile) <psymtabs>: New method.
6535         (class objfile_psymtabs): Remove.
6536         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
6537         typedef.
6538         <range>: New method.
6539         (require_partial_symbols): Change return type.
6540         * psymtab.c (require_partial_symbols)
6541         (psym_expand_symtabs_matching): Update.
6542         * mdebugread.c (parse_partial_symbols): Update.
6543         * dbxread.c (dbx_end_psymtab): Update.
6544
6545 2019-01-15  Tom Tromey  <tom@tromey.com>
6546
6547         * symtab.c (lookup_objfile_from_block)
6548         (lookup_symbol_in_objfile_symtabs)
6549         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
6550         (find_line_symtab, info_sources_command)
6551         (default_collect_symbol_completion_matches_break_on)
6552         (make_source_files_completion_list): Update.
6553         * symmisc.c (print_objfile_statistics, dump_objfile)
6554         (maintenance_print_symbols, maintenance_info_symtabs)
6555         (maintenance_check_symtabs, maintenance_info_line_tables):
6556         Update.
6557         * source.c (select_source_symtab)
6558         (forget_cached_source_info_for_objfile): Update.
6559         * objfiles.h (class objfile_compunits): Remove.
6560         (struct objfile) <compunits_range>: New typedef.
6561         (compunits): New method.
6562         * objfiles.c (objfile_relocate1): Update.
6563         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6564         * maint.c (count_symtabs_and_blocks): Update.
6565         * linespec.c (iterate_over_all_matching_symtabs): Update.
6566         * cp-support.c (add_symbol_overload_list_qualified): Update.
6567         * coffread.c (coff_symtab_read): Update.
6568         * ada-lang.c (add_nonlocal_symbols)
6569         (ada_collect_symbol_completion_matches)
6570         (ada_add_global_exceptions): Update.
6571
6572 2019-01-15  Tom Tromey  <tom@tromey.com>
6573
6574         * progspace.h (program_space) <objfiles_safe_range>: New
6575         typedef.
6576         <objfiles_safe>: New method.
6577         * objfiles.h (class all_objfiles_safe): Remove.
6578         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
6579         * jit.c (jit_inferior_exit_hook): Update.
6580
6581 2019-01-17  Tom Tromey  <tom@tromey.com>
6582
6583         * progspace.h (program_space) <objfiles_range>: New typedef.
6584         <objfiles>: New method.
6585         <objfiles_head>: Rename from objfiles.
6586         (object_files): Update.
6587         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
6588         * guile/scm-pretty-print.c
6589         (ppscm_find_pretty_printer_from_objfiles): Update.
6590         * guile/scm-objfile.c (gdbscm_objfiles): Update.
6591         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
6592         Update.
6593         * python/py-progspace.c (pspy_get_objfiles): Update.
6594         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6595         Update.
6596         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6597         (objfpy_lookup_objfile_by_build_id): Update.
6598         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6599         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6600         Update.
6601         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6602         (expand_symtab_containing_pc, lookup_objfile_from_block)
6603         (lookup_static_symbol, basic_lookup_transparent_type)
6604         (find_pc_sect_compunit_symtab, find_symbol_at_address)
6605         (find_line_symtab, info_sources_command)
6606         (default_collect_symbol_completion_matches_break_on)
6607         (make_source_files_completion_list, find_main_name): Update.
6608         * symmisc.c (print_symbol_bcache_statistics)
6609         (print_objfile_statistics, maintenance_print_symbols)
6610         (maintenance_print_msymbols, maintenance_print_objfiles)
6611         (maintenance_info_symtabs, maintenance_check_symtabs)
6612         (maintenance_expand_symtabs, maintenance_info_line_tables):
6613         Update.
6614         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
6615         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
6616         (map_overlay_command, unmap_overlay_command)
6617         (simple_overlay_update, expand_symtabs_matching)
6618         (map_symbol_filenames): Update.
6619         * symfile-debug.c (set_debug_symfile): Update.
6620         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
6621         Update.
6622         * source.c (select_source_symtab, forget_cached_source_info):
6623         Update.
6624         * solib.c (solib_read_symbols): Update.
6625         * solib-spu.c (append_ocl_sos): Update.
6626         * psymtab.c (maintenance_print_psymbols)
6627         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
6628         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
6629         * printcmd.c (info_symbol_command): Update.
6630         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
6631         Update.
6632         * objfiles.h (class all_objfiles): Remove.
6633         * objfiles.c (have_partial_symbols, have_full_symbols)
6634         (have_minimal_symbols, qsort_cmp, update_section_map)
6635         (shared_objfile_contains_address_p)
6636         (default_iterate_over_objfiles_in_search_order): Update.
6637         * objc-lang.c (info_selectors_command, info_classes_command)
6638         (find_methods): Update.
6639         * minsyms.c (find_solib_trampoline_target): Update.
6640         * maint.c (maintenance_info_sections)
6641         (maintenance_translate_address, count_symtabs_and_blocks):
6642         Update.
6643         * main.c (captured_main_1): Update.
6644         * linux-thread-db.c (try_thread_db_load_from_pdir)
6645         (has_libpthread): Update.
6646         * linespec.c (iterate_over_all_matching_symtabs)
6647         (search_minsyms_for_name): Update.
6648         * jit.c (jit_find_objf_with_entry_addr): Update.
6649         * hppa-tdep.c (find_unwind_entry)
6650         (hppa_lookup_stub_minimal_symbol): Update.
6651         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
6652         Update.
6653         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6654         (elf_gnu_ifunc_resolve_by_got): Update.
6655         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
6656         * dwarf-index-write.c (save_gdb_index_command): Update.
6657         * cp-support.c (add_symbol_overload_list_qualified): Update.
6658         * breakpoint.c (create_overlay_event_breakpoint)
6659         (create_longjmp_master_breakpoint)
6660         (create_std_terminate_master_breakpoint)
6661         (create_exception_master_breakpoint): Update.
6662         * blockframe.c (find_pc_partial_function): Update.
6663         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
6664         (ada_collect_symbol_completion_matches)
6665         (ada_add_global_exceptions): Update.
6666
6667 2019-01-17  Tom Tromey  <tom@tromey.com>
6668
6669         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
6670         declare VEC.
6671         (solib_target_parse_libraries): Change return type.
6672         (library_list_start_segment, library_list_start_section)
6673         (library_list_end_library, library_list_start_library); Update.
6674         (solib_target_free_library_list): Remove.
6675         (solib_target_parse_libraries): Remove cleanup.  Change return
6676         type.
6677         (solib_target_current_sos): Update.
6678
6679 2019-01-17  Tom Tromey  <tromey@bapiya>
6680
6681         * valprint.c: Replace "the the" with "the".
6682         * symtab.c: Replace "the the" with "the".
6683         * solib.c: Replace "the the" with "the".
6684         * solib-dsbt.c: Replace "the the" with "the".
6685         * linespec.c: Replace "the the" with "the".
6686         * dwarf2loc.h: Replace "the the" with "the".
6687         * amd64-windows-tdep.c: Replace "the the" with "the".
6688         * aarch64-tdep.c: Replace "the the" with "the".
6689
6690 2019-01-16  Keith Seitz  <keiths@redhat.com>
6691
6692         PR gdb/23773
6693         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
6694         <builder>: Rename to ..
6695         <m_builder>: ... this and make private.
6696         (dwarf2_cu::get_builder): New method.  Change all users of
6697         `builder' to use this method.
6698         (dwarf2_start_symtab): Move to ...
6699         (dwarf2_cu::start_symtab): ... here.  Update all callers
6700         (setup_type_unit_groups): Move to ...
6701         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
6702         callers.
6703         (dwarf2_cu::reset_builder): New method.
6704         (process_full_compunit, process_full_type_unit): Use
6705         dwarf2_cu::reset_builder.
6706         (follow_die_offset): Record the ancestor CU if it is different
6707         from the followed DIE's CU.
6708         (follow_die_sig_1): Likewise.
6709
6710 2019-01-15  Tom Tromey  <tom@tromey.com>
6711
6712         * remote.c (class remote_state) <buf>: Now a char_vector.
6713         <buf_size>: Remove.
6714         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
6715         parameter.
6716         (remote_target::getpkt_or_notif_sane_1)
6717         (remote_target::getpkt_sane)
6718         (remote_target::getpkt_or_notif_sane): Likewise.
6719         (class remote_target) <putpkt>: New overload.
6720         (remote_target::read_frame): Change type of "buf_p".  Remove
6721         sizeof_p parameter.
6722         (packet_ok): New overload.
6723         (packet_check_result): New overload.
6724         Update all uses.
6725
6726 2019-01-14  Tom Tromey  <tom@tromey.com>
6727
6728         * remote-notif.c (handle_notification, remote_notif_ack)
6729         (remote_notif_parse): Make "buf" const.
6730         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
6731         const.
6732         (remote_notif_parse, remote_notif_ack, handle_notification):
6733         Likewise.
6734         * remote.c (remote_notif_stop_parse): Make "buf" const.
6735         (remote_target::remote_parse_stop_reply): Make "buf" const.
6736         (remote_notif_stop_ack): Make "buf" const.
6737
6738 2019-01-14  Tom Tromey  <tom@tromey.com>
6739
6740         * remote.c (remote_console_output): Make parameter const.
6741
6742 2019-01-14  Tom Tromey  <tom@tromey.com>
6743
6744         * target-debug.h (target_debug_print_signals): Constify.
6745         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
6746         * procfs.c (procfs_target::pass_signals): Update.
6747         * linux-nat.c (linux_nat_target::pass_signals): Update.
6748         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
6749         * target-delegates.c: Rebuild.
6750         * remote.c (remote_target::program_signals): Update.
6751         (remote_target::pass_signals): Update.
6752         * target.c (target_pass_signals): Constify argument.
6753         (target_program_signals): Likewise.
6754         * target.h (struct target_ops) <pass_signals, program_signals>:
6755         Constify argument.
6756         (target_pass_signals, target_program_signals): Constify argument.
6757
6758 2019-01-14  Tom Tromey  <tom@tromey.com>
6759
6760         PR tui/28819:
6761         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
6762
6763 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6764
6765         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
6766         field.
6767         * rs6000-tdep.c: Include reggroups.h.
6768         (IS_V_ALIAS_PSEUDOREG): Define.
6769         (rs6000_register_name): Return names for the "vX" aliases.
6770         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
6771         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
6772         aliases.  Call default_register_reggroup_p for all other
6773         pseudo-registers.
6774         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
6775         New functions.
6776         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
6777         Handle "vX" aliases.
6778         (v_alias_pseudo_register_collect): New function.
6779         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
6780         (rs6000_gdbarch_init): Initialize "vX" aliases as
6781         pseudo-registers.  Restore registration of
6782         rs6000_pseudo_register_reggroup_p with
6783         set_tdesc_pseudo_register_reggroup_p.
6784
6785 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
6786
6787         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
6788         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
6789         set_gdbarch_num_pseudo_regs.
6790
6791 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6792
6793         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
6794         Remove arg prefixname, add do_set and do_show.
6795         Add member functions set_list and show_list.
6796         * cli/cli-style.c (class cli_style_option): Update accordingly.
6797         (style_set_list): Move to file scope.
6798         (style_show_list): Likewise.
6799         (set_style): Call help_list.
6800         (show_style): Call cmd_show_list.
6801         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
6802         Update to use the new macro.
6803
6804 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
6805
6806         * ada-lang.c (_initialize_ada_language): Expand the help text
6807         for the "catch exception" command.
6808
6809 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6810
6811         * symtab.c (matching_obj_sections): Initialize obj,
6812         declare it closer to its usage.
6813
6814 2019-01-10  Tom Tromey  <tom@tromey.com>
6815
6816         * thread-iter.h (inf_threads_iterator): Use next_iterator.
6817         (basic_inf_threads_range): Remove.
6818         (inf_threads_range, inf_non_exited_threads_range)
6819         (safe_inf_threads_range): Use next_adapter.
6820
6821 2019-01-10  Keith Seitz  <keiths@redhat.com>
6822
6823         PR gdb/23712
6824         PR symtab/23010
6825         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
6826         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
6827
6828 2019-01-10  Keith Seitz  <keiths@redhat.com>
6829
6830         PR gdb/23712
6831         PR symtab/23010
6832         * dictionary.c (pending_to_vector): Remove.
6833         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6834         Remove _1 suffix, replacing functions of the same name.  Update
6835         all callers.
6836         (dict_create_hashed, dict_create_hashed_expandable)
6837         (dict_create_linear, dict_create_linear_expandable, dict_free)
6838         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
6839         Make functions static.
6840
6841 2019-01-10  Keith Seitz  <keiths@redhat.com>
6842
6843         PR gdb/23712
6844         PR symtab/23010
6845         * dictionary.h (struct dictionary): Replace declaration with
6846         multidictionary.
6847         (dict_create_hashed, dict_create_hashed_expandable)
6848         (dict_create_linear, dict_create_linear_expandable)
6849         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
6850         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
6851         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
6852         taking multidictionary argument.
6853         [ALL_DICT_SYMBOLS]: Update for multidictionary.
6854         * block.h (struct block) <dict>: Change to multidictionary
6855         and rename `multidict'.
6856         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
6857         symmisc.c: Update all dictionary references to multidictionary.
6858
6859 2019-01-10  Keith Seitz  <keiths@redhat.com>
6860
6861         PR gdb/23712
6862         PR symtab/23010
6863         * dictionary.c: Include unordered_map.
6864         (pending_to_vector): New function.
6865         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6866         Rewrite the non-"_1" functions to take vector instead
6867         of linked list.
6868         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
6869         "new" _1 versions of the same name.
6870         (multidictionary): Define.
6871         (std::hash<enum language): New definition.
6872         (collate_pending_symbols_by_language, mdict_create_hashed)
6873         (mdict_create_hashed_expandable, mdict_create_linear)
6874         (mdict_create_linear_expandable, mdict_free)
6875         (find_language_dictionary, create_new_language_dictionary)
6876         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
6877         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
6878         (mdict_size, mdict_empty): New functions.
6879         * dictionary.h (mdict_iterator): Define.
6880
6881 2019-01-10  Pedro Alves  <palves@redhat.com>
6882
6883         * breakpoint.c (read_uploaded_action)
6884         (create_tracepoint_from_upload): Adjust to use
6885         gdb::unique_xmalloc_ptr.
6886         * ctf.c (ctf_write_uploaded_tp):
6887         (SET_ARRAY_FIELD): Use emplace_back.
6888         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
6889         * tracefile-tfile.c (tfile_write_uploaded_tp):
6890         * tracepoint.c (parse_tracepoint_definition): Adjust to use
6891         gdb::unique_xmalloc_ptr.
6892         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
6893         at_string, cond_string, cmd_strings>: Replace char pointers
6894         with gdb::unique_xmalloc_ptr.
6895
6896 2019-01-10  Pedro Alves  <palves@redhat.com>
6897
6898         * solib-target.c (library_list_start_library): Don't xstrdup name.
6899
6900 2019-01-10  Pedro Alves  <palves@redhat.com>
6901
6902         * mdebugread.c (parse_partial_symbols): Use
6903         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
6904
6905 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6906
6907         * linux-fork.c (scoped_switch_fork_info)
6908         <~scoped_switch_fork_info>: Fix incorrect variable name.
6909
6910 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6911
6912         * linux-fork.c (scoped_switch_fork_info)
6913         <scoped_switch_fork_info>: Make explicit.
6914         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
6915
6916 2019-01-10  Tom Tromey  <tom@tromey.com>
6917
6918         * objfiles.h (objfile::reset_psymtabs): Update.
6919         * objfiles.c (objfile::objfile): Update.
6920         * psymtab.h (psymtab_storage::obstack): Update.
6921         (psymtab_storage::m_obstack): Use gdb::optional.
6922         (class psymtab_storage): Update comment.  Remove objfile
6923         parameter.
6924         * psymtab.c (psymtab_storage::psymtab_storage): Update.
6925
6926 2019-01-10  Tom Tromey  <tom@tromey.com>
6927
6928         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
6929         <free_psymtabs>: Now private.
6930         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
6931         (allocate_psymtab): Use new method.
6932
6933 2019-01-10  Tom Tromey  <tom@tromey.com>
6934
6935         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
6936         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
6937         * mdebugread.c (parse_partial_symbols): Use
6938         allocate_dependencies.
6939         * dwarf2read.c (dwarf2_create_include_psymtab): Use
6940         allocate_dependencies.
6941         (process_psymtab_comp_unit_reader)
6942         (build_type_psymtab_dependencies): Likewise.
6943         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
6944
6945 2019-01-10  Tom Tromey  <tom@tromey.com>
6946
6947         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
6948         PSYMBOL_SET_LANGUAGE.
6949         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
6950
6951 2019-01-10  Tom Tromey  <tom@tromey.com>
6952
6953         * psymtab.h (psymtab_storage::obstack): New method.
6954         <m_obstack>: Rename from obstack; now private.
6955         * psymtab.c (psymtab_storage): Update.
6956         * dwarf2read.c (create_addrmap_from_index)
6957         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
6958         Update.
6959
6960 2019-01-10  Tom Tromey  <tom@tromey.com>
6961
6962         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
6963         * objfiles.h (objfile::reset_psymtabs): New method.
6964
6965 2019-01-10  Tom Tromey  <tom@tromey.com>
6966
6967         * symmisc.c (print_symbol_bcache_statistics): Update.
6968         (print_objfile_statistics): Update.
6969         * symfile.c (reread_symbols): Update.
6970         * psymtab.h (class psymtab_storage): New.
6971         * psymtab.c (psymtab_storage): New constructor.
6972         (~psymtab_storage): New destructor.
6973         (require_partial_symbols): Update.
6974         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
6975         (find_pc_sect_psymtab, find_pc_sect_psymbol)
6976         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
6977         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
6978         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
6979         (start_psymtab_common, end_psymtab_common)
6980         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
6981         (allocate_psymtab): Update.
6982         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
6983         Update.
6984         (dump_psymtab_addrmap, maintenance_print_psymbols)
6985         (maintenance_check_psymtabs): Update.
6986         (class objfile_psymtabs): Move to objfiles.h.
6987         * psympriv.h (discard_psymtab): Now inline.
6988         (psymtab_discarder::psymtab_discarder): Update.
6989         (psymtab_discarder::~psymtab_discarder): Update.
6990         (ALL_OBJFILE_PSYMTABS): Rewrite.
6991         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6992         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6993         Remove fields.
6994         <partial_symtabs>: New field.
6995         (class objfile_psymtabs): Move from psymtab.h.  Update.
6996         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6997         psymbol_cache.
6998         (objfile::~objfile): Don't destroy psymbol_cache.
6999         * mdebugread.c (parse_partial_symbols): Update.
7000         * dwarf2read.c (create_addrmap_from_index)
7001         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7002         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
7003         (add_partial_subprogram, dwarf2_ranges_read): Update.
7004         * dwarf-index-write.c (write_address_map)
7005         (write_one_signatured_type, recursively_write_psymbols)
7006         (class debug_names, class debug_names, write_psymtabs_to_index):
7007         Update.
7008
7009 2019-01-10  Tom Tromey  <tom@tromey.com>
7010
7011         * symtab.h (SYMBOL_SET_NAMES): Update.
7012         (symbol_set_names): Update.
7013         (MSYMBOL_SET_NAMES): Update.
7014         * symtab.c (symbol_set_names): Change argument to be an
7015         objfile_per_bfd_storage.
7016         * psymtab.c (add_psymbol_to_bcache): Update.
7017         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
7018
7019 2019-01-10  Tom Tromey  <tom@tromey.com>
7020
7021         * symtab.c (create_demangled_names_hash): Change argument to be an
7022         objfile_per_bfd_storage.
7023         (symbol_set_names): Update.
7024
7025 2019-01-10  Tom Tromey  <tom@tromey.com>
7026
7027         * xcoffread.c (xcoff_initial_scan): Unconditionally call
7028         init_psymbol_list.
7029         * psymtab.c (init_psymbol_list): Do nothing if already called.
7030         * psympriv.h (init_psymbol_list): Add comment.
7031         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
7032         init_psymbol_list.
7033         * dbxread.c (dbx_symfile_read): Unconditionally call
7034         init_psymbol_list.
7035
7036 2019-01-10  Tom Tromey  <tom@tromey.com>
7037
7038         * xcoffread.c (scan_xcoff_symtab): Update.
7039         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
7040         "where".
7041         * mdebugread.c (parse_partial_symbols)
7042         (handle_psymbol_enumerators): Update.
7043         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7044         * dbxread.c (read_dbx_symtab): Update.
7045         * psympriv.h (psymbol_placement): New enum.
7046         (add_psymbol_to_list): Update.
7047
7048 2019-01-10  Tom Tromey  <tom@tromey.com>
7049
7050         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7051         static_psymbols parameters.
7052         (scan_xcoff_symtab): Update.
7053         * psymtab.c (start_psymtab_common): Remove global_psymbols and
7054         static_psymbols parameters.
7055         * psympriv.h (start_psymtab_common): Update.
7056         * mdebugread.c (parse_partial_symbols): Update.
7057         * dwarf2read.c (create_partial_symtab): Update.
7058         * dbxread.c (read_dbx_symtab): Update.
7059         (start_psymtab): Remove global_psymbols and static_psymbols
7060         parameters.
7061
7062 2019-01-10  Tom Tromey  <tom@tromey.com>
7063
7064         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
7065         * psymtab.c (allocate_psymtab): Add comment.
7066         * psympriv.h (allocate_psymtab): Add comment.
7067         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
7068         initializations.
7069         * dbxread.c (dbx_end_psymtab): Remove some initializations.
7070
7071 2019-01-10  Tom Tromey  <tom@tromey.com>
7072
7073         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7074         Don't declare.
7075         * mipsread.c: Include mdebugread.h.
7076         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7077         Declare.
7078         * elfread.c: Include mdebugread.h.
7079
7080 2019-01-09  Tom Tromey  <tom@tromey.com>
7081
7082         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7083         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7084         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7085         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7086         (psym_lookup_symbol, psym_find_last_source_symtab)
7087         (psym_forget_cached_source_info, psym_print_stats)
7088         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7089         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7090         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7091         (psym_find_compunit_symtab_by_address)
7092         (maintenance_print_psymbols, maintenance_info_psymtabs)
7093         (maintenance_check_psymtabs): Use ranged for.
7094         * psymtab.h (class objfile_psymtabs): New.
7095         (require_partial_symbols): Return objfile_psymtabs.
7096         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7097
7098 2019-01-09  Tom Tromey  <tom@tromey.com>
7099
7100         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7101         (find_pc_mapped_section, list_overlays_command)
7102         (map_overlay_command, unmap_overlay_command)
7103         (simple_overlay_update): Use all_objfiles.
7104         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7105         * printcmd.c (info_symbol_command): Use all_objfiles.
7106         * objfiles.h (ALL_OBJSECTIONS): Remove.
7107         * maint.c (maintenance_translate_address): Use all_objfiles.
7108         * gcore.c (gcore_create_callback): Use all_objfiles.
7109         (objfile_find_memory_regions): Likewise.
7110
7111 2019-01-09  Tom Tromey  <tom@tromey.com>
7112
7113         * symtab.c (find_line_symtab, info_sources_command)
7114         (make_source_files_completion_list): Use objfile_compunits.
7115         * source.c (select_source_symtab): Use objfile_compunits.
7116         * objfiles.h (struct objfile): Update comment.
7117         (ALL_OBJFILES): Remove.
7118         (ALL_FILETABS): Remove.
7119         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7120         objfile_compunits.
7121
7122 2019-01-09  Tom Tromey  <tom@tromey.com>
7123
7124         * symmisc.c (print_objfile_statistics, dump_objfile)
7125         (maintenance_print_symbols): Use compunit_filetabs.
7126         * source.c (forget_cached_source_info_for_objfile): Use
7127         compunit_filetabs.
7128         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7129         (ALL_FILETABS): Use compunit_filetabs.
7130         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7131         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7132
7133 2019-01-09  Tom Tromey  <tom@tromey.com>
7134
7135         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7136         (compunit_filetabs): New.
7137         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7138         compunit_filetabs.
7139         (info_sources_command, make_source_files_completion_list): Remove
7140         declaration.
7141         * symmisc.c (print_objfile_statistics, dump_objfile)
7142         (maintenance_print_symbols): Remove declaration.
7143         (maintenance_info_symtabs): Use compunit_filetabs.
7144         (maintenance_info_line_tables): Likewise.
7145         * source.c (select_source_symtab): Change local variable name.
7146         (forget_cached_source_info_for_objfile): Remove declaration.
7147         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7148         * objfiles.c (objfile_relocate1): Remove declaration.
7149         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7150         declaration.
7151         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7152         * coffread.c (coff_symtab_read): Remove declaration.
7153         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7154         compunit_filetabs.
7155
7156 2019-01-09  Tom Tromey  <tom@tromey.com>
7157
7158         * symtab.c (lookup_objfile_from_block)
7159         (find_pc_sect_compunit_symtab, search_symbols)
7160         (default_collect_symbol_completion_matches_break_on): Use
7161         objfile_compunits.
7162         * objfiles.h (ALL_COMPUNITS): Remove.
7163         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7164         * cp-support.c (add_symbol_overload_list_qualified): Use
7165         objfile_compunits.
7166         * ada-lang.c (ada_collect_symbol_completion_matches)
7167         (ada_add_global_exceptions): Use objfile_compunits.
7168
7169 2019-01-09  Tom Tromey  <tom@tromey.com>
7170
7171         * source.c (select_source_symtab)
7172         (forget_cached_source_info_for_objfile): Remove declaration.
7173         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7174         declaration.
7175         * maint.c (count_symtabs_and_blocks): Remove declaration.
7176         * cp-support.c (add_symbol_overload_list_qualified): Remove
7177         declaration.
7178         * coffread.c (coff_symtab_read): Remove declaration.
7179         * symtab.c (lookup_symbol_in_objfile_symtabs)
7180         (basic_lookup_transparent_type_1): Use objfile_compunits.
7181         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7182         (info_sources_command, search_symbols)
7183         (default_collect_symbol_completion_matches_break_on)
7184         (make_source_files_completion_list): Remove declaration.
7185         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7186         (ada_collect_symbol_completion_matches)
7187         (ada_add_global_exceptions): Remove declaration.
7188         * linespec.c (iterate_over_all_matching_symtabs): Use
7189         objfile_compunits.
7190         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7191         (class objfile_compunits): New.
7192         (ALL_COMPUNITS): Use objfile_compunits.
7193         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
7194         (maintenance_check_symtabs, maintenance_info_line_tables): Use
7195         objfile_compunits.
7196         * objfiles.c (objfile_relocate1): Use objfile_compunits.
7197
7198 2019-01-09  Tom Tromey  <tom@tromey.com>
7199
7200         * symtab.c (search_symbols)
7201         (default_collect_symbol_completion_matches_break_on): Use
7202         objfile_msymbols.
7203         * ada-lang.c (ada_lookup_simple_minsym)
7204         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
7205         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
7206         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
7207         objfile_msymbols.
7208         * coffread.c (coff_symfile_read): Use objfile_msymbols.
7209         * symmisc.c (dump_msymbols): Use objfile_msymbols.
7210         * objc-lang.c (find_methods): Use objfile_msymbols.
7211         (info_selectors_command, info_classes_command): Likewise.
7212         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7213         * objfiles.h (class objfile_msymbols): New.
7214         (ALL_OBJFILE_MSYMBOLS): Remove.
7215         (ALL_MSYMBOLS): Remove.
7216
7217 2019-01-09  Tom Tromey  <tom@tromey.com>
7218
7219         * common/next-iterator.h (next_adapter): Add Iterator template
7220         parameter.
7221         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
7222         (class all_objfiles_safe): New.
7223         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
7224         * objfiles.c (put_objfile_before): Update comment.
7225         (add_separate_debug_objfile): Likewise.
7226         (free_all_objfiles): Use all_objfiles_safe.
7227         (objfile_purge_solibs): Likewise.
7228
7229 2019-01-09  Tom Tromey  <tom@tromey.com>
7230
7231         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7232         (expand_symtab_containing_pc, lookup_static_symbol)
7233         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
7234         (find_symbol_at_address, find_line_symtab, find_main_name): Use
7235         all_objfiles.
7236         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
7237         * breakpoint.c (create_overlay_event_breakpoint)
7238         (create_longjmp_master_breakpoint)
7239         (create_std_terminate_master_breakpoint)
7240         (create_exception_master_breakpoint): Use all_objfiles.
7241         * linux-thread-db.c (try_thread_db_load_from_pdir)
7242         (has_libpthread): Use all_objfiles.
7243         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
7244         * linespec.c (iterate_over_all_matching_symtabs)
7245         (search_minsyms_for_name): Use all_objfiles.
7246         * maint.c (maintenance_info_sections): Use all_objfiles.
7247         * main.c (captured_main_1): Use all_objfiles.
7248         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7249         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
7250         * guile/scm-pretty-print.c
7251         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
7252         * solib-spu.c (append_ocl_sos): Use all_objfiles.
7253         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
7254         (maintenance_print_msymbols): Use all_objfiles.
7255         * source.c (select_source_symtab): Use all_objfiles.
7256         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
7257         * symfile.c (remove_symbol_file_command)
7258         (expand_symtabs_matching, map_symbol_filenames): Use
7259         all_objfiles.
7260         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
7261         all_objfiles.
7262         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
7263         * objc-lang.c (find_methods): Use all_objfiles.
7264         * objfiles.c (have_partial_symbols, have_full_symbols)
7265         (have_minimal_symbols, qsort_cmp)
7266         (default_iterate_over_objfiles_in_search_order): Use
7267         all_objfiles.
7268         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
7269         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
7270         (maintenance_check_psymtabs): Use all_objfiles.
7271         (ALL_PSYMTABS): Remove.
7272         * compile/compile-object-run.c (do_module_cleanup): Use
7273         all_objfiles.
7274         * blockframe.c (find_pc_partial_function): Use all_objfiles.
7275         * cp-support.c (add_symbol_overload_list_qualified): Use
7276         all_objfiles.
7277         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7278         Use all_objfiles.
7279         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
7280         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
7281         all_objfiles.
7282         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7283         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
7284         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7285         Uses all_objfiles.
7286         * solib.c (solib_read_symbols): Use all_objfiles
7287
7288 2019-01-09  Tom Tromey  <tom@tromey.com>
7289
7290         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7291         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7292         all_objfiles.
7293         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7294         * symmisc.c (print_symbol_bcache_statistics)
7295         (print_objfile_statistics, maintenance_print_objfiles)
7296         (maintenance_info_symtabs, maintenance_check_symtabs)
7297         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7298         all_objfiles.
7299         * source.c (forget_cached_source_info): Use all_objfiles.
7300         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7301         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7302         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7303         * objfiles.c (update_section_map): Use all_objfiles.
7304         (shared_objfile_contains_address_p): Likewise.
7305         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7306         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7307
7308 2019-01-09  Tom Tromey  <tom@tromey.com>
7309
7310         * common/next-iterator.h: New file.
7311         * objfiles.h (class all_objfiles): New.
7312         (struct objfile_iterator): New.
7313
7314 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7315
7316         * NEWS: Move the description of the changed "frame", "select-frame",
7317          and "info frame" commands to the Changed commands section.
7318
7319 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7320
7321         * gdbtypes.c (check_stub_method_group): Remove handling of old
7322         mangling schemes.
7323         * linespec.c (find_methods): Likewise.
7324         * stabsread.c (read_member_functions): Likewise.
7325         * valops.c (search_struct_method): Likewise.
7326         (value_struct_elt_for_reference): Likewise.
7327         * NEWS: Mention this change.
7328
7329 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7330
7331         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7332         print_source_lines.
7333         * source.c (print_source_lines_base): Update line number check.
7334         (print_source_lines): New function.
7335         (source_lines_range::source_lines_range): New function.
7336         * source.h (class source_lines_range): New class.
7337         (print_source_lines): New declaration.
7338
7339 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7340
7341         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7342
7343 2019-01-08  Tom Tromey  <tom@tromey.com>
7344             Simon Marchi  <simon.marchi@ericsson.com>
7345
7346         PR gdb/24060
7347         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7348         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7349         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7350         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7351         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7352         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7353
7354 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7355
7356         * source.c (select_source_symtab): Move header comment to
7357         declaration in source.h.
7358         (forget_cached_source_info_for_objfile): Likewise.
7359         (forget_cached_source_info): Likewise.
7360         (identify_source_line): Likewise.
7361         * source.h (identify_source_line): Move declaration from symtab.h
7362         and add comment from source.c
7363         (print_source_lines): Likewise.
7364         (forget_cached_source_info_for_objfile): Likewise.
7365         (forget_cached_source_info): Likewise.
7366         (select_source_symtab): Likewise.
7367         (enum print_source_lines_flag): Move definition from symtab.h.
7368         * symtab.h (identify_source_line): Move declaration to source.h.
7369         (print_source_lines): Likewise.
7370         (forget_cached_source_info_for_objfile): Likewise.
7371         (forget_cached_source_info): Likewise.
7372         (select_source_symtab): Likewise.
7373         (enum print_source_lines_flag): Move definition to source.h.
7374         * tui/tui-hooks.c: Add 'source.h' include.
7375
7376 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7377
7378         * source.c (print_source_lines_base): Handle requests to print
7379         reverse line number sequences, and guard against empty lines
7380         string.
7381
7382 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7383
7384         * source.c (print_source_lines_base): Fix skip of '\r' if next
7385         character is '\n'.
7386
7387 2019-01-06  Tom Tromey  <tom@tromey.com>
7388
7389         * c-exp.y (struct c_parse_state) <macro_original_text,
7390         expansion_obstack>: New member.
7391         (macro_original_text, expansion_obstack): Remove globals.
7392         (scan_macro_expansion, scanning_macro_expansion)
7393         (finished_macro_expansion): Update.
7394         (scan_macro_cleanup): Remove.
7395         (yylex, c_parse): Update.
7396
7397 2019-01-06  Tom Tromey  <tom@tromey.com>
7398
7399         * c-exp.y (struct c_parse_state) <strings>: New member.
7400         (operator_stoken): Update.
7401
7402 2019-01-06  Tom Tromey  <tom@tromey.com>
7403
7404         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
7405         (union type_stack_elt) <typelist_val>: Now a pointer to
7406         std::vector.
7407         (type_stack_cleanup): Don't declare.
7408         (push_typelist): Update.
7409         * parse.c (pop_typelist): Return a std::vector.
7410         (push_typelist): Take a std::vector.
7411         (follow_types): Update.  Do not free args.
7412         (type_stack_cleanup): Remove.
7413         * c-exp.y (struct c_parse_state): New.
7414         (cpstate): New global.
7415         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
7416         (nonempty_typelist): Update.
7417         (func_mod): Create a new vector.
7418         (c_parse): Create a c_parse_state.
7419         (check_parameter_typelist): Do not delete params.
7420         (function_method): Update.  Do not delete type_list.
7421
7422 2019-01-06  Tom Tromey  <tom@tromey.com>
7423
7424         PR gdb/28155:
7425         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
7426         check_typedef.
7427         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
7428         (print_return_value): Likewise.
7429
7430 2019-01-05  Tom Tromey  <tom@tromey.com>
7431
7432         * contrib/cleanup_check.py: Remove.
7433         * contrib/gcc-with-excheck: Remove.
7434         * contrib/exsummary.py: Remove.
7435         * contrib/excheck.py: Remove.
7436
7437 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7438
7439         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7440         NULL. Initialize tpprev to NULL instead of assigning it
7441         to NULL on the next statement.
7442         * windows-nat.c (windows_delete_thread): Remove check for
7443         main_thread_id before printing thread exit notifications.
7444         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
7445         Remove thread ID check against main_thread_id.
7446         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
7447         windows_delete_thread.
7448         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
7449
7450 2019-01-04  Tom Tromey  <tom@tromey.com>
7451
7452         * compile/compile.c (_initialize_compile): Use upper case for
7453         metasyntactic variables.
7454         * symmisc.c (_initialize_symmisc): Use upper case for
7455         metasyntactic variables.
7456         * psymtab.c (_initialize_psymtab): Use upper case for
7457         metasyntactic variables.
7458         * demangle.c (demangle_command): Use upper case for metasyntactic
7459         variables.
7460         (_initialize_demangler): Likewise.
7461         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
7462         variables.
7463
7464 2019-01-03  Tom Tromey  <tom@tromey.com>
7465
7466         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
7467
7468 2019-01-03  Tom Tromey  <tom@tromey.com>
7469
7470         * python/py-symtab.c (salpy_str): Update.
7471         (struct salpy_sal_object) <symtab>: Now a PyObject.
7472         (salpy_dealloc): Update.
7473         (del_objfile_sal): Use gdbpy_ref.
7474
7475 2019-01-03  Tom Tromey  <tom@tromey.com>
7476
7477         * python/py-type.c (convert_field): Use new_reference.  Return
7478         gdbpy_ref.
7479         (make_fielditem): Return gdbpy_ref.
7480         (typy_fields): Update.
7481         (typy_getitem): Update.
7482         (field_name): Return gdbpy_ref.  Use new_reference.
7483         (typy_iterator_iternext): Update.
7484
7485 2019-01-03  Tom Tromey  <tom@tromey.com>
7486
7487         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
7488
7489 2019-01-03  Tom Tromey  <tom@tromey.com>
7490
7491         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
7492         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
7493         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
7494         (pspy_set_frame_filters, pspy_set_frame_unwinders)
7495         (pspy_set_type_printers): Likewise.
7496         * python/py-function.c (fnpy_init): Use gdbpy_ref.
7497         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
7498         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
7499         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
7500         (objfpy_set_type_printers): Likewise.
7501
7502 2019-01-03  Tom Tromey  <tom@tromey.com>
7503
7504         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
7505         (gdbpy_print_stack): Use gdbpy_err_fetch.
7506         * python/python-internal.h (class gdbpy_err_fetch): New class.
7507         (class gdbpy_enter) <m_error_type, m_error_value,
7508         m_error_traceback>: Remove.
7509         <m_error>: New member.
7510         (gdbpy_exception_to_string): Don't declare.
7511         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
7512         * python/py-value.c (convert_value_from_python): Use
7513         gdbpy_err_fetch.
7514         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
7515         gdbpy_exception_to_string.
7516         (gdbpy_handle_exception): Use gdbpy_err_fetch.
7517         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
7518         gdbpy_err_fetch.
7519
7520 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7521
7522         * linux-nat.c (delete_lwp_cleanup): Delete.
7523         (struct lwp_deleter): New struct.
7524         (lwp_info_up): New typedef.
7525         (linux_nat_target::follow_fork): Delete cleanup, and make use of
7526         lwp_info_up.
7527
7528 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7529
7530         * linux-fork.c (class scoped_switch_fork_info): New class.
7531         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
7532
7533 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7534
7535         * valops.c (find_overload_match): Remove use of null_cleanup, and
7536         calls to do_cleanups.
7537
7538 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7539
7540         * compile/compile-cplus-types.c
7541         (compile_cplus_instance::decl_name): Handle changes to
7542         cp_func_name.
7543         * cp-support.c (cp_func_name): Update header comment, update
7544         return type.
7545         * cp-support.h (cp_func_name): Update return type in declaration.
7546         * valops.c (find_overload_match): Move temp_func local to top
7547         level of function and change its type.  Use temp_func to hold and
7548         delete temporary string obtained from cp_func_name.
7549
7550 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7551
7552         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
7553         gdb::char_vector, remove cleanup, and update uses of `msg`.
7554
7555 2019-01-03  Jim Wilson  <jimw@sifive.com>
7556
7557         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
7558
7559 2019-01-02  Tom Tromey  <tom@tromey.com>
7560
7561         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
7562         (tdesc_parse_xml): Remove cleanups.
7563         * target-descriptions.h (make_cleanup_free_target_description):
7564         Don't declare.
7565         (target_desc_deleter): New struct.
7566         (target_desc_up): New typedef.
7567         * target-descriptions.c (target_desc_deleter::operator()): Rename
7568         from free_target_description.
7569         (make_cleanup_free_target_description): Remove.
7570
7571 2019-01-02  Tom Tromey  <tom@tromey.com>
7572
7573         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
7574         constructor, destructor.
7575         (linespec_parser): Remove typedef.
7576         (~linespec_parser): Rename from linespec_parser_delete.
7577         (linespec_lex_to_end, linespec_complete_label)
7578         (linespec_complete): Update.
7579         (decode_line_full): Remove cleanups.
7580         (decode_line_1): Update.
7581
7582 2019-01-02  Tom Tromey  <tom@tromey.com>
7583
7584         * python/python-internal.h (inferior_to_inferior_object): Change
7585         return type.
7586         * python/py-exitedevent.c (create_exited_event_object): Update.
7587         * python/py-inferior.c (inferior_to_inferior_object): Return
7588         gdbpy_ref.
7589         (python_new_inferior, python_inferior_deleted)
7590         (thread_to_thread_object, delete_thread_object)
7591         (build_inferior_list, gdbpy_selected_inferior): Update.
7592         * python/py-infthread.c (create_thread_object): Update.  Also fail
7593         if inferior_to_inferior_object fails.
7594
7595 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
7596
7597         * inferior.h (class inferior) <displaced_step_state>: New field.
7598         * infrun.h (struct displaced_step_state): Move here from
7599         infrun.c.  Initialize fields, add constructor.
7600         <inf>: Remove field.
7601         <reset>: New method.
7602         * infrun.c (struct displaced_step_inferior_state): Move to
7603         infrun.h.
7604         (displaced_step_inferior_states): Remove.
7605         (get_displaced_stepping_state): Adust.
7606         (displaced_step_in_progress_any_inferior): Adjust.
7607         (displaced_step_in_progress_thread): Adjust.
7608         (displaced_step_in_progress): Adjust.
7609         (add_displaced_stepping_state): Remove.
7610         (get_displaced_step_closure_by_addr): Adjust.
7611         (remove_displaced_stepping_state): Remove.
7612         (infrun_inferior_exit): Call displaced_step_state.reset.
7613         (use_displaced_stepping): Don't check for NULL.
7614         (displaced_step_prepare_throw): Call
7615         get_displaced_stepping_state.
7616         (displaced_step_fixup): Don't check for NULL.
7617         (prepare_for_detach): Don't check for NULL.
7618
7619 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7620
7621         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
7622          in case of call that did not complete.
7623
7624 2019-01-02  Andrey Utkin  <autkin@undo.io>
7625
7626         * symfile.c (find_separate_debug_file): Fix search of debug files for
7627         remote debuggee.
7628
7629 2019-01-02  Tom Tromey  <tom@tromey.com>
7630
7631         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
7632         indentation.
7633         * python/py-frame.c (frapy_older): Remove cast.
7634         (frapy_newer): Likewise.
7635         * python/py-breakpoint.c (local_setattro): Remove cast.
7636         * python/py-arch.c (archpy_name): Remove local variable.
7637         * python/py-type.c (gdbpy_lookup_type): Remove cast.
7638
7639 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
7640
7641         * unittests/basic_string_view/element_access/char/empty.cc:
7642         Fix year range in copyright header.
7643
7644 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7645
7646         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
7647         Delete.
7648         <operator==>: Update with for removed field.
7649         <hash>: Likewise.
7650         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
7651         <isa_features>: ...this.
7652         <abi_features>: New field.
7653         (riscv_isa_flen): Update comment.
7654         (riscv_abi_xlen): New declaration.
7655         (riscv_abi_flen): New declaration.
7656         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
7657         isa_features.
7658         (riscv_abi_xlen): New function.
7659         (riscv_isa_flen): Update to get answer from isa_features.
7660         (riscv_abi_flen): New function.
7661         (riscv_has_fp_abi): Update to get answer from abi_features.
7662         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
7663         xlen and flen.
7664         (riscv_call_info) <xlen, flen>: Update comment.
7665         (riscv_call_arg_struct): Remove invalid assertions
7666         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
7667         is removed.
7668         (riscv_gdbarch_init): Gather isa features and abi features
7669         separately, ensure both match on the gdbarch when reusing an old
7670         gdbarch.  Relax an error check to allow 32-bit abi float to run on
7671         a target with 64-bit float hardware.
7672
7673 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7674
7675         * source.c (search_command_helper): Stop reverse search
7676         when line 1 has been searched.
7677
7678 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7679
7680         * record-full.c (record_full_base_target::close): Rewrite
7681         record_full_core_buf_list free logic.
7682
7683 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7684
7685         * break-catch-syscall.c (print_one_catch_syscall): xfree
7686         the last text.
7687
7688 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7689
7690         * top.c (print_gdb_version): Update Copyright year in version
7691         message.
7692
7693 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7694
7695         Update copyright year range in all GDB files.
7696
7697 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
7698
7699         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
7700
7701 For older changes see ChangeLog-2018.
7702 \f
7703 Local Variables:
7704 mode: change-log
7705 left-margin: 8
7706 fill-column: 74
7707 version-control: never
7708 coding: utf-8
7709 End:
7710