82e0819c136dc42702e74c0714b399b5ab437436
[external/binutils.git] / gdb / ChangeLog
1 2019-08-06  Tom Tromey  <tom@tromey.com>
2
3         * stabsread.c (patch_block_stabs, read_one_struct_field)
4         (read_enum_type): Use obstack_strndup.
5         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
6         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
7         * dwarf2read.c (guess_full_die_structure_name)
8         (anonymous_struct_prefix): Use obstack_strndup.
9         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
10         * c-exp.y (yylex): Use obstack_strndup.
11         * ada-exp.y (write_object_renaming, write_ambiguous_var)
12         (write_var_or_type): Use obstack_strndup.
13
14 2019-08-06  Tom Tromey  <tom@tromey.com>
15
16         * symfile.c (reread_symbols): Use obstack_strdup.
17         * stabsread.c (read_type): Use obstack_strdup.
18         * gdb_obstack.h (obstack_strdup): New overload.
19         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
20         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
21         (dwarf2_canonicalize_name): Use obstack_strdup.
22         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
23         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
24         Use obstack_strdup.
25
26 2019-08-06  Tom Tromey  <tom@tromey.com>
27
28         * gdb_obstack.h (obstack_strdup): Define.
29         * gdb_obstack.c (obstack_strdup): Don't define.
30
31 2019-08-06  Tom Tromey  <tom@tromey.com>
32
33         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
34         obstack_strdup.
35         * typeprint.c (typedef_hash_table::find_global_typedef): Use
36         obstack_strdup.
37         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
38         * stabsread.c (common_block_start): Use obstack_strdup.
39         * objfiles.c (set_objfile_main_name, objfile): Use
40         obstack_strdup.
41         * namespace.c (add_using_directive): Use obstack_strdup.
42         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
43         * jit.c (finalize_symtab): Use obstack_strdup.
44         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
45         (guess_partial_die_structure_name, partial_die_info::fixup)
46         (dwarf2_name): Use obstack_strdup.
47         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
48         obstack_strdup.
49         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
50         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
51         obstack_strdup.
52         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
53
54 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
55
56         * unittests/help-doc-selftests.c: New file.
57         * Makefile.in: Add the new file.
58
59 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
60
61         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
62         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
63         the full first line, except when FOR_VALUE_PREFIX.  In this case,
64         the trailing '.' is not output, and the first character is uppercased.
65         (print_help_for_command): Update call to print_doc_line.
66         (print_doc_of_command): Likewise.
67         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
68         * cli/cli-option.c (append_indented_doc): Do not append newline.
69         (build_help_option): Append newline after first appended_indented_doc
70         only if a second call is done.
71         (build_help): Append 2 new lines before each option, except the first
72         one.
73         * compile/compile.c (_initialize_compile): Add new lines after
74         %OPTIONS%, when not at the end of the help.
75         Change help doc or code
76         producing the help doc to respect the invariants.
77         * maint-test-options.c (_initialize_maint_test_options): Likewise.
78         Also removed the new line after 'Options:', as all other commands
79         do not put an empty line between 'Options:' and the first option.
80         * printcmd.c (_initialize_printcmd): Likewise.
81         * stack.c (_initialize_stack): Likewise.
82         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
83         incorrectly telling COMMAND is optional.
84         * ada-lang.c (_initialize_ada_language): Change help doc or code
85         producing the help doc to respect the invariants.
86         * ada-tasks.c (_initialize_ada_tasks): Likewise.
87         * breakpoint.c (_initialize_breakpoint): Likewise.
88         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
89         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
90         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
91         * cli/cli-style.c (cli_style_option::add_setshow_commands,
92         _initialize_cli_style): Likewise.
93         * corelow.c (core_target_info): Likewise.
94         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
95         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
96         * filesystem.c (_initialize_filesystem): Likewise.
97         * frame.c (_initialize_frame): Likewise.
98         * gnu-nat.c (add_task_commands): Likewise.
99         * infcall.c (_initialize_infcall): Likewise.
100         * infcmd.c (_initialize_infcmd): Likewise.
101         * interps.c (_initialize_interpreter): Likewise.
102         * language.c (_initialize_language): Likewise.
103         * linux-fork.c (_initialize_linux_fork): Likewise.
104         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
105         * maint.c (_initialize_maint_cmds): Likewise.
106         * memattr.c (_initialize_mem): Likewise.
107         * printcmd.c (_initialize_printcmd): Likewise.
108         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
109         _RegEx): Likewise.
110         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
111         * record-btrace.c (_initialize_record_btrace): Likewise.
112         * record-full.c (_initialize_record_full): Likewise.
113         * record.c (_initialize_record): Likewise.
114         * regcache-dump.c (_initialize_regcache_dump): Likewise.
115         * regcache.c (_initialize_regcache): Likewise.
116         * remote.c (add_packet_config_cmd, init_remote_threadtests,
117         _initialize_remote): Likewise.
118         * ser-tcp.c (_initialize_ser_tcp): Likewise.
119         * serial.c (_initialize_serial): Likewise.
120         * skip.c (_initialize_step_skip): Likewise.
121         * source.c (_initialize_source): Likewise.
122         * stack.c (_initialize_stack): Likewise.
123         * symfile.c (_initialize_symfile): Likewise.
124         * symtab.c (_initialize_symtab): Likewise.
125         * target-descriptions.c (_initialize_target_descriptions): Likewise.
126         * top.c (init_main): Likewise.
127         * tracefile-tfile.c (tfile_target_info): Likewise.
128         * tracepoint.c (_initialize_tracepoint): Likewise.
129         * tui/tui-win.c (_initialize_tui_win): Likewise.
130         * utils.c (add_internal_problem_command): Likewise.
131         * valprint.c (value_print_option_defs): Likewise.
132
133 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
134
135         PR build/24886
136         * configure.ac: Drop enable-libmcheck support.
137         * configure, config.in: Rebuild.
138         * libmcheck.m4: Remove.
139         * acinclude.m4: Don't include it.
140         * Makefile.in: Don't distribute it.
141         * top.c (print_gdb_configuration): Don't mention it.
142
143 2019-08-06  Tom Tromey  <tom@tromey.com>
144
145         * utils.c (set_output_style): Sometimes pass stream to
146         emit_style_escape.
147         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
148         * record-btrace.c (btrace_insn_history): Update.
149         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
150         method.
151         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
152         Update initializers.
153         <m_uiout>: New field.
154         <m_di>: Move lower.
155         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
156         Remove "uiout" parameter.
157         (dump_insns): Update.
158         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
159         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
160
161 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
162
163         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
164         (error_in_psymtab_expansion): Likewise.
165         (lookup_symbol_via_quick_fns): Likewise.
166         (basic_lookup_transparent_type_quick): Likewise.
167         (basic_lookup_transparent_type_1): Likewise.
168
169 2019-08-06  Tom Tromey  <tromey@adacore.com>
170
171         * source.c (last_source_error): Now bool.
172         (print_source_lines_base): Make "noprint" bool.  Only open
173         source file when last_source_visited changes.
174
175 2019-08-06  Tom Tromey  <tromey@adacore.com>
176
177         * annotate.c (annotate_source_line): Use g_source_cache.
178         * source-cache.c (source_cache::get_plain_source_lines): Change
179         parameters.  Populate m_offset_cache.
180         (source_cache::ensure): New method.
181         (source_cache::get_line_charpos): New method.
182         (extract_lines): Move lower.  Change parameters.
183         (source_cache::get_source_lines): Move lower.
184         * source-cache.h (class source_cache): Update comment.
185         <get_line_charpos>: New method.
186         <get_source_lines>: Update comment.
187         <clear>: Clear m_offset_cache.
188         <get_plain_source_lines>: Change parameters.
189         <ensure>: New method
190         <m_offset_cache>: New member.
191         * source.c (forget_cached_source_info_for_objfile): Update.
192         (info_source_command): Use g_source_cache.
193         (find_source_lines, open_source_file_with_line_charpos): Remove.
194         (print_source_lines_base, search_command_helper): Use g_source_cache.
195         * source.h (open_source_file_with_line_charpos): Don't declare.
196         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
197         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
198         Use g_source_cache.
199
200 2019-08-06  Tom Tromey  <tromey@adacore.com>
201
202         * source-cache.c (source_cache::get_plain_source_lines):
203         Remove "first_line" and "last_line" parameters.
204         (source_cache::get_source_lines): Cache plain text.
205         * source-cache.h (class source_cache)
206         <get_plain_source_lines>: Update.
207
208 2019-08-06  Tom Tromey  <tromey@adacore.com>
209
210         * source-cache.c (extract_lines): No longer a method.
211         Changed type of parameter.  Include final newline.
212         (selftests::extract_lines_test): New function.
213         (_initialize_source_cache): Likewise.
214         * source-cache.h (class source_cache)
215         <extract_lines>: Don't declare.
216
217 2019-08-06  Tom Tromey  <tromey@adacore.com>
218
219         * breakpoint.c (init_breakpoint_sal): Update.
220         (breakpoint): Update.
221         * breakpoint.h (struct breakpoint) <filter>: Now a
222         unique_xmalloc_ptr.
223
224 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
225
226         * NEWS: Mention dictionary access on blocks.
227         * python/py-block.c (blpy_getitem): New function.
228         (block_object_as_mapping): New struct.
229         (block_object_type): Use new struct for tp_as_mapping field.
230
231 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
232
233         * objfiles.h (objfile): Add a comment describing partial symbols.
234
235 2019-08-05  Tom Tromey  <tromey@adacore.com>
236
237         * compile/compile.c (_initialize_compile): Use _(), not N_().
238         * thread.c (_initialize_thread): Use _(), not N_().
239         * stack.c (_initialize_stack): Use _(), not N_().
240         * printcmd.c (_initialize_printcmd): Use _(), not N_().
241
242 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
243
244         * dwarf2read.c (struct dw2_symtab_iterator):
245         <want_specific_block>: Remove.
246         <block_index>: Change type to gdb::optional.
247         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
248         change type of BLOCK_INDEX parameter to gdb::optional.
249         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
250         (dw2_lookup_symbol): Don't pass argument for
251         WANT_SPECIFIC_BLOCK.
252         (dw2_expand_symtabs_for_function): Don't pass argument for
253         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
254         (class dw2_debug_names_iterator)
255         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
256         parameter, change BLOCK_INDEX type to gdb::optional.
257         <m_want_specific_block>: Remove.
258         <m_block_index>: Change type to gdb::optional.
259         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
260         gdb::optional.  Re-write in function of gdb::optional.
261         (dw2_debug_names_lookup_symbol): Don't pass argument for
262         WANT_SPECIFIC_BLOCK.
263         (dw2_debug_names_expand_symtabs_for_function): Don't pass
264         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
265         BLOCK_INDEX.
266
267 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
268
269         * NEWS: Mention changes to "info sources" command.
270
271 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
272
273         * symtab.c (filename_partial_match_opts): New struct type.
274         (struct output_source_filename_data): New members
275         regexp, c_regexp, partial_match.
276         (output_source_filename): Use new members to decide to print file.
277         (info_sources_option_defs): New variable.
278         (make_info_sources_options_def_group, print_info_sources_header,
279         info_sources_command_completer):
280         New functions.
281         (info_sources_command): Read new optional arguments.
282         (_initialize_symtab): Update info sources help.
283
284 2019-08-02  Alexandre Oliva <oliva@adacore.com>
285
286         * ada-lang.c (exception_support_info_v0): Renamed from...
287         (default_exception_support_info): ... this.  Create new
288         definition for v1.
289         (ada_has_this_exception_support): Look up catch_handlers_sym.
290         (ada_exception_support_info_sniffer): Try v0 after default.
291
292 2019-08-01  Tom Tromey  <tromey@adacore.com>
293
294         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
295         gdbarch.h.
296
297 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
298
299         * s12z-tdep.c: Fix include path for s12z-opc.h.
300
301 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
302
303         * NEWS: Require GNU make 3.82.
304
305 2019-07-16  Tom Tromey  <tom@tromey.com>
306
307         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
308         declare.
309
310 2019-07-30  Tom Tromey  <tromey@adacore.com>
311
312         * block.c (contained_in): Remove BLOCK_FUNCTION check.
313
314 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
315
316         * printcmd.c (print_address_symbolic): Print negative offsets.
317         (build_address_symbolic): Force signed arithmetic when computing
318         offset.
319
320 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
321
322         PR/24474: Add a function to lookup static variables.
323         * NEWS: Mention this new function.
324         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
325         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
326         * python/python.c (python_GdbMethods): Add new function.
327
328 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
329
330         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
331         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
332         (objfpy_lookup_static_symbol): New function.
333         (objfile_object_methods): Add new functions.
334
335 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
336
337         * NEWS: Mention 'set|show print frame-info'.  Mention new
338         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
339         backtrace argument.  Mention that python frame filtering code
340         is now consistent with what 'backtrace' command prints.
341
342 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
343
344         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
345         comments.
346         (print_frame_info_auto, print_frame_info_source_line,
347         print_frame_info_location, print_frame_info_source_and_location,
348         print_frame_info_location_and_address, print_frame_info_short_location):
349         New declarations.
350         (struct frame_print_options): New member print_frame_info.
351         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
352         * stack.h (get_user_print_what_frame_info): New declaration.
353         (frame_show_address): New declaration.
354         * stack.c (print_frame_arguments_choices): New value 'presence'.
355         (print_frame_info_auto, print_frame_info_source_line,
356         print_frame_info_location, print_frame_info_source_and_location,
357         print_frame_info_location_and_address, print_frame_info_short_location,
358         print_frame_info_choices, print_frame_info_print_what): New definitions.
359         (print_frame_args): Only print dots for args if print frame-arguments
360         is 'presence'.
361         (frame_print_option_defs): New element for "frame-info".
362         (get_user_print_what_frame_info): New function.
363         (frame_show_address): Make non static.  Move comment to stack.h.
364         (print_frame_info_to_print_what): New function.
365         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
366         to decide what to print.
367         (backtrace_command_1): Handle the new print_frame_arguments_presence
368         value.
369         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
370         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
371         (py_print_frame): In non-mi mode, use LOCATION as default for
372         print_what, similarly to frame information printed directly by
373         backtrace command. Handle frame-info user option in non MI mode.
374
375 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
376
377         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
378         Add case for debugging 32-bit target on 64-bit host.  Revise
379         comment.
380
381 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
382
383         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
384         instead of find_function_entry_range_from_pc.
385
386 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
387
388         * stack.c (find_frame_funname): Remove code which preferred
389         minsym over symtab sym in "certain pathological cases".
390
391         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
392         parameter.  Change type of "do_demangle" to bool.
393         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
394         Pass suitable "prefer_sym_over_minsym" flag to
395         build_address_symbolic().  Don't output "+" for negative offsets.
396         * printcmd.c (print_address_symbolic): Update invocation of
397         build_address_symbolic to include a "prefer_sym_over_minsym"
398         flag.
399         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
400         Restrict cases in which use of minimal symbol is preferred to that
401         of a found symbol.  Update comments.
402
403         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
404         for entry pc when entry pc is out of range for that FDE.
405
406 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
407
408         PR gdb/24839:
409         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
410         type.
411
412 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
413
414         * python/py-objfile.c (add_separate_debug_file): Fix comment about
415         this function's Python signature.
416
417
418 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
419
420         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
421         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
422         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
423         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
424         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
425
426
427 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
428
429         * h8300-tdep.c (h8300_register_name_common): New.
430         h8300_register_name): Use h8300_register_name_common.
431         (h8300s_register_name): Likewise.
432         (h8300sx_register_name): Likewise.
433         (h8300h_register_nam): New.
434         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
435
436
437 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
438
439         * arm-tdep.c (arm_skip_cmse_entry): New function.
440         (arm_is_sgstubs_section): New function.
441         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
442
443 2019-07-22  Tom Tromey  <tom@tromey.com>
444
445         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
446         Don't self-assign.
447
448 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
449
450         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
451         type_print.
452
453 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
454
455         * symtab.c (search_symbols): Adjust msymbol matching type arrays
456         so that GDB doesn't match any msymbols when searching in the
457         TYPES_DOMAIN.
458         (print_symbol_info): Print using typedef_print or type_print based
459         on the type of the symbol.  Add updated FIXME comment moved from...
460         (_initialize_symtab): ... move and update FIXME comment to above.
461
462 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
463
464         * NEWS: Mention adding -q option to "info types".
465         * symtab.c (struct info_types_options): New struct.
466         (info_types_options_defs): New variable.
467         (make_info_types_options_def_group): New function.
468         (info_types_command): Use gdb::option framework to parse options.
469         (info_types_command_completer): New function.
470         (_initialize_symtab): Extend the help text on "info types" and
471         register command completer.
472
473 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
474
475         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
476         (lookup_symbol_in_objfile): Change int to block_enum and add a
477         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
478
479 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
480
481         * MAINTAINERS (Write After Approval): Add self.
482
483 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
484
485         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
486         instruction to the dummy code region.
487
488 2019-07-19  Tom Tromey  <tromey@adacore.com>
489
490         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
491         (ARGSUSED, PARAMS, __func__): Remove rules.
492
493 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
494
495         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
496         * features/arm/arm-with-iwmmxt.c: Remove.
497         * features/arm/arm-with-iwmmxt.xml: Remove.
498         * features/arm/arm-with-m-fpa-layout.c: Remove.
499         * features/arm/arm-with-m-fpa-layout.xml: Remove.
500         * features/arm/arm-with-m-vfp-d16.c: Remove.
501         * features/arm/arm-with-m-vfp-d16.xml: Remove.
502         * features/arm/arm-with-m.c: Remove.
503         * features/arm/arm-with-m.xml: Remove.
504         * features/arm/arm-with-neon.c: Remove.
505         * features/arm/arm-with-neon.xml: Remove.
506         * features/arm/arm-with-vfpv2.c: Remove.
507         * features/arm/arm-with-vfpv2.xml: Remove.
508         * features/arm/arm-with-vfpv3.c: Remove.
509         * features/arm/arm-with-vfpv3.xml: Remove.
510
511 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
512
513         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
514
515 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
516
517         * arch/aarch32.c (aarch32_create_target_description): Create
518         target descriptions using features.
519         * arch/arm.c (arm_create_target_description)
520         (arm_create_mprofile_target_description): Likewise.
521         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
522
523 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
524
525         * Makefile.in: Add new files.
526         * aarch32-tdep.c: New file.
527         * aarch32-tdep.h: New file.
528         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
529         Call aarch32_read_description.
530         * arch/aarch32.c: New file.
531         * arch/aarch32.h: New file.
532         * arch/arm.c (arm_create_target_description)
533         (arm_create_mprofile_target_description): New function.
534         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
535         (arm_create_target_description)
536         (arm_create_mprofile_target_description): New declaration.
537         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
538         read_description functions.
539         * arm-linux-nat.c (arm_linux_nat_target::read_description):
540         Likewise.
541         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
542         * arm-tdep.c (tdesc_arm_list): New variable.
543         (arm_register_g_packet_guesses): Call create description functions.
544         (arm_read_description) (arm_read_mprofile_description): New
545         function.
546         * arm-tdep.h (arm_read_description)
547         (arm_read_mprofile_description): Add declaration.
548         * configure.tgt: Add new files.
549
550 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
551
552         * top.c (new_ui_command): Open specified terminal just once.
553
554 2019-07-18  Tom Tromey  <tromey@adacore.com>
555
556         * symtab.c (main_name): Constify return type.
557         * symfile.c (set_initial_language): Update.
558         * symtab.h (main_name): Constify return type.
559
560 2019-07-17  Tom Tromey  <tom@tromey.com>
561
562         * tui/tui-winsource.c (tui_update_source_window)
563         (tui_update_source_window_as_is)
564         (tui_update_source_windows_with_line): Remove return.
565         * tui/tui-disasm.c (tui_show_disassem)
566         (tui_show_disassem_and_update_source): Remove return.
567         * tui/tui.c (tui_reset): Remove return.
568         * tui/tui-wingeneral.c
569         (tui_check_and_display_highlight_if_needed): Remove return.
570
571 2019-07-17  Tom Tromey  <tom@tromey.com>
572
573         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
574
575 2019-07-17  Tom Tromey  <tom@tromey.com>
576
577         * tui/tui-winsource.h (struct tui_exec_info_window)
578         (struct tui_source_window_base): Move from tui-data.h.
579         * tui/tui-winsource.c: Move many method definitions from
580         elsewhere.  Remove "structuring" comments.
581         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
582         (tui_source_window_base::refresh_window): Move to
583         tui-winsource.c.
584         * tui/tui-win.c (tui_source_window_base::refresh_all)
585         (tui_source_window_base::update_tab_width)
586         (tui_source_window_base::set_new_height)
587         (tui_source_window_base::do_make_visible_with_new_height): Move to
588         tui-winsource.c.
589         * tui/tui-source.h: Update.
590         * tui/tui-source.c (tui_source_window_base::reset): Move to
591         tui-winsource.c.
592         * tui/tui-disasm.h: Update.
593         * tui/tui-data.h (struct tui_exec_info_window): Move to
594         tui-winsource.h.
595         (struct tui_source_window_base): Likewise.
596         * tui/tui-data.c (tui_source_window_base::clear_detail)
597         (tui_source_window_base, ~tui_source_window_base): Move to
598         tui-winsource.c.
599
600 2019-07-17  Tom Tromey  <tom@tromey.com>
601
602         * tui/tui-win.c (tui_resize_all)
603         (tui_source_window_base::update_tab_width)
604         (tui_adjust_win_heights): Update.
605         (tui_win_info::make_invisible_and_set_new_height): Rename from
606         make_invisible_and_set_new_height.
607         * tui/tui-data.h (struct tui_win_info)
608         <make_invisible_and_set_new_height>: New method.
609
610 2019-07-17  Tom Tromey  <tom@tromey.com>
611
612         * tui/tui.c: Update.
613         * tui/tui-source.h (struct tui_source_window): Move from
614         tui-data.h.
615         * tui/tui-layout.c: Update.
616         * tui/tui-disasm.c: Update.
617         * tui/tui-data.h (struct tui_source_window): Move to
618         tui-source.h.
619
620 2019-07-17  Tom Tromey  <tom@tromey.com>
621
622         * tui/tui-disasm.h (struct tui_disasm_window): Move from
623         tui-data.h.
624         * tui/tui-data.h (struct tui_disasm_window): Move to
625         tui-disasm.h.
626
627 2019-07-17  Tom Tromey  <tom@tromey.com>
628
629         * tui/tui-regs.h (struct tui_data_item_window): Move from
630         tui-data.h.
631         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
632         * tui/tui-data.h (struct tui_data_item_window): Move to
633         tui-regs.h.
634         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
635
636 2019-07-17  Tom Tromey  <tom@tromey.com>
637
638         * tui/tui.c: Update.
639         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
640         (tui_cmd_window::max_height): Move to tui-command.c.
641         * tui/tui-layout.c: Update.
642         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
643         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
644         tui-command.c.
645         * tui/tui-command.h (struct tui_cmd_window): Move from
646         tui-data.h.
647         * tui/tui-command.c: Remove "structuring" comments.
648         (tui_cmd_window::clear_detail)
649         (tui_cmd_window::do_make_visible_with_new_height)
650         (tui_cmd_window::max_height): Move from elsewhere.
651
652 2019-07-17  Tom Tromey  <tom@tromey.com>
653
654         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
655         Now static.
656         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
657         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
658
659 2019-07-17  Tom Tromey  <tom@tromey.com>
660
661         * tui/tui.c: Update.
662         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
663         tui-regs.c.
664         * tui/tui-windata.h: Remove file.
665         * tui/tui-windata.c: Remove file.
666         * tui/tui-win.c (tui_data_window::set_new_height)
667         (tui_data_window::do_make_visible_with_new_height): Move to
668         tui-regs.c.
669         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
670         * tui/tui-regs.c: Remove "structuring" comments.
671         (tui_data_window::first_data_item_displayed)
672         (tui_data_window::delete_data_content_windows)
673         (tui_data_window::erase_data_content)
674         (tui_data_window::display_all_data)
675         (tui_data_window::refresh_all)
676         (tui_data_window::do_scroll_vertical)
677         (tui_data_window::clear_detail, tui_data_window::set_new_height)
678         (tui_data_window::do_make_visible_with_new_height)
679         (tui_data_window::refresh_window): Move from elsewhere.
680         (_initialize_tui_regs): Move to end of file.
681         * tui/tui-layout.c: Update.
682         * tui/tui-hooks.c: Update.
683         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
684         * tui/tui-data.c (tui_data_window::clear_detail): Move to
685         tui-regs.c.
686         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
687
688 2019-07-17  Tom Tromey  <tom@tromey.com>
689
690         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
691         seen.
692
693 2019-07-17  Tom Tromey  <tom@tromey.com>
694
695         * tui/tui-win.c (tui_source_window_base::set_new_height)
696         (tui_source_window_base::do_make_visible_with_new_height): Use
697         m_has_locator field directly.
698         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
699         method.
700         (struct tui_source_window_base) <has_locator>: Likewise.
701
702 2019-07-17  Tom Tromey  <tom@tromey.com>
703
704         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
705         Don't declare.
706         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
707         Remove.
708         * tui/tui-win.c (tui_source_window_base::set_new_height)
709         (tui_source_window_base::set_new_height)
710         (make_invisible_and_set_new_height)
711         (tui_source_window_base::do_make_visible_with_new_height)
712         (tui_source_window_base::do_make_visible_with_new_height):
713         Update.
714         * tui/tui-layout.c (show_source_disasm_command, show_data)
715         (show_source_or_disasm_and_command): Update.
716         * tui/tui-layout.c (show_layout): Update.
717
718 2019-07-17  Tom Tromey  <tom@tromey.com>
719
720         * tui/tui-layout.c (make_data_window): Remove.
721         (show_data): Unify creation and re-initialization cases.
722
723 2019-07-17  Tom Tromey  <tom@tromey.com>
724
725         * tui/tui-layout.c (make_source_window, make_disasm_window):
726         Remove.
727         (show_data): Unify creation and re-initialization cases.
728
729 2019-07-17  Tom Tromey  <tom@tromey.com>
730
731         * tui/tui-layout.c (make_command_window): Remove.
732         (show_source_disasm_command, show_source_or_disasm_and_command):
733         Unify creation and re-initialization cases.
734
735 2019-07-17  Tom Tromey  <tom@tromey.com>
736
737         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
738         creation and re-initialization cases.
739
740 2019-07-17  Tom Tromey  <tom@tromey.com>
741
742         * tui/tui-regs.c (tui_get_register): Return void.
743
744 2019-07-17  Tom Tromey  <tom@tromey.com>
745
746         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
747         Simplify.
748
749 2019-07-17  Tom Tromey  <tom@tromey.com>
750
751         * tui/tui-layout.c (show_source_disasm_command): Simplify window
752         resetting.
753
754 2019-07-17  Tom Tromey  <tom@tromey.com>
755
756         * tui/tui.h (tui_set_layout_by_name): Don't declare.
757         * tui/tui-regs.c (tui_reg_layout): New function.
758         (tui_show_registers, tui_reg_command): Use it.
759         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
760         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
761         parameters.
762         (tui_layout_command): Remove.
763
764 2019-07-17  Tom Tromey  <tom@tromey.com>
765
766         * tui/tui-layout.h (tui/tui-layout): Return void.
767         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
768
769 2019-07-17  Tom Tromey  <tom@tromey.com>
770
771         * tui/tui-layout.c (show_source_disasm_command, show_data):
772         Update.
773         (reset_locator): Remove.
774         (show_source_or_disasm_and_command): Update.
775
776 2019-07-17  Tom Tromey  <tom@tromey.com>
777
778         * tui/tui-source.c (tui_source_window_base::reset): Remove
779         win_type parameter.
780         * tui/tui-layout.c (make_command_window, make_source_window)
781         (make_disasm_window, make_data_window)
782         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
783         (reset_locator, show_source_or_disasm_and_command): Update.
784         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
785         win_type parameter.
786         (struct tui_source_window_base) <reset>: Likewise.
787
788 2019-07-17  Tom Tromey  <tom@tromey.com>
789
790         * tui/tui-layout.c (show_source_disasm_command): Use
791         reset_locator.
792         (reset_locator): New function.
793         (init_and_make_win): Remove.
794         (show_source_or_disasm_and_command): Use reset_locator.
795
796 2019-07-17  Tom Tromey  <tom@tromey.com>
797
798         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
799         condition.
800         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
801         Remove condition.
802         * tui/tui-source.c (tui_source_window_base::reset): New method.
803         * tui/tui-layout.c (make_command_window): Don't call
804         init_and_make_win.
805         (make_source_window, make_disasm_window): Don't call
806         make_source_or_disasm_window.
807         (make_data_window): Don't call init_and_make_win.  Change calling
808         convention.
809         (show_source_disasm_command, show_data): Simplify.
810         (make_source_or_disasm_window): Remove.
811         (show_source_or_disasm_and_command): Simplify.
812         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
813         (struct tui_source_window_base) <reset>: Likewise.
814         <execution_info>: Remove initializer.
815         * tui/tui-data.c (tui_source_window_base): Initialize
816         execution_info.
817
818 2019-07-17  Tom Tromey  <tom@tromey.com>
819
820         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
821         variable.
822
823 2019-07-17  Tom Tromey  <tom@tromey.com>
824
825         * tui/tui.c (tui_rl_other_window): Update.
826         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
827         superclass method first.  Always iterate over regs_content.
828         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
829         method.
830         * tui/tui-win.c (tui_set_focus_command): Update.
831
832 2019-07-17  Tom Tromey  <tom@tromey.com>
833
834         * tui/tui-win.c (tui_set_focus_command): Rename from
835         tui_set_focus.  Call tui_enable.
836         (tui_set_focus_command): Remove.
837
838 2019-07-17  Tom Tromey  <tom@tromey.com>
839
840         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
841         refresh_window.
842         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
843         touchwin.
844         (tui_data_window::refresh_window): Call refresh_window on data
845         items.  Always call superclass refresh_window.
846         (tui_win_info::refresh): Remove.
847         (tui_source_window_base::refresh_window): Update.
848         (tui_refresh_all): Update.
849         * tui/tui-layout.c (show_source_disasm_command): Remove call to
850         refresh_window.
851         (show_source_or_disasm_and_command): Likewise.
852         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
853         (struct tui_source_window_base) <refresh>: Likewise.
854
855 2019-07-17  Tom Tromey  <tom@tromey.com>
856
857         * tui/tui-winsource.c (tui_clear_source_content)
858         (tui_show_source_content): Update.
859         * tui/tui-source.c (tui_source_window::showing_source_p): Check
860         whether content is empty.
861         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
862         Remove.
863
864 2019-07-17  Tom Tromey  <tom@tromey.com>
865
866         * tui/tui-winsource.c (tui_erase_source_content): Clear the
867         window's contents.
868         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
869         * tui/tui-source.c (tui_set_source_content_nil): Remove.
870
871 2019-07-17  Tom Tromey  <tom@tromey.com>
872
873         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
874         (struct tui_data_item_window): Update.
875
876 2019-07-17  Tom Tromey  <tom@tromey.com>
877
878         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
879         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
880         defines.
881
882 2019-07-17  Tom Tromey  <tom@tromey.com>
883
884         * tui/tui-winsource.h (tui_erase_source_content)
885         (tui_clear_source_content): Remove "display_prompt" parameter.
886         * tui/tui-winsource.c (tui_update_source_window_as_is)
887         (tui_update_source_windows_with_addr): Update.
888         (tui_clear_source_content): Remove "display_prompt" parameter.
889         (tui_erase_source_content): Likewise.  Simplify.
890         (tui_show_source_content): Update.
891         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
892         * tui/tui-stack.c (tui_show_frame_info): Update.
893         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
894         Remove defines.
895
896 2019-07-17  Tom Tromey  <tom@tromey.com>
897
898         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
899         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
900         parameter.
901         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
902         parameter.
903
904 2019-07-17  Tom Tromey  <tom@tromey.com>
905
906         * tui/tui-winsource.c (tui_clear_source_content)
907         (tui_show_source_content, tui_show_exec_info_content)
908         (tui_clear_exec_info_content): Update.
909         * tui/tui-stack.c (tui_show_locator_content): Update.
910         (tui_show_frame_info): Update.
911         * tui/tui-source.h (tui_source_window): Don't declare.
912         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
913         from tui_source_is_displayed.
914         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
915         Remove field.
916         (struct tui_source_window_base) <content_in_use>: New field.  Now
917         bool.
918         (struct tui_source_window) <showing_source_p>: New method.
919         (TUI_SRC_WIN): Change cast.
920         * tui/tui-data.c (tui_initialize_static_data): Update.
921
922 2019-07-17  Tom Tromey  <tom@tromey.com>
923
924         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
925         location_matches_p.
926         * tui/tui-source.c (tui_source_window::location_matches_p): New
927         method.
928         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
929         method.
930         * tui/tui-data.h (struct tui_source_window_base)
931         <location_matches_p>: New method.
932         (struct tui_source_window, struct tui_disasm_window)
933         <location_matches_p>: Likewise.
934
935 2019-07-17  Tom Tromey  <tom@tromey.com>
936
937         * tui/tui-win.c (tui_set_win_height_command): Rename from
938         tui_set_win_height.
939         (tui_set_win_height_command): Remove.
940
941 2019-07-17  Tom Tromey  <tom@tromey.com>
942
943         * tui/tui-source.c (tui_source_window): New constructor.  Add
944         observer.
945         (~tui_source_window): New destructor.
946         (tui_source_window::style_changed): New method.
947         * tui/tui-hooks.c (tui_redisplay_source): Remove.
948         (tui_attach_detach_observers): Update.
949         * tui/tui-data.h (struct tui_source_window): Make constructor not
950         inline.  Add destructor.
951         (struct tui_source_window) <style_changed>: New method.
952         <m_observable>: New member.
953
954 2019-07-17  Tom Tromey  <tom@tromey.com>
955
956         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
957         * tui/tui-win.c (tui_resize_all): Fix typo.
958
959 2019-07-17  Tom Tromey  <tom@tromey.com>
960
961         * tui/tui-wingeneral.h (tui_refresh_all): Update.
962         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
963         (tui_refresh_all): Remove "list" parameter.  Use foreach.
964         * tui/tui-win.c (window_name_completer): Use foreach.
965         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
966         (update_tab_width): Likewise.
967         * tui/tui-layout.c (show_layout): Update.
968         * tui/tui-data.h (class tui_window_iterator): New.
969         (struct all_tui_windows): New.
970         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
971
972 2019-07-17  Tom Tromey  <tom@tromey.com>
973
974         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
975         parameter.  Don't reference globals.
976         (tui_reg_command): Update.
977
978 2019-07-17  Tom Tromey  <tom@tromey.com>
979
980         * tui/tui-regs.c (tui_show_registers): Simplify.
981
982 2019-07-17  Tom Tromey  <tom@tromey.com>
983
984         * tui/tui-regs.c (tui_show_registers): Update.
985         (tui_show_register_group): Add win_info parameter.
986
987 2019-07-17  Tom Tromey  <tom@tromey.com>
988
989         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
990         Rename from tui_display_reg_element_at_line.
991         (tui_data_window::display_registers_from_line): Update.
992         * tui/tui-data.h (struct tui_data_window)
993         <display_reg_element_at_line>: New method.
994
995 2019-07-17  Tom Tromey  <tom@tromey.com>
996
997         * tui/tui-regs.h (tui_display_registers_from)
998         (tui_display_registers_from_line): Don't declare.
999         * tui/tui-windata.c (tui_data_window::display_all_data)
1000         (tui_data_window::refresh_all)
1001         (tui_data_window::do_scroll_vertical): Update.
1002         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1003         from tui_display_registers_from.
1004         (tui_display_reg_element_at_line): Update.
1005         (tui_data_window::display_registers_from_line): Rename from
1006         tui_display_registers_from_line.
1007         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1008         display_registers_from_line>: New methods.
1009
1010 2019-07-17  Tom Tromey  <tom@tromey.com>
1011
1012         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1013         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1014         from tui_erase_data_content.
1015         (tui_data_window::display_all_data)
1016         (tui_data_window::refresh_all)
1017         (tui_data_window::do_scroll_vertical): Update.
1018         * tui/tui-regs.c (tui_show_registers): Update.
1019         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1020         New method.
1021
1022 2019-07-17  Tom Tromey  <tom@tromey.com>
1023
1024         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1025         declare.
1026         * tui/tui-windata.c
1027         (tui_data_window::delete_data_content_windows): Rename from
1028         tui_delete_data_content_windows.
1029         (tui_data_window::display_all_data)
1030         (tui_data_window::do_scroll_vertical): Update.
1031         * tui/tui-data.h (struct tui_data_window)
1032         <delete_data_content_windows>: New method.
1033
1034 2019-07-17  Tom Tromey  <tom@tromey.com>
1035
1036         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1037         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1038
1039 2019-07-17  Tom Tromey  <tom@tromey.com>
1040
1041         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1042         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1043         from tui_display_all_data.
1044         * tui/tui-win.c
1045         (tui_data_window::do_make_visible_with_new_height): Update.
1046         * tui/tui-regs.c (tui_show_registers): Update.
1047         * tui/tui-layout.c (tui_set_layout): Update.
1048         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1049         method.
1050
1051 2019-07-17  Tom Tromey  <tom@tromey.com>
1052
1053         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1054         * tui/tui-windata.c (tui_display_data_from): Remove.
1055         (tui_data_window::refresh_all): Update.
1056
1057 2019-07-17  Tom Tromey  <tom@tromey.com>
1058
1059         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1060         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1061         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1062         tui_display_registers_from_line.
1063         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1064         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1065         "force_display" parameter.
1066
1067 2019-07-17  Tom Tromey  <tom@tromey.com>
1068
1069         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1070         declare.
1071         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1072         Rename from tui_first_reg_element_no_inline.
1073         (tui_display_reg_element_at_line)
1074         (tui_display_registers_from_line): Update.
1075         * tui/tui-data.h (struct tui_data_window)
1076         <first_reg_element_no_inline>: New method.
1077
1078 2019-07-17  Tom Tromey  <tom@tromey.com>
1079
1080         * tui/tui-windata.c (tui_display_data_from)
1081         (tui_data_window::do_scroll_vertical): Update.
1082         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1083         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1084         Rename from tui_line_from_reg_element_no.
1085         (tui_display_registers_from_line): Update.
1086         * tui/tui-data.h (struct tui_data_window)
1087         <line_from_reg_element_no>: New method.
1088
1089 2019-07-17  Tom Tromey  <tom@tromey.com>
1090
1091         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1092         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1093         tui_last_regs_line_no.
1094         (tui_display_reg_element_at_line)
1095         (tui_display_registers_from_line): Update.
1096         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1097         method.
1098
1099 2019-07-17  Tom Tromey  <tom@tromey.com>
1100
1101         PR tui/24722:
1102         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1103         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1104         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1105         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1106         (tui_update_breakpoint_info): Likewise.
1107         * tui/tui-hooks.c (tui_event_create_breakpoint)
1108         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1109         Update.
1110
1111 2019-07-17  Tom Tromey  <tom@tromey.com>
1112
1113         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1114
1115 2019-07-17  Tom Tromey  <tom@tromey.com>
1116
1117         * tui/tui-winsource.c (tui_update_source_window_as_is)
1118         (tui_update_source_windows_with_addr): Update.
1119         * tui/tui-source.h (tui_set_source_content)
1120         (tui_show_symtab_source): Add "win_info" parameter.
1121         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1122         parameter.
1123         (tui_show_symtab_source): Likewise.
1124
1125 2019-07-17  Tom Tromey  <tom@tromey.com>
1126
1127         * tui/tui-wingeneral.c
1128         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1129
1130 2019-07-17  Tom Tromey  <tom@tromey.com>
1131
1132         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1133         (struct tui_cmd_window) <can_scroll>: New method.
1134         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1135         method.
1136
1137 2019-07-17  Tom Tromey  <tromey@adacore.com>
1138
1139         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1140         do_field_signed>: Rename.  Change type of "value".
1141         * ui-out.c (ui_out::field_signed): Rename from field_int.
1142         Change type of "value".
1143         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1144         type of "value".
1145         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1146         do_field_int.  Change type of "value".
1147         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1148         do_field_int.  Change type of "value".
1149         * tracepoint.c (trace_status_mi, tfind_1)
1150         (print_one_static_tracepoint_marker): Update.
1151         * thread.c (print_thread_info_1, print_selected_thread_frame):
1152         Update.
1153         * stack.c (print_frame, print_frame_info): Update.
1154         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1155         Update.
1156         * source.c (print_source_lines_base): Update.
1157         * skip.c (info_skip_command): Update.
1158         * record-btrace.c (btrace_ui_out_decode_error)
1159         (btrace_call_history_src_line): Update.
1160         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1161         Update.
1162         * progspace.c (print_program_space): Update.
1163         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1164         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1165         do_field_int.  Change type of "value".
1166         * mi/mi-out.c (mi_ui_out::do_table_begin)
1167         (mi_ui_out::do_table_header): Update.
1168         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1169         type of "value".
1170         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1171         (mi_cmd_data_list_changed_registers, output_register)
1172         (mi_cmd_data_read_memory, mi_load_progress)
1173         (mi_cmd_trace_frame_collected): Update.
1174         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1175         Update.
1176         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1177         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1178         (mi_cmd_var_list_children, varobj_update_one): Update.
1179         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1180         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1181         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1182         * inferior.c (print_inferior): Update.
1183         * gdb_bfd.c (print_one_bfd): Update.
1184         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1185         Update.
1186         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1187         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1188         do_field_int.  Change type of "value".
1189         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1190         do_field_int.  Change type of "value".
1191         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1192         (print_one_breakpoint_location, print_it_catch_fork)
1193         (print_one_catch_fork, print_it_catch_vfork)
1194         (print_one_catch_vfork, print_it_catch_solib)
1195         (print_it_catch_exec, print_it_ranged_breakpoint)
1196         (print_mention_watchpoint, print_mention_masked_watchpoint)
1197         (bkpt_print_it, update_static_tracepoint): Update.
1198         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1199         * break-catch-syscall.c (print_it_catch_syscall): Update.
1200         * ada-tasks.c (print_ada_task_info): Update.
1201         * ada-lang.c (print_it_exception, print_mention_exception):
1202         Update.
1203
1204 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1205
1206         PR breakpoints/24541
1207         * gdbarch.c: Regenerate.
1208         * gdbarch.h: Regenerate.
1209         * gdbarch.sh: Adjust return type and parameter types for
1210         'stap_adjust_register'.
1211         (i386_stap_adjust_register): Adjust signature and return new
1212         register name.
1213         * stap-probe.c (stap_parse_register_operand): Adjust use of
1214         'gdbarch_stap_adjust_register'.
1215
1216 2019-07-17  Tom Tromey  <tromey@adacore.com>
1217
1218         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1219         declare VEC.
1220         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1221         std::vector.
1222         (struct s390_process_info): Add initializers.
1223         (s390_add_process): Use new.
1224         (s390_linux_nat_target::low_forget_process): Use delete.
1225         (s390_linux_nat_target::low_new_fork)
1226         (s390_linux_nat_target::stopped_by_watchpoint)
1227         (s390_linux_nat_target::low_prepare_to_resume)
1228         (s390_linux_nat_target::insert_watchpoint)
1229         (s390_linux_nat_target::insert_hw_breakpoint)
1230         (s390_linux_nat_target::remove_watchpoint)
1231         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1232
1233 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1234
1235         * aarch64-fbsd-nat.c: Include regcache.h.
1236         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1237         argument.
1238         (aarch64_fbsd_nat_target::fetch_registers)
1239         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1240         variable.
1241         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1242
1243 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1244
1245         * fbsd-nat.c: Include gdbarch.h.
1246
1247 2019-07-15  Tom Tromey  <tromey@adacore.com>
1248
1249         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1250
1251 2019-07-15  Tom Tromey  <tromey@adacore.com>
1252
1253         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1254         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1255         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1256         * cli-out.c (cli_ui_out::do_field_int): New method.
1257         * ui-out.c (ui_out::field_unsigned): New method.
1258         * symfile.c (generic_load): Use field_unsigned.
1259         (print_transfer_performance): Likewise.
1260         * record-btrace.c (ui_out_field_uint): Remove.
1261         (btrace_call_history_insn_range, btrace_call_history): Use
1262         field_unsigned.
1263         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1264         field_unsigned.
1265         * ui-out.h (class ui_out) <field_unsigned>: New method.
1266         <do_field_unsigned>: Likewise.
1267
1268 2019-07-15  Tom Tromey  <tromey@adacore.com>
1269
1270         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1271         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1272         * target.c (flash_erase_command): Use field_string.
1273         * infrun.c (print_signal_received_reason): Use field_string.
1274         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1275         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1276         field_string.
1277         * ada-tasks.c (print_ada_task_info): Use field_string.
1278
1279 2019-07-15  Tom Tromey  <tromey@adacore.com>
1280
1281         * target.c (flash_erase_command): Use field_core_addr.
1282         * symfile.c (generic_load): Use field_core_addr.
1283         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1284         Use field_core_addr.
1285         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1286         field_core_addr.
1287
1288 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1289
1290         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1291         value if its desired type is smaller than a CORE_ADDR and signed.
1292
1293 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1294
1295         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1296         of changes to field names, and use new is_reference field to
1297         decide if a property is a reference or not.
1298         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1299         field.
1300         (struct dwarf2_property_baton): Update header comment, rename
1301         'referenced_type' to 'property_type' and update comments.
1302         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1303         default property type, store in property baton, update to take
1304         accound of renamed field.
1305         (read_func_scope): Update call to attr_to_dynamic_prop.
1306         (read_array_type): Likewise.
1307         (dwarf2_per_cu_addr_sized_int_type): New function.
1308         (read_subrange_index_type): Move type finding code to
1309         dwarf2_per_cu_addr_sized_int_type.
1310         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1311         (dwarf2_per_cu_addr_type): New function.
1312         (set_die_type): Update calls to attr_to_dynamic_prop.
1313
1314 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1315
1316         * dwarf2read.c (read_subrange_index_type): New function.
1317         (read_subrange_type): Move code into new function and call it.
1318         * gdbtypes.c (create_range_type): Add some asserts.
1319
1320 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1321
1322         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1323         update return statements.
1324         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1325         declaration, and update comment to match.
1326         * gdbtypes.c (resolve_dynamic_array): Update call to
1327         dwarf2_evaluate_property to match new return type.
1328
1329 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1330
1331         * valarith.c (value_subscripted_rvalue): Change lowerbound
1332         parameter type from int to LONGEST.
1333         * value.h (value_subscripted_rvalue): Likewise in declaration.
1334
1335 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1336
1337         * cli/cli-utils.c (info_print_command_completer): New function.
1338         * cli/cli-utils.h: Add 'completer.h' include, and forward
1339         declaration for 'struct cmd_list_element'.
1340         (info_print_command_completer): Declare.
1341         * stack.c (_initialize_stack): Add completer for 'info locals' and
1342         'info args'.
1343         * symtab.c (_initialize_symtab): Add completer for 'info
1344         variables' and 'info functions'.
1345         * NEWS: Mention completion for additional info commands.
1346
1347 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1348
1349         * cli/cli-utils.c (extract_info_print_args): Delete.
1350         (extract_arg_maybe_quoted): Delete.
1351         (info_print_options_defs): New variable.
1352         (make_info_print_options_def_group): New function.
1353         (extract_info_print_options): Define new function.
1354         * cli/cli-utils.h (extract_info_print_args): Delete.
1355         (struct info_print_options): New structure.
1356         (extract_info_print_options): Declare new function.
1357         * stack.c (info_locals_command): Update to use new
1358         extract_info_print_options, also add a header comment.
1359         (info_args_command): Likewise.
1360         * symtab.c (info_variables_command): Likewise.
1361         (info_functions_command): Likewise.
1362
1363 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1364
1365         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1366         to extract string arguments.
1367         * common/common-utils.c (extract_string_maybe_quoted): New function.
1368         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1369
1370 2019-07-11  Tom Tromey  <tromey@adacore.com>
1371
1372         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1373         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1374         * top.h (gdbinit): Don't declare.
1375         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1376         into...
1377         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1378         * top.c (gdb_init): Don't call init_cli_cmds.
1379         (gdbinit): Remove.
1380         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1381
1382 2019-07-11  Tom Tromey  <tromey@adacore.com>
1383
1384         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1385         after it has been moved.
1386
1387 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1388
1389         * valops.c (value_must_coerce_to_target): Change return type to
1390         bool.
1391         * value.h (value_must_coerce_to_target): Likewise.
1392
1393 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1394
1395         * breakpoint.c (is_hardware_watchpoint): Remove
1396         forward-declaration.
1397         (is_masked_watchpoint): Change return type to bool.
1398         (is_tracepoint): Likewise.
1399         (is_breakpoint): Likewise.
1400         (is_hardware_watchpoint): Likewise.
1401         (is_watchpoint): Likewise.
1402         (is_no_memory_software_watchpoint): Likewise.
1403         (is_catchpoint): Likewise.
1404         (breakpoint_1): Make FILTER parameter's return type bool.
1405         is_masked_watchpoint): Change return type to bool.
1406         (save_breakpoints): Make FILTER parameter's return type bool.
1407         * breakpoint.h (is_breakpoint): Change return type to bool.
1408         (is_watchpoint): Likewise.
1409         (is_catchpoint): Likewise.
1410         (is_tracepoint): Likewise.
1411
1412 2019-07-10  Tom Tromey  <tom@tromey.com>
1413
1414         * defs.h: Don't include gdbarch.h.
1415         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1416         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1417         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1418         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1419         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1420         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1421         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1422         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1423         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1424         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1425         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1426         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1427         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1428         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1429         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1430         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1431         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1432         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1433         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1434         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1435         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1436         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1437         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1438         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1439         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1440         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1441         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1442
1443 2019-07-10  Tom Tromey  <tromey@adacore.com>
1444
1445         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1446         * breakpoint.c (init_ada_exception_breakpoint): Register as
1447         bp_catchpoint.
1448         (print_one_breakpoint_location, print_one_breakpoint): Use
1449         is_ada_exception_catchpoint.
1450         * ada-lang.c (class ada_catchpoint_location): Pass
1451         bp_loc_software_breakpoint to bp_location constructor.
1452         (is_ada_exception_catchpoint): New function.
1453
1454 2019-07-10  Tom Tromey  <tromey@adacore.com>
1455
1456         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1457         VEC.
1458         (struct arm_exidx_entry): New method operator<.
1459         (struct arm_exidx_data) <section_maps>: Change type.
1460         (arm_exidx_data_free): Remove.
1461         (arm_exidx_data_key): Change type.  Move lower.
1462         (arm_exidx_new_objfile): Update.
1463         (arm_compare_exidx_entries): Remove.
1464         (arm_find_exidx_entry, _initialize_arm_tdep)
1465
1466 2019-07-10  Tom Tromey  <tromey@adacore.com>
1467
1468         * solib-spu.c (ocl_program_data_key): Change type.
1469         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1470         Update.
1471
1472 2019-07-10  Tom Tromey  <tromey@adacore.com>
1473
1474         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1475         (struct solib_aix_inferior_data) <library_list>: Change type.
1476         (solib_aix_inferior_data_handle): Change type.
1477         (get_solib_aix_inferior_data): Update.
1478         (solib_aix_free_library_list): Remove.
1479         (library_list_start_library): Update.
1480         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1481         return type.
1482         (solib_aix_get_library_list)
1483         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1484         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1485
1486 2019-07-10  Tom Tromey  <tromey@adacore.com>
1487
1488         * solib-dsbt.c (struct dsbt_info): Add initializers.
1489         (solib_dsbt_pspace_data): Change type.
1490         (dsbt_pspace_data_cleanup): Remove.
1491         (get_dsbt_info, _initialize_dsbt_solib): Update.
1492
1493 2019-07-10  Tom Tromey  <tromey@adacore.com>
1494
1495         * spu-tdep.c (spu_overlay_data): Change type.
1496         (spu_get_overlay_table, spu_overlay_new_objfile)
1497         (_initialize_spu_tdep): Update.
1498
1499 2019-07-10  Tom Tromey  <tromey@adacore.com>
1500
1501         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1502         destructor.
1503         (dbx_objfile_data_key): Change type and declare later.
1504         (DBX_SYMFILE_INFO): Rewrite.
1505         * dbxread.c (dbx_objfile_data_key): Change type.
1506         (dbx_symfile_init): Update.
1507         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1508         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1509         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1510
1511 2019-07-10  Tom Tromey  <tromey@adacore.com>
1512
1513         * jit.c (jit_program_space_key): Change type.  Move lower.
1514         (get_jit_program_space_data): Update.
1515         (jit_program_space_data_cleanup): Remove.
1516         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1517         Update.
1518         (struct jit_program_space_data): Add initializers.
1519
1520 2019-07-10  Tom Tromey  <tromey@adacore.com>
1521
1522         * solib-darwin.c (struct darwin_info): Add initializers.
1523         (solib_darwin_pspace_data): Change type.
1524         (darwin_pspace_data_cleanup): Remove.
1525         (get_darwin_info, _initialize_darwin_solib): Update.
1526
1527 2019-07-10  Tom Tromey  <tromey@adacore.com>
1528
1529         * remote-sim.c (struct sim_inferior_data): Add initializers,
1530         constructor, and destructor.
1531         (sim_inferior_data_key): Change type.  Move lower.
1532         (check_for_duplicate_sim_descriptor): Update.
1533         (get_sim_inferior_data): Use new.  Update.
1534         (~sim_inferior_data_cleanup): Rename from
1535         sim_inferior_data_cleanup.  Simplify.
1536         (gdbsim_close_inferior, simulator_command)
1537         (sim_command_completer, _initialize_remote_sim): Update.
1538         (next_pid, INITIAL_PID): Move earlier.
1539
1540 2019-07-10  Tom Tromey  <tromey@adacore.com>
1541
1542         * python/python-internal.h (create_thread_object): Return
1543         gdbpy_ref.
1544         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1545         * python/py-inferior.c (struct threadlist_entry): Add
1546         constructor.
1547         <thread_obj>: Now a gdbpy_ref.
1548         (thread_to_thread_object): Update.
1549         (add_thread_object): Use new.
1550         (delete_thread_object): Use delete.
1551         (infpy_threads): Update.
1552         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1553         GIL.
1554
1555 2019-07-10  Tom Tromey  <tromey@adacore.com>
1556
1557         * valops.c (value_cast): Specialize error message for Ada.
1558
1559 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1560
1561         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1562
1563 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1564
1565         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1566         bpstat_should_step): Return bool, adjust comments.
1567         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1568         bpstat_should_step): Likewise.
1569
1570 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1571
1572         * features/Makefile: Use feature target descriptions for Arm.
1573         * features/arm/arm-core.c: Generate new file.
1574         * features/arm/arm-fpa.c: Likewise.
1575         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1576         * features/arm/arm-m-profile.c: Likewise.
1577         * features/arm/arm-vfpv2.c: Likewise.
1578         * features/arm/arm-vfpv3.c: Likewise.
1579         * features/arm/xscale-iwmmxt.c: Likewise.
1580         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1581
1582 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1583
1584         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1585         ptrace earlier.
1586
1587 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1588
1589         * features/aarch64-pauth.c: Regenerate.
1590
1591 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1592
1593         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1594         bool.
1595         (bpstat_what): Use false instead of 0.
1596
1597 2019-07-09  Pedro Alves  <palves@redhat.com>
1598
1599         * break-catch-throw.c (is_exception_catchpoint): New.
1600         * breakpoint.c (print_one_breakpoint_location): New parameter
1601         'raw_loc'.  Handle it.  Use
1602         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1603         looking at the breakpoint's type.
1604         (print_one_breakpoint): If handling "maint info breakpoints", also
1605         print locations of exception catchpoints.
1606         * breakpoint.h (is_exception_catchpoint): Declare.
1607
1608 2019-07-09  Pedro Alves  <palves@redhat.com>
1609
1610         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1611         "addr" field.
1612         (allocate_location_exception_catchpoint): New.
1613         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1614         (initialize_throw_catchpoint_ops): Install
1615         allocate_location_exception_catchpoint as allocate_location
1616         method.
1617         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1618         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1619         bp_loc_other.
1620         (breakpoint_address_is_meaningful): Delete.
1621         (bl_address_is_meaningful): New.
1622         (breakpoint_locations_match): Adjust comment.
1623         (bp_location_from_bp_type): New, factored out of...
1624         (bp_location::bp_location(breakpoint *)): ... this.
1625         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1626         factored out of...
1627         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1628         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1629         breakpoint_address_is_meaningful.
1630         (bp_locations_compare): Adjust comment.
1631         (update_global_location_list): Use bl_address_is_meaningful
1632         instead of breakpoint_address_is_meaningful.
1633         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1634         explicit.
1635         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1636         * python/py-breakpoint.c (bppy_get_location): No longer check
1637         whether location is null.
1638
1639 2019-07-09  Pedro Alves  <palves@redhat.com>
1640
1641         PR c++/15468
1642         * breakpoint.c (print_one_breakpoint_location): Remove
1643         single-location assert.
1644
1645 2019-07-09  Tom Tromey  <tom@tromey.com>
1646
1647         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1648         * configure: Rebuild.
1649         * configure.ac: Change common to gdbsupport.
1650         * gdbsupport: Rename from common.
1651         * acinclude.m4: Change common to gdbsupport.
1652         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1653         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1654         gdbsupport.
1655         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1656         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1657         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1658         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1659         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1660         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1661         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1662         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1663         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1664         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1665         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1666         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1667         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1668         coff-pe-read.c, command.h, compile/compile-c-support.c,
1669         compile/compile-c.h, compile/compile-cplus-symbols.c,
1670         compile/compile-cplus-types.c, compile/compile-cplus.h,
1671         compile/compile-loc2c.c, compile/compile.c, completer.c,
1672         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1673         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1674         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1675         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1676         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1677         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1678         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1679         features/aarch64-core.c, features/aarch64-fpu.c,
1680         features/aarch64-pauth.c, features/aarch64-sve.c,
1681         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1682         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1683         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1684         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1685         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1686         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1687         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1688         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1689         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1690         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1691         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1692         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1693         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1694         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1695         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1696         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1697         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1698         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1699         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1700         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1701         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1702         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1703         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1704         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1705         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1706         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1707         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1708         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1709         minsyms.c, mips-linux-tdep.c, namespace.h,
1710         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1711         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1712         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1713         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1714         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1715         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1716         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1717         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1718         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1719         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1720         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1721         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1722         procfs.c, producer.c, progspace.h, psymtab.h,
1723         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1724         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1725         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1726         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1727         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1728         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1729         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1730         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1731         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1732         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1733         target-memory.c, target.c, target.h, target/waitstatus.c,
1734         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1735         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1736         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1737         unittests/array-view-selftests.c,
1738         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1739         unittests/common-utils-selftests.c,
1740         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1741         unittests/format_pieces-selftests.c,
1742         unittests/function-view-selftests.c,
1743         unittests/lookup_name_info-selftests.c,
1744         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1745         unittests/mkdir-recursive-selftests.c,
1746         unittests/observable-selftests.c,
1747         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1748         unittests/parse-connection-spec-selftests.c,
1749         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1750         unittests/scoped_fd-selftests.c,
1751         unittests/scoped_mmap-selftests.c,
1752         unittests/scoped_restore-selftests.c,
1753         unittests/string_view-selftests.c, unittests/style-selftests.c,
1754         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1755         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1756         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1757         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1758         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1759         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1760
1761 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1762
1763         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1764         bool value.
1765         (decode_digits_ordinary): Set explicit_line field in sal.
1766         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1767         symtab_and_line that was set on an explicit line number in
1768         assembler code.  Do always update the recorded symtab and line if
1769         we do skip the prologue.
1770
1771 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1772
1773         * breakpoint.c (set_breakpoint_location_function): Remove
1774         explicit_loc parameter.
1775         (momentary_breakpoint_from_master): Update call to
1776         set_breakpoint_location_function.
1777         (add_location_to_breakpoint): Likewise.
1778
1779 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1780
1781         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1782         required features based on default bfd type when no specific bfd
1783         is present.
1784
1785 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1786
1787         * NEWS: Mention that GDB printf and eval commands can now print
1788         C-style and Ada-style convenience var strings without
1789         calling the inferior.
1790         * printcmd.c (printf_c_string): Locally print GDB internal var
1791         instead of transiting via the inferior.
1792         (printf_wide_c_string): Likewise.
1793
1794 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1795
1796         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1797
1798 2019-07-04  Tom Tromey  <tom@tromey.com>
1799
1800         PR tui/24724:
1801         * tui/tui-winsource.c (tui_clear_source_content): Update.
1802         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1803         (tui_update_breakpoint_info): Update.
1804         (tui_set_exec_info_content): Update.
1805         * tui/tui-source.c (tui_set_source_content_nil): Update.
1806         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1807         has_break.
1808         * tui/tui-data.h (enum tui_bp_flag): New.
1809         (tui_bp_flags): New enum flags type.
1810         (struct tui_source_element) <break_mode>: Change type.  Rename
1811         from has_break.
1812         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1813         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1814         constants.
1815         * tui/tui-winsource.h: Fix comment.
1816
1817 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1818
1819         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1820         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1821         (store_fpregs_to_thread)
1822         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1823         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1824         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1825         (IWMMXT_REGS_SIZE): Add define.
1826         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1827         (fetch_vfp_regs, store_vfp_regs)
1828         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1829         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1830
1831 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1832
1833         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1834         defines.
1835         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1836         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1837         (ARM_INT_REGISTER_SIZE): ...to this.
1838         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1839         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1840         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1841         (arm_linux_collect_gregset, supply_nwfpe_register)
1842         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1843         defines.
1844         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1845         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1846         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1847         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1848         (arm_return_in_memory, arm_store_return_value)
1849         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1850         (arm_record_ld_st_multiple): Likewise.
1851         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1852         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1853
1854 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1855
1856         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1857         AARCH64_DISPLACED_MODIFIED_INSNS.
1858         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1859         (aarch64_displaced_step_copy_insn): Likewise.
1860         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1861         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1862         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1863         ARM_DISPLACED_MODIFIED_INSNS.
1864         * arm-tdep.c (arm_gdbarch_init): Likewise.
1865         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1866         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1867         (struct arm_displaced_step_closure): Use
1868         ARM_DISPLACED_MODIFIED_INSNS.
1869
1870 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1871
1872         * features/Makefile: Remove unused xml files.
1873         * features/aarch64.xml: Remove.
1874         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1875         * features/i386/amd64-avx-avx512.xml: Remove.
1876         * features/i386/amd64-avx-linux.xml: Remove.
1877         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1878         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1879         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1880         * features/i386/amd64-avx-mpx.xml: Remove.
1881         * features/i386/amd64-avx.xml: Remove.
1882         * features/i386/amd64-linux.xml: Remove.
1883         * features/i386/amd64-mpx-linux.xml: Remove.
1884         * features/i386/amd64-mpx.xml: Remove.
1885         * features/i386/amd64.xml: Remove.
1886         * features/i386/i386-avx-avx512-linux.xml: Remove.
1887         * features/i386/i386-avx-avx512.xml: Remove.
1888         * features/i386/i386-avx-linux.xml: Remove.
1889         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1890         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1891         * features/i386/i386-avx-mpx-linux.xml: Remove.
1892         * features/i386/i386-avx-mpx.xml: Remove.
1893         * features/i386/i386-avx.xml: Remove.
1894         * features/i386/i386-linux.xml: Remove.
1895         * features/i386/i386-mmx-linux.xml: Remove.
1896         * features/i386/i386-mmx.xml: Remove.
1897         * features/i386/i386-mpx-linux.xml: Remove.
1898         * features/i386/i386-mpx.xml: Remove.
1899         * features/i386/i386.xml: Remove.
1900         * features/i386/x32-avx-avx512-linux.xml: Remove.
1901         * features/i386/x32-avx-linux.xml: Remove.
1902         * features/i386/x32-linux.xml: Remove.
1903
1904 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1905
1906         * regformats/aarch64.dat: Remove.
1907         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1908         * regformats/i386/amd64-avx-linux.dat: Remove.
1909         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1910         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1911         * regformats/i386/amd64-linux.dat: Remove.
1912         * regformats/i386/amd64-mpx-linux.dat: Remove.
1913         * regformats/i386/amd64.dat: Remove.
1914         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1915         * regformats/i386/i386-avx-linux.dat: Remove.
1916         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1917         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1918         * regformats/i386/i386-linux.dat: Remove.
1919         * regformats/i386/i386-mmx-linux.dat: Remove.
1920         * regformats/i386/i386-mpx-linux.dat: Remove.
1921         * regformats/i386/i386.dat: Remove.
1922         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1923         * regformats/i386/x32-avx-linux.dat: Remove.
1924         * regformats/i386/x32-linux.dat: Remove.
1925
1926 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1927
1928         * aarch64-tdep.c: Remove xml self tests.
1929         * amd64-linux-tdep.c: Likewise.
1930         * amd64-tdep.c: Likewise.
1931         * i386-linux-tdep.c: Likewise.
1932         * i386-tdep.c: Likewise.
1933
1934 2019-07-03  Pedro Alves  <palves@redhat.com>
1935
1936         PR cli/24732
1937         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1938         (pipe_cmd_option_defs): New.
1939         (make_pipe_cmd_options_def_group): New.
1940         (pipe_command): Use gdb::option::process_options.
1941         (pipe_command_completer): New function.
1942         (_initialize_cli_cmds): Install completer for "pipe" command.
1943
1944 2019-07-03  Pedro Alves  <palves@redhat.com>
1945
1946         * cli/cli-option.c (union option_value) <string>: New field.
1947         (struct option_def_and_value): Add ctor, move ctor, dtor and
1948         use DISABLE_COPY_AND_ASSIGN.
1949         (option_def_and_value::clear_value): New.
1950         (parse_option, save_option_value_in_ctx, get_val_type_str)
1951         (add_setshow_cmds_for_options): Handle var_string.
1952         * cli-option.h (union option_def::var_address) <string>: New
1953         field.
1954         (struct string_option_def): New.
1955         * maint-test-options.c (struct test_options_opts): Add default
1956         ctor and use DISABLE_COPY_AND_ASSIGN.
1957         <string_opt>: New field.
1958         (test_options_opts::~test_options_opts): New.
1959         (test_options_opts::dump): Also dump "-string".
1960         (test_options_option_defs): Install "string.
1961
1962 2019-07-03  Pedro Alves  <palves@redhat.com>
1963
1964         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1965         option_value with a null enumeration.
1966         (complete_options): Save the option values in the context.
1967         (save_option_value_in_ctx): New, factored out from ...
1968         (process_options): ... here.
1969         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1970         of the function.
1971         * maint-test-options.c (test_options_opts::dump): New, factored
1972         out from ...
1973         (maintenance_test_options_command_mode): ... here.
1974         (maintenance_test_options_command_completion_result): Delete.
1975         (maintenance_test_options_command_completion_text): Update
1976         comment.
1977         (maintenance_show_test_options_completion_result): Change
1978         prototype.  Just print
1979         maintenance_test_options_command_completion_text.
1980         (save_completion_result): New.
1981         (maintenance_test_options_completer_mode): Pass options context to
1982         complete_options, and then save a dump.
1983         (_initialize_maint_test_options): Use add_cmd to install "maint
1984         show test-options-completion-result".
1985
1986 2019-07-03  Pedro Alves  <palves@redhat.com>
1987
1988         * NEWS (New commands): Mention "with" and "maint with".
1989         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1990         (with_command, with_command_completer): New.
1991         (pipe_command): Adjust to new repeat_previous
1992         interface.
1993         (_initialize_cli_cmds): Install the "with" command and its "w"
1994         alias.
1995         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1996         declarations.
1997         * cli/cli-setshow.c (parse_cli_var_uinteger)
1998         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1999         argument strings for all var_types.
2000         (get_setshow_command_value_string): New, factored out from ...
2001         (do_show_command): ... this.
2002         * cli/cli-setshow.h: Include <string>.
2003         (get_setshow_command_value_string): Declare.
2004         * command.h (repeat_previous): Now returns const char *.  Adjust
2005         comment.
2006         * maint.c: Include "cli/cli-cmds.h".
2007         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2008         (_initialize_maint_cmds): Register the "maintenance with" command.
2009         * top.c (repeat_previous): Move bits from pipe_command here:
2010         Return the saved command line, if any; error out if there's no
2011         command to relaunch.
2012
2013 2019-07-03  Pedro Alves  <palves@redhat.com>
2014
2015         * NEWS (New commands): Mention "maint set/show test-settings"
2016         instead of "maint test-settings".
2017         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2018         (maintenance_test_settings_set_list): Rename to ...
2019         (maintenance_set_test_settings_list): ... this.
2020         (maintenance_test_settings_show_list): Rename to  ...
2021         (maintenance_show_test_settings_list): ... this.
2022         (maintenance_test_settings_cmd): Delete.
2023         (maintenance_test_settings_set_cmd): ...
2024         (maintenance_set_test_settings_cmd): ... this.
2025         (maintenance_test_settings_show_cmd): ...
2026         (maintenance_show_test_settings_cmd): ... this.
2027         (maintenance_test_settings_show_value_cmd):
2028         (maintenance_show_test_settings_value_cmd): ... this.
2029         (_initialize_maint_test_settings): No longer install the "maint
2030         test-settings" prefix command.  Rename "maint test-settings set"
2031         to "maint set test-settings", and "maint test-settings show" to
2032         "maint show test-settings".  Adjust all subcommands.
2033
2034 2019-07-03  Pedro Alves  <palves@redhat.com>
2035
2036         * maint-test-settings.c: Fix file's intro comment.  Replace all
2037         references to "test-options" with references to "test-settings",
2038         in comments.
2039
2040 2019-07-03  Pedro Alves  <palves@redhat.com>
2041
2042         * maint-test-settings.c (maintenance_test_settings_xxx)
2043         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2044         New.
2045         (maintenance_test_settings_enums): Use them.
2046         (maintenance_test_settings_enum): Default to
2047         maintenance_test_settings_xxx.
2048         (_initialize_maint_test_settings): Initialize
2049         MAINTENANCE_TEST_SETTINGS_FILENAME.
2050
2051 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2052
2053         * breakpoint.h (remove_breakpoints_inf): Change return type to
2054         void, move function documentation here.
2055         * breakpoint.c (remove_breakpoints_inf): Change return type to
2056         void, move function documentation to header.
2057
2058 2019-07-02  Pedro Alves  <palves@redhat.com>
2059
2060         * NEWS (Completion improvements): Mention "info threads".
2061         * thread.c (struct info_threads_opts, info_threads_option_defs)
2062         (make_info_threads_options_def_group): New.
2063         (info_threads_command): Use gdb::option::process_options.
2064         (info_threads_command_completer): New.
2065         (_initialize_thread): Use gdb::option::build_help to build the
2066         help text for "info threads".
2067
2068 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2069
2070         * defs.h (generic_load): Move from here...
2071         * symfile.h (generic_load): ... to here.  Rename name parameter
2072         to args.
2073         * symfile.c (generic_load): Add comment.
2074
2075 2019-07-01  Tom Tromey  <tromey@adacore.com>
2076
2077         * dwarf2read.c
2078         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2079         declaration of without_params.  Fix formatting.
2080
2081 2019-07-01  Tom Tromey  <tromey@adacore.com>
2082
2083         * ada-exp.y (find_primitive_type): Update.
2084         * ada-lang.h (ada_lookup_symbol): Update.
2085         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2086         parameter.
2087         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2088
2089 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2090
2091         PR breakpoints/24541
2092         * gdbarch.c: Regenerate.
2093         * gdbarch.h: Regenerate.
2094         * gdbarch.sh: Add 'stap_adjust_register'.
2095         * i386-tdep.c: Include '<unordered_set>'.
2096         (i386_stap_adjust_register): New function.
2097         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2098         * stap-probe.c (stap_parse_register_operand): Call
2099         'gdbarch_stap_adjust_register'.
2100
2101 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2102
2103         PR python/24742
2104         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2105         * python/python.c (do_start_initialization): Use 'xmalloc'
2106         instead of 'PyMem_Malloc'.
2107
2108 2019-06-28  Tom Tromey  <tromey@adacore.com>
2109
2110         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2111         for Ada.
2112
2113 2019-06-27  Tom Tromey  <tromey@adacore.com>
2114
2115         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2116         objfile_key.
2117         (arm_find_mapping_symbol, arm_record_special_symbol)
2118         (_initialize_arm_tdep): Update.
2119         (arm_objfile_data_free): Remove.
2120
2121 2019-06-27  Tom Tromey  <tromey@adacore.com>
2122
2123         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2124         to cp_print_static_field.
2125
2126 2019-06-26  Tom Tromey  <tromey@adacore.com>
2127
2128         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2129         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2130         declare.
2131
2132 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2133
2134         * features/aarch64-core.c (create_feature_aarch64_core):
2135         Regenerate.
2136         * features/aarch64-core.xml: Add cpsr flags.
2137
2138 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2139
2140         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2141         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2142
2143 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2144
2145         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2146         field.
2147         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2148         use.
2149         (arm_record_special_symbol): Don't insert new symbol in sorted
2150         position, push it at the end.
2151
2152 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2153
2154         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2155         (arm_mapping_symbol_s): Remove.
2156         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2157         (arm_mapping_symbol_vec): New typedef.
2158         (struct arm_per_objfile): Add constructor.
2159         <section_maps>: Change type to
2160         std::unique_ptr<arm_mapping_symbol_vec[]>.
2161         (arm_compare_mapping_symbols): Remove.
2162         (arm_find_mapping_symbol): Adjust to section_maps type change.
2163         (arm_objfile_data_free): Call delete on arm_per_objfile.
2164         (arm_record_special_symbol): Adjust to section_maps type change.
2165         Allocate arm_per_objfile with new.
2166
2167 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2168
2169         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2170         with the command prefix.
2171
2172 2019-06-25  Tom Tromey  <tom@tromey.com>
2173
2174         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2175         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2176
2177 2019-06-25  Tom Tromey  <tom@tromey.com>
2178
2179         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2180         type.
2181         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2182         protected.
2183
2184 2019-06-25  Tom Tromey  <tom@tromey.com>
2185
2186         * tui/tui-winsource.c
2187         (tui_source_window_base::set_is_exec_point_at): Add check against
2188         LOA_ADDRESS.
2189
2190 2019-06-25  Tom Tromey  <tom@tromey.com>
2191
2192         * tui/tui-source.c (tui_set_source_content): Don't check before
2193         xfree.
2194         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2195
2196 2019-06-25  Tom Tromey  <tom@tromey.com>
2197
2198         * tui/tui-winsource.h (tui_update_source_window_as_is)
2199         (tui_alloc_source_buffer, tui_line_is_displayed)
2200         (tui_addr_is_displayed): Change type of win_info.
2201         * tui/tui-winsource.c (tui_update_source_window_as_is)
2202         (tui_clear_source_content, tui_show_source_line)
2203         (tui_show_source_content, tui_source_window_base::refill)
2204         (tui_source_window_base::set_is_exec_point_at)
2205         (tui_source_window_base::set_is_exec_point_at)
2206         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2207         (tui_alloc_source_buffer, tui_line_is_displayed)
2208         (tui_addr_is_displayed): Change type of win_info.  Update.
2209         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2210         (tui_source_window_base::do_make_visible_with_new_height):
2211         Update.
2212         * tui/tui-source.c (tui_set_source_content)
2213         (tui_set_source_content_nil)
2214         (tui_source_window::do_scroll_vertical): Update.
2215         * tui/tui-layout.c (show_layout): Update.
2216         * tui/tui-disasm.c (tui_set_disassem_content)
2217         (tui_disasm_window::do_scroll_vertical): Update.
2218         * tui/tui-data.h (tui_win_content): Remove.
2219         (struct tui_gen_win_info) <content, content_size>: Remove.
2220         (struct tui_source_element): Add initializers and destructor.
2221         (union tui_which_element, struct tui_win_element): Remove.
2222         (struct tui_source_window_base) <content>: New field.
2223         (struct tui_data_window): Remove destructor.
2224         (tui_alloc_content, tui_free_win_content)
2225         (tui_free_all_source_wins_content): Don't declare.
2226         * tui/tui-data.c (tui_initialize_static_data): Update.
2227         (init_content_element, tui_alloc_content): Remove.
2228         (~tui_gen_win_info): Update.
2229         (~tui_data_window, tui_free_all_source_wins_content)
2230         (tui_free_win_content, free_content, free_content_elements):
2231         Remove.
2232
2233 2019-06-25  Tom Tromey  <tom@tromey.com>
2234
2235         * tui/tui-winsource.h (tui_clear_source_content)
2236         (tui_erase_source_content, tui_show_source_content): Change type
2237         of win_info.
2238         * tui/tui-winsource.c (tui_clear_source_content)
2239         (tui_erase_source_content, tui_show_source_content): Change type
2240         of win_info.
2241         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2242         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2243         win_info.
2244         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2245         win_info.
2246         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2247
2248 2019-06-25  Tom Tromey  <tom@tromey.com>
2249
2250         * tui/tui-winsource.c (tui_clear_source_content)
2251         (tui_source_window_base::set_is_exec_point_at): Update.
2252         * tui/tui-source.c (tui_set_source_content_nil): Update.
2253         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2254         a bool.
2255         * tui/tui-data.c (init_content_element): Update.
2256
2257 2019-06-25  Tom Tromey  <tom@tromey.com>
2258
2259         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2260         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2261         * tui/tui-layout.c (init_and_make_win): Update.
2262         * tui/tui.h (enum tui_win_type): Update.
2263         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2264         tui_win_is_auxillary.
2265         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2266         tui_win_is_auxillary.
2267
2268 2019-06-25  Tom Tromey  <tom@tromey.com>
2269
2270         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2271         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2272         (tui_delete_data_content_windows, tui_display_all_data)
2273         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2274         Update.
2275         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2276         * tui/tui-regs.c (tui_last_regs_line_no)
2277         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2278         (tui_show_registers): Update.
2279         (tui_show_register_group): Return void.  Update.
2280         (tui_display_registers_from, tui_display_reg_element_at_line)
2281         (tui_display_registers_from_line, tui_check_register_values):
2282         Update.
2283         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2284         member.
2285         (struct tui_data_window) <regs_content>: Now a std::vector.
2286         <regs_content_count>: Remove.
2287         (tui_add_content_elements, tui_free_data_content): Don't declare.
2288         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2289         (init_content_element): Remove DATA_WIN case.  Add assert.
2290         (tui_add_content_elements): Remove.
2291         (tui_data_window): Update.
2292         (tui_free_data_content): Remove.
2293         (free_content_elements): Remove DATA_WIN case.
2294
2295 2019-06-25  Tom Tromey  <tom@tromey.com>
2296
2297         * tui/tui-data.c (tui_data_item_window): Update.
2298         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2299         * tui/tui-windata.c (tui_display_all_data)
2300         (tui_display_data_from_line): Update.
2301         (tui_check_data_values): Remove.
2302         * tui/tui-regs.c (tui_show_register_group)
2303         (tui_display_reg_element_at_line): Update.
2304         * tui/tui-hooks.c (tui_register_changed)
2305         (tui_refresh_frame_and_register_information): Call
2306         tui_check_register_values.
2307         * tui/tui-data.h (struct tui_data_window) <data_content,
2308         data_content_count, data_type>: Remove.
2309         (enum tui_data_type): Remove.
2310
2311         * tui/tui-data.c (tui_data_window::clear_detail)
2312         (~tui_data_window): Update.
2313
2314 2019-06-25  Tom Tromey  <tom@tromey.com>
2315
2316         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2317         declare.
2318         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2319         Rename from tui_first_data_item_displayed.  Update.
2320         (tui_data_window::refresh_all)
2321         (tui_data_window::do_scroll_vertical): Update.
2322         * tui/tui-data.h (struct tui_data_window)
2323         <first_data_item_displayed>: Declare new method.
2324
2325 2019-06-25  Tom Tromey  <tom@tromey.com>
2326
2327         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2328         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2329         contents...
2330         (tui_initialize_static_data): ...here.
2331
2332 2019-06-25  Tom Tromey  <tom@tromey.com>
2333
2334         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2335         (tui_display_registers_from, tui_check_register_values): Update.
2336         (tui_display_register): Remove win_info parameter; update.
2337         (tui_get_register): Change type of parameters.
2338         * tui/tui-data.h (struct tui_data_element): Remove.
2339         (union tui_which_element) <data>: Remove.
2340         <data_window>: Change type.
2341         (struct tui_data_item_window): New.
2342         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2343         case.  Add assert.
2344         (~tui_data_item_window): New destructor.
2345         (free_content_elements): Remove DATA_ITEM_WIN case.
2346
2347 2019-06-25  Tom Tromey  <tom@tromey.com>
2348
2349         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2350         Remove.
2351
2352 2019-06-25  Tom Tromey  <tom@tromey.com>
2353
2354         * tui/tui-data.h (struct tui_command_element): Remove.
2355         (union tui_which_element) <command>: Remove.
2356         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2357         assert.
2358         (free_content_elements): Remove CMD_WIN case.
2359
2360 2019-06-25  Tom Tromey  <tom@tromey.com>
2361
2362         * tui/tui-layout.c (tui_set_layout): Update.
2363         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2364         * tui/tui-data.c (layout_def): Update.
2365
2366 2019-06-25  Tom Tromey  <tom@tromey.com>
2367
2368         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2369         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2370         (tui_source_window_base::set_new_height): Update.
2371         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2372         Update.
2373         (tui_set_locator_fullname, tui_set_locator_info)
2374         (tui_show_frame_info): Update.
2375         * tui/tui-source.c (tui_set_source_content)
2376         (tui_source_is_displayed): Update.
2377         * tui/tui-layout.c (show_source_disasm_command, show_data)
2378         (show_source_or_disasm_and_command): Update.
2379         * tui/tui-disasm.c (tui_set_disassem_content)
2380         (tui_get_begin_asm_address): Update.
2381         * tui/tui-data.h (struct tui_locator_element): Remove.
2382         (union tui_which_element) <locator>: Remove.
2383         (struct tui_locator_window): New.
2384         (tui_locator_win_info_ptr): Change return type.
2385         * tui/tui-data.c (_locator): Change type.
2386         (tui_locator_win_info_ptr): Change return type.
2387         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2388         (tui_alloc_content): Add assert.
2389
2390 2019-06-25  Tom Tromey  <tom@tromey.com>
2391
2392         * tui/tui-winsource.c
2393         (tui_exec_info_window::maybe_allocate_content): New method.
2394         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2395         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2396         (make_source_or_disasm_window): Add cast.
2397         * tui/tui-data.h (union tui_which_element) <simple_string>:
2398         Remove.
2399         (struct tui_source_info): New.
2400         (struct tui_source_window_base) <execution_info>: Change type.
2401         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2402         case, and add assert.
2403         (tui_alloc_content): Add assert.
2404
2405 2019-06-25  Tom Tromey  <tom@tromey.com>
2406
2407         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2408         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2409         * tui/tui-data.c (tui_alloc_win_info): Remove.
2410
2411 2019-06-25  Tom Tromey  <tom@tromey.com>
2412
2413         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2414         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2415         can_highlight.
2416
2417 2019-06-25  Tom Tromey  <tom@tromey.com>
2418
2419         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2420         make_visible_with_new_height method.
2421         (tui_win_info::make_visible_with_new_height): New method.
2422         (tui_source_window_base::do_make_visible_with_new_height)
2423         (tui_data_window::do_make_visible_with_new_height)
2424         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2425         (make_visible_with_new_height): Remove.
2426         (tui_resize_all, tui_adjust_win_heights): Use
2427         make_visible_with_new_height method.
2428         * tui/tui-data.h (struct tui_win_info)
2429         <do_make_visible_with_new_height, make_visible_with_new_height>:
2430         New methods.
2431         (struct tui_source_window_base, struct tui_data_window)
2432         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2433         methods.
2434
2435 2019-06-25  Tom Tromey  <tom@tromey.com>
2436
2437         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2438         method.
2439         (update_tab_width): Call update_tab_width method.
2440         * tui/tui-data.h (struct tui_win_info)
2441         (struct tui_source_window_base) <update_tab_width>: New methods.
2442
2443 2019-06-25  Tom Tromey  <tom@tromey.com>
2444
2445         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2446         parameter.
2447         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2448         parameter.
2449         (tui_gen_win_info::make_visible): Update.
2450         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2451         parameter.
2452         * tui/tui-data.h (enum tui_box): New enum.
2453         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2454
2455 2019-06-25  Tom Tromey  <tom@tromey.com>
2456
2457         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2458         init_and_make_win for EXEC_INFO_WIN.
2459         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2460         longer inline.
2461         (struct tui_win_info) <~tui_win_info>: Inline.
2462         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2463         Don't declare.
2464         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2465         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2466         Remove.
2467         (tui_initialize_static_data): Update.
2468         (~tui_gen_win_info): Handle more cleanup here.
2469         (~tui_source_window_base): Delete "execution_info".
2470         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2471
2472 2019-06-25  Tom Tromey  <tom@tromey.com>
2473
2474         * tui/tui-layout.c (make_command_window): Don't set
2475         can_highlight.
2476         (show_source_disasm_command): Call the reset method.
2477         (show_data): Don't set can_highlight.  Call the reset method.
2478         (tui_gen_win_info::reset): Rename from init_gen_win_info
2479         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2480         (show_source_or_disasm_and_command): Call the reset method.
2481         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2482         (struct tui_cmd_window): Set can_highlight.
2483
2484 2019-06-25  Tom Tromey  <tom@tromey.com>
2485
2486         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2487         from make_visible.
2488         (tui_make_visible, tui_make_invisible): Rewrite.
2489         (tui_win_info::make_visible): Remove.
2490         (tui_source_window_base::make_visible): Update.
2491         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2492         method.  Moved from...
2493         (struct tui_win_info) <make_visible>: ...here.
2494
2495 2019-06-25  Tom Tromey  <tom@tromey.com>
2496
2497         * tui/tui-winsource.c
2498         (tui_source_window_base::do_scroll_horizontal): Remove direction
2499         parameter.
2500         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2501         direction parameter.
2502         * tui/tui-win.c (tui_win_info::forward_scroll)
2503         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2504         (tui_win_info::right_scroll): Update.
2505         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2506         direction parameter.
2507         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2508         direction parameter.
2509         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2510         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2511         Remove direction parameter.
2512         (struct tui_source_window_base, struct tui_source_window)
2513         (struct tui_disasm_window, struct tui_data_window)
2514         (struct tui_cmd_window): Update.
2515
2516 2019-06-25  Tom Tromey  <tom@tromey.com>
2517
2518         * tui/tui-winsource.h (tui_set_exec_info_content)
2519         (tui_show_exec_info_content, tui_erase_exec_info_content)
2520         (tui_clear_exec_info_content, tui_update_exec_info): Change
2521         argument to tui_source_window_base.
2522         * tui/tui-winsource.c (tui_set_exec_info_content)
2523         (tui_show_exec_info_content, tui_erase_exec_info_content)
2524         (tui_clear_exec_info_content, tui_update_exec_info): Change
2525         argument to tui_source_window_base.
2526
2527 2019-06-25  Tom Tromey  <tom@tromey.com>
2528
2529         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2530         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2531
2532 2019-06-25  Tom Tromey  <tom@tromey.com>
2533
2534         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2535         check.
2536
2537 2019-06-25  Tom Tromey  <tom@tromey.com>
2538
2539         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2540         type to void.
2541         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2542         type to void.
2543         * tui/tui-source.c (tui_set_source_content): Update.
2544         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2545
2546 2019-06-25  Tom Tromey  <tom@tromey.com>
2547
2548         * tui/tui-win.c (window_name_completer, tui_set_focus)
2549         (tui_all_windows_info): Use name method.
2550         * tui/tui-data.h (struct tui_gen_win_info)
2551         (struct tui_source_window, struct tui_disasm_window)
2552         (struct tui_data_window, struct tui_cmd_window) <name>: New
2553         method.
2554         (tui_win_name): Don't declare.
2555         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2556         (tui_win_name): Remove.
2557
2558 2019-06-25  Tom Tromey  <tom@tromey.com>
2559
2560         * tui/tui-winsource.h (tui_update_source_window)
2561         (tui_update_source_window_as_is): Change parameter type.
2562         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2563         to be a tui_source_window_base.
2564         (tui_update_source_window_as_is): Likewise.
2565         * tui/tui-win.c (make_visible_with_new_height): Update.
2566
2567 2019-06-25  Tom Tromey  <tom@tromey.com>
2568
2569         * tui/tui-winsource.c (tui_erase_source_content)
2570         (tui_show_source_content, tui_show_exec_info_content)
2571         (tui_erase_exec_info_content): Use refresh_window method.
2572         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2573         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2574         from tui_refresh_win.
2575         (tui_data_window::refresh_window): New method.
2576         (tui_win_info::refresh, tui_source_window_base::refresh)
2577         (tui_refresh_all): Use refresh_window method.
2578         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2579         method.
2580         * tui/tui-regs.c (tui_display_register): Call refresh_window
2581         method.
2582         * tui/tui-layout.c (show_source_disasm_command)
2583         (show_source_or_disasm_and_command): Call refresh_window method.
2584         * tui/tui-data.h (struct tui_gen_win_info)
2585         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2586         New method.
2587
2588 2019-06-25  Tom Tromey  <tom@tromey.com>
2589
2590         * tui/tui.c (tui_rl_other_window, tui_enable)
2591         (tui_is_window_visible, tui_get_command_dimension): Update.
2592         * tui/tui-winsource.c (tui_update_source_window_as_is)
2593         (tui_clear_source_content, tui_erase_source_content)
2594         (tui_show_source_line, tui_source_window_base::refill)
2595         (tui_source_window_base::do_scroll_horizontal)
2596         (tui_source_window_base::set_is_exec_point_at)
2597         (tui_update_breakpoint_info, tui_set_exec_info_content)
2598         (tui_alloc_source_buffer, tui_line_is_displayed)
2599         (tui_addr_is_displayed): Update.
2600         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2601         (tui_check_and_display_highlight_if_needed)
2602         (tui_win_info::make_visible, tui_win_info::refresh)
2603         (tui_refresh_all): Update.
2604         * tui/tui-windata.c (tui_first_data_item_displayed)
2605         (tui_delete_data_content_windows, tui_erase_data_content)
2606         (tui_display_all_data, tui_data_window::refresh_all)
2607         (tui_check_data_values): Update.
2608         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2609         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2610         (tui_win_info::backward_scroll, tui_refresh_all_win)
2611         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2612         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2613         (tui_source_window_base::set_new_height)
2614         (tui_data_window::set_new_height)
2615         (make_invisible_and_set_new_height)
2616         (make_visible_with_new_height, new_height_ok)
2617         (parse_scrolling_args): Update.
2618         * tui/tui-stack.c (tui_show_frame_info): Update.
2619         * tui/tui-source.c (tui_set_source_content)
2620         (tui_set_source_content_nil, tui_source_is_displayed)
2621         (tui_source_window::do_scroll_vertical): Update.
2622         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2623         (tui_display_registers_from, tui_display_reg_element_at_line)
2624         (tui_check_register_values, tui_reg_command): Update.
2625         * tui/tui-layout.c (tui_default_win_height)
2626         (show_source_disasm_command, show_data, init_and_make_win)
2627         (show_source_or_disasm_and_command): Update.
2628         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2629         (tui_redisplay_readline, tui_mld_flush)
2630         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2631         (tui_getc): Update.
2632         * tui/tui-disasm.c (tui_set_disassem_content)
2633         (tui_disasm_window::do_scroll_vertical): Update.
2634         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2635         Now virtual.
2636         (struct tui_win_info): Derive from tui_gen_win_info.
2637         <~tui_win_info>: Mark as override.
2638         <generic>: Remove member.
2639         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2640         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2641         (~tui_data_window, ~tui_win_info)
2642         (tui_free_all_source_wins_content): Update.
2643         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2644
2645 2019-06-25  Tom Tromey  <tom@tromey.com>
2646
2647         * tui/tui-layout.c (init_and_make_win): Use new.
2648         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2649         destructor, initializers.
2650         (tui_alloc_generic_win_info): Don't declare.
2651         * tui/tui-data.c (_locator): Add argument to constructor.
2652         (source_win, disasm_win): New globals.
2653         (exec_info): Remove.
2654         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2655         Update.
2656         (tui_alloc_generic_win_info): Remove.
2657         (init_content_element): Use new.
2658         (tui_win_info::tui_win_info): Update.
2659         (free_content_elements) <case DATA_WIN>: Use delete.
2660
2661 2019-06-25  Tom Tromey  <tom@tromey.com>
2662
2663         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2664         * tui/tui-windata.c (tui_first_data_item_displayed)
2665         (tui_delete_data_content_windows): Update.
2666         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2667         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2668         (tui_display_registers_from, tui_check_register_values): Update.
2669         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2670         pointer.
2671         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2672         window.
2673         (tui_free_data_content): Update.
2674         (free_content_elements) <case DATA_WIN>: Free the window.
2675
2676 2019-06-25  Tom Tromey  <tom@tromey.com>
2677
2678         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2679         Update.
2680         * tui/tui-layout.c (make_command_window)
2681         (show_source_disasm_command, show_data, init_and_make_win)
2682         (show_source_or_disasm_and_command): Update.
2683         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2684         method.
2685         <can_highight, is_highlighted>: Now bool.
2686         (tui_set_win_highlight): Don't declare.
2687         * tui/tui-data.c (tui_set_win_highlight): Remove.
2688
2689 2019-06-25  Tom Tromey  <tom@tromey.com>
2690
2691         * tui/tui-wingeneral.c (make_visible): Remove check of window
2692         type.
2693
2694 2019-06-25  Tom Tromey  <tom@tromey.com>
2695
2696         * tui/tui-win.c (tui_win_info::max_height)
2697         (tui_cmd_window::max_height): New methods.
2698         (new_height_ok): Call max_height.
2699         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2700         <max_height>: New method.
2701
2702 2019-06-25  Tom Tromey  <tom@tromey.com>
2703
2704         * tui/tui-win.c (tui_source_window_base::set_new_height)
2705         (tui_data_window::set_new_height): New methods.
2706         (make_invisible_and_set_new_height): Call set_new_height method.
2707         * tui/tui-data.h (struct tui_win_info)
2708         (struct tui_source_window_base, struct tui_data_window)
2709         <set_new_height>: New method.
2710
2711 2019-06-25  Tom Tromey  <tom@tromey.com>
2712
2713         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2714         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2715         tui_refresh_data_win.
2716         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2717         method.
2718         (tui_refresh_all_win): Call the refresh_all method.
2719         (tui_set_focus): Likewise.
2720         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2721         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2722         Likewise.
2723
2724 2019-06-25  Tom Tromey  <tom@tromey.com>
2725
2726         * tui/tui-winsource.h (tui_refill_source_window)
2727         (tui_set_is_exec_point_at): Don't declare.
2728         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2729         (tui_source_window_base::refill): Rename from
2730         tui_refill_source_window.
2731         (tui_source_window_base::do_scroll_horizontal): Update.
2732         (tui_source_window_base::set_is_exec_point_at): Rename from
2733         tui_set_is_exec_point_at.
2734         (tui_update_all_breakpoint_info): Update.
2735         * tui/tui-stack.c (tui_show_frame_info): Update.
2736         * tui/tui-layout.c (show_data): Add cast.
2737         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2738         * tui/tui-data.h (struct tui_source_window_base) <refill,
2739         set_is_exec_point_at>: New methods.
2740         (tui_source_windows, tui_add_to_source_windows): Update types.
2741         (tui_add_to_source_windows): Remove redundant declaration.
2742         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2743         (tui_source_windows): Change return type.
2744         (tui_clear_source_windows_detail): Update.
2745         (tui_add_to_source_windows): Change type of parameter.
2746         (tui_free_all_source_wins_content): Update.
2747
2748 2019-06-25  Tom Tromey  <tom@tromey.com>
2749
2750         * tui/tui-wingeneral.c (tui_win_info::refresh)
2751         (tui_source_window_base::refresh): New methods.
2752         (tui_refresh_all): Call the refresh method.
2753         * tui/tui-data.h (struct tui_win_info)
2754         (struct tui_source_window_base) <refresh>: New method.
2755
2756 2019-06-25  Tom Tromey  <tom@tromey.com>
2757
2758         * tui/tui.h (tui_is_window_visible): Return bool.
2759         * tui/tui.c (tui_is_window_visible): Return bool.
2760         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2761         (tui_make_visible, tui_make_invisible)
2762         (tui_win_info::make_visible)
2763         (tui_source_window_base::make_visible, make_all_visible)
2764         (tui_make_all_visible, tui_make_all_invisible): Update.
2765         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2766         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2767         bool.
2768         (struct tui_win_info, struct tui_source_window_base)
2769         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2770         * tui/tui-data.c (tui_init_generic_part): Update.
2771
2772 2019-06-25  Tom Tromey  <tom@tromey.com>
2773
2774         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2775         (tui_source_window_base::make_visible): New methods.
2776         (make_all_visible): Make method call.
2777         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2778         (struct tui_source_window_base, struct tui_cmd_window): Override
2779         make_visible.
2780         (tui_win_is_source_type): Don't declare.
2781         * tui/tui-data.c (tui_win_is_source_type): Remove.
2782
2783 2019-06-25  Tom Tromey  <tom@tromey.com>
2784
2785         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2786         NULL check.
2787
2788 2019-06-25  Tom Tromey  <tom@tromey.com>
2789
2790         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2791         Inline constructor.  Add initializers for members.
2792         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2793         constructors; now inline in class.
2794
2795 2019-06-25  Tom Tromey  <tom@tromey.com>
2796
2797         * tui/tui-regs.c (tui_show_registers): Update.
2798         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2799         bool.
2800         * tui/tui-data.c (tui_data_window::clear_detail)
2801         (tui_data_window): Update.
2802
2803 2019-06-25  Tom Tromey  <tom@tromey.com>
2804
2805         * tui/tui-windata.c (tui_display_all_data)
2806         (tui_display_data_from_line, tui_display_data_from)
2807         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2808         Update.
2809         * tui/tui-regs.c (tui_last_regs_line_no)
2810         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2811         (tui_show_registers, tui_show_register_group)
2812         (tui_display_registers_from, tui_display_reg_element_at_line)
2813         (tui_display_registers_from_line, tui_check_register_values)
2814         (tui_reg_next, tui_reg_prev): Update.
2815         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2816         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2817         tui_data_window.
2818         (struct tui_win_info) <detail>: Remove.  Add new fields from
2819         tui_data_info.
2820         (TUI_DATA_WIN): Add cast.
2821         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2822         (~tui_data_window): Simplify.
2823
2824 2019-06-25  Tom Tromey  <tom@tromey.com>
2825
2826         * tui/tui-layout.c (show_source_disasm_command)
2827         (show_source_or_disasm_and_command): Update.
2828         * tui/tui-io.c (update_cmdwin_start_line)
2829         (tui_redisplay_readline): Update.
2830         * tui/tui-data.h (struct tui_command_info): Remove.
2831         (struct tui_win_info) <detail>: Remove command_info member.
2832         (struct tui_data_window) <start_line>: New member, from
2833         tui_command_info.
2834         (TUI_CMD_WIN): Add casts.
2835
2836 2019-06-25  Tom Tromey  <tom@tromey.com>
2837
2838         * tui/tui-winsource.c (tui_update_source_window)
2839         (tui_refill_source_window)
2840         (tui_source_window_base::do_scroll_horizontal)
2841         (tui_update_breakpoint_info, tui_set_exec_info_content)
2842         (tui_show_exec_info_content, tui_erase_exec_info_content)
2843         (tui_clear_exec_info_content): Update.
2844         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2845         Update.
2846         * tui/tui-win.c (make_invisible_and_set_new_height)
2847         (make_visible_with_new_height): Update.
2848         * tui/tui-source.c (tui_set_source_content)
2849         (tui_show_symtab_source): Update.
2850         * tui/tui-layout.c (extract_display_start_addr)
2851         (show_source_disasm_command, show_data)
2852         (make_source_or_disasm_window)
2853         (show_source_or_disasm_and_command): Update.
2854         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2855         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2856         "gdbarch".
2857         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2858         to tui_source_window_base.
2859         (struct tui_win_info) <detail>: Remove source_info member.
2860         (struct tui_source_window_base) <has_locator>: Inline.
2861         Move contents from tui_source_info; rename has_locator member to
2862         m_has_locator.
2863         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2864         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2865         header file.
2866         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2867         Simplify.
2868         (tui_free_all_source_wins_content): Cast to
2869         tui_source_window_base.
2870
2871 2019-06-25  Tom Tromey  <tom@tromey.com>
2872
2873         * tui/tui-win.c (make_invisible_and_set_new_height)
2874         (make_visible_with_new_height): Call has_locator method.
2875         * tui/tui-layout.c (show_source_disasm_command, show_data)
2876         (show_source_or_disasm_and_command): Update for bool change.
2877         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2878         (tui_win_info) <has_locator>: New method.
2879         (struct tui_source_window_base) <has_locator>: New method.
2880         (tui_win_has_locator): Don't declare.
2881         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2882         from tui_win_has_locator.
2883         (tui_source_window_base): Use false, not FALSE.
2884
2885 2019-06-25  Tom Tromey  <tom@tromey.com>
2886
2887         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2888         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2889         clear_detail method directly.
2890         (tui_clear_win_detail): Remove.
2891
2892 2019-06-25  Tom Tromey  <tom@tromey.com>
2893
2894         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2895         "this", not TUI_DISASM_WIN.
2896
2897 2019-06-25  Tom Tromey  <tom@tromey.com>
2898
2899         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2900         declare.
2901         * tui/tui-winsource.c
2902         (tui_source_window_base::do_scroll_horizontal): Rename from
2903         tui_horizontal_source_scroll.
2904         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2905         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2906         from tui_vertical_data_scroll.
2907         * tui/tui-win.h (tui_scroll): Don't declare.
2908         * tui/tui-win.c (tui_win_info::forward_scroll)
2909         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2910         (tui_win_info::right_scroll): Rename and update.
2911         (tui_scroll_forward_command, tui_scroll_backward_command)
2912         (tui_scroll_left_command, tui_scroll_right_command): Update.
2913         (tui_scroll): Remove.
2914         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2915         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2916         from tui_vertical_source_scroll.
2917         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2918         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2919         from tui_vertical_disassem_scroll.
2920         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2921         do_scroll_horizontal>: New methods.
2922         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2923         Likewise.
2924         (struct tui_source_window_base): Add do_scroll_horizontal.
2925         (struct tui_source_window, struct tui_disasm_window): Add
2926         do_scroll_vertical.
2927         (struct tui_data_window, struct tui_cmd_window): Add
2928         do_scroll_horizontal and do_scroll_vertical.
2929         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2930
2931 2019-06-25  Tom Tromey  <tom@tromey.com>
2932
2933         * tui/tui-data.h (struct tui_source_window_base): New struct.
2934         (struct tui_source_window): Derive from tui_source_window_base.
2935         (struct tui_disasm_window): New struct.
2936         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2937         from tui_source_window::clear_detail.
2938         (tui_source_window_base): Rename from tui_source_window.
2939         (~tui_source_window_base): Rename from ~tui_source_window.
2940         (tui_alloc_win_info): Create a tui_disasm_window.
2941
2942 2019-06-25  Tom Tromey  <tom@tromey.com>
2943
2944         * tui/tui-data.h (struct tui_source_window)
2945         (struct tui_data_window): Declare destructors.
2946         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2947         destructors.
2948         (tui_win_info): Simplify.
2949
2950 2019-06-25  Tom Tromey  <tom@tromey.com>
2951
2952         * tui/tui-winsource.c (tui_display_main)
2953         (tui_update_source_windows_with_addr)
2954         (tui_update_all_breakpoint_info): Update.
2955         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2956         (new_height_ok, parse_scrolling_args): Update.
2957         * tui/tui-stack.c (tui_show_frame_info): Update.
2958         * tui/tui-data.h (struct tui_list): Remove.
2959         (tui_source_windows): Return a reference to a std::vector.
2960         * tui/tui-data.c (source_windows): Now a std::vector.
2961         (tui_source_windows): Change return type.
2962         (tui_clear_source_windows): Rewrite.
2963         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2964         (tui_free_all_source_wins_content): Rewrite.
2965
2966 2019-06-25  Tom Tromey  <tom@tromey.com>
2967
2968         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2969         (struct tui_data_window, struct tui_cmd_window): Declare
2970         clear_detail method.
2971         * tui/tui-data.c (tui_source_window::clear_detail)
2972         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2973         methods.
2974         (tui_clear_win_detail): Simplify.
2975
2976 2019-06-25  Tom Tromey  <tom@tromey.com>
2977
2978         * tui/tui-layout.c (make_source_window, make_disasm_window)
2979         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2980         Return the new window.
2981         (show_source_disasm_command, show_data)
2982         (show_source_or_disasm_and_command): Update.
2983
2984 2019-06-25  Tom Tromey  <tom@tromey.com>
2985
2986         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2987         parameter.  Return the new window.
2988         (show_source_disasm_command): Update and remove NULL check.
2989         (show_source_or_disasm_and_command): Update.
2990
2991 2019-06-25  Tom Tromey  <tom@tromey.com>
2992
2993         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2994
2995 2019-06-25  Tom Tromey  <tom@tromey.com>
2996
2997         * tui/tui-data.h (struct tui_win_info): Make constructor
2998         protected.  Make destructor virtual.  Add initializers.
2999         (tui_source_window, tui_data_window, tui_cmd_window): New
3000         classes.
3001         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3002         constructor.  Add "type" parameter.
3003         (tui_source_window, tui_data_window, tui_cmd_window): New
3004         constructors.
3005         (tui_alloc_win_info): Instantiate the appropriate subclass.
3006
3007 2019-06-25  Tom Tromey  <tom@tromey.com>
3008
3009         * tui/tui-win.c (tui_resize_all): Use delete.
3010         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3011         destructor.
3012         (tui_free_window): Don't declare.
3013         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3014         Update.
3015
3016 2019-06-25  Tom Tromey  <tom@tromey.com>
3017
3018         * tui/tui-data.h (struct tui_win_info): Add constructor.
3019         * tui/tui-data.c (tui_alloc_win_info): Use new.
3020         (tui_free_window): Use delete.
3021
3022 2019-06-22  Tom Tromey  <tom@tromey.com>
3023
3024         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3025         declare.
3026         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3027
3028 2019-06-22  Tom Tromey  <tom@tromey.com>
3029
3030         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3031         declare.
3032         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3033
3034 2019-06-22  Tom de Vries  <tdevries@suse.de>
3035
3036         * dwarf2read.c (create_addrmap_from_aranges)
3037         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3038         instead of '%zu'.
3039
3040 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3041
3042         * dwarf2read.h (dwarf2_section_info_def): Remove.
3043         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3044         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3045         std::vector<dwarf2_section_info>.
3046         (struct dwo_file) <~dwo_file>: Remove.
3047         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3048         types field.
3049         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3050         (dwarf2_read_debug_names): Likewise.
3051         (create_debug_types_hash_table): Change parameter type to
3052         array_view, adjust code accordingly.
3053         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3054         (partial_die_info::fixup): Likewise.
3055         (determine_prefix): Likewise.
3056         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3057
3058 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3059
3060         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3061         gdb_bfd_ref_ptr.
3062         <~dwo_file>: Remove call to gdb_bfd_unref.
3063         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3064         gdb_bfd_ref_ptr::get.
3065
3066 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3067
3068         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3069         type to htab_up.
3070         * dwarf2read.c (struct dwo_file): Initialize fields.
3071         <~dwo_file>: New.
3072         (free_dwo_file): Remove, move content to ~dwo_file.
3073         (struct dwo_file_deleter): Remove.
3074         (dwo_file_up>: Remove custom deleter.
3075         (free_dwo_files): Remove.
3076         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3077         dwo_files.
3078         (process_skeletonless_type_units): Call unique_ptr::get.
3079         (allocate_dwo_file_hash_table): Add deleter to created hash
3080         table.  Change return type to htab_up.
3081         (lookup_dwo_file_slot): Don't memset dwo_file, call
3082         unique_ptr::get.
3083         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3084         (create_dwo_unit_in_dwp_v2): Likewise.
3085         (open_and_init_dwo_file): Likewise.
3086         (free_dwo_file_from_slot): Remove.
3087
3088 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3089
3090         * dwarf2read.h (struct dwarf2_section_info) <readin,
3091         is_virtual>: Change type to bool.
3092         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3093         true instead of 1.
3094
3095 2019-06-19  Tom Tromey  <tom@tromey.com>
3096
3097         * tui/tui-data.h (tui_init_content_element): Don't declare.
3098
3099 2019-06-19  Tom Tromey  <tom@tromey.com>
3100
3101         * tui/tui-data.h (tui_init_win_info): Don't declare.
3102
3103 2019-06-19  Tom de Vries  <tdevries@suse.de>
3104
3105         * dwarf2read.h (abstract_to_concrete): Change type to
3106         std::unordered_map<sect_offset, std::vector<sect_offset>,
3107         gdb::hash_enum<sect_offset>>.
3108
3109 2019-06-19  Tom Tromey  <tromey@adacore.com>
3110
3111         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3112         EVAL_AVOID_SIDE_EFFECTS specially.
3113
3114 2019-06-19  Tom Tromey  <tromey@adacore.com>
3115
3116         * source-cache.c (highlighter): New global.
3117         (source_cache::get_source_lines): Create a highlighter on demand.
3118
3119 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3120
3121         * defs.h (deprecated_interactive_hook): Delete declaration.
3122         * interps.c (clear_interpreter_hooks): Remove use of
3123         deprecated_interactive_hook.
3124         * top.c (deprecated_interactive_hook): Delete definition.
3125         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3126
3127 2019-06-18  Tom de Vries  <tdevries@suse.de>
3128
3129         PR gdb/24515
3130         * dwarf2read.h (abstract_to_concrete): Change type from
3131         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3132         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3133         * dwarf2read.c (read_variable): Update.
3134         (dwarf2_fetch_die_loc_sect_off): Update.
3135
3136 2019-06-17  Tom de Vries  <tdevries@suse.de>
3137
3138         PR gdb/24617
3139         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3140         accessing parent[parent_len - 1].
3141
3142 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3143
3144         PR gdb/24364
3145         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3146         call dtrace_process_dof with NULL dof.
3147
3148 2019-06-16  Tom de Vries  <tdevries@suse.de>
3149
3150         PR gdb/24445
3151         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3152
3153 2019-06-16  Tom Tromey  <tom@tromey.com>
3154
3155         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3156         (make_all_visible): Use address of member.
3157
3158 2019-06-16  Tom Tromey  <tom@tromey.com>
3159
3160         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3161         (tui_free_window, free_content, free_content_elements): Remove
3162         unnecessary cast.
3163         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3164         cast.
3165         * tui/tui-regs.c (tui_show_register_group)
3166         (tui_display_registers_from, tui_display_reg_element_at_line):
3167         Remove unnecessary cast.
3168
3169 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3170
3171         * linux-nat.c (normal_mask): Delete.
3172         (_initialize_linux_nat): Don't initialise normal_mask.
3173
3174 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3175
3176         PR gdb/24445
3177         * dwarf-index-write.h (write_psymtabs_to_index): Add
3178         dwz_basename parameter.
3179         * dwarf-index-write.c (write_gdbindex): Move file writing to
3180         write_gdbindex_1.  Change return type void.
3181         (assert_file_size): Move up, remove filename parameter.
3182         (write_gdbindex_1): New function.
3183         (write_debug_names): Change return type to void, call
3184         assert_file_size.
3185         (struct index_wip_file): New struct.
3186         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3187         file logic to index_wip_file.  Write index for dwz file if
3188         needed.
3189         (save_gdb_index_command): Pass basename of dwz file, if present.
3190         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3191         build-id of dwz file, if present.
3192         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3193         (dwarf2_get_dwz_file): Likewise.
3194         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3195         (dwarf2_get_dwz_file): Likewise.
3196
3197 2019-06-16  Tom Tromey  <tom@tromey.com>
3198
3199         * coffread.c (process_coff_symbol): Use xstrdup.
3200         * value.c (create_internalvar): Use xstrdup.
3201
3202 2019-06-16  Tom Tromey  <tom@tromey.com>
3203
3204         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3205         * breakpoint.c (stopin_command, stopat_command)
3206         (until_break_command, decode_location_default): Remove unnecessary
3207         cast.
3208         * utils.c (subset_compare): Remove unnecessary cast.
3209         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3210         cast.
3211         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3212         cast.
3213         * infcmd.c (path_command): Remove unnecessary cast.
3214         * coffread.c (decode_type): Remove unnecessary cast.
3215         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3216         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3217         * tui/tui-stack.c (tui_show_locator_content)
3218         (tui_show_frame_info): Remove unnecessary cast.
3219         * tui/tui-win.c (tui_scroll_forward_command)
3220         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3221         (parse_scrolling_args): Remove unnecessary cast.
3222         * tui/tui-data.c (init_win_info, tui_del_window)
3223         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3224         (free_content_elements): Remove unnecessary cast.
3225         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3226         unnecessary cast.
3227         * tui/tui-source.c (tui_set_source_content)
3228         (tui_vertical_source_scroll): Remove unnecessary cast.
3229         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3230         cast.
3231         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3232         * tui/tui-regs.c (tui_display_registers_from)
3233         (tui_display_register): Remove unnecessary cast.
3234         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3235         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3236         (make_visible): Remove unnecessary cast.
3237         * tui/tui-winsource.c (tui_erase_source_content)
3238         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3239         unnecessary cast.
3240         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3241         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3242         * stabsread.c (read_type, read_array_type, read_range_type):
3243         Remove unnecessary cast.
3244         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3245         (parse_symbol, parse_type, upgrade_type, parse_external)
3246         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3247         unnecessary cast.
3248         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3249
3250 2019-06-16  Tom Tromey  <tom@tromey.com>
3251
3252         * tui/tui-data.c (tui_alloc_generic_win_info)
3253         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3254         checks.
3255
3256 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3257             Andrew Burgess  <andrew.burgess@embecosm.com>
3258
3259         * f-typeprint.c (f_print_type): Don't return early for not
3260         associated or not allocated types.
3261         (f_type_print_varspec_suffix): Add print_rank parameter and print
3262         ranks of array types in case they dangling.
3263         (f_type_print_base): Add print_rank parameter.
3264
3265 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3266
3267         * NEWS: Mention new MI commands.
3268         * break-catch-throw.c (enum exception_event_kind): Move to
3269         breakpoint.h.
3270         (print_mention_exception_catchpoint): Output text as a single
3271         message.
3272         (catch_exception_command_1): Rename to...
3273         (catch_exception_event): ...this, make non-static, update header
3274         command, and change some parameter types.
3275         (catch_catch_command): Update for changes to
3276         catch_exception_command_1.
3277         (catch_throw_command): Likewise.
3278         (catch_rethrow_command): Likewise.
3279         * breakpoint.c (enum exception_event_kind): Delete.
3280         * breakpoint.h (enum exception_event_kind): Moved here from
3281         break-catch-throw.c.
3282         (catch_exception_event): Declare.
3283         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3284         (mi_cmd_catch_throw): New function.
3285         (mi_cmd_catch_rethrow): New function.
3286         (mi_cmd_catch_catch): New function.
3287         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3288         'catch-catch' entries.
3289         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3290         (mi_cmd_catch_rethrow): Declare.
3291         (mi_cmd_catch_catch): Declare.
3292
3293 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3294
3295         * annotate.c (annotate_source_line): Change return type to void,
3296         update implementation to match.
3297         * annotate.h (annotate_source_line): Change return type to void,
3298         update header comment.
3299         * stack.c (print_frame_info): Don't change what frame information
3300         is printed based on whether annotations are on or not.
3301
3302 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3303
3304         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3305         (annotate_source): Make static.
3306         (annotate_source_line): Moved from source.c and renamed from
3307         identify_source_line.  Update the return type.
3308         * annotate.h (annotate_source): Delete declaration.
3309         (annotate_source_line): Declaration moved from source.h, and
3310         renamed from identify_source_line.  Return type updated.
3311         * source.c (identify_source_line): Moved to annotate.c and renamed
3312         to annotate_source_line.
3313         (info_line_command): Remove check of annotation_level.
3314         * source.h (identify_source_line): Move declaration to annotate.h
3315         and rename to annotate_source_line.
3316         * stack.c: Add 'annotate.h' include.
3317         (print_frame_info): Remove check of annotation_level before
3318         calling annotate_source_line.
3319
3320 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3321
3322         * source-cache.c (source_cache::get_plain_source_lines): Use
3323         open_source_file_with_line_charpos instead of just
3324         open_source_file, remove call to find_source_lines.
3325         (source_cache::get_source_lines): Likewise.
3326         * source.c (find_source_lines): Make static.
3327         (get_filename_and_charpos): Renamed into...
3328         (open_source_file_with_line_charpos): ..this along with changes to
3329         return a scoped_fd, and some other minor clean ups.
3330         (identify_source_line): Use open_source_file_with_line_charpos.
3331         (search_command_helper): Use open_source_file_with_line_charpos
3332         instead of just open_source_file, remove call to
3333         find_source_lines.
3334         * source.h (open_source_file_with_line_charpos): Declare new
3335         function.
3336         (find_source_lines): Delete declaration.
3337
3338 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3339
3340         * source.c (get_filename_and_charpos): Remove fullname
3341         parameter.
3342         (identify_source_line): Update call to get_filename_and_charpos.
3343
3344 2019-06-14  Tom Tromey  <tromey@adacore.com>
3345
3346         PR gdb/24502:
3347         * ui-style.h (skip_ansi_escape): Update comment.
3348         * ui-file.h (class no_terminal_escape_file): New class.
3349         * ui-file.c (no_terminal_escape_file::write)
3350         (no_terminal_escape_file::puts): New methods.
3351         * cli/cli-logging.c (handle_redirections): Use
3352         no_terminal_escape_file.
3353
3354 2019-06-14  Tom Tromey  <tromey@adacore.com>
3355
3356         * NEWS: Move convenience variable news above Python news.
3357
3358 2019-06-14  Tom Tromey  <tom@tromey.com>
3359
3360         * gnulib: Move directory to top-level.
3361         * configure.ac: Don't configure gnulib.
3362         * configure: Rebuild.
3363         * common/common-defs.h: Use new path to gnulib.
3364         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3365         (GNULIB_H): Remove.
3366         (INCGNU): Look in new gnulib location.
3367         (HFILES_NO_SRCDIR): Remove gnulib files.
3368         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3369         (generated_files): Remove GNULIB_H.
3370         ($(LIBGNU), all-lib): Remove targets.
3371         (distclean): Don't mention GNULIB_BUILDDIR.
3372         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3373
3374 2019-06-14  Tom Tromey  <tromey@adacore.com>
3375
3376         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3377         Warn if symbol file does not provide any symbols.
3378
3379 2019-06-14  Tom Tromey  <tromey@adacore.com>
3380
3381         * source.c (find_and_open_source): Respect basenames_may_differ.
3382
3383 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3384
3385         * annotate.c (annotate_breakpoints_invalid): Make use of
3386         scoped_restore_terminal_state.
3387         (annotate_frames_invalid): Likewise.
3388
3389 2019-06-14  Tom Tromey  <tromey@adacore.com>
3390
3391         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3392         allow assignment to an internalvar.
3393
3394 2019-06-14  Tom Tromey  <tromey@adacore.com>
3395
3396         * ada-lex.l: Allow "_" in attribute names.
3397
3398 2019-06-14  Tom Tromey  <tromey@adacore.com>
3399
3400         PR gdb/24653:
3401         * regcache.c (registers_changed): Don't call alloca.
3402         * top.c (execute_command): Don't call alloca.
3403
3404 2019-06-13  Pedro Alves  <palves@redhat.com>
3405
3406         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3407         'expression'.  When parsing an expression, error out if there's
3408         junk after "unlimited".
3409         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3410         (do_set_command): Adjust calls to is_unlimited_literal.
3411
3412 2019-06-13  Pedro Alves  <palves@redhat.com>
3413
3414         * compile/compile.c (make_compile_options_def_group): Add braces
3415         around array_view initializer.
3416         * thread.c (make_thread_apply_all_options_def_group)
3417         (make_thread_apply_all_options_def_group): Likewise.
3418
3419 2019-06-13  Pedro Alves  <palves@redhat.com>
3420
3421         * NEWS (New commands): Mention "maint test-options
3422         require-delimiter", "maint test-options unknown-is-error", "maint
3423         test-options unknown-is-operand" and "maint show
3424         test-options-completion-result".
3425         (New command options, command completion): New section.
3426         (Completion improvements): New section.
3427         Mention that you can abbreviate "unlimited".
3428
3429 2019-06-13  Pedro Alves  <palves@redhat.com>
3430
3431         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3432         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3433         * unittests/cli-utils-selftests.c (test_parse_flags)
3434         (test_parse_flags_qcs): Delete.
3435         (test_cli_utils): Don't call deleted functions.
3436
3437 2019-06-13  Pedro Alves  <palves@redhat.com>
3438
3439         * thread.c: Include "cli/cli-option.h".
3440         (tp_array_compar_ascending): Global.
3441         (tp_array_compar): Delete function.
3442         (tp_array_compar_ascending, tp_array_compar_descending): New
3443         functions.
3444         (ascending_option_def, qcs_flag_option_def)
3445         (thr_qcs_flags_option_defs)
3446         (make_thread_apply_all_options_def_group)
3447         (make_thread_apply_options_def_group): New.
3448         (thread_apply_all_command): Use gdb::option::process_options.
3449         (thread_apply_command_completer)
3450         (thread_apply_all_command_completer): New.
3451         (thread_apply_command): Use gdb::option::process_options.
3452         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3453         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3454         to generate help text of "thread apply".  Adjust "taas"'s help.
3455         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3456         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3457
3458 2019-06-13  Pedro Alves  <palves@redhat.com>
3459
3460         * thread.c (thread_apply_command): Check for invalid TID with
3461         isdigit instead of !isalpha.
3462
3463 2019-06-13  Pedro Alves  <palves@redhat.com>
3464
3465         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3466         (validate_flags_qcs): New.
3467         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3468         (validate_flags_qcs): Declare.
3469         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3470         (make_frame_apply_options_def_group): New.
3471         (frame_apply_command_count): Process options with
3472         gdb::option::process_options.
3473         (frame_apply_completer): New.
3474         (frame_apply_level_completer, frame_apply_all_completer)
3475         (frame_apply_completer): New.
3476         (_initialize_stack): Update help of "frame apply", "frame apply
3477         level", "frame apply all" and "faas" to mention supported options
3478         and install command completers.
3479         * stack.h (frame_apply_all_completer): Declare.
3480         * thread.c: Include "stack.h".
3481         (tfaas_command): Add "--".
3482         (_initialize_thread): Update help "tfaas" to mention supported
3483         options and install command completer.
3484
3485 2019-06-13  Pedro Alves  <palves@redhat.com>
3486
3487         * completer.c (complete_nested_command_line): New.
3488         (gdb_completion_word_break_characters_throw): Add assertion.
3489         * completer.h (complete_nested_command_line): Declare.
3490
3491 2019-06-13  Pedro Alves  <palves@redhat.com>
3492
3493         * stack.c (parse_backtrace_qualifiers): New.
3494         (backtrace_command): Use it.
3495         (backtrace_command_completer): Complete on qualifiers.
3496
3497 2019-06-13  Pedro Alves  <palves@redhat.com>
3498
3499         * frame.c: Include "cli/cli-option.h.
3500         (user_set_backtrace_options): New.
3501         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3502         Delete.
3503         (get_prev_frame): Adjust.
3504         (boolean_option_def, uinteger_option_def)
3505         (set_backtrace_option_defs): New.
3506         (_initialize_frame): Adjust and use
3507         gdb::option::add_setshow_cmds_for_options to install "set
3508         backtrace past-main" and "set backtrace past-entry".
3509         * frame.h: Include "cli/cli-option.h".
3510         (struct frame_print_options): Forward declare.
3511         (print_frame_arguments_all, print_frame_arguments_scalars)
3512         (print_frame_arguments_none): Declare.
3513         (print_entry_values): Delete declaration.
3514         (struct frame_print_options, user_frame_print_options): New.
3515         (struct set_backtrace_options): New.
3516         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3517         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3518         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3519         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3520         (list_args_or_locals): Add frame_print_options parameter.
3521         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3522         * python/py-framefilter.c (enumerate_args): Pass down
3523         USER_FRAME_PRINT_OPTIONS.
3524         * stack.c: Include "cli/cli-option.h".
3525         (print_frame_arguments_all, print_frame_arguments_scalars)
3526         (print_frame_arguments_none): Declare.
3527         (print_raw_frame_arguments, print_entry_values): Delete.
3528         (user_frame_print_options): New.
3529         (boolean_option_def, enum_option_def, frame_print_option_defs):
3530         New.
3531         (struct backtrace_cmd_options): New.
3532         (bt_flag_option_def): New.
3533         (backtrace_command_option_defs): New.
3534         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3535         (print_frame_arg, read_frame_arg, print_frame_args)
3536         (print_frame_info, print_frame): Add frame_print_options parameter
3537         and use it.
3538         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3539         (backtrace_command_1): Add frame_print_options and
3540         backtrace_cmd_options parameters and use them.
3541         (make_backtrace_options_def_group): New.
3542         (backtrace_command): Process command options with
3543         gdb::option::process_options.
3544         (backtrace_command_completer): New.
3545         (_initialize_stack): Extend "backtrace"'s help to mention
3546         supported options.  Install completer for "backtrace".
3547         Install some settings commands with add_setshow_cmds_for_options.
3548
3549 2019-06-13  Pedro Alves  <palves@redhat.com>
3550
3551         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3552         and that "set/show print raw frame-arguments" are now deprecated.
3553
3554         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3555         command.
3556         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3557         * stack.c (_initialize_stack): Install "set/show print
3558         raw-frame-arguments", and deprecate "set/show print raw
3559         frame-arguments".
3560         * valprint.c (_initialize_valprint): Deprecate "set/show print
3561         raw".
3562
3563 2019-06-13  Pedro Alves  <palves@redhat.com>
3564
3565         * compile/compile.c (struct compile_options): New.
3566         (compile_flag_option_def, compile_command_option_defs)
3567         (make_compile_options_def_group): New.
3568         (compile_file_command): Handle options with
3569         gdb::option::process_options.
3570         (compile_file_command_completer): New function.
3571         (compile_code_command): Handle options with
3572         gdb::option::process_options.
3573         (compile_code_command_completer): New function.
3574         (_initialize_compiler): Install completers for "compile code" and
3575         "compile file".  Mention available options in "compile code" and
3576         "compile code"'s help.
3577         * completer.c (advance_to_completion_word): New, factored out from
3578         ...
3579         (advance_to_expression_complete_word_point): ... this.
3580         (advance_to_filename_complete_word_point): New.
3581         * completer.h (advance_to_filename_complete_word_point): New
3582         declaration.
3583
3584 2019-06-13  Pedro Alves  <palves@redhat.com>
3585
3586         * compile/compile.c: Include "cli/cli-option.h".
3587         (compile_print_value): Scope data pointer is now a
3588         value_print_options pointer; adjust.
3589         (compile_print_command): Process options.  Scope data pointer is
3590         now a value_print_options pointer; adjust.
3591         (_initialize_compile): Update "compile print"'s help to include
3592         supported options.  Install a completer for "compile print".
3593         * cp-valprint.c (show_vtblprint, show_objectprint)
3594         (show_static_field_print): Delete.
3595         (_initialize_cp_valprint): Don't install "set print
3596         static-members", "set print vtbl", "set print object" here.
3597         * printcmd.c: Include "cli/cli-option.h" and
3598         "common/gdb_optional.h".
3599         (print_command_parse_format): Rework to fill in a
3600         value_print_options instead of a format_data.
3601         (print_value): Change parameter type from format_data pointer to
3602         value_print_options reference.  Adjust.
3603         (print_command_1): Process options.  Adjust to pass down a
3604         value_print_options.
3605         (print_command_completer): New.
3606         (_initialize_printcmd): Install print_command_completer as
3607         handle_brkchars completer for the "print" command.  Update
3608         "print"'s help to include supported options.
3609         * valprint.c: Include "cli/cli-option.h".
3610         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3611         here from cp-valprint.c.
3612         (boolean_option_def, uinteger_option_def)
3613         (value_print_option_defs, make_value_print_options_def_group):
3614         New.  Use gdb::option::add_setshow_cmds_for_options to install
3615         "set print elements", "set print null-stop", "set print repeats",
3616         "set print pretty", "set print union", "set print array", "set
3617         print address", "set print symbol", "set print array-indexes".
3618         * valprint.h: Include <string> and "cli/cli-option.h".
3619         (make_value_print_options_def_group): Declare.
3620         (print_value): Change parameter type from format_data pointer to
3621         value_print_options reference.
3622         (print_command_completer): Declare.
3623
3624 2019-06-13  Pedro Alves  <palves@redhat.com>
3625
3626         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3627         (COMMON_SFILES): Add maint-test-settings.c.
3628         * cli/cli-decode.c (boolean_enums): New global, factored out from
3629         ...
3630         (add_setshow_boolean_cmd): ... here.
3631         * cli/cli-decode.h (boolean_enums): Declare.
3632         * cli/cli-option.c: New file.
3633         * cli/cli-option.h: New file.
3634         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3635         factored out from ...
3636         (parse_cli_boolean_value(const char *)): ... this.
3637         (is_unlimited_literal): Change parameter type to pointer to
3638         pointer.  Adjust and advance ARG pointer.
3639         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3640         (parse_cli_var_enum): New, factored out from ...
3641         (do_set_command): ... this.  Adjust.
3642         * cli/cli-setshow.h (parse_cli_boolean_value)
3643         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3644         (parse_cli_var_enum): Declare.
3645         * cli/cli-utils.c: Include "cli/cli-option.h".
3646         (get_ulongest): New.
3647         * cli/cli-utils.h (get_ulongest): Declare.
3648         (check_for_argument): New overloads.
3649         * maint-test-options.c: New file.
3650
3651 2019-06-13  Pedro Alves  <palves@redhat.com>
3652
3653         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3654         parse a range if "-" is at the end of the string.
3655
3656 2019-06-13  Pedro Alves  <palves@redhat.com>
3657
3658         * cli/cli-setshow.c (parse_auto_binary_operation)
3659         (parse_cli_boolean_value): Don't allow "o".
3660
3661 2019-06-13  Pedro Alves  <palves@redhat.com>
3662
3663         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3664         * NEWS: Mention maint test-settings KIND.
3665         * maint-test-settings.c: New file.
3666
3667 2019-06-13  Pedro Alves  <palves@redhat.com>
3668
3669         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3670         completer.
3671         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3672         "set" completers.
3673
3674 2019-06-13  Pedro Alves  <palves@redhat.com>
3675
3676         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3677         after item.
3678
3679 2019-06-13  Pedro Alves  <palves@redhat.com>
3680
3681         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3682
3683 2019-06-13  Pedro Alves <palves@redhat.com>
3684
3685         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3686         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3687         call.
3688         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3689         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3690         calls.
3691         (check_for_argument): Skip spaces after argument.
3692
3693 2019-06-13  Pedro Alves  <palves@redhat.com>
3694
3695         * thread.c (thread_apply_command): Adjust TID parsing.
3696         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3697         detected before end of string.
3698         (tid_is_in_list): Error out if LIST is invalid.
3699
3700 2019-06-13  Pedro Alves  <palves@redhat.com>
3701
3702         * completer.c (complete_line_internal_1): Rewind completion word
3703         point.
3704         (completion_tracker::advance_custom_word_point_by): Change
3705         parameter type to int.
3706         * completer.h (completion_tracker::advance_custom_word_point_by):
3707         Likewise.
3708
3709 2019-06-13  Pedro Alves  <palves@redhat.com>
3710
3711         * completer.c (advance_to_completion_word): Handle delimiters.
3712
3713 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3714
3715         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3716
3717 2019-06-11  Tom Tromey  <tom@tromey.com>
3718
3719         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3720         (xmalloc_failed): Move to alloc.c.
3721         * alloc.c: New file.
3722         * Makefile.in (COMMON_SFILES): Add alloc.c.
3723
3724 2019-06-11  Tom Tromey  <tom@tromey.com>
3725
3726         * nat/linux-waitpid.c: Don't include server.h.
3727         (linux_debug): Remove.
3728         (my_waitpid): Update.
3729
3730 2019-06-11  Tom Tromey  <tromey@adacore.com>
3731
3732         * infcall.c (_initialize_infcall): Remove trailing newline from
3733         help.
3734         * user-regs.c (_initialize_user_regs): Remove trailing newline
3735         from help.
3736         * typeprint.c (_initialize_typeprint): Remove trailing newline
3737         from help.
3738         * reverse.c (_initialize_reverse): Remove trailing newlines from
3739         help.
3740         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3741         from help.
3742         * language.c (add_set_language_command): Remove trailing newline
3743         from help.
3744         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3745         help.
3746         * disasm.c (_initialize_disasm): Remove trailing newline from
3747         help.
3748         * top.c (init_main): Remove trailing newline from help.
3749         * interps.c (_initialize_interpreter): Remove trailing newline
3750         from help.
3751         * btrace.c (_initialize_btrace): Remove trailing newlines from
3752         help.
3753         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3754         from help.
3755         * python/python.c (_initialize_python): Remove trailing newline
3756         from help.
3757         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3758         help.
3759         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3760         from help.  Reformat some text.
3761         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3762         from help.
3763         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3764         newline from help.
3765
3766 2019-06-11  Tom Tromey  <tromey@adacore.com>
3767
3768         * darwin-nat.c (darwin_decode_exception_message)
3769         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3770
3771 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3772
3773         * valops.c (value_slice): Check for not allocated or not
3774         associated values.
3775
3776 2019-06-10  Tom de Vries  <tdevries@suse.de>
3777
3778         PR gdb/24618
3779         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3780         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3781         invalid.
3782
3783 2019-06-10  Tom de Vries  <tdevries@suse.de>
3784
3785         PR gdb/24611
3786         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3787         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3788
3789 2019-06-10  Tom de Vries  <tdevries@suse.de>
3790
3791         PR symtab/24545
3792         * symtab.c (struct demangled_name_entry): Add language field.
3793         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3794         static minimal symbol".  Set and use language field.
3795
3796 2019-06-10  Tom Tromey  <tromey@adacore.com>
3797
3798         * ada-lang.c (_initialize_ada_language): Update help text.
3799
3800 2019-06-10  Tom Tromey  <tromey@adacore.com>
3801
3802         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3803         with a newline.
3804         * guile/guile.c (handle_boot_error): Don't end warning with a
3805         newline.
3806         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3807         warning with a newline.
3808         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3809         newline.
3810         (s12z_frame_cache): Likewise.
3811         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3812         a newline.
3813         * solib-svr4.c (disable_probes_interface): Don't end warning with
3814         a newline.
3815         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3816         newline.
3817         * python/python.c (do_finish_initialization): Don't end warning
3818         with a newline.
3819
3820 2019-06-10  Tom Tromey  <tom@tromey.com>
3821
3822         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3823         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3824         gdbpy_enter.
3825
3826 2019-06-10  Tom Tromey  <tromey@adacore.com>
3827
3828         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3829         data.
3830         (elf_new_init): Don't call stabsread_new_init.
3831         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3832         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3833         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3834
3835 2019-06-10  Tom de Vries  <tdevries@suse.de>
3836
3837         PR symtab/16264
3838         PR symtab/24517
3839         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3840
3841 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3842
3843         * source.c (find_and_open_source): Also rewrite relative file
3844         names.
3845
3846 2019-04-26  Amos Bird  <amosbird@gmail.com>
3847
3848         * annotate.c (annotate_thread_exited): Add "thread-exited"
3849         annotation.
3850
3851 2019-06-06  Tom Tromey  <tromey@adacore.com>
3852
3853         * maint.h (class scoped_command_stats): Use
3854         DISABLE_COPY_AND_ASSIGN.
3855         <print_time>: New method.
3856         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3857         print_time.
3858         (scoped_command_stats::print_time): New method.
3859
3860 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3861
3862         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3863         instructions of lengths 6 or 8 bytes.
3864
3865 2019-06-04  Pedro Alves  <palves@redhat.com>
3866
3867         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3868
3869         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3870         * breakpoint.c (condition_completer): Likewise.
3871         * cli/cli-dump.c (scan_expression): Likewise.
3872         * common/filestuff.c (mkdir_recursive): Likewise.
3873         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3874         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3875         (gdb_abspath): Likewise.
3876         * compile/compile-cplus-types.c
3877         (compile_cplus_instance::decl_name): Likewise.
3878         * completer.c (complete_explicit_location):
3879         (signal_completer, reg_or_group_completer_1): Likewise.
3880         * cp-support.c (cp_remove_params_if_any): Likewise.
3881         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3882         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3883         * infcmd.c (strip_bg_char): Likewise.
3884         * linespec.c (copy_token_string): Likewise.
3885         * mi/mi-main.c (output_cores): Likewise.
3886         * psymtab.c (psymtab_search_name):
3887         * symfile.c (test_set_ext_lang_command): Likewise.
3888         * target.c (target_fileio_read_stralloc): Likewise.
3889         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3890         * value.c (complete_internalvar): Likewise.
3891
3892 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3893
3894         Add objfile property to gdb.Type.
3895         * NEWS: Mention Python API addition.
3896         * python/py-type.c (typy_get_objfile): New method.
3897
3898 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3899
3900         * NEWS: Mention the new set|show style [title|highlight].
3901         Mention changes to "show style", "help" and "apropos".
3902
3903 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3904
3905         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3906         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3907         instead of print_help_for_command.
3908         (print_doc_of_command): New function.
3909         (help_list): Add 'apropos -v word' suggestion.
3910         (print_help_for_command): Style the command name using title style.
3911         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3912         (_initialize_cli_cmds): Describe -v in apropos_command help.
3913
3914 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3915
3916         * cli/cli-style.h (cli_style_option): Add name in constructor,
3917         add m_name class member, add constructor with intensity,
3918         add name class function.
3919         (cli_style_option::add_setshow_commands): Remove name argument.
3920         (highlight_style, title_style): New styles.
3921         * cli/cli-style.c (do_show): New function that shows a style
3922         characteristic styling the style name with itself.
3923         (set_style_name): New function.
3924         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3925         Update all callers according to the changes in cli/cli-style.h.
3926         * utils.h (fputs_highlighted): New function.
3927         * utils.c (fputs_highlighted): Likewise.
3928
3929 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3930
3931         * NEWS: Mention new pipe command and new convenience variables.
3932
3933 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3934
3935         * cli/cli-cmds.c (pipe_command): New function.
3936         (_initialize_cli_cmds): Call add_com for pipe_command.
3937         Define | as an alias for pipe.
3938         (exit_status_set_internal_vars): New function.
3939         (shell_escape): Call exit_status_set_internal_vars.
3940         cli/cli-decode.c (find_command_name_length): Recognize | as
3941         a single character command.
3942
3943 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3944
3945         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3946         top.c (execute_command_to_ui_file): New function, mostly a copy
3947         of execute_command_to_string.
3948         (execute_command_to_string): Implement by calling
3949         execute_command_to_ui_file.
3950
3951 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3952
3953         * top.h (saved_command_line): Remove declaration.
3954         * top.c (previous_saved_command_line, previous_repeat_arguments):
3955         New variables.
3956         (saved_command_line): Make static, define together with other
3957         'repeat variables'.
3958         (dont_repeat): Clear repeat_arguments.
3959         (repeat_previous, get_saved_command_line, save_command_line):
3960         New functions.
3961         (gdb_init): Initialize saved_command_line
3962         and previous_saved_command_line.
3963         * main.c (captured_main_1): Remove saved_command_line initialization.
3964         * event-top.c (handle_line_of_input): Update to use
3965         the new 'repeat' related functions instead of direct access to
3966         saved_command_line.
3967         * command.h (repeat_previous, get_saved_command_line,
3968         save_command_line): New declarations.
3969         (dont_repeat): Add comment.
3970
3971 2019-05-30  Tom Tromey  <tromey@adacore.com>
3972
3973         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3974         Fix comment.
3975         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3976
3977 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3978
3979         PR cli/24587
3980         * completer.c (complete): Initialize variable word.
3981
3982 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3983
3984         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3985         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3986         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3987         'body' is NULL to the outter 'if', protecting the '!is_define'
3988         situation as well.
3989
3990 2019-05-29  Tom Tromey  <tromey@adacore.com>
3991
3992         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3993         (dwarf_unknown): New function.
3994         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3995         (dwarf_type_encoding_name): Use dwarf_unknown.
3996
3997 2019-05-29  Tom Tromey  <tromey@adacore.com>
3998
3999         PR c++/20020:
4000         * cp-valprint.c (cp_print_value_fields): Call
4001         cp_print_static_field inside "try".
4002
4003 2019-05-29  Tom Tromey  <tromey@adacore.com>
4004
4005         * inflow.c (struct terminal_info): Add default operator=.
4006         * configure: Rebuild.
4007         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4008         -Wdeprecated-copy-dtor, -Wredundant-move.
4009
4010 2019-05-29  Tom Tromey  <tromey@adacore.com>
4011
4012         * NEWS: Add entry.
4013         * infcmd.c (print_return_value_1): Handle finish_print
4014         option.
4015         (show_print_finish): New function.
4016         (_initialize_infcmd): Add "set/show print finish" commands.
4017         * valprint.c (user_print_options): Initialize new member.
4018         * valprint.h (struct value_print_options) <finish_print>: New
4019         member.
4020
4021 2019-05-28  Tom Tromey  <tromey@adacore.com>
4022
4023         * ada-lang.c (ada_remove_Xbn_suffix)
4024         (find_old_style_renaming_symbol)
4025         (parse_old_style_renaming): Remove.
4026         (ada_find_renaming_symbol): Don't call
4027         find_old_style_renaming_symbol.
4028         (ada_is_renaming_symbol): Rename from
4029         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4030         bool.  Now static.
4031         (ada_read_var_value): Update and simplify.
4032         * ada-exp.y (write_var_or_type): Remove old code.
4033
4034 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4035
4036         * event-top.c: Remove include comment.
4037         * inflow.c (class scoped_ignore_sigttou): Move from here...
4038         * inflow.h (class scoped_ignore_sigttou): ...to here.
4039         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4040         * top.c:  Remove include comment.
4041
4042 2019-05-27  Tom Tromey  <tom@tromey.com>
4043
4044         * NEWS: Fix typo.
4045
4046 2019-05-22  Tom Tromey  <tromey@adacore.com>
4047
4048         * target.c (target_follow_exec): Constify parameter.
4049         * target-delegates.c: Rebuild.
4050         * remote.c (remote_target::follow_exec): Constify parameter.
4051         * infrun.c (follow_exec): Constify parameter.
4052         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4053         (target_follow_exec): Likewise.
4054
4055 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4056
4057         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4058         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4059
4060 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4061
4062         * NEWS: Add debugredirect and testsuite sections.
4063
4064 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4065
4066         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4067         target descriptions using exclusively floating point register name
4068         aliases.
4069
4070 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4071
4072         PR gdb/18644:
4073         * f-lang.c (build_fortran_types): Handle the case where
4074         gdbarch_floatformat_for_type returns a nullptr.
4075
4076 2019-05-21  Tom de Vries  <tdevries@suse.de>
4077
4078         PR cli/24587
4079         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4080
4081 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4082
4083         PR gdb/18644:
4084         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4085         16-byte floats.
4086         * i386-tdep.c (i386_floatformat_for_type): Use
4087         floatformats_ia64_quad for the 16-byte floating point component
4088         within a fortran 32-byte complex number.
4089
4090 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4091
4092         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4093         delete default constructor.
4094         (find_partial_die): Update to return const struct.
4095         (partial_die_parent_scope): Move variable declaration into scope
4096         of its use and change its type to auto.
4097         (guess_partial_die_structure_name): Likewise.
4098         (partial_die_info::fixup): Likewise.
4099
4100 2019-05-17  Tom Tromey  <tromey@adacore.com>
4101
4102         * source.c (find_and_open_source): Remove cast.
4103
4104 2019-05-17  Tom Tromey  <tromey@adacore.com>
4105
4106         * annotate.c (annotate_source): Make "filename" const.
4107         * annotate.h (annotate_source): Use const.
4108
4109 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4110
4111         * disasm.c (set_disassembler_options): Send errors to stderr.
4112
4113 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4114
4115         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4116         (cli_interp_base::set_logging): Check debug_redirect.
4117         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4118         * cli/cli-logging.c (debug_redirect): Add static variable.
4119         (pop_output_files): Add default param.
4120         (handle_redirections): Print debug setting.
4121         (show_logging_command): Likewise.
4122         (_initialize_cli_logging): Add debugredirect command.
4123         * interps.c (current_interp_set_logging): Add debug_redirect
4124         parameter.
4125         * interps.h (set_logging): Add debug_redirect parameter.
4126         (current_interp_set_logging): Likewise.
4127         * mi/mi-common.h: Likewise.
4128         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4129
4130 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4131             Tom Tromey  <tromey@adacore.com>
4132
4133         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4134         directly.
4135         * cli/cli-interp.h (make_logging_output): Remove declaration.
4136         * cli/cli-logging.c (make_logging_output): Remove function.
4137         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4138         directly.
4139         * ui-file.c (tee_file::tee_file): Remove bools.
4140         (tee_file::~tee_file): Remove deletes.
4141         * ui-file.h (tee_file): Remove bools.
4142
4143 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4144
4145         * mi/mi-cmds.h (mi_cmd_complete): New function.
4146         * mi/mi-main.c (mi_cmd_complete): Likewise.
4147         * mi/mi-cmds.c: Define new MI command -complete.
4148         * NEWS: Mention new -complete command.
4149
4150 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4151
4152         * completer.h (complete): New function.
4153         * completer.c (complete): Likewise.
4154         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4155         function defined in completer.h.
4156
4157 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4158
4159         * MAINTAINERS (Write After Approval): Add myself.
4160
4161 2019-05-17  Tom de Vries  <tdevries@suse.de>
4162
4163         PR gdb/24094
4164         * dwarf2read.c (struct cu_partial_die_info): New struct.
4165         (find_partial_die): Return cu_partial_die_info.
4166         (partial_die_parent_scope, guess_partial_die_structure_name)
4167         (partial_die_info::fixup): Handle new return type of find_partial_die.
4168
4169 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4170
4171         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4172         "std::string", simplifying the algorithm.
4173
4174 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4175
4176         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4177         (stap_static_probe_ops::get_probes): Likewise.
4178
4179 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4180
4181         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4182         '-')" and "else if".
4183         (stap_parse_single_operand): Join checks for
4184         "gdbarch_stap_parse_special_token_p" and
4185         "gdbarch_stap_parse_special_token" in the same "if" statement.
4186         Invert check when verifying for operation on register
4187         displacement.
4188
4189 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4190
4191         * stap-probe.c (stap_get_opcode): Update comment.
4192         (stap_get_expected_argument_type): Likewise.
4193         (handle_stap_probe): Likewise.
4194
4195 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4196
4197         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4198         return type to 'bool'.  Adjust comment.  Use 'bool' when
4199         appropriate.
4200         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4201         * stap-probe.c (stap_parse_argument_1): Likewise.
4202         (stap_is_operator): Likewise.
4203         (stap_is_generic_prefix): Likewise.
4204         (stap_is_register_prefix): Likewise.
4205         (stap_is_register_indirection_prefix): Likewise.
4206         (stap_is_integer_prefix): Likewise.
4207         (stap_generic_check_suffix): Likewise.
4208         (stap_check_integer_suffix): Likewise.
4209         (stap_check_register_suffix): Likewise.
4210         (stap_check_register_indirection_suffix): Likewise.
4211         (stap_parse_register_operand): Likewise.
4212         (stap_parse_single_operand): Likewise.
4213         (stap_parse_argument_1): Likewise.
4214         (stap_probe::get_argument_count): Likewise.
4215         (stap_is_operator): Likewise.
4216
4217 2019-05-16  Tom Tromey  <tromey@adacore.com>
4218
4219         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4220         keyword to foreach.
4221
4222 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4223
4224         * linux-thread-db.c (try_thread_db_load_1): Change return type
4225         to bool.
4226         (try_thread_db_load): Likewise.
4227         (try_thread_db_load_from_pdir_1): Likewise.
4228         (try_thread_db_load_from_pdir): Likewise.
4229         (try_thread_db_load_from_sdir): Likewise.
4230         (try_thread_db_load_from_dir): Likewise.
4231         (thread_db_load_search): Likewise.
4232         (has_libpthread): Likewise.
4233         (thread_db_load): Likewise.
4234
4235 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4236
4237         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4238         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4239         NULL, and complain/return if that's the case.
4240
4241 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4242
4243         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4244         (advance, posn, abstract_read_memory): New functions.
4245         [struct mem_read_abstraction]: New struct.
4246         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4247
4248 2019-05-14  Tom Tromey  <tromey@adacore.com>
4249
4250         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4251         value is not lval_memory.
4252
4253 2019-05-14  Tom Tromey  <tromey@adacore.com>
4254
4255         * solib.c (info_sharedlibrary_command): Style the file name.
4256
4257 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4258
4259         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4260         (aarch64_vnv_type): Likewise.
4261         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4262         * common/tdesc.c: Likewise.
4263         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4264         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4265         * features/aarch64-fpu.xml: Add ieee half view.
4266         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4267         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4268         * gdbtypes.h (struct builtin_type): Likewise.
4269         (struct objfile_type): Likewise.
4270
4271 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4272
4273         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4274         typo.
4275         * location.h (string_to_event_location): Likewise.
4276
4277 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4278
4279         GDB 8.3 released.
4280
4281 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4282
4283         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4284         New variable declaration.
4285         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4286         New variable.
4287         (print_one_breakpoint): Use ui_out::test_flags and new global
4288         variable to compute use_fixed_output.
4289         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4290         Remove.
4291         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4292         (mi_multi_location_breakpoint_output_fixed): Remove.
4293         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4294         new variable.
4295         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4296         fix_multi_location_breakpoint_output flag if version >= 3.
4297         * ui-out.h (enum ui_out_flag)
4298         <fix_multi_location_breakpoint_output>: New enumerator.
4299
4300 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4301
4302         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4303
4304 2019-05-10  Tom Tromey  <tromey@adacore.com>
4305
4306         * ada-lang.c (catch_ada_completer): New function.
4307         (_initialize_ada_language): Use it.
4308
4309 2019-05-10  Tom Tromey  <tromey@adacore.com>
4310
4311         * thread.c (print_thread_info): Make "requested_threads" const.
4312         * gdbthread.h (print_thread_info): Make "requested_threads"
4313         const.
4314         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4315         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4316
4317 2019-05-08  Tom Tromey  <tom@tromey.com>
4318
4319         * gdbtypes.c (objfile_type_data): Change type.
4320         (objfile_type, _initialize_gdbtypes): Update.
4321
4322 2019-05-08  Tom Tromey  <tom@tromey.com>
4323
4324         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4325         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4326         (_initialize_dwarf2_frame): Update.
4327
4328 2019-05-08  Tom Tromey  <tom@tromey.com>
4329
4330         * objc-lang.c (objc_objfile_data): Change type.
4331         (find_methods): Update.
4332         (_initialize_objc_lang): Remove.
4333
4334 2019-05-08  Tom Tromey  <tom@tromey.com>
4335
4336         * stabsread.c (rs6000_builtin_type_data): Change type.
4337         (rs6000_builtin_type, _initialize_stabsread): Update.
4338
4339 2019-05-08  Tom Tromey  <tom@tromey.com>
4340
4341         * mips-tdep.c (mips_pdr_data): Remove.
4342         (_initialize_mips_tdep): Update.
4343
4344 2019-05-08  Tom Tromey  <tom@tromey.com>
4345
4346         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4347         (hppa_init_objfile_priv_data, read_unwind_info)
4348         (find_unwind_entry, _initialize_hppa_tdep): Update.
4349
4350 2019-05-08  Tom Tromey  <tom@tromey.com>
4351
4352         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4353         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4354         on obstack.
4355         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4356
4357 2019-05-08  Tom Tromey  <tom@tromey.com>
4358
4359         * mdebugread.c (basic_type_data): Change type.
4360         (basic_type, _initialize_mdebugread): Update.
4361
4362 2019-05-08  Tom Tromey  <tom@tromey.com>
4363
4364         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4365
4366 2019-05-08  Tom Tromey  <tom@tromey.com>
4367
4368         * nto-tdep.c (nto_inferior_data_reg): Change type.
4369         (nto_inferior_data): Update.
4370         (nto_inferior_data_cleanup, nto_new_inferior_data)
4371         (_initialize_nto_tdep): Remove.
4372         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4373
4374 2019-05-08  Tom Tromey  <tom@tromey.com>
4375
4376         * ada-lang.c (struct ada_inferior_data): Add initializers.
4377         (ada_inferior_data): Change type.
4378         (ada_inferior_data_cleanup): Remove.
4379         (get_ada_inferior_data, ada_inferior_exit)
4380         (struct ada_pspace_data): Add initializers, destructor.
4381         (ada_pspace_data_handle): Change type.
4382         (get_ada_pspace_data): Update.
4383         (ada_pspace_data_cleanup): Remove.
4384
4385 2019-05-08  Tom Tromey  <tom@tromey.com>
4386
4387         * coffread.c (struct coff_symfile_info): Add initializers.
4388         (coff_objfile_data_key): Move lower.  Change type.
4389         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4390         Update.
4391         (coff_free_info): Remove.
4392
4393 2019-05-08  Tom Tromey  <tom@tromey.com>
4394
4395         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4396         (fbsd_pspace_data_handle): Move lower.  Change type.
4397         (get_fbsd_pspace_data): Update.
4398         (fbsd_pspace_data_cleanup): Remove.
4399         (_initialize_fbsd_tdep): Update.
4400
4401 2019-05-08  Tom Tromey  <tom@tromey.com>
4402
4403         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4404         (get_ada_tasks_pspace_data): Update.
4405         (ada_tasks_pspace_data_cleanup): Remove.
4406         (_initialize_tasks): Update.
4407         (ada_tasks_inferior_data_handle): Change type.
4408         (get_ada_tasks_inferior_data): Update.
4409         (ada_tasks_inferior_data_cleanup): Remove.
4410         (struct ada_tasks_pspace_data): Add initializers.
4411
4412 2019-05-08  Tom Tromey  <tom@tromey.com>
4413
4414         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4415         * symfile-debug.c (debug_sym_get_probes): Change type.
4416         * stap-probe.c (handle_stap_probe):
4417         (stap_static_probe_ops::get_probes): Change type.
4418         * probe.h (class static_probe_ops) <get_probes>: Change type.
4419         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4420         (parse_probes_in_pspace): Update.
4421         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4422         Update.
4423         (any_static_probe_ops::get_probes): Change type.
4424         * elfread.c (elfread_data): New typedef.
4425         (probe_key): Change type.
4426         (elf_get_probes): Likewise.  Update.
4427         (probe_key_free): Remove.
4428         (_initialize_elfread): Update.
4429         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4430         Change type.
4431         (dtrace_process_dof_probe, dtrace_process_dof)
4432         (dtrace_static_probe_ops::get_probe): Change type.
4433
4434 2019-05-08  Tom Tromey  <tom@tromey.com>
4435
4436         * xcoffread.c (struct xcoff_symfile_info): Rename from
4437         coff_symfile_info.  Add initializers.
4438         (xcoff_objfile_data_key): Move lower.  Change type.
4439         (XCOFF_DATA): Rewrite.
4440         (xcoff_free_info): Remove.
4441         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4442         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4443         (xcoff_initial_scan): Update.
4444
4445 2019-05-08  Tom Tromey  <tom@tromey.com>
4446
4447         * solib-svr4.c (struct svr4_info): Add initializers and
4448         destructor.
4449         <probes_table>: Now an htab_up.
4450         (solib_svr4_pspace_data): Change type.
4451         (free_probes_table): Simplify.
4452         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4453         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4454         (probes_table_remove_objfile_probes, register_solib_event_probe)
4455         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4456         (_initialize_svr4_solib): Update.
4457
4458 2019-05-08  Tom Tromey  <tom@tromey.com>
4459
4460         * remote.c (remote_pspace_data): Change type.
4461         (remote_pspace_data_cleanup): Remove.
4462         (get_remote_exec_file, set_pspace_remote_exec_file)
4463         (_initialize_remote): Update.
4464
4465 2019-05-08  Tom Tromey  <tom@tromey.com>
4466
4467         * breakpoint.c (breakpoint_objfile_key): Change type.
4468         (get_breakpoint_objfile_data): Update.
4469         (free_breakpoint_objfile_data): Remove.
4470         (_initialize_breakpoint): Update.
4471
4472 2019-05-08  Tom Tromey  <tom@tromey.com>
4473
4474         * linux-tdep.c (struct linux_info): Add initializers.
4475         (linux_inferior_data): Move.  Change type.
4476         (invalidate_linux_cache_inf): Update.
4477         (linux_inferior_data_cleanup): Remove.
4478         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4479
4480 2019-05-08  Tom Tromey  <tom@tromey.com>
4481
4482         * auxv.c (auxv_inferior_data): Move.  Change type.
4483         (auxv_inferior_data_cleanup): Remove.
4484         (invalidate_auxv_cache_inf): Rewrite.
4485         (get_auxv_inferior_data, _initialize_auxv): Update.
4486
4487 2019-05-08  Tom Tromey  <tom@tromey.com>
4488
4489         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4490         (symfile_debug_objfile_data_key): Change type.
4491         (symfile_debug_installed, debug_qf_has_symbols)
4492         (debug_qf_find_last_source_symtab)
4493         (debug_qf_forget_cached_source_info)
4494         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4495         (debug_qf_print_stats, debug_qf_dump)
4496         (debug_qf_expand_symtabs_for_function)
4497         (debug_qf_expand_all_symtabs)
4498         (debug_qf_expand_symtabs_with_fullname)
4499         (debug_qf_map_matching_symbols)
4500         (debug_qf_expand_symtabs_matching)
4501         (debug_qf_find_pc_sect_compunit_symtab)
4502         (debug_qf_map_symbol_filenames)
4503         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4504         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4505         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4506         (debug_sym_read_linetable, debug_sym_relocate): Update.
4507         (symfile_debug_free_objfile): Remove.
4508         (install_symfile_debug_logging, _initialize_symfile_debug):
4509         Update.
4510
4511 2019-05-08  Tom Tromey  <tom@tromey.com>
4512
4513         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4514         allocate_on_obstack.
4515         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4516         (get_dwarf2_per_objfile): Update.
4517         (set_dwarf2_per_objfile): Remove.
4518         (dwarf2_has_info, dwarf2_get_section_info): Update.
4519         (dwarf2_free_objfile): Remove.
4520         (_initialize_dwarf2_read): Update.
4521
4522 2019-05-08  Tom Tromey  <tom@tromey.com>
4523
4524         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4525         initializers.
4526         <unsupported_script_warning_printed,
4527         script_not_found_warning_printed>: Now bool.
4528         (auto_load_pspace_data): Change type.
4529         (~auto_load_pspace_info): Rename from
4530         auto_load_pspace_data_cleanup.
4531         (get_auto_load_pspace_data, init_loaded_scripts_info)
4532         (clear_section_scripts, maybe_print_unsupported_script_warning)
4533         (maybe_print_script_not_found_warning, _initialize_auto_load):
4534         Update.
4535
4536 2019-05-08  Tom Tromey  <tom@tromey.com>
4537
4538         * objfiles.c (objfile_pspace_info): Add destructor and
4539         initializers.
4540         (objfiles_pspace_data): Change type.
4541         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4542         (get_objfile_pspace_data): Update.
4543         (objfiles_bfd_data): Change type.
4544         (get_objfile_bfd_data): Update.
4545         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4546
4547 2019-05-08  Tom Tromey  <tom@tromey.com>
4548
4549         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4550         Change type.
4551         (get_catch_syscall_inferior_data): Update.
4552         (catch_syscall_inferior_data_cleanup): Remove.
4553         (_initialize_break_catch_syscall): Update.
4554
4555 2019-05-08  Tom Tromey  <tom@tromey.com>
4556
4557         * inflow.c (struct terminal_info): Add destructor and
4558         initializers.
4559         (inflow_inferior_data): Change type.
4560         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4561         (get_inflow_inferior_data, inflow_inferior_exit)
4562         (swap_terminal_info, _initialize_inflow): Update.
4563
4564 2019-05-08  Tom Tromey  <tom@tromey.com>
4565
4566         * target-dcache.c (target_dcache_cleanup): Remove.
4567         (target_dcache_aspace_key): Change type.
4568         (target_dcache_init_p, target_dcache_invalidate)
4569         (target_dcache_get, target_dcache_get_or_init)
4570         (_initialize_target_dcache): Update.
4571         * dcache.h (struct dcache_deleter): New.
4572
4573 2019-05-08  Tom Tromey  <tom@tromey.com>
4574
4575         * symtab.c (struct symbol_cache): Add destructor and
4576         initializers.
4577         (symbol_cache_key): Move.  Change type.
4578         (make_symbol_cache, free_symbol_cache): Remove.
4579         (get_symbol_cache): Update.
4580         (symbol_cache_cleanup): Remove.
4581         (ALL_PSPACES, symbol_cache_flush)
4582         (maintenance_print_symbol_cache)
4583         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4584         Update.
4585
4586 2019-05-08  Tom Tromey  <tom@tromey.com>
4587
4588         * symtab.c (struct main_info): Add destructor and initializers.
4589         (main_progspace_key): Move.  Change type.
4590         (get_main_info): Update.
4591         (main_info_cleanup): Remove.
4592         (_initialize_symtab): Update.
4593
4594 2019-05-08  Tom Tromey  <tom@tromey.com>
4595
4596         * registry.h (DECLARE_REGISTRY): Define the _key class.
4597
4598 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4599
4600         * NEWS: Merge two 'New commands' sections.
4601
4602 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4603
4604         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4605         parameter and use Ada language definition instead.
4606         (ada_val_print_ptr): Remove unused language parameter.
4607         (ada_val_print_num): Remove language parameter and use Ada language
4608         definition instead.
4609         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4610         parameter.
4611         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4612         parameter and use Ada language definition instead.
4613         (ada_val_print_1): Update all ada_val_print_xxx calls.
4614         Remove language parameter.
4615         (ada_val_print): Update ada_val_print_1 call.
4616
4617 2019-05-08  Tom Tromey  <tromey@adacore.com>
4618
4619         * remote.c (remote_hw_watchpoint_limit)
4620         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4621         Now static.
4622
4623 2019-05-08  Tom Tromey  <tromey@adacore.com>
4624
4625         * maint.c (_initialize_maint_cmds): Move initialization code to
4626         remote.c.
4627         (watchdog, show_watchdog): Move to remote.c.
4628         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4629         "watchdog" static.
4630         (_initialize_remote): Move initialization code from maint.c.
4631         * defs.h (watchdog): Don't declare.
4632
4633 2019-05-08  Tom Tromey  <tromey@adacore.com>
4634
4635         * tui/tui-interp.c: Include main.h.
4636         * interps.c: Include main.h.
4637         * main.h (interpreter_p): Declare.
4638         * defs.h (interpreter_p): Don't declare.
4639
4640 2019-05-08  Tom Tromey  <tromey@adacore.com>
4641
4642         * dwarf2loc.c: Include dwarf2read.h.
4643         * defs.h (read_unsigned_leb128): Don't declare.
4644         * dwarf2read.h (read_unsigned_leb128): Declare.
4645
4646 2019-05-08  Tom Tromey  <tromey@adacore.com>
4647
4648         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4649         method.
4650
4651 2019-05-08  Tom Tromey  <tromey@adacore.com>
4652
4653         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4654         when no wrap column is set.
4655
4656 2019-05-08  Tom Tromey  <tromey@adacore.com>
4657
4658         * c-lang.c (c_get_string): Handle non-C-style arrays.
4659
4660 2019-05-08  Tom Tromey  <tromey@adacore.com>
4661
4662         * typeprint.c (print_offset_data::update): Print the bit offset,
4663         not the number of bits remaining.
4664
4665 2019-05-08  Tom Tromey  <tromey@adacore.com>
4666
4667         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4668         padding at end of comment.
4669
4670 2019-05-08  Tom Tromey  <tromey@adacore.com>
4671
4672         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4673         Compare main types.
4674
4675 2019-05-06  Tom Tromey  <tom@tromey.com>
4676
4677         * common/scoped_mmap.c: Include common-defs.h.
4678         * common/scoped_mmap.h: Don't include config.h.
4679
4680 2019-05-04  Tom Tromey  <tom@tromey.com>
4681
4682         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4683         (struct aarch64_call_info): Add initializers.
4684         <si>: Now a std::vector.
4685         (pass_on_stack, aarch64_push_dummy_call): Update.
4686
4687 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4688             Tom Tromey  <tom@tromey.com>
4689
4690         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4691         (ppc_threads): Now a std::vector.  Now static.
4692         (hwdebug_find_thread_points_by_tid)
4693         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4694         Update.
4695
4696 2019-05-04  Tom Tromey  <tom@tromey.com>
4697
4698         * arc-tdep.c (arc_tdesc_init): Return bool.
4699
4700 2019-05-04  Tom Tromey  <tom@tromey.com>
4701
4702         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4703         Use gdb_assert_not_reached.
4704
4705 2019-05-04  Tom Tromey  <tom@tromey.com>
4706
4707         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4708         "false".
4709
4710 2019-05-04  Tom Tromey  <tom@tromey.com>
4711
4712         * arc-tdep.c (arc_tdesc_init): Use bool.
4713
4714 2019-05-04  Tom Tromey  <tom@tromey.com>
4715
4716         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4717
4718 2019-05-04  Tom Tromey  <tom@tromey.com>
4719
4720         * cli/cli-cmds.c (valid_command_p): Return bool.
4721
4722 2019-05-04  Tom Tromey  <tom@tromey.com>
4723
4724         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4725         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4726
4727 2019-05-04  Raul Tambre  <raul@tambre.ee>
4728
4729         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4730         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4731         operator for comparison.
4732
4733 2019-05-04  Tom Tromey  <tom@tromey.com>
4734
4735         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4736         (lookup_partial_symbol, print_partial_symbols)
4737         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4738         (psymbol_compare): Update.
4739         (add_psymbol_to_bcache): Clear the entire psymbol.
4740         (maintenance_check_psymtabs): Update.
4741         * psympriv.h (struct partial_symbol): Don't derive from
4742         general_symbol_info.
4743         <obj_section, unrelocated_address, address,
4744         set_unrelocated_address>: Update.
4745         <ginfo>: New member.
4746         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4747         (debug_names::write_psymbols): Update.
4748
4749 2019-05-04  Tom de Vries  <tdevries@suse.de>
4750
4751         * contrib/cc-with-tweaks.sh: Support -n arg.
4752
4753 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4754
4755         * corelow.c (core_target::detach): Ensure frame cache and
4756         register caches are cleared.
4757         inferior.c (exit_inferior_1): Likewise.
4758
4759 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4760             Tom Tromey  <tom@tromey.com>
4761
4762         * dictionary.c (collate_pending_symbols_by_language): Remove
4763         "struct" from foreach.
4764         * symtab.c (lookup_global_symbol_from_objfile)
4765         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4766         foreach.
4767         * ser-tcp.c (net_open): Remove "struct" from foreach.
4768         * objfiles.c (objfile_relocate, objfile_rebase)
4769         (objfile_has_symbols): Remove "struct" from foreach.
4770         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4771         from foreach.
4772         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4773         foreach.
4774         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4775         "struct" from foreach.
4776         * ada-lang.c (create_excep_cond_exprs)
4777         (ada_exception_catchpoint_cond_string): Remove "struct" from
4778         foreach.
4779
4780 2019-05-03  Tom Tromey  <tromey@adacore.com>
4781
4782         * ada-exp.y (convert_char_literal): Check suffix of each
4783         enumerator.
4784
4785 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4786
4787         PR ada/21406:
4788         * ada-exp.y (yywrap): Don't define.
4789         * ada-lex.l (%option): Add noyywrap
4790         (yywrap): Remove.
4791
4792 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4793
4794         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4795         _WIN32_WINNT to the XP level, unless already defined to a higher
4796         level.
4797
4798         * unittests/parse-connection-spec-selftests.c:
4799         * ser-tcp.c:
4800         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4801         override.
4802
4803         * symfile.c (find_separate_debug_file): Remove colon from the
4804         drive spec of DOS/Windows file names of the target, so that the
4805         file name produced from DEBUGDIR and the target's directory will
4806         be valid on DOS/Windows systems.
4807
4808 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4809
4810         * rust-lang.c (val_print_struct): Handle printing structures
4811         containing strings.
4812
4813 2019-05-02  Tom Tromey  <tromey@adacore.com>
4814
4815         * valarith.c (_initialize_valarith): Remove.
4816
4817 2019-05-01  Tom Tromey  <tromey@adacore.com>
4818
4819         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4820         bitfields.
4821
4822 2019-05-01  Tom Tromey  <tromey@adacore.com>
4823
4824         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4825         for big-endian copies.
4826
4827 2019-04-30  Ali Tamur  <tamur@google.com>
4828         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4829         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4830         (read_3_bytes): New function.
4831
4832 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4833
4834         * windows-nat.c (main_thread_id): Delete.
4835         (handle_output_debug_string): Replace main_thread_id by
4836         current_event.dwThreadId.
4837         (fake_create_process): Likewise.
4838         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4839         Do not set main_thread_id.
4840         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4841         current_event.dwThreadId.
4842         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4843
4844 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4845
4846         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4847         Use current_event.dwThreadId instead of main_thread_id.
4848
4849 2019-04-30  Tom Tromey  <tromey@adacore.com>
4850
4851         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4852         (create_excep_cond_exprs): Iterate over program spaces.
4853         (ada_exception_catchpoint_cond_string): Examine all minimal
4854         symbols for exception types.
4855
4856 2019-04-30  Tom Tromey  <tromey@adacore.com>
4857
4858         PR c++/24470:
4859         * dwarf2read.c (process_structure_scope): Handle case where type
4860         has template parameters but no symbol was created.
4861
4862 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4863             Chris January  <chris.january@arm.com>
4864
4865         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4866         qualifier.
4867         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4868
4869 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4870
4871         * f-typeprint.c (f_print_type): Update rules for printing
4872         whitespace.
4873         (f_type_print_varspec_suffix): Likewise.
4874
4875 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4876             Chris January  <chris.january@arm.com>
4877
4878         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4879         function arguments.
4880
4881 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4882
4883         * f-lang.c (build_fortran_types): Change name of void type to
4884         lower case.
4885         * f-typeprint.c (f_type_print_base): Print the name of the void
4886         type, rather than a fixed string.
4887         * f-valprint.c (f_decorations): Use lower case void string.
4888
4889 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4890             Chris January  <chris.january@arm.com>
4891
4892         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4893         types for Fortran.
4894
4895 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4896             Chris January  <chris.january@arm.com>
4897             David Lecomber  <david.lecomber@arm.com>
4898
4899         * f-exp.y (BINOP_INTRINSIC): New token.
4900         (exp): New parser rule handling BINOP_INTRINSIC.
4901         (f77_keywords): Add new builtin procedures.
4902         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4903         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4904         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4905         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4906         (print_unop_subexp_f): New function.
4907         (print_binop_subexp_f): New function.
4908         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4909         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4910         (dump_subexp_body_f): Likewise.
4911         (operator_check_f): Likewise.
4912         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4913         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4914
4915 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4916
4917         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4918         UNOP_KIND.
4919         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4920         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4921         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4922         (operator_length_f): New fuction.
4923         (print_subexp_f): New function.
4924         (op_name_f): New function.
4925         (dump_subexp_body_f): New function.
4926         (operator_check_f): New function.
4927         (exp_descriptor_f): Replace standard expression handling functions
4928         with new functions.
4929         * gdb/fortran-operator.def: New file.
4930         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4931         * gdb/std-operator.def: Remove UNOP_KIND.
4932
4933 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4934
4935         * std-operator.def: Remove unbalanced, stray double quote
4936         character.
4937
4938 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4939             Chris January  <chris.january@arm.com>
4940             Daniel Everett  <daniel.everett@arm.com>
4941             Nick Forrington  <nick.forrington@arm.com>
4942             Richard Bunt  <richard.bunt@arm.com>
4943
4944         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4945         of depth when printing anonymous structs or unions.
4946         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4947         Don't print either the top-level value, or the children if the
4948         max-depth is exceeded.
4949         (ppscm_print_children): When printing the key of a map, allow one
4950         extra level of depth.
4951         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4952         print either the top-level value, or the children if the max-depth
4953         is exceeded.
4954         (print_children): When printing the key of a map, allow one extra
4955         level of depth.
4956         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4957         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4958         (user_print_options): Initialise max_depth field.
4959         (val_print_scalar_or_string_type_p): New function.
4960         (val_print): Check to see if the max depth has been reached.
4961         (val_print_check_max_depth): Define new function.
4962         (show_print_max_depth): New function.
4963         (_initialize_valprint): Add 'print max-depth' option.
4964         * valprint.h (struct value_print_options) <max_depth>: New field.
4965         (val_print_check_max_depth): Declare new function.
4966         * NEWS: Document new feature.
4967
4968 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4969
4970         * ada-lang.c (ada_language_defn): Initialise new field.
4971         * c-lang.c (c_is_string_type_p): New function.
4972         (c_language_defn): Initialise new field.
4973         (cplus_language_defn): Initialise new field.
4974         (asm_language_defn): Initialise new field.
4975         (minimal_language_defn): Initialise new field.
4976         * c-lang.h (c_is_string_type_p): Declare new function.
4977         * d-lang.c (d_language_defn): Initialise new field.
4978         * f-lang.c (f_is_string_type_p): New function.
4979         (f_language_defn): Initialise new field.
4980         * go-lang.c (go_is_string_type_p): New function.
4981         (go_language_defn): Initialise new field.
4982         * language.c (default_is_string_type_p): New function.
4983         (unknown_language_defn): Initialise new field.
4984         (auto_language_defn): Initialise new field.
4985         * language.h (struct language_defn) <la_is_string_type_p>: New
4986         member variable.
4987         (default_is_string_type_p): Declare new function.
4988         * m2-lang.c (m2_language_defn): Initialise new field.
4989         * objc-lang.c (objc_language_defn): Initialise new field.
4990         * opencl-lang.c (opencl_language_defn): Initialise new field.
4991         * p-lang.c (pascal_is_string_type_p): New function.
4992         (pascal_language_defn): Initialise new field.
4993         * rust-lang.c (rust_is_string_type_p): New function.
4994         (rust_language_defn): Initialise new field.
4995
4996 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4997
4998         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4999         New field.
5000         * ada-lang.c (ada_language_defn): Initialise new field.
5001         * c-lang.c (c_language_defn): Likewise.
5002         (cplus_language_defn): Likewise.
5003         (asm_language_defn): Likewise.
5004         (minimal_language_defn): Likewise.
5005         * d-lang.c (d_language_defn): Likewise.
5006         * f-lang.c (f_language_defn): Likewise.
5007         * go-lang.c (go_language_defn): Likewise.
5008         * language.c (unknown_language_defn): Likewise.
5009         (auto_language_defn): Likewise.
5010         * m2-lang.c (m2_language_defn): Likewise.
5011         * objc-lang.c (objc_language_defn): Likewise.
5012         * opencl-lang.c (opencl_language_defn): Likewise.
5013         * p-lang.c (pascal_language_defn): Likewise.
5014         * rust-lang.c (rust_language_defn): Likewise.
5015
5016 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5017
5018         * ada-lang.c (ada_is_character_type): Change return type to bool.
5019         (ada_is_string_type): Likewise.
5020         * ada-lang.h (ada_is_character_type): Update declaration
5021         (ada_is_string_type): Likewise.
5022
5023 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5024
5025         Support style in 'frame|thread apply'
5026
5027         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5028         * record.c (record_start, record_stop): Update callers of
5029         execute_command_to_string with false.
5030         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5031         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5032         methods.
5033         (class string_file): New constructor with term_out parameter.
5034         Override methods term_out and can_emit_style_escape.  New member
5035         term_out.
5036         (class stdio_file): Override can_emit_style_escape.
5037         (class tee_file): Override term_out and can_emit_style_escape.
5038         * utils.h (can_emit_style_escape): Remove.
5039         * utils.c (can_emit_style_escape): Likewise.
5040         Update all callers of can_emit_style_escape (SOMESTREAM) to
5041         SOMESTREAM->can_emit_style_escape.
5042         * source-cache.c (source_cache::get_source_lines): Likewise.
5043         * stack.c (frame_apply_command_count): Call execute_command_to_string
5044         passing the term_out characteristic of the current gdb_stdout.
5045         * thread.c (thr_try_catch_cmd): Likewise.
5046         * top.c (execute_command_to_string): pass term_out parameter
5047         to construct the string_file for the command output.
5048         * ui-file.c (term_cli_styling): New function (most code moved
5049         from utils.c can_emit_style_escape).
5050         (string_file::string_file, string_file::can_emit_style_escape,
5051         stdio_file::can_emit_style_escape, tee_file::term_out,
5052         tee_file::can_emit_style_escape): New functions.
5053
5054 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5055
5056         * NEWS: Mention the new set|show may-call-functions.
5057         * infcall.c (may_call_functions_p): New variable.
5058         (show_may_call_functions_p): New function.
5059         (call_function_by_hand_dummy): Throws an error if not
5060         may-call-functions.
5061         (_initialize_infcall): Call add_setshow_boolean_cmd for
5062         may-call-functions.
5063
5064 2019-04-25  Keith Seitz  <keiths@redhat.com>
5065
5066         PR c++/24367
5067         * cp-support.c (inspect_type): Don't attempt substitutions
5068         of symbol with the same name.
5069
5070 2019-04-25  Tom Tromey  <tromey@adacore.com>
5071
5072         PR gdb/24475:
5073         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5074         static.
5075
5076 2019-04-25  Tom Tromey  <tromey@adacore.com>
5077
5078         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5079         rvalue reference.
5080         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5081         (gdb_xml_parser::parse): Use std::move.
5082         * python/python-internal.h (gdbpy_convert_exception): Take a const
5083         reference.
5084         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5085         std::move.
5086         * python/py-utils.c (gdbpy_convert_exception): Take a const
5087         reference.
5088         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5089         Use std::move.
5090         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5091         Use std::move.
5092         * mi/mi-main.c (mi_print_exception): Take a const reference.
5093         * main.c (handle_command_errors): Take a const reference.
5094         * linespec.c (parse_linespec): Use std::move.
5095         * infcall.c (run_inferior_call): Use std::move.
5096         (call_function_by_hand_dummy): Use std::move.
5097         * exec.c (try_open_exec_file): Use std::move.
5098         * exceptions.h (exception_print, exception_fprintf)
5099         (exception_print_same): Update.
5100         * exceptions.c (print_exception, exception_print)
5101         (exception_fprintf, exception_print_same): Change parameters to
5102         const reference.
5103         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5104         * common/new-op.c: Use std::move.
5105         * common/common-exceptions.h (struct gdb_exception): Add move
5106         constructor.
5107         (struct gdb_exception_error, struct gdb_exception_quit, struct
5108         gdb_quit_bad_alloc): Change constructor to move constructor.
5109         (throw_exception): Change parameter to rvalue reference.
5110         * common/common-exceptions.c (throw_exception): Take rvalue
5111         reference.
5112         * cli/cli-interp.c (safe_execute_command): Use std::move.
5113         * breakpoint.c (insert_bp_location, location_to_sals): Use
5114         std::move.
5115
5116 2019-04-25  Tom Tromey  <tromey@adacore.com>
5117
5118         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5119         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5120         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5121         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5122         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5123         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5124         guile/scm-value.c: Use unpack.
5125         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5126         gdbscm_gdb_exception.
5127         (gdbscm_throw_gdb_exception): Likewise.
5128         (struct gdbscm_gdb_exception): New.
5129         (unpack): New function.
5130         (gdbscm_wrap): Use unpack.
5131
5132 2019-04-25  Tom Tromey  <tromey@adacore.com>
5133
5134         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5135         (gdb_rl_callback_handler): Use std::move.
5136         * common/common-exceptions.h (struct gdb_exception): Add move
5137         assignment operator.
5138         (throw_exception_sjlj): Change "exception" to const reference.
5139         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5140         (throw_exception_sjlj): Change "exception" to const reference.
5141
5142 2019-04-25  Tom Tromey  <tromey@adacore.com>
5143
5144         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5145         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5146         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5147         Update.
5148         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5149         Update.
5150         * mi/mi-interp.c (mi_interp::exec): Update.
5151         * linespec.c (parse_linespec): Update.
5152         * infcall.c (run_inferior_call): Update.
5153         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5154         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5155         (gdbscm_lookup_global_symbol): Update.
5156         * guile/scm-param.c (gdbscm_parameter_value): Update.
5157         * guile/scm-frame.c (gdbscm_frame_read_register)
5158         (gdbscm_frame_read_var): Update.
5159         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5160         * exec.c (try_open_exec_file): Update.
5161         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5162         (gdb_rl_callback_handler): Update.
5163         * common/common-exceptions.h (exception_none): Don't declare.
5164         * common/common-exceptions.c (exception_none): Don't define.
5165         (struct catcher) <exception>: Update.
5166         * cli/cli-interp.c (safe_execute_command): Update.
5167         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5168
5169 2019-04-25  Ali Tamur  <tamur@google.com>
5170
5171         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5172         (read_attribute_value): Likewise.
5173         (dwarf2_read_addr_index): Update comment.
5174         (read_str_index): Add DW_FORM_strx.
5175         (dwarf2_string_attr): Likewise.
5176         (dwarf2_const_value_attr): Likewise.
5177         (dump_die_shallow): Likewise.
5178         (dwarf2_fetch_constant_bytes): Likewise.
5179         (skip_form_bytes): Likewise.
5180         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5181
5182 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5183
5184         PR corefiles/11608
5185         PR corefiles/18187
5186         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5187         OFFSET.  Verify if current mapping contains an ELF header.
5188         (linux_find_memory_regions_full): Adjust call to
5189         dump_mapping_p.
5190
5191 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5192             Kang Li <kanglictf@gmail.com>
5193
5194         PR gdb/21600
5195
5196         * dwarf2-frame.c (read_initial_length): Be consistent about using
5197         unsigned representation of length.
5198         (decode_frame_entry_1): Likewise.  Check for wraparound of
5199         end pointer as well as buffer overflow.
5200
5201 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5202
5203         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5204         "vq".
5205
5206 2019-04-24  Tom Tromey  <tromey@adacore.com>
5207
5208         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5209
5210 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5211
5212         * s12z-tdep.c (s12z_unwind_pc): Delete.
5213         (s12z_unwind_sp): Delete.
5214         (s12z_gdbarch_init): Don't register deleted functions with
5215         gdbarch.
5216
5217 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5218
5219         * rl78-tdep.c (rl78_unwind_sp): Delete.
5220         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5221
5222 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5223
5224         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5225         (xstormy16_unwind_pc): Delete.
5226         (xstormy16_dummy_id): Delete.
5227         (xstormy16_gdbarch_init): Don't register deleted functions with
5228         gdbarch.
5229
5230 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5231
5232         * vax-tdep.c (vax_unwind_pc): Delete.
5233         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5234
5235 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5236
5237         * v850-tdep.c (v850_unwind_sp): Delete.
5238         (v850_unwind_pc): Delete.
5239         (v850_dummy_id): Delete.
5240         (v850_gdbarch_init): Don't register deleted functions with
5241         gdbarch.
5242
5243 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5244
5245         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5246         (tilegx_unwind_pc): Delete.
5247         (tilegx_unwind_dummy_id): Delete.
5248         (tilegx_gdbarch_init): Don't register deleted functions with
5249         gdbarch.
5250
5251 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5252
5253         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5254         (tic6x_dummy_id): Delete.
5255         (tic6x_gdbarch_init): Don't register deleted functions with
5256         gdbarch.
5257
5258 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5259
5260         * sparc-tdep.c (sparc_unwind_pc): Delete.
5261         (sparc32_gdbarch_init): Don't register deleted function with
5262         gdbarch.
5263
5264 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5265
5266         * sh-tdep.c (sh_unwind_sp): Delete.
5267         (sh_unwind_pc): Delete.
5268         (sh_dummy_id): Delete.
5269         (sh_gdbarch_init): Don't register deleted functions with
5270         gdbarch.
5271
5272 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5273
5274         * score-tdep.c (score_unwind_sp): Delete.
5275         (score_unwind_pc): Delete.
5276         (score_dummy_id): Delete.
5277         (score_gdbarch_init): Don't register deleted functions with
5278         gdbarch.
5279
5280 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5281
5282         * rx-tdep.c (rx_unwind_pc): Delete.
5283         (rx_unwind_sp): Delete.
5284         (rx_dummy_id): Delete.
5285         (rx_gdbarch_init): Don't register deleted functions with
5286         gdbarch.  Update comment.
5287
5288 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5289
5290         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5291         (rs6000_dummy_id): Delete.
5292         (rs6000_gdbarch_init): Don't register deleted functions with
5293         gdbarch.
5294
5295 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5296
5297         * or1k-tdep.c (or1k_dummy_id): Delete.
5298         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5299
5300 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5301
5302         * nios2-tdep.c (nios2_dummy_id): Delete.
5303         (nios2_unwind_sp): Delete.
5304         (nios2_gdbarch_init): Don't register deleted functions with
5305         gdbarch.
5306
5307 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5308
5309         * nds32-tdep.c (nds32_dummy_id): Delete.
5310         (nds32_unwind_pc): Delete.
5311         (nds32_unwind_sp): Delete.
5312         (nds32_gdbarch_init): Don't register deleted functions with
5313         gdbarch.
5314
5315 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5316
5317         * msp430-tdep.c (msp430_unwind_pc): Delete.
5318         (msp430_unwind_sp): Delete.
5319         (msp430_dummy_id): Delete.
5320         (msp430_gdbarch_init): Don't register deleted functions with
5321         gdbarch.
5322
5323 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5324
5325         * moxie-tdep.c (moxie_unwind_sp): Delete.
5326         (moxie_unwind_pc): Delete.
5327         (moxie_dummy_id): Delete.
5328         (moxie_gdbarch_init): Don't register deleted functions with
5329         gdbarch.
5330
5331 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5332
5333         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5334         (mn10300_unwind_pc): Delete.
5335         (mn10300_unwind_sp): Delete.
5336         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5337         mn10300_unwind_sp.
5338         (mn10300_frame_unwind_init): Don't register deleted functions with
5339         gdbarch.
5340
5341 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5342
5343         * mep-tdep.c (mep_unwind_pc): Delete.
5344         (mep_unwind_sp): Delete.
5345         (mep_dummy_id): Delete.
5346         (mep_gdbarch_init): Don't register deleted functions with
5347         gdbarch.
5348
5349 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5350
5351         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5352         (m68hc11_unwind_sp): Delete.
5353         (m68hc11_gdbarch_init): Don't register deleted functions with
5354         gdbarch.
5355
5356 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5357
5358         * m32r-tdep.c (m32r_unwind_sp): Delete.
5359         (m32r_unwind_pc): Delete.
5360         (m32r_dummy_id): Delete.
5361         (m32r_gdbarch_init): Don't register deleted functions with
5362         gdbarch.
5363
5364 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5365
5366         * m32c-tdep.c (m32c_unwind_pc): Delete.
5367         (m32c_unwind_sp): Delete.
5368         (m32c_dummy_id): Delete.
5369         (m32c_gdbarch_init): Don't register deleted functions with
5370         gdbarch.
5371
5372 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5373
5374         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5375         (lm32_unwind_pc): Delete.
5376         (lm32_dummy_id): Delete.
5377         (lm32_gdbarch_init): Don't register deleted functions with
5378         gdbarch.
5379
5380 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5381
5382         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5383         (iq2000_unwind_pc): Delete.
5384         (iq2000_dummy_id): Delete.
5385         (iq2000_gdbarch_init): Don't register deleted functions with
5386         gdbarch.
5387
5388 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5389
5390         * nds32-tdep.c (nds32_type_align): Delete.
5391         (nds32_push_dummy_call): Use type_align instead.
5392
5393 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5394
5395         * arm-tdep.c (arm_type_align): Only handle vector override case.
5396         (arm_push_dummy_call): Use type_align.
5397         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5398
5399 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5400
5401         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5402         case.
5403         (pass_on_stack): Use type_align.
5404         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5405         function.
5406
5407 2019-04-23  Tom Tromey  <tromey@adacore.com>
5408
5409         * dwarf2read.c (line_header::file_name_at): Remove unused
5410         overload.
5411
5412 2019-04-23  Tom de Vries  <tdevries@suse.de>
5413
5414         PR gdb/24438
5415         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5416         invocation.
5417
5418
5419 2019-03-27  Ali Tamur  <tamur@google.com>
5420
5421         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5422         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5423         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5424         (dwarf_expr_context::get_addr_index): Likewise
5425         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5426         (symbol_needs_eval_context::get_addr_index): Likewise
5427         (disassemble_dwarf_expression): Add DW_OP_addrx
5428         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5429         (read_cutu_die_from_dwo): Update comment
5430         (skip_one_die): Add DW_FORM_addrx
5431         (read_attribute_value): Likewise
5432         (var_decode_location): Add DW_OP_addrx
5433         (dwarf2_const_value_attr): Add DW_FORM_addrx
5434         (dump_die_shallow): Likewise
5435         (dwarf2_fetch_constant_bytes): Likewise
5436         (decode_locdesc): Add DW_OP_addrx
5437         (skip_form_bytes): Add DW_FORM_addrx
5438
5439 2019-04-22  Ali Tamur  <tamur@google.com>
5440
5441         * MAINTAINERS (Write After Approval): Add self.
5442
5443 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5444
5445         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5446         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5447         (open_symbol_file_object): Likewise.
5448         (svr4_default_sos): Add info parameter.
5449         (svr4_read_so_list): Likewise.
5450         (svr4_current_sos_direct): Adjust functions calls to pass down
5451         info.
5452         (svr4_current_sos_1): Add info parameter.
5453         (svr4_current_sos): Call get_svr4_info, pass info down to
5454         svr4_current_sos_1.
5455         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5456         get_svr4_info.
5457         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5458         get_svr4_info.
5459         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5460         to get_svr4_info.
5461         (probes_table_remove_objfile_probes): Likewise.
5462         (register_solib_event_probe): Add info parameter.
5463         (solist_update_incremental): Pass info parameter down to
5464         svr4_read_so_list.
5465         (disable_probes_interface): Add info parameter.
5466         (svr4_handle_solib_event): Pass current_program_space to
5467         get_svr4_info.  Adjust disable_probes_interface cleanup.
5468         (svr4_create_probe_breakpoints): Add info parameter, pass it
5469         down to register_solib_event_probe.
5470         (svr4_create_solib_event_breakpoints): Add info parameter,
5471         pass it down to svr4_create_probe_breakpoints.
5472         (enable_break): Pass info down to
5473         svr4_create_solib_event_breakpoints.
5474         (svr4_solib_create_inferior_hook): Pass current_program_space to
5475         get_svr4_info.
5476         (svr4_clear_solib): Likewise.
5477
5478 2019-04-22  Pedro Alves  <palves@redhat.com>
5479
5480         * solib-svr4.c (svr4_free_objfile_observer): New.
5481         (probe_and_action::objfile): New field.
5482         (probes_table_htab_remove_objfile_probes)
5483         (probes_table_remove_objfile_probes): New functions.
5484         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5485         in the new probe_and_action.  Don't store the probe in 'lookup'.
5486         (svr4_create_probe_breakpoints): Pass objfile to
5487         register_solib_event_probe.
5488         (_initialize_svr4_solib): Register a free_objfile observer.
5489
5490 2019-04-19  Tom Tromey  <tom@tromey.com>
5491
5492         * common/queue.h: Remove.
5493
5494 2019-04-19  Tom Tromey  <tom@tromey.com>
5495
5496         * event-loop.c: Don't include "common/queue.h".
5497
5498 2019-04-19  Tom Tromey  <tom@tromey.com>
5499
5500         * remote.c (remote_target): Use delete.
5501         * remote-notif.h: Include <list>, not "common/queue.h".
5502         (notif_client_p): Remove typedef.
5503         (remote_notif_state): Add constructor, destructor, initializer.
5504         <notif_queue>: Now a std::list.
5505         (remote_notif_state_xfree): Don't declare.
5506         * remote-notif.c (remote_notif_process, handle_notification)
5507         (remote_notif_state_allocate): Update.
5508         (~remote_notif_state): Rename from remote_notif_state_xfree.
5509
5510 2019-04-19  Tom Tromey  <tom@tromey.com>
5511
5512         * symfile.c (reread_symbols): Update.
5513         * objfiles.c (objfile_register_static_link)
5514         (objfile_lookup_static_link): Update
5515         (~objfile) Don't delete static_links.
5516         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5517
5518 2019-04-19  Tom Tromey  <tom@tromey.com>
5519
5520         * type-stack.h (struct type_stack) <insert>: Constify string.
5521         * type-stack.c (type_stack::insert): Constify string.
5522         * gdbtypes.h (lookup_template_type): Update.
5523         (address_space_name_to_int): Update.
5524         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5525         const.
5526         (lookup_template_type): Make name const.
5527         * c-exp.y: Update rules.
5528         (lex_one_token, classify_name, classify_inner_name)
5529         (c_print_token): Update.
5530         * p-exp.y: Update rules.
5531         (yylex): Update.
5532         * f-exp.y: Update rules.
5533         (yylex): Update.
5534         * d-exp.y: Update rules.
5535         (lex_one_token, classify_name, classify_inner_name): Update.
5536         * parse.c (write_dollar_variable, copy_name): Return std::string.
5537         * parser-defs.h (copy_name): Change return type.
5538         * m2-exp.y: Update rules.
5539         (yylex): Update.
5540         * go-exp.y (lex_one_token): Update.
5541         Update rules.
5542         (classify_unsafe_function, classify_packaged_name)
5543         (classify_name, yylex): Update.
5544
5545 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5546
5547         * configure.ac: add --enable-source-highlight switch.
5548         * configure: Regenerate.
5549         * top.c (print_gdb_version): plumb --enable-source-highlight
5550         status to "show configuration".
5551
5552 2019-04-19  Tom Tromey  <tromey@adacore.com>
5553
5554         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5555         Check ADA_TYPE_P.
5556         (empty_record, ada_template_to_fixed_record_type_1)
5557         (template_to_static_fixed_type)
5558         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5559         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5560         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5561         macros.
5562
5563 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5564
5565         PR symtab/24423:
5566         * source.c (print_source_lines_base): Advance "iter" when a
5567         control character is seen.
5568
5569 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5570
5571         * inferior.h (struct infcall_suspend_state_deleter):
5572         Catch exception in destructor to avoid crash.
5573
5574 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5575
5576         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5577         close to the add_com "shell".
5578
5579 2019-04-18  Tom Tromey  <tromey@adacore.com>
5580
5581         * process-stratum-target.h (class process_stratum_target)
5582         <stratum>: Add "final".
5583
5584 2019-04-17  Tom Tromey  <tromey@adacore.com>
5585
5586         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5587         against nullptr before use.
5588
5589 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5590
5591         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5592
5593 2019-04-17  Jim Wilson  <jimw@sifive.com>
5594             Andrew Burgess  <andrew.burgess@embecosm.com>
5595
5596         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5597         code read might fail, assume 4-byte breakpoint in that case.
5598
5599 2019-04-15  Leszek Swirski  <leszeks@google.com>
5600
5601         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5602         rather than a hand-rolled POD check when checking for forced MEMORY
5603         classification.
5604
5605 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5606
5607         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5608         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5609         function.
5610         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5611         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5612         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5613         declaration.
5614
5615 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5616
5617         * aarch64-linux-nat.c
5618         (aarch64_linux_nat_target::thread_architecture): Add override.
5619         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5620         each VQ.
5621
5622 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5623
5624         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5625
5626 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5627
5628         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5629         target types of size 96-bits, add some additional comments, and
5630         check that the builtin type we found was the correct size.
5631
5632 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5633
5634         * utils.c (prompt_for_continue): Don't restore the styling at the
5635         end, as applied_style has the wrong value.  This fixes styling in
5636         long lists of file names that are interrupted by the "Continue?"
5637         prompt.
5638
5639 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5640
5641         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5642         * c-lang.c (c_language_defn): Likewise.
5643         (cplus_language_defn): Likewise.
5644         (asm_language_defn): Likewise.
5645         (minimal_language_defn): Likewise.
5646         * d-lang.c (d_language_defn): Likewise.
5647         * f-lang.c (f_language_defn): Likewise.
5648         * go-lang.c (go_language_defn): Likewise.
5649         * language.c (unknown_language_defn): Likewise.
5650         (auto_language_defn): Likewise.
5651         * language.h (struct language_defn): Remove la_magic field.
5652         (LANG_MAGIC): Delete.
5653         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5654         * objc-lang.c (objc_language_defn): Likewise.
5655         * opencl-lang.c (opencl_language_defn): Likewise.
5656         * p-lang.c (pascal_language_defn): Likewise.
5657         * rust-lang.c (rust_language_defn): Likewise.
5658
5659 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5660
5661         * riscv-tdep.c (riscv_type_align): New function.
5662         (riscv_type_alignment): Delete.
5663         (riscv_arg_location): Use 'type_align'.
5664         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5665
5666 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5667
5668         * gdbtypes.c (type_align): A struct with no non-static fields also
5669         has alignment of 1.
5670
5671 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5672
5673         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5674         component to 0.
5675         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5676         member.
5677         (riscv_struct_info::analyse): New implementation using new
5678         analyse_inner member function.
5679         (riscv_struct_info::field_offset): New member function.
5680         (riscv_struct_info::m_offsets): New member variable.
5681         (riscv_struct_info::analyse_inner): New private member function,
5682         takes the old implementation of riscv_struct_info::analyse but
5683         extended to track field offsets.
5684         (riscv_call_arg_struct): Update the struct folding special cases
5685         to handle cases where empty C++ structs, which are non-zero
5686         length, are found.
5687         (riscv_arg_location): Initialise the length of each location, a
5688         non-zero length now indicates the location is in use.
5689         (riscv_push_dummy_call): Allow for the first location having a
5690         non-zero offset when setting up arguments.
5691         (riscv_return_value): Likewise, but for return values.
5692
5693 2019-04-11  Tom Tromey  <tromey@adacore.com>
5694
5695         * utils.c (internal_vproblem): Make "msg" const.
5696
5697 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5698
5699         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5700         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5701         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5702         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5703
5704 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5705
5706         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5707         function.
5708         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5709         of amd64_collect_native_gregset.
5710         (amd64_linux_nat_target::store_registers): Likewise.
5711
5712 2019-04-10  Tom Tromey  <tom@tromey.com>
5713
5714         * symtab.c (lookup_global_symbol_from_objfile)
5715         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5716         * objfiles.h (class separate_debug_iterator): New.
5717         (class separate_debug_range): New.
5718         (struct objfile) <separate_debug_objfiles>: New method.
5719         (objfile_separate_debug_iterate): Don't declare.
5720         * objfiles.c (separate_debug_iterator::operator++): Rename from
5721         objfile_separate_debug_iterate.
5722         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5723         iterator.
5724         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5725         iterator.
5726
5727 2019-04-10  Tom Tromey  <tom@tromey.com>
5728
5729         * symfile.c (reread_symbols): Remove old comment.
5730         * objfiles.c (free_all_objfiles): Fix a typo.
5731
5732 2019-04-10  Tom Tromey  <tom@tromey.com>
5733
5734         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5735         * minsyms.c (lookup_minimal_symbol): Use foreach.
5736         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5737         (lookup_minimal_symbol_solib_trampoline): Likewise.
5738         * symfile.c (reread_symbols): Use foreach.
5739
5740 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5741             Tom Tromey  <tromey@adacore.com>
5742
5743         PR rust/24414:
5744         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5745         (rust_lex_int_test): Change "value" to be LONGEST.
5746         (rust_lex_tests): Add test for long integer literal.
5747
5748 2019-04-09  Tom Tromey  <tromey@adacore.com>
5749
5750         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5751         to bool.
5752         (extended_remote_target::attach): Update.
5753         (remote_target::remote_notice_new_inferior): Update.
5754         (remote_target::add_current_inferior_and_thread): Update.
5755         * inferior.c (exit_inferior_1): Use "false".
5756         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5757
5758 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5759
5760         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5761         the "start" command.
5762
5763 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5764
5765         * python/py-inferior.c (infpy_thread_from_thread_handle):
5766         Adjust comments to reflect renaming of thread_from_thread_handle
5767         to thread_from_handle.  Adjust keywords.  Fix type error message.
5768         (inferior_object_methods): Add thread_from_handle.  Retain
5769         thread_from_thread_handle, but mark it as deprecated.
5770
5771 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5772
5773         * gdbthread.h (find_thread_by_handle): Revise declaration.
5774         * thread.c (find_thread_by_handle): Likewise.  Adjust
5775         implementation too.
5776         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5777         support for buffer objects as handles.
5778
5779 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5780
5781         * python/py-infthread.c (thpy_thread_handle): New function.
5782         (thread_object_methods): Register thpy_thread_handle.
5783
5784 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5785
5786         * gdbthread.h (thread_to_thread_handle): Declare.
5787         * thread.c (gdbtypes.h): Include.
5788         (thread_to_thread_handle): New function.
5789
5790         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5791         (target_thread_info_to_thread_handle): Declare.
5792         * target.c (target_thread_info_to_thread_handle): New function.
5793         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5794         * target-delegates.c: Regenerate.
5795
5796         * linux-thread-db.c (class thread_db_target): Add method
5797         thread_info_to_thread_handle.
5798         (thread_db_target::thread_info_to_thread_handle): Define.
5799         * remote.c (class remote_target): Add new method
5800         thread_info_to_thread_handle.
5801         (remote_target::thread_info_to_thread_handle): Define.
5802
5803 2019-04-08  Pedro Alves  <palves@redhat.com>
5804
5805         * common/common-exceptions.c (throw_exception): Don't create
5806         named object to throw; throw directly.
5807         (throw_it): Likewise.  Don't initialize gdb_exception::message
5808         here, with new; pass FMT and AP to the ctor instead.
5809         * common/common-exceptions.h: Include <string>.
5810         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5811         const char *, va_list)): New ctor.  Use std::make_shared.
5812         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5813         errors)): Delete.
5814         (gdb_exception_error::gdb_exception_error(enum errors, const char
5815         *, va_list)): New.
5816         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5817         Add assertion.
5818         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5819         errors)): Delete.
5820         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5821         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5822         Add assertion.
5823
5824 2019-04-08  Tom Tromey  <tom@tromey.com>
5825
5826         * valops.c (value_rtti_indirect_type): Replace throw_exception
5827         with throw.
5828         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5829         with throw.
5830         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5831         throw.
5832         * target.c (target_translate_tls_address): Replace throw_exception
5833         with throw.
5834         * stack.c (frame_apply_command_count): Replace throw_exception
5835         with throw.
5836         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5837         throw.
5838         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5839         with throw.
5840         * rs6000-tdep.c (rs6000_frame_cache)
5841         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5842         * remote.c: Replace throw_exception with throw.
5843         * record-full.c (record_full_message, record_full_wait_1)
5844         (record_full_restore): Replace throw_exception with throw.
5845         * record-btrace.c:
5846         (get_thread_current_frame_id, record_btrace_start_replaying)
5847         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5848         (cmd_record_btrace_start): Replace throw_exception with throw.
5849         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5850         throw.
5851         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5852         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5853         * linespec.c:
5854         (find_linespec_symbols): Replace throw_exception with throw.
5855         * infrun.c (displaced_step_prepare, resume): Replace
5856         throw_exception with throw.
5857         * infcmd.c (post_create_inferior): Replace throw_exception with
5858         throw.
5859         * inf-loop.c (inferior_event_handler): Replace throw_exception
5860         with throw.
5861         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5862         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5863         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5864         (get_prev_frame_always, get_frame_pc_if_available)
5865         (get_frame_address_in_block_if_available, get_frame_language):
5866         Replace throw_exception with throw.
5867         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5868         throw_exception with throw.
5869         * eval.c (fetch_subexp_value, evaluate_var_value)
5870         (evaluate_funcall, evaluate_subexp_standard): Replace
5871         throw_exception with throw.
5872         * dwarf2loc.c (call_site_find_chain)
5873         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5874         Replace throw_exception with throw.
5875         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5876         with throw.
5877         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5878         throw.
5879         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5880         * completer.c (complete_line_internal): Replace throw_exception
5881         with throw.
5882         * compile/compile-object-run.c (compile_object_run): Replace
5883         throw_exception with throw.
5884         * cli/cli-script.c (process_next_line): Replace throw_exception
5885         with throw.
5886         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5887         (btrace_enable, btrace_maint_update_pt_packets): Replace
5888         throw_exception with throw.
5889         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5890         throw_exception with throw.
5891         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5892         throw_exception with throw.
5893         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5894         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5895         * aarch64-tdep.c (aarch64_make_prologue_cache)
5896         (aarch64_make_stub_cache): Replace throw_exception with throw.
5897
5898 2019-04-08  Tom Tromey  <tom@tromey.com>
5899
5900         * common/common-exceptions.c (throw_exception): Rename from
5901         throw_exception_cxx.  Remove old copy.  Make argument const.
5902         (throw_it): Create and throw exception objects directly.
5903         * common/common-exceptions.h (throw_exception): Make argument
5904         const.
5905         (struct gdb_exception_error): Add constructor.
5906         (struct gdb_exception_quit): Add constructor.
5907
5908 2019-04-08  Tom Tromey  <tom@tromey.com>
5909
5910         * common/common-exceptions.h (exception_rethrow): Don't declare.
5911         (TRY_SJLJ): Update comment.
5912         (TRY, CATCH, END_CATCH): Remove.
5913         * common/common-exceptions.c (exception_rethrow): Remove.
5914
5915 2019-04-08  Tom Tromey  <tom@tromey.com>
5916
5917         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5918         Remove.
5919         (gdb_exception_error): Rename from
5920         gdb_exception_RETURN_MASK_ERROR.
5921         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5922         (gdb_quit_bad_alloc): Update.
5923         * aarch64-tdep.c: Update.
5924         * ada-lang.c: Update.
5925         * ada-typeprint.c: Update.
5926         * ada-valprint.c: Update.
5927         * amd64-tdep.c: Update.
5928         * arch-utils.c: Update.
5929         * break-catch-throw.c: Update.
5930         * breakpoint.c: Update.
5931         * btrace.c: Update.
5932         * c-varobj.c: Update.
5933         * cli/cli-cmds.c: Update.
5934         * cli/cli-interp.c: Update.
5935         * cli/cli-script.c: Update.
5936         * common/common-exceptions.c: Update.
5937         * common/new-op.c: Update.
5938         * common/selftest.c: Update.
5939         * compile/compile-c-symbols.c: Update.
5940         * compile/compile-cplus-symbols.c: Update.
5941         * compile/compile-object-load.c: Update.
5942         * compile/compile-object-run.c: Update.
5943         * completer.c: Update.
5944         * corelow.c: Update.
5945         * cp-abi.c: Update.
5946         * cp-support.c: Update.
5947         * cp-valprint.c: Update.
5948         * darwin-nat.c: Update.
5949         * disasm-selftests.c: Update.
5950         * dtrace-probe.c: Update.
5951         * dwarf-index-cache.c: Update.
5952         * dwarf-index-write.c: Update.
5953         * dwarf2-frame-tailcall.c: Update.
5954         * dwarf2-frame.c: Update.
5955         * dwarf2loc.c: Update.
5956         * dwarf2read.c: Update.
5957         * eval.c: Update.
5958         * event-loop.c: Update.
5959         * event-top.c: Update.
5960         * exec.c: Update.
5961         * f-valprint.c: Update.
5962         * fbsd-tdep.c: Update.
5963         * frame-unwind.c: Update.
5964         * frame.c: Update.
5965         * gdbtypes.c: Update.
5966         * gnu-v3-abi.c: Update.
5967         * guile/guile-internal.h: Update.
5968         * guile/scm-block.c: Update.
5969         * guile/scm-breakpoint.c: Update.
5970         * guile/scm-cmd.c: Update.
5971         * guile/scm-disasm.c: Update.
5972         * guile/scm-frame.c: Update.
5973         * guile/scm-lazy-string.c: Update.
5974         * guile/scm-math.c: Update.
5975         * guile/scm-param.c: Update.
5976         * guile/scm-ports.c: Update.
5977         * guile/scm-pretty-print.c: Update.
5978         * guile/scm-symbol.c: Update.
5979         * guile/scm-symtab.c: Update.
5980         * guile/scm-type.c: Update.
5981         * guile/scm-value.c: Update.
5982         * i386-linux-tdep.c: Update.
5983         * i386-tdep.c: Update.
5984         * inf-loop.c: Update.
5985         * infcall.c: Update.
5986         * infcmd.c: Update.
5987         * infrun.c: Update.
5988         * jit.c: Update.
5989         * language.c: Update.
5990         * linespec.c: Update.
5991         * linux-fork.c: Update.
5992         * linux-nat.c: Update.
5993         * linux-tdep.c: Update.
5994         * linux-thread-db.c: Update.
5995         * main.c: Update.
5996         * mi/mi-cmd-break.c: Update.
5997         * mi/mi-cmd-stack.c: Update.
5998         * mi/mi-interp.c: Update.
5999         * mi/mi-main.c: Update.
6000         * objc-lang.c: Update.
6001         * p-valprint.c: Update.
6002         * parse.c: Update.
6003         * ppc-linux-tdep.c: Update.
6004         * printcmd.c: Update.
6005         * python/py-arch.c: Update.
6006         * python/py-breakpoint.c: Update.
6007         * python/py-cmd.c: Update.
6008         * python/py-finishbreakpoint.c: Update.
6009         * python/py-frame.c: Update.
6010         * python/py-framefilter.c: Update.
6011         * python/py-gdb-readline.c: Update.
6012         * python/py-inferior.c: Update.
6013         * python/py-infthread.c: Update.
6014         * python/py-lazy-string.c: Update.
6015         * python/py-linetable.c: Update.
6016         * python/py-objfile.c: Update.
6017         * python/py-param.c: Update.
6018         * python/py-prettyprint.c: Update.
6019         * python/py-progspace.c: Update.
6020         * python/py-record-btrace.c: Update.
6021         * python/py-record.c: Update.
6022         * python/py-symbol.c: Update.
6023         * python/py-type.c: Update.
6024         * python/py-unwind.c: Update.
6025         * python/py-utils.c: Update.
6026         * python/py-value.c: Update.
6027         * python/python.c: Update.
6028         * record-btrace.c: Update.
6029         * record-full.c: Update.
6030         * remote-fileio.c: Update.
6031         * remote.c: Update.
6032         * riscv-tdep.c: Update.
6033         * rs6000-aix-tdep.c: Update.
6034         * rs6000-tdep.c: Update.
6035         * rust-exp.y: Update.
6036         * rust-lang.c: Update.
6037         * s390-tdep.c: Update.
6038         * selftest-arch.c: Update.
6039         * solib-dsbt.c: Update.
6040         * solib-frv.c: Update.
6041         * solib-spu.c: Update.
6042         * solib-svr4.c: Update.
6043         * solib.c: Update.
6044         * sparc64-linux-tdep.c: Update.
6045         * stack.c: Update.
6046         * symfile-mem.c: Update.
6047         * symmisc.c: Update.
6048         * target.c: Update.
6049         * thread.c: Update.
6050         * top.c: Update.
6051         * tracefile-tfile.c: Update.
6052         * tui/tui.c: Update.
6053         * typeprint.c: Update.
6054         * unittests/cli-utils-selftests.c: Update.
6055         * unittests/parse-connection-spec-selftests.c: Update.
6056         * valops.c: Update.
6057         * valprint.c: Update.
6058         * value.c: Update.
6059         * varobj.c: Update.
6060         * windows-nat.c: Update.
6061         * x86-linux-nat.c: Update.
6062         * xml-support.c: Update.
6063
6064 2019-04-08  Tom Tromey  <tom@tromey.com>
6065
6066         * xml-support.c: Use C++ exception handling.
6067         * x86-linux-nat.c: Use C++ exception handling.
6068         * windows-nat.c: Use C++ exception handling.
6069         * varobj.c: Use C++ exception handling.
6070         * value.c: Use C++ exception handling.
6071         * valprint.c: Use C++ exception handling.
6072         * valops.c: Use C++ exception handling.
6073         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6074         handling.
6075         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6076         * typeprint.c: Use C++ exception handling.
6077         * tui/tui.c: Use C++ exception handling.
6078         * tracefile-tfile.c: Use C++ exception handling.
6079         * top.c: Use C++ exception handling.
6080         * thread.c: Use C++ exception handling.
6081         * target.c: Use C++ exception handling.
6082         * symmisc.c: Use C++ exception handling.
6083         * symfile-mem.c: Use C++ exception handling.
6084         * stack.c: Use C++ exception handling.
6085         * sparc64-linux-tdep.c: Use C++ exception handling.
6086         * solib.c: Use C++ exception handling.
6087         * solib-svr4.c: Use C++ exception handling.
6088         * solib-spu.c: Use C++ exception handling.
6089         * solib-frv.c: Use C++ exception handling.
6090         * solib-dsbt.c: Use C++ exception handling.
6091         * selftest-arch.c: Use C++ exception handling.
6092         * s390-tdep.c: Use C++ exception handling.
6093         * rust-lang.c: Use C++ exception handling.
6094         * rust-exp.y: Use C++ exception handling.
6095         * rs6000-tdep.c: Use C++ exception handling.
6096         * rs6000-aix-tdep.c: Use C++ exception handling.
6097         * riscv-tdep.c: Use C++ exception handling.
6098         * remote.c: Use C++ exception handling.
6099         * remote-fileio.c: Use C++ exception handling.
6100         * record-full.c: Use C++ exception handling.
6101         * record-btrace.c: Use C++ exception handling.
6102         * python/python.c: Use C++ exception handling.
6103         * python/py-value.c: Use C++ exception handling.
6104         * python/py-utils.c: Use C++ exception handling.
6105         * python/py-unwind.c: Use C++ exception handling.
6106         * python/py-type.c: Use C++ exception handling.
6107         * python/py-symbol.c: Use C++ exception handling.
6108         * python/py-record.c: Use C++ exception handling.
6109         * python/py-record-btrace.c: Use C++ exception handling.
6110         * python/py-progspace.c: Use C++ exception handling.
6111         * python/py-prettyprint.c: Use C++ exception handling.
6112         * python/py-param.c: Use C++ exception handling.
6113         * python/py-objfile.c: Use C++ exception handling.
6114         * python/py-linetable.c: Use C++ exception handling.
6115         * python/py-lazy-string.c: Use C++ exception handling.
6116         * python/py-infthread.c: Use C++ exception handling.
6117         * python/py-inferior.c: Use C++ exception handling.
6118         * python/py-gdb-readline.c: Use C++ exception handling.
6119         * python/py-framefilter.c: Use C++ exception handling.
6120         * python/py-frame.c: Use C++ exception handling.
6121         * python/py-finishbreakpoint.c: Use C++ exception handling.
6122         * python/py-cmd.c: Use C++ exception handling.
6123         * python/py-breakpoint.c: Use C++ exception handling.
6124         * python/py-arch.c: Use C++ exception handling.
6125         * printcmd.c: Use C++ exception handling.
6126         * ppc-linux-tdep.c: Use C++ exception handling.
6127         * parse.c: Use C++ exception handling.
6128         * p-valprint.c: Use C++ exception handling.
6129         * objc-lang.c: Use C++ exception handling.
6130         * mi/mi-main.c: Use C++ exception handling.
6131         * mi/mi-interp.c: Use C++ exception handling.
6132         * mi/mi-cmd-stack.c: Use C++ exception handling.
6133         * mi/mi-cmd-break.c: Use C++ exception handling.
6134         * main.c: Use C++ exception handling.
6135         * linux-thread-db.c: Use C++ exception handling.
6136         * linux-tdep.c: Use C++ exception handling.
6137         * linux-nat.c: Use C++ exception handling.
6138         * linux-fork.c: Use C++ exception handling.
6139         * linespec.c: Use C++ exception handling.
6140         * language.c: Use C++ exception handling.
6141         * jit.c: Use C++ exception handling.
6142         * infrun.c: Use C++ exception handling.
6143         * infcmd.c: Use C++ exception handling.
6144         * infcall.c: Use C++ exception handling.
6145         * inf-loop.c: Use C++ exception handling.
6146         * i386-tdep.c: Use C++ exception handling.
6147         * i386-linux-tdep.c: Use C++ exception handling.
6148         * guile/scm-value.c: Use C++ exception handling.
6149         * guile/scm-type.c: Use C++ exception handling.
6150         * guile/scm-symtab.c: Use C++ exception handling.
6151         * guile/scm-symbol.c: Use C++ exception handling.
6152         * guile/scm-pretty-print.c: Use C++ exception handling.
6153         * guile/scm-ports.c: Use C++ exception handling.
6154         * guile/scm-param.c: Use C++ exception handling.
6155         * guile/scm-math.c: Use C++ exception handling.
6156         * guile/scm-lazy-string.c: Use C++ exception handling.
6157         * guile/scm-frame.c: Use C++ exception handling.
6158         * guile/scm-disasm.c: Use C++ exception handling.
6159         * guile/scm-cmd.c: Use C++ exception handling.
6160         * guile/scm-breakpoint.c: Use C++ exception handling.
6161         * guile/scm-block.c: Use C++ exception handling.
6162         * guile/guile-internal.h: Use C++ exception handling.
6163         * gnu-v3-abi.c: Use C++ exception handling.
6164         * gdbtypes.c: Use C++ exception handling.
6165         * frame.c: Use C++ exception handling.
6166         * frame-unwind.c: Use C++ exception handling.
6167         * fbsd-tdep.c: Use C++ exception handling.
6168         * f-valprint.c: Use C++ exception handling.
6169         * exec.c: Use C++ exception handling.
6170         * event-top.c: Use C++ exception handling.
6171         * event-loop.c: Use C++ exception handling.
6172         * eval.c: Use C++ exception handling.
6173         * dwarf2read.c: Use C++ exception handling.
6174         * dwarf2loc.c: Use C++ exception handling.
6175         * dwarf2-frame.c: Use C++ exception handling.
6176         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6177         * dwarf-index-write.c: Use C++ exception handling.
6178         * dwarf-index-cache.c: Use C++ exception handling.
6179         * dtrace-probe.c: Use C++ exception handling.
6180         * disasm-selftests.c: Use C++ exception handling.
6181         * darwin-nat.c: Use C++ exception handling.
6182         * cp-valprint.c: Use C++ exception handling.
6183         * cp-support.c: Use C++ exception handling.
6184         * cp-abi.c: Use C++ exception handling.
6185         * corelow.c: Use C++ exception handling.
6186         * completer.c: Use C++ exception handling.
6187         * compile/compile-object-run.c: Use C++ exception handling.
6188         * compile/compile-object-load.c: Use C++ exception handling.
6189         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6190         * compile/compile-c-symbols.c: Use C++ exception handling.
6191         * common/selftest.c: Use C++ exception handling.
6192         * common/new-op.c: Use C++ exception handling.
6193         * cli/cli-script.c: Use C++ exception handling.
6194         * cli/cli-interp.c: Use C++ exception handling.
6195         * cli/cli-cmds.c: Use C++ exception handling.
6196         * c-varobj.c: Use C++ exception handling.
6197         * btrace.c: Use C++ exception handling.
6198         * breakpoint.c: Use C++ exception handling.
6199         * break-catch-throw.c: Use C++ exception handling.
6200         * arch-utils.c: Use C++ exception handling.
6201         * amd64-tdep.c: Use C++ exception handling.
6202         * ada-valprint.c: Use C++ exception handling.
6203         * ada-typeprint.c: Use C++ exception handling.
6204         * ada-lang.c: Use C++ exception handling.
6205         * aarch64-tdep.c: Use C++ exception handling.
6206
6207 2019-04-08  Tom Tromey  <tom@tromey.com>
6208
6209         * xml-support.c (gdb_xml_parser::parse): Update.
6210         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6211         * value.c (show_convenience): Update.
6212         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6213         (test_parse_flags_qcs): Update.
6214         * thread.c (thr_try_catch_cmd): Update.
6215         * target.c (target_translate_tls_address): Update.
6216         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6217         (info_frame_command_core, frame_apply_command_count): Update.
6218         * rust-exp.y (rust_lex_exception_test): Update.
6219         * riscv-tdep.c (riscv_print_one_register_info): Update.
6220         * remote.c (remote_target::enable_btrace): Update.
6221         * record-btrace.c (record_btrace_enable_warn): Update.
6222         * python/py-utils.c (gdbpy_convert_exception): Update.
6223         * printcmd.c (do_one_display, print_variable_and_value): Update.
6224         * mi/mi-main.c (mi_print_exception): Update.
6225         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6226         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6227         * linux-nat.c (linux_nat_target::attach): Update.
6228         * linux-fork.c (class scoped_switch_fork_info): Update.
6229         * infrun.c (displaced_step_prepare): Update.
6230         * infcall.c (call_function_by_hand_dummy): Update.
6231         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6232         * gnu-v3-abi.c (print_one_vtable): Update.
6233         * frame.c (get_prev_frame_always): Update.
6234         * f-valprint.c (info_common_command_for_block): Update.
6235         * exec.c (try_open_exec_file): Update.
6236         * exceptions.c (print_exception, exception_print)
6237         (exception_fprintf, exception_print_same): Update.
6238         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6239         * dwarf-index-cache.c (index_cache::store)
6240         (index_cache::lookup_gdb_index): Update.
6241         * darwin-nat.c (maybe_cache_shell): Update.
6242         * cp-valprint.c (cp_print_value_fields): Update.
6243         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6244         (gcc_cplus_symbol_address): Update.
6245         * compile/compile-c-symbols.c (gcc_convert_symbol)
6246         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6247         * common/selftest.c: Update.
6248         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6249         a std::string.
6250         (exception_try_scope_entry, exception_try_scope_exit): Don't
6251         declare.
6252         (struct exception_try_scope): Remove.
6253         (TRY): Don't use exception_try_scope.
6254         (struct gdb_exception): Add constructor, operator=.
6255         <what>: New method.
6256         (struct gdb_exception_RETURN_MASK_ALL)
6257         (struct gdb_exception_RETURN_MASK_ERROR)
6258         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6259         (struct gdb_quit_bad_alloc): Update.
6260         * common/common-exceptions.c (exception_none): Change
6261         initializer.
6262         (struct catcher) <state, exception>: Initialize inline.
6263         <prev>: Remove member.
6264         (current_catcher): Remove.
6265         (catchers): New global.
6266         (exceptions_state_mc_init): Simplify.
6267         (catcher_pop): Remove.
6268         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6269         (try_scope_depth, exception_try_scope_entry)
6270         (exception_try_scope_exit): Remove.
6271         (throw_exception_sjlj): Update.
6272         (exception_messages, exception_messages_size): Remove.
6273         (throw_it): Simplify.
6274         (gdb_exception_sliced_copy): Remove.
6275         (throw_exception_cxx): Update.
6276         * cli/cli-script.c (script_from_file): Update.
6277         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6278         Update.
6279         * ada-valprint.c (ada_val_print): Update.
6280         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6281         (create_excep_cond_exprs): Update.
6282
6283 2019-04-08  Tom Tromey  <tom@tromey.com>
6284
6285         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6286         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6287         (TRY, CATCH, END_CATCH): Remove some definitions.
6288         * common/common-exceptions.c: Don't use GDB_XCPT.
6289         (catcher_list_size): Remove.
6290         (throw_exception, throw_it): Simplify.
6291
6292 2019-04-05  Tom Tromey  <tom@tromey.com>
6293
6294         Revert the header-sorting patch.
6295         * ft32-tdep.c: Revert.
6296         * frv-tdep.c: Revert.
6297         * frv-linux-tdep.c: Revert.
6298         * frame.c: Revert.
6299         * frame-unwind.c: Revert.
6300         * frame-base.c: Revert.
6301         * fork-child.c: Revert.
6302         * findvar.c: Revert.
6303         * findcmd.c: Revert.
6304         * filesystem.c: Revert.
6305         * filename-seen-cache.h: Revert.
6306         * filename-seen-cache.c: Revert.
6307         * fbsd-tdep.c: Revert.
6308         * fbsd-nat.h: Revert.
6309         * fbsd-nat.c: Revert.
6310         * f-valprint.c: Revert.
6311         * f-typeprint.c: Revert.
6312         * f-lang.c: Revert.
6313         * extension.h: Revert.
6314         * extension.c: Revert.
6315         * extension-priv.h: Revert.
6316         * expprint.c: Revert.
6317         * exec.h: Revert.
6318         * exec.c: Revert.
6319         * exceptions.c: Revert.
6320         * event-top.c: Revert.
6321         * event-loop.c: Revert.
6322         * eval.c: Revert.
6323         * elfread.c: Revert.
6324         * dwarf2read.h: Revert.
6325         * dwarf2read.c: Revert.
6326         * dwarf2loc.c: Revert.
6327         * dwarf2expr.h: Revert.
6328         * dwarf2expr.c: Revert.
6329         * dwarf2-frame.c: Revert.
6330         * dwarf2-frame-tailcall.c: Revert.
6331         * dwarf-index-write.h: Revert.
6332         * dwarf-index-write.c: Revert.
6333         * dwarf-index-common.c: Revert.
6334         * dwarf-index-cache.h: Revert.
6335         * dwarf-index-cache.c: Revert.
6336         * dummy-frame.c: Revert.
6337         * dtrace-probe.c: Revert.
6338         * disasm.h: Revert.
6339         * disasm.c: Revert.
6340         * disasm-selftests.c: Revert.
6341         * dictionary.c: Revert.
6342         * dicos-tdep.c: Revert.
6343         * demangle.c: Revert.
6344         * dcache.h: Revert.
6345         * dcache.c: Revert.
6346         * darwin-nat.h: Revert.
6347         * darwin-nat.c: Revert.
6348         * darwin-nat-info.c: Revert.
6349         * d-valprint.c: Revert.
6350         * d-namespace.c: Revert.
6351         * d-lang.c: Revert.
6352         * ctf.c: Revert.
6353         * csky-tdep.c: Revert.
6354         * csky-linux-tdep.c: Revert.
6355         * cris-tdep.c: Revert.
6356         * cris-linux-tdep.c: Revert.
6357         * cp-valprint.c: Revert.
6358         * cp-support.c: Revert.
6359         * cp-namespace.c: Revert.
6360         * cp-abi.c: Revert.
6361         * corelow.c: Revert.
6362         * corefile.c: Revert.
6363         * continuations.c: Revert.
6364         * completer.h: Revert.
6365         * completer.c: Revert.
6366         * complaints.c: Revert.
6367         * coffread.c: Revert.
6368         * coff-pe-read.c: Revert.
6369         * cli-out.h: Revert.
6370         * cli-out.c: Revert.
6371         * charset.c: Revert.
6372         * c-varobj.c: Revert.
6373         * c-valprint.c: Revert.
6374         * c-typeprint.c: Revert.
6375         * c-lang.c: Revert.
6376         * buildsym.c: Revert.
6377         * buildsym-legacy.c: Revert.
6378         * build-id.h: Revert.
6379         * build-id.c: Revert.
6380         * btrace.c: Revert.
6381         * bsd-uthread.c: Revert.
6382         * breakpoint.h: Revert.
6383         * breakpoint.c: Revert.
6384         * break-catch-throw.c: Revert.
6385         * break-catch-syscall.c: Revert.
6386         * break-catch-sig.c: Revert.
6387         * blockframe.c: Revert.
6388         * block.c: Revert.
6389         * bfin-tdep.c: Revert.
6390         * bfin-linux-tdep.c: Revert.
6391         * bfd-target.c: Revert.
6392         * bcache.c: Revert.
6393         * ax-general.c: Revert.
6394         * ax-gdb.h: Revert.
6395         * ax-gdb.c: Revert.
6396         * avr-tdep.c: Revert.
6397         * auxv.c: Revert.
6398         * auto-load.c: Revert.
6399         * arm-wince-tdep.c: Revert.
6400         * arm-tdep.c: Revert.
6401         * arm-symbian-tdep.c: Revert.
6402         * arm-pikeos-tdep.c: Revert.
6403         * arm-obsd-tdep.c: Revert.
6404         * arm-nbsd-tdep.c: Revert.
6405         * arm-nbsd-nat.c: Revert.
6406         * arm-linux-tdep.c: Revert.
6407         * arm-linux-nat.c: Revert.
6408         * arm-fbsd-tdep.c: Revert.
6409         * arm-fbsd-nat.c: Revert.
6410         * arm-bsd-tdep.c: Revert.
6411         * arch-utils.c: Revert.
6412         * arc-tdep.c: Revert.
6413         * arc-newlib-tdep.c: Revert.
6414         * annotate.h: Revert.
6415         * annotate.c: Revert.
6416         * amd64-windows-tdep.c: Revert.
6417         * amd64-windows-nat.c: Revert.
6418         * amd64-tdep.c: Revert.
6419         * amd64-sol2-tdep.c: Revert.
6420         * amd64-obsd-tdep.c: Revert.
6421         * amd64-obsd-nat.c: Revert.
6422         * amd64-nbsd-tdep.c: Revert.
6423         * amd64-nbsd-nat.c: Revert.
6424         * amd64-nat.c: Revert.
6425         * amd64-linux-tdep.c: Revert.
6426         * amd64-linux-nat.c: Revert.
6427         * amd64-fbsd-tdep.c: Revert.
6428         * amd64-fbsd-nat.c: Revert.
6429         * amd64-dicos-tdep.c: Revert.
6430         * amd64-darwin-tdep.c: Revert.
6431         * amd64-bsd-nat.c: Revert.
6432         * alpha-tdep.c: Revert.
6433         * alpha-obsd-tdep.c: Revert.
6434         * alpha-nbsd-tdep.c: Revert.
6435         * alpha-mdebug-tdep.c: Revert.
6436         * alpha-linux-tdep.c: Revert.
6437         * alpha-linux-nat.c: Revert.
6438         * alpha-bsd-tdep.c: Revert.
6439         * alpha-bsd-nat.c: Revert.
6440         * aix-thread.c: Revert.
6441         * agent.c: Revert.
6442         * addrmap.c: Revert.
6443         * ada-varobj.c: Revert.
6444         * ada-valprint.c: Revert.
6445         * ada-typeprint.c: Revert.
6446         * ada-tasks.c: Revert.
6447         * ada-lang.c: Revert.
6448         * aarch64-tdep.c: Revert.
6449         * aarch64-ravenscar-thread.c: Revert.
6450         * aarch64-newlib-tdep.c: Revert.
6451         * aarch64-linux-tdep.c: Revert.
6452         * aarch64-linux-nat.c: Revert.
6453         * aarch64-fbsd-tdep.c: Revert.
6454         * aarch64-fbsd-nat.c: Revert.
6455         * aarch32-linux-nat.c: Revert.
6456
6457 2019-04-05  Tom Tromey  <tom@tromey.com>
6458
6459         * ft32-tdep.c: Sort headers.
6460         * frv-tdep.c: Sort headers.
6461         * frv-linux-tdep.c: Sort headers.
6462         * frame.c: Sort headers.
6463         * frame-unwind.c: Sort headers.
6464         * frame-base.c: Sort headers.
6465         * fork-child.c: Sort headers.
6466         * findvar.c: Sort headers.
6467         * findcmd.c: Sort headers.
6468         * filesystem.c: Sort headers.
6469         * filename-seen-cache.h: Sort headers.
6470         * filename-seen-cache.c: Sort headers.
6471         * fbsd-tdep.c: Sort headers.
6472         * fbsd-nat.h: Sort headers.
6473         * fbsd-nat.c: Sort headers.
6474         * f-valprint.c: Sort headers.
6475         * f-typeprint.c: Sort headers.
6476         * f-lang.c: Sort headers.
6477         * extension.h: Sort headers.
6478         * extension.c: Sort headers.
6479         * extension-priv.h: Sort headers.
6480         * expprint.c: Sort headers.
6481         * exec.h: Sort headers.
6482         * exec.c: Sort headers.
6483         * exceptions.c: Sort headers.
6484         * event-top.c: Sort headers.
6485         * event-loop.c: Sort headers.
6486         * eval.c: Sort headers.
6487         * elfread.c: Sort headers.
6488         * dwarf2read.h: Sort headers.
6489         * dwarf2read.c: Sort headers.
6490         * dwarf2loc.c: Sort headers.
6491         * dwarf2expr.h: Sort headers.
6492         * dwarf2expr.c: Sort headers.
6493         * dwarf2-frame.c: Sort headers.
6494         * dwarf2-frame-tailcall.c: Sort headers.
6495         * dwarf-index-write.h: Sort headers.
6496         * dwarf-index-write.c: Sort headers.
6497         * dwarf-index-common.c: Sort headers.
6498         * dwarf-index-cache.h: Sort headers.
6499         * dwarf-index-cache.c: Sort headers.
6500         * dummy-frame.c: Sort headers.
6501         * dtrace-probe.c: Sort headers.
6502         * disasm.h: Sort headers.
6503         * disasm.c: Sort headers.
6504         * disasm-selftests.c: Sort headers.
6505         * dictionary.c: Sort headers.
6506         * dicos-tdep.c: Sort headers.
6507         * demangle.c: Sort headers.
6508         * dcache.h: Sort headers.
6509         * dcache.c: Sort headers.
6510         * darwin-nat.h: Sort headers.
6511         * darwin-nat.c: Sort headers.
6512         * darwin-nat-info.c: Sort headers.
6513         * d-valprint.c: Sort headers.
6514         * d-namespace.c: Sort headers.
6515         * d-lang.c: Sort headers.
6516         * ctf.c: Sort headers.
6517         * csky-tdep.c: Sort headers.
6518         * csky-linux-tdep.c: Sort headers.
6519         * cris-tdep.c: Sort headers.
6520         * cris-linux-tdep.c: Sort headers.
6521         * cp-valprint.c: Sort headers.
6522         * cp-support.c: Sort headers.
6523         * cp-namespace.c: Sort headers.
6524         * cp-abi.c: Sort headers.
6525         * corelow.c: Sort headers.
6526         * corefile.c: Sort headers.
6527         * continuations.c: Sort headers.
6528         * completer.h: Sort headers.
6529         * completer.c: Sort headers.
6530         * complaints.c: Sort headers.
6531         * coffread.c: Sort headers.
6532         * coff-pe-read.c: Sort headers.
6533         * cli-out.h: Sort headers.
6534         * cli-out.c: Sort headers.
6535         * charset.c: Sort headers.
6536         * c-varobj.c: Sort headers.
6537         * c-valprint.c: Sort headers.
6538         * c-typeprint.c: Sort headers.
6539         * c-lang.c: Sort headers.
6540         * buildsym.c: Sort headers.
6541         * buildsym-legacy.c: Sort headers.
6542         * build-id.h: Sort headers.
6543         * build-id.c: Sort headers.
6544         * btrace.c: Sort headers.
6545         * bsd-uthread.c: Sort headers.
6546         * breakpoint.h: Sort headers.
6547         * breakpoint.c: Sort headers.
6548         * break-catch-throw.c: Sort headers.
6549         * break-catch-syscall.c: Sort headers.
6550         * break-catch-sig.c: Sort headers.
6551         * blockframe.c: Sort headers.
6552         * block.c: Sort headers.
6553         * bfin-tdep.c: Sort headers.
6554         * bfin-linux-tdep.c: Sort headers.
6555         * bfd-target.c: Sort headers.
6556         * bcache.c: Sort headers.
6557         * ax-general.c: Sort headers.
6558         * ax-gdb.h: Sort headers.
6559         * ax-gdb.c: Sort headers.
6560         * avr-tdep.c: Sort headers.
6561         * auxv.c: Sort headers.
6562         * auto-load.c: Sort headers.
6563         * arm-wince-tdep.c: Sort headers.
6564         * arm-tdep.c: Sort headers.
6565         * arm-symbian-tdep.c: Sort headers.
6566         * arm-pikeos-tdep.c: Sort headers.
6567         * arm-obsd-tdep.c: Sort headers.
6568         * arm-nbsd-tdep.c: Sort headers.
6569         * arm-nbsd-nat.c: Sort headers.
6570         * arm-linux-tdep.c: Sort headers.
6571         * arm-linux-nat.c: Sort headers.
6572         * arm-fbsd-tdep.c: Sort headers.
6573         * arm-fbsd-nat.c: Sort headers.
6574         * arm-bsd-tdep.c: Sort headers.
6575         * arch-utils.c: Sort headers.
6576         * arc-tdep.c: Sort headers.
6577         * arc-newlib-tdep.c: Sort headers.
6578         * annotate.h: Sort headers.
6579         * annotate.c: Sort headers.
6580         * amd64-windows-tdep.c: Sort headers.
6581         * amd64-windows-nat.c: Sort headers.
6582         * amd64-tdep.c: Sort headers.
6583         * amd64-sol2-tdep.c: Sort headers.
6584         * amd64-obsd-tdep.c: Sort headers.
6585         * amd64-obsd-nat.c: Sort headers.
6586         * amd64-nbsd-tdep.c: Sort headers.
6587         * amd64-nbsd-nat.c: Sort headers.
6588         * amd64-nat.c: Sort headers.
6589         * amd64-linux-tdep.c: Sort headers.
6590         * amd64-linux-nat.c: Sort headers.
6591         * amd64-fbsd-tdep.c: Sort headers.
6592         * amd64-fbsd-nat.c: Sort headers.
6593         * amd64-dicos-tdep.c: Sort headers.
6594         * amd64-darwin-tdep.c: Sort headers.
6595         * amd64-bsd-nat.c: Sort headers.
6596         * alpha-tdep.c: Sort headers.
6597         * alpha-obsd-tdep.c: Sort headers.
6598         * alpha-nbsd-tdep.c: Sort headers.
6599         * alpha-mdebug-tdep.c: Sort headers.
6600         * alpha-linux-tdep.c: Sort headers.
6601         * alpha-linux-nat.c: Sort headers.
6602         * alpha-bsd-tdep.c: Sort headers.
6603         * alpha-bsd-nat.c: Sort headers.
6604         * aix-thread.c: Sort headers.
6605         * agent.c: Sort headers.
6606         * addrmap.c: Sort headers.
6607         * ada-varobj.c: Sort headers.
6608         * ada-valprint.c: Sort headers.
6609         * ada-typeprint.c: Sort headers.
6610         * ada-tasks.c: Sort headers.
6611         * ada-lang.c: Sort headers.
6612         * aarch64-tdep.c: Sort headers.
6613         * aarch64-ravenscar-thread.c: Sort headers.
6614         * aarch64-newlib-tdep.c: Sort headers.
6615         * aarch64-linux-tdep.c: Sort headers.
6616         * aarch64-linux-nat.c: Sort headers.
6617         * aarch64-fbsd-tdep.c: Sort headers.
6618         * aarch64-fbsd-nat.c: Sort headers.
6619         * aarch32-linux-nat.c: Sort headers.
6620
6621 2019-04-04  Tom Tromey  <tom@tromey.com>
6622
6623         * varobj.c (varobj_create): Update.
6624         * rust-exp.y (struct rust_parser) <update_innermost_block,
6625         lookup_symbol>: New methods.
6626         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6627         Rename.
6628         (rust_parser::rust_lookup_type)
6629         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6630         * printcmd.c (display_command, do_one_display): Update.
6631         * parser-defs.h (struct parser_state) <parser_state>: Add
6632         "tracker" parameter.
6633         (block_tracker): New member.
6634         (class innermost_block_tracker) <innermost_block_tracker>: Add
6635         "types" parameter.
6636         <reset>: Remove method.
6637         (innermost_block): Don't declare.
6638         (null_post_parser): Update.
6639         * parse.c (innermost_block): Remove global.
6640         (write_dollar_variable): Update.
6641         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6642         Remove "tracker_types" parameter.
6643         (parse_expression): Add "tracker" parameter.
6644         (parse_expression_for_completion): Update.
6645         (null_post_parser): Add "tracker" parameter.
6646         * p-exp.y: Update rules.
6647         * m2-exp.y: Update rules.
6648         * language.h (struct language_defn) <la_post_parser>: Add
6649         "tracker" parameter.
6650         * go-exp.y: Update rules.
6651         * f-exp.y: Update rules.
6652         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6653         parameter.
6654         * d-exp.y: Update rules.
6655         * c-exp.y: Update rules.
6656         * breakpoint.c (set_breakpoint_condition): Create an
6657         innermost_block_tracker.
6658         (watch_command_1): Likewise.
6659         * ada-lang.c (resolve): Add "tracker" parameter.
6660         (resolve_subexp): Likewise.
6661         * ada-exp.y (write_var_from_sym): Update.
6662
6663 2019-04-04  Tom Tromey  <tom@tromey.com>
6664
6665         * type-stack.h: New file.
6666         * type-stack.c: New file.
6667         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6668         type-stack.h.
6669         (insert_into_type_stack, insert_type, push_type, push_type_int)
6670         (insert_type_address_space, pop_type, pop_type_int)
6671         (pop_typelist, pop_type_stack, append_type_stack)
6672         (push_type_stack, get_type_stack, push_typelist)
6673         (follow_type_instance_flags, follow_types): Don't declare.
6674         * parse.c (type_stack): Remove global.
6675         (parse_exp_in_context): Update.
6676         (insert_into_type_stack, insert_type, push_type, push_type_int)
6677         (insert_type_address_space, pop_type, pop_type_int)
6678         (pop_typelist, pop_type_stack, append_type_stack)
6679         (push_type_stack, get_type_stack, push_typelist)
6680         (follow_type_instance_flags, follow_types): Remove (moved to
6681         type-stack.c).
6682         * f-exp.y (type_stack): New global.
6683         Update rules.
6684         (push_kind_type, f_parse): Update.
6685         * d-exp.y (type_stack): New global.
6686         Update rules.
6687         (d_parse): Update.
6688         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6689         Update rules.
6690         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6691         (HFILES_NO_SRCDIR): Add type-stack.h.
6692
6693 2019-04-04  Tom Tromey  <tom@tromey.com>
6694
6695         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6696         (rust_parser::convert_ast_to_expression, rust_parse)
6697         (rust_lex_test_completion, rust_lex_tests): Update.
6698         * parser-defs.h (struct expr_completion_state): New.
6699         (struct parser_state) <parser_state>: Add completion parameter.
6700         <mark_struct_expression, mark_completion_tag>: New methods.
6701         <parse_completion, m_completion_state>: New members.
6702         (prefixify_expression, null_post_parser): Update.
6703         (mark_struct_expression, mark_completion_tag): Don't declare.
6704         * parse.c (parse_completion, expout_last_struct)
6705         (expout_tag_completion_type, expout_completion_name): Remove
6706         globals.
6707         (parser_state::mark_struct_expression)
6708         (parser_state::mark_completion_tag): Now methods.
6709         (prefixify_expression): Add last_struct parameter.
6710         (prefixify_subexp): Likewise.
6711         (parse_exp_1): Update.
6712         (parse_exp_in_context): Add cstate parameter.  Update.
6713         (parse_expression_for_completion): Create an
6714         expr_completion_state.
6715         (null_post_parser): Add "completion" parameter.
6716         * p-exp.y: Update rules.
6717         (yylex): Update.
6718         * language.h (struct language_defn) <la_post_parser>: Add
6719         "completing" parameter.
6720         * go-exp.y: Update rules.
6721         (lex_one_token): Update.
6722         * expression.h (parse_completion): Don't declare.
6723         * d-exp.y: Update rules.
6724         (lex_one_token): Update rules.
6725         * c-exp.y: Update rules.
6726         (lex_one_token): Update.
6727         * ada-lang.c (resolve): Add "parse_completion" parameter.
6728         (resolve_subexp): Likewise.
6729         (ada_resolve_function): Likewise.
6730
6731 2019-04-04  Tom Tromey  <tom@tromey.com>
6732
6733         * parser-defs.h (struct parser_state) <start_arglist,
6734         end_arglist>: New methods.
6735         <arglist_len, m_funcall_chain>: New members.
6736         (arglist_len, start_arglist, end_arglist): Don't declare.
6737         * parse.c (arglist_len, funcall_chain): Remove global.
6738         (start_arglist, end_arglist): Remove functions.
6739         (parse_exp_in_context): Update.
6740         * p-exp.y: Update rules.
6741         * m2-exp.y: Update rules.
6742         * go-exp.y: Update rules.
6743         * f-exp.y: Update rules.
6744         * d-exp.y: Update rules.
6745         * c-exp.y: Update rules.
6746
6747 2019-04-04  Tom Tromey  <tom@tromey.com>
6748
6749         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6750         lex_operator, push_back>: New methods.
6751         Update all rules.
6752         (rust_parser::lex_hex, lex_escape): Rename and update.
6753         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6754         (rust_parser::lex_operator): Rename and update.
6755         (rust_parser::lex_number, rustyylex, rustyyerror)
6756         (rust_lex_test_init, rust_lex_test_sequence)
6757         (rust_lex_test_push_back, rust_lex_tests): Update.
6758         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6759         parameter.
6760         <lexptr, prev_lexptr>: New members.
6761         (lexptr, prev_lexptr): Don't declare.
6762         * parse.c (lexptr, prev_lexptr): Remove globals.
6763         (parse_exp_in_context): Update.
6764         * p-exp.y (yylex, yyerror): Update.
6765         * m2-exp.y (parse_number, yylex, yyerror): Update.
6766         * go-exp.y (lex_one_token, yyerror): Update.
6767         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6768         * d-exp.y (lex_one_token, yyerror): Update.
6769         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6770         (lex_one_token, yyerror): Update.
6771         * ada-lex.l (YY_INPUT): Update.
6772         (rewind_to_char): Update.
6773         * ada-exp.y (yyerror): Update.
6774
6775 2019-04-04  Tom Tromey  <tom@tromey.com>
6776
6777         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6778         * parser-defs.h (struct parser_state) <parser_state>: Add new
6779         parameter.
6780         <comma_terminates>: New member.
6781         (comma_terminates): Don't declare global.
6782         * parse.c (comma_terminates): Remove global.
6783         (parse_exp_in_context): Update.
6784         * p-exp.y (yylex): Update.
6785         * m2-exp.y (yylex): Update.
6786         * go-exp.y (lex_one_token): Update.
6787         * f-exp.y (yylex): Update.
6788         * d-exp.y (lex_one_token): Update.
6789         * c-exp.y (lex_one_token): Update.
6790         * ada-lex.l: Update.
6791
6792 2019-04-04  Tom Tromey  <tom@tromey.com>
6793
6794         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6795         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6796         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6797         * parser-defs.h (paren_depth): Don't declare.
6798         * parse.c (paren_depth): Remove global.
6799         (parse_exp_in_context): Update.
6800         * p-exp.y (paren_depth): New global.
6801         (pascal_parse): Initialize it.
6802         * m2-exp.y (paren_depth): New global.
6803         (m2_parse): Initialize it.
6804         * go-exp.y (paren_depth): New global.
6805         (go_parse): Initialize it.
6806         * f-exp.y (paren_depth): New global.
6807         (f_parse): Initialize it.
6808         * d-exp.y (paren_depth): New global.
6809         (d_parse): Initialize it.
6810         * c-exp.y (paren_depth): New global.
6811         (c_parse): Initialize it.
6812         * ada-lex.l (paren_depth): New global.
6813         (lexer_init): Initialize it.
6814
6815 2019-04-04  Tom Tromey  <tom@tromey.com>
6816
6817         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6818         (rust_parser::convert_ast_to_type)
6819         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6820         * parser-defs.h (struct parser_state) <parser_state>: Add
6821         parameters.  Initialize new members.
6822         <expression_context_block, expression_context_pc>: New members.
6823         * parse.c (expression_context_block, expression_context_pc):
6824         Remove globals.
6825         (parse_exp_in_context): Update.
6826         * p-exp.y: Update all rules.
6827         (yylex): Update.
6828         * m2-exp.y: Update all rules.
6829         (yylex): Update.
6830         * go-exp.y (yylex): Update.
6831         * f-exp.y (yylex): Update.
6832         * d-exp.y: Update all rules.
6833         (yylex): Update.
6834         * c-exp.y: Update all rules.
6835         (lex_one_token, classify_name, yylex, c_parse): Update.
6836         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6837
6838 2019-04-04  Tom Tromey  <tom@tromey.com>
6839
6840         * gdbarch.h, gdbarch.c: Rebuild.
6841         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6842         * stap-probe.h: 
6843         (struct stap_parse_info): Replace "parser_state" with
6844         "expr_builder".
6845         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6846         (parser_state): New class.
6847         * parse.c (expr_builder): Rename.
6848         (expr_builder::release): Rename.
6849         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6850         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6851         (write_exp_elt_longcst, write_exp_elt_floatcst)
6852         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6853         (write_exp_string_vector, write_exp_bitstring)
6854         (write_exp_msymbol, mark_struct_expression)
6855         (write_dollar_variable)
6856         (insert_type_address_space, increase_expout_size): Replace
6857         "parser_state" with "expr_builder".
6858         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6859         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6860         "parser_state" with "expr_builder".
6861
6862 2019-04-04  Tom Tromey  <tom@tromey.com>
6863
6864         * rust-exp.y: Replace "parse_language" with method call.
6865         * p-exp.y: 
6866         (yylex): Replace "parse_language" with method call.
6867         * m2-exp.y: 
6868         (yylex): Replace "parse_language" with method call.
6869         * go-exp.y (classify_name): Replace "parse_language" with method
6870         call.
6871         * f-exp.y (yylex): Replace "parse_language" with method call.
6872         * d-exp.y (lex_one_token): Replace "parse_language" with method
6873         call.
6874         * c-exp.y: 
6875         (lex_one_token, classify_name, yylex): Replace "parse_language"
6876         with method call.
6877         * ada-exp.y (find_primitive_type, type_char)
6878         (type_system_address): Replace "parse_language" with method call.
6879
6880 2019-04-04  Tom Tromey  <tom@tromey.com>
6881
6882         * rust-exp.y: Replace "parse_gdbarch" with method call.
6883         * parse.c (write_dollar_variable, insert_type_address_space):
6884         Replace "parse_gdbarch" with method call.
6885         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6886         call.
6887         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6888         call.
6889         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6890         "parse_gdbarch" with method call.
6891         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6892         with method call.
6893         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6894         "parse_gdbarch" with method call.
6895         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6896         "parse_gdbarch" with method call.
6897         * c-exp.y (parse_type, parse_number, classify_name): Replace
6898         "parse_gdbarch" with method call.
6899         * ada-lex.l: Replace "parse_gdbarch" with method call.
6900         * ada-exp.y (parse_type, find_primitive_type, type_char)
6901         (type_system_address): Replace "parse_gdbarch" with method call.
6902
6903 2019-04-04  Tom Tromey  <tom@tromey.com>
6904
6905         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6906         * stap-probe.c (stap_parse_argument): Update.
6907         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6908         initial_size parameter.
6909         * rust-exp.y (rust_lex_tests): Update.
6910         * parse.c (parser_state): Update.
6911         (parse_exp_in_context): Update.
6912         * parser-defs.h (struct parser_state) <parser_state>: Remove
6913         "initial_size" parameter.
6914
6915 2019-04-04  Tom Tromey  <tom@tromey.com>
6916
6917         * parser-defs.h (increase_expout_size): Don't declare.
6918         * parse.c (increase_expout_size): Now static.
6919
6920 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6921
6922         * gnu-nat.c (gnu_nat_target::wait): Fix
6923         target_waitstatus_to_string call.
6924
6925 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6926
6927         * eval.c (evaluate_subexp_standard): Handle internal functions
6928         during Fortran function call handling.
6929
6930 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6931
6932         * NEWS: Mention new internal functions.
6933         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6934         (read_base_type): Use dwarf2_init_complex_target_type.
6935         * value.c (creal_internal_fn): New function.
6936         (cimag_internal_fn): New function.
6937         (_initialize_values): Register new internal functions.
6938
6939 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6940
6941         * infrun.c (stop_all_threads): If debug_infrun, always
6942         trace the wait status after wait_one, using
6943         target_waitstatus_to_string and target_pid_to_str.
6944         (handle_inferior_event): Replace various trace of
6945         wait status kind by a single trace.
6946         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6947         wait status kind image by target_waitstatus_to_string.
6948         * target/waitstatus.c (target_waitstatus_to_string): Fix
6949         obsolete comment.
6950
6951 2019-04-01  Tom Tromey  <tromey@adacore.com>
6952
6953         PR symtab/23331:
6954         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6955
6956 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6957             Pedro Alves  <palves@redhat.com>
6958
6959         * top.c (quit_force): Call 'finalize_values'.
6960         * value.c (finalize_values): New function.
6961         * value.h (finalize_values): Declare.
6962
6963 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6964
6965         * NEWS: Announce $_gdb_major and $_gdb_minor.
6966
6967         * top.c (init_gdb_version_vars): New function.
6968         (gdb_init): Call init_gdb_version_vars.
6969
6970 2019-03-29  Tom Tromey  <tromey@adacore.com>
6971
6972         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6973         help text.  Remove dead code.
6974
6975 2019-03-29  Keith Seitz  <keiths@redhat.com>
6976
6977         From Siddhesh Poyarekar:
6978         * f-lang.h (f77_get_upperbound): Return LONGEST.
6979         (f77_get_lowerbound): Likewise.
6980         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6981         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6982         print them.
6983         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6984         plongest to format print it.
6985         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6986         (f77_get_upperbound): Likewise.
6987         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6988         LOWER_BOUND to LONGEST.
6989         (f77_create_arrayprint_offset_tbl): Likewise.
6990
6991 2019-03-29  Keith Seitz  <keiths@redhat.com>
6992
6993         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6994         %s/pulongest for TYPE_LENGTH instead of %d in format
6995         strings.
6996         * ada-typerint.c (ada_print_type): Likewise.
6997         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6998         * compile/compile-c-support.c (generate_register_struct): Likewise.
6999         * gdbtypes.c (recursive_dump_type): Likewise.
7000         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7001         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7002         instead of %d in format strings.
7003         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7004         to std::min to ULONGEST.
7005         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7006         instead of %d in format strings.
7007         * tracepoint.c (info_scope_command): Likewise.
7008         * typeprint.c (print_offset_data::update)
7009         (print_offset_data::finish): Likewise.
7010         * xtensa-tdep.c (xtensa_store_return_value)
7011         (xtensa_push_dummy_call): Likewise.
7012
7013 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7014
7015         * windows-nat.c (display_selector): Fixed format specifications
7016         for 64-bit Cygwin.
7017
7018 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7019
7020         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7021
7022 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7023
7024         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7025         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7026         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7027         (nios2_linux_init_abi): Install it.
7028
7029 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7030
7031         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7032
7033 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7034
7035         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7036
7037 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7038             Tom Tromey  <tromey@adacore.com>
7039
7040         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7041
7042 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7043
7044         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7045         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7046         method to compute the bounds of range types. Also print "[evaluated]"
7047         if the bounds' values come from a dynamic evaluation.
7048
7049 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7050
7051         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7052         whitespace when pretty printing is on.
7053
7054 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7055
7056         * ppc-linux-nat.c: Add include.
7057
7058 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7059
7060         * NEWS: Mention AArch64 Pointer Authentication.
7061
7062 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7063
7064         * arm-linux-nat.c: Add include.
7065
7066 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7067
7068         * source-cache.c (source_cache::get_source_lines): Re-read
7069         fullname after calling open_source_file.
7070
7071 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7072
7073         * NEWS: Mention TLS support for FreeBSD.
7074
7075 2019-03-25  Tom Tromey  <tromey@adacore.com>
7076
7077         * minsyms.c (BUNCH_SIZE): Update comment.
7078         (~minimal_symbol_reader): Remove old comment.
7079         (compact_minimal_symbols): Update comment.
7080         (minimal_symbol_reader::install): Remove old comment.  Update
7081         other comments.
7082
7083 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7084
7085         * s390-linux-nat.c: Add include.
7086
7087 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7088
7089         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7090         Call linux_get_hwcap.
7091         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7092         Likewise.
7093         (aarch64_linux_get_hwcap): Remove function.
7094         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7095         declaration.
7096         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7097         linux_get_hwcap.
7098         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7099         * linux-tdep.c (linux_get_hwcap): Add function.
7100         (linux_get_hwcap2): Likewise.
7101         * linux-tdep.h (linux_get_hwcap): Add declaration.
7102         (linux_get_hwcap2): Likewise.
7103         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7104         (ppc_linux_get_hwcap2): Likewise.
7105         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7106         linux_get_hwcap.
7107         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7108         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7109         (ppc_linux_nat_target::read_description): Likewise.
7110         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7111         * s390-linux-nat.c: Likewise.
7112         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7113
7114 2019-03-24  Tom Tromey  <tom@tromey.com>
7115
7116         * ada-lang.c (standard_lookup): Simplify initialization.
7117         (ada_lookup_symbol_nonlocal): Simplify return.
7118         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7119         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7120         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7121         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7122         initialization.
7123         * solib.c (solib_global_lookup): Simplify.
7124         * symtab.c (null_block_symbol): Remove.
7125         (symbol_cache_lookup): Simplify returns.
7126         (lookup_language_this): Simplify returns.
7127         (lookup_symbol_aux): Simplify return.
7128         (lookup_local_symbol): Simplify returns.
7129         (lookup_global_symbol_from_objfile): Simplify return.
7130         (lookup_symbol_in_objfile_symtabs)
7131         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7132         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7133         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7134         * cp-namespace.c (cp_lookup_bare_symbol)
7135         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7136         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7137         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7138         (cp_lookup_symbol_via_imports): Simplify initialization.
7139         (find_symbol_in_baseclass): Likewise.
7140         * symtab.h (null_block_symbol): Remove.
7141         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7142         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7143         (d_lookup_symbol_module): Likewise.
7144         (find_symbol_in_baseclass): Simplify initialization.
7145
7146 2019-03-24  Tom Tromey  <tom@tromey.com>
7147
7148         * expression.h: Don't include symtab.h.
7149         (struct block): Forward declare.
7150
7151 2019-03-24  Tom Tromey  <tom@tromey.com>
7152
7153         * c-exp.y (typebase): Remove casts.
7154         * gdbtypes.c (lookup_unsigned_typename, )
7155         (lookup_signed_typename): Remove cast.
7156         * eval.c (parse_to_comma_and_eval): Remove cast.
7157         * parse.c (write_dollar_variable): Remove cast.
7158         * block.h (struct block) <superblock>: Now const.
7159         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7160         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7161         (map_block): Make "block" const.
7162         * symfile.h (struct quick_symbol_functions)
7163         <map_matching_symbols>: Constify block argument to "callback".
7164         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7165         const.
7166         (find_pc_sect_compunit_symtab): Make "b" const.
7167         (find_symbol_at_address): Likewise.
7168         (search_symbols): Likewise.
7169         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7170         (dw2_debug_names_lookup_symbol): Likewise.
7171         (dw2_map_matching_symbols): Update.
7172         * p-valprint.c (pascal_val_print): Remove "block".
7173         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7174         (aux_add_nonlocal_symbols): Make "block" const.
7175         (resolve_subexp): Remove cast.
7176         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7177         const.
7178         (iterate_over_file_blocks): Likewise.
7179         * f-exp.y (%union) <bval>: Remove.
7180         * coffread.c (patch_opaque_types): Make "b" const.
7181         * spu-tdep.c (spu_catch_start): Make "block" const.
7182         * c-valprint.c (print_unpacked_pointer): Remove "block".
7183         * symmisc.c (dump_symtab_1): Make "b" const.
7184         (block_depth): Make "block" const.
7185         * d-exp.y (%union) <bval>: Remove.
7186         * cp-support.h (cp_lookup_rtti_type): Update.
7187         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7188         * psymtab.c (psym_lookup_symbol): Make "block" const.
7189         (maintenance_check_psymtabs): Make "b" const.
7190         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7191         (enumerate_locals, enumerate_args): Update.
7192         * python/py-symtab.c (stpy_global_block): Make "block" const.
7193         (stpy_static_block): Likewise.
7194         * inline-frame.c (block_starting_point_at): Make "new_block"
7195         const.
7196         * block.c (find_block_in_blockvector): Make return type const.
7197         (blockvector_for_pc_sect): Make "b" const.
7198         (find_block_in_blockvector): Make "b" const.
7199
7200 2019-03-23  Tom Tromey  <tom@tromey.com>
7201
7202         * varobj.c (varobj_create): Update.
7203         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7204         * printcmd.c (display_command, do_one_display): Don't reset
7205         innermost_block.
7206         * parser-defs.h (enum innermost_block_tracker_type): Move to
7207         expression.h.
7208         (innermost_block): Update comment.
7209         * parse.c (parse_exp_1): Add tracker_types parameter.
7210         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7211         tracker_types parameter.  Reset innermost_block.
7212         (parse_exp_in_context): Remove.
7213         (parse_expression_for_completion): Update.
7214         * objfiles.c (~objfile): Don't reset expression_context_block or
7215         innermost_block.
7216         * expression.h (enum innermost_block_tracker_type): Move from
7217         parser-defs.h.
7218         (parse_exp_1): Add tracker_types parameter.
7219         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7220         reset innermost_block.
7221
7222 2019-03-23  Tom Tromey  <tom@tromey.com>
7223
7224         * objfiles.h: Include bcache.h.
7225
7226 2019-03-23  Tom Tromey  <tom@tromey.com>
7227
7228         * linespec.c (get_current_search_block): Use
7229         scoped_restore_current_language.
7230         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7231
7232 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7233             Jiong Wang  <jiong.wang@arm.com>
7234
7235         * aarch64-linux-tdep.c
7236         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7237         section.
7238         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7239
7240 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7241             Jiong Wang  <jiong.wang@arm.com>
7242
7243         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7244         instructions.
7245         (aarch64_analyze_prologue_test): Add PACIASP test.
7246         (aarch64_prologue_prev_register): Unmask PC value.
7247
7248 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7249             Jiong Wang  <jiong.wang@arm.com>
7250
7251         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7252         (aarch64_dwarf2_prev_register): Unmask PC value.
7253         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7254         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7255         DW_CFA_AARCH64_negate_ra_state.
7256         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7257
7258 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7259             Jiong Wang  <jiong.wang@arm.com>
7260
7261         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7262         registers.
7263         (aarch64_pseudo_register_name): Likewise.
7264         (aarch64_pseudo_register_type): Likewise.
7265         (aarch64_pseudo_register_reggroup_p): Likewise.
7266         (aarch64_gdbarch_init): Add pauth registers.
7267         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7268         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7269         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7270         (struct gdbarch_tdep): Add regnum for ra_state.
7271
7272 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7273             Jiong Wang  <jiong.wang@arm.com>
7274
7275         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7276
7277 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7278             Jiong Wang  <jiong.wang@arm.com>
7279
7280         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7281         function.
7282         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7283         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7284         (aarch64_gdbarch_init): Add puth registers.
7285         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7286         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7287         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7288
7289 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7290             Jiong Wang  <jiong.wang@arm.com>
7291
7292         * aarch64-linux-nat.c
7293         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7294         * aarch64-linux-tdep.c
7295         (aarch64_linux_core_read_description): Likewise.
7296         (aarch64_linux_get_hwcap): New function.
7297         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7298         (aarch64_linux_get_hwcap): New declaration.
7299
7300 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7301             Jiong Wang  <jiong.wang@arm.com>
7302
7303         * aarch64-linux-nat.c
7304         (aarch64_linux_nat_target::read_description): Add pauth param.
7305         * aarch64-linux-tdep.c
7306         (aarch64_linux_core_read_description): Likewise.
7307         * aarch64-tdep.c (struct target_desc): Add in pauth.
7308         (aarch64_read_description): Add pauth param.
7309         (aarch64_gdbarch_init): Likewise.
7310         * aarch64-tdep.h (aarch64_read_description): Likewise.
7311         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7312         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7313         * features/Makefile: Add new files.
7314         * features/aarch64-pauth.c: New file.
7315         * features/aarch64-pauth.xml: New file.
7316
7317 2019-03-20  Tom Tromey  <tromey@adacore.com>
7318
7319         * infrun.c (handle_inferior_event): Rename from
7320         handle_inferior_event_1.  Create a scoped_value_mark.
7321         (handle_inferior_event): Remove.
7322
7323 2019-03-19  Tom Tromey  <tromey@adacore.com>
7324
7325         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7326         * infrun.h (print_stop_event): Add "displays" parameter.
7327         * infrun.c (print_stop_event): Add "displays" parameter.
7328
7329 2019-03-19  Pedro Alves  <palves@redhat.com>
7330
7331         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7332         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7333         to -1.  Fix TABs vs spaces.
7334         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7335         * tui/tui-out.h (tui_ui_out) Add intro comments.
7336         <m_line, m_start_of_line>: In-class initialize, and add describing
7337         comment.
7338
7339 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7340
7341         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7342         variable names.
7343         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7344
7345 2019-03-18  Pedro Alves  <palves@redhat.com>
7346             Eli Zaretskii <eliz@gnu.org>
7347
7348         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7349         m_line and m_start_of_line.
7350
7351 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7352
7353         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7354         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7355         it returns a newline.  This fixes a regression in TU mode, whereby
7356         the next line is output on the same screen line as the user input.
7357
7358 2019-03-18  Tom Tromey  <tromey@adacore.com>
7359
7360         * minsyms.c (minimal_symbol_reader::install): Remove call to
7361         obstack_blank.
7362
7363 2019-03-18  Pedro Alves  <palves@redhat.com>
7364
7365         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7366         New globals.
7367         (apply_style): New, factored out from ...
7368         (apply_ansi_escape): ... this.  Handle reverse video mode.
7369         (tui_set_reverse_mode): New function.
7370         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7371         * tui/tui-winsource.c (tui_show_source_line): Use
7372         tui_set_reverse_mode instead of setting A_STANDOUT.
7373         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7374         New setter methods.
7375
7376 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7377
7378         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7379         Handle tabs.
7380
7381 2019-03-18  Tom Tromey  <tromey@adacore.com>
7382
7383         * ada-lang.c (empty_array): Add "high" parameter.
7384         (ada_evaluate_subexp): Update.
7385
7386 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7387
7388         * unittests/string_view-selftests.c: Define
7389         _initialize_string_view_selftests unconditionally.
7390
7391 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7392
7393         PR gdb/24350
7394         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7395
7396 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7397
7398         PR gdb/24351
7399         * windows-nat.c (display_selector): Fix format specifiers.
7400
7401 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7402
7403         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7404         tui_refill_source_window instead of tui_refresh_win, to update the
7405         current execution line.  This fixes redisplay of the current line
7406         when stepping through the code with "next" or "step".
7407
7408 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7409
7410         * source-cache.c (source_cache::get_source_lines): Call
7411         find_source_lines to initialize s->nlines.  This fixes vertical
7412         scrolling of TUI source window when the DOWN arrow is pressed.
7413
7414 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7415
7416         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7417         linux-thread-db.c (_initialize_thread_db): Likewise.
7418
7419 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7420
7421         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7422         wclrtoeol in tui_show_source_line".  This reverts changes made in
7423         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7424
7425 2019-03-15  Tom Tromey  <tom@tromey.com>
7426
7427         * symtab.h (struct minimal_symbol): Derive from
7428         general_symbol_info.
7429         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7430         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7431         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7432         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7433         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7434         (MSYMBOL_SEARCH_NAME): Update.
7435         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7436         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7437         * minsyms.c (minimal_symbol_reader::record_full): Update.
7438
7439 2019-03-15  Tom Tromey  <tom@tromey.com>
7440
7441         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7442
7443 2019-03-15  Tom Tromey  <tom@tromey.com>
7444
7445         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7446         unique_xmalloc_ptr.
7447         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7448         Update.
7449         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7450         (build_minimal_symbol_hash_tables)
7451         (minimal_symbol_reader::install): Update.
7452
7453 2019-03-15  Tom Tromey  <tom@tromey.com>
7454
7455         * symtab.c (create_demangled_names_hash): Update.
7456         (symbol_set_names): Update.
7457         * objfiles.h (struct objfile_per_bfd_storage)
7458         <demangled_names_hash>: Now an htab_up.
7459         * objfiles.c (objfile_per_bfd_storage): Simplify.
7460
7461 2019-03-15  Tom Tromey  <tom@tromey.com>
7462
7463         * objfiles.h (struct objfile_per_bfd_storage): Declare
7464         destructor.
7465         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7466         New.
7467         (get_objfile_bfd_data): Use new.  Don't initialize
7468         language_of_main.
7469         (free_objfile_per_bfd_storage): Remove.
7470         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7471
7472 2019-03-15  Tom Tromey  <tom@tromey.com>
7473
7474         * symfile.c (reread_symbols): Update.
7475         * objfiles.c (objfile::objfile): Update.
7476         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7477         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7478         comment.
7479         (minimal_symbol_reader::install): Update.
7480         (terminate_minimal_symbol_table): Remove.
7481         * jit.c (jit_object_close_impl): Update.
7482
7483 2019-03-15  Tom Tromey  <tom@tromey.com>
7484
7485         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7486         initializations.
7487
7488 2019-03-15  Tom Tromey  <tom@tromey.com>
7489
7490         * objfiles.h (struct objfile_per_bfd_storage)
7491         <demangled_hash_languages>: Now a bitset.
7492         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7493         (lookup_minimal_symbol): Update.
7494
7495 2019-03-15  Tom Tromey  <tom@tromey.com>
7496
7497         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7498         Don't return the symbol.
7499         * coffread.c (record_minimal_symbol): Use record_full.
7500
7501 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7502
7503         The MS-Windows port of ncurses fails to switch to a color pair if
7504         one or both of the colors are the implicit default colors.  This
7505         change records the default colors when TUI is initialized, and
7506         then specifies them explicitly when a color pair uses the default
7507         colors.  This allows color styling in TUI mode on MS-Windows.
7508
7509         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7510         ncurses_norm_attr.
7511         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7512         colors in ncurses_norm_attr.
7513         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7514         "none", replace it with the default color recorded in
7515         ncurses_norm_attr.
7516
7517 2019-03-14  Tom Tromey  <tromey@adacore.com>
7518
7519         * source-cache.h (class source_cache) <get_source_lines>: Return
7520         std::string.
7521         * source-cache.c (source_cache::extract_lines): Handle case where
7522         first_pos==npos.  Return std::string.
7523         (source_cache::get_source_lines): Update.
7524
7525 2019-03-14  Tom Tromey  <tromey@adacore.com>
7526
7527         * NEWS: Add item for "style sources" commands.
7528         * source-cache.c (source_cache::get_source_lines): Check
7529         source_styling.
7530         * cli/cli-style.c (source_styling): New global.
7531         (_initialize_cli_style): Add "style sources" commands.
7532         (show_style_sources): New function.
7533         * cli/cli-style.h (source_styling): Declare.
7534
7535 2019-03-14  Pedro Alves  <palves@redhat.com>
7536             Tom Tromey  <tromey@adacore.com>
7537
7538         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7539         * tui/tui-winsource.c (tui_refill_source_window): New function,
7540         from...
7541         (tui_horizontal_source_scroll): ... here.  Move some logic.
7542         * cli/cli-style.c (set_style_enabled): Notify new observable.
7543         * tui/tui-hooks.c (tui_redisplay_source): New function.
7544         (tui_attach_detach_observers): Attach or detach
7545         tui_redisplay_source.
7546         * observable.h (source_styling_changed): New observable.
7547         * observable.c: Define source_styling_changed observable.
7548
7549 2019-03-13  Tom Tromey  <tromey@adacore.com>
7550
7551         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7552         (i386_gnu_nat_target::store_registers): Update.
7553         * target-debug.h (target_debug_print_std_string): New macro.
7554         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7555         * windows-tdep.c (display_one_tib): Update.
7556         * tui/tui-stack.c (tui_make_status_line): Update.
7557         * top.c (print_inferior_quit_action): Update.
7558         * thread.c (thr_try_catch_cmd): Update.
7559         (add_thread_with_info): Update.
7560         (thread_target_id_str): Update.
7561         (thr_try_catch_cmd): Update.
7562         (thread_command): Update.
7563         (thread_find_command): Update.
7564         * record-btrace.c (record_btrace_target::info_record)
7565         (record_btrace_resume_thread, record_btrace_target::resume)
7566         (record_btrace_cancel_resume, record_btrace_step_thread)
7567         (record_btrace_target::wait, record_btrace_target::wait)
7568         (record_btrace_target::wait, record_btrace_target::stop): Update.
7569         * progspace.c (print_program_space): Update.
7570         * process-stratum-target.c
7571         (process_stratum_target::thread_address_space): Update.
7572         * linux-fork.c (linux_fork_mourn_inferior)
7573         (detach_checkpoint_command, info_checkpoints_command)
7574         (linux_fork_context): Update.
7575         (linux_fork_detach): Update.
7576         (class scoped_switch_fork_info): Update.
7577         (delete_checkpoint_command): Update.
7578         * infrun.c (follow_fork_inferior): Update.
7579         (follow_fork_inferior): Update.
7580         (proceed_after_vfork_done): Update.
7581         (handle_vfork_child_exec_or_exit): Update.
7582         (follow_exec): Update.
7583         (displaced_step_prepare_throw): Update.
7584         (displaced_step_restore): Update.
7585         (start_step_over): Update.
7586         (resume_1): Update.
7587         (clear_proceed_status_thread): Update.
7588         (proceed): Update.
7589         (print_target_wait_results): Update.
7590         (do_target_wait): Update.
7591         (context_switch): Update.
7592         (stop_all_threads): Update.
7593         (restart_threads): Update.
7594         (finish_step_over): Update.
7595         (handle_signal_stop): Update.
7596         (switch_back_to_stepped_thread): Update.
7597         (keep_going_pass_signal): Update.
7598         (print_exited_reason): Update.
7599         (normal_stop): Update.
7600         * inferior.c (inferior_pid_to_str): Change return type.
7601         (print_selected_inferior): Update.
7602         (add_inferior): Update.
7603         (detach_inferior): Update.
7604         * dummy-frame.c (fprint_dummy_frames): Update.
7605         * dcache.c (dcache_info_1): Update.
7606         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7607         (btrace_fetch, btrace_clear): Update.
7608         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7609         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7610         type.
7611         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7612         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7613         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7614         * gdbarch.c, gdbarch.h: Rebuild.
7615         * gdbarch.sh (core_pid_to_str): Change return type.
7616         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7617         return type.
7618         (windows_nat_target::pid_to_str): Change return type.
7619         (windows_delete_thread): Update.
7620         (windows_nat_target::attach): Update.
7621         (windows_nat_target::files_info): Update.
7622         * target-delegates.c: Rebuild.
7623         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7624         return type.
7625         (sol_thread_target::pid_to_str): Change return type.
7626         * remote.c (class remote_target) <pid_to_str>: Change return
7627         type.
7628         (remote_target::pid_to_str): Change return type.
7629         (extended_remote_target::attach, remote_target::remote_stop_ns)
7630         (remote_target::remote_notif_remove_queued_reply)
7631         (remote_target::push_stop_reply, remote_target::disable_btrace):
7632         Update.
7633         (extended_remote_target::attach): Update.
7634         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7635         type.
7636         (gdbsim_target::pid_to_str): Change return type.
7637         * ravenscar-thread.c (struct ravenscar_thread_target)
7638         <pid_to_str>: Change return type.
7639         (ravenscar_thread_target::pid_to_str): Change return type.
7640         * procfs.c (class procfs_target) <pid_to_str>: Change return
7641         type.
7642         (procfs_target::pid_to_str): Change return type.
7643         (procfs_target::attach): Update.
7644         (procfs_target::detach): Update.
7645         (procfs_target::fetch_registers): Update.
7646         (procfs_target::store_registers): Update.
7647         (procfs_target::wait): Update.
7648         (procfs_target::files_info): Update.
7649         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7650         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7651         return type.
7652         (nto_procfs_target::pid_to_str): Change return type.
7653         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7654         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7655         return type.
7656         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7657         (exit_lwp): Update.
7658         (attach_proc_task_lwp_callback, get_detach_signal)
7659         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7660         (linux_nat_target::resume, wait_lwp, stop_callback)
7661         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7662         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7663         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7664         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7665         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7666         type.
7667         (inf_ptrace_target::attach): Update.
7668         (inf_ptrace_target::files_info): Update.
7669         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7670         type.
7671         (go32_nat_target::pid_to_str): Change return type.
7672         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7673         (gnu_nat_target::wait): Update.
7674         (gnu_nat_target::wait): Update.
7675         (gnu_nat_target::resume): Update.
7676         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7677         (fbsd_nat_target::wait): Update.
7678         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7679         type.
7680         (darwin_nat_target::attach): Update.
7681         * corelow.c (class core_target) <pid_to_str>: Change return type.
7682         (core_target::pid_to_str): Change return type.
7683         * target.c (normal_pid_to_str): Change return type.
7684         (default_pid_to_str): Likewise.
7685         (target_pid_to_str): Change return type.
7686         (target_translate_tls_address): Update.
7687         (target_announce_detach): Update.
7688         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7689         return type.
7690         (bsd_uthread_target::pid_to_str): Change return type.
7691         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7692         type.
7693         (bsd_kvm_target::pid_to_str): Change return type.
7694         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7695         return type.
7696         (aix_thread_target::pid_to_str): Change return type.
7697         * target.h (struct target_ops) <pid_to_str>: Change return type.
7698         (target_pid_to_str, normal_pid_to_str): Likewise.
7699         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7700         type.
7701         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7702         type.
7703         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7704         return type.
7705         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7706         type.
7707         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7708         type.
7709         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7710         return type.
7711
7712 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7713
7714         * NEWS: Mention that the new default MI version is 3.  Mention
7715         changes to the output of commands and events that deal with
7716         multi-location breakpoints.
7717         * breakpoint.c: Include "mi/mi-out.h".
7718         (print_one_breakpoint): Change output syntax if using MI version
7719         >= 3.
7720         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7721         New.
7722         (mi_multi_location_breakpoint_output_fixed): New.
7723         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7724         (mi_cmd_fix_multi_location_breakpoint_output): New.
7725         (mi_multi_location_breakpoint_output_fixed): New.
7726         * mi/mi-cmds.c (mi_cmds): Register command
7727         -fix-multi-location-breakpoint-output.
7728         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7729         interpreter "mi".
7730
7731 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7732
7733         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7734         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7735         instantiate mi_ui_out based on interpreter name.
7736         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7737         * mi/mi-main.c (mi_load_progress): Likewise.
7738
7739 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7740
7741         * NEWS: Combine separate "New targets" sections for 8.3.
7742
7743 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7744
7745         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7746         (ppcfbsd_init_abi): Install gdbarch
7747         "fetch_tls_load_module_address" and "get_thread_local_address"
7748         methods.
7749
7750 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7751
7752         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7753         (riscv_fbsd_init_abi): Install gdbarch
7754         "fetch_tls_load_module_address" and "get_thread_local_address"
7755         methods.
7756
7757 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7758
7759         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7760         (i386fbsd_init_abi): Install gdbarch
7761         "fetch_tls_load_module_address" and "get_thread_local_address"
7762         methods.
7763
7764 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7765
7766         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7767         (amd64fbsd_init_abi): Install gdbarch
7768         "fetch_tls_load_module_address" and "get_thread_local_address"
7769         methods.
7770
7771 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7772
7773         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7774         (struct fbsd_pspace_data): New type.
7775         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7776         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7777         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7778         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7779         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7780
7781 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7782
7783         * gdbtypes.c (lookup_struct_elt): New function.
7784         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7785         * gdbtypes.h (struct struct_elt): New type.
7786         (lookup_struct_elt): New prototype.
7787
7788 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7789
7790         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7791         remove disabled code block.
7792
7793 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7794
7795         * gdbarch.sh (get_thread_local_address): New method.
7796         * gdbarch.h, gdbarch.c: Regenerate.
7797         * target.c (target_translate_tls_address): Use
7798         gdbarch_get_thread_local_address if present instead of
7799         target::get_thread_local_address.
7800
7801 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7802
7803         * target.h (target::get_thread_local_address): Update comment.
7804
7805 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7806
7807         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7808         objfile->separate_debug_objfile_backlink if not NULL.
7809
7810 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7811
7812         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7813         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7814         (amd64bsd_store_inferior_registers): Likewise.
7815         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7816         Enable segment base registers.
7817         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7818         PT_GETFSBASE and PT_GETGSBASE.
7819         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7820         PT_SETGSBASE.
7821         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7822         segment base registers.
7823         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7824
7825 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7826
7827         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7828         Update calls to i386_target_description to add 'segments'
7829         parameter.
7830         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7831         add segment base registers.
7832         * arch/i386.c (i386_create_target_description): Add 'segments'
7833         parameter to enable segment base registers.
7834         * arch/i386.h (i386_create_target_description): Likewise.
7835         * features/i386/32bit-segments.xml: New file.
7836         * features/i386/32bit-segments.c: Generate.
7837         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7838         call to i386_target_description to add 'segments' parameter.
7839         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7840         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7841         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7842         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7843         if feature is present.
7844         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7845         Add 'segments' parameter to call to i386_target_description.
7846         (i386_target_description): Add 'segments' parameter to enable
7847         segment base registers.
7848         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7849         to call to i386_target_description.
7850         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7851         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7852         Define I386_NUM_REGS.
7853         (i386_target_description): Add 'segments' parameter to enable
7854         segment base registers.
7855
7856 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7857
7858         PR/24325
7859         * source-cache.c: #undef open and close, to avoid unresolved
7860         externals during linking.
7861
7862 2019-03-12  Tom Tromey  <tromey@adacore.com>
7863
7864         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7865         const.  Add initializers.
7866         (_initialize_remote): Don't initialize ptid globals.
7867
7868 2019-03-12  Pedro Alves  <palves@redhat.com>
7869
7870         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7871
7872 2019-03-12  Pedro Alves  <palves@redhat.com>
7873
7874         * cp-name-parser.y (main): Remove unused 'len' variable.
7875
7876 2019-03-12  Tom Tromey  <tromey@adacore.com>
7877
7878         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7879         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7880
7881 2019-03-12  Tom Tromey  <tromey@adacore.com>
7882
7883         * linux-nat.c (iterate_over_lwps): Update.
7884         (stop_callback): Remove parameter.
7885         (stop_wait_callback, detach_callback, resume_set_callback)
7886         (select_singlestep_lwp_callback, set_ignore_sigint)
7887         (status_callback, resumed_callback, resume_clear_callback)
7888         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7889         data parameter.
7890         (linux_nat_target::detach, linux_nat_target::resume)
7891         (linux_stop_and_wait_all_lwps, select_event_lwp)
7892         (linux_nat_filter_event, linux_nat_wait_1)
7893         (linux_nat_target::kill, linux_nat_target::stop)
7894         (linux_nat_target::stop): Update.
7895         (linux_nat_resume_callback): Change type.
7896         (resume_stopped_resumed_lwps, count_events_callback)
7897         (select_event_lwp_callback): Likewise.
7898         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7899         * arm-linux-nat.c (struct update_registers_data): Remove.
7900         (update_registers_callback): Change type.
7901         (arm_linux_insert_hw_breakpoint1): Update.
7902         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7903         parameter.
7904         (x86_linux_dr_set_addr): Update.
7905         (x86_linux_dr_set_control): Update.
7906         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7907         (iterate_over_lwps): Use gdb::function_view.
7908         * nat/aarch64-linux-hw-point.c (struct
7909         aarch64_dr_update_callback_param): Remove.
7910         (debug_reg_change_callback): Change type.
7911         (aarch64_notify_debug_reg_change): Update.
7912         * s390-linux-nat.c (s390_refresh_per_info): Update.
7913
7914 2019-03-11  Tom Tromey  <tromey@adacore.com>
7915
7916         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7917         redundant assignment to "this_cu".
7918
7919 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7920
7921         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7922
7923 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7924
7925         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7926         from...
7927         (rank_one_type): ... this.
7928
7929 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7930
7931         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7932         from...
7933         (rank_one_type): ... this.
7934
7935 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7936
7937         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7938         from...
7939         (rank_one_type): ... this.
7940
7941 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7942
7943         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7944         from...
7945         (rank_one_type): ... this.
7946
7947 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7948
7949         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7950         from...
7951         (rank_one_type): ... this.
7952
7953 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7954
7955         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7956         from...
7957         (rank_one_type): ... this.
7958
7959 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7960
7961         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7962         from...
7963         (rank_one_type): ... this.
7964
7965 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7966
7967         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7968         from...
7969         (rank_one_type): ... this.
7970
7971 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7972
7973         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7974         from...
7975         (rank_one_type): ... this.
7976
7977 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7978
7979         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7980         from...
7981         (rank_one_type): ... this.
7982
7983 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7984
7985         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7986         from...
7987         (rank_one_type): ... this.
7988
7989 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7990
7991         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7992         from...
7993         (rank_one_type): ... this.
7994
7995 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7996
7997         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7998         inferior-events' shows the example events.
7999
8000 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8001
8002         Support styling on native MS-Windows console
8003
8004         PR/24315
8005         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8006         on MS-Windows if $TERM is not defined.
8007
8008         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8009
8010         * posix-hdep.c (gdb_console_fputs):
8011         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8012         functions.
8013         * ui-file.h (gdb_console_fputs): Add prototype.
8014
8015         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8016         back to fputs only if the former returns zero.
8017
8018 2019-03-07  Tom Tromey  <tom@tromey.com>
8019
8020         * symmisc.c (print_symbol_bcache_statistics): Update.
8021         (print_objfile_statistics): Update.
8022         * symfile.c (allocate_symtab): Update.
8023         * stabsread.c: Don't include bcache.h.
8024         * psymtab.h (struct psymbol_bcache): Don't declare.
8025         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8026         (psymbol_bcache_init, psymbol_bcache_free)
8027         (psymbol_bcache_get_bcache): Don't declare.
8028         * psymtab.c (struct psymbol_bcache): Remove.
8029         (psymtab_storage::psymtab_storage): Update.
8030         (psymtab_storage::~psymtab_storage): Update.
8031         (psymbol_bcache_init, psymbol_bcache_free)
8032         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8033         (add_psymbol_to_bcache): Update.
8034         (allocate_psymtab): Update.
8035         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8036         macro_cache>: No longer pointers.
8037         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8038         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8039         * macrotab.c (macro_bcache): Update.
8040         * macroexp.c: Don't include bcache.h.
8041         * gdbtypes.c (check_types_worklist): Update.
8042         (types_deeply_equal): Remove TRY/CATCH.  Update.
8043         * elfread.c (elf_symtab_read): Update.
8044         * dwarf2read.c: Don't include bcache.h.
8045         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8046         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8047         (print_bcache_statistics, bcache_memory_used): Don't declare.
8048         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8049         methods.  Rename all data members.
8050         * bcache.c (struct bcache): Move to bcache.h.
8051         (bcache::expand_hash_table): Rename from expand_hash_table.
8052         (bcache): Remove.
8053         (bcache::insert): Rename from bcache_full.
8054         (bcache::compare): Rename from bcache_compare.
8055         (bcache_xmalloc): Remove.
8056         (bcache::~bcache): Rename from bcache_xfree.
8057         (bcache::print_statistics): Rename from print_bcache_statistics.
8058         (bcache::memory_used): Rename from bcache_memory_used.
8059
8060 2019-03-07  Pedro Alves  <palves@redhat.com>
8061
8062         * infrun.c (normal_stop): Also check for
8063         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8064
8065 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8066
8067         * f-lang.c (value_from_host_double): Moved to...
8068         * value.c (value_from_host_double): ...here.
8069         * value.h (value_from_host_double): Declare.
8070         * guile/scm-math.c (vlscm_convert_typed_number): Use
8071         value_from_host_double.
8072         (vlscm_convert_number): Likewise.
8073         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8074         * python/py-value.c (convert_value_from_python): Likewise.
8075
8076 2019-03-06  Tom Tromey  <tom@tromey.com>
8077
8078         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8079
8080 2019-03-06  Tom Tromey  <tom@tromey.com>
8081
8082         * utils.h (free_current_contents): Don't declare.
8083         * utils.c (free_current_contents): Remove.
8084
8085 2019-03-06  Tom Tromey  <tom@tromey.com>
8086
8087         * top.c (quit_force): Update.
8088         * main.c (captured_command_loop): Update.
8089         * common/new-op.c (operator new): Update.
8090         * common/common-exceptions.c (struct catcher)
8091         <save_cleanup_chain>: Remove member.
8092         (exceptions_state_mc_init): Update.
8093         (exception_try_scope_entry): Return nullptr.
8094         (exception_try_scope_exit, exception_rethrow)
8095         (throw_exception_sjlj, throw_exception_cxx): Update.
8096         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8097         (all_cleanups, do_cleanups, discard_cleanups)
8098         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8099         (restore_cleanups, restore_final_cleanups): Don't declare.
8100         (do_final_cleanups): Remove parameter.
8101         * common/cleanups.c (cleanup_chain, make_cleanup)
8102         (make_cleanup_dtor, all_cleanups, do_cleanups)
8103         (discard_my_cleanups, discard_cleanups)
8104         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8105         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8106         (null_cleanup): Remove.
8107         (do_final_cleanups): Remove parameter.
8108
8109 2019-03-06  Tom Tromey  <tom@tromey.com>
8110
8111         * remote.c (remote_target::remote_parse_stop_reply): Use
8112         unique_xmalloc_ptr.
8113
8114 2019-03-06  Tom Tromey  <tom@tromey.com>
8115
8116         * stabsread.c (struct stabs_field_info): Rename from field_info.
8117         <list, fnlist>: Add initializers.
8118         <obstack>: New member.
8119         (read_member_functions, read_struct_fields, read_baseclasses):
8120         Allocate on obstack.  Don't use cleanups.
8121         (read_one_struct_field, read_member_functions, read_struct_fields)
8122         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8123         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8124         (read_struct_type): Update.
8125
8126 2019-03-06  Tom Tromey  <tom@tromey.com>
8127
8128         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8129         * common/filestuff.h (make_cleanup_close): Don't declare.
8130         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8131         Remove.
8132
8133 2019-03-06  Tom Tromey  <tom@tromey.com>
8134
8135         * solib-aix.c: Use make_scope_exit.
8136
8137 2019-03-06  Tom Tromey  <tom@tromey.com>
8138
8139         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8140         Use make_scope_exit.
8141
8142 2019-03-06  Tom Tromey  <tom@tromey.com>
8143
8144         * solib-svr4.c (disable_probes_interface): Remove parameter.
8145         (svr4_handle_solib_event): Use make_scope_exit.
8146
8147 2019-03-06  Tom Tromey  <tom@tromey.com>
8148
8149         * remote.c (struct stop_reply_deleter): Remove.
8150         (stop_reply_up): Update.
8151         (struct stop_reply): Derive from notif_event.  Don't typedef.
8152         <regcache>: Now a std::vector.
8153         (stop_reply_xfree): Remove.
8154         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8155         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8156         (remote_target::discard_pending_stop_replies): Use delete.
8157         (remote_target::remote_parse_stop_reply): Update.
8158         (remote_target::process_stop_reply): Update.
8159         * remote-notif.h (struct notif_event): Add virtual destructor.
8160         Remove "dtr" member.
8161         (struct notif_client) <alloc_event>: Return a unique_ptr.
8162         (notif_event_xfree): Don't declare.
8163         (notif_event_up): New typedef.
8164         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8165         (notif_event_xfree, do_notif_event_xfree): Remove.
8166         (remote_notif_state_xfree): Update.
8167
8168 2019-03-06  Tom Tromey  <tom@tromey.com>
8169
8170         * infrun.c (displaced_step_clear_cleanup): Now a
8171         forward_scope_exit type.
8172         (displaced_step_prepare_throw): Update.
8173         (displaced_step_fixup): Update.
8174
8175 2019-03-06  Tom Tromey  <tom@tromey.com>
8176
8177         * inferior.h (class inferior): Update comment.
8178         * gdbthread.h (class thread_info): Update comment.
8179
8180 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8181             Tom Tromey  <tom@tromey.com>
8182
8183         * stabsread.h (struct stab_section_list): Remove.
8184         (coffstab_build_psymtabs): Update.
8185         * dbxread.c (symbuf_sections): Now a std::vector.
8186         (sect_idx): New global.
8187         (fill_symbuf): Update.
8188         (coffstab_build_psymtabs): Change type of stabsects parameter.
8189         Update.
8190         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8191         std::vector.
8192         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8193         (coff_locate_sections): Update.
8194         (coff_symfile_read): Remove cleanups.  Update.
8195         (init_stringtab): Add storage parameter.
8196         (free_stringtab, free_stringtab_cleanup): Remove.
8197         (init_lineno): Add storage parameter.
8198         (free_linetab, free_linetab_cleanup): Remove.
8199
8200 2019-03-06  Pedro Alves  <palves@redhat.com>
8201
8202         * linux-fork.c (fork_info::clobber_regs): Delete.
8203         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8204         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8205         comment.  Adjust.
8206         (scoped_switch_fork_info::scoped_switch_fork_info)
8207         (checkpoint_command, linux_fork_context): Adjust
8208         fork_save_infrun_state calls.
8209
8210 2019-03-06  Pedro Alves  <palves@redhat.com>
8211
8212         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8213         (inf_has_multiple_threads): Return 'bool' and rewrite using
8214         inferior_info::threads().
8215
8216 2019-03-06  Pedro Alves  <palves@redhat.com>
8217
8218         * linux-fork.c: Include <list>.
8219         (fork_list): Now a std::list instance.
8220         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8221         (forks_exist_p, find_last_fork): Adjust.
8222         (new_fork): Delete.
8223         (one_fork_p): New.
8224         (add_fork): Adjust.
8225         (free_fork): Delete, folded into fork_info::~fork_info().
8226         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8227         Adjust.
8228         (init_fork_list): Delete.
8229         (linux_fork_killall, linux_fork_mourn_inferior)
8230         (linux_fork_detach, info_checkpoints_command): Adjust.
8231         (_initialize_linux_fork): No longer call init_fork_list.
8232
8233 2019-03-06  Pedro Alves  <palves@redhat.com>
8234
8235         * linux-fork.c (new_fork): New, split out of ...
8236         (add_fork): ... this.  Return void.  Move "first fork" special
8237         case from here, to ...
8238         (checkpoint_command): ... here.
8239         * linux-linux.h (add_fork): Return void.
8240
8241 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8242
8243         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8244
8245 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8246             Chris January  <chris.january@arm.com>
8247             David Lecomber  <david.lecomber@arm.com>
8248
8249         * f-exp.y: New token, UNOP_INTRINSIC.
8250         (exp): New pattern using UNOP_INTRINSIC token.
8251         (f77_keywords): Add 'abs' keyword.
8252         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8253         (value_from_host_double): New function.
8254         (evaluate_subexp_f): Support UNOP_ABS.
8255
8256 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8257
8258         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8259         types.
8260
8261 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8262
8263         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8264         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8265         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8266
8267 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8268
8269         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8270
8271 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8272             Chris January  <chris.january@arm.com>
8273
8274         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8275         * f-exp.y: Define 'KIND' token.
8276         (exp): New pattern for KIND expressions.
8277         (ptype): Handle types with a kind extension.
8278         (direct_abs_decl): Extend to spot kind extensions.
8279         (f77_keywords): Add 'kind' to the list.
8280         (push_kind_type): New function.
8281         (convert_to_kind_type): New function.
8282         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8283         * parse.c (operator_length_standard): Likewise.
8284         * parser-defs.h (enum type_pieces): Add tp_kind.
8285         * std-operator.def: Add UNOP_KIND.
8286
8287 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8288
8289         * f-exp.y (f_parse): Set yydebug.
8290
8291 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8292
8293         * f-lang.c (evaluate_subexp_f): New function.
8294         (exp_descriptor_f): New global.
8295         (f_language_defn): Use exp_descriptor_f instead of
8296         exp_descriptor_standard.
8297
8298 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8299
8300         * f-exp.y (struct token): Add comments.
8301         (dot_ops): Remove uppercase versions and the end marker.
8302         (f77_keywords): Likewise.
8303         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8304         entries in the dot_ops array are case insensitive, and use
8305         strncasecmp to compare strings.  Also some whitespace cleanup in
8306         this area.  Similar for the f77_keywords array, except entries in
8307         this list might be case sensitive.
8308
8309 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8310
8311         * f-exp.y (struct f77_boolean_val): Add comments.
8312         (boolean_values): Remove uppercase versions, and end marker.
8313         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8314         and use strncasecmp to achieve case insensitivity.  Additionally,
8315         perform whitespace cleanup around this code.
8316
8317 2019-03-06  Tom Tromey  <tromey@adacore.com>
8318
8319         * remote-sim.c (gdbsim_target_open): Use result of
8320         gdb_argv::release.
8321
8322 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8323         Dirk Schubert  <dirk.schubert@arm.com>
8324         Chris January  <chris.january@arm.com>
8325
8326         * eval.c (evaluate_subexp_standard): Call Fortran argument
8327         wrapping logic.
8328         * f-lang.c (struct value): A value which can be passed into a
8329         Fortran function call.
8330         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8331         where appropriate.
8332         (struct type): Value ready for a Fortran function call.
8333         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8334         is needed.
8335         * f-lang.h (fortran_argument_convert): Declaration.
8336         (fortran_preserve_arg_pointer): Declaration.
8337         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8338
8339 2019-03-05  Tom Tromey  <tromey@adacore.com>
8340
8341         * python/py-prettyprint.c (print_string_repr): Remove #if.
8342         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8343
8344 2019-03-05  Tom Tromey  <tromey@adacore.com>
8345
8346         * target.c (the_dummy_target): Move later.  Change type to
8347         "dummy_target".
8348         (initialize_targets): Don't initialize the_dummy_target.
8349
8350 2019-03-05  Tom Tromey  <tromey@adacore.com>
8351
8352         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8353         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8354
8355 2019-03-05  Tom Tromey  <tromey@adacore.com>
8356
8357         * windows-nat.c (windows_nat_target::attach)
8358         (windows_nat_target::detach): Don't call gdb_flush.
8359         * valprint.c (generic_val_print, val_print, val_print_string):
8360         Don't call gdb_flush.
8361         * utils.c (defaulted_query): Don't call gdb_flush.
8362         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8363         * target.c (target_announce_detach): Don't call gdb_flush.
8364         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8365         * remote.c (extended_remote_target::attach): Don't call
8366         gdb_flush.
8367         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8368         * printcmd.c (do_examine): Don't call gdb_flush.
8369         (info_display_command): Don't call gdb_flush.
8370         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8371         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8372         * memattr.c (info_mem_command): Don't call gdb_flush.
8373         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8374         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8375         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8376         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8377         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8378         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8379         (gnu_nat_target::detach): Don't call gdb_flush.
8380         * f-valprint.c (f_val_print): Don't call gdb_flush.
8381         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8382         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8383         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8384         gdb_flush.
8385         * c-valprint.c (c_val_print): Don't call gdb_flush.
8386         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8387
8388 2019-03-05  Tom Tromey  <tromey@adacore.com>
8389
8390         * varobj.c (update_dynamic_varobj_children): Update.
8391         (install_default_visualizer): Use reset, not release.
8392         * value.c (set_internalvar): Update.
8393         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8394         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8395         ATTRIBUTE_UNUSED_RESULT.
8396
8397 2019-03-05  Tom Tromey  <tromey@adacore.com>
8398
8399         * remote.c (class scoped_remote_fd) <release>: Add
8400         ATTRIBUTE_UNUSED_RESULT.
8401
8402 2019-03-05  Tom Tromey  <tromey@adacore.com>
8403
8404         * macroexp.c (struct macro_buffer) <release>: Add
8405         ATTRIBUTE_UNUSED_RESULT.
8406
8407 2019-03-05  Tom Tromey  <tromey@adacore.com>
8408
8409         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8410         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8411         ATTRIBUTE_UNUSED_RESULT.
8412
8413 2019-03-05  Tom Tromey  <tromey@adacore.com>
8414
8415         * common/scoped_fd.h (class scoped_fd) <release>: Add
8416         ATTRIBUTE_UNUSED_RESULT.
8417
8418 2019-03-05  Tom Tromey  <tromey@adacore.com>
8419
8420         * parser-defs.h (struct parser_state) <release>: Add
8421         ATTRIBUTE_UNUSED_RESULT.
8422
8423 2019-03-05  Tom Tromey  <tromey@adacore.com>
8424
8425         * utils.h (class gdb_argv) <release>: Add
8426         ATTRIBUTE_UNUSED_RESULT.
8427         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8428
8429 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8430
8431         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8432         for-loop range, to avoid compiler warnings.
8433
8434         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8435         avoid compiler warnings about unused variables.
8436
8437         * NEWS: Mention end of support for native debugging on MS-Windows
8438         before XP.
8439
8440         PR gdb/24292
8441         * common/netstuff.c:
8442         * gdbserver/gdbreplay.c
8443         * gdbserver/remote-utils.c:
8444         * ser-tcp.c:
8445         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8446         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8447         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8448         'getaddrinfo' and 'freeaddrinfo' were not available before
8449         Windows XP, and mingw.org's MinGW headers by default define
8450         _WIN32_WINNT to 0x500.
8451
8452 2019-03-01  Gary Benson <gbenson@redhat.com>
8453
8454         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8455
8456 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8457             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8458
8459         PR gdb/8527
8460         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8461         set_sigint_trap, clear_sigint_trap.
8462
8463 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8464
8465         * target.c (target_detach): Clear the regcache and the
8466         frame cache.
8467
8468 2019-02-27  Pedro Alves  <palves@redhat.com>
8469
8470         * utils.c (set_screen_size): When we cap the height/width sizes,
8471         tweak the corresponding command variable to show "unlimited":
8472
8473 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8474             Pedro Alves  <palves@redhat.com>
8475
8476         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8477         before calling rl_set_screen_size.
8478
8479 2019-02-27  Tom Tromey  <tromey@adacore.com>
8480
8481         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8482         define.
8483         * python/py-value.c: Remove Python 2.4 workaround.
8484         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8485         workaround.
8486         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8487         Python 2.4 workaround.
8488         * python/python-internal.h: Remove Python 2.4 comment.
8489         (Py_ssize_t): Don't define.
8490         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8491         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8492         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8493         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8494         * python/python.c (do_start_initialization): Remove Python 2.4
8495         workaround.
8496         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8497         (print_children): Remove Python 2.4 workaround.
8498         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8499         workaround.
8500         (CHARBUFFERPROC_NAME): Remove.
8501         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8502         Python 2.4 workaround.
8503
8504 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8505
8506         * NEWS: Note minimum Python version.
8507
8508 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8509
8510         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8511         code from these functions.  Remove corresponding ifdefs.  Use
8512         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8513         Remove gotos and target of gotos.
8514         (infpy_search_memory): Likewise.
8515
8516 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8517
8518         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8519         (hppa_gdbarch_init): Don't register deleted functions with
8520         gdbarch.
8521
8522 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8523
8524         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8525         (h8300_unwind_sp): Delete.
8526         (h8300_dummy_id): Delete.
8527         (h8300_gdbarch_init): Don't register deleted functions with
8528         gdbarch.
8529
8530 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8531
8532         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8533         (ft32_unwind_pc): Delete.
8534         (ft32_unwind_sp): Delete.
8535         (ft32_gdbarch_init): Don't register deleted functions with
8536         gdbarch.
8537
8538 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8539
8540         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8541         (frv_unwind_pc): Delete.
8542         (frv_unwind_sp): Delete.
8543         (frv_gdbarch_init): Don't register deleted functions with
8544         gdbarch.
8545
8546 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8547
8548         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8549         (riscv_unwind_pc): Delete.
8550         (riscv_unwind_sp): Delete.
8551         (riscv_gdbarch_init): Don't register deleted functions with
8552         gdbarch.
8553
8554 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8555
8556         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8557         (csky_unwind_pc): Delete.
8558         (csky_unwind_sp): Delete.
8559         (csky_gdbarch_init): Don't register deleted functions with
8560         gdbarch.
8561
8562 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8563
8564         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8565         (cris_unwind_pc): Delete.
8566         (cris_unwind_sp): Delete.
8567         (cris_gdbarch_init): Don't register deleted functions with
8568         gdbarch.
8569
8570 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8571
8572         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8573         (bfin_unwind_pc): Delete.
8574         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8575
8576 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8577
8578         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8579         (arm_unwind_pc): Delete.
8580         (arm_unwind_sp): Delete.
8581         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8582
8583 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8584
8585         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8586         (arc_unwind_pc): Delete.
8587         (arc_unwind_sp): Delete.
8588         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8589
8590 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8591
8592         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8593         (alpha_unwind_pc): Delete.
8594         (alpha_gdbarch_init): Don't register deleted functions with
8595         gdbarch.
8596
8597 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8598
8599         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8600         (aarch64_unwind_pc): Delete.
8601         (aarch64_unwind_sp): Delete.
8602         (aarch64_gdbarch_init): Don't register deleted functions with
8603         gdbarch.
8604
8605 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8606
8607         * gdbtypes.c (type_align): Don't consider static members when
8608         computing structure alignment.
8609
8610 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8611
8612         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8613         return 0 for other types.
8614         * arch-utils.c (default_type_align): Always return 0.
8615         * gdbarch.h: Regenerate.
8616         * gdbarch.sh (type_align): Extend comment.
8617         * gdbtypes.c (type_align): Add additional comments, always call
8618         gdbarch_type_align before applying the default rules.
8619         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8620         generic code will then apply a suitable default.
8621         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8622         types, return 0 for other types.
8623
8624 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8625
8626         * NEWS: Create a new section for the next release branch.
8627         Rename the section of the current branch, now that it has
8628         been cut.
8629
8630 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8631
8632         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8633         * version.in: Bump version to 8.3.50.DATE-git.
8634
8635 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8636
8637         * aix-thread.c (ptid_cmp): Remove unused variable.
8638         (get_signaled_thread): Likewise.
8639         (store_regs_user_thread): Likewise.
8640         (store_regs_kernel_thread): Likewise.
8641         (fetch_regs_kernel_thread): Remove shadowed variable.
8642
8643 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8644
8645         * features/riscv/32bit-cpu.xml: Add register numbers.
8646         * features/riscv/32bit-fpu.c: Regenerate.
8647         * features/riscv/32bit-fpu.xml: Add register numbers.
8648         * features/riscv/64bit-cpu.xml: Add register numbers.
8649         * features/riscv/64bit-fpu.c: Regenerate.
8650         * features/riscv/64bit-fpu.xml: Add register numbers.
8651
8652 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8653
8654         * NEWS: Mention two argument form of gdb.Value constructor.
8655         * python/py-value.c (convert_buffer_and_type_to_value): New
8656         function.
8657         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8658         Add support for handling an optional second argument.  Call
8659         convert_buffer_and_type_to_value as appropriate.
8660         * python/python-internal.h (Py_buffer_deleter): New struct.
8661         (Py_buffer_up): New typedef.
8662
8663 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8664
8665         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8666         instead of releasing ownership.
8667
8668 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8669
8670         * dwarf2read.c (open_and_init_dwp_file): Call
8671         elf_numsections instead of bfd_count_sections to initialize
8672         dwp_file->num_sections.
8673
8674 2019-02-25  Tom Tromey  <tromey@adacore.com>
8675
8676         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8677
8678 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8679
8680         * gcore.in: Add '--readnever' option when invoking GDB.
8681
8682 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8683
8684         * MAINTAINERS: Update my email address.
8685
8686 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8687
8688         * build-id.c (build_id_to_debug_bfd_1): New function.
8689         (build_id_to_debug_bfd): Look for separate debug file in
8690         sysroot.
8691
8692 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8693
8694         * gdbarch.sh: Update the copyright year range that is placed into
8695         generated files.
8696
8697 2019-02-22  Keith Seitz  <keiths@redhat.com>
8698
8699         PR symtab/23853
8700         * linespec.c (create_sals_line_offset): Search for the default
8701         symtab's filename instead of its fullname.
8702
8703 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8704
8705         * NEWS: Update style defaults.
8706
8707 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8708
8709         * main.c (captured_main_1): Disable styling in batch mode.
8710
8711 2019-02-20  Tom Tromey  <tom@tromey.com>
8712
8713         * symtab.c (symtab_symbol_info): Fix typos.
8714
8715 2019-02-20  Tom Tromey  <tromey@adacore.com>
8716
8717         * findcmd.c (_initialize_mem_search): Use upper case for
8718         metasyntactic variables.
8719
8720 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8721
8722         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8723         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8724
8725 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8726
8727         * top.h (source_file_name): Change to std::string.
8728         * top.c (source_file_name): Likewise.
8729         (command_line_input): Adjust.
8730         * cli/cli-script.c (script_from_file): Adjust.
8731
8732 2019-02-19  Tom Tromey  <tromey@adacore.com>
8733
8734         * ravenscar-thread.c
8735         (ravenscar_thread_target::update_thread_list): Don't call
8736         ada_build_task_list.
8737         * ada-lang.h (ada_build_task_list): Don't declare.
8738         * ada-tasks.c (struct ada_tasks_inferior_data)
8739         <task_list_valid_p>: Now bool.
8740         (read_known_tasks, ada_task_list_changed)
8741         (ada_tasks_invalidate_inferior_data): Update.
8742         (read_known_tasks_array): Return bool.
8743         (read_known_tasks_list): Likewise.
8744         (read_known_tasks): Return void.
8745         (ada_build_task_list): Now static.
8746
8747 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8748
8749         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8750         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8751
8752 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8753
8754         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8755         variant for ada_tasks_pspace_data_handle and
8756         ada_tasks_inferior_data_handle.
8757         (ada_tasks_pspace_data_cleanup): New function.
8758         (ada_tasks_inferior_data_cleanup): New function.
8759
8760 2019-02-17  Tom Tromey  <tom@tromey.com>
8761
8762         * macrotab.h (macro_source_fullname): Return a std::string.
8763         * macrotab.c (macro_include, check_for_redefinition)
8764         (macro_undef, macro_lookup_definition, foreach_macro)
8765         (foreach_macro_in_scope): Update.
8766         (macro_source_fullname): Return a std::string.
8767         * macrocmd.c (show_pp_source_pos): Update.
8768
8769 2019-02-17  Tom Tromey  <tom@tromey.com>
8770
8771         * macrocmd.c (show_pp_source_pos): Style the file names.
8772
8773 2019-02-17  Tom Tromey  <tom@tromey.com>
8774
8775         PR tui/24197:
8776         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8777
8778 2019-02-17  Tom Tromey  <tom@tromey.com>
8779
8780         * ada-lang.c (user_select_syms): Use filtered printing.
8781         * utils.c (wrap_style): New global.
8782         (desired_style): Remove.
8783         (emit_style_escape): Add stream parameter.
8784         (set_output_style, reset_terminal_style, prompt_for_continue):
8785         Update.
8786         (flush_wrap_buffer): Only flush gdb_stdout.
8787         (wrap_here): Set wrap_style.
8788         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8789         treat escape sequences as a character.  Change when wrap buffer is
8790         flushed.
8791         (fputs_styled): Do not set the output style when the default is
8792         requested.
8793         * ui-style.h (struct ui_file_style) <is_default>: New method.
8794         * source.c (print_source_lines_base): Emit escape sequences in one
8795         piece.
8796
8797 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8798
8799         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8800         integers and enumeration types.
8801
8802 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8803
8804         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8805         instead of lookup_symbol_in_language
8806         (do_exact_match): New function.
8807         (ada_get_symbol_name_matcher): Return do_exact_match when
8808         doing a verbatim match.
8809
8810 2019-02-15  Tom Tromey  <tromey@adacore.com>
8811
8812         * ravenscar-thread.c (ravenscar_thread_target::resume)
8813         (ravenscar_thread_target::wait): Special case wildcard requests.
8814
8815 2019-02-15  Tom Tromey  <tromey@adacore.com>
8816
8817         * ravenscar-thread.c (base_ptid): Remove.
8818         (struct ravenscar_thread_target) <close>: New method.
8819         <m_base_ptid>: New member.
8820         <update_inferior_ptid, active_task, task_is_currently_active,
8821         runtime_initialized>: Declare methods.
8822         <ravenscar_thread_target>: Add constructor.
8823         (ravenscar_thread_target::task_is_currently_active)
8824         (ravenscar_thread_target::update_inferior_ptid)
8825         (ravenscar_runtime_initialized): Rename.  Now methods.
8826         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8827         (ravenscar_thread_target::update_thread_list): Update.
8828         (ravenscar_thread_target::active_task): Now method.
8829         (ravenscar_thread_target::store_registers)
8830         (ravenscar_thread_target::prepare_to_store)
8831         (ravenscar_thread_target::prepare_to_store)
8832         (ravenscar_thread_target::mourn_inferior): Update.
8833         (ravenscar_inferior_created): Use "new" to create target.
8834         (ravenscar_thread_target::get_ada_task_ptid): Update.
8835         (_initialize_ravenscar): Don't initialize base_ptid.
8836         (ravenscar_ops): Remove global.
8837
8838 2019-02-15  Tom Tromey  <tromey@adacore.com>
8839
8840         * target.h (push_target): Declare new overload.
8841         * target.c (push_target): New overload, taking an rvalue reference.
8842         * remote.c (remote_target::open_1): Use push_target overload.
8843         * corelow.c (core_target_open): Use push_target overload.
8844
8845 2019-02-15  Tom Tromey  <tromey@adacore.com>
8846
8847         * ravenscar-thread.c (is_ravenscar_task)
8848         (ravenscar_task_is_currently_active): Return bool.
8849         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8850         (_initialize_ravenscar): Remove "(void)".
8851         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8852         Return bool.
8853
8854 2019-02-15  Tom Tromey  <tromey@adacore.com>
8855
8856         * ravenscar-thread.c (ravenscar_runtime_initializer)
8857         (has_ravenscar_runtime, get_running_thread_id)
8858         (ravenscar_thread_target::resume): Fix indentation.
8859
8860 2019-02-15  Tom Tromey  <tromey@adacore.com>
8861
8862         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8863         from ravenscar_arch_ops.
8864         (sparc_ravenscar_ops::fetch_registers)
8865         (sparc_ravenscar_ops::store_registers): Now methods.
8866         (sparc_ravenscar_prepare_to_store): Remove.
8867         (sparc_ravenscar_ops): Redefine.
8868         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8869         methods and destructor.  Remove members.
8870         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8871         (ravenscar_thread_target::store_registers)
8872         (ravenscar_thread_target::prepare_to_store): Update.
8873         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8874         Remove.
8875         (struct ppc_ravenscar_powerpc_ops): Derive from
8876         ravenscar_arch_ops.
8877         (ppc_ravenscar_powerpc_ops::fetch_registers)
8878         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8879         (ppc_ravenscar_powerpc_ops): Redefine.
8880         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8881         (ppc_ravenscar_e500_ops::fetch_registers)
8882         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8883         (ppc_ravenscar_e500_ops): Redefine.
8884         * aarch64-ravenscar-thread.c
8885         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8886         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8887         (aarch64_ravenscar_fetch_registers)
8888         (aarch64_ravenscar_store_registers): Now methods.
8889         (aarch64_ravenscar_ops): Redefine.
8890
8891 2019-02-15  Tom Tromey  <tromey@adacore.com>
8892
8893         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8894         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8895         (ravenscar_thread_target::stopped_by_watchpoint)
8896         (ravenscar_thread_target::stopped_data_address)
8897         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8898
8899 2019-02-15  Tom Tromey  <tromey@adacore.com>
8900
8901         * ravenscar-thread.c: Fix some typos.
8902
8903 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8904             Tom Tromey  <tromey@adacore.com>
8905
8906         * ada-lang.c (ada_exception_sal): Change addr_string to a
8907         std::string.
8908         (create_ada_exception_catchpoint): Update.
8909
8910 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8911             Tom Tromey  <tromey@adacore.com>
8912
8913         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8914         (bp_location_ops): Remove.
8915         (base_breakpoint_allocate_location): Update.
8916         (free_bp_location): Update.
8917         * ada-lang.c (class ada_catchpoint_location)
8918         <ada_catchpoint_location>: Remove ops parameter.
8919         (ada_catchpoint_location_dtor): Remove.
8920         (ada_catchpoint_location_ops): Remove.
8921         (allocate_location_exception): Update.
8922         * breakpoint.h (struct bp_location_ops): Remove.
8923         (class bp_location) <bp_location>: Remove bp_location_ops
8924         parameter.
8925         <~bp_location>: Add destructor.
8926         <ops>: Remove.
8927
8928 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8929             Pedro Alves  <palves@redhat.com>
8930
8931         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8932         'PATH_MAX'.
8933
8934 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8935             Samuel Thibault  <samuel.thibault@gnu.org>
8936             Thomas Schwinge  <thomas@codesourcery.com>
8937
8938         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8939         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8940
8941 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8942
8943         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8944         (check_empty): Use "const char *".
8945
8946         * gnu-nat.c (gnu_nat_target::detach): Instead of
8947         'detach_inferior (pid)' call
8948         'detach_inferior (find_inferior_pid (pid))'.
8949
8950         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8951         'nat/fork-inferior.o'.
8952         * gnu-nat.c: #include "nat/fork-inferior.h".
8953
8954         * gnu-nat.c (gnu_nat_target::detach): Instead of
8955         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8956         * gnu-nat.h: #include "inf-child.h".
8957         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8958         'i386_gnu_nat_target::fetch_registers'.
8959         (gnu_store_registers): Rename/move to
8960         'i386_gnu_nat_target::store_registers'.
8961
8962         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8963         * gnu-nat.h (mach_thread_info): New function.
8964         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8965
8966         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8967
8968 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8969
8970         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8971
8972 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8973
8974         * windows-nat.c (windows_add_thread): Add new parameter
8975         "main_thread_p" with default value set to false.  Update
8976         function documentation as well as all callers.
8977         (windows_delete_thread): Likewise.
8978         (fake_create_process): Update call to windows_add_thread.
8979         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8980         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8981         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8982         call to windows_delete_thread.
8983
8984 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8985
8986         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8987
8988 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8989
8990         * symfile.c (find_separate_debug_file): Use canonical path of
8991         sysroot with child_path instead of gdb_sysroot if it is valid.
8992
8993 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8994
8995         * symfile.c (find_separate_debug_file): Use child_path to
8996         determine if an object file is under a sysroot.
8997
8998 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8999
9000         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9001         unittests/child-path-selftests.c.
9002         * common/pathstuff.c (child_path): New function.
9003         * common/pathstuff.h (child_path): New prototype.
9004         * unittests/child-path-selftests.c: New file.
9005
9006 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9007
9008         * symfile.c (find_separate_debug_file): Look for separate debug
9009         files in debug directories under the sysroot.
9010
9011 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9012
9013         * symtab.h (struct minimal_symbol data_p): New const method.
9014         (struct minimal_symbol text_p): Likewise.
9015         * symtab.c (output_source_filename): Use file name style
9016         to print file name.
9017         (print_symbol_info): Likewise.
9018         (print_msymbol_info): Use address style to print addresses.
9019         Use function name style to print executable text symbols.
9020         (expand_symtab_containing_pc): Use data_p.
9021         (find_pc_sect_compunit_symtab): Likewise.
9022
9023 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9024
9025         * breakpoint.c (describe_other_breakpoints): Use address style
9026         to print addresses.
9027         (say_where): Likewise.
9028
9029 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9030
9031         * ada-typeprint.c (print_func_type): Print function name
9032         style to print function name.
9033         * c-typeprint.c (c_print_type_1): Likewise.
9034
9035 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9036
9037         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9038         for execve.
9039
9040 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9041
9042         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9043         type_stack.
9044
9045 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9046
9047         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9048         TYPE_CODE_REF types.
9049
9050 2019-02-08  Jim Wilson  <jimw@sifive.com>
9051
9052         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9053         (riscv_linux_fregset): New.
9054         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9055
9056 2019-02-07  Tom Tromey  <tom@tromey.com>
9057
9058         * thread.c (thread_cancel_execution_command): Update.
9059         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9060         methods.
9061         (struct thread_fsm_ops): Remove.
9062         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9063         (thread_fsm_should_stop, thread_fsm_return_value)
9064         (thread_fsm_set_finished, thread_fsm_finished_p)
9065         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9066         Don't declare.
9067         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9068         * infrun.c (clear_proceed_status_thread)
9069         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9070         (print_stop_event): Update.
9071         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9072         Add constructor.
9073         (step_command_fsm_ops): Remove.
9074         (new_step_command_fsm): Remove.
9075         (step_1): Update.
9076         (step_command_fsm::should_stop): Rename from
9077         step_command_fsm_should_stop.
9078         (step_command_fsm::clean_up): Rename from
9079         step_command_fsm_clean_up.
9080         (step_command_fsm::do_async_reply_reason): Rename from
9081         step_command_fsm_async_reply_reason.
9082         (struct until_next_fsm): Inherit from thread_fsm.  Add
9083         constructor.
9084         (until_next_fsm_ops): Remove.
9085         (new_until_next_fsm): Remove.
9086         (until_next_fsm::should_stop): Rename from
9087         until_next_fsm_should_stop.
9088         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9089         (until_next_fsm::do_async_reply_reason): Rename from
9090         until_next_fsm_async_reply_reason.
9091         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9092         constructor.  Change type of breakpoint.
9093         (finish_command_fsm_ops): Remove.
9094         (new_finish_command_fsm): Remove.
9095         (finish_command_fsm::should_stop): Rename from
9096         finish_command_fsm_should_stop.
9097         (finish_command_fsm::clean_up): Rename from
9098         finish_command_fsm_clean_up.
9099         (finish_command_fsm::return_value): Rename from
9100         finish_command_fsm_return_value.
9101         (finish_command_fsm::do_async_reply_reason): Rename from
9102         finish_command_fsm_async_reply_reason.
9103         (finish_command): Update.
9104         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9105         Add constructor.
9106         (call_thread_fsm_ops): Remove.
9107         (call_thread_fsm::call_thread_fsm): Rename from
9108         new_call_thread_fsm.
9109         (call_thread_fsm::should_stop): Rename from
9110         call_thread_fsm_should_stop.
9111         (call_thread_fsm::should_notify_stop): Rename from
9112         call_thread_fsm_should_notify_stop.
9113         (run_inferior_call, call_function_by_hand_dummy): Update.
9114         * cli/cli-interp.c (should_print_stop_to_console): Update.
9115         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9116         Add constructor.  Change type of location_breakpoint,
9117         caller_breakpoint.
9118         (until_break_fsm_ops): Remove.
9119         (new_until_break_fsm): Remove.
9120         (until_break_fsm::should_stop): Rename from
9121         until_break_fsm_should_stop.
9122         (until_break_fsm::clean_up): Rename from
9123         until_break_fsm_clean_up.
9124         (until_break_fsm::do_async_reply_reason): Rename from
9125         until_break_fsm_async_reply_reason.
9126         (until_break_command): Update.
9127         * thread-fsm.c: Remove.
9128         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9129
9130 2019-02-07  Tom Tromey  <tom@tromey.com>
9131
9132         * yy-remap.h: Add include guard.
9133         * xtensa-tdep.h: Add include guard.
9134         * xcoffread.h: Rename include guard.
9135         * varobj-iter.h: Add include guard.
9136         * tui/tui.h: Rename include guard.
9137         * tui/tui-winsource.h: Rename include guard.
9138         * tui/tui-wingeneral.h: Rename include guard.
9139         * tui/tui-windata.h: Rename include guard.
9140         * tui/tui-win.h: Rename include guard.
9141         * tui/tui-stack.h: Rename include guard.
9142         * tui/tui-source.h: Rename include guard.
9143         * tui/tui-regs.h: Rename include guard.
9144         * tui/tui-out.h: Rename include guard.
9145         * tui/tui-layout.h: Rename include guard.
9146         * tui/tui-io.h: Rename include guard.
9147         * tui/tui-hooks.h: Rename include guard.
9148         * tui/tui-file.h: Rename include guard.
9149         * tui/tui-disasm.h: Rename include guard.
9150         * tui/tui-data.h: Rename include guard.
9151         * tui/tui-command.h: Rename include guard.
9152         * tic6x-tdep.h: Add include guard.
9153         * target/waitstatus.h: Rename include guard.
9154         * target/wait.h: Rename include guard.
9155         * target/target.h: Rename include guard.
9156         * target/resume.h: Rename include guard.
9157         * target-float.h: Rename include guard.
9158         * stabsread.h: Add include guard.
9159         * rs6000-tdep.h: Add include guard.
9160         * riscv-fbsd-tdep.h: Add include guard.
9161         * regformats/regdef.h: Rename include guard.
9162         * record.h: Rename include guard.
9163         * python/python.h: Rename include guard.
9164         * python/python-internal.h: Rename include guard.
9165         * python/py-stopevent.h: Rename include guard.
9166         * python/py-ref.h: Rename include guard.
9167         * python/py-record.h: Rename include guard.
9168         * python/py-record-full.h: Rename include guard.
9169         * python/py-record-btrace.h: Rename include guard.
9170         * python/py-instruction.h: Rename include guard.
9171         * python/py-events.h: Rename include guard.
9172         * python/py-event.h: Rename include guard.
9173         * procfs.h: Add include guard.
9174         * proc-utils.h: Add include guard.
9175         * p-lang.h: Add include guard.
9176         * or1k-tdep.h: Rename include guard.
9177         * observable.h: Rename include guard.
9178         * nto-tdep.h: Rename include guard.
9179         * nat/x86-linux.h: Rename include guard.
9180         * nat/x86-linux-dregs.h: Rename include guard.
9181         * nat/x86-gcc-cpuid.h: Add include guard.
9182         * nat/x86-dregs.h: Rename include guard.
9183         * nat/x86-cpuid.h: Rename include guard.
9184         * nat/ppc-linux.h: Rename include guard.
9185         * nat/mips-linux-watch.h: Rename include guard.
9186         * nat/linux-waitpid.h: Rename include guard.
9187         * nat/linux-ptrace.h: Rename include guard.
9188         * nat/linux-procfs.h: Rename include guard.
9189         * nat/linux-osdata.h: Rename include guard.
9190         * nat/linux-nat.h: Rename include guard.
9191         * nat/linux-namespaces.h: Rename include guard.
9192         * nat/linux-btrace.h: Rename include guard.
9193         * nat/glibc_thread_db.h: Rename include guard.
9194         * nat/gdb_thread_db.h: Rename include guard.
9195         * nat/gdb_ptrace.h: Rename include guard.
9196         * nat/fork-inferior.h: Rename include guard.
9197         * nat/amd64-linux-siginfo.h: Rename include guard.
9198         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9199         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9200         * nat/aarch64-linux.h: Rename include guard.
9201         * nat/aarch64-linux-hw-point.h: Rename include guard.
9202         * mn10300-tdep.h: Add include guard.
9203         * mips-linux-tdep.h: Add include guard.
9204         * mi/mi-parse.h: Rename include guard.
9205         * mi/mi-out.h: Rename include guard.
9206         * mi/mi-main.h: Rename include guard.
9207         * mi/mi-interp.h: Rename include guard.
9208         * mi/mi-getopt.h: Rename include guard.
9209         * mi/mi-console.h: Rename include guard.
9210         * mi/mi-common.h: Rename include guard.
9211         * mi/mi-cmds.h: Rename include guard.
9212         * mi/mi-cmd-break.h: Rename include guard.
9213         * m2-lang.h: Add include guard.
9214         * location.h: Rename include guard.
9215         * linux-record.h: Rename include guard.
9216         * linux-nat.h: Add include guard.
9217         * linux-fork.h: Add include guard.
9218         * i386-darwin-tdep.h: Rename include guard.
9219         * hppa-linux-offsets.h: Add include guard.
9220         * guile/guile.h: Rename include guard.
9221         * guile/guile-internal.h: Rename include guard.
9222         * gnu-nat.h: Rename include guard.
9223         * gdb-stabs.h: Rename include guard.
9224         * frv-tdep.h: Add include guard.
9225         * f-lang.h: Add include guard.
9226         * event-loop.h: Add include guard.
9227         * darwin-nat.h: Rename include guard.
9228         * cp-abi.h: Rename include guard.
9229         * config/sparc/nm-sol2.h: Rename include guard.
9230         * config/nm-nto.h: Rename include guard.
9231         * config/nm-linux.h: Add include guard.
9232         * config/i386/nm-i386gnu.h: Rename include guard.
9233         * config/djgpp/nl_types.h: Rename include guard.
9234         * config/djgpp/langinfo.h: Rename include guard.
9235         * compile/gcc-cp-plugin.h: Add include guard.
9236         * compile/gcc-c-plugin.h: Add include guard.
9237         * compile/compile.h: Rename include guard.
9238         * compile/compile-object-run.h: Rename include guard.
9239         * compile/compile-object-load.h: Rename include guard.
9240         * compile/compile-internal.h: Rename include guard.
9241         * compile/compile-cplus.h: Rename include guard.
9242         * compile/compile-c.h: Rename include guard.
9243         * common/xml-utils.h: Rename include guard.
9244         * common/x86-xstate.h: Rename include guard.
9245         * common/version.h: Rename include guard.
9246         * common/vec.h: Rename include guard.
9247         * common/tdesc.h: Rename include guard.
9248         * common/selftest.h: Rename include guard.
9249         * common/scoped_restore.h: Rename include guard.
9250         * common/scoped_mmap.h: Rename include guard.
9251         * common/scoped_fd.h: Rename include guard.
9252         * common/safe-iterator.h: Rename include guard.
9253         * common/run-time-clock.h: Rename include guard.
9254         * common/refcounted-object.h: Rename include guard.
9255         * common/queue.h: Rename include guard.
9256         * common/ptid.h: Rename include guard.
9257         * common/print-utils.h: Rename include guard.
9258         * common/preprocessor.h: Rename include guard.
9259         * common/pathstuff.h: Rename include guard.
9260         * common/observable.h: Rename include guard.
9261         * common/netstuff.h: Rename include guard.
9262         * common/job-control.h: Rename include guard.
9263         * common/host-defs.h: Rename include guard.
9264         * common/gdb_wait.h: Rename include guard.
9265         * common/gdb_vecs.h: Rename include guard.
9266         * common/gdb_unlinker.h: Rename include guard.
9267         * common/gdb_unique_ptr.h: Rename include guard.
9268         * common/gdb_tilde_expand.h: Rename include guard.
9269         * common/gdb_sys_time.h: Rename include guard.
9270         * common/gdb_string_view.h: Rename include guard.
9271         * common/gdb_splay_tree.h: Rename include guard.
9272         * common/gdb_setjmp.h: Rename include guard.
9273         * common/gdb_ref_ptr.h: Rename include guard.
9274         * common/gdb_optional.h: Rename include guard.
9275         * common/gdb_locale.h: Rename include guard.
9276         * common/gdb_assert.h: Rename include guard.
9277         * common/filtered-iterator.h: Rename include guard.
9278         * common/filestuff.h: Rename include guard.
9279         * common/fileio.h: Rename include guard.
9280         * common/environ.h: Rename include guard.
9281         * common/common-utils.h: Rename include guard.
9282         * common/common-types.h: Rename include guard.
9283         * common/common-regcache.h: Rename include guard.
9284         * common/common-inferior.h: Rename include guard.
9285         * common/common-gdbthread.h: Rename include guard.
9286         * common/common-exceptions.h: Rename include guard.
9287         * common/common-defs.h: Rename include guard.
9288         * common/common-debug.h: Rename include guard.
9289         * common/cleanups.h: Rename include guard.
9290         * common/buffer.h: Rename include guard.
9291         * common/btrace-common.h: Rename include guard.
9292         * common/break-common.h: Rename include guard.
9293         * cli/cli-utils.h: Rename include guard.
9294         * cli/cli-style.h: Rename include guard.
9295         * cli/cli-setshow.h: Rename include guard.
9296         * cli/cli-script.h: Rename include guard.
9297         * cli/cli-interp.h: Rename include guard.
9298         * cli/cli-decode.h: Rename include guard.
9299         * cli/cli-cmds.h: Rename include guard.
9300         * charset-list.h: Add include guard.
9301         * buildsym-legacy.h: Rename include guard.
9302         * bfin-tdep.h: Add include guard.
9303         * ax.h: Rename include guard.
9304         * arm-linux-tdep.h: Add include guard.
9305         * arm-fbsd-tdep.h: Add include guard.
9306         * arch/xtensa.h: Rename include guard.
9307         * arch/tic6x.h: Add include guard.
9308         * arch/i386.h: Add include guard.
9309         * arch/arm.h: Rename include guard.
9310         * arch/arm-linux.h: Rename include guard.
9311         * arch/arm-get-next-pcs.h: Rename include guard.
9312         * arch/amd64.h: Add include guard.
9313         * arch/aarch64-insn.h: Rename include guard.
9314         * arch-utils.h: Rename include guard.
9315         * annotate.h: Add include guard.
9316         * amd64-darwin-tdep.h: Rename include guard.
9317         * aarch64-linux-tdep.h: Add include guard.
9318         * aarch64-fbsd-tdep.h: Add include guard.
9319         * aarch32-linux-nat.h: Add include guard.
9320
9321 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9322
9323         * macrotab.c (macro_define_internal): New function that
9324         factorizes macro_define_object_internal and macro_define_function
9325         code.
9326         (macro_define_object_internal): Use macro_define_internal.
9327         (macro_define_function): Likewise.
9328
9329 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9330
9331         * macrocmd.c (extract_identifier): Return
9332         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9333         callers.
9334
9335 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9336
9337         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9338
9339 2019-02-05  Tom Tromey  <tom@tromey.com>
9340
9341         * target.c (target_stack::unpush): Move assertion earlier.
9342
9343 2019-01-30  Tom Tromey  <tom@tromey.com>
9344
9345         PR python/23615:
9346         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9347         (gdbpy_parse_and_eval): Likewise.
9348         * python/python-internal.h (gdbpy_allow_threads): New class.
9349
9350 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9351
9352         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9353         (aarch64_fbsd_fpregmap): Move earlier.
9354         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9355         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9356         instead of individual calls to trad_frame_set_reg_addr.
9357         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9358         earlier.
9359         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9360         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9361         instead of individual calls to trad_frame_set_reg_addr.
9362
9363 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9364
9365         * CONTRIBUTE: Replace contribution list with wiki link.
9366
9367 2019-01-25  Tom Tromey  <tom@tromey.com>
9368
9369         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9370
9371 2019-01-25  Tom Tromey  <tom@tromey.com>
9372
9373         * xtensa-linux-nat.c: Fix common/ includes.
9374         * xml-support.h: Fix common/ includes.
9375         * xml-support.c: Fix common/ includes.
9376         * x86-linux-nat.c: Fix common/ includes.
9377         * windows-nat.c: Fix common/ includes.
9378         * varobj.h: Fix common/ includes.
9379         * varobj.c: Fix common/ includes.
9380         * value.c: Fix common/ includes.
9381         * valops.c: Fix common/ includes.
9382         * utils.c: Fix common/ includes.
9383         * unittests/xml-utils-selftests.c: Fix common/ includes.
9384         * unittests/utils-selftests.c: Fix common/ includes.
9385         * unittests/unpack-selftests.c: Fix common/ includes.
9386         * unittests/tracepoint-selftests.c: Fix common/ includes.
9387         * unittests/style-selftests.c: Fix common/ includes.
9388         * unittests/string_view-selftests.c: Fix common/ includes.
9389         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9390         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9391         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9392         * unittests/rsp-low-selftests.c: Fix common/ includes.
9393         * unittests/parse-connection-spec-selftests.c: Fix common/
9394         includes.
9395         * unittests/optional-selftests.c: Fix common/ includes.
9396         * unittests/offset-type-selftests.c: Fix common/ includes.
9397         * unittests/observable-selftests.c: Fix common/ includes.
9398         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9399         * unittests/memrange-selftests.c: Fix common/ includes.
9400         * unittests/memory-map-selftests.c: Fix common/ includes.
9401         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9402         * unittests/function-view-selftests.c: Fix common/ includes.
9403         * unittests/environ-selftests.c: Fix common/ includes.
9404         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9405         * unittests/common-utils-selftests.c: Fix common/ includes.
9406         * unittests/cli-utils-selftests.c: Fix common/ includes.
9407         * unittests/array-view-selftests.c: Fix common/ includes.
9408         * ui-file.c: Fix common/ includes.
9409         * tui/tui-io.c: Fix common/ includes.
9410         * tracepoint.h: Fix common/ includes.
9411         * tracepoint.c: Fix common/ includes.
9412         * tracefile-tfile.c: Fix common/ includes.
9413         * top.h: Fix common/ includes.
9414         * top.c: Fix common/ includes.
9415         * thread.c: Fix common/ includes.
9416         * target/waitstatus.h: Fix common/ includes.
9417         * target/waitstatus.c: Fix common/ includes.
9418         * target.h: Fix common/ includes.
9419         * target.c: Fix common/ includes.
9420         * target-memory.c: Fix common/ includes.
9421         * target-descriptions.c: Fix common/ includes.
9422         * symtab.h: Fix common/ includes.
9423         * symfile.c: Fix common/ includes.
9424         * stap-probe.c: Fix common/ includes.
9425         * spu-linux-nat.c: Fix common/ includes.
9426         * sparc-nat.c: Fix common/ includes.
9427         * source.c: Fix common/ includes.
9428         * solib.c: Fix common/ includes.
9429         * solib-target.c: Fix common/ includes.
9430         * ser-unix.c: Fix common/ includes.
9431         * ser-tcp.c: Fix common/ includes.
9432         * ser-pipe.c: Fix common/ includes.
9433         * ser-base.c: Fix common/ includes.
9434         * selftest-arch.c: Fix common/ includes.
9435         * s12z-tdep.c: Fix common/ includes.
9436         * rust-exp.y: Fix common/ includes.
9437         * rs6000-aix-tdep.c: Fix common/ includes.
9438         * riscv-tdep.c: Fix common/ includes.
9439         * remote.c: Fix common/ includes.
9440         * remote-notif.h: Fix common/ includes.
9441         * remote-fileio.h: Fix common/ includes.
9442         * remote-fileio.c: Fix common/ includes.
9443         * regcache.h: Fix common/ includes.
9444         * regcache.c: Fix common/ includes.
9445         * record-btrace.c: Fix common/ includes.
9446         * python/python.c: Fix common/ includes.
9447         * python/py-type.c: Fix common/ includes.
9448         * python/py-inferior.c: Fix common/ includes.
9449         * progspace.h: Fix common/ includes.
9450         * producer.c: Fix common/ includes.
9451         * procfs.c: Fix common/ includes.
9452         * proc-api.c: Fix common/ includes.
9453         * printcmd.c: Fix common/ includes.
9454         * ppc-linux-nat.c: Fix common/ includes.
9455         * parser-defs.h: Fix common/ includes.
9456         * osdata.c: Fix common/ includes.
9457         * obsd-nat.c: Fix common/ includes.
9458         * nat/x86-linux.c: Fix common/ includes.
9459         * nat/x86-linux-dregs.c: Fix common/ includes.
9460         * nat/x86-dregs.h: Fix common/ includes.
9461         * nat/x86-dregs.c: Fix common/ includes.
9462         * nat/ppc-linux.c: Fix common/ includes.
9463         * nat/mips-linux-watch.h: Fix common/ includes.
9464         * nat/mips-linux-watch.c: Fix common/ includes.
9465         * nat/linux-waitpid.c: Fix common/ includes.
9466         * nat/linux-ptrace.h: Fix common/ includes.
9467         * nat/linux-ptrace.c: Fix common/ includes.
9468         * nat/linux-procfs.c: Fix common/ includes.
9469         * nat/linux-personality.c: Fix common/ includes.
9470         * nat/linux-osdata.c: Fix common/ includes.
9471         * nat/linux-namespaces.c: Fix common/ includes.
9472         * nat/linux-btrace.h: Fix common/ includes.
9473         * nat/linux-btrace.c: Fix common/ includes.
9474         * nat/fork-inferior.c: Fix common/ includes.
9475         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9476         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9477         * nat/aarch64-linux.c: Fix common/ includes.
9478         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9479         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9480         * namespace.h: Fix common/ includes.
9481         * mips-linux-tdep.c: Fix common/ includes.
9482         * minsyms.c: Fix common/ includes.
9483         * mi/mi-parse.h: Fix common/ includes.
9484         * mi/mi-main.c: Fix common/ includes.
9485         * mi/mi-cmd-env.c: Fix common/ includes.
9486         * memrange.h: Fix common/ includes.
9487         * memattr.c: Fix common/ includes.
9488         * maint.h: Fix common/ includes.
9489         * maint.c: Fix common/ includes.
9490         * main.c: Fix common/ includes.
9491         * machoread.c: Fix common/ includes.
9492         * location.c: Fix common/ includes.
9493         * linux-thread-db.c: Fix common/ includes.
9494         * linux-nat.c: Fix common/ includes.
9495         * linux-fork.c: Fix common/ includes.
9496         * inline-frame.c: Fix common/ includes.
9497         * infrun.c: Fix common/ includes.
9498         * inflow.c: Fix common/ includes.
9499         * inferior.h: Fix common/ includes.
9500         * inferior.c: Fix common/ includes.
9501         * infcmd.c: Fix common/ includes.
9502         * inf-ptrace.c: Fix common/ includes.
9503         * inf-child.c: Fix common/ includes.
9504         * ia64-linux-nat.c: Fix common/ includes.
9505         * i387-tdep.c: Fix common/ includes.
9506         * i386-tdep.c: Fix common/ includes.
9507         * i386-linux-tdep.c: Fix common/ includes.
9508         * i386-linux-nat.c: Fix common/ includes.
9509         * i386-go32-tdep.c: Fix common/ includes.
9510         * i386-fbsd-tdep.c: Fix common/ includes.
9511         * i386-fbsd-nat.c: Fix common/ includes.
9512         * guile/scm-type.c: Fix common/ includes.
9513         * guile/guile.c: Fix common/ includes.
9514         * go32-nat.c: Fix common/ includes.
9515         * gnu-nat.c: Fix common/ includes.
9516         * gdbthread.h: Fix common/ includes.
9517         * gdbarch-selftests.c: Fix common/ includes.
9518         * gdb_usleep.c: Fix common/ includes.
9519         * gdb_select.h: Fix common/ includes.
9520         * gdb_bfd.c: Fix common/ includes.
9521         * gcore.c: Fix common/ includes.
9522         * fork-child.c: Fix common/ includes.
9523         * findvar.c: Fix common/ includes.
9524         * fbsd-nat.c: Fix common/ includes.
9525         * event-top.c: Fix common/ includes.
9526         * event-loop.c: Fix common/ includes.
9527         * dwarf2read.c: Fix common/ includes.
9528         * dwarf2loc.c: Fix common/ includes.
9529         * dwarf2-frame.c: Fix common/ includes.
9530         * dwarf-index-cache.c: Fix common/ includes.
9531         * dtrace-probe.c: Fix common/ includes.
9532         * disasm-selftests.c: Fix common/ includes.
9533         * defs.h: Fix common/ includes.
9534         * csky-tdep.c: Fix common/ includes.
9535         * cp-valprint.c: Fix common/ includes.
9536         * cp-support.h: Fix common/ includes.
9537         * cp-support.c: Fix common/ includes.
9538         * corelow.c: Fix common/ includes.
9539         * completer.h: Fix common/ includes.
9540         * completer.c: Fix common/ includes.
9541         * compile/compile.c: Fix common/ includes.
9542         * compile/compile-loc2c.c: Fix common/ includes.
9543         * compile/compile-cplus-types.c: Fix common/ includes.
9544         * compile/compile-cplus-symbols.c: Fix common/ includes.
9545         * command.h: Fix common/ includes.
9546         * cli/cli-dump.c: Fix common/ includes.
9547         * cli/cli-cmds.c: Fix common/ includes.
9548         * charset.c: Fix common/ includes.
9549         * build-id.c: Fix common/ includes.
9550         * btrace.h: Fix common/ includes.
9551         * btrace.c: Fix common/ includes.
9552         * breakpoint.h: Fix common/ includes.
9553         * breakpoint.c: Fix common/ includes.
9554         * ax.h: 
9555         (enum agent_op): Fix common/ includes.
9556         * ax-general.c (struct aop_map): Fix common/ includes.
9557         * ax-gdb.c: Fix common/ includes.
9558         * auxv.c: Fix common/ includes.
9559         * auto-load.c: Fix common/ includes.
9560         * arm-tdep.c: Fix common/ includes.
9561         * arch/riscv.c: Fix common/ includes.
9562         * arch/ppc-linux-common.c: Fix common/ includes.
9563         * arch/i386.c: Fix common/ includes.
9564         * arch/arm.c: Fix common/ includes.
9565         * arch/arm-linux.c: Fix common/ includes.
9566         * arch/arm-get-next-pcs.c: Fix common/ includes.
9567         * arch/amd64.c: Fix common/ includes.
9568         * arch/aarch64.c: Fix common/ includes.
9569         * arch/aarch64-insn.c: Fix common/ includes.
9570         * arch-utils.c: Fix common/ includes.
9571         * amd64-windows-tdep.c: Fix common/ includes.
9572         * amd64-tdep.c: Fix common/ includes.
9573         * amd64-sol2-tdep.c: Fix common/ includes.
9574         * amd64-obsd-tdep.c: Fix common/ includes.
9575         * amd64-nbsd-tdep.c: Fix common/ includes.
9576         * amd64-linux-tdep.c: Fix common/ includes.
9577         * amd64-linux-nat.c: Fix common/ includes.
9578         * amd64-fbsd-tdep.c: Fix common/ includes.
9579         * amd64-fbsd-nat.c: Fix common/ includes.
9580         * amd64-dicos-tdep.c: Fix common/ includes.
9581         * amd64-darwin-tdep.c: Fix common/ includes.
9582         * agent.c: Fix common/ includes.
9583         * ada-lang.h: Fix common/ includes.
9584         * ada-lang.c: Fix common/ includes.
9585         * aarch64-tdep.c: Fix common/ includes.
9586
9587 2019-01-25  Tom Tromey  <tom@tromey.com>
9588
9589         * common/create-version.sh: Use common/version.h.
9590
9591 2019-01-24  Pedro Alves  <palves@redhat.com>
9592
9593         * infrun.c (signal_stop, signal_print, signal_program)
9594         (signal_catch, signal_pass): Now arrays instead of pointers.
9595         (update_signals_program_target, do_target_resume)
9596         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9597         * linux-nat.c (linux_nat_target::pass_signals)
9598         (linux_nat_target::create_inferior, linux_nat_target::attach):
9599         Adjust.
9600         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9601         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9602         * procfs.c (procfs_target::pass_signals): Adjust.
9603         * record-full.c (record_full_target::resume): Adjust.
9604         * remote.c (remote_target::pass_signals)
9605         (remote_target::program_signals): Adjust.
9606         * target-debug.h (target_debug_print_signals): Now takes a
9607         gdb::array_view as parameter.  Adjust.
9608         * target.h (target_ops) <pass_signals, program_signals>: Replace
9609         pointer and length parameters with gdb::array_view.
9610         (target_pass_signals, target_program_signals): Likewise.
9611         * target-delegates.c: Regenerate.
9612
9613 2019-01-24  Pedro Alves  <palves@redhat.com>
9614
9615         * common/forward-scope-exit.h
9616         (forward_scope_exit::forward_scope_exit): Pass arguments to
9617         m_bind_function directly, instead of creating a std::bind and
9618         copying that.
9619
9620 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9621
9622         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9623         for static members.
9624         (pass_in_v_vfp_candidate): Likewise.
9625
9626 2019-01-23  Tom Tromey  <tom@tromey.com>
9627             Pedro Alves  <palves@redhat.com>
9628
9629         * regcache.c (class regcache_invalidator): Remove.
9630         (regcache::raw_write): Use make_scope_exit.
9631
9632 2019-01-23  Tom Tromey  <tom@tromey.com>
9633
9634         * ui-out.h (class ui_out_emit_type): Update comment.
9635
9636 2019-01-23  Tom Tromey  <tom@tromey.com>
9637
9638         * infrun.c (fetch_inferior_event): Update comment.
9639
9640 2019-01-23  Tom Tromey  <tom@tromey.com>
9641             Pedro Alves  <palves@redhat.com>
9642
9643         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9644         parameter.
9645         (fetch_inferior_event): Use SCOPE_EXIT.
9646
9647
9648 2019-01-23  Tom Tromey  <tom@tromey.com>
9649             Pedro Alves  <palves@redhat.com>
9650
9651         * infrun.c (disable_thread_events): Delete.
9652         (stop_all_threads): Use SCOPE_EXIT.
9653
9654 2019-01-23  Tom Tromey  <tom@tromey.com>
9655             Pedro Alves  <palves@redhat.com>
9656
9657         * symfile.c: Include forward-scope-exit.h.
9658         (clear_symtab_users_cleanup): Replace forward declaration with
9659         a FORWARD_SCOPE_EXIT.
9660         (syms_from_objfile_1): Use the forward_scope_exit and
9661         gdb::optional instead of cleanup_function.
9662         (reread_symbols): Use the forward_scope_exit instead of
9663         cleanup_function.
9664         (clear_symtab_users_cleanup): Remove function.
9665
9666 2019-01-23  Tom Tromey  <tom@tromey.com>
9667             Pedro Alves  <palves@redhat.com>
9668
9669         * linux-nat.c: Include scope-exit.h.
9670         (cleanup_target_stop): Remove.
9671         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9672         SCOPE_EXIT.
9673
9674 2019-01-23  Tom Tromey  <tom@tromey.com>
9675             Pedro Alves  <palves@redhat.com>
9676
9677         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9678         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9679
9680 2019-01-23  Tom Tromey  <tom@tromey.com>
9681             Andrew Burgess  <andrew.burgess@embecosm.com>
9682             Pedro Alves  <palves@redhat.com>
9683
9684         * infrun.c (fetch_inferior_event): Use scope_exit.
9685         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9686         * top.c (execute_command): Use scope_exit.
9687         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9688         * utils.c (do_bpstat_clear_actions_cleanup)
9689         (make_bpstat_clear_actions_cleanup): Remove.
9690
9691 2019-01-23  Tom Tromey  <tom@tromey.com>
9692             Pedro Alves  <palves@redhat.com>
9693
9694         * infrun.c: Include "common/scope-exit.h"
9695         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9696         (wait_for_inferior): Use SCOPE_EXIT.
9697         (fetch_inferior_event): Use scope_exit.
9698
9699 2019-01-23  Tom Tromey  <tom@tromey.com>
9700             Pedro Alves  <palves@redhat.com>
9701
9702         * breakpoint.c (create_breakpoint): Remove cleanup.
9703
9704 2019-01-23  Tom Tromey  <tom@tromey.com>
9705             Andrew Burgess  <andrew.burgess@embecosm.com>
9706             Pedro Alves  <palves@redhat.com>
9707
9708 2019-01-23  Pedro Alves  <palves@redhat.com>
9709
9710         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9711
9712 2019-01-23  Pedro Alves  <palves@redhat.com>
9713             Andrew Burgess  <andrew.burgess@embecosm.com>
9714
9715         * gdbthread.h: Include "common/forward-scope-exit.h".
9716         (scoped_finish_thread_state): Redefine custom class in terms of
9717         forward_scope_exit.
9718
9719 2019-01-23  Pedro Alves  <palves@redhat.com>
9720             Andrew Burgess  <andrew.burgess@embecosm.com>
9721
9722         * common/forward-scope-exit.h: New file.
9723
9724 2019-01-23  Pedro Alves  <palves@redhat.com>
9725             Andrew Burgess  <andrew.burgess@embecosm.com>
9726             Tom Tromey  <tom@tromey.com>
9727
9728         * common/scope-exit.h: New file.
9729
9730 2019-01-23  Pedro Alves  <palves@redhat.com>
9731
9732         * common/preprocessor.h (ESC): Rename to ...
9733         (ESC_PARENS): ... this.
9734         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9735         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9736
9737 2019-01-23  Tom Tromey  <tom@tromey.com>
9738
9739         * language.h (class scoped_switch_to_sym_language_if_auto):
9740         Initialize m_lang in both cases.
9741
9742 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9743
9744         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9745         with XCNEW.
9746
9747 2019-01-22  Tom Tromey  <tom@tromey.com>
9748
9749         * corelow.c: Do not include sys/file.h.
9750
9751 2019-01-22  Tom Tromey  <tom@tromey.com>
9752
9753         * tui/tui-wingeneral.h: Include gdb_curses.h.
9754
9755 2019-01-22  Tom Tromey  <tom@tromey.com>
9756
9757         * source-cache.h (class source_cache) <get_source_lines,
9758         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9759
9760 2019-01-22  Tom Tromey  <tom@tromey.com>
9761
9762         * remote-fileio.h (struct remote_target): Declare.
9763
9764 2019-01-22  Tom Tromey  <tom@tromey.com>
9765
9766         * python/py-arch.c: Do not include py-ref.h.
9767         * python/py-bpevent.c: Do not include py-ref.h.
9768         * python/py-cmd.c: Do not include py-ref.h.
9769         * python/py-continueevent.c: Do not include py-ref.h.
9770         * python/py-event.h: Do not include py-ref.h.
9771         * python/py-evtregistry.c: Do not include py-ref.h.
9772         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9773         * python/py-frame.c: Do not include py-ref.h.
9774         * python/py-framefilter.c: Do not include py-ref.h.
9775         * python/py-function.c: Do not include py-ref.h.
9776         * python/py-infevents.c: Do not include py-ref.h.
9777         * python/py-linetable.c: Do not include py-ref.h.
9778         * python/py-objfile.c: Do not include py-ref.h.
9779         * python/py-param.c: Do not include py-ref.h.
9780         * python/py-prettyprint.c: Do not include py-ref.h.
9781         * python/py-progspace.c: Do not include py-ref.h.
9782         * python/py-symbol.c: Do not include py-ref.h.
9783         * python/py-symtab.c: Do not include py-ref.h.
9784         * python/py-type.c: Do not include py-ref.h.
9785         * python/py-unwind.c: Do not include py-ref.h.
9786         * python/py-utils.c: Do not include py-ref.h.
9787         * python/py-value.c: Do not include py-ref.h.
9788         * python/py-varobj.c: Do not include py-ref.h.
9789         * python/py-xmethods.c: Do not include py-ref.h.
9790         * python/python.c: Do not include py-ref.h.
9791         * varobj.c: Do not include py-ref.h.
9792
9793 2019-01-22  Tom Tromey  <tom@tromey.com>
9794
9795         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9796         keyword for bcache.
9797
9798 2019-01-22  Tom Tromey  <tom@tromey.com>
9799
9800         * compile/compile-cplus-types.c: Remove a comment by #include.
9801
9802 2019-01-22  Tom Tromey  <tom@tromey.com>
9803
9804         * compile/gcc-c-plugin.h: Include compile-internal.h.
9805
9806 2019-01-22  Tom Tromey  <tom@tromey.com>
9807
9808         * stabsread.c (EXTERN): Do not define.
9809         (symnum, next_symbol_text_func, processing_gcc_compilation)
9810         (within_function, global_sym_chain, global_stabs)
9811         (previous_stab_code, this_object_header_files)
9812         (n_this_object_header_files)
9813         (n_allocated_this_object_header_files): Define.
9814         * stabsread.h (EXTERN): Never define.  Use "extern".
9815
9816 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9817
9818         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9819         history_value.
9820
9821 2019-01-21  Tom Tromey  <tom@tromey.com>
9822
9823         * ui-out.c: Fix includes.
9824         * tui/tui-source.c: Fix includes.
9825         * target.c: Fix includes.
9826         * remote.c: Fix includes.
9827         * regcache.c: Fix includes.
9828         * python/py-block.c: Fix includes.
9829         * printcmd.c: Fix includes.
9830         * or1k-tdep.c: Fix includes.
9831         * mi/mi-main.c: Fix includes.
9832         * m32r-tdep.c: Fix includes.
9833         * csky-tdep.c: Fix includes.
9834         * compile/compile-cplus-types.c: Fix includes.
9835         * cli/cli-interp.c: Fix includes.
9836
9837 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9838
9839         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9840         for padding.
9841
9842 2019-01-16  Tom Tromey  <tom@tromey.com>
9843
9844         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9845         earlier.
9846         (struct objfile) <msymbols_range>: Move from top level.
9847         <msymbols>: New method.
9848         (class objfile_msymbols): Remove.
9849         * symtab.c (default_collect_symbol_completion_matches_break_on):
9850         Update.
9851         * symmisc.c (dump_msymbols): Update.
9852         * stabsread.c (scan_file_globals): Update.
9853         * objc-lang.c (info_selectors_command, info_classes_command)
9854         (find_methods): Update.
9855         * minsyms.c (find_solib_trampoline_target): Update.
9856         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9857         * coffread.c (coff_symfile_read): Update.
9858         * ada-lang.c (ada_lookup_simple_minsym)
9859         (ada_collect_symbol_completion_matches): Update.
9860
9861 2019-01-16  Tom Tromey  <tom@tromey.com>
9862
9863         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9864         type.  Remove no-argument constructor.
9865         <iterator::operator++>: Simplify.
9866         <begin>: Update.
9867         <end>: Use minimal_symbol_count.
9868
9869 2019-01-16  Tom Tromey  <tom@tromey.com>
9870
9871         * objfiles.h (struct objfile) <psymtabs>: New method.
9872         (class objfile_psymtabs): Remove.
9873         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9874         typedef.
9875         <range>: New method.
9876         (require_partial_symbols): Change return type.
9877         * psymtab.c (require_partial_symbols)
9878         (psym_expand_symtabs_matching): Update.
9879         * mdebugread.c (parse_partial_symbols): Update.
9880         * dbxread.c (dbx_end_psymtab): Update.
9881
9882 2019-01-15  Tom Tromey  <tom@tromey.com>
9883
9884         * symtab.c (lookup_objfile_from_block)
9885         (lookup_symbol_in_objfile_symtabs)
9886         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9887         (find_line_symtab, info_sources_command)
9888         (default_collect_symbol_completion_matches_break_on)
9889         (make_source_files_completion_list): Update.
9890         * symmisc.c (print_objfile_statistics, dump_objfile)
9891         (maintenance_print_symbols, maintenance_info_symtabs)
9892         (maintenance_check_symtabs, maintenance_info_line_tables):
9893         Update.
9894         * source.c (select_source_symtab)
9895         (forget_cached_source_info_for_objfile): Update.
9896         * objfiles.h (class objfile_compunits): Remove.
9897         (struct objfile) <compunits_range>: New typedef.
9898         (compunits): New method.
9899         * objfiles.c (objfile_relocate1): Update.
9900         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9901         * maint.c (count_symtabs_and_blocks): Update.
9902         * linespec.c (iterate_over_all_matching_symtabs): Update.
9903         * cp-support.c (add_symbol_overload_list_qualified): Update.
9904         * coffread.c (coff_symtab_read): Update.
9905         * ada-lang.c (add_nonlocal_symbols)
9906         (ada_collect_symbol_completion_matches)
9907         (ada_add_global_exceptions): Update.
9908
9909 2019-01-15  Tom Tromey  <tom@tromey.com>
9910
9911         * progspace.h (program_space) <objfiles_safe_range>: New
9912         typedef.
9913         <objfiles_safe>: New method.
9914         * objfiles.h (class all_objfiles_safe): Remove.
9915         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9916         * jit.c (jit_inferior_exit_hook): Update.
9917
9918 2019-01-17  Tom Tromey  <tom@tromey.com>
9919
9920         * progspace.h (program_space) <objfiles_range>: New typedef.
9921         <objfiles>: New method.
9922         <objfiles_head>: Rename from objfiles.
9923         (object_files): Update.
9924         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9925         * guile/scm-pretty-print.c
9926         (ppscm_find_pretty_printer_from_objfiles): Update.
9927         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9928         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9929         Update.
9930         * python/py-progspace.c (pspy_get_objfiles): Update.
9931         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9932         Update.
9933         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9934         (objfpy_lookup_objfile_by_build_id): Update.
9935         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9936         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9937         Update.
9938         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9939         (expand_symtab_containing_pc, lookup_objfile_from_block)
9940         (lookup_static_symbol, basic_lookup_transparent_type)
9941         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9942         (find_line_symtab, info_sources_command)
9943         (default_collect_symbol_completion_matches_break_on)
9944         (make_source_files_completion_list, find_main_name): Update.
9945         * symmisc.c (print_symbol_bcache_statistics)
9946         (print_objfile_statistics, maintenance_print_symbols)
9947         (maintenance_print_msymbols, maintenance_print_objfiles)
9948         (maintenance_info_symtabs, maintenance_check_symtabs)
9949         (maintenance_expand_symtabs, maintenance_info_line_tables):
9950         Update.
9951         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9952         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9953         (map_overlay_command, unmap_overlay_command)
9954         (simple_overlay_update, expand_symtabs_matching)
9955         (map_symbol_filenames): Update.
9956         * symfile-debug.c (set_debug_symfile): Update.
9957         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9958         Update.
9959         * source.c (select_source_symtab, forget_cached_source_info):
9960         Update.
9961         * solib.c (solib_read_symbols): Update.
9962         * solib-spu.c (append_ocl_sos): Update.
9963         * psymtab.c (maintenance_print_psymbols)
9964         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9965         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9966         * printcmd.c (info_symbol_command): Update.
9967         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9968         Update.
9969         * objfiles.h (class all_objfiles): Remove.
9970         * objfiles.c (have_partial_symbols, have_full_symbols)
9971         (have_minimal_symbols, qsort_cmp, update_section_map)
9972         (shared_objfile_contains_address_p)
9973         (default_iterate_over_objfiles_in_search_order): Update.
9974         * objc-lang.c (info_selectors_command, info_classes_command)
9975         (find_methods): Update.
9976         * minsyms.c (find_solib_trampoline_target): Update.
9977         * maint.c (maintenance_info_sections)
9978         (maintenance_translate_address, count_symtabs_and_blocks):
9979         Update.
9980         * main.c (captured_main_1): Update.
9981         * linux-thread-db.c (try_thread_db_load_from_pdir)
9982         (has_libpthread): Update.
9983         * linespec.c (iterate_over_all_matching_symtabs)
9984         (search_minsyms_for_name): Update.
9985         * jit.c (jit_find_objf_with_entry_addr): Update.
9986         * hppa-tdep.c (find_unwind_entry)
9987         (hppa_lookup_stub_minimal_symbol): Update.
9988         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9989         Update.
9990         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9991         (elf_gnu_ifunc_resolve_by_got): Update.
9992         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9993         * dwarf-index-write.c (save_gdb_index_command): Update.
9994         * cp-support.c (add_symbol_overload_list_qualified): Update.
9995         * breakpoint.c (create_overlay_event_breakpoint)
9996         (create_longjmp_master_breakpoint)
9997         (create_std_terminate_master_breakpoint)
9998         (create_exception_master_breakpoint): Update.
9999         * blockframe.c (find_pc_partial_function): Update.
10000         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10001         (ada_collect_symbol_completion_matches)
10002         (ada_add_global_exceptions): Update.
10003
10004 2019-01-17  Tom Tromey  <tom@tromey.com>
10005
10006         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10007         declare VEC.
10008         (solib_target_parse_libraries): Change return type.
10009         (library_list_start_segment, library_list_start_section)
10010         (library_list_end_library, library_list_start_library); Update.
10011         (solib_target_free_library_list): Remove.
10012         (solib_target_parse_libraries): Remove cleanup.  Change return
10013         type.
10014         (solib_target_current_sos): Update.
10015
10016 2019-01-17  Tom Tromey  <tromey@bapiya>
10017
10018         * valprint.c: Replace "the the" with "the".
10019         * symtab.c: Replace "the the" with "the".
10020         * solib.c: Replace "the the" with "the".
10021         * solib-dsbt.c: Replace "the the" with "the".
10022         * linespec.c: Replace "the the" with "the".
10023         * dwarf2loc.h: Replace "the the" with "the".
10024         * amd64-windows-tdep.c: Replace "the the" with "the".
10025         * aarch64-tdep.c: Replace "the the" with "the".
10026
10027 2019-01-16  Keith Seitz  <keiths@redhat.com>
10028
10029         PR gdb/23773
10030         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10031         <builder>: Rename to ..
10032         <m_builder>: ... this and make private.
10033         (dwarf2_cu::get_builder): New method.  Change all users of
10034         `builder' to use this method.
10035         (dwarf2_start_symtab): Move to ...
10036         (dwarf2_cu::start_symtab): ... here.  Update all callers
10037         (setup_type_unit_groups): Move to ...
10038         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10039         callers.
10040         (dwarf2_cu::reset_builder): New method.
10041         (process_full_compunit, process_full_type_unit): Use
10042         dwarf2_cu::reset_builder.
10043         (follow_die_offset): Record the ancestor CU if it is different
10044         from the followed DIE's CU.
10045         (follow_die_sig_1): Likewise.
10046
10047 2019-01-15  Tom Tromey  <tom@tromey.com>
10048
10049         * remote.c (class remote_state) <buf>: Now a char_vector.
10050         <buf_size>: Remove.
10051         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10052         parameter.
10053         (remote_target::getpkt_or_notif_sane_1)
10054         (remote_target::getpkt_sane)
10055         (remote_target::getpkt_or_notif_sane): Likewise.
10056         (class remote_target) <putpkt>: New overload.
10057         (remote_target::read_frame): Change type of "buf_p".  Remove
10058         sizeof_p parameter.
10059         (packet_ok): New overload.
10060         (packet_check_result): New overload.
10061         Update all uses.
10062
10063 2019-01-14  Tom Tromey  <tom@tromey.com>
10064
10065         * remote-notif.c (handle_notification, remote_notif_ack)
10066         (remote_notif_parse): Make "buf" const.
10067         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10068         const.
10069         (remote_notif_parse, remote_notif_ack, handle_notification):
10070         Likewise.
10071         * remote.c (remote_notif_stop_parse): Make "buf" const.
10072         (remote_target::remote_parse_stop_reply): Make "buf" const.
10073         (remote_notif_stop_ack): Make "buf" const.
10074
10075 2019-01-14  Tom Tromey  <tom@tromey.com>
10076
10077         * remote.c (remote_console_output): Make parameter const.
10078
10079 2019-01-14  Tom Tromey  <tom@tromey.com>
10080
10081         * target-debug.h (target_debug_print_signals): Constify.
10082         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10083         * procfs.c (procfs_target::pass_signals): Update.
10084         * linux-nat.c (linux_nat_target::pass_signals): Update.
10085         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10086         * target-delegates.c: Rebuild.
10087         * remote.c (remote_target::program_signals): Update.
10088         (remote_target::pass_signals): Update.
10089         * target.c (target_pass_signals): Constify argument.
10090         (target_program_signals): Likewise.
10091         * target.h (struct target_ops) <pass_signals, program_signals>:
10092         Constify argument.
10093         (target_pass_signals, target_program_signals): Constify argument.
10094
10095 2019-01-14  Tom Tromey  <tom@tromey.com>
10096
10097         PR tui/28819:
10098         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10099
10100 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10101
10102         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10103         field.
10104         * rs6000-tdep.c: Include reggroups.h.
10105         (IS_V_ALIAS_PSEUDOREG): Define.
10106         (rs6000_register_name): Return names for the "vX" aliases.
10107         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10108         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10109         aliases.  Call default_register_reggroup_p for all other
10110         pseudo-registers.
10111         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10112         New functions.
10113         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10114         Handle "vX" aliases.
10115         (v_alias_pseudo_register_collect): New function.
10116         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10117         (rs6000_gdbarch_init): Initialize "vX" aliases as
10118         pseudo-registers.  Restore registration of
10119         rs6000_pseudo_register_reggroup_p with
10120         set_tdesc_pseudo_register_reggroup_p.
10121
10122 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10123
10124         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10125         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10126         set_gdbarch_num_pseudo_regs.
10127
10128 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10129
10130         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10131         Remove arg prefixname, add do_set and do_show.
10132         Add member functions set_list and show_list.
10133         * cli/cli-style.c (class cli_style_option): Update accordingly.
10134         (style_set_list): Move to file scope.
10135         (style_show_list): Likewise.
10136         (set_style): Call help_list.
10137         (show_style): Call cmd_show_list.
10138         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10139         Update to use the new macro.
10140
10141 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10142
10143         * ada-lang.c (_initialize_ada_language): Expand the help text
10144         for the "catch exception" command.
10145
10146 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10147
10148         * symtab.c (matching_obj_sections): Initialize obj,
10149         declare it closer to its usage.
10150
10151 2019-01-10  Tom Tromey  <tom@tromey.com>
10152
10153         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10154         (basic_inf_threads_range): Remove.
10155         (inf_threads_range, inf_non_exited_threads_range)
10156         (safe_inf_threads_range): Use next_adapter.
10157
10158 2019-01-10  Keith Seitz  <keiths@redhat.com>
10159
10160         PR gdb/23712
10161         PR symtab/23010
10162         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10163         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10164
10165 2019-01-10  Keith Seitz  <keiths@redhat.com>
10166
10167         PR gdb/23712
10168         PR symtab/23010
10169         * dictionary.c (pending_to_vector): Remove.
10170         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10171         Remove _1 suffix, replacing functions of the same name.  Update
10172         all callers.
10173         (dict_create_hashed, dict_create_hashed_expandable)
10174         (dict_create_linear, dict_create_linear_expandable, dict_free)
10175         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10176         Make functions static.
10177
10178 2019-01-10  Keith Seitz  <keiths@redhat.com>
10179
10180         PR gdb/23712
10181         PR symtab/23010
10182         * dictionary.h (struct dictionary): Replace declaration with
10183         multidictionary.
10184         (dict_create_hashed, dict_create_hashed_expandable)
10185         (dict_create_linear, dict_create_linear_expandable)
10186         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10187         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10188         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10189         taking multidictionary argument.
10190         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10191         * block.h (struct block) <dict>: Change to multidictionary
10192         and rename `multidict'.
10193         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10194         symmisc.c: Update all dictionary references to multidictionary.
10195
10196 2019-01-10  Keith Seitz  <keiths@redhat.com>
10197
10198         PR gdb/23712
10199         PR symtab/23010
10200         * dictionary.c: Include unordered_map.
10201         (pending_to_vector): New function.
10202         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10203         Rewrite the non-"_1" functions to take vector instead
10204         of linked list.
10205         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10206         "new" _1 versions of the same name.
10207         (multidictionary): Define.
10208         (std::hash<enum language): New definition.
10209         (collate_pending_symbols_by_language, mdict_create_hashed)
10210         (mdict_create_hashed_expandable, mdict_create_linear)
10211         (mdict_create_linear_expandable, mdict_free)
10212         (find_language_dictionary, create_new_language_dictionary)
10213         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10214         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10215         (mdict_size, mdict_empty): New functions.
10216         * dictionary.h (mdict_iterator): Define.
10217
10218 2019-01-10  Pedro Alves  <palves@redhat.com>
10219
10220         * breakpoint.c (read_uploaded_action)
10221         (create_tracepoint_from_upload): Adjust to use
10222         gdb::unique_xmalloc_ptr.
10223         * ctf.c (ctf_write_uploaded_tp):
10224         (SET_ARRAY_FIELD): Use emplace_back.
10225         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10226         * tracefile-tfile.c (tfile_write_uploaded_tp):
10227         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10228         gdb::unique_xmalloc_ptr.
10229         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10230         at_string, cond_string, cmd_strings>: Replace char pointers
10231         with gdb::unique_xmalloc_ptr.
10232
10233 2019-01-10  Pedro Alves  <palves@redhat.com>
10234
10235         * solib-target.c (library_list_start_library): Don't xstrdup name.
10236
10237 2019-01-10  Pedro Alves  <palves@redhat.com>
10238
10239         * mdebugread.c (parse_partial_symbols): Use
10240         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10241
10242 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10243
10244         * linux-fork.c (scoped_switch_fork_info)
10245         <~scoped_switch_fork_info>: Fix incorrect variable name.
10246
10247 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10248
10249         * linux-fork.c (scoped_switch_fork_info)
10250         <scoped_switch_fork_info>: Make explicit.
10251         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10252
10253 2019-01-10  Tom Tromey  <tom@tromey.com>
10254
10255         * objfiles.h (objfile::reset_psymtabs): Update.
10256         * objfiles.c (objfile::objfile): Update.
10257         * psymtab.h (psymtab_storage::obstack): Update.
10258         (psymtab_storage::m_obstack): Use gdb::optional.
10259         (class psymtab_storage): Update comment.  Remove objfile
10260         parameter.
10261         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10262
10263 2019-01-10  Tom Tromey  <tom@tromey.com>
10264
10265         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10266         <free_psymtabs>: Now private.
10267         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10268         (allocate_psymtab): Use new method.
10269
10270 2019-01-10  Tom Tromey  <tom@tromey.com>
10271
10272         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10273         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10274         * mdebugread.c (parse_partial_symbols): Use
10275         allocate_dependencies.
10276         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10277         allocate_dependencies.
10278         (process_psymtab_comp_unit_reader)
10279         (build_type_psymtab_dependencies): Likewise.
10280         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10281
10282 2019-01-10  Tom Tromey  <tom@tromey.com>
10283
10284         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10285         PSYMBOL_SET_LANGUAGE.
10286         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10287
10288 2019-01-10  Tom Tromey  <tom@tromey.com>
10289
10290         * psymtab.h (psymtab_storage::obstack): New method.
10291         <m_obstack>: Rename from obstack; now private.
10292         * psymtab.c (psymtab_storage): Update.
10293         * dwarf2read.c (create_addrmap_from_index)
10294         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10295         Update.
10296
10297 2019-01-10  Tom Tromey  <tom@tromey.com>
10298
10299         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10300         * objfiles.h (objfile::reset_psymtabs): New method.
10301
10302 2019-01-10  Tom Tromey  <tom@tromey.com>
10303
10304         * symmisc.c (print_symbol_bcache_statistics): Update.
10305         (print_objfile_statistics): Update.
10306         * symfile.c (reread_symbols): Update.
10307         * psymtab.h (class psymtab_storage): New.
10308         * psymtab.c (psymtab_storage): New constructor.
10309         (~psymtab_storage): New destructor.
10310         (require_partial_symbols): Update.
10311         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10312         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10313         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10314         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10315         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10316         (start_psymtab_common, end_psymtab_common)
10317         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10318         (allocate_psymtab): Update.
10319         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10320         Update.
10321         (dump_psymtab_addrmap, maintenance_print_psymbols)
10322         (maintenance_check_psymtabs): Update.
10323         (class objfile_psymtabs): Move to objfiles.h.
10324         * psympriv.h (discard_psymtab): Now inline.
10325         (psymtab_discarder::psymtab_discarder): Update.
10326         (psymtab_discarder::~psymtab_discarder): Update.
10327         (ALL_OBJFILE_PSYMTABS): Rewrite.
10328         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10329         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10330         Remove fields.
10331         <partial_symtabs>: New field.
10332         (class objfile_psymtabs): Move from psymtab.h.  Update.
10333         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10334         psymbol_cache.
10335         (objfile::~objfile): Don't destroy psymbol_cache.
10336         * mdebugread.c (parse_partial_symbols): Update.
10337         * dwarf2read.c (create_addrmap_from_index)
10338         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10339         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10340         (add_partial_subprogram, dwarf2_ranges_read): Update.
10341         * dwarf-index-write.c (write_address_map)
10342         (write_one_signatured_type, recursively_write_psymbols)
10343         (class debug_names, class debug_names, write_psymtabs_to_index):
10344         Update.
10345
10346 2019-01-10  Tom Tromey  <tom@tromey.com>
10347
10348         * symtab.h (SYMBOL_SET_NAMES): Update.
10349         (symbol_set_names): Update.
10350         (MSYMBOL_SET_NAMES): Update.
10351         * symtab.c (symbol_set_names): Change argument to be an
10352         objfile_per_bfd_storage.
10353         * psymtab.c (add_psymbol_to_bcache): Update.
10354         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10355
10356 2019-01-10  Tom Tromey  <tom@tromey.com>
10357
10358         * symtab.c (create_demangled_names_hash): Change argument to be an
10359         objfile_per_bfd_storage.
10360         (symbol_set_names): Update.
10361
10362 2019-01-10  Tom Tromey  <tom@tromey.com>
10363
10364         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10365         init_psymbol_list.
10366         * psymtab.c (init_psymbol_list): Do nothing if already called.
10367         * psympriv.h (init_psymbol_list): Add comment.
10368         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10369         init_psymbol_list.
10370         * dbxread.c (dbx_symfile_read): Unconditionally call
10371         init_psymbol_list.
10372
10373 2019-01-10  Tom Tromey  <tom@tromey.com>
10374
10375         * xcoffread.c (scan_xcoff_symtab): Update.
10376         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10377         "where".
10378         * mdebugread.c (parse_partial_symbols)
10379         (handle_psymbol_enumerators): Update.
10380         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10381         * dbxread.c (read_dbx_symtab): Update.
10382         * psympriv.h (psymbol_placement): New enum.
10383         (add_psymbol_to_list): Update.
10384
10385 2019-01-10  Tom Tromey  <tom@tromey.com>
10386
10387         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10388         static_psymbols parameters.
10389         (scan_xcoff_symtab): Update.
10390         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10391         static_psymbols parameters.
10392         * psympriv.h (start_psymtab_common): Update.
10393         * mdebugread.c (parse_partial_symbols): Update.
10394         * dwarf2read.c (create_partial_symtab): Update.
10395         * dbxread.c (read_dbx_symtab): Update.
10396         (start_psymtab): Remove global_psymbols and static_psymbols
10397         parameters.
10398
10399 2019-01-10  Tom Tromey  <tom@tromey.com>
10400
10401         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10402         * psymtab.c (allocate_psymtab): Add comment.
10403         * psympriv.h (allocate_psymtab): Add comment.
10404         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10405         initializations.
10406         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10407
10408 2019-01-10  Tom Tromey  <tom@tromey.com>
10409
10410         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10411         Don't declare.
10412         * mipsread.c: Include mdebugread.h.
10413         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10414         Declare.
10415         * elfread.c: Include mdebugread.h.
10416
10417 2019-01-09  Tom Tromey  <tom@tromey.com>
10418
10419         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10420         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10421         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10422         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10423         (psym_lookup_symbol, psym_find_last_source_symtab)
10424         (psym_forget_cached_source_info, psym_print_stats)
10425         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10426         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10427         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10428         (psym_find_compunit_symtab_by_address)
10429         (maintenance_print_psymbols, maintenance_info_psymtabs)
10430         (maintenance_check_psymtabs): Use ranged for.
10431         * psymtab.h (class objfile_psymtabs): New.
10432         (require_partial_symbols): Return objfile_psymtabs.
10433         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10434
10435 2019-01-09  Tom Tromey  <tom@tromey.com>
10436
10437         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10438         (find_pc_mapped_section, list_overlays_command)
10439         (map_overlay_command, unmap_overlay_command)
10440         (simple_overlay_update): Use all_objfiles.
10441         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10442         * printcmd.c (info_symbol_command): Use all_objfiles.
10443         * objfiles.h (ALL_OBJSECTIONS): Remove.
10444         * maint.c (maintenance_translate_address): Use all_objfiles.
10445         * gcore.c (gcore_create_callback): Use all_objfiles.
10446         (objfile_find_memory_regions): Likewise.
10447
10448 2019-01-09  Tom Tromey  <tom@tromey.com>
10449
10450         * symtab.c (find_line_symtab, info_sources_command)
10451         (make_source_files_completion_list): Use objfile_compunits.
10452         * source.c (select_source_symtab): Use objfile_compunits.
10453         * objfiles.h (struct objfile): Update comment.
10454         (ALL_OBJFILES): Remove.
10455         (ALL_FILETABS): Remove.
10456         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10457         objfile_compunits.
10458
10459 2019-01-09  Tom Tromey  <tom@tromey.com>
10460
10461         * symmisc.c (print_objfile_statistics, dump_objfile)
10462         (maintenance_print_symbols): Use compunit_filetabs.
10463         * source.c (forget_cached_source_info_for_objfile): Use
10464         compunit_filetabs.
10465         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10466         (ALL_FILETABS): Use compunit_filetabs.
10467         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10468         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10469
10470 2019-01-09  Tom Tromey  <tom@tromey.com>
10471
10472         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10473         (compunit_filetabs): New.
10474         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10475         compunit_filetabs.
10476         (info_sources_command, make_source_files_completion_list): Remove
10477         declaration.
10478         * symmisc.c (print_objfile_statistics, dump_objfile)
10479         (maintenance_print_symbols): Remove declaration.
10480         (maintenance_info_symtabs): Use compunit_filetabs.
10481         (maintenance_info_line_tables): Likewise.
10482         * source.c (select_source_symtab): Change local variable name.
10483         (forget_cached_source_info_for_objfile): Remove declaration.
10484         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10485         * objfiles.c (objfile_relocate1): Remove declaration.
10486         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10487         declaration.
10488         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10489         * coffread.c (coff_symtab_read): Remove declaration.
10490         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10491         compunit_filetabs.
10492
10493 2019-01-09  Tom Tromey  <tom@tromey.com>
10494
10495         * symtab.c (lookup_objfile_from_block)
10496         (find_pc_sect_compunit_symtab, search_symbols)
10497         (default_collect_symbol_completion_matches_break_on): Use
10498         objfile_compunits.
10499         * objfiles.h (ALL_COMPUNITS): Remove.
10500         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10501         * cp-support.c (add_symbol_overload_list_qualified): Use
10502         objfile_compunits.
10503         * ada-lang.c (ada_collect_symbol_completion_matches)
10504         (ada_add_global_exceptions): Use objfile_compunits.
10505
10506 2019-01-09  Tom Tromey  <tom@tromey.com>
10507
10508         * source.c (select_source_symtab)
10509         (forget_cached_source_info_for_objfile): Remove declaration.
10510         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10511         declaration.
10512         * maint.c (count_symtabs_and_blocks): Remove declaration.
10513         * cp-support.c (add_symbol_overload_list_qualified): Remove
10514         declaration.
10515         * coffread.c (coff_symtab_read): Remove declaration.
10516         * symtab.c (lookup_symbol_in_objfile_symtabs)
10517         (basic_lookup_transparent_type_1): Use objfile_compunits.
10518         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10519         (info_sources_command, search_symbols)
10520         (default_collect_symbol_completion_matches_break_on)
10521         (make_source_files_completion_list): Remove declaration.
10522         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10523         (ada_collect_symbol_completion_matches)
10524         (ada_add_global_exceptions): Remove declaration.
10525         * linespec.c (iterate_over_all_matching_symtabs): Use
10526         objfile_compunits.
10527         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10528         (class objfile_compunits): New.
10529         (ALL_COMPUNITS): Use objfile_compunits.
10530         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10531         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10532         objfile_compunits.
10533         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10534
10535 2019-01-09  Tom Tromey  <tom@tromey.com>
10536
10537         * symtab.c (search_symbols)
10538         (default_collect_symbol_completion_matches_break_on): Use
10539         objfile_msymbols.
10540         * ada-lang.c (ada_lookup_simple_minsym)
10541         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10542         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10543         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10544         objfile_msymbols.
10545         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10546         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10547         * objc-lang.c (find_methods): Use objfile_msymbols.
10548         (info_selectors_command, info_classes_command): Likewise.
10549         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10550         * objfiles.h (class objfile_msymbols): New.
10551         (ALL_OBJFILE_MSYMBOLS): Remove.
10552         (ALL_MSYMBOLS): Remove.
10553
10554 2019-01-09  Tom Tromey  <tom@tromey.com>
10555
10556         * common/next-iterator.h (next_adapter): Add Iterator template
10557         parameter.
10558         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10559         (class all_objfiles_safe): New.
10560         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10561         * objfiles.c (put_objfile_before): Update comment.
10562         (add_separate_debug_objfile): Likewise.
10563         (free_all_objfiles): Use all_objfiles_safe.
10564         (objfile_purge_solibs): Likewise.
10565
10566 2019-01-09  Tom Tromey  <tom@tromey.com>
10567
10568         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10569         (expand_symtab_containing_pc, lookup_static_symbol)
10570         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10571         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10572         all_objfiles.
10573         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10574         * breakpoint.c (create_overlay_event_breakpoint)
10575         (create_longjmp_master_breakpoint)
10576         (create_std_terminate_master_breakpoint)
10577         (create_exception_master_breakpoint): Use all_objfiles.
10578         * linux-thread-db.c (try_thread_db_load_from_pdir)
10579         (has_libpthread): Use all_objfiles.
10580         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10581         * linespec.c (iterate_over_all_matching_symtabs)
10582         (search_minsyms_for_name): Use all_objfiles.
10583         * maint.c (maintenance_info_sections): Use all_objfiles.
10584         * main.c (captured_main_1): Use all_objfiles.
10585         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10586         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10587         * guile/scm-pretty-print.c
10588         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10589         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10590         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10591         (maintenance_print_msymbols): Use all_objfiles.
10592         * source.c (select_source_symtab): Use all_objfiles.
10593         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10594         * symfile.c (remove_symbol_file_command)
10595         (expand_symtabs_matching, map_symbol_filenames): Use
10596         all_objfiles.
10597         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10598         all_objfiles.
10599         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10600         * objc-lang.c (find_methods): Use all_objfiles.
10601         * objfiles.c (have_partial_symbols, have_full_symbols)
10602         (have_minimal_symbols, qsort_cmp)
10603         (default_iterate_over_objfiles_in_search_order): Use
10604         all_objfiles.
10605         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10606         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10607         (maintenance_check_psymtabs): Use all_objfiles.
10608         (ALL_PSYMTABS): Remove.
10609         * compile/compile-object-run.c (do_module_cleanup): Use
10610         all_objfiles.
10611         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10612         * cp-support.c (add_symbol_overload_list_qualified): Use
10613         all_objfiles.
10614         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10615         Use all_objfiles.
10616         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10617         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10618         all_objfiles.
10619         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10620         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10621         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10622         Uses all_objfiles.
10623         * solib.c (solib_read_symbols): Use all_objfiles
10624
10625 2019-01-09  Tom Tromey  <tom@tromey.com>
10626
10627         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10628         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10629         all_objfiles.
10630         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10631         * symmisc.c (print_symbol_bcache_statistics)
10632         (print_objfile_statistics, maintenance_print_objfiles)
10633         (maintenance_info_symtabs, maintenance_check_symtabs)
10634         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10635         all_objfiles.
10636         * source.c (forget_cached_source_info): Use all_objfiles.
10637         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10638         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10639         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10640         * objfiles.c (update_section_map): Use all_objfiles.
10641         (shared_objfile_contains_address_p): Likewise.
10642         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10643         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10644
10645 2019-01-09  Tom Tromey  <tom@tromey.com>
10646
10647         * common/next-iterator.h: New file.
10648         * objfiles.h (class all_objfiles): New.
10649         (struct objfile_iterator): New.
10650
10651 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10652
10653         * NEWS: Move the description of the changed "frame", "select-frame",
10654          and "info frame" commands to the Changed commands section.
10655
10656 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10657
10658         * gdbtypes.c (check_stub_method_group): Remove handling of old
10659         mangling schemes.
10660         * linespec.c (find_methods): Likewise.
10661         * stabsread.c (read_member_functions): Likewise.
10662         * valops.c (search_struct_method): Likewise.
10663         (value_struct_elt_for_reference): Likewise.
10664         * NEWS: Mention this change.
10665
10666 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10667
10668         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10669         print_source_lines.
10670         * source.c (print_source_lines_base): Update line number check.
10671         (print_source_lines): New function.
10672         (source_lines_range::source_lines_range): New function.
10673         * source.h (class source_lines_range): New class.
10674         (print_source_lines): New declaration.
10675
10676 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10677
10678         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10679
10680 2019-01-08  Tom Tromey  <tom@tromey.com>
10681             Simon Marchi  <simon.marchi@ericsson.com>
10682
10683         PR gdb/24060
10684         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10685         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10686         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10687         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10688         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10689         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10690
10691 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10692
10693         * source.c (select_source_symtab): Move header comment to
10694         declaration in source.h.
10695         (forget_cached_source_info_for_objfile): Likewise.
10696         (forget_cached_source_info): Likewise.
10697         (identify_source_line): Likewise.
10698         * source.h (identify_source_line): Move declaration from symtab.h
10699         and add comment from source.c
10700         (print_source_lines): Likewise.
10701         (forget_cached_source_info_for_objfile): Likewise.
10702         (forget_cached_source_info): Likewise.
10703         (select_source_symtab): Likewise.
10704         (enum print_source_lines_flag): Move definition from symtab.h.
10705         * symtab.h (identify_source_line): Move declaration to source.h.
10706         (print_source_lines): Likewise.
10707         (forget_cached_source_info_for_objfile): Likewise.
10708         (forget_cached_source_info): Likewise.
10709         (select_source_symtab): Likewise.
10710         (enum print_source_lines_flag): Move definition to source.h.
10711         * tui/tui-hooks.c: Add 'source.h' include.
10712
10713 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10714
10715         * source.c (print_source_lines_base): Handle requests to print
10716         reverse line number sequences, and guard against empty lines
10717         string.
10718
10719 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10720
10721         * source.c (print_source_lines_base): Fix skip of '\r' if next
10722         character is '\n'.
10723
10724 2019-01-06  Tom Tromey  <tom@tromey.com>
10725
10726         * c-exp.y (struct c_parse_state) <macro_original_text,
10727         expansion_obstack>: New member.
10728         (macro_original_text, expansion_obstack): Remove globals.
10729         (scan_macro_expansion, scanning_macro_expansion)
10730         (finished_macro_expansion): Update.
10731         (scan_macro_cleanup): Remove.
10732         (yylex, c_parse): Update.
10733
10734 2019-01-06  Tom Tromey  <tom@tromey.com>
10735
10736         * c-exp.y (struct c_parse_state) <strings>: New member.
10737         (operator_stoken): Update.
10738
10739 2019-01-06  Tom Tromey  <tom@tromey.com>
10740
10741         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10742         (union type_stack_elt) <typelist_val>: Now a pointer to
10743         std::vector.
10744         (type_stack_cleanup): Don't declare.
10745         (push_typelist): Update.
10746         * parse.c (pop_typelist): Return a std::vector.
10747         (push_typelist): Take a std::vector.
10748         (follow_types): Update.  Do not free args.
10749         (type_stack_cleanup): Remove.
10750         * c-exp.y (struct c_parse_state): New.
10751         (cpstate): New global.
10752         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10753         (nonempty_typelist): Update.
10754         (func_mod): Create a new vector.
10755         (c_parse): Create a c_parse_state.
10756         (check_parameter_typelist): Do not delete params.
10757         (function_method): Update.  Do not delete type_list.
10758
10759 2019-01-06  Tom Tromey  <tom@tromey.com>
10760
10761         PR gdb/28155:
10762         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10763         check_typedef.
10764         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10765         (print_return_value): Likewise.
10766
10767 2019-01-05  Tom Tromey  <tom@tromey.com>
10768
10769         * contrib/cleanup_check.py: Remove.
10770         * contrib/gcc-with-excheck: Remove.
10771         * contrib/exsummary.py: Remove.
10772         * contrib/excheck.py: Remove.
10773
10774 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10775
10776         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10777         NULL. Initialize tpprev to NULL instead of assigning it
10778         to NULL on the next statement.
10779         * windows-nat.c (windows_delete_thread): Remove check for
10780         main_thread_id before printing thread exit notifications.
10781         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10782         Remove thread ID check against main_thread_id.
10783         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10784         windows_delete_thread.
10785         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10786
10787 2019-01-04  Tom Tromey  <tom@tromey.com>
10788
10789         * compile/compile.c (_initialize_compile): Use upper case for
10790         metasyntactic variables.
10791         * symmisc.c (_initialize_symmisc): Use upper case for
10792         metasyntactic variables.
10793         * psymtab.c (_initialize_psymtab): Use upper case for
10794         metasyntactic variables.
10795         * demangle.c (demangle_command): Use upper case for metasyntactic
10796         variables.
10797         (_initialize_demangler): Likewise.
10798         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10799         variables.
10800
10801 2019-01-03  Tom Tromey  <tom@tromey.com>
10802
10803         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10804
10805 2019-01-03  Tom Tromey  <tom@tromey.com>
10806
10807         * python/py-symtab.c (salpy_str): Update.
10808         (struct salpy_sal_object) <symtab>: Now a PyObject.
10809         (salpy_dealloc): Update.
10810         (del_objfile_sal): Use gdbpy_ref.
10811
10812 2019-01-03  Tom Tromey  <tom@tromey.com>
10813
10814         * python/py-type.c (convert_field): Use new_reference.  Return
10815         gdbpy_ref.
10816         (make_fielditem): Return gdbpy_ref.
10817         (typy_fields): Update.
10818         (typy_getitem): Update.
10819         (field_name): Return gdbpy_ref.  Use new_reference.
10820         (typy_iterator_iternext): Update.
10821
10822 2019-01-03  Tom Tromey  <tom@tromey.com>
10823
10824         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10825
10826 2019-01-03  Tom Tromey  <tom@tromey.com>
10827
10828         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10829         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10830         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10831         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10832         (pspy_set_type_printers): Likewise.
10833         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10834         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10835         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10836         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10837         (objfpy_set_type_printers): Likewise.
10838
10839 2019-01-03  Tom Tromey  <tom@tromey.com>
10840
10841         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10842         (gdbpy_print_stack): Use gdbpy_err_fetch.
10843         * python/python-internal.h (class gdbpy_err_fetch): New class.
10844         (class gdbpy_enter) <m_error_type, m_error_value,
10845         m_error_traceback>: Remove.
10846         <m_error>: New member.
10847         (gdbpy_exception_to_string): Don't declare.
10848         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10849         * python/py-value.c (convert_value_from_python): Use
10850         gdbpy_err_fetch.
10851         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10852         gdbpy_exception_to_string.
10853         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10854         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10855         gdbpy_err_fetch.
10856
10857 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10858
10859         * linux-nat.c (delete_lwp_cleanup): Delete.
10860         (struct lwp_deleter): New struct.
10861         (lwp_info_up): New typedef.
10862         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10863         lwp_info_up.
10864
10865 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10866
10867         * linux-fork.c (class scoped_switch_fork_info): New class.
10868         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10869
10870 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10871
10872         * valops.c (find_overload_match): Remove use of null_cleanup, and
10873         calls to do_cleanups.
10874
10875 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10876
10877         * compile/compile-cplus-types.c
10878         (compile_cplus_instance::decl_name): Handle changes to
10879         cp_func_name.
10880         * cp-support.c (cp_func_name): Update header comment, update
10881         return type.
10882         * cp-support.h (cp_func_name): Update return type in declaration.
10883         * valops.c (find_overload_match): Move temp_func local to top
10884         level of function and change its type.  Use temp_func to hold and
10885         delete temporary string obtained from cp_func_name.
10886
10887 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10888
10889         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10890         gdb::char_vector, remove cleanup, and update uses of `msg`.
10891
10892 2019-01-03  Jim Wilson  <jimw@sifive.com>
10893
10894         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10895
10896 2019-01-02  Tom Tromey  <tom@tromey.com>
10897
10898         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10899         (tdesc_parse_xml): Remove cleanups.
10900         * target-descriptions.h (make_cleanup_free_target_description):
10901         Don't declare.
10902         (target_desc_deleter): New struct.
10903         (target_desc_up): New typedef.
10904         * target-descriptions.c (target_desc_deleter::operator()): Rename
10905         from free_target_description.
10906         (make_cleanup_free_target_description): Remove.
10907
10908 2019-01-02  Tom Tromey  <tom@tromey.com>
10909
10910         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10911         constructor, destructor.
10912         (linespec_parser): Remove typedef.
10913         (~linespec_parser): Rename from linespec_parser_delete.
10914         (linespec_lex_to_end, linespec_complete_label)
10915         (linespec_complete): Update.
10916         (decode_line_full): Remove cleanups.
10917         (decode_line_1): Update.
10918
10919 2019-01-02  Tom Tromey  <tom@tromey.com>
10920
10921         * python/python-internal.h (inferior_to_inferior_object): Change
10922         return type.
10923         * python/py-exitedevent.c (create_exited_event_object): Update.
10924         * python/py-inferior.c (inferior_to_inferior_object): Return
10925         gdbpy_ref.
10926         (python_new_inferior, python_inferior_deleted)
10927         (thread_to_thread_object, delete_thread_object)
10928         (build_inferior_list, gdbpy_selected_inferior): Update.
10929         * python/py-infthread.c (create_thread_object): Update.  Also fail
10930         if inferior_to_inferior_object fails.
10931
10932 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10933
10934         * inferior.h (class inferior) <displaced_step_state>: New field.
10935         * infrun.h (struct displaced_step_state): Move here from
10936         infrun.c.  Initialize fields, add constructor.
10937         <inf>: Remove field.
10938         <reset>: New method.
10939         * infrun.c (struct displaced_step_inferior_state): Move to
10940         infrun.h.
10941         (displaced_step_inferior_states): Remove.
10942         (get_displaced_stepping_state): Adust.
10943         (displaced_step_in_progress_any_inferior): Adjust.
10944         (displaced_step_in_progress_thread): Adjust.
10945         (displaced_step_in_progress): Adjust.
10946         (add_displaced_stepping_state): Remove.
10947         (get_displaced_step_closure_by_addr): Adjust.
10948         (remove_displaced_stepping_state): Remove.
10949         (infrun_inferior_exit): Call displaced_step_state.reset.
10950         (use_displaced_stepping): Don't check for NULL.
10951         (displaced_step_prepare_throw): Call
10952         get_displaced_stepping_state.
10953         (displaced_step_fixup): Don't check for NULL.
10954         (prepare_for_detach): Don't check for NULL.
10955
10956 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10957
10958         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10959          in case of call that did not complete.
10960
10961 2019-01-02  Andrey Utkin  <autkin@undo.io>
10962
10963         * symfile.c (find_separate_debug_file): Fix search of debug files for
10964         remote debuggee.
10965
10966 2019-01-02  Tom Tromey  <tom@tromey.com>
10967
10968         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10969         indentation.
10970         * python/py-frame.c (frapy_older): Remove cast.
10971         (frapy_newer): Likewise.
10972         * python/py-breakpoint.c (local_setattro): Remove cast.
10973         * python/py-arch.c (archpy_name): Remove local variable.
10974         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10975
10976 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10977
10978         * unittests/basic_string_view/element_access/char/empty.cc:
10979         Fix year range in copyright header.
10980
10981 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10982
10983         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10984         Delete.
10985         <operator==>: Update with for removed field.
10986         <hash>: Likewise.
10987         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10988         <isa_features>: ...this.
10989         <abi_features>: New field.
10990         (riscv_isa_flen): Update comment.
10991         (riscv_abi_xlen): New declaration.
10992         (riscv_abi_flen): New declaration.
10993         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10994         isa_features.
10995         (riscv_abi_xlen): New function.
10996         (riscv_isa_flen): Update to get answer from isa_features.
10997         (riscv_abi_flen): New function.
10998         (riscv_has_fp_abi): Update to get answer from abi_features.
10999         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11000         xlen and flen.
11001         (riscv_call_info) <xlen, flen>: Update comment.
11002         (riscv_call_arg_struct): Remove invalid assertions
11003         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11004         is removed.
11005         (riscv_gdbarch_init): Gather isa features and abi features
11006         separately, ensure both match on the gdbarch when reusing an old
11007         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11008         a target with 64-bit float hardware.
11009
11010 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11011
11012         * source.c (search_command_helper): Stop reverse search
11013         when line 1 has been searched.
11014
11015 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11016
11017         * record-full.c (record_full_base_target::close): Rewrite
11018         record_full_core_buf_list free logic.
11019
11020 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11021
11022         * break-catch-syscall.c (print_one_catch_syscall): xfree
11023         the last text.
11024
11025 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11026
11027         * top.c (print_gdb_version): Update Copyright year in version
11028         message.
11029
11030 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11031
11032         Update copyright year range in all GDB files.
11033
11034 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11035
11036         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11037
11038 For older changes see ChangeLog-2018.
11039 \f
11040 Local Variables:
11041 mode: change-log
11042 left-margin: 8
11043 fill-column: 74
11044 version-control: never
11045 coding: utf-8
11046 End:
11047