gdb/ChangeLog

   1 2019-04-04  Tom Tromey  <tom@tromey.com>
   2
   3         * rust-exp.y (rustyylex, rust_lex_tests): Update.
   4         * parser-defs.h (struct parser_state) <parser_state>: Add new
   5         parameter.
   6         <comma_terminates>: New member.
   7         (comma_terminates): Don't declare global.
   8         * parse.c (comma_terminates): Remove global.
   9         (parse_exp_in_context): Update.
  10         * p-exp.y (yylex): Update.
  11         * m2-exp.y (yylex): Update.
  12         * go-exp.y (lex_one_token): Update.
  13         * f-exp.y (yylex): Update.
  14         * d-exp.y (lex_one_token): Update.
  15         * c-exp.y (lex_one_token): Update.
  16         * ada-lex.l: Update.
  17
  18 2019-04-04  Tom Tromey  <tom@tromey.com>
  19
  20         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
  21         (rustyylex, rust_lex_test_init, rust_lex_test_one)
  22         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
  23         * parser-defs.h (paren_depth): Don't declare.
  24         * parse.c (paren_depth): Remove global.
  25         (parse_exp_in_context): Update.
  26         * p-exp.y (paren_depth): New global.
  27         (pascal_parse): Initialize it.
  28         * m2-exp.y (paren_depth): New global.
  29         (m2_parse): Initialize it.
  30         * go-exp.y (paren_depth): New global.
  31         (go_parse): Initialize it.
  32         * f-exp.y (paren_depth): New global.
  33         (f_parse): Initialize it.
  34         * d-exp.y (paren_depth): New global.
  35         (d_parse): Initialize it.
  36         * c-exp.y (paren_depth): New global.
  37         (c_parse): Initialize it.
  38         * ada-lex.l (paren_depth): New global.
  39         (lexer_init): Initialize it.
  40
  41 2019-04-04  Tom Tromey  <tom@tromey.com>
  42
  43         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
  44         (rust_parser::convert_ast_to_type)
  45         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
  46         * parser-defs.h (struct parser_state) <parser_state>: Add
  47         parameters.  Initialize new members.
  48         <expression_context_block, expression_context_pc>: New members.
  49         * parse.c (expression_context_block, expression_context_pc):
  50         Remove globals.
  51         (parse_exp_in_context): Update.
  52         * p-exp.y: Update all rules.
  53         (yylex): Update.
  54         * m2-exp.y: Update all rules.
  55         (yylex): Update.
  56         * go-exp.y (yylex): Update.
  57         * f-exp.y (yylex): Update.
  58         * d-exp.y: Update all rules.
  59         (yylex): Update.
  60         * c-exp.y: Update all rules.
  61         (lex_one_token, classify_name, yylex, c_parse): Update.
  62         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
  63
  64 2019-04-04  Tom Tromey  <tom@tromey.com>
  65
  66         * gdbarch.h, gdbarch.c: Rebuild.
  67         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
  68         * stap-probe.h:
  69         (struct stap_parse_info): Replace "parser_state" with
  70         "expr_builder".
  71         * parser-defs.h (struct expr_builder): Rename from "parser_state".
  72         (parser_state): New class.
  73         * parse.c (expr_builder): Rename.
  74         (expr_builder::release): Rename.
  75         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
  76         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
  77         (write_exp_elt_longcst, write_exp_elt_floatcst)
  78         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
  79         (write_exp_string_vector, write_exp_bitstring)
  80         (write_exp_msymbol, mark_struct_expression)
  81         (write_dollar_variable)
  82         (insert_type_address_space, increase_expout_size): Replace
  83         "parser_state" with "expr_builder".
  84         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
  85         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
  86         "parser_state" with "expr_builder".
  87
  88 2019-04-04  Tom Tromey  <tom@tromey.com>
  89
  90         * rust-exp.y: Replace "parse_language" with method call.
  91         * p-exp.y:
  92         (yylex): Replace "parse_language" with method call.
  93         * m2-exp.y:
  94         (yylex): Replace "parse_language" with method call.
  95         * go-exp.y (classify_name): Replace "parse_language" with method
  96         call.
  97         * f-exp.y (yylex): Replace "parse_language" with method call.
  98         * d-exp.y (lex_one_token): Replace "parse_language" with method
  99         call.
 100         * c-exp.y:
 101         (lex_one_token, classify_name, yylex): Replace "parse_language"
 102         with method call.
 103         * ada-exp.y (find_primitive_type, type_char)
 104         (type_system_address): Replace "parse_language" with method call.
 105
 106 2019-04-04  Tom Tromey  <tom@tromey.com>
 107
 108         * rust-exp.y: Replace "parse_gdbarch" with method call.
 109         * parse.c (write_dollar_variable, insert_type_address_space):
 110         Replace "parse_gdbarch" with method call.
 111         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
 112         call.
 113         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
 114         call.
 115         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
 116         "parse_gdbarch" with method call.
 117         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
 118         with method call.
 119         * f-exp.y (parse_type, parse_f_type, yylex): Replace
 120         "parse_gdbarch" with method call.
 121         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
 122         "parse_gdbarch" with method call.
 123         * c-exp.y (parse_type, parse_number, classify_name): Replace
 124         "parse_gdbarch" with method call.
 125         * ada-lex.l: Replace "parse_gdbarch" with method call.
 126         * ada-exp.y (parse_type, find_primitive_type, type_char)
 127         (type_system_address): Replace "parse_gdbarch" with method call.
 128
 129 2019-04-04  Tom Tromey  <tom@tromey.com>
 130
 131         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
 132         * stap-probe.c (stap_parse_argument): Update.
 133         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
 134         initial_size parameter.
 135         * rust-exp.y (rust_lex_tests): Update.
 136         * parse.c (parser_state): Update.
 137         (parse_exp_in_context): Update.
 138         * parser-defs.h (struct parser_state) <parser_state>: Remove
 139         "initial_size" parameter.
 140
 141 2019-04-04  Tom Tromey  <tom@tromey.com>
 142
 143         * parser-defs.h (increase_expout_size): Don't declare.
 144         * parse.c (increase_expout_size): Now static.
 145
 146 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
 147
 148         * gnu-nat.c (gnu_nat_target::wait): Fix
 149         target_waitstatus_to_string call.
 150
 151 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 152
 153         * eval.c (evaluate_subexp_standard): Handle internal functions
 154         during Fortran function call handling.
 155
 156 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 157
 158         * NEWS: Mention new internal functions.
 159         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
 160         (read_base_type): Use dwarf2_init_complex_target_type.
 161         * value.c (creal_internal_fn): New function.
 162         (cimag_internal_fn): New function.
 163         (_initialize_values): Register new internal functions.
 164
 165 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 166
 167         * infrun.c (stop_all_threads): If debug_infrun, always
 168         trace the wait status after wait_one, using
 169         target_waitstatus_to_string and target_pid_to_str.
 170         (handle_inferior_event): Replace various trace of
 171         wait status kind by a single trace.
 172         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
 173         wait status kind image by target_waitstatus_to_string.
 174         * target/waitstatus.c (target_waitstatus_to_string): Fix
 175         obsolete comment.
 176
 177 2019-04-01  Tom Tromey  <tromey@adacore.com>
 178
 179         PR symtab/23331:
 180         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
 181
 182 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
 183             Pedro Alves  <palves@redhat.com>
 184
 185         * top.c (quit_force): Call 'finalize_values'.
 186         * value.c (finalize_values): New function.
 187         * value.h (finalize_values): Declare.
 188
 189 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
 190
 191         * NEWS: Announce $_gdb_major and $_gdb_minor.
 192
 193         * top.c (init_gdb_version_vars): New function.
 194         (gdb_init): Call init_gdb_version_vars.
 195
 196 2019-03-29  Tom Tromey  <tromey@adacore.com>
 197
 198         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
 199         help text.  Remove dead code.
 200
 201 2019-03-29  Keith Seitz  <keiths@redhat.com>
 202
 203         From Siddhesh Poyarekar:
 204         * f-lang.h (f77_get_upperbound): Return LONGEST.
 205         (f77_get_lowerbound): Likewise.
 206         * f-typeprint.c (f_type_print_varspec_suffix): Expand
 207         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
 208         print them.
 209         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
 210         plongest to format print it.
 211         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
 212         (f77_get_upperbound): Likewise.
 213         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
 214         LOWER_BOUND to LONGEST.
 215         (f77_create_arrayprint_offset_tbl): Likewise.
 216
 217 2019-03-29  Keith Seitz  <keiths@redhat.com>
 218
 219         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
 220         %s/pulongest for TYPE_LENGTH instead of %d in format
 221         strings.
 222         * ada-typerint.c (ada_print_type): Likewise.
 223         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
 224         * compile/compile-c-support.c (generate_register_struct): Likewise.
 225         * gdbtypes.c (recursive_dump_type): Likewise.
 226         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
 227         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
 228         instead of %d in format strings.
 229         * riscv-tdep.c (riscv_type_alignment): Cast second argument
 230         to std::min to ULONGEST.
 231         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
 232         instead of %d in format strings.
 233         * tracepoint.c (info_scope_command): Likewise.
 234         * typeprint.c (print_offset_data::update)
 235         (print_offset_data::finish): Likewise.
 236         * xtensa-tdep.c (xtensa_store_return_value)
 237         (xtensa_push_dummy_call): Likewise.
 238
 239 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
 240
 241         * windows-nat.c (display_selector): Fixed format specifications
 242         for 64-bit Cygwin.
 243
 244 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 245
 246         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
 247
 248 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
 249
 250         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
 251         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
 252         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
 253         (nios2_linux_init_abi): Install it.
 254
 255 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
 256
 257         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
 258
 259 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
 260
 261         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
 262
 263 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 264             Tom Tromey  <tromey@adacore.com>
 265
 266         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
 267
 268 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
 269
 270         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
 271         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
 272         method to compute the bounds of range types. Also print "[evaluated]"
 273         if the bounds' values come from a dynamic evaluation.
 274
 275 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 276
 277         * cp-valprint.c (cp_print_value_fields): Don't print trailing
 278         whitespace when pretty printing is on.
 279
 280 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 281
 282         * ppc-linux-nat.c: Add include.
 283
 284 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 285
 286         * NEWS: Mention AArch64 Pointer Authentication.
 287
 288 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 289
 290         * arm-linux-nat.c: Add include.
 291
 292 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
 293
 294         * source-cache.c (source_cache::get_source_lines): Re-read
 295         fullname after calling open_source_file.
 296
 297 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
 298
 299         * NEWS: Mention TLS support for FreeBSD.
 300
 301 2019-03-25  Tom Tromey  <tromey@adacore.com>
 302
 303         * minsyms.c (BUNCH_SIZE): Update comment.
 304         (~minimal_symbol_reader): Remove old comment.
 305         (compact_minimal_symbols): Update comment.
 306         (minimal_symbol_reader::install): Remove old comment.  Update
 307         other comments.
 308
 309 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
 310
 311         * s390-linux-nat.c: Add include.
 312
 313 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
 314
 315         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 316         Call linux_get_hwcap.
 317         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
 318         Likewise.
 319         (aarch64_linux_get_hwcap): Remove function.
 320         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
 321         declaration.
 322         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
 323         linux_get_hwcap.
 324         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 325         * linux-tdep.c (linux_get_hwcap): Add function.
 326         (linux_get_hwcap2): Likewise.
 327         * linux-tdep.h (linux_get_hwcap): Add declaration.
 328         (linux_get_hwcap2): Likewise.
 329         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
 330         (ppc_linux_get_hwcap2): Likewise.
 331         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
 332         linux_get_hwcap.
 333         (ppc_linux_nat_target::insert_watchpoint): Likewise.
 334         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
 335         (ppc_linux_nat_target::read_description): Likewise.
 336         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
 337         * s390-linux-nat.c: Likewise.
 338         * s390-linux-tdep.c (s390_core_read_description): Likewise.
 339
 340 2019-03-24  Tom Tromey  <tom@tromey.com>
 341
 342         * ada-lang.c (standard_lookup): Simplify initialization.
 343         (ada_lookup_symbol_nonlocal): Simplify return.
 344         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
 345         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
 346         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
 347         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
 348         initialization.
 349         * solib.c (solib_global_lookup): Simplify.
 350         * symtab.c (null_block_symbol): Remove.
 351         (symbol_cache_lookup): Simplify returns.
 352         (lookup_language_this): Simplify returns.
 353         (lookup_symbol_aux): Simplify return.
 354         (lookup_local_symbol): Simplify returns.
 355         (lookup_global_symbol_from_objfile): Simplify return.
 356         (lookup_symbol_in_objfile_symtabs)
 357         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
 358         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
 359         (lookup_static_symbol, lookup_global_symbol): Simplify return.
 360         * cp-namespace.c (cp_lookup_bare_symbol)
 361         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
 362         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
 363         (cp_lookup_nested_symbol): Don't use null_block_symbol.
 364         (cp_lookup_symbol_via_imports): Simplify initialization.
 365         (find_symbol_in_baseclass): Likewise.
 366         * symtab.h (null_block_symbol): Remove.
 367         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
 368         (d_lookup_nested_symbol, d_lookup_symbol_imports)
 369         (d_lookup_symbol_module): Likewise.
 370         (find_symbol_in_baseclass): Simplify initialization.
 371
 372 2019-03-24  Tom Tromey  <tom@tromey.com>
 373
 374         * expression.h: Don't include symtab.h.
 375         (struct block): Forward declare.
 376
 377 2019-03-24  Tom Tromey  <tom@tromey.com>
 378
 379         * c-exp.y (typebase): Remove casts.
 380         * gdbtypes.c (lookup_unsigned_typename, )
 381         (lookup_signed_typename): Remove cast.
 382         * eval.c (parse_to_comma_and_eval): Remove cast.
 383         * parse.c (write_dollar_variable): Remove cast.
 384         * block.h (struct block) <superblock>: Now const.
 385         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
 386         * psymtab.c (psym_map_matching_symbols): Make "block" const.
 387         (map_block): Make "block" const.
 388         * symfile.h (struct quick_symbol_functions)
 389         <map_matching_symbols>: Constify block argument to "callback".
 390         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
 391         const.
 392         (find_pc_sect_compunit_symtab): Make "b" const.
 393         (find_symbol_at_address): Likewise.
 394         (search_symbols): Likewise.
 395         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
 396         (dw2_debug_names_lookup_symbol): Likewise.
 397         (dw2_map_matching_symbols): Update.
 398         * p-valprint.c (pascal_val_print): Remove "block".
 399         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
 400         (aux_add_nonlocal_symbols): Make "block" const.
 401         (resolve_subexp): Remove cast.
 402         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
 403         const.
 404         (iterate_over_file_blocks): Likewise.
 405         * f-exp.y (%union) <bval>: Remove.
 406         * coffread.c (patch_opaque_types): Make "b" const.
 407         * spu-tdep.c (spu_catch_start): Make "block" const.
 408         * c-valprint.c (print_unpacked_pointer): Remove "block".
 409         * symmisc.c (dump_symtab_1): Make "b" const.
 410         (block_depth): Make "block" const.
 411         * d-exp.y (%union) <bval>: Remove.
 412         * cp-support.h (cp_lookup_rtti_type): Update.
 413         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
 414         * psymtab.c (psym_lookup_symbol): Make "block" const.
 415         (maintenance_check_psymtabs): Make "b" const.
 416         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
 417         (enumerate_locals, enumerate_args): Update.
 418         * python/py-symtab.c (stpy_global_block): Make "block" const.
 419         (stpy_static_block): Likewise.
 420         * inline-frame.c (block_starting_point_at): Make "new_block"
 421         const.
 422         * block.c (find_block_in_blockvector): Make return type const.
 423         (blockvector_for_pc_sect): Make "b" const.
 424         (find_block_in_blockvector): Make "b" const.
 425
 426 2019-03-23  Tom Tromey  <tom@tromey.com>
 427
 428         * varobj.c (varobj_create): Update.
 429         * symfile.c (clear_symtab_users): Don't reset innermost_block.
 430         * printcmd.c (display_command, do_one_display): Don't reset
 431         innermost_block.
 432         * parser-defs.h (enum innermost_block_tracker_type): Move to
 433         expression.h.
 434         (innermost_block): Update comment.
 435         * parse.c (parse_exp_1): Add tracker_types parameter.
 436         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
 437         tracker_types parameter.  Reset innermost_block.
 438         (parse_exp_in_context): Remove.
 439         (parse_expression_for_completion): Update.
 440         * objfiles.c (~objfile): Don't reset expression_context_block or
 441         innermost_block.
 442         * expression.h (enum innermost_block_tracker_type): Move from
 443         parser-defs.h.
 444         (parse_exp_1): Add tracker_types parameter.
 445         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
 446         reset innermost_block.
 447
 448 2019-03-23  Tom Tromey  <tom@tromey.com>
 449
 450         * objfiles.h: Include bcache.h.
 451
 452 2019-03-23  Tom Tromey  <tom@tromey.com>
 453
 454         * linespec.c (get_current_search_block): Use
 455         scoped_restore_current_language.
 456         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
 457
 458 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 459             Jiong Wang  <jiong.wang@arm.com>
 460
 461         * aarch64-linux-tdep.c
 462         (aarch64_linux_iterate_over_regset_sections): Check for pauth
 463         section.
 464         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
 465
 466 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 467             Jiong Wang  <jiong.wang@arm.com>
 468
 469         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
 470         instructions.
 471         (aarch64_analyze_prologue_test): Add PACIASP test.
 472         (aarch64_prologue_prev_register): Unmask PC value.
 473
 474 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 475             Jiong Wang  <jiong.wang@arm.com>
 476
 477         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
 478         (aarch64_dwarf2_prev_register): Unmask PC value.
 479         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
 480         (aarch64_execute_dwarf_cfa_vendor_op): Check for
 481         DW_CFA_AARCH64_negate_ra_state.
 482         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
 483
 484 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 485             Jiong Wang  <jiong.wang@arm.com>
 486
 487         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
 488         registers.
 489         (aarch64_pseudo_register_name): Likewise.
 490         (aarch64_pseudo_register_type): Likewise.
 491         (aarch64_pseudo_register_reggroup_p): Likewise.
 492         (aarch64_gdbarch_init): Add pauth registers.
 493         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
 494         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
 495         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
 496         (struct gdbarch_tdep): Add regnum for ra_state.
 497
 498 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 499             Jiong Wang  <jiong.wang@arm.com>
 500
 501         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
 502
 503 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 504             Jiong Wang  <jiong.wang@arm.com>
 505
 506         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
 507         function.
 508         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
 509         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
 510         (aarch64_gdbarch_init): Add puth registers.
 511         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
 512         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
 513         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
 514
 515 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 516             Jiong Wang  <jiong.wang@arm.com>
 517
 518         * aarch64-linux-nat.c
 519         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
 520         * aarch64-linux-tdep.c
 521         (aarch64_linux_core_read_description): Likewise.
 522         (aarch64_linux_get_hwcap): New function.
 523         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
 524         (aarch64_linux_get_hwcap): New declaration.
 525
 526 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 527             Jiong Wang  <jiong.wang@arm.com>
 528
 529         * aarch64-linux-nat.c
 530         (aarch64_linux_nat_target::read_description): Add pauth param.
 531         * aarch64-linux-tdep.c
 532         (aarch64_linux_core_read_description): Likewise.
 533         * aarch64-tdep.c (struct target_desc): Add in pauth.
 534         (aarch64_read_description): Add pauth param.
 535         (aarch64_gdbarch_init): Likewise.
 536         * aarch64-tdep.h (aarch64_read_description): Likewise.
 537         * arch/aarch64.c (aarch64_create_target_description): Likewise.
 538         * arch/aarch64.h (aarch64_create_target_description): Likewise.
 539         * features/Makefile: Add new files.
 540         * features/aarch64-pauth.c: New file.
 541         * features/aarch64-pauth.xml: New file.
 542
 543 2019-03-20  Tom Tromey  <tromey@adacore.com>
 544
 545         * infrun.c (handle_inferior_event): Rename from
 546         handle_inferior_event_1.  Create a scoped_value_mark.
 547         (handle_inferior_event): Remove.
 548
 549 2019-03-19  Tom Tromey  <tromey@adacore.com>
 550
 551         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
 552         * infrun.h (print_stop_event): Add "displays" parameter.
 553         * infrun.c (print_stop_event): Add "displays" parameter.
 554
 555 2019-03-19  Pedro Alves  <palves@redhat.com>
 556
 557         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
 558         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
 559         to -1.  Fix TABs vs spaces.
 560         (tui_ui_out::tui_ui_out): Don't initialize fields here.
 561         * tui/tui-out.h (tui_ui_out) Add intro comments.
 562         <m_line, m_start_of_line>: In-class initialize, and add describing
 563         comment.
 564
 565 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
 566
 567         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
 568         variable names.
 569         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
 570
 571 2019-03-18  Pedro Alves  <palves@redhat.com>
 572             Eli Zaretskii <eliz@gnu.org>
 573
 574         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
 575         m_line and m_start_of_line.
 576
 577 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
 578
 579         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
 580         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
 581         it returns a newline.  This fixes a regression in TU mode, whereby
 582         the next line is output on the same screen line as the user input.
 583
 584 2019-03-18  Tom Tromey  <tromey@adacore.com>
 585
 586         * minsyms.c (minimal_symbol_reader::install): Remove call to
 587         obstack_blank.
 588
 589 2019-03-18  Pedro Alves  <palves@redhat.com>
 590
 591         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
 592         New globals.
 593         (apply_style): New, factored out from ...
 594         (apply_ansi_escape): ... this.  Handle reverse video mode.
 595         (tui_set_reverse_mode): New function.
 596         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
 597         * tui/tui-winsource.c (tui_show_source_line): Use
 598         tui_set_reverse_mode instead of setting A_STANDOUT.
 599         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
 600         New setter methods.
 601
 602 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
 603
 604         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
 605         Handle tabs.
 606
 607 2019-03-18  Tom Tromey  <tromey@adacore.com>
 608
 609         * ada-lang.c (empty_array): Add "high" parameter.
 610         (ada_evaluate_subexp): Update.
 611
 612 2019-03-17  Sergei Trofimovich <siarheit@google.com>
 613
 614         * unittests/string_view-selftests.c: Define
 615         _initialize_string_view_selftests unconditionally.
 616
 617 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 618
 619         PR gdb/24350
 620         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
 621
 622 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 623
 624         PR gdb/24351
 625         * windows-nat.c (display_selector): Fix format specifiers.
 626
 627 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
 628
 629         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
 630         tui_refill_source_window instead of tui_refresh_win, to update the
 631         current execution line.  This fixes redisplay of the current line
 632         when stepping through the code with "next" or "step".
 633
 634 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 635
 636         * source-cache.c (source_cache::get_source_lines): Call
 637         find_source_lines to initialize s->nlines.  This fixes vertical
 638         scrolling of TUI source window when the DOWN arrow is pressed.
 639
 640 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 641
 642         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
 643         linux-thread-db.c (_initialize_thread_db): Likewise.
 644
 645 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 646
 647         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
 648         wclrtoeol in tui_show_source_line".  This reverts changes made in
 649         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
 650
 651 2019-03-15  Tom Tromey  <tom@tromey.com>
 652
 653         * symtab.h (struct minimal_symbol): Derive from
 654         general_symbol_info.
 655         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
 656         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
 657         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
 658         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
 659         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
 660         (MSYMBOL_SEARCH_NAME): Update.
 661         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
 662         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
 663         * minsyms.c (minimal_symbol_reader::record_full): Update.
 664
 665 2019-03-15  Tom Tromey  <tom@tromey.com>
 666
 667         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
 668
 669 2019-03-15  Tom Tromey  <tom@tromey.com>
 670
 671         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
 672         unique_xmalloc_ptr.
 673         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
 674         Update.
 675         * minsyms.c (lookup_minimal_symbol_by_pc_section)
 676         (build_minimal_symbol_hash_tables)
 677         (minimal_symbol_reader::install): Update.
 678
 679 2019-03-15  Tom Tromey  <tom@tromey.com>
 680
 681         * symtab.c (create_demangled_names_hash): Update.
 682         (symbol_set_names): Update.
 683         * objfiles.h (struct objfile_per_bfd_storage)
 684         <demangled_names_hash>: Now an htab_up.
 685         * objfiles.c (objfile_per_bfd_storage): Simplify.
 686
 687 2019-03-15  Tom Tromey  <tom@tromey.com>
 688
 689         * objfiles.h (struct objfile_per_bfd_storage): Declare
 690         destructor.
 691         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
 692         New.
 693         (get_objfile_bfd_data): Use new.  Don't initialize
 694         language_of_main.
 695         (free_objfile_per_bfd_storage): Remove.
 696         (objfile_bfd_data_free, objfile::~objfile): Use delete.
 697
 698 2019-03-15  Tom Tromey  <tom@tromey.com>
 699
 700         * symfile.c (reread_symbols): Update.
 701         * objfiles.c (objfile::objfile): Update.
 702         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
 703         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
 704         comment.
 705         (minimal_symbol_reader::install): Update.
 706         (terminate_minimal_symbol_table): Remove.
 707         * jit.c (jit_object_close_impl): Update.
 708
 709 2019-03-15  Tom Tromey  <tom@tromey.com>
 710
 711         * minsyms.c (minimal_symbol_reader::record_full): Remove some
 712         initializations.
 713
 714 2019-03-15  Tom Tromey  <tom@tromey.com>
 715
 716         * objfiles.h (struct objfile_per_bfd_storage)
 717         <demangled_hash_languages>: Now a bitset.
 718         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 719         (lookup_minimal_symbol): Update.
 720
 721 2019-03-15  Tom Tromey  <tom@tromey.com>
 722
 723         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
 724         Don't return the symbol.
 725         * coffread.c (record_minimal_symbol): Use record_full.
 726
 727 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 728
 729         The MS-Windows port of ncurses fails to switch to a color pair if
 730         one or both of the colors are the implicit default colors.  This
 731         change records the default colors when TUI is initialized, and
 732         then specifies them explicitly when a color pair uses the default
 733         colors.  This allows color styling in TUI mode on MS-Windows.
 734
 735         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 736         ncurses_norm_attr.
 737         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 738         colors in ncurses_norm_attr.
 739         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 740         "none", replace it with the default color recorded in
 741         ncurses_norm_attr.
 742
 743 2019-03-14  Tom Tromey  <tromey@adacore.com>
 744
 745         * source-cache.h (class source_cache) <get_source_lines>: Return
 746         std::string.
 747         * source-cache.c (source_cache::extract_lines): Handle case where
 748         first_pos==npos.  Return std::string.
 749         (source_cache::get_source_lines): Update.
 750
 751 2019-03-14  Tom Tromey  <tromey@adacore.com>
 752
 753         * NEWS: Add item for "style sources" commands.
 754         * source-cache.c (source_cache::get_source_lines): Check
 755         source_styling.
 756         * cli/cli-style.c (source_styling): New global.
 757         (_initialize_cli_style): Add "style sources" commands.
 758         (show_style_sources): New function.
 759         * cli/cli-style.h (source_styling): Declare.
 760
 761 2019-03-14  Pedro Alves  <palves@redhat.com>
 762             Tom Tromey  <tromey@adacore.com>
 763
 764         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 765         * tui/tui-winsource.c (tui_refill_source_window): New function,
 766         from...
 767         (tui_horizontal_source_scroll): ... here.  Move some logic.
 768         * cli/cli-style.c (set_style_enabled): Notify new observable.
 769         * tui/tui-hooks.c (tui_redisplay_source): New function.
 770         (tui_attach_detach_observers): Attach or detach
 771         tui_redisplay_source.
 772         * observable.h (source_styling_changed): New observable.
 773         * observable.c: Define source_styling_changed observable.
 774
 775 2019-03-13  Tom Tromey  <tromey@adacore.com>
 776
 777         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
 778         (i386_gnu_nat_target::store_registers): Update.
 779         * target-debug.h (target_debug_print_std_string): New macro.
 780         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 781         * windows-tdep.c (display_one_tib): Update.
 782         * tui/tui-stack.c (tui_make_status_line): Update.
 783         * top.c (print_inferior_quit_action): Update.
 784         * thread.c (thr_try_catch_cmd): Update.
 785         (add_thread_with_info): Update.
 786         (thread_target_id_str): Update.
 787         (thr_try_catch_cmd): Update.
 788         (thread_command): Update.
 789         (thread_find_command): Update.
 790         * record-btrace.c (record_btrace_target::info_record)
 791         (record_btrace_resume_thread, record_btrace_target::resume)
 792         (record_btrace_cancel_resume, record_btrace_step_thread)
 793         (record_btrace_target::wait, record_btrace_target::wait)
 794         (record_btrace_target::wait, record_btrace_target::stop): Update.
 795         * progspace.c (print_program_space): Update.
 796         * process-stratum-target.c
 797         (process_stratum_target::thread_address_space): Update.
 798         * linux-fork.c (linux_fork_mourn_inferior)
 799         (detach_checkpoint_command, info_checkpoints_command)
 800         (linux_fork_context): Update.
 801         (linux_fork_detach): Update.
 802         (class scoped_switch_fork_info): Update.
 803         (delete_checkpoint_command): Update.
 804         * infrun.c (follow_fork_inferior): Update.
 805         (follow_fork_inferior): Update.
 806         (proceed_after_vfork_done): Update.
 807         (handle_vfork_child_exec_or_exit): Update.
 808         (follow_exec): Update.
 809         (displaced_step_prepare_throw): Update.
 810         (displaced_step_restore): Update.
 811         (start_step_over): Update.
 812         (resume_1): Update.
 813         (clear_proceed_status_thread): Update.
 814         (proceed): Update.
 815         (print_target_wait_results): Update.
 816         (do_target_wait): Update.
 817         (context_switch): Update.
 818         (stop_all_threads): Update.
 819         (restart_threads): Update.
 820         (finish_step_over): Update.
 821         (handle_signal_stop): Update.
 822         (switch_back_to_stepped_thread): Update.
 823         (keep_going_pass_signal): Update.
 824         (print_exited_reason): Update.
 825         (normal_stop): Update.
 826         * inferior.c (inferior_pid_to_str): Change return type.
 827         (print_selected_inferior): Update.
 828         (add_inferior): Update.
 829         (detach_inferior): Update.
 830         * dummy-frame.c (fprint_dummy_frames): Update.
 831         * dcache.c (dcache_info_1): Update.
 832         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 833         (btrace_fetch, btrace_clear): Update.
 834         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 835         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 836         type.
 837         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 838         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 839         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 840         * gdbarch.c, gdbarch.h: Rebuild.
 841         * gdbarch.sh (core_pid_to_str): Change return type.
 842         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 843         return type.
 844         (windows_nat_target::pid_to_str): Change return type.
 845         (windows_delete_thread): Update.
 846         (windows_nat_target::attach): Update.
 847         (windows_nat_target::files_info): Update.
 848         * target-delegates.c: Rebuild.
 849         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 850         return type.
 851         (sol_thread_target::pid_to_str): Change return type.
 852         * remote.c (class remote_target) <pid_to_str>: Change return
 853         type.
 854         (remote_target::pid_to_str): Change return type.
 855         (extended_remote_target::attach, remote_target::remote_stop_ns)
 856         (remote_target::remote_notif_remove_queued_reply)
 857         (remote_target::push_stop_reply, remote_target::disable_btrace):
 858         Update.
 859         (extended_remote_target::attach): Update.
 860         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 861         type.
 862         (gdbsim_target::pid_to_str): Change return type.
 863         * ravenscar-thread.c (struct ravenscar_thread_target)
 864         <pid_to_str>: Change return type.
 865         (ravenscar_thread_target::pid_to_str): Change return type.
 866         * procfs.c (class procfs_target) <pid_to_str>: Change return
 867         type.
 868         (procfs_target::pid_to_str): Change return type.
 869         (procfs_target::attach): Update.
 870         (procfs_target::detach): Update.
 871         (procfs_target::fetch_registers): Update.
 872         (procfs_target::store_registers): Update.
 873         (procfs_target::wait): Update.
 874         (procfs_target::files_info): Update.
 875         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 876         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 877         return type.
 878         (nto_procfs_target::pid_to_str): Change return type.
 879         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 880         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 881         return type.
 882         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 883         (exit_lwp): Update.
 884         (attach_proc_task_lwp_callback, get_detach_signal)
 885         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 886         (linux_nat_target::resume, wait_lwp, stop_callback)
 887         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 888         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 889         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 890         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 891         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 892         type.
 893         (inf_ptrace_target::attach): Update.
 894         (inf_ptrace_target::files_info): Update.
 895         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 896         type.
 897         (go32_nat_target::pid_to_str): Change return type.
 898         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 899         (gnu_nat_target::wait): Update.
 900         (gnu_nat_target::wait): Update.
 901         (gnu_nat_target::resume): Update.
 902         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 903         (fbsd_nat_target::wait): Update.
 904         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 905         type.
 906         (darwin_nat_target::attach): Update.
 907         * corelow.c (class core_target) <pid_to_str>: Change return type.
 908         (core_target::pid_to_str): Change return type.
 909         * target.c (normal_pid_to_str): Change return type.
 910         (default_pid_to_str): Likewise.
 911         (target_pid_to_str): Change return type.
 912         (target_translate_tls_address): Update.
 913         (target_announce_detach): Update.
 914         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 915         return type.
 916         (bsd_uthread_target::pid_to_str): Change return type.
 917         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 918         type.
 919         (bsd_kvm_target::pid_to_str): Change return type.
 920         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 921         return type.
 922         (aix_thread_target::pid_to_str): Change return type.
 923         * target.h (struct target_ops) <pid_to_str>: Change return type.
 924         (target_pid_to_str, normal_pid_to_str): Likewise.
 925         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 926         type.
 927         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 928         type.
 929         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 930         return type.
 931         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 932         type.
 933         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 934         type.
 935         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 936         return type.
 937
 938 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 939
 940         * NEWS: Mention that the new default MI version is 3.  Mention
 941         changes to the output of commands and events that deal with
 942         multi-location breakpoints.
 943         * breakpoint.c: Include "mi/mi-out.h".
 944         (print_one_breakpoint): Change output syntax if using MI version
 945         >= 3.
 946         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 947         New.
 948         (mi_multi_location_breakpoint_output_fixed): New.
 949         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 950         (mi_cmd_fix_multi_location_breakpoint_output): New.
 951         (mi_multi_location_breakpoint_output_fixed): New.
 952         * mi/mi-cmds.c (mi_cmds): Register command
 953         -fix-multi-location-breakpoint-output.
 954         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 955         interpreter "mi".
 956
 957 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 958
 959         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 960         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 961         instantiate mi_ui_out based on interpreter name.
 962         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 963         * mi/mi-main.c (mi_load_progress): Likewise.
 964
 965 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 966
 967         * NEWS: Combine separate "New targets" sections for 8.3.
 968
 969 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 970
 971         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 972         (ppcfbsd_init_abi): Install gdbarch
 973         "fetch_tls_load_module_address" and "get_thread_local_address"
 974         methods.
 975
 976 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 977
 978         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 979         (riscv_fbsd_init_abi): Install gdbarch
 980         "fetch_tls_load_module_address" and "get_thread_local_address"
 981         methods.
 982
 983 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 984
 985         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 986         (i386fbsd_init_abi): Install gdbarch
 987         "fetch_tls_load_module_address" and "get_thread_local_address"
 988         methods.
 989
 990 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 991
 992         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 993         (amd64fbsd_init_abi): Install gdbarch
 994         "fetch_tls_load_module_address" and "get_thread_local_address"
 995         methods.
 996
 997 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 998
 999         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
1000         (struct fbsd_pspace_data): New type.
1001         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
1002         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
1003         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
1004         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
1005         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
1006
1007 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1008
1009         * gdbtypes.c (lookup_struct_elt): New function.
1010         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
1011         * gdbtypes.h (struct struct_elt): New type.
1012         (lookup_struct_elt): New prototype.
1013
1014 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1015
1016         * gdbtypes.c (lookup_struct_elt_type): Update comment and
1017         remove disabled code block.
1018
1019 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1020
1021         * gdbarch.sh (get_thread_local_address): New method.
1022         * gdbarch.h, gdbarch.c: Regenerate.
1023         * target.c (target_translate_tls_address): Use
1024         gdbarch_get_thread_local_address if present instead of
1025         target::get_thread_local_address.
1026
1027 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1028
1029         * target.h (target::get_thread_local_address): Update comment.
1030
1031 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1032
1033         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
1034         objfile->separate_debug_objfile_backlink if not NULL.
1035
1036 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1037
1038         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
1039         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
1040         (amd64bsd_store_inferior_registers): Likewise.
1041         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
1042         Enable segment base registers.
1043         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
1044         PT_GETFSBASE and PT_GETGSBASE.
1045         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
1046         PT_SETGSBASE.
1047         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
1048         segment base registers.
1049         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
1050
1051 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1052
1053         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
1054         Update calls to i386_target_description to add 'segments'
1055         parameter.
1056         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
1057         add segment base registers.
1058         * arch/i386.c (i386_create_target_description): Add 'segments'
1059         parameter to enable segment base registers.
1060         * arch/i386.h (i386_create_target_description): Likewise.
1061         * features/i386/32bit-segments.xml: New file.
1062         * features/i386/32bit-segments.c: Generate.
1063         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
1064         call to i386_target_description to add 'segments' parameter.
1065         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
1066         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
1067         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
1068         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
1069         if feature is present.
1070         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
1071         Add 'segments' parameter to call to i386_target_description.
1072         (i386_target_description): Add 'segments' parameter to enable
1073         segment base registers.
1074         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
1075         to call to i386_target_description.
1076         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
1077         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
1078         Define I386_NUM_REGS.
1079         (i386_target_description): Add 'segments' parameter to enable
1080         segment base registers.
1081
1082 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
1083
1084         PR/24325
1085         * source-cache.c: #undef open and close, to avoid unresolved
1086         externals during linking.
1087
1088 2019-03-12  Tom Tromey  <tromey@adacore.com>
1089
1090         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
1091         const.  Add initializers.
1092         (_initialize_remote): Don't initialize ptid globals.
1093
1094 2019-03-12  Pedro Alves  <palves@redhat.com>
1095
1096         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
1097
1098 2019-03-12  Pedro Alves  <palves@redhat.com>
1099
1100         * cp-name-parser.y (main): Remove unused 'len' variable.
1101
1102 2019-03-12  Tom Tromey  <tromey@adacore.com>
1103
1104         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
1105         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
1106
1107 2019-03-12  Tom Tromey  <tromey@adacore.com>
1108
1109         * linux-nat.c (iterate_over_lwps): Update.
1110         (stop_callback): Remove parameter.
1111         (stop_wait_callback, detach_callback, resume_set_callback)
1112         (select_singlestep_lwp_callback, set_ignore_sigint)
1113         (status_callback, resumed_callback, resume_clear_callback)
1114         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
1115         data parameter.
1116         (linux_nat_target::detach, linux_nat_target::resume)
1117         (linux_stop_and_wait_all_lwps, select_event_lwp)
1118         (linux_nat_filter_event, linux_nat_wait_1)
1119         (linux_nat_target::kill, linux_nat_target::stop)
1120         (linux_nat_target::stop): Update.
1121         (linux_nat_resume_callback): Change type.
1122         (resume_stopped_resumed_lwps, count_events_callback)
1123         (select_event_lwp_callback): Likewise.
1124         (linux_stop_lwp, linux_nat_stop_lwp): Update.
1125         * arm-linux-nat.c (struct update_registers_data): Remove.
1126         (update_registers_callback): Change type.
1127         (arm_linux_insert_hw_breakpoint1): Update.
1128         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
1129         parameter.
1130         (x86_linux_dr_set_addr): Update.
1131         (x86_linux_dr_set_control): Update.
1132         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
1133         (iterate_over_lwps): Use gdb::function_view.
1134         * nat/aarch64-linux-hw-point.c (struct
1135         aarch64_dr_update_callback_param): Remove.
1136         (debug_reg_change_callback): Change type.
1137         (aarch64_notify_debug_reg_change): Update.
1138         * s390-linux-nat.c (s390_refresh_per_info): Update.
1139
1140 2019-03-11  Tom Tromey  <tromey@adacore.com>
1141
1142         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
1143         redundant assignment to "this_cu".
1144
1145 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1146
1147         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
1148
1149 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1150
1151         * gdbtypes.c (rank_one_type_parm_set): New function extracted
1152         from...
1153         (rank_one_type): ... this.
1154
1155 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1156
1157         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
1158         from...
1159         (rank_one_type): ... this.
1160
1161 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1162
1163         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
1164         from...
1165         (rank_one_type): ... this.
1166
1167 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1168
1169         * gdbtypes.c (rank_one_type_parm_float): New function extracted
1170         from...
1171         (rank_one_type): ... this.
1172
1173 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1174
1175         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
1176         from...
1177         (rank_one_type): ... this.
1178
1179 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1180
1181         * gdbtypes.c (rank_one_type_parm_range): New function extracted
1182         from...
1183         (rank_one_type): ... this.
1184
1185 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1186
1187         * gdbtypes.c (rank_one_type_parm_char): New function extracted
1188         from...
1189         (rank_one_type): ... this.
1190
1191 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1192
1193         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
1194         from...
1195         (rank_one_type): ... this.
1196
1197 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1198
1199         * gdbtypes.c (rank_one_type_parm_int): New function extracted
1200         from...
1201         (rank_one_type): ... this.
1202
1203 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1204
1205         * gdbtypes.c (rank_one_type_parm_func): New function extracted
1206         from...
1207         (rank_one_type): ... this.
1208
1209 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1210
1211         * gdbtypes.c (rank_one_type_parm_array): New function extracted
1212         from...
1213         (rank_one_type): ... this.
1214
1215 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1216
1217         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
1218         from...
1219         (rank_one_type): ... this.
1220
1221 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1222
1223         * inferior.c (initialize_inferiors): Ensure 'help set/show print
1224         inferior-events' shows the example events.
1225
1226 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
1227
1228         Support styling on native MS-Windows console
1229
1230         PR/24315
1231         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
1232         on MS-Windows if $TERM is not defined.
1233
1234         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
1235
1236         * posix-hdep.c (gdb_console_fputs):
1237         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
1238         functions.
1239         * ui-file.h (gdb_console_fputs): Add prototype.
1240
1241         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
1242         back to fputs only if the former returns zero.
1243
1244 2019-03-07  Tom Tromey  <tom@tromey.com>
1245
1246         * symmisc.c (print_symbol_bcache_statistics): Update.
1247         (print_objfile_statistics): Update.
1248         * symfile.c (allocate_symtab): Update.
1249         * stabsread.c: Don't include bcache.h.
1250         * psymtab.h (struct psymbol_bcache): Don't declare.
1251         (class psymtab_storage) <psymbol_cache>: Now a bcache.
1252         (psymbol_bcache_init, psymbol_bcache_free)
1253         (psymbol_bcache_get_bcache): Don't declare.
1254         * psymtab.c (struct psymbol_bcache): Remove.
1255         (psymtab_storage::psymtab_storage): Update.
1256         (psymtab_storage::~psymtab_storage): Update.
1257         (psymbol_bcache_init, psymbol_bcache_free)
1258         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
1259         (add_psymbol_to_bcache): Update.
1260         (allocate_psymtab): Update.
1261         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
1262         macro_cache>: No longer pointers.
1263         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
1264         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
1265         * macrotab.c (macro_bcache): Update.
1266         * macroexp.c: Don't include bcache.h.
1267         * gdbtypes.c (check_types_worklist): Update.
1268         (types_deeply_equal): Remove TRY/CATCH.  Update.
1269         * elfread.c (elf_symtab_read): Update.
1270         * dwarf2read.c: Don't include bcache.h.
1271         * buildsym.c (buildsym_compunit::get_macro_table): Update.
1272         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
1273         (print_bcache_statistics, bcache_memory_used): Don't declare.
1274         (struct bcache): Move from bcache.c.  Add constructor, destructor,
1275         methods.  Rename all data members.
1276         * bcache.c (struct bcache): Move to bcache.h.
1277         (bcache::expand_hash_table): Rename from expand_hash_table.
1278         (bcache): Remove.
1279         (bcache::insert): Rename from bcache_full.
1280         (bcache::compare): Rename from bcache_compare.
1281         (bcache_xmalloc): Remove.
1282         (bcache::~bcache): Rename from bcache_xfree.
1283         (bcache::print_statistics): Rename from print_bcache_statistics.
1284         (bcache::memory_used): Rename from bcache_memory_used.
1285
1286 2019-03-07  Pedro Alves  <palves@redhat.com>
1287
1288         * infrun.c (normal_stop): Also check for
1289         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
1290
1291 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1292
1293         * f-lang.c (value_from_host_double): Moved to...
1294         * value.c (value_from_host_double): ...here.
1295         * value.h (value_from_host_double): Declare.
1296         * guile/scm-math.c (vlscm_convert_typed_number): Use
1297         value_from_host_double.
1298         (vlscm_convert_number): Likewise.
1299         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
1300         * python/py-value.c (convert_value_from_python): Likewise.
1301
1302 2019-03-06  Tom Tromey  <tom@tromey.com>
1303
1304         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
1305
1306 2019-03-06  Tom Tromey  <tom@tromey.com>
1307
1308         * utils.h (free_current_contents): Don't declare.
1309         * utils.c (free_current_contents): Remove.
1310
1311 2019-03-06  Tom Tromey  <tom@tromey.com>
1312
1313         * top.c (quit_force): Update.
1314         * main.c (captured_command_loop): Update.
1315         * common/new-op.c (operator new): Update.
1316         * common/common-exceptions.c (struct catcher)
1317         <save_cleanup_chain>: Remove member.
1318         (exceptions_state_mc_init): Update.
1319         (exception_try_scope_entry): Return nullptr.
1320         (exception_try_scope_exit, exception_rethrow)
1321         (throw_exception_sjlj, throw_exception_cxx): Update.
1322         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
1323         (all_cleanups, do_cleanups, discard_cleanups)
1324         (discard_final_cleanups, save_cleanups, save_final_cleanups)
1325         (restore_cleanups, restore_final_cleanups): Don't declare.
1326         (do_final_cleanups): Remove parameter.
1327         * common/cleanups.c (cleanup_chain, make_cleanup)
1328         (make_cleanup_dtor, all_cleanups, do_cleanups)
1329         (discard_my_cleanups, discard_cleanups)
1330         (discard_final_cleanups, save_my_cleanups, save_cleanups)
1331         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
1332         (null_cleanup): Remove.
1333         (do_final_cleanups): Remove parameter.
1334
1335 2019-03-06  Tom Tromey  <tom@tromey.com>
1336
1337         * remote.c (remote_target::remote_parse_stop_reply): Use
1338         unique_xmalloc_ptr.
1339
1340 2019-03-06  Tom Tromey  <tom@tromey.com>
1341
1342         * stabsread.c (struct stabs_field_info): Rename from field_info.
1343         <list, fnlist>: Add initializers.
1344         <obstack>: New member.
1345         (read_member_functions, read_struct_fields, read_baseclasses):
1346         Allocate on obstack.  Don't use cleanups.
1347         (read_one_struct_field, read_member_functions, read_struct_fields)
1348         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
1349         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
1350         (read_struct_type): Update.
1351
1352 2019-03-06  Tom Tromey  <tom@tromey.com>
1353
1354         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
1355         * common/filestuff.h (make_cleanup_close): Don't declare.
1356         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
1357         Remove.
1358
1359 2019-03-06  Tom Tromey  <tom@tromey.com>
1360
1361         * solib-aix.c: Use make_scope_exit.
1362
1363 2019-03-06  Tom Tromey  <tom@tromey.com>
1364
1365         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
1366         Use make_scope_exit.
1367
1368 2019-03-06  Tom Tromey  <tom@tromey.com>
1369
1370         * solib-svr4.c (disable_probes_interface): Remove parameter.
1371         (svr4_handle_solib_event): Use make_scope_exit.
1372
1373 2019-03-06  Tom Tromey  <tom@tromey.com>
1374
1375         * remote.c (struct stop_reply_deleter): Remove.
1376         (stop_reply_up): Update.
1377         (struct stop_reply): Derive from notif_event.  Don't typedef.
1378         <regcache>: Now a std::vector.
1379         (stop_reply_xfree): Remove.
1380         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
1381         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
1382         (remote_target::discard_pending_stop_replies): Use delete.
1383         (remote_target::remote_parse_stop_reply): Update.
1384         (remote_target::process_stop_reply): Update.
1385         * remote-notif.h (struct notif_event): Add virtual destructor.
1386         Remove "dtr" member.
1387         (struct notif_client) <alloc_event>: Return a unique_ptr.
1388         (notif_event_xfree): Don't declare.
1389         (notif_event_up): New typedef.
1390         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
1391         (notif_event_xfree, do_notif_event_xfree): Remove.
1392         (remote_notif_state_xfree): Update.
1393
1394 2019-03-06  Tom Tromey  <tom@tromey.com>
1395
1396         * infrun.c (displaced_step_clear_cleanup): Now a
1397         forward_scope_exit type.
1398         (displaced_step_prepare_throw): Update.
1399         (displaced_step_fixup): Update.
1400
1401 2019-03-06  Tom Tromey  <tom@tromey.com>
1402
1403         * inferior.h (class inferior): Update comment.
1404         * gdbthread.h (class thread_info): Update comment.
1405
1406 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
1407             Tom Tromey  <tom@tromey.com>
1408
1409         * stabsread.h (struct stab_section_list): Remove.
1410         (coffstab_build_psymtabs): Update.
1411         * dbxread.c (symbuf_sections): Now a std::vector.
1412         (sect_idx): New global.
1413         (fill_symbuf): Update.
1414         (coffstab_build_psymtabs): Change type of stabsects parameter.
1415         Update.
1416         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
1417         std::vector.
1418         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
1419         (coff_locate_sections): Update.
1420         (coff_symfile_read): Remove cleanups.  Update.
1421         (init_stringtab): Add storage parameter.
1422         (free_stringtab, free_stringtab_cleanup): Remove.
1423         (init_lineno): Add storage parameter.
1424         (free_linetab, free_linetab_cleanup): Remove.
1425
1426 2019-03-06  Pedro Alves  <palves@redhat.com>
1427
1428         * linux-fork.c (fork_info::clobber_regs): Delete.
1429         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
1430         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
1431         comment.  Adjust.
1432         (scoped_switch_fork_info::scoped_switch_fork_info)
1433         (checkpoint_command, linux_fork_context): Adjust
1434         fork_save_infrun_state calls.
1435
1436 2019-03-06  Pedro Alves  <palves@redhat.com>
1437
1438         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
1439         (inf_has_multiple_threads): Return 'bool' and rewrite using
1440         inferior_info::threads().
1441
1442 2019-03-06  Pedro Alves  <palves@redhat.com>
1443
1444         * linux-fork.c: Include <list>.
1445         (fork_list): Now a std::list instance.
1446         (fork_info): Add ctor, dtor, and in-class initialize all fields.
1447         (forks_exist_p, find_last_fork): Adjust.
1448         (new_fork): Delete.
1449         (one_fork_p): New.
1450         (add_fork): Adjust.
1451         (free_fork): Delete, folded into fork_info::~fork_info().
1452         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
1453         Adjust.
1454         (init_fork_list): Delete.
1455         (linux_fork_killall, linux_fork_mourn_inferior)
1456         (linux_fork_detach, info_checkpoints_command): Adjust.
1457         (_initialize_linux_fork): No longer call init_fork_list.
1458
1459 2019-03-06  Pedro Alves  <palves@redhat.com>
1460
1461         * linux-fork.c (new_fork): New, split out of ...
1462         (add_fork): ... this.  Return void.  Move "first fork" special
1463         case from here, to ...
1464         (checkpoint_command): ... here.
1465         * linux-linux.h (add_fork): Return void.
1466
1467 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1468
1469         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
1470
1471 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1472             Chris January  <chris.january@arm.com>
1473             David Lecomber  <david.lecomber@arm.com>
1474
1475         * f-exp.y: New token, UNOP_INTRINSIC.
1476         (exp): New pattern using UNOP_INTRINSIC token.
1477         (f77_keywords): Add 'abs' keyword.
1478         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
1479         (value_from_host_double): New function.
1480         (evaluate_subexp_f): Support UNOP_ABS.
1481
1482 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1483
1484         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
1485         types.
1486
1487 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1488
1489         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
1490         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
1491         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
1492
1493 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1494
1495         * f-exp.y (convert_to_kind_type): Handle more type kinds.
1496
1497 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1498             Chris January  <chris.january@arm.com>
1499
1500         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
1501         * f-exp.y: Define 'KIND' token.
1502         (exp): New pattern for KIND expressions.
1503         (ptype): Handle types with a kind extension.
1504         (direct_abs_decl): Extend to spot kind extensions.
1505         (f77_keywords): Add 'kind' to the list.
1506         (push_kind_type): New function.
1507         (convert_to_kind_type): New function.
1508         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
1509         * parse.c (operator_length_standard): Likewise.
1510         * parser-defs.h (enum type_pieces): Add tp_kind.
1511         * std-operator.def: Add UNOP_KIND.
1512
1513 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1514
1515         * f-exp.y (f_parse): Set yydebug.
1516
1517 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1518
1519         * f-lang.c (evaluate_subexp_f): New function.
1520         (exp_descriptor_f): New global.
1521         (f_language_defn): Use exp_descriptor_f instead of
1522         exp_descriptor_standard.
1523
1524 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1525
1526         * f-exp.y (struct token): Add comments.
1527         (dot_ops): Remove uppercase versions and the end marker.
1528         (f77_keywords): Likewise.
1529         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
1530         entries in the dot_ops array are case insensitive, and use
1531         strncasecmp to compare strings.  Also some whitespace cleanup in
1532         this area.  Similar for the f77_keywords array, except entries in
1533         this list might be case sensitive.
1534
1535 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1536
1537         * f-exp.y (struct f77_boolean_val): Add comments.
1538         (boolean_values): Remove uppercase versions, and end marker.
1539         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
1540         and use strncasecmp to achieve case insensitivity.  Additionally,
1541         perform whitespace cleanup around this code.
1542
1543 2019-03-06  Tom Tromey  <tromey@adacore.com>
1544
1545         * remote-sim.c (gdbsim_target_open): Use result of
1546         gdb_argv::release.
1547
1548 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
1549         Dirk Schubert  <dirk.schubert@arm.com>
1550         Chris January  <chris.january@arm.com>
1551
1552         * eval.c (evaluate_subexp_standard): Call Fortran argument
1553         wrapping logic.
1554         * f-lang.c (struct value): A value which can be passed into a
1555         Fortran function call.
1556         (fortran_argument_convert): Wrap Fortran arguments in a pointer
1557         where appropriate.
1558         (struct type): Value ready for a Fortran function call.
1559         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
1560         is needed.
1561         * f-lang.h (fortran_argument_convert): Declaration.
1562         (fortran_preserve_arg_pointer): Declaration.
1563         * infcall.c (value_arg_coerce): Call Fortran argument logic.
1564
1565 2019-03-05  Tom Tromey  <tromey@adacore.com>
1566
1567         * python/py-prettyprint.c (print_string_repr): Remove #if.
1568         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
1569
1570 2019-03-05  Tom Tromey  <tromey@adacore.com>
1571
1572         * target.c (the_dummy_target): Move later.  Change type to
1573         "dummy_target".
1574         (initialize_targets): Don't initialize the_dummy_target.
1575
1576 2019-03-05  Tom Tromey  <tromey@adacore.com>
1577
1578         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
1579         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
1580
1581 2019-03-05  Tom Tromey  <tromey@adacore.com>
1582
1583         * windows-nat.c (windows_nat_target::attach)
1584         (windows_nat_target::detach): Don't call gdb_flush.
1585         * valprint.c (generic_val_print, val_print, val_print_string):
1586         Don't call gdb_flush.
1587         * utils.c (defaulted_query): Don't call gdb_flush.
1588         * typeprint.c (print_type_scalar): Don't call gdb_flush.
1589         * target.c (target_announce_detach): Don't call gdb_flush.
1590         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
1591         * remote.c (extended_remote_target::attach): Don't call
1592         gdb_flush.
1593         * procfs.c (procfs_target::detach): Don't call gdb_flush.
1594         * printcmd.c (do_examine): Don't call gdb_flush.
1595         (info_display_command): Don't call gdb_flush.
1596         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
1597         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
1598         * memattr.c (info_mem_command): Don't call gdb_flush.
1599         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
1600         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
1601         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
1602         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
1603         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
1604         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
1605         (gnu_nat_target::detach): Don't call gdb_flush.
1606         * f-valprint.c (f_val_print): Don't call gdb_flush.
1607         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
1608         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
1609         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
1610         gdb_flush.
1611         * c-valprint.c (c_val_print): Don't call gdb_flush.
1612         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
1613
1614 2019-03-05  Tom Tromey  <tromey@adacore.com>
1615
1616         * varobj.c (update_dynamic_varobj_children): Update.
1617         (install_default_visualizer): Use reset, not release.
1618         * value.c (set_internalvar): Update.
1619         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
1620         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
1621         ATTRIBUTE_UNUSED_RESULT.
1622
1623 2019-03-05  Tom Tromey  <tromey@adacore.com>
1624
1625         * remote.c (class scoped_remote_fd) <release>: Add
1626         ATTRIBUTE_UNUSED_RESULT.
1627
1628 2019-03-05  Tom Tromey  <tromey@adacore.com>
1629
1630         * macroexp.c (struct macro_buffer) <release>: Add
1631         ATTRIBUTE_UNUSED_RESULT.
1632
1633 2019-03-05  Tom Tromey  <tromey@adacore.com>
1634
1635         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
1636         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
1637         ATTRIBUTE_UNUSED_RESULT.
1638
1639 2019-03-05  Tom Tromey  <tromey@adacore.com>
1640
1641         * common/scoped_fd.h (class scoped_fd) <release>: Add
1642         ATTRIBUTE_UNUSED_RESULT.
1643
1644 2019-03-05  Tom Tromey  <tromey@adacore.com>
1645
1646         * parser-defs.h (struct parser_state) <release>: Add
1647         ATTRIBUTE_UNUSED_RESULT.
1648
1649 2019-03-05  Tom Tromey  <tromey@adacore.com>
1650
1651         * utils.h (class gdb_argv) <release>: Add
1652         ATTRIBUTE_UNUSED_RESULT.
1653         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1654
1655 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1656
1657         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1658         for-loop range, to avoid compiler warnings.
1659
1660         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1661         avoid compiler warnings about unused variables.
1662
1663         * NEWS: Mention end of support for native debugging on MS-Windows
1664         before XP.
1665
1666         PR gdb/24292
1667         * common/netstuff.c:
1668         * gdbserver/gdbreplay.c
1669         * gdbserver/remote-utils.c:
1670         * ser-tcp.c:
1671         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1672         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1673         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1674         'getaddrinfo' and 'freeaddrinfo' were not available before
1675         Windows XP, and mingw.org's MinGW headers by default define
1676         _WIN32_WINNT to 0x500.
1677
1678 2019-03-01  Gary Benson <gbenson@redhat.com>
1679
1680         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1681
1682 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1683             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1684
1685         PR gdb/8527
1686         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1687         set_sigint_trap, clear_sigint_trap.
1688
1689 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1690
1691         * target.c (target_detach): Clear the regcache and the
1692         frame cache.
1693
1694 2019-02-27  Pedro Alves  <palves@redhat.com>
1695
1696         * utils.c (set_screen_size): When we cap the height/width sizes,
1697         tweak the corresponding command variable to show "unlimited":
1698
1699 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1700             Pedro Alves  <palves@redhat.com>
1701
1702         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1703         before calling rl_set_screen_size.
1704
1705 2019-02-27  Tom Tromey  <tromey@adacore.com>
1706
1707         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1708         define.
1709         * python/py-value.c: Remove Python 2.4 workaround.
1710         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1711         workaround.
1712         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1713         Python 2.4 workaround.
1714         * python/python-internal.h: Remove Python 2.4 comment.
1715         (Py_ssize_t): Don't define.
1716         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1717         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1718         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1719         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1720         * python/python.c (do_start_initialization): Remove Python 2.4
1721         workaround.
1722         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1723         (print_children): Remove Python 2.4 workaround.
1724         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1725         workaround.
1726         (CHARBUFFERPROC_NAME): Remove.
1727         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1728         Python 2.4 workaround.
1729
1730 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1731
1732         * NEWS: Note minimum Python version.
1733
1734 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1735
1736         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1737         code from these functions.  Remove corresponding ifdefs.  Use
1738         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1739         Remove gotos and target of gotos.
1740         (infpy_search_memory): Likewise.
1741
1742 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1743
1744         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1745         (hppa_gdbarch_init): Don't register deleted functions with
1746         gdbarch.
1747
1748 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1749
1750         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1751         (h8300_unwind_sp): Delete.
1752         (h8300_dummy_id): Delete.
1753         (h8300_gdbarch_init): Don't register deleted functions with
1754         gdbarch.
1755
1756 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1757
1758         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1759         (ft32_unwind_pc): Delete.
1760         (ft32_unwind_sp): Delete.
1761         (ft32_gdbarch_init): Don't register deleted functions with
1762         gdbarch.
1763
1764 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1765
1766         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1767         (frv_unwind_pc): Delete.
1768         (frv_unwind_sp): Delete.
1769         (frv_gdbarch_init): Don't register deleted functions with
1770         gdbarch.
1771
1772 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1773
1774         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1775         (riscv_unwind_pc): Delete.
1776         (riscv_unwind_sp): Delete.
1777         (riscv_gdbarch_init): Don't register deleted functions with
1778         gdbarch.
1779
1780 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1781
1782         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1783         (csky_unwind_pc): Delete.
1784         (csky_unwind_sp): Delete.
1785         (csky_gdbarch_init): Don't register deleted functions with
1786         gdbarch.
1787
1788 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1789
1790         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1791         (cris_unwind_pc): Delete.
1792         (cris_unwind_sp): Delete.
1793         (cris_gdbarch_init): Don't register deleted functions with
1794         gdbarch.
1795
1796 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1797
1798         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1799         (bfin_unwind_pc): Delete.
1800         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1801
1802 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1803
1804         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1805         (arm_unwind_pc): Delete.
1806         (arm_unwind_sp): Delete.
1807         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1808
1809 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1810
1811         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1812         (arc_unwind_pc): Delete.
1813         (arc_unwind_sp): Delete.
1814         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1815
1816 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1817
1818         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1819         (alpha_unwind_pc): Delete.
1820         (alpha_gdbarch_init): Don't register deleted functions with
1821         gdbarch.
1822
1823 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1824
1825         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1826         (aarch64_unwind_pc): Delete.
1827         (aarch64_unwind_sp): Delete.
1828         (aarch64_gdbarch_init): Don't register deleted functions with
1829         gdbarch.
1830
1831 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1832
1833         * gdbtypes.c (type_align): Don't consider static members when
1834         computing structure alignment.
1835
1836 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1837
1838         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1839         return 0 for other types.
1840         * arch-utils.c (default_type_align): Always return 0.
1841         * gdbarch.h: Regenerate.
1842         * gdbarch.sh (type_align): Extend comment.
1843         * gdbtypes.c (type_align): Add additional comments, always call
1844         gdbarch_type_align before applying the default rules.
1845         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1846         generic code will then apply a suitable default.
1847         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1848         types, return 0 for other types.
1849
1850 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1851
1852         * NEWS: Create a new section for the next release branch.
1853         Rename the section of the current branch, now that it has
1854         been cut.
1855
1856 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1857
1858         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1859         * version.in: Bump version to 8.3.50.DATE-git.
1860
1861 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1862
1863         * aix-thread.c (ptid_cmp): Remove unused variable.
1864         (get_signaled_thread): Likewise.
1865         (store_regs_user_thread): Likewise.
1866         (store_regs_kernel_thread): Likewise.
1867         (fetch_regs_kernel_thread): Remove shadowed variable.
1868
1869 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1870
1871         * features/riscv/32bit-cpu.xml: Add register numbers.
1872         * features/riscv/32bit-fpu.c: Regenerate.
1873         * features/riscv/32bit-fpu.xml: Add register numbers.
1874         * features/riscv/64bit-cpu.xml: Add register numbers.
1875         * features/riscv/64bit-fpu.c: Regenerate.
1876         * features/riscv/64bit-fpu.xml: Add register numbers.
1877
1878 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1879
1880         * NEWS: Mention two argument form of gdb.Value constructor.
1881         * python/py-value.c (convert_buffer_and_type_to_value): New
1882         function.
1883         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1884         Add support for handling an optional second argument.  Call
1885         convert_buffer_and_type_to_value as appropriate.
1886         * python/python-internal.h (Py_buffer_deleter): New struct.
1887         (Py_buffer_up): New typedef.
1888
1889 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1890
1891         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1892         instead of releasing ownership.
1893
1894 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1895
1896         * dwarf2read.c (open_and_init_dwp_file): Call
1897         elf_numsections instead of bfd_count_sections to initialize
1898         dwp_file->num_sections.
1899
1900 2019-02-25  Tom Tromey  <tromey@adacore.com>
1901
1902         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1903
1904 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1905
1906         * gcore.in: Add '--readnever' option when invoking GDB.
1907
1908 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1909
1910         * MAINTAINERS: Update my email address.
1911
1912 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1913
1914         * build-id.c (build_id_to_debug_bfd_1): New function.
1915         (build_id_to_debug_bfd): Look for separate debug file in
1916         sysroot.
1917
1918 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1919
1920         * gdbarch.sh: Update the copyright year range that is placed into
1921         generated files.
1922
1923 2019-02-22  Keith Seitz  <keiths@redhat.com>
1924
1925         PR symtab/23853
1926         * linespec.c (create_sals_line_offset): Search for the default
1927         symtab's filename instead of its fullname.
1928
1929 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1930
1931         * NEWS: Update style defaults.
1932
1933 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1934
1935         * main.c (captured_main_1): Disable styling in batch mode.
1936
1937 2019-02-20  Tom Tromey  <tom@tromey.com>
1938
1939         * symtab.c (symtab_symbol_info): Fix typos.
1940
1941 2019-02-20  Tom Tromey  <tromey@adacore.com>
1942
1943         * findcmd.c (_initialize_mem_search): Use upper case for
1944         metasyntactic variables.
1945
1946 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1947
1948         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1949         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1950
1951 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1952
1953         * top.h (source_file_name): Change to std::string.
1954         * top.c (source_file_name): Likewise.
1955         (command_line_input): Adjust.
1956         * cli/cli-script.c (script_from_file): Adjust.
1957
1958 2019-02-19  Tom Tromey  <tromey@adacore.com>
1959
1960         * ravenscar-thread.c
1961         (ravenscar_thread_target::update_thread_list): Don't call
1962         ada_build_task_list.
1963         * ada-lang.h (ada_build_task_list): Don't declare.
1964         * ada-tasks.c (struct ada_tasks_inferior_data)
1965         <task_list_valid_p>: Now bool.
1966         (read_known_tasks, ada_task_list_changed)
1967         (ada_tasks_invalidate_inferior_data): Update.
1968         (read_known_tasks_array): Return bool.
1969         (read_known_tasks_list): Likewise.
1970         (read_known_tasks): Return void.
1971         (ada_build_task_list): Now static.
1972
1973 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1974
1975         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1976         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1977
1978 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1979
1980         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1981         variant for ada_tasks_pspace_data_handle and
1982         ada_tasks_inferior_data_handle.
1983         (ada_tasks_pspace_data_cleanup): New function.
1984         (ada_tasks_inferior_data_cleanup): New function.
1985
1986 2019-02-17  Tom Tromey  <tom@tromey.com>
1987
1988         * macrotab.h (macro_source_fullname): Return a std::string.
1989         * macrotab.c (macro_include, check_for_redefinition)
1990         (macro_undef, macro_lookup_definition, foreach_macro)
1991         (foreach_macro_in_scope): Update.
1992         (macro_source_fullname): Return a std::string.
1993         * macrocmd.c (show_pp_source_pos): Update.
1994
1995 2019-02-17  Tom Tromey  <tom@tromey.com>
1996
1997         * macrocmd.c (show_pp_source_pos): Style the file names.
1998
1999 2019-02-17  Tom Tromey  <tom@tromey.com>
2000
2001         PR tui/24197:
2002         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
2003
2004 2019-02-17  Tom Tromey  <tom@tromey.com>
2005
2006         * ada-lang.c (user_select_syms): Use filtered printing.
2007         * utils.c (wrap_style): New global.
2008         (desired_style): Remove.
2009         (emit_style_escape): Add stream parameter.
2010         (set_output_style, reset_terminal_style, prompt_for_continue):
2011         Update.
2012         (flush_wrap_buffer): Only flush gdb_stdout.
2013         (wrap_here): Set wrap_style.
2014         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
2015         treat escape sequences as a character.  Change when wrap buffer is
2016         flushed.
2017         (fputs_styled): Do not set the output style when the default is
2018         requested.
2019         * ui-style.h (struct ui_file_style) <is_default>: New method.
2020         * source.c (print_source_lines_base): Emit escape sequences in one
2021         piece.
2022
2023 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
2024
2025         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
2026         integers and enumeration types.
2027
2028 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
2029
2030         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
2031         instead of lookup_symbol_in_language
2032         (do_exact_match): New function.
2033         (ada_get_symbol_name_matcher): Return do_exact_match when
2034         doing a verbatim match.
2035
2036 2019-02-15  Tom Tromey  <tromey@adacore.com>
2037
2038         * ravenscar-thread.c (ravenscar_thread_target::resume)
2039         (ravenscar_thread_target::wait): Special case wildcard requests.
2040
2041 2019-02-15  Tom Tromey  <tromey@adacore.com>
2042
2043         * ravenscar-thread.c (base_ptid): Remove.
2044         (struct ravenscar_thread_target) <close>: New method.
2045         <m_base_ptid>: New member.
2046         <update_inferior_ptid, active_task, task_is_currently_active,
2047         runtime_initialized>: Declare methods.
2048         <ravenscar_thread_target>: Add constructor.
2049         (ravenscar_thread_target::task_is_currently_active)
2050         (ravenscar_thread_target::update_inferior_ptid)
2051         (ravenscar_runtime_initialized): Rename.  Now methods.
2052         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
2053         (ravenscar_thread_target::update_thread_list): Update.
2054         (ravenscar_thread_target::active_task): Now method.
2055         (ravenscar_thread_target::store_registers)
2056         (ravenscar_thread_target::prepare_to_store)
2057         (ravenscar_thread_target::prepare_to_store)
2058         (ravenscar_thread_target::mourn_inferior): Update.
2059         (ravenscar_inferior_created): Use "new" to create target.
2060         (ravenscar_thread_target::get_ada_task_ptid): Update.
2061         (_initialize_ravenscar): Don't initialize base_ptid.
2062         (ravenscar_ops): Remove global.
2063
2064 2019-02-15  Tom Tromey  <tromey@adacore.com>
2065
2066         * target.h (push_target): Declare new overload.
2067         * target.c (push_target): New overload, taking an rvalue reference.
2068         * remote.c (remote_target::open_1): Use push_target overload.
2069         * corelow.c (core_target_open): Use push_target overload.
2070
2071 2019-02-15  Tom Tromey  <tromey@adacore.com>
2072
2073         * ravenscar-thread.c (is_ravenscar_task)
2074         (ravenscar_task_is_currently_active): Return bool.
2075         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
2076         (_initialize_ravenscar): Remove "(void)".
2077         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
2078         Return bool.
2079
2080 2019-02-15  Tom Tromey  <tromey@adacore.com>
2081
2082         * ravenscar-thread.c (ravenscar_runtime_initializer)
2083         (has_ravenscar_runtime, get_running_thread_id)
2084         (ravenscar_thread_target::resume): Fix indentation.
2085
2086 2019-02-15  Tom Tromey  <tromey@adacore.com>
2087
2088         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
2089         from ravenscar_arch_ops.
2090         (sparc_ravenscar_ops::fetch_registers)
2091         (sparc_ravenscar_ops::store_registers): Now methods.
2092         (sparc_ravenscar_prepare_to_store): Remove.
2093         (sparc_ravenscar_ops): Redefine.
2094         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
2095         methods and destructor.  Remove members.
2096         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
2097         (ravenscar_thread_target::store_registers)
2098         (ravenscar_thread_target::prepare_to_store): Update.
2099         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
2100         Remove.
2101         (struct ppc_ravenscar_powerpc_ops): Derive from
2102         ravenscar_arch_ops.
2103         (ppc_ravenscar_powerpc_ops::fetch_registers)
2104         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
2105         (ppc_ravenscar_powerpc_ops): Redefine.
2106         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
2107         (ppc_ravenscar_e500_ops::fetch_registers)
2108         (ppc_ravenscar_e500_ops::store_registers): Now methods.
2109         (ppc_ravenscar_e500_ops): Redefine.
2110         * aarch64-ravenscar-thread.c
2111         (aarch64_ravenscar_generic_prepare_to_store): Remove.
2112         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
2113         (aarch64_ravenscar_fetch_registers)
2114         (aarch64_ravenscar_store_registers): Now methods.
2115         (aarch64_ravenscar_ops): Redefine.
2116
2117 2019-02-15  Tom Tromey  <tromey@adacore.com>
2118
2119         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
2120         (ravenscar_thread_target::stopped_by_hw_breakpoint)
2121         (ravenscar_thread_target::stopped_by_watchpoint)
2122         (ravenscar_thread_target::stopped_data_address)
2123         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
2124
2125 2019-02-15  Tom Tromey  <tromey@adacore.com>
2126
2127         * ravenscar-thread.c: Fix some typos.
2128
2129 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2130             Tom Tromey  <tromey@adacore.com>
2131
2132         * ada-lang.c (ada_exception_sal): Change addr_string to a
2133         std::string.
2134         (create_ada_exception_catchpoint): Update.
2135
2136 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2137             Tom Tromey  <tromey@adacore.com>
2138
2139         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
2140         (bp_location_ops): Remove.
2141         (base_breakpoint_allocate_location): Update.
2142         (free_bp_location): Update.
2143         * ada-lang.c (class ada_catchpoint_location)
2144         <ada_catchpoint_location>: Remove ops parameter.
2145         (ada_catchpoint_location_dtor): Remove.
2146         (ada_catchpoint_location_ops): Remove.
2147         (allocate_location_exception): Update.
2148         * breakpoint.h (struct bp_location_ops): Remove.
2149         (class bp_location) <bp_location>: Remove bp_location_ops
2150         parameter.
2151         <~bp_location>: Add destructor.
2152         <ops>: Remove.
2153
2154 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
2155             Pedro Alves  <palves@redhat.com>
2156
2157         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
2158         'PATH_MAX'.
2159
2160 2019-02-14  David Michael  <fedora.dm0@gmail.com>
2161             Samuel Thibault  <samuel.thibault@gnu.org>
2162             Thomas Schwinge  <thomas@codesourcery.com>
2163
2164         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
2165         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
2166
2167 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
2168
2169         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
2170         (check_empty): Use "const char *".
2171
2172         * gnu-nat.c (gnu_nat_target::detach): Instead of
2173         'detach_inferior (pid)' call
2174         'detach_inferior (find_inferior_pid (pid))'.
2175
2176         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
2177         'nat/fork-inferior.o'.
2178         * gnu-nat.c: #include "nat/fork-inferior.h".
2179
2180         * gnu-nat.c (gnu_nat_target::detach): Instead of
2181         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
2182         * gnu-nat.h: #include "inf-child.h".
2183         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
2184         'i386_gnu_nat_target::fetch_registers'.
2185         (gnu_store_registers): Rename/move to
2186         'i386_gnu_nat_target::store_registers'.
2187
2188         * config/i386/nm-i386gnu.h: Don't "#include" any files.
2189         * gnu-nat.h (mach_thread_info): New function.
2190         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
2191
2192         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
2193
2194 2019-02-14  Frederic Konrad  <konrad@adacore.com>
2195
2196         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
2197
2198 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
2199
2200         * windows-nat.c (windows_add_thread): Add new parameter
2201         "main_thread_p" with default value set to false.  Update
2202         function documentation as well as all callers.
2203         (windows_delete_thread): Likewise.
2204         (fake_create_process): Update call to windows_add_thread.
2205         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
2206         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
2207         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
2208         call to windows_delete_thread.
2209
2210 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
2211
2212         * MAINTAINERS: Add Andrew Burgess as global maintainer.
2213
2214 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2215
2216         * symfile.c (find_separate_debug_file): Use canonical path of
2217         sysroot with child_path instead of gdb_sysroot if it is valid.
2218
2219 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2220
2221         * symfile.c (find_separate_debug_file): Use child_path to
2222         determine if an object file is under a sysroot.
2223
2224 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2225
2226         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
2227         unittests/child-path-selftests.c.
2228         * common/pathstuff.c (child_path): New function.
2229         * common/pathstuff.h (child_path): New prototype.
2230         * unittests/child-path-selftests.c: New file.
2231
2232 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2233
2234         * symfile.c (find_separate_debug_file): Look for separate debug
2235         files in debug directories under the sysroot.
2236
2237 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2238
2239         * symtab.h (struct minimal_symbol data_p): New const method.
2240         (struct minimal_symbol text_p): Likewise.
2241         * symtab.c (output_source_filename): Use file name style
2242         to print file name.
2243         (print_symbol_info): Likewise.
2244         (print_msymbol_info): Use address style to print addresses.
2245         Use function name style to print executable text symbols.
2246         (expand_symtab_containing_pc): Use data_p.
2247         (find_pc_sect_compunit_symtab): Likewise.
2248
2249 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2250
2251         * breakpoint.c (describe_other_breakpoints): Use address style
2252         to print addresses.
2253         (say_where): Likewise.
2254
2255 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2256
2257         * ada-typeprint.c (print_func_type): Print function name
2258         style to print function name.
2259         * c-typeprint.c (c_print_type_1): Likewise.
2260
2261 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
2262
2263         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
2264         for execve.
2265
2266 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2267
2268         * c-exp.y (direct_abs_decl): Use emplace_back to record the
2269         type_stack.
2270
2271 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
2272
2273         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
2274         TYPE_CODE_REF types.
2275
2276 2019-02-08  Jim Wilson  <jimw@sifive.com>
2277
2278         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
2279         (riscv_linux_fregset): New.
2280         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
2281
2282 2019-02-07  Tom Tromey  <tom@tromey.com>
2283
2284         * thread.c (thread_cancel_execution_command): Update.
2285         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
2286         methods.
2287         (struct thread_fsm_ops): Remove.
2288         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
2289         (thread_fsm_should_stop, thread_fsm_return_value)
2290         (thread_fsm_set_finished, thread_fsm_finished_p)
2291         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
2292         Don't declare.
2293         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
2294         * infrun.c (clear_proceed_status_thread)
2295         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
2296         (print_stop_event): Update.
2297         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
2298         Add constructor.
2299         (step_command_fsm_ops): Remove.
2300         (new_step_command_fsm): Remove.
2301         (step_1): Update.
2302         (step_command_fsm::should_stop): Rename from
2303         step_command_fsm_should_stop.
2304         (step_command_fsm::clean_up): Rename from
2305         step_command_fsm_clean_up.
2306         (step_command_fsm::do_async_reply_reason): Rename from
2307         step_command_fsm_async_reply_reason.
2308         (struct until_next_fsm): Inherit from thread_fsm.  Add
2309         constructor.
2310         (until_next_fsm_ops): Remove.
2311         (new_until_next_fsm): Remove.
2312         (until_next_fsm::should_stop): Rename from
2313         until_next_fsm_should_stop.
2314         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
2315         (until_next_fsm::do_async_reply_reason): Rename from
2316         until_next_fsm_async_reply_reason.
2317         (struct finish_command_fsm): Inherit from thread_fsm.  Add
2318         constructor.  Change type of breakpoint.
2319         (finish_command_fsm_ops): Remove.
2320         (new_finish_command_fsm): Remove.
2321         (finish_command_fsm::should_stop): Rename from
2322         finish_command_fsm_should_stop.
2323         (finish_command_fsm::clean_up): Rename from
2324         finish_command_fsm_clean_up.
2325         (finish_command_fsm::return_value): Rename from
2326         finish_command_fsm_return_value.
2327         (finish_command_fsm::do_async_reply_reason): Rename from
2328         finish_command_fsm_async_reply_reason.
2329         (finish_command): Update.
2330         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
2331         Add constructor.
2332         (call_thread_fsm_ops): Remove.
2333         (call_thread_fsm::call_thread_fsm): Rename from
2334         new_call_thread_fsm.
2335         (call_thread_fsm::should_stop): Rename from
2336         call_thread_fsm_should_stop.
2337         (call_thread_fsm::should_notify_stop): Rename from
2338         call_thread_fsm_should_notify_stop.
2339         (run_inferior_call, call_function_by_hand_dummy): Update.
2340         * cli/cli-interp.c (should_print_stop_to_console): Update.
2341         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
2342         Add constructor.  Change type of location_breakpoint,
2343         caller_breakpoint.
2344         (until_break_fsm_ops): Remove.
2345         (new_until_break_fsm): Remove.
2346         (until_break_fsm::should_stop): Rename from
2347         until_break_fsm_should_stop.
2348         (until_break_fsm::clean_up): Rename from
2349         until_break_fsm_clean_up.
2350         (until_break_fsm::do_async_reply_reason): Rename from
2351         until_break_fsm_async_reply_reason.
2352         (until_break_command): Update.
2353         * thread-fsm.c: Remove.
2354         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
2355
2356 2019-02-07  Tom Tromey  <tom@tromey.com>
2357
2358         * yy-remap.h: Add include guard.
2359         * xtensa-tdep.h: Add include guard.
2360         * xcoffread.h: Rename include guard.
2361         * varobj-iter.h: Add include guard.
2362         * tui/tui.h: Rename include guard.
2363         * tui/tui-winsource.h: Rename include guard.
2364         * tui/tui-wingeneral.h: Rename include guard.
2365         * tui/tui-windata.h: Rename include guard.
2366         * tui/tui-win.h: Rename include guard.
2367         * tui/tui-stack.h: Rename include guard.
2368         * tui/tui-source.h: Rename include guard.
2369         * tui/tui-regs.h: Rename include guard.
2370         * tui/tui-out.h: Rename include guard.
2371         * tui/tui-layout.h: Rename include guard.
2372         * tui/tui-io.h: Rename include guard.
2373         * tui/tui-hooks.h: Rename include guard.
2374         * tui/tui-file.h: Rename include guard.
2375         * tui/tui-disasm.h: Rename include guard.
2376         * tui/tui-data.h: Rename include guard.
2377         * tui/tui-command.h: Rename include guard.
2378         * tic6x-tdep.h: Add include guard.
2379         * target/waitstatus.h: Rename include guard.
2380         * target/wait.h: Rename include guard.
2381         * target/target.h: Rename include guard.
2382         * target/resume.h: Rename include guard.
2383         * target-float.h: Rename include guard.
2384         * stabsread.h: Add include guard.
2385         * rs6000-tdep.h: Add include guard.
2386         * riscv-fbsd-tdep.h: Add include guard.
2387         * regformats/regdef.h: Rename include guard.
2388         * record.h: Rename include guard.
2389         * python/python.h: Rename include guard.
2390         * python/python-internal.h: Rename include guard.
2391         * python/py-stopevent.h: Rename include guard.
2392         * python/py-ref.h: Rename include guard.
2393         * python/py-record.h: Rename include guard.
2394         * python/py-record-full.h: Rename include guard.
2395         * python/py-record-btrace.h: Rename include guard.
2396         * python/py-instruction.h: Rename include guard.
2397         * python/py-events.h: Rename include guard.
2398         * python/py-event.h: Rename include guard.
2399         * procfs.h: Add include guard.
2400         * proc-utils.h: Add include guard.
2401         * p-lang.h: Add include guard.
2402         * or1k-tdep.h: Rename include guard.
2403         * observable.h: Rename include guard.
2404         * nto-tdep.h: Rename include guard.
2405         * nat/x86-linux.h: Rename include guard.
2406         * nat/x86-linux-dregs.h: Rename include guard.
2407         * nat/x86-gcc-cpuid.h: Add include guard.
2408         * nat/x86-dregs.h: Rename include guard.
2409         * nat/x86-cpuid.h: Rename include guard.
2410         * nat/ppc-linux.h: Rename include guard.
2411         * nat/mips-linux-watch.h: Rename include guard.
2412         * nat/linux-waitpid.h: Rename include guard.
2413         * nat/linux-ptrace.h: Rename include guard.
2414         * nat/linux-procfs.h: Rename include guard.
2415         * nat/linux-osdata.h: Rename include guard.
2416         * nat/linux-nat.h: Rename include guard.
2417         * nat/linux-namespaces.h: Rename include guard.
2418         * nat/linux-btrace.h: Rename include guard.
2419         * nat/glibc_thread_db.h: Rename include guard.
2420         * nat/gdb_thread_db.h: Rename include guard.
2421         * nat/gdb_ptrace.h: Rename include guard.
2422         * nat/fork-inferior.h: Rename include guard.
2423         * nat/amd64-linux-siginfo.h: Rename include guard.
2424         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
2425         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
2426         * nat/aarch64-linux.h: Rename include guard.
2427         * nat/aarch64-linux-hw-point.h: Rename include guard.
2428         * mn10300-tdep.h: Add include guard.
2429         * mips-linux-tdep.h: Add include guard.
2430         * mi/mi-parse.h: Rename include guard.
2431         * mi/mi-out.h: Rename include guard.
2432         * mi/mi-main.h: Rename include guard.
2433         * mi/mi-interp.h: Rename include guard.
2434         * mi/mi-getopt.h: Rename include guard.
2435         * mi/mi-console.h: Rename include guard.
2436         * mi/mi-common.h: Rename include guard.
2437         * mi/mi-cmds.h: Rename include guard.
2438         * mi/mi-cmd-break.h: Rename include guard.
2439         * m2-lang.h: Add include guard.
2440         * location.h: Rename include guard.
2441         * linux-record.h: Rename include guard.
2442         * linux-nat.h: Add include guard.
2443         * linux-fork.h: Add include guard.
2444         * i386-darwin-tdep.h: Rename include guard.
2445         * hppa-linux-offsets.h: Add include guard.
2446         * guile/guile.h: Rename include guard.
2447         * guile/guile-internal.h: Rename include guard.
2448         * gnu-nat.h: Rename include guard.
2449         * gdb-stabs.h: Rename include guard.
2450         * frv-tdep.h: Add include guard.
2451         * f-lang.h: Add include guard.
2452         * event-loop.h: Add include guard.
2453         * darwin-nat.h: Rename include guard.
2454         * cp-abi.h: Rename include guard.
2455         * config/sparc/nm-sol2.h: Rename include guard.
2456         * config/nm-nto.h: Rename include guard.
2457         * config/nm-linux.h: Add include guard.
2458         * config/i386/nm-i386gnu.h: Rename include guard.
2459         * config/djgpp/nl_types.h: Rename include guard.
2460         * config/djgpp/langinfo.h: Rename include guard.
2461         * compile/gcc-cp-plugin.h: Add include guard.
2462         * compile/gcc-c-plugin.h: Add include guard.
2463         * compile/compile.h: Rename include guard.
2464         * compile/compile-object-run.h: Rename include guard.
2465         * compile/compile-object-load.h: Rename include guard.
2466         * compile/compile-internal.h: Rename include guard.
2467         * compile/compile-cplus.h: Rename include guard.
2468         * compile/compile-c.h: Rename include guard.
2469         * common/xml-utils.h: Rename include guard.
2470         * common/x86-xstate.h: Rename include guard.
2471         * common/version.h: Rename include guard.
2472         * common/vec.h: Rename include guard.
2473         * common/tdesc.h: Rename include guard.
2474         * common/selftest.h: Rename include guard.
2475         * common/scoped_restore.h: Rename include guard.
2476         * common/scoped_mmap.h: Rename include guard.
2477         * common/scoped_fd.h: Rename include guard.
2478         * common/safe-iterator.h: Rename include guard.
2479         * common/run-time-clock.h: Rename include guard.
2480         * common/refcounted-object.h: Rename include guard.
2481         * common/queue.h: Rename include guard.
2482         * common/ptid.h: Rename include guard.
2483         * common/print-utils.h: Rename include guard.
2484         * common/preprocessor.h: Rename include guard.
2485         * common/pathstuff.h: Rename include guard.
2486         * common/observable.h: Rename include guard.
2487         * common/netstuff.h: Rename include guard.
2488         * common/job-control.h: Rename include guard.
2489         * common/host-defs.h: Rename include guard.
2490         * common/gdb_wait.h: Rename include guard.
2491         * common/gdb_vecs.h: Rename include guard.
2492         * common/gdb_unlinker.h: Rename include guard.
2493         * common/gdb_unique_ptr.h: Rename include guard.
2494         * common/gdb_tilde_expand.h: Rename include guard.
2495         * common/gdb_sys_time.h: Rename include guard.
2496         * common/gdb_string_view.h: Rename include guard.
2497         * common/gdb_splay_tree.h: Rename include guard.
2498         * common/gdb_setjmp.h: Rename include guard.
2499         * common/gdb_ref_ptr.h: Rename include guard.
2500         * common/gdb_optional.h: Rename include guard.
2501         * common/gdb_locale.h: Rename include guard.
2502         * common/gdb_assert.h: Rename include guard.
2503         * common/filtered-iterator.h: Rename include guard.
2504         * common/filestuff.h: Rename include guard.
2505         * common/fileio.h: Rename include guard.
2506         * common/environ.h: Rename include guard.
2507         * common/common-utils.h: Rename include guard.
2508         * common/common-types.h: Rename include guard.
2509         * common/common-regcache.h: Rename include guard.
2510         * common/common-inferior.h: Rename include guard.
2511         * common/common-gdbthread.h: Rename include guard.
2512         * common/common-exceptions.h: Rename include guard.
2513         * common/common-defs.h: Rename include guard.
2514         * common/common-debug.h: Rename include guard.
2515         * common/cleanups.h: Rename include guard.
2516         * common/buffer.h: Rename include guard.
2517         * common/btrace-common.h: Rename include guard.
2518         * common/break-common.h: Rename include guard.
2519         * cli/cli-utils.h: Rename include guard.
2520         * cli/cli-style.h: Rename include guard.
2521         * cli/cli-setshow.h: Rename include guard.
2522         * cli/cli-script.h: Rename include guard.
2523         * cli/cli-interp.h: Rename include guard.
2524         * cli/cli-decode.h: Rename include guard.
2525         * cli/cli-cmds.h: Rename include guard.
2526         * charset-list.h: Add include guard.
2527         * buildsym-legacy.h: Rename include guard.
2528         * bfin-tdep.h: Add include guard.
2529         * ax.h: Rename include guard.
2530         * arm-linux-tdep.h: Add include guard.
2531         * arm-fbsd-tdep.h: Add include guard.
2532         * arch/xtensa.h: Rename include guard.
2533         * arch/tic6x.h: Add include guard.
2534         * arch/i386.h: Add include guard.
2535         * arch/arm.h: Rename include guard.
2536         * arch/arm-linux.h: Rename include guard.
2537         * arch/arm-get-next-pcs.h: Rename include guard.
2538         * arch/amd64.h: Add include guard.
2539         * arch/aarch64-insn.h: Rename include guard.
2540         * arch-utils.h: Rename include guard.
2541         * annotate.h: Add include guard.
2542         * amd64-darwin-tdep.h: Rename include guard.
2543         * aarch64-linux-tdep.h: Add include guard.
2544         * aarch64-fbsd-tdep.h: Add include guard.
2545         * aarch32-linux-nat.h: Add include guard.
2546
2547 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2548
2549         * macrotab.c (macro_define_internal): New function that
2550         factorizes macro_define_object_internal and macro_define_function
2551         code.
2552         (macro_define_object_internal): Use macro_define_internal.
2553         (macro_define_function): Likewise.
2554
2555 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2556
2557         * macrocmd.c (extract_identifier): Return
2558         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
2559         callers.
2560
2561 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
2562
2563         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
2564
2565 2019-02-05  Tom Tromey  <tom@tromey.com>
2566
2567         * target.c (target_stack::unpush): Move assertion earlier.
2568
2569 2019-01-30  Tom Tromey  <tom@tromey.com>
2570
2571         PR python/23615:
2572         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
2573         (gdbpy_parse_and_eval): Likewise.
2574         * python/python-internal.h (gdbpy_allow_threads): New class.
2575
2576 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
2577
2578         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
2579         (aarch64_fbsd_fpregmap): Move earlier.
2580         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
2581         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2582         instead of individual calls to trad_frame_set_reg_addr.
2583         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
2584         earlier.
2585         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
2586         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2587         instead of individual calls to trad_frame_set_reg_addr.
2588
2589 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
2590
2591         * CONTRIBUTE: Replace contribution list with wiki link.
2592
2593 2019-01-25  Tom Tromey  <tom@tromey.com>
2594
2595         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
2596
2597 2019-01-25  Tom Tromey  <tom@tromey.com>
2598
2599         * xtensa-linux-nat.c: Fix common/ includes.
2600         * xml-support.h: Fix common/ includes.
2601         * xml-support.c: Fix common/ includes.
2602         * x86-linux-nat.c: Fix common/ includes.
2603         * windows-nat.c: Fix common/ includes.
2604         * varobj.h: Fix common/ includes.
2605         * varobj.c: Fix common/ includes.
2606         * value.c: Fix common/ includes.
2607         * valops.c: Fix common/ includes.
2608         * utils.c: Fix common/ includes.
2609         * unittests/xml-utils-selftests.c: Fix common/ includes.
2610         * unittests/utils-selftests.c: Fix common/ includes.
2611         * unittests/unpack-selftests.c: Fix common/ includes.
2612         * unittests/tracepoint-selftests.c: Fix common/ includes.
2613         * unittests/style-selftests.c: Fix common/ includes.
2614         * unittests/string_view-selftests.c: Fix common/ includes.
2615         * unittests/scoped_restore-selftests.c: Fix common/ includes.
2616         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
2617         * unittests/scoped_fd-selftests.c: Fix common/ includes.
2618         * unittests/rsp-low-selftests.c: Fix common/ includes.
2619         * unittests/parse-connection-spec-selftests.c: Fix common/
2620         includes.
2621         * unittests/optional-selftests.c: Fix common/ includes.
2622         * unittests/offset-type-selftests.c: Fix common/ includes.
2623         * unittests/observable-selftests.c: Fix common/ includes.
2624         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
2625         * unittests/memrange-selftests.c: Fix common/ includes.
2626         * unittests/memory-map-selftests.c: Fix common/ includes.
2627         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
2628         * unittests/function-view-selftests.c: Fix common/ includes.
2629         * unittests/environ-selftests.c: Fix common/ includes.
2630         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
2631         * unittests/common-utils-selftests.c: Fix common/ includes.
2632         * unittests/cli-utils-selftests.c: Fix common/ includes.
2633         * unittests/array-view-selftests.c: Fix common/ includes.
2634         * ui-file.c: Fix common/ includes.
2635         * tui/tui-io.c: Fix common/ includes.
2636         * tracepoint.h: Fix common/ includes.
2637         * tracepoint.c: Fix common/ includes.
2638         * tracefile-tfile.c: Fix common/ includes.
2639         * top.h: Fix common/ includes.
2640         * top.c: Fix common/ includes.
2641         * thread.c: Fix common/ includes.
2642         * target/waitstatus.h: Fix common/ includes.
2643         * target/waitstatus.c: Fix common/ includes.
2644         * target.h: Fix common/ includes.
2645         * target.c: Fix common/ includes.
2646         * target-memory.c: Fix common/ includes.
2647         * target-descriptions.c: Fix common/ includes.
2648         * symtab.h: Fix common/ includes.
2649         * symfile.c: Fix common/ includes.
2650         * stap-probe.c: Fix common/ includes.
2651         * spu-linux-nat.c: Fix common/ includes.
2652         * sparc-nat.c: Fix common/ includes.
2653         * source.c: Fix common/ includes.
2654         * solib.c: Fix common/ includes.
2655         * solib-target.c: Fix common/ includes.
2656         * ser-unix.c: Fix common/ includes.
2657         * ser-tcp.c: Fix common/ includes.
2658         * ser-pipe.c: Fix common/ includes.
2659         * ser-base.c: Fix common/ includes.
2660         * selftest-arch.c: Fix common/ includes.
2661         * s12z-tdep.c: Fix common/ includes.
2662         * rust-exp.y: Fix common/ includes.
2663         * rs6000-aix-tdep.c: Fix common/ includes.
2664         * riscv-tdep.c: Fix common/ includes.
2665         * remote.c: Fix common/ includes.
2666         * remote-notif.h: Fix common/ includes.
2667         * remote-fileio.h: Fix common/ includes.
2668         * remote-fileio.c: Fix common/ includes.
2669         * regcache.h: Fix common/ includes.
2670         * regcache.c: Fix common/ includes.
2671         * record-btrace.c: Fix common/ includes.
2672         * python/python.c: Fix common/ includes.
2673         * python/py-type.c: Fix common/ includes.
2674         * python/py-inferior.c: Fix common/ includes.
2675         * progspace.h: Fix common/ includes.
2676         * producer.c: Fix common/ includes.
2677         * procfs.c: Fix common/ includes.
2678         * proc-api.c: Fix common/ includes.
2679         * printcmd.c: Fix common/ includes.
2680         * ppc-linux-nat.c: Fix common/ includes.
2681         * parser-defs.h: Fix common/ includes.
2682         * osdata.c: Fix common/ includes.
2683         * obsd-nat.c: Fix common/ includes.
2684         * nat/x86-linux.c: Fix common/ includes.
2685         * nat/x86-linux-dregs.c: Fix common/ includes.
2686         * nat/x86-dregs.h: Fix common/ includes.
2687         * nat/x86-dregs.c: Fix common/ includes.
2688         * nat/ppc-linux.c: Fix common/ includes.
2689         * nat/mips-linux-watch.h: Fix common/ includes.
2690         * nat/mips-linux-watch.c: Fix common/ includes.
2691         * nat/linux-waitpid.c: Fix common/ includes.
2692         * nat/linux-ptrace.h: Fix common/ includes.
2693         * nat/linux-ptrace.c: Fix common/ includes.
2694         * nat/linux-procfs.c: Fix common/ includes.
2695         * nat/linux-personality.c: Fix common/ includes.
2696         * nat/linux-osdata.c: Fix common/ includes.
2697         * nat/linux-namespaces.c: Fix common/ includes.
2698         * nat/linux-btrace.h: Fix common/ includes.
2699         * nat/linux-btrace.c: Fix common/ includes.
2700         * nat/fork-inferior.c: Fix common/ includes.
2701         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2702         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2703         * nat/aarch64-linux.c: Fix common/ includes.
2704         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2705         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2706         * namespace.h: Fix common/ includes.
2707         * mips-linux-tdep.c: Fix common/ includes.
2708         * minsyms.c: Fix common/ includes.
2709         * mi/mi-parse.h: Fix common/ includes.
2710         * mi/mi-main.c: Fix common/ includes.
2711         * mi/mi-cmd-env.c: Fix common/ includes.
2712         * memrange.h: Fix common/ includes.
2713         * memattr.c: Fix common/ includes.
2714         * maint.h: Fix common/ includes.
2715         * maint.c: Fix common/ includes.
2716         * main.c: Fix common/ includes.
2717         * machoread.c: Fix common/ includes.
2718         * location.c: Fix common/ includes.
2719         * linux-thread-db.c: Fix common/ includes.
2720         * linux-nat.c: Fix common/ includes.
2721         * linux-fork.c: Fix common/ includes.
2722         * inline-frame.c: Fix common/ includes.
2723         * infrun.c: Fix common/ includes.
2724         * inflow.c: Fix common/ includes.
2725         * inferior.h: Fix common/ includes.
2726         * inferior.c: Fix common/ includes.
2727         * infcmd.c: Fix common/ includes.
2728         * inf-ptrace.c: Fix common/ includes.
2729         * inf-child.c: Fix common/ includes.
2730         * ia64-linux-nat.c: Fix common/ includes.
2731         * i387-tdep.c: Fix common/ includes.
2732         * i386-tdep.c: Fix common/ includes.
2733         * i386-linux-tdep.c: Fix common/ includes.
2734         * i386-linux-nat.c: Fix common/ includes.
2735         * i386-go32-tdep.c: Fix common/ includes.
2736         * i386-fbsd-tdep.c: Fix common/ includes.
2737         * i386-fbsd-nat.c: Fix common/ includes.
2738         * guile/scm-type.c: Fix common/ includes.
2739         * guile/guile.c: Fix common/ includes.
2740         * go32-nat.c: Fix common/ includes.
2741         * gnu-nat.c: Fix common/ includes.
2742         * gdbthread.h: Fix common/ includes.
2743         * gdbarch-selftests.c: Fix common/ includes.
2744         * gdb_usleep.c: Fix common/ includes.
2745         * gdb_select.h: Fix common/ includes.
2746         * gdb_bfd.c: Fix common/ includes.
2747         * gcore.c: Fix common/ includes.
2748         * fork-child.c: Fix common/ includes.
2749         * findvar.c: Fix common/ includes.
2750         * fbsd-nat.c: Fix common/ includes.
2751         * event-top.c: Fix common/ includes.
2752         * event-loop.c: Fix common/ includes.
2753         * dwarf2read.c: Fix common/ includes.
2754         * dwarf2loc.c: Fix common/ includes.
2755         * dwarf2-frame.c: Fix common/ includes.
2756         * dwarf-index-cache.c: Fix common/ includes.
2757         * dtrace-probe.c: Fix common/ includes.
2758         * disasm-selftests.c: Fix common/ includes.
2759         * defs.h: Fix common/ includes.
2760         * csky-tdep.c: Fix common/ includes.
2761         * cp-valprint.c: Fix common/ includes.
2762         * cp-support.h: Fix common/ includes.
2763         * cp-support.c: Fix common/ includes.
2764         * corelow.c: Fix common/ includes.
2765         * completer.h: Fix common/ includes.
2766         * completer.c: Fix common/ includes.
2767         * compile/compile.c: Fix common/ includes.
2768         * compile/compile-loc2c.c: Fix common/ includes.
2769         * compile/compile-cplus-types.c: Fix common/ includes.
2770         * compile/compile-cplus-symbols.c: Fix common/ includes.
2771         * command.h: Fix common/ includes.
2772         * cli/cli-dump.c: Fix common/ includes.
2773         * cli/cli-cmds.c: Fix common/ includes.
2774         * charset.c: Fix common/ includes.
2775         * build-id.c: Fix common/ includes.
2776         * btrace.h: Fix common/ includes.
2777         * btrace.c: Fix common/ includes.
2778         * breakpoint.h: Fix common/ includes.
2779         * breakpoint.c: Fix common/ includes.
2780         * ax.h:
2781         (enum agent_op): Fix common/ includes.
2782         * ax-general.c (struct aop_map): Fix common/ includes.
2783         * ax-gdb.c: Fix common/ includes.
2784         * auxv.c: Fix common/ includes.
2785         * auto-load.c: Fix common/ includes.
2786         * arm-tdep.c: Fix common/ includes.
2787         * arch/riscv.c: Fix common/ includes.
2788         * arch/ppc-linux-common.c: Fix common/ includes.
2789         * arch/i386.c: Fix common/ includes.
2790         * arch/arm.c: Fix common/ includes.
2791         * arch/arm-linux.c: Fix common/ includes.
2792         * arch/arm-get-next-pcs.c: Fix common/ includes.
2793         * arch/amd64.c: Fix common/ includes.
2794         * arch/aarch64.c: Fix common/ includes.
2795         * arch/aarch64-insn.c: Fix common/ includes.
2796         * arch-utils.c: Fix common/ includes.
2797         * amd64-windows-tdep.c: Fix common/ includes.
2798         * amd64-tdep.c: Fix common/ includes.
2799         * amd64-sol2-tdep.c: Fix common/ includes.
2800         * amd64-obsd-tdep.c: Fix common/ includes.
2801         * amd64-nbsd-tdep.c: Fix common/ includes.
2802         * amd64-linux-tdep.c: Fix common/ includes.
2803         * amd64-linux-nat.c: Fix common/ includes.
2804         * amd64-fbsd-tdep.c: Fix common/ includes.
2805         * amd64-fbsd-nat.c: Fix common/ includes.
2806         * amd64-dicos-tdep.c: Fix common/ includes.
2807         * amd64-darwin-tdep.c: Fix common/ includes.
2808         * agent.c: Fix common/ includes.
2809         * ada-lang.h: Fix common/ includes.
2810         * ada-lang.c: Fix common/ includes.
2811         * aarch64-tdep.c: Fix common/ includes.
2812
2813 2019-01-25  Tom Tromey  <tom@tromey.com>
2814
2815         * common/create-version.sh: Use common/version.h.
2816
2817 2019-01-24  Pedro Alves  <palves@redhat.com>
2818
2819         * infrun.c (signal_stop, signal_print, signal_program)
2820         (signal_catch, signal_pass): Now arrays instead of pointers.
2821         (update_signals_program_target, do_target_resume)
2822         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2823         * linux-nat.c (linux_nat_target::pass_signals)
2824         (linux_nat_target::create_inferior, linux_nat_target::attach):
2825         Adjust.
2826         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2827         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2828         * procfs.c (procfs_target::pass_signals): Adjust.
2829         * record-full.c (record_full_target::resume): Adjust.
2830         * remote.c (remote_target::pass_signals)
2831         (remote_target::program_signals): Adjust.
2832         * target-debug.h (target_debug_print_signals): Now takes a
2833         gdb::array_view as parameter.  Adjust.
2834         * target.h (target_ops) <pass_signals, program_signals>: Replace
2835         pointer and length parameters with gdb::array_view.
2836         (target_pass_signals, target_program_signals): Likewise.
2837         * target-delegates.c: Regenerate.
2838
2839 2019-01-24  Pedro Alves  <palves@redhat.com>
2840
2841         * common/forward-scope-exit.h
2842         (forward_scope_exit::forward_scope_exit): Pass arguments to
2843         m_bind_function directly, instead of creating a std::bind and
2844         copying that.
2845
2846 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2847
2848         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2849         for static members.
2850         (pass_in_v_vfp_candidate): Likewise.
2851
2852 2019-01-23  Tom Tromey  <tom@tromey.com>
2853             Pedro Alves  <palves@redhat.com>
2854
2855         * regcache.c (class regcache_invalidator): Remove.
2856         (regcache::raw_write): Use make_scope_exit.
2857
2858 2019-01-23  Tom Tromey  <tom@tromey.com>
2859
2860         * ui-out.h (class ui_out_emit_type): Update comment.
2861
2862 2019-01-23  Tom Tromey  <tom@tromey.com>
2863
2864         * infrun.c (fetch_inferior_event): Update comment.
2865
2866 2019-01-23  Tom Tromey  <tom@tromey.com>
2867             Pedro Alves  <palves@redhat.com>
2868
2869         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2870         parameter.
2871         (fetch_inferior_event): Use SCOPE_EXIT.
2872
2873
2874 2019-01-23  Tom Tromey  <tom@tromey.com>
2875             Pedro Alves  <palves@redhat.com>
2876
2877         * infrun.c (disable_thread_events): Delete.
2878         (stop_all_threads): Use SCOPE_EXIT.
2879
2880 2019-01-23  Tom Tromey  <tom@tromey.com>
2881             Pedro Alves  <palves@redhat.com>
2882
2883         * symfile.c: Include forward-scope-exit.h.
2884         (clear_symtab_users_cleanup): Replace forward declaration with
2885         a FORWARD_SCOPE_EXIT.
2886         (syms_from_objfile_1): Use the forward_scope_exit and
2887         gdb::optional instead of cleanup_function.
2888         (reread_symbols): Use the forward_scope_exit instead of
2889         cleanup_function.
2890         (clear_symtab_users_cleanup): Remove function.
2891
2892 2019-01-23  Tom Tromey  <tom@tromey.com>
2893             Pedro Alves  <palves@redhat.com>
2894
2895         * linux-nat.c: Include scope-exit.h.
2896         (cleanup_target_stop): Remove.
2897         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2898         SCOPE_EXIT.
2899
2900 2019-01-23  Tom Tromey  <tom@tromey.com>
2901             Pedro Alves  <palves@redhat.com>
2902
2903         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2904         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2905
2906 2019-01-23  Tom Tromey  <tom@tromey.com>
2907             Andrew Burgess  <andrew.burgess@embecosm.com>
2908             Pedro Alves  <palves@redhat.com>
2909
2910         * infrun.c (fetch_inferior_event): Use scope_exit.
2911         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2912         * top.c (execute_command): Use scope_exit.
2913         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2914         * utils.c (do_bpstat_clear_actions_cleanup)
2915         (make_bpstat_clear_actions_cleanup): Remove.
2916
2917 2019-01-23  Tom Tromey  <tom@tromey.com>
2918             Pedro Alves  <palves@redhat.com>
2919
2920         * infrun.c: Include "common/scope-exit.h"
2921         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2922         (wait_for_inferior): Use SCOPE_EXIT.
2923         (fetch_inferior_event): Use scope_exit.
2924
2925 2019-01-23  Tom Tromey  <tom@tromey.com>
2926             Pedro Alves  <palves@redhat.com>
2927
2928         * breakpoint.c (create_breakpoint): Remove cleanup.
2929
2930 2019-01-23  Tom Tromey  <tom@tromey.com>
2931             Andrew Burgess  <andrew.burgess@embecosm.com>
2932             Pedro Alves  <palves@redhat.com>
2933
2934 2019-01-23  Pedro Alves  <palves@redhat.com>
2935
2936         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2937
2938 2019-01-23  Pedro Alves  <palves@redhat.com>
2939             Andrew Burgess  <andrew.burgess@embecosm.com>
2940
2941         * gdbthread.h: Include "common/forward-scope-exit.h".
2942         (scoped_finish_thread_state): Redefine custom class in terms of
2943         forward_scope_exit.
2944
2945 2019-01-23  Pedro Alves  <palves@redhat.com>
2946             Andrew Burgess  <andrew.burgess@embecosm.com>
2947
2948         * common/forward-scope-exit.h: New file.
2949
2950 2019-01-23  Pedro Alves  <palves@redhat.com>
2951             Andrew Burgess  <andrew.burgess@embecosm.com>
2952             Tom Tromey  <tom@tromey.com>
2953
2954         * common/scope-exit.h: New file.
2955
2956 2019-01-23  Pedro Alves  <palves@redhat.com>
2957
2958         * common/preprocessor.h (ESC): Rename to ...
2959         (ESC_PARENS): ... this.
2960         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2961         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2962
2963 2019-01-23  Tom Tromey  <tom@tromey.com>
2964
2965         * language.h (class scoped_switch_to_sym_language_if_auto):
2966         Initialize m_lang in both cases.
2967
2968 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2969
2970         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2971         with XCNEW.
2972
2973 2019-01-22  Tom Tromey  <tom@tromey.com>
2974
2975         * corelow.c: Do not include sys/file.h.
2976
2977 2019-01-22  Tom Tromey  <tom@tromey.com>
2978
2979         * tui/tui-wingeneral.h: Include gdb_curses.h.
2980
2981 2019-01-22  Tom Tromey  <tom@tromey.com>
2982
2983         * source-cache.h (class source_cache) <get_source_lines,
2984         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2985
2986 2019-01-22  Tom Tromey  <tom@tromey.com>
2987
2988         * remote-fileio.h (struct remote_target): Declare.
2989
2990 2019-01-22  Tom Tromey  <tom@tromey.com>
2991
2992         * python/py-arch.c: Do not include py-ref.h.
2993         * python/py-bpevent.c: Do not include py-ref.h.
2994         * python/py-cmd.c: Do not include py-ref.h.
2995         * python/py-continueevent.c: Do not include py-ref.h.
2996         * python/py-event.h: Do not include py-ref.h.
2997         * python/py-evtregistry.c: Do not include py-ref.h.
2998         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2999         * python/py-frame.c: Do not include py-ref.h.
3000         * python/py-framefilter.c: Do not include py-ref.h.
3001         * python/py-function.c: Do not include py-ref.h.
3002         * python/py-infevents.c: Do not include py-ref.h.
3003         * python/py-linetable.c: Do not include py-ref.h.
3004         * python/py-objfile.c: Do not include py-ref.h.
3005         * python/py-param.c: Do not include py-ref.h.
3006         * python/py-prettyprint.c: Do not include py-ref.h.
3007         * python/py-progspace.c: Do not include py-ref.h.
3008         * python/py-symbol.c: Do not include py-ref.h.
3009         * python/py-symtab.c: Do not include py-ref.h.
3010         * python/py-type.c: Do not include py-ref.h.
3011         * python/py-unwind.c: Do not include py-ref.h.
3012         * python/py-utils.c: Do not include py-ref.h.
3013         * python/py-value.c: Do not include py-ref.h.
3014         * python/py-varobj.c: Do not include py-ref.h.
3015         * python/py-xmethods.c: Do not include py-ref.h.
3016         * python/python.c: Do not include py-ref.h.
3017         * varobj.c: Do not include py-ref.h.
3018
3019 2019-01-22  Tom Tromey  <tom@tromey.com>
3020
3021         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
3022         keyword for bcache.
3023
3024 2019-01-22  Tom Tromey  <tom@tromey.com>
3025
3026         * compile/compile-cplus-types.c: Remove a comment by #include.
3027
3028 2019-01-22  Tom Tromey  <tom@tromey.com>
3029
3030         * compile/gcc-c-plugin.h: Include compile-internal.h.
3031
3032 2019-01-22  Tom Tromey  <tom@tromey.com>
3033
3034         * stabsread.c (EXTERN): Do not define.
3035         (symnum, next_symbol_text_func, processing_gcc_compilation)
3036         (within_function, global_sym_chain, global_stabs)
3037         (previous_stab_code, this_object_header_files)
3038         (n_this_object_header_files)
3039         (n_allocated_this_object_header_files): Define.
3040         * stabsread.h (EXTERN): Never define.  Use "extern".
3041
3042 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3043
3044         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
3045         history_value.
3046
3047 2019-01-21  Tom Tromey  <tom@tromey.com>
3048
3049         * ui-out.c: Fix includes.
3050         * tui/tui-source.c: Fix includes.
3051         * target.c: Fix includes.
3052         * remote.c: Fix includes.
3053         * regcache.c: Fix includes.
3054         * python/py-block.c: Fix includes.
3055         * printcmd.c: Fix includes.
3056         * or1k-tdep.c: Fix includes.
3057         * mi/mi-main.c: Fix includes.
3058         * m32r-tdep.c: Fix includes.
3059         * csky-tdep.c: Fix includes.
3060         * compile/compile-cplus-types.c: Fix includes.
3061         * cli/cli-interp.c: Fix includes.
3062
3063 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
3064
3065         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
3066         for padding.
3067
3068 2019-01-16  Tom Tromey  <tom@tromey.com>
3069
3070         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
3071         earlier.
3072         (struct objfile) <msymbols_range>: Move from top level.
3073         <msymbols>: New method.
3074         (class objfile_msymbols): Remove.
3075         * symtab.c (default_collect_symbol_completion_matches_break_on):
3076         Update.
3077         * symmisc.c (dump_msymbols): Update.
3078         * stabsread.c (scan_file_globals): Update.
3079         * objc-lang.c (info_selectors_command, info_classes_command)
3080         (find_methods): Update.
3081         * minsyms.c (find_solib_trampoline_target): Update.
3082         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
3083         * coffread.c (coff_symfile_read): Update.
3084         * ada-lang.c (ada_lookup_simple_minsym)
3085         (ada_collect_symbol_completion_matches): Update.
3086
3087 2019-01-16  Tom Tromey  <tom@tromey.com>
3088
3089         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
3090         type.  Remove no-argument constructor.
3091         <iterator::operator++>: Simplify.
3092         <begin>: Update.
3093         <end>: Use minimal_symbol_count.
3094
3095 2019-01-16  Tom Tromey  <tom@tromey.com>
3096
3097         * objfiles.h (struct objfile) <psymtabs>: New method.
3098         (class objfile_psymtabs): Remove.
3099         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
3100         typedef.
3101         <range>: New method.
3102         (require_partial_symbols): Change return type.
3103         * psymtab.c (require_partial_symbols)
3104         (psym_expand_symtabs_matching): Update.
3105         * mdebugread.c (parse_partial_symbols): Update.
3106         * dbxread.c (dbx_end_psymtab): Update.
3107
3108 2019-01-15  Tom Tromey  <tom@tromey.com>
3109
3110         * symtab.c (lookup_objfile_from_block)
3111         (lookup_symbol_in_objfile_symtabs)
3112         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
3113         (find_line_symtab, info_sources_command)
3114         (default_collect_symbol_completion_matches_break_on)
3115         (make_source_files_completion_list): Update.
3116         * symmisc.c (print_objfile_statistics, dump_objfile)
3117         (maintenance_print_symbols, maintenance_info_symtabs)
3118         (maintenance_check_symtabs, maintenance_info_line_tables):
3119         Update.
3120         * source.c (select_source_symtab)
3121         (forget_cached_source_info_for_objfile): Update.
3122         * objfiles.h (class objfile_compunits): Remove.
3123         (struct objfile) <compunits_range>: New typedef.
3124         (compunits): New method.
3125         * objfiles.c (objfile_relocate1): Update.
3126         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
3127         * maint.c (count_symtabs_and_blocks): Update.
3128         * linespec.c (iterate_over_all_matching_symtabs): Update.
3129         * cp-support.c (add_symbol_overload_list_qualified): Update.
3130         * coffread.c (coff_symtab_read): Update.
3131         * ada-lang.c (add_nonlocal_symbols)
3132         (ada_collect_symbol_completion_matches)
3133         (ada_add_global_exceptions): Update.
3134
3135 2019-01-15  Tom Tromey  <tom@tromey.com>
3136
3137         * progspace.h (program_space) <objfiles_safe_range>: New
3138         typedef.
3139         <objfiles_safe>: New method.
3140         * objfiles.h (class all_objfiles_safe): Remove.
3141         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
3142         * jit.c (jit_inferior_exit_hook): Update.
3143
3144 2019-01-17  Tom Tromey  <tom@tromey.com>
3145
3146         * progspace.h (program_space) <objfiles_range>: New typedef.
3147         <objfiles>: New method.
3148         <objfiles_head>: Rename from objfiles.
3149         (object_files): Update.
3150         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
3151         * guile/scm-pretty-print.c
3152         (ppscm_find_pretty_printer_from_objfiles): Update.
3153         * guile/scm-objfile.c (gdbscm_objfiles): Update.
3154         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
3155         Update.
3156         * python/py-progspace.c (pspy_get_objfiles): Update.
3157         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3158         Update.
3159         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3160         (objfpy_lookup_objfile_by_build_id): Update.
3161         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
3162         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3163         Update.
3164         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3165         (expand_symtab_containing_pc, lookup_objfile_from_block)
3166         (lookup_static_symbol, basic_lookup_transparent_type)
3167         (find_pc_sect_compunit_symtab, find_symbol_at_address)
3168         (find_line_symtab, info_sources_command)
3169         (default_collect_symbol_completion_matches_break_on)
3170         (make_source_files_completion_list, find_main_name): Update.
3171         * symmisc.c (print_symbol_bcache_statistics)
3172         (print_objfile_statistics, maintenance_print_symbols)
3173         (maintenance_print_msymbols, maintenance_print_objfiles)
3174         (maintenance_info_symtabs, maintenance_check_symtabs)
3175         (maintenance_expand_symtabs, maintenance_info_line_tables):
3176         Update.
3177         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
3178         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
3179         (map_overlay_command, unmap_overlay_command)
3180         (simple_overlay_update, expand_symtabs_matching)
3181         (map_symbol_filenames): Update.
3182         * symfile-debug.c (set_debug_symfile): Update.
3183         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
3184         Update.
3185         * source.c (select_source_symtab, forget_cached_source_info):
3186         Update.
3187         * solib.c (solib_read_symbols): Update.
3188         * solib-spu.c (append_ocl_sos): Update.
3189         * psymtab.c (maintenance_print_psymbols)
3190         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
3191         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
3192         * printcmd.c (info_symbol_command): Update.
3193         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
3194         Update.
3195         * objfiles.h (class all_objfiles): Remove.
3196         * objfiles.c (have_partial_symbols, have_full_symbols)
3197         (have_minimal_symbols, qsort_cmp, update_section_map)
3198         (shared_objfile_contains_address_p)
3199         (default_iterate_over_objfiles_in_search_order): Update.
3200         * objc-lang.c (info_selectors_command, info_classes_command)
3201         (find_methods): Update.
3202         * minsyms.c (find_solib_trampoline_target): Update.
3203         * maint.c (maintenance_info_sections)
3204         (maintenance_translate_address, count_symtabs_and_blocks):
3205         Update.
3206         * main.c (captured_main_1): Update.
3207         * linux-thread-db.c (try_thread_db_load_from_pdir)
3208         (has_libpthread): Update.
3209         * linespec.c (iterate_over_all_matching_symtabs)
3210         (search_minsyms_for_name): Update.
3211         * jit.c (jit_find_objf_with_entry_addr): Update.
3212         * hppa-tdep.c (find_unwind_entry)
3213         (hppa_lookup_stub_minimal_symbol): Update.
3214         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
3215         Update.
3216         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3217         (elf_gnu_ifunc_resolve_by_got): Update.
3218         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
3219         * dwarf-index-write.c (save_gdb_index_command): Update.
3220         * cp-support.c (add_symbol_overload_list_qualified): Update.
3221         * breakpoint.c (create_overlay_event_breakpoint)
3222         (create_longjmp_master_breakpoint)
3223         (create_std_terminate_master_breakpoint)
3224         (create_exception_master_breakpoint): Update.
3225         * blockframe.c (find_pc_partial_function): Update.
3226         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
3227         (ada_collect_symbol_completion_matches)
3228         (ada_add_global_exceptions): Update.
3229
3230 2019-01-17  Tom Tromey  <tom@tromey.com>
3231
3232         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
3233         declare VEC.
3234         (solib_target_parse_libraries): Change return type.
3235         (library_list_start_segment, library_list_start_section)
3236         (library_list_end_library, library_list_start_library); Update.
3237         (solib_target_free_library_list): Remove.
3238         (solib_target_parse_libraries): Remove cleanup.  Change return
3239         type.
3240         (solib_target_current_sos): Update.
3241
3242 2019-01-17  Tom Tromey  <tromey@bapiya>
3243
3244         * valprint.c: Replace "the the" with "the".
3245         * symtab.c: Replace "the the" with "the".
3246         * solib.c: Replace "the the" with "the".
3247         * solib-dsbt.c: Replace "the the" with "the".
3248         * linespec.c: Replace "the the" with "the".
3249         * dwarf2loc.h: Replace "the the" with "the".
3250         * amd64-windows-tdep.c: Replace "the the" with "the".
3251         * aarch64-tdep.c: Replace "the the" with "the".
3252
3253 2019-01-16  Keith Seitz  <keiths@redhat.com>
3254
3255         PR gdb/23773
3256         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
3257         <builder>: Rename to ..
3258         <m_builder>: ... this and make private.
3259         (dwarf2_cu::get_builder): New method.  Change all users of
3260         `builder' to use this method.
3261         (dwarf2_start_symtab): Move to ...
3262         (dwarf2_cu::start_symtab): ... here.  Update all callers
3263         (setup_type_unit_groups): Move to ...
3264         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
3265         callers.
3266         (dwarf2_cu::reset_builder): New method.
3267         (process_full_compunit, process_full_type_unit): Use
3268         dwarf2_cu::reset_builder.
3269         (follow_die_offset): Record the ancestor CU if it is different
3270         from the followed DIE's CU.
3271         (follow_die_sig_1): Likewise.
3272
3273 2019-01-15  Tom Tromey  <tom@tromey.com>
3274
3275         * remote.c (class remote_state) <buf>: Now a char_vector.
3276         <buf_size>: Remove.
3277         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
3278         parameter.
3279         (remote_target::getpkt_or_notif_sane_1)
3280         (remote_target::getpkt_sane)
3281         (remote_target::getpkt_or_notif_sane): Likewise.
3282         (class remote_target) <putpkt>: New overload.
3283         (remote_target::read_frame): Change type of "buf_p".  Remove
3284         sizeof_p parameter.
3285         (packet_ok): New overload.
3286         (packet_check_result): New overload.
3287         Update all uses.
3288
3289 2019-01-14  Tom Tromey  <tom@tromey.com>
3290
3291         * remote-notif.c (handle_notification, remote_notif_ack)
3292         (remote_notif_parse): Make "buf" const.
3293         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
3294         const.
3295         (remote_notif_parse, remote_notif_ack, handle_notification):
3296         Likewise.
3297         * remote.c (remote_notif_stop_parse): Make "buf" const.
3298         (remote_target::remote_parse_stop_reply): Make "buf" const.
3299         (remote_notif_stop_ack): Make "buf" const.
3300
3301 2019-01-14  Tom Tromey  <tom@tromey.com>
3302
3303         * remote.c (remote_console_output): Make parameter const.
3304
3305 2019-01-14  Tom Tromey  <tom@tromey.com>
3306
3307         * target-debug.h (target_debug_print_signals): Constify.
3308         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
3309         * procfs.c (procfs_target::pass_signals): Update.
3310         * linux-nat.c (linux_nat_target::pass_signals): Update.
3311         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
3312         * target-delegates.c: Rebuild.
3313         * remote.c (remote_target::program_signals): Update.
3314         (remote_target::pass_signals): Update.
3315         * target.c (target_pass_signals): Constify argument.
3316         (target_program_signals): Likewise.
3317         * target.h (struct target_ops) <pass_signals, program_signals>:
3318         Constify argument.
3319         (target_pass_signals, target_program_signals): Constify argument.
3320
3321 2019-01-14  Tom Tromey  <tom@tromey.com>
3322
3323         PR tui/28819:
3324         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
3325
3326 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3327
3328         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
3329         field.
3330         * rs6000-tdep.c: Include reggroups.h.
3331         (IS_V_ALIAS_PSEUDOREG): Define.
3332         (rs6000_register_name): Return names for the "vX" aliases.
3333         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
3334         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
3335         aliases.  Call default_register_reggroup_p for all other
3336         pseudo-registers.
3337         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
3338         New functions.
3339         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
3340         Handle "vX" aliases.
3341         (v_alias_pseudo_register_collect): New function.
3342         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
3343         (rs6000_gdbarch_init): Initialize "vX" aliases as
3344         pseudo-registers.  Restore registration of
3345         rs6000_pseudo_register_reggroup_p with
3346         set_tdesc_pseudo_register_reggroup_p.
3347
3348 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
3349
3350         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
3351         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
3352         set_gdbarch_num_pseudo_regs.
3353
3354 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3355
3356         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
3357         Remove arg prefixname, add do_set and do_show.
3358         Add member functions set_list and show_list.
3359         * cli/cli-style.c (class cli_style_option): Update accordingly.
3360         (style_set_list): Move to file scope.
3361         (style_show_list): Likewise.
3362         (set_style): Call help_list.
3363         (show_style): Call cmd_show_list.
3364         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
3365         Update to use the new macro.
3366
3367 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
3368
3369         * ada-lang.c (_initialize_ada_language): Expand the help text
3370         for the "catch exception" command.
3371
3372 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3373
3374         * symtab.c (matching_obj_sections): Initialize obj,
3375         declare it closer to its usage.
3376
3377 2019-01-10  Tom Tromey  <tom@tromey.com>
3378
3379         * thread-iter.h (inf_threads_iterator): Use next_iterator.
3380         (basic_inf_threads_range): Remove.
3381         (inf_threads_range, inf_non_exited_threads_range)
3382         (safe_inf_threads_range): Use next_adapter.
3383
3384 2019-01-10  Keith Seitz  <keiths@redhat.com>
3385
3386         PR gdb/23712
3387         PR symtab/23010
3388         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
3389         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
3390
3391 2019-01-10  Keith Seitz  <keiths@redhat.com>
3392
3393         PR gdb/23712
3394         PR symtab/23010
3395         * dictionary.c (pending_to_vector): Remove.
3396         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3397         Remove _1 suffix, replacing functions of the same name.  Update
3398         all callers.
3399         (dict_create_hashed, dict_create_hashed_expandable)
3400         (dict_create_linear, dict_create_linear_expandable, dict_free)
3401         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
3402         Make functions static.
3403
3404 2019-01-10  Keith Seitz  <keiths@redhat.com>
3405
3406         PR gdb/23712
3407         PR symtab/23010
3408         * dictionary.h (struct dictionary): Replace declaration with
3409         multidictionary.
3410         (dict_create_hashed, dict_create_hashed_expandable)
3411         (dict_create_linear, dict_create_linear_expandable)
3412         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
3413         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
3414         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
3415         taking multidictionary argument.
3416         [ALL_DICT_SYMBOLS]: Update for multidictionary.
3417         * block.h (struct block) <dict>: Change to multidictionary
3418         and rename `multidict'.
3419         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
3420         symmisc.c: Update all dictionary references to multidictionary.
3421
3422 2019-01-10  Keith Seitz  <keiths@redhat.com>
3423
3424         PR gdb/23712
3425         PR symtab/23010
3426         * dictionary.c: Include unordered_map.
3427         (pending_to_vector): New function.
3428         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3429         Rewrite the non-"_1" functions to take vector instead
3430         of linked list.
3431         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
3432         "new" _1 versions of the same name.
3433         (multidictionary): Define.
3434         (std::hash<enum language): New definition.
3435         (collate_pending_symbols_by_language, mdict_create_hashed)
3436         (mdict_create_hashed_expandable, mdict_create_linear)
3437         (mdict_create_linear_expandable, mdict_free)
3438         (find_language_dictionary, create_new_language_dictionary)
3439         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
3440         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
3441         (mdict_size, mdict_empty): New functions.
3442         * dictionary.h (mdict_iterator): Define.
3443
3444 2019-01-10  Pedro Alves  <palves@redhat.com>
3445
3446         * breakpoint.c (read_uploaded_action)
3447         (create_tracepoint_from_upload): Adjust to use
3448         gdb::unique_xmalloc_ptr.
3449         * ctf.c (ctf_write_uploaded_tp):
3450         (SET_ARRAY_FIELD): Use emplace_back.
3451         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
3452         * tracefile-tfile.c (tfile_write_uploaded_tp):
3453         * tracepoint.c (parse_tracepoint_definition): Adjust to use
3454         gdb::unique_xmalloc_ptr.
3455         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
3456         at_string, cond_string, cmd_strings>: Replace char pointers
3457         with gdb::unique_xmalloc_ptr.
3458
3459 2019-01-10  Pedro Alves  <palves@redhat.com>
3460
3461         * solib-target.c (library_list_start_library): Don't xstrdup name.
3462
3463 2019-01-10  Pedro Alves  <palves@redhat.com>
3464
3465         * mdebugread.c (parse_partial_symbols): Use
3466         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
3467
3468 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3469
3470         * linux-fork.c (scoped_switch_fork_info)
3471         <~scoped_switch_fork_info>: Fix incorrect variable name.
3472
3473 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3474
3475         * linux-fork.c (scoped_switch_fork_info)
3476         <scoped_switch_fork_info>: Make explicit.
3477         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
3478
3479 2019-01-10  Tom Tromey  <tom@tromey.com>
3480
3481         * objfiles.h (objfile::reset_psymtabs): Update.
3482         * objfiles.c (objfile::objfile): Update.
3483         * psymtab.h (psymtab_storage::obstack): Update.
3484         (psymtab_storage::m_obstack): Use gdb::optional.
3485         (class psymtab_storage): Update comment.  Remove objfile
3486         parameter.
3487         * psymtab.c (psymtab_storage::psymtab_storage): Update.
3488
3489 2019-01-10  Tom Tromey  <tom@tromey.com>
3490
3491         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
3492         <free_psymtabs>: Now private.
3493         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
3494         (allocate_psymtab): Use new method.
3495
3496 2019-01-10  Tom Tromey  <tom@tromey.com>
3497
3498         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
3499         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
3500         * mdebugread.c (parse_partial_symbols): Use
3501         allocate_dependencies.
3502         * dwarf2read.c (dwarf2_create_include_psymtab): Use
3503         allocate_dependencies.
3504         (process_psymtab_comp_unit_reader)
3505         (build_type_psymtab_dependencies): Likewise.
3506         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
3507
3508 2019-01-10  Tom Tromey  <tom@tromey.com>
3509
3510         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
3511         PSYMBOL_SET_LANGUAGE.
3512         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
3513
3514 2019-01-10  Tom Tromey  <tom@tromey.com>
3515
3516         * psymtab.h (psymtab_storage::obstack): New method.
3517         <m_obstack>: Rename from obstack; now private.
3518         * psymtab.c (psymtab_storage): Update.
3519         * dwarf2read.c (create_addrmap_from_index)
3520         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
3521         Update.
3522
3523 2019-01-10  Tom Tromey  <tom@tromey.com>
3524
3525         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
3526         * objfiles.h (objfile::reset_psymtabs): New method.
3527
3528 2019-01-10  Tom Tromey  <tom@tromey.com>
3529
3530         * symmisc.c (print_symbol_bcache_statistics): Update.
3531         (print_objfile_statistics): Update.
3532         * symfile.c (reread_symbols): Update.
3533         * psymtab.h (class psymtab_storage): New.
3534         * psymtab.c (psymtab_storage): New constructor.
3535         (~psymtab_storage): New destructor.
3536         (require_partial_symbols): Update.
3537         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
3538         (find_pc_sect_psymtab, find_pc_sect_psymbol)
3539         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
3540         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
3541         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
3542         (start_psymtab_common, end_psymtab_common)
3543         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
3544         (allocate_psymtab): Update.
3545         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
3546         Update.
3547         (dump_psymtab_addrmap, maintenance_print_psymbols)
3548         (maintenance_check_psymtabs): Update.
3549         (class objfile_psymtabs): Move to objfiles.h.
3550         * psympriv.h (discard_psymtab): Now inline.
3551         (psymtab_discarder::psymtab_discarder): Update.
3552         (psymtab_discarder::~psymtab_discarder): Update.
3553         (ALL_OBJFILE_PSYMTABS): Rewrite.
3554         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
3555         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
3556         Remove fields.
3557         <partial_symtabs>: New field.
3558         (class objfile_psymtabs): Move from psymtab.h.  Update.
3559         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
3560         psymbol_cache.
3561         (objfile::~objfile): Don't destroy psymbol_cache.
3562         * mdebugread.c (parse_partial_symbols): Update.
3563         * dwarf2read.c (create_addrmap_from_index)
3564         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3565         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
3566         (add_partial_subprogram, dwarf2_ranges_read): Update.
3567         * dwarf-index-write.c (write_address_map)
3568         (write_one_signatured_type, recursively_write_psymbols)
3569         (class debug_names, class debug_names, write_psymtabs_to_index):
3570         Update.
3571
3572 2019-01-10  Tom Tromey  <tom@tromey.com>
3573
3574         * symtab.h (SYMBOL_SET_NAMES): Update.
3575         (symbol_set_names): Update.
3576         (MSYMBOL_SET_NAMES): Update.
3577         * symtab.c (symbol_set_names): Change argument to be an
3578         objfile_per_bfd_storage.
3579         * psymtab.c (add_psymbol_to_bcache): Update.
3580         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
3581
3582 2019-01-10  Tom Tromey  <tom@tromey.com>
3583
3584         * symtab.c (create_demangled_names_hash): Change argument to be an
3585         objfile_per_bfd_storage.
3586         (symbol_set_names): Update.
3587
3588 2019-01-10  Tom Tromey  <tom@tromey.com>
3589
3590         * xcoffread.c (xcoff_initial_scan): Unconditionally call
3591         init_psymbol_list.
3592         * psymtab.c (init_psymbol_list): Do nothing if already called.
3593         * psympriv.h (init_psymbol_list): Add comment.
3594         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
3595         init_psymbol_list.
3596         * dbxread.c (dbx_symfile_read): Unconditionally call
3597         init_psymbol_list.
3598
3599 2019-01-10  Tom Tromey  <tom@tromey.com>
3600
3601         * xcoffread.c (scan_xcoff_symtab): Update.
3602         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
3603         "where".
3604         * mdebugread.c (parse_partial_symbols)
3605         (handle_psymbol_enumerators): Update.
3606         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
3607         * dbxread.c (read_dbx_symtab): Update.
3608         * psympriv.h (psymbol_placement): New enum.
3609         (add_psymbol_to_list): Update.
3610
3611 2019-01-10  Tom Tromey  <tom@tromey.com>
3612
3613         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
3614         static_psymbols parameters.
3615         (scan_xcoff_symtab): Update.
3616         * psymtab.c (start_psymtab_common): Remove global_psymbols and
3617         static_psymbols parameters.
3618         * psympriv.h (start_psymtab_common): Update.
3619         * mdebugread.c (parse_partial_symbols): Update.
3620         * dwarf2read.c (create_partial_symtab): Update.
3621         * dbxread.c (read_dbx_symtab): Update.
3622         (start_psymtab): Remove global_psymbols and static_psymbols
3623         parameters.
3624
3625 2019-01-10  Tom Tromey  <tom@tromey.com>
3626
3627         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
3628         * psymtab.c (allocate_psymtab): Add comment.
3629         * psympriv.h (allocate_psymtab): Add comment.
3630         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
3631         initializations.
3632         * dbxread.c (dbx_end_psymtab): Remove some initializations.
3633
3634 2019-01-10  Tom Tromey  <tom@tromey.com>
3635
3636         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3637         Don't declare.
3638         * mipsread.c: Include mdebugread.h.
3639         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3640         Declare.
3641         * elfread.c: Include mdebugread.h.
3642
3643 2019-01-09  Tom Tromey  <tom@tromey.com>
3644
3645         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3646         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3647         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3648         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3649         (psym_lookup_symbol, psym_find_last_source_symtab)
3650         (psym_forget_cached_source_info, psym_print_stats)
3651         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3652         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3653         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3654         (psym_find_compunit_symtab_by_address)
3655         (maintenance_print_psymbols, maintenance_info_psymtabs)
3656         (maintenance_check_psymtabs): Use ranged for.
3657         * psymtab.h (class objfile_psymtabs): New.
3658         (require_partial_symbols): Return objfile_psymtabs.
3659         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3660
3661 2019-01-09  Tom Tromey  <tom@tromey.com>
3662
3663         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3664         (find_pc_mapped_section, list_overlays_command)
3665         (map_overlay_command, unmap_overlay_command)
3666         (simple_overlay_update): Use all_objfiles.
3667         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3668         * printcmd.c (info_symbol_command): Use all_objfiles.
3669         * objfiles.h (ALL_OBJSECTIONS): Remove.
3670         * maint.c (maintenance_translate_address): Use all_objfiles.
3671         * gcore.c (gcore_create_callback): Use all_objfiles.
3672         (objfile_find_memory_regions): Likewise.
3673
3674 2019-01-09  Tom Tromey  <tom@tromey.com>
3675
3676         * symtab.c (find_line_symtab, info_sources_command)
3677         (make_source_files_completion_list): Use objfile_compunits.
3678         * source.c (select_source_symtab): Use objfile_compunits.
3679         * objfiles.h (struct objfile): Update comment.
3680         (ALL_OBJFILES): Remove.
3681         (ALL_FILETABS): Remove.
3682         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3683         objfile_compunits.
3684
3685 2019-01-09  Tom Tromey  <tom@tromey.com>
3686
3687         * symmisc.c (print_objfile_statistics, dump_objfile)
3688         (maintenance_print_symbols): Use compunit_filetabs.
3689         * source.c (forget_cached_source_info_for_objfile): Use
3690         compunit_filetabs.
3691         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3692         (ALL_FILETABS): Use compunit_filetabs.
3693         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3694         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3695
3696 2019-01-09  Tom Tromey  <tom@tromey.com>
3697
3698         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3699         (compunit_filetabs): New.
3700         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3701         compunit_filetabs.
3702         (info_sources_command, make_source_files_completion_list): Remove
3703         declaration.
3704         * symmisc.c (print_objfile_statistics, dump_objfile)
3705         (maintenance_print_symbols): Remove declaration.
3706         (maintenance_info_symtabs): Use compunit_filetabs.
3707         (maintenance_info_line_tables): Likewise.
3708         * source.c (select_source_symtab): Change local variable name.
3709         (forget_cached_source_info_for_objfile): Remove declaration.
3710         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3711         * objfiles.c (objfile_relocate1): Remove declaration.
3712         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3713         declaration.
3714         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3715         * coffread.c (coff_symtab_read): Remove declaration.
3716         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3717         compunit_filetabs.
3718
3719 2019-01-09  Tom Tromey  <tom@tromey.com>
3720
3721         * symtab.c (lookup_objfile_from_block)
3722         (find_pc_sect_compunit_symtab, search_symbols)
3723         (default_collect_symbol_completion_matches_break_on): Use
3724         objfile_compunits.
3725         * objfiles.h (ALL_COMPUNITS): Remove.
3726         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3727         * cp-support.c (add_symbol_overload_list_qualified): Use
3728         objfile_compunits.
3729         * ada-lang.c (ada_collect_symbol_completion_matches)
3730         (ada_add_global_exceptions): Use objfile_compunits.
3731
3732 2019-01-09  Tom Tromey  <tom@tromey.com>
3733
3734         * source.c (select_source_symtab)
3735         (forget_cached_source_info_for_objfile): Remove declaration.
3736         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3737         declaration.
3738         * maint.c (count_symtabs_and_blocks): Remove declaration.
3739         * cp-support.c (add_symbol_overload_list_qualified): Remove
3740         declaration.
3741         * coffread.c (coff_symtab_read): Remove declaration.
3742         * symtab.c (lookup_symbol_in_objfile_symtabs)
3743         (basic_lookup_transparent_type_1): Use objfile_compunits.
3744         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3745         (info_sources_command, search_symbols)
3746         (default_collect_symbol_completion_matches_break_on)
3747         (make_source_files_completion_list): Remove declaration.
3748         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3749         (ada_collect_symbol_completion_matches)
3750         (ada_add_global_exceptions): Remove declaration.
3751         * linespec.c (iterate_over_all_matching_symtabs): Use
3752         objfile_compunits.
3753         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3754         (class objfile_compunits): New.
3755         (ALL_COMPUNITS): Use objfile_compunits.
3756         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3757         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3758         objfile_compunits.
3759         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3760
3761 2019-01-09  Tom Tromey  <tom@tromey.com>
3762
3763         * symtab.c (search_symbols)
3764         (default_collect_symbol_completion_matches_break_on): Use
3765         objfile_msymbols.
3766         * ada-lang.c (ada_lookup_simple_minsym)
3767         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3768         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3769         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3770         objfile_msymbols.
3771         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3772         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3773         * objc-lang.c (find_methods): Use objfile_msymbols.
3774         (info_selectors_command, info_classes_command): Likewise.
3775         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3776         * objfiles.h (class objfile_msymbols): New.
3777         (ALL_OBJFILE_MSYMBOLS): Remove.
3778         (ALL_MSYMBOLS): Remove.
3779
3780 2019-01-09  Tom Tromey  <tom@tromey.com>
3781
3782         * common/next-iterator.h (next_adapter): Add Iterator template
3783         parameter.
3784         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3785         (class all_objfiles_safe): New.
3786         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3787         * objfiles.c (put_objfile_before): Update comment.
3788         (add_separate_debug_objfile): Likewise.
3789         (free_all_objfiles): Use all_objfiles_safe.
3790         (objfile_purge_solibs): Likewise.
3791
3792 2019-01-09  Tom Tromey  <tom@tromey.com>
3793
3794         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3795         (expand_symtab_containing_pc, lookup_static_symbol)
3796         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3797         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3798         all_objfiles.
3799         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3800         * breakpoint.c (create_overlay_event_breakpoint)
3801         (create_longjmp_master_breakpoint)
3802         (create_std_terminate_master_breakpoint)
3803         (create_exception_master_breakpoint): Use all_objfiles.
3804         * linux-thread-db.c (try_thread_db_load_from_pdir)
3805         (has_libpthread): Use all_objfiles.
3806         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3807         * linespec.c (iterate_over_all_matching_symtabs)
3808         (search_minsyms_for_name): Use all_objfiles.
3809         * maint.c (maintenance_info_sections): Use all_objfiles.
3810         * main.c (captured_main_1): Use all_objfiles.
3811         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3812         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3813         * guile/scm-pretty-print.c
3814         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3815         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3816         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3817         (maintenance_print_msymbols): Use all_objfiles.
3818         * source.c (select_source_symtab): Use all_objfiles.
3819         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3820         * symfile.c (remove_symbol_file_command)
3821         (expand_symtabs_matching, map_symbol_filenames): Use
3822         all_objfiles.
3823         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3824         all_objfiles.
3825         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3826         * objc-lang.c (find_methods): Use all_objfiles.
3827         * objfiles.c (have_partial_symbols, have_full_symbols)
3828         (have_minimal_symbols, qsort_cmp)
3829         (default_iterate_over_objfiles_in_search_order): Use
3830         all_objfiles.
3831         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3832         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3833         (maintenance_check_psymtabs): Use all_objfiles.
3834         (ALL_PSYMTABS): Remove.
3835         * compile/compile-object-run.c (do_module_cleanup): Use
3836         all_objfiles.
3837         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3838         * cp-support.c (add_symbol_overload_list_qualified): Use
3839         all_objfiles.
3840         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3841         Use all_objfiles.
3842         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3843         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3844         all_objfiles.
3845         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3846         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3847         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3848         Uses all_objfiles.
3849         * solib.c (solib_read_symbols): Use all_objfiles
3850
3851 2019-01-09  Tom Tromey  <tom@tromey.com>
3852
3853         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3854         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3855         all_objfiles.
3856         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3857         * symmisc.c (print_symbol_bcache_statistics)
3858         (print_objfile_statistics, maintenance_print_objfiles)
3859         (maintenance_info_symtabs, maintenance_check_symtabs)
3860         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3861         all_objfiles.
3862         * source.c (forget_cached_source_info): Use all_objfiles.
3863         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3864         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3865         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3866         * objfiles.c (update_section_map): Use all_objfiles.
3867         (shared_objfile_contains_address_p): Likewise.
3868         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3869         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3870
3871 2019-01-09  Tom Tromey  <tom@tromey.com>
3872
3873         * common/next-iterator.h: New file.
3874         * objfiles.h (class all_objfiles): New.
3875         (struct objfile_iterator): New.
3876
3877 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3878
3879         * NEWS: Move the description of the changed "frame", "select-frame",
3880          and "info frame" commands to the Changed commands section.
3881
3882 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3883
3884         * gdbtypes.c (check_stub_method_group): Remove handling of old
3885         mangling schemes.
3886         * linespec.c (find_methods): Likewise.
3887         * stabsread.c (read_member_functions): Likewise.
3888         * valops.c (search_struct_method): Likewise.
3889         (value_struct_elt_for_reference): Likewise.
3890         * NEWS: Mention this change.
3891
3892 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3893
3894         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3895         print_source_lines.
3896         * source.c (print_source_lines_base): Update line number check.
3897         (print_source_lines): New function.
3898         (source_lines_range::source_lines_range): New function.
3899         * source.h (class source_lines_range): New class.
3900         (print_source_lines): New declaration.
3901
3902 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3903
3904         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3905
3906 2019-01-08  Tom Tromey  <tom@tromey.com>
3907             Simon Marchi  <simon.marchi@ericsson.com>
3908
3909         PR gdb/24060
3910         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3911         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3912         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3913         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3914         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3915         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3916
3917 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3918
3919         * source.c (select_source_symtab): Move header comment to
3920         declaration in source.h.
3921         (forget_cached_source_info_for_objfile): Likewise.
3922         (forget_cached_source_info): Likewise.
3923         (identify_source_line): Likewise.
3924         * source.h (identify_source_line): Move declaration from symtab.h
3925         and add comment from source.c
3926         (print_source_lines): Likewise.
3927         (forget_cached_source_info_for_objfile): Likewise.
3928         (forget_cached_source_info): Likewise.
3929         (select_source_symtab): Likewise.
3930         (enum print_source_lines_flag): Move definition from symtab.h.
3931         * symtab.h (identify_source_line): Move declaration to source.h.
3932         (print_source_lines): Likewise.
3933         (forget_cached_source_info_for_objfile): Likewise.
3934         (forget_cached_source_info): Likewise.
3935         (select_source_symtab): Likewise.
3936         (enum print_source_lines_flag): Move definition to source.h.
3937         * tui/tui-hooks.c: Add 'source.h' include.
3938
3939 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3940
3941         * source.c (print_source_lines_base): Handle requests to print
3942         reverse line number sequences, and guard against empty lines
3943         string.
3944
3945 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3946
3947         * source.c (print_source_lines_base): Fix skip of '\r' if next
3948         character is '\n'.
3949
3950 2019-01-06  Tom Tromey  <tom@tromey.com>
3951
3952         * c-exp.y (struct c_parse_state) <macro_original_text,
3953         expansion_obstack>: New member.
3954         (macro_original_text, expansion_obstack): Remove globals.
3955         (scan_macro_expansion, scanning_macro_expansion)
3956         (finished_macro_expansion): Update.
3957         (scan_macro_cleanup): Remove.
3958         (yylex, c_parse): Update.
3959
3960 2019-01-06  Tom Tromey  <tom@tromey.com>
3961
3962         * c-exp.y (struct c_parse_state) <strings>: New member.
3963         (operator_stoken): Update.
3964
3965 2019-01-06  Tom Tromey  <tom@tromey.com>
3966
3967         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3968         (union type_stack_elt) <typelist_val>: Now a pointer to
3969         std::vector.
3970         (type_stack_cleanup): Don't declare.
3971         (push_typelist): Update.
3972         * parse.c (pop_typelist): Return a std::vector.
3973         (push_typelist): Take a std::vector.
3974         (follow_types): Update.  Do not free args.
3975         (type_stack_cleanup): Remove.
3976         * c-exp.y (struct c_parse_state): New.
3977         (cpstate): New global.
3978         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3979         (nonempty_typelist): Update.
3980         (func_mod): Create a new vector.
3981         (c_parse): Create a c_parse_state.
3982         (check_parameter_typelist): Do not delete params.
3983         (function_method): Update.  Do not delete type_list.
3984
3985 2019-01-06  Tom Tromey  <tom@tromey.com>
3986
3987         PR gdb/28155:
3988         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3989         check_typedef.
3990         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3991         (print_return_value): Likewise.
3992
3993 2019-01-05  Tom Tromey  <tom@tromey.com>
3994
3995         * contrib/cleanup_check.py: Remove.
3996         * contrib/gcc-with-excheck: Remove.
3997         * contrib/exsummary.py: Remove.
3998         * contrib/excheck.py: Remove.
3999
4000 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
4001
4002         * thread.c (delete_thread_1): Add gdb_assert that THR is not
4003         NULL. Initialize tpprev to NULL instead of assigning it
4004         to NULL on the next statement.
4005         * windows-nat.c (windows_delete_thread): Remove check for
4006         main_thread_id before printing thread exit notifications.
4007         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
4008         Remove thread ID check against main_thread_id.
4009         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
4010         windows_delete_thread.
4011         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
4012
4013 2019-01-04  Tom Tromey  <tom@tromey.com>
4014
4015         * compile/compile.c (_initialize_compile): Use upper case for
4016         metasyntactic variables.
4017         * symmisc.c (_initialize_symmisc): Use upper case for
4018         metasyntactic variables.
4019         * psymtab.c (_initialize_psymtab): Use upper case for
4020         metasyntactic variables.
4021         * demangle.c (demangle_command): Use upper case for metasyntactic
4022         variables.
4023         (_initialize_demangler): Likewise.
4024         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
4025         variables.
4026
4027 2019-01-03  Tom Tromey  <tom@tromey.com>
4028
4029         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
4030
4031 2019-01-03  Tom Tromey  <tom@tromey.com>
4032
4033         * python/py-symtab.c (salpy_str): Update.
4034         (struct salpy_sal_object) <symtab>: Now a PyObject.
4035         (salpy_dealloc): Update.
4036         (del_objfile_sal): Use gdbpy_ref.
4037
4038 2019-01-03  Tom Tromey  <tom@tromey.com>
4039
4040         * python/py-type.c (convert_field): Use new_reference.  Return
4041         gdbpy_ref.
4042         (make_fielditem): Return gdbpy_ref.
4043         (typy_fields): Update.
4044         (typy_getitem): Update.
4045         (field_name): Return gdbpy_ref.  Use new_reference.
4046         (typy_iterator_iternext): Update.
4047
4048 2019-01-03  Tom Tromey  <tom@tromey.com>
4049
4050         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
4051
4052 2019-01-03  Tom Tromey  <tom@tromey.com>
4053
4054         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
4055         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
4056         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
4057         (pspy_set_frame_filters, pspy_set_frame_unwinders)
4058         (pspy_set_type_printers): Likewise.
4059         * python/py-function.c (fnpy_init): Use gdbpy_ref.
4060         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
4061         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
4062         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
4063         (objfpy_set_type_printers): Likewise.
4064
4065 2019-01-03  Tom Tromey  <tom@tromey.com>
4066
4067         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
4068         (gdbpy_print_stack): Use gdbpy_err_fetch.
4069         * python/python-internal.h (class gdbpy_err_fetch): New class.
4070         (class gdbpy_enter) <m_error_type, m_error_value,
4071         m_error_traceback>: Remove.
4072         <m_error>: New member.
4073         (gdbpy_exception_to_string): Don't declare.
4074         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
4075         * python/py-value.c (convert_value_from_python): Use
4076         gdbpy_err_fetch.
4077         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
4078         gdbpy_exception_to_string.
4079         (gdbpy_handle_exception): Use gdbpy_err_fetch.
4080         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
4081         gdbpy_err_fetch.
4082
4083 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4084
4085         * linux-nat.c (delete_lwp_cleanup): Delete.
4086         (struct lwp_deleter): New struct.
4087         (lwp_info_up): New typedef.
4088         (linux_nat_target::follow_fork): Delete cleanup, and make use of
4089         lwp_info_up.
4090
4091 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4092
4093         * linux-fork.c (class scoped_switch_fork_info): New class.
4094         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
4095
4096 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4097
4098         * valops.c (find_overload_match): Remove use of null_cleanup, and
4099         calls to do_cleanups.
4100
4101 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4102
4103         * compile/compile-cplus-types.c
4104         (compile_cplus_instance::decl_name): Handle changes to
4105         cp_func_name.
4106         * cp-support.c (cp_func_name): Update header comment, update
4107         return type.
4108         * cp-support.h (cp_func_name): Update return type in declaration.
4109         * valops.c (find_overload_match): Move temp_func local to top
4110         level of function and change its type.  Use temp_func to hold and
4111         delete temporary string obtained from cp_func_name.
4112
4113 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4114
4115         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
4116         gdb::char_vector, remove cleanup, and update uses of `msg`.
4117
4118 2019-01-03  Jim Wilson  <jimw@sifive.com>
4119
4120         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
4121
4122 2019-01-02  Tom Tromey  <tom@tromey.com>
4123
4124         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
4125         (tdesc_parse_xml): Remove cleanups.
4126         * target-descriptions.h (make_cleanup_free_target_description):
4127         Don't declare.
4128         (target_desc_deleter): New struct.
4129         (target_desc_up): New typedef.
4130         * target-descriptions.c (target_desc_deleter::operator()): Rename
4131         from free_target_description.
4132         (make_cleanup_free_target_description): Remove.
4133
4134 2019-01-02  Tom Tromey  <tom@tromey.com>
4135
4136         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
4137         constructor, destructor.
4138         (linespec_parser): Remove typedef.
4139         (~linespec_parser): Rename from linespec_parser_delete.
4140         (linespec_lex_to_end, linespec_complete_label)
4141         (linespec_complete): Update.
4142         (decode_line_full): Remove cleanups.
4143         (decode_line_1): Update.
4144
4145 2019-01-02  Tom Tromey  <tom@tromey.com>
4146
4147         * python/python-internal.h (inferior_to_inferior_object): Change
4148         return type.
4149         * python/py-exitedevent.c (create_exited_event_object): Update.
4150         * python/py-inferior.c (inferior_to_inferior_object): Return
4151         gdbpy_ref.
4152         (python_new_inferior, python_inferior_deleted)
4153         (thread_to_thread_object, delete_thread_object)
4154         (build_inferior_list, gdbpy_selected_inferior): Update.
4155         * python/py-infthread.c (create_thread_object): Update.  Also fail
4156         if inferior_to_inferior_object fails.
4157
4158 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
4159
4160         * inferior.h (class inferior) <displaced_step_state>: New field.
4161         * infrun.h (struct displaced_step_state): Move here from
4162         infrun.c.  Initialize fields, add constructor.
4163         <inf>: Remove field.
4164         <reset>: New method.
4165         * infrun.c (struct displaced_step_inferior_state): Move to
4166         infrun.h.
4167         (displaced_step_inferior_states): Remove.
4168         (get_displaced_stepping_state): Adust.
4169         (displaced_step_in_progress_any_inferior): Adjust.
4170         (displaced_step_in_progress_thread): Adjust.
4171         (displaced_step_in_progress): Adjust.
4172         (add_displaced_stepping_state): Remove.
4173         (get_displaced_step_closure_by_addr): Adjust.
4174         (remove_displaced_stepping_state): Remove.
4175         (infrun_inferior_exit): Call displaced_step_state.reset.
4176         (use_displaced_stepping): Don't check for NULL.
4177         (displaced_step_prepare_throw): Call
4178         get_displaced_stepping_state.
4179         (displaced_step_fixup): Don't check for NULL.
4180         (prepare_for_detach): Don't check for NULL.
4181
4182 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4183
4184         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
4185          in case of call that did not complete.
4186
4187 2019-01-02  Andrey Utkin  <autkin@undo.io>
4188
4189         * symfile.c (find_separate_debug_file): Fix search of debug files for
4190         remote debuggee.
4191
4192 2019-01-02  Tom Tromey  <tom@tromey.com>
4193
4194         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
4195         indentation.
4196         * python/py-frame.c (frapy_older): Remove cast.
4197         (frapy_newer): Likewise.
4198         * python/py-breakpoint.c (local_setattro): Remove cast.
4199         * python/py-arch.c (archpy_name): Remove local variable.
4200         * python/py-type.c (gdbpy_lookup_type): Remove cast.
4201
4202 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
4203
4204         * unittests/basic_string_view/element_access/char/empty.cc:
4205         Fix year range in copyright header.
4206
4207 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4208
4209         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
4210         Delete.
4211         <operator==>: Update with for removed field.
4212         <hash>: Likewise.
4213         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
4214         <isa_features>: ...this.
4215         <abi_features>: New field.
4216         (riscv_isa_flen): Update comment.
4217         (riscv_abi_xlen): New declaration.
4218         (riscv_abi_flen): New declaration.
4219         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
4220         isa_features.
4221         (riscv_abi_xlen): New function.
4222         (riscv_isa_flen): Update to get answer from isa_features.
4223         (riscv_abi_flen): New function.
4224         (riscv_has_fp_abi): Update to get answer from abi_features.
4225         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
4226         xlen and flen.
4227         (riscv_call_info) <xlen, flen>: Update comment.
4228         (riscv_call_arg_struct): Remove invalid assertions
4229         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
4230         is removed.
4231         (riscv_gdbarch_init): Gather isa features and abi features
4232         separately, ensure both match on the gdbarch when reusing an old
4233         gdbarch.  Relax an error check to allow 32-bit abi float to run on
4234         a target with 64-bit float hardware.
4235
4236 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4237
4238         * source.c (search_command_helper): Stop reverse search
4239         when line 1 has been searched.
4240
4241 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4242
4243         * record-full.c (record_full_base_target::close): Rewrite
4244         record_full_core_buf_list free logic.
4245
4246 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4247
4248         * break-catch-syscall.c (print_one_catch_syscall): xfree
4249         the last text.
4250
4251 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4252
4253         * top.c (print_gdb_version): Update Copyright year in version
4254         message.
4255
4256 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4257
4258         Update copyright year range in all GDB files.
4259
4260 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
4261
4262         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
4263
4264 For older changes see ChangeLog-2018.
4265 \f
4266 Local Variables:
4267 mode: change-log
4268 left-margin: 8
4269 fill-column: 74
4270 version-control: never
4271 coding: utf-8
4272 End:
4273