gdb/ChangeLog

   1 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
   2
   3         * linux-thread-db.c (try_thread_db_load_1): Change return type
   4         to bool.
   5         (try_thread_db_load): Likewise.
   6         (try_thread_db_load_from_pdir_1): Likewise.
   7         (try_thread_db_load_from_pdir): Likewise.
   8         (try_thread_db_load_from_sdir): Likewise.
   9         (try_thread_db_load_from_dir): Likewise.
  10         (thread_db_load_search): Likewise.
  11         (has_libpthread): Likewise.
  12         (thread_db_load): Likewise.
  13
  14 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
  15
  16         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
  17         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
  18         NULL, and complain/return if that's the case.
  19
  20 2019-05-15  John Darrington <john@darrington.wattle.id.au>
  21
  22         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
  23         (advance, posn, abstract_read_memory): New functions.
  24         [struct mem_read_abstraction]: New struct.
  25         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
  26
  27 2019-05-14  Tom Tromey  <tromey@adacore.com>
  28
  29         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
  30         value is not lval_memory.
  31
  32 2019-05-14  Tom Tromey  <tromey@adacore.com>
  33
  34         * solib.c (info_sharedlibrary_command): Style the file name.
  35
  36 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
  37
  38         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
  39         (aarch64_vnv_type): Likewise.
  40         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
  41         * common/tdesc.c: Likewise.
  42         * common/tdesc.h (enum tdesc_type_kind): Likewise.
  43         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
  44         * features/aarch64-fpu.xml: Add ieee half view.
  45         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
  46         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
  47         * gdbtypes.h (struct builtin_type): Likewise.
  48         (struct objfile_type): Likewise.
  49
  50 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
  51
  52         * language.c (language_sniff_from_mangled_name): Fix "langauge"
  53         typo.
  54         * location.h (string_to_event_location): Likewise.
  55
  56 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
  57
  58         GDB 8.3 released.
  59
  60 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
  61
  62         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
  63         New variable declaration.
  64         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
  65         New variable.
  66         (print_one_breakpoint): Use ui_out::test_flags and new global
  67         variable to compute use_fixed_output.
  68         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
  69         Remove.
  70         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
  71         (mi_multi_location_breakpoint_output_fixed): Remove.
  72         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
  73         new variable.
  74         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
  75         fix_multi_location_breakpoint_output flag if version >= 3.
  76         * ui-out.h (enum ui_out_flag)
  77         <fix_multi_location_breakpoint_output>: New enumerator.
  78
  79 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
  80
  81         * contrib/cc-with-tweaks.sh: Validate dwz's work.
  82
  83 2019-05-10  Tom Tromey  <tromey@adacore.com>
  84
  85         * ada-lang.c (catch_ada_completer): New function.
  86         (_initialize_ada_language): Use it.
  87
  88 2019-05-10  Tom Tromey  <tromey@adacore.com>
  89
  90         * thread.c (print_thread_info): Make "requested_threads" const.
  91         * gdbthread.h (print_thread_info): Make "requested_threads"
  92         const.
  93         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
  94         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
  95
  96 2019-05-08  Tom Tromey  <tom@tromey.com>
  97
  98         * gdbtypes.c (objfile_type_data): Change type.
  99         (objfile_type, _initialize_gdbtypes): Update.
 100
 101 2019-05-08  Tom Tromey  <tom@tromey.com>
 102
 103         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
 104         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
 105         (_initialize_dwarf2_frame): Update.
 106
 107 2019-05-08  Tom Tromey  <tom@tromey.com>
 108
 109         * objc-lang.c (objc_objfile_data): Change type.
 110         (find_methods): Update.
 111         (_initialize_objc_lang): Remove.
 112
 113 2019-05-08  Tom Tromey  <tom@tromey.com>
 114
 115         * stabsread.c (rs6000_builtin_type_data): Change type.
 116         (rs6000_builtin_type, _initialize_stabsread): Update.
 117
 118 2019-05-08  Tom Tromey  <tom@tromey.com>
 119
 120         * mips-tdep.c (mips_pdr_data): Remove.
 121         (_initialize_mips_tdep): Update.
 122
 123 2019-05-08  Tom Tromey  <tom@tromey.com>
 124
 125         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
 126         (hppa_init_objfile_priv_data, read_unwind_info)
 127         (find_unwind_entry, _initialize_hppa_tdep): Update.
 128
 129 2019-05-08  Tom Tromey  <tom@tromey.com>
 130
 131         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
 132         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
 133         on obstack.
 134         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
 135
 136 2019-05-08  Tom Tromey  <tom@tromey.com>
 137
 138         * mdebugread.c (basic_type_data): Change type.
 139         (basic_type, _initialize_mdebugread): Update.
 140
 141 2019-05-08  Tom Tromey  <tom@tromey.com>
 142
 143         * common/gdb_unique_ptr.h (struct noop_deleter): New.
 144
 145 2019-05-08  Tom Tromey  <tom@tromey.com>
 146
 147         * nto-tdep.c (nto_inferior_data_reg): Change type.
 148         (nto_inferior_data): Update.
 149         (nto_inferior_data_cleanup, nto_new_inferior_data)
 150         (_initialize_nto_tdep): Remove.
 151         * nto-tdep.h (struct nto_inferior_data): Add initializers.
 152
 153 2019-05-08  Tom Tromey  <tom@tromey.com>
 154
 155         * ada-lang.c (struct ada_inferior_data): Add initializers.
 156         (ada_inferior_data): Change type.
 157         (ada_inferior_data_cleanup): Remove.
 158         (get_ada_inferior_data, ada_inferior_exit)
 159         (struct ada_pspace_data): Add initializers, destructor.
 160         (ada_pspace_data_handle): Change type.
 161         (get_ada_pspace_data): Update.
 162         (ada_pspace_data_cleanup): Remove.
 163
 164 2019-05-08  Tom Tromey  <tom@tromey.com>
 165
 166         * coffread.c (struct coff_symfile_info): Add initializers.
 167         (coff_objfile_data_key): Move lower.  Change type.
 168         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
 169         Update.
 170         (coff_free_info): Remove.
 171
 172 2019-05-08  Tom Tromey  <tom@tromey.com>
 173
 174         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
 175         (fbsd_pspace_data_handle): Move lower.  Change type.
 176         (get_fbsd_pspace_data): Update.
 177         (fbsd_pspace_data_cleanup): Remove.
 178         (_initialize_fbsd_tdep): Update.
 179
 180 2019-05-08  Tom Tromey  <tom@tromey.com>
 181
 182         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
 183         (get_ada_tasks_pspace_data): Update.
 184         (ada_tasks_pspace_data_cleanup): Remove.
 185         (_initialize_tasks): Update.
 186         (ada_tasks_inferior_data_handle): Change type.
 187         (get_ada_tasks_inferior_data): Update.
 188         (ada_tasks_inferior_data_cleanup): Remove.
 189         (struct ada_tasks_pspace_data): Add initializers.
 190
 191 2019-05-08  Tom Tromey  <tom@tromey.com>
 192
 193         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
 194         * symfile-debug.c (debug_sym_get_probes): Change type.
 195         * stap-probe.c (handle_stap_probe):
 196         (stap_static_probe_ops::get_probes): Change type.
 197         * probe.h (class static_probe_ops) <get_probes>: Change type.
 198         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
 199         (parse_probes_in_pspace): Update.
 200         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
 201         Update.
 202         (any_static_probe_ops::get_probes): Change type.
 203         * elfread.c (elfread_data): New typedef.
 204         (probe_key): Change type.
 205         (elf_get_probes): Likewise.  Update.
 206         (probe_key_free): Remove.
 207         (_initialize_elfread): Update.
 208         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
 209         Change type.
 210         (dtrace_process_dof_probe, dtrace_process_dof)
 211         (dtrace_static_probe_ops::get_probe): Change type.
 212
 213 2019-05-08  Tom Tromey  <tom@tromey.com>
 214
 215         * xcoffread.c (struct xcoff_symfile_info): Rename from
 216         coff_symfile_info.  Add initializers.
 217         (xcoff_objfile_data_key): Move lower.  Change type.
 218         (XCOFF_DATA): Rewrite.
 219         (xcoff_free_info): Remove.
 220         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
 221         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
 222         (xcoff_initial_scan): Update.
 223
 224 2019-05-08  Tom Tromey  <tom@tromey.com>
 225
 226         * solib-svr4.c (struct svr4_info): Add initializers and
 227         destructor.
 228         <probes_table>: Now an htab_up.
 229         (solib_svr4_pspace_data): Change type.
 230         (free_probes_table): Simplify.
 231         (~svr4_info): Rename from svr4_pspace_data_cleanup.
 232         (get_svr4_info, probes_table_htab_remove_objfile_probes)
 233         (probes_table_remove_objfile_probes, register_solib_event_probe)
 234         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
 235         (_initialize_svr4_solib): Update.
 236
 237 2019-05-08  Tom Tromey  <tom@tromey.com>
 238
 239         * remote.c (remote_pspace_data): Change type.
 240         (remote_pspace_data_cleanup): Remove.
 241         (get_remote_exec_file, set_pspace_remote_exec_file)
 242         (_initialize_remote): Update.
 243
 244 2019-05-08  Tom Tromey  <tom@tromey.com>
 245
 246         * breakpoint.c (breakpoint_objfile_key): Change type.
 247         (get_breakpoint_objfile_data): Update.
 248         (free_breakpoint_objfile_data): Remove.
 249         (_initialize_breakpoint): Update.
 250
 251 2019-05-08  Tom Tromey  <tom@tromey.com>
 252
 253         * linux-tdep.c (struct linux_info): Add initializers.
 254         (linux_inferior_data): Move.  Change type.
 255         (invalidate_linux_cache_inf): Update.
 256         (linux_inferior_data_cleanup): Remove.
 257         (get_linux_inferior_data, _initialize_linux_tdep): Update.
 258
 259 2019-05-08  Tom Tromey  <tom@tromey.com>
 260
 261         * auxv.c (auxv_inferior_data): Move.  Change type.
 262         (auxv_inferior_data_cleanup): Remove.
 263         (invalidate_auxv_cache_inf): Rewrite.
 264         (get_auxv_inferior_data, _initialize_auxv): Update.
 265
 266 2019-05-08  Tom Tromey  <tom@tromey.com>
 267
 268         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
 269         (symfile_debug_objfile_data_key): Change type.
 270         (symfile_debug_installed, debug_qf_has_symbols)
 271         (debug_qf_find_last_source_symtab)
 272         (debug_qf_forget_cached_source_info)
 273         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
 274         (debug_qf_print_stats, debug_qf_dump)
 275         (debug_qf_expand_symtabs_for_function)
 276         (debug_qf_expand_all_symtabs)
 277         (debug_qf_expand_symtabs_with_fullname)
 278         (debug_qf_map_matching_symbols)
 279         (debug_qf_expand_symtabs_matching)
 280         (debug_qf_find_pc_sect_compunit_symtab)
 281         (debug_qf_map_symbol_filenames)
 282         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
 283         (debug_sym_new_init, debug_sym_init, debug_sym_read)
 284         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
 285         (debug_sym_read_linetable, debug_sym_relocate): Update.
 286         (symfile_debug_free_objfile): Remove.
 287         (install_symfile_debug_logging, _initialize_symfile_debug):
 288         Update.
 289
 290 2019-05-08  Tom Tromey  <tom@tromey.com>
 291
 292         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
 293         allocate_on_obstack.
 294         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
 295         (get_dwarf2_per_objfile): Update.
 296         (set_dwarf2_per_objfile): Remove.
 297         (dwarf2_has_info, dwarf2_get_section_info): Update.
 298         (dwarf2_free_objfile): Remove.
 299         (_initialize_dwarf2_read): Update.
 300
 301 2019-05-08  Tom Tromey  <tom@tromey.com>
 302
 303         * auto-load.c (struct auto_load_pspace_info): Add destructor and
 304         initializers.
 305         <unsupported_script_warning_printed,
 306         script_not_found_warning_printed>: Now bool.
 307         (auto_load_pspace_data): Change type.
 308         (~auto_load_pspace_info): Rename from
 309         auto_load_pspace_data_cleanup.
 310         (get_auto_load_pspace_data, init_loaded_scripts_info)
 311         (clear_section_scripts, maybe_print_unsupported_script_warning)
 312         (maybe_print_script_not_found_warning, _initialize_auto_load):
 313         Update.
 314
 315 2019-05-08  Tom Tromey  <tom@tromey.com>
 316
 317         * objfiles.c (objfile_pspace_info): Add destructor and
 318         initializers.
 319         (objfiles_pspace_data): Change type.
 320         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
 321         (get_objfile_pspace_data): Update.
 322         (objfiles_bfd_data): Change type.
 323         (get_objfile_bfd_data): Update.
 324         (objfile_bfd_data_free, _initialize_objfiles): Remove.
 325
 326 2019-05-08  Tom Tromey  <tom@tromey.com>
 327
 328         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
 329         Change type.
 330         (get_catch_syscall_inferior_data): Update.
 331         (catch_syscall_inferior_data_cleanup): Remove.
 332         (_initialize_break_catch_syscall): Update.
 333
 334 2019-05-08  Tom Tromey  <tom@tromey.com>
 335
 336         * inflow.c (struct terminal_info): Add destructor and
 337         initializers.
 338         (inflow_inferior_data): Change type.
 339         (~terminal_info): Rename from inflow_inferior_data_cleanup.
 340         (get_inflow_inferior_data, inflow_inferior_exit)
 341         (swap_terminal_info, _initialize_inflow): Update.
 342
 343 2019-05-08  Tom Tromey  <tom@tromey.com>
 344
 345         * target-dcache.c (target_dcache_cleanup): Remove.
 346         (target_dcache_aspace_key): Change type.
 347         (target_dcache_init_p, target_dcache_invalidate)
 348         (target_dcache_get, target_dcache_get_or_init)
 349         (_initialize_target_dcache): Update.
 350         * dcache.h (struct dcache_deleter): New.
 351
 352 2019-05-08  Tom Tromey  <tom@tromey.com>
 353
 354         * symtab.c (struct symbol_cache): Add destructor and
 355         initializers.
 356         (symbol_cache_key): Move.  Change type.
 357         (make_symbol_cache, free_symbol_cache): Remove.
 358         (get_symbol_cache): Update.
 359         (symbol_cache_cleanup): Remove.
 360         (ALL_PSPACES, symbol_cache_flush)
 361         (maintenance_print_symbol_cache)
 362         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
 363         Update.
 364
 365 2019-05-08  Tom Tromey  <tom@tromey.com>
 366
 367         * symtab.c (struct main_info): Add destructor and initializers.
 368         (main_progspace_key): Move.  Change type.
 369         (get_main_info): Update.
 370         (main_info_cleanup): Remove.
 371         (_initialize_symtab): Update.
 372
 373 2019-05-08  Tom Tromey  <tom@tromey.com>
 374
 375         * registry.h (DECLARE_REGISTRY): Define the _key class.
 376
 377 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 378
 379         * NEWS: Merge two 'New commands' sections.
 380
 381 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 382
 383         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 384         parameter and use Ada language definition instead.
 385         (ada_val_print_ptr): Remove unused language parameter.
 386         (ada_val_print_num): Remove language parameter and use Ada language
 387         definition instead.
 388         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 389         parameter.
 390         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 391         parameter and use Ada language definition instead.
 392         (ada_val_print_1): Update all ada_val_print_xxx calls.
 393         Remove language parameter.
 394         (ada_val_print): Update ada_val_print_1 call.
 395
 396 2019-05-08  Tom Tromey  <tromey@adacore.com>
 397
 398         * remote.c (remote_hw_watchpoint_limit)
 399         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 400         Now static.
 401
 402 2019-05-08  Tom Tromey  <tromey@adacore.com>
 403
 404         * maint.c (_initialize_maint_cmds): Move initialization code to
 405         remote.c.
 406         (watchdog, show_watchdog): Move to remote.c.
 407         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 408         "watchdog" static.
 409         (_initialize_remote): Move initialization code from maint.c.
 410         * defs.h (watchdog): Don't declare.
 411
 412 2019-05-08  Tom Tromey  <tromey@adacore.com>
 413
 414         * tui/tui-interp.c: Include main.h.
 415         * interps.c: Include main.h.
 416         * main.h (interpreter_p): Declare.
 417         * defs.h (interpreter_p): Don't declare.
 418
 419 2019-05-08  Tom Tromey  <tromey@adacore.com>
 420
 421         * dwarf2loc.c: Include dwarf2read.h.
 422         * defs.h (read_unsigned_leb128): Don't declare.
 423         * dwarf2read.h (read_unsigned_leb128): Declare.
 424
 425 2019-05-08  Tom Tromey  <tromey@adacore.com>
 426
 427         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 428         method.
 429
 430 2019-05-08  Tom Tromey  <tromey@adacore.com>
 431
 432         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 433         when no wrap column is set.
 434
 435 2019-05-08  Tom Tromey  <tromey@adacore.com>
 436
 437         * c-lang.c (c_get_string): Handle non-C-style arrays.
 438
 439 2019-05-08  Tom Tromey  <tromey@adacore.com>
 440
 441         * typeprint.c (print_offset_data::update): Print the bit offset,
 442         not the number of bits remaining.
 443
 444 2019-05-08  Tom Tromey  <tromey@adacore.com>
 445
 446         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 447         padding at end of comment.
 448
 449 2019-05-08  Tom Tromey  <tromey@adacore.com>
 450
 451         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 452         Compare main types.
 453
 454 2019-05-06  Tom Tromey  <tom@tromey.com>
 455
 456         * common/scoped_mmap.c: Include common-defs.h.
 457         * common/scoped_mmap.h: Don't include config.h.
 458
 459 2019-05-04  Tom Tromey  <tom@tromey.com>
 460
 461         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 462         (struct aarch64_call_info): Add initializers.
 463         <si>: Now a std::vector.
 464         (pass_on_stack, aarch64_push_dummy_call): Update.
 465
 466 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 467             Tom Tromey  <tom@tromey.com>
 468
 469         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 470         (ppc_threads): Now a std::vector.  Now static.
 471         (hwdebug_find_thread_points_by_tid)
 472         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 473         Update.
 474
 475 2019-05-04  Tom Tromey  <tom@tromey.com>
 476
 477         * arc-tdep.c (arc_tdesc_init): Return bool.
 478
 479 2019-05-04  Tom Tromey  <tom@tromey.com>
 480
 481         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 482         Use gdb_assert_not_reached.
 483
 484 2019-05-04  Tom Tromey  <tom@tromey.com>
 485
 486         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 487         "false".
 488
 489 2019-05-04  Tom Tromey  <tom@tromey.com>
 490
 491         * arc-tdep.c (arc_tdesc_init): Use bool.
 492
 493 2019-05-04  Tom Tromey  <tom@tromey.com>
 494
 495         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 496
 497 2019-05-04  Tom Tromey  <tom@tromey.com>
 498
 499         * cli/cli-cmds.c (valid_command_p): Return bool.
 500
 501 2019-05-04  Tom Tromey  <tom@tromey.com>
 502
 503         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 504         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 505
 506 2019-05-04  Raul Tambre  <raul@tambre.ee>
 507
 508         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 509         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 510         operator for comparison.
 511
 512 2019-05-04  Tom Tromey  <tom@tromey.com>
 513
 514         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 515         (lookup_partial_symbol, print_partial_symbols)
 516         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 517         (psymbol_compare): Update.
 518         (add_psymbol_to_bcache): Clear the entire psymbol.
 519         (maintenance_check_psymtabs): Update.
 520         * psympriv.h (struct partial_symbol): Don't derive from
 521         general_symbol_info.
 522         <obj_section, unrelocated_address, address,
 523         set_unrelocated_address>: Update.
 524         <ginfo>: New member.
 525         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 526         (debug_names::write_psymbols): Update.
 527
 528 2019-05-04  Tom de Vries  <tdevries@suse.de>
 529
 530         * contrib/cc-with-tweaks.sh: Support -n arg.
 531
 532 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 533
 534         * corelow.c (core_target::detach): Ensure frame cache and
 535         register caches are cleared.
 536         inferior.c (exit_inferior_1): Likewise.
 537
 538 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 539             Tom Tromey  <tom@tromey.com>
 540
 541         * dictionary.c (collate_pending_symbols_by_language): Remove
 542         "struct" from foreach.
 543         * symtab.c (lookup_global_symbol_from_objfile)
 544         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 545         foreach.
 546         * ser-tcp.c (net_open): Remove "struct" from foreach.
 547         * objfiles.c (objfile_relocate, objfile_rebase)
 548         (objfile_has_symbols): Remove "struct" from foreach.
 549         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 550         from foreach.
 551         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 552         foreach.
 553         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 554         "struct" from foreach.
 555         * ada-lang.c (create_excep_cond_exprs)
 556         (ada_exception_catchpoint_cond_string): Remove "struct" from
 557         foreach.
 558
 559 2019-05-03  Tom Tromey  <tromey@adacore.com>
 560
 561         * ada-exp.y (convert_char_literal): Check suffix of each
 562         enumerator.
 563
 564 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 565
 566         PR ada/21406:
 567         * ada-exp.y (yywrap): Don't define.
 568         * ada-lex.l (%option): Add noyywrap
 569         (yywrap): Remove.
 570
 571 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 572
 573         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 574         _WIN32_WINNT to the XP level, unless already defined to a higher
 575         level.
 576
 577         * unittests/parse-connection-spec-selftests.c:
 578         * ser-tcp.c:
 579         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 580         override.
 581
 582         * symfile.c (find_separate_debug_file): Remove colon from the
 583         drive spec of DOS/Windows file names of the target, so that the
 584         file name produced from DEBUGDIR and the target's directory will
 585         be valid on DOS/Windows systems.
 586
 587 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 588
 589         * rust-lang.c (val_print_struct): Handle printing structures
 590         containing strings.
 591
 592 2019-05-02  Tom Tromey  <tromey@adacore.com>
 593
 594         * valarith.c (_initialize_valarith): Remove.
 595
 596 2019-05-01  Tom Tromey  <tromey@adacore.com>
 597
 598         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 599         bitfields.
 600
 601 2019-05-01  Tom Tromey  <tromey@adacore.com>
 602
 603         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 604         for big-endian copies.
 605
 606 2019-04-30  Ali Tamur  <tamur@google.com>
 607         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 608         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 609         (read_3_bytes): New function.
 610
 611 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 612
 613         * windows-nat.c (main_thread_id): Delete.
 614         (handle_output_debug_string): Replace main_thread_id by
 615         current_event.dwThreadId.
 616         (fake_create_process): Likewise.
 617         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 618         Do not set main_thread_id.
 619         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 620         current_event.dwThreadId.
 621         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 622
 623 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 624
 625         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 626         Use current_event.dwThreadId instead of main_thread_id.
 627
 628 2019-04-30  Tom Tromey  <tromey@adacore.com>
 629
 630         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 631         (create_excep_cond_exprs): Iterate over program spaces.
 632         (ada_exception_catchpoint_cond_string): Examine all minimal
 633         symbols for exception types.
 634
 635 2019-04-30  Tom Tromey  <tromey@adacore.com>
 636
 637         PR c++/24470:
 638         * dwarf2read.c (process_structure_scope): Handle case where type
 639         has template parameters but no symbol was created.
 640
 641 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 642             Chris January  <chris.january@arm.com>
 643
 644         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 645         qualifier.
 646         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 647
 648 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 649
 650         * f-typeprint.c (f_print_type): Update rules for printing
 651         whitespace.
 652         (f_type_print_varspec_suffix): Likewise.
 653
 654 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 655             Chris January  <chris.january@arm.com>
 656
 657         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 658         function arguments.
 659
 660 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 661
 662         * f-lang.c (build_fortran_types): Change name of void type to
 663         lower case.
 664         * f-typeprint.c (f_type_print_base): Print the name of the void
 665         type, rather than a fixed string.
 666         * f-valprint.c (f_decorations): Use lower case void string.
 667
 668 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 669             Chris January  <chris.january@arm.com>
 670
 671         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 672         types for Fortran.
 673
 674 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 675             Chris January  <chris.january@arm.com>
 676             David Lecomber  <david.lecomber@arm.com>
 677
 678         * f-exp.y (BINOP_INTRINSIC): New token.
 679         (exp): New parser rule handling BINOP_INTRINSIC.
 680         (f77_keywords): Add new builtin procedures.
 681         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 682         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 683         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 684         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 685         (print_unop_subexp_f): New function.
 686         (print_binop_subexp_f): New function.
 687         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 688         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 689         (dump_subexp_body_f): Likewise.
 690         (operator_check_f): Likewise.
 691         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 692         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 693
 694 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 695
 696         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 697         UNOP_KIND.
 698         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 699         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 700         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 701         (operator_length_f): New fuction.
 702         (print_subexp_f): New function.
 703         (op_name_f): New function.
 704         (dump_subexp_body_f): New function.
 705         (operator_check_f): New function.
 706         (exp_descriptor_f): Replace standard expression handling functions
 707         with new functions.
 708         * gdb/fortran-operator.def: New file.
 709         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 710         * gdb/std-operator.def: Remove UNOP_KIND.
 711
 712 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 713
 714         * std-operator.def: Remove unbalanced, stray double quote
 715         character.
 716
 717 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 718             Chris January  <chris.january@arm.com>
 719             Daniel Everett  <daniel.everett@arm.com>
 720             Nick Forrington  <nick.forrington@arm.com>
 721             Richard Bunt  <richard.bunt@arm.com>
 722
 723         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 724         of depth when printing anonymous structs or unions.
 725         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 726         Don't print either the top-level value, or the children if the
 727         max-depth is exceeded.
 728         (ppscm_print_children): When printing the key of a map, allow one
 729         extra level of depth.
 730         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 731         print either the top-level value, or the children if the max-depth
 732         is exceeded.
 733         (print_children): When printing the key of a map, allow one extra
 734         level of depth.
 735         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 736         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 737         (user_print_options): Initialise max_depth field.
 738         (val_print_scalar_or_string_type_p): New function.
 739         (val_print): Check to see if the max depth has been reached.
 740         (val_print_check_max_depth): Define new function.
 741         (show_print_max_depth): New function.
 742         (_initialize_valprint): Add 'print max-depth' option.
 743         * valprint.h (struct value_print_options) <max_depth>: New field.
 744         (val_print_check_max_depth): Declare new function.
 745         * NEWS: Document new feature.
 746
 747 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 748
 749         * ada-lang.c (ada_language_defn): Initialise new field.
 750         * c-lang.c (c_is_string_type_p): New function.
 751         (c_language_defn): Initialise new field.
 752         (cplus_language_defn): Initialise new field.
 753         (asm_language_defn): Initialise new field.
 754         (minimal_language_defn): Initialise new field.
 755         * c-lang.h (c_is_string_type_p): Declare new function.
 756         * d-lang.c (d_language_defn): Initialise new field.
 757         * f-lang.c (f_is_string_type_p): New function.
 758         (f_language_defn): Initialise new field.
 759         * go-lang.c (go_is_string_type_p): New function.
 760         (go_language_defn): Initialise new field.
 761         * language.c (default_is_string_type_p): New function.
 762         (unknown_language_defn): Initialise new field.
 763         (auto_language_defn): Initialise new field.
 764         * language.h (struct language_defn) <la_is_string_type_p>: New
 765         member variable.
 766         (default_is_string_type_p): Declare new function.
 767         * m2-lang.c (m2_language_defn): Initialise new field.
 768         * objc-lang.c (objc_language_defn): Initialise new field.
 769         * opencl-lang.c (opencl_language_defn): Initialise new field.
 770         * p-lang.c (pascal_is_string_type_p): New function.
 771         (pascal_language_defn): Initialise new field.
 772         * rust-lang.c (rust_is_string_type_p): New function.
 773         (rust_language_defn): Initialise new field.
 774
 775 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 776
 777         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 778         New field.
 779         * ada-lang.c (ada_language_defn): Initialise new field.
 780         * c-lang.c (c_language_defn): Likewise.
 781         (cplus_language_defn): Likewise.
 782         (asm_language_defn): Likewise.
 783         (minimal_language_defn): Likewise.
 784         * d-lang.c (d_language_defn): Likewise.
 785         * f-lang.c (f_language_defn): Likewise.
 786         * go-lang.c (go_language_defn): Likewise.
 787         * language.c (unknown_language_defn): Likewise.
 788         (auto_language_defn): Likewise.
 789         * m2-lang.c (m2_language_defn): Likewise.
 790         * objc-lang.c (objc_language_defn): Likewise.
 791         * opencl-lang.c (opencl_language_defn): Likewise.
 792         * p-lang.c (pascal_language_defn): Likewise.
 793         * rust-lang.c (rust_language_defn): Likewise.
 794
 795 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 796
 797         * ada-lang.c (ada_is_character_type): Change return type to bool.
 798         (ada_is_string_type): Likewise.
 799         * ada-lang.h (ada_is_character_type): Update declaration
 800         (ada_is_string_type): Likewise.
 801
 802 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 803
 804         Support style in 'frame|thread apply'
 805
 806         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 807         * record.c (record_start, record_stop): Update callers of
 808         execute_command_to_string with false.
 809         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 810         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 811         methods.
 812         (class string_file): New constructor with term_out parameter.
 813         Override methods term_out and can_emit_style_escape.  New member
 814         term_out.
 815         (class stdio_file): Override can_emit_style_escape.
 816         (class tee_file): Override term_out and can_emit_style_escape.
 817         * utils.h (can_emit_style_escape): Remove.
 818         * utils.c (can_emit_style_escape): Likewise.
 819         Update all callers of can_emit_style_escape (SOMESTREAM) to
 820         SOMESTREAM->can_emit_style_escape.
 821         * source-cache.c (source_cache::get_source_lines): Likewise.
 822         * stack.c (frame_apply_command_count): Call execute_command_to_string
 823         passing the term_out characteristic of the current gdb_stdout.
 824         * thread.c (thr_try_catch_cmd): Likewise.
 825         * top.c (execute_command_to_string): pass term_out parameter
 826         to construct the string_file for the command output.
 827         * ui-file.c (term_cli_styling): New function (most code moved
 828         from utils.c can_emit_style_escape).
 829         (string_file::string_file, string_file::can_emit_style_escape,
 830         stdio_file::can_emit_style_escape, tee_file::term_out,
 831         tee_file::can_emit_style_escape): New functions.
 832
 833 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 834
 835         * NEWS: Mention the new set|show may-call-functions.
 836         * infcall.c (may_call_functions_p): New variable.
 837         (show_may_call_functions_p): New function.
 838         (call_function_by_hand_dummy): Throws an error if not
 839         may-call-functions.
 840         (_initialize_infcall): Call add_setshow_boolean_cmd for
 841         may-call-functions.
 842
 843 2019-04-25  Keith Seitz  <keiths@redhat.com>
 844
 845         PR c++/24367
 846         * cp-support.c (inspect_type): Don't attempt substitutions
 847         of symbol with the same name.
 848
 849 2019-04-25  Tom Tromey  <tromey@adacore.com>
 850
 851         PR gdb/24475:
 852         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 853         static.
 854
 855 2019-04-25  Tom Tromey  <tromey@adacore.com>
 856
 857         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 858         rvalue reference.
 859         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 860         (gdb_xml_parser::parse): Use std::move.
 861         * python/python-internal.h (gdbpy_convert_exception): Take a const
 862         reference.
 863         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 864         std::move.
 865         * python/py-utils.c (gdbpy_convert_exception): Take a const
 866         reference.
 867         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 868         Use std::move.
 869         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 870         Use std::move.
 871         * mi/mi-main.c (mi_print_exception): Take a const reference.
 872         * main.c (handle_command_errors): Take a const reference.
 873         * linespec.c (parse_linespec): Use std::move.
 874         * infcall.c (run_inferior_call): Use std::move.
 875         (call_function_by_hand_dummy): Use std::move.
 876         * exec.c (try_open_exec_file): Use std::move.
 877         * exceptions.h (exception_print, exception_fprintf)
 878         (exception_print_same): Update.
 879         * exceptions.c (print_exception, exception_print)
 880         (exception_fprintf, exception_print_same): Change parameters to
 881         const reference.
 882         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 883         * common/new-op.c: Use std::move.
 884         * common/common-exceptions.h (struct gdb_exception): Add move
 885         constructor.
 886         (struct gdb_exception_error, struct gdb_exception_quit, struct
 887         gdb_quit_bad_alloc): Change constructor to move constructor.
 888         (throw_exception): Change parameter to rvalue reference.
 889         * common/common-exceptions.c (throw_exception): Take rvalue
 890         reference.
 891         * cli/cli-interp.c (safe_execute_command): Use std::move.
 892         * breakpoint.c (insert_bp_location, location_to_sals): Use
 893         std::move.
 894
 895 2019-04-25  Tom Tromey  <tromey@adacore.com>
 896
 897         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 898         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 899         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 900         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 901         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 902         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 903         guile/scm-value.c: Use unpack.
 904         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 905         gdbscm_gdb_exception.
 906         (gdbscm_throw_gdb_exception): Likewise.
 907         (struct gdbscm_gdb_exception): New.
 908         (unpack): New function.
 909         (gdbscm_wrap): Use unpack.
 910
 911 2019-04-25  Tom Tromey  <tromey@adacore.com>
 912
 913         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 914         (gdb_rl_callback_handler): Use std::move.
 915         * common/common-exceptions.h (struct gdb_exception): Add move
 916         assignment operator.
 917         (throw_exception_sjlj): Change "exception" to const reference.
 918         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 919         (throw_exception_sjlj): Change "exception" to const reference.
 920
 921 2019-04-25  Tom Tromey  <tromey@adacore.com>
 922
 923         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 924         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 925         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 926         Update.
 927         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 928         Update.
 929         * mi/mi-interp.c (mi_interp::exec): Update.
 930         * linespec.c (parse_linespec): Update.
 931         * infcall.c (run_inferior_call): Update.
 932         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 933         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 934         (gdbscm_lookup_global_symbol): Update.
 935         * guile/scm-param.c (gdbscm_parameter_value): Update.
 936         * guile/scm-frame.c (gdbscm_frame_read_register)
 937         (gdbscm_frame_read_var): Update.
 938         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 939         * exec.c (try_open_exec_file): Update.
 940         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 941         (gdb_rl_callback_handler): Update.
 942         * common/common-exceptions.h (exception_none): Don't declare.
 943         * common/common-exceptions.c (exception_none): Don't define.
 944         (struct catcher) <exception>: Update.
 945         * cli/cli-interp.c (safe_execute_command): Update.
 946         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 947
 948 2019-04-25  Ali Tamur  <tamur@google.com>
 949
 950         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 951         (read_attribute_value): Likewise.
 952         (dwarf2_read_addr_index): Update comment.
 953         (read_str_index): Add DW_FORM_strx.
 954         (dwarf2_string_attr): Likewise.
 955         (dwarf2_const_value_attr): Likewise.
 956         (dump_die_shallow): Likewise.
 957         (dwarf2_fetch_constant_bytes): Likewise.
 958         (skip_form_bytes): Likewise.
 959         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 960
 961 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 962
 963         PR corefiles/11608
 964         PR corefiles/18187
 965         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 966         OFFSET.  Verify if current mapping contains an ELF header.
 967         (linux_find_memory_regions_full): Adjust call to
 968         dump_mapping_p.
 969
 970 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 971             Kang Li <kanglictf@gmail.com>
 972
 973         PR gdb/21600
 974
 975         * dwarf2-frame.c (read_initial_length): Be consistent about using
 976         unsigned representation of length.
 977         (decode_frame_entry_1): Likewise.  Check for wraparound of
 978         end pointer as well as buffer overflow.
 979
 980 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 981
 982         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 983         "vq".
 984
 985 2019-04-24  Tom Tromey  <tromey@adacore.com>
 986
 987         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 988
 989 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 990
 991         * s12z-tdep.c (s12z_unwind_pc): Delete.
 992         (s12z_unwind_sp): Delete.
 993         (s12z_gdbarch_init): Don't register deleted functions with
 994         gdbarch.
 995
 996 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 997
 998         * rl78-tdep.c (rl78_unwind_sp): Delete.
 999         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
1000
1001 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1002
1003         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
1004         (xstormy16_unwind_pc): Delete.
1005         (xstormy16_dummy_id): Delete.
1006         (xstormy16_gdbarch_init): Don't register deleted functions with
1007         gdbarch.
1008
1009 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1010
1011         * vax-tdep.c (vax_unwind_pc): Delete.
1012         (vax_gdbarch_init): Don't register deleted function with gdbarch.
1013
1014 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1015
1016         * v850-tdep.c (v850_unwind_sp): Delete.
1017         (v850_unwind_pc): Delete.
1018         (v850_dummy_id): Delete.
1019         (v850_gdbarch_init): Don't register deleted functions with
1020         gdbarch.
1021
1022 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1023
1024         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
1025         (tilegx_unwind_pc): Delete.
1026         (tilegx_unwind_dummy_id): Delete.
1027         (tilegx_gdbarch_init): Don't register deleted functions with
1028         gdbarch.
1029
1030 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1031
1032         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
1033         (tic6x_dummy_id): Delete.
1034         (tic6x_gdbarch_init): Don't register deleted functions with
1035         gdbarch.
1036
1037 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1038
1039         * sparc-tdep.c (sparc_unwind_pc): Delete.
1040         (sparc32_gdbarch_init): Don't register deleted function with
1041         gdbarch.
1042
1043 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1044
1045         * sh-tdep.c (sh_unwind_sp): Delete.
1046         (sh_unwind_pc): Delete.
1047         (sh_dummy_id): Delete.
1048         (sh_gdbarch_init): Don't register deleted functions with
1049         gdbarch.
1050
1051 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1052
1053         * score-tdep.c (score_unwind_sp): Delete.
1054         (score_unwind_pc): Delete.
1055         (score_dummy_id): Delete.
1056         (score_gdbarch_init): Don't register deleted functions with
1057         gdbarch.
1058
1059 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1060
1061         * rx-tdep.c (rx_unwind_pc): Delete.
1062         (rx_unwind_sp): Delete.
1063         (rx_dummy_id): Delete.
1064         (rx_gdbarch_init): Don't register deleted functions with
1065         gdbarch.  Update comment.
1066
1067 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1068
1069         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
1070         (rs6000_dummy_id): Delete.
1071         (rs6000_gdbarch_init): Don't register deleted functions with
1072         gdbarch.
1073
1074 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1075
1076         * or1k-tdep.c (or1k_dummy_id): Delete.
1077         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
1078
1079 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1080
1081         * nios2-tdep.c (nios2_dummy_id): Delete.
1082         (nios2_unwind_sp): Delete.
1083         (nios2_gdbarch_init): Don't register deleted functions with
1084         gdbarch.
1085
1086 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1087
1088         * nds32-tdep.c (nds32_dummy_id): Delete.
1089         (nds32_unwind_pc): Delete.
1090         (nds32_unwind_sp): Delete.
1091         (nds32_gdbarch_init): Don't register deleted functions with
1092         gdbarch.
1093
1094 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1095
1096         * msp430-tdep.c (msp430_unwind_pc): Delete.
1097         (msp430_unwind_sp): Delete.
1098         (msp430_dummy_id): Delete.
1099         (msp430_gdbarch_init): Don't register deleted functions with
1100         gdbarch.
1101
1102 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1103
1104         * moxie-tdep.c (moxie_unwind_sp): Delete.
1105         (moxie_unwind_pc): Delete.
1106         (moxie_dummy_id): Delete.
1107         (moxie_gdbarch_init): Don't register deleted functions with
1108         gdbarch.
1109
1110 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1111
1112         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1113         (mn10300_unwind_pc): Delete.
1114         (mn10300_unwind_sp): Delete.
1115         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1116         mn10300_unwind_sp.
1117         (mn10300_frame_unwind_init): Don't register deleted functions with
1118         gdbarch.
1119
1120 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1121
1122         * mep-tdep.c (mep_unwind_pc): Delete.
1123         (mep_unwind_sp): Delete.
1124         (mep_dummy_id): Delete.
1125         (mep_gdbarch_init): Don't register deleted functions with
1126         gdbarch.
1127
1128 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1129
1130         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1131         (m68hc11_unwind_sp): Delete.
1132         (m68hc11_gdbarch_init): Don't register deleted functions with
1133         gdbarch.
1134
1135 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1136
1137         * m32r-tdep.c (m32r_unwind_sp): Delete.
1138         (m32r_unwind_pc): Delete.
1139         (m32r_dummy_id): Delete.
1140         (m32r_gdbarch_init): Don't register deleted functions with
1141         gdbarch.
1142
1143 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1144
1145         * m32c-tdep.c (m32c_unwind_pc): Delete.
1146         (m32c_unwind_sp): Delete.
1147         (m32c_dummy_id): Delete.
1148         (m32c_gdbarch_init): Don't register deleted functions with
1149         gdbarch.
1150
1151 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1152
1153         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1154         (lm32_unwind_pc): Delete.
1155         (lm32_dummy_id): Delete.
1156         (lm32_gdbarch_init): Don't register deleted functions with
1157         gdbarch.
1158
1159 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1160
1161         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1162         (iq2000_unwind_pc): Delete.
1163         (iq2000_dummy_id): Delete.
1164         (iq2000_gdbarch_init): Don't register deleted functions with
1165         gdbarch.
1166
1167 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1168
1169         * nds32-tdep.c (nds32_type_align): Delete.
1170         (nds32_push_dummy_call): Use type_align instead.
1171
1172 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1173
1174         * arm-tdep.c (arm_type_align): Only handle vector override case.
1175         (arm_push_dummy_call): Use type_align.
1176         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1177
1178 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1179
1180         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1181         case.
1182         (pass_on_stack): Use type_align.
1183         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1184         function.
1185
1186 2019-04-23  Tom Tromey  <tromey@adacore.com>
1187
1188         * dwarf2read.c (line_header::file_name_at): Remove unused
1189         overload.
1190
1191 2019-04-23  Tom de Vries  <tdevries@suse.de>
1192
1193         PR gdb/24438
1194         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1195         invocation.
1196
1197
1198 2019-03-27  Ali Tamur  <tamur@google.com>
1199
1200         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1201         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1202         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1203         (dwarf_expr_context::get_addr_index): Likewise
1204         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1205         (symbol_needs_eval_context::get_addr_index): Likewise
1206         (disassemble_dwarf_expression): Add DW_OP_addrx
1207         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1208         (read_cutu_die_from_dwo): Update comment
1209         (skip_one_die): Add DW_FORM_addrx
1210         (read_attribute_value): Likewise
1211         (var_decode_location): Add DW_OP_addrx
1212         (dwarf2_const_value_attr): Add DW_FORM_addrx
1213         (dump_die_shallow): Likewise
1214         (dwarf2_fetch_constant_bytes): Likewise
1215         (decode_locdesc): Add DW_OP_addrx
1216         (skip_form_bytes): Add DW_FORM_addrx
1217
1218 2019-04-22  Ali Tamur  <tamur@google.com>
1219
1220         * MAINTAINERS (Write After Approval): Add self.
1221
1222 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1223
1224         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1225         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1226         (open_symbol_file_object): Likewise.
1227         (svr4_default_sos): Add info parameter.
1228         (svr4_read_so_list): Likewise.
1229         (svr4_current_sos_direct): Adjust functions calls to pass down
1230         info.
1231         (svr4_current_sos_1): Add info parameter.
1232         (svr4_current_sos): Call get_svr4_info, pass info down to
1233         svr4_current_sos_1.
1234         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1235         get_svr4_info.
1236         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1237         get_svr4_info.
1238         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1239         to get_svr4_info.
1240         (probes_table_remove_objfile_probes): Likewise.
1241         (register_solib_event_probe): Add info parameter.
1242         (solist_update_incremental): Pass info parameter down to
1243         svr4_read_so_list.
1244         (disable_probes_interface): Add info parameter.
1245         (svr4_handle_solib_event): Pass current_program_space to
1246         get_svr4_info.  Adjust disable_probes_interface cleanup.
1247         (svr4_create_probe_breakpoints): Add info parameter, pass it
1248         down to register_solib_event_probe.
1249         (svr4_create_solib_event_breakpoints): Add info parameter,
1250         pass it down to svr4_create_probe_breakpoints.
1251         (enable_break): Pass info down to
1252         svr4_create_solib_event_breakpoints.
1253         (svr4_solib_create_inferior_hook): Pass current_program_space to
1254         get_svr4_info.
1255         (svr4_clear_solib): Likewise.
1256
1257 2019-04-22  Pedro Alves  <palves@redhat.com>
1258
1259         * solib-svr4.c (svr4_free_objfile_observer): New.
1260         (probe_and_action::objfile): New field.
1261         (probes_table_htab_remove_objfile_probes)
1262         (probes_table_remove_objfile_probes): New functions.
1263         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1264         in the new probe_and_action.  Don't store the probe in 'lookup'.
1265         (svr4_create_probe_breakpoints): Pass objfile to
1266         register_solib_event_probe.
1267         (_initialize_svr4_solib): Register a free_objfile observer.
1268
1269 2019-04-19  Tom Tromey  <tom@tromey.com>
1270
1271         * common/queue.h: Remove.
1272
1273 2019-04-19  Tom Tromey  <tom@tromey.com>
1274
1275         * event-loop.c: Don't include "common/queue.h".
1276
1277 2019-04-19  Tom Tromey  <tom@tromey.com>
1278
1279         * remote.c (remote_target): Use delete.
1280         * remote-notif.h: Include <list>, not "common/queue.h".
1281         (notif_client_p): Remove typedef.
1282         (remote_notif_state): Add constructor, destructor, initializer.
1283         <notif_queue>: Now a std::list.
1284         (remote_notif_state_xfree): Don't declare.
1285         * remote-notif.c (remote_notif_process, handle_notification)
1286         (remote_notif_state_allocate): Update.
1287         (~remote_notif_state): Rename from remote_notif_state_xfree.
1288
1289 2019-04-19  Tom Tromey  <tom@tromey.com>
1290
1291         * symfile.c (reread_symbols): Update.
1292         * objfiles.c (objfile_register_static_link)
1293         (objfile_lookup_static_link): Update
1294         (~objfile) Don't delete static_links.
1295         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1296
1297 2019-04-19  Tom Tromey  <tom@tromey.com>
1298
1299         * type-stack.h (struct type_stack) <insert>: Constify string.
1300         * type-stack.c (type_stack::insert): Constify string.
1301         * gdbtypes.h (lookup_template_type): Update.
1302         (address_space_name_to_int): Update.
1303         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1304         const.
1305         (lookup_template_type): Make name const.
1306         * c-exp.y: Update rules.
1307         (lex_one_token, classify_name, classify_inner_name)
1308         (c_print_token): Update.
1309         * p-exp.y: Update rules.
1310         (yylex): Update.
1311         * f-exp.y: Update rules.
1312         (yylex): Update.
1313         * d-exp.y: Update rules.
1314         (lex_one_token, classify_name, classify_inner_name): Update.
1315         * parse.c (write_dollar_variable, copy_name): Return std::string.
1316         * parser-defs.h (copy_name): Change return type.
1317         * m2-exp.y: Update rules.
1318         (yylex): Update.
1319         * go-exp.y (lex_one_token): Update.
1320         Update rules.
1321         (classify_unsafe_function, classify_packaged_name)
1322         (classify_name, yylex): Update.
1323
1324 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1325
1326         * configure.ac: add --enable-source-highlight switch.
1327         * configure: Regenerate.
1328         * top.c (print_gdb_version): plumb --enable-source-highlight
1329         status to "show configuration".
1330
1331 2019-04-19  Tom Tromey  <tromey@adacore.com>
1332
1333         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1334         Check ADA_TYPE_P.
1335         (empty_record, ada_template_to_fixed_record_type_1)
1336         (template_to_static_fixed_type)
1337         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1338         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1339         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1340         macros.
1341
1342 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1343
1344         PR symtab/24423:
1345         * source.c (print_source_lines_base): Advance "iter" when a
1346         control character is seen.
1347
1348 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1349
1350         * inferior.h (struct infcall_suspend_state_deleter):
1351         Catch exception in destructor to avoid crash.
1352
1353 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1354
1355         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1356         close to the add_com "shell".
1357
1358 2019-04-18  Tom Tromey  <tromey@adacore.com>
1359
1360         * process-stratum-target.h (class process_stratum_target)
1361         <stratum>: Add "final".
1362
1363 2019-04-17  Tom Tromey  <tromey@adacore.com>
1364
1365         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1366         against nullptr before use.
1367
1368 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1369
1370         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1371
1372 2019-04-17  Jim Wilson  <jimw@sifive.com>
1373             Andrew Burgess  <andrew.burgess@embecosm.com>
1374
1375         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1376         code read might fail, assume 4-byte breakpoint in that case.
1377
1378 2019-04-15  Leszek Swirski  <leszeks@google.com>
1379
1380         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1381         rather than a hand-rolled POD check when checking for forced MEMORY
1382         classification.
1383
1384 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1385
1386         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1387         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1388         function.
1389         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1390         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1391         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1392         declaration.
1393
1394 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1395
1396         * aarch64-linux-nat.c
1397         (aarch64_linux_nat_target::thread_architecture): Add override.
1398         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1399         each VQ.
1400
1401 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1402
1403         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1404
1405 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1406
1407         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1408         target types of size 96-bits, add some additional comments, and
1409         check that the builtin type we found was the correct size.
1410
1411 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1412
1413         * utils.c (prompt_for_continue): Don't restore the styling at the
1414         end, as applied_style has the wrong value.  This fixes styling in
1415         long lists of file names that are interrupted by the "Continue?"
1416         prompt.
1417
1418 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1419
1420         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1421         * c-lang.c (c_language_defn): Likewise.
1422         (cplus_language_defn): Likewise.
1423         (asm_language_defn): Likewise.
1424         (minimal_language_defn): Likewise.
1425         * d-lang.c (d_language_defn): Likewise.
1426         * f-lang.c (f_language_defn): Likewise.
1427         * go-lang.c (go_language_defn): Likewise.
1428         * language.c (unknown_language_defn): Likewise.
1429         (auto_language_defn): Likewise.
1430         * language.h (struct language_defn): Remove la_magic field.
1431         (LANG_MAGIC): Delete.
1432         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1433         * objc-lang.c (objc_language_defn): Likewise.
1434         * opencl-lang.c (opencl_language_defn): Likewise.
1435         * p-lang.c (pascal_language_defn): Likewise.
1436         * rust-lang.c (rust_language_defn): Likewise.
1437
1438 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1439
1440         * riscv-tdep.c (riscv_type_align): New function.
1441         (riscv_type_alignment): Delete.
1442         (riscv_arg_location): Use 'type_align'.
1443         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1444
1445 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1446
1447         * gdbtypes.c (type_align): A struct with no non-static fields also
1448         has alignment of 1.
1449
1450 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1451
1452         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1453         component to 0.
1454         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1455         member.
1456         (riscv_struct_info::analyse): New implementation using new
1457         analyse_inner member function.
1458         (riscv_struct_info::field_offset): New member function.
1459         (riscv_struct_info::m_offsets): New member variable.
1460         (riscv_struct_info::analyse_inner): New private member function,
1461         takes the old implementation of riscv_struct_info::analyse but
1462         extended to track field offsets.
1463         (riscv_call_arg_struct): Update the struct folding special cases
1464         to handle cases where empty C++ structs, which are non-zero
1465         length, are found.
1466         (riscv_arg_location): Initialise the length of each location, a
1467         non-zero length now indicates the location is in use.
1468         (riscv_push_dummy_call): Allow for the first location having a
1469         non-zero offset when setting up arguments.
1470         (riscv_return_value): Likewise, but for return values.
1471
1472 2019-04-11  Tom Tromey  <tromey@adacore.com>
1473
1474         * utils.c (internal_vproblem): Make "msg" const.
1475
1476 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1477
1478         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1479         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1480         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1481         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1482
1483 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1484
1485         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1486         function.
1487         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1488         of amd64_collect_native_gregset.
1489         (amd64_linux_nat_target::store_registers): Likewise.
1490
1491 2019-04-10  Tom Tromey  <tom@tromey.com>
1492
1493         * symtab.c (lookup_global_symbol_from_objfile)
1494         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1495         * objfiles.h (class separate_debug_iterator): New.
1496         (class separate_debug_range): New.
1497         (struct objfile) <separate_debug_objfiles>: New method.
1498         (objfile_separate_debug_iterate): Don't declare.
1499         * objfiles.c (separate_debug_iterator::operator++): Rename from
1500         objfile_separate_debug_iterate.
1501         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1502         iterator.
1503         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1504         iterator.
1505
1506 2019-04-10  Tom Tromey  <tom@tromey.com>
1507
1508         * symfile.c (reread_symbols): Remove old comment.
1509         * objfiles.c (free_all_objfiles): Fix a typo.
1510
1511 2019-04-10  Tom Tromey  <tom@tromey.com>
1512
1513         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1514         * minsyms.c (lookup_minimal_symbol): Use foreach.
1515         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1516         (lookup_minimal_symbol_solib_trampoline): Likewise.
1517         * symfile.c (reread_symbols): Use foreach.
1518
1519 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1520             Tom Tromey  <tromey@adacore.com>
1521
1522         PR rust/24414:
1523         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1524         (rust_lex_int_test): Change "value" to be LONGEST.
1525         (rust_lex_tests): Add test for long integer literal.
1526
1527 2019-04-09  Tom Tromey  <tromey@adacore.com>
1528
1529         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1530         to bool.
1531         (extended_remote_target::attach): Update.
1532         (remote_target::remote_notice_new_inferior): Update.
1533         (remote_target::add_current_inferior_and_thread): Update.
1534         * inferior.c (exit_inferior_1): Use "false".
1535         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1536
1537 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1538
1539         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1540         the "start" command.
1541
1542 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1543
1544         * python/py-inferior.c (infpy_thread_from_thread_handle):
1545         Adjust comments to reflect renaming of thread_from_thread_handle
1546         to thread_from_handle.  Adjust keywords.  Fix type error message.
1547         (inferior_object_methods): Add thread_from_handle.  Retain
1548         thread_from_thread_handle, but mark it as deprecated.
1549
1550 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1551
1552         * gdbthread.h (find_thread_by_handle): Revise declaration.
1553         * thread.c (find_thread_by_handle): Likewise.  Adjust
1554         implementation too.
1555         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1556         support for buffer objects as handles.
1557
1558 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1559
1560         * python/py-infthread.c (thpy_thread_handle): New function.
1561         (thread_object_methods): Register thpy_thread_handle.
1562
1563 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1564
1565         * gdbthread.h (thread_to_thread_handle): Declare.
1566         * thread.c (gdbtypes.h): Include.
1567         (thread_to_thread_handle): New function.
1568
1569         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1570         (target_thread_info_to_thread_handle): Declare.
1571         * target.c (target_thread_info_to_thread_handle): New function.
1572         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1573         * target-delegates.c: Regenerate.
1574
1575         * linux-thread-db.c (class thread_db_target): Add method
1576         thread_info_to_thread_handle.
1577         (thread_db_target::thread_info_to_thread_handle): Define.
1578         * remote.c (class remote_target): Add new method
1579         thread_info_to_thread_handle.
1580         (remote_target::thread_info_to_thread_handle): Define.
1581
1582 2019-04-08  Pedro Alves  <palves@redhat.com>
1583
1584         * common/common-exceptions.c (throw_exception): Don't create
1585         named object to throw; throw directly.
1586         (throw_it): Likewise.  Don't initialize gdb_exception::message
1587         here, with new; pass FMT and AP to the ctor instead.
1588         * common/common-exceptions.h: Include <string>.
1589         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1590         const char *, va_list)): New ctor.  Use std::make_shared.
1591         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1592         errors)): Delete.
1593         (gdb_exception_error::gdb_exception_error(enum errors, const char
1594         *, va_list)): New.
1595         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1596         Add assertion.
1597         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1598         errors)): Delete.
1599         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1600         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1601         Add assertion.
1602
1603 2019-04-08  Tom Tromey  <tom@tromey.com>
1604
1605         * valops.c (value_rtti_indirect_type): Replace throw_exception
1606         with throw.
1607         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1608         with throw.
1609         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1610         throw.
1611         * target.c (target_translate_tls_address): Replace throw_exception
1612         with throw.
1613         * stack.c (frame_apply_command_count): Replace throw_exception
1614         with throw.
1615         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1616         throw.
1617         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1618         with throw.
1619         * rs6000-tdep.c (rs6000_frame_cache)
1620         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1621         * remote.c: Replace throw_exception with throw.
1622         * record-full.c (record_full_message, record_full_wait_1)
1623         (record_full_restore): Replace throw_exception with throw.
1624         * record-btrace.c:
1625         (get_thread_current_frame_id, record_btrace_start_replaying)
1626         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1627         (cmd_record_btrace_start): Replace throw_exception with throw.
1628         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1629         throw.
1630         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1631         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1632         * linespec.c:
1633         (find_linespec_symbols): Replace throw_exception with throw.
1634         * infrun.c (displaced_step_prepare, resume): Replace
1635         throw_exception with throw.
1636         * infcmd.c (post_create_inferior): Replace throw_exception with
1637         throw.
1638         * inf-loop.c (inferior_event_handler): Replace throw_exception
1639         with throw.
1640         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1641         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1642         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1643         (get_prev_frame_always, get_frame_pc_if_available)
1644         (get_frame_address_in_block_if_available, get_frame_language):
1645         Replace throw_exception with throw.
1646         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1647         throw_exception with throw.
1648         * eval.c (fetch_subexp_value, evaluate_var_value)
1649         (evaluate_funcall, evaluate_subexp_standard): Replace
1650         throw_exception with throw.
1651         * dwarf2loc.c (call_site_find_chain)
1652         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1653         Replace throw_exception with throw.
1654         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1655         with throw.
1656         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1657         throw.
1658         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1659         * completer.c (complete_line_internal): Replace throw_exception
1660         with throw.
1661         * compile/compile-object-run.c (compile_object_run): Replace
1662         throw_exception with throw.
1663         * cli/cli-script.c (process_next_line): Replace throw_exception
1664         with throw.
1665         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1666         (btrace_enable, btrace_maint_update_pt_packets): Replace
1667         throw_exception with throw.
1668         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1669         throw_exception with throw.
1670         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1671         throw_exception with throw.
1672         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1673         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1674         * aarch64-tdep.c (aarch64_make_prologue_cache)
1675         (aarch64_make_stub_cache): Replace throw_exception with throw.
1676
1677 2019-04-08  Tom Tromey  <tom@tromey.com>
1678
1679         * common/common-exceptions.c (throw_exception): Rename from
1680         throw_exception_cxx.  Remove old copy.  Make argument const.
1681         (throw_it): Create and throw exception objects directly.
1682         * common/common-exceptions.h (throw_exception): Make argument
1683         const.
1684         (struct gdb_exception_error): Add constructor.
1685         (struct gdb_exception_quit): Add constructor.
1686
1687 2019-04-08  Tom Tromey  <tom@tromey.com>
1688
1689         * common/common-exceptions.h (exception_rethrow): Don't declare.
1690         (TRY_SJLJ): Update comment.
1691         (TRY, CATCH, END_CATCH): Remove.
1692         * common/common-exceptions.c (exception_rethrow): Remove.
1693
1694 2019-04-08  Tom Tromey  <tom@tromey.com>
1695
1696         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1697         Remove.
1698         (gdb_exception_error): Rename from
1699         gdb_exception_RETURN_MASK_ERROR.
1700         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1701         (gdb_quit_bad_alloc): Update.
1702         * aarch64-tdep.c: Update.
1703         * ada-lang.c: Update.
1704         * ada-typeprint.c: Update.
1705         * ada-valprint.c: Update.
1706         * amd64-tdep.c: Update.
1707         * arch-utils.c: Update.
1708         * break-catch-throw.c: Update.
1709         * breakpoint.c: Update.
1710         * btrace.c: Update.
1711         * c-varobj.c: Update.
1712         * cli/cli-cmds.c: Update.
1713         * cli/cli-interp.c: Update.
1714         * cli/cli-script.c: Update.
1715         * common/common-exceptions.c: Update.
1716         * common/new-op.c: Update.
1717         * common/selftest.c: Update.
1718         * compile/compile-c-symbols.c: Update.
1719         * compile/compile-cplus-symbols.c: Update.
1720         * compile/compile-object-load.c: Update.
1721         * compile/compile-object-run.c: Update.
1722         * completer.c: Update.
1723         * corelow.c: Update.
1724         * cp-abi.c: Update.
1725         * cp-support.c: Update.
1726         * cp-valprint.c: Update.
1727         * darwin-nat.c: Update.
1728         * disasm-selftests.c: Update.
1729         * dtrace-probe.c: Update.
1730         * dwarf-index-cache.c: Update.
1731         * dwarf-index-write.c: Update.
1732         * dwarf2-frame-tailcall.c: Update.
1733         * dwarf2-frame.c: Update.
1734         * dwarf2loc.c: Update.
1735         * dwarf2read.c: Update.
1736         * eval.c: Update.
1737         * event-loop.c: Update.
1738         * event-top.c: Update.
1739         * exec.c: Update.
1740         * f-valprint.c: Update.
1741         * fbsd-tdep.c: Update.
1742         * frame-unwind.c: Update.
1743         * frame.c: Update.
1744         * gdbtypes.c: Update.
1745         * gnu-v3-abi.c: Update.
1746         * guile/guile-internal.h: Update.
1747         * guile/scm-block.c: Update.
1748         * guile/scm-breakpoint.c: Update.
1749         * guile/scm-cmd.c: Update.
1750         * guile/scm-disasm.c: Update.
1751         * guile/scm-frame.c: Update.
1752         * guile/scm-lazy-string.c: Update.
1753         * guile/scm-math.c: Update.
1754         * guile/scm-param.c: Update.
1755         * guile/scm-ports.c: Update.
1756         * guile/scm-pretty-print.c: Update.
1757         * guile/scm-symbol.c: Update.
1758         * guile/scm-symtab.c: Update.
1759         * guile/scm-type.c: Update.
1760         * guile/scm-value.c: Update.
1761         * i386-linux-tdep.c: Update.
1762         * i386-tdep.c: Update.
1763         * inf-loop.c: Update.
1764         * infcall.c: Update.
1765         * infcmd.c: Update.
1766         * infrun.c: Update.
1767         * jit.c: Update.
1768         * language.c: Update.
1769         * linespec.c: Update.
1770         * linux-fork.c: Update.
1771         * linux-nat.c: Update.
1772         * linux-tdep.c: Update.
1773         * linux-thread-db.c: Update.
1774         * main.c: Update.
1775         * mi/mi-cmd-break.c: Update.
1776         * mi/mi-cmd-stack.c: Update.
1777         * mi/mi-interp.c: Update.
1778         * mi/mi-main.c: Update.
1779         * objc-lang.c: Update.
1780         * p-valprint.c: Update.
1781         * parse.c: Update.
1782         * ppc-linux-tdep.c: Update.
1783         * printcmd.c: Update.
1784         * python/py-arch.c: Update.
1785         * python/py-breakpoint.c: Update.
1786         * python/py-cmd.c: Update.
1787         * python/py-finishbreakpoint.c: Update.
1788         * python/py-frame.c: Update.
1789         * python/py-framefilter.c: Update.
1790         * python/py-gdb-readline.c: Update.
1791         * python/py-inferior.c: Update.
1792         * python/py-infthread.c: Update.
1793         * python/py-lazy-string.c: Update.
1794         * python/py-linetable.c: Update.
1795         * python/py-objfile.c: Update.
1796         * python/py-param.c: Update.
1797         * python/py-prettyprint.c: Update.
1798         * python/py-progspace.c: Update.
1799         * python/py-record-btrace.c: Update.
1800         * python/py-record.c: Update.
1801         * python/py-symbol.c: Update.
1802         * python/py-type.c: Update.
1803         * python/py-unwind.c: Update.
1804         * python/py-utils.c: Update.
1805         * python/py-value.c: Update.
1806         * python/python.c: Update.
1807         * record-btrace.c: Update.
1808         * record-full.c: Update.
1809         * remote-fileio.c: Update.
1810         * remote.c: Update.
1811         * riscv-tdep.c: Update.
1812         * rs6000-aix-tdep.c: Update.
1813         * rs6000-tdep.c: Update.
1814         * rust-exp.y: Update.
1815         * rust-lang.c: Update.
1816         * s390-tdep.c: Update.
1817         * selftest-arch.c: Update.
1818         * solib-dsbt.c: Update.
1819         * solib-frv.c: Update.
1820         * solib-spu.c: Update.
1821         * solib-svr4.c: Update.
1822         * solib.c: Update.
1823         * sparc64-linux-tdep.c: Update.
1824         * stack.c: Update.
1825         * symfile-mem.c: Update.
1826         * symmisc.c: Update.
1827         * target.c: Update.
1828         * thread.c: Update.
1829         * top.c: Update.
1830         * tracefile-tfile.c: Update.
1831         * tui/tui.c: Update.
1832         * typeprint.c: Update.
1833         * unittests/cli-utils-selftests.c: Update.
1834         * unittests/parse-connection-spec-selftests.c: Update.
1835         * valops.c: Update.
1836         * valprint.c: Update.
1837         * value.c: Update.
1838         * varobj.c: Update.
1839         * windows-nat.c: Update.
1840         * x86-linux-nat.c: Update.
1841         * xml-support.c: Update.
1842
1843 2019-04-08  Tom Tromey  <tom@tromey.com>
1844
1845         * xml-support.c: Use C++ exception handling.
1846         * x86-linux-nat.c: Use C++ exception handling.
1847         * windows-nat.c: Use C++ exception handling.
1848         * varobj.c: Use C++ exception handling.
1849         * value.c: Use C++ exception handling.
1850         * valprint.c: Use C++ exception handling.
1851         * valops.c: Use C++ exception handling.
1852         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1853         handling.
1854         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1855         * typeprint.c: Use C++ exception handling.
1856         * tui/tui.c: Use C++ exception handling.
1857         * tracefile-tfile.c: Use C++ exception handling.
1858         * top.c: Use C++ exception handling.
1859         * thread.c: Use C++ exception handling.
1860         * target.c: Use C++ exception handling.
1861         * symmisc.c: Use C++ exception handling.
1862         * symfile-mem.c: Use C++ exception handling.
1863         * stack.c: Use C++ exception handling.
1864         * sparc64-linux-tdep.c: Use C++ exception handling.
1865         * solib.c: Use C++ exception handling.
1866         * solib-svr4.c: Use C++ exception handling.
1867         * solib-spu.c: Use C++ exception handling.
1868         * solib-frv.c: Use C++ exception handling.
1869         * solib-dsbt.c: Use C++ exception handling.
1870         * selftest-arch.c: Use C++ exception handling.
1871         * s390-tdep.c: Use C++ exception handling.
1872         * rust-lang.c: Use C++ exception handling.
1873         * rust-exp.y: Use C++ exception handling.
1874         * rs6000-tdep.c: Use C++ exception handling.
1875         * rs6000-aix-tdep.c: Use C++ exception handling.
1876         * riscv-tdep.c: Use C++ exception handling.
1877         * remote.c: Use C++ exception handling.
1878         * remote-fileio.c: Use C++ exception handling.
1879         * record-full.c: Use C++ exception handling.
1880         * record-btrace.c: Use C++ exception handling.
1881         * python/python.c: Use C++ exception handling.
1882         * python/py-value.c: Use C++ exception handling.
1883         * python/py-utils.c: Use C++ exception handling.
1884         * python/py-unwind.c: Use C++ exception handling.
1885         * python/py-type.c: Use C++ exception handling.
1886         * python/py-symbol.c: Use C++ exception handling.
1887         * python/py-record.c: Use C++ exception handling.
1888         * python/py-record-btrace.c: Use C++ exception handling.
1889         * python/py-progspace.c: Use C++ exception handling.
1890         * python/py-prettyprint.c: Use C++ exception handling.
1891         * python/py-param.c: Use C++ exception handling.
1892         * python/py-objfile.c: Use C++ exception handling.
1893         * python/py-linetable.c: Use C++ exception handling.
1894         * python/py-lazy-string.c: Use C++ exception handling.
1895         * python/py-infthread.c: Use C++ exception handling.
1896         * python/py-inferior.c: Use C++ exception handling.
1897         * python/py-gdb-readline.c: Use C++ exception handling.
1898         * python/py-framefilter.c: Use C++ exception handling.
1899         * python/py-frame.c: Use C++ exception handling.
1900         * python/py-finishbreakpoint.c: Use C++ exception handling.
1901         * python/py-cmd.c: Use C++ exception handling.
1902         * python/py-breakpoint.c: Use C++ exception handling.
1903         * python/py-arch.c: Use C++ exception handling.
1904         * printcmd.c: Use C++ exception handling.
1905         * ppc-linux-tdep.c: Use C++ exception handling.
1906         * parse.c: Use C++ exception handling.
1907         * p-valprint.c: Use C++ exception handling.
1908         * objc-lang.c: Use C++ exception handling.
1909         * mi/mi-main.c: Use C++ exception handling.
1910         * mi/mi-interp.c: Use C++ exception handling.
1911         * mi/mi-cmd-stack.c: Use C++ exception handling.
1912         * mi/mi-cmd-break.c: Use C++ exception handling.
1913         * main.c: Use C++ exception handling.
1914         * linux-thread-db.c: Use C++ exception handling.
1915         * linux-tdep.c: Use C++ exception handling.
1916         * linux-nat.c: Use C++ exception handling.
1917         * linux-fork.c: Use C++ exception handling.
1918         * linespec.c: Use C++ exception handling.
1919         * language.c: Use C++ exception handling.
1920         * jit.c: Use C++ exception handling.
1921         * infrun.c: Use C++ exception handling.
1922         * infcmd.c: Use C++ exception handling.
1923         * infcall.c: Use C++ exception handling.
1924         * inf-loop.c: Use C++ exception handling.
1925         * i386-tdep.c: Use C++ exception handling.
1926         * i386-linux-tdep.c: Use C++ exception handling.
1927         * guile/scm-value.c: Use C++ exception handling.
1928         * guile/scm-type.c: Use C++ exception handling.
1929         * guile/scm-symtab.c: Use C++ exception handling.
1930         * guile/scm-symbol.c: Use C++ exception handling.
1931         * guile/scm-pretty-print.c: Use C++ exception handling.
1932         * guile/scm-ports.c: Use C++ exception handling.
1933         * guile/scm-param.c: Use C++ exception handling.
1934         * guile/scm-math.c: Use C++ exception handling.
1935         * guile/scm-lazy-string.c: Use C++ exception handling.
1936         * guile/scm-frame.c: Use C++ exception handling.
1937         * guile/scm-disasm.c: Use C++ exception handling.
1938         * guile/scm-cmd.c: Use C++ exception handling.
1939         * guile/scm-breakpoint.c: Use C++ exception handling.
1940         * guile/scm-block.c: Use C++ exception handling.
1941         * guile/guile-internal.h: Use C++ exception handling.
1942         * gnu-v3-abi.c: Use C++ exception handling.
1943         * gdbtypes.c: Use C++ exception handling.
1944         * frame.c: Use C++ exception handling.
1945         * frame-unwind.c: Use C++ exception handling.
1946         * fbsd-tdep.c: Use C++ exception handling.
1947         * f-valprint.c: Use C++ exception handling.
1948         * exec.c: Use C++ exception handling.
1949         * event-top.c: Use C++ exception handling.
1950         * event-loop.c: Use C++ exception handling.
1951         * eval.c: Use C++ exception handling.
1952         * dwarf2read.c: Use C++ exception handling.
1953         * dwarf2loc.c: Use C++ exception handling.
1954         * dwarf2-frame.c: Use C++ exception handling.
1955         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1956         * dwarf-index-write.c: Use C++ exception handling.
1957         * dwarf-index-cache.c: Use C++ exception handling.
1958         * dtrace-probe.c: Use C++ exception handling.
1959         * disasm-selftests.c: Use C++ exception handling.
1960         * darwin-nat.c: Use C++ exception handling.
1961         * cp-valprint.c: Use C++ exception handling.
1962         * cp-support.c: Use C++ exception handling.
1963         * cp-abi.c: Use C++ exception handling.
1964         * corelow.c: Use C++ exception handling.
1965         * completer.c: Use C++ exception handling.
1966         * compile/compile-object-run.c: Use C++ exception handling.
1967         * compile/compile-object-load.c: Use C++ exception handling.
1968         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1969         * compile/compile-c-symbols.c: Use C++ exception handling.
1970         * common/selftest.c: Use C++ exception handling.
1971         * common/new-op.c: Use C++ exception handling.
1972         * cli/cli-script.c: Use C++ exception handling.
1973         * cli/cli-interp.c: Use C++ exception handling.
1974         * cli/cli-cmds.c: Use C++ exception handling.
1975         * c-varobj.c: Use C++ exception handling.
1976         * btrace.c: Use C++ exception handling.
1977         * breakpoint.c: Use C++ exception handling.
1978         * break-catch-throw.c: Use C++ exception handling.
1979         * arch-utils.c: Use C++ exception handling.
1980         * amd64-tdep.c: Use C++ exception handling.
1981         * ada-valprint.c: Use C++ exception handling.
1982         * ada-typeprint.c: Use C++ exception handling.
1983         * ada-lang.c: Use C++ exception handling.
1984         * aarch64-tdep.c: Use C++ exception handling.
1985
1986 2019-04-08  Tom Tromey  <tom@tromey.com>
1987
1988         * xml-support.c (gdb_xml_parser::parse): Update.
1989         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1990         * value.c (show_convenience): Update.
1991         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1992         (test_parse_flags_qcs): Update.
1993         * thread.c (thr_try_catch_cmd): Update.
1994         * target.c (target_translate_tls_address): Update.
1995         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1996         (info_frame_command_core, frame_apply_command_count): Update.
1997         * rust-exp.y (rust_lex_exception_test): Update.
1998         * riscv-tdep.c (riscv_print_one_register_info): Update.
1999         * remote.c (remote_target::enable_btrace): Update.
2000         * record-btrace.c (record_btrace_enable_warn): Update.
2001         * python/py-utils.c (gdbpy_convert_exception): Update.
2002         * printcmd.c (do_one_display, print_variable_and_value): Update.
2003         * mi/mi-main.c (mi_print_exception): Update.
2004         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
2005         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2006         * linux-nat.c (linux_nat_target::attach): Update.
2007         * linux-fork.c (class scoped_switch_fork_info): Update.
2008         * infrun.c (displaced_step_prepare): Update.
2009         * infcall.c (call_function_by_hand_dummy): Update.
2010         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
2011         * gnu-v3-abi.c (print_one_vtable): Update.
2012         * frame.c (get_prev_frame_always): Update.
2013         * f-valprint.c (info_common_command_for_block): Update.
2014         * exec.c (try_open_exec_file): Update.
2015         * exceptions.c (print_exception, exception_print)
2016         (exception_fprintf, exception_print_same): Update.
2017         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
2018         * dwarf-index-cache.c (index_cache::store)
2019         (index_cache::lookup_gdb_index): Update.
2020         * darwin-nat.c (maybe_cache_shell): Update.
2021         * cp-valprint.c (cp_print_value_fields): Update.
2022         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
2023         (gcc_cplus_symbol_address): Update.
2024         * compile/compile-c-symbols.c (gcc_convert_symbol)
2025         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
2026         * common/selftest.c: Update.
2027         * common/common-exceptions.h (struct gdb_exception) <message>: Now
2028         a std::string.
2029         (exception_try_scope_entry, exception_try_scope_exit): Don't
2030         declare.
2031         (struct exception_try_scope): Remove.
2032         (TRY): Don't use exception_try_scope.
2033         (struct gdb_exception): Add constructor, operator=.
2034         <what>: New method.
2035         (struct gdb_exception_RETURN_MASK_ALL)
2036         (struct gdb_exception_RETURN_MASK_ERROR)
2037         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
2038         (struct gdb_quit_bad_alloc): Update.
2039         * common/common-exceptions.c (exception_none): Change
2040         initializer.
2041         (struct catcher) <state, exception>: Initialize inline.
2042         <prev>: Remove member.
2043         (current_catcher): Remove.
2044         (catchers): New global.
2045         (exceptions_state_mc_init): Simplify.
2046         (catcher_pop): Remove.
2047         (exceptions_state_mc, exceptions_state_mc_catch): Update.
2048         (try_scope_depth, exception_try_scope_entry)
2049         (exception_try_scope_exit): Remove.
2050         (throw_exception_sjlj): Update.
2051         (exception_messages, exception_messages_size): Remove.
2052         (throw_it): Simplify.
2053         (gdb_exception_sliced_copy): Remove.
2054         (throw_exception_cxx): Update.
2055         * cli/cli-script.c (script_from_file): Update.
2056         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
2057         Update.
2058         * ada-valprint.c (ada_val_print): Update.
2059         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
2060         (create_excep_cond_exprs): Update.
2061
2062 2019-04-08  Tom Tromey  <tom@tromey.com>
2063
2064         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
2065         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
2066         (TRY, CATCH, END_CATCH): Remove some definitions.
2067         * common/common-exceptions.c: Don't use GDB_XCPT.
2068         (catcher_list_size): Remove.
2069         (throw_exception, throw_it): Simplify.
2070
2071 2019-04-05  Tom Tromey  <tom@tromey.com>
2072
2073         Revert the header-sorting patch.
2074         * ft32-tdep.c: Revert.
2075         * frv-tdep.c: Revert.
2076         * frv-linux-tdep.c: Revert.
2077         * frame.c: Revert.
2078         * frame-unwind.c: Revert.
2079         * frame-base.c: Revert.
2080         * fork-child.c: Revert.
2081         * findvar.c: Revert.
2082         * findcmd.c: Revert.
2083         * filesystem.c: Revert.
2084         * filename-seen-cache.h: Revert.
2085         * filename-seen-cache.c: Revert.
2086         * fbsd-tdep.c: Revert.
2087         * fbsd-nat.h: Revert.
2088         * fbsd-nat.c: Revert.
2089         * f-valprint.c: Revert.
2090         * f-typeprint.c: Revert.
2091         * f-lang.c: Revert.
2092         * extension.h: Revert.
2093         * extension.c: Revert.
2094         * extension-priv.h: Revert.
2095         * expprint.c: Revert.
2096         * exec.h: Revert.
2097         * exec.c: Revert.
2098         * exceptions.c: Revert.
2099         * event-top.c: Revert.
2100         * event-loop.c: Revert.
2101         * eval.c: Revert.
2102         * elfread.c: Revert.
2103         * dwarf2read.h: Revert.
2104         * dwarf2read.c: Revert.
2105         * dwarf2loc.c: Revert.
2106         * dwarf2expr.h: Revert.
2107         * dwarf2expr.c: Revert.
2108         * dwarf2-frame.c: Revert.
2109         * dwarf2-frame-tailcall.c: Revert.
2110         * dwarf-index-write.h: Revert.
2111         * dwarf-index-write.c: Revert.
2112         * dwarf-index-common.c: Revert.
2113         * dwarf-index-cache.h: Revert.
2114         * dwarf-index-cache.c: Revert.
2115         * dummy-frame.c: Revert.
2116         * dtrace-probe.c: Revert.
2117         * disasm.h: Revert.
2118         * disasm.c: Revert.
2119         * disasm-selftests.c: Revert.
2120         * dictionary.c: Revert.
2121         * dicos-tdep.c: Revert.
2122         * demangle.c: Revert.
2123         * dcache.h: Revert.
2124         * dcache.c: Revert.
2125         * darwin-nat.h: Revert.
2126         * darwin-nat.c: Revert.
2127         * darwin-nat-info.c: Revert.
2128         * d-valprint.c: Revert.
2129         * d-namespace.c: Revert.
2130         * d-lang.c: Revert.
2131         * ctf.c: Revert.
2132         * csky-tdep.c: Revert.
2133         * csky-linux-tdep.c: Revert.
2134         * cris-tdep.c: Revert.
2135         * cris-linux-tdep.c: Revert.
2136         * cp-valprint.c: Revert.
2137         * cp-support.c: Revert.
2138         * cp-namespace.c: Revert.
2139         * cp-abi.c: Revert.
2140         * corelow.c: Revert.
2141         * corefile.c: Revert.
2142         * continuations.c: Revert.
2143         * completer.h: Revert.
2144         * completer.c: Revert.
2145         * complaints.c: Revert.
2146         * coffread.c: Revert.
2147         * coff-pe-read.c: Revert.
2148         * cli-out.h: Revert.
2149         * cli-out.c: Revert.
2150         * charset.c: Revert.
2151         * c-varobj.c: Revert.
2152         * c-valprint.c: Revert.
2153         * c-typeprint.c: Revert.
2154         * c-lang.c: Revert.
2155         * buildsym.c: Revert.
2156         * buildsym-legacy.c: Revert.
2157         * build-id.h: Revert.
2158         * build-id.c: Revert.
2159         * btrace.c: Revert.
2160         * bsd-uthread.c: Revert.
2161         * breakpoint.h: Revert.
2162         * breakpoint.c: Revert.
2163         * break-catch-throw.c: Revert.
2164         * break-catch-syscall.c: Revert.
2165         * break-catch-sig.c: Revert.
2166         * blockframe.c: Revert.
2167         * block.c: Revert.
2168         * bfin-tdep.c: Revert.
2169         * bfin-linux-tdep.c: Revert.
2170         * bfd-target.c: Revert.
2171         * bcache.c: Revert.
2172         * ax-general.c: Revert.
2173         * ax-gdb.h: Revert.
2174         * ax-gdb.c: Revert.
2175         * avr-tdep.c: Revert.
2176         * auxv.c: Revert.
2177         * auto-load.c: Revert.
2178         * arm-wince-tdep.c: Revert.
2179         * arm-tdep.c: Revert.
2180         * arm-symbian-tdep.c: Revert.
2181         * arm-pikeos-tdep.c: Revert.
2182         * arm-obsd-tdep.c: Revert.
2183         * arm-nbsd-tdep.c: Revert.
2184         * arm-nbsd-nat.c: Revert.
2185         * arm-linux-tdep.c: Revert.
2186         * arm-linux-nat.c: Revert.
2187         * arm-fbsd-tdep.c: Revert.
2188         * arm-fbsd-nat.c: Revert.
2189         * arm-bsd-tdep.c: Revert.
2190         * arch-utils.c: Revert.
2191         * arc-tdep.c: Revert.
2192         * arc-newlib-tdep.c: Revert.
2193         * annotate.h: Revert.
2194         * annotate.c: Revert.
2195         * amd64-windows-tdep.c: Revert.
2196         * amd64-windows-nat.c: Revert.
2197         * amd64-tdep.c: Revert.
2198         * amd64-sol2-tdep.c: Revert.
2199         * amd64-obsd-tdep.c: Revert.
2200         * amd64-obsd-nat.c: Revert.
2201         * amd64-nbsd-tdep.c: Revert.
2202         * amd64-nbsd-nat.c: Revert.
2203         * amd64-nat.c: Revert.
2204         * amd64-linux-tdep.c: Revert.
2205         * amd64-linux-nat.c: Revert.
2206         * amd64-fbsd-tdep.c: Revert.
2207         * amd64-fbsd-nat.c: Revert.
2208         * amd64-dicos-tdep.c: Revert.
2209         * amd64-darwin-tdep.c: Revert.
2210         * amd64-bsd-nat.c: Revert.
2211         * alpha-tdep.c: Revert.
2212         * alpha-obsd-tdep.c: Revert.
2213         * alpha-nbsd-tdep.c: Revert.
2214         * alpha-mdebug-tdep.c: Revert.
2215         * alpha-linux-tdep.c: Revert.
2216         * alpha-linux-nat.c: Revert.
2217         * alpha-bsd-tdep.c: Revert.
2218         * alpha-bsd-nat.c: Revert.
2219         * aix-thread.c: Revert.
2220         * agent.c: Revert.
2221         * addrmap.c: Revert.
2222         * ada-varobj.c: Revert.
2223         * ada-valprint.c: Revert.
2224         * ada-typeprint.c: Revert.
2225         * ada-tasks.c: Revert.
2226         * ada-lang.c: Revert.
2227         * aarch64-tdep.c: Revert.
2228         * aarch64-ravenscar-thread.c: Revert.
2229         * aarch64-newlib-tdep.c: Revert.
2230         * aarch64-linux-tdep.c: Revert.
2231         * aarch64-linux-nat.c: Revert.
2232         * aarch64-fbsd-tdep.c: Revert.
2233         * aarch64-fbsd-nat.c: Revert.
2234         * aarch32-linux-nat.c: Revert.
2235
2236 2019-04-05  Tom Tromey  <tom@tromey.com>
2237
2238         * ft32-tdep.c: Sort headers.
2239         * frv-tdep.c: Sort headers.
2240         * frv-linux-tdep.c: Sort headers.
2241         * frame.c: Sort headers.
2242         * frame-unwind.c: Sort headers.
2243         * frame-base.c: Sort headers.
2244         * fork-child.c: Sort headers.
2245         * findvar.c: Sort headers.
2246         * findcmd.c: Sort headers.
2247         * filesystem.c: Sort headers.
2248         * filename-seen-cache.h: Sort headers.
2249         * filename-seen-cache.c: Sort headers.
2250         * fbsd-tdep.c: Sort headers.
2251         * fbsd-nat.h: Sort headers.
2252         * fbsd-nat.c: Sort headers.
2253         * f-valprint.c: Sort headers.
2254         * f-typeprint.c: Sort headers.
2255         * f-lang.c: Sort headers.
2256         * extension.h: Sort headers.
2257         * extension.c: Sort headers.
2258         * extension-priv.h: Sort headers.
2259         * expprint.c: Sort headers.
2260         * exec.h: Sort headers.
2261         * exec.c: Sort headers.
2262         * exceptions.c: Sort headers.
2263         * event-top.c: Sort headers.
2264         * event-loop.c: Sort headers.
2265         * eval.c: Sort headers.
2266         * elfread.c: Sort headers.
2267         * dwarf2read.h: Sort headers.
2268         * dwarf2read.c: Sort headers.
2269         * dwarf2loc.c: Sort headers.
2270         * dwarf2expr.h: Sort headers.
2271         * dwarf2expr.c: Sort headers.
2272         * dwarf2-frame.c: Sort headers.
2273         * dwarf2-frame-tailcall.c: Sort headers.
2274         * dwarf-index-write.h: Sort headers.
2275         * dwarf-index-write.c: Sort headers.
2276         * dwarf-index-common.c: Sort headers.
2277         * dwarf-index-cache.h: Sort headers.
2278         * dwarf-index-cache.c: Sort headers.
2279         * dummy-frame.c: Sort headers.
2280         * dtrace-probe.c: Sort headers.
2281         * disasm.h: Sort headers.
2282         * disasm.c: Sort headers.
2283         * disasm-selftests.c: Sort headers.
2284         * dictionary.c: Sort headers.
2285         * dicos-tdep.c: Sort headers.
2286         * demangle.c: Sort headers.
2287         * dcache.h: Sort headers.
2288         * dcache.c: Sort headers.
2289         * darwin-nat.h: Sort headers.
2290         * darwin-nat.c: Sort headers.
2291         * darwin-nat-info.c: Sort headers.
2292         * d-valprint.c: Sort headers.
2293         * d-namespace.c: Sort headers.
2294         * d-lang.c: Sort headers.
2295         * ctf.c: Sort headers.
2296         * csky-tdep.c: Sort headers.
2297         * csky-linux-tdep.c: Sort headers.
2298         * cris-tdep.c: Sort headers.
2299         * cris-linux-tdep.c: Sort headers.
2300         * cp-valprint.c: Sort headers.
2301         * cp-support.c: Sort headers.
2302         * cp-namespace.c: Sort headers.
2303         * cp-abi.c: Sort headers.
2304         * corelow.c: Sort headers.
2305         * corefile.c: Sort headers.
2306         * continuations.c: Sort headers.
2307         * completer.h: Sort headers.
2308         * completer.c: Sort headers.
2309         * complaints.c: Sort headers.
2310         * coffread.c: Sort headers.
2311         * coff-pe-read.c: Sort headers.
2312         * cli-out.h: Sort headers.
2313         * cli-out.c: Sort headers.
2314         * charset.c: Sort headers.
2315         * c-varobj.c: Sort headers.
2316         * c-valprint.c: Sort headers.
2317         * c-typeprint.c: Sort headers.
2318         * c-lang.c: Sort headers.
2319         * buildsym.c: Sort headers.
2320         * buildsym-legacy.c: Sort headers.
2321         * build-id.h: Sort headers.
2322         * build-id.c: Sort headers.
2323         * btrace.c: Sort headers.
2324         * bsd-uthread.c: Sort headers.
2325         * breakpoint.h: Sort headers.
2326         * breakpoint.c: Sort headers.
2327         * break-catch-throw.c: Sort headers.
2328         * break-catch-syscall.c: Sort headers.
2329         * break-catch-sig.c: Sort headers.
2330         * blockframe.c: Sort headers.
2331         * block.c: Sort headers.
2332         * bfin-tdep.c: Sort headers.
2333         * bfin-linux-tdep.c: Sort headers.
2334         * bfd-target.c: Sort headers.
2335         * bcache.c: Sort headers.
2336         * ax-general.c: Sort headers.
2337         * ax-gdb.h: Sort headers.
2338         * ax-gdb.c: Sort headers.
2339         * avr-tdep.c: Sort headers.
2340         * auxv.c: Sort headers.
2341         * auto-load.c: Sort headers.
2342         * arm-wince-tdep.c: Sort headers.
2343         * arm-tdep.c: Sort headers.
2344         * arm-symbian-tdep.c: Sort headers.
2345         * arm-pikeos-tdep.c: Sort headers.
2346         * arm-obsd-tdep.c: Sort headers.
2347         * arm-nbsd-tdep.c: Sort headers.
2348         * arm-nbsd-nat.c: Sort headers.
2349         * arm-linux-tdep.c: Sort headers.
2350         * arm-linux-nat.c: Sort headers.
2351         * arm-fbsd-tdep.c: Sort headers.
2352         * arm-fbsd-nat.c: Sort headers.
2353         * arm-bsd-tdep.c: Sort headers.
2354         * arch-utils.c: Sort headers.
2355         * arc-tdep.c: Sort headers.
2356         * arc-newlib-tdep.c: Sort headers.
2357         * annotate.h: Sort headers.
2358         * annotate.c: Sort headers.
2359         * amd64-windows-tdep.c: Sort headers.
2360         * amd64-windows-nat.c: Sort headers.
2361         * amd64-tdep.c: Sort headers.
2362         * amd64-sol2-tdep.c: Sort headers.
2363         * amd64-obsd-tdep.c: Sort headers.
2364         * amd64-obsd-nat.c: Sort headers.
2365         * amd64-nbsd-tdep.c: Sort headers.
2366         * amd64-nbsd-nat.c: Sort headers.
2367         * amd64-nat.c: Sort headers.
2368         * amd64-linux-tdep.c: Sort headers.
2369         * amd64-linux-nat.c: Sort headers.
2370         * amd64-fbsd-tdep.c: Sort headers.
2371         * amd64-fbsd-nat.c: Sort headers.
2372         * amd64-dicos-tdep.c: Sort headers.
2373         * amd64-darwin-tdep.c: Sort headers.
2374         * amd64-bsd-nat.c: Sort headers.
2375         * alpha-tdep.c: Sort headers.
2376         * alpha-obsd-tdep.c: Sort headers.
2377         * alpha-nbsd-tdep.c: Sort headers.
2378         * alpha-mdebug-tdep.c: Sort headers.
2379         * alpha-linux-tdep.c: Sort headers.
2380         * alpha-linux-nat.c: Sort headers.
2381         * alpha-bsd-tdep.c: Sort headers.
2382         * alpha-bsd-nat.c: Sort headers.
2383         * aix-thread.c: Sort headers.
2384         * agent.c: Sort headers.
2385         * addrmap.c: Sort headers.
2386         * ada-varobj.c: Sort headers.
2387         * ada-valprint.c: Sort headers.
2388         * ada-typeprint.c: Sort headers.
2389         * ada-tasks.c: Sort headers.
2390         * ada-lang.c: Sort headers.
2391         * aarch64-tdep.c: Sort headers.
2392         * aarch64-ravenscar-thread.c: Sort headers.
2393         * aarch64-newlib-tdep.c: Sort headers.
2394         * aarch64-linux-tdep.c: Sort headers.
2395         * aarch64-linux-nat.c: Sort headers.
2396         * aarch64-fbsd-tdep.c: Sort headers.
2397         * aarch64-fbsd-nat.c: Sort headers.
2398         * aarch32-linux-nat.c: Sort headers.
2399
2400 2019-04-04  Tom Tromey  <tom@tromey.com>
2401
2402         * varobj.c (varobj_create): Update.
2403         * rust-exp.y (struct rust_parser) <update_innermost_block,
2404         lookup_symbol>: New methods.
2405         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2406         Rename.
2407         (rust_parser::rust_lookup_type)
2408         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2409         * printcmd.c (display_command, do_one_display): Update.
2410         * parser-defs.h (struct parser_state) <parser_state>: Add
2411         "tracker" parameter.
2412         (block_tracker): New member.
2413         (class innermost_block_tracker) <innermost_block_tracker>: Add
2414         "types" parameter.
2415         <reset>: Remove method.
2416         (innermost_block): Don't declare.
2417         (null_post_parser): Update.
2418         * parse.c (innermost_block): Remove global.
2419         (write_dollar_variable): Update.
2420         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2421         Remove "tracker_types" parameter.
2422         (parse_expression): Add "tracker" parameter.
2423         (parse_expression_for_completion): Update.
2424         (null_post_parser): Add "tracker" parameter.
2425         * p-exp.y: Update rules.
2426         * m2-exp.y: Update rules.
2427         * language.h (struct language_defn) <la_post_parser>: Add
2428         "tracker" parameter.
2429         * go-exp.y: Update rules.
2430         * f-exp.y: Update rules.
2431         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2432         parameter.
2433         * d-exp.y: Update rules.
2434         * c-exp.y: Update rules.
2435         * breakpoint.c (set_breakpoint_condition): Create an
2436         innermost_block_tracker.
2437         (watch_command_1): Likewise.
2438         * ada-lang.c (resolve): Add "tracker" parameter.
2439         (resolve_subexp): Likewise.
2440         * ada-exp.y (write_var_from_sym): Update.
2441
2442 2019-04-04  Tom Tromey  <tom@tromey.com>
2443
2444         * type-stack.h: New file.
2445         * type-stack.c: New file.
2446         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2447         type-stack.h.
2448         (insert_into_type_stack, insert_type, push_type, push_type_int)
2449         (insert_type_address_space, pop_type, pop_type_int)
2450         (pop_typelist, pop_type_stack, append_type_stack)
2451         (push_type_stack, get_type_stack, push_typelist)
2452         (follow_type_instance_flags, follow_types): Don't declare.
2453         * parse.c (type_stack): Remove global.
2454         (parse_exp_in_context): Update.
2455         (insert_into_type_stack, insert_type, push_type, push_type_int)
2456         (insert_type_address_space, pop_type, pop_type_int)
2457         (pop_typelist, pop_type_stack, append_type_stack)
2458         (push_type_stack, get_type_stack, push_typelist)
2459         (follow_type_instance_flags, follow_types): Remove (moved to
2460         type-stack.c).
2461         * f-exp.y (type_stack): New global.
2462         Update rules.
2463         (push_kind_type, f_parse): Update.
2464         * d-exp.y (type_stack): New global.
2465         Update rules.
2466         (d_parse): Update.
2467         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2468         Update rules.
2469         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2470         (HFILES_NO_SRCDIR): Add type-stack.h.
2471
2472 2019-04-04  Tom Tromey  <tom@tromey.com>
2473
2474         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2475         (rust_parser::convert_ast_to_expression, rust_parse)
2476         (rust_lex_test_completion, rust_lex_tests): Update.
2477         * parser-defs.h (struct expr_completion_state): New.
2478         (struct parser_state) <parser_state>: Add completion parameter.
2479         <mark_struct_expression, mark_completion_tag>: New methods.
2480         <parse_completion, m_completion_state>: New members.
2481         (prefixify_expression, null_post_parser): Update.
2482         (mark_struct_expression, mark_completion_tag): Don't declare.
2483         * parse.c (parse_completion, expout_last_struct)
2484         (expout_tag_completion_type, expout_completion_name): Remove
2485         globals.
2486         (parser_state::mark_struct_expression)
2487         (parser_state::mark_completion_tag): Now methods.
2488         (prefixify_expression): Add last_struct parameter.
2489         (prefixify_subexp): Likewise.
2490         (parse_exp_1): Update.
2491         (parse_exp_in_context): Add cstate parameter.  Update.
2492         (parse_expression_for_completion): Create an
2493         expr_completion_state.
2494         (null_post_parser): Add "completion" parameter.
2495         * p-exp.y: Update rules.
2496         (yylex): Update.
2497         * language.h (struct language_defn) <la_post_parser>: Add
2498         "completing" parameter.
2499         * go-exp.y: Update rules.
2500         (lex_one_token): Update.
2501         * expression.h (parse_completion): Don't declare.
2502         * d-exp.y: Update rules.
2503         (lex_one_token): Update rules.
2504         * c-exp.y: Update rules.
2505         (lex_one_token): Update.
2506         * ada-lang.c (resolve): Add "parse_completion" parameter.
2507         (resolve_subexp): Likewise.
2508         (ada_resolve_function): Likewise.
2509
2510 2019-04-04  Tom Tromey  <tom@tromey.com>
2511
2512         * parser-defs.h (struct parser_state) <start_arglist,
2513         end_arglist>: New methods.
2514         <arglist_len, m_funcall_chain>: New members.
2515         (arglist_len, start_arglist, end_arglist): Don't declare.
2516         * parse.c (arglist_len, funcall_chain): Remove global.
2517         (start_arglist, end_arglist): Remove functions.
2518         (parse_exp_in_context): Update.
2519         * p-exp.y: Update rules.
2520         * m2-exp.y: Update rules.
2521         * go-exp.y: Update rules.
2522         * f-exp.y: Update rules.
2523         * d-exp.y: Update rules.
2524         * c-exp.y: Update rules.
2525
2526 2019-04-04  Tom Tromey  <tom@tromey.com>
2527
2528         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2529         lex_operator, push_back>: New methods.
2530         Update all rules.
2531         (rust_parser::lex_hex, lex_escape): Rename and update.
2532         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2533         (rust_parser::lex_operator): Rename and update.
2534         (rust_parser::lex_number, rustyylex, rustyyerror)
2535         (rust_lex_test_init, rust_lex_test_sequence)
2536         (rust_lex_test_push_back, rust_lex_tests): Update.
2537         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2538         parameter.
2539         <lexptr, prev_lexptr>: New members.
2540         (lexptr, prev_lexptr): Don't declare.
2541         * parse.c (lexptr, prev_lexptr): Remove globals.
2542         (parse_exp_in_context): Update.
2543         * p-exp.y (yylex, yyerror): Update.
2544         * m2-exp.y (parse_number, yylex, yyerror): Update.
2545         * go-exp.y (lex_one_token, yyerror): Update.
2546         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2547         * d-exp.y (lex_one_token, yyerror): Update.
2548         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2549         (lex_one_token, yyerror): Update.
2550         * ada-lex.l (YY_INPUT): Update.
2551         (rewind_to_char): Update.
2552         * ada-exp.y (yyerror): Update.
2553
2554 2019-04-04  Tom Tromey  <tom@tromey.com>
2555
2556         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2557         * parser-defs.h (struct parser_state) <parser_state>: Add new
2558         parameter.
2559         <comma_terminates>: New member.
2560         (comma_terminates): Don't declare global.
2561         * parse.c (comma_terminates): Remove global.
2562         (parse_exp_in_context): Update.
2563         * p-exp.y (yylex): Update.
2564         * m2-exp.y (yylex): Update.
2565         * go-exp.y (lex_one_token): Update.
2566         * f-exp.y (yylex): Update.
2567         * d-exp.y (lex_one_token): Update.
2568         * c-exp.y (lex_one_token): Update.
2569         * ada-lex.l: Update.
2570
2571 2019-04-04  Tom Tromey  <tom@tromey.com>
2572
2573         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2574         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2575         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2576         * parser-defs.h (paren_depth): Don't declare.
2577         * parse.c (paren_depth): Remove global.
2578         (parse_exp_in_context): Update.
2579         * p-exp.y (paren_depth): New global.
2580         (pascal_parse): Initialize it.
2581         * m2-exp.y (paren_depth): New global.
2582         (m2_parse): Initialize it.
2583         * go-exp.y (paren_depth): New global.
2584         (go_parse): Initialize it.
2585         * f-exp.y (paren_depth): New global.
2586         (f_parse): Initialize it.
2587         * d-exp.y (paren_depth): New global.
2588         (d_parse): Initialize it.
2589         * c-exp.y (paren_depth): New global.
2590         (c_parse): Initialize it.
2591         * ada-lex.l (paren_depth): New global.
2592         (lexer_init): Initialize it.
2593
2594 2019-04-04  Tom Tromey  <tom@tromey.com>
2595
2596         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2597         (rust_parser::convert_ast_to_type)
2598         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2599         * parser-defs.h (struct parser_state) <parser_state>: Add
2600         parameters.  Initialize new members.
2601         <expression_context_block, expression_context_pc>: New members.
2602         * parse.c (expression_context_block, expression_context_pc):
2603         Remove globals.
2604         (parse_exp_in_context): Update.
2605         * p-exp.y: Update all rules.
2606         (yylex): Update.
2607         * m2-exp.y: Update all rules.
2608         (yylex): Update.
2609         * go-exp.y (yylex): Update.
2610         * f-exp.y (yylex): Update.
2611         * d-exp.y: Update all rules.
2612         (yylex): Update.
2613         * c-exp.y: Update all rules.
2614         (lex_one_token, classify_name, yylex, c_parse): Update.
2615         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2616
2617 2019-04-04  Tom Tromey  <tom@tromey.com>
2618
2619         * gdbarch.h, gdbarch.c: Rebuild.
2620         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2621         * stap-probe.h:
2622         (struct stap_parse_info): Replace "parser_state" with
2623         "expr_builder".
2624         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2625         (parser_state): New class.
2626         * parse.c (expr_builder): Rename.
2627         (expr_builder::release): Rename.
2628         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2629         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2630         (write_exp_elt_longcst, write_exp_elt_floatcst)
2631         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2632         (write_exp_string_vector, write_exp_bitstring)
2633         (write_exp_msymbol, mark_struct_expression)
2634         (write_dollar_variable)
2635         (insert_type_address_space, increase_expout_size): Replace
2636         "parser_state" with "expr_builder".
2637         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2638         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2639         "parser_state" with "expr_builder".
2640
2641 2019-04-04  Tom Tromey  <tom@tromey.com>
2642
2643         * rust-exp.y: Replace "parse_language" with method call.
2644         * p-exp.y:
2645         (yylex): Replace "parse_language" with method call.
2646         * m2-exp.y:
2647         (yylex): Replace "parse_language" with method call.
2648         * go-exp.y (classify_name): Replace "parse_language" with method
2649         call.
2650         * f-exp.y (yylex): Replace "parse_language" with method call.
2651         * d-exp.y (lex_one_token): Replace "parse_language" with method
2652         call.
2653         * c-exp.y:
2654         (lex_one_token, classify_name, yylex): Replace "parse_language"
2655         with method call.
2656         * ada-exp.y (find_primitive_type, type_char)
2657         (type_system_address): Replace "parse_language" with method call.
2658
2659 2019-04-04  Tom Tromey  <tom@tromey.com>
2660
2661         * rust-exp.y: Replace "parse_gdbarch" with method call.
2662         * parse.c (write_dollar_variable, insert_type_address_space):
2663         Replace "parse_gdbarch" with method call.
2664         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2665         call.
2666         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2667         call.
2668         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2669         "parse_gdbarch" with method call.
2670         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2671         with method call.
2672         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2673         "parse_gdbarch" with method call.
2674         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2675         "parse_gdbarch" with method call.
2676         * c-exp.y (parse_type, parse_number, classify_name): Replace
2677         "parse_gdbarch" with method call.
2678         * ada-lex.l: Replace "parse_gdbarch" with method call.
2679         * ada-exp.y (parse_type, find_primitive_type, type_char)
2680         (type_system_address): Replace "parse_gdbarch" with method call.
2681
2682 2019-04-04  Tom Tromey  <tom@tromey.com>
2683
2684         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2685         * stap-probe.c (stap_parse_argument): Update.
2686         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2687         initial_size parameter.
2688         * rust-exp.y (rust_lex_tests): Update.
2689         * parse.c (parser_state): Update.
2690         (parse_exp_in_context): Update.
2691         * parser-defs.h (struct parser_state) <parser_state>: Remove
2692         "initial_size" parameter.
2693
2694 2019-04-04  Tom Tromey  <tom@tromey.com>
2695
2696         * parser-defs.h (increase_expout_size): Don't declare.
2697         * parse.c (increase_expout_size): Now static.
2698
2699 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2700
2701         * gnu-nat.c (gnu_nat_target::wait): Fix
2702         target_waitstatus_to_string call.
2703
2704 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2705
2706         * eval.c (evaluate_subexp_standard): Handle internal functions
2707         during Fortran function call handling.
2708
2709 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2710
2711         * NEWS: Mention new internal functions.
2712         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2713         (read_base_type): Use dwarf2_init_complex_target_type.
2714         * value.c (creal_internal_fn): New function.
2715         (cimag_internal_fn): New function.
2716         (_initialize_values): Register new internal functions.
2717
2718 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2719
2720         * infrun.c (stop_all_threads): If debug_infrun, always
2721         trace the wait status after wait_one, using
2722         target_waitstatus_to_string and target_pid_to_str.
2723         (handle_inferior_event): Replace various trace of
2724         wait status kind by a single trace.
2725         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2726         wait status kind image by target_waitstatus_to_string.
2727         * target/waitstatus.c (target_waitstatus_to_string): Fix
2728         obsolete comment.
2729
2730 2019-04-01  Tom Tromey  <tromey@adacore.com>
2731
2732         PR symtab/23331:
2733         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2734
2735 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2736             Pedro Alves  <palves@redhat.com>
2737
2738         * top.c (quit_force): Call 'finalize_values'.
2739         * value.c (finalize_values): New function.
2740         * value.h (finalize_values): Declare.
2741
2742 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2743
2744         * NEWS: Announce $_gdb_major and $_gdb_minor.
2745
2746         * top.c (init_gdb_version_vars): New function.
2747         (gdb_init): Call init_gdb_version_vars.
2748
2749 2019-03-29  Tom Tromey  <tromey@adacore.com>
2750
2751         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2752         help text.  Remove dead code.
2753
2754 2019-03-29  Keith Seitz  <keiths@redhat.com>
2755
2756         From Siddhesh Poyarekar:
2757         * f-lang.h (f77_get_upperbound): Return LONGEST.
2758         (f77_get_lowerbound): Likewise.
2759         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2760         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2761         print them.
2762         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2763         plongest to format print it.
2764         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2765         (f77_get_upperbound): Likewise.
2766         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2767         LOWER_BOUND to LONGEST.
2768         (f77_create_arrayprint_offset_tbl): Likewise.
2769
2770 2019-03-29  Keith Seitz  <keiths@redhat.com>
2771
2772         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2773         %s/pulongest for TYPE_LENGTH instead of %d in format
2774         strings.
2775         * ada-typerint.c (ada_print_type): Likewise.
2776         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2777         * compile/compile-c-support.c (generate_register_struct): Likewise.
2778         * gdbtypes.c (recursive_dump_type): Likewise.
2779         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2780         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2781         instead of %d in format strings.
2782         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2783         to std::min to ULONGEST.
2784         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2785         instead of %d in format strings.
2786         * tracepoint.c (info_scope_command): Likewise.
2787         * typeprint.c (print_offset_data::update)
2788         (print_offset_data::finish): Likewise.
2789         * xtensa-tdep.c (xtensa_store_return_value)
2790         (xtensa_push_dummy_call): Likewise.
2791
2792 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2793
2794         * windows-nat.c (display_selector): Fixed format specifications
2795         for 64-bit Cygwin.
2796
2797 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2798
2799         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2800
2801 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2802
2803         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2804         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2805         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2806         (nios2_linux_init_abi): Install it.
2807
2808 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2809
2810         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2811
2812 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2813
2814         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2815
2816 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2817             Tom Tromey  <tromey@adacore.com>
2818
2819         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2820
2821 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2822
2823         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2824         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2825         method to compute the bounds of range types. Also print "[evaluated]"
2826         if the bounds' values come from a dynamic evaluation.
2827
2828 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2829
2830         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2831         whitespace when pretty printing is on.
2832
2833 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2834
2835         * ppc-linux-nat.c: Add include.
2836
2837 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2838
2839         * NEWS: Mention AArch64 Pointer Authentication.
2840
2841 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2842
2843         * arm-linux-nat.c: Add include.
2844
2845 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2846
2847         * source-cache.c (source_cache::get_source_lines): Re-read
2848         fullname after calling open_source_file.
2849
2850 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2851
2852         * NEWS: Mention TLS support for FreeBSD.
2853
2854 2019-03-25  Tom Tromey  <tromey@adacore.com>
2855
2856         * minsyms.c (BUNCH_SIZE): Update comment.
2857         (~minimal_symbol_reader): Remove old comment.
2858         (compact_minimal_symbols): Update comment.
2859         (minimal_symbol_reader::install): Remove old comment.  Update
2860         other comments.
2861
2862 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2863
2864         * s390-linux-nat.c: Add include.
2865
2866 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2867
2868         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2869         Call linux_get_hwcap.
2870         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2871         Likewise.
2872         (aarch64_linux_get_hwcap): Remove function.
2873         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2874         declaration.
2875         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2876         linux_get_hwcap.
2877         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2878         * linux-tdep.c (linux_get_hwcap): Add function.
2879         (linux_get_hwcap2): Likewise.
2880         * linux-tdep.h (linux_get_hwcap): Add declaration.
2881         (linux_get_hwcap2): Likewise.
2882         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2883         (ppc_linux_get_hwcap2): Likewise.
2884         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2885         linux_get_hwcap.
2886         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2887         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2888         (ppc_linux_nat_target::read_description): Likewise.
2889         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2890         * s390-linux-nat.c: Likewise.
2891         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2892
2893 2019-03-24  Tom Tromey  <tom@tromey.com>
2894
2895         * ada-lang.c (standard_lookup): Simplify initialization.
2896         (ada_lookup_symbol_nonlocal): Simplify return.
2897         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2898         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2899         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2900         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2901         initialization.
2902         * solib.c (solib_global_lookup): Simplify.
2903         * symtab.c (null_block_symbol): Remove.
2904         (symbol_cache_lookup): Simplify returns.
2905         (lookup_language_this): Simplify returns.
2906         (lookup_symbol_aux): Simplify return.
2907         (lookup_local_symbol): Simplify returns.
2908         (lookup_global_symbol_from_objfile): Simplify return.
2909         (lookup_symbol_in_objfile_symtabs)
2910         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2911         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2912         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2913         * cp-namespace.c (cp_lookup_bare_symbol)
2914         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2915         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2916         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2917         (cp_lookup_symbol_via_imports): Simplify initialization.
2918         (find_symbol_in_baseclass): Likewise.
2919         * symtab.h (null_block_symbol): Remove.
2920         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2921         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2922         (d_lookup_symbol_module): Likewise.
2923         (find_symbol_in_baseclass): Simplify initialization.
2924
2925 2019-03-24  Tom Tromey  <tom@tromey.com>
2926
2927         * expression.h: Don't include symtab.h.
2928         (struct block): Forward declare.
2929
2930 2019-03-24  Tom Tromey  <tom@tromey.com>
2931
2932         * c-exp.y (typebase): Remove casts.
2933         * gdbtypes.c (lookup_unsigned_typename, )
2934         (lookup_signed_typename): Remove cast.
2935         * eval.c (parse_to_comma_and_eval): Remove cast.
2936         * parse.c (write_dollar_variable): Remove cast.
2937         * block.h (struct block) <superblock>: Now const.
2938         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2939         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2940         (map_block): Make "block" const.
2941         * symfile.h (struct quick_symbol_functions)
2942         <map_matching_symbols>: Constify block argument to "callback".
2943         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2944         const.
2945         (find_pc_sect_compunit_symtab): Make "b" const.
2946         (find_symbol_at_address): Likewise.
2947         (search_symbols): Likewise.
2948         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2949         (dw2_debug_names_lookup_symbol): Likewise.
2950         (dw2_map_matching_symbols): Update.
2951         * p-valprint.c (pascal_val_print): Remove "block".
2952         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2953         (aux_add_nonlocal_symbols): Make "block" const.
2954         (resolve_subexp): Remove cast.
2955         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2956         const.
2957         (iterate_over_file_blocks): Likewise.
2958         * f-exp.y (%union) <bval>: Remove.
2959         * coffread.c (patch_opaque_types): Make "b" const.
2960         * spu-tdep.c (spu_catch_start): Make "block" const.
2961         * c-valprint.c (print_unpacked_pointer): Remove "block".
2962         * symmisc.c (dump_symtab_1): Make "b" const.
2963         (block_depth): Make "block" const.
2964         * d-exp.y (%union) <bval>: Remove.
2965         * cp-support.h (cp_lookup_rtti_type): Update.
2966         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2967         * psymtab.c (psym_lookup_symbol): Make "block" const.
2968         (maintenance_check_psymtabs): Make "b" const.
2969         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2970         (enumerate_locals, enumerate_args): Update.
2971         * python/py-symtab.c (stpy_global_block): Make "block" const.
2972         (stpy_static_block): Likewise.
2973         * inline-frame.c (block_starting_point_at): Make "new_block"
2974         const.
2975         * block.c (find_block_in_blockvector): Make return type const.
2976         (blockvector_for_pc_sect): Make "b" const.
2977         (find_block_in_blockvector): Make "b" const.
2978
2979 2019-03-23  Tom Tromey  <tom@tromey.com>
2980
2981         * varobj.c (varobj_create): Update.
2982         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2983         * printcmd.c (display_command, do_one_display): Don't reset
2984         innermost_block.
2985         * parser-defs.h (enum innermost_block_tracker_type): Move to
2986         expression.h.
2987         (innermost_block): Update comment.
2988         * parse.c (parse_exp_1): Add tracker_types parameter.
2989         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2990         tracker_types parameter.  Reset innermost_block.
2991         (parse_exp_in_context): Remove.
2992         (parse_expression_for_completion): Update.
2993         * objfiles.c (~objfile): Don't reset expression_context_block or
2994         innermost_block.
2995         * expression.h (enum innermost_block_tracker_type): Move from
2996         parser-defs.h.
2997         (parse_exp_1): Add tracker_types parameter.
2998         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2999         reset innermost_block.
3000
3001 2019-03-23  Tom Tromey  <tom@tromey.com>
3002
3003         * objfiles.h: Include bcache.h.
3004
3005 2019-03-23  Tom Tromey  <tom@tromey.com>
3006
3007         * linespec.c (get_current_search_block): Use
3008         scoped_restore_current_language.
3009         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
3010
3011 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3012             Jiong Wang  <jiong.wang@arm.com>
3013
3014         * aarch64-linux-tdep.c
3015         (aarch64_linux_iterate_over_regset_sections): Check for pauth
3016         section.
3017         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
3018
3019 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3020             Jiong Wang  <jiong.wang@arm.com>
3021
3022         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
3023         instructions.
3024         (aarch64_analyze_prologue_test): Add PACIASP test.
3025         (aarch64_prologue_prev_register): Unmask PC value.
3026
3027 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3028             Jiong Wang  <jiong.wang@arm.com>
3029
3030         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
3031         (aarch64_dwarf2_prev_register): Unmask PC value.
3032         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
3033         (aarch64_execute_dwarf_cfa_vendor_op): Check for
3034         DW_CFA_AARCH64_negate_ra_state.
3035         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
3036
3037 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3038             Jiong Wang  <jiong.wang@arm.com>
3039
3040         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
3041         registers.
3042         (aarch64_pseudo_register_name): Likewise.
3043         (aarch64_pseudo_register_type): Likewise.
3044         (aarch64_pseudo_register_reggroup_p): Likewise.
3045         (aarch64_gdbarch_init): Add pauth registers.
3046         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
3047         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
3048         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
3049         (struct gdbarch_tdep): Add regnum for ra_state.
3050
3051 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3052             Jiong Wang  <jiong.wang@arm.com>
3053
3054         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
3055
3056 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3057             Jiong Wang  <jiong.wang@arm.com>
3058
3059         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
3060         function.
3061         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
3062         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
3063         (aarch64_gdbarch_init): Add puth registers.
3064         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
3065         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
3066         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
3067
3068 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3069             Jiong Wang  <jiong.wang@arm.com>
3070
3071         * aarch64-linux-nat.c
3072         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
3073         * aarch64-linux-tdep.c
3074         (aarch64_linux_core_read_description): Likewise.
3075         (aarch64_linux_get_hwcap): New function.
3076         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
3077         (aarch64_linux_get_hwcap): New declaration.
3078
3079 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3080             Jiong Wang  <jiong.wang@arm.com>
3081
3082         * aarch64-linux-nat.c
3083         (aarch64_linux_nat_target::read_description): Add pauth param.
3084         * aarch64-linux-tdep.c
3085         (aarch64_linux_core_read_description): Likewise.
3086         * aarch64-tdep.c (struct target_desc): Add in pauth.
3087         (aarch64_read_description): Add pauth param.
3088         (aarch64_gdbarch_init): Likewise.
3089         * aarch64-tdep.h (aarch64_read_description): Likewise.
3090         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3091         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3092         * features/Makefile: Add new files.
3093         * features/aarch64-pauth.c: New file.
3094         * features/aarch64-pauth.xml: New file.
3095
3096 2019-03-20  Tom Tromey  <tromey@adacore.com>
3097
3098         * infrun.c (handle_inferior_event): Rename from
3099         handle_inferior_event_1.  Create a scoped_value_mark.
3100         (handle_inferior_event): Remove.
3101
3102 2019-03-19  Tom Tromey  <tromey@adacore.com>
3103
3104         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3105         * infrun.h (print_stop_event): Add "displays" parameter.
3106         * infrun.c (print_stop_event): Add "displays" parameter.
3107
3108 2019-03-19  Pedro Alves  <palves@redhat.com>
3109
3110         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3111         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3112         to -1.  Fix TABs vs spaces.
3113         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3114         * tui/tui-out.h (tui_ui_out) Add intro comments.
3115         <m_line, m_start_of_line>: In-class initialize, and add describing
3116         comment.
3117
3118 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3119
3120         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3121         variable names.
3122         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3123
3124 2019-03-18  Pedro Alves  <palves@redhat.com>
3125             Eli Zaretskii <eliz@gnu.org>
3126
3127         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3128         m_line and m_start_of_line.
3129
3130 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3131
3132         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3133         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3134         it returns a newline.  This fixes a regression in TU mode, whereby
3135         the next line is output on the same screen line as the user input.
3136
3137 2019-03-18  Tom Tromey  <tromey@adacore.com>
3138
3139         * minsyms.c (minimal_symbol_reader::install): Remove call to
3140         obstack_blank.
3141
3142 2019-03-18  Pedro Alves  <palves@redhat.com>
3143
3144         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3145         New globals.
3146         (apply_style): New, factored out from ...
3147         (apply_ansi_escape): ... this.  Handle reverse video mode.
3148         (tui_set_reverse_mode): New function.
3149         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3150         * tui/tui-winsource.c (tui_show_source_line): Use
3151         tui_set_reverse_mode instead of setting A_STANDOUT.
3152         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3153         New setter methods.
3154
3155 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3156
3157         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3158         Handle tabs.
3159
3160 2019-03-18  Tom Tromey  <tromey@adacore.com>
3161
3162         * ada-lang.c (empty_array): Add "high" parameter.
3163         (ada_evaluate_subexp): Update.
3164
3165 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3166
3167         * unittests/string_view-selftests.c: Define
3168         _initialize_string_view_selftests unconditionally.
3169
3170 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3171
3172         PR gdb/24350
3173         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3174
3175 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3176
3177         PR gdb/24351
3178         * windows-nat.c (display_selector): Fix format specifiers.
3179
3180 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3181
3182         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3183         tui_refill_source_window instead of tui_refresh_win, to update the
3184         current execution line.  This fixes redisplay of the current line
3185         when stepping through the code with "next" or "step".
3186
3187 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3188
3189         * source-cache.c (source_cache::get_source_lines): Call
3190         find_source_lines to initialize s->nlines.  This fixes vertical
3191         scrolling of TUI source window when the DOWN arrow is pressed.
3192
3193 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3194
3195         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3196         linux-thread-db.c (_initialize_thread_db): Likewise.
3197
3198 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3199
3200         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3201         wclrtoeol in tui_show_source_line".  This reverts changes made in
3202         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3203
3204 2019-03-15  Tom Tromey  <tom@tromey.com>
3205
3206         * symtab.h (struct minimal_symbol): Derive from
3207         general_symbol_info.
3208         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3209         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3210         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3211         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3212         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3213         (MSYMBOL_SEARCH_NAME): Update.
3214         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3215         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3216         * minsyms.c (minimal_symbol_reader::record_full): Update.
3217
3218 2019-03-15  Tom Tromey  <tom@tromey.com>
3219
3220         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3221
3222 2019-03-15  Tom Tromey  <tom@tromey.com>
3223
3224         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3225         unique_xmalloc_ptr.
3226         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3227         Update.
3228         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3229         (build_minimal_symbol_hash_tables)
3230         (minimal_symbol_reader::install): Update.
3231
3232 2019-03-15  Tom Tromey  <tom@tromey.com>
3233
3234         * symtab.c (create_demangled_names_hash): Update.
3235         (symbol_set_names): Update.
3236         * objfiles.h (struct objfile_per_bfd_storage)
3237         <demangled_names_hash>: Now an htab_up.
3238         * objfiles.c (objfile_per_bfd_storage): Simplify.
3239
3240 2019-03-15  Tom Tromey  <tom@tromey.com>
3241
3242         * objfiles.h (struct objfile_per_bfd_storage): Declare
3243         destructor.
3244         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3245         New.
3246         (get_objfile_bfd_data): Use new.  Don't initialize
3247         language_of_main.
3248         (free_objfile_per_bfd_storage): Remove.
3249         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3250
3251 2019-03-15  Tom Tromey  <tom@tromey.com>
3252
3253         * symfile.c (reread_symbols): Update.
3254         * objfiles.c (objfile::objfile): Update.
3255         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3256         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3257         comment.
3258         (minimal_symbol_reader::install): Update.
3259         (terminate_minimal_symbol_table): Remove.
3260         * jit.c (jit_object_close_impl): Update.
3261
3262 2019-03-15  Tom Tromey  <tom@tromey.com>
3263
3264         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3265         initializations.
3266
3267 2019-03-15  Tom Tromey  <tom@tromey.com>
3268
3269         * objfiles.h (struct objfile_per_bfd_storage)
3270         <demangled_hash_languages>: Now a bitset.
3271         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3272         (lookup_minimal_symbol): Update.
3273
3274 2019-03-15  Tom Tromey  <tom@tromey.com>
3275
3276         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3277         Don't return the symbol.
3278         * coffread.c (record_minimal_symbol): Use record_full.
3279
3280 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3281
3282         The MS-Windows port of ncurses fails to switch to a color pair if
3283         one or both of the colors are the implicit default colors.  This
3284         change records the default colors when TUI is initialized, and
3285         then specifies them explicitly when a color pair uses the default
3286         colors.  This allows color styling in TUI mode on MS-Windows.
3287
3288         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3289         ncurses_norm_attr.
3290         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3291         colors in ncurses_norm_attr.
3292         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3293         "none", replace it with the default color recorded in
3294         ncurses_norm_attr.
3295
3296 2019-03-14  Tom Tromey  <tromey@adacore.com>
3297
3298         * source-cache.h (class source_cache) <get_source_lines>: Return
3299         std::string.
3300         * source-cache.c (source_cache::extract_lines): Handle case where
3301         first_pos==npos.  Return std::string.
3302         (source_cache::get_source_lines): Update.
3303
3304 2019-03-14  Tom Tromey  <tromey@adacore.com>
3305
3306         * NEWS: Add item for "style sources" commands.
3307         * source-cache.c (source_cache::get_source_lines): Check
3308         source_styling.
3309         * cli/cli-style.c (source_styling): New global.
3310         (_initialize_cli_style): Add "style sources" commands.
3311         (show_style_sources): New function.
3312         * cli/cli-style.h (source_styling): Declare.
3313
3314 2019-03-14  Pedro Alves  <palves@redhat.com>
3315             Tom Tromey  <tromey@adacore.com>
3316
3317         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3318         * tui/tui-winsource.c (tui_refill_source_window): New function,
3319         from...
3320         (tui_horizontal_source_scroll): ... here.  Move some logic.
3321         * cli/cli-style.c (set_style_enabled): Notify new observable.
3322         * tui/tui-hooks.c (tui_redisplay_source): New function.
3323         (tui_attach_detach_observers): Attach or detach
3324         tui_redisplay_source.
3325         * observable.h (source_styling_changed): New observable.
3326         * observable.c: Define source_styling_changed observable.
3327
3328 2019-03-13  Tom Tromey  <tromey@adacore.com>
3329
3330         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3331         (i386_gnu_nat_target::store_registers): Update.
3332         * target-debug.h (target_debug_print_std_string): New macro.
3333         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3334         * windows-tdep.c (display_one_tib): Update.
3335         * tui/tui-stack.c (tui_make_status_line): Update.
3336         * top.c (print_inferior_quit_action): Update.
3337         * thread.c (thr_try_catch_cmd): Update.
3338         (add_thread_with_info): Update.
3339         (thread_target_id_str): Update.
3340         (thr_try_catch_cmd): Update.
3341         (thread_command): Update.
3342         (thread_find_command): Update.
3343         * record-btrace.c (record_btrace_target::info_record)
3344         (record_btrace_resume_thread, record_btrace_target::resume)
3345         (record_btrace_cancel_resume, record_btrace_step_thread)
3346         (record_btrace_target::wait, record_btrace_target::wait)
3347         (record_btrace_target::wait, record_btrace_target::stop): Update.
3348         * progspace.c (print_program_space): Update.
3349         * process-stratum-target.c
3350         (process_stratum_target::thread_address_space): Update.
3351         * linux-fork.c (linux_fork_mourn_inferior)
3352         (detach_checkpoint_command, info_checkpoints_command)
3353         (linux_fork_context): Update.
3354         (linux_fork_detach): Update.
3355         (class scoped_switch_fork_info): Update.
3356         (delete_checkpoint_command): Update.
3357         * infrun.c (follow_fork_inferior): Update.
3358         (follow_fork_inferior): Update.
3359         (proceed_after_vfork_done): Update.
3360         (handle_vfork_child_exec_or_exit): Update.
3361         (follow_exec): Update.
3362         (displaced_step_prepare_throw): Update.
3363         (displaced_step_restore): Update.
3364         (start_step_over): Update.
3365         (resume_1): Update.
3366         (clear_proceed_status_thread): Update.
3367         (proceed): Update.
3368         (print_target_wait_results): Update.
3369         (do_target_wait): Update.
3370         (context_switch): Update.
3371         (stop_all_threads): Update.
3372         (restart_threads): Update.
3373         (finish_step_over): Update.
3374         (handle_signal_stop): Update.
3375         (switch_back_to_stepped_thread): Update.
3376         (keep_going_pass_signal): Update.
3377         (print_exited_reason): Update.
3378         (normal_stop): Update.
3379         * inferior.c (inferior_pid_to_str): Change return type.
3380         (print_selected_inferior): Update.
3381         (add_inferior): Update.
3382         (detach_inferior): Update.
3383         * dummy-frame.c (fprint_dummy_frames): Update.
3384         * dcache.c (dcache_info_1): Update.
3385         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3386         (btrace_fetch, btrace_clear): Update.
3387         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3388         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3389         type.
3390         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3391         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3392         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3393         * gdbarch.c, gdbarch.h: Rebuild.
3394         * gdbarch.sh (core_pid_to_str): Change return type.
3395         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3396         return type.
3397         (windows_nat_target::pid_to_str): Change return type.
3398         (windows_delete_thread): Update.
3399         (windows_nat_target::attach): Update.
3400         (windows_nat_target::files_info): Update.
3401         * target-delegates.c: Rebuild.
3402         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3403         return type.
3404         (sol_thread_target::pid_to_str): Change return type.
3405         * remote.c (class remote_target) <pid_to_str>: Change return
3406         type.
3407         (remote_target::pid_to_str): Change return type.
3408         (extended_remote_target::attach, remote_target::remote_stop_ns)
3409         (remote_target::remote_notif_remove_queued_reply)
3410         (remote_target::push_stop_reply, remote_target::disable_btrace):
3411         Update.
3412         (extended_remote_target::attach): Update.
3413         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3414         type.
3415         (gdbsim_target::pid_to_str): Change return type.
3416         * ravenscar-thread.c (struct ravenscar_thread_target)
3417         <pid_to_str>: Change return type.
3418         (ravenscar_thread_target::pid_to_str): Change return type.
3419         * procfs.c (class procfs_target) <pid_to_str>: Change return
3420         type.
3421         (procfs_target::pid_to_str): Change return type.
3422         (procfs_target::attach): Update.
3423         (procfs_target::detach): Update.
3424         (procfs_target::fetch_registers): Update.
3425         (procfs_target::store_registers): Update.
3426         (procfs_target::wait): Update.
3427         (procfs_target::files_info): Update.
3428         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3429         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3430         return type.
3431         (nto_procfs_target::pid_to_str): Change return type.
3432         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3433         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3434         return type.
3435         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3436         (exit_lwp): Update.
3437         (attach_proc_task_lwp_callback, get_detach_signal)
3438         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3439         (linux_nat_target::resume, wait_lwp, stop_callback)
3440         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3441         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3442         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3443         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3444         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3445         type.
3446         (inf_ptrace_target::attach): Update.
3447         (inf_ptrace_target::files_info): Update.
3448         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3449         type.
3450         (go32_nat_target::pid_to_str): Change return type.
3451         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3452         (gnu_nat_target::wait): Update.
3453         (gnu_nat_target::wait): Update.
3454         (gnu_nat_target::resume): Update.
3455         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3456         (fbsd_nat_target::wait): Update.
3457         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3458         type.
3459         (darwin_nat_target::attach): Update.
3460         * corelow.c (class core_target) <pid_to_str>: Change return type.
3461         (core_target::pid_to_str): Change return type.
3462         * target.c (normal_pid_to_str): Change return type.
3463         (default_pid_to_str): Likewise.
3464         (target_pid_to_str): Change return type.
3465         (target_translate_tls_address): Update.
3466         (target_announce_detach): Update.
3467         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3468         return type.
3469         (bsd_uthread_target::pid_to_str): Change return type.
3470         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3471         type.
3472         (bsd_kvm_target::pid_to_str): Change return type.
3473         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3474         return type.
3475         (aix_thread_target::pid_to_str): Change return type.
3476         * target.h (struct target_ops) <pid_to_str>: Change return type.
3477         (target_pid_to_str, normal_pid_to_str): Likewise.
3478         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3479         type.
3480         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3481         type.
3482         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3483         return type.
3484         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3485         type.
3486         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3487         type.
3488         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3489         return type.
3490
3491 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3492
3493         * NEWS: Mention that the new default MI version is 3.  Mention
3494         changes to the output of commands and events that deal with
3495         multi-location breakpoints.
3496         * breakpoint.c: Include "mi/mi-out.h".
3497         (print_one_breakpoint): Change output syntax if using MI version
3498         >= 3.
3499         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3500         New.
3501         (mi_multi_location_breakpoint_output_fixed): New.
3502         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3503         (mi_cmd_fix_multi_location_breakpoint_output): New.
3504         (mi_multi_location_breakpoint_output_fixed): New.
3505         * mi/mi-cmds.c (mi_cmds): Register command
3506         -fix-multi-location-breakpoint-output.
3507         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3508         interpreter "mi".
3509
3510 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3511
3512         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3513         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3514         instantiate mi_ui_out based on interpreter name.
3515         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3516         * mi/mi-main.c (mi_load_progress): Likewise.
3517
3518 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3519
3520         * NEWS: Combine separate "New targets" sections for 8.3.
3521
3522 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3523
3524         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3525         (ppcfbsd_init_abi): Install gdbarch
3526         "fetch_tls_load_module_address" and "get_thread_local_address"
3527         methods.
3528
3529 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3530
3531         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3532         (riscv_fbsd_init_abi): Install gdbarch
3533         "fetch_tls_load_module_address" and "get_thread_local_address"
3534         methods.
3535
3536 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3537
3538         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3539         (i386fbsd_init_abi): Install gdbarch
3540         "fetch_tls_load_module_address" and "get_thread_local_address"
3541         methods.
3542
3543 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3544
3545         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3546         (amd64fbsd_init_abi): Install gdbarch
3547         "fetch_tls_load_module_address" and "get_thread_local_address"
3548         methods.
3549
3550 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3551
3552         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3553         (struct fbsd_pspace_data): New type.
3554         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3555         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3556         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3557         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3558         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3559
3560 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3561
3562         * gdbtypes.c (lookup_struct_elt): New function.
3563         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3564         * gdbtypes.h (struct struct_elt): New type.
3565         (lookup_struct_elt): New prototype.
3566
3567 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3568
3569         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3570         remove disabled code block.
3571
3572 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3573
3574         * gdbarch.sh (get_thread_local_address): New method.
3575         * gdbarch.h, gdbarch.c: Regenerate.
3576         * target.c (target_translate_tls_address): Use
3577         gdbarch_get_thread_local_address if present instead of
3578         target::get_thread_local_address.
3579
3580 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3581
3582         * target.h (target::get_thread_local_address): Update comment.
3583
3584 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3585
3586         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3587         objfile->separate_debug_objfile_backlink if not NULL.
3588
3589 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3590
3591         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3592         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3593         (amd64bsd_store_inferior_registers): Likewise.
3594         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3595         Enable segment base registers.
3596         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3597         PT_GETFSBASE and PT_GETGSBASE.
3598         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3599         PT_SETGSBASE.
3600         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3601         segment base registers.
3602         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3603
3604 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3605
3606         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3607         Update calls to i386_target_description to add 'segments'
3608         parameter.
3609         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3610         add segment base registers.
3611         * arch/i386.c (i386_create_target_description): Add 'segments'
3612         parameter to enable segment base registers.
3613         * arch/i386.h (i386_create_target_description): Likewise.
3614         * features/i386/32bit-segments.xml: New file.
3615         * features/i386/32bit-segments.c: Generate.
3616         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3617         call to i386_target_description to add 'segments' parameter.
3618         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3619         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3620         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3621         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3622         if feature is present.
3623         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3624         Add 'segments' parameter to call to i386_target_description.
3625         (i386_target_description): Add 'segments' parameter to enable
3626         segment base registers.
3627         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3628         to call to i386_target_description.
3629         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3630         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3631         Define I386_NUM_REGS.
3632         (i386_target_description): Add 'segments' parameter to enable
3633         segment base registers.
3634
3635 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3636
3637         PR/24325
3638         * source-cache.c: #undef open and close, to avoid unresolved
3639         externals during linking.
3640
3641 2019-03-12  Tom Tromey  <tromey@adacore.com>
3642
3643         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3644         const.  Add initializers.
3645         (_initialize_remote): Don't initialize ptid globals.
3646
3647 2019-03-12  Pedro Alves  <palves@redhat.com>
3648
3649         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3650
3651 2019-03-12  Pedro Alves  <palves@redhat.com>
3652
3653         * cp-name-parser.y (main): Remove unused 'len' variable.
3654
3655 2019-03-12  Tom Tromey  <tromey@adacore.com>
3656
3657         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3658         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3659
3660 2019-03-12  Tom Tromey  <tromey@adacore.com>
3661
3662         * linux-nat.c (iterate_over_lwps): Update.
3663         (stop_callback): Remove parameter.
3664         (stop_wait_callback, detach_callback, resume_set_callback)
3665         (select_singlestep_lwp_callback, set_ignore_sigint)
3666         (status_callback, resumed_callback, resume_clear_callback)
3667         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3668         data parameter.
3669         (linux_nat_target::detach, linux_nat_target::resume)
3670         (linux_stop_and_wait_all_lwps, select_event_lwp)
3671         (linux_nat_filter_event, linux_nat_wait_1)
3672         (linux_nat_target::kill, linux_nat_target::stop)
3673         (linux_nat_target::stop): Update.
3674         (linux_nat_resume_callback): Change type.
3675         (resume_stopped_resumed_lwps, count_events_callback)
3676         (select_event_lwp_callback): Likewise.
3677         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3678         * arm-linux-nat.c (struct update_registers_data): Remove.
3679         (update_registers_callback): Change type.
3680         (arm_linux_insert_hw_breakpoint1): Update.
3681         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3682         parameter.
3683         (x86_linux_dr_set_addr): Update.
3684         (x86_linux_dr_set_control): Update.
3685         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3686         (iterate_over_lwps): Use gdb::function_view.
3687         * nat/aarch64-linux-hw-point.c (struct
3688         aarch64_dr_update_callback_param): Remove.
3689         (debug_reg_change_callback): Change type.
3690         (aarch64_notify_debug_reg_change): Update.
3691         * s390-linux-nat.c (s390_refresh_per_info): Update.
3692
3693 2019-03-11  Tom Tromey  <tromey@adacore.com>
3694
3695         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3696         redundant assignment to "this_cu".
3697
3698 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3699
3700         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3701
3702 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3703
3704         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3705         from...
3706         (rank_one_type): ... this.
3707
3708 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3709
3710         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3711         from...
3712         (rank_one_type): ... this.
3713
3714 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3715
3716         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3717         from...
3718         (rank_one_type): ... this.
3719
3720 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3721
3722         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3723         from...
3724         (rank_one_type): ... this.
3725
3726 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3727
3728         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3729         from...
3730         (rank_one_type): ... this.
3731
3732 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3733
3734         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3735         from...
3736         (rank_one_type): ... this.
3737
3738 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3739
3740         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3741         from...
3742         (rank_one_type): ... this.
3743
3744 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3745
3746         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3747         from...
3748         (rank_one_type): ... this.
3749
3750 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3751
3752         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3753         from...
3754         (rank_one_type): ... this.
3755
3756 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3757
3758         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3759         from...
3760         (rank_one_type): ... this.
3761
3762 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3763
3764         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3765         from...
3766         (rank_one_type): ... this.
3767
3768 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3769
3770         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3771         from...
3772         (rank_one_type): ... this.
3773
3774 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3775
3776         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3777         inferior-events' shows the example events.
3778
3779 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3780
3781         Support styling on native MS-Windows console
3782
3783         PR/24315
3784         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3785         on MS-Windows if $TERM is not defined.
3786
3787         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3788
3789         * posix-hdep.c (gdb_console_fputs):
3790         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3791         functions.
3792         * ui-file.h (gdb_console_fputs): Add prototype.
3793
3794         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3795         back to fputs only if the former returns zero.
3796
3797 2019-03-07  Tom Tromey  <tom@tromey.com>
3798
3799         * symmisc.c (print_symbol_bcache_statistics): Update.
3800         (print_objfile_statistics): Update.
3801         * symfile.c (allocate_symtab): Update.
3802         * stabsread.c: Don't include bcache.h.
3803         * psymtab.h (struct psymbol_bcache): Don't declare.
3804         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3805         (psymbol_bcache_init, psymbol_bcache_free)
3806         (psymbol_bcache_get_bcache): Don't declare.
3807         * psymtab.c (struct psymbol_bcache): Remove.
3808         (psymtab_storage::psymtab_storage): Update.
3809         (psymtab_storage::~psymtab_storage): Update.
3810         (psymbol_bcache_init, psymbol_bcache_free)
3811         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3812         (add_psymbol_to_bcache): Update.
3813         (allocate_psymtab): Update.
3814         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3815         macro_cache>: No longer pointers.
3816         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3817         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3818         * macrotab.c (macro_bcache): Update.
3819         * macroexp.c: Don't include bcache.h.
3820         * gdbtypes.c (check_types_worklist): Update.
3821         (types_deeply_equal): Remove TRY/CATCH.  Update.
3822         * elfread.c (elf_symtab_read): Update.
3823         * dwarf2read.c: Don't include bcache.h.
3824         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3825         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3826         (print_bcache_statistics, bcache_memory_used): Don't declare.
3827         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3828         methods.  Rename all data members.
3829         * bcache.c (struct bcache): Move to bcache.h.
3830         (bcache::expand_hash_table): Rename from expand_hash_table.
3831         (bcache): Remove.
3832         (bcache::insert): Rename from bcache_full.
3833         (bcache::compare): Rename from bcache_compare.
3834         (bcache_xmalloc): Remove.
3835         (bcache::~bcache): Rename from bcache_xfree.
3836         (bcache::print_statistics): Rename from print_bcache_statistics.
3837         (bcache::memory_used): Rename from bcache_memory_used.
3838
3839 2019-03-07  Pedro Alves  <palves@redhat.com>
3840
3841         * infrun.c (normal_stop): Also check for
3842         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3843
3844 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3845
3846         * f-lang.c (value_from_host_double): Moved to...
3847         * value.c (value_from_host_double): ...here.
3848         * value.h (value_from_host_double): Declare.
3849         * guile/scm-math.c (vlscm_convert_typed_number): Use
3850         value_from_host_double.
3851         (vlscm_convert_number): Likewise.
3852         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3853         * python/py-value.c (convert_value_from_python): Likewise.
3854
3855 2019-03-06  Tom Tromey  <tom@tromey.com>
3856
3857         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3858
3859 2019-03-06  Tom Tromey  <tom@tromey.com>
3860
3861         * utils.h (free_current_contents): Don't declare.
3862         * utils.c (free_current_contents): Remove.
3863
3864 2019-03-06  Tom Tromey  <tom@tromey.com>
3865
3866         * top.c (quit_force): Update.
3867         * main.c (captured_command_loop): Update.
3868         * common/new-op.c (operator new): Update.
3869         * common/common-exceptions.c (struct catcher)
3870         <save_cleanup_chain>: Remove member.
3871         (exceptions_state_mc_init): Update.
3872         (exception_try_scope_entry): Return nullptr.
3873         (exception_try_scope_exit, exception_rethrow)
3874         (throw_exception_sjlj, throw_exception_cxx): Update.
3875         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3876         (all_cleanups, do_cleanups, discard_cleanups)
3877         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3878         (restore_cleanups, restore_final_cleanups): Don't declare.
3879         (do_final_cleanups): Remove parameter.
3880         * common/cleanups.c (cleanup_chain, make_cleanup)
3881         (make_cleanup_dtor, all_cleanups, do_cleanups)
3882         (discard_my_cleanups, discard_cleanups)
3883         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3884         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3885         (null_cleanup): Remove.
3886         (do_final_cleanups): Remove parameter.
3887
3888 2019-03-06  Tom Tromey  <tom@tromey.com>
3889
3890         * remote.c (remote_target::remote_parse_stop_reply): Use
3891         unique_xmalloc_ptr.
3892
3893 2019-03-06  Tom Tromey  <tom@tromey.com>
3894
3895         * stabsread.c (struct stabs_field_info): Rename from field_info.
3896         <list, fnlist>: Add initializers.
3897         <obstack>: New member.
3898         (read_member_functions, read_struct_fields, read_baseclasses):
3899         Allocate on obstack.  Don't use cleanups.
3900         (read_one_struct_field, read_member_functions, read_struct_fields)
3901         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3902         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3903         (read_struct_type): Update.
3904
3905 2019-03-06  Tom Tromey  <tom@tromey.com>
3906
3907         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3908         * common/filestuff.h (make_cleanup_close): Don't declare.
3909         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3910         Remove.
3911
3912 2019-03-06  Tom Tromey  <tom@tromey.com>
3913
3914         * solib-aix.c: Use make_scope_exit.
3915
3916 2019-03-06  Tom Tromey  <tom@tromey.com>
3917
3918         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3919         Use make_scope_exit.
3920
3921 2019-03-06  Tom Tromey  <tom@tromey.com>
3922
3923         * solib-svr4.c (disable_probes_interface): Remove parameter.
3924         (svr4_handle_solib_event): Use make_scope_exit.
3925
3926 2019-03-06  Tom Tromey  <tom@tromey.com>
3927
3928         * remote.c (struct stop_reply_deleter): Remove.
3929         (stop_reply_up): Update.
3930         (struct stop_reply): Derive from notif_event.  Don't typedef.
3931         <regcache>: Now a std::vector.
3932         (stop_reply_xfree): Remove.
3933         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3934         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3935         (remote_target::discard_pending_stop_replies): Use delete.
3936         (remote_target::remote_parse_stop_reply): Update.
3937         (remote_target::process_stop_reply): Update.
3938         * remote-notif.h (struct notif_event): Add virtual destructor.
3939         Remove "dtr" member.
3940         (struct notif_client) <alloc_event>: Return a unique_ptr.
3941         (notif_event_xfree): Don't declare.
3942         (notif_event_up): New typedef.
3943         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3944         (notif_event_xfree, do_notif_event_xfree): Remove.
3945         (remote_notif_state_xfree): Update.
3946
3947 2019-03-06  Tom Tromey  <tom@tromey.com>
3948
3949         * infrun.c (displaced_step_clear_cleanup): Now a
3950         forward_scope_exit type.
3951         (displaced_step_prepare_throw): Update.
3952         (displaced_step_fixup): Update.
3953
3954 2019-03-06  Tom Tromey  <tom@tromey.com>
3955
3956         * inferior.h (class inferior): Update comment.
3957         * gdbthread.h (class thread_info): Update comment.
3958
3959 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3960             Tom Tromey  <tom@tromey.com>
3961
3962         * stabsread.h (struct stab_section_list): Remove.
3963         (coffstab_build_psymtabs): Update.
3964         * dbxread.c (symbuf_sections): Now a std::vector.
3965         (sect_idx): New global.
3966         (fill_symbuf): Update.
3967         (coffstab_build_psymtabs): Change type of stabsects parameter.
3968         Update.
3969         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3970         std::vector.
3971         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3972         (coff_locate_sections): Update.
3973         (coff_symfile_read): Remove cleanups.  Update.
3974         (init_stringtab): Add storage parameter.
3975         (free_stringtab, free_stringtab_cleanup): Remove.
3976         (init_lineno): Add storage parameter.
3977         (free_linetab, free_linetab_cleanup): Remove.
3978
3979 2019-03-06  Pedro Alves  <palves@redhat.com>
3980
3981         * linux-fork.c (fork_info::clobber_regs): Delete.
3982         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3983         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3984         comment.  Adjust.
3985         (scoped_switch_fork_info::scoped_switch_fork_info)
3986         (checkpoint_command, linux_fork_context): Adjust
3987         fork_save_infrun_state calls.
3988
3989 2019-03-06  Pedro Alves  <palves@redhat.com>
3990
3991         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3992         (inf_has_multiple_threads): Return 'bool' and rewrite using
3993         inferior_info::threads().
3994
3995 2019-03-06  Pedro Alves  <palves@redhat.com>
3996
3997         * linux-fork.c: Include <list>.
3998         (fork_list): Now a std::list instance.
3999         (fork_info): Add ctor, dtor, and in-class initialize all fields.
4000         (forks_exist_p, find_last_fork): Adjust.
4001         (new_fork): Delete.
4002         (one_fork_p): New.
4003         (add_fork): Adjust.
4004         (free_fork): Delete, folded into fork_info::~fork_info().
4005         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
4006         Adjust.
4007         (init_fork_list): Delete.
4008         (linux_fork_killall, linux_fork_mourn_inferior)
4009         (linux_fork_detach, info_checkpoints_command): Adjust.
4010         (_initialize_linux_fork): No longer call init_fork_list.
4011
4012 2019-03-06  Pedro Alves  <palves@redhat.com>
4013
4014         * linux-fork.c (new_fork): New, split out of ...
4015         (add_fork): ... this.  Return void.  Move "first fork" special
4016         case from here, to ...
4017         (checkpoint_command): ... here.
4018         * linux-linux.h (add_fork): Return void.
4019
4020 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4021
4022         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
4023
4024 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4025             Chris January  <chris.january@arm.com>
4026             David Lecomber  <david.lecomber@arm.com>
4027
4028         * f-exp.y: New token, UNOP_INTRINSIC.
4029         (exp): New pattern using UNOP_INTRINSIC token.
4030         (f77_keywords): Add 'abs' keyword.
4031         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
4032         (value_from_host_double): New function.
4033         (evaluate_subexp_f): Support UNOP_ABS.
4034
4035 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4036
4037         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
4038         types.
4039
4040 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4041
4042         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
4043         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
4044         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
4045
4046 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4047
4048         * f-exp.y (convert_to_kind_type): Handle more type kinds.
4049
4050 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4051             Chris January  <chris.january@arm.com>
4052
4053         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
4054         * f-exp.y: Define 'KIND' token.
4055         (exp): New pattern for KIND expressions.
4056         (ptype): Handle types with a kind extension.
4057         (direct_abs_decl): Extend to spot kind extensions.
4058         (f77_keywords): Add 'kind' to the list.
4059         (push_kind_type): New function.
4060         (convert_to_kind_type): New function.
4061         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
4062         * parse.c (operator_length_standard): Likewise.
4063         * parser-defs.h (enum type_pieces): Add tp_kind.
4064         * std-operator.def: Add UNOP_KIND.
4065
4066 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4067
4068         * f-exp.y (f_parse): Set yydebug.
4069
4070 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4071
4072         * f-lang.c (evaluate_subexp_f): New function.
4073         (exp_descriptor_f): New global.
4074         (f_language_defn): Use exp_descriptor_f instead of
4075         exp_descriptor_standard.
4076
4077 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4078
4079         * f-exp.y (struct token): Add comments.
4080         (dot_ops): Remove uppercase versions and the end marker.
4081         (f77_keywords): Likewise.
4082         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
4083         entries in the dot_ops array are case insensitive, and use
4084         strncasecmp to compare strings.  Also some whitespace cleanup in
4085         this area.  Similar for the f77_keywords array, except entries in
4086         this list might be case sensitive.
4087
4088 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4089
4090         * f-exp.y (struct f77_boolean_val): Add comments.
4091         (boolean_values): Remove uppercase versions, and end marker.
4092         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
4093         and use strncasecmp to achieve case insensitivity.  Additionally,
4094         perform whitespace cleanup around this code.
4095
4096 2019-03-06  Tom Tromey  <tromey@adacore.com>
4097
4098         * remote-sim.c (gdbsim_target_open): Use result of
4099         gdb_argv::release.
4100
4101 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4102         Dirk Schubert  <dirk.schubert@arm.com>
4103         Chris January  <chris.january@arm.com>
4104
4105         * eval.c (evaluate_subexp_standard): Call Fortran argument
4106         wrapping logic.
4107         * f-lang.c (struct value): A value which can be passed into a
4108         Fortran function call.
4109         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4110         where appropriate.
4111         (struct type): Value ready for a Fortran function call.
4112         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4113         is needed.
4114         * f-lang.h (fortran_argument_convert): Declaration.
4115         (fortran_preserve_arg_pointer): Declaration.
4116         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4117
4118 2019-03-05  Tom Tromey  <tromey@adacore.com>
4119
4120         * python/py-prettyprint.c (print_string_repr): Remove #if.
4121         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4122
4123 2019-03-05  Tom Tromey  <tromey@adacore.com>
4124
4125         * target.c (the_dummy_target): Move later.  Change type to
4126         "dummy_target".
4127         (initialize_targets): Don't initialize the_dummy_target.
4128
4129 2019-03-05  Tom Tromey  <tromey@adacore.com>
4130
4131         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4132         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4133
4134 2019-03-05  Tom Tromey  <tromey@adacore.com>
4135
4136         * windows-nat.c (windows_nat_target::attach)
4137         (windows_nat_target::detach): Don't call gdb_flush.
4138         * valprint.c (generic_val_print, val_print, val_print_string):
4139         Don't call gdb_flush.
4140         * utils.c (defaulted_query): Don't call gdb_flush.
4141         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4142         * target.c (target_announce_detach): Don't call gdb_flush.
4143         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4144         * remote.c (extended_remote_target::attach): Don't call
4145         gdb_flush.
4146         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4147         * printcmd.c (do_examine): Don't call gdb_flush.
4148         (info_display_command): Don't call gdb_flush.
4149         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4150         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4151         * memattr.c (info_mem_command): Don't call gdb_flush.
4152         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4153         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4154         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4155         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4156         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4157         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4158         (gnu_nat_target::detach): Don't call gdb_flush.
4159         * f-valprint.c (f_val_print): Don't call gdb_flush.
4160         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4161         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4162         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4163         gdb_flush.
4164         * c-valprint.c (c_val_print): Don't call gdb_flush.
4165         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4166
4167 2019-03-05  Tom Tromey  <tromey@adacore.com>
4168
4169         * varobj.c (update_dynamic_varobj_children): Update.
4170         (install_default_visualizer): Use reset, not release.
4171         * value.c (set_internalvar): Update.
4172         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4173         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4174         ATTRIBUTE_UNUSED_RESULT.
4175
4176 2019-03-05  Tom Tromey  <tromey@adacore.com>
4177
4178         * remote.c (class scoped_remote_fd) <release>: Add
4179         ATTRIBUTE_UNUSED_RESULT.
4180
4181 2019-03-05  Tom Tromey  <tromey@adacore.com>
4182
4183         * macroexp.c (struct macro_buffer) <release>: Add
4184         ATTRIBUTE_UNUSED_RESULT.
4185
4186 2019-03-05  Tom Tromey  <tromey@adacore.com>
4187
4188         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4189         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4190         ATTRIBUTE_UNUSED_RESULT.
4191
4192 2019-03-05  Tom Tromey  <tromey@adacore.com>
4193
4194         * common/scoped_fd.h (class scoped_fd) <release>: Add
4195         ATTRIBUTE_UNUSED_RESULT.
4196
4197 2019-03-05  Tom Tromey  <tromey@adacore.com>
4198
4199         * parser-defs.h (struct parser_state) <release>: Add
4200         ATTRIBUTE_UNUSED_RESULT.
4201
4202 2019-03-05  Tom Tromey  <tromey@adacore.com>
4203
4204         * utils.h (class gdb_argv) <release>: Add
4205         ATTRIBUTE_UNUSED_RESULT.
4206         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4207
4208 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4209
4210         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4211         for-loop range, to avoid compiler warnings.
4212
4213         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4214         avoid compiler warnings about unused variables.
4215
4216         * NEWS: Mention end of support for native debugging on MS-Windows
4217         before XP.
4218
4219         PR gdb/24292
4220         * common/netstuff.c:
4221         * gdbserver/gdbreplay.c
4222         * gdbserver/remote-utils.c:
4223         * ser-tcp.c:
4224         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4225         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4226         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4227         'getaddrinfo' and 'freeaddrinfo' were not available before
4228         Windows XP, and mingw.org's MinGW headers by default define
4229         _WIN32_WINNT to 0x500.
4230
4231 2019-03-01  Gary Benson <gbenson@redhat.com>
4232
4233         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4234
4235 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4236             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4237
4238         PR gdb/8527
4239         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4240         set_sigint_trap, clear_sigint_trap.
4241
4242 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4243
4244         * target.c (target_detach): Clear the regcache and the
4245         frame cache.
4246
4247 2019-02-27  Pedro Alves  <palves@redhat.com>
4248
4249         * utils.c (set_screen_size): When we cap the height/width sizes,
4250         tweak the corresponding command variable to show "unlimited":
4251
4252 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4253             Pedro Alves  <palves@redhat.com>
4254
4255         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4256         before calling rl_set_screen_size.
4257
4258 2019-02-27  Tom Tromey  <tromey@adacore.com>
4259
4260         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4261         define.
4262         * python/py-value.c: Remove Python 2.4 workaround.
4263         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4264         workaround.
4265         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4266         Python 2.4 workaround.
4267         * python/python-internal.h: Remove Python 2.4 comment.
4268         (Py_ssize_t): Don't define.
4269         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4270         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4271         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4272         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4273         * python/python.c (do_start_initialization): Remove Python 2.4
4274         workaround.
4275         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4276         (print_children): Remove Python 2.4 workaround.
4277         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4278         workaround.
4279         (CHARBUFFERPROC_NAME): Remove.
4280         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4281         Python 2.4 workaround.
4282
4283 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4284
4285         * NEWS: Note minimum Python version.
4286
4287 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4288
4289         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4290         code from these functions.  Remove corresponding ifdefs.  Use
4291         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4292         Remove gotos and target of gotos.
4293         (infpy_search_memory): Likewise.
4294
4295 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4296
4297         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4298         (hppa_gdbarch_init): Don't register deleted functions with
4299         gdbarch.
4300
4301 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4302
4303         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4304         (h8300_unwind_sp): Delete.
4305         (h8300_dummy_id): Delete.
4306         (h8300_gdbarch_init): Don't register deleted functions with
4307         gdbarch.
4308
4309 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4310
4311         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4312         (ft32_unwind_pc): Delete.
4313         (ft32_unwind_sp): Delete.
4314         (ft32_gdbarch_init): Don't register deleted functions with
4315         gdbarch.
4316
4317 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4318
4319         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4320         (frv_unwind_pc): Delete.
4321         (frv_unwind_sp): Delete.
4322         (frv_gdbarch_init): Don't register deleted functions with
4323         gdbarch.
4324
4325 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4326
4327         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4328         (riscv_unwind_pc): Delete.
4329         (riscv_unwind_sp): Delete.
4330         (riscv_gdbarch_init): Don't register deleted functions with
4331         gdbarch.
4332
4333 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4334
4335         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4336         (csky_unwind_pc): Delete.
4337         (csky_unwind_sp): Delete.
4338         (csky_gdbarch_init): Don't register deleted functions with
4339         gdbarch.
4340
4341 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4342
4343         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4344         (cris_unwind_pc): Delete.
4345         (cris_unwind_sp): Delete.
4346         (cris_gdbarch_init): Don't register deleted functions with
4347         gdbarch.
4348
4349 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4350
4351         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4352         (bfin_unwind_pc): Delete.
4353         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4354
4355 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4356
4357         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4358         (arm_unwind_pc): Delete.
4359         (arm_unwind_sp): Delete.
4360         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4361
4362 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4363
4364         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4365         (arc_unwind_pc): Delete.
4366         (arc_unwind_sp): Delete.
4367         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4368
4369 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4370
4371         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4372         (alpha_unwind_pc): Delete.
4373         (alpha_gdbarch_init): Don't register deleted functions with
4374         gdbarch.
4375
4376 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4377
4378         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4379         (aarch64_unwind_pc): Delete.
4380         (aarch64_unwind_sp): Delete.
4381         (aarch64_gdbarch_init): Don't register deleted functions with
4382         gdbarch.
4383
4384 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4385
4386         * gdbtypes.c (type_align): Don't consider static members when
4387         computing structure alignment.
4388
4389 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4390
4391         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4392         return 0 for other types.
4393         * arch-utils.c (default_type_align): Always return 0.
4394         * gdbarch.h: Regenerate.
4395         * gdbarch.sh (type_align): Extend comment.
4396         * gdbtypes.c (type_align): Add additional comments, always call
4397         gdbarch_type_align before applying the default rules.
4398         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4399         generic code will then apply a suitable default.
4400         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4401         types, return 0 for other types.
4402
4403 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4404
4405         * NEWS: Create a new section for the next release branch.
4406         Rename the section of the current branch, now that it has
4407         been cut.
4408
4409 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4410
4411         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4412         * version.in: Bump version to 8.3.50.DATE-git.
4413
4414 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4415
4416         * aix-thread.c (ptid_cmp): Remove unused variable.
4417         (get_signaled_thread): Likewise.
4418         (store_regs_user_thread): Likewise.
4419         (store_regs_kernel_thread): Likewise.
4420         (fetch_regs_kernel_thread): Remove shadowed variable.
4421
4422 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4423
4424         * features/riscv/32bit-cpu.xml: Add register numbers.
4425         * features/riscv/32bit-fpu.c: Regenerate.
4426         * features/riscv/32bit-fpu.xml: Add register numbers.
4427         * features/riscv/64bit-cpu.xml: Add register numbers.
4428         * features/riscv/64bit-fpu.c: Regenerate.
4429         * features/riscv/64bit-fpu.xml: Add register numbers.
4430
4431 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4432
4433         * NEWS: Mention two argument form of gdb.Value constructor.
4434         * python/py-value.c (convert_buffer_and_type_to_value): New
4435         function.
4436         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4437         Add support for handling an optional second argument.  Call
4438         convert_buffer_and_type_to_value as appropriate.
4439         * python/python-internal.h (Py_buffer_deleter): New struct.
4440         (Py_buffer_up): New typedef.
4441
4442 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4443
4444         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4445         instead of releasing ownership.
4446
4447 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4448
4449         * dwarf2read.c (open_and_init_dwp_file): Call
4450         elf_numsections instead of bfd_count_sections to initialize
4451         dwp_file->num_sections.
4452
4453 2019-02-25  Tom Tromey  <tromey@adacore.com>
4454
4455         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4456
4457 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4458
4459         * gcore.in: Add '--readnever' option when invoking GDB.
4460
4461 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4462
4463         * MAINTAINERS: Update my email address.
4464
4465 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4466
4467         * build-id.c (build_id_to_debug_bfd_1): New function.
4468         (build_id_to_debug_bfd): Look for separate debug file in
4469         sysroot.
4470
4471 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4472
4473         * gdbarch.sh: Update the copyright year range that is placed into
4474         generated files.
4475
4476 2019-02-22  Keith Seitz  <keiths@redhat.com>
4477
4478         PR symtab/23853
4479         * linespec.c (create_sals_line_offset): Search for the default
4480         symtab's filename instead of its fullname.
4481
4482 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4483
4484         * NEWS: Update style defaults.
4485
4486 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4487
4488         * main.c (captured_main_1): Disable styling in batch mode.
4489
4490 2019-02-20  Tom Tromey  <tom@tromey.com>
4491
4492         * symtab.c (symtab_symbol_info): Fix typos.
4493
4494 2019-02-20  Tom Tromey  <tromey@adacore.com>
4495
4496         * findcmd.c (_initialize_mem_search): Use upper case for
4497         metasyntactic variables.
4498
4499 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4500
4501         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4502         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4503
4504 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4505
4506         * top.h (source_file_name): Change to std::string.
4507         * top.c (source_file_name): Likewise.
4508         (command_line_input): Adjust.
4509         * cli/cli-script.c (script_from_file): Adjust.
4510
4511 2019-02-19  Tom Tromey  <tromey@adacore.com>
4512
4513         * ravenscar-thread.c
4514         (ravenscar_thread_target::update_thread_list): Don't call
4515         ada_build_task_list.
4516         * ada-lang.h (ada_build_task_list): Don't declare.
4517         * ada-tasks.c (struct ada_tasks_inferior_data)
4518         <task_list_valid_p>: Now bool.
4519         (read_known_tasks, ada_task_list_changed)
4520         (ada_tasks_invalidate_inferior_data): Update.
4521         (read_known_tasks_array): Return bool.
4522         (read_known_tasks_list): Likewise.
4523         (read_known_tasks): Return void.
4524         (ada_build_task_list): Now static.
4525
4526 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4527
4528         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4529         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4530
4531 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4532
4533         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4534         variant for ada_tasks_pspace_data_handle and
4535         ada_tasks_inferior_data_handle.
4536         (ada_tasks_pspace_data_cleanup): New function.
4537         (ada_tasks_inferior_data_cleanup): New function.
4538
4539 2019-02-17  Tom Tromey  <tom@tromey.com>
4540
4541         * macrotab.h (macro_source_fullname): Return a std::string.
4542         * macrotab.c (macro_include, check_for_redefinition)
4543         (macro_undef, macro_lookup_definition, foreach_macro)
4544         (foreach_macro_in_scope): Update.
4545         (macro_source_fullname): Return a std::string.
4546         * macrocmd.c (show_pp_source_pos): Update.
4547
4548 2019-02-17  Tom Tromey  <tom@tromey.com>
4549
4550         * macrocmd.c (show_pp_source_pos): Style the file names.
4551
4552 2019-02-17  Tom Tromey  <tom@tromey.com>
4553
4554         PR tui/24197:
4555         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4556
4557 2019-02-17  Tom Tromey  <tom@tromey.com>
4558
4559         * ada-lang.c (user_select_syms): Use filtered printing.
4560         * utils.c (wrap_style): New global.
4561         (desired_style): Remove.
4562         (emit_style_escape): Add stream parameter.
4563         (set_output_style, reset_terminal_style, prompt_for_continue):
4564         Update.
4565         (flush_wrap_buffer): Only flush gdb_stdout.
4566         (wrap_here): Set wrap_style.
4567         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4568         treat escape sequences as a character.  Change when wrap buffer is
4569         flushed.
4570         (fputs_styled): Do not set the output style when the default is
4571         requested.
4572         * ui-style.h (struct ui_file_style) <is_default>: New method.
4573         * source.c (print_source_lines_base): Emit escape sequences in one
4574         piece.
4575
4576 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4577
4578         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4579         integers and enumeration types.
4580
4581 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4582
4583         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4584         instead of lookup_symbol_in_language
4585         (do_exact_match): New function.
4586         (ada_get_symbol_name_matcher): Return do_exact_match when
4587         doing a verbatim match.
4588
4589 2019-02-15  Tom Tromey  <tromey@adacore.com>
4590
4591         * ravenscar-thread.c (ravenscar_thread_target::resume)
4592         (ravenscar_thread_target::wait): Special case wildcard requests.
4593
4594 2019-02-15  Tom Tromey  <tromey@adacore.com>
4595
4596         * ravenscar-thread.c (base_ptid): Remove.
4597         (struct ravenscar_thread_target) <close>: New method.
4598         <m_base_ptid>: New member.
4599         <update_inferior_ptid, active_task, task_is_currently_active,
4600         runtime_initialized>: Declare methods.
4601         <ravenscar_thread_target>: Add constructor.
4602         (ravenscar_thread_target::task_is_currently_active)
4603         (ravenscar_thread_target::update_inferior_ptid)
4604         (ravenscar_runtime_initialized): Rename.  Now methods.
4605         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4606         (ravenscar_thread_target::update_thread_list): Update.
4607         (ravenscar_thread_target::active_task): Now method.
4608         (ravenscar_thread_target::store_registers)
4609         (ravenscar_thread_target::prepare_to_store)
4610         (ravenscar_thread_target::prepare_to_store)
4611         (ravenscar_thread_target::mourn_inferior): Update.
4612         (ravenscar_inferior_created): Use "new" to create target.
4613         (ravenscar_thread_target::get_ada_task_ptid): Update.
4614         (_initialize_ravenscar): Don't initialize base_ptid.
4615         (ravenscar_ops): Remove global.
4616
4617 2019-02-15  Tom Tromey  <tromey@adacore.com>
4618
4619         * target.h (push_target): Declare new overload.
4620         * target.c (push_target): New overload, taking an rvalue reference.
4621         * remote.c (remote_target::open_1): Use push_target overload.
4622         * corelow.c (core_target_open): Use push_target overload.
4623
4624 2019-02-15  Tom Tromey  <tromey@adacore.com>
4625
4626         * ravenscar-thread.c (is_ravenscar_task)
4627         (ravenscar_task_is_currently_active): Return bool.
4628         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4629         (_initialize_ravenscar): Remove "(void)".
4630         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4631         Return bool.
4632
4633 2019-02-15  Tom Tromey  <tromey@adacore.com>
4634
4635         * ravenscar-thread.c (ravenscar_runtime_initializer)
4636         (has_ravenscar_runtime, get_running_thread_id)
4637         (ravenscar_thread_target::resume): Fix indentation.
4638
4639 2019-02-15  Tom Tromey  <tromey@adacore.com>
4640
4641         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4642         from ravenscar_arch_ops.
4643         (sparc_ravenscar_ops::fetch_registers)
4644         (sparc_ravenscar_ops::store_registers): Now methods.
4645         (sparc_ravenscar_prepare_to_store): Remove.
4646         (sparc_ravenscar_ops): Redefine.
4647         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4648         methods and destructor.  Remove members.
4649         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4650         (ravenscar_thread_target::store_registers)
4651         (ravenscar_thread_target::prepare_to_store): Update.
4652         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4653         Remove.
4654         (struct ppc_ravenscar_powerpc_ops): Derive from
4655         ravenscar_arch_ops.
4656         (ppc_ravenscar_powerpc_ops::fetch_registers)
4657         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4658         (ppc_ravenscar_powerpc_ops): Redefine.
4659         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4660         (ppc_ravenscar_e500_ops::fetch_registers)
4661         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4662         (ppc_ravenscar_e500_ops): Redefine.
4663         * aarch64-ravenscar-thread.c
4664         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4665         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4666         (aarch64_ravenscar_fetch_registers)
4667         (aarch64_ravenscar_store_registers): Now methods.
4668         (aarch64_ravenscar_ops): Redefine.
4669
4670 2019-02-15  Tom Tromey  <tromey@adacore.com>
4671
4672         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4673         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4674         (ravenscar_thread_target::stopped_by_watchpoint)
4675         (ravenscar_thread_target::stopped_data_address)
4676         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4677
4678 2019-02-15  Tom Tromey  <tromey@adacore.com>
4679
4680         * ravenscar-thread.c: Fix some typos.
4681
4682 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4683             Tom Tromey  <tromey@adacore.com>
4684
4685         * ada-lang.c (ada_exception_sal): Change addr_string to a
4686         std::string.
4687         (create_ada_exception_catchpoint): Update.
4688
4689 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4690             Tom Tromey  <tromey@adacore.com>
4691
4692         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4693         (bp_location_ops): Remove.
4694         (base_breakpoint_allocate_location): Update.
4695         (free_bp_location): Update.
4696         * ada-lang.c (class ada_catchpoint_location)
4697         <ada_catchpoint_location>: Remove ops parameter.
4698         (ada_catchpoint_location_dtor): Remove.
4699         (ada_catchpoint_location_ops): Remove.
4700         (allocate_location_exception): Update.
4701         * breakpoint.h (struct bp_location_ops): Remove.
4702         (class bp_location) <bp_location>: Remove bp_location_ops
4703         parameter.
4704         <~bp_location>: Add destructor.
4705         <ops>: Remove.
4706
4707 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4708             Pedro Alves  <palves@redhat.com>
4709
4710         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4711         'PATH_MAX'.
4712
4713 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4714             Samuel Thibault  <samuel.thibault@gnu.org>
4715             Thomas Schwinge  <thomas@codesourcery.com>
4716
4717         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4718         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4719
4720 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4721
4722         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4723         (check_empty): Use "const char *".
4724
4725         * gnu-nat.c (gnu_nat_target::detach): Instead of
4726         'detach_inferior (pid)' call
4727         'detach_inferior (find_inferior_pid (pid))'.
4728
4729         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4730         'nat/fork-inferior.o'.
4731         * gnu-nat.c: #include "nat/fork-inferior.h".
4732
4733         * gnu-nat.c (gnu_nat_target::detach): Instead of
4734         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4735         * gnu-nat.h: #include "inf-child.h".
4736         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4737         'i386_gnu_nat_target::fetch_registers'.
4738         (gnu_store_registers): Rename/move to
4739         'i386_gnu_nat_target::store_registers'.
4740
4741         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4742         * gnu-nat.h (mach_thread_info): New function.
4743         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4744
4745         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4746
4747 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4748
4749         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4750
4751 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4752
4753         * windows-nat.c (windows_add_thread): Add new parameter
4754         "main_thread_p" with default value set to false.  Update
4755         function documentation as well as all callers.
4756         (windows_delete_thread): Likewise.
4757         (fake_create_process): Update call to windows_add_thread.
4758         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4759         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4760         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4761         call to windows_delete_thread.
4762
4763 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4764
4765         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4766
4767 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4768
4769         * symfile.c (find_separate_debug_file): Use canonical path of
4770         sysroot with child_path instead of gdb_sysroot if it is valid.
4771
4772 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4773
4774         * symfile.c (find_separate_debug_file): Use child_path to
4775         determine if an object file is under a sysroot.
4776
4777 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4778
4779         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4780         unittests/child-path-selftests.c.
4781         * common/pathstuff.c (child_path): New function.
4782         * common/pathstuff.h (child_path): New prototype.
4783         * unittests/child-path-selftests.c: New file.
4784
4785 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4786
4787         * symfile.c (find_separate_debug_file): Look for separate debug
4788         files in debug directories under the sysroot.
4789
4790 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4791
4792         * symtab.h (struct minimal_symbol data_p): New const method.
4793         (struct minimal_symbol text_p): Likewise.
4794         * symtab.c (output_source_filename): Use file name style
4795         to print file name.
4796         (print_symbol_info): Likewise.
4797         (print_msymbol_info): Use address style to print addresses.
4798         Use function name style to print executable text symbols.
4799         (expand_symtab_containing_pc): Use data_p.
4800         (find_pc_sect_compunit_symtab): Likewise.
4801
4802 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4803
4804         * breakpoint.c (describe_other_breakpoints): Use address style
4805         to print addresses.
4806         (say_where): Likewise.
4807
4808 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4809
4810         * ada-typeprint.c (print_func_type): Print function name
4811         style to print function name.
4812         * c-typeprint.c (c_print_type_1): Likewise.
4813
4814 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4815
4816         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4817         for execve.
4818
4819 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4820
4821         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4822         type_stack.
4823
4824 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4825
4826         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4827         TYPE_CODE_REF types.
4828
4829 2019-02-08  Jim Wilson  <jimw@sifive.com>
4830
4831         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4832         (riscv_linux_fregset): New.
4833         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4834
4835 2019-02-07  Tom Tromey  <tom@tromey.com>
4836
4837         * thread.c (thread_cancel_execution_command): Update.
4838         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4839         methods.
4840         (struct thread_fsm_ops): Remove.
4841         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4842         (thread_fsm_should_stop, thread_fsm_return_value)
4843         (thread_fsm_set_finished, thread_fsm_finished_p)
4844         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4845         Don't declare.
4846         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4847         * infrun.c (clear_proceed_status_thread)
4848         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4849         (print_stop_event): Update.
4850         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4851         Add constructor.
4852         (step_command_fsm_ops): Remove.
4853         (new_step_command_fsm): Remove.
4854         (step_1): Update.
4855         (step_command_fsm::should_stop): Rename from
4856         step_command_fsm_should_stop.
4857         (step_command_fsm::clean_up): Rename from
4858         step_command_fsm_clean_up.
4859         (step_command_fsm::do_async_reply_reason): Rename from
4860         step_command_fsm_async_reply_reason.
4861         (struct until_next_fsm): Inherit from thread_fsm.  Add
4862         constructor.
4863         (until_next_fsm_ops): Remove.
4864         (new_until_next_fsm): Remove.
4865         (until_next_fsm::should_stop): Rename from
4866         until_next_fsm_should_stop.
4867         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4868         (until_next_fsm::do_async_reply_reason): Rename from
4869         until_next_fsm_async_reply_reason.
4870         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4871         constructor.  Change type of breakpoint.
4872         (finish_command_fsm_ops): Remove.
4873         (new_finish_command_fsm): Remove.
4874         (finish_command_fsm::should_stop): Rename from
4875         finish_command_fsm_should_stop.
4876         (finish_command_fsm::clean_up): Rename from
4877         finish_command_fsm_clean_up.
4878         (finish_command_fsm::return_value): Rename from
4879         finish_command_fsm_return_value.
4880         (finish_command_fsm::do_async_reply_reason): Rename from
4881         finish_command_fsm_async_reply_reason.
4882         (finish_command): Update.
4883         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4884         Add constructor.
4885         (call_thread_fsm_ops): Remove.
4886         (call_thread_fsm::call_thread_fsm): Rename from
4887         new_call_thread_fsm.
4888         (call_thread_fsm::should_stop): Rename from
4889         call_thread_fsm_should_stop.
4890         (call_thread_fsm::should_notify_stop): Rename from
4891         call_thread_fsm_should_notify_stop.
4892         (run_inferior_call, call_function_by_hand_dummy): Update.
4893         * cli/cli-interp.c (should_print_stop_to_console): Update.
4894         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4895         Add constructor.  Change type of location_breakpoint,
4896         caller_breakpoint.
4897         (until_break_fsm_ops): Remove.
4898         (new_until_break_fsm): Remove.
4899         (until_break_fsm::should_stop): Rename from
4900         until_break_fsm_should_stop.
4901         (until_break_fsm::clean_up): Rename from
4902         until_break_fsm_clean_up.
4903         (until_break_fsm::do_async_reply_reason): Rename from
4904         until_break_fsm_async_reply_reason.
4905         (until_break_command): Update.
4906         * thread-fsm.c: Remove.
4907         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4908
4909 2019-02-07  Tom Tromey  <tom@tromey.com>
4910
4911         * yy-remap.h: Add include guard.
4912         * xtensa-tdep.h: Add include guard.
4913         * xcoffread.h: Rename include guard.
4914         * varobj-iter.h: Add include guard.
4915         * tui/tui.h: Rename include guard.
4916         * tui/tui-winsource.h: Rename include guard.
4917         * tui/tui-wingeneral.h: Rename include guard.
4918         * tui/tui-windata.h: Rename include guard.
4919         * tui/tui-win.h: Rename include guard.
4920         * tui/tui-stack.h: Rename include guard.
4921         * tui/tui-source.h: Rename include guard.
4922         * tui/tui-regs.h: Rename include guard.
4923         * tui/tui-out.h: Rename include guard.
4924         * tui/tui-layout.h: Rename include guard.
4925         * tui/tui-io.h: Rename include guard.
4926         * tui/tui-hooks.h: Rename include guard.
4927         * tui/tui-file.h: Rename include guard.
4928         * tui/tui-disasm.h: Rename include guard.
4929         * tui/tui-data.h: Rename include guard.
4930         * tui/tui-command.h: Rename include guard.
4931         * tic6x-tdep.h: Add include guard.
4932         * target/waitstatus.h: Rename include guard.
4933         * target/wait.h: Rename include guard.
4934         * target/target.h: Rename include guard.
4935         * target/resume.h: Rename include guard.
4936         * target-float.h: Rename include guard.
4937         * stabsread.h: Add include guard.
4938         * rs6000-tdep.h: Add include guard.
4939         * riscv-fbsd-tdep.h: Add include guard.
4940         * regformats/regdef.h: Rename include guard.
4941         * record.h: Rename include guard.
4942         * python/python.h: Rename include guard.
4943         * python/python-internal.h: Rename include guard.
4944         * python/py-stopevent.h: Rename include guard.
4945         * python/py-ref.h: Rename include guard.
4946         * python/py-record.h: Rename include guard.
4947         * python/py-record-full.h: Rename include guard.
4948         * python/py-record-btrace.h: Rename include guard.
4949         * python/py-instruction.h: Rename include guard.
4950         * python/py-events.h: Rename include guard.
4951         * python/py-event.h: Rename include guard.
4952         * procfs.h: Add include guard.
4953         * proc-utils.h: Add include guard.
4954         * p-lang.h: Add include guard.
4955         * or1k-tdep.h: Rename include guard.
4956         * observable.h: Rename include guard.
4957         * nto-tdep.h: Rename include guard.
4958         * nat/x86-linux.h: Rename include guard.
4959         * nat/x86-linux-dregs.h: Rename include guard.
4960         * nat/x86-gcc-cpuid.h: Add include guard.
4961         * nat/x86-dregs.h: Rename include guard.
4962         * nat/x86-cpuid.h: Rename include guard.
4963         * nat/ppc-linux.h: Rename include guard.
4964         * nat/mips-linux-watch.h: Rename include guard.
4965         * nat/linux-waitpid.h: Rename include guard.
4966         * nat/linux-ptrace.h: Rename include guard.
4967         * nat/linux-procfs.h: Rename include guard.
4968         * nat/linux-osdata.h: Rename include guard.
4969         * nat/linux-nat.h: Rename include guard.
4970         * nat/linux-namespaces.h: Rename include guard.
4971         * nat/linux-btrace.h: Rename include guard.
4972         * nat/glibc_thread_db.h: Rename include guard.
4973         * nat/gdb_thread_db.h: Rename include guard.
4974         * nat/gdb_ptrace.h: Rename include guard.
4975         * nat/fork-inferior.h: Rename include guard.
4976         * nat/amd64-linux-siginfo.h: Rename include guard.
4977         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4978         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4979         * nat/aarch64-linux.h: Rename include guard.
4980         * nat/aarch64-linux-hw-point.h: Rename include guard.
4981         * mn10300-tdep.h: Add include guard.
4982         * mips-linux-tdep.h: Add include guard.
4983         * mi/mi-parse.h: Rename include guard.
4984         * mi/mi-out.h: Rename include guard.
4985         * mi/mi-main.h: Rename include guard.
4986         * mi/mi-interp.h: Rename include guard.
4987         * mi/mi-getopt.h: Rename include guard.
4988         * mi/mi-console.h: Rename include guard.
4989         * mi/mi-common.h: Rename include guard.
4990         * mi/mi-cmds.h: Rename include guard.
4991         * mi/mi-cmd-break.h: Rename include guard.
4992         * m2-lang.h: Add include guard.
4993         * location.h: Rename include guard.
4994         * linux-record.h: Rename include guard.
4995         * linux-nat.h: Add include guard.
4996         * linux-fork.h: Add include guard.
4997         * i386-darwin-tdep.h: Rename include guard.
4998         * hppa-linux-offsets.h: Add include guard.
4999         * guile/guile.h: Rename include guard.
5000         * guile/guile-internal.h: Rename include guard.
5001         * gnu-nat.h: Rename include guard.
5002         * gdb-stabs.h: Rename include guard.
5003         * frv-tdep.h: Add include guard.
5004         * f-lang.h: Add include guard.
5005         * event-loop.h: Add include guard.
5006         * darwin-nat.h: Rename include guard.
5007         * cp-abi.h: Rename include guard.
5008         * config/sparc/nm-sol2.h: Rename include guard.
5009         * config/nm-nto.h: Rename include guard.
5010         * config/nm-linux.h: Add include guard.
5011         * config/i386/nm-i386gnu.h: Rename include guard.
5012         * config/djgpp/nl_types.h: Rename include guard.
5013         * config/djgpp/langinfo.h: Rename include guard.
5014         * compile/gcc-cp-plugin.h: Add include guard.
5015         * compile/gcc-c-plugin.h: Add include guard.
5016         * compile/compile.h: Rename include guard.
5017         * compile/compile-object-run.h: Rename include guard.
5018         * compile/compile-object-load.h: Rename include guard.
5019         * compile/compile-internal.h: Rename include guard.
5020         * compile/compile-cplus.h: Rename include guard.
5021         * compile/compile-c.h: Rename include guard.
5022         * common/xml-utils.h: Rename include guard.
5023         * common/x86-xstate.h: Rename include guard.
5024         * common/version.h: Rename include guard.
5025         * common/vec.h: Rename include guard.
5026         * common/tdesc.h: Rename include guard.
5027         * common/selftest.h: Rename include guard.
5028         * common/scoped_restore.h: Rename include guard.
5029         * common/scoped_mmap.h: Rename include guard.
5030         * common/scoped_fd.h: Rename include guard.
5031         * common/safe-iterator.h: Rename include guard.
5032         * common/run-time-clock.h: Rename include guard.
5033         * common/refcounted-object.h: Rename include guard.
5034         * common/queue.h: Rename include guard.
5035         * common/ptid.h: Rename include guard.
5036         * common/print-utils.h: Rename include guard.
5037         * common/preprocessor.h: Rename include guard.
5038         * common/pathstuff.h: Rename include guard.
5039         * common/observable.h: Rename include guard.
5040         * common/netstuff.h: Rename include guard.
5041         * common/job-control.h: Rename include guard.
5042         * common/host-defs.h: Rename include guard.
5043         * common/gdb_wait.h: Rename include guard.
5044         * common/gdb_vecs.h: Rename include guard.
5045         * common/gdb_unlinker.h: Rename include guard.
5046         * common/gdb_unique_ptr.h: Rename include guard.
5047         * common/gdb_tilde_expand.h: Rename include guard.
5048         * common/gdb_sys_time.h: Rename include guard.
5049         * common/gdb_string_view.h: Rename include guard.
5050         * common/gdb_splay_tree.h: Rename include guard.
5051         * common/gdb_setjmp.h: Rename include guard.
5052         * common/gdb_ref_ptr.h: Rename include guard.
5053         * common/gdb_optional.h: Rename include guard.
5054         * common/gdb_locale.h: Rename include guard.
5055         * common/gdb_assert.h: Rename include guard.
5056         * common/filtered-iterator.h: Rename include guard.
5057         * common/filestuff.h: Rename include guard.
5058         * common/fileio.h: Rename include guard.
5059         * common/environ.h: Rename include guard.
5060         * common/common-utils.h: Rename include guard.
5061         * common/common-types.h: Rename include guard.
5062         * common/common-regcache.h: Rename include guard.
5063         * common/common-inferior.h: Rename include guard.
5064         * common/common-gdbthread.h: Rename include guard.
5065         * common/common-exceptions.h: Rename include guard.
5066         * common/common-defs.h: Rename include guard.
5067         * common/common-debug.h: Rename include guard.
5068         * common/cleanups.h: Rename include guard.
5069         * common/buffer.h: Rename include guard.
5070         * common/btrace-common.h: Rename include guard.
5071         * common/break-common.h: Rename include guard.
5072         * cli/cli-utils.h: Rename include guard.
5073         * cli/cli-style.h: Rename include guard.
5074         * cli/cli-setshow.h: Rename include guard.
5075         * cli/cli-script.h: Rename include guard.
5076         * cli/cli-interp.h: Rename include guard.
5077         * cli/cli-decode.h: Rename include guard.
5078         * cli/cli-cmds.h: Rename include guard.
5079         * charset-list.h: Add include guard.
5080         * buildsym-legacy.h: Rename include guard.
5081         * bfin-tdep.h: Add include guard.
5082         * ax.h: Rename include guard.
5083         * arm-linux-tdep.h: Add include guard.
5084         * arm-fbsd-tdep.h: Add include guard.
5085         * arch/xtensa.h: Rename include guard.
5086         * arch/tic6x.h: Add include guard.
5087         * arch/i386.h: Add include guard.
5088         * arch/arm.h: Rename include guard.
5089         * arch/arm-linux.h: Rename include guard.
5090         * arch/arm-get-next-pcs.h: Rename include guard.
5091         * arch/amd64.h: Add include guard.
5092         * arch/aarch64-insn.h: Rename include guard.
5093         * arch-utils.h: Rename include guard.
5094         * annotate.h: Add include guard.
5095         * amd64-darwin-tdep.h: Rename include guard.
5096         * aarch64-linux-tdep.h: Add include guard.
5097         * aarch64-fbsd-tdep.h: Add include guard.
5098         * aarch32-linux-nat.h: Add include guard.
5099
5100 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5101
5102         * macrotab.c (macro_define_internal): New function that
5103         factorizes macro_define_object_internal and macro_define_function
5104         code.
5105         (macro_define_object_internal): Use macro_define_internal.
5106         (macro_define_function): Likewise.
5107
5108 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5109
5110         * macrocmd.c (extract_identifier): Return
5111         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5112         callers.
5113
5114 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5115
5116         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5117
5118 2019-02-05  Tom Tromey  <tom@tromey.com>
5119
5120         * target.c (target_stack::unpush): Move assertion earlier.
5121
5122 2019-01-30  Tom Tromey  <tom@tromey.com>
5123
5124         PR python/23615:
5125         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5126         (gdbpy_parse_and_eval): Likewise.
5127         * python/python-internal.h (gdbpy_allow_threads): New class.
5128
5129 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5130
5131         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5132         (aarch64_fbsd_fpregmap): Move earlier.
5133         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5134         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5135         instead of individual calls to trad_frame_set_reg_addr.
5136         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5137         earlier.
5138         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5139         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5140         instead of individual calls to trad_frame_set_reg_addr.
5141
5142 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5143
5144         * CONTRIBUTE: Replace contribution list with wiki link.
5145
5146 2019-01-25  Tom Tromey  <tom@tromey.com>
5147
5148         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5149
5150 2019-01-25  Tom Tromey  <tom@tromey.com>
5151
5152         * xtensa-linux-nat.c: Fix common/ includes.
5153         * xml-support.h: Fix common/ includes.
5154         * xml-support.c: Fix common/ includes.
5155         * x86-linux-nat.c: Fix common/ includes.
5156         * windows-nat.c: Fix common/ includes.
5157         * varobj.h: Fix common/ includes.
5158         * varobj.c: Fix common/ includes.
5159         * value.c: Fix common/ includes.
5160         * valops.c: Fix common/ includes.
5161         * utils.c: Fix common/ includes.
5162         * unittests/xml-utils-selftests.c: Fix common/ includes.
5163         * unittests/utils-selftests.c: Fix common/ includes.
5164         * unittests/unpack-selftests.c: Fix common/ includes.
5165         * unittests/tracepoint-selftests.c: Fix common/ includes.
5166         * unittests/style-selftests.c: Fix common/ includes.
5167         * unittests/string_view-selftests.c: Fix common/ includes.
5168         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5169         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5170         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5171         * unittests/rsp-low-selftests.c: Fix common/ includes.
5172         * unittests/parse-connection-spec-selftests.c: Fix common/
5173         includes.
5174         * unittests/optional-selftests.c: Fix common/ includes.
5175         * unittests/offset-type-selftests.c: Fix common/ includes.
5176         * unittests/observable-selftests.c: Fix common/ includes.
5177         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5178         * unittests/memrange-selftests.c: Fix common/ includes.
5179         * unittests/memory-map-selftests.c: Fix common/ includes.
5180         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5181         * unittests/function-view-selftests.c: Fix common/ includes.
5182         * unittests/environ-selftests.c: Fix common/ includes.
5183         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5184         * unittests/common-utils-selftests.c: Fix common/ includes.
5185         * unittests/cli-utils-selftests.c: Fix common/ includes.
5186         * unittests/array-view-selftests.c: Fix common/ includes.
5187         * ui-file.c: Fix common/ includes.
5188         * tui/tui-io.c: Fix common/ includes.
5189         * tracepoint.h: Fix common/ includes.
5190         * tracepoint.c: Fix common/ includes.
5191         * tracefile-tfile.c: Fix common/ includes.
5192         * top.h: Fix common/ includes.
5193         * top.c: Fix common/ includes.
5194         * thread.c: Fix common/ includes.
5195         * target/waitstatus.h: Fix common/ includes.
5196         * target/waitstatus.c: Fix common/ includes.
5197         * target.h: Fix common/ includes.
5198         * target.c: Fix common/ includes.
5199         * target-memory.c: Fix common/ includes.
5200         * target-descriptions.c: Fix common/ includes.
5201         * symtab.h: Fix common/ includes.
5202         * symfile.c: Fix common/ includes.
5203         * stap-probe.c: Fix common/ includes.
5204         * spu-linux-nat.c: Fix common/ includes.
5205         * sparc-nat.c: Fix common/ includes.
5206         * source.c: Fix common/ includes.
5207         * solib.c: Fix common/ includes.
5208         * solib-target.c: Fix common/ includes.
5209         * ser-unix.c: Fix common/ includes.
5210         * ser-tcp.c: Fix common/ includes.
5211         * ser-pipe.c: Fix common/ includes.
5212         * ser-base.c: Fix common/ includes.
5213         * selftest-arch.c: Fix common/ includes.
5214         * s12z-tdep.c: Fix common/ includes.
5215         * rust-exp.y: Fix common/ includes.
5216         * rs6000-aix-tdep.c: Fix common/ includes.
5217         * riscv-tdep.c: Fix common/ includes.
5218         * remote.c: Fix common/ includes.
5219         * remote-notif.h: Fix common/ includes.
5220         * remote-fileio.h: Fix common/ includes.
5221         * remote-fileio.c: Fix common/ includes.
5222         * regcache.h: Fix common/ includes.
5223         * regcache.c: Fix common/ includes.
5224         * record-btrace.c: Fix common/ includes.
5225         * python/python.c: Fix common/ includes.
5226         * python/py-type.c: Fix common/ includes.
5227         * python/py-inferior.c: Fix common/ includes.
5228         * progspace.h: Fix common/ includes.
5229         * producer.c: Fix common/ includes.
5230         * procfs.c: Fix common/ includes.
5231         * proc-api.c: Fix common/ includes.
5232         * printcmd.c: Fix common/ includes.
5233         * ppc-linux-nat.c: Fix common/ includes.
5234         * parser-defs.h: Fix common/ includes.
5235         * osdata.c: Fix common/ includes.
5236         * obsd-nat.c: Fix common/ includes.
5237         * nat/x86-linux.c: Fix common/ includes.
5238         * nat/x86-linux-dregs.c: Fix common/ includes.
5239         * nat/x86-dregs.h: Fix common/ includes.
5240         * nat/x86-dregs.c: Fix common/ includes.
5241         * nat/ppc-linux.c: Fix common/ includes.
5242         * nat/mips-linux-watch.h: Fix common/ includes.
5243         * nat/mips-linux-watch.c: Fix common/ includes.
5244         * nat/linux-waitpid.c: Fix common/ includes.
5245         * nat/linux-ptrace.h: Fix common/ includes.
5246         * nat/linux-ptrace.c: Fix common/ includes.
5247         * nat/linux-procfs.c: Fix common/ includes.
5248         * nat/linux-personality.c: Fix common/ includes.
5249         * nat/linux-osdata.c: Fix common/ includes.
5250         * nat/linux-namespaces.c: Fix common/ includes.
5251         * nat/linux-btrace.h: Fix common/ includes.
5252         * nat/linux-btrace.c: Fix common/ includes.
5253         * nat/fork-inferior.c: Fix common/ includes.
5254         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5255         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5256         * nat/aarch64-linux.c: Fix common/ includes.
5257         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5258         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5259         * namespace.h: Fix common/ includes.
5260         * mips-linux-tdep.c: Fix common/ includes.
5261         * minsyms.c: Fix common/ includes.
5262         * mi/mi-parse.h: Fix common/ includes.
5263         * mi/mi-main.c: Fix common/ includes.
5264         * mi/mi-cmd-env.c: Fix common/ includes.
5265         * memrange.h: Fix common/ includes.
5266         * memattr.c: Fix common/ includes.
5267         * maint.h: Fix common/ includes.
5268         * maint.c: Fix common/ includes.
5269         * main.c: Fix common/ includes.
5270         * machoread.c: Fix common/ includes.
5271         * location.c: Fix common/ includes.
5272         * linux-thread-db.c: Fix common/ includes.
5273         * linux-nat.c: Fix common/ includes.
5274         * linux-fork.c: Fix common/ includes.
5275         * inline-frame.c: Fix common/ includes.
5276         * infrun.c: Fix common/ includes.
5277         * inflow.c: Fix common/ includes.
5278         * inferior.h: Fix common/ includes.
5279         * inferior.c: Fix common/ includes.
5280         * infcmd.c: Fix common/ includes.
5281         * inf-ptrace.c: Fix common/ includes.
5282         * inf-child.c: Fix common/ includes.
5283         * ia64-linux-nat.c: Fix common/ includes.
5284         * i387-tdep.c: Fix common/ includes.
5285         * i386-tdep.c: Fix common/ includes.
5286         * i386-linux-tdep.c: Fix common/ includes.
5287         * i386-linux-nat.c: Fix common/ includes.
5288         * i386-go32-tdep.c: Fix common/ includes.
5289         * i386-fbsd-tdep.c: Fix common/ includes.
5290         * i386-fbsd-nat.c: Fix common/ includes.
5291         * guile/scm-type.c: Fix common/ includes.
5292         * guile/guile.c: Fix common/ includes.
5293         * go32-nat.c: Fix common/ includes.
5294         * gnu-nat.c: Fix common/ includes.
5295         * gdbthread.h: Fix common/ includes.
5296         * gdbarch-selftests.c: Fix common/ includes.
5297         * gdb_usleep.c: Fix common/ includes.
5298         * gdb_select.h: Fix common/ includes.
5299         * gdb_bfd.c: Fix common/ includes.
5300         * gcore.c: Fix common/ includes.
5301         * fork-child.c: Fix common/ includes.
5302         * findvar.c: Fix common/ includes.
5303         * fbsd-nat.c: Fix common/ includes.
5304         * event-top.c: Fix common/ includes.
5305         * event-loop.c: Fix common/ includes.
5306         * dwarf2read.c: Fix common/ includes.
5307         * dwarf2loc.c: Fix common/ includes.
5308         * dwarf2-frame.c: Fix common/ includes.
5309         * dwarf-index-cache.c: Fix common/ includes.
5310         * dtrace-probe.c: Fix common/ includes.
5311         * disasm-selftests.c: Fix common/ includes.
5312         * defs.h: Fix common/ includes.
5313         * csky-tdep.c: Fix common/ includes.
5314         * cp-valprint.c: Fix common/ includes.
5315         * cp-support.h: Fix common/ includes.
5316         * cp-support.c: Fix common/ includes.
5317         * corelow.c: Fix common/ includes.
5318         * completer.h: Fix common/ includes.
5319         * completer.c: Fix common/ includes.
5320         * compile/compile.c: Fix common/ includes.
5321         * compile/compile-loc2c.c: Fix common/ includes.
5322         * compile/compile-cplus-types.c: Fix common/ includes.
5323         * compile/compile-cplus-symbols.c: Fix common/ includes.
5324         * command.h: Fix common/ includes.
5325         * cli/cli-dump.c: Fix common/ includes.
5326         * cli/cli-cmds.c: Fix common/ includes.
5327         * charset.c: Fix common/ includes.
5328         * build-id.c: Fix common/ includes.
5329         * btrace.h: Fix common/ includes.
5330         * btrace.c: Fix common/ includes.
5331         * breakpoint.h: Fix common/ includes.
5332         * breakpoint.c: Fix common/ includes.
5333         * ax.h:
5334         (enum agent_op): Fix common/ includes.
5335         * ax-general.c (struct aop_map): Fix common/ includes.
5336         * ax-gdb.c: Fix common/ includes.
5337         * auxv.c: Fix common/ includes.
5338         * auto-load.c: Fix common/ includes.
5339         * arm-tdep.c: Fix common/ includes.
5340         * arch/riscv.c: Fix common/ includes.
5341         * arch/ppc-linux-common.c: Fix common/ includes.
5342         * arch/i386.c: Fix common/ includes.
5343         * arch/arm.c: Fix common/ includes.
5344         * arch/arm-linux.c: Fix common/ includes.
5345         * arch/arm-get-next-pcs.c: Fix common/ includes.
5346         * arch/amd64.c: Fix common/ includes.
5347         * arch/aarch64.c: Fix common/ includes.
5348         * arch/aarch64-insn.c: Fix common/ includes.
5349         * arch-utils.c: Fix common/ includes.
5350         * amd64-windows-tdep.c: Fix common/ includes.
5351         * amd64-tdep.c: Fix common/ includes.
5352         * amd64-sol2-tdep.c: Fix common/ includes.
5353         * amd64-obsd-tdep.c: Fix common/ includes.
5354         * amd64-nbsd-tdep.c: Fix common/ includes.
5355         * amd64-linux-tdep.c: Fix common/ includes.
5356         * amd64-linux-nat.c: Fix common/ includes.
5357         * amd64-fbsd-tdep.c: Fix common/ includes.
5358         * amd64-fbsd-nat.c: Fix common/ includes.
5359         * amd64-dicos-tdep.c: Fix common/ includes.
5360         * amd64-darwin-tdep.c: Fix common/ includes.
5361         * agent.c: Fix common/ includes.
5362         * ada-lang.h: Fix common/ includes.
5363         * ada-lang.c: Fix common/ includes.
5364         * aarch64-tdep.c: Fix common/ includes.
5365
5366 2019-01-25  Tom Tromey  <tom@tromey.com>
5367
5368         * common/create-version.sh: Use common/version.h.
5369
5370 2019-01-24  Pedro Alves  <palves@redhat.com>
5371
5372         * infrun.c (signal_stop, signal_print, signal_program)
5373         (signal_catch, signal_pass): Now arrays instead of pointers.
5374         (update_signals_program_target, do_target_resume)
5375         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5376         * linux-nat.c (linux_nat_target::pass_signals)
5377         (linux_nat_target::create_inferior, linux_nat_target::attach):
5378         Adjust.
5379         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5380         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5381         * procfs.c (procfs_target::pass_signals): Adjust.
5382         * record-full.c (record_full_target::resume): Adjust.
5383         * remote.c (remote_target::pass_signals)
5384         (remote_target::program_signals): Adjust.
5385         * target-debug.h (target_debug_print_signals): Now takes a
5386         gdb::array_view as parameter.  Adjust.
5387         * target.h (target_ops) <pass_signals, program_signals>: Replace
5388         pointer and length parameters with gdb::array_view.
5389         (target_pass_signals, target_program_signals): Likewise.
5390         * target-delegates.c: Regenerate.
5391
5392 2019-01-24  Pedro Alves  <palves@redhat.com>
5393
5394         * common/forward-scope-exit.h
5395         (forward_scope_exit::forward_scope_exit): Pass arguments to
5396         m_bind_function directly, instead of creating a std::bind and
5397         copying that.
5398
5399 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5400
5401         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5402         for static members.
5403         (pass_in_v_vfp_candidate): Likewise.
5404
5405 2019-01-23  Tom Tromey  <tom@tromey.com>
5406             Pedro Alves  <palves@redhat.com>
5407
5408         * regcache.c (class regcache_invalidator): Remove.
5409         (regcache::raw_write): Use make_scope_exit.
5410
5411 2019-01-23  Tom Tromey  <tom@tromey.com>
5412
5413         * ui-out.h (class ui_out_emit_type): Update comment.
5414
5415 2019-01-23  Tom Tromey  <tom@tromey.com>
5416
5417         * infrun.c (fetch_inferior_event): Update comment.
5418
5419 2019-01-23  Tom Tromey  <tom@tromey.com>
5420             Pedro Alves  <palves@redhat.com>
5421
5422         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5423         parameter.
5424         (fetch_inferior_event): Use SCOPE_EXIT.
5425
5426
5427 2019-01-23  Tom Tromey  <tom@tromey.com>
5428             Pedro Alves  <palves@redhat.com>
5429
5430         * infrun.c (disable_thread_events): Delete.
5431         (stop_all_threads): Use SCOPE_EXIT.
5432
5433 2019-01-23  Tom Tromey  <tom@tromey.com>
5434             Pedro Alves  <palves@redhat.com>
5435
5436         * symfile.c: Include forward-scope-exit.h.
5437         (clear_symtab_users_cleanup): Replace forward declaration with
5438         a FORWARD_SCOPE_EXIT.
5439         (syms_from_objfile_1): Use the forward_scope_exit and
5440         gdb::optional instead of cleanup_function.
5441         (reread_symbols): Use the forward_scope_exit instead of
5442         cleanup_function.
5443         (clear_symtab_users_cleanup): Remove function.
5444
5445 2019-01-23  Tom Tromey  <tom@tromey.com>
5446             Pedro Alves  <palves@redhat.com>
5447
5448         * linux-nat.c: Include scope-exit.h.
5449         (cleanup_target_stop): Remove.
5450         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5451         SCOPE_EXIT.
5452
5453 2019-01-23  Tom Tromey  <tom@tromey.com>
5454             Pedro Alves  <palves@redhat.com>
5455
5456         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5457         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5458
5459 2019-01-23  Tom Tromey  <tom@tromey.com>
5460             Andrew Burgess  <andrew.burgess@embecosm.com>
5461             Pedro Alves  <palves@redhat.com>
5462
5463         * infrun.c (fetch_inferior_event): Use scope_exit.
5464         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5465         * top.c (execute_command): Use scope_exit.
5466         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5467         * utils.c (do_bpstat_clear_actions_cleanup)
5468         (make_bpstat_clear_actions_cleanup): Remove.
5469
5470 2019-01-23  Tom Tromey  <tom@tromey.com>
5471             Pedro Alves  <palves@redhat.com>
5472
5473         * infrun.c: Include "common/scope-exit.h"
5474         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5475         (wait_for_inferior): Use SCOPE_EXIT.
5476         (fetch_inferior_event): Use scope_exit.
5477
5478 2019-01-23  Tom Tromey  <tom@tromey.com>
5479             Pedro Alves  <palves@redhat.com>
5480
5481         * breakpoint.c (create_breakpoint): Remove cleanup.
5482
5483 2019-01-23  Tom Tromey  <tom@tromey.com>
5484             Andrew Burgess  <andrew.burgess@embecosm.com>
5485             Pedro Alves  <palves@redhat.com>
5486
5487 2019-01-23  Pedro Alves  <palves@redhat.com>
5488
5489         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5490
5491 2019-01-23  Pedro Alves  <palves@redhat.com>
5492             Andrew Burgess  <andrew.burgess@embecosm.com>
5493
5494         * gdbthread.h: Include "common/forward-scope-exit.h".
5495         (scoped_finish_thread_state): Redefine custom class in terms of
5496         forward_scope_exit.
5497
5498 2019-01-23  Pedro Alves  <palves@redhat.com>
5499             Andrew Burgess  <andrew.burgess@embecosm.com>
5500
5501         * common/forward-scope-exit.h: New file.
5502
5503 2019-01-23  Pedro Alves  <palves@redhat.com>
5504             Andrew Burgess  <andrew.burgess@embecosm.com>
5505             Tom Tromey  <tom@tromey.com>
5506
5507         * common/scope-exit.h: New file.
5508
5509 2019-01-23  Pedro Alves  <palves@redhat.com>
5510
5511         * common/preprocessor.h (ESC): Rename to ...
5512         (ESC_PARENS): ... this.
5513         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5514         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5515
5516 2019-01-23  Tom Tromey  <tom@tromey.com>
5517
5518         * language.h (class scoped_switch_to_sym_language_if_auto):
5519         Initialize m_lang in both cases.
5520
5521 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5522
5523         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5524         with XCNEW.
5525
5526 2019-01-22  Tom Tromey  <tom@tromey.com>
5527
5528         * corelow.c: Do not include sys/file.h.
5529
5530 2019-01-22  Tom Tromey  <tom@tromey.com>
5531
5532         * tui/tui-wingeneral.h: Include gdb_curses.h.
5533
5534 2019-01-22  Tom Tromey  <tom@tromey.com>
5535
5536         * source-cache.h (class source_cache) <get_source_lines,
5537         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5538
5539 2019-01-22  Tom Tromey  <tom@tromey.com>
5540
5541         * remote-fileio.h (struct remote_target): Declare.
5542
5543 2019-01-22  Tom Tromey  <tom@tromey.com>
5544
5545         * python/py-arch.c: Do not include py-ref.h.
5546         * python/py-bpevent.c: Do not include py-ref.h.
5547         * python/py-cmd.c: Do not include py-ref.h.
5548         * python/py-continueevent.c: Do not include py-ref.h.
5549         * python/py-event.h: Do not include py-ref.h.
5550         * python/py-evtregistry.c: Do not include py-ref.h.
5551         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5552         * python/py-frame.c: Do not include py-ref.h.
5553         * python/py-framefilter.c: Do not include py-ref.h.
5554         * python/py-function.c: Do not include py-ref.h.
5555         * python/py-infevents.c: Do not include py-ref.h.
5556         * python/py-linetable.c: Do not include py-ref.h.
5557         * python/py-objfile.c: Do not include py-ref.h.
5558         * python/py-param.c: Do not include py-ref.h.
5559         * python/py-prettyprint.c: Do not include py-ref.h.
5560         * python/py-progspace.c: Do not include py-ref.h.
5561         * python/py-symbol.c: Do not include py-ref.h.
5562         * python/py-symtab.c: Do not include py-ref.h.
5563         * python/py-type.c: Do not include py-ref.h.
5564         * python/py-unwind.c: Do not include py-ref.h.
5565         * python/py-utils.c: Do not include py-ref.h.
5566         * python/py-value.c: Do not include py-ref.h.
5567         * python/py-varobj.c: Do not include py-ref.h.
5568         * python/py-xmethods.c: Do not include py-ref.h.
5569         * python/python.c: Do not include py-ref.h.
5570         * varobj.c: Do not include py-ref.h.
5571
5572 2019-01-22  Tom Tromey  <tom@tromey.com>
5573
5574         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5575         keyword for bcache.
5576
5577 2019-01-22  Tom Tromey  <tom@tromey.com>
5578
5579         * compile/compile-cplus-types.c: Remove a comment by #include.
5580
5581 2019-01-22  Tom Tromey  <tom@tromey.com>
5582
5583         * compile/gcc-c-plugin.h: Include compile-internal.h.
5584
5585 2019-01-22  Tom Tromey  <tom@tromey.com>
5586
5587         * stabsread.c (EXTERN): Do not define.
5588         (symnum, next_symbol_text_func, processing_gcc_compilation)
5589         (within_function, global_sym_chain, global_stabs)
5590         (previous_stab_code, this_object_header_files)
5591         (n_this_object_header_files)
5592         (n_allocated_this_object_header_files): Define.
5593         * stabsread.h (EXTERN): Never define.  Use "extern".
5594
5595 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5596
5597         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5598         history_value.
5599
5600 2019-01-21  Tom Tromey  <tom@tromey.com>
5601
5602         * ui-out.c: Fix includes.
5603         * tui/tui-source.c: Fix includes.
5604         * target.c: Fix includes.
5605         * remote.c: Fix includes.
5606         * regcache.c: Fix includes.
5607         * python/py-block.c: Fix includes.
5608         * printcmd.c: Fix includes.
5609         * or1k-tdep.c: Fix includes.
5610         * mi/mi-main.c: Fix includes.
5611         * m32r-tdep.c: Fix includes.
5612         * csky-tdep.c: Fix includes.
5613         * compile/compile-cplus-types.c: Fix includes.
5614         * cli/cli-interp.c: Fix includes.
5615
5616 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5617
5618         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5619         for padding.
5620
5621 2019-01-16  Tom Tromey  <tom@tromey.com>
5622
5623         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5624         earlier.
5625         (struct objfile) <msymbols_range>: Move from top level.
5626         <msymbols>: New method.
5627         (class objfile_msymbols): Remove.
5628         * symtab.c (default_collect_symbol_completion_matches_break_on):
5629         Update.
5630         * symmisc.c (dump_msymbols): Update.
5631         * stabsread.c (scan_file_globals): Update.
5632         * objc-lang.c (info_selectors_command, info_classes_command)
5633         (find_methods): Update.
5634         * minsyms.c (find_solib_trampoline_target): Update.
5635         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5636         * coffread.c (coff_symfile_read): Update.
5637         * ada-lang.c (ada_lookup_simple_minsym)
5638         (ada_collect_symbol_completion_matches): Update.
5639
5640 2019-01-16  Tom Tromey  <tom@tromey.com>
5641
5642         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5643         type.  Remove no-argument constructor.
5644         <iterator::operator++>: Simplify.
5645         <begin>: Update.
5646         <end>: Use minimal_symbol_count.
5647
5648 2019-01-16  Tom Tromey  <tom@tromey.com>
5649
5650         * objfiles.h (struct objfile) <psymtabs>: New method.
5651         (class objfile_psymtabs): Remove.
5652         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5653         typedef.
5654         <range>: New method.
5655         (require_partial_symbols): Change return type.
5656         * psymtab.c (require_partial_symbols)
5657         (psym_expand_symtabs_matching): Update.
5658         * mdebugread.c (parse_partial_symbols): Update.
5659         * dbxread.c (dbx_end_psymtab): Update.
5660
5661 2019-01-15  Tom Tromey  <tom@tromey.com>
5662
5663         * symtab.c (lookup_objfile_from_block)
5664         (lookup_symbol_in_objfile_symtabs)
5665         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5666         (find_line_symtab, info_sources_command)
5667         (default_collect_symbol_completion_matches_break_on)
5668         (make_source_files_completion_list): Update.
5669         * symmisc.c (print_objfile_statistics, dump_objfile)
5670         (maintenance_print_symbols, maintenance_info_symtabs)
5671         (maintenance_check_symtabs, maintenance_info_line_tables):
5672         Update.
5673         * source.c (select_source_symtab)
5674         (forget_cached_source_info_for_objfile): Update.
5675         * objfiles.h (class objfile_compunits): Remove.
5676         (struct objfile) <compunits_range>: New typedef.
5677         (compunits): New method.
5678         * objfiles.c (objfile_relocate1): Update.
5679         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5680         * maint.c (count_symtabs_and_blocks): Update.
5681         * linespec.c (iterate_over_all_matching_symtabs): Update.
5682         * cp-support.c (add_symbol_overload_list_qualified): Update.
5683         * coffread.c (coff_symtab_read): Update.
5684         * ada-lang.c (add_nonlocal_symbols)
5685         (ada_collect_symbol_completion_matches)
5686         (ada_add_global_exceptions): Update.
5687
5688 2019-01-15  Tom Tromey  <tom@tromey.com>
5689
5690         * progspace.h (program_space) <objfiles_safe_range>: New
5691         typedef.
5692         <objfiles_safe>: New method.
5693         * objfiles.h (class all_objfiles_safe): Remove.
5694         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5695         * jit.c (jit_inferior_exit_hook): Update.
5696
5697 2019-01-17  Tom Tromey  <tom@tromey.com>
5698
5699         * progspace.h (program_space) <objfiles_range>: New typedef.
5700         <objfiles>: New method.
5701         <objfiles_head>: Rename from objfiles.
5702         (object_files): Update.
5703         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5704         * guile/scm-pretty-print.c
5705         (ppscm_find_pretty_printer_from_objfiles): Update.
5706         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5707         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5708         Update.
5709         * python/py-progspace.c (pspy_get_objfiles): Update.
5710         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5711         Update.
5712         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5713         (objfpy_lookup_objfile_by_build_id): Update.
5714         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5715         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5716         Update.
5717         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5718         (expand_symtab_containing_pc, lookup_objfile_from_block)
5719         (lookup_static_symbol, basic_lookup_transparent_type)
5720         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5721         (find_line_symtab, info_sources_command)
5722         (default_collect_symbol_completion_matches_break_on)
5723         (make_source_files_completion_list, find_main_name): Update.
5724         * symmisc.c (print_symbol_bcache_statistics)
5725         (print_objfile_statistics, maintenance_print_symbols)
5726         (maintenance_print_msymbols, maintenance_print_objfiles)
5727         (maintenance_info_symtabs, maintenance_check_symtabs)
5728         (maintenance_expand_symtabs, maintenance_info_line_tables):
5729         Update.
5730         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5731         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5732         (map_overlay_command, unmap_overlay_command)
5733         (simple_overlay_update, expand_symtabs_matching)
5734         (map_symbol_filenames): Update.
5735         * symfile-debug.c (set_debug_symfile): Update.
5736         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5737         Update.
5738         * source.c (select_source_symtab, forget_cached_source_info):
5739         Update.
5740         * solib.c (solib_read_symbols): Update.
5741         * solib-spu.c (append_ocl_sos): Update.
5742         * psymtab.c (maintenance_print_psymbols)
5743         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5744         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5745         * printcmd.c (info_symbol_command): Update.
5746         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5747         Update.
5748         * objfiles.h (class all_objfiles): Remove.
5749         * objfiles.c (have_partial_symbols, have_full_symbols)
5750         (have_minimal_symbols, qsort_cmp, update_section_map)
5751         (shared_objfile_contains_address_p)
5752         (default_iterate_over_objfiles_in_search_order): Update.
5753         * objc-lang.c (info_selectors_command, info_classes_command)
5754         (find_methods): Update.
5755         * minsyms.c (find_solib_trampoline_target): Update.
5756         * maint.c (maintenance_info_sections)
5757         (maintenance_translate_address, count_symtabs_and_blocks):
5758         Update.
5759         * main.c (captured_main_1): Update.
5760         * linux-thread-db.c (try_thread_db_load_from_pdir)
5761         (has_libpthread): Update.
5762         * linespec.c (iterate_over_all_matching_symtabs)
5763         (search_minsyms_for_name): Update.
5764         * jit.c (jit_find_objf_with_entry_addr): Update.
5765         * hppa-tdep.c (find_unwind_entry)
5766         (hppa_lookup_stub_minimal_symbol): Update.
5767         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5768         Update.
5769         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5770         (elf_gnu_ifunc_resolve_by_got): Update.
5771         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5772         * dwarf-index-write.c (save_gdb_index_command): Update.
5773         * cp-support.c (add_symbol_overload_list_qualified): Update.
5774         * breakpoint.c (create_overlay_event_breakpoint)
5775         (create_longjmp_master_breakpoint)
5776         (create_std_terminate_master_breakpoint)
5777         (create_exception_master_breakpoint): Update.
5778         * blockframe.c (find_pc_partial_function): Update.
5779         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5780         (ada_collect_symbol_completion_matches)
5781         (ada_add_global_exceptions): Update.
5782
5783 2019-01-17  Tom Tromey  <tom@tromey.com>
5784
5785         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5786         declare VEC.
5787         (solib_target_parse_libraries): Change return type.
5788         (library_list_start_segment, library_list_start_section)
5789         (library_list_end_library, library_list_start_library); Update.
5790         (solib_target_free_library_list): Remove.
5791         (solib_target_parse_libraries): Remove cleanup.  Change return
5792         type.
5793         (solib_target_current_sos): Update.
5794
5795 2019-01-17  Tom Tromey  <tromey@bapiya>
5796
5797         * valprint.c: Replace "the the" with "the".
5798         * symtab.c: Replace "the the" with "the".
5799         * solib.c: Replace "the the" with "the".
5800         * solib-dsbt.c: Replace "the the" with "the".
5801         * linespec.c: Replace "the the" with "the".
5802         * dwarf2loc.h: Replace "the the" with "the".
5803         * amd64-windows-tdep.c: Replace "the the" with "the".
5804         * aarch64-tdep.c: Replace "the the" with "the".
5805
5806 2019-01-16  Keith Seitz  <keiths@redhat.com>
5807
5808         PR gdb/23773
5809         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5810         <builder>: Rename to ..
5811         <m_builder>: ... this and make private.
5812         (dwarf2_cu::get_builder): New method.  Change all users of
5813         `builder' to use this method.
5814         (dwarf2_start_symtab): Move to ...
5815         (dwarf2_cu::start_symtab): ... here.  Update all callers
5816         (setup_type_unit_groups): Move to ...
5817         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5818         callers.
5819         (dwarf2_cu::reset_builder): New method.
5820         (process_full_compunit, process_full_type_unit): Use
5821         dwarf2_cu::reset_builder.
5822         (follow_die_offset): Record the ancestor CU if it is different
5823         from the followed DIE's CU.
5824         (follow_die_sig_1): Likewise.
5825
5826 2019-01-15  Tom Tromey  <tom@tromey.com>
5827
5828         * remote.c (class remote_state) <buf>: Now a char_vector.
5829         <buf_size>: Remove.
5830         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5831         parameter.
5832         (remote_target::getpkt_or_notif_sane_1)
5833         (remote_target::getpkt_sane)
5834         (remote_target::getpkt_or_notif_sane): Likewise.
5835         (class remote_target) <putpkt>: New overload.
5836         (remote_target::read_frame): Change type of "buf_p".  Remove
5837         sizeof_p parameter.
5838         (packet_ok): New overload.
5839         (packet_check_result): New overload.
5840         Update all uses.
5841
5842 2019-01-14  Tom Tromey  <tom@tromey.com>
5843
5844         * remote-notif.c (handle_notification, remote_notif_ack)
5845         (remote_notif_parse): Make "buf" const.
5846         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5847         const.
5848         (remote_notif_parse, remote_notif_ack, handle_notification):
5849         Likewise.
5850         * remote.c (remote_notif_stop_parse): Make "buf" const.
5851         (remote_target::remote_parse_stop_reply): Make "buf" const.
5852         (remote_notif_stop_ack): Make "buf" const.
5853
5854 2019-01-14  Tom Tromey  <tom@tromey.com>
5855
5856         * remote.c (remote_console_output): Make parameter const.
5857
5858 2019-01-14  Tom Tromey  <tom@tromey.com>
5859
5860         * target-debug.h (target_debug_print_signals): Constify.
5861         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5862         * procfs.c (procfs_target::pass_signals): Update.
5863         * linux-nat.c (linux_nat_target::pass_signals): Update.
5864         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5865         * target-delegates.c: Rebuild.
5866         * remote.c (remote_target::program_signals): Update.
5867         (remote_target::pass_signals): Update.
5868         * target.c (target_pass_signals): Constify argument.
5869         (target_program_signals): Likewise.
5870         * target.h (struct target_ops) <pass_signals, program_signals>:
5871         Constify argument.
5872         (target_pass_signals, target_program_signals): Constify argument.
5873
5874 2019-01-14  Tom Tromey  <tom@tromey.com>
5875
5876         PR tui/28819:
5877         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5878
5879 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5880
5881         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5882         field.
5883         * rs6000-tdep.c: Include reggroups.h.
5884         (IS_V_ALIAS_PSEUDOREG): Define.
5885         (rs6000_register_name): Return names for the "vX" aliases.
5886         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5887         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5888         aliases.  Call default_register_reggroup_p for all other
5889         pseudo-registers.
5890         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5891         New functions.
5892         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5893         Handle "vX" aliases.
5894         (v_alias_pseudo_register_collect): New function.
5895         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5896         (rs6000_gdbarch_init): Initialize "vX" aliases as
5897         pseudo-registers.  Restore registration of
5898         rs6000_pseudo_register_reggroup_p with
5899         set_tdesc_pseudo_register_reggroup_p.
5900
5901 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5902
5903         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5904         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5905         set_gdbarch_num_pseudo_regs.
5906
5907 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5908
5909         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5910         Remove arg prefixname, add do_set and do_show.
5911         Add member functions set_list and show_list.
5912         * cli/cli-style.c (class cli_style_option): Update accordingly.
5913         (style_set_list): Move to file scope.
5914         (style_show_list): Likewise.
5915         (set_style): Call help_list.
5916         (show_style): Call cmd_show_list.
5917         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5918         Update to use the new macro.
5919
5920 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5921
5922         * ada-lang.c (_initialize_ada_language): Expand the help text
5923         for the "catch exception" command.
5924
5925 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5926
5927         * symtab.c (matching_obj_sections): Initialize obj,
5928         declare it closer to its usage.
5929
5930 2019-01-10  Tom Tromey  <tom@tromey.com>
5931
5932         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5933         (basic_inf_threads_range): Remove.
5934         (inf_threads_range, inf_non_exited_threads_range)
5935         (safe_inf_threads_range): Use next_adapter.
5936
5937 2019-01-10  Keith Seitz  <keiths@redhat.com>
5938
5939         PR gdb/23712
5940         PR symtab/23010
5941         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5942         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5943
5944 2019-01-10  Keith Seitz  <keiths@redhat.com>
5945
5946         PR gdb/23712
5947         PR symtab/23010
5948         * dictionary.c (pending_to_vector): Remove.
5949         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5950         Remove _1 suffix, replacing functions of the same name.  Update
5951         all callers.
5952         (dict_create_hashed, dict_create_hashed_expandable)
5953         (dict_create_linear, dict_create_linear_expandable, dict_free)
5954         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5955         Make functions static.
5956
5957 2019-01-10  Keith Seitz  <keiths@redhat.com>
5958
5959         PR gdb/23712
5960         PR symtab/23010
5961         * dictionary.h (struct dictionary): Replace declaration with
5962         multidictionary.
5963         (dict_create_hashed, dict_create_hashed_expandable)
5964         (dict_create_linear, dict_create_linear_expandable)
5965         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5966         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5967         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5968         taking multidictionary argument.
5969         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5970         * block.h (struct block) <dict>: Change to multidictionary
5971         and rename `multidict'.
5972         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5973         symmisc.c: Update all dictionary references to multidictionary.
5974
5975 2019-01-10  Keith Seitz  <keiths@redhat.com>
5976
5977         PR gdb/23712
5978         PR symtab/23010
5979         * dictionary.c: Include unordered_map.
5980         (pending_to_vector): New function.
5981         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5982         Rewrite the non-"_1" functions to take vector instead
5983         of linked list.
5984         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5985         "new" _1 versions of the same name.
5986         (multidictionary): Define.
5987         (std::hash<enum language): New definition.
5988         (collate_pending_symbols_by_language, mdict_create_hashed)
5989         (mdict_create_hashed_expandable, mdict_create_linear)
5990         (mdict_create_linear_expandable, mdict_free)
5991         (find_language_dictionary, create_new_language_dictionary)
5992         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5993         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5994         (mdict_size, mdict_empty): New functions.
5995         * dictionary.h (mdict_iterator): Define.
5996
5997 2019-01-10  Pedro Alves  <palves@redhat.com>
5998
5999         * breakpoint.c (read_uploaded_action)
6000         (create_tracepoint_from_upload): Adjust to use
6001         gdb::unique_xmalloc_ptr.
6002         * ctf.c (ctf_write_uploaded_tp):
6003         (SET_ARRAY_FIELD): Use emplace_back.
6004         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
6005         * tracefile-tfile.c (tfile_write_uploaded_tp):
6006         * tracepoint.c (parse_tracepoint_definition): Adjust to use
6007         gdb::unique_xmalloc_ptr.
6008         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
6009         at_string, cond_string, cmd_strings>: Replace char pointers
6010         with gdb::unique_xmalloc_ptr.
6011
6012 2019-01-10  Pedro Alves  <palves@redhat.com>
6013
6014         * solib-target.c (library_list_start_library): Don't xstrdup name.
6015
6016 2019-01-10  Pedro Alves  <palves@redhat.com>
6017
6018         * mdebugread.c (parse_partial_symbols): Use
6019         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
6020
6021 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6022
6023         * linux-fork.c (scoped_switch_fork_info)
6024         <~scoped_switch_fork_info>: Fix incorrect variable name.
6025
6026 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6027
6028         * linux-fork.c (scoped_switch_fork_info)
6029         <scoped_switch_fork_info>: Make explicit.
6030         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
6031
6032 2019-01-10  Tom Tromey  <tom@tromey.com>
6033
6034         * objfiles.h (objfile::reset_psymtabs): Update.
6035         * objfiles.c (objfile::objfile): Update.
6036         * psymtab.h (psymtab_storage::obstack): Update.
6037         (psymtab_storage::m_obstack): Use gdb::optional.
6038         (class psymtab_storage): Update comment.  Remove objfile
6039         parameter.
6040         * psymtab.c (psymtab_storage::psymtab_storage): Update.
6041
6042 2019-01-10  Tom Tromey  <tom@tromey.com>
6043
6044         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
6045         <free_psymtabs>: Now private.
6046         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
6047         (allocate_psymtab): Use new method.
6048
6049 2019-01-10  Tom Tromey  <tom@tromey.com>
6050
6051         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
6052         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
6053         * mdebugread.c (parse_partial_symbols): Use
6054         allocate_dependencies.
6055         * dwarf2read.c (dwarf2_create_include_psymtab): Use
6056         allocate_dependencies.
6057         (process_psymtab_comp_unit_reader)
6058         (build_type_psymtab_dependencies): Likewise.
6059         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
6060
6061 2019-01-10  Tom Tromey  <tom@tromey.com>
6062
6063         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
6064         PSYMBOL_SET_LANGUAGE.
6065         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
6066
6067 2019-01-10  Tom Tromey  <tom@tromey.com>
6068
6069         * psymtab.h (psymtab_storage::obstack): New method.
6070         <m_obstack>: Rename from obstack; now private.
6071         * psymtab.c (psymtab_storage): Update.
6072         * dwarf2read.c (create_addrmap_from_index)
6073         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
6074         Update.
6075
6076 2019-01-10  Tom Tromey  <tom@tromey.com>
6077
6078         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
6079         * objfiles.h (objfile::reset_psymtabs): New method.
6080
6081 2019-01-10  Tom Tromey  <tom@tromey.com>
6082
6083         * symmisc.c (print_symbol_bcache_statistics): Update.
6084         (print_objfile_statistics): Update.
6085         * symfile.c (reread_symbols): Update.
6086         * psymtab.h (class psymtab_storage): New.
6087         * psymtab.c (psymtab_storage): New constructor.
6088         (~psymtab_storage): New destructor.
6089         (require_partial_symbols): Update.
6090         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
6091         (find_pc_sect_psymtab, find_pc_sect_psymbol)
6092         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
6093         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
6094         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
6095         (start_psymtab_common, end_psymtab_common)
6096         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
6097         (allocate_psymtab): Update.
6098         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
6099         Update.
6100         (dump_psymtab_addrmap, maintenance_print_psymbols)
6101         (maintenance_check_psymtabs): Update.
6102         (class objfile_psymtabs): Move to objfiles.h.
6103         * psympriv.h (discard_psymtab): Now inline.
6104         (psymtab_discarder::psymtab_discarder): Update.
6105         (psymtab_discarder::~psymtab_discarder): Update.
6106         (ALL_OBJFILE_PSYMTABS): Rewrite.
6107         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6108         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6109         Remove fields.
6110         <partial_symtabs>: New field.
6111         (class objfile_psymtabs): Move from psymtab.h.  Update.
6112         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6113         psymbol_cache.
6114         (objfile::~objfile): Don't destroy psymbol_cache.
6115         * mdebugread.c (parse_partial_symbols): Update.
6116         * dwarf2read.c (create_addrmap_from_index)
6117         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6118         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6119         (add_partial_subprogram, dwarf2_ranges_read): Update.
6120         * dwarf-index-write.c (write_address_map)
6121         (write_one_signatured_type, recursively_write_psymbols)
6122         (class debug_names, class debug_names, write_psymtabs_to_index):
6123         Update.
6124
6125 2019-01-10  Tom Tromey  <tom@tromey.com>
6126
6127         * symtab.h (SYMBOL_SET_NAMES): Update.
6128         (symbol_set_names): Update.
6129         (MSYMBOL_SET_NAMES): Update.
6130         * symtab.c (symbol_set_names): Change argument to be an
6131         objfile_per_bfd_storage.
6132         * psymtab.c (add_psymbol_to_bcache): Update.
6133         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6134
6135 2019-01-10  Tom Tromey  <tom@tromey.com>
6136
6137         * symtab.c (create_demangled_names_hash): Change argument to be an
6138         objfile_per_bfd_storage.
6139         (symbol_set_names): Update.
6140
6141 2019-01-10  Tom Tromey  <tom@tromey.com>
6142
6143         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6144         init_psymbol_list.
6145         * psymtab.c (init_psymbol_list): Do nothing if already called.
6146         * psympriv.h (init_psymbol_list): Add comment.
6147         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6148         init_psymbol_list.
6149         * dbxread.c (dbx_symfile_read): Unconditionally call
6150         init_psymbol_list.
6151
6152 2019-01-10  Tom Tromey  <tom@tromey.com>
6153
6154         * xcoffread.c (scan_xcoff_symtab): Update.
6155         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6156         "where".
6157         * mdebugread.c (parse_partial_symbols)
6158         (handle_psymbol_enumerators): Update.
6159         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6160         * dbxread.c (read_dbx_symtab): Update.
6161         * psympriv.h (psymbol_placement): New enum.
6162         (add_psymbol_to_list): Update.
6163
6164 2019-01-10  Tom Tromey  <tom@tromey.com>
6165
6166         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6167         static_psymbols parameters.
6168         (scan_xcoff_symtab): Update.
6169         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6170         static_psymbols parameters.
6171         * psympriv.h (start_psymtab_common): Update.
6172         * mdebugread.c (parse_partial_symbols): Update.
6173         * dwarf2read.c (create_partial_symtab): Update.
6174         * dbxread.c (read_dbx_symtab): Update.
6175         (start_psymtab): Remove global_psymbols and static_psymbols
6176         parameters.
6177
6178 2019-01-10  Tom Tromey  <tom@tromey.com>
6179
6180         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6181         * psymtab.c (allocate_psymtab): Add comment.
6182         * psympriv.h (allocate_psymtab): Add comment.
6183         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6184         initializations.
6185         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6186
6187 2019-01-10  Tom Tromey  <tom@tromey.com>
6188
6189         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6190         Don't declare.
6191         * mipsread.c: Include mdebugread.h.
6192         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6193         Declare.
6194         * elfread.c: Include mdebugread.h.
6195
6196 2019-01-09  Tom Tromey  <tom@tromey.com>
6197
6198         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6199         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6200         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6201         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6202         (psym_lookup_symbol, psym_find_last_source_symtab)
6203         (psym_forget_cached_source_info, psym_print_stats)
6204         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6205         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6206         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6207         (psym_find_compunit_symtab_by_address)
6208         (maintenance_print_psymbols, maintenance_info_psymtabs)
6209         (maintenance_check_psymtabs): Use ranged for.
6210         * psymtab.h (class objfile_psymtabs): New.
6211         (require_partial_symbols): Return objfile_psymtabs.
6212         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6213
6214 2019-01-09  Tom Tromey  <tom@tromey.com>
6215
6216         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6217         (find_pc_mapped_section, list_overlays_command)
6218         (map_overlay_command, unmap_overlay_command)
6219         (simple_overlay_update): Use all_objfiles.
6220         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6221         * printcmd.c (info_symbol_command): Use all_objfiles.
6222         * objfiles.h (ALL_OBJSECTIONS): Remove.
6223         * maint.c (maintenance_translate_address): Use all_objfiles.
6224         * gcore.c (gcore_create_callback): Use all_objfiles.
6225         (objfile_find_memory_regions): Likewise.
6226
6227 2019-01-09  Tom Tromey  <tom@tromey.com>
6228
6229         * symtab.c (find_line_symtab, info_sources_command)
6230         (make_source_files_completion_list): Use objfile_compunits.
6231         * source.c (select_source_symtab): Use objfile_compunits.
6232         * objfiles.h (struct objfile): Update comment.
6233         (ALL_OBJFILES): Remove.
6234         (ALL_FILETABS): Remove.
6235         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6236         objfile_compunits.
6237
6238 2019-01-09  Tom Tromey  <tom@tromey.com>
6239
6240         * symmisc.c (print_objfile_statistics, dump_objfile)
6241         (maintenance_print_symbols): Use compunit_filetabs.
6242         * source.c (forget_cached_source_info_for_objfile): Use
6243         compunit_filetabs.
6244         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6245         (ALL_FILETABS): Use compunit_filetabs.
6246         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6247         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6248
6249 2019-01-09  Tom Tromey  <tom@tromey.com>
6250
6251         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6252         (compunit_filetabs): New.
6253         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6254         compunit_filetabs.
6255         (info_sources_command, make_source_files_completion_list): Remove
6256         declaration.
6257         * symmisc.c (print_objfile_statistics, dump_objfile)
6258         (maintenance_print_symbols): Remove declaration.
6259         (maintenance_info_symtabs): Use compunit_filetabs.
6260         (maintenance_info_line_tables): Likewise.
6261         * source.c (select_source_symtab): Change local variable name.
6262         (forget_cached_source_info_for_objfile): Remove declaration.
6263         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6264         * objfiles.c (objfile_relocate1): Remove declaration.
6265         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6266         declaration.
6267         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6268         * coffread.c (coff_symtab_read): Remove declaration.
6269         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6270         compunit_filetabs.
6271
6272 2019-01-09  Tom Tromey  <tom@tromey.com>
6273
6274         * symtab.c (lookup_objfile_from_block)
6275         (find_pc_sect_compunit_symtab, search_symbols)
6276         (default_collect_symbol_completion_matches_break_on): Use
6277         objfile_compunits.
6278         * objfiles.h (ALL_COMPUNITS): Remove.
6279         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6280         * cp-support.c (add_symbol_overload_list_qualified): Use
6281         objfile_compunits.
6282         * ada-lang.c (ada_collect_symbol_completion_matches)
6283         (ada_add_global_exceptions): Use objfile_compunits.
6284
6285 2019-01-09  Tom Tromey  <tom@tromey.com>
6286
6287         * source.c (select_source_symtab)
6288         (forget_cached_source_info_for_objfile): Remove declaration.
6289         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6290         declaration.
6291         * maint.c (count_symtabs_and_blocks): Remove declaration.
6292         * cp-support.c (add_symbol_overload_list_qualified): Remove
6293         declaration.
6294         * coffread.c (coff_symtab_read): Remove declaration.
6295         * symtab.c (lookup_symbol_in_objfile_symtabs)
6296         (basic_lookup_transparent_type_1): Use objfile_compunits.
6297         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6298         (info_sources_command, search_symbols)
6299         (default_collect_symbol_completion_matches_break_on)
6300         (make_source_files_completion_list): Remove declaration.
6301         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6302         (ada_collect_symbol_completion_matches)
6303         (ada_add_global_exceptions): Remove declaration.
6304         * linespec.c (iterate_over_all_matching_symtabs): Use
6305         objfile_compunits.
6306         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6307         (class objfile_compunits): New.
6308         (ALL_COMPUNITS): Use objfile_compunits.
6309         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6310         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6311         objfile_compunits.
6312         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6313
6314 2019-01-09  Tom Tromey  <tom@tromey.com>
6315
6316         * symtab.c (search_symbols)
6317         (default_collect_symbol_completion_matches_break_on): Use
6318         objfile_msymbols.
6319         * ada-lang.c (ada_lookup_simple_minsym)
6320         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6321         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6322         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6323         objfile_msymbols.
6324         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6325         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6326         * objc-lang.c (find_methods): Use objfile_msymbols.
6327         (info_selectors_command, info_classes_command): Likewise.
6328         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6329         * objfiles.h (class objfile_msymbols): New.
6330         (ALL_OBJFILE_MSYMBOLS): Remove.
6331         (ALL_MSYMBOLS): Remove.
6332
6333 2019-01-09  Tom Tromey  <tom@tromey.com>
6334
6335         * common/next-iterator.h (next_adapter): Add Iterator template
6336         parameter.
6337         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6338         (class all_objfiles_safe): New.
6339         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6340         * objfiles.c (put_objfile_before): Update comment.
6341         (add_separate_debug_objfile): Likewise.
6342         (free_all_objfiles): Use all_objfiles_safe.
6343         (objfile_purge_solibs): Likewise.
6344
6345 2019-01-09  Tom Tromey  <tom@tromey.com>
6346
6347         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6348         (expand_symtab_containing_pc, lookup_static_symbol)
6349         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6350         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6351         all_objfiles.
6352         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6353         * breakpoint.c (create_overlay_event_breakpoint)
6354         (create_longjmp_master_breakpoint)
6355         (create_std_terminate_master_breakpoint)
6356         (create_exception_master_breakpoint): Use all_objfiles.
6357         * linux-thread-db.c (try_thread_db_load_from_pdir)
6358         (has_libpthread): Use all_objfiles.
6359         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6360         * linespec.c (iterate_over_all_matching_symtabs)
6361         (search_minsyms_for_name): Use all_objfiles.
6362         * maint.c (maintenance_info_sections): Use all_objfiles.
6363         * main.c (captured_main_1): Use all_objfiles.
6364         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6365         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6366         * guile/scm-pretty-print.c
6367         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6368         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6369         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6370         (maintenance_print_msymbols): Use all_objfiles.
6371         * source.c (select_source_symtab): Use all_objfiles.
6372         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6373         * symfile.c (remove_symbol_file_command)
6374         (expand_symtabs_matching, map_symbol_filenames): Use
6375         all_objfiles.
6376         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6377         all_objfiles.
6378         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6379         * objc-lang.c (find_methods): Use all_objfiles.
6380         * objfiles.c (have_partial_symbols, have_full_symbols)
6381         (have_minimal_symbols, qsort_cmp)
6382         (default_iterate_over_objfiles_in_search_order): Use
6383         all_objfiles.
6384         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6385         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6386         (maintenance_check_psymtabs): Use all_objfiles.
6387         (ALL_PSYMTABS): Remove.
6388         * compile/compile-object-run.c (do_module_cleanup): Use
6389         all_objfiles.
6390         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6391         * cp-support.c (add_symbol_overload_list_qualified): Use
6392         all_objfiles.
6393         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6394         Use all_objfiles.
6395         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6396         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6397         all_objfiles.
6398         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6399         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6400         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6401         Uses all_objfiles.
6402         * solib.c (solib_read_symbols): Use all_objfiles
6403
6404 2019-01-09  Tom Tromey  <tom@tromey.com>
6405
6406         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6407         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6408         all_objfiles.
6409         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6410         * symmisc.c (print_symbol_bcache_statistics)
6411         (print_objfile_statistics, maintenance_print_objfiles)
6412         (maintenance_info_symtabs, maintenance_check_symtabs)
6413         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6414         all_objfiles.
6415         * source.c (forget_cached_source_info): Use all_objfiles.
6416         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6417         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6418         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6419         * objfiles.c (update_section_map): Use all_objfiles.
6420         (shared_objfile_contains_address_p): Likewise.
6421         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6422         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6423
6424 2019-01-09  Tom Tromey  <tom@tromey.com>
6425
6426         * common/next-iterator.h: New file.
6427         * objfiles.h (class all_objfiles): New.
6428         (struct objfile_iterator): New.
6429
6430 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6431
6432         * NEWS: Move the description of the changed "frame", "select-frame",
6433          and "info frame" commands to the Changed commands section.
6434
6435 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6436
6437         * gdbtypes.c (check_stub_method_group): Remove handling of old
6438         mangling schemes.
6439         * linespec.c (find_methods): Likewise.
6440         * stabsread.c (read_member_functions): Likewise.
6441         * valops.c (search_struct_method): Likewise.
6442         (value_struct_elt_for_reference): Likewise.
6443         * NEWS: Mention this change.
6444
6445 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6446
6447         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6448         print_source_lines.
6449         * source.c (print_source_lines_base): Update line number check.
6450         (print_source_lines): New function.
6451         (source_lines_range::source_lines_range): New function.
6452         * source.h (class source_lines_range): New class.
6453         (print_source_lines): New declaration.
6454
6455 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6456
6457         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6458
6459 2019-01-08  Tom Tromey  <tom@tromey.com>
6460             Simon Marchi  <simon.marchi@ericsson.com>
6461
6462         PR gdb/24060
6463         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6464         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6465         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6466         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6467         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6468         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6469
6470 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6471
6472         * source.c (select_source_symtab): Move header comment to
6473         declaration in source.h.
6474         (forget_cached_source_info_for_objfile): Likewise.
6475         (forget_cached_source_info): Likewise.
6476         (identify_source_line): Likewise.
6477         * source.h (identify_source_line): Move declaration from symtab.h
6478         and add comment from source.c
6479         (print_source_lines): Likewise.
6480         (forget_cached_source_info_for_objfile): Likewise.
6481         (forget_cached_source_info): Likewise.
6482         (select_source_symtab): Likewise.
6483         (enum print_source_lines_flag): Move definition from symtab.h.
6484         * symtab.h (identify_source_line): Move declaration to source.h.
6485         (print_source_lines): Likewise.
6486         (forget_cached_source_info_for_objfile): Likewise.
6487         (forget_cached_source_info): Likewise.
6488         (select_source_symtab): Likewise.
6489         (enum print_source_lines_flag): Move definition to source.h.
6490         * tui/tui-hooks.c: Add 'source.h' include.
6491
6492 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6493
6494         * source.c (print_source_lines_base): Handle requests to print
6495         reverse line number sequences, and guard against empty lines
6496         string.
6497
6498 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6499
6500         * source.c (print_source_lines_base): Fix skip of '\r' if next
6501         character is '\n'.
6502
6503 2019-01-06  Tom Tromey  <tom@tromey.com>
6504
6505         * c-exp.y (struct c_parse_state) <macro_original_text,
6506         expansion_obstack>: New member.
6507         (macro_original_text, expansion_obstack): Remove globals.
6508         (scan_macro_expansion, scanning_macro_expansion)
6509         (finished_macro_expansion): Update.
6510         (scan_macro_cleanup): Remove.
6511         (yylex, c_parse): Update.
6512
6513 2019-01-06  Tom Tromey  <tom@tromey.com>
6514
6515         * c-exp.y (struct c_parse_state) <strings>: New member.
6516         (operator_stoken): Update.
6517
6518 2019-01-06  Tom Tromey  <tom@tromey.com>
6519
6520         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6521         (union type_stack_elt) <typelist_val>: Now a pointer to
6522         std::vector.
6523         (type_stack_cleanup): Don't declare.
6524         (push_typelist): Update.
6525         * parse.c (pop_typelist): Return a std::vector.
6526         (push_typelist): Take a std::vector.
6527         (follow_types): Update.  Do not free args.
6528         (type_stack_cleanup): Remove.
6529         * c-exp.y (struct c_parse_state): New.
6530         (cpstate): New global.
6531         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6532         (nonempty_typelist): Update.
6533         (func_mod): Create a new vector.
6534         (c_parse): Create a c_parse_state.
6535         (check_parameter_typelist): Do not delete params.
6536         (function_method): Update.  Do not delete type_list.
6537
6538 2019-01-06  Tom Tromey  <tom@tromey.com>
6539
6540         PR gdb/28155:
6541         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6542         check_typedef.
6543         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6544         (print_return_value): Likewise.
6545
6546 2019-01-05  Tom Tromey  <tom@tromey.com>
6547
6548         * contrib/cleanup_check.py: Remove.
6549         * contrib/gcc-with-excheck: Remove.
6550         * contrib/exsummary.py: Remove.
6551         * contrib/excheck.py: Remove.
6552
6553 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6554
6555         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6556         NULL. Initialize tpprev to NULL instead of assigning it
6557         to NULL on the next statement.
6558         * windows-nat.c (windows_delete_thread): Remove check for
6559         main_thread_id before printing thread exit notifications.
6560         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6561         Remove thread ID check against main_thread_id.
6562         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6563         windows_delete_thread.
6564         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6565
6566 2019-01-04  Tom Tromey  <tom@tromey.com>
6567
6568         * compile/compile.c (_initialize_compile): Use upper case for
6569         metasyntactic variables.
6570         * symmisc.c (_initialize_symmisc): Use upper case for
6571         metasyntactic variables.
6572         * psymtab.c (_initialize_psymtab): Use upper case for
6573         metasyntactic variables.
6574         * demangle.c (demangle_command): Use upper case for metasyntactic
6575         variables.
6576         (_initialize_demangler): Likewise.
6577         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6578         variables.
6579
6580 2019-01-03  Tom Tromey  <tom@tromey.com>
6581
6582         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6583
6584 2019-01-03  Tom Tromey  <tom@tromey.com>
6585
6586         * python/py-symtab.c (salpy_str): Update.
6587         (struct salpy_sal_object) <symtab>: Now a PyObject.
6588         (salpy_dealloc): Update.
6589         (del_objfile_sal): Use gdbpy_ref.
6590
6591 2019-01-03  Tom Tromey  <tom@tromey.com>
6592
6593         * python/py-type.c (convert_field): Use new_reference.  Return
6594         gdbpy_ref.
6595         (make_fielditem): Return gdbpy_ref.
6596         (typy_fields): Update.
6597         (typy_getitem): Update.
6598         (field_name): Return gdbpy_ref.  Use new_reference.
6599         (typy_iterator_iternext): Update.
6600
6601 2019-01-03  Tom Tromey  <tom@tromey.com>
6602
6603         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6604
6605 2019-01-03  Tom Tromey  <tom@tromey.com>
6606
6607         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6608         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6609         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6610         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6611         (pspy_set_type_printers): Likewise.
6612         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6613         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6614         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6615         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6616         (objfpy_set_type_printers): Likewise.
6617
6618 2019-01-03  Tom Tromey  <tom@tromey.com>
6619
6620         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6621         (gdbpy_print_stack): Use gdbpy_err_fetch.
6622         * python/python-internal.h (class gdbpy_err_fetch): New class.
6623         (class gdbpy_enter) <m_error_type, m_error_value,
6624         m_error_traceback>: Remove.
6625         <m_error>: New member.
6626         (gdbpy_exception_to_string): Don't declare.
6627         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6628         * python/py-value.c (convert_value_from_python): Use
6629         gdbpy_err_fetch.
6630         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6631         gdbpy_exception_to_string.
6632         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6633         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6634         gdbpy_err_fetch.
6635
6636 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6637
6638         * linux-nat.c (delete_lwp_cleanup): Delete.
6639         (struct lwp_deleter): New struct.
6640         (lwp_info_up): New typedef.
6641         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6642         lwp_info_up.
6643
6644 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6645
6646         * linux-fork.c (class scoped_switch_fork_info): New class.
6647         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6648
6649 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6650
6651         * valops.c (find_overload_match): Remove use of null_cleanup, and
6652         calls to do_cleanups.
6653
6654 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6655
6656         * compile/compile-cplus-types.c
6657         (compile_cplus_instance::decl_name): Handle changes to
6658         cp_func_name.
6659         * cp-support.c (cp_func_name): Update header comment, update
6660         return type.
6661         * cp-support.h (cp_func_name): Update return type in declaration.
6662         * valops.c (find_overload_match): Move temp_func local to top
6663         level of function and change its type.  Use temp_func to hold and
6664         delete temporary string obtained from cp_func_name.
6665
6666 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6667
6668         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6669         gdb::char_vector, remove cleanup, and update uses of `msg`.
6670
6671 2019-01-03  Jim Wilson  <jimw@sifive.com>
6672
6673         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6674
6675 2019-01-02  Tom Tromey  <tom@tromey.com>
6676
6677         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6678         (tdesc_parse_xml): Remove cleanups.
6679         * target-descriptions.h (make_cleanup_free_target_description):
6680         Don't declare.
6681         (target_desc_deleter): New struct.
6682         (target_desc_up): New typedef.
6683         * target-descriptions.c (target_desc_deleter::operator()): Rename
6684         from free_target_description.
6685         (make_cleanup_free_target_description): Remove.
6686
6687 2019-01-02  Tom Tromey  <tom@tromey.com>
6688
6689         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6690         constructor, destructor.
6691         (linespec_parser): Remove typedef.
6692         (~linespec_parser): Rename from linespec_parser_delete.
6693         (linespec_lex_to_end, linespec_complete_label)
6694         (linespec_complete): Update.
6695         (decode_line_full): Remove cleanups.
6696         (decode_line_1): Update.
6697
6698 2019-01-02  Tom Tromey  <tom@tromey.com>
6699
6700         * python/python-internal.h (inferior_to_inferior_object): Change
6701         return type.
6702         * python/py-exitedevent.c (create_exited_event_object): Update.
6703         * python/py-inferior.c (inferior_to_inferior_object): Return
6704         gdbpy_ref.
6705         (python_new_inferior, python_inferior_deleted)
6706         (thread_to_thread_object, delete_thread_object)
6707         (build_inferior_list, gdbpy_selected_inferior): Update.
6708         * python/py-infthread.c (create_thread_object): Update.  Also fail
6709         if inferior_to_inferior_object fails.
6710
6711 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6712
6713         * inferior.h (class inferior) <displaced_step_state>: New field.
6714         * infrun.h (struct displaced_step_state): Move here from
6715         infrun.c.  Initialize fields, add constructor.
6716         <inf>: Remove field.
6717         <reset>: New method.
6718         * infrun.c (struct displaced_step_inferior_state): Move to
6719         infrun.h.
6720         (displaced_step_inferior_states): Remove.
6721         (get_displaced_stepping_state): Adust.
6722         (displaced_step_in_progress_any_inferior): Adjust.
6723         (displaced_step_in_progress_thread): Adjust.
6724         (displaced_step_in_progress): Adjust.
6725         (add_displaced_stepping_state): Remove.
6726         (get_displaced_step_closure_by_addr): Adjust.
6727         (remove_displaced_stepping_state): Remove.
6728         (infrun_inferior_exit): Call displaced_step_state.reset.
6729         (use_displaced_stepping): Don't check for NULL.
6730         (displaced_step_prepare_throw): Call
6731         get_displaced_stepping_state.
6732         (displaced_step_fixup): Don't check for NULL.
6733         (prepare_for_detach): Don't check for NULL.
6734
6735 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6736
6737         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6738          in case of call that did not complete.
6739
6740 2019-01-02  Andrey Utkin  <autkin@undo.io>
6741
6742         * symfile.c (find_separate_debug_file): Fix search of debug files for
6743         remote debuggee.
6744
6745 2019-01-02  Tom Tromey  <tom@tromey.com>
6746
6747         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6748         indentation.
6749         * python/py-frame.c (frapy_older): Remove cast.
6750         (frapy_newer): Likewise.
6751         * python/py-breakpoint.c (local_setattro): Remove cast.
6752         * python/py-arch.c (archpy_name): Remove local variable.
6753         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6754
6755 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6756
6757         * unittests/basic_string_view/element_access/char/empty.cc:
6758         Fix year range in copyright header.
6759
6760 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6761
6762         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6763         Delete.
6764         <operator==>: Update with for removed field.
6765         <hash>: Likewise.
6766         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6767         <isa_features>: ...this.
6768         <abi_features>: New field.
6769         (riscv_isa_flen): Update comment.
6770         (riscv_abi_xlen): New declaration.
6771         (riscv_abi_flen): New declaration.
6772         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6773         isa_features.
6774         (riscv_abi_xlen): New function.
6775         (riscv_isa_flen): Update to get answer from isa_features.
6776         (riscv_abi_flen): New function.
6777         (riscv_has_fp_abi): Update to get answer from abi_features.
6778         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6779         xlen and flen.
6780         (riscv_call_info) <xlen, flen>: Update comment.
6781         (riscv_call_arg_struct): Remove invalid assertions
6782         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6783         is removed.
6784         (riscv_gdbarch_init): Gather isa features and abi features
6785         separately, ensure both match on the gdbarch when reusing an old
6786         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6787         a target with 64-bit float hardware.
6788
6789 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6790
6791         * source.c (search_command_helper): Stop reverse search
6792         when line 1 has been searched.
6793
6794 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6795
6796         * record-full.c (record_full_base_target::close): Rewrite
6797         record_full_core_buf_list free logic.
6798
6799 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6800
6801         * break-catch-syscall.c (print_one_catch_syscall): xfree
6802         the last text.
6803
6804 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6805
6806         * top.c (print_gdb_version): Update Copyright year in version
6807         message.
6808
6809 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6810
6811         Update copyright year range in all GDB files.
6812
6813 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6814
6815         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6816
6817 For older changes see ChangeLog-2018.
6818 \f
6819 Local Variables:
6820 mode: change-log
6821 left-margin: 8
6822 fill-column: 74
6823 version-control: never
6824 coding: utf-8
6825 End:
6826