gdb/ChangeLog

   1 2019-01-16  Tom Tromey  <tom@tromey.com>
   2
   3         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
   4         type.  Remove no-argument constructor.
   5         <iterator::operator++>: Simplify.
   6         <begin>: Update.
   7         <end>: Use minimal_symbol_count.
   8
   9 2019-01-16  Tom Tromey  <tom@tromey.com>
  10
  11         * objfiles.h (struct objfile) <psymtabs>: New method.
  12         (class objfile_psymtabs): Remove.
  13         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
  14         typedef.
  15         <range>: New method.
  16         (require_partial_symbols): Change return type.
  17         * psymtab.c (require_partial_symbols)
  18         (psym_expand_symtabs_matching): Update.
  19         * mdebugread.c (parse_partial_symbols): Update.
  20         * dbxread.c (dbx_end_psymtab): Update.
  21
  22 2019-01-15  Tom Tromey  <tom@tromey.com>
  23
  24         * symtab.c (lookup_objfile_from_block)
  25         (lookup_symbol_in_objfile_symtabs)
  26         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
  27         (find_line_symtab, info_sources_command)
  28         (default_collect_symbol_completion_matches_break_on)
  29         (make_source_files_completion_list): Update.
  30         * symmisc.c (print_objfile_statistics, dump_objfile)
  31         (maintenance_print_symbols, maintenance_info_symtabs)
  32         (maintenance_check_symtabs, maintenance_info_line_tables):
  33         Update.
  34         * source.c (select_source_symtab)
  35         (forget_cached_source_info_for_objfile): Update.
  36         * objfiles.h (class objfile_compunits): Remove.
  37         (struct objfile) <compunits_range>: New typedef.
  38         (compunits): New method.
  39         * objfiles.c (objfile_relocate1): Update.
  40         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
  41         * maint.c (count_symtabs_and_blocks): Update.
  42         * linespec.c (iterate_over_all_matching_symtabs): Update.
  43         * cp-support.c (add_symbol_overload_list_qualified): Update.
  44         * coffread.c (coff_symtab_read): Update.
  45         * ada-lang.c (add_nonlocal_symbols)
  46         (ada_collect_symbol_completion_matches)
  47         (ada_add_global_exceptions): Update.
  48
  49 2019-01-15  Tom Tromey  <tom@tromey.com>
  50
  51         * progspace.h (program_space) <objfiles_safe_range>: New
  52         typedef.
  53         <objfiles_safe>: New method.
  54         * objfiles.h (class all_objfiles_safe): Remove.
  55         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
  56         * jit.c (jit_inferior_exit_hook): Update.
  57
  58 2019-01-17  Tom Tromey  <tom@tromey.com>
  59
  60         * progspace.h (program_space) <objfiles_range>: New typedef.
  61         <objfiles>: New method.
  62         <objfiles_head>: Rename from objfiles.
  63         (object_files): Update.
  64         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
  65         * guile/scm-pretty-print.c
  66         (ppscm_find_pretty_printer_from_objfiles): Update.
  67         * guile/scm-objfile.c (gdbscm_objfiles): Update.
  68         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
  69         Update.
  70         * python/py-progspace.c (pspy_get_objfiles): Update.
  71         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
  72         Update.
  73         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
  74         (objfpy_lookup_objfile_by_build_id): Update.
  75         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
  76         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
  77         Update.
  78         * symtab.c (iterate_over_symtabs, matching_obj_sections)
  79         (expand_symtab_containing_pc, lookup_objfile_from_block)
  80         (lookup_static_symbol, basic_lookup_transparent_type)
  81         (find_pc_sect_compunit_symtab, find_symbol_at_address)
  82         (find_line_symtab, info_sources_command)
  83         (default_collect_symbol_completion_matches_break_on)
  84         (make_source_files_completion_list, find_main_name): Update.
  85         * symmisc.c (print_symbol_bcache_statistics)
  86         (print_objfile_statistics, maintenance_print_symbols)
  87         (maintenance_print_msymbols, maintenance_print_objfiles)
  88         (maintenance_info_symtabs, maintenance_check_symtabs)
  89         (maintenance_expand_symtabs, maintenance_info_line_tables):
  90         Update.
  91         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
  92         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
  93         (map_overlay_command, unmap_overlay_command)
  94         (simple_overlay_update, expand_symtabs_matching)
  95         (map_symbol_filenames): Update.
  96         * symfile-debug.c (set_debug_symfile): Update.
  97         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
  98         Update.
  99         * source.c (select_source_symtab, forget_cached_source_info):
 100         Update.
 101         * solib.c (solib_read_symbols): Update.
 102         * solib-spu.c (append_ocl_sos): Update.
 103         * psymtab.c (maintenance_print_psymbols)
 104         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
 105         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
 106         * printcmd.c (info_symbol_command): Update.
 107         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
 108         Update.
 109         * objfiles.h (class all_objfiles): Remove.
 110         * objfiles.c (have_partial_symbols, have_full_symbols)
 111         (have_minimal_symbols, qsort_cmp, update_section_map)
 112         (shared_objfile_contains_address_p)
 113         (default_iterate_over_objfiles_in_search_order): Update.
 114         * objc-lang.c (info_selectors_command, info_classes_command)
 115         (find_methods): Update.
 116         * minsyms.c (find_solib_trampoline_target): Update.
 117         * maint.c (maintenance_info_sections)
 118         (maintenance_translate_address, count_symtabs_and_blocks):
 119         Update.
 120         * main.c (captured_main_1): Update.
 121         * linux-thread-db.c (try_thread_db_load_from_pdir)
 122         (has_libpthread): Update.
 123         * linespec.c (iterate_over_all_matching_symtabs)
 124         (search_minsyms_for_name): Update.
 125         * jit.c (jit_find_objf_with_entry_addr): Update.
 126         * hppa-tdep.c (find_unwind_entry)
 127         (hppa_lookup_stub_minimal_symbol): Update.
 128         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
 129         Update.
 130         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 131         (elf_gnu_ifunc_resolve_by_got): Update.
 132         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
 133         * dwarf-index-write.c (save_gdb_index_command): Update.
 134         * cp-support.c (add_symbol_overload_list_qualified): Update.
 135         * breakpoint.c (create_overlay_event_breakpoint)
 136         (create_longjmp_master_breakpoint)
 137         (create_std_terminate_master_breakpoint)
 138         (create_exception_master_breakpoint): Update.
 139         * blockframe.c (find_pc_partial_function): Update.
 140         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
 141         (ada_collect_symbol_completion_matches)
 142         (ada_add_global_exceptions): Update.
 143
 144 2019-01-17  Tom Tromey  <tom@tromey.com>
 145
 146         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
 147         declare VEC.
 148         (solib_target_parse_libraries): Change return type.
 149         (library_list_start_segment, library_list_start_section)
 150         (library_list_end_library, library_list_start_library); Update.
 151         (solib_target_free_library_list): Remove.
 152         (solib_target_parse_libraries): Remove cleanup.  Change return
 153         type.
 154         (solib_target_current_sos): Update.
 155
 156 2019-01-17  Tom Tromey  <tromey@bapiya>
 157
 158         * valprint.c: Replace "the the" with "the".
 159         * symtab.c: Replace "the the" with "the".
 160         * solib.c: Replace "the the" with "the".
 161         * solib-dsbt.c: Replace "the the" with "the".
 162         * linespec.c: Replace "the the" with "the".
 163         * dwarf2loc.h: Replace "the the" with "the".
 164         * amd64-windows-tdep.c: Replace "the the" with "the".
 165         * aarch64-tdep.c: Replace "the the" with "the".
 166
 167 2019-01-16  Keith Seitz  <keiths@redhat.com>
 168
 169         PR gdb/23773
 170         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
 171         <builder>: Rename to ..
 172         <m_builder>: ... this and make private.
 173         (dwarf2_cu::get_builder): New method.  Change all users of
 174         `builder' to use this method.
 175         (dwarf2_start_symtab): Move to ...
 176         (dwarf2_cu::start_symtab): ... here.  Update all callers
 177         (setup_type_unit_groups): Move to ...
 178         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
 179         callers.
 180         (dwarf2_cu::reset_builder): New method.
 181         (process_full_compunit, process_full_type_unit): Use
 182         dwarf2_cu::reset_builder.
 183         (follow_die_offset): Record the ancestor CU if it is different
 184         from the followed DIE's CU.
 185         (follow_die_sig_1): Likewise.
 186
 187 2019-01-15  Tom Tromey  <tom@tromey.com>
 188
 189         * remote.c (class remote_state) <buf>: Now a char_vector.
 190         <buf_size>: Remove.
 191         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
 192         parameter.
 193         (remote_target::getpkt_or_notif_sane_1)
 194         (remote_target::getpkt_sane)
 195         (remote_target::getpkt_or_notif_sane): Likewise.
 196         (class remote_target) <putpkt>: New overload.
 197         (remote_target::read_frame): Change type of "buf_p".  Remove
 198         sizeof_p parameter.
 199         (packet_ok): New overload.
 200         (packet_check_result): New overload.
 201         Update all uses.
 202
 203 2019-01-14  Tom Tromey  <tom@tromey.com>
 204
 205         * remote-notif.c (handle_notification, remote_notif_ack)
 206         (remote_notif_parse): Make "buf" const.
 207         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
 208         const.
 209         (remote_notif_parse, remote_notif_ack, handle_notification):
 210         Likewise.
 211         * remote.c (remote_notif_stop_parse): Make "buf" const.
 212         (remote_target::remote_parse_stop_reply): Make "buf" const.
 213         (remote_notif_stop_ack): Make "buf" const.
 214
 215 2019-01-14  Tom Tromey  <tom@tromey.com>
 216
 217         * remote.c (remote_console_output): Make parameter const.
 218
 219 2019-01-14  Tom Tromey  <tom@tromey.com>
 220
 221         * target-debug.h (target_debug_print_signals): Constify.
 222         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
 223         * procfs.c (procfs_target::pass_signals): Update.
 224         * linux-nat.c (linux_nat_target::pass_signals): Update.
 225         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
 226         * target-delegates.c: Rebuild.
 227         * remote.c (remote_target::program_signals): Update.
 228         (remote_target::pass_signals): Update.
 229         * target.c (target_pass_signals): Constify argument.
 230         (target_program_signals): Likewise.
 231         * target.h (struct target_ops) <pass_signals, program_signals>:
 232         Constify argument.
 233         (target_pass_signals, target_program_signals): Constify argument.
 234
 235 2019-01-14  Tom Tromey  <tom@tromey.com>
 236
 237         PR tui/28819:
 238         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
 239
 240 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 241
 242         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
 243         field.
 244         * rs6000-tdep.c: Include reggroups.h.
 245         (IS_V_ALIAS_PSEUDOREG): Define.
 246         (rs6000_register_name): Return names for the "vX" aliases.
 247         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
 248         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
 249         aliases.  Call default_register_reggroup_p for all other
 250         pseudo-registers.
 251         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
 252         New functions.
 253         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
 254         Handle "vX" aliases.
 255         (v_alias_pseudo_register_collect): New function.
 256         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
 257         (rs6000_gdbarch_init): Initialize "vX" aliases as
 258         pseudo-registers.  Restore registration of
 259         rs6000_pseudo_register_reggroup_p with
 260         set_tdesc_pseudo_register_reggroup_p.
 261
 262 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
 263
 264         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
 265         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
 266         set_gdbarch_num_pseudo_regs.
 267
 268 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 269
 270         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
 271         Remove arg prefixname, add do_set and do_show.
 272         Add member functions set_list and show_list.
 273         * cli/cli-style.c (class cli_style_option): Update accordingly.
 274         (style_set_list): Move to file scope.
 275         (style_show_list): Likewise.
 276         (set_style): Call help_list.
 277         (show_style): Call cmd_show_list.
 278         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
 279         Update to use the new macro.
 280
 281 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
 282
 283         * ada-lang.c (_initialize_ada_language): Expand the help text
 284         for the "catch exception" command.
 285
 286 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 287
 288         * symtab.c (matching_obj_sections): Initialize obj,
 289         declare it closer to its usage.
 290
 291 2019-01-10  Tom Tromey  <tom@tromey.com>
 292
 293         * thread-iter.h (inf_threads_iterator): Use next_iterator.
 294         (basic_inf_threads_range): Remove.
 295         (inf_threads_range, inf_non_exited_threads_range)
 296         (safe_inf_threads_range): Use next_adapter.
 297
 298 2019-01-10  Keith Seitz  <keiths@redhat.com>
 299
 300         PR gdb/23712
 301         PR symtab/23010
 302         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
 303         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
 304
 305 2019-01-10  Keith Seitz  <keiths@redhat.com>
 306
 307         PR gdb/23712
 308         PR symtab/23010
 309         * dictionary.c (pending_to_vector): Remove.
 310         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 311         Remove _1 suffix, replacing functions of the same name.  Update
 312         all callers.
 313         (dict_create_hashed, dict_create_hashed_expandable)
 314         (dict_create_linear, dict_create_linear_expandable, dict_free)
 315         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
 316         Make functions static.
 317
 318 2019-01-10  Keith Seitz  <keiths@redhat.com>
 319
 320         PR gdb/23712
 321         PR symtab/23010
 322         * dictionary.h (struct dictionary): Replace declaration with
 323         multidictionary.
 324         (dict_create_hashed, dict_create_hashed_expandable)
 325         (dict_create_linear, dict_create_linear_expandable)
 326         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
 327         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
 328         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
 329         taking multidictionary argument.
 330         [ALL_DICT_SYMBOLS]: Update for multidictionary.
 331         * block.h (struct block) <dict>: Change to multidictionary
 332         and rename `multidict'.
 333         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
 334         symmisc.c: Update all dictionary references to multidictionary.
 335
 336 2019-01-10  Keith Seitz  <keiths@redhat.com>
 337
 338         PR gdb/23712
 339         PR symtab/23010
 340         * dictionary.c: Include unordered_map.
 341         (pending_to_vector): New function.
 342         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 343         Rewrite the non-"_1" functions to take vector instead
 344         of linked list.
 345         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
 346         "new" _1 versions of the same name.
 347         (multidictionary): Define.
 348         (std::hash<enum language): New definition.
 349         (collate_pending_symbols_by_language, mdict_create_hashed)
 350         (mdict_create_hashed_expandable, mdict_create_linear)
 351         (mdict_create_linear_expandable, mdict_free)
 352         (find_language_dictionary, create_new_language_dictionary)
 353         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
 354         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
 355         (mdict_size, mdict_empty): New functions.
 356         * dictionary.h (mdict_iterator): Define.
 357
 358 2019-01-10  Pedro Alves  <palves@redhat.com>
 359
 360         * breakpoint.c (read_uploaded_action)
 361         (create_tracepoint_from_upload): Adjust to use
 362         gdb::unique_xmalloc_ptr.
 363         * ctf.c (ctf_write_uploaded_tp):
 364         (SET_ARRAY_FIELD): Use emplace_back.
 365         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
 366         * tracefile-tfile.c (tfile_write_uploaded_tp):
 367         * tracepoint.c (parse_tracepoint_definition): Adjust to use
 368         gdb::unique_xmalloc_ptr.
 369         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
 370         at_string, cond_string, cmd_strings>: Replace char pointers
 371         with gdb::unique_xmalloc_ptr.
 372
 373 2019-01-10  Pedro Alves  <palves@redhat.com>
 374
 375         * solib-target.c (library_list_start_library): Don't xstrdup name.
 376
 377 2019-01-10  Pedro Alves  <palves@redhat.com>
 378
 379         * mdebugread.c (parse_partial_symbols): Use
 380         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
 381
 382 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 383
 384         * linux-fork.c (scoped_switch_fork_info)
 385         <~scoped_switch_fork_info>: Fix incorrect variable name.
 386
 387 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 388
 389         * linux-fork.c (scoped_switch_fork_info)
 390         <scoped_switch_fork_info>: Make explicit.
 391         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
 392
 393 2019-01-10  Tom Tromey  <tom@tromey.com>
 394
 395         * objfiles.h (objfile::reset_psymtabs): Update.
 396         * objfiles.c (objfile::objfile): Update.
 397         * psymtab.h (psymtab_storage::obstack): Update.
 398         (psymtab_storage::m_obstack): Use gdb::optional.
 399         (class psymtab_storage): Update comment.  Remove objfile
 400         parameter.
 401         * psymtab.c (psymtab_storage::psymtab_storage): Update.
 402
 403 2019-01-10  Tom Tromey  <tom@tromey.com>
 404
 405         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
 406         <free_psymtabs>: Now private.
 407         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
 408         (allocate_psymtab): Use new method.
 409
 410 2019-01-10  Tom Tromey  <tom@tromey.com>
 411
 412         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
 413         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
 414         * mdebugread.c (parse_partial_symbols): Use
 415         allocate_dependencies.
 416         * dwarf2read.c (dwarf2_create_include_psymtab): Use
 417         allocate_dependencies.
 418         (process_psymtab_comp_unit_reader)
 419         (build_type_psymtab_dependencies): Likewise.
 420         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
 421
 422 2019-01-10  Tom Tromey  <tom@tromey.com>
 423
 424         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
 425         PSYMBOL_SET_LANGUAGE.
 426         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
 427
 428 2019-01-10  Tom Tromey  <tom@tromey.com>
 429
 430         * psymtab.h (psymtab_storage::obstack): New method.
 431         <m_obstack>: Rename from obstack; now private.
 432         * psymtab.c (psymtab_storage): Update.
 433         * dwarf2read.c (create_addrmap_from_index)
 434         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
 435         Update.
 436
 437 2019-01-10  Tom Tromey  <tom@tromey.com>
 438
 439         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
 440         * objfiles.h (objfile::reset_psymtabs): New method.
 441
 442 2019-01-10  Tom Tromey  <tom@tromey.com>
 443
 444         * symmisc.c (print_symbol_bcache_statistics): Update.
 445         (print_objfile_statistics): Update.
 446         * symfile.c (reread_symbols): Update.
 447         * psymtab.h (class psymtab_storage): New.
 448         * psymtab.c (psymtab_storage): New constructor.
 449         (~psymtab_storage): New destructor.
 450         (require_partial_symbols): Update.
 451         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
 452         (find_pc_sect_psymtab, find_pc_sect_psymbol)
 453         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
 454         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
 455         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
 456         (start_psymtab_common, end_psymtab_common)
 457         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
 458         (allocate_psymtab): Update.
 459         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
 460         Update.
 461         (dump_psymtab_addrmap, maintenance_print_psymbols)
 462         (maintenance_check_psymtabs): Update.
 463         (class objfile_psymtabs): Move to objfiles.h.
 464         * psympriv.h (discard_psymtab): Now inline.
 465         (psymtab_discarder::psymtab_discarder): Update.
 466         (psymtab_discarder::~psymtab_discarder): Update.
 467         (ALL_OBJFILE_PSYMTABS): Rewrite.
 468         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
 469         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
 470         Remove fields.
 471         <partial_symtabs>: New field.
 472         (class objfile_psymtabs): Move from psymtab.h.  Update.
 473         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
 474         psymbol_cache.
 475         (objfile::~objfile): Don't destroy psymbol_cache.
 476         * mdebugread.c (parse_partial_symbols): Update.
 477         * dwarf2read.c (create_addrmap_from_index)
 478         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
 479         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
 480         (add_partial_subprogram, dwarf2_ranges_read): Update.
 481         * dwarf-index-write.c (write_address_map)
 482         (write_one_signatured_type, recursively_write_psymbols)
 483         (class debug_names, class debug_names, write_psymtabs_to_index):
 484         Update.
 485
 486 2019-01-10  Tom Tromey  <tom@tromey.com>
 487
 488         * symtab.h (SYMBOL_SET_NAMES): Update.
 489         (symbol_set_names): Update.
 490         (MSYMBOL_SET_NAMES): Update.
 491         * symtab.c (symbol_set_names): Change argument to be an
 492         objfile_per_bfd_storage.
 493         * psymtab.c (add_psymbol_to_bcache): Update.
 494         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
 495
 496 2019-01-10  Tom Tromey  <tom@tromey.com>
 497
 498         * symtab.c (create_demangled_names_hash): Change argument to be an
 499         objfile_per_bfd_storage.
 500         (symbol_set_names): Update.
 501
 502 2019-01-10  Tom Tromey  <tom@tromey.com>
 503
 504         * xcoffread.c (xcoff_initial_scan): Unconditionally call
 505         init_psymbol_list.
 506         * psymtab.c (init_psymbol_list): Do nothing if already called.
 507         * psympriv.h (init_psymbol_list): Add comment.
 508         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
 509         init_psymbol_list.
 510         * dbxread.c (dbx_symfile_read): Unconditionally call
 511         init_psymbol_list.
 512
 513 2019-01-10  Tom Tromey  <tom@tromey.com>
 514
 515         * xcoffread.c (scan_xcoff_symtab): Update.
 516         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
 517         "where".
 518         * mdebugread.c (parse_partial_symbols)
 519         (handle_psymbol_enumerators): Update.
 520         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
 521         * dbxread.c (read_dbx_symtab): Update.
 522         * psympriv.h (psymbol_placement): New enum.
 523         (add_psymbol_to_list): Update.
 524
 525 2019-01-10  Tom Tromey  <tom@tromey.com>
 526
 527         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
 528         static_psymbols parameters.
 529         (scan_xcoff_symtab): Update.
 530         * psymtab.c (start_psymtab_common): Remove global_psymbols and
 531         static_psymbols parameters.
 532         * psympriv.h (start_psymtab_common): Update.
 533         * mdebugread.c (parse_partial_symbols): Update.
 534         * dwarf2read.c (create_partial_symtab): Update.
 535         * dbxread.c (read_dbx_symtab): Update.
 536         (start_psymtab): Remove global_psymbols and static_psymbols
 537         parameters.
 538
 539 2019-01-10  Tom Tromey  <tom@tromey.com>
 540
 541         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
 542         * psymtab.c (allocate_psymtab): Add comment.
 543         * psympriv.h (allocate_psymtab): Add comment.
 544         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
 545         initializations.
 546         * dbxread.c (dbx_end_psymtab): Remove some initializations.
 547
 548 2019-01-10  Tom Tromey  <tom@tromey.com>
 549
 550         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 551         Don't declare.
 552         * mipsread.c: Include mdebugread.h.
 553         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 554         Declare.
 555         * elfread.c: Include mdebugread.h.
 556
 557 2019-01-09  Tom Tromey  <tom@tromey.com>
 558
 559         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
 560         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
 561         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
 562         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
 563         (psym_lookup_symbol, psym_find_last_source_symtab)
 564         (psym_forget_cached_source_info, psym_print_stats)
 565         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
 566         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
 567         (psym_map_matching_symbols, psym_expand_symtabs_matching)
 568         (psym_find_compunit_symtab_by_address)
 569         (maintenance_print_psymbols, maintenance_info_psymtabs)
 570         (maintenance_check_psymtabs): Use ranged for.
 571         * psymtab.h (class objfile_psymtabs): New.
 572         (require_partial_symbols): Return objfile_psymtabs.
 573         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
 574
 575 2019-01-09  Tom Tromey  <tom@tromey.com>
 576
 577         * symfile.c (overlay_invalidate_all, find_pc_overlay)
 578         (find_pc_mapped_section, list_overlays_command)
 579         (map_overlay_command, unmap_overlay_command)
 580         (simple_overlay_update): Use all_objfiles.
 581         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
 582         * printcmd.c (info_symbol_command): Use all_objfiles.
 583         * objfiles.h (ALL_OBJSECTIONS): Remove.
 584         * maint.c (maintenance_translate_address): Use all_objfiles.
 585         * gcore.c (gcore_create_callback): Use all_objfiles.
 586         (objfile_find_memory_regions): Likewise.
 587
 588 2019-01-09  Tom Tromey  <tom@tromey.com>
 589
 590         * symtab.c (find_line_symtab, info_sources_command)
 591         (make_source_files_completion_list): Use objfile_compunits.
 592         * source.c (select_source_symtab): Use objfile_compunits.
 593         * objfiles.h (struct objfile): Update comment.
 594         (ALL_OBJFILES): Remove.
 595         (ALL_FILETABS): Remove.
 596         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
 597         objfile_compunits.
 598
 599 2019-01-09  Tom Tromey  <tom@tromey.com>
 600
 601         * symmisc.c (print_objfile_statistics, dump_objfile)
 602         (maintenance_print_symbols): Use compunit_filetabs.
 603         * source.c (forget_cached_source_info_for_objfile): Use
 604         compunit_filetabs.
 605         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
 606         (ALL_FILETABS): Use compunit_filetabs.
 607         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
 608         * coffread.c (coff_symtab_read): Use compunit_filetabs.
 609
 610 2019-01-09  Tom Tromey  <tom@tromey.com>
 611
 612         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
 613         (compunit_filetabs): New.
 614         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
 615         compunit_filetabs.
 616         (info_sources_command, make_source_files_completion_list): Remove
 617         declaration.
 618         * symmisc.c (print_objfile_statistics, dump_objfile)
 619         (maintenance_print_symbols): Remove declaration.
 620         (maintenance_info_symtabs): Use compunit_filetabs.
 621         (maintenance_info_line_tables): Likewise.
 622         * source.c (select_source_symtab): Change local variable name.
 623         (forget_cached_source_info_for_objfile): Remove declaration.
 624         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
 625         * objfiles.c (objfile_relocate1): Remove declaration.
 626         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 627         declaration.
 628         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
 629         * coffread.c (coff_symtab_read): Remove declaration.
 630         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 631         compunit_filetabs.
 632
 633 2019-01-09  Tom Tromey  <tom@tromey.com>
 634
 635         * symtab.c (lookup_objfile_from_block)
 636         (find_pc_sect_compunit_symtab, search_symbols)
 637         (default_collect_symbol_completion_matches_break_on): Use
 638         objfile_compunits.
 639         * objfiles.h (ALL_COMPUNITS): Remove.
 640         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
 641         * cp-support.c (add_symbol_overload_list_qualified): Use
 642         objfile_compunits.
 643         * ada-lang.c (ada_collect_symbol_completion_matches)
 644         (ada_add_global_exceptions): Use objfile_compunits.
 645
 646 2019-01-09  Tom Tromey  <tom@tromey.com>
 647
 648         * source.c (select_source_symtab)
 649         (forget_cached_source_info_for_objfile): Remove declaration.
 650         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 651         declaration.
 652         * maint.c (count_symtabs_and_blocks): Remove declaration.
 653         * cp-support.c (add_symbol_overload_list_qualified): Remove
 654         declaration.
 655         * coffread.c (coff_symtab_read): Remove declaration.
 656         * symtab.c (lookup_symbol_in_objfile_symtabs)
 657         (basic_lookup_transparent_type_1): Use objfile_compunits.
 658         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
 659         (info_sources_command, search_symbols)
 660         (default_collect_symbol_completion_matches_break_on)
 661         (make_source_files_completion_list): Remove declaration.
 662         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
 663         (ada_collect_symbol_completion_matches)
 664         (ada_add_global_exceptions): Remove declaration.
 665         * linespec.c (iterate_over_all_matching_symtabs): Use
 666         objfile_compunits.
 667         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
 668         (class objfile_compunits): New.
 669         (ALL_COMPUNITS): Use objfile_compunits.
 670         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
 671         (maintenance_check_symtabs, maintenance_info_line_tables): Use
 672         objfile_compunits.
 673         * objfiles.c (objfile_relocate1): Use objfile_compunits.
 674
 675 2019-01-09  Tom Tromey  <tom@tromey.com>
 676
 677         * symtab.c (search_symbols)
 678         (default_collect_symbol_completion_matches_break_on): Use
 679         objfile_msymbols.
 680         * ada-lang.c (ada_lookup_simple_minsym)
 681         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
 682         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
 683         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
 684         objfile_msymbols.
 685         * coffread.c (coff_symfile_read): Use objfile_msymbols.
 686         * symmisc.c (dump_msymbols): Use objfile_msymbols.
 687         * objc-lang.c (find_methods): Use objfile_msymbols.
 688         (info_selectors_command, info_classes_command): Likewise.
 689         * stabsread.c (scan_file_globals): Use objfile_msymbols.
 690         * objfiles.h (class objfile_msymbols): New.
 691         (ALL_OBJFILE_MSYMBOLS): Remove.
 692         (ALL_MSYMBOLS): Remove.
 693
 694 2019-01-09  Tom Tromey  <tom@tromey.com>
 695
 696         * common/next-iterator.h (next_adapter): Add Iterator template
 697         parameter.
 698         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
 699         (class all_objfiles_safe): New.
 700         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
 701         * objfiles.c (put_objfile_before): Update comment.
 702         (add_separate_debug_objfile): Likewise.
 703         (free_all_objfiles): Use all_objfiles_safe.
 704         (objfile_purge_solibs): Likewise.
 705
 706 2019-01-09  Tom Tromey  <tom@tromey.com>
 707
 708         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 709         (expand_symtab_containing_pc, lookup_static_symbol)
 710         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
 711         (find_symbol_at_address, find_line_symtab, find_main_name): Use
 712         all_objfiles.
 713         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
 714         * breakpoint.c (create_overlay_event_breakpoint)
 715         (create_longjmp_master_breakpoint)
 716         (create_std_terminate_master_breakpoint)
 717         (create_exception_master_breakpoint): Use all_objfiles.
 718         * linux-thread-db.c (try_thread_db_load_from_pdir)
 719         (has_libpthread): Use all_objfiles.
 720         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
 721         * linespec.c (iterate_over_all_matching_symtabs)
 722         (search_minsyms_for_name): Use all_objfiles.
 723         * maint.c (maintenance_info_sections): Use all_objfiles.
 724         * main.c (captured_main_1): Use all_objfiles.
 725         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
 726         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
 727         * guile/scm-pretty-print.c
 728         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
 729         * solib-spu.c (append_ocl_sos): Use all_objfiles.
 730         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
 731         (maintenance_print_msymbols): Use all_objfiles.
 732         * source.c (select_source_symtab): Use all_objfiles.
 733         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
 734         * symfile.c (remove_symbol_file_command)
 735         (expand_symtabs_matching, map_symbol_filenames): Use
 736         all_objfiles.
 737         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
 738         all_objfiles.
 739         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
 740         * objc-lang.c (find_methods): Use all_objfiles.
 741         * objfiles.c (have_partial_symbols, have_full_symbols)
 742         (have_minimal_symbols, qsort_cmp)
 743         (default_iterate_over_objfiles_in_search_order): Use
 744         all_objfiles.
 745         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
 746         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
 747         (maintenance_check_psymtabs): Use all_objfiles.
 748         (ALL_PSYMTABS): Remove.
 749         * compile/compile-object-run.c (do_module_cleanup): Use
 750         all_objfiles.
 751         * blockframe.c (find_pc_partial_function): Use all_objfiles.
 752         * cp-support.c (add_symbol_overload_list_qualified): Use
 753         all_objfiles.
 754         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 755         Use all_objfiles.
 756         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
 757         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
 758         all_objfiles.
 759         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 760         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
 761         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 762         Uses all_objfiles.
 763         * solib.c (solib_read_symbols): Use all_objfiles
 764
 765 2019-01-09  Tom Tromey  <tom@tromey.com>
 766
 767         * probe.c (parse_probes_in_pspace): Use all_objfiles.
 768         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
 769         all_objfiles.
 770         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
 771         * symmisc.c (print_symbol_bcache_statistics)
 772         (print_objfile_statistics, maintenance_print_objfiles)
 773         (maintenance_info_symtabs, maintenance_check_symtabs)
 774         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
 775         all_objfiles.
 776         * source.c (forget_cached_source_info): Use all_objfiles.
 777         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
 778         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 779         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
 780         * objfiles.c (update_section_map): Use all_objfiles.
 781         (shared_objfile_contains_address_p): Likewise.
 782         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
 783         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
 784
 785 2019-01-09  Tom Tromey  <tom@tromey.com>
 786
 787         * common/next-iterator.h: New file.
 788         * objfiles.h (class all_objfiles): New.
 789         (struct objfile_iterator): New.
 790
 791 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 792
 793         * NEWS: Move the description of the changed "frame", "select-frame",
 794          and "info frame" commands to the Changed commands section.
 795
 796 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
 797
 798         * gdbtypes.c (check_stub_method_group): Remove handling of old
 799         mangling schemes.
 800         * linespec.c (find_methods): Likewise.
 801         * stabsread.c (read_member_functions): Likewise.
 802         * valops.c (search_struct_method): Likewise.
 803         (value_struct_elt_for_reference): Likewise.
 804         * NEWS: Mention this change.
 805
 806 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 807
 808         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
 809         print_source_lines.
 810         * source.c (print_source_lines_base): Update line number check.
 811         (print_source_lines): New function.
 812         (source_lines_range::source_lines_range): New function.
 813         * source.h (class source_lines_range): New class.
 814         (print_source_lines): New declaration.
 815
 816 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 817
 818         * linespec.c (linespec_state_destructor): Free self->canonical_names.
 819
 820 2019-01-08  Tom Tromey  <tom@tromey.com>
 821             Simon Marchi  <simon.marchi@ericsson.com>
 822
 823         PR gdb/24060
 824         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
 825         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
 826         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 827         * f-exp.y (DOLLAR_VARIABLE): Likewise.
 828         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
 829         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 830
 831 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 832
 833         * source.c (select_source_symtab): Move header comment to
 834         declaration in source.h.
 835         (forget_cached_source_info_for_objfile): Likewise.
 836         (forget_cached_source_info): Likewise.
 837         (identify_source_line): Likewise.
 838         * source.h (identify_source_line): Move declaration from symtab.h
 839         and add comment from source.c
 840         (print_source_lines): Likewise.
 841         (forget_cached_source_info_for_objfile): Likewise.
 842         (forget_cached_source_info): Likewise.
 843         (select_source_symtab): Likewise.
 844         (enum print_source_lines_flag): Move definition from symtab.h.
 845         * symtab.h (identify_source_line): Move declaration to source.h.
 846         (print_source_lines): Likewise.
 847         (forget_cached_source_info_for_objfile): Likewise.
 848         (forget_cached_source_info): Likewise.
 849         (select_source_symtab): Likewise.
 850         (enum print_source_lines_flag): Move definition to source.h.
 851         * tui/tui-hooks.c: Add 'source.h' include.
 852
 853 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 854
 855         * source.c (print_source_lines_base): Handle requests to print
 856         reverse line number sequences, and guard against empty lines
 857         string.
 858
 859 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 860
 861         * source.c (print_source_lines_base): Fix skip of '\r' if next
 862         character is '\n'.
 863
 864 2019-01-06  Tom Tromey  <tom@tromey.com>
 865
 866         * c-exp.y (struct c_parse_state) <macro_original_text,
 867         expansion_obstack>: New member.
 868         (macro_original_text, expansion_obstack): Remove globals.
 869         (scan_macro_expansion, scanning_macro_expansion)
 870         (finished_macro_expansion): Update.
 871         (scan_macro_cleanup): Remove.
 872         (yylex, c_parse): Update.
 873
 874 2019-01-06  Tom Tromey  <tom@tromey.com>
 875
 876         * c-exp.y (struct c_parse_state) <strings>: New member.
 877         (operator_stoken): Update.
 878
 879 2019-01-06  Tom Tromey  <tom@tromey.com>
 880
 881         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
 882         (union type_stack_elt) <typelist_val>: Now a pointer to
 883         std::vector.
 884         (type_stack_cleanup): Don't declare.
 885         (push_typelist): Update.
 886         * parse.c (pop_typelist): Return a std::vector.
 887         (push_typelist): Take a std::vector.
 888         (follow_types): Update.  Do not free args.
 889         (type_stack_cleanup): Remove.
 890         * c-exp.y (struct c_parse_state): New.
 891         (cpstate): New global.
 892         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
 893         (nonempty_typelist): Update.
 894         (func_mod): Create a new vector.
 895         (c_parse): Create a c_parse_state.
 896         (check_parameter_typelist): Do not delete params.
 897         (function_method): Update.  Do not delete type_list.
 898
 899 2019-01-06  Tom Tromey  <tom@tromey.com>
 900
 901         PR gdb/28155:
 902         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
 903         check_typedef.
 904         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
 905         (print_return_value): Likewise.
 906
 907 2019-01-05  Tom Tromey  <tom@tromey.com>
 908
 909         * contrib/cleanup_check.py: Remove.
 910         * contrib/gcc-with-excheck: Remove.
 911         * contrib/exsummary.py: Remove.
 912         * contrib/excheck.py: Remove.
 913
 914 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
 915
 916         * thread.c (delete_thread_1): Add gdb_assert that THR is not
 917         NULL. Initialize tpprev to NULL instead of assigning it
 918         to NULL on the next statement.
 919         * windows-nat.c (windows_delete_thread): Remove check for
 920         main_thread_id before printing thread exit notifications.
 921         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
 922         Remove thread ID check against main_thread_id.
 923         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
 924         windows_delete_thread.
 925         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
 926
 927 2019-01-04  Tom Tromey  <tom@tromey.com>
 928
 929         * compile/compile.c (_initialize_compile): Use upper case for
 930         metasyntactic variables.
 931         * symmisc.c (_initialize_symmisc): Use upper case for
 932         metasyntactic variables.
 933         * psymtab.c (_initialize_psymtab): Use upper case for
 934         metasyntactic variables.
 935         * demangle.c (demangle_command): Use upper case for metasyntactic
 936         variables.
 937         (_initialize_demangler): Likewise.
 938         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
 939         variables.
 940
 941 2019-01-03  Tom Tromey  <tom@tromey.com>
 942
 943         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
 944
 945 2019-01-03  Tom Tromey  <tom@tromey.com>
 946
 947         * python/py-symtab.c (salpy_str): Update.
 948         (struct salpy_sal_object) <symtab>: Now a PyObject.
 949         (salpy_dealloc): Update.
 950         (del_objfile_sal): Use gdbpy_ref.
 951
 952 2019-01-03  Tom Tromey  <tom@tromey.com>
 953
 954         * python/py-type.c (convert_field): Use new_reference.  Return
 955         gdbpy_ref.
 956         (make_fielditem): Return gdbpy_ref.
 957         (typy_fields): Update.
 958         (typy_getitem): Update.
 959         (field_name): Return gdbpy_ref.  Use new_reference.
 960         (typy_iterator_iternext): Update.
 961
 962 2019-01-03  Tom Tromey  <tom@tromey.com>
 963
 964         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
 965
 966 2019-01-03  Tom Tromey  <tom@tromey.com>
 967
 968         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
 969         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
 970         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
 971         (pspy_set_frame_filters, pspy_set_frame_unwinders)
 972         (pspy_set_type_printers): Likewise.
 973         * python/py-function.c (fnpy_init): Use gdbpy_ref.
 974         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
 975         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
 976         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
 977         (objfpy_set_type_printers): Likewise.
 978
 979 2019-01-03  Tom Tromey  <tom@tromey.com>
 980
 981         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
 982         (gdbpy_print_stack): Use gdbpy_err_fetch.
 983         * python/python-internal.h (class gdbpy_err_fetch): New class.
 984         (class gdbpy_enter) <m_error_type, m_error_value,
 985         m_error_traceback>: Remove.
 986         <m_error>: New member.
 987         (gdbpy_exception_to_string): Don't declare.
 988         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
 989         * python/py-value.c (convert_value_from_python): Use
 990         gdbpy_err_fetch.
 991         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
 992         gdbpy_exception_to_string.
 993         (gdbpy_handle_exception): Use gdbpy_err_fetch.
 994         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
 995         gdbpy_err_fetch.
 996
 997 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 998
 999         * linux-nat.c (delete_lwp_cleanup): Delete.
1000         (struct lwp_deleter): New struct.
1001         (lwp_info_up): New typedef.
1002         (linux_nat_target::follow_fork): Delete cleanup, and make use of
1003         lwp_info_up.
1004
1005 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1006
1007         * linux-fork.c (class scoped_switch_fork_info): New class.
1008         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
1009
1010 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1011
1012         * valops.c (find_overload_match): Remove use of null_cleanup, and
1013         calls to do_cleanups.
1014
1015 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1016
1017         * compile/compile-cplus-types.c
1018         (compile_cplus_instance::decl_name): Handle changes to
1019         cp_func_name.
1020         * cp-support.c (cp_func_name): Update header comment, update
1021         return type.
1022         * cp-support.h (cp_func_name): Update return type in declaration.
1023         * valops.c (find_overload_match): Move temp_func local to top
1024         level of function and change its type.  Use temp_func to hold and
1025         delete temporary string obtained from cp_func_name.
1026
1027 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1028
1029         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
1030         gdb::char_vector, remove cleanup, and update uses of `msg`.
1031
1032 2019-01-03  Jim Wilson  <jimw@sifive.com>
1033
1034         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
1035
1036 2019-01-02  Tom Tromey  <tom@tromey.com>
1037
1038         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
1039         (tdesc_parse_xml): Remove cleanups.
1040         * target-descriptions.h (make_cleanup_free_target_description):
1041         Don't declare.
1042         (target_desc_deleter): New struct.
1043         (target_desc_up): New typedef.
1044         * target-descriptions.c (target_desc_deleter::operator()): Rename
1045         from free_target_description.
1046         (make_cleanup_free_target_description): Remove.
1047
1048 2019-01-02  Tom Tromey  <tom@tromey.com>
1049
1050         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
1051         constructor, destructor.
1052         (linespec_parser): Remove typedef.
1053         (~linespec_parser): Rename from linespec_parser_delete.
1054         (linespec_lex_to_end, linespec_complete_label)
1055         (linespec_complete): Update.
1056         (decode_line_full): Remove cleanups.
1057         (decode_line_1): Update.
1058
1059 2019-01-02  Tom Tromey  <tom@tromey.com>
1060
1061         * python/python-internal.h (inferior_to_inferior_object): Change
1062         return type.
1063         * python/py-exitedevent.c (create_exited_event_object): Update.
1064         * python/py-inferior.c (inferior_to_inferior_object): Return
1065         gdbpy_ref.
1066         (python_new_inferior, python_inferior_deleted)
1067         (thread_to_thread_object, delete_thread_object)
1068         (build_inferior_list, gdbpy_selected_inferior): Update.
1069         * python/py-infthread.c (create_thread_object): Update.  Also fail
1070         if inferior_to_inferior_object fails.
1071
1072 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
1073
1074         * inferior.h (class inferior) <displaced_step_state>: New field.
1075         * infrun.h (struct displaced_step_state): Move here from
1076         infrun.c.  Initialize fields, add constructor.
1077         <inf>: Remove field.
1078         <reset>: New method.
1079         * infrun.c (struct displaced_step_inferior_state): Move to
1080         infrun.h.
1081         (displaced_step_inferior_states): Remove.
1082         (get_displaced_stepping_state): Adust.
1083         (displaced_step_in_progress_any_inferior): Adjust.
1084         (displaced_step_in_progress_thread): Adjust.
1085         (displaced_step_in_progress): Adjust.
1086         (add_displaced_stepping_state): Remove.
1087         (get_displaced_step_closure_by_addr): Adjust.
1088         (remove_displaced_stepping_state): Remove.
1089         (infrun_inferior_exit): Call displaced_step_state.reset.
1090         (use_displaced_stepping): Don't check for NULL.
1091         (displaced_step_prepare_throw): Call
1092         get_displaced_stepping_state.
1093         (displaced_step_fixup): Don't check for NULL.
1094         (prepare_for_detach): Don't check for NULL.
1095
1096 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1097
1098         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
1099          in case of call that did not complete.
1100
1101 2019-01-02  Andrey Utkin  <autkin@undo.io>
1102
1103         * symfile.c (find_separate_debug_file): Fix search of debug files for
1104         remote debuggee.
1105
1106 2019-01-02  Tom Tromey  <tom@tromey.com>
1107
1108         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
1109         indentation.
1110         * python/py-frame.c (frapy_older): Remove cast.
1111         (frapy_newer): Likewise.
1112         * python/py-breakpoint.c (local_setattro): Remove cast.
1113         * python/py-arch.c (archpy_name): Remove local variable.
1114         * python/py-type.c (gdbpy_lookup_type): Remove cast.
1115
1116 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
1117
1118         * unittests/basic_string_view/element_access/char/empty.cc:
1119         Fix year range in copyright header.
1120
1121 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1122
1123         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
1124         Delete.
1125         <operator==>: Update with for removed field.
1126         <hash>: Likewise.
1127         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
1128         <isa_features>: ...this.
1129         <abi_features>: New field.
1130         (riscv_isa_flen): Update comment.
1131         (riscv_abi_xlen): New declaration.
1132         (riscv_abi_flen): New declaration.
1133         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
1134         isa_features.
1135         (riscv_abi_xlen): New function.
1136         (riscv_isa_flen): Update to get answer from isa_features.
1137         (riscv_abi_flen): New function.
1138         (riscv_has_fp_abi): Update to get answer from abi_features.
1139         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
1140         xlen and flen.
1141         (riscv_call_info) <xlen, flen>: Update comment.
1142         (riscv_call_arg_struct): Remove invalid assertions
1143         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
1144         is removed.
1145         (riscv_gdbarch_init): Gather isa features and abi features
1146         separately, ensure both match on the gdbarch when reusing an old
1147         gdbarch.  Relax an error check to allow 32-bit abi float to run on
1148         a target with 64-bit float hardware.
1149
1150 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1151
1152         * source.c (search_command_helper): Stop reverse search
1153         when line 1 has been searched.
1154
1155 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1156
1157         * record-full.c (record_full_base_target::close): Rewrite
1158         record_full_core_buf_list free logic.
1159
1160 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1161
1162         * break-catch-syscall.c (print_one_catch_syscall): xfree
1163         the last text.
1164
1165 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1166
1167         * top.c (print_gdb_version): Update Copyright year in version
1168         message.
1169
1170 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1171
1172         Update copyright year range in all GDB files.
1173
1174 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
1175
1176         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
1177
1178 For older changes see ChangeLog-2018.
1179 \f
1180 Local Variables:
1181 mode: change-log
1182 left-margin: 8
1183 fill-column: 74
1184 version-control: never
1185 coding: utf-8
1186 End:
1187