gdb/ChangeLog

   1 2019-06-10  Tom Tromey  <tromey@adacore.com>
   2
   3         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
   4         data.
   5         (elf_new_init): Don't call stabsread_new_init.
   6         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
   7         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
   8         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
   9
  10 2019-06-10  Tom de Vries  <tdevries@suse.de>
  11
  12         PR symtab/16264
  13         PR symtab/24517
  14         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
  15
  16 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
  17
  18         * source.c (find_and_open_source): Also rewrite relative file
  19         names.
  20
  21 2019-04-26  Amos Bird  <amosbird@gmail.com>
  22
  23         * annotate.c (annotate_thread_exited): Add "thread-exited"
  24         annotation.
  25
  26 2019-06-06  Tom Tromey  <tromey@adacore.com>
  27
  28         * maint.h (class scoped_command_stats): Use
  29         DISABLE_COPY_AND_ASSIGN.
  30         <print_time>: New method.
  31         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
  32         print_time.
  33         (scoped_command_stats::print_time): New method.
  34
  35 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
  36
  37         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
  38         instructions of lengths 6 or 8 bytes.
  39
  40 2019-06-04  Pedro Alves  <palves@redhat.com>
  41
  42         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
  43
  44         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
  45         * breakpoint.c (condition_completer): Likewise.
  46         * cli/cli-dump.c (scan_expression): Likewise.
  47         * common/filestuff.c (mkdir_recursive): Likewise.
  48         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
  49         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
  50         (gdb_abspath): Likewise.
  51         * compile/compile-cplus-types.c
  52         (compile_cplus_instance::decl_name): Likewise.
  53         * completer.c (complete_explicit_location):
  54         (signal_completer, reg_or_group_completer_1): Likewise.
  55         * cp-support.c (cp_remove_params_if_any): Likewise.
  56         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
  57         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
  58         * infcmd.c (strip_bg_char): Likewise.
  59         * linespec.c (copy_token_string): Likewise.
  60         * mi/mi-main.c (output_cores): Likewise.
  61         * psymtab.c (psymtab_search_name):
  62         * symfile.c (test_set_ext_lang_command): Likewise.
  63         * target.c (target_fileio_read_stralloc): Likewise.
  64         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
  65         * value.c (complete_internalvar): Likewise.
  66
  67 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
  68
  69         Add objfile property to gdb.Type.
  70         * NEWS: Mention Python API addition.
  71         * python/py-type.c (typy_get_objfile): New method.
  72
  73 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  74
  75         * NEWS: Mention the new set|show style [title|highlight].
  76         Mention changes to "show style", "help" and "apropos".
  77
  78 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  79
  80         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
  81         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
  82         instead of print_help_for_command.
  83         (print_doc_of_command): New function.
  84         (help_list): Add 'apropos -v word' suggestion.
  85         (print_help_for_command): Style the command name using title style.
  86         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
  87         (_initialize_cli_cmds): Describe -v in apropos_command help.
  88
  89 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  90
  91         * cli/cli-style.h (cli_style_option): Add name in constructor,
  92         add m_name class member, add constructor with intensity,
  93         add name class function.
  94         (cli_style_option::add_setshow_commands): Remove name argument.
  95         (highlight_style, title_style): New styles.
  96         * cli/cli-style.c (do_show): New function that shows a style
  97         characteristic styling the style name with itself.
  98         (set_style_name): New function.
  99         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
 100         Update all callers according to the changes in cli/cli-style.h.
 101         * utils.h (fputs_highlighted): New function.
 102         * utils.c (fputs_highlighted): Likewise.
 103
 104 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 105
 106         * NEWS: Mention new pipe command and new convenience variables.
 107
 108 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 109
 110         * cli/cli-cmds.c (pipe_command): New function.
 111         (_initialize_cli_cmds): Call add_com for pipe_command.
 112         Define | as an alias for pipe.
 113         (exit_status_set_internal_vars): New function.
 114         (shell_escape): Call exit_status_set_internal_vars.
 115         cli/cli-decode.c (find_command_name_length): Recognize | as
 116         a single character command.
 117
 118 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 119
 120         * gdbcmd.h (execute_command_to_ui_file): New declaration.
 121         top.c (execute_command_to_ui_file): New function, mostly a copy
 122         of execute_command_to_string.
 123         (execute_command_to_string): Implement by calling
 124         execute_command_to_ui_file.
 125
 126 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 127
 128         * top.h (saved_command_line): Remove declaration.
 129         * top.c (previous_saved_command_line, previous_repeat_arguments):
 130         New variables.
 131         (saved_command_line): Make static, define together with other
 132         'repeat variables'.
 133         (dont_repeat): Clear repeat_arguments.
 134         (repeat_previous, get_saved_command_line, save_command_line):
 135         New functions.
 136         (gdb_init): Initialize saved_command_line
 137         and previous_saved_command_line.
 138         * main.c (captured_main_1): Remove saved_command_line initialization.
 139         * event-top.c (handle_line_of_input): Update to use
 140         the new 'repeat' related functions instead of direct access to
 141         saved_command_line.
 142         * command.h (repeat_previous, get_saved_command_line,
 143         save_command_line): New declarations.
 144         (dont_repeat): Add comment.
 145
 146 2019-05-30  Tom Tromey  <tromey@adacore.com>
 147
 148         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
 149         Fix comment.
 150         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
 151
 152 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
 153
 154         PR cli/24587
 155         * completer.c (complete): Initialize variable word.
 156
 157 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
 158
 159         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 160         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
 161         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
 162         'body' is NULL to the outter 'if', protecting the '!is_define'
 163         situation as well.
 164
 165 2019-05-29  Tom Tromey  <tromey@adacore.com>
 166
 167         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
 168         (dwarf_unknown): New function.
 169         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
 170         (dwarf_type_encoding_name): Use dwarf_unknown.
 171
 172 2019-05-29  Tom Tromey  <tromey@adacore.com>
 173
 174         PR c++/20020:
 175         * cp-valprint.c (cp_print_value_fields): Call
 176         cp_print_static_field inside "try".
 177
 178 2019-05-29  Tom Tromey  <tromey@adacore.com>
 179
 180         * inflow.c (struct terminal_info): Add default operator=.
 181         * configure: Rebuild.
 182         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
 183         -Wdeprecated-copy-dtor, -Wredundant-move.
 184
 185 2019-05-29  Tom Tromey  <tromey@adacore.com>
 186
 187         * NEWS: Add entry.
 188         * infcmd.c (print_return_value_1): Handle finish_print
 189         option.
 190         (show_print_finish): New function.
 191         (_initialize_infcmd): Add "set/show print finish" commands.
 192         * valprint.c (user_print_options): Initialize new member.
 193         * valprint.h (struct value_print_options) <finish_print>: New
 194         member.
 195
 196 2019-05-28  Tom Tromey  <tromey@adacore.com>
 197
 198         * ada-lang.c (ada_remove_Xbn_suffix)
 199         (find_old_style_renaming_symbol)
 200         (parse_old_style_renaming): Remove.
 201         (ada_find_renaming_symbol): Don't call
 202         find_old_style_renaming_symbol.
 203         (ada_is_renaming_symbol): Rename from
 204         ada_find_renaming_symbol.  Remove "block" parameter.  Return
 205         bool.  Now static.
 206         (ada_read_var_value): Update and simplify.
 207         * ada-exp.y (write_var_or_type): Remove old code.
 208
 209 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
 210
 211         * event-top.c: Remove include comment.
 212         * inflow.c (class scoped_ignore_sigttou): Move from here...
 213         * inflow.h (class scoped_ignore_sigttou): ...to here.
 214         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
 215         * top.c:  Remove include comment.
 216
 217 2019-05-27  Tom Tromey  <tom@tromey.com>
 218
 219         * NEWS: Fix typo.
 220
 221 2019-05-22  Tom Tromey  <tromey@adacore.com>
 222
 223         * target.c (target_follow_exec): Constify parameter.
 224         * target-delegates.c: Rebuild.
 225         * remote.c (remote_target::follow_exec): Constify parameter.
 226         * infrun.c (follow_exec): Constify parameter.
 227         * target.h (struct target_ops) <follow_exec>: Constify parameter.
 228         (target_follow_exec): Likewise.
 229
 230 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 231
 232         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
 233         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
 234
 235 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 236
 237         * NEWS: Add debugredirect and testsuite sections.
 238
 239 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
 240
 241         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
 242         target descriptions using exclusively floating point register name
 243         aliases.
 244
 245 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 246
 247         PR gdb/18644:
 248         * f-lang.c (build_fortran_types): Handle the case where
 249         gdbarch_floatformat_for_type returns a nullptr.
 250
 251 2019-05-21  Tom de Vries  <tdevries@suse.de>
 252
 253         PR cli/24587
 254         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
 255
 256 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 257
 258         PR gdb/18644:
 259         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
 260         16-byte floats.
 261         * i386-tdep.c (i386_floatformat_for_type): Use
 262         floatformats_ia64_quad for the 16-byte floating point component
 263         within a fortran 32-byte complex number.
 264
 265 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 266
 267         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
 268         delete default constructor.
 269         (find_partial_die): Update to return const struct.
 270         (partial_die_parent_scope): Move variable declaration into scope
 271         of its use and change its type to auto.
 272         (guess_partial_die_structure_name): Likewise.
 273         (partial_die_info::fixup): Likewise.
 274
 275 2019-05-17  Tom Tromey  <tromey@adacore.com>
 276
 277         * source.c (find_and_open_source): Remove cast.
 278
 279 2019-05-17  Tom Tromey  <tromey@adacore.com>
 280
 281         * annotate.c (annotate_source): Make "filename" const.
 282         * annotate.h (annotate_source): Use const.
 283
 284 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 285
 286         * disasm.c (set_disassembler_options): Send errors to stderr.
 287
 288 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 289
 290         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
 291         (cli_interp_base::set_logging): Check debug_redirect.
 292         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
 293         * cli/cli-logging.c (debug_redirect): Add static variable.
 294         (pop_output_files): Add default param.
 295         (handle_redirections): Print debug setting.
 296         (show_logging_command): Likewise.
 297         (_initialize_cli_logging): Add debugredirect command.
 298         * interps.c (current_interp_set_logging): Add debug_redirect
 299         parameter.
 300         * interps.h (set_logging): Add debug_redirect parameter.
 301         (current_interp_set_logging): Likewise.
 302         * mi/mi-common.h: Likewise.
 303         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
 304
 305 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 306             Tom Tromey  <tromey@adacore.com>
 307
 308         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
 309         directly.
 310         * cli/cli-interp.h (make_logging_output): Remove declaration.
 311         * cli/cli-logging.c (make_logging_output): Remove function.
 312         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
 313         directly.
 314         * ui-file.c (tee_file::tee_file): Remove bools.
 315         (tee_file::~tee_file): Remove deletes.
 316         * ui-file.h (tee_file): Remove bools.
 317
 318 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
 319
 320         * mi/mi-cmds.h (mi_cmd_complete): New function.
 321         * mi/mi-main.c (mi_cmd_complete): Likewise.
 322         * mi/mi-cmds.c: Define new MI command -complete.
 323         * NEWS: Mention new -complete command.
 324
 325 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
 326
 327         * completer.h (complete): New function.
 328         * completer.c (complete): Likewise.
 329         * cli/cli-cmds.c: (complete_command): Update to use new complete()
 330         function defined in completer.h.
 331
 332 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
 333
 334        * MAINTAINERS (Write After Approval): Add myself.
 335
 336 2019-05-17  Tom de Vries  <tdevries@suse.de>
 337
 338         PR gdb/24094
 339         * dwarf2read.c (struct cu_partial_die_info): New struct.
 340         (find_partial_die): Return cu_partial_die_info.
 341         (partial_die_parent_scope, guess_partial_die_structure_name)
 342         (partial_die_info::fixup): Handle new return type of find_partial_die.
 343
 344 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 345
 346         * stap-probe.c (stap_parse_register_operand): Make "regname" an
 347         "std::string", simplifying the algorithm.
 348
 349 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 350
 351         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
 352         (stap_static_probe_ops::get_probes): Likewise.
 353
 354 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 355
 356         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
 357         '-')" and "else if".
 358         (stap_parse_single_operand): Join checks for
 359         "gdbarch_stap_parse_special_token_p" and
 360         "gdbarch_stap_parse_special_token" in the same "if" statement.
 361         Invert check when verifying for operation on register
 362         displacement.
 363
 364 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 365
 366         * stap-probe.c (stap_get_opcode): Update comment.
 367         (stap_get_expected_argument_type): Likewise.
 368         (handle_stap_probe): Likewise.
 369
 370 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 371
 372         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
 373         return type to 'bool'.  Adjust comment.  Use 'bool' when
 374         appropriate.
 375         (i386_stap_parse_special_token_three_arg_disp): Likewise.
 376         * stap-probe.c (stap_parse_argument_1): Likewise.
 377         (stap_is_operator): Likewise.
 378         (stap_is_generic_prefix): Likewise.
 379         (stap_is_register_prefix): Likewise.
 380         (stap_is_register_indirection_prefix): Likewise.
 381         (stap_is_integer_prefix): Likewise.
 382         (stap_generic_check_suffix): Likewise.
 383         (stap_check_integer_suffix): Likewise.
 384         (stap_check_register_suffix): Likewise.
 385         (stap_check_register_indirection_suffix): Likewise.
 386         (stap_parse_register_operand): Likewise.
 387         (stap_parse_single_operand): Likewise.
 388         (stap_parse_argument_1): Likewise.
 389         (stap_probe::get_argument_count): Likewise.
 390         (stap_is_operator): Likewise.
 391
 392 2019-05-16  Tom Tromey  <tromey@adacore.com>
 393
 394         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
 395         keyword to foreach.
 396
 397 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
 398
 399         * linux-thread-db.c (try_thread_db_load_1): Change return type
 400         to bool.
 401         (try_thread_db_load): Likewise.
 402         (try_thread_db_load_from_pdir_1): Likewise.
 403         (try_thread_db_load_from_pdir): Likewise.
 404         (try_thread_db_load_from_sdir): Likewise.
 405         (try_thread_db_load_from_dir): Likewise.
 406         (thread_db_load_search): Likewise.
 407         (has_libpthread): Likewise.
 408         (thread_db_load): Likewise.
 409
 410 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
 411
 412         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 413         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
 414         NULL, and complain/return if that's the case.
 415
 416 2019-05-15  John Darrington <john@darrington.wattle.id.au>
 417
 418         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
 419         (advance, posn, abstract_read_memory): New functions.
 420         [struct mem_read_abstraction]: New struct.
 421         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
 422
 423 2019-05-14  Tom Tromey  <tromey@adacore.com>
 424
 425         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
 426         value is not lval_memory.
 427
 428 2019-05-14  Tom Tromey  <tromey@adacore.com>
 429
 430         * solib.c (info_sharedlibrary_command): Style the file name.
 431
 432 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
 433
 434         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
 435         (aarch64_vnv_type): Likewise.
 436         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
 437         * common/tdesc.c: Likewise.
 438         * common/tdesc.h (enum tdesc_type_kind): Likewise.
 439         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
 440         * features/aarch64-fpu.xml: Add ieee half view.
 441         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
 442         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
 443         * gdbtypes.h (struct builtin_type): Likewise.
 444         (struct objfile_type): Likewise.
 445
 446 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
 447
 448         * language.c (language_sniff_from_mangled_name): Fix "langauge"
 449         typo.
 450         * location.h (string_to_event_location): Likewise.
 451
 452 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
 453
 454         GDB 8.3 released.
 455
 456 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 457
 458         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
 459         New variable declaration.
 460         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
 461         New variable.
 462         (print_one_breakpoint): Use ui_out::test_flags and new global
 463         variable to compute use_fixed_output.
 464         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
 465         Remove.
 466         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
 467         (mi_multi_location_breakpoint_output_fixed): Remove.
 468         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
 469         new variable.
 470         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
 471         fix_multi_location_breakpoint_output flag if version >= 3.
 472         * ui-out.h (enum ui_out_flag)
 473         <fix_multi_location_breakpoint_output>: New enumerator.
 474
 475 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 476
 477         * contrib/cc-with-tweaks.sh: Validate dwz's work.
 478
 479 2019-05-10  Tom Tromey  <tromey@adacore.com>
 480
 481         * ada-lang.c (catch_ada_completer): New function.
 482         (_initialize_ada_language): Use it.
 483
 484 2019-05-10  Tom Tromey  <tromey@adacore.com>
 485
 486         * thread.c (print_thread_info): Make "requested_threads" const.
 487         * gdbthread.h (print_thread_info): Make "requested_threads"
 488         const.
 489         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
 490         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
 491
 492 2019-05-08  Tom Tromey  <tom@tromey.com>
 493
 494         * gdbtypes.c (objfile_type_data): Change type.
 495         (objfile_type, _initialize_gdbtypes): Update.
 496
 497 2019-05-08  Tom Tromey  <tom@tromey.com>
 498
 499         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
 500         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
 501         (_initialize_dwarf2_frame): Update.
 502
 503 2019-05-08  Tom Tromey  <tom@tromey.com>
 504
 505         * objc-lang.c (objc_objfile_data): Change type.
 506         (find_methods): Update.
 507         (_initialize_objc_lang): Remove.
 508
 509 2019-05-08  Tom Tromey  <tom@tromey.com>
 510
 511         * stabsread.c (rs6000_builtin_type_data): Change type.
 512         (rs6000_builtin_type, _initialize_stabsread): Update.
 513
 514 2019-05-08  Tom Tromey  <tom@tromey.com>
 515
 516         * mips-tdep.c (mips_pdr_data): Remove.
 517         (_initialize_mips_tdep): Update.
 518
 519 2019-05-08  Tom Tromey  <tom@tromey.com>
 520
 521         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
 522         (hppa_init_objfile_priv_data, read_unwind_info)
 523         (find_unwind_entry, _initialize_hppa_tdep): Update.
 524
 525 2019-05-08  Tom Tromey  <tom@tromey.com>
 526
 527         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
 528         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
 529         on obstack.
 530         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
 531
 532 2019-05-08  Tom Tromey  <tom@tromey.com>
 533
 534         * mdebugread.c (basic_type_data): Change type.
 535         (basic_type, _initialize_mdebugread): Update.
 536
 537 2019-05-08  Tom Tromey  <tom@tromey.com>
 538
 539         * common/gdb_unique_ptr.h (struct noop_deleter): New.
 540
 541 2019-05-08  Tom Tromey  <tom@tromey.com>
 542
 543         * nto-tdep.c (nto_inferior_data_reg): Change type.
 544         (nto_inferior_data): Update.
 545         (nto_inferior_data_cleanup, nto_new_inferior_data)
 546         (_initialize_nto_tdep): Remove.
 547         * nto-tdep.h (struct nto_inferior_data): Add initializers.
 548
 549 2019-05-08  Tom Tromey  <tom@tromey.com>
 550
 551         * ada-lang.c (struct ada_inferior_data): Add initializers.
 552         (ada_inferior_data): Change type.
 553         (ada_inferior_data_cleanup): Remove.
 554         (get_ada_inferior_data, ada_inferior_exit)
 555         (struct ada_pspace_data): Add initializers, destructor.
 556         (ada_pspace_data_handle): Change type.
 557         (get_ada_pspace_data): Update.
 558         (ada_pspace_data_cleanup): Remove.
 559
 560 2019-05-08  Tom Tromey  <tom@tromey.com>
 561
 562         * coffread.c (struct coff_symfile_info): Add initializers.
 563         (coff_objfile_data_key): Move lower.  Change type.
 564         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
 565         Update.
 566         (coff_free_info): Remove.
 567
 568 2019-05-08  Tom Tromey  <tom@tromey.com>
 569
 570         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
 571         (fbsd_pspace_data_handle): Move lower.  Change type.
 572         (get_fbsd_pspace_data): Update.
 573         (fbsd_pspace_data_cleanup): Remove.
 574         (_initialize_fbsd_tdep): Update.
 575
 576 2019-05-08  Tom Tromey  <tom@tromey.com>
 577
 578         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
 579         (get_ada_tasks_pspace_data): Update.
 580         (ada_tasks_pspace_data_cleanup): Remove.
 581         (_initialize_tasks): Update.
 582         (ada_tasks_inferior_data_handle): Change type.
 583         (get_ada_tasks_inferior_data): Update.
 584         (ada_tasks_inferior_data_cleanup): Remove.
 585         (struct ada_tasks_pspace_data): Add initializers.
 586
 587 2019-05-08  Tom Tromey  <tom@tromey.com>
 588
 589         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
 590         * symfile-debug.c (debug_sym_get_probes): Change type.
 591         * stap-probe.c (handle_stap_probe):
 592         (stap_static_probe_ops::get_probes): Change type.
 593         * probe.h (class static_probe_ops) <get_probes>: Change type.
 594         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
 595         (parse_probes_in_pspace): Update.
 596         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
 597         Update.
 598         (any_static_probe_ops::get_probes): Change type.
 599         * elfread.c (elfread_data): New typedef.
 600         (probe_key): Change type.
 601         (elf_get_probes): Likewise.  Update.
 602         (probe_key_free): Remove.
 603         (_initialize_elfread): Update.
 604         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
 605         Change type.
 606         (dtrace_process_dof_probe, dtrace_process_dof)
 607         (dtrace_static_probe_ops::get_probe): Change type.
 608
 609 2019-05-08  Tom Tromey  <tom@tromey.com>
 610
 611         * xcoffread.c (struct xcoff_symfile_info): Rename from
 612         coff_symfile_info.  Add initializers.
 613         (xcoff_objfile_data_key): Move lower.  Change type.
 614         (XCOFF_DATA): Rewrite.
 615         (xcoff_free_info): Remove.
 616         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
 617         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
 618         (xcoff_initial_scan): Update.
 619
 620 2019-05-08  Tom Tromey  <tom@tromey.com>
 621
 622         * solib-svr4.c (struct svr4_info): Add initializers and
 623         destructor.
 624         <probes_table>: Now an htab_up.
 625         (solib_svr4_pspace_data): Change type.
 626         (free_probes_table): Simplify.
 627         (~svr4_info): Rename from svr4_pspace_data_cleanup.
 628         (get_svr4_info, probes_table_htab_remove_objfile_probes)
 629         (probes_table_remove_objfile_probes, register_solib_event_probe)
 630         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
 631         (_initialize_svr4_solib): Update.
 632
 633 2019-05-08  Tom Tromey  <tom@tromey.com>
 634
 635         * remote.c (remote_pspace_data): Change type.
 636         (remote_pspace_data_cleanup): Remove.
 637         (get_remote_exec_file, set_pspace_remote_exec_file)
 638         (_initialize_remote): Update.
 639
 640 2019-05-08  Tom Tromey  <tom@tromey.com>
 641
 642         * breakpoint.c (breakpoint_objfile_key): Change type.
 643         (get_breakpoint_objfile_data): Update.
 644         (free_breakpoint_objfile_data): Remove.
 645         (_initialize_breakpoint): Update.
 646
 647 2019-05-08  Tom Tromey  <tom@tromey.com>
 648
 649         * linux-tdep.c (struct linux_info): Add initializers.
 650         (linux_inferior_data): Move.  Change type.
 651         (invalidate_linux_cache_inf): Update.
 652         (linux_inferior_data_cleanup): Remove.
 653         (get_linux_inferior_data, _initialize_linux_tdep): Update.
 654
 655 2019-05-08  Tom Tromey  <tom@tromey.com>
 656
 657         * auxv.c (auxv_inferior_data): Move.  Change type.
 658         (auxv_inferior_data_cleanup): Remove.
 659         (invalidate_auxv_cache_inf): Rewrite.
 660         (get_auxv_inferior_data, _initialize_auxv): Update.
 661
 662 2019-05-08  Tom Tromey  <tom@tromey.com>
 663
 664         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
 665         (symfile_debug_objfile_data_key): Change type.
 666         (symfile_debug_installed, debug_qf_has_symbols)
 667         (debug_qf_find_last_source_symtab)
 668         (debug_qf_forget_cached_source_info)
 669         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
 670         (debug_qf_print_stats, debug_qf_dump)
 671         (debug_qf_expand_symtabs_for_function)
 672         (debug_qf_expand_all_symtabs)
 673         (debug_qf_expand_symtabs_with_fullname)
 674         (debug_qf_map_matching_symbols)
 675         (debug_qf_expand_symtabs_matching)
 676         (debug_qf_find_pc_sect_compunit_symtab)
 677         (debug_qf_map_symbol_filenames)
 678         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
 679         (debug_sym_new_init, debug_sym_init, debug_sym_read)
 680         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
 681         (debug_sym_read_linetable, debug_sym_relocate): Update.
 682         (symfile_debug_free_objfile): Remove.
 683         (install_symfile_debug_logging, _initialize_symfile_debug):
 684         Update.
 685
 686 2019-05-08  Tom Tromey  <tom@tromey.com>
 687
 688         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
 689         allocate_on_obstack.
 690         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
 691         (get_dwarf2_per_objfile): Update.
 692         (set_dwarf2_per_objfile): Remove.
 693         (dwarf2_has_info, dwarf2_get_section_info): Update.
 694         (dwarf2_free_objfile): Remove.
 695         (_initialize_dwarf2_read): Update.
 696
 697 2019-05-08  Tom Tromey  <tom@tromey.com>
 698
 699         * auto-load.c (struct auto_load_pspace_info): Add destructor and
 700         initializers.
 701         <unsupported_script_warning_printed,
 702         script_not_found_warning_printed>: Now bool.
 703         (auto_load_pspace_data): Change type.
 704         (~auto_load_pspace_info): Rename from
 705         auto_load_pspace_data_cleanup.
 706         (get_auto_load_pspace_data, init_loaded_scripts_info)
 707         (clear_section_scripts, maybe_print_unsupported_script_warning)
 708         (maybe_print_script_not_found_warning, _initialize_auto_load):
 709         Update.
 710
 711 2019-05-08  Tom Tromey  <tom@tromey.com>
 712
 713         * objfiles.c (objfile_pspace_info): Add destructor and
 714         initializers.
 715         (objfiles_pspace_data): Change type.
 716         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
 717         (get_objfile_pspace_data): Update.
 718         (objfiles_bfd_data): Change type.
 719         (get_objfile_bfd_data): Update.
 720         (objfile_bfd_data_free, _initialize_objfiles): Remove.
 721
 722 2019-05-08  Tom Tromey  <tom@tromey.com>
 723
 724         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
 725         Change type.
 726         (get_catch_syscall_inferior_data): Update.
 727         (catch_syscall_inferior_data_cleanup): Remove.
 728         (_initialize_break_catch_syscall): Update.
 729
 730 2019-05-08  Tom Tromey  <tom@tromey.com>
 731
 732         * inflow.c (struct terminal_info): Add destructor and
 733         initializers.
 734         (inflow_inferior_data): Change type.
 735         (~terminal_info): Rename from inflow_inferior_data_cleanup.
 736         (get_inflow_inferior_data, inflow_inferior_exit)
 737         (swap_terminal_info, _initialize_inflow): Update.
 738
 739 2019-05-08  Tom Tromey  <tom@tromey.com>
 740
 741         * target-dcache.c (target_dcache_cleanup): Remove.
 742         (target_dcache_aspace_key): Change type.
 743         (target_dcache_init_p, target_dcache_invalidate)
 744         (target_dcache_get, target_dcache_get_or_init)
 745         (_initialize_target_dcache): Update.
 746         * dcache.h (struct dcache_deleter): New.
 747
 748 2019-05-08  Tom Tromey  <tom@tromey.com>
 749
 750         * symtab.c (struct symbol_cache): Add destructor and
 751         initializers.
 752         (symbol_cache_key): Move.  Change type.
 753         (make_symbol_cache, free_symbol_cache): Remove.
 754         (get_symbol_cache): Update.
 755         (symbol_cache_cleanup): Remove.
 756         (ALL_PSPACES, symbol_cache_flush)
 757         (maintenance_print_symbol_cache)
 758         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
 759         Update.
 760
 761 2019-05-08  Tom Tromey  <tom@tromey.com>
 762
 763         * symtab.c (struct main_info): Add destructor and initializers.
 764         (main_progspace_key): Move.  Change type.
 765         (get_main_info): Update.
 766         (main_info_cleanup): Remove.
 767         (_initialize_symtab): Update.
 768
 769 2019-05-08  Tom Tromey  <tom@tromey.com>
 770
 771         * registry.h (DECLARE_REGISTRY): Define the _key class.
 772
 773 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 774
 775         * NEWS: Merge two 'New commands' sections.
 776
 777 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 778
 779         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 780         parameter and use Ada language definition instead.
 781         (ada_val_print_ptr): Remove unused language parameter.
 782         (ada_val_print_num): Remove language parameter and use Ada language
 783         definition instead.
 784         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 785         parameter.
 786         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 787         parameter and use Ada language definition instead.
 788         (ada_val_print_1): Update all ada_val_print_xxx calls.
 789         Remove language parameter.
 790         (ada_val_print): Update ada_val_print_1 call.
 791
 792 2019-05-08  Tom Tromey  <tromey@adacore.com>
 793
 794         * remote.c (remote_hw_watchpoint_limit)
 795         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 796         Now static.
 797
 798 2019-05-08  Tom Tromey  <tromey@adacore.com>
 799
 800         * maint.c (_initialize_maint_cmds): Move initialization code to
 801         remote.c.
 802         (watchdog, show_watchdog): Move to remote.c.
 803         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 804         "watchdog" static.
 805         (_initialize_remote): Move initialization code from maint.c.
 806         * defs.h (watchdog): Don't declare.
 807
 808 2019-05-08  Tom Tromey  <tromey@adacore.com>
 809
 810         * tui/tui-interp.c: Include main.h.
 811         * interps.c: Include main.h.
 812         * main.h (interpreter_p): Declare.
 813         * defs.h (interpreter_p): Don't declare.
 814
 815 2019-05-08  Tom Tromey  <tromey@adacore.com>
 816
 817         * dwarf2loc.c: Include dwarf2read.h.
 818         * defs.h (read_unsigned_leb128): Don't declare.
 819         * dwarf2read.h (read_unsigned_leb128): Declare.
 820
 821 2019-05-08  Tom Tromey  <tromey@adacore.com>
 822
 823         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 824         method.
 825
 826 2019-05-08  Tom Tromey  <tromey@adacore.com>
 827
 828         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 829         when no wrap column is set.
 830
 831 2019-05-08  Tom Tromey  <tromey@adacore.com>
 832
 833         * c-lang.c (c_get_string): Handle non-C-style arrays.
 834
 835 2019-05-08  Tom Tromey  <tromey@adacore.com>
 836
 837         * typeprint.c (print_offset_data::update): Print the bit offset,
 838         not the number of bits remaining.
 839
 840 2019-05-08  Tom Tromey  <tromey@adacore.com>
 841
 842         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 843         padding at end of comment.
 844
 845 2019-05-08  Tom Tromey  <tromey@adacore.com>
 846
 847         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 848         Compare main types.
 849
 850 2019-05-06  Tom Tromey  <tom@tromey.com>
 851
 852         * common/scoped_mmap.c: Include common-defs.h.
 853         * common/scoped_mmap.h: Don't include config.h.
 854
 855 2019-05-04  Tom Tromey  <tom@tromey.com>
 856
 857         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 858         (struct aarch64_call_info): Add initializers.
 859         <si>: Now a std::vector.
 860         (pass_on_stack, aarch64_push_dummy_call): Update.
 861
 862 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 863             Tom Tromey  <tom@tromey.com>
 864
 865         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 866         (ppc_threads): Now a std::vector.  Now static.
 867         (hwdebug_find_thread_points_by_tid)
 868         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 869         Update.
 870
 871 2019-05-04  Tom Tromey  <tom@tromey.com>
 872
 873         * arc-tdep.c (arc_tdesc_init): Return bool.
 874
 875 2019-05-04  Tom Tromey  <tom@tromey.com>
 876
 877         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 878         Use gdb_assert_not_reached.
 879
 880 2019-05-04  Tom Tromey  <tom@tromey.com>
 881
 882         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 883         "false".
 884
 885 2019-05-04  Tom Tromey  <tom@tromey.com>
 886
 887         * arc-tdep.c (arc_tdesc_init): Use bool.
 888
 889 2019-05-04  Tom Tromey  <tom@tromey.com>
 890
 891         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 892
 893 2019-05-04  Tom Tromey  <tom@tromey.com>
 894
 895         * cli/cli-cmds.c (valid_command_p): Return bool.
 896
 897 2019-05-04  Tom Tromey  <tom@tromey.com>
 898
 899         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 900         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 901
 902 2019-05-04  Raul Tambre  <raul@tambre.ee>
 903
 904         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 905         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 906         operator for comparison.
 907
 908 2019-05-04  Tom Tromey  <tom@tromey.com>
 909
 910         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 911         (lookup_partial_symbol, print_partial_symbols)
 912         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 913         (psymbol_compare): Update.
 914         (add_psymbol_to_bcache): Clear the entire psymbol.
 915         (maintenance_check_psymtabs): Update.
 916         * psympriv.h (struct partial_symbol): Don't derive from
 917         general_symbol_info.
 918         <obj_section, unrelocated_address, address,
 919         set_unrelocated_address>: Update.
 920         <ginfo>: New member.
 921         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 922         (debug_names::write_psymbols): Update.
 923
 924 2019-05-04  Tom de Vries  <tdevries@suse.de>
 925
 926         * contrib/cc-with-tweaks.sh: Support -n arg.
 927
 928 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 929
 930         * corelow.c (core_target::detach): Ensure frame cache and
 931         register caches are cleared.
 932         inferior.c (exit_inferior_1): Likewise.
 933
 934 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 935             Tom Tromey  <tom@tromey.com>
 936
 937         * dictionary.c (collate_pending_symbols_by_language): Remove
 938         "struct" from foreach.
 939         * symtab.c (lookup_global_symbol_from_objfile)
 940         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 941         foreach.
 942         * ser-tcp.c (net_open): Remove "struct" from foreach.
 943         * objfiles.c (objfile_relocate, objfile_rebase)
 944         (objfile_has_symbols): Remove "struct" from foreach.
 945         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 946         from foreach.
 947         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 948         foreach.
 949         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 950         "struct" from foreach.
 951         * ada-lang.c (create_excep_cond_exprs)
 952         (ada_exception_catchpoint_cond_string): Remove "struct" from
 953         foreach.
 954
 955 2019-05-03  Tom Tromey  <tromey@adacore.com>
 956
 957         * ada-exp.y (convert_char_literal): Check suffix of each
 958         enumerator.
 959
 960 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 961
 962         PR ada/21406:
 963         * ada-exp.y (yywrap): Don't define.
 964         * ada-lex.l (%option): Add noyywrap
 965         (yywrap): Remove.
 966
 967 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 968
 969         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 970         _WIN32_WINNT to the XP level, unless already defined to a higher
 971         level.
 972
 973         * unittests/parse-connection-spec-selftests.c:
 974         * ser-tcp.c:
 975         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 976         override.
 977
 978         * symfile.c (find_separate_debug_file): Remove colon from the
 979         drive spec of DOS/Windows file names of the target, so that the
 980         file name produced from DEBUGDIR and the target's directory will
 981         be valid on DOS/Windows systems.
 982
 983 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 984
 985         * rust-lang.c (val_print_struct): Handle printing structures
 986         containing strings.
 987
 988 2019-05-02  Tom Tromey  <tromey@adacore.com>
 989
 990         * valarith.c (_initialize_valarith): Remove.
 991
 992 2019-05-01  Tom Tromey  <tromey@adacore.com>
 993
 994         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 995         bitfields.
 996
 997 2019-05-01  Tom Tromey  <tromey@adacore.com>
 998
 999         * ada-lang.c (ada_value_assign): Correctly compute starting offset
1000         for big-endian copies.
1001
1002 2019-04-30  Ali Tamur  <tamur@google.com>
1003         * gdb/dwarf2read.c (read_3_bytes): New declaration.
1004         (read_attribute_value): Added DW_FORM_strx1-4 cases.
1005         (read_3_bytes): New function.
1006
1007 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1008
1009         * windows-nat.c (main_thread_id): Delete.
1010         (handle_output_debug_string): Replace main_thread_id by
1011         current_event.dwThreadId.
1012         (fake_create_process): Likewise.
1013         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
1014         Do not set main_thread_id.
1015         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
1016         current_event.dwThreadId.
1017         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
1018
1019 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1020
1021         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
1022         Use current_event.dwThreadId instead of main_thread_id.
1023
1024 2019-04-30  Tom Tromey  <tromey@adacore.com>
1025
1026         * ada-lang.c (ada_lookup_simple_minsyms): New function.
1027         (create_excep_cond_exprs): Iterate over program spaces.
1028         (ada_exception_catchpoint_cond_string): Examine all minimal
1029         symbols for exception types.
1030
1031 2019-04-30  Tom Tromey  <tromey@adacore.com>
1032
1033         PR c++/24470:
1034         * dwarf2read.c (process_structure_scope): Handle case where type
1035         has template parameters but no symbol was created.
1036
1037 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1038             Chris January  <chris.january@arm.com>
1039
1040         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
1041         qualifier.
1042         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
1043
1044 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1045
1046         * f-typeprint.c (f_print_type): Update rules for printing
1047         whitespace.
1048         (f_type_print_varspec_suffix): Likewise.
1049
1050 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1051             Chris January  <chris.january@arm.com>
1052
1053         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
1054         function arguments.
1055
1056 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1057
1058         * f-lang.c (build_fortran_types): Change name of void type to
1059         lower case.
1060         * f-typeprint.c (f_type_print_base): Print the name of the void
1061         type, rather than a fixed string.
1062         * f-valprint.c (f_decorations): Use lower case void string.
1063
1064 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1065             Chris January  <chris.january@arm.com>
1066
1067         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
1068         types for Fortran.
1069
1070 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1071             Chris January  <chris.january@arm.com>
1072             David Lecomber  <david.lecomber@arm.com>
1073
1074         * f-exp.y (BINOP_INTRINSIC): New token.
1075         (exp): New parser rule handling BINOP_INTRINSIC.
1076         (f77_keywords): Add new builtin procedures.
1077         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
1078         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1079         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
1080         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1081         (print_unop_subexp_f): New function.
1082         (print_binop_subexp_f): New function.
1083         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1084         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1085         (dump_subexp_body_f): Likewise.
1086         (operator_check_f): Likewise.
1087         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1088         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
1089
1090 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1091
1092         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
1093         UNOP_KIND.
1094         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
1095         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
1096         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
1097         (operator_length_f): New fuction.
1098         (print_subexp_f): New function.
1099         (op_name_f): New function.
1100         (dump_subexp_body_f): New function.
1101         (operator_check_f): New function.
1102         (exp_descriptor_f): Replace standard expression handling functions
1103         with new functions.
1104         * gdb/fortran-operator.def: New file.
1105         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
1106         * gdb/std-operator.def: Remove UNOP_KIND.
1107
1108 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1109
1110         * std-operator.def: Remove unbalanced, stray double quote
1111         character.
1112
1113 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1114             Chris January  <chris.january@arm.com>
1115             Daniel Everett  <daniel.everett@arm.com>
1116             Nick Forrington  <nick.forrington@arm.com>
1117             Richard Bunt  <richard.bunt@arm.com>
1118
1119         * cp-valprint.c (cp_print_value_fields): Allow an additional level
1120         of depth when printing anonymous structs or unions.
1121         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
1122         Don't print either the top-level value, or the children if the
1123         max-depth is exceeded.
1124         (ppscm_print_children): When printing the key of a map, allow one
1125         extra level of depth.
1126         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
1127         print either the top-level value, or the children if the max-depth
1128         is exceeded.
1129         (print_children): When printing the key of a map, allow one extra
1130         level of depth.
1131         * python/py-value.c (valpy_format_string): Add max_depth keyword.
1132         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
1133         (user_print_options): Initialise max_depth field.
1134         (val_print_scalar_or_string_type_p): New function.
1135         (val_print): Check to see if the max depth has been reached.
1136         (val_print_check_max_depth): Define new function.
1137         (show_print_max_depth): New function.
1138         (_initialize_valprint): Add 'print max-depth' option.
1139         * valprint.h (struct value_print_options) <max_depth>: New field.
1140         (val_print_check_max_depth): Declare new function.
1141         * NEWS: Document new feature.
1142
1143 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1144
1145         * ada-lang.c (ada_language_defn): Initialise new field.
1146         * c-lang.c (c_is_string_type_p): New function.
1147         (c_language_defn): Initialise new field.
1148         (cplus_language_defn): Initialise new field.
1149         (asm_language_defn): Initialise new field.
1150         (minimal_language_defn): Initialise new field.
1151         * c-lang.h (c_is_string_type_p): Declare new function.
1152         * d-lang.c (d_language_defn): Initialise new field.
1153         * f-lang.c (f_is_string_type_p): New function.
1154         (f_language_defn): Initialise new field.
1155         * go-lang.c (go_is_string_type_p): New function.
1156         (go_language_defn): Initialise new field.
1157         * language.c (default_is_string_type_p): New function.
1158         (unknown_language_defn): Initialise new field.
1159         (auto_language_defn): Initialise new field.
1160         * language.h (struct language_defn) <la_is_string_type_p>: New
1161         member variable.
1162         (default_is_string_type_p): Declare new function.
1163         * m2-lang.c (m2_language_defn): Initialise new field.
1164         * objc-lang.c (objc_language_defn): Initialise new field.
1165         * opencl-lang.c (opencl_language_defn): Initialise new field.
1166         * p-lang.c (pascal_is_string_type_p): New function.
1167         (pascal_language_defn): Initialise new field.
1168         * rust-lang.c (rust_is_string_type_p): New function.
1169         (rust_language_defn): Initialise new field.
1170
1171 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1172
1173         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
1174         New field.
1175         * ada-lang.c (ada_language_defn): Initialise new field.
1176         * c-lang.c (c_language_defn): Likewise.
1177         (cplus_language_defn): Likewise.
1178         (asm_language_defn): Likewise.
1179         (minimal_language_defn): Likewise.
1180         * d-lang.c (d_language_defn): Likewise.
1181         * f-lang.c (f_language_defn): Likewise.
1182         * go-lang.c (go_language_defn): Likewise.
1183         * language.c (unknown_language_defn): Likewise.
1184         (auto_language_defn): Likewise.
1185         * m2-lang.c (m2_language_defn): Likewise.
1186         * objc-lang.c (objc_language_defn): Likewise.
1187         * opencl-lang.c (opencl_language_defn): Likewise.
1188         * p-lang.c (pascal_language_defn): Likewise.
1189         * rust-lang.c (rust_language_defn): Likewise.
1190
1191 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1192
1193         * ada-lang.c (ada_is_character_type): Change return type to bool.
1194         (ada_is_string_type): Likewise.
1195         * ada-lang.h (ada_is_character_type): Update declaration
1196         (ada_is_string_type): Likewise.
1197
1198 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1199
1200         Support style in 'frame|thread apply'
1201
1202         * gdbcmd.h (execute_command_to_string): New term_out parameter.
1203         * record.c (record_start, record_stop): Update callers of
1204         execute_command_to_string with false.
1205         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
1206         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
1207         methods.
1208         (class string_file): New constructor with term_out parameter.
1209         Override methods term_out and can_emit_style_escape.  New member
1210         term_out.
1211         (class stdio_file): Override can_emit_style_escape.
1212         (class tee_file): Override term_out and can_emit_style_escape.
1213         * utils.h (can_emit_style_escape): Remove.
1214         * utils.c (can_emit_style_escape): Likewise.
1215         Update all callers of can_emit_style_escape (SOMESTREAM) to
1216         SOMESTREAM->can_emit_style_escape.
1217         * source-cache.c (source_cache::get_source_lines): Likewise.
1218         * stack.c (frame_apply_command_count): Call execute_command_to_string
1219         passing the term_out characteristic of the current gdb_stdout.
1220         * thread.c (thr_try_catch_cmd): Likewise.
1221         * top.c (execute_command_to_string): pass term_out parameter
1222         to construct the string_file for the command output.
1223         * ui-file.c (term_cli_styling): New function (most code moved
1224         from utils.c can_emit_style_escape).
1225         (string_file::string_file, string_file::can_emit_style_escape,
1226         stdio_file::can_emit_style_escape, tee_file::term_out,
1227         tee_file::can_emit_style_escape): New functions.
1228
1229 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1230
1231         * NEWS: Mention the new set|show may-call-functions.
1232         * infcall.c (may_call_functions_p): New variable.
1233         (show_may_call_functions_p): New function.
1234         (call_function_by_hand_dummy): Throws an error if not
1235         may-call-functions.
1236         (_initialize_infcall): Call add_setshow_boolean_cmd for
1237         may-call-functions.
1238
1239 2019-04-25  Keith Seitz  <keiths@redhat.com>
1240
1241         PR c++/24367
1242         * cp-support.c (inspect_type): Don't attempt substitutions
1243         of symbol with the same name.
1244
1245 2019-04-25  Tom Tromey  <tromey@adacore.com>
1246
1247         PR gdb/24475:
1248         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
1249         static.
1250
1251 2019-04-25  Tom Tromey  <tromey@adacore.com>
1252
1253         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
1254         rvalue reference.
1255         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
1256         (gdb_xml_parser::parse): Use std::move.
1257         * python/python-internal.h (gdbpy_convert_exception): Take a const
1258         reference.
1259         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
1260         std::move.
1261         * python/py-utils.c (gdbpy_convert_exception): Take a const
1262         reference.
1263         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1264         Use std::move.
1265         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1266         Use std::move.
1267         * mi/mi-main.c (mi_print_exception): Take a const reference.
1268         * main.c (handle_command_errors): Take a const reference.
1269         * linespec.c (parse_linespec): Use std::move.
1270         * infcall.c (run_inferior_call): Use std::move.
1271         (call_function_by_hand_dummy): Use std::move.
1272         * exec.c (try_open_exec_file): Use std::move.
1273         * exceptions.h (exception_print, exception_fprintf)
1274         (exception_print_same): Update.
1275         * exceptions.c (print_exception, exception_print)
1276         (exception_fprintf, exception_print_same): Change parameters to
1277         const reference.
1278         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
1279         * common/new-op.c: Use std::move.
1280         * common/common-exceptions.h (struct gdb_exception): Add move
1281         constructor.
1282         (struct gdb_exception_error, struct gdb_exception_quit, struct
1283         gdb_quit_bad_alloc): Change constructor to move constructor.
1284         (throw_exception): Change parameter to rvalue reference.
1285         * common/common-exceptions.c (throw_exception): Take rvalue
1286         reference.
1287         * cli/cli-interp.c (safe_execute_command): Use std::move.
1288         * breakpoint.c (insert_bp_location, location_to_sals): Use
1289         std::move.
1290
1291 2019-04-25  Tom Tromey  <tromey@adacore.com>
1292
1293         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
1294         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
1295         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
1296         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
1297         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
1298         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
1299         guile/scm-value.c: Use unpack.
1300         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
1301         gdbscm_gdb_exception.
1302         (gdbscm_throw_gdb_exception): Likewise.
1303         (struct gdbscm_gdb_exception): New.
1304         (unpack): New function.
1305         (gdbscm_wrap): Use unpack.
1306
1307 2019-04-25  Tom Tromey  <tromey@adacore.com>
1308
1309         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1310         (gdb_rl_callback_handler): Use std::move.
1311         * common/common-exceptions.h (struct gdb_exception): Add move
1312         assignment operator.
1313         (throw_exception_sjlj): Change "exception" to const reference.
1314         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
1315         (throw_exception_sjlj): Change "exception" to const reference.
1316
1317 2019-04-25  Tom Tromey  <tromey@adacore.com>
1318
1319         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
1320         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
1321         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1322         Update.
1323         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1324         Update.
1325         * mi/mi-interp.c (mi_interp::exec): Update.
1326         * linespec.c (parse_linespec): Update.
1327         * infcall.c (run_inferior_call): Update.
1328         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
1329         * guile/scm-symbol.c (gdbscm_lookup_symbol)
1330         (gdbscm_lookup_global_symbol): Update.
1331         * guile/scm-param.c (gdbscm_parameter_value): Update.
1332         * guile/scm-frame.c (gdbscm_frame_read_register)
1333         (gdbscm_frame_read_var): Update.
1334         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
1335         * exec.c (try_open_exec_file): Update.
1336         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1337         (gdb_rl_callback_handler): Update.
1338         * common/common-exceptions.h (exception_none): Don't declare.
1339         * common/common-exceptions.c (exception_none): Don't define.
1340         (struct catcher) <exception>: Update.
1341         * cli/cli-interp.c (safe_execute_command): Update.
1342         * breakpoint.c (insert_bp_location, location_to_sals): Update.
1343
1344 2019-04-25  Ali Tamur  <tamur@google.com>
1345
1346         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
1347         (read_attribute_value): Likewise.
1348         (dwarf2_read_addr_index): Update comment.
1349         (read_str_index): Add DW_FORM_strx.
1350         (dwarf2_string_attr): Likewise.
1351         (dwarf2_const_value_attr): Likewise.
1352         (dump_die_shallow): Likewise.
1353         (dwarf2_fetch_constant_bytes): Likewise.
1354         (skip_form_bytes): Likewise.
1355         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
1356
1357 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
1358
1359         PR corefiles/11608
1360         PR corefiles/18187
1361         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
1362         OFFSET.  Verify if current mapping contains an ELF header.
1363         (linux_find_memory_regions_full): Adjust call to
1364         dump_mapping_p.
1365
1366 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
1367             Kang Li <kanglictf@gmail.com>
1368
1369         PR gdb/21600
1370
1371         * dwarf2-frame.c (read_initial_length): Be consistent about using
1372         unsigned representation of length.
1373         (decode_frame_entry_1): Likewise.  Check for wraparound of
1374         end pointer as well as buffer overflow.
1375
1376 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
1377
1378         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
1379         "vq".
1380
1381 2019-04-24  Tom Tromey  <tromey@adacore.com>
1382
1383         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
1384
1385 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1386
1387         * s12z-tdep.c (s12z_unwind_pc): Delete.
1388         (s12z_unwind_sp): Delete.
1389         (s12z_gdbarch_init): Don't register deleted functions with
1390         gdbarch.
1391
1392 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1393
1394         * rl78-tdep.c (rl78_unwind_sp): Delete.
1395         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
1396
1397 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1398
1399         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
1400         (xstormy16_unwind_pc): Delete.
1401         (xstormy16_dummy_id): Delete.
1402         (xstormy16_gdbarch_init): Don't register deleted functions with
1403         gdbarch.
1404
1405 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1406
1407         * vax-tdep.c (vax_unwind_pc): Delete.
1408         (vax_gdbarch_init): Don't register deleted function with gdbarch.
1409
1410 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1411
1412         * v850-tdep.c (v850_unwind_sp): Delete.
1413         (v850_unwind_pc): Delete.
1414         (v850_dummy_id): Delete.
1415         (v850_gdbarch_init): Don't register deleted functions with
1416         gdbarch.
1417
1418 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1419
1420         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
1421         (tilegx_unwind_pc): Delete.
1422         (tilegx_unwind_dummy_id): Delete.
1423         (tilegx_gdbarch_init): Don't register deleted functions with
1424         gdbarch.
1425
1426 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1427
1428         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
1429         (tic6x_dummy_id): Delete.
1430         (tic6x_gdbarch_init): Don't register deleted functions with
1431         gdbarch.
1432
1433 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1434
1435         * sparc-tdep.c (sparc_unwind_pc): Delete.
1436         (sparc32_gdbarch_init): Don't register deleted function with
1437         gdbarch.
1438
1439 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1440
1441         * sh-tdep.c (sh_unwind_sp): Delete.
1442         (sh_unwind_pc): Delete.
1443         (sh_dummy_id): Delete.
1444         (sh_gdbarch_init): Don't register deleted functions with
1445         gdbarch.
1446
1447 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1448
1449         * score-tdep.c (score_unwind_sp): Delete.
1450         (score_unwind_pc): Delete.
1451         (score_dummy_id): Delete.
1452         (score_gdbarch_init): Don't register deleted functions with
1453         gdbarch.
1454
1455 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1456
1457         * rx-tdep.c (rx_unwind_pc): Delete.
1458         (rx_unwind_sp): Delete.
1459         (rx_dummy_id): Delete.
1460         (rx_gdbarch_init): Don't register deleted functions with
1461         gdbarch.  Update comment.
1462
1463 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1464
1465         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
1466         (rs6000_dummy_id): Delete.
1467         (rs6000_gdbarch_init): Don't register deleted functions with
1468         gdbarch.
1469
1470 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1471
1472         * or1k-tdep.c (or1k_dummy_id): Delete.
1473         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
1474
1475 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1476
1477         * nios2-tdep.c (nios2_dummy_id): Delete.
1478         (nios2_unwind_sp): Delete.
1479         (nios2_gdbarch_init): Don't register deleted functions with
1480         gdbarch.
1481
1482 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1483
1484         * nds32-tdep.c (nds32_dummy_id): Delete.
1485         (nds32_unwind_pc): Delete.
1486         (nds32_unwind_sp): Delete.
1487         (nds32_gdbarch_init): Don't register deleted functions with
1488         gdbarch.
1489
1490 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1491
1492         * msp430-tdep.c (msp430_unwind_pc): Delete.
1493         (msp430_unwind_sp): Delete.
1494         (msp430_dummy_id): Delete.
1495         (msp430_gdbarch_init): Don't register deleted functions with
1496         gdbarch.
1497
1498 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1499
1500         * moxie-tdep.c (moxie_unwind_sp): Delete.
1501         (moxie_unwind_pc): Delete.
1502         (moxie_dummy_id): Delete.
1503         (moxie_gdbarch_init): Don't register deleted functions with
1504         gdbarch.
1505
1506 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1507
1508         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1509         (mn10300_unwind_pc): Delete.
1510         (mn10300_unwind_sp): Delete.
1511         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1512         mn10300_unwind_sp.
1513         (mn10300_frame_unwind_init): Don't register deleted functions with
1514         gdbarch.
1515
1516 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1517
1518         * mep-tdep.c (mep_unwind_pc): Delete.
1519         (mep_unwind_sp): Delete.
1520         (mep_dummy_id): Delete.
1521         (mep_gdbarch_init): Don't register deleted functions with
1522         gdbarch.
1523
1524 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1525
1526         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1527         (m68hc11_unwind_sp): Delete.
1528         (m68hc11_gdbarch_init): Don't register deleted functions with
1529         gdbarch.
1530
1531 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1532
1533         * m32r-tdep.c (m32r_unwind_sp): Delete.
1534         (m32r_unwind_pc): Delete.
1535         (m32r_dummy_id): Delete.
1536         (m32r_gdbarch_init): Don't register deleted functions with
1537         gdbarch.
1538
1539 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1540
1541         * m32c-tdep.c (m32c_unwind_pc): Delete.
1542         (m32c_unwind_sp): Delete.
1543         (m32c_dummy_id): Delete.
1544         (m32c_gdbarch_init): Don't register deleted functions with
1545         gdbarch.
1546
1547 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1548
1549         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1550         (lm32_unwind_pc): Delete.
1551         (lm32_dummy_id): Delete.
1552         (lm32_gdbarch_init): Don't register deleted functions with
1553         gdbarch.
1554
1555 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1556
1557         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1558         (iq2000_unwind_pc): Delete.
1559         (iq2000_dummy_id): Delete.
1560         (iq2000_gdbarch_init): Don't register deleted functions with
1561         gdbarch.
1562
1563 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1564
1565         * nds32-tdep.c (nds32_type_align): Delete.
1566         (nds32_push_dummy_call): Use type_align instead.
1567
1568 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1569
1570         * arm-tdep.c (arm_type_align): Only handle vector override case.
1571         (arm_push_dummy_call): Use type_align.
1572         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1573
1574 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1575
1576         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1577         case.
1578         (pass_on_stack): Use type_align.
1579         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1580         function.
1581
1582 2019-04-23  Tom Tromey  <tromey@adacore.com>
1583
1584         * dwarf2read.c (line_header::file_name_at): Remove unused
1585         overload.
1586
1587 2019-04-23  Tom de Vries  <tdevries@suse.de>
1588
1589         PR gdb/24438
1590         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1591         invocation.
1592
1593
1594 2019-03-27  Ali Tamur  <tamur@google.com>
1595
1596         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1597         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1598         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1599         (dwarf_expr_context::get_addr_index): Likewise
1600         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1601         (symbol_needs_eval_context::get_addr_index): Likewise
1602         (disassemble_dwarf_expression): Add DW_OP_addrx
1603         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1604         (read_cutu_die_from_dwo): Update comment
1605         (skip_one_die): Add DW_FORM_addrx
1606         (read_attribute_value): Likewise
1607         (var_decode_location): Add DW_OP_addrx
1608         (dwarf2_const_value_attr): Add DW_FORM_addrx
1609         (dump_die_shallow): Likewise
1610         (dwarf2_fetch_constant_bytes): Likewise
1611         (decode_locdesc): Add DW_OP_addrx
1612         (skip_form_bytes): Add DW_FORM_addrx
1613
1614 2019-04-22  Ali Tamur  <tamur@google.com>
1615
1616         * MAINTAINERS (Write After Approval): Add self.
1617
1618 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1619
1620         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1621         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1622         (open_symbol_file_object): Likewise.
1623         (svr4_default_sos): Add info parameter.
1624         (svr4_read_so_list): Likewise.
1625         (svr4_current_sos_direct): Adjust functions calls to pass down
1626         info.
1627         (svr4_current_sos_1): Add info parameter.
1628         (svr4_current_sos): Call get_svr4_info, pass info down to
1629         svr4_current_sos_1.
1630         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1631         get_svr4_info.
1632         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1633         get_svr4_info.
1634         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1635         to get_svr4_info.
1636         (probes_table_remove_objfile_probes): Likewise.
1637         (register_solib_event_probe): Add info parameter.
1638         (solist_update_incremental): Pass info parameter down to
1639         svr4_read_so_list.
1640         (disable_probes_interface): Add info parameter.
1641         (svr4_handle_solib_event): Pass current_program_space to
1642         get_svr4_info.  Adjust disable_probes_interface cleanup.
1643         (svr4_create_probe_breakpoints): Add info parameter, pass it
1644         down to register_solib_event_probe.
1645         (svr4_create_solib_event_breakpoints): Add info parameter,
1646         pass it down to svr4_create_probe_breakpoints.
1647         (enable_break): Pass info down to
1648         svr4_create_solib_event_breakpoints.
1649         (svr4_solib_create_inferior_hook): Pass current_program_space to
1650         get_svr4_info.
1651         (svr4_clear_solib): Likewise.
1652
1653 2019-04-22  Pedro Alves  <palves@redhat.com>
1654
1655         * solib-svr4.c (svr4_free_objfile_observer): New.
1656         (probe_and_action::objfile): New field.
1657         (probes_table_htab_remove_objfile_probes)
1658         (probes_table_remove_objfile_probes): New functions.
1659         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1660         in the new probe_and_action.  Don't store the probe in 'lookup'.
1661         (svr4_create_probe_breakpoints): Pass objfile to
1662         register_solib_event_probe.
1663         (_initialize_svr4_solib): Register a free_objfile observer.
1664
1665 2019-04-19  Tom Tromey  <tom@tromey.com>
1666
1667         * common/queue.h: Remove.
1668
1669 2019-04-19  Tom Tromey  <tom@tromey.com>
1670
1671         * event-loop.c: Don't include "common/queue.h".
1672
1673 2019-04-19  Tom Tromey  <tom@tromey.com>
1674
1675         * remote.c (remote_target): Use delete.
1676         * remote-notif.h: Include <list>, not "common/queue.h".
1677         (notif_client_p): Remove typedef.
1678         (remote_notif_state): Add constructor, destructor, initializer.
1679         <notif_queue>: Now a std::list.
1680         (remote_notif_state_xfree): Don't declare.
1681         * remote-notif.c (remote_notif_process, handle_notification)
1682         (remote_notif_state_allocate): Update.
1683         (~remote_notif_state): Rename from remote_notif_state_xfree.
1684
1685 2019-04-19  Tom Tromey  <tom@tromey.com>
1686
1687         * symfile.c (reread_symbols): Update.
1688         * objfiles.c (objfile_register_static_link)
1689         (objfile_lookup_static_link): Update
1690         (~objfile) Don't delete static_links.
1691         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1692
1693 2019-04-19  Tom Tromey  <tom@tromey.com>
1694
1695         * type-stack.h (struct type_stack) <insert>: Constify string.
1696         * type-stack.c (type_stack::insert): Constify string.
1697         * gdbtypes.h (lookup_template_type): Update.
1698         (address_space_name_to_int): Update.
1699         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1700         const.
1701         (lookup_template_type): Make name const.
1702         * c-exp.y: Update rules.
1703         (lex_one_token, classify_name, classify_inner_name)
1704         (c_print_token): Update.
1705         * p-exp.y: Update rules.
1706         (yylex): Update.
1707         * f-exp.y: Update rules.
1708         (yylex): Update.
1709         * d-exp.y: Update rules.
1710         (lex_one_token, classify_name, classify_inner_name): Update.
1711         * parse.c (write_dollar_variable, copy_name): Return std::string.
1712         * parser-defs.h (copy_name): Change return type.
1713         * m2-exp.y: Update rules.
1714         (yylex): Update.
1715         * go-exp.y (lex_one_token): Update.
1716         Update rules.
1717         (classify_unsafe_function, classify_packaged_name)
1718         (classify_name, yylex): Update.
1719
1720 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1721
1722         * configure.ac: add --enable-source-highlight switch.
1723         * configure: Regenerate.
1724         * top.c (print_gdb_version): plumb --enable-source-highlight
1725         status to "show configuration".
1726
1727 2019-04-19  Tom Tromey  <tromey@adacore.com>
1728
1729         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1730         Check ADA_TYPE_P.
1731         (empty_record, ada_template_to_fixed_record_type_1)
1732         (template_to_static_fixed_type)
1733         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1734         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1735         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1736         macros.
1737
1738 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1739
1740         PR symtab/24423:
1741         * source.c (print_source_lines_base): Advance "iter" when a
1742         control character is seen.
1743
1744 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1745
1746         * inferior.h (struct infcall_suspend_state_deleter):
1747         Catch exception in destructor to avoid crash.
1748
1749 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1750
1751         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1752         close to the add_com "shell".
1753
1754 2019-04-18  Tom Tromey  <tromey@adacore.com>
1755
1756         * process-stratum-target.h (class process_stratum_target)
1757         <stratum>: Add "final".
1758
1759 2019-04-17  Tom Tromey  <tromey@adacore.com>
1760
1761         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1762         against nullptr before use.
1763
1764 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1765
1766         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1767
1768 2019-04-17  Jim Wilson  <jimw@sifive.com>
1769             Andrew Burgess  <andrew.burgess@embecosm.com>
1770
1771         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1772         code read might fail, assume 4-byte breakpoint in that case.
1773
1774 2019-04-15  Leszek Swirski  <leszeks@google.com>
1775
1776         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1777         rather than a hand-rolled POD check when checking for forced MEMORY
1778         classification.
1779
1780 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1781
1782         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1783         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1784         function.
1785         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1786         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1787         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1788         declaration.
1789
1790 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1791
1792         * aarch64-linux-nat.c
1793         (aarch64_linux_nat_target::thread_architecture): Add override.
1794         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1795         each VQ.
1796
1797 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1798
1799         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1800
1801 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1802
1803         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1804         target types of size 96-bits, add some additional comments, and
1805         check that the builtin type we found was the correct size.
1806
1807 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1808
1809         * utils.c (prompt_for_continue): Don't restore the styling at the
1810         end, as applied_style has the wrong value.  This fixes styling in
1811         long lists of file names that are interrupted by the "Continue?"
1812         prompt.
1813
1814 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1815
1816         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1817         * c-lang.c (c_language_defn): Likewise.
1818         (cplus_language_defn): Likewise.
1819         (asm_language_defn): Likewise.
1820         (minimal_language_defn): Likewise.
1821         * d-lang.c (d_language_defn): Likewise.
1822         * f-lang.c (f_language_defn): Likewise.
1823         * go-lang.c (go_language_defn): Likewise.
1824         * language.c (unknown_language_defn): Likewise.
1825         (auto_language_defn): Likewise.
1826         * language.h (struct language_defn): Remove la_magic field.
1827         (LANG_MAGIC): Delete.
1828         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1829         * objc-lang.c (objc_language_defn): Likewise.
1830         * opencl-lang.c (opencl_language_defn): Likewise.
1831         * p-lang.c (pascal_language_defn): Likewise.
1832         * rust-lang.c (rust_language_defn): Likewise.
1833
1834 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1835
1836         * riscv-tdep.c (riscv_type_align): New function.
1837         (riscv_type_alignment): Delete.
1838         (riscv_arg_location): Use 'type_align'.
1839         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1840
1841 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1842
1843         * gdbtypes.c (type_align): A struct with no non-static fields also
1844         has alignment of 1.
1845
1846 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1847
1848         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1849         component to 0.
1850         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1851         member.
1852         (riscv_struct_info::analyse): New implementation using new
1853         analyse_inner member function.
1854         (riscv_struct_info::field_offset): New member function.
1855         (riscv_struct_info::m_offsets): New member variable.
1856         (riscv_struct_info::analyse_inner): New private member function,
1857         takes the old implementation of riscv_struct_info::analyse but
1858         extended to track field offsets.
1859         (riscv_call_arg_struct): Update the struct folding special cases
1860         to handle cases where empty C++ structs, which are non-zero
1861         length, are found.
1862         (riscv_arg_location): Initialise the length of each location, a
1863         non-zero length now indicates the location is in use.
1864         (riscv_push_dummy_call): Allow for the first location having a
1865         non-zero offset when setting up arguments.
1866         (riscv_return_value): Likewise, but for return values.
1867
1868 2019-04-11  Tom Tromey  <tromey@adacore.com>
1869
1870         * utils.c (internal_vproblem): Make "msg" const.
1871
1872 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1873
1874         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1875         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1876         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1877         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1878
1879 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1880
1881         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1882         function.
1883         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1884         of amd64_collect_native_gregset.
1885         (amd64_linux_nat_target::store_registers): Likewise.
1886
1887 2019-04-10  Tom Tromey  <tom@tromey.com>
1888
1889         * symtab.c (lookup_global_symbol_from_objfile)
1890         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1891         * objfiles.h (class separate_debug_iterator): New.
1892         (class separate_debug_range): New.
1893         (struct objfile) <separate_debug_objfiles>: New method.
1894         (objfile_separate_debug_iterate): Don't declare.
1895         * objfiles.c (separate_debug_iterator::operator++): Rename from
1896         objfile_separate_debug_iterate.
1897         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1898         iterator.
1899         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1900         iterator.
1901
1902 2019-04-10  Tom Tromey  <tom@tromey.com>
1903
1904         * symfile.c (reread_symbols): Remove old comment.
1905         * objfiles.c (free_all_objfiles): Fix a typo.
1906
1907 2019-04-10  Tom Tromey  <tom@tromey.com>
1908
1909         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1910         * minsyms.c (lookup_minimal_symbol): Use foreach.
1911         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1912         (lookup_minimal_symbol_solib_trampoline): Likewise.
1913         * symfile.c (reread_symbols): Use foreach.
1914
1915 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1916             Tom Tromey  <tromey@adacore.com>
1917
1918         PR rust/24414:
1919         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1920         (rust_lex_int_test): Change "value" to be LONGEST.
1921         (rust_lex_tests): Add test for long integer literal.
1922
1923 2019-04-09  Tom Tromey  <tromey@adacore.com>
1924
1925         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1926         to bool.
1927         (extended_remote_target::attach): Update.
1928         (remote_target::remote_notice_new_inferior): Update.
1929         (remote_target::add_current_inferior_and_thread): Update.
1930         * inferior.c (exit_inferior_1): Use "false".
1931         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1932
1933 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1934
1935         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1936         the "start" command.
1937
1938 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1939
1940         * python/py-inferior.c (infpy_thread_from_thread_handle):
1941         Adjust comments to reflect renaming of thread_from_thread_handle
1942         to thread_from_handle.  Adjust keywords.  Fix type error message.
1943         (inferior_object_methods): Add thread_from_handle.  Retain
1944         thread_from_thread_handle, but mark it as deprecated.
1945
1946 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1947
1948         * gdbthread.h (find_thread_by_handle): Revise declaration.
1949         * thread.c (find_thread_by_handle): Likewise.  Adjust
1950         implementation too.
1951         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1952         support for buffer objects as handles.
1953
1954 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1955
1956         * python/py-infthread.c (thpy_thread_handle): New function.
1957         (thread_object_methods): Register thpy_thread_handle.
1958
1959 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1960
1961         * gdbthread.h (thread_to_thread_handle): Declare.
1962         * thread.c (gdbtypes.h): Include.
1963         (thread_to_thread_handle): New function.
1964
1965         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1966         (target_thread_info_to_thread_handle): Declare.
1967         * target.c (target_thread_info_to_thread_handle): New function.
1968         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1969         * target-delegates.c: Regenerate.
1970
1971         * linux-thread-db.c (class thread_db_target): Add method
1972         thread_info_to_thread_handle.
1973         (thread_db_target::thread_info_to_thread_handle): Define.
1974         * remote.c (class remote_target): Add new method
1975         thread_info_to_thread_handle.
1976         (remote_target::thread_info_to_thread_handle): Define.
1977
1978 2019-04-08  Pedro Alves  <palves@redhat.com>
1979
1980         * common/common-exceptions.c (throw_exception): Don't create
1981         named object to throw; throw directly.
1982         (throw_it): Likewise.  Don't initialize gdb_exception::message
1983         here, with new; pass FMT and AP to the ctor instead.
1984         * common/common-exceptions.h: Include <string>.
1985         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1986         const char *, va_list)): New ctor.  Use std::make_shared.
1987         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1988         errors)): Delete.
1989         (gdb_exception_error::gdb_exception_error(enum errors, const char
1990         *, va_list)): New.
1991         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1992         Add assertion.
1993         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1994         errors)): Delete.
1995         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1996         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1997         Add assertion.
1998
1999 2019-04-08  Tom Tromey  <tom@tromey.com>
2000
2001         * valops.c (value_rtti_indirect_type): Replace throw_exception
2002         with throw.
2003         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
2004         with throw.
2005         * thread.c (thr_try_catch_cmd): Replace throw_exception with
2006         throw.
2007         * target.c (target_translate_tls_address): Replace throw_exception
2008         with throw.
2009         * stack.c (frame_apply_command_count): Replace throw_exception
2010         with throw.
2011         * solib-spu.c (append_ocl_sos): Replace throw_exception with
2012         throw.
2013         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
2014         with throw.
2015         * rs6000-tdep.c (rs6000_frame_cache)
2016         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
2017         * remote.c: Replace throw_exception with throw.
2018         * record-full.c (record_full_message, record_full_wait_1)
2019         (record_full_restore): Replace throw_exception with throw.
2020         * record-btrace.c:
2021         (get_thread_current_frame_id, record_btrace_start_replaying)
2022         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
2023         (cmd_record_btrace_start): Replace throw_exception with throw.
2024         * parse.c (parse_exp_in_context_1): Replace throw_exception with
2025         throw.
2026         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
2027         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
2028         * linespec.c:
2029         (find_linespec_symbols): Replace throw_exception with throw.
2030         * infrun.c (displaced_step_prepare, resume): Replace
2031         throw_exception with throw.
2032         * infcmd.c (post_create_inferior): Replace throw_exception with
2033         throw.
2034         * inf-loop.c (inferior_event_handler): Replace throw_exception
2035         with throw.
2036         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
2037         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
2038         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
2039         (get_prev_frame_always, get_frame_pc_if_available)
2040         (get_frame_address_in_block_if_available, get_frame_language):
2041         Replace throw_exception with throw.
2042         * frame-unwind.c (frame_unwind_try_unwinder): Replace
2043         throw_exception with throw.
2044         * eval.c (fetch_subexp_value, evaluate_var_value)
2045         (evaluate_funcall, evaluate_subexp_standard): Replace
2046         throw_exception with throw.
2047         * dwarf2loc.c (call_site_find_chain)
2048         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
2049         Replace throw_exception with throw.
2050         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
2051         with throw.
2052         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
2053         throw.
2054         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
2055         * completer.c (complete_line_internal): Replace throw_exception
2056         with throw.
2057         * compile/compile-object-run.c (compile_object_run): Replace
2058         throw_exception with throw.
2059         * cli/cli-script.c (process_next_line): Replace throw_exception
2060         with throw.
2061         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
2062         (btrace_enable, btrace_maint_update_pt_packets): Replace
2063         throw_exception with throw.
2064         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
2065         throw_exception with throw.
2066         * break-catch-throw.c (re_set_exception_catchpoint): Replace
2067         throw_exception with throw.
2068         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
2069         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
2070         * aarch64-tdep.c (aarch64_make_prologue_cache)
2071         (aarch64_make_stub_cache): Replace throw_exception with throw.
2072
2073 2019-04-08  Tom Tromey  <tom@tromey.com>
2074
2075         * common/common-exceptions.c (throw_exception): Rename from
2076         throw_exception_cxx.  Remove old copy.  Make argument const.
2077         (throw_it): Create and throw exception objects directly.
2078         * common/common-exceptions.h (throw_exception): Make argument
2079         const.
2080         (struct gdb_exception_error): Add constructor.
2081         (struct gdb_exception_quit): Add constructor.
2082
2083 2019-04-08  Tom Tromey  <tom@tromey.com>
2084
2085         * common/common-exceptions.h (exception_rethrow): Don't declare.
2086         (TRY_SJLJ): Update comment.
2087         (TRY, CATCH, END_CATCH): Remove.
2088         * common/common-exceptions.c (exception_rethrow): Remove.
2089
2090 2019-04-08  Tom Tromey  <tom@tromey.com>
2091
2092         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
2093         Remove.
2094         (gdb_exception_error): Rename from
2095         gdb_exception_RETURN_MASK_ERROR.
2096         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
2097         (gdb_quit_bad_alloc): Update.
2098         * aarch64-tdep.c: Update.
2099         * ada-lang.c: Update.
2100         * ada-typeprint.c: Update.
2101         * ada-valprint.c: Update.
2102         * amd64-tdep.c: Update.
2103         * arch-utils.c: Update.
2104         * break-catch-throw.c: Update.
2105         * breakpoint.c: Update.
2106         * btrace.c: Update.
2107         * c-varobj.c: Update.
2108         * cli/cli-cmds.c: Update.
2109         * cli/cli-interp.c: Update.
2110         * cli/cli-script.c: Update.
2111         * common/common-exceptions.c: Update.
2112         * common/new-op.c: Update.
2113         * common/selftest.c: Update.
2114         * compile/compile-c-symbols.c: Update.
2115         * compile/compile-cplus-symbols.c: Update.
2116         * compile/compile-object-load.c: Update.
2117         * compile/compile-object-run.c: Update.
2118         * completer.c: Update.
2119         * corelow.c: Update.
2120         * cp-abi.c: Update.
2121         * cp-support.c: Update.
2122         * cp-valprint.c: Update.
2123         * darwin-nat.c: Update.
2124         * disasm-selftests.c: Update.
2125         * dtrace-probe.c: Update.
2126         * dwarf-index-cache.c: Update.
2127         * dwarf-index-write.c: Update.
2128         * dwarf2-frame-tailcall.c: Update.
2129         * dwarf2-frame.c: Update.
2130         * dwarf2loc.c: Update.
2131         * dwarf2read.c: Update.
2132         * eval.c: Update.
2133         * event-loop.c: Update.
2134         * event-top.c: Update.
2135         * exec.c: Update.
2136         * f-valprint.c: Update.
2137         * fbsd-tdep.c: Update.
2138         * frame-unwind.c: Update.
2139         * frame.c: Update.
2140         * gdbtypes.c: Update.
2141         * gnu-v3-abi.c: Update.
2142         * guile/guile-internal.h: Update.
2143         * guile/scm-block.c: Update.
2144         * guile/scm-breakpoint.c: Update.
2145         * guile/scm-cmd.c: Update.
2146         * guile/scm-disasm.c: Update.
2147         * guile/scm-frame.c: Update.
2148         * guile/scm-lazy-string.c: Update.
2149         * guile/scm-math.c: Update.
2150         * guile/scm-param.c: Update.
2151         * guile/scm-ports.c: Update.
2152         * guile/scm-pretty-print.c: Update.
2153         * guile/scm-symbol.c: Update.
2154         * guile/scm-symtab.c: Update.
2155         * guile/scm-type.c: Update.
2156         * guile/scm-value.c: Update.
2157         * i386-linux-tdep.c: Update.
2158         * i386-tdep.c: Update.
2159         * inf-loop.c: Update.
2160         * infcall.c: Update.
2161         * infcmd.c: Update.
2162         * infrun.c: Update.
2163         * jit.c: Update.
2164         * language.c: Update.
2165         * linespec.c: Update.
2166         * linux-fork.c: Update.
2167         * linux-nat.c: Update.
2168         * linux-tdep.c: Update.
2169         * linux-thread-db.c: Update.
2170         * main.c: Update.
2171         * mi/mi-cmd-break.c: Update.
2172         * mi/mi-cmd-stack.c: Update.
2173         * mi/mi-interp.c: Update.
2174         * mi/mi-main.c: Update.
2175         * objc-lang.c: Update.
2176         * p-valprint.c: Update.
2177         * parse.c: Update.
2178         * ppc-linux-tdep.c: Update.
2179         * printcmd.c: Update.
2180         * python/py-arch.c: Update.
2181         * python/py-breakpoint.c: Update.
2182         * python/py-cmd.c: Update.
2183         * python/py-finishbreakpoint.c: Update.
2184         * python/py-frame.c: Update.
2185         * python/py-framefilter.c: Update.
2186         * python/py-gdb-readline.c: Update.
2187         * python/py-inferior.c: Update.
2188         * python/py-infthread.c: Update.
2189         * python/py-lazy-string.c: Update.
2190         * python/py-linetable.c: Update.
2191         * python/py-objfile.c: Update.
2192         * python/py-param.c: Update.
2193         * python/py-prettyprint.c: Update.
2194         * python/py-progspace.c: Update.
2195         * python/py-record-btrace.c: Update.
2196         * python/py-record.c: Update.
2197         * python/py-symbol.c: Update.
2198         * python/py-type.c: Update.
2199         * python/py-unwind.c: Update.
2200         * python/py-utils.c: Update.
2201         * python/py-value.c: Update.
2202         * python/python.c: Update.
2203         * record-btrace.c: Update.
2204         * record-full.c: Update.
2205         * remote-fileio.c: Update.
2206         * remote.c: Update.
2207         * riscv-tdep.c: Update.
2208         * rs6000-aix-tdep.c: Update.
2209         * rs6000-tdep.c: Update.
2210         * rust-exp.y: Update.
2211         * rust-lang.c: Update.
2212         * s390-tdep.c: Update.
2213         * selftest-arch.c: Update.
2214         * solib-dsbt.c: Update.
2215         * solib-frv.c: Update.
2216         * solib-spu.c: Update.
2217         * solib-svr4.c: Update.
2218         * solib.c: Update.
2219         * sparc64-linux-tdep.c: Update.
2220         * stack.c: Update.
2221         * symfile-mem.c: Update.
2222         * symmisc.c: Update.
2223         * target.c: Update.
2224         * thread.c: Update.
2225         * top.c: Update.
2226         * tracefile-tfile.c: Update.
2227         * tui/tui.c: Update.
2228         * typeprint.c: Update.
2229         * unittests/cli-utils-selftests.c: Update.
2230         * unittests/parse-connection-spec-selftests.c: Update.
2231         * valops.c: Update.
2232         * valprint.c: Update.
2233         * value.c: Update.
2234         * varobj.c: Update.
2235         * windows-nat.c: Update.
2236         * x86-linux-nat.c: Update.
2237         * xml-support.c: Update.
2238
2239 2019-04-08  Tom Tromey  <tom@tromey.com>
2240
2241         * xml-support.c: Use C++ exception handling.
2242         * x86-linux-nat.c: Use C++ exception handling.
2243         * windows-nat.c: Use C++ exception handling.
2244         * varobj.c: Use C++ exception handling.
2245         * value.c: Use C++ exception handling.
2246         * valprint.c: Use C++ exception handling.
2247         * valops.c: Use C++ exception handling.
2248         * unittests/parse-connection-spec-selftests.c: Use C++ exception
2249         handling.
2250         * unittests/cli-utils-selftests.c: Use C++ exception handling.
2251         * typeprint.c: Use C++ exception handling.
2252         * tui/tui.c: Use C++ exception handling.
2253         * tracefile-tfile.c: Use C++ exception handling.
2254         * top.c: Use C++ exception handling.
2255         * thread.c: Use C++ exception handling.
2256         * target.c: Use C++ exception handling.
2257         * symmisc.c: Use C++ exception handling.
2258         * symfile-mem.c: Use C++ exception handling.
2259         * stack.c: Use C++ exception handling.
2260         * sparc64-linux-tdep.c: Use C++ exception handling.
2261         * solib.c: Use C++ exception handling.
2262         * solib-svr4.c: Use C++ exception handling.
2263         * solib-spu.c: Use C++ exception handling.
2264         * solib-frv.c: Use C++ exception handling.
2265         * solib-dsbt.c: Use C++ exception handling.
2266         * selftest-arch.c: Use C++ exception handling.
2267         * s390-tdep.c: Use C++ exception handling.
2268         * rust-lang.c: Use C++ exception handling.
2269         * rust-exp.y: Use C++ exception handling.
2270         * rs6000-tdep.c: Use C++ exception handling.
2271         * rs6000-aix-tdep.c: Use C++ exception handling.
2272         * riscv-tdep.c: Use C++ exception handling.
2273         * remote.c: Use C++ exception handling.
2274         * remote-fileio.c: Use C++ exception handling.
2275         * record-full.c: Use C++ exception handling.
2276         * record-btrace.c: Use C++ exception handling.
2277         * python/python.c: Use C++ exception handling.
2278         * python/py-value.c: Use C++ exception handling.
2279         * python/py-utils.c: Use C++ exception handling.
2280         * python/py-unwind.c: Use C++ exception handling.
2281         * python/py-type.c: Use C++ exception handling.
2282         * python/py-symbol.c: Use C++ exception handling.
2283         * python/py-record.c: Use C++ exception handling.
2284         * python/py-record-btrace.c: Use C++ exception handling.
2285         * python/py-progspace.c: Use C++ exception handling.
2286         * python/py-prettyprint.c: Use C++ exception handling.
2287         * python/py-param.c: Use C++ exception handling.
2288         * python/py-objfile.c: Use C++ exception handling.
2289         * python/py-linetable.c: Use C++ exception handling.
2290         * python/py-lazy-string.c: Use C++ exception handling.
2291         * python/py-infthread.c: Use C++ exception handling.
2292         * python/py-inferior.c: Use C++ exception handling.
2293         * python/py-gdb-readline.c: Use C++ exception handling.
2294         * python/py-framefilter.c: Use C++ exception handling.
2295         * python/py-frame.c: Use C++ exception handling.
2296         * python/py-finishbreakpoint.c: Use C++ exception handling.
2297         * python/py-cmd.c: Use C++ exception handling.
2298         * python/py-breakpoint.c: Use C++ exception handling.
2299         * python/py-arch.c: Use C++ exception handling.
2300         * printcmd.c: Use C++ exception handling.
2301         * ppc-linux-tdep.c: Use C++ exception handling.
2302         * parse.c: Use C++ exception handling.
2303         * p-valprint.c: Use C++ exception handling.
2304         * objc-lang.c: Use C++ exception handling.
2305         * mi/mi-main.c: Use C++ exception handling.
2306         * mi/mi-interp.c: Use C++ exception handling.
2307         * mi/mi-cmd-stack.c: Use C++ exception handling.
2308         * mi/mi-cmd-break.c: Use C++ exception handling.
2309         * main.c: Use C++ exception handling.
2310         * linux-thread-db.c: Use C++ exception handling.
2311         * linux-tdep.c: Use C++ exception handling.
2312         * linux-nat.c: Use C++ exception handling.
2313         * linux-fork.c: Use C++ exception handling.
2314         * linespec.c: Use C++ exception handling.
2315         * language.c: Use C++ exception handling.
2316         * jit.c: Use C++ exception handling.
2317         * infrun.c: Use C++ exception handling.
2318         * infcmd.c: Use C++ exception handling.
2319         * infcall.c: Use C++ exception handling.
2320         * inf-loop.c: Use C++ exception handling.
2321         * i386-tdep.c: Use C++ exception handling.
2322         * i386-linux-tdep.c: Use C++ exception handling.
2323         * guile/scm-value.c: Use C++ exception handling.
2324         * guile/scm-type.c: Use C++ exception handling.
2325         * guile/scm-symtab.c: Use C++ exception handling.
2326         * guile/scm-symbol.c: Use C++ exception handling.
2327         * guile/scm-pretty-print.c: Use C++ exception handling.
2328         * guile/scm-ports.c: Use C++ exception handling.
2329         * guile/scm-param.c: Use C++ exception handling.
2330         * guile/scm-math.c: Use C++ exception handling.
2331         * guile/scm-lazy-string.c: Use C++ exception handling.
2332         * guile/scm-frame.c: Use C++ exception handling.
2333         * guile/scm-disasm.c: Use C++ exception handling.
2334         * guile/scm-cmd.c: Use C++ exception handling.
2335         * guile/scm-breakpoint.c: Use C++ exception handling.
2336         * guile/scm-block.c: Use C++ exception handling.
2337         * guile/guile-internal.h: Use C++ exception handling.
2338         * gnu-v3-abi.c: Use C++ exception handling.
2339         * gdbtypes.c: Use C++ exception handling.
2340         * frame.c: Use C++ exception handling.
2341         * frame-unwind.c: Use C++ exception handling.
2342         * fbsd-tdep.c: Use C++ exception handling.
2343         * f-valprint.c: Use C++ exception handling.
2344         * exec.c: Use C++ exception handling.
2345         * event-top.c: Use C++ exception handling.
2346         * event-loop.c: Use C++ exception handling.
2347         * eval.c: Use C++ exception handling.
2348         * dwarf2read.c: Use C++ exception handling.
2349         * dwarf2loc.c: Use C++ exception handling.
2350         * dwarf2-frame.c: Use C++ exception handling.
2351         * dwarf2-frame-tailcall.c: Use C++ exception handling.
2352         * dwarf-index-write.c: Use C++ exception handling.
2353         * dwarf-index-cache.c: Use C++ exception handling.
2354         * dtrace-probe.c: Use C++ exception handling.
2355         * disasm-selftests.c: Use C++ exception handling.
2356         * darwin-nat.c: Use C++ exception handling.
2357         * cp-valprint.c: Use C++ exception handling.
2358         * cp-support.c: Use C++ exception handling.
2359         * cp-abi.c: Use C++ exception handling.
2360         * corelow.c: Use C++ exception handling.
2361         * completer.c: Use C++ exception handling.
2362         * compile/compile-object-run.c: Use C++ exception handling.
2363         * compile/compile-object-load.c: Use C++ exception handling.
2364         * compile/compile-cplus-symbols.c: Use C++ exception handling.
2365         * compile/compile-c-symbols.c: Use C++ exception handling.
2366         * common/selftest.c: Use C++ exception handling.
2367         * common/new-op.c: Use C++ exception handling.
2368         * cli/cli-script.c: Use C++ exception handling.
2369         * cli/cli-interp.c: Use C++ exception handling.
2370         * cli/cli-cmds.c: Use C++ exception handling.
2371         * c-varobj.c: Use C++ exception handling.
2372         * btrace.c: Use C++ exception handling.
2373         * breakpoint.c: Use C++ exception handling.
2374         * break-catch-throw.c: Use C++ exception handling.
2375         * arch-utils.c: Use C++ exception handling.
2376         * amd64-tdep.c: Use C++ exception handling.
2377         * ada-valprint.c: Use C++ exception handling.
2378         * ada-typeprint.c: Use C++ exception handling.
2379         * ada-lang.c: Use C++ exception handling.
2380         * aarch64-tdep.c: Use C++ exception handling.
2381
2382 2019-04-08  Tom Tromey  <tom@tromey.com>
2383
2384         * xml-support.c (gdb_xml_parser::parse): Update.
2385         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2386         * value.c (show_convenience): Update.
2387         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
2388         (test_parse_flags_qcs): Update.
2389         * thread.c (thr_try_catch_cmd): Update.
2390         * target.c (target_translate_tls_address): Update.
2391         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2392         (info_frame_command_core, frame_apply_command_count): Update.
2393         * rust-exp.y (rust_lex_exception_test): Update.
2394         * riscv-tdep.c (riscv_print_one_register_info): Update.
2395         * remote.c (remote_target::enable_btrace): Update.
2396         * record-btrace.c (record_btrace_enable_warn): Update.
2397         * python/py-utils.c (gdbpy_convert_exception): Update.
2398         * printcmd.c (do_one_display, print_variable_and_value): Update.
2399         * mi/mi-main.c (mi_print_exception): Update.
2400         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
2401         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2402         * linux-nat.c (linux_nat_target::attach): Update.
2403         * linux-fork.c (class scoped_switch_fork_info): Update.
2404         * infrun.c (displaced_step_prepare): Update.
2405         * infcall.c (call_function_by_hand_dummy): Update.
2406         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
2407         * gnu-v3-abi.c (print_one_vtable): Update.
2408         * frame.c (get_prev_frame_always): Update.
2409         * f-valprint.c (info_common_command_for_block): Update.
2410         * exec.c (try_open_exec_file): Update.
2411         * exceptions.c (print_exception, exception_print)
2412         (exception_fprintf, exception_print_same): Update.
2413         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
2414         * dwarf-index-cache.c (index_cache::store)
2415         (index_cache::lookup_gdb_index): Update.
2416         * darwin-nat.c (maybe_cache_shell): Update.
2417         * cp-valprint.c (cp_print_value_fields): Update.
2418         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
2419         (gcc_cplus_symbol_address): Update.
2420         * compile/compile-c-symbols.c (gcc_convert_symbol)
2421         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
2422         * common/selftest.c: Update.
2423         * common/common-exceptions.h (struct gdb_exception) <message>: Now
2424         a std::string.
2425         (exception_try_scope_entry, exception_try_scope_exit): Don't
2426         declare.
2427         (struct exception_try_scope): Remove.
2428         (TRY): Don't use exception_try_scope.
2429         (struct gdb_exception): Add constructor, operator=.
2430         <what>: New method.
2431         (struct gdb_exception_RETURN_MASK_ALL)
2432         (struct gdb_exception_RETURN_MASK_ERROR)
2433         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
2434         (struct gdb_quit_bad_alloc): Update.
2435         * common/common-exceptions.c (exception_none): Change
2436         initializer.
2437         (struct catcher) <state, exception>: Initialize inline.
2438         <prev>: Remove member.
2439         (current_catcher): Remove.
2440         (catchers): New global.
2441         (exceptions_state_mc_init): Simplify.
2442         (catcher_pop): Remove.
2443         (exceptions_state_mc, exceptions_state_mc_catch): Update.
2444         (try_scope_depth, exception_try_scope_entry)
2445         (exception_try_scope_exit): Remove.
2446         (throw_exception_sjlj): Update.
2447         (exception_messages, exception_messages_size): Remove.
2448         (throw_it): Simplify.
2449         (gdb_exception_sliced_copy): Remove.
2450         (throw_exception_cxx): Update.
2451         * cli/cli-script.c (script_from_file): Update.
2452         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
2453         Update.
2454         * ada-valprint.c (ada_val_print): Update.
2455         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
2456         (create_excep_cond_exprs): Update.
2457
2458 2019-04-08  Tom Tromey  <tom@tromey.com>
2459
2460         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
2461         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
2462         (TRY, CATCH, END_CATCH): Remove some definitions.
2463         * common/common-exceptions.c: Don't use GDB_XCPT.
2464         (catcher_list_size): Remove.
2465         (throw_exception, throw_it): Simplify.
2466
2467 2019-04-05  Tom Tromey  <tom@tromey.com>
2468
2469         Revert the header-sorting patch.
2470         * ft32-tdep.c: Revert.
2471         * frv-tdep.c: Revert.
2472         * frv-linux-tdep.c: Revert.
2473         * frame.c: Revert.
2474         * frame-unwind.c: Revert.
2475         * frame-base.c: Revert.
2476         * fork-child.c: Revert.
2477         * findvar.c: Revert.
2478         * findcmd.c: Revert.
2479         * filesystem.c: Revert.
2480         * filename-seen-cache.h: Revert.
2481         * filename-seen-cache.c: Revert.
2482         * fbsd-tdep.c: Revert.
2483         * fbsd-nat.h: Revert.
2484         * fbsd-nat.c: Revert.
2485         * f-valprint.c: Revert.
2486         * f-typeprint.c: Revert.
2487         * f-lang.c: Revert.
2488         * extension.h: Revert.
2489         * extension.c: Revert.
2490         * extension-priv.h: Revert.
2491         * expprint.c: Revert.
2492         * exec.h: Revert.
2493         * exec.c: Revert.
2494         * exceptions.c: Revert.
2495         * event-top.c: Revert.
2496         * event-loop.c: Revert.
2497         * eval.c: Revert.
2498         * elfread.c: Revert.
2499         * dwarf2read.h: Revert.
2500         * dwarf2read.c: Revert.
2501         * dwarf2loc.c: Revert.
2502         * dwarf2expr.h: Revert.
2503         * dwarf2expr.c: Revert.
2504         * dwarf2-frame.c: Revert.
2505         * dwarf2-frame-tailcall.c: Revert.
2506         * dwarf-index-write.h: Revert.
2507         * dwarf-index-write.c: Revert.
2508         * dwarf-index-common.c: Revert.
2509         * dwarf-index-cache.h: Revert.
2510         * dwarf-index-cache.c: Revert.
2511         * dummy-frame.c: Revert.
2512         * dtrace-probe.c: Revert.
2513         * disasm.h: Revert.
2514         * disasm.c: Revert.
2515         * disasm-selftests.c: Revert.
2516         * dictionary.c: Revert.
2517         * dicos-tdep.c: Revert.
2518         * demangle.c: Revert.
2519         * dcache.h: Revert.
2520         * dcache.c: Revert.
2521         * darwin-nat.h: Revert.
2522         * darwin-nat.c: Revert.
2523         * darwin-nat-info.c: Revert.
2524         * d-valprint.c: Revert.
2525         * d-namespace.c: Revert.
2526         * d-lang.c: Revert.
2527         * ctf.c: Revert.
2528         * csky-tdep.c: Revert.
2529         * csky-linux-tdep.c: Revert.
2530         * cris-tdep.c: Revert.
2531         * cris-linux-tdep.c: Revert.
2532         * cp-valprint.c: Revert.
2533         * cp-support.c: Revert.
2534         * cp-namespace.c: Revert.
2535         * cp-abi.c: Revert.
2536         * corelow.c: Revert.
2537         * corefile.c: Revert.
2538         * continuations.c: Revert.
2539         * completer.h: Revert.
2540         * completer.c: Revert.
2541         * complaints.c: Revert.
2542         * coffread.c: Revert.
2543         * coff-pe-read.c: Revert.
2544         * cli-out.h: Revert.
2545         * cli-out.c: Revert.
2546         * charset.c: Revert.
2547         * c-varobj.c: Revert.
2548         * c-valprint.c: Revert.
2549         * c-typeprint.c: Revert.
2550         * c-lang.c: Revert.
2551         * buildsym.c: Revert.
2552         * buildsym-legacy.c: Revert.
2553         * build-id.h: Revert.
2554         * build-id.c: Revert.
2555         * btrace.c: Revert.
2556         * bsd-uthread.c: Revert.
2557         * breakpoint.h: Revert.
2558         * breakpoint.c: Revert.
2559         * break-catch-throw.c: Revert.
2560         * break-catch-syscall.c: Revert.
2561         * break-catch-sig.c: Revert.
2562         * blockframe.c: Revert.
2563         * block.c: Revert.
2564         * bfin-tdep.c: Revert.
2565         * bfin-linux-tdep.c: Revert.
2566         * bfd-target.c: Revert.
2567         * bcache.c: Revert.
2568         * ax-general.c: Revert.
2569         * ax-gdb.h: Revert.
2570         * ax-gdb.c: Revert.
2571         * avr-tdep.c: Revert.
2572         * auxv.c: Revert.
2573         * auto-load.c: Revert.
2574         * arm-wince-tdep.c: Revert.
2575         * arm-tdep.c: Revert.
2576         * arm-symbian-tdep.c: Revert.
2577         * arm-pikeos-tdep.c: Revert.
2578         * arm-obsd-tdep.c: Revert.
2579         * arm-nbsd-tdep.c: Revert.
2580         * arm-nbsd-nat.c: Revert.
2581         * arm-linux-tdep.c: Revert.
2582         * arm-linux-nat.c: Revert.
2583         * arm-fbsd-tdep.c: Revert.
2584         * arm-fbsd-nat.c: Revert.
2585         * arm-bsd-tdep.c: Revert.
2586         * arch-utils.c: Revert.
2587         * arc-tdep.c: Revert.
2588         * arc-newlib-tdep.c: Revert.
2589         * annotate.h: Revert.
2590         * annotate.c: Revert.
2591         * amd64-windows-tdep.c: Revert.
2592         * amd64-windows-nat.c: Revert.
2593         * amd64-tdep.c: Revert.
2594         * amd64-sol2-tdep.c: Revert.
2595         * amd64-obsd-tdep.c: Revert.
2596         * amd64-obsd-nat.c: Revert.
2597         * amd64-nbsd-tdep.c: Revert.
2598         * amd64-nbsd-nat.c: Revert.
2599         * amd64-nat.c: Revert.
2600         * amd64-linux-tdep.c: Revert.
2601         * amd64-linux-nat.c: Revert.
2602         * amd64-fbsd-tdep.c: Revert.
2603         * amd64-fbsd-nat.c: Revert.
2604         * amd64-dicos-tdep.c: Revert.
2605         * amd64-darwin-tdep.c: Revert.
2606         * amd64-bsd-nat.c: Revert.
2607         * alpha-tdep.c: Revert.
2608         * alpha-obsd-tdep.c: Revert.
2609         * alpha-nbsd-tdep.c: Revert.
2610         * alpha-mdebug-tdep.c: Revert.
2611         * alpha-linux-tdep.c: Revert.
2612         * alpha-linux-nat.c: Revert.
2613         * alpha-bsd-tdep.c: Revert.
2614         * alpha-bsd-nat.c: Revert.
2615         * aix-thread.c: Revert.
2616         * agent.c: Revert.
2617         * addrmap.c: Revert.
2618         * ada-varobj.c: Revert.
2619         * ada-valprint.c: Revert.
2620         * ada-typeprint.c: Revert.
2621         * ada-tasks.c: Revert.
2622         * ada-lang.c: Revert.
2623         * aarch64-tdep.c: Revert.
2624         * aarch64-ravenscar-thread.c: Revert.
2625         * aarch64-newlib-tdep.c: Revert.
2626         * aarch64-linux-tdep.c: Revert.
2627         * aarch64-linux-nat.c: Revert.
2628         * aarch64-fbsd-tdep.c: Revert.
2629         * aarch64-fbsd-nat.c: Revert.
2630         * aarch32-linux-nat.c: Revert.
2631
2632 2019-04-05  Tom Tromey  <tom@tromey.com>
2633
2634         * ft32-tdep.c: Sort headers.
2635         * frv-tdep.c: Sort headers.
2636         * frv-linux-tdep.c: Sort headers.
2637         * frame.c: Sort headers.
2638         * frame-unwind.c: Sort headers.
2639         * frame-base.c: Sort headers.
2640         * fork-child.c: Sort headers.
2641         * findvar.c: Sort headers.
2642         * findcmd.c: Sort headers.
2643         * filesystem.c: Sort headers.
2644         * filename-seen-cache.h: Sort headers.
2645         * filename-seen-cache.c: Sort headers.
2646         * fbsd-tdep.c: Sort headers.
2647         * fbsd-nat.h: Sort headers.
2648         * fbsd-nat.c: Sort headers.
2649         * f-valprint.c: Sort headers.
2650         * f-typeprint.c: Sort headers.
2651         * f-lang.c: Sort headers.
2652         * extension.h: Sort headers.
2653         * extension.c: Sort headers.
2654         * extension-priv.h: Sort headers.
2655         * expprint.c: Sort headers.
2656         * exec.h: Sort headers.
2657         * exec.c: Sort headers.
2658         * exceptions.c: Sort headers.
2659         * event-top.c: Sort headers.
2660         * event-loop.c: Sort headers.
2661         * eval.c: Sort headers.
2662         * elfread.c: Sort headers.
2663         * dwarf2read.h: Sort headers.
2664         * dwarf2read.c: Sort headers.
2665         * dwarf2loc.c: Sort headers.
2666         * dwarf2expr.h: Sort headers.
2667         * dwarf2expr.c: Sort headers.
2668         * dwarf2-frame.c: Sort headers.
2669         * dwarf2-frame-tailcall.c: Sort headers.
2670         * dwarf-index-write.h: Sort headers.
2671         * dwarf-index-write.c: Sort headers.
2672         * dwarf-index-common.c: Sort headers.
2673         * dwarf-index-cache.h: Sort headers.
2674         * dwarf-index-cache.c: Sort headers.
2675         * dummy-frame.c: Sort headers.
2676         * dtrace-probe.c: Sort headers.
2677         * disasm.h: Sort headers.
2678         * disasm.c: Sort headers.
2679         * disasm-selftests.c: Sort headers.
2680         * dictionary.c: Sort headers.
2681         * dicos-tdep.c: Sort headers.
2682         * demangle.c: Sort headers.
2683         * dcache.h: Sort headers.
2684         * dcache.c: Sort headers.
2685         * darwin-nat.h: Sort headers.
2686         * darwin-nat.c: Sort headers.
2687         * darwin-nat-info.c: Sort headers.
2688         * d-valprint.c: Sort headers.
2689         * d-namespace.c: Sort headers.
2690         * d-lang.c: Sort headers.
2691         * ctf.c: Sort headers.
2692         * csky-tdep.c: Sort headers.
2693         * csky-linux-tdep.c: Sort headers.
2694         * cris-tdep.c: Sort headers.
2695         * cris-linux-tdep.c: Sort headers.
2696         * cp-valprint.c: Sort headers.
2697         * cp-support.c: Sort headers.
2698         * cp-namespace.c: Sort headers.
2699         * cp-abi.c: Sort headers.
2700         * corelow.c: Sort headers.
2701         * corefile.c: Sort headers.
2702         * continuations.c: Sort headers.
2703         * completer.h: Sort headers.
2704         * completer.c: Sort headers.
2705         * complaints.c: Sort headers.
2706         * coffread.c: Sort headers.
2707         * coff-pe-read.c: Sort headers.
2708         * cli-out.h: Sort headers.
2709         * cli-out.c: Sort headers.
2710         * charset.c: Sort headers.
2711         * c-varobj.c: Sort headers.
2712         * c-valprint.c: Sort headers.
2713         * c-typeprint.c: Sort headers.
2714         * c-lang.c: Sort headers.
2715         * buildsym.c: Sort headers.
2716         * buildsym-legacy.c: Sort headers.
2717         * build-id.h: Sort headers.
2718         * build-id.c: Sort headers.
2719         * btrace.c: Sort headers.
2720         * bsd-uthread.c: Sort headers.
2721         * breakpoint.h: Sort headers.
2722         * breakpoint.c: Sort headers.
2723         * break-catch-throw.c: Sort headers.
2724         * break-catch-syscall.c: Sort headers.
2725         * break-catch-sig.c: Sort headers.
2726         * blockframe.c: Sort headers.
2727         * block.c: Sort headers.
2728         * bfin-tdep.c: Sort headers.
2729         * bfin-linux-tdep.c: Sort headers.
2730         * bfd-target.c: Sort headers.
2731         * bcache.c: Sort headers.
2732         * ax-general.c: Sort headers.
2733         * ax-gdb.h: Sort headers.
2734         * ax-gdb.c: Sort headers.
2735         * avr-tdep.c: Sort headers.
2736         * auxv.c: Sort headers.
2737         * auto-load.c: Sort headers.
2738         * arm-wince-tdep.c: Sort headers.
2739         * arm-tdep.c: Sort headers.
2740         * arm-symbian-tdep.c: Sort headers.
2741         * arm-pikeos-tdep.c: Sort headers.
2742         * arm-obsd-tdep.c: Sort headers.
2743         * arm-nbsd-tdep.c: Sort headers.
2744         * arm-nbsd-nat.c: Sort headers.
2745         * arm-linux-tdep.c: Sort headers.
2746         * arm-linux-nat.c: Sort headers.
2747         * arm-fbsd-tdep.c: Sort headers.
2748         * arm-fbsd-nat.c: Sort headers.
2749         * arm-bsd-tdep.c: Sort headers.
2750         * arch-utils.c: Sort headers.
2751         * arc-tdep.c: Sort headers.
2752         * arc-newlib-tdep.c: Sort headers.
2753         * annotate.h: Sort headers.
2754         * annotate.c: Sort headers.
2755         * amd64-windows-tdep.c: Sort headers.
2756         * amd64-windows-nat.c: Sort headers.
2757         * amd64-tdep.c: Sort headers.
2758         * amd64-sol2-tdep.c: Sort headers.
2759         * amd64-obsd-tdep.c: Sort headers.
2760         * amd64-obsd-nat.c: Sort headers.
2761         * amd64-nbsd-tdep.c: Sort headers.
2762         * amd64-nbsd-nat.c: Sort headers.
2763         * amd64-nat.c: Sort headers.
2764         * amd64-linux-tdep.c: Sort headers.
2765         * amd64-linux-nat.c: Sort headers.
2766         * amd64-fbsd-tdep.c: Sort headers.
2767         * amd64-fbsd-nat.c: Sort headers.
2768         * amd64-dicos-tdep.c: Sort headers.
2769         * amd64-darwin-tdep.c: Sort headers.
2770         * amd64-bsd-nat.c: Sort headers.
2771         * alpha-tdep.c: Sort headers.
2772         * alpha-obsd-tdep.c: Sort headers.
2773         * alpha-nbsd-tdep.c: Sort headers.
2774         * alpha-mdebug-tdep.c: Sort headers.
2775         * alpha-linux-tdep.c: Sort headers.
2776         * alpha-linux-nat.c: Sort headers.
2777         * alpha-bsd-tdep.c: Sort headers.
2778         * alpha-bsd-nat.c: Sort headers.
2779         * aix-thread.c: Sort headers.
2780         * agent.c: Sort headers.
2781         * addrmap.c: Sort headers.
2782         * ada-varobj.c: Sort headers.
2783         * ada-valprint.c: Sort headers.
2784         * ada-typeprint.c: Sort headers.
2785         * ada-tasks.c: Sort headers.
2786         * ada-lang.c: Sort headers.
2787         * aarch64-tdep.c: Sort headers.
2788         * aarch64-ravenscar-thread.c: Sort headers.
2789         * aarch64-newlib-tdep.c: Sort headers.
2790         * aarch64-linux-tdep.c: Sort headers.
2791         * aarch64-linux-nat.c: Sort headers.
2792         * aarch64-fbsd-tdep.c: Sort headers.
2793         * aarch64-fbsd-nat.c: Sort headers.
2794         * aarch32-linux-nat.c: Sort headers.
2795
2796 2019-04-04  Tom Tromey  <tom@tromey.com>
2797
2798         * varobj.c (varobj_create): Update.
2799         * rust-exp.y (struct rust_parser) <update_innermost_block,
2800         lookup_symbol>: New methods.
2801         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2802         Rename.
2803         (rust_parser::rust_lookup_type)
2804         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2805         * printcmd.c (display_command, do_one_display): Update.
2806         * parser-defs.h (struct parser_state) <parser_state>: Add
2807         "tracker" parameter.
2808         (block_tracker): New member.
2809         (class innermost_block_tracker) <innermost_block_tracker>: Add
2810         "types" parameter.
2811         <reset>: Remove method.
2812         (innermost_block): Don't declare.
2813         (null_post_parser): Update.
2814         * parse.c (innermost_block): Remove global.
2815         (write_dollar_variable): Update.
2816         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2817         Remove "tracker_types" parameter.
2818         (parse_expression): Add "tracker" parameter.
2819         (parse_expression_for_completion): Update.
2820         (null_post_parser): Add "tracker" parameter.
2821         * p-exp.y: Update rules.
2822         * m2-exp.y: Update rules.
2823         * language.h (struct language_defn) <la_post_parser>: Add
2824         "tracker" parameter.
2825         * go-exp.y: Update rules.
2826         * f-exp.y: Update rules.
2827         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2828         parameter.
2829         * d-exp.y: Update rules.
2830         * c-exp.y: Update rules.
2831         * breakpoint.c (set_breakpoint_condition): Create an
2832         innermost_block_tracker.
2833         (watch_command_1): Likewise.
2834         * ada-lang.c (resolve): Add "tracker" parameter.
2835         (resolve_subexp): Likewise.
2836         * ada-exp.y (write_var_from_sym): Update.
2837
2838 2019-04-04  Tom Tromey  <tom@tromey.com>
2839
2840         * type-stack.h: New file.
2841         * type-stack.c: New file.
2842         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2843         type-stack.h.
2844         (insert_into_type_stack, insert_type, push_type, push_type_int)
2845         (insert_type_address_space, pop_type, pop_type_int)
2846         (pop_typelist, pop_type_stack, append_type_stack)
2847         (push_type_stack, get_type_stack, push_typelist)
2848         (follow_type_instance_flags, follow_types): Don't declare.
2849         * parse.c (type_stack): Remove global.
2850         (parse_exp_in_context): Update.
2851         (insert_into_type_stack, insert_type, push_type, push_type_int)
2852         (insert_type_address_space, pop_type, pop_type_int)
2853         (pop_typelist, pop_type_stack, append_type_stack)
2854         (push_type_stack, get_type_stack, push_typelist)
2855         (follow_type_instance_flags, follow_types): Remove (moved to
2856         type-stack.c).
2857         * f-exp.y (type_stack): New global.
2858         Update rules.
2859         (push_kind_type, f_parse): Update.
2860         * d-exp.y (type_stack): New global.
2861         Update rules.
2862         (d_parse): Update.
2863         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2864         Update rules.
2865         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2866         (HFILES_NO_SRCDIR): Add type-stack.h.
2867
2868 2019-04-04  Tom Tromey  <tom@tromey.com>
2869
2870         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2871         (rust_parser::convert_ast_to_expression, rust_parse)
2872         (rust_lex_test_completion, rust_lex_tests): Update.
2873         * parser-defs.h (struct expr_completion_state): New.
2874         (struct parser_state) <parser_state>: Add completion parameter.
2875         <mark_struct_expression, mark_completion_tag>: New methods.
2876         <parse_completion, m_completion_state>: New members.
2877         (prefixify_expression, null_post_parser): Update.
2878         (mark_struct_expression, mark_completion_tag): Don't declare.
2879         * parse.c (parse_completion, expout_last_struct)
2880         (expout_tag_completion_type, expout_completion_name): Remove
2881         globals.
2882         (parser_state::mark_struct_expression)
2883         (parser_state::mark_completion_tag): Now methods.
2884         (prefixify_expression): Add last_struct parameter.
2885         (prefixify_subexp): Likewise.
2886         (parse_exp_1): Update.
2887         (parse_exp_in_context): Add cstate parameter.  Update.
2888         (parse_expression_for_completion): Create an
2889         expr_completion_state.
2890         (null_post_parser): Add "completion" parameter.
2891         * p-exp.y: Update rules.
2892         (yylex): Update.
2893         * language.h (struct language_defn) <la_post_parser>: Add
2894         "completing" parameter.
2895         * go-exp.y: Update rules.
2896         (lex_one_token): Update.
2897         * expression.h (parse_completion): Don't declare.
2898         * d-exp.y: Update rules.
2899         (lex_one_token): Update rules.
2900         * c-exp.y: Update rules.
2901         (lex_one_token): Update.
2902         * ada-lang.c (resolve): Add "parse_completion" parameter.
2903         (resolve_subexp): Likewise.
2904         (ada_resolve_function): Likewise.
2905
2906 2019-04-04  Tom Tromey  <tom@tromey.com>
2907
2908         * parser-defs.h (struct parser_state) <start_arglist,
2909         end_arglist>: New methods.
2910         <arglist_len, m_funcall_chain>: New members.
2911         (arglist_len, start_arglist, end_arglist): Don't declare.
2912         * parse.c (arglist_len, funcall_chain): Remove global.
2913         (start_arglist, end_arglist): Remove functions.
2914         (parse_exp_in_context): Update.
2915         * p-exp.y: Update rules.
2916         * m2-exp.y: Update rules.
2917         * go-exp.y: Update rules.
2918         * f-exp.y: Update rules.
2919         * d-exp.y: Update rules.
2920         * c-exp.y: Update rules.
2921
2922 2019-04-04  Tom Tromey  <tom@tromey.com>
2923
2924         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2925         lex_operator, push_back>: New methods.
2926         Update all rules.
2927         (rust_parser::lex_hex, lex_escape): Rename and update.
2928         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2929         (rust_parser::lex_operator): Rename and update.
2930         (rust_parser::lex_number, rustyylex, rustyyerror)
2931         (rust_lex_test_init, rust_lex_test_sequence)
2932         (rust_lex_test_push_back, rust_lex_tests): Update.
2933         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2934         parameter.
2935         <lexptr, prev_lexptr>: New members.
2936         (lexptr, prev_lexptr): Don't declare.
2937         * parse.c (lexptr, prev_lexptr): Remove globals.
2938         (parse_exp_in_context): Update.
2939         * p-exp.y (yylex, yyerror): Update.
2940         * m2-exp.y (parse_number, yylex, yyerror): Update.
2941         * go-exp.y (lex_one_token, yyerror): Update.
2942         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2943         * d-exp.y (lex_one_token, yyerror): Update.
2944         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2945         (lex_one_token, yyerror): Update.
2946         * ada-lex.l (YY_INPUT): Update.
2947         (rewind_to_char): Update.
2948         * ada-exp.y (yyerror): Update.
2949
2950 2019-04-04  Tom Tromey  <tom@tromey.com>
2951
2952         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2953         * parser-defs.h (struct parser_state) <parser_state>: Add new
2954         parameter.
2955         <comma_terminates>: New member.
2956         (comma_terminates): Don't declare global.
2957         * parse.c (comma_terminates): Remove global.
2958         (parse_exp_in_context): Update.
2959         * p-exp.y (yylex): Update.
2960         * m2-exp.y (yylex): Update.
2961         * go-exp.y (lex_one_token): Update.
2962         * f-exp.y (yylex): Update.
2963         * d-exp.y (lex_one_token): Update.
2964         * c-exp.y (lex_one_token): Update.
2965         * ada-lex.l: Update.
2966
2967 2019-04-04  Tom Tromey  <tom@tromey.com>
2968
2969         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2970         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2971         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2972         * parser-defs.h (paren_depth): Don't declare.
2973         * parse.c (paren_depth): Remove global.
2974         (parse_exp_in_context): Update.
2975         * p-exp.y (paren_depth): New global.
2976         (pascal_parse): Initialize it.
2977         * m2-exp.y (paren_depth): New global.
2978         (m2_parse): Initialize it.
2979         * go-exp.y (paren_depth): New global.
2980         (go_parse): Initialize it.
2981         * f-exp.y (paren_depth): New global.
2982         (f_parse): Initialize it.
2983         * d-exp.y (paren_depth): New global.
2984         (d_parse): Initialize it.
2985         * c-exp.y (paren_depth): New global.
2986         (c_parse): Initialize it.
2987         * ada-lex.l (paren_depth): New global.
2988         (lexer_init): Initialize it.
2989
2990 2019-04-04  Tom Tromey  <tom@tromey.com>
2991
2992         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2993         (rust_parser::convert_ast_to_type)
2994         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2995         * parser-defs.h (struct parser_state) <parser_state>: Add
2996         parameters.  Initialize new members.
2997         <expression_context_block, expression_context_pc>: New members.
2998         * parse.c (expression_context_block, expression_context_pc):
2999         Remove globals.
3000         (parse_exp_in_context): Update.
3001         * p-exp.y: Update all rules.
3002         (yylex): Update.
3003         * m2-exp.y: Update all rules.
3004         (yylex): Update.
3005         * go-exp.y (yylex): Update.
3006         * f-exp.y (yylex): Update.
3007         * d-exp.y: Update all rules.
3008         (yylex): Update.
3009         * c-exp.y: Update all rules.
3010         (lex_one_token, classify_name, yylex, c_parse): Update.
3011         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
3012
3013 2019-04-04  Tom Tromey  <tom@tromey.com>
3014
3015         * gdbarch.h, gdbarch.c: Rebuild.
3016         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
3017         * stap-probe.h:
3018         (struct stap_parse_info): Replace "parser_state" with
3019         "expr_builder".
3020         * parser-defs.h (struct expr_builder): Rename from "parser_state".
3021         (parser_state): New class.
3022         * parse.c (expr_builder): Rename.
3023         (expr_builder::release): Rename.
3024         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
3025         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
3026         (write_exp_elt_longcst, write_exp_elt_floatcst)
3027         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
3028         (write_exp_string_vector, write_exp_bitstring)
3029         (write_exp_msymbol, mark_struct_expression)
3030         (write_dollar_variable)
3031         (insert_type_address_space, increase_expout_size): Replace
3032         "parser_state" with "expr_builder".
3033         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
3034         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
3035         "parser_state" with "expr_builder".
3036
3037 2019-04-04  Tom Tromey  <tom@tromey.com>
3038
3039         * rust-exp.y: Replace "parse_language" with method call.
3040         * p-exp.y:
3041         (yylex): Replace "parse_language" with method call.
3042         * m2-exp.y:
3043         (yylex): Replace "parse_language" with method call.
3044         * go-exp.y (classify_name): Replace "parse_language" with method
3045         call.
3046         * f-exp.y (yylex): Replace "parse_language" with method call.
3047         * d-exp.y (lex_one_token): Replace "parse_language" with method
3048         call.
3049         * c-exp.y:
3050         (lex_one_token, classify_name, yylex): Replace "parse_language"
3051         with method call.
3052         * ada-exp.y (find_primitive_type, type_char)
3053         (type_system_address): Replace "parse_language" with method call.
3054
3055 2019-04-04  Tom Tromey  <tom@tromey.com>
3056
3057         * rust-exp.y: Replace "parse_gdbarch" with method call.
3058         * parse.c (write_dollar_variable, insert_type_address_space):
3059         Replace "parse_gdbarch" with method call.
3060         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
3061         call.
3062         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
3063         call.
3064         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
3065         "parse_gdbarch" with method call.
3066         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
3067         with method call.
3068         * f-exp.y (parse_type, parse_f_type, yylex): Replace
3069         "parse_gdbarch" with method call.
3070         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
3071         "parse_gdbarch" with method call.
3072         * c-exp.y (parse_type, parse_number, classify_name): Replace
3073         "parse_gdbarch" with method call.
3074         * ada-lex.l: Replace "parse_gdbarch" with method call.
3075         * ada-exp.y (parse_type, find_primitive_type, type_char)
3076         (type_system_address): Replace "parse_gdbarch" with method call.
3077
3078 2019-04-04  Tom Tromey  <tom@tromey.com>
3079
3080         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
3081         * stap-probe.c (stap_parse_argument): Update.
3082         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
3083         initial_size parameter.
3084         * rust-exp.y (rust_lex_tests): Update.
3085         * parse.c (parser_state): Update.
3086         (parse_exp_in_context): Update.
3087         * parser-defs.h (struct parser_state) <parser_state>: Remove
3088         "initial_size" parameter.
3089
3090 2019-04-04  Tom Tromey  <tom@tromey.com>
3091
3092         * parser-defs.h (increase_expout_size): Don't declare.
3093         * parse.c (increase_expout_size): Now static.
3094
3095 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
3096
3097         * gnu-nat.c (gnu_nat_target::wait): Fix
3098         target_waitstatus_to_string call.
3099
3100 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3101
3102         * eval.c (evaluate_subexp_standard): Handle internal functions
3103         during Fortran function call handling.
3104
3105 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3106
3107         * NEWS: Mention new internal functions.
3108         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
3109         (read_base_type): Use dwarf2_init_complex_target_type.
3110         * value.c (creal_internal_fn): New function.
3111         (cimag_internal_fn): New function.
3112         (_initialize_values): Register new internal functions.
3113
3114 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3115
3116         * infrun.c (stop_all_threads): If debug_infrun, always
3117         trace the wait status after wait_one, using
3118         target_waitstatus_to_string and target_pid_to_str.
3119         (handle_inferior_event): Replace various trace of
3120         wait status kind by a single trace.
3121         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
3122         wait status kind image by target_waitstatus_to_string.
3123         * target/waitstatus.c (target_waitstatus_to_string): Fix
3124         obsolete comment.
3125
3126 2019-04-01  Tom Tromey  <tromey@adacore.com>
3127
3128         PR symtab/23331:
3129         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
3130
3131 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
3132             Pedro Alves  <palves@redhat.com>
3133
3134         * top.c (quit_force): Call 'finalize_values'.
3135         * value.c (finalize_values): New function.
3136         * value.h (finalize_values): Declare.
3137
3138 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
3139
3140         * NEWS: Announce $_gdb_major and $_gdb_minor.
3141
3142         * top.c (init_gdb_version_vars): New function.
3143         (gdb_init): Call init_gdb_version_vars.
3144
3145 2019-03-29  Tom Tromey  <tromey@adacore.com>
3146
3147         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
3148         help text.  Remove dead code.
3149
3150 2019-03-29  Keith Seitz  <keiths@redhat.com>
3151
3152         From Siddhesh Poyarekar:
3153         * f-lang.h (f77_get_upperbound): Return LONGEST.
3154         (f77_get_lowerbound): Likewise.
3155         * f-typeprint.c (f_type_print_varspec_suffix): Expand
3156         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
3157         print them.
3158         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
3159         plongest to format print it.
3160         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
3161         (f77_get_upperbound): Likewise.
3162         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
3163         LOWER_BOUND to LONGEST.
3164         (f77_create_arrayprint_offset_tbl): Likewise.
3165
3166 2019-03-29  Keith Seitz  <keiths@redhat.com>
3167
3168         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
3169         %s/pulongest for TYPE_LENGTH instead of %d in format
3170         strings.
3171         * ada-typerint.c (ada_print_type): Likewise.
3172         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
3173         * compile/compile-c-support.c (generate_register_struct): Likewise.
3174         * gdbtypes.c (recursive_dump_type): Likewise.
3175         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
3176         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
3177         instead of %d in format strings.
3178         * riscv-tdep.c (riscv_type_alignment): Cast second argument
3179         to std::min to ULONGEST.
3180         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
3181         instead of %d in format strings.
3182         * tracepoint.c (info_scope_command): Likewise.
3183         * typeprint.c (print_offset_data::update)
3184         (print_offset_data::finish): Likewise.
3185         * xtensa-tdep.c (xtensa_store_return_value)
3186         (xtensa_push_dummy_call): Likewise.
3187
3188 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
3189
3190         * windows-nat.c (display_selector): Fixed format specifications
3191         for 64-bit Cygwin.
3192
3193 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3194
3195         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
3196
3197 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
3198
3199         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
3200         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
3201         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
3202         (nios2_linux_init_abi): Install it.
3203
3204 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3205
3206         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
3207
3208 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3209
3210         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
3211
3212 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3213             Tom Tromey  <tromey@adacore.com>
3214
3215         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
3216
3217 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
3218
3219         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
3220         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
3221         method to compute the bounds of range types. Also print "[evaluated]"
3222         if the bounds' values come from a dynamic evaluation.
3223
3224 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3225
3226         * cp-valprint.c (cp_print_value_fields): Don't print trailing
3227         whitespace when pretty printing is on.
3228
3229 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3230
3231         * ppc-linux-nat.c: Add include.
3232
3233 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3234
3235         * NEWS: Mention AArch64 Pointer Authentication.
3236
3237 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3238
3239         * arm-linux-nat.c: Add include.
3240
3241 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
3242
3243         * source-cache.c (source_cache::get_source_lines): Re-read
3244         fullname after calling open_source_file.
3245
3246 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
3247
3248         * NEWS: Mention TLS support for FreeBSD.
3249
3250 2019-03-25  Tom Tromey  <tromey@adacore.com>
3251
3252         * minsyms.c (BUNCH_SIZE): Update comment.
3253         (~minimal_symbol_reader): Remove old comment.
3254         (compact_minimal_symbols): Update comment.
3255         (minimal_symbol_reader::install): Remove old comment.  Update
3256         other comments.
3257
3258 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3259
3260         * s390-linux-nat.c: Add include.
3261
3262 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3263
3264         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3265         Call linux_get_hwcap.
3266         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3267         Likewise.
3268         (aarch64_linux_get_hwcap): Remove function.
3269         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
3270         declaration.
3271         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
3272         linux_get_hwcap.
3273         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3274         * linux-tdep.c (linux_get_hwcap): Add function.
3275         (linux_get_hwcap2): Likewise.
3276         * linux-tdep.h (linux_get_hwcap): Add declaration.
3277         (linux_get_hwcap2): Likewise.
3278         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
3279         (ppc_linux_get_hwcap2): Likewise.
3280         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
3281         linux_get_hwcap.
3282         (ppc_linux_nat_target::insert_watchpoint): Likewise.
3283         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
3284         (ppc_linux_nat_target::read_description): Likewise.
3285         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
3286         * s390-linux-nat.c: Likewise.
3287         * s390-linux-tdep.c (s390_core_read_description): Likewise.
3288
3289 2019-03-24  Tom Tromey  <tom@tromey.com>
3290
3291         * ada-lang.c (standard_lookup): Simplify initialization.
3292         (ada_lookup_symbol_nonlocal): Simplify return.
3293         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
3294         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
3295         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
3296         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
3297         initialization.
3298         * solib.c (solib_global_lookup): Simplify.
3299         * symtab.c (null_block_symbol): Remove.
3300         (symbol_cache_lookup): Simplify returns.
3301         (lookup_language_this): Simplify returns.
3302         (lookup_symbol_aux): Simplify return.
3303         (lookup_local_symbol): Simplify returns.
3304         (lookup_global_symbol_from_objfile): Simplify return.
3305         (lookup_symbol_in_objfile_symtabs)
3306         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
3307         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
3308         (lookup_static_symbol, lookup_global_symbol): Simplify return.
3309         * cp-namespace.c (cp_lookup_bare_symbol)
3310         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
3311         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
3312         (cp_lookup_nested_symbol): Don't use null_block_symbol.
3313         (cp_lookup_symbol_via_imports): Simplify initialization.
3314         (find_symbol_in_baseclass): Likewise.
3315         * symtab.h (null_block_symbol): Remove.
3316         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
3317         (d_lookup_nested_symbol, d_lookup_symbol_imports)
3318         (d_lookup_symbol_module): Likewise.
3319         (find_symbol_in_baseclass): Simplify initialization.
3320
3321 2019-03-24  Tom Tromey  <tom@tromey.com>
3322
3323         * expression.h: Don't include symtab.h.
3324         (struct block): Forward declare.
3325
3326 2019-03-24  Tom Tromey  <tom@tromey.com>
3327
3328         * c-exp.y (typebase): Remove casts.
3329         * gdbtypes.c (lookup_unsigned_typename, )
3330         (lookup_signed_typename): Remove cast.
3331         * eval.c (parse_to_comma_and_eval): Remove cast.
3332         * parse.c (write_dollar_variable): Remove cast.
3333         * block.h (struct block) <superblock>: Now const.
3334         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
3335         * psymtab.c (psym_map_matching_symbols): Make "block" const.
3336         (map_block): Make "block" const.
3337         * symfile.h (struct quick_symbol_functions)
3338         <map_matching_symbols>: Constify block argument to "callback".
3339         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
3340         const.
3341         (find_pc_sect_compunit_symtab): Make "b" const.
3342         (find_symbol_at_address): Likewise.
3343         (search_symbols): Likewise.
3344         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
3345         (dw2_debug_names_lookup_symbol): Likewise.
3346         (dw2_map_matching_symbols): Update.
3347         * p-valprint.c (pascal_val_print): Remove "block".
3348         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
3349         (aux_add_nonlocal_symbols): Make "block" const.
3350         (resolve_subexp): Remove cast.
3351         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
3352         const.
3353         (iterate_over_file_blocks): Likewise.
3354         * f-exp.y (%union) <bval>: Remove.
3355         * coffread.c (patch_opaque_types): Make "b" const.
3356         * spu-tdep.c (spu_catch_start): Make "block" const.
3357         * c-valprint.c (print_unpacked_pointer): Remove "block".
3358         * symmisc.c (dump_symtab_1): Make "b" const.
3359         (block_depth): Make "block" const.
3360         * d-exp.y (%union) <bval>: Remove.
3361         * cp-support.h (cp_lookup_rtti_type): Update.
3362         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
3363         * psymtab.c (psym_lookup_symbol): Make "block" const.
3364         (maintenance_check_psymtabs): Make "b" const.
3365         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
3366         (enumerate_locals, enumerate_args): Update.
3367         * python/py-symtab.c (stpy_global_block): Make "block" const.
3368         (stpy_static_block): Likewise.
3369         * inline-frame.c (block_starting_point_at): Make "new_block"
3370         const.
3371         * block.c (find_block_in_blockvector): Make return type const.
3372         (blockvector_for_pc_sect): Make "b" const.
3373         (find_block_in_blockvector): Make "b" const.
3374
3375 2019-03-23  Tom Tromey  <tom@tromey.com>
3376
3377         * varobj.c (varobj_create): Update.
3378         * symfile.c (clear_symtab_users): Don't reset innermost_block.
3379         * printcmd.c (display_command, do_one_display): Don't reset
3380         innermost_block.
3381         * parser-defs.h (enum innermost_block_tracker_type): Move to
3382         expression.h.
3383         (innermost_block): Update comment.
3384         * parse.c (parse_exp_1): Add tracker_types parameter.
3385         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
3386         tracker_types parameter.  Reset innermost_block.
3387         (parse_exp_in_context): Remove.
3388         (parse_expression_for_completion): Update.
3389         * objfiles.c (~objfile): Don't reset expression_context_block or
3390         innermost_block.
3391         * expression.h (enum innermost_block_tracker_type): Move from
3392         parser-defs.h.
3393         (parse_exp_1): Add tracker_types parameter.
3394         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
3395         reset innermost_block.
3396
3397 2019-03-23  Tom Tromey  <tom@tromey.com>
3398
3399         * objfiles.h: Include bcache.h.
3400
3401 2019-03-23  Tom Tromey  <tom@tromey.com>
3402
3403         * linespec.c (get_current_search_block): Use
3404         scoped_restore_current_language.
3405         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
3406
3407 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3408             Jiong Wang  <jiong.wang@arm.com>
3409
3410         * aarch64-linux-tdep.c
3411         (aarch64_linux_iterate_over_regset_sections): Check for pauth
3412         section.
3413         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
3414
3415 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3416             Jiong Wang  <jiong.wang@arm.com>
3417
3418         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
3419         instructions.
3420         (aarch64_analyze_prologue_test): Add PACIASP test.
3421         (aarch64_prologue_prev_register): Unmask PC value.
3422
3423 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3424             Jiong Wang  <jiong.wang@arm.com>
3425
3426         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
3427         (aarch64_dwarf2_prev_register): Unmask PC value.
3428         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
3429         (aarch64_execute_dwarf_cfa_vendor_op): Check for
3430         DW_CFA_AARCH64_negate_ra_state.
3431         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
3432
3433 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3434             Jiong Wang  <jiong.wang@arm.com>
3435
3436         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
3437         registers.
3438         (aarch64_pseudo_register_name): Likewise.
3439         (aarch64_pseudo_register_type): Likewise.
3440         (aarch64_pseudo_register_reggroup_p): Likewise.
3441         (aarch64_gdbarch_init): Add pauth registers.
3442         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
3443         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
3444         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
3445         (struct gdbarch_tdep): Add regnum for ra_state.
3446
3447 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3448             Jiong Wang  <jiong.wang@arm.com>
3449
3450         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
3451
3452 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3453             Jiong Wang  <jiong.wang@arm.com>
3454
3455         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
3456         function.
3457         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
3458         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
3459         (aarch64_gdbarch_init): Add puth registers.
3460         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
3461         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
3462         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
3463
3464 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3465             Jiong Wang  <jiong.wang@arm.com>
3466
3467         * aarch64-linux-nat.c
3468         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
3469         * aarch64-linux-tdep.c
3470         (aarch64_linux_core_read_description): Likewise.
3471         (aarch64_linux_get_hwcap): New function.
3472         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
3473         (aarch64_linux_get_hwcap): New declaration.
3474
3475 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3476             Jiong Wang  <jiong.wang@arm.com>
3477
3478         * aarch64-linux-nat.c
3479         (aarch64_linux_nat_target::read_description): Add pauth param.
3480         * aarch64-linux-tdep.c
3481         (aarch64_linux_core_read_description): Likewise.
3482         * aarch64-tdep.c (struct target_desc): Add in pauth.
3483         (aarch64_read_description): Add pauth param.
3484         (aarch64_gdbarch_init): Likewise.
3485         * aarch64-tdep.h (aarch64_read_description): Likewise.
3486         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3487         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3488         * features/Makefile: Add new files.
3489         * features/aarch64-pauth.c: New file.
3490         * features/aarch64-pauth.xml: New file.
3491
3492 2019-03-20  Tom Tromey  <tromey@adacore.com>
3493
3494         * infrun.c (handle_inferior_event): Rename from
3495         handle_inferior_event_1.  Create a scoped_value_mark.
3496         (handle_inferior_event): Remove.
3497
3498 2019-03-19  Tom Tromey  <tromey@adacore.com>
3499
3500         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3501         * infrun.h (print_stop_event): Add "displays" parameter.
3502         * infrun.c (print_stop_event): Add "displays" parameter.
3503
3504 2019-03-19  Pedro Alves  <palves@redhat.com>
3505
3506         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3507         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3508         to -1.  Fix TABs vs spaces.
3509         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3510         * tui/tui-out.h (tui_ui_out) Add intro comments.
3511         <m_line, m_start_of_line>: In-class initialize, and add describing
3512         comment.
3513
3514 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3515
3516         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3517         variable names.
3518         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3519
3520 2019-03-18  Pedro Alves  <palves@redhat.com>
3521             Eli Zaretskii <eliz@gnu.org>
3522
3523         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3524         m_line and m_start_of_line.
3525
3526 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3527
3528         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3529         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3530         it returns a newline.  This fixes a regression in TU mode, whereby
3531         the next line is output on the same screen line as the user input.
3532
3533 2019-03-18  Tom Tromey  <tromey@adacore.com>
3534
3535         * minsyms.c (minimal_symbol_reader::install): Remove call to
3536         obstack_blank.
3537
3538 2019-03-18  Pedro Alves  <palves@redhat.com>
3539
3540         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3541         New globals.
3542         (apply_style): New, factored out from ...
3543         (apply_ansi_escape): ... this.  Handle reverse video mode.
3544         (tui_set_reverse_mode): New function.
3545         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3546         * tui/tui-winsource.c (tui_show_source_line): Use
3547         tui_set_reverse_mode instead of setting A_STANDOUT.
3548         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3549         New setter methods.
3550
3551 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3552
3553         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3554         Handle tabs.
3555
3556 2019-03-18  Tom Tromey  <tromey@adacore.com>
3557
3558         * ada-lang.c (empty_array): Add "high" parameter.
3559         (ada_evaluate_subexp): Update.
3560
3561 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3562
3563         * unittests/string_view-selftests.c: Define
3564         _initialize_string_view_selftests unconditionally.
3565
3566 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3567
3568         PR gdb/24350
3569         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3570
3571 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3572
3573         PR gdb/24351
3574         * windows-nat.c (display_selector): Fix format specifiers.
3575
3576 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3577
3578         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3579         tui_refill_source_window instead of tui_refresh_win, to update the
3580         current execution line.  This fixes redisplay of the current line
3581         when stepping through the code with "next" or "step".
3582
3583 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3584
3585         * source-cache.c (source_cache::get_source_lines): Call
3586         find_source_lines to initialize s->nlines.  This fixes vertical
3587         scrolling of TUI source window when the DOWN arrow is pressed.
3588
3589 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3590
3591         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3592         linux-thread-db.c (_initialize_thread_db): Likewise.
3593
3594 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3595
3596         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3597         wclrtoeol in tui_show_source_line".  This reverts changes made in
3598         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3599
3600 2019-03-15  Tom Tromey  <tom@tromey.com>
3601
3602         * symtab.h (struct minimal_symbol): Derive from
3603         general_symbol_info.
3604         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3605         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3606         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3607         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3608         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3609         (MSYMBOL_SEARCH_NAME): Update.
3610         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3611         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3612         * minsyms.c (minimal_symbol_reader::record_full): Update.
3613
3614 2019-03-15  Tom Tromey  <tom@tromey.com>
3615
3616         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3617
3618 2019-03-15  Tom Tromey  <tom@tromey.com>
3619
3620         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3621         unique_xmalloc_ptr.
3622         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3623         Update.
3624         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3625         (build_minimal_symbol_hash_tables)
3626         (minimal_symbol_reader::install): Update.
3627
3628 2019-03-15  Tom Tromey  <tom@tromey.com>
3629
3630         * symtab.c (create_demangled_names_hash): Update.
3631         (symbol_set_names): Update.
3632         * objfiles.h (struct objfile_per_bfd_storage)
3633         <demangled_names_hash>: Now an htab_up.
3634         * objfiles.c (objfile_per_bfd_storage): Simplify.
3635
3636 2019-03-15  Tom Tromey  <tom@tromey.com>
3637
3638         * objfiles.h (struct objfile_per_bfd_storage): Declare
3639         destructor.
3640         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3641         New.
3642         (get_objfile_bfd_data): Use new.  Don't initialize
3643         language_of_main.
3644         (free_objfile_per_bfd_storage): Remove.
3645         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3646
3647 2019-03-15  Tom Tromey  <tom@tromey.com>
3648
3649         * symfile.c (reread_symbols): Update.
3650         * objfiles.c (objfile::objfile): Update.
3651         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3652         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3653         comment.
3654         (minimal_symbol_reader::install): Update.
3655         (terminate_minimal_symbol_table): Remove.
3656         * jit.c (jit_object_close_impl): Update.
3657
3658 2019-03-15  Tom Tromey  <tom@tromey.com>
3659
3660         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3661         initializations.
3662
3663 2019-03-15  Tom Tromey  <tom@tromey.com>
3664
3665         * objfiles.h (struct objfile_per_bfd_storage)
3666         <demangled_hash_languages>: Now a bitset.
3667         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3668         (lookup_minimal_symbol): Update.
3669
3670 2019-03-15  Tom Tromey  <tom@tromey.com>
3671
3672         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3673         Don't return the symbol.
3674         * coffread.c (record_minimal_symbol): Use record_full.
3675
3676 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3677
3678         The MS-Windows port of ncurses fails to switch to a color pair if
3679         one or both of the colors are the implicit default colors.  This
3680         change records the default colors when TUI is initialized, and
3681         then specifies them explicitly when a color pair uses the default
3682         colors.  This allows color styling in TUI mode on MS-Windows.
3683
3684         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3685         ncurses_norm_attr.
3686         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3687         colors in ncurses_norm_attr.
3688         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3689         "none", replace it with the default color recorded in
3690         ncurses_norm_attr.
3691
3692 2019-03-14  Tom Tromey  <tromey@adacore.com>
3693
3694         * source-cache.h (class source_cache) <get_source_lines>: Return
3695         std::string.
3696         * source-cache.c (source_cache::extract_lines): Handle case where
3697         first_pos==npos.  Return std::string.
3698         (source_cache::get_source_lines): Update.
3699
3700 2019-03-14  Tom Tromey  <tromey@adacore.com>
3701
3702         * NEWS: Add item for "style sources" commands.
3703         * source-cache.c (source_cache::get_source_lines): Check
3704         source_styling.
3705         * cli/cli-style.c (source_styling): New global.
3706         (_initialize_cli_style): Add "style sources" commands.
3707         (show_style_sources): New function.
3708         * cli/cli-style.h (source_styling): Declare.
3709
3710 2019-03-14  Pedro Alves  <palves@redhat.com>
3711             Tom Tromey  <tromey@adacore.com>
3712
3713         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3714         * tui/tui-winsource.c (tui_refill_source_window): New function,
3715         from...
3716         (tui_horizontal_source_scroll): ... here.  Move some logic.
3717         * cli/cli-style.c (set_style_enabled): Notify new observable.
3718         * tui/tui-hooks.c (tui_redisplay_source): New function.
3719         (tui_attach_detach_observers): Attach or detach
3720         tui_redisplay_source.
3721         * observable.h (source_styling_changed): New observable.
3722         * observable.c: Define source_styling_changed observable.
3723
3724 2019-03-13  Tom Tromey  <tromey@adacore.com>
3725
3726         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3727         (i386_gnu_nat_target::store_registers): Update.
3728         * target-debug.h (target_debug_print_std_string): New macro.
3729         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3730         * windows-tdep.c (display_one_tib): Update.
3731         * tui/tui-stack.c (tui_make_status_line): Update.
3732         * top.c (print_inferior_quit_action): Update.
3733         * thread.c (thr_try_catch_cmd): Update.
3734         (add_thread_with_info): Update.
3735         (thread_target_id_str): Update.
3736         (thr_try_catch_cmd): Update.
3737         (thread_command): Update.
3738         (thread_find_command): Update.
3739         * record-btrace.c (record_btrace_target::info_record)
3740         (record_btrace_resume_thread, record_btrace_target::resume)
3741         (record_btrace_cancel_resume, record_btrace_step_thread)
3742         (record_btrace_target::wait, record_btrace_target::wait)
3743         (record_btrace_target::wait, record_btrace_target::stop): Update.
3744         * progspace.c (print_program_space): Update.
3745         * process-stratum-target.c
3746         (process_stratum_target::thread_address_space): Update.
3747         * linux-fork.c (linux_fork_mourn_inferior)
3748         (detach_checkpoint_command, info_checkpoints_command)
3749         (linux_fork_context): Update.
3750         (linux_fork_detach): Update.
3751         (class scoped_switch_fork_info): Update.
3752         (delete_checkpoint_command): Update.
3753         * infrun.c (follow_fork_inferior): Update.
3754         (follow_fork_inferior): Update.
3755         (proceed_after_vfork_done): Update.
3756         (handle_vfork_child_exec_or_exit): Update.
3757         (follow_exec): Update.
3758         (displaced_step_prepare_throw): Update.
3759         (displaced_step_restore): Update.
3760         (start_step_over): Update.
3761         (resume_1): Update.
3762         (clear_proceed_status_thread): Update.
3763         (proceed): Update.
3764         (print_target_wait_results): Update.
3765         (do_target_wait): Update.
3766         (context_switch): Update.
3767         (stop_all_threads): Update.
3768         (restart_threads): Update.
3769         (finish_step_over): Update.
3770         (handle_signal_stop): Update.
3771         (switch_back_to_stepped_thread): Update.
3772         (keep_going_pass_signal): Update.
3773         (print_exited_reason): Update.
3774         (normal_stop): Update.
3775         * inferior.c (inferior_pid_to_str): Change return type.
3776         (print_selected_inferior): Update.
3777         (add_inferior): Update.
3778         (detach_inferior): Update.
3779         * dummy-frame.c (fprint_dummy_frames): Update.
3780         * dcache.c (dcache_info_1): Update.
3781         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3782         (btrace_fetch, btrace_clear): Update.
3783         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3784         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3785         type.
3786         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3787         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3788         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3789         * gdbarch.c, gdbarch.h: Rebuild.
3790         * gdbarch.sh (core_pid_to_str): Change return type.
3791         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3792         return type.
3793         (windows_nat_target::pid_to_str): Change return type.
3794         (windows_delete_thread): Update.
3795         (windows_nat_target::attach): Update.
3796         (windows_nat_target::files_info): Update.
3797         * target-delegates.c: Rebuild.
3798         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3799         return type.
3800         (sol_thread_target::pid_to_str): Change return type.
3801         * remote.c (class remote_target) <pid_to_str>: Change return
3802         type.
3803         (remote_target::pid_to_str): Change return type.
3804         (extended_remote_target::attach, remote_target::remote_stop_ns)
3805         (remote_target::remote_notif_remove_queued_reply)
3806         (remote_target::push_stop_reply, remote_target::disable_btrace):
3807         Update.
3808         (extended_remote_target::attach): Update.
3809         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3810         type.
3811         (gdbsim_target::pid_to_str): Change return type.
3812         * ravenscar-thread.c (struct ravenscar_thread_target)
3813         <pid_to_str>: Change return type.
3814         (ravenscar_thread_target::pid_to_str): Change return type.
3815         * procfs.c (class procfs_target) <pid_to_str>: Change return
3816         type.
3817         (procfs_target::pid_to_str): Change return type.
3818         (procfs_target::attach): Update.
3819         (procfs_target::detach): Update.
3820         (procfs_target::fetch_registers): Update.
3821         (procfs_target::store_registers): Update.
3822         (procfs_target::wait): Update.
3823         (procfs_target::files_info): Update.
3824         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3825         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3826         return type.
3827         (nto_procfs_target::pid_to_str): Change return type.
3828         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3829         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3830         return type.
3831         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3832         (exit_lwp): Update.
3833         (attach_proc_task_lwp_callback, get_detach_signal)
3834         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3835         (linux_nat_target::resume, wait_lwp, stop_callback)
3836         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3837         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3838         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3839         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3840         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3841         type.
3842         (inf_ptrace_target::attach): Update.
3843         (inf_ptrace_target::files_info): Update.
3844         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3845         type.
3846         (go32_nat_target::pid_to_str): Change return type.
3847         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3848         (gnu_nat_target::wait): Update.
3849         (gnu_nat_target::wait): Update.
3850         (gnu_nat_target::resume): Update.
3851         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3852         (fbsd_nat_target::wait): Update.
3853         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3854         type.
3855         (darwin_nat_target::attach): Update.
3856         * corelow.c (class core_target) <pid_to_str>: Change return type.
3857         (core_target::pid_to_str): Change return type.
3858         * target.c (normal_pid_to_str): Change return type.
3859         (default_pid_to_str): Likewise.
3860         (target_pid_to_str): Change return type.
3861         (target_translate_tls_address): Update.
3862         (target_announce_detach): Update.
3863         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3864         return type.
3865         (bsd_uthread_target::pid_to_str): Change return type.
3866         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3867         type.
3868         (bsd_kvm_target::pid_to_str): Change return type.
3869         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3870         return type.
3871         (aix_thread_target::pid_to_str): Change return type.
3872         * target.h (struct target_ops) <pid_to_str>: Change return type.
3873         (target_pid_to_str, normal_pid_to_str): Likewise.
3874         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3875         type.
3876         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3877         type.
3878         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3879         return type.
3880         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3881         type.
3882         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3883         type.
3884         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3885         return type.
3886
3887 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3888
3889         * NEWS: Mention that the new default MI version is 3.  Mention
3890         changes to the output of commands and events that deal with
3891         multi-location breakpoints.
3892         * breakpoint.c: Include "mi/mi-out.h".
3893         (print_one_breakpoint): Change output syntax if using MI version
3894         >= 3.
3895         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3896         New.
3897         (mi_multi_location_breakpoint_output_fixed): New.
3898         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3899         (mi_cmd_fix_multi_location_breakpoint_output): New.
3900         (mi_multi_location_breakpoint_output_fixed): New.
3901         * mi/mi-cmds.c (mi_cmds): Register command
3902         -fix-multi-location-breakpoint-output.
3903         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3904         interpreter "mi".
3905
3906 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3907
3908         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3909         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3910         instantiate mi_ui_out based on interpreter name.
3911         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3912         * mi/mi-main.c (mi_load_progress): Likewise.
3913
3914 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3915
3916         * NEWS: Combine separate "New targets" sections for 8.3.
3917
3918 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3919
3920         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3921         (ppcfbsd_init_abi): Install gdbarch
3922         "fetch_tls_load_module_address" and "get_thread_local_address"
3923         methods.
3924
3925 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3926
3927         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3928         (riscv_fbsd_init_abi): Install gdbarch
3929         "fetch_tls_load_module_address" and "get_thread_local_address"
3930         methods.
3931
3932 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3933
3934         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3935         (i386fbsd_init_abi): Install gdbarch
3936         "fetch_tls_load_module_address" and "get_thread_local_address"
3937         methods.
3938
3939 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3940
3941         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3942         (amd64fbsd_init_abi): Install gdbarch
3943         "fetch_tls_load_module_address" and "get_thread_local_address"
3944         methods.
3945
3946 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3947
3948         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3949         (struct fbsd_pspace_data): New type.
3950         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3951         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3952         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3953         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3954         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3955
3956 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3957
3958         * gdbtypes.c (lookup_struct_elt): New function.
3959         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3960         * gdbtypes.h (struct struct_elt): New type.
3961         (lookup_struct_elt): New prototype.
3962
3963 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3964
3965         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3966         remove disabled code block.
3967
3968 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3969
3970         * gdbarch.sh (get_thread_local_address): New method.
3971         * gdbarch.h, gdbarch.c: Regenerate.
3972         * target.c (target_translate_tls_address): Use
3973         gdbarch_get_thread_local_address if present instead of
3974         target::get_thread_local_address.
3975
3976 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3977
3978         * target.h (target::get_thread_local_address): Update comment.
3979
3980 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3981
3982         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3983         objfile->separate_debug_objfile_backlink if not NULL.
3984
3985 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3986
3987         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3988         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3989         (amd64bsd_store_inferior_registers): Likewise.
3990         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3991         Enable segment base registers.
3992         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3993         PT_GETFSBASE and PT_GETGSBASE.
3994         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3995         PT_SETGSBASE.
3996         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3997         segment base registers.
3998         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3999
4000 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4001
4002         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4003         Update calls to i386_target_description to add 'segments'
4004         parameter.
4005         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
4006         add segment base registers.
4007         * arch/i386.c (i386_create_target_description): Add 'segments'
4008         parameter to enable segment base registers.
4009         * arch/i386.h (i386_create_target_description): Likewise.
4010         * features/i386/32bit-segments.xml: New file.
4011         * features/i386/32bit-segments.c: Generate.
4012         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
4013         call to i386_target_description to add 'segments' parameter.
4014         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4015         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
4016         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
4017         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
4018         if feature is present.
4019         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
4020         Add 'segments' parameter to call to i386_target_description.
4021         (i386_target_description): Add 'segments' parameter to enable
4022         segment base registers.
4023         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
4024         to call to i386_target_description.
4025         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
4026         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
4027         Define I386_NUM_REGS.
4028         (i386_target_description): Add 'segments' parameter to enable
4029         segment base registers.
4030
4031 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
4032
4033         PR/24325
4034         * source-cache.c: #undef open and close, to avoid unresolved
4035         externals during linking.
4036
4037 2019-03-12  Tom Tromey  <tromey@adacore.com>
4038
4039         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
4040         const.  Add initializers.
4041         (_initialize_remote): Don't initialize ptid globals.
4042
4043 2019-03-12  Pedro Alves  <palves@redhat.com>
4044
4045         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
4046
4047 2019-03-12  Pedro Alves  <palves@redhat.com>
4048
4049         * cp-name-parser.y (main): Remove unused 'len' variable.
4050
4051 2019-03-12  Tom Tromey  <tromey@adacore.com>
4052
4053         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
4054         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
4055
4056 2019-03-12  Tom Tromey  <tromey@adacore.com>
4057
4058         * linux-nat.c (iterate_over_lwps): Update.
4059         (stop_callback): Remove parameter.
4060         (stop_wait_callback, detach_callback, resume_set_callback)
4061         (select_singlestep_lwp_callback, set_ignore_sigint)
4062         (status_callback, resumed_callback, resume_clear_callback)
4063         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
4064         data parameter.
4065         (linux_nat_target::detach, linux_nat_target::resume)
4066         (linux_stop_and_wait_all_lwps, select_event_lwp)
4067         (linux_nat_filter_event, linux_nat_wait_1)
4068         (linux_nat_target::kill, linux_nat_target::stop)
4069         (linux_nat_target::stop): Update.
4070         (linux_nat_resume_callback): Change type.
4071         (resume_stopped_resumed_lwps, count_events_callback)
4072         (select_event_lwp_callback): Likewise.
4073         (linux_stop_lwp, linux_nat_stop_lwp): Update.
4074         * arm-linux-nat.c (struct update_registers_data): Remove.
4075         (update_registers_callback): Change type.
4076         (arm_linux_insert_hw_breakpoint1): Update.
4077         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
4078         parameter.
4079         (x86_linux_dr_set_addr): Update.
4080         (x86_linux_dr_set_control): Update.
4081         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
4082         (iterate_over_lwps): Use gdb::function_view.
4083         * nat/aarch64-linux-hw-point.c (struct
4084         aarch64_dr_update_callback_param): Remove.
4085         (debug_reg_change_callback): Change type.
4086         (aarch64_notify_debug_reg_change): Update.
4087         * s390-linux-nat.c (s390_refresh_per_info): Update.
4088
4089 2019-03-11  Tom Tromey  <tromey@adacore.com>
4090
4091         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
4092         redundant assignment to "this_cu".
4093
4094 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4095
4096         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
4097
4098 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4099
4100         * gdbtypes.c (rank_one_type_parm_set): New function extracted
4101         from...
4102         (rank_one_type): ... this.
4103
4104 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4105
4106         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
4107         from...
4108         (rank_one_type): ... this.
4109
4110 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4111
4112         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
4113         from...
4114         (rank_one_type): ... this.
4115
4116 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4117
4118         * gdbtypes.c (rank_one_type_parm_float): New function extracted
4119         from...
4120         (rank_one_type): ... this.
4121
4122 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4123
4124         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
4125         from...
4126         (rank_one_type): ... this.
4127
4128 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4129
4130         * gdbtypes.c (rank_one_type_parm_range): New function extracted
4131         from...
4132         (rank_one_type): ... this.
4133
4134 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4135
4136         * gdbtypes.c (rank_one_type_parm_char): New function extracted
4137         from...
4138         (rank_one_type): ... this.
4139
4140 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4141
4142         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
4143         from...
4144         (rank_one_type): ... this.
4145
4146 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4147
4148         * gdbtypes.c (rank_one_type_parm_int): New function extracted
4149         from...
4150         (rank_one_type): ... this.
4151
4152 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4153
4154         * gdbtypes.c (rank_one_type_parm_func): New function extracted
4155         from...
4156         (rank_one_type): ... this.
4157
4158 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4159
4160         * gdbtypes.c (rank_one_type_parm_array): New function extracted
4161         from...
4162         (rank_one_type): ... this.
4163
4164 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4165
4166         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
4167         from...
4168         (rank_one_type): ... this.
4169
4170 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4171
4172         * inferior.c (initialize_inferiors): Ensure 'help set/show print
4173         inferior-events' shows the example events.
4174
4175 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
4176
4177         Support styling on native MS-Windows console
4178
4179         PR/24315
4180         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
4181         on MS-Windows if $TERM is not defined.
4182
4183         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
4184
4185         * posix-hdep.c (gdb_console_fputs):
4186         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
4187         functions.
4188         * ui-file.h (gdb_console_fputs): Add prototype.
4189
4190         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
4191         back to fputs only if the former returns zero.
4192
4193 2019-03-07  Tom Tromey  <tom@tromey.com>
4194
4195         * symmisc.c (print_symbol_bcache_statistics): Update.
4196         (print_objfile_statistics): Update.
4197         * symfile.c (allocate_symtab): Update.
4198         * stabsread.c: Don't include bcache.h.
4199         * psymtab.h (struct psymbol_bcache): Don't declare.
4200         (class psymtab_storage) <psymbol_cache>: Now a bcache.
4201         (psymbol_bcache_init, psymbol_bcache_free)
4202         (psymbol_bcache_get_bcache): Don't declare.
4203         * psymtab.c (struct psymbol_bcache): Remove.
4204         (psymtab_storage::psymtab_storage): Update.
4205         (psymtab_storage::~psymtab_storage): Update.
4206         (psymbol_bcache_init, psymbol_bcache_free)
4207         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
4208         (add_psymbol_to_bcache): Update.
4209         (allocate_psymtab): Update.
4210         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
4211         macro_cache>: No longer pointers.
4212         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
4213         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
4214         * macrotab.c (macro_bcache): Update.
4215         * macroexp.c: Don't include bcache.h.
4216         * gdbtypes.c (check_types_worklist): Update.
4217         (types_deeply_equal): Remove TRY/CATCH.  Update.
4218         * elfread.c (elf_symtab_read): Update.
4219         * dwarf2read.c: Don't include bcache.h.
4220         * buildsym.c (buildsym_compunit::get_macro_table): Update.
4221         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
4222         (print_bcache_statistics, bcache_memory_used): Don't declare.
4223         (struct bcache): Move from bcache.c.  Add constructor, destructor,
4224         methods.  Rename all data members.
4225         * bcache.c (struct bcache): Move to bcache.h.
4226         (bcache::expand_hash_table): Rename from expand_hash_table.
4227         (bcache): Remove.
4228         (bcache::insert): Rename from bcache_full.
4229         (bcache::compare): Rename from bcache_compare.
4230         (bcache_xmalloc): Remove.
4231         (bcache::~bcache): Rename from bcache_xfree.
4232         (bcache::print_statistics): Rename from print_bcache_statistics.
4233         (bcache::memory_used): Rename from bcache_memory_used.
4234
4235 2019-03-07  Pedro Alves  <palves@redhat.com>
4236
4237         * infrun.c (normal_stop): Also check for
4238         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
4239
4240 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4241
4242         * f-lang.c (value_from_host_double): Moved to...
4243         * value.c (value_from_host_double): ...here.
4244         * value.h (value_from_host_double): Declare.
4245         * guile/scm-math.c (vlscm_convert_typed_number): Use
4246         value_from_host_double.
4247         (vlscm_convert_number): Likewise.
4248         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
4249         * python/py-value.c (convert_value_from_python): Likewise.
4250
4251 2019-03-06  Tom Tromey  <tom@tromey.com>
4252
4253         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
4254
4255 2019-03-06  Tom Tromey  <tom@tromey.com>
4256
4257         * utils.h (free_current_contents): Don't declare.
4258         * utils.c (free_current_contents): Remove.
4259
4260 2019-03-06  Tom Tromey  <tom@tromey.com>
4261
4262         * top.c (quit_force): Update.
4263         * main.c (captured_command_loop): Update.
4264         * common/new-op.c (operator new): Update.
4265         * common/common-exceptions.c (struct catcher)
4266         <save_cleanup_chain>: Remove member.
4267         (exceptions_state_mc_init): Update.
4268         (exception_try_scope_entry): Return nullptr.
4269         (exception_try_scope_exit, exception_rethrow)
4270         (throw_exception_sjlj, throw_exception_cxx): Update.
4271         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
4272         (all_cleanups, do_cleanups, discard_cleanups)
4273         (discard_final_cleanups, save_cleanups, save_final_cleanups)
4274         (restore_cleanups, restore_final_cleanups): Don't declare.
4275         (do_final_cleanups): Remove parameter.
4276         * common/cleanups.c (cleanup_chain, make_cleanup)
4277         (make_cleanup_dtor, all_cleanups, do_cleanups)
4278         (discard_my_cleanups, discard_cleanups)
4279         (discard_final_cleanups, save_my_cleanups, save_cleanups)
4280         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
4281         (null_cleanup): Remove.
4282         (do_final_cleanups): Remove parameter.
4283
4284 2019-03-06  Tom Tromey  <tom@tromey.com>
4285
4286         * remote.c (remote_target::remote_parse_stop_reply): Use
4287         unique_xmalloc_ptr.
4288
4289 2019-03-06  Tom Tromey  <tom@tromey.com>
4290
4291         * stabsread.c (struct stabs_field_info): Rename from field_info.
4292         <list, fnlist>: Add initializers.
4293         <obstack>: New member.
4294         (read_member_functions, read_struct_fields, read_baseclasses):
4295         Allocate on obstack.  Don't use cleanups.
4296         (read_one_struct_field, read_member_functions, read_struct_fields)
4297         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
4298         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
4299         (read_struct_type): Update.
4300
4301 2019-03-06  Tom Tromey  <tom@tromey.com>
4302
4303         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
4304         * common/filestuff.h (make_cleanup_close): Don't declare.
4305         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
4306         Remove.
4307
4308 2019-03-06  Tom Tromey  <tom@tromey.com>
4309
4310         * solib-aix.c: Use make_scope_exit.
4311
4312 2019-03-06  Tom Tromey  <tom@tromey.com>
4313
4314         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
4315         Use make_scope_exit.
4316
4317 2019-03-06  Tom Tromey  <tom@tromey.com>
4318
4319         * solib-svr4.c (disable_probes_interface): Remove parameter.
4320         (svr4_handle_solib_event): Use make_scope_exit.
4321
4322 2019-03-06  Tom Tromey  <tom@tromey.com>
4323
4324         * remote.c (struct stop_reply_deleter): Remove.
4325         (stop_reply_up): Update.
4326         (struct stop_reply): Derive from notif_event.  Don't typedef.
4327         <regcache>: Now a std::vector.
4328         (stop_reply_xfree): Remove.
4329         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
4330         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
4331         (remote_target::discard_pending_stop_replies): Use delete.
4332         (remote_target::remote_parse_stop_reply): Update.
4333         (remote_target::process_stop_reply): Update.
4334         * remote-notif.h (struct notif_event): Add virtual destructor.
4335         Remove "dtr" member.
4336         (struct notif_client) <alloc_event>: Return a unique_ptr.
4337         (notif_event_xfree): Don't declare.
4338         (notif_event_up): New typedef.
4339         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
4340         (notif_event_xfree, do_notif_event_xfree): Remove.
4341         (remote_notif_state_xfree): Update.
4342
4343 2019-03-06  Tom Tromey  <tom@tromey.com>
4344
4345         * infrun.c (displaced_step_clear_cleanup): Now a
4346         forward_scope_exit type.
4347         (displaced_step_prepare_throw): Update.
4348         (displaced_step_fixup): Update.
4349
4350 2019-03-06  Tom Tromey  <tom@tromey.com>
4351
4352         * inferior.h (class inferior): Update comment.
4353         * gdbthread.h (class thread_info): Update comment.
4354
4355 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
4356             Tom Tromey  <tom@tromey.com>
4357
4358         * stabsread.h (struct stab_section_list): Remove.
4359         (coffstab_build_psymtabs): Update.
4360         * dbxread.c (symbuf_sections): Now a std::vector.
4361         (sect_idx): New global.
4362         (fill_symbuf): Update.
4363         (coffstab_build_psymtabs): Change type of stabsects parameter.
4364         Update.
4365         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
4366         std::vector.
4367         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
4368         (coff_locate_sections): Update.
4369         (coff_symfile_read): Remove cleanups.  Update.
4370         (init_stringtab): Add storage parameter.
4371         (free_stringtab, free_stringtab_cleanup): Remove.
4372         (init_lineno): Add storage parameter.
4373         (free_linetab, free_linetab_cleanup): Remove.
4374
4375 2019-03-06  Pedro Alves  <palves@redhat.com>
4376
4377         * linux-fork.c (fork_info::clobber_regs): Delete.
4378         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
4379         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
4380         comment.  Adjust.
4381         (scoped_switch_fork_info::scoped_switch_fork_info)
4382         (checkpoint_command, linux_fork_context): Adjust
4383         fork_save_infrun_state calls.
4384
4385 2019-03-06  Pedro Alves  <palves@redhat.com>
4386
4387         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
4388         (inf_has_multiple_threads): Return 'bool' and rewrite using
4389         inferior_info::threads().
4390
4391 2019-03-06  Pedro Alves  <palves@redhat.com>
4392
4393         * linux-fork.c: Include <list>.
4394         (fork_list): Now a std::list instance.
4395         (fork_info): Add ctor, dtor, and in-class initialize all fields.
4396         (forks_exist_p, find_last_fork): Adjust.
4397         (new_fork): Delete.
4398         (one_fork_p): New.
4399         (add_fork): Adjust.
4400         (free_fork): Delete, folded into fork_info::~fork_info().
4401         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
4402         Adjust.
4403         (init_fork_list): Delete.
4404         (linux_fork_killall, linux_fork_mourn_inferior)
4405         (linux_fork_detach, info_checkpoints_command): Adjust.
4406         (_initialize_linux_fork): No longer call init_fork_list.
4407
4408 2019-03-06  Pedro Alves  <palves@redhat.com>
4409
4410         * linux-fork.c (new_fork): New, split out of ...
4411         (add_fork): ... this.  Return void.  Move "first fork" special
4412         case from here, to ...
4413         (checkpoint_command): ... here.
4414         * linux-linux.h (add_fork): Return void.
4415
4416 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4417
4418         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
4419
4420 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4421             Chris January  <chris.january@arm.com>
4422             David Lecomber  <david.lecomber@arm.com>
4423
4424         * f-exp.y: New token, UNOP_INTRINSIC.
4425         (exp): New pattern using UNOP_INTRINSIC token.
4426         (f77_keywords): Add 'abs' keyword.
4427         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
4428         (value_from_host_double): New function.
4429         (evaluate_subexp_f): Support UNOP_ABS.
4430
4431 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4432
4433         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
4434         types.
4435
4436 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4437
4438         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
4439         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
4440         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
4441
4442 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4443
4444         * f-exp.y (convert_to_kind_type): Handle more type kinds.
4445
4446 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4447             Chris January  <chris.january@arm.com>
4448
4449         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
4450         * f-exp.y: Define 'KIND' token.
4451         (exp): New pattern for KIND expressions.
4452         (ptype): Handle types with a kind extension.
4453         (direct_abs_decl): Extend to spot kind extensions.
4454         (f77_keywords): Add 'kind' to the list.
4455         (push_kind_type): New function.
4456         (convert_to_kind_type): New function.
4457         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
4458         * parse.c (operator_length_standard): Likewise.
4459         * parser-defs.h (enum type_pieces): Add tp_kind.
4460         * std-operator.def: Add UNOP_KIND.
4461
4462 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4463
4464         * f-exp.y (f_parse): Set yydebug.
4465
4466 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4467
4468         * f-lang.c (evaluate_subexp_f): New function.
4469         (exp_descriptor_f): New global.
4470         (f_language_defn): Use exp_descriptor_f instead of
4471         exp_descriptor_standard.
4472
4473 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4474
4475         * f-exp.y (struct token): Add comments.
4476         (dot_ops): Remove uppercase versions and the end marker.
4477         (f77_keywords): Likewise.
4478         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
4479         entries in the dot_ops array are case insensitive, and use
4480         strncasecmp to compare strings.  Also some whitespace cleanup in
4481         this area.  Similar for the f77_keywords array, except entries in
4482         this list might be case sensitive.
4483
4484 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4485
4486         * f-exp.y (struct f77_boolean_val): Add comments.
4487         (boolean_values): Remove uppercase versions, and end marker.
4488         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
4489         and use strncasecmp to achieve case insensitivity.  Additionally,
4490         perform whitespace cleanup around this code.
4491
4492 2019-03-06  Tom Tromey  <tromey@adacore.com>
4493
4494         * remote-sim.c (gdbsim_target_open): Use result of
4495         gdb_argv::release.
4496
4497 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4498         Dirk Schubert  <dirk.schubert@arm.com>
4499         Chris January  <chris.january@arm.com>
4500
4501         * eval.c (evaluate_subexp_standard): Call Fortran argument
4502         wrapping logic.
4503         * f-lang.c (struct value): A value which can be passed into a
4504         Fortran function call.
4505         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4506         where appropriate.
4507         (struct type): Value ready for a Fortran function call.
4508         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4509         is needed.
4510         * f-lang.h (fortran_argument_convert): Declaration.
4511         (fortran_preserve_arg_pointer): Declaration.
4512         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4513
4514 2019-03-05  Tom Tromey  <tromey@adacore.com>
4515
4516         * python/py-prettyprint.c (print_string_repr): Remove #if.
4517         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4518
4519 2019-03-05  Tom Tromey  <tromey@adacore.com>
4520
4521         * target.c (the_dummy_target): Move later.  Change type to
4522         "dummy_target".
4523         (initialize_targets): Don't initialize the_dummy_target.
4524
4525 2019-03-05  Tom Tromey  <tromey@adacore.com>
4526
4527         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4528         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4529
4530 2019-03-05  Tom Tromey  <tromey@adacore.com>
4531
4532         * windows-nat.c (windows_nat_target::attach)
4533         (windows_nat_target::detach): Don't call gdb_flush.
4534         * valprint.c (generic_val_print, val_print, val_print_string):
4535         Don't call gdb_flush.
4536         * utils.c (defaulted_query): Don't call gdb_flush.
4537         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4538         * target.c (target_announce_detach): Don't call gdb_flush.
4539         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4540         * remote.c (extended_remote_target::attach): Don't call
4541         gdb_flush.
4542         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4543         * printcmd.c (do_examine): Don't call gdb_flush.
4544         (info_display_command): Don't call gdb_flush.
4545         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4546         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4547         * memattr.c (info_mem_command): Don't call gdb_flush.
4548         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4549         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4550         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4551         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4552         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4553         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4554         (gnu_nat_target::detach): Don't call gdb_flush.
4555         * f-valprint.c (f_val_print): Don't call gdb_flush.
4556         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4557         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4558         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4559         gdb_flush.
4560         * c-valprint.c (c_val_print): Don't call gdb_flush.
4561         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4562
4563 2019-03-05  Tom Tromey  <tromey@adacore.com>
4564
4565         * varobj.c (update_dynamic_varobj_children): Update.
4566         (install_default_visualizer): Use reset, not release.
4567         * value.c (set_internalvar): Update.
4568         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4569         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4570         ATTRIBUTE_UNUSED_RESULT.
4571
4572 2019-03-05  Tom Tromey  <tromey@adacore.com>
4573
4574         * remote.c (class scoped_remote_fd) <release>: Add
4575         ATTRIBUTE_UNUSED_RESULT.
4576
4577 2019-03-05  Tom Tromey  <tromey@adacore.com>
4578
4579         * macroexp.c (struct macro_buffer) <release>: Add
4580         ATTRIBUTE_UNUSED_RESULT.
4581
4582 2019-03-05  Tom Tromey  <tromey@adacore.com>
4583
4584         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4585         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4586         ATTRIBUTE_UNUSED_RESULT.
4587
4588 2019-03-05  Tom Tromey  <tromey@adacore.com>
4589
4590         * common/scoped_fd.h (class scoped_fd) <release>: Add
4591         ATTRIBUTE_UNUSED_RESULT.
4592
4593 2019-03-05  Tom Tromey  <tromey@adacore.com>
4594
4595         * parser-defs.h (struct parser_state) <release>: Add
4596         ATTRIBUTE_UNUSED_RESULT.
4597
4598 2019-03-05  Tom Tromey  <tromey@adacore.com>
4599
4600         * utils.h (class gdb_argv) <release>: Add
4601         ATTRIBUTE_UNUSED_RESULT.
4602         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4603
4604 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4605
4606         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4607         for-loop range, to avoid compiler warnings.
4608
4609         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4610         avoid compiler warnings about unused variables.
4611
4612         * NEWS: Mention end of support for native debugging on MS-Windows
4613         before XP.
4614
4615         PR gdb/24292
4616         * common/netstuff.c:
4617         * gdbserver/gdbreplay.c
4618         * gdbserver/remote-utils.c:
4619         * ser-tcp.c:
4620         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4621         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4622         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4623         'getaddrinfo' and 'freeaddrinfo' were not available before
4624         Windows XP, and mingw.org's MinGW headers by default define
4625         _WIN32_WINNT to 0x500.
4626
4627 2019-03-01  Gary Benson <gbenson@redhat.com>
4628
4629         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4630
4631 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4632             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4633
4634         PR gdb/8527
4635         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4636         set_sigint_trap, clear_sigint_trap.
4637
4638 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4639
4640         * target.c (target_detach): Clear the regcache and the
4641         frame cache.
4642
4643 2019-02-27  Pedro Alves  <palves@redhat.com>
4644
4645         * utils.c (set_screen_size): When we cap the height/width sizes,
4646         tweak the corresponding command variable to show "unlimited":
4647
4648 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4649             Pedro Alves  <palves@redhat.com>
4650
4651         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4652         before calling rl_set_screen_size.
4653
4654 2019-02-27  Tom Tromey  <tromey@adacore.com>
4655
4656         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4657         define.
4658         * python/py-value.c: Remove Python 2.4 workaround.
4659         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4660         workaround.
4661         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4662         Python 2.4 workaround.
4663         * python/python-internal.h: Remove Python 2.4 comment.
4664         (Py_ssize_t): Don't define.
4665         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4666         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4667         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4668         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4669         * python/python.c (do_start_initialization): Remove Python 2.4
4670         workaround.
4671         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4672         (print_children): Remove Python 2.4 workaround.
4673         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4674         workaround.
4675         (CHARBUFFERPROC_NAME): Remove.
4676         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4677         Python 2.4 workaround.
4678
4679 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4680
4681         * NEWS: Note minimum Python version.
4682
4683 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4684
4685         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4686         code from these functions.  Remove corresponding ifdefs.  Use
4687         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4688         Remove gotos and target of gotos.
4689         (infpy_search_memory): Likewise.
4690
4691 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4692
4693         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4694         (hppa_gdbarch_init): Don't register deleted functions with
4695         gdbarch.
4696
4697 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4698
4699         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4700         (h8300_unwind_sp): Delete.
4701         (h8300_dummy_id): Delete.
4702         (h8300_gdbarch_init): Don't register deleted functions with
4703         gdbarch.
4704
4705 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4706
4707         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4708         (ft32_unwind_pc): Delete.
4709         (ft32_unwind_sp): Delete.
4710         (ft32_gdbarch_init): Don't register deleted functions with
4711         gdbarch.
4712
4713 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4714
4715         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4716         (frv_unwind_pc): Delete.
4717         (frv_unwind_sp): Delete.
4718         (frv_gdbarch_init): Don't register deleted functions with
4719         gdbarch.
4720
4721 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4722
4723         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4724         (riscv_unwind_pc): Delete.
4725         (riscv_unwind_sp): Delete.
4726         (riscv_gdbarch_init): Don't register deleted functions with
4727         gdbarch.
4728
4729 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4730
4731         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4732         (csky_unwind_pc): Delete.
4733         (csky_unwind_sp): Delete.
4734         (csky_gdbarch_init): Don't register deleted functions with
4735         gdbarch.
4736
4737 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4738
4739         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4740         (cris_unwind_pc): Delete.
4741         (cris_unwind_sp): Delete.
4742         (cris_gdbarch_init): Don't register deleted functions with
4743         gdbarch.
4744
4745 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4746
4747         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4748         (bfin_unwind_pc): Delete.
4749         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4750
4751 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4752
4753         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4754         (arm_unwind_pc): Delete.
4755         (arm_unwind_sp): Delete.
4756         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4757
4758 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4759
4760         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4761         (arc_unwind_pc): Delete.
4762         (arc_unwind_sp): Delete.
4763         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4764
4765 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4766
4767         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4768         (alpha_unwind_pc): Delete.
4769         (alpha_gdbarch_init): Don't register deleted functions with
4770         gdbarch.
4771
4772 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4773
4774         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4775         (aarch64_unwind_pc): Delete.
4776         (aarch64_unwind_sp): Delete.
4777         (aarch64_gdbarch_init): Don't register deleted functions with
4778         gdbarch.
4779
4780 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4781
4782         * gdbtypes.c (type_align): Don't consider static members when
4783         computing structure alignment.
4784
4785 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4786
4787         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4788         return 0 for other types.
4789         * arch-utils.c (default_type_align): Always return 0.
4790         * gdbarch.h: Regenerate.
4791         * gdbarch.sh (type_align): Extend comment.
4792         * gdbtypes.c (type_align): Add additional comments, always call
4793         gdbarch_type_align before applying the default rules.
4794         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4795         generic code will then apply a suitable default.
4796         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4797         types, return 0 for other types.
4798
4799 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4800
4801         * NEWS: Create a new section for the next release branch.
4802         Rename the section of the current branch, now that it has
4803         been cut.
4804
4805 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4806
4807         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4808         * version.in: Bump version to 8.3.50.DATE-git.
4809
4810 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4811
4812         * aix-thread.c (ptid_cmp): Remove unused variable.
4813         (get_signaled_thread): Likewise.
4814         (store_regs_user_thread): Likewise.
4815         (store_regs_kernel_thread): Likewise.
4816         (fetch_regs_kernel_thread): Remove shadowed variable.
4817
4818 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4819
4820         * features/riscv/32bit-cpu.xml: Add register numbers.
4821         * features/riscv/32bit-fpu.c: Regenerate.
4822         * features/riscv/32bit-fpu.xml: Add register numbers.
4823         * features/riscv/64bit-cpu.xml: Add register numbers.
4824         * features/riscv/64bit-fpu.c: Regenerate.
4825         * features/riscv/64bit-fpu.xml: Add register numbers.
4826
4827 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4828
4829         * NEWS: Mention two argument form of gdb.Value constructor.
4830         * python/py-value.c (convert_buffer_and_type_to_value): New
4831         function.
4832         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4833         Add support for handling an optional second argument.  Call
4834         convert_buffer_and_type_to_value as appropriate.
4835         * python/python-internal.h (Py_buffer_deleter): New struct.
4836         (Py_buffer_up): New typedef.
4837
4838 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4839
4840         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4841         instead of releasing ownership.
4842
4843 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4844
4845         * dwarf2read.c (open_and_init_dwp_file): Call
4846         elf_numsections instead of bfd_count_sections to initialize
4847         dwp_file->num_sections.
4848
4849 2019-02-25  Tom Tromey  <tromey@adacore.com>
4850
4851         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4852
4853 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4854
4855         * gcore.in: Add '--readnever' option when invoking GDB.
4856
4857 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4858
4859         * MAINTAINERS: Update my email address.
4860
4861 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4862
4863         * build-id.c (build_id_to_debug_bfd_1): New function.
4864         (build_id_to_debug_bfd): Look for separate debug file in
4865         sysroot.
4866
4867 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4868
4869         * gdbarch.sh: Update the copyright year range that is placed into
4870         generated files.
4871
4872 2019-02-22  Keith Seitz  <keiths@redhat.com>
4873
4874         PR symtab/23853
4875         * linespec.c (create_sals_line_offset): Search for the default
4876         symtab's filename instead of its fullname.
4877
4878 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4879
4880         * NEWS: Update style defaults.
4881
4882 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4883
4884         * main.c (captured_main_1): Disable styling in batch mode.
4885
4886 2019-02-20  Tom Tromey  <tom@tromey.com>
4887
4888         * symtab.c (symtab_symbol_info): Fix typos.
4889
4890 2019-02-20  Tom Tromey  <tromey@adacore.com>
4891
4892         * findcmd.c (_initialize_mem_search): Use upper case for
4893         metasyntactic variables.
4894
4895 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4896
4897         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4898         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4899
4900 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4901
4902         * top.h (source_file_name): Change to std::string.
4903         * top.c (source_file_name): Likewise.
4904         (command_line_input): Adjust.
4905         * cli/cli-script.c (script_from_file): Adjust.
4906
4907 2019-02-19  Tom Tromey  <tromey@adacore.com>
4908
4909         * ravenscar-thread.c
4910         (ravenscar_thread_target::update_thread_list): Don't call
4911         ada_build_task_list.
4912         * ada-lang.h (ada_build_task_list): Don't declare.
4913         * ada-tasks.c (struct ada_tasks_inferior_data)
4914         <task_list_valid_p>: Now bool.
4915         (read_known_tasks, ada_task_list_changed)
4916         (ada_tasks_invalidate_inferior_data): Update.
4917         (read_known_tasks_array): Return bool.
4918         (read_known_tasks_list): Likewise.
4919         (read_known_tasks): Return void.
4920         (ada_build_task_list): Now static.
4921
4922 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4923
4924         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4925         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4926
4927 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4928
4929         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4930         variant for ada_tasks_pspace_data_handle and
4931         ada_tasks_inferior_data_handle.
4932         (ada_tasks_pspace_data_cleanup): New function.
4933         (ada_tasks_inferior_data_cleanup): New function.
4934
4935 2019-02-17  Tom Tromey  <tom@tromey.com>
4936
4937         * macrotab.h (macro_source_fullname): Return a std::string.
4938         * macrotab.c (macro_include, check_for_redefinition)
4939         (macro_undef, macro_lookup_definition, foreach_macro)
4940         (foreach_macro_in_scope): Update.
4941         (macro_source_fullname): Return a std::string.
4942         * macrocmd.c (show_pp_source_pos): Update.
4943
4944 2019-02-17  Tom Tromey  <tom@tromey.com>
4945
4946         * macrocmd.c (show_pp_source_pos): Style the file names.
4947
4948 2019-02-17  Tom Tromey  <tom@tromey.com>
4949
4950         PR tui/24197:
4951         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4952
4953 2019-02-17  Tom Tromey  <tom@tromey.com>
4954
4955         * ada-lang.c (user_select_syms): Use filtered printing.
4956         * utils.c (wrap_style): New global.
4957         (desired_style): Remove.
4958         (emit_style_escape): Add stream parameter.
4959         (set_output_style, reset_terminal_style, prompt_for_continue):
4960         Update.
4961         (flush_wrap_buffer): Only flush gdb_stdout.
4962         (wrap_here): Set wrap_style.
4963         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4964         treat escape sequences as a character.  Change when wrap buffer is
4965         flushed.
4966         (fputs_styled): Do not set the output style when the default is
4967         requested.
4968         * ui-style.h (struct ui_file_style) <is_default>: New method.
4969         * source.c (print_source_lines_base): Emit escape sequences in one
4970         piece.
4971
4972 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4973
4974         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4975         integers and enumeration types.
4976
4977 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4978
4979         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4980         instead of lookup_symbol_in_language
4981         (do_exact_match): New function.
4982         (ada_get_symbol_name_matcher): Return do_exact_match when
4983         doing a verbatim match.
4984
4985 2019-02-15  Tom Tromey  <tromey@adacore.com>
4986
4987         * ravenscar-thread.c (ravenscar_thread_target::resume)
4988         (ravenscar_thread_target::wait): Special case wildcard requests.
4989
4990 2019-02-15  Tom Tromey  <tromey@adacore.com>
4991
4992         * ravenscar-thread.c (base_ptid): Remove.
4993         (struct ravenscar_thread_target) <close>: New method.
4994         <m_base_ptid>: New member.
4995         <update_inferior_ptid, active_task, task_is_currently_active,
4996         runtime_initialized>: Declare methods.
4997         <ravenscar_thread_target>: Add constructor.
4998         (ravenscar_thread_target::task_is_currently_active)
4999         (ravenscar_thread_target::update_inferior_ptid)
5000         (ravenscar_runtime_initialized): Rename.  Now methods.
5001         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
5002         (ravenscar_thread_target::update_thread_list): Update.
5003         (ravenscar_thread_target::active_task): Now method.
5004         (ravenscar_thread_target::store_registers)
5005         (ravenscar_thread_target::prepare_to_store)
5006         (ravenscar_thread_target::prepare_to_store)
5007         (ravenscar_thread_target::mourn_inferior): Update.
5008         (ravenscar_inferior_created): Use "new" to create target.
5009         (ravenscar_thread_target::get_ada_task_ptid): Update.
5010         (_initialize_ravenscar): Don't initialize base_ptid.
5011         (ravenscar_ops): Remove global.
5012
5013 2019-02-15  Tom Tromey  <tromey@adacore.com>
5014
5015         * target.h (push_target): Declare new overload.
5016         * target.c (push_target): New overload, taking an rvalue reference.
5017         * remote.c (remote_target::open_1): Use push_target overload.
5018         * corelow.c (core_target_open): Use push_target overload.
5019
5020 2019-02-15  Tom Tromey  <tromey@adacore.com>
5021
5022         * ravenscar-thread.c (is_ravenscar_task)
5023         (ravenscar_task_is_currently_active): Return bool.
5024         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
5025         (_initialize_ravenscar): Remove "(void)".
5026         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
5027         Return bool.
5028
5029 2019-02-15  Tom Tromey  <tromey@adacore.com>
5030
5031         * ravenscar-thread.c (ravenscar_runtime_initializer)
5032         (has_ravenscar_runtime, get_running_thread_id)
5033         (ravenscar_thread_target::resume): Fix indentation.
5034
5035 2019-02-15  Tom Tromey  <tromey@adacore.com>
5036
5037         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
5038         from ravenscar_arch_ops.
5039         (sparc_ravenscar_ops::fetch_registers)
5040         (sparc_ravenscar_ops::store_registers): Now methods.
5041         (sparc_ravenscar_prepare_to_store): Remove.
5042         (sparc_ravenscar_ops): Redefine.
5043         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
5044         methods and destructor.  Remove members.
5045         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
5046         (ravenscar_thread_target::store_registers)
5047         (ravenscar_thread_target::prepare_to_store): Update.
5048         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
5049         Remove.
5050         (struct ppc_ravenscar_powerpc_ops): Derive from
5051         ravenscar_arch_ops.
5052         (ppc_ravenscar_powerpc_ops::fetch_registers)
5053         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
5054         (ppc_ravenscar_powerpc_ops): Redefine.
5055         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
5056         (ppc_ravenscar_e500_ops::fetch_registers)
5057         (ppc_ravenscar_e500_ops::store_registers): Now methods.
5058         (ppc_ravenscar_e500_ops): Redefine.
5059         * aarch64-ravenscar-thread.c
5060         (aarch64_ravenscar_generic_prepare_to_store): Remove.
5061         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
5062         (aarch64_ravenscar_fetch_registers)
5063         (aarch64_ravenscar_store_registers): Now methods.
5064         (aarch64_ravenscar_ops): Redefine.
5065
5066 2019-02-15  Tom Tromey  <tromey@adacore.com>
5067
5068         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
5069         (ravenscar_thread_target::stopped_by_hw_breakpoint)
5070         (ravenscar_thread_target::stopped_by_watchpoint)
5071         (ravenscar_thread_target::stopped_data_address)
5072         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
5073
5074 2019-02-15  Tom Tromey  <tromey@adacore.com>
5075
5076         * ravenscar-thread.c: Fix some typos.
5077
5078 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5079             Tom Tromey  <tromey@adacore.com>
5080
5081         * ada-lang.c (ada_exception_sal): Change addr_string to a
5082         std::string.
5083         (create_ada_exception_catchpoint): Update.
5084
5085 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5086             Tom Tromey  <tromey@adacore.com>
5087
5088         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
5089         (bp_location_ops): Remove.
5090         (base_breakpoint_allocate_location): Update.
5091         (free_bp_location): Update.
5092         * ada-lang.c (class ada_catchpoint_location)
5093         <ada_catchpoint_location>: Remove ops parameter.
5094         (ada_catchpoint_location_dtor): Remove.
5095         (ada_catchpoint_location_ops): Remove.
5096         (allocate_location_exception): Update.
5097         * breakpoint.h (struct bp_location_ops): Remove.
5098         (class bp_location) <bp_location>: Remove bp_location_ops
5099         parameter.
5100         <~bp_location>: Add destructor.
5101         <ops>: Remove.
5102
5103 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5104             Pedro Alves  <palves@redhat.com>
5105
5106         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
5107         'PATH_MAX'.
5108
5109 2019-02-14  David Michael  <fedora.dm0@gmail.com>
5110             Samuel Thibault  <samuel.thibault@gnu.org>
5111             Thomas Schwinge  <thomas@codesourcery.com>
5112
5113         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
5114         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
5115
5116 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5117
5118         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
5119         (check_empty): Use "const char *".
5120
5121         * gnu-nat.c (gnu_nat_target::detach): Instead of
5122         'detach_inferior (pid)' call
5123         'detach_inferior (find_inferior_pid (pid))'.
5124
5125         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
5126         'nat/fork-inferior.o'.
5127         * gnu-nat.c: #include "nat/fork-inferior.h".
5128
5129         * gnu-nat.c (gnu_nat_target::detach): Instead of
5130         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
5131         * gnu-nat.h: #include "inf-child.h".
5132         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
5133         'i386_gnu_nat_target::fetch_registers'.
5134         (gnu_store_registers): Rename/move to
5135         'i386_gnu_nat_target::store_registers'.
5136
5137         * config/i386/nm-i386gnu.h: Don't "#include" any files.
5138         * gnu-nat.h (mach_thread_info): New function.
5139         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
5140
5141         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
5142
5143 2019-02-14  Frederic Konrad  <konrad@adacore.com>
5144
5145         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
5146
5147 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
5148
5149         * windows-nat.c (windows_add_thread): Add new parameter
5150         "main_thread_p" with default value set to false.  Update
5151         function documentation as well as all callers.
5152         (windows_delete_thread): Likewise.
5153         (fake_create_process): Update call to windows_add_thread.
5154         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
5155         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
5156         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
5157         call to windows_delete_thread.
5158
5159 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
5160
5161         * MAINTAINERS: Add Andrew Burgess as global maintainer.
5162
5163 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5164
5165         * symfile.c (find_separate_debug_file): Use canonical path of
5166         sysroot with child_path instead of gdb_sysroot if it is valid.
5167
5168 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5169
5170         * symfile.c (find_separate_debug_file): Use child_path to
5171         determine if an object file is under a sysroot.
5172
5173 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5174
5175         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5176         unittests/child-path-selftests.c.
5177         * common/pathstuff.c (child_path): New function.
5178         * common/pathstuff.h (child_path): New prototype.
5179         * unittests/child-path-selftests.c: New file.
5180
5181 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5182
5183         * symfile.c (find_separate_debug_file): Look for separate debug
5184         files in debug directories under the sysroot.
5185
5186 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5187
5188         * symtab.h (struct minimal_symbol data_p): New const method.
5189         (struct minimal_symbol text_p): Likewise.
5190         * symtab.c (output_source_filename): Use file name style
5191         to print file name.
5192         (print_symbol_info): Likewise.
5193         (print_msymbol_info): Use address style to print addresses.
5194         Use function name style to print executable text symbols.
5195         (expand_symtab_containing_pc): Use data_p.
5196         (find_pc_sect_compunit_symtab): Likewise.
5197
5198 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5199
5200         * breakpoint.c (describe_other_breakpoints): Use address style
5201         to print addresses.
5202         (say_where): Likewise.
5203
5204 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5205
5206         * ada-typeprint.c (print_func_type): Print function name
5207         style to print function name.
5208         * c-typeprint.c (c_print_type_1): Likewise.
5209
5210 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
5211
5212         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
5213         for execve.
5214
5215 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5216
5217         * c-exp.y (direct_abs_decl): Use emplace_back to record the
5218         type_stack.
5219
5220 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
5221
5222         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
5223         TYPE_CODE_REF types.
5224
5225 2019-02-08  Jim Wilson  <jimw@sifive.com>
5226
5227         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
5228         (riscv_linux_fregset): New.
5229         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
5230
5231 2019-02-07  Tom Tromey  <tom@tromey.com>
5232
5233         * thread.c (thread_cancel_execution_command): Update.
5234         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
5235         methods.
5236         (struct thread_fsm_ops): Remove.
5237         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
5238         (thread_fsm_should_stop, thread_fsm_return_value)
5239         (thread_fsm_set_finished, thread_fsm_finished_p)
5240         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
5241         Don't declare.
5242         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
5243         * infrun.c (clear_proceed_status_thread)
5244         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
5245         (print_stop_event): Update.
5246         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
5247         Add constructor.
5248         (step_command_fsm_ops): Remove.
5249         (new_step_command_fsm): Remove.
5250         (step_1): Update.
5251         (step_command_fsm::should_stop): Rename from
5252         step_command_fsm_should_stop.
5253         (step_command_fsm::clean_up): Rename from
5254         step_command_fsm_clean_up.
5255         (step_command_fsm::do_async_reply_reason): Rename from
5256         step_command_fsm_async_reply_reason.
5257         (struct until_next_fsm): Inherit from thread_fsm.  Add
5258         constructor.
5259         (until_next_fsm_ops): Remove.
5260         (new_until_next_fsm): Remove.
5261         (until_next_fsm::should_stop): Rename from
5262         until_next_fsm_should_stop.
5263         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
5264         (until_next_fsm::do_async_reply_reason): Rename from
5265         until_next_fsm_async_reply_reason.
5266         (struct finish_command_fsm): Inherit from thread_fsm.  Add
5267         constructor.  Change type of breakpoint.
5268         (finish_command_fsm_ops): Remove.
5269         (new_finish_command_fsm): Remove.
5270         (finish_command_fsm::should_stop): Rename from
5271         finish_command_fsm_should_stop.
5272         (finish_command_fsm::clean_up): Rename from
5273         finish_command_fsm_clean_up.
5274         (finish_command_fsm::return_value): Rename from
5275         finish_command_fsm_return_value.
5276         (finish_command_fsm::do_async_reply_reason): Rename from
5277         finish_command_fsm_async_reply_reason.
5278         (finish_command): Update.
5279         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
5280         Add constructor.
5281         (call_thread_fsm_ops): Remove.
5282         (call_thread_fsm::call_thread_fsm): Rename from
5283         new_call_thread_fsm.
5284         (call_thread_fsm::should_stop): Rename from
5285         call_thread_fsm_should_stop.
5286         (call_thread_fsm::should_notify_stop): Rename from
5287         call_thread_fsm_should_notify_stop.
5288         (run_inferior_call, call_function_by_hand_dummy): Update.
5289         * cli/cli-interp.c (should_print_stop_to_console): Update.
5290         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
5291         Add constructor.  Change type of location_breakpoint,
5292         caller_breakpoint.
5293         (until_break_fsm_ops): Remove.
5294         (new_until_break_fsm): Remove.
5295         (until_break_fsm::should_stop): Rename from
5296         until_break_fsm_should_stop.
5297         (until_break_fsm::clean_up): Rename from
5298         until_break_fsm_clean_up.
5299         (until_break_fsm::do_async_reply_reason): Rename from
5300         until_break_fsm_async_reply_reason.
5301         (until_break_command): Update.
5302         * thread-fsm.c: Remove.
5303         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
5304
5305 2019-02-07  Tom Tromey  <tom@tromey.com>
5306
5307         * yy-remap.h: Add include guard.
5308         * xtensa-tdep.h: Add include guard.
5309         * xcoffread.h: Rename include guard.
5310         * varobj-iter.h: Add include guard.
5311         * tui/tui.h: Rename include guard.
5312         * tui/tui-winsource.h: Rename include guard.
5313         * tui/tui-wingeneral.h: Rename include guard.
5314         * tui/tui-windata.h: Rename include guard.
5315         * tui/tui-win.h: Rename include guard.
5316         * tui/tui-stack.h: Rename include guard.
5317         * tui/tui-source.h: Rename include guard.
5318         * tui/tui-regs.h: Rename include guard.
5319         * tui/tui-out.h: Rename include guard.
5320         * tui/tui-layout.h: Rename include guard.
5321         * tui/tui-io.h: Rename include guard.
5322         * tui/tui-hooks.h: Rename include guard.
5323         * tui/tui-file.h: Rename include guard.
5324         * tui/tui-disasm.h: Rename include guard.
5325         * tui/tui-data.h: Rename include guard.
5326         * tui/tui-command.h: Rename include guard.
5327         * tic6x-tdep.h: Add include guard.
5328         * target/waitstatus.h: Rename include guard.
5329         * target/wait.h: Rename include guard.
5330         * target/target.h: Rename include guard.
5331         * target/resume.h: Rename include guard.
5332         * target-float.h: Rename include guard.
5333         * stabsread.h: Add include guard.
5334         * rs6000-tdep.h: Add include guard.
5335         * riscv-fbsd-tdep.h: Add include guard.
5336         * regformats/regdef.h: Rename include guard.
5337         * record.h: Rename include guard.
5338         * python/python.h: Rename include guard.
5339         * python/python-internal.h: Rename include guard.
5340         * python/py-stopevent.h: Rename include guard.
5341         * python/py-ref.h: Rename include guard.
5342         * python/py-record.h: Rename include guard.
5343         * python/py-record-full.h: Rename include guard.
5344         * python/py-record-btrace.h: Rename include guard.
5345         * python/py-instruction.h: Rename include guard.
5346         * python/py-events.h: Rename include guard.
5347         * python/py-event.h: Rename include guard.
5348         * procfs.h: Add include guard.
5349         * proc-utils.h: Add include guard.
5350         * p-lang.h: Add include guard.
5351         * or1k-tdep.h: Rename include guard.
5352         * observable.h: Rename include guard.
5353         * nto-tdep.h: Rename include guard.
5354         * nat/x86-linux.h: Rename include guard.
5355         * nat/x86-linux-dregs.h: Rename include guard.
5356         * nat/x86-gcc-cpuid.h: Add include guard.
5357         * nat/x86-dregs.h: Rename include guard.
5358         * nat/x86-cpuid.h: Rename include guard.
5359         * nat/ppc-linux.h: Rename include guard.
5360         * nat/mips-linux-watch.h: Rename include guard.
5361         * nat/linux-waitpid.h: Rename include guard.
5362         * nat/linux-ptrace.h: Rename include guard.
5363         * nat/linux-procfs.h: Rename include guard.
5364         * nat/linux-osdata.h: Rename include guard.
5365         * nat/linux-nat.h: Rename include guard.
5366         * nat/linux-namespaces.h: Rename include guard.
5367         * nat/linux-btrace.h: Rename include guard.
5368         * nat/glibc_thread_db.h: Rename include guard.
5369         * nat/gdb_thread_db.h: Rename include guard.
5370         * nat/gdb_ptrace.h: Rename include guard.
5371         * nat/fork-inferior.h: Rename include guard.
5372         * nat/amd64-linux-siginfo.h: Rename include guard.
5373         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
5374         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
5375         * nat/aarch64-linux.h: Rename include guard.
5376         * nat/aarch64-linux-hw-point.h: Rename include guard.
5377         * mn10300-tdep.h: Add include guard.
5378         * mips-linux-tdep.h: Add include guard.
5379         * mi/mi-parse.h: Rename include guard.
5380         * mi/mi-out.h: Rename include guard.
5381         * mi/mi-main.h: Rename include guard.
5382         * mi/mi-interp.h: Rename include guard.
5383         * mi/mi-getopt.h: Rename include guard.
5384         * mi/mi-console.h: Rename include guard.
5385         * mi/mi-common.h: Rename include guard.
5386         * mi/mi-cmds.h: Rename include guard.
5387         * mi/mi-cmd-break.h: Rename include guard.
5388         * m2-lang.h: Add include guard.
5389         * location.h: Rename include guard.
5390         * linux-record.h: Rename include guard.
5391         * linux-nat.h: Add include guard.
5392         * linux-fork.h: Add include guard.
5393         * i386-darwin-tdep.h: Rename include guard.
5394         * hppa-linux-offsets.h: Add include guard.
5395         * guile/guile.h: Rename include guard.
5396         * guile/guile-internal.h: Rename include guard.
5397         * gnu-nat.h: Rename include guard.
5398         * gdb-stabs.h: Rename include guard.
5399         * frv-tdep.h: Add include guard.
5400         * f-lang.h: Add include guard.
5401         * event-loop.h: Add include guard.
5402         * darwin-nat.h: Rename include guard.
5403         * cp-abi.h: Rename include guard.
5404         * config/sparc/nm-sol2.h: Rename include guard.
5405         * config/nm-nto.h: Rename include guard.
5406         * config/nm-linux.h: Add include guard.
5407         * config/i386/nm-i386gnu.h: Rename include guard.
5408         * config/djgpp/nl_types.h: Rename include guard.
5409         * config/djgpp/langinfo.h: Rename include guard.
5410         * compile/gcc-cp-plugin.h: Add include guard.
5411         * compile/gcc-c-plugin.h: Add include guard.
5412         * compile/compile.h: Rename include guard.
5413         * compile/compile-object-run.h: Rename include guard.
5414         * compile/compile-object-load.h: Rename include guard.
5415         * compile/compile-internal.h: Rename include guard.
5416         * compile/compile-cplus.h: Rename include guard.
5417         * compile/compile-c.h: Rename include guard.
5418         * common/xml-utils.h: Rename include guard.
5419         * common/x86-xstate.h: Rename include guard.
5420         * common/version.h: Rename include guard.
5421         * common/vec.h: Rename include guard.
5422         * common/tdesc.h: Rename include guard.
5423         * common/selftest.h: Rename include guard.
5424         * common/scoped_restore.h: Rename include guard.
5425         * common/scoped_mmap.h: Rename include guard.
5426         * common/scoped_fd.h: Rename include guard.
5427         * common/safe-iterator.h: Rename include guard.
5428         * common/run-time-clock.h: Rename include guard.
5429         * common/refcounted-object.h: Rename include guard.
5430         * common/queue.h: Rename include guard.
5431         * common/ptid.h: Rename include guard.
5432         * common/print-utils.h: Rename include guard.
5433         * common/preprocessor.h: Rename include guard.
5434         * common/pathstuff.h: Rename include guard.
5435         * common/observable.h: Rename include guard.
5436         * common/netstuff.h: Rename include guard.
5437         * common/job-control.h: Rename include guard.
5438         * common/host-defs.h: Rename include guard.
5439         * common/gdb_wait.h: Rename include guard.
5440         * common/gdb_vecs.h: Rename include guard.
5441         * common/gdb_unlinker.h: Rename include guard.
5442         * common/gdb_unique_ptr.h: Rename include guard.
5443         * common/gdb_tilde_expand.h: Rename include guard.
5444         * common/gdb_sys_time.h: Rename include guard.
5445         * common/gdb_string_view.h: Rename include guard.
5446         * common/gdb_splay_tree.h: Rename include guard.
5447         * common/gdb_setjmp.h: Rename include guard.
5448         * common/gdb_ref_ptr.h: Rename include guard.
5449         * common/gdb_optional.h: Rename include guard.
5450         * common/gdb_locale.h: Rename include guard.
5451         * common/gdb_assert.h: Rename include guard.
5452         * common/filtered-iterator.h: Rename include guard.
5453         * common/filestuff.h: Rename include guard.
5454         * common/fileio.h: Rename include guard.
5455         * common/environ.h: Rename include guard.
5456         * common/common-utils.h: Rename include guard.
5457         * common/common-types.h: Rename include guard.
5458         * common/common-regcache.h: Rename include guard.
5459         * common/common-inferior.h: Rename include guard.
5460         * common/common-gdbthread.h: Rename include guard.
5461         * common/common-exceptions.h: Rename include guard.
5462         * common/common-defs.h: Rename include guard.
5463         * common/common-debug.h: Rename include guard.
5464         * common/cleanups.h: Rename include guard.
5465         * common/buffer.h: Rename include guard.
5466         * common/btrace-common.h: Rename include guard.
5467         * common/break-common.h: Rename include guard.
5468         * cli/cli-utils.h: Rename include guard.
5469         * cli/cli-style.h: Rename include guard.
5470         * cli/cli-setshow.h: Rename include guard.
5471         * cli/cli-script.h: Rename include guard.
5472         * cli/cli-interp.h: Rename include guard.
5473         * cli/cli-decode.h: Rename include guard.
5474         * cli/cli-cmds.h: Rename include guard.
5475         * charset-list.h: Add include guard.
5476         * buildsym-legacy.h: Rename include guard.
5477         * bfin-tdep.h: Add include guard.
5478         * ax.h: Rename include guard.
5479         * arm-linux-tdep.h: Add include guard.
5480         * arm-fbsd-tdep.h: Add include guard.
5481         * arch/xtensa.h: Rename include guard.
5482         * arch/tic6x.h: Add include guard.
5483         * arch/i386.h: Add include guard.
5484         * arch/arm.h: Rename include guard.
5485         * arch/arm-linux.h: Rename include guard.
5486         * arch/arm-get-next-pcs.h: Rename include guard.
5487         * arch/amd64.h: Add include guard.
5488         * arch/aarch64-insn.h: Rename include guard.
5489         * arch-utils.h: Rename include guard.
5490         * annotate.h: Add include guard.
5491         * amd64-darwin-tdep.h: Rename include guard.
5492         * aarch64-linux-tdep.h: Add include guard.
5493         * aarch64-fbsd-tdep.h: Add include guard.
5494         * aarch32-linux-nat.h: Add include guard.
5495
5496 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5497
5498         * macrotab.c (macro_define_internal): New function that
5499         factorizes macro_define_object_internal and macro_define_function
5500         code.
5501         (macro_define_object_internal): Use macro_define_internal.
5502         (macro_define_function): Likewise.
5503
5504 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5505
5506         * macrocmd.c (extract_identifier): Return
5507         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5508         callers.
5509
5510 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5511
5512         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5513
5514 2019-02-05  Tom Tromey  <tom@tromey.com>
5515
5516         * target.c (target_stack::unpush): Move assertion earlier.
5517
5518 2019-01-30  Tom Tromey  <tom@tromey.com>
5519
5520         PR python/23615:
5521         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5522         (gdbpy_parse_and_eval): Likewise.
5523         * python/python-internal.h (gdbpy_allow_threads): New class.
5524
5525 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5526
5527         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5528         (aarch64_fbsd_fpregmap): Move earlier.
5529         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5530         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5531         instead of individual calls to trad_frame_set_reg_addr.
5532         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5533         earlier.
5534         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5535         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5536         instead of individual calls to trad_frame_set_reg_addr.
5537
5538 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5539
5540         * CONTRIBUTE: Replace contribution list with wiki link.
5541
5542 2019-01-25  Tom Tromey  <tom@tromey.com>
5543
5544         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5545
5546 2019-01-25  Tom Tromey  <tom@tromey.com>
5547
5548         * xtensa-linux-nat.c: Fix common/ includes.
5549         * xml-support.h: Fix common/ includes.
5550         * xml-support.c: Fix common/ includes.
5551         * x86-linux-nat.c: Fix common/ includes.
5552         * windows-nat.c: Fix common/ includes.
5553         * varobj.h: Fix common/ includes.
5554         * varobj.c: Fix common/ includes.
5555         * value.c: Fix common/ includes.
5556         * valops.c: Fix common/ includes.
5557         * utils.c: Fix common/ includes.
5558         * unittests/xml-utils-selftests.c: Fix common/ includes.
5559         * unittests/utils-selftests.c: Fix common/ includes.
5560         * unittests/unpack-selftests.c: Fix common/ includes.
5561         * unittests/tracepoint-selftests.c: Fix common/ includes.
5562         * unittests/style-selftests.c: Fix common/ includes.
5563         * unittests/string_view-selftests.c: Fix common/ includes.
5564         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5565         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5566         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5567         * unittests/rsp-low-selftests.c: Fix common/ includes.
5568         * unittests/parse-connection-spec-selftests.c: Fix common/
5569         includes.
5570         * unittests/optional-selftests.c: Fix common/ includes.
5571         * unittests/offset-type-selftests.c: Fix common/ includes.
5572         * unittests/observable-selftests.c: Fix common/ includes.
5573         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5574         * unittests/memrange-selftests.c: Fix common/ includes.
5575         * unittests/memory-map-selftests.c: Fix common/ includes.
5576         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5577         * unittests/function-view-selftests.c: Fix common/ includes.
5578         * unittests/environ-selftests.c: Fix common/ includes.
5579         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5580         * unittests/common-utils-selftests.c: Fix common/ includes.
5581         * unittests/cli-utils-selftests.c: Fix common/ includes.
5582         * unittests/array-view-selftests.c: Fix common/ includes.
5583         * ui-file.c: Fix common/ includes.
5584         * tui/tui-io.c: Fix common/ includes.
5585         * tracepoint.h: Fix common/ includes.
5586         * tracepoint.c: Fix common/ includes.
5587         * tracefile-tfile.c: Fix common/ includes.
5588         * top.h: Fix common/ includes.
5589         * top.c: Fix common/ includes.
5590         * thread.c: Fix common/ includes.
5591         * target/waitstatus.h: Fix common/ includes.
5592         * target/waitstatus.c: Fix common/ includes.
5593         * target.h: Fix common/ includes.
5594         * target.c: Fix common/ includes.
5595         * target-memory.c: Fix common/ includes.
5596         * target-descriptions.c: Fix common/ includes.
5597         * symtab.h: Fix common/ includes.
5598         * symfile.c: Fix common/ includes.
5599         * stap-probe.c: Fix common/ includes.
5600         * spu-linux-nat.c: Fix common/ includes.
5601         * sparc-nat.c: Fix common/ includes.
5602         * source.c: Fix common/ includes.
5603         * solib.c: Fix common/ includes.
5604         * solib-target.c: Fix common/ includes.
5605         * ser-unix.c: Fix common/ includes.
5606         * ser-tcp.c: Fix common/ includes.
5607         * ser-pipe.c: Fix common/ includes.
5608         * ser-base.c: Fix common/ includes.
5609         * selftest-arch.c: Fix common/ includes.
5610         * s12z-tdep.c: Fix common/ includes.
5611         * rust-exp.y: Fix common/ includes.
5612         * rs6000-aix-tdep.c: Fix common/ includes.
5613         * riscv-tdep.c: Fix common/ includes.
5614         * remote.c: Fix common/ includes.
5615         * remote-notif.h: Fix common/ includes.
5616         * remote-fileio.h: Fix common/ includes.
5617         * remote-fileio.c: Fix common/ includes.
5618         * regcache.h: Fix common/ includes.
5619         * regcache.c: Fix common/ includes.
5620         * record-btrace.c: Fix common/ includes.
5621         * python/python.c: Fix common/ includes.
5622         * python/py-type.c: Fix common/ includes.
5623         * python/py-inferior.c: Fix common/ includes.
5624         * progspace.h: Fix common/ includes.
5625         * producer.c: Fix common/ includes.
5626         * procfs.c: Fix common/ includes.
5627         * proc-api.c: Fix common/ includes.
5628         * printcmd.c: Fix common/ includes.
5629         * ppc-linux-nat.c: Fix common/ includes.
5630         * parser-defs.h: Fix common/ includes.
5631         * osdata.c: Fix common/ includes.
5632         * obsd-nat.c: Fix common/ includes.
5633         * nat/x86-linux.c: Fix common/ includes.
5634         * nat/x86-linux-dregs.c: Fix common/ includes.
5635         * nat/x86-dregs.h: Fix common/ includes.
5636         * nat/x86-dregs.c: Fix common/ includes.
5637         * nat/ppc-linux.c: Fix common/ includes.
5638         * nat/mips-linux-watch.h: Fix common/ includes.
5639         * nat/mips-linux-watch.c: Fix common/ includes.
5640         * nat/linux-waitpid.c: Fix common/ includes.
5641         * nat/linux-ptrace.h: Fix common/ includes.
5642         * nat/linux-ptrace.c: Fix common/ includes.
5643         * nat/linux-procfs.c: Fix common/ includes.
5644         * nat/linux-personality.c: Fix common/ includes.
5645         * nat/linux-osdata.c: Fix common/ includes.
5646         * nat/linux-namespaces.c: Fix common/ includes.
5647         * nat/linux-btrace.h: Fix common/ includes.
5648         * nat/linux-btrace.c: Fix common/ includes.
5649         * nat/fork-inferior.c: Fix common/ includes.
5650         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5651         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5652         * nat/aarch64-linux.c: Fix common/ includes.
5653         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5654         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5655         * namespace.h: Fix common/ includes.
5656         * mips-linux-tdep.c: Fix common/ includes.
5657         * minsyms.c: Fix common/ includes.
5658         * mi/mi-parse.h: Fix common/ includes.
5659         * mi/mi-main.c: Fix common/ includes.
5660         * mi/mi-cmd-env.c: Fix common/ includes.
5661         * memrange.h: Fix common/ includes.
5662         * memattr.c: Fix common/ includes.
5663         * maint.h: Fix common/ includes.
5664         * maint.c: Fix common/ includes.
5665         * main.c: Fix common/ includes.
5666         * machoread.c: Fix common/ includes.
5667         * location.c: Fix common/ includes.
5668         * linux-thread-db.c: Fix common/ includes.
5669         * linux-nat.c: Fix common/ includes.
5670         * linux-fork.c: Fix common/ includes.
5671         * inline-frame.c: Fix common/ includes.
5672         * infrun.c: Fix common/ includes.
5673         * inflow.c: Fix common/ includes.
5674         * inferior.h: Fix common/ includes.
5675         * inferior.c: Fix common/ includes.
5676         * infcmd.c: Fix common/ includes.
5677         * inf-ptrace.c: Fix common/ includes.
5678         * inf-child.c: Fix common/ includes.
5679         * ia64-linux-nat.c: Fix common/ includes.
5680         * i387-tdep.c: Fix common/ includes.
5681         * i386-tdep.c: Fix common/ includes.
5682         * i386-linux-tdep.c: Fix common/ includes.
5683         * i386-linux-nat.c: Fix common/ includes.
5684         * i386-go32-tdep.c: Fix common/ includes.
5685         * i386-fbsd-tdep.c: Fix common/ includes.
5686         * i386-fbsd-nat.c: Fix common/ includes.
5687         * guile/scm-type.c: Fix common/ includes.
5688         * guile/guile.c: Fix common/ includes.
5689         * go32-nat.c: Fix common/ includes.
5690         * gnu-nat.c: Fix common/ includes.
5691         * gdbthread.h: Fix common/ includes.
5692         * gdbarch-selftests.c: Fix common/ includes.
5693         * gdb_usleep.c: Fix common/ includes.
5694         * gdb_select.h: Fix common/ includes.
5695         * gdb_bfd.c: Fix common/ includes.
5696         * gcore.c: Fix common/ includes.
5697         * fork-child.c: Fix common/ includes.
5698         * findvar.c: Fix common/ includes.
5699         * fbsd-nat.c: Fix common/ includes.
5700         * event-top.c: Fix common/ includes.
5701         * event-loop.c: Fix common/ includes.
5702         * dwarf2read.c: Fix common/ includes.
5703         * dwarf2loc.c: Fix common/ includes.
5704         * dwarf2-frame.c: Fix common/ includes.
5705         * dwarf-index-cache.c: Fix common/ includes.
5706         * dtrace-probe.c: Fix common/ includes.
5707         * disasm-selftests.c: Fix common/ includes.
5708         * defs.h: Fix common/ includes.
5709         * csky-tdep.c: Fix common/ includes.
5710         * cp-valprint.c: Fix common/ includes.
5711         * cp-support.h: Fix common/ includes.
5712         * cp-support.c: Fix common/ includes.
5713         * corelow.c: Fix common/ includes.
5714         * completer.h: Fix common/ includes.
5715         * completer.c: Fix common/ includes.
5716         * compile/compile.c: Fix common/ includes.
5717         * compile/compile-loc2c.c: Fix common/ includes.
5718         * compile/compile-cplus-types.c: Fix common/ includes.
5719         * compile/compile-cplus-symbols.c: Fix common/ includes.
5720         * command.h: Fix common/ includes.
5721         * cli/cli-dump.c: Fix common/ includes.
5722         * cli/cli-cmds.c: Fix common/ includes.
5723         * charset.c: Fix common/ includes.
5724         * build-id.c: Fix common/ includes.
5725         * btrace.h: Fix common/ includes.
5726         * btrace.c: Fix common/ includes.
5727         * breakpoint.h: Fix common/ includes.
5728         * breakpoint.c: Fix common/ includes.
5729         * ax.h:
5730         (enum agent_op): Fix common/ includes.
5731         * ax-general.c (struct aop_map): Fix common/ includes.
5732         * ax-gdb.c: Fix common/ includes.
5733         * auxv.c: Fix common/ includes.
5734         * auto-load.c: Fix common/ includes.
5735         * arm-tdep.c: Fix common/ includes.
5736         * arch/riscv.c: Fix common/ includes.
5737         * arch/ppc-linux-common.c: Fix common/ includes.
5738         * arch/i386.c: Fix common/ includes.
5739         * arch/arm.c: Fix common/ includes.
5740         * arch/arm-linux.c: Fix common/ includes.
5741         * arch/arm-get-next-pcs.c: Fix common/ includes.
5742         * arch/amd64.c: Fix common/ includes.
5743         * arch/aarch64.c: Fix common/ includes.
5744         * arch/aarch64-insn.c: Fix common/ includes.
5745         * arch-utils.c: Fix common/ includes.
5746         * amd64-windows-tdep.c: Fix common/ includes.
5747         * amd64-tdep.c: Fix common/ includes.
5748         * amd64-sol2-tdep.c: Fix common/ includes.
5749         * amd64-obsd-tdep.c: Fix common/ includes.
5750         * amd64-nbsd-tdep.c: Fix common/ includes.
5751         * amd64-linux-tdep.c: Fix common/ includes.
5752         * amd64-linux-nat.c: Fix common/ includes.
5753         * amd64-fbsd-tdep.c: Fix common/ includes.
5754         * amd64-fbsd-nat.c: Fix common/ includes.
5755         * amd64-dicos-tdep.c: Fix common/ includes.
5756         * amd64-darwin-tdep.c: Fix common/ includes.
5757         * agent.c: Fix common/ includes.
5758         * ada-lang.h: Fix common/ includes.
5759         * ada-lang.c: Fix common/ includes.
5760         * aarch64-tdep.c: Fix common/ includes.
5761
5762 2019-01-25  Tom Tromey  <tom@tromey.com>
5763
5764         * common/create-version.sh: Use common/version.h.
5765
5766 2019-01-24  Pedro Alves  <palves@redhat.com>
5767
5768         * infrun.c (signal_stop, signal_print, signal_program)
5769         (signal_catch, signal_pass): Now arrays instead of pointers.
5770         (update_signals_program_target, do_target_resume)
5771         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5772         * linux-nat.c (linux_nat_target::pass_signals)
5773         (linux_nat_target::create_inferior, linux_nat_target::attach):
5774         Adjust.
5775         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5776         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5777         * procfs.c (procfs_target::pass_signals): Adjust.
5778         * record-full.c (record_full_target::resume): Adjust.
5779         * remote.c (remote_target::pass_signals)
5780         (remote_target::program_signals): Adjust.
5781         * target-debug.h (target_debug_print_signals): Now takes a
5782         gdb::array_view as parameter.  Adjust.
5783         * target.h (target_ops) <pass_signals, program_signals>: Replace
5784         pointer and length parameters with gdb::array_view.
5785         (target_pass_signals, target_program_signals): Likewise.
5786         * target-delegates.c: Regenerate.
5787
5788 2019-01-24  Pedro Alves  <palves@redhat.com>
5789
5790         * common/forward-scope-exit.h
5791         (forward_scope_exit::forward_scope_exit): Pass arguments to
5792         m_bind_function directly, instead of creating a std::bind and
5793         copying that.
5794
5795 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5796
5797         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5798         for static members.
5799         (pass_in_v_vfp_candidate): Likewise.
5800
5801 2019-01-23  Tom Tromey  <tom@tromey.com>
5802             Pedro Alves  <palves@redhat.com>
5803
5804         * regcache.c (class regcache_invalidator): Remove.
5805         (regcache::raw_write): Use make_scope_exit.
5806
5807 2019-01-23  Tom Tromey  <tom@tromey.com>
5808
5809         * ui-out.h (class ui_out_emit_type): Update comment.
5810
5811 2019-01-23  Tom Tromey  <tom@tromey.com>
5812
5813         * infrun.c (fetch_inferior_event): Update comment.
5814
5815 2019-01-23  Tom Tromey  <tom@tromey.com>
5816             Pedro Alves  <palves@redhat.com>
5817
5818         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5819         parameter.
5820         (fetch_inferior_event): Use SCOPE_EXIT.
5821
5822
5823 2019-01-23  Tom Tromey  <tom@tromey.com>
5824             Pedro Alves  <palves@redhat.com>
5825
5826         * infrun.c (disable_thread_events): Delete.
5827         (stop_all_threads): Use SCOPE_EXIT.
5828
5829 2019-01-23  Tom Tromey  <tom@tromey.com>
5830             Pedro Alves  <palves@redhat.com>
5831
5832         * symfile.c: Include forward-scope-exit.h.
5833         (clear_symtab_users_cleanup): Replace forward declaration with
5834         a FORWARD_SCOPE_EXIT.
5835         (syms_from_objfile_1): Use the forward_scope_exit and
5836         gdb::optional instead of cleanup_function.
5837         (reread_symbols): Use the forward_scope_exit instead of
5838         cleanup_function.
5839         (clear_symtab_users_cleanup): Remove function.
5840
5841 2019-01-23  Tom Tromey  <tom@tromey.com>
5842             Pedro Alves  <palves@redhat.com>
5843
5844         * linux-nat.c: Include scope-exit.h.
5845         (cleanup_target_stop): Remove.
5846         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5847         SCOPE_EXIT.
5848
5849 2019-01-23  Tom Tromey  <tom@tromey.com>
5850             Pedro Alves  <palves@redhat.com>
5851
5852         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5853         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5854
5855 2019-01-23  Tom Tromey  <tom@tromey.com>
5856             Andrew Burgess  <andrew.burgess@embecosm.com>
5857             Pedro Alves  <palves@redhat.com>
5858
5859         * infrun.c (fetch_inferior_event): Use scope_exit.
5860         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5861         * top.c (execute_command): Use scope_exit.
5862         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5863         * utils.c (do_bpstat_clear_actions_cleanup)
5864         (make_bpstat_clear_actions_cleanup): Remove.
5865
5866 2019-01-23  Tom Tromey  <tom@tromey.com>
5867             Pedro Alves  <palves@redhat.com>
5868
5869         * infrun.c: Include "common/scope-exit.h"
5870         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5871         (wait_for_inferior): Use SCOPE_EXIT.
5872         (fetch_inferior_event): Use scope_exit.
5873
5874 2019-01-23  Tom Tromey  <tom@tromey.com>
5875             Pedro Alves  <palves@redhat.com>
5876
5877         * breakpoint.c (create_breakpoint): Remove cleanup.
5878
5879 2019-01-23  Tom Tromey  <tom@tromey.com>
5880             Andrew Burgess  <andrew.burgess@embecosm.com>
5881             Pedro Alves  <palves@redhat.com>
5882
5883 2019-01-23  Pedro Alves  <palves@redhat.com>
5884
5885         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5886
5887 2019-01-23  Pedro Alves  <palves@redhat.com>
5888             Andrew Burgess  <andrew.burgess@embecosm.com>
5889
5890         * gdbthread.h: Include "common/forward-scope-exit.h".
5891         (scoped_finish_thread_state): Redefine custom class in terms of
5892         forward_scope_exit.
5893
5894 2019-01-23  Pedro Alves  <palves@redhat.com>
5895             Andrew Burgess  <andrew.burgess@embecosm.com>
5896
5897         * common/forward-scope-exit.h: New file.
5898
5899 2019-01-23  Pedro Alves  <palves@redhat.com>
5900             Andrew Burgess  <andrew.burgess@embecosm.com>
5901             Tom Tromey  <tom@tromey.com>
5902
5903         * common/scope-exit.h: New file.
5904
5905 2019-01-23  Pedro Alves  <palves@redhat.com>
5906
5907         * common/preprocessor.h (ESC): Rename to ...
5908         (ESC_PARENS): ... this.
5909         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5910         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5911
5912 2019-01-23  Tom Tromey  <tom@tromey.com>
5913
5914         * language.h (class scoped_switch_to_sym_language_if_auto):
5915         Initialize m_lang in both cases.
5916
5917 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5918
5919         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5920         with XCNEW.
5921
5922 2019-01-22  Tom Tromey  <tom@tromey.com>
5923
5924         * corelow.c: Do not include sys/file.h.
5925
5926 2019-01-22  Tom Tromey  <tom@tromey.com>
5927
5928         * tui/tui-wingeneral.h: Include gdb_curses.h.
5929
5930 2019-01-22  Tom Tromey  <tom@tromey.com>
5931
5932         * source-cache.h (class source_cache) <get_source_lines,
5933         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5934
5935 2019-01-22  Tom Tromey  <tom@tromey.com>
5936
5937         * remote-fileio.h (struct remote_target): Declare.
5938
5939 2019-01-22  Tom Tromey  <tom@tromey.com>
5940
5941         * python/py-arch.c: Do not include py-ref.h.
5942         * python/py-bpevent.c: Do not include py-ref.h.
5943         * python/py-cmd.c: Do not include py-ref.h.
5944         * python/py-continueevent.c: Do not include py-ref.h.
5945         * python/py-event.h: Do not include py-ref.h.
5946         * python/py-evtregistry.c: Do not include py-ref.h.
5947         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5948         * python/py-frame.c: Do not include py-ref.h.
5949         * python/py-framefilter.c: Do not include py-ref.h.
5950         * python/py-function.c: Do not include py-ref.h.
5951         * python/py-infevents.c: Do not include py-ref.h.
5952         * python/py-linetable.c: Do not include py-ref.h.
5953         * python/py-objfile.c: Do not include py-ref.h.
5954         * python/py-param.c: Do not include py-ref.h.
5955         * python/py-prettyprint.c: Do not include py-ref.h.
5956         * python/py-progspace.c: Do not include py-ref.h.
5957         * python/py-symbol.c: Do not include py-ref.h.
5958         * python/py-symtab.c: Do not include py-ref.h.
5959         * python/py-type.c: Do not include py-ref.h.
5960         * python/py-unwind.c: Do not include py-ref.h.
5961         * python/py-utils.c: Do not include py-ref.h.
5962         * python/py-value.c: Do not include py-ref.h.
5963         * python/py-varobj.c: Do not include py-ref.h.
5964         * python/py-xmethods.c: Do not include py-ref.h.
5965         * python/python.c: Do not include py-ref.h.
5966         * varobj.c: Do not include py-ref.h.
5967
5968 2019-01-22  Tom Tromey  <tom@tromey.com>
5969
5970         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5971         keyword for bcache.
5972
5973 2019-01-22  Tom Tromey  <tom@tromey.com>
5974
5975         * compile/compile-cplus-types.c: Remove a comment by #include.
5976
5977 2019-01-22  Tom Tromey  <tom@tromey.com>
5978
5979         * compile/gcc-c-plugin.h: Include compile-internal.h.
5980
5981 2019-01-22  Tom Tromey  <tom@tromey.com>
5982
5983         * stabsread.c (EXTERN): Do not define.
5984         (symnum, next_symbol_text_func, processing_gcc_compilation)
5985         (within_function, global_sym_chain, global_stabs)
5986         (previous_stab_code, this_object_header_files)
5987         (n_this_object_header_files)
5988         (n_allocated_this_object_header_files): Define.
5989         * stabsread.h (EXTERN): Never define.  Use "extern".
5990
5991 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5992
5993         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5994         history_value.
5995
5996 2019-01-21  Tom Tromey  <tom@tromey.com>
5997
5998         * ui-out.c: Fix includes.
5999         * tui/tui-source.c: Fix includes.
6000         * target.c: Fix includes.
6001         * remote.c: Fix includes.
6002         * regcache.c: Fix includes.
6003         * python/py-block.c: Fix includes.
6004         * printcmd.c: Fix includes.
6005         * or1k-tdep.c: Fix includes.
6006         * mi/mi-main.c: Fix includes.
6007         * m32r-tdep.c: Fix includes.
6008         * csky-tdep.c: Fix includes.
6009         * compile/compile-cplus-types.c: Fix includes.
6010         * cli/cli-interp.c: Fix includes.
6011
6012 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
6013
6014         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6015         for padding.
6016
6017 2019-01-16  Tom Tromey  <tom@tromey.com>
6018
6019         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
6020         earlier.
6021         (struct objfile) <msymbols_range>: Move from top level.
6022         <msymbols>: New method.
6023         (class objfile_msymbols): Remove.
6024         * symtab.c (default_collect_symbol_completion_matches_break_on):
6025         Update.
6026         * symmisc.c (dump_msymbols): Update.
6027         * stabsread.c (scan_file_globals): Update.
6028         * objc-lang.c (info_selectors_command, info_classes_command)
6029         (find_methods): Update.
6030         * minsyms.c (find_solib_trampoline_target): Update.
6031         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
6032         * coffread.c (coff_symfile_read): Update.
6033         * ada-lang.c (ada_lookup_simple_minsym)
6034         (ada_collect_symbol_completion_matches): Update.
6035
6036 2019-01-16  Tom Tromey  <tom@tromey.com>
6037
6038         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
6039         type.  Remove no-argument constructor.
6040         <iterator::operator++>: Simplify.
6041         <begin>: Update.
6042         <end>: Use minimal_symbol_count.
6043
6044 2019-01-16  Tom Tromey  <tom@tromey.com>
6045
6046         * objfiles.h (struct objfile) <psymtabs>: New method.
6047         (class objfile_psymtabs): Remove.
6048         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
6049         typedef.
6050         <range>: New method.
6051         (require_partial_symbols): Change return type.
6052         * psymtab.c (require_partial_symbols)
6053         (psym_expand_symtabs_matching): Update.
6054         * mdebugread.c (parse_partial_symbols): Update.
6055         * dbxread.c (dbx_end_psymtab): Update.
6056
6057 2019-01-15  Tom Tromey  <tom@tromey.com>
6058
6059         * symtab.c (lookup_objfile_from_block)
6060         (lookup_symbol_in_objfile_symtabs)
6061         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
6062         (find_line_symtab, info_sources_command)
6063         (default_collect_symbol_completion_matches_break_on)
6064         (make_source_files_completion_list): Update.
6065         * symmisc.c (print_objfile_statistics, dump_objfile)
6066         (maintenance_print_symbols, maintenance_info_symtabs)
6067         (maintenance_check_symtabs, maintenance_info_line_tables):
6068         Update.
6069         * source.c (select_source_symtab)
6070         (forget_cached_source_info_for_objfile): Update.
6071         * objfiles.h (class objfile_compunits): Remove.
6072         (struct objfile) <compunits_range>: New typedef.
6073         (compunits): New method.
6074         * objfiles.c (objfile_relocate1): Update.
6075         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6076         * maint.c (count_symtabs_and_blocks): Update.
6077         * linespec.c (iterate_over_all_matching_symtabs): Update.
6078         * cp-support.c (add_symbol_overload_list_qualified): Update.
6079         * coffread.c (coff_symtab_read): Update.
6080         * ada-lang.c (add_nonlocal_symbols)
6081         (ada_collect_symbol_completion_matches)
6082         (ada_add_global_exceptions): Update.
6083
6084 2019-01-15  Tom Tromey  <tom@tromey.com>
6085
6086         * progspace.h (program_space) <objfiles_safe_range>: New
6087         typedef.
6088         <objfiles_safe>: New method.
6089         * objfiles.h (class all_objfiles_safe): Remove.
6090         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
6091         * jit.c (jit_inferior_exit_hook): Update.
6092
6093 2019-01-17  Tom Tromey  <tom@tromey.com>
6094
6095         * progspace.h (program_space) <objfiles_range>: New typedef.
6096         <objfiles>: New method.
6097         <objfiles_head>: Rename from objfiles.
6098         (object_files): Update.
6099         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
6100         * guile/scm-pretty-print.c
6101         (ppscm_find_pretty_printer_from_objfiles): Update.
6102         * guile/scm-objfile.c (gdbscm_objfiles): Update.
6103         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
6104         Update.
6105         * python/py-progspace.c (pspy_get_objfiles): Update.
6106         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6107         Update.
6108         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6109         (objfpy_lookup_objfile_by_build_id): Update.
6110         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6111         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6112         Update.
6113         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6114         (expand_symtab_containing_pc, lookup_objfile_from_block)
6115         (lookup_static_symbol, basic_lookup_transparent_type)
6116         (find_pc_sect_compunit_symtab, find_symbol_at_address)
6117         (find_line_symtab, info_sources_command)
6118         (default_collect_symbol_completion_matches_break_on)
6119         (make_source_files_completion_list, find_main_name): Update.
6120         * symmisc.c (print_symbol_bcache_statistics)
6121         (print_objfile_statistics, maintenance_print_symbols)
6122         (maintenance_print_msymbols, maintenance_print_objfiles)
6123         (maintenance_info_symtabs, maintenance_check_symtabs)
6124         (maintenance_expand_symtabs, maintenance_info_line_tables):
6125         Update.
6126         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
6127         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
6128         (map_overlay_command, unmap_overlay_command)
6129         (simple_overlay_update, expand_symtabs_matching)
6130         (map_symbol_filenames): Update.
6131         * symfile-debug.c (set_debug_symfile): Update.
6132         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
6133         Update.
6134         * source.c (select_source_symtab, forget_cached_source_info):
6135         Update.
6136         * solib.c (solib_read_symbols): Update.
6137         * solib-spu.c (append_ocl_sos): Update.
6138         * psymtab.c (maintenance_print_psymbols)
6139         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
6140         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
6141         * printcmd.c (info_symbol_command): Update.
6142         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
6143         Update.
6144         * objfiles.h (class all_objfiles): Remove.
6145         * objfiles.c (have_partial_symbols, have_full_symbols)
6146         (have_minimal_symbols, qsort_cmp, update_section_map)
6147         (shared_objfile_contains_address_p)
6148         (default_iterate_over_objfiles_in_search_order): Update.
6149         * objc-lang.c (info_selectors_command, info_classes_command)
6150         (find_methods): Update.
6151         * minsyms.c (find_solib_trampoline_target): Update.
6152         * maint.c (maintenance_info_sections)
6153         (maintenance_translate_address, count_symtabs_and_blocks):
6154         Update.
6155         * main.c (captured_main_1): Update.
6156         * linux-thread-db.c (try_thread_db_load_from_pdir)
6157         (has_libpthread): Update.
6158         * linespec.c (iterate_over_all_matching_symtabs)
6159         (search_minsyms_for_name): Update.
6160         * jit.c (jit_find_objf_with_entry_addr): Update.
6161         * hppa-tdep.c (find_unwind_entry)
6162         (hppa_lookup_stub_minimal_symbol): Update.
6163         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
6164         Update.
6165         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6166         (elf_gnu_ifunc_resolve_by_got): Update.
6167         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
6168         * dwarf-index-write.c (save_gdb_index_command): Update.
6169         * cp-support.c (add_symbol_overload_list_qualified): Update.
6170         * breakpoint.c (create_overlay_event_breakpoint)
6171         (create_longjmp_master_breakpoint)
6172         (create_std_terminate_master_breakpoint)
6173         (create_exception_master_breakpoint): Update.
6174         * blockframe.c (find_pc_partial_function): Update.
6175         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
6176         (ada_collect_symbol_completion_matches)
6177         (ada_add_global_exceptions): Update.
6178
6179 2019-01-17  Tom Tromey  <tom@tromey.com>
6180
6181         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
6182         declare VEC.
6183         (solib_target_parse_libraries): Change return type.
6184         (library_list_start_segment, library_list_start_section)
6185         (library_list_end_library, library_list_start_library); Update.
6186         (solib_target_free_library_list): Remove.
6187         (solib_target_parse_libraries): Remove cleanup.  Change return
6188         type.
6189         (solib_target_current_sos): Update.
6190
6191 2019-01-17  Tom Tromey  <tromey@bapiya>
6192
6193         * valprint.c: Replace "the the" with "the".
6194         * symtab.c: Replace "the the" with "the".
6195         * solib.c: Replace "the the" with "the".
6196         * solib-dsbt.c: Replace "the the" with "the".
6197         * linespec.c: Replace "the the" with "the".
6198         * dwarf2loc.h: Replace "the the" with "the".
6199         * amd64-windows-tdep.c: Replace "the the" with "the".
6200         * aarch64-tdep.c: Replace "the the" with "the".
6201
6202 2019-01-16  Keith Seitz  <keiths@redhat.com>
6203
6204         PR gdb/23773
6205         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
6206         <builder>: Rename to ..
6207         <m_builder>: ... this and make private.
6208         (dwarf2_cu::get_builder): New method.  Change all users of
6209         `builder' to use this method.
6210         (dwarf2_start_symtab): Move to ...
6211         (dwarf2_cu::start_symtab): ... here.  Update all callers
6212         (setup_type_unit_groups): Move to ...
6213         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
6214         callers.
6215         (dwarf2_cu::reset_builder): New method.
6216         (process_full_compunit, process_full_type_unit): Use
6217         dwarf2_cu::reset_builder.
6218         (follow_die_offset): Record the ancestor CU if it is different
6219         from the followed DIE's CU.
6220         (follow_die_sig_1): Likewise.
6221
6222 2019-01-15  Tom Tromey  <tom@tromey.com>
6223
6224         * remote.c (class remote_state) <buf>: Now a char_vector.
6225         <buf_size>: Remove.
6226         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
6227         parameter.
6228         (remote_target::getpkt_or_notif_sane_1)
6229         (remote_target::getpkt_sane)
6230         (remote_target::getpkt_or_notif_sane): Likewise.
6231         (class remote_target) <putpkt>: New overload.
6232         (remote_target::read_frame): Change type of "buf_p".  Remove
6233         sizeof_p parameter.
6234         (packet_ok): New overload.
6235         (packet_check_result): New overload.
6236         Update all uses.
6237
6238 2019-01-14  Tom Tromey  <tom@tromey.com>
6239
6240         * remote-notif.c (handle_notification, remote_notif_ack)
6241         (remote_notif_parse): Make "buf" const.
6242         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
6243         const.
6244         (remote_notif_parse, remote_notif_ack, handle_notification):
6245         Likewise.
6246         * remote.c (remote_notif_stop_parse): Make "buf" const.
6247         (remote_target::remote_parse_stop_reply): Make "buf" const.
6248         (remote_notif_stop_ack): Make "buf" const.
6249
6250 2019-01-14  Tom Tromey  <tom@tromey.com>
6251
6252         * remote.c (remote_console_output): Make parameter const.
6253
6254 2019-01-14  Tom Tromey  <tom@tromey.com>
6255
6256         * target-debug.h (target_debug_print_signals): Constify.
6257         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
6258         * procfs.c (procfs_target::pass_signals): Update.
6259         * linux-nat.c (linux_nat_target::pass_signals): Update.
6260         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
6261         * target-delegates.c: Rebuild.
6262         * remote.c (remote_target::program_signals): Update.
6263         (remote_target::pass_signals): Update.
6264         * target.c (target_pass_signals): Constify argument.
6265         (target_program_signals): Likewise.
6266         * target.h (struct target_ops) <pass_signals, program_signals>:
6267         Constify argument.
6268         (target_pass_signals, target_program_signals): Constify argument.
6269
6270 2019-01-14  Tom Tromey  <tom@tromey.com>
6271
6272         PR tui/28819:
6273         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
6274
6275 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6276
6277         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
6278         field.
6279         * rs6000-tdep.c: Include reggroups.h.
6280         (IS_V_ALIAS_PSEUDOREG): Define.
6281         (rs6000_register_name): Return names for the "vX" aliases.
6282         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
6283         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
6284         aliases.  Call default_register_reggroup_p for all other
6285         pseudo-registers.
6286         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
6287         New functions.
6288         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
6289         Handle "vX" aliases.
6290         (v_alias_pseudo_register_collect): New function.
6291         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
6292         (rs6000_gdbarch_init): Initialize "vX" aliases as
6293         pseudo-registers.  Restore registration of
6294         rs6000_pseudo_register_reggroup_p with
6295         set_tdesc_pseudo_register_reggroup_p.
6296
6297 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
6298
6299         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
6300         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
6301         set_gdbarch_num_pseudo_regs.
6302
6303 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6304
6305         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
6306         Remove arg prefixname, add do_set and do_show.
6307         Add member functions set_list and show_list.
6308         * cli/cli-style.c (class cli_style_option): Update accordingly.
6309         (style_set_list): Move to file scope.
6310         (style_show_list): Likewise.
6311         (set_style): Call help_list.
6312         (show_style): Call cmd_show_list.
6313         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
6314         Update to use the new macro.
6315
6316 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
6317
6318         * ada-lang.c (_initialize_ada_language): Expand the help text
6319         for the "catch exception" command.
6320
6321 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6322
6323         * symtab.c (matching_obj_sections): Initialize obj,
6324         declare it closer to its usage.
6325
6326 2019-01-10  Tom Tromey  <tom@tromey.com>
6327
6328         * thread-iter.h (inf_threads_iterator): Use next_iterator.
6329         (basic_inf_threads_range): Remove.
6330         (inf_threads_range, inf_non_exited_threads_range)
6331         (safe_inf_threads_range): Use next_adapter.
6332
6333 2019-01-10  Keith Seitz  <keiths@redhat.com>
6334
6335         PR gdb/23712
6336         PR symtab/23010
6337         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
6338         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
6339
6340 2019-01-10  Keith Seitz  <keiths@redhat.com>
6341
6342         PR gdb/23712
6343         PR symtab/23010
6344         * dictionary.c (pending_to_vector): Remove.
6345         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6346         Remove _1 suffix, replacing functions of the same name.  Update
6347         all callers.
6348         (dict_create_hashed, dict_create_hashed_expandable)
6349         (dict_create_linear, dict_create_linear_expandable, dict_free)
6350         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
6351         Make functions static.
6352
6353 2019-01-10  Keith Seitz  <keiths@redhat.com>
6354
6355         PR gdb/23712
6356         PR symtab/23010
6357         * dictionary.h (struct dictionary): Replace declaration with
6358         multidictionary.
6359         (dict_create_hashed, dict_create_hashed_expandable)
6360         (dict_create_linear, dict_create_linear_expandable)
6361         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
6362         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
6363         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
6364         taking multidictionary argument.
6365         [ALL_DICT_SYMBOLS]: Update for multidictionary.
6366         * block.h (struct block) <dict>: Change to multidictionary
6367         and rename `multidict'.
6368         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
6369         symmisc.c: Update all dictionary references to multidictionary.
6370
6371 2019-01-10  Keith Seitz  <keiths@redhat.com>
6372
6373         PR gdb/23712
6374         PR symtab/23010
6375         * dictionary.c: Include unordered_map.
6376         (pending_to_vector): New function.
6377         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6378         Rewrite the non-"_1" functions to take vector instead
6379         of linked list.
6380         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
6381         "new" _1 versions of the same name.
6382         (multidictionary): Define.
6383         (std::hash<enum language): New definition.
6384         (collate_pending_symbols_by_language, mdict_create_hashed)
6385         (mdict_create_hashed_expandable, mdict_create_linear)
6386         (mdict_create_linear_expandable, mdict_free)
6387         (find_language_dictionary, create_new_language_dictionary)
6388         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
6389         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
6390         (mdict_size, mdict_empty): New functions.
6391         * dictionary.h (mdict_iterator): Define.
6392
6393 2019-01-10  Pedro Alves  <palves@redhat.com>
6394
6395         * breakpoint.c (read_uploaded_action)
6396         (create_tracepoint_from_upload): Adjust to use
6397         gdb::unique_xmalloc_ptr.
6398         * ctf.c (ctf_write_uploaded_tp):
6399         (SET_ARRAY_FIELD): Use emplace_back.
6400         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
6401         * tracefile-tfile.c (tfile_write_uploaded_tp):
6402         * tracepoint.c (parse_tracepoint_definition): Adjust to use
6403         gdb::unique_xmalloc_ptr.
6404         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
6405         at_string, cond_string, cmd_strings>: Replace char pointers
6406         with gdb::unique_xmalloc_ptr.
6407
6408 2019-01-10  Pedro Alves  <palves@redhat.com>
6409
6410         * solib-target.c (library_list_start_library): Don't xstrdup name.
6411
6412 2019-01-10  Pedro Alves  <palves@redhat.com>
6413
6414         * mdebugread.c (parse_partial_symbols): Use
6415         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
6416
6417 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6418
6419         * linux-fork.c (scoped_switch_fork_info)
6420         <~scoped_switch_fork_info>: Fix incorrect variable name.
6421
6422 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6423
6424         * linux-fork.c (scoped_switch_fork_info)
6425         <scoped_switch_fork_info>: Make explicit.
6426         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
6427
6428 2019-01-10  Tom Tromey  <tom@tromey.com>
6429
6430         * objfiles.h (objfile::reset_psymtabs): Update.
6431         * objfiles.c (objfile::objfile): Update.
6432         * psymtab.h (psymtab_storage::obstack): Update.
6433         (psymtab_storage::m_obstack): Use gdb::optional.
6434         (class psymtab_storage): Update comment.  Remove objfile
6435         parameter.
6436         * psymtab.c (psymtab_storage::psymtab_storage): Update.
6437
6438 2019-01-10  Tom Tromey  <tom@tromey.com>
6439
6440         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
6441         <free_psymtabs>: Now private.
6442         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
6443         (allocate_psymtab): Use new method.
6444
6445 2019-01-10  Tom Tromey  <tom@tromey.com>
6446
6447         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
6448         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
6449         * mdebugread.c (parse_partial_symbols): Use
6450         allocate_dependencies.
6451         * dwarf2read.c (dwarf2_create_include_psymtab): Use
6452         allocate_dependencies.
6453         (process_psymtab_comp_unit_reader)
6454         (build_type_psymtab_dependencies): Likewise.
6455         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
6456
6457 2019-01-10  Tom Tromey  <tom@tromey.com>
6458
6459         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
6460         PSYMBOL_SET_LANGUAGE.
6461         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
6462
6463 2019-01-10  Tom Tromey  <tom@tromey.com>
6464
6465         * psymtab.h (psymtab_storage::obstack): New method.
6466         <m_obstack>: Rename from obstack; now private.
6467         * psymtab.c (psymtab_storage): Update.
6468         * dwarf2read.c (create_addrmap_from_index)
6469         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
6470         Update.
6471
6472 2019-01-10  Tom Tromey  <tom@tromey.com>
6473
6474         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
6475         * objfiles.h (objfile::reset_psymtabs): New method.
6476
6477 2019-01-10  Tom Tromey  <tom@tromey.com>
6478
6479         * symmisc.c (print_symbol_bcache_statistics): Update.
6480         (print_objfile_statistics): Update.
6481         * symfile.c (reread_symbols): Update.
6482         * psymtab.h (class psymtab_storage): New.
6483         * psymtab.c (psymtab_storage): New constructor.
6484         (~psymtab_storage): New destructor.
6485         (require_partial_symbols): Update.
6486         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
6487         (find_pc_sect_psymtab, find_pc_sect_psymbol)
6488         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
6489         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
6490         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
6491         (start_psymtab_common, end_psymtab_common)
6492         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
6493         (allocate_psymtab): Update.
6494         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
6495         Update.
6496         (dump_psymtab_addrmap, maintenance_print_psymbols)
6497         (maintenance_check_psymtabs): Update.
6498         (class objfile_psymtabs): Move to objfiles.h.
6499         * psympriv.h (discard_psymtab): Now inline.
6500         (psymtab_discarder::psymtab_discarder): Update.
6501         (psymtab_discarder::~psymtab_discarder): Update.
6502         (ALL_OBJFILE_PSYMTABS): Rewrite.
6503         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6504         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6505         Remove fields.
6506         <partial_symtabs>: New field.
6507         (class objfile_psymtabs): Move from psymtab.h.  Update.
6508         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6509         psymbol_cache.
6510         (objfile::~objfile): Don't destroy psymbol_cache.
6511         * mdebugread.c (parse_partial_symbols): Update.
6512         * dwarf2read.c (create_addrmap_from_index)
6513         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6514         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6515         (add_partial_subprogram, dwarf2_ranges_read): Update.
6516         * dwarf-index-write.c (write_address_map)
6517         (write_one_signatured_type, recursively_write_psymbols)
6518         (class debug_names, class debug_names, write_psymtabs_to_index):
6519         Update.
6520
6521 2019-01-10  Tom Tromey  <tom@tromey.com>
6522
6523         * symtab.h (SYMBOL_SET_NAMES): Update.
6524         (symbol_set_names): Update.
6525         (MSYMBOL_SET_NAMES): Update.
6526         * symtab.c (symbol_set_names): Change argument to be an
6527         objfile_per_bfd_storage.
6528         * psymtab.c (add_psymbol_to_bcache): Update.
6529         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6530
6531 2019-01-10  Tom Tromey  <tom@tromey.com>
6532
6533         * symtab.c (create_demangled_names_hash): Change argument to be an
6534         objfile_per_bfd_storage.
6535         (symbol_set_names): Update.
6536
6537 2019-01-10  Tom Tromey  <tom@tromey.com>
6538
6539         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6540         init_psymbol_list.
6541         * psymtab.c (init_psymbol_list): Do nothing if already called.
6542         * psympriv.h (init_psymbol_list): Add comment.
6543         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6544         init_psymbol_list.
6545         * dbxread.c (dbx_symfile_read): Unconditionally call
6546         init_psymbol_list.
6547
6548 2019-01-10  Tom Tromey  <tom@tromey.com>
6549
6550         * xcoffread.c (scan_xcoff_symtab): Update.
6551         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6552         "where".
6553         * mdebugread.c (parse_partial_symbols)
6554         (handle_psymbol_enumerators): Update.
6555         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6556         * dbxread.c (read_dbx_symtab): Update.
6557         * psympriv.h (psymbol_placement): New enum.
6558         (add_psymbol_to_list): Update.
6559
6560 2019-01-10  Tom Tromey  <tom@tromey.com>
6561
6562         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6563         static_psymbols parameters.
6564         (scan_xcoff_symtab): Update.
6565         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6566         static_psymbols parameters.
6567         * psympriv.h (start_psymtab_common): Update.
6568         * mdebugread.c (parse_partial_symbols): Update.
6569         * dwarf2read.c (create_partial_symtab): Update.
6570         * dbxread.c (read_dbx_symtab): Update.
6571         (start_psymtab): Remove global_psymbols and static_psymbols
6572         parameters.
6573
6574 2019-01-10  Tom Tromey  <tom@tromey.com>
6575
6576         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6577         * psymtab.c (allocate_psymtab): Add comment.
6578         * psympriv.h (allocate_psymtab): Add comment.
6579         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6580         initializations.
6581         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6582
6583 2019-01-10  Tom Tromey  <tom@tromey.com>
6584
6585         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6586         Don't declare.
6587         * mipsread.c: Include mdebugread.h.
6588         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6589         Declare.
6590         * elfread.c: Include mdebugread.h.
6591
6592 2019-01-09  Tom Tromey  <tom@tromey.com>
6593
6594         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6595         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6596         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6597         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6598         (psym_lookup_symbol, psym_find_last_source_symtab)
6599         (psym_forget_cached_source_info, psym_print_stats)
6600         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6601         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6602         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6603         (psym_find_compunit_symtab_by_address)
6604         (maintenance_print_psymbols, maintenance_info_psymtabs)
6605         (maintenance_check_psymtabs): Use ranged for.
6606         * psymtab.h (class objfile_psymtabs): New.
6607         (require_partial_symbols): Return objfile_psymtabs.
6608         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6609
6610 2019-01-09  Tom Tromey  <tom@tromey.com>
6611
6612         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6613         (find_pc_mapped_section, list_overlays_command)
6614         (map_overlay_command, unmap_overlay_command)
6615         (simple_overlay_update): Use all_objfiles.
6616         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6617         * printcmd.c (info_symbol_command): Use all_objfiles.
6618         * objfiles.h (ALL_OBJSECTIONS): Remove.
6619         * maint.c (maintenance_translate_address): Use all_objfiles.
6620         * gcore.c (gcore_create_callback): Use all_objfiles.
6621         (objfile_find_memory_regions): Likewise.
6622
6623 2019-01-09  Tom Tromey  <tom@tromey.com>
6624
6625         * symtab.c (find_line_symtab, info_sources_command)
6626         (make_source_files_completion_list): Use objfile_compunits.
6627         * source.c (select_source_symtab): Use objfile_compunits.
6628         * objfiles.h (struct objfile): Update comment.
6629         (ALL_OBJFILES): Remove.
6630         (ALL_FILETABS): Remove.
6631         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6632         objfile_compunits.
6633
6634 2019-01-09  Tom Tromey  <tom@tromey.com>
6635
6636         * symmisc.c (print_objfile_statistics, dump_objfile)
6637         (maintenance_print_symbols): Use compunit_filetabs.
6638         * source.c (forget_cached_source_info_for_objfile): Use
6639         compunit_filetabs.
6640         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6641         (ALL_FILETABS): Use compunit_filetabs.
6642         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6643         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6644
6645 2019-01-09  Tom Tromey  <tom@tromey.com>
6646
6647         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6648         (compunit_filetabs): New.
6649         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6650         compunit_filetabs.
6651         (info_sources_command, make_source_files_completion_list): Remove
6652         declaration.
6653         * symmisc.c (print_objfile_statistics, dump_objfile)
6654         (maintenance_print_symbols): Remove declaration.
6655         (maintenance_info_symtabs): Use compunit_filetabs.
6656         (maintenance_info_line_tables): Likewise.
6657         * source.c (select_source_symtab): Change local variable name.
6658         (forget_cached_source_info_for_objfile): Remove declaration.
6659         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6660         * objfiles.c (objfile_relocate1): Remove declaration.
6661         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6662         declaration.
6663         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6664         * coffread.c (coff_symtab_read): Remove declaration.
6665         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6666         compunit_filetabs.
6667
6668 2019-01-09  Tom Tromey  <tom@tromey.com>
6669
6670         * symtab.c (lookup_objfile_from_block)
6671         (find_pc_sect_compunit_symtab, search_symbols)
6672         (default_collect_symbol_completion_matches_break_on): Use
6673         objfile_compunits.
6674         * objfiles.h (ALL_COMPUNITS): Remove.
6675         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6676         * cp-support.c (add_symbol_overload_list_qualified): Use
6677         objfile_compunits.
6678         * ada-lang.c (ada_collect_symbol_completion_matches)
6679         (ada_add_global_exceptions): Use objfile_compunits.
6680
6681 2019-01-09  Tom Tromey  <tom@tromey.com>
6682
6683         * source.c (select_source_symtab)
6684         (forget_cached_source_info_for_objfile): Remove declaration.
6685         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6686         declaration.
6687         * maint.c (count_symtabs_and_blocks): Remove declaration.
6688         * cp-support.c (add_symbol_overload_list_qualified): Remove
6689         declaration.
6690         * coffread.c (coff_symtab_read): Remove declaration.
6691         * symtab.c (lookup_symbol_in_objfile_symtabs)
6692         (basic_lookup_transparent_type_1): Use objfile_compunits.
6693         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6694         (info_sources_command, search_symbols)
6695         (default_collect_symbol_completion_matches_break_on)
6696         (make_source_files_completion_list): Remove declaration.
6697         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6698         (ada_collect_symbol_completion_matches)
6699         (ada_add_global_exceptions): Remove declaration.
6700         * linespec.c (iterate_over_all_matching_symtabs): Use
6701         objfile_compunits.
6702         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6703         (class objfile_compunits): New.
6704         (ALL_COMPUNITS): Use objfile_compunits.
6705         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6706         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6707         objfile_compunits.
6708         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6709
6710 2019-01-09  Tom Tromey  <tom@tromey.com>
6711
6712         * symtab.c (search_symbols)
6713         (default_collect_symbol_completion_matches_break_on): Use
6714         objfile_msymbols.
6715         * ada-lang.c (ada_lookup_simple_minsym)
6716         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6717         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6718         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6719         objfile_msymbols.
6720         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6721         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6722         * objc-lang.c (find_methods): Use objfile_msymbols.
6723         (info_selectors_command, info_classes_command): Likewise.
6724         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6725         * objfiles.h (class objfile_msymbols): New.
6726         (ALL_OBJFILE_MSYMBOLS): Remove.
6727         (ALL_MSYMBOLS): Remove.
6728
6729 2019-01-09  Tom Tromey  <tom@tromey.com>
6730
6731         * common/next-iterator.h (next_adapter): Add Iterator template
6732         parameter.
6733         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6734         (class all_objfiles_safe): New.
6735         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6736         * objfiles.c (put_objfile_before): Update comment.
6737         (add_separate_debug_objfile): Likewise.
6738         (free_all_objfiles): Use all_objfiles_safe.
6739         (objfile_purge_solibs): Likewise.
6740
6741 2019-01-09  Tom Tromey  <tom@tromey.com>
6742
6743         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6744         (expand_symtab_containing_pc, lookup_static_symbol)
6745         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6746         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6747         all_objfiles.
6748         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6749         * breakpoint.c (create_overlay_event_breakpoint)
6750         (create_longjmp_master_breakpoint)
6751         (create_std_terminate_master_breakpoint)
6752         (create_exception_master_breakpoint): Use all_objfiles.
6753         * linux-thread-db.c (try_thread_db_load_from_pdir)
6754         (has_libpthread): Use all_objfiles.
6755         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6756         * linespec.c (iterate_over_all_matching_symtabs)
6757         (search_minsyms_for_name): Use all_objfiles.
6758         * maint.c (maintenance_info_sections): Use all_objfiles.
6759         * main.c (captured_main_1): Use all_objfiles.
6760         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6761         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6762         * guile/scm-pretty-print.c
6763         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6764         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6765         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6766         (maintenance_print_msymbols): Use all_objfiles.
6767         * source.c (select_source_symtab): Use all_objfiles.
6768         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6769         * symfile.c (remove_symbol_file_command)
6770         (expand_symtabs_matching, map_symbol_filenames): Use
6771         all_objfiles.
6772         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6773         all_objfiles.
6774         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6775         * objc-lang.c (find_methods): Use all_objfiles.
6776         * objfiles.c (have_partial_symbols, have_full_symbols)
6777         (have_minimal_symbols, qsort_cmp)
6778         (default_iterate_over_objfiles_in_search_order): Use
6779         all_objfiles.
6780         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6781         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6782         (maintenance_check_psymtabs): Use all_objfiles.
6783         (ALL_PSYMTABS): Remove.
6784         * compile/compile-object-run.c (do_module_cleanup): Use
6785         all_objfiles.
6786         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6787         * cp-support.c (add_symbol_overload_list_qualified): Use
6788         all_objfiles.
6789         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6790         Use all_objfiles.
6791         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6792         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6793         all_objfiles.
6794         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6795         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6796         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6797         Uses all_objfiles.
6798         * solib.c (solib_read_symbols): Use all_objfiles
6799
6800 2019-01-09  Tom Tromey  <tom@tromey.com>
6801
6802         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6803         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6804         all_objfiles.
6805         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6806         * symmisc.c (print_symbol_bcache_statistics)
6807         (print_objfile_statistics, maintenance_print_objfiles)
6808         (maintenance_info_symtabs, maintenance_check_symtabs)
6809         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6810         all_objfiles.
6811         * source.c (forget_cached_source_info): Use all_objfiles.
6812         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6813         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6814         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6815         * objfiles.c (update_section_map): Use all_objfiles.
6816         (shared_objfile_contains_address_p): Likewise.
6817         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6818         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6819
6820 2019-01-09  Tom Tromey  <tom@tromey.com>
6821
6822         * common/next-iterator.h: New file.
6823         * objfiles.h (class all_objfiles): New.
6824         (struct objfile_iterator): New.
6825
6826 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6827
6828         * NEWS: Move the description of the changed "frame", "select-frame",
6829          and "info frame" commands to the Changed commands section.
6830
6831 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6832
6833         * gdbtypes.c (check_stub_method_group): Remove handling of old
6834         mangling schemes.
6835         * linespec.c (find_methods): Likewise.
6836         * stabsread.c (read_member_functions): Likewise.
6837         * valops.c (search_struct_method): Likewise.
6838         (value_struct_elt_for_reference): Likewise.
6839         * NEWS: Mention this change.
6840
6841 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6842
6843         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6844         print_source_lines.
6845         * source.c (print_source_lines_base): Update line number check.
6846         (print_source_lines): New function.
6847         (source_lines_range::source_lines_range): New function.
6848         * source.h (class source_lines_range): New class.
6849         (print_source_lines): New declaration.
6850
6851 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6852
6853         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6854
6855 2019-01-08  Tom Tromey  <tom@tromey.com>
6856             Simon Marchi  <simon.marchi@ericsson.com>
6857
6858         PR gdb/24060
6859         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6860         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6861         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6862         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6863         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6864         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6865
6866 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6867
6868         * source.c (select_source_symtab): Move header comment to
6869         declaration in source.h.
6870         (forget_cached_source_info_for_objfile): Likewise.
6871         (forget_cached_source_info): Likewise.
6872         (identify_source_line): Likewise.
6873         * source.h (identify_source_line): Move declaration from symtab.h
6874         and add comment from source.c
6875         (print_source_lines): Likewise.
6876         (forget_cached_source_info_for_objfile): Likewise.
6877         (forget_cached_source_info): Likewise.
6878         (select_source_symtab): Likewise.
6879         (enum print_source_lines_flag): Move definition from symtab.h.
6880         * symtab.h (identify_source_line): Move declaration to source.h.
6881         (print_source_lines): Likewise.
6882         (forget_cached_source_info_for_objfile): Likewise.
6883         (forget_cached_source_info): Likewise.
6884         (select_source_symtab): Likewise.
6885         (enum print_source_lines_flag): Move definition to source.h.
6886         * tui/tui-hooks.c: Add 'source.h' include.
6887
6888 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6889
6890         * source.c (print_source_lines_base): Handle requests to print
6891         reverse line number sequences, and guard against empty lines
6892         string.
6893
6894 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6895
6896         * source.c (print_source_lines_base): Fix skip of '\r' if next
6897         character is '\n'.
6898
6899 2019-01-06  Tom Tromey  <tom@tromey.com>
6900
6901         * c-exp.y (struct c_parse_state) <macro_original_text,
6902         expansion_obstack>: New member.
6903         (macro_original_text, expansion_obstack): Remove globals.
6904         (scan_macro_expansion, scanning_macro_expansion)
6905         (finished_macro_expansion): Update.
6906         (scan_macro_cleanup): Remove.
6907         (yylex, c_parse): Update.
6908
6909 2019-01-06  Tom Tromey  <tom@tromey.com>
6910
6911         * c-exp.y (struct c_parse_state) <strings>: New member.
6912         (operator_stoken): Update.
6913
6914 2019-01-06  Tom Tromey  <tom@tromey.com>
6915
6916         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6917         (union type_stack_elt) <typelist_val>: Now a pointer to
6918         std::vector.
6919         (type_stack_cleanup): Don't declare.
6920         (push_typelist): Update.
6921         * parse.c (pop_typelist): Return a std::vector.
6922         (push_typelist): Take a std::vector.
6923         (follow_types): Update.  Do not free args.
6924         (type_stack_cleanup): Remove.
6925         * c-exp.y (struct c_parse_state): New.
6926         (cpstate): New global.
6927         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6928         (nonempty_typelist): Update.
6929         (func_mod): Create a new vector.
6930         (c_parse): Create a c_parse_state.
6931         (check_parameter_typelist): Do not delete params.
6932         (function_method): Update.  Do not delete type_list.
6933
6934 2019-01-06  Tom Tromey  <tom@tromey.com>
6935
6936         PR gdb/28155:
6937         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6938         check_typedef.
6939         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6940         (print_return_value): Likewise.
6941
6942 2019-01-05  Tom Tromey  <tom@tromey.com>
6943
6944         * contrib/cleanup_check.py: Remove.
6945         * contrib/gcc-with-excheck: Remove.
6946         * contrib/exsummary.py: Remove.
6947         * contrib/excheck.py: Remove.
6948
6949 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6950
6951         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6952         NULL. Initialize tpprev to NULL instead of assigning it
6953         to NULL on the next statement.
6954         * windows-nat.c (windows_delete_thread): Remove check for
6955         main_thread_id before printing thread exit notifications.
6956         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6957         Remove thread ID check against main_thread_id.
6958         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6959         windows_delete_thread.
6960         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6961
6962 2019-01-04  Tom Tromey  <tom@tromey.com>
6963
6964         * compile/compile.c (_initialize_compile): Use upper case for
6965         metasyntactic variables.
6966         * symmisc.c (_initialize_symmisc): Use upper case for
6967         metasyntactic variables.
6968         * psymtab.c (_initialize_psymtab): Use upper case for
6969         metasyntactic variables.
6970         * demangle.c (demangle_command): Use upper case for metasyntactic
6971         variables.
6972         (_initialize_demangler): Likewise.
6973         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6974         variables.
6975
6976 2019-01-03  Tom Tromey  <tom@tromey.com>
6977
6978         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6979
6980 2019-01-03  Tom Tromey  <tom@tromey.com>
6981
6982         * python/py-symtab.c (salpy_str): Update.
6983         (struct salpy_sal_object) <symtab>: Now a PyObject.
6984         (salpy_dealloc): Update.
6985         (del_objfile_sal): Use gdbpy_ref.
6986
6987 2019-01-03  Tom Tromey  <tom@tromey.com>
6988
6989         * python/py-type.c (convert_field): Use new_reference.  Return
6990         gdbpy_ref.
6991         (make_fielditem): Return gdbpy_ref.
6992         (typy_fields): Update.
6993         (typy_getitem): Update.
6994         (field_name): Return gdbpy_ref.  Use new_reference.
6995         (typy_iterator_iternext): Update.
6996
6997 2019-01-03  Tom Tromey  <tom@tromey.com>
6998
6999         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
7000
7001 2019-01-03  Tom Tromey  <tom@tromey.com>
7002
7003         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
7004         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
7005         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
7006         (pspy_set_frame_filters, pspy_set_frame_unwinders)
7007         (pspy_set_type_printers): Likewise.
7008         * python/py-function.c (fnpy_init): Use gdbpy_ref.
7009         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
7010         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
7011         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
7012         (objfpy_set_type_printers): Likewise.
7013
7014 2019-01-03  Tom Tromey  <tom@tromey.com>
7015
7016         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
7017         (gdbpy_print_stack): Use gdbpy_err_fetch.
7018         * python/python-internal.h (class gdbpy_err_fetch): New class.
7019         (class gdbpy_enter) <m_error_type, m_error_value,
7020         m_error_traceback>: Remove.
7021         <m_error>: New member.
7022         (gdbpy_exception_to_string): Don't declare.
7023         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
7024         * python/py-value.c (convert_value_from_python): Use
7025         gdbpy_err_fetch.
7026         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
7027         gdbpy_exception_to_string.
7028         (gdbpy_handle_exception): Use gdbpy_err_fetch.
7029         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
7030         gdbpy_err_fetch.
7031
7032 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7033
7034         * linux-nat.c (delete_lwp_cleanup): Delete.
7035         (struct lwp_deleter): New struct.
7036         (lwp_info_up): New typedef.
7037         (linux_nat_target::follow_fork): Delete cleanup, and make use of
7038         lwp_info_up.
7039
7040 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7041
7042         * linux-fork.c (class scoped_switch_fork_info): New class.
7043         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
7044
7045 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7046
7047         * valops.c (find_overload_match): Remove use of null_cleanup, and
7048         calls to do_cleanups.
7049
7050 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7051
7052         * compile/compile-cplus-types.c
7053         (compile_cplus_instance::decl_name): Handle changes to
7054         cp_func_name.
7055         * cp-support.c (cp_func_name): Update header comment, update
7056         return type.
7057         * cp-support.h (cp_func_name): Update return type in declaration.
7058         * valops.c (find_overload_match): Move temp_func local to top
7059         level of function and change its type.  Use temp_func to hold and
7060         delete temporary string obtained from cp_func_name.
7061
7062 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7063
7064         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
7065         gdb::char_vector, remove cleanup, and update uses of `msg`.
7066
7067 2019-01-03  Jim Wilson  <jimw@sifive.com>
7068
7069         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
7070
7071 2019-01-02  Tom Tromey  <tom@tromey.com>
7072
7073         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
7074         (tdesc_parse_xml): Remove cleanups.
7075         * target-descriptions.h (make_cleanup_free_target_description):
7076         Don't declare.
7077         (target_desc_deleter): New struct.
7078         (target_desc_up): New typedef.
7079         * target-descriptions.c (target_desc_deleter::operator()): Rename
7080         from free_target_description.
7081         (make_cleanup_free_target_description): Remove.
7082
7083 2019-01-02  Tom Tromey  <tom@tromey.com>
7084
7085         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
7086         constructor, destructor.
7087         (linespec_parser): Remove typedef.
7088         (~linespec_parser): Rename from linespec_parser_delete.
7089         (linespec_lex_to_end, linespec_complete_label)
7090         (linespec_complete): Update.
7091         (decode_line_full): Remove cleanups.
7092         (decode_line_1): Update.
7093
7094 2019-01-02  Tom Tromey  <tom@tromey.com>
7095
7096         * python/python-internal.h (inferior_to_inferior_object): Change
7097         return type.
7098         * python/py-exitedevent.c (create_exited_event_object): Update.
7099         * python/py-inferior.c (inferior_to_inferior_object): Return
7100         gdbpy_ref.
7101         (python_new_inferior, python_inferior_deleted)
7102         (thread_to_thread_object, delete_thread_object)
7103         (build_inferior_list, gdbpy_selected_inferior): Update.
7104         * python/py-infthread.c (create_thread_object): Update.  Also fail
7105         if inferior_to_inferior_object fails.
7106
7107 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
7108
7109         * inferior.h (class inferior) <displaced_step_state>: New field.
7110         * infrun.h (struct displaced_step_state): Move here from
7111         infrun.c.  Initialize fields, add constructor.
7112         <inf>: Remove field.
7113         <reset>: New method.
7114         * infrun.c (struct displaced_step_inferior_state): Move to
7115         infrun.h.
7116         (displaced_step_inferior_states): Remove.
7117         (get_displaced_stepping_state): Adust.
7118         (displaced_step_in_progress_any_inferior): Adjust.
7119         (displaced_step_in_progress_thread): Adjust.
7120         (displaced_step_in_progress): Adjust.
7121         (add_displaced_stepping_state): Remove.
7122         (get_displaced_step_closure_by_addr): Adjust.
7123         (remove_displaced_stepping_state): Remove.
7124         (infrun_inferior_exit): Call displaced_step_state.reset.
7125         (use_displaced_stepping): Don't check for NULL.
7126         (displaced_step_prepare_throw): Call
7127         get_displaced_stepping_state.
7128         (displaced_step_fixup): Don't check for NULL.
7129         (prepare_for_detach): Don't check for NULL.
7130
7131 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7132
7133         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
7134          in case of call that did not complete.
7135
7136 2019-01-02  Andrey Utkin  <autkin@undo.io>
7137
7138         * symfile.c (find_separate_debug_file): Fix search of debug files for
7139         remote debuggee.
7140
7141 2019-01-02  Tom Tromey  <tom@tromey.com>
7142
7143         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
7144         indentation.
7145         * python/py-frame.c (frapy_older): Remove cast.
7146         (frapy_newer): Likewise.
7147         * python/py-breakpoint.c (local_setattro): Remove cast.
7148         * python/py-arch.c (archpy_name): Remove local variable.
7149         * python/py-type.c (gdbpy_lookup_type): Remove cast.
7150
7151 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
7152
7153         * unittests/basic_string_view/element_access/char/empty.cc:
7154         Fix year range in copyright header.
7155
7156 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7157
7158         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
7159         Delete.
7160         <operator==>: Update with for removed field.
7161         <hash>: Likewise.
7162         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
7163         <isa_features>: ...this.
7164         <abi_features>: New field.
7165         (riscv_isa_flen): Update comment.
7166         (riscv_abi_xlen): New declaration.
7167         (riscv_abi_flen): New declaration.
7168         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
7169         isa_features.
7170         (riscv_abi_xlen): New function.
7171         (riscv_isa_flen): Update to get answer from isa_features.
7172         (riscv_abi_flen): New function.
7173         (riscv_has_fp_abi): Update to get answer from abi_features.
7174         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
7175         xlen and flen.
7176         (riscv_call_info) <xlen, flen>: Update comment.
7177         (riscv_call_arg_struct): Remove invalid assertions
7178         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
7179         is removed.
7180         (riscv_gdbarch_init): Gather isa features and abi features
7181         separately, ensure both match on the gdbarch when reusing an old
7182         gdbarch.  Relax an error check to allow 32-bit abi float to run on
7183         a target with 64-bit float hardware.
7184
7185 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7186
7187         * source.c (search_command_helper): Stop reverse search
7188         when line 1 has been searched.
7189
7190 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7191
7192         * record-full.c (record_full_base_target::close): Rewrite
7193         record_full_core_buf_list free logic.
7194
7195 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7196
7197         * break-catch-syscall.c (print_one_catch_syscall): xfree
7198         the last text.
7199
7200 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7201
7202         * top.c (print_gdb_version): Update Copyright year in version
7203         message.
7204
7205 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7206
7207         Update copyright year range in all GDB files.
7208
7209 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
7210
7211         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
7212
7213 For older changes see ChangeLog-2018.
7214 \f
7215 Local Variables:
7216 mode: change-log
7217 left-margin: 8
7218 fill-column: 74
7219 version-control: never
7220 coding: utf-8
7221 End:
7222