Split rank_one_type_parm_func from rank_one_type
[external/binutils.git] / gdb / ChangeLog
1 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2
3         * gdbtypes.c (rank_one_type_parm_func): New function extracted
4         from...
5         (rank_one_type): ... this.
6
7 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8
9         * gdbtypes.c (rank_one_type_parm_array): New function extracted
10         from...
11         (rank_one_type): ... this.
12
13 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14
15         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
16         from...
17         (rank_one_type): ... this.
18
19 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
20
21         * inferior.c (initialize_inferiors): Ensure 'help set/show print
22         inferior-events' shows the example events.
23
24 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
25
26         Support styling on native MS-Windows console
27
28         PR/24315
29         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
30         on MS-Windows if $TERM is not defined.
31
32         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
33
34         * posix-hdep.c (gdb_console_fputs):
35         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
36         functions.
37         * ui-file.h (gdb_console_fputs): Add prototype.
38
39         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
40         back to fputs only if the former returns zero.
41
42 2019-03-07  Tom Tromey  <tom@tromey.com>
43
44         * symmisc.c (print_symbol_bcache_statistics): Update.
45         (print_objfile_statistics): Update.
46         * symfile.c (allocate_symtab): Update.
47         * stabsread.c: Don't include bcache.h.
48         * psymtab.h (struct psymbol_bcache): Don't declare.
49         (class psymtab_storage) <psymbol_cache>: Now a bcache.
50         (psymbol_bcache_init, psymbol_bcache_free)
51         (psymbol_bcache_get_bcache): Don't declare.
52         * psymtab.c (struct psymbol_bcache): Remove.
53         (psymtab_storage::psymtab_storage): Update.
54         (psymtab_storage::~psymtab_storage): Update.
55         (psymbol_bcache_init, psymbol_bcache_free)
56         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
57         (add_psymbol_to_bcache): Update.
58         (allocate_psymtab): Update.
59         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
60         macro_cache>: No longer pointers.
61         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
62         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
63         * macrotab.c (macro_bcache): Update.
64         * macroexp.c: Don't include bcache.h.
65         * gdbtypes.c (check_types_worklist): Update.
66         (types_deeply_equal): Remove TRY/CATCH.  Update.
67         * elfread.c (elf_symtab_read): Update.
68         * dwarf2read.c: Don't include bcache.h.
69         * buildsym.c (buildsym_compunit::get_macro_table): Update.
70         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
71         (print_bcache_statistics, bcache_memory_used): Don't declare.
72         (struct bcache): Move from bcache.c.  Add constructor, destructor,
73         methods.  Rename all data members.
74         * bcache.c (struct bcache): Move to bcache.h.
75         (bcache::expand_hash_table): Rename from expand_hash_table.
76         (bcache): Remove.
77         (bcache::insert): Rename from bcache_full.
78         (bcache::compare): Rename from bcache_compare.
79         (bcache_xmalloc): Remove.
80         (bcache::~bcache): Rename from bcache_xfree.
81         (bcache::print_statistics): Rename from print_bcache_statistics.
82         (bcache::memory_used): Rename from bcache_memory_used.
83
84 2019-03-07  Pedro Alves  <palves@redhat.com>
85
86         * infrun.c (normal_stop): Also check for
87         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
88
89 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
90
91         * f-lang.c (value_from_host_double): Moved to...
92         * value.c (value_from_host_double): ...here.
93         * value.h (value_from_host_double): Declare.
94         * guile/scm-math.c (vlscm_convert_typed_number): Use
95         value_from_host_double.
96         (vlscm_convert_number): Likewise.
97         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
98         * python/py-value.c (convert_value_from_python): Likewise.
99
100 2019-03-06  Tom Tromey  <tom@tromey.com>
101
102         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
103
104 2019-03-06  Tom Tromey  <tom@tromey.com>
105
106         * utils.h (free_current_contents): Don't declare.
107         * utils.c (free_current_contents): Remove.
108
109 2019-03-06  Tom Tromey  <tom@tromey.com>
110
111         * top.c (quit_force): Update.
112         * main.c (captured_command_loop): Update.
113         * common/new-op.c (operator new): Update.
114         * common/common-exceptions.c (struct catcher)
115         <save_cleanup_chain>: Remove member.
116         (exceptions_state_mc_init): Update.
117         (exception_try_scope_entry): Return nullptr.
118         (exception_try_scope_exit, exception_rethrow)
119         (throw_exception_sjlj, throw_exception_cxx): Update.
120         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
121         (all_cleanups, do_cleanups, discard_cleanups)
122         (discard_final_cleanups, save_cleanups, save_final_cleanups)
123         (restore_cleanups, restore_final_cleanups): Don't declare.
124         (do_final_cleanups): Remove parameter.
125         * common/cleanups.c (cleanup_chain, make_cleanup)
126         (make_cleanup_dtor, all_cleanups, do_cleanups)
127         (discard_my_cleanups, discard_cleanups)
128         (discard_final_cleanups, save_my_cleanups, save_cleanups)
129         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
130         (null_cleanup): Remove.
131         (do_final_cleanups): Remove parameter.
132
133 2019-03-06  Tom Tromey  <tom@tromey.com>
134
135         * remote.c (remote_target::remote_parse_stop_reply): Use
136         unique_xmalloc_ptr.
137
138 2019-03-06  Tom Tromey  <tom@tromey.com>
139
140         * stabsread.c (struct stabs_field_info): Rename from field_info.
141         <list, fnlist>: Add initializers.
142         <obstack>: New member.
143         (read_member_functions, read_struct_fields, read_baseclasses):
144         Allocate on obstack.  Don't use cleanups.
145         (read_one_struct_field, read_member_functions, read_struct_fields)
146         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
147         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
148         (read_struct_type): Update.
149
150 2019-03-06  Tom Tromey  <tom@tromey.com>
151
152         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
153         * common/filestuff.h (make_cleanup_close): Don't declare.
154         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
155         Remove.
156
157 2019-03-06  Tom Tromey  <tom@tromey.com>
158
159         * solib-aix.c: Use make_scope_exit.
160
161 2019-03-06  Tom Tromey  <tom@tromey.com>
162
163         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
164         Use make_scope_exit.
165
166 2019-03-06  Tom Tromey  <tom@tromey.com>
167
168         * solib-svr4.c (disable_probes_interface): Remove parameter.
169         (svr4_handle_solib_event): Use make_scope_exit.
170
171 2019-03-06  Tom Tromey  <tom@tromey.com>
172
173         * remote.c (struct stop_reply_deleter): Remove.
174         (stop_reply_up): Update.
175         (struct stop_reply): Derive from notif_event.  Don't typedef.
176         <regcache>: Now a std::vector.
177         (stop_reply_xfree): Remove.
178         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
179         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
180         (remote_target::discard_pending_stop_replies): Use delete.
181         (remote_target::remote_parse_stop_reply): Update.
182         (remote_target::process_stop_reply): Update.
183         * remote-notif.h (struct notif_event): Add virtual destructor.
184         Remove "dtr" member.
185         (struct notif_client) <alloc_event>: Return a unique_ptr.
186         (notif_event_xfree): Don't declare.
187         (notif_event_up): New typedef.
188         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
189         (notif_event_xfree, do_notif_event_xfree): Remove.
190         (remote_notif_state_xfree): Update.
191
192 2019-03-06  Tom Tromey  <tom@tromey.com>
193
194         * infrun.c (displaced_step_clear_cleanup): Now a
195         forward_scope_exit type.
196         (displaced_step_prepare_throw): Update.
197         (displaced_step_fixup): Update.
198
199 2019-03-06  Tom Tromey  <tom@tromey.com>
200
201         * inferior.h (class inferior): Update comment.
202         * gdbthread.h (class thread_info): Update comment.
203
204 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
205             Tom Tromey  <tom@tromey.com>
206
207         * stabsread.h (struct stab_section_list): Remove.
208         (coffstab_build_psymtabs): Update.
209         * dbxread.c (symbuf_sections): Now a std::vector.
210         (sect_idx): New global.
211         (fill_symbuf): Update.
212         (coffstab_build_psymtabs): Change type of stabsects parameter.
213         Update.
214         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
215         std::vector.
216         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
217         (coff_locate_sections): Update.
218         (coff_symfile_read): Remove cleanups.  Update.
219         (init_stringtab): Add storage parameter.
220         (free_stringtab, free_stringtab_cleanup): Remove.
221         (init_lineno): Add storage parameter.
222         (free_linetab, free_linetab_cleanup): Remove.
223
224 2019-03-06  Pedro Alves  <palves@redhat.com>
225
226         * linux-fork.c (fork_info::clobber_regs): Delete.
227         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
228         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
229         comment.  Adjust.
230         (scoped_switch_fork_info::scoped_switch_fork_info)
231         (checkpoint_command, linux_fork_context): Adjust
232         fork_save_infrun_state calls.
233
234 2019-03-06  Pedro Alves  <palves@redhat.com>
235
236         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
237         (inf_has_multiple_threads): Return 'bool' and rewrite using
238         inferior_info::threads().
239
240 2019-03-06  Pedro Alves  <palves@redhat.com>
241
242         * linux-fork.c: Include <list>.
243         (fork_list): Now a std::list instance.
244         (fork_info): Add ctor, dtor, and in-class initialize all fields.
245         (forks_exist_p, find_last_fork): Adjust.
246         (new_fork): Delete.
247         (one_fork_p): New.
248         (add_fork): Adjust.
249         (free_fork): Delete, folded into fork_info::~fork_info().
250         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
251         Adjust.
252         (init_fork_list): Delete.
253         (linux_fork_killall, linux_fork_mourn_inferior)
254         (linux_fork_detach, info_checkpoints_command): Adjust.
255         (_initialize_linux_fork): No longer call init_fork_list.
256
257 2019-03-06  Pedro Alves  <palves@redhat.com>
258
259         * linux-fork.c (new_fork): New, split out of ...
260         (add_fork): ... this.  Return void.  Move "first fork" special
261         case from here, to ...
262         (checkpoint_command): ... here.
263         * linux-linux.h (add_fork): Return void.
264
265 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
266
267         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
268
269 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
270             Chris January  <chris.january@arm.com>
271             David Lecomber  <david.lecomber@arm.com>
272
273         * f-exp.y: New token, UNOP_INTRINSIC.
274         (exp): New pattern using UNOP_INTRINSIC token.
275         (f77_keywords): Add 'abs' keyword.
276         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
277         (value_from_host_double): New function.
278         (evaluate_subexp_f): Support UNOP_ABS.
279
280 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
281
282         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
283         types.
284
285 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
286
287         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
288         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
289         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
290
291 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
292
293         * f-exp.y (convert_to_kind_type): Handle more type kinds.
294
295 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
296             Chris January  <chris.january@arm.com>
297
298         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
299         * f-exp.y: Define 'KIND' token.
300         (exp): New pattern for KIND expressions.
301         (ptype): Handle types with a kind extension.
302         (direct_abs_decl): Extend to spot kind extensions.
303         (f77_keywords): Add 'kind' to the list.
304         (push_kind_type): New function.
305         (convert_to_kind_type): New function.
306         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
307         * parse.c (operator_length_standard): Likewise.
308         * parser-defs.h (enum type_pieces): Add tp_kind.
309         * std-operator.def: Add UNOP_KIND.
310
311 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
312
313         * f-exp.y (f_parse): Set yydebug.
314
315 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
316
317         * f-lang.c (evaluate_subexp_f): New function.
318         (exp_descriptor_f): New global.
319         (f_language_defn): Use exp_descriptor_f instead of
320         exp_descriptor_standard.
321
322 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
323
324         * f-exp.y (struct token): Add comments.
325         (dot_ops): Remove uppercase versions and the end marker.
326         (f77_keywords): Likewise.
327         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
328         entries in the dot_ops array are case insensitive, and use
329         strncasecmp to compare strings.  Also some whitespace cleanup in
330         this area.  Similar for the f77_keywords array, except entries in
331         this list might be case sensitive.
332
333 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
334
335         * f-exp.y (struct f77_boolean_val): Add comments.
336         (boolean_values): Remove uppercase versions, and end marker.
337         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
338         and use strncasecmp to achieve case insensitivity.  Additionally,
339         perform whitespace cleanup around this code.
340
341 2019-03-06  Tom Tromey  <tromey@adacore.com>
342
343         * remote-sim.c (gdbsim_target_open): Use result of
344         gdb_argv::release.
345
346 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
347         Dirk Schubert  <dirk.schubert@arm.com>
348         Chris January  <chris.january@arm.com>
349
350         * eval.c (evaluate_subexp_standard): Call Fortran argument
351         wrapping logic.
352         * f-lang.c (struct value): A value which can be passed into a
353         Fortran function call.
354         (fortran_argument_convert): Wrap Fortran arguments in a pointer
355         where appropriate.
356         (struct type): Value ready for a Fortran function call.
357         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
358         is needed.
359         * f-lang.h (fortran_argument_convert): Declaration.
360         (fortran_preserve_arg_pointer): Declaration.
361         * infcall.c (value_arg_coerce): Call Fortran argument logic.
362
363 2019-03-05  Tom Tromey  <tromey@adacore.com>
364
365         * python/py-prettyprint.c (print_string_repr): Remove #if.
366         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
367
368 2019-03-05  Tom Tromey  <tromey@adacore.com>
369
370         * target.c (the_dummy_target): Move later.  Change type to
371         "dummy_target".
372         (initialize_targets): Don't initialize the_dummy_target.
373
374 2019-03-05  Tom Tromey  <tromey@adacore.com>
375
376         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
377         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
378
379 2019-03-05  Tom Tromey  <tromey@adacore.com>
380
381         * windows-nat.c (windows_nat_target::attach)
382         (windows_nat_target::detach): Don't call gdb_flush.
383         * valprint.c (generic_val_print, val_print, val_print_string):
384         Don't call gdb_flush.
385         * utils.c (defaulted_query): Don't call gdb_flush.
386         * typeprint.c (print_type_scalar): Don't call gdb_flush.
387         * target.c (target_announce_detach): Don't call gdb_flush.
388         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
389         * remote.c (extended_remote_target::attach): Don't call
390         gdb_flush.
391         * procfs.c (procfs_target::detach): Don't call gdb_flush.
392         * printcmd.c (do_examine): Don't call gdb_flush.
393         (info_display_command): Don't call gdb_flush.
394         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
395         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
396         * memattr.c (info_mem_command): Don't call gdb_flush.
397         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
398         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
399         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
400         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
401         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
402         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
403         (gnu_nat_target::detach): Don't call gdb_flush.
404         * f-valprint.c (f_val_print): Don't call gdb_flush.
405         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
406         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
407         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
408         gdb_flush.
409         * c-valprint.c (c_val_print): Don't call gdb_flush.
410         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
411
412 2019-03-05  Tom Tromey  <tromey@adacore.com>
413
414         * varobj.c (update_dynamic_varobj_children): Update.
415         (install_default_visualizer): Use reset, not release.
416         * value.c (set_internalvar): Update.
417         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
418         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
419         ATTRIBUTE_UNUSED_RESULT.
420
421 2019-03-05  Tom Tromey  <tromey@adacore.com>
422
423         * remote.c (class scoped_remote_fd) <release>: Add
424         ATTRIBUTE_UNUSED_RESULT.
425
426 2019-03-05  Tom Tromey  <tromey@adacore.com>
427
428         * macroexp.c (struct macro_buffer) <release>: Add
429         ATTRIBUTE_UNUSED_RESULT.
430
431 2019-03-05  Tom Tromey  <tromey@adacore.com>
432
433         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
434         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
435         ATTRIBUTE_UNUSED_RESULT.
436
437 2019-03-05  Tom Tromey  <tromey@adacore.com>
438
439         * common/scoped_fd.h (class scoped_fd) <release>: Add
440         ATTRIBUTE_UNUSED_RESULT.
441
442 2019-03-05  Tom Tromey  <tromey@adacore.com>
443
444         * parser-defs.h (struct parser_state) <release>: Add
445         ATTRIBUTE_UNUSED_RESULT.
446
447 2019-03-05  Tom Tromey  <tromey@adacore.com>
448
449         * utils.h (class gdb_argv) <release>: Add
450         ATTRIBUTE_UNUSED_RESULT.
451         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
452
453 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
454
455         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
456         for-loop range, to avoid compiler warnings.
457
458         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
459         avoid compiler warnings about unused variables.
460
461         * NEWS: Mention end of support for native debugging on MS-Windows
462         before XP.
463
464         PR gdb/24292
465         * common/netstuff.c:
466         * gdbserver/gdbreplay.c
467         * gdbserver/remote-utils.c:
468         * ser-tcp.c:
469         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
470         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
471         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
472         'getaddrinfo' and 'freeaddrinfo' were not available before
473         Windows XP, and mingw.org's MinGW headers by default define
474         _WIN32_WINNT to 0x500.
475
476 2019-03-01  Gary Benson <gbenson@redhat.com>
477
478         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
479
480 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
481             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
482
483         PR gdb/8527
484         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
485         set_sigint_trap, clear_sigint_trap.
486
487 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
488
489         * target.c (target_detach): Clear the regcache and the
490         frame cache.
491
492 2019-02-27  Pedro Alves  <palves@redhat.com>
493
494         * utils.c (set_screen_size): When we cap the height/width sizes,
495         tweak the corresponding command variable to show "unlimited":
496
497 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
498             Pedro Alves  <palves@redhat.com>
499
500         * utils.c (set_screen_size): Reduce "infinite" rows and columns
501         before calling rl_set_screen_size.
502
503 2019-02-27  Tom Tromey  <tromey@adacore.com>
504
505         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
506         define.
507         * python/py-value.c: Remove Python 2.4 workaround.
508         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
509         workaround.
510         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
511         Python 2.4 workaround.
512         * python/python-internal.h: Remove Python 2.4 comment.
513         (Py_ssize_t): Don't define.
514         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
515         (gdb_Py_DECREF): Remove Python 2.4 workaround.
516         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
517         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
518         * python/python.c (do_start_initialization): Remove Python 2.4
519         workaround.
520         * python/py-prettyprint.c (class dummy_python_frame): Remove.
521         (print_children): Remove Python 2.4 workaround.
522         * python/py-inferior.c (buffer_procs): Remove Python 2.4
523         workaround.
524         (CHARBUFFERPROC_NAME): Remove.
525         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
526         Python 2.4 workaround.
527
528 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
529
530         * NEWS: Note minimum Python version.
531
532 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
533
534         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
535         code from these functions.  Remove corresponding ifdefs.  Use
536         Py_buffer_up instead of explicit calls to PyBuffer_Release.
537         Remove gotos and target of gotos.
538         (infpy_search_memory): Likewise.
539
540 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
541
542         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
543         (hppa_gdbarch_init): Don't register deleted functions with
544         gdbarch.
545
546 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
547
548         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
549         (h8300_unwind_sp): Delete.
550         (h8300_dummy_id): Delete.
551         (h8300_gdbarch_init): Don't register deleted functions with
552         gdbarch.
553
554 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
555
556         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
557         (ft32_unwind_pc): Delete.
558         (ft32_unwind_sp): Delete.
559         (ft32_gdbarch_init): Don't register deleted functions with
560         gdbarch.
561
562 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
563
564         * gdb/frv-tdep.c (frv_dummy_id): Delete.
565         (frv_unwind_pc): Delete.
566         (frv_unwind_sp): Delete.
567         (frv_gdbarch_init): Don't register deleted functions with
568         gdbarch.
569
570 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
571
572         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
573         (riscv_unwind_pc): Delete.
574         (riscv_unwind_sp): Delete.
575         (riscv_gdbarch_init): Don't register deleted functions with
576         gdbarch.
577
578 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
579
580         * gdb/csky-tdep.c (csky_dummy_id): Delete.
581         (csky_unwind_pc): Delete.
582         (csky_unwind_sp): Delete.
583         (csky_gdbarch_init): Don't register deleted functions with
584         gdbarch.
585
586 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
587
588         * gdb/cris-tdep.c (cris_dummy_id): Delete.
589         (cris_unwind_pc): Delete.
590         (cris_unwind_sp): Delete.
591         (cris_gdbarch_init): Don't register deleted functions with
592         gdbarch.
593
594 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
595
596         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
597         (bfin_unwind_pc): Delete.
598         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
599
600 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
601
602         * gdb/arm-tdep.c (arm_dummy_id): Delete.
603         (arm_unwind_pc): Delete.
604         (arm_unwind_sp): Delete.
605         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
606
607 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
608
609         * gdb/arc-tdep.c (arc_dummy_id): Delete.
610         (arc_unwind_pc): Delete.
611         (arc_unwind_sp): Delete.
612         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
613
614 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
615
616         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
617         (alpha_unwind_pc): Delete.
618         (alpha_gdbarch_init): Don't register deleted functions with
619         gdbarch.
620
621 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
622
623         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
624         (aarch64_unwind_pc): Delete.
625         (aarch64_unwind_sp): Delete.
626         (aarch64_gdbarch_init): Don't register deleted functions with
627         gdbarch.
628
629 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
630
631         * gdbtypes.c (type_align): Don't consider static members when
632         computing structure alignment.
633
634 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
635
636         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
637         return 0 for other types.
638         * arch-utils.c (default_type_align): Always return 0.
639         * gdbarch.h: Regenerate.
640         * gdbarch.sh (type_align): Extend comment.
641         * gdbtypes.c (type_align): Add additional comments, always call
642         gdbarch_type_align before applying the default rules.
643         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
644         generic code will then apply a suitable default.
645         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
646         types, return 0 for other types.
647
648 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
649
650         * NEWS: Create a new section for the next release branch.
651         Rename the section of the current branch, now that it has
652         been cut.
653
654 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
655
656         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
657         * version.in: Bump version to 8.3.50.DATE-git.
658
659 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
660
661         * aix-thread.c (ptid_cmp): Remove unused variable.
662         (get_signaled_thread): Likewise.
663         (store_regs_user_thread): Likewise.
664         (store_regs_kernel_thread): Likewise.
665         (fetch_regs_kernel_thread): Remove shadowed variable.
666
667 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
668
669         * features/riscv/32bit-cpu.xml: Add register numbers.
670         * features/riscv/32bit-fpu.c: Regenerate.
671         * features/riscv/32bit-fpu.xml: Add register numbers.
672         * features/riscv/64bit-cpu.xml: Add register numbers.
673         * features/riscv/64bit-fpu.c: Regenerate.
674         * features/riscv/64bit-fpu.xml: Add register numbers.
675
676 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
677
678         * NEWS: Mention two argument form of gdb.Value constructor.
679         * python/py-value.c (convert_buffer_and_type_to_value): New
680         function.
681         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
682         Add support for handling an optional second argument.  Call
683         convert_buffer_and_type_to_value as appropriate.
684         * python/python-internal.h (Py_buffer_deleter): New struct.
685         (Py_buffer_up): New typedef.
686
687 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
688
689         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
690         instead of releasing ownership.
691
692 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
693
694         * dwarf2read.c (open_and_init_dwp_file): Call
695         elf_numsections instead of bfd_count_sections to initialize
696         dwp_file->num_sections.
697
698 2019-02-25  Tom Tromey  <tromey@adacore.com>
699
700         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
701
702 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
703
704         * gcore.in: Add '--readnever' option when invoking GDB.
705
706 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
707
708         * MAINTAINERS: Update my email address.
709
710 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
711
712         * build-id.c (build_id_to_debug_bfd_1): New function.
713         (build_id_to_debug_bfd): Look for separate debug file in
714         sysroot.
715
716 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
717
718         * gdbarch.sh: Update the copyright year range that is placed into
719         generated files.
720
721 2019-02-22  Keith Seitz  <keiths@redhat.com>
722
723         PR symtab/23853
724         * linespec.c (create_sals_line_offset): Search for the default
725         symtab's filename instead of its fullname.
726
727 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
728
729         * NEWS: Update style defaults.
730
731 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
732
733         * main.c (captured_main_1): Disable styling in batch mode.
734
735 2019-02-20  Tom Tromey  <tom@tromey.com>
736
737         * symtab.c (symtab_symbol_info): Fix typos.
738
739 2019-02-20  Tom Tromey  <tromey@adacore.com>
740
741         * findcmd.c (_initialize_mem_search): Use upper case for
742         metasyntactic variables.
743
744 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
745
746         * aarch64-tdep.c (aarch64_add_reggroups): New function.
747         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
748
749 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
750
751         * top.h (source_file_name): Change to std::string.
752         * top.c (source_file_name): Likewise.
753         (command_line_input): Adjust.
754         * cli/cli-script.c (script_from_file): Adjust.
755
756 2019-02-19  Tom Tromey  <tromey@adacore.com>
757
758         * ravenscar-thread.c
759         (ravenscar_thread_target::update_thread_list): Don't call
760         ada_build_task_list.
761         * ada-lang.h (ada_build_task_list): Don't declare.
762         * ada-tasks.c (struct ada_tasks_inferior_data)
763         <task_list_valid_p>: Now bool.
764         (read_known_tasks, ada_task_list_changed)
765         (ada_tasks_invalidate_inferior_data): Update.
766         (read_known_tasks_array): Return bool.
767         (read_known_tasks_list): Likewise.
768         (read_known_tasks): Return void.
769         (ada_build_task_list): Now static.
770
771 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
772
773         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
774         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
775
776 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
777
778         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
779         variant for ada_tasks_pspace_data_handle and
780         ada_tasks_inferior_data_handle.
781         (ada_tasks_pspace_data_cleanup): New function.
782         (ada_tasks_inferior_data_cleanup): New function.
783
784 2019-02-17  Tom Tromey  <tom@tromey.com>
785
786         * macrotab.h (macro_source_fullname): Return a std::string.
787         * macrotab.c (macro_include, check_for_redefinition)
788         (macro_undef, macro_lookup_definition, foreach_macro)
789         (foreach_macro_in_scope): Update.
790         (macro_source_fullname): Return a std::string.
791         * macrocmd.c (show_pp_source_pos): Update.
792
793 2019-02-17  Tom Tromey  <tom@tromey.com>
794
795         * macrocmd.c (show_pp_source_pos): Style the file names.
796
797 2019-02-17  Tom Tromey  <tom@tromey.com>
798
799         PR tui/24197:
800         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
801
802 2019-02-17  Tom Tromey  <tom@tromey.com>
803
804         * ada-lang.c (user_select_syms): Use filtered printing.
805         * utils.c (wrap_style): New global.
806         (desired_style): Remove.
807         (emit_style_escape): Add stream parameter.
808         (set_output_style, reset_terminal_style, prompt_for_continue):
809         Update.
810         (flush_wrap_buffer): Only flush gdb_stdout.
811         (wrap_here): Set wrap_style.
812         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
813         treat escape sequences as a character.  Change when wrap buffer is
814         flushed.
815         (fputs_styled): Do not set the output style when the default is
816         requested.
817         * ui-style.h (struct ui_file_style) <is_default>: New method.
818         * source.c (print_source_lines_base): Emit escape sequences in one
819         piece.
820
821 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
822
823         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
824         integers and enumeration types.
825
826 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
827
828         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
829         instead of lookup_symbol_in_language
830         (do_exact_match): New function.
831         (ada_get_symbol_name_matcher): Return do_exact_match when
832         doing a verbatim match.
833
834 2019-02-15  Tom Tromey  <tromey@adacore.com>
835
836         * ravenscar-thread.c (ravenscar_thread_target::resume)
837         (ravenscar_thread_target::wait): Special case wildcard requests.
838
839 2019-02-15  Tom Tromey  <tromey@adacore.com>
840
841         * ravenscar-thread.c (base_ptid): Remove.
842         (struct ravenscar_thread_target) <close>: New method.
843         <m_base_ptid>: New member.
844         <update_inferior_ptid, active_task, task_is_currently_active,
845         runtime_initialized>: Declare methods.
846         <ravenscar_thread_target>: Add constructor.
847         (ravenscar_thread_target::task_is_currently_active)
848         (ravenscar_thread_target::update_inferior_ptid)
849         (ravenscar_runtime_initialized): Rename.  Now methods.
850         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
851         (ravenscar_thread_target::update_thread_list): Update.
852         (ravenscar_thread_target::active_task): Now method.
853         (ravenscar_thread_target::store_registers)
854         (ravenscar_thread_target::prepare_to_store)
855         (ravenscar_thread_target::prepare_to_store)
856         (ravenscar_thread_target::mourn_inferior): Update.
857         (ravenscar_inferior_created): Use "new" to create target.
858         (ravenscar_thread_target::get_ada_task_ptid): Update.
859         (_initialize_ravenscar): Don't initialize base_ptid.
860         (ravenscar_ops): Remove global.
861
862 2019-02-15  Tom Tromey  <tromey@adacore.com>
863
864         * target.h (push_target): Declare new overload.
865         * target.c (push_target): New overload, taking an rvalue reference.
866         * remote.c (remote_target::open_1): Use push_target overload.
867         * corelow.c (core_target_open): Use push_target overload.
868
869 2019-02-15  Tom Tromey  <tromey@adacore.com>
870
871         * ravenscar-thread.c (is_ravenscar_task)
872         (ravenscar_task_is_currently_active): Return bool.
873         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
874         (_initialize_ravenscar): Remove "(void)".
875         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
876         Return bool.
877
878 2019-02-15  Tom Tromey  <tromey@adacore.com>
879
880         * ravenscar-thread.c (ravenscar_runtime_initializer)
881         (has_ravenscar_runtime, get_running_thread_id)
882         (ravenscar_thread_target::resume): Fix indentation.
883
884 2019-02-15  Tom Tromey  <tromey@adacore.com>
885
886         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
887         from ravenscar_arch_ops.
888         (sparc_ravenscar_ops::fetch_registers)
889         (sparc_ravenscar_ops::store_registers): Now methods.
890         (sparc_ravenscar_prepare_to_store): Remove.
891         (sparc_ravenscar_ops): Redefine.
892         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
893         methods and destructor.  Remove members.
894         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
895         (ravenscar_thread_target::store_registers)
896         (ravenscar_thread_target::prepare_to_store): Update.
897         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
898         Remove.
899         (struct ppc_ravenscar_powerpc_ops): Derive from
900         ravenscar_arch_ops.
901         (ppc_ravenscar_powerpc_ops::fetch_registers)
902         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
903         (ppc_ravenscar_powerpc_ops): Redefine.
904         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
905         (ppc_ravenscar_e500_ops::fetch_registers)
906         (ppc_ravenscar_e500_ops::store_registers): Now methods.
907         (ppc_ravenscar_e500_ops): Redefine.
908         * aarch64-ravenscar-thread.c
909         (aarch64_ravenscar_generic_prepare_to_store): Remove.
910         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
911         (aarch64_ravenscar_fetch_registers)
912         (aarch64_ravenscar_store_registers): Now methods.
913         (aarch64_ravenscar_ops): Redefine.
914
915 2019-02-15  Tom Tromey  <tromey@adacore.com>
916
917         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
918         (ravenscar_thread_target::stopped_by_hw_breakpoint)
919         (ravenscar_thread_target::stopped_by_watchpoint)
920         (ravenscar_thread_target::stopped_data_address)
921         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
922
923 2019-02-15  Tom Tromey  <tromey@adacore.com>
924
925         * ravenscar-thread.c: Fix some typos.
926
927 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
928             Tom Tromey  <tromey@adacore.com>
929
930         * ada-lang.c (ada_exception_sal): Change addr_string to a
931         std::string.
932         (create_ada_exception_catchpoint): Update.
933
934 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
935             Tom Tromey  <tromey@adacore.com>
936
937         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
938         (bp_location_ops): Remove.
939         (base_breakpoint_allocate_location): Update.
940         (free_bp_location): Update.
941         * ada-lang.c (class ada_catchpoint_location)
942         <ada_catchpoint_location>: Remove ops parameter.
943         (ada_catchpoint_location_dtor): Remove.
944         (ada_catchpoint_location_ops): Remove.
945         (allocate_location_exception): Update.
946         * breakpoint.h (struct bp_location_ops): Remove.
947         (class bp_location) <bp_location>: Remove bp_location_ops
948         parameter.
949         <~bp_location>: Add destructor.
950         <ops>: Remove.
951
952 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
953             Pedro Alves  <palves@redhat.com>
954
955         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
956         'PATH_MAX'.
957
958 2019-02-14  David Michael  <fedora.dm0@gmail.com>
959             Samuel Thibault  <samuel.thibault@gnu.org>
960             Thomas Schwinge  <thomas@codesourcery.com>
961
962         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
963         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
964
965 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
966
967         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
968         (check_empty): Use "const char *".
969
970         * gnu-nat.c (gnu_nat_target::detach): Instead of
971         'detach_inferior (pid)' call
972         'detach_inferior (find_inferior_pid (pid))'.
973
974         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
975         'nat/fork-inferior.o'.
976         * gnu-nat.c: #include "nat/fork-inferior.h".
977
978         * gnu-nat.c (gnu_nat_target::detach): Instead of
979         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
980         * gnu-nat.h: #include "inf-child.h".
981         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
982         'i386_gnu_nat_target::fetch_registers'.
983         (gnu_store_registers): Rename/move to
984         'i386_gnu_nat_target::store_registers'.
985
986         * config/i386/nm-i386gnu.h: Don't "#include" any files.
987         * gnu-nat.h (mach_thread_info): New function.
988         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
989
990         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
991
992 2019-02-14  Frederic Konrad  <konrad@adacore.com>
993
994         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
995
996 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
997
998         * windows-nat.c (windows_add_thread): Add new parameter
999         "main_thread_p" with default value set to false.  Update
1000         function documentation as well as all callers.
1001         (windows_delete_thread): Likewise.
1002         (fake_create_process): Update call to windows_add_thread.
1003         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1004         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1005         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1006         call to windows_delete_thread.
1007
1008 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1009
1010         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1011
1012 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1013
1014         * symfile.c (find_separate_debug_file): Use canonical path of
1015         sysroot with child_path instead of gdb_sysroot if it is valid.
1016
1017 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1018
1019         * symfile.c (find_separate_debug_file): Use child_path to
1020         determine if an object file is under a sysroot.
1021
1022 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1023
1024         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1025         unittests/child-path-selftests.c.
1026         * common/pathstuff.c (child_path): New function.
1027         * common/pathstuff.h (child_path): New prototype.
1028         * unittests/child-path-selftests.c: New file.
1029
1030 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1031
1032         * symfile.c (find_separate_debug_file): Look for separate debug
1033         files in debug directories under the sysroot.
1034
1035 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1036
1037         * symtab.h (struct minimal_symbol data_p): New const method.
1038         (struct minimal_symbol text_p): Likewise.
1039         * symtab.c (output_source_filename): Use file name style
1040         to print file name.
1041         (print_symbol_info): Likewise.
1042         (print_msymbol_info): Use address style to print addresses.
1043         Use function name style to print executable text symbols.
1044         (expand_symtab_containing_pc): Use data_p.
1045         (find_pc_sect_compunit_symtab): Likewise.
1046
1047 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1048
1049         * breakpoint.c (describe_other_breakpoints): Use address style
1050         to print addresses.
1051         (say_where): Likewise.
1052
1053 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1054
1055         * ada-typeprint.c (print_func_type): Print function name
1056         style to print function name.
1057         * c-typeprint.c (c_print_type_1): Likewise.
1058
1059 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
1060
1061         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
1062         for execve.
1063
1064 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1065
1066         * c-exp.y (direct_abs_decl): Use emplace_back to record the
1067         type_stack.
1068
1069 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
1070
1071         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
1072         TYPE_CODE_REF types.
1073
1074 2019-02-08  Jim Wilson  <jimw@sifive.com>
1075
1076         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
1077         (riscv_linux_fregset): New.
1078         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
1079
1080 2019-02-07  Tom Tromey  <tom@tromey.com>
1081
1082         * thread.c (thread_cancel_execution_command): Update.
1083         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
1084         methods.
1085         (struct thread_fsm_ops): Remove.
1086         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
1087         (thread_fsm_should_stop, thread_fsm_return_value)
1088         (thread_fsm_set_finished, thread_fsm_finished_p)
1089         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
1090         Don't declare.
1091         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
1092         * infrun.c (clear_proceed_status_thread)
1093         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
1094         (print_stop_event): Update.
1095         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
1096         Add constructor.
1097         (step_command_fsm_ops): Remove.
1098         (new_step_command_fsm): Remove.
1099         (step_1): Update.
1100         (step_command_fsm::should_stop): Rename from
1101         step_command_fsm_should_stop.
1102         (step_command_fsm::clean_up): Rename from
1103         step_command_fsm_clean_up.
1104         (step_command_fsm::do_async_reply_reason): Rename from
1105         step_command_fsm_async_reply_reason.
1106         (struct until_next_fsm): Inherit from thread_fsm.  Add
1107         constructor.
1108         (until_next_fsm_ops): Remove.
1109         (new_until_next_fsm): Remove.
1110         (until_next_fsm::should_stop): Rename from
1111         until_next_fsm_should_stop.
1112         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
1113         (until_next_fsm::do_async_reply_reason): Rename from
1114         until_next_fsm_async_reply_reason.
1115         (struct finish_command_fsm): Inherit from thread_fsm.  Add
1116         constructor.  Change type of breakpoint.
1117         (finish_command_fsm_ops): Remove.
1118         (new_finish_command_fsm): Remove.
1119         (finish_command_fsm::should_stop): Rename from
1120         finish_command_fsm_should_stop.
1121         (finish_command_fsm::clean_up): Rename from
1122         finish_command_fsm_clean_up.
1123         (finish_command_fsm::return_value): Rename from
1124         finish_command_fsm_return_value.
1125         (finish_command_fsm::do_async_reply_reason): Rename from
1126         finish_command_fsm_async_reply_reason.
1127         (finish_command): Update.
1128         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
1129         Add constructor.
1130         (call_thread_fsm_ops): Remove.
1131         (call_thread_fsm::call_thread_fsm): Rename from
1132         new_call_thread_fsm.
1133         (call_thread_fsm::should_stop): Rename from
1134         call_thread_fsm_should_stop.
1135         (call_thread_fsm::should_notify_stop): Rename from
1136         call_thread_fsm_should_notify_stop.
1137         (run_inferior_call, call_function_by_hand_dummy): Update.
1138         * cli/cli-interp.c (should_print_stop_to_console): Update.
1139         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
1140         Add constructor.  Change type of location_breakpoint,
1141         caller_breakpoint.
1142         (until_break_fsm_ops): Remove.
1143         (new_until_break_fsm): Remove.
1144         (until_break_fsm::should_stop): Rename from
1145         until_break_fsm_should_stop.
1146         (until_break_fsm::clean_up): Rename from
1147         until_break_fsm_clean_up.
1148         (until_break_fsm::do_async_reply_reason): Rename from
1149         until_break_fsm_async_reply_reason.
1150         (until_break_command): Update.
1151         * thread-fsm.c: Remove.
1152         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
1153
1154 2019-02-07  Tom Tromey  <tom@tromey.com>
1155
1156         * yy-remap.h: Add include guard.
1157         * xtensa-tdep.h: Add include guard.
1158         * xcoffread.h: Rename include guard.
1159         * varobj-iter.h: Add include guard.
1160         * tui/tui.h: Rename include guard.
1161         * tui/tui-winsource.h: Rename include guard.
1162         * tui/tui-wingeneral.h: Rename include guard.
1163         * tui/tui-windata.h: Rename include guard.
1164         * tui/tui-win.h: Rename include guard.
1165         * tui/tui-stack.h: Rename include guard.
1166         * tui/tui-source.h: Rename include guard.
1167         * tui/tui-regs.h: Rename include guard.
1168         * tui/tui-out.h: Rename include guard.
1169         * tui/tui-layout.h: Rename include guard.
1170         * tui/tui-io.h: Rename include guard.
1171         * tui/tui-hooks.h: Rename include guard.
1172         * tui/tui-file.h: Rename include guard.
1173         * tui/tui-disasm.h: Rename include guard.
1174         * tui/tui-data.h: Rename include guard.
1175         * tui/tui-command.h: Rename include guard.
1176         * tic6x-tdep.h: Add include guard.
1177         * target/waitstatus.h: Rename include guard.
1178         * target/wait.h: Rename include guard.
1179         * target/target.h: Rename include guard.
1180         * target/resume.h: Rename include guard.
1181         * target-float.h: Rename include guard.
1182         * stabsread.h: Add include guard.
1183         * rs6000-tdep.h: Add include guard.
1184         * riscv-fbsd-tdep.h: Add include guard.
1185         * regformats/regdef.h: Rename include guard.
1186         * record.h: Rename include guard.
1187         * python/python.h: Rename include guard.
1188         * python/python-internal.h: Rename include guard.
1189         * python/py-stopevent.h: Rename include guard.
1190         * python/py-ref.h: Rename include guard.
1191         * python/py-record.h: Rename include guard.
1192         * python/py-record-full.h: Rename include guard.
1193         * python/py-record-btrace.h: Rename include guard.
1194         * python/py-instruction.h: Rename include guard.
1195         * python/py-events.h: Rename include guard.
1196         * python/py-event.h: Rename include guard.
1197         * procfs.h: Add include guard.
1198         * proc-utils.h: Add include guard.
1199         * p-lang.h: Add include guard.
1200         * or1k-tdep.h: Rename include guard.
1201         * observable.h: Rename include guard.
1202         * nto-tdep.h: Rename include guard.
1203         * nat/x86-linux.h: Rename include guard.
1204         * nat/x86-linux-dregs.h: Rename include guard.
1205         * nat/x86-gcc-cpuid.h: Add include guard.
1206         * nat/x86-dregs.h: Rename include guard.
1207         * nat/x86-cpuid.h: Rename include guard.
1208         * nat/ppc-linux.h: Rename include guard.
1209         * nat/mips-linux-watch.h: Rename include guard.
1210         * nat/linux-waitpid.h: Rename include guard.
1211         * nat/linux-ptrace.h: Rename include guard.
1212         * nat/linux-procfs.h: Rename include guard.
1213         * nat/linux-osdata.h: Rename include guard.
1214         * nat/linux-nat.h: Rename include guard.
1215         * nat/linux-namespaces.h: Rename include guard.
1216         * nat/linux-btrace.h: Rename include guard.
1217         * nat/glibc_thread_db.h: Rename include guard.
1218         * nat/gdb_thread_db.h: Rename include guard.
1219         * nat/gdb_ptrace.h: Rename include guard.
1220         * nat/fork-inferior.h: Rename include guard.
1221         * nat/amd64-linux-siginfo.h: Rename include guard.
1222         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
1223         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
1224         * nat/aarch64-linux.h: Rename include guard.
1225         * nat/aarch64-linux-hw-point.h: Rename include guard.
1226         * mn10300-tdep.h: Add include guard.
1227         * mips-linux-tdep.h: Add include guard.
1228         * mi/mi-parse.h: Rename include guard.
1229         * mi/mi-out.h: Rename include guard.
1230         * mi/mi-main.h: Rename include guard.
1231         * mi/mi-interp.h: Rename include guard.
1232         * mi/mi-getopt.h: Rename include guard.
1233         * mi/mi-console.h: Rename include guard.
1234         * mi/mi-common.h: Rename include guard.
1235         * mi/mi-cmds.h: Rename include guard.
1236         * mi/mi-cmd-break.h: Rename include guard.
1237         * m2-lang.h: Add include guard.
1238         * location.h: Rename include guard.
1239         * linux-record.h: Rename include guard.
1240         * linux-nat.h: Add include guard.
1241         * linux-fork.h: Add include guard.
1242         * i386-darwin-tdep.h: Rename include guard.
1243         * hppa-linux-offsets.h: Add include guard.
1244         * guile/guile.h: Rename include guard.
1245         * guile/guile-internal.h: Rename include guard.
1246         * gnu-nat.h: Rename include guard.
1247         * gdb-stabs.h: Rename include guard.
1248         * frv-tdep.h: Add include guard.
1249         * f-lang.h: Add include guard.
1250         * event-loop.h: Add include guard.
1251         * darwin-nat.h: Rename include guard.
1252         * cp-abi.h: Rename include guard.
1253         * config/sparc/nm-sol2.h: Rename include guard.
1254         * config/nm-nto.h: Rename include guard.
1255         * config/nm-linux.h: Add include guard.
1256         * config/i386/nm-i386gnu.h: Rename include guard.
1257         * config/djgpp/nl_types.h: Rename include guard.
1258         * config/djgpp/langinfo.h: Rename include guard.
1259         * compile/gcc-cp-plugin.h: Add include guard.
1260         * compile/gcc-c-plugin.h: Add include guard.
1261         * compile/compile.h: Rename include guard.
1262         * compile/compile-object-run.h: Rename include guard.
1263         * compile/compile-object-load.h: Rename include guard.
1264         * compile/compile-internal.h: Rename include guard.
1265         * compile/compile-cplus.h: Rename include guard.
1266         * compile/compile-c.h: Rename include guard.
1267         * common/xml-utils.h: Rename include guard.
1268         * common/x86-xstate.h: Rename include guard.
1269         * common/version.h: Rename include guard.
1270         * common/vec.h: Rename include guard.
1271         * common/tdesc.h: Rename include guard.
1272         * common/selftest.h: Rename include guard.
1273         * common/scoped_restore.h: Rename include guard.
1274         * common/scoped_mmap.h: Rename include guard.
1275         * common/scoped_fd.h: Rename include guard.
1276         * common/safe-iterator.h: Rename include guard.
1277         * common/run-time-clock.h: Rename include guard.
1278         * common/refcounted-object.h: Rename include guard.
1279         * common/queue.h: Rename include guard.
1280         * common/ptid.h: Rename include guard.
1281         * common/print-utils.h: Rename include guard.
1282         * common/preprocessor.h: Rename include guard.
1283         * common/pathstuff.h: Rename include guard.
1284         * common/observable.h: Rename include guard.
1285         * common/netstuff.h: Rename include guard.
1286         * common/job-control.h: Rename include guard.
1287         * common/host-defs.h: Rename include guard.
1288         * common/gdb_wait.h: Rename include guard.
1289         * common/gdb_vecs.h: Rename include guard.
1290         * common/gdb_unlinker.h: Rename include guard.
1291         * common/gdb_unique_ptr.h: Rename include guard.
1292         * common/gdb_tilde_expand.h: Rename include guard.
1293         * common/gdb_sys_time.h: Rename include guard.
1294         * common/gdb_string_view.h: Rename include guard.
1295         * common/gdb_splay_tree.h: Rename include guard.
1296         * common/gdb_setjmp.h: Rename include guard.
1297         * common/gdb_ref_ptr.h: Rename include guard.
1298         * common/gdb_optional.h: Rename include guard.
1299         * common/gdb_locale.h: Rename include guard.
1300         * common/gdb_assert.h: Rename include guard.
1301         * common/filtered-iterator.h: Rename include guard.
1302         * common/filestuff.h: Rename include guard.
1303         * common/fileio.h: Rename include guard.
1304         * common/environ.h: Rename include guard.
1305         * common/common-utils.h: Rename include guard.
1306         * common/common-types.h: Rename include guard.
1307         * common/common-regcache.h: Rename include guard.
1308         * common/common-inferior.h: Rename include guard.
1309         * common/common-gdbthread.h: Rename include guard.
1310         * common/common-exceptions.h: Rename include guard.
1311         * common/common-defs.h: Rename include guard.
1312         * common/common-debug.h: Rename include guard.
1313         * common/cleanups.h: Rename include guard.
1314         * common/buffer.h: Rename include guard.
1315         * common/btrace-common.h: Rename include guard.
1316         * common/break-common.h: Rename include guard.
1317         * cli/cli-utils.h: Rename include guard.
1318         * cli/cli-style.h: Rename include guard.
1319         * cli/cli-setshow.h: Rename include guard.
1320         * cli/cli-script.h: Rename include guard.
1321         * cli/cli-interp.h: Rename include guard.
1322         * cli/cli-decode.h: Rename include guard.
1323         * cli/cli-cmds.h: Rename include guard.
1324         * charset-list.h: Add include guard.
1325         * buildsym-legacy.h: Rename include guard.
1326         * bfin-tdep.h: Add include guard.
1327         * ax.h: Rename include guard.
1328         * arm-linux-tdep.h: Add include guard.
1329         * arm-fbsd-tdep.h: Add include guard.
1330         * arch/xtensa.h: Rename include guard.
1331         * arch/tic6x.h: Add include guard.
1332         * arch/i386.h: Add include guard.
1333         * arch/arm.h: Rename include guard.
1334         * arch/arm-linux.h: Rename include guard.
1335         * arch/arm-get-next-pcs.h: Rename include guard.
1336         * arch/amd64.h: Add include guard.
1337         * arch/aarch64-insn.h: Rename include guard.
1338         * arch-utils.h: Rename include guard.
1339         * annotate.h: Add include guard.
1340         * amd64-darwin-tdep.h: Rename include guard.
1341         * aarch64-linux-tdep.h: Add include guard.
1342         * aarch64-fbsd-tdep.h: Add include guard.
1343         * aarch32-linux-nat.h: Add include guard.
1344
1345 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1346
1347         * macrotab.c (macro_define_internal): New function that
1348         factorizes macro_define_object_internal and macro_define_function
1349         code.
1350         (macro_define_object_internal): Use macro_define_internal.
1351         (macro_define_function): Likewise.
1352
1353 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1354
1355         * macrocmd.c (extract_identifier): Return
1356         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
1357         callers.
1358
1359 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1360
1361         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1362
1363 2019-02-05  Tom Tromey  <tom@tromey.com>
1364
1365         * target.c (target_stack::unpush): Move assertion earlier.
1366
1367 2019-01-30  Tom Tromey  <tom@tromey.com>
1368
1369         PR python/23615:
1370         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1371         (gdbpy_parse_and_eval): Likewise.
1372         * python/python-internal.h (gdbpy_allow_threads): New class.
1373
1374 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1375
1376         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1377         (aarch64_fbsd_fpregmap): Move earlier.
1378         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1379         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1380         instead of individual calls to trad_frame_set_reg_addr.
1381         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1382         earlier.
1383         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1384         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1385         instead of individual calls to trad_frame_set_reg_addr.
1386
1387 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1388
1389         * CONTRIBUTE: Replace contribution list with wiki link.
1390
1391 2019-01-25  Tom Tromey  <tom@tromey.com>
1392
1393         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1394
1395 2019-01-25  Tom Tromey  <tom@tromey.com>
1396
1397         * xtensa-linux-nat.c: Fix common/ includes.
1398         * xml-support.h: Fix common/ includes.
1399         * xml-support.c: Fix common/ includes.
1400         * x86-linux-nat.c: Fix common/ includes.
1401         * windows-nat.c: Fix common/ includes.
1402         * varobj.h: Fix common/ includes.
1403         * varobj.c: Fix common/ includes.
1404         * value.c: Fix common/ includes.
1405         * valops.c: Fix common/ includes.
1406         * utils.c: Fix common/ includes.
1407         * unittests/xml-utils-selftests.c: Fix common/ includes.
1408         * unittests/utils-selftests.c: Fix common/ includes.
1409         * unittests/unpack-selftests.c: Fix common/ includes.
1410         * unittests/tracepoint-selftests.c: Fix common/ includes.
1411         * unittests/style-selftests.c: Fix common/ includes.
1412         * unittests/string_view-selftests.c: Fix common/ includes.
1413         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1414         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1415         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1416         * unittests/rsp-low-selftests.c: Fix common/ includes.
1417         * unittests/parse-connection-spec-selftests.c: Fix common/
1418         includes.
1419         * unittests/optional-selftests.c: Fix common/ includes.
1420         * unittests/offset-type-selftests.c: Fix common/ includes.
1421         * unittests/observable-selftests.c: Fix common/ includes.
1422         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1423         * unittests/memrange-selftests.c: Fix common/ includes.
1424         * unittests/memory-map-selftests.c: Fix common/ includes.
1425         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1426         * unittests/function-view-selftests.c: Fix common/ includes.
1427         * unittests/environ-selftests.c: Fix common/ includes.
1428         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1429         * unittests/common-utils-selftests.c: Fix common/ includes.
1430         * unittests/cli-utils-selftests.c: Fix common/ includes.
1431         * unittests/array-view-selftests.c: Fix common/ includes.
1432         * ui-file.c: Fix common/ includes.
1433         * tui/tui-io.c: Fix common/ includes.
1434         * tracepoint.h: Fix common/ includes.
1435         * tracepoint.c: Fix common/ includes.
1436         * tracefile-tfile.c: Fix common/ includes.
1437         * top.h: Fix common/ includes.
1438         * top.c: Fix common/ includes.
1439         * thread.c: Fix common/ includes.
1440         * target/waitstatus.h: Fix common/ includes.
1441         * target/waitstatus.c: Fix common/ includes.
1442         * target.h: Fix common/ includes.
1443         * target.c: Fix common/ includes.
1444         * target-memory.c: Fix common/ includes.
1445         * target-descriptions.c: Fix common/ includes.
1446         * symtab.h: Fix common/ includes.
1447         * symfile.c: Fix common/ includes.
1448         * stap-probe.c: Fix common/ includes.
1449         * spu-linux-nat.c: Fix common/ includes.
1450         * sparc-nat.c: Fix common/ includes.
1451         * source.c: Fix common/ includes.
1452         * solib.c: Fix common/ includes.
1453         * solib-target.c: Fix common/ includes.
1454         * ser-unix.c: Fix common/ includes.
1455         * ser-tcp.c: Fix common/ includes.
1456         * ser-pipe.c: Fix common/ includes.
1457         * ser-base.c: Fix common/ includes.
1458         * selftest-arch.c: Fix common/ includes.
1459         * s12z-tdep.c: Fix common/ includes.
1460         * rust-exp.y: Fix common/ includes.
1461         * rs6000-aix-tdep.c: Fix common/ includes.
1462         * riscv-tdep.c: Fix common/ includes.
1463         * remote.c: Fix common/ includes.
1464         * remote-notif.h: Fix common/ includes.
1465         * remote-fileio.h: Fix common/ includes.
1466         * remote-fileio.c: Fix common/ includes.
1467         * regcache.h: Fix common/ includes.
1468         * regcache.c: Fix common/ includes.
1469         * record-btrace.c: Fix common/ includes.
1470         * python/python.c: Fix common/ includes.
1471         * python/py-type.c: Fix common/ includes.
1472         * python/py-inferior.c: Fix common/ includes.
1473         * progspace.h: Fix common/ includes.
1474         * producer.c: Fix common/ includes.
1475         * procfs.c: Fix common/ includes.
1476         * proc-api.c: Fix common/ includes.
1477         * printcmd.c: Fix common/ includes.
1478         * ppc-linux-nat.c: Fix common/ includes.
1479         * parser-defs.h: Fix common/ includes.
1480         * osdata.c: Fix common/ includes.
1481         * obsd-nat.c: Fix common/ includes.
1482         * nat/x86-linux.c: Fix common/ includes.
1483         * nat/x86-linux-dregs.c: Fix common/ includes.
1484         * nat/x86-dregs.h: Fix common/ includes.
1485         * nat/x86-dregs.c: Fix common/ includes.
1486         * nat/ppc-linux.c: Fix common/ includes.
1487         * nat/mips-linux-watch.h: Fix common/ includes.
1488         * nat/mips-linux-watch.c: Fix common/ includes.
1489         * nat/linux-waitpid.c: Fix common/ includes.
1490         * nat/linux-ptrace.h: Fix common/ includes.
1491         * nat/linux-ptrace.c: Fix common/ includes.
1492         * nat/linux-procfs.c: Fix common/ includes.
1493         * nat/linux-personality.c: Fix common/ includes.
1494         * nat/linux-osdata.c: Fix common/ includes.
1495         * nat/linux-namespaces.c: Fix common/ includes.
1496         * nat/linux-btrace.h: Fix common/ includes.
1497         * nat/linux-btrace.c: Fix common/ includes.
1498         * nat/fork-inferior.c: Fix common/ includes.
1499         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1500         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1501         * nat/aarch64-linux.c: Fix common/ includes.
1502         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1503         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1504         * namespace.h: Fix common/ includes.
1505         * mips-linux-tdep.c: Fix common/ includes.
1506         * minsyms.c: Fix common/ includes.
1507         * mi/mi-parse.h: Fix common/ includes.
1508         * mi/mi-main.c: Fix common/ includes.
1509         * mi/mi-cmd-env.c: Fix common/ includes.
1510         * memrange.h: Fix common/ includes.
1511         * memattr.c: Fix common/ includes.
1512         * maint.h: Fix common/ includes.
1513         * maint.c: Fix common/ includes.
1514         * main.c: Fix common/ includes.
1515         * machoread.c: Fix common/ includes.
1516         * location.c: Fix common/ includes.
1517         * linux-thread-db.c: Fix common/ includes.
1518         * linux-nat.c: Fix common/ includes.
1519         * linux-fork.c: Fix common/ includes.
1520         * inline-frame.c: Fix common/ includes.
1521         * infrun.c: Fix common/ includes.
1522         * inflow.c: Fix common/ includes.
1523         * inferior.h: Fix common/ includes.
1524         * inferior.c: Fix common/ includes.
1525         * infcmd.c: Fix common/ includes.
1526         * inf-ptrace.c: Fix common/ includes.
1527         * inf-child.c: Fix common/ includes.
1528         * ia64-linux-nat.c: Fix common/ includes.
1529         * i387-tdep.c: Fix common/ includes.
1530         * i386-tdep.c: Fix common/ includes.
1531         * i386-linux-tdep.c: Fix common/ includes.
1532         * i386-linux-nat.c: Fix common/ includes.
1533         * i386-go32-tdep.c: Fix common/ includes.
1534         * i386-fbsd-tdep.c: Fix common/ includes.
1535         * i386-fbsd-nat.c: Fix common/ includes.
1536         * guile/scm-type.c: Fix common/ includes.
1537         * guile/guile.c: Fix common/ includes.
1538         * go32-nat.c: Fix common/ includes.
1539         * gnu-nat.c: Fix common/ includes.
1540         * gdbthread.h: Fix common/ includes.
1541         * gdbarch-selftests.c: Fix common/ includes.
1542         * gdb_usleep.c: Fix common/ includes.
1543         * gdb_select.h: Fix common/ includes.
1544         * gdb_bfd.c: Fix common/ includes.
1545         * gcore.c: Fix common/ includes.
1546         * fork-child.c: Fix common/ includes.
1547         * findvar.c: Fix common/ includes.
1548         * fbsd-nat.c: Fix common/ includes.
1549         * event-top.c: Fix common/ includes.
1550         * event-loop.c: Fix common/ includes.
1551         * dwarf2read.c: Fix common/ includes.
1552         * dwarf2loc.c: Fix common/ includes.
1553         * dwarf2-frame.c: Fix common/ includes.
1554         * dwarf-index-cache.c: Fix common/ includes.
1555         * dtrace-probe.c: Fix common/ includes.
1556         * disasm-selftests.c: Fix common/ includes.
1557         * defs.h: Fix common/ includes.
1558         * csky-tdep.c: Fix common/ includes.
1559         * cp-valprint.c: Fix common/ includes.
1560         * cp-support.h: Fix common/ includes.
1561         * cp-support.c: Fix common/ includes.
1562         * corelow.c: Fix common/ includes.
1563         * completer.h: Fix common/ includes.
1564         * completer.c: Fix common/ includes.
1565         * compile/compile.c: Fix common/ includes.
1566         * compile/compile-loc2c.c: Fix common/ includes.
1567         * compile/compile-cplus-types.c: Fix common/ includes.
1568         * compile/compile-cplus-symbols.c: Fix common/ includes.
1569         * command.h: Fix common/ includes.
1570         * cli/cli-dump.c: Fix common/ includes.
1571         * cli/cli-cmds.c: Fix common/ includes.
1572         * charset.c: Fix common/ includes.
1573         * build-id.c: Fix common/ includes.
1574         * btrace.h: Fix common/ includes.
1575         * btrace.c: Fix common/ includes.
1576         * breakpoint.h: Fix common/ includes.
1577         * breakpoint.c: Fix common/ includes.
1578         * ax.h: 
1579         (enum agent_op): Fix common/ includes.
1580         * ax-general.c (struct aop_map): Fix common/ includes.
1581         * ax-gdb.c: Fix common/ includes.
1582         * auxv.c: Fix common/ includes.
1583         * auto-load.c: Fix common/ includes.
1584         * arm-tdep.c: Fix common/ includes.
1585         * arch/riscv.c: Fix common/ includes.
1586         * arch/ppc-linux-common.c: Fix common/ includes.
1587         * arch/i386.c: Fix common/ includes.
1588         * arch/arm.c: Fix common/ includes.
1589         * arch/arm-linux.c: Fix common/ includes.
1590         * arch/arm-get-next-pcs.c: Fix common/ includes.
1591         * arch/amd64.c: Fix common/ includes.
1592         * arch/aarch64.c: Fix common/ includes.
1593         * arch/aarch64-insn.c: Fix common/ includes.
1594         * arch-utils.c: Fix common/ includes.
1595         * amd64-windows-tdep.c: Fix common/ includes.
1596         * amd64-tdep.c: Fix common/ includes.
1597         * amd64-sol2-tdep.c: Fix common/ includes.
1598         * amd64-obsd-tdep.c: Fix common/ includes.
1599         * amd64-nbsd-tdep.c: Fix common/ includes.
1600         * amd64-linux-tdep.c: Fix common/ includes.
1601         * amd64-linux-nat.c: Fix common/ includes.
1602         * amd64-fbsd-tdep.c: Fix common/ includes.
1603         * amd64-fbsd-nat.c: Fix common/ includes.
1604         * amd64-dicos-tdep.c: Fix common/ includes.
1605         * amd64-darwin-tdep.c: Fix common/ includes.
1606         * agent.c: Fix common/ includes.
1607         * ada-lang.h: Fix common/ includes.
1608         * ada-lang.c: Fix common/ includes.
1609         * aarch64-tdep.c: Fix common/ includes.
1610
1611 2019-01-25  Tom Tromey  <tom@tromey.com>
1612
1613         * common/create-version.sh: Use common/version.h.
1614
1615 2019-01-24  Pedro Alves  <palves@redhat.com>
1616
1617         * infrun.c (signal_stop, signal_print, signal_program)
1618         (signal_catch, signal_pass): Now arrays instead of pointers.
1619         (update_signals_program_target, do_target_resume)
1620         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1621         * linux-nat.c (linux_nat_target::pass_signals)
1622         (linux_nat_target::create_inferior, linux_nat_target::attach):
1623         Adjust.
1624         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1625         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1626         * procfs.c (procfs_target::pass_signals): Adjust.
1627         * record-full.c (record_full_target::resume): Adjust.
1628         * remote.c (remote_target::pass_signals)
1629         (remote_target::program_signals): Adjust.
1630         * target-debug.h (target_debug_print_signals): Now takes a
1631         gdb::array_view as parameter.  Adjust.
1632         * target.h (target_ops) <pass_signals, program_signals>: Replace
1633         pointer and length parameters with gdb::array_view.
1634         (target_pass_signals, target_program_signals): Likewise.
1635         * target-delegates.c: Regenerate.
1636
1637 2019-01-24  Pedro Alves  <palves@redhat.com>
1638
1639         * common/forward-scope-exit.h
1640         (forward_scope_exit::forward_scope_exit): Pass arguments to
1641         m_bind_function directly, instead of creating a std::bind and
1642         copying that.
1643
1644 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1645
1646         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1647         for static members.
1648         (pass_in_v_vfp_candidate): Likewise.
1649
1650 2019-01-23  Tom Tromey  <tom@tromey.com>
1651             Pedro Alves  <palves@redhat.com>
1652
1653         * regcache.c (class regcache_invalidator): Remove.
1654         (regcache::raw_write): Use make_scope_exit.
1655
1656 2019-01-23  Tom Tromey  <tom@tromey.com>
1657
1658         * ui-out.h (class ui_out_emit_type): Update comment.
1659
1660 2019-01-23  Tom Tromey  <tom@tromey.com>
1661
1662         * infrun.c (fetch_inferior_event): Update comment.
1663
1664 2019-01-23  Tom Tromey  <tom@tromey.com>
1665             Pedro Alves  <palves@redhat.com>
1666
1667         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1668         parameter.
1669         (fetch_inferior_event): Use SCOPE_EXIT.
1670
1671
1672 2019-01-23  Tom Tromey  <tom@tromey.com>
1673             Pedro Alves  <palves@redhat.com>
1674
1675         * infrun.c (disable_thread_events): Delete.
1676         (stop_all_threads): Use SCOPE_EXIT.
1677
1678 2019-01-23  Tom Tromey  <tom@tromey.com>
1679             Pedro Alves  <palves@redhat.com>
1680
1681         * symfile.c: Include forward-scope-exit.h.
1682         (clear_symtab_users_cleanup): Replace forward declaration with
1683         a FORWARD_SCOPE_EXIT.
1684         (syms_from_objfile_1): Use the forward_scope_exit and
1685         gdb::optional instead of cleanup_function.
1686         (reread_symbols): Use the forward_scope_exit instead of
1687         cleanup_function.
1688         (clear_symtab_users_cleanup): Remove function.
1689
1690 2019-01-23  Tom Tromey  <tom@tromey.com>
1691             Pedro Alves  <palves@redhat.com>
1692
1693         * linux-nat.c: Include scope-exit.h.
1694         (cleanup_target_stop): Remove.
1695         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1696         SCOPE_EXIT.
1697
1698 2019-01-23  Tom Tromey  <tom@tromey.com>
1699             Pedro Alves  <palves@redhat.com>
1700
1701         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1702         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1703
1704 2019-01-23  Tom Tromey  <tom@tromey.com>
1705             Andrew Burgess  <andrew.burgess@embecosm.com>
1706             Pedro Alves  <palves@redhat.com>
1707
1708         * infrun.c (fetch_inferior_event): Use scope_exit.
1709         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1710         * top.c (execute_command): Use scope_exit.
1711         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1712         * utils.c (do_bpstat_clear_actions_cleanup)
1713         (make_bpstat_clear_actions_cleanup): Remove.
1714
1715 2019-01-23  Tom Tromey  <tom@tromey.com>
1716             Pedro Alves  <palves@redhat.com>
1717
1718         * infrun.c: Include "common/scope-exit.h"
1719         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1720         (wait_for_inferior): Use SCOPE_EXIT.
1721         (fetch_inferior_event): Use scope_exit.
1722
1723 2019-01-23  Tom Tromey  <tom@tromey.com>
1724             Pedro Alves  <palves@redhat.com>
1725
1726         * breakpoint.c (create_breakpoint): Remove cleanup.
1727
1728 2019-01-23  Tom Tromey  <tom@tromey.com>
1729             Andrew Burgess  <andrew.burgess@embecosm.com>
1730             Pedro Alves  <palves@redhat.com>
1731
1732 2019-01-23  Pedro Alves  <palves@redhat.com>
1733
1734         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1735
1736 2019-01-23  Pedro Alves  <palves@redhat.com>
1737             Andrew Burgess  <andrew.burgess@embecosm.com>
1738
1739         * gdbthread.h: Include "common/forward-scope-exit.h".
1740         (scoped_finish_thread_state): Redefine custom class in terms of
1741         forward_scope_exit.
1742
1743 2019-01-23  Pedro Alves  <palves@redhat.com>
1744             Andrew Burgess  <andrew.burgess@embecosm.com>
1745
1746         * common/forward-scope-exit.h: New file.
1747
1748 2019-01-23  Pedro Alves  <palves@redhat.com>
1749             Andrew Burgess  <andrew.burgess@embecosm.com>
1750             Tom Tromey  <tom@tromey.com>
1751
1752         * common/scope-exit.h: New file.
1753
1754 2019-01-23  Pedro Alves  <palves@redhat.com>
1755
1756         * common/preprocessor.h (ESC): Rename to ...
1757         (ESC_PARENS): ... this.
1758         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1759         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1760
1761 2019-01-23  Tom Tromey  <tom@tromey.com>
1762
1763         * language.h (class scoped_switch_to_sym_language_if_auto):
1764         Initialize m_lang in both cases.
1765
1766 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1767
1768         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1769         with XCNEW.
1770
1771 2019-01-22  Tom Tromey  <tom@tromey.com>
1772
1773         * corelow.c: Do not include sys/file.h.
1774
1775 2019-01-22  Tom Tromey  <tom@tromey.com>
1776
1777         * tui/tui-wingeneral.h: Include gdb_curses.h.
1778
1779 2019-01-22  Tom Tromey  <tom@tromey.com>
1780
1781         * source-cache.h (class source_cache) <get_source_lines,
1782         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1783
1784 2019-01-22  Tom Tromey  <tom@tromey.com>
1785
1786         * remote-fileio.h (struct remote_target): Declare.
1787
1788 2019-01-22  Tom Tromey  <tom@tromey.com>
1789
1790         * python/py-arch.c: Do not include py-ref.h.
1791         * python/py-bpevent.c: Do not include py-ref.h.
1792         * python/py-cmd.c: Do not include py-ref.h.
1793         * python/py-continueevent.c: Do not include py-ref.h.
1794         * python/py-event.h: Do not include py-ref.h.
1795         * python/py-evtregistry.c: Do not include py-ref.h.
1796         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1797         * python/py-frame.c: Do not include py-ref.h.
1798         * python/py-framefilter.c: Do not include py-ref.h.
1799         * python/py-function.c: Do not include py-ref.h.
1800         * python/py-infevents.c: Do not include py-ref.h.
1801         * python/py-linetable.c: Do not include py-ref.h.
1802         * python/py-objfile.c: Do not include py-ref.h.
1803         * python/py-param.c: Do not include py-ref.h.
1804         * python/py-prettyprint.c: Do not include py-ref.h.
1805         * python/py-progspace.c: Do not include py-ref.h.
1806         * python/py-symbol.c: Do not include py-ref.h.
1807         * python/py-symtab.c: Do not include py-ref.h.
1808         * python/py-type.c: Do not include py-ref.h.
1809         * python/py-unwind.c: Do not include py-ref.h.
1810         * python/py-utils.c: Do not include py-ref.h.
1811         * python/py-value.c: Do not include py-ref.h.
1812         * python/py-varobj.c: Do not include py-ref.h.
1813         * python/py-xmethods.c: Do not include py-ref.h.
1814         * python/python.c: Do not include py-ref.h.
1815         * varobj.c: Do not include py-ref.h.
1816
1817 2019-01-22  Tom Tromey  <tom@tromey.com>
1818
1819         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1820         keyword for bcache.
1821
1822 2019-01-22  Tom Tromey  <tom@tromey.com>
1823
1824         * compile/compile-cplus-types.c: Remove a comment by #include.
1825
1826 2019-01-22  Tom Tromey  <tom@tromey.com>
1827
1828         * compile/gcc-c-plugin.h: Include compile-internal.h.
1829
1830 2019-01-22  Tom Tromey  <tom@tromey.com>
1831
1832         * stabsread.c (EXTERN): Do not define.
1833         (symnum, next_symbol_text_func, processing_gcc_compilation)
1834         (within_function, global_sym_chain, global_stabs)
1835         (previous_stab_code, this_object_header_files)
1836         (n_this_object_header_files)
1837         (n_allocated_this_object_header_files): Define.
1838         * stabsread.h (EXTERN): Never define.  Use "extern".
1839
1840 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1841
1842         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1843         history_value.
1844
1845 2019-01-21  Tom Tromey  <tom@tromey.com>
1846
1847         * ui-out.c: Fix includes.
1848         * tui/tui-source.c: Fix includes.
1849         * target.c: Fix includes.
1850         * remote.c: Fix includes.
1851         * regcache.c: Fix includes.
1852         * python/py-block.c: Fix includes.
1853         * printcmd.c: Fix includes.
1854         * or1k-tdep.c: Fix includes.
1855         * mi/mi-main.c: Fix includes.
1856         * m32r-tdep.c: Fix includes.
1857         * csky-tdep.c: Fix includes.
1858         * compile/compile-cplus-types.c: Fix includes.
1859         * cli/cli-interp.c: Fix includes.
1860
1861 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1862
1863         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1864         for padding.
1865
1866 2019-01-16  Tom Tromey  <tom@tromey.com>
1867
1868         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1869         earlier.
1870         (struct objfile) <msymbols_range>: Move from top level.
1871         <msymbols>: New method.
1872         (class objfile_msymbols): Remove.
1873         * symtab.c (default_collect_symbol_completion_matches_break_on):
1874         Update.
1875         * symmisc.c (dump_msymbols): Update.
1876         * stabsread.c (scan_file_globals): Update.
1877         * objc-lang.c (info_selectors_command, info_classes_command)
1878         (find_methods): Update.
1879         * minsyms.c (find_solib_trampoline_target): Update.
1880         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1881         * coffread.c (coff_symfile_read): Update.
1882         * ada-lang.c (ada_lookup_simple_minsym)
1883         (ada_collect_symbol_completion_matches): Update.
1884
1885 2019-01-16  Tom Tromey  <tom@tromey.com>
1886
1887         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1888         type.  Remove no-argument constructor.
1889         <iterator::operator++>: Simplify.
1890         <begin>: Update.
1891         <end>: Use minimal_symbol_count.
1892
1893 2019-01-16  Tom Tromey  <tom@tromey.com>
1894
1895         * objfiles.h (struct objfile) <psymtabs>: New method.
1896         (class objfile_psymtabs): Remove.
1897         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1898         typedef.
1899         <range>: New method.
1900         (require_partial_symbols): Change return type.
1901         * psymtab.c (require_partial_symbols)
1902         (psym_expand_symtabs_matching): Update.
1903         * mdebugread.c (parse_partial_symbols): Update.
1904         * dbxread.c (dbx_end_psymtab): Update.
1905
1906 2019-01-15  Tom Tromey  <tom@tromey.com>
1907
1908         * symtab.c (lookup_objfile_from_block)
1909         (lookup_symbol_in_objfile_symtabs)
1910         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1911         (find_line_symtab, info_sources_command)
1912         (default_collect_symbol_completion_matches_break_on)
1913         (make_source_files_completion_list): Update.
1914         * symmisc.c (print_objfile_statistics, dump_objfile)
1915         (maintenance_print_symbols, maintenance_info_symtabs)
1916         (maintenance_check_symtabs, maintenance_info_line_tables):
1917         Update.
1918         * source.c (select_source_symtab)
1919         (forget_cached_source_info_for_objfile): Update.
1920         * objfiles.h (class objfile_compunits): Remove.
1921         (struct objfile) <compunits_range>: New typedef.
1922         (compunits): New method.
1923         * objfiles.c (objfile_relocate1): Update.
1924         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1925         * maint.c (count_symtabs_and_blocks): Update.
1926         * linespec.c (iterate_over_all_matching_symtabs): Update.
1927         * cp-support.c (add_symbol_overload_list_qualified): Update.
1928         * coffread.c (coff_symtab_read): Update.
1929         * ada-lang.c (add_nonlocal_symbols)
1930         (ada_collect_symbol_completion_matches)
1931         (ada_add_global_exceptions): Update.
1932
1933 2019-01-15  Tom Tromey  <tom@tromey.com>
1934
1935         * progspace.h (program_space) <objfiles_safe_range>: New
1936         typedef.
1937         <objfiles_safe>: New method.
1938         * objfiles.h (class all_objfiles_safe): Remove.
1939         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1940         * jit.c (jit_inferior_exit_hook): Update.
1941
1942 2019-01-17  Tom Tromey  <tom@tromey.com>
1943
1944         * progspace.h (program_space) <objfiles_range>: New typedef.
1945         <objfiles>: New method.
1946         <objfiles_head>: Rename from objfiles.
1947         (object_files): Update.
1948         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1949         * guile/scm-pretty-print.c
1950         (ppscm_find_pretty_printer_from_objfiles): Update.
1951         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1952         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1953         Update.
1954         * python/py-progspace.c (pspy_get_objfiles): Update.
1955         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1956         Update.
1957         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1958         (objfpy_lookup_objfile_by_build_id): Update.
1959         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1960         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1961         Update.
1962         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1963         (expand_symtab_containing_pc, lookup_objfile_from_block)
1964         (lookup_static_symbol, basic_lookup_transparent_type)
1965         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1966         (find_line_symtab, info_sources_command)
1967         (default_collect_symbol_completion_matches_break_on)
1968         (make_source_files_completion_list, find_main_name): Update.
1969         * symmisc.c (print_symbol_bcache_statistics)
1970         (print_objfile_statistics, maintenance_print_symbols)
1971         (maintenance_print_msymbols, maintenance_print_objfiles)
1972         (maintenance_info_symtabs, maintenance_check_symtabs)
1973         (maintenance_expand_symtabs, maintenance_info_line_tables):
1974         Update.
1975         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1976         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1977         (map_overlay_command, unmap_overlay_command)
1978         (simple_overlay_update, expand_symtabs_matching)
1979         (map_symbol_filenames): Update.
1980         * symfile-debug.c (set_debug_symfile): Update.
1981         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1982         Update.
1983         * source.c (select_source_symtab, forget_cached_source_info):
1984         Update.
1985         * solib.c (solib_read_symbols): Update.
1986         * solib-spu.c (append_ocl_sos): Update.
1987         * psymtab.c (maintenance_print_psymbols)
1988         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1989         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1990         * printcmd.c (info_symbol_command): Update.
1991         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1992         Update.
1993         * objfiles.h (class all_objfiles): Remove.
1994         * objfiles.c (have_partial_symbols, have_full_symbols)
1995         (have_minimal_symbols, qsort_cmp, update_section_map)
1996         (shared_objfile_contains_address_p)
1997         (default_iterate_over_objfiles_in_search_order): Update.
1998         * objc-lang.c (info_selectors_command, info_classes_command)
1999         (find_methods): Update.
2000         * minsyms.c (find_solib_trampoline_target): Update.
2001         * maint.c (maintenance_info_sections)
2002         (maintenance_translate_address, count_symtabs_and_blocks):
2003         Update.
2004         * main.c (captured_main_1): Update.
2005         * linux-thread-db.c (try_thread_db_load_from_pdir)
2006         (has_libpthread): Update.
2007         * linespec.c (iterate_over_all_matching_symtabs)
2008         (search_minsyms_for_name): Update.
2009         * jit.c (jit_find_objf_with_entry_addr): Update.
2010         * hppa-tdep.c (find_unwind_entry)
2011         (hppa_lookup_stub_minimal_symbol): Update.
2012         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2013         Update.
2014         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2015         (elf_gnu_ifunc_resolve_by_got): Update.
2016         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2017         * dwarf-index-write.c (save_gdb_index_command): Update.
2018         * cp-support.c (add_symbol_overload_list_qualified): Update.
2019         * breakpoint.c (create_overlay_event_breakpoint)
2020         (create_longjmp_master_breakpoint)
2021         (create_std_terminate_master_breakpoint)
2022         (create_exception_master_breakpoint): Update.
2023         * blockframe.c (find_pc_partial_function): Update.
2024         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2025         (ada_collect_symbol_completion_matches)
2026         (ada_add_global_exceptions): Update.
2027
2028 2019-01-17  Tom Tromey  <tom@tromey.com>
2029
2030         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2031         declare VEC.
2032         (solib_target_parse_libraries): Change return type.
2033         (library_list_start_segment, library_list_start_section)
2034         (library_list_end_library, library_list_start_library); Update.
2035         (solib_target_free_library_list): Remove.
2036         (solib_target_parse_libraries): Remove cleanup.  Change return
2037         type.
2038         (solib_target_current_sos): Update.
2039
2040 2019-01-17  Tom Tromey  <tromey@bapiya>
2041
2042         * valprint.c: Replace "the the" with "the".
2043         * symtab.c: Replace "the the" with "the".
2044         * solib.c: Replace "the the" with "the".
2045         * solib-dsbt.c: Replace "the the" with "the".
2046         * linespec.c: Replace "the the" with "the".
2047         * dwarf2loc.h: Replace "the the" with "the".
2048         * amd64-windows-tdep.c: Replace "the the" with "the".
2049         * aarch64-tdep.c: Replace "the the" with "the".
2050
2051 2019-01-16  Keith Seitz  <keiths@redhat.com>
2052
2053         PR gdb/23773
2054         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2055         <builder>: Rename to ..
2056         <m_builder>: ... this and make private.
2057         (dwarf2_cu::get_builder): New method.  Change all users of
2058         `builder' to use this method.
2059         (dwarf2_start_symtab): Move to ...
2060         (dwarf2_cu::start_symtab): ... here.  Update all callers
2061         (setup_type_unit_groups): Move to ...
2062         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
2063         callers.
2064         (dwarf2_cu::reset_builder): New method.
2065         (process_full_compunit, process_full_type_unit): Use
2066         dwarf2_cu::reset_builder.
2067         (follow_die_offset): Record the ancestor CU if it is different
2068         from the followed DIE's CU.
2069         (follow_die_sig_1): Likewise.
2070
2071 2019-01-15  Tom Tromey  <tom@tromey.com>
2072
2073         * remote.c (class remote_state) <buf>: Now a char_vector.
2074         <buf_size>: Remove.
2075         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
2076         parameter.
2077         (remote_target::getpkt_or_notif_sane_1)
2078         (remote_target::getpkt_sane)
2079         (remote_target::getpkt_or_notif_sane): Likewise.
2080         (class remote_target) <putpkt>: New overload.
2081         (remote_target::read_frame): Change type of "buf_p".  Remove
2082         sizeof_p parameter.
2083         (packet_ok): New overload.
2084         (packet_check_result): New overload.
2085         Update all uses.
2086
2087 2019-01-14  Tom Tromey  <tom@tromey.com>
2088
2089         * remote-notif.c (handle_notification, remote_notif_ack)
2090         (remote_notif_parse): Make "buf" const.
2091         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
2092         const.
2093         (remote_notif_parse, remote_notif_ack, handle_notification):
2094         Likewise.
2095         * remote.c (remote_notif_stop_parse): Make "buf" const.
2096         (remote_target::remote_parse_stop_reply): Make "buf" const.
2097         (remote_notif_stop_ack): Make "buf" const.
2098
2099 2019-01-14  Tom Tromey  <tom@tromey.com>
2100
2101         * remote.c (remote_console_output): Make parameter const.
2102
2103 2019-01-14  Tom Tromey  <tom@tromey.com>
2104
2105         * target-debug.h (target_debug_print_signals): Constify.
2106         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
2107         * procfs.c (procfs_target::pass_signals): Update.
2108         * linux-nat.c (linux_nat_target::pass_signals): Update.
2109         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
2110         * target-delegates.c: Rebuild.
2111         * remote.c (remote_target::program_signals): Update.
2112         (remote_target::pass_signals): Update.
2113         * target.c (target_pass_signals): Constify argument.
2114         (target_program_signals): Likewise.
2115         * target.h (struct target_ops) <pass_signals, program_signals>:
2116         Constify argument.
2117         (target_pass_signals, target_program_signals): Constify argument.
2118
2119 2019-01-14  Tom Tromey  <tom@tromey.com>
2120
2121         PR tui/28819:
2122         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
2123
2124 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2125
2126         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
2127         field.
2128         * rs6000-tdep.c: Include reggroups.h.
2129         (IS_V_ALIAS_PSEUDOREG): Define.
2130         (rs6000_register_name): Return names for the "vX" aliases.
2131         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
2132         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
2133         aliases.  Call default_register_reggroup_p for all other
2134         pseudo-registers.
2135         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
2136         New functions.
2137         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
2138         Handle "vX" aliases.
2139         (v_alias_pseudo_register_collect): New function.
2140         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
2141         (rs6000_gdbarch_init): Initialize "vX" aliases as
2142         pseudo-registers.  Restore registration of
2143         rs6000_pseudo_register_reggroup_p with
2144         set_tdesc_pseudo_register_reggroup_p.
2145
2146 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
2147
2148         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
2149         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
2150         set_gdbarch_num_pseudo_regs.
2151
2152 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2153
2154         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
2155         Remove arg prefixname, add do_set and do_show.
2156         Add member functions set_list and show_list.
2157         * cli/cli-style.c (class cli_style_option): Update accordingly.
2158         (style_set_list): Move to file scope.
2159         (style_show_list): Likewise.
2160         (set_style): Call help_list.
2161         (show_style): Call cmd_show_list.
2162         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
2163         Update to use the new macro.
2164
2165 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
2166
2167         * ada-lang.c (_initialize_ada_language): Expand the help text
2168         for the "catch exception" command.
2169
2170 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2171
2172         * symtab.c (matching_obj_sections): Initialize obj,
2173         declare it closer to its usage.
2174
2175 2019-01-10  Tom Tromey  <tom@tromey.com>
2176
2177         * thread-iter.h (inf_threads_iterator): Use next_iterator.
2178         (basic_inf_threads_range): Remove.
2179         (inf_threads_range, inf_non_exited_threads_range)
2180         (safe_inf_threads_range): Use next_adapter.
2181
2182 2019-01-10  Keith Seitz  <keiths@redhat.com>
2183
2184         PR gdb/23712
2185         PR symtab/23010
2186         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
2187         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
2188
2189 2019-01-10  Keith Seitz  <keiths@redhat.com>
2190
2191         PR gdb/23712
2192         PR symtab/23010
2193         * dictionary.c (pending_to_vector): Remove.
2194         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2195         Remove _1 suffix, replacing functions of the same name.  Update
2196         all callers.
2197         (dict_create_hashed, dict_create_hashed_expandable)
2198         (dict_create_linear, dict_create_linear_expandable, dict_free)
2199         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
2200         Make functions static.
2201
2202 2019-01-10  Keith Seitz  <keiths@redhat.com>
2203
2204         PR gdb/23712
2205         PR symtab/23010
2206         * dictionary.h (struct dictionary): Replace declaration with
2207         multidictionary.
2208         (dict_create_hashed, dict_create_hashed_expandable)
2209         (dict_create_linear, dict_create_linear_expandable)
2210         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
2211         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
2212         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
2213         taking multidictionary argument.
2214         [ALL_DICT_SYMBOLS]: Update for multidictionary.
2215         * block.h (struct block) <dict>: Change to multidictionary
2216         and rename `multidict'.
2217         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
2218         symmisc.c: Update all dictionary references to multidictionary.
2219
2220 2019-01-10  Keith Seitz  <keiths@redhat.com>
2221
2222         PR gdb/23712
2223         PR symtab/23010
2224         * dictionary.c: Include unordered_map.
2225         (pending_to_vector): New function.
2226         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2227         Rewrite the non-"_1" functions to take vector instead
2228         of linked list.
2229         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
2230         "new" _1 versions of the same name.
2231         (multidictionary): Define.
2232         (std::hash<enum language): New definition.
2233         (collate_pending_symbols_by_language, mdict_create_hashed)
2234         (mdict_create_hashed_expandable, mdict_create_linear)
2235         (mdict_create_linear_expandable, mdict_free)
2236         (find_language_dictionary, create_new_language_dictionary)
2237         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
2238         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
2239         (mdict_size, mdict_empty): New functions.
2240         * dictionary.h (mdict_iterator): Define.
2241
2242 2019-01-10  Pedro Alves  <palves@redhat.com>
2243
2244         * breakpoint.c (read_uploaded_action)
2245         (create_tracepoint_from_upload): Adjust to use
2246         gdb::unique_xmalloc_ptr.
2247         * ctf.c (ctf_write_uploaded_tp):
2248         (SET_ARRAY_FIELD): Use emplace_back.
2249         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
2250         * tracefile-tfile.c (tfile_write_uploaded_tp):
2251         * tracepoint.c (parse_tracepoint_definition): Adjust to use
2252         gdb::unique_xmalloc_ptr.
2253         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
2254         at_string, cond_string, cmd_strings>: Replace char pointers
2255         with gdb::unique_xmalloc_ptr.
2256
2257 2019-01-10  Pedro Alves  <palves@redhat.com>
2258
2259         * solib-target.c (library_list_start_library): Don't xstrdup name.
2260
2261 2019-01-10  Pedro Alves  <palves@redhat.com>
2262
2263         * mdebugread.c (parse_partial_symbols): Use
2264         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
2265
2266 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2267
2268         * linux-fork.c (scoped_switch_fork_info)
2269         <~scoped_switch_fork_info>: Fix incorrect variable name.
2270
2271 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2272
2273         * linux-fork.c (scoped_switch_fork_info)
2274         <scoped_switch_fork_info>: Make explicit.
2275         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
2276
2277 2019-01-10  Tom Tromey  <tom@tromey.com>
2278
2279         * objfiles.h (objfile::reset_psymtabs): Update.
2280         * objfiles.c (objfile::objfile): Update.
2281         * psymtab.h (psymtab_storage::obstack): Update.
2282         (psymtab_storage::m_obstack): Use gdb::optional.
2283         (class psymtab_storage): Update comment.  Remove objfile
2284         parameter.
2285         * psymtab.c (psymtab_storage::psymtab_storage): Update.
2286
2287 2019-01-10  Tom Tromey  <tom@tromey.com>
2288
2289         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
2290         <free_psymtabs>: Now private.
2291         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
2292         (allocate_psymtab): Use new method.
2293
2294 2019-01-10  Tom Tromey  <tom@tromey.com>
2295
2296         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
2297         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
2298         * mdebugread.c (parse_partial_symbols): Use
2299         allocate_dependencies.
2300         * dwarf2read.c (dwarf2_create_include_psymtab): Use
2301         allocate_dependencies.
2302         (process_psymtab_comp_unit_reader)
2303         (build_type_psymtab_dependencies): Likewise.
2304         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
2305
2306 2019-01-10  Tom Tromey  <tom@tromey.com>
2307
2308         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
2309         PSYMBOL_SET_LANGUAGE.
2310         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
2311
2312 2019-01-10  Tom Tromey  <tom@tromey.com>
2313
2314         * psymtab.h (psymtab_storage::obstack): New method.
2315         <m_obstack>: Rename from obstack; now private.
2316         * psymtab.c (psymtab_storage): Update.
2317         * dwarf2read.c (create_addrmap_from_index)
2318         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
2319         Update.
2320
2321 2019-01-10  Tom Tromey  <tom@tromey.com>
2322
2323         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
2324         * objfiles.h (objfile::reset_psymtabs): New method.
2325
2326 2019-01-10  Tom Tromey  <tom@tromey.com>
2327
2328         * symmisc.c (print_symbol_bcache_statistics): Update.
2329         (print_objfile_statistics): Update.
2330         * symfile.c (reread_symbols): Update.
2331         * psymtab.h (class psymtab_storage): New.
2332         * psymtab.c (psymtab_storage): New constructor.
2333         (~psymtab_storage): New destructor.
2334         (require_partial_symbols): Update.
2335         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
2336         (find_pc_sect_psymtab, find_pc_sect_psymbol)
2337         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
2338         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
2339         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
2340         (start_psymtab_common, end_psymtab_common)
2341         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
2342         (allocate_psymtab): Update.
2343         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
2344         Update.
2345         (dump_psymtab_addrmap, maintenance_print_psymbols)
2346         (maintenance_check_psymtabs): Update.
2347         (class objfile_psymtabs): Move to objfiles.h.
2348         * psympriv.h (discard_psymtab): Now inline.
2349         (psymtab_discarder::psymtab_discarder): Update.
2350         (psymtab_discarder::~psymtab_discarder): Update.
2351         (ALL_OBJFILE_PSYMTABS): Rewrite.
2352         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
2353         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
2354         Remove fields.
2355         <partial_symtabs>: New field.
2356         (class objfile_psymtabs): Move from psymtab.h.  Update.
2357         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
2358         psymbol_cache.
2359         (objfile::~objfile): Don't destroy psymbol_cache.
2360         * mdebugread.c (parse_partial_symbols): Update.
2361         * dwarf2read.c (create_addrmap_from_index)
2362         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2363         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2364         (add_partial_subprogram, dwarf2_ranges_read): Update.
2365         * dwarf-index-write.c (write_address_map)
2366         (write_one_signatured_type, recursively_write_psymbols)
2367         (class debug_names, class debug_names, write_psymtabs_to_index):
2368         Update.
2369
2370 2019-01-10  Tom Tromey  <tom@tromey.com>
2371
2372         * symtab.h (SYMBOL_SET_NAMES): Update.
2373         (symbol_set_names): Update.
2374         (MSYMBOL_SET_NAMES): Update.
2375         * symtab.c (symbol_set_names): Change argument to be an
2376         objfile_per_bfd_storage.
2377         * psymtab.c (add_psymbol_to_bcache): Update.
2378         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2379
2380 2019-01-10  Tom Tromey  <tom@tromey.com>
2381
2382         * symtab.c (create_demangled_names_hash): Change argument to be an
2383         objfile_per_bfd_storage.
2384         (symbol_set_names): Update.
2385
2386 2019-01-10  Tom Tromey  <tom@tromey.com>
2387
2388         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2389         init_psymbol_list.
2390         * psymtab.c (init_psymbol_list): Do nothing if already called.
2391         * psympriv.h (init_psymbol_list): Add comment.
2392         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2393         init_psymbol_list.
2394         * dbxread.c (dbx_symfile_read): Unconditionally call
2395         init_psymbol_list.
2396
2397 2019-01-10  Tom Tromey  <tom@tromey.com>
2398
2399         * xcoffread.c (scan_xcoff_symtab): Update.
2400         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2401         "where".
2402         * mdebugread.c (parse_partial_symbols)
2403         (handle_psymbol_enumerators): Update.
2404         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2405         * dbxread.c (read_dbx_symtab): Update.
2406         * psympriv.h (psymbol_placement): New enum.
2407         (add_psymbol_to_list): Update.
2408
2409 2019-01-10  Tom Tromey  <tom@tromey.com>
2410
2411         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2412         static_psymbols parameters.
2413         (scan_xcoff_symtab): Update.
2414         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2415         static_psymbols parameters.
2416         * psympriv.h (start_psymtab_common): Update.
2417         * mdebugread.c (parse_partial_symbols): Update.
2418         * dwarf2read.c (create_partial_symtab): Update.
2419         * dbxread.c (read_dbx_symtab): Update.
2420         (start_psymtab): Remove global_psymbols and static_psymbols
2421         parameters.
2422
2423 2019-01-10  Tom Tromey  <tom@tromey.com>
2424
2425         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2426         * psymtab.c (allocate_psymtab): Add comment.
2427         * psympriv.h (allocate_psymtab): Add comment.
2428         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2429         initializations.
2430         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2431
2432 2019-01-10  Tom Tromey  <tom@tromey.com>
2433
2434         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2435         Don't declare.
2436         * mipsread.c: Include mdebugread.h.
2437         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2438         Declare.
2439         * elfread.c: Include mdebugread.h.
2440
2441 2019-01-09  Tom Tromey  <tom@tromey.com>
2442
2443         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2444         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2445         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2446         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2447         (psym_lookup_symbol, psym_find_last_source_symtab)
2448         (psym_forget_cached_source_info, psym_print_stats)
2449         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2450         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2451         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2452         (psym_find_compunit_symtab_by_address)
2453         (maintenance_print_psymbols, maintenance_info_psymtabs)
2454         (maintenance_check_psymtabs): Use ranged for.
2455         * psymtab.h (class objfile_psymtabs): New.
2456         (require_partial_symbols): Return objfile_psymtabs.
2457         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2458
2459 2019-01-09  Tom Tromey  <tom@tromey.com>
2460
2461         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2462         (find_pc_mapped_section, list_overlays_command)
2463         (map_overlay_command, unmap_overlay_command)
2464         (simple_overlay_update): Use all_objfiles.
2465         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2466         * printcmd.c (info_symbol_command): Use all_objfiles.
2467         * objfiles.h (ALL_OBJSECTIONS): Remove.
2468         * maint.c (maintenance_translate_address): Use all_objfiles.
2469         * gcore.c (gcore_create_callback): Use all_objfiles.
2470         (objfile_find_memory_regions): Likewise.
2471
2472 2019-01-09  Tom Tromey  <tom@tromey.com>
2473
2474         * symtab.c (find_line_symtab, info_sources_command)
2475         (make_source_files_completion_list): Use objfile_compunits.
2476         * source.c (select_source_symtab): Use objfile_compunits.
2477         * objfiles.h (struct objfile): Update comment.
2478         (ALL_OBJFILES): Remove.
2479         (ALL_FILETABS): Remove.
2480         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2481         objfile_compunits.
2482
2483 2019-01-09  Tom Tromey  <tom@tromey.com>
2484
2485         * symmisc.c (print_objfile_statistics, dump_objfile)
2486         (maintenance_print_symbols): Use compunit_filetabs.
2487         * source.c (forget_cached_source_info_for_objfile): Use
2488         compunit_filetabs.
2489         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2490         (ALL_FILETABS): Use compunit_filetabs.
2491         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2492         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2493
2494 2019-01-09  Tom Tromey  <tom@tromey.com>
2495
2496         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2497         (compunit_filetabs): New.
2498         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2499         compunit_filetabs.
2500         (info_sources_command, make_source_files_completion_list): Remove
2501         declaration.
2502         * symmisc.c (print_objfile_statistics, dump_objfile)
2503         (maintenance_print_symbols): Remove declaration.
2504         (maintenance_info_symtabs): Use compunit_filetabs.
2505         (maintenance_info_line_tables): Likewise.
2506         * source.c (select_source_symtab): Change local variable name.
2507         (forget_cached_source_info_for_objfile): Remove declaration.
2508         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2509         * objfiles.c (objfile_relocate1): Remove declaration.
2510         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2511         declaration.
2512         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2513         * coffread.c (coff_symtab_read): Remove declaration.
2514         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2515         compunit_filetabs.
2516
2517 2019-01-09  Tom Tromey  <tom@tromey.com>
2518
2519         * symtab.c (lookup_objfile_from_block)
2520         (find_pc_sect_compunit_symtab, search_symbols)
2521         (default_collect_symbol_completion_matches_break_on): Use
2522         objfile_compunits.
2523         * objfiles.h (ALL_COMPUNITS): Remove.
2524         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2525         * cp-support.c (add_symbol_overload_list_qualified): Use
2526         objfile_compunits.
2527         * ada-lang.c (ada_collect_symbol_completion_matches)
2528         (ada_add_global_exceptions): Use objfile_compunits.
2529
2530 2019-01-09  Tom Tromey  <tom@tromey.com>
2531
2532         * source.c (select_source_symtab)
2533         (forget_cached_source_info_for_objfile): Remove declaration.
2534         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2535         declaration.
2536         * maint.c (count_symtabs_and_blocks): Remove declaration.
2537         * cp-support.c (add_symbol_overload_list_qualified): Remove
2538         declaration.
2539         * coffread.c (coff_symtab_read): Remove declaration.
2540         * symtab.c (lookup_symbol_in_objfile_symtabs)
2541         (basic_lookup_transparent_type_1): Use objfile_compunits.
2542         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2543         (info_sources_command, search_symbols)
2544         (default_collect_symbol_completion_matches_break_on)
2545         (make_source_files_completion_list): Remove declaration.
2546         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2547         (ada_collect_symbol_completion_matches)
2548         (ada_add_global_exceptions): Remove declaration.
2549         * linespec.c (iterate_over_all_matching_symtabs): Use
2550         objfile_compunits.
2551         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2552         (class objfile_compunits): New.
2553         (ALL_COMPUNITS): Use objfile_compunits.
2554         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2555         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2556         objfile_compunits.
2557         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2558
2559 2019-01-09  Tom Tromey  <tom@tromey.com>
2560
2561         * symtab.c (search_symbols)
2562         (default_collect_symbol_completion_matches_break_on): Use
2563         objfile_msymbols.
2564         * ada-lang.c (ada_lookup_simple_minsym)
2565         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2566         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2567         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2568         objfile_msymbols.
2569         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2570         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2571         * objc-lang.c (find_methods): Use objfile_msymbols.
2572         (info_selectors_command, info_classes_command): Likewise.
2573         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2574         * objfiles.h (class objfile_msymbols): New.
2575         (ALL_OBJFILE_MSYMBOLS): Remove.
2576         (ALL_MSYMBOLS): Remove.
2577
2578 2019-01-09  Tom Tromey  <tom@tromey.com>
2579
2580         * common/next-iterator.h (next_adapter): Add Iterator template
2581         parameter.
2582         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2583         (class all_objfiles_safe): New.
2584         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2585         * objfiles.c (put_objfile_before): Update comment.
2586         (add_separate_debug_objfile): Likewise.
2587         (free_all_objfiles): Use all_objfiles_safe.
2588         (objfile_purge_solibs): Likewise.
2589
2590 2019-01-09  Tom Tromey  <tom@tromey.com>
2591
2592         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2593         (expand_symtab_containing_pc, lookup_static_symbol)
2594         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2595         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2596         all_objfiles.
2597         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2598         * breakpoint.c (create_overlay_event_breakpoint)
2599         (create_longjmp_master_breakpoint)
2600         (create_std_terminate_master_breakpoint)
2601         (create_exception_master_breakpoint): Use all_objfiles.
2602         * linux-thread-db.c (try_thread_db_load_from_pdir)
2603         (has_libpthread): Use all_objfiles.
2604         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2605         * linespec.c (iterate_over_all_matching_symtabs)
2606         (search_minsyms_for_name): Use all_objfiles.
2607         * maint.c (maintenance_info_sections): Use all_objfiles.
2608         * main.c (captured_main_1): Use all_objfiles.
2609         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2610         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2611         * guile/scm-pretty-print.c
2612         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2613         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2614         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2615         (maintenance_print_msymbols): Use all_objfiles.
2616         * source.c (select_source_symtab): Use all_objfiles.
2617         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2618         * symfile.c (remove_symbol_file_command)
2619         (expand_symtabs_matching, map_symbol_filenames): Use
2620         all_objfiles.
2621         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2622         all_objfiles.
2623         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2624         * objc-lang.c (find_methods): Use all_objfiles.
2625         * objfiles.c (have_partial_symbols, have_full_symbols)
2626         (have_minimal_symbols, qsort_cmp)
2627         (default_iterate_over_objfiles_in_search_order): Use
2628         all_objfiles.
2629         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2630         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2631         (maintenance_check_psymtabs): Use all_objfiles.
2632         (ALL_PSYMTABS): Remove.
2633         * compile/compile-object-run.c (do_module_cleanup): Use
2634         all_objfiles.
2635         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2636         * cp-support.c (add_symbol_overload_list_qualified): Use
2637         all_objfiles.
2638         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2639         Use all_objfiles.
2640         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2641         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2642         all_objfiles.
2643         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2644         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2645         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2646         Uses all_objfiles.
2647         * solib.c (solib_read_symbols): Use all_objfiles
2648
2649 2019-01-09  Tom Tromey  <tom@tromey.com>
2650
2651         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2652         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2653         all_objfiles.
2654         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2655         * symmisc.c (print_symbol_bcache_statistics)
2656         (print_objfile_statistics, maintenance_print_objfiles)
2657         (maintenance_info_symtabs, maintenance_check_symtabs)
2658         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2659         all_objfiles.
2660         * source.c (forget_cached_source_info): Use all_objfiles.
2661         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2662         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2663         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2664         * objfiles.c (update_section_map): Use all_objfiles.
2665         (shared_objfile_contains_address_p): Likewise.
2666         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2667         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2668
2669 2019-01-09  Tom Tromey  <tom@tromey.com>
2670
2671         * common/next-iterator.h: New file.
2672         * objfiles.h (class all_objfiles): New.
2673         (struct objfile_iterator): New.
2674
2675 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2676
2677         * NEWS: Move the description of the changed "frame", "select-frame",
2678          and "info frame" commands to the Changed commands section.
2679
2680 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2681
2682         * gdbtypes.c (check_stub_method_group): Remove handling of old
2683         mangling schemes.
2684         * linespec.c (find_methods): Likewise.
2685         * stabsread.c (read_member_functions): Likewise.
2686         * valops.c (search_struct_method): Likewise.
2687         (value_struct_elt_for_reference): Likewise.
2688         * NEWS: Mention this change.
2689
2690 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2691
2692         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2693         print_source_lines.
2694         * source.c (print_source_lines_base): Update line number check.
2695         (print_source_lines): New function.
2696         (source_lines_range::source_lines_range): New function.
2697         * source.h (class source_lines_range): New class.
2698         (print_source_lines): New declaration.
2699
2700 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2701
2702         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2703
2704 2019-01-08  Tom Tromey  <tom@tromey.com>
2705             Simon Marchi  <simon.marchi@ericsson.com>
2706
2707         PR gdb/24060
2708         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2709         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2710         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2711         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2712         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2713         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2714
2715 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2716
2717         * source.c (select_source_symtab): Move header comment to
2718         declaration in source.h.
2719         (forget_cached_source_info_for_objfile): Likewise.
2720         (forget_cached_source_info): Likewise.
2721         (identify_source_line): Likewise.
2722         * source.h (identify_source_line): Move declaration from symtab.h
2723         and add comment from source.c
2724         (print_source_lines): Likewise.
2725         (forget_cached_source_info_for_objfile): Likewise.
2726         (forget_cached_source_info): Likewise.
2727         (select_source_symtab): Likewise.
2728         (enum print_source_lines_flag): Move definition from symtab.h.
2729         * symtab.h (identify_source_line): Move declaration to source.h.
2730         (print_source_lines): Likewise.
2731         (forget_cached_source_info_for_objfile): Likewise.
2732         (forget_cached_source_info): Likewise.
2733         (select_source_symtab): Likewise.
2734         (enum print_source_lines_flag): Move definition to source.h.
2735         * tui/tui-hooks.c: Add 'source.h' include.
2736
2737 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2738
2739         * source.c (print_source_lines_base): Handle requests to print
2740         reverse line number sequences, and guard against empty lines
2741         string.
2742
2743 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2744
2745         * source.c (print_source_lines_base): Fix skip of '\r' if next
2746         character is '\n'.
2747
2748 2019-01-06  Tom Tromey  <tom@tromey.com>
2749
2750         * c-exp.y (struct c_parse_state) <macro_original_text,
2751         expansion_obstack>: New member.
2752         (macro_original_text, expansion_obstack): Remove globals.
2753         (scan_macro_expansion, scanning_macro_expansion)
2754         (finished_macro_expansion): Update.
2755         (scan_macro_cleanup): Remove.
2756         (yylex, c_parse): Update.
2757
2758 2019-01-06  Tom Tromey  <tom@tromey.com>
2759
2760         * c-exp.y (struct c_parse_state) <strings>: New member.
2761         (operator_stoken): Update.
2762
2763 2019-01-06  Tom Tromey  <tom@tromey.com>
2764
2765         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2766         (union type_stack_elt) <typelist_val>: Now a pointer to
2767         std::vector.
2768         (type_stack_cleanup): Don't declare.
2769         (push_typelist): Update.
2770         * parse.c (pop_typelist): Return a std::vector.
2771         (push_typelist): Take a std::vector.
2772         (follow_types): Update.  Do not free args.
2773         (type_stack_cleanup): Remove.
2774         * c-exp.y (struct c_parse_state): New.
2775         (cpstate): New global.
2776         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2777         (nonempty_typelist): Update.
2778         (func_mod): Create a new vector.
2779         (c_parse): Create a c_parse_state.
2780         (check_parameter_typelist): Do not delete params.
2781         (function_method): Update.  Do not delete type_list.
2782
2783 2019-01-06  Tom Tromey  <tom@tromey.com>
2784
2785         PR gdb/28155:
2786         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2787         check_typedef.
2788         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2789         (print_return_value): Likewise.
2790
2791 2019-01-05  Tom Tromey  <tom@tromey.com>
2792
2793         * contrib/cleanup_check.py: Remove.
2794         * contrib/gcc-with-excheck: Remove.
2795         * contrib/exsummary.py: Remove.
2796         * contrib/excheck.py: Remove.
2797
2798 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2799
2800         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2801         NULL. Initialize tpprev to NULL instead of assigning it
2802         to NULL on the next statement.
2803         * windows-nat.c (windows_delete_thread): Remove check for
2804         main_thread_id before printing thread exit notifications.
2805         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2806         Remove thread ID check against main_thread_id.
2807         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2808         windows_delete_thread.
2809         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2810
2811 2019-01-04  Tom Tromey  <tom@tromey.com>
2812
2813         * compile/compile.c (_initialize_compile): Use upper case for
2814         metasyntactic variables.
2815         * symmisc.c (_initialize_symmisc): Use upper case for
2816         metasyntactic variables.
2817         * psymtab.c (_initialize_psymtab): Use upper case for
2818         metasyntactic variables.
2819         * demangle.c (demangle_command): Use upper case for metasyntactic
2820         variables.
2821         (_initialize_demangler): Likewise.
2822         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2823         variables.
2824
2825 2019-01-03  Tom Tromey  <tom@tromey.com>
2826
2827         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2828
2829 2019-01-03  Tom Tromey  <tom@tromey.com>
2830
2831         * python/py-symtab.c (salpy_str): Update.
2832         (struct salpy_sal_object) <symtab>: Now a PyObject.
2833         (salpy_dealloc): Update.
2834         (del_objfile_sal): Use gdbpy_ref.
2835
2836 2019-01-03  Tom Tromey  <tom@tromey.com>
2837
2838         * python/py-type.c (convert_field): Use new_reference.  Return
2839         gdbpy_ref.
2840         (make_fielditem): Return gdbpy_ref.
2841         (typy_fields): Update.
2842         (typy_getitem): Update.
2843         (field_name): Return gdbpy_ref.  Use new_reference.
2844         (typy_iterator_iternext): Update.
2845
2846 2019-01-03  Tom Tromey  <tom@tromey.com>
2847
2848         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2849
2850 2019-01-03  Tom Tromey  <tom@tromey.com>
2851
2852         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2853         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2854         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2855         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2856         (pspy_set_type_printers): Likewise.
2857         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2858         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2859         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2860         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2861         (objfpy_set_type_printers): Likewise.
2862
2863 2019-01-03  Tom Tromey  <tom@tromey.com>
2864
2865         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2866         (gdbpy_print_stack): Use gdbpy_err_fetch.
2867         * python/python-internal.h (class gdbpy_err_fetch): New class.
2868         (class gdbpy_enter) <m_error_type, m_error_value,
2869         m_error_traceback>: Remove.
2870         <m_error>: New member.
2871         (gdbpy_exception_to_string): Don't declare.
2872         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2873         * python/py-value.c (convert_value_from_python): Use
2874         gdbpy_err_fetch.
2875         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2876         gdbpy_exception_to_string.
2877         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2878         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2879         gdbpy_err_fetch.
2880
2881 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2882
2883         * linux-nat.c (delete_lwp_cleanup): Delete.
2884         (struct lwp_deleter): New struct.
2885         (lwp_info_up): New typedef.
2886         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2887         lwp_info_up.
2888
2889 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2890
2891         * linux-fork.c (class scoped_switch_fork_info): New class.
2892         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2893
2894 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2895
2896         * valops.c (find_overload_match): Remove use of null_cleanup, and
2897         calls to do_cleanups.
2898
2899 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2900
2901         * compile/compile-cplus-types.c
2902         (compile_cplus_instance::decl_name): Handle changes to
2903         cp_func_name.
2904         * cp-support.c (cp_func_name): Update header comment, update
2905         return type.
2906         * cp-support.h (cp_func_name): Update return type in declaration.
2907         * valops.c (find_overload_match): Move temp_func local to top
2908         level of function and change its type.  Use temp_func to hold and
2909         delete temporary string obtained from cp_func_name.
2910
2911 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2912
2913         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2914         gdb::char_vector, remove cleanup, and update uses of `msg`.
2915
2916 2019-01-03  Jim Wilson  <jimw@sifive.com>
2917
2918         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2919
2920 2019-01-02  Tom Tromey  <tom@tromey.com>
2921
2922         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2923         (tdesc_parse_xml): Remove cleanups.
2924         * target-descriptions.h (make_cleanup_free_target_description):
2925         Don't declare.
2926         (target_desc_deleter): New struct.
2927         (target_desc_up): New typedef.
2928         * target-descriptions.c (target_desc_deleter::operator()): Rename
2929         from free_target_description.
2930         (make_cleanup_free_target_description): Remove.
2931
2932 2019-01-02  Tom Tromey  <tom@tromey.com>
2933
2934         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2935         constructor, destructor.
2936         (linespec_parser): Remove typedef.
2937         (~linespec_parser): Rename from linespec_parser_delete.
2938         (linespec_lex_to_end, linespec_complete_label)
2939         (linespec_complete): Update.
2940         (decode_line_full): Remove cleanups.
2941         (decode_line_1): Update.
2942
2943 2019-01-02  Tom Tromey  <tom@tromey.com>
2944
2945         * python/python-internal.h (inferior_to_inferior_object): Change
2946         return type.
2947         * python/py-exitedevent.c (create_exited_event_object): Update.
2948         * python/py-inferior.c (inferior_to_inferior_object): Return
2949         gdbpy_ref.
2950         (python_new_inferior, python_inferior_deleted)
2951         (thread_to_thread_object, delete_thread_object)
2952         (build_inferior_list, gdbpy_selected_inferior): Update.
2953         * python/py-infthread.c (create_thread_object): Update.  Also fail
2954         if inferior_to_inferior_object fails.
2955
2956 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2957
2958         * inferior.h (class inferior) <displaced_step_state>: New field.
2959         * infrun.h (struct displaced_step_state): Move here from
2960         infrun.c.  Initialize fields, add constructor.
2961         <inf>: Remove field.
2962         <reset>: New method.
2963         * infrun.c (struct displaced_step_inferior_state): Move to
2964         infrun.h.
2965         (displaced_step_inferior_states): Remove.
2966         (get_displaced_stepping_state): Adust.
2967         (displaced_step_in_progress_any_inferior): Adjust.
2968         (displaced_step_in_progress_thread): Adjust.
2969         (displaced_step_in_progress): Adjust.
2970         (add_displaced_stepping_state): Remove.
2971         (get_displaced_step_closure_by_addr): Adjust.
2972         (remove_displaced_stepping_state): Remove.
2973         (infrun_inferior_exit): Call displaced_step_state.reset.
2974         (use_displaced_stepping): Don't check for NULL.
2975         (displaced_step_prepare_throw): Call
2976         get_displaced_stepping_state.
2977         (displaced_step_fixup): Don't check for NULL.
2978         (prepare_for_detach): Don't check for NULL.
2979
2980 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2981
2982         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2983          in case of call that did not complete.
2984
2985 2019-01-02  Andrey Utkin  <autkin@undo.io>
2986
2987         * symfile.c (find_separate_debug_file): Fix search of debug files for
2988         remote debuggee.
2989
2990 2019-01-02  Tom Tromey  <tom@tromey.com>
2991
2992         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2993         indentation.
2994         * python/py-frame.c (frapy_older): Remove cast.
2995         (frapy_newer): Likewise.
2996         * python/py-breakpoint.c (local_setattro): Remove cast.
2997         * python/py-arch.c (archpy_name): Remove local variable.
2998         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2999
3000 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3001
3002         * unittests/basic_string_view/element_access/char/empty.cc:
3003         Fix year range in copyright header.
3004
3005 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3006
3007         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3008         Delete.
3009         <operator==>: Update with for removed field.
3010         <hash>: Likewise.
3011         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3012         <isa_features>: ...this.
3013         <abi_features>: New field.
3014         (riscv_isa_flen): Update comment.
3015         (riscv_abi_xlen): New declaration.
3016         (riscv_abi_flen): New declaration.
3017         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3018         isa_features.
3019         (riscv_abi_xlen): New function.
3020         (riscv_isa_flen): Update to get answer from isa_features.
3021         (riscv_abi_flen): New function.
3022         (riscv_has_fp_abi): Update to get answer from abi_features.
3023         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3024         xlen and flen.
3025         (riscv_call_info) <xlen, flen>: Update comment.
3026         (riscv_call_arg_struct): Remove invalid assertions
3027         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3028         is removed.
3029         (riscv_gdbarch_init): Gather isa features and abi features
3030         separately, ensure both match on the gdbarch when reusing an old
3031         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3032         a target with 64-bit float hardware.
3033
3034 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3035
3036         * source.c (search_command_helper): Stop reverse search
3037         when line 1 has been searched.
3038
3039 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3040
3041         * record-full.c (record_full_base_target::close): Rewrite
3042         record_full_core_buf_list free logic.
3043
3044 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3045
3046         * break-catch-syscall.c (print_one_catch_syscall): xfree
3047         the last text.
3048
3049 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3050
3051         * top.c (print_gdb_version): Update Copyright year in version
3052         message.
3053
3054 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3055
3056         Update copyright year range in all GDB files.
3057
3058 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
3059
3060         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
3061
3062 For older changes see ChangeLog-2018.
3063 \f
3064 Local Variables:
3065 mode: change-log
3066 left-margin: 8
3067 fill-column: 74
3068 version-control: never
3069 coding: utf-8
3070 End:
3071