765e2c95e14ff24232bd9e58ed9016c01d517f40
[external/binutils.git] / gdb / ChangeLog
1 2019-08-19  Tom Tromey  <tom@tromey.com>
2
3         PR gdb/25009
4         * configure: Rebuild.
5         * configure.ac: Disallow the combination of -static-libstdc++ and
6         source highlight.
7         * source-cache.c (get_language_name): Handle rust.
8         (source_cache::get_source_lines): Ignore highlighting exceptions.
9
10 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
11
12         PR breakpoints/24541
13         * gdbarch.c: Regenerate.
14         * gdbarch.h: Regenerate.
15         * gdbarch.sh: Add 'stap_adjust_register'.
16         * i386-tdep.c: Include '<unordered_set>'.
17         (i386_stap_adjust_register): New function.
18         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
19         * stap-probe.c (stap_parse_register_operand): Call
20         'gdbarch_stap_adjust_register'.
21
22 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
23
24         PR breakpoints/24541
25         * stap-probe.c (stap_parse_register_operand): Make "regname" an
26         "std::string", simplifying the algorithm.
27
28 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
29
30         PR gdb/25010
31         * event-top.c: Remove include comment.
32         * inflow.c (class scoped_ignore_sigttou): Move from here...
33         * inflow.h (class scoped_ignore_sigttou): ...to here.
34         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
35         * top.c:  Remove include comment.
36
37 2019-08-04  Alan Hayward  <alan.hayward@arm.com>
38
39         PR breakpoints/25011
40         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
41
42 2019-05-29  Tom Tromey  <tromey@adacore.com>
43
44         PR c++/20020:
45         * cp-valprint.c (cp_print_value_fields): Call
46         cp_print_static_field inside "try".
47
48 2019-06-10  Tom de Vries  <tdevries@suse.de>
49
50         PR symtab/24545
51         * symtab.c (struct demangled_name_entry): Add language field.
52         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
53         static minimal symbol".  Set and use language field.
54
55 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
56
57         PR gdb/24592
58         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
59         function.
60         (fill_gregset): Call amd64_linux_collect_native_gregset instead
61         of amd64_collect_native_gregset.
62         (amd64_linux_nat_target::store_registers): Likewise.
63
64 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
65
66         * version.in: Set GDB version number to 8.3.0.DATE-git.
67
68 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
69
70         GDB 8.3 released.
71
72 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
73
74         * version.in: Set GDB version number to 8.3.
75
76 2019-05-08  Tom Tromey  <tromey@adacore.com>
77
78         * utils.c (fputs_maybe_filtered): Reset style after paging, even
79         when no wrap column is set.
80
81 2019-05-04  Tom Tromey  <tom@tromey.com>
82
83         * psymtab.c (psymbol_name_matches, match_partial_symbol)
84         (lookup_partial_symbol, print_partial_symbols)
85         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
86         (psymbol_compare): Update.
87         (add_psymbol_to_bcache): Clear the entire psymbol.
88         (maintenance_check_psymtabs): Update.
89         * psympriv.h (struct partial_symbol): Don't derive from
90         general_symbol_info.
91         <obj_section, unrelocated_address, address,
92         set_unrelocated_address>: Update.
93         <ginfo>: New member.
94         * dwarf-index-write.c (write_psymbols, debug_names::insert)
95         (debug_names::write_psymbols): Update.
96
97 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
98
99         * windows-nat.c [_WIN32_WINNT]: Define _WIN32_WINNT to Windows XP
100         level, so that various Windows header files expose the necessary
101         declarations and definitions.
102
103         * symfile.c (find_separate_debug_file): Remove colon from the
104         drive spec of DOS/Windows file names of the target, so that the
105         file name produced from DEBUGDIR and the target's directory will
106         be valid on DOS/Windows systems.
107
108 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
109
110         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
111         Use current_event.dwThreadId instead of main_thread_id.
112
113 2019-04-30  Tom Tromey  <tromey@adacore.com>
114
115         PR c++/24470:
116         * dwarf2read.c (process_structure_scope): Handle case where type
117         has template parameters but no symbol was created.
118
119 2019-04-19  Sergei Trofimovich <siarheit@google.com>
120
121         * configure.ac: add --enable-source-highlight switch.
122         * configure: Regenerate.
123         * top.c (print_gdb_version): plumb --enable-source-highlight
124         status to "show configuration".
125
126 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
127
128         PR symtab/24423:
129         * source.c (print_source_lines_base): Advance "iter" when a
130         control character is seen.
131
132 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
133
134         * inferior.h (struct infcall_suspend_state_deleter):
135         Catch exception in destructor to avoid crash.
136
137 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
138
139         * utils.c (prompt_for_continue): Don't restore the styling at the
140         end, as applied_style has the wrong value.  This fixes styling in
141         long lists of file names that are interrupted by the "Continue?"
142         prompt.
143
144 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
145
146         * version.in: Set GDB version number to 8.2.91.DATE-git.
147
148 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
149
150         GDB 8.2.91 released.
151
152 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
153
154         * version.in: Set GDB version number to 8.2.91.
155
156 2019-03-20  Tom Tromey  <tromey@adacore.com>
157
158         PR gdb/24391
159         * infrun.c (handle_inferior_event): Rename from
160         handle_inferior_event_1.  Create a scoped_value_mark.
161         (handle_inferior_event): Remove.
162
163 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
164
165         * source-cache.c (source_cache::get_source_lines): Re-read
166         fullname after calling open_source_file.
167
168 2019-03-18  Pedro Alves  <palves@redhat.com>
169             Eli Zaretskii <eliz@gnu.org>
170
171         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
172         m_line and m_start_of_line.
173
174 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
175
176         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
177         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
178         it returns a newline.  This fixes a regression in TU mode, whereby
179         the next line is output on the same screen line as the user input.
180
181 2019-03-18  Pedro Alves  <palves@redhat.com>
182
183         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
184         New globals.
185         (apply_style): New, factored out from ...
186         (apply_ansi_escape): ... this.  Handle reverse video mode.
187         (tui_set_reverse_mode): New function.
188         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
189         * tui/tui-winsource.c (tui_show_source_line): Use
190         tui_set_reverse_mode instead of setting A_STANDOUT.
191         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
192         New setter methods.
193
194 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
195
196         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
197         Handle tabs.
198
199 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
200
201         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
202         tui_refill_source_window instead of tui_refresh_win, to update the
203         current execution line.  This fixes redisplay of the current line
204         when stepping through the code with "next" or "step".
205
206 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
207
208         * source-cache.c (source_cache::get_source_lines): Call
209         find_source_lines to initialize s->nlines.  This fixes vertical
210         scrolling of TUI source window when the DOWN arrow is pressed.
211
212 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
213
214         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
215         wclrtoeol in tui_show_source_line".  This reverts changes made in
216         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
217
218 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
219
220         * NEWS: Combine separate "New targets" sections for 8.3.
221
222 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
223
224         The MS-Windows port of ncurses fails to switch to a color pair if
225         one or both of the colors are the implicit default colors.  This
226         change records the default colors when TUI is initialized, and
227         then specifies them explicitly when a color pair uses the default
228         colors.  This allows color styling in TUI mode on MS-Windows.
229
230         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
231         ncurses_norm_attr.
232         (tui_initialize_io) [__MINGW32__]: Record the default terminal
233         colors in ncurses_norm_attr.
234         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
235         "none", replace it with the default color recorded in
236         ncurses_norm_attr.
237
238 2019-03-14  Tom Tromey  <tromey@adacore.com>
239
240         * source-cache.h (class source_cache) <get_source_lines>: Return
241         std::string.
242         * source-cache.c (source_cache::extract_lines): Handle case where
243         first_pos==npos.  Return std::string.
244         (source_cache::get_source_lines): Update.
245
246 2019-03-14  Tom Tromey  <tromey@adacore.com>
247
248         * NEWS: Add item for "style sources" commands.
249         * source-cache.c (source_cache::get_source_lines): Check
250         source_styling.
251         * cli/cli-style.c (source_styling): New global.
252         (_initialize_cli_style): Add "style sources" commands.
253         (show_style_sources): New function.
254         * cli/cli-style.h (source_styling): Declare.
255
256 2019-03-14  Pedro Alves  <palves@redhat.com>
257             Tom Tromey  <tromey@adacore.com>
258
259         * tui/tui-winsource.h (tui_refill_source_window): Declare.
260         * tui/tui-winsource.c (tui_refill_source_window): New function,
261         from...
262         (tui_horizontal_source_scroll): ... here.  Move some logic.
263         * cli/cli-style.c (set_style_enabled): Notify new observable.
264         * tui/tui-hooks.c (tui_redisplay_source): New function.
265         (tui_attach_detach_observers): Attach or detach
266         tui_redisplay_source.
267         * observable.h (source_styling_changed): New observable.
268         * observable.c: Define source_styling_changed observable.
269
270 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
271
272         PR/24325
273         * source-cache.c: #undef open and close, to avoid unresolved
274         externals during linking.
275
276 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
277
278         Support styling on native MS-Windows console
279
280         PR/24315
281         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
282         on MS-Windows if $TERM is not defined.
283
284         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
285
286         * posix-hdep.c (gdb_console_fputs):
287         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
288         functions.
289         * ui-file.h (gdb_console_fputs): Add prototype.
290
291         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
292         back to fputs only if the former returns zero.
293
294 2019-03-07  Brian Vandenberg  <phantall@gmail.com>
295             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
296
297         PR gdb/8527
298         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
299         set_sigint_trap, clear_sigint_trap.
300
301 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
302
303         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
304         for-loop range, to avoid compiler warnings.
305
306         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
307         avoid compiler warnings about unused variables.
308
309 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
310
311         * NEWS: Mention end of support for native debugging on MS-Windows
312         before XP.
313
314 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
315
316         PR gdb/24292
317         * common/netstuff.c:
318         * gdbserver/gdbreplay.c
319         * gdbserver/remote-utils.c:
320         * ser-tcp.c:
321         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
322         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
323         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
324         'getaddrinfo' and 'freeaddrinfo' were not available before
325         Windows XP, and mingw.org's MinGW headers by default define
326         _WIN32_WINNT to 0x500.
327
328 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
329     
330         * NEWS: Note minimum Python version.
331
332 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
333
334         * version.in: Set GDB version number to 8.2.90.DATE-git.
335
336 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
337
338         GDB 8.2.90 released.
339
340 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
341
342         * version.in: Set GDB version number to 8.2.90.
343
344 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
345
346         * NEWS: Change "Changes since GDB 8.2" into "Changes in GDB 8.3".
347
348 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
349
350         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
351         * version.in: Bump version to 8.2.90.DATE-git.
352
353 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
354
355         * aix-thread.c (ptid_cmp): Remove unused variable.
356         (get_signaled_thread): Likewise.
357         (store_regs_user_thread): Likewise.
358         (store_regs_kernel_thread): Likewise.
359         (fetch_regs_kernel_thread): Remove shadowed variable.
360
361 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
362
363         * features/riscv/32bit-cpu.xml: Add register numbers.
364         * features/riscv/32bit-fpu.c: Regenerate.
365         * features/riscv/32bit-fpu.xml: Add register numbers.
366         * features/riscv/64bit-cpu.xml: Add register numbers.
367         * features/riscv/64bit-fpu.c: Regenerate.
368         * features/riscv/64bit-fpu.xml: Add register numbers.
369
370 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
371
372         * NEWS: Mention two argument form of gdb.Value constructor.
373         * python/py-value.c (convert_buffer_and_type_to_value): New
374         function.
375         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
376         Add support for handling an optional second argument.  Call
377         convert_buffer_and_type_to_value as appropriate.
378         * python/python-internal.h (Py_buffer_deleter): New struct.
379         (Py_buffer_up): New typedef.
380
381 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
382
383         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
384         instead of releasing ownership.
385
386 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
387
388         * dwarf2read.c (open_and_init_dwp_file): Call
389         elf_numsections instead of bfd_count_sections to initialize
390         dwp_file->num_sections.
391
392 2019-02-25  Tom Tromey  <tromey@adacore.com>
393
394         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
395
396 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
397
398         * gcore.in: Add '--readnever' option when invoking GDB.
399
400 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
401
402         * MAINTAINERS: Update my email address.
403
404 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
405
406         * build-id.c (build_id_to_debug_bfd_1): New function.
407         (build_id_to_debug_bfd): Look for separate debug file in
408         sysroot.
409
410 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
411
412         * gdbarch.sh: Update the copyright year range that is placed into
413         generated files.
414
415 2019-02-22  Keith Seitz  <keiths@redhat.com>
416
417         PR symtab/23853
418         * linespec.c (create_sals_line_offset): Search for the default
419         symtab's filename instead of its fullname.
420
421 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
422
423         * NEWS: Update style defaults.
424
425 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
426
427         * main.c (captured_main_1): Disable styling in batch mode.
428
429 2019-02-20  Tom Tromey  <tom@tromey.com>
430
431         * symtab.c (symtab_symbol_info): Fix typos.
432
433 2019-02-20  Tom Tromey  <tromey@adacore.com>
434
435         * findcmd.c (_initialize_mem_search): Use upper case for
436         metasyntactic variables.
437
438 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
439
440         * aarch64-tdep.c (aarch64_add_reggroups): New function.
441         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
442
443 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
444
445         * top.h (source_file_name): Change to std::string.
446         * top.c (source_file_name): Likewise.
447         (command_line_input): Adjust.
448         * cli/cli-script.c (script_from_file): Adjust.
449
450 2019-02-19  Tom Tromey  <tromey@adacore.com>
451
452         * ravenscar-thread.c
453         (ravenscar_thread_target::update_thread_list): Don't call
454         ada_build_task_list.
455         * ada-lang.h (ada_build_task_list): Don't declare.
456         * ada-tasks.c (struct ada_tasks_inferior_data)
457         <task_list_valid_p>: Now bool.
458         (read_known_tasks, ada_task_list_changed)
459         (ada_tasks_invalidate_inferior_data): Update.
460         (read_known_tasks_array): Return bool.
461         (read_known_tasks_list): Likewise.
462         (read_known_tasks): Return void.
463         (ada_build_task_list): Now static.
464
465 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
466
467         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
468         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
469
470 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
471
472         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
473         variant for ada_tasks_pspace_data_handle and
474         ada_tasks_inferior_data_handle.
475         (ada_tasks_pspace_data_cleanup): New function.
476         (ada_tasks_inferior_data_cleanup): New function.
477
478 2019-02-17  Tom Tromey  <tom@tromey.com>
479
480         * macrotab.h (macro_source_fullname): Return a std::string.
481         * macrotab.c (macro_include, check_for_redefinition)
482         (macro_undef, macro_lookup_definition, foreach_macro)
483         (foreach_macro_in_scope): Update.
484         (macro_source_fullname): Return a std::string.
485         * macrocmd.c (show_pp_source_pos): Update.
486
487 2019-02-17  Tom Tromey  <tom@tromey.com>
488
489         * macrocmd.c (show_pp_source_pos): Style the file names.
490
491 2019-02-17  Tom Tromey  <tom@tromey.com>
492
493         PR tui/24197:
494         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
495
496 2019-02-17  Tom Tromey  <tom@tromey.com>
497
498         * ada-lang.c (user_select_syms): Use filtered printing.
499         * utils.c (wrap_style): New global.
500         (desired_style): Remove.
501         (emit_style_escape): Add stream parameter.
502         (set_output_style, reset_terminal_style, prompt_for_continue):
503         Update.
504         (flush_wrap_buffer): Only flush gdb_stdout.
505         (wrap_here): Set wrap_style.
506         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
507         treat escape sequences as a character.  Change when wrap buffer is
508         flushed.
509         (fputs_styled): Do not set the output style when the default is
510         requested.
511         * ui-style.h (struct ui_file_style) <is_default>: New method.
512         * source.c (print_source_lines_base): Emit escape sequences in one
513         piece.
514
515 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
516
517         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
518         integers and enumeration types.
519
520 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
521
522         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
523         instead of lookup_symbol_in_language
524         (do_exact_match): New function.
525         (ada_get_symbol_name_matcher): Return do_exact_match when
526         doing a verbatim match.
527
528 2019-02-15  Tom Tromey  <tromey@adacore.com>
529
530         * ravenscar-thread.c (ravenscar_thread_target::resume)
531         (ravenscar_thread_target::wait): Special case wildcard requests.
532
533 2019-02-15  Tom Tromey  <tromey@adacore.com>
534
535         * ravenscar-thread.c (base_ptid): Remove.
536         (struct ravenscar_thread_target) <close>: New method.
537         <m_base_ptid>: New member.
538         <update_inferior_ptid, active_task, task_is_currently_active,
539         runtime_initialized>: Declare methods.
540         <ravenscar_thread_target>: Add constructor.
541         (ravenscar_thread_target::task_is_currently_active)
542         (ravenscar_thread_target::update_inferior_ptid)
543         (ravenscar_runtime_initialized): Rename.  Now methods.
544         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
545         (ravenscar_thread_target::update_thread_list): Update.
546         (ravenscar_thread_target::active_task): Now method.
547         (ravenscar_thread_target::store_registers)
548         (ravenscar_thread_target::prepare_to_store)
549         (ravenscar_thread_target::prepare_to_store)
550         (ravenscar_thread_target::mourn_inferior): Update.
551         (ravenscar_inferior_created): Use "new" to create target.
552         (ravenscar_thread_target::get_ada_task_ptid): Update.
553         (_initialize_ravenscar): Don't initialize base_ptid.
554         (ravenscar_ops): Remove global.
555
556 2019-02-15  Tom Tromey  <tromey@adacore.com>
557
558         * target.h (push_target): Declare new overload.
559         * target.c (push_target): New overload, taking an rvalue reference.
560         * remote.c (remote_target::open_1): Use push_target overload.
561         * corelow.c (core_target_open): Use push_target overload.
562
563 2019-02-15  Tom Tromey  <tromey@adacore.com>
564
565         * ravenscar-thread.c (is_ravenscar_task)
566         (ravenscar_task_is_currently_active): Return bool.
567         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
568         (_initialize_ravenscar): Remove "(void)".
569         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
570         Return bool.
571
572 2019-02-15  Tom Tromey  <tromey@adacore.com>
573
574         * ravenscar-thread.c (ravenscar_runtime_initializer)
575         (has_ravenscar_runtime, get_running_thread_id)
576         (ravenscar_thread_target::resume): Fix indentation.
577
578 2019-02-15  Tom Tromey  <tromey@adacore.com>
579
580         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
581         from ravenscar_arch_ops.
582         (sparc_ravenscar_ops::fetch_registers)
583         (sparc_ravenscar_ops::store_registers): Now methods.
584         (sparc_ravenscar_prepare_to_store): Remove.
585         (sparc_ravenscar_ops): Redefine.
586         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
587         methods and destructor.  Remove members.
588         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
589         (ravenscar_thread_target::store_registers)
590         (ravenscar_thread_target::prepare_to_store): Update.
591         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
592         Remove.
593         (struct ppc_ravenscar_powerpc_ops): Derive from
594         ravenscar_arch_ops.
595         (ppc_ravenscar_powerpc_ops::fetch_registers)
596         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
597         (ppc_ravenscar_powerpc_ops): Redefine.
598         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
599         (ppc_ravenscar_e500_ops::fetch_registers)
600         (ppc_ravenscar_e500_ops::store_registers): Now methods.
601         (ppc_ravenscar_e500_ops): Redefine.
602         * aarch64-ravenscar-thread.c
603         (aarch64_ravenscar_generic_prepare_to_store): Remove.
604         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
605         (aarch64_ravenscar_fetch_registers)
606         (aarch64_ravenscar_store_registers): Now methods.
607         (aarch64_ravenscar_ops): Redefine.
608
609 2019-02-15  Tom Tromey  <tromey@adacore.com>
610
611         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
612         (ravenscar_thread_target::stopped_by_hw_breakpoint)
613         (ravenscar_thread_target::stopped_by_watchpoint)
614         (ravenscar_thread_target::stopped_data_address)
615         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
616
617 2019-02-15  Tom Tromey  <tromey@adacore.com>
618
619         * ravenscar-thread.c: Fix some typos.
620
621 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
622             Tom Tromey  <tromey@adacore.com>
623
624         * ada-lang.c (ada_exception_sal): Change addr_string to a
625         std::string.
626         (create_ada_exception_catchpoint): Update.
627
628 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
629             Tom Tromey  <tromey@adacore.com>
630
631         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
632         (bp_location_ops): Remove.
633         (base_breakpoint_allocate_location): Update.
634         (free_bp_location): Update.
635         * ada-lang.c (class ada_catchpoint_location)
636         <ada_catchpoint_location>: Remove ops parameter.
637         (ada_catchpoint_location_dtor): Remove.
638         (ada_catchpoint_location_ops): Remove.
639         (allocate_location_exception): Update.
640         * breakpoint.h (struct bp_location_ops): Remove.
641         (class bp_location) <bp_location>: Remove bp_location_ops
642         parameter.
643         <~bp_location>: Add destructor.
644         <ops>: Remove.
645
646 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
647             Pedro Alves  <palves@redhat.com>
648
649         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
650         'PATH_MAX'.
651
652 2019-02-14  David Michael  <fedora.dm0@gmail.com>
653             Samuel Thibault  <samuel.thibault@gnu.org>
654             Thomas Schwinge  <thomas@codesourcery.com>
655
656         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
657         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
658
659 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
660
661         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
662         (check_empty): Use "const char *".
663
664         * gnu-nat.c (gnu_nat_target::detach): Instead of
665         'detach_inferior (pid)' call
666         'detach_inferior (find_inferior_pid (pid))'.
667
668         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
669         'nat/fork-inferior.o'.
670         * gnu-nat.c: #include "nat/fork-inferior.h".
671
672         * gnu-nat.c (gnu_nat_target::detach): Instead of
673         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
674         * gnu-nat.h: #include "inf-child.h".
675         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
676         'i386_gnu_nat_target::fetch_registers'.
677         (gnu_store_registers): Rename/move to
678         'i386_gnu_nat_target::store_registers'.
679
680         * config/i386/nm-i386gnu.h: Don't "#include" any files.
681         * gnu-nat.h (mach_thread_info): New function.
682         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
683
684         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
685
686 2019-02-14  Frederic Konrad  <konrad@adacore.com>
687
688         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
689
690 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
691
692         * windows-nat.c (windows_add_thread): Add new parameter
693         "main_thread_p" with default value set to false.  Update
694         function documentation as well as all callers.
695         (windows_delete_thread): Likewise.
696         (fake_create_process): Update call to windows_add_thread.
697         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
698         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
699         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
700         call to windows_delete_thread.
701
702 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
703
704         * MAINTAINERS: Add Andrew Burgess as global maintainer.
705
706 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
707
708         * symfile.c (find_separate_debug_file): Use canonical path of
709         sysroot with child_path instead of gdb_sysroot if it is valid.
710
711 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
712
713         * symfile.c (find_separate_debug_file): Use child_path to
714         determine if an object file is under a sysroot.
715
716 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
717
718         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
719         unittests/child-path-selftests.c.
720         * common/pathstuff.c (child_path): New function.
721         * common/pathstuff.h (child_path): New prototype.
722         * unittests/child-path-selftests.c: New file.
723
724 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
725
726         * symfile.c (find_separate_debug_file): Look for separate debug
727         files in debug directories under the sysroot.
728
729 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
730
731         * symtab.h (struct minimal_symbol data_p): New const method.
732         (struct minimal_symbol text_p): Likewise.
733         * symtab.c (output_source_filename): Use file name style
734         to print file name.
735         (print_symbol_info): Likewise.
736         (print_msymbol_info): Use address style to print addresses.
737         Use function name style to print executable text symbols.
738         (expand_symtab_containing_pc): Use data_p.
739         (find_pc_sect_compunit_symtab): Likewise.
740
741 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
742
743         * breakpoint.c (describe_other_breakpoints): Use address style
744         to print addresses.
745         (say_where): Likewise.
746
747 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
748
749         * ada-typeprint.c (print_func_type): Print function name
750         style to print function name.
751         * c-typeprint.c (c_print_type_1): Likewise.
752
753 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
754
755         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
756         for execve.
757
758 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
759
760         * c-exp.y (direct_abs_decl): Use emplace_back to record the
761         type_stack.
762
763 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
764
765         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
766         TYPE_CODE_REF types.
767
768 2019-02-08  Jim Wilson  <jimw@sifive.com>
769
770         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
771         (riscv_linux_fregset): New.
772         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
773
774 2019-02-07  Tom Tromey  <tom@tromey.com>
775
776         * thread.c (thread_cancel_execution_command): Update.
777         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
778         methods.
779         (struct thread_fsm_ops): Remove.
780         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
781         (thread_fsm_should_stop, thread_fsm_return_value)
782         (thread_fsm_set_finished, thread_fsm_finished_p)
783         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
784         Don't declare.
785         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
786         * infrun.c (clear_proceed_status_thread)
787         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
788         (print_stop_event): Update.
789         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
790         Add constructor.
791         (step_command_fsm_ops): Remove.
792         (new_step_command_fsm): Remove.
793         (step_1): Update.
794         (step_command_fsm::should_stop): Rename from
795         step_command_fsm_should_stop.
796         (step_command_fsm::clean_up): Rename from
797         step_command_fsm_clean_up.
798         (step_command_fsm::do_async_reply_reason): Rename from
799         step_command_fsm_async_reply_reason.
800         (struct until_next_fsm): Inherit from thread_fsm.  Add
801         constructor.
802         (until_next_fsm_ops): Remove.
803         (new_until_next_fsm): Remove.
804         (until_next_fsm::should_stop): Rename from
805         until_next_fsm_should_stop.
806         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
807         (until_next_fsm::do_async_reply_reason): Rename from
808         until_next_fsm_async_reply_reason.
809         (struct finish_command_fsm): Inherit from thread_fsm.  Add
810         constructor.  Change type of breakpoint.
811         (finish_command_fsm_ops): Remove.
812         (new_finish_command_fsm): Remove.
813         (finish_command_fsm::should_stop): Rename from
814         finish_command_fsm_should_stop.
815         (finish_command_fsm::clean_up): Rename from
816         finish_command_fsm_clean_up.
817         (finish_command_fsm::return_value): Rename from
818         finish_command_fsm_return_value.
819         (finish_command_fsm::do_async_reply_reason): Rename from
820         finish_command_fsm_async_reply_reason.
821         (finish_command): Update.
822         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
823         Add constructor.
824         (call_thread_fsm_ops): Remove.
825         (call_thread_fsm::call_thread_fsm): Rename from
826         new_call_thread_fsm.
827         (call_thread_fsm::should_stop): Rename from
828         call_thread_fsm_should_stop.
829         (call_thread_fsm::should_notify_stop): Rename from
830         call_thread_fsm_should_notify_stop.
831         (run_inferior_call, call_function_by_hand_dummy): Update.
832         * cli/cli-interp.c (should_print_stop_to_console): Update.
833         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
834         Add constructor.  Change type of location_breakpoint,
835         caller_breakpoint.
836         (until_break_fsm_ops): Remove.
837         (new_until_break_fsm): Remove.
838         (until_break_fsm::should_stop): Rename from
839         until_break_fsm_should_stop.
840         (until_break_fsm::clean_up): Rename from
841         until_break_fsm_clean_up.
842         (until_break_fsm::do_async_reply_reason): Rename from
843         until_break_fsm_async_reply_reason.
844         (until_break_command): Update.
845         * thread-fsm.c: Remove.
846         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
847
848 2019-02-07  Tom Tromey  <tom@tromey.com>
849
850         * yy-remap.h: Add include guard.
851         * xtensa-tdep.h: Add include guard.
852         * xcoffread.h: Rename include guard.
853         * varobj-iter.h: Add include guard.
854         * tui/tui.h: Rename include guard.
855         * tui/tui-winsource.h: Rename include guard.
856         * tui/tui-wingeneral.h: Rename include guard.
857         * tui/tui-windata.h: Rename include guard.
858         * tui/tui-win.h: Rename include guard.
859         * tui/tui-stack.h: Rename include guard.
860         * tui/tui-source.h: Rename include guard.
861         * tui/tui-regs.h: Rename include guard.
862         * tui/tui-out.h: Rename include guard.
863         * tui/tui-layout.h: Rename include guard.
864         * tui/tui-io.h: Rename include guard.
865         * tui/tui-hooks.h: Rename include guard.
866         * tui/tui-file.h: Rename include guard.
867         * tui/tui-disasm.h: Rename include guard.
868         * tui/tui-data.h: Rename include guard.
869         * tui/tui-command.h: Rename include guard.
870         * tic6x-tdep.h: Add include guard.
871         * target/waitstatus.h: Rename include guard.
872         * target/wait.h: Rename include guard.
873         * target/target.h: Rename include guard.
874         * target/resume.h: Rename include guard.
875         * target-float.h: Rename include guard.
876         * stabsread.h: Add include guard.
877         * rs6000-tdep.h: Add include guard.
878         * riscv-fbsd-tdep.h: Add include guard.
879         * regformats/regdef.h: Rename include guard.
880         * record.h: Rename include guard.
881         * python/python.h: Rename include guard.
882         * python/python-internal.h: Rename include guard.
883         * python/py-stopevent.h: Rename include guard.
884         * python/py-ref.h: Rename include guard.
885         * python/py-record.h: Rename include guard.
886         * python/py-record-full.h: Rename include guard.
887         * python/py-record-btrace.h: Rename include guard.
888         * python/py-instruction.h: Rename include guard.
889         * python/py-events.h: Rename include guard.
890         * python/py-event.h: Rename include guard.
891         * procfs.h: Add include guard.
892         * proc-utils.h: Add include guard.
893         * p-lang.h: Add include guard.
894         * or1k-tdep.h: Rename include guard.
895         * observable.h: Rename include guard.
896         * nto-tdep.h: Rename include guard.
897         * nat/x86-linux.h: Rename include guard.
898         * nat/x86-linux-dregs.h: Rename include guard.
899         * nat/x86-gcc-cpuid.h: Add include guard.
900         * nat/x86-dregs.h: Rename include guard.
901         * nat/x86-cpuid.h: Rename include guard.
902         * nat/ppc-linux.h: Rename include guard.
903         * nat/mips-linux-watch.h: Rename include guard.
904         * nat/linux-waitpid.h: Rename include guard.
905         * nat/linux-ptrace.h: Rename include guard.
906         * nat/linux-procfs.h: Rename include guard.
907         * nat/linux-osdata.h: Rename include guard.
908         * nat/linux-nat.h: Rename include guard.
909         * nat/linux-namespaces.h: Rename include guard.
910         * nat/linux-btrace.h: Rename include guard.
911         * nat/glibc_thread_db.h: Rename include guard.
912         * nat/gdb_thread_db.h: Rename include guard.
913         * nat/gdb_ptrace.h: Rename include guard.
914         * nat/fork-inferior.h: Rename include guard.
915         * nat/amd64-linux-siginfo.h: Rename include guard.
916         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
917         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
918         * nat/aarch64-linux.h: Rename include guard.
919         * nat/aarch64-linux-hw-point.h: Rename include guard.
920         * mn10300-tdep.h: Add include guard.
921         * mips-linux-tdep.h: Add include guard.
922         * mi/mi-parse.h: Rename include guard.
923         * mi/mi-out.h: Rename include guard.
924         * mi/mi-main.h: Rename include guard.
925         * mi/mi-interp.h: Rename include guard.
926         * mi/mi-getopt.h: Rename include guard.
927         * mi/mi-console.h: Rename include guard.
928         * mi/mi-common.h: Rename include guard.
929         * mi/mi-cmds.h: Rename include guard.
930         * mi/mi-cmd-break.h: Rename include guard.
931         * m2-lang.h: Add include guard.
932         * location.h: Rename include guard.
933         * linux-record.h: Rename include guard.
934         * linux-nat.h: Add include guard.
935         * linux-fork.h: Add include guard.
936         * i386-darwin-tdep.h: Rename include guard.
937         * hppa-linux-offsets.h: Add include guard.
938         * guile/guile.h: Rename include guard.
939         * guile/guile-internal.h: Rename include guard.
940         * gnu-nat.h: Rename include guard.
941         * gdb-stabs.h: Rename include guard.
942         * frv-tdep.h: Add include guard.
943         * f-lang.h: Add include guard.
944         * event-loop.h: Add include guard.
945         * darwin-nat.h: Rename include guard.
946         * cp-abi.h: Rename include guard.
947         * config/sparc/nm-sol2.h: Rename include guard.
948         * config/nm-nto.h: Rename include guard.
949         * config/nm-linux.h: Add include guard.
950         * config/i386/nm-i386gnu.h: Rename include guard.
951         * config/djgpp/nl_types.h: Rename include guard.
952         * config/djgpp/langinfo.h: Rename include guard.
953         * compile/gcc-cp-plugin.h: Add include guard.
954         * compile/gcc-c-plugin.h: Add include guard.
955         * compile/compile.h: Rename include guard.
956         * compile/compile-object-run.h: Rename include guard.
957         * compile/compile-object-load.h: Rename include guard.
958         * compile/compile-internal.h: Rename include guard.
959         * compile/compile-cplus.h: Rename include guard.
960         * compile/compile-c.h: Rename include guard.
961         * common/xml-utils.h: Rename include guard.
962         * common/x86-xstate.h: Rename include guard.
963         * common/version.h: Rename include guard.
964         * common/vec.h: Rename include guard.
965         * common/tdesc.h: Rename include guard.
966         * common/selftest.h: Rename include guard.
967         * common/scoped_restore.h: Rename include guard.
968         * common/scoped_mmap.h: Rename include guard.
969         * common/scoped_fd.h: Rename include guard.
970         * common/safe-iterator.h: Rename include guard.
971         * common/run-time-clock.h: Rename include guard.
972         * common/refcounted-object.h: Rename include guard.
973         * common/queue.h: Rename include guard.
974         * common/ptid.h: Rename include guard.
975         * common/print-utils.h: Rename include guard.
976         * common/preprocessor.h: Rename include guard.
977         * common/pathstuff.h: Rename include guard.
978         * common/observable.h: Rename include guard.
979         * common/netstuff.h: Rename include guard.
980         * common/job-control.h: Rename include guard.
981         * common/host-defs.h: Rename include guard.
982         * common/gdb_wait.h: Rename include guard.
983         * common/gdb_vecs.h: Rename include guard.
984         * common/gdb_unlinker.h: Rename include guard.
985         * common/gdb_unique_ptr.h: Rename include guard.
986         * common/gdb_tilde_expand.h: Rename include guard.
987         * common/gdb_sys_time.h: Rename include guard.
988         * common/gdb_string_view.h: Rename include guard.
989         * common/gdb_splay_tree.h: Rename include guard.
990         * common/gdb_setjmp.h: Rename include guard.
991         * common/gdb_ref_ptr.h: Rename include guard.
992         * common/gdb_optional.h: Rename include guard.
993         * common/gdb_locale.h: Rename include guard.
994         * common/gdb_assert.h: Rename include guard.
995         * common/filtered-iterator.h: Rename include guard.
996         * common/filestuff.h: Rename include guard.
997         * common/fileio.h: Rename include guard.
998         * common/environ.h: Rename include guard.
999         * common/common-utils.h: Rename include guard.
1000         * common/common-types.h: Rename include guard.
1001         * common/common-regcache.h: Rename include guard.
1002         * common/common-inferior.h: Rename include guard.
1003         * common/common-gdbthread.h: Rename include guard.
1004         * common/common-exceptions.h: Rename include guard.
1005         * common/common-defs.h: Rename include guard.
1006         * common/common-debug.h: Rename include guard.
1007         * common/cleanups.h: Rename include guard.
1008         * common/buffer.h: Rename include guard.
1009         * common/btrace-common.h: Rename include guard.
1010         * common/break-common.h: Rename include guard.
1011         * cli/cli-utils.h: Rename include guard.
1012         * cli/cli-style.h: Rename include guard.
1013         * cli/cli-setshow.h: Rename include guard.
1014         * cli/cli-script.h: Rename include guard.
1015         * cli/cli-interp.h: Rename include guard.
1016         * cli/cli-decode.h: Rename include guard.
1017         * cli/cli-cmds.h: Rename include guard.
1018         * charset-list.h: Add include guard.
1019         * buildsym-legacy.h: Rename include guard.
1020         * bfin-tdep.h: Add include guard.
1021         * ax.h: Rename include guard.
1022         * arm-linux-tdep.h: Add include guard.
1023         * arm-fbsd-tdep.h: Add include guard.
1024         * arch/xtensa.h: Rename include guard.
1025         * arch/tic6x.h: Add include guard.
1026         * arch/i386.h: Add include guard.
1027         * arch/arm.h: Rename include guard.
1028         * arch/arm-linux.h: Rename include guard.
1029         * arch/arm-get-next-pcs.h: Rename include guard.
1030         * arch/amd64.h: Add include guard.
1031         * arch/aarch64-insn.h: Rename include guard.
1032         * arch-utils.h: Rename include guard.
1033         * annotate.h: Add include guard.
1034         * amd64-darwin-tdep.h: Rename include guard.
1035         * aarch64-linux-tdep.h: Add include guard.
1036         * aarch64-fbsd-tdep.h: Add include guard.
1037         * aarch32-linux-nat.h: Add include guard.
1038
1039 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1040
1041         * macrotab.c (macro_define_internal): New function that
1042         factorizes macro_define_object_internal and macro_define_function
1043         code.
1044         (macro_define_object_internal): Use macro_define_internal.
1045         (macro_define_function): Likewise.
1046
1047 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1048
1049         * macrocmd.c (extract_identifier): Return
1050         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
1051         callers.
1052
1053 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1054
1055         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1056
1057 2019-02-05  Tom Tromey  <tom@tromey.com>
1058
1059         * target.c (target_stack::unpush): Move assertion earlier.
1060
1061 2019-01-30  Tom Tromey  <tom@tromey.com>
1062
1063         PR python/23615:
1064         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1065         (gdbpy_parse_and_eval): Likewise.
1066         * python/python-internal.h (gdbpy_allow_threads): New class.
1067
1068 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1069
1070         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1071         (aarch64_fbsd_fpregmap): Move earlier.
1072         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1073         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1074         instead of individual calls to trad_frame_set_reg_addr.
1075         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1076         earlier.
1077         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1078         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1079         instead of individual calls to trad_frame_set_reg_addr.
1080
1081 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1082
1083         * CONTRIBUTE: Replace contribution list with wiki link.
1084
1085 2019-01-25  Tom Tromey  <tom@tromey.com>
1086
1087         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1088
1089 2019-01-25  Tom Tromey  <tom@tromey.com>
1090
1091         * xtensa-linux-nat.c: Fix common/ includes.
1092         * xml-support.h: Fix common/ includes.
1093         * xml-support.c: Fix common/ includes.
1094         * x86-linux-nat.c: Fix common/ includes.
1095         * windows-nat.c: Fix common/ includes.
1096         * varobj.h: Fix common/ includes.
1097         * varobj.c: Fix common/ includes.
1098         * value.c: Fix common/ includes.
1099         * valops.c: Fix common/ includes.
1100         * utils.c: Fix common/ includes.
1101         * unittests/xml-utils-selftests.c: Fix common/ includes.
1102         * unittests/utils-selftests.c: Fix common/ includes.
1103         * unittests/unpack-selftests.c: Fix common/ includes.
1104         * unittests/tracepoint-selftests.c: Fix common/ includes.
1105         * unittests/style-selftests.c: Fix common/ includes.
1106         * unittests/string_view-selftests.c: Fix common/ includes.
1107         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1108         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1109         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1110         * unittests/rsp-low-selftests.c: Fix common/ includes.
1111         * unittests/parse-connection-spec-selftests.c: Fix common/
1112         includes.
1113         * unittests/optional-selftests.c: Fix common/ includes.
1114         * unittests/offset-type-selftests.c: Fix common/ includes.
1115         * unittests/observable-selftests.c: Fix common/ includes.
1116         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1117         * unittests/memrange-selftests.c: Fix common/ includes.
1118         * unittests/memory-map-selftests.c: Fix common/ includes.
1119         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1120         * unittests/function-view-selftests.c: Fix common/ includes.
1121         * unittests/environ-selftests.c: Fix common/ includes.
1122         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1123         * unittests/common-utils-selftests.c: Fix common/ includes.
1124         * unittests/cli-utils-selftests.c: Fix common/ includes.
1125         * unittests/array-view-selftests.c: Fix common/ includes.
1126         * ui-file.c: Fix common/ includes.
1127         * tui/tui-io.c: Fix common/ includes.
1128         * tracepoint.h: Fix common/ includes.
1129         * tracepoint.c: Fix common/ includes.
1130         * tracefile-tfile.c: Fix common/ includes.
1131         * top.h: Fix common/ includes.
1132         * top.c: Fix common/ includes.
1133         * thread.c: Fix common/ includes.
1134         * target/waitstatus.h: Fix common/ includes.
1135         * target/waitstatus.c: Fix common/ includes.
1136         * target.h: Fix common/ includes.
1137         * target.c: Fix common/ includes.
1138         * target-memory.c: Fix common/ includes.
1139         * target-descriptions.c: Fix common/ includes.
1140         * symtab.h: Fix common/ includes.
1141         * symfile.c: Fix common/ includes.
1142         * stap-probe.c: Fix common/ includes.
1143         * spu-linux-nat.c: Fix common/ includes.
1144         * sparc-nat.c: Fix common/ includes.
1145         * source.c: Fix common/ includes.
1146         * solib.c: Fix common/ includes.
1147         * solib-target.c: Fix common/ includes.
1148         * ser-unix.c: Fix common/ includes.
1149         * ser-tcp.c: Fix common/ includes.
1150         * ser-pipe.c: Fix common/ includes.
1151         * ser-base.c: Fix common/ includes.
1152         * selftest-arch.c: Fix common/ includes.
1153         * s12z-tdep.c: Fix common/ includes.
1154         * rust-exp.y: Fix common/ includes.
1155         * rs6000-aix-tdep.c: Fix common/ includes.
1156         * riscv-tdep.c: Fix common/ includes.
1157         * remote.c: Fix common/ includes.
1158         * remote-notif.h: Fix common/ includes.
1159         * remote-fileio.h: Fix common/ includes.
1160         * remote-fileio.c: Fix common/ includes.
1161         * regcache.h: Fix common/ includes.
1162         * regcache.c: Fix common/ includes.
1163         * record-btrace.c: Fix common/ includes.
1164         * python/python.c: Fix common/ includes.
1165         * python/py-type.c: Fix common/ includes.
1166         * python/py-inferior.c: Fix common/ includes.
1167         * progspace.h: Fix common/ includes.
1168         * producer.c: Fix common/ includes.
1169         * procfs.c: Fix common/ includes.
1170         * proc-api.c: Fix common/ includes.
1171         * printcmd.c: Fix common/ includes.
1172         * ppc-linux-nat.c: Fix common/ includes.
1173         * parser-defs.h: Fix common/ includes.
1174         * osdata.c: Fix common/ includes.
1175         * obsd-nat.c: Fix common/ includes.
1176         * nat/x86-linux.c: Fix common/ includes.
1177         * nat/x86-linux-dregs.c: Fix common/ includes.
1178         * nat/x86-dregs.h: Fix common/ includes.
1179         * nat/x86-dregs.c: Fix common/ includes.
1180         * nat/ppc-linux.c: Fix common/ includes.
1181         * nat/mips-linux-watch.h: Fix common/ includes.
1182         * nat/mips-linux-watch.c: Fix common/ includes.
1183         * nat/linux-waitpid.c: Fix common/ includes.
1184         * nat/linux-ptrace.h: Fix common/ includes.
1185         * nat/linux-ptrace.c: Fix common/ includes.
1186         * nat/linux-procfs.c: Fix common/ includes.
1187         * nat/linux-personality.c: Fix common/ includes.
1188         * nat/linux-osdata.c: Fix common/ includes.
1189         * nat/linux-namespaces.c: Fix common/ includes.
1190         * nat/linux-btrace.h: Fix common/ includes.
1191         * nat/linux-btrace.c: Fix common/ includes.
1192         * nat/fork-inferior.c: Fix common/ includes.
1193         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1194         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1195         * nat/aarch64-linux.c: Fix common/ includes.
1196         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1197         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1198         * namespace.h: Fix common/ includes.
1199         * mips-linux-tdep.c: Fix common/ includes.
1200         * minsyms.c: Fix common/ includes.
1201         * mi/mi-parse.h: Fix common/ includes.
1202         * mi/mi-main.c: Fix common/ includes.
1203         * mi/mi-cmd-env.c: Fix common/ includes.
1204         * memrange.h: Fix common/ includes.
1205         * memattr.c: Fix common/ includes.
1206         * maint.h: Fix common/ includes.
1207         * maint.c: Fix common/ includes.
1208         * main.c: Fix common/ includes.
1209         * machoread.c: Fix common/ includes.
1210         * location.c: Fix common/ includes.
1211         * linux-thread-db.c: Fix common/ includes.
1212         * linux-nat.c: Fix common/ includes.
1213         * linux-fork.c: Fix common/ includes.
1214         * inline-frame.c: Fix common/ includes.
1215         * infrun.c: Fix common/ includes.
1216         * inflow.c: Fix common/ includes.
1217         * inferior.h: Fix common/ includes.
1218         * inferior.c: Fix common/ includes.
1219         * infcmd.c: Fix common/ includes.
1220         * inf-ptrace.c: Fix common/ includes.
1221         * inf-child.c: Fix common/ includes.
1222         * ia64-linux-nat.c: Fix common/ includes.
1223         * i387-tdep.c: Fix common/ includes.
1224         * i386-tdep.c: Fix common/ includes.
1225         * i386-linux-tdep.c: Fix common/ includes.
1226         * i386-linux-nat.c: Fix common/ includes.
1227         * i386-go32-tdep.c: Fix common/ includes.
1228         * i386-fbsd-tdep.c: Fix common/ includes.
1229         * i386-fbsd-nat.c: Fix common/ includes.
1230         * guile/scm-type.c: Fix common/ includes.
1231         * guile/guile.c: Fix common/ includes.
1232         * go32-nat.c: Fix common/ includes.
1233         * gnu-nat.c: Fix common/ includes.
1234         * gdbthread.h: Fix common/ includes.
1235         * gdbarch-selftests.c: Fix common/ includes.
1236         * gdb_usleep.c: Fix common/ includes.
1237         * gdb_select.h: Fix common/ includes.
1238         * gdb_bfd.c: Fix common/ includes.
1239         * gcore.c: Fix common/ includes.
1240         * fork-child.c: Fix common/ includes.
1241         * findvar.c: Fix common/ includes.
1242         * fbsd-nat.c: Fix common/ includes.
1243         * event-top.c: Fix common/ includes.
1244         * event-loop.c: Fix common/ includes.
1245         * dwarf2read.c: Fix common/ includes.
1246         * dwarf2loc.c: Fix common/ includes.
1247         * dwarf2-frame.c: Fix common/ includes.
1248         * dwarf-index-cache.c: Fix common/ includes.
1249         * dtrace-probe.c: Fix common/ includes.
1250         * disasm-selftests.c: Fix common/ includes.
1251         * defs.h: Fix common/ includes.
1252         * csky-tdep.c: Fix common/ includes.
1253         * cp-valprint.c: Fix common/ includes.
1254         * cp-support.h: Fix common/ includes.
1255         * cp-support.c: Fix common/ includes.
1256         * corelow.c: Fix common/ includes.
1257         * completer.h: Fix common/ includes.
1258         * completer.c: Fix common/ includes.
1259         * compile/compile.c: Fix common/ includes.
1260         * compile/compile-loc2c.c: Fix common/ includes.
1261         * compile/compile-cplus-types.c: Fix common/ includes.
1262         * compile/compile-cplus-symbols.c: Fix common/ includes.
1263         * command.h: Fix common/ includes.
1264         * cli/cli-dump.c: Fix common/ includes.
1265         * cli/cli-cmds.c: Fix common/ includes.
1266         * charset.c: Fix common/ includes.
1267         * build-id.c: Fix common/ includes.
1268         * btrace.h: Fix common/ includes.
1269         * btrace.c: Fix common/ includes.
1270         * breakpoint.h: Fix common/ includes.
1271         * breakpoint.c: Fix common/ includes.
1272         * ax.h: 
1273         (enum agent_op): Fix common/ includes.
1274         * ax-general.c (struct aop_map): Fix common/ includes.
1275         * ax-gdb.c: Fix common/ includes.
1276         * auxv.c: Fix common/ includes.
1277         * auto-load.c: Fix common/ includes.
1278         * arm-tdep.c: Fix common/ includes.
1279         * arch/riscv.c: Fix common/ includes.
1280         * arch/ppc-linux-common.c: Fix common/ includes.
1281         * arch/i386.c: Fix common/ includes.
1282         * arch/arm.c: Fix common/ includes.
1283         * arch/arm-linux.c: Fix common/ includes.
1284         * arch/arm-get-next-pcs.c: Fix common/ includes.
1285         * arch/amd64.c: Fix common/ includes.
1286         * arch/aarch64.c: Fix common/ includes.
1287         * arch/aarch64-insn.c: Fix common/ includes.
1288         * arch-utils.c: Fix common/ includes.
1289         * amd64-windows-tdep.c: Fix common/ includes.
1290         * amd64-tdep.c: Fix common/ includes.
1291         * amd64-sol2-tdep.c: Fix common/ includes.
1292         * amd64-obsd-tdep.c: Fix common/ includes.
1293         * amd64-nbsd-tdep.c: Fix common/ includes.
1294         * amd64-linux-tdep.c: Fix common/ includes.
1295         * amd64-linux-nat.c: Fix common/ includes.
1296         * amd64-fbsd-tdep.c: Fix common/ includes.
1297         * amd64-fbsd-nat.c: Fix common/ includes.
1298         * amd64-dicos-tdep.c: Fix common/ includes.
1299         * amd64-darwin-tdep.c: Fix common/ includes.
1300         * agent.c: Fix common/ includes.
1301         * ada-lang.h: Fix common/ includes.
1302         * ada-lang.c: Fix common/ includes.
1303         * aarch64-tdep.c: Fix common/ includes.
1304
1305 2019-01-25  Tom Tromey  <tom@tromey.com>
1306
1307         * common/create-version.sh: Use common/version.h.
1308
1309 2019-01-24  Pedro Alves  <palves@redhat.com>
1310
1311         * infrun.c (signal_stop, signal_print, signal_program)
1312         (signal_catch, signal_pass): Now arrays instead of pointers.
1313         (update_signals_program_target, do_target_resume)
1314         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1315         * linux-nat.c (linux_nat_target::pass_signals)
1316         (linux_nat_target::create_inferior, linux_nat_target::attach):
1317         Adjust.
1318         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1319         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1320         * procfs.c (procfs_target::pass_signals): Adjust.
1321         * record-full.c (record_full_target::resume): Adjust.
1322         * remote.c (remote_target::pass_signals)
1323         (remote_target::program_signals): Adjust.
1324         * target-debug.h (target_debug_print_signals): Now takes a
1325         gdb::array_view as parameter.  Adjust.
1326         * target.h (target_ops) <pass_signals, program_signals>: Replace
1327         pointer and length parameters with gdb::array_view.
1328         (target_pass_signals, target_program_signals): Likewise.
1329         * target-delegates.c: Regenerate.
1330
1331 2019-01-24  Pedro Alves  <palves@redhat.com>
1332
1333         * common/forward-scope-exit.h
1334         (forward_scope_exit::forward_scope_exit): Pass arguments to
1335         m_bind_function directly, instead of creating a std::bind and
1336         copying that.
1337
1338 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1339
1340         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1341         for static members.
1342         (pass_in_v_vfp_candidate): Likewise.
1343
1344 2019-01-23  Tom Tromey  <tom@tromey.com>
1345             Pedro Alves  <palves@redhat.com>
1346
1347         * regcache.c (class regcache_invalidator): Remove.
1348         (regcache::raw_write): Use make_scope_exit.
1349
1350 2019-01-23  Tom Tromey  <tom@tromey.com>
1351
1352         * ui-out.h (class ui_out_emit_type): Update comment.
1353
1354 2019-01-23  Tom Tromey  <tom@tromey.com>
1355
1356         * infrun.c (fetch_inferior_event): Update comment.
1357
1358 2019-01-23  Tom Tromey  <tom@tromey.com>
1359             Pedro Alves  <palves@redhat.com>
1360
1361         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1362         parameter.
1363         (fetch_inferior_event): Use SCOPE_EXIT.
1364
1365
1366 2019-01-23  Tom Tromey  <tom@tromey.com>
1367             Pedro Alves  <palves@redhat.com>
1368
1369         * infrun.c (disable_thread_events): Delete.
1370         (stop_all_threads): Use SCOPE_EXIT.
1371
1372 2019-01-23  Tom Tromey  <tom@tromey.com>
1373             Pedro Alves  <palves@redhat.com>
1374
1375         * symfile.c: Include forward-scope-exit.h.
1376         (clear_symtab_users_cleanup): Replace forward declaration with
1377         a FORWARD_SCOPE_EXIT.
1378         (syms_from_objfile_1): Use the forward_scope_exit and
1379         gdb::optional instead of cleanup_function.
1380         (reread_symbols): Use the forward_scope_exit instead of
1381         cleanup_function.
1382         (clear_symtab_users_cleanup): Remove function.
1383
1384 2019-01-23  Tom Tromey  <tom@tromey.com>
1385             Pedro Alves  <palves@redhat.com>
1386
1387         * linux-nat.c: Include scope-exit.h.
1388         (cleanup_target_stop): Remove.
1389         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1390         SCOPE_EXIT.
1391
1392 2019-01-23  Tom Tromey  <tom@tromey.com>
1393             Pedro Alves  <palves@redhat.com>
1394
1395         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1396         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1397
1398 2019-01-23  Tom Tromey  <tom@tromey.com>
1399             Andrew Burgess  <andrew.burgess@embecosm.com>
1400             Pedro Alves  <palves@redhat.com>
1401
1402         * infrun.c (fetch_inferior_event): Use scope_exit.
1403         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1404         * top.c (execute_command): Use scope_exit.
1405         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1406         * utils.c (do_bpstat_clear_actions_cleanup)
1407         (make_bpstat_clear_actions_cleanup): Remove.
1408
1409 2019-01-23  Tom Tromey  <tom@tromey.com>
1410             Pedro Alves  <palves@redhat.com>
1411
1412         * infrun.c: Include "common/scope-exit.h"
1413         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1414         (wait_for_inferior): Use SCOPE_EXIT.
1415         (fetch_inferior_event): Use scope_exit.
1416
1417 2019-01-23  Tom Tromey  <tom@tromey.com>
1418             Pedro Alves  <palves@redhat.com>
1419
1420         * breakpoint.c (create_breakpoint): Remove cleanup.
1421
1422 2019-01-23  Tom Tromey  <tom@tromey.com>
1423             Andrew Burgess  <andrew.burgess@embecosm.com>
1424             Pedro Alves  <palves@redhat.com>
1425
1426 2019-01-23  Pedro Alves  <palves@redhat.com>
1427
1428         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1429
1430 2019-01-23  Pedro Alves  <palves@redhat.com>
1431             Andrew Burgess  <andrew.burgess@embecosm.com>
1432
1433         * gdbthread.h: Include "common/forward-scope-exit.h".
1434         (scoped_finish_thread_state): Redefine custom class in terms of
1435         forward_scope_exit.
1436
1437 2019-01-23  Pedro Alves  <palves@redhat.com>
1438             Andrew Burgess  <andrew.burgess@embecosm.com>
1439
1440         * common/forward-scope-exit.h: New file.
1441
1442 2019-01-23  Pedro Alves  <palves@redhat.com>
1443             Andrew Burgess  <andrew.burgess@embecosm.com>
1444             Tom Tromey  <tom@tromey.com>
1445
1446         * common/scope-exit.h: New file.
1447
1448 2019-01-23  Pedro Alves  <palves@redhat.com>
1449
1450         * common/preprocessor.h (ESC): Rename to ...
1451         (ESC_PARENS): ... this.
1452         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1453         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1454
1455 2019-01-23  Tom Tromey  <tom@tromey.com>
1456
1457         * language.h (class scoped_switch_to_sym_language_if_auto):
1458         Initialize m_lang in both cases.
1459
1460 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1461
1462         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1463         with XCNEW.
1464
1465 2019-01-22  Tom Tromey  <tom@tromey.com>
1466
1467         * corelow.c: Do not include sys/file.h.
1468
1469 2019-01-22  Tom Tromey  <tom@tromey.com>
1470
1471         * tui/tui-wingeneral.h: Include gdb_curses.h.
1472
1473 2019-01-22  Tom Tromey  <tom@tromey.com>
1474
1475         * source-cache.h (class source_cache) <get_source_lines,
1476         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1477
1478 2019-01-22  Tom Tromey  <tom@tromey.com>
1479
1480         * remote-fileio.h (struct remote_target): Declare.
1481
1482 2019-01-22  Tom Tromey  <tom@tromey.com>
1483
1484         * python/py-arch.c: Do not include py-ref.h.
1485         * python/py-bpevent.c: Do not include py-ref.h.
1486         * python/py-cmd.c: Do not include py-ref.h.
1487         * python/py-continueevent.c: Do not include py-ref.h.
1488         * python/py-event.h: Do not include py-ref.h.
1489         * python/py-evtregistry.c: Do not include py-ref.h.
1490         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1491         * python/py-frame.c: Do not include py-ref.h.
1492         * python/py-framefilter.c: Do not include py-ref.h.
1493         * python/py-function.c: Do not include py-ref.h.
1494         * python/py-infevents.c: Do not include py-ref.h.
1495         * python/py-linetable.c: Do not include py-ref.h.
1496         * python/py-objfile.c: Do not include py-ref.h.
1497         * python/py-param.c: Do not include py-ref.h.
1498         * python/py-prettyprint.c: Do not include py-ref.h.
1499         * python/py-progspace.c: Do not include py-ref.h.
1500         * python/py-symbol.c: Do not include py-ref.h.
1501         * python/py-symtab.c: Do not include py-ref.h.
1502         * python/py-type.c: Do not include py-ref.h.
1503         * python/py-unwind.c: Do not include py-ref.h.
1504         * python/py-utils.c: Do not include py-ref.h.
1505         * python/py-value.c: Do not include py-ref.h.
1506         * python/py-varobj.c: Do not include py-ref.h.
1507         * python/py-xmethods.c: Do not include py-ref.h.
1508         * python/python.c: Do not include py-ref.h.
1509         * varobj.c: Do not include py-ref.h.
1510
1511 2019-01-22  Tom Tromey  <tom@tromey.com>
1512
1513         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1514         keyword for bcache.
1515
1516 2019-01-22  Tom Tromey  <tom@tromey.com>
1517
1518         * compile/compile-cplus-types.c: Remove a comment by #include.
1519
1520 2019-01-22  Tom Tromey  <tom@tromey.com>
1521
1522         * compile/gcc-c-plugin.h: Include compile-internal.h.
1523
1524 2019-01-22  Tom Tromey  <tom@tromey.com>
1525
1526         * stabsread.c (EXTERN): Do not define.
1527         (symnum, next_symbol_text_func, processing_gcc_compilation)
1528         (within_function, global_sym_chain, global_stabs)
1529         (previous_stab_code, this_object_header_files)
1530         (n_this_object_header_files)
1531         (n_allocated_this_object_header_files): Define.
1532         * stabsread.h (EXTERN): Never define.  Use "extern".
1533
1534 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1535
1536         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1537         history_value.
1538
1539 2019-01-21  Tom Tromey  <tom@tromey.com>
1540
1541         * ui-out.c: Fix includes.
1542         * tui/tui-source.c: Fix includes.
1543         * target.c: Fix includes.
1544         * remote.c: Fix includes.
1545         * regcache.c: Fix includes.
1546         * python/py-block.c: Fix includes.
1547         * printcmd.c: Fix includes.
1548         * or1k-tdep.c: Fix includes.
1549         * mi/mi-main.c: Fix includes.
1550         * m32r-tdep.c: Fix includes.
1551         * csky-tdep.c: Fix includes.
1552         * compile/compile-cplus-types.c: Fix includes.
1553         * cli/cli-interp.c: Fix includes.
1554
1555 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1556
1557         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1558         for padding.
1559
1560 2019-01-16  Tom Tromey  <tom@tromey.com>
1561
1562         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1563         earlier.
1564         (struct objfile) <msymbols_range>: Move from top level.
1565         <msymbols>: New method.
1566         (class objfile_msymbols): Remove.
1567         * symtab.c (default_collect_symbol_completion_matches_break_on):
1568         Update.
1569         * symmisc.c (dump_msymbols): Update.
1570         * stabsread.c (scan_file_globals): Update.
1571         * objc-lang.c (info_selectors_command, info_classes_command)
1572         (find_methods): Update.
1573         * minsyms.c (find_solib_trampoline_target): Update.
1574         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1575         * coffread.c (coff_symfile_read): Update.
1576         * ada-lang.c (ada_lookup_simple_minsym)
1577         (ada_collect_symbol_completion_matches): Update.
1578
1579 2019-01-16  Tom Tromey  <tom@tromey.com>
1580
1581         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1582         type.  Remove no-argument constructor.
1583         <iterator::operator++>: Simplify.
1584         <begin>: Update.
1585         <end>: Use minimal_symbol_count.
1586
1587 2019-01-16  Tom Tromey  <tom@tromey.com>
1588
1589         * objfiles.h (struct objfile) <psymtabs>: New method.
1590         (class objfile_psymtabs): Remove.
1591         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1592         typedef.
1593         <range>: New method.
1594         (require_partial_symbols): Change return type.
1595         * psymtab.c (require_partial_symbols)
1596         (psym_expand_symtabs_matching): Update.
1597         * mdebugread.c (parse_partial_symbols): Update.
1598         * dbxread.c (dbx_end_psymtab): Update.
1599
1600 2019-01-15  Tom Tromey  <tom@tromey.com>
1601
1602         * symtab.c (lookup_objfile_from_block)
1603         (lookup_symbol_in_objfile_symtabs)
1604         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1605         (find_line_symtab, info_sources_command)
1606         (default_collect_symbol_completion_matches_break_on)
1607         (make_source_files_completion_list): Update.
1608         * symmisc.c (print_objfile_statistics, dump_objfile)
1609         (maintenance_print_symbols, maintenance_info_symtabs)
1610         (maintenance_check_symtabs, maintenance_info_line_tables):
1611         Update.
1612         * source.c (select_source_symtab)
1613         (forget_cached_source_info_for_objfile): Update.
1614         * objfiles.h (class objfile_compunits): Remove.
1615         (struct objfile) <compunits_range>: New typedef.
1616         (compunits): New method.
1617         * objfiles.c (objfile_relocate1): Update.
1618         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1619         * maint.c (count_symtabs_and_blocks): Update.
1620         * linespec.c (iterate_over_all_matching_symtabs): Update.
1621         * cp-support.c (add_symbol_overload_list_qualified): Update.
1622         * coffread.c (coff_symtab_read): Update.
1623         * ada-lang.c (add_nonlocal_symbols)
1624         (ada_collect_symbol_completion_matches)
1625         (ada_add_global_exceptions): Update.
1626
1627 2019-01-15  Tom Tromey  <tom@tromey.com>
1628
1629         * progspace.h (program_space) <objfiles_safe_range>: New
1630         typedef.
1631         <objfiles_safe>: New method.
1632         * objfiles.h (class all_objfiles_safe): Remove.
1633         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1634         * jit.c (jit_inferior_exit_hook): Update.
1635
1636 2019-01-17  Tom Tromey  <tom@tromey.com>
1637
1638         * progspace.h (program_space) <objfiles_range>: New typedef.
1639         <objfiles>: New method.
1640         <objfiles_head>: Rename from objfiles.
1641         (object_files): Update.
1642         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1643         * guile/scm-pretty-print.c
1644         (ppscm_find_pretty_printer_from_objfiles): Update.
1645         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1646         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1647         Update.
1648         * python/py-progspace.c (pspy_get_objfiles): Update.
1649         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1650         Update.
1651         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1652         (objfpy_lookup_objfile_by_build_id): Update.
1653         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1654         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1655         Update.
1656         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1657         (expand_symtab_containing_pc, lookup_objfile_from_block)
1658         (lookup_static_symbol, basic_lookup_transparent_type)
1659         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1660         (find_line_symtab, info_sources_command)
1661         (default_collect_symbol_completion_matches_break_on)
1662         (make_source_files_completion_list, find_main_name): Update.
1663         * symmisc.c (print_symbol_bcache_statistics)
1664         (print_objfile_statistics, maintenance_print_symbols)
1665         (maintenance_print_msymbols, maintenance_print_objfiles)
1666         (maintenance_info_symtabs, maintenance_check_symtabs)
1667         (maintenance_expand_symtabs, maintenance_info_line_tables):
1668         Update.
1669         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1670         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1671         (map_overlay_command, unmap_overlay_command)
1672         (simple_overlay_update, expand_symtabs_matching)
1673         (map_symbol_filenames): Update.
1674         * symfile-debug.c (set_debug_symfile): Update.
1675         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1676         Update.
1677         * source.c (select_source_symtab, forget_cached_source_info):
1678         Update.
1679         * solib.c (solib_read_symbols): Update.
1680         * solib-spu.c (append_ocl_sos): Update.
1681         * psymtab.c (maintenance_print_psymbols)
1682         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1683         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1684         * printcmd.c (info_symbol_command): Update.
1685         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1686         Update.
1687         * objfiles.h (class all_objfiles): Remove.
1688         * objfiles.c (have_partial_symbols, have_full_symbols)
1689         (have_minimal_symbols, qsort_cmp, update_section_map)
1690         (shared_objfile_contains_address_p)
1691         (default_iterate_over_objfiles_in_search_order): Update.
1692         * objc-lang.c (info_selectors_command, info_classes_command)
1693         (find_methods): Update.
1694         * minsyms.c (find_solib_trampoline_target): Update.
1695         * maint.c (maintenance_info_sections)
1696         (maintenance_translate_address, count_symtabs_and_blocks):
1697         Update.
1698         * main.c (captured_main_1): Update.
1699         * linux-thread-db.c (try_thread_db_load_from_pdir)
1700         (has_libpthread): Update.
1701         * linespec.c (iterate_over_all_matching_symtabs)
1702         (search_minsyms_for_name): Update.
1703         * jit.c (jit_find_objf_with_entry_addr): Update.
1704         * hppa-tdep.c (find_unwind_entry)
1705         (hppa_lookup_stub_minimal_symbol): Update.
1706         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1707         Update.
1708         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1709         (elf_gnu_ifunc_resolve_by_got): Update.
1710         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1711         * dwarf-index-write.c (save_gdb_index_command): Update.
1712         * cp-support.c (add_symbol_overload_list_qualified): Update.
1713         * breakpoint.c (create_overlay_event_breakpoint)
1714         (create_longjmp_master_breakpoint)
1715         (create_std_terminate_master_breakpoint)
1716         (create_exception_master_breakpoint): Update.
1717         * blockframe.c (find_pc_partial_function): Update.
1718         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1719         (ada_collect_symbol_completion_matches)
1720         (ada_add_global_exceptions): Update.
1721
1722 2019-01-17  Tom Tromey  <tom@tromey.com>
1723
1724         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1725         declare VEC.
1726         (solib_target_parse_libraries): Change return type.
1727         (library_list_start_segment, library_list_start_section)
1728         (library_list_end_library, library_list_start_library); Update.
1729         (solib_target_free_library_list): Remove.
1730         (solib_target_parse_libraries): Remove cleanup.  Change return
1731         type.
1732         (solib_target_current_sos): Update.
1733
1734 2019-01-17  Tom Tromey  <tromey@bapiya>
1735
1736         * valprint.c: Replace "the the" with "the".
1737         * symtab.c: Replace "the the" with "the".
1738         * solib.c: Replace "the the" with "the".
1739         * solib-dsbt.c: Replace "the the" with "the".
1740         * linespec.c: Replace "the the" with "the".
1741         * dwarf2loc.h: Replace "the the" with "the".
1742         * amd64-windows-tdep.c: Replace "the the" with "the".
1743         * aarch64-tdep.c: Replace "the the" with "the".
1744
1745 2019-01-16  Keith Seitz  <keiths@redhat.com>
1746
1747         PR gdb/23773
1748         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1749         <builder>: Rename to ..
1750         <m_builder>: ... this and make private.
1751         (dwarf2_cu::get_builder): New method.  Change all users of
1752         `builder' to use this method.
1753         (dwarf2_start_symtab): Move to ...
1754         (dwarf2_cu::start_symtab): ... here.  Update all callers
1755         (setup_type_unit_groups): Move to ...
1756         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1757         callers.
1758         (dwarf2_cu::reset_builder): New method.
1759         (process_full_compunit, process_full_type_unit): Use
1760         dwarf2_cu::reset_builder.
1761         (follow_die_offset): Record the ancestor CU if it is different
1762         from the followed DIE's CU.
1763         (follow_die_sig_1): Likewise.
1764
1765 2019-01-15  Tom Tromey  <tom@tromey.com>
1766
1767         * remote.c (class remote_state) <buf>: Now a char_vector.
1768         <buf_size>: Remove.
1769         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1770         parameter.
1771         (remote_target::getpkt_or_notif_sane_1)
1772         (remote_target::getpkt_sane)
1773         (remote_target::getpkt_or_notif_sane): Likewise.
1774         (class remote_target) <putpkt>: New overload.
1775         (remote_target::read_frame): Change type of "buf_p".  Remove
1776         sizeof_p parameter.
1777         (packet_ok): New overload.
1778         (packet_check_result): New overload.
1779         Update all uses.
1780
1781 2019-01-14  Tom Tromey  <tom@tromey.com>
1782
1783         * remote-notif.c (handle_notification, remote_notif_ack)
1784         (remote_notif_parse): Make "buf" const.
1785         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1786         const.
1787         (remote_notif_parse, remote_notif_ack, handle_notification):
1788         Likewise.
1789         * remote.c (remote_notif_stop_parse): Make "buf" const.
1790         (remote_target::remote_parse_stop_reply): Make "buf" const.
1791         (remote_notif_stop_ack): Make "buf" const.
1792
1793 2019-01-14  Tom Tromey  <tom@tromey.com>
1794
1795         * remote.c (remote_console_output): Make parameter const.
1796
1797 2019-01-14  Tom Tromey  <tom@tromey.com>
1798
1799         * target-debug.h (target_debug_print_signals): Constify.
1800         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1801         * procfs.c (procfs_target::pass_signals): Update.
1802         * linux-nat.c (linux_nat_target::pass_signals): Update.
1803         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1804         * target-delegates.c: Rebuild.
1805         * remote.c (remote_target::program_signals): Update.
1806         (remote_target::pass_signals): Update.
1807         * target.c (target_pass_signals): Constify argument.
1808         (target_program_signals): Likewise.
1809         * target.h (struct target_ops) <pass_signals, program_signals>:
1810         Constify argument.
1811         (target_pass_signals, target_program_signals): Constify argument.
1812
1813 2019-01-14  Tom Tromey  <tom@tromey.com>
1814
1815         PR tui/28819:
1816         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1817
1818 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1819
1820         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1821         field.
1822         * rs6000-tdep.c: Include reggroups.h.
1823         (IS_V_ALIAS_PSEUDOREG): Define.
1824         (rs6000_register_name): Return names for the "vX" aliases.
1825         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1826         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1827         aliases.  Call default_register_reggroup_p for all other
1828         pseudo-registers.
1829         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1830         New functions.
1831         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1832         Handle "vX" aliases.
1833         (v_alias_pseudo_register_collect): New function.
1834         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1835         (rs6000_gdbarch_init): Initialize "vX" aliases as
1836         pseudo-registers.  Restore registration of
1837         rs6000_pseudo_register_reggroup_p with
1838         set_tdesc_pseudo_register_reggroup_p.
1839
1840 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1841
1842         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1843         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1844         set_gdbarch_num_pseudo_regs.
1845
1846 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1847
1848         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1849         Remove arg prefixname, add do_set and do_show.
1850         Add member functions set_list and show_list.
1851         * cli/cli-style.c (class cli_style_option): Update accordingly.
1852         (style_set_list): Move to file scope.
1853         (style_show_list): Likewise.
1854         (set_style): Call help_list.
1855         (show_style): Call cmd_show_list.
1856         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1857         Update to use the new macro.
1858
1859 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1860
1861         * ada-lang.c (_initialize_ada_language): Expand the help text
1862         for the "catch exception" command.
1863
1864 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1865
1866         * symtab.c (matching_obj_sections): Initialize obj,
1867         declare it closer to its usage.
1868
1869 2019-01-10  Tom Tromey  <tom@tromey.com>
1870
1871         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1872         (basic_inf_threads_range): Remove.
1873         (inf_threads_range, inf_non_exited_threads_range)
1874         (safe_inf_threads_range): Use next_adapter.
1875
1876 2019-01-10  Keith Seitz  <keiths@redhat.com>
1877
1878         PR gdb/23712
1879         PR symtab/23010
1880         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1881         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1882
1883 2019-01-10  Keith Seitz  <keiths@redhat.com>
1884
1885         PR gdb/23712
1886         PR symtab/23010
1887         * dictionary.c (pending_to_vector): Remove.
1888         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1889         Remove _1 suffix, replacing functions of the same name.  Update
1890         all callers.
1891         (dict_create_hashed, dict_create_hashed_expandable)
1892         (dict_create_linear, dict_create_linear_expandable, dict_free)
1893         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1894         Make functions static.
1895
1896 2019-01-10  Keith Seitz  <keiths@redhat.com>
1897
1898         PR gdb/23712
1899         PR symtab/23010
1900         * dictionary.h (struct dictionary): Replace declaration with
1901         multidictionary.
1902         (dict_create_hashed, dict_create_hashed_expandable)
1903         (dict_create_linear, dict_create_linear_expandable)
1904         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1905         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1906         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1907         taking multidictionary argument.
1908         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1909         * block.h (struct block) <dict>: Change to multidictionary
1910         and rename `multidict'.
1911         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1912         symmisc.c: Update all dictionary references to multidictionary.
1913
1914 2019-01-10  Keith Seitz  <keiths@redhat.com>
1915
1916         PR gdb/23712
1917         PR symtab/23010
1918         * dictionary.c: Include unordered_map.
1919         (pending_to_vector): New function.
1920         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1921         Rewrite the non-"_1" functions to take vector instead
1922         of linked list.
1923         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1924         "new" _1 versions of the same name.
1925         (multidictionary): Define.
1926         (std::hash<enum language): New definition.
1927         (collate_pending_symbols_by_language, mdict_create_hashed)
1928         (mdict_create_hashed_expandable, mdict_create_linear)
1929         (mdict_create_linear_expandable, mdict_free)
1930         (find_language_dictionary, create_new_language_dictionary)
1931         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1932         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1933         (mdict_size, mdict_empty): New functions.
1934         * dictionary.h (mdict_iterator): Define.
1935
1936 2019-01-10  Pedro Alves  <palves@redhat.com>
1937
1938         * breakpoint.c (read_uploaded_action)
1939         (create_tracepoint_from_upload): Adjust to use
1940         gdb::unique_xmalloc_ptr.
1941         * ctf.c (ctf_write_uploaded_tp):
1942         (SET_ARRAY_FIELD): Use emplace_back.
1943         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1944         * tracefile-tfile.c (tfile_write_uploaded_tp):
1945         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1946         gdb::unique_xmalloc_ptr.
1947         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1948         at_string, cond_string, cmd_strings>: Replace char pointers
1949         with gdb::unique_xmalloc_ptr.
1950
1951 2019-01-10  Pedro Alves  <palves@redhat.com>
1952
1953         * solib-target.c (library_list_start_library): Don't xstrdup name.
1954
1955 2019-01-10  Pedro Alves  <palves@redhat.com>
1956
1957         * mdebugread.c (parse_partial_symbols): Use
1958         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1959
1960 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1961
1962         * linux-fork.c (scoped_switch_fork_info)
1963         <~scoped_switch_fork_info>: Fix incorrect variable name.
1964
1965 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1966
1967         * linux-fork.c (scoped_switch_fork_info)
1968         <scoped_switch_fork_info>: Make explicit.
1969         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1970
1971 2019-01-10  Tom Tromey  <tom@tromey.com>
1972
1973         * objfiles.h (objfile::reset_psymtabs): Update.
1974         * objfiles.c (objfile::objfile): Update.
1975         * psymtab.h (psymtab_storage::obstack): Update.
1976         (psymtab_storage::m_obstack): Use gdb::optional.
1977         (class psymtab_storage): Update comment.  Remove objfile
1978         parameter.
1979         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1980
1981 2019-01-10  Tom Tromey  <tom@tromey.com>
1982
1983         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1984         <free_psymtabs>: Now private.
1985         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1986         (allocate_psymtab): Use new method.
1987
1988 2019-01-10  Tom Tromey  <tom@tromey.com>
1989
1990         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1991         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1992         * mdebugread.c (parse_partial_symbols): Use
1993         allocate_dependencies.
1994         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1995         allocate_dependencies.
1996         (process_psymtab_comp_unit_reader)
1997         (build_type_psymtab_dependencies): Likewise.
1998         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1999
2000 2019-01-10  Tom Tromey  <tom@tromey.com>
2001
2002         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
2003         PSYMBOL_SET_LANGUAGE.
2004         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
2005
2006 2019-01-10  Tom Tromey  <tom@tromey.com>
2007
2008         * psymtab.h (psymtab_storage::obstack): New method.
2009         <m_obstack>: Rename from obstack; now private.
2010         * psymtab.c (psymtab_storage): Update.
2011         * dwarf2read.c (create_addrmap_from_index)
2012         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
2013         Update.
2014
2015 2019-01-10  Tom Tromey  <tom@tromey.com>
2016
2017         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
2018         * objfiles.h (objfile::reset_psymtabs): New method.
2019
2020 2019-01-10  Tom Tromey  <tom@tromey.com>
2021
2022         * symmisc.c (print_symbol_bcache_statistics): Update.
2023         (print_objfile_statistics): Update.
2024         * symfile.c (reread_symbols): Update.
2025         * psymtab.h (class psymtab_storage): New.
2026         * psymtab.c (psymtab_storage): New constructor.
2027         (~psymtab_storage): New destructor.
2028         (require_partial_symbols): Update.
2029         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
2030         (find_pc_sect_psymtab, find_pc_sect_psymbol)
2031         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
2032         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
2033         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
2034         (start_psymtab_common, end_psymtab_common)
2035         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
2036         (allocate_psymtab): Update.
2037         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
2038         Update.
2039         (dump_psymtab_addrmap, maintenance_print_psymbols)
2040         (maintenance_check_psymtabs): Update.
2041         (class objfile_psymtabs): Move to objfiles.h.
2042         * psympriv.h (discard_psymtab): Now inline.
2043         (psymtab_discarder::psymtab_discarder): Update.
2044         (psymtab_discarder::~psymtab_discarder): Update.
2045         (ALL_OBJFILE_PSYMTABS): Rewrite.
2046         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
2047         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
2048         Remove fields.
2049         <partial_symtabs>: New field.
2050         (class objfile_psymtabs): Move from psymtab.h.  Update.
2051         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
2052         psymbol_cache.
2053         (objfile::~objfile): Don't destroy psymbol_cache.
2054         * mdebugread.c (parse_partial_symbols): Update.
2055         * dwarf2read.c (create_addrmap_from_index)
2056         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2057         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2058         (add_partial_subprogram, dwarf2_ranges_read): Update.
2059         * dwarf-index-write.c (write_address_map)
2060         (write_one_signatured_type, recursively_write_psymbols)
2061         (class debug_names, class debug_names, write_psymtabs_to_index):
2062         Update.
2063
2064 2019-01-10  Tom Tromey  <tom@tromey.com>
2065
2066         * symtab.h (SYMBOL_SET_NAMES): Update.
2067         (symbol_set_names): Update.
2068         (MSYMBOL_SET_NAMES): Update.
2069         * symtab.c (symbol_set_names): Change argument to be an
2070         objfile_per_bfd_storage.
2071         * psymtab.c (add_psymbol_to_bcache): Update.
2072         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2073
2074 2019-01-10  Tom Tromey  <tom@tromey.com>
2075
2076         * symtab.c (create_demangled_names_hash): Change argument to be an
2077         objfile_per_bfd_storage.
2078         (symbol_set_names): Update.
2079
2080 2019-01-10  Tom Tromey  <tom@tromey.com>
2081
2082         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2083         init_psymbol_list.
2084         * psymtab.c (init_psymbol_list): Do nothing if already called.
2085         * psympriv.h (init_psymbol_list): Add comment.
2086         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2087         init_psymbol_list.
2088         * dbxread.c (dbx_symfile_read): Unconditionally call
2089         init_psymbol_list.
2090
2091 2019-01-10  Tom Tromey  <tom@tromey.com>
2092
2093         * xcoffread.c (scan_xcoff_symtab): Update.
2094         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2095         "where".
2096         * mdebugread.c (parse_partial_symbols)
2097         (handle_psymbol_enumerators): Update.
2098         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2099         * dbxread.c (read_dbx_symtab): Update.
2100         * psympriv.h (psymbol_placement): New enum.
2101         (add_psymbol_to_list): Update.
2102
2103 2019-01-10  Tom Tromey  <tom@tromey.com>
2104
2105         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2106         static_psymbols parameters.
2107         (scan_xcoff_symtab): Update.
2108         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2109         static_psymbols parameters.
2110         * psympriv.h (start_psymtab_common): Update.
2111         * mdebugread.c (parse_partial_symbols): Update.
2112         * dwarf2read.c (create_partial_symtab): Update.
2113         * dbxread.c (read_dbx_symtab): Update.
2114         (start_psymtab): Remove global_psymbols and static_psymbols
2115         parameters.
2116
2117 2019-01-10  Tom Tromey  <tom@tromey.com>
2118
2119         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2120         * psymtab.c (allocate_psymtab): Add comment.
2121         * psympriv.h (allocate_psymtab): Add comment.
2122         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2123         initializations.
2124         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2125
2126 2019-01-10  Tom Tromey  <tom@tromey.com>
2127
2128         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2129         Don't declare.
2130         * mipsread.c: Include mdebugread.h.
2131         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2132         Declare.
2133         * elfread.c: Include mdebugread.h.
2134
2135 2019-01-09  Tom Tromey  <tom@tromey.com>
2136
2137         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2138         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2139         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2140         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2141         (psym_lookup_symbol, psym_find_last_source_symtab)
2142         (psym_forget_cached_source_info, psym_print_stats)
2143         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2144         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2145         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2146         (psym_find_compunit_symtab_by_address)
2147         (maintenance_print_psymbols, maintenance_info_psymtabs)
2148         (maintenance_check_psymtabs): Use ranged for.
2149         * psymtab.h (class objfile_psymtabs): New.
2150         (require_partial_symbols): Return objfile_psymtabs.
2151         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2152
2153 2019-01-09  Tom Tromey  <tom@tromey.com>
2154
2155         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2156         (find_pc_mapped_section, list_overlays_command)
2157         (map_overlay_command, unmap_overlay_command)
2158         (simple_overlay_update): Use all_objfiles.
2159         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2160         * printcmd.c (info_symbol_command): Use all_objfiles.
2161         * objfiles.h (ALL_OBJSECTIONS): Remove.
2162         * maint.c (maintenance_translate_address): Use all_objfiles.
2163         * gcore.c (gcore_create_callback): Use all_objfiles.
2164         (objfile_find_memory_regions): Likewise.
2165
2166 2019-01-09  Tom Tromey  <tom@tromey.com>
2167
2168         * symtab.c (find_line_symtab, info_sources_command)
2169         (make_source_files_completion_list): Use objfile_compunits.
2170         * source.c (select_source_symtab): Use objfile_compunits.
2171         * objfiles.h (struct objfile): Update comment.
2172         (ALL_OBJFILES): Remove.
2173         (ALL_FILETABS): Remove.
2174         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2175         objfile_compunits.
2176
2177 2019-01-09  Tom Tromey  <tom@tromey.com>
2178
2179         * symmisc.c (print_objfile_statistics, dump_objfile)
2180         (maintenance_print_symbols): Use compunit_filetabs.
2181         * source.c (forget_cached_source_info_for_objfile): Use
2182         compunit_filetabs.
2183         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2184         (ALL_FILETABS): Use compunit_filetabs.
2185         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2186         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2187
2188 2019-01-09  Tom Tromey  <tom@tromey.com>
2189
2190         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2191         (compunit_filetabs): New.
2192         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2193         compunit_filetabs.
2194         (info_sources_command, make_source_files_completion_list): Remove
2195         declaration.
2196         * symmisc.c (print_objfile_statistics, dump_objfile)
2197         (maintenance_print_symbols): Remove declaration.
2198         (maintenance_info_symtabs): Use compunit_filetabs.
2199         (maintenance_info_line_tables): Likewise.
2200         * source.c (select_source_symtab): Change local variable name.
2201         (forget_cached_source_info_for_objfile): Remove declaration.
2202         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2203         * objfiles.c (objfile_relocate1): Remove declaration.
2204         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2205         declaration.
2206         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2207         * coffread.c (coff_symtab_read): Remove declaration.
2208         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2209         compunit_filetabs.
2210
2211 2019-01-09  Tom Tromey  <tom@tromey.com>
2212
2213         * symtab.c (lookup_objfile_from_block)
2214         (find_pc_sect_compunit_symtab, search_symbols)
2215         (default_collect_symbol_completion_matches_break_on): Use
2216         objfile_compunits.
2217         * objfiles.h (ALL_COMPUNITS): Remove.
2218         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2219         * cp-support.c (add_symbol_overload_list_qualified): Use
2220         objfile_compunits.
2221         * ada-lang.c (ada_collect_symbol_completion_matches)
2222         (ada_add_global_exceptions): Use objfile_compunits.
2223
2224 2019-01-09  Tom Tromey  <tom@tromey.com>
2225
2226         * source.c (select_source_symtab)
2227         (forget_cached_source_info_for_objfile): Remove declaration.
2228         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2229         declaration.
2230         * maint.c (count_symtabs_and_blocks): Remove declaration.
2231         * cp-support.c (add_symbol_overload_list_qualified): Remove
2232         declaration.
2233         * coffread.c (coff_symtab_read): Remove declaration.
2234         * symtab.c (lookup_symbol_in_objfile_symtabs)
2235         (basic_lookup_transparent_type_1): Use objfile_compunits.
2236         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2237         (info_sources_command, search_symbols)
2238         (default_collect_symbol_completion_matches_break_on)
2239         (make_source_files_completion_list): Remove declaration.
2240         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2241         (ada_collect_symbol_completion_matches)
2242         (ada_add_global_exceptions): Remove declaration.
2243         * linespec.c (iterate_over_all_matching_symtabs): Use
2244         objfile_compunits.
2245         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2246         (class objfile_compunits): New.
2247         (ALL_COMPUNITS): Use objfile_compunits.
2248         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2249         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2250         objfile_compunits.
2251         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2252
2253 2019-01-09  Tom Tromey  <tom@tromey.com>
2254
2255         * symtab.c (search_symbols)
2256         (default_collect_symbol_completion_matches_break_on): Use
2257         objfile_msymbols.
2258         * ada-lang.c (ada_lookup_simple_minsym)
2259         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2260         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2261         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2262         objfile_msymbols.
2263         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2264         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2265         * objc-lang.c (find_methods): Use objfile_msymbols.
2266         (info_selectors_command, info_classes_command): Likewise.
2267         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2268         * objfiles.h (class objfile_msymbols): New.
2269         (ALL_OBJFILE_MSYMBOLS): Remove.
2270         (ALL_MSYMBOLS): Remove.
2271
2272 2019-01-09  Tom Tromey  <tom@tromey.com>
2273
2274         * common/next-iterator.h (next_adapter): Add Iterator template
2275         parameter.
2276         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2277         (class all_objfiles_safe): New.
2278         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2279         * objfiles.c (put_objfile_before): Update comment.
2280         (add_separate_debug_objfile): Likewise.
2281         (free_all_objfiles): Use all_objfiles_safe.
2282         (objfile_purge_solibs): Likewise.
2283
2284 2019-01-09  Tom Tromey  <tom@tromey.com>
2285
2286         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2287         (expand_symtab_containing_pc, lookup_static_symbol)
2288         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2289         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2290         all_objfiles.
2291         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2292         * breakpoint.c (create_overlay_event_breakpoint)
2293         (create_longjmp_master_breakpoint)
2294         (create_std_terminate_master_breakpoint)
2295         (create_exception_master_breakpoint): Use all_objfiles.
2296         * linux-thread-db.c (try_thread_db_load_from_pdir)
2297         (has_libpthread): Use all_objfiles.
2298         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2299         * linespec.c (iterate_over_all_matching_symtabs)
2300         (search_minsyms_for_name): Use all_objfiles.
2301         * maint.c (maintenance_info_sections): Use all_objfiles.
2302         * main.c (captured_main_1): Use all_objfiles.
2303         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2304         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2305         * guile/scm-pretty-print.c
2306         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2307         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2308         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2309         (maintenance_print_msymbols): Use all_objfiles.
2310         * source.c (select_source_symtab): Use all_objfiles.
2311         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2312         * symfile.c (remove_symbol_file_command)
2313         (expand_symtabs_matching, map_symbol_filenames): Use
2314         all_objfiles.
2315         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2316         all_objfiles.
2317         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2318         * objc-lang.c (find_methods): Use all_objfiles.
2319         * objfiles.c (have_partial_symbols, have_full_symbols)
2320         (have_minimal_symbols, qsort_cmp)
2321         (default_iterate_over_objfiles_in_search_order): Use
2322         all_objfiles.
2323         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2324         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2325         (maintenance_check_psymtabs): Use all_objfiles.
2326         (ALL_PSYMTABS): Remove.
2327         * compile/compile-object-run.c (do_module_cleanup): Use
2328         all_objfiles.
2329         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2330         * cp-support.c (add_symbol_overload_list_qualified): Use
2331         all_objfiles.
2332         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2333         Use all_objfiles.
2334         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2335         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2336         all_objfiles.
2337         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2338         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2339         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2340         Uses all_objfiles.
2341         * solib.c (solib_read_symbols): Use all_objfiles
2342
2343 2019-01-09  Tom Tromey  <tom@tromey.com>
2344
2345         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2346         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2347         all_objfiles.
2348         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2349         * symmisc.c (print_symbol_bcache_statistics)
2350         (print_objfile_statistics, maintenance_print_objfiles)
2351         (maintenance_info_symtabs, maintenance_check_symtabs)
2352         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2353         all_objfiles.
2354         * source.c (forget_cached_source_info): Use all_objfiles.
2355         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2356         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2357         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2358         * objfiles.c (update_section_map): Use all_objfiles.
2359         (shared_objfile_contains_address_p): Likewise.
2360         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2361         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2362
2363 2019-01-09  Tom Tromey  <tom@tromey.com>
2364
2365         * common/next-iterator.h: New file.
2366         * objfiles.h (class all_objfiles): New.
2367         (struct objfile_iterator): New.
2368
2369 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2370
2371         * NEWS: Move the description of the changed "frame", "select-frame",
2372          and "info frame" commands to the Changed commands section.
2373
2374 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2375
2376         * gdbtypes.c (check_stub_method_group): Remove handling of old
2377         mangling schemes.
2378         * linespec.c (find_methods): Likewise.
2379         * stabsread.c (read_member_functions): Likewise.
2380         * valops.c (search_struct_method): Likewise.
2381         (value_struct_elt_for_reference): Likewise.
2382         * NEWS: Mention this change.
2383
2384 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2385
2386         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2387         print_source_lines.
2388         * source.c (print_source_lines_base): Update line number check.
2389         (print_source_lines): New function.
2390         (source_lines_range::source_lines_range): New function.
2391         * source.h (class source_lines_range): New class.
2392         (print_source_lines): New declaration.
2393
2394 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2395
2396         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2397
2398 2019-01-08  Tom Tromey  <tom@tromey.com>
2399             Simon Marchi  <simon.marchi@ericsson.com>
2400
2401         PR gdb/24060
2402         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2403         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2404         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2405         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2406         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2407         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2408
2409 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2410
2411         * source.c (select_source_symtab): Move header comment to
2412         declaration in source.h.
2413         (forget_cached_source_info_for_objfile): Likewise.
2414         (forget_cached_source_info): Likewise.
2415         (identify_source_line): Likewise.
2416         * source.h (identify_source_line): Move declaration from symtab.h
2417         and add comment from source.c
2418         (print_source_lines): Likewise.
2419         (forget_cached_source_info_for_objfile): Likewise.
2420         (forget_cached_source_info): Likewise.
2421         (select_source_symtab): Likewise.
2422         (enum print_source_lines_flag): Move definition from symtab.h.
2423         * symtab.h (identify_source_line): Move declaration to source.h.
2424         (print_source_lines): Likewise.
2425         (forget_cached_source_info_for_objfile): Likewise.
2426         (forget_cached_source_info): Likewise.
2427         (select_source_symtab): Likewise.
2428         (enum print_source_lines_flag): Move definition to source.h.
2429         * tui/tui-hooks.c: Add 'source.h' include.
2430
2431 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2432
2433         * source.c (print_source_lines_base): Handle requests to print
2434         reverse line number sequences, and guard against empty lines
2435         string.
2436
2437 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2438
2439         * source.c (print_source_lines_base): Fix skip of '\r' if next
2440         character is '\n'.
2441
2442 2019-01-06  Tom Tromey  <tom@tromey.com>
2443
2444         * c-exp.y (struct c_parse_state) <macro_original_text,
2445         expansion_obstack>: New member.
2446         (macro_original_text, expansion_obstack): Remove globals.
2447         (scan_macro_expansion, scanning_macro_expansion)
2448         (finished_macro_expansion): Update.
2449         (scan_macro_cleanup): Remove.
2450         (yylex, c_parse): Update.
2451
2452 2019-01-06  Tom Tromey  <tom@tromey.com>
2453
2454         * c-exp.y (struct c_parse_state) <strings>: New member.
2455         (operator_stoken): Update.
2456
2457 2019-01-06  Tom Tromey  <tom@tromey.com>
2458
2459         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2460         (union type_stack_elt) <typelist_val>: Now a pointer to
2461         std::vector.
2462         (type_stack_cleanup): Don't declare.
2463         (push_typelist): Update.
2464         * parse.c (pop_typelist): Return a std::vector.
2465         (push_typelist): Take a std::vector.
2466         (follow_types): Update.  Do not free args.
2467         (type_stack_cleanup): Remove.
2468         * c-exp.y (struct c_parse_state): New.
2469         (cpstate): New global.
2470         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2471         (nonempty_typelist): Update.
2472         (func_mod): Create a new vector.
2473         (c_parse): Create a c_parse_state.
2474         (check_parameter_typelist): Do not delete params.
2475         (function_method): Update.  Do not delete type_list.
2476
2477 2019-01-06  Tom Tromey  <tom@tromey.com>
2478
2479         PR gdb/28155:
2480         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2481         check_typedef.
2482         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2483         (print_return_value): Likewise.
2484
2485 2019-01-05  Tom Tromey  <tom@tromey.com>
2486
2487         * contrib/cleanup_check.py: Remove.
2488         * contrib/gcc-with-excheck: Remove.
2489         * contrib/exsummary.py: Remove.
2490         * contrib/excheck.py: Remove.
2491
2492 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2493
2494         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2495         NULL. Initialize tpprev to NULL instead of assigning it
2496         to NULL on the next statement.
2497         * windows-nat.c (windows_delete_thread): Remove check for
2498         main_thread_id before printing thread exit notifications.
2499         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2500         Remove thread ID check against main_thread_id.
2501         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2502         windows_delete_thread.
2503         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2504
2505 2019-01-04  Tom Tromey  <tom@tromey.com>
2506
2507         * compile/compile.c (_initialize_compile): Use upper case for
2508         metasyntactic variables.
2509         * symmisc.c (_initialize_symmisc): Use upper case for
2510         metasyntactic variables.
2511         * psymtab.c (_initialize_psymtab): Use upper case for
2512         metasyntactic variables.
2513         * demangle.c (demangle_command): Use upper case for metasyntactic
2514         variables.
2515         (_initialize_demangler): Likewise.
2516         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2517         variables.
2518
2519 2019-01-03  Tom Tromey  <tom@tromey.com>
2520
2521         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2522
2523 2019-01-03  Tom Tromey  <tom@tromey.com>
2524
2525         * python/py-symtab.c (salpy_str): Update.
2526         (struct salpy_sal_object) <symtab>: Now a PyObject.
2527         (salpy_dealloc): Update.
2528         (del_objfile_sal): Use gdbpy_ref.
2529
2530 2019-01-03  Tom Tromey  <tom@tromey.com>
2531
2532         * python/py-type.c (convert_field): Use new_reference.  Return
2533         gdbpy_ref.
2534         (make_fielditem): Return gdbpy_ref.
2535         (typy_fields): Update.
2536         (typy_getitem): Update.
2537         (field_name): Return gdbpy_ref.  Use new_reference.
2538         (typy_iterator_iternext): Update.
2539
2540 2019-01-03  Tom Tromey  <tom@tromey.com>
2541
2542         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2543
2544 2019-01-03  Tom Tromey  <tom@tromey.com>
2545
2546         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2547         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2548         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2549         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2550         (pspy_set_type_printers): Likewise.
2551         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2552         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2553         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2554         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2555         (objfpy_set_type_printers): Likewise.
2556
2557 2019-01-03  Tom Tromey  <tom@tromey.com>
2558
2559         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2560         (gdbpy_print_stack): Use gdbpy_err_fetch.
2561         * python/python-internal.h (class gdbpy_err_fetch): New class.
2562         (class gdbpy_enter) <m_error_type, m_error_value,
2563         m_error_traceback>: Remove.
2564         <m_error>: New member.
2565         (gdbpy_exception_to_string): Don't declare.
2566         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2567         * python/py-value.c (convert_value_from_python): Use
2568         gdbpy_err_fetch.
2569         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2570         gdbpy_exception_to_string.
2571         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2572         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2573         gdbpy_err_fetch.
2574
2575 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2576
2577         * linux-nat.c (delete_lwp_cleanup): Delete.
2578         (struct lwp_deleter): New struct.
2579         (lwp_info_up): New typedef.
2580         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2581         lwp_info_up.
2582
2583 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2584
2585         * linux-fork.c (class scoped_switch_fork_info): New class.
2586         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2587
2588 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2589
2590         * valops.c (find_overload_match): Remove use of null_cleanup, and
2591         calls to do_cleanups.
2592
2593 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2594
2595         * compile/compile-cplus-types.c
2596         (compile_cplus_instance::decl_name): Handle changes to
2597         cp_func_name.
2598         * cp-support.c (cp_func_name): Update header comment, update
2599         return type.
2600         * cp-support.h (cp_func_name): Update return type in declaration.
2601         * valops.c (find_overload_match): Move temp_func local to top
2602         level of function and change its type.  Use temp_func to hold and
2603         delete temporary string obtained from cp_func_name.
2604
2605 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2606
2607         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2608         gdb::char_vector, remove cleanup, and update uses of `msg`.
2609
2610 2019-01-03  Jim Wilson  <jimw@sifive.com>
2611
2612         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2613
2614 2019-01-02  Tom Tromey  <tom@tromey.com>
2615
2616         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2617         (tdesc_parse_xml): Remove cleanups.
2618         * target-descriptions.h (make_cleanup_free_target_description):
2619         Don't declare.
2620         (target_desc_deleter): New struct.
2621         (target_desc_up): New typedef.
2622         * target-descriptions.c (target_desc_deleter::operator()): Rename
2623         from free_target_description.
2624         (make_cleanup_free_target_description): Remove.
2625
2626 2019-01-02  Tom Tromey  <tom@tromey.com>
2627
2628         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2629         constructor, destructor.
2630         (linespec_parser): Remove typedef.
2631         (~linespec_parser): Rename from linespec_parser_delete.
2632         (linespec_lex_to_end, linespec_complete_label)
2633         (linespec_complete): Update.
2634         (decode_line_full): Remove cleanups.
2635         (decode_line_1): Update.
2636
2637 2019-01-02  Tom Tromey  <tom@tromey.com>
2638
2639         * python/python-internal.h (inferior_to_inferior_object): Change
2640         return type.
2641         * python/py-exitedevent.c (create_exited_event_object): Update.
2642         * python/py-inferior.c (inferior_to_inferior_object): Return
2643         gdbpy_ref.
2644         (python_new_inferior, python_inferior_deleted)
2645         (thread_to_thread_object, delete_thread_object)
2646         (build_inferior_list, gdbpy_selected_inferior): Update.
2647         * python/py-infthread.c (create_thread_object): Update.  Also fail
2648         if inferior_to_inferior_object fails.
2649
2650 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2651
2652         * inferior.h (class inferior) <displaced_step_state>: New field.
2653         * infrun.h (struct displaced_step_state): Move here from
2654         infrun.c.  Initialize fields, add constructor.
2655         <inf>: Remove field.
2656         <reset>: New method.
2657         * infrun.c (struct displaced_step_inferior_state): Move to
2658         infrun.h.
2659         (displaced_step_inferior_states): Remove.
2660         (get_displaced_stepping_state): Adust.
2661         (displaced_step_in_progress_any_inferior): Adjust.
2662         (displaced_step_in_progress_thread): Adjust.
2663         (displaced_step_in_progress): Adjust.
2664         (add_displaced_stepping_state): Remove.
2665         (get_displaced_step_closure_by_addr): Adjust.
2666         (remove_displaced_stepping_state): Remove.
2667         (infrun_inferior_exit): Call displaced_step_state.reset.
2668         (use_displaced_stepping): Don't check for NULL.
2669         (displaced_step_prepare_throw): Call
2670         get_displaced_stepping_state.
2671         (displaced_step_fixup): Don't check for NULL.
2672         (prepare_for_detach): Don't check for NULL.
2673
2674 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2675
2676         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2677          in case of call that did not complete.
2678
2679 2019-01-02  Andrey Utkin  <autkin@undo.io>
2680
2681         * symfile.c (find_separate_debug_file): Fix search of debug files for
2682         remote debuggee.
2683
2684 2019-01-02  Tom Tromey  <tom@tromey.com>
2685
2686         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2687         indentation.
2688         * python/py-frame.c (frapy_older): Remove cast.
2689         (frapy_newer): Likewise.
2690         * python/py-breakpoint.c (local_setattro): Remove cast.
2691         * python/py-arch.c (archpy_name): Remove local variable.
2692         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2693
2694 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2695
2696         * unittests/basic_string_view/element_access/char/empty.cc:
2697         Fix year range in copyright header.
2698
2699 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2700
2701         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2702         Delete.
2703         <operator==>: Update with for removed field.
2704         <hash>: Likewise.
2705         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2706         <isa_features>: ...this.
2707         <abi_features>: New field.
2708         (riscv_isa_flen): Update comment.
2709         (riscv_abi_xlen): New declaration.
2710         (riscv_abi_flen): New declaration.
2711         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2712         isa_features.
2713         (riscv_abi_xlen): New function.
2714         (riscv_isa_flen): Update to get answer from isa_features.
2715         (riscv_abi_flen): New function.
2716         (riscv_has_fp_abi): Update to get answer from abi_features.
2717         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2718         xlen and flen.
2719         (riscv_call_info) <xlen, flen>: Update comment.
2720         (riscv_call_arg_struct): Remove invalid assertions
2721         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2722         is removed.
2723         (riscv_gdbarch_init): Gather isa features and abi features
2724         separately, ensure both match on the gdbarch when reusing an old
2725         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2726         a target with 64-bit float hardware.
2727
2728 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2729
2730         * source.c (search_command_helper): Stop reverse search
2731         when line 1 has been searched.
2732
2733 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2734
2735         * record-full.c (record_full_base_target::close): Rewrite
2736         record_full_core_buf_list free logic.
2737
2738 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2739
2740         * break-catch-syscall.c (print_one_catch_syscall): xfree
2741         the last text.
2742
2743 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2744
2745         * top.c (print_gdb_version): Update Copyright year in version
2746         message.
2747
2748 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2749
2750         Update copyright year range in all GDB files.
2751
2752 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2753
2754         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2755
2756 For older changes see ChangeLog-2018.
2757 \f
2758 Local Variables:
2759 mode: change-log
2760 left-margin: 8
2761 fill-column: 74
2762 version-control: never
2763 coding: utf-8
2764 End:
2765