gdb/ChangeLog

   1 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
   2
   3         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
   4         Handle tabs.
   5
   6 2019-03-18  Tom Tromey  <tromey@adacore.com>
   7
   8         * ada-lang.c (empty_array): Add "high" parameter.
   9         (ada_evaluate_subexp): Update.
  10
  11 2019-03-17  Sergei Trofimovich <siarheit@google.com>
  12
  13         * unittests/string_view-selftests.c: Define
  14         _initialize_string_view_selftests unconditionally.
  15
  16 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
  17
  18         PR gdb/24350
  19         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
  20
  21 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
  22
  23         PR gdb/24351
  24         * windows-nat.c (display_selector): Fix format specifiers.
  25
  26 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
  27
  28         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
  29         tui_refill_source_window instead of tui_refresh_win, to update the
  30         current execution line.  This fixes redisplay of the current line
  31         when stepping through the code with "next" or "step".
  32
  33 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
  34
  35         * source-cache.c (source_cache::get_source_lines): Call
  36         find_source_lines to initialize s->nlines.  This fixes vertical
  37         scrolling of TUI source window when the DOWN arrow is pressed.
  38
  39 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  40
  41         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
  42         linux-thread-db.c (_initialize_thread_db): Likewise.
  43
  44 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
  45
  46         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
  47         wclrtoeol in tui_show_source_line".  This reverts changes made in
  48         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
  49
  50 2019-03-15  Tom Tromey  <tom@tromey.com>
  51
  52         * symtab.h (struct minimal_symbol): Derive from
  53         general_symbol_info.
  54         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
  55         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
  56         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
  57         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
  58         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
  59         (MSYMBOL_SEARCH_NAME): Update.
  60         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
  61         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
  62         * minsyms.c (minimal_symbol_reader::record_full): Update.
  63
  64 2019-03-15  Tom Tromey  <tom@tromey.com>
  65
  66         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
  67
  68 2019-03-15  Tom Tromey  <tom@tromey.com>
  69
  70         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
  71         unique_xmalloc_ptr.
  72         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
  73         Update.
  74         * minsyms.c (lookup_minimal_symbol_by_pc_section)
  75         (build_minimal_symbol_hash_tables)
  76         (minimal_symbol_reader::install): Update.
  77
  78 2019-03-15  Tom Tromey  <tom@tromey.com>
  79
  80         * symtab.c (create_demangled_names_hash): Update.
  81         (symbol_set_names): Update.
  82         * objfiles.h (struct objfile_per_bfd_storage)
  83         <demangled_names_hash>: Now an htab_up.
  84         * objfiles.c (objfile_per_bfd_storage): Simplify.
  85
  86 2019-03-15  Tom Tromey  <tom@tromey.com>
  87
  88         * objfiles.h (struct objfile_per_bfd_storage): Declare
  89         destructor.
  90         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
  91         New.
  92         (get_objfile_bfd_data): Use new.  Don't initialize
  93         language_of_main.
  94         (free_objfile_per_bfd_storage): Remove.
  95         (objfile_bfd_data_free, objfile::~objfile): Use delete.
  96
  97 2019-03-15  Tom Tromey  <tom@tromey.com>
  98
  99         * symfile.c (reread_symbols): Update.
 100         * objfiles.c (objfile::objfile): Update.
 101         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
 102         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
 103         comment.
 104         (minimal_symbol_reader::install): Update.
 105         (terminate_minimal_symbol_table): Remove.
 106         * jit.c (jit_object_close_impl): Update.
 107
 108 2019-03-15  Tom Tromey  <tom@tromey.com>
 109
 110         * minsyms.c (minimal_symbol_reader::record_full): Remove some
 111         initializations.
 112
 113 2019-03-15  Tom Tromey  <tom@tromey.com>
 114
 115         * objfiles.h (struct objfile_per_bfd_storage)
 116         <demangled_hash_languages>: Now a bitset.
 117         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 118         (lookup_minimal_symbol): Update.
 119
 120 2019-03-15  Tom Tromey  <tom@tromey.com>
 121
 122         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
 123         Don't return the symbol.
 124         * coffread.c (record_minimal_symbol): Use record_full.
 125
 126 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 127
 128         The MS-Windows port of ncurses fails to switch to a color pair if
 129         one or both of the colors are the implicit default colors.  This
 130         change records the default colors when TUI is initialized, and
 131         then specifies them explicitly when a color pair uses the default
 132         colors.  This allows color styling in TUI mode on MS-Windows.
 133
 134         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 135         ncurses_norm_attr.
 136         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 137         colors in ncurses_norm_attr.
 138         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 139         "none", replace it with the default color recorded in
 140         ncurses_norm_attr.
 141
 142 2019-03-14  Tom Tromey  <tromey@adacore.com>
 143
 144         * source-cache.h (class source_cache) <get_source_lines>: Return
 145         std::string.
 146         * source-cache.c (source_cache::extract_lines): Handle case where
 147         first_pos==npos.  Return std::string.
 148         (source_cache::get_source_lines): Update.
 149
 150 2019-03-14  Tom Tromey  <tromey@adacore.com>
 151
 152         * NEWS: Add item for "style sources" commands.
 153         * source-cache.c (source_cache::get_source_lines): Check
 154         source_styling.
 155         * cli/cli-style.c (source_styling): New global.
 156         (_initialize_cli_style): Add "style sources" commands.
 157         (show_style_sources): New function.
 158         * cli/cli-style.h (source_styling): Declare.
 159
 160 2019-03-14  Pedro Alves  <palves@redhat.com>
 161             Tom Tromey  <tromey@adacore.com>
 162
 163         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 164         * tui/tui-winsource.c (tui_refill_source_window): New function,
 165         from...
 166         (tui_horizontal_source_scroll): ... here.  Move some logic.
 167         * cli/cli-style.c (set_style_enabled): Notify new observable.
 168         * tui/tui-hooks.c (tui_redisplay_source): New function.
 169         (tui_attach_detach_observers): Attach or detach
 170         tui_redisplay_source.
 171         * observable.h (source_styling_changed): New observable.
 172         * observable.c: Define source_styling_changed observable.
 173
 174 2019-03-13  Tom Tromey  <tromey@adacore.com>
 175
 176         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
 177         (i386_gnu_nat_target::store_registers): Update.
 178         * target-debug.h (target_debug_print_std_string): New macro.
 179         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 180         * windows-tdep.c (display_one_tib): Update.
 181         * tui/tui-stack.c (tui_make_status_line): Update.
 182         * top.c (print_inferior_quit_action): Update.
 183         * thread.c (thr_try_catch_cmd): Update.
 184         (add_thread_with_info): Update.
 185         (thread_target_id_str): Update.
 186         (thr_try_catch_cmd): Update.
 187         (thread_command): Update.
 188         (thread_find_command): Update.
 189         * record-btrace.c (record_btrace_target::info_record)
 190         (record_btrace_resume_thread, record_btrace_target::resume)
 191         (record_btrace_cancel_resume, record_btrace_step_thread)
 192         (record_btrace_target::wait, record_btrace_target::wait)
 193         (record_btrace_target::wait, record_btrace_target::stop): Update.
 194         * progspace.c (print_program_space): Update.
 195         * process-stratum-target.c
 196         (process_stratum_target::thread_address_space): Update.
 197         * linux-fork.c (linux_fork_mourn_inferior)
 198         (detach_checkpoint_command, info_checkpoints_command)
 199         (linux_fork_context): Update.
 200         (linux_fork_detach): Update.
 201         (class scoped_switch_fork_info): Update.
 202         (delete_checkpoint_command): Update.
 203         * infrun.c (follow_fork_inferior): Update.
 204         (follow_fork_inferior): Update.
 205         (proceed_after_vfork_done): Update.
 206         (handle_vfork_child_exec_or_exit): Update.
 207         (follow_exec): Update.
 208         (displaced_step_prepare_throw): Update.
 209         (displaced_step_restore): Update.
 210         (start_step_over): Update.
 211         (resume_1): Update.
 212         (clear_proceed_status_thread): Update.
 213         (proceed): Update.
 214         (print_target_wait_results): Update.
 215         (do_target_wait): Update.
 216         (context_switch): Update.
 217         (stop_all_threads): Update.
 218         (restart_threads): Update.
 219         (finish_step_over): Update.
 220         (handle_signal_stop): Update.
 221         (switch_back_to_stepped_thread): Update.
 222         (keep_going_pass_signal): Update.
 223         (print_exited_reason): Update.
 224         (normal_stop): Update.
 225         * inferior.c (inferior_pid_to_str): Change return type.
 226         (print_selected_inferior): Update.
 227         (add_inferior): Update.
 228         (detach_inferior): Update.
 229         * dummy-frame.c (fprint_dummy_frames): Update.
 230         * dcache.c (dcache_info_1): Update.
 231         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 232         (btrace_fetch, btrace_clear): Update.
 233         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 234         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 235         type.
 236         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 237         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 238         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 239         * gdbarch.c, gdbarch.h: Rebuild.
 240         * gdbarch.sh (core_pid_to_str): Change return type.
 241         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 242         return type.
 243         (windows_nat_target::pid_to_str): Change return type.
 244         (windows_delete_thread): Update.
 245         (windows_nat_target::attach): Update.
 246         (windows_nat_target::files_info): Update.
 247         * target-delegates.c: Rebuild.
 248         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 249         return type.
 250         (sol_thread_target::pid_to_str): Change return type.
 251         * remote.c (class remote_target) <pid_to_str>: Change return
 252         type.
 253         (remote_target::pid_to_str): Change return type.
 254         (extended_remote_target::attach, remote_target::remote_stop_ns)
 255         (remote_target::remote_notif_remove_queued_reply)
 256         (remote_target::push_stop_reply, remote_target::disable_btrace):
 257         Update.
 258         (extended_remote_target::attach): Update.
 259         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 260         type.
 261         (gdbsim_target::pid_to_str): Change return type.
 262         * ravenscar-thread.c (struct ravenscar_thread_target)
 263         <pid_to_str>: Change return type.
 264         (ravenscar_thread_target::pid_to_str): Change return type.
 265         * procfs.c (class procfs_target) <pid_to_str>: Change return
 266         type.
 267         (procfs_target::pid_to_str): Change return type.
 268         (procfs_target::attach): Update.
 269         (procfs_target::detach): Update.
 270         (procfs_target::fetch_registers): Update.
 271         (procfs_target::store_registers): Update.
 272         (procfs_target::wait): Update.
 273         (procfs_target::files_info): Update.
 274         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 275         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 276         return type.
 277         (nto_procfs_target::pid_to_str): Change return type.
 278         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 279         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 280         return type.
 281         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 282         (exit_lwp): Update.
 283         (attach_proc_task_lwp_callback, get_detach_signal)
 284         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 285         (linux_nat_target::resume, wait_lwp, stop_callback)
 286         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 287         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 288         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 289         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 290         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 291         type.
 292         (inf_ptrace_target::attach): Update.
 293         (inf_ptrace_target::files_info): Update.
 294         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 295         type.
 296         (go32_nat_target::pid_to_str): Change return type.
 297         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 298         (gnu_nat_target::wait): Update.
 299         (gnu_nat_target::wait): Update.
 300         (gnu_nat_target::resume): Update.
 301         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 302         (fbsd_nat_target::wait): Update.
 303         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 304         type.
 305         (darwin_nat_target::attach): Update.
 306         * corelow.c (class core_target) <pid_to_str>: Change return type.
 307         (core_target::pid_to_str): Change return type.
 308         * target.c (normal_pid_to_str): Change return type.
 309         (default_pid_to_str): Likewise.
 310         (target_pid_to_str): Change return type.
 311         (target_translate_tls_address): Update.
 312         (target_announce_detach): Update.
 313         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 314         return type.
 315         (bsd_uthread_target::pid_to_str): Change return type.
 316         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 317         type.
 318         (bsd_kvm_target::pid_to_str): Change return type.
 319         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 320         return type.
 321         (aix_thread_target::pid_to_str): Change return type.
 322         * target.h (struct target_ops) <pid_to_str>: Change return type.
 323         (target_pid_to_str, normal_pid_to_str): Likewise.
 324         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 325         type.
 326         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 327         type.
 328         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 329         return type.
 330         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 331         type.
 332         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 333         type.
 334         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 335         return type.
 336
 337 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 338
 339         * NEWS: Mention that the new default MI version is 3.  Mention
 340         changes to the output of commands and events that deal with
 341         multi-location breakpoints.
 342         * breakpoint.c: Include "mi/mi-out.h".
 343         (print_one_breakpoint): Change output syntax if using MI version
 344         >= 3.
 345         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 346         New.
 347         (mi_multi_location_breakpoint_output_fixed): New.
 348         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 349         (mi_cmd_fix_multi_location_breakpoint_output): New.
 350         (mi_multi_location_breakpoint_output_fixed): New.
 351         * mi/mi-cmds.c (mi_cmds): Register command
 352         -fix-multi-location-breakpoint-output.
 353         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 354         interpreter "mi".
 355
 356 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 357
 358         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 359         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 360         instantiate mi_ui_out based on interpreter name.
 361         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 362         * mi/mi-main.c (mi_load_progress): Likewise.
 363
 364 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 365
 366         * NEWS: Combine separate "New targets" sections for 8.3.
 367
 368 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 369
 370         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 371         (ppcfbsd_init_abi): Install gdbarch
 372         "fetch_tls_load_module_address" and "get_thread_local_address"
 373         methods.
 374
 375 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 376
 377         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 378         (riscv_fbsd_init_abi): Install gdbarch
 379         "fetch_tls_load_module_address" and "get_thread_local_address"
 380         methods.
 381
 382 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 383
 384         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 385         (i386fbsd_init_abi): Install gdbarch
 386         "fetch_tls_load_module_address" and "get_thread_local_address"
 387         methods.
 388
 389 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 390
 391         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 392         (amd64fbsd_init_abi): Install gdbarch
 393         "fetch_tls_load_module_address" and "get_thread_local_address"
 394         methods.
 395
 396 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 397
 398         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 399         (struct fbsd_pspace_data): New type.
 400         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 401         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 402         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 403         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 404         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 405
 406 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 407
 408         * gdbtypes.c (lookup_struct_elt): New function.
 409         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 410         * gdbtypes.h (struct struct_elt): New type.
 411         (lookup_struct_elt): New prototype.
 412
 413 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 414
 415         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 416         remove disabled code block.
 417
 418 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 419
 420         * gdbarch.sh (get_thread_local_address): New method.
 421         * gdbarch.h, gdbarch.c: Regenerate.
 422         * target.c (target_translate_tls_address): Use
 423         gdbarch_get_thread_local_address if present instead of
 424         target::get_thread_local_address.
 425
 426 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 427
 428         * target.h (target::get_thread_local_address): Update comment.
 429
 430 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 431
 432         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 433         objfile->separate_debug_objfile_backlink if not NULL.
 434
 435 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 436
 437         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 438         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 439         (amd64bsd_store_inferior_registers): Likewise.
 440         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 441         Enable segment base registers.
 442         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 443         PT_GETFSBASE and PT_GETGSBASE.
 444         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 445         PT_SETGSBASE.
 446         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 447         segment base registers.
 448         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 449
 450 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 451
 452         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 453         Update calls to i386_target_description to add 'segments'
 454         parameter.
 455         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 456         add segment base registers.
 457         * arch/i386.c (i386_create_target_description): Add 'segments'
 458         parameter to enable segment base registers.
 459         * arch/i386.h (i386_create_target_description): Likewise.
 460         * features/i386/32bit-segments.xml: New file.
 461         * features/i386/32bit-segments.c: Generate.
 462         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 463         call to i386_target_description to add 'segments' parameter.
 464         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 465         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 466         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 467         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 468         if feature is present.
 469         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 470         Add 'segments' parameter to call to i386_target_description.
 471         (i386_target_description): Add 'segments' parameter to enable
 472         segment base registers.
 473         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 474         to call to i386_target_description.
 475         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 476         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 477         Define I386_NUM_REGS.
 478         (i386_target_description): Add 'segments' parameter to enable
 479         segment base registers.
 480
 481 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 482
 483         PR/24325
 484         * source-cache.c: #undef open and close, to avoid unresolved
 485         externals during linking.
 486
 487 2019-03-12  Tom Tromey  <tromey@adacore.com>
 488
 489         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 490         const.  Add initializers.
 491         (_initialize_remote): Don't initialize ptid globals.
 492
 493 2019-03-12  Pedro Alves  <palves@redhat.com>
 494
 495         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 496
 497 2019-03-12  Pedro Alves  <palves@redhat.com>
 498
 499         * cp-name-parser.y (main): Remove unused 'len' variable.
 500
 501 2019-03-12  Tom Tromey  <tromey@adacore.com>
 502
 503         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 504         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 505
 506 2019-03-12  Tom Tromey  <tromey@adacore.com>
 507
 508         * linux-nat.c (iterate_over_lwps): Update.
 509         (stop_callback): Remove parameter.
 510         (stop_wait_callback, detach_callback, resume_set_callback)
 511         (select_singlestep_lwp_callback, set_ignore_sigint)
 512         (status_callback, resumed_callback, resume_clear_callback)
 513         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 514         data parameter.
 515         (linux_nat_target::detach, linux_nat_target::resume)
 516         (linux_stop_and_wait_all_lwps, select_event_lwp)
 517         (linux_nat_filter_event, linux_nat_wait_1)
 518         (linux_nat_target::kill, linux_nat_target::stop)
 519         (linux_nat_target::stop): Update.
 520         (linux_nat_resume_callback): Change type.
 521         (resume_stopped_resumed_lwps, count_events_callback)
 522         (select_event_lwp_callback): Likewise.
 523         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 524         * arm-linux-nat.c (struct update_registers_data): Remove.
 525         (update_registers_callback): Change type.
 526         (arm_linux_insert_hw_breakpoint1): Update.
 527         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 528         parameter.
 529         (x86_linux_dr_set_addr): Update.
 530         (x86_linux_dr_set_control): Update.
 531         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 532         (iterate_over_lwps): Use gdb::function_view.
 533         * nat/aarch64-linux-hw-point.c (struct
 534         aarch64_dr_update_callback_param): Remove.
 535         (debug_reg_change_callback): Change type.
 536         (aarch64_notify_debug_reg_change): Update.
 537         * s390-linux-nat.c (s390_refresh_per_info): Update.
 538
 539 2019-03-11  Tom Tromey  <tromey@adacore.com>
 540
 541         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 542         redundant assignment to "this_cu".
 543
 544 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 545
 546         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 547
 548 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 549
 550         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 551         from...
 552         (rank_one_type): ... this.
 553
 554 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 555
 556         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 557         from...
 558         (rank_one_type): ... this.
 559
 560 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 561
 562         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 563         from...
 564         (rank_one_type): ... this.
 565
 566 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 567
 568         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 569         from...
 570         (rank_one_type): ... this.
 571
 572 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 573
 574         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
 575         from...
 576         (rank_one_type): ... this.
 577
 578 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 579
 580         * gdbtypes.c (rank_one_type_parm_range): New function extracted
 581         from...
 582         (rank_one_type): ... this.
 583
 584 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 585
 586         * gdbtypes.c (rank_one_type_parm_char): New function extracted
 587         from...
 588         (rank_one_type): ... this.
 589
 590 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 591
 592         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
 593         from...
 594         (rank_one_type): ... this.
 595
 596 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 597
 598         * gdbtypes.c (rank_one_type_parm_int): New function extracted
 599         from...
 600         (rank_one_type): ... this.
 601
 602 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 603
 604         * gdbtypes.c (rank_one_type_parm_func): New function extracted
 605         from...
 606         (rank_one_type): ... this.
 607
 608 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 609
 610         * gdbtypes.c (rank_one_type_parm_array): New function extracted
 611         from...
 612         (rank_one_type): ... this.
 613
 614 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 615
 616         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
 617         from...
 618         (rank_one_type): ... this.
 619
 620 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 621
 622         * inferior.c (initialize_inferiors): Ensure 'help set/show print
 623         inferior-events' shows the example events.
 624
 625 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 626
 627         Support styling on native MS-Windows console
 628
 629         PR/24315
 630         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 631         on MS-Windows if $TERM is not defined.
 632
 633         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 634
 635         * posix-hdep.c (gdb_console_fputs):
 636         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 637         functions.
 638         * ui-file.h (gdb_console_fputs): Add prototype.
 639
 640         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 641         back to fputs only if the former returns zero.
 642
 643 2019-03-07  Tom Tromey  <tom@tromey.com>
 644
 645         * symmisc.c (print_symbol_bcache_statistics): Update.
 646         (print_objfile_statistics): Update.
 647         * symfile.c (allocate_symtab): Update.
 648         * stabsread.c: Don't include bcache.h.
 649         * psymtab.h (struct psymbol_bcache): Don't declare.
 650         (class psymtab_storage) <psymbol_cache>: Now a bcache.
 651         (psymbol_bcache_init, psymbol_bcache_free)
 652         (psymbol_bcache_get_bcache): Don't declare.
 653         * psymtab.c (struct psymbol_bcache): Remove.
 654         (psymtab_storage::psymtab_storage): Update.
 655         (psymtab_storage::~psymtab_storage): Update.
 656         (psymbol_bcache_init, psymbol_bcache_free)
 657         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
 658         (add_psymbol_to_bcache): Update.
 659         (allocate_psymtab): Update.
 660         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
 661         macro_cache>: No longer pointers.
 662         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
 663         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
 664         * macrotab.c (macro_bcache): Update.
 665         * macroexp.c: Don't include bcache.h.
 666         * gdbtypes.c (check_types_worklist): Update.
 667         (types_deeply_equal): Remove TRY/CATCH.  Update.
 668         * elfread.c (elf_symtab_read): Update.
 669         * dwarf2read.c: Don't include bcache.h.
 670         * buildsym.c (buildsym_compunit::get_macro_table): Update.
 671         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
 672         (print_bcache_statistics, bcache_memory_used): Don't declare.
 673         (struct bcache): Move from bcache.c.  Add constructor, destructor,
 674         methods.  Rename all data members.
 675         * bcache.c (struct bcache): Move to bcache.h.
 676         (bcache::expand_hash_table): Rename from expand_hash_table.
 677         (bcache): Remove.
 678         (bcache::insert): Rename from bcache_full.
 679         (bcache::compare): Rename from bcache_compare.
 680         (bcache_xmalloc): Remove.
 681         (bcache::~bcache): Rename from bcache_xfree.
 682         (bcache::print_statistics): Rename from print_bcache_statistics.
 683         (bcache::memory_used): Rename from bcache_memory_used.
 684
 685 2019-03-07  Pedro Alves  <palves@redhat.com>
 686
 687         * infrun.c (normal_stop): Also check for
 688         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
 689
 690 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 691
 692         * f-lang.c (value_from_host_double): Moved to...
 693         * value.c (value_from_host_double): ...here.
 694         * value.h (value_from_host_double): Declare.
 695         * guile/scm-math.c (vlscm_convert_typed_number): Use
 696         value_from_host_double.
 697         (vlscm_convert_number): Likewise.
 698         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
 699         * python/py-value.c (convert_value_from_python): Likewise.
 700
 701 2019-03-06  Tom Tromey  <tom@tromey.com>
 702
 703         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
 704
 705 2019-03-06  Tom Tromey  <tom@tromey.com>
 706
 707         * utils.h (free_current_contents): Don't declare.
 708         * utils.c (free_current_contents): Remove.
 709
 710 2019-03-06  Tom Tromey  <tom@tromey.com>
 711
 712         * top.c (quit_force): Update.
 713         * main.c (captured_command_loop): Update.
 714         * common/new-op.c (operator new): Update.
 715         * common/common-exceptions.c (struct catcher)
 716         <save_cleanup_chain>: Remove member.
 717         (exceptions_state_mc_init): Update.
 718         (exception_try_scope_entry): Return nullptr.
 719         (exception_try_scope_exit, exception_rethrow)
 720         (throw_exception_sjlj, throw_exception_cxx): Update.
 721         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
 722         (all_cleanups, do_cleanups, discard_cleanups)
 723         (discard_final_cleanups, save_cleanups, save_final_cleanups)
 724         (restore_cleanups, restore_final_cleanups): Don't declare.
 725         (do_final_cleanups): Remove parameter.
 726         * common/cleanups.c (cleanup_chain, make_cleanup)
 727         (make_cleanup_dtor, all_cleanups, do_cleanups)
 728         (discard_my_cleanups, discard_cleanups)
 729         (discard_final_cleanups, save_my_cleanups, save_cleanups)
 730         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
 731         (null_cleanup): Remove.
 732         (do_final_cleanups): Remove parameter.
 733
 734 2019-03-06  Tom Tromey  <tom@tromey.com>
 735
 736         * remote.c (remote_target::remote_parse_stop_reply): Use
 737         unique_xmalloc_ptr.
 738
 739 2019-03-06  Tom Tromey  <tom@tromey.com>
 740
 741         * stabsread.c (struct stabs_field_info): Rename from field_info.
 742         <list, fnlist>: Add initializers.
 743         <obstack>: New member.
 744         (read_member_functions, read_struct_fields, read_baseclasses):
 745         Allocate on obstack.  Don't use cleanups.
 746         (read_one_struct_field, read_member_functions, read_struct_fields)
 747         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
 748         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
 749         (read_struct_type): Update.
 750
 751 2019-03-06  Tom Tromey  <tom@tromey.com>
 752
 753         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
 754         * common/filestuff.h (make_cleanup_close): Don't declare.
 755         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
 756         Remove.
 757
 758 2019-03-06  Tom Tromey  <tom@tromey.com>
 759
 760         * solib-aix.c: Use make_scope_exit.
 761
 762 2019-03-06  Tom Tromey  <tom@tromey.com>
 763
 764         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
 765         Use make_scope_exit.
 766
 767 2019-03-06  Tom Tromey  <tom@tromey.com>
 768
 769         * solib-svr4.c (disable_probes_interface): Remove parameter.
 770         (svr4_handle_solib_event): Use make_scope_exit.
 771
 772 2019-03-06  Tom Tromey  <tom@tromey.com>
 773
 774         * remote.c (struct stop_reply_deleter): Remove.
 775         (stop_reply_up): Update.
 776         (struct stop_reply): Derive from notif_event.  Don't typedef.
 777         <regcache>: Now a std::vector.
 778         (stop_reply_xfree): Remove.
 779         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
 780         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
 781         (remote_target::discard_pending_stop_replies): Use delete.
 782         (remote_target::remote_parse_stop_reply): Update.
 783         (remote_target::process_stop_reply): Update.
 784         * remote-notif.h (struct notif_event): Add virtual destructor.
 785         Remove "dtr" member.
 786         (struct notif_client) <alloc_event>: Return a unique_ptr.
 787         (notif_event_xfree): Don't declare.
 788         (notif_event_up): New typedef.
 789         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
 790         (notif_event_xfree, do_notif_event_xfree): Remove.
 791         (remote_notif_state_xfree): Update.
 792
 793 2019-03-06  Tom Tromey  <tom@tromey.com>
 794
 795         * infrun.c (displaced_step_clear_cleanup): Now a
 796         forward_scope_exit type.
 797         (displaced_step_prepare_throw): Update.
 798         (displaced_step_fixup): Update.
 799
 800 2019-03-06  Tom Tromey  <tom@tromey.com>
 801
 802         * inferior.h (class inferior): Update comment.
 803         * gdbthread.h (class thread_info): Update comment.
 804
 805 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
 806             Tom Tromey  <tom@tromey.com>
 807
 808         * stabsread.h (struct stab_section_list): Remove.
 809         (coffstab_build_psymtabs): Update.
 810         * dbxread.c (symbuf_sections): Now a std::vector.
 811         (sect_idx): New global.
 812         (fill_symbuf): Update.
 813         (coffstab_build_psymtabs): Change type of stabsects parameter.
 814         Update.
 815         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
 816         std::vector.
 817         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
 818         (coff_locate_sections): Update.
 819         (coff_symfile_read): Remove cleanups.  Update.
 820         (init_stringtab): Add storage parameter.
 821         (free_stringtab, free_stringtab_cleanup): Remove.
 822         (init_lineno): Add storage parameter.
 823         (free_linetab, free_linetab_cleanup): Remove.
 824
 825 2019-03-06  Pedro Alves  <palves@redhat.com>
 826
 827         * linux-fork.c (fork_info::clobber_regs): Delete.
 828         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
 829         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
 830         comment.  Adjust.
 831         (scoped_switch_fork_info::scoped_switch_fork_info)
 832         (checkpoint_command, linux_fork_context): Adjust
 833         fork_save_infrun_state calls.
 834
 835 2019-03-06  Pedro Alves  <palves@redhat.com>
 836
 837         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
 838         (inf_has_multiple_threads): Return 'bool' and rewrite using
 839         inferior_info::threads().
 840
 841 2019-03-06  Pedro Alves  <palves@redhat.com>
 842
 843         * linux-fork.c: Include <list>.
 844         (fork_list): Now a std::list instance.
 845         (fork_info): Add ctor, dtor, and in-class initialize all fields.
 846         (forks_exist_p, find_last_fork): Adjust.
 847         (new_fork): Delete.
 848         (one_fork_p): New.
 849         (add_fork): Adjust.
 850         (free_fork): Delete, folded into fork_info::~fork_info().
 851         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
 852         Adjust.
 853         (init_fork_list): Delete.
 854         (linux_fork_killall, linux_fork_mourn_inferior)
 855         (linux_fork_detach, info_checkpoints_command): Adjust.
 856         (_initialize_linux_fork): No longer call init_fork_list.
 857
 858 2019-03-06  Pedro Alves  <palves@redhat.com>
 859
 860         * linux-fork.c (new_fork): New, split out of ...
 861         (add_fork): ... this.  Return void.  Move "first fork" special
 862         case from here, to ...
 863         (checkpoint_command): ... here.
 864         * linux-linux.h (add_fork): Return void.
 865
 866 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 867
 868         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
 869
 870 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 871             Chris January  <chris.january@arm.com>
 872             David Lecomber  <david.lecomber@arm.com>
 873
 874         * f-exp.y: New token, UNOP_INTRINSIC.
 875         (exp): New pattern using UNOP_INTRINSIC token.
 876         (f77_keywords): Add 'abs' keyword.
 877         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
 878         (value_from_host_double): New function.
 879         (evaluate_subexp_f): Support UNOP_ABS.
 880
 881 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 882
 883         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
 884         types.
 885
 886 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 887
 888         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
 889         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
 890         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
 891
 892 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 893
 894         * f-exp.y (convert_to_kind_type): Handle more type kinds.
 895
 896 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 897             Chris January  <chris.january@arm.com>
 898
 899         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
 900         * f-exp.y: Define 'KIND' token.
 901         (exp): New pattern for KIND expressions.
 902         (ptype): Handle types with a kind extension.
 903         (direct_abs_decl): Extend to spot kind extensions.
 904         (f77_keywords): Add 'kind' to the list.
 905         (push_kind_type): New function.
 906         (convert_to_kind_type): New function.
 907         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
 908         * parse.c (operator_length_standard): Likewise.
 909         * parser-defs.h (enum type_pieces): Add tp_kind.
 910         * std-operator.def: Add UNOP_KIND.
 911
 912 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 913
 914         * f-exp.y (f_parse): Set yydebug.
 915
 916 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 917
 918         * f-lang.c (evaluate_subexp_f): New function.
 919         (exp_descriptor_f): New global.
 920         (f_language_defn): Use exp_descriptor_f instead of
 921         exp_descriptor_standard.
 922
 923 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 924
 925         * f-exp.y (struct token): Add comments.
 926         (dot_ops): Remove uppercase versions and the end marker.
 927         (f77_keywords): Likewise.
 928         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
 929         entries in the dot_ops array are case insensitive, and use
 930         strncasecmp to compare strings.  Also some whitespace cleanup in
 931         this area.  Similar for the f77_keywords array, except entries in
 932         this list might be case sensitive.
 933
 934 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 935
 936         * f-exp.y (struct f77_boolean_val): Add comments.
 937         (boolean_values): Remove uppercase versions, and end marker.
 938         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
 939         and use strncasecmp to achieve case insensitivity.  Additionally,
 940         perform whitespace cleanup around this code.
 941
 942 2019-03-06  Tom Tromey  <tromey@adacore.com>
 943
 944         * remote-sim.c (gdbsim_target_open): Use result of
 945         gdb_argv::release.
 946
 947 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
 948         Dirk Schubert  <dirk.schubert@arm.com>
 949         Chris January  <chris.january@arm.com>
 950
 951         * eval.c (evaluate_subexp_standard): Call Fortran argument
 952         wrapping logic.
 953         * f-lang.c (struct value): A value which can be passed into a
 954         Fortran function call.
 955         (fortran_argument_convert): Wrap Fortran arguments in a pointer
 956         where appropriate.
 957         (struct type): Value ready for a Fortran function call.
 958         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
 959         is needed.
 960         * f-lang.h (fortran_argument_convert): Declaration.
 961         (fortran_preserve_arg_pointer): Declaration.
 962         * infcall.c (value_arg_coerce): Call Fortran argument logic.
 963
 964 2019-03-05  Tom Tromey  <tromey@adacore.com>
 965
 966         * python/py-prettyprint.c (print_string_repr): Remove #if.
 967         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
 968
 969 2019-03-05  Tom Tromey  <tromey@adacore.com>
 970
 971         * target.c (the_dummy_target): Move later.  Change type to
 972         "dummy_target".
 973         (initialize_targets): Don't initialize the_dummy_target.
 974
 975 2019-03-05  Tom Tromey  <tromey@adacore.com>
 976
 977         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
 978         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
 979
 980 2019-03-05  Tom Tromey  <tromey@adacore.com>
 981
 982         * windows-nat.c (windows_nat_target::attach)
 983         (windows_nat_target::detach): Don't call gdb_flush.
 984         * valprint.c (generic_val_print, val_print, val_print_string):
 985         Don't call gdb_flush.
 986         * utils.c (defaulted_query): Don't call gdb_flush.
 987         * typeprint.c (print_type_scalar): Don't call gdb_flush.
 988         * target.c (target_announce_detach): Don't call gdb_flush.
 989         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
 990         * remote.c (extended_remote_target::attach): Don't call
 991         gdb_flush.
 992         * procfs.c (procfs_target::detach): Don't call gdb_flush.
 993         * printcmd.c (do_examine): Don't call gdb_flush.
 994         (info_display_command): Don't call gdb_flush.
 995         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
 996         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
 997         * memattr.c (info_mem_command): Don't call gdb_flush.
 998         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
 999         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
1000         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
1001         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
1002         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
1003         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
1004         (gnu_nat_target::detach): Don't call gdb_flush.
1005         * f-valprint.c (f_val_print): Don't call gdb_flush.
1006         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
1007         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
1008         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
1009         gdb_flush.
1010         * c-valprint.c (c_val_print): Don't call gdb_flush.
1011         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
1012
1013 2019-03-05  Tom Tromey  <tromey@adacore.com>
1014
1015         * varobj.c (update_dynamic_varobj_children): Update.
1016         (install_default_visualizer): Use reset, not release.
1017         * value.c (set_internalvar): Update.
1018         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
1019         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
1020         ATTRIBUTE_UNUSED_RESULT.
1021
1022 2019-03-05  Tom Tromey  <tromey@adacore.com>
1023
1024         * remote.c (class scoped_remote_fd) <release>: Add
1025         ATTRIBUTE_UNUSED_RESULT.
1026
1027 2019-03-05  Tom Tromey  <tromey@adacore.com>
1028
1029         * macroexp.c (struct macro_buffer) <release>: Add
1030         ATTRIBUTE_UNUSED_RESULT.
1031
1032 2019-03-05  Tom Tromey  <tromey@adacore.com>
1033
1034         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
1035         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
1036         ATTRIBUTE_UNUSED_RESULT.
1037
1038 2019-03-05  Tom Tromey  <tromey@adacore.com>
1039
1040         * common/scoped_fd.h (class scoped_fd) <release>: Add
1041         ATTRIBUTE_UNUSED_RESULT.
1042
1043 2019-03-05  Tom Tromey  <tromey@adacore.com>
1044
1045         * parser-defs.h (struct parser_state) <release>: Add
1046         ATTRIBUTE_UNUSED_RESULT.
1047
1048 2019-03-05  Tom Tromey  <tromey@adacore.com>
1049
1050         * utils.h (class gdb_argv) <release>: Add
1051         ATTRIBUTE_UNUSED_RESULT.
1052         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1053
1054 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1055
1056         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1057         for-loop range, to avoid compiler warnings.
1058
1059         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1060         avoid compiler warnings about unused variables.
1061
1062         * NEWS: Mention end of support for native debugging on MS-Windows
1063         before XP.
1064
1065         PR gdb/24292
1066         * common/netstuff.c:
1067         * gdbserver/gdbreplay.c
1068         * gdbserver/remote-utils.c:
1069         * ser-tcp.c:
1070         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1071         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1072         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1073         'getaddrinfo' and 'freeaddrinfo' were not available before
1074         Windows XP, and mingw.org's MinGW headers by default define
1075         _WIN32_WINNT to 0x500.
1076
1077 2019-03-01  Gary Benson <gbenson@redhat.com>
1078
1079         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1080
1081 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1082             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1083
1084         PR gdb/8527
1085         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1086         set_sigint_trap, clear_sigint_trap.
1087
1088 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1089
1090         * target.c (target_detach): Clear the regcache and the
1091         frame cache.
1092
1093 2019-02-27  Pedro Alves  <palves@redhat.com>
1094
1095         * utils.c (set_screen_size): When we cap the height/width sizes,
1096         tweak the corresponding command variable to show "unlimited":
1097
1098 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1099             Pedro Alves  <palves@redhat.com>
1100
1101         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1102         before calling rl_set_screen_size.
1103
1104 2019-02-27  Tom Tromey  <tromey@adacore.com>
1105
1106         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1107         define.
1108         * python/py-value.c: Remove Python 2.4 workaround.
1109         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1110         workaround.
1111         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1112         Python 2.4 workaround.
1113         * python/python-internal.h: Remove Python 2.4 comment.
1114         (Py_ssize_t): Don't define.
1115         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1116         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1117         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1118         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1119         * python/python.c (do_start_initialization): Remove Python 2.4
1120         workaround.
1121         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1122         (print_children): Remove Python 2.4 workaround.
1123         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1124         workaround.
1125         (CHARBUFFERPROC_NAME): Remove.
1126         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1127         Python 2.4 workaround.
1128
1129 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1130
1131         * NEWS: Note minimum Python version.
1132
1133 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1134
1135         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1136         code from these functions.  Remove corresponding ifdefs.  Use
1137         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1138         Remove gotos and target of gotos.
1139         (infpy_search_memory): Likewise.
1140
1141 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1142
1143         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1144         (hppa_gdbarch_init): Don't register deleted functions with
1145         gdbarch.
1146
1147 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1148
1149         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1150         (h8300_unwind_sp): Delete.
1151         (h8300_dummy_id): Delete.
1152         (h8300_gdbarch_init): Don't register deleted functions with
1153         gdbarch.
1154
1155 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1156
1157         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1158         (ft32_unwind_pc): Delete.
1159         (ft32_unwind_sp): Delete.
1160         (ft32_gdbarch_init): Don't register deleted functions with
1161         gdbarch.
1162
1163 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1164
1165         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1166         (frv_unwind_pc): Delete.
1167         (frv_unwind_sp): Delete.
1168         (frv_gdbarch_init): Don't register deleted functions with
1169         gdbarch.
1170
1171 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1172
1173         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1174         (riscv_unwind_pc): Delete.
1175         (riscv_unwind_sp): Delete.
1176         (riscv_gdbarch_init): Don't register deleted functions with
1177         gdbarch.
1178
1179 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1180
1181         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1182         (csky_unwind_pc): Delete.
1183         (csky_unwind_sp): Delete.
1184         (csky_gdbarch_init): Don't register deleted functions with
1185         gdbarch.
1186
1187 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1188
1189         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1190         (cris_unwind_pc): Delete.
1191         (cris_unwind_sp): Delete.
1192         (cris_gdbarch_init): Don't register deleted functions with
1193         gdbarch.
1194
1195 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1196
1197         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1198         (bfin_unwind_pc): Delete.
1199         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1200
1201 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1202
1203         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1204         (arm_unwind_pc): Delete.
1205         (arm_unwind_sp): Delete.
1206         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1207
1208 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1209
1210         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1211         (arc_unwind_pc): Delete.
1212         (arc_unwind_sp): Delete.
1213         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1214
1215 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1216
1217         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1218         (alpha_unwind_pc): Delete.
1219         (alpha_gdbarch_init): Don't register deleted functions with
1220         gdbarch.
1221
1222 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1223
1224         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1225         (aarch64_unwind_pc): Delete.
1226         (aarch64_unwind_sp): Delete.
1227         (aarch64_gdbarch_init): Don't register deleted functions with
1228         gdbarch.
1229
1230 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1231
1232         * gdbtypes.c (type_align): Don't consider static members when
1233         computing structure alignment.
1234
1235 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1236
1237         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1238         return 0 for other types.
1239         * arch-utils.c (default_type_align): Always return 0.
1240         * gdbarch.h: Regenerate.
1241         * gdbarch.sh (type_align): Extend comment.
1242         * gdbtypes.c (type_align): Add additional comments, always call
1243         gdbarch_type_align before applying the default rules.
1244         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1245         generic code will then apply a suitable default.
1246         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1247         types, return 0 for other types.
1248
1249 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1250
1251         * NEWS: Create a new section for the next release branch.
1252         Rename the section of the current branch, now that it has
1253         been cut.
1254
1255 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1256
1257         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1258         * version.in: Bump version to 8.3.50.DATE-git.
1259
1260 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1261
1262         * aix-thread.c (ptid_cmp): Remove unused variable.
1263         (get_signaled_thread): Likewise.
1264         (store_regs_user_thread): Likewise.
1265         (store_regs_kernel_thread): Likewise.
1266         (fetch_regs_kernel_thread): Remove shadowed variable.
1267
1268 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1269
1270         * features/riscv/32bit-cpu.xml: Add register numbers.
1271         * features/riscv/32bit-fpu.c: Regenerate.
1272         * features/riscv/32bit-fpu.xml: Add register numbers.
1273         * features/riscv/64bit-cpu.xml: Add register numbers.
1274         * features/riscv/64bit-fpu.c: Regenerate.
1275         * features/riscv/64bit-fpu.xml: Add register numbers.
1276
1277 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1278
1279         * NEWS: Mention two argument form of gdb.Value constructor.
1280         * python/py-value.c (convert_buffer_and_type_to_value): New
1281         function.
1282         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1283         Add support for handling an optional second argument.  Call
1284         convert_buffer_and_type_to_value as appropriate.
1285         * python/python-internal.h (Py_buffer_deleter): New struct.
1286         (Py_buffer_up): New typedef.
1287
1288 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1289
1290         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1291         instead of releasing ownership.
1292
1293 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1294
1295         * dwarf2read.c (open_and_init_dwp_file): Call
1296         elf_numsections instead of bfd_count_sections to initialize
1297         dwp_file->num_sections.
1298
1299 2019-02-25  Tom Tromey  <tromey@adacore.com>
1300
1301         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1302
1303 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1304
1305         * gcore.in: Add '--readnever' option when invoking GDB.
1306
1307 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1308
1309         * MAINTAINERS: Update my email address.
1310
1311 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1312
1313         * build-id.c (build_id_to_debug_bfd_1): New function.
1314         (build_id_to_debug_bfd): Look for separate debug file in
1315         sysroot.
1316
1317 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1318
1319         * gdbarch.sh: Update the copyright year range that is placed into
1320         generated files.
1321
1322 2019-02-22  Keith Seitz  <keiths@redhat.com>
1323
1324         PR symtab/23853
1325         * linespec.c (create_sals_line_offset): Search for the default
1326         symtab's filename instead of its fullname.
1327
1328 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1329
1330         * NEWS: Update style defaults.
1331
1332 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1333
1334         * main.c (captured_main_1): Disable styling in batch mode.
1335
1336 2019-02-20  Tom Tromey  <tom@tromey.com>
1337
1338         * symtab.c (symtab_symbol_info): Fix typos.
1339
1340 2019-02-20  Tom Tromey  <tromey@adacore.com>
1341
1342         * findcmd.c (_initialize_mem_search): Use upper case for
1343         metasyntactic variables.
1344
1345 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1346
1347         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1348         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1349
1350 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1351
1352         * top.h (source_file_name): Change to std::string.
1353         * top.c (source_file_name): Likewise.
1354         (command_line_input): Adjust.
1355         * cli/cli-script.c (script_from_file): Adjust.
1356
1357 2019-02-19  Tom Tromey  <tromey@adacore.com>
1358
1359         * ravenscar-thread.c
1360         (ravenscar_thread_target::update_thread_list): Don't call
1361         ada_build_task_list.
1362         * ada-lang.h (ada_build_task_list): Don't declare.
1363         * ada-tasks.c (struct ada_tasks_inferior_data)
1364         <task_list_valid_p>: Now bool.
1365         (read_known_tasks, ada_task_list_changed)
1366         (ada_tasks_invalidate_inferior_data): Update.
1367         (read_known_tasks_array): Return bool.
1368         (read_known_tasks_list): Likewise.
1369         (read_known_tasks): Return void.
1370         (ada_build_task_list): Now static.
1371
1372 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1373
1374         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1375         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1376
1377 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1378
1379         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1380         variant for ada_tasks_pspace_data_handle and
1381         ada_tasks_inferior_data_handle.
1382         (ada_tasks_pspace_data_cleanup): New function.
1383         (ada_tasks_inferior_data_cleanup): New function.
1384
1385 2019-02-17  Tom Tromey  <tom@tromey.com>
1386
1387         * macrotab.h (macro_source_fullname): Return a std::string.
1388         * macrotab.c (macro_include, check_for_redefinition)
1389         (macro_undef, macro_lookup_definition, foreach_macro)
1390         (foreach_macro_in_scope): Update.
1391         (macro_source_fullname): Return a std::string.
1392         * macrocmd.c (show_pp_source_pos): Update.
1393
1394 2019-02-17  Tom Tromey  <tom@tromey.com>
1395
1396         * macrocmd.c (show_pp_source_pos): Style the file names.
1397
1398 2019-02-17  Tom Tromey  <tom@tromey.com>
1399
1400         PR tui/24197:
1401         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1402
1403 2019-02-17  Tom Tromey  <tom@tromey.com>
1404
1405         * ada-lang.c (user_select_syms): Use filtered printing.
1406         * utils.c (wrap_style): New global.
1407         (desired_style): Remove.
1408         (emit_style_escape): Add stream parameter.
1409         (set_output_style, reset_terminal_style, prompt_for_continue):
1410         Update.
1411         (flush_wrap_buffer): Only flush gdb_stdout.
1412         (wrap_here): Set wrap_style.
1413         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1414         treat escape sequences as a character.  Change when wrap buffer is
1415         flushed.
1416         (fputs_styled): Do not set the output style when the default is
1417         requested.
1418         * ui-style.h (struct ui_file_style) <is_default>: New method.
1419         * source.c (print_source_lines_base): Emit escape sequences in one
1420         piece.
1421
1422 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1423
1424         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1425         integers and enumeration types.
1426
1427 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1428
1429         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1430         instead of lookup_symbol_in_language
1431         (do_exact_match): New function.
1432         (ada_get_symbol_name_matcher): Return do_exact_match when
1433         doing a verbatim match.
1434
1435 2019-02-15  Tom Tromey  <tromey@adacore.com>
1436
1437         * ravenscar-thread.c (ravenscar_thread_target::resume)
1438         (ravenscar_thread_target::wait): Special case wildcard requests.
1439
1440 2019-02-15  Tom Tromey  <tromey@adacore.com>
1441
1442         * ravenscar-thread.c (base_ptid): Remove.
1443         (struct ravenscar_thread_target) <close>: New method.
1444         <m_base_ptid>: New member.
1445         <update_inferior_ptid, active_task, task_is_currently_active,
1446         runtime_initialized>: Declare methods.
1447         <ravenscar_thread_target>: Add constructor.
1448         (ravenscar_thread_target::task_is_currently_active)
1449         (ravenscar_thread_target::update_inferior_ptid)
1450         (ravenscar_runtime_initialized): Rename.  Now methods.
1451         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1452         (ravenscar_thread_target::update_thread_list): Update.
1453         (ravenscar_thread_target::active_task): Now method.
1454         (ravenscar_thread_target::store_registers)
1455         (ravenscar_thread_target::prepare_to_store)
1456         (ravenscar_thread_target::prepare_to_store)
1457         (ravenscar_thread_target::mourn_inferior): Update.
1458         (ravenscar_inferior_created): Use "new" to create target.
1459         (ravenscar_thread_target::get_ada_task_ptid): Update.
1460         (_initialize_ravenscar): Don't initialize base_ptid.
1461         (ravenscar_ops): Remove global.
1462
1463 2019-02-15  Tom Tromey  <tromey@adacore.com>
1464
1465         * target.h (push_target): Declare new overload.
1466         * target.c (push_target): New overload, taking an rvalue reference.
1467         * remote.c (remote_target::open_1): Use push_target overload.
1468         * corelow.c (core_target_open): Use push_target overload.
1469
1470 2019-02-15  Tom Tromey  <tromey@adacore.com>
1471
1472         * ravenscar-thread.c (is_ravenscar_task)
1473         (ravenscar_task_is_currently_active): Return bool.
1474         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1475         (_initialize_ravenscar): Remove "(void)".
1476         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1477         Return bool.
1478
1479 2019-02-15  Tom Tromey  <tromey@adacore.com>
1480
1481         * ravenscar-thread.c (ravenscar_runtime_initializer)
1482         (has_ravenscar_runtime, get_running_thread_id)
1483         (ravenscar_thread_target::resume): Fix indentation.
1484
1485 2019-02-15  Tom Tromey  <tromey@adacore.com>
1486
1487         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1488         from ravenscar_arch_ops.
1489         (sparc_ravenscar_ops::fetch_registers)
1490         (sparc_ravenscar_ops::store_registers): Now methods.
1491         (sparc_ravenscar_prepare_to_store): Remove.
1492         (sparc_ravenscar_ops): Redefine.
1493         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1494         methods and destructor.  Remove members.
1495         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1496         (ravenscar_thread_target::store_registers)
1497         (ravenscar_thread_target::prepare_to_store): Update.
1498         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1499         Remove.
1500         (struct ppc_ravenscar_powerpc_ops): Derive from
1501         ravenscar_arch_ops.
1502         (ppc_ravenscar_powerpc_ops::fetch_registers)
1503         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1504         (ppc_ravenscar_powerpc_ops): Redefine.
1505         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1506         (ppc_ravenscar_e500_ops::fetch_registers)
1507         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1508         (ppc_ravenscar_e500_ops): Redefine.
1509         * aarch64-ravenscar-thread.c
1510         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1511         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1512         (aarch64_ravenscar_fetch_registers)
1513         (aarch64_ravenscar_store_registers): Now methods.
1514         (aarch64_ravenscar_ops): Redefine.
1515
1516 2019-02-15  Tom Tromey  <tromey@adacore.com>
1517
1518         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1519         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1520         (ravenscar_thread_target::stopped_by_watchpoint)
1521         (ravenscar_thread_target::stopped_data_address)
1522         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1523
1524 2019-02-15  Tom Tromey  <tromey@adacore.com>
1525
1526         * ravenscar-thread.c: Fix some typos.
1527
1528 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1529             Tom Tromey  <tromey@adacore.com>
1530
1531         * ada-lang.c (ada_exception_sal): Change addr_string to a
1532         std::string.
1533         (create_ada_exception_catchpoint): Update.
1534
1535 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1536             Tom Tromey  <tromey@adacore.com>
1537
1538         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1539         (bp_location_ops): Remove.
1540         (base_breakpoint_allocate_location): Update.
1541         (free_bp_location): Update.
1542         * ada-lang.c (class ada_catchpoint_location)
1543         <ada_catchpoint_location>: Remove ops parameter.
1544         (ada_catchpoint_location_dtor): Remove.
1545         (ada_catchpoint_location_ops): Remove.
1546         (allocate_location_exception): Update.
1547         * breakpoint.h (struct bp_location_ops): Remove.
1548         (class bp_location) <bp_location>: Remove bp_location_ops
1549         parameter.
1550         <~bp_location>: Add destructor.
1551         <ops>: Remove.
1552
1553 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1554             Pedro Alves  <palves@redhat.com>
1555
1556         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1557         'PATH_MAX'.
1558
1559 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1560             Samuel Thibault  <samuel.thibault@gnu.org>
1561             Thomas Schwinge  <thomas@codesourcery.com>
1562
1563         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1564         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1565
1566 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1567
1568         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1569         (check_empty): Use "const char *".
1570
1571         * gnu-nat.c (gnu_nat_target::detach): Instead of
1572         'detach_inferior (pid)' call
1573         'detach_inferior (find_inferior_pid (pid))'.
1574
1575         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1576         'nat/fork-inferior.o'.
1577         * gnu-nat.c: #include "nat/fork-inferior.h".
1578
1579         * gnu-nat.c (gnu_nat_target::detach): Instead of
1580         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1581         * gnu-nat.h: #include "inf-child.h".
1582         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1583         'i386_gnu_nat_target::fetch_registers'.
1584         (gnu_store_registers): Rename/move to
1585         'i386_gnu_nat_target::store_registers'.
1586
1587         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1588         * gnu-nat.h (mach_thread_info): New function.
1589         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1590
1591         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1592
1593 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1594
1595         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1596
1597 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1598
1599         * windows-nat.c (windows_add_thread): Add new parameter
1600         "main_thread_p" with default value set to false.  Update
1601         function documentation as well as all callers.
1602         (windows_delete_thread): Likewise.
1603         (fake_create_process): Update call to windows_add_thread.
1604         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1605         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1606         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1607         call to windows_delete_thread.
1608
1609 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1610
1611         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1612
1613 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1614
1615         * symfile.c (find_separate_debug_file): Use canonical path of
1616         sysroot with child_path instead of gdb_sysroot if it is valid.
1617
1618 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1619
1620         * symfile.c (find_separate_debug_file): Use child_path to
1621         determine if an object file is under a sysroot.
1622
1623 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1624
1625         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1626         unittests/child-path-selftests.c.
1627         * common/pathstuff.c (child_path): New function.
1628         * common/pathstuff.h (child_path): New prototype.
1629         * unittests/child-path-selftests.c: New file.
1630
1631 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1632
1633         * symfile.c (find_separate_debug_file): Look for separate debug
1634         files in debug directories under the sysroot.
1635
1636 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1637
1638         * symtab.h (struct minimal_symbol data_p): New const method.
1639         (struct minimal_symbol text_p): Likewise.
1640         * symtab.c (output_source_filename): Use file name style
1641         to print file name.
1642         (print_symbol_info): Likewise.
1643         (print_msymbol_info): Use address style to print addresses.
1644         Use function name style to print executable text symbols.
1645         (expand_symtab_containing_pc): Use data_p.
1646         (find_pc_sect_compunit_symtab): Likewise.
1647
1648 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1649
1650         * breakpoint.c (describe_other_breakpoints): Use address style
1651         to print addresses.
1652         (say_where): Likewise.
1653
1654 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1655
1656         * ada-typeprint.c (print_func_type): Print function name
1657         style to print function name.
1658         * c-typeprint.c (c_print_type_1): Likewise.
1659
1660 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
1661
1662         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
1663         for execve.
1664
1665 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1666
1667         * c-exp.y (direct_abs_decl): Use emplace_back to record the
1668         type_stack.
1669
1670 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
1671
1672         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
1673         TYPE_CODE_REF types.
1674
1675 2019-02-08  Jim Wilson  <jimw@sifive.com>
1676
1677         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
1678         (riscv_linux_fregset): New.
1679         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
1680
1681 2019-02-07  Tom Tromey  <tom@tromey.com>
1682
1683         * thread.c (thread_cancel_execution_command): Update.
1684         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
1685         methods.
1686         (struct thread_fsm_ops): Remove.
1687         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
1688         (thread_fsm_should_stop, thread_fsm_return_value)
1689         (thread_fsm_set_finished, thread_fsm_finished_p)
1690         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
1691         Don't declare.
1692         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
1693         * infrun.c (clear_proceed_status_thread)
1694         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
1695         (print_stop_event): Update.
1696         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
1697         Add constructor.
1698         (step_command_fsm_ops): Remove.
1699         (new_step_command_fsm): Remove.
1700         (step_1): Update.
1701         (step_command_fsm::should_stop): Rename from
1702         step_command_fsm_should_stop.
1703         (step_command_fsm::clean_up): Rename from
1704         step_command_fsm_clean_up.
1705         (step_command_fsm::do_async_reply_reason): Rename from
1706         step_command_fsm_async_reply_reason.
1707         (struct until_next_fsm): Inherit from thread_fsm.  Add
1708         constructor.
1709         (until_next_fsm_ops): Remove.
1710         (new_until_next_fsm): Remove.
1711         (until_next_fsm::should_stop): Rename from
1712         until_next_fsm_should_stop.
1713         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
1714         (until_next_fsm::do_async_reply_reason): Rename from
1715         until_next_fsm_async_reply_reason.
1716         (struct finish_command_fsm): Inherit from thread_fsm.  Add
1717         constructor.  Change type of breakpoint.
1718         (finish_command_fsm_ops): Remove.
1719         (new_finish_command_fsm): Remove.
1720         (finish_command_fsm::should_stop): Rename from
1721         finish_command_fsm_should_stop.
1722         (finish_command_fsm::clean_up): Rename from
1723         finish_command_fsm_clean_up.
1724         (finish_command_fsm::return_value): Rename from
1725         finish_command_fsm_return_value.
1726         (finish_command_fsm::do_async_reply_reason): Rename from
1727         finish_command_fsm_async_reply_reason.
1728         (finish_command): Update.
1729         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
1730         Add constructor.
1731         (call_thread_fsm_ops): Remove.
1732         (call_thread_fsm::call_thread_fsm): Rename from
1733         new_call_thread_fsm.
1734         (call_thread_fsm::should_stop): Rename from
1735         call_thread_fsm_should_stop.
1736         (call_thread_fsm::should_notify_stop): Rename from
1737         call_thread_fsm_should_notify_stop.
1738         (run_inferior_call, call_function_by_hand_dummy): Update.
1739         * cli/cli-interp.c (should_print_stop_to_console): Update.
1740         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
1741         Add constructor.  Change type of location_breakpoint,
1742         caller_breakpoint.
1743         (until_break_fsm_ops): Remove.
1744         (new_until_break_fsm): Remove.
1745         (until_break_fsm::should_stop): Rename from
1746         until_break_fsm_should_stop.
1747         (until_break_fsm::clean_up): Rename from
1748         until_break_fsm_clean_up.
1749         (until_break_fsm::do_async_reply_reason): Rename from
1750         until_break_fsm_async_reply_reason.
1751         (until_break_command): Update.
1752         * thread-fsm.c: Remove.
1753         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
1754
1755 2019-02-07  Tom Tromey  <tom@tromey.com>
1756
1757         * yy-remap.h: Add include guard.
1758         * xtensa-tdep.h: Add include guard.
1759         * xcoffread.h: Rename include guard.
1760         * varobj-iter.h: Add include guard.
1761         * tui/tui.h: Rename include guard.
1762         * tui/tui-winsource.h: Rename include guard.
1763         * tui/tui-wingeneral.h: Rename include guard.
1764         * tui/tui-windata.h: Rename include guard.
1765         * tui/tui-win.h: Rename include guard.
1766         * tui/tui-stack.h: Rename include guard.
1767         * tui/tui-source.h: Rename include guard.
1768         * tui/tui-regs.h: Rename include guard.
1769         * tui/tui-out.h: Rename include guard.
1770         * tui/tui-layout.h: Rename include guard.
1771         * tui/tui-io.h: Rename include guard.
1772         * tui/tui-hooks.h: Rename include guard.
1773         * tui/tui-file.h: Rename include guard.
1774         * tui/tui-disasm.h: Rename include guard.
1775         * tui/tui-data.h: Rename include guard.
1776         * tui/tui-command.h: Rename include guard.
1777         * tic6x-tdep.h: Add include guard.
1778         * target/waitstatus.h: Rename include guard.
1779         * target/wait.h: Rename include guard.
1780         * target/target.h: Rename include guard.
1781         * target/resume.h: Rename include guard.
1782         * target-float.h: Rename include guard.
1783         * stabsread.h: Add include guard.
1784         * rs6000-tdep.h: Add include guard.
1785         * riscv-fbsd-tdep.h: Add include guard.
1786         * regformats/regdef.h: Rename include guard.
1787         * record.h: Rename include guard.
1788         * python/python.h: Rename include guard.
1789         * python/python-internal.h: Rename include guard.
1790         * python/py-stopevent.h: Rename include guard.
1791         * python/py-ref.h: Rename include guard.
1792         * python/py-record.h: Rename include guard.
1793         * python/py-record-full.h: Rename include guard.
1794         * python/py-record-btrace.h: Rename include guard.
1795         * python/py-instruction.h: Rename include guard.
1796         * python/py-events.h: Rename include guard.
1797         * python/py-event.h: Rename include guard.
1798         * procfs.h: Add include guard.
1799         * proc-utils.h: Add include guard.
1800         * p-lang.h: Add include guard.
1801         * or1k-tdep.h: Rename include guard.
1802         * observable.h: Rename include guard.
1803         * nto-tdep.h: Rename include guard.
1804         * nat/x86-linux.h: Rename include guard.
1805         * nat/x86-linux-dregs.h: Rename include guard.
1806         * nat/x86-gcc-cpuid.h: Add include guard.
1807         * nat/x86-dregs.h: Rename include guard.
1808         * nat/x86-cpuid.h: Rename include guard.
1809         * nat/ppc-linux.h: Rename include guard.
1810         * nat/mips-linux-watch.h: Rename include guard.
1811         * nat/linux-waitpid.h: Rename include guard.
1812         * nat/linux-ptrace.h: Rename include guard.
1813         * nat/linux-procfs.h: Rename include guard.
1814         * nat/linux-osdata.h: Rename include guard.
1815         * nat/linux-nat.h: Rename include guard.
1816         * nat/linux-namespaces.h: Rename include guard.
1817         * nat/linux-btrace.h: Rename include guard.
1818         * nat/glibc_thread_db.h: Rename include guard.
1819         * nat/gdb_thread_db.h: Rename include guard.
1820         * nat/gdb_ptrace.h: Rename include guard.
1821         * nat/fork-inferior.h: Rename include guard.
1822         * nat/amd64-linux-siginfo.h: Rename include guard.
1823         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
1824         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
1825         * nat/aarch64-linux.h: Rename include guard.
1826         * nat/aarch64-linux-hw-point.h: Rename include guard.
1827         * mn10300-tdep.h: Add include guard.
1828         * mips-linux-tdep.h: Add include guard.
1829         * mi/mi-parse.h: Rename include guard.
1830         * mi/mi-out.h: Rename include guard.
1831         * mi/mi-main.h: Rename include guard.
1832         * mi/mi-interp.h: Rename include guard.
1833         * mi/mi-getopt.h: Rename include guard.
1834         * mi/mi-console.h: Rename include guard.
1835         * mi/mi-common.h: Rename include guard.
1836         * mi/mi-cmds.h: Rename include guard.
1837         * mi/mi-cmd-break.h: Rename include guard.
1838         * m2-lang.h: Add include guard.
1839         * location.h: Rename include guard.
1840         * linux-record.h: Rename include guard.
1841         * linux-nat.h: Add include guard.
1842         * linux-fork.h: Add include guard.
1843         * i386-darwin-tdep.h: Rename include guard.
1844         * hppa-linux-offsets.h: Add include guard.
1845         * guile/guile.h: Rename include guard.
1846         * guile/guile-internal.h: Rename include guard.
1847         * gnu-nat.h: Rename include guard.
1848         * gdb-stabs.h: Rename include guard.
1849         * frv-tdep.h: Add include guard.
1850         * f-lang.h: Add include guard.
1851         * event-loop.h: Add include guard.
1852         * darwin-nat.h: Rename include guard.
1853         * cp-abi.h: Rename include guard.
1854         * config/sparc/nm-sol2.h: Rename include guard.
1855         * config/nm-nto.h: Rename include guard.
1856         * config/nm-linux.h: Add include guard.
1857         * config/i386/nm-i386gnu.h: Rename include guard.
1858         * config/djgpp/nl_types.h: Rename include guard.
1859         * config/djgpp/langinfo.h: Rename include guard.
1860         * compile/gcc-cp-plugin.h: Add include guard.
1861         * compile/gcc-c-plugin.h: Add include guard.
1862         * compile/compile.h: Rename include guard.
1863         * compile/compile-object-run.h: Rename include guard.
1864         * compile/compile-object-load.h: Rename include guard.
1865         * compile/compile-internal.h: Rename include guard.
1866         * compile/compile-cplus.h: Rename include guard.
1867         * compile/compile-c.h: Rename include guard.
1868         * common/xml-utils.h: Rename include guard.
1869         * common/x86-xstate.h: Rename include guard.
1870         * common/version.h: Rename include guard.
1871         * common/vec.h: Rename include guard.
1872         * common/tdesc.h: Rename include guard.
1873         * common/selftest.h: Rename include guard.
1874         * common/scoped_restore.h: Rename include guard.
1875         * common/scoped_mmap.h: Rename include guard.
1876         * common/scoped_fd.h: Rename include guard.
1877         * common/safe-iterator.h: Rename include guard.
1878         * common/run-time-clock.h: Rename include guard.
1879         * common/refcounted-object.h: Rename include guard.
1880         * common/queue.h: Rename include guard.
1881         * common/ptid.h: Rename include guard.
1882         * common/print-utils.h: Rename include guard.
1883         * common/preprocessor.h: Rename include guard.
1884         * common/pathstuff.h: Rename include guard.
1885         * common/observable.h: Rename include guard.
1886         * common/netstuff.h: Rename include guard.
1887         * common/job-control.h: Rename include guard.
1888         * common/host-defs.h: Rename include guard.
1889         * common/gdb_wait.h: Rename include guard.
1890         * common/gdb_vecs.h: Rename include guard.
1891         * common/gdb_unlinker.h: Rename include guard.
1892         * common/gdb_unique_ptr.h: Rename include guard.
1893         * common/gdb_tilde_expand.h: Rename include guard.
1894         * common/gdb_sys_time.h: Rename include guard.
1895         * common/gdb_string_view.h: Rename include guard.
1896         * common/gdb_splay_tree.h: Rename include guard.
1897         * common/gdb_setjmp.h: Rename include guard.
1898         * common/gdb_ref_ptr.h: Rename include guard.
1899         * common/gdb_optional.h: Rename include guard.
1900         * common/gdb_locale.h: Rename include guard.
1901         * common/gdb_assert.h: Rename include guard.
1902         * common/filtered-iterator.h: Rename include guard.
1903         * common/filestuff.h: Rename include guard.
1904         * common/fileio.h: Rename include guard.
1905         * common/environ.h: Rename include guard.
1906         * common/common-utils.h: Rename include guard.
1907         * common/common-types.h: Rename include guard.
1908         * common/common-regcache.h: Rename include guard.
1909         * common/common-inferior.h: Rename include guard.
1910         * common/common-gdbthread.h: Rename include guard.
1911         * common/common-exceptions.h: Rename include guard.
1912         * common/common-defs.h: Rename include guard.
1913         * common/common-debug.h: Rename include guard.
1914         * common/cleanups.h: Rename include guard.
1915         * common/buffer.h: Rename include guard.
1916         * common/btrace-common.h: Rename include guard.
1917         * common/break-common.h: Rename include guard.
1918         * cli/cli-utils.h: Rename include guard.
1919         * cli/cli-style.h: Rename include guard.
1920         * cli/cli-setshow.h: Rename include guard.
1921         * cli/cli-script.h: Rename include guard.
1922         * cli/cli-interp.h: Rename include guard.
1923         * cli/cli-decode.h: Rename include guard.
1924         * cli/cli-cmds.h: Rename include guard.
1925         * charset-list.h: Add include guard.
1926         * buildsym-legacy.h: Rename include guard.
1927         * bfin-tdep.h: Add include guard.
1928         * ax.h: Rename include guard.
1929         * arm-linux-tdep.h: Add include guard.
1930         * arm-fbsd-tdep.h: Add include guard.
1931         * arch/xtensa.h: Rename include guard.
1932         * arch/tic6x.h: Add include guard.
1933         * arch/i386.h: Add include guard.
1934         * arch/arm.h: Rename include guard.
1935         * arch/arm-linux.h: Rename include guard.
1936         * arch/arm-get-next-pcs.h: Rename include guard.
1937         * arch/amd64.h: Add include guard.
1938         * arch/aarch64-insn.h: Rename include guard.
1939         * arch-utils.h: Rename include guard.
1940         * annotate.h: Add include guard.
1941         * amd64-darwin-tdep.h: Rename include guard.
1942         * aarch64-linux-tdep.h: Add include guard.
1943         * aarch64-fbsd-tdep.h: Add include guard.
1944         * aarch32-linux-nat.h: Add include guard.
1945
1946 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1947
1948         * macrotab.c (macro_define_internal): New function that
1949         factorizes macro_define_object_internal and macro_define_function
1950         code.
1951         (macro_define_object_internal): Use macro_define_internal.
1952         (macro_define_function): Likewise.
1953
1954 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1955
1956         * macrocmd.c (extract_identifier): Return
1957         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
1958         callers.
1959
1960 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1961
1962         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1963
1964 2019-02-05  Tom Tromey  <tom@tromey.com>
1965
1966         * target.c (target_stack::unpush): Move assertion earlier.
1967
1968 2019-01-30  Tom Tromey  <tom@tromey.com>
1969
1970         PR python/23615:
1971         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1972         (gdbpy_parse_and_eval): Likewise.
1973         * python/python-internal.h (gdbpy_allow_threads): New class.
1974
1975 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1976
1977         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1978         (aarch64_fbsd_fpregmap): Move earlier.
1979         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1980         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1981         instead of individual calls to trad_frame_set_reg_addr.
1982         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1983         earlier.
1984         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1985         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1986         instead of individual calls to trad_frame_set_reg_addr.
1987
1988 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1989
1990         * CONTRIBUTE: Replace contribution list with wiki link.
1991
1992 2019-01-25  Tom Tromey  <tom@tromey.com>
1993
1994         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1995
1996 2019-01-25  Tom Tromey  <tom@tromey.com>
1997
1998         * xtensa-linux-nat.c: Fix common/ includes.
1999         * xml-support.h: Fix common/ includes.
2000         * xml-support.c: Fix common/ includes.
2001         * x86-linux-nat.c: Fix common/ includes.
2002         * windows-nat.c: Fix common/ includes.
2003         * varobj.h: Fix common/ includes.
2004         * varobj.c: Fix common/ includes.
2005         * value.c: Fix common/ includes.
2006         * valops.c: Fix common/ includes.
2007         * utils.c: Fix common/ includes.
2008         * unittests/xml-utils-selftests.c: Fix common/ includes.
2009         * unittests/utils-selftests.c: Fix common/ includes.
2010         * unittests/unpack-selftests.c: Fix common/ includes.
2011         * unittests/tracepoint-selftests.c: Fix common/ includes.
2012         * unittests/style-selftests.c: Fix common/ includes.
2013         * unittests/string_view-selftests.c: Fix common/ includes.
2014         * unittests/scoped_restore-selftests.c: Fix common/ includes.
2015         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
2016         * unittests/scoped_fd-selftests.c: Fix common/ includes.
2017         * unittests/rsp-low-selftests.c: Fix common/ includes.
2018         * unittests/parse-connection-spec-selftests.c: Fix common/
2019         includes.
2020         * unittests/optional-selftests.c: Fix common/ includes.
2021         * unittests/offset-type-selftests.c: Fix common/ includes.
2022         * unittests/observable-selftests.c: Fix common/ includes.
2023         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
2024         * unittests/memrange-selftests.c: Fix common/ includes.
2025         * unittests/memory-map-selftests.c: Fix common/ includes.
2026         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
2027         * unittests/function-view-selftests.c: Fix common/ includes.
2028         * unittests/environ-selftests.c: Fix common/ includes.
2029         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
2030         * unittests/common-utils-selftests.c: Fix common/ includes.
2031         * unittests/cli-utils-selftests.c: Fix common/ includes.
2032         * unittests/array-view-selftests.c: Fix common/ includes.
2033         * ui-file.c: Fix common/ includes.
2034         * tui/tui-io.c: Fix common/ includes.
2035         * tracepoint.h: Fix common/ includes.
2036         * tracepoint.c: Fix common/ includes.
2037         * tracefile-tfile.c: Fix common/ includes.
2038         * top.h: Fix common/ includes.
2039         * top.c: Fix common/ includes.
2040         * thread.c: Fix common/ includes.
2041         * target/waitstatus.h: Fix common/ includes.
2042         * target/waitstatus.c: Fix common/ includes.
2043         * target.h: Fix common/ includes.
2044         * target.c: Fix common/ includes.
2045         * target-memory.c: Fix common/ includes.
2046         * target-descriptions.c: Fix common/ includes.
2047         * symtab.h: Fix common/ includes.
2048         * symfile.c: Fix common/ includes.
2049         * stap-probe.c: Fix common/ includes.
2050         * spu-linux-nat.c: Fix common/ includes.
2051         * sparc-nat.c: Fix common/ includes.
2052         * source.c: Fix common/ includes.
2053         * solib.c: Fix common/ includes.
2054         * solib-target.c: Fix common/ includes.
2055         * ser-unix.c: Fix common/ includes.
2056         * ser-tcp.c: Fix common/ includes.
2057         * ser-pipe.c: Fix common/ includes.
2058         * ser-base.c: Fix common/ includes.
2059         * selftest-arch.c: Fix common/ includes.
2060         * s12z-tdep.c: Fix common/ includes.
2061         * rust-exp.y: Fix common/ includes.
2062         * rs6000-aix-tdep.c: Fix common/ includes.
2063         * riscv-tdep.c: Fix common/ includes.
2064         * remote.c: Fix common/ includes.
2065         * remote-notif.h: Fix common/ includes.
2066         * remote-fileio.h: Fix common/ includes.
2067         * remote-fileio.c: Fix common/ includes.
2068         * regcache.h: Fix common/ includes.
2069         * regcache.c: Fix common/ includes.
2070         * record-btrace.c: Fix common/ includes.
2071         * python/python.c: Fix common/ includes.
2072         * python/py-type.c: Fix common/ includes.
2073         * python/py-inferior.c: Fix common/ includes.
2074         * progspace.h: Fix common/ includes.
2075         * producer.c: Fix common/ includes.
2076         * procfs.c: Fix common/ includes.
2077         * proc-api.c: Fix common/ includes.
2078         * printcmd.c: Fix common/ includes.
2079         * ppc-linux-nat.c: Fix common/ includes.
2080         * parser-defs.h: Fix common/ includes.
2081         * osdata.c: Fix common/ includes.
2082         * obsd-nat.c: Fix common/ includes.
2083         * nat/x86-linux.c: Fix common/ includes.
2084         * nat/x86-linux-dregs.c: Fix common/ includes.
2085         * nat/x86-dregs.h: Fix common/ includes.
2086         * nat/x86-dregs.c: Fix common/ includes.
2087         * nat/ppc-linux.c: Fix common/ includes.
2088         * nat/mips-linux-watch.h: Fix common/ includes.
2089         * nat/mips-linux-watch.c: Fix common/ includes.
2090         * nat/linux-waitpid.c: Fix common/ includes.
2091         * nat/linux-ptrace.h: Fix common/ includes.
2092         * nat/linux-ptrace.c: Fix common/ includes.
2093         * nat/linux-procfs.c: Fix common/ includes.
2094         * nat/linux-personality.c: Fix common/ includes.
2095         * nat/linux-osdata.c: Fix common/ includes.
2096         * nat/linux-namespaces.c: Fix common/ includes.
2097         * nat/linux-btrace.h: Fix common/ includes.
2098         * nat/linux-btrace.c: Fix common/ includes.
2099         * nat/fork-inferior.c: Fix common/ includes.
2100         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2101         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2102         * nat/aarch64-linux.c: Fix common/ includes.
2103         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2104         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2105         * namespace.h: Fix common/ includes.
2106         * mips-linux-tdep.c: Fix common/ includes.
2107         * minsyms.c: Fix common/ includes.
2108         * mi/mi-parse.h: Fix common/ includes.
2109         * mi/mi-main.c: Fix common/ includes.
2110         * mi/mi-cmd-env.c: Fix common/ includes.
2111         * memrange.h: Fix common/ includes.
2112         * memattr.c: Fix common/ includes.
2113         * maint.h: Fix common/ includes.
2114         * maint.c: Fix common/ includes.
2115         * main.c: Fix common/ includes.
2116         * machoread.c: Fix common/ includes.
2117         * location.c: Fix common/ includes.
2118         * linux-thread-db.c: Fix common/ includes.
2119         * linux-nat.c: Fix common/ includes.
2120         * linux-fork.c: Fix common/ includes.
2121         * inline-frame.c: Fix common/ includes.
2122         * infrun.c: Fix common/ includes.
2123         * inflow.c: Fix common/ includes.
2124         * inferior.h: Fix common/ includes.
2125         * inferior.c: Fix common/ includes.
2126         * infcmd.c: Fix common/ includes.
2127         * inf-ptrace.c: Fix common/ includes.
2128         * inf-child.c: Fix common/ includes.
2129         * ia64-linux-nat.c: Fix common/ includes.
2130         * i387-tdep.c: Fix common/ includes.
2131         * i386-tdep.c: Fix common/ includes.
2132         * i386-linux-tdep.c: Fix common/ includes.
2133         * i386-linux-nat.c: Fix common/ includes.
2134         * i386-go32-tdep.c: Fix common/ includes.
2135         * i386-fbsd-tdep.c: Fix common/ includes.
2136         * i386-fbsd-nat.c: Fix common/ includes.
2137         * guile/scm-type.c: Fix common/ includes.
2138         * guile/guile.c: Fix common/ includes.
2139         * go32-nat.c: Fix common/ includes.
2140         * gnu-nat.c: Fix common/ includes.
2141         * gdbthread.h: Fix common/ includes.
2142         * gdbarch-selftests.c: Fix common/ includes.
2143         * gdb_usleep.c: Fix common/ includes.
2144         * gdb_select.h: Fix common/ includes.
2145         * gdb_bfd.c: Fix common/ includes.
2146         * gcore.c: Fix common/ includes.
2147         * fork-child.c: Fix common/ includes.
2148         * findvar.c: Fix common/ includes.
2149         * fbsd-nat.c: Fix common/ includes.
2150         * event-top.c: Fix common/ includes.
2151         * event-loop.c: Fix common/ includes.
2152         * dwarf2read.c: Fix common/ includes.
2153         * dwarf2loc.c: Fix common/ includes.
2154         * dwarf2-frame.c: Fix common/ includes.
2155         * dwarf-index-cache.c: Fix common/ includes.
2156         * dtrace-probe.c: Fix common/ includes.
2157         * disasm-selftests.c: Fix common/ includes.
2158         * defs.h: Fix common/ includes.
2159         * csky-tdep.c: Fix common/ includes.
2160         * cp-valprint.c: Fix common/ includes.
2161         * cp-support.h: Fix common/ includes.
2162         * cp-support.c: Fix common/ includes.
2163         * corelow.c: Fix common/ includes.
2164         * completer.h: Fix common/ includes.
2165         * completer.c: Fix common/ includes.
2166         * compile/compile.c: Fix common/ includes.
2167         * compile/compile-loc2c.c: Fix common/ includes.
2168         * compile/compile-cplus-types.c: Fix common/ includes.
2169         * compile/compile-cplus-symbols.c: Fix common/ includes.
2170         * command.h: Fix common/ includes.
2171         * cli/cli-dump.c: Fix common/ includes.
2172         * cli/cli-cmds.c: Fix common/ includes.
2173         * charset.c: Fix common/ includes.
2174         * build-id.c: Fix common/ includes.
2175         * btrace.h: Fix common/ includes.
2176         * btrace.c: Fix common/ includes.
2177         * breakpoint.h: Fix common/ includes.
2178         * breakpoint.c: Fix common/ includes.
2179         * ax.h:
2180         (enum agent_op): Fix common/ includes.
2181         * ax-general.c (struct aop_map): Fix common/ includes.
2182         * ax-gdb.c: Fix common/ includes.
2183         * auxv.c: Fix common/ includes.
2184         * auto-load.c: Fix common/ includes.
2185         * arm-tdep.c: Fix common/ includes.
2186         * arch/riscv.c: Fix common/ includes.
2187         * arch/ppc-linux-common.c: Fix common/ includes.
2188         * arch/i386.c: Fix common/ includes.
2189         * arch/arm.c: Fix common/ includes.
2190         * arch/arm-linux.c: Fix common/ includes.
2191         * arch/arm-get-next-pcs.c: Fix common/ includes.
2192         * arch/amd64.c: Fix common/ includes.
2193         * arch/aarch64.c: Fix common/ includes.
2194         * arch/aarch64-insn.c: Fix common/ includes.
2195         * arch-utils.c: Fix common/ includes.
2196         * amd64-windows-tdep.c: Fix common/ includes.
2197         * amd64-tdep.c: Fix common/ includes.
2198         * amd64-sol2-tdep.c: Fix common/ includes.
2199         * amd64-obsd-tdep.c: Fix common/ includes.
2200         * amd64-nbsd-tdep.c: Fix common/ includes.
2201         * amd64-linux-tdep.c: Fix common/ includes.
2202         * amd64-linux-nat.c: Fix common/ includes.
2203         * amd64-fbsd-tdep.c: Fix common/ includes.
2204         * amd64-fbsd-nat.c: Fix common/ includes.
2205         * amd64-dicos-tdep.c: Fix common/ includes.
2206         * amd64-darwin-tdep.c: Fix common/ includes.
2207         * agent.c: Fix common/ includes.
2208         * ada-lang.h: Fix common/ includes.
2209         * ada-lang.c: Fix common/ includes.
2210         * aarch64-tdep.c: Fix common/ includes.
2211
2212 2019-01-25  Tom Tromey  <tom@tromey.com>
2213
2214         * common/create-version.sh: Use common/version.h.
2215
2216 2019-01-24  Pedro Alves  <palves@redhat.com>
2217
2218         * infrun.c (signal_stop, signal_print, signal_program)
2219         (signal_catch, signal_pass): Now arrays instead of pointers.
2220         (update_signals_program_target, do_target_resume)
2221         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2222         * linux-nat.c (linux_nat_target::pass_signals)
2223         (linux_nat_target::create_inferior, linux_nat_target::attach):
2224         Adjust.
2225         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2226         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2227         * procfs.c (procfs_target::pass_signals): Adjust.
2228         * record-full.c (record_full_target::resume): Adjust.
2229         * remote.c (remote_target::pass_signals)
2230         (remote_target::program_signals): Adjust.
2231         * target-debug.h (target_debug_print_signals): Now takes a
2232         gdb::array_view as parameter.  Adjust.
2233         * target.h (target_ops) <pass_signals, program_signals>: Replace
2234         pointer and length parameters with gdb::array_view.
2235         (target_pass_signals, target_program_signals): Likewise.
2236         * target-delegates.c: Regenerate.
2237
2238 2019-01-24  Pedro Alves  <palves@redhat.com>
2239
2240         * common/forward-scope-exit.h
2241         (forward_scope_exit::forward_scope_exit): Pass arguments to
2242         m_bind_function directly, instead of creating a std::bind and
2243         copying that.
2244
2245 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2246
2247         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2248         for static members.
2249         (pass_in_v_vfp_candidate): Likewise.
2250
2251 2019-01-23  Tom Tromey  <tom@tromey.com>
2252             Pedro Alves  <palves@redhat.com>
2253
2254         * regcache.c (class regcache_invalidator): Remove.
2255         (regcache::raw_write): Use make_scope_exit.
2256
2257 2019-01-23  Tom Tromey  <tom@tromey.com>
2258
2259         * ui-out.h (class ui_out_emit_type): Update comment.
2260
2261 2019-01-23  Tom Tromey  <tom@tromey.com>
2262
2263         * infrun.c (fetch_inferior_event): Update comment.
2264
2265 2019-01-23  Tom Tromey  <tom@tromey.com>
2266             Pedro Alves  <palves@redhat.com>
2267
2268         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2269         parameter.
2270         (fetch_inferior_event): Use SCOPE_EXIT.
2271
2272
2273 2019-01-23  Tom Tromey  <tom@tromey.com>
2274             Pedro Alves  <palves@redhat.com>
2275
2276         * infrun.c (disable_thread_events): Delete.
2277         (stop_all_threads): Use SCOPE_EXIT.
2278
2279 2019-01-23  Tom Tromey  <tom@tromey.com>
2280             Pedro Alves  <palves@redhat.com>
2281
2282         * symfile.c: Include forward-scope-exit.h.
2283         (clear_symtab_users_cleanup): Replace forward declaration with
2284         a FORWARD_SCOPE_EXIT.
2285         (syms_from_objfile_1): Use the forward_scope_exit and
2286         gdb::optional instead of cleanup_function.
2287         (reread_symbols): Use the forward_scope_exit instead of
2288         cleanup_function.
2289         (clear_symtab_users_cleanup): Remove function.
2290
2291 2019-01-23  Tom Tromey  <tom@tromey.com>
2292             Pedro Alves  <palves@redhat.com>
2293
2294         * linux-nat.c: Include scope-exit.h.
2295         (cleanup_target_stop): Remove.
2296         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2297         SCOPE_EXIT.
2298
2299 2019-01-23  Tom Tromey  <tom@tromey.com>
2300             Pedro Alves  <palves@redhat.com>
2301
2302         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2303         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2304
2305 2019-01-23  Tom Tromey  <tom@tromey.com>
2306             Andrew Burgess  <andrew.burgess@embecosm.com>
2307             Pedro Alves  <palves@redhat.com>
2308
2309         * infrun.c (fetch_inferior_event): Use scope_exit.
2310         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2311         * top.c (execute_command): Use scope_exit.
2312         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2313         * utils.c (do_bpstat_clear_actions_cleanup)
2314         (make_bpstat_clear_actions_cleanup): Remove.
2315
2316 2019-01-23  Tom Tromey  <tom@tromey.com>
2317             Pedro Alves  <palves@redhat.com>
2318
2319         * infrun.c: Include "common/scope-exit.h"
2320         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2321         (wait_for_inferior): Use SCOPE_EXIT.
2322         (fetch_inferior_event): Use scope_exit.
2323
2324 2019-01-23  Tom Tromey  <tom@tromey.com>
2325             Pedro Alves  <palves@redhat.com>
2326
2327         * breakpoint.c (create_breakpoint): Remove cleanup.
2328
2329 2019-01-23  Tom Tromey  <tom@tromey.com>
2330             Andrew Burgess  <andrew.burgess@embecosm.com>
2331             Pedro Alves  <palves@redhat.com>
2332
2333 2019-01-23  Pedro Alves  <palves@redhat.com>
2334
2335         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2336
2337 2019-01-23  Pedro Alves  <palves@redhat.com>
2338             Andrew Burgess  <andrew.burgess@embecosm.com>
2339
2340         * gdbthread.h: Include "common/forward-scope-exit.h".
2341         (scoped_finish_thread_state): Redefine custom class in terms of
2342         forward_scope_exit.
2343
2344 2019-01-23  Pedro Alves  <palves@redhat.com>
2345             Andrew Burgess  <andrew.burgess@embecosm.com>
2346
2347         * common/forward-scope-exit.h: New file.
2348
2349 2019-01-23  Pedro Alves  <palves@redhat.com>
2350             Andrew Burgess  <andrew.burgess@embecosm.com>
2351             Tom Tromey  <tom@tromey.com>
2352
2353         * common/scope-exit.h: New file.
2354
2355 2019-01-23  Pedro Alves  <palves@redhat.com>
2356
2357         * common/preprocessor.h (ESC): Rename to ...
2358         (ESC_PARENS): ... this.
2359         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2360         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2361
2362 2019-01-23  Tom Tromey  <tom@tromey.com>
2363
2364         * language.h (class scoped_switch_to_sym_language_if_auto):
2365         Initialize m_lang in both cases.
2366
2367 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2368
2369         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2370         with XCNEW.
2371
2372 2019-01-22  Tom Tromey  <tom@tromey.com>
2373
2374         * corelow.c: Do not include sys/file.h.
2375
2376 2019-01-22  Tom Tromey  <tom@tromey.com>
2377
2378         * tui/tui-wingeneral.h: Include gdb_curses.h.
2379
2380 2019-01-22  Tom Tromey  <tom@tromey.com>
2381
2382         * source-cache.h (class source_cache) <get_source_lines,
2383         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2384
2385 2019-01-22  Tom Tromey  <tom@tromey.com>
2386
2387         * remote-fileio.h (struct remote_target): Declare.
2388
2389 2019-01-22  Tom Tromey  <tom@tromey.com>
2390
2391         * python/py-arch.c: Do not include py-ref.h.
2392         * python/py-bpevent.c: Do not include py-ref.h.
2393         * python/py-cmd.c: Do not include py-ref.h.
2394         * python/py-continueevent.c: Do not include py-ref.h.
2395         * python/py-event.h: Do not include py-ref.h.
2396         * python/py-evtregistry.c: Do not include py-ref.h.
2397         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2398         * python/py-frame.c: Do not include py-ref.h.
2399         * python/py-framefilter.c: Do not include py-ref.h.
2400         * python/py-function.c: Do not include py-ref.h.
2401         * python/py-infevents.c: Do not include py-ref.h.
2402         * python/py-linetable.c: Do not include py-ref.h.
2403         * python/py-objfile.c: Do not include py-ref.h.
2404         * python/py-param.c: Do not include py-ref.h.
2405         * python/py-prettyprint.c: Do not include py-ref.h.
2406         * python/py-progspace.c: Do not include py-ref.h.
2407         * python/py-symbol.c: Do not include py-ref.h.
2408         * python/py-symtab.c: Do not include py-ref.h.
2409         * python/py-type.c: Do not include py-ref.h.
2410         * python/py-unwind.c: Do not include py-ref.h.
2411         * python/py-utils.c: Do not include py-ref.h.
2412         * python/py-value.c: Do not include py-ref.h.
2413         * python/py-varobj.c: Do not include py-ref.h.
2414         * python/py-xmethods.c: Do not include py-ref.h.
2415         * python/python.c: Do not include py-ref.h.
2416         * varobj.c: Do not include py-ref.h.
2417
2418 2019-01-22  Tom Tromey  <tom@tromey.com>
2419
2420         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2421         keyword for bcache.
2422
2423 2019-01-22  Tom Tromey  <tom@tromey.com>
2424
2425         * compile/compile-cplus-types.c: Remove a comment by #include.
2426
2427 2019-01-22  Tom Tromey  <tom@tromey.com>
2428
2429         * compile/gcc-c-plugin.h: Include compile-internal.h.
2430
2431 2019-01-22  Tom Tromey  <tom@tromey.com>
2432
2433         * stabsread.c (EXTERN): Do not define.
2434         (symnum, next_symbol_text_func, processing_gcc_compilation)
2435         (within_function, global_sym_chain, global_stabs)
2436         (previous_stab_code, this_object_header_files)
2437         (n_this_object_header_files)
2438         (n_allocated_this_object_header_files): Define.
2439         * stabsread.h (EXTERN): Never define.  Use "extern".
2440
2441 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2442
2443         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2444         history_value.
2445
2446 2019-01-21  Tom Tromey  <tom@tromey.com>
2447
2448         * ui-out.c: Fix includes.
2449         * tui/tui-source.c: Fix includes.
2450         * target.c: Fix includes.
2451         * remote.c: Fix includes.
2452         * regcache.c: Fix includes.
2453         * python/py-block.c: Fix includes.
2454         * printcmd.c: Fix includes.
2455         * or1k-tdep.c: Fix includes.
2456         * mi/mi-main.c: Fix includes.
2457         * m32r-tdep.c: Fix includes.
2458         * csky-tdep.c: Fix includes.
2459         * compile/compile-cplus-types.c: Fix includes.
2460         * cli/cli-interp.c: Fix includes.
2461
2462 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2463
2464         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2465         for padding.
2466
2467 2019-01-16  Tom Tromey  <tom@tromey.com>
2468
2469         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2470         earlier.
2471         (struct objfile) <msymbols_range>: Move from top level.
2472         <msymbols>: New method.
2473         (class objfile_msymbols): Remove.
2474         * symtab.c (default_collect_symbol_completion_matches_break_on):
2475         Update.
2476         * symmisc.c (dump_msymbols): Update.
2477         * stabsread.c (scan_file_globals): Update.
2478         * objc-lang.c (info_selectors_command, info_classes_command)
2479         (find_methods): Update.
2480         * minsyms.c (find_solib_trampoline_target): Update.
2481         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2482         * coffread.c (coff_symfile_read): Update.
2483         * ada-lang.c (ada_lookup_simple_minsym)
2484         (ada_collect_symbol_completion_matches): Update.
2485
2486 2019-01-16  Tom Tromey  <tom@tromey.com>
2487
2488         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2489         type.  Remove no-argument constructor.
2490         <iterator::operator++>: Simplify.
2491         <begin>: Update.
2492         <end>: Use minimal_symbol_count.
2493
2494 2019-01-16  Tom Tromey  <tom@tromey.com>
2495
2496         * objfiles.h (struct objfile) <psymtabs>: New method.
2497         (class objfile_psymtabs): Remove.
2498         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2499         typedef.
2500         <range>: New method.
2501         (require_partial_symbols): Change return type.
2502         * psymtab.c (require_partial_symbols)
2503         (psym_expand_symtabs_matching): Update.
2504         * mdebugread.c (parse_partial_symbols): Update.
2505         * dbxread.c (dbx_end_psymtab): Update.
2506
2507 2019-01-15  Tom Tromey  <tom@tromey.com>
2508
2509         * symtab.c (lookup_objfile_from_block)
2510         (lookup_symbol_in_objfile_symtabs)
2511         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2512         (find_line_symtab, info_sources_command)
2513         (default_collect_symbol_completion_matches_break_on)
2514         (make_source_files_completion_list): Update.
2515         * symmisc.c (print_objfile_statistics, dump_objfile)
2516         (maintenance_print_symbols, maintenance_info_symtabs)
2517         (maintenance_check_symtabs, maintenance_info_line_tables):
2518         Update.
2519         * source.c (select_source_symtab)
2520         (forget_cached_source_info_for_objfile): Update.
2521         * objfiles.h (class objfile_compunits): Remove.
2522         (struct objfile) <compunits_range>: New typedef.
2523         (compunits): New method.
2524         * objfiles.c (objfile_relocate1): Update.
2525         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2526         * maint.c (count_symtabs_and_blocks): Update.
2527         * linespec.c (iterate_over_all_matching_symtabs): Update.
2528         * cp-support.c (add_symbol_overload_list_qualified): Update.
2529         * coffread.c (coff_symtab_read): Update.
2530         * ada-lang.c (add_nonlocal_symbols)
2531         (ada_collect_symbol_completion_matches)
2532         (ada_add_global_exceptions): Update.
2533
2534 2019-01-15  Tom Tromey  <tom@tromey.com>
2535
2536         * progspace.h (program_space) <objfiles_safe_range>: New
2537         typedef.
2538         <objfiles_safe>: New method.
2539         * objfiles.h (class all_objfiles_safe): Remove.
2540         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2541         * jit.c (jit_inferior_exit_hook): Update.
2542
2543 2019-01-17  Tom Tromey  <tom@tromey.com>
2544
2545         * progspace.h (program_space) <objfiles_range>: New typedef.
2546         <objfiles>: New method.
2547         <objfiles_head>: Rename from objfiles.
2548         (object_files): Update.
2549         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2550         * guile/scm-pretty-print.c
2551         (ppscm_find_pretty_printer_from_objfiles): Update.
2552         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2553         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2554         Update.
2555         * python/py-progspace.c (pspy_get_objfiles): Update.
2556         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2557         Update.
2558         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2559         (objfpy_lookup_objfile_by_build_id): Update.
2560         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2561         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2562         Update.
2563         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2564         (expand_symtab_containing_pc, lookup_objfile_from_block)
2565         (lookup_static_symbol, basic_lookup_transparent_type)
2566         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2567         (find_line_symtab, info_sources_command)
2568         (default_collect_symbol_completion_matches_break_on)
2569         (make_source_files_completion_list, find_main_name): Update.
2570         * symmisc.c (print_symbol_bcache_statistics)
2571         (print_objfile_statistics, maintenance_print_symbols)
2572         (maintenance_print_msymbols, maintenance_print_objfiles)
2573         (maintenance_info_symtabs, maintenance_check_symtabs)
2574         (maintenance_expand_symtabs, maintenance_info_line_tables):
2575         Update.
2576         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2577         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2578         (map_overlay_command, unmap_overlay_command)
2579         (simple_overlay_update, expand_symtabs_matching)
2580         (map_symbol_filenames): Update.
2581         * symfile-debug.c (set_debug_symfile): Update.
2582         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2583         Update.
2584         * source.c (select_source_symtab, forget_cached_source_info):
2585         Update.
2586         * solib.c (solib_read_symbols): Update.
2587         * solib-spu.c (append_ocl_sos): Update.
2588         * psymtab.c (maintenance_print_psymbols)
2589         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2590         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2591         * printcmd.c (info_symbol_command): Update.
2592         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2593         Update.
2594         * objfiles.h (class all_objfiles): Remove.
2595         * objfiles.c (have_partial_symbols, have_full_symbols)
2596         (have_minimal_symbols, qsort_cmp, update_section_map)
2597         (shared_objfile_contains_address_p)
2598         (default_iterate_over_objfiles_in_search_order): Update.
2599         * objc-lang.c (info_selectors_command, info_classes_command)
2600         (find_methods): Update.
2601         * minsyms.c (find_solib_trampoline_target): Update.
2602         * maint.c (maintenance_info_sections)
2603         (maintenance_translate_address, count_symtabs_and_blocks):
2604         Update.
2605         * main.c (captured_main_1): Update.
2606         * linux-thread-db.c (try_thread_db_load_from_pdir)
2607         (has_libpthread): Update.
2608         * linespec.c (iterate_over_all_matching_symtabs)
2609         (search_minsyms_for_name): Update.
2610         * jit.c (jit_find_objf_with_entry_addr): Update.
2611         * hppa-tdep.c (find_unwind_entry)
2612         (hppa_lookup_stub_minimal_symbol): Update.
2613         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2614         Update.
2615         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2616         (elf_gnu_ifunc_resolve_by_got): Update.
2617         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2618         * dwarf-index-write.c (save_gdb_index_command): Update.
2619         * cp-support.c (add_symbol_overload_list_qualified): Update.
2620         * breakpoint.c (create_overlay_event_breakpoint)
2621         (create_longjmp_master_breakpoint)
2622         (create_std_terminate_master_breakpoint)
2623         (create_exception_master_breakpoint): Update.
2624         * blockframe.c (find_pc_partial_function): Update.
2625         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2626         (ada_collect_symbol_completion_matches)
2627         (ada_add_global_exceptions): Update.
2628
2629 2019-01-17  Tom Tromey  <tom@tromey.com>
2630
2631         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2632         declare VEC.
2633         (solib_target_parse_libraries): Change return type.
2634         (library_list_start_segment, library_list_start_section)
2635         (library_list_end_library, library_list_start_library); Update.
2636         (solib_target_free_library_list): Remove.
2637         (solib_target_parse_libraries): Remove cleanup.  Change return
2638         type.
2639         (solib_target_current_sos): Update.
2640
2641 2019-01-17  Tom Tromey  <tromey@bapiya>
2642
2643         * valprint.c: Replace "the the" with "the".
2644         * symtab.c: Replace "the the" with "the".
2645         * solib.c: Replace "the the" with "the".
2646         * solib-dsbt.c: Replace "the the" with "the".
2647         * linespec.c: Replace "the the" with "the".
2648         * dwarf2loc.h: Replace "the the" with "the".
2649         * amd64-windows-tdep.c: Replace "the the" with "the".
2650         * aarch64-tdep.c: Replace "the the" with "the".
2651
2652 2019-01-16  Keith Seitz  <keiths@redhat.com>
2653
2654         PR gdb/23773
2655         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2656         <builder>: Rename to ..
2657         <m_builder>: ... this and make private.
2658         (dwarf2_cu::get_builder): New method.  Change all users of
2659         `builder' to use this method.
2660         (dwarf2_start_symtab): Move to ...
2661         (dwarf2_cu::start_symtab): ... here.  Update all callers
2662         (setup_type_unit_groups): Move to ...
2663         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
2664         callers.
2665         (dwarf2_cu::reset_builder): New method.
2666         (process_full_compunit, process_full_type_unit): Use
2667         dwarf2_cu::reset_builder.
2668         (follow_die_offset): Record the ancestor CU if it is different
2669         from the followed DIE's CU.
2670         (follow_die_sig_1): Likewise.
2671
2672 2019-01-15  Tom Tromey  <tom@tromey.com>
2673
2674         * remote.c (class remote_state) <buf>: Now a char_vector.
2675         <buf_size>: Remove.
2676         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
2677         parameter.
2678         (remote_target::getpkt_or_notif_sane_1)
2679         (remote_target::getpkt_sane)
2680         (remote_target::getpkt_or_notif_sane): Likewise.
2681         (class remote_target) <putpkt>: New overload.
2682         (remote_target::read_frame): Change type of "buf_p".  Remove
2683         sizeof_p parameter.
2684         (packet_ok): New overload.
2685         (packet_check_result): New overload.
2686         Update all uses.
2687
2688 2019-01-14  Tom Tromey  <tom@tromey.com>
2689
2690         * remote-notif.c (handle_notification, remote_notif_ack)
2691         (remote_notif_parse): Make "buf" const.
2692         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
2693         const.
2694         (remote_notif_parse, remote_notif_ack, handle_notification):
2695         Likewise.
2696         * remote.c (remote_notif_stop_parse): Make "buf" const.
2697         (remote_target::remote_parse_stop_reply): Make "buf" const.
2698         (remote_notif_stop_ack): Make "buf" const.
2699
2700 2019-01-14  Tom Tromey  <tom@tromey.com>
2701
2702         * remote.c (remote_console_output): Make parameter const.
2703
2704 2019-01-14  Tom Tromey  <tom@tromey.com>
2705
2706         * target-debug.h (target_debug_print_signals): Constify.
2707         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
2708         * procfs.c (procfs_target::pass_signals): Update.
2709         * linux-nat.c (linux_nat_target::pass_signals): Update.
2710         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
2711         * target-delegates.c: Rebuild.
2712         * remote.c (remote_target::program_signals): Update.
2713         (remote_target::pass_signals): Update.
2714         * target.c (target_pass_signals): Constify argument.
2715         (target_program_signals): Likewise.
2716         * target.h (struct target_ops) <pass_signals, program_signals>:
2717         Constify argument.
2718         (target_pass_signals, target_program_signals): Constify argument.
2719
2720 2019-01-14  Tom Tromey  <tom@tromey.com>
2721
2722         PR tui/28819:
2723         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
2724
2725 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2726
2727         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
2728         field.
2729         * rs6000-tdep.c: Include reggroups.h.
2730         (IS_V_ALIAS_PSEUDOREG): Define.
2731         (rs6000_register_name): Return names for the "vX" aliases.
2732         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
2733         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
2734         aliases.  Call default_register_reggroup_p for all other
2735         pseudo-registers.
2736         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
2737         New functions.
2738         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
2739         Handle "vX" aliases.
2740         (v_alias_pseudo_register_collect): New function.
2741         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
2742         (rs6000_gdbarch_init): Initialize "vX" aliases as
2743         pseudo-registers.  Restore registration of
2744         rs6000_pseudo_register_reggroup_p with
2745         set_tdesc_pseudo_register_reggroup_p.
2746
2747 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
2748
2749         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
2750         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
2751         set_gdbarch_num_pseudo_regs.
2752
2753 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2754
2755         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
2756         Remove arg prefixname, add do_set and do_show.
2757         Add member functions set_list and show_list.
2758         * cli/cli-style.c (class cli_style_option): Update accordingly.
2759         (style_set_list): Move to file scope.
2760         (style_show_list): Likewise.
2761         (set_style): Call help_list.
2762         (show_style): Call cmd_show_list.
2763         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
2764         Update to use the new macro.
2765
2766 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
2767
2768         * ada-lang.c (_initialize_ada_language): Expand the help text
2769         for the "catch exception" command.
2770
2771 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2772
2773         * symtab.c (matching_obj_sections): Initialize obj,
2774         declare it closer to its usage.
2775
2776 2019-01-10  Tom Tromey  <tom@tromey.com>
2777
2778         * thread-iter.h (inf_threads_iterator): Use next_iterator.
2779         (basic_inf_threads_range): Remove.
2780         (inf_threads_range, inf_non_exited_threads_range)
2781         (safe_inf_threads_range): Use next_adapter.
2782
2783 2019-01-10  Keith Seitz  <keiths@redhat.com>
2784
2785         PR gdb/23712
2786         PR symtab/23010
2787         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
2788         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
2789
2790 2019-01-10  Keith Seitz  <keiths@redhat.com>
2791
2792         PR gdb/23712
2793         PR symtab/23010
2794         * dictionary.c (pending_to_vector): Remove.
2795         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2796         Remove _1 suffix, replacing functions of the same name.  Update
2797         all callers.
2798         (dict_create_hashed, dict_create_hashed_expandable)
2799         (dict_create_linear, dict_create_linear_expandable, dict_free)
2800         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
2801         Make functions static.
2802
2803 2019-01-10  Keith Seitz  <keiths@redhat.com>
2804
2805         PR gdb/23712
2806         PR symtab/23010
2807         * dictionary.h (struct dictionary): Replace declaration with
2808         multidictionary.
2809         (dict_create_hashed, dict_create_hashed_expandable)
2810         (dict_create_linear, dict_create_linear_expandable)
2811         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
2812         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
2813         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
2814         taking multidictionary argument.
2815         [ALL_DICT_SYMBOLS]: Update for multidictionary.
2816         * block.h (struct block) <dict>: Change to multidictionary
2817         and rename `multidict'.
2818         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
2819         symmisc.c: Update all dictionary references to multidictionary.
2820
2821 2019-01-10  Keith Seitz  <keiths@redhat.com>
2822
2823         PR gdb/23712
2824         PR symtab/23010
2825         * dictionary.c: Include unordered_map.
2826         (pending_to_vector): New function.
2827         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2828         Rewrite the non-"_1" functions to take vector instead
2829         of linked list.
2830         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
2831         "new" _1 versions of the same name.
2832         (multidictionary): Define.
2833         (std::hash<enum language): New definition.
2834         (collate_pending_symbols_by_language, mdict_create_hashed)
2835         (mdict_create_hashed_expandable, mdict_create_linear)
2836         (mdict_create_linear_expandable, mdict_free)
2837         (find_language_dictionary, create_new_language_dictionary)
2838         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
2839         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
2840         (mdict_size, mdict_empty): New functions.
2841         * dictionary.h (mdict_iterator): Define.
2842
2843 2019-01-10  Pedro Alves  <palves@redhat.com>
2844
2845         * breakpoint.c (read_uploaded_action)
2846         (create_tracepoint_from_upload): Adjust to use
2847         gdb::unique_xmalloc_ptr.
2848         * ctf.c (ctf_write_uploaded_tp):
2849         (SET_ARRAY_FIELD): Use emplace_back.
2850         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
2851         * tracefile-tfile.c (tfile_write_uploaded_tp):
2852         * tracepoint.c (parse_tracepoint_definition): Adjust to use
2853         gdb::unique_xmalloc_ptr.
2854         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
2855         at_string, cond_string, cmd_strings>: Replace char pointers
2856         with gdb::unique_xmalloc_ptr.
2857
2858 2019-01-10  Pedro Alves  <palves@redhat.com>
2859
2860         * solib-target.c (library_list_start_library): Don't xstrdup name.
2861
2862 2019-01-10  Pedro Alves  <palves@redhat.com>
2863
2864         * mdebugread.c (parse_partial_symbols): Use
2865         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
2866
2867 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2868
2869         * linux-fork.c (scoped_switch_fork_info)
2870         <~scoped_switch_fork_info>: Fix incorrect variable name.
2871
2872 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2873
2874         * linux-fork.c (scoped_switch_fork_info)
2875         <scoped_switch_fork_info>: Make explicit.
2876         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
2877
2878 2019-01-10  Tom Tromey  <tom@tromey.com>
2879
2880         * objfiles.h (objfile::reset_psymtabs): Update.
2881         * objfiles.c (objfile::objfile): Update.
2882         * psymtab.h (psymtab_storage::obstack): Update.
2883         (psymtab_storage::m_obstack): Use gdb::optional.
2884         (class psymtab_storage): Update comment.  Remove objfile
2885         parameter.
2886         * psymtab.c (psymtab_storage::psymtab_storage): Update.
2887
2888 2019-01-10  Tom Tromey  <tom@tromey.com>
2889
2890         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
2891         <free_psymtabs>: Now private.
2892         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
2893         (allocate_psymtab): Use new method.
2894
2895 2019-01-10  Tom Tromey  <tom@tromey.com>
2896
2897         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
2898         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
2899         * mdebugread.c (parse_partial_symbols): Use
2900         allocate_dependencies.
2901         * dwarf2read.c (dwarf2_create_include_psymtab): Use
2902         allocate_dependencies.
2903         (process_psymtab_comp_unit_reader)
2904         (build_type_psymtab_dependencies): Likewise.
2905         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
2906
2907 2019-01-10  Tom Tromey  <tom@tromey.com>
2908
2909         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
2910         PSYMBOL_SET_LANGUAGE.
2911         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
2912
2913 2019-01-10  Tom Tromey  <tom@tromey.com>
2914
2915         * psymtab.h (psymtab_storage::obstack): New method.
2916         <m_obstack>: Rename from obstack; now private.
2917         * psymtab.c (psymtab_storage): Update.
2918         * dwarf2read.c (create_addrmap_from_index)
2919         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
2920         Update.
2921
2922 2019-01-10  Tom Tromey  <tom@tromey.com>
2923
2924         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
2925         * objfiles.h (objfile::reset_psymtabs): New method.
2926
2927 2019-01-10  Tom Tromey  <tom@tromey.com>
2928
2929         * symmisc.c (print_symbol_bcache_statistics): Update.
2930         (print_objfile_statistics): Update.
2931         * symfile.c (reread_symbols): Update.
2932         * psymtab.h (class psymtab_storage): New.
2933         * psymtab.c (psymtab_storage): New constructor.
2934         (~psymtab_storage): New destructor.
2935         (require_partial_symbols): Update.
2936         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
2937         (find_pc_sect_psymtab, find_pc_sect_psymbol)
2938         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
2939         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
2940         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
2941         (start_psymtab_common, end_psymtab_common)
2942         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
2943         (allocate_psymtab): Update.
2944         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
2945         Update.
2946         (dump_psymtab_addrmap, maintenance_print_psymbols)
2947         (maintenance_check_psymtabs): Update.
2948         (class objfile_psymtabs): Move to objfiles.h.
2949         * psympriv.h (discard_psymtab): Now inline.
2950         (psymtab_discarder::psymtab_discarder): Update.
2951         (psymtab_discarder::~psymtab_discarder): Update.
2952         (ALL_OBJFILE_PSYMTABS): Rewrite.
2953         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
2954         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
2955         Remove fields.
2956         <partial_symtabs>: New field.
2957         (class objfile_psymtabs): Move from psymtab.h.  Update.
2958         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
2959         psymbol_cache.
2960         (objfile::~objfile): Don't destroy psymbol_cache.
2961         * mdebugread.c (parse_partial_symbols): Update.
2962         * dwarf2read.c (create_addrmap_from_index)
2963         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2964         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2965         (add_partial_subprogram, dwarf2_ranges_read): Update.
2966         * dwarf-index-write.c (write_address_map)
2967         (write_one_signatured_type, recursively_write_psymbols)
2968         (class debug_names, class debug_names, write_psymtabs_to_index):
2969         Update.
2970
2971 2019-01-10  Tom Tromey  <tom@tromey.com>
2972
2973         * symtab.h (SYMBOL_SET_NAMES): Update.
2974         (symbol_set_names): Update.
2975         (MSYMBOL_SET_NAMES): Update.
2976         * symtab.c (symbol_set_names): Change argument to be an
2977         objfile_per_bfd_storage.
2978         * psymtab.c (add_psymbol_to_bcache): Update.
2979         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2980
2981 2019-01-10  Tom Tromey  <tom@tromey.com>
2982
2983         * symtab.c (create_demangled_names_hash): Change argument to be an
2984         objfile_per_bfd_storage.
2985         (symbol_set_names): Update.
2986
2987 2019-01-10  Tom Tromey  <tom@tromey.com>
2988
2989         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2990         init_psymbol_list.
2991         * psymtab.c (init_psymbol_list): Do nothing if already called.
2992         * psympriv.h (init_psymbol_list): Add comment.
2993         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2994         init_psymbol_list.
2995         * dbxread.c (dbx_symfile_read): Unconditionally call
2996         init_psymbol_list.
2997
2998 2019-01-10  Tom Tromey  <tom@tromey.com>
2999
3000         * xcoffread.c (scan_xcoff_symtab): Update.
3001         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
3002         "where".
3003         * mdebugread.c (parse_partial_symbols)
3004         (handle_psymbol_enumerators): Update.
3005         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
3006         * dbxread.c (read_dbx_symtab): Update.
3007         * psympriv.h (psymbol_placement): New enum.
3008         (add_psymbol_to_list): Update.
3009
3010 2019-01-10  Tom Tromey  <tom@tromey.com>
3011
3012         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
3013         static_psymbols parameters.
3014         (scan_xcoff_symtab): Update.
3015         * psymtab.c (start_psymtab_common): Remove global_psymbols and
3016         static_psymbols parameters.
3017         * psympriv.h (start_psymtab_common): Update.
3018         * mdebugread.c (parse_partial_symbols): Update.
3019         * dwarf2read.c (create_partial_symtab): Update.
3020         * dbxread.c (read_dbx_symtab): Update.
3021         (start_psymtab): Remove global_psymbols and static_psymbols
3022         parameters.
3023
3024 2019-01-10  Tom Tromey  <tom@tromey.com>
3025
3026         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
3027         * psymtab.c (allocate_psymtab): Add comment.
3028         * psympriv.h (allocate_psymtab): Add comment.
3029         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
3030         initializations.
3031         * dbxread.c (dbx_end_psymtab): Remove some initializations.
3032
3033 2019-01-10  Tom Tromey  <tom@tromey.com>
3034
3035         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3036         Don't declare.
3037         * mipsread.c: Include mdebugread.h.
3038         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3039         Declare.
3040         * elfread.c: Include mdebugread.h.
3041
3042 2019-01-09  Tom Tromey  <tom@tromey.com>
3043
3044         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3045         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3046         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3047         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3048         (psym_lookup_symbol, psym_find_last_source_symtab)
3049         (psym_forget_cached_source_info, psym_print_stats)
3050         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3051         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3052         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3053         (psym_find_compunit_symtab_by_address)
3054         (maintenance_print_psymbols, maintenance_info_psymtabs)
3055         (maintenance_check_psymtabs): Use ranged for.
3056         * psymtab.h (class objfile_psymtabs): New.
3057         (require_partial_symbols): Return objfile_psymtabs.
3058         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3059
3060 2019-01-09  Tom Tromey  <tom@tromey.com>
3061
3062         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3063         (find_pc_mapped_section, list_overlays_command)
3064         (map_overlay_command, unmap_overlay_command)
3065         (simple_overlay_update): Use all_objfiles.
3066         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3067         * printcmd.c (info_symbol_command): Use all_objfiles.
3068         * objfiles.h (ALL_OBJSECTIONS): Remove.
3069         * maint.c (maintenance_translate_address): Use all_objfiles.
3070         * gcore.c (gcore_create_callback): Use all_objfiles.
3071         (objfile_find_memory_regions): Likewise.
3072
3073 2019-01-09  Tom Tromey  <tom@tromey.com>
3074
3075         * symtab.c (find_line_symtab, info_sources_command)
3076         (make_source_files_completion_list): Use objfile_compunits.
3077         * source.c (select_source_symtab): Use objfile_compunits.
3078         * objfiles.h (struct objfile): Update comment.
3079         (ALL_OBJFILES): Remove.
3080         (ALL_FILETABS): Remove.
3081         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3082         objfile_compunits.
3083
3084 2019-01-09  Tom Tromey  <tom@tromey.com>
3085
3086         * symmisc.c (print_objfile_statistics, dump_objfile)
3087         (maintenance_print_symbols): Use compunit_filetabs.
3088         * source.c (forget_cached_source_info_for_objfile): Use
3089         compunit_filetabs.
3090         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3091         (ALL_FILETABS): Use compunit_filetabs.
3092         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3093         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3094
3095 2019-01-09  Tom Tromey  <tom@tromey.com>
3096
3097         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3098         (compunit_filetabs): New.
3099         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3100         compunit_filetabs.
3101         (info_sources_command, make_source_files_completion_list): Remove
3102         declaration.
3103         * symmisc.c (print_objfile_statistics, dump_objfile)
3104         (maintenance_print_symbols): Remove declaration.
3105         (maintenance_info_symtabs): Use compunit_filetabs.
3106         (maintenance_info_line_tables): Likewise.
3107         * source.c (select_source_symtab): Change local variable name.
3108         (forget_cached_source_info_for_objfile): Remove declaration.
3109         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3110         * objfiles.c (objfile_relocate1): Remove declaration.
3111         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3112         declaration.
3113         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3114         * coffread.c (coff_symtab_read): Remove declaration.
3115         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3116         compunit_filetabs.
3117
3118 2019-01-09  Tom Tromey  <tom@tromey.com>
3119
3120         * symtab.c (lookup_objfile_from_block)
3121         (find_pc_sect_compunit_symtab, search_symbols)
3122         (default_collect_symbol_completion_matches_break_on): Use
3123         objfile_compunits.
3124         * objfiles.h (ALL_COMPUNITS): Remove.
3125         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3126         * cp-support.c (add_symbol_overload_list_qualified): Use
3127         objfile_compunits.
3128         * ada-lang.c (ada_collect_symbol_completion_matches)
3129         (ada_add_global_exceptions): Use objfile_compunits.
3130
3131 2019-01-09  Tom Tromey  <tom@tromey.com>
3132
3133         * source.c (select_source_symtab)
3134         (forget_cached_source_info_for_objfile): Remove declaration.
3135         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3136         declaration.
3137         * maint.c (count_symtabs_and_blocks): Remove declaration.
3138         * cp-support.c (add_symbol_overload_list_qualified): Remove
3139         declaration.
3140         * coffread.c (coff_symtab_read): Remove declaration.
3141         * symtab.c (lookup_symbol_in_objfile_symtabs)
3142         (basic_lookup_transparent_type_1): Use objfile_compunits.
3143         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3144         (info_sources_command, search_symbols)
3145         (default_collect_symbol_completion_matches_break_on)
3146         (make_source_files_completion_list): Remove declaration.
3147         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3148         (ada_collect_symbol_completion_matches)
3149         (ada_add_global_exceptions): Remove declaration.
3150         * linespec.c (iterate_over_all_matching_symtabs): Use
3151         objfile_compunits.
3152         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3153         (class objfile_compunits): New.
3154         (ALL_COMPUNITS): Use objfile_compunits.
3155         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3156         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3157         objfile_compunits.
3158         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3159
3160 2019-01-09  Tom Tromey  <tom@tromey.com>
3161
3162         * symtab.c (search_symbols)
3163         (default_collect_symbol_completion_matches_break_on): Use
3164         objfile_msymbols.
3165         * ada-lang.c (ada_lookup_simple_minsym)
3166         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3167         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3168         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3169         objfile_msymbols.
3170         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3171         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3172         * objc-lang.c (find_methods): Use objfile_msymbols.
3173         (info_selectors_command, info_classes_command): Likewise.
3174         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3175         * objfiles.h (class objfile_msymbols): New.
3176         (ALL_OBJFILE_MSYMBOLS): Remove.
3177         (ALL_MSYMBOLS): Remove.
3178
3179 2019-01-09  Tom Tromey  <tom@tromey.com>
3180
3181         * common/next-iterator.h (next_adapter): Add Iterator template
3182         parameter.
3183         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3184         (class all_objfiles_safe): New.
3185         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3186         * objfiles.c (put_objfile_before): Update comment.
3187         (add_separate_debug_objfile): Likewise.
3188         (free_all_objfiles): Use all_objfiles_safe.
3189         (objfile_purge_solibs): Likewise.
3190
3191 2019-01-09  Tom Tromey  <tom@tromey.com>
3192
3193         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3194         (expand_symtab_containing_pc, lookup_static_symbol)
3195         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3196         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3197         all_objfiles.
3198         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3199         * breakpoint.c (create_overlay_event_breakpoint)
3200         (create_longjmp_master_breakpoint)
3201         (create_std_terminate_master_breakpoint)
3202         (create_exception_master_breakpoint): Use all_objfiles.
3203         * linux-thread-db.c (try_thread_db_load_from_pdir)
3204         (has_libpthread): Use all_objfiles.
3205         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3206         * linespec.c (iterate_over_all_matching_symtabs)
3207         (search_minsyms_for_name): Use all_objfiles.
3208         * maint.c (maintenance_info_sections): Use all_objfiles.
3209         * main.c (captured_main_1): Use all_objfiles.
3210         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3211         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3212         * guile/scm-pretty-print.c
3213         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3214         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3215         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3216         (maintenance_print_msymbols): Use all_objfiles.
3217         * source.c (select_source_symtab): Use all_objfiles.
3218         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3219         * symfile.c (remove_symbol_file_command)
3220         (expand_symtabs_matching, map_symbol_filenames): Use
3221         all_objfiles.
3222         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3223         all_objfiles.
3224         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3225         * objc-lang.c (find_methods): Use all_objfiles.
3226         * objfiles.c (have_partial_symbols, have_full_symbols)
3227         (have_minimal_symbols, qsort_cmp)
3228         (default_iterate_over_objfiles_in_search_order): Use
3229         all_objfiles.
3230         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3231         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3232         (maintenance_check_psymtabs): Use all_objfiles.
3233         (ALL_PSYMTABS): Remove.
3234         * compile/compile-object-run.c (do_module_cleanup): Use
3235         all_objfiles.
3236         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3237         * cp-support.c (add_symbol_overload_list_qualified): Use
3238         all_objfiles.
3239         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3240         Use all_objfiles.
3241         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3242         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3243         all_objfiles.
3244         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3245         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3246         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3247         Uses all_objfiles.
3248         * solib.c (solib_read_symbols): Use all_objfiles
3249
3250 2019-01-09  Tom Tromey  <tom@tromey.com>
3251
3252         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3253         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3254         all_objfiles.
3255         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3256         * symmisc.c (print_symbol_bcache_statistics)
3257         (print_objfile_statistics, maintenance_print_objfiles)
3258         (maintenance_info_symtabs, maintenance_check_symtabs)
3259         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3260         all_objfiles.
3261         * source.c (forget_cached_source_info): Use all_objfiles.
3262         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3263         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3264         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3265         * objfiles.c (update_section_map): Use all_objfiles.
3266         (shared_objfile_contains_address_p): Likewise.
3267         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3268         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3269
3270 2019-01-09  Tom Tromey  <tom@tromey.com>
3271
3272         * common/next-iterator.h: New file.
3273         * objfiles.h (class all_objfiles): New.
3274         (struct objfile_iterator): New.
3275
3276 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3277
3278         * NEWS: Move the description of the changed "frame", "select-frame",
3279          and "info frame" commands to the Changed commands section.
3280
3281 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3282
3283         * gdbtypes.c (check_stub_method_group): Remove handling of old
3284         mangling schemes.
3285         * linespec.c (find_methods): Likewise.
3286         * stabsread.c (read_member_functions): Likewise.
3287         * valops.c (search_struct_method): Likewise.
3288         (value_struct_elt_for_reference): Likewise.
3289         * NEWS: Mention this change.
3290
3291 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3292
3293         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3294         print_source_lines.
3295         * source.c (print_source_lines_base): Update line number check.
3296         (print_source_lines): New function.
3297         (source_lines_range::source_lines_range): New function.
3298         * source.h (class source_lines_range): New class.
3299         (print_source_lines): New declaration.
3300
3301 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3302
3303         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3304
3305 2019-01-08  Tom Tromey  <tom@tromey.com>
3306             Simon Marchi  <simon.marchi@ericsson.com>
3307
3308         PR gdb/24060
3309         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3310         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3311         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3312         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3313         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3314         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3315
3316 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3317
3318         * source.c (select_source_symtab): Move header comment to
3319         declaration in source.h.
3320         (forget_cached_source_info_for_objfile): Likewise.
3321         (forget_cached_source_info): Likewise.
3322         (identify_source_line): Likewise.
3323         * source.h (identify_source_line): Move declaration from symtab.h
3324         and add comment from source.c
3325         (print_source_lines): Likewise.
3326         (forget_cached_source_info_for_objfile): Likewise.
3327         (forget_cached_source_info): Likewise.
3328         (select_source_symtab): Likewise.
3329         (enum print_source_lines_flag): Move definition from symtab.h.
3330         * symtab.h (identify_source_line): Move declaration to source.h.
3331         (print_source_lines): Likewise.
3332         (forget_cached_source_info_for_objfile): Likewise.
3333         (forget_cached_source_info): Likewise.
3334         (select_source_symtab): Likewise.
3335         (enum print_source_lines_flag): Move definition to source.h.
3336         * tui/tui-hooks.c: Add 'source.h' include.
3337
3338 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3339
3340         * source.c (print_source_lines_base): Handle requests to print
3341         reverse line number sequences, and guard against empty lines
3342         string.
3343
3344 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3345
3346         * source.c (print_source_lines_base): Fix skip of '\r' if next
3347         character is '\n'.
3348
3349 2019-01-06  Tom Tromey  <tom@tromey.com>
3350
3351         * c-exp.y (struct c_parse_state) <macro_original_text,
3352         expansion_obstack>: New member.
3353         (macro_original_text, expansion_obstack): Remove globals.
3354         (scan_macro_expansion, scanning_macro_expansion)
3355         (finished_macro_expansion): Update.
3356         (scan_macro_cleanup): Remove.
3357         (yylex, c_parse): Update.
3358
3359 2019-01-06  Tom Tromey  <tom@tromey.com>
3360
3361         * c-exp.y (struct c_parse_state) <strings>: New member.
3362         (operator_stoken): Update.
3363
3364 2019-01-06  Tom Tromey  <tom@tromey.com>
3365
3366         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3367         (union type_stack_elt) <typelist_val>: Now a pointer to
3368         std::vector.
3369         (type_stack_cleanup): Don't declare.
3370         (push_typelist): Update.
3371         * parse.c (pop_typelist): Return a std::vector.
3372         (push_typelist): Take a std::vector.
3373         (follow_types): Update.  Do not free args.
3374         (type_stack_cleanup): Remove.
3375         * c-exp.y (struct c_parse_state): New.
3376         (cpstate): New global.
3377         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3378         (nonempty_typelist): Update.
3379         (func_mod): Create a new vector.
3380         (c_parse): Create a c_parse_state.
3381         (check_parameter_typelist): Do not delete params.
3382         (function_method): Update.  Do not delete type_list.
3383
3384 2019-01-06  Tom Tromey  <tom@tromey.com>
3385
3386         PR gdb/28155:
3387         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3388         check_typedef.
3389         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3390         (print_return_value): Likewise.
3391
3392 2019-01-05  Tom Tromey  <tom@tromey.com>
3393
3394         * contrib/cleanup_check.py: Remove.
3395         * contrib/gcc-with-excheck: Remove.
3396         * contrib/exsummary.py: Remove.
3397         * contrib/excheck.py: Remove.
3398
3399 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3400
3401         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3402         NULL. Initialize tpprev to NULL instead of assigning it
3403         to NULL on the next statement.
3404         * windows-nat.c (windows_delete_thread): Remove check for
3405         main_thread_id before printing thread exit notifications.
3406         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3407         Remove thread ID check against main_thread_id.
3408         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3409         windows_delete_thread.
3410         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3411
3412 2019-01-04  Tom Tromey  <tom@tromey.com>
3413
3414         * compile/compile.c (_initialize_compile): Use upper case for
3415         metasyntactic variables.
3416         * symmisc.c (_initialize_symmisc): Use upper case for
3417         metasyntactic variables.
3418         * psymtab.c (_initialize_psymtab): Use upper case for
3419         metasyntactic variables.
3420         * demangle.c (demangle_command): Use upper case for metasyntactic
3421         variables.
3422         (_initialize_demangler): Likewise.
3423         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3424         variables.
3425
3426 2019-01-03  Tom Tromey  <tom@tromey.com>
3427
3428         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3429
3430 2019-01-03  Tom Tromey  <tom@tromey.com>
3431
3432         * python/py-symtab.c (salpy_str): Update.
3433         (struct salpy_sal_object) <symtab>: Now a PyObject.
3434         (salpy_dealloc): Update.
3435         (del_objfile_sal): Use gdbpy_ref.
3436
3437 2019-01-03  Tom Tromey  <tom@tromey.com>
3438
3439         * python/py-type.c (convert_field): Use new_reference.  Return
3440         gdbpy_ref.
3441         (make_fielditem): Return gdbpy_ref.
3442         (typy_fields): Update.
3443         (typy_getitem): Update.
3444         (field_name): Return gdbpy_ref.  Use new_reference.
3445         (typy_iterator_iternext): Update.
3446
3447 2019-01-03  Tom Tromey  <tom@tromey.com>
3448
3449         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3450
3451 2019-01-03  Tom Tromey  <tom@tromey.com>
3452
3453         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3454         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3455         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3456         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3457         (pspy_set_type_printers): Likewise.
3458         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3459         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3460         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3461         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3462         (objfpy_set_type_printers): Likewise.
3463
3464 2019-01-03  Tom Tromey  <tom@tromey.com>
3465
3466         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3467         (gdbpy_print_stack): Use gdbpy_err_fetch.
3468         * python/python-internal.h (class gdbpy_err_fetch): New class.
3469         (class gdbpy_enter) <m_error_type, m_error_value,
3470         m_error_traceback>: Remove.
3471         <m_error>: New member.
3472         (gdbpy_exception_to_string): Don't declare.
3473         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3474         * python/py-value.c (convert_value_from_python): Use
3475         gdbpy_err_fetch.
3476         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3477         gdbpy_exception_to_string.
3478         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3479         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3480         gdbpy_err_fetch.
3481
3482 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3483
3484         * linux-nat.c (delete_lwp_cleanup): Delete.
3485         (struct lwp_deleter): New struct.
3486         (lwp_info_up): New typedef.
3487         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3488         lwp_info_up.
3489
3490 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3491
3492         * linux-fork.c (class scoped_switch_fork_info): New class.
3493         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3494
3495 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3496
3497         * valops.c (find_overload_match): Remove use of null_cleanup, and
3498         calls to do_cleanups.
3499
3500 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3501
3502         * compile/compile-cplus-types.c
3503         (compile_cplus_instance::decl_name): Handle changes to
3504         cp_func_name.
3505         * cp-support.c (cp_func_name): Update header comment, update
3506         return type.
3507         * cp-support.h (cp_func_name): Update return type in declaration.
3508         * valops.c (find_overload_match): Move temp_func local to top
3509         level of function and change its type.  Use temp_func to hold and
3510         delete temporary string obtained from cp_func_name.
3511
3512 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3513
3514         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3515         gdb::char_vector, remove cleanup, and update uses of `msg`.
3516
3517 2019-01-03  Jim Wilson  <jimw@sifive.com>
3518
3519         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3520
3521 2019-01-02  Tom Tromey  <tom@tromey.com>
3522
3523         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3524         (tdesc_parse_xml): Remove cleanups.
3525         * target-descriptions.h (make_cleanup_free_target_description):
3526         Don't declare.
3527         (target_desc_deleter): New struct.
3528         (target_desc_up): New typedef.
3529         * target-descriptions.c (target_desc_deleter::operator()): Rename
3530         from free_target_description.
3531         (make_cleanup_free_target_description): Remove.
3532
3533 2019-01-02  Tom Tromey  <tom@tromey.com>
3534
3535         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3536         constructor, destructor.
3537         (linespec_parser): Remove typedef.
3538         (~linespec_parser): Rename from linespec_parser_delete.
3539         (linespec_lex_to_end, linespec_complete_label)
3540         (linespec_complete): Update.
3541         (decode_line_full): Remove cleanups.
3542         (decode_line_1): Update.
3543
3544 2019-01-02  Tom Tromey  <tom@tromey.com>
3545
3546         * python/python-internal.h (inferior_to_inferior_object): Change
3547         return type.
3548         * python/py-exitedevent.c (create_exited_event_object): Update.
3549         * python/py-inferior.c (inferior_to_inferior_object): Return
3550         gdbpy_ref.
3551         (python_new_inferior, python_inferior_deleted)
3552         (thread_to_thread_object, delete_thread_object)
3553         (build_inferior_list, gdbpy_selected_inferior): Update.
3554         * python/py-infthread.c (create_thread_object): Update.  Also fail
3555         if inferior_to_inferior_object fails.
3556
3557 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3558
3559         * inferior.h (class inferior) <displaced_step_state>: New field.
3560         * infrun.h (struct displaced_step_state): Move here from
3561         infrun.c.  Initialize fields, add constructor.
3562         <inf>: Remove field.
3563         <reset>: New method.
3564         * infrun.c (struct displaced_step_inferior_state): Move to
3565         infrun.h.
3566         (displaced_step_inferior_states): Remove.
3567         (get_displaced_stepping_state): Adust.
3568         (displaced_step_in_progress_any_inferior): Adjust.
3569         (displaced_step_in_progress_thread): Adjust.
3570         (displaced_step_in_progress): Adjust.
3571         (add_displaced_stepping_state): Remove.
3572         (get_displaced_step_closure_by_addr): Adjust.
3573         (remove_displaced_stepping_state): Remove.
3574         (infrun_inferior_exit): Call displaced_step_state.reset.
3575         (use_displaced_stepping): Don't check for NULL.
3576         (displaced_step_prepare_throw): Call
3577         get_displaced_stepping_state.
3578         (displaced_step_fixup): Don't check for NULL.
3579         (prepare_for_detach): Don't check for NULL.
3580
3581 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3582
3583         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3584          in case of call that did not complete.
3585
3586 2019-01-02  Andrey Utkin  <autkin@undo.io>
3587
3588         * symfile.c (find_separate_debug_file): Fix search of debug files for
3589         remote debuggee.
3590
3591 2019-01-02  Tom Tromey  <tom@tromey.com>
3592
3593         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3594         indentation.
3595         * python/py-frame.c (frapy_older): Remove cast.
3596         (frapy_newer): Likewise.
3597         * python/py-breakpoint.c (local_setattro): Remove cast.
3598         * python/py-arch.c (archpy_name): Remove local variable.
3599         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3600
3601 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3602
3603         * unittests/basic_string_view/element_access/char/empty.cc:
3604         Fix year range in copyright header.
3605
3606 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3607
3608         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3609         Delete.
3610         <operator==>: Update with for removed field.
3611         <hash>: Likewise.
3612         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3613         <isa_features>: ...this.
3614         <abi_features>: New field.
3615         (riscv_isa_flen): Update comment.
3616         (riscv_abi_xlen): New declaration.
3617         (riscv_abi_flen): New declaration.
3618         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3619         isa_features.
3620         (riscv_abi_xlen): New function.
3621         (riscv_isa_flen): Update to get answer from isa_features.
3622         (riscv_abi_flen): New function.
3623         (riscv_has_fp_abi): Update to get answer from abi_features.
3624         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3625         xlen and flen.
3626         (riscv_call_info) <xlen, flen>: Update comment.
3627         (riscv_call_arg_struct): Remove invalid assertions
3628         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3629         is removed.
3630         (riscv_gdbarch_init): Gather isa features and abi features
3631         separately, ensure both match on the gdbarch when reusing an old
3632         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3633         a target with 64-bit float hardware.
3634
3635 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3636
3637         * source.c (search_command_helper): Stop reverse search
3638         when line 1 has been searched.
3639
3640 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3641
3642         * record-full.c (record_full_base_target::close): Rewrite
3643         record_full_core_buf_list free logic.
3644
3645 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3646
3647         * break-catch-syscall.c (print_one_catch_syscall): xfree
3648         the last text.
3649
3650 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3651
3652         * top.c (print_gdb_version): Update Copyright year in version
3653         message.
3654
3655 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3656
3657         Update copyright year range in all GDB files.
3658
3659 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
3660
3661         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
3662
3663 For older changes see ChangeLog-2018.
3664 \f
3665 Local Variables:
3666 mode: change-log
3667 left-margin: 8
3668 fill-column: 74
3669 version-control: never
3670 coding: utf-8
3671 End:
3672