750ce86843338742ebae63b458f7182be949cdb4
[external/binutils.git] / gdb / ChangeLog
1 2019-08-13  Tom Tromey  <tom@tromey.com>
2
3         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
4         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
6         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
7         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
8         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
9         ... here.
10
11 2019-08-13  Tom Tromey  <tom@tromey.com>
12
13         * tui/tui-winsource.h (struct tui_source_window_base)
14         <update_exec_info>: Declare.
15         (tui_update_exec_info): Don't declare.
16         * tui/tui-winsource.c (tui_update_source_window_as_is)
17         (tui_source_window_base::refresh_all)
18         (tui_update_all_breakpoint_info): Update.
19         (tui_source_window_base::update_exec_info): Rename from
20         tui_update_exec_info.
21         * tui/tui-stack.c (tui_show_frame_info): Update.
22
23 2019-08-13  Tom Tromey  <tom@tromey.com>
24
25         * tui/tui-winsource.h (struct tui_source_window_base)
26         <set_exec_info_content>: Declare.
27         (tui_set_exec_info_content): Don't declare.
28         * tui/tui-winsource.c
29         (tui_source_window_base::set_exec_info_content): Rename from
30         tui_set_exec_info_content.
31         (tui_update_exec_info): Update.
32
33 2019-08-13  Tom Tromey  <tom@tromey.com>
34
35         * tui/tui-winsource.h (struct tui_source_window_base)
36         <show_source_content>: Declare.
37         (tui_show_source_content): Don't declare.
38         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
39         (tui_source_window_base::show_source_content): Rename from
40         tui_show_source_content.
41         (tui_source_window_base::refresh_all): Update.
42         * tui/tui-layout.c (show_source_disasm_command)
43         (show_source_or_disasm_and_command): Update.
44
45 2019-08-13  Tom Tromey  <tom@tromey.com>
46
47         * tui/tui-winsource.c (tui_erase_source_content)
48         (tui_show_source_content, tui_source_window_base::refresh_all):
49         Update.
50         * tui/tui-wingeneral.h
51         (tui_check_and_display_highlight_if_needed): Don't declare.
52         * tui/tui-wingeneral.c
53         (tui_win_info::check_and_display_highlight_if_needed): Rename from
54         check_and_display_highlight_if_needed.
55         * tui/tui-win.c (tui_rehighlight_all)
56         (tui_win_info::make_visible_with_new_height): Update.
57         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
58         (tui_data_window::erase_data_content)
59         (tui_data_window::display_all_data): Update.
60         * tui/tui-data.h (struct tui_win_info)
61         <check_and_display_highlight_if_needed>: Declare.
62
63 2019-08-13  Tom Tromey  <tom@tromey.com>
64
65         * tui/tui-win.c (tui_resize_all): Call
66         tui_delete_invisible_windows.
67         * tui/tui-layout.c (show_layout): Call
68         tui_delete_invisible_windows.
69         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
70         * tui/tui-data.c (tui_delete_invisible_windows): New function.
71
72 2019-08-13  Tom Tromey  <tom@tromey.com>
73
74         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
75         tui_add_win_to_layout.
76
77 2019-08-13  Tom Tromey  <tom@tromey.com>
78
79         * tui/tui-layout.h (tui_default_win_height): Don't declare.
80         * tui/tui-layout.c (tui_default_win_height): Now static.
81
82 2019-08-13  Tom Tromey  <tom@tromey.com>
83
84         * tui/tui-layout.c (show_layout): Unify all layout cases into a
85         single switch.
86         (show_source_disasm_command, show_source_or_disasm_and_command):
87         Don't check current layout.
88
89 2019-08-13  Tom Tromey  <tom@tromey.com>
90
91         * tui/tui-wingeneral.c (make_all_visible): Remove.
92         (tui_make_all_invisible): Simplify.
93         * tui/tui-layout.c (tui_make_all_invisible): Move from
94         tui-wingeneral.c; simplify.
95         (show_layout): Hoist call to tui_make_all_invisible.
96         (show_data): Don't call tui_make_all_invisible.
97
98 2019-08-13  Tom Tromey  <tom@tromey.com>
99
100         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
101         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
102
103 2019-08-13  Tom Tromey  <tom@tromey.com>
104
105         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
106         tui-data.c.
107         (show_source_disasm_command, show_data)
108         (show_source_or_disasm_and_command): Don't use
109         tui_set_current_layout_to.
110         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
111         * tui/tui-data.c (current_layout, tui_current_layout): Move to
112         tui-layout.c.
113         (tui_set_current_layout_to): Remove.
114
115 2019-08-13  Tom Tromey  <tom@tromey.com>
116
117         * tui/tui-layout.c (tui_set_layout): Update.
118         * tui/tui-data.h (struct tui_layout_def): Remove.
119         (tui_layout_def): Don't declare.
120         * tui/tui-data.c (layout_def): Remove.
121         (tui_layout_def): Remove.
122
123 2019-08-13  Tom Tromey  <tom@tromey.com>
124
125         * tui/tui-winsource.h (struct tui_source_window_base)
126         <clear_detail>: No longer "override".
127         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
128         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
129         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
130         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
131         Remove.
132         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
133
134 2019-08-13  Tom Tromey  <tromey@adacore.com>
135
136         * tracepoint.c: Don't include readline.h or history.h.
137
138 2019-08-12  Tom Tromey  <tom@tromey.com>
139
140         * configure: Rebuild.
141         * configure.ac: Check for readline 7.
142         * NEWS: Mention readline 7 requirement.
143         * README: Update.
144
145 2019-08-12  Tom Tromey  <tom@tromey.com>
146
147         * mingw-hdep.c (gdb_select): Remove readline hack.
148
149 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
150
151         * blockframe.c (find_pc_partial_function): Set *block to nullptr
152         when the function fails.
153
154 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
155
156         * s390-tdep.c (s390_type_align): New function.
157         (s390_gdbarch_init): Set it as type_align gdbarch method.
158
159 2019-08-09  Tom de Vries  <tdevries@suse.de>
160
161         PR gdb/24591
162         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
163         pc_low with relocation offset.
164
165 2019-08-07  Tom Tromey  <tromey@adacore.com>
166
167         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
168         (print_frame_args): Update.
169         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
170         Update.
171         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
172         * frame.h (struct frame_arg): Add initializers.
173         <error>: Now a unique_xmalloc_ptr.
174
175 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
176
177         * NEWS: Expand the Pointer Authentication entry.
178         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
179         (aarch64_frame_unmask_lr): ... to this.
180         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
181         Call aarch64_frame_unmask_lr.
182         * frame.c (struct frame_info): Add "masked" variable.
183         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
184         (fprint_frame): Check for masked pc.
185         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
186         declarations.
187         * python/py-framefilter.c (py_print_frame): Check for masked pc.
188         * stack.c (print_frame): Check for masked pc.
189
190 2019-08-06  Tom Tromey  <tom@tromey.com>
191
192         * stabsread.c (patch_block_stabs, read_one_struct_field)
193         (read_enum_type): Use obstack_strndup.
194         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
195         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
196         * dwarf2read.c (guess_full_die_structure_name)
197         (anonymous_struct_prefix): Use obstack_strndup.
198         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
199         * c-exp.y (yylex): Use obstack_strndup.
200         * ada-exp.y (write_object_renaming, write_ambiguous_var)
201         (write_var_or_type): Use obstack_strndup.
202
203 2019-08-06  Tom Tromey  <tom@tromey.com>
204
205         * symfile.c (reread_symbols): Use obstack_strdup.
206         * stabsread.c (read_type): Use obstack_strdup.
207         * gdb_obstack.h (obstack_strdup): New overload.
208         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
209         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
210         (dwarf2_canonicalize_name): Use obstack_strdup.
211         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
212         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
213         Use obstack_strdup.
214
215 2019-08-06  Tom Tromey  <tom@tromey.com>
216
217         * gdb_obstack.h (obstack_strdup): Define.
218         * gdb_obstack.c (obstack_strdup): Don't define.
219
220 2019-08-06  Tom Tromey  <tom@tromey.com>
221
222         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
223         obstack_strdup.
224         * typeprint.c (typedef_hash_table::find_global_typedef): Use
225         obstack_strdup.
226         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
227         * stabsread.c (common_block_start): Use obstack_strdup.
228         * objfiles.c (set_objfile_main_name, objfile): Use
229         obstack_strdup.
230         * namespace.c (add_using_directive): Use obstack_strdup.
231         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
232         * jit.c (finalize_symtab): Use obstack_strdup.
233         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
234         (guess_partial_die_structure_name, partial_die_info::fixup)
235         (dwarf2_name): Use obstack_strdup.
236         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
237         obstack_strdup.
238         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
239         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
240         obstack_strdup.
241         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
242
243 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
244
245         * unittests/help-doc-selftests.c: New file.
246         * Makefile.in: Add the new file.
247
248 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
249
250         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
251         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
252         the full first line, except when FOR_VALUE_PREFIX.  In this case,
253         the trailing '.' is not output, and the first character is uppercased.
254         (print_help_for_command): Update call to print_doc_line.
255         (print_doc_of_command): Likewise.
256         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
257         * cli/cli-option.c (append_indented_doc): Do not append newline.
258         (build_help_option): Append newline after first appended_indented_doc
259         only if a second call is done.
260         (build_help): Append 2 new lines before each option, except the first
261         one.
262         * compile/compile.c (_initialize_compile): Add new lines after
263         %OPTIONS%, when not at the end of the help.
264         Change help doc or code
265         producing the help doc to respect the invariants.
266         * maint-test-options.c (_initialize_maint_test_options): Likewise.
267         Also removed the new line after 'Options:', as all other commands
268         do not put an empty line between 'Options:' and the first option.
269         * printcmd.c (_initialize_printcmd): Likewise.
270         * stack.c (_initialize_stack): Likewise.
271         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
272         incorrectly telling COMMAND is optional.
273         * ada-lang.c (_initialize_ada_language): Change help doc or code
274         producing the help doc to respect the invariants.
275         * ada-tasks.c (_initialize_ada_tasks): Likewise.
276         * breakpoint.c (_initialize_breakpoint): Likewise.
277         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
278         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
279         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
280         * cli/cli-style.c (cli_style_option::add_setshow_commands,
281         _initialize_cli_style): Likewise.
282         * corelow.c (core_target_info): Likewise.
283         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
284         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
285         * filesystem.c (_initialize_filesystem): Likewise.
286         * frame.c (_initialize_frame): Likewise.
287         * gnu-nat.c (add_task_commands): Likewise.
288         * infcall.c (_initialize_infcall): Likewise.
289         * infcmd.c (_initialize_infcmd): Likewise.
290         * interps.c (_initialize_interpreter): Likewise.
291         * language.c (_initialize_language): Likewise.
292         * linux-fork.c (_initialize_linux_fork): Likewise.
293         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
294         * maint.c (_initialize_maint_cmds): Likewise.
295         * memattr.c (_initialize_mem): Likewise.
296         * printcmd.c (_initialize_printcmd): Likewise.
297         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
298         _RegEx): Likewise.
299         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
300         * record-btrace.c (_initialize_record_btrace): Likewise.
301         * record-full.c (_initialize_record_full): Likewise.
302         * record.c (_initialize_record): Likewise.
303         * regcache-dump.c (_initialize_regcache_dump): Likewise.
304         * regcache.c (_initialize_regcache): Likewise.
305         * remote.c (add_packet_config_cmd, init_remote_threadtests,
306         _initialize_remote): Likewise.
307         * ser-tcp.c (_initialize_ser_tcp): Likewise.
308         * serial.c (_initialize_serial): Likewise.
309         * skip.c (_initialize_step_skip): Likewise.
310         * source.c (_initialize_source): Likewise.
311         * stack.c (_initialize_stack): Likewise.
312         * symfile.c (_initialize_symfile): Likewise.
313         * symtab.c (_initialize_symtab): Likewise.
314         * target-descriptions.c (_initialize_target_descriptions): Likewise.
315         * top.c (init_main): Likewise.
316         * tracefile-tfile.c (tfile_target_info): Likewise.
317         * tracepoint.c (_initialize_tracepoint): Likewise.
318         * tui/tui-win.c (_initialize_tui_win): Likewise.
319         * utils.c (add_internal_problem_command): Likewise.
320         * valprint.c (value_print_option_defs): Likewise.
321
322 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
323
324         PR build/24886
325         * configure.ac: Drop enable-libmcheck support.
326         * configure, config.in: Rebuild.
327         * libmcheck.m4: Remove.
328         * acinclude.m4: Don't include it.
329         * Makefile.in: Don't distribute it.
330         * top.c (print_gdb_configuration): Don't mention it.
331
332 2019-08-06  Tom Tromey  <tom@tromey.com>
333
334         * utils.c (set_output_style): Sometimes pass stream to
335         emit_style_escape.
336         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
337         * record-btrace.c (btrace_insn_history): Update.
338         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
339         method.
340         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
341         Update initializers.
342         <m_uiout>: New field.
343         <m_di>: Move lower.
344         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
345         Remove "uiout" parameter.
346         (dump_insns): Update.
347         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
348         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
349
350 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
351
352         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
353         (error_in_psymtab_expansion): Likewise.
354         (lookup_symbol_via_quick_fns): Likewise.
355         (basic_lookup_transparent_type_quick): Likewise.
356         (basic_lookup_transparent_type_1): Likewise.
357
358 2019-08-06  Tom Tromey  <tromey@adacore.com>
359
360         * source.c (last_source_error): Now bool.
361         (print_source_lines_base): Make "noprint" bool.  Only open
362         source file when last_source_visited changes.
363
364 2019-08-06  Tom Tromey  <tromey@adacore.com>
365
366         * annotate.c (annotate_source_line): Use g_source_cache.
367         * source-cache.c (source_cache::get_plain_source_lines): Change
368         parameters.  Populate m_offset_cache.
369         (source_cache::ensure): New method.
370         (source_cache::get_line_charpos): New method.
371         (extract_lines): Move lower.  Change parameters.
372         (source_cache::get_source_lines): Move lower.
373         * source-cache.h (class source_cache): Update comment.
374         <get_line_charpos>: New method.
375         <get_source_lines>: Update comment.
376         <clear>: Clear m_offset_cache.
377         <get_plain_source_lines>: Change parameters.
378         <ensure>: New method
379         <m_offset_cache>: New member.
380         * source.c (forget_cached_source_info_for_objfile): Update.
381         (info_source_command): Use g_source_cache.
382         (find_source_lines, open_source_file_with_line_charpos): Remove.
383         (print_source_lines_base, search_command_helper): Use g_source_cache.
384         * source.h (open_source_file_with_line_charpos): Don't declare.
385         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
386         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
387         Use g_source_cache.
388
389 2019-08-06  Tom Tromey  <tromey@adacore.com>
390
391         * source-cache.c (source_cache::get_plain_source_lines):
392         Remove "first_line" and "last_line" parameters.
393         (source_cache::get_source_lines): Cache plain text.
394         * source-cache.h (class source_cache)
395         <get_plain_source_lines>: Update.
396
397 2019-08-06  Tom Tromey  <tromey@adacore.com>
398
399         * source-cache.c (extract_lines): No longer a method.
400         Changed type of parameter.  Include final newline.
401         (selftests::extract_lines_test): New function.
402         (_initialize_source_cache): Likewise.
403         * source-cache.h (class source_cache)
404         <extract_lines>: Don't declare.
405
406 2019-08-06  Tom Tromey  <tromey@adacore.com>
407
408         * breakpoint.c (init_breakpoint_sal): Update.
409         (breakpoint): Update.
410         * breakpoint.h (struct breakpoint) <filter>: Now a
411         unique_xmalloc_ptr.
412
413 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
414
415         * NEWS: Mention dictionary access on blocks.
416         * python/py-block.c (blpy_getitem): New function.
417         (block_object_as_mapping): New struct.
418         (block_object_type): Use new struct for tp_as_mapping field.
419
420 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
421
422         * objfiles.h (objfile): Add a comment describing partial symbols.
423
424 2019-08-05  Tom Tromey  <tromey@adacore.com>
425
426         * compile/compile.c (_initialize_compile): Use _(), not N_().
427         * thread.c (_initialize_thread): Use _(), not N_().
428         * stack.c (_initialize_stack): Use _(), not N_().
429         * printcmd.c (_initialize_printcmd): Use _(), not N_().
430
431 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
432
433         * dwarf2read.c (struct dw2_symtab_iterator):
434         <want_specific_block>: Remove.
435         <block_index>: Change type to gdb::optional.
436         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
437         change type of BLOCK_INDEX parameter to gdb::optional.
438         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
439         (dw2_lookup_symbol): Don't pass argument for
440         WANT_SPECIFIC_BLOCK.
441         (dw2_expand_symtabs_for_function): Don't pass argument for
442         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
443         (class dw2_debug_names_iterator)
444         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
445         parameter, change BLOCK_INDEX type to gdb::optional.
446         <m_want_specific_block>: Remove.
447         <m_block_index>: Change type to gdb::optional.
448         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
449         gdb::optional.  Re-write in function of gdb::optional.
450         (dw2_debug_names_lookup_symbol): Don't pass argument for
451         WANT_SPECIFIC_BLOCK.
452         (dw2_debug_names_expand_symtabs_for_function): Don't pass
453         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
454         BLOCK_INDEX.
455
456 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
457
458         * NEWS: Mention changes to "info sources" command.
459
460 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
461
462         * symtab.c (filename_partial_match_opts): New struct type.
463         (struct output_source_filename_data): New members
464         regexp, c_regexp, partial_match.
465         (output_source_filename): Use new members to decide to print file.
466         (info_sources_option_defs): New variable.
467         (make_info_sources_options_def_group, print_info_sources_header,
468         info_sources_command_completer):
469         New functions.
470         (info_sources_command): Read new optional arguments.
471         (_initialize_symtab): Update info sources help.
472
473 2019-08-02  Alexandre Oliva <oliva@adacore.com>
474
475         * ada-lang.c (exception_support_info_v0): Renamed from...
476         (default_exception_support_info): ... this.  Create new
477         definition for v1.
478         (ada_has_this_exception_support): Look up catch_handlers_sym.
479         (ada_exception_support_info_sniffer): Try v0 after default.
480
481 2019-08-01  Tom Tromey  <tromey@adacore.com>
482
483         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
484         gdbarch.h.
485
486 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
487
488         * s12z-tdep.c: Fix include path for s12z-opc.h.
489
490 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
491
492         * NEWS: Require GNU make 3.82.
493
494 2019-07-16  Tom Tromey  <tom@tromey.com>
495
496         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
497         declare.
498
499 2019-07-30  Tom Tromey  <tromey@adacore.com>
500
501         * block.c (contained_in): Remove BLOCK_FUNCTION check.
502
503 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
504
505         * printcmd.c (print_address_symbolic): Print negative offsets.
506         (build_address_symbolic): Force signed arithmetic when computing
507         offset.
508
509 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
510
511         PR/24474: Add a function to lookup static variables.
512         * NEWS: Mention this new function.
513         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
514         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
515         * python/python.c (python_GdbMethods): Add new function.
516
517 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
518
519         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
520         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
521         (objfpy_lookup_static_symbol): New function.
522         (objfile_object_methods): Add new functions.
523
524 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
525
526         * NEWS: Mention 'set|show print frame-info'.  Mention new
527         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
528         backtrace argument.  Mention that python frame filtering code
529         is now consistent with what 'backtrace' command prints.
530
531 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
532
533         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
534         comments.
535         (print_frame_info_auto, print_frame_info_source_line,
536         print_frame_info_location, print_frame_info_source_and_location,
537         print_frame_info_location_and_address, print_frame_info_short_location):
538         New declarations.
539         (struct frame_print_options): New member print_frame_info.
540         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
541         * stack.h (get_user_print_what_frame_info): New declaration.
542         (frame_show_address): New declaration.
543         * stack.c (print_frame_arguments_choices): New value 'presence'.
544         (print_frame_info_auto, print_frame_info_source_line,
545         print_frame_info_location, print_frame_info_source_and_location,
546         print_frame_info_location_and_address, print_frame_info_short_location,
547         print_frame_info_choices, print_frame_info_print_what): New definitions.
548         (print_frame_args): Only print dots for args if print frame-arguments
549         is 'presence'.
550         (frame_print_option_defs): New element for "frame-info".
551         (get_user_print_what_frame_info): New function.
552         (frame_show_address): Make non static.  Move comment to stack.h.
553         (print_frame_info_to_print_what): New function.
554         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
555         to decide what to print.
556         (backtrace_command_1): Handle the new print_frame_arguments_presence
557         value.
558         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
559         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
560         (py_print_frame): In non-mi mode, use LOCATION as default for
561         print_what, similarly to frame information printed directly by
562         backtrace command. Handle frame-info user option in non MI mode.
563
564 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
565
566         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
567         Add case for debugging 32-bit target on 64-bit host.  Revise
568         comment.
569
570 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
571
572         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
573         instead of find_function_entry_range_from_pc.
574
575 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
576
577         * stack.c (find_frame_funname): Remove code which preferred
578         minsym over symtab sym in "certain pathological cases".
579
580         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
581         parameter.  Change type of "do_demangle" to bool.
582         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
583         Pass suitable "prefer_sym_over_minsym" flag to
584         build_address_symbolic().  Don't output "+" for negative offsets.
585         * printcmd.c (print_address_symbolic): Update invocation of
586         build_address_symbolic to include a "prefer_sym_over_minsym"
587         flag.
588         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
589         Restrict cases in which use of minimal symbol is preferred to that
590         of a found symbol.  Update comments.
591
592         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
593         for entry pc when entry pc is out of range for that FDE.
594
595 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
596
597         PR gdb/24839:
598         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
599         type.
600
601 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
602
603         * python/py-objfile.c (add_separate_debug_file): Fix comment about
604         this function's Python signature.
605
606
607 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
608
609         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
610         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
611         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
612         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
613         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
614
615
616 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
617
618         * h8300-tdep.c (h8300_register_name_common): New.
619         h8300_register_name): Use h8300_register_name_common.
620         (h8300s_register_name): Likewise.
621         (h8300sx_register_name): Likewise.
622         (h8300h_register_nam): New.
623         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
624
625
626 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
627
628         * arm-tdep.c (arm_skip_cmse_entry): New function.
629         (arm_is_sgstubs_section): New function.
630         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
631
632 2019-07-22  Tom Tromey  <tom@tromey.com>
633
634         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
635         Don't self-assign.
636
637 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
638
639         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
640         type_print.
641
642 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
643
644         * symtab.c (search_symbols): Adjust msymbol matching type arrays
645         so that GDB doesn't match any msymbols when searching in the
646         TYPES_DOMAIN.
647         (print_symbol_info): Print using typedef_print or type_print based
648         on the type of the symbol.  Add updated FIXME comment moved from...
649         (_initialize_symtab): ... move and update FIXME comment to above.
650
651 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
652
653         * NEWS: Mention adding -q option to "info types".
654         * symtab.c (struct info_types_options): New struct.
655         (info_types_options_defs): New variable.
656         (make_info_types_options_def_group): New function.
657         (info_types_command): Use gdb::option framework to parse options.
658         (info_types_command_completer): New function.
659         (_initialize_symtab): Extend the help text on "info types" and
660         register command completer.
661
662 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
663
664         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
665         (lookup_symbol_in_objfile): Change int to block_enum and add a
666         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
667
668 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
669
670         * MAINTAINERS (Write After Approval): Add self.
671
672 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
673
674         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
675         instruction to the dummy code region.
676
677 2019-07-19  Tom Tromey  <tromey@adacore.com>
678
679         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
680         (ARGSUSED, PARAMS, __func__): Remove rules.
681
682 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
683
684         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
685         * features/arm/arm-with-iwmmxt.c: Remove.
686         * features/arm/arm-with-iwmmxt.xml: Remove.
687         * features/arm/arm-with-m-fpa-layout.c: Remove.
688         * features/arm/arm-with-m-fpa-layout.xml: Remove.
689         * features/arm/arm-with-m-vfp-d16.c: Remove.
690         * features/arm/arm-with-m-vfp-d16.xml: Remove.
691         * features/arm/arm-with-m.c: Remove.
692         * features/arm/arm-with-m.xml: Remove.
693         * features/arm/arm-with-neon.c: Remove.
694         * features/arm/arm-with-neon.xml: Remove.
695         * features/arm/arm-with-vfpv2.c: Remove.
696         * features/arm/arm-with-vfpv2.xml: Remove.
697         * features/arm/arm-with-vfpv3.c: Remove.
698         * features/arm/arm-with-vfpv3.xml: Remove.
699
700 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
701
702         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
703
704 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
705
706         * arch/aarch32.c (aarch32_create_target_description): Create
707         target descriptions using features.
708         * arch/arm.c (arm_create_target_description)
709         (arm_create_mprofile_target_description): Likewise.
710         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
711
712 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
713
714         * Makefile.in: Add new files.
715         * aarch32-tdep.c: New file.
716         * aarch32-tdep.h: New file.
717         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
718         Call aarch32_read_description.
719         * arch/aarch32.c: New file.
720         * arch/aarch32.h: New file.
721         * arch/arm.c (arm_create_target_description)
722         (arm_create_mprofile_target_description): New function.
723         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
724         (arm_create_target_description)
725         (arm_create_mprofile_target_description): New declaration.
726         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
727         read_description functions.
728         * arm-linux-nat.c (arm_linux_nat_target::read_description):
729         Likewise.
730         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
731         * arm-tdep.c (tdesc_arm_list): New variable.
732         (arm_register_g_packet_guesses): Call create description functions.
733         (arm_read_description) (arm_read_mprofile_description): New
734         function.
735         * arm-tdep.h (arm_read_description)
736         (arm_read_mprofile_description): Add declaration.
737         * configure.tgt: Add new files.
738
739 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
740
741         * top.c (new_ui_command): Open specified terminal just once.
742
743 2019-07-18  Tom Tromey  <tromey@adacore.com>
744
745         * symtab.c (main_name): Constify return type.
746         * symfile.c (set_initial_language): Update.
747         * symtab.h (main_name): Constify return type.
748
749 2019-07-17  Tom Tromey  <tom@tromey.com>
750
751         * tui/tui-winsource.c (tui_update_source_window)
752         (tui_update_source_window_as_is)
753         (tui_update_source_windows_with_line): Remove return.
754         * tui/tui-disasm.c (tui_show_disassem)
755         (tui_show_disassem_and_update_source): Remove return.
756         * tui/tui.c (tui_reset): Remove return.
757         * tui/tui-wingeneral.c
758         (tui_check_and_display_highlight_if_needed): Remove return.
759
760 2019-07-17  Tom Tromey  <tom@tromey.com>
761
762         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
763
764 2019-07-17  Tom Tromey  <tom@tromey.com>
765
766         * tui/tui-winsource.h (struct tui_exec_info_window)
767         (struct tui_source_window_base): Move from tui-data.h.
768         * tui/tui-winsource.c: Move many method definitions from
769         elsewhere.  Remove "structuring" comments.
770         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
771         (tui_source_window_base::refresh_window): Move to
772         tui-winsource.c.
773         * tui/tui-win.c (tui_source_window_base::refresh_all)
774         (tui_source_window_base::update_tab_width)
775         (tui_source_window_base::set_new_height)
776         (tui_source_window_base::do_make_visible_with_new_height): Move to
777         tui-winsource.c.
778         * tui/tui-source.h: Update.
779         * tui/tui-source.c (tui_source_window_base::reset): Move to
780         tui-winsource.c.
781         * tui/tui-disasm.h: Update.
782         * tui/tui-data.h (struct tui_exec_info_window): Move to
783         tui-winsource.h.
784         (struct tui_source_window_base): Likewise.
785         * tui/tui-data.c (tui_source_window_base::clear_detail)
786         (tui_source_window_base, ~tui_source_window_base): Move to
787         tui-winsource.c.
788
789 2019-07-17  Tom Tromey  <tom@tromey.com>
790
791         * tui/tui-win.c (tui_resize_all)
792         (tui_source_window_base::update_tab_width)
793         (tui_adjust_win_heights): Update.
794         (tui_win_info::make_invisible_and_set_new_height): Rename from
795         make_invisible_and_set_new_height.
796         * tui/tui-data.h (struct tui_win_info)
797         <make_invisible_and_set_new_height>: New method.
798
799 2019-07-17  Tom Tromey  <tom@tromey.com>
800
801         * tui/tui.c: Update.
802         * tui/tui-source.h (struct tui_source_window): Move from
803         tui-data.h.
804         * tui/tui-layout.c: Update.
805         * tui/tui-disasm.c: Update.
806         * tui/tui-data.h (struct tui_source_window): Move to
807         tui-source.h.
808
809 2019-07-17  Tom Tromey  <tom@tromey.com>
810
811         * tui/tui-disasm.h (struct tui_disasm_window): Move from
812         tui-data.h.
813         * tui/tui-data.h (struct tui_disasm_window): Move to
814         tui-disasm.h.
815
816 2019-07-17  Tom Tromey  <tom@tromey.com>
817
818         * tui/tui-regs.h (struct tui_data_item_window): Move from
819         tui-data.h.
820         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
821         * tui/tui-data.h (struct tui_data_item_window): Move to
822         tui-regs.h.
823         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
824
825 2019-07-17  Tom Tromey  <tom@tromey.com>
826
827         * tui/tui.c: Update.
828         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
829         (tui_cmd_window::max_height): Move to tui-command.c.
830         * tui/tui-layout.c: Update.
831         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
832         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
833         tui-command.c.
834         * tui/tui-command.h (struct tui_cmd_window): Move from
835         tui-data.h.
836         * tui/tui-command.c: Remove "structuring" comments.
837         (tui_cmd_window::clear_detail)
838         (tui_cmd_window::do_make_visible_with_new_height)
839         (tui_cmd_window::max_height): Move from elsewhere.
840
841 2019-07-17  Tom Tromey  <tom@tromey.com>
842
843         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
844         Now static.
845         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
846         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
847
848 2019-07-17  Tom Tromey  <tom@tromey.com>
849
850         * tui/tui.c: Update.
851         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
852         tui-regs.c.
853         * tui/tui-windata.h: Remove file.
854         * tui/tui-windata.c: Remove file.
855         * tui/tui-win.c (tui_data_window::set_new_height)
856         (tui_data_window::do_make_visible_with_new_height): Move to
857         tui-regs.c.
858         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
859         * tui/tui-regs.c: Remove "structuring" comments.
860         (tui_data_window::first_data_item_displayed)
861         (tui_data_window::delete_data_content_windows)
862         (tui_data_window::erase_data_content)
863         (tui_data_window::display_all_data)
864         (tui_data_window::refresh_all)
865         (tui_data_window::do_scroll_vertical)
866         (tui_data_window::clear_detail, tui_data_window::set_new_height)
867         (tui_data_window::do_make_visible_with_new_height)
868         (tui_data_window::refresh_window): Move from elsewhere.
869         (_initialize_tui_regs): Move to end of file.
870         * tui/tui-layout.c: Update.
871         * tui/tui-hooks.c: Update.
872         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
873         * tui/tui-data.c (tui_data_window::clear_detail): Move to
874         tui-regs.c.
875         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
876
877 2019-07-17  Tom Tromey  <tom@tromey.com>
878
879         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
880         seen.
881
882 2019-07-17  Tom Tromey  <tom@tromey.com>
883
884         * tui/tui-win.c (tui_source_window_base::set_new_height)
885         (tui_source_window_base::do_make_visible_with_new_height): Use
886         m_has_locator field directly.
887         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
888         method.
889         (struct tui_source_window_base) <has_locator>: Likewise.
890
891 2019-07-17  Tom Tromey  <tom@tromey.com>
892
893         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
894         Don't declare.
895         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
896         Remove.
897         * tui/tui-win.c (tui_source_window_base::set_new_height)
898         (tui_source_window_base::set_new_height)
899         (make_invisible_and_set_new_height)
900         (tui_source_window_base::do_make_visible_with_new_height)
901         (tui_source_window_base::do_make_visible_with_new_height):
902         Update.
903         * tui/tui-layout.c (show_source_disasm_command, show_data)
904         (show_source_or_disasm_and_command): Update.
905         * tui/tui-layout.c (show_layout): Update.
906
907 2019-07-17  Tom Tromey  <tom@tromey.com>
908
909         * tui/tui-layout.c (make_data_window): Remove.
910         (show_data): Unify creation and re-initialization cases.
911
912 2019-07-17  Tom Tromey  <tom@tromey.com>
913
914         * tui/tui-layout.c (make_source_window, make_disasm_window):
915         Remove.
916         (show_data): Unify creation and re-initialization cases.
917
918 2019-07-17  Tom Tromey  <tom@tromey.com>
919
920         * tui/tui-layout.c (make_command_window): Remove.
921         (show_source_disasm_command, show_source_or_disasm_and_command):
922         Unify creation and re-initialization cases.
923
924 2019-07-17  Tom Tromey  <tom@tromey.com>
925
926         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
927         creation and re-initialization cases.
928
929 2019-07-17  Tom Tromey  <tom@tromey.com>
930
931         * tui/tui-regs.c (tui_get_register): Return void.
932
933 2019-07-17  Tom Tromey  <tom@tromey.com>
934
935         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
936         Simplify.
937
938 2019-07-17  Tom Tromey  <tom@tromey.com>
939
940         * tui/tui-layout.c (show_source_disasm_command): Simplify window
941         resetting.
942
943 2019-07-17  Tom Tromey  <tom@tromey.com>
944
945         * tui/tui.h (tui_set_layout_by_name): Don't declare.
946         * tui/tui-regs.c (tui_reg_layout): New function.
947         (tui_show_registers, tui_reg_command): Use it.
948         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
949         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
950         parameters.
951         (tui_layout_command): Remove.
952
953 2019-07-17  Tom Tromey  <tom@tromey.com>
954
955         * tui/tui-layout.h (tui/tui-layout): Return void.
956         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
957
958 2019-07-17  Tom Tromey  <tom@tromey.com>
959
960         * tui/tui-layout.c (show_source_disasm_command, show_data):
961         Update.
962         (reset_locator): Remove.
963         (show_source_or_disasm_and_command): Update.
964
965 2019-07-17  Tom Tromey  <tom@tromey.com>
966
967         * tui/tui-source.c (tui_source_window_base::reset): Remove
968         win_type parameter.
969         * tui/tui-layout.c (make_command_window, make_source_window)
970         (make_disasm_window, make_data_window)
971         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
972         (reset_locator, show_source_or_disasm_and_command): Update.
973         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
974         win_type parameter.
975         (struct tui_source_window_base) <reset>: Likewise.
976
977 2019-07-17  Tom Tromey  <tom@tromey.com>
978
979         * tui/tui-layout.c (show_source_disasm_command): Use
980         reset_locator.
981         (reset_locator): New function.
982         (init_and_make_win): Remove.
983         (show_source_or_disasm_and_command): Use reset_locator.
984
985 2019-07-17  Tom Tromey  <tom@tromey.com>
986
987         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
988         condition.
989         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
990         Remove condition.
991         * tui/tui-source.c (tui_source_window_base::reset): New method.
992         * tui/tui-layout.c (make_command_window): Don't call
993         init_and_make_win.
994         (make_source_window, make_disasm_window): Don't call
995         make_source_or_disasm_window.
996         (make_data_window): Don't call init_and_make_win.  Change calling
997         convention.
998         (show_source_disasm_command, show_data): Simplify.
999         (make_source_or_disasm_window): Remove.
1000         (show_source_or_disasm_and_command): Simplify.
1001         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1002         (struct tui_source_window_base) <reset>: Likewise.
1003         <execution_info>: Remove initializer.
1004         * tui/tui-data.c (tui_source_window_base): Initialize
1005         execution_info.
1006
1007 2019-07-17  Tom Tromey  <tom@tromey.com>
1008
1009         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1010         variable.
1011
1012 2019-07-17  Tom Tromey  <tom@tromey.com>
1013
1014         * tui/tui.c (tui_rl_other_window): Update.
1015         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1016         superclass method first.  Always iterate over regs_content.
1017         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1018         method.
1019         * tui/tui-win.c (tui_set_focus_command): Update.
1020
1021 2019-07-17  Tom Tromey  <tom@tromey.com>
1022
1023         * tui/tui-win.c (tui_set_focus_command): Rename from
1024         tui_set_focus.  Call tui_enable.
1025         (tui_set_focus_command): Remove.
1026
1027 2019-07-17  Tom Tromey  <tom@tromey.com>
1028
1029         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1030         refresh_window.
1031         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1032         touchwin.
1033         (tui_data_window::refresh_window): Call refresh_window on data
1034         items.  Always call superclass refresh_window.
1035         (tui_win_info::refresh): Remove.
1036         (tui_source_window_base::refresh_window): Update.
1037         (tui_refresh_all): Update.
1038         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1039         refresh_window.
1040         (show_source_or_disasm_and_command): Likewise.
1041         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1042         (struct tui_source_window_base) <refresh>: Likewise.
1043
1044 2019-07-17  Tom Tromey  <tom@tromey.com>
1045
1046         * tui/tui-winsource.c (tui_clear_source_content)
1047         (tui_show_source_content): Update.
1048         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1049         whether content is empty.
1050         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1051         Remove.
1052
1053 2019-07-17  Tom Tromey  <tom@tromey.com>
1054
1055         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1056         window's contents.
1057         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1058         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1059
1060 2019-07-17  Tom Tromey  <tom@tromey.com>
1061
1062         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1063         (struct tui_data_item_window): Update.
1064
1065 2019-07-17  Tom Tromey  <tom@tromey.com>
1066
1067         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1068         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1069         defines.
1070
1071 2019-07-17  Tom Tromey  <tom@tromey.com>
1072
1073         * tui/tui-winsource.h (tui_erase_source_content)
1074         (tui_clear_source_content): Remove "display_prompt" parameter.
1075         * tui/tui-winsource.c (tui_update_source_window_as_is)
1076         (tui_update_source_windows_with_addr): Update.
1077         (tui_clear_source_content): Remove "display_prompt" parameter.
1078         (tui_erase_source_content): Likewise.  Simplify.
1079         (tui_show_source_content): Update.
1080         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1081         * tui/tui-stack.c (tui_show_frame_info): Update.
1082         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1083         Remove defines.
1084
1085 2019-07-17  Tom Tromey  <tom@tromey.com>
1086
1087         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1088         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1089         parameter.
1090         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1091         parameter.
1092
1093 2019-07-17  Tom Tromey  <tom@tromey.com>
1094
1095         * tui/tui-winsource.c (tui_clear_source_content)
1096         (tui_show_source_content, tui_show_exec_info_content)
1097         (tui_clear_exec_info_content): Update.
1098         * tui/tui-stack.c (tui_show_locator_content): Update.
1099         (tui_show_frame_info): Update.
1100         * tui/tui-source.h (tui_source_window): Don't declare.
1101         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1102         from tui_source_is_displayed.
1103         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1104         Remove field.
1105         (struct tui_source_window_base) <content_in_use>: New field.  Now
1106         bool.
1107         (struct tui_source_window) <showing_source_p>: New method.
1108         (TUI_SRC_WIN): Change cast.
1109         * tui/tui-data.c (tui_initialize_static_data): Update.
1110
1111 2019-07-17  Tom Tromey  <tom@tromey.com>
1112
1113         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1114         location_matches_p.
1115         * tui/tui-source.c (tui_source_window::location_matches_p): New
1116         method.
1117         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1118         method.
1119         * tui/tui-data.h (struct tui_source_window_base)
1120         <location_matches_p>: New method.
1121         (struct tui_source_window, struct tui_disasm_window)
1122         <location_matches_p>: Likewise.
1123
1124 2019-07-17  Tom Tromey  <tom@tromey.com>
1125
1126         * tui/tui-win.c (tui_set_win_height_command): Rename from
1127         tui_set_win_height.
1128         (tui_set_win_height_command): Remove.
1129
1130 2019-07-17  Tom Tromey  <tom@tromey.com>
1131
1132         * tui/tui-source.c (tui_source_window): New constructor.  Add
1133         observer.
1134         (~tui_source_window): New destructor.
1135         (tui_source_window::style_changed): New method.
1136         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1137         (tui_attach_detach_observers): Update.
1138         * tui/tui-data.h (struct tui_source_window): Make constructor not
1139         inline.  Add destructor.
1140         (struct tui_source_window) <style_changed>: New method.
1141         <m_observable>: New member.
1142
1143 2019-07-17  Tom Tromey  <tom@tromey.com>
1144
1145         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1146         * tui/tui-win.c (tui_resize_all): Fix typo.
1147
1148 2019-07-17  Tom Tromey  <tom@tromey.com>
1149
1150         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1151         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1152         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1153         * tui/tui-win.c (window_name_completer): Use foreach.
1154         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1155         (update_tab_width): Likewise.
1156         * tui/tui-layout.c (show_layout): Update.
1157         * tui/tui-data.h (class tui_window_iterator): New.
1158         (struct all_tui_windows): New.
1159         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1160
1161 2019-07-17  Tom Tromey  <tom@tromey.com>
1162
1163         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1164         parameter.  Don't reference globals.
1165         (tui_reg_command): Update.
1166
1167 2019-07-17  Tom Tromey  <tom@tromey.com>
1168
1169         * tui/tui-regs.c (tui_show_registers): Simplify.
1170
1171 2019-07-17  Tom Tromey  <tom@tromey.com>
1172
1173         * tui/tui-regs.c (tui_show_registers): Update.
1174         (tui_show_register_group): Add win_info parameter.
1175
1176 2019-07-17  Tom Tromey  <tom@tromey.com>
1177
1178         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1179         Rename from tui_display_reg_element_at_line.
1180         (tui_data_window::display_registers_from_line): Update.
1181         * tui/tui-data.h (struct tui_data_window)
1182         <display_reg_element_at_line>: New method.
1183
1184 2019-07-17  Tom Tromey  <tom@tromey.com>
1185
1186         * tui/tui-regs.h (tui_display_registers_from)
1187         (tui_display_registers_from_line): Don't declare.
1188         * tui/tui-windata.c (tui_data_window::display_all_data)
1189         (tui_data_window::refresh_all)
1190         (tui_data_window::do_scroll_vertical): Update.
1191         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1192         from tui_display_registers_from.
1193         (tui_display_reg_element_at_line): Update.
1194         (tui_data_window::display_registers_from_line): Rename from
1195         tui_display_registers_from_line.
1196         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1197         display_registers_from_line>: New methods.
1198
1199 2019-07-17  Tom Tromey  <tom@tromey.com>
1200
1201         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1202         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1203         from tui_erase_data_content.
1204         (tui_data_window::display_all_data)
1205         (tui_data_window::refresh_all)
1206         (tui_data_window::do_scroll_vertical): Update.
1207         * tui/tui-regs.c (tui_show_registers): Update.
1208         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1209         New method.
1210
1211 2019-07-17  Tom Tromey  <tom@tromey.com>
1212
1213         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1214         declare.
1215         * tui/tui-windata.c
1216         (tui_data_window::delete_data_content_windows): Rename from
1217         tui_delete_data_content_windows.
1218         (tui_data_window::display_all_data)
1219         (tui_data_window::do_scroll_vertical): Update.
1220         * tui/tui-data.h (struct tui_data_window)
1221         <delete_data_content_windows>: New method.
1222
1223 2019-07-17  Tom Tromey  <tom@tromey.com>
1224
1225         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1226         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1227
1228 2019-07-17  Tom Tromey  <tom@tromey.com>
1229
1230         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1231         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1232         from tui_display_all_data.
1233         * tui/tui-win.c
1234         (tui_data_window::do_make_visible_with_new_height): Update.
1235         * tui/tui-regs.c (tui_show_registers): Update.
1236         * tui/tui-layout.c (tui_set_layout): Update.
1237         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1238         method.
1239
1240 2019-07-17  Tom Tromey  <tom@tromey.com>
1241
1242         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1243         * tui/tui-windata.c (tui_display_data_from): Remove.
1244         (tui_data_window::refresh_all): Update.
1245
1246 2019-07-17  Tom Tromey  <tom@tromey.com>
1247
1248         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1249         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1250         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1251         tui_display_registers_from_line.
1252         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1253         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1254         "force_display" parameter.
1255
1256 2019-07-17  Tom Tromey  <tom@tromey.com>
1257
1258         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1259         declare.
1260         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1261         Rename from tui_first_reg_element_no_inline.
1262         (tui_display_reg_element_at_line)
1263         (tui_display_registers_from_line): Update.
1264         * tui/tui-data.h (struct tui_data_window)
1265         <first_reg_element_no_inline>: New method.
1266
1267 2019-07-17  Tom Tromey  <tom@tromey.com>
1268
1269         * tui/tui-windata.c (tui_display_data_from)
1270         (tui_data_window::do_scroll_vertical): Update.
1271         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1272         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1273         Rename from tui_line_from_reg_element_no.
1274         (tui_display_registers_from_line): Update.
1275         * tui/tui-data.h (struct tui_data_window)
1276         <line_from_reg_element_no>: New method.
1277
1278 2019-07-17  Tom Tromey  <tom@tromey.com>
1279
1280         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1281         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1282         tui_last_regs_line_no.
1283         (tui_display_reg_element_at_line)
1284         (tui_display_registers_from_line): Update.
1285         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1286         method.
1287
1288 2019-07-17  Tom Tromey  <tom@tromey.com>
1289
1290         PR tui/24722:
1291         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1292         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1293         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1294         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1295         (tui_update_breakpoint_info): Likewise.
1296         * tui/tui-hooks.c (tui_event_create_breakpoint)
1297         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1298         Update.
1299
1300 2019-07-17  Tom Tromey  <tom@tromey.com>
1301
1302         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1303
1304 2019-07-17  Tom Tromey  <tom@tromey.com>
1305
1306         * tui/tui-winsource.c (tui_update_source_window_as_is)
1307         (tui_update_source_windows_with_addr): Update.
1308         * tui/tui-source.h (tui_set_source_content)
1309         (tui_show_symtab_source): Add "win_info" parameter.
1310         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1311         parameter.
1312         (tui_show_symtab_source): Likewise.
1313
1314 2019-07-17  Tom Tromey  <tom@tromey.com>
1315
1316         * tui/tui-wingeneral.c
1317         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1318
1319 2019-07-17  Tom Tromey  <tom@tromey.com>
1320
1321         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1322         (struct tui_cmd_window) <can_scroll>: New method.
1323         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1324         method.
1325
1326 2019-07-17  Tom Tromey  <tromey@adacore.com>
1327
1328         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1329         do_field_signed>: Rename.  Change type of "value".
1330         * ui-out.c (ui_out::field_signed): Rename from field_int.
1331         Change type of "value".
1332         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1333         type of "value".
1334         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1335         do_field_int.  Change type of "value".
1336         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1337         do_field_int.  Change type of "value".
1338         * tracepoint.c (trace_status_mi, tfind_1)
1339         (print_one_static_tracepoint_marker): Update.
1340         * thread.c (print_thread_info_1, print_selected_thread_frame):
1341         Update.
1342         * stack.c (print_frame, print_frame_info): Update.
1343         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1344         Update.
1345         * source.c (print_source_lines_base): Update.
1346         * skip.c (info_skip_command): Update.
1347         * record-btrace.c (btrace_ui_out_decode_error)
1348         (btrace_call_history_src_line): Update.
1349         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1350         Update.
1351         * progspace.c (print_program_space): Update.
1352         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1353         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1354         do_field_int.  Change type of "value".
1355         * mi/mi-out.c (mi_ui_out::do_table_begin)
1356         (mi_ui_out::do_table_header): Update.
1357         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1358         type of "value".
1359         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1360         (mi_cmd_data_list_changed_registers, output_register)
1361         (mi_cmd_data_read_memory, mi_load_progress)
1362         (mi_cmd_trace_frame_collected): Update.
1363         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1364         Update.
1365         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1366         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1367         (mi_cmd_var_list_children, varobj_update_one): Update.
1368         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1369         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1370         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1371         * inferior.c (print_inferior): Update.
1372         * gdb_bfd.c (print_one_bfd): Update.
1373         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1374         Update.
1375         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1376         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1377         do_field_int.  Change type of "value".
1378         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1379         do_field_int.  Change type of "value".
1380         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1381         (print_one_breakpoint_location, print_it_catch_fork)
1382         (print_one_catch_fork, print_it_catch_vfork)
1383         (print_one_catch_vfork, print_it_catch_solib)
1384         (print_it_catch_exec, print_it_ranged_breakpoint)
1385         (print_mention_watchpoint, print_mention_masked_watchpoint)
1386         (bkpt_print_it, update_static_tracepoint): Update.
1387         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1388         * break-catch-syscall.c (print_it_catch_syscall): Update.
1389         * ada-tasks.c (print_ada_task_info): Update.
1390         * ada-lang.c (print_it_exception, print_mention_exception):
1391         Update.
1392
1393 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1394
1395         PR breakpoints/24541
1396         * gdbarch.c: Regenerate.
1397         * gdbarch.h: Regenerate.
1398         * gdbarch.sh: Adjust return type and parameter types for
1399         'stap_adjust_register'.
1400         (i386_stap_adjust_register): Adjust signature and return new
1401         register name.
1402         * stap-probe.c (stap_parse_register_operand): Adjust use of
1403         'gdbarch_stap_adjust_register'.
1404
1405 2019-07-17  Tom Tromey  <tromey@adacore.com>
1406
1407         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1408         declare VEC.
1409         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1410         std::vector.
1411         (struct s390_process_info): Add initializers.
1412         (s390_add_process): Use new.
1413         (s390_linux_nat_target::low_forget_process): Use delete.
1414         (s390_linux_nat_target::low_new_fork)
1415         (s390_linux_nat_target::stopped_by_watchpoint)
1416         (s390_linux_nat_target::low_prepare_to_resume)
1417         (s390_linux_nat_target::insert_watchpoint)
1418         (s390_linux_nat_target::insert_hw_breakpoint)
1419         (s390_linux_nat_target::remove_watchpoint)
1420         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1421
1422 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1423
1424         * aarch64-fbsd-nat.c: Include regcache.h.
1425         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1426         argument.
1427         (aarch64_fbsd_nat_target::fetch_registers)
1428         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1429         variable.
1430         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1431
1432 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1433
1434         * fbsd-nat.c: Include gdbarch.h.
1435
1436 2019-07-15  Tom Tromey  <tromey@adacore.com>
1437
1438         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1439
1440 2019-07-15  Tom Tromey  <tromey@adacore.com>
1441
1442         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1443         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1444         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1445         * cli-out.c (cli_ui_out::do_field_int): New method.
1446         * ui-out.c (ui_out::field_unsigned): New method.
1447         * symfile.c (generic_load): Use field_unsigned.
1448         (print_transfer_performance): Likewise.
1449         * record-btrace.c (ui_out_field_uint): Remove.
1450         (btrace_call_history_insn_range, btrace_call_history): Use
1451         field_unsigned.
1452         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1453         field_unsigned.
1454         * ui-out.h (class ui_out) <field_unsigned>: New method.
1455         <do_field_unsigned>: Likewise.
1456
1457 2019-07-15  Tom Tromey  <tromey@adacore.com>
1458
1459         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1460         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1461         * target.c (flash_erase_command): Use field_string.
1462         * infrun.c (print_signal_received_reason): Use field_string.
1463         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1464         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1465         field_string.
1466         * ada-tasks.c (print_ada_task_info): Use field_string.
1467
1468 2019-07-15  Tom Tromey  <tromey@adacore.com>
1469
1470         * target.c (flash_erase_command): Use field_core_addr.
1471         * symfile.c (generic_load): Use field_core_addr.
1472         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1473         Use field_core_addr.
1474         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1475         field_core_addr.
1476
1477 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1478
1479         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1480         value if its desired type is smaller than a CORE_ADDR and signed.
1481
1482 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1483
1484         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1485         of changes to field names, and use new is_reference field to
1486         decide if a property is a reference or not.
1487         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1488         field.
1489         (struct dwarf2_property_baton): Update header comment, rename
1490         'referenced_type' to 'property_type' and update comments.
1491         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1492         default property type, store in property baton, update to take
1493         accound of renamed field.
1494         (read_func_scope): Update call to attr_to_dynamic_prop.
1495         (read_array_type): Likewise.
1496         (dwarf2_per_cu_addr_sized_int_type): New function.
1497         (read_subrange_index_type): Move type finding code to
1498         dwarf2_per_cu_addr_sized_int_type.
1499         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1500         (dwarf2_per_cu_addr_type): New function.
1501         (set_die_type): Update calls to attr_to_dynamic_prop.
1502
1503 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1504
1505         * dwarf2read.c (read_subrange_index_type): New function.
1506         (read_subrange_type): Move code into new function and call it.
1507         * gdbtypes.c (create_range_type): Add some asserts.
1508
1509 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1510
1511         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1512         update return statements.
1513         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1514         declaration, and update comment to match.
1515         * gdbtypes.c (resolve_dynamic_array): Update call to
1516         dwarf2_evaluate_property to match new return type.
1517
1518 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1519
1520         * valarith.c (value_subscripted_rvalue): Change lowerbound
1521         parameter type from int to LONGEST.
1522         * value.h (value_subscripted_rvalue): Likewise in declaration.
1523
1524 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1525
1526         * cli/cli-utils.c (info_print_command_completer): New function.
1527         * cli/cli-utils.h: Add 'completer.h' include, and forward
1528         declaration for 'struct cmd_list_element'.
1529         (info_print_command_completer): Declare.
1530         * stack.c (_initialize_stack): Add completer for 'info locals' and
1531         'info args'.
1532         * symtab.c (_initialize_symtab): Add completer for 'info
1533         variables' and 'info functions'.
1534         * NEWS: Mention completion for additional info commands.
1535
1536 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1537
1538         * cli/cli-utils.c (extract_info_print_args): Delete.
1539         (extract_arg_maybe_quoted): Delete.
1540         (info_print_options_defs): New variable.
1541         (make_info_print_options_def_group): New function.
1542         (extract_info_print_options): Define new function.
1543         * cli/cli-utils.h (extract_info_print_args): Delete.
1544         (struct info_print_options): New structure.
1545         (extract_info_print_options): Declare new function.
1546         * stack.c (info_locals_command): Update to use new
1547         extract_info_print_options, also add a header comment.
1548         (info_args_command): Likewise.
1549         * symtab.c (info_variables_command): Likewise.
1550         (info_functions_command): Likewise.
1551
1552 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1553
1554         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1555         to extract string arguments.
1556         * common/common-utils.c (extract_string_maybe_quoted): New function.
1557         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1558
1559 2019-07-11  Tom Tromey  <tromey@adacore.com>
1560
1561         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1562         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1563         * top.h (gdbinit): Don't declare.
1564         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1565         into...
1566         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1567         * top.c (gdb_init): Don't call init_cli_cmds.
1568         (gdbinit): Remove.
1569         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1570
1571 2019-07-11  Tom Tromey  <tromey@adacore.com>
1572
1573         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1574         after it has been moved.
1575
1576 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1577
1578         * valops.c (value_must_coerce_to_target): Change return type to
1579         bool.
1580         * value.h (value_must_coerce_to_target): Likewise.
1581
1582 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1583
1584         * breakpoint.c (is_hardware_watchpoint): Remove
1585         forward-declaration.
1586         (is_masked_watchpoint): Change return type to bool.
1587         (is_tracepoint): Likewise.
1588         (is_breakpoint): Likewise.
1589         (is_hardware_watchpoint): Likewise.
1590         (is_watchpoint): Likewise.
1591         (is_no_memory_software_watchpoint): Likewise.
1592         (is_catchpoint): Likewise.
1593         (breakpoint_1): Make FILTER parameter's return type bool.
1594         is_masked_watchpoint): Change return type to bool.
1595         (save_breakpoints): Make FILTER parameter's return type bool.
1596         * breakpoint.h (is_breakpoint): Change return type to bool.
1597         (is_watchpoint): Likewise.
1598         (is_catchpoint): Likewise.
1599         (is_tracepoint): Likewise.
1600
1601 2019-07-10  Tom Tromey  <tom@tromey.com>
1602
1603         * defs.h: Don't include gdbarch.h.
1604         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1605         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1606         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1607         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1608         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1609         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1610         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1611         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1612         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1613         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1614         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1615         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1616         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1617         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1618         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1619         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1620         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1621         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1622         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1623         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1624         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1625         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1626         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1627         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1628         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1629         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1630         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1631
1632 2019-07-10  Tom Tromey  <tromey@adacore.com>
1633
1634         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1635         * breakpoint.c (init_ada_exception_breakpoint): Register as
1636         bp_catchpoint.
1637         (print_one_breakpoint_location, print_one_breakpoint): Use
1638         is_ada_exception_catchpoint.
1639         * ada-lang.c (class ada_catchpoint_location): Pass
1640         bp_loc_software_breakpoint to bp_location constructor.
1641         (is_ada_exception_catchpoint): New function.
1642
1643 2019-07-10  Tom Tromey  <tromey@adacore.com>
1644
1645         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1646         VEC.
1647         (struct arm_exidx_entry): New method operator<.
1648         (struct arm_exidx_data) <section_maps>: Change type.
1649         (arm_exidx_data_free): Remove.
1650         (arm_exidx_data_key): Change type.  Move lower.
1651         (arm_exidx_new_objfile): Update.
1652         (arm_compare_exidx_entries): Remove.
1653         (arm_find_exidx_entry, _initialize_arm_tdep)
1654
1655 2019-07-10  Tom Tromey  <tromey@adacore.com>
1656
1657         * solib-spu.c (ocl_program_data_key): Change type.
1658         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1659         Update.
1660
1661 2019-07-10  Tom Tromey  <tromey@adacore.com>
1662
1663         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1664         (struct solib_aix_inferior_data) <library_list>: Change type.
1665         (solib_aix_inferior_data_handle): Change type.
1666         (get_solib_aix_inferior_data): Update.
1667         (solib_aix_free_library_list): Remove.
1668         (library_list_start_library): Update.
1669         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1670         return type.
1671         (solib_aix_get_library_list)
1672         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1673         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1674
1675 2019-07-10  Tom Tromey  <tromey@adacore.com>
1676
1677         * solib-dsbt.c (struct dsbt_info): Add initializers.
1678         (solib_dsbt_pspace_data): Change type.
1679         (dsbt_pspace_data_cleanup): Remove.
1680         (get_dsbt_info, _initialize_dsbt_solib): Update.
1681
1682 2019-07-10  Tom Tromey  <tromey@adacore.com>
1683
1684         * spu-tdep.c (spu_overlay_data): Change type.
1685         (spu_get_overlay_table, spu_overlay_new_objfile)
1686         (_initialize_spu_tdep): Update.
1687
1688 2019-07-10  Tom Tromey  <tromey@adacore.com>
1689
1690         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1691         destructor.
1692         (dbx_objfile_data_key): Change type and declare later.
1693         (DBX_SYMFILE_INFO): Rewrite.
1694         * dbxread.c (dbx_objfile_data_key): Change type.
1695         (dbx_symfile_init): Update.
1696         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1697         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1698         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1699
1700 2019-07-10  Tom Tromey  <tromey@adacore.com>
1701
1702         * jit.c (jit_program_space_key): Change type.  Move lower.
1703         (get_jit_program_space_data): Update.
1704         (jit_program_space_data_cleanup): Remove.
1705         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1706         Update.
1707         (struct jit_program_space_data): Add initializers.
1708
1709 2019-07-10  Tom Tromey  <tromey@adacore.com>
1710
1711         * solib-darwin.c (struct darwin_info): Add initializers.
1712         (solib_darwin_pspace_data): Change type.
1713         (darwin_pspace_data_cleanup): Remove.
1714         (get_darwin_info, _initialize_darwin_solib): Update.
1715
1716 2019-07-10  Tom Tromey  <tromey@adacore.com>
1717
1718         * remote-sim.c (struct sim_inferior_data): Add initializers,
1719         constructor, and destructor.
1720         (sim_inferior_data_key): Change type.  Move lower.
1721         (check_for_duplicate_sim_descriptor): Update.
1722         (get_sim_inferior_data): Use new.  Update.
1723         (~sim_inferior_data_cleanup): Rename from
1724         sim_inferior_data_cleanup.  Simplify.
1725         (gdbsim_close_inferior, simulator_command)
1726         (sim_command_completer, _initialize_remote_sim): Update.
1727         (next_pid, INITIAL_PID): Move earlier.
1728
1729 2019-07-10  Tom Tromey  <tromey@adacore.com>
1730
1731         * python/python-internal.h (create_thread_object): Return
1732         gdbpy_ref.
1733         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1734         * python/py-inferior.c (struct threadlist_entry): Add
1735         constructor.
1736         <thread_obj>: Now a gdbpy_ref.
1737         (thread_to_thread_object): Update.
1738         (add_thread_object): Use new.
1739         (delete_thread_object): Use delete.
1740         (infpy_threads): Update.
1741         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1742         GIL.
1743
1744 2019-07-10  Tom Tromey  <tromey@adacore.com>
1745
1746         * valops.c (value_cast): Specialize error message for Ada.
1747
1748 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1749
1750         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1751
1752 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1753
1754         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1755         bpstat_should_step): Return bool, adjust comments.
1756         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1757         bpstat_should_step): Likewise.
1758
1759 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1760
1761         * features/Makefile: Use feature target descriptions for Arm.
1762         * features/arm/arm-core.c: Generate new file.
1763         * features/arm/arm-fpa.c: Likewise.
1764         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1765         * features/arm/arm-m-profile.c: Likewise.
1766         * features/arm/arm-vfpv2.c: Likewise.
1767         * features/arm/arm-vfpv3.c: Likewise.
1768         * features/arm/xscale-iwmmxt.c: Likewise.
1769         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1770
1771 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1772
1773         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1774         ptrace earlier.
1775
1776 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1777
1778         * features/aarch64-pauth.c: Regenerate.
1779
1780 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1781
1782         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1783         bool.
1784         (bpstat_what): Use false instead of 0.
1785
1786 2019-07-09  Pedro Alves  <palves@redhat.com>
1787
1788         * break-catch-throw.c (is_exception_catchpoint): New.
1789         * breakpoint.c (print_one_breakpoint_location): New parameter
1790         'raw_loc'.  Handle it.  Use
1791         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1792         looking at the breakpoint's type.
1793         (print_one_breakpoint): If handling "maint info breakpoints", also
1794         print locations of exception catchpoints.
1795         * breakpoint.h (is_exception_catchpoint): Declare.
1796
1797 2019-07-09  Pedro Alves  <palves@redhat.com>
1798
1799         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1800         "addr" field.
1801         (allocate_location_exception_catchpoint): New.
1802         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1803         (initialize_throw_catchpoint_ops): Install
1804         allocate_location_exception_catchpoint as allocate_location
1805         method.
1806         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1807         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1808         bp_loc_other.
1809         (breakpoint_address_is_meaningful): Delete.
1810         (bl_address_is_meaningful): New.
1811         (breakpoint_locations_match): Adjust comment.
1812         (bp_location_from_bp_type): New, factored out of...
1813         (bp_location::bp_location(breakpoint *)): ... this.
1814         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1815         factored out of...
1816         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1817         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1818         breakpoint_address_is_meaningful.
1819         (bp_locations_compare): Adjust comment.
1820         (update_global_location_list): Use bl_address_is_meaningful
1821         instead of breakpoint_address_is_meaningful.
1822         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1823         explicit.
1824         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1825         * python/py-breakpoint.c (bppy_get_location): No longer check
1826         whether location is null.
1827
1828 2019-07-09  Pedro Alves  <palves@redhat.com>
1829
1830         PR c++/15468
1831         * breakpoint.c (print_one_breakpoint_location): Remove
1832         single-location assert.
1833
1834 2019-07-09  Tom Tromey  <tom@tromey.com>
1835
1836         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1837         * configure: Rebuild.
1838         * configure.ac: Change common to gdbsupport.
1839         * gdbsupport: Rename from common.
1840         * acinclude.m4: Change common to gdbsupport.
1841         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1842         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1843         gdbsupport.
1844         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1845         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1846         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1847         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1848         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1849         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1850         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1851         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1852         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1853         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1854         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1855         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1856         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1857         coff-pe-read.c, command.h, compile/compile-c-support.c,
1858         compile/compile-c.h, compile/compile-cplus-symbols.c,
1859         compile/compile-cplus-types.c, compile/compile-cplus.h,
1860         compile/compile-loc2c.c, compile/compile.c, completer.c,
1861         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1862         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1863         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1864         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1865         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1866         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1867         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1868         features/aarch64-core.c, features/aarch64-fpu.c,
1869         features/aarch64-pauth.c, features/aarch64-sve.c,
1870         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1871         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1872         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1873         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1874         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1875         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1876         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1877         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1878         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1879         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1880         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1881         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1882         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1883         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1884         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1885         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1886         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1887         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1888         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1889         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1890         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1891         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1892         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1893         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1894         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1895         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1896         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1897         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1898         minsyms.c, mips-linux-tdep.c, namespace.h,
1899         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1900         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1901         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1902         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1903         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1904         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1905         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1906         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1907         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1908         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1909         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1910         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1911         procfs.c, producer.c, progspace.h, psymtab.h,
1912         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1913         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1914         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1915         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1916         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1917         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1918         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1919         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1920         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1921         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1922         target-memory.c, target.c, target.h, target/waitstatus.c,
1923         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1924         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1925         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1926         unittests/array-view-selftests.c,
1927         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1928         unittests/common-utils-selftests.c,
1929         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1930         unittests/format_pieces-selftests.c,
1931         unittests/function-view-selftests.c,
1932         unittests/lookup_name_info-selftests.c,
1933         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1934         unittests/mkdir-recursive-selftests.c,
1935         unittests/observable-selftests.c,
1936         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1937         unittests/parse-connection-spec-selftests.c,
1938         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1939         unittests/scoped_fd-selftests.c,
1940         unittests/scoped_mmap-selftests.c,
1941         unittests/scoped_restore-selftests.c,
1942         unittests/string_view-selftests.c, unittests/style-selftests.c,
1943         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1944         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1945         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1946         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1947         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1948         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1949
1950 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1951
1952         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1953         bool value.
1954         (decode_digits_ordinary): Set explicit_line field in sal.
1955         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1956         symtab_and_line that was set on an explicit line number in
1957         assembler code.  Do always update the recorded symtab and line if
1958         we do skip the prologue.
1959
1960 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1961
1962         * breakpoint.c (set_breakpoint_location_function): Remove
1963         explicit_loc parameter.
1964         (momentary_breakpoint_from_master): Update call to
1965         set_breakpoint_location_function.
1966         (add_location_to_breakpoint): Likewise.
1967
1968 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1969
1970         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1971         required features based on default bfd type when no specific bfd
1972         is present.
1973
1974 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1975
1976         * NEWS: Mention that GDB printf and eval commands can now print
1977         C-style and Ada-style convenience var strings without
1978         calling the inferior.
1979         * printcmd.c (printf_c_string): Locally print GDB internal var
1980         instead of transiting via the inferior.
1981         (printf_wide_c_string): Likewise.
1982
1983 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1984
1985         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1986
1987 2019-07-04  Tom Tromey  <tom@tromey.com>
1988
1989         PR tui/24724:
1990         * tui/tui-winsource.c (tui_clear_source_content): Update.
1991         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1992         (tui_update_breakpoint_info): Update.
1993         (tui_set_exec_info_content): Update.
1994         * tui/tui-source.c (tui_set_source_content_nil): Update.
1995         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1996         has_break.
1997         * tui/tui-data.h (enum tui_bp_flag): New.
1998         (tui_bp_flags): New enum flags type.
1999         (struct tui_source_element) <break_mode>: Change type.  Rename
2000         from has_break.
2001         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2002         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2003         constants.
2004         * tui/tui-winsource.h: Fix comment.
2005
2006 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2007
2008         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2009         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2010         (store_fpregs_to_thread)
2011         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2012         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2013         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2014         (IWMMXT_REGS_SIZE): Add define.
2015         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2016         (fetch_vfp_regs, store_vfp_regs)
2017         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2018         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2019
2020 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2021
2022         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2023         defines.
2024         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2025         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2026         (ARM_INT_REGISTER_SIZE): ...to this.
2027         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2028         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2029         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2030         (arm_linux_collect_gregset, supply_nwfpe_register)
2031         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2032         defines.
2033         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2034         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2035         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2036         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2037         (arm_return_in_memory, arm_store_return_value)
2038         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2039         (arm_record_ld_st_multiple): Likewise.
2040         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2041         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2042
2043 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2044
2045         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2046         AARCH64_DISPLACED_MODIFIED_INSNS.
2047         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2048         (aarch64_displaced_step_copy_insn): Likewise.
2049         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2050         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2051         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2052         ARM_DISPLACED_MODIFIED_INSNS.
2053         * arm-tdep.c (arm_gdbarch_init): Likewise.
2054         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2055         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2056         (struct arm_displaced_step_closure): Use
2057         ARM_DISPLACED_MODIFIED_INSNS.
2058
2059 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2060
2061         * features/Makefile: Remove unused xml files.
2062         * features/aarch64.xml: Remove.
2063         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2064         * features/i386/amd64-avx-avx512.xml: Remove.
2065         * features/i386/amd64-avx-linux.xml: Remove.
2066         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2067         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2068         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2069         * features/i386/amd64-avx-mpx.xml: Remove.
2070         * features/i386/amd64-avx.xml: Remove.
2071         * features/i386/amd64-linux.xml: Remove.
2072         * features/i386/amd64-mpx-linux.xml: Remove.
2073         * features/i386/amd64-mpx.xml: Remove.
2074         * features/i386/amd64.xml: Remove.
2075         * features/i386/i386-avx-avx512-linux.xml: Remove.
2076         * features/i386/i386-avx-avx512.xml: Remove.
2077         * features/i386/i386-avx-linux.xml: Remove.
2078         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2079         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2080         * features/i386/i386-avx-mpx-linux.xml: Remove.
2081         * features/i386/i386-avx-mpx.xml: Remove.
2082         * features/i386/i386-avx.xml: Remove.
2083         * features/i386/i386-linux.xml: Remove.
2084         * features/i386/i386-mmx-linux.xml: Remove.
2085         * features/i386/i386-mmx.xml: Remove.
2086         * features/i386/i386-mpx-linux.xml: Remove.
2087         * features/i386/i386-mpx.xml: Remove.
2088         * features/i386/i386.xml: Remove.
2089         * features/i386/x32-avx-avx512-linux.xml: Remove.
2090         * features/i386/x32-avx-linux.xml: Remove.
2091         * features/i386/x32-linux.xml: Remove.
2092
2093 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2094
2095         * regformats/aarch64.dat: Remove.
2096         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2097         * regformats/i386/amd64-avx-linux.dat: Remove.
2098         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2099         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2100         * regformats/i386/amd64-linux.dat: Remove.
2101         * regformats/i386/amd64-mpx-linux.dat: Remove.
2102         * regformats/i386/amd64.dat: Remove.
2103         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2104         * regformats/i386/i386-avx-linux.dat: Remove.
2105         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2106         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2107         * regformats/i386/i386-linux.dat: Remove.
2108         * regformats/i386/i386-mmx-linux.dat: Remove.
2109         * regformats/i386/i386-mpx-linux.dat: Remove.
2110         * regformats/i386/i386.dat: Remove.
2111         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2112         * regformats/i386/x32-avx-linux.dat: Remove.
2113         * regformats/i386/x32-linux.dat: Remove.
2114
2115 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2116
2117         * aarch64-tdep.c: Remove xml self tests.
2118         * amd64-linux-tdep.c: Likewise.
2119         * amd64-tdep.c: Likewise.
2120         * i386-linux-tdep.c: Likewise.
2121         * i386-tdep.c: Likewise.
2122
2123 2019-07-03  Pedro Alves  <palves@redhat.com>
2124
2125         PR cli/24732
2126         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2127         (pipe_cmd_option_defs): New.
2128         (make_pipe_cmd_options_def_group): New.
2129         (pipe_command): Use gdb::option::process_options.
2130         (pipe_command_completer): New function.
2131         (_initialize_cli_cmds): Install completer for "pipe" command.
2132
2133 2019-07-03  Pedro Alves  <palves@redhat.com>
2134
2135         * cli/cli-option.c (union option_value) <string>: New field.
2136         (struct option_def_and_value): Add ctor, move ctor, dtor and
2137         use DISABLE_COPY_AND_ASSIGN.
2138         (option_def_and_value::clear_value): New.
2139         (parse_option, save_option_value_in_ctx, get_val_type_str)
2140         (add_setshow_cmds_for_options): Handle var_string.
2141         * cli-option.h (union option_def::var_address) <string>: New
2142         field.
2143         (struct string_option_def): New.
2144         * maint-test-options.c (struct test_options_opts): Add default
2145         ctor and use DISABLE_COPY_AND_ASSIGN.
2146         <string_opt>: New field.
2147         (test_options_opts::~test_options_opts): New.
2148         (test_options_opts::dump): Also dump "-string".
2149         (test_options_option_defs): Install "string.
2150
2151 2019-07-03  Pedro Alves  <palves@redhat.com>
2152
2153         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2154         option_value with a null enumeration.
2155         (complete_options): Save the option values in the context.
2156         (save_option_value_in_ctx): New, factored out from ...
2157         (process_options): ... here.
2158         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2159         of the function.
2160         * maint-test-options.c (test_options_opts::dump): New, factored
2161         out from ...
2162         (maintenance_test_options_command_mode): ... here.
2163         (maintenance_test_options_command_completion_result): Delete.
2164         (maintenance_test_options_command_completion_text): Update
2165         comment.
2166         (maintenance_show_test_options_completion_result): Change
2167         prototype.  Just print
2168         maintenance_test_options_command_completion_text.
2169         (save_completion_result): New.
2170         (maintenance_test_options_completer_mode): Pass options context to
2171         complete_options, and then save a dump.
2172         (_initialize_maint_test_options): Use add_cmd to install "maint
2173         show test-options-completion-result".
2174
2175 2019-07-03  Pedro Alves  <palves@redhat.com>
2176
2177         * NEWS (New commands): Mention "with" and "maint with".
2178         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2179         (with_command, with_command_completer): New.
2180         (pipe_command): Adjust to new repeat_previous
2181         interface.
2182         (_initialize_cli_cmds): Install the "with" command and its "w"
2183         alias.
2184         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2185         declarations.
2186         * cli/cli-setshow.c (parse_cli_var_uinteger)
2187         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2188         argument strings for all var_types.
2189         (get_setshow_command_value_string): New, factored out from ...
2190         (do_show_command): ... this.
2191         * cli/cli-setshow.h: Include <string>.
2192         (get_setshow_command_value_string): Declare.
2193         * command.h (repeat_previous): Now returns const char *.  Adjust
2194         comment.
2195         * maint.c: Include "cli/cli-cmds.h".
2196         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2197         (_initialize_maint_cmds): Register the "maintenance with" command.
2198         * top.c (repeat_previous): Move bits from pipe_command here:
2199         Return the saved command line, if any; error out if there's no
2200         command to relaunch.
2201
2202 2019-07-03  Pedro Alves  <palves@redhat.com>
2203
2204         * NEWS (New commands): Mention "maint set/show test-settings"
2205         instead of "maint test-settings".
2206         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2207         (maintenance_test_settings_set_list): Rename to ...
2208         (maintenance_set_test_settings_list): ... this.
2209         (maintenance_test_settings_show_list): Rename to  ...
2210         (maintenance_show_test_settings_list): ... this.
2211         (maintenance_test_settings_cmd): Delete.
2212         (maintenance_test_settings_set_cmd): ...
2213         (maintenance_set_test_settings_cmd): ... this.
2214         (maintenance_test_settings_show_cmd): ...
2215         (maintenance_show_test_settings_cmd): ... this.
2216         (maintenance_test_settings_show_value_cmd):
2217         (maintenance_show_test_settings_value_cmd): ... this.
2218         (_initialize_maint_test_settings): No longer install the "maint
2219         test-settings" prefix command.  Rename "maint test-settings set"
2220         to "maint set test-settings", and "maint test-settings show" to
2221         "maint show test-settings".  Adjust all subcommands.
2222
2223 2019-07-03  Pedro Alves  <palves@redhat.com>
2224
2225         * maint-test-settings.c: Fix file's intro comment.  Replace all
2226         references to "test-options" with references to "test-settings",
2227         in comments.
2228
2229 2019-07-03  Pedro Alves  <palves@redhat.com>
2230
2231         * maint-test-settings.c (maintenance_test_settings_xxx)
2232         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2233         New.
2234         (maintenance_test_settings_enums): Use them.
2235         (maintenance_test_settings_enum): Default to
2236         maintenance_test_settings_xxx.
2237         (_initialize_maint_test_settings): Initialize
2238         MAINTENANCE_TEST_SETTINGS_FILENAME.
2239
2240 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2241
2242         * breakpoint.h (remove_breakpoints_inf): Change return type to
2243         void, move function documentation here.
2244         * breakpoint.c (remove_breakpoints_inf): Change return type to
2245         void, move function documentation to header.
2246
2247 2019-07-02  Pedro Alves  <palves@redhat.com>
2248
2249         * NEWS (Completion improvements): Mention "info threads".
2250         * thread.c (struct info_threads_opts, info_threads_option_defs)
2251         (make_info_threads_options_def_group): New.
2252         (info_threads_command): Use gdb::option::process_options.
2253         (info_threads_command_completer): New.
2254         (_initialize_thread): Use gdb::option::build_help to build the
2255         help text for "info threads".
2256
2257 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2258
2259         * defs.h (generic_load): Move from here...
2260         * symfile.h (generic_load): ... to here.  Rename name parameter
2261         to args.
2262         * symfile.c (generic_load): Add comment.
2263
2264 2019-07-01  Tom Tromey  <tromey@adacore.com>
2265
2266         * dwarf2read.c
2267         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2268         declaration of without_params.  Fix formatting.
2269
2270 2019-07-01  Tom Tromey  <tromey@adacore.com>
2271
2272         * ada-exp.y (find_primitive_type): Update.
2273         * ada-lang.h (ada_lookup_symbol): Update.
2274         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2275         parameter.
2276         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2277
2278 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2279
2280         PR breakpoints/24541
2281         * gdbarch.c: Regenerate.
2282         * gdbarch.h: Regenerate.
2283         * gdbarch.sh: Add 'stap_adjust_register'.
2284         * i386-tdep.c: Include '<unordered_set>'.
2285         (i386_stap_adjust_register): New function.
2286         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2287         * stap-probe.c (stap_parse_register_operand): Call
2288         'gdbarch_stap_adjust_register'.
2289
2290 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2291
2292         PR python/24742
2293         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2294         * python/python.c (do_start_initialization): Use 'xmalloc'
2295         instead of 'PyMem_Malloc'.
2296
2297 2019-06-28  Tom Tromey  <tromey@adacore.com>
2298
2299         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2300         for Ada.
2301
2302 2019-06-27  Tom Tromey  <tromey@adacore.com>
2303
2304         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2305         objfile_key.
2306         (arm_find_mapping_symbol, arm_record_special_symbol)
2307         (_initialize_arm_tdep): Update.
2308         (arm_objfile_data_free): Remove.
2309
2310 2019-06-27  Tom Tromey  <tromey@adacore.com>
2311
2312         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2313         to cp_print_static_field.
2314
2315 2019-06-26  Tom Tromey  <tromey@adacore.com>
2316
2317         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2318         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2319         declare.
2320
2321 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2322
2323         * features/aarch64-core.c (create_feature_aarch64_core):
2324         Regenerate.
2325         * features/aarch64-core.xml: Add cpsr flags.
2326
2327 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2328
2329         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2330         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2331
2332 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2333
2334         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2335         field.
2336         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2337         use.
2338         (arm_record_special_symbol): Don't insert new symbol in sorted
2339         position, push it at the end.
2340
2341 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2342
2343         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2344         (arm_mapping_symbol_s): Remove.
2345         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2346         (arm_mapping_symbol_vec): New typedef.
2347         (struct arm_per_objfile): Add constructor.
2348         <section_maps>: Change type to
2349         std::unique_ptr<arm_mapping_symbol_vec[]>.
2350         (arm_compare_mapping_symbols): Remove.
2351         (arm_find_mapping_symbol): Adjust to section_maps type change.
2352         (arm_objfile_data_free): Call delete on arm_per_objfile.
2353         (arm_record_special_symbol): Adjust to section_maps type change.
2354         Allocate arm_per_objfile with new.
2355
2356 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2357
2358         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2359         with the command prefix.
2360
2361 2019-06-25  Tom Tromey  <tom@tromey.com>
2362
2363         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2364         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2365
2366 2019-06-25  Tom Tromey  <tom@tromey.com>
2367
2368         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2369         type.
2370         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2371         protected.
2372
2373 2019-06-25  Tom Tromey  <tom@tromey.com>
2374
2375         * tui/tui-winsource.c
2376         (tui_source_window_base::set_is_exec_point_at): Add check against
2377         LOA_ADDRESS.
2378
2379 2019-06-25  Tom Tromey  <tom@tromey.com>
2380
2381         * tui/tui-source.c (tui_set_source_content): Don't check before
2382         xfree.
2383         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2384
2385 2019-06-25  Tom Tromey  <tom@tromey.com>
2386
2387         * tui/tui-winsource.h (tui_update_source_window_as_is)
2388         (tui_alloc_source_buffer, tui_line_is_displayed)
2389         (tui_addr_is_displayed): Change type of win_info.
2390         * tui/tui-winsource.c (tui_update_source_window_as_is)
2391         (tui_clear_source_content, tui_show_source_line)
2392         (tui_show_source_content, tui_source_window_base::refill)
2393         (tui_source_window_base::set_is_exec_point_at)
2394         (tui_source_window_base::set_is_exec_point_at)
2395         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2396         (tui_alloc_source_buffer, tui_line_is_displayed)
2397         (tui_addr_is_displayed): Change type of win_info.  Update.
2398         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2399         (tui_source_window_base::do_make_visible_with_new_height):
2400         Update.
2401         * tui/tui-source.c (tui_set_source_content)
2402         (tui_set_source_content_nil)
2403         (tui_source_window::do_scroll_vertical): Update.
2404         * tui/tui-layout.c (show_layout): Update.
2405         * tui/tui-disasm.c (tui_set_disassem_content)
2406         (tui_disasm_window::do_scroll_vertical): Update.
2407         * tui/tui-data.h (tui_win_content): Remove.
2408         (struct tui_gen_win_info) <content, content_size>: Remove.
2409         (struct tui_source_element): Add initializers and destructor.
2410         (union tui_which_element, struct tui_win_element): Remove.
2411         (struct tui_source_window_base) <content>: New field.
2412         (struct tui_data_window): Remove destructor.
2413         (tui_alloc_content, tui_free_win_content)
2414         (tui_free_all_source_wins_content): Don't declare.
2415         * tui/tui-data.c (tui_initialize_static_data): Update.
2416         (init_content_element, tui_alloc_content): Remove.
2417         (~tui_gen_win_info): Update.
2418         (~tui_data_window, tui_free_all_source_wins_content)
2419         (tui_free_win_content, free_content, free_content_elements):
2420         Remove.
2421
2422 2019-06-25  Tom Tromey  <tom@tromey.com>
2423
2424         * tui/tui-winsource.h (tui_clear_source_content)
2425         (tui_erase_source_content, tui_show_source_content): Change type
2426         of win_info.
2427         * tui/tui-winsource.c (tui_clear_source_content)
2428         (tui_erase_source_content, tui_show_source_content): Change type
2429         of win_info.
2430         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2431         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2432         win_info.
2433         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2434         win_info.
2435         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2436
2437 2019-06-25  Tom Tromey  <tom@tromey.com>
2438
2439         * tui/tui-winsource.c (tui_clear_source_content)
2440         (tui_source_window_base::set_is_exec_point_at): Update.
2441         * tui/tui-source.c (tui_set_source_content_nil): Update.
2442         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2443         a bool.
2444         * tui/tui-data.c (init_content_element): Update.
2445
2446 2019-06-25  Tom Tromey  <tom@tromey.com>
2447
2448         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2449         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2450         * tui/tui-layout.c (init_and_make_win): Update.
2451         * tui/tui.h (enum tui_win_type): Update.
2452         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2453         tui_win_is_auxillary.
2454         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2455         tui_win_is_auxillary.
2456
2457 2019-06-25  Tom Tromey  <tom@tromey.com>
2458
2459         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2460         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2461         (tui_delete_data_content_windows, tui_display_all_data)
2462         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2463         Update.
2464         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2465         * tui/tui-regs.c (tui_last_regs_line_no)
2466         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2467         (tui_show_registers): Update.
2468         (tui_show_register_group): Return void.  Update.
2469         (tui_display_registers_from, tui_display_reg_element_at_line)
2470         (tui_display_registers_from_line, tui_check_register_values):
2471         Update.
2472         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2473         member.
2474         (struct tui_data_window) <regs_content>: Now a std::vector.
2475         <regs_content_count>: Remove.
2476         (tui_add_content_elements, tui_free_data_content): Don't declare.
2477         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2478         (init_content_element): Remove DATA_WIN case.  Add assert.
2479         (tui_add_content_elements): Remove.
2480         (tui_data_window): Update.
2481         (tui_free_data_content): Remove.
2482         (free_content_elements): Remove DATA_WIN case.
2483
2484 2019-06-25  Tom Tromey  <tom@tromey.com>
2485
2486         * tui/tui-data.c (tui_data_item_window): Update.
2487         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2488         * tui/tui-windata.c (tui_display_all_data)
2489         (tui_display_data_from_line): Update.
2490         (tui_check_data_values): Remove.
2491         * tui/tui-regs.c (tui_show_register_group)
2492         (tui_display_reg_element_at_line): Update.
2493         * tui/tui-hooks.c (tui_register_changed)
2494         (tui_refresh_frame_and_register_information): Call
2495         tui_check_register_values.
2496         * tui/tui-data.h (struct tui_data_window) <data_content,
2497         data_content_count, data_type>: Remove.
2498         (enum tui_data_type): Remove.
2499
2500         * tui/tui-data.c (tui_data_window::clear_detail)
2501         (~tui_data_window): Update.
2502
2503 2019-06-25  Tom Tromey  <tom@tromey.com>
2504
2505         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2506         declare.
2507         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2508         Rename from tui_first_data_item_displayed.  Update.
2509         (tui_data_window::refresh_all)
2510         (tui_data_window::do_scroll_vertical): Update.
2511         * tui/tui-data.h (struct tui_data_window)
2512         <first_data_item_displayed>: Declare new method.
2513
2514 2019-06-25  Tom Tromey  <tom@tromey.com>
2515
2516         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2517         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2518         contents...
2519         (tui_initialize_static_data): ...here.
2520
2521 2019-06-25  Tom Tromey  <tom@tromey.com>
2522
2523         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2524         (tui_display_registers_from, tui_check_register_values): Update.
2525         (tui_display_register): Remove win_info parameter; update.
2526         (tui_get_register): Change type of parameters.
2527         * tui/tui-data.h (struct tui_data_element): Remove.
2528         (union tui_which_element) <data>: Remove.
2529         <data_window>: Change type.
2530         (struct tui_data_item_window): New.
2531         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2532         case.  Add assert.
2533         (~tui_data_item_window): New destructor.
2534         (free_content_elements): Remove DATA_ITEM_WIN case.
2535
2536 2019-06-25  Tom Tromey  <tom@tromey.com>
2537
2538         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2539         Remove.
2540
2541 2019-06-25  Tom Tromey  <tom@tromey.com>
2542
2543         * tui/tui-data.h (struct tui_command_element): Remove.
2544         (union tui_which_element) <command>: Remove.
2545         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2546         assert.
2547         (free_content_elements): Remove CMD_WIN case.
2548
2549 2019-06-25  Tom Tromey  <tom@tromey.com>
2550
2551         * tui/tui-layout.c (tui_set_layout): Update.
2552         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2553         * tui/tui-data.c (layout_def): Update.
2554
2555 2019-06-25  Tom Tromey  <tom@tromey.com>
2556
2557         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2558         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2559         (tui_source_window_base::set_new_height): Update.
2560         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2561         Update.
2562         (tui_set_locator_fullname, tui_set_locator_info)
2563         (tui_show_frame_info): Update.
2564         * tui/tui-source.c (tui_set_source_content)
2565         (tui_source_is_displayed): Update.
2566         * tui/tui-layout.c (show_source_disasm_command, show_data)
2567         (show_source_or_disasm_and_command): Update.
2568         * tui/tui-disasm.c (tui_set_disassem_content)
2569         (tui_get_begin_asm_address): Update.
2570         * tui/tui-data.h (struct tui_locator_element): Remove.
2571         (union tui_which_element) <locator>: Remove.
2572         (struct tui_locator_window): New.
2573         (tui_locator_win_info_ptr): Change return type.
2574         * tui/tui-data.c (_locator): Change type.
2575         (tui_locator_win_info_ptr): Change return type.
2576         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2577         (tui_alloc_content): Add assert.
2578
2579 2019-06-25  Tom Tromey  <tom@tromey.com>
2580
2581         * tui/tui-winsource.c
2582         (tui_exec_info_window::maybe_allocate_content): New method.
2583         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2584         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2585         (make_source_or_disasm_window): Add cast.
2586         * tui/tui-data.h (union tui_which_element) <simple_string>:
2587         Remove.
2588         (struct tui_source_info): New.
2589         (struct tui_source_window_base) <execution_info>: Change type.
2590         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2591         case, and add assert.
2592         (tui_alloc_content): Add assert.
2593
2594 2019-06-25  Tom Tromey  <tom@tromey.com>
2595
2596         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2597         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2598         * tui/tui-data.c (tui_alloc_win_info): Remove.
2599
2600 2019-06-25  Tom Tromey  <tom@tromey.com>
2601
2602         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2603         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2604         can_highlight.
2605
2606 2019-06-25  Tom Tromey  <tom@tromey.com>
2607
2608         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2609         make_visible_with_new_height method.
2610         (tui_win_info::make_visible_with_new_height): New method.
2611         (tui_source_window_base::do_make_visible_with_new_height)
2612         (tui_data_window::do_make_visible_with_new_height)
2613         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2614         (make_visible_with_new_height): Remove.
2615         (tui_resize_all, tui_adjust_win_heights): Use
2616         make_visible_with_new_height method.
2617         * tui/tui-data.h (struct tui_win_info)
2618         <do_make_visible_with_new_height, make_visible_with_new_height>:
2619         New methods.
2620         (struct tui_source_window_base, struct tui_data_window)
2621         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2622         methods.
2623
2624 2019-06-25  Tom Tromey  <tom@tromey.com>
2625
2626         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2627         method.
2628         (update_tab_width): Call update_tab_width method.
2629         * tui/tui-data.h (struct tui_win_info)
2630         (struct tui_source_window_base) <update_tab_width>: New methods.
2631
2632 2019-06-25  Tom Tromey  <tom@tromey.com>
2633
2634         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2635         parameter.
2636         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2637         parameter.
2638         (tui_gen_win_info::make_visible): Update.
2639         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2640         parameter.
2641         * tui/tui-data.h (enum tui_box): New enum.
2642         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2643
2644 2019-06-25  Tom Tromey  <tom@tromey.com>
2645
2646         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2647         init_and_make_win for EXEC_INFO_WIN.
2648         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2649         longer inline.
2650         (struct tui_win_info) <~tui_win_info>: Inline.
2651         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2652         Don't declare.
2653         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2654         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2655         Remove.
2656         (tui_initialize_static_data): Update.
2657         (~tui_gen_win_info): Handle more cleanup here.
2658         (~tui_source_window_base): Delete "execution_info".
2659         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2660
2661 2019-06-25  Tom Tromey  <tom@tromey.com>
2662
2663         * tui/tui-layout.c (make_command_window): Don't set
2664         can_highlight.
2665         (show_source_disasm_command): Call the reset method.
2666         (show_data): Don't set can_highlight.  Call the reset method.
2667         (tui_gen_win_info::reset): Rename from init_gen_win_info
2668         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2669         (show_source_or_disasm_and_command): Call the reset method.
2670         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2671         (struct tui_cmd_window): Set can_highlight.
2672
2673 2019-06-25  Tom Tromey  <tom@tromey.com>
2674
2675         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2676         from make_visible.
2677         (tui_make_visible, tui_make_invisible): Rewrite.
2678         (tui_win_info::make_visible): Remove.
2679         (tui_source_window_base::make_visible): Update.
2680         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2681         method.  Moved from...
2682         (struct tui_win_info) <make_visible>: ...here.
2683
2684 2019-06-25  Tom Tromey  <tom@tromey.com>
2685
2686         * tui/tui-winsource.c
2687         (tui_source_window_base::do_scroll_horizontal): Remove direction
2688         parameter.
2689         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2690         direction parameter.
2691         * tui/tui-win.c (tui_win_info::forward_scroll)
2692         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2693         (tui_win_info::right_scroll): Update.
2694         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2695         direction parameter.
2696         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2697         direction parameter.
2698         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2699         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2700         Remove direction parameter.
2701         (struct tui_source_window_base, struct tui_source_window)
2702         (struct tui_disasm_window, struct tui_data_window)
2703         (struct tui_cmd_window): Update.
2704
2705 2019-06-25  Tom Tromey  <tom@tromey.com>
2706
2707         * tui/tui-winsource.h (tui_set_exec_info_content)
2708         (tui_show_exec_info_content, tui_erase_exec_info_content)
2709         (tui_clear_exec_info_content, tui_update_exec_info): Change
2710         argument to tui_source_window_base.
2711         * tui/tui-winsource.c (tui_set_exec_info_content)
2712         (tui_show_exec_info_content, tui_erase_exec_info_content)
2713         (tui_clear_exec_info_content, tui_update_exec_info): Change
2714         argument to tui_source_window_base.
2715
2716 2019-06-25  Tom Tromey  <tom@tromey.com>
2717
2718         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2719         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2720
2721 2019-06-25  Tom Tromey  <tom@tromey.com>
2722
2723         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2724         check.
2725
2726 2019-06-25  Tom Tromey  <tom@tromey.com>
2727
2728         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2729         type to void.
2730         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2731         type to void.
2732         * tui/tui-source.c (tui_set_source_content): Update.
2733         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2734
2735 2019-06-25  Tom Tromey  <tom@tromey.com>
2736
2737         * tui/tui-win.c (window_name_completer, tui_set_focus)
2738         (tui_all_windows_info): Use name method.
2739         * tui/tui-data.h (struct tui_gen_win_info)
2740         (struct tui_source_window, struct tui_disasm_window)
2741         (struct tui_data_window, struct tui_cmd_window) <name>: New
2742         method.
2743         (tui_win_name): Don't declare.
2744         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2745         (tui_win_name): Remove.
2746
2747 2019-06-25  Tom Tromey  <tom@tromey.com>
2748
2749         * tui/tui-winsource.h (tui_update_source_window)
2750         (tui_update_source_window_as_is): Change parameter type.
2751         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2752         to be a tui_source_window_base.
2753         (tui_update_source_window_as_is): Likewise.
2754         * tui/tui-win.c (make_visible_with_new_height): Update.
2755
2756 2019-06-25  Tom Tromey  <tom@tromey.com>
2757
2758         * tui/tui-winsource.c (tui_erase_source_content)
2759         (tui_show_source_content, tui_show_exec_info_content)
2760         (tui_erase_exec_info_content): Use refresh_window method.
2761         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2762         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2763         from tui_refresh_win.
2764         (tui_data_window::refresh_window): New method.
2765         (tui_win_info::refresh, tui_source_window_base::refresh)
2766         (tui_refresh_all): Use refresh_window method.
2767         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2768         method.
2769         * tui/tui-regs.c (tui_display_register): Call refresh_window
2770         method.
2771         * tui/tui-layout.c (show_source_disasm_command)
2772         (show_source_or_disasm_and_command): Call refresh_window method.
2773         * tui/tui-data.h (struct tui_gen_win_info)
2774         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2775         New method.
2776
2777 2019-06-25  Tom Tromey  <tom@tromey.com>
2778
2779         * tui/tui.c (tui_rl_other_window, tui_enable)
2780         (tui_is_window_visible, tui_get_command_dimension): Update.
2781         * tui/tui-winsource.c (tui_update_source_window_as_is)
2782         (tui_clear_source_content, tui_erase_source_content)
2783         (tui_show_source_line, tui_source_window_base::refill)
2784         (tui_source_window_base::do_scroll_horizontal)
2785         (tui_source_window_base::set_is_exec_point_at)
2786         (tui_update_breakpoint_info, tui_set_exec_info_content)
2787         (tui_alloc_source_buffer, tui_line_is_displayed)
2788         (tui_addr_is_displayed): Update.
2789         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2790         (tui_check_and_display_highlight_if_needed)
2791         (tui_win_info::make_visible, tui_win_info::refresh)
2792         (tui_refresh_all): Update.
2793         * tui/tui-windata.c (tui_first_data_item_displayed)
2794         (tui_delete_data_content_windows, tui_erase_data_content)
2795         (tui_display_all_data, tui_data_window::refresh_all)
2796         (tui_check_data_values): Update.
2797         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2798         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2799         (tui_win_info::backward_scroll, tui_refresh_all_win)
2800         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2801         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2802         (tui_source_window_base::set_new_height)
2803         (tui_data_window::set_new_height)
2804         (make_invisible_and_set_new_height)
2805         (make_visible_with_new_height, new_height_ok)
2806         (parse_scrolling_args): Update.
2807         * tui/tui-stack.c (tui_show_frame_info): Update.
2808         * tui/tui-source.c (tui_set_source_content)
2809         (tui_set_source_content_nil, tui_source_is_displayed)
2810         (tui_source_window::do_scroll_vertical): Update.
2811         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2812         (tui_display_registers_from, tui_display_reg_element_at_line)
2813         (tui_check_register_values, tui_reg_command): Update.
2814         * tui/tui-layout.c (tui_default_win_height)
2815         (show_source_disasm_command, show_data, init_and_make_win)
2816         (show_source_or_disasm_and_command): Update.
2817         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2818         (tui_redisplay_readline, tui_mld_flush)
2819         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2820         (tui_getc): Update.
2821         * tui/tui-disasm.c (tui_set_disassem_content)
2822         (tui_disasm_window::do_scroll_vertical): Update.
2823         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2824         Now virtual.
2825         (struct tui_win_info): Derive from tui_gen_win_info.
2826         <~tui_win_info>: Mark as override.
2827         <generic>: Remove member.
2828         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2829         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2830         (~tui_data_window, ~tui_win_info)
2831         (tui_free_all_source_wins_content): Update.
2832         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2833
2834 2019-06-25  Tom Tromey  <tom@tromey.com>
2835
2836         * tui/tui-layout.c (init_and_make_win): Use new.
2837         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2838         destructor, initializers.
2839         (tui_alloc_generic_win_info): Don't declare.
2840         * tui/tui-data.c (_locator): Add argument to constructor.
2841         (source_win, disasm_win): New globals.
2842         (exec_info): Remove.
2843         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2844         Update.
2845         (tui_alloc_generic_win_info): Remove.
2846         (init_content_element): Use new.
2847         (tui_win_info::tui_win_info): Update.
2848         (free_content_elements) <case DATA_WIN>: Use delete.
2849
2850 2019-06-25  Tom Tromey  <tom@tromey.com>
2851
2852         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2853         * tui/tui-windata.c (tui_first_data_item_displayed)
2854         (tui_delete_data_content_windows): Update.
2855         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2856         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2857         (tui_display_registers_from, tui_check_register_values): Update.
2858         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2859         pointer.
2860         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2861         window.
2862         (tui_free_data_content): Update.
2863         (free_content_elements) <case DATA_WIN>: Free the window.
2864
2865 2019-06-25  Tom Tromey  <tom@tromey.com>
2866
2867         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2868         Update.
2869         * tui/tui-layout.c (make_command_window)
2870         (show_source_disasm_command, show_data, init_and_make_win)
2871         (show_source_or_disasm_and_command): Update.
2872         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2873         method.
2874         <can_highight, is_highlighted>: Now bool.
2875         (tui_set_win_highlight): Don't declare.
2876         * tui/tui-data.c (tui_set_win_highlight): Remove.
2877
2878 2019-06-25  Tom Tromey  <tom@tromey.com>
2879
2880         * tui/tui-wingeneral.c (make_visible): Remove check of window
2881         type.
2882
2883 2019-06-25  Tom Tromey  <tom@tromey.com>
2884
2885         * tui/tui-win.c (tui_win_info::max_height)
2886         (tui_cmd_window::max_height): New methods.
2887         (new_height_ok): Call max_height.
2888         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2889         <max_height>: New method.
2890
2891 2019-06-25  Tom Tromey  <tom@tromey.com>
2892
2893         * tui/tui-win.c (tui_source_window_base::set_new_height)
2894         (tui_data_window::set_new_height): New methods.
2895         (make_invisible_and_set_new_height): Call set_new_height method.
2896         * tui/tui-data.h (struct tui_win_info)
2897         (struct tui_source_window_base, struct tui_data_window)
2898         <set_new_height>: New method.
2899
2900 2019-06-25  Tom Tromey  <tom@tromey.com>
2901
2902         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2903         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2904         tui_refresh_data_win.
2905         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2906         method.
2907         (tui_refresh_all_win): Call the refresh_all method.
2908         (tui_set_focus): Likewise.
2909         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2910         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2911         Likewise.
2912
2913 2019-06-25  Tom Tromey  <tom@tromey.com>
2914
2915         * tui/tui-winsource.h (tui_refill_source_window)
2916         (tui_set_is_exec_point_at): Don't declare.
2917         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2918         (tui_source_window_base::refill): Rename from
2919         tui_refill_source_window.
2920         (tui_source_window_base::do_scroll_horizontal): Update.
2921         (tui_source_window_base::set_is_exec_point_at): Rename from
2922         tui_set_is_exec_point_at.
2923         (tui_update_all_breakpoint_info): Update.
2924         * tui/tui-stack.c (tui_show_frame_info): Update.
2925         * tui/tui-layout.c (show_data): Add cast.
2926         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2927         * tui/tui-data.h (struct tui_source_window_base) <refill,
2928         set_is_exec_point_at>: New methods.
2929         (tui_source_windows, tui_add_to_source_windows): Update types.
2930         (tui_add_to_source_windows): Remove redundant declaration.
2931         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2932         (tui_source_windows): Change return type.
2933         (tui_clear_source_windows_detail): Update.
2934         (tui_add_to_source_windows): Change type of parameter.
2935         (tui_free_all_source_wins_content): Update.
2936
2937 2019-06-25  Tom Tromey  <tom@tromey.com>
2938
2939         * tui/tui-wingeneral.c (tui_win_info::refresh)
2940         (tui_source_window_base::refresh): New methods.
2941         (tui_refresh_all): Call the refresh method.
2942         * tui/tui-data.h (struct tui_win_info)
2943         (struct tui_source_window_base) <refresh>: New method.
2944
2945 2019-06-25  Tom Tromey  <tom@tromey.com>
2946
2947         * tui/tui.h (tui_is_window_visible): Return bool.
2948         * tui/tui.c (tui_is_window_visible): Return bool.
2949         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2950         (tui_make_visible, tui_make_invisible)
2951         (tui_win_info::make_visible)
2952         (tui_source_window_base::make_visible, make_all_visible)
2953         (tui_make_all_visible, tui_make_all_invisible): Update.
2954         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2955         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2956         bool.
2957         (struct tui_win_info, struct tui_source_window_base)
2958         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2959         * tui/tui-data.c (tui_init_generic_part): Update.
2960
2961 2019-06-25  Tom Tromey  <tom@tromey.com>
2962
2963         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2964         (tui_source_window_base::make_visible): New methods.
2965         (make_all_visible): Make method call.
2966         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2967         (struct tui_source_window_base, struct tui_cmd_window): Override
2968         make_visible.
2969         (tui_win_is_source_type): Don't declare.
2970         * tui/tui-data.c (tui_win_is_source_type): Remove.
2971
2972 2019-06-25  Tom Tromey  <tom@tromey.com>
2973
2974         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2975         NULL check.
2976
2977 2019-06-25  Tom Tromey  <tom@tromey.com>
2978
2979         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2980         Inline constructor.  Add initializers for members.
2981         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2982         constructors; now inline in class.
2983
2984 2019-06-25  Tom Tromey  <tom@tromey.com>
2985
2986         * tui/tui-regs.c (tui_show_registers): Update.
2987         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2988         bool.
2989         * tui/tui-data.c (tui_data_window::clear_detail)
2990         (tui_data_window): Update.
2991
2992 2019-06-25  Tom Tromey  <tom@tromey.com>
2993
2994         * tui/tui-windata.c (tui_display_all_data)
2995         (tui_display_data_from_line, tui_display_data_from)
2996         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2997         Update.
2998         * tui/tui-regs.c (tui_last_regs_line_no)
2999         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3000         (tui_show_registers, tui_show_register_group)
3001         (tui_display_registers_from, tui_display_reg_element_at_line)
3002         (tui_display_registers_from_line, tui_check_register_values)
3003         (tui_reg_next, tui_reg_prev): Update.
3004         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3005         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3006         tui_data_window.
3007         (struct tui_win_info) <detail>: Remove.  Add new fields from
3008         tui_data_info.
3009         (TUI_DATA_WIN): Add cast.
3010         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3011         (~tui_data_window): Simplify.
3012
3013 2019-06-25  Tom Tromey  <tom@tromey.com>
3014
3015         * tui/tui-layout.c (show_source_disasm_command)
3016         (show_source_or_disasm_and_command): Update.
3017         * tui/tui-io.c (update_cmdwin_start_line)
3018         (tui_redisplay_readline): Update.
3019         * tui/tui-data.h (struct tui_command_info): Remove.
3020         (struct tui_win_info) <detail>: Remove command_info member.
3021         (struct tui_data_window) <start_line>: New member, from
3022         tui_command_info.
3023         (TUI_CMD_WIN): Add casts.
3024
3025 2019-06-25  Tom Tromey  <tom@tromey.com>
3026
3027         * tui/tui-winsource.c (tui_update_source_window)
3028         (tui_refill_source_window)
3029         (tui_source_window_base::do_scroll_horizontal)
3030         (tui_update_breakpoint_info, tui_set_exec_info_content)
3031         (tui_show_exec_info_content, tui_erase_exec_info_content)
3032         (tui_clear_exec_info_content): Update.
3033         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3034         Update.
3035         * tui/tui-win.c (make_invisible_and_set_new_height)
3036         (make_visible_with_new_height): Update.
3037         * tui/tui-source.c (tui_set_source_content)
3038         (tui_show_symtab_source): Update.
3039         * tui/tui-layout.c (extract_display_start_addr)
3040         (show_source_disasm_command, show_data)
3041         (make_source_or_disasm_window)
3042         (show_source_or_disasm_and_command): Update.
3043         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3044         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3045         "gdbarch".
3046         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3047         to tui_source_window_base.
3048         (struct tui_win_info) <detail>: Remove source_info member.
3049         (struct tui_source_window_base) <has_locator>: Inline.
3050         Move contents from tui_source_info; rename has_locator member to
3051         m_has_locator.
3052         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3053         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3054         header file.
3055         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3056         Simplify.
3057         (tui_free_all_source_wins_content): Cast to
3058         tui_source_window_base.
3059
3060 2019-06-25  Tom Tromey  <tom@tromey.com>
3061
3062         * tui/tui-win.c (make_invisible_and_set_new_height)
3063         (make_visible_with_new_height): Call has_locator method.
3064         * tui/tui-layout.c (show_source_disasm_command, show_data)
3065         (show_source_or_disasm_and_command): Update for bool change.
3066         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3067         (tui_win_info) <has_locator>: New method.
3068         (struct tui_source_window_base) <has_locator>: New method.
3069         (tui_win_has_locator): Don't declare.
3070         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3071         from tui_win_has_locator.
3072         (tui_source_window_base): Use false, not FALSE.
3073
3074 2019-06-25  Tom Tromey  <tom@tromey.com>
3075
3076         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3077         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3078         clear_detail method directly.
3079         (tui_clear_win_detail): Remove.
3080
3081 2019-06-25  Tom Tromey  <tom@tromey.com>
3082
3083         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3084         "this", not TUI_DISASM_WIN.
3085
3086 2019-06-25  Tom Tromey  <tom@tromey.com>
3087
3088         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3089         declare.
3090         * tui/tui-winsource.c
3091         (tui_source_window_base::do_scroll_horizontal): Rename from
3092         tui_horizontal_source_scroll.
3093         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3094         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3095         from tui_vertical_data_scroll.
3096         * tui/tui-win.h (tui_scroll): Don't declare.
3097         * tui/tui-win.c (tui_win_info::forward_scroll)
3098         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3099         (tui_win_info::right_scroll): Rename and update.
3100         (tui_scroll_forward_command, tui_scroll_backward_command)
3101         (tui_scroll_left_command, tui_scroll_right_command): Update.
3102         (tui_scroll): Remove.
3103         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3104         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3105         from tui_vertical_source_scroll.
3106         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3107         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3108         from tui_vertical_disassem_scroll.
3109         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3110         do_scroll_horizontal>: New methods.
3111         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3112         Likewise.
3113         (struct tui_source_window_base): Add do_scroll_horizontal.
3114         (struct tui_source_window, struct tui_disasm_window): Add
3115         do_scroll_vertical.
3116         (struct tui_data_window, struct tui_cmd_window): Add
3117         do_scroll_horizontal and do_scroll_vertical.
3118         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3119
3120 2019-06-25  Tom Tromey  <tom@tromey.com>
3121
3122         * tui/tui-data.h (struct tui_source_window_base): New struct.
3123         (struct tui_source_window): Derive from tui_source_window_base.
3124         (struct tui_disasm_window): New struct.
3125         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3126         from tui_source_window::clear_detail.
3127         (tui_source_window_base): Rename from tui_source_window.
3128         (~tui_source_window_base): Rename from ~tui_source_window.
3129         (tui_alloc_win_info): Create a tui_disasm_window.
3130
3131 2019-06-25  Tom Tromey  <tom@tromey.com>
3132
3133         * tui/tui-data.h (struct tui_source_window)
3134         (struct tui_data_window): Declare destructors.
3135         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3136         destructors.
3137         (tui_win_info): Simplify.
3138
3139 2019-06-25  Tom Tromey  <tom@tromey.com>
3140
3141         * tui/tui-winsource.c (tui_display_main)
3142         (tui_update_source_windows_with_addr)
3143         (tui_update_all_breakpoint_info): Update.
3144         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3145         (new_height_ok, parse_scrolling_args): Update.
3146         * tui/tui-stack.c (tui_show_frame_info): Update.
3147         * tui/tui-data.h (struct tui_list): Remove.
3148         (tui_source_windows): Return a reference to a std::vector.
3149         * tui/tui-data.c (source_windows): Now a std::vector.
3150         (tui_source_windows): Change return type.
3151         (tui_clear_source_windows): Rewrite.
3152         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3153         (tui_free_all_source_wins_content): Rewrite.
3154
3155 2019-06-25  Tom Tromey  <tom@tromey.com>
3156
3157         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3158         (struct tui_data_window, struct tui_cmd_window): Declare
3159         clear_detail method.
3160         * tui/tui-data.c (tui_source_window::clear_detail)
3161         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3162         methods.
3163         (tui_clear_win_detail): Simplify.
3164
3165 2019-06-25  Tom Tromey  <tom@tromey.com>
3166
3167         * tui/tui-layout.c (make_source_window, make_disasm_window)
3168         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3169         Return the new window.
3170         (show_source_disasm_command, show_data)
3171         (show_source_or_disasm_and_command): Update.
3172
3173 2019-06-25  Tom Tromey  <tom@tromey.com>
3174
3175         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3176         parameter.  Return the new window.
3177         (show_source_disasm_command): Update and remove NULL check.
3178         (show_source_or_disasm_and_command): Update.
3179
3180 2019-06-25  Tom Tromey  <tom@tromey.com>
3181
3182         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3183
3184 2019-06-25  Tom Tromey  <tom@tromey.com>
3185
3186         * tui/tui-data.h (struct tui_win_info): Make constructor
3187         protected.  Make destructor virtual.  Add initializers.
3188         (tui_source_window, tui_data_window, tui_cmd_window): New
3189         classes.
3190         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3191         constructor.  Add "type" parameter.
3192         (tui_source_window, tui_data_window, tui_cmd_window): New
3193         constructors.
3194         (tui_alloc_win_info): Instantiate the appropriate subclass.
3195
3196 2019-06-25  Tom Tromey  <tom@tromey.com>
3197
3198         * tui/tui-win.c (tui_resize_all): Use delete.
3199         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3200         destructor.
3201         (tui_free_window): Don't declare.
3202         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3203         Update.
3204
3205 2019-06-25  Tom Tromey  <tom@tromey.com>
3206
3207         * tui/tui-data.h (struct tui_win_info): Add constructor.
3208         * tui/tui-data.c (tui_alloc_win_info): Use new.
3209         (tui_free_window): Use delete.
3210
3211 2019-06-22  Tom Tromey  <tom@tromey.com>
3212
3213         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3214         declare.
3215         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3216
3217 2019-06-22  Tom Tromey  <tom@tromey.com>
3218
3219         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3220         declare.
3221         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3222
3223 2019-06-22  Tom de Vries  <tdevries@suse.de>
3224
3225         * dwarf2read.c (create_addrmap_from_aranges)
3226         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3227         instead of '%zu'.
3228
3229 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3230
3231         * dwarf2read.h (dwarf2_section_info_def): Remove.
3232         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3233         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3234         std::vector<dwarf2_section_info>.
3235         (struct dwo_file) <~dwo_file>: Remove.
3236         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3237         types field.
3238         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3239         (dwarf2_read_debug_names): Likewise.
3240         (create_debug_types_hash_table): Change parameter type to
3241         array_view, adjust code accordingly.
3242         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3243         (partial_die_info::fixup): Likewise.
3244         (determine_prefix): Likewise.
3245         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3246
3247 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3248
3249         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3250         gdb_bfd_ref_ptr.
3251         <~dwo_file>: Remove call to gdb_bfd_unref.
3252         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3253         gdb_bfd_ref_ptr::get.
3254
3255 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3256
3257         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3258         type to htab_up.
3259         * dwarf2read.c (struct dwo_file): Initialize fields.
3260         <~dwo_file>: New.
3261         (free_dwo_file): Remove, move content to ~dwo_file.
3262         (struct dwo_file_deleter): Remove.
3263         (dwo_file_up>: Remove custom deleter.
3264         (free_dwo_files): Remove.
3265         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3266         dwo_files.
3267         (process_skeletonless_type_units): Call unique_ptr::get.
3268         (allocate_dwo_file_hash_table): Add deleter to created hash
3269         table.  Change return type to htab_up.
3270         (lookup_dwo_file_slot): Don't memset dwo_file, call
3271         unique_ptr::get.
3272         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3273         (create_dwo_unit_in_dwp_v2): Likewise.
3274         (open_and_init_dwo_file): Likewise.
3275         (free_dwo_file_from_slot): Remove.
3276
3277 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3278
3279         * dwarf2read.h (struct dwarf2_section_info) <readin,
3280         is_virtual>: Change type to bool.
3281         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3282         true instead of 1.
3283
3284 2019-06-19  Tom Tromey  <tom@tromey.com>
3285
3286         * tui/tui-data.h (tui_init_content_element): Don't declare.
3287
3288 2019-06-19  Tom Tromey  <tom@tromey.com>
3289
3290         * tui/tui-data.h (tui_init_win_info): Don't declare.
3291
3292 2019-06-19  Tom de Vries  <tdevries@suse.de>
3293
3294         * dwarf2read.h (abstract_to_concrete): Change type to
3295         std::unordered_map<sect_offset, std::vector<sect_offset>,
3296         gdb::hash_enum<sect_offset>>.
3297
3298 2019-06-19  Tom Tromey  <tromey@adacore.com>
3299
3300         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3301         EVAL_AVOID_SIDE_EFFECTS specially.
3302
3303 2019-06-19  Tom Tromey  <tromey@adacore.com>
3304
3305         * source-cache.c (highlighter): New global.
3306         (source_cache::get_source_lines): Create a highlighter on demand.
3307
3308 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3309
3310         * defs.h (deprecated_interactive_hook): Delete declaration.
3311         * interps.c (clear_interpreter_hooks): Remove use of
3312         deprecated_interactive_hook.
3313         * top.c (deprecated_interactive_hook): Delete definition.
3314         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3315
3316 2019-06-18  Tom de Vries  <tdevries@suse.de>
3317
3318         PR gdb/24515
3319         * dwarf2read.h (abstract_to_concrete): Change type from
3320         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3321         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3322         * dwarf2read.c (read_variable): Update.
3323         (dwarf2_fetch_die_loc_sect_off): Update.
3324
3325 2019-06-17  Tom de Vries  <tdevries@suse.de>
3326
3327         PR gdb/24617
3328         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3329         accessing parent[parent_len - 1].
3330
3331 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3332
3333         PR gdb/24364
3334         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3335         call dtrace_process_dof with NULL dof.
3336
3337 2019-06-16  Tom de Vries  <tdevries@suse.de>
3338
3339         PR gdb/24445
3340         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3341
3342 2019-06-16  Tom Tromey  <tom@tromey.com>
3343
3344         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3345         (make_all_visible): Use address of member.
3346
3347 2019-06-16  Tom Tromey  <tom@tromey.com>
3348
3349         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3350         (tui_free_window, free_content, free_content_elements): Remove
3351         unnecessary cast.
3352         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3353         cast.
3354         * tui/tui-regs.c (tui_show_register_group)
3355         (tui_display_registers_from, tui_display_reg_element_at_line):
3356         Remove unnecessary cast.
3357
3358 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3359
3360         * linux-nat.c (normal_mask): Delete.
3361         (_initialize_linux_nat): Don't initialise normal_mask.
3362
3363 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3364
3365         PR gdb/24445
3366         * dwarf-index-write.h (write_psymtabs_to_index): Add
3367         dwz_basename parameter.
3368         * dwarf-index-write.c (write_gdbindex): Move file writing to
3369         write_gdbindex_1.  Change return type void.
3370         (assert_file_size): Move up, remove filename parameter.
3371         (write_gdbindex_1): New function.
3372         (write_debug_names): Change return type to void, call
3373         assert_file_size.
3374         (struct index_wip_file): New struct.
3375         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3376         file logic to index_wip_file.  Write index for dwz file if
3377         needed.
3378         (save_gdb_index_command): Pass basename of dwz file, if present.
3379         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3380         build-id of dwz file, if present.
3381         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3382         (dwarf2_get_dwz_file): Likewise.
3383         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3384         (dwarf2_get_dwz_file): Likewise.
3385
3386 2019-06-16  Tom Tromey  <tom@tromey.com>
3387
3388         * coffread.c (process_coff_symbol): Use xstrdup.
3389         * value.c (create_internalvar): Use xstrdup.
3390
3391 2019-06-16  Tom Tromey  <tom@tromey.com>
3392
3393         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3394         * breakpoint.c (stopin_command, stopat_command)
3395         (until_break_command, decode_location_default): Remove unnecessary
3396         cast.
3397         * utils.c (subset_compare): Remove unnecessary cast.
3398         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3399         cast.
3400         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3401         cast.
3402         * infcmd.c (path_command): Remove unnecessary cast.
3403         * coffread.c (decode_type): Remove unnecessary cast.
3404         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3405         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3406         * tui/tui-stack.c (tui_show_locator_content)
3407         (tui_show_frame_info): Remove unnecessary cast.
3408         * tui/tui-win.c (tui_scroll_forward_command)
3409         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3410         (parse_scrolling_args): Remove unnecessary cast.
3411         * tui/tui-data.c (init_win_info, tui_del_window)
3412         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3413         (free_content_elements): Remove unnecessary cast.
3414         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3415         unnecessary cast.
3416         * tui/tui-source.c (tui_set_source_content)
3417         (tui_vertical_source_scroll): Remove unnecessary cast.
3418         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3419         cast.
3420         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3421         * tui/tui-regs.c (tui_display_registers_from)
3422         (tui_display_register): Remove unnecessary cast.
3423         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3424         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3425         (make_visible): Remove unnecessary cast.
3426         * tui/tui-winsource.c (tui_erase_source_content)
3427         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3428         unnecessary cast.
3429         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3430         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3431         * stabsread.c (read_type, read_array_type, read_range_type):
3432         Remove unnecessary cast.
3433         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3434         (parse_symbol, parse_type, upgrade_type, parse_external)
3435         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3436         unnecessary cast.
3437         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3438
3439 2019-06-16  Tom Tromey  <tom@tromey.com>
3440
3441         * tui/tui-data.c (tui_alloc_generic_win_info)
3442         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3443         checks.
3444
3445 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3446             Andrew Burgess  <andrew.burgess@embecosm.com>
3447
3448         * f-typeprint.c (f_print_type): Don't return early for not
3449         associated or not allocated types.
3450         (f_type_print_varspec_suffix): Add print_rank parameter and print
3451         ranks of array types in case they dangling.
3452         (f_type_print_base): Add print_rank parameter.
3453
3454 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3455
3456         * NEWS: Mention new MI commands.
3457         * break-catch-throw.c (enum exception_event_kind): Move to
3458         breakpoint.h.
3459         (print_mention_exception_catchpoint): Output text as a single
3460         message.
3461         (catch_exception_command_1): Rename to...
3462         (catch_exception_event): ...this, make non-static, update header
3463         command, and change some parameter types.
3464         (catch_catch_command): Update for changes to
3465         catch_exception_command_1.
3466         (catch_throw_command): Likewise.
3467         (catch_rethrow_command): Likewise.
3468         * breakpoint.c (enum exception_event_kind): Delete.
3469         * breakpoint.h (enum exception_event_kind): Moved here from
3470         break-catch-throw.c.
3471         (catch_exception_event): Declare.
3472         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3473         (mi_cmd_catch_throw): New function.
3474         (mi_cmd_catch_rethrow): New function.
3475         (mi_cmd_catch_catch): New function.
3476         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3477         'catch-catch' entries.
3478         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3479         (mi_cmd_catch_rethrow): Declare.
3480         (mi_cmd_catch_catch): Declare.
3481
3482 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3483
3484         * annotate.c (annotate_source_line): Change return type to void,
3485         update implementation to match.
3486         * annotate.h (annotate_source_line): Change return type to void,
3487         update header comment.
3488         * stack.c (print_frame_info): Don't change what frame information
3489         is printed based on whether annotations are on or not.
3490
3491 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3492
3493         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3494         (annotate_source): Make static.
3495         (annotate_source_line): Moved from source.c and renamed from
3496         identify_source_line.  Update the return type.
3497         * annotate.h (annotate_source): Delete declaration.
3498         (annotate_source_line): Declaration moved from source.h, and
3499         renamed from identify_source_line.  Return type updated.
3500         * source.c (identify_source_line): Moved to annotate.c and renamed
3501         to annotate_source_line.
3502         (info_line_command): Remove check of annotation_level.
3503         * source.h (identify_source_line): Move declaration to annotate.h
3504         and rename to annotate_source_line.
3505         * stack.c: Add 'annotate.h' include.
3506         (print_frame_info): Remove check of annotation_level before
3507         calling annotate_source_line.
3508
3509 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3510
3511         * source-cache.c (source_cache::get_plain_source_lines): Use
3512         open_source_file_with_line_charpos instead of just
3513         open_source_file, remove call to find_source_lines.
3514         (source_cache::get_source_lines): Likewise.
3515         * source.c (find_source_lines): Make static.
3516         (get_filename_and_charpos): Renamed into...
3517         (open_source_file_with_line_charpos): ..this along with changes to
3518         return a scoped_fd, and some other minor clean ups.
3519         (identify_source_line): Use open_source_file_with_line_charpos.
3520         (search_command_helper): Use open_source_file_with_line_charpos
3521         instead of just open_source_file, remove call to
3522         find_source_lines.
3523         * source.h (open_source_file_with_line_charpos): Declare new
3524         function.
3525         (find_source_lines): Delete declaration.
3526
3527 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3528
3529         * source.c (get_filename_and_charpos): Remove fullname
3530         parameter.
3531         (identify_source_line): Update call to get_filename_and_charpos.
3532
3533 2019-06-14  Tom Tromey  <tromey@adacore.com>
3534
3535         PR gdb/24502:
3536         * ui-style.h (skip_ansi_escape): Update comment.
3537         * ui-file.h (class no_terminal_escape_file): New class.
3538         * ui-file.c (no_terminal_escape_file::write)
3539         (no_terminal_escape_file::puts): New methods.
3540         * cli/cli-logging.c (handle_redirections): Use
3541         no_terminal_escape_file.
3542
3543 2019-06-14  Tom Tromey  <tromey@adacore.com>
3544
3545         * NEWS: Move convenience variable news above Python news.
3546
3547 2019-06-14  Tom Tromey  <tom@tromey.com>
3548
3549         * gnulib: Move directory to top-level.
3550         * configure.ac: Don't configure gnulib.
3551         * configure: Rebuild.
3552         * common/common-defs.h: Use new path to gnulib.
3553         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3554         (GNULIB_H): Remove.
3555         (INCGNU): Look in new gnulib location.
3556         (HFILES_NO_SRCDIR): Remove gnulib files.
3557         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3558         (generated_files): Remove GNULIB_H.
3559         ($(LIBGNU), all-lib): Remove targets.
3560         (distclean): Don't mention GNULIB_BUILDDIR.
3561         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3562
3563 2019-06-14  Tom Tromey  <tromey@adacore.com>
3564
3565         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3566         Warn if symbol file does not provide any symbols.
3567
3568 2019-06-14  Tom Tromey  <tromey@adacore.com>
3569
3570         * source.c (find_and_open_source): Respect basenames_may_differ.
3571
3572 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3573
3574         * annotate.c (annotate_breakpoints_invalid): Make use of
3575         scoped_restore_terminal_state.
3576         (annotate_frames_invalid): Likewise.
3577
3578 2019-06-14  Tom Tromey  <tromey@adacore.com>
3579
3580         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3581         allow assignment to an internalvar.
3582
3583 2019-06-14  Tom Tromey  <tromey@adacore.com>
3584
3585         * ada-lex.l: Allow "_" in attribute names.
3586
3587 2019-06-14  Tom Tromey  <tromey@adacore.com>
3588
3589         PR gdb/24653:
3590         * regcache.c (registers_changed): Don't call alloca.
3591         * top.c (execute_command): Don't call alloca.
3592
3593 2019-06-13  Pedro Alves  <palves@redhat.com>
3594
3595         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3596         'expression'.  When parsing an expression, error out if there's
3597         junk after "unlimited".
3598         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3599         (do_set_command): Adjust calls to is_unlimited_literal.
3600
3601 2019-06-13  Pedro Alves  <palves@redhat.com>
3602
3603         * compile/compile.c (make_compile_options_def_group): Add braces
3604         around array_view initializer.
3605         * thread.c (make_thread_apply_all_options_def_group)
3606         (make_thread_apply_all_options_def_group): Likewise.
3607
3608 2019-06-13  Pedro Alves  <palves@redhat.com>
3609
3610         * NEWS (New commands): Mention "maint test-options
3611         require-delimiter", "maint test-options unknown-is-error", "maint
3612         test-options unknown-is-operand" and "maint show
3613         test-options-completion-result".
3614         (New command options, command completion): New section.
3615         (Completion improvements): New section.
3616         Mention that you can abbreviate "unlimited".
3617
3618 2019-06-13  Pedro Alves  <palves@redhat.com>
3619
3620         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3621         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3622         * unittests/cli-utils-selftests.c (test_parse_flags)
3623         (test_parse_flags_qcs): Delete.
3624         (test_cli_utils): Don't call deleted functions.
3625
3626 2019-06-13  Pedro Alves  <palves@redhat.com>
3627
3628         * thread.c: Include "cli/cli-option.h".
3629         (tp_array_compar_ascending): Global.
3630         (tp_array_compar): Delete function.
3631         (tp_array_compar_ascending, tp_array_compar_descending): New
3632         functions.
3633         (ascending_option_def, qcs_flag_option_def)
3634         (thr_qcs_flags_option_defs)
3635         (make_thread_apply_all_options_def_group)
3636         (make_thread_apply_options_def_group): New.
3637         (thread_apply_all_command): Use gdb::option::process_options.
3638         (thread_apply_command_completer)
3639         (thread_apply_all_command_completer): New.
3640         (thread_apply_command): Use gdb::option::process_options.
3641         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3642         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3643         to generate help text of "thread apply".  Adjust "taas"'s help.
3644         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3645         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3646
3647 2019-06-13  Pedro Alves  <palves@redhat.com>
3648
3649         * thread.c (thread_apply_command): Check for invalid TID with
3650         isdigit instead of !isalpha.
3651
3652 2019-06-13  Pedro Alves  <palves@redhat.com>
3653
3654         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3655         (validate_flags_qcs): New.
3656         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3657         (validate_flags_qcs): Declare.
3658         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3659         (make_frame_apply_options_def_group): New.
3660         (frame_apply_command_count): Process options with
3661         gdb::option::process_options.
3662         (frame_apply_completer): New.
3663         (frame_apply_level_completer, frame_apply_all_completer)
3664         (frame_apply_completer): New.
3665         (_initialize_stack): Update help of "frame apply", "frame apply
3666         level", "frame apply all" and "faas" to mention supported options
3667         and install command completers.
3668         * stack.h (frame_apply_all_completer): Declare.
3669         * thread.c: Include "stack.h".
3670         (tfaas_command): Add "--".
3671         (_initialize_thread): Update help "tfaas" to mention supported
3672         options and install command completer.
3673
3674 2019-06-13  Pedro Alves  <palves@redhat.com>
3675
3676         * completer.c (complete_nested_command_line): New.
3677         (gdb_completion_word_break_characters_throw): Add assertion.
3678         * completer.h (complete_nested_command_line): Declare.
3679
3680 2019-06-13  Pedro Alves  <palves@redhat.com>
3681
3682         * stack.c (parse_backtrace_qualifiers): New.
3683         (backtrace_command): Use it.
3684         (backtrace_command_completer): Complete on qualifiers.
3685
3686 2019-06-13  Pedro Alves  <palves@redhat.com>
3687
3688         * frame.c: Include "cli/cli-option.h.
3689         (user_set_backtrace_options): New.
3690         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3691         Delete.
3692         (get_prev_frame): Adjust.
3693         (boolean_option_def, uinteger_option_def)
3694         (set_backtrace_option_defs): New.
3695         (_initialize_frame): Adjust and use
3696         gdb::option::add_setshow_cmds_for_options to install "set
3697         backtrace past-main" and "set backtrace past-entry".
3698         * frame.h: Include "cli/cli-option.h".
3699         (struct frame_print_options): Forward declare.
3700         (print_frame_arguments_all, print_frame_arguments_scalars)
3701         (print_frame_arguments_none): Declare.
3702         (print_entry_values): Delete declaration.
3703         (struct frame_print_options, user_frame_print_options): New.
3704         (struct set_backtrace_options): New.
3705         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3706         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3707         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3708         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3709         (list_args_or_locals): Add frame_print_options parameter.
3710         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3711         * python/py-framefilter.c (enumerate_args): Pass down
3712         USER_FRAME_PRINT_OPTIONS.
3713         * stack.c: Include "cli/cli-option.h".
3714         (print_frame_arguments_all, print_frame_arguments_scalars)
3715         (print_frame_arguments_none): Declare.
3716         (print_raw_frame_arguments, print_entry_values): Delete.
3717         (user_frame_print_options): New.
3718         (boolean_option_def, enum_option_def, frame_print_option_defs):
3719         New.
3720         (struct backtrace_cmd_options): New.
3721         (bt_flag_option_def): New.
3722         (backtrace_command_option_defs): New.
3723         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3724         (print_frame_arg, read_frame_arg, print_frame_args)
3725         (print_frame_info, print_frame): Add frame_print_options parameter
3726         and use it.
3727         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3728         (backtrace_command_1): Add frame_print_options and
3729         backtrace_cmd_options parameters and use them.
3730         (make_backtrace_options_def_group): New.
3731         (backtrace_command): Process command options with
3732         gdb::option::process_options.
3733         (backtrace_command_completer): New.
3734         (_initialize_stack): Extend "backtrace"'s help to mention
3735         supported options.  Install completer for "backtrace".
3736         Install some settings commands with add_setshow_cmds_for_options.
3737
3738 2019-06-13  Pedro Alves  <palves@redhat.com>
3739
3740         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3741         and that "set/show print raw frame-arguments" are now deprecated.
3742
3743         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3744         command.
3745         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3746         * stack.c (_initialize_stack): Install "set/show print
3747         raw-frame-arguments", and deprecate "set/show print raw
3748         frame-arguments".
3749         * valprint.c (_initialize_valprint): Deprecate "set/show print
3750         raw".
3751
3752 2019-06-13  Pedro Alves  <palves@redhat.com>
3753
3754         * compile/compile.c (struct compile_options): New.
3755         (compile_flag_option_def, compile_command_option_defs)
3756         (make_compile_options_def_group): New.
3757         (compile_file_command): Handle options with
3758         gdb::option::process_options.
3759         (compile_file_command_completer): New function.
3760         (compile_code_command): Handle options with
3761         gdb::option::process_options.
3762         (compile_code_command_completer): New function.
3763         (_initialize_compiler): Install completers for "compile code" and
3764         "compile file".  Mention available options in "compile code" and
3765         "compile code"'s help.
3766         * completer.c (advance_to_completion_word): New, factored out from
3767         ...
3768         (advance_to_expression_complete_word_point): ... this.
3769         (advance_to_filename_complete_word_point): New.
3770         * completer.h (advance_to_filename_complete_word_point): New
3771         declaration.
3772
3773 2019-06-13  Pedro Alves  <palves@redhat.com>
3774
3775         * compile/compile.c: Include "cli/cli-option.h".
3776         (compile_print_value): Scope data pointer is now a
3777         value_print_options pointer; adjust.
3778         (compile_print_command): Process options.  Scope data pointer is
3779         now a value_print_options pointer; adjust.
3780         (_initialize_compile): Update "compile print"'s help to include
3781         supported options.  Install a completer for "compile print".
3782         * cp-valprint.c (show_vtblprint, show_objectprint)
3783         (show_static_field_print): Delete.
3784         (_initialize_cp_valprint): Don't install "set print
3785         static-members", "set print vtbl", "set print object" here.
3786         * printcmd.c: Include "cli/cli-option.h" and
3787         "common/gdb_optional.h".
3788         (print_command_parse_format): Rework to fill in a
3789         value_print_options instead of a format_data.
3790         (print_value): Change parameter type from format_data pointer to
3791         value_print_options reference.  Adjust.
3792         (print_command_1): Process options.  Adjust to pass down a
3793         value_print_options.
3794         (print_command_completer): New.
3795         (_initialize_printcmd): Install print_command_completer as
3796         handle_brkchars completer for the "print" command.  Update
3797         "print"'s help to include supported options.
3798         * valprint.c: Include "cli/cli-option.h".
3799         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3800         here from cp-valprint.c.
3801         (boolean_option_def, uinteger_option_def)
3802         (value_print_option_defs, make_value_print_options_def_group):
3803         New.  Use gdb::option::add_setshow_cmds_for_options to install
3804         "set print elements", "set print null-stop", "set print repeats",
3805         "set print pretty", "set print union", "set print array", "set
3806         print address", "set print symbol", "set print array-indexes".
3807         * valprint.h: Include <string> and "cli/cli-option.h".
3808         (make_value_print_options_def_group): Declare.
3809         (print_value): Change parameter type from format_data pointer to
3810         value_print_options reference.
3811         (print_command_completer): Declare.
3812
3813 2019-06-13  Pedro Alves  <palves@redhat.com>
3814
3815         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3816         (COMMON_SFILES): Add maint-test-settings.c.
3817         * cli/cli-decode.c (boolean_enums): New global, factored out from
3818         ...
3819         (add_setshow_boolean_cmd): ... here.
3820         * cli/cli-decode.h (boolean_enums): Declare.
3821         * cli/cli-option.c: New file.
3822         * cli/cli-option.h: New file.
3823         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3824         factored out from ...
3825         (parse_cli_boolean_value(const char *)): ... this.
3826         (is_unlimited_literal): Change parameter type to pointer to
3827         pointer.  Adjust and advance ARG pointer.
3828         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3829         (parse_cli_var_enum): New, factored out from ...
3830         (do_set_command): ... this.  Adjust.
3831         * cli/cli-setshow.h (parse_cli_boolean_value)
3832         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3833         (parse_cli_var_enum): Declare.
3834         * cli/cli-utils.c: Include "cli/cli-option.h".
3835         (get_ulongest): New.
3836         * cli/cli-utils.h (get_ulongest): Declare.
3837         (check_for_argument): New overloads.
3838         * maint-test-options.c: New file.
3839
3840 2019-06-13  Pedro Alves  <palves@redhat.com>
3841
3842         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3843         parse a range if "-" is at the end of the string.
3844
3845 2019-06-13  Pedro Alves  <palves@redhat.com>
3846
3847         * cli/cli-setshow.c (parse_auto_binary_operation)
3848         (parse_cli_boolean_value): Don't allow "o".
3849
3850 2019-06-13  Pedro Alves  <palves@redhat.com>
3851
3852         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3853         * NEWS: Mention maint test-settings KIND.
3854         * maint-test-settings.c: New file.
3855
3856 2019-06-13  Pedro Alves  <palves@redhat.com>
3857
3858         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3859         completer.
3860         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3861         "set" completers.
3862
3863 2019-06-13  Pedro Alves  <palves@redhat.com>
3864
3865         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3866         after item.
3867
3868 2019-06-13  Pedro Alves  <palves@redhat.com>
3869
3870         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3871
3872 2019-06-13  Pedro Alves <palves@redhat.com>
3873
3874         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3875         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3876         call.
3877         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3878         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3879         calls.
3880         (check_for_argument): Skip spaces after argument.
3881
3882 2019-06-13  Pedro Alves  <palves@redhat.com>
3883
3884         * thread.c (thread_apply_command): Adjust TID parsing.
3885         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3886         detected before end of string.
3887         (tid_is_in_list): Error out if LIST is invalid.
3888
3889 2019-06-13  Pedro Alves  <palves@redhat.com>
3890
3891         * completer.c (complete_line_internal_1): Rewind completion word
3892         point.
3893         (completion_tracker::advance_custom_word_point_by): Change
3894         parameter type to int.
3895         * completer.h (completion_tracker::advance_custom_word_point_by):
3896         Likewise.
3897
3898 2019-06-13  Pedro Alves  <palves@redhat.com>
3899
3900         * completer.c (advance_to_completion_word): Handle delimiters.
3901
3902 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3903
3904         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3905
3906 2019-06-11  Tom Tromey  <tom@tromey.com>
3907
3908         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3909         (xmalloc_failed): Move to alloc.c.
3910         * alloc.c: New file.
3911         * Makefile.in (COMMON_SFILES): Add alloc.c.
3912
3913 2019-06-11  Tom Tromey  <tom@tromey.com>
3914
3915         * nat/linux-waitpid.c: Don't include server.h.
3916         (linux_debug): Remove.
3917         (my_waitpid): Update.
3918
3919 2019-06-11  Tom Tromey  <tromey@adacore.com>
3920
3921         * infcall.c (_initialize_infcall): Remove trailing newline from
3922         help.
3923         * user-regs.c (_initialize_user_regs): Remove trailing newline
3924         from help.
3925         * typeprint.c (_initialize_typeprint): Remove trailing newline
3926         from help.
3927         * reverse.c (_initialize_reverse): Remove trailing newlines from
3928         help.
3929         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3930         from help.
3931         * language.c (add_set_language_command): Remove trailing newline
3932         from help.
3933         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3934         help.
3935         * disasm.c (_initialize_disasm): Remove trailing newline from
3936         help.
3937         * top.c (init_main): Remove trailing newline from help.
3938         * interps.c (_initialize_interpreter): Remove trailing newline
3939         from help.
3940         * btrace.c (_initialize_btrace): Remove trailing newlines from
3941         help.
3942         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3943         from help.
3944         * python/python.c (_initialize_python): Remove trailing newline
3945         from help.
3946         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3947         help.
3948         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3949         from help.  Reformat some text.
3950         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3951         from help.
3952         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3953         newline from help.
3954
3955 2019-06-11  Tom Tromey  <tromey@adacore.com>
3956
3957         * darwin-nat.c (darwin_decode_exception_message)
3958         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3959
3960 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3961
3962         * valops.c (value_slice): Check for not allocated or not
3963         associated values.
3964
3965 2019-06-10  Tom de Vries  <tdevries@suse.de>
3966
3967         PR gdb/24618
3968         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3969         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3970         invalid.
3971
3972 2019-06-10  Tom de Vries  <tdevries@suse.de>
3973
3974         PR gdb/24611
3975         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3976         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3977
3978 2019-06-10  Tom de Vries  <tdevries@suse.de>
3979
3980         PR symtab/24545
3981         * symtab.c (struct demangled_name_entry): Add language field.
3982         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3983         static minimal symbol".  Set and use language field.
3984
3985 2019-06-10  Tom Tromey  <tromey@adacore.com>
3986
3987         * ada-lang.c (_initialize_ada_language): Update help text.
3988
3989 2019-06-10  Tom Tromey  <tromey@adacore.com>
3990
3991         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3992         with a newline.
3993         * guile/guile.c (handle_boot_error): Don't end warning with a
3994         newline.
3995         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3996         warning with a newline.
3997         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3998         newline.
3999         (s12z_frame_cache): Likewise.
4000         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4001         a newline.
4002         * solib-svr4.c (disable_probes_interface): Don't end warning with
4003         a newline.
4004         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4005         newline.
4006         * python/python.c (do_finish_initialization): Don't end warning
4007         with a newline.
4008
4009 2019-06-10  Tom Tromey  <tom@tromey.com>
4010
4011         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4012         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4013         gdbpy_enter.
4014
4015 2019-06-10  Tom Tromey  <tromey@adacore.com>
4016
4017         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4018         data.
4019         (elf_new_init): Don't call stabsread_new_init.
4020         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4021         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4022         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4023
4024 2019-06-10  Tom de Vries  <tdevries@suse.de>
4025
4026         PR symtab/16264
4027         PR symtab/24517
4028         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4029
4030 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4031
4032         * source.c (find_and_open_source): Also rewrite relative file
4033         names.
4034
4035 2019-04-26  Amos Bird  <amosbird@gmail.com>
4036
4037         * annotate.c (annotate_thread_exited): Add "thread-exited"
4038         annotation.
4039
4040 2019-06-06  Tom Tromey  <tromey@adacore.com>
4041
4042         * maint.h (class scoped_command_stats): Use
4043         DISABLE_COPY_AND_ASSIGN.
4044         <print_time>: New method.
4045         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4046         print_time.
4047         (scoped_command_stats::print_time): New method.
4048
4049 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4050
4051         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4052         instructions of lengths 6 or 8 bytes.
4053
4054 2019-06-04  Pedro Alves  <palves@redhat.com>
4055
4056         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4057
4058         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4059         * breakpoint.c (condition_completer): Likewise.
4060         * cli/cli-dump.c (scan_expression): Likewise.
4061         * common/filestuff.c (mkdir_recursive): Likewise.
4062         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4063         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4064         (gdb_abspath): Likewise.
4065         * compile/compile-cplus-types.c
4066         (compile_cplus_instance::decl_name): Likewise.
4067         * completer.c (complete_explicit_location):
4068         (signal_completer, reg_or_group_completer_1): Likewise.
4069         * cp-support.c (cp_remove_params_if_any): Likewise.
4070         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4071         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4072         * infcmd.c (strip_bg_char): Likewise.
4073         * linespec.c (copy_token_string): Likewise.
4074         * mi/mi-main.c (output_cores): Likewise.
4075         * psymtab.c (psymtab_search_name):
4076         * symfile.c (test_set_ext_lang_command): Likewise.
4077         * target.c (target_fileio_read_stralloc): Likewise.
4078         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4079         * value.c (complete_internalvar): Likewise.
4080
4081 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4082
4083         Add objfile property to gdb.Type.
4084         * NEWS: Mention Python API addition.
4085         * python/py-type.c (typy_get_objfile): New method.
4086
4087 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4088
4089         * NEWS: Mention the new set|show style [title|highlight].
4090         Mention changes to "show style", "help" and "apropos".
4091
4092 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4093
4094         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4095         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4096         instead of print_help_for_command.
4097         (print_doc_of_command): New function.
4098         (help_list): Add 'apropos -v word' suggestion.
4099         (print_help_for_command): Style the command name using title style.
4100         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4101         (_initialize_cli_cmds): Describe -v in apropos_command help.
4102
4103 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4104
4105         * cli/cli-style.h (cli_style_option): Add name in constructor,
4106         add m_name class member, add constructor with intensity,
4107         add name class function.
4108         (cli_style_option::add_setshow_commands): Remove name argument.
4109         (highlight_style, title_style): New styles.
4110         * cli/cli-style.c (do_show): New function that shows a style
4111         characteristic styling the style name with itself.
4112         (set_style_name): New function.
4113         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4114         Update all callers according to the changes in cli/cli-style.h.
4115         * utils.h (fputs_highlighted): New function.
4116         * utils.c (fputs_highlighted): Likewise.
4117
4118 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4119
4120         * NEWS: Mention new pipe command and new convenience variables.
4121
4122 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4123
4124         * cli/cli-cmds.c (pipe_command): New function.
4125         (_initialize_cli_cmds): Call add_com for pipe_command.
4126         Define | as an alias for pipe.
4127         (exit_status_set_internal_vars): New function.
4128         (shell_escape): Call exit_status_set_internal_vars.
4129         cli/cli-decode.c (find_command_name_length): Recognize | as
4130         a single character command.
4131
4132 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4133
4134         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4135         top.c (execute_command_to_ui_file): New function, mostly a copy
4136         of execute_command_to_string.
4137         (execute_command_to_string): Implement by calling
4138         execute_command_to_ui_file.
4139
4140 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4141
4142         * top.h (saved_command_line): Remove declaration.
4143         * top.c (previous_saved_command_line, previous_repeat_arguments):
4144         New variables.
4145         (saved_command_line): Make static, define together with other
4146         'repeat variables'.
4147         (dont_repeat): Clear repeat_arguments.
4148         (repeat_previous, get_saved_command_line, save_command_line):
4149         New functions.
4150         (gdb_init): Initialize saved_command_line
4151         and previous_saved_command_line.
4152         * main.c (captured_main_1): Remove saved_command_line initialization.
4153         * event-top.c (handle_line_of_input): Update to use
4154         the new 'repeat' related functions instead of direct access to
4155         saved_command_line.
4156         * command.h (repeat_previous, get_saved_command_line,
4157         save_command_line): New declarations.
4158         (dont_repeat): Add comment.
4159
4160 2019-05-30  Tom Tromey  <tromey@adacore.com>
4161
4162         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4163         Fix comment.
4164         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4165
4166 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4167
4168         PR cli/24587
4169         * completer.c (complete): Initialize variable word.
4170
4171 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4172
4173         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4174         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4175         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4176         'body' is NULL to the outter 'if', protecting the '!is_define'
4177         situation as well.
4178
4179 2019-05-29  Tom Tromey  <tromey@adacore.com>
4180
4181         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4182         (dwarf_unknown): New function.
4183         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4184         (dwarf_type_encoding_name): Use dwarf_unknown.
4185
4186 2019-05-29  Tom Tromey  <tromey@adacore.com>
4187
4188         PR c++/20020:
4189         * cp-valprint.c (cp_print_value_fields): Call
4190         cp_print_static_field inside "try".
4191
4192 2019-05-29  Tom Tromey  <tromey@adacore.com>
4193
4194         * inflow.c (struct terminal_info): Add default operator=.
4195         * configure: Rebuild.
4196         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4197         -Wdeprecated-copy-dtor, -Wredundant-move.
4198
4199 2019-05-29  Tom Tromey  <tromey@adacore.com>
4200
4201         * NEWS: Add entry.
4202         * infcmd.c (print_return_value_1): Handle finish_print
4203         option.
4204         (show_print_finish): New function.
4205         (_initialize_infcmd): Add "set/show print finish" commands.
4206         * valprint.c (user_print_options): Initialize new member.
4207         * valprint.h (struct value_print_options) <finish_print>: New
4208         member.
4209
4210 2019-05-28  Tom Tromey  <tromey@adacore.com>
4211
4212         * ada-lang.c (ada_remove_Xbn_suffix)
4213         (find_old_style_renaming_symbol)
4214         (parse_old_style_renaming): Remove.
4215         (ada_find_renaming_symbol): Don't call
4216         find_old_style_renaming_symbol.
4217         (ada_is_renaming_symbol): Rename from
4218         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4219         bool.  Now static.
4220         (ada_read_var_value): Update and simplify.
4221         * ada-exp.y (write_var_or_type): Remove old code.
4222
4223 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4224
4225         * event-top.c: Remove include comment.
4226         * inflow.c (class scoped_ignore_sigttou): Move from here...
4227         * inflow.h (class scoped_ignore_sigttou): ...to here.
4228         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4229         * top.c:  Remove include comment.
4230
4231 2019-05-27  Tom Tromey  <tom@tromey.com>
4232
4233         * NEWS: Fix typo.
4234
4235 2019-05-22  Tom Tromey  <tromey@adacore.com>
4236
4237         * target.c (target_follow_exec): Constify parameter.
4238         * target-delegates.c: Rebuild.
4239         * remote.c (remote_target::follow_exec): Constify parameter.
4240         * infrun.c (follow_exec): Constify parameter.
4241         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4242         (target_follow_exec): Likewise.
4243
4244 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4245
4246         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4247         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4248
4249 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4250
4251         * NEWS: Add debugredirect and testsuite sections.
4252
4253 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4254
4255         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4256         target descriptions using exclusively floating point register name
4257         aliases.
4258
4259 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4260
4261         PR gdb/18644:
4262         * f-lang.c (build_fortran_types): Handle the case where
4263         gdbarch_floatformat_for_type returns a nullptr.
4264
4265 2019-05-21  Tom de Vries  <tdevries@suse.de>
4266
4267         PR cli/24587
4268         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4269
4270 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4271
4272         PR gdb/18644:
4273         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4274         16-byte floats.
4275         * i386-tdep.c (i386_floatformat_for_type): Use
4276         floatformats_ia64_quad for the 16-byte floating point component
4277         within a fortran 32-byte complex number.
4278
4279 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4280
4281         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4282         delete default constructor.
4283         (find_partial_die): Update to return const struct.
4284         (partial_die_parent_scope): Move variable declaration into scope
4285         of its use and change its type to auto.
4286         (guess_partial_die_structure_name): Likewise.
4287         (partial_die_info::fixup): Likewise.
4288
4289 2019-05-17  Tom Tromey  <tromey@adacore.com>
4290
4291         * source.c (find_and_open_source): Remove cast.
4292
4293 2019-05-17  Tom Tromey  <tromey@adacore.com>
4294
4295         * annotate.c (annotate_source): Make "filename" const.
4296         * annotate.h (annotate_source): Use const.
4297
4298 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4299
4300         * disasm.c (set_disassembler_options): Send errors to stderr.
4301
4302 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4303
4304         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4305         (cli_interp_base::set_logging): Check debug_redirect.
4306         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4307         * cli/cli-logging.c (debug_redirect): Add static variable.
4308         (pop_output_files): Add default param.
4309         (handle_redirections): Print debug setting.
4310         (show_logging_command): Likewise.
4311         (_initialize_cli_logging): Add debugredirect command.
4312         * interps.c (current_interp_set_logging): Add debug_redirect
4313         parameter.
4314         * interps.h (set_logging): Add debug_redirect parameter.
4315         (current_interp_set_logging): Likewise.
4316         * mi/mi-common.h: Likewise.
4317         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4318
4319 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4320             Tom Tromey  <tromey@adacore.com>
4321
4322         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4323         directly.
4324         * cli/cli-interp.h (make_logging_output): Remove declaration.
4325         * cli/cli-logging.c (make_logging_output): Remove function.
4326         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4327         directly.
4328         * ui-file.c (tee_file::tee_file): Remove bools.
4329         (tee_file::~tee_file): Remove deletes.
4330         * ui-file.h (tee_file): Remove bools.
4331
4332 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4333
4334         * mi/mi-cmds.h (mi_cmd_complete): New function.
4335         * mi/mi-main.c (mi_cmd_complete): Likewise.
4336         * mi/mi-cmds.c: Define new MI command -complete.
4337         * NEWS: Mention new -complete command.
4338
4339 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4340
4341         * completer.h (complete): New function.
4342         * completer.c (complete): Likewise.
4343         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4344         function defined in completer.h.
4345
4346 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4347
4348         * MAINTAINERS (Write After Approval): Add myself.
4349
4350 2019-05-17  Tom de Vries  <tdevries@suse.de>
4351
4352         PR gdb/24094
4353         * dwarf2read.c (struct cu_partial_die_info): New struct.
4354         (find_partial_die): Return cu_partial_die_info.
4355         (partial_die_parent_scope, guess_partial_die_structure_name)
4356         (partial_die_info::fixup): Handle new return type of find_partial_die.
4357
4358 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4359
4360         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4361         "std::string", simplifying the algorithm.
4362
4363 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4364
4365         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4366         (stap_static_probe_ops::get_probes): Likewise.
4367
4368 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4369
4370         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4371         '-')" and "else if".
4372         (stap_parse_single_operand): Join checks for
4373         "gdbarch_stap_parse_special_token_p" and
4374         "gdbarch_stap_parse_special_token" in the same "if" statement.
4375         Invert check when verifying for operation on register
4376         displacement.
4377
4378 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4379
4380         * stap-probe.c (stap_get_opcode): Update comment.
4381         (stap_get_expected_argument_type): Likewise.
4382         (handle_stap_probe): Likewise.
4383
4384 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4385
4386         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4387         return type to 'bool'.  Adjust comment.  Use 'bool' when
4388         appropriate.
4389         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4390         * stap-probe.c (stap_parse_argument_1): Likewise.
4391         (stap_is_operator): Likewise.
4392         (stap_is_generic_prefix): Likewise.
4393         (stap_is_register_prefix): Likewise.
4394         (stap_is_register_indirection_prefix): Likewise.
4395         (stap_is_integer_prefix): Likewise.
4396         (stap_generic_check_suffix): Likewise.
4397         (stap_check_integer_suffix): Likewise.
4398         (stap_check_register_suffix): Likewise.
4399         (stap_check_register_indirection_suffix): Likewise.
4400         (stap_parse_register_operand): Likewise.
4401         (stap_parse_single_operand): Likewise.
4402         (stap_parse_argument_1): Likewise.
4403         (stap_probe::get_argument_count): Likewise.
4404         (stap_is_operator): Likewise.
4405
4406 2019-05-16  Tom Tromey  <tromey@adacore.com>
4407
4408         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4409         keyword to foreach.
4410
4411 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4412
4413         * linux-thread-db.c (try_thread_db_load_1): Change return type
4414         to bool.
4415         (try_thread_db_load): Likewise.
4416         (try_thread_db_load_from_pdir_1): Likewise.
4417         (try_thread_db_load_from_pdir): Likewise.
4418         (try_thread_db_load_from_sdir): Likewise.
4419         (try_thread_db_load_from_dir): Likewise.
4420         (thread_db_load_search): Likewise.
4421         (has_libpthread): Likewise.
4422         (thread_db_load): Likewise.
4423
4424 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4425
4426         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4427         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4428         NULL, and complain/return if that's the case.
4429
4430 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4431
4432         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4433         (advance, posn, abstract_read_memory): New functions.
4434         [struct mem_read_abstraction]: New struct.
4435         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4436
4437 2019-05-14  Tom Tromey  <tromey@adacore.com>
4438
4439         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4440         value is not lval_memory.
4441
4442 2019-05-14  Tom Tromey  <tromey@adacore.com>
4443
4444         * solib.c (info_sharedlibrary_command): Style the file name.
4445
4446 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4447
4448         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4449         (aarch64_vnv_type): Likewise.
4450         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4451         * common/tdesc.c: Likewise.
4452         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4453         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4454         * features/aarch64-fpu.xml: Add ieee half view.
4455         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4456         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4457         * gdbtypes.h (struct builtin_type): Likewise.
4458         (struct objfile_type): Likewise.
4459
4460 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4461
4462         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4463         typo.
4464         * location.h (string_to_event_location): Likewise.
4465
4466 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4467
4468         GDB 8.3 released.
4469
4470 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4471
4472         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4473         New variable declaration.
4474         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4475         New variable.
4476         (print_one_breakpoint): Use ui_out::test_flags and new global
4477         variable to compute use_fixed_output.
4478         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4479         Remove.
4480         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4481         (mi_multi_location_breakpoint_output_fixed): Remove.
4482         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4483         new variable.
4484         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4485         fix_multi_location_breakpoint_output flag if version >= 3.
4486         * ui-out.h (enum ui_out_flag)
4487         <fix_multi_location_breakpoint_output>: New enumerator.
4488
4489 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4490
4491         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4492
4493 2019-05-10  Tom Tromey  <tromey@adacore.com>
4494
4495         * ada-lang.c (catch_ada_completer): New function.
4496         (_initialize_ada_language): Use it.
4497
4498 2019-05-10  Tom Tromey  <tromey@adacore.com>
4499
4500         * thread.c (print_thread_info): Make "requested_threads" const.
4501         * gdbthread.h (print_thread_info): Make "requested_threads"
4502         const.
4503         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4504         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4505
4506 2019-05-08  Tom Tromey  <tom@tromey.com>
4507
4508         * gdbtypes.c (objfile_type_data): Change type.
4509         (objfile_type, _initialize_gdbtypes): Update.
4510
4511 2019-05-08  Tom Tromey  <tom@tromey.com>
4512
4513         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4514         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4515         (_initialize_dwarf2_frame): Update.
4516
4517 2019-05-08  Tom Tromey  <tom@tromey.com>
4518
4519         * objc-lang.c (objc_objfile_data): Change type.
4520         (find_methods): Update.
4521         (_initialize_objc_lang): Remove.
4522
4523 2019-05-08  Tom Tromey  <tom@tromey.com>
4524
4525         * stabsread.c (rs6000_builtin_type_data): Change type.
4526         (rs6000_builtin_type, _initialize_stabsread): Update.
4527
4528 2019-05-08  Tom Tromey  <tom@tromey.com>
4529
4530         * mips-tdep.c (mips_pdr_data): Remove.
4531         (_initialize_mips_tdep): Update.
4532
4533 2019-05-08  Tom Tromey  <tom@tromey.com>
4534
4535         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4536         (hppa_init_objfile_priv_data, read_unwind_info)
4537         (find_unwind_entry, _initialize_hppa_tdep): Update.
4538
4539 2019-05-08  Tom Tromey  <tom@tromey.com>
4540
4541         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4542         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4543         on obstack.
4544         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4545
4546 2019-05-08  Tom Tromey  <tom@tromey.com>
4547
4548         * mdebugread.c (basic_type_data): Change type.
4549         (basic_type, _initialize_mdebugread): Update.
4550
4551 2019-05-08  Tom Tromey  <tom@tromey.com>
4552
4553         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4554
4555 2019-05-08  Tom Tromey  <tom@tromey.com>
4556
4557         * nto-tdep.c (nto_inferior_data_reg): Change type.
4558         (nto_inferior_data): Update.
4559         (nto_inferior_data_cleanup, nto_new_inferior_data)
4560         (_initialize_nto_tdep): Remove.
4561         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4562
4563 2019-05-08  Tom Tromey  <tom@tromey.com>
4564
4565         * ada-lang.c (struct ada_inferior_data): Add initializers.
4566         (ada_inferior_data): Change type.
4567         (ada_inferior_data_cleanup): Remove.
4568         (get_ada_inferior_data, ada_inferior_exit)
4569         (struct ada_pspace_data): Add initializers, destructor.
4570         (ada_pspace_data_handle): Change type.
4571         (get_ada_pspace_data): Update.
4572         (ada_pspace_data_cleanup): Remove.
4573
4574 2019-05-08  Tom Tromey  <tom@tromey.com>
4575
4576         * coffread.c (struct coff_symfile_info): Add initializers.
4577         (coff_objfile_data_key): Move lower.  Change type.
4578         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4579         Update.
4580         (coff_free_info): Remove.
4581
4582 2019-05-08  Tom Tromey  <tom@tromey.com>
4583
4584         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4585         (fbsd_pspace_data_handle): Move lower.  Change type.
4586         (get_fbsd_pspace_data): Update.
4587         (fbsd_pspace_data_cleanup): Remove.
4588         (_initialize_fbsd_tdep): Update.
4589
4590 2019-05-08  Tom Tromey  <tom@tromey.com>
4591
4592         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4593         (get_ada_tasks_pspace_data): Update.
4594         (ada_tasks_pspace_data_cleanup): Remove.
4595         (_initialize_tasks): Update.
4596         (ada_tasks_inferior_data_handle): Change type.
4597         (get_ada_tasks_inferior_data): Update.
4598         (ada_tasks_inferior_data_cleanup): Remove.
4599         (struct ada_tasks_pspace_data): Add initializers.
4600
4601 2019-05-08  Tom Tromey  <tom@tromey.com>
4602
4603         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4604         * symfile-debug.c (debug_sym_get_probes): Change type.
4605         * stap-probe.c (handle_stap_probe):
4606         (stap_static_probe_ops::get_probes): Change type.
4607         * probe.h (class static_probe_ops) <get_probes>: Change type.
4608         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4609         (parse_probes_in_pspace): Update.
4610         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4611         Update.
4612         (any_static_probe_ops::get_probes): Change type.
4613         * elfread.c (elfread_data): New typedef.
4614         (probe_key): Change type.
4615         (elf_get_probes): Likewise.  Update.
4616         (probe_key_free): Remove.
4617         (_initialize_elfread): Update.
4618         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4619         Change type.
4620         (dtrace_process_dof_probe, dtrace_process_dof)
4621         (dtrace_static_probe_ops::get_probe): Change type.
4622
4623 2019-05-08  Tom Tromey  <tom@tromey.com>
4624
4625         * xcoffread.c (struct xcoff_symfile_info): Rename from
4626         coff_symfile_info.  Add initializers.
4627         (xcoff_objfile_data_key): Move lower.  Change type.
4628         (XCOFF_DATA): Rewrite.
4629         (xcoff_free_info): Remove.
4630         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4631         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4632         (xcoff_initial_scan): Update.
4633
4634 2019-05-08  Tom Tromey  <tom@tromey.com>
4635
4636         * solib-svr4.c (struct svr4_info): Add initializers and
4637         destructor.
4638         <probes_table>: Now an htab_up.
4639         (solib_svr4_pspace_data): Change type.
4640         (free_probes_table): Simplify.
4641         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4642         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4643         (probes_table_remove_objfile_probes, register_solib_event_probe)
4644         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4645         (_initialize_svr4_solib): Update.
4646
4647 2019-05-08  Tom Tromey  <tom@tromey.com>
4648
4649         * remote.c (remote_pspace_data): Change type.
4650         (remote_pspace_data_cleanup): Remove.
4651         (get_remote_exec_file, set_pspace_remote_exec_file)
4652         (_initialize_remote): Update.
4653
4654 2019-05-08  Tom Tromey  <tom@tromey.com>
4655
4656         * breakpoint.c (breakpoint_objfile_key): Change type.
4657         (get_breakpoint_objfile_data): Update.
4658         (free_breakpoint_objfile_data): Remove.
4659         (_initialize_breakpoint): Update.
4660
4661 2019-05-08  Tom Tromey  <tom@tromey.com>
4662
4663         * linux-tdep.c (struct linux_info): Add initializers.
4664         (linux_inferior_data): Move.  Change type.
4665         (invalidate_linux_cache_inf): Update.
4666         (linux_inferior_data_cleanup): Remove.
4667         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4668
4669 2019-05-08  Tom Tromey  <tom@tromey.com>
4670
4671         * auxv.c (auxv_inferior_data): Move.  Change type.
4672         (auxv_inferior_data_cleanup): Remove.
4673         (invalidate_auxv_cache_inf): Rewrite.
4674         (get_auxv_inferior_data, _initialize_auxv): Update.
4675
4676 2019-05-08  Tom Tromey  <tom@tromey.com>
4677
4678         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4679         (symfile_debug_objfile_data_key): Change type.
4680         (symfile_debug_installed, debug_qf_has_symbols)
4681         (debug_qf_find_last_source_symtab)
4682         (debug_qf_forget_cached_source_info)
4683         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4684         (debug_qf_print_stats, debug_qf_dump)
4685         (debug_qf_expand_symtabs_for_function)
4686         (debug_qf_expand_all_symtabs)
4687         (debug_qf_expand_symtabs_with_fullname)
4688         (debug_qf_map_matching_symbols)
4689         (debug_qf_expand_symtabs_matching)
4690         (debug_qf_find_pc_sect_compunit_symtab)
4691         (debug_qf_map_symbol_filenames)
4692         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4693         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4694         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4695         (debug_sym_read_linetable, debug_sym_relocate): Update.
4696         (symfile_debug_free_objfile): Remove.
4697         (install_symfile_debug_logging, _initialize_symfile_debug):
4698         Update.
4699
4700 2019-05-08  Tom Tromey  <tom@tromey.com>
4701
4702         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4703         allocate_on_obstack.
4704         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4705         (get_dwarf2_per_objfile): Update.
4706         (set_dwarf2_per_objfile): Remove.
4707         (dwarf2_has_info, dwarf2_get_section_info): Update.
4708         (dwarf2_free_objfile): Remove.
4709         (_initialize_dwarf2_read): Update.
4710
4711 2019-05-08  Tom Tromey  <tom@tromey.com>
4712
4713         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4714         initializers.
4715         <unsupported_script_warning_printed,
4716         script_not_found_warning_printed>: Now bool.
4717         (auto_load_pspace_data): Change type.
4718         (~auto_load_pspace_info): Rename from
4719         auto_load_pspace_data_cleanup.
4720         (get_auto_load_pspace_data, init_loaded_scripts_info)
4721         (clear_section_scripts, maybe_print_unsupported_script_warning)
4722         (maybe_print_script_not_found_warning, _initialize_auto_load):
4723         Update.
4724
4725 2019-05-08  Tom Tromey  <tom@tromey.com>
4726
4727         * objfiles.c (objfile_pspace_info): Add destructor and
4728         initializers.
4729         (objfiles_pspace_data): Change type.
4730         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4731         (get_objfile_pspace_data): Update.
4732         (objfiles_bfd_data): Change type.
4733         (get_objfile_bfd_data): Update.
4734         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4735
4736 2019-05-08  Tom Tromey  <tom@tromey.com>
4737
4738         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4739         Change type.
4740         (get_catch_syscall_inferior_data): Update.
4741         (catch_syscall_inferior_data_cleanup): Remove.
4742         (_initialize_break_catch_syscall): Update.
4743
4744 2019-05-08  Tom Tromey  <tom@tromey.com>
4745
4746         * inflow.c (struct terminal_info): Add destructor and
4747         initializers.
4748         (inflow_inferior_data): Change type.
4749         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4750         (get_inflow_inferior_data, inflow_inferior_exit)
4751         (swap_terminal_info, _initialize_inflow): Update.
4752
4753 2019-05-08  Tom Tromey  <tom@tromey.com>
4754
4755         * target-dcache.c (target_dcache_cleanup): Remove.
4756         (target_dcache_aspace_key): Change type.
4757         (target_dcache_init_p, target_dcache_invalidate)
4758         (target_dcache_get, target_dcache_get_or_init)
4759         (_initialize_target_dcache): Update.
4760         * dcache.h (struct dcache_deleter): New.
4761
4762 2019-05-08  Tom Tromey  <tom@tromey.com>
4763
4764         * symtab.c (struct symbol_cache): Add destructor and
4765         initializers.
4766         (symbol_cache_key): Move.  Change type.
4767         (make_symbol_cache, free_symbol_cache): Remove.
4768         (get_symbol_cache): Update.
4769         (symbol_cache_cleanup): Remove.
4770         (ALL_PSPACES, symbol_cache_flush)
4771         (maintenance_print_symbol_cache)
4772         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4773         Update.
4774
4775 2019-05-08  Tom Tromey  <tom@tromey.com>
4776
4777         * symtab.c (struct main_info): Add destructor and initializers.
4778         (main_progspace_key): Move.  Change type.
4779         (get_main_info): Update.
4780         (main_info_cleanup): Remove.
4781         (_initialize_symtab): Update.
4782
4783 2019-05-08  Tom Tromey  <tom@tromey.com>
4784
4785         * registry.h (DECLARE_REGISTRY): Define the _key class.
4786
4787 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4788
4789         * NEWS: Merge two 'New commands' sections.
4790
4791 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4792
4793         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4794         parameter and use Ada language definition instead.
4795         (ada_val_print_ptr): Remove unused language parameter.
4796         (ada_val_print_num): Remove language parameter and use Ada language
4797         definition instead.
4798         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4799         parameter.
4800         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4801         parameter and use Ada language definition instead.
4802         (ada_val_print_1): Update all ada_val_print_xxx calls.
4803         Remove language parameter.
4804         (ada_val_print): Update ada_val_print_1 call.
4805
4806 2019-05-08  Tom Tromey  <tromey@adacore.com>
4807
4808         * remote.c (remote_hw_watchpoint_limit)
4809         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4810         Now static.
4811
4812 2019-05-08  Tom Tromey  <tromey@adacore.com>
4813
4814         * maint.c (_initialize_maint_cmds): Move initialization code to
4815         remote.c.
4816         (watchdog, show_watchdog): Move to remote.c.
4817         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4818         "watchdog" static.
4819         (_initialize_remote): Move initialization code from maint.c.
4820         * defs.h (watchdog): Don't declare.
4821
4822 2019-05-08  Tom Tromey  <tromey@adacore.com>
4823
4824         * tui/tui-interp.c: Include main.h.
4825         * interps.c: Include main.h.
4826         * main.h (interpreter_p): Declare.
4827         * defs.h (interpreter_p): Don't declare.
4828
4829 2019-05-08  Tom Tromey  <tromey@adacore.com>
4830
4831         * dwarf2loc.c: Include dwarf2read.h.
4832         * defs.h (read_unsigned_leb128): Don't declare.
4833         * dwarf2read.h (read_unsigned_leb128): Declare.
4834
4835 2019-05-08  Tom Tromey  <tromey@adacore.com>
4836
4837         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4838         method.
4839
4840 2019-05-08  Tom Tromey  <tromey@adacore.com>
4841
4842         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4843         when no wrap column is set.
4844
4845 2019-05-08  Tom Tromey  <tromey@adacore.com>
4846
4847         * c-lang.c (c_get_string): Handle non-C-style arrays.
4848
4849 2019-05-08  Tom Tromey  <tromey@adacore.com>
4850
4851         * typeprint.c (print_offset_data::update): Print the bit offset,
4852         not the number of bits remaining.
4853
4854 2019-05-08  Tom Tromey  <tromey@adacore.com>
4855
4856         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4857         padding at end of comment.
4858
4859 2019-05-08  Tom Tromey  <tromey@adacore.com>
4860
4861         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4862         Compare main types.
4863
4864 2019-05-06  Tom Tromey  <tom@tromey.com>
4865
4866         * common/scoped_mmap.c: Include common-defs.h.
4867         * common/scoped_mmap.h: Don't include config.h.
4868
4869 2019-05-04  Tom Tromey  <tom@tromey.com>
4870
4871         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4872         (struct aarch64_call_info): Add initializers.
4873         <si>: Now a std::vector.
4874         (pass_on_stack, aarch64_push_dummy_call): Update.
4875
4876 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4877             Tom Tromey  <tom@tromey.com>
4878
4879         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4880         (ppc_threads): Now a std::vector.  Now static.
4881         (hwdebug_find_thread_points_by_tid)
4882         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4883         Update.
4884
4885 2019-05-04  Tom Tromey  <tom@tromey.com>
4886
4887         * arc-tdep.c (arc_tdesc_init): Return bool.
4888
4889 2019-05-04  Tom Tromey  <tom@tromey.com>
4890
4891         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4892         Use gdb_assert_not_reached.
4893
4894 2019-05-04  Tom Tromey  <tom@tromey.com>
4895
4896         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4897         "false".
4898
4899 2019-05-04  Tom Tromey  <tom@tromey.com>
4900
4901         * arc-tdep.c (arc_tdesc_init): Use bool.
4902
4903 2019-05-04  Tom Tromey  <tom@tromey.com>
4904
4905         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4906
4907 2019-05-04  Tom Tromey  <tom@tromey.com>
4908
4909         * cli/cli-cmds.c (valid_command_p): Return bool.
4910
4911 2019-05-04  Tom Tromey  <tom@tromey.com>
4912
4913         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4914         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4915
4916 2019-05-04  Raul Tambre  <raul@tambre.ee>
4917
4918         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4919         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4920         operator for comparison.
4921
4922 2019-05-04  Tom Tromey  <tom@tromey.com>
4923
4924         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4925         (lookup_partial_symbol, print_partial_symbols)
4926         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4927         (psymbol_compare): Update.
4928         (add_psymbol_to_bcache): Clear the entire psymbol.
4929         (maintenance_check_psymtabs): Update.
4930         * psympriv.h (struct partial_symbol): Don't derive from
4931         general_symbol_info.
4932         <obj_section, unrelocated_address, address,
4933         set_unrelocated_address>: Update.
4934         <ginfo>: New member.
4935         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4936         (debug_names::write_psymbols): Update.
4937
4938 2019-05-04  Tom de Vries  <tdevries@suse.de>
4939
4940         * contrib/cc-with-tweaks.sh: Support -n arg.
4941
4942 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4943
4944         * corelow.c (core_target::detach): Ensure frame cache and
4945         register caches are cleared.
4946         inferior.c (exit_inferior_1): Likewise.
4947
4948 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4949             Tom Tromey  <tom@tromey.com>
4950
4951         * dictionary.c (collate_pending_symbols_by_language): Remove
4952         "struct" from foreach.
4953         * symtab.c (lookup_global_symbol_from_objfile)
4954         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4955         foreach.
4956         * ser-tcp.c (net_open): Remove "struct" from foreach.
4957         * objfiles.c (objfile_relocate, objfile_rebase)
4958         (objfile_has_symbols): Remove "struct" from foreach.
4959         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4960         from foreach.
4961         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4962         foreach.
4963         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4964         "struct" from foreach.
4965         * ada-lang.c (create_excep_cond_exprs)
4966         (ada_exception_catchpoint_cond_string): Remove "struct" from
4967         foreach.
4968
4969 2019-05-03  Tom Tromey  <tromey@adacore.com>
4970
4971         * ada-exp.y (convert_char_literal): Check suffix of each
4972         enumerator.
4973
4974 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4975
4976         PR ada/21406:
4977         * ada-exp.y (yywrap): Don't define.
4978         * ada-lex.l (%option): Add noyywrap
4979         (yywrap): Remove.
4980
4981 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4982
4983         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4984         _WIN32_WINNT to the XP level, unless already defined to a higher
4985         level.
4986
4987         * unittests/parse-connection-spec-selftests.c:
4988         * ser-tcp.c:
4989         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4990         override.
4991
4992         * symfile.c (find_separate_debug_file): Remove colon from the
4993         drive spec of DOS/Windows file names of the target, so that the
4994         file name produced from DEBUGDIR and the target's directory will
4995         be valid on DOS/Windows systems.
4996
4997 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4998
4999         * rust-lang.c (val_print_struct): Handle printing structures
5000         containing strings.
5001
5002 2019-05-02  Tom Tromey  <tromey@adacore.com>
5003
5004         * valarith.c (_initialize_valarith): Remove.
5005
5006 2019-05-01  Tom Tromey  <tromey@adacore.com>
5007
5008         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5009         bitfields.
5010
5011 2019-05-01  Tom Tromey  <tromey@adacore.com>
5012
5013         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5014         for big-endian copies.
5015
5016 2019-04-30  Ali Tamur  <tamur@google.com>
5017         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5018         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5019         (read_3_bytes): New function.
5020
5021 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5022
5023         * windows-nat.c (main_thread_id): Delete.
5024         (handle_output_debug_string): Replace main_thread_id by
5025         current_event.dwThreadId.
5026         (fake_create_process): Likewise.
5027         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5028         Do not set main_thread_id.
5029         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5030         current_event.dwThreadId.
5031         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5032
5033 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5034
5035         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5036         Use current_event.dwThreadId instead of main_thread_id.
5037
5038 2019-04-30  Tom Tromey  <tromey@adacore.com>
5039
5040         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5041         (create_excep_cond_exprs): Iterate over program spaces.
5042         (ada_exception_catchpoint_cond_string): Examine all minimal
5043         symbols for exception types.
5044
5045 2019-04-30  Tom Tromey  <tromey@adacore.com>
5046
5047         PR c++/24470:
5048         * dwarf2read.c (process_structure_scope): Handle case where type
5049         has template parameters but no symbol was created.
5050
5051 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5052             Chris January  <chris.january@arm.com>
5053
5054         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5055         qualifier.
5056         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5057
5058 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5059
5060         * f-typeprint.c (f_print_type): Update rules for printing
5061         whitespace.
5062         (f_type_print_varspec_suffix): Likewise.
5063
5064 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5065             Chris January  <chris.january@arm.com>
5066
5067         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5068         function arguments.
5069
5070 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5071
5072         * f-lang.c (build_fortran_types): Change name of void type to
5073         lower case.
5074         * f-typeprint.c (f_type_print_base): Print the name of the void
5075         type, rather than a fixed string.
5076         * f-valprint.c (f_decorations): Use lower case void string.
5077
5078 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5079             Chris January  <chris.january@arm.com>
5080
5081         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5082         types for Fortran.
5083
5084 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5085             Chris January  <chris.january@arm.com>
5086             David Lecomber  <david.lecomber@arm.com>
5087
5088         * f-exp.y (BINOP_INTRINSIC): New token.
5089         (exp): New parser rule handling BINOP_INTRINSIC.
5090         (f77_keywords): Add new builtin procedures.
5091         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5092         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5093         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5094         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5095         (print_unop_subexp_f): New function.
5096         (print_binop_subexp_f): New function.
5097         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5098         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5099         (dump_subexp_body_f): Likewise.
5100         (operator_check_f): Likewise.
5101         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5102         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5103
5104 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5105
5106         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5107         UNOP_KIND.
5108         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5109         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5110         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5111         (operator_length_f): New fuction.
5112         (print_subexp_f): New function.
5113         (op_name_f): New function.
5114         (dump_subexp_body_f): New function.
5115         (operator_check_f): New function.
5116         (exp_descriptor_f): Replace standard expression handling functions
5117         with new functions.
5118         * gdb/fortran-operator.def: New file.
5119         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5120         * gdb/std-operator.def: Remove UNOP_KIND.
5121
5122 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5123
5124         * std-operator.def: Remove unbalanced, stray double quote
5125         character.
5126
5127 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5128             Chris January  <chris.january@arm.com>
5129             Daniel Everett  <daniel.everett@arm.com>
5130             Nick Forrington  <nick.forrington@arm.com>
5131             Richard Bunt  <richard.bunt@arm.com>
5132
5133         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5134         of depth when printing anonymous structs or unions.
5135         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5136         Don't print either the top-level value, or the children if the
5137         max-depth is exceeded.
5138         (ppscm_print_children): When printing the key of a map, allow one
5139         extra level of depth.
5140         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5141         print either the top-level value, or the children if the max-depth
5142         is exceeded.
5143         (print_children): When printing the key of a map, allow one extra
5144         level of depth.
5145         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5146         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5147         (user_print_options): Initialise max_depth field.
5148         (val_print_scalar_or_string_type_p): New function.
5149         (val_print): Check to see if the max depth has been reached.
5150         (val_print_check_max_depth): Define new function.
5151         (show_print_max_depth): New function.
5152         (_initialize_valprint): Add 'print max-depth' option.
5153         * valprint.h (struct value_print_options) <max_depth>: New field.
5154         (val_print_check_max_depth): Declare new function.
5155         * NEWS: Document new feature.
5156
5157 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5158
5159         * ada-lang.c (ada_language_defn): Initialise new field.
5160         * c-lang.c (c_is_string_type_p): New function.
5161         (c_language_defn): Initialise new field.
5162         (cplus_language_defn): Initialise new field.
5163         (asm_language_defn): Initialise new field.
5164         (minimal_language_defn): Initialise new field.
5165         * c-lang.h (c_is_string_type_p): Declare new function.
5166         * d-lang.c (d_language_defn): Initialise new field.
5167         * f-lang.c (f_is_string_type_p): New function.
5168         (f_language_defn): Initialise new field.
5169         * go-lang.c (go_is_string_type_p): New function.
5170         (go_language_defn): Initialise new field.
5171         * language.c (default_is_string_type_p): New function.
5172         (unknown_language_defn): Initialise new field.
5173         (auto_language_defn): Initialise new field.
5174         * language.h (struct language_defn) <la_is_string_type_p>: New
5175         member variable.
5176         (default_is_string_type_p): Declare new function.
5177         * m2-lang.c (m2_language_defn): Initialise new field.
5178         * objc-lang.c (objc_language_defn): Initialise new field.
5179         * opencl-lang.c (opencl_language_defn): Initialise new field.
5180         * p-lang.c (pascal_is_string_type_p): New function.
5181         (pascal_language_defn): Initialise new field.
5182         * rust-lang.c (rust_is_string_type_p): New function.
5183         (rust_language_defn): Initialise new field.
5184
5185 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5186
5187         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5188         New field.
5189         * ada-lang.c (ada_language_defn): Initialise new field.
5190         * c-lang.c (c_language_defn): Likewise.
5191         (cplus_language_defn): Likewise.
5192         (asm_language_defn): Likewise.
5193         (minimal_language_defn): Likewise.
5194         * d-lang.c (d_language_defn): Likewise.
5195         * f-lang.c (f_language_defn): Likewise.
5196         * go-lang.c (go_language_defn): Likewise.
5197         * language.c (unknown_language_defn): Likewise.
5198         (auto_language_defn): Likewise.
5199         * m2-lang.c (m2_language_defn): Likewise.
5200         * objc-lang.c (objc_language_defn): Likewise.
5201         * opencl-lang.c (opencl_language_defn): Likewise.
5202         * p-lang.c (pascal_language_defn): Likewise.
5203         * rust-lang.c (rust_language_defn): Likewise.
5204
5205 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5206
5207         * ada-lang.c (ada_is_character_type): Change return type to bool.
5208         (ada_is_string_type): Likewise.
5209         * ada-lang.h (ada_is_character_type): Update declaration
5210         (ada_is_string_type): Likewise.
5211
5212 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5213
5214         Support style in 'frame|thread apply'
5215
5216         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5217         * record.c (record_start, record_stop): Update callers of
5218         execute_command_to_string with false.
5219         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5220         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5221         methods.
5222         (class string_file): New constructor with term_out parameter.
5223         Override methods term_out and can_emit_style_escape.  New member
5224         term_out.
5225         (class stdio_file): Override can_emit_style_escape.
5226         (class tee_file): Override term_out and can_emit_style_escape.
5227         * utils.h (can_emit_style_escape): Remove.
5228         * utils.c (can_emit_style_escape): Likewise.
5229         Update all callers of can_emit_style_escape (SOMESTREAM) to
5230         SOMESTREAM->can_emit_style_escape.
5231         * source-cache.c (source_cache::get_source_lines): Likewise.
5232         * stack.c (frame_apply_command_count): Call execute_command_to_string
5233         passing the term_out characteristic of the current gdb_stdout.
5234         * thread.c (thr_try_catch_cmd): Likewise.
5235         * top.c (execute_command_to_string): pass term_out parameter
5236         to construct the string_file for the command output.
5237         * ui-file.c (term_cli_styling): New function (most code moved
5238         from utils.c can_emit_style_escape).
5239         (string_file::string_file, string_file::can_emit_style_escape,
5240         stdio_file::can_emit_style_escape, tee_file::term_out,
5241         tee_file::can_emit_style_escape): New functions.
5242
5243 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5244
5245         * NEWS: Mention the new set|show may-call-functions.
5246         * infcall.c (may_call_functions_p): New variable.
5247         (show_may_call_functions_p): New function.
5248         (call_function_by_hand_dummy): Throws an error if not
5249         may-call-functions.
5250         (_initialize_infcall): Call add_setshow_boolean_cmd for
5251         may-call-functions.
5252
5253 2019-04-25  Keith Seitz  <keiths@redhat.com>
5254
5255         PR c++/24367
5256         * cp-support.c (inspect_type): Don't attempt substitutions
5257         of symbol with the same name.
5258
5259 2019-04-25  Tom Tromey  <tromey@adacore.com>
5260
5261         PR gdb/24475:
5262         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5263         static.
5264
5265 2019-04-25  Tom Tromey  <tromey@adacore.com>
5266
5267         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5268         rvalue reference.
5269         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5270         (gdb_xml_parser::parse): Use std::move.
5271         * python/python-internal.h (gdbpy_convert_exception): Take a const
5272         reference.
5273         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5274         std::move.
5275         * python/py-utils.c (gdbpy_convert_exception): Take a const
5276         reference.
5277         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5278         Use std::move.
5279         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5280         Use std::move.
5281         * mi/mi-main.c (mi_print_exception): Take a const reference.
5282         * main.c (handle_command_errors): Take a const reference.
5283         * linespec.c (parse_linespec): Use std::move.
5284         * infcall.c (run_inferior_call): Use std::move.
5285         (call_function_by_hand_dummy): Use std::move.
5286         * exec.c (try_open_exec_file): Use std::move.
5287         * exceptions.h (exception_print, exception_fprintf)
5288         (exception_print_same): Update.
5289         * exceptions.c (print_exception, exception_print)
5290         (exception_fprintf, exception_print_same): Change parameters to
5291         const reference.
5292         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5293         * common/new-op.c: Use std::move.
5294         * common/common-exceptions.h (struct gdb_exception): Add move
5295         constructor.
5296         (struct gdb_exception_error, struct gdb_exception_quit, struct
5297         gdb_quit_bad_alloc): Change constructor to move constructor.
5298         (throw_exception): Change parameter to rvalue reference.
5299         * common/common-exceptions.c (throw_exception): Take rvalue
5300         reference.
5301         * cli/cli-interp.c (safe_execute_command): Use std::move.
5302         * breakpoint.c (insert_bp_location, location_to_sals): Use
5303         std::move.
5304
5305 2019-04-25  Tom Tromey  <tromey@adacore.com>
5306
5307         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5308         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5309         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5310         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5311         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5312         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5313         guile/scm-value.c: Use unpack.
5314         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5315         gdbscm_gdb_exception.
5316         (gdbscm_throw_gdb_exception): Likewise.
5317         (struct gdbscm_gdb_exception): New.
5318         (unpack): New function.
5319         (gdbscm_wrap): Use unpack.
5320
5321 2019-04-25  Tom Tromey  <tromey@adacore.com>
5322
5323         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5324         (gdb_rl_callback_handler): Use std::move.
5325         * common/common-exceptions.h (struct gdb_exception): Add move
5326         assignment operator.
5327         (throw_exception_sjlj): Change "exception" to const reference.
5328         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5329         (throw_exception_sjlj): Change "exception" to const reference.
5330
5331 2019-04-25  Tom Tromey  <tromey@adacore.com>
5332
5333         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5334         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5335         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5336         Update.
5337         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5338         Update.
5339         * mi/mi-interp.c (mi_interp::exec): Update.
5340         * linespec.c (parse_linespec): Update.
5341         * infcall.c (run_inferior_call): Update.
5342         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5343         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5344         (gdbscm_lookup_global_symbol): Update.
5345         * guile/scm-param.c (gdbscm_parameter_value): Update.
5346         * guile/scm-frame.c (gdbscm_frame_read_register)
5347         (gdbscm_frame_read_var): Update.
5348         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5349         * exec.c (try_open_exec_file): Update.
5350         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5351         (gdb_rl_callback_handler): Update.
5352         * common/common-exceptions.h (exception_none): Don't declare.
5353         * common/common-exceptions.c (exception_none): Don't define.
5354         (struct catcher) <exception>: Update.
5355         * cli/cli-interp.c (safe_execute_command): Update.
5356         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5357
5358 2019-04-25  Ali Tamur  <tamur@google.com>
5359
5360         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5361         (read_attribute_value): Likewise.
5362         (dwarf2_read_addr_index): Update comment.
5363         (read_str_index): Add DW_FORM_strx.
5364         (dwarf2_string_attr): Likewise.
5365         (dwarf2_const_value_attr): Likewise.
5366         (dump_die_shallow): Likewise.
5367         (dwarf2_fetch_constant_bytes): Likewise.
5368         (skip_form_bytes): Likewise.
5369         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5370
5371 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5372
5373         PR corefiles/11608
5374         PR corefiles/18187
5375         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5376         OFFSET.  Verify if current mapping contains an ELF header.
5377         (linux_find_memory_regions_full): Adjust call to
5378         dump_mapping_p.
5379
5380 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5381             Kang Li <kanglictf@gmail.com>
5382
5383         PR gdb/21600
5384
5385         * dwarf2-frame.c (read_initial_length): Be consistent about using
5386         unsigned representation of length.
5387         (decode_frame_entry_1): Likewise.  Check for wraparound of
5388         end pointer as well as buffer overflow.
5389
5390 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5391
5392         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5393         "vq".
5394
5395 2019-04-24  Tom Tromey  <tromey@adacore.com>
5396
5397         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5398
5399 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5400
5401         * s12z-tdep.c (s12z_unwind_pc): Delete.
5402         (s12z_unwind_sp): Delete.
5403         (s12z_gdbarch_init): Don't register deleted functions with
5404         gdbarch.
5405
5406 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5407
5408         * rl78-tdep.c (rl78_unwind_sp): Delete.
5409         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5410
5411 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5412
5413         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5414         (xstormy16_unwind_pc): Delete.
5415         (xstormy16_dummy_id): Delete.
5416         (xstormy16_gdbarch_init): Don't register deleted functions with
5417         gdbarch.
5418
5419 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5420
5421         * vax-tdep.c (vax_unwind_pc): Delete.
5422         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5423
5424 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5425
5426         * v850-tdep.c (v850_unwind_sp): Delete.
5427         (v850_unwind_pc): Delete.
5428         (v850_dummy_id): Delete.
5429         (v850_gdbarch_init): Don't register deleted functions with
5430         gdbarch.
5431
5432 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5433
5434         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5435         (tilegx_unwind_pc): Delete.
5436         (tilegx_unwind_dummy_id): Delete.
5437         (tilegx_gdbarch_init): Don't register deleted functions with
5438         gdbarch.
5439
5440 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5441
5442         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5443         (tic6x_dummy_id): Delete.
5444         (tic6x_gdbarch_init): Don't register deleted functions with
5445         gdbarch.
5446
5447 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5448
5449         * sparc-tdep.c (sparc_unwind_pc): Delete.
5450         (sparc32_gdbarch_init): Don't register deleted function with
5451         gdbarch.
5452
5453 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5454
5455         * sh-tdep.c (sh_unwind_sp): Delete.
5456         (sh_unwind_pc): Delete.
5457         (sh_dummy_id): Delete.
5458         (sh_gdbarch_init): Don't register deleted functions with
5459         gdbarch.
5460
5461 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5462
5463         * score-tdep.c (score_unwind_sp): Delete.
5464         (score_unwind_pc): Delete.
5465         (score_dummy_id): Delete.
5466         (score_gdbarch_init): Don't register deleted functions with
5467         gdbarch.
5468
5469 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5470
5471         * rx-tdep.c (rx_unwind_pc): Delete.
5472         (rx_unwind_sp): Delete.
5473         (rx_dummy_id): Delete.
5474         (rx_gdbarch_init): Don't register deleted functions with
5475         gdbarch.  Update comment.
5476
5477 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5478
5479         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5480         (rs6000_dummy_id): Delete.
5481         (rs6000_gdbarch_init): Don't register deleted functions with
5482         gdbarch.
5483
5484 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5485
5486         * or1k-tdep.c (or1k_dummy_id): Delete.
5487         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5488
5489 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5490
5491         * nios2-tdep.c (nios2_dummy_id): Delete.
5492         (nios2_unwind_sp): Delete.
5493         (nios2_gdbarch_init): Don't register deleted functions with
5494         gdbarch.
5495
5496 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5497
5498         * nds32-tdep.c (nds32_dummy_id): Delete.
5499         (nds32_unwind_pc): Delete.
5500         (nds32_unwind_sp): Delete.
5501         (nds32_gdbarch_init): Don't register deleted functions with
5502         gdbarch.
5503
5504 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5505
5506         * msp430-tdep.c (msp430_unwind_pc): Delete.
5507         (msp430_unwind_sp): Delete.
5508         (msp430_dummy_id): Delete.
5509         (msp430_gdbarch_init): Don't register deleted functions with
5510         gdbarch.
5511
5512 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5513
5514         * moxie-tdep.c (moxie_unwind_sp): Delete.
5515         (moxie_unwind_pc): Delete.
5516         (moxie_dummy_id): Delete.
5517         (moxie_gdbarch_init): Don't register deleted functions with
5518         gdbarch.
5519
5520 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5521
5522         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5523         (mn10300_unwind_pc): Delete.
5524         (mn10300_unwind_sp): Delete.
5525         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5526         mn10300_unwind_sp.
5527         (mn10300_frame_unwind_init): Don't register deleted functions with
5528         gdbarch.
5529
5530 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5531
5532         * mep-tdep.c (mep_unwind_pc): Delete.
5533         (mep_unwind_sp): Delete.
5534         (mep_dummy_id): Delete.
5535         (mep_gdbarch_init): Don't register deleted functions with
5536         gdbarch.
5537
5538 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5539
5540         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5541         (m68hc11_unwind_sp): Delete.
5542         (m68hc11_gdbarch_init): Don't register deleted functions with
5543         gdbarch.
5544
5545 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5546
5547         * m32r-tdep.c (m32r_unwind_sp): Delete.
5548         (m32r_unwind_pc): Delete.
5549         (m32r_dummy_id): Delete.
5550         (m32r_gdbarch_init): Don't register deleted functions with
5551         gdbarch.
5552
5553 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5554
5555         * m32c-tdep.c (m32c_unwind_pc): Delete.
5556         (m32c_unwind_sp): Delete.
5557         (m32c_dummy_id): Delete.
5558         (m32c_gdbarch_init): Don't register deleted functions with
5559         gdbarch.
5560
5561 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5562
5563         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5564         (lm32_unwind_pc): Delete.
5565         (lm32_dummy_id): Delete.
5566         (lm32_gdbarch_init): Don't register deleted functions with
5567         gdbarch.
5568
5569 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5570
5571         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5572         (iq2000_unwind_pc): Delete.
5573         (iq2000_dummy_id): Delete.
5574         (iq2000_gdbarch_init): Don't register deleted functions with
5575         gdbarch.
5576
5577 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5578
5579         * nds32-tdep.c (nds32_type_align): Delete.
5580         (nds32_push_dummy_call): Use type_align instead.
5581
5582 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5583
5584         * arm-tdep.c (arm_type_align): Only handle vector override case.
5585         (arm_push_dummy_call): Use type_align.
5586         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5587
5588 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5589
5590         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5591         case.
5592         (pass_on_stack): Use type_align.
5593         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5594         function.
5595
5596 2019-04-23  Tom Tromey  <tromey@adacore.com>
5597
5598         * dwarf2read.c (line_header::file_name_at): Remove unused
5599         overload.
5600
5601 2019-04-23  Tom de Vries  <tdevries@suse.de>
5602
5603         PR gdb/24438
5604         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5605         invocation.
5606
5607
5608 2019-03-27  Ali Tamur  <tamur@google.com>
5609
5610         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5611         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5612         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5613         (dwarf_expr_context::get_addr_index): Likewise
5614         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5615         (symbol_needs_eval_context::get_addr_index): Likewise
5616         (disassemble_dwarf_expression): Add DW_OP_addrx
5617         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5618         (read_cutu_die_from_dwo): Update comment
5619         (skip_one_die): Add DW_FORM_addrx
5620         (read_attribute_value): Likewise
5621         (var_decode_location): Add DW_OP_addrx
5622         (dwarf2_const_value_attr): Add DW_FORM_addrx
5623         (dump_die_shallow): Likewise
5624         (dwarf2_fetch_constant_bytes): Likewise
5625         (decode_locdesc): Add DW_OP_addrx
5626         (skip_form_bytes): Add DW_FORM_addrx
5627
5628 2019-04-22  Ali Tamur  <tamur@google.com>
5629
5630         * MAINTAINERS (Write After Approval): Add self.
5631
5632 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5633
5634         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5635         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5636         (open_symbol_file_object): Likewise.
5637         (svr4_default_sos): Add info parameter.
5638         (svr4_read_so_list): Likewise.
5639         (svr4_current_sos_direct): Adjust functions calls to pass down
5640         info.
5641         (svr4_current_sos_1): Add info parameter.
5642         (svr4_current_sos): Call get_svr4_info, pass info down to
5643         svr4_current_sos_1.
5644         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5645         get_svr4_info.
5646         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5647         get_svr4_info.
5648         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5649         to get_svr4_info.
5650         (probes_table_remove_objfile_probes): Likewise.
5651         (register_solib_event_probe): Add info parameter.
5652         (solist_update_incremental): Pass info parameter down to
5653         svr4_read_so_list.
5654         (disable_probes_interface): Add info parameter.
5655         (svr4_handle_solib_event): Pass current_program_space to
5656         get_svr4_info.  Adjust disable_probes_interface cleanup.
5657         (svr4_create_probe_breakpoints): Add info parameter, pass it
5658         down to register_solib_event_probe.
5659         (svr4_create_solib_event_breakpoints): Add info parameter,
5660         pass it down to svr4_create_probe_breakpoints.
5661         (enable_break): Pass info down to
5662         svr4_create_solib_event_breakpoints.
5663         (svr4_solib_create_inferior_hook): Pass current_program_space to
5664         get_svr4_info.
5665         (svr4_clear_solib): Likewise.
5666
5667 2019-04-22  Pedro Alves  <palves@redhat.com>
5668
5669         * solib-svr4.c (svr4_free_objfile_observer): New.
5670         (probe_and_action::objfile): New field.
5671         (probes_table_htab_remove_objfile_probes)
5672         (probes_table_remove_objfile_probes): New functions.
5673         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5674         in the new probe_and_action.  Don't store the probe in 'lookup'.
5675         (svr4_create_probe_breakpoints): Pass objfile to
5676         register_solib_event_probe.
5677         (_initialize_svr4_solib): Register a free_objfile observer.
5678
5679 2019-04-19  Tom Tromey  <tom@tromey.com>
5680
5681         * common/queue.h: Remove.
5682
5683 2019-04-19  Tom Tromey  <tom@tromey.com>
5684
5685         * event-loop.c: Don't include "common/queue.h".
5686
5687 2019-04-19  Tom Tromey  <tom@tromey.com>
5688
5689         * remote.c (remote_target): Use delete.
5690         * remote-notif.h: Include <list>, not "common/queue.h".
5691         (notif_client_p): Remove typedef.
5692         (remote_notif_state): Add constructor, destructor, initializer.
5693         <notif_queue>: Now a std::list.
5694         (remote_notif_state_xfree): Don't declare.
5695         * remote-notif.c (remote_notif_process, handle_notification)
5696         (remote_notif_state_allocate): Update.
5697         (~remote_notif_state): Rename from remote_notif_state_xfree.
5698
5699 2019-04-19  Tom Tromey  <tom@tromey.com>
5700
5701         * symfile.c (reread_symbols): Update.
5702         * objfiles.c (objfile_register_static_link)
5703         (objfile_lookup_static_link): Update
5704         (~objfile) Don't delete static_links.
5705         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5706
5707 2019-04-19  Tom Tromey  <tom@tromey.com>
5708
5709         * type-stack.h (struct type_stack) <insert>: Constify string.
5710         * type-stack.c (type_stack::insert): Constify string.
5711         * gdbtypes.h (lookup_template_type): Update.
5712         (address_space_name_to_int): Update.
5713         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5714         const.
5715         (lookup_template_type): Make name const.
5716         * c-exp.y: Update rules.
5717         (lex_one_token, classify_name, classify_inner_name)
5718         (c_print_token): Update.
5719         * p-exp.y: Update rules.
5720         (yylex): Update.
5721         * f-exp.y: Update rules.
5722         (yylex): Update.
5723         * d-exp.y: Update rules.
5724         (lex_one_token, classify_name, classify_inner_name): Update.
5725         * parse.c (write_dollar_variable, copy_name): Return std::string.
5726         * parser-defs.h (copy_name): Change return type.
5727         * m2-exp.y: Update rules.
5728         (yylex): Update.
5729         * go-exp.y (lex_one_token): Update.
5730         Update rules.
5731         (classify_unsafe_function, classify_packaged_name)
5732         (classify_name, yylex): Update.
5733
5734 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5735
5736         * configure.ac: add --enable-source-highlight switch.
5737         * configure: Regenerate.
5738         * top.c (print_gdb_version): plumb --enable-source-highlight
5739         status to "show configuration".
5740
5741 2019-04-19  Tom Tromey  <tromey@adacore.com>
5742
5743         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5744         Check ADA_TYPE_P.
5745         (empty_record, ada_template_to_fixed_record_type_1)
5746         (template_to_static_fixed_type)
5747         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5748         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5749         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5750         macros.
5751
5752 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5753
5754         PR symtab/24423:
5755         * source.c (print_source_lines_base): Advance "iter" when a
5756         control character is seen.
5757
5758 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5759
5760         * inferior.h (struct infcall_suspend_state_deleter):
5761         Catch exception in destructor to avoid crash.
5762
5763 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5764
5765         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5766         close to the add_com "shell".
5767
5768 2019-04-18  Tom Tromey  <tromey@adacore.com>
5769
5770         * process-stratum-target.h (class process_stratum_target)
5771         <stratum>: Add "final".
5772
5773 2019-04-17  Tom Tromey  <tromey@adacore.com>
5774
5775         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5776         against nullptr before use.
5777
5778 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5779
5780         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5781
5782 2019-04-17  Jim Wilson  <jimw@sifive.com>
5783             Andrew Burgess  <andrew.burgess@embecosm.com>
5784
5785         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5786         code read might fail, assume 4-byte breakpoint in that case.
5787
5788 2019-04-15  Leszek Swirski  <leszeks@google.com>
5789
5790         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5791         rather than a hand-rolled POD check when checking for forced MEMORY
5792         classification.
5793
5794 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5795
5796         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5797         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5798         function.
5799         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5800         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5801         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5802         declaration.
5803
5804 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5805
5806         * aarch64-linux-nat.c
5807         (aarch64_linux_nat_target::thread_architecture): Add override.
5808         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5809         each VQ.
5810
5811 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5812
5813         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5814
5815 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5816
5817         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5818         target types of size 96-bits, add some additional comments, and
5819         check that the builtin type we found was the correct size.
5820
5821 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5822
5823         * utils.c (prompt_for_continue): Don't restore the styling at the
5824         end, as applied_style has the wrong value.  This fixes styling in
5825         long lists of file names that are interrupted by the "Continue?"
5826         prompt.
5827
5828 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5829
5830         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5831         * c-lang.c (c_language_defn): Likewise.
5832         (cplus_language_defn): Likewise.
5833         (asm_language_defn): Likewise.
5834         (minimal_language_defn): Likewise.
5835         * d-lang.c (d_language_defn): Likewise.
5836         * f-lang.c (f_language_defn): Likewise.
5837         * go-lang.c (go_language_defn): Likewise.
5838         * language.c (unknown_language_defn): Likewise.
5839         (auto_language_defn): Likewise.
5840         * language.h (struct language_defn): Remove la_magic field.
5841         (LANG_MAGIC): Delete.
5842         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5843         * objc-lang.c (objc_language_defn): Likewise.
5844         * opencl-lang.c (opencl_language_defn): Likewise.
5845         * p-lang.c (pascal_language_defn): Likewise.
5846         * rust-lang.c (rust_language_defn): Likewise.
5847
5848 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5849
5850         * riscv-tdep.c (riscv_type_align): New function.
5851         (riscv_type_alignment): Delete.
5852         (riscv_arg_location): Use 'type_align'.
5853         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5854
5855 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5856
5857         * gdbtypes.c (type_align): A struct with no non-static fields also
5858         has alignment of 1.
5859
5860 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5861
5862         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5863         component to 0.
5864         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5865         member.
5866         (riscv_struct_info::analyse): New implementation using new
5867         analyse_inner member function.
5868         (riscv_struct_info::field_offset): New member function.
5869         (riscv_struct_info::m_offsets): New member variable.
5870         (riscv_struct_info::analyse_inner): New private member function,
5871         takes the old implementation of riscv_struct_info::analyse but
5872         extended to track field offsets.
5873         (riscv_call_arg_struct): Update the struct folding special cases
5874         to handle cases where empty C++ structs, which are non-zero
5875         length, are found.
5876         (riscv_arg_location): Initialise the length of each location, a
5877         non-zero length now indicates the location is in use.
5878         (riscv_push_dummy_call): Allow for the first location having a
5879         non-zero offset when setting up arguments.
5880         (riscv_return_value): Likewise, but for return values.
5881
5882 2019-04-11  Tom Tromey  <tromey@adacore.com>
5883
5884         * utils.c (internal_vproblem): Make "msg" const.
5885
5886 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5887
5888         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5889         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5890         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5891         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5892
5893 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5894
5895         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5896         function.
5897         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5898         of amd64_collect_native_gregset.
5899         (amd64_linux_nat_target::store_registers): Likewise.
5900
5901 2019-04-10  Tom Tromey  <tom@tromey.com>
5902
5903         * symtab.c (lookup_global_symbol_from_objfile)
5904         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5905         * objfiles.h (class separate_debug_iterator): New.
5906         (class separate_debug_range): New.
5907         (struct objfile) <separate_debug_objfiles>: New method.
5908         (objfile_separate_debug_iterate): Don't declare.
5909         * objfiles.c (separate_debug_iterator::operator++): Rename from
5910         objfile_separate_debug_iterate.
5911         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5912         iterator.
5913         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5914         iterator.
5915
5916 2019-04-10  Tom Tromey  <tom@tromey.com>
5917
5918         * symfile.c (reread_symbols): Remove old comment.
5919         * objfiles.c (free_all_objfiles): Fix a typo.
5920
5921 2019-04-10  Tom Tromey  <tom@tromey.com>
5922
5923         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5924         * minsyms.c (lookup_minimal_symbol): Use foreach.
5925         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5926         (lookup_minimal_symbol_solib_trampoline): Likewise.
5927         * symfile.c (reread_symbols): Use foreach.
5928
5929 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5930             Tom Tromey  <tromey@adacore.com>
5931
5932         PR rust/24414:
5933         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5934         (rust_lex_int_test): Change "value" to be LONGEST.
5935         (rust_lex_tests): Add test for long integer literal.
5936
5937 2019-04-09  Tom Tromey  <tromey@adacore.com>
5938
5939         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5940         to bool.
5941         (extended_remote_target::attach): Update.
5942         (remote_target::remote_notice_new_inferior): Update.
5943         (remote_target::add_current_inferior_and_thread): Update.
5944         * inferior.c (exit_inferior_1): Use "false".
5945         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5946
5947 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5948
5949         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5950         the "start" command.
5951
5952 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5953
5954         * python/py-inferior.c (infpy_thread_from_thread_handle):
5955         Adjust comments to reflect renaming of thread_from_thread_handle
5956         to thread_from_handle.  Adjust keywords.  Fix type error message.
5957         (inferior_object_methods): Add thread_from_handle.  Retain
5958         thread_from_thread_handle, but mark it as deprecated.
5959
5960 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5961
5962         * gdbthread.h (find_thread_by_handle): Revise declaration.
5963         * thread.c (find_thread_by_handle): Likewise.  Adjust
5964         implementation too.
5965         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5966         support for buffer objects as handles.
5967
5968 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5969
5970         * python/py-infthread.c (thpy_thread_handle): New function.
5971         (thread_object_methods): Register thpy_thread_handle.
5972
5973 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5974
5975         * gdbthread.h (thread_to_thread_handle): Declare.
5976         * thread.c (gdbtypes.h): Include.
5977         (thread_to_thread_handle): New function.
5978
5979         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5980         (target_thread_info_to_thread_handle): Declare.
5981         * target.c (target_thread_info_to_thread_handle): New function.
5982         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5983         * target-delegates.c: Regenerate.
5984
5985         * linux-thread-db.c (class thread_db_target): Add method
5986         thread_info_to_thread_handle.
5987         (thread_db_target::thread_info_to_thread_handle): Define.
5988         * remote.c (class remote_target): Add new method
5989         thread_info_to_thread_handle.
5990         (remote_target::thread_info_to_thread_handle): Define.
5991
5992 2019-04-08  Pedro Alves  <palves@redhat.com>
5993
5994         * common/common-exceptions.c (throw_exception): Don't create
5995         named object to throw; throw directly.
5996         (throw_it): Likewise.  Don't initialize gdb_exception::message
5997         here, with new; pass FMT and AP to the ctor instead.
5998         * common/common-exceptions.h: Include <string>.
5999         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6000         const char *, va_list)): New ctor.  Use std::make_shared.
6001         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6002         errors)): Delete.
6003         (gdb_exception_error::gdb_exception_error(enum errors, const char
6004         *, va_list)): New.
6005         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6006         Add assertion.
6007         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6008         errors)): Delete.
6009         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6010         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6011         Add assertion.
6012
6013 2019-04-08  Tom Tromey  <tom@tromey.com>
6014
6015         * valops.c (value_rtti_indirect_type): Replace throw_exception
6016         with throw.
6017         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6018         with throw.
6019         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6020         throw.
6021         * target.c (target_translate_tls_address): Replace throw_exception
6022         with throw.
6023         * stack.c (frame_apply_command_count): Replace throw_exception
6024         with throw.
6025         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6026         throw.
6027         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6028         with throw.
6029         * rs6000-tdep.c (rs6000_frame_cache)
6030         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6031         * remote.c: Replace throw_exception with throw.
6032         * record-full.c (record_full_message, record_full_wait_1)
6033         (record_full_restore): Replace throw_exception with throw.
6034         * record-btrace.c:
6035         (get_thread_current_frame_id, record_btrace_start_replaying)
6036         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6037         (cmd_record_btrace_start): Replace throw_exception with throw.
6038         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6039         throw.
6040         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6041         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6042         * linespec.c:
6043         (find_linespec_symbols): Replace throw_exception with throw.
6044         * infrun.c (displaced_step_prepare, resume): Replace
6045         throw_exception with throw.
6046         * infcmd.c (post_create_inferior): Replace throw_exception with
6047         throw.
6048         * inf-loop.c (inferior_event_handler): Replace throw_exception
6049         with throw.
6050         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6051         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6052         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6053         (get_prev_frame_always, get_frame_pc_if_available)
6054         (get_frame_address_in_block_if_available, get_frame_language):
6055         Replace throw_exception with throw.
6056         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6057         throw_exception with throw.
6058         * eval.c (fetch_subexp_value, evaluate_var_value)
6059         (evaluate_funcall, evaluate_subexp_standard): Replace
6060         throw_exception with throw.
6061         * dwarf2loc.c (call_site_find_chain)
6062         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6063         Replace throw_exception with throw.
6064         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6065         with throw.
6066         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6067         throw.
6068         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6069         * completer.c (complete_line_internal): Replace throw_exception
6070         with throw.
6071         * compile/compile-object-run.c (compile_object_run): Replace
6072         throw_exception with throw.
6073         * cli/cli-script.c (process_next_line): Replace throw_exception
6074         with throw.
6075         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6076         (btrace_enable, btrace_maint_update_pt_packets): Replace
6077         throw_exception with throw.
6078         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6079         throw_exception with throw.
6080         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6081         throw_exception with throw.
6082         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6083         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6084         * aarch64-tdep.c (aarch64_make_prologue_cache)
6085         (aarch64_make_stub_cache): Replace throw_exception with throw.
6086
6087 2019-04-08  Tom Tromey  <tom@tromey.com>
6088
6089         * common/common-exceptions.c (throw_exception): Rename from
6090         throw_exception_cxx.  Remove old copy.  Make argument const.
6091         (throw_it): Create and throw exception objects directly.
6092         * common/common-exceptions.h (throw_exception): Make argument
6093         const.
6094         (struct gdb_exception_error): Add constructor.
6095         (struct gdb_exception_quit): Add constructor.
6096
6097 2019-04-08  Tom Tromey  <tom@tromey.com>
6098
6099         * common/common-exceptions.h (exception_rethrow): Don't declare.
6100         (TRY_SJLJ): Update comment.
6101         (TRY, CATCH, END_CATCH): Remove.
6102         * common/common-exceptions.c (exception_rethrow): Remove.
6103
6104 2019-04-08  Tom Tromey  <tom@tromey.com>
6105
6106         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6107         Remove.
6108         (gdb_exception_error): Rename from
6109         gdb_exception_RETURN_MASK_ERROR.
6110         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6111         (gdb_quit_bad_alloc): Update.
6112         * aarch64-tdep.c: Update.
6113         * ada-lang.c: Update.
6114         * ada-typeprint.c: Update.
6115         * ada-valprint.c: Update.
6116         * amd64-tdep.c: Update.
6117         * arch-utils.c: Update.
6118         * break-catch-throw.c: Update.
6119         * breakpoint.c: Update.
6120         * btrace.c: Update.
6121         * c-varobj.c: Update.
6122         * cli/cli-cmds.c: Update.
6123         * cli/cli-interp.c: Update.
6124         * cli/cli-script.c: Update.
6125         * common/common-exceptions.c: Update.
6126         * common/new-op.c: Update.
6127         * common/selftest.c: Update.
6128         * compile/compile-c-symbols.c: Update.
6129         * compile/compile-cplus-symbols.c: Update.
6130         * compile/compile-object-load.c: Update.
6131         * compile/compile-object-run.c: Update.
6132         * completer.c: Update.
6133         * corelow.c: Update.
6134         * cp-abi.c: Update.
6135         * cp-support.c: Update.
6136         * cp-valprint.c: Update.
6137         * darwin-nat.c: Update.
6138         * disasm-selftests.c: Update.
6139         * dtrace-probe.c: Update.
6140         * dwarf-index-cache.c: Update.
6141         * dwarf-index-write.c: Update.
6142         * dwarf2-frame-tailcall.c: Update.
6143         * dwarf2-frame.c: Update.
6144         * dwarf2loc.c: Update.
6145         * dwarf2read.c: Update.
6146         * eval.c: Update.
6147         * event-loop.c: Update.
6148         * event-top.c: Update.
6149         * exec.c: Update.
6150         * f-valprint.c: Update.
6151         * fbsd-tdep.c: Update.
6152         * frame-unwind.c: Update.
6153         * frame.c: Update.
6154         * gdbtypes.c: Update.
6155         * gnu-v3-abi.c: Update.
6156         * guile/guile-internal.h: Update.
6157         * guile/scm-block.c: Update.
6158         * guile/scm-breakpoint.c: Update.
6159         * guile/scm-cmd.c: Update.
6160         * guile/scm-disasm.c: Update.
6161         * guile/scm-frame.c: Update.
6162         * guile/scm-lazy-string.c: Update.
6163         * guile/scm-math.c: Update.
6164         * guile/scm-param.c: Update.
6165         * guile/scm-ports.c: Update.
6166         * guile/scm-pretty-print.c: Update.
6167         * guile/scm-symbol.c: Update.
6168         * guile/scm-symtab.c: Update.
6169         * guile/scm-type.c: Update.
6170         * guile/scm-value.c: Update.
6171         * i386-linux-tdep.c: Update.
6172         * i386-tdep.c: Update.
6173         * inf-loop.c: Update.
6174         * infcall.c: Update.
6175         * infcmd.c: Update.
6176         * infrun.c: Update.
6177         * jit.c: Update.
6178         * language.c: Update.
6179         * linespec.c: Update.
6180         * linux-fork.c: Update.
6181         * linux-nat.c: Update.
6182         * linux-tdep.c: Update.
6183         * linux-thread-db.c: Update.
6184         * main.c: Update.
6185         * mi/mi-cmd-break.c: Update.
6186         * mi/mi-cmd-stack.c: Update.
6187         * mi/mi-interp.c: Update.
6188         * mi/mi-main.c: Update.
6189         * objc-lang.c: Update.
6190         * p-valprint.c: Update.
6191         * parse.c: Update.
6192         * ppc-linux-tdep.c: Update.
6193         * printcmd.c: Update.
6194         * python/py-arch.c: Update.
6195         * python/py-breakpoint.c: Update.
6196         * python/py-cmd.c: Update.
6197         * python/py-finishbreakpoint.c: Update.
6198         * python/py-frame.c: Update.
6199         * python/py-framefilter.c: Update.
6200         * python/py-gdb-readline.c: Update.
6201         * python/py-inferior.c: Update.
6202         * python/py-infthread.c: Update.
6203         * python/py-lazy-string.c: Update.
6204         * python/py-linetable.c: Update.
6205         * python/py-objfile.c: Update.
6206         * python/py-param.c: Update.
6207         * python/py-prettyprint.c: Update.
6208         * python/py-progspace.c: Update.
6209         * python/py-record-btrace.c: Update.
6210         * python/py-record.c: Update.
6211         * python/py-symbol.c: Update.
6212         * python/py-type.c: Update.
6213         * python/py-unwind.c: Update.
6214         * python/py-utils.c: Update.
6215         * python/py-value.c: Update.
6216         * python/python.c: Update.
6217         * record-btrace.c: Update.
6218         * record-full.c: Update.
6219         * remote-fileio.c: Update.
6220         * remote.c: Update.
6221         * riscv-tdep.c: Update.
6222         * rs6000-aix-tdep.c: Update.
6223         * rs6000-tdep.c: Update.
6224         * rust-exp.y: Update.
6225         * rust-lang.c: Update.
6226         * s390-tdep.c: Update.
6227         * selftest-arch.c: Update.
6228         * solib-dsbt.c: Update.
6229         * solib-frv.c: Update.
6230         * solib-spu.c: Update.
6231         * solib-svr4.c: Update.
6232         * solib.c: Update.
6233         * sparc64-linux-tdep.c: Update.
6234         * stack.c: Update.
6235         * symfile-mem.c: Update.
6236         * symmisc.c: Update.
6237         * target.c: Update.
6238         * thread.c: Update.
6239         * top.c: Update.
6240         * tracefile-tfile.c: Update.
6241         * tui/tui.c: Update.
6242         * typeprint.c: Update.
6243         * unittests/cli-utils-selftests.c: Update.
6244         * unittests/parse-connection-spec-selftests.c: Update.
6245         * valops.c: Update.
6246         * valprint.c: Update.
6247         * value.c: Update.
6248         * varobj.c: Update.
6249         * windows-nat.c: Update.
6250         * x86-linux-nat.c: Update.
6251         * xml-support.c: Update.
6252
6253 2019-04-08  Tom Tromey  <tom@tromey.com>
6254
6255         * xml-support.c: Use C++ exception handling.
6256         * x86-linux-nat.c: Use C++ exception handling.
6257         * windows-nat.c: Use C++ exception handling.
6258         * varobj.c: Use C++ exception handling.
6259         * value.c: Use C++ exception handling.
6260         * valprint.c: Use C++ exception handling.
6261         * valops.c: Use C++ exception handling.
6262         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6263         handling.
6264         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6265         * typeprint.c: Use C++ exception handling.
6266         * tui/tui.c: Use C++ exception handling.
6267         * tracefile-tfile.c: Use C++ exception handling.
6268         * top.c: Use C++ exception handling.
6269         * thread.c: Use C++ exception handling.
6270         * target.c: Use C++ exception handling.
6271         * symmisc.c: Use C++ exception handling.
6272         * symfile-mem.c: Use C++ exception handling.
6273         * stack.c: Use C++ exception handling.
6274         * sparc64-linux-tdep.c: Use C++ exception handling.
6275         * solib.c: Use C++ exception handling.
6276         * solib-svr4.c: Use C++ exception handling.
6277         * solib-spu.c: Use C++ exception handling.
6278         * solib-frv.c: Use C++ exception handling.
6279         * solib-dsbt.c: Use C++ exception handling.
6280         * selftest-arch.c: Use C++ exception handling.
6281         * s390-tdep.c: Use C++ exception handling.
6282         * rust-lang.c: Use C++ exception handling.
6283         * rust-exp.y: Use C++ exception handling.
6284         * rs6000-tdep.c: Use C++ exception handling.
6285         * rs6000-aix-tdep.c: Use C++ exception handling.
6286         * riscv-tdep.c: Use C++ exception handling.
6287         * remote.c: Use C++ exception handling.
6288         * remote-fileio.c: Use C++ exception handling.
6289         * record-full.c: Use C++ exception handling.
6290         * record-btrace.c: Use C++ exception handling.
6291         * python/python.c: Use C++ exception handling.
6292         * python/py-value.c: Use C++ exception handling.
6293         * python/py-utils.c: Use C++ exception handling.
6294         * python/py-unwind.c: Use C++ exception handling.
6295         * python/py-type.c: Use C++ exception handling.
6296         * python/py-symbol.c: Use C++ exception handling.
6297         * python/py-record.c: Use C++ exception handling.
6298         * python/py-record-btrace.c: Use C++ exception handling.
6299         * python/py-progspace.c: Use C++ exception handling.
6300         * python/py-prettyprint.c: Use C++ exception handling.
6301         * python/py-param.c: Use C++ exception handling.
6302         * python/py-objfile.c: Use C++ exception handling.
6303         * python/py-linetable.c: Use C++ exception handling.
6304         * python/py-lazy-string.c: Use C++ exception handling.
6305         * python/py-infthread.c: Use C++ exception handling.
6306         * python/py-inferior.c: Use C++ exception handling.
6307         * python/py-gdb-readline.c: Use C++ exception handling.
6308         * python/py-framefilter.c: Use C++ exception handling.
6309         * python/py-frame.c: Use C++ exception handling.
6310         * python/py-finishbreakpoint.c: Use C++ exception handling.
6311         * python/py-cmd.c: Use C++ exception handling.
6312         * python/py-breakpoint.c: Use C++ exception handling.
6313         * python/py-arch.c: Use C++ exception handling.
6314         * printcmd.c: Use C++ exception handling.
6315         * ppc-linux-tdep.c: Use C++ exception handling.
6316         * parse.c: Use C++ exception handling.
6317         * p-valprint.c: Use C++ exception handling.
6318         * objc-lang.c: Use C++ exception handling.
6319         * mi/mi-main.c: Use C++ exception handling.
6320         * mi/mi-interp.c: Use C++ exception handling.
6321         * mi/mi-cmd-stack.c: Use C++ exception handling.
6322         * mi/mi-cmd-break.c: Use C++ exception handling.
6323         * main.c: Use C++ exception handling.
6324         * linux-thread-db.c: Use C++ exception handling.
6325         * linux-tdep.c: Use C++ exception handling.
6326         * linux-nat.c: Use C++ exception handling.
6327         * linux-fork.c: Use C++ exception handling.
6328         * linespec.c: Use C++ exception handling.
6329         * language.c: Use C++ exception handling.
6330         * jit.c: Use C++ exception handling.
6331         * infrun.c: Use C++ exception handling.
6332         * infcmd.c: Use C++ exception handling.
6333         * infcall.c: Use C++ exception handling.
6334         * inf-loop.c: Use C++ exception handling.
6335         * i386-tdep.c: Use C++ exception handling.
6336         * i386-linux-tdep.c: Use C++ exception handling.
6337         * guile/scm-value.c: Use C++ exception handling.
6338         * guile/scm-type.c: Use C++ exception handling.
6339         * guile/scm-symtab.c: Use C++ exception handling.
6340         * guile/scm-symbol.c: Use C++ exception handling.
6341         * guile/scm-pretty-print.c: Use C++ exception handling.
6342         * guile/scm-ports.c: Use C++ exception handling.
6343         * guile/scm-param.c: Use C++ exception handling.
6344         * guile/scm-math.c: Use C++ exception handling.
6345         * guile/scm-lazy-string.c: Use C++ exception handling.
6346         * guile/scm-frame.c: Use C++ exception handling.
6347         * guile/scm-disasm.c: Use C++ exception handling.
6348         * guile/scm-cmd.c: Use C++ exception handling.
6349         * guile/scm-breakpoint.c: Use C++ exception handling.
6350         * guile/scm-block.c: Use C++ exception handling.
6351         * guile/guile-internal.h: Use C++ exception handling.
6352         * gnu-v3-abi.c: Use C++ exception handling.
6353         * gdbtypes.c: Use C++ exception handling.
6354         * frame.c: Use C++ exception handling.
6355         * frame-unwind.c: Use C++ exception handling.
6356         * fbsd-tdep.c: Use C++ exception handling.
6357         * f-valprint.c: Use C++ exception handling.
6358         * exec.c: Use C++ exception handling.
6359         * event-top.c: Use C++ exception handling.
6360         * event-loop.c: Use C++ exception handling.
6361         * eval.c: Use C++ exception handling.
6362         * dwarf2read.c: Use C++ exception handling.
6363         * dwarf2loc.c: Use C++ exception handling.
6364         * dwarf2-frame.c: Use C++ exception handling.
6365         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6366         * dwarf-index-write.c: Use C++ exception handling.
6367         * dwarf-index-cache.c: Use C++ exception handling.
6368         * dtrace-probe.c: Use C++ exception handling.
6369         * disasm-selftests.c: Use C++ exception handling.
6370         * darwin-nat.c: Use C++ exception handling.
6371         * cp-valprint.c: Use C++ exception handling.
6372         * cp-support.c: Use C++ exception handling.
6373         * cp-abi.c: Use C++ exception handling.
6374         * corelow.c: Use C++ exception handling.
6375         * completer.c: Use C++ exception handling.
6376         * compile/compile-object-run.c: Use C++ exception handling.
6377         * compile/compile-object-load.c: Use C++ exception handling.
6378         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6379         * compile/compile-c-symbols.c: Use C++ exception handling.
6380         * common/selftest.c: Use C++ exception handling.
6381         * common/new-op.c: Use C++ exception handling.
6382         * cli/cli-script.c: Use C++ exception handling.
6383         * cli/cli-interp.c: Use C++ exception handling.
6384         * cli/cli-cmds.c: Use C++ exception handling.
6385         * c-varobj.c: Use C++ exception handling.
6386         * btrace.c: Use C++ exception handling.
6387         * breakpoint.c: Use C++ exception handling.
6388         * break-catch-throw.c: Use C++ exception handling.
6389         * arch-utils.c: Use C++ exception handling.
6390         * amd64-tdep.c: Use C++ exception handling.
6391         * ada-valprint.c: Use C++ exception handling.
6392         * ada-typeprint.c: Use C++ exception handling.
6393         * ada-lang.c: Use C++ exception handling.
6394         * aarch64-tdep.c: Use C++ exception handling.
6395
6396 2019-04-08  Tom Tromey  <tom@tromey.com>
6397
6398         * xml-support.c (gdb_xml_parser::parse): Update.
6399         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6400         * value.c (show_convenience): Update.
6401         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6402         (test_parse_flags_qcs): Update.
6403         * thread.c (thr_try_catch_cmd): Update.
6404         * target.c (target_translate_tls_address): Update.
6405         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6406         (info_frame_command_core, frame_apply_command_count): Update.
6407         * rust-exp.y (rust_lex_exception_test): Update.
6408         * riscv-tdep.c (riscv_print_one_register_info): Update.
6409         * remote.c (remote_target::enable_btrace): Update.
6410         * record-btrace.c (record_btrace_enable_warn): Update.
6411         * python/py-utils.c (gdbpy_convert_exception): Update.
6412         * printcmd.c (do_one_display, print_variable_and_value): Update.
6413         * mi/mi-main.c (mi_print_exception): Update.
6414         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6415         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6416         * linux-nat.c (linux_nat_target::attach): Update.
6417         * linux-fork.c (class scoped_switch_fork_info): Update.
6418         * infrun.c (displaced_step_prepare): Update.
6419         * infcall.c (call_function_by_hand_dummy): Update.
6420         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6421         * gnu-v3-abi.c (print_one_vtable): Update.
6422         * frame.c (get_prev_frame_always): Update.
6423         * f-valprint.c (info_common_command_for_block): Update.
6424         * exec.c (try_open_exec_file): Update.
6425         * exceptions.c (print_exception, exception_print)
6426         (exception_fprintf, exception_print_same): Update.
6427         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6428         * dwarf-index-cache.c (index_cache::store)
6429         (index_cache::lookup_gdb_index): Update.
6430         * darwin-nat.c (maybe_cache_shell): Update.
6431         * cp-valprint.c (cp_print_value_fields): Update.
6432         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6433         (gcc_cplus_symbol_address): Update.
6434         * compile/compile-c-symbols.c (gcc_convert_symbol)
6435         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6436         * common/selftest.c: Update.
6437         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6438         a std::string.
6439         (exception_try_scope_entry, exception_try_scope_exit): Don't
6440         declare.
6441         (struct exception_try_scope): Remove.
6442         (TRY): Don't use exception_try_scope.
6443         (struct gdb_exception): Add constructor, operator=.
6444         <what>: New method.
6445         (struct gdb_exception_RETURN_MASK_ALL)
6446         (struct gdb_exception_RETURN_MASK_ERROR)
6447         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6448         (struct gdb_quit_bad_alloc): Update.
6449         * common/common-exceptions.c (exception_none): Change
6450         initializer.
6451         (struct catcher) <state, exception>: Initialize inline.
6452         <prev>: Remove member.
6453         (current_catcher): Remove.
6454         (catchers): New global.
6455         (exceptions_state_mc_init): Simplify.
6456         (catcher_pop): Remove.
6457         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6458         (try_scope_depth, exception_try_scope_entry)
6459         (exception_try_scope_exit): Remove.
6460         (throw_exception_sjlj): Update.
6461         (exception_messages, exception_messages_size): Remove.
6462         (throw_it): Simplify.
6463         (gdb_exception_sliced_copy): Remove.
6464         (throw_exception_cxx): Update.
6465         * cli/cli-script.c (script_from_file): Update.
6466         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6467         Update.
6468         * ada-valprint.c (ada_val_print): Update.
6469         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6470         (create_excep_cond_exprs): Update.
6471
6472 2019-04-08  Tom Tromey  <tom@tromey.com>
6473
6474         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6475         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6476         (TRY, CATCH, END_CATCH): Remove some definitions.
6477         * common/common-exceptions.c: Don't use GDB_XCPT.
6478         (catcher_list_size): Remove.
6479         (throw_exception, throw_it): Simplify.
6480
6481 2019-04-05  Tom Tromey  <tom@tromey.com>
6482
6483         Revert the header-sorting patch.
6484         * ft32-tdep.c: Revert.
6485         * frv-tdep.c: Revert.
6486         * frv-linux-tdep.c: Revert.
6487         * frame.c: Revert.
6488         * frame-unwind.c: Revert.
6489         * frame-base.c: Revert.
6490         * fork-child.c: Revert.
6491         * findvar.c: Revert.
6492         * findcmd.c: Revert.
6493         * filesystem.c: Revert.
6494         * filename-seen-cache.h: Revert.
6495         * filename-seen-cache.c: Revert.
6496         * fbsd-tdep.c: Revert.
6497         * fbsd-nat.h: Revert.
6498         * fbsd-nat.c: Revert.
6499         * f-valprint.c: Revert.
6500         * f-typeprint.c: Revert.
6501         * f-lang.c: Revert.
6502         * extension.h: Revert.
6503         * extension.c: Revert.
6504         * extension-priv.h: Revert.
6505         * expprint.c: Revert.
6506         * exec.h: Revert.
6507         * exec.c: Revert.
6508         * exceptions.c: Revert.
6509         * event-top.c: Revert.
6510         * event-loop.c: Revert.
6511         * eval.c: Revert.
6512         * elfread.c: Revert.
6513         * dwarf2read.h: Revert.
6514         * dwarf2read.c: Revert.
6515         * dwarf2loc.c: Revert.
6516         * dwarf2expr.h: Revert.
6517         * dwarf2expr.c: Revert.
6518         * dwarf2-frame.c: Revert.
6519         * dwarf2-frame-tailcall.c: Revert.
6520         * dwarf-index-write.h: Revert.
6521         * dwarf-index-write.c: Revert.
6522         * dwarf-index-common.c: Revert.
6523         * dwarf-index-cache.h: Revert.
6524         * dwarf-index-cache.c: Revert.
6525         * dummy-frame.c: Revert.
6526         * dtrace-probe.c: Revert.
6527         * disasm.h: Revert.
6528         * disasm.c: Revert.
6529         * disasm-selftests.c: Revert.
6530         * dictionary.c: Revert.
6531         * dicos-tdep.c: Revert.
6532         * demangle.c: Revert.
6533         * dcache.h: Revert.
6534         * dcache.c: Revert.
6535         * darwin-nat.h: Revert.
6536         * darwin-nat.c: Revert.
6537         * darwin-nat-info.c: Revert.
6538         * d-valprint.c: Revert.
6539         * d-namespace.c: Revert.
6540         * d-lang.c: Revert.
6541         * ctf.c: Revert.
6542         * csky-tdep.c: Revert.
6543         * csky-linux-tdep.c: Revert.
6544         * cris-tdep.c: Revert.
6545         * cris-linux-tdep.c: Revert.
6546         * cp-valprint.c: Revert.
6547         * cp-support.c: Revert.
6548         * cp-namespace.c: Revert.
6549         * cp-abi.c: Revert.
6550         * corelow.c: Revert.
6551         * corefile.c: Revert.
6552         * continuations.c: Revert.
6553         * completer.h: Revert.
6554         * completer.c: Revert.
6555         * complaints.c: Revert.
6556         * coffread.c: Revert.
6557         * coff-pe-read.c: Revert.
6558         * cli-out.h: Revert.
6559         * cli-out.c: Revert.
6560         * charset.c: Revert.
6561         * c-varobj.c: Revert.
6562         * c-valprint.c: Revert.
6563         * c-typeprint.c: Revert.
6564         * c-lang.c: Revert.
6565         * buildsym.c: Revert.
6566         * buildsym-legacy.c: Revert.
6567         * build-id.h: Revert.
6568         * build-id.c: Revert.
6569         * btrace.c: Revert.
6570         * bsd-uthread.c: Revert.
6571         * breakpoint.h: Revert.
6572         * breakpoint.c: Revert.
6573         * break-catch-throw.c: Revert.
6574         * break-catch-syscall.c: Revert.
6575         * break-catch-sig.c: Revert.
6576         * blockframe.c: Revert.
6577         * block.c: Revert.
6578         * bfin-tdep.c: Revert.
6579         * bfin-linux-tdep.c: Revert.
6580         * bfd-target.c: Revert.
6581         * bcache.c: Revert.
6582         * ax-general.c: Revert.
6583         * ax-gdb.h: Revert.
6584         * ax-gdb.c: Revert.
6585         * avr-tdep.c: Revert.
6586         * auxv.c: Revert.
6587         * auto-load.c: Revert.
6588         * arm-wince-tdep.c: Revert.
6589         * arm-tdep.c: Revert.
6590         * arm-symbian-tdep.c: Revert.
6591         * arm-pikeos-tdep.c: Revert.
6592         * arm-obsd-tdep.c: Revert.
6593         * arm-nbsd-tdep.c: Revert.
6594         * arm-nbsd-nat.c: Revert.
6595         * arm-linux-tdep.c: Revert.
6596         * arm-linux-nat.c: Revert.
6597         * arm-fbsd-tdep.c: Revert.
6598         * arm-fbsd-nat.c: Revert.
6599         * arm-bsd-tdep.c: Revert.
6600         * arch-utils.c: Revert.
6601         * arc-tdep.c: Revert.
6602         * arc-newlib-tdep.c: Revert.
6603         * annotate.h: Revert.
6604         * annotate.c: Revert.
6605         * amd64-windows-tdep.c: Revert.
6606         * amd64-windows-nat.c: Revert.
6607         * amd64-tdep.c: Revert.
6608         * amd64-sol2-tdep.c: Revert.
6609         * amd64-obsd-tdep.c: Revert.
6610         * amd64-obsd-nat.c: Revert.
6611         * amd64-nbsd-tdep.c: Revert.
6612         * amd64-nbsd-nat.c: Revert.
6613         * amd64-nat.c: Revert.
6614         * amd64-linux-tdep.c: Revert.
6615         * amd64-linux-nat.c: Revert.
6616         * amd64-fbsd-tdep.c: Revert.
6617         * amd64-fbsd-nat.c: Revert.
6618         * amd64-dicos-tdep.c: Revert.
6619         * amd64-darwin-tdep.c: Revert.
6620         * amd64-bsd-nat.c: Revert.
6621         * alpha-tdep.c: Revert.
6622         * alpha-obsd-tdep.c: Revert.
6623         * alpha-nbsd-tdep.c: Revert.
6624         * alpha-mdebug-tdep.c: Revert.
6625         * alpha-linux-tdep.c: Revert.
6626         * alpha-linux-nat.c: Revert.
6627         * alpha-bsd-tdep.c: Revert.
6628         * alpha-bsd-nat.c: Revert.
6629         * aix-thread.c: Revert.
6630         * agent.c: Revert.
6631         * addrmap.c: Revert.
6632         * ada-varobj.c: Revert.
6633         * ada-valprint.c: Revert.
6634         * ada-typeprint.c: Revert.
6635         * ada-tasks.c: Revert.
6636         * ada-lang.c: Revert.
6637         * aarch64-tdep.c: Revert.
6638         * aarch64-ravenscar-thread.c: Revert.
6639         * aarch64-newlib-tdep.c: Revert.
6640         * aarch64-linux-tdep.c: Revert.
6641         * aarch64-linux-nat.c: Revert.
6642         * aarch64-fbsd-tdep.c: Revert.
6643         * aarch64-fbsd-nat.c: Revert.
6644         * aarch32-linux-nat.c: Revert.
6645
6646 2019-04-05  Tom Tromey  <tom@tromey.com>
6647
6648         * ft32-tdep.c: Sort headers.
6649         * frv-tdep.c: Sort headers.
6650         * frv-linux-tdep.c: Sort headers.
6651         * frame.c: Sort headers.
6652         * frame-unwind.c: Sort headers.
6653         * frame-base.c: Sort headers.
6654         * fork-child.c: Sort headers.
6655         * findvar.c: Sort headers.
6656         * findcmd.c: Sort headers.
6657         * filesystem.c: Sort headers.
6658         * filename-seen-cache.h: Sort headers.
6659         * filename-seen-cache.c: Sort headers.
6660         * fbsd-tdep.c: Sort headers.
6661         * fbsd-nat.h: Sort headers.
6662         * fbsd-nat.c: Sort headers.
6663         * f-valprint.c: Sort headers.
6664         * f-typeprint.c: Sort headers.
6665         * f-lang.c: Sort headers.
6666         * extension.h: Sort headers.
6667         * extension.c: Sort headers.
6668         * extension-priv.h: Sort headers.
6669         * expprint.c: Sort headers.
6670         * exec.h: Sort headers.
6671         * exec.c: Sort headers.
6672         * exceptions.c: Sort headers.
6673         * event-top.c: Sort headers.
6674         * event-loop.c: Sort headers.
6675         * eval.c: Sort headers.
6676         * elfread.c: Sort headers.
6677         * dwarf2read.h: Sort headers.
6678         * dwarf2read.c: Sort headers.
6679         * dwarf2loc.c: Sort headers.
6680         * dwarf2expr.h: Sort headers.
6681         * dwarf2expr.c: Sort headers.
6682         * dwarf2-frame.c: Sort headers.
6683         * dwarf2-frame-tailcall.c: Sort headers.
6684         * dwarf-index-write.h: Sort headers.
6685         * dwarf-index-write.c: Sort headers.
6686         * dwarf-index-common.c: Sort headers.
6687         * dwarf-index-cache.h: Sort headers.
6688         * dwarf-index-cache.c: Sort headers.
6689         * dummy-frame.c: Sort headers.
6690         * dtrace-probe.c: Sort headers.
6691         * disasm.h: Sort headers.
6692         * disasm.c: Sort headers.
6693         * disasm-selftests.c: Sort headers.
6694         * dictionary.c: Sort headers.
6695         * dicos-tdep.c: Sort headers.
6696         * demangle.c: Sort headers.
6697         * dcache.h: Sort headers.
6698         * dcache.c: Sort headers.
6699         * darwin-nat.h: Sort headers.
6700         * darwin-nat.c: Sort headers.
6701         * darwin-nat-info.c: Sort headers.
6702         * d-valprint.c: Sort headers.
6703         * d-namespace.c: Sort headers.
6704         * d-lang.c: Sort headers.
6705         * ctf.c: Sort headers.
6706         * csky-tdep.c: Sort headers.
6707         * csky-linux-tdep.c: Sort headers.
6708         * cris-tdep.c: Sort headers.
6709         * cris-linux-tdep.c: Sort headers.
6710         * cp-valprint.c: Sort headers.
6711         * cp-support.c: Sort headers.
6712         * cp-namespace.c: Sort headers.
6713         * cp-abi.c: Sort headers.
6714         * corelow.c: Sort headers.
6715         * corefile.c: Sort headers.
6716         * continuations.c: Sort headers.
6717         * completer.h: Sort headers.
6718         * completer.c: Sort headers.
6719         * complaints.c: Sort headers.
6720         * coffread.c: Sort headers.
6721         * coff-pe-read.c: Sort headers.
6722         * cli-out.h: Sort headers.
6723         * cli-out.c: Sort headers.
6724         * charset.c: Sort headers.
6725         * c-varobj.c: Sort headers.
6726         * c-valprint.c: Sort headers.
6727         * c-typeprint.c: Sort headers.
6728         * c-lang.c: Sort headers.
6729         * buildsym.c: Sort headers.
6730         * buildsym-legacy.c: Sort headers.
6731         * build-id.h: Sort headers.
6732         * build-id.c: Sort headers.
6733         * btrace.c: Sort headers.
6734         * bsd-uthread.c: Sort headers.
6735         * breakpoint.h: Sort headers.
6736         * breakpoint.c: Sort headers.
6737         * break-catch-throw.c: Sort headers.
6738         * break-catch-syscall.c: Sort headers.
6739         * break-catch-sig.c: Sort headers.
6740         * blockframe.c: Sort headers.
6741         * block.c: Sort headers.
6742         * bfin-tdep.c: Sort headers.
6743         * bfin-linux-tdep.c: Sort headers.
6744         * bfd-target.c: Sort headers.
6745         * bcache.c: Sort headers.
6746         * ax-general.c: Sort headers.
6747         * ax-gdb.h: Sort headers.
6748         * ax-gdb.c: Sort headers.
6749         * avr-tdep.c: Sort headers.
6750         * auxv.c: Sort headers.
6751         * auto-load.c: Sort headers.
6752         * arm-wince-tdep.c: Sort headers.
6753         * arm-tdep.c: Sort headers.
6754         * arm-symbian-tdep.c: Sort headers.
6755         * arm-pikeos-tdep.c: Sort headers.
6756         * arm-obsd-tdep.c: Sort headers.
6757         * arm-nbsd-tdep.c: Sort headers.
6758         * arm-nbsd-nat.c: Sort headers.
6759         * arm-linux-tdep.c: Sort headers.
6760         * arm-linux-nat.c: Sort headers.
6761         * arm-fbsd-tdep.c: Sort headers.
6762         * arm-fbsd-nat.c: Sort headers.
6763         * arm-bsd-tdep.c: Sort headers.
6764         * arch-utils.c: Sort headers.
6765         * arc-tdep.c: Sort headers.
6766         * arc-newlib-tdep.c: Sort headers.
6767         * annotate.h: Sort headers.
6768         * annotate.c: Sort headers.
6769         * amd64-windows-tdep.c: Sort headers.
6770         * amd64-windows-nat.c: Sort headers.
6771         * amd64-tdep.c: Sort headers.
6772         * amd64-sol2-tdep.c: Sort headers.
6773         * amd64-obsd-tdep.c: Sort headers.
6774         * amd64-obsd-nat.c: Sort headers.
6775         * amd64-nbsd-tdep.c: Sort headers.
6776         * amd64-nbsd-nat.c: Sort headers.
6777         * amd64-nat.c: Sort headers.
6778         * amd64-linux-tdep.c: Sort headers.
6779         * amd64-linux-nat.c: Sort headers.
6780         * amd64-fbsd-tdep.c: Sort headers.
6781         * amd64-fbsd-nat.c: Sort headers.
6782         * amd64-dicos-tdep.c: Sort headers.
6783         * amd64-darwin-tdep.c: Sort headers.
6784         * amd64-bsd-nat.c: Sort headers.
6785         * alpha-tdep.c: Sort headers.
6786         * alpha-obsd-tdep.c: Sort headers.
6787         * alpha-nbsd-tdep.c: Sort headers.
6788         * alpha-mdebug-tdep.c: Sort headers.
6789         * alpha-linux-tdep.c: Sort headers.
6790         * alpha-linux-nat.c: Sort headers.
6791         * alpha-bsd-tdep.c: Sort headers.
6792         * alpha-bsd-nat.c: Sort headers.
6793         * aix-thread.c: Sort headers.
6794         * agent.c: Sort headers.
6795         * addrmap.c: Sort headers.
6796         * ada-varobj.c: Sort headers.
6797         * ada-valprint.c: Sort headers.
6798         * ada-typeprint.c: Sort headers.
6799         * ada-tasks.c: Sort headers.
6800         * ada-lang.c: Sort headers.
6801         * aarch64-tdep.c: Sort headers.
6802         * aarch64-ravenscar-thread.c: Sort headers.
6803         * aarch64-newlib-tdep.c: Sort headers.
6804         * aarch64-linux-tdep.c: Sort headers.
6805         * aarch64-linux-nat.c: Sort headers.
6806         * aarch64-fbsd-tdep.c: Sort headers.
6807         * aarch64-fbsd-nat.c: Sort headers.
6808         * aarch32-linux-nat.c: Sort headers.
6809
6810 2019-04-04  Tom Tromey  <tom@tromey.com>
6811
6812         * varobj.c (varobj_create): Update.
6813         * rust-exp.y (struct rust_parser) <update_innermost_block,
6814         lookup_symbol>: New methods.
6815         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6816         Rename.
6817         (rust_parser::rust_lookup_type)
6818         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6819         * printcmd.c (display_command, do_one_display): Update.
6820         * parser-defs.h (struct parser_state) <parser_state>: Add
6821         "tracker" parameter.
6822         (block_tracker): New member.
6823         (class innermost_block_tracker) <innermost_block_tracker>: Add
6824         "types" parameter.
6825         <reset>: Remove method.
6826         (innermost_block): Don't declare.
6827         (null_post_parser): Update.
6828         * parse.c (innermost_block): Remove global.
6829         (write_dollar_variable): Update.
6830         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6831         Remove "tracker_types" parameter.
6832         (parse_expression): Add "tracker" parameter.
6833         (parse_expression_for_completion): Update.
6834         (null_post_parser): Add "tracker" parameter.
6835         * p-exp.y: Update rules.
6836         * m2-exp.y: Update rules.
6837         * language.h (struct language_defn) <la_post_parser>: Add
6838         "tracker" parameter.
6839         * go-exp.y: Update rules.
6840         * f-exp.y: Update rules.
6841         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6842         parameter.
6843         * d-exp.y: Update rules.
6844         * c-exp.y: Update rules.
6845         * breakpoint.c (set_breakpoint_condition): Create an
6846         innermost_block_tracker.
6847         (watch_command_1): Likewise.
6848         * ada-lang.c (resolve): Add "tracker" parameter.
6849         (resolve_subexp): Likewise.
6850         * ada-exp.y (write_var_from_sym): Update.
6851
6852 2019-04-04  Tom Tromey  <tom@tromey.com>
6853
6854         * type-stack.h: New file.
6855         * type-stack.c: New file.
6856         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6857         type-stack.h.
6858         (insert_into_type_stack, insert_type, push_type, push_type_int)
6859         (insert_type_address_space, pop_type, pop_type_int)
6860         (pop_typelist, pop_type_stack, append_type_stack)
6861         (push_type_stack, get_type_stack, push_typelist)
6862         (follow_type_instance_flags, follow_types): Don't declare.
6863         * parse.c (type_stack): Remove global.
6864         (parse_exp_in_context): Update.
6865         (insert_into_type_stack, insert_type, push_type, push_type_int)
6866         (insert_type_address_space, pop_type, pop_type_int)
6867         (pop_typelist, pop_type_stack, append_type_stack)
6868         (push_type_stack, get_type_stack, push_typelist)
6869         (follow_type_instance_flags, follow_types): Remove (moved to
6870         type-stack.c).
6871         * f-exp.y (type_stack): New global.
6872         Update rules.
6873         (push_kind_type, f_parse): Update.
6874         * d-exp.y (type_stack): New global.
6875         Update rules.
6876         (d_parse): Update.
6877         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6878         Update rules.
6879         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6880         (HFILES_NO_SRCDIR): Add type-stack.h.
6881
6882 2019-04-04  Tom Tromey  <tom@tromey.com>
6883
6884         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6885         (rust_parser::convert_ast_to_expression, rust_parse)
6886         (rust_lex_test_completion, rust_lex_tests): Update.
6887         * parser-defs.h (struct expr_completion_state): New.
6888         (struct parser_state) <parser_state>: Add completion parameter.
6889         <mark_struct_expression, mark_completion_tag>: New methods.
6890         <parse_completion, m_completion_state>: New members.
6891         (prefixify_expression, null_post_parser): Update.
6892         (mark_struct_expression, mark_completion_tag): Don't declare.
6893         * parse.c (parse_completion, expout_last_struct)
6894         (expout_tag_completion_type, expout_completion_name): Remove
6895         globals.
6896         (parser_state::mark_struct_expression)
6897         (parser_state::mark_completion_tag): Now methods.
6898         (prefixify_expression): Add last_struct parameter.
6899         (prefixify_subexp): Likewise.
6900         (parse_exp_1): Update.
6901         (parse_exp_in_context): Add cstate parameter.  Update.
6902         (parse_expression_for_completion): Create an
6903         expr_completion_state.
6904         (null_post_parser): Add "completion" parameter.
6905         * p-exp.y: Update rules.
6906         (yylex): Update.
6907         * language.h (struct language_defn) <la_post_parser>: Add
6908         "completing" parameter.
6909         * go-exp.y: Update rules.
6910         (lex_one_token): Update.
6911         * expression.h (parse_completion): Don't declare.
6912         * d-exp.y: Update rules.
6913         (lex_one_token): Update rules.
6914         * c-exp.y: Update rules.
6915         (lex_one_token): Update.
6916         * ada-lang.c (resolve): Add "parse_completion" parameter.
6917         (resolve_subexp): Likewise.
6918         (ada_resolve_function): Likewise.
6919
6920 2019-04-04  Tom Tromey  <tom@tromey.com>
6921
6922         * parser-defs.h (struct parser_state) <start_arglist,
6923         end_arglist>: New methods.
6924         <arglist_len, m_funcall_chain>: New members.
6925         (arglist_len, start_arglist, end_arglist): Don't declare.
6926         * parse.c (arglist_len, funcall_chain): Remove global.
6927         (start_arglist, end_arglist): Remove functions.
6928         (parse_exp_in_context): Update.
6929         * p-exp.y: Update rules.
6930         * m2-exp.y: Update rules.
6931         * go-exp.y: Update rules.
6932         * f-exp.y: Update rules.
6933         * d-exp.y: Update rules.
6934         * c-exp.y: Update rules.
6935
6936 2019-04-04  Tom Tromey  <tom@tromey.com>
6937
6938         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6939         lex_operator, push_back>: New methods.
6940         Update all rules.
6941         (rust_parser::lex_hex, lex_escape): Rename and update.
6942         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6943         (rust_parser::lex_operator): Rename and update.
6944         (rust_parser::lex_number, rustyylex, rustyyerror)
6945         (rust_lex_test_init, rust_lex_test_sequence)
6946         (rust_lex_test_push_back, rust_lex_tests): Update.
6947         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6948         parameter.
6949         <lexptr, prev_lexptr>: New members.
6950         (lexptr, prev_lexptr): Don't declare.
6951         * parse.c (lexptr, prev_lexptr): Remove globals.
6952         (parse_exp_in_context): Update.
6953         * p-exp.y (yylex, yyerror): Update.
6954         * m2-exp.y (parse_number, yylex, yyerror): Update.
6955         * go-exp.y (lex_one_token, yyerror): Update.
6956         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6957         * d-exp.y (lex_one_token, yyerror): Update.
6958         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6959         (lex_one_token, yyerror): Update.
6960         * ada-lex.l (YY_INPUT): Update.
6961         (rewind_to_char): Update.
6962         * ada-exp.y (yyerror): Update.
6963
6964 2019-04-04  Tom Tromey  <tom@tromey.com>
6965
6966         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6967         * parser-defs.h (struct parser_state) <parser_state>: Add new
6968         parameter.
6969         <comma_terminates>: New member.
6970         (comma_terminates): Don't declare global.
6971         * parse.c (comma_terminates): Remove global.
6972         (parse_exp_in_context): Update.
6973         * p-exp.y (yylex): Update.
6974         * m2-exp.y (yylex): Update.
6975         * go-exp.y (lex_one_token): Update.
6976         * f-exp.y (yylex): Update.
6977         * d-exp.y (lex_one_token): Update.
6978         * c-exp.y (lex_one_token): Update.
6979         * ada-lex.l: Update.
6980
6981 2019-04-04  Tom Tromey  <tom@tromey.com>
6982
6983         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6984         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6985         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6986         * parser-defs.h (paren_depth): Don't declare.
6987         * parse.c (paren_depth): Remove global.
6988         (parse_exp_in_context): Update.
6989         * p-exp.y (paren_depth): New global.
6990         (pascal_parse): Initialize it.
6991         * m2-exp.y (paren_depth): New global.
6992         (m2_parse): Initialize it.
6993         * go-exp.y (paren_depth): New global.
6994         (go_parse): Initialize it.
6995         * f-exp.y (paren_depth): New global.
6996         (f_parse): Initialize it.
6997         * d-exp.y (paren_depth): New global.
6998         (d_parse): Initialize it.
6999         * c-exp.y (paren_depth): New global.
7000         (c_parse): Initialize it.
7001         * ada-lex.l (paren_depth): New global.
7002         (lexer_init): Initialize it.
7003
7004 2019-04-04  Tom Tromey  <tom@tromey.com>
7005
7006         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7007         (rust_parser::convert_ast_to_type)
7008         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7009         * parser-defs.h (struct parser_state) <parser_state>: Add
7010         parameters.  Initialize new members.
7011         <expression_context_block, expression_context_pc>: New members.
7012         * parse.c (expression_context_block, expression_context_pc):
7013         Remove globals.
7014         (parse_exp_in_context): Update.
7015         * p-exp.y: Update all rules.
7016         (yylex): Update.
7017         * m2-exp.y: Update all rules.
7018         (yylex): Update.
7019         * go-exp.y (yylex): Update.
7020         * f-exp.y (yylex): Update.
7021         * d-exp.y: Update all rules.
7022         (yylex): Update.
7023         * c-exp.y: Update all rules.
7024         (lex_one_token, classify_name, yylex, c_parse): Update.
7025         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7026
7027 2019-04-04  Tom Tromey  <tom@tromey.com>
7028
7029         * gdbarch.h, gdbarch.c: Rebuild.
7030         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7031         * stap-probe.h: 
7032         (struct stap_parse_info): Replace "parser_state" with
7033         "expr_builder".
7034         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7035         (parser_state): New class.
7036         * parse.c (expr_builder): Rename.
7037         (expr_builder::release): Rename.
7038         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7039         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7040         (write_exp_elt_longcst, write_exp_elt_floatcst)
7041         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7042         (write_exp_string_vector, write_exp_bitstring)
7043         (write_exp_msymbol, mark_struct_expression)
7044         (write_dollar_variable)
7045         (insert_type_address_space, increase_expout_size): Replace
7046         "parser_state" with "expr_builder".
7047         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7048         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7049         "parser_state" with "expr_builder".
7050
7051 2019-04-04  Tom Tromey  <tom@tromey.com>
7052
7053         * rust-exp.y: Replace "parse_language" with method call.
7054         * p-exp.y: 
7055         (yylex): Replace "parse_language" with method call.
7056         * m2-exp.y: 
7057         (yylex): Replace "parse_language" with method call.
7058         * go-exp.y (classify_name): Replace "parse_language" with method
7059         call.
7060         * f-exp.y (yylex): Replace "parse_language" with method call.
7061         * d-exp.y (lex_one_token): Replace "parse_language" with method
7062         call.
7063         * c-exp.y: 
7064         (lex_one_token, classify_name, yylex): Replace "parse_language"
7065         with method call.
7066         * ada-exp.y (find_primitive_type, type_char)
7067         (type_system_address): Replace "parse_language" with method call.
7068
7069 2019-04-04  Tom Tromey  <tom@tromey.com>
7070
7071         * rust-exp.y: Replace "parse_gdbarch" with method call.
7072         * parse.c (write_dollar_variable, insert_type_address_space):
7073         Replace "parse_gdbarch" with method call.
7074         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7075         call.
7076         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7077         call.
7078         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7079         "parse_gdbarch" with method call.
7080         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7081         with method call.
7082         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7083         "parse_gdbarch" with method call.
7084         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7085         "parse_gdbarch" with method call.
7086         * c-exp.y (parse_type, parse_number, classify_name): Replace
7087         "parse_gdbarch" with method call.
7088         * ada-lex.l: Replace "parse_gdbarch" with method call.
7089         * ada-exp.y (parse_type, find_primitive_type, type_char)
7090         (type_system_address): Replace "parse_gdbarch" with method call.
7091
7092 2019-04-04  Tom Tromey  <tom@tromey.com>
7093
7094         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7095         * stap-probe.c (stap_parse_argument): Update.
7096         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7097         initial_size parameter.
7098         * rust-exp.y (rust_lex_tests): Update.
7099         * parse.c (parser_state): Update.
7100         (parse_exp_in_context): Update.
7101         * parser-defs.h (struct parser_state) <parser_state>: Remove
7102         "initial_size" parameter.
7103
7104 2019-04-04  Tom Tromey  <tom@tromey.com>
7105
7106         * parser-defs.h (increase_expout_size): Don't declare.
7107         * parse.c (increase_expout_size): Now static.
7108
7109 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7110
7111         * gnu-nat.c (gnu_nat_target::wait): Fix
7112         target_waitstatus_to_string call.
7113
7114 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7115
7116         * eval.c (evaluate_subexp_standard): Handle internal functions
7117         during Fortran function call handling.
7118
7119 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7120
7121         * NEWS: Mention new internal functions.
7122         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7123         (read_base_type): Use dwarf2_init_complex_target_type.
7124         * value.c (creal_internal_fn): New function.
7125         (cimag_internal_fn): New function.
7126         (_initialize_values): Register new internal functions.
7127
7128 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7129
7130         * infrun.c (stop_all_threads): If debug_infrun, always
7131         trace the wait status after wait_one, using
7132         target_waitstatus_to_string and target_pid_to_str.
7133         (handle_inferior_event): Replace various trace of
7134         wait status kind by a single trace.
7135         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7136         wait status kind image by target_waitstatus_to_string.
7137         * target/waitstatus.c (target_waitstatus_to_string): Fix
7138         obsolete comment.
7139
7140 2019-04-01  Tom Tromey  <tromey@adacore.com>
7141
7142         PR symtab/23331:
7143         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7144
7145 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7146             Pedro Alves  <palves@redhat.com>
7147
7148         * top.c (quit_force): Call 'finalize_values'.
7149         * value.c (finalize_values): New function.
7150         * value.h (finalize_values): Declare.
7151
7152 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7153
7154         * NEWS: Announce $_gdb_major and $_gdb_minor.
7155
7156         * top.c (init_gdb_version_vars): New function.
7157         (gdb_init): Call init_gdb_version_vars.
7158
7159 2019-03-29  Tom Tromey  <tromey@adacore.com>
7160
7161         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7162         help text.  Remove dead code.
7163
7164 2019-03-29  Keith Seitz  <keiths@redhat.com>
7165
7166         From Siddhesh Poyarekar:
7167         * f-lang.h (f77_get_upperbound): Return LONGEST.
7168         (f77_get_lowerbound): Likewise.
7169         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7170         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7171         print them.
7172         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7173         plongest to format print it.
7174         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7175         (f77_get_upperbound): Likewise.
7176         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7177         LOWER_BOUND to LONGEST.
7178         (f77_create_arrayprint_offset_tbl): Likewise.
7179
7180 2019-03-29  Keith Seitz  <keiths@redhat.com>
7181
7182         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7183         %s/pulongest for TYPE_LENGTH instead of %d in format
7184         strings.
7185         * ada-typerint.c (ada_print_type): Likewise.
7186         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7187         * compile/compile-c-support.c (generate_register_struct): Likewise.
7188         * gdbtypes.c (recursive_dump_type): Likewise.
7189         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7190         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7191         instead of %d in format strings.
7192         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7193         to std::min to ULONGEST.
7194         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7195         instead of %d in format strings.
7196         * tracepoint.c (info_scope_command): Likewise.
7197         * typeprint.c (print_offset_data::update)
7198         (print_offset_data::finish): Likewise.
7199         * xtensa-tdep.c (xtensa_store_return_value)
7200         (xtensa_push_dummy_call): Likewise.
7201
7202 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7203
7204         * windows-nat.c (display_selector): Fixed format specifications
7205         for 64-bit Cygwin.
7206
7207 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7208
7209         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7210
7211 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7212
7213         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7214         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7215         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7216         (nios2_linux_init_abi): Install it.
7217
7218 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7219
7220         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7221
7222 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7223
7224         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7225
7226 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7227             Tom Tromey  <tromey@adacore.com>
7228
7229         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7230
7231 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7232
7233         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7234         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7235         method to compute the bounds of range types. Also print "[evaluated]"
7236         if the bounds' values come from a dynamic evaluation.
7237
7238 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7239
7240         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7241         whitespace when pretty printing is on.
7242
7243 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7244
7245         * ppc-linux-nat.c: Add include.
7246
7247 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7248
7249         * NEWS: Mention AArch64 Pointer Authentication.
7250
7251 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7252
7253         * arm-linux-nat.c: Add include.
7254
7255 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7256
7257         * source-cache.c (source_cache::get_source_lines): Re-read
7258         fullname after calling open_source_file.
7259
7260 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7261
7262         * NEWS: Mention TLS support for FreeBSD.
7263
7264 2019-03-25  Tom Tromey  <tromey@adacore.com>
7265
7266         * minsyms.c (BUNCH_SIZE): Update comment.
7267         (~minimal_symbol_reader): Remove old comment.
7268         (compact_minimal_symbols): Update comment.
7269         (minimal_symbol_reader::install): Remove old comment.  Update
7270         other comments.
7271
7272 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7273
7274         * s390-linux-nat.c: Add include.
7275
7276 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7277
7278         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7279         Call linux_get_hwcap.
7280         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7281         Likewise.
7282         (aarch64_linux_get_hwcap): Remove function.
7283         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7284         declaration.
7285         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7286         linux_get_hwcap.
7287         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7288         * linux-tdep.c (linux_get_hwcap): Add function.
7289         (linux_get_hwcap2): Likewise.
7290         * linux-tdep.h (linux_get_hwcap): Add declaration.
7291         (linux_get_hwcap2): Likewise.
7292         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7293         (ppc_linux_get_hwcap2): Likewise.
7294         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7295         linux_get_hwcap.
7296         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7297         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7298         (ppc_linux_nat_target::read_description): Likewise.
7299         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7300         * s390-linux-nat.c: Likewise.
7301         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7302
7303 2019-03-24  Tom Tromey  <tom@tromey.com>
7304
7305         * ada-lang.c (standard_lookup): Simplify initialization.
7306         (ada_lookup_symbol_nonlocal): Simplify return.
7307         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7308         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7309         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7310         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7311         initialization.
7312         * solib.c (solib_global_lookup): Simplify.
7313         * symtab.c (null_block_symbol): Remove.
7314         (symbol_cache_lookup): Simplify returns.
7315         (lookup_language_this): Simplify returns.
7316         (lookup_symbol_aux): Simplify return.
7317         (lookup_local_symbol): Simplify returns.
7318         (lookup_global_symbol_from_objfile): Simplify return.
7319         (lookup_symbol_in_objfile_symtabs)
7320         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7321         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7322         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7323         * cp-namespace.c (cp_lookup_bare_symbol)
7324         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7325         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7326         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7327         (cp_lookup_symbol_via_imports): Simplify initialization.
7328         (find_symbol_in_baseclass): Likewise.
7329         * symtab.h (null_block_symbol): Remove.
7330         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7331         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7332         (d_lookup_symbol_module): Likewise.
7333         (find_symbol_in_baseclass): Simplify initialization.
7334
7335 2019-03-24  Tom Tromey  <tom@tromey.com>
7336
7337         * expression.h: Don't include symtab.h.
7338         (struct block): Forward declare.
7339
7340 2019-03-24  Tom Tromey  <tom@tromey.com>
7341
7342         * c-exp.y (typebase): Remove casts.
7343         * gdbtypes.c (lookup_unsigned_typename, )
7344         (lookup_signed_typename): Remove cast.
7345         * eval.c (parse_to_comma_and_eval): Remove cast.
7346         * parse.c (write_dollar_variable): Remove cast.
7347         * block.h (struct block) <superblock>: Now const.
7348         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7349         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7350         (map_block): Make "block" const.
7351         * symfile.h (struct quick_symbol_functions)
7352         <map_matching_symbols>: Constify block argument to "callback".
7353         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7354         const.
7355         (find_pc_sect_compunit_symtab): Make "b" const.
7356         (find_symbol_at_address): Likewise.
7357         (search_symbols): Likewise.
7358         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7359         (dw2_debug_names_lookup_symbol): Likewise.
7360         (dw2_map_matching_symbols): Update.
7361         * p-valprint.c (pascal_val_print): Remove "block".
7362         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7363         (aux_add_nonlocal_symbols): Make "block" const.
7364         (resolve_subexp): Remove cast.
7365         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7366         const.
7367         (iterate_over_file_blocks): Likewise.
7368         * f-exp.y (%union) <bval>: Remove.
7369         * coffread.c (patch_opaque_types): Make "b" const.
7370         * spu-tdep.c (spu_catch_start): Make "block" const.
7371         * c-valprint.c (print_unpacked_pointer): Remove "block".
7372         * symmisc.c (dump_symtab_1): Make "b" const.
7373         (block_depth): Make "block" const.
7374         * d-exp.y (%union) <bval>: Remove.
7375         * cp-support.h (cp_lookup_rtti_type): Update.
7376         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7377         * psymtab.c (psym_lookup_symbol): Make "block" const.
7378         (maintenance_check_psymtabs): Make "b" const.
7379         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7380         (enumerate_locals, enumerate_args): Update.
7381         * python/py-symtab.c (stpy_global_block): Make "block" const.
7382         (stpy_static_block): Likewise.
7383         * inline-frame.c (block_starting_point_at): Make "new_block"
7384         const.
7385         * block.c (find_block_in_blockvector): Make return type const.
7386         (blockvector_for_pc_sect): Make "b" const.
7387         (find_block_in_blockvector): Make "b" const.
7388
7389 2019-03-23  Tom Tromey  <tom@tromey.com>
7390
7391         * varobj.c (varobj_create): Update.
7392         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7393         * printcmd.c (display_command, do_one_display): Don't reset
7394         innermost_block.
7395         * parser-defs.h (enum innermost_block_tracker_type): Move to
7396         expression.h.
7397         (innermost_block): Update comment.
7398         * parse.c (parse_exp_1): Add tracker_types parameter.
7399         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7400         tracker_types parameter.  Reset innermost_block.
7401         (parse_exp_in_context): Remove.
7402         (parse_expression_for_completion): Update.
7403         * objfiles.c (~objfile): Don't reset expression_context_block or
7404         innermost_block.
7405         * expression.h (enum innermost_block_tracker_type): Move from
7406         parser-defs.h.
7407         (parse_exp_1): Add tracker_types parameter.
7408         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7409         reset innermost_block.
7410
7411 2019-03-23  Tom Tromey  <tom@tromey.com>
7412
7413         * objfiles.h: Include bcache.h.
7414
7415 2019-03-23  Tom Tromey  <tom@tromey.com>
7416
7417         * linespec.c (get_current_search_block): Use
7418         scoped_restore_current_language.
7419         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7420
7421 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7422             Jiong Wang  <jiong.wang@arm.com>
7423
7424         * aarch64-linux-tdep.c
7425         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7426         section.
7427         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7428
7429 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7430             Jiong Wang  <jiong.wang@arm.com>
7431
7432         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7433         instructions.
7434         (aarch64_analyze_prologue_test): Add PACIASP test.
7435         (aarch64_prologue_prev_register): Unmask PC value.
7436
7437 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7438             Jiong Wang  <jiong.wang@arm.com>
7439
7440         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7441         (aarch64_dwarf2_prev_register): Unmask PC value.
7442         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7443         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7444         DW_CFA_AARCH64_negate_ra_state.
7445         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7446
7447 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7448             Jiong Wang  <jiong.wang@arm.com>
7449
7450         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7451         registers.
7452         (aarch64_pseudo_register_name): Likewise.
7453         (aarch64_pseudo_register_type): Likewise.
7454         (aarch64_pseudo_register_reggroup_p): Likewise.
7455         (aarch64_gdbarch_init): Add pauth registers.
7456         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7457         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7458         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7459         (struct gdbarch_tdep): Add regnum for ra_state.
7460
7461 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7462             Jiong Wang  <jiong.wang@arm.com>
7463
7464         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7465
7466 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7467             Jiong Wang  <jiong.wang@arm.com>
7468
7469         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7470         function.
7471         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7472         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7473         (aarch64_gdbarch_init): Add puth registers.
7474         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7475         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7476         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7477
7478 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7479             Jiong Wang  <jiong.wang@arm.com>
7480
7481         * aarch64-linux-nat.c
7482         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7483         * aarch64-linux-tdep.c
7484         (aarch64_linux_core_read_description): Likewise.
7485         (aarch64_linux_get_hwcap): New function.
7486         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7487         (aarch64_linux_get_hwcap): New declaration.
7488
7489 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7490             Jiong Wang  <jiong.wang@arm.com>
7491
7492         * aarch64-linux-nat.c
7493         (aarch64_linux_nat_target::read_description): Add pauth param.
7494         * aarch64-linux-tdep.c
7495         (aarch64_linux_core_read_description): Likewise.
7496         * aarch64-tdep.c (struct target_desc): Add in pauth.
7497         (aarch64_read_description): Add pauth param.
7498         (aarch64_gdbarch_init): Likewise.
7499         * aarch64-tdep.h (aarch64_read_description): Likewise.
7500         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7501         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7502         * features/Makefile: Add new files.
7503         * features/aarch64-pauth.c: New file.
7504         * features/aarch64-pauth.xml: New file.
7505
7506 2019-03-20  Tom Tromey  <tromey@adacore.com>
7507
7508         * infrun.c (handle_inferior_event): Rename from
7509         handle_inferior_event_1.  Create a scoped_value_mark.
7510         (handle_inferior_event): Remove.
7511
7512 2019-03-19  Tom Tromey  <tromey@adacore.com>
7513
7514         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7515         * infrun.h (print_stop_event): Add "displays" parameter.
7516         * infrun.c (print_stop_event): Add "displays" parameter.
7517
7518 2019-03-19  Pedro Alves  <palves@redhat.com>
7519
7520         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7521         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7522         to -1.  Fix TABs vs spaces.
7523         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7524         * tui/tui-out.h (tui_ui_out) Add intro comments.
7525         <m_line, m_start_of_line>: In-class initialize, and add describing
7526         comment.
7527
7528 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7529
7530         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7531         variable names.
7532         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7533
7534 2019-03-18  Pedro Alves  <palves@redhat.com>
7535             Eli Zaretskii <eliz@gnu.org>
7536
7537         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7538         m_line and m_start_of_line.
7539
7540 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7541
7542         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7543         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7544         it returns a newline.  This fixes a regression in TU mode, whereby
7545         the next line is output on the same screen line as the user input.
7546
7547 2019-03-18  Tom Tromey  <tromey@adacore.com>
7548
7549         * minsyms.c (minimal_symbol_reader::install): Remove call to
7550         obstack_blank.
7551
7552 2019-03-18  Pedro Alves  <palves@redhat.com>
7553
7554         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7555         New globals.
7556         (apply_style): New, factored out from ...
7557         (apply_ansi_escape): ... this.  Handle reverse video mode.
7558         (tui_set_reverse_mode): New function.
7559         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7560         * tui/tui-winsource.c (tui_show_source_line): Use
7561         tui_set_reverse_mode instead of setting A_STANDOUT.
7562         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7563         New setter methods.
7564
7565 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7566
7567         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7568         Handle tabs.
7569
7570 2019-03-18  Tom Tromey  <tromey@adacore.com>
7571
7572         * ada-lang.c (empty_array): Add "high" parameter.
7573         (ada_evaluate_subexp): Update.
7574
7575 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7576
7577         * unittests/string_view-selftests.c: Define
7578         _initialize_string_view_selftests unconditionally.
7579
7580 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7581
7582         PR gdb/24350
7583         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7584
7585 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7586
7587         PR gdb/24351
7588         * windows-nat.c (display_selector): Fix format specifiers.
7589
7590 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7591
7592         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7593         tui_refill_source_window instead of tui_refresh_win, to update the
7594         current execution line.  This fixes redisplay of the current line
7595         when stepping through the code with "next" or "step".
7596
7597 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7598
7599         * source-cache.c (source_cache::get_source_lines): Call
7600         find_source_lines to initialize s->nlines.  This fixes vertical
7601         scrolling of TUI source window when the DOWN arrow is pressed.
7602
7603 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7604
7605         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7606         linux-thread-db.c (_initialize_thread_db): Likewise.
7607
7608 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7609
7610         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7611         wclrtoeol in tui_show_source_line".  This reverts changes made in
7612         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7613
7614 2019-03-15  Tom Tromey  <tom@tromey.com>
7615
7616         * symtab.h (struct minimal_symbol): Derive from
7617         general_symbol_info.
7618         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7619         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7620         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7621         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7622         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7623         (MSYMBOL_SEARCH_NAME): Update.
7624         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7625         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7626         * minsyms.c (minimal_symbol_reader::record_full): Update.
7627
7628 2019-03-15  Tom Tromey  <tom@tromey.com>
7629
7630         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7631
7632 2019-03-15  Tom Tromey  <tom@tromey.com>
7633
7634         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7635         unique_xmalloc_ptr.
7636         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7637         Update.
7638         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7639         (build_minimal_symbol_hash_tables)
7640         (minimal_symbol_reader::install): Update.
7641
7642 2019-03-15  Tom Tromey  <tom@tromey.com>
7643
7644         * symtab.c (create_demangled_names_hash): Update.
7645         (symbol_set_names): Update.
7646         * objfiles.h (struct objfile_per_bfd_storage)
7647         <demangled_names_hash>: Now an htab_up.
7648         * objfiles.c (objfile_per_bfd_storage): Simplify.
7649
7650 2019-03-15  Tom Tromey  <tom@tromey.com>
7651
7652         * objfiles.h (struct objfile_per_bfd_storage): Declare
7653         destructor.
7654         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7655         New.
7656         (get_objfile_bfd_data): Use new.  Don't initialize
7657         language_of_main.
7658         (free_objfile_per_bfd_storage): Remove.
7659         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7660
7661 2019-03-15  Tom Tromey  <tom@tromey.com>
7662
7663         * symfile.c (reread_symbols): Update.
7664         * objfiles.c (objfile::objfile): Update.
7665         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7666         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7667         comment.
7668         (minimal_symbol_reader::install): Update.
7669         (terminate_minimal_symbol_table): Remove.
7670         * jit.c (jit_object_close_impl): Update.
7671
7672 2019-03-15  Tom Tromey  <tom@tromey.com>
7673
7674         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7675         initializations.
7676
7677 2019-03-15  Tom Tromey  <tom@tromey.com>
7678
7679         * objfiles.h (struct objfile_per_bfd_storage)
7680         <demangled_hash_languages>: Now a bitset.
7681         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7682         (lookup_minimal_symbol): Update.
7683
7684 2019-03-15  Tom Tromey  <tom@tromey.com>
7685
7686         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7687         Don't return the symbol.
7688         * coffread.c (record_minimal_symbol): Use record_full.
7689
7690 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7691
7692         The MS-Windows port of ncurses fails to switch to a color pair if
7693         one or both of the colors are the implicit default colors.  This
7694         change records the default colors when TUI is initialized, and
7695         then specifies them explicitly when a color pair uses the default
7696         colors.  This allows color styling in TUI mode on MS-Windows.
7697
7698         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7699         ncurses_norm_attr.
7700         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7701         colors in ncurses_norm_attr.
7702         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7703         "none", replace it with the default color recorded in
7704         ncurses_norm_attr.
7705
7706 2019-03-14  Tom Tromey  <tromey@adacore.com>
7707
7708         * source-cache.h (class source_cache) <get_source_lines>: Return
7709         std::string.
7710         * source-cache.c (source_cache::extract_lines): Handle case where
7711         first_pos==npos.  Return std::string.
7712         (source_cache::get_source_lines): Update.
7713
7714 2019-03-14  Tom Tromey  <tromey@adacore.com>
7715
7716         * NEWS: Add item for "style sources" commands.
7717         * source-cache.c (source_cache::get_source_lines): Check
7718         source_styling.
7719         * cli/cli-style.c (source_styling): New global.
7720         (_initialize_cli_style): Add "style sources" commands.
7721         (show_style_sources): New function.
7722         * cli/cli-style.h (source_styling): Declare.
7723
7724 2019-03-14  Pedro Alves  <palves@redhat.com>
7725             Tom Tromey  <tromey@adacore.com>
7726
7727         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7728         * tui/tui-winsource.c (tui_refill_source_window): New function,
7729         from...
7730         (tui_horizontal_source_scroll): ... here.  Move some logic.
7731         * cli/cli-style.c (set_style_enabled): Notify new observable.
7732         * tui/tui-hooks.c (tui_redisplay_source): New function.
7733         (tui_attach_detach_observers): Attach or detach
7734         tui_redisplay_source.
7735         * observable.h (source_styling_changed): New observable.
7736         * observable.c: Define source_styling_changed observable.
7737
7738 2019-03-13  Tom Tromey  <tromey@adacore.com>
7739
7740         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7741         (i386_gnu_nat_target::store_registers): Update.
7742         * target-debug.h (target_debug_print_std_string): New macro.
7743         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7744         * windows-tdep.c (display_one_tib): Update.
7745         * tui/tui-stack.c (tui_make_status_line): Update.
7746         * top.c (print_inferior_quit_action): Update.
7747         * thread.c (thr_try_catch_cmd): Update.
7748         (add_thread_with_info): Update.
7749         (thread_target_id_str): Update.
7750         (thr_try_catch_cmd): Update.
7751         (thread_command): Update.
7752         (thread_find_command): Update.
7753         * record-btrace.c (record_btrace_target::info_record)
7754         (record_btrace_resume_thread, record_btrace_target::resume)
7755         (record_btrace_cancel_resume, record_btrace_step_thread)
7756         (record_btrace_target::wait, record_btrace_target::wait)
7757         (record_btrace_target::wait, record_btrace_target::stop): Update.
7758         * progspace.c (print_program_space): Update.
7759         * process-stratum-target.c
7760         (process_stratum_target::thread_address_space): Update.
7761         * linux-fork.c (linux_fork_mourn_inferior)
7762         (detach_checkpoint_command, info_checkpoints_command)
7763         (linux_fork_context): Update.
7764         (linux_fork_detach): Update.
7765         (class scoped_switch_fork_info): Update.
7766         (delete_checkpoint_command): Update.
7767         * infrun.c (follow_fork_inferior): Update.
7768         (follow_fork_inferior): Update.
7769         (proceed_after_vfork_done): Update.
7770         (handle_vfork_child_exec_or_exit): Update.
7771         (follow_exec): Update.
7772         (displaced_step_prepare_throw): Update.
7773         (displaced_step_restore): Update.
7774         (start_step_over): Update.
7775         (resume_1): Update.
7776         (clear_proceed_status_thread): Update.
7777         (proceed): Update.
7778         (print_target_wait_results): Update.
7779         (do_target_wait): Update.
7780         (context_switch): Update.
7781         (stop_all_threads): Update.
7782         (restart_threads): Update.
7783         (finish_step_over): Update.
7784         (handle_signal_stop): Update.
7785         (switch_back_to_stepped_thread): Update.
7786         (keep_going_pass_signal): Update.
7787         (print_exited_reason): Update.
7788         (normal_stop): Update.
7789         * inferior.c (inferior_pid_to_str): Change return type.
7790         (print_selected_inferior): Update.
7791         (add_inferior): Update.
7792         (detach_inferior): Update.
7793         * dummy-frame.c (fprint_dummy_frames): Update.
7794         * dcache.c (dcache_info_1): Update.
7795         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7796         (btrace_fetch, btrace_clear): Update.
7797         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7798         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7799         type.
7800         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7801         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7802         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7803         * gdbarch.c, gdbarch.h: Rebuild.
7804         * gdbarch.sh (core_pid_to_str): Change return type.
7805         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7806         return type.
7807         (windows_nat_target::pid_to_str): Change return type.
7808         (windows_delete_thread): Update.
7809         (windows_nat_target::attach): Update.
7810         (windows_nat_target::files_info): Update.
7811         * target-delegates.c: Rebuild.
7812         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7813         return type.
7814         (sol_thread_target::pid_to_str): Change return type.
7815         * remote.c (class remote_target) <pid_to_str>: Change return
7816         type.
7817         (remote_target::pid_to_str): Change return type.
7818         (extended_remote_target::attach, remote_target::remote_stop_ns)
7819         (remote_target::remote_notif_remove_queued_reply)
7820         (remote_target::push_stop_reply, remote_target::disable_btrace):
7821         Update.
7822         (extended_remote_target::attach): Update.
7823         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7824         type.
7825         (gdbsim_target::pid_to_str): Change return type.
7826         * ravenscar-thread.c (struct ravenscar_thread_target)
7827         <pid_to_str>: Change return type.
7828         (ravenscar_thread_target::pid_to_str): Change return type.
7829         * procfs.c (class procfs_target) <pid_to_str>: Change return
7830         type.
7831         (procfs_target::pid_to_str): Change return type.
7832         (procfs_target::attach): Update.
7833         (procfs_target::detach): Update.
7834         (procfs_target::fetch_registers): Update.
7835         (procfs_target::store_registers): Update.
7836         (procfs_target::wait): Update.
7837         (procfs_target::files_info): Update.
7838         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7839         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7840         return type.
7841         (nto_procfs_target::pid_to_str): Change return type.
7842         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7843         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7844         return type.
7845         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7846         (exit_lwp): Update.
7847         (attach_proc_task_lwp_callback, get_detach_signal)
7848         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7849         (linux_nat_target::resume, wait_lwp, stop_callback)
7850         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7851         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7852         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7853         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7854         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7855         type.
7856         (inf_ptrace_target::attach): Update.
7857         (inf_ptrace_target::files_info): Update.
7858         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7859         type.
7860         (go32_nat_target::pid_to_str): Change return type.
7861         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7862         (gnu_nat_target::wait): Update.
7863         (gnu_nat_target::wait): Update.
7864         (gnu_nat_target::resume): Update.
7865         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7866         (fbsd_nat_target::wait): Update.
7867         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7868         type.
7869         (darwin_nat_target::attach): Update.
7870         * corelow.c (class core_target) <pid_to_str>: Change return type.
7871         (core_target::pid_to_str): Change return type.
7872         * target.c (normal_pid_to_str): Change return type.
7873         (default_pid_to_str): Likewise.
7874         (target_pid_to_str): Change return type.
7875         (target_translate_tls_address): Update.
7876         (target_announce_detach): Update.
7877         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7878         return type.
7879         (bsd_uthread_target::pid_to_str): Change return type.
7880         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7881         type.
7882         (bsd_kvm_target::pid_to_str): Change return type.
7883         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7884         return type.
7885         (aix_thread_target::pid_to_str): Change return type.
7886         * target.h (struct target_ops) <pid_to_str>: Change return type.
7887         (target_pid_to_str, normal_pid_to_str): Likewise.
7888         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7889         type.
7890         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7891         type.
7892         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7893         return type.
7894         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7895         type.
7896         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7897         type.
7898         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7899         return type.
7900
7901 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7902
7903         * NEWS: Mention that the new default MI version is 3.  Mention
7904         changes to the output of commands and events that deal with
7905         multi-location breakpoints.
7906         * breakpoint.c: Include "mi/mi-out.h".
7907         (print_one_breakpoint): Change output syntax if using MI version
7908         >= 3.
7909         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7910         New.
7911         (mi_multi_location_breakpoint_output_fixed): New.
7912         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7913         (mi_cmd_fix_multi_location_breakpoint_output): New.
7914         (mi_multi_location_breakpoint_output_fixed): New.
7915         * mi/mi-cmds.c (mi_cmds): Register command
7916         -fix-multi-location-breakpoint-output.
7917         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7918         interpreter "mi".
7919
7920 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7921
7922         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7923         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7924         instantiate mi_ui_out based on interpreter name.
7925         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7926         * mi/mi-main.c (mi_load_progress): Likewise.
7927
7928 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7929
7930         * NEWS: Combine separate "New targets" sections for 8.3.
7931
7932 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7933
7934         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7935         (ppcfbsd_init_abi): Install gdbarch
7936         "fetch_tls_load_module_address" and "get_thread_local_address"
7937         methods.
7938
7939 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7940
7941         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7942         (riscv_fbsd_init_abi): Install gdbarch
7943         "fetch_tls_load_module_address" and "get_thread_local_address"
7944         methods.
7945
7946 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7947
7948         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7949         (i386fbsd_init_abi): Install gdbarch
7950         "fetch_tls_load_module_address" and "get_thread_local_address"
7951         methods.
7952
7953 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7954
7955         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7956         (amd64fbsd_init_abi): Install gdbarch
7957         "fetch_tls_load_module_address" and "get_thread_local_address"
7958         methods.
7959
7960 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7961
7962         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7963         (struct fbsd_pspace_data): New type.
7964         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7965         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7966         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7967         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7968         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7969
7970 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7971
7972         * gdbtypes.c (lookup_struct_elt): New function.
7973         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7974         * gdbtypes.h (struct struct_elt): New type.
7975         (lookup_struct_elt): New prototype.
7976
7977 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7978
7979         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7980         remove disabled code block.
7981
7982 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7983
7984         * gdbarch.sh (get_thread_local_address): New method.
7985         * gdbarch.h, gdbarch.c: Regenerate.
7986         * target.c (target_translate_tls_address): Use
7987         gdbarch_get_thread_local_address if present instead of
7988         target::get_thread_local_address.
7989
7990 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7991
7992         * target.h (target::get_thread_local_address): Update comment.
7993
7994 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7995
7996         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7997         objfile->separate_debug_objfile_backlink if not NULL.
7998
7999 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8000
8001         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8002         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8003         (amd64bsd_store_inferior_registers): Likewise.
8004         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8005         Enable segment base registers.
8006         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8007         PT_GETFSBASE and PT_GETGSBASE.
8008         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8009         PT_SETGSBASE.
8010         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8011         segment base registers.
8012         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8013
8014 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8015
8016         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8017         Update calls to i386_target_description to add 'segments'
8018         parameter.
8019         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8020         add segment base registers.
8021         * arch/i386.c (i386_create_target_description): Add 'segments'
8022         parameter to enable segment base registers.
8023         * arch/i386.h (i386_create_target_description): Likewise.
8024         * features/i386/32bit-segments.xml: New file.
8025         * features/i386/32bit-segments.c: Generate.
8026         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8027         call to i386_target_description to add 'segments' parameter.
8028         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8029         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8030         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8031         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8032         if feature is present.
8033         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8034         Add 'segments' parameter to call to i386_target_description.
8035         (i386_target_description): Add 'segments' parameter to enable
8036         segment base registers.
8037         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8038         to call to i386_target_description.
8039         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8040         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8041         Define I386_NUM_REGS.
8042         (i386_target_description): Add 'segments' parameter to enable
8043         segment base registers.
8044
8045 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8046
8047         PR/24325
8048         * source-cache.c: #undef open and close, to avoid unresolved
8049         externals during linking.
8050
8051 2019-03-12  Tom Tromey  <tromey@adacore.com>
8052
8053         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8054         const.  Add initializers.
8055         (_initialize_remote): Don't initialize ptid globals.
8056
8057 2019-03-12  Pedro Alves  <palves@redhat.com>
8058
8059         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8060
8061 2019-03-12  Pedro Alves  <palves@redhat.com>
8062
8063         * cp-name-parser.y (main): Remove unused 'len' variable.
8064
8065 2019-03-12  Tom Tromey  <tromey@adacore.com>
8066
8067         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8068         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8069
8070 2019-03-12  Tom Tromey  <tromey@adacore.com>
8071
8072         * linux-nat.c (iterate_over_lwps): Update.
8073         (stop_callback): Remove parameter.
8074         (stop_wait_callback, detach_callback, resume_set_callback)
8075         (select_singlestep_lwp_callback, set_ignore_sigint)
8076         (status_callback, resumed_callback, resume_clear_callback)
8077         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8078         data parameter.
8079         (linux_nat_target::detach, linux_nat_target::resume)
8080         (linux_stop_and_wait_all_lwps, select_event_lwp)
8081         (linux_nat_filter_event, linux_nat_wait_1)
8082         (linux_nat_target::kill, linux_nat_target::stop)
8083         (linux_nat_target::stop): Update.
8084         (linux_nat_resume_callback): Change type.
8085         (resume_stopped_resumed_lwps, count_events_callback)
8086         (select_event_lwp_callback): Likewise.
8087         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8088         * arm-linux-nat.c (struct update_registers_data): Remove.
8089         (update_registers_callback): Change type.
8090         (arm_linux_insert_hw_breakpoint1): Update.
8091         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8092         parameter.
8093         (x86_linux_dr_set_addr): Update.
8094         (x86_linux_dr_set_control): Update.
8095         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8096         (iterate_over_lwps): Use gdb::function_view.
8097         * nat/aarch64-linux-hw-point.c (struct
8098         aarch64_dr_update_callback_param): Remove.
8099         (debug_reg_change_callback): Change type.
8100         (aarch64_notify_debug_reg_change): Update.
8101         * s390-linux-nat.c (s390_refresh_per_info): Update.
8102
8103 2019-03-11  Tom Tromey  <tromey@adacore.com>
8104
8105         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8106         redundant assignment to "this_cu".
8107
8108 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8109
8110         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8111
8112 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8113
8114         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8115         from...
8116         (rank_one_type): ... this.
8117
8118 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8119
8120         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8121         from...
8122         (rank_one_type): ... this.
8123
8124 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8125
8126         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8127         from...
8128         (rank_one_type): ... this.
8129
8130 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8131
8132         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8133         from...
8134         (rank_one_type): ... this.
8135
8136 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8137
8138         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8139         from...
8140         (rank_one_type): ... this.
8141
8142 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8143
8144         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8145         from...
8146         (rank_one_type): ... this.
8147
8148 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8149
8150         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8151         from...
8152         (rank_one_type): ... this.
8153
8154 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8155
8156         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8157         from...
8158         (rank_one_type): ... this.
8159
8160 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8161
8162         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8163         from...
8164         (rank_one_type): ... this.
8165
8166 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8167
8168         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8169         from...
8170         (rank_one_type): ... this.
8171
8172 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8173
8174         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8175         from...
8176         (rank_one_type): ... this.
8177
8178 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8179
8180         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8181         from...
8182         (rank_one_type): ... this.
8183
8184 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8185
8186         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8187         inferior-events' shows the example events.
8188
8189 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8190
8191         Support styling on native MS-Windows console
8192
8193         PR/24315
8194         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8195         on MS-Windows if $TERM is not defined.
8196
8197         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8198
8199         * posix-hdep.c (gdb_console_fputs):
8200         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8201         functions.
8202         * ui-file.h (gdb_console_fputs): Add prototype.
8203
8204         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8205         back to fputs only if the former returns zero.
8206
8207 2019-03-07  Tom Tromey  <tom@tromey.com>
8208
8209         * symmisc.c (print_symbol_bcache_statistics): Update.
8210         (print_objfile_statistics): Update.
8211         * symfile.c (allocate_symtab): Update.
8212         * stabsread.c: Don't include bcache.h.
8213         * psymtab.h (struct psymbol_bcache): Don't declare.
8214         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8215         (psymbol_bcache_init, psymbol_bcache_free)
8216         (psymbol_bcache_get_bcache): Don't declare.
8217         * psymtab.c (struct psymbol_bcache): Remove.
8218         (psymtab_storage::psymtab_storage): Update.
8219         (psymtab_storage::~psymtab_storage): Update.
8220         (psymbol_bcache_init, psymbol_bcache_free)
8221         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8222         (add_psymbol_to_bcache): Update.
8223         (allocate_psymtab): Update.
8224         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8225         macro_cache>: No longer pointers.
8226         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8227         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8228         * macrotab.c (macro_bcache): Update.
8229         * macroexp.c: Don't include bcache.h.
8230         * gdbtypes.c (check_types_worklist): Update.
8231         (types_deeply_equal): Remove TRY/CATCH.  Update.
8232         * elfread.c (elf_symtab_read): Update.
8233         * dwarf2read.c: Don't include bcache.h.
8234         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8235         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8236         (print_bcache_statistics, bcache_memory_used): Don't declare.
8237         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8238         methods.  Rename all data members.
8239         * bcache.c (struct bcache): Move to bcache.h.
8240         (bcache::expand_hash_table): Rename from expand_hash_table.
8241         (bcache): Remove.
8242         (bcache::insert): Rename from bcache_full.
8243         (bcache::compare): Rename from bcache_compare.
8244         (bcache_xmalloc): Remove.
8245         (bcache::~bcache): Rename from bcache_xfree.
8246         (bcache::print_statistics): Rename from print_bcache_statistics.
8247         (bcache::memory_used): Rename from bcache_memory_used.
8248
8249 2019-03-07  Pedro Alves  <palves@redhat.com>
8250
8251         * infrun.c (normal_stop): Also check for
8252         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8253
8254 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8255
8256         * f-lang.c (value_from_host_double): Moved to...
8257         * value.c (value_from_host_double): ...here.
8258         * value.h (value_from_host_double): Declare.
8259         * guile/scm-math.c (vlscm_convert_typed_number): Use
8260         value_from_host_double.
8261         (vlscm_convert_number): Likewise.
8262         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8263         * python/py-value.c (convert_value_from_python): Likewise.
8264
8265 2019-03-06  Tom Tromey  <tom@tromey.com>
8266
8267         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8268
8269 2019-03-06  Tom Tromey  <tom@tromey.com>
8270
8271         * utils.h (free_current_contents): Don't declare.
8272         * utils.c (free_current_contents): Remove.
8273
8274 2019-03-06  Tom Tromey  <tom@tromey.com>
8275
8276         * top.c (quit_force): Update.
8277         * main.c (captured_command_loop): Update.
8278         * common/new-op.c (operator new): Update.
8279         * common/common-exceptions.c (struct catcher)
8280         <save_cleanup_chain>: Remove member.
8281         (exceptions_state_mc_init): Update.
8282         (exception_try_scope_entry): Return nullptr.
8283         (exception_try_scope_exit, exception_rethrow)
8284         (throw_exception_sjlj, throw_exception_cxx): Update.
8285         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8286         (all_cleanups, do_cleanups, discard_cleanups)
8287         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8288         (restore_cleanups, restore_final_cleanups): Don't declare.
8289         (do_final_cleanups): Remove parameter.
8290         * common/cleanups.c (cleanup_chain, make_cleanup)
8291         (make_cleanup_dtor, all_cleanups, do_cleanups)
8292         (discard_my_cleanups, discard_cleanups)
8293         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8294         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8295         (null_cleanup): Remove.
8296         (do_final_cleanups): Remove parameter.
8297
8298 2019-03-06  Tom Tromey  <tom@tromey.com>
8299
8300         * remote.c (remote_target::remote_parse_stop_reply): Use
8301         unique_xmalloc_ptr.
8302
8303 2019-03-06  Tom Tromey  <tom@tromey.com>
8304
8305         * stabsread.c (struct stabs_field_info): Rename from field_info.
8306         <list, fnlist>: Add initializers.
8307         <obstack>: New member.
8308         (read_member_functions, read_struct_fields, read_baseclasses):
8309         Allocate on obstack.  Don't use cleanups.
8310         (read_one_struct_field, read_member_functions, read_struct_fields)
8311         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8312         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8313         (read_struct_type): Update.
8314
8315 2019-03-06  Tom Tromey  <tom@tromey.com>
8316
8317         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8318         * common/filestuff.h (make_cleanup_close): Don't declare.
8319         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8320         Remove.
8321
8322 2019-03-06  Tom Tromey  <tom@tromey.com>
8323
8324         * solib-aix.c: Use make_scope_exit.
8325
8326 2019-03-06  Tom Tromey  <tom@tromey.com>
8327
8328         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8329         Use make_scope_exit.
8330
8331 2019-03-06  Tom Tromey  <tom@tromey.com>
8332
8333         * solib-svr4.c (disable_probes_interface): Remove parameter.
8334         (svr4_handle_solib_event): Use make_scope_exit.
8335
8336 2019-03-06  Tom Tromey  <tom@tromey.com>
8337
8338         * remote.c (struct stop_reply_deleter): Remove.
8339         (stop_reply_up): Update.
8340         (struct stop_reply): Derive from notif_event.  Don't typedef.
8341         <regcache>: Now a std::vector.
8342         (stop_reply_xfree): Remove.
8343         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8344         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8345         (remote_target::discard_pending_stop_replies): Use delete.
8346         (remote_target::remote_parse_stop_reply): Update.
8347         (remote_target::process_stop_reply): Update.
8348         * remote-notif.h (struct notif_event): Add virtual destructor.
8349         Remove "dtr" member.
8350         (struct notif_client) <alloc_event>: Return a unique_ptr.
8351         (notif_event_xfree): Don't declare.
8352         (notif_event_up): New typedef.
8353         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8354         (notif_event_xfree, do_notif_event_xfree): Remove.
8355         (remote_notif_state_xfree): Update.
8356
8357 2019-03-06  Tom Tromey  <tom@tromey.com>
8358
8359         * infrun.c (displaced_step_clear_cleanup): Now a
8360         forward_scope_exit type.
8361         (displaced_step_prepare_throw): Update.
8362         (displaced_step_fixup): Update.
8363
8364 2019-03-06  Tom Tromey  <tom@tromey.com>
8365
8366         * inferior.h (class inferior): Update comment.
8367         * gdbthread.h (class thread_info): Update comment.
8368
8369 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8370             Tom Tromey  <tom@tromey.com>
8371
8372         * stabsread.h (struct stab_section_list): Remove.
8373         (coffstab_build_psymtabs): Update.
8374         * dbxread.c (symbuf_sections): Now a std::vector.
8375         (sect_idx): New global.
8376         (fill_symbuf): Update.
8377         (coffstab_build_psymtabs): Change type of stabsects parameter.
8378         Update.
8379         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8380         std::vector.
8381         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8382         (coff_locate_sections): Update.
8383         (coff_symfile_read): Remove cleanups.  Update.
8384         (init_stringtab): Add storage parameter.
8385         (free_stringtab, free_stringtab_cleanup): Remove.
8386         (init_lineno): Add storage parameter.
8387         (free_linetab, free_linetab_cleanup): Remove.
8388
8389 2019-03-06  Pedro Alves  <palves@redhat.com>
8390
8391         * linux-fork.c (fork_info::clobber_regs): Delete.
8392         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8393         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8394         comment.  Adjust.
8395         (scoped_switch_fork_info::scoped_switch_fork_info)
8396         (checkpoint_command, linux_fork_context): Adjust
8397         fork_save_infrun_state calls.
8398
8399 2019-03-06  Pedro Alves  <palves@redhat.com>
8400
8401         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8402         (inf_has_multiple_threads): Return 'bool' and rewrite using
8403         inferior_info::threads().
8404
8405 2019-03-06  Pedro Alves  <palves@redhat.com>
8406
8407         * linux-fork.c: Include <list>.
8408         (fork_list): Now a std::list instance.
8409         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8410         (forks_exist_p, find_last_fork): Adjust.
8411         (new_fork): Delete.
8412         (one_fork_p): New.
8413         (add_fork): Adjust.
8414         (free_fork): Delete, folded into fork_info::~fork_info().
8415         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8416         Adjust.
8417         (init_fork_list): Delete.
8418         (linux_fork_killall, linux_fork_mourn_inferior)
8419         (linux_fork_detach, info_checkpoints_command): Adjust.
8420         (_initialize_linux_fork): No longer call init_fork_list.
8421
8422 2019-03-06  Pedro Alves  <palves@redhat.com>
8423
8424         * linux-fork.c (new_fork): New, split out of ...
8425         (add_fork): ... this.  Return void.  Move "first fork" special
8426         case from here, to ...
8427         (checkpoint_command): ... here.
8428         * linux-linux.h (add_fork): Return void.
8429
8430 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8431
8432         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8433
8434 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8435             Chris January  <chris.january@arm.com>
8436             David Lecomber  <david.lecomber@arm.com>
8437
8438         * f-exp.y: New token, UNOP_INTRINSIC.
8439         (exp): New pattern using UNOP_INTRINSIC token.
8440         (f77_keywords): Add 'abs' keyword.
8441         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8442         (value_from_host_double): New function.
8443         (evaluate_subexp_f): Support UNOP_ABS.
8444
8445 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8446
8447         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8448         types.
8449
8450 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8451
8452         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8453         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8454         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8455
8456 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8457
8458         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8459
8460 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8461             Chris January  <chris.january@arm.com>
8462
8463         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8464         * f-exp.y: Define 'KIND' token.
8465         (exp): New pattern for KIND expressions.
8466         (ptype): Handle types with a kind extension.
8467         (direct_abs_decl): Extend to spot kind extensions.
8468         (f77_keywords): Add 'kind' to the list.
8469         (push_kind_type): New function.
8470         (convert_to_kind_type): New function.
8471         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8472         * parse.c (operator_length_standard): Likewise.
8473         * parser-defs.h (enum type_pieces): Add tp_kind.
8474         * std-operator.def: Add UNOP_KIND.
8475
8476 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8477
8478         * f-exp.y (f_parse): Set yydebug.
8479
8480 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8481
8482         * f-lang.c (evaluate_subexp_f): New function.
8483         (exp_descriptor_f): New global.
8484         (f_language_defn): Use exp_descriptor_f instead of
8485         exp_descriptor_standard.
8486
8487 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8488
8489         * f-exp.y (struct token): Add comments.
8490         (dot_ops): Remove uppercase versions and the end marker.
8491         (f77_keywords): Likewise.
8492         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8493         entries in the dot_ops array are case insensitive, and use
8494         strncasecmp to compare strings.  Also some whitespace cleanup in
8495         this area.  Similar for the f77_keywords array, except entries in
8496         this list might be case sensitive.
8497
8498 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8499
8500         * f-exp.y (struct f77_boolean_val): Add comments.
8501         (boolean_values): Remove uppercase versions, and end marker.
8502         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8503         and use strncasecmp to achieve case insensitivity.  Additionally,
8504         perform whitespace cleanup around this code.
8505
8506 2019-03-06  Tom Tromey  <tromey@adacore.com>
8507
8508         * remote-sim.c (gdbsim_target_open): Use result of
8509         gdb_argv::release.
8510
8511 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8512         Dirk Schubert  <dirk.schubert@arm.com>
8513         Chris January  <chris.january@arm.com>
8514
8515         * eval.c (evaluate_subexp_standard): Call Fortran argument
8516         wrapping logic.
8517         * f-lang.c (struct value): A value which can be passed into a
8518         Fortran function call.
8519         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8520         where appropriate.
8521         (struct type): Value ready for a Fortran function call.
8522         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8523         is needed.
8524         * f-lang.h (fortran_argument_convert): Declaration.
8525         (fortran_preserve_arg_pointer): Declaration.
8526         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8527
8528 2019-03-05  Tom Tromey  <tromey@adacore.com>
8529
8530         * python/py-prettyprint.c (print_string_repr): Remove #if.
8531         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8532
8533 2019-03-05  Tom Tromey  <tromey@adacore.com>
8534
8535         * target.c (the_dummy_target): Move later.  Change type to
8536         "dummy_target".
8537         (initialize_targets): Don't initialize the_dummy_target.
8538
8539 2019-03-05  Tom Tromey  <tromey@adacore.com>
8540
8541         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8542         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8543
8544 2019-03-05  Tom Tromey  <tromey@adacore.com>
8545
8546         * windows-nat.c (windows_nat_target::attach)
8547         (windows_nat_target::detach): Don't call gdb_flush.
8548         * valprint.c (generic_val_print, val_print, val_print_string):
8549         Don't call gdb_flush.
8550         * utils.c (defaulted_query): Don't call gdb_flush.
8551         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8552         * target.c (target_announce_detach): Don't call gdb_flush.
8553         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8554         * remote.c (extended_remote_target::attach): Don't call
8555         gdb_flush.
8556         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8557         * printcmd.c (do_examine): Don't call gdb_flush.
8558         (info_display_command): Don't call gdb_flush.
8559         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8560         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8561         * memattr.c (info_mem_command): Don't call gdb_flush.
8562         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8563         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8564         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8565         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8566         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8567         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8568         (gnu_nat_target::detach): Don't call gdb_flush.
8569         * f-valprint.c (f_val_print): Don't call gdb_flush.
8570         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8571         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8572         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8573         gdb_flush.
8574         * c-valprint.c (c_val_print): Don't call gdb_flush.
8575         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8576
8577 2019-03-05  Tom Tromey  <tromey@adacore.com>
8578
8579         * varobj.c (update_dynamic_varobj_children): Update.
8580         (install_default_visualizer): Use reset, not release.
8581         * value.c (set_internalvar): Update.
8582         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8583         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8584         ATTRIBUTE_UNUSED_RESULT.
8585
8586 2019-03-05  Tom Tromey  <tromey@adacore.com>
8587
8588         * remote.c (class scoped_remote_fd) <release>: Add
8589         ATTRIBUTE_UNUSED_RESULT.
8590
8591 2019-03-05  Tom Tromey  <tromey@adacore.com>
8592
8593         * macroexp.c (struct macro_buffer) <release>: Add
8594         ATTRIBUTE_UNUSED_RESULT.
8595
8596 2019-03-05  Tom Tromey  <tromey@adacore.com>
8597
8598         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8599         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8600         ATTRIBUTE_UNUSED_RESULT.
8601
8602 2019-03-05  Tom Tromey  <tromey@adacore.com>
8603
8604         * common/scoped_fd.h (class scoped_fd) <release>: Add
8605         ATTRIBUTE_UNUSED_RESULT.
8606
8607 2019-03-05  Tom Tromey  <tromey@adacore.com>
8608
8609         * parser-defs.h (struct parser_state) <release>: Add
8610         ATTRIBUTE_UNUSED_RESULT.
8611
8612 2019-03-05  Tom Tromey  <tromey@adacore.com>
8613
8614         * utils.h (class gdb_argv) <release>: Add
8615         ATTRIBUTE_UNUSED_RESULT.
8616         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8617
8618 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8619
8620         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8621         for-loop range, to avoid compiler warnings.
8622
8623         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8624         avoid compiler warnings about unused variables.
8625
8626         * NEWS: Mention end of support for native debugging on MS-Windows
8627         before XP.
8628
8629         PR gdb/24292
8630         * common/netstuff.c:
8631         * gdbserver/gdbreplay.c
8632         * gdbserver/remote-utils.c:
8633         * ser-tcp.c:
8634         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8635         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8636         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8637         'getaddrinfo' and 'freeaddrinfo' were not available before
8638         Windows XP, and mingw.org's MinGW headers by default define
8639         _WIN32_WINNT to 0x500.
8640
8641 2019-03-01  Gary Benson <gbenson@redhat.com>
8642
8643         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8644
8645 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8646             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8647
8648         PR gdb/8527
8649         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8650         set_sigint_trap, clear_sigint_trap.
8651
8652 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8653
8654         * target.c (target_detach): Clear the regcache and the
8655         frame cache.
8656
8657 2019-02-27  Pedro Alves  <palves@redhat.com>
8658
8659         * utils.c (set_screen_size): When we cap the height/width sizes,
8660         tweak the corresponding command variable to show "unlimited":
8661
8662 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8663             Pedro Alves  <palves@redhat.com>
8664
8665         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8666         before calling rl_set_screen_size.
8667
8668 2019-02-27  Tom Tromey  <tromey@adacore.com>
8669
8670         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8671         define.
8672         * python/py-value.c: Remove Python 2.4 workaround.
8673         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8674         workaround.
8675         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8676         Python 2.4 workaround.
8677         * python/python-internal.h: Remove Python 2.4 comment.
8678         (Py_ssize_t): Don't define.
8679         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8680         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8681         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8682         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8683         * python/python.c (do_start_initialization): Remove Python 2.4
8684         workaround.
8685         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8686         (print_children): Remove Python 2.4 workaround.
8687         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8688         workaround.
8689         (CHARBUFFERPROC_NAME): Remove.
8690         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8691         Python 2.4 workaround.
8692
8693 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8694
8695         * NEWS: Note minimum Python version.
8696
8697 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8698
8699         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8700         code from these functions.  Remove corresponding ifdefs.  Use
8701         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8702         Remove gotos and target of gotos.
8703         (infpy_search_memory): Likewise.
8704
8705 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8706
8707         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8708         (hppa_gdbarch_init): Don't register deleted functions with
8709         gdbarch.
8710
8711 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8712
8713         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8714         (h8300_unwind_sp): Delete.
8715         (h8300_dummy_id): Delete.
8716         (h8300_gdbarch_init): Don't register deleted functions with
8717         gdbarch.
8718
8719 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8720
8721         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8722         (ft32_unwind_pc): Delete.
8723         (ft32_unwind_sp): Delete.
8724         (ft32_gdbarch_init): Don't register deleted functions with
8725         gdbarch.
8726
8727 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8728
8729         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8730         (frv_unwind_pc): Delete.
8731         (frv_unwind_sp): Delete.
8732         (frv_gdbarch_init): Don't register deleted functions with
8733         gdbarch.
8734
8735 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8736
8737         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8738         (riscv_unwind_pc): Delete.
8739         (riscv_unwind_sp): Delete.
8740         (riscv_gdbarch_init): Don't register deleted functions with
8741         gdbarch.
8742
8743 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8744
8745         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8746         (csky_unwind_pc): Delete.
8747         (csky_unwind_sp): Delete.
8748         (csky_gdbarch_init): Don't register deleted functions with
8749         gdbarch.
8750
8751 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8752
8753         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8754         (cris_unwind_pc): Delete.
8755         (cris_unwind_sp): Delete.
8756         (cris_gdbarch_init): Don't register deleted functions with
8757         gdbarch.
8758
8759 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8760
8761         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8762         (bfin_unwind_pc): Delete.
8763         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8764
8765 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8766
8767         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8768         (arm_unwind_pc): Delete.
8769         (arm_unwind_sp): Delete.
8770         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8771
8772 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8773
8774         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8775         (arc_unwind_pc): Delete.
8776         (arc_unwind_sp): Delete.
8777         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8778
8779 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8780
8781         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8782         (alpha_unwind_pc): Delete.
8783         (alpha_gdbarch_init): Don't register deleted functions with
8784         gdbarch.
8785
8786 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8787
8788         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8789         (aarch64_unwind_pc): Delete.
8790         (aarch64_unwind_sp): Delete.
8791         (aarch64_gdbarch_init): Don't register deleted functions with
8792         gdbarch.
8793
8794 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8795
8796         * gdbtypes.c (type_align): Don't consider static members when
8797         computing structure alignment.
8798
8799 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8800
8801         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8802         return 0 for other types.
8803         * arch-utils.c (default_type_align): Always return 0.
8804         * gdbarch.h: Regenerate.
8805         * gdbarch.sh (type_align): Extend comment.
8806         * gdbtypes.c (type_align): Add additional comments, always call
8807         gdbarch_type_align before applying the default rules.
8808         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8809         generic code will then apply a suitable default.
8810         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8811         types, return 0 for other types.
8812
8813 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8814
8815         * NEWS: Create a new section for the next release branch.
8816         Rename the section of the current branch, now that it has
8817         been cut.
8818
8819 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8820
8821         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8822         * version.in: Bump version to 8.3.50.DATE-git.
8823
8824 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8825
8826         * aix-thread.c (ptid_cmp): Remove unused variable.
8827         (get_signaled_thread): Likewise.
8828         (store_regs_user_thread): Likewise.
8829         (store_regs_kernel_thread): Likewise.
8830         (fetch_regs_kernel_thread): Remove shadowed variable.
8831
8832 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8833
8834         * features/riscv/32bit-cpu.xml: Add register numbers.
8835         * features/riscv/32bit-fpu.c: Regenerate.
8836         * features/riscv/32bit-fpu.xml: Add register numbers.
8837         * features/riscv/64bit-cpu.xml: Add register numbers.
8838         * features/riscv/64bit-fpu.c: Regenerate.
8839         * features/riscv/64bit-fpu.xml: Add register numbers.
8840
8841 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8842
8843         * NEWS: Mention two argument form of gdb.Value constructor.
8844         * python/py-value.c (convert_buffer_and_type_to_value): New
8845         function.
8846         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8847         Add support for handling an optional second argument.  Call
8848         convert_buffer_and_type_to_value as appropriate.
8849         * python/python-internal.h (Py_buffer_deleter): New struct.
8850         (Py_buffer_up): New typedef.
8851
8852 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8853
8854         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8855         instead of releasing ownership.
8856
8857 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8858
8859         * dwarf2read.c (open_and_init_dwp_file): Call
8860         elf_numsections instead of bfd_count_sections to initialize
8861         dwp_file->num_sections.
8862
8863 2019-02-25  Tom Tromey  <tromey@adacore.com>
8864
8865         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8866
8867 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8868
8869         * gcore.in: Add '--readnever' option when invoking GDB.
8870
8871 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8872
8873         * MAINTAINERS: Update my email address.
8874
8875 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8876
8877         * build-id.c (build_id_to_debug_bfd_1): New function.
8878         (build_id_to_debug_bfd): Look for separate debug file in
8879         sysroot.
8880
8881 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8882
8883         * gdbarch.sh: Update the copyright year range that is placed into
8884         generated files.
8885
8886 2019-02-22  Keith Seitz  <keiths@redhat.com>
8887
8888         PR symtab/23853
8889         * linespec.c (create_sals_line_offset): Search for the default
8890         symtab's filename instead of its fullname.
8891
8892 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8893
8894         * NEWS: Update style defaults.
8895
8896 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8897
8898         * main.c (captured_main_1): Disable styling in batch mode.
8899
8900 2019-02-20  Tom Tromey  <tom@tromey.com>
8901
8902         * symtab.c (symtab_symbol_info): Fix typos.
8903
8904 2019-02-20  Tom Tromey  <tromey@adacore.com>
8905
8906         * findcmd.c (_initialize_mem_search): Use upper case for
8907         metasyntactic variables.
8908
8909 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8910
8911         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8912         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8913
8914 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8915
8916         * top.h (source_file_name): Change to std::string.
8917         * top.c (source_file_name): Likewise.
8918         (command_line_input): Adjust.
8919         * cli/cli-script.c (script_from_file): Adjust.
8920
8921 2019-02-19  Tom Tromey  <tromey@adacore.com>
8922
8923         * ravenscar-thread.c
8924         (ravenscar_thread_target::update_thread_list): Don't call
8925         ada_build_task_list.
8926         * ada-lang.h (ada_build_task_list): Don't declare.
8927         * ada-tasks.c (struct ada_tasks_inferior_data)
8928         <task_list_valid_p>: Now bool.
8929         (read_known_tasks, ada_task_list_changed)
8930         (ada_tasks_invalidate_inferior_data): Update.
8931         (read_known_tasks_array): Return bool.
8932         (read_known_tasks_list): Likewise.
8933         (read_known_tasks): Return void.
8934         (ada_build_task_list): Now static.
8935
8936 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8937
8938         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8939         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8940
8941 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8942
8943         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8944         variant for ada_tasks_pspace_data_handle and
8945         ada_tasks_inferior_data_handle.
8946         (ada_tasks_pspace_data_cleanup): New function.
8947         (ada_tasks_inferior_data_cleanup): New function.
8948
8949 2019-02-17  Tom Tromey  <tom@tromey.com>
8950
8951         * macrotab.h (macro_source_fullname): Return a std::string.
8952         * macrotab.c (macro_include, check_for_redefinition)
8953         (macro_undef, macro_lookup_definition, foreach_macro)
8954         (foreach_macro_in_scope): Update.
8955         (macro_source_fullname): Return a std::string.
8956         * macrocmd.c (show_pp_source_pos): Update.
8957
8958 2019-02-17  Tom Tromey  <tom@tromey.com>
8959
8960         * macrocmd.c (show_pp_source_pos): Style the file names.
8961
8962 2019-02-17  Tom Tromey  <tom@tromey.com>
8963
8964         PR tui/24197:
8965         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8966
8967 2019-02-17  Tom Tromey  <tom@tromey.com>
8968
8969         * ada-lang.c (user_select_syms): Use filtered printing.
8970         * utils.c (wrap_style): New global.
8971         (desired_style): Remove.
8972         (emit_style_escape): Add stream parameter.
8973         (set_output_style, reset_terminal_style, prompt_for_continue):
8974         Update.
8975         (flush_wrap_buffer): Only flush gdb_stdout.
8976         (wrap_here): Set wrap_style.
8977         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8978         treat escape sequences as a character.  Change when wrap buffer is
8979         flushed.
8980         (fputs_styled): Do not set the output style when the default is
8981         requested.
8982         * ui-style.h (struct ui_file_style) <is_default>: New method.
8983         * source.c (print_source_lines_base): Emit escape sequences in one
8984         piece.
8985
8986 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8987
8988         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8989         integers and enumeration types.
8990
8991 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8992
8993         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8994         instead of lookup_symbol_in_language
8995         (do_exact_match): New function.
8996         (ada_get_symbol_name_matcher): Return do_exact_match when
8997         doing a verbatim match.
8998
8999 2019-02-15  Tom Tromey  <tromey@adacore.com>
9000
9001         * ravenscar-thread.c (ravenscar_thread_target::resume)
9002         (ravenscar_thread_target::wait): Special case wildcard requests.
9003
9004 2019-02-15  Tom Tromey  <tromey@adacore.com>
9005
9006         * ravenscar-thread.c (base_ptid): Remove.
9007         (struct ravenscar_thread_target) <close>: New method.
9008         <m_base_ptid>: New member.
9009         <update_inferior_ptid, active_task, task_is_currently_active,
9010         runtime_initialized>: Declare methods.
9011         <ravenscar_thread_target>: Add constructor.
9012         (ravenscar_thread_target::task_is_currently_active)
9013         (ravenscar_thread_target::update_inferior_ptid)
9014         (ravenscar_runtime_initialized): Rename.  Now methods.
9015         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9016         (ravenscar_thread_target::update_thread_list): Update.
9017         (ravenscar_thread_target::active_task): Now method.
9018         (ravenscar_thread_target::store_registers)
9019         (ravenscar_thread_target::prepare_to_store)
9020         (ravenscar_thread_target::prepare_to_store)
9021         (ravenscar_thread_target::mourn_inferior): Update.
9022         (ravenscar_inferior_created): Use "new" to create target.
9023         (ravenscar_thread_target::get_ada_task_ptid): Update.
9024         (_initialize_ravenscar): Don't initialize base_ptid.
9025         (ravenscar_ops): Remove global.
9026
9027 2019-02-15  Tom Tromey  <tromey@adacore.com>
9028
9029         * target.h (push_target): Declare new overload.
9030         * target.c (push_target): New overload, taking an rvalue reference.
9031         * remote.c (remote_target::open_1): Use push_target overload.
9032         * corelow.c (core_target_open): Use push_target overload.
9033
9034 2019-02-15  Tom Tromey  <tromey@adacore.com>
9035
9036         * ravenscar-thread.c (is_ravenscar_task)
9037         (ravenscar_task_is_currently_active): Return bool.
9038         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9039         (_initialize_ravenscar): Remove "(void)".
9040         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9041         Return bool.
9042
9043 2019-02-15  Tom Tromey  <tromey@adacore.com>
9044
9045         * ravenscar-thread.c (ravenscar_runtime_initializer)
9046         (has_ravenscar_runtime, get_running_thread_id)
9047         (ravenscar_thread_target::resume): Fix indentation.
9048
9049 2019-02-15  Tom Tromey  <tromey@adacore.com>
9050
9051         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9052         from ravenscar_arch_ops.
9053         (sparc_ravenscar_ops::fetch_registers)
9054         (sparc_ravenscar_ops::store_registers): Now methods.
9055         (sparc_ravenscar_prepare_to_store): Remove.
9056         (sparc_ravenscar_ops): Redefine.
9057         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9058         methods and destructor.  Remove members.
9059         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9060         (ravenscar_thread_target::store_registers)
9061         (ravenscar_thread_target::prepare_to_store): Update.
9062         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9063         Remove.
9064         (struct ppc_ravenscar_powerpc_ops): Derive from
9065         ravenscar_arch_ops.
9066         (ppc_ravenscar_powerpc_ops::fetch_registers)
9067         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9068         (ppc_ravenscar_powerpc_ops): Redefine.
9069         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9070         (ppc_ravenscar_e500_ops::fetch_registers)
9071         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9072         (ppc_ravenscar_e500_ops): Redefine.
9073         * aarch64-ravenscar-thread.c
9074         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9075         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9076         (aarch64_ravenscar_fetch_registers)
9077         (aarch64_ravenscar_store_registers): Now methods.
9078         (aarch64_ravenscar_ops): Redefine.
9079
9080 2019-02-15  Tom Tromey  <tromey@adacore.com>
9081
9082         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9083         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9084         (ravenscar_thread_target::stopped_by_watchpoint)
9085         (ravenscar_thread_target::stopped_data_address)
9086         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9087
9088 2019-02-15  Tom Tromey  <tromey@adacore.com>
9089
9090         * ravenscar-thread.c: Fix some typos.
9091
9092 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9093             Tom Tromey  <tromey@adacore.com>
9094
9095         * ada-lang.c (ada_exception_sal): Change addr_string to a
9096         std::string.
9097         (create_ada_exception_catchpoint): Update.
9098
9099 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9100             Tom Tromey  <tromey@adacore.com>
9101
9102         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9103         (bp_location_ops): Remove.
9104         (base_breakpoint_allocate_location): Update.
9105         (free_bp_location): Update.
9106         * ada-lang.c (class ada_catchpoint_location)
9107         <ada_catchpoint_location>: Remove ops parameter.
9108         (ada_catchpoint_location_dtor): Remove.
9109         (ada_catchpoint_location_ops): Remove.
9110         (allocate_location_exception): Update.
9111         * breakpoint.h (struct bp_location_ops): Remove.
9112         (class bp_location) <bp_location>: Remove bp_location_ops
9113         parameter.
9114         <~bp_location>: Add destructor.
9115         <ops>: Remove.
9116
9117 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9118             Pedro Alves  <palves@redhat.com>
9119
9120         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9121         'PATH_MAX'.
9122
9123 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9124             Samuel Thibault  <samuel.thibault@gnu.org>
9125             Thomas Schwinge  <thomas@codesourcery.com>
9126
9127         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9128         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9129
9130 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9131
9132         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9133         (check_empty): Use "const char *".
9134
9135         * gnu-nat.c (gnu_nat_target::detach): Instead of
9136         'detach_inferior (pid)' call
9137         'detach_inferior (find_inferior_pid (pid))'.
9138
9139         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9140         'nat/fork-inferior.o'.
9141         * gnu-nat.c: #include "nat/fork-inferior.h".
9142
9143         * gnu-nat.c (gnu_nat_target::detach): Instead of
9144         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9145         * gnu-nat.h: #include "inf-child.h".
9146         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9147         'i386_gnu_nat_target::fetch_registers'.
9148         (gnu_store_registers): Rename/move to
9149         'i386_gnu_nat_target::store_registers'.
9150
9151         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9152         * gnu-nat.h (mach_thread_info): New function.
9153         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9154
9155         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9156
9157 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9158
9159         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9160
9161 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9162
9163         * windows-nat.c (windows_add_thread): Add new parameter
9164         "main_thread_p" with default value set to false.  Update
9165         function documentation as well as all callers.
9166         (windows_delete_thread): Likewise.
9167         (fake_create_process): Update call to windows_add_thread.
9168         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9169         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9170         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9171         call to windows_delete_thread.
9172
9173 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9174
9175         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9176
9177 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9178
9179         * symfile.c (find_separate_debug_file): Use canonical path of
9180         sysroot with child_path instead of gdb_sysroot if it is valid.
9181
9182 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9183
9184         * symfile.c (find_separate_debug_file): Use child_path to
9185         determine if an object file is under a sysroot.
9186
9187 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9188
9189         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9190         unittests/child-path-selftests.c.
9191         * common/pathstuff.c (child_path): New function.
9192         * common/pathstuff.h (child_path): New prototype.
9193         * unittests/child-path-selftests.c: New file.
9194
9195 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9196
9197         * symfile.c (find_separate_debug_file): Look for separate debug
9198         files in debug directories under the sysroot.
9199
9200 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9201
9202         * symtab.h (struct minimal_symbol data_p): New const method.
9203         (struct minimal_symbol text_p): Likewise.
9204         * symtab.c (output_source_filename): Use file name style
9205         to print file name.
9206         (print_symbol_info): Likewise.
9207         (print_msymbol_info): Use address style to print addresses.
9208         Use function name style to print executable text symbols.
9209         (expand_symtab_containing_pc): Use data_p.
9210         (find_pc_sect_compunit_symtab): Likewise.
9211
9212 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9213
9214         * breakpoint.c (describe_other_breakpoints): Use address style
9215         to print addresses.
9216         (say_where): Likewise.
9217
9218 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9219
9220         * ada-typeprint.c (print_func_type): Print function name
9221         style to print function name.
9222         * c-typeprint.c (c_print_type_1): Likewise.
9223
9224 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9225
9226         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9227         for execve.
9228
9229 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9230
9231         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9232         type_stack.
9233
9234 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9235
9236         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9237         TYPE_CODE_REF types.
9238
9239 2019-02-08  Jim Wilson  <jimw@sifive.com>
9240
9241         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9242         (riscv_linux_fregset): New.
9243         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9244
9245 2019-02-07  Tom Tromey  <tom@tromey.com>
9246
9247         * thread.c (thread_cancel_execution_command): Update.
9248         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9249         methods.
9250         (struct thread_fsm_ops): Remove.
9251         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9252         (thread_fsm_should_stop, thread_fsm_return_value)
9253         (thread_fsm_set_finished, thread_fsm_finished_p)
9254         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9255         Don't declare.
9256         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9257         * infrun.c (clear_proceed_status_thread)
9258         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9259         (print_stop_event): Update.
9260         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9261         Add constructor.
9262         (step_command_fsm_ops): Remove.
9263         (new_step_command_fsm): Remove.
9264         (step_1): Update.
9265         (step_command_fsm::should_stop): Rename from
9266         step_command_fsm_should_stop.
9267         (step_command_fsm::clean_up): Rename from
9268         step_command_fsm_clean_up.
9269         (step_command_fsm::do_async_reply_reason): Rename from
9270         step_command_fsm_async_reply_reason.
9271         (struct until_next_fsm): Inherit from thread_fsm.  Add
9272         constructor.
9273         (until_next_fsm_ops): Remove.
9274         (new_until_next_fsm): Remove.
9275         (until_next_fsm::should_stop): Rename from
9276         until_next_fsm_should_stop.
9277         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9278         (until_next_fsm::do_async_reply_reason): Rename from
9279         until_next_fsm_async_reply_reason.
9280         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9281         constructor.  Change type of breakpoint.
9282         (finish_command_fsm_ops): Remove.
9283         (new_finish_command_fsm): Remove.
9284         (finish_command_fsm::should_stop): Rename from
9285         finish_command_fsm_should_stop.
9286         (finish_command_fsm::clean_up): Rename from
9287         finish_command_fsm_clean_up.
9288         (finish_command_fsm::return_value): Rename from
9289         finish_command_fsm_return_value.
9290         (finish_command_fsm::do_async_reply_reason): Rename from
9291         finish_command_fsm_async_reply_reason.
9292         (finish_command): Update.
9293         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9294         Add constructor.
9295         (call_thread_fsm_ops): Remove.
9296         (call_thread_fsm::call_thread_fsm): Rename from
9297         new_call_thread_fsm.
9298         (call_thread_fsm::should_stop): Rename from
9299         call_thread_fsm_should_stop.
9300         (call_thread_fsm::should_notify_stop): Rename from
9301         call_thread_fsm_should_notify_stop.
9302         (run_inferior_call, call_function_by_hand_dummy): Update.
9303         * cli/cli-interp.c (should_print_stop_to_console): Update.
9304         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9305         Add constructor.  Change type of location_breakpoint,
9306         caller_breakpoint.
9307         (until_break_fsm_ops): Remove.
9308         (new_until_break_fsm): Remove.
9309         (until_break_fsm::should_stop): Rename from
9310         until_break_fsm_should_stop.
9311         (until_break_fsm::clean_up): Rename from
9312         until_break_fsm_clean_up.
9313         (until_break_fsm::do_async_reply_reason): Rename from
9314         until_break_fsm_async_reply_reason.
9315         (until_break_command): Update.
9316         * thread-fsm.c: Remove.
9317         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9318
9319 2019-02-07  Tom Tromey  <tom@tromey.com>
9320
9321         * yy-remap.h: Add include guard.
9322         * xtensa-tdep.h: Add include guard.
9323         * xcoffread.h: Rename include guard.
9324         * varobj-iter.h: Add include guard.
9325         * tui/tui.h: Rename include guard.
9326         * tui/tui-winsource.h: Rename include guard.
9327         * tui/tui-wingeneral.h: Rename include guard.
9328         * tui/tui-windata.h: Rename include guard.
9329         * tui/tui-win.h: Rename include guard.
9330         * tui/tui-stack.h: Rename include guard.
9331         * tui/tui-source.h: Rename include guard.
9332         * tui/tui-regs.h: Rename include guard.
9333         * tui/tui-out.h: Rename include guard.
9334         * tui/tui-layout.h: Rename include guard.
9335         * tui/tui-io.h: Rename include guard.
9336         * tui/tui-hooks.h: Rename include guard.
9337         * tui/tui-file.h: Rename include guard.
9338         * tui/tui-disasm.h: Rename include guard.
9339         * tui/tui-data.h: Rename include guard.
9340         * tui/tui-command.h: Rename include guard.
9341         * tic6x-tdep.h: Add include guard.
9342         * target/waitstatus.h: Rename include guard.
9343         * target/wait.h: Rename include guard.
9344         * target/target.h: Rename include guard.
9345         * target/resume.h: Rename include guard.
9346         * target-float.h: Rename include guard.
9347         * stabsread.h: Add include guard.
9348         * rs6000-tdep.h: Add include guard.
9349         * riscv-fbsd-tdep.h: Add include guard.
9350         * regformats/regdef.h: Rename include guard.
9351         * record.h: Rename include guard.
9352         * python/python.h: Rename include guard.
9353         * python/python-internal.h: Rename include guard.
9354         * python/py-stopevent.h: Rename include guard.
9355         * python/py-ref.h: Rename include guard.
9356         * python/py-record.h: Rename include guard.
9357         * python/py-record-full.h: Rename include guard.
9358         * python/py-record-btrace.h: Rename include guard.
9359         * python/py-instruction.h: Rename include guard.
9360         * python/py-events.h: Rename include guard.
9361         * python/py-event.h: Rename include guard.
9362         * procfs.h: Add include guard.
9363         * proc-utils.h: Add include guard.
9364         * p-lang.h: Add include guard.
9365         * or1k-tdep.h: Rename include guard.
9366         * observable.h: Rename include guard.
9367         * nto-tdep.h: Rename include guard.
9368         * nat/x86-linux.h: Rename include guard.
9369         * nat/x86-linux-dregs.h: Rename include guard.
9370         * nat/x86-gcc-cpuid.h: Add include guard.
9371         * nat/x86-dregs.h: Rename include guard.
9372         * nat/x86-cpuid.h: Rename include guard.
9373         * nat/ppc-linux.h: Rename include guard.
9374         * nat/mips-linux-watch.h: Rename include guard.
9375         * nat/linux-waitpid.h: Rename include guard.
9376         * nat/linux-ptrace.h: Rename include guard.
9377         * nat/linux-procfs.h: Rename include guard.
9378         * nat/linux-osdata.h: Rename include guard.
9379         * nat/linux-nat.h: Rename include guard.
9380         * nat/linux-namespaces.h: Rename include guard.
9381         * nat/linux-btrace.h: Rename include guard.
9382         * nat/glibc_thread_db.h: Rename include guard.
9383         * nat/gdb_thread_db.h: Rename include guard.
9384         * nat/gdb_ptrace.h: Rename include guard.
9385         * nat/fork-inferior.h: Rename include guard.
9386         * nat/amd64-linux-siginfo.h: Rename include guard.
9387         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9388         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9389         * nat/aarch64-linux.h: Rename include guard.
9390         * nat/aarch64-linux-hw-point.h: Rename include guard.
9391         * mn10300-tdep.h: Add include guard.
9392         * mips-linux-tdep.h: Add include guard.
9393         * mi/mi-parse.h: Rename include guard.
9394         * mi/mi-out.h: Rename include guard.
9395         * mi/mi-main.h: Rename include guard.
9396         * mi/mi-interp.h: Rename include guard.
9397         * mi/mi-getopt.h: Rename include guard.
9398         * mi/mi-console.h: Rename include guard.
9399         * mi/mi-common.h: Rename include guard.
9400         * mi/mi-cmds.h: Rename include guard.
9401         * mi/mi-cmd-break.h: Rename include guard.
9402         * m2-lang.h: Add include guard.
9403         * location.h: Rename include guard.
9404         * linux-record.h: Rename include guard.
9405         * linux-nat.h: Add include guard.
9406         * linux-fork.h: Add include guard.
9407         * i386-darwin-tdep.h: Rename include guard.
9408         * hppa-linux-offsets.h: Add include guard.
9409         * guile/guile.h: Rename include guard.
9410         * guile/guile-internal.h: Rename include guard.
9411         * gnu-nat.h: Rename include guard.
9412         * gdb-stabs.h: Rename include guard.
9413         * frv-tdep.h: Add include guard.
9414         * f-lang.h: Add include guard.
9415         * event-loop.h: Add include guard.
9416         * darwin-nat.h: Rename include guard.
9417         * cp-abi.h: Rename include guard.
9418         * config/sparc/nm-sol2.h: Rename include guard.
9419         * config/nm-nto.h: Rename include guard.
9420         * config/nm-linux.h: Add include guard.
9421         * config/i386/nm-i386gnu.h: Rename include guard.
9422         * config/djgpp/nl_types.h: Rename include guard.
9423         * config/djgpp/langinfo.h: Rename include guard.
9424         * compile/gcc-cp-plugin.h: Add include guard.
9425         * compile/gcc-c-plugin.h: Add include guard.
9426         * compile/compile.h: Rename include guard.
9427         * compile/compile-object-run.h: Rename include guard.
9428         * compile/compile-object-load.h: Rename include guard.
9429         * compile/compile-internal.h: Rename include guard.
9430         * compile/compile-cplus.h: Rename include guard.
9431         * compile/compile-c.h: Rename include guard.
9432         * common/xml-utils.h: Rename include guard.
9433         * common/x86-xstate.h: Rename include guard.
9434         * common/version.h: Rename include guard.
9435         * common/vec.h: Rename include guard.
9436         * common/tdesc.h: Rename include guard.
9437         * common/selftest.h: Rename include guard.
9438         * common/scoped_restore.h: Rename include guard.
9439         * common/scoped_mmap.h: Rename include guard.
9440         * common/scoped_fd.h: Rename include guard.
9441         * common/safe-iterator.h: Rename include guard.
9442         * common/run-time-clock.h: Rename include guard.
9443         * common/refcounted-object.h: Rename include guard.
9444         * common/queue.h: Rename include guard.
9445         * common/ptid.h: Rename include guard.
9446         * common/print-utils.h: Rename include guard.
9447         * common/preprocessor.h: Rename include guard.
9448         * common/pathstuff.h: Rename include guard.
9449         * common/observable.h: Rename include guard.
9450         * common/netstuff.h: Rename include guard.
9451         * common/job-control.h: Rename include guard.
9452         * common/host-defs.h: Rename include guard.
9453         * common/gdb_wait.h: Rename include guard.
9454         * common/gdb_vecs.h: Rename include guard.
9455         * common/gdb_unlinker.h: Rename include guard.
9456         * common/gdb_unique_ptr.h: Rename include guard.
9457         * common/gdb_tilde_expand.h: Rename include guard.
9458         * common/gdb_sys_time.h: Rename include guard.
9459         * common/gdb_string_view.h: Rename include guard.
9460         * common/gdb_splay_tree.h: Rename include guard.
9461         * common/gdb_setjmp.h: Rename include guard.
9462         * common/gdb_ref_ptr.h: Rename include guard.
9463         * common/gdb_optional.h: Rename include guard.
9464         * common/gdb_locale.h: Rename include guard.
9465         * common/gdb_assert.h: Rename include guard.
9466         * common/filtered-iterator.h: Rename include guard.
9467         * common/filestuff.h: Rename include guard.
9468         * common/fileio.h: Rename include guard.
9469         * common/environ.h: Rename include guard.
9470         * common/common-utils.h: Rename include guard.
9471         * common/common-types.h: Rename include guard.
9472         * common/common-regcache.h: Rename include guard.
9473         * common/common-inferior.h: Rename include guard.
9474         * common/common-gdbthread.h: Rename include guard.
9475         * common/common-exceptions.h: Rename include guard.
9476         * common/common-defs.h: Rename include guard.
9477         * common/common-debug.h: Rename include guard.
9478         * common/cleanups.h: Rename include guard.
9479         * common/buffer.h: Rename include guard.
9480         * common/btrace-common.h: Rename include guard.
9481         * common/break-common.h: Rename include guard.
9482         * cli/cli-utils.h: Rename include guard.
9483         * cli/cli-style.h: Rename include guard.
9484         * cli/cli-setshow.h: Rename include guard.
9485         * cli/cli-script.h: Rename include guard.
9486         * cli/cli-interp.h: Rename include guard.
9487         * cli/cli-decode.h: Rename include guard.
9488         * cli/cli-cmds.h: Rename include guard.
9489         * charset-list.h: Add include guard.
9490         * buildsym-legacy.h: Rename include guard.
9491         * bfin-tdep.h: Add include guard.
9492         * ax.h: Rename include guard.
9493         * arm-linux-tdep.h: Add include guard.
9494         * arm-fbsd-tdep.h: Add include guard.
9495         * arch/xtensa.h: Rename include guard.
9496         * arch/tic6x.h: Add include guard.
9497         * arch/i386.h: Add include guard.
9498         * arch/arm.h: Rename include guard.
9499         * arch/arm-linux.h: Rename include guard.
9500         * arch/arm-get-next-pcs.h: Rename include guard.
9501         * arch/amd64.h: Add include guard.
9502         * arch/aarch64-insn.h: Rename include guard.
9503         * arch-utils.h: Rename include guard.
9504         * annotate.h: Add include guard.
9505         * amd64-darwin-tdep.h: Rename include guard.
9506         * aarch64-linux-tdep.h: Add include guard.
9507         * aarch64-fbsd-tdep.h: Add include guard.
9508         * aarch32-linux-nat.h: Add include guard.
9509
9510 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9511
9512         * macrotab.c (macro_define_internal): New function that
9513         factorizes macro_define_object_internal and macro_define_function
9514         code.
9515         (macro_define_object_internal): Use macro_define_internal.
9516         (macro_define_function): Likewise.
9517
9518 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9519
9520         * macrocmd.c (extract_identifier): Return
9521         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9522         callers.
9523
9524 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9525
9526         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9527
9528 2019-02-05  Tom Tromey  <tom@tromey.com>
9529
9530         * target.c (target_stack::unpush): Move assertion earlier.
9531
9532 2019-01-30  Tom Tromey  <tom@tromey.com>
9533
9534         PR python/23615:
9535         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9536         (gdbpy_parse_and_eval): Likewise.
9537         * python/python-internal.h (gdbpy_allow_threads): New class.
9538
9539 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9540
9541         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9542         (aarch64_fbsd_fpregmap): Move earlier.
9543         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9544         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9545         instead of individual calls to trad_frame_set_reg_addr.
9546         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9547         earlier.
9548         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9549         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9550         instead of individual calls to trad_frame_set_reg_addr.
9551
9552 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9553
9554         * CONTRIBUTE: Replace contribution list with wiki link.
9555
9556 2019-01-25  Tom Tromey  <tom@tromey.com>
9557
9558         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9559
9560 2019-01-25  Tom Tromey  <tom@tromey.com>
9561
9562         * xtensa-linux-nat.c: Fix common/ includes.
9563         * xml-support.h: Fix common/ includes.
9564         * xml-support.c: Fix common/ includes.
9565         * x86-linux-nat.c: Fix common/ includes.
9566         * windows-nat.c: Fix common/ includes.
9567         * varobj.h: Fix common/ includes.
9568         * varobj.c: Fix common/ includes.
9569         * value.c: Fix common/ includes.
9570         * valops.c: Fix common/ includes.
9571         * utils.c: Fix common/ includes.
9572         * unittests/xml-utils-selftests.c: Fix common/ includes.
9573         * unittests/utils-selftests.c: Fix common/ includes.
9574         * unittests/unpack-selftests.c: Fix common/ includes.
9575         * unittests/tracepoint-selftests.c: Fix common/ includes.
9576         * unittests/style-selftests.c: Fix common/ includes.
9577         * unittests/string_view-selftests.c: Fix common/ includes.
9578         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9579         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9580         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9581         * unittests/rsp-low-selftests.c: Fix common/ includes.
9582         * unittests/parse-connection-spec-selftests.c: Fix common/
9583         includes.
9584         * unittests/optional-selftests.c: Fix common/ includes.
9585         * unittests/offset-type-selftests.c: Fix common/ includes.
9586         * unittests/observable-selftests.c: Fix common/ includes.
9587         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9588         * unittests/memrange-selftests.c: Fix common/ includes.
9589         * unittests/memory-map-selftests.c: Fix common/ includes.
9590         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9591         * unittests/function-view-selftests.c: Fix common/ includes.
9592         * unittests/environ-selftests.c: Fix common/ includes.
9593         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9594         * unittests/common-utils-selftests.c: Fix common/ includes.
9595         * unittests/cli-utils-selftests.c: Fix common/ includes.
9596         * unittests/array-view-selftests.c: Fix common/ includes.
9597         * ui-file.c: Fix common/ includes.
9598         * tui/tui-io.c: Fix common/ includes.
9599         * tracepoint.h: Fix common/ includes.
9600         * tracepoint.c: Fix common/ includes.
9601         * tracefile-tfile.c: Fix common/ includes.
9602         * top.h: Fix common/ includes.
9603         * top.c: Fix common/ includes.
9604         * thread.c: Fix common/ includes.
9605         * target/waitstatus.h: Fix common/ includes.
9606         * target/waitstatus.c: Fix common/ includes.
9607         * target.h: Fix common/ includes.
9608         * target.c: Fix common/ includes.
9609         * target-memory.c: Fix common/ includes.
9610         * target-descriptions.c: Fix common/ includes.
9611         * symtab.h: Fix common/ includes.
9612         * symfile.c: Fix common/ includes.
9613         * stap-probe.c: Fix common/ includes.
9614         * spu-linux-nat.c: Fix common/ includes.
9615         * sparc-nat.c: Fix common/ includes.
9616         * source.c: Fix common/ includes.
9617         * solib.c: Fix common/ includes.
9618         * solib-target.c: Fix common/ includes.
9619         * ser-unix.c: Fix common/ includes.
9620         * ser-tcp.c: Fix common/ includes.
9621         * ser-pipe.c: Fix common/ includes.
9622         * ser-base.c: Fix common/ includes.
9623         * selftest-arch.c: Fix common/ includes.
9624         * s12z-tdep.c: Fix common/ includes.
9625         * rust-exp.y: Fix common/ includes.
9626         * rs6000-aix-tdep.c: Fix common/ includes.
9627         * riscv-tdep.c: Fix common/ includes.
9628         * remote.c: Fix common/ includes.
9629         * remote-notif.h: Fix common/ includes.
9630         * remote-fileio.h: Fix common/ includes.
9631         * remote-fileio.c: Fix common/ includes.
9632         * regcache.h: Fix common/ includes.
9633         * regcache.c: Fix common/ includes.
9634         * record-btrace.c: Fix common/ includes.
9635         * python/python.c: Fix common/ includes.
9636         * python/py-type.c: Fix common/ includes.
9637         * python/py-inferior.c: Fix common/ includes.
9638         * progspace.h: Fix common/ includes.
9639         * producer.c: Fix common/ includes.
9640         * procfs.c: Fix common/ includes.
9641         * proc-api.c: Fix common/ includes.
9642         * printcmd.c: Fix common/ includes.
9643         * ppc-linux-nat.c: Fix common/ includes.
9644         * parser-defs.h: Fix common/ includes.
9645         * osdata.c: Fix common/ includes.
9646         * obsd-nat.c: Fix common/ includes.
9647         * nat/x86-linux.c: Fix common/ includes.
9648         * nat/x86-linux-dregs.c: Fix common/ includes.
9649         * nat/x86-dregs.h: Fix common/ includes.
9650         * nat/x86-dregs.c: Fix common/ includes.
9651         * nat/ppc-linux.c: Fix common/ includes.
9652         * nat/mips-linux-watch.h: Fix common/ includes.
9653         * nat/mips-linux-watch.c: Fix common/ includes.
9654         * nat/linux-waitpid.c: Fix common/ includes.
9655         * nat/linux-ptrace.h: Fix common/ includes.
9656         * nat/linux-ptrace.c: Fix common/ includes.
9657         * nat/linux-procfs.c: Fix common/ includes.
9658         * nat/linux-personality.c: Fix common/ includes.
9659         * nat/linux-osdata.c: Fix common/ includes.
9660         * nat/linux-namespaces.c: Fix common/ includes.
9661         * nat/linux-btrace.h: Fix common/ includes.
9662         * nat/linux-btrace.c: Fix common/ includes.
9663         * nat/fork-inferior.c: Fix common/ includes.
9664         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9665         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9666         * nat/aarch64-linux.c: Fix common/ includes.
9667         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9668         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9669         * namespace.h: Fix common/ includes.
9670         * mips-linux-tdep.c: Fix common/ includes.
9671         * minsyms.c: Fix common/ includes.
9672         * mi/mi-parse.h: Fix common/ includes.
9673         * mi/mi-main.c: Fix common/ includes.
9674         * mi/mi-cmd-env.c: Fix common/ includes.
9675         * memrange.h: Fix common/ includes.
9676         * memattr.c: Fix common/ includes.
9677         * maint.h: Fix common/ includes.
9678         * maint.c: Fix common/ includes.
9679         * main.c: Fix common/ includes.
9680         * machoread.c: Fix common/ includes.
9681         * location.c: Fix common/ includes.
9682         * linux-thread-db.c: Fix common/ includes.
9683         * linux-nat.c: Fix common/ includes.
9684         * linux-fork.c: Fix common/ includes.
9685         * inline-frame.c: Fix common/ includes.
9686         * infrun.c: Fix common/ includes.
9687         * inflow.c: Fix common/ includes.
9688         * inferior.h: Fix common/ includes.
9689         * inferior.c: Fix common/ includes.
9690         * infcmd.c: Fix common/ includes.
9691         * inf-ptrace.c: Fix common/ includes.
9692         * inf-child.c: Fix common/ includes.
9693         * ia64-linux-nat.c: Fix common/ includes.
9694         * i387-tdep.c: Fix common/ includes.
9695         * i386-tdep.c: Fix common/ includes.
9696         * i386-linux-tdep.c: Fix common/ includes.
9697         * i386-linux-nat.c: Fix common/ includes.
9698         * i386-go32-tdep.c: Fix common/ includes.
9699         * i386-fbsd-tdep.c: Fix common/ includes.
9700         * i386-fbsd-nat.c: Fix common/ includes.
9701         * guile/scm-type.c: Fix common/ includes.
9702         * guile/guile.c: Fix common/ includes.
9703         * go32-nat.c: Fix common/ includes.
9704         * gnu-nat.c: Fix common/ includes.
9705         * gdbthread.h: Fix common/ includes.
9706         * gdbarch-selftests.c: Fix common/ includes.
9707         * gdb_usleep.c: Fix common/ includes.
9708         * gdb_select.h: Fix common/ includes.
9709         * gdb_bfd.c: Fix common/ includes.
9710         * gcore.c: Fix common/ includes.
9711         * fork-child.c: Fix common/ includes.
9712         * findvar.c: Fix common/ includes.
9713         * fbsd-nat.c: Fix common/ includes.
9714         * event-top.c: Fix common/ includes.
9715         * event-loop.c: Fix common/ includes.
9716         * dwarf2read.c: Fix common/ includes.
9717         * dwarf2loc.c: Fix common/ includes.
9718         * dwarf2-frame.c: Fix common/ includes.
9719         * dwarf-index-cache.c: Fix common/ includes.
9720         * dtrace-probe.c: Fix common/ includes.
9721         * disasm-selftests.c: Fix common/ includes.
9722         * defs.h: Fix common/ includes.
9723         * csky-tdep.c: Fix common/ includes.
9724         * cp-valprint.c: Fix common/ includes.
9725         * cp-support.h: Fix common/ includes.
9726         * cp-support.c: Fix common/ includes.
9727         * corelow.c: Fix common/ includes.
9728         * completer.h: Fix common/ includes.
9729         * completer.c: Fix common/ includes.
9730         * compile/compile.c: Fix common/ includes.
9731         * compile/compile-loc2c.c: Fix common/ includes.
9732         * compile/compile-cplus-types.c: Fix common/ includes.
9733         * compile/compile-cplus-symbols.c: Fix common/ includes.
9734         * command.h: Fix common/ includes.
9735         * cli/cli-dump.c: Fix common/ includes.
9736         * cli/cli-cmds.c: Fix common/ includes.
9737         * charset.c: Fix common/ includes.
9738         * build-id.c: Fix common/ includes.
9739         * btrace.h: Fix common/ includes.
9740         * btrace.c: Fix common/ includes.
9741         * breakpoint.h: Fix common/ includes.
9742         * breakpoint.c: Fix common/ includes.
9743         * ax.h: 
9744         (enum agent_op): Fix common/ includes.
9745         * ax-general.c (struct aop_map): Fix common/ includes.
9746         * ax-gdb.c: Fix common/ includes.
9747         * auxv.c: Fix common/ includes.
9748         * auto-load.c: Fix common/ includes.
9749         * arm-tdep.c: Fix common/ includes.
9750         * arch/riscv.c: Fix common/ includes.
9751         * arch/ppc-linux-common.c: Fix common/ includes.
9752         * arch/i386.c: Fix common/ includes.
9753         * arch/arm.c: Fix common/ includes.
9754         * arch/arm-linux.c: Fix common/ includes.
9755         * arch/arm-get-next-pcs.c: Fix common/ includes.
9756         * arch/amd64.c: Fix common/ includes.
9757         * arch/aarch64.c: Fix common/ includes.
9758         * arch/aarch64-insn.c: Fix common/ includes.
9759         * arch-utils.c: Fix common/ includes.
9760         * amd64-windows-tdep.c: Fix common/ includes.
9761         * amd64-tdep.c: Fix common/ includes.
9762         * amd64-sol2-tdep.c: Fix common/ includes.
9763         * amd64-obsd-tdep.c: Fix common/ includes.
9764         * amd64-nbsd-tdep.c: Fix common/ includes.
9765         * amd64-linux-tdep.c: Fix common/ includes.
9766         * amd64-linux-nat.c: Fix common/ includes.
9767         * amd64-fbsd-tdep.c: Fix common/ includes.
9768         * amd64-fbsd-nat.c: Fix common/ includes.
9769         * amd64-dicos-tdep.c: Fix common/ includes.
9770         * amd64-darwin-tdep.c: Fix common/ includes.
9771         * agent.c: Fix common/ includes.
9772         * ada-lang.h: Fix common/ includes.
9773         * ada-lang.c: Fix common/ includes.
9774         * aarch64-tdep.c: Fix common/ includes.
9775
9776 2019-01-25  Tom Tromey  <tom@tromey.com>
9777
9778         * common/create-version.sh: Use common/version.h.
9779
9780 2019-01-24  Pedro Alves  <palves@redhat.com>
9781
9782         * infrun.c (signal_stop, signal_print, signal_program)
9783         (signal_catch, signal_pass): Now arrays instead of pointers.
9784         (update_signals_program_target, do_target_resume)
9785         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9786         * linux-nat.c (linux_nat_target::pass_signals)
9787         (linux_nat_target::create_inferior, linux_nat_target::attach):
9788         Adjust.
9789         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9790         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9791         * procfs.c (procfs_target::pass_signals): Adjust.
9792         * record-full.c (record_full_target::resume): Adjust.
9793         * remote.c (remote_target::pass_signals)
9794         (remote_target::program_signals): Adjust.
9795         * target-debug.h (target_debug_print_signals): Now takes a
9796         gdb::array_view as parameter.  Adjust.
9797         * target.h (target_ops) <pass_signals, program_signals>: Replace
9798         pointer and length parameters with gdb::array_view.
9799         (target_pass_signals, target_program_signals): Likewise.
9800         * target-delegates.c: Regenerate.
9801
9802 2019-01-24  Pedro Alves  <palves@redhat.com>
9803
9804         * common/forward-scope-exit.h
9805         (forward_scope_exit::forward_scope_exit): Pass arguments to
9806         m_bind_function directly, instead of creating a std::bind and
9807         copying that.
9808
9809 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9810
9811         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9812         for static members.
9813         (pass_in_v_vfp_candidate): Likewise.
9814
9815 2019-01-23  Tom Tromey  <tom@tromey.com>
9816             Pedro Alves  <palves@redhat.com>
9817
9818         * regcache.c (class regcache_invalidator): Remove.
9819         (regcache::raw_write): Use make_scope_exit.
9820
9821 2019-01-23  Tom Tromey  <tom@tromey.com>
9822
9823         * ui-out.h (class ui_out_emit_type): Update comment.
9824
9825 2019-01-23  Tom Tromey  <tom@tromey.com>
9826
9827         * infrun.c (fetch_inferior_event): Update comment.
9828
9829 2019-01-23  Tom Tromey  <tom@tromey.com>
9830             Pedro Alves  <palves@redhat.com>
9831
9832         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9833         parameter.
9834         (fetch_inferior_event): Use SCOPE_EXIT.
9835
9836
9837 2019-01-23  Tom Tromey  <tom@tromey.com>
9838             Pedro Alves  <palves@redhat.com>
9839
9840         * infrun.c (disable_thread_events): Delete.
9841         (stop_all_threads): Use SCOPE_EXIT.
9842
9843 2019-01-23  Tom Tromey  <tom@tromey.com>
9844             Pedro Alves  <palves@redhat.com>
9845
9846         * symfile.c: Include forward-scope-exit.h.
9847         (clear_symtab_users_cleanup): Replace forward declaration with
9848         a FORWARD_SCOPE_EXIT.
9849         (syms_from_objfile_1): Use the forward_scope_exit and
9850         gdb::optional instead of cleanup_function.
9851         (reread_symbols): Use the forward_scope_exit instead of
9852         cleanup_function.
9853         (clear_symtab_users_cleanup): Remove function.
9854
9855 2019-01-23  Tom Tromey  <tom@tromey.com>
9856             Pedro Alves  <palves@redhat.com>
9857
9858         * linux-nat.c: Include scope-exit.h.
9859         (cleanup_target_stop): Remove.
9860         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9861         SCOPE_EXIT.
9862
9863 2019-01-23  Tom Tromey  <tom@tromey.com>
9864             Pedro Alves  <palves@redhat.com>
9865
9866         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9867         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9868
9869 2019-01-23  Tom Tromey  <tom@tromey.com>
9870             Andrew Burgess  <andrew.burgess@embecosm.com>
9871             Pedro Alves  <palves@redhat.com>
9872
9873         * infrun.c (fetch_inferior_event): Use scope_exit.
9874         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9875         * top.c (execute_command): Use scope_exit.
9876         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9877         * utils.c (do_bpstat_clear_actions_cleanup)
9878         (make_bpstat_clear_actions_cleanup): Remove.
9879
9880 2019-01-23  Tom Tromey  <tom@tromey.com>
9881             Pedro Alves  <palves@redhat.com>
9882
9883         * infrun.c: Include "common/scope-exit.h"
9884         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9885         (wait_for_inferior): Use SCOPE_EXIT.
9886         (fetch_inferior_event): Use scope_exit.
9887
9888 2019-01-23  Tom Tromey  <tom@tromey.com>
9889             Pedro Alves  <palves@redhat.com>
9890
9891         * breakpoint.c (create_breakpoint): Remove cleanup.
9892
9893 2019-01-23  Tom Tromey  <tom@tromey.com>
9894             Andrew Burgess  <andrew.burgess@embecosm.com>
9895             Pedro Alves  <palves@redhat.com>
9896
9897 2019-01-23  Pedro Alves  <palves@redhat.com>
9898
9899         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9900
9901 2019-01-23  Pedro Alves  <palves@redhat.com>
9902             Andrew Burgess  <andrew.burgess@embecosm.com>
9903
9904         * gdbthread.h: Include "common/forward-scope-exit.h".
9905         (scoped_finish_thread_state): Redefine custom class in terms of
9906         forward_scope_exit.
9907
9908 2019-01-23  Pedro Alves  <palves@redhat.com>
9909             Andrew Burgess  <andrew.burgess@embecosm.com>
9910
9911         * common/forward-scope-exit.h: New file.
9912
9913 2019-01-23  Pedro Alves  <palves@redhat.com>
9914             Andrew Burgess  <andrew.burgess@embecosm.com>
9915             Tom Tromey  <tom@tromey.com>
9916
9917         * common/scope-exit.h: New file.
9918
9919 2019-01-23  Pedro Alves  <palves@redhat.com>
9920
9921         * common/preprocessor.h (ESC): Rename to ...
9922         (ESC_PARENS): ... this.
9923         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9924         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9925
9926 2019-01-23  Tom Tromey  <tom@tromey.com>
9927
9928         * language.h (class scoped_switch_to_sym_language_if_auto):
9929         Initialize m_lang in both cases.
9930
9931 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9932
9933         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9934         with XCNEW.
9935
9936 2019-01-22  Tom Tromey  <tom@tromey.com>
9937
9938         * corelow.c: Do not include sys/file.h.
9939
9940 2019-01-22  Tom Tromey  <tom@tromey.com>
9941
9942         * tui/tui-wingeneral.h: Include gdb_curses.h.
9943
9944 2019-01-22  Tom Tromey  <tom@tromey.com>
9945
9946         * source-cache.h (class source_cache) <get_source_lines,
9947         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9948
9949 2019-01-22  Tom Tromey  <tom@tromey.com>
9950
9951         * remote-fileio.h (struct remote_target): Declare.
9952
9953 2019-01-22  Tom Tromey  <tom@tromey.com>
9954
9955         * python/py-arch.c: Do not include py-ref.h.
9956         * python/py-bpevent.c: Do not include py-ref.h.
9957         * python/py-cmd.c: Do not include py-ref.h.
9958         * python/py-continueevent.c: Do not include py-ref.h.
9959         * python/py-event.h: Do not include py-ref.h.
9960         * python/py-evtregistry.c: Do not include py-ref.h.
9961         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9962         * python/py-frame.c: Do not include py-ref.h.
9963         * python/py-framefilter.c: Do not include py-ref.h.
9964         * python/py-function.c: Do not include py-ref.h.
9965         * python/py-infevents.c: Do not include py-ref.h.
9966         * python/py-linetable.c: Do not include py-ref.h.
9967         * python/py-objfile.c: Do not include py-ref.h.
9968         * python/py-param.c: Do not include py-ref.h.
9969         * python/py-prettyprint.c: Do not include py-ref.h.
9970         * python/py-progspace.c: Do not include py-ref.h.
9971         * python/py-symbol.c: Do not include py-ref.h.
9972         * python/py-symtab.c: Do not include py-ref.h.
9973         * python/py-type.c: Do not include py-ref.h.
9974         * python/py-unwind.c: Do not include py-ref.h.
9975         * python/py-utils.c: Do not include py-ref.h.
9976         * python/py-value.c: Do not include py-ref.h.
9977         * python/py-varobj.c: Do not include py-ref.h.
9978         * python/py-xmethods.c: Do not include py-ref.h.
9979         * python/python.c: Do not include py-ref.h.
9980         * varobj.c: Do not include py-ref.h.
9981
9982 2019-01-22  Tom Tromey  <tom@tromey.com>
9983
9984         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9985         keyword for bcache.
9986
9987 2019-01-22  Tom Tromey  <tom@tromey.com>
9988
9989         * compile/compile-cplus-types.c: Remove a comment by #include.
9990
9991 2019-01-22  Tom Tromey  <tom@tromey.com>
9992
9993         * compile/gcc-c-plugin.h: Include compile-internal.h.
9994
9995 2019-01-22  Tom Tromey  <tom@tromey.com>
9996
9997         * stabsread.c (EXTERN): Do not define.
9998         (symnum, next_symbol_text_func, processing_gcc_compilation)
9999         (within_function, global_sym_chain, global_stabs)
10000         (previous_stab_code, this_object_header_files)
10001         (n_this_object_header_files)
10002         (n_allocated_this_object_header_files): Define.
10003         * stabsread.h (EXTERN): Never define.  Use "extern".
10004
10005 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10006
10007         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10008         history_value.
10009
10010 2019-01-21  Tom Tromey  <tom@tromey.com>
10011
10012         * ui-out.c: Fix includes.
10013         * tui/tui-source.c: Fix includes.
10014         * target.c: Fix includes.
10015         * remote.c: Fix includes.
10016         * regcache.c: Fix includes.
10017         * python/py-block.c: Fix includes.
10018         * printcmd.c: Fix includes.
10019         * or1k-tdep.c: Fix includes.
10020         * mi/mi-main.c: Fix includes.
10021         * m32r-tdep.c: Fix includes.
10022         * csky-tdep.c: Fix includes.
10023         * compile/compile-cplus-types.c: Fix includes.
10024         * cli/cli-interp.c: Fix includes.
10025
10026 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10027
10028         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10029         for padding.
10030
10031 2019-01-16  Tom Tromey  <tom@tromey.com>
10032
10033         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10034         earlier.
10035         (struct objfile) <msymbols_range>: Move from top level.
10036         <msymbols>: New method.
10037         (class objfile_msymbols): Remove.
10038         * symtab.c (default_collect_symbol_completion_matches_break_on):
10039         Update.
10040         * symmisc.c (dump_msymbols): Update.
10041         * stabsread.c (scan_file_globals): Update.
10042         * objc-lang.c (info_selectors_command, info_classes_command)
10043         (find_methods): Update.
10044         * minsyms.c (find_solib_trampoline_target): Update.
10045         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10046         * coffread.c (coff_symfile_read): Update.
10047         * ada-lang.c (ada_lookup_simple_minsym)
10048         (ada_collect_symbol_completion_matches): Update.
10049
10050 2019-01-16  Tom Tromey  <tom@tromey.com>
10051
10052         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10053         type.  Remove no-argument constructor.
10054         <iterator::operator++>: Simplify.
10055         <begin>: Update.
10056         <end>: Use minimal_symbol_count.
10057
10058 2019-01-16  Tom Tromey  <tom@tromey.com>
10059
10060         * objfiles.h (struct objfile) <psymtabs>: New method.
10061         (class objfile_psymtabs): Remove.
10062         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10063         typedef.
10064         <range>: New method.
10065         (require_partial_symbols): Change return type.
10066         * psymtab.c (require_partial_symbols)
10067         (psym_expand_symtabs_matching): Update.
10068         * mdebugread.c (parse_partial_symbols): Update.
10069         * dbxread.c (dbx_end_psymtab): Update.
10070
10071 2019-01-15  Tom Tromey  <tom@tromey.com>
10072
10073         * symtab.c (lookup_objfile_from_block)
10074         (lookup_symbol_in_objfile_symtabs)
10075         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10076         (find_line_symtab, info_sources_command)
10077         (default_collect_symbol_completion_matches_break_on)
10078         (make_source_files_completion_list): Update.
10079         * symmisc.c (print_objfile_statistics, dump_objfile)
10080         (maintenance_print_symbols, maintenance_info_symtabs)
10081         (maintenance_check_symtabs, maintenance_info_line_tables):
10082         Update.
10083         * source.c (select_source_symtab)
10084         (forget_cached_source_info_for_objfile): Update.
10085         * objfiles.h (class objfile_compunits): Remove.
10086         (struct objfile) <compunits_range>: New typedef.
10087         (compunits): New method.
10088         * objfiles.c (objfile_relocate1): Update.
10089         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10090         * maint.c (count_symtabs_and_blocks): Update.
10091         * linespec.c (iterate_over_all_matching_symtabs): Update.
10092         * cp-support.c (add_symbol_overload_list_qualified): Update.
10093         * coffread.c (coff_symtab_read): Update.
10094         * ada-lang.c (add_nonlocal_symbols)
10095         (ada_collect_symbol_completion_matches)
10096         (ada_add_global_exceptions): Update.
10097
10098 2019-01-15  Tom Tromey  <tom@tromey.com>
10099
10100         * progspace.h (program_space) <objfiles_safe_range>: New
10101         typedef.
10102         <objfiles_safe>: New method.
10103         * objfiles.h (class all_objfiles_safe): Remove.
10104         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10105         * jit.c (jit_inferior_exit_hook): Update.
10106
10107 2019-01-17  Tom Tromey  <tom@tromey.com>
10108
10109         * progspace.h (program_space) <objfiles_range>: New typedef.
10110         <objfiles>: New method.
10111         <objfiles_head>: Rename from objfiles.
10112         (object_files): Update.
10113         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10114         * guile/scm-pretty-print.c
10115         (ppscm_find_pretty_printer_from_objfiles): Update.
10116         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10117         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10118         Update.
10119         * python/py-progspace.c (pspy_get_objfiles): Update.
10120         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10121         Update.
10122         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10123         (objfpy_lookup_objfile_by_build_id): Update.
10124         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10125         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10126         Update.
10127         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10128         (expand_symtab_containing_pc, lookup_objfile_from_block)
10129         (lookup_static_symbol, basic_lookup_transparent_type)
10130         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10131         (find_line_symtab, info_sources_command)
10132         (default_collect_symbol_completion_matches_break_on)
10133         (make_source_files_completion_list, find_main_name): Update.
10134         * symmisc.c (print_symbol_bcache_statistics)
10135         (print_objfile_statistics, maintenance_print_symbols)
10136         (maintenance_print_msymbols, maintenance_print_objfiles)
10137         (maintenance_info_symtabs, maintenance_check_symtabs)
10138         (maintenance_expand_symtabs, maintenance_info_line_tables):
10139         Update.
10140         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10141         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10142         (map_overlay_command, unmap_overlay_command)
10143         (simple_overlay_update, expand_symtabs_matching)
10144         (map_symbol_filenames): Update.
10145         * symfile-debug.c (set_debug_symfile): Update.
10146         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10147         Update.
10148         * source.c (select_source_symtab, forget_cached_source_info):
10149         Update.
10150         * solib.c (solib_read_symbols): Update.
10151         * solib-spu.c (append_ocl_sos): Update.
10152         * psymtab.c (maintenance_print_psymbols)
10153         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10154         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10155         * printcmd.c (info_symbol_command): Update.
10156         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10157         Update.
10158         * objfiles.h (class all_objfiles): Remove.
10159         * objfiles.c (have_partial_symbols, have_full_symbols)
10160         (have_minimal_symbols, qsort_cmp, update_section_map)
10161         (shared_objfile_contains_address_p)
10162         (default_iterate_over_objfiles_in_search_order): Update.
10163         * objc-lang.c (info_selectors_command, info_classes_command)
10164         (find_methods): Update.
10165         * minsyms.c (find_solib_trampoline_target): Update.
10166         * maint.c (maintenance_info_sections)
10167         (maintenance_translate_address, count_symtabs_and_blocks):
10168         Update.
10169         * main.c (captured_main_1): Update.
10170         * linux-thread-db.c (try_thread_db_load_from_pdir)
10171         (has_libpthread): Update.
10172         * linespec.c (iterate_over_all_matching_symtabs)
10173         (search_minsyms_for_name): Update.
10174         * jit.c (jit_find_objf_with_entry_addr): Update.
10175         * hppa-tdep.c (find_unwind_entry)
10176         (hppa_lookup_stub_minimal_symbol): Update.
10177         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10178         Update.
10179         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10180         (elf_gnu_ifunc_resolve_by_got): Update.
10181         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10182         * dwarf-index-write.c (save_gdb_index_command): Update.
10183         * cp-support.c (add_symbol_overload_list_qualified): Update.
10184         * breakpoint.c (create_overlay_event_breakpoint)
10185         (create_longjmp_master_breakpoint)
10186         (create_std_terminate_master_breakpoint)
10187         (create_exception_master_breakpoint): Update.
10188         * blockframe.c (find_pc_partial_function): Update.
10189         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10190         (ada_collect_symbol_completion_matches)
10191         (ada_add_global_exceptions): Update.
10192
10193 2019-01-17  Tom Tromey  <tom@tromey.com>
10194
10195         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10196         declare VEC.
10197         (solib_target_parse_libraries): Change return type.
10198         (library_list_start_segment, library_list_start_section)
10199         (library_list_end_library, library_list_start_library); Update.
10200         (solib_target_free_library_list): Remove.
10201         (solib_target_parse_libraries): Remove cleanup.  Change return
10202         type.
10203         (solib_target_current_sos): Update.
10204
10205 2019-01-17  Tom Tromey  <tromey@bapiya>
10206
10207         * valprint.c: Replace "the the" with "the".
10208         * symtab.c: Replace "the the" with "the".
10209         * solib.c: Replace "the the" with "the".
10210         * solib-dsbt.c: Replace "the the" with "the".
10211         * linespec.c: Replace "the the" with "the".
10212         * dwarf2loc.h: Replace "the the" with "the".
10213         * amd64-windows-tdep.c: Replace "the the" with "the".
10214         * aarch64-tdep.c: Replace "the the" with "the".
10215
10216 2019-01-16  Keith Seitz  <keiths@redhat.com>
10217
10218         PR gdb/23773
10219         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10220         <builder>: Rename to ..
10221         <m_builder>: ... this and make private.
10222         (dwarf2_cu::get_builder): New method.  Change all users of
10223         `builder' to use this method.
10224         (dwarf2_start_symtab): Move to ...
10225         (dwarf2_cu::start_symtab): ... here.  Update all callers
10226         (setup_type_unit_groups): Move to ...
10227         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10228         callers.
10229         (dwarf2_cu::reset_builder): New method.
10230         (process_full_compunit, process_full_type_unit): Use
10231         dwarf2_cu::reset_builder.
10232         (follow_die_offset): Record the ancestor CU if it is different
10233         from the followed DIE's CU.
10234         (follow_die_sig_1): Likewise.
10235
10236 2019-01-15  Tom Tromey  <tom@tromey.com>
10237
10238         * remote.c (class remote_state) <buf>: Now a char_vector.
10239         <buf_size>: Remove.
10240         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10241         parameter.
10242         (remote_target::getpkt_or_notif_sane_1)
10243         (remote_target::getpkt_sane)
10244         (remote_target::getpkt_or_notif_sane): Likewise.
10245         (class remote_target) <putpkt>: New overload.
10246         (remote_target::read_frame): Change type of "buf_p".  Remove
10247         sizeof_p parameter.
10248         (packet_ok): New overload.
10249         (packet_check_result): New overload.
10250         Update all uses.
10251
10252 2019-01-14  Tom Tromey  <tom@tromey.com>
10253
10254         * remote-notif.c (handle_notification, remote_notif_ack)
10255         (remote_notif_parse): Make "buf" const.
10256         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10257         const.
10258         (remote_notif_parse, remote_notif_ack, handle_notification):
10259         Likewise.
10260         * remote.c (remote_notif_stop_parse): Make "buf" const.
10261         (remote_target::remote_parse_stop_reply): Make "buf" const.
10262         (remote_notif_stop_ack): Make "buf" const.
10263
10264 2019-01-14  Tom Tromey  <tom@tromey.com>
10265
10266         * remote.c (remote_console_output): Make parameter const.
10267
10268 2019-01-14  Tom Tromey  <tom@tromey.com>
10269
10270         * target-debug.h (target_debug_print_signals): Constify.
10271         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10272         * procfs.c (procfs_target::pass_signals): Update.
10273         * linux-nat.c (linux_nat_target::pass_signals): Update.
10274         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10275         * target-delegates.c: Rebuild.
10276         * remote.c (remote_target::program_signals): Update.
10277         (remote_target::pass_signals): Update.
10278         * target.c (target_pass_signals): Constify argument.
10279         (target_program_signals): Likewise.
10280         * target.h (struct target_ops) <pass_signals, program_signals>:
10281         Constify argument.
10282         (target_pass_signals, target_program_signals): Constify argument.
10283
10284 2019-01-14  Tom Tromey  <tom@tromey.com>
10285
10286         PR tui/28819:
10287         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10288
10289 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10290
10291         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10292         field.
10293         * rs6000-tdep.c: Include reggroups.h.
10294         (IS_V_ALIAS_PSEUDOREG): Define.
10295         (rs6000_register_name): Return names for the "vX" aliases.
10296         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10297         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10298         aliases.  Call default_register_reggroup_p for all other
10299         pseudo-registers.
10300         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10301         New functions.
10302         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10303         Handle "vX" aliases.
10304         (v_alias_pseudo_register_collect): New function.
10305         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10306         (rs6000_gdbarch_init): Initialize "vX" aliases as
10307         pseudo-registers.  Restore registration of
10308         rs6000_pseudo_register_reggroup_p with
10309         set_tdesc_pseudo_register_reggroup_p.
10310
10311 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10312
10313         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10314         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10315         set_gdbarch_num_pseudo_regs.
10316
10317 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10318
10319         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10320         Remove arg prefixname, add do_set and do_show.
10321         Add member functions set_list and show_list.
10322         * cli/cli-style.c (class cli_style_option): Update accordingly.
10323         (style_set_list): Move to file scope.
10324         (style_show_list): Likewise.
10325         (set_style): Call help_list.
10326         (show_style): Call cmd_show_list.
10327         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10328         Update to use the new macro.
10329
10330 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10331
10332         * ada-lang.c (_initialize_ada_language): Expand the help text
10333         for the "catch exception" command.
10334
10335 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10336
10337         * symtab.c (matching_obj_sections): Initialize obj,
10338         declare it closer to its usage.
10339
10340 2019-01-10  Tom Tromey  <tom@tromey.com>
10341
10342         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10343         (basic_inf_threads_range): Remove.
10344         (inf_threads_range, inf_non_exited_threads_range)
10345         (safe_inf_threads_range): Use next_adapter.
10346
10347 2019-01-10  Keith Seitz  <keiths@redhat.com>
10348
10349         PR gdb/23712
10350         PR symtab/23010
10351         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10352         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10353
10354 2019-01-10  Keith Seitz  <keiths@redhat.com>
10355
10356         PR gdb/23712
10357         PR symtab/23010
10358         * dictionary.c (pending_to_vector): Remove.
10359         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10360         Remove _1 suffix, replacing functions of the same name.  Update
10361         all callers.
10362         (dict_create_hashed, dict_create_hashed_expandable)
10363         (dict_create_linear, dict_create_linear_expandable, dict_free)
10364         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10365         Make functions static.
10366
10367 2019-01-10  Keith Seitz  <keiths@redhat.com>
10368
10369         PR gdb/23712
10370         PR symtab/23010
10371         * dictionary.h (struct dictionary): Replace declaration with
10372         multidictionary.
10373         (dict_create_hashed, dict_create_hashed_expandable)
10374         (dict_create_linear, dict_create_linear_expandable)
10375         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10376         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10377         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10378         taking multidictionary argument.
10379         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10380         * block.h (struct block) <dict>: Change to multidictionary
10381         and rename `multidict'.
10382         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10383         symmisc.c: Update all dictionary references to multidictionary.
10384
10385 2019-01-10  Keith Seitz  <keiths@redhat.com>
10386
10387         PR gdb/23712
10388         PR symtab/23010
10389         * dictionary.c: Include unordered_map.
10390         (pending_to_vector): New function.
10391         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10392         Rewrite the non-"_1" functions to take vector instead
10393         of linked list.
10394         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10395         "new" _1 versions of the same name.
10396         (multidictionary): Define.
10397         (std::hash<enum language): New definition.
10398         (collate_pending_symbols_by_language, mdict_create_hashed)
10399         (mdict_create_hashed_expandable, mdict_create_linear)
10400         (mdict_create_linear_expandable, mdict_free)
10401         (find_language_dictionary, create_new_language_dictionary)
10402         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10403         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10404         (mdict_size, mdict_empty): New functions.
10405         * dictionary.h (mdict_iterator): Define.
10406
10407 2019-01-10  Pedro Alves  <palves@redhat.com>
10408
10409         * breakpoint.c (read_uploaded_action)
10410         (create_tracepoint_from_upload): Adjust to use
10411         gdb::unique_xmalloc_ptr.
10412         * ctf.c (ctf_write_uploaded_tp):
10413         (SET_ARRAY_FIELD): Use emplace_back.
10414         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10415         * tracefile-tfile.c (tfile_write_uploaded_tp):
10416         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10417         gdb::unique_xmalloc_ptr.
10418         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10419         at_string, cond_string, cmd_strings>: Replace char pointers
10420         with gdb::unique_xmalloc_ptr.
10421
10422 2019-01-10  Pedro Alves  <palves@redhat.com>
10423
10424         * solib-target.c (library_list_start_library): Don't xstrdup name.
10425
10426 2019-01-10  Pedro Alves  <palves@redhat.com>
10427
10428         * mdebugread.c (parse_partial_symbols): Use
10429         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10430
10431 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10432
10433         * linux-fork.c (scoped_switch_fork_info)
10434         <~scoped_switch_fork_info>: Fix incorrect variable name.
10435
10436 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10437
10438         * linux-fork.c (scoped_switch_fork_info)
10439         <scoped_switch_fork_info>: Make explicit.
10440         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10441
10442 2019-01-10  Tom Tromey  <tom@tromey.com>
10443
10444         * objfiles.h (objfile::reset_psymtabs): Update.
10445         * objfiles.c (objfile::objfile): Update.
10446         * psymtab.h (psymtab_storage::obstack): Update.
10447         (psymtab_storage::m_obstack): Use gdb::optional.
10448         (class psymtab_storage): Update comment.  Remove objfile
10449         parameter.
10450         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10451
10452 2019-01-10  Tom Tromey  <tom@tromey.com>
10453
10454         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10455         <free_psymtabs>: Now private.
10456         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10457         (allocate_psymtab): Use new method.
10458
10459 2019-01-10  Tom Tromey  <tom@tromey.com>
10460
10461         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10462         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10463         * mdebugread.c (parse_partial_symbols): Use
10464         allocate_dependencies.
10465         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10466         allocate_dependencies.
10467         (process_psymtab_comp_unit_reader)
10468         (build_type_psymtab_dependencies): Likewise.
10469         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10470
10471 2019-01-10  Tom Tromey  <tom@tromey.com>
10472
10473         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10474         PSYMBOL_SET_LANGUAGE.
10475         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10476
10477 2019-01-10  Tom Tromey  <tom@tromey.com>
10478
10479         * psymtab.h (psymtab_storage::obstack): New method.
10480         <m_obstack>: Rename from obstack; now private.
10481         * psymtab.c (psymtab_storage): Update.
10482         * dwarf2read.c (create_addrmap_from_index)
10483         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10484         Update.
10485
10486 2019-01-10  Tom Tromey  <tom@tromey.com>
10487
10488         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10489         * objfiles.h (objfile::reset_psymtabs): New method.
10490
10491 2019-01-10  Tom Tromey  <tom@tromey.com>
10492
10493         * symmisc.c (print_symbol_bcache_statistics): Update.
10494         (print_objfile_statistics): Update.
10495         * symfile.c (reread_symbols): Update.
10496         * psymtab.h (class psymtab_storage): New.
10497         * psymtab.c (psymtab_storage): New constructor.
10498         (~psymtab_storage): New destructor.
10499         (require_partial_symbols): Update.
10500         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10501         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10502         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10503         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10504         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10505         (start_psymtab_common, end_psymtab_common)
10506         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10507         (allocate_psymtab): Update.
10508         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10509         Update.
10510         (dump_psymtab_addrmap, maintenance_print_psymbols)
10511         (maintenance_check_psymtabs): Update.
10512         (class objfile_psymtabs): Move to objfiles.h.
10513         * psympriv.h (discard_psymtab): Now inline.
10514         (psymtab_discarder::psymtab_discarder): Update.
10515         (psymtab_discarder::~psymtab_discarder): Update.
10516         (ALL_OBJFILE_PSYMTABS): Rewrite.
10517         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10518         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10519         Remove fields.
10520         <partial_symtabs>: New field.
10521         (class objfile_psymtabs): Move from psymtab.h.  Update.
10522         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10523         psymbol_cache.
10524         (objfile::~objfile): Don't destroy psymbol_cache.
10525         * mdebugread.c (parse_partial_symbols): Update.
10526         * dwarf2read.c (create_addrmap_from_index)
10527         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10528         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10529         (add_partial_subprogram, dwarf2_ranges_read): Update.
10530         * dwarf-index-write.c (write_address_map)
10531         (write_one_signatured_type, recursively_write_psymbols)
10532         (class debug_names, class debug_names, write_psymtabs_to_index):
10533         Update.
10534
10535 2019-01-10  Tom Tromey  <tom@tromey.com>
10536
10537         * symtab.h (SYMBOL_SET_NAMES): Update.
10538         (symbol_set_names): Update.
10539         (MSYMBOL_SET_NAMES): Update.
10540         * symtab.c (symbol_set_names): Change argument to be an
10541         objfile_per_bfd_storage.
10542         * psymtab.c (add_psymbol_to_bcache): Update.
10543         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10544
10545 2019-01-10  Tom Tromey  <tom@tromey.com>
10546
10547         * symtab.c (create_demangled_names_hash): Change argument to be an
10548         objfile_per_bfd_storage.
10549         (symbol_set_names): Update.
10550
10551 2019-01-10  Tom Tromey  <tom@tromey.com>
10552
10553         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10554         init_psymbol_list.
10555         * psymtab.c (init_psymbol_list): Do nothing if already called.
10556         * psympriv.h (init_psymbol_list): Add comment.
10557         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10558         init_psymbol_list.
10559         * dbxread.c (dbx_symfile_read): Unconditionally call
10560         init_psymbol_list.
10561
10562 2019-01-10  Tom Tromey  <tom@tromey.com>
10563
10564         * xcoffread.c (scan_xcoff_symtab): Update.
10565         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10566         "where".
10567         * mdebugread.c (parse_partial_symbols)
10568         (handle_psymbol_enumerators): Update.
10569         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10570         * dbxread.c (read_dbx_symtab): Update.
10571         * psympriv.h (psymbol_placement): New enum.
10572         (add_psymbol_to_list): Update.
10573
10574 2019-01-10  Tom Tromey  <tom@tromey.com>
10575
10576         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10577         static_psymbols parameters.
10578         (scan_xcoff_symtab): Update.
10579         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10580         static_psymbols parameters.
10581         * psympriv.h (start_psymtab_common): Update.
10582         * mdebugread.c (parse_partial_symbols): Update.
10583         * dwarf2read.c (create_partial_symtab): Update.
10584         * dbxread.c (read_dbx_symtab): Update.
10585         (start_psymtab): Remove global_psymbols and static_psymbols
10586         parameters.
10587
10588 2019-01-10  Tom Tromey  <tom@tromey.com>
10589
10590         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10591         * psymtab.c (allocate_psymtab): Add comment.
10592         * psympriv.h (allocate_psymtab): Add comment.
10593         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10594         initializations.
10595         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10596
10597 2019-01-10  Tom Tromey  <tom@tromey.com>
10598
10599         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10600         Don't declare.
10601         * mipsread.c: Include mdebugread.h.
10602         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10603         Declare.
10604         * elfread.c: Include mdebugread.h.
10605
10606 2019-01-09  Tom Tromey  <tom@tromey.com>
10607
10608         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10609         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10610         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10611         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10612         (psym_lookup_symbol, psym_find_last_source_symtab)
10613         (psym_forget_cached_source_info, psym_print_stats)
10614         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10615         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10616         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10617         (psym_find_compunit_symtab_by_address)
10618         (maintenance_print_psymbols, maintenance_info_psymtabs)
10619         (maintenance_check_psymtabs): Use ranged for.
10620         * psymtab.h (class objfile_psymtabs): New.
10621         (require_partial_symbols): Return objfile_psymtabs.
10622         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10623
10624 2019-01-09  Tom Tromey  <tom@tromey.com>
10625
10626         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10627         (find_pc_mapped_section, list_overlays_command)
10628         (map_overlay_command, unmap_overlay_command)
10629         (simple_overlay_update): Use all_objfiles.
10630         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10631         * printcmd.c (info_symbol_command): Use all_objfiles.
10632         * objfiles.h (ALL_OBJSECTIONS): Remove.
10633         * maint.c (maintenance_translate_address): Use all_objfiles.
10634         * gcore.c (gcore_create_callback): Use all_objfiles.
10635         (objfile_find_memory_regions): Likewise.
10636
10637 2019-01-09  Tom Tromey  <tom@tromey.com>
10638
10639         * symtab.c (find_line_symtab, info_sources_command)
10640         (make_source_files_completion_list): Use objfile_compunits.
10641         * source.c (select_source_symtab): Use objfile_compunits.
10642         * objfiles.h (struct objfile): Update comment.
10643         (ALL_OBJFILES): Remove.
10644         (ALL_FILETABS): Remove.
10645         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10646         objfile_compunits.
10647
10648 2019-01-09  Tom Tromey  <tom@tromey.com>
10649
10650         * symmisc.c (print_objfile_statistics, dump_objfile)
10651         (maintenance_print_symbols): Use compunit_filetabs.
10652         * source.c (forget_cached_source_info_for_objfile): Use
10653         compunit_filetabs.
10654         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10655         (ALL_FILETABS): Use compunit_filetabs.
10656         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10657         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10658
10659 2019-01-09  Tom Tromey  <tom@tromey.com>
10660
10661         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10662         (compunit_filetabs): New.
10663         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10664         compunit_filetabs.
10665         (info_sources_command, make_source_files_completion_list): Remove
10666         declaration.
10667         * symmisc.c (print_objfile_statistics, dump_objfile)
10668         (maintenance_print_symbols): Remove declaration.
10669         (maintenance_info_symtabs): Use compunit_filetabs.
10670         (maintenance_info_line_tables): Likewise.
10671         * source.c (select_source_symtab): Change local variable name.
10672         (forget_cached_source_info_for_objfile): Remove declaration.
10673         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10674         * objfiles.c (objfile_relocate1): Remove declaration.
10675         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10676         declaration.
10677         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10678         * coffread.c (coff_symtab_read): Remove declaration.
10679         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10680         compunit_filetabs.
10681
10682 2019-01-09  Tom Tromey  <tom@tromey.com>
10683
10684         * symtab.c (lookup_objfile_from_block)
10685         (find_pc_sect_compunit_symtab, search_symbols)
10686         (default_collect_symbol_completion_matches_break_on): Use
10687         objfile_compunits.
10688         * objfiles.h (ALL_COMPUNITS): Remove.
10689         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10690         * cp-support.c (add_symbol_overload_list_qualified): Use
10691         objfile_compunits.
10692         * ada-lang.c (ada_collect_symbol_completion_matches)
10693         (ada_add_global_exceptions): Use objfile_compunits.
10694
10695 2019-01-09  Tom Tromey  <tom@tromey.com>
10696
10697         * source.c (select_source_symtab)
10698         (forget_cached_source_info_for_objfile): Remove declaration.
10699         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10700         declaration.
10701         * maint.c (count_symtabs_and_blocks): Remove declaration.
10702         * cp-support.c (add_symbol_overload_list_qualified): Remove
10703         declaration.
10704         * coffread.c (coff_symtab_read): Remove declaration.
10705         * symtab.c (lookup_symbol_in_objfile_symtabs)
10706         (basic_lookup_transparent_type_1): Use objfile_compunits.
10707         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10708         (info_sources_command, search_symbols)
10709         (default_collect_symbol_completion_matches_break_on)
10710         (make_source_files_completion_list): Remove declaration.
10711         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10712         (ada_collect_symbol_completion_matches)
10713         (ada_add_global_exceptions): Remove declaration.
10714         * linespec.c (iterate_over_all_matching_symtabs): Use
10715         objfile_compunits.
10716         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10717         (class objfile_compunits): New.
10718         (ALL_COMPUNITS): Use objfile_compunits.
10719         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10720         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10721         objfile_compunits.
10722         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10723
10724 2019-01-09  Tom Tromey  <tom@tromey.com>
10725
10726         * symtab.c (search_symbols)
10727         (default_collect_symbol_completion_matches_break_on): Use
10728         objfile_msymbols.
10729         * ada-lang.c (ada_lookup_simple_minsym)
10730         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10731         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10732         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10733         objfile_msymbols.
10734         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10735         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10736         * objc-lang.c (find_methods): Use objfile_msymbols.
10737         (info_selectors_command, info_classes_command): Likewise.
10738         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10739         * objfiles.h (class objfile_msymbols): New.
10740         (ALL_OBJFILE_MSYMBOLS): Remove.
10741         (ALL_MSYMBOLS): Remove.
10742
10743 2019-01-09  Tom Tromey  <tom@tromey.com>
10744
10745         * common/next-iterator.h (next_adapter): Add Iterator template
10746         parameter.
10747         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10748         (class all_objfiles_safe): New.
10749         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10750         * objfiles.c (put_objfile_before): Update comment.
10751         (add_separate_debug_objfile): Likewise.
10752         (free_all_objfiles): Use all_objfiles_safe.
10753         (objfile_purge_solibs): Likewise.
10754
10755 2019-01-09  Tom Tromey  <tom@tromey.com>
10756
10757         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10758         (expand_symtab_containing_pc, lookup_static_symbol)
10759         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10760         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10761         all_objfiles.
10762         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10763         * breakpoint.c (create_overlay_event_breakpoint)
10764         (create_longjmp_master_breakpoint)
10765         (create_std_terminate_master_breakpoint)
10766         (create_exception_master_breakpoint): Use all_objfiles.
10767         * linux-thread-db.c (try_thread_db_load_from_pdir)
10768         (has_libpthread): Use all_objfiles.
10769         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10770         * linespec.c (iterate_over_all_matching_symtabs)
10771         (search_minsyms_for_name): Use all_objfiles.
10772         * maint.c (maintenance_info_sections): Use all_objfiles.
10773         * main.c (captured_main_1): Use all_objfiles.
10774         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10775         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10776         * guile/scm-pretty-print.c
10777         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10778         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10779         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10780         (maintenance_print_msymbols): Use all_objfiles.
10781         * source.c (select_source_symtab): Use all_objfiles.
10782         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10783         * symfile.c (remove_symbol_file_command)
10784         (expand_symtabs_matching, map_symbol_filenames): Use
10785         all_objfiles.
10786         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10787         all_objfiles.
10788         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10789         * objc-lang.c (find_methods): Use all_objfiles.
10790         * objfiles.c (have_partial_symbols, have_full_symbols)
10791         (have_minimal_symbols, qsort_cmp)
10792         (default_iterate_over_objfiles_in_search_order): Use
10793         all_objfiles.
10794         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10795         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10796         (maintenance_check_psymtabs): Use all_objfiles.
10797         (ALL_PSYMTABS): Remove.
10798         * compile/compile-object-run.c (do_module_cleanup): Use
10799         all_objfiles.
10800         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10801         * cp-support.c (add_symbol_overload_list_qualified): Use
10802         all_objfiles.
10803         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10804         Use all_objfiles.
10805         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10806         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10807         all_objfiles.
10808         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10809         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10810         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10811         Uses all_objfiles.
10812         * solib.c (solib_read_symbols): Use all_objfiles
10813
10814 2019-01-09  Tom Tromey  <tom@tromey.com>
10815
10816         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10817         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10818         all_objfiles.
10819         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10820         * symmisc.c (print_symbol_bcache_statistics)
10821         (print_objfile_statistics, maintenance_print_objfiles)
10822         (maintenance_info_symtabs, maintenance_check_symtabs)
10823         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10824         all_objfiles.
10825         * source.c (forget_cached_source_info): Use all_objfiles.
10826         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10827         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10828         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10829         * objfiles.c (update_section_map): Use all_objfiles.
10830         (shared_objfile_contains_address_p): Likewise.
10831         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10832         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10833
10834 2019-01-09  Tom Tromey  <tom@tromey.com>
10835
10836         * common/next-iterator.h: New file.
10837         * objfiles.h (class all_objfiles): New.
10838         (struct objfile_iterator): New.
10839
10840 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10841
10842         * NEWS: Move the description of the changed "frame", "select-frame",
10843          and "info frame" commands to the Changed commands section.
10844
10845 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10846
10847         * gdbtypes.c (check_stub_method_group): Remove handling of old
10848         mangling schemes.
10849         * linespec.c (find_methods): Likewise.
10850         * stabsread.c (read_member_functions): Likewise.
10851         * valops.c (search_struct_method): Likewise.
10852         (value_struct_elt_for_reference): Likewise.
10853         * NEWS: Mention this change.
10854
10855 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10856
10857         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10858         print_source_lines.
10859         * source.c (print_source_lines_base): Update line number check.
10860         (print_source_lines): New function.
10861         (source_lines_range::source_lines_range): New function.
10862         * source.h (class source_lines_range): New class.
10863         (print_source_lines): New declaration.
10864
10865 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10866
10867         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10868
10869 2019-01-08  Tom Tromey  <tom@tromey.com>
10870             Simon Marchi  <simon.marchi@ericsson.com>
10871
10872         PR gdb/24060
10873         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10874         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10875         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10876         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10877         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10878         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10879
10880 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10881
10882         * source.c (select_source_symtab): Move header comment to
10883         declaration in source.h.
10884         (forget_cached_source_info_for_objfile): Likewise.
10885         (forget_cached_source_info): Likewise.
10886         (identify_source_line): Likewise.
10887         * source.h (identify_source_line): Move declaration from symtab.h
10888         and add comment from source.c
10889         (print_source_lines): Likewise.
10890         (forget_cached_source_info_for_objfile): Likewise.
10891         (forget_cached_source_info): Likewise.
10892         (select_source_symtab): Likewise.
10893         (enum print_source_lines_flag): Move definition from symtab.h.
10894         * symtab.h (identify_source_line): Move declaration to source.h.
10895         (print_source_lines): Likewise.
10896         (forget_cached_source_info_for_objfile): Likewise.
10897         (forget_cached_source_info): Likewise.
10898         (select_source_symtab): Likewise.
10899         (enum print_source_lines_flag): Move definition to source.h.
10900         * tui/tui-hooks.c: Add 'source.h' include.
10901
10902 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10903
10904         * source.c (print_source_lines_base): Handle requests to print
10905         reverse line number sequences, and guard against empty lines
10906         string.
10907
10908 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10909
10910         * source.c (print_source_lines_base): Fix skip of '\r' if next
10911         character is '\n'.
10912
10913 2019-01-06  Tom Tromey  <tom@tromey.com>
10914
10915         * c-exp.y (struct c_parse_state) <macro_original_text,
10916         expansion_obstack>: New member.
10917         (macro_original_text, expansion_obstack): Remove globals.
10918         (scan_macro_expansion, scanning_macro_expansion)
10919         (finished_macro_expansion): Update.
10920         (scan_macro_cleanup): Remove.
10921         (yylex, c_parse): Update.
10922
10923 2019-01-06  Tom Tromey  <tom@tromey.com>
10924
10925         * c-exp.y (struct c_parse_state) <strings>: New member.
10926         (operator_stoken): Update.
10927
10928 2019-01-06  Tom Tromey  <tom@tromey.com>
10929
10930         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10931         (union type_stack_elt) <typelist_val>: Now a pointer to
10932         std::vector.
10933         (type_stack_cleanup): Don't declare.
10934         (push_typelist): Update.
10935         * parse.c (pop_typelist): Return a std::vector.
10936         (push_typelist): Take a std::vector.
10937         (follow_types): Update.  Do not free args.
10938         (type_stack_cleanup): Remove.
10939         * c-exp.y (struct c_parse_state): New.
10940         (cpstate): New global.
10941         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10942         (nonempty_typelist): Update.
10943         (func_mod): Create a new vector.
10944         (c_parse): Create a c_parse_state.
10945         (check_parameter_typelist): Do not delete params.
10946         (function_method): Update.  Do not delete type_list.
10947
10948 2019-01-06  Tom Tromey  <tom@tromey.com>
10949
10950         PR gdb/28155:
10951         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10952         check_typedef.
10953         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10954         (print_return_value): Likewise.
10955
10956 2019-01-05  Tom Tromey  <tom@tromey.com>
10957
10958         * contrib/cleanup_check.py: Remove.
10959         * contrib/gcc-with-excheck: Remove.
10960         * contrib/exsummary.py: Remove.
10961         * contrib/excheck.py: Remove.
10962
10963 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10964
10965         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10966         NULL. Initialize tpprev to NULL instead of assigning it
10967         to NULL on the next statement.
10968         * windows-nat.c (windows_delete_thread): Remove check for
10969         main_thread_id before printing thread exit notifications.
10970         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10971         Remove thread ID check against main_thread_id.
10972         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10973         windows_delete_thread.
10974         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10975
10976 2019-01-04  Tom Tromey  <tom@tromey.com>
10977
10978         * compile/compile.c (_initialize_compile): Use upper case for
10979         metasyntactic variables.
10980         * symmisc.c (_initialize_symmisc): Use upper case for
10981         metasyntactic variables.
10982         * psymtab.c (_initialize_psymtab): Use upper case for
10983         metasyntactic variables.
10984         * demangle.c (demangle_command): Use upper case for metasyntactic
10985         variables.
10986         (_initialize_demangler): Likewise.
10987         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10988         variables.
10989
10990 2019-01-03  Tom Tromey  <tom@tromey.com>
10991
10992         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10993
10994 2019-01-03  Tom Tromey  <tom@tromey.com>
10995
10996         * python/py-symtab.c (salpy_str): Update.
10997         (struct salpy_sal_object) <symtab>: Now a PyObject.
10998         (salpy_dealloc): Update.
10999         (del_objfile_sal): Use gdbpy_ref.
11000
11001 2019-01-03  Tom Tromey  <tom@tromey.com>
11002
11003         * python/py-type.c (convert_field): Use new_reference.  Return
11004         gdbpy_ref.
11005         (make_fielditem): Return gdbpy_ref.
11006         (typy_fields): Update.
11007         (typy_getitem): Update.
11008         (field_name): Return gdbpy_ref.  Use new_reference.
11009         (typy_iterator_iternext): Update.
11010
11011 2019-01-03  Tom Tromey  <tom@tromey.com>
11012
11013         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11014
11015 2019-01-03  Tom Tromey  <tom@tromey.com>
11016
11017         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11018         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11019         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11020         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11021         (pspy_set_type_printers): Likewise.
11022         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11023         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11024         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11025         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11026         (objfpy_set_type_printers): Likewise.
11027
11028 2019-01-03  Tom Tromey  <tom@tromey.com>
11029
11030         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11031         (gdbpy_print_stack): Use gdbpy_err_fetch.
11032         * python/python-internal.h (class gdbpy_err_fetch): New class.
11033         (class gdbpy_enter) <m_error_type, m_error_value,
11034         m_error_traceback>: Remove.
11035         <m_error>: New member.
11036         (gdbpy_exception_to_string): Don't declare.
11037         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11038         * python/py-value.c (convert_value_from_python): Use
11039         gdbpy_err_fetch.
11040         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11041         gdbpy_exception_to_string.
11042         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11043         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11044         gdbpy_err_fetch.
11045
11046 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11047
11048         * linux-nat.c (delete_lwp_cleanup): Delete.
11049         (struct lwp_deleter): New struct.
11050         (lwp_info_up): New typedef.
11051         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11052         lwp_info_up.
11053
11054 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11055
11056         * linux-fork.c (class scoped_switch_fork_info): New class.
11057         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11058
11059 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11060
11061         * valops.c (find_overload_match): Remove use of null_cleanup, and
11062         calls to do_cleanups.
11063
11064 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11065
11066         * compile/compile-cplus-types.c
11067         (compile_cplus_instance::decl_name): Handle changes to
11068         cp_func_name.
11069         * cp-support.c (cp_func_name): Update header comment, update
11070         return type.
11071         * cp-support.h (cp_func_name): Update return type in declaration.
11072         * valops.c (find_overload_match): Move temp_func local to top
11073         level of function and change its type.  Use temp_func to hold and
11074         delete temporary string obtained from cp_func_name.
11075
11076 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11077
11078         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11079         gdb::char_vector, remove cleanup, and update uses of `msg`.
11080
11081 2019-01-03  Jim Wilson  <jimw@sifive.com>
11082
11083         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11084
11085 2019-01-02  Tom Tromey  <tom@tromey.com>
11086
11087         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11088         (tdesc_parse_xml): Remove cleanups.
11089         * target-descriptions.h (make_cleanup_free_target_description):
11090         Don't declare.
11091         (target_desc_deleter): New struct.
11092         (target_desc_up): New typedef.
11093         * target-descriptions.c (target_desc_deleter::operator()): Rename
11094         from free_target_description.
11095         (make_cleanup_free_target_description): Remove.
11096
11097 2019-01-02  Tom Tromey  <tom@tromey.com>
11098
11099         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11100         constructor, destructor.
11101         (linespec_parser): Remove typedef.
11102         (~linespec_parser): Rename from linespec_parser_delete.
11103         (linespec_lex_to_end, linespec_complete_label)
11104         (linespec_complete): Update.
11105         (decode_line_full): Remove cleanups.
11106         (decode_line_1): Update.
11107
11108 2019-01-02  Tom Tromey  <tom@tromey.com>
11109
11110         * python/python-internal.h (inferior_to_inferior_object): Change
11111         return type.
11112         * python/py-exitedevent.c (create_exited_event_object): Update.
11113         * python/py-inferior.c (inferior_to_inferior_object): Return
11114         gdbpy_ref.
11115         (python_new_inferior, python_inferior_deleted)
11116         (thread_to_thread_object, delete_thread_object)
11117         (build_inferior_list, gdbpy_selected_inferior): Update.
11118         * python/py-infthread.c (create_thread_object): Update.  Also fail
11119         if inferior_to_inferior_object fails.
11120
11121 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11122
11123         * inferior.h (class inferior) <displaced_step_state>: New field.
11124         * infrun.h (struct displaced_step_state): Move here from
11125         infrun.c.  Initialize fields, add constructor.
11126         <inf>: Remove field.
11127         <reset>: New method.
11128         * infrun.c (struct displaced_step_inferior_state): Move to
11129         infrun.h.
11130         (displaced_step_inferior_states): Remove.
11131         (get_displaced_stepping_state): Adust.
11132         (displaced_step_in_progress_any_inferior): Adjust.
11133         (displaced_step_in_progress_thread): Adjust.
11134         (displaced_step_in_progress): Adjust.
11135         (add_displaced_stepping_state): Remove.
11136         (get_displaced_step_closure_by_addr): Adjust.
11137         (remove_displaced_stepping_state): Remove.
11138         (infrun_inferior_exit): Call displaced_step_state.reset.
11139         (use_displaced_stepping): Don't check for NULL.
11140         (displaced_step_prepare_throw): Call
11141         get_displaced_stepping_state.
11142         (displaced_step_fixup): Don't check for NULL.
11143         (prepare_for_detach): Don't check for NULL.
11144
11145 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11146
11147         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11148          in case of call that did not complete.
11149
11150 2019-01-02  Andrey Utkin  <autkin@undo.io>
11151
11152         * symfile.c (find_separate_debug_file): Fix search of debug files for
11153         remote debuggee.
11154
11155 2019-01-02  Tom Tromey  <tom@tromey.com>
11156
11157         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11158         indentation.
11159         * python/py-frame.c (frapy_older): Remove cast.
11160         (frapy_newer): Likewise.
11161         * python/py-breakpoint.c (local_setattro): Remove cast.
11162         * python/py-arch.c (archpy_name): Remove local variable.
11163         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11164
11165 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11166
11167         * unittests/basic_string_view/element_access/char/empty.cc:
11168         Fix year range in copyright header.
11169
11170 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11171
11172         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11173         Delete.
11174         <operator==>: Update with for removed field.
11175         <hash>: Likewise.
11176         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11177         <isa_features>: ...this.
11178         <abi_features>: New field.
11179         (riscv_isa_flen): Update comment.
11180         (riscv_abi_xlen): New declaration.
11181         (riscv_abi_flen): New declaration.
11182         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11183         isa_features.
11184         (riscv_abi_xlen): New function.
11185         (riscv_isa_flen): Update to get answer from isa_features.
11186         (riscv_abi_flen): New function.
11187         (riscv_has_fp_abi): Update to get answer from abi_features.
11188         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11189         xlen and flen.
11190         (riscv_call_info) <xlen, flen>: Update comment.
11191         (riscv_call_arg_struct): Remove invalid assertions
11192         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11193         is removed.
11194         (riscv_gdbarch_init): Gather isa features and abi features
11195         separately, ensure both match on the gdbarch when reusing an old
11196         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11197         a target with 64-bit float hardware.
11198
11199 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11200
11201         * source.c (search_command_helper): Stop reverse search
11202         when line 1 has been searched.
11203
11204 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11205
11206         * record-full.c (record_full_base_target::close): Rewrite
11207         record_full_core_buf_list free logic.
11208
11209 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11210
11211         * break-catch-syscall.c (print_one_catch_syscall): xfree
11212         the last text.
11213
11214 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11215
11216         * top.c (print_gdb_version): Update Copyright year in version
11217         message.
11218
11219 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11220
11221         Update copyright year range in all GDB files.
11222
11223 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11224
11225         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11226
11227 For older changes see ChangeLog-2018.
11228 \f
11229 Local Variables:
11230 mode: change-log
11231 left-margin: 8
11232 fill-column: 74
11233 version-control: never
11234 coding: utf-8
11235 End:
11236