[gdb, hurd] Repair build after "Use thread_info and inferior pointers more throughout"
[external/binutils.git] / gdb / ChangeLog
1 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
2
3         * gnu-nat.c (gnu_nat_target::detach): Instead of
4         'detach_inferior (pid)' call
5         'detach_inferior (find_inferior_pid (pid))'.
6
7         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8         'nat/fork-inferior.o'.
9         * gnu-nat.c: #include "nat/fork-inferior.h".
10
11         * gnu-nat.c (gnu_nat_target::detach): Instead of
12         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
13         * gnu-nat.h: #include "inf-child.h".
14         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
15         'i386_gnu_nat_target::fetch_registers'.
16         (gnu_store_registers): Rename/move to
17         'i386_gnu_nat_target::store_registers'.
18
19         * config/i386/nm-i386gnu.h: Don't "#include" any files.
20         * gnu-nat.h (mach_thread_info): New function.
21         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
22
23         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
24
25 2019-02-14  Frederic Konrad  <konrad@adacore.com>
26
27         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
28
29 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
30
31         * windows-nat.c (windows_add_thread): Add new parameter
32         "main_thread_p" with default value set to false.  Update
33         function documentation as well as all callers.
34         (windows_delete_thread): Likewise.
35         (fake_create_process): Update call to windows_add_thread.
36         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
37         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
38         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
39         call to windows_delete_thread.
40
41 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
42
43         * MAINTAINERS: Add Andrew Burgess as global maintainer.
44
45 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
46
47         * symfile.c (find_separate_debug_file): Use canonical path of
48         sysroot with child_path instead of gdb_sysroot if it is valid.
49
50 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
51
52         * symfile.c (find_separate_debug_file): Use child_path to
53         determine if an object file is under a sysroot.
54
55 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
56
57         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
58         unittests/child-path-selftests.c.
59         * common/pathstuff.c (child_path): New function.
60         * common/pathstuff.h (child_path): New prototype.
61         * unittests/child-path-selftests.c: New file.
62
63 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
64
65         * symfile.c (find_separate_debug_file): Look for separate debug
66         files in debug directories under the sysroot.
67
68 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
69
70         * symtab.h (struct minimal_symbol data_p): New const method.
71         (struct minimal_symbol text_p): Likewise.
72         * symtab.c (output_source_filename): Use file name style
73         to print file name.
74         (print_symbol_info): Likewise.
75         (print_msymbol_info): Use address style to print addresses.
76         Use function name style to print executable text symbols.
77         (expand_symtab_containing_pc): Use data_p.
78         (find_pc_sect_compunit_symtab): Likewise.
79
80 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
81
82         * breakpoint.c (describe_other_breakpoints): Use address style
83         to print addresses.
84         (say_where): Likewise.
85
86 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
87
88         * ada-typeprint.c (print_func_type): Print function name
89         style to print function name.
90         * c-typeprint.c (c_print_type_1): Likewise.
91
92 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
93
94         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
95         for execve.
96
97 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
98
99         * c-exp.y (direct_abs_decl): Use emplace_back to record the
100         type_stack.
101
102 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
103
104         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
105         TYPE_CODE_REF types.
106
107 2019-02-08  Jim Wilson  <jimw@sifive.com>
108
109         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
110         (riscv_linux_fregset): New.
111         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
112
113 2019-02-07  Tom Tromey  <tom@tromey.com>
114
115         * thread.c (thread_cancel_execution_command): Update.
116         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
117         methods.
118         (struct thread_fsm_ops): Remove.
119         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
120         (thread_fsm_should_stop, thread_fsm_return_value)
121         (thread_fsm_set_finished, thread_fsm_finished_p)
122         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
123         Don't declare.
124         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
125         * infrun.c (clear_proceed_status_thread)
126         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
127         (print_stop_event): Update.
128         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
129         Add constructor.
130         (step_command_fsm_ops): Remove.
131         (new_step_command_fsm): Remove.
132         (step_1): Update.
133         (step_command_fsm::should_stop): Rename from
134         step_command_fsm_should_stop.
135         (step_command_fsm::clean_up): Rename from
136         step_command_fsm_clean_up.
137         (step_command_fsm::do_async_reply_reason): Rename from
138         step_command_fsm_async_reply_reason.
139         (struct until_next_fsm): Inherit from thread_fsm.  Add
140         constructor.
141         (until_next_fsm_ops): Remove.
142         (new_until_next_fsm): Remove.
143         (until_next_fsm::should_stop): Rename from
144         until_next_fsm_should_stop.
145         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
146         (until_next_fsm::do_async_reply_reason): Rename from
147         until_next_fsm_async_reply_reason.
148         (struct finish_command_fsm): Inherit from thread_fsm.  Add
149         constructor.  Change type of breakpoint.
150         (finish_command_fsm_ops): Remove.
151         (new_finish_command_fsm): Remove.
152         (finish_command_fsm::should_stop): Rename from
153         finish_command_fsm_should_stop.
154         (finish_command_fsm::clean_up): Rename from
155         finish_command_fsm_clean_up.
156         (finish_command_fsm::return_value): Rename from
157         finish_command_fsm_return_value.
158         (finish_command_fsm::do_async_reply_reason): Rename from
159         finish_command_fsm_async_reply_reason.
160         (finish_command): Update.
161         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
162         Add constructor.
163         (call_thread_fsm_ops): Remove.
164         (call_thread_fsm::call_thread_fsm): Rename from
165         new_call_thread_fsm.
166         (call_thread_fsm::should_stop): Rename from
167         call_thread_fsm_should_stop.
168         (call_thread_fsm::should_notify_stop): Rename from
169         call_thread_fsm_should_notify_stop.
170         (run_inferior_call, call_function_by_hand_dummy): Update.
171         * cli/cli-interp.c (should_print_stop_to_console): Update.
172         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
173         Add constructor.  Change type of location_breakpoint,
174         caller_breakpoint.
175         (until_break_fsm_ops): Remove.
176         (new_until_break_fsm): Remove.
177         (until_break_fsm::should_stop): Rename from
178         until_break_fsm_should_stop.
179         (until_break_fsm::clean_up): Rename from
180         until_break_fsm_clean_up.
181         (until_break_fsm::do_async_reply_reason): Rename from
182         until_break_fsm_async_reply_reason.
183         (until_break_command): Update.
184         * thread-fsm.c: Remove.
185         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
186
187 2019-02-07  Tom Tromey  <tom@tromey.com>
188
189         * yy-remap.h: Add include guard.
190         * xtensa-tdep.h: Add include guard.
191         * xcoffread.h: Rename include guard.
192         * varobj-iter.h: Add include guard.
193         * tui/tui.h: Rename include guard.
194         * tui/tui-winsource.h: Rename include guard.
195         * tui/tui-wingeneral.h: Rename include guard.
196         * tui/tui-windata.h: Rename include guard.
197         * tui/tui-win.h: Rename include guard.
198         * tui/tui-stack.h: Rename include guard.
199         * tui/tui-source.h: Rename include guard.
200         * tui/tui-regs.h: Rename include guard.
201         * tui/tui-out.h: Rename include guard.
202         * tui/tui-layout.h: Rename include guard.
203         * tui/tui-io.h: Rename include guard.
204         * tui/tui-hooks.h: Rename include guard.
205         * tui/tui-file.h: Rename include guard.
206         * tui/tui-disasm.h: Rename include guard.
207         * tui/tui-data.h: Rename include guard.
208         * tui/tui-command.h: Rename include guard.
209         * tic6x-tdep.h: Add include guard.
210         * target/waitstatus.h: Rename include guard.
211         * target/wait.h: Rename include guard.
212         * target/target.h: Rename include guard.
213         * target/resume.h: Rename include guard.
214         * target-float.h: Rename include guard.
215         * stabsread.h: Add include guard.
216         * rs6000-tdep.h: Add include guard.
217         * riscv-fbsd-tdep.h: Add include guard.
218         * regformats/regdef.h: Rename include guard.
219         * record.h: Rename include guard.
220         * python/python.h: Rename include guard.
221         * python/python-internal.h: Rename include guard.
222         * python/py-stopevent.h: Rename include guard.
223         * python/py-ref.h: Rename include guard.
224         * python/py-record.h: Rename include guard.
225         * python/py-record-full.h: Rename include guard.
226         * python/py-record-btrace.h: Rename include guard.
227         * python/py-instruction.h: Rename include guard.
228         * python/py-events.h: Rename include guard.
229         * python/py-event.h: Rename include guard.
230         * procfs.h: Add include guard.
231         * proc-utils.h: Add include guard.
232         * p-lang.h: Add include guard.
233         * or1k-tdep.h: Rename include guard.
234         * observable.h: Rename include guard.
235         * nto-tdep.h: Rename include guard.
236         * nat/x86-linux.h: Rename include guard.
237         * nat/x86-linux-dregs.h: Rename include guard.
238         * nat/x86-gcc-cpuid.h: Add include guard.
239         * nat/x86-dregs.h: Rename include guard.
240         * nat/x86-cpuid.h: Rename include guard.
241         * nat/ppc-linux.h: Rename include guard.
242         * nat/mips-linux-watch.h: Rename include guard.
243         * nat/linux-waitpid.h: Rename include guard.
244         * nat/linux-ptrace.h: Rename include guard.
245         * nat/linux-procfs.h: Rename include guard.
246         * nat/linux-osdata.h: Rename include guard.
247         * nat/linux-nat.h: Rename include guard.
248         * nat/linux-namespaces.h: Rename include guard.
249         * nat/linux-btrace.h: Rename include guard.
250         * nat/glibc_thread_db.h: Rename include guard.
251         * nat/gdb_thread_db.h: Rename include guard.
252         * nat/gdb_ptrace.h: Rename include guard.
253         * nat/fork-inferior.h: Rename include guard.
254         * nat/amd64-linux-siginfo.h: Rename include guard.
255         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
256         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
257         * nat/aarch64-linux.h: Rename include guard.
258         * nat/aarch64-linux-hw-point.h: Rename include guard.
259         * mn10300-tdep.h: Add include guard.
260         * mips-linux-tdep.h: Add include guard.
261         * mi/mi-parse.h: Rename include guard.
262         * mi/mi-out.h: Rename include guard.
263         * mi/mi-main.h: Rename include guard.
264         * mi/mi-interp.h: Rename include guard.
265         * mi/mi-getopt.h: Rename include guard.
266         * mi/mi-console.h: Rename include guard.
267         * mi/mi-common.h: Rename include guard.
268         * mi/mi-cmds.h: Rename include guard.
269         * mi/mi-cmd-break.h: Rename include guard.
270         * m2-lang.h: Add include guard.
271         * location.h: Rename include guard.
272         * linux-record.h: Rename include guard.
273         * linux-nat.h: Add include guard.
274         * linux-fork.h: Add include guard.
275         * i386-darwin-tdep.h: Rename include guard.
276         * hppa-linux-offsets.h: Add include guard.
277         * guile/guile.h: Rename include guard.
278         * guile/guile-internal.h: Rename include guard.
279         * gnu-nat.h: Rename include guard.
280         * gdb-stabs.h: Rename include guard.
281         * frv-tdep.h: Add include guard.
282         * f-lang.h: Add include guard.
283         * event-loop.h: Add include guard.
284         * darwin-nat.h: Rename include guard.
285         * cp-abi.h: Rename include guard.
286         * config/sparc/nm-sol2.h: Rename include guard.
287         * config/nm-nto.h: Rename include guard.
288         * config/nm-linux.h: Add include guard.
289         * config/i386/nm-i386gnu.h: Rename include guard.
290         * config/djgpp/nl_types.h: Rename include guard.
291         * config/djgpp/langinfo.h: Rename include guard.
292         * compile/gcc-cp-plugin.h: Add include guard.
293         * compile/gcc-c-plugin.h: Add include guard.
294         * compile/compile.h: Rename include guard.
295         * compile/compile-object-run.h: Rename include guard.
296         * compile/compile-object-load.h: Rename include guard.
297         * compile/compile-internal.h: Rename include guard.
298         * compile/compile-cplus.h: Rename include guard.
299         * compile/compile-c.h: Rename include guard.
300         * common/xml-utils.h: Rename include guard.
301         * common/x86-xstate.h: Rename include guard.
302         * common/version.h: Rename include guard.
303         * common/vec.h: Rename include guard.
304         * common/tdesc.h: Rename include guard.
305         * common/selftest.h: Rename include guard.
306         * common/scoped_restore.h: Rename include guard.
307         * common/scoped_mmap.h: Rename include guard.
308         * common/scoped_fd.h: Rename include guard.
309         * common/safe-iterator.h: Rename include guard.
310         * common/run-time-clock.h: Rename include guard.
311         * common/refcounted-object.h: Rename include guard.
312         * common/queue.h: Rename include guard.
313         * common/ptid.h: Rename include guard.
314         * common/print-utils.h: Rename include guard.
315         * common/preprocessor.h: Rename include guard.
316         * common/pathstuff.h: Rename include guard.
317         * common/observable.h: Rename include guard.
318         * common/netstuff.h: Rename include guard.
319         * common/job-control.h: Rename include guard.
320         * common/host-defs.h: Rename include guard.
321         * common/gdb_wait.h: Rename include guard.
322         * common/gdb_vecs.h: Rename include guard.
323         * common/gdb_unlinker.h: Rename include guard.
324         * common/gdb_unique_ptr.h: Rename include guard.
325         * common/gdb_tilde_expand.h: Rename include guard.
326         * common/gdb_sys_time.h: Rename include guard.
327         * common/gdb_string_view.h: Rename include guard.
328         * common/gdb_splay_tree.h: Rename include guard.
329         * common/gdb_setjmp.h: Rename include guard.
330         * common/gdb_ref_ptr.h: Rename include guard.
331         * common/gdb_optional.h: Rename include guard.
332         * common/gdb_locale.h: Rename include guard.
333         * common/gdb_assert.h: Rename include guard.
334         * common/filtered-iterator.h: Rename include guard.
335         * common/filestuff.h: Rename include guard.
336         * common/fileio.h: Rename include guard.
337         * common/environ.h: Rename include guard.
338         * common/common-utils.h: Rename include guard.
339         * common/common-types.h: Rename include guard.
340         * common/common-regcache.h: Rename include guard.
341         * common/common-inferior.h: Rename include guard.
342         * common/common-gdbthread.h: Rename include guard.
343         * common/common-exceptions.h: Rename include guard.
344         * common/common-defs.h: Rename include guard.
345         * common/common-debug.h: Rename include guard.
346         * common/cleanups.h: Rename include guard.
347         * common/buffer.h: Rename include guard.
348         * common/btrace-common.h: Rename include guard.
349         * common/break-common.h: Rename include guard.
350         * cli/cli-utils.h: Rename include guard.
351         * cli/cli-style.h: Rename include guard.
352         * cli/cli-setshow.h: Rename include guard.
353         * cli/cli-script.h: Rename include guard.
354         * cli/cli-interp.h: Rename include guard.
355         * cli/cli-decode.h: Rename include guard.
356         * cli/cli-cmds.h: Rename include guard.
357         * charset-list.h: Add include guard.
358         * buildsym-legacy.h: Rename include guard.
359         * bfin-tdep.h: Add include guard.
360         * ax.h: Rename include guard.
361         * arm-linux-tdep.h: Add include guard.
362         * arm-fbsd-tdep.h: Add include guard.
363         * arch/xtensa.h: Rename include guard.
364         * arch/tic6x.h: Add include guard.
365         * arch/i386.h: Add include guard.
366         * arch/arm.h: Rename include guard.
367         * arch/arm-linux.h: Rename include guard.
368         * arch/arm-get-next-pcs.h: Rename include guard.
369         * arch/amd64.h: Add include guard.
370         * arch/aarch64-insn.h: Rename include guard.
371         * arch-utils.h: Rename include guard.
372         * annotate.h: Add include guard.
373         * amd64-darwin-tdep.h: Rename include guard.
374         * aarch64-linux-tdep.h: Add include guard.
375         * aarch64-fbsd-tdep.h: Add include guard.
376         * aarch32-linux-nat.h: Add include guard.
377
378 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
379
380         * macrotab.c (macro_define_internal): New function that
381         factorizes macro_define_object_internal and macro_define_function
382         code.
383         (macro_define_object_internal): Use macro_define_internal.
384         (macro_define_function): Likewise.
385
386 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
387
388         * macrocmd.c (extract_identifier): Return
389         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
390         callers.
391
392 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
393
394         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
395
396 2019-02-05  Tom Tromey  <tom@tromey.com>
397
398         * target.c (target_stack::unpush): Move assertion earlier.
399
400 2019-01-30  Tom Tromey  <tom@tromey.com>
401
402         PR python/23615:
403         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
404         (gdbpy_parse_and_eval): Likewise.
405         * python/python-internal.h (gdbpy_allow_threads): New class.
406
407 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
408
409         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
410         (aarch64_fbsd_fpregmap): Move earlier.
411         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
412         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
413         instead of individual calls to trad_frame_set_reg_addr.
414         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
415         earlier.
416         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
417         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
418         instead of individual calls to trad_frame_set_reg_addr.
419
420 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
421
422         * CONTRIBUTE: Replace contribution list with wiki link.
423
424 2019-01-25  Tom Tromey  <tom@tromey.com>
425
426         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
427
428 2019-01-25  Tom Tromey  <tom@tromey.com>
429
430         * xtensa-linux-nat.c: Fix common/ includes.
431         * xml-support.h: Fix common/ includes.
432         * xml-support.c: Fix common/ includes.
433         * x86-linux-nat.c: Fix common/ includes.
434         * windows-nat.c: Fix common/ includes.
435         * varobj.h: Fix common/ includes.
436         * varobj.c: Fix common/ includes.
437         * value.c: Fix common/ includes.
438         * valops.c: Fix common/ includes.
439         * utils.c: Fix common/ includes.
440         * unittests/xml-utils-selftests.c: Fix common/ includes.
441         * unittests/utils-selftests.c: Fix common/ includes.
442         * unittests/unpack-selftests.c: Fix common/ includes.
443         * unittests/tracepoint-selftests.c: Fix common/ includes.
444         * unittests/style-selftests.c: Fix common/ includes.
445         * unittests/string_view-selftests.c: Fix common/ includes.
446         * unittests/scoped_restore-selftests.c: Fix common/ includes.
447         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
448         * unittests/scoped_fd-selftests.c: Fix common/ includes.
449         * unittests/rsp-low-selftests.c: Fix common/ includes.
450         * unittests/parse-connection-spec-selftests.c: Fix common/
451         includes.
452         * unittests/optional-selftests.c: Fix common/ includes.
453         * unittests/offset-type-selftests.c: Fix common/ includes.
454         * unittests/observable-selftests.c: Fix common/ includes.
455         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
456         * unittests/memrange-selftests.c: Fix common/ includes.
457         * unittests/memory-map-selftests.c: Fix common/ includes.
458         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
459         * unittests/function-view-selftests.c: Fix common/ includes.
460         * unittests/environ-selftests.c: Fix common/ includes.
461         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
462         * unittests/common-utils-selftests.c: Fix common/ includes.
463         * unittests/cli-utils-selftests.c: Fix common/ includes.
464         * unittests/array-view-selftests.c: Fix common/ includes.
465         * ui-file.c: Fix common/ includes.
466         * tui/tui-io.c: Fix common/ includes.
467         * tracepoint.h: Fix common/ includes.
468         * tracepoint.c: Fix common/ includes.
469         * tracefile-tfile.c: Fix common/ includes.
470         * top.h: Fix common/ includes.
471         * top.c: Fix common/ includes.
472         * thread.c: Fix common/ includes.
473         * target/waitstatus.h: Fix common/ includes.
474         * target/waitstatus.c: Fix common/ includes.
475         * target.h: Fix common/ includes.
476         * target.c: Fix common/ includes.
477         * target-memory.c: Fix common/ includes.
478         * target-descriptions.c: Fix common/ includes.
479         * symtab.h: Fix common/ includes.
480         * symfile.c: Fix common/ includes.
481         * stap-probe.c: Fix common/ includes.
482         * spu-linux-nat.c: Fix common/ includes.
483         * sparc-nat.c: Fix common/ includes.
484         * source.c: Fix common/ includes.
485         * solib.c: Fix common/ includes.
486         * solib-target.c: Fix common/ includes.
487         * ser-unix.c: Fix common/ includes.
488         * ser-tcp.c: Fix common/ includes.
489         * ser-pipe.c: Fix common/ includes.
490         * ser-base.c: Fix common/ includes.
491         * selftest-arch.c: Fix common/ includes.
492         * s12z-tdep.c: Fix common/ includes.
493         * rust-exp.y: Fix common/ includes.
494         * rs6000-aix-tdep.c: Fix common/ includes.
495         * riscv-tdep.c: Fix common/ includes.
496         * remote.c: Fix common/ includes.
497         * remote-notif.h: Fix common/ includes.
498         * remote-fileio.h: Fix common/ includes.
499         * remote-fileio.c: Fix common/ includes.
500         * regcache.h: Fix common/ includes.
501         * regcache.c: Fix common/ includes.
502         * record-btrace.c: Fix common/ includes.
503         * python/python.c: Fix common/ includes.
504         * python/py-type.c: Fix common/ includes.
505         * python/py-inferior.c: Fix common/ includes.
506         * progspace.h: Fix common/ includes.
507         * producer.c: Fix common/ includes.
508         * procfs.c: Fix common/ includes.
509         * proc-api.c: Fix common/ includes.
510         * printcmd.c: Fix common/ includes.
511         * ppc-linux-nat.c: Fix common/ includes.
512         * parser-defs.h: Fix common/ includes.
513         * osdata.c: Fix common/ includes.
514         * obsd-nat.c: Fix common/ includes.
515         * nat/x86-linux.c: Fix common/ includes.
516         * nat/x86-linux-dregs.c: Fix common/ includes.
517         * nat/x86-dregs.h: Fix common/ includes.
518         * nat/x86-dregs.c: Fix common/ includes.
519         * nat/ppc-linux.c: Fix common/ includes.
520         * nat/mips-linux-watch.h: Fix common/ includes.
521         * nat/mips-linux-watch.c: Fix common/ includes.
522         * nat/linux-waitpid.c: Fix common/ includes.
523         * nat/linux-ptrace.h: Fix common/ includes.
524         * nat/linux-ptrace.c: Fix common/ includes.
525         * nat/linux-procfs.c: Fix common/ includes.
526         * nat/linux-personality.c: Fix common/ includes.
527         * nat/linux-osdata.c: Fix common/ includes.
528         * nat/linux-namespaces.c: Fix common/ includes.
529         * nat/linux-btrace.h: Fix common/ includes.
530         * nat/linux-btrace.c: Fix common/ includes.
531         * nat/fork-inferior.c: Fix common/ includes.
532         * nat/amd64-linux-siginfo.c: Fix common/ includes.
533         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
534         * nat/aarch64-linux.c: Fix common/ includes.
535         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
536         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
537         * namespace.h: Fix common/ includes.
538         * mips-linux-tdep.c: Fix common/ includes.
539         * minsyms.c: Fix common/ includes.
540         * mi/mi-parse.h: Fix common/ includes.
541         * mi/mi-main.c: Fix common/ includes.
542         * mi/mi-cmd-env.c: Fix common/ includes.
543         * memrange.h: Fix common/ includes.
544         * memattr.c: Fix common/ includes.
545         * maint.h: Fix common/ includes.
546         * maint.c: Fix common/ includes.
547         * main.c: Fix common/ includes.
548         * machoread.c: Fix common/ includes.
549         * location.c: Fix common/ includes.
550         * linux-thread-db.c: Fix common/ includes.
551         * linux-nat.c: Fix common/ includes.
552         * linux-fork.c: Fix common/ includes.
553         * inline-frame.c: Fix common/ includes.
554         * infrun.c: Fix common/ includes.
555         * inflow.c: Fix common/ includes.
556         * inferior.h: Fix common/ includes.
557         * inferior.c: Fix common/ includes.
558         * infcmd.c: Fix common/ includes.
559         * inf-ptrace.c: Fix common/ includes.
560         * inf-child.c: Fix common/ includes.
561         * ia64-linux-nat.c: Fix common/ includes.
562         * i387-tdep.c: Fix common/ includes.
563         * i386-tdep.c: Fix common/ includes.
564         * i386-linux-tdep.c: Fix common/ includes.
565         * i386-linux-nat.c: Fix common/ includes.
566         * i386-go32-tdep.c: Fix common/ includes.
567         * i386-fbsd-tdep.c: Fix common/ includes.
568         * i386-fbsd-nat.c: Fix common/ includes.
569         * guile/scm-type.c: Fix common/ includes.
570         * guile/guile.c: Fix common/ includes.
571         * go32-nat.c: Fix common/ includes.
572         * gnu-nat.c: Fix common/ includes.
573         * gdbthread.h: Fix common/ includes.
574         * gdbarch-selftests.c: Fix common/ includes.
575         * gdb_usleep.c: Fix common/ includes.
576         * gdb_select.h: Fix common/ includes.
577         * gdb_bfd.c: Fix common/ includes.
578         * gcore.c: Fix common/ includes.
579         * fork-child.c: Fix common/ includes.
580         * findvar.c: Fix common/ includes.
581         * fbsd-nat.c: Fix common/ includes.
582         * event-top.c: Fix common/ includes.
583         * event-loop.c: Fix common/ includes.
584         * dwarf2read.c: Fix common/ includes.
585         * dwarf2loc.c: Fix common/ includes.
586         * dwarf2-frame.c: Fix common/ includes.
587         * dwarf-index-cache.c: Fix common/ includes.
588         * dtrace-probe.c: Fix common/ includes.
589         * disasm-selftests.c: Fix common/ includes.
590         * defs.h: Fix common/ includes.
591         * csky-tdep.c: Fix common/ includes.
592         * cp-valprint.c: Fix common/ includes.
593         * cp-support.h: Fix common/ includes.
594         * cp-support.c: Fix common/ includes.
595         * corelow.c: Fix common/ includes.
596         * completer.h: Fix common/ includes.
597         * completer.c: Fix common/ includes.
598         * compile/compile.c: Fix common/ includes.
599         * compile/compile-loc2c.c: Fix common/ includes.
600         * compile/compile-cplus-types.c: Fix common/ includes.
601         * compile/compile-cplus-symbols.c: Fix common/ includes.
602         * command.h: Fix common/ includes.
603         * cli/cli-dump.c: Fix common/ includes.
604         * cli/cli-cmds.c: Fix common/ includes.
605         * charset.c: Fix common/ includes.
606         * build-id.c: Fix common/ includes.
607         * btrace.h: Fix common/ includes.
608         * btrace.c: Fix common/ includes.
609         * breakpoint.h: Fix common/ includes.
610         * breakpoint.c: Fix common/ includes.
611         * ax.h: 
612         (enum agent_op): Fix common/ includes.
613         * ax-general.c (struct aop_map): Fix common/ includes.
614         * ax-gdb.c: Fix common/ includes.
615         * auxv.c: Fix common/ includes.
616         * auto-load.c: Fix common/ includes.
617         * arm-tdep.c: Fix common/ includes.
618         * arch/riscv.c: Fix common/ includes.
619         * arch/ppc-linux-common.c: Fix common/ includes.
620         * arch/i386.c: Fix common/ includes.
621         * arch/arm.c: Fix common/ includes.
622         * arch/arm-linux.c: Fix common/ includes.
623         * arch/arm-get-next-pcs.c: Fix common/ includes.
624         * arch/amd64.c: Fix common/ includes.
625         * arch/aarch64.c: Fix common/ includes.
626         * arch/aarch64-insn.c: Fix common/ includes.
627         * arch-utils.c: Fix common/ includes.
628         * amd64-windows-tdep.c: Fix common/ includes.
629         * amd64-tdep.c: Fix common/ includes.
630         * amd64-sol2-tdep.c: Fix common/ includes.
631         * amd64-obsd-tdep.c: Fix common/ includes.
632         * amd64-nbsd-tdep.c: Fix common/ includes.
633         * amd64-linux-tdep.c: Fix common/ includes.
634         * amd64-linux-nat.c: Fix common/ includes.
635         * amd64-fbsd-tdep.c: Fix common/ includes.
636         * amd64-fbsd-nat.c: Fix common/ includes.
637         * amd64-dicos-tdep.c: Fix common/ includes.
638         * amd64-darwin-tdep.c: Fix common/ includes.
639         * agent.c: Fix common/ includes.
640         * ada-lang.h: Fix common/ includes.
641         * ada-lang.c: Fix common/ includes.
642         * aarch64-tdep.c: Fix common/ includes.
643
644 2019-01-25  Tom Tromey  <tom@tromey.com>
645
646         * common/create-version.sh: Use common/version.h.
647
648 2019-01-24  Pedro Alves  <palves@redhat.com>
649
650         * infrun.c (signal_stop, signal_print, signal_program)
651         (signal_catch, signal_pass): Now arrays instead of pointers.
652         (update_signals_program_target, do_target_resume)
653         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
654         * linux-nat.c (linux_nat_target::pass_signals)
655         (linux_nat_target::create_inferior, linux_nat_target::attach):
656         Adjust.
657         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
658         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
659         * procfs.c (procfs_target::pass_signals): Adjust.
660         * record-full.c (record_full_target::resume): Adjust.
661         * remote.c (remote_target::pass_signals)
662         (remote_target::program_signals): Adjust.
663         * target-debug.h (target_debug_print_signals): Now takes a
664         gdb::array_view as parameter.  Adjust.
665         * target.h (target_ops) <pass_signals, program_signals>: Replace
666         pointer and length parameters with gdb::array_view.
667         (target_pass_signals, target_program_signals): Likewise.
668         * target-delegates.c: Regenerate.
669
670 2019-01-24  Pedro Alves  <palves@redhat.com>
671
672         * common/forward-scope-exit.h
673         (forward_scope_exit::forward_scope_exit): Pass arguments to
674         m_bind_function directly, instead of creating a std::bind and
675         copying that.
676
677 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
678
679         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
680         for static members.
681         (pass_in_v_vfp_candidate): Likewise.
682
683 2019-01-23  Tom Tromey  <tom@tromey.com>
684             Pedro Alves  <palves@redhat.com>
685
686         * regcache.c (class regcache_invalidator): Remove.
687         (regcache::raw_write): Use make_scope_exit.
688
689 2019-01-23  Tom Tromey  <tom@tromey.com>
690
691         * ui-out.h (class ui_out_emit_type): Update comment.
692
693 2019-01-23  Tom Tromey  <tom@tromey.com>
694
695         * infrun.c (fetch_inferior_event): Update comment.
696
697 2019-01-23  Tom Tromey  <tom@tromey.com>
698             Pedro Alves  <palves@redhat.com>
699
700         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
701         parameter.
702         (fetch_inferior_event): Use SCOPE_EXIT.
703
704
705 2019-01-23  Tom Tromey  <tom@tromey.com>
706             Pedro Alves  <palves@redhat.com>
707
708         * infrun.c (disable_thread_events): Delete.
709         (stop_all_threads): Use SCOPE_EXIT.
710
711 2019-01-23  Tom Tromey  <tom@tromey.com>
712             Pedro Alves  <palves@redhat.com>
713
714         * symfile.c: Include forward-scope-exit.h.
715         (clear_symtab_users_cleanup): Replace forward declaration with
716         a FORWARD_SCOPE_EXIT.
717         (syms_from_objfile_1): Use the forward_scope_exit and
718         gdb::optional instead of cleanup_function.
719         (reread_symbols): Use the forward_scope_exit instead of
720         cleanup_function.
721         (clear_symtab_users_cleanup): Remove function.
722
723 2019-01-23  Tom Tromey  <tom@tromey.com>
724             Pedro Alves  <palves@redhat.com>
725
726         * linux-nat.c: Include scope-exit.h.
727         (cleanup_target_stop): Remove.
728         (linux_nat_target::static_tracepoint_markers_by_strid): Use
729         SCOPE_EXIT.
730
731 2019-01-23  Tom Tromey  <tom@tromey.com>
732             Pedro Alves  <palves@redhat.com>
733
734         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
735         (call_function_by_hand_dummy): Use SCOPE_EXIT.
736
737 2019-01-23  Tom Tromey  <tom@tromey.com>
738             Andrew Burgess  <andrew.burgess@embecosm.com>
739             Pedro Alves  <palves@redhat.com>
740
741         * infrun.c (fetch_inferior_event): Use scope_exit.
742         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
743         * top.c (execute_command): Use scope_exit.
744         * breakpoint.c (bpstat_do_actions): Use scope_exit.
745         * utils.c (do_bpstat_clear_actions_cleanup)
746         (make_bpstat_clear_actions_cleanup): Remove.
747
748 2019-01-23  Tom Tromey  <tom@tromey.com>
749             Pedro Alves  <palves@redhat.com>
750
751         * infrun.c: Include "common/scope-exit.h"
752         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
753         (wait_for_inferior): Use SCOPE_EXIT.
754         (fetch_inferior_event): Use scope_exit.
755
756 2019-01-23  Tom Tromey  <tom@tromey.com>
757             Pedro Alves  <palves@redhat.com>
758
759         * breakpoint.c (create_breakpoint): Remove cleanup.
760
761 2019-01-23  Tom Tromey  <tom@tromey.com>
762             Andrew Burgess  <andrew.burgess@embecosm.com>
763             Pedro Alves  <palves@redhat.com>
764
765 2019-01-23  Pedro Alves  <palves@redhat.com>
766
767         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
768
769 2019-01-23  Pedro Alves  <palves@redhat.com>
770             Andrew Burgess  <andrew.burgess@embecosm.com>
771
772         * gdbthread.h: Include "common/forward-scope-exit.h".
773         (scoped_finish_thread_state): Redefine custom class in terms of
774         forward_scope_exit.
775
776 2019-01-23  Pedro Alves  <palves@redhat.com>
777             Andrew Burgess  <andrew.burgess@embecosm.com>
778
779         * common/forward-scope-exit.h: New file.
780
781 2019-01-23  Pedro Alves  <palves@redhat.com>
782             Andrew Burgess  <andrew.burgess@embecosm.com>
783             Tom Tromey  <tom@tromey.com>
784
785         * common/scope-exit.h: New file.
786
787 2019-01-23  Pedro Alves  <palves@redhat.com>
788
789         * common/preprocessor.h (ESC): Rename to ...
790         (ESC_PARENS): ... this.
791         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
792         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
793
794 2019-01-23  Tom Tromey  <tom@tromey.com>
795
796         * language.h (class scoped_switch_to_sym_language_if_auto):
797         Initialize m_lang in both cases.
798
799 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
800
801         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
802         with XCNEW.
803
804 2019-01-22  Tom Tromey  <tom@tromey.com>
805
806         * corelow.c: Do not include sys/file.h.
807
808 2019-01-22  Tom Tromey  <tom@tromey.com>
809
810         * tui/tui-wingeneral.h: Include gdb_curses.h.
811
812 2019-01-22  Tom Tromey  <tom@tromey.com>
813
814         * source-cache.h (class source_cache) <get_source_lines,
815         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
816
817 2019-01-22  Tom Tromey  <tom@tromey.com>
818
819         * remote-fileio.h (struct remote_target): Declare.
820
821 2019-01-22  Tom Tromey  <tom@tromey.com>
822
823         * python/py-arch.c: Do not include py-ref.h.
824         * python/py-bpevent.c: Do not include py-ref.h.
825         * python/py-cmd.c: Do not include py-ref.h.
826         * python/py-continueevent.c: Do not include py-ref.h.
827         * python/py-event.h: Do not include py-ref.h.
828         * python/py-evtregistry.c: Do not include py-ref.h.
829         * python/py-finishbreakpoint.c: Do not include py-ref.h.
830         * python/py-frame.c: Do not include py-ref.h.
831         * python/py-framefilter.c: Do not include py-ref.h.
832         * python/py-function.c: Do not include py-ref.h.
833         * python/py-infevents.c: Do not include py-ref.h.
834         * python/py-linetable.c: Do not include py-ref.h.
835         * python/py-objfile.c: Do not include py-ref.h.
836         * python/py-param.c: Do not include py-ref.h.
837         * python/py-prettyprint.c: Do not include py-ref.h.
838         * python/py-progspace.c: Do not include py-ref.h.
839         * python/py-symbol.c: Do not include py-ref.h.
840         * python/py-symtab.c: Do not include py-ref.h.
841         * python/py-type.c: Do not include py-ref.h.
842         * python/py-unwind.c: Do not include py-ref.h.
843         * python/py-utils.c: Do not include py-ref.h.
844         * python/py-value.c: Do not include py-ref.h.
845         * python/py-varobj.c: Do not include py-ref.h.
846         * python/py-xmethods.c: Do not include py-ref.h.
847         * python/python.c: Do not include py-ref.h.
848         * varobj.c: Do not include py-ref.h.
849
850 2019-01-22  Tom Tromey  <tom@tromey.com>
851
852         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
853         keyword for bcache.
854
855 2019-01-22  Tom Tromey  <tom@tromey.com>
856
857         * compile/compile-cplus-types.c: Remove a comment by #include.
858
859 2019-01-22  Tom Tromey  <tom@tromey.com>
860
861         * compile/gcc-c-plugin.h: Include compile-internal.h.
862
863 2019-01-22  Tom Tromey  <tom@tromey.com>
864
865         * stabsread.c (EXTERN): Do not define.
866         (symnum, next_symbol_text_func, processing_gcc_compilation)
867         (within_function, global_sym_chain, global_stabs)
868         (previous_stab_code, this_object_header_files)
869         (n_this_object_header_files)
870         (n_allocated_this_object_header_files): Define.
871         * stabsread.h (EXTERN): Never define.  Use "extern".
872
873 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
874
875         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
876         history_value.
877
878 2019-01-21  Tom Tromey  <tom@tromey.com>
879
880         * ui-out.c: Fix includes.
881         * tui/tui-source.c: Fix includes.
882         * target.c: Fix includes.
883         * remote.c: Fix includes.
884         * regcache.c: Fix includes.
885         * python/py-block.c: Fix includes.
886         * printcmd.c: Fix includes.
887         * or1k-tdep.c: Fix includes.
888         * mi/mi-main.c: Fix includes.
889         * m32r-tdep.c: Fix includes.
890         * csky-tdep.c: Fix includes.
891         * compile/compile-cplus-types.c: Fix includes.
892         * cli/cli-interp.c: Fix includes.
893
894 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
895
896         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
897         for padding.
898
899 2019-01-16  Tom Tromey  <tom@tromey.com>
900
901         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
902         earlier.
903         (struct objfile) <msymbols_range>: Move from top level.
904         <msymbols>: New method.
905         (class objfile_msymbols): Remove.
906         * symtab.c (default_collect_symbol_completion_matches_break_on):
907         Update.
908         * symmisc.c (dump_msymbols): Update.
909         * stabsread.c (scan_file_globals): Update.
910         * objc-lang.c (info_selectors_command, info_classes_command)
911         (find_methods): Update.
912         * minsyms.c (find_solib_trampoline_target): Update.
913         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
914         * coffread.c (coff_symfile_read): Update.
915         * ada-lang.c (ada_lookup_simple_minsym)
916         (ada_collect_symbol_completion_matches): Update.
917
918 2019-01-16  Tom Tromey  <tom@tromey.com>
919
920         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
921         type.  Remove no-argument constructor.
922         <iterator::operator++>: Simplify.
923         <begin>: Update.
924         <end>: Use minimal_symbol_count.
925
926 2019-01-16  Tom Tromey  <tom@tromey.com>
927
928         * objfiles.h (struct objfile) <psymtabs>: New method.
929         (class objfile_psymtabs): Remove.
930         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
931         typedef.
932         <range>: New method.
933         (require_partial_symbols): Change return type.
934         * psymtab.c (require_partial_symbols)
935         (psym_expand_symtabs_matching): Update.
936         * mdebugread.c (parse_partial_symbols): Update.
937         * dbxread.c (dbx_end_psymtab): Update.
938
939 2019-01-15  Tom Tromey  <tom@tromey.com>
940
941         * symtab.c (lookup_objfile_from_block)
942         (lookup_symbol_in_objfile_symtabs)
943         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
944         (find_line_symtab, info_sources_command)
945         (default_collect_symbol_completion_matches_break_on)
946         (make_source_files_completion_list): Update.
947         * symmisc.c (print_objfile_statistics, dump_objfile)
948         (maintenance_print_symbols, maintenance_info_symtabs)
949         (maintenance_check_symtabs, maintenance_info_line_tables):
950         Update.
951         * source.c (select_source_symtab)
952         (forget_cached_source_info_for_objfile): Update.
953         * objfiles.h (class objfile_compunits): Remove.
954         (struct objfile) <compunits_range>: New typedef.
955         (compunits): New method.
956         * objfiles.c (objfile_relocate1): Update.
957         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
958         * maint.c (count_symtabs_and_blocks): Update.
959         * linespec.c (iterate_over_all_matching_symtabs): Update.
960         * cp-support.c (add_symbol_overload_list_qualified): Update.
961         * coffread.c (coff_symtab_read): Update.
962         * ada-lang.c (add_nonlocal_symbols)
963         (ada_collect_symbol_completion_matches)
964         (ada_add_global_exceptions): Update.
965
966 2019-01-15  Tom Tromey  <tom@tromey.com>
967
968         * progspace.h (program_space) <objfiles_safe_range>: New
969         typedef.
970         <objfiles_safe>: New method.
971         * objfiles.h (class all_objfiles_safe): Remove.
972         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
973         * jit.c (jit_inferior_exit_hook): Update.
974
975 2019-01-17  Tom Tromey  <tom@tromey.com>
976
977         * progspace.h (program_space) <objfiles_range>: New typedef.
978         <objfiles>: New method.
979         <objfiles_head>: Rename from objfiles.
980         (object_files): Update.
981         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
982         * guile/scm-pretty-print.c
983         (ppscm_find_pretty_printer_from_objfiles): Update.
984         * guile/scm-objfile.c (gdbscm_objfiles): Update.
985         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
986         Update.
987         * python/py-progspace.c (pspy_get_objfiles): Update.
988         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
989         Update.
990         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
991         (objfpy_lookup_objfile_by_build_id): Update.
992         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
993         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
994         Update.
995         * symtab.c (iterate_over_symtabs, matching_obj_sections)
996         (expand_symtab_containing_pc, lookup_objfile_from_block)
997         (lookup_static_symbol, basic_lookup_transparent_type)
998         (find_pc_sect_compunit_symtab, find_symbol_at_address)
999         (find_line_symtab, info_sources_command)
1000         (default_collect_symbol_completion_matches_break_on)
1001         (make_source_files_completion_list, find_main_name): Update.
1002         * symmisc.c (print_symbol_bcache_statistics)
1003         (print_objfile_statistics, maintenance_print_symbols)
1004         (maintenance_print_msymbols, maintenance_print_objfiles)
1005         (maintenance_info_symtabs, maintenance_check_symtabs)
1006         (maintenance_expand_symtabs, maintenance_info_line_tables):
1007         Update.
1008         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1009         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1010         (map_overlay_command, unmap_overlay_command)
1011         (simple_overlay_update, expand_symtabs_matching)
1012         (map_symbol_filenames): Update.
1013         * symfile-debug.c (set_debug_symfile): Update.
1014         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1015         Update.
1016         * source.c (select_source_symtab, forget_cached_source_info):
1017         Update.
1018         * solib.c (solib_read_symbols): Update.
1019         * solib-spu.c (append_ocl_sos): Update.
1020         * psymtab.c (maintenance_print_psymbols)
1021         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1022         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1023         * printcmd.c (info_symbol_command): Update.
1024         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1025         Update.
1026         * objfiles.h (class all_objfiles): Remove.
1027         * objfiles.c (have_partial_symbols, have_full_symbols)
1028         (have_minimal_symbols, qsort_cmp, update_section_map)
1029         (shared_objfile_contains_address_p)
1030         (default_iterate_over_objfiles_in_search_order): Update.
1031         * objc-lang.c (info_selectors_command, info_classes_command)
1032         (find_methods): Update.
1033         * minsyms.c (find_solib_trampoline_target): Update.
1034         * maint.c (maintenance_info_sections)
1035         (maintenance_translate_address, count_symtabs_and_blocks):
1036         Update.
1037         * main.c (captured_main_1): Update.
1038         * linux-thread-db.c (try_thread_db_load_from_pdir)
1039         (has_libpthread): Update.
1040         * linespec.c (iterate_over_all_matching_symtabs)
1041         (search_minsyms_for_name): Update.
1042         * jit.c (jit_find_objf_with_entry_addr): Update.
1043         * hppa-tdep.c (find_unwind_entry)
1044         (hppa_lookup_stub_minimal_symbol): Update.
1045         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1046         Update.
1047         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1048         (elf_gnu_ifunc_resolve_by_got): Update.
1049         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1050         * dwarf-index-write.c (save_gdb_index_command): Update.
1051         * cp-support.c (add_symbol_overload_list_qualified): Update.
1052         * breakpoint.c (create_overlay_event_breakpoint)
1053         (create_longjmp_master_breakpoint)
1054         (create_std_terminate_master_breakpoint)
1055         (create_exception_master_breakpoint): Update.
1056         * blockframe.c (find_pc_partial_function): Update.
1057         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1058         (ada_collect_symbol_completion_matches)
1059         (ada_add_global_exceptions): Update.
1060
1061 2019-01-17  Tom Tromey  <tom@tromey.com>
1062
1063         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1064         declare VEC.
1065         (solib_target_parse_libraries): Change return type.
1066         (library_list_start_segment, library_list_start_section)
1067         (library_list_end_library, library_list_start_library); Update.
1068         (solib_target_free_library_list): Remove.
1069         (solib_target_parse_libraries): Remove cleanup.  Change return
1070         type.
1071         (solib_target_current_sos): Update.
1072
1073 2019-01-17  Tom Tromey  <tromey@bapiya>
1074
1075         * valprint.c: Replace "the the" with "the".
1076         * symtab.c: Replace "the the" with "the".
1077         * solib.c: Replace "the the" with "the".
1078         * solib-dsbt.c: Replace "the the" with "the".
1079         * linespec.c: Replace "the the" with "the".
1080         * dwarf2loc.h: Replace "the the" with "the".
1081         * amd64-windows-tdep.c: Replace "the the" with "the".
1082         * aarch64-tdep.c: Replace "the the" with "the".
1083
1084 2019-01-16  Keith Seitz  <keiths@redhat.com>
1085
1086         PR gdb/23773
1087         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1088         <builder>: Rename to ..
1089         <m_builder>: ... this and make private.
1090         (dwarf2_cu::get_builder): New method.  Change all users of
1091         `builder' to use this method.
1092         (dwarf2_start_symtab): Move to ...
1093         (dwarf2_cu::start_symtab): ... here.  Update all callers
1094         (setup_type_unit_groups): Move to ...
1095         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1096         callers.
1097         (dwarf2_cu::reset_builder): New method.
1098         (process_full_compunit, process_full_type_unit): Use
1099         dwarf2_cu::reset_builder.
1100         (follow_die_offset): Record the ancestor CU if it is different
1101         from the followed DIE's CU.
1102         (follow_die_sig_1): Likewise.
1103
1104 2019-01-15  Tom Tromey  <tom@tromey.com>
1105
1106         * remote.c (class remote_state) <buf>: Now a char_vector.
1107         <buf_size>: Remove.
1108         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1109         parameter.
1110         (remote_target::getpkt_or_notif_sane_1)
1111         (remote_target::getpkt_sane)
1112         (remote_target::getpkt_or_notif_sane): Likewise.
1113         (class remote_target) <putpkt>: New overload.
1114         (remote_target::read_frame): Change type of "buf_p".  Remove
1115         sizeof_p parameter.
1116         (packet_ok): New overload.
1117         (packet_check_result): New overload.
1118         Update all uses.
1119
1120 2019-01-14  Tom Tromey  <tom@tromey.com>
1121
1122         * remote-notif.c (handle_notification, remote_notif_ack)
1123         (remote_notif_parse): Make "buf" const.
1124         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1125         const.
1126         (remote_notif_parse, remote_notif_ack, handle_notification):
1127         Likewise.
1128         * remote.c (remote_notif_stop_parse): Make "buf" const.
1129         (remote_target::remote_parse_stop_reply): Make "buf" const.
1130         (remote_notif_stop_ack): Make "buf" const.
1131
1132 2019-01-14  Tom Tromey  <tom@tromey.com>
1133
1134         * remote.c (remote_console_output): Make parameter const.
1135
1136 2019-01-14  Tom Tromey  <tom@tromey.com>
1137
1138         * target-debug.h (target_debug_print_signals): Constify.
1139         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1140         * procfs.c (procfs_target::pass_signals): Update.
1141         * linux-nat.c (linux_nat_target::pass_signals): Update.
1142         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1143         * target-delegates.c: Rebuild.
1144         * remote.c (remote_target::program_signals): Update.
1145         (remote_target::pass_signals): Update.
1146         * target.c (target_pass_signals): Constify argument.
1147         (target_program_signals): Likewise.
1148         * target.h (struct target_ops) <pass_signals, program_signals>:
1149         Constify argument.
1150         (target_pass_signals, target_program_signals): Constify argument.
1151
1152 2019-01-14  Tom Tromey  <tom@tromey.com>
1153
1154         PR tui/28819:
1155         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1156
1157 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1158
1159         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1160         field.
1161         * rs6000-tdep.c: Include reggroups.h.
1162         (IS_V_ALIAS_PSEUDOREG): Define.
1163         (rs6000_register_name): Return names for the "vX" aliases.
1164         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1165         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1166         aliases.  Call default_register_reggroup_p for all other
1167         pseudo-registers.
1168         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1169         New functions.
1170         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1171         Handle "vX" aliases.
1172         (v_alias_pseudo_register_collect): New function.
1173         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1174         (rs6000_gdbarch_init): Initialize "vX" aliases as
1175         pseudo-registers.  Restore registration of
1176         rs6000_pseudo_register_reggroup_p with
1177         set_tdesc_pseudo_register_reggroup_p.
1178
1179 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1180
1181         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1182         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1183         set_gdbarch_num_pseudo_regs.
1184
1185 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1186
1187         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1188         Remove arg prefixname, add do_set and do_show.
1189         Add member functions set_list and show_list.
1190         * cli/cli-style.c (class cli_style_option): Update accordingly.
1191         (style_set_list): Move to file scope.
1192         (style_show_list): Likewise.
1193         (set_style): Call help_list.
1194         (show_style): Call cmd_show_list.
1195         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1196         Update to use the new macro.
1197
1198 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1199
1200         * ada-lang.c (_initialize_ada_language): Expand the help text
1201         for the "catch exception" command.
1202
1203 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1204
1205         * symtab.c (matching_obj_sections): Initialize obj,
1206         declare it closer to its usage.
1207
1208 2019-01-10  Tom Tromey  <tom@tromey.com>
1209
1210         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1211         (basic_inf_threads_range): Remove.
1212         (inf_threads_range, inf_non_exited_threads_range)
1213         (safe_inf_threads_range): Use next_adapter.
1214
1215 2019-01-10  Keith Seitz  <keiths@redhat.com>
1216
1217         PR gdb/23712
1218         PR symtab/23010
1219         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1220         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1221
1222 2019-01-10  Keith Seitz  <keiths@redhat.com>
1223
1224         PR gdb/23712
1225         PR symtab/23010
1226         * dictionary.c (pending_to_vector): Remove.
1227         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1228         Remove _1 suffix, replacing functions of the same name.  Update
1229         all callers.
1230         (dict_create_hashed, dict_create_hashed_expandable)
1231         (dict_create_linear, dict_create_linear_expandable, dict_free)
1232         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1233         Make functions static.
1234
1235 2019-01-10  Keith Seitz  <keiths@redhat.com>
1236
1237         PR gdb/23712
1238         PR symtab/23010
1239         * dictionary.h (struct dictionary): Replace declaration with
1240         multidictionary.
1241         (dict_create_hashed, dict_create_hashed_expandable)
1242         (dict_create_linear, dict_create_linear_expandable)
1243         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1244         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1245         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1246         taking multidictionary argument.
1247         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1248         * block.h (struct block) <dict>: Change to multidictionary
1249         and rename `multidict'.
1250         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1251         symmisc.c: Update all dictionary references to multidictionary.
1252
1253 2019-01-10  Keith Seitz  <keiths@redhat.com>
1254
1255         PR gdb/23712
1256         PR symtab/23010
1257         * dictionary.c: Include unordered_map.
1258         (pending_to_vector): New function.
1259         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1260         Rewrite the non-"_1" functions to take vector instead
1261         of linked list.
1262         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1263         "new" _1 versions of the same name.
1264         (multidictionary): Define.
1265         (std::hash<enum language): New definition.
1266         (collate_pending_symbols_by_language, mdict_create_hashed)
1267         (mdict_create_hashed_expandable, mdict_create_linear)
1268         (mdict_create_linear_expandable, mdict_free)
1269         (find_language_dictionary, create_new_language_dictionary)
1270         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1271         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1272         (mdict_size, mdict_empty): New functions.
1273         * dictionary.h (mdict_iterator): Define.
1274
1275 2019-01-10  Pedro Alves  <palves@redhat.com>
1276
1277         * breakpoint.c (read_uploaded_action)
1278         (create_tracepoint_from_upload): Adjust to use
1279         gdb::unique_xmalloc_ptr.
1280         * ctf.c (ctf_write_uploaded_tp):
1281         (SET_ARRAY_FIELD): Use emplace_back.
1282         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1283         * tracefile-tfile.c (tfile_write_uploaded_tp):
1284         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1285         gdb::unique_xmalloc_ptr.
1286         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1287         at_string, cond_string, cmd_strings>: Replace char pointers
1288         with gdb::unique_xmalloc_ptr.
1289
1290 2019-01-10  Pedro Alves  <palves@redhat.com>
1291
1292         * solib-target.c (library_list_start_library): Don't xstrdup name.
1293
1294 2019-01-10  Pedro Alves  <palves@redhat.com>
1295
1296         * mdebugread.c (parse_partial_symbols): Use
1297         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1298
1299 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1300
1301         * linux-fork.c (scoped_switch_fork_info)
1302         <~scoped_switch_fork_info>: Fix incorrect variable name.
1303
1304 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1305
1306         * linux-fork.c (scoped_switch_fork_info)
1307         <scoped_switch_fork_info>: Make explicit.
1308         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1309
1310 2019-01-10  Tom Tromey  <tom@tromey.com>
1311
1312         * objfiles.h (objfile::reset_psymtabs): Update.
1313         * objfiles.c (objfile::objfile): Update.
1314         * psymtab.h (psymtab_storage::obstack): Update.
1315         (psymtab_storage::m_obstack): Use gdb::optional.
1316         (class psymtab_storage): Update comment.  Remove objfile
1317         parameter.
1318         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1319
1320 2019-01-10  Tom Tromey  <tom@tromey.com>
1321
1322         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1323         <free_psymtabs>: Now private.
1324         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1325         (allocate_psymtab): Use new method.
1326
1327 2019-01-10  Tom Tromey  <tom@tromey.com>
1328
1329         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1330         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1331         * mdebugread.c (parse_partial_symbols): Use
1332         allocate_dependencies.
1333         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1334         allocate_dependencies.
1335         (process_psymtab_comp_unit_reader)
1336         (build_type_psymtab_dependencies): Likewise.
1337         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1338
1339 2019-01-10  Tom Tromey  <tom@tromey.com>
1340
1341         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1342         PSYMBOL_SET_LANGUAGE.
1343         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1344
1345 2019-01-10  Tom Tromey  <tom@tromey.com>
1346
1347         * psymtab.h (psymtab_storage::obstack): New method.
1348         <m_obstack>: Rename from obstack; now private.
1349         * psymtab.c (psymtab_storage): Update.
1350         * dwarf2read.c (create_addrmap_from_index)
1351         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1352         Update.
1353
1354 2019-01-10  Tom Tromey  <tom@tromey.com>
1355
1356         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1357         * objfiles.h (objfile::reset_psymtabs): New method.
1358
1359 2019-01-10  Tom Tromey  <tom@tromey.com>
1360
1361         * symmisc.c (print_symbol_bcache_statistics): Update.
1362         (print_objfile_statistics): Update.
1363         * symfile.c (reread_symbols): Update.
1364         * psymtab.h (class psymtab_storage): New.
1365         * psymtab.c (psymtab_storage): New constructor.
1366         (~psymtab_storage): New destructor.
1367         (require_partial_symbols): Update.
1368         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1369         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1370         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1371         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1372         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1373         (start_psymtab_common, end_psymtab_common)
1374         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1375         (allocate_psymtab): Update.
1376         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1377         Update.
1378         (dump_psymtab_addrmap, maintenance_print_psymbols)
1379         (maintenance_check_psymtabs): Update.
1380         (class objfile_psymtabs): Move to objfiles.h.
1381         * psympriv.h (discard_psymtab): Now inline.
1382         (psymtab_discarder::psymtab_discarder): Update.
1383         (psymtab_discarder::~psymtab_discarder): Update.
1384         (ALL_OBJFILE_PSYMTABS): Rewrite.
1385         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1386         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1387         Remove fields.
1388         <partial_symtabs>: New field.
1389         (class objfile_psymtabs): Move from psymtab.h.  Update.
1390         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1391         psymbol_cache.
1392         (objfile::~objfile): Don't destroy psymbol_cache.
1393         * mdebugread.c (parse_partial_symbols): Update.
1394         * dwarf2read.c (create_addrmap_from_index)
1395         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1396         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1397         (add_partial_subprogram, dwarf2_ranges_read): Update.
1398         * dwarf-index-write.c (write_address_map)
1399         (write_one_signatured_type, recursively_write_psymbols)
1400         (class debug_names, class debug_names, write_psymtabs_to_index):
1401         Update.
1402
1403 2019-01-10  Tom Tromey  <tom@tromey.com>
1404
1405         * symtab.h (SYMBOL_SET_NAMES): Update.
1406         (symbol_set_names): Update.
1407         (MSYMBOL_SET_NAMES): Update.
1408         * symtab.c (symbol_set_names): Change argument to be an
1409         objfile_per_bfd_storage.
1410         * psymtab.c (add_psymbol_to_bcache): Update.
1411         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1412
1413 2019-01-10  Tom Tromey  <tom@tromey.com>
1414
1415         * symtab.c (create_demangled_names_hash): Change argument to be an
1416         objfile_per_bfd_storage.
1417         (symbol_set_names): Update.
1418
1419 2019-01-10  Tom Tromey  <tom@tromey.com>
1420
1421         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1422         init_psymbol_list.
1423         * psymtab.c (init_psymbol_list): Do nothing if already called.
1424         * psympriv.h (init_psymbol_list): Add comment.
1425         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1426         init_psymbol_list.
1427         * dbxread.c (dbx_symfile_read): Unconditionally call
1428         init_psymbol_list.
1429
1430 2019-01-10  Tom Tromey  <tom@tromey.com>
1431
1432         * xcoffread.c (scan_xcoff_symtab): Update.
1433         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1434         "where".
1435         * mdebugread.c (parse_partial_symbols)
1436         (handle_psymbol_enumerators): Update.
1437         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1438         * dbxread.c (read_dbx_symtab): Update.
1439         * psympriv.h (psymbol_placement): New enum.
1440         (add_psymbol_to_list): Update.
1441
1442 2019-01-10  Tom Tromey  <tom@tromey.com>
1443
1444         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1445         static_psymbols parameters.
1446         (scan_xcoff_symtab): Update.
1447         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1448         static_psymbols parameters.
1449         * psympriv.h (start_psymtab_common): Update.
1450         * mdebugread.c (parse_partial_symbols): Update.
1451         * dwarf2read.c (create_partial_symtab): Update.
1452         * dbxread.c (read_dbx_symtab): Update.
1453         (start_psymtab): Remove global_psymbols and static_psymbols
1454         parameters.
1455
1456 2019-01-10  Tom Tromey  <tom@tromey.com>
1457
1458         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1459         * psymtab.c (allocate_psymtab): Add comment.
1460         * psympriv.h (allocate_psymtab): Add comment.
1461         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1462         initializations.
1463         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1464
1465 2019-01-10  Tom Tromey  <tom@tromey.com>
1466
1467         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1468         Don't declare.
1469         * mipsread.c: Include mdebugread.h.
1470         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1471         Declare.
1472         * elfread.c: Include mdebugread.h.
1473
1474 2019-01-09  Tom Tromey  <tom@tromey.com>
1475
1476         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1477         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1478         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1479         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1480         (psym_lookup_symbol, psym_find_last_source_symtab)
1481         (psym_forget_cached_source_info, psym_print_stats)
1482         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1483         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1484         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1485         (psym_find_compunit_symtab_by_address)
1486         (maintenance_print_psymbols, maintenance_info_psymtabs)
1487         (maintenance_check_psymtabs): Use ranged for.
1488         * psymtab.h (class objfile_psymtabs): New.
1489         (require_partial_symbols): Return objfile_psymtabs.
1490         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1491
1492 2019-01-09  Tom Tromey  <tom@tromey.com>
1493
1494         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1495         (find_pc_mapped_section, list_overlays_command)
1496         (map_overlay_command, unmap_overlay_command)
1497         (simple_overlay_update): Use all_objfiles.
1498         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1499         * printcmd.c (info_symbol_command): Use all_objfiles.
1500         * objfiles.h (ALL_OBJSECTIONS): Remove.
1501         * maint.c (maintenance_translate_address): Use all_objfiles.
1502         * gcore.c (gcore_create_callback): Use all_objfiles.
1503         (objfile_find_memory_regions): Likewise.
1504
1505 2019-01-09  Tom Tromey  <tom@tromey.com>
1506
1507         * symtab.c (find_line_symtab, info_sources_command)
1508         (make_source_files_completion_list): Use objfile_compunits.
1509         * source.c (select_source_symtab): Use objfile_compunits.
1510         * objfiles.h (struct objfile): Update comment.
1511         (ALL_OBJFILES): Remove.
1512         (ALL_FILETABS): Remove.
1513         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1514         objfile_compunits.
1515
1516 2019-01-09  Tom Tromey  <tom@tromey.com>
1517
1518         * symmisc.c (print_objfile_statistics, dump_objfile)
1519         (maintenance_print_symbols): Use compunit_filetabs.
1520         * source.c (forget_cached_source_info_for_objfile): Use
1521         compunit_filetabs.
1522         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1523         (ALL_FILETABS): Use compunit_filetabs.
1524         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1525         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1526
1527 2019-01-09  Tom Tromey  <tom@tromey.com>
1528
1529         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1530         (compunit_filetabs): New.
1531         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1532         compunit_filetabs.
1533         (info_sources_command, make_source_files_completion_list): Remove
1534         declaration.
1535         * symmisc.c (print_objfile_statistics, dump_objfile)
1536         (maintenance_print_symbols): Remove declaration.
1537         (maintenance_info_symtabs): Use compunit_filetabs.
1538         (maintenance_info_line_tables): Likewise.
1539         * source.c (select_source_symtab): Change local variable name.
1540         (forget_cached_source_info_for_objfile): Remove declaration.
1541         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1542         * objfiles.c (objfile_relocate1): Remove declaration.
1543         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1544         declaration.
1545         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1546         * coffread.c (coff_symtab_read): Remove declaration.
1547         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1548         compunit_filetabs.
1549
1550 2019-01-09  Tom Tromey  <tom@tromey.com>
1551
1552         * symtab.c (lookup_objfile_from_block)
1553         (find_pc_sect_compunit_symtab, search_symbols)
1554         (default_collect_symbol_completion_matches_break_on): Use
1555         objfile_compunits.
1556         * objfiles.h (ALL_COMPUNITS): Remove.
1557         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1558         * cp-support.c (add_symbol_overload_list_qualified): Use
1559         objfile_compunits.
1560         * ada-lang.c (ada_collect_symbol_completion_matches)
1561         (ada_add_global_exceptions): Use objfile_compunits.
1562
1563 2019-01-09  Tom Tromey  <tom@tromey.com>
1564
1565         * source.c (select_source_symtab)
1566         (forget_cached_source_info_for_objfile): Remove declaration.
1567         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1568         declaration.
1569         * maint.c (count_symtabs_and_blocks): Remove declaration.
1570         * cp-support.c (add_symbol_overload_list_qualified): Remove
1571         declaration.
1572         * coffread.c (coff_symtab_read): Remove declaration.
1573         * symtab.c (lookup_symbol_in_objfile_symtabs)
1574         (basic_lookup_transparent_type_1): Use objfile_compunits.
1575         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1576         (info_sources_command, search_symbols)
1577         (default_collect_symbol_completion_matches_break_on)
1578         (make_source_files_completion_list): Remove declaration.
1579         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1580         (ada_collect_symbol_completion_matches)
1581         (ada_add_global_exceptions): Remove declaration.
1582         * linespec.c (iterate_over_all_matching_symtabs): Use
1583         objfile_compunits.
1584         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1585         (class objfile_compunits): New.
1586         (ALL_COMPUNITS): Use objfile_compunits.
1587         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1588         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1589         objfile_compunits.
1590         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1591
1592 2019-01-09  Tom Tromey  <tom@tromey.com>
1593
1594         * symtab.c (search_symbols)
1595         (default_collect_symbol_completion_matches_break_on): Use
1596         objfile_msymbols.
1597         * ada-lang.c (ada_lookup_simple_minsym)
1598         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1599         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1600         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1601         objfile_msymbols.
1602         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1603         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1604         * objc-lang.c (find_methods): Use objfile_msymbols.
1605         (info_selectors_command, info_classes_command): Likewise.
1606         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1607         * objfiles.h (class objfile_msymbols): New.
1608         (ALL_OBJFILE_MSYMBOLS): Remove.
1609         (ALL_MSYMBOLS): Remove.
1610
1611 2019-01-09  Tom Tromey  <tom@tromey.com>
1612
1613         * common/next-iterator.h (next_adapter): Add Iterator template
1614         parameter.
1615         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1616         (class all_objfiles_safe): New.
1617         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1618         * objfiles.c (put_objfile_before): Update comment.
1619         (add_separate_debug_objfile): Likewise.
1620         (free_all_objfiles): Use all_objfiles_safe.
1621         (objfile_purge_solibs): Likewise.
1622
1623 2019-01-09  Tom Tromey  <tom@tromey.com>
1624
1625         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1626         (expand_symtab_containing_pc, lookup_static_symbol)
1627         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1628         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1629         all_objfiles.
1630         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1631         * breakpoint.c (create_overlay_event_breakpoint)
1632         (create_longjmp_master_breakpoint)
1633         (create_std_terminate_master_breakpoint)
1634         (create_exception_master_breakpoint): Use all_objfiles.
1635         * linux-thread-db.c (try_thread_db_load_from_pdir)
1636         (has_libpthread): Use all_objfiles.
1637         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1638         * linespec.c (iterate_over_all_matching_symtabs)
1639         (search_minsyms_for_name): Use all_objfiles.
1640         * maint.c (maintenance_info_sections): Use all_objfiles.
1641         * main.c (captured_main_1): Use all_objfiles.
1642         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1643         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1644         * guile/scm-pretty-print.c
1645         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1646         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1647         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1648         (maintenance_print_msymbols): Use all_objfiles.
1649         * source.c (select_source_symtab): Use all_objfiles.
1650         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1651         * symfile.c (remove_symbol_file_command)
1652         (expand_symtabs_matching, map_symbol_filenames): Use
1653         all_objfiles.
1654         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1655         all_objfiles.
1656         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1657         * objc-lang.c (find_methods): Use all_objfiles.
1658         * objfiles.c (have_partial_symbols, have_full_symbols)
1659         (have_minimal_symbols, qsort_cmp)
1660         (default_iterate_over_objfiles_in_search_order): Use
1661         all_objfiles.
1662         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1663         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1664         (maintenance_check_psymtabs): Use all_objfiles.
1665         (ALL_PSYMTABS): Remove.
1666         * compile/compile-object-run.c (do_module_cleanup): Use
1667         all_objfiles.
1668         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1669         * cp-support.c (add_symbol_overload_list_qualified): Use
1670         all_objfiles.
1671         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1672         Use all_objfiles.
1673         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1674         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1675         all_objfiles.
1676         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1677         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1678         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1679         Uses all_objfiles.
1680         * solib.c (solib_read_symbols): Use all_objfiles
1681
1682 2019-01-09  Tom Tromey  <tom@tromey.com>
1683
1684         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1685         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1686         all_objfiles.
1687         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1688         * symmisc.c (print_symbol_bcache_statistics)
1689         (print_objfile_statistics, maintenance_print_objfiles)
1690         (maintenance_info_symtabs, maintenance_check_symtabs)
1691         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1692         all_objfiles.
1693         * source.c (forget_cached_source_info): Use all_objfiles.
1694         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1695         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1696         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1697         * objfiles.c (update_section_map): Use all_objfiles.
1698         (shared_objfile_contains_address_p): Likewise.
1699         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1700         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1701
1702 2019-01-09  Tom Tromey  <tom@tromey.com>
1703
1704         * common/next-iterator.h: New file.
1705         * objfiles.h (class all_objfiles): New.
1706         (struct objfile_iterator): New.
1707
1708 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1709
1710         * NEWS: Move the description of the changed "frame", "select-frame",
1711          and "info frame" commands to the Changed commands section.
1712
1713 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
1714
1715         * gdbtypes.c (check_stub_method_group): Remove handling of old
1716         mangling schemes.
1717         * linespec.c (find_methods): Likewise.
1718         * stabsread.c (read_member_functions): Likewise.
1719         * valops.c (search_struct_method): Likewise.
1720         (value_struct_elt_for_reference): Likewise.
1721         * NEWS: Mention this change.
1722
1723 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1724
1725         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
1726         print_source_lines.
1727         * source.c (print_source_lines_base): Update line number check.
1728         (print_source_lines): New function.
1729         (source_lines_range::source_lines_range): New function.
1730         * source.h (class source_lines_range): New class.
1731         (print_source_lines): New declaration.
1732
1733 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1734
1735         * linespec.c (linespec_state_destructor): Free self->canonical_names.
1736
1737 2019-01-08  Tom Tromey  <tom@tromey.com>
1738             Simon Marchi  <simon.marchi@ericsson.com>
1739
1740         PR gdb/24060
1741         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
1742         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
1743         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1744         * f-exp.y (DOLLAR_VARIABLE): Likewise.
1745         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
1746         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1747
1748 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1749
1750         * source.c (select_source_symtab): Move header comment to
1751         declaration in source.h.
1752         (forget_cached_source_info_for_objfile): Likewise.
1753         (forget_cached_source_info): Likewise.
1754         (identify_source_line): Likewise.
1755         * source.h (identify_source_line): Move declaration from symtab.h
1756         and add comment from source.c
1757         (print_source_lines): Likewise.
1758         (forget_cached_source_info_for_objfile): Likewise.
1759         (forget_cached_source_info): Likewise.
1760         (select_source_symtab): Likewise.
1761         (enum print_source_lines_flag): Move definition from symtab.h.
1762         * symtab.h (identify_source_line): Move declaration to source.h.
1763         (print_source_lines): Likewise.
1764         (forget_cached_source_info_for_objfile): Likewise.
1765         (forget_cached_source_info): Likewise.
1766         (select_source_symtab): Likewise.
1767         (enum print_source_lines_flag): Move definition to source.h.
1768         * tui/tui-hooks.c: Add 'source.h' include.
1769
1770 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1771
1772         * source.c (print_source_lines_base): Handle requests to print
1773         reverse line number sequences, and guard against empty lines
1774         string.
1775
1776 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1777
1778         * source.c (print_source_lines_base): Fix skip of '\r' if next
1779         character is '\n'.
1780
1781 2019-01-06  Tom Tromey  <tom@tromey.com>
1782
1783         * c-exp.y (struct c_parse_state) <macro_original_text,
1784         expansion_obstack>: New member.
1785         (macro_original_text, expansion_obstack): Remove globals.
1786         (scan_macro_expansion, scanning_macro_expansion)
1787         (finished_macro_expansion): Update.
1788         (scan_macro_cleanup): Remove.
1789         (yylex, c_parse): Update.
1790
1791 2019-01-06  Tom Tromey  <tom@tromey.com>
1792
1793         * c-exp.y (struct c_parse_state) <strings>: New member.
1794         (operator_stoken): Update.
1795
1796 2019-01-06  Tom Tromey  <tom@tromey.com>
1797
1798         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
1799         (union type_stack_elt) <typelist_val>: Now a pointer to
1800         std::vector.
1801         (type_stack_cleanup): Don't declare.
1802         (push_typelist): Update.
1803         * parse.c (pop_typelist): Return a std::vector.
1804         (push_typelist): Take a std::vector.
1805         (follow_types): Update.  Do not free args.
1806         (type_stack_cleanup): Remove.
1807         * c-exp.y (struct c_parse_state): New.
1808         (cpstate): New global.
1809         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
1810         (nonempty_typelist): Update.
1811         (func_mod): Create a new vector.
1812         (c_parse): Create a c_parse_state.
1813         (check_parameter_typelist): Do not delete params.
1814         (function_method): Update.  Do not delete type_list.
1815
1816 2019-01-06  Tom Tromey  <tom@tromey.com>
1817
1818         PR gdb/28155:
1819         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
1820         check_typedef.
1821         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
1822         (print_return_value): Likewise.
1823
1824 2019-01-05  Tom Tromey  <tom@tromey.com>
1825
1826         * contrib/cleanup_check.py: Remove.
1827         * contrib/gcc-with-excheck: Remove.
1828         * contrib/exsummary.py: Remove.
1829         * contrib/excheck.py: Remove.
1830
1831 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
1832
1833         * thread.c (delete_thread_1): Add gdb_assert that THR is not
1834         NULL. Initialize tpprev to NULL instead of assigning it
1835         to NULL on the next statement.
1836         * windows-nat.c (windows_delete_thread): Remove check for
1837         main_thread_id before printing thread exit notifications.
1838         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
1839         Remove thread ID check against main_thread_id.
1840         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
1841         windows_delete_thread.
1842         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
1843
1844 2019-01-04  Tom Tromey  <tom@tromey.com>
1845
1846         * compile/compile.c (_initialize_compile): Use upper case for
1847         metasyntactic variables.
1848         * symmisc.c (_initialize_symmisc): Use upper case for
1849         metasyntactic variables.
1850         * psymtab.c (_initialize_psymtab): Use upper case for
1851         metasyntactic variables.
1852         * demangle.c (demangle_command): Use upper case for metasyntactic
1853         variables.
1854         (_initialize_demangler): Likewise.
1855         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
1856         variables.
1857
1858 2019-01-03  Tom Tromey  <tom@tromey.com>
1859
1860         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
1861
1862 2019-01-03  Tom Tromey  <tom@tromey.com>
1863
1864         * python/py-symtab.c (salpy_str): Update.
1865         (struct salpy_sal_object) <symtab>: Now a PyObject.
1866         (salpy_dealloc): Update.
1867         (del_objfile_sal): Use gdbpy_ref.
1868
1869 2019-01-03  Tom Tromey  <tom@tromey.com>
1870
1871         * python/py-type.c (convert_field): Use new_reference.  Return
1872         gdbpy_ref.
1873         (make_fielditem): Return gdbpy_ref.
1874         (typy_fields): Update.
1875         (typy_getitem): Update.
1876         (field_name): Return gdbpy_ref.  Use new_reference.
1877         (typy_iterator_iternext): Update.
1878
1879 2019-01-03  Tom Tromey  <tom@tromey.com>
1880
1881         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
1882
1883 2019-01-03  Tom Tromey  <tom@tromey.com>
1884
1885         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
1886         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
1887         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
1888         (pspy_set_frame_filters, pspy_set_frame_unwinders)
1889         (pspy_set_type_printers): Likewise.
1890         * python/py-function.c (fnpy_init): Use gdbpy_ref.
1891         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
1892         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
1893         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
1894         (objfpy_set_type_printers): Likewise.
1895
1896 2019-01-03  Tom Tromey  <tom@tromey.com>
1897
1898         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
1899         (gdbpy_print_stack): Use gdbpy_err_fetch.
1900         * python/python-internal.h (class gdbpy_err_fetch): New class.
1901         (class gdbpy_enter) <m_error_type, m_error_value,
1902         m_error_traceback>: Remove.
1903         <m_error>: New member.
1904         (gdbpy_exception_to_string): Don't declare.
1905         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
1906         * python/py-value.c (convert_value_from_python): Use
1907         gdbpy_err_fetch.
1908         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
1909         gdbpy_exception_to_string.
1910         (gdbpy_handle_exception): Use gdbpy_err_fetch.
1911         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1912         gdbpy_err_fetch.
1913
1914 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1915
1916         * linux-nat.c (delete_lwp_cleanup): Delete.
1917         (struct lwp_deleter): New struct.
1918         (lwp_info_up): New typedef.
1919         (linux_nat_target::follow_fork): Delete cleanup, and make use of
1920         lwp_info_up.
1921
1922 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1923
1924         * linux-fork.c (class scoped_switch_fork_info): New class.
1925         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
1926
1927 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1928
1929         * valops.c (find_overload_match): Remove use of null_cleanup, and
1930         calls to do_cleanups.
1931
1932 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1933
1934         * compile/compile-cplus-types.c
1935         (compile_cplus_instance::decl_name): Handle changes to
1936         cp_func_name.
1937         * cp-support.c (cp_func_name): Update header comment, update
1938         return type.
1939         * cp-support.h (cp_func_name): Update return type in declaration.
1940         * valops.c (find_overload_match): Move temp_func local to top
1941         level of function and change its type.  Use temp_func to hold and
1942         delete temporary string obtained from cp_func_name.
1943
1944 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1945
1946         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
1947         gdb::char_vector, remove cleanup, and update uses of `msg`.
1948
1949 2019-01-03  Jim Wilson  <jimw@sifive.com>
1950
1951         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
1952
1953 2019-01-02  Tom Tromey  <tom@tromey.com>
1954
1955         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
1956         (tdesc_parse_xml): Remove cleanups.
1957         * target-descriptions.h (make_cleanup_free_target_description):
1958         Don't declare.
1959         (target_desc_deleter): New struct.
1960         (target_desc_up): New typedef.
1961         * target-descriptions.c (target_desc_deleter::operator()): Rename
1962         from free_target_description.
1963         (make_cleanup_free_target_description): Remove.
1964
1965 2019-01-02  Tom Tromey  <tom@tromey.com>
1966
1967         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
1968         constructor, destructor.
1969         (linespec_parser): Remove typedef.
1970         (~linespec_parser): Rename from linespec_parser_delete.
1971         (linespec_lex_to_end, linespec_complete_label)
1972         (linespec_complete): Update.
1973         (decode_line_full): Remove cleanups.
1974         (decode_line_1): Update.
1975
1976 2019-01-02  Tom Tromey  <tom@tromey.com>
1977
1978         * python/python-internal.h (inferior_to_inferior_object): Change
1979         return type.
1980         * python/py-exitedevent.c (create_exited_event_object): Update.
1981         * python/py-inferior.c (inferior_to_inferior_object): Return
1982         gdbpy_ref.
1983         (python_new_inferior, python_inferior_deleted)
1984         (thread_to_thread_object, delete_thread_object)
1985         (build_inferior_list, gdbpy_selected_inferior): Update.
1986         * python/py-infthread.c (create_thread_object): Update.  Also fail
1987         if inferior_to_inferior_object fails.
1988
1989 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
1990
1991         * inferior.h (class inferior) <displaced_step_state>: New field.
1992         * infrun.h (struct displaced_step_state): Move here from
1993         infrun.c.  Initialize fields, add constructor.
1994         <inf>: Remove field.
1995         <reset>: New method.
1996         * infrun.c (struct displaced_step_inferior_state): Move to
1997         infrun.h.
1998         (displaced_step_inferior_states): Remove.
1999         (get_displaced_stepping_state): Adust.
2000         (displaced_step_in_progress_any_inferior): Adjust.
2001         (displaced_step_in_progress_thread): Adjust.
2002         (displaced_step_in_progress): Adjust.
2003         (add_displaced_stepping_state): Remove.
2004         (get_displaced_step_closure_by_addr): Adjust.
2005         (remove_displaced_stepping_state): Remove.
2006         (infrun_inferior_exit): Call displaced_step_state.reset.
2007         (use_displaced_stepping): Don't check for NULL.
2008         (displaced_step_prepare_throw): Call
2009         get_displaced_stepping_state.
2010         (displaced_step_fixup): Don't check for NULL.
2011         (prepare_for_detach): Don't check for NULL.
2012
2013 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2014
2015         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2016          in case of call that did not complete.
2017
2018 2019-01-02  Andrey Utkin  <autkin@undo.io>
2019
2020         * symfile.c (find_separate_debug_file): Fix search of debug files for
2021         remote debuggee.
2022
2023 2019-01-02  Tom Tromey  <tom@tromey.com>
2024
2025         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2026         indentation.
2027         * python/py-frame.c (frapy_older): Remove cast.
2028         (frapy_newer): Likewise.
2029         * python/py-breakpoint.c (local_setattro): Remove cast.
2030         * python/py-arch.c (archpy_name): Remove local variable.
2031         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2032
2033 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2034
2035         * unittests/basic_string_view/element_access/char/empty.cc:
2036         Fix year range in copyright header.
2037
2038 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2039
2040         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2041         Delete.
2042         <operator==>: Update with for removed field.
2043         <hash>: Likewise.
2044         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2045         <isa_features>: ...this.
2046         <abi_features>: New field.
2047         (riscv_isa_flen): Update comment.
2048         (riscv_abi_xlen): New declaration.
2049         (riscv_abi_flen): New declaration.
2050         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2051         isa_features.
2052         (riscv_abi_xlen): New function.
2053         (riscv_isa_flen): Update to get answer from isa_features.
2054         (riscv_abi_flen): New function.
2055         (riscv_has_fp_abi): Update to get answer from abi_features.
2056         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2057         xlen and flen.
2058         (riscv_call_info) <xlen, flen>: Update comment.
2059         (riscv_call_arg_struct): Remove invalid assertions
2060         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2061         is removed.
2062         (riscv_gdbarch_init): Gather isa features and abi features
2063         separately, ensure both match on the gdbarch when reusing an old
2064         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2065         a target with 64-bit float hardware.
2066
2067 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2068
2069         * source.c (search_command_helper): Stop reverse search
2070         when line 1 has been searched.
2071
2072 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2073
2074         * record-full.c (record_full_base_target::close): Rewrite
2075         record_full_core_buf_list free logic.
2076
2077 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2078
2079         * break-catch-syscall.c (print_one_catch_syscall): xfree
2080         the last text.
2081
2082 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2083
2084         * top.c (print_gdb_version): Update Copyright year in version
2085         message.
2086
2087 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2088
2089         Update copyright year range in all GDB files.
2090
2091 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2092
2093         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2094
2095 For older changes see ChangeLog-2018.
2096 \f
2097 Local Variables:
2098 mode: change-log
2099 left-margin: 8
2100 fill-column: 74
2101 version-control: never
2102 coding: utf-8
2103 End:
2104