gdb/ChangeLog

   1 2019-04-09  Tom Tromey  <tromey@adacore.com>
   2
   3         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
   4         to bool.
   5         (extended_remote_target::attach): Update.
   6         (remote_target::remote_notice_new_inferior): Update.
   7         (remote_target::add_current_inferior_and_thread): Update.
   8         * inferior.c (exit_inferior_1): Use "false".
   9         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
  10
  11 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
  12
  13         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
  14         the "start" command.
  15
  16 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
  17
  18         * python/py-inferior.c (infpy_thread_from_thread_handle):
  19         Adjust comments to reflect renaming of thread_from_thread_handle
  20         to thread_from_handle.  Adjust keywords.  Fix type error message.
  21         (inferior_object_methods): Add thread_from_handle.  Retain
  22         thread_from_thread_handle, but mark it as deprecated.
  23
  24 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
  25
  26         * gdbthread.h (find_thread_by_handle): Revise declaration.
  27         * thread.c (find_thread_by_handle): Likewise.  Adjust
  28         implementation too.
  29         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
  30         support for buffer objects as handles.
  31
  32 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
  33
  34         * python/py-infthread.c (thpy_thread_handle): New function.
  35         (thread_object_methods): Register thpy_thread_handle.
  36
  37 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
  38
  39         * gdbthread.h (thread_to_thread_handle): Declare.
  40         * thread.c (gdbtypes.h): Include.
  41         (thread_to_thread_handle): New function.
  42
  43         * target.h (struct target_ops): Add thread_info_to_thread_handle.
  44         (target_thread_info_to_thread_handle): Declare.
  45         * target.c (target_thread_info_to_thread_handle): New function.
  46         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
  47         * target-delegates.c: Regenerate.
  48
  49         * linux-thread-db.c (class thread_db_target): Add method
  50         thread_info_to_thread_handle.
  51         (thread_db_target::thread_info_to_thread_handle): Define.
  52         * remote.c (class remote_target): Add new method
  53         thread_info_to_thread_handle.
  54         (remote_target::thread_info_to_thread_handle): Define.
  55
  56 2019-04-08  Pedro Alves  <palves@redhat.com>
  57
  58         * common/common-exceptions.c (throw_exception): Don't create
  59         named object to throw; throw directly.
  60         (throw_it): Likewise.  Don't initialize gdb_exception::message
  61         here, with new; pass FMT and AP to the ctor instead.
  62         * common/common-exceptions.h: Include <string>.
  63         (gdb_exception::gdb_exception(enum return_reason, enum errors,
  64         const char *, va_list)): New ctor.  Use std::make_shared.
  65         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
  66         errors)): Delete.
  67         (gdb_exception_error::gdb_exception_error(enum errors, const char
  68         *, va_list)): New.
  69         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
  70         Add assertion.
  71         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
  72         errors)): Delete.
  73         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
  74         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
  75         Add assertion.
  76
  77 2019-04-08  Tom Tromey  <tom@tromey.com>
  78
  79         * valops.c (value_rtti_indirect_type): Replace throw_exception
  80         with throw.
  81         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
  82         with throw.
  83         * thread.c (thr_try_catch_cmd): Replace throw_exception with
  84         throw.
  85         * target.c (target_translate_tls_address): Replace throw_exception
  86         with throw.
  87         * stack.c (frame_apply_command_count): Replace throw_exception
  88         with throw.
  89         * solib-spu.c (append_ocl_sos): Replace throw_exception with
  90         throw.
  91         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
  92         with throw.
  93         * rs6000-tdep.c (rs6000_frame_cache)
  94         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
  95         * remote.c: Replace throw_exception with throw.
  96         * record-full.c (record_full_message, record_full_wait_1)
  97         (record_full_restore): Replace throw_exception with throw.
  98         * record-btrace.c:
  99         (get_thread_current_frame_id, record_btrace_start_replaying)
 100         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
 101         (cmd_record_btrace_start): Replace throw_exception with throw.
 102         * parse.c (parse_exp_in_context_1): Replace throw_exception with
 103         throw.
 104         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
 105         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
 106         * linespec.c:
 107         (find_linespec_symbols): Replace throw_exception with throw.
 108         * infrun.c (displaced_step_prepare, resume): Replace
 109         throw_exception with throw.
 110         * infcmd.c (post_create_inferior): Replace throw_exception with
 111         throw.
 112         * inf-loop.c (inferior_event_handler): Replace throw_exception
 113         with throw.
 114         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
 115         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
 116         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
 117         (get_prev_frame_always, get_frame_pc_if_available)
 118         (get_frame_address_in_block_if_available, get_frame_language):
 119         Replace throw_exception with throw.
 120         * frame-unwind.c (frame_unwind_try_unwinder): Replace
 121         throw_exception with throw.
 122         * eval.c (fetch_subexp_value, evaluate_var_value)
 123         (evaluate_funcall, evaluate_subexp_standard): Replace
 124         throw_exception with throw.
 125         * dwarf2loc.c (call_site_find_chain)
 126         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
 127         Replace throw_exception with throw.
 128         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
 129         with throw.
 130         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
 131         throw.
 132         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
 133         * completer.c (complete_line_internal): Replace throw_exception
 134         with throw.
 135         * compile/compile-object-run.c (compile_object_run): Replace
 136         throw_exception with throw.
 137         * cli/cli-script.c (process_next_line): Replace throw_exception
 138         with throw.
 139         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
 140         (btrace_enable, btrace_maint_update_pt_packets): Replace
 141         throw_exception with throw.
 142         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
 143         throw_exception with throw.
 144         * break-catch-throw.c (re_set_exception_catchpoint): Replace
 145         throw_exception with throw.
 146         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
 147         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
 148         * aarch64-tdep.c (aarch64_make_prologue_cache)
 149         (aarch64_make_stub_cache): Replace throw_exception with throw.
 150
 151 2019-04-08  Tom Tromey  <tom@tromey.com>
 152
 153         * common/common-exceptions.c (throw_exception): Rename from
 154         throw_exception_cxx.  Remove old copy.  Make argument const.
 155         (throw_it): Create and throw exception objects directly.
 156         * common/common-exceptions.h (throw_exception): Make argument
 157         const.
 158         (struct gdb_exception_error): Add constructor.
 159         (struct gdb_exception_quit): Add constructor.
 160
 161 2019-04-08  Tom Tromey  <tom@tromey.com>
 162
 163         * common/common-exceptions.h (exception_rethrow): Don't declare.
 164         (TRY_SJLJ): Update comment.
 165         (TRY, CATCH, END_CATCH): Remove.
 166         * common/common-exceptions.c (exception_rethrow): Remove.
 167
 168 2019-04-08  Tom Tromey  <tom@tromey.com>
 169
 170         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
 171         Remove.
 172         (gdb_exception_error): Rename from
 173         gdb_exception_RETURN_MASK_ERROR.
 174         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
 175         (gdb_quit_bad_alloc): Update.
 176         * aarch64-tdep.c: Update.
 177         * ada-lang.c: Update.
 178         * ada-typeprint.c: Update.
 179         * ada-valprint.c: Update.
 180         * amd64-tdep.c: Update.
 181         * arch-utils.c: Update.
 182         * break-catch-throw.c: Update.
 183         * breakpoint.c: Update.
 184         * btrace.c: Update.
 185         * c-varobj.c: Update.
 186         * cli/cli-cmds.c: Update.
 187         * cli/cli-interp.c: Update.
 188         * cli/cli-script.c: Update.
 189         * common/common-exceptions.c: Update.
 190         * common/new-op.c: Update.
 191         * common/selftest.c: Update.
 192         * compile/compile-c-symbols.c: Update.
 193         * compile/compile-cplus-symbols.c: Update.
 194         * compile/compile-object-load.c: Update.
 195         * compile/compile-object-run.c: Update.
 196         * completer.c: Update.
 197         * corelow.c: Update.
 198         * cp-abi.c: Update.
 199         * cp-support.c: Update.
 200         * cp-valprint.c: Update.
 201         * darwin-nat.c: Update.
 202         * disasm-selftests.c: Update.
 203         * dtrace-probe.c: Update.
 204         * dwarf-index-cache.c: Update.
 205         * dwarf-index-write.c: Update.
 206         * dwarf2-frame-tailcall.c: Update.
 207         * dwarf2-frame.c: Update.
 208         * dwarf2loc.c: Update.
 209         * dwarf2read.c: Update.
 210         * eval.c: Update.
 211         * event-loop.c: Update.
 212         * event-top.c: Update.
 213         * exec.c: Update.
 214         * f-valprint.c: Update.
 215         * fbsd-tdep.c: Update.
 216         * frame-unwind.c: Update.
 217         * frame.c: Update.
 218         * gdbtypes.c: Update.
 219         * gnu-v3-abi.c: Update.
 220         * guile/guile-internal.h: Update.
 221         * guile/scm-block.c: Update.
 222         * guile/scm-breakpoint.c: Update.
 223         * guile/scm-cmd.c: Update.
 224         * guile/scm-disasm.c: Update.
 225         * guile/scm-frame.c: Update.
 226         * guile/scm-lazy-string.c: Update.
 227         * guile/scm-math.c: Update.
 228         * guile/scm-param.c: Update.
 229         * guile/scm-ports.c: Update.
 230         * guile/scm-pretty-print.c: Update.
 231         * guile/scm-symbol.c: Update.
 232         * guile/scm-symtab.c: Update.
 233         * guile/scm-type.c: Update.
 234         * guile/scm-value.c: Update.
 235         * i386-linux-tdep.c: Update.
 236         * i386-tdep.c: Update.
 237         * inf-loop.c: Update.
 238         * infcall.c: Update.
 239         * infcmd.c: Update.
 240         * infrun.c: Update.
 241         * jit.c: Update.
 242         * language.c: Update.
 243         * linespec.c: Update.
 244         * linux-fork.c: Update.
 245         * linux-nat.c: Update.
 246         * linux-tdep.c: Update.
 247         * linux-thread-db.c: Update.
 248         * main.c: Update.
 249         * mi/mi-cmd-break.c: Update.
 250         * mi/mi-cmd-stack.c: Update.
 251         * mi/mi-interp.c: Update.
 252         * mi/mi-main.c: Update.
 253         * objc-lang.c: Update.
 254         * p-valprint.c: Update.
 255         * parse.c: Update.
 256         * ppc-linux-tdep.c: Update.
 257         * printcmd.c: Update.
 258         * python/py-arch.c: Update.
 259         * python/py-breakpoint.c: Update.
 260         * python/py-cmd.c: Update.
 261         * python/py-finishbreakpoint.c: Update.
 262         * python/py-frame.c: Update.
 263         * python/py-framefilter.c: Update.
 264         * python/py-gdb-readline.c: Update.
 265         * python/py-inferior.c: Update.
 266         * python/py-infthread.c: Update.
 267         * python/py-lazy-string.c: Update.
 268         * python/py-linetable.c: Update.
 269         * python/py-objfile.c: Update.
 270         * python/py-param.c: Update.
 271         * python/py-prettyprint.c: Update.
 272         * python/py-progspace.c: Update.
 273         * python/py-record-btrace.c: Update.
 274         * python/py-record.c: Update.
 275         * python/py-symbol.c: Update.
 276         * python/py-type.c: Update.
 277         * python/py-unwind.c: Update.
 278         * python/py-utils.c: Update.
 279         * python/py-value.c: Update.
 280         * python/python.c: Update.
 281         * record-btrace.c: Update.
 282         * record-full.c: Update.
 283         * remote-fileio.c: Update.
 284         * remote.c: Update.
 285         * riscv-tdep.c: Update.
 286         * rs6000-aix-tdep.c: Update.
 287         * rs6000-tdep.c: Update.
 288         * rust-exp.y: Update.
 289         * rust-lang.c: Update.
 290         * s390-tdep.c: Update.
 291         * selftest-arch.c: Update.
 292         * solib-dsbt.c: Update.
 293         * solib-frv.c: Update.
 294         * solib-spu.c: Update.
 295         * solib-svr4.c: Update.
 296         * solib.c: Update.
 297         * sparc64-linux-tdep.c: Update.
 298         * stack.c: Update.
 299         * symfile-mem.c: Update.
 300         * symmisc.c: Update.
 301         * target.c: Update.
 302         * thread.c: Update.
 303         * top.c: Update.
 304         * tracefile-tfile.c: Update.
 305         * tui/tui.c: Update.
 306         * typeprint.c: Update.
 307         * unittests/cli-utils-selftests.c: Update.
 308         * unittests/parse-connection-spec-selftests.c: Update.
 309         * valops.c: Update.
 310         * valprint.c: Update.
 311         * value.c: Update.
 312         * varobj.c: Update.
 313         * windows-nat.c: Update.
 314         * x86-linux-nat.c: Update.
 315         * xml-support.c: Update.
 316
 317 2019-04-08  Tom Tromey  <tom@tromey.com>
 318
 319         * xml-support.c: Use C++ exception handling.
 320         * x86-linux-nat.c: Use C++ exception handling.
 321         * windows-nat.c: Use C++ exception handling.
 322         * varobj.c: Use C++ exception handling.
 323         * value.c: Use C++ exception handling.
 324         * valprint.c: Use C++ exception handling.
 325         * valops.c: Use C++ exception handling.
 326         * unittests/parse-connection-spec-selftests.c: Use C++ exception
 327         handling.
 328         * unittests/cli-utils-selftests.c: Use C++ exception handling.
 329         * typeprint.c: Use C++ exception handling.
 330         * tui/tui.c: Use C++ exception handling.
 331         * tracefile-tfile.c: Use C++ exception handling.
 332         * top.c: Use C++ exception handling.
 333         * thread.c: Use C++ exception handling.
 334         * target.c: Use C++ exception handling.
 335         * symmisc.c: Use C++ exception handling.
 336         * symfile-mem.c: Use C++ exception handling.
 337         * stack.c: Use C++ exception handling.
 338         * sparc64-linux-tdep.c: Use C++ exception handling.
 339         * solib.c: Use C++ exception handling.
 340         * solib-svr4.c: Use C++ exception handling.
 341         * solib-spu.c: Use C++ exception handling.
 342         * solib-frv.c: Use C++ exception handling.
 343         * solib-dsbt.c: Use C++ exception handling.
 344         * selftest-arch.c: Use C++ exception handling.
 345         * s390-tdep.c: Use C++ exception handling.
 346         * rust-lang.c: Use C++ exception handling.
 347         * rust-exp.y: Use C++ exception handling.
 348         * rs6000-tdep.c: Use C++ exception handling.
 349         * rs6000-aix-tdep.c: Use C++ exception handling.
 350         * riscv-tdep.c: Use C++ exception handling.
 351         * remote.c: Use C++ exception handling.
 352         * remote-fileio.c: Use C++ exception handling.
 353         * record-full.c: Use C++ exception handling.
 354         * record-btrace.c: Use C++ exception handling.
 355         * python/python.c: Use C++ exception handling.
 356         * python/py-value.c: Use C++ exception handling.
 357         * python/py-utils.c: Use C++ exception handling.
 358         * python/py-unwind.c: Use C++ exception handling.
 359         * python/py-type.c: Use C++ exception handling.
 360         * python/py-symbol.c: Use C++ exception handling.
 361         * python/py-record.c: Use C++ exception handling.
 362         * python/py-record-btrace.c: Use C++ exception handling.
 363         * python/py-progspace.c: Use C++ exception handling.
 364         * python/py-prettyprint.c: Use C++ exception handling.
 365         * python/py-param.c: Use C++ exception handling.
 366         * python/py-objfile.c: Use C++ exception handling.
 367         * python/py-linetable.c: Use C++ exception handling.
 368         * python/py-lazy-string.c: Use C++ exception handling.
 369         * python/py-infthread.c: Use C++ exception handling.
 370         * python/py-inferior.c: Use C++ exception handling.
 371         * python/py-gdb-readline.c: Use C++ exception handling.
 372         * python/py-framefilter.c: Use C++ exception handling.
 373         * python/py-frame.c: Use C++ exception handling.
 374         * python/py-finishbreakpoint.c: Use C++ exception handling.
 375         * python/py-cmd.c: Use C++ exception handling.
 376         * python/py-breakpoint.c: Use C++ exception handling.
 377         * python/py-arch.c: Use C++ exception handling.
 378         * printcmd.c: Use C++ exception handling.
 379         * ppc-linux-tdep.c: Use C++ exception handling.
 380         * parse.c: Use C++ exception handling.
 381         * p-valprint.c: Use C++ exception handling.
 382         * objc-lang.c: Use C++ exception handling.
 383         * mi/mi-main.c: Use C++ exception handling.
 384         * mi/mi-interp.c: Use C++ exception handling.
 385         * mi/mi-cmd-stack.c: Use C++ exception handling.
 386         * mi/mi-cmd-break.c: Use C++ exception handling.
 387         * main.c: Use C++ exception handling.
 388         * linux-thread-db.c: Use C++ exception handling.
 389         * linux-tdep.c: Use C++ exception handling.
 390         * linux-nat.c: Use C++ exception handling.
 391         * linux-fork.c: Use C++ exception handling.
 392         * linespec.c: Use C++ exception handling.
 393         * language.c: Use C++ exception handling.
 394         * jit.c: Use C++ exception handling.
 395         * infrun.c: Use C++ exception handling.
 396         * infcmd.c: Use C++ exception handling.
 397         * infcall.c: Use C++ exception handling.
 398         * inf-loop.c: Use C++ exception handling.
 399         * i386-tdep.c: Use C++ exception handling.
 400         * i386-linux-tdep.c: Use C++ exception handling.
 401         * guile/scm-value.c: Use C++ exception handling.
 402         * guile/scm-type.c: Use C++ exception handling.
 403         * guile/scm-symtab.c: Use C++ exception handling.
 404         * guile/scm-symbol.c: Use C++ exception handling.
 405         * guile/scm-pretty-print.c: Use C++ exception handling.
 406         * guile/scm-ports.c: Use C++ exception handling.
 407         * guile/scm-param.c: Use C++ exception handling.
 408         * guile/scm-math.c: Use C++ exception handling.
 409         * guile/scm-lazy-string.c: Use C++ exception handling.
 410         * guile/scm-frame.c: Use C++ exception handling.
 411         * guile/scm-disasm.c: Use C++ exception handling.
 412         * guile/scm-cmd.c: Use C++ exception handling.
 413         * guile/scm-breakpoint.c: Use C++ exception handling.
 414         * guile/scm-block.c: Use C++ exception handling.
 415         * guile/guile-internal.h: Use C++ exception handling.
 416         * gnu-v3-abi.c: Use C++ exception handling.
 417         * gdbtypes.c: Use C++ exception handling.
 418         * frame.c: Use C++ exception handling.
 419         * frame-unwind.c: Use C++ exception handling.
 420         * fbsd-tdep.c: Use C++ exception handling.
 421         * f-valprint.c: Use C++ exception handling.
 422         * exec.c: Use C++ exception handling.
 423         * event-top.c: Use C++ exception handling.
 424         * event-loop.c: Use C++ exception handling.
 425         * eval.c: Use C++ exception handling.
 426         * dwarf2read.c: Use C++ exception handling.
 427         * dwarf2loc.c: Use C++ exception handling.
 428         * dwarf2-frame.c: Use C++ exception handling.
 429         * dwarf2-frame-tailcall.c: Use C++ exception handling.
 430         * dwarf-index-write.c: Use C++ exception handling.
 431         * dwarf-index-cache.c: Use C++ exception handling.
 432         * dtrace-probe.c: Use C++ exception handling.
 433         * disasm-selftests.c: Use C++ exception handling.
 434         * darwin-nat.c: Use C++ exception handling.
 435         * cp-valprint.c: Use C++ exception handling.
 436         * cp-support.c: Use C++ exception handling.
 437         * cp-abi.c: Use C++ exception handling.
 438         * corelow.c: Use C++ exception handling.
 439         * completer.c: Use C++ exception handling.
 440         * compile/compile-object-run.c: Use C++ exception handling.
 441         * compile/compile-object-load.c: Use C++ exception handling.
 442         * compile/compile-cplus-symbols.c: Use C++ exception handling.
 443         * compile/compile-c-symbols.c: Use C++ exception handling.
 444         * common/selftest.c: Use C++ exception handling.
 445         * common/new-op.c: Use C++ exception handling.
 446         * cli/cli-script.c: Use C++ exception handling.
 447         * cli/cli-interp.c: Use C++ exception handling.
 448         * cli/cli-cmds.c: Use C++ exception handling.
 449         * c-varobj.c: Use C++ exception handling.
 450         * btrace.c: Use C++ exception handling.
 451         * breakpoint.c: Use C++ exception handling.
 452         * break-catch-throw.c: Use C++ exception handling.
 453         * arch-utils.c: Use C++ exception handling.
 454         * amd64-tdep.c: Use C++ exception handling.
 455         * ada-valprint.c: Use C++ exception handling.
 456         * ada-typeprint.c: Use C++ exception handling.
 457         * ada-lang.c: Use C++ exception handling.
 458         * aarch64-tdep.c: Use C++ exception handling.
 459
 460 2019-04-08  Tom Tromey  <tom@tromey.com>
 461
 462         * xml-support.c (gdb_xml_parser::parse): Update.
 463         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 464         * value.c (show_convenience): Update.
 465         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
 466         (test_parse_flags_qcs): Update.
 467         * thread.c (thr_try_catch_cmd): Update.
 468         * target.c (target_translate_tls_address): Update.
 469         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 470         (info_frame_command_core, frame_apply_command_count): Update.
 471         * rust-exp.y (rust_lex_exception_test): Update.
 472         * riscv-tdep.c (riscv_print_one_register_info): Update.
 473         * remote.c (remote_target::enable_btrace): Update.
 474         * record-btrace.c (record_btrace_enable_warn): Update.
 475         * python/py-utils.c (gdbpy_convert_exception): Update.
 476         * printcmd.c (do_one_display, print_variable_and_value): Update.
 477         * mi/mi-main.c (mi_print_exception): Update.
 478         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
 479         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 480         * linux-nat.c (linux_nat_target::attach): Update.
 481         * linux-fork.c (class scoped_switch_fork_info): Update.
 482         * infrun.c (displaced_step_prepare): Update.
 483         * infcall.c (call_function_by_hand_dummy): Update.
 484         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
 485         * gnu-v3-abi.c (print_one_vtable): Update.
 486         * frame.c (get_prev_frame_always): Update.
 487         * f-valprint.c (info_common_command_for_block): Update.
 488         * exec.c (try_open_exec_file): Update.
 489         * exceptions.c (print_exception, exception_print)
 490         (exception_fprintf, exception_print_same): Update.
 491         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
 492         * dwarf-index-cache.c (index_cache::store)
 493         (index_cache::lookup_gdb_index): Update.
 494         * darwin-nat.c (maybe_cache_shell): Update.
 495         * cp-valprint.c (cp_print_value_fields): Update.
 496         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
 497         (gcc_cplus_symbol_address): Update.
 498         * compile/compile-c-symbols.c (gcc_convert_symbol)
 499         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
 500         * common/selftest.c: Update.
 501         * common/common-exceptions.h (struct gdb_exception) <message>: Now
 502         a std::string.
 503         (exception_try_scope_entry, exception_try_scope_exit): Don't
 504         declare.
 505         (struct exception_try_scope): Remove.
 506         (TRY): Don't use exception_try_scope.
 507         (struct gdb_exception): Add constructor, operator=.
 508         <what>: New method.
 509         (struct gdb_exception_RETURN_MASK_ALL)
 510         (struct gdb_exception_RETURN_MASK_ERROR)
 511         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
 512         (struct gdb_quit_bad_alloc): Update.
 513         * common/common-exceptions.c (exception_none): Change
 514         initializer.
 515         (struct catcher) <state, exception>: Initialize inline.
 516         <prev>: Remove member.
 517         (current_catcher): Remove.
 518         (catchers): New global.
 519         (exceptions_state_mc_init): Simplify.
 520         (catcher_pop): Remove.
 521         (exceptions_state_mc, exceptions_state_mc_catch): Update.
 522         (try_scope_depth, exception_try_scope_entry)
 523         (exception_try_scope_exit): Remove.
 524         (throw_exception_sjlj): Update.
 525         (exception_messages, exception_messages_size): Remove.
 526         (throw_it): Simplify.
 527         (gdb_exception_sliced_copy): Remove.
 528         (throw_exception_cxx): Update.
 529         * cli/cli-script.c (script_from_file): Update.
 530         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
 531         Update.
 532         * ada-valprint.c (ada_val_print): Update.
 533         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
 534         (create_excep_cond_exprs): Update.
 535
 536 2019-04-08  Tom Tromey  <tom@tromey.com>
 537
 538         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
 539         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
 540         (TRY, CATCH, END_CATCH): Remove some definitions.
 541         * common/common-exceptions.c: Don't use GDB_XCPT.
 542         (catcher_list_size): Remove.
 543         (throw_exception, throw_it): Simplify.
 544
 545 2019-04-05  Tom Tromey  <tom@tromey.com>
 546
 547         Revert the header-sorting patch.
 548         * ft32-tdep.c: Revert.
 549         * frv-tdep.c: Revert.
 550         * frv-linux-tdep.c: Revert.
 551         * frame.c: Revert.
 552         * frame-unwind.c: Revert.
 553         * frame-base.c: Revert.
 554         * fork-child.c: Revert.
 555         * findvar.c: Revert.
 556         * findcmd.c: Revert.
 557         * filesystem.c: Revert.
 558         * filename-seen-cache.h: Revert.
 559         * filename-seen-cache.c: Revert.
 560         * fbsd-tdep.c: Revert.
 561         * fbsd-nat.h: Revert.
 562         * fbsd-nat.c: Revert.
 563         * f-valprint.c: Revert.
 564         * f-typeprint.c: Revert.
 565         * f-lang.c: Revert.
 566         * extension.h: Revert.
 567         * extension.c: Revert.
 568         * extension-priv.h: Revert.
 569         * expprint.c: Revert.
 570         * exec.h: Revert.
 571         * exec.c: Revert.
 572         * exceptions.c: Revert.
 573         * event-top.c: Revert.
 574         * event-loop.c: Revert.
 575         * eval.c: Revert.
 576         * elfread.c: Revert.
 577         * dwarf2read.h: Revert.
 578         * dwarf2read.c: Revert.
 579         * dwarf2loc.c: Revert.
 580         * dwarf2expr.h: Revert.
 581         * dwarf2expr.c: Revert.
 582         * dwarf2-frame.c: Revert.
 583         * dwarf2-frame-tailcall.c: Revert.
 584         * dwarf-index-write.h: Revert.
 585         * dwarf-index-write.c: Revert.
 586         * dwarf-index-common.c: Revert.
 587         * dwarf-index-cache.h: Revert.
 588         * dwarf-index-cache.c: Revert.
 589         * dummy-frame.c: Revert.
 590         * dtrace-probe.c: Revert.
 591         * disasm.h: Revert.
 592         * disasm.c: Revert.
 593         * disasm-selftests.c: Revert.
 594         * dictionary.c: Revert.
 595         * dicos-tdep.c: Revert.
 596         * demangle.c: Revert.
 597         * dcache.h: Revert.
 598         * dcache.c: Revert.
 599         * darwin-nat.h: Revert.
 600         * darwin-nat.c: Revert.
 601         * darwin-nat-info.c: Revert.
 602         * d-valprint.c: Revert.
 603         * d-namespace.c: Revert.
 604         * d-lang.c: Revert.
 605         * ctf.c: Revert.
 606         * csky-tdep.c: Revert.
 607         * csky-linux-tdep.c: Revert.
 608         * cris-tdep.c: Revert.
 609         * cris-linux-tdep.c: Revert.
 610         * cp-valprint.c: Revert.
 611         * cp-support.c: Revert.
 612         * cp-namespace.c: Revert.
 613         * cp-abi.c: Revert.
 614         * corelow.c: Revert.
 615         * corefile.c: Revert.
 616         * continuations.c: Revert.
 617         * completer.h: Revert.
 618         * completer.c: Revert.
 619         * complaints.c: Revert.
 620         * coffread.c: Revert.
 621         * coff-pe-read.c: Revert.
 622         * cli-out.h: Revert.
 623         * cli-out.c: Revert.
 624         * charset.c: Revert.
 625         * c-varobj.c: Revert.
 626         * c-valprint.c: Revert.
 627         * c-typeprint.c: Revert.
 628         * c-lang.c: Revert.
 629         * buildsym.c: Revert.
 630         * buildsym-legacy.c: Revert.
 631         * build-id.h: Revert.
 632         * build-id.c: Revert.
 633         * btrace.c: Revert.
 634         * bsd-uthread.c: Revert.
 635         * breakpoint.h: Revert.
 636         * breakpoint.c: Revert.
 637         * break-catch-throw.c: Revert.
 638         * break-catch-syscall.c: Revert.
 639         * break-catch-sig.c: Revert.
 640         * blockframe.c: Revert.
 641         * block.c: Revert.
 642         * bfin-tdep.c: Revert.
 643         * bfin-linux-tdep.c: Revert.
 644         * bfd-target.c: Revert.
 645         * bcache.c: Revert.
 646         * ax-general.c: Revert.
 647         * ax-gdb.h: Revert.
 648         * ax-gdb.c: Revert.
 649         * avr-tdep.c: Revert.
 650         * auxv.c: Revert.
 651         * auto-load.c: Revert.
 652         * arm-wince-tdep.c: Revert.
 653         * arm-tdep.c: Revert.
 654         * arm-symbian-tdep.c: Revert.
 655         * arm-pikeos-tdep.c: Revert.
 656         * arm-obsd-tdep.c: Revert.
 657         * arm-nbsd-tdep.c: Revert.
 658         * arm-nbsd-nat.c: Revert.
 659         * arm-linux-tdep.c: Revert.
 660         * arm-linux-nat.c: Revert.
 661         * arm-fbsd-tdep.c: Revert.
 662         * arm-fbsd-nat.c: Revert.
 663         * arm-bsd-tdep.c: Revert.
 664         * arch-utils.c: Revert.
 665         * arc-tdep.c: Revert.
 666         * arc-newlib-tdep.c: Revert.
 667         * annotate.h: Revert.
 668         * annotate.c: Revert.
 669         * amd64-windows-tdep.c: Revert.
 670         * amd64-windows-nat.c: Revert.
 671         * amd64-tdep.c: Revert.
 672         * amd64-sol2-tdep.c: Revert.
 673         * amd64-obsd-tdep.c: Revert.
 674         * amd64-obsd-nat.c: Revert.
 675         * amd64-nbsd-tdep.c: Revert.
 676         * amd64-nbsd-nat.c: Revert.
 677         * amd64-nat.c: Revert.
 678         * amd64-linux-tdep.c: Revert.
 679         * amd64-linux-nat.c: Revert.
 680         * amd64-fbsd-tdep.c: Revert.
 681         * amd64-fbsd-nat.c: Revert.
 682         * amd64-dicos-tdep.c: Revert.
 683         * amd64-darwin-tdep.c: Revert.
 684         * amd64-bsd-nat.c: Revert.
 685         * alpha-tdep.c: Revert.
 686         * alpha-obsd-tdep.c: Revert.
 687         * alpha-nbsd-tdep.c: Revert.
 688         * alpha-mdebug-tdep.c: Revert.
 689         * alpha-linux-tdep.c: Revert.
 690         * alpha-linux-nat.c: Revert.
 691         * alpha-bsd-tdep.c: Revert.
 692         * alpha-bsd-nat.c: Revert.
 693         * aix-thread.c: Revert.
 694         * agent.c: Revert.
 695         * addrmap.c: Revert.
 696         * ada-varobj.c: Revert.
 697         * ada-valprint.c: Revert.
 698         * ada-typeprint.c: Revert.
 699         * ada-tasks.c: Revert.
 700         * ada-lang.c: Revert.
 701         * aarch64-tdep.c: Revert.
 702         * aarch64-ravenscar-thread.c: Revert.
 703         * aarch64-newlib-tdep.c: Revert.
 704         * aarch64-linux-tdep.c: Revert.
 705         * aarch64-linux-nat.c: Revert.
 706         * aarch64-fbsd-tdep.c: Revert.
 707         * aarch64-fbsd-nat.c: Revert.
 708         * aarch32-linux-nat.c: Revert.
 709
 710 2019-04-05  Tom Tromey  <tom@tromey.com>
 711
 712         * ft32-tdep.c: Sort headers.
 713         * frv-tdep.c: Sort headers.
 714         * frv-linux-tdep.c: Sort headers.
 715         * frame.c: Sort headers.
 716         * frame-unwind.c: Sort headers.
 717         * frame-base.c: Sort headers.
 718         * fork-child.c: Sort headers.
 719         * findvar.c: Sort headers.
 720         * findcmd.c: Sort headers.
 721         * filesystem.c: Sort headers.
 722         * filename-seen-cache.h: Sort headers.
 723         * filename-seen-cache.c: Sort headers.
 724         * fbsd-tdep.c: Sort headers.
 725         * fbsd-nat.h: Sort headers.
 726         * fbsd-nat.c: Sort headers.
 727         * f-valprint.c: Sort headers.
 728         * f-typeprint.c: Sort headers.
 729         * f-lang.c: Sort headers.
 730         * extension.h: Sort headers.
 731         * extension.c: Sort headers.
 732         * extension-priv.h: Sort headers.
 733         * expprint.c: Sort headers.
 734         * exec.h: Sort headers.
 735         * exec.c: Sort headers.
 736         * exceptions.c: Sort headers.
 737         * event-top.c: Sort headers.
 738         * event-loop.c: Sort headers.
 739         * eval.c: Sort headers.
 740         * elfread.c: Sort headers.
 741         * dwarf2read.h: Sort headers.
 742         * dwarf2read.c: Sort headers.
 743         * dwarf2loc.c: Sort headers.
 744         * dwarf2expr.h: Sort headers.
 745         * dwarf2expr.c: Sort headers.
 746         * dwarf2-frame.c: Sort headers.
 747         * dwarf2-frame-tailcall.c: Sort headers.
 748         * dwarf-index-write.h: Sort headers.
 749         * dwarf-index-write.c: Sort headers.
 750         * dwarf-index-common.c: Sort headers.
 751         * dwarf-index-cache.h: Sort headers.
 752         * dwarf-index-cache.c: Sort headers.
 753         * dummy-frame.c: Sort headers.
 754         * dtrace-probe.c: Sort headers.
 755         * disasm.h: Sort headers.
 756         * disasm.c: Sort headers.
 757         * disasm-selftests.c: Sort headers.
 758         * dictionary.c: Sort headers.
 759         * dicos-tdep.c: Sort headers.
 760         * demangle.c: Sort headers.
 761         * dcache.h: Sort headers.
 762         * dcache.c: Sort headers.
 763         * darwin-nat.h: Sort headers.
 764         * darwin-nat.c: Sort headers.
 765         * darwin-nat-info.c: Sort headers.
 766         * d-valprint.c: Sort headers.
 767         * d-namespace.c: Sort headers.
 768         * d-lang.c: Sort headers.
 769         * ctf.c: Sort headers.
 770         * csky-tdep.c: Sort headers.
 771         * csky-linux-tdep.c: Sort headers.
 772         * cris-tdep.c: Sort headers.
 773         * cris-linux-tdep.c: Sort headers.
 774         * cp-valprint.c: Sort headers.
 775         * cp-support.c: Sort headers.
 776         * cp-namespace.c: Sort headers.
 777         * cp-abi.c: Sort headers.
 778         * corelow.c: Sort headers.
 779         * corefile.c: Sort headers.
 780         * continuations.c: Sort headers.
 781         * completer.h: Sort headers.
 782         * completer.c: Sort headers.
 783         * complaints.c: Sort headers.
 784         * coffread.c: Sort headers.
 785         * coff-pe-read.c: Sort headers.
 786         * cli-out.h: Sort headers.
 787         * cli-out.c: Sort headers.
 788         * charset.c: Sort headers.
 789         * c-varobj.c: Sort headers.
 790         * c-valprint.c: Sort headers.
 791         * c-typeprint.c: Sort headers.
 792         * c-lang.c: Sort headers.
 793         * buildsym.c: Sort headers.
 794         * buildsym-legacy.c: Sort headers.
 795         * build-id.h: Sort headers.
 796         * build-id.c: Sort headers.
 797         * btrace.c: Sort headers.
 798         * bsd-uthread.c: Sort headers.
 799         * breakpoint.h: Sort headers.
 800         * breakpoint.c: Sort headers.
 801         * break-catch-throw.c: Sort headers.
 802         * break-catch-syscall.c: Sort headers.
 803         * break-catch-sig.c: Sort headers.
 804         * blockframe.c: Sort headers.
 805         * block.c: Sort headers.
 806         * bfin-tdep.c: Sort headers.
 807         * bfin-linux-tdep.c: Sort headers.
 808         * bfd-target.c: Sort headers.
 809         * bcache.c: Sort headers.
 810         * ax-general.c: Sort headers.
 811         * ax-gdb.h: Sort headers.
 812         * ax-gdb.c: Sort headers.
 813         * avr-tdep.c: Sort headers.
 814         * auxv.c: Sort headers.
 815         * auto-load.c: Sort headers.
 816         * arm-wince-tdep.c: Sort headers.
 817         * arm-tdep.c: Sort headers.
 818         * arm-symbian-tdep.c: Sort headers.
 819         * arm-pikeos-tdep.c: Sort headers.
 820         * arm-obsd-tdep.c: Sort headers.
 821         * arm-nbsd-tdep.c: Sort headers.
 822         * arm-nbsd-nat.c: Sort headers.
 823         * arm-linux-tdep.c: Sort headers.
 824         * arm-linux-nat.c: Sort headers.
 825         * arm-fbsd-tdep.c: Sort headers.
 826         * arm-fbsd-nat.c: Sort headers.
 827         * arm-bsd-tdep.c: Sort headers.
 828         * arch-utils.c: Sort headers.
 829         * arc-tdep.c: Sort headers.
 830         * arc-newlib-tdep.c: Sort headers.
 831         * annotate.h: Sort headers.
 832         * annotate.c: Sort headers.
 833         * amd64-windows-tdep.c: Sort headers.
 834         * amd64-windows-nat.c: Sort headers.
 835         * amd64-tdep.c: Sort headers.
 836         * amd64-sol2-tdep.c: Sort headers.
 837         * amd64-obsd-tdep.c: Sort headers.
 838         * amd64-obsd-nat.c: Sort headers.
 839         * amd64-nbsd-tdep.c: Sort headers.
 840         * amd64-nbsd-nat.c: Sort headers.
 841         * amd64-nat.c: Sort headers.
 842         * amd64-linux-tdep.c: Sort headers.
 843         * amd64-linux-nat.c: Sort headers.
 844         * amd64-fbsd-tdep.c: Sort headers.
 845         * amd64-fbsd-nat.c: Sort headers.
 846         * amd64-dicos-tdep.c: Sort headers.
 847         * amd64-darwin-tdep.c: Sort headers.
 848         * amd64-bsd-nat.c: Sort headers.
 849         * alpha-tdep.c: Sort headers.
 850         * alpha-obsd-tdep.c: Sort headers.
 851         * alpha-nbsd-tdep.c: Sort headers.
 852         * alpha-mdebug-tdep.c: Sort headers.
 853         * alpha-linux-tdep.c: Sort headers.
 854         * alpha-linux-nat.c: Sort headers.
 855         * alpha-bsd-tdep.c: Sort headers.
 856         * alpha-bsd-nat.c: Sort headers.
 857         * aix-thread.c: Sort headers.
 858         * agent.c: Sort headers.
 859         * addrmap.c: Sort headers.
 860         * ada-varobj.c: Sort headers.
 861         * ada-valprint.c: Sort headers.
 862         * ada-typeprint.c: Sort headers.
 863         * ada-tasks.c: Sort headers.
 864         * ada-lang.c: Sort headers.
 865         * aarch64-tdep.c: Sort headers.
 866         * aarch64-ravenscar-thread.c: Sort headers.
 867         * aarch64-newlib-tdep.c: Sort headers.
 868         * aarch64-linux-tdep.c: Sort headers.
 869         * aarch64-linux-nat.c: Sort headers.
 870         * aarch64-fbsd-tdep.c: Sort headers.
 871         * aarch64-fbsd-nat.c: Sort headers.
 872         * aarch32-linux-nat.c: Sort headers.
 873
 874 2019-04-04  Tom Tromey  <tom@tromey.com>
 875
 876         * varobj.c (varobj_create): Update.
 877         * rust-exp.y (struct rust_parser) <update_innermost_block,
 878         lookup_symbol>: New methods.
 879         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
 880         Rename.
 881         (rust_parser::rust_lookup_type)
 882         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
 883         * printcmd.c (display_command, do_one_display): Update.
 884         * parser-defs.h (struct parser_state) <parser_state>: Add
 885         "tracker" parameter.
 886         (block_tracker): New member.
 887         (class innermost_block_tracker) <innermost_block_tracker>: Add
 888         "types" parameter.
 889         <reset>: Remove method.
 890         (innermost_block): Don't declare.
 891         (null_post_parser): Update.
 892         * parse.c (innermost_block): Remove global.
 893         (write_dollar_variable): Update.
 894         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
 895         Remove "tracker_types" parameter.
 896         (parse_expression): Add "tracker" parameter.
 897         (parse_expression_for_completion): Update.
 898         (null_post_parser): Add "tracker" parameter.
 899         * p-exp.y: Update rules.
 900         * m2-exp.y: Update rules.
 901         * language.h (struct language_defn) <la_post_parser>: Add
 902         "tracker" parameter.
 903         * go-exp.y: Update rules.
 904         * f-exp.y: Update rules.
 905         * expression.h (parse_expression, parse_exp_1): Add "tracker"
 906         parameter.
 907         * d-exp.y: Update rules.
 908         * c-exp.y: Update rules.
 909         * breakpoint.c (set_breakpoint_condition): Create an
 910         innermost_block_tracker.
 911         (watch_command_1): Likewise.
 912         * ada-lang.c (resolve): Add "tracker" parameter.
 913         (resolve_subexp): Likewise.
 914         * ada-exp.y (write_var_from_sym): Update.
 915
 916 2019-04-04  Tom Tromey  <tom@tromey.com>
 917
 918         * type-stack.h: New file.
 919         * type-stack.c: New file.
 920         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
 921         type-stack.h.
 922         (insert_into_type_stack, insert_type, push_type, push_type_int)
 923         (insert_type_address_space, pop_type, pop_type_int)
 924         (pop_typelist, pop_type_stack, append_type_stack)
 925         (push_type_stack, get_type_stack, push_typelist)
 926         (follow_type_instance_flags, follow_types): Don't declare.
 927         * parse.c (type_stack): Remove global.
 928         (parse_exp_in_context): Update.
 929         (insert_into_type_stack, insert_type, push_type, push_type_int)
 930         (insert_type_address_space, pop_type, pop_type_int)
 931         (pop_typelist, pop_type_stack, append_type_stack)
 932         (push_type_stack, get_type_stack, push_typelist)
 933         (follow_type_instance_flags, follow_types): Remove (moved to
 934         type-stack.c).
 935         * f-exp.y (type_stack): New global.
 936         Update rules.
 937         (push_kind_type, f_parse): Update.
 938         * d-exp.y (type_stack): New global.
 939         Update rules.
 940         (d_parse): Update.
 941         * c-exp.y (struct c_parse_state) <type_stack>: New member.
 942         Update rules.
 943         * Makefile.in (COMMON_SFILES): Add type-stack.c.
 944         (HFILES_NO_SRCDIR): Add type-stack.h.
 945
 946 2019-04-04  Tom Tromey  <tom@tromey.com>
 947
 948         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
 949         (rust_parser::convert_ast_to_expression, rust_parse)
 950         (rust_lex_test_completion, rust_lex_tests): Update.
 951         * parser-defs.h (struct expr_completion_state): New.
 952         (struct parser_state) <parser_state>: Add completion parameter.
 953         <mark_struct_expression, mark_completion_tag>: New methods.
 954         <parse_completion, m_completion_state>: New members.
 955         (prefixify_expression, null_post_parser): Update.
 956         (mark_struct_expression, mark_completion_tag): Don't declare.
 957         * parse.c (parse_completion, expout_last_struct)
 958         (expout_tag_completion_type, expout_completion_name): Remove
 959         globals.
 960         (parser_state::mark_struct_expression)
 961         (parser_state::mark_completion_tag): Now methods.
 962         (prefixify_expression): Add last_struct parameter.
 963         (prefixify_subexp): Likewise.
 964         (parse_exp_1): Update.
 965         (parse_exp_in_context): Add cstate parameter.  Update.
 966         (parse_expression_for_completion): Create an
 967         expr_completion_state.
 968         (null_post_parser): Add "completion" parameter.
 969         * p-exp.y: Update rules.
 970         (yylex): Update.
 971         * language.h (struct language_defn) <la_post_parser>: Add
 972         "completing" parameter.
 973         * go-exp.y: Update rules.
 974         (lex_one_token): Update.
 975         * expression.h (parse_completion): Don't declare.
 976         * d-exp.y: Update rules.
 977         (lex_one_token): Update rules.
 978         * c-exp.y: Update rules.
 979         (lex_one_token): Update.
 980         * ada-lang.c (resolve): Add "parse_completion" parameter.
 981         (resolve_subexp): Likewise.
 982         (ada_resolve_function): Likewise.
 983
 984 2019-04-04  Tom Tromey  <tom@tromey.com>
 985
 986         * parser-defs.h (struct parser_state) <start_arglist,
 987         end_arglist>: New methods.
 988         <arglist_len, m_funcall_chain>: New members.
 989         (arglist_len, start_arglist, end_arglist): Don't declare.
 990         * parse.c (arglist_len, funcall_chain): Remove global.
 991         (start_arglist, end_arglist): Remove functions.
 992         (parse_exp_in_context): Update.
 993         * p-exp.y: Update rules.
 994         * m2-exp.y: Update rules.
 995         * go-exp.y: Update rules.
 996         * f-exp.y: Update rules.
 997         * d-exp.y: Update rules.
 998         * c-exp.y: Update rules.
 999
1000 2019-04-04  Tom Tromey  <tom@tromey.com>
1001
1002         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1003         lex_operator, push_back>: New methods.
1004         Update all rules.
1005         (rust_parser::lex_hex, lex_escape): Rename and update.
1006         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
1007         (rust_parser::lex_operator): Rename and update.
1008         (rust_parser::lex_number, rustyylex, rustyyerror)
1009         (rust_lex_test_init, rust_lex_test_sequence)
1010         (rust_lex_test_push_back, rust_lex_tests): Update.
1011         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
1012         parameter.
1013         <lexptr, prev_lexptr>: New members.
1014         (lexptr, prev_lexptr): Don't declare.
1015         * parse.c (lexptr, prev_lexptr): Remove globals.
1016         (parse_exp_in_context): Update.
1017         * p-exp.y (yylex, yyerror): Update.
1018         * m2-exp.y (parse_number, yylex, yyerror): Update.
1019         * go-exp.y (lex_one_token, yyerror): Update.
1020         * f-exp.y (match_string_literal, yylex, yyerror): Update.
1021         * d-exp.y (lex_one_token, yyerror): Update.
1022         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
1023         (lex_one_token, yyerror): Update.
1024         * ada-lex.l (YY_INPUT): Update.
1025         (rewind_to_char): Update.
1026         * ada-exp.y (yyerror): Update.
1027
1028 2019-04-04  Tom Tromey  <tom@tromey.com>
1029
1030         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1031         * parser-defs.h (struct parser_state) <parser_state>: Add new
1032         parameter.
1033         <comma_terminates>: New member.
1034         (comma_terminates): Don't declare global.
1035         * parse.c (comma_terminates): Remove global.
1036         (parse_exp_in_context): Update.
1037         * p-exp.y (yylex): Update.
1038         * m2-exp.y (yylex): Update.
1039         * go-exp.y (lex_one_token): Update.
1040         * f-exp.y (yylex): Update.
1041         * d-exp.y (lex_one_token): Update.
1042         * c-exp.y (lex_one_token): Update.
1043         * ada-lex.l: Update.
1044
1045 2019-04-04  Tom Tromey  <tom@tromey.com>
1046
1047         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
1048         (rustyylex, rust_lex_test_init, rust_lex_test_one)
1049         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
1050         * parser-defs.h (paren_depth): Don't declare.
1051         * parse.c (paren_depth): Remove global.
1052         (parse_exp_in_context): Update.
1053         * p-exp.y (paren_depth): New global.
1054         (pascal_parse): Initialize it.
1055         * m2-exp.y (paren_depth): New global.
1056         (m2_parse): Initialize it.
1057         * go-exp.y (paren_depth): New global.
1058         (go_parse): Initialize it.
1059         * f-exp.y (paren_depth): New global.
1060         (f_parse): Initialize it.
1061         * d-exp.y (paren_depth): New global.
1062         (d_parse): Initialize it.
1063         * c-exp.y (paren_depth): New global.
1064         (c_parse): Initialize it.
1065         * ada-lex.l (paren_depth): New global.
1066         (lexer_init): Initialize it.
1067
1068 2019-04-04  Tom Tromey  <tom@tromey.com>
1069
1070         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
1071         (rust_parser::convert_ast_to_type)
1072         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1073         * parser-defs.h (struct parser_state) <parser_state>: Add
1074         parameters.  Initialize new members.
1075         <expression_context_block, expression_context_pc>: New members.
1076         * parse.c (expression_context_block, expression_context_pc):
1077         Remove globals.
1078         (parse_exp_in_context): Update.
1079         * p-exp.y: Update all rules.
1080         (yylex): Update.
1081         * m2-exp.y: Update all rules.
1082         (yylex): Update.
1083         * go-exp.y (yylex): Update.
1084         * f-exp.y (yylex): Update.
1085         * d-exp.y: Update all rules.
1086         (yylex): Update.
1087         * c-exp.y: Update all rules.
1088         (lex_one_token, classify_name, yylex, c_parse): Update.
1089         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
1090
1091 2019-04-04  Tom Tromey  <tom@tromey.com>
1092
1093         * gdbarch.h, gdbarch.c: Rebuild.
1094         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
1095         * stap-probe.h:
1096         (struct stap_parse_info): Replace "parser_state" with
1097         "expr_builder".
1098         * parser-defs.h (struct expr_builder): Rename from "parser_state".
1099         (parser_state): New class.
1100         * parse.c (expr_builder): Rename.
1101         (expr_builder::release): Rename.
1102         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
1103         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
1104         (write_exp_elt_longcst, write_exp_elt_floatcst)
1105         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
1106         (write_exp_string_vector, write_exp_bitstring)
1107         (write_exp_msymbol, mark_struct_expression)
1108         (write_dollar_variable)
1109         (insert_type_address_space, increase_expout_size): Replace
1110         "parser_state" with "expr_builder".
1111         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
1112         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
1113         "parser_state" with "expr_builder".
1114
1115 2019-04-04  Tom Tromey  <tom@tromey.com>
1116
1117         * rust-exp.y: Replace "parse_language" with method call.
1118         * p-exp.y:
1119         (yylex): Replace "parse_language" with method call.
1120         * m2-exp.y:
1121         (yylex): Replace "parse_language" with method call.
1122         * go-exp.y (classify_name): Replace "parse_language" with method
1123         call.
1124         * f-exp.y (yylex): Replace "parse_language" with method call.
1125         * d-exp.y (lex_one_token): Replace "parse_language" with method
1126         call.
1127         * c-exp.y:
1128         (lex_one_token, classify_name, yylex): Replace "parse_language"
1129         with method call.
1130         * ada-exp.y (find_primitive_type, type_char)
1131         (type_system_address): Replace "parse_language" with method call.
1132
1133 2019-04-04  Tom Tromey  <tom@tromey.com>
1134
1135         * rust-exp.y: Replace "parse_gdbarch" with method call.
1136         * parse.c (write_dollar_variable, insert_type_address_space):
1137         Replace "parse_gdbarch" with method call.
1138         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
1139         call.
1140         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
1141         call.
1142         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
1143         "parse_gdbarch" with method call.
1144         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
1145         with method call.
1146         * f-exp.y (parse_type, parse_f_type, yylex): Replace
1147         "parse_gdbarch" with method call.
1148         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
1149         "parse_gdbarch" with method call.
1150         * c-exp.y (parse_type, parse_number, classify_name): Replace
1151         "parse_gdbarch" with method call.
1152         * ada-lex.l: Replace "parse_gdbarch" with method call.
1153         * ada-exp.y (parse_type, find_primitive_type, type_char)
1154         (type_system_address): Replace "parse_gdbarch" with method call.
1155
1156 2019-04-04  Tom Tromey  <tom@tromey.com>
1157
1158         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
1159         * stap-probe.c (stap_parse_argument): Update.
1160         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
1161         initial_size parameter.
1162         * rust-exp.y (rust_lex_tests): Update.
1163         * parse.c (parser_state): Update.
1164         (parse_exp_in_context): Update.
1165         * parser-defs.h (struct parser_state) <parser_state>: Remove
1166         "initial_size" parameter.
1167
1168 2019-04-04  Tom Tromey  <tom@tromey.com>
1169
1170         * parser-defs.h (increase_expout_size): Don't declare.
1171         * parse.c (increase_expout_size): Now static.
1172
1173 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
1174
1175         * gnu-nat.c (gnu_nat_target::wait): Fix
1176         target_waitstatus_to_string call.
1177
1178 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1179
1180         * eval.c (evaluate_subexp_standard): Handle internal functions
1181         during Fortran function call handling.
1182
1183 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1184
1185         * NEWS: Mention new internal functions.
1186         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
1187         (read_base_type): Use dwarf2_init_complex_target_type.
1188         * value.c (creal_internal_fn): New function.
1189         (cimag_internal_fn): New function.
1190         (_initialize_values): Register new internal functions.
1191
1192 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1193
1194         * infrun.c (stop_all_threads): If debug_infrun, always
1195         trace the wait status after wait_one, using
1196         target_waitstatus_to_string and target_pid_to_str.
1197         (handle_inferior_event): Replace various trace of
1198         wait status kind by a single trace.
1199         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
1200         wait status kind image by target_waitstatus_to_string.
1201         * target/waitstatus.c (target_waitstatus_to_string): Fix
1202         obsolete comment.
1203
1204 2019-04-01  Tom Tromey  <tromey@adacore.com>
1205
1206         PR symtab/23331:
1207         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
1208
1209 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
1210             Pedro Alves  <palves@redhat.com>
1211
1212         * top.c (quit_force): Call 'finalize_values'.
1213         * value.c (finalize_values): New function.
1214         * value.h (finalize_values): Declare.
1215
1216 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
1217
1218         * NEWS: Announce $_gdb_major and $_gdb_minor.
1219
1220         * top.c (init_gdb_version_vars): New function.
1221         (gdb_init): Call init_gdb_version_vars.
1222
1223 2019-03-29  Tom Tromey  <tromey@adacore.com>
1224
1225         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
1226         help text.  Remove dead code.
1227
1228 2019-03-29  Keith Seitz  <keiths@redhat.com>
1229
1230         From Siddhesh Poyarekar:
1231         * f-lang.h (f77_get_upperbound): Return LONGEST.
1232         (f77_get_lowerbound): Likewise.
1233         * f-typeprint.c (f_type_print_varspec_suffix): Expand
1234         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
1235         print them.
1236         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
1237         plongest to format print it.
1238         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
1239         (f77_get_upperbound): Likewise.
1240         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
1241         LOWER_BOUND to LONGEST.
1242         (f77_create_arrayprint_offset_tbl): Likewise.
1243
1244 2019-03-29  Keith Seitz  <keiths@redhat.com>
1245
1246         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
1247         %s/pulongest for TYPE_LENGTH instead of %d in format
1248         strings.
1249         * ada-typerint.c (ada_print_type): Likewise.
1250         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
1251         * compile/compile-c-support.c (generate_register_struct): Likewise.
1252         * gdbtypes.c (recursive_dump_type): Likewise.
1253         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
1254         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
1255         instead of %d in format strings.
1256         * riscv-tdep.c (riscv_type_alignment): Cast second argument
1257         to std::min to ULONGEST.
1258         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
1259         instead of %d in format strings.
1260         * tracepoint.c (info_scope_command): Likewise.
1261         * typeprint.c (print_offset_data::update)
1262         (print_offset_data::finish): Likewise.
1263         * xtensa-tdep.c (xtensa_store_return_value)
1264         (xtensa_push_dummy_call): Likewise.
1265
1266 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
1267
1268         * windows-nat.c (display_selector): Fixed format specifications
1269         for 64-bit Cygwin.
1270
1271 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1272
1273         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
1274
1275 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
1276
1277         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
1278         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
1279         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
1280         (nios2_linux_init_abi): Install it.
1281
1282 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1283
1284         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
1285
1286 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1287
1288         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
1289
1290 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1291             Tom Tromey  <tromey@adacore.com>
1292
1293         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
1294
1295 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
1296
1297         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
1298         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
1299         method to compute the bounds of range types. Also print "[evaluated]"
1300         if the bounds' values come from a dynamic evaluation.
1301
1302 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1303
1304         * cp-valprint.c (cp_print_value_fields): Don't print trailing
1305         whitespace when pretty printing is on.
1306
1307 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1308
1309         * ppc-linux-nat.c: Add include.
1310
1311 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1312
1313         * NEWS: Mention AArch64 Pointer Authentication.
1314
1315 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1316
1317         * arm-linux-nat.c: Add include.
1318
1319 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
1320
1321         * source-cache.c (source_cache::get_source_lines): Re-read
1322         fullname after calling open_source_file.
1323
1324 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
1325
1326         * NEWS: Mention TLS support for FreeBSD.
1327
1328 2019-03-25  Tom Tromey  <tromey@adacore.com>
1329
1330         * minsyms.c (BUNCH_SIZE): Update comment.
1331         (~minimal_symbol_reader): Remove old comment.
1332         (compact_minimal_symbols): Update comment.
1333         (minimal_symbol_reader::install): Remove old comment.  Update
1334         other comments.
1335
1336 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1337
1338         * s390-linux-nat.c: Add include.
1339
1340 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1341
1342         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1343         Call linux_get_hwcap.
1344         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
1345         Likewise.
1346         (aarch64_linux_get_hwcap): Remove function.
1347         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
1348         declaration.
1349         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
1350         linux_get_hwcap.
1351         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1352         * linux-tdep.c (linux_get_hwcap): Add function.
1353         (linux_get_hwcap2): Likewise.
1354         * linux-tdep.h (linux_get_hwcap): Add declaration.
1355         (linux_get_hwcap2): Likewise.
1356         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
1357         (ppc_linux_get_hwcap2): Likewise.
1358         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
1359         linux_get_hwcap.
1360         (ppc_linux_nat_target::insert_watchpoint): Likewise.
1361         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
1362         (ppc_linux_nat_target::read_description): Likewise.
1363         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
1364         * s390-linux-nat.c: Likewise.
1365         * s390-linux-tdep.c (s390_core_read_description): Likewise.
1366
1367 2019-03-24  Tom Tromey  <tom@tromey.com>
1368
1369         * ada-lang.c (standard_lookup): Simplify initialization.
1370         (ada_lookup_symbol_nonlocal): Simplify return.
1371         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
1372         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
1373         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
1374         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
1375         initialization.
1376         * solib.c (solib_global_lookup): Simplify.
1377         * symtab.c (null_block_symbol): Remove.
1378         (symbol_cache_lookup): Simplify returns.
1379         (lookup_language_this): Simplify returns.
1380         (lookup_symbol_aux): Simplify return.
1381         (lookup_local_symbol): Simplify returns.
1382         (lookup_global_symbol_from_objfile): Simplify return.
1383         (lookup_symbol_in_objfile_symtabs)
1384         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
1385         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
1386         (lookup_static_symbol, lookup_global_symbol): Simplify return.
1387         * cp-namespace.c (cp_lookup_bare_symbol)
1388         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
1389         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
1390         (cp_lookup_nested_symbol): Don't use null_block_symbol.
1391         (cp_lookup_symbol_via_imports): Simplify initialization.
1392         (find_symbol_in_baseclass): Likewise.
1393         * symtab.h (null_block_symbol): Remove.
1394         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
1395         (d_lookup_nested_symbol, d_lookup_symbol_imports)
1396         (d_lookup_symbol_module): Likewise.
1397         (find_symbol_in_baseclass): Simplify initialization.
1398
1399 2019-03-24  Tom Tromey  <tom@tromey.com>
1400
1401         * expression.h: Don't include symtab.h.
1402         (struct block): Forward declare.
1403
1404 2019-03-24  Tom Tromey  <tom@tromey.com>
1405
1406         * c-exp.y (typebase): Remove casts.
1407         * gdbtypes.c (lookup_unsigned_typename, )
1408         (lookup_signed_typename): Remove cast.
1409         * eval.c (parse_to_comma_and_eval): Remove cast.
1410         * parse.c (write_dollar_variable): Remove cast.
1411         * block.h (struct block) <superblock>: Now const.
1412         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
1413         * psymtab.c (psym_map_matching_symbols): Make "block" const.
1414         (map_block): Make "block" const.
1415         * symfile.h (struct quick_symbol_functions)
1416         <map_matching_symbols>: Constify block argument to "callback".
1417         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
1418         const.
1419         (find_pc_sect_compunit_symtab): Make "b" const.
1420         (find_symbol_at_address): Likewise.
1421         (search_symbols): Likewise.
1422         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
1423         (dw2_debug_names_lookup_symbol): Likewise.
1424         (dw2_map_matching_symbols): Update.
1425         * p-valprint.c (pascal_val_print): Remove "block".
1426         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
1427         (aux_add_nonlocal_symbols): Make "block" const.
1428         (resolve_subexp): Remove cast.
1429         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
1430         const.
1431         (iterate_over_file_blocks): Likewise.
1432         * f-exp.y (%union) <bval>: Remove.
1433         * coffread.c (patch_opaque_types): Make "b" const.
1434         * spu-tdep.c (spu_catch_start): Make "block" const.
1435         * c-valprint.c (print_unpacked_pointer): Remove "block".
1436         * symmisc.c (dump_symtab_1): Make "b" const.
1437         (block_depth): Make "block" const.
1438         * d-exp.y (%union) <bval>: Remove.
1439         * cp-support.h (cp_lookup_rtti_type): Update.
1440         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
1441         * psymtab.c (psym_lookup_symbol): Make "block" const.
1442         (maintenance_check_psymtabs): Make "b" const.
1443         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
1444         (enumerate_locals, enumerate_args): Update.
1445         * python/py-symtab.c (stpy_global_block): Make "block" const.
1446         (stpy_static_block): Likewise.
1447         * inline-frame.c (block_starting_point_at): Make "new_block"
1448         const.
1449         * block.c (find_block_in_blockvector): Make return type const.
1450         (blockvector_for_pc_sect): Make "b" const.
1451         (find_block_in_blockvector): Make "b" const.
1452
1453 2019-03-23  Tom Tromey  <tom@tromey.com>
1454
1455         * varobj.c (varobj_create): Update.
1456         * symfile.c (clear_symtab_users): Don't reset innermost_block.
1457         * printcmd.c (display_command, do_one_display): Don't reset
1458         innermost_block.
1459         * parser-defs.h (enum innermost_block_tracker_type): Move to
1460         expression.h.
1461         (innermost_block): Update comment.
1462         * parse.c (parse_exp_1): Add tracker_types parameter.
1463         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
1464         tracker_types parameter.  Reset innermost_block.
1465         (parse_exp_in_context): Remove.
1466         (parse_expression_for_completion): Update.
1467         * objfiles.c (~objfile): Don't reset expression_context_block or
1468         innermost_block.
1469         * expression.h (enum innermost_block_tracker_type): Move from
1470         parser-defs.h.
1471         (parse_exp_1): Add tracker_types parameter.
1472         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
1473         reset innermost_block.
1474
1475 2019-03-23  Tom Tromey  <tom@tromey.com>
1476
1477         * objfiles.h: Include bcache.h.
1478
1479 2019-03-23  Tom Tromey  <tom@tromey.com>
1480
1481         * linespec.c (get_current_search_block): Use
1482         scoped_restore_current_language.
1483         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
1484
1485 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1486             Jiong Wang  <jiong.wang@arm.com>
1487
1488         * aarch64-linux-tdep.c
1489         (aarch64_linux_iterate_over_regset_sections): Check for pauth
1490         section.
1491         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
1492
1493 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1494             Jiong Wang  <jiong.wang@arm.com>
1495
1496         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
1497         instructions.
1498         (aarch64_analyze_prologue_test): Add PACIASP test.
1499         (aarch64_prologue_prev_register): Unmask PC value.
1500
1501 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1502             Jiong Wang  <jiong.wang@arm.com>
1503
1504         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
1505         (aarch64_dwarf2_prev_register): Unmask PC value.
1506         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
1507         (aarch64_execute_dwarf_cfa_vendor_op): Check for
1508         DW_CFA_AARCH64_negate_ra_state.
1509         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
1510
1511 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1512             Jiong Wang  <jiong.wang@arm.com>
1513
1514         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
1515         registers.
1516         (aarch64_pseudo_register_name): Likewise.
1517         (aarch64_pseudo_register_type): Likewise.
1518         (aarch64_pseudo_register_reggroup_p): Likewise.
1519         (aarch64_gdbarch_init): Add pauth registers.
1520         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
1521         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
1522         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
1523         (struct gdbarch_tdep): Add regnum for ra_state.
1524
1525 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1526             Jiong Wang  <jiong.wang@arm.com>
1527
1528         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
1529
1530 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1531             Jiong Wang  <jiong.wang@arm.com>
1532
1533         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
1534         function.
1535         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
1536         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
1537         (aarch64_gdbarch_init): Add puth registers.
1538         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
1539         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
1540         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
1541
1542 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1543             Jiong Wang  <jiong.wang@arm.com>
1544
1545         * aarch64-linux-nat.c
1546         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
1547         * aarch64-linux-tdep.c
1548         (aarch64_linux_core_read_description): Likewise.
1549         (aarch64_linux_get_hwcap): New function.
1550         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
1551         (aarch64_linux_get_hwcap): New declaration.
1552
1553 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1554             Jiong Wang  <jiong.wang@arm.com>
1555
1556         * aarch64-linux-nat.c
1557         (aarch64_linux_nat_target::read_description): Add pauth param.
1558         * aarch64-linux-tdep.c
1559         (aarch64_linux_core_read_description): Likewise.
1560         * aarch64-tdep.c (struct target_desc): Add in pauth.
1561         (aarch64_read_description): Add pauth param.
1562         (aarch64_gdbarch_init): Likewise.
1563         * aarch64-tdep.h (aarch64_read_description): Likewise.
1564         * arch/aarch64.c (aarch64_create_target_description): Likewise.
1565         * arch/aarch64.h (aarch64_create_target_description): Likewise.
1566         * features/Makefile: Add new files.
1567         * features/aarch64-pauth.c: New file.
1568         * features/aarch64-pauth.xml: New file.
1569
1570 2019-03-20  Tom Tromey  <tromey@adacore.com>
1571
1572         * infrun.c (handle_inferior_event): Rename from
1573         handle_inferior_event_1.  Create a scoped_value_mark.
1574         (handle_inferior_event): Remove.
1575
1576 2019-03-19  Tom Tromey  <tromey@adacore.com>
1577
1578         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
1579         * infrun.h (print_stop_event): Add "displays" parameter.
1580         * infrun.c (print_stop_event): Add "displays" parameter.
1581
1582 2019-03-19  Pedro Alves  <palves@redhat.com>
1583
1584         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
1585         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
1586         to -1.  Fix TABs vs spaces.
1587         (tui_ui_out::tui_ui_out): Don't initialize fields here.
1588         * tui/tui-out.h (tui_ui_out) Add intro comments.
1589         <m_line, m_start_of_line>: In-class initialize, and add describing
1590         comment.
1591
1592 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
1593
1594         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
1595         variable names.
1596         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
1597
1598 2019-03-18  Pedro Alves  <palves@redhat.com>
1599             Eli Zaretskii <eliz@gnu.org>
1600
1601         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
1602         m_line and m_start_of_line.
1603
1604 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
1605
1606         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
1607         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
1608         it returns a newline.  This fixes a regression in TU mode, whereby
1609         the next line is output on the same screen line as the user input.
1610
1611 2019-03-18  Tom Tromey  <tromey@adacore.com>
1612
1613         * minsyms.c (minimal_symbol_reader::install): Remove call to
1614         obstack_blank.
1615
1616 2019-03-18  Pedro Alves  <palves@redhat.com>
1617
1618         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
1619         New globals.
1620         (apply_style): New, factored out from ...
1621         (apply_ansi_escape): ... this.  Handle reverse video mode.
1622         (tui_set_reverse_mode): New function.
1623         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
1624         * tui/tui-winsource.c (tui_show_source_line): Use
1625         tui_set_reverse_mode instead of setting A_STANDOUT.
1626         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
1627         New setter methods.
1628
1629 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
1630
1631         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
1632         Handle tabs.
1633
1634 2019-03-18  Tom Tromey  <tromey@adacore.com>
1635
1636         * ada-lang.c (empty_array): Add "high" parameter.
1637         (ada_evaluate_subexp): Update.
1638
1639 2019-03-17  Sergei Trofimovich <siarheit@google.com>
1640
1641         * unittests/string_view-selftests.c: Define
1642         _initialize_string_view_selftests unconditionally.
1643
1644 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1645
1646         PR gdb/24350
1647         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
1648
1649 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1650
1651         PR gdb/24351
1652         * windows-nat.c (display_selector): Fix format specifiers.
1653
1654 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
1655
1656         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
1657         tui_refill_source_window instead of tui_refresh_win, to update the
1658         current execution line.  This fixes redisplay of the current line
1659         when stepping through the code with "next" or "step".
1660
1661 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1662
1663         * source-cache.c (source_cache::get_source_lines): Call
1664         find_source_lines to initialize s->nlines.  This fixes vertical
1665         scrolling of TUI source window when the DOWN arrow is pressed.
1666
1667 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1668
1669         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
1670         linux-thread-db.c (_initialize_thread_db): Likewise.
1671
1672 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1673
1674         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
1675         wclrtoeol in tui_show_source_line".  This reverts changes made in
1676         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
1677
1678 2019-03-15  Tom Tromey  <tom@tromey.com>
1679
1680         * symtab.h (struct minimal_symbol): Derive from
1681         general_symbol_info.
1682         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
1683         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
1684         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
1685         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
1686         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
1687         (MSYMBOL_SEARCH_NAME): Update.
1688         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
1689         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
1690         * minsyms.c (minimal_symbol_reader::record_full): Update.
1691
1692 2019-03-15  Tom Tromey  <tom@tromey.com>
1693
1694         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
1695
1696 2019-03-15  Tom Tromey  <tom@tromey.com>
1697
1698         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
1699         unique_xmalloc_ptr.
1700         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
1701         Update.
1702         * minsyms.c (lookup_minimal_symbol_by_pc_section)
1703         (build_minimal_symbol_hash_tables)
1704         (minimal_symbol_reader::install): Update.
1705
1706 2019-03-15  Tom Tromey  <tom@tromey.com>
1707
1708         * symtab.c (create_demangled_names_hash): Update.
1709         (symbol_set_names): Update.
1710         * objfiles.h (struct objfile_per_bfd_storage)
1711         <demangled_names_hash>: Now an htab_up.
1712         * objfiles.c (objfile_per_bfd_storage): Simplify.
1713
1714 2019-03-15  Tom Tromey  <tom@tromey.com>
1715
1716         * objfiles.h (struct objfile_per_bfd_storage): Declare
1717         destructor.
1718         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
1719         New.
1720         (get_objfile_bfd_data): Use new.  Don't initialize
1721         language_of_main.
1722         (free_objfile_per_bfd_storage): Remove.
1723         (objfile_bfd_data_free, objfile::~objfile): Use delete.
1724
1725 2019-03-15  Tom Tromey  <tom@tromey.com>
1726
1727         * symfile.c (reread_symbols): Update.
1728         * objfiles.c (objfile::objfile): Update.
1729         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
1730         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
1731         comment.
1732         (minimal_symbol_reader::install): Update.
1733         (terminate_minimal_symbol_table): Remove.
1734         * jit.c (jit_object_close_impl): Update.
1735
1736 2019-03-15  Tom Tromey  <tom@tromey.com>
1737
1738         * minsyms.c (minimal_symbol_reader::record_full): Remove some
1739         initializations.
1740
1741 2019-03-15  Tom Tromey  <tom@tromey.com>
1742
1743         * objfiles.h (struct objfile_per_bfd_storage)
1744         <demangled_hash_languages>: Now a bitset.
1745         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
1746         (lookup_minimal_symbol): Update.
1747
1748 2019-03-15  Tom Tromey  <tom@tromey.com>
1749
1750         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
1751         Don't return the symbol.
1752         * coffread.c (record_minimal_symbol): Use record_full.
1753
1754 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
1755
1756         The MS-Windows port of ncurses fails to switch to a color pair if
1757         one or both of the colors are the implicit default colors.  This
1758         change records the default colors when TUI is initialized, and
1759         then specifies them explicitly when a color pair uses the default
1760         colors.  This allows color styling in TUI mode on MS-Windows.
1761
1762         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
1763         ncurses_norm_attr.
1764         (tui_initialize_io) [__MINGW32__]: Record the default terminal
1765         colors in ncurses_norm_attr.
1766         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
1767         "none", replace it with the default color recorded in
1768         ncurses_norm_attr.
1769
1770 2019-03-14  Tom Tromey  <tromey@adacore.com>
1771
1772         * source-cache.h (class source_cache) <get_source_lines>: Return
1773         std::string.
1774         * source-cache.c (source_cache::extract_lines): Handle case where
1775         first_pos==npos.  Return std::string.
1776         (source_cache::get_source_lines): Update.
1777
1778 2019-03-14  Tom Tromey  <tromey@adacore.com>
1779
1780         * NEWS: Add item for "style sources" commands.
1781         * source-cache.c (source_cache::get_source_lines): Check
1782         source_styling.
1783         * cli/cli-style.c (source_styling): New global.
1784         (_initialize_cli_style): Add "style sources" commands.
1785         (show_style_sources): New function.
1786         * cli/cli-style.h (source_styling): Declare.
1787
1788 2019-03-14  Pedro Alves  <palves@redhat.com>
1789             Tom Tromey  <tromey@adacore.com>
1790
1791         * tui/tui-winsource.h (tui_refill_source_window): Declare.
1792         * tui/tui-winsource.c (tui_refill_source_window): New function,
1793         from...
1794         (tui_horizontal_source_scroll): ... here.  Move some logic.
1795         * cli/cli-style.c (set_style_enabled): Notify new observable.
1796         * tui/tui-hooks.c (tui_redisplay_source): New function.
1797         (tui_attach_detach_observers): Attach or detach
1798         tui_redisplay_source.
1799         * observable.h (source_styling_changed): New observable.
1800         * observable.c: Define source_styling_changed observable.
1801
1802 2019-03-13  Tom Tromey  <tromey@adacore.com>
1803
1804         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
1805         (i386_gnu_nat_target::store_registers): Update.
1806         * target-debug.h (target_debug_print_std_string): New macro.
1807         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1808         * windows-tdep.c (display_one_tib): Update.
1809         * tui/tui-stack.c (tui_make_status_line): Update.
1810         * top.c (print_inferior_quit_action): Update.
1811         * thread.c (thr_try_catch_cmd): Update.
1812         (add_thread_with_info): Update.
1813         (thread_target_id_str): Update.
1814         (thr_try_catch_cmd): Update.
1815         (thread_command): Update.
1816         (thread_find_command): Update.
1817         * record-btrace.c (record_btrace_target::info_record)
1818         (record_btrace_resume_thread, record_btrace_target::resume)
1819         (record_btrace_cancel_resume, record_btrace_step_thread)
1820         (record_btrace_target::wait, record_btrace_target::wait)
1821         (record_btrace_target::wait, record_btrace_target::stop): Update.
1822         * progspace.c (print_program_space): Update.
1823         * process-stratum-target.c
1824         (process_stratum_target::thread_address_space): Update.
1825         * linux-fork.c (linux_fork_mourn_inferior)
1826         (detach_checkpoint_command, info_checkpoints_command)
1827         (linux_fork_context): Update.
1828         (linux_fork_detach): Update.
1829         (class scoped_switch_fork_info): Update.
1830         (delete_checkpoint_command): Update.
1831         * infrun.c (follow_fork_inferior): Update.
1832         (follow_fork_inferior): Update.
1833         (proceed_after_vfork_done): Update.
1834         (handle_vfork_child_exec_or_exit): Update.
1835         (follow_exec): Update.
1836         (displaced_step_prepare_throw): Update.
1837         (displaced_step_restore): Update.
1838         (start_step_over): Update.
1839         (resume_1): Update.
1840         (clear_proceed_status_thread): Update.
1841         (proceed): Update.
1842         (print_target_wait_results): Update.
1843         (do_target_wait): Update.
1844         (context_switch): Update.
1845         (stop_all_threads): Update.
1846         (restart_threads): Update.
1847         (finish_step_over): Update.
1848         (handle_signal_stop): Update.
1849         (switch_back_to_stepped_thread): Update.
1850         (keep_going_pass_signal): Update.
1851         (print_exited_reason): Update.
1852         (normal_stop): Update.
1853         * inferior.c (inferior_pid_to_str): Change return type.
1854         (print_selected_inferior): Update.
1855         (add_inferior): Update.
1856         (detach_inferior): Update.
1857         * dummy-frame.c (fprint_dummy_frames): Update.
1858         * dcache.c (dcache_info_1): Update.
1859         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
1860         (btrace_fetch, btrace_clear): Update.
1861         * linux-tdep.c (linux_core_pid_to_str): Change return type.
1862         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
1863         type.
1864         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
1865         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
1866         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
1867         * gdbarch.c, gdbarch.h: Rebuild.
1868         * gdbarch.sh (core_pid_to_str): Change return type.
1869         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
1870         return type.
1871         (windows_nat_target::pid_to_str): Change return type.
1872         (windows_delete_thread): Update.
1873         (windows_nat_target::attach): Update.
1874         (windows_nat_target::files_info): Update.
1875         * target-delegates.c: Rebuild.
1876         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
1877         return type.
1878         (sol_thread_target::pid_to_str): Change return type.
1879         * remote.c (class remote_target) <pid_to_str>: Change return
1880         type.
1881         (remote_target::pid_to_str): Change return type.
1882         (extended_remote_target::attach, remote_target::remote_stop_ns)
1883         (remote_target::remote_notif_remove_queued_reply)
1884         (remote_target::push_stop_reply, remote_target::disable_btrace):
1885         Update.
1886         (extended_remote_target::attach): Update.
1887         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
1888         type.
1889         (gdbsim_target::pid_to_str): Change return type.
1890         * ravenscar-thread.c (struct ravenscar_thread_target)
1891         <pid_to_str>: Change return type.
1892         (ravenscar_thread_target::pid_to_str): Change return type.
1893         * procfs.c (class procfs_target) <pid_to_str>: Change return
1894         type.
1895         (procfs_target::pid_to_str): Change return type.
1896         (procfs_target::attach): Update.
1897         (procfs_target::detach): Update.
1898         (procfs_target::fetch_registers): Update.
1899         (procfs_target::store_registers): Update.
1900         (procfs_target::wait): Update.
1901         (procfs_target::files_info): Update.
1902         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
1903         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
1904         return type.
1905         (nto_procfs_target::pid_to_str): Change return type.
1906         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
1907         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
1908         return type.
1909         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
1910         (exit_lwp): Update.
1911         (attach_proc_task_lwp_callback, get_detach_signal)
1912         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
1913         (linux_nat_target::resume, wait_lwp, stop_callback)
1914         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
1915         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
1916         (linux_nat_wait_1, resume_stopped_resumed_lwps)
1917         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
1918         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
1919         type.
1920         (inf_ptrace_target::attach): Update.
1921         (inf_ptrace_target::files_info): Update.
1922         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
1923         type.
1924         (go32_nat_target::pid_to_str): Change return type.
1925         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
1926         (gnu_nat_target::wait): Update.
1927         (gnu_nat_target::wait): Update.
1928         (gnu_nat_target::resume): Update.
1929         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
1930         (fbsd_nat_target::wait): Update.
1931         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
1932         type.
1933         (darwin_nat_target::attach): Update.
1934         * corelow.c (class core_target) <pid_to_str>: Change return type.
1935         (core_target::pid_to_str): Change return type.
1936         * target.c (normal_pid_to_str): Change return type.
1937         (default_pid_to_str): Likewise.
1938         (target_pid_to_str): Change return type.
1939         (target_translate_tls_address): Update.
1940         (target_announce_detach): Update.
1941         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
1942         return type.
1943         (bsd_uthread_target::pid_to_str): Change return type.
1944         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
1945         type.
1946         (bsd_kvm_target::pid_to_str): Change return type.
1947         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
1948         return type.
1949         (aix_thread_target::pid_to_str): Change return type.
1950         * target.h (struct target_ops) <pid_to_str>: Change return type.
1951         (target_pid_to_str, normal_pid_to_str): Likewise.
1952         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
1953         type.
1954         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
1955         type.
1956         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
1957         return type.
1958         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
1959         type.
1960         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
1961         type.
1962         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
1963         return type.
1964
1965 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
1966
1967         * NEWS: Mention that the new default MI version is 3.  Mention
1968         changes to the output of commands and events that deal with
1969         multi-location breakpoints.
1970         * breakpoint.c: Include "mi/mi-out.h".
1971         (print_one_breakpoint): Change output syntax if using MI version
1972         >= 3.
1973         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
1974         New.
1975         (mi_multi_location_breakpoint_output_fixed): New.
1976         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
1977         (mi_cmd_fix_multi_location_breakpoint_output): New.
1978         (mi_multi_location_breakpoint_output_fixed): New.
1979         * mi/mi-cmds.c (mi_cmds): Register command
1980         -fix-multi-location-breakpoint-output.
1981         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
1982         interpreter "mi".
1983
1984 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
1985
1986         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
1987         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
1988         instantiate mi_ui_out based on interpreter name.
1989         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
1990         * mi/mi-main.c (mi_load_progress): Likewise.
1991
1992 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1993
1994         * NEWS: Combine separate "New targets" sections for 8.3.
1995
1996 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1997
1998         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
1999         (ppcfbsd_init_abi): Install gdbarch
2000         "fetch_tls_load_module_address" and "get_thread_local_address"
2001         methods.
2002
2003 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2004
2005         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
2006         (riscv_fbsd_init_abi): Install gdbarch
2007         "fetch_tls_load_module_address" and "get_thread_local_address"
2008         methods.
2009
2010 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2011
2012         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
2013         (i386fbsd_init_abi): Install gdbarch
2014         "fetch_tls_load_module_address" and "get_thread_local_address"
2015         methods.
2016
2017 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2018
2019         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
2020         (amd64fbsd_init_abi): Install gdbarch
2021         "fetch_tls_load_module_address" and "get_thread_local_address"
2022         methods.
2023
2024 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2025
2026         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
2027         (struct fbsd_pspace_data): New type.
2028         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
2029         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
2030         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2031         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
2032         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
2033
2034 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2035
2036         * gdbtypes.c (lookup_struct_elt): New function.
2037         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
2038         * gdbtypes.h (struct struct_elt): New type.
2039         (lookup_struct_elt): New prototype.
2040
2041 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2042
2043         * gdbtypes.c (lookup_struct_elt_type): Update comment and
2044         remove disabled code block.
2045
2046 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2047
2048         * gdbarch.sh (get_thread_local_address): New method.
2049         * gdbarch.h, gdbarch.c: Regenerate.
2050         * target.c (target_translate_tls_address): Use
2051         gdbarch_get_thread_local_address if present instead of
2052         target::get_thread_local_address.
2053
2054 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2055
2056         * target.h (target::get_thread_local_address): Update comment.
2057
2058 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2059
2060         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
2061         objfile->separate_debug_objfile_backlink if not NULL.
2062
2063 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2064
2065         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
2066         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
2067         (amd64bsd_store_inferior_registers): Likewise.
2068         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2069         Enable segment base registers.
2070         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
2071         PT_GETFSBASE and PT_GETGSBASE.
2072         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
2073         PT_SETGSBASE.
2074         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
2075         segment base registers.
2076         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2077
2078 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2079
2080         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2081         Update calls to i386_target_description to add 'segments'
2082         parameter.
2083         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
2084         add segment base registers.
2085         * arch/i386.c (i386_create_target_description): Add 'segments'
2086         parameter to enable segment base registers.
2087         * arch/i386.h (i386_create_target_description): Likewise.
2088         * features/i386/32bit-segments.xml: New file.
2089         * features/i386/32bit-segments.c: Generate.
2090         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
2091         call to i386_target_description to add 'segments' parameter.
2092         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2093         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
2094         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
2095         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
2096         if feature is present.
2097         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
2098         Add 'segments' parameter to call to i386_target_description.
2099         (i386_target_description): Add 'segments' parameter to enable
2100         segment base registers.
2101         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
2102         to call to i386_target_description.
2103         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
2104         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
2105         Define I386_NUM_REGS.
2106         (i386_target_description): Add 'segments' parameter to enable
2107         segment base registers.
2108
2109 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
2110
2111         PR/24325
2112         * source-cache.c: #undef open and close, to avoid unresolved
2113         externals during linking.
2114
2115 2019-03-12  Tom Tromey  <tromey@adacore.com>
2116
2117         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
2118         const.  Add initializers.
2119         (_initialize_remote): Don't initialize ptid globals.
2120
2121 2019-03-12  Pedro Alves  <palves@redhat.com>
2122
2123         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
2124
2125 2019-03-12  Pedro Alves  <palves@redhat.com>
2126
2127         * cp-name-parser.y (main): Remove unused 'len' variable.
2128
2129 2019-03-12  Tom Tromey  <tromey@adacore.com>
2130
2131         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
2132         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
2133
2134 2019-03-12  Tom Tromey  <tromey@adacore.com>
2135
2136         * linux-nat.c (iterate_over_lwps): Update.
2137         (stop_callback): Remove parameter.
2138         (stop_wait_callback, detach_callback, resume_set_callback)
2139         (select_singlestep_lwp_callback, set_ignore_sigint)
2140         (status_callback, resumed_callback, resume_clear_callback)
2141         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
2142         data parameter.
2143         (linux_nat_target::detach, linux_nat_target::resume)
2144         (linux_stop_and_wait_all_lwps, select_event_lwp)
2145         (linux_nat_filter_event, linux_nat_wait_1)
2146         (linux_nat_target::kill, linux_nat_target::stop)
2147         (linux_nat_target::stop): Update.
2148         (linux_nat_resume_callback): Change type.
2149         (resume_stopped_resumed_lwps, count_events_callback)
2150         (select_event_lwp_callback): Likewise.
2151         (linux_stop_lwp, linux_nat_stop_lwp): Update.
2152         * arm-linux-nat.c (struct update_registers_data): Remove.
2153         (update_registers_callback): Change type.
2154         (arm_linux_insert_hw_breakpoint1): Update.
2155         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
2156         parameter.
2157         (x86_linux_dr_set_addr): Update.
2158         (x86_linux_dr_set_control): Update.
2159         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
2160         (iterate_over_lwps): Use gdb::function_view.
2161         * nat/aarch64-linux-hw-point.c (struct
2162         aarch64_dr_update_callback_param): Remove.
2163         (debug_reg_change_callback): Change type.
2164         (aarch64_notify_debug_reg_change): Update.
2165         * s390-linux-nat.c (s390_refresh_per_info): Update.
2166
2167 2019-03-11  Tom Tromey  <tromey@adacore.com>
2168
2169         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
2170         redundant assignment to "this_cu".
2171
2172 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2173
2174         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
2175
2176 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2177
2178         * gdbtypes.c (rank_one_type_parm_set): New function extracted
2179         from...
2180         (rank_one_type): ... this.
2181
2182 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2183
2184         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
2185         from...
2186         (rank_one_type): ... this.
2187
2188 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2189
2190         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
2191         from...
2192         (rank_one_type): ... this.
2193
2194 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2195
2196         * gdbtypes.c (rank_one_type_parm_float): New function extracted
2197         from...
2198         (rank_one_type): ... this.
2199
2200 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2201
2202         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
2203         from...
2204         (rank_one_type): ... this.
2205
2206 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2207
2208         * gdbtypes.c (rank_one_type_parm_range): New function extracted
2209         from...
2210         (rank_one_type): ... this.
2211
2212 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2213
2214         * gdbtypes.c (rank_one_type_parm_char): New function extracted
2215         from...
2216         (rank_one_type): ... this.
2217
2218 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2219
2220         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
2221         from...
2222         (rank_one_type): ... this.
2223
2224 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2225
2226         * gdbtypes.c (rank_one_type_parm_int): New function extracted
2227         from...
2228         (rank_one_type): ... this.
2229
2230 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2231
2232         * gdbtypes.c (rank_one_type_parm_func): New function extracted
2233         from...
2234         (rank_one_type): ... this.
2235
2236 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2237
2238         * gdbtypes.c (rank_one_type_parm_array): New function extracted
2239         from...
2240         (rank_one_type): ... this.
2241
2242 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2243
2244         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
2245         from...
2246         (rank_one_type): ... this.
2247
2248 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2249
2250         * inferior.c (initialize_inferiors): Ensure 'help set/show print
2251         inferior-events' shows the example events.
2252
2253 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
2254
2255         Support styling on native MS-Windows console
2256
2257         PR/24315
2258         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
2259         on MS-Windows if $TERM is not defined.
2260
2261         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
2262
2263         * posix-hdep.c (gdb_console_fputs):
2264         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
2265         functions.
2266         * ui-file.h (gdb_console_fputs): Add prototype.
2267
2268         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
2269         back to fputs only if the former returns zero.
2270
2271 2019-03-07  Tom Tromey  <tom@tromey.com>
2272
2273         * symmisc.c (print_symbol_bcache_statistics): Update.
2274         (print_objfile_statistics): Update.
2275         * symfile.c (allocate_symtab): Update.
2276         * stabsread.c: Don't include bcache.h.
2277         * psymtab.h (struct psymbol_bcache): Don't declare.
2278         (class psymtab_storage) <psymbol_cache>: Now a bcache.
2279         (psymbol_bcache_init, psymbol_bcache_free)
2280         (psymbol_bcache_get_bcache): Don't declare.
2281         * psymtab.c (struct psymbol_bcache): Remove.
2282         (psymtab_storage::psymtab_storage): Update.
2283         (psymtab_storage::~psymtab_storage): Update.
2284         (psymbol_bcache_init, psymbol_bcache_free)
2285         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
2286         (add_psymbol_to_bcache): Update.
2287         (allocate_psymtab): Update.
2288         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
2289         macro_cache>: No longer pointers.
2290         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
2291         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
2292         * macrotab.c (macro_bcache): Update.
2293         * macroexp.c: Don't include bcache.h.
2294         * gdbtypes.c (check_types_worklist): Update.
2295         (types_deeply_equal): Remove TRY/CATCH.  Update.
2296         * elfread.c (elf_symtab_read): Update.
2297         * dwarf2read.c: Don't include bcache.h.
2298         * buildsym.c (buildsym_compunit::get_macro_table): Update.
2299         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
2300         (print_bcache_statistics, bcache_memory_used): Don't declare.
2301         (struct bcache): Move from bcache.c.  Add constructor, destructor,
2302         methods.  Rename all data members.
2303         * bcache.c (struct bcache): Move to bcache.h.
2304         (bcache::expand_hash_table): Rename from expand_hash_table.
2305         (bcache): Remove.
2306         (bcache::insert): Rename from bcache_full.
2307         (bcache::compare): Rename from bcache_compare.
2308         (bcache_xmalloc): Remove.
2309         (bcache::~bcache): Rename from bcache_xfree.
2310         (bcache::print_statistics): Rename from print_bcache_statistics.
2311         (bcache::memory_used): Rename from bcache_memory_used.
2312
2313 2019-03-07  Pedro Alves  <palves@redhat.com>
2314
2315         * infrun.c (normal_stop): Also check for
2316         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
2317
2318 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2319
2320         * f-lang.c (value_from_host_double): Moved to...
2321         * value.c (value_from_host_double): ...here.
2322         * value.h (value_from_host_double): Declare.
2323         * guile/scm-math.c (vlscm_convert_typed_number): Use
2324         value_from_host_double.
2325         (vlscm_convert_number): Likewise.
2326         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
2327         * python/py-value.c (convert_value_from_python): Likewise.
2328
2329 2019-03-06  Tom Tromey  <tom@tromey.com>
2330
2331         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
2332
2333 2019-03-06  Tom Tromey  <tom@tromey.com>
2334
2335         * utils.h (free_current_contents): Don't declare.
2336         * utils.c (free_current_contents): Remove.
2337
2338 2019-03-06  Tom Tromey  <tom@tromey.com>
2339
2340         * top.c (quit_force): Update.
2341         * main.c (captured_command_loop): Update.
2342         * common/new-op.c (operator new): Update.
2343         * common/common-exceptions.c (struct catcher)
2344         <save_cleanup_chain>: Remove member.
2345         (exceptions_state_mc_init): Update.
2346         (exception_try_scope_entry): Return nullptr.
2347         (exception_try_scope_exit, exception_rethrow)
2348         (throw_exception_sjlj, throw_exception_cxx): Update.
2349         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
2350         (all_cleanups, do_cleanups, discard_cleanups)
2351         (discard_final_cleanups, save_cleanups, save_final_cleanups)
2352         (restore_cleanups, restore_final_cleanups): Don't declare.
2353         (do_final_cleanups): Remove parameter.
2354         * common/cleanups.c (cleanup_chain, make_cleanup)
2355         (make_cleanup_dtor, all_cleanups, do_cleanups)
2356         (discard_my_cleanups, discard_cleanups)
2357         (discard_final_cleanups, save_my_cleanups, save_cleanups)
2358         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
2359         (null_cleanup): Remove.
2360         (do_final_cleanups): Remove parameter.
2361
2362 2019-03-06  Tom Tromey  <tom@tromey.com>
2363
2364         * remote.c (remote_target::remote_parse_stop_reply): Use
2365         unique_xmalloc_ptr.
2366
2367 2019-03-06  Tom Tromey  <tom@tromey.com>
2368
2369         * stabsread.c (struct stabs_field_info): Rename from field_info.
2370         <list, fnlist>: Add initializers.
2371         <obstack>: New member.
2372         (read_member_functions, read_struct_fields, read_baseclasses):
2373         Allocate on obstack.  Don't use cleanups.
2374         (read_one_struct_field, read_member_functions, read_struct_fields)
2375         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
2376         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
2377         (read_struct_type): Update.
2378
2379 2019-03-06  Tom Tromey  <tom@tromey.com>
2380
2381         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
2382         * common/filestuff.h (make_cleanup_close): Don't declare.
2383         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
2384         Remove.
2385
2386 2019-03-06  Tom Tromey  <tom@tromey.com>
2387
2388         * solib-aix.c: Use make_scope_exit.
2389
2390 2019-03-06  Tom Tromey  <tom@tromey.com>
2391
2392         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
2393         Use make_scope_exit.
2394
2395 2019-03-06  Tom Tromey  <tom@tromey.com>
2396
2397         * solib-svr4.c (disable_probes_interface): Remove parameter.
2398         (svr4_handle_solib_event): Use make_scope_exit.
2399
2400 2019-03-06  Tom Tromey  <tom@tromey.com>
2401
2402         * remote.c (struct stop_reply_deleter): Remove.
2403         (stop_reply_up): Update.
2404         (struct stop_reply): Derive from notif_event.  Don't typedef.
2405         <regcache>: Now a std::vector.
2406         (stop_reply_xfree): Remove.
2407         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
2408         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
2409         (remote_target::discard_pending_stop_replies): Use delete.
2410         (remote_target::remote_parse_stop_reply): Update.
2411         (remote_target::process_stop_reply): Update.
2412         * remote-notif.h (struct notif_event): Add virtual destructor.
2413         Remove "dtr" member.
2414         (struct notif_client) <alloc_event>: Return a unique_ptr.
2415         (notif_event_xfree): Don't declare.
2416         (notif_event_up): New typedef.
2417         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
2418         (notif_event_xfree, do_notif_event_xfree): Remove.
2419         (remote_notif_state_xfree): Update.
2420
2421 2019-03-06  Tom Tromey  <tom@tromey.com>
2422
2423         * infrun.c (displaced_step_clear_cleanup): Now a
2424         forward_scope_exit type.
2425         (displaced_step_prepare_throw): Update.
2426         (displaced_step_fixup): Update.
2427
2428 2019-03-06  Tom Tromey  <tom@tromey.com>
2429
2430         * inferior.h (class inferior): Update comment.
2431         * gdbthread.h (class thread_info): Update comment.
2432
2433 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
2434             Tom Tromey  <tom@tromey.com>
2435
2436         * stabsread.h (struct stab_section_list): Remove.
2437         (coffstab_build_psymtabs): Update.
2438         * dbxread.c (symbuf_sections): Now a std::vector.
2439         (sect_idx): New global.
2440         (fill_symbuf): Update.
2441         (coffstab_build_psymtabs): Change type of stabsects parameter.
2442         Update.
2443         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
2444         std::vector.
2445         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
2446         (coff_locate_sections): Update.
2447         (coff_symfile_read): Remove cleanups.  Update.
2448         (init_stringtab): Add storage parameter.
2449         (free_stringtab, free_stringtab_cleanup): Remove.
2450         (init_lineno): Add storage parameter.
2451         (free_linetab, free_linetab_cleanup): Remove.
2452
2453 2019-03-06  Pedro Alves  <palves@redhat.com>
2454
2455         * linux-fork.c (fork_info::clobber_regs): Delete.
2456         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
2457         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
2458         comment.  Adjust.
2459         (scoped_switch_fork_info::scoped_switch_fork_info)
2460         (checkpoint_command, linux_fork_context): Adjust
2461         fork_save_infrun_state calls.
2462
2463 2019-03-06  Pedro Alves  <palves@redhat.com>
2464
2465         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
2466         (inf_has_multiple_threads): Return 'bool' and rewrite using
2467         inferior_info::threads().
2468
2469 2019-03-06  Pedro Alves  <palves@redhat.com>
2470
2471         * linux-fork.c: Include <list>.
2472         (fork_list): Now a std::list instance.
2473         (fork_info): Add ctor, dtor, and in-class initialize all fields.
2474         (forks_exist_p, find_last_fork): Adjust.
2475         (new_fork): Delete.
2476         (one_fork_p): New.
2477         (add_fork): Adjust.
2478         (free_fork): Delete, folded into fork_info::~fork_info().
2479         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
2480         Adjust.
2481         (init_fork_list): Delete.
2482         (linux_fork_killall, linux_fork_mourn_inferior)
2483         (linux_fork_detach, info_checkpoints_command): Adjust.
2484         (_initialize_linux_fork): No longer call init_fork_list.
2485
2486 2019-03-06  Pedro Alves  <palves@redhat.com>
2487
2488         * linux-fork.c (new_fork): New, split out of ...
2489         (add_fork): ... this.  Return void.  Move "first fork" special
2490         case from here, to ...
2491         (checkpoint_command): ... here.
2492         * linux-linux.h (add_fork): Return void.
2493
2494 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2495
2496         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
2497
2498 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2499             Chris January  <chris.january@arm.com>
2500             David Lecomber  <david.lecomber@arm.com>
2501
2502         * f-exp.y: New token, UNOP_INTRINSIC.
2503         (exp): New pattern using UNOP_INTRINSIC token.
2504         (f77_keywords): Add 'abs' keyword.
2505         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
2506         (value_from_host_double): New function.
2507         (evaluate_subexp_f): Support UNOP_ABS.
2508
2509 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2510
2511         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
2512         types.
2513
2514 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2515
2516         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
2517         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
2518         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
2519
2520 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2521
2522         * f-exp.y (convert_to_kind_type): Handle more type kinds.
2523
2524 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2525             Chris January  <chris.january@arm.com>
2526
2527         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
2528         * f-exp.y: Define 'KIND' token.
2529         (exp): New pattern for KIND expressions.
2530         (ptype): Handle types with a kind extension.
2531         (direct_abs_decl): Extend to spot kind extensions.
2532         (f77_keywords): Add 'kind' to the list.
2533         (push_kind_type): New function.
2534         (convert_to_kind_type): New function.
2535         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
2536         * parse.c (operator_length_standard): Likewise.
2537         * parser-defs.h (enum type_pieces): Add tp_kind.
2538         * std-operator.def: Add UNOP_KIND.
2539
2540 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2541
2542         * f-exp.y (f_parse): Set yydebug.
2543
2544 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2545
2546         * f-lang.c (evaluate_subexp_f): New function.
2547         (exp_descriptor_f): New global.
2548         (f_language_defn): Use exp_descriptor_f instead of
2549         exp_descriptor_standard.
2550
2551 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2552
2553         * f-exp.y (struct token): Add comments.
2554         (dot_ops): Remove uppercase versions and the end marker.
2555         (f77_keywords): Likewise.
2556         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
2557         entries in the dot_ops array are case insensitive, and use
2558         strncasecmp to compare strings.  Also some whitespace cleanup in
2559         this area.  Similar for the f77_keywords array, except entries in
2560         this list might be case sensitive.
2561
2562 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2563
2564         * f-exp.y (struct f77_boolean_val): Add comments.
2565         (boolean_values): Remove uppercase versions, and end marker.
2566         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
2567         and use strncasecmp to achieve case insensitivity.  Additionally,
2568         perform whitespace cleanup around this code.
2569
2570 2019-03-06  Tom Tromey  <tromey@adacore.com>
2571
2572         * remote-sim.c (gdbsim_target_open): Use result of
2573         gdb_argv::release.
2574
2575 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
2576         Dirk Schubert  <dirk.schubert@arm.com>
2577         Chris January  <chris.january@arm.com>
2578
2579         * eval.c (evaluate_subexp_standard): Call Fortran argument
2580         wrapping logic.
2581         * f-lang.c (struct value): A value which can be passed into a
2582         Fortran function call.
2583         (fortran_argument_convert): Wrap Fortran arguments in a pointer
2584         where appropriate.
2585         (struct type): Value ready for a Fortran function call.
2586         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
2587         is needed.
2588         * f-lang.h (fortran_argument_convert): Declaration.
2589         (fortran_preserve_arg_pointer): Declaration.
2590         * infcall.c (value_arg_coerce): Call Fortran argument logic.
2591
2592 2019-03-05  Tom Tromey  <tromey@adacore.com>
2593
2594         * python/py-prettyprint.c (print_string_repr): Remove #if.
2595         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
2596
2597 2019-03-05  Tom Tromey  <tromey@adacore.com>
2598
2599         * target.c (the_dummy_target): Move later.  Change type to
2600         "dummy_target".
2601         (initialize_targets): Don't initialize the_dummy_target.
2602
2603 2019-03-05  Tom Tromey  <tromey@adacore.com>
2604
2605         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
2606         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
2607
2608 2019-03-05  Tom Tromey  <tromey@adacore.com>
2609
2610         * windows-nat.c (windows_nat_target::attach)
2611         (windows_nat_target::detach): Don't call gdb_flush.
2612         * valprint.c (generic_val_print, val_print, val_print_string):
2613         Don't call gdb_flush.
2614         * utils.c (defaulted_query): Don't call gdb_flush.
2615         * typeprint.c (print_type_scalar): Don't call gdb_flush.
2616         * target.c (target_announce_detach): Don't call gdb_flush.
2617         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
2618         * remote.c (extended_remote_target::attach): Don't call
2619         gdb_flush.
2620         * procfs.c (procfs_target::detach): Don't call gdb_flush.
2621         * printcmd.c (do_examine): Don't call gdb_flush.
2622         (info_display_command): Don't call gdb_flush.
2623         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
2624         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
2625         * memattr.c (info_mem_command): Don't call gdb_flush.
2626         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
2627         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
2628         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
2629         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
2630         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
2631         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
2632         (gnu_nat_target::detach): Don't call gdb_flush.
2633         * f-valprint.c (f_val_print): Don't call gdb_flush.
2634         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
2635         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
2636         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
2637         gdb_flush.
2638         * c-valprint.c (c_val_print): Don't call gdb_flush.
2639         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
2640
2641 2019-03-05  Tom Tromey  <tromey@adacore.com>
2642
2643         * varobj.c (update_dynamic_varobj_children): Update.
2644         (install_default_visualizer): Use reset, not release.
2645         * value.c (set_internalvar): Update.
2646         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
2647         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
2648         ATTRIBUTE_UNUSED_RESULT.
2649
2650 2019-03-05  Tom Tromey  <tromey@adacore.com>
2651
2652         * remote.c (class scoped_remote_fd) <release>: Add
2653         ATTRIBUTE_UNUSED_RESULT.
2654
2655 2019-03-05  Tom Tromey  <tromey@adacore.com>
2656
2657         * macroexp.c (struct macro_buffer) <release>: Add
2658         ATTRIBUTE_UNUSED_RESULT.
2659
2660 2019-03-05  Tom Tromey  <tromey@adacore.com>
2661
2662         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
2663         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
2664         ATTRIBUTE_UNUSED_RESULT.
2665
2666 2019-03-05  Tom Tromey  <tromey@adacore.com>
2667
2668         * common/scoped_fd.h (class scoped_fd) <release>: Add
2669         ATTRIBUTE_UNUSED_RESULT.
2670
2671 2019-03-05  Tom Tromey  <tromey@adacore.com>
2672
2673         * parser-defs.h (struct parser_state) <release>: Add
2674         ATTRIBUTE_UNUSED_RESULT.
2675
2676 2019-03-05  Tom Tromey  <tromey@adacore.com>
2677
2678         * utils.h (class gdb_argv) <release>: Add
2679         ATTRIBUTE_UNUSED_RESULT.
2680         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
2681
2682 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
2683
2684         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
2685         for-loop range, to avoid compiler warnings.
2686
2687         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
2688         avoid compiler warnings about unused variables.
2689
2690         * NEWS: Mention end of support for native debugging on MS-Windows
2691         before XP.
2692
2693         PR gdb/24292
2694         * common/netstuff.c:
2695         * gdbserver/gdbreplay.c
2696         * gdbserver/remote-utils.c:
2697         * ser-tcp.c:
2698         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
2699         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
2700         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
2701         'getaddrinfo' and 'freeaddrinfo' were not available before
2702         Windows XP, and mingw.org's MinGW headers by default define
2703         _WIN32_WINNT to 0x500.
2704
2705 2019-03-01  Gary Benson <gbenson@redhat.com>
2706
2707         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
2708
2709 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
2710             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2711
2712         PR gdb/8527
2713         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
2714         set_sigint_trap, clear_sigint_trap.
2715
2716 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2717
2718         * target.c (target_detach): Clear the regcache and the
2719         frame cache.
2720
2721 2019-02-27  Pedro Alves  <palves@redhat.com>
2722
2723         * utils.c (set_screen_size): When we cap the height/width sizes,
2724         tweak the corresponding command variable to show "unlimited":
2725
2726 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
2727             Pedro Alves  <palves@redhat.com>
2728
2729         * utils.c (set_screen_size): Reduce "infinite" rows and columns
2730         before calling rl_set_screen_size.
2731
2732 2019-02-27  Tom Tromey  <tromey@adacore.com>
2733
2734         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
2735         define.
2736         * python/py-value.c: Remove Python 2.4 workaround.
2737         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
2738         workaround.
2739         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
2740         Python 2.4 workaround.
2741         * python/python-internal.h: Remove Python 2.4 comment.
2742         (Py_ssize_t): Don't define.
2743         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
2744         (gdb_Py_DECREF): Remove Python 2.4 workaround.
2745         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
2746         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
2747         * python/python.c (do_start_initialization): Remove Python 2.4
2748         workaround.
2749         * python/py-prettyprint.c (class dummy_python_frame): Remove.
2750         (print_children): Remove Python 2.4 workaround.
2751         * python/py-inferior.c (buffer_procs): Remove Python 2.4
2752         workaround.
2753         (CHARBUFFERPROC_NAME): Remove.
2754         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
2755         Python 2.4 workaround.
2756
2757 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2758
2759         * NEWS: Note minimum Python version.
2760
2761 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2762
2763         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
2764         code from these functions.  Remove corresponding ifdefs.  Use
2765         Py_buffer_up instead of explicit calls to PyBuffer_Release.
2766         Remove gotos and target of gotos.
2767         (infpy_search_memory): Likewise.
2768
2769 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2770
2771         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
2772         (hppa_gdbarch_init): Don't register deleted functions with
2773         gdbarch.
2774
2775 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2776
2777         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
2778         (h8300_unwind_sp): Delete.
2779         (h8300_dummy_id): Delete.
2780         (h8300_gdbarch_init): Don't register deleted functions with
2781         gdbarch.
2782
2783 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2784
2785         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
2786         (ft32_unwind_pc): Delete.
2787         (ft32_unwind_sp): Delete.
2788         (ft32_gdbarch_init): Don't register deleted functions with
2789         gdbarch.
2790
2791 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2792
2793         * gdb/frv-tdep.c (frv_dummy_id): Delete.
2794         (frv_unwind_pc): Delete.
2795         (frv_unwind_sp): Delete.
2796         (frv_gdbarch_init): Don't register deleted functions with
2797         gdbarch.
2798
2799 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2800
2801         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
2802         (riscv_unwind_pc): Delete.
2803         (riscv_unwind_sp): Delete.
2804         (riscv_gdbarch_init): Don't register deleted functions with
2805         gdbarch.
2806
2807 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2808
2809         * gdb/csky-tdep.c (csky_dummy_id): Delete.
2810         (csky_unwind_pc): Delete.
2811         (csky_unwind_sp): Delete.
2812         (csky_gdbarch_init): Don't register deleted functions with
2813         gdbarch.
2814
2815 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2816
2817         * gdb/cris-tdep.c (cris_dummy_id): Delete.
2818         (cris_unwind_pc): Delete.
2819         (cris_unwind_sp): Delete.
2820         (cris_gdbarch_init): Don't register deleted functions with
2821         gdbarch.
2822
2823 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2824
2825         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
2826         (bfin_unwind_pc): Delete.
2827         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
2828
2829 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2830
2831         * gdb/arm-tdep.c (arm_dummy_id): Delete.
2832         (arm_unwind_pc): Delete.
2833         (arm_unwind_sp): Delete.
2834         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
2835
2836 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2837
2838         * gdb/arc-tdep.c (arc_dummy_id): Delete.
2839         (arc_unwind_pc): Delete.
2840         (arc_unwind_sp): Delete.
2841         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
2842
2843 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2844
2845         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
2846         (alpha_unwind_pc): Delete.
2847         (alpha_gdbarch_init): Don't register deleted functions with
2848         gdbarch.
2849
2850 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2851
2852         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
2853         (aarch64_unwind_pc): Delete.
2854         (aarch64_unwind_sp): Delete.
2855         (aarch64_gdbarch_init): Don't register deleted functions with
2856         gdbarch.
2857
2858 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2859
2860         * gdbtypes.c (type_align): Don't consider static members when
2861         computing structure alignment.
2862
2863 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2864
2865         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
2866         return 0 for other types.
2867         * arch-utils.c (default_type_align): Always return 0.
2868         * gdbarch.h: Regenerate.
2869         * gdbarch.sh (type_align): Extend comment.
2870         * gdbtypes.c (type_align): Add additional comments, always call
2871         gdbarch_type_align before applying the default rules.
2872         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
2873         generic code will then apply a suitable default.
2874         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
2875         types, return 0 for other types.
2876
2877 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
2878
2879         * NEWS: Create a new section for the next release branch.
2880         Rename the section of the current branch, now that it has
2881         been cut.
2882
2883 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
2884
2885         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
2886         * version.in: Bump version to 8.3.50.DATE-git.
2887
2888 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
2889
2890         * aix-thread.c (ptid_cmp): Remove unused variable.
2891         (get_signaled_thread): Likewise.
2892         (store_regs_user_thread): Likewise.
2893         (store_regs_kernel_thread): Likewise.
2894         (fetch_regs_kernel_thread): Remove shadowed variable.
2895
2896 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2897
2898         * features/riscv/32bit-cpu.xml: Add register numbers.
2899         * features/riscv/32bit-fpu.c: Regenerate.
2900         * features/riscv/32bit-fpu.xml: Add register numbers.
2901         * features/riscv/64bit-cpu.xml: Add register numbers.
2902         * features/riscv/64bit-fpu.c: Regenerate.
2903         * features/riscv/64bit-fpu.xml: Add register numbers.
2904
2905 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
2906
2907         * NEWS: Mention two argument form of gdb.Value constructor.
2908         * python/py-value.c (convert_buffer_and_type_to_value): New
2909         function.
2910         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
2911         Add support for handling an optional second argument.  Call
2912         convert_buffer_and_type_to_value as appropriate.
2913         * python/python-internal.h (Py_buffer_deleter): New struct.
2914         (Py_buffer_up): New typedef.
2915
2916 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
2917
2918         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
2919         instead of releasing ownership.
2920
2921 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
2922
2923         * dwarf2read.c (open_and_init_dwp_file): Call
2924         elf_numsections instead of bfd_count_sections to initialize
2925         dwp_file->num_sections.
2926
2927 2019-02-25  Tom Tromey  <tromey@adacore.com>
2928
2929         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
2930
2931 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2932
2933         * gcore.in: Add '--readnever' option when invoking GDB.
2934
2935 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
2936
2937         * MAINTAINERS: Update my email address.
2938
2939 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
2940
2941         * build-id.c (build_id_to_debug_bfd_1): New function.
2942         (build_id_to_debug_bfd): Look for separate debug file in
2943         sysroot.
2944
2945 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2946
2947         * gdbarch.sh: Update the copyright year range that is placed into
2948         generated files.
2949
2950 2019-02-22  Keith Seitz  <keiths@redhat.com>
2951
2952         PR symtab/23853
2953         * linespec.c (create_sals_line_offset): Search for the default
2954         symtab's filename instead of its fullname.
2955
2956 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
2957
2958         * NEWS: Update style defaults.
2959
2960 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
2961
2962         * main.c (captured_main_1): Disable styling in batch mode.
2963
2964 2019-02-20  Tom Tromey  <tom@tromey.com>
2965
2966         * symtab.c (symtab_symbol_info): Fix typos.
2967
2968 2019-02-20  Tom Tromey  <tromey@adacore.com>
2969
2970         * findcmd.c (_initialize_mem_search): Use upper case for
2971         metasyntactic variables.
2972
2973 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
2974
2975         * aarch64-tdep.c (aarch64_add_reggroups): New function.
2976         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
2977
2978 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
2979
2980         * top.h (source_file_name): Change to std::string.
2981         * top.c (source_file_name): Likewise.
2982         (command_line_input): Adjust.
2983         * cli/cli-script.c (script_from_file): Adjust.
2984
2985 2019-02-19  Tom Tromey  <tromey@adacore.com>
2986
2987         * ravenscar-thread.c
2988         (ravenscar_thread_target::update_thread_list): Don't call
2989         ada_build_task_list.
2990         * ada-lang.h (ada_build_task_list): Don't declare.
2991         * ada-tasks.c (struct ada_tasks_inferior_data)
2992         <task_list_valid_p>: Now bool.
2993         (read_known_tasks, ada_task_list_changed)
2994         (ada_tasks_invalidate_inferior_data): Update.
2995         (read_known_tasks_array): Return bool.
2996         (read_known_tasks_list): Likewise.
2997         (read_known_tasks): Return void.
2998         (ada_build_task_list): Now static.
2999
3000 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3001
3002         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3003         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3004
3005 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3006
3007         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
3008         variant for ada_tasks_pspace_data_handle and
3009         ada_tasks_inferior_data_handle.
3010         (ada_tasks_pspace_data_cleanup): New function.
3011         (ada_tasks_inferior_data_cleanup): New function.
3012
3013 2019-02-17  Tom Tromey  <tom@tromey.com>
3014
3015         * macrotab.h (macro_source_fullname): Return a std::string.
3016         * macrotab.c (macro_include, check_for_redefinition)
3017         (macro_undef, macro_lookup_definition, foreach_macro)
3018         (foreach_macro_in_scope): Update.
3019         (macro_source_fullname): Return a std::string.
3020         * macrocmd.c (show_pp_source_pos): Update.
3021
3022 2019-02-17  Tom Tromey  <tom@tromey.com>
3023
3024         * macrocmd.c (show_pp_source_pos): Style the file names.
3025
3026 2019-02-17  Tom Tromey  <tom@tromey.com>
3027
3028         PR tui/24197:
3029         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
3030
3031 2019-02-17  Tom Tromey  <tom@tromey.com>
3032
3033         * ada-lang.c (user_select_syms): Use filtered printing.
3034         * utils.c (wrap_style): New global.
3035         (desired_style): Remove.
3036         (emit_style_escape): Add stream parameter.
3037         (set_output_style, reset_terminal_style, prompt_for_continue):
3038         Update.
3039         (flush_wrap_buffer): Only flush gdb_stdout.
3040         (wrap_here): Set wrap_style.
3041         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
3042         treat escape sequences as a character.  Change when wrap buffer is
3043         flushed.
3044         (fputs_styled): Do not set the output style when the default is
3045         requested.
3046         * ui-style.h (struct ui_file_style) <is_default>: New method.
3047         * source.c (print_source_lines_base): Emit escape sequences in one
3048         piece.
3049
3050 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3051
3052         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
3053         integers and enumeration types.
3054
3055 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3056
3057         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
3058         instead of lookup_symbol_in_language
3059         (do_exact_match): New function.
3060         (ada_get_symbol_name_matcher): Return do_exact_match when
3061         doing a verbatim match.
3062
3063 2019-02-15  Tom Tromey  <tromey@adacore.com>
3064
3065         * ravenscar-thread.c (ravenscar_thread_target::resume)
3066         (ravenscar_thread_target::wait): Special case wildcard requests.
3067
3068 2019-02-15  Tom Tromey  <tromey@adacore.com>
3069
3070         * ravenscar-thread.c (base_ptid): Remove.
3071         (struct ravenscar_thread_target) <close>: New method.
3072         <m_base_ptid>: New member.
3073         <update_inferior_ptid, active_task, task_is_currently_active,
3074         runtime_initialized>: Declare methods.
3075         <ravenscar_thread_target>: Add constructor.
3076         (ravenscar_thread_target::task_is_currently_active)
3077         (ravenscar_thread_target::update_inferior_ptid)
3078         (ravenscar_runtime_initialized): Rename.  Now methods.
3079         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
3080         (ravenscar_thread_target::update_thread_list): Update.
3081         (ravenscar_thread_target::active_task): Now method.
3082         (ravenscar_thread_target::store_registers)
3083         (ravenscar_thread_target::prepare_to_store)
3084         (ravenscar_thread_target::prepare_to_store)
3085         (ravenscar_thread_target::mourn_inferior): Update.
3086         (ravenscar_inferior_created): Use "new" to create target.
3087         (ravenscar_thread_target::get_ada_task_ptid): Update.
3088         (_initialize_ravenscar): Don't initialize base_ptid.
3089         (ravenscar_ops): Remove global.
3090
3091 2019-02-15  Tom Tromey  <tromey@adacore.com>
3092
3093         * target.h (push_target): Declare new overload.
3094         * target.c (push_target): New overload, taking an rvalue reference.
3095         * remote.c (remote_target::open_1): Use push_target overload.
3096         * corelow.c (core_target_open): Use push_target overload.
3097
3098 2019-02-15  Tom Tromey  <tromey@adacore.com>
3099
3100         * ravenscar-thread.c (is_ravenscar_task)
3101         (ravenscar_task_is_currently_active): Return bool.
3102         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
3103         (_initialize_ravenscar): Remove "(void)".
3104         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
3105         Return bool.
3106
3107 2019-02-15  Tom Tromey  <tromey@adacore.com>
3108
3109         * ravenscar-thread.c (ravenscar_runtime_initializer)
3110         (has_ravenscar_runtime, get_running_thread_id)
3111         (ravenscar_thread_target::resume): Fix indentation.
3112
3113 2019-02-15  Tom Tromey  <tromey@adacore.com>
3114
3115         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
3116         from ravenscar_arch_ops.
3117         (sparc_ravenscar_ops::fetch_registers)
3118         (sparc_ravenscar_ops::store_registers): Now methods.
3119         (sparc_ravenscar_prepare_to_store): Remove.
3120         (sparc_ravenscar_ops): Redefine.
3121         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
3122         methods and destructor.  Remove members.
3123         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
3124         (ravenscar_thread_target::store_registers)
3125         (ravenscar_thread_target::prepare_to_store): Update.
3126         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
3127         Remove.
3128         (struct ppc_ravenscar_powerpc_ops): Derive from
3129         ravenscar_arch_ops.
3130         (ppc_ravenscar_powerpc_ops::fetch_registers)
3131         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
3132         (ppc_ravenscar_powerpc_ops): Redefine.
3133         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
3134         (ppc_ravenscar_e500_ops::fetch_registers)
3135         (ppc_ravenscar_e500_ops::store_registers): Now methods.
3136         (ppc_ravenscar_e500_ops): Redefine.
3137         * aarch64-ravenscar-thread.c
3138         (aarch64_ravenscar_generic_prepare_to_store): Remove.
3139         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
3140         (aarch64_ravenscar_fetch_registers)
3141         (aarch64_ravenscar_store_registers): Now methods.
3142         (aarch64_ravenscar_ops): Redefine.
3143
3144 2019-02-15  Tom Tromey  <tromey@adacore.com>
3145
3146         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
3147         (ravenscar_thread_target::stopped_by_hw_breakpoint)
3148         (ravenscar_thread_target::stopped_by_watchpoint)
3149         (ravenscar_thread_target::stopped_data_address)
3150         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
3151
3152 2019-02-15  Tom Tromey  <tromey@adacore.com>
3153
3154         * ravenscar-thread.c: Fix some typos.
3155
3156 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3157             Tom Tromey  <tromey@adacore.com>
3158
3159         * ada-lang.c (ada_exception_sal): Change addr_string to a
3160         std::string.
3161         (create_ada_exception_catchpoint): Update.
3162
3163 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3164             Tom Tromey  <tromey@adacore.com>
3165
3166         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
3167         (bp_location_ops): Remove.
3168         (base_breakpoint_allocate_location): Update.
3169         (free_bp_location): Update.
3170         * ada-lang.c (class ada_catchpoint_location)
3171         <ada_catchpoint_location>: Remove ops parameter.
3172         (ada_catchpoint_location_dtor): Remove.
3173         (ada_catchpoint_location_ops): Remove.
3174         (allocate_location_exception): Update.
3175         * breakpoint.h (struct bp_location_ops): Remove.
3176         (class bp_location) <bp_location>: Remove bp_location_ops
3177         parameter.
3178         <~bp_location>: Add destructor.
3179         <ops>: Remove.
3180
3181 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3182             Pedro Alves  <palves@redhat.com>
3183
3184         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
3185         'PATH_MAX'.
3186
3187 2019-02-14  David Michael  <fedora.dm0@gmail.com>
3188             Samuel Thibault  <samuel.thibault@gnu.org>
3189             Thomas Schwinge  <thomas@codesourcery.com>
3190
3191         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
3192         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
3193
3194 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3195
3196         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
3197         (check_empty): Use "const char *".
3198
3199         * gnu-nat.c (gnu_nat_target::detach): Instead of
3200         'detach_inferior (pid)' call
3201         'detach_inferior (find_inferior_pid (pid))'.
3202
3203         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
3204         'nat/fork-inferior.o'.
3205         * gnu-nat.c: #include "nat/fork-inferior.h".
3206
3207         * gnu-nat.c (gnu_nat_target::detach): Instead of
3208         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
3209         * gnu-nat.h: #include "inf-child.h".
3210         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
3211         'i386_gnu_nat_target::fetch_registers'.
3212         (gnu_store_registers): Rename/move to
3213         'i386_gnu_nat_target::store_registers'.
3214
3215         * config/i386/nm-i386gnu.h: Don't "#include" any files.
3216         * gnu-nat.h (mach_thread_info): New function.
3217         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
3218
3219         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
3220
3221 2019-02-14  Frederic Konrad  <konrad@adacore.com>
3222
3223         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
3224
3225 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
3226
3227         * windows-nat.c (windows_add_thread): Add new parameter
3228         "main_thread_p" with default value set to false.  Update
3229         function documentation as well as all callers.
3230         (windows_delete_thread): Likewise.
3231         (fake_create_process): Update call to windows_add_thread.
3232         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
3233         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
3234         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
3235         call to windows_delete_thread.
3236
3237 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
3238
3239         * MAINTAINERS: Add Andrew Burgess as global maintainer.
3240
3241 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3242
3243         * symfile.c (find_separate_debug_file): Use canonical path of
3244         sysroot with child_path instead of gdb_sysroot if it is valid.
3245
3246 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3247
3248         * symfile.c (find_separate_debug_file): Use child_path to
3249         determine if an object file is under a sysroot.
3250
3251 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3252
3253         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3254         unittests/child-path-selftests.c.
3255         * common/pathstuff.c (child_path): New function.
3256         * common/pathstuff.h (child_path): New prototype.
3257         * unittests/child-path-selftests.c: New file.
3258
3259 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3260
3261         * symfile.c (find_separate_debug_file): Look for separate debug
3262         files in debug directories under the sysroot.
3263
3264 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3265
3266         * symtab.h (struct minimal_symbol data_p): New const method.
3267         (struct minimal_symbol text_p): Likewise.
3268         * symtab.c (output_source_filename): Use file name style
3269         to print file name.
3270         (print_symbol_info): Likewise.
3271         (print_msymbol_info): Use address style to print addresses.
3272         Use function name style to print executable text symbols.
3273         (expand_symtab_containing_pc): Use data_p.
3274         (find_pc_sect_compunit_symtab): Likewise.
3275
3276 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3277
3278         * breakpoint.c (describe_other_breakpoints): Use address style
3279         to print addresses.
3280         (say_where): Likewise.
3281
3282 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3283
3284         * ada-typeprint.c (print_func_type): Print function name
3285         style to print function name.
3286         * c-typeprint.c (c_print_type_1): Likewise.
3287
3288 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
3289
3290         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
3291         for execve.
3292
3293 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3294
3295         * c-exp.y (direct_abs_decl): Use emplace_back to record the
3296         type_stack.
3297
3298 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
3299
3300         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
3301         TYPE_CODE_REF types.
3302
3303 2019-02-08  Jim Wilson  <jimw@sifive.com>
3304
3305         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
3306         (riscv_linux_fregset): New.
3307         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
3308
3309 2019-02-07  Tom Tromey  <tom@tromey.com>
3310
3311         * thread.c (thread_cancel_execution_command): Update.
3312         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
3313         methods.
3314         (struct thread_fsm_ops): Remove.
3315         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
3316         (thread_fsm_should_stop, thread_fsm_return_value)
3317         (thread_fsm_set_finished, thread_fsm_finished_p)
3318         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
3319         Don't declare.
3320         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
3321         * infrun.c (clear_proceed_status_thread)
3322         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
3323         (print_stop_event): Update.
3324         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
3325         Add constructor.
3326         (step_command_fsm_ops): Remove.
3327         (new_step_command_fsm): Remove.
3328         (step_1): Update.
3329         (step_command_fsm::should_stop): Rename from
3330         step_command_fsm_should_stop.
3331         (step_command_fsm::clean_up): Rename from
3332         step_command_fsm_clean_up.
3333         (step_command_fsm::do_async_reply_reason): Rename from
3334         step_command_fsm_async_reply_reason.
3335         (struct until_next_fsm): Inherit from thread_fsm.  Add
3336         constructor.
3337         (until_next_fsm_ops): Remove.
3338         (new_until_next_fsm): Remove.
3339         (until_next_fsm::should_stop): Rename from
3340         until_next_fsm_should_stop.
3341         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
3342         (until_next_fsm::do_async_reply_reason): Rename from
3343         until_next_fsm_async_reply_reason.
3344         (struct finish_command_fsm): Inherit from thread_fsm.  Add
3345         constructor.  Change type of breakpoint.
3346         (finish_command_fsm_ops): Remove.
3347         (new_finish_command_fsm): Remove.
3348         (finish_command_fsm::should_stop): Rename from
3349         finish_command_fsm_should_stop.
3350         (finish_command_fsm::clean_up): Rename from
3351         finish_command_fsm_clean_up.
3352         (finish_command_fsm::return_value): Rename from
3353         finish_command_fsm_return_value.
3354         (finish_command_fsm::do_async_reply_reason): Rename from
3355         finish_command_fsm_async_reply_reason.
3356         (finish_command): Update.
3357         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
3358         Add constructor.
3359         (call_thread_fsm_ops): Remove.
3360         (call_thread_fsm::call_thread_fsm): Rename from
3361         new_call_thread_fsm.
3362         (call_thread_fsm::should_stop): Rename from
3363         call_thread_fsm_should_stop.
3364         (call_thread_fsm::should_notify_stop): Rename from
3365         call_thread_fsm_should_notify_stop.
3366         (run_inferior_call, call_function_by_hand_dummy): Update.
3367         * cli/cli-interp.c (should_print_stop_to_console): Update.
3368         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
3369         Add constructor.  Change type of location_breakpoint,
3370         caller_breakpoint.
3371         (until_break_fsm_ops): Remove.
3372         (new_until_break_fsm): Remove.
3373         (until_break_fsm::should_stop): Rename from
3374         until_break_fsm_should_stop.
3375         (until_break_fsm::clean_up): Rename from
3376         until_break_fsm_clean_up.
3377         (until_break_fsm::do_async_reply_reason): Rename from
3378         until_break_fsm_async_reply_reason.
3379         (until_break_command): Update.
3380         * thread-fsm.c: Remove.
3381         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
3382
3383 2019-02-07  Tom Tromey  <tom@tromey.com>
3384
3385         * yy-remap.h: Add include guard.
3386         * xtensa-tdep.h: Add include guard.
3387         * xcoffread.h: Rename include guard.
3388         * varobj-iter.h: Add include guard.
3389         * tui/tui.h: Rename include guard.
3390         * tui/tui-winsource.h: Rename include guard.
3391         * tui/tui-wingeneral.h: Rename include guard.
3392         * tui/tui-windata.h: Rename include guard.
3393         * tui/tui-win.h: Rename include guard.
3394         * tui/tui-stack.h: Rename include guard.
3395         * tui/tui-source.h: Rename include guard.
3396         * tui/tui-regs.h: Rename include guard.
3397         * tui/tui-out.h: Rename include guard.
3398         * tui/tui-layout.h: Rename include guard.
3399         * tui/tui-io.h: Rename include guard.
3400         * tui/tui-hooks.h: Rename include guard.
3401         * tui/tui-file.h: Rename include guard.
3402         * tui/tui-disasm.h: Rename include guard.
3403         * tui/tui-data.h: Rename include guard.
3404         * tui/tui-command.h: Rename include guard.
3405         * tic6x-tdep.h: Add include guard.
3406         * target/waitstatus.h: Rename include guard.
3407         * target/wait.h: Rename include guard.
3408         * target/target.h: Rename include guard.
3409         * target/resume.h: Rename include guard.
3410         * target-float.h: Rename include guard.
3411         * stabsread.h: Add include guard.
3412         * rs6000-tdep.h: Add include guard.
3413         * riscv-fbsd-tdep.h: Add include guard.
3414         * regformats/regdef.h: Rename include guard.
3415         * record.h: Rename include guard.
3416         * python/python.h: Rename include guard.
3417         * python/python-internal.h: Rename include guard.
3418         * python/py-stopevent.h: Rename include guard.
3419         * python/py-ref.h: Rename include guard.
3420         * python/py-record.h: Rename include guard.
3421         * python/py-record-full.h: Rename include guard.
3422         * python/py-record-btrace.h: Rename include guard.
3423         * python/py-instruction.h: Rename include guard.
3424         * python/py-events.h: Rename include guard.
3425         * python/py-event.h: Rename include guard.
3426         * procfs.h: Add include guard.
3427         * proc-utils.h: Add include guard.
3428         * p-lang.h: Add include guard.
3429         * or1k-tdep.h: Rename include guard.
3430         * observable.h: Rename include guard.
3431         * nto-tdep.h: Rename include guard.
3432         * nat/x86-linux.h: Rename include guard.
3433         * nat/x86-linux-dregs.h: Rename include guard.
3434         * nat/x86-gcc-cpuid.h: Add include guard.
3435         * nat/x86-dregs.h: Rename include guard.
3436         * nat/x86-cpuid.h: Rename include guard.
3437         * nat/ppc-linux.h: Rename include guard.
3438         * nat/mips-linux-watch.h: Rename include guard.
3439         * nat/linux-waitpid.h: Rename include guard.
3440         * nat/linux-ptrace.h: Rename include guard.
3441         * nat/linux-procfs.h: Rename include guard.
3442         * nat/linux-osdata.h: Rename include guard.
3443         * nat/linux-nat.h: Rename include guard.
3444         * nat/linux-namespaces.h: Rename include guard.
3445         * nat/linux-btrace.h: Rename include guard.
3446         * nat/glibc_thread_db.h: Rename include guard.
3447         * nat/gdb_thread_db.h: Rename include guard.
3448         * nat/gdb_ptrace.h: Rename include guard.
3449         * nat/fork-inferior.h: Rename include guard.
3450         * nat/amd64-linux-siginfo.h: Rename include guard.
3451         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
3452         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
3453         * nat/aarch64-linux.h: Rename include guard.
3454         * nat/aarch64-linux-hw-point.h: Rename include guard.
3455         * mn10300-tdep.h: Add include guard.
3456         * mips-linux-tdep.h: Add include guard.
3457         * mi/mi-parse.h: Rename include guard.
3458         * mi/mi-out.h: Rename include guard.
3459         * mi/mi-main.h: Rename include guard.
3460         * mi/mi-interp.h: Rename include guard.
3461         * mi/mi-getopt.h: Rename include guard.
3462         * mi/mi-console.h: Rename include guard.
3463         * mi/mi-common.h: Rename include guard.
3464         * mi/mi-cmds.h: Rename include guard.
3465         * mi/mi-cmd-break.h: Rename include guard.
3466         * m2-lang.h: Add include guard.
3467         * location.h: Rename include guard.
3468         * linux-record.h: Rename include guard.
3469         * linux-nat.h: Add include guard.
3470         * linux-fork.h: Add include guard.
3471         * i386-darwin-tdep.h: Rename include guard.
3472         * hppa-linux-offsets.h: Add include guard.
3473         * guile/guile.h: Rename include guard.
3474         * guile/guile-internal.h: Rename include guard.
3475         * gnu-nat.h: Rename include guard.
3476         * gdb-stabs.h: Rename include guard.
3477         * frv-tdep.h: Add include guard.
3478         * f-lang.h: Add include guard.
3479         * event-loop.h: Add include guard.
3480         * darwin-nat.h: Rename include guard.
3481         * cp-abi.h: Rename include guard.
3482         * config/sparc/nm-sol2.h: Rename include guard.
3483         * config/nm-nto.h: Rename include guard.
3484         * config/nm-linux.h: Add include guard.
3485         * config/i386/nm-i386gnu.h: Rename include guard.
3486         * config/djgpp/nl_types.h: Rename include guard.
3487         * config/djgpp/langinfo.h: Rename include guard.
3488         * compile/gcc-cp-plugin.h: Add include guard.
3489         * compile/gcc-c-plugin.h: Add include guard.
3490         * compile/compile.h: Rename include guard.
3491         * compile/compile-object-run.h: Rename include guard.
3492         * compile/compile-object-load.h: Rename include guard.
3493         * compile/compile-internal.h: Rename include guard.
3494         * compile/compile-cplus.h: Rename include guard.
3495         * compile/compile-c.h: Rename include guard.
3496         * common/xml-utils.h: Rename include guard.
3497         * common/x86-xstate.h: Rename include guard.
3498         * common/version.h: Rename include guard.
3499         * common/vec.h: Rename include guard.
3500         * common/tdesc.h: Rename include guard.
3501         * common/selftest.h: Rename include guard.
3502         * common/scoped_restore.h: Rename include guard.
3503         * common/scoped_mmap.h: Rename include guard.
3504         * common/scoped_fd.h: Rename include guard.
3505         * common/safe-iterator.h: Rename include guard.
3506         * common/run-time-clock.h: Rename include guard.
3507         * common/refcounted-object.h: Rename include guard.
3508         * common/queue.h: Rename include guard.
3509         * common/ptid.h: Rename include guard.
3510         * common/print-utils.h: Rename include guard.
3511         * common/preprocessor.h: Rename include guard.
3512         * common/pathstuff.h: Rename include guard.
3513         * common/observable.h: Rename include guard.
3514         * common/netstuff.h: Rename include guard.
3515         * common/job-control.h: Rename include guard.
3516         * common/host-defs.h: Rename include guard.
3517         * common/gdb_wait.h: Rename include guard.
3518         * common/gdb_vecs.h: Rename include guard.
3519         * common/gdb_unlinker.h: Rename include guard.
3520         * common/gdb_unique_ptr.h: Rename include guard.
3521         * common/gdb_tilde_expand.h: Rename include guard.
3522         * common/gdb_sys_time.h: Rename include guard.
3523         * common/gdb_string_view.h: Rename include guard.
3524         * common/gdb_splay_tree.h: Rename include guard.
3525         * common/gdb_setjmp.h: Rename include guard.
3526         * common/gdb_ref_ptr.h: Rename include guard.
3527         * common/gdb_optional.h: Rename include guard.
3528         * common/gdb_locale.h: Rename include guard.
3529         * common/gdb_assert.h: Rename include guard.
3530         * common/filtered-iterator.h: Rename include guard.
3531         * common/filestuff.h: Rename include guard.
3532         * common/fileio.h: Rename include guard.
3533         * common/environ.h: Rename include guard.
3534         * common/common-utils.h: Rename include guard.
3535         * common/common-types.h: Rename include guard.
3536         * common/common-regcache.h: Rename include guard.
3537         * common/common-inferior.h: Rename include guard.
3538         * common/common-gdbthread.h: Rename include guard.
3539         * common/common-exceptions.h: Rename include guard.
3540         * common/common-defs.h: Rename include guard.
3541         * common/common-debug.h: Rename include guard.
3542         * common/cleanups.h: Rename include guard.
3543         * common/buffer.h: Rename include guard.
3544         * common/btrace-common.h: Rename include guard.
3545         * common/break-common.h: Rename include guard.
3546         * cli/cli-utils.h: Rename include guard.
3547         * cli/cli-style.h: Rename include guard.
3548         * cli/cli-setshow.h: Rename include guard.
3549         * cli/cli-script.h: Rename include guard.
3550         * cli/cli-interp.h: Rename include guard.
3551         * cli/cli-decode.h: Rename include guard.
3552         * cli/cli-cmds.h: Rename include guard.
3553         * charset-list.h: Add include guard.
3554         * buildsym-legacy.h: Rename include guard.
3555         * bfin-tdep.h: Add include guard.
3556         * ax.h: Rename include guard.
3557         * arm-linux-tdep.h: Add include guard.
3558         * arm-fbsd-tdep.h: Add include guard.
3559         * arch/xtensa.h: Rename include guard.
3560         * arch/tic6x.h: Add include guard.
3561         * arch/i386.h: Add include guard.
3562         * arch/arm.h: Rename include guard.
3563         * arch/arm-linux.h: Rename include guard.
3564         * arch/arm-get-next-pcs.h: Rename include guard.
3565         * arch/amd64.h: Add include guard.
3566         * arch/aarch64-insn.h: Rename include guard.
3567         * arch-utils.h: Rename include guard.
3568         * annotate.h: Add include guard.
3569         * amd64-darwin-tdep.h: Rename include guard.
3570         * aarch64-linux-tdep.h: Add include guard.
3571         * aarch64-fbsd-tdep.h: Add include guard.
3572         * aarch32-linux-nat.h: Add include guard.
3573
3574 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3575
3576         * macrotab.c (macro_define_internal): New function that
3577         factorizes macro_define_object_internal and macro_define_function
3578         code.
3579         (macro_define_object_internal): Use macro_define_internal.
3580         (macro_define_function): Likewise.
3581
3582 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3583
3584         * macrocmd.c (extract_identifier): Return
3585         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
3586         callers.
3587
3588 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
3589
3590         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
3591
3592 2019-02-05  Tom Tromey  <tom@tromey.com>
3593
3594         * target.c (target_stack::unpush): Move assertion earlier.
3595
3596 2019-01-30  Tom Tromey  <tom@tromey.com>
3597
3598         PR python/23615:
3599         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
3600         (gdbpy_parse_and_eval): Likewise.
3601         * python/python-internal.h (gdbpy_allow_threads): New class.
3602
3603 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
3604
3605         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
3606         (aarch64_fbsd_fpregmap): Move earlier.
3607         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
3608         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3609         instead of individual calls to trad_frame_set_reg_addr.
3610         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
3611         earlier.
3612         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
3613         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3614         instead of individual calls to trad_frame_set_reg_addr.
3615
3616 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
3617
3618         * CONTRIBUTE: Replace contribution list with wiki link.
3619
3620 2019-01-25  Tom Tromey  <tom@tromey.com>
3621
3622         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
3623
3624 2019-01-25  Tom Tromey  <tom@tromey.com>
3625
3626         * xtensa-linux-nat.c: Fix common/ includes.
3627         * xml-support.h: Fix common/ includes.
3628         * xml-support.c: Fix common/ includes.
3629         * x86-linux-nat.c: Fix common/ includes.
3630         * windows-nat.c: Fix common/ includes.
3631         * varobj.h: Fix common/ includes.
3632         * varobj.c: Fix common/ includes.
3633         * value.c: Fix common/ includes.
3634         * valops.c: Fix common/ includes.
3635         * utils.c: Fix common/ includes.
3636         * unittests/xml-utils-selftests.c: Fix common/ includes.
3637         * unittests/utils-selftests.c: Fix common/ includes.
3638         * unittests/unpack-selftests.c: Fix common/ includes.
3639         * unittests/tracepoint-selftests.c: Fix common/ includes.
3640         * unittests/style-selftests.c: Fix common/ includes.
3641         * unittests/string_view-selftests.c: Fix common/ includes.
3642         * unittests/scoped_restore-selftests.c: Fix common/ includes.
3643         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
3644         * unittests/scoped_fd-selftests.c: Fix common/ includes.
3645         * unittests/rsp-low-selftests.c: Fix common/ includes.
3646         * unittests/parse-connection-spec-selftests.c: Fix common/
3647         includes.
3648         * unittests/optional-selftests.c: Fix common/ includes.
3649         * unittests/offset-type-selftests.c: Fix common/ includes.
3650         * unittests/observable-selftests.c: Fix common/ includes.
3651         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
3652         * unittests/memrange-selftests.c: Fix common/ includes.
3653         * unittests/memory-map-selftests.c: Fix common/ includes.
3654         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
3655         * unittests/function-view-selftests.c: Fix common/ includes.
3656         * unittests/environ-selftests.c: Fix common/ includes.
3657         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
3658         * unittests/common-utils-selftests.c: Fix common/ includes.
3659         * unittests/cli-utils-selftests.c: Fix common/ includes.
3660         * unittests/array-view-selftests.c: Fix common/ includes.
3661         * ui-file.c: Fix common/ includes.
3662         * tui/tui-io.c: Fix common/ includes.
3663         * tracepoint.h: Fix common/ includes.
3664         * tracepoint.c: Fix common/ includes.
3665         * tracefile-tfile.c: Fix common/ includes.
3666         * top.h: Fix common/ includes.
3667         * top.c: Fix common/ includes.
3668         * thread.c: Fix common/ includes.
3669         * target/waitstatus.h: Fix common/ includes.
3670         * target/waitstatus.c: Fix common/ includes.
3671         * target.h: Fix common/ includes.
3672         * target.c: Fix common/ includes.
3673         * target-memory.c: Fix common/ includes.
3674         * target-descriptions.c: Fix common/ includes.
3675         * symtab.h: Fix common/ includes.
3676         * symfile.c: Fix common/ includes.
3677         * stap-probe.c: Fix common/ includes.
3678         * spu-linux-nat.c: Fix common/ includes.
3679         * sparc-nat.c: Fix common/ includes.
3680         * source.c: Fix common/ includes.
3681         * solib.c: Fix common/ includes.
3682         * solib-target.c: Fix common/ includes.
3683         * ser-unix.c: Fix common/ includes.
3684         * ser-tcp.c: Fix common/ includes.
3685         * ser-pipe.c: Fix common/ includes.
3686         * ser-base.c: Fix common/ includes.
3687         * selftest-arch.c: Fix common/ includes.
3688         * s12z-tdep.c: Fix common/ includes.
3689         * rust-exp.y: Fix common/ includes.
3690         * rs6000-aix-tdep.c: Fix common/ includes.
3691         * riscv-tdep.c: Fix common/ includes.
3692         * remote.c: Fix common/ includes.
3693         * remote-notif.h: Fix common/ includes.
3694         * remote-fileio.h: Fix common/ includes.
3695         * remote-fileio.c: Fix common/ includes.
3696         * regcache.h: Fix common/ includes.
3697         * regcache.c: Fix common/ includes.
3698         * record-btrace.c: Fix common/ includes.
3699         * python/python.c: Fix common/ includes.
3700         * python/py-type.c: Fix common/ includes.
3701         * python/py-inferior.c: Fix common/ includes.
3702         * progspace.h: Fix common/ includes.
3703         * producer.c: Fix common/ includes.
3704         * procfs.c: Fix common/ includes.
3705         * proc-api.c: Fix common/ includes.
3706         * printcmd.c: Fix common/ includes.
3707         * ppc-linux-nat.c: Fix common/ includes.
3708         * parser-defs.h: Fix common/ includes.
3709         * osdata.c: Fix common/ includes.
3710         * obsd-nat.c: Fix common/ includes.
3711         * nat/x86-linux.c: Fix common/ includes.
3712         * nat/x86-linux-dregs.c: Fix common/ includes.
3713         * nat/x86-dregs.h: Fix common/ includes.
3714         * nat/x86-dregs.c: Fix common/ includes.
3715         * nat/ppc-linux.c: Fix common/ includes.
3716         * nat/mips-linux-watch.h: Fix common/ includes.
3717         * nat/mips-linux-watch.c: Fix common/ includes.
3718         * nat/linux-waitpid.c: Fix common/ includes.
3719         * nat/linux-ptrace.h: Fix common/ includes.
3720         * nat/linux-ptrace.c: Fix common/ includes.
3721         * nat/linux-procfs.c: Fix common/ includes.
3722         * nat/linux-personality.c: Fix common/ includes.
3723         * nat/linux-osdata.c: Fix common/ includes.
3724         * nat/linux-namespaces.c: Fix common/ includes.
3725         * nat/linux-btrace.h: Fix common/ includes.
3726         * nat/linux-btrace.c: Fix common/ includes.
3727         * nat/fork-inferior.c: Fix common/ includes.
3728         * nat/amd64-linux-siginfo.c: Fix common/ includes.
3729         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
3730         * nat/aarch64-linux.c: Fix common/ includes.
3731         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
3732         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
3733         * namespace.h: Fix common/ includes.
3734         * mips-linux-tdep.c: Fix common/ includes.
3735         * minsyms.c: Fix common/ includes.
3736         * mi/mi-parse.h: Fix common/ includes.
3737         * mi/mi-main.c: Fix common/ includes.
3738         * mi/mi-cmd-env.c: Fix common/ includes.
3739         * memrange.h: Fix common/ includes.
3740         * memattr.c: Fix common/ includes.
3741         * maint.h: Fix common/ includes.
3742         * maint.c: Fix common/ includes.
3743         * main.c: Fix common/ includes.
3744         * machoread.c: Fix common/ includes.
3745         * location.c: Fix common/ includes.
3746         * linux-thread-db.c: Fix common/ includes.
3747         * linux-nat.c: Fix common/ includes.
3748         * linux-fork.c: Fix common/ includes.
3749         * inline-frame.c: Fix common/ includes.
3750         * infrun.c: Fix common/ includes.
3751         * inflow.c: Fix common/ includes.
3752         * inferior.h: Fix common/ includes.
3753         * inferior.c: Fix common/ includes.
3754         * infcmd.c: Fix common/ includes.
3755         * inf-ptrace.c: Fix common/ includes.
3756         * inf-child.c: Fix common/ includes.
3757         * ia64-linux-nat.c: Fix common/ includes.
3758         * i387-tdep.c: Fix common/ includes.
3759         * i386-tdep.c: Fix common/ includes.
3760         * i386-linux-tdep.c: Fix common/ includes.
3761         * i386-linux-nat.c: Fix common/ includes.
3762         * i386-go32-tdep.c: Fix common/ includes.
3763         * i386-fbsd-tdep.c: Fix common/ includes.
3764         * i386-fbsd-nat.c: Fix common/ includes.
3765         * guile/scm-type.c: Fix common/ includes.
3766         * guile/guile.c: Fix common/ includes.
3767         * go32-nat.c: Fix common/ includes.
3768         * gnu-nat.c: Fix common/ includes.
3769         * gdbthread.h: Fix common/ includes.
3770         * gdbarch-selftests.c: Fix common/ includes.
3771         * gdb_usleep.c: Fix common/ includes.
3772         * gdb_select.h: Fix common/ includes.
3773         * gdb_bfd.c: Fix common/ includes.
3774         * gcore.c: Fix common/ includes.
3775         * fork-child.c: Fix common/ includes.
3776         * findvar.c: Fix common/ includes.
3777         * fbsd-nat.c: Fix common/ includes.
3778         * event-top.c: Fix common/ includes.
3779         * event-loop.c: Fix common/ includes.
3780         * dwarf2read.c: Fix common/ includes.
3781         * dwarf2loc.c: Fix common/ includes.
3782         * dwarf2-frame.c: Fix common/ includes.
3783         * dwarf-index-cache.c: Fix common/ includes.
3784         * dtrace-probe.c: Fix common/ includes.
3785         * disasm-selftests.c: Fix common/ includes.
3786         * defs.h: Fix common/ includes.
3787         * csky-tdep.c: Fix common/ includes.
3788         * cp-valprint.c: Fix common/ includes.
3789         * cp-support.h: Fix common/ includes.
3790         * cp-support.c: Fix common/ includes.
3791         * corelow.c: Fix common/ includes.
3792         * completer.h: Fix common/ includes.
3793         * completer.c: Fix common/ includes.
3794         * compile/compile.c: Fix common/ includes.
3795         * compile/compile-loc2c.c: Fix common/ includes.
3796         * compile/compile-cplus-types.c: Fix common/ includes.
3797         * compile/compile-cplus-symbols.c: Fix common/ includes.
3798         * command.h: Fix common/ includes.
3799         * cli/cli-dump.c: Fix common/ includes.
3800         * cli/cli-cmds.c: Fix common/ includes.
3801         * charset.c: Fix common/ includes.
3802         * build-id.c: Fix common/ includes.
3803         * btrace.h: Fix common/ includes.
3804         * btrace.c: Fix common/ includes.
3805         * breakpoint.h: Fix common/ includes.
3806         * breakpoint.c: Fix common/ includes.
3807         * ax.h:
3808         (enum agent_op): Fix common/ includes.
3809         * ax-general.c (struct aop_map): Fix common/ includes.
3810         * ax-gdb.c: Fix common/ includes.
3811         * auxv.c: Fix common/ includes.
3812         * auto-load.c: Fix common/ includes.
3813         * arm-tdep.c: Fix common/ includes.
3814         * arch/riscv.c: Fix common/ includes.
3815         * arch/ppc-linux-common.c: Fix common/ includes.
3816         * arch/i386.c: Fix common/ includes.
3817         * arch/arm.c: Fix common/ includes.
3818         * arch/arm-linux.c: Fix common/ includes.
3819         * arch/arm-get-next-pcs.c: Fix common/ includes.
3820         * arch/amd64.c: Fix common/ includes.
3821         * arch/aarch64.c: Fix common/ includes.
3822         * arch/aarch64-insn.c: Fix common/ includes.
3823         * arch-utils.c: Fix common/ includes.
3824         * amd64-windows-tdep.c: Fix common/ includes.
3825         * amd64-tdep.c: Fix common/ includes.
3826         * amd64-sol2-tdep.c: Fix common/ includes.
3827         * amd64-obsd-tdep.c: Fix common/ includes.
3828         * amd64-nbsd-tdep.c: Fix common/ includes.
3829         * amd64-linux-tdep.c: Fix common/ includes.
3830         * amd64-linux-nat.c: Fix common/ includes.
3831         * amd64-fbsd-tdep.c: Fix common/ includes.
3832         * amd64-fbsd-nat.c: Fix common/ includes.
3833         * amd64-dicos-tdep.c: Fix common/ includes.
3834         * amd64-darwin-tdep.c: Fix common/ includes.
3835         * agent.c: Fix common/ includes.
3836         * ada-lang.h: Fix common/ includes.
3837         * ada-lang.c: Fix common/ includes.
3838         * aarch64-tdep.c: Fix common/ includes.
3839
3840 2019-01-25  Tom Tromey  <tom@tromey.com>
3841
3842         * common/create-version.sh: Use common/version.h.
3843
3844 2019-01-24  Pedro Alves  <palves@redhat.com>
3845
3846         * infrun.c (signal_stop, signal_print, signal_program)
3847         (signal_catch, signal_pass): Now arrays instead of pointers.
3848         (update_signals_program_target, do_target_resume)
3849         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
3850         * linux-nat.c (linux_nat_target::pass_signals)
3851         (linux_nat_target::create_inferior, linux_nat_target::attach):
3852         Adjust.
3853         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
3854         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
3855         * procfs.c (procfs_target::pass_signals): Adjust.
3856         * record-full.c (record_full_target::resume): Adjust.
3857         * remote.c (remote_target::pass_signals)
3858         (remote_target::program_signals): Adjust.
3859         * target-debug.h (target_debug_print_signals): Now takes a
3860         gdb::array_view as parameter.  Adjust.
3861         * target.h (target_ops) <pass_signals, program_signals>: Replace
3862         pointer and length parameters with gdb::array_view.
3863         (target_pass_signals, target_program_signals): Likewise.
3864         * target-delegates.c: Regenerate.
3865
3866 2019-01-24  Pedro Alves  <palves@redhat.com>
3867
3868         * common/forward-scope-exit.h
3869         (forward_scope_exit::forward_scope_exit): Pass arguments to
3870         m_bind_function directly, instead of creating a std::bind and
3871         copying that.
3872
3873 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
3874
3875         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
3876         for static members.
3877         (pass_in_v_vfp_candidate): Likewise.
3878
3879 2019-01-23  Tom Tromey  <tom@tromey.com>
3880             Pedro Alves  <palves@redhat.com>
3881
3882         * regcache.c (class regcache_invalidator): Remove.
3883         (regcache::raw_write): Use make_scope_exit.
3884
3885 2019-01-23  Tom Tromey  <tom@tromey.com>
3886
3887         * ui-out.h (class ui_out_emit_type): Update comment.
3888
3889 2019-01-23  Tom Tromey  <tom@tromey.com>
3890
3891         * infrun.c (fetch_inferior_event): Update comment.
3892
3893 2019-01-23  Tom Tromey  <tom@tromey.com>
3894             Pedro Alves  <palves@redhat.com>
3895
3896         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
3897         parameter.
3898         (fetch_inferior_event): Use SCOPE_EXIT.
3899
3900
3901 2019-01-23  Tom Tromey  <tom@tromey.com>
3902             Pedro Alves  <palves@redhat.com>
3903
3904         * infrun.c (disable_thread_events): Delete.
3905         (stop_all_threads): Use SCOPE_EXIT.
3906
3907 2019-01-23  Tom Tromey  <tom@tromey.com>
3908             Pedro Alves  <palves@redhat.com>
3909
3910         * symfile.c: Include forward-scope-exit.h.
3911         (clear_symtab_users_cleanup): Replace forward declaration with
3912         a FORWARD_SCOPE_EXIT.
3913         (syms_from_objfile_1): Use the forward_scope_exit and
3914         gdb::optional instead of cleanup_function.
3915         (reread_symbols): Use the forward_scope_exit instead of
3916         cleanup_function.
3917         (clear_symtab_users_cleanup): Remove function.
3918
3919 2019-01-23  Tom Tromey  <tom@tromey.com>
3920             Pedro Alves  <palves@redhat.com>
3921
3922         * linux-nat.c: Include scope-exit.h.
3923         (cleanup_target_stop): Remove.
3924         (linux_nat_target::static_tracepoint_markers_by_strid): Use
3925         SCOPE_EXIT.
3926
3927 2019-01-23  Tom Tromey  <tom@tromey.com>
3928             Pedro Alves  <palves@redhat.com>
3929
3930         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
3931         (call_function_by_hand_dummy): Use SCOPE_EXIT.
3932
3933 2019-01-23  Tom Tromey  <tom@tromey.com>
3934             Andrew Burgess  <andrew.burgess@embecosm.com>
3935             Pedro Alves  <palves@redhat.com>
3936
3937         * infrun.c (fetch_inferior_event): Use scope_exit.
3938         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
3939         * top.c (execute_command): Use scope_exit.
3940         * breakpoint.c (bpstat_do_actions): Use scope_exit.
3941         * utils.c (do_bpstat_clear_actions_cleanup)
3942         (make_bpstat_clear_actions_cleanup): Remove.
3943
3944 2019-01-23  Tom Tromey  <tom@tromey.com>
3945             Pedro Alves  <palves@redhat.com>
3946
3947         * infrun.c: Include "common/scope-exit.h"
3948         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
3949         (wait_for_inferior): Use SCOPE_EXIT.
3950         (fetch_inferior_event): Use scope_exit.
3951
3952 2019-01-23  Tom Tromey  <tom@tromey.com>
3953             Pedro Alves  <palves@redhat.com>
3954
3955         * breakpoint.c (create_breakpoint): Remove cleanup.
3956
3957 2019-01-23  Tom Tromey  <tom@tromey.com>
3958             Andrew Burgess  <andrew.burgess@embecosm.com>
3959             Pedro Alves  <palves@redhat.com>
3960
3961 2019-01-23  Pedro Alves  <palves@redhat.com>
3962
3963         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
3964
3965 2019-01-23  Pedro Alves  <palves@redhat.com>
3966             Andrew Burgess  <andrew.burgess@embecosm.com>
3967
3968         * gdbthread.h: Include "common/forward-scope-exit.h".
3969         (scoped_finish_thread_state): Redefine custom class in terms of
3970         forward_scope_exit.
3971
3972 2019-01-23  Pedro Alves  <palves@redhat.com>
3973             Andrew Burgess  <andrew.burgess@embecosm.com>
3974
3975         * common/forward-scope-exit.h: New file.
3976
3977 2019-01-23  Pedro Alves  <palves@redhat.com>
3978             Andrew Burgess  <andrew.burgess@embecosm.com>
3979             Tom Tromey  <tom@tromey.com>
3980
3981         * common/scope-exit.h: New file.
3982
3983 2019-01-23  Pedro Alves  <palves@redhat.com>
3984
3985         * common/preprocessor.h (ESC): Rename to ...
3986         (ESC_PARENS): ... this.
3987         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
3988         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
3989
3990 2019-01-23  Tom Tromey  <tom@tromey.com>
3991
3992         * language.h (class scoped_switch_to_sym_language_if_auto):
3993         Initialize m_lang in both cases.
3994
3995 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
3996
3997         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
3998         with XCNEW.
3999
4000 2019-01-22  Tom Tromey  <tom@tromey.com>
4001
4002         * corelow.c: Do not include sys/file.h.
4003
4004 2019-01-22  Tom Tromey  <tom@tromey.com>
4005
4006         * tui/tui-wingeneral.h: Include gdb_curses.h.
4007
4008 2019-01-22  Tom Tromey  <tom@tromey.com>
4009
4010         * source-cache.h (class source_cache) <get_source_lines,
4011         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
4012
4013 2019-01-22  Tom Tromey  <tom@tromey.com>
4014
4015         * remote-fileio.h (struct remote_target): Declare.
4016
4017 2019-01-22  Tom Tromey  <tom@tromey.com>
4018
4019         * python/py-arch.c: Do not include py-ref.h.
4020         * python/py-bpevent.c: Do not include py-ref.h.
4021         * python/py-cmd.c: Do not include py-ref.h.
4022         * python/py-continueevent.c: Do not include py-ref.h.
4023         * python/py-event.h: Do not include py-ref.h.
4024         * python/py-evtregistry.c: Do not include py-ref.h.
4025         * python/py-finishbreakpoint.c: Do not include py-ref.h.
4026         * python/py-frame.c: Do not include py-ref.h.
4027         * python/py-framefilter.c: Do not include py-ref.h.
4028         * python/py-function.c: Do not include py-ref.h.
4029         * python/py-infevents.c: Do not include py-ref.h.
4030         * python/py-linetable.c: Do not include py-ref.h.
4031         * python/py-objfile.c: Do not include py-ref.h.
4032         * python/py-param.c: Do not include py-ref.h.
4033         * python/py-prettyprint.c: Do not include py-ref.h.
4034         * python/py-progspace.c: Do not include py-ref.h.
4035         * python/py-symbol.c: Do not include py-ref.h.
4036         * python/py-symtab.c: Do not include py-ref.h.
4037         * python/py-type.c: Do not include py-ref.h.
4038         * python/py-unwind.c: Do not include py-ref.h.
4039         * python/py-utils.c: Do not include py-ref.h.
4040         * python/py-value.c: Do not include py-ref.h.
4041         * python/py-varobj.c: Do not include py-ref.h.
4042         * python/py-xmethods.c: Do not include py-ref.h.
4043         * python/python.c: Do not include py-ref.h.
4044         * varobj.c: Do not include py-ref.h.
4045
4046 2019-01-22  Tom Tromey  <tom@tromey.com>
4047
4048         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
4049         keyword for bcache.
4050
4051 2019-01-22  Tom Tromey  <tom@tromey.com>
4052
4053         * compile/compile-cplus-types.c: Remove a comment by #include.
4054
4055 2019-01-22  Tom Tromey  <tom@tromey.com>
4056
4057         * compile/gcc-c-plugin.h: Include compile-internal.h.
4058
4059 2019-01-22  Tom Tromey  <tom@tromey.com>
4060
4061         * stabsread.c (EXTERN): Do not define.
4062         (symnum, next_symbol_text_func, processing_gcc_compilation)
4063         (within_function, global_sym_chain, global_stabs)
4064         (previous_stab_code, this_object_header_files)
4065         (n_this_object_header_files)
4066         (n_allocated_this_object_header_files): Define.
4067         * stabsread.h (EXTERN): Never define.  Use "extern".
4068
4069 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4070
4071         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
4072         history_value.
4073
4074 2019-01-21  Tom Tromey  <tom@tromey.com>
4075
4076         * ui-out.c: Fix includes.
4077         * tui/tui-source.c: Fix includes.
4078         * target.c: Fix includes.
4079         * remote.c: Fix includes.
4080         * regcache.c: Fix includes.
4081         * python/py-block.c: Fix includes.
4082         * printcmd.c: Fix includes.
4083         * or1k-tdep.c: Fix includes.
4084         * mi/mi-main.c: Fix includes.
4085         * m32r-tdep.c: Fix includes.
4086         * csky-tdep.c: Fix includes.
4087         * compile/compile-cplus-types.c: Fix includes.
4088         * cli/cli-interp.c: Fix includes.
4089
4090 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
4091
4092         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4093         for padding.
4094
4095 2019-01-16  Tom Tromey  <tom@tromey.com>
4096
4097         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
4098         earlier.
4099         (struct objfile) <msymbols_range>: Move from top level.
4100         <msymbols>: New method.
4101         (class objfile_msymbols): Remove.
4102         * symtab.c (default_collect_symbol_completion_matches_break_on):
4103         Update.
4104         * symmisc.c (dump_msymbols): Update.
4105         * stabsread.c (scan_file_globals): Update.
4106         * objc-lang.c (info_selectors_command, info_classes_command)
4107         (find_methods): Update.
4108         * minsyms.c (find_solib_trampoline_target): Update.
4109         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
4110         * coffread.c (coff_symfile_read): Update.
4111         * ada-lang.c (ada_lookup_simple_minsym)
4112         (ada_collect_symbol_completion_matches): Update.
4113
4114 2019-01-16  Tom Tromey  <tom@tromey.com>
4115
4116         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
4117         type.  Remove no-argument constructor.
4118         <iterator::operator++>: Simplify.
4119         <begin>: Update.
4120         <end>: Use minimal_symbol_count.
4121
4122 2019-01-16  Tom Tromey  <tom@tromey.com>
4123
4124         * objfiles.h (struct objfile) <psymtabs>: New method.
4125         (class objfile_psymtabs): Remove.
4126         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
4127         typedef.
4128         <range>: New method.
4129         (require_partial_symbols): Change return type.
4130         * psymtab.c (require_partial_symbols)
4131         (psym_expand_symtabs_matching): Update.
4132         * mdebugread.c (parse_partial_symbols): Update.
4133         * dbxread.c (dbx_end_psymtab): Update.
4134
4135 2019-01-15  Tom Tromey  <tom@tromey.com>
4136
4137         * symtab.c (lookup_objfile_from_block)
4138         (lookup_symbol_in_objfile_symtabs)
4139         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
4140         (find_line_symtab, info_sources_command)
4141         (default_collect_symbol_completion_matches_break_on)
4142         (make_source_files_completion_list): Update.
4143         * symmisc.c (print_objfile_statistics, dump_objfile)
4144         (maintenance_print_symbols, maintenance_info_symtabs)
4145         (maintenance_check_symtabs, maintenance_info_line_tables):
4146         Update.
4147         * source.c (select_source_symtab)
4148         (forget_cached_source_info_for_objfile): Update.
4149         * objfiles.h (class objfile_compunits): Remove.
4150         (struct objfile) <compunits_range>: New typedef.
4151         (compunits): New method.
4152         * objfiles.c (objfile_relocate1): Update.
4153         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4154         * maint.c (count_symtabs_and_blocks): Update.
4155         * linespec.c (iterate_over_all_matching_symtabs): Update.
4156         * cp-support.c (add_symbol_overload_list_qualified): Update.
4157         * coffread.c (coff_symtab_read): Update.
4158         * ada-lang.c (add_nonlocal_symbols)
4159         (ada_collect_symbol_completion_matches)
4160         (ada_add_global_exceptions): Update.
4161
4162 2019-01-15  Tom Tromey  <tom@tromey.com>
4163
4164         * progspace.h (program_space) <objfiles_safe_range>: New
4165         typedef.
4166         <objfiles_safe>: New method.
4167         * objfiles.h (class all_objfiles_safe): Remove.
4168         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
4169         * jit.c (jit_inferior_exit_hook): Update.
4170
4171 2019-01-17  Tom Tromey  <tom@tromey.com>
4172
4173         * progspace.h (program_space) <objfiles_range>: New typedef.
4174         <objfiles>: New method.
4175         <objfiles_head>: Rename from objfiles.
4176         (object_files): Update.
4177         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
4178         * guile/scm-pretty-print.c
4179         (ppscm_find_pretty_printer_from_objfiles): Update.
4180         * guile/scm-objfile.c (gdbscm_objfiles): Update.
4181         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
4182         Update.
4183         * python/py-progspace.c (pspy_get_objfiles): Update.
4184         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4185         Update.
4186         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4187         (objfpy_lookup_objfile_by_build_id): Update.
4188         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4189         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4190         Update.
4191         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4192         (expand_symtab_containing_pc, lookup_objfile_from_block)
4193         (lookup_static_symbol, basic_lookup_transparent_type)
4194         (find_pc_sect_compunit_symtab, find_symbol_at_address)
4195         (find_line_symtab, info_sources_command)
4196         (default_collect_symbol_completion_matches_break_on)
4197         (make_source_files_completion_list, find_main_name): Update.
4198         * symmisc.c (print_symbol_bcache_statistics)
4199         (print_objfile_statistics, maintenance_print_symbols)
4200         (maintenance_print_msymbols, maintenance_print_objfiles)
4201         (maintenance_info_symtabs, maintenance_check_symtabs)
4202         (maintenance_expand_symtabs, maintenance_info_line_tables):
4203         Update.
4204         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
4205         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
4206         (map_overlay_command, unmap_overlay_command)
4207         (simple_overlay_update, expand_symtabs_matching)
4208         (map_symbol_filenames): Update.
4209         * symfile-debug.c (set_debug_symfile): Update.
4210         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
4211         Update.
4212         * source.c (select_source_symtab, forget_cached_source_info):
4213         Update.
4214         * solib.c (solib_read_symbols): Update.
4215         * solib-spu.c (append_ocl_sos): Update.
4216         * psymtab.c (maintenance_print_psymbols)
4217         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
4218         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
4219         * printcmd.c (info_symbol_command): Update.
4220         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
4221         Update.
4222         * objfiles.h (class all_objfiles): Remove.
4223         * objfiles.c (have_partial_symbols, have_full_symbols)
4224         (have_minimal_symbols, qsort_cmp, update_section_map)
4225         (shared_objfile_contains_address_p)
4226         (default_iterate_over_objfiles_in_search_order): Update.
4227         * objc-lang.c (info_selectors_command, info_classes_command)
4228         (find_methods): Update.
4229         * minsyms.c (find_solib_trampoline_target): Update.
4230         * maint.c (maintenance_info_sections)
4231         (maintenance_translate_address, count_symtabs_and_blocks):
4232         Update.
4233         * main.c (captured_main_1): Update.
4234         * linux-thread-db.c (try_thread_db_load_from_pdir)
4235         (has_libpthread): Update.
4236         * linespec.c (iterate_over_all_matching_symtabs)
4237         (search_minsyms_for_name): Update.
4238         * jit.c (jit_find_objf_with_entry_addr): Update.
4239         * hppa-tdep.c (find_unwind_entry)
4240         (hppa_lookup_stub_minimal_symbol): Update.
4241         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
4242         Update.
4243         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4244         (elf_gnu_ifunc_resolve_by_got): Update.
4245         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
4246         * dwarf-index-write.c (save_gdb_index_command): Update.
4247         * cp-support.c (add_symbol_overload_list_qualified): Update.
4248         * breakpoint.c (create_overlay_event_breakpoint)
4249         (create_longjmp_master_breakpoint)
4250         (create_std_terminate_master_breakpoint)
4251         (create_exception_master_breakpoint): Update.
4252         * blockframe.c (find_pc_partial_function): Update.
4253         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
4254         (ada_collect_symbol_completion_matches)
4255         (ada_add_global_exceptions): Update.
4256
4257 2019-01-17  Tom Tromey  <tom@tromey.com>
4258
4259         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
4260         declare VEC.
4261         (solib_target_parse_libraries): Change return type.
4262         (library_list_start_segment, library_list_start_section)
4263         (library_list_end_library, library_list_start_library); Update.
4264         (solib_target_free_library_list): Remove.
4265         (solib_target_parse_libraries): Remove cleanup.  Change return
4266         type.
4267         (solib_target_current_sos): Update.
4268
4269 2019-01-17  Tom Tromey  <tromey@bapiya>
4270
4271         * valprint.c: Replace "the the" with "the".
4272         * symtab.c: Replace "the the" with "the".
4273         * solib.c: Replace "the the" with "the".
4274         * solib-dsbt.c: Replace "the the" with "the".
4275         * linespec.c: Replace "the the" with "the".
4276         * dwarf2loc.h: Replace "the the" with "the".
4277         * amd64-windows-tdep.c: Replace "the the" with "the".
4278         * aarch64-tdep.c: Replace "the the" with "the".
4279
4280 2019-01-16  Keith Seitz  <keiths@redhat.com>
4281
4282         PR gdb/23773
4283         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
4284         <builder>: Rename to ..
4285         <m_builder>: ... this and make private.
4286         (dwarf2_cu::get_builder): New method.  Change all users of
4287         `builder' to use this method.
4288         (dwarf2_start_symtab): Move to ...
4289         (dwarf2_cu::start_symtab): ... here.  Update all callers
4290         (setup_type_unit_groups): Move to ...
4291         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
4292         callers.
4293         (dwarf2_cu::reset_builder): New method.
4294         (process_full_compunit, process_full_type_unit): Use
4295         dwarf2_cu::reset_builder.
4296         (follow_die_offset): Record the ancestor CU if it is different
4297         from the followed DIE's CU.
4298         (follow_die_sig_1): Likewise.
4299
4300 2019-01-15  Tom Tromey  <tom@tromey.com>
4301
4302         * remote.c (class remote_state) <buf>: Now a char_vector.
4303         <buf_size>: Remove.
4304         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
4305         parameter.
4306         (remote_target::getpkt_or_notif_sane_1)
4307         (remote_target::getpkt_sane)
4308         (remote_target::getpkt_or_notif_sane): Likewise.
4309         (class remote_target) <putpkt>: New overload.
4310         (remote_target::read_frame): Change type of "buf_p".  Remove
4311         sizeof_p parameter.
4312         (packet_ok): New overload.
4313         (packet_check_result): New overload.
4314         Update all uses.
4315
4316 2019-01-14  Tom Tromey  <tom@tromey.com>
4317
4318         * remote-notif.c (handle_notification, remote_notif_ack)
4319         (remote_notif_parse): Make "buf" const.
4320         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
4321         const.
4322         (remote_notif_parse, remote_notif_ack, handle_notification):
4323         Likewise.
4324         * remote.c (remote_notif_stop_parse): Make "buf" const.
4325         (remote_target::remote_parse_stop_reply): Make "buf" const.
4326         (remote_notif_stop_ack): Make "buf" const.
4327
4328 2019-01-14  Tom Tromey  <tom@tromey.com>
4329
4330         * remote.c (remote_console_output): Make parameter const.
4331
4332 2019-01-14  Tom Tromey  <tom@tromey.com>
4333
4334         * target-debug.h (target_debug_print_signals): Constify.
4335         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
4336         * procfs.c (procfs_target::pass_signals): Update.
4337         * linux-nat.c (linux_nat_target::pass_signals): Update.
4338         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
4339         * target-delegates.c: Rebuild.
4340         * remote.c (remote_target::program_signals): Update.
4341         (remote_target::pass_signals): Update.
4342         * target.c (target_pass_signals): Constify argument.
4343         (target_program_signals): Likewise.
4344         * target.h (struct target_ops) <pass_signals, program_signals>:
4345         Constify argument.
4346         (target_pass_signals, target_program_signals): Constify argument.
4347
4348 2019-01-14  Tom Tromey  <tom@tromey.com>
4349
4350         PR tui/28819:
4351         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
4352
4353 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4354
4355         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
4356         field.
4357         * rs6000-tdep.c: Include reggroups.h.
4358         (IS_V_ALIAS_PSEUDOREG): Define.
4359         (rs6000_register_name): Return names for the "vX" aliases.
4360         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
4361         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
4362         aliases.  Call default_register_reggroup_p for all other
4363         pseudo-registers.
4364         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
4365         New functions.
4366         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
4367         Handle "vX" aliases.
4368         (v_alias_pseudo_register_collect): New function.
4369         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
4370         (rs6000_gdbarch_init): Initialize "vX" aliases as
4371         pseudo-registers.  Restore registration of
4372         rs6000_pseudo_register_reggroup_p with
4373         set_tdesc_pseudo_register_reggroup_p.
4374
4375 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
4376
4377         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
4378         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
4379         set_gdbarch_num_pseudo_regs.
4380
4381 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4382
4383         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
4384         Remove arg prefixname, add do_set and do_show.
4385         Add member functions set_list and show_list.
4386         * cli/cli-style.c (class cli_style_option): Update accordingly.
4387         (style_set_list): Move to file scope.
4388         (style_show_list): Likewise.
4389         (set_style): Call help_list.
4390         (show_style): Call cmd_show_list.
4391         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
4392         Update to use the new macro.
4393
4394 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
4395
4396         * ada-lang.c (_initialize_ada_language): Expand the help text
4397         for the "catch exception" command.
4398
4399 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4400
4401         * symtab.c (matching_obj_sections): Initialize obj,
4402         declare it closer to its usage.
4403
4404 2019-01-10  Tom Tromey  <tom@tromey.com>
4405
4406         * thread-iter.h (inf_threads_iterator): Use next_iterator.
4407         (basic_inf_threads_range): Remove.
4408         (inf_threads_range, inf_non_exited_threads_range)
4409         (safe_inf_threads_range): Use next_adapter.
4410
4411 2019-01-10  Keith Seitz  <keiths@redhat.com>
4412
4413         PR gdb/23712
4414         PR symtab/23010
4415         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
4416         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
4417
4418 2019-01-10  Keith Seitz  <keiths@redhat.com>
4419
4420         PR gdb/23712
4421         PR symtab/23010
4422         * dictionary.c (pending_to_vector): Remove.
4423         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4424         Remove _1 suffix, replacing functions of the same name.  Update
4425         all callers.
4426         (dict_create_hashed, dict_create_hashed_expandable)
4427         (dict_create_linear, dict_create_linear_expandable, dict_free)
4428         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
4429         Make functions static.
4430
4431 2019-01-10  Keith Seitz  <keiths@redhat.com>
4432
4433         PR gdb/23712
4434         PR symtab/23010
4435         * dictionary.h (struct dictionary): Replace declaration with
4436         multidictionary.
4437         (dict_create_hashed, dict_create_hashed_expandable)
4438         (dict_create_linear, dict_create_linear_expandable)
4439         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
4440         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
4441         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
4442         taking multidictionary argument.
4443         [ALL_DICT_SYMBOLS]: Update for multidictionary.
4444         * block.h (struct block) <dict>: Change to multidictionary
4445         and rename `multidict'.
4446         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
4447         symmisc.c: Update all dictionary references to multidictionary.
4448
4449 2019-01-10  Keith Seitz  <keiths@redhat.com>
4450
4451         PR gdb/23712
4452         PR symtab/23010
4453         * dictionary.c: Include unordered_map.
4454         (pending_to_vector): New function.
4455         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4456         Rewrite the non-"_1" functions to take vector instead
4457         of linked list.
4458         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
4459         "new" _1 versions of the same name.
4460         (multidictionary): Define.
4461         (std::hash<enum language): New definition.
4462         (collate_pending_symbols_by_language, mdict_create_hashed)
4463         (mdict_create_hashed_expandable, mdict_create_linear)
4464         (mdict_create_linear_expandable, mdict_free)
4465         (find_language_dictionary, create_new_language_dictionary)
4466         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
4467         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
4468         (mdict_size, mdict_empty): New functions.
4469         * dictionary.h (mdict_iterator): Define.
4470
4471 2019-01-10  Pedro Alves  <palves@redhat.com>
4472
4473         * breakpoint.c (read_uploaded_action)
4474         (create_tracepoint_from_upload): Adjust to use
4475         gdb::unique_xmalloc_ptr.
4476         * ctf.c (ctf_write_uploaded_tp):
4477         (SET_ARRAY_FIELD): Use emplace_back.
4478         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
4479         * tracefile-tfile.c (tfile_write_uploaded_tp):
4480         * tracepoint.c (parse_tracepoint_definition): Adjust to use
4481         gdb::unique_xmalloc_ptr.
4482         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
4483         at_string, cond_string, cmd_strings>: Replace char pointers
4484         with gdb::unique_xmalloc_ptr.
4485
4486 2019-01-10  Pedro Alves  <palves@redhat.com>
4487
4488         * solib-target.c (library_list_start_library): Don't xstrdup name.
4489
4490 2019-01-10  Pedro Alves  <palves@redhat.com>
4491
4492         * mdebugread.c (parse_partial_symbols): Use
4493         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
4494
4495 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4496
4497         * linux-fork.c (scoped_switch_fork_info)
4498         <~scoped_switch_fork_info>: Fix incorrect variable name.
4499
4500 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4501
4502         * linux-fork.c (scoped_switch_fork_info)
4503         <scoped_switch_fork_info>: Make explicit.
4504         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
4505
4506 2019-01-10  Tom Tromey  <tom@tromey.com>
4507
4508         * objfiles.h (objfile::reset_psymtabs): Update.
4509         * objfiles.c (objfile::objfile): Update.
4510         * psymtab.h (psymtab_storage::obstack): Update.
4511         (psymtab_storage::m_obstack): Use gdb::optional.
4512         (class psymtab_storage): Update comment.  Remove objfile
4513         parameter.
4514         * psymtab.c (psymtab_storage::psymtab_storage): Update.
4515
4516 2019-01-10  Tom Tromey  <tom@tromey.com>
4517
4518         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
4519         <free_psymtabs>: Now private.
4520         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
4521         (allocate_psymtab): Use new method.
4522
4523 2019-01-10  Tom Tromey  <tom@tromey.com>
4524
4525         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
4526         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
4527         * mdebugread.c (parse_partial_symbols): Use
4528         allocate_dependencies.
4529         * dwarf2read.c (dwarf2_create_include_psymtab): Use
4530         allocate_dependencies.
4531         (process_psymtab_comp_unit_reader)
4532         (build_type_psymtab_dependencies): Likewise.
4533         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
4534
4535 2019-01-10  Tom Tromey  <tom@tromey.com>
4536
4537         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
4538         PSYMBOL_SET_LANGUAGE.
4539         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
4540
4541 2019-01-10  Tom Tromey  <tom@tromey.com>
4542
4543         * psymtab.h (psymtab_storage::obstack): New method.
4544         <m_obstack>: Rename from obstack; now private.
4545         * psymtab.c (psymtab_storage): Update.
4546         * dwarf2read.c (create_addrmap_from_index)
4547         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
4548         Update.
4549
4550 2019-01-10  Tom Tromey  <tom@tromey.com>
4551
4552         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
4553         * objfiles.h (objfile::reset_psymtabs): New method.
4554
4555 2019-01-10  Tom Tromey  <tom@tromey.com>
4556
4557         * symmisc.c (print_symbol_bcache_statistics): Update.
4558         (print_objfile_statistics): Update.
4559         * symfile.c (reread_symbols): Update.
4560         * psymtab.h (class psymtab_storage): New.
4561         * psymtab.c (psymtab_storage): New constructor.
4562         (~psymtab_storage): New destructor.
4563         (require_partial_symbols): Update.
4564         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
4565         (find_pc_sect_psymtab, find_pc_sect_psymbol)
4566         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
4567         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
4568         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
4569         (start_psymtab_common, end_psymtab_common)
4570         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
4571         (allocate_psymtab): Update.
4572         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
4573         Update.
4574         (dump_psymtab_addrmap, maintenance_print_psymbols)
4575         (maintenance_check_psymtabs): Update.
4576         (class objfile_psymtabs): Move to objfiles.h.
4577         * psympriv.h (discard_psymtab): Now inline.
4578         (psymtab_discarder::psymtab_discarder): Update.
4579         (psymtab_discarder::~psymtab_discarder): Update.
4580         (ALL_OBJFILE_PSYMTABS): Rewrite.
4581         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
4582         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
4583         Remove fields.
4584         <partial_symtabs>: New field.
4585         (class objfile_psymtabs): Move from psymtab.h.  Update.
4586         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
4587         psymbol_cache.
4588         (objfile::~objfile): Don't destroy psymbol_cache.
4589         * mdebugread.c (parse_partial_symbols): Update.
4590         * dwarf2read.c (create_addrmap_from_index)
4591         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
4592         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
4593         (add_partial_subprogram, dwarf2_ranges_read): Update.
4594         * dwarf-index-write.c (write_address_map)
4595         (write_one_signatured_type, recursively_write_psymbols)
4596         (class debug_names, class debug_names, write_psymtabs_to_index):
4597         Update.
4598
4599 2019-01-10  Tom Tromey  <tom@tromey.com>
4600
4601         * symtab.h (SYMBOL_SET_NAMES): Update.
4602         (symbol_set_names): Update.
4603         (MSYMBOL_SET_NAMES): Update.
4604         * symtab.c (symbol_set_names): Change argument to be an
4605         objfile_per_bfd_storage.
4606         * psymtab.c (add_psymbol_to_bcache): Update.
4607         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
4608
4609 2019-01-10  Tom Tromey  <tom@tromey.com>
4610
4611         * symtab.c (create_demangled_names_hash): Change argument to be an
4612         objfile_per_bfd_storage.
4613         (symbol_set_names): Update.
4614
4615 2019-01-10  Tom Tromey  <tom@tromey.com>
4616
4617         * xcoffread.c (xcoff_initial_scan): Unconditionally call
4618         init_psymbol_list.
4619         * psymtab.c (init_psymbol_list): Do nothing if already called.
4620         * psympriv.h (init_psymbol_list): Add comment.
4621         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
4622         init_psymbol_list.
4623         * dbxread.c (dbx_symfile_read): Unconditionally call
4624         init_psymbol_list.
4625
4626 2019-01-10  Tom Tromey  <tom@tromey.com>
4627
4628         * xcoffread.c (scan_xcoff_symtab): Update.
4629         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
4630         "where".
4631         * mdebugread.c (parse_partial_symbols)
4632         (handle_psymbol_enumerators): Update.
4633         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
4634         * dbxread.c (read_dbx_symtab): Update.
4635         * psympriv.h (psymbol_placement): New enum.
4636         (add_psymbol_to_list): Update.
4637
4638 2019-01-10  Tom Tromey  <tom@tromey.com>
4639
4640         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
4641         static_psymbols parameters.
4642         (scan_xcoff_symtab): Update.
4643         * psymtab.c (start_psymtab_common): Remove global_psymbols and
4644         static_psymbols parameters.
4645         * psympriv.h (start_psymtab_common): Update.
4646         * mdebugread.c (parse_partial_symbols): Update.
4647         * dwarf2read.c (create_partial_symtab): Update.
4648         * dbxread.c (read_dbx_symtab): Update.
4649         (start_psymtab): Remove global_psymbols and static_psymbols
4650         parameters.
4651
4652 2019-01-10  Tom Tromey  <tom@tromey.com>
4653
4654         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
4655         * psymtab.c (allocate_psymtab): Add comment.
4656         * psympriv.h (allocate_psymtab): Add comment.
4657         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
4658         initializations.
4659         * dbxread.c (dbx_end_psymtab): Remove some initializations.
4660
4661 2019-01-10  Tom Tromey  <tom@tromey.com>
4662
4663         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4664         Don't declare.
4665         * mipsread.c: Include mdebugread.h.
4666         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4667         Declare.
4668         * elfread.c: Include mdebugread.h.
4669
4670 2019-01-09  Tom Tromey  <tom@tromey.com>
4671
4672         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
4673         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
4674         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
4675         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
4676         (psym_lookup_symbol, psym_find_last_source_symtab)
4677         (psym_forget_cached_source_info, psym_print_stats)
4678         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
4679         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
4680         (psym_map_matching_symbols, psym_expand_symtabs_matching)
4681         (psym_find_compunit_symtab_by_address)
4682         (maintenance_print_psymbols, maintenance_info_psymtabs)
4683         (maintenance_check_psymtabs): Use ranged for.
4684         * psymtab.h (class objfile_psymtabs): New.
4685         (require_partial_symbols): Return objfile_psymtabs.
4686         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
4687
4688 2019-01-09  Tom Tromey  <tom@tromey.com>
4689
4690         * symfile.c (overlay_invalidate_all, find_pc_overlay)
4691         (find_pc_mapped_section, list_overlays_command)
4692         (map_overlay_command, unmap_overlay_command)
4693         (simple_overlay_update): Use all_objfiles.
4694         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
4695         * printcmd.c (info_symbol_command): Use all_objfiles.
4696         * objfiles.h (ALL_OBJSECTIONS): Remove.
4697         * maint.c (maintenance_translate_address): Use all_objfiles.
4698         * gcore.c (gcore_create_callback): Use all_objfiles.
4699         (objfile_find_memory_regions): Likewise.
4700
4701 2019-01-09  Tom Tromey  <tom@tromey.com>
4702
4703         * symtab.c (find_line_symtab, info_sources_command)
4704         (make_source_files_completion_list): Use objfile_compunits.
4705         * source.c (select_source_symtab): Use objfile_compunits.
4706         * objfiles.h (struct objfile): Update comment.
4707         (ALL_OBJFILES): Remove.
4708         (ALL_FILETABS): Remove.
4709         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
4710         objfile_compunits.
4711
4712 2019-01-09  Tom Tromey  <tom@tromey.com>
4713
4714         * symmisc.c (print_objfile_statistics, dump_objfile)
4715         (maintenance_print_symbols): Use compunit_filetabs.
4716         * source.c (forget_cached_source_info_for_objfile): Use
4717         compunit_filetabs.
4718         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
4719         (ALL_FILETABS): Use compunit_filetabs.
4720         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
4721         * coffread.c (coff_symtab_read): Use compunit_filetabs.
4722
4723 2019-01-09  Tom Tromey  <tom@tromey.com>
4724
4725         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
4726         (compunit_filetabs): New.
4727         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
4728         compunit_filetabs.
4729         (info_sources_command, make_source_files_completion_list): Remove
4730         declaration.
4731         * symmisc.c (print_objfile_statistics, dump_objfile)
4732         (maintenance_print_symbols): Remove declaration.
4733         (maintenance_info_symtabs): Use compunit_filetabs.
4734         (maintenance_info_line_tables): Likewise.
4735         * source.c (select_source_symtab): Change local variable name.
4736         (forget_cached_source_info_for_objfile): Remove declaration.
4737         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
4738         * objfiles.c (objfile_relocate1): Remove declaration.
4739         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4740         declaration.
4741         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
4742         * coffread.c (coff_symtab_read): Remove declaration.
4743         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
4744         compunit_filetabs.
4745
4746 2019-01-09  Tom Tromey  <tom@tromey.com>
4747
4748         * symtab.c (lookup_objfile_from_block)
4749         (find_pc_sect_compunit_symtab, search_symbols)
4750         (default_collect_symbol_completion_matches_break_on): Use
4751         objfile_compunits.
4752         * objfiles.h (ALL_COMPUNITS): Remove.
4753         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
4754         * cp-support.c (add_symbol_overload_list_qualified): Use
4755         objfile_compunits.
4756         * ada-lang.c (ada_collect_symbol_completion_matches)
4757         (ada_add_global_exceptions): Use objfile_compunits.
4758
4759 2019-01-09  Tom Tromey  <tom@tromey.com>
4760
4761         * source.c (select_source_symtab)
4762         (forget_cached_source_info_for_objfile): Remove declaration.
4763         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4764         declaration.
4765         * maint.c (count_symtabs_and_blocks): Remove declaration.
4766         * cp-support.c (add_symbol_overload_list_qualified): Remove
4767         declaration.
4768         * coffread.c (coff_symtab_read): Remove declaration.
4769         * symtab.c (lookup_symbol_in_objfile_symtabs)
4770         (basic_lookup_transparent_type_1): Use objfile_compunits.
4771         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
4772         (info_sources_command, search_symbols)
4773         (default_collect_symbol_completion_matches_break_on)
4774         (make_source_files_completion_list): Remove declaration.
4775         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
4776         (ada_collect_symbol_completion_matches)
4777         (ada_add_global_exceptions): Remove declaration.
4778         * linespec.c (iterate_over_all_matching_symtabs): Use
4779         objfile_compunits.
4780         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
4781         (class objfile_compunits): New.
4782         (ALL_COMPUNITS): Use objfile_compunits.
4783         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
4784         (maintenance_check_symtabs, maintenance_info_line_tables): Use
4785         objfile_compunits.
4786         * objfiles.c (objfile_relocate1): Use objfile_compunits.
4787
4788 2019-01-09  Tom Tromey  <tom@tromey.com>
4789
4790         * symtab.c (search_symbols)
4791         (default_collect_symbol_completion_matches_break_on): Use
4792         objfile_msymbols.
4793         * ada-lang.c (ada_lookup_simple_minsym)
4794         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
4795         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
4796         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
4797         objfile_msymbols.
4798         * coffread.c (coff_symfile_read): Use objfile_msymbols.
4799         * symmisc.c (dump_msymbols): Use objfile_msymbols.
4800         * objc-lang.c (find_methods): Use objfile_msymbols.
4801         (info_selectors_command, info_classes_command): Likewise.
4802         * stabsread.c (scan_file_globals): Use objfile_msymbols.
4803         * objfiles.h (class objfile_msymbols): New.
4804         (ALL_OBJFILE_MSYMBOLS): Remove.
4805         (ALL_MSYMBOLS): Remove.
4806
4807 2019-01-09  Tom Tromey  <tom@tromey.com>
4808
4809         * common/next-iterator.h (next_adapter): Add Iterator template
4810         parameter.
4811         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
4812         (class all_objfiles_safe): New.
4813         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
4814         * objfiles.c (put_objfile_before): Update comment.
4815         (add_separate_debug_objfile): Likewise.
4816         (free_all_objfiles): Use all_objfiles_safe.
4817         (objfile_purge_solibs): Likewise.
4818
4819 2019-01-09  Tom Tromey  <tom@tromey.com>
4820
4821         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4822         (expand_symtab_containing_pc, lookup_static_symbol)
4823         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
4824         (find_symbol_at_address, find_line_symtab, find_main_name): Use
4825         all_objfiles.
4826         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
4827         * breakpoint.c (create_overlay_event_breakpoint)
4828         (create_longjmp_master_breakpoint)
4829         (create_std_terminate_master_breakpoint)
4830         (create_exception_master_breakpoint): Use all_objfiles.
4831         * linux-thread-db.c (try_thread_db_load_from_pdir)
4832         (has_libpthread): Use all_objfiles.
4833         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
4834         * linespec.c (iterate_over_all_matching_symtabs)
4835         (search_minsyms_for_name): Use all_objfiles.
4836         * maint.c (maintenance_info_sections): Use all_objfiles.
4837         * main.c (captured_main_1): Use all_objfiles.
4838         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
4839         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
4840         * guile/scm-pretty-print.c
4841         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
4842         * solib-spu.c (append_ocl_sos): Use all_objfiles.
4843         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
4844         (maintenance_print_msymbols): Use all_objfiles.
4845         * source.c (select_source_symtab): Use all_objfiles.
4846         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
4847         * symfile.c (remove_symbol_file_command)
4848         (expand_symtabs_matching, map_symbol_filenames): Use
4849         all_objfiles.
4850         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
4851         all_objfiles.
4852         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
4853         * objc-lang.c (find_methods): Use all_objfiles.
4854         * objfiles.c (have_partial_symbols, have_full_symbols)
4855         (have_minimal_symbols, qsort_cmp)
4856         (default_iterate_over_objfiles_in_search_order): Use
4857         all_objfiles.
4858         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
4859         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
4860         (maintenance_check_psymtabs): Use all_objfiles.
4861         (ALL_PSYMTABS): Remove.
4862         * compile/compile-object-run.c (do_module_cleanup): Use
4863         all_objfiles.
4864         * blockframe.c (find_pc_partial_function): Use all_objfiles.
4865         * cp-support.c (add_symbol_overload_list_qualified): Use
4866         all_objfiles.
4867         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4868         Use all_objfiles.
4869         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
4870         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
4871         all_objfiles.
4872         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4873         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
4874         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4875         Uses all_objfiles.
4876         * solib.c (solib_read_symbols): Use all_objfiles
4877
4878 2019-01-09  Tom Tromey  <tom@tromey.com>
4879
4880         * probe.c (parse_probes_in_pspace): Use all_objfiles.
4881         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
4882         all_objfiles.
4883         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
4884         * symmisc.c (print_symbol_bcache_statistics)
4885         (print_objfile_statistics, maintenance_print_objfiles)
4886         (maintenance_info_symtabs, maintenance_check_symtabs)
4887         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
4888         all_objfiles.
4889         * source.c (forget_cached_source_info): Use all_objfiles.
4890         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
4891         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4892         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
4893         * objfiles.c (update_section_map): Use all_objfiles.
4894         (shared_objfile_contains_address_p): Likewise.
4895         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
4896         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
4897
4898 2019-01-09  Tom Tromey  <tom@tromey.com>
4899
4900         * common/next-iterator.h: New file.
4901         * objfiles.h (class all_objfiles): New.
4902         (struct objfile_iterator): New.
4903
4904 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4905
4906         * NEWS: Move the description of the changed "frame", "select-frame",
4907          and "info frame" commands to the Changed commands section.
4908
4909 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
4910
4911         * gdbtypes.c (check_stub_method_group): Remove handling of old
4912         mangling schemes.
4913         * linespec.c (find_methods): Likewise.
4914         * stabsread.c (read_member_functions): Likewise.
4915         * valops.c (search_struct_method): Likewise.
4916         (value_struct_elt_for_reference): Likewise.
4917         * NEWS: Mention this change.
4918
4919 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4920
4921         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
4922         print_source_lines.
4923         * source.c (print_source_lines_base): Update line number check.
4924         (print_source_lines): New function.
4925         (source_lines_range::source_lines_range): New function.
4926         * source.h (class source_lines_range): New class.
4927         (print_source_lines): New declaration.
4928
4929 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4930
4931         * linespec.c (linespec_state_destructor): Free self->canonical_names.
4932
4933 2019-01-08  Tom Tromey  <tom@tromey.com>
4934             Simon Marchi  <simon.marchi@ericsson.com>
4935
4936         PR gdb/24060
4937         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
4938         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
4939         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
4940         * f-exp.y (DOLLAR_VARIABLE): Likewise.
4941         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
4942         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
4943
4944 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4945
4946         * source.c (select_source_symtab): Move header comment to
4947         declaration in source.h.
4948         (forget_cached_source_info_for_objfile): Likewise.
4949         (forget_cached_source_info): Likewise.
4950         (identify_source_line): Likewise.
4951         * source.h (identify_source_line): Move declaration from symtab.h
4952         and add comment from source.c
4953         (print_source_lines): Likewise.
4954         (forget_cached_source_info_for_objfile): Likewise.
4955         (forget_cached_source_info): Likewise.
4956         (select_source_symtab): Likewise.
4957         (enum print_source_lines_flag): Move definition from symtab.h.
4958         * symtab.h (identify_source_line): Move declaration to source.h.
4959         (print_source_lines): Likewise.
4960         (forget_cached_source_info_for_objfile): Likewise.
4961         (forget_cached_source_info): Likewise.
4962         (select_source_symtab): Likewise.
4963         (enum print_source_lines_flag): Move definition to source.h.
4964         * tui/tui-hooks.c: Add 'source.h' include.
4965
4966 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4967
4968         * source.c (print_source_lines_base): Handle requests to print
4969         reverse line number sequences, and guard against empty lines
4970         string.
4971
4972 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4973
4974         * source.c (print_source_lines_base): Fix skip of '\r' if next
4975         character is '\n'.
4976
4977 2019-01-06  Tom Tromey  <tom@tromey.com>
4978
4979         * c-exp.y (struct c_parse_state) <macro_original_text,
4980         expansion_obstack>: New member.
4981         (macro_original_text, expansion_obstack): Remove globals.
4982         (scan_macro_expansion, scanning_macro_expansion)
4983         (finished_macro_expansion): Update.
4984         (scan_macro_cleanup): Remove.
4985         (yylex, c_parse): Update.
4986
4987 2019-01-06  Tom Tromey  <tom@tromey.com>
4988
4989         * c-exp.y (struct c_parse_state) <strings>: New member.
4990         (operator_stoken): Update.
4991
4992 2019-01-06  Tom Tromey  <tom@tromey.com>
4993
4994         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
4995         (union type_stack_elt) <typelist_val>: Now a pointer to
4996         std::vector.
4997         (type_stack_cleanup): Don't declare.
4998         (push_typelist): Update.
4999         * parse.c (pop_typelist): Return a std::vector.
5000         (push_typelist): Take a std::vector.
5001         (follow_types): Update.  Do not free args.
5002         (type_stack_cleanup): Remove.
5003         * c-exp.y (struct c_parse_state): New.
5004         (cpstate): New global.
5005         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
5006         (nonempty_typelist): Update.
5007         (func_mod): Create a new vector.
5008         (c_parse): Create a c_parse_state.
5009         (check_parameter_typelist): Do not delete params.
5010         (function_method): Update.  Do not delete type_list.
5011
5012 2019-01-06  Tom Tromey  <tom@tromey.com>
5013
5014         PR gdb/28155:
5015         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
5016         check_typedef.
5017         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
5018         (print_return_value): Likewise.
5019
5020 2019-01-05  Tom Tromey  <tom@tromey.com>
5021
5022         * contrib/cleanup_check.py: Remove.
5023         * contrib/gcc-with-excheck: Remove.
5024         * contrib/exsummary.py: Remove.
5025         * contrib/excheck.py: Remove.
5026
5027 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
5028
5029         * thread.c (delete_thread_1): Add gdb_assert that THR is not
5030         NULL. Initialize tpprev to NULL instead of assigning it
5031         to NULL on the next statement.
5032         * windows-nat.c (windows_delete_thread): Remove check for
5033         main_thread_id before printing thread exit notifications.
5034         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
5035         Remove thread ID check against main_thread_id.
5036         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
5037         windows_delete_thread.
5038         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
5039
5040 2019-01-04  Tom Tromey  <tom@tromey.com>
5041
5042         * compile/compile.c (_initialize_compile): Use upper case for
5043         metasyntactic variables.
5044         * symmisc.c (_initialize_symmisc): Use upper case for
5045         metasyntactic variables.
5046         * psymtab.c (_initialize_psymtab): Use upper case for
5047         metasyntactic variables.
5048         * demangle.c (demangle_command): Use upper case for metasyntactic
5049         variables.
5050         (_initialize_demangler): Likewise.
5051         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
5052         variables.
5053
5054 2019-01-03  Tom Tromey  <tom@tromey.com>
5055
5056         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
5057
5058 2019-01-03  Tom Tromey  <tom@tromey.com>
5059
5060         * python/py-symtab.c (salpy_str): Update.
5061         (struct salpy_sal_object) <symtab>: Now a PyObject.
5062         (salpy_dealloc): Update.
5063         (del_objfile_sal): Use gdbpy_ref.
5064
5065 2019-01-03  Tom Tromey  <tom@tromey.com>
5066
5067         * python/py-type.c (convert_field): Use new_reference.  Return
5068         gdbpy_ref.
5069         (make_fielditem): Return gdbpy_ref.
5070         (typy_fields): Update.
5071         (typy_getitem): Update.
5072         (field_name): Return gdbpy_ref.  Use new_reference.
5073         (typy_iterator_iternext): Update.
5074
5075 2019-01-03  Tom Tromey  <tom@tromey.com>
5076
5077         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
5078
5079 2019-01-03  Tom Tromey  <tom@tromey.com>
5080
5081         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
5082         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
5083         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
5084         (pspy_set_frame_filters, pspy_set_frame_unwinders)
5085         (pspy_set_type_printers): Likewise.
5086         * python/py-function.c (fnpy_init): Use gdbpy_ref.
5087         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
5088         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
5089         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
5090         (objfpy_set_type_printers): Likewise.
5091
5092 2019-01-03  Tom Tromey  <tom@tromey.com>
5093
5094         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
5095         (gdbpy_print_stack): Use gdbpy_err_fetch.
5096         * python/python-internal.h (class gdbpy_err_fetch): New class.
5097         (class gdbpy_enter) <m_error_type, m_error_value,
5098         m_error_traceback>: Remove.
5099         <m_error>: New member.
5100         (gdbpy_exception_to_string): Don't declare.
5101         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
5102         * python/py-value.c (convert_value_from_python): Use
5103         gdbpy_err_fetch.
5104         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
5105         gdbpy_exception_to_string.
5106         (gdbpy_handle_exception): Use gdbpy_err_fetch.
5107         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
5108         gdbpy_err_fetch.
5109
5110 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5111
5112         * linux-nat.c (delete_lwp_cleanup): Delete.
5113         (struct lwp_deleter): New struct.
5114         (lwp_info_up): New typedef.
5115         (linux_nat_target::follow_fork): Delete cleanup, and make use of
5116         lwp_info_up.
5117
5118 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5119
5120         * linux-fork.c (class scoped_switch_fork_info): New class.
5121         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
5122
5123 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5124
5125         * valops.c (find_overload_match): Remove use of null_cleanup, and
5126         calls to do_cleanups.
5127
5128 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5129
5130         * compile/compile-cplus-types.c
5131         (compile_cplus_instance::decl_name): Handle changes to
5132         cp_func_name.
5133         * cp-support.c (cp_func_name): Update header comment, update
5134         return type.
5135         * cp-support.h (cp_func_name): Update return type in declaration.
5136         * valops.c (find_overload_match): Move temp_func local to top
5137         level of function and change its type.  Use temp_func to hold and
5138         delete temporary string obtained from cp_func_name.
5139
5140 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5141
5142         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
5143         gdb::char_vector, remove cleanup, and update uses of `msg`.
5144
5145 2019-01-03  Jim Wilson  <jimw@sifive.com>
5146
5147         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
5148
5149 2019-01-02  Tom Tromey  <tom@tromey.com>
5150
5151         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
5152         (tdesc_parse_xml): Remove cleanups.
5153         * target-descriptions.h (make_cleanup_free_target_description):
5154         Don't declare.
5155         (target_desc_deleter): New struct.
5156         (target_desc_up): New typedef.
5157         * target-descriptions.c (target_desc_deleter::operator()): Rename
5158         from free_target_description.
5159         (make_cleanup_free_target_description): Remove.
5160
5161 2019-01-02  Tom Tromey  <tom@tromey.com>
5162
5163         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
5164         constructor, destructor.
5165         (linespec_parser): Remove typedef.
5166         (~linespec_parser): Rename from linespec_parser_delete.
5167         (linespec_lex_to_end, linespec_complete_label)
5168         (linespec_complete): Update.
5169         (decode_line_full): Remove cleanups.
5170         (decode_line_1): Update.
5171
5172 2019-01-02  Tom Tromey  <tom@tromey.com>
5173
5174         * python/python-internal.h (inferior_to_inferior_object): Change
5175         return type.
5176         * python/py-exitedevent.c (create_exited_event_object): Update.
5177         * python/py-inferior.c (inferior_to_inferior_object): Return
5178         gdbpy_ref.
5179         (python_new_inferior, python_inferior_deleted)
5180         (thread_to_thread_object, delete_thread_object)
5181         (build_inferior_list, gdbpy_selected_inferior): Update.
5182         * python/py-infthread.c (create_thread_object): Update.  Also fail
5183         if inferior_to_inferior_object fails.
5184
5185 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
5186
5187         * inferior.h (class inferior) <displaced_step_state>: New field.
5188         * infrun.h (struct displaced_step_state): Move here from
5189         infrun.c.  Initialize fields, add constructor.
5190         <inf>: Remove field.
5191         <reset>: New method.
5192         * infrun.c (struct displaced_step_inferior_state): Move to
5193         infrun.h.
5194         (displaced_step_inferior_states): Remove.
5195         (get_displaced_stepping_state): Adust.
5196         (displaced_step_in_progress_any_inferior): Adjust.
5197         (displaced_step_in_progress_thread): Adjust.
5198         (displaced_step_in_progress): Adjust.
5199         (add_displaced_stepping_state): Remove.
5200         (get_displaced_step_closure_by_addr): Adjust.
5201         (remove_displaced_stepping_state): Remove.
5202         (infrun_inferior_exit): Call displaced_step_state.reset.
5203         (use_displaced_stepping): Don't check for NULL.
5204         (displaced_step_prepare_throw): Call
5205         get_displaced_stepping_state.
5206         (displaced_step_fixup): Don't check for NULL.
5207         (prepare_for_detach): Don't check for NULL.
5208
5209 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5210
5211         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
5212          in case of call that did not complete.
5213
5214 2019-01-02  Andrey Utkin  <autkin@undo.io>
5215
5216         * symfile.c (find_separate_debug_file): Fix search of debug files for
5217         remote debuggee.
5218
5219 2019-01-02  Tom Tromey  <tom@tromey.com>
5220
5221         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
5222         indentation.
5223         * python/py-frame.c (frapy_older): Remove cast.
5224         (frapy_newer): Likewise.
5225         * python/py-breakpoint.c (local_setattro): Remove cast.
5226         * python/py-arch.c (archpy_name): Remove local variable.
5227         * python/py-type.c (gdbpy_lookup_type): Remove cast.
5228
5229 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
5230
5231         * unittests/basic_string_view/element_access/char/empty.cc:
5232         Fix year range in copyright header.
5233
5234 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5235
5236         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
5237         Delete.
5238         <operator==>: Update with for removed field.
5239         <hash>: Likewise.
5240         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
5241         <isa_features>: ...this.
5242         <abi_features>: New field.
5243         (riscv_isa_flen): Update comment.
5244         (riscv_abi_xlen): New declaration.
5245         (riscv_abi_flen): New declaration.
5246         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
5247         isa_features.
5248         (riscv_abi_xlen): New function.
5249         (riscv_isa_flen): Update to get answer from isa_features.
5250         (riscv_abi_flen): New function.
5251         (riscv_has_fp_abi): Update to get answer from abi_features.
5252         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
5253         xlen and flen.
5254         (riscv_call_info) <xlen, flen>: Update comment.
5255         (riscv_call_arg_struct): Remove invalid assertions
5256         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
5257         is removed.
5258         (riscv_gdbarch_init): Gather isa features and abi features
5259         separately, ensure both match on the gdbarch when reusing an old
5260         gdbarch.  Relax an error check to allow 32-bit abi float to run on
5261         a target with 64-bit float hardware.
5262
5263 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5264
5265         * source.c (search_command_helper): Stop reverse search
5266         when line 1 has been searched.
5267
5268 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5269
5270         * record-full.c (record_full_base_target::close): Rewrite
5271         record_full_core_buf_list free logic.
5272
5273 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5274
5275         * break-catch-syscall.c (print_one_catch_syscall): xfree
5276         the last text.
5277
5278 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5279
5280         * top.c (print_gdb_version): Update Copyright year in version
5281         message.
5282
5283 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5284
5285         Update copyright year range in all GDB files.
5286
5287 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
5288
5289         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
5290
5291 For older changes see ChangeLog-2018.
5292 \f
5293 Local Variables:
5294 mode: change-log
5295 left-margin: 8
5296 fill-column: 74
5297 version-control: never
5298 coding: utf-8
5299 End:
5300