gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
   4         creation and re-initialization cases.
   5
   6 2019-07-17  Tom Tromey  <tom@tromey.com>
   7
   8         * tui/tui-regs.c (tui_get_register): Return void.
   9
  10 2019-07-17  Tom Tromey  <tom@tromey.com>
  11
  12         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
  13         Simplify.
  14
  15 2019-07-17  Tom Tromey  <tom@tromey.com>
  16
  17         * tui/tui-layout.c (show_source_disasm_command): Simplify window
  18         resetting.
  19
  20 2019-07-17  Tom Tromey  <tom@tromey.com>
  21
  22         * tui/tui.h (tui_set_layout_by_name): Don't declare.
  23         * tui/tui-regs.c (tui_reg_layout): New function.
  24         (tui_show_registers, tui_reg_command): Use it.
  25         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
  26         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
  27         parameters.
  28         (tui_layout_command): Remove.
  29
  30 2019-07-17  Tom Tromey  <tom@tromey.com>
  31
  32         * tui/tui-layout.h (tui/tui-layout): Return void.
  33         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
  34
  35 2019-07-17  Tom Tromey  <tom@tromey.com>
  36
  37         * tui/tui-layout.c (show_source_disasm_command, show_data):
  38         Update.
  39         (reset_locator): Remove.
  40         (show_source_or_disasm_and_command): Update.
  41
  42 2019-07-17  Tom Tromey  <tom@tromey.com>
  43
  44         * tui/tui-source.c (tui_source_window_base::reset): Remove
  45         win_type parameter.
  46         * tui/tui-layout.c (make_command_window, make_source_window)
  47         (make_disasm_window, make_data_window)
  48         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
  49         (reset_locator, show_source_or_disasm_and_command): Update.
  50         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
  51         win_type parameter.
  52         (struct tui_source_window_base) <reset>: Likewise.
  53
  54 2019-07-17  Tom Tromey  <tom@tromey.com>
  55
  56         * tui/tui-layout.c (show_source_disasm_command): Use
  57         reset_locator.
  58         (reset_locator): New function.
  59         (init_and_make_win): Remove.
  60         (show_source_or_disasm_and_command): Use reset_locator.
  61
  62 2019-07-17  Tom Tromey  <tom@tromey.com>
  63
  64         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
  65         condition.
  66         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
  67         Remove condition.
  68         * tui/tui-source.c (tui_source_window_base::reset): New method.
  69         * tui/tui-layout.c (make_command_window): Don't call
  70         init_and_make_win.
  71         (make_source_window, make_disasm_window): Don't call
  72         make_source_or_disasm_window.
  73         (make_data_window): Don't call init_and_make_win.  Change calling
  74         convention.
  75         (show_source_disasm_command, show_data): Simplify.
  76         (make_source_or_disasm_window): Remove.
  77         (show_source_or_disasm_and_command): Simplify.
  78         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
  79         (struct tui_source_window_base) <reset>: Likewise.
  80         <execution_info>: Remove initializer.
  81         * tui/tui-data.c (tui_source_window_base): Initialize
  82         execution_info.
  83
  84 2019-07-17  Tom Tromey  <tom@tromey.com>
  85
  86         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
  87         variable.
  88
  89 2019-07-17  Tom Tromey  <tom@tromey.com>
  90
  91         * tui/tui.c (tui_rl_other_window): Update.
  92         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
  93         superclass method first.  Always iterate over regs_content.
  94         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
  95         method.
  96         * tui/tui-win.c (tui_set_focus_command): Update.
  97
  98 2019-07-17  Tom Tromey  <tom@tromey.com>
  99
 100         * tui/tui-win.c (tui_set_focus_command): Rename from
 101         tui_set_focus.  Call tui_enable.
 102         (tui_set_focus_command): Remove.
 103
 104 2019-07-17  Tom Tromey  <tom@tromey.com>
 105
 106         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 107         refresh_window.
 108         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 109         touchwin.
 110         (tui_data_window::refresh_window): Call refresh_window on data
 111         items.  Always call superclass refresh_window.
 112         (tui_win_info::refresh): Remove.
 113         (tui_source_window_base::refresh_window): Update.
 114         (tui_refresh_all): Update.
 115         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 116         refresh_window.
 117         (show_source_or_disasm_and_command): Likewise.
 118         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 119         (struct tui_source_window_base) <refresh>: Likewise.
 120
 121 2019-07-17  Tom Tromey  <tom@tromey.com>
 122
 123         * tui/tui-winsource.c (tui_clear_source_content)
 124         (tui_show_source_content): Update.
 125         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 126         whether content is empty.
 127         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 128         Remove.
 129
 130 2019-07-17  Tom Tromey  <tom@tromey.com>
 131
 132         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 133         window's contents.
 134         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 135         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 136
 137 2019-07-17  Tom Tromey  <tom@tromey.com>
 138
 139         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 140         (struct tui_data_item_window): Update.
 141
 142 2019-07-17  Tom Tromey  <tom@tromey.com>
 143
 144         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 145         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 146         defines.
 147
 148 2019-07-17  Tom Tromey  <tom@tromey.com>
 149
 150         * tui/tui-winsource.h (tui_erase_source_content)
 151         (tui_clear_source_content): Remove "display_prompt" parameter.
 152         * tui/tui-winsource.c (tui_update_source_window_as_is)
 153         (tui_update_source_windows_with_addr): Update.
 154         (tui_clear_source_content): Remove "display_prompt" parameter.
 155         (tui_erase_source_content): Likewise.  Simplify.
 156         (tui_show_source_content): Update.
 157         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 158         * tui/tui-stack.c (tui_show_frame_info): Update.
 159         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 160         Remove defines.
 161
 162 2019-07-17  Tom Tromey  <tom@tromey.com>
 163
 164         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 165         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 166         parameter.
 167         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 168         parameter.
 169
 170 2019-07-17  Tom Tromey  <tom@tromey.com>
 171
 172         * tui/tui-winsource.c (tui_clear_source_content)
 173         (tui_show_source_content, tui_show_exec_info_content)
 174         (tui_clear_exec_info_content): Update.
 175         * tui/tui-stack.c (tui_show_locator_content): Update.
 176         (tui_show_frame_info): Update.
 177         * tui/tui-source.h (tui_source_window): Don't declare.
 178         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 179         from tui_source_is_displayed.
 180         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 181         Remove field.
 182         (struct tui_source_window_base) <content_in_use>: New field.  Now
 183         bool.
 184         (struct tui_source_window) <showing_source_p>: New method.
 185         (TUI_SRC_WIN): Change cast.
 186         * tui/tui-data.c (tui_initialize_static_data): Update.
 187
 188 2019-07-17  Tom Tromey  <tom@tromey.com>
 189
 190         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 191         location_matches_p.
 192         * tui/tui-source.c (tui_source_window::location_matches_p): New
 193         method.
 194         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 195         method.
 196         * tui/tui-data.h (struct tui_source_window_base)
 197         <location_matches_p>: New method.
 198         (struct tui_source_window, struct tui_disasm_window)
 199         <location_matches_p>: Likewise.
 200
 201 2019-07-17  Tom Tromey  <tom@tromey.com>
 202
 203         * tui/tui-win.c (tui_set_win_height_command): Rename from
 204         tui_set_win_height.
 205         (tui_set_win_height_command): Remove.
 206
 207 2019-07-17  Tom Tromey  <tom@tromey.com>
 208
 209         * tui/tui-source.c (tui_source_window): New constructor.  Add
 210         observer.
 211         (~tui_source_window): New destructor.
 212         (tui_source_window::style_changed): New method.
 213         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 214         (tui_attach_detach_observers): Update.
 215         * tui/tui-data.h (struct tui_source_window): Make constructor not
 216         inline.  Add destructor.
 217         (struct tui_source_window) <style_changed>: New method.
 218         <m_observable>: New member.
 219
 220 2019-07-17  Tom Tromey  <tom@tromey.com>
 221
 222         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 223         * tui/tui-win.c (tui_resize_all): Fix typo.
 224
 225 2019-07-17  Tom Tromey  <tom@tromey.com>
 226
 227         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 228         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 229         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 230         * tui/tui-win.c (window_name_completer): Use foreach.
 231         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 232         (update_tab_width): Likewise.
 233         * tui/tui-layout.c (show_layout): Update.
 234         * tui/tui-data.h (class tui_window_iterator): New.
 235         (struct all_tui_windows): New.
 236         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 237
 238 2019-07-17  Tom Tromey  <tom@tromey.com>
 239
 240         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 241         parameter.  Don't reference globals.
 242         (tui_reg_command): Update.
 243
 244 2019-07-17  Tom Tromey  <tom@tromey.com>
 245
 246         * tui/tui-regs.c (tui_show_registers): Simplify.
 247
 248 2019-07-17  Tom Tromey  <tom@tromey.com>
 249
 250         * tui/tui-regs.c (tui_show_registers): Update.
 251         (tui_show_register_group): Add win_info parameter.
 252
 253 2019-07-17  Tom Tromey  <tom@tromey.com>
 254
 255         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 256         Rename from tui_display_reg_element_at_line.
 257         (tui_data_window::display_registers_from_line): Update.
 258         * tui/tui-data.h (struct tui_data_window)
 259         <display_reg_element_at_line>: New method.
 260
 261 2019-07-17  Tom Tromey  <tom@tromey.com>
 262
 263         * tui/tui-regs.h (tui_display_registers_from)
 264         (tui_display_registers_from_line): Don't declare.
 265         * tui/tui-windata.c (tui_data_window::display_all_data)
 266         (tui_data_window::refresh_all)
 267         (tui_data_window::do_scroll_vertical): Update.
 268         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 269         from tui_display_registers_from.
 270         (tui_display_reg_element_at_line): Update.
 271         (tui_data_window::display_registers_from_line): Rename from
 272         tui_display_registers_from_line.
 273         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 274         display_registers_from_line>: New methods.
 275
 276 2019-07-17  Tom Tromey  <tom@tromey.com>
 277
 278         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 279         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 280         from tui_erase_data_content.
 281         (tui_data_window::display_all_data)
 282         (tui_data_window::refresh_all)
 283         (tui_data_window::do_scroll_vertical): Update.
 284         * tui/tui-regs.c (tui_show_registers): Update.
 285         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 286         New method.
 287
 288 2019-07-17  Tom Tromey  <tom@tromey.com>
 289
 290         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 291         declare.
 292         * tui/tui-windata.c
 293         (tui_data_window::delete_data_content_windows): Rename from
 294         tui_delete_data_content_windows.
 295         (tui_data_window::display_all_data)
 296         (tui_data_window::do_scroll_vertical): Update.
 297         * tui/tui-data.h (struct tui_data_window)
 298         <delete_data_content_windows>: New method.
 299
 300 2019-07-17  Tom Tromey  <tom@tromey.com>
 301
 302         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 303         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 304
 305 2019-07-17  Tom Tromey  <tom@tromey.com>
 306
 307         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 308         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 309         from tui_display_all_data.
 310         * tui/tui-win.c
 311         (tui_data_window::do_make_visible_with_new_height): Update.
 312         * tui/tui-regs.c (tui_show_registers): Update.
 313         * tui/tui-layout.c (tui_set_layout): Update.
 314         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 315         method.
 316
 317 2019-07-17  Tom Tromey  <tom@tromey.com>
 318
 319         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 320         * tui/tui-windata.c (tui_display_data_from): Remove.
 321         (tui_data_window::refresh_all): Update.
 322
 323 2019-07-17  Tom Tromey  <tom@tromey.com>
 324
 325         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 326         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 327         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 328         tui_display_registers_from_line.
 329         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 330         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 331         "force_display" parameter.
 332
 333 2019-07-17  Tom Tromey  <tom@tromey.com>
 334
 335         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 336         declare.
 337         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 338         Rename from tui_first_reg_element_no_inline.
 339         (tui_display_reg_element_at_line)
 340         (tui_display_registers_from_line): Update.
 341         * tui/tui-data.h (struct tui_data_window)
 342         <first_reg_element_no_inline>: New method.
 343
 344 2019-07-17  Tom Tromey  <tom@tromey.com>
 345
 346         * tui/tui-windata.c (tui_display_data_from)
 347         (tui_data_window::do_scroll_vertical): Update.
 348         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 349         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 350         Rename from tui_line_from_reg_element_no.
 351         (tui_display_registers_from_line): Update.
 352         * tui/tui-data.h (struct tui_data_window)
 353         <line_from_reg_element_no>: New method.
 354
 355 2019-07-17  Tom Tromey  <tom@tromey.com>
 356
 357         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 358         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 359         tui_last_regs_line_no.
 360         (tui_display_reg_element_at_line)
 361         (tui_display_registers_from_line): Update.
 362         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 363         method.
 364
 365 2019-07-17  Tom Tromey  <tom@tromey.com>
 366
 367         PR tui/24722:
 368         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 369         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 370         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 371         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 372         (tui_update_breakpoint_info): Likewise.
 373         * tui/tui-hooks.c (tui_event_create_breakpoint)
 374         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 375         Update.
 376
 377 2019-07-17  Tom Tromey  <tom@tromey.com>
 378
 379         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 380
 381 2019-07-17  Tom Tromey  <tom@tromey.com>
 382
 383         * tui/tui-winsource.c (tui_update_source_window_as_is)
 384         (tui_update_source_windows_with_addr): Update.
 385         * tui/tui-source.h (tui_set_source_content)
 386         (tui_show_symtab_source): Add "win_info" parameter.
 387         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 388         parameter.
 389         (tui_show_symtab_source): Likewise.
 390
 391 2019-07-17  Tom Tromey  <tom@tromey.com>
 392
 393         * tui/tui-wingeneral.c
 394         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 395
 396 2019-07-17  Tom Tromey  <tom@tromey.com>
 397
 398         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 399         (struct tui_cmd_window) <can_scroll>: New method.
 400         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 401         method.
 402
 403 2019-07-17  Tom Tromey  <tromey@adacore.com>
 404
 405         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 406         do_field_signed>: Rename.  Change type of "value".
 407         * ui-out.c (ui_out::field_signed): Rename from field_int.
 408         Change type of "value".
 409         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 410         type of "value".
 411         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 412         do_field_int.  Change type of "value".
 413         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 414         do_field_int.  Change type of "value".
 415         * tracepoint.c (trace_status_mi, tfind_1)
 416         (print_one_static_tracepoint_marker): Update.
 417         * thread.c (print_thread_info_1, print_selected_thread_frame):
 418         Update.
 419         * stack.c (print_frame, print_frame_info): Update.
 420         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 421         Update.
 422         * source.c (print_source_lines_base): Update.
 423         * skip.c (info_skip_command): Update.
 424         * record-btrace.c (btrace_ui_out_decode_error)
 425         (btrace_call_history_src_line): Update.
 426         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 427         Update.
 428         * progspace.c (print_program_space): Update.
 429         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 430         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 431         do_field_int.  Change type of "value".
 432         * mi/mi-out.c (mi_ui_out::do_table_begin)
 433         (mi_ui_out::do_table_header): Update.
 434         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 435         type of "value".
 436         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 437         (mi_cmd_data_list_changed_registers, output_register)
 438         (mi_cmd_data_read_memory, mi_load_progress)
 439         (mi_cmd_trace_frame_collected): Update.
 440         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 441         Update.
 442         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 443         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 444         (mi_cmd_var_list_children, varobj_update_one): Update.
 445         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 446         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 447         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 448         * inferior.c (print_inferior): Update.
 449         * gdb_bfd.c (print_one_bfd): Update.
 450         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 451         Update.
 452         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 453         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 454         do_field_int.  Change type of "value".
 455         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 456         do_field_int.  Change type of "value".
 457         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 458         (print_one_breakpoint_location, print_it_catch_fork)
 459         (print_one_catch_fork, print_it_catch_vfork)
 460         (print_one_catch_vfork, print_it_catch_solib)
 461         (print_it_catch_exec, print_it_ranged_breakpoint)
 462         (print_mention_watchpoint, print_mention_masked_watchpoint)
 463         (bkpt_print_it, update_static_tracepoint): Update.
 464         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 465         * break-catch-syscall.c (print_it_catch_syscall): Update.
 466         * ada-tasks.c (print_ada_task_info): Update.
 467         * ada-lang.c (print_it_exception, print_mention_exception):
 468         Update.
 469
 470 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 471
 472         PR breakpoints/24541
 473         * gdbarch.c: Regenerate.
 474         * gdbarch.h: Regenerate.
 475         * gdbarch.sh: Adjust return type and parameter types for
 476         'stap_adjust_register'.
 477         (i386_stap_adjust_register): Adjust signature and return new
 478         register name.
 479         * stap-probe.c (stap_parse_register_operand): Adjust use of
 480         'gdbarch_stap_adjust_register'.
 481
 482 2019-07-17  Tom Tromey  <tromey@adacore.com>
 483
 484         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 485         declare VEC.
 486         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 487         std::vector.
 488         (struct s390_process_info): Add initializers.
 489         (s390_add_process): Use new.
 490         (s390_linux_nat_target::low_forget_process): Use delete.
 491         (s390_linux_nat_target::low_new_fork)
 492         (s390_linux_nat_target::stopped_by_watchpoint)
 493         (s390_linux_nat_target::low_prepare_to_resume)
 494         (s390_linux_nat_target::insert_watchpoint)
 495         (s390_linux_nat_target::insert_hw_breakpoint)
 496         (s390_linux_nat_target::remove_watchpoint)
 497         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 498
 499 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 500
 501         * aarch64-fbsd-nat.c: Include regcache.h.
 502         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 503         argument.
 504         (aarch64_fbsd_nat_target::fetch_registers)
 505         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 506         variable.
 507         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 508
 509 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 510
 511         * fbsd-nat.c: Include gdbarch.h.
 512
 513 2019-07-15  Tom Tromey  <tromey@adacore.com>
 514
 515         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 516
 517 2019-07-15  Tom Tromey  <tromey@adacore.com>
 518
 519         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 520         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 521         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 522         * cli-out.c (cli_ui_out::do_field_int): New method.
 523         * ui-out.c (ui_out::field_unsigned): New method.
 524         * symfile.c (generic_load): Use field_unsigned.
 525         (print_transfer_performance): Likewise.
 526         * record-btrace.c (ui_out_field_uint): Remove.
 527         (btrace_call_history_insn_range, btrace_call_history): Use
 528         field_unsigned.
 529         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 530         field_unsigned.
 531         * ui-out.h (class ui_out) <field_unsigned>: New method.
 532         <do_field_unsigned>: Likewise.
 533
 534 2019-07-15  Tom Tromey  <tromey@adacore.com>
 535
 536         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 537         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 538         * target.c (flash_erase_command): Use field_string.
 539         * infrun.c (print_signal_received_reason): Use field_string.
 540         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 541         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 542         field_string.
 543         * ada-tasks.c (print_ada_task_info): Use field_string.
 544
 545 2019-07-15  Tom Tromey  <tromey@adacore.com>
 546
 547         * target.c (flash_erase_command): Use field_core_addr.
 548         * symfile.c (generic_load): Use field_core_addr.
 549         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 550         Use field_core_addr.
 551         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 552         field_core_addr.
 553
 554 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 555
 556         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 557         value if its desired type is smaller than a CORE_ADDR and signed.
 558
 559 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 560
 561         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 562         of changes to field names, and use new is_reference field to
 563         decide if a property is a reference or not.
 564         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 565         field.
 566         (struct dwarf2_property_baton): Update header comment, rename
 567         'referenced_type' to 'property_type' and update comments.
 568         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 569         default property type, store in property baton, update to take
 570         accound of renamed field.
 571         (read_func_scope): Update call to attr_to_dynamic_prop.
 572         (read_array_type): Likewise.
 573         (dwarf2_per_cu_addr_sized_int_type): New function.
 574         (read_subrange_index_type): Move type finding code to
 575         dwarf2_per_cu_addr_sized_int_type.
 576         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 577         (dwarf2_per_cu_addr_type): New function.
 578         (set_die_type): Update calls to attr_to_dynamic_prop.
 579
 580 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 581
 582         * dwarf2read.c (read_subrange_index_type): New function.
 583         (read_subrange_type): Move code into new function and call it.
 584         * gdbtypes.c (create_range_type): Add some asserts.
 585
 586 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 587
 588         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 589         update return statements.
 590         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 591         declaration, and update comment to match.
 592         * gdbtypes.c (resolve_dynamic_array): Update call to
 593         dwarf2_evaluate_property to match new return type.
 594
 595 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 596
 597         * valarith.c (value_subscripted_rvalue): Change lowerbound
 598         parameter type from int to LONGEST.
 599         * value.h (value_subscripted_rvalue): Likewise in declaration.
 600
 601 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 602
 603         * cli/cli-utils.c (info_print_command_completer): New function.
 604         * cli/cli-utils.h: Add 'completer.h' include, and forward
 605         declaration for 'struct cmd_list_element'.
 606         (info_print_command_completer): Declare.
 607         * stack.c (_initialize_stack): Add completer for 'info locals' and
 608         'info args'.
 609         * symtab.c (_initialize_symtab): Add completer for 'info
 610         variables' and 'info functions'.
 611         * NEWS: Mention completion for additional info commands.
 612
 613 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 614
 615         * cli/cli-utils.c (extract_info_print_args): Delete.
 616         (extract_arg_maybe_quoted): Delete.
 617         (info_print_options_defs): New variable.
 618         (make_info_print_options_def_group): New function.
 619         (extract_info_print_options): Define new function.
 620         * cli/cli-utils.h (extract_info_print_args): Delete.
 621         (struct info_print_options): New structure.
 622         (extract_info_print_options): Declare new function.
 623         * stack.c (info_locals_command): Update to use new
 624         extract_info_print_options, also add a header comment.
 625         (info_args_command): Likewise.
 626         * symtab.c (info_variables_command): Likewise.
 627         (info_functions_command): Likewise.
 628
 629 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 630
 631         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 632         to extract string arguments.
 633         * common/common-utils.c (extract_string_maybe_quoted): New function.
 634         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 635
 636 2019-07-11  Tom Tromey  <tromey@adacore.com>
 637
 638         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 639         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 640         * top.h (gdbinit): Don't declare.
 641         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 642         into...
 643         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 644         * top.c (gdb_init): Don't call init_cli_cmds.
 645         (gdbinit): Remove.
 646         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 647
 648 2019-07-11  Tom Tromey  <tromey@adacore.com>
 649
 650         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 651         after it has been moved.
 652
 653 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 654
 655         * valops.c (value_must_coerce_to_target): Change return type to
 656         bool.
 657         * value.h (value_must_coerce_to_target): Likewise.
 658
 659 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 660
 661         * breakpoint.c (is_hardware_watchpoint): Remove
 662         forward-declaration.
 663         (is_masked_watchpoint): Change return type to bool.
 664         (is_tracepoint): Likewise.
 665         (is_breakpoint): Likewise.
 666         (is_hardware_watchpoint): Likewise.
 667         (is_watchpoint): Likewise.
 668         (is_no_memory_software_watchpoint): Likewise.
 669         (is_catchpoint): Likewise.
 670         (breakpoint_1): Make FILTER parameter's return type bool.
 671         is_masked_watchpoint): Change return type to bool.
 672         (save_breakpoints): Make FILTER parameter's return type bool.
 673         * breakpoint.h (is_breakpoint): Change return type to bool.
 674         (is_watchpoint): Likewise.
 675         (is_catchpoint): Likewise.
 676         (is_tracepoint): Likewise.
 677
 678 2019-07-10  Tom Tromey  <tom@tromey.com>
 679
 680         * defs.h: Don't include gdbarch.h.
 681         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 682         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 683         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 684         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 685         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 686         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 687         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 688         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 689         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 690         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 691         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 692         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 693         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 694         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 695         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 696         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 697         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 698         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 699         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 700         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 701         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 702         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 703         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 704         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 705         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 706         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 707         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 708
 709 2019-07-10  Tom Tromey  <tromey@adacore.com>
 710
 711         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 712         * breakpoint.c (init_ada_exception_breakpoint): Register as
 713         bp_catchpoint.
 714         (print_one_breakpoint_location, print_one_breakpoint): Use
 715         is_ada_exception_catchpoint.
 716         * ada-lang.c (class ada_catchpoint_location): Pass
 717         bp_loc_software_breakpoint to bp_location constructor.
 718         (is_ada_exception_catchpoint): New function.
 719
 720 2019-07-10  Tom Tromey  <tromey@adacore.com>
 721
 722         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 723         VEC.
 724         (struct arm_exidx_entry): New method operator<.
 725         (struct arm_exidx_data) <section_maps>: Change type.
 726         (arm_exidx_data_free): Remove.
 727         (arm_exidx_data_key): Change type.  Move lower.
 728         (arm_exidx_new_objfile): Update.
 729         (arm_compare_exidx_entries): Remove.
 730         (arm_find_exidx_entry, _initialize_arm_tdep)
 731
 732 2019-07-10  Tom Tromey  <tromey@adacore.com>
 733
 734         * solib-spu.c (ocl_program_data_key): Change type.
 735         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 736         Update.
 737
 738 2019-07-10  Tom Tromey  <tromey@adacore.com>
 739
 740         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 741         (struct solib_aix_inferior_data) <library_list>: Change type.
 742         (solib_aix_inferior_data_handle): Change type.
 743         (get_solib_aix_inferior_data): Update.
 744         (solib_aix_free_library_list): Remove.
 745         (library_list_start_library): Update.
 746         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 747         return type.
 748         (solib_aix_get_library_list)
 749         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 750         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 751
 752 2019-07-10  Tom Tromey  <tromey@adacore.com>
 753
 754         * solib-dsbt.c (struct dsbt_info): Add initializers.
 755         (solib_dsbt_pspace_data): Change type.
 756         (dsbt_pspace_data_cleanup): Remove.
 757         (get_dsbt_info, _initialize_dsbt_solib): Update.
 758
 759 2019-07-10  Tom Tromey  <tromey@adacore.com>
 760
 761         * spu-tdep.c (spu_overlay_data): Change type.
 762         (spu_get_overlay_table, spu_overlay_new_objfile)
 763         (_initialize_spu_tdep): Update.
 764
 765 2019-07-10  Tom Tromey  <tromey@adacore.com>
 766
 767         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 768         destructor.
 769         (dbx_objfile_data_key): Change type and declare later.
 770         (DBX_SYMFILE_INFO): Rewrite.
 771         * dbxread.c (dbx_objfile_data_key): Change type.
 772         (dbx_symfile_init): Update.
 773         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 774         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 775         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 776
 777 2019-07-10  Tom Tromey  <tromey@adacore.com>
 778
 779         * jit.c (jit_program_space_key): Change type.  Move lower.
 780         (get_jit_program_space_data): Update.
 781         (jit_program_space_data_cleanup): Remove.
 782         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 783         Update.
 784         (struct jit_program_space_data): Add initializers.
 785
 786 2019-07-10  Tom Tromey  <tromey@adacore.com>
 787
 788         * solib-darwin.c (struct darwin_info): Add initializers.
 789         (solib_darwin_pspace_data): Change type.
 790         (darwin_pspace_data_cleanup): Remove.
 791         (get_darwin_info, _initialize_darwin_solib): Update.
 792
 793 2019-07-10  Tom Tromey  <tromey@adacore.com>
 794
 795         * remote-sim.c (struct sim_inferior_data): Add initializers,
 796         constructor, and destructor.
 797         (sim_inferior_data_key): Change type.  Move lower.
 798         (check_for_duplicate_sim_descriptor): Update.
 799         (get_sim_inferior_data): Use new.  Update.
 800         (~sim_inferior_data_cleanup): Rename from
 801         sim_inferior_data_cleanup.  Simplify.
 802         (gdbsim_close_inferior, simulator_command)
 803         (sim_command_completer, _initialize_remote_sim): Update.
 804         (next_pid, INITIAL_PID): Move earlier.
 805
 806 2019-07-10  Tom Tromey  <tromey@adacore.com>
 807
 808         * python/python-internal.h (create_thread_object): Return
 809         gdbpy_ref.
 810         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 811         * python/py-inferior.c (struct threadlist_entry): Add
 812         constructor.
 813         <thread_obj>: Now a gdbpy_ref.
 814         (thread_to_thread_object): Update.
 815         (add_thread_object): Use new.
 816         (delete_thread_object): Use delete.
 817         (infpy_threads): Update.
 818         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 819         GIL.
 820
 821 2019-07-10  Tom Tromey  <tromey@adacore.com>
 822
 823         * valops.c (value_cast): Specialize error message for Ada.
 824
 825 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 826
 827         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 828
 829 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 830
 831         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 832         bpstat_should_step): Return bool, adjust comments.
 833         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 834         bpstat_should_step): Likewise.
 835
 836 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 837
 838         * features/Makefile: Use feature target descriptions for Arm.
 839         * features/arm/arm-core.c: Generate new file.
 840         * features/arm/arm-fpa.c: Likewise.
 841         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 842         * features/arm/arm-m-profile.c: Likewise.
 843         * features/arm/arm-vfpv2.c: Likewise.
 844         * features/arm/arm-vfpv3.c: Likewise.
 845         * features/arm/xscale-iwmmxt.c: Likewise.
 846         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 847
 848 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 849
 850         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 851         ptrace earlier.
 852
 853 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 854
 855         * features/aarch64-pauth.c: Regenerate.
 856
 857 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 858
 859         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 860         bool.
 861         (bpstat_what): Use false instead of 0.
 862
 863 2019-07-09  Pedro Alves  <palves@redhat.com>
 864
 865         * break-catch-throw.c (is_exception_catchpoint): New.
 866         * breakpoint.c (print_one_breakpoint_location): New parameter
 867         'raw_loc'.  Handle it.  Use
 868         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 869         looking at the breakpoint's type.
 870         (print_one_breakpoint): If handling "maint info breakpoints", also
 871         print locations of exception catchpoints.
 872         * breakpoint.h (is_exception_catchpoint): Declare.
 873
 874 2019-07-09  Pedro Alves  <palves@redhat.com>
 875
 876         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 877         "addr" field.
 878         (allocate_location_exception_catchpoint): New.
 879         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 880         (initialize_throw_catchpoint_ops): Install
 881         allocate_location_exception_catchpoint as allocate_location
 882         method.
 883         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 884         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 885         bp_loc_other.
 886         (breakpoint_address_is_meaningful): Delete.
 887         (bl_address_is_meaningful): New.
 888         (breakpoint_locations_match): Adjust comment.
 889         (bp_location_from_bp_type): New, factored out of...
 890         (bp_location::bp_location(breakpoint *)): ... this.
 891         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 892         factored out of...
 893         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 894         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 895         breakpoint_address_is_meaningful.
 896         (bp_locations_compare): Adjust comment.
 897         (update_global_location_list): Use bl_address_is_meaningful
 898         instead of breakpoint_address_is_meaningful.
 899         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 900         explicit.
 901         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 902         * python/py-breakpoint.c (bppy_get_location): No longer check
 903         whether location is null.
 904
 905 2019-07-09  Pedro Alves  <palves@redhat.com>
 906
 907         PR c++/15468
 908         * breakpoint.c (print_one_breakpoint_location): Remove
 909         single-location assert.
 910
 911 2019-07-09  Tom Tromey  <tom@tromey.com>
 912
 913         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 914         * configure: Rebuild.
 915         * configure.ac: Change common to gdbsupport.
 916         * gdbsupport: Rename from common.
 917         * acinclude.m4: Change common to gdbsupport.
 918         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 919         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 920         gdbsupport.
 921         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 922         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 923         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 924         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 925         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 926         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 927         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 928         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 929         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 930         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 931         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 932         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 933         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 934         coff-pe-read.c, command.h, compile/compile-c-support.c,
 935         compile/compile-c.h, compile/compile-cplus-symbols.c,
 936         compile/compile-cplus-types.c, compile/compile-cplus.h,
 937         compile/compile-loc2c.c, compile/compile.c, completer.c,
 938         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 939         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 940         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 941         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 942         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 943         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 944         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 945         features/aarch64-core.c, features/aarch64-fpu.c,
 946         features/aarch64-pauth.c, features/aarch64-sve.c,
 947         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 948         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 949         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 950         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 951         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 952         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 953         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 954         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 955         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 956         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 957         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 958         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 959         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 960         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 961         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 962         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 963         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 964         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 965         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 966         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 967         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 968         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 969         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 970         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 971         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 972         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 973         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 974         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 975         minsyms.c, mips-linux-tdep.c, namespace.h,
 976         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 977         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 978         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 979         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 980         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 981         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 982         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 983         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 984         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 985         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 986         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 987         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 988         procfs.c, producer.c, progspace.h, psymtab.h,
 989         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 990         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 991         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 992         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 993         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 994         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 995         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 996         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 997         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 998         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 999         target-memory.c, target.c, target.h, target/waitstatus.c,
1000         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1001         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1002         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1003         unittests/array-view-selftests.c,
1004         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1005         unittests/common-utils-selftests.c,
1006         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1007         unittests/format_pieces-selftests.c,
1008         unittests/function-view-selftests.c,
1009         unittests/lookup_name_info-selftests.c,
1010         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1011         unittests/mkdir-recursive-selftests.c,
1012         unittests/observable-selftests.c,
1013         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1014         unittests/parse-connection-spec-selftests.c,
1015         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1016         unittests/scoped_fd-selftests.c,
1017         unittests/scoped_mmap-selftests.c,
1018         unittests/scoped_restore-selftests.c,
1019         unittests/string_view-selftests.c, unittests/style-selftests.c,
1020         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1021         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1022         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1023         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1024         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1025         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1026
1027 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1028
1029         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1030         bool value.
1031         (decode_digits_ordinary): Set explicit_line field in sal.
1032         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1033         symtab_and_line that was set on an explicit line number in
1034         assembler code.  Do always update the recorded symtab and line if
1035         we do skip the prologue.
1036
1037 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1038
1039         * breakpoint.c (set_breakpoint_location_function): Remove
1040         explicit_loc parameter.
1041         (momentary_breakpoint_from_master): Update call to
1042         set_breakpoint_location_function.
1043         (add_location_to_breakpoint): Likewise.
1044
1045 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1046
1047         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1048         required features based on default bfd type when no specific bfd
1049         is present.
1050
1051 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1052
1053         * NEWS: Mention that GDB printf and eval commands can now print
1054         C-style and Ada-style convenience var strings without
1055         calling the inferior.
1056         * printcmd.c (printf_c_string): Locally print GDB internal var
1057         instead of transiting via the inferior.
1058         (printf_wide_c_string): Likewise.
1059
1060 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1061
1062         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1063
1064 2019-07-04  Tom Tromey  <tom@tromey.com>
1065
1066         PR tui/24724:
1067         * tui/tui-winsource.c (tui_clear_source_content): Update.
1068         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1069         (tui_update_breakpoint_info): Update.
1070         (tui_set_exec_info_content): Update.
1071         * tui/tui-source.c (tui_set_source_content_nil): Update.
1072         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1073         has_break.
1074         * tui/tui-data.h (enum tui_bp_flag): New.
1075         (tui_bp_flags): New enum flags type.
1076         (struct tui_source_element) <break_mode>: Change type.  Rename
1077         from has_break.
1078         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1079         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1080         constants.
1081         * tui/tui-winsource.h: Fix comment.
1082
1083 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1084
1085         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1086         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1087         (store_fpregs_to_thread)
1088         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1089         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1090         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1091         (IWMMXT_REGS_SIZE): Add define.
1092         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1093         (fetch_vfp_regs, store_vfp_regs)
1094         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1095         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1096
1097 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1098
1099         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1100         defines.
1101         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1102         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1103         (ARM_INT_REGISTER_SIZE): ...to this.
1104         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1105         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1106         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1107         (arm_linux_collect_gregset, supply_nwfpe_register)
1108         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1109         defines.
1110         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1111         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1112         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1113         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1114         (arm_return_in_memory, arm_store_return_value)
1115         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1116         (arm_record_ld_st_multiple): Likewise.
1117         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1118         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1119
1120 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1121
1122         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1123         AARCH64_DISPLACED_MODIFIED_INSNS.
1124         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1125         (aarch64_displaced_step_copy_insn): Likewise.
1126         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1127         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1128         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1129         ARM_DISPLACED_MODIFIED_INSNS.
1130         * arm-tdep.c (arm_gdbarch_init): Likewise.
1131         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1132         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1133         (struct arm_displaced_step_closure): Use
1134         ARM_DISPLACED_MODIFIED_INSNS.
1135
1136 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1137
1138         * features/Makefile: Remove unused xml files.
1139         * features/aarch64.xml: Remove.
1140         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1141         * features/i386/amd64-avx-avx512.xml: Remove.
1142         * features/i386/amd64-avx-linux.xml: Remove.
1143         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1144         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1145         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1146         * features/i386/amd64-avx-mpx.xml: Remove.
1147         * features/i386/amd64-avx.xml: Remove.
1148         * features/i386/amd64-linux.xml: Remove.
1149         * features/i386/amd64-mpx-linux.xml: Remove.
1150         * features/i386/amd64-mpx.xml: Remove.
1151         * features/i386/amd64.xml: Remove.
1152         * features/i386/i386-avx-avx512-linux.xml: Remove.
1153         * features/i386/i386-avx-avx512.xml: Remove.
1154         * features/i386/i386-avx-linux.xml: Remove.
1155         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1156         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1157         * features/i386/i386-avx-mpx-linux.xml: Remove.
1158         * features/i386/i386-avx-mpx.xml: Remove.
1159         * features/i386/i386-avx.xml: Remove.
1160         * features/i386/i386-linux.xml: Remove.
1161         * features/i386/i386-mmx-linux.xml: Remove.
1162         * features/i386/i386-mmx.xml: Remove.
1163         * features/i386/i386-mpx-linux.xml: Remove.
1164         * features/i386/i386-mpx.xml: Remove.
1165         * features/i386/i386.xml: Remove.
1166         * features/i386/x32-avx-avx512-linux.xml: Remove.
1167         * features/i386/x32-avx-linux.xml: Remove.
1168         * features/i386/x32-linux.xml: Remove.
1169
1170 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1171
1172         * regformats/aarch64.dat: Remove.
1173         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1174         * regformats/i386/amd64-avx-linux.dat: Remove.
1175         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1176         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1177         * regformats/i386/amd64-linux.dat: Remove.
1178         * regformats/i386/amd64-mpx-linux.dat: Remove.
1179         * regformats/i386/amd64.dat: Remove.
1180         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1181         * regformats/i386/i386-avx-linux.dat: Remove.
1182         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1183         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1184         * regformats/i386/i386-linux.dat: Remove.
1185         * regformats/i386/i386-mmx-linux.dat: Remove.
1186         * regformats/i386/i386-mpx-linux.dat: Remove.
1187         * regformats/i386/i386.dat: Remove.
1188         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1189         * regformats/i386/x32-avx-linux.dat: Remove.
1190         * regformats/i386/x32-linux.dat: Remove.
1191
1192 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1193
1194         * aarch64-tdep.c: Remove xml self tests.
1195         * amd64-linux-tdep.c: Likewise.
1196         * amd64-tdep.c: Likewise.
1197         * i386-linux-tdep.c: Likewise.
1198         * i386-tdep.c: Likewise.
1199
1200 2019-07-03  Pedro Alves  <palves@redhat.com>
1201
1202         PR cli/24732
1203         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1204         (pipe_cmd_option_defs): New.
1205         (make_pipe_cmd_options_def_group): New.
1206         (pipe_command): Use gdb::option::process_options.
1207         (pipe_command_completer): New function.
1208         (_initialize_cli_cmds): Install completer for "pipe" command.
1209
1210 2019-07-03  Pedro Alves  <palves@redhat.com>
1211
1212         * cli/cli-option.c (union option_value) <string>: New field.
1213         (struct option_def_and_value): Add ctor, move ctor, dtor and
1214         use DISABLE_COPY_AND_ASSIGN.
1215         (option_def_and_value::clear_value): New.
1216         (parse_option, save_option_value_in_ctx, get_val_type_str)
1217         (add_setshow_cmds_for_options): Handle var_string.
1218         * cli-option.h (union option_def::var_address) <string>: New
1219         field.
1220         (struct string_option_def): New.
1221         * maint-test-options.c (struct test_options_opts): Add default
1222         ctor and use DISABLE_COPY_AND_ASSIGN.
1223         <string_opt>: New field.
1224         (test_options_opts::~test_options_opts): New.
1225         (test_options_opts::dump): Also dump "-string".
1226         (test_options_option_defs): Install "string.
1227
1228 2019-07-03  Pedro Alves  <palves@redhat.com>
1229
1230         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1231         option_value with a null enumeration.
1232         (complete_options): Save the option values in the context.
1233         (save_option_value_in_ctx): New, factored out from ...
1234         (process_options): ... here.
1235         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1236         of the function.
1237         * maint-test-options.c (test_options_opts::dump): New, factored
1238         out from ...
1239         (maintenance_test_options_command_mode): ... here.
1240         (maintenance_test_options_command_completion_result): Delete.
1241         (maintenance_test_options_command_completion_text): Update
1242         comment.
1243         (maintenance_show_test_options_completion_result): Change
1244         prototype.  Just print
1245         maintenance_test_options_command_completion_text.
1246         (save_completion_result): New.
1247         (maintenance_test_options_completer_mode): Pass options context to
1248         complete_options, and then save a dump.
1249         (_initialize_maint_test_options): Use add_cmd to install "maint
1250         show test-options-completion-result".
1251
1252 2019-07-03  Pedro Alves  <palves@redhat.com>
1253
1254         * NEWS (New commands): Mention "with" and "maint with".
1255         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1256         (with_command, with_command_completer): New.
1257         (pipe_command): Adjust to new repeat_previous
1258         interface.
1259         (_initialize_cli_cmds): Install the "with" command and its "w"
1260         alias.
1261         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1262         declarations.
1263         * cli/cli-setshow.c (parse_cli_var_uinteger)
1264         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1265         argument strings for all var_types.
1266         (get_setshow_command_value_string): New, factored out from ...
1267         (do_show_command): ... this.
1268         * cli/cli-setshow.h: Include <string>.
1269         (get_setshow_command_value_string): Declare.
1270         * command.h (repeat_previous): Now returns const char *.  Adjust
1271         comment.
1272         * maint.c: Include "cli/cli-cmds.h".
1273         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1274         (_initialize_maint_cmds): Register the "maintenance with" command.
1275         * top.c (repeat_previous): Move bits from pipe_command here:
1276         Return the saved command line, if any; error out if there's no
1277         command to relaunch.
1278
1279 2019-07-03  Pedro Alves  <palves@redhat.com>
1280
1281         * NEWS (New commands): Mention "maint set/show test-settings"
1282         instead of "maint test-settings".
1283         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1284         (maintenance_test_settings_set_list): Rename to ...
1285         (maintenance_set_test_settings_list): ... this.
1286         (maintenance_test_settings_show_list): Rename to  ...
1287         (maintenance_show_test_settings_list): ... this.
1288         (maintenance_test_settings_cmd): Delete.
1289         (maintenance_test_settings_set_cmd): ...
1290         (maintenance_set_test_settings_cmd): ... this.
1291         (maintenance_test_settings_show_cmd): ...
1292         (maintenance_show_test_settings_cmd): ... this.
1293         (maintenance_test_settings_show_value_cmd):
1294         (maintenance_show_test_settings_value_cmd): ... this.
1295         (_initialize_maint_test_settings): No longer install the "maint
1296         test-settings" prefix command.  Rename "maint test-settings set"
1297         to "maint set test-settings", and "maint test-settings show" to
1298         "maint show test-settings".  Adjust all subcommands.
1299
1300 2019-07-03  Pedro Alves  <palves@redhat.com>
1301
1302         * maint-test-settings.c: Fix file's intro comment.  Replace all
1303         references to "test-options" with references to "test-settings",
1304         in comments.
1305
1306 2019-07-03  Pedro Alves  <palves@redhat.com>
1307
1308         * maint-test-settings.c (maintenance_test_settings_xxx)
1309         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1310         New.
1311         (maintenance_test_settings_enums): Use them.
1312         (maintenance_test_settings_enum): Default to
1313         maintenance_test_settings_xxx.
1314         (_initialize_maint_test_settings): Initialize
1315         MAINTENANCE_TEST_SETTINGS_FILENAME.
1316
1317 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1318
1319         * breakpoint.h (remove_breakpoints_inf): Change return type to
1320         void, move function documentation here.
1321         * breakpoint.c (remove_breakpoints_inf): Change return type to
1322         void, move function documentation to header.
1323
1324 2019-07-02  Pedro Alves  <palves@redhat.com>
1325
1326         * NEWS (Completion improvements): Mention "info threads".
1327         * thread.c (struct info_threads_opts, info_threads_option_defs)
1328         (make_info_threads_options_def_group): New.
1329         (info_threads_command): Use gdb::option::process_options.
1330         (info_threads_command_completer): New.
1331         (_initialize_thread): Use gdb::option::build_help to build the
1332         help text for "info threads".
1333
1334 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1335
1336         * defs.h (generic_load): Move from here...
1337         * symfile.h (generic_load): ... to here.  Rename name parameter
1338         to args.
1339         * symfile.c (generic_load): Add comment.
1340
1341 2019-07-01  Tom Tromey  <tromey@adacore.com>
1342
1343         * dwarf2read.c
1344         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1345         declaration of without_params.  Fix formatting.
1346
1347 2019-07-01  Tom Tromey  <tromey@adacore.com>
1348
1349         * ada-exp.y (find_primitive_type): Update.
1350         * ada-lang.h (ada_lookup_symbol): Update.
1351         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1352         parameter.
1353         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1354
1355 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1356
1357         PR breakpoints/24541
1358         * gdbarch.c: Regenerate.
1359         * gdbarch.h: Regenerate.
1360         * gdbarch.sh: Add 'stap_adjust_register'.
1361         * i386-tdep.c: Include '<unordered_set>'.
1362         (i386_stap_adjust_register): New function.
1363         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1364         * stap-probe.c (stap_parse_register_operand): Call
1365         'gdbarch_stap_adjust_register'.
1366
1367 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1368
1369         PR python/24742
1370         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1371         * python/python.c (do_start_initialization): Use 'xmalloc'
1372         instead of 'PyMem_Malloc'.
1373
1374 2019-06-28  Tom Tromey  <tromey@adacore.com>
1375
1376         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1377         for Ada.
1378
1379 2019-06-27  Tom Tromey  <tromey@adacore.com>
1380
1381         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1382         objfile_key.
1383         (arm_find_mapping_symbol, arm_record_special_symbol)
1384         (_initialize_arm_tdep): Update.
1385         (arm_objfile_data_free): Remove.
1386
1387 2019-06-27  Tom Tromey  <tromey@adacore.com>
1388
1389         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1390         to cp_print_static_field.
1391
1392 2019-06-26  Tom Tromey  <tromey@adacore.com>
1393
1394         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1395         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1396         declare.
1397
1398 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1399
1400         * features/aarch64-core.c (create_feature_aarch64_core):
1401         Regenerate.
1402         * features/aarch64-core.xml: Add cpsr flags.
1403
1404 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1405
1406         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1407         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1408
1409 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1410
1411         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1412         field.
1413         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1414         use.
1415         (arm_record_special_symbol): Don't insert new symbol in sorted
1416         position, push it at the end.
1417
1418 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1419
1420         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1421         (arm_mapping_symbol_s): Remove.
1422         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1423         (arm_mapping_symbol_vec): New typedef.
1424         (struct arm_per_objfile): Add constructor.
1425         <section_maps>: Change type to
1426         std::unique_ptr<arm_mapping_symbol_vec[]>.
1427         (arm_compare_mapping_symbols): Remove.
1428         (arm_find_mapping_symbol): Adjust to section_maps type change.
1429         (arm_objfile_data_free): Call delete on arm_per_objfile.
1430         (arm_record_special_symbol): Adjust to section_maps type change.
1431         Allocate arm_per_objfile with new.
1432
1433 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1434
1435         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1436         with the command prefix.
1437
1438 2019-06-25  Tom Tromey  <tom@tromey.com>
1439
1440         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1441         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1442
1443 2019-06-25  Tom Tromey  <tom@tromey.com>
1444
1445         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1446         type.
1447         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1448         protected.
1449
1450 2019-06-25  Tom Tromey  <tom@tromey.com>
1451
1452         * tui/tui-winsource.c
1453         (tui_source_window_base::set_is_exec_point_at): Add check against
1454         LOA_ADDRESS.
1455
1456 2019-06-25  Tom Tromey  <tom@tromey.com>
1457
1458         * tui/tui-source.c (tui_set_source_content): Don't check before
1459         xfree.
1460         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1461
1462 2019-06-25  Tom Tromey  <tom@tromey.com>
1463
1464         * tui/tui-winsource.h (tui_update_source_window_as_is)
1465         (tui_alloc_source_buffer, tui_line_is_displayed)
1466         (tui_addr_is_displayed): Change type of win_info.
1467         * tui/tui-winsource.c (tui_update_source_window_as_is)
1468         (tui_clear_source_content, tui_show_source_line)
1469         (tui_show_source_content, tui_source_window_base::refill)
1470         (tui_source_window_base::set_is_exec_point_at)
1471         (tui_source_window_base::set_is_exec_point_at)
1472         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1473         (tui_alloc_source_buffer, tui_line_is_displayed)
1474         (tui_addr_is_displayed): Change type of win_info.  Update.
1475         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1476         (tui_source_window_base::do_make_visible_with_new_height):
1477         Update.
1478         * tui/tui-source.c (tui_set_source_content)
1479         (tui_set_source_content_nil)
1480         (tui_source_window::do_scroll_vertical): Update.
1481         * tui/tui-layout.c (show_layout): Update.
1482         * tui/tui-disasm.c (tui_set_disassem_content)
1483         (tui_disasm_window::do_scroll_vertical): Update.
1484         * tui/tui-data.h (tui_win_content): Remove.
1485         (struct tui_gen_win_info) <content, content_size>: Remove.
1486         (struct tui_source_element): Add initializers and destructor.
1487         (union tui_which_element, struct tui_win_element): Remove.
1488         (struct tui_source_window_base) <content>: New field.
1489         (struct tui_data_window): Remove destructor.
1490         (tui_alloc_content, tui_free_win_content)
1491         (tui_free_all_source_wins_content): Don't declare.
1492         * tui/tui-data.c (tui_initialize_static_data): Update.
1493         (init_content_element, tui_alloc_content): Remove.
1494         (~tui_gen_win_info): Update.
1495         (~tui_data_window, tui_free_all_source_wins_content)
1496         (tui_free_win_content, free_content, free_content_elements):
1497         Remove.
1498
1499 2019-06-25  Tom Tromey  <tom@tromey.com>
1500
1501         * tui/tui-winsource.h (tui_clear_source_content)
1502         (tui_erase_source_content, tui_show_source_content): Change type
1503         of win_info.
1504         * tui/tui-winsource.c (tui_clear_source_content)
1505         (tui_erase_source_content, tui_show_source_content): Change type
1506         of win_info.
1507         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1508         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1509         win_info.
1510         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1511         win_info.
1512         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1513
1514 2019-06-25  Tom Tromey  <tom@tromey.com>
1515
1516         * tui/tui-winsource.c (tui_clear_source_content)
1517         (tui_source_window_base::set_is_exec_point_at): Update.
1518         * tui/tui-source.c (tui_set_source_content_nil): Update.
1519         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1520         a bool.
1521         * tui/tui-data.c (init_content_element): Update.
1522
1523 2019-06-25  Tom Tromey  <tom@tromey.com>
1524
1525         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1526         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1527         * tui/tui-layout.c (init_and_make_win): Update.
1528         * tui/tui.h (enum tui_win_type): Update.
1529         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1530         tui_win_is_auxillary.
1531         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1532         tui_win_is_auxillary.
1533
1534 2019-06-25  Tom Tromey  <tom@tromey.com>
1535
1536         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1537         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1538         (tui_delete_data_content_windows, tui_display_all_data)
1539         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1540         Update.
1541         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1542         * tui/tui-regs.c (tui_last_regs_line_no)
1543         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1544         (tui_show_registers): Update.
1545         (tui_show_register_group): Return void.  Update.
1546         (tui_display_registers_from, tui_display_reg_element_at_line)
1547         (tui_display_registers_from_line, tui_check_register_values):
1548         Update.
1549         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1550         member.
1551         (struct tui_data_window) <regs_content>: Now a std::vector.
1552         <regs_content_count>: Remove.
1553         (tui_add_content_elements, tui_free_data_content): Don't declare.
1554         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1555         (init_content_element): Remove DATA_WIN case.  Add assert.
1556         (tui_add_content_elements): Remove.
1557         (tui_data_window): Update.
1558         (tui_free_data_content): Remove.
1559         (free_content_elements): Remove DATA_WIN case.
1560
1561 2019-06-25  Tom Tromey  <tom@tromey.com>
1562
1563         * tui/tui-data.c (tui_data_item_window): Update.
1564         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1565         * tui/tui-windata.c (tui_display_all_data)
1566         (tui_display_data_from_line): Update.
1567         (tui_check_data_values): Remove.
1568         * tui/tui-regs.c (tui_show_register_group)
1569         (tui_display_reg_element_at_line): Update.
1570         * tui/tui-hooks.c (tui_register_changed)
1571         (tui_refresh_frame_and_register_information): Call
1572         tui_check_register_values.
1573         * tui/tui-data.h (struct tui_data_window) <data_content,
1574         data_content_count, data_type>: Remove.
1575         (enum tui_data_type): Remove.
1576
1577         * tui/tui-data.c (tui_data_window::clear_detail)
1578         (~tui_data_window): Update.
1579
1580 2019-06-25  Tom Tromey  <tom@tromey.com>
1581
1582         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1583         declare.
1584         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1585         Rename from tui_first_data_item_displayed.  Update.
1586         (tui_data_window::refresh_all)
1587         (tui_data_window::do_scroll_vertical): Update.
1588         * tui/tui-data.h (struct tui_data_window)
1589         <first_data_item_displayed>: Declare new method.
1590
1591 2019-06-25  Tom Tromey  <tom@tromey.com>
1592
1593         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1594         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1595         contents...
1596         (tui_initialize_static_data): ...here.
1597
1598 2019-06-25  Tom Tromey  <tom@tromey.com>
1599
1600         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1601         (tui_display_registers_from, tui_check_register_values): Update.
1602         (tui_display_register): Remove win_info parameter; update.
1603         (tui_get_register): Change type of parameters.
1604         * tui/tui-data.h (struct tui_data_element): Remove.
1605         (union tui_which_element) <data>: Remove.
1606         <data_window>: Change type.
1607         (struct tui_data_item_window): New.
1608         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1609         case.  Add assert.
1610         (~tui_data_item_window): New destructor.
1611         (free_content_elements): Remove DATA_ITEM_WIN case.
1612
1613 2019-06-25  Tom Tromey  <tom@tromey.com>
1614
1615         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1616         Remove.
1617
1618 2019-06-25  Tom Tromey  <tom@tromey.com>
1619
1620         * tui/tui-data.h (struct tui_command_element): Remove.
1621         (union tui_which_element) <command>: Remove.
1622         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1623         assert.
1624         (free_content_elements): Remove CMD_WIN case.
1625
1626 2019-06-25  Tom Tromey  <tom@tromey.com>
1627
1628         * tui/tui-layout.c (tui_set_layout): Update.
1629         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1630         * tui/tui-data.c (layout_def): Update.
1631
1632 2019-06-25  Tom Tromey  <tom@tromey.com>
1633
1634         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1635         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1636         (tui_source_window_base::set_new_height): Update.
1637         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1638         Update.
1639         (tui_set_locator_fullname, tui_set_locator_info)
1640         (tui_show_frame_info): Update.
1641         * tui/tui-source.c (tui_set_source_content)
1642         (tui_source_is_displayed): Update.
1643         * tui/tui-layout.c (show_source_disasm_command, show_data)
1644         (show_source_or_disasm_and_command): Update.
1645         * tui/tui-disasm.c (tui_set_disassem_content)
1646         (tui_get_begin_asm_address): Update.
1647         * tui/tui-data.h (struct tui_locator_element): Remove.
1648         (union tui_which_element) <locator>: Remove.
1649         (struct tui_locator_window): New.
1650         (tui_locator_win_info_ptr): Change return type.
1651         * tui/tui-data.c (_locator): Change type.
1652         (tui_locator_win_info_ptr): Change return type.
1653         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1654         (tui_alloc_content): Add assert.
1655
1656 2019-06-25  Tom Tromey  <tom@tromey.com>
1657
1658         * tui/tui-winsource.c
1659         (tui_exec_info_window::maybe_allocate_content): New method.
1660         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1661         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1662         (make_source_or_disasm_window): Add cast.
1663         * tui/tui-data.h (union tui_which_element) <simple_string>:
1664         Remove.
1665         (struct tui_source_info): New.
1666         (struct tui_source_window_base) <execution_info>: Change type.
1667         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1668         case, and add assert.
1669         (tui_alloc_content): Add assert.
1670
1671 2019-06-25  Tom Tromey  <tom@tromey.com>
1672
1673         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1674         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1675         * tui/tui-data.c (tui_alloc_win_info): Remove.
1676
1677 2019-06-25  Tom Tromey  <tom@tromey.com>
1678
1679         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1680         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1681         can_highlight.
1682
1683 2019-06-25  Tom Tromey  <tom@tromey.com>
1684
1685         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1686         make_visible_with_new_height method.
1687         (tui_win_info::make_visible_with_new_height): New method.
1688         (tui_source_window_base::do_make_visible_with_new_height)
1689         (tui_data_window::do_make_visible_with_new_height)
1690         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1691         (make_visible_with_new_height): Remove.
1692         (tui_resize_all, tui_adjust_win_heights): Use
1693         make_visible_with_new_height method.
1694         * tui/tui-data.h (struct tui_win_info)
1695         <do_make_visible_with_new_height, make_visible_with_new_height>:
1696         New methods.
1697         (struct tui_source_window_base, struct tui_data_window)
1698         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1699         methods.
1700
1701 2019-06-25  Tom Tromey  <tom@tromey.com>
1702
1703         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1704         method.
1705         (update_tab_width): Call update_tab_width method.
1706         * tui/tui-data.h (struct tui_win_info)
1707         (struct tui_source_window_base) <update_tab_width>: New methods.
1708
1709 2019-06-25  Tom Tromey  <tom@tromey.com>
1710
1711         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1712         parameter.
1713         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1714         parameter.
1715         (tui_gen_win_info::make_visible): Update.
1716         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1717         parameter.
1718         * tui/tui-data.h (enum tui_box): New enum.
1719         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1720
1721 2019-06-25  Tom Tromey  <tom@tromey.com>
1722
1723         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1724         init_and_make_win for EXEC_INFO_WIN.
1725         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1726         longer inline.
1727         (struct tui_win_info) <~tui_win_info>: Inline.
1728         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1729         Don't declare.
1730         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1731         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1732         Remove.
1733         (tui_initialize_static_data): Update.
1734         (~tui_gen_win_info): Handle more cleanup here.
1735         (~tui_source_window_base): Delete "execution_info".
1736         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1737
1738 2019-06-25  Tom Tromey  <tom@tromey.com>
1739
1740         * tui/tui-layout.c (make_command_window): Don't set
1741         can_highlight.
1742         (show_source_disasm_command): Call the reset method.
1743         (show_data): Don't set can_highlight.  Call the reset method.
1744         (tui_gen_win_info::reset): Rename from init_gen_win_info
1745         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1746         (show_source_or_disasm_and_command): Call the reset method.
1747         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1748         (struct tui_cmd_window): Set can_highlight.
1749
1750 2019-06-25  Tom Tromey  <tom@tromey.com>
1751
1752         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1753         from make_visible.
1754         (tui_make_visible, tui_make_invisible): Rewrite.
1755         (tui_win_info::make_visible): Remove.
1756         (tui_source_window_base::make_visible): Update.
1757         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1758         method.  Moved from...
1759         (struct tui_win_info) <make_visible>: ...here.
1760
1761 2019-06-25  Tom Tromey  <tom@tromey.com>
1762
1763         * tui/tui-winsource.c
1764         (tui_source_window_base::do_scroll_horizontal): Remove direction
1765         parameter.
1766         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1767         direction parameter.
1768         * tui/tui-win.c (tui_win_info::forward_scroll)
1769         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1770         (tui_win_info::right_scroll): Update.
1771         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1772         direction parameter.
1773         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1774         direction parameter.
1775         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1776         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1777         Remove direction parameter.
1778         (struct tui_source_window_base, struct tui_source_window)
1779         (struct tui_disasm_window, struct tui_data_window)
1780         (struct tui_cmd_window): Update.
1781
1782 2019-06-25  Tom Tromey  <tom@tromey.com>
1783
1784         * tui/tui-winsource.h (tui_set_exec_info_content)
1785         (tui_show_exec_info_content, tui_erase_exec_info_content)
1786         (tui_clear_exec_info_content, tui_update_exec_info): Change
1787         argument to tui_source_window_base.
1788         * tui/tui-winsource.c (tui_set_exec_info_content)
1789         (tui_show_exec_info_content, tui_erase_exec_info_content)
1790         (tui_clear_exec_info_content, tui_update_exec_info): Change
1791         argument to tui_source_window_base.
1792
1793 2019-06-25  Tom Tromey  <tom@tromey.com>
1794
1795         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1796         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1797
1798 2019-06-25  Tom Tromey  <tom@tromey.com>
1799
1800         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1801         check.
1802
1803 2019-06-25  Tom Tromey  <tom@tromey.com>
1804
1805         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1806         type to void.
1807         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1808         type to void.
1809         * tui/tui-source.c (tui_set_source_content): Update.
1810         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1811
1812 2019-06-25  Tom Tromey  <tom@tromey.com>
1813
1814         * tui/tui-win.c (window_name_completer, tui_set_focus)
1815         (tui_all_windows_info): Use name method.
1816         * tui/tui-data.h (struct tui_gen_win_info)
1817         (struct tui_source_window, struct tui_disasm_window)
1818         (struct tui_data_window, struct tui_cmd_window) <name>: New
1819         method.
1820         (tui_win_name): Don't declare.
1821         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1822         (tui_win_name): Remove.
1823
1824 2019-06-25  Tom Tromey  <tom@tromey.com>
1825
1826         * tui/tui-winsource.h (tui_update_source_window)
1827         (tui_update_source_window_as_is): Change parameter type.
1828         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1829         to be a tui_source_window_base.
1830         (tui_update_source_window_as_is): Likewise.
1831         * tui/tui-win.c (make_visible_with_new_height): Update.
1832
1833 2019-06-25  Tom Tromey  <tom@tromey.com>
1834
1835         * tui/tui-winsource.c (tui_erase_source_content)
1836         (tui_show_source_content, tui_show_exec_info_content)
1837         (tui_erase_exec_info_content): Use refresh_window method.
1838         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1839         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1840         from tui_refresh_win.
1841         (tui_data_window::refresh_window): New method.
1842         (tui_win_info::refresh, tui_source_window_base::refresh)
1843         (tui_refresh_all): Use refresh_window method.
1844         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1845         method.
1846         * tui/tui-regs.c (tui_display_register): Call refresh_window
1847         method.
1848         * tui/tui-layout.c (show_source_disasm_command)
1849         (show_source_or_disasm_and_command): Call refresh_window method.
1850         * tui/tui-data.h (struct tui_gen_win_info)
1851         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1852         New method.
1853
1854 2019-06-25  Tom Tromey  <tom@tromey.com>
1855
1856         * tui/tui.c (tui_rl_other_window, tui_enable)
1857         (tui_is_window_visible, tui_get_command_dimension): Update.
1858         * tui/tui-winsource.c (tui_update_source_window_as_is)
1859         (tui_clear_source_content, tui_erase_source_content)
1860         (tui_show_source_line, tui_source_window_base::refill)
1861         (tui_source_window_base::do_scroll_horizontal)
1862         (tui_source_window_base::set_is_exec_point_at)
1863         (tui_update_breakpoint_info, tui_set_exec_info_content)
1864         (tui_alloc_source_buffer, tui_line_is_displayed)
1865         (tui_addr_is_displayed): Update.
1866         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1867         (tui_check_and_display_highlight_if_needed)
1868         (tui_win_info::make_visible, tui_win_info::refresh)
1869         (tui_refresh_all): Update.
1870         * tui/tui-windata.c (tui_first_data_item_displayed)
1871         (tui_delete_data_content_windows, tui_erase_data_content)
1872         (tui_display_all_data, tui_data_window::refresh_all)
1873         (tui_check_data_values): Update.
1874         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1875         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1876         (tui_win_info::backward_scroll, tui_refresh_all_win)
1877         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1878         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1879         (tui_source_window_base::set_new_height)
1880         (tui_data_window::set_new_height)
1881         (make_invisible_and_set_new_height)
1882         (make_visible_with_new_height, new_height_ok)
1883         (parse_scrolling_args): Update.
1884         * tui/tui-stack.c (tui_show_frame_info): Update.
1885         * tui/tui-source.c (tui_set_source_content)
1886         (tui_set_source_content_nil, tui_source_is_displayed)
1887         (tui_source_window::do_scroll_vertical): Update.
1888         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1889         (tui_display_registers_from, tui_display_reg_element_at_line)
1890         (tui_check_register_values, tui_reg_command): Update.
1891         * tui/tui-layout.c (tui_default_win_height)
1892         (show_source_disasm_command, show_data, init_and_make_win)
1893         (show_source_or_disasm_and_command): Update.
1894         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1895         (tui_redisplay_readline, tui_mld_flush)
1896         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1897         (tui_getc): Update.
1898         * tui/tui-disasm.c (tui_set_disassem_content)
1899         (tui_disasm_window::do_scroll_vertical): Update.
1900         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1901         Now virtual.
1902         (struct tui_win_info): Derive from tui_gen_win_info.
1903         <~tui_win_info>: Mark as override.
1904         <generic>: Remove member.
1905         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1906         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1907         (~tui_data_window, ~tui_win_info)
1908         (tui_free_all_source_wins_content): Update.
1909         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1910
1911 2019-06-25  Tom Tromey  <tom@tromey.com>
1912
1913         * tui/tui-layout.c (init_and_make_win): Use new.
1914         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1915         destructor, initializers.
1916         (tui_alloc_generic_win_info): Don't declare.
1917         * tui/tui-data.c (_locator): Add argument to constructor.
1918         (source_win, disasm_win): New globals.
1919         (exec_info): Remove.
1920         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1921         Update.
1922         (tui_alloc_generic_win_info): Remove.
1923         (init_content_element): Use new.
1924         (tui_win_info::tui_win_info): Update.
1925         (free_content_elements) <case DATA_WIN>: Use delete.
1926
1927 2019-06-25  Tom Tromey  <tom@tromey.com>
1928
1929         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1930         * tui/tui-windata.c (tui_first_data_item_displayed)
1931         (tui_delete_data_content_windows): Update.
1932         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1933         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1934         (tui_display_registers_from, tui_check_register_values): Update.
1935         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1936         pointer.
1937         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1938         window.
1939         (tui_free_data_content): Update.
1940         (free_content_elements) <case DATA_WIN>: Free the window.
1941
1942 2019-06-25  Tom Tromey  <tom@tromey.com>
1943
1944         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1945         Update.
1946         * tui/tui-layout.c (make_command_window)
1947         (show_source_disasm_command, show_data, init_and_make_win)
1948         (show_source_or_disasm_and_command): Update.
1949         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1950         method.
1951         <can_highight, is_highlighted>: Now bool.
1952         (tui_set_win_highlight): Don't declare.
1953         * tui/tui-data.c (tui_set_win_highlight): Remove.
1954
1955 2019-06-25  Tom Tromey  <tom@tromey.com>
1956
1957         * tui/tui-wingeneral.c (make_visible): Remove check of window
1958         type.
1959
1960 2019-06-25  Tom Tromey  <tom@tromey.com>
1961
1962         * tui/tui-win.c (tui_win_info::max_height)
1963         (tui_cmd_window::max_height): New methods.
1964         (new_height_ok): Call max_height.
1965         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1966         <max_height>: New method.
1967
1968 2019-06-25  Tom Tromey  <tom@tromey.com>
1969
1970         * tui/tui-win.c (tui_source_window_base::set_new_height)
1971         (tui_data_window::set_new_height): New methods.
1972         (make_invisible_and_set_new_height): Call set_new_height method.
1973         * tui/tui-data.h (struct tui_win_info)
1974         (struct tui_source_window_base, struct tui_data_window)
1975         <set_new_height>: New method.
1976
1977 2019-06-25  Tom Tromey  <tom@tromey.com>
1978
1979         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1980         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1981         tui_refresh_data_win.
1982         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1983         method.
1984         (tui_refresh_all_win): Call the refresh_all method.
1985         (tui_set_focus): Likewise.
1986         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1987         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1988         Likewise.
1989
1990 2019-06-25  Tom Tromey  <tom@tromey.com>
1991
1992         * tui/tui-winsource.h (tui_refill_source_window)
1993         (tui_set_is_exec_point_at): Don't declare.
1994         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1995         (tui_source_window_base::refill): Rename from
1996         tui_refill_source_window.
1997         (tui_source_window_base::do_scroll_horizontal): Update.
1998         (tui_source_window_base::set_is_exec_point_at): Rename from
1999         tui_set_is_exec_point_at.
2000         (tui_update_all_breakpoint_info): Update.
2001         * tui/tui-stack.c (tui_show_frame_info): Update.
2002         * tui/tui-layout.c (show_data): Add cast.
2003         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2004         * tui/tui-data.h (struct tui_source_window_base) <refill,
2005         set_is_exec_point_at>: New methods.
2006         (tui_source_windows, tui_add_to_source_windows): Update types.
2007         (tui_add_to_source_windows): Remove redundant declaration.
2008         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2009         (tui_source_windows): Change return type.
2010         (tui_clear_source_windows_detail): Update.
2011         (tui_add_to_source_windows): Change type of parameter.
2012         (tui_free_all_source_wins_content): Update.
2013
2014 2019-06-25  Tom Tromey  <tom@tromey.com>
2015
2016         * tui/tui-wingeneral.c (tui_win_info::refresh)
2017         (tui_source_window_base::refresh): New methods.
2018         (tui_refresh_all): Call the refresh method.
2019         * tui/tui-data.h (struct tui_win_info)
2020         (struct tui_source_window_base) <refresh>: New method.
2021
2022 2019-06-25  Tom Tromey  <tom@tromey.com>
2023
2024         * tui/tui.h (tui_is_window_visible): Return bool.
2025         * tui/tui.c (tui_is_window_visible): Return bool.
2026         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2027         (tui_make_visible, tui_make_invisible)
2028         (tui_win_info::make_visible)
2029         (tui_source_window_base::make_visible, make_all_visible)
2030         (tui_make_all_visible, tui_make_all_invisible): Update.
2031         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2032         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2033         bool.
2034         (struct tui_win_info, struct tui_source_window_base)
2035         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2036         * tui/tui-data.c (tui_init_generic_part): Update.
2037
2038 2019-06-25  Tom Tromey  <tom@tromey.com>
2039
2040         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2041         (tui_source_window_base::make_visible): New methods.
2042         (make_all_visible): Make method call.
2043         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2044         (struct tui_source_window_base, struct tui_cmd_window): Override
2045         make_visible.
2046         (tui_win_is_source_type): Don't declare.
2047         * tui/tui-data.c (tui_win_is_source_type): Remove.
2048
2049 2019-06-25  Tom Tromey  <tom@tromey.com>
2050
2051         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2052         NULL check.
2053
2054 2019-06-25  Tom Tromey  <tom@tromey.com>
2055
2056         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2057         Inline constructor.  Add initializers for members.
2058         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2059         constructors; now inline in class.
2060
2061 2019-06-25  Tom Tromey  <tom@tromey.com>
2062
2063         * tui/tui-regs.c (tui_show_registers): Update.
2064         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2065         bool.
2066         * tui/tui-data.c (tui_data_window::clear_detail)
2067         (tui_data_window): Update.
2068
2069 2019-06-25  Tom Tromey  <tom@tromey.com>
2070
2071         * tui/tui-windata.c (tui_display_all_data)
2072         (tui_display_data_from_line, tui_display_data_from)
2073         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2074         Update.
2075         * tui/tui-regs.c (tui_last_regs_line_no)
2076         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2077         (tui_show_registers, tui_show_register_group)
2078         (tui_display_registers_from, tui_display_reg_element_at_line)
2079         (tui_display_registers_from_line, tui_check_register_values)
2080         (tui_reg_next, tui_reg_prev): Update.
2081         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2082         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2083         tui_data_window.
2084         (struct tui_win_info) <detail>: Remove.  Add new fields from
2085         tui_data_info.
2086         (TUI_DATA_WIN): Add cast.
2087         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2088         (~tui_data_window): Simplify.
2089
2090 2019-06-25  Tom Tromey  <tom@tromey.com>
2091
2092         * tui/tui-layout.c (show_source_disasm_command)
2093         (show_source_or_disasm_and_command): Update.
2094         * tui/tui-io.c (update_cmdwin_start_line)
2095         (tui_redisplay_readline): Update.
2096         * tui/tui-data.h (struct tui_command_info): Remove.
2097         (struct tui_win_info) <detail>: Remove command_info member.
2098         (struct tui_data_window) <start_line>: New member, from
2099         tui_command_info.
2100         (TUI_CMD_WIN): Add casts.
2101
2102 2019-06-25  Tom Tromey  <tom@tromey.com>
2103
2104         * tui/tui-winsource.c (tui_update_source_window)
2105         (tui_refill_source_window)
2106         (tui_source_window_base::do_scroll_horizontal)
2107         (tui_update_breakpoint_info, tui_set_exec_info_content)
2108         (tui_show_exec_info_content, tui_erase_exec_info_content)
2109         (tui_clear_exec_info_content): Update.
2110         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2111         Update.
2112         * tui/tui-win.c (make_invisible_and_set_new_height)
2113         (make_visible_with_new_height): Update.
2114         * tui/tui-source.c (tui_set_source_content)
2115         (tui_show_symtab_source): Update.
2116         * tui/tui-layout.c (extract_display_start_addr)
2117         (show_source_disasm_command, show_data)
2118         (make_source_or_disasm_window)
2119         (show_source_or_disasm_and_command): Update.
2120         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2121         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2122         "gdbarch".
2123         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2124         to tui_source_window_base.
2125         (struct tui_win_info) <detail>: Remove source_info member.
2126         (struct tui_source_window_base) <has_locator>: Inline.
2127         Move contents from tui_source_info; rename has_locator member to
2128         m_has_locator.
2129         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2130         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2131         header file.
2132         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2133         Simplify.
2134         (tui_free_all_source_wins_content): Cast to
2135         tui_source_window_base.
2136
2137 2019-06-25  Tom Tromey  <tom@tromey.com>
2138
2139         * tui/tui-win.c (make_invisible_and_set_new_height)
2140         (make_visible_with_new_height): Call has_locator method.
2141         * tui/tui-layout.c (show_source_disasm_command, show_data)
2142         (show_source_or_disasm_and_command): Update for bool change.
2143         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2144         (tui_win_info) <has_locator>: New method.
2145         (struct tui_source_window_base) <has_locator>: New method.
2146         (tui_win_has_locator): Don't declare.
2147         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2148         from tui_win_has_locator.
2149         (tui_source_window_base): Use false, not FALSE.
2150
2151 2019-06-25  Tom Tromey  <tom@tromey.com>
2152
2153         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2154         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2155         clear_detail method directly.
2156         (tui_clear_win_detail): Remove.
2157
2158 2019-06-25  Tom Tromey  <tom@tromey.com>
2159
2160         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2161         "this", not TUI_DISASM_WIN.
2162
2163 2019-06-25  Tom Tromey  <tom@tromey.com>
2164
2165         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2166         declare.
2167         * tui/tui-winsource.c
2168         (tui_source_window_base::do_scroll_horizontal): Rename from
2169         tui_horizontal_source_scroll.
2170         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2171         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2172         from tui_vertical_data_scroll.
2173         * tui/tui-win.h (tui_scroll): Don't declare.
2174         * tui/tui-win.c (tui_win_info::forward_scroll)
2175         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2176         (tui_win_info::right_scroll): Rename and update.
2177         (tui_scroll_forward_command, tui_scroll_backward_command)
2178         (tui_scroll_left_command, tui_scroll_right_command): Update.
2179         (tui_scroll): Remove.
2180         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2181         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2182         from tui_vertical_source_scroll.
2183         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2184         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2185         from tui_vertical_disassem_scroll.
2186         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2187         do_scroll_horizontal>: New methods.
2188         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2189         Likewise.
2190         (struct tui_source_window_base): Add do_scroll_horizontal.
2191         (struct tui_source_window, struct tui_disasm_window): Add
2192         do_scroll_vertical.
2193         (struct tui_data_window, struct tui_cmd_window): Add
2194         do_scroll_horizontal and do_scroll_vertical.
2195         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2196
2197 2019-06-25  Tom Tromey  <tom@tromey.com>
2198
2199         * tui/tui-data.h (struct tui_source_window_base): New struct.
2200         (struct tui_source_window): Derive from tui_source_window_base.
2201         (struct tui_disasm_window): New struct.
2202         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2203         from tui_source_window::clear_detail.
2204         (tui_source_window_base): Rename from tui_source_window.
2205         (~tui_source_window_base): Rename from ~tui_source_window.
2206         (tui_alloc_win_info): Create a tui_disasm_window.
2207
2208 2019-06-25  Tom Tromey  <tom@tromey.com>
2209
2210         * tui/tui-data.h (struct tui_source_window)
2211         (struct tui_data_window): Declare destructors.
2212         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2213         destructors.
2214         (tui_win_info): Simplify.
2215
2216 2019-06-25  Tom Tromey  <tom@tromey.com>
2217
2218         * tui/tui-winsource.c (tui_display_main)
2219         (tui_update_source_windows_with_addr)
2220         (tui_update_all_breakpoint_info): Update.
2221         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2222         (new_height_ok, parse_scrolling_args): Update.
2223         * tui/tui-stack.c (tui_show_frame_info): Update.
2224         * tui/tui-data.h (struct tui_list): Remove.
2225         (tui_source_windows): Return a reference to a std::vector.
2226         * tui/tui-data.c (source_windows): Now a std::vector.
2227         (tui_source_windows): Change return type.
2228         (tui_clear_source_windows): Rewrite.
2229         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2230         (tui_free_all_source_wins_content): Rewrite.
2231
2232 2019-06-25  Tom Tromey  <tom@tromey.com>
2233
2234         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2235         (struct tui_data_window, struct tui_cmd_window): Declare
2236         clear_detail method.
2237         * tui/tui-data.c (tui_source_window::clear_detail)
2238         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2239         methods.
2240         (tui_clear_win_detail): Simplify.
2241
2242 2019-06-25  Tom Tromey  <tom@tromey.com>
2243
2244         * tui/tui-layout.c (make_source_window, make_disasm_window)
2245         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2246         Return the new window.
2247         (show_source_disasm_command, show_data)
2248         (show_source_or_disasm_and_command): Update.
2249
2250 2019-06-25  Tom Tromey  <tom@tromey.com>
2251
2252         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2253         parameter.  Return the new window.
2254         (show_source_disasm_command): Update and remove NULL check.
2255         (show_source_or_disasm_and_command): Update.
2256
2257 2019-06-25  Tom Tromey  <tom@tromey.com>
2258
2259         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2260
2261 2019-06-25  Tom Tromey  <tom@tromey.com>
2262
2263         * tui/tui-data.h (struct tui_win_info): Make constructor
2264         protected.  Make destructor virtual.  Add initializers.
2265         (tui_source_window, tui_data_window, tui_cmd_window): New
2266         classes.
2267         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2268         constructor.  Add "type" parameter.
2269         (tui_source_window, tui_data_window, tui_cmd_window): New
2270         constructors.
2271         (tui_alloc_win_info): Instantiate the appropriate subclass.
2272
2273 2019-06-25  Tom Tromey  <tom@tromey.com>
2274
2275         * tui/tui-win.c (tui_resize_all): Use delete.
2276         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2277         destructor.
2278         (tui_free_window): Don't declare.
2279         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2280         Update.
2281
2282 2019-06-25  Tom Tromey  <tom@tromey.com>
2283
2284         * tui/tui-data.h (struct tui_win_info): Add constructor.
2285         * tui/tui-data.c (tui_alloc_win_info): Use new.
2286         (tui_free_window): Use delete.
2287
2288 2019-06-22  Tom Tromey  <tom@tromey.com>
2289
2290         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2291         declare.
2292         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2293
2294 2019-06-22  Tom Tromey  <tom@tromey.com>
2295
2296         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2297         declare.
2298         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2299
2300 2019-06-22  Tom de Vries  <tdevries@suse.de>
2301
2302         * dwarf2read.c (create_addrmap_from_aranges)
2303         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2304         instead of '%zu'.
2305
2306 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2307
2308         * dwarf2read.h (dwarf2_section_info_def): Remove.
2309         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2310         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2311         std::vector<dwarf2_section_info>.
2312         (struct dwo_file) <~dwo_file>: Remove.
2313         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2314         types field.
2315         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2316         (dwarf2_read_debug_names): Likewise.
2317         (create_debug_types_hash_table): Change parameter type to
2318         array_view, adjust code accordingly.
2319         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2320         (partial_die_info::fixup): Likewise.
2321         (determine_prefix): Likewise.
2322         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2323
2324 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2325
2326         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2327         gdb_bfd_ref_ptr.
2328         <~dwo_file>: Remove call to gdb_bfd_unref.
2329         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2330         gdb_bfd_ref_ptr::get.
2331
2332 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2333
2334         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2335         type to htab_up.
2336         * dwarf2read.c (struct dwo_file): Initialize fields.
2337         <~dwo_file>: New.
2338         (free_dwo_file): Remove, move content to ~dwo_file.
2339         (struct dwo_file_deleter): Remove.
2340         (dwo_file_up>: Remove custom deleter.
2341         (free_dwo_files): Remove.
2342         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2343         dwo_files.
2344         (process_skeletonless_type_units): Call unique_ptr::get.
2345         (allocate_dwo_file_hash_table): Add deleter to created hash
2346         table.  Change return type to htab_up.
2347         (lookup_dwo_file_slot): Don't memset dwo_file, call
2348         unique_ptr::get.
2349         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2350         (create_dwo_unit_in_dwp_v2): Likewise.
2351         (open_and_init_dwo_file): Likewise.
2352         (free_dwo_file_from_slot): Remove.
2353
2354 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2355
2356         * dwarf2read.h (struct dwarf2_section_info) <readin,
2357         is_virtual>: Change type to bool.
2358         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2359         true instead of 1.
2360
2361 2019-06-19  Tom Tromey  <tom@tromey.com>
2362
2363         * tui/tui-data.h (tui_init_content_element): Don't declare.
2364
2365 2019-06-19  Tom Tromey  <tom@tromey.com>
2366
2367         * tui/tui-data.h (tui_init_win_info): Don't declare.
2368
2369 2019-06-19  Tom de Vries  <tdevries@suse.de>
2370
2371         * dwarf2read.h (abstract_to_concrete): Change type to
2372         std::unordered_map<sect_offset, std::vector<sect_offset>,
2373         gdb::hash_enum<sect_offset>>.
2374
2375 2019-06-19  Tom Tromey  <tromey@adacore.com>
2376
2377         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2378         EVAL_AVOID_SIDE_EFFECTS specially.
2379
2380 2019-06-19  Tom Tromey  <tromey@adacore.com>
2381
2382         * source-cache.c (highlighter): New global.
2383         (source_cache::get_source_lines): Create a highlighter on demand.
2384
2385 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2386
2387         * defs.h (deprecated_interactive_hook): Delete declaration.
2388         * interps.c (clear_interpreter_hooks): Remove use of
2389         deprecated_interactive_hook.
2390         * top.c (deprecated_interactive_hook): Delete definition.
2391         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2392
2393 2019-06-18  Tom de Vries  <tdevries@suse.de>
2394
2395         PR gdb/24515
2396         * dwarf2read.h (abstract_to_concrete): Change type from
2397         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2398         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2399         * dwarf2read.c (read_variable): Update.
2400         (dwarf2_fetch_die_loc_sect_off): Update.
2401
2402 2019-06-17  Tom de Vries  <tdevries@suse.de>
2403
2404         PR gdb/24617
2405         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2406         accessing parent[parent_len - 1].
2407
2408 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2409
2410         PR gdb/24364
2411         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2412         call dtrace_process_dof with NULL dof.
2413
2414 2019-06-16  Tom de Vries  <tdevries@suse.de>
2415
2416         PR gdb/24445
2417         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2418
2419 2019-06-16  Tom Tromey  <tom@tromey.com>
2420
2421         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2422         (make_all_visible): Use address of member.
2423
2424 2019-06-16  Tom Tromey  <tom@tromey.com>
2425
2426         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2427         (tui_free_window, free_content, free_content_elements): Remove
2428         unnecessary cast.
2429         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2430         cast.
2431         * tui/tui-regs.c (tui_show_register_group)
2432         (tui_display_registers_from, tui_display_reg_element_at_line):
2433         Remove unnecessary cast.
2434
2435 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2436
2437         * linux-nat.c (normal_mask): Delete.
2438         (_initialize_linux_nat): Don't initialise normal_mask.
2439
2440 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2441
2442         PR gdb/24445
2443         * dwarf-index-write.h (write_psymtabs_to_index): Add
2444         dwz_basename parameter.
2445         * dwarf-index-write.c (write_gdbindex): Move file writing to
2446         write_gdbindex_1.  Change return type void.
2447         (assert_file_size): Move up, remove filename parameter.
2448         (write_gdbindex_1): New function.
2449         (write_debug_names): Change return type to void, call
2450         assert_file_size.
2451         (struct index_wip_file): New struct.
2452         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2453         file logic to index_wip_file.  Write index for dwz file if
2454         needed.
2455         (save_gdb_index_command): Pass basename of dwz file, if present.
2456         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2457         build-id of dwz file, if present.
2458         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2459         (dwarf2_get_dwz_file): Likewise.
2460         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2461         (dwarf2_get_dwz_file): Likewise.
2462
2463 2019-06-16  Tom Tromey  <tom@tromey.com>
2464
2465         * coffread.c (process_coff_symbol): Use xstrdup.
2466         * value.c (create_internalvar): Use xstrdup.
2467
2468 2019-06-16  Tom Tromey  <tom@tromey.com>
2469
2470         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2471         * breakpoint.c (stopin_command, stopat_command)
2472         (until_break_command, decode_location_default): Remove unnecessary
2473         cast.
2474         * utils.c (subset_compare): Remove unnecessary cast.
2475         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2476         cast.
2477         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2478         cast.
2479         * infcmd.c (path_command): Remove unnecessary cast.
2480         * coffread.c (decode_type): Remove unnecessary cast.
2481         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2482         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2483         * tui/tui-stack.c (tui_show_locator_content)
2484         (tui_show_frame_info): Remove unnecessary cast.
2485         * tui/tui-win.c (tui_scroll_forward_command)
2486         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2487         (parse_scrolling_args): Remove unnecessary cast.
2488         * tui/tui-data.c (init_win_info, tui_del_window)
2489         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2490         (free_content_elements): Remove unnecessary cast.
2491         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2492         unnecessary cast.
2493         * tui/tui-source.c (tui_set_source_content)
2494         (tui_vertical_source_scroll): Remove unnecessary cast.
2495         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2496         cast.
2497         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2498         * tui/tui-regs.c (tui_display_registers_from)
2499         (tui_display_register): Remove unnecessary cast.
2500         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2501         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2502         (make_visible): Remove unnecessary cast.
2503         * tui/tui-winsource.c (tui_erase_source_content)
2504         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2505         unnecessary cast.
2506         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2507         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2508         * stabsread.c (read_type, read_array_type, read_range_type):
2509         Remove unnecessary cast.
2510         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2511         (parse_symbol, parse_type, upgrade_type, parse_external)
2512         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2513         unnecessary cast.
2514         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2515
2516 2019-06-16  Tom Tromey  <tom@tromey.com>
2517
2518         * tui/tui-data.c (tui_alloc_generic_win_info)
2519         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2520         checks.
2521
2522 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2523             Andrew Burgess  <andrew.burgess@embecosm.com>
2524
2525         * f-typeprint.c (f_print_type): Don't return early for not
2526         associated or not allocated types.
2527         (f_type_print_varspec_suffix): Add print_rank parameter and print
2528         ranks of array types in case they dangling.
2529         (f_type_print_base): Add print_rank parameter.
2530
2531 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2532
2533         * NEWS: Mention new MI commands.
2534         * break-catch-throw.c (enum exception_event_kind): Move to
2535         breakpoint.h.
2536         (print_mention_exception_catchpoint): Output text as a single
2537         message.
2538         (catch_exception_command_1): Rename to...
2539         (catch_exception_event): ...this, make non-static, update header
2540         command, and change some parameter types.
2541         (catch_catch_command): Update for changes to
2542         catch_exception_command_1.
2543         (catch_throw_command): Likewise.
2544         (catch_rethrow_command): Likewise.
2545         * breakpoint.c (enum exception_event_kind): Delete.
2546         * breakpoint.h (enum exception_event_kind): Moved here from
2547         break-catch-throw.c.
2548         (catch_exception_event): Declare.
2549         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2550         (mi_cmd_catch_throw): New function.
2551         (mi_cmd_catch_rethrow): New function.
2552         (mi_cmd_catch_catch): New function.
2553         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2554         'catch-catch' entries.
2555         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2556         (mi_cmd_catch_rethrow): Declare.
2557         (mi_cmd_catch_catch): Declare.
2558
2559 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2560
2561         * annotate.c (annotate_source_line): Change return type to void,
2562         update implementation to match.
2563         * annotate.h (annotate_source_line): Change return type to void,
2564         update header comment.
2565         * stack.c (print_frame_info): Don't change what frame information
2566         is printed based on whether annotations are on or not.
2567
2568 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2569
2570         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2571         (annotate_source): Make static.
2572         (annotate_source_line): Moved from source.c and renamed from
2573         identify_source_line.  Update the return type.
2574         * annotate.h (annotate_source): Delete declaration.
2575         (annotate_source_line): Declaration moved from source.h, and
2576         renamed from identify_source_line.  Return type updated.
2577         * source.c (identify_source_line): Moved to annotate.c and renamed
2578         to annotate_source_line.
2579         (info_line_command): Remove check of annotation_level.
2580         * source.h (identify_source_line): Move declaration to annotate.h
2581         and rename to annotate_source_line.
2582         * stack.c: Add 'annotate.h' include.
2583         (print_frame_info): Remove check of annotation_level before
2584         calling annotate_source_line.
2585
2586 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2587
2588         * source-cache.c (source_cache::get_plain_source_lines): Use
2589         open_source_file_with_line_charpos instead of just
2590         open_source_file, remove call to find_source_lines.
2591         (source_cache::get_source_lines): Likewise.
2592         * source.c (find_source_lines): Make static.
2593         (get_filename_and_charpos): Renamed into...
2594         (open_source_file_with_line_charpos): ..this along with changes to
2595         return a scoped_fd, and some other minor clean ups.
2596         (identify_source_line): Use open_source_file_with_line_charpos.
2597         (search_command_helper): Use open_source_file_with_line_charpos
2598         instead of just open_source_file, remove call to
2599         find_source_lines.
2600         * source.h (open_source_file_with_line_charpos): Declare new
2601         function.
2602         (find_source_lines): Delete declaration.
2603
2604 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2605
2606         * source.c (get_filename_and_charpos): Remove fullname
2607         parameter.
2608         (identify_source_line): Update call to get_filename_and_charpos.
2609
2610 2019-06-14  Tom Tromey  <tromey@adacore.com>
2611
2612         PR gdb/24502:
2613         * ui-style.h (skip_ansi_escape): Update comment.
2614         * ui-file.h (class no_terminal_escape_file): New class.
2615         * ui-file.c (no_terminal_escape_file::write)
2616         (no_terminal_escape_file::puts): New methods.
2617         * cli/cli-logging.c (handle_redirections): Use
2618         no_terminal_escape_file.
2619
2620 2019-06-14  Tom Tromey  <tromey@adacore.com>
2621
2622         * NEWS: Move convenience variable news above Python news.
2623
2624 2019-06-14  Tom Tromey  <tom@tromey.com>
2625
2626         * gnulib: Move directory to top-level.
2627         * configure.ac: Don't configure gnulib.
2628         * configure: Rebuild.
2629         * common/common-defs.h: Use new path to gnulib.
2630         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2631         (GNULIB_H): Remove.
2632         (INCGNU): Look in new gnulib location.
2633         (HFILES_NO_SRCDIR): Remove gnulib files.
2634         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2635         (generated_files): Remove GNULIB_H.
2636         ($(LIBGNU), all-lib): Remove targets.
2637         (distclean): Don't mention GNULIB_BUILDDIR.
2638         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2639
2640 2019-06-14  Tom Tromey  <tromey@adacore.com>
2641
2642         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2643         Warn if symbol file does not provide any symbols.
2644
2645 2019-06-14  Tom Tromey  <tromey@adacore.com>
2646
2647         * source.c (find_and_open_source): Respect basenames_may_differ.
2648
2649 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2650
2651         * annotate.c (annotate_breakpoints_invalid): Make use of
2652         scoped_restore_terminal_state.
2653         (annotate_frames_invalid): Likewise.
2654
2655 2019-06-14  Tom Tromey  <tromey@adacore.com>
2656
2657         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2658         allow assignment to an internalvar.
2659
2660 2019-06-14  Tom Tromey  <tromey@adacore.com>
2661
2662         * ada-lex.l: Allow "_" in attribute names.
2663
2664 2019-06-14  Tom Tromey  <tromey@adacore.com>
2665
2666         PR gdb/24653:
2667         * regcache.c (registers_changed): Don't call alloca.
2668         * top.c (execute_command): Don't call alloca.
2669
2670 2019-06-13  Pedro Alves  <palves@redhat.com>
2671
2672         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2673         'expression'.  When parsing an expression, error out if there's
2674         junk after "unlimited".
2675         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2676         (do_set_command): Adjust calls to is_unlimited_literal.
2677
2678 2019-06-13  Pedro Alves  <palves@redhat.com>
2679
2680         * compile/compile.c (make_compile_options_def_group): Add braces
2681         around array_view initializer.
2682         * thread.c (make_thread_apply_all_options_def_group)
2683         (make_thread_apply_all_options_def_group): Likewise.
2684
2685 2019-06-13  Pedro Alves  <palves@redhat.com>
2686
2687         * NEWS (New commands): Mention "maint test-options
2688         require-delimiter", "maint test-options unknown-is-error", "maint
2689         test-options unknown-is-operand" and "maint show
2690         test-options-completion-result".
2691         (New command options, command completion): New section.
2692         (Completion improvements): New section.
2693         Mention that you can abbreviate "unlimited".
2694
2695 2019-06-13  Pedro Alves  <palves@redhat.com>
2696
2697         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2698         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2699         * unittests/cli-utils-selftests.c (test_parse_flags)
2700         (test_parse_flags_qcs): Delete.
2701         (test_cli_utils): Don't call deleted functions.
2702
2703 2019-06-13  Pedro Alves  <palves@redhat.com>
2704
2705         * thread.c: Include "cli/cli-option.h".
2706         (tp_array_compar_ascending): Global.
2707         (tp_array_compar): Delete function.
2708         (tp_array_compar_ascending, tp_array_compar_descending): New
2709         functions.
2710         (ascending_option_def, qcs_flag_option_def)
2711         (thr_qcs_flags_option_defs)
2712         (make_thread_apply_all_options_def_group)
2713         (make_thread_apply_options_def_group): New.
2714         (thread_apply_all_command): Use gdb::option::process_options.
2715         (thread_apply_command_completer)
2716         (thread_apply_all_command_completer): New.
2717         (thread_apply_command): Use gdb::option::process_options.
2718         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2719         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2720         to generate help text of "thread apply".  Adjust "taas"'s help.
2721         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2722         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2723
2724 2019-06-13  Pedro Alves  <palves@redhat.com>
2725
2726         * thread.c (thread_apply_command): Check for invalid TID with
2727         isdigit instead of !isalpha.
2728
2729 2019-06-13  Pedro Alves  <palves@redhat.com>
2730
2731         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2732         (validate_flags_qcs): New.
2733         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2734         (validate_flags_qcs): Declare.
2735         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2736         (make_frame_apply_options_def_group): New.
2737         (frame_apply_command_count): Process options with
2738         gdb::option::process_options.
2739         (frame_apply_completer): New.
2740         (frame_apply_level_completer, frame_apply_all_completer)
2741         (frame_apply_completer): New.
2742         (_initialize_stack): Update help of "frame apply", "frame apply
2743         level", "frame apply all" and "faas" to mention supported options
2744         and install command completers.
2745         * stack.h (frame_apply_all_completer): Declare.
2746         * thread.c: Include "stack.h".
2747         (tfaas_command): Add "--".
2748         (_initialize_thread): Update help "tfaas" to mention supported
2749         options and install command completer.
2750
2751 2019-06-13  Pedro Alves  <palves@redhat.com>
2752
2753         * completer.c (complete_nested_command_line): New.
2754         (gdb_completion_word_break_characters_throw): Add assertion.
2755         * completer.h (complete_nested_command_line): Declare.
2756
2757 2019-06-13  Pedro Alves  <palves@redhat.com>
2758
2759         * stack.c (parse_backtrace_qualifiers): New.
2760         (backtrace_command): Use it.
2761         (backtrace_command_completer): Complete on qualifiers.
2762
2763 2019-06-13  Pedro Alves  <palves@redhat.com>
2764
2765         * frame.c: Include "cli/cli-option.h.
2766         (user_set_backtrace_options): New.
2767         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2768         Delete.
2769         (get_prev_frame): Adjust.
2770         (boolean_option_def, uinteger_option_def)
2771         (set_backtrace_option_defs): New.
2772         (_initialize_frame): Adjust and use
2773         gdb::option::add_setshow_cmds_for_options to install "set
2774         backtrace past-main" and "set backtrace past-entry".
2775         * frame.h: Include "cli/cli-option.h".
2776         (struct frame_print_options): Forward declare.
2777         (print_frame_arguments_all, print_frame_arguments_scalars)
2778         (print_frame_arguments_none): Declare.
2779         (print_entry_values): Delete declaration.
2780         (struct frame_print_options, user_frame_print_options): New.
2781         (struct set_backtrace_options): New.
2782         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2783         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2784         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2785         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2786         (list_args_or_locals): Add frame_print_options parameter.
2787         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2788         * python/py-framefilter.c (enumerate_args): Pass down
2789         USER_FRAME_PRINT_OPTIONS.
2790         * stack.c: Include "cli/cli-option.h".
2791         (print_frame_arguments_all, print_frame_arguments_scalars)
2792         (print_frame_arguments_none): Declare.
2793         (print_raw_frame_arguments, print_entry_values): Delete.
2794         (user_frame_print_options): New.
2795         (boolean_option_def, enum_option_def, frame_print_option_defs):
2796         New.
2797         (struct backtrace_cmd_options): New.
2798         (bt_flag_option_def): New.
2799         (backtrace_command_option_defs): New.
2800         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2801         (print_frame_arg, read_frame_arg, print_frame_args)
2802         (print_frame_info, print_frame): Add frame_print_options parameter
2803         and use it.
2804         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2805         (backtrace_command_1): Add frame_print_options and
2806         backtrace_cmd_options parameters and use them.
2807         (make_backtrace_options_def_group): New.
2808         (backtrace_command): Process command options with
2809         gdb::option::process_options.
2810         (backtrace_command_completer): New.
2811         (_initialize_stack): Extend "backtrace"'s help to mention
2812         supported options.  Install completer for "backtrace".
2813         Install some settings commands with add_setshow_cmds_for_options.
2814
2815 2019-06-13  Pedro Alves  <palves@redhat.com>
2816
2817         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2818         and that "set/show print raw frame-arguments" are now deprecated.
2819
2820         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2821         command.
2822         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2823         * stack.c (_initialize_stack): Install "set/show print
2824         raw-frame-arguments", and deprecate "set/show print raw
2825         frame-arguments".
2826         * valprint.c (_initialize_valprint): Deprecate "set/show print
2827         raw".
2828
2829 2019-06-13  Pedro Alves  <palves@redhat.com>
2830
2831         * compile/compile.c (struct compile_options): New.
2832         (compile_flag_option_def, compile_command_option_defs)
2833         (make_compile_options_def_group): New.
2834         (compile_file_command): Handle options with
2835         gdb::option::process_options.
2836         (compile_file_command_completer): New function.
2837         (compile_code_command): Handle options with
2838         gdb::option::process_options.
2839         (compile_code_command_completer): New function.
2840         (_initialize_compiler): Install completers for "compile code" and
2841         "compile file".  Mention available options in "compile code" and
2842         "compile code"'s help.
2843         * completer.c (advance_to_completion_word): New, factored out from
2844         ...
2845         (advance_to_expression_complete_word_point): ... this.
2846         (advance_to_filename_complete_word_point): New.
2847         * completer.h (advance_to_filename_complete_word_point): New
2848         declaration.
2849
2850 2019-06-13  Pedro Alves  <palves@redhat.com>
2851
2852         * compile/compile.c: Include "cli/cli-option.h".
2853         (compile_print_value): Scope data pointer is now a
2854         value_print_options pointer; adjust.
2855         (compile_print_command): Process options.  Scope data pointer is
2856         now a value_print_options pointer; adjust.
2857         (_initialize_compile): Update "compile print"'s help to include
2858         supported options.  Install a completer for "compile print".
2859         * cp-valprint.c (show_vtblprint, show_objectprint)
2860         (show_static_field_print): Delete.
2861         (_initialize_cp_valprint): Don't install "set print
2862         static-members", "set print vtbl", "set print object" here.
2863         * printcmd.c: Include "cli/cli-option.h" and
2864         "common/gdb_optional.h".
2865         (print_command_parse_format): Rework to fill in a
2866         value_print_options instead of a format_data.
2867         (print_value): Change parameter type from format_data pointer to
2868         value_print_options reference.  Adjust.
2869         (print_command_1): Process options.  Adjust to pass down a
2870         value_print_options.
2871         (print_command_completer): New.
2872         (_initialize_printcmd): Install print_command_completer as
2873         handle_brkchars completer for the "print" command.  Update
2874         "print"'s help to include supported options.
2875         * valprint.c: Include "cli/cli-option.h".
2876         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2877         here from cp-valprint.c.
2878         (boolean_option_def, uinteger_option_def)
2879         (value_print_option_defs, make_value_print_options_def_group):
2880         New.  Use gdb::option::add_setshow_cmds_for_options to install
2881         "set print elements", "set print null-stop", "set print repeats",
2882         "set print pretty", "set print union", "set print array", "set
2883         print address", "set print symbol", "set print array-indexes".
2884         * valprint.h: Include <string> and "cli/cli-option.h".
2885         (make_value_print_options_def_group): Declare.
2886         (print_value): Change parameter type from format_data pointer to
2887         value_print_options reference.
2888         (print_command_completer): Declare.
2889
2890 2019-06-13  Pedro Alves  <palves@redhat.com>
2891
2892         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2893         (COMMON_SFILES): Add maint-test-settings.c.
2894         * cli/cli-decode.c (boolean_enums): New global, factored out from
2895         ...
2896         (add_setshow_boolean_cmd): ... here.
2897         * cli/cli-decode.h (boolean_enums): Declare.
2898         * cli/cli-option.c: New file.
2899         * cli/cli-option.h: New file.
2900         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2901         factored out from ...
2902         (parse_cli_boolean_value(const char *)): ... this.
2903         (is_unlimited_literal): Change parameter type to pointer to
2904         pointer.  Adjust and advance ARG pointer.
2905         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2906         (parse_cli_var_enum): New, factored out from ...
2907         (do_set_command): ... this.  Adjust.
2908         * cli/cli-setshow.h (parse_cli_boolean_value)
2909         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2910         (parse_cli_var_enum): Declare.
2911         * cli/cli-utils.c: Include "cli/cli-option.h".
2912         (get_ulongest): New.
2913         * cli/cli-utils.h (get_ulongest): Declare.
2914         (check_for_argument): New overloads.
2915         * maint-test-options.c: New file.
2916
2917 2019-06-13  Pedro Alves  <palves@redhat.com>
2918
2919         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2920         parse a range if "-" is at the end of the string.
2921
2922 2019-06-13  Pedro Alves  <palves@redhat.com>
2923
2924         * cli/cli-setshow.c (parse_auto_binary_operation)
2925         (parse_cli_boolean_value): Don't allow "o".
2926
2927 2019-06-13  Pedro Alves  <palves@redhat.com>
2928
2929         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2930         * NEWS: Mention maint test-settings KIND.
2931         * maint-test-settings.c: New file.
2932
2933 2019-06-13  Pedro Alves  <palves@redhat.com>
2934
2935         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2936         completer.
2937         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2938         "set" completers.
2939
2940 2019-06-13  Pedro Alves  <palves@redhat.com>
2941
2942         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2943         after item.
2944
2945 2019-06-13  Pedro Alves  <palves@redhat.com>
2946
2947         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2948
2949 2019-06-13  Pedro Alves <palves@redhat.com>
2950
2951         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2952         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2953         call.
2954         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2955         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2956         calls.
2957         (check_for_argument): Skip spaces after argument.
2958
2959 2019-06-13  Pedro Alves  <palves@redhat.com>
2960
2961         * thread.c (thread_apply_command): Adjust TID parsing.
2962         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2963         detected before end of string.
2964         (tid_is_in_list): Error out if LIST is invalid.
2965
2966 2019-06-13  Pedro Alves  <palves@redhat.com>
2967
2968         * completer.c (complete_line_internal_1): Rewind completion word
2969         point.
2970         (completion_tracker::advance_custom_word_point_by): Change
2971         parameter type to int.
2972         * completer.h (completion_tracker::advance_custom_word_point_by):
2973         Likewise.
2974
2975 2019-06-13  Pedro Alves  <palves@redhat.com>
2976
2977         * completer.c (advance_to_completion_word): Handle delimiters.
2978
2979 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2980
2981         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2982
2983 2019-06-11  Tom Tromey  <tom@tromey.com>
2984
2985         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2986         (xmalloc_failed): Move to alloc.c.
2987         * alloc.c: New file.
2988         * Makefile.in (COMMON_SFILES): Add alloc.c.
2989
2990 2019-06-11  Tom Tromey  <tom@tromey.com>
2991
2992         * nat/linux-waitpid.c: Don't include server.h.
2993         (linux_debug): Remove.
2994         (my_waitpid): Update.
2995
2996 2019-06-11  Tom Tromey  <tromey@adacore.com>
2997
2998         * infcall.c (_initialize_infcall): Remove trailing newline from
2999         help.
3000         * user-regs.c (_initialize_user_regs): Remove trailing newline
3001         from help.
3002         * typeprint.c (_initialize_typeprint): Remove trailing newline
3003         from help.
3004         * reverse.c (_initialize_reverse): Remove trailing newlines from
3005         help.
3006         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3007         from help.
3008         * language.c (add_set_language_command): Remove trailing newline
3009         from help.
3010         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3011         help.
3012         * disasm.c (_initialize_disasm): Remove trailing newline from
3013         help.
3014         * top.c (init_main): Remove trailing newline from help.
3015         * interps.c (_initialize_interpreter): Remove trailing newline
3016         from help.
3017         * btrace.c (_initialize_btrace): Remove trailing newlines from
3018         help.
3019         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3020         from help.
3021         * python/python.c (_initialize_python): Remove trailing newline
3022         from help.
3023         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3024         help.
3025         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3026         from help.  Reformat some text.
3027         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3028         from help.
3029         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3030         newline from help.
3031
3032 2019-06-11  Tom Tromey  <tromey@adacore.com>
3033
3034         * darwin-nat.c (darwin_decode_exception_message)
3035         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3036
3037 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3038
3039         * valops.c (value_slice): Check for not allocated or not
3040         associated values.
3041
3042 2019-06-10  Tom de Vries  <tdevries@suse.de>
3043
3044         PR gdb/24618
3045         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3046         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3047         invalid.
3048
3049 2019-06-10  Tom de Vries  <tdevries@suse.de>
3050
3051         PR gdb/24611
3052         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3053         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3054
3055 2019-06-10  Tom de Vries  <tdevries@suse.de>
3056
3057         PR symtab/24545
3058         * symtab.c (struct demangled_name_entry): Add language field.
3059         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3060         static minimal symbol".  Set and use language field.
3061
3062 2019-06-10  Tom Tromey  <tromey@adacore.com>
3063
3064         * ada-lang.c (_initialize_ada_language): Update help text.
3065
3066 2019-06-10  Tom Tromey  <tromey@adacore.com>
3067
3068         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3069         with a newline.
3070         * guile/guile.c (handle_boot_error): Don't end warning with a
3071         newline.
3072         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3073         warning with a newline.
3074         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3075         newline.
3076         (s12z_frame_cache): Likewise.
3077         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3078         a newline.
3079         * solib-svr4.c (disable_probes_interface): Don't end warning with
3080         a newline.
3081         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3082         newline.
3083         * python/python.c (do_finish_initialization): Don't end warning
3084         with a newline.
3085
3086 2019-06-10  Tom Tromey  <tom@tromey.com>
3087
3088         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3089         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3090         gdbpy_enter.
3091
3092 2019-06-10  Tom Tromey  <tromey@adacore.com>
3093
3094         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3095         data.
3096         (elf_new_init): Don't call stabsread_new_init.
3097         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3098         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3099         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3100
3101 2019-06-10  Tom de Vries  <tdevries@suse.de>
3102
3103         PR symtab/16264
3104         PR symtab/24517
3105         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3106
3107 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3108
3109         * source.c (find_and_open_source): Also rewrite relative file
3110         names.
3111
3112 2019-04-26  Amos Bird  <amosbird@gmail.com>
3113
3114         * annotate.c (annotate_thread_exited): Add "thread-exited"
3115         annotation.
3116
3117 2019-06-06  Tom Tromey  <tromey@adacore.com>
3118
3119         * maint.h (class scoped_command_stats): Use
3120         DISABLE_COPY_AND_ASSIGN.
3121         <print_time>: New method.
3122         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3123         print_time.
3124         (scoped_command_stats::print_time): New method.
3125
3126 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3127
3128         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3129         instructions of lengths 6 or 8 bytes.
3130
3131 2019-06-04  Pedro Alves  <palves@redhat.com>
3132
3133         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3134
3135         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3136         * breakpoint.c (condition_completer): Likewise.
3137         * cli/cli-dump.c (scan_expression): Likewise.
3138         * common/filestuff.c (mkdir_recursive): Likewise.
3139         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3140         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3141         (gdb_abspath): Likewise.
3142         * compile/compile-cplus-types.c
3143         (compile_cplus_instance::decl_name): Likewise.
3144         * completer.c (complete_explicit_location):
3145         (signal_completer, reg_or_group_completer_1): Likewise.
3146         * cp-support.c (cp_remove_params_if_any): Likewise.
3147         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3148         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3149         * infcmd.c (strip_bg_char): Likewise.
3150         * linespec.c (copy_token_string): Likewise.
3151         * mi/mi-main.c (output_cores): Likewise.
3152         * psymtab.c (psymtab_search_name):
3153         * symfile.c (test_set_ext_lang_command): Likewise.
3154         * target.c (target_fileio_read_stralloc): Likewise.
3155         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3156         * value.c (complete_internalvar): Likewise.
3157
3158 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3159
3160         Add objfile property to gdb.Type.
3161         * NEWS: Mention Python API addition.
3162         * python/py-type.c (typy_get_objfile): New method.
3163
3164 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3165
3166         * NEWS: Mention the new set|show style [title|highlight].
3167         Mention changes to "show style", "help" and "apropos".
3168
3169 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3170
3171         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3172         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3173         instead of print_help_for_command.
3174         (print_doc_of_command): New function.
3175         (help_list): Add 'apropos -v word' suggestion.
3176         (print_help_for_command): Style the command name using title style.
3177         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3178         (_initialize_cli_cmds): Describe -v in apropos_command help.
3179
3180 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3181
3182         * cli/cli-style.h (cli_style_option): Add name in constructor,
3183         add m_name class member, add constructor with intensity,
3184         add name class function.
3185         (cli_style_option::add_setshow_commands): Remove name argument.
3186         (highlight_style, title_style): New styles.
3187         * cli/cli-style.c (do_show): New function that shows a style
3188         characteristic styling the style name with itself.
3189         (set_style_name): New function.
3190         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3191         Update all callers according to the changes in cli/cli-style.h.
3192         * utils.h (fputs_highlighted): New function.
3193         * utils.c (fputs_highlighted): Likewise.
3194
3195 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3196
3197         * NEWS: Mention new pipe command and new convenience variables.
3198
3199 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3200
3201         * cli/cli-cmds.c (pipe_command): New function.
3202         (_initialize_cli_cmds): Call add_com for pipe_command.
3203         Define | as an alias for pipe.
3204         (exit_status_set_internal_vars): New function.
3205         (shell_escape): Call exit_status_set_internal_vars.
3206         cli/cli-decode.c (find_command_name_length): Recognize | as
3207         a single character command.
3208
3209 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3210
3211         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3212         top.c (execute_command_to_ui_file): New function, mostly a copy
3213         of execute_command_to_string.
3214         (execute_command_to_string): Implement by calling
3215         execute_command_to_ui_file.
3216
3217 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3218
3219         * top.h (saved_command_line): Remove declaration.
3220         * top.c (previous_saved_command_line, previous_repeat_arguments):
3221         New variables.
3222         (saved_command_line): Make static, define together with other
3223         'repeat variables'.
3224         (dont_repeat): Clear repeat_arguments.
3225         (repeat_previous, get_saved_command_line, save_command_line):
3226         New functions.
3227         (gdb_init): Initialize saved_command_line
3228         and previous_saved_command_line.
3229         * main.c (captured_main_1): Remove saved_command_line initialization.
3230         * event-top.c (handle_line_of_input): Update to use
3231         the new 'repeat' related functions instead of direct access to
3232         saved_command_line.
3233         * command.h (repeat_previous, get_saved_command_line,
3234         save_command_line): New declarations.
3235         (dont_repeat): Add comment.
3236
3237 2019-05-30  Tom Tromey  <tromey@adacore.com>
3238
3239         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3240         Fix comment.
3241         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3242
3243 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3244
3245         PR cli/24587
3246         * completer.c (complete): Initialize variable word.
3247
3248 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3249
3250         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3251         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3252         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3253         'body' is NULL to the outter 'if', protecting the '!is_define'
3254         situation as well.
3255
3256 2019-05-29  Tom Tromey  <tromey@adacore.com>
3257
3258         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3259         (dwarf_unknown): New function.
3260         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3261         (dwarf_type_encoding_name): Use dwarf_unknown.
3262
3263 2019-05-29  Tom Tromey  <tromey@adacore.com>
3264
3265         PR c++/20020:
3266         * cp-valprint.c (cp_print_value_fields): Call
3267         cp_print_static_field inside "try".
3268
3269 2019-05-29  Tom Tromey  <tromey@adacore.com>
3270
3271         * inflow.c (struct terminal_info): Add default operator=.
3272         * configure: Rebuild.
3273         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3274         -Wdeprecated-copy-dtor, -Wredundant-move.
3275
3276 2019-05-29  Tom Tromey  <tromey@adacore.com>
3277
3278         * NEWS: Add entry.
3279         * infcmd.c (print_return_value_1): Handle finish_print
3280         option.
3281         (show_print_finish): New function.
3282         (_initialize_infcmd): Add "set/show print finish" commands.
3283         * valprint.c (user_print_options): Initialize new member.
3284         * valprint.h (struct value_print_options) <finish_print>: New
3285         member.
3286
3287 2019-05-28  Tom Tromey  <tromey@adacore.com>
3288
3289         * ada-lang.c (ada_remove_Xbn_suffix)
3290         (find_old_style_renaming_symbol)
3291         (parse_old_style_renaming): Remove.
3292         (ada_find_renaming_symbol): Don't call
3293         find_old_style_renaming_symbol.
3294         (ada_is_renaming_symbol): Rename from
3295         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3296         bool.  Now static.
3297         (ada_read_var_value): Update and simplify.
3298         * ada-exp.y (write_var_or_type): Remove old code.
3299
3300 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3301
3302         * event-top.c: Remove include comment.
3303         * inflow.c (class scoped_ignore_sigttou): Move from here...
3304         * inflow.h (class scoped_ignore_sigttou): ...to here.
3305         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3306         * top.c:  Remove include comment.
3307
3308 2019-05-27  Tom Tromey  <tom@tromey.com>
3309
3310         * NEWS: Fix typo.
3311
3312 2019-05-22  Tom Tromey  <tromey@adacore.com>
3313
3314         * target.c (target_follow_exec): Constify parameter.
3315         * target-delegates.c: Rebuild.
3316         * remote.c (remote_target::follow_exec): Constify parameter.
3317         * infrun.c (follow_exec): Constify parameter.
3318         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3319         (target_follow_exec): Likewise.
3320
3321 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3322
3323         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3324         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3325
3326 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3327
3328         * NEWS: Add debugredirect and testsuite sections.
3329
3330 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3331
3332         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3333         target descriptions using exclusively floating point register name
3334         aliases.
3335
3336 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3337
3338         PR gdb/18644:
3339         * f-lang.c (build_fortran_types): Handle the case where
3340         gdbarch_floatformat_for_type returns a nullptr.
3341
3342 2019-05-21  Tom de Vries  <tdevries@suse.de>
3343
3344         PR cli/24587
3345         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3346
3347 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3348
3349         PR gdb/18644:
3350         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3351         16-byte floats.
3352         * i386-tdep.c (i386_floatformat_for_type): Use
3353         floatformats_ia64_quad for the 16-byte floating point component
3354         within a fortran 32-byte complex number.
3355
3356 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3357
3358         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3359         delete default constructor.
3360         (find_partial_die): Update to return const struct.
3361         (partial_die_parent_scope): Move variable declaration into scope
3362         of its use and change its type to auto.
3363         (guess_partial_die_structure_name): Likewise.
3364         (partial_die_info::fixup): Likewise.
3365
3366 2019-05-17  Tom Tromey  <tromey@adacore.com>
3367
3368         * source.c (find_and_open_source): Remove cast.
3369
3370 2019-05-17  Tom Tromey  <tromey@adacore.com>
3371
3372         * annotate.c (annotate_source): Make "filename" const.
3373         * annotate.h (annotate_source): Use const.
3374
3375 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3376
3377         * disasm.c (set_disassembler_options): Send errors to stderr.
3378
3379 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3380
3381         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3382         (cli_interp_base::set_logging): Check debug_redirect.
3383         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3384         * cli/cli-logging.c (debug_redirect): Add static variable.
3385         (pop_output_files): Add default param.
3386         (handle_redirections): Print debug setting.
3387         (show_logging_command): Likewise.
3388         (_initialize_cli_logging): Add debugredirect command.
3389         * interps.c (current_interp_set_logging): Add debug_redirect
3390         parameter.
3391         * interps.h (set_logging): Add debug_redirect parameter.
3392         (current_interp_set_logging): Likewise.
3393         * mi/mi-common.h: Likewise.
3394         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3395
3396 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3397             Tom Tromey  <tromey@adacore.com>
3398
3399         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3400         directly.
3401         * cli/cli-interp.h (make_logging_output): Remove declaration.
3402         * cli/cli-logging.c (make_logging_output): Remove function.
3403         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3404         directly.
3405         * ui-file.c (tee_file::tee_file): Remove bools.
3406         (tee_file::~tee_file): Remove deletes.
3407         * ui-file.h (tee_file): Remove bools.
3408
3409 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3410
3411         * mi/mi-cmds.h (mi_cmd_complete): New function.
3412         * mi/mi-main.c (mi_cmd_complete): Likewise.
3413         * mi/mi-cmds.c: Define new MI command -complete.
3414         * NEWS: Mention new -complete command.
3415
3416 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3417
3418         * completer.h (complete): New function.
3419         * completer.c (complete): Likewise.
3420         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3421         function defined in completer.h.
3422
3423 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3424
3425         * MAINTAINERS (Write After Approval): Add myself.
3426
3427 2019-05-17  Tom de Vries  <tdevries@suse.de>
3428
3429         PR gdb/24094
3430         * dwarf2read.c (struct cu_partial_die_info): New struct.
3431         (find_partial_die): Return cu_partial_die_info.
3432         (partial_die_parent_scope, guess_partial_die_structure_name)
3433         (partial_die_info::fixup): Handle new return type of find_partial_die.
3434
3435 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3436
3437         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3438         "std::string", simplifying the algorithm.
3439
3440 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3441
3442         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3443         (stap_static_probe_ops::get_probes): Likewise.
3444
3445 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3446
3447         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3448         '-')" and "else if".
3449         (stap_parse_single_operand): Join checks for
3450         "gdbarch_stap_parse_special_token_p" and
3451         "gdbarch_stap_parse_special_token" in the same "if" statement.
3452         Invert check when verifying for operation on register
3453         displacement.
3454
3455 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3456
3457         * stap-probe.c (stap_get_opcode): Update comment.
3458         (stap_get_expected_argument_type): Likewise.
3459         (handle_stap_probe): Likewise.
3460
3461 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3462
3463         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3464         return type to 'bool'.  Adjust comment.  Use 'bool' when
3465         appropriate.
3466         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3467         * stap-probe.c (stap_parse_argument_1): Likewise.
3468         (stap_is_operator): Likewise.
3469         (stap_is_generic_prefix): Likewise.
3470         (stap_is_register_prefix): Likewise.
3471         (stap_is_register_indirection_prefix): Likewise.
3472         (stap_is_integer_prefix): Likewise.
3473         (stap_generic_check_suffix): Likewise.
3474         (stap_check_integer_suffix): Likewise.
3475         (stap_check_register_suffix): Likewise.
3476         (stap_check_register_indirection_suffix): Likewise.
3477         (stap_parse_register_operand): Likewise.
3478         (stap_parse_single_operand): Likewise.
3479         (stap_parse_argument_1): Likewise.
3480         (stap_probe::get_argument_count): Likewise.
3481         (stap_is_operator): Likewise.
3482
3483 2019-05-16  Tom Tromey  <tromey@adacore.com>
3484
3485         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3486         keyword to foreach.
3487
3488 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3489
3490         * linux-thread-db.c (try_thread_db_load_1): Change return type
3491         to bool.
3492         (try_thread_db_load): Likewise.
3493         (try_thread_db_load_from_pdir_1): Likewise.
3494         (try_thread_db_load_from_pdir): Likewise.
3495         (try_thread_db_load_from_sdir): Likewise.
3496         (try_thread_db_load_from_dir): Likewise.
3497         (thread_db_load_search): Likewise.
3498         (has_libpthread): Likewise.
3499         (thread_db_load): Likewise.
3500
3501 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3502
3503         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3504         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3505         NULL, and complain/return if that's the case.
3506
3507 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3508
3509         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3510         (advance, posn, abstract_read_memory): New functions.
3511         [struct mem_read_abstraction]: New struct.
3512         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3513
3514 2019-05-14  Tom Tromey  <tromey@adacore.com>
3515
3516         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3517         value is not lval_memory.
3518
3519 2019-05-14  Tom Tromey  <tromey@adacore.com>
3520
3521         * solib.c (info_sharedlibrary_command): Style the file name.
3522
3523 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3524
3525         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3526         (aarch64_vnv_type): Likewise.
3527         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3528         * common/tdesc.c: Likewise.
3529         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3530         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3531         * features/aarch64-fpu.xml: Add ieee half view.
3532         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3533         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3534         * gdbtypes.h (struct builtin_type): Likewise.
3535         (struct objfile_type): Likewise.
3536
3537 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3538
3539         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3540         typo.
3541         * location.h (string_to_event_location): Likewise.
3542
3543 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3544
3545         GDB 8.3 released.
3546
3547 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3548
3549         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3550         New variable declaration.
3551         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3552         New variable.
3553         (print_one_breakpoint): Use ui_out::test_flags and new global
3554         variable to compute use_fixed_output.
3555         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3556         Remove.
3557         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3558         (mi_multi_location_breakpoint_output_fixed): Remove.
3559         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3560         new variable.
3561         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3562         fix_multi_location_breakpoint_output flag if version >= 3.
3563         * ui-out.h (enum ui_out_flag)
3564         <fix_multi_location_breakpoint_output>: New enumerator.
3565
3566 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3567
3568         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3569
3570 2019-05-10  Tom Tromey  <tromey@adacore.com>
3571
3572         * ada-lang.c (catch_ada_completer): New function.
3573         (_initialize_ada_language): Use it.
3574
3575 2019-05-10  Tom Tromey  <tromey@adacore.com>
3576
3577         * thread.c (print_thread_info): Make "requested_threads" const.
3578         * gdbthread.h (print_thread_info): Make "requested_threads"
3579         const.
3580         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3581         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3582
3583 2019-05-08  Tom Tromey  <tom@tromey.com>
3584
3585         * gdbtypes.c (objfile_type_data): Change type.
3586         (objfile_type, _initialize_gdbtypes): Update.
3587
3588 2019-05-08  Tom Tromey  <tom@tromey.com>
3589
3590         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3591         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3592         (_initialize_dwarf2_frame): Update.
3593
3594 2019-05-08  Tom Tromey  <tom@tromey.com>
3595
3596         * objc-lang.c (objc_objfile_data): Change type.
3597         (find_methods): Update.
3598         (_initialize_objc_lang): Remove.
3599
3600 2019-05-08  Tom Tromey  <tom@tromey.com>
3601
3602         * stabsread.c (rs6000_builtin_type_data): Change type.
3603         (rs6000_builtin_type, _initialize_stabsread): Update.
3604
3605 2019-05-08  Tom Tromey  <tom@tromey.com>
3606
3607         * mips-tdep.c (mips_pdr_data): Remove.
3608         (_initialize_mips_tdep): Update.
3609
3610 2019-05-08  Tom Tromey  <tom@tromey.com>
3611
3612         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3613         (hppa_init_objfile_priv_data, read_unwind_info)
3614         (find_unwind_entry, _initialize_hppa_tdep): Update.
3615
3616 2019-05-08  Tom Tromey  <tom@tromey.com>
3617
3618         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3619         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3620         on obstack.
3621         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3622
3623 2019-05-08  Tom Tromey  <tom@tromey.com>
3624
3625         * mdebugread.c (basic_type_data): Change type.
3626         (basic_type, _initialize_mdebugread): Update.
3627
3628 2019-05-08  Tom Tromey  <tom@tromey.com>
3629
3630         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3631
3632 2019-05-08  Tom Tromey  <tom@tromey.com>
3633
3634         * nto-tdep.c (nto_inferior_data_reg): Change type.
3635         (nto_inferior_data): Update.
3636         (nto_inferior_data_cleanup, nto_new_inferior_data)
3637         (_initialize_nto_tdep): Remove.
3638         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3639
3640 2019-05-08  Tom Tromey  <tom@tromey.com>
3641
3642         * ada-lang.c (struct ada_inferior_data): Add initializers.
3643         (ada_inferior_data): Change type.
3644         (ada_inferior_data_cleanup): Remove.
3645         (get_ada_inferior_data, ada_inferior_exit)
3646         (struct ada_pspace_data): Add initializers, destructor.
3647         (ada_pspace_data_handle): Change type.
3648         (get_ada_pspace_data): Update.
3649         (ada_pspace_data_cleanup): Remove.
3650
3651 2019-05-08  Tom Tromey  <tom@tromey.com>
3652
3653         * coffread.c (struct coff_symfile_info): Add initializers.
3654         (coff_objfile_data_key): Move lower.  Change type.
3655         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3656         Update.
3657         (coff_free_info): Remove.
3658
3659 2019-05-08  Tom Tromey  <tom@tromey.com>
3660
3661         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3662         (fbsd_pspace_data_handle): Move lower.  Change type.
3663         (get_fbsd_pspace_data): Update.
3664         (fbsd_pspace_data_cleanup): Remove.
3665         (_initialize_fbsd_tdep): Update.
3666
3667 2019-05-08  Tom Tromey  <tom@tromey.com>
3668
3669         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3670         (get_ada_tasks_pspace_data): Update.
3671         (ada_tasks_pspace_data_cleanup): Remove.
3672         (_initialize_tasks): Update.
3673         (ada_tasks_inferior_data_handle): Change type.
3674         (get_ada_tasks_inferior_data): Update.
3675         (ada_tasks_inferior_data_cleanup): Remove.
3676         (struct ada_tasks_pspace_data): Add initializers.
3677
3678 2019-05-08  Tom Tromey  <tom@tromey.com>
3679
3680         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3681         * symfile-debug.c (debug_sym_get_probes): Change type.
3682         * stap-probe.c (handle_stap_probe):
3683         (stap_static_probe_ops::get_probes): Change type.
3684         * probe.h (class static_probe_ops) <get_probes>: Change type.
3685         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3686         (parse_probes_in_pspace): Update.
3687         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3688         Update.
3689         (any_static_probe_ops::get_probes): Change type.
3690         * elfread.c (elfread_data): New typedef.
3691         (probe_key): Change type.
3692         (elf_get_probes): Likewise.  Update.
3693         (probe_key_free): Remove.
3694         (_initialize_elfread): Update.
3695         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3696         Change type.
3697         (dtrace_process_dof_probe, dtrace_process_dof)
3698         (dtrace_static_probe_ops::get_probe): Change type.
3699
3700 2019-05-08  Tom Tromey  <tom@tromey.com>
3701
3702         * xcoffread.c (struct xcoff_symfile_info): Rename from
3703         coff_symfile_info.  Add initializers.
3704         (xcoff_objfile_data_key): Move lower.  Change type.
3705         (XCOFF_DATA): Rewrite.
3706         (xcoff_free_info): Remove.
3707         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3708         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3709         (xcoff_initial_scan): Update.
3710
3711 2019-05-08  Tom Tromey  <tom@tromey.com>
3712
3713         * solib-svr4.c (struct svr4_info): Add initializers and
3714         destructor.
3715         <probes_table>: Now an htab_up.
3716         (solib_svr4_pspace_data): Change type.
3717         (free_probes_table): Simplify.
3718         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3719         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3720         (probes_table_remove_objfile_probes, register_solib_event_probe)
3721         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3722         (_initialize_svr4_solib): Update.
3723
3724 2019-05-08  Tom Tromey  <tom@tromey.com>
3725
3726         * remote.c (remote_pspace_data): Change type.
3727         (remote_pspace_data_cleanup): Remove.
3728         (get_remote_exec_file, set_pspace_remote_exec_file)
3729         (_initialize_remote): Update.
3730
3731 2019-05-08  Tom Tromey  <tom@tromey.com>
3732
3733         * breakpoint.c (breakpoint_objfile_key): Change type.
3734         (get_breakpoint_objfile_data): Update.
3735         (free_breakpoint_objfile_data): Remove.
3736         (_initialize_breakpoint): Update.
3737
3738 2019-05-08  Tom Tromey  <tom@tromey.com>
3739
3740         * linux-tdep.c (struct linux_info): Add initializers.
3741         (linux_inferior_data): Move.  Change type.
3742         (invalidate_linux_cache_inf): Update.
3743         (linux_inferior_data_cleanup): Remove.
3744         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3745
3746 2019-05-08  Tom Tromey  <tom@tromey.com>
3747
3748         * auxv.c (auxv_inferior_data): Move.  Change type.
3749         (auxv_inferior_data_cleanup): Remove.
3750         (invalidate_auxv_cache_inf): Rewrite.
3751         (get_auxv_inferior_data, _initialize_auxv): Update.
3752
3753 2019-05-08  Tom Tromey  <tom@tromey.com>
3754
3755         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3756         (symfile_debug_objfile_data_key): Change type.
3757         (symfile_debug_installed, debug_qf_has_symbols)
3758         (debug_qf_find_last_source_symtab)
3759         (debug_qf_forget_cached_source_info)
3760         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3761         (debug_qf_print_stats, debug_qf_dump)
3762         (debug_qf_expand_symtabs_for_function)
3763         (debug_qf_expand_all_symtabs)
3764         (debug_qf_expand_symtabs_with_fullname)
3765         (debug_qf_map_matching_symbols)
3766         (debug_qf_expand_symtabs_matching)
3767         (debug_qf_find_pc_sect_compunit_symtab)
3768         (debug_qf_map_symbol_filenames)
3769         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3770         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3771         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3772         (debug_sym_read_linetable, debug_sym_relocate): Update.
3773         (symfile_debug_free_objfile): Remove.
3774         (install_symfile_debug_logging, _initialize_symfile_debug):
3775         Update.
3776
3777 2019-05-08  Tom Tromey  <tom@tromey.com>
3778
3779         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3780         allocate_on_obstack.
3781         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3782         (get_dwarf2_per_objfile): Update.
3783         (set_dwarf2_per_objfile): Remove.
3784         (dwarf2_has_info, dwarf2_get_section_info): Update.
3785         (dwarf2_free_objfile): Remove.
3786         (_initialize_dwarf2_read): Update.
3787
3788 2019-05-08  Tom Tromey  <tom@tromey.com>
3789
3790         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3791         initializers.
3792         <unsupported_script_warning_printed,
3793         script_not_found_warning_printed>: Now bool.
3794         (auto_load_pspace_data): Change type.
3795         (~auto_load_pspace_info): Rename from
3796         auto_load_pspace_data_cleanup.
3797         (get_auto_load_pspace_data, init_loaded_scripts_info)
3798         (clear_section_scripts, maybe_print_unsupported_script_warning)
3799         (maybe_print_script_not_found_warning, _initialize_auto_load):
3800         Update.
3801
3802 2019-05-08  Tom Tromey  <tom@tromey.com>
3803
3804         * objfiles.c (objfile_pspace_info): Add destructor and
3805         initializers.
3806         (objfiles_pspace_data): Change type.
3807         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3808         (get_objfile_pspace_data): Update.
3809         (objfiles_bfd_data): Change type.
3810         (get_objfile_bfd_data): Update.
3811         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3812
3813 2019-05-08  Tom Tromey  <tom@tromey.com>
3814
3815         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3816         Change type.
3817         (get_catch_syscall_inferior_data): Update.
3818         (catch_syscall_inferior_data_cleanup): Remove.
3819         (_initialize_break_catch_syscall): Update.
3820
3821 2019-05-08  Tom Tromey  <tom@tromey.com>
3822
3823         * inflow.c (struct terminal_info): Add destructor and
3824         initializers.
3825         (inflow_inferior_data): Change type.
3826         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3827         (get_inflow_inferior_data, inflow_inferior_exit)
3828         (swap_terminal_info, _initialize_inflow): Update.
3829
3830 2019-05-08  Tom Tromey  <tom@tromey.com>
3831
3832         * target-dcache.c (target_dcache_cleanup): Remove.
3833         (target_dcache_aspace_key): Change type.
3834         (target_dcache_init_p, target_dcache_invalidate)
3835         (target_dcache_get, target_dcache_get_or_init)
3836         (_initialize_target_dcache): Update.
3837         * dcache.h (struct dcache_deleter): New.
3838
3839 2019-05-08  Tom Tromey  <tom@tromey.com>
3840
3841         * symtab.c (struct symbol_cache): Add destructor and
3842         initializers.
3843         (symbol_cache_key): Move.  Change type.
3844         (make_symbol_cache, free_symbol_cache): Remove.
3845         (get_symbol_cache): Update.
3846         (symbol_cache_cleanup): Remove.
3847         (ALL_PSPACES, symbol_cache_flush)
3848         (maintenance_print_symbol_cache)
3849         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3850         Update.
3851
3852 2019-05-08  Tom Tromey  <tom@tromey.com>
3853
3854         * symtab.c (struct main_info): Add destructor and initializers.
3855         (main_progspace_key): Move.  Change type.
3856         (get_main_info): Update.
3857         (main_info_cleanup): Remove.
3858         (_initialize_symtab): Update.
3859
3860 2019-05-08  Tom Tromey  <tom@tromey.com>
3861
3862         * registry.h (DECLARE_REGISTRY): Define the _key class.
3863
3864 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3865
3866         * NEWS: Merge two 'New commands' sections.
3867
3868 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3869
3870         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3871         parameter and use Ada language definition instead.
3872         (ada_val_print_ptr): Remove unused language parameter.
3873         (ada_val_print_num): Remove language parameter and use Ada language
3874         definition instead.
3875         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3876         parameter.
3877         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3878         parameter and use Ada language definition instead.
3879         (ada_val_print_1): Update all ada_val_print_xxx calls.
3880         Remove language parameter.
3881         (ada_val_print): Update ada_val_print_1 call.
3882
3883 2019-05-08  Tom Tromey  <tromey@adacore.com>
3884
3885         * remote.c (remote_hw_watchpoint_limit)
3886         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3887         Now static.
3888
3889 2019-05-08  Tom Tromey  <tromey@adacore.com>
3890
3891         * maint.c (_initialize_maint_cmds): Move initialization code to
3892         remote.c.
3893         (watchdog, show_watchdog): Move to remote.c.
3894         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3895         "watchdog" static.
3896         (_initialize_remote): Move initialization code from maint.c.
3897         * defs.h (watchdog): Don't declare.
3898
3899 2019-05-08  Tom Tromey  <tromey@adacore.com>
3900
3901         * tui/tui-interp.c: Include main.h.
3902         * interps.c: Include main.h.
3903         * main.h (interpreter_p): Declare.
3904         * defs.h (interpreter_p): Don't declare.
3905
3906 2019-05-08  Tom Tromey  <tromey@adacore.com>
3907
3908         * dwarf2loc.c: Include dwarf2read.h.
3909         * defs.h (read_unsigned_leb128): Don't declare.
3910         * dwarf2read.h (read_unsigned_leb128): Declare.
3911
3912 2019-05-08  Tom Tromey  <tromey@adacore.com>
3913
3914         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3915         method.
3916
3917 2019-05-08  Tom Tromey  <tromey@adacore.com>
3918
3919         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3920         when no wrap column is set.
3921
3922 2019-05-08  Tom Tromey  <tromey@adacore.com>
3923
3924         * c-lang.c (c_get_string): Handle non-C-style arrays.
3925
3926 2019-05-08  Tom Tromey  <tromey@adacore.com>
3927
3928         * typeprint.c (print_offset_data::update): Print the bit offset,
3929         not the number of bits remaining.
3930
3931 2019-05-08  Tom Tromey  <tromey@adacore.com>
3932
3933         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3934         padding at end of comment.
3935
3936 2019-05-08  Tom Tromey  <tromey@adacore.com>
3937
3938         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3939         Compare main types.
3940
3941 2019-05-06  Tom Tromey  <tom@tromey.com>
3942
3943         * common/scoped_mmap.c: Include common-defs.h.
3944         * common/scoped_mmap.h: Don't include config.h.
3945
3946 2019-05-04  Tom Tromey  <tom@tromey.com>
3947
3948         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3949         (struct aarch64_call_info): Add initializers.
3950         <si>: Now a std::vector.
3951         (pass_on_stack, aarch64_push_dummy_call): Update.
3952
3953 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3954             Tom Tromey  <tom@tromey.com>
3955
3956         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3957         (ppc_threads): Now a std::vector.  Now static.
3958         (hwdebug_find_thread_points_by_tid)
3959         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3960         Update.
3961
3962 2019-05-04  Tom Tromey  <tom@tromey.com>
3963
3964         * arc-tdep.c (arc_tdesc_init): Return bool.
3965
3966 2019-05-04  Tom Tromey  <tom@tromey.com>
3967
3968         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3969         Use gdb_assert_not_reached.
3970
3971 2019-05-04  Tom Tromey  <tom@tromey.com>
3972
3973         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3974         "false".
3975
3976 2019-05-04  Tom Tromey  <tom@tromey.com>
3977
3978         * arc-tdep.c (arc_tdesc_init): Use bool.
3979
3980 2019-05-04  Tom Tromey  <tom@tromey.com>
3981
3982         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3983
3984 2019-05-04  Tom Tromey  <tom@tromey.com>
3985
3986         * cli/cli-cmds.c (valid_command_p): Return bool.
3987
3988 2019-05-04  Tom Tromey  <tom@tromey.com>
3989
3990         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3991         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3992
3993 2019-05-04  Raul Tambre  <raul@tambre.ee>
3994
3995         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3996         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3997         operator for comparison.
3998
3999 2019-05-04  Tom Tromey  <tom@tromey.com>
4000
4001         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4002         (lookup_partial_symbol, print_partial_symbols)
4003         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4004         (psymbol_compare): Update.
4005         (add_psymbol_to_bcache): Clear the entire psymbol.
4006         (maintenance_check_psymtabs): Update.
4007         * psympriv.h (struct partial_symbol): Don't derive from
4008         general_symbol_info.
4009         <obj_section, unrelocated_address, address,
4010         set_unrelocated_address>: Update.
4011         <ginfo>: New member.
4012         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4013         (debug_names::write_psymbols): Update.
4014
4015 2019-05-04  Tom de Vries  <tdevries@suse.de>
4016
4017         * contrib/cc-with-tweaks.sh: Support -n arg.
4018
4019 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4020
4021         * corelow.c (core_target::detach): Ensure frame cache and
4022         register caches are cleared.
4023         inferior.c (exit_inferior_1): Likewise.
4024
4025 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4026             Tom Tromey  <tom@tromey.com>
4027
4028         * dictionary.c (collate_pending_symbols_by_language): Remove
4029         "struct" from foreach.
4030         * symtab.c (lookup_global_symbol_from_objfile)
4031         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4032         foreach.
4033         * ser-tcp.c (net_open): Remove "struct" from foreach.
4034         * objfiles.c (objfile_relocate, objfile_rebase)
4035         (objfile_has_symbols): Remove "struct" from foreach.
4036         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4037         from foreach.
4038         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4039         foreach.
4040         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4041         "struct" from foreach.
4042         * ada-lang.c (create_excep_cond_exprs)
4043         (ada_exception_catchpoint_cond_string): Remove "struct" from
4044         foreach.
4045
4046 2019-05-03  Tom Tromey  <tromey@adacore.com>
4047
4048         * ada-exp.y (convert_char_literal): Check suffix of each
4049         enumerator.
4050
4051 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4052
4053         PR ada/21406:
4054         * ada-exp.y (yywrap): Don't define.
4055         * ada-lex.l (%option): Add noyywrap
4056         (yywrap): Remove.
4057
4058 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4059
4060         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4061         _WIN32_WINNT to the XP level, unless already defined to a higher
4062         level.
4063
4064         * unittests/parse-connection-spec-selftests.c:
4065         * ser-tcp.c:
4066         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4067         override.
4068
4069         * symfile.c (find_separate_debug_file): Remove colon from the
4070         drive spec of DOS/Windows file names of the target, so that the
4071         file name produced from DEBUGDIR and the target's directory will
4072         be valid on DOS/Windows systems.
4073
4074 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4075
4076         * rust-lang.c (val_print_struct): Handle printing structures
4077         containing strings.
4078
4079 2019-05-02  Tom Tromey  <tromey@adacore.com>
4080
4081         * valarith.c (_initialize_valarith): Remove.
4082
4083 2019-05-01  Tom Tromey  <tromey@adacore.com>
4084
4085         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4086         bitfields.
4087
4088 2019-05-01  Tom Tromey  <tromey@adacore.com>
4089
4090         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4091         for big-endian copies.
4092
4093 2019-04-30  Ali Tamur  <tamur@google.com>
4094         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4095         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4096         (read_3_bytes): New function.
4097
4098 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4099
4100         * windows-nat.c (main_thread_id): Delete.
4101         (handle_output_debug_string): Replace main_thread_id by
4102         current_event.dwThreadId.
4103         (fake_create_process): Likewise.
4104         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4105         Do not set main_thread_id.
4106         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4107         current_event.dwThreadId.
4108         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4109
4110 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4111
4112         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4113         Use current_event.dwThreadId instead of main_thread_id.
4114
4115 2019-04-30  Tom Tromey  <tromey@adacore.com>
4116
4117         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4118         (create_excep_cond_exprs): Iterate over program spaces.
4119         (ada_exception_catchpoint_cond_string): Examine all minimal
4120         symbols for exception types.
4121
4122 2019-04-30  Tom Tromey  <tromey@adacore.com>
4123
4124         PR c++/24470:
4125         * dwarf2read.c (process_structure_scope): Handle case where type
4126         has template parameters but no symbol was created.
4127
4128 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4129             Chris January  <chris.january@arm.com>
4130
4131         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4132         qualifier.
4133         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4134
4135 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4136
4137         * f-typeprint.c (f_print_type): Update rules for printing
4138         whitespace.
4139         (f_type_print_varspec_suffix): Likewise.
4140
4141 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4142             Chris January  <chris.january@arm.com>
4143
4144         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4145         function arguments.
4146
4147 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4148
4149         * f-lang.c (build_fortran_types): Change name of void type to
4150         lower case.
4151         * f-typeprint.c (f_type_print_base): Print the name of the void
4152         type, rather than a fixed string.
4153         * f-valprint.c (f_decorations): Use lower case void string.
4154
4155 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4156             Chris January  <chris.january@arm.com>
4157
4158         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4159         types for Fortran.
4160
4161 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4162             Chris January  <chris.january@arm.com>
4163             David Lecomber  <david.lecomber@arm.com>
4164
4165         * f-exp.y (BINOP_INTRINSIC): New token.
4166         (exp): New parser rule handling BINOP_INTRINSIC.
4167         (f77_keywords): Add new builtin procedures.
4168         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4169         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4170         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4171         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4172         (print_unop_subexp_f): New function.
4173         (print_binop_subexp_f): New function.
4174         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4175         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4176         (dump_subexp_body_f): Likewise.
4177         (operator_check_f): Likewise.
4178         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4179         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4180
4181 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4182
4183         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4184         UNOP_KIND.
4185         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4186         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4187         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4188         (operator_length_f): New fuction.
4189         (print_subexp_f): New function.
4190         (op_name_f): New function.
4191         (dump_subexp_body_f): New function.
4192         (operator_check_f): New function.
4193         (exp_descriptor_f): Replace standard expression handling functions
4194         with new functions.
4195         * gdb/fortran-operator.def: New file.
4196         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4197         * gdb/std-operator.def: Remove UNOP_KIND.
4198
4199 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4200
4201         * std-operator.def: Remove unbalanced, stray double quote
4202         character.
4203
4204 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4205             Chris January  <chris.january@arm.com>
4206             Daniel Everett  <daniel.everett@arm.com>
4207             Nick Forrington  <nick.forrington@arm.com>
4208             Richard Bunt  <richard.bunt@arm.com>
4209
4210         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4211         of depth when printing anonymous structs or unions.
4212         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4213         Don't print either the top-level value, or the children if the
4214         max-depth is exceeded.
4215         (ppscm_print_children): When printing the key of a map, allow one
4216         extra level of depth.
4217         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4218         print either the top-level value, or the children if the max-depth
4219         is exceeded.
4220         (print_children): When printing the key of a map, allow one extra
4221         level of depth.
4222         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4223         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4224         (user_print_options): Initialise max_depth field.
4225         (val_print_scalar_or_string_type_p): New function.
4226         (val_print): Check to see if the max depth has been reached.
4227         (val_print_check_max_depth): Define new function.
4228         (show_print_max_depth): New function.
4229         (_initialize_valprint): Add 'print max-depth' option.
4230         * valprint.h (struct value_print_options) <max_depth>: New field.
4231         (val_print_check_max_depth): Declare new function.
4232         * NEWS: Document new feature.
4233
4234 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4235
4236         * ada-lang.c (ada_language_defn): Initialise new field.
4237         * c-lang.c (c_is_string_type_p): New function.
4238         (c_language_defn): Initialise new field.
4239         (cplus_language_defn): Initialise new field.
4240         (asm_language_defn): Initialise new field.
4241         (minimal_language_defn): Initialise new field.
4242         * c-lang.h (c_is_string_type_p): Declare new function.
4243         * d-lang.c (d_language_defn): Initialise new field.
4244         * f-lang.c (f_is_string_type_p): New function.
4245         (f_language_defn): Initialise new field.
4246         * go-lang.c (go_is_string_type_p): New function.
4247         (go_language_defn): Initialise new field.
4248         * language.c (default_is_string_type_p): New function.
4249         (unknown_language_defn): Initialise new field.
4250         (auto_language_defn): Initialise new field.
4251         * language.h (struct language_defn) <la_is_string_type_p>: New
4252         member variable.
4253         (default_is_string_type_p): Declare new function.
4254         * m2-lang.c (m2_language_defn): Initialise new field.
4255         * objc-lang.c (objc_language_defn): Initialise new field.
4256         * opencl-lang.c (opencl_language_defn): Initialise new field.
4257         * p-lang.c (pascal_is_string_type_p): New function.
4258         (pascal_language_defn): Initialise new field.
4259         * rust-lang.c (rust_is_string_type_p): New function.
4260         (rust_language_defn): Initialise new field.
4261
4262 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4263
4264         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4265         New field.
4266         * ada-lang.c (ada_language_defn): Initialise new field.
4267         * c-lang.c (c_language_defn): Likewise.
4268         (cplus_language_defn): Likewise.
4269         (asm_language_defn): Likewise.
4270         (minimal_language_defn): Likewise.
4271         * d-lang.c (d_language_defn): Likewise.
4272         * f-lang.c (f_language_defn): Likewise.
4273         * go-lang.c (go_language_defn): Likewise.
4274         * language.c (unknown_language_defn): Likewise.
4275         (auto_language_defn): Likewise.
4276         * m2-lang.c (m2_language_defn): Likewise.
4277         * objc-lang.c (objc_language_defn): Likewise.
4278         * opencl-lang.c (opencl_language_defn): Likewise.
4279         * p-lang.c (pascal_language_defn): Likewise.
4280         * rust-lang.c (rust_language_defn): Likewise.
4281
4282 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4283
4284         * ada-lang.c (ada_is_character_type): Change return type to bool.
4285         (ada_is_string_type): Likewise.
4286         * ada-lang.h (ada_is_character_type): Update declaration
4287         (ada_is_string_type): Likewise.
4288
4289 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4290
4291         Support style in 'frame|thread apply'
4292
4293         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4294         * record.c (record_start, record_stop): Update callers of
4295         execute_command_to_string with false.
4296         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4297         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4298         methods.
4299         (class string_file): New constructor with term_out parameter.
4300         Override methods term_out and can_emit_style_escape.  New member
4301         term_out.
4302         (class stdio_file): Override can_emit_style_escape.
4303         (class tee_file): Override term_out and can_emit_style_escape.
4304         * utils.h (can_emit_style_escape): Remove.
4305         * utils.c (can_emit_style_escape): Likewise.
4306         Update all callers of can_emit_style_escape (SOMESTREAM) to
4307         SOMESTREAM->can_emit_style_escape.
4308         * source-cache.c (source_cache::get_source_lines): Likewise.
4309         * stack.c (frame_apply_command_count): Call execute_command_to_string
4310         passing the term_out characteristic of the current gdb_stdout.
4311         * thread.c (thr_try_catch_cmd): Likewise.
4312         * top.c (execute_command_to_string): pass term_out parameter
4313         to construct the string_file for the command output.
4314         * ui-file.c (term_cli_styling): New function (most code moved
4315         from utils.c can_emit_style_escape).
4316         (string_file::string_file, string_file::can_emit_style_escape,
4317         stdio_file::can_emit_style_escape, tee_file::term_out,
4318         tee_file::can_emit_style_escape): New functions.
4319
4320 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4321
4322         * NEWS: Mention the new set|show may-call-functions.
4323         * infcall.c (may_call_functions_p): New variable.
4324         (show_may_call_functions_p): New function.
4325         (call_function_by_hand_dummy): Throws an error if not
4326         may-call-functions.
4327         (_initialize_infcall): Call add_setshow_boolean_cmd for
4328         may-call-functions.
4329
4330 2019-04-25  Keith Seitz  <keiths@redhat.com>
4331
4332         PR c++/24367
4333         * cp-support.c (inspect_type): Don't attempt substitutions
4334         of symbol with the same name.
4335
4336 2019-04-25  Tom Tromey  <tromey@adacore.com>
4337
4338         PR gdb/24475:
4339         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4340         static.
4341
4342 2019-04-25  Tom Tromey  <tromey@adacore.com>
4343
4344         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4345         rvalue reference.
4346         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4347         (gdb_xml_parser::parse): Use std::move.
4348         * python/python-internal.h (gdbpy_convert_exception): Take a const
4349         reference.
4350         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4351         std::move.
4352         * python/py-utils.c (gdbpy_convert_exception): Take a const
4353         reference.
4354         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4355         Use std::move.
4356         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4357         Use std::move.
4358         * mi/mi-main.c (mi_print_exception): Take a const reference.
4359         * main.c (handle_command_errors): Take a const reference.
4360         * linespec.c (parse_linespec): Use std::move.
4361         * infcall.c (run_inferior_call): Use std::move.
4362         (call_function_by_hand_dummy): Use std::move.
4363         * exec.c (try_open_exec_file): Use std::move.
4364         * exceptions.h (exception_print, exception_fprintf)
4365         (exception_print_same): Update.
4366         * exceptions.c (print_exception, exception_print)
4367         (exception_fprintf, exception_print_same): Change parameters to
4368         const reference.
4369         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4370         * common/new-op.c: Use std::move.
4371         * common/common-exceptions.h (struct gdb_exception): Add move
4372         constructor.
4373         (struct gdb_exception_error, struct gdb_exception_quit, struct
4374         gdb_quit_bad_alloc): Change constructor to move constructor.
4375         (throw_exception): Change parameter to rvalue reference.
4376         * common/common-exceptions.c (throw_exception): Take rvalue
4377         reference.
4378         * cli/cli-interp.c (safe_execute_command): Use std::move.
4379         * breakpoint.c (insert_bp_location, location_to_sals): Use
4380         std::move.
4381
4382 2019-04-25  Tom Tromey  <tromey@adacore.com>
4383
4384         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4385         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4386         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4387         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4388         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4389         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4390         guile/scm-value.c: Use unpack.
4391         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4392         gdbscm_gdb_exception.
4393         (gdbscm_throw_gdb_exception): Likewise.
4394         (struct gdbscm_gdb_exception): New.
4395         (unpack): New function.
4396         (gdbscm_wrap): Use unpack.
4397
4398 2019-04-25  Tom Tromey  <tromey@adacore.com>
4399
4400         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4401         (gdb_rl_callback_handler): Use std::move.
4402         * common/common-exceptions.h (struct gdb_exception): Add move
4403         assignment operator.
4404         (throw_exception_sjlj): Change "exception" to const reference.
4405         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4406         (throw_exception_sjlj): Change "exception" to const reference.
4407
4408 2019-04-25  Tom Tromey  <tromey@adacore.com>
4409
4410         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4411         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4412         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4413         Update.
4414         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4415         Update.
4416         * mi/mi-interp.c (mi_interp::exec): Update.
4417         * linespec.c (parse_linespec): Update.
4418         * infcall.c (run_inferior_call): Update.
4419         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4420         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4421         (gdbscm_lookup_global_symbol): Update.
4422         * guile/scm-param.c (gdbscm_parameter_value): Update.
4423         * guile/scm-frame.c (gdbscm_frame_read_register)
4424         (gdbscm_frame_read_var): Update.
4425         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4426         * exec.c (try_open_exec_file): Update.
4427         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4428         (gdb_rl_callback_handler): Update.
4429         * common/common-exceptions.h (exception_none): Don't declare.
4430         * common/common-exceptions.c (exception_none): Don't define.
4431         (struct catcher) <exception>: Update.
4432         * cli/cli-interp.c (safe_execute_command): Update.
4433         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4434
4435 2019-04-25  Ali Tamur  <tamur@google.com>
4436
4437         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4438         (read_attribute_value): Likewise.
4439         (dwarf2_read_addr_index): Update comment.
4440         (read_str_index): Add DW_FORM_strx.
4441         (dwarf2_string_attr): Likewise.
4442         (dwarf2_const_value_attr): Likewise.
4443         (dump_die_shallow): Likewise.
4444         (dwarf2_fetch_constant_bytes): Likewise.
4445         (skip_form_bytes): Likewise.
4446         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4447
4448 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4449
4450         PR corefiles/11608
4451         PR corefiles/18187
4452         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4453         OFFSET.  Verify if current mapping contains an ELF header.
4454         (linux_find_memory_regions_full): Adjust call to
4455         dump_mapping_p.
4456
4457 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4458             Kang Li <kanglictf@gmail.com>
4459
4460         PR gdb/21600
4461
4462         * dwarf2-frame.c (read_initial_length): Be consistent about using
4463         unsigned representation of length.
4464         (decode_frame_entry_1): Likewise.  Check for wraparound of
4465         end pointer as well as buffer overflow.
4466
4467 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4468
4469         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4470         "vq".
4471
4472 2019-04-24  Tom Tromey  <tromey@adacore.com>
4473
4474         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4475
4476 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4477
4478         * s12z-tdep.c (s12z_unwind_pc): Delete.
4479         (s12z_unwind_sp): Delete.
4480         (s12z_gdbarch_init): Don't register deleted functions with
4481         gdbarch.
4482
4483 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4484
4485         * rl78-tdep.c (rl78_unwind_sp): Delete.
4486         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4487
4488 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4489
4490         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4491         (xstormy16_unwind_pc): Delete.
4492         (xstormy16_dummy_id): Delete.
4493         (xstormy16_gdbarch_init): Don't register deleted functions with
4494         gdbarch.
4495
4496 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4497
4498         * vax-tdep.c (vax_unwind_pc): Delete.
4499         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4500
4501 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4502
4503         * v850-tdep.c (v850_unwind_sp): Delete.
4504         (v850_unwind_pc): Delete.
4505         (v850_dummy_id): Delete.
4506         (v850_gdbarch_init): Don't register deleted functions with
4507         gdbarch.
4508
4509 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4510
4511         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4512         (tilegx_unwind_pc): Delete.
4513         (tilegx_unwind_dummy_id): Delete.
4514         (tilegx_gdbarch_init): Don't register deleted functions with
4515         gdbarch.
4516
4517 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4518
4519         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4520         (tic6x_dummy_id): Delete.
4521         (tic6x_gdbarch_init): Don't register deleted functions with
4522         gdbarch.
4523
4524 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4525
4526         * sparc-tdep.c (sparc_unwind_pc): Delete.
4527         (sparc32_gdbarch_init): Don't register deleted function with
4528         gdbarch.
4529
4530 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4531
4532         * sh-tdep.c (sh_unwind_sp): Delete.
4533         (sh_unwind_pc): Delete.
4534         (sh_dummy_id): Delete.
4535         (sh_gdbarch_init): Don't register deleted functions with
4536         gdbarch.
4537
4538 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4539
4540         * score-tdep.c (score_unwind_sp): Delete.
4541         (score_unwind_pc): Delete.
4542         (score_dummy_id): Delete.
4543         (score_gdbarch_init): Don't register deleted functions with
4544         gdbarch.
4545
4546 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4547
4548         * rx-tdep.c (rx_unwind_pc): Delete.
4549         (rx_unwind_sp): Delete.
4550         (rx_dummy_id): Delete.
4551         (rx_gdbarch_init): Don't register deleted functions with
4552         gdbarch.  Update comment.
4553
4554 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4555
4556         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4557         (rs6000_dummy_id): Delete.
4558         (rs6000_gdbarch_init): Don't register deleted functions with
4559         gdbarch.
4560
4561 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4562
4563         * or1k-tdep.c (or1k_dummy_id): Delete.
4564         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4565
4566 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4567
4568         * nios2-tdep.c (nios2_dummy_id): Delete.
4569         (nios2_unwind_sp): Delete.
4570         (nios2_gdbarch_init): Don't register deleted functions with
4571         gdbarch.
4572
4573 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4574
4575         * nds32-tdep.c (nds32_dummy_id): Delete.
4576         (nds32_unwind_pc): Delete.
4577         (nds32_unwind_sp): Delete.
4578         (nds32_gdbarch_init): Don't register deleted functions with
4579         gdbarch.
4580
4581 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4582
4583         * msp430-tdep.c (msp430_unwind_pc): Delete.
4584         (msp430_unwind_sp): Delete.
4585         (msp430_dummy_id): Delete.
4586         (msp430_gdbarch_init): Don't register deleted functions with
4587         gdbarch.
4588
4589 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4590
4591         * moxie-tdep.c (moxie_unwind_sp): Delete.
4592         (moxie_unwind_pc): Delete.
4593         (moxie_dummy_id): Delete.
4594         (moxie_gdbarch_init): Don't register deleted functions with
4595         gdbarch.
4596
4597 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4598
4599         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4600         (mn10300_unwind_pc): Delete.
4601         (mn10300_unwind_sp): Delete.
4602         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4603         mn10300_unwind_sp.
4604         (mn10300_frame_unwind_init): Don't register deleted functions with
4605         gdbarch.
4606
4607 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4608
4609         * mep-tdep.c (mep_unwind_pc): Delete.
4610         (mep_unwind_sp): Delete.
4611         (mep_dummy_id): Delete.
4612         (mep_gdbarch_init): Don't register deleted functions with
4613         gdbarch.
4614
4615 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4616
4617         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4618         (m68hc11_unwind_sp): Delete.
4619         (m68hc11_gdbarch_init): Don't register deleted functions with
4620         gdbarch.
4621
4622 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4623
4624         * m32r-tdep.c (m32r_unwind_sp): Delete.
4625         (m32r_unwind_pc): Delete.
4626         (m32r_dummy_id): Delete.
4627         (m32r_gdbarch_init): Don't register deleted functions with
4628         gdbarch.
4629
4630 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4631
4632         * m32c-tdep.c (m32c_unwind_pc): Delete.
4633         (m32c_unwind_sp): Delete.
4634         (m32c_dummy_id): Delete.
4635         (m32c_gdbarch_init): Don't register deleted functions with
4636         gdbarch.
4637
4638 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4639
4640         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4641         (lm32_unwind_pc): Delete.
4642         (lm32_dummy_id): Delete.
4643         (lm32_gdbarch_init): Don't register deleted functions with
4644         gdbarch.
4645
4646 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4647
4648         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4649         (iq2000_unwind_pc): Delete.
4650         (iq2000_dummy_id): Delete.
4651         (iq2000_gdbarch_init): Don't register deleted functions with
4652         gdbarch.
4653
4654 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4655
4656         * nds32-tdep.c (nds32_type_align): Delete.
4657         (nds32_push_dummy_call): Use type_align instead.
4658
4659 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4660
4661         * arm-tdep.c (arm_type_align): Only handle vector override case.
4662         (arm_push_dummy_call): Use type_align.
4663         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4664
4665 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4666
4667         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4668         case.
4669         (pass_on_stack): Use type_align.
4670         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4671         function.
4672
4673 2019-04-23  Tom Tromey  <tromey@adacore.com>
4674
4675         * dwarf2read.c (line_header::file_name_at): Remove unused
4676         overload.
4677
4678 2019-04-23  Tom de Vries  <tdevries@suse.de>
4679
4680         PR gdb/24438
4681         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4682         invocation.
4683
4684
4685 2019-03-27  Ali Tamur  <tamur@google.com>
4686
4687         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4688         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4689         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4690         (dwarf_expr_context::get_addr_index): Likewise
4691         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4692         (symbol_needs_eval_context::get_addr_index): Likewise
4693         (disassemble_dwarf_expression): Add DW_OP_addrx
4694         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4695         (read_cutu_die_from_dwo): Update comment
4696         (skip_one_die): Add DW_FORM_addrx
4697         (read_attribute_value): Likewise
4698         (var_decode_location): Add DW_OP_addrx
4699         (dwarf2_const_value_attr): Add DW_FORM_addrx
4700         (dump_die_shallow): Likewise
4701         (dwarf2_fetch_constant_bytes): Likewise
4702         (decode_locdesc): Add DW_OP_addrx
4703         (skip_form_bytes): Add DW_FORM_addrx
4704
4705 2019-04-22  Ali Tamur  <tamur@google.com>
4706
4707         * MAINTAINERS (Write After Approval): Add self.
4708
4709 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4710
4711         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4712         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4713         (open_symbol_file_object): Likewise.
4714         (svr4_default_sos): Add info parameter.
4715         (svr4_read_so_list): Likewise.
4716         (svr4_current_sos_direct): Adjust functions calls to pass down
4717         info.
4718         (svr4_current_sos_1): Add info parameter.
4719         (svr4_current_sos): Call get_svr4_info, pass info down to
4720         svr4_current_sos_1.
4721         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4722         get_svr4_info.
4723         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4724         get_svr4_info.
4725         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4726         to get_svr4_info.
4727         (probes_table_remove_objfile_probes): Likewise.
4728         (register_solib_event_probe): Add info parameter.
4729         (solist_update_incremental): Pass info parameter down to
4730         svr4_read_so_list.
4731         (disable_probes_interface): Add info parameter.
4732         (svr4_handle_solib_event): Pass current_program_space to
4733         get_svr4_info.  Adjust disable_probes_interface cleanup.
4734         (svr4_create_probe_breakpoints): Add info parameter, pass it
4735         down to register_solib_event_probe.
4736         (svr4_create_solib_event_breakpoints): Add info parameter,
4737         pass it down to svr4_create_probe_breakpoints.
4738         (enable_break): Pass info down to
4739         svr4_create_solib_event_breakpoints.
4740         (svr4_solib_create_inferior_hook): Pass current_program_space to
4741         get_svr4_info.
4742         (svr4_clear_solib): Likewise.
4743
4744 2019-04-22  Pedro Alves  <palves@redhat.com>
4745
4746         * solib-svr4.c (svr4_free_objfile_observer): New.
4747         (probe_and_action::objfile): New field.
4748         (probes_table_htab_remove_objfile_probes)
4749         (probes_table_remove_objfile_probes): New functions.
4750         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4751         in the new probe_and_action.  Don't store the probe in 'lookup'.
4752         (svr4_create_probe_breakpoints): Pass objfile to
4753         register_solib_event_probe.
4754         (_initialize_svr4_solib): Register a free_objfile observer.
4755
4756 2019-04-19  Tom Tromey  <tom@tromey.com>
4757
4758         * common/queue.h: Remove.
4759
4760 2019-04-19  Tom Tromey  <tom@tromey.com>
4761
4762         * event-loop.c: Don't include "common/queue.h".
4763
4764 2019-04-19  Tom Tromey  <tom@tromey.com>
4765
4766         * remote.c (remote_target): Use delete.
4767         * remote-notif.h: Include <list>, not "common/queue.h".
4768         (notif_client_p): Remove typedef.
4769         (remote_notif_state): Add constructor, destructor, initializer.
4770         <notif_queue>: Now a std::list.
4771         (remote_notif_state_xfree): Don't declare.
4772         * remote-notif.c (remote_notif_process, handle_notification)
4773         (remote_notif_state_allocate): Update.
4774         (~remote_notif_state): Rename from remote_notif_state_xfree.
4775
4776 2019-04-19  Tom Tromey  <tom@tromey.com>
4777
4778         * symfile.c (reread_symbols): Update.
4779         * objfiles.c (objfile_register_static_link)
4780         (objfile_lookup_static_link): Update
4781         (~objfile) Don't delete static_links.
4782         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4783
4784 2019-04-19  Tom Tromey  <tom@tromey.com>
4785
4786         * type-stack.h (struct type_stack) <insert>: Constify string.
4787         * type-stack.c (type_stack::insert): Constify string.
4788         * gdbtypes.h (lookup_template_type): Update.
4789         (address_space_name_to_int): Update.
4790         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4791         const.
4792         (lookup_template_type): Make name const.
4793         * c-exp.y: Update rules.
4794         (lex_one_token, classify_name, classify_inner_name)
4795         (c_print_token): Update.
4796         * p-exp.y: Update rules.
4797         (yylex): Update.
4798         * f-exp.y: Update rules.
4799         (yylex): Update.
4800         * d-exp.y: Update rules.
4801         (lex_one_token, classify_name, classify_inner_name): Update.
4802         * parse.c (write_dollar_variable, copy_name): Return std::string.
4803         * parser-defs.h (copy_name): Change return type.
4804         * m2-exp.y: Update rules.
4805         (yylex): Update.
4806         * go-exp.y (lex_one_token): Update.
4807         Update rules.
4808         (classify_unsafe_function, classify_packaged_name)
4809         (classify_name, yylex): Update.
4810
4811 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4812
4813         * configure.ac: add --enable-source-highlight switch.
4814         * configure: Regenerate.
4815         * top.c (print_gdb_version): plumb --enable-source-highlight
4816         status to "show configuration".
4817
4818 2019-04-19  Tom Tromey  <tromey@adacore.com>
4819
4820         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4821         Check ADA_TYPE_P.
4822         (empty_record, ada_template_to_fixed_record_type_1)
4823         (template_to_static_fixed_type)
4824         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4825         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4826         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4827         macros.
4828
4829 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4830
4831         PR symtab/24423:
4832         * source.c (print_source_lines_base): Advance "iter" when a
4833         control character is seen.
4834
4835 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4836
4837         * inferior.h (struct infcall_suspend_state_deleter):
4838         Catch exception in destructor to avoid crash.
4839
4840 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4841
4842         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4843         close to the add_com "shell".
4844
4845 2019-04-18  Tom Tromey  <tromey@adacore.com>
4846
4847         * process-stratum-target.h (class process_stratum_target)
4848         <stratum>: Add "final".
4849
4850 2019-04-17  Tom Tromey  <tromey@adacore.com>
4851
4852         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4853         against nullptr before use.
4854
4855 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4856
4857         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4858
4859 2019-04-17  Jim Wilson  <jimw@sifive.com>
4860             Andrew Burgess  <andrew.burgess@embecosm.com>
4861
4862         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4863         code read might fail, assume 4-byte breakpoint in that case.
4864
4865 2019-04-15  Leszek Swirski  <leszeks@google.com>
4866
4867         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4868         rather than a hand-rolled POD check when checking for forced MEMORY
4869         classification.
4870
4871 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4872
4873         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4874         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4875         function.
4876         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4877         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4878         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4879         declaration.
4880
4881 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4882
4883         * aarch64-linux-nat.c
4884         (aarch64_linux_nat_target::thread_architecture): Add override.
4885         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4886         each VQ.
4887
4888 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4889
4890         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4891
4892 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4893
4894         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4895         target types of size 96-bits, add some additional comments, and
4896         check that the builtin type we found was the correct size.
4897
4898 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4899
4900         * utils.c (prompt_for_continue): Don't restore the styling at the
4901         end, as applied_style has the wrong value.  This fixes styling in
4902         long lists of file names that are interrupted by the "Continue?"
4903         prompt.
4904
4905 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4906
4907         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4908         * c-lang.c (c_language_defn): Likewise.
4909         (cplus_language_defn): Likewise.
4910         (asm_language_defn): Likewise.
4911         (minimal_language_defn): Likewise.
4912         * d-lang.c (d_language_defn): Likewise.
4913         * f-lang.c (f_language_defn): Likewise.
4914         * go-lang.c (go_language_defn): Likewise.
4915         * language.c (unknown_language_defn): Likewise.
4916         (auto_language_defn): Likewise.
4917         * language.h (struct language_defn): Remove la_magic field.
4918         (LANG_MAGIC): Delete.
4919         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4920         * objc-lang.c (objc_language_defn): Likewise.
4921         * opencl-lang.c (opencl_language_defn): Likewise.
4922         * p-lang.c (pascal_language_defn): Likewise.
4923         * rust-lang.c (rust_language_defn): Likewise.
4924
4925 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4926
4927         * riscv-tdep.c (riscv_type_align): New function.
4928         (riscv_type_alignment): Delete.
4929         (riscv_arg_location): Use 'type_align'.
4930         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4931
4932 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4933
4934         * gdbtypes.c (type_align): A struct with no non-static fields also
4935         has alignment of 1.
4936
4937 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4938
4939         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4940         component to 0.
4941         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4942         member.
4943         (riscv_struct_info::analyse): New implementation using new
4944         analyse_inner member function.
4945         (riscv_struct_info::field_offset): New member function.
4946         (riscv_struct_info::m_offsets): New member variable.
4947         (riscv_struct_info::analyse_inner): New private member function,
4948         takes the old implementation of riscv_struct_info::analyse but
4949         extended to track field offsets.
4950         (riscv_call_arg_struct): Update the struct folding special cases
4951         to handle cases where empty C++ structs, which are non-zero
4952         length, are found.
4953         (riscv_arg_location): Initialise the length of each location, a
4954         non-zero length now indicates the location is in use.
4955         (riscv_push_dummy_call): Allow for the first location having a
4956         non-zero offset when setting up arguments.
4957         (riscv_return_value): Likewise, but for return values.
4958
4959 2019-04-11  Tom Tromey  <tromey@adacore.com>
4960
4961         * utils.c (internal_vproblem): Make "msg" const.
4962
4963 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4964
4965         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4966         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4967         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4968         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4969
4970 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4971
4972         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4973         function.
4974         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4975         of amd64_collect_native_gregset.
4976         (amd64_linux_nat_target::store_registers): Likewise.
4977
4978 2019-04-10  Tom Tromey  <tom@tromey.com>
4979
4980         * symtab.c (lookup_global_symbol_from_objfile)
4981         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4982         * objfiles.h (class separate_debug_iterator): New.
4983         (class separate_debug_range): New.
4984         (struct objfile) <separate_debug_objfiles>: New method.
4985         (objfile_separate_debug_iterate): Don't declare.
4986         * objfiles.c (separate_debug_iterator::operator++): Rename from
4987         objfile_separate_debug_iterate.
4988         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4989         iterator.
4990         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4991         iterator.
4992
4993 2019-04-10  Tom Tromey  <tom@tromey.com>
4994
4995         * symfile.c (reread_symbols): Remove old comment.
4996         * objfiles.c (free_all_objfiles): Fix a typo.
4997
4998 2019-04-10  Tom Tromey  <tom@tromey.com>
4999
5000         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5001         * minsyms.c (lookup_minimal_symbol): Use foreach.
5002         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5003         (lookup_minimal_symbol_solib_trampoline): Likewise.
5004         * symfile.c (reread_symbols): Use foreach.
5005
5006 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5007             Tom Tromey  <tromey@adacore.com>
5008
5009         PR rust/24414:
5010         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5011         (rust_lex_int_test): Change "value" to be LONGEST.
5012         (rust_lex_tests): Add test for long integer literal.
5013
5014 2019-04-09  Tom Tromey  <tromey@adacore.com>
5015
5016         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5017         to bool.
5018         (extended_remote_target::attach): Update.
5019         (remote_target::remote_notice_new_inferior): Update.
5020         (remote_target::add_current_inferior_and_thread): Update.
5021         * inferior.c (exit_inferior_1): Use "false".
5022         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5023
5024 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5025
5026         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5027         the "start" command.
5028
5029 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5030
5031         * python/py-inferior.c (infpy_thread_from_thread_handle):
5032         Adjust comments to reflect renaming of thread_from_thread_handle
5033         to thread_from_handle.  Adjust keywords.  Fix type error message.
5034         (inferior_object_methods): Add thread_from_handle.  Retain
5035         thread_from_thread_handle, but mark it as deprecated.
5036
5037 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5038
5039         * gdbthread.h (find_thread_by_handle): Revise declaration.
5040         * thread.c (find_thread_by_handle): Likewise.  Adjust
5041         implementation too.
5042         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5043         support for buffer objects as handles.
5044
5045 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5046
5047         * python/py-infthread.c (thpy_thread_handle): New function.
5048         (thread_object_methods): Register thpy_thread_handle.
5049
5050 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5051
5052         * gdbthread.h (thread_to_thread_handle): Declare.
5053         * thread.c (gdbtypes.h): Include.
5054         (thread_to_thread_handle): New function.
5055
5056         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5057         (target_thread_info_to_thread_handle): Declare.
5058         * target.c (target_thread_info_to_thread_handle): New function.
5059         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5060         * target-delegates.c: Regenerate.
5061
5062         * linux-thread-db.c (class thread_db_target): Add method
5063         thread_info_to_thread_handle.
5064         (thread_db_target::thread_info_to_thread_handle): Define.
5065         * remote.c (class remote_target): Add new method
5066         thread_info_to_thread_handle.
5067         (remote_target::thread_info_to_thread_handle): Define.
5068
5069 2019-04-08  Pedro Alves  <palves@redhat.com>
5070
5071         * common/common-exceptions.c (throw_exception): Don't create
5072         named object to throw; throw directly.
5073         (throw_it): Likewise.  Don't initialize gdb_exception::message
5074         here, with new; pass FMT and AP to the ctor instead.
5075         * common/common-exceptions.h: Include <string>.
5076         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5077         const char *, va_list)): New ctor.  Use std::make_shared.
5078         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5079         errors)): Delete.
5080         (gdb_exception_error::gdb_exception_error(enum errors, const char
5081         *, va_list)): New.
5082         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5083         Add assertion.
5084         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5085         errors)): Delete.
5086         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5087         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5088         Add assertion.
5089
5090 2019-04-08  Tom Tromey  <tom@tromey.com>
5091
5092         * valops.c (value_rtti_indirect_type): Replace throw_exception
5093         with throw.
5094         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5095         with throw.
5096         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5097         throw.
5098         * target.c (target_translate_tls_address): Replace throw_exception
5099         with throw.
5100         * stack.c (frame_apply_command_count): Replace throw_exception
5101         with throw.
5102         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5103         throw.
5104         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5105         with throw.
5106         * rs6000-tdep.c (rs6000_frame_cache)
5107         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5108         * remote.c: Replace throw_exception with throw.
5109         * record-full.c (record_full_message, record_full_wait_1)
5110         (record_full_restore): Replace throw_exception with throw.
5111         * record-btrace.c:
5112         (get_thread_current_frame_id, record_btrace_start_replaying)
5113         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5114         (cmd_record_btrace_start): Replace throw_exception with throw.
5115         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5116         throw.
5117         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5118         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5119         * linespec.c:
5120         (find_linespec_symbols): Replace throw_exception with throw.
5121         * infrun.c (displaced_step_prepare, resume): Replace
5122         throw_exception with throw.
5123         * infcmd.c (post_create_inferior): Replace throw_exception with
5124         throw.
5125         * inf-loop.c (inferior_event_handler): Replace throw_exception
5126         with throw.
5127         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5128         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5129         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5130         (get_prev_frame_always, get_frame_pc_if_available)
5131         (get_frame_address_in_block_if_available, get_frame_language):
5132         Replace throw_exception with throw.
5133         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5134         throw_exception with throw.
5135         * eval.c (fetch_subexp_value, evaluate_var_value)
5136         (evaluate_funcall, evaluate_subexp_standard): Replace
5137         throw_exception with throw.
5138         * dwarf2loc.c (call_site_find_chain)
5139         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5140         Replace throw_exception with throw.
5141         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5142         with throw.
5143         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5144         throw.
5145         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5146         * completer.c (complete_line_internal): Replace throw_exception
5147         with throw.
5148         * compile/compile-object-run.c (compile_object_run): Replace
5149         throw_exception with throw.
5150         * cli/cli-script.c (process_next_line): Replace throw_exception
5151         with throw.
5152         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5153         (btrace_enable, btrace_maint_update_pt_packets): Replace
5154         throw_exception with throw.
5155         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5156         throw_exception with throw.
5157         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5158         throw_exception with throw.
5159         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5160         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5161         * aarch64-tdep.c (aarch64_make_prologue_cache)
5162         (aarch64_make_stub_cache): Replace throw_exception with throw.
5163
5164 2019-04-08  Tom Tromey  <tom@tromey.com>
5165
5166         * common/common-exceptions.c (throw_exception): Rename from
5167         throw_exception_cxx.  Remove old copy.  Make argument const.
5168         (throw_it): Create and throw exception objects directly.
5169         * common/common-exceptions.h (throw_exception): Make argument
5170         const.
5171         (struct gdb_exception_error): Add constructor.
5172         (struct gdb_exception_quit): Add constructor.
5173
5174 2019-04-08  Tom Tromey  <tom@tromey.com>
5175
5176         * common/common-exceptions.h (exception_rethrow): Don't declare.
5177         (TRY_SJLJ): Update comment.
5178         (TRY, CATCH, END_CATCH): Remove.
5179         * common/common-exceptions.c (exception_rethrow): Remove.
5180
5181 2019-04-08  Tom Tromey  <tom@tromey.com>
5182
5183         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5184         Remove.
5185         (gdb_exception_error): Rename from
5186         gdb_exception_RETURN_MASK_ERROR.
5187         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5188         (gdb_quit_bad_alloc): Update.
5189         * aarch64-tdep.c: Update.
5190         * ada-lang.c: Update.
5191         * ada-typeprint.c: Update.
5192         * ada-valprint.c: Update.
5193         * amd64-tdep.c: Update.
5194         * arch-utils.c: Update.
5195         * break-catch-throw.c: Update.
5196         * breakpoint.c: Update.
5197         * btrace.c: Update.
5198         * c-varobj.c: Update.
5199         * cli/cli-cmds.c: Update.
5200         * cli/cli-interp.c: Update.
5201         * cli/cli-script.c: Update.
5202         * common/common-exceptions.c: Update.
5203         * common/new-op.c: Update.
5204         * common/selftest.c: Update.
5205         * compile/compile-c-symbols.c: Update.
5206         * compile/compile-cplus-symbols.c: Update.
5207         * compile/compile-object-load.c: Update.
5208         * compile/compile-object-run.c: Update.
5209         * completer.c: Update.
5210         * corelow.c: Update.
5211         * cp-abi.c: Update.
5212         * cp-support.c: Update.
5213         * cp-valprint.c: Update.
5214         * darwin-nat.c: Update.
5215         * disasm-selftests.c: Update.
5216         * dtrace-probe.c: Update.
5217         * dwarf-index-cache.c: Update.
5218         * dwarf-index-write.c: Update.
5219         * dwarf2-frame-tailcall.c: Update.
5220         * dwarf2-frame.c: Update.
5221         * dwarf2loc.c: Update.
5222         * dwarf2read.c: Update.
5223         * eval.c: Update.
5224         * event-loop.c: Update.
5225         * event-top.c: Update.
5226         * exec.c: Update.
5227         * f-valprint.c: Update.
5228         * fbsd-tdep.c: Update.
5229         * frame-unwind.c: Update.
5230         * frame.c: Update.
5231         * gdbtypes.c: Update.
5232         * gnu-v3-abi.c: Update.
5233         * guile/guile-internal.h: Update.
5234         * guile/scm-block.c: Update.
5235         * guile/scm-breakpoint.c: Update.
5236         * guile/scm-cmd.c: Update.
5237         * guile/scm-disasm.c: Update.
5238         * guile/scm-frame.c: Update.
5239         * guile/scm-lazy-string.c: Update.
5240         * guile/scm-math.c: Update.
5241         * guile/scm-param.c: Update.
5242         * guile/scm-ports.c: Update.
5243         * guile/scm-pretty-print.c: Update.
5244         * guile/scm-symbol.c: Update.
5245         * guile/scm-symtab.c: Update.
5246         * guile/scm-type.c: Update.
5247         * guile/scm-value.c: Update.
5248         * i386-linux-tdep.c: Update.
5249         * i386-tdep.c: Update.
5250         * inf-loop.c: Update.
5251         * infcall.c: Update.
5252         * infcmd.c: Update.
5253         * infrun.c: Update.
5254         * jit.c: Update.
5255         * language.c: Update.
5256         * linespec.c: Update.
5257         * linux-fork.c: Update.
5258         * linux-nat.c: Update.
5259         * linux-tdep.c: Update.
5260         * linux-thread-db.c: Update.
5261         * main.c: Update.
5262         * mi/mi-cmd-break.c: Update.
5263         * mi/mi-cmd-stack.c: Update.
5264         * mi/mi-interp.c: Update.
5265         * mi/mi-main.c: Update.
5266         * objc-lang.c: Update.
5267         * p-valprint.c: Update.
5268         * parse.c: Update.
5269         * ppc-linux-tdep.c: Update.
5270         * printcmd.c: Update.
5271         * python/py-arch.c: Update.
5272         * python/py-breakpoint.c: Update.
5273         * python/py-cmd.c: Update.
5274         * python/py-finishbreakpoint.c: Update.
5275         * python/py-frame.c: Update.
5276         * python/py-framefilter.c: Update.
5277         * python/py-gdb-readline.c: Update.
5278         * python/py-inferior.c: Update.
5279         * python/py-infthread.c: Update.
5280         * python/py-lazy-string.c: Update.
5281         * python/py-linetable.c: Update.
5282         * python/py-objfile.c: Update.
5283         * python/py-param.c: Update.
5284         * python/py-prettyprint.c: Update.
5285         * python/py-progspace.c: Update.
5286         * python/py-record-btrace.c: Update.
5287         * python/py-record.c: Update.
5288         * python/py-symbol.c: Update.
5289         * python/py-type.c: Update.
5290         * python/py-unwind.c: Update.
5291         * python/py-utils.c: Update.
5292         * python/py-value.c: Update.
5293         * python/python.c: Update.
5294         * record-btrace.c: Update.
5295         * record-full.c: Update.
5296         * remote-fileio.c: Update.
5297         * remote.c: Update.
5298         * riscv-tdep.c: Update.
5299         * rs6000-aix-tdep.c: Update.
5300         * rs6000-tdep.c: Update.
5301         * rust-exp.y: Update.
5302         * rust-lang.c: Update.
5303         * s390-tdep.c: Update.
5304         * selftest-arch.c: Update.
5305         * solib-dsbt.c: Update.
5306         * solib-frv.c: Update.
5307         * solib-spu.c: Update.
5308         * solib-svr4.c: Update.
5309         * solib.c: Update.
5310         * sparc64-linux-tdep.c: Update.
5311         * stack.c: Update.
5312         * symfile-mem.c: Update.
5313         * symmisc.c: Update.
5314         * target.c: Update.
5315         * thread.c: Update.
5316         * top.c: Update.
5317         * tracefile-tfile.c: Update.
5318         * tui/tui.c: Update.
5319         * typeprint.c: Update.
5320         * unittests/cli-utils-selftests.c: Update.
5321         * unittests/parse-connection-spec-selftests.c: Update.
5322         * valops.c: Update.
5323         * valprint.c: Update.
5324         * value.c: Update.
5325         * varobj.c: Update.
5326         * windows-nat.c: Update.
5327         * x86-linux-nat.c: Update.
5328         * xml-support.c: Update.
5329
5330 2019-04-08  Tom Tromey  <tom@tromey.com>
5331
5332         * xml-support.c: Use C++ exception handling.
5333         * x86-linux-nat.c: Use C++ exception handling.
5334         * windows-nat.c: Use C++ exception handling.
5335         * varobj.c: Use C++ exception handling.
5336         * value.c: Use C++ exception handling.
5337         * valprint.c: Use C++ exception handling.
5338         * valops.c: Use C++ exception handling.
5339         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5340         handling.
5341         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5342         * typeprint.c: Use C++ exception handling.
5343         * tui/tui.c: Use C++ exception handling.
5344         * tracefile-tfile.c: Use C++ exception handling.
5345         * top.c: Use C++ exception handling.
5346         * thread.c: Use C++ exception handling.
5347         * target.c: Use C++ exception handling.
5348         * symmisc.c: Use C++ exception handling.
5349         * symfile-mem.c: Use C++ exception handling.
5350         * stack.c: Use C++ exception handling.
5351         * sparc64-linux-tdep.c: Use C++ exception handling.
5352         * solib.c: Use C++ exception handling.
5353         * solib-svr4.c: Use C++ exception handling.
5354         * solib-spu.c: Use C++ exception handling.
5355         * solib-frv.c: Use C++ exception handling.
5356         * solib-dsbt.c: Use C++ exception handling.
5357         * selftest-arch.c: Use C++ exception handling.
5358         * s390-tdep.c: Use C++ exception handling.
5359         * rust-lang.c: Use C++ exception handling.
5360         * rust-exp.y: Use C++ exception handling.
5361         * rs6000-tdep.c: Use C++ exception handling.
5362         * rs6000-aix-tdep.c: Use C++ exception handling.
5363         * riscv-tdep.c: Use C++ exception handling.
5364         * remote.c: Use C++ exception handling.
5365         * remote-fileio.c: Use C++ exception handling.
5366         * record-full.c: Use C++ exception handling.
5367         * record-btrace.c: Use C++ exception handling.
5368         * python/python.c: Use C++ exception handling.
5369         * python/py-value.c: Use C++ exception handling.
5370         * python/py-utils.c: Use C++ exception handling.
5371         * python/py-unwind.c: Use C++ exception handling.
5372         * python/py-type.c: Use C++ exception handling.
5373         * python/py-symbol.c: Use C++ exception handling.
5374         * python/py-record.c: Use C++ exception handling.
5375         * python/py-record-btrace.c: Use C++ exception handling.
5376         * python/py-progspace.c: Use C++ exception handling.
5377         * python/py-prettyprint.c: Use C++ exception handling.
5378         * python/py-param.c: Use C++ exception handling.
5379         * python/py-objfile.c: Use C++ exception handling.
5380         * python/py-linetable.c: Use C++ exception handling.
5381         * python/py-lazy-string.c: Use C++ exception handling.
5382         * python/py-infthread.c: Use C++ exception handling.
5383         * python/py-inferior.c: Use C++ exception handling.
5384         * python/py-gdb-readline.c: Use C++ exception handling.
5385         * python/py-framefilter.c: Use C++ exception handling.
5386         * python/py-frame.c: Use C++ exception handling.
5387         * python/py-finishbreakpoint.c: Use C++ exception handling.
5388         * python/py-cmd.c: Use C++ exception handling.
5389         * python/py-breakpoint.c: Use C++ exception handling.
5390         * python/py-arch.c: Use C++ exception handling.
5391         * printcmd.c: Use C++ exception handling.
5392         * ppc-linux-tdep.c: Use C++ exception handling.
5393         * parse.c: Use C++ exception handling.
5394         * p-valprint.c: Use C++ exception handling.
5395         * objc-lang.c: Use C++ exception handling.
5396         * mi/mi-main.c: Use C++ exception handling.
5397         * mi/mi-interp.c: Use C++ exception handling.
5398         * mi/mi-cmd-stack.c: Use C++ exception handling.
5399         * mi/mi-cmd-break.c: Use C++ exception handling.
5400         * main.c: Use C++ exception handling.
5401         * linux-thread-db.c: Use C++ exception handling.
5402         * linux-tdep.c: Use C++ exception handling.
5403         * linux-nat.c: Use C++ exception handling.
5404         * linux-fork.c: Use C++ exception handling.
5405         * linespec.c: Use C++ exception handling.
5406         * language.c: Use C++ exception handling.
5407         * jit.c: Use C++ exception handling.
5408         * infrun.c: Use C++ exception handling.
5409         * infcmd.c: Use C++ exception handling.
5410         * infcall.c: Use C++ exception handling.
5411         * inf-loop.c: Use C++ exception handling.
5412         * i386-tdep.c: Use C++ exception handling.
5413         * i386-linux-tdep.c: Use C++ exception handling.
5414         * guile/scm-value.c: Use C++ exception handling.
5415         * guile/scm-type.c: Use C++ exception handling.
5416         * guile/scm-symtab.c: Use C++ exception handling.
5417         * guile/scm-symbol.c: Use C++ exception handling.
5418         * guile/scm-pretty-print.c: Use C++ exception handling.
5419         * guile/scm-ports.c: Use C++ exception handling.
5420         * guile/scm-param.c: Use C++ exception handling.
5421         * guile/scm-math.c: Use C++ exception handling.
5422         * guile/scm-lazy-string.c: Use C++ exception handling.
5423         * guile/scm-frame.c: Use C++ exception handling.
5424         * guile/scm-disasm.c: Use C++ exception handling.
5425         * guile/scm-cmd.c: Use C++ exception handling.
5426         * guile/scm-breakpoint.c: Use C++ exception handling.
5427         * guile/scm-block.c: Use C++ exception handling.
5428         * guile/guile-internal.h: Use C++ exception handling.
5429         * gnu-v3-abi.c: Use C++ exception handling.
5430         * gdbtypes.c: Use C++ exception handling.
5431         * frame.c: Use C++ exception handling.
5432         * frame-unwind.c: Use C++ exception handling.
5433         * fbsd-tdep.c: Use C++ exception handling.
5434         * f-valprint.c: Use C++ exception handling.
5435         * exec.c: Use C++ exception handling.
5436         * event-top.c: Use C++ exception handling.
5437         * event-loop.c: Use C++ exception handling.
5438         * eval.c: Use C++ exception handling.
5439         * dwarf2read.c: Use C++ exception handling.
5440         * dwarf2loc.c: Use C++ exception handling.
5441         * dwarf2-frame.c: Use C++ exception handling.
5442         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5443         * dwarf-index-write.c: Use C++ exception handling.
5444         * dwarf-index-cache.c: Use C++ exception handling.
5445         * dtrace-probe.c: Use C++ exception handling.
5446         * disasm-selftests.c: Use C++ exception handling.
5447         * darwin-nat.c: Use C++ exception handling.
5448         * cp-valprint.c: Use C++ exception handling.
5449         * cp-support.c: Use C++ exception handling.
5450         * cp-abi.c: Use C++ exception handling.
5451         * corelow.c: Use C++ exception handling.
5452         * completer.c: Use C++ exception handling.
5453         * compile/compile-object-run.c: Use C++ exception handling.
5454         * compile/compile-object-load.c: Use C++ exception handling.
5455         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5456         * compile/compile-c-symbols.c: Use C++ exception handling.
5457         * common/selftest.c: Use C++ exception handling.
5458         * common/new-op.c: Use C++ exception handling.
5459         * cli/cli-script.c: Use C++ exception handling.
5460         * cli/cli-interp.c: Use C++ exception handling.
5461         * cli/cli-cmds.c: Use C++ exception handling.
5462         * c-varobj.c: Use C++ exception handling.
5463         * btrace.c: Use C++ exception handling.
5464         * breakpoint.c: Use C++ exception handling.
5465         * break-catch-throw.c: Use C++ exception handling.
5466         * arch-utils.c: Use C++ exception handling.
5467         * amd64-tdep.c: Use C++ exception handling.
5468         * ada-valprint.c: Use C++ exception handling.
5469         * ada-typeprint.c: Use C++ exception handling.
5470         * ada-lang.c: Use C++ exception handling.
5471         * aarch64-tdep.c: Use C++ exception handling.
5472
5473 2019-04-08  Tom Tromey  <tom@tromey.com>
5474
5475         * xml-support.c (gdb_xml_parser::parse): Update.
5476         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5477         * value.c (show_convenience): Update.
5478         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5479         (test_parse_flags_qcs): Update.
5480         * thread.c (thr_try_catch_cmd): Update.
5481         * target.c (target_translate_tls_address): Update.
5482         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5483         (info_frame_command_core, frame_apply_command_count): Update.
5484         * rust-exp.y (rust_lex_exception_test): Update.
5485         * riscv-tdep.c (riscv_print_one_register_info): Update.
5486         * remote.c (remote_target::enable_btrace): Update.
5487         * record-btrace.c (record_btrace_enable_warn): Update.
5488         * python/py-utils.c (gdbpy_convert_exception): Update.
5489         * printcmd.c (do_one_display, print_variable_and_value): Update.
5490         * mi/mi-main.c (mi_print_exception): Update.
5491         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5492         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5493         * linux-nat.c (linux_nat_target::attach): Update.
5494         * linux-fork.c (class scoped_switch_fork_info): Update.
5495         * infrun.c (displaced_step_prepare): Update.
5496         * infcall.c (call_function_by_hand_dummy): Update.
5497         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5498         * gnu-v3-abi.c (print_one_vtable): Update.
5499         * frame.c (get_prev_frame_always): Update.
5500         * f-valprint.c (info_common_command_for_block): Update.
5501         * exec.c (try_open_exec_file): Update.
5502         * exceptions.c (print_exception, exception_print)
5503         (exception_fprintf, exception_print_same): Update.
5504         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5505         * dwarf-index-cache.c (index_cache::store)
5506         (index_cache::lookup_gdb_index): Update.
5507         * darwin-nat.c (maybe_cache_shell): Update.
5508         * cp-valprint.c (cp_print_value_fields): Update.
5509         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5510         (gcc_cplus_symbol_address): Update.
5511         * compile/compile-c-symbols.c (gcc_convert_symbol)
5512         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5513         * common/selftest.c: Update.
5514         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5515         a std::string.
5516         (exception_try_scope_entry, exception_try_scope_exit): Don't
5517         declare.
5518         (struct exception_try_scope): Remove.
5519         (TRY): Don't use exception_try_scope.
5520         (struct gdb_exception): Add constructor, operator=.
5521         <what>: New method.
5522         (struct gdb_exception_RETURN_MASK_ALL)
5523         (struct gdb_exception_RETURN_MASK_ERROR)
5524         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5525         (struct gdb_quit_bad_alloc): Update.
5526         * common/common-exceptions.c (exception_none): Change
5527         initializer.
5528         (struct catcher) <state, exception>: Initialize inline.
5529         <prev>: Remove member.
5530         (current_catcher): Remove.
5531         (catchers): New global.
5532         (exceptions_state_mc_init): Simplify.
5533         (catcher_pop): Remove.
5534         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5535         (try_scope_depth, exception_try_scope_entry)
5536         (exception_try_scope_exit): Remove.
5537         (throw_exception_sjlj): Update.
5538         (exception_messages, exception_messages_size): Remove.
5539         (throw_it): Simplify.
5540         (gdb_exception_sliced_copy): Remove.
5541         (throw_exception_cxx): Update.
5542         * cli/cli-script.c (script_from_file): Update.
5543         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5544         Update.
5545         * ada-valprint.c (ada_val_print): Update.
5546         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5547         (create_excep_cond_exprs): Update.
5548
5549 2019-04-08  Tom Tromey  <tom@tromey.com>
5550
5551         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5552         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5553         (TRY, CATCH, END_CATCH): Remove some definitions.
5554         * common/common-exceptions.c: Don't use GDB_XCPT.
5555         (catcher_list_size): Remove.
5556         (throw_exception, throw_it): Simplify.
5557
5558 2019-04-05  Tom Tromey  <tom@tromey.com>
5559
5560         Revert the header-sorting patch.
5561         * ft32-tdep.c: Revert.
5562         * frv-tdep.c: Revert.
5563         * frv-linux-tdep.c: Revert.
5564         * frame.c: Revert.
5565         * frame-unwind.c: Revert.
5566         * frame-base.c: Revert.
5567         * fork-child.c: Revert.
5568         * findvar.c: Revert.
5569         * findcmd.c: Revert.
5570         * filesystem.c: Revert.
5571         * filename-seen-cache.h: Revert.
5572         * filename-seen-cache.c: Revert.
5573         * fbsd-tdep.c: Revert.
5574         * fbsd-nat.h: Revert.
5575         * fbsd-nat.c: Revert.
5576         * f-valprint.c: Revert.
5577         * f-typeprint.c: Revert.
5578         * f-lang.c: Revert.
5579         * extension.h: Revert.
5580         * extension.c: Revert.
5581         * extension-priv.h: Revert.
5582         * expprint.c: Revert.
5583         * exec.h: Revert.
5584         * exec.c: Revert.
5585         * exceptions.c: Revert.
5586         * event-top.c: Revert.
5587         * event-loop.c: Revert.
5588         * eval.c: Revert.
5589         * elfread.c: Revert.
5590         * dwarf2read.h: Revert.
5591         * dwarf2read.c: Revert.
5592         * dwarf2loc.c: Revert.
5593         * dwarf2expr.h: Revert.
5594         * dwarf2expr.c: Revert.
5595         * dwarf2-frame.c: Revert.
5596         * dwarf2-frame-tailcall.c: Revert.
5597         * dwarf-index-write.h: Revert.
5598         * dwarf-index-write.c: Revert.
5599         * dwarf-index-common.c: Revert.
5600         * dwarf-index-cache.h: Revert.
5601         * dwarf-index-cache.c: Revert.
5602         * dummy-frame.c: Revert.
5603         * dtrace-probe.c: Revert.
5604         * disasm.h: Revert.
5605         * disasm.c: Revert.
5606         * disasm-selftests.c: Revert.
5607         * dictionary.c: Revert.
5608         * dicos-tdep.c: Revert.
5609         * demangle.c: Revert.
5610         * dcache.h: Revert.
5611         * dcache.c: Revert.
5612         * darwin-nat.h: Revert.
5613         * darwin-nat.c: Revert.
5614         * darwin-nat-info.c: Revert.
5615         * d-valprint.c: Revert.
5616         * d-namespace.c: Revert.
5617         * d-lang.c: Revert.
5618         * ctf.c: Revert.
5619         * csky-tdep.c: Revert.
5620         * csky-linux-tdep.c: Revert.
5621         * cris-tdep.c: Revert.
5622         * cris-linux-tdep.c: Revert.
5623         * cp-valprint.c: Revert.
5624         * cp-support.c: Revert.
5625         * cp-namespace.c: Revert.
5626         * cp-abi.c: Revert.
5627         * corelow.c: Revert.
5628         * corefile.c: Revert.
5629         * continuations.c: Revert.
5630         * completer.h: Revert.
5631         * completer.c: Revert.
5632         * complaints.c: Revert.
5633         * coffread.c: Revert.
5634         * coff-pe-read.c: Revert.
5635         * cli-out.h: Revert.
5636         * cli-out.c: Revert.
5637         * charset.c: Revert.
5638         * c-varobj.c: Revert.
5639         * c-valprint.c: Revert.
5640         * c-typeprint.c: Revert.
5641         * c-lang.c: Revert.
5642         * buildsym.c: Revert.
5643         * buildsym-legacy.c: Revert.
5644         * build-id.h: Revert.
5645         * build-id.c: Revert.
5646         * btrace.c: Revert.
5647         * bsd-uthread.c: Revert.
5648         * breakpoint.h: Revert.
5649         * breakpoint.c: Revert.
5650         * break-catch-throw.c: Revert.
5651         * break-catch-syscall.c: Revert.
5652         * break-catch-sig.c: Revert.
5653         * blockframe.c: Revert.
5654         * block.c: Revert.
5655         * bfin-tdep.c: Revert.
5656         * bfin-linux-tdep.c: Revert.
5657         * bfd-target.c: Revert.
5658         * bcache.c: Revert.
5659         * ax-general.c: Revert.
5660         * ax-gdb.h: Revert.
5661         * ax-gdb.c: Revert.
5662         * avr-tdep.c: Revert.
5663         * auxv.c: Revert.
5664         * auto-load.c: Revert.
5665         * arm-wince-tdep.c: Revert.
5666         * arm-tdep.c: Revert.
5667         * arm-symbian-tdep.c: Revert.
5668         * arm-pikeos-tdep.c: Revert.
5669         * arm-obsd-tdep.c: Revert.
5670         * arm-nbsd-tdep.c: Revert.
5671         * arm-nbsd-nat.c: Revert.
5672         * arm-linux-tdep.c: Revert.
5673         * arm-linux-nat.c: Revert.
5674         * arm-fbsd-tdep.c: Revert.
5675         * arm-fbsd-nat.c: Revert.
5676         * arm-bsd-tdep.c: Revert.
5677         * arch-utils.c: Revert.
5678         * arc-tdep.c: Revert.
5679         * arc-newlib-tdep.c: Revert.
5680         * annotate.h: Revert.
5681         * annotate.c: Revert.
5682         * amd64-windows-tdep.c: Revert.
5683         * amd64-windows-nat.c: Revert.
5684         * amd64-tdep.c: Revert.
5685         * amd64-sol2-tdep.c: Revert.
5686         * amd64-obsd-tdep.c: Revert.
5687         * amd64-obsd-nat.c: Revert.
5688         * amd64-nbsd-tdep.c: Revert.
5689         * amd64-nbsd-nat.c: Revert.
5690         * amd64-nat.c: Revert.
5691         * amd64-linux-tdep.c: Revert.
5692         * amd64-linux-nat.c: Revert.
5693         * amd64-fbsd-tdep.c: Revert.
5694         * amd64-fbsd-nat.c: Revert.
5695         * amd64-dicos-tdep.c: Revert.
5696         * amd64-darwin-tdep.c: Revert.
5697         * amd64-bsd-nat.c: Revert.
5698         * alpha-tdep.c: Revert.
5699         * alpha-obsd-tdep.c: Revert.
5700         * alpha-nbsd-tdep.c: Revert.
5701         * alpha-mdebug-tdep.c: Revert.
5702         * alpha-linux-tdep.c: Revert.
5703         * alpha-linux-nat.c: Revert.
5704         * alpha-bsd-tdep.c: Revert.
5705         * alpha-bsd-nat.c: Revert.
5706         * aix-thread.c: Revert.
5707         * agent.c: Revert.
5708         * addrmap.c: Revert.
5709         * ada-varobj.c: Revert.
5710         * ada-valprint.c: Revert.
5711         * ada-typeprint.c: Revert.
5712         * ada-tasks.c: Revert.
5713         * ada-lang.c: Revert.
5714         * aarch64-tdep.c: Revert.
5715         * aarch64-ravenscar-thread.c: Revert.
5716         * aarch64-newlib-tdep.c: Revert.
5717         * aarch64-linux-tdep.c: Revert.
5718         * aarch64-linux-nat.c: Revert.
5719         * aarch64-fbsd-tdep.c: Revert.
5720         * aarch64-fbsd-nat.c: Revert.
5721         * aarch32-linux-nat.c: Revert.
5722
5723 2019-04-05  Tom Tromey  <tom@tromey.com>
5724
5725         * ft32-tdep.c: Sort headers.
5726         * frv-tdep.c: Sort headers.
5727         * frv-linux-tdep.c: Sort headers.
5728         * frame.c: Sort headers.
5729         * frame-unwind.c: Sort headers.
5730         * frame-base.c: Sort headers.
5731         * fork-child.c: Sort headers.
5732         * findvar.c: Sort headers.
5733         * findcmd.c: Sort headers.
5734         * filesystem.c: Sort headers.
5735         * filename-seen-cache.h: Sort headers.
5736         * filename-seen-cache.c: Sort headers.
5737         * fbsd-tdep.c: Sort headers.
5738         * fbsd-nat.h: Sort headers.
5739         * fbsd-nat.c: Sort headers.
5740         * f-valprint.c: Sort headers.
5741         * f-typeprint.c: Sort headers.
5742         * f-lang.c: Sort headers.
5743         * extension.h: Sort headers.
5744         * extension.c: Sort headers.
5745         * extension-priv.h: Sort headers.
5746         * expprint.c: Sort headers.
5747         * exec.h: Sort headers.
5748         * exec.c: Sort headers.
5749         * exceptions.c: Sort headers.
5750         * event-top.c: Sort headers.
5751         * event-loop.c: Sort headers.
5752         * eval.c: Sort headers.
5753         * elfread.c: Sort headers.
5754         * dwarf2read.h: Sort headers.
5755         * dwarf2read.c: Sort headers.
5756         * dwarf2loc.c: Sort headers.
5757         * dwarf2expr.h: Sort headers.
5758         * dwarf2expr.c: Sort headers.
5759         * dwarf2-frame.c: Sort headers.
5760         * dwarf2-frame-tailcall.c: Sort headers.
5761         * dwarf-index-write.h: Sort headers.
5762         * dwarf-index-write.c: Sort headers.
5763         * dwarf-index-common.c: Sort headers.
5764         * dwarf-index-cache.h: Sort headers.
5765         * dwarf-index-cache.c: Sort headers.
5766         * dummy-frame.c: Sort headers.
5767         * dtrace-probe.c: Sort headers.
5768         * disasm.h: Sort headers.
5769         * disasm.c: Sort headers.
5770         * disasm-selftests.c: Sort headers.
5771         * dictionary.c: Sort headers.
5772         * dicos-tdep.c: Sort headers.
5773         * demangle.c: Sort headers.
5774         * dcache.h: Sort headers.
5775         * dcache.c: Sort headers.
5776         * darwin-nat.h: Sort headers.
5777         * darwin-nat.c: Sort headers.
5778         * darwin-nat-info.c: Sort headers.
5779         * d-valprint.c: Sort headers.
5780         * d-namespace.c: Sort headers.
5781         * d-lang.c: Sort headers.
5782         * ctf.c: Sort headers.
5783         * csky-tdep.c: Sort headers.
5784         * csky-linux-tdep.c: Sort headers.
5785         * cris-tdep.c: Sort headers.
5786         * cris-linux-tdep.c: Sort headers.
5787         * cp-valprint.c: Sort headers.
5788         * cp-support.c: Sort headers.
5789         * cp-namespace.c: Sort headers.
5790         * cp-abi.c: Sort headers.
5791         * corelow.c: Sort headers.
5792         * corefile.c: Sort headers.
5793         * continuations.c: Sort headers.
5794         * completer.h: Sort headers.
5795         * completer.c: Sort headers.
5796         * complaints.c: Sort headers.
5797         * coffread.c: Sort headers.
5798         * coff-pe-read.c: Sort headers.
5799         * cli-out.h: Sort headers.
5800         * cli-out.c: Sort headers.
5801         * charset.c: Sort headers.
5802         * c-varobj.c: Sort headers.
5803         * c-valprint.c: Sort headers.
5804         * c-typeprint.c: Sort headers.
5805         * c-lang.c: Sort headers.
5806         * buildsym.c: Sort headers.
5807         * buildsym-legacy.c: Sort headers.
5808         * build-id.h: Sort headers.
5809         * build-id.c: Sort headers.
5810         * btrace.c: Sort headers.
5811         * bsd-uthread.c: Sort headers.
5812         * breakpoint.h: Sort headers.
5813         * breakpoint.c: Sort headers.
5814         * break-catch-throw.c: Sort headers.
5815         * break-catch-syscall.c: Sort headers.
5816         * break-catch-sig.c: Sort headers.
5817         * blockframe.c: Sort headers.
5818         * block.c: Sort headers.
5819         * bfin-tdep.c: Sort headers.
5820         * bfin-linux-tdep.c: Sort headers.
5821         * bfd-target.c: Sort headers.
5822         * bcache.c: Sort headers.
5823         * ax-general.c: Sort headers.
5824         * ax-gdb.h: Sort headers.
5825         * ax-gdb.c: Sort headers.
5826         * avr-tdep.c: Sort headers.
5827         * auxv.c: Sort headers.
5828         * auto-load.c: Sort headers.
5829         * arm-wince-tdep.c: Sort headers.
5830         * arm-tdep.c: Sort headers.
5831         * arm-symbian-tdep.c: Sort headers.
5832         * arm-pikeos-tdep.c: Sort headers.
5833         * arm-obsd-tdep.c: Sort headers.
5834         * arm-nbsd-tdep.c: Sort headers.
5835         * arm-nbsd-nat.c: Sort headers.
5836         * arm-linux-tdep.c: Sort headers.
5837         * arm-linux-nat.c: Sort headers.
5838         * arm-fbsd-tdep.c: Sort headers.
5839         * arm-fbsd-nat.c: Sort headers.
5840         * arm-bsd-tdep.c: Sort headers.
5841         * arch-utils.c: Sort headers.
5842         * arc-tdep.c: Sort headers.
5843         * arc-newlib-tdep.c: Sort headers.
5844         * annotate.h: Sort headers.
5845         * annotate.c: Sort headers.
5846         * amd64-windows-tdep.c: Sort headers.
5847         * amd64-windows-nat.c: Sort headers.
5848         * amd64-tdep.c: Sort headers.
5849         * amd64-sol2-tdep.c: Sort headers.
5850         * amd64-obsd-tdep.c: Sort headers.
5851         * amd64-obsd-nat.c: Sort headers.
5852         * amd64-nbsd-tdep.c: Sort headers.
5853         * amd64-nbsd-nat.c: Sort headers.
5854         * amd64-nat.c: Sort headers.
5855         * amd64-linux-tdep.c: Sort headers.
5856         * amd64-linux-nat.c: Sort headers.
5857         * amd64-fbsd-tdep.c: Sort headers.
5858         * amd64-fbsd-nat.c: Sort headers.
5859         * amd64-dicos-tdep.c: Sort headers.
5860         * amd64-darwin-tdep.c: Sort headers.
5861         * amd64-bsd-nat.c: Sort headers.
5862         * alpha-tdep.c: Sort headers.
5863         * alpha-obsd-tdep.c: Sort headers.
5864         * alpha-nbsd-tdep.c: Sort headers.
5865         * alpha-mdebug-tdep.c: Sort headers.
5866         * alpha-linux-tdep.c: Sort headers.
5867         * alpha-linux-nat.c: Sort headers.
5868         * alpha-bsd-tdep.c: Sort headers.
5869         * alpha-bsd-nat.c: Sort headers.
5870         * aix-thread.c: Sort headers.
5871         * agent.c: Sort headers.
5872         * addrmap.c: Sort headers.
5873         * ada-varobj.c: Sort headers.
5874         * ada-valprint.c: Sort headers.
5875         * ada-typeprint.c: Sort headers.
5876         * ada-tasks.c: Sort headers.
5877         * ada-lang.c: Sort headers.
5878         * aarch64-tdep.c: Sort headers.
5879         * aarch64-ravenscar-thread.c: Sort headers.
5880         * aarch64-newlib-tdep.c: Sort headers.
5881         * aarch64-linux-tdep.c: Sort headers.
5882         * aarch64-linux-nat.c: Sort headers.
5883         * aarch64-fbsd-tdep.c: Sort headers.
5884         * aarch64-fbsd-nat.c: Sort headers.
5885         * aarch32-linux-nat.c: Sort headers.
5886
5887 2019-04-04  Tom Tromey  <tom@tromey.com>
5888
5889         * varobj.c (varobj_create): Update.
5890         * rust-exp.y (struct rust_parser) <update_innermost_block,
5891         lookup_symbol>: New methods.
5892         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5893         Rename.
5894         (rust_parser::rust_lookup_type)
5895         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5896         * printcmd.c (display_command, do_one_display): Update.
5897         * parser-defs.h (struct parser_state) <parser_state>: Add
5898         "tracker" parameter.
5899         (block_tracker): New member.
5900         (class innermost_block_tracker) <innermost_block_tracker>: Add
5901         "types" parameter.
5902         <reset>: Remove method.
5903         (innermost_block): Don't declare.
5904         (null_post_parser): Update.
5905         * parse.c (innermost_block): Remove global.
5906         (write_dollar_variable): Update.
5907         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5908         Remove "tracker_types" parameter.
5909         (parse_expression): Add "tracker" parameter.
5910         (parse_expression_for_completion): Update.
5911         (null_post_parser): Add "tracker" parameter.
5912         * p-exp.y: Update rules.
5913         * m2-exp.y: Update rules.
5914         * language.h (struct language_defn) <la_post_parser>: Add
5915         "tracker" parameter.
5916         * go-exp.y: Update rules.
5917         * f-exp.y: Update rules.
5918         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5919         parameter.
5920         * d-exp.y: Update rules.
5921         * c-exp.y: Update rules.
5922         * breakpoint.c (set_breakpoint_condition): Create an
5923         innermost_block_tracker.
5924         (watch_command_1): Likewise.
5925         * ada-lang.c (resolve): Add "tracker" parameter.
5926         (resolve_subexp): Likewise.
5927         * ada-exp.y (write_var_from_sym): Update.
5928
5929 2019-04-04  Tom Tromey  <tom@tromey.com>
5930
5931         * type-stack.h: New file.
5932         * type-stack.c: New file.
5933         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5934         type-stack.h.
5935         (insert_into_type_stack, insert_type, push_type, push_type_int)
5936         (insert_type_address_space, pop_type, pop_type_int)
5937         (pop_typelist, pop_type_stack, append_type_stack)
5938         (push_type_stack, get_type_stack, push_typelist)
5939         (follow_type_instance_flags, follow_types): Don't declare.
5940         * parse.c (type_stack): Remove global.
5941         (parse_exp_in_context): Update.
5942         (insert_into_type_stack, insert_type, push_type, push_type_int)
5943         (insert_type_address_space, pop_type, pop_type_int)
5944         (pop_typelist, pop_type_stack, append_type_stack)
5945         (push_type_stack, get_type_stack, push_typelist)
5946         (follow_type_instance_flags, follow_types): Remove (moved to
5947         type-stack.c).
5948         * f-exp.y (type_stack): New global.
5949         Update rules.
5950         (push_kind_type, f_parse): Update.
5951         * d-exp.y (type_stack): New global.
5952         Update rules.
5953         (d_parse): Update.
5954         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5955         Update rules.
5956         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5957         (HFILES_NO_SRCDIR): Add type-stack.h.
5958
5959 2019-04-04  Tom Tromey  <tom@tromey.com>
5960
5961         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5962         (rust_parser::convert_ast_to_expression, rust_parse)
5963         (rust_lex_test_completion, rust_lex_tests): Update.
5964         * parser-defs.h (struct expr_completion_state): New.
5965         (struct parser_state) <parser_state>: Add completion parameter.
5966         <mark_struct_expression, mark_completion_tag>: New methods.
5967         <parse_completion, m_completion_state>: New members.
5968         (prefixify_expression, null_post_parser): Update.
5969         (mark_struct_expression, mark_completion_tag): Don't declare.
5970         * parse.c (parse_completion, expout_last_struct)
5971         (expout_tag_completion_type, expout_completion_name): Remove
5972         globals.
5973         (parser_state::mark_struct_expression)
5974         (parser_state::mark_completion_tag): Now methods.
5975         (prefixify_expression): Add last_struct parameter.
5976         (prefixify_subexp): Likewise.
5977         (parse_exp_1): Update.
5978         (parse_exp_in_context): Add cstate parameter.  Update.
5979         (parse_expression_for_completion): Create an
5980         expr_completion_state.
5981         (null_post_parser): Add "completion" parameter.
5982         * p-exp.y: Update rules.
5983         (yylex): Update.
5984         * language.h (struct language_defn) <la_post_parser>: Add
5985         "completing" parameter.
5986         * go-exp.y: Update rules.
5987         (lex_one_token): Update.
5988         * expression.h (parse_completion): Don't declare.
5989         * d-exp.y: Update rules.
5990         (lex_one_token): Update rules.
5991         * c-exp.y: Update rules.
5992         (lex_one_token): Update.
5993         * ada-lang.c (resolve): Add "parse_completion" parameter.
5994         (resolve_subexp): Likewise.
5995         (ada_resolve_function): Likewise.
5996
5997 2019-04-04  Tom Tromey  <tom@tromey.com>
5998
5999         * parser-defs.h (struct parser_state) <start_arglist,
6000         end_arglist>: New methods.
6001         <arglist_len, m_funcall_chain>: New members.
6002         (arglist_len, start_arglist, end_arglist): Don't declare.
6003         * parse.c (arglist_len, funcall_chain): Remove global.
6004         (start_arglist, end_arglist): Remove functions.
6005         (parse_exp_in_context): Update.
6006         * p-exp.y: Update rules.
6007         * m2-exp.y: Update rules.
6008         * go-exp.y: Update rules.
6009         * f-exp.y: Update rules.
6010         * d-exp.y: Update rules.
6011         * c-exp.y: Update rules.
6012
6013 2019-04-04  Tom Tromey  <tom@tromey.com>
6014
6015         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6016         lex_operator, push_back>: New methods.
6017         Update all rules.
6018         (rust_parser::lex_hex, lex_escape): Rename and update.
6019         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6020         (rust_parser::lex_operator): Rename and update.
6021         (rust_parser::lex_number, rustyylex, rustyyerror)
6022         (rust_lex_test_init, rust_lex_test_sequence)
6023         (rust_lex_test_push_back, rust_lex_tests): Update.
6024         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6025         parameter.
6026         <lexptr, prev_lexptr>: New members.
6027         (lexptr, prev_lexptr): Don't declare.
6028         * parse.c (lexptr, prev_lexptr): Remove globals.
6029         (parse_exp_in_context): Update.
6030         * p-exp.y (yylex, yyerror): Update.
6031         * m2-exp.y (parse_number, yylex, yyerror): Update.
6032         * go-exp.y (lex_one_token, yyerror): Update.
6033         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6034         * d-exp.y (lex_one_token, yyerror): Update.
6035         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6036         (lex_one_token, yyerror): Update.
6037         * ada-lex.l (YY_INPUT): Update.
6038         (rewind_to_char): Update.
6039         * ada-exp.y (yyerror): Update.
6040
6041 2019-04-04  Tom Tromey  <tom@tromey.com>
6042
6043         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6044         * parser-defs.h (struct parser_state) <parser_state>: Add new
6045         parameter.
6046         <comma_terminates>: New member.
6047         (comma_terminates): Don't declare global.
6048         * parse.c (comma_terminates): Remove global.
6049         (parse_exp_in_context): Update.
6050         * p-exp.y (yylex): Update.
6051         * m2-exp.y (yylex): Update.
6052         * go-exp.y (lex_one_token): Update.
6053         * f-exp.y (yylex): Update.
6054         * d-exp.y (lex_one_token): Update.
6055         * c-exp.y (lex_one_token): Update.
6056         * ada-lex.l: Update.
6057
6058 2019-04-04  Tom Tromey  <tom@tromey.com>
6059
6060         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6061         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6062         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6063         * parser-defs.h (paren_depth): Don't declare.
6064         * parse.c (paren_depth): Remove global.
6065         (parse_exp_in_context): Update.
6066         * p-exp.y (paren_depth): New global.
6067         (pascal_parse): Initialize it.
6068         * m2-exp.y (paren_depth): New global.
6069         (m2_parse): Initialize it.
6070         * go-exp.y (paren_depth): New global.
6071         (go_parse): Initialize it.
6072         * f-exp.y (paren_depth): New global.
6073         (f_parse): Initialize it.
6074         * d-exp.y (paren_depth): New global.
6075         (d_parse): Initialize it.
6076         * c-exp.y (paren_depth): New global.
6077         (c_parse): Initialize it.
6078         * ada-lex.l (paren_depth): New global.
6079         (lexer_init): Initialize it.
6080
6081 2019-04-04  Tom Tromey  <tom@tromey.com>
6082
6083         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6084         (rust_parser::convert_ast_to_type)
6085         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6086         * parser-defs.h (struct parser_state) <parser_state>: Add
6087         parameters.  Initialize new members.
6088         <expression_context_block, expression_context_pc>: New members.
6089         * parse.c (expression_context_block, expression_context_pc):
6090         Remove globals.
6091         (parse_exp_in_context): Update.
6092         * p-exp.y: Update all rules.
6093         (yylex): Update.
6094         * m2-exp.y: Update all rules.
6095         (yylex): Update.
6096         * go-exp.y (yylex): Update.
6097         * f-exp.y (yylex): Update.
6098         * d-exp.y: Update all rules.
6099         (yylex): Update.
6100         * c-exp.y: Update all rules.
6101         (lex_one_token, classify_name, yylex, c_parse): Update.
6102         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6103
6104 2019-04-04  Tom Tromey  <tom@tromey.com>
6105
6106         * gdbarch.h, gdbarch.c: Rebuild.
6107         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6108         * stap-probe.h:
6109         (struct stap_parse_info): Replace "parser_state" with
6110         "expr_builder".
6111         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6112         (parser_state): New class.
6113         * parse.c (expr_builder): Rename.
6114         (expr_builder::release): Rename.
6115         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6116         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6117         (write_exp_elt_longcst, write_exp_elt_floatcst)
6118         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6119         (write_exp_string_vector, write_exp_bitstring)
6120         (write_exp_msymbol, mark_struct_expression)
6121         (write_dollar_variable)
6122         (insert_type_address_space, increase_expout_size): Replace
6123         "parser_state" with "expr_builder".
6124         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6125         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6126         "parser_state" with "expr_builder".
6127
6128 2019-04-04  Tom Tromey  <tom@tromey.com>
6129
6130         * rust-exp.y: Replace "parse_language" with method call.
6131         * p-exp.y:
6132         (yylex): Replace "parse_language" with method call.
6133         * m2-exp.y:
6134         (yylex): Replace "parse_language" with method call.
6135         * go-exp.y (classify_name): Replace "parse_language" with method
6136         call.
6137         * f-exp.y (yylex): Replace "parse_language" with method call.
6138         * d-exp.y (lex_one_token): Replace "parse_language" with method
6139         call.
6140         * c-exp.y:
6141         (lex_one_token, classify_name, yylex): Replace "parse_language"
6142         with method call.
6143         * ada-exp.y (find_primitive_type, type_char)
6144         (type_system_address): Replace "parse_language" with method call.
6145
6146 2019-04-04  Tom Tromey  <tom@tromey.com>
6147
6148         * rust-exp.y: Replace "parse_gdbarch" with method call.
6149         * parse.c (write_dollar_variable, insert_type_address_space):
6150         Replace "parse_gdbarch" with method call.
6151         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6152         call.
6153         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6154         call.
6155         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6156         "parse_gdbarch" with method call.
6157         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6158         with method call.
6159         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6160         "parse_gdbarch" with method call.
6161         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6162         "parse_gdbarch" with method call.
6163         * c-exp.y (parse_type, parse_number, classify_name): Replace
6164         "parse_gdbarch" with method call.
6165         * ada-lex.l: Replace "parse_gdbarch" with method call.
6166         * ada-exp.y (parse_type, find_primitive_type, type_char)
6167         (type_system_address): Replace "parse_gdbarch" with method call.
6168
6169 2019-04-04  Tom Tromey  <tom@tromey.com>
6170
6171         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6172         * stap-probe.c (stap_parse_argument): Update.
6173         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6174         initial_size parameter.
6175         * rust-exp.y (rust_lex_tests): Update.
6176         * parse.c (parser_state): Update.
6177         (parse_exp_in_context): Update.
6178         * parser-defs.h (struct parser_state) <parser_state>: Remove
6179         "initial_size" parameter.
6180
6181 2019-04-04  Tom Tromey  <tom@tromey.com>
6182
6183         * parser-defs.h (increase_expout_size): Don't declare.
6184         * parse.c (increase_expout_size): Now static.
6185
6186 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6187
6188         * gnu-nat.c (gnu_nat_target::wait): Fix
6189         target_waitstatus_to_string call.
6190
6191 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6192
6193         * eval.c (evaluate_subexp_standard): Handle internal functions
6194         during Fortran function call handling.
6195
6196 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6197
6198         * NEWS: Mention new internal functions.
6199         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6200         (read_base_type): Use dwarf2_init_complex_target_type.
6201         * value.c (creal_internal_fn): New function.
6202         (cimag_internal_fn): New function.
6203         (_initialize_values): Register new internal functions.
6204
6205 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6206
6207         * infrun.c (stop_all_threads): If debug_infrun, always
6208         trace the wait status after wait_one, using
6209         target_waitstatus_to_string and target_pid_to_str.
6210         (handle_inferior_event): Replace various trace of
6211         wait status kind by a single trace.
6212         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6213         wait status kind image by target_waitstatus_to_string.
6214         * target/waitstatus.c (target_waitstatus_to_string): Fix
6215         obsolete comment.
6216
6217 2019-04-01  Tom Tromey  <tromey@adacore.com>
6218
6219         PR symtab/23331:
6220         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6221
6222 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6223             Pedro Alves  <palves@redhat.com>
6224
6225         * top.c (quit_force): Call 'finalize_values'.
6226         * value.c (finalize_values): New function.
6227         * value.h (finalize_values): Declare.
6228
6229 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6230
6231         * NEWS: Announce $_gdb_major and $_gdb_minor.
6232
6233         * top.c (init_gdb_version_vars): New function.
6234         (gdb_init): Call init_gdb_version_vars.
6235
6236 2019-03-29  Tom Tromey  <tromey@adacore.com>
6237
6238         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6239         help text.  Remove dead code.
6240
6241 2019-03-29  Keith Seitz  <keiths@redhat.com>
6242
6243         From Siddhesh Poyarekar:
6244         * f-lang.h (f77_get_upperbound): Return LONGEST.
6245         (f77_get_lowerbound): Likewise.
6246         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6247         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6248         print them.
6249         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6250         plongest to format print it.
6251         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6252         (f77_get_upperbound): Likewise.
6253         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6254         LOWER_BOUND to LONGEST.
6255         (f77_create_arrayprint_offset_tbl): Likewise.
6256
6257 2019-03-29  Keith Seitz  <keiths@redhat.com>
6258
6259         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6260         %s/pulongest for TYPE_LENGTH instead of %d in format
6261         strings.
6262         * ada-typerint.c (ada_print_type): Likewise.
6263         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6264         * compile/compile-c-support.c (generate_register_struct): Likewise.
6265         * gdbtypes.c (recursive_dump_type): Likewise.
6266         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6267         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6268         instead of %d in format strings.
6269         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6270         to std::min to ULONGEST.
6271         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6272         instead of %d in format strings.
6273         * tracepoint.c (info_scope_command): Likewise.
6274         * typeprint.c (print_offset_data::update)
6275         (print_offset_data::finish): Likewise.
6276         * xtensa-tdep.c (xtensa_store_return_value)
6277         (xtensa_push_dummy_call): Likewise.
6278
6279 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6280
6281         * windows-nat.c (display_selector): Fixed format specifications
6282         for 64-bit Cygwin.
6283
6284 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6285
6286         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6287
6288 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6289
6290         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6291         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6292         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6293         (nios2_linux_init_abi): Install it.
6294
6295 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6296
6297         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6298
6299 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6300
6301         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6302
6303 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6304             Tom Tromey  <tromey@adacore.com>
6305
6306         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6307
6308 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6309
6310         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6311         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6312         method to compute the bounds of range types. Also print "[evaluated]"
6313         if the bounds' values come from a dynamic evaluation.
6314
6315 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6316
6317         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6318         whitespace when pretty printing is on.
6319
6320 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6321
6322         * ppc-linux-nat.c: Add include.
6323
6324 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6325
6326         * NEWS: Mention AArch64 Pointer Authentication.
6327
6328 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6329
6330         * arm-linux-nat.c: Add include.
6331
6332 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6333
6334         * source-cache.c (source_cache::get_source_lines): Re-read
6335         fullname after calling open_source_file.
6336
6337 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6338
6339         * NEWS: Mention TLS support for FreeBSD.
6340
6341 2019-03-25  Tom Tromey  <tromey@adacore.com>
6342
6343         * minsyms.c (BUNCH_SIZE): Update comment.
6344         (~minimal_symbol_reader): Remove old comment.
6345         (compact_minimal_symbols): Update comment.
6346         (minimal_symbol_reader::install): Remove old comment.  Update
6347         other comments.
6348
6349 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6350
6351         * s390-linux-nat.c: Add include.
6352
6353 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6354
6355         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6356         Call linux_get_hwcap.
6357         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6358         Likewise.
6359         (aarch64_linux_get_hwcap): Remove function.
6360         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6361         declaration.
6362         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6363         linux_get_hwcap.
6364         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6365         * linux-tdep.c (linux_get_hwcap): Add function.
6366         (linux_get_hwcap2): Likewise.
6367         * linux-tdep.h (linux_get_hwcap): Add declaration.
6368         (linux_get_hwcap2): Likewise.
6369         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6370         (ppc_linux_get_hwcap2): Likewise.
6371         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6372         linux_get_hwcap.
6373         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6374         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6375         (ppc_linux_nat_target::read_description): Likewise.
6376         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6377         * s390-linux-nat.c: Likewise.
6378         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6379
6380 2019-03-24  Tom Tromey  <tom@tromey.com>
6381
6382         * ada-lang.c (standard_lookup): Simplify initialization.
6383         (ada_lookup_symbol_nonlocal): Simplify return.
6384         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6385         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6386         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6387         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6388         initialization.
6389         * solib.c (solib_global_lookup): Simplify.
6390         * symtab.c (null_block_symbol): Remove.
6391         (symbol_cache_lookup): Simplify returns.
6392         (lookup_language_this): Simplify returns.
6393         (lookup_symbol_aux): Simplify return.
6394         (lookup_local_symbol): Simplify returns.
6395         (lookup_global_symbol_from_objfile): Simplify return.
6396         (lookup_symbol_in_objfile_symtabs)
6397         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6398         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6399         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6400         * cp-namespace.c (cp_lookup_bare_symbol)
6401         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6402         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6403         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6404         (cp_lookup_symbol_via_imports): Simplify initialization.
6405         (find_symbol_in_baseclass): Likewise.
6406         * symtab.h (null_block_symbol): Remove.
6407         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6408         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6409         (d_lookup_symbol_module): Likewise.
6410         (find_symbol_in_baseclass): Simplify initialization.
6411
6412 2019-03-24  Tom Tromey  <tom@tromey.com>
6413
6414         * expression.h: Don't include symtab.h.
6415         (struct block): Forward declare.
6416
6417 2019-03-24  Tom Tromey  <tom@tromey.com>
6418
6419         * c-exp.y (typebase): Remove casts.
6420         * gdbtypes.c (lookup_unsigned_typename, )
6421         (lookup_signed_typename): Remove cast.
6422         * eval.c (parse_to_comma_and_eval): Remove cast.
6423         * parse.c (write_dollar_variable): Remove cast.
6424         * block.h (struct block) <superblock>: Now const.
6425         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6426         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6427         (map_block): Make "block" const.
6428         * symfile.h (struct quick_symbol_functions)
6429         <map_matching_symbols>: Constify block argument to "callback".
6430         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6431         const.
6432         (find_pc_sect_compunit_symtab): Make "b" const.
6433         (find_symbol_at_address): Likewise.
6434         (search_symbols): Likewise.
6435         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6436         (dw2_debug_names_lookup_symbol): Likewise.
6437         (dw2_map_matching_symbols): Update.
6438         * p-valprint.c (pascal_val_print): Remove "block".
6439         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6440         (aux_add_nonlocal_symbols): Make "block" const.
6441         (resolve_subexp): Remove cast.
6442         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6443         const.
6444         (iterate_over_file_blocks): Likewise.
6445         * f-exp.y (%union) <bval>: Remove.
6446         * coffread.c (patch_opaque_types): Make "b" const.
6447         * spu-tdep.c (spu_catch_start): Make "block" const.
6448         * c-valprint.c (print_unpacked_pointer): Remove "block".
6449         * symmisc.c (dump_symtab_1): Make "b" const.
6450         (block_depth): Make "block" const.
6451         * d-exp.y (%union) <bval>: Remove.
6452         * cp-support.h (cp_lookup_rtti_type): Update.
6453         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6454         * psymtab.c (psym_lookup_symbol): Make "block" const.
6455         (maintenance_check_psymtabs): Make "b" const.
6456         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6457         (enumerate_locals, enumerate_args): Update.
6458         * python/py-symtab.c (stpy_global_block): Make "block" const.
6459         (stpy_static_block): Likewise.
6460         * inline-frame.c (block_starting_point_at): Make "new_block"
6461         const.
6462         * block.c (find_block_in_blockvector): Make return type const.
6463         (blockvector_for_pc_sect): Make "b" const.
6464         (find_block_in_blockvector): Make "b" const.
6465
6466 2019-03-23  Tom Tromey  <tom@tromey.com>
6467
6468         * varobj.c (varobj_create): Update.
6469         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6470         * printcmd.c (display_command, do_one_display): Don't reset
6471         innermost_block.
6472         * parser-defs.h (enum innermost_block_tracker_type): Move to
6473         expression.h.
6474         (innermost_block): Update comment.
6475         * parse.c (parse_exp_1): Add tracker_types parameter.
6476         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6477         tracker_types parameter.  Reset innermost_block.
6478         (parse_exp_in_context): Remove.
6479         (parse_expression_for_completion): Update.
6480         * objfiles.c (~objfile): Don't reset expression_context_block or
6481         innermost_block.
6482         * expression.h (enum innermost_block_tracker_type): Move from
6483         parser-defs.h.
6484         (parse_exp_1): Add tracker_types parameter.
6485         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6486         reset innermost_block.
6487
6488 2019-03-23  Tom Tromey  <tom@tromey.com>
6489
6490         * objfiles.h: Include bcache.h.
6491
6492 2019-03-23  Tom Tromey  <tom@tromey.com>
6493
6494         * linespec.c (get_current_search_block): Use
6495         scoped_restore_current_language.
6496         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6497
6498 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6499             Jiong Wang  <jiong.wang@arm.com>
6500
6501         * aarch64-linux-tdep.c
6502         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6503         section.
6504         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6505
6506 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6507             Jiong Wang  <jiong.wang@arm.com>
6508
6509         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6510         instructions.
6511         (aarch64_analyze_prologue_test): Add PACIASP test.
6512         (aarch64_prologue_prev_register): Unmask PC value.
6513
6514 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6515             Jiong Wang  <jiong.wang@arm.com>
6516
6517         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6518         (aarch64_dwarf2_prev_register): Unmask PC value.
6519         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6520         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6521         DW_CFA_AARCH64_negate_ra_state.
6522         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6523
6524 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6525             Jiong Wang  <jiong.wang@arm.com>
6526
6527         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6528         registers.
6529         (aarch64_pseudo_register_name): Likewise.
6530         (aarch64_pseudo_register_type): Likewise.
6531         (aarch64_pseudo_register_reggroup_p): Likewise.
6532         (aarch64_gdbarch_init): Add pauth registers.
6533         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6534         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6535         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6536         (struct gdbarch_tdep): Add regnum for ra_state.
6537
6538 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6539             Jiong Wang  <jiong.wang@arm.com>
6540
6541         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6542
6543 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6544             Jiong Wang  <jiong.wang@arm.com>
6545
6546         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6547         function.
6548         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6549         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6550         (aarch64_gdbarch_init): Add puth registers.
6551         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6552         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6553         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6554
6555 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6556             Jiong Wang  <jiong.wang@arm.com>
6557
6558         * aarch64-linux-nat.c
6559         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6560         * aarch64-linux-tdep.c
6561         (aarch64_linux_core_read_description): Likewise.
6562         (aarch64_linux_get_hwcap): New function.
6563         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6564         (aarch64_linux_get_hwcap): New declaration.
6565
6566 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6567             Jiong Wang  <jiong.wang@arm.com>
6568
6569         * aarch64-linux-nat.c
6570         (aarch64_linux_nat_target::read_description): Add pauth param.
6571         * aarch64-linux-tdep.c
6572         (aarch64_linux_core_read_description): Likewise.
6573         * aarch64-tdep.c (struct target_desc): Add in pauth.
6574         (aarch64_read_description): Add pauth param.
6575         (aarch64_gdbarch_init): Likewise.
6576         * aarch64-tdep.h (aarch64_read_description): Likewise.
6577         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6578         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6579         * features/Makefile: Add new files.
6580         * features/aarch64-pauth.c: New file.
6581         * features/aarch64-pauth.xml: New file.
6582
6583 2019-03-20  Tom Tromey  <tromey@adacore.com>
6584
6585         * infrun.c (handle_inferior_event): Rename from
6586         handle_inferior_event_1.  Create a scoped_value_mark.
6587         (handle_inferior_event): Remove.
6588
6589 2019-03-19  Tom Tromey  <tromey@adacore.com>
6590
6591         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6592         * infrun.h (print_stop_event): Add "displays" parameter.
6593         * infrun.c (print_stop_event): Add "displays" parameter.
6594
6595 2019-03-19  Pedro Alves  <palves@redhat.com>
6596
6597         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6598         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6599         to -1.  Fix TABs vs spaces.
6600         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6601         * tui/tui-out.h (tui_ui_out) Add intro comments.
6602         <m_line, m_start_of_line>: In-class initialize, and add describing
6603         comment.
6604
6605 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6606
6607         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6608         variable names.
6609         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6610
6611 2019-03-18  Pedro Alves  <palves@redhat.com>
6612             Eli Zaretskii <eliz@gnu.org>
6613
6614         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6615         m_line and m_start_of_line.
6616
6617 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6618
6619         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6620         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6621         it returns a newline.  This fixes a regression in TU mode, whereby
6622         the next line is output on the same screen line as the user input.
6623
6624 2019-03-18  Tom Tromey  <tromey@adacore.com>
6625
6626         * minsyms.c (minimal_symbol_reader::install): Remove call to
6627         obstack_blank.
6628
6629 2019-03-18  Pedro Alves  <palves@redhat.com>
6630
6631         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6632         New globals.
6633         (apply_style): New, factored out from ...
6634         (apply_ansi_escape): ... this.  Handle reverse video mode.
6635         (tui_set_reverse_mode): New function.
6636         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6637         * tui/tui-winsource.c (tui_show_source_line): Use
6638         tui_set_reverse_mode instead of setting A_STANDOUT.
6639         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6640         New setter methods.
6641
6642 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6643
6644         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6645         Handle tabs.
6646
6647 2019-03-18  Tom Tromey  <tromey@adacore.com>
6648
6649         * ada-lang.c (empty_array): Add "high" parameter.
6650         (ada_evaluate_subexp): Update.
6651
6652 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6653
6654         * unittests/string_view-selftests.c: Define
6655         _initialize_string_view_selftests unconditionally.
6656
6657 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6658
6659         PR gdb/24350
6660         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6661
6662 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6663
6664         PR gdb/24351
6665         * windows-nat.c (display_selector): Fix format specifiers.
6666
6667 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6668
6669         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6670         tui_refill_source_window instead of tui_refresh_win, to update the
6671         current execution line.  This fixes redisplay of the current line
6672         when stepping through the code with "next" or "step".
6673
6674 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6675
6676         * source-cache.c (source_cache::get_source_lines): Call
6677         find_source_lines to initialize s->nlines.  This fixes vertical
6678         scrolling of TUI source window when the DOWN arrow is pressed.
6679
6680 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6681
6682         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6683         linux-thread-db.c (_initialize_thread_db): Likewise.
6684
6685 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6686
6687         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6688         wclrtoeol in tui_show_source_line".  This reverts changes made in
6689         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6690
6691 2019-03-15  Tom Tromey  <tom@tromey.com>
6692
6693         * symtab.h (struct minimal_symbol): Derive from
6694         general_symbol_info.
6695         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6696         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6697         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6698         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6699         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6700         (MSYMBOL_SEARCH_NAME): Update.
6701         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6702         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6703         * minsyms.c (minimal_symbol_reader::record_full): Update.
6704
6705 2019-03-15  Tom Tromey  <tom@tromey.com>
6706
6707         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6708
6709 2019-03-15  Tom Tromey  <tom@tromey.com>
6710
6711         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6712         unique_xmalloc_ptr.
6713         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6714         Update.
6715         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6716         (build_minimal_symbol_hash_tables)
6717         (minimal_symbol_reader::install): Update.
6718
6719 2019-03-15  Tom Tromey  <tom@tromey.com>
6720
6721         * symtab.c (create_demangled_names_hash): Update.
6722         (symbol_set_names): Update.
6723         * objfiles.h (struct objfile_per_bfd_storage)
6724         <demangled_names_hash>: Now an htab_up.
6725         * objfiles.c (objfile_per_bfd_storage): Simplify.
6726
6727 2019-03-15  Tom Tromey  <tom@tromey.com>
6728
6729         * objfiles.h (struct objfile_per_bfd_storage): Declare
6730         destructor.
6731         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6732         New.
6733         (get_objfile_bfd_data): Use new.  Don't initialize
6734         language_of_main.
6735         (free_objfile_per_bfd_storage): Remove.
6736         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6737
6738 2019-03-15  Tom Tromey  <tom@tromey.com>
6739
6740         * symfile.c (reread_symbols): Update.
6741         * objfiles.c (objfile::objfile): Update.
6742         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6743         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6744         comment.
6745         (minimal_symbol_reader::install): Update.
6746         (terminate_minimal_symbol_table): Remove.
6747         * jit.c (jit_object_close_impl): Update.
6748
6749 2019-03-15  Tom Tromey  <tom@tromey.com>
6750
6751         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6752         initializations.
6753
6754 2019-03-15  Tom Tromey  <tom@tromey.com>
6755
6756         * objfiles.h (struct objfile_per_bfd_storage)
6757         <demangled_hash_languages>: Now a bitset.
6758         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6759         (lookup_minimal_symbol): Update.
6760
6761 2019-03-15  Tom Tromey  <tom@tromey.com>
6762
6763         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6764         Don't return the symbol.
6765         * coffread.c (record_minimal_symbol): Use record_full.
6766
6767 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6768
6769         The MS-Windows port of ncurses fails to switch to a color pair if
6770         one or both of the colors are the implicit default colors.  This
6771         change records the default colors when TUI is initialized, and
6772         then specifies them explicitly when a color pair uses the default
6773         colors.  This allows color styling in TUI mode on MS-Windows.
6774
6775         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6776         ncurses_norm_attr.
6777         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6778         colors in ncurses_norm_attr.
6779         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6780         "none", replace it with the default color recorded in
6781         ncurses_norm_attr.
6782
6783 2019-03-14  Tom Tromey  <tromey@adacore.com>
6784
6785         * source-cache.h (class source_cache) <get_source_lines>: Return
6786         std::string.
6787         * source-cache.c (source_cache::extract_lines): Handle case where
6788         first_pos==npos.  Return std::string.
6789         (source_cache::get_source_lines): Update.
6790
6791 2019-03-14  Tom Tromey  <tromey@adacore.com>
6792
6793         * NEWS: Add item for "style sources" commands.
6794         * source-cache.c (source_cache::get_source_lines): Check
6795         source_styling.
6796         * cli/cli-style.c (source_styling): New global.
6797         (_initialize_cli_style): Add "style sources" commands.
6798         (show_style_sources): New function.
6799         * cli/cli-style.h (source_styling): Declare.
6800
6801 2019-03-14  Pedro Alves  <palves@redhat.com>
6802             Tom Tromey  <tromey@adacore.com>
6803
6804         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6805         * tui/tui-winsource.c (tui_refill_source_window): New function,
6806         from...
6807         (tui_horizontal_source_scroll): ... here.  Move some logic.
6808         * cli/cli-style.c (set_style_enabled): Notify new observable.
6809         * tui/tui-hooks.c (tui_redisplay_source): New function.
6810         (tui_attach_detach_observers): Attach or detach
6811         tui_redisplay_source.
6812         * observable.h (source_styling_changed): New observable.
6813         * observable.c: Define source_styling_changed observable.
6814
6815 2019-03-13  Tom Tromey  <tromey@adacore.com>
6816
6817         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6818         (i386_gnu_nat_target::store_registers): Update.
6819         * target-debug.h (target_debug_print_std_string): New macro.
6820         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6821         * windows-tdep.c (display_one_tib): Update.
6822         * tui/tui-stack.c (tui_make_status_line): Update.
6823         * top.c (print_inferior_quit_action): Update.
6824         * thread.c (thr_try_catch_cmd): Update.
6825         (add_thread_with_info): Update.
6826         (thread_target_id_str): Update.
6827         (thr_try_catch_cmd): Update.
6828         (thread_command): Update.
6829         (thread_find_command): Update.
6830         * record-btrace.c (record_btrace_target::info_record)
6831         (record_btrace_resume_thread, record_btrace_target::resume)
6832         (record_btrace_cancel_resume, record_btrace_step_thread)
6833         (record_btrace_target::wait, record_btrace_target::wait)
6834         (record_btrace_target::wait, record_btrace_target::stop): Update.
6835         * progspace.c (print_program_space): Update.
6836         * process-stratum-target.c
6837         (process_stratum_target::thread_address_space): Update.
6838         * linux-fork.c (linux_fork_mourn_inferior)
6839         (detach_checkpoint_command, info_checkpoints_command)
6840         (linux_fork_context): Update.
6841         (linux_fork_detach): Update.
6842         (class scoped_switch_fork_info): Update.
6843         (delete_checkpoint_command): Update.
6844         * infrun.c (follow_fork_inferior): Update.
6845         (follow_fork_inferior): Update.
6846         (proceed_after_vfork_done): Update.
6847         (handle_vfork_child_exec_or_exit): Update.
6848         (follow_exec): Update.
6849         (displaced_step_prepare_throw): Update.
6850         (displaced_step_restore): Update.
6851         (start_step_over): Update.
6852         (resume_1): Update.
6853         (clear_proceed_status_thread): Update.
6854         (proceed): Update.
6855         (print_target_wait_results): Update.
6856         (do_target_wait): Update.
6857         (context_switch): Update.
6858         (stop_all_threads): Update.
6859         (restart_threads): Update.
6860         (finish_step_over): Update.
6861         (handle_signal_stop): Update.
6862         (switch_back_to_stepped_thread): Update.
6863         (keep_going_pass_signal): Update.
6864         (print_exited_reason): Update.
6865         (normal_stop): Update.
6866         * inferior.c (inferior_pid_to_str): Change return type.
6867         (print_selected_inferior): Update.
6868         (add_inferior): Update.
6869         (detach_inferior): Update.
6870         * dummy-frame.c (fprint_dummy_frames): Update.
6871         * dcache.c (dcache_info_1): Update.
6872         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6873         (btrace_fetch, btrace_clear): Update.
6874         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6875         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6876         type.
6877         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6878         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6879         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6880         * gdbarch.c, gdbarch.h: Rebuild.
6881         * gdbarch.sh (core_pid_to_str): Change return type.
6882         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6883         return type.
6884         (windows_nat_target::pid_to_str): Change return type.
6885         (windows_delete_thread): Update.
6886         (windows_nat_target::attach): Update.
6887         (windows_nat_target::files_info): Update.
6888         * target-delegates.c: Rebuild.
6889         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6890         return type.
6891         (sol_thread_target::pid_to_str): Change return type.
6892         * remote.c (class remote_target) <pid_to_str>: Change return
6893         type.
6894         (remote_target::pid_to_str): Change return type.
6895         (extended_remote_target::attach, remote_target::remote_stop_ns)
6896         (remote_target::remote_notif_remove_queued_reply)
6897         (remote_target::push_stop_reply, remote_target::disable_btrace):
6898         Update.
6899         (extended_remote_target::attach): Update.
6900         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6901         type.
6902         (gdbsim_target::pid_to_str): Change return type.
6903         * ravenscar-thread.c (struct ravenscar_thread_target)
6904         <pid_to_str>: Change return type.
6905         (ravenscar_thread_target::pid_to_str): Change return type.
6906         * procfs.c (class procfs_target) <pid_to_str>: Change return
6907         type.
6908         (procfs_target::pid_to_str): Change return type.
6909         (procfs_target::attach): Update.
6910         (procfs_target::detach): Update.
6911         (procfs_target::fetch_registers): Update.
6912         (procfs_target::store_registers): Update.
6913         (procfs_target::wait): Update.
6914         (procfs_target::files_info): Update.
6915         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6916         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6917         return type.
6918         (nto_procfs_target::pid_to_str): Change return type.
6919         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6920         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6921         return type.
6922         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6923         (exit_lwp): Update.
6924         (attach_proc_task_lwp_callback, get_detach_signal)
6925         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6926         (linux_nat_target::resume, wait_lwp, stop_callback)
6927         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6928         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6929         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6930         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6931         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6932         type.
6933         (inf_ptrace_target::attach): Update.
6934         (inf_ptrace_target::files_info): Update.
6935         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6936         type.
6937         (go32_nat_target::pid_to_str): Change return type.
6938         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6939         (gnu_nat_target::wait): Update.
6940         (gnu_nat_target::wait): Update.
6941         (gnu_nat_target::resume): Update.
6942         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6943         (fbsd_nat_target::wait): Update.
6944         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6945         type.
6946         (darwin_nat_target::attach): Update.
6947         * corelow.c (class core_target) <pid_to_str>: Change return type.
6948         (core_target::pid_to_str): Change return type.
6949         * target.c (normal_pid_to_str): Change return type.
6950         (default_pid_to_str): Likewise.
6951         (target_pid_to_str): Change return type.
6952         (target_translate_tls_address): Update.
6953         (target_announce_detach): Update.
6954         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6955         return type.
6956         (bsd_uthread_target::pid_to_str): Change return type.
6957         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6958         type.
6959         (bsd_kvm_target::pid_to_str): Change return type.
6960         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6961         return type.
6962         (aix_thread_target::pid_to_str): Change return type.
6963         * target.h (struct target_ops) <pid_to_str>: Change return type.
6964         (target_pid_to_str, normal_pid_to_str): Likewise.
6965         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6966         type.
6967         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6968         type.
6969         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6970         return type.
6971         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6972         type.
6973         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6974         type.
6975         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6976         return type.
6977
6978 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6979
6980         * NEWS: Mention that the new default MI version is 3.  Mention
6981         changes to the output of commands and events that deal with
6982         multi-location breakpoints.
6983         * breakpoint.c: Include "mi/mi-out.h".
6984         (print_one_breakpoint): Change output syntax if using MI version
6985         >= 3.
6986         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6987         New.
6988         (mi_multi_location_breakpoint_output_fixed): New.
6989         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6990         (mi_cmd_fix_multi_location_breakpoint_output): New.
6991         (mi_multi_location_breakpoint_output_fixed): New.
6992         * mi/mi-cmds.c (mi_cmds): Register command
6993         -fix-multi-location-breakpoint-output.
6994         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6995         interpreter "mi".
6996
6997 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6998
6999         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7000         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7001         instantiate mi_ui_out based on interpreter name.
7002         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7003         * mi/mi-main.c (mi_load_progress): Likewise.
7004
7005 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7006
7007         * NEWS: Combine separate "New targets" sections for 8.3.
7008
7009 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7010
7011         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7012         (ppcfbsd_init_abi): Install gdbarch
7013         "fetch_tls_load_module_address" and "get_thread_local_address"
7014         methods.
7015
7016 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7017
7018         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7019         (riscv_fbsd_init_abi): Install gdbarch
7020         "fetch_tls_load_module_address" and "get_thread_local_address"
7021         methods.
7022
7023 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7024
7025         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7026         (i386fbsd_init_abi): Install gdbarch
7027         "fetch_tls_load_module_address" and "get_thread_local_address"
7028         methods.
7029
7030 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7031
7032         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7033         (amd64fbsd_init_abi): Install gdbarch
7034         "fetch_tls_load_module_address" and "get_thread_local_address"
7035         methods.
7036
7037 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7038
7039         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7040         (struct fbsd_pspace_data): New type.
7041         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7042         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7043         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7044         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7045         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7046
7047 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7048
7049         * gdbtypes.c (lookup_struct_elt): New function.
7050         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7051         * gdbtypes.h (struct struct_elt): New type.
7052         (lookup_struct_elt): New prototype.
7053
7054 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7055
7056         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7057         remove disabled code block.
7058
7059 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7060
7061         * gdbarch.sh (get_thread_local_address): New method.
7062         * gdbarch.h, gdbarch.c: Regenerate.
7063         * target.c (target_translate_tls_address): Use
7064         gdbarch_get_thread_local_address if present instead of
7065         target::get_thread_local_address.
7066
7067 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7068
7069         * target.h (target::get_thread_local_address): Update comment.
7070
7071 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7072
7073         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7074         objfile->separate_debug_objfile_backlink if not NULL.
7075
7076 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7077
7078         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7079         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7080         (amd64bsd_store_inferior_registers): Likewise.
7081         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7082         Enable segment base registers.
7083         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7084         PT_GETFSBASE and PT_GETGSBASE.
7085         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7086         PT_SETGSBASE.
7087         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7088         segment base registers.
7089         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7090
7091 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7092
7093         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7094         Update calls to i386_target_description to add 'segments'
7095         parameter.
7096         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7097         add segment base registers.
7098         * arch/i386.c (i386_create_target_description): Add 'segments'
7099         parameter to enable segment base registers.
7100         * arch/i386.h (i386_create_target_description): Likewise.
7101         * features/i386/32bit-segments.xml: New file.
7102         * features/i386/32bit-segments.c: Generate.
7103         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7104         call to i386_target_description to add 'segments' parameter.
7105         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7106         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7107         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7108         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7109         if feature is present.
7110         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7111         Add 'segments' parameter to call to i386_target_description.
7112         (i386_target_description): Add 'segments' parameter to enable
7113         segment base registers.
7114         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7115         to call to i386_target_description.
7116         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7117         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7118         Define I386_NUM_REGS.
7119         (i386_target_description): Add 'segments' parameter to enable
7120         segment base registers.
7121
7122 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7123
7124         PR/24325
7125         * source-cache.c: #undef open and close, to avoid unresolved
7126         externals during linking.
7127
7128 2019-03-12  Tom Tromey  <tromey@adacore.com>
7129
7130         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7131         const.  Add initializers.
7132         (_initialize_remote): Don't initialize ptid globals.
7133
7134 2019-03-12  Pedro Alves  <palves@redhat.com>
7135
7136         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7137
7138 2019-03-12  Pedro Alves  <palves@redhat.com>
7139
7140         * cp-name-parser.y (main): Remove unused 'len' variable.
7141
7142 2019-03-12  Tom Tromey  <tromey@adacore.com>
7143
7144         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7145         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7146
7147 2019-03-12  Tom Tromey  <tromey@adacore.com>
7148
7149         * linux-nat.c (iterate_over_lwps): Update.
7150         (stop_callback): Remove parameter.
7151         (stop_wait_callback, detach_callback, resume_set_callback)
7152         (select_singlestep_lwp_callback, set_ignore_sigint)
7153         (status_callback, resumed_callback, resume_clear_callback)
7154         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7155         data parameter.
7156         (linux_nat_target::detach, linux_nat_target::resume)
7157         (linux_stop_and_wait_all_lwps, select_event_lwp)
7158         (linux_nat_filter_event, linux_nat_wait_1)
7159         (linux_nat_target::kill, linux_nat_target::stop)
7160         (linux_nat_target::stop): Update.
7161         (linux_nat_resume_callback): Change type.
7162         (resume_stopped_resumed_lwps, count_events_callback)
7163         (select_event_lwp_callback): Likewise.
7164         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7165         * arm-linux-nat.c (struct update_registers_data): Remove.
7166         (update_registers_callback): Change type.
7167         (arm_linux_insert_hw_breakpoint1): Update.
7168         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7169         parameter.
7170         (x86_linux_dr_set_addr): Update.
7171         (x86_linux_dr_set_control): Update.
7172         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7173         (iterate_over_lwps): Use gdb::function_view.
7174         * nat/aarch64-linux-hw-point.c (struct
7175         aarch64_dr_update_callback_param): Remove.
7176         (debug_reg_change_callback): Change type.
7177         (aarch64_notify_debug_reg_change): Update.
7178         * s390-linux-nat.c (s390_refresh_per_info): Update.
7179
7180 2019-03-11  Tom Tromey  <tromey@adacore.com>
7181
7182         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7183         redundant assignment to "this_cu".
7184
7185 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7186
7187         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7188
7189 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7190
7191         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7192         from...
7193         (rank_one_type): ... this.
7194
7195 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7196
7197         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7198         from...
7199         (rank_one_type): ... this.
7200
7201 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7202
7203         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7204         from...
7205         (rank_one_type): ... this.
7206
7207 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7208
7209         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7210         from...
7211         (rank_one_type): ... this.
7212
7213 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7214
7215         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7216         from...
7217         (rank_one_type): ... this.
7218
7219 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7220
7221         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7222         from...
7223         (rank_one_type): ... this.
7224
7225 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7226
7227         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7228         from...
7229         (rank_one_type): ... this.
7230
7231 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7232
7233         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7234         from...
7235         (rank_one_type): ... this.
7236
7237 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7238
7239         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7240         from...
7241         (rank_one_type): ... this.
7242
7243 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7244
7245         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7246         from...
7247         (rank_one_type): ... this.
7248
7249 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7250
7251         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7252         from...
7253         (rank_one_type): ... this.
7254
7255 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7256
7257         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7258         from...
7259         (rank_one_type): ... this.
7260
7261 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7262
7263         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7264         inferior-events' shows the example events.
7265
7266 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7267
7268         Support styling on native MS-Windows console
7269
7270         PR/24315
7271         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7272         on MS-Windows if $TERM is not defined.
7273
7274         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7275
7276         * posix-hdep.c (gdb_console_fputs):
7277         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7278         functions.
7279         * ui-file.h (gdb_console_fputs): Add prototype.
7280
7281         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7282         back to fputs only if the former returns zero.
7283
7284 2019-03-07  Tom Tromey  <tom@tromey.com>
7285
7286         * symmisc.c (print_symbol_bcache_statistics): Update.
7287         (print_objfile_statistics): Update.
7288         * symfile.c (allocate_symtab): Update.
7289         * stabsread.c: Don't include bcache.h.
7290         * psymtab.h (struct psymbol_bcache): Don't declare.
7291         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7292         (psymbol_bcache_init, psymbol_bcache_free)
7293         (psymbol_bcache_get_bcache): Don't declare.
7294         * psymtab.c (struct psymbol_bcache): Remove.
7295         (psymtab_storage::psymtab_storage): Update.
7296         (psymtab_storage::~psymtab_storage): Update.
7297         (psymbol_bcache_init, psymbol_bcache_free)
7298         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7299         (add_psymbol_to_bcache): Update.
7300         (allocate_psymtab): Update.
7301         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7302         macro_cache>: No longer pointers.
7303         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7304         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7305         * macrotab.c (macro_bcache): Update.
7306         * macroexp.c: Don't include bcache.h.
7307         * gdbtypes.c (check_types_worklist): Update.
7308         (types_deeply_equal): Remove TRY/CATCH.  Update.
7309         * elfread.c (elf_symtab_read): Update.
7310         * dwarf2read.c: Don't include bcache.h.
7311         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7312         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7313         (print_bcache_statistics, bcache_memory_used): Don't declare.
7314         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7315         methods.  Rename all data members.
7316         * bcache.c (struct bcache): Move to bcache.h.
7317         (bcache::expand_hash_table): Rename from expand_hash_table.
7318         (bcache): Remove.
7319         (bcache::insert): Rename from bcache_full.
7320         (bcache::compare): Rename from bcache_compare.
7321         (bcache_xmalloc): Remove.
7322         (bcache::~bcache): Rename from bcache_xfree.
7323         (bcache::print_statistics): Rename from print_bcache_statistics.
7324         (bcache::memory_used): Rename from bcache_memory_used.
7325
7326 2019-03-07  Pedro Alves  <palves@redhat.com>
7327
7328         * infrun.c (normal_stop): Also check for
7329         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7330
7331 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7332
7333         * f-lang.c (value_from_host_double): Moved to...
7334         * value.c (value_from_host_double): ...here.
7335         * value.h (value_from_host_double): Declare.
7336         * guile/scm-math.c (vlscm_convert_typed_number): Use
7337         value_from_host_double.
7338         (vlscm_convert_number): Likewise.
7339         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7340         * python/py-value.c (convert_value_from_python): Likewise.
7341
7342 2019-03-06  Tom Tromey  <tom@tromey.com>
7343
7344         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7345
7346 2019-03-06  Tom Tromey  <tom@tromey.com>
7347
7348         * utils.h (free_current_contents): Don't declare.
7349         * utils.c (free_current_contents): Remove.
7350
7351 2019-03-06  Tom Tromey  <tom@tromey.com>
7352
7353         * top.c (quit_force): Update.
7354         * main.c (captured_command_loop): Update.
7355         * common/new-op.c (operator new): Update.
7356         * common/common-exceptions.c (struct catcher)
7357         <save_cleanup_chain>: Remove member.
7358         (exceptions_state_mc_init): Update.
7359         (exception_try_scope_entry): Return nullptr.
7360         (exception_try_scope_exit, exception_rethrow)
7361         (throw_exception_sjlj, throw_exception_cxx): Update.
7362         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7363         (all_cleanups, do_cleanups, discard_cleanups)
7364         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7365         (restore_cleanups, restore_final_cleanups): Don't declare.
7366         (do_final_cleanups): Remove parameter.
7367         * common/cleanups.c (cleanup_chain, make_cleanup)
7368         (make_cleanup_dtor, all_cleanups, do_cleanups)
7369         (discard_my_cleanups, discard_cleanups)
7370         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7371         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7372         (null_cleanup): Remove.
7373         (do_final_cleanups): Remove parameter.
7374
7375 2019-03-06  Tom Tromey  <tom@tromey.com>
7376
7377         * remote.c (remote_target::remote_parse_stop_reply): Use
7378         unique_xmalloc_ptr.
7379
7380 2019-03-06  Tom Tromey  <tom@tromey.com>
7381
7382         * stabsread.c (struct stabs_field_info): Rename from field_info.
7383         <list, fnlist>: Add initializers.
7384         <obstack>: New member.
7385         (read_member_functions, read_struct_fields, read_baseclasses):
7386         Allocate on obstack.  Don't use cleanups.
7387         (read_one_struct_field, read_member_functions, read_struct_fields)
7388         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7389         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7390         (read_struct_type): Update.
7391
7392 2019-03-06  Tom Tromey  <tom@tromey.com>
7393
7394         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7395         * common/filestuff.h (make_cleanup_close): Don't declare.
7396         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7397         Remove.
7398
7399 2019-03-06  Tom Tromey  <tom@tromey.com>
7400
7401         * solib-aix.c: Use make_scope_exit.
7402
7403 2019-03-06  Tom Tromey  <tom@tromey.com>
7404
7405         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7406         Use make_scope_exit.
7407
7408 2019-03-06  Tom Tromey  <tom@tromey.com>
7409
7410         * solib-svr4.c (disable_probes_interface): Remove parameter.
7411         (svr4_handle_solib_event): Use make_scope_exit.
7412
7413 2019-03-06  Tom Tromey  <tom@tromey.com>
7414
7415         * remote.c (struct stop_reply_deleter): Remove.
7416         (stop_reply_up): Update.
7417         (struct stop_reply): Derive from notif_event.  Don't typedef.
7418         <regcache>: Now a std::vector.
7419         (stop_reply_xfree): Remove.
7420         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7421         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7422         (remote_target::discard_pending_stop_replies): Use delete.
7423         (remote_target::remote_parse_stop_reply): Update.
7424         (remote_target::process_stop_reply): Update.
7425         * remote-notif.h (struct notif_event): Add virtual destructor.
7426         Remove "dtr" member.
7427         (struct notif_client) <alloc_event>: Return a unique_ptr.
7428         (notif_event_xfree): Don't declare.
7429         (notif_event_up): New typedef.
7430         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7431         (notif_event_xfree, do_notif_event_xfree): Remove.
7432         (remote_notif_state_xfree): Update.
7433
7434 2019-03-06  Tom Tromey  <tom@tromey.com>
7435
7436         * infrun.c (displaced_step_clear_cleanup): Now a
7437         forward_scope_exit type.
7438         (displaced_step_prepare_throw): Update.
7439         (displaced_step_fixup): Update.
7440
7441 2019-03-06  Tom Tromey  <tom@tromey.com>
7442
7443         * inferior.h (class inferior): Update comment.
7444         * gdbthread.h (class thread_info): Update comment.
7445
7446 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7447             Tom Tromey  <tom@tromey.com>
7448
7449         * stabsread.h (struct stab_section_list): Remove.
7450         (coffstab_build_psymtabs): Update.
7451         * dbxread.c (symbuf_sections): Now a std::vector.
7452         (sect_idx): New global.
7453         (fill_symbuf): Update.
7454         (coffstab_build_psymtabs): Change type of stabsects parameter.
7455         Update.
7456         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7457         std::vector.
7458         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7459         (coff_locate_sections): Update.
7460         (coff_symfile_read): Remove cleanups.  Update.
7461         (init_stringtab): Add storage parameter.
7462         (free_stringtab, free_stringtab_cleanup): Remove.
7463         (init_lineno): Add storage parameter.
7464         (free_linetab, free_linetab_cleanup): Remove.
7465
7466 2019-03-06  Pedro Alves  <palves@redhat.com>
7467
7468         * linux-fork.c (fork_info::clobber_regs): Delete.
7469         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7470         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7471         comment.  Adjust.
7472         (scoped_switch_fork_info::scoped_switch_fork_info)
7473         (checkpoint_command, linux_fork_context): Adjust
7474         fork_save_infrun_state calls.
7475
7476 2019-03-06  Pedro Alves  <palves@redhat.com>
7477
7478         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7479         (inf_has_multiple_threads): Return 'bool' and rewrite using
7480         inferior_info::threads().
7481
7482 2019-03-06  Pedro Alves  <palves@redhat.com>
7483
7484         * linux-fork.c: Include <list>.
7485         (fork_list): Now a std::list instance.
7486         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7487         (forks_exist_p, find_last_fork): Adjust.
7488         (new_fork): Delete.
7489         (one_fork_p): New.
7490         (add_fork): Adjust.
7491         (free_fork): Delete, folded into fork_info::~fork_info().
7492         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7493         Adjust.
7494         (init_fork_list): Delete.
7495         (linux_fork_killall, linux_fork_mourn_inferior)
7496         (linux_fork_detach, info_checkpoints_command): Adjust.
7497         (_initialize_linux_fork): No longer call init_fork_list.
7498
7499 2019-03-06  Pedro Alves  <palves@redhat.com>
7500
7501         * linux-fork.c (new_fork): New, split out of ...
7502         (add_fork): ... this.  Return void.  Move "first fork" special
7503         case from here, to ...
7504         (checkpoint_command): ... here.
7505         * linux-linux.h (add_fork): Return void.
7506
7507 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7508
7509         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7510
7511 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7512             Chris January  <chris.january@arm.com>
7513             David Lecomber  <david.lecomber@arm.com>
7514
7515         * f-exp.y: New token, UNOP_INTRINSIC.
7516         (exp): New pattern using UNOP_INTRINSIC token.
7517         (f77_keywords): Add 'abs' keyword.
7518         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7519         (value_from_host_double): New function.
7520         (evaluate_subexp_f): Support UNOP_ABS.
7521
7522 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7523
7524         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7525         types.
7526
7527 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7528
7529         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7530         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7531         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7532
7533 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7534
7535         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7536
7537 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7538             Chris January  <chris.january@arm.com>
7539
7540         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7541         * f-exp.y: Define 'KIND' token.
7542         (exp): New pattern for KIND expressions.
7543         (ptype): Handle types with a kind extension.
7544         (direct_abs_decl): Extend to spot kind extensions.
7545         (f77_keywords): Add 'kind' to the list.
7546         (push_kind_type): New function.
7547         (convert_to_kind_type): New function.
7548         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7549         * parse.c (operator_length_standard): Likewise.
7550         * parser-defs.h (enum type_pieces): Add tp_kind.
7551         * std-operator.def: Add UNOP_KIND.
7552
7553 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7554
7555         * f-exp.y (f_parse): Set yydebug.
7556
7557 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7558
7559         * f-lang.c (evaluate_subexp_f): New function.
7560         (exp_descriptor_f): New global.
7561         (f_language_defn): Use exp_descriptor_f instead of
7562         exp_descriptor_standard.
7563
7564 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7565
7566         * f-exp.y (struct token): Add comments.
7567         (dot_ops): Remove uppercase versions and the end marker.
7568         (f77_keywords): Likewise.
7569         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7570         entries in the dot_ops array are case insensitive, and use
7571         strncasecmp to compare strings.  Also some whitespace cleanup in
7572         this area.  Similar for the f77_keywords array, except entries in
7573         this list might be case sensitive.
7574
7575 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7576
7577         * f-exp.y (struct f77_boolean_val): Add comments.
7578         (boolean_values): Remove uppercase versions, and end marker.
7579         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7580         and use strncasecmp to achieve case insensitivity.  Additionally,
7581         perform whitespace cleanup around this code.
7582
7583 2019-03-06  Tom Tromey  <tromey@adacore.com>
7584
7585         * remote-sim.c (gdbsim_target_open): Use result of
7586         gdb_argv::release.
7587
7588 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7589         Dirk Schubert  <dirk.schubert@arm.com>
7590         Chris January  <chris.january@arm.com>
7591
7592         * eval.c (evaluate_subexp_standard): Call Fortran argument
7593         wrapping logic.
7594         * f-lang.c (struct value): A value which can be passed into a
7595         Fortran function call.
7596         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7597         where appropriate.
7598         (struct type): Value ready for a Fortran function call.
7599         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7600         is needed.
7601         * f-lang.h (fortran_argument_convert): Declaration.
7602         (fortran_preserve_arg_pointer): Declaration.
7603         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7604
7605 2019-03-05  Tom Tromey  <tromey@adacore.com>
7606
7607         * python/py-prettyprint.c (print_string_repr): Remove #if.
7608         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7609
7610 2019-03-05  Tom Tromey  <tromey@adacore.com>
7611
7612         * target.c (the_dummy_target): Move later.  Change type to
7613         "dummy_target".
7614         (initialize_targets): Don't initialize the_dummy_target.
7615
7616 2019-03-05  Tom Tromey  <tromey@adacore.com>
7617
7618         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7619         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7620
7621 2019-03-05  Tom Tromey  <tromey@adacore.com>
7622
7623         * windows-nat.c (windows_nat_target::attach)
7624         (windows_nat_target::detach): Don't call gdb_flush.
7625         * valprint.c (generic_val_print, val_print, val_print_string):
7626         Don't call gdb_flush.
7627         * utils.c (defaulted_query): Don't call gdb_flush.
7628         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7629         * target.c (target_announce_detach): Don't call gdb_flush.
7630         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7631         * remote.c (extended_remote_target::attach): Don't call
7632         gdb_flush.
7633         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7634         * printcmd.c (do_examine): Don't call gdb_flush.
7635         (info_display_command): Don't call gdb_flush.
7636         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7637         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7638         * memattr.c (info_mem_command): Don't call gdb_flush.
7639         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7640         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7641         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7642         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7643         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7644         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7645         (gnu_nat_target::detach): Don't call gdb_flush.
7646         * f-valprint.c (f_val_print): Don't call gdb_flush.
7647         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7648         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7649         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7650         gdb_flush.
7651         * c-valprint.c (c_val_print): Don't call gdb_flush.
7652         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7653
7654 2019-03-05  Tom Tromey  <tromey@adacore.com>
7655
7656         * varobj.c (update_dynamic_varobj_children): Update.
7657         (install_default_visualizer): Use reset, not release.
7658         * value.c (set_internalvar): Update.
7659         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7660         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7661         ATTRIBUTE_UNUSED_RESULT.
7662
7663 2019-03-05  Tom Tromey  <tromey@adacore.com>
7664
7665         * remote.c (class scoped_remote_fd) <release>: Add
7666         ATTRIBUTE_UNUSED_RESULT.
7667
7668 2019-03-05  Tom Tromey  <tromey@adacore.com>
7669
7670         * macroexp.c (struct macro_buffer) <release>: Add
7671         ATTRIBUTE_UNUSED_RESULT.
7672
7673 2019-03-05  Tom Tromey  <tromey@adacore.com>
7674
7675         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7676         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7677         ATTRIBUTE_UNUSED_RESULT.
7678
7679 2019-03-05  Tom Tromey  <tromey@adacore.com>
7680
7681         * common/scoped_fd.h (class scoped_fd) <release>: Add
7682         ATTRIBUTE_UNUSED_RESULT.
7683
7684 2019-03-05  Tom Tromey  <tromey@adacore.com>
7685
7686         * parser-defs.h (struct parser_state) <release>: Add
7687         ATTRIBUTE_UNUSED_RESULT.
7688
7689 2019-03-05  Tom Tromey  <tromey@adacore.com>
7690
7691         * utils.h (class gdb_argv) <release>: Add
7692         ATTRIBUTE_UNUSED_RESULT.
7693         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7694
7695 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7696
7697         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7698         for-loop range, to avoid compiler warnings.
7699
7700         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7701         avoid compiler warnings about unused variables.
7702
7703         * NEWS: Mention end of support for native debugging on MS-Windows
7704         before XP.
7705
7706         PR gdb/24292
7707         * common/netstuff.c:
7708         * gdbserver/gdbreplay.c
7709         * gdbserver/remote-utils.c:
7710         * ser-tcp.c:
7711         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7712         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7713         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7714         'getaddrinfo' and 'freeaddrinfo' were not available before
7715         Windows XP, and mingw.org's MinGW headers by default define
7716         _WIN32_WINNT to 0x500.
7717
7718 2019-03-01  Gary Benson <gbenson@redhat.com>
7719
7720         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7721
7722 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7723             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7724
7725         PR gdb/8527
7726         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7727         set_sigint_trap, clear_sigint_trap.
7728
7729 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7730
7731         * target.c (target_detach): Clear the regcache and the
7732         frame cache.
7733
7734 2019-02-27  Pedro Alves  <palves@redhat.com>
7735
7736         * utils.c (set_screen_size): When we cap the height/width sizes,
7737         tweak the corresponding command variable to show "unlimited":
7738
7739 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7740             Pedro Alves  <palves@redhat.com>
7741
7742         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7743         before calling rl_set_screen_size.
7744
7745 2019-02-27  Tom Tromey  <tromey@adacore.com>
7746
7747         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7748         define.
7749         * python/py-value.c: Remove Python 2.4 workaround.
7750         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7751         workaround.
7752         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7753         Python 2.4 workaround.
7754         * python/python-internal.h: Remove Python 2.4 comment.
7755         (Py_ssize_t): Don't define.
7756         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7757         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7758         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7759         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7760         * python/python.c (do_start_initialization): Remove Python 2.4
7761         workaround.
7762         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7763         (print_children): Remove Python 2.4 workaround.
7764         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7765         workaround.
7766         (CHARBUFFERPROC_NAME): Remove.
7767         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7768         Python 2.4 workaround.
7769
7770 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7771
7772         * NEWS: Note minimum Python version.
7773
7774 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7775
7776         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7777         code from these functions.  Remove corresponding ifdefs.  Use
7778         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7779         Remove gotos and target of gotos.
7780         (infpy_search_memory): Likewise.
7781
7782 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7783
7784         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7785         (hppa_gdbarch_init): Don't register deleted functions with
7786         gdbarch.
7787
7788 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7789
7790         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7791         (h8300_unwind_sp): Delete.
7792         (h8300_dummy_id): Delete.
7793         (h8300_gdbarch_init): Don't register deleted functions with
7794         gdbarch.
7795
7796 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7797
7798         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7799         (ft32_unwind_pc): Delete.
7800         (ft32_unwind_sp): Delete.
7801         (ft32_gdbarch_init): Don't register deleted functions with
7802         gdbarch.
7803
7804 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7805
7806         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7807         (frv_unwind_pc): Delete.
7808         (frv_unwind_sp): Delete.
7809         (frv_gdbarch_init): Don't register deleted functions with
7810         gdbarch.
7811
7812 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7813
7814         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7815         (riscv_unwind_pc): Delete.
7816         (riscv_unwind_sp): Delete.
7817         (riscv_gdbarch_init): Don't register deleted functions with
7818         gdbarch.
7819
7820 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7821
7822         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7823         (csky_unwind_pc): Delete.
7824         (csky_unwind_sp): Delete.
7825         (csky_gdbarch_init): Don't register deleted functions with
7826         gdbarch.
7827
7828 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7829
7830         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7831         (cris_unwind_pc): Delete.
7832         (cris_unwind_sp): Delete.
7833         (cris_gdbarch_init): Don't register deleted functions with
7834         gdbarch.
7835
7836 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7837
7838         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7839         (bfin_unwind_pc): Delete.
7840         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7841
7842 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7843
7844         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7845         (arm_unwind_pc): Delete.
7846         (arm_unwind_sp): Delete.
7847         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7848
7849 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7850
7851         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7852         (arc_unwind_pc): Delete.
7853         (arc_unwind_sp): Delete.
7854         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7855
7856 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7857
7858         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7859         (alpha_unwind_pc): Delete.
7860         (alpha_gdbarch_init): Don't register deleted functions with
7861         gdbarch.
7862
7863 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7864
7865         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7866         (aarch64_unwind_pc): Delete.
7867         (aarch64_unwind_sp): Delete.
7868         (aarch64_gdbarch_init): Don't register deleted functions with
7869         gdbarch.
7870
7871 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7872
7873         * gdbtypes.c (type_align): Don't consider static members when
7874         computing structure alignment.
7875
7876 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7877
7878         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7879         return 0 for other types.
7880         * arch-utils.c (default_type_align): Always return 0.
7881         * gdbarch.h: Regenerate.
7882         * gdbarch.sh (type_align): Extend comment.
7883         * gdbtypes.c (type_align): Add additional comments, always call
7884         gdbarch_type_align before applying the default rules.
7885         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7886         generic code will then apply a suitable default.
7887         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7888         types, return 0 for other types.
7889
7890 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7891
7892         * NEWS: Create a new section for the next release branch.
7893         Rename the section of the current branch, now that it has
7894         been cut.
7895
7896 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7897
7898         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7899         * version.in: Bump version to 8.3.50.DATE-git.
7900
7901 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7902
7903         * aix-thread.c (ptid_cmp): Remove unused variable.
7904         (get_signaled_thread): Likewise.
7905         (store_regs_user_thread): Likewise.
7906         (store_regs_kernel_thread): Likewise.
7907         (fetch_regs_kernel_thread): Remove shadowed variable.
7908
7909 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7910
7911         * features/riscv/32bit-cpu.xml: Add register numbers.
7912         * features/riscv/32bit-fpu.c: Regenerate.
7913         * features/riscv/32bit-fpu.xml: Add register numbers.
7914         * features/riscv/64bit-cpu.xml: Add register numbers.
7915         * features/riscv/64bit-fpu.c: Regenerate.
7916         * features/riscv/64bit-fpu.xml: Add register numbers.
7917
7918 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7919
7920         * NEWS: Mention two argument form of gdb.Value constructor.
7921         * python/py-value.c (convert_buffer_and_type_to_value): New
7922         function.
7923         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7924         Add support for handling an optional second argument.  Call
7925         convert_buffer_and_type_to_value as appropriate.
7926         * python/python-internal.h (Py_buffer_deleter): New struct.
7927         (Py_buffer_up): New typedef.
7928
7929 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7930
7931         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7932         instead of releasing ownership.
7933
7934 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7935
7936         * dwarf2read.c (open_and_init_dwp_file): Call
7937         elf_numsections instead of bfd_count_sections to initialize
7938         dwp_file->num_sections.
7939
7940 2019-02-25  Tom Tromey  <tromey@adacore.com>
7941
7942         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7943
7944 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7945
7946         * gcore.in: Add '--readnever' option when invoking GDB.
7947
7948 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7949
7950         * MAINTAINERS: Update my email address.
7951
7952 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7953
7954         * build-id.c (build_id_to_debug_bfd_1): New function.
7955         (build_id_to_debug_bfd): Look for separate debug file in
7956         sysroot.
7957
7958 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7959
7960         * gdbarch.sh: Update the copyright year range that is placed into
7961         generated files.
7962
7963 2019-02-22  Keith Seitz  <keiths@redhat.com>
7964
7965         PR symtab/23853
7966         * linespec.c (create_sals_line_offset): Search for the default
7967         symtab's filename instead of its fullname.
7968
7969 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7970
7971         * NEWS: Update style defaults.
7972
7973 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7974
7975         * main.c (captured_main_1): Disable styling in batch mode.
7976
7977 2019-02-20  Tom Tromey  <tom@tromey.com>
7978
7979         * symtab.c (symtab_symbol_info): Fix typos.
7980
7981 2019-02-20  Tom Tromey  <tromey@adacore.com>
7982
7983         * findcmd.c (_initialize_mem_search): Use upper case for
7984         metasyntactic variables.
7985
7986 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7987
7988         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7989         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7990
7991 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7992
7993         * top.h (source_file_name): Change to std::string.
7994         * top.c (source_file_name): Likewise.
7995         (command_line_input): Adjust.
7996         * cli/cli-script.c (script_from_file): Adjust.
7997
7998 2019-02-19  Tom Tromey  <tromey@adacore.com>
7999
8000         * ravenscar-thread.c
8001         (ravenscar_thread_target::update_thread_list): Don't call
8002         ada_build_task_list.
8003         * ada-lang.h (ada_build_task_list): Don't declare.
8004         * ada-tasks.c (struct ada_tasks_inferior_data)
8005         <task_list_valid_p>: Now bool.
8006         (read_known_tasks, ada_task_list_changed)
8007         (ada_tasks_invalidate_inferior_data): Update.
8008         (read_known_tasks_array): Return bool.
8009         (read_known_tasks_list): Likewise.
8010         (read_known_tasks): Return void.
8011         (ada_build_task_list): Now static.
8012
8013 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8014
8015         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8016         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8017
8018 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8019
8020         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8021         variant for ada_tasks_pspace_data_handle and
8022         ada_tasks_inferior_data_handle.
8023         (ada_tasks_pspace_data_cleanup): New function.
8024         (ada_tasks_inferior_data_cleanup): New function.
8025
8026 2019-02-17  Tom Tromey  <tom@tromey.com>
8027
8028         * macrotab.h (macro_source_fullname): Return a std::string.
8029         * macrotab.c (macro_include, check_for_redefinition)
8030         (macro_undef, macro_lookup_definition, foreach_macro)
8031         (foreach_macro_in_scope): Update.
8032         (macro_source_fullname): Return a std::string.
8033         * macrocmd.c (show_pp_source_pos): Update.
8034
8035 2019-02-17  Tom Tromey  <tom@tromey.com>
8036
8037         * macrocmd.c (show_pp_source_pos): Style the file names.
8038
8039 2019-02-17  Tom Tromey  <tom@tromey.com>
8040
8041         PR tui/24197:
8042         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8043
8044 2019-02-17  Tom Tromey  <tom@tromey.com>
8045
8046         * ada-lang.c (user_select_syms): Use filtered printing.
8047         * utils.c (wrap_style): New global.
8048         (desired_style): Remove.
8049         (emit_style_escape): Add stream parameter.
8050         (set_output_style, reset_terminal_style, prompt_for_continue):
8051         Update.
8052         (flush_wrap_buffer): Only flush gdb_stdout.
8053         (wrap_here): Set wrap_style.
8054         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8055         treat escape sequences as a character.  Change when wrap buffer is
8056         flushed.
8057         (fputs_styled): Do not set the output style when the default is
8058         requested.
8059         * ui-style.h (struct ui_file_style) <is_default>: New method.
8060         * source.c (print_source_lines_base): Emit escape sequences in one
8061         piece.
8062
8063 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8064
8065         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8066         integers and enumeration types.
8067
8068 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8069
8070         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8071         instead of lookup_symbol_in_language
8072         (do_exact_match): New function.
8073         (ada_get_symbol_name_matcher): Return do_exact_match when
8074         doing a verbatim match.
8075
8076 2019-02-15  Tom Tromey  <tromey@adacore.com>
8077
8078         * ravenscar-thread.c (ravenscar_thread_target::resume)
8079         (ravenscar_thread_target::wait): Special case wildcard requests.
8080
8081 2019-02-15  Tom Tromey  <tromey@adacore.com>
8082
8083         * ravenscar-thread.c (base_ptid): Remove.
8084         (struct ravenscar_thread_target) <close>: New method.
8085         <m_base_ptid>: New member.
8086         <update_inferior_ptid, active_task, task_is_currently_active,
8087         runtime_initialized>: Declare methods.
8088         <ravenscar_thread_target>: Add constructor.
8089         (ravenscar_thread_target::task_is_currently_active)
8090         (ravenscar_thread_target::update_inferior_ptid)
8091         (ravenscar_runtime_initialized): Rename.  Now methods.
8092         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8093         (ravenscar_thread_target::update_thread_list): Update.
8094         (ravenscar_thread_target::active_task): Now method.
8095         (ravenscar_thread_target::store_registers)
8096         (ravenscar_thread_target::prepare_to_store)
8097         (ravenscar_thread_target::prepare_to_store)
8098         (ravenscar_thread_target::mourn_inferior): Update.
8099         (ravenscar_inferior_created): Use "new" to create target.
8100         (ravenscar_thread_target::get_ada_task_ptid): Update.
8101         (_initialize_ravenscar): Don't initialize base_ptid.
8102         (ravenscar_ops): Remove global.
8103
8104 2019-02-15  Tom Tromey  <tromey@adacore.com>
8105
8106         * target.h (push_target): Declare new overload.
8107         * target.c (push_target): New overload, taking an rvalue reference.
8108         * remote.c (remote_target::open_1): Use push_target overload.
8109         * corelow.c (core_target_open): Use push_target overload.
8110
8111 2019-02-15  Tom Tromey  <tromey@adacore.com>
8112
8113         * ravenscar-thread.c (is_ravenscar_task)
8114         (ravenscar_task_is_currently_active): Return bool.
8115         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8116         (_initialize_ravenscar): Remove "(void)".
8117         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8118         Return bool.
8119
8120 2019-02-15  Tom Tromey  <tromey@adacore.com>
8121
8122         * ravenscar-thread.c (ravenscar_runtime_initializer)
8123         (has_ravenscar_runtime, get_running_thread_id)
8124         (ravenscar_thread_target::resume): Fix indentation.
8125
8126 2019-02-15  Tom Tromey  <tromey@adacore.com>
8127
8128         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8129         from ravenscar_arch_ops.
8130         (sparc_ravenscar_ops::fetch_registers)
8131         (sparc_ravenscar_ops::store_registers): Now methods.
8132         (sparc_ravenscar_prepare_to_store): Remove.
8133         (sparc_ravenscar_ops): Redefine.
8134         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8135         methods and destructor.  Remove members.
8136         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8137         (ravenscar_thread_target::store_registers)
8138         (ravenscar_thread_target::prepare_to_store): Update.
8139         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8140         Remove.
8141         (struct ppc_ravenscar_powerpc_ops): Derive from
8142         ravenscar_arch_ops.
8143         (ppc_ravenscar_powerpc_ops::fetch_registers)
8144         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8145         (ppc_ravenscar_powerpc_ops): Redefine.
8146         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8147         (ppc_ravenscar_e500_ops::fetch_registers)
8148         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8149         (ppc_ravenscar_e500_ops): Redefine.
8150         * aarch64-ravenscar-thread.c
8151         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8152         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8153         (aarch64_ravenscar_fetch_registers)
8154         (aarch64_ravenscar_store_registers): Now methods.
8155         (aarch64_ravenscar_ops): Redefine.
8156
8157 2019-02-15  Tom Tromey  <tromey@adacore.com>
8158
8159         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8160         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8161         (ravenscar_thread_target::stopped_by_watchpoint)
8162         (ravenscar_thread_target::stopped_data_address)
8163         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8164
8165 2019-02-15  Tom Tromey  <tromey@adacore.com>
8166
8167         * ravenscar-thread.c: Fix some typos.
8168
8169 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8170             Tom Tromey  <tromey@adacore.com>
8171
8172         * ada-lang.c (ada_exception_sal): Change addr_string to a
8173         std::string.
8174         (create_ada_exception_catchpoint): Update.
8175
8176 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8177             Tom Tromey  <tromey@adacore.com>
8178
8179         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8180         (bp_location_ops): Remove.
8181         (base_breakpoint_allocate_location): Update.
8182         (free_bp_location): Update.
8183         * ada-lang.c (class ada_catchpoint_location)
8184         <ada_catchpoint_location>: Remove ops parameter.
8185         (ada_catchpoint_location_dtor): Remove.
8186         (ada_catchpoint_location_ops): Remove.
8187         (allocate_location_exception): Update.
8188         * breakpoint.h (struct bp_location_ops): Remove.
8189         (class bp_location) <bp_location>: Remove bp_location_ops
8190         parameter.
8191         <~bp_location>: Add destructor.
8192         <ops>: Remove.
8193
8194 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8195             Pedro Alves  <palves@redhat.com>
8196
8197         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8198         'PATH_MAX'.
8199
8200 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8201             Samuel Thibault  <samuel.thibault@gnu.org>
8202             Thomas Schwinge  <thomas@codesourcery.com>
8203
8204         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8205         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8206
8207 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8208
8209         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8210         (check_empty): Use "const char *".
8211
8212         * gnu-nat.c (gnu_nat_target::detach): Instead of
8213         'detach_inferior (pid)' call
8214         'detach_inferior (find_inferior_pid (pid))'.
8215
8216         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8217         'nat/fork-inferior.o'.
8218         * gnu-nat.c: #include "nat/fork-inferior.h".
8219
8220         * gnu-nat.c (gnu_nat_target::detach): Instead of
8221         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8222         * gnu-nat.h: #include "inf-child.h".
8223         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8224         'i386_gnu_nat_target::fetch_registers'.
8225         (gnu_store_registers): Rename/move to
8226         'i386_gnu_nat_target::store_registers'.
8227
8228         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8229         * gnu-nat.h (mach_thread_info): New function.
8230         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8231
8232         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8233
8234 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8235
8236         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8237
8238 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8239
8240         * windows-nat.c (windows_add_thread): Add new parameter
8241         "main_thread_p" with default value set to false.  Update
8242         function documentation as well as all callers.
8243         (windows_delete_thread): Likewise.
8244         (fake_create_process): Update call to windows_add_thread.
8245         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8246         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8247         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8248         call to windows_delete_thread.
8249
8250 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8251
8252         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8253
8254 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8255
8256         * symfile.c (find_separate_debug_file): Use canonical path of
8257         sysroot with child_path instead of gdb_sysroot if it is valid.
8258
8259 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8260
8261         * symfile.c (find_separate_debug_file): Use child_path to
8262         determine if an object file is under a sysroot.
8263
8264 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8265
8266         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8267         unittests/child-path-selftests.c.
8268         * common/pathstuff.c (child_path): New function.
8269         * common/pathstuff.h (child_path): New prototype.
8270         * unittests/child-path-selftests.c: New file.
8271
8272 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8273
8274         * symfile.c (find_separate_debug_file): Look for separate debug
8275         files in debug directories under the sysroot.
8276
8277 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8278
8279         * symtab.h (struct minimal_symbol data_p): New const method.
8280         (struct minimal_symbol text_p): Likewise.
8281         * symtab.c (output_source_filename): Use file name style
8282         to print file name.
8283         (print_symbol_info): Likewise.
8284         (print_msymbol_info): Use address style to print addresses.
8285         Use function name style to print executable text symbols.
8286         (expand_symtab_containing_pc): Use data_p.
8287         (find_pc_sect_compunit_symtab): Likewise.
8288
8289 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8290
8291         * breakpoint.c (describe_other_breakpoints): Use address style
8292         to print addresses.
8293         (say_where): Likewise.
8294
8295 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8296
8297         * ada-typeprint.c (print_func_type): Print function name
8298         style to print function name.
8299         * c-typeprint.c (c_print_type_1): Likewise.
8300
8301 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8302
8303         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8304         for execve.
8305
8306 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8307
8308         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8309         type_stack.
8310
8311 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8312
8313         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8314         TYPE_CODE_REF types.
8315
8316 2019-02-08  Jim Wilson  <jimw@sifive.com>
8317
8318         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8319         (riscv_linux_fregset): New.
8320         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8321
8322 2019-02-07  Tom Tromey  <tom@tromey.com>
8323
8324         * thread.c (thread_cancel_execution_command): Update.
8325         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8326         methods.
8327         (struct thread_fsm_ops): Remove.
8328         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8329         (thread_fsm_should_stop, thread_fsm_return_value)
8330         (thread_fsm_set_finished, thread_fsm_finished_p)
8331         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8332         Don't declare.
8333         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8334         * infrun.c (clear_proceed_status_thread)
8335         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8336         (print_stop_event): Update.
8337         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8338         Add constructor.
8339         (step_command_fsm_ops): Remove.
8340         (new_step_command_fsm): Remove.
8341         (step_1): Update.
8342         (step_command_fsm::should_stop): Rename from
8343         step_command_fsm_should_stop.
8344         (step_command_fsm::clean_up): Rename from
8345         step_command_fsm_clean_up.
8346         (step_command_fsm::do_async_reply_reason): Rename from
8347         step_command_fsm_async_reply_reason.
8348         (struct until_next_fsm): Inherit from thread_fsm.  Add
8349         constructor.
8350         (until_next_fsm_ops): Remove.
8351         (new_until_next_fsm): Remove.
8352         (until_next_fsm::should_stop): Rename from
8353         until_next_fsm_should_stop.
8354         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8355         (until_next_fsm::do_async_reply_reason): Rename from
8356         until_next_fsm_async_reply_reason.
8357         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8358         constructor.  Change type of breakpoint.
8359         (finish_command_fsm_ops): Remove.
8360         (new_finish_command_fsm): Remove.
8361         (finish_command_fsm::should_stop): Rename from
8362         finish_command_fsm_should_stop.
8363         (finish_command_fsm::clean_up): Rename from
8364         finish_command_fsm_clean_up.
8365         (finish_command_fsm::return_value): Rename from
8366         finish_command_fsm_return_value.
8367         (finish_command_fsm::do_async_reply_reason): Rename from
8368         finish_command_fsm_async_reply_reason.
8369         (finish_command): Update.
8370         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8371         Add constructor.
8372         (call_thread_fsm_ops): Remove.
8373         (call_thread_fsm::call_thread_fsm): Rename from
8374         new_call_thread_fsm.
8375         (call_thread_fsm::should_stop): Rename from
8376         call_thread_fsm_should_stop.
8377         (call_thread_fsm::should_notify_stop): Rename from
8378         call_thread_fsm_should_notify_stop.
8379         (run_inferior_call, call_function_by_hand_dummy): Update.
8380         * cli/cli-interp.c (should_print_stop_to_console): Update.
8381         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8382         Add constructor.  Change type of location_breakpoint,
8383         caller_breakpoint.
8384         (until_break_fsm_ops): Remove.
8385         (new_until_break_fsm): Remove.
8386         (until_break_fsm::should_stop): Rename from
8387         until_break_fsm_should_stop.
8388         (until_break_fsm::clean_up): Rename from
8389         until_break_fsm_clean_up.
8390         (until_break_fsm::do_async_reply_reason): Rename from
8391         until_break_fsm_async_reply_reason.
8392         (until_break_command): Update.
8393         * thread-fsm.c: Remove.
8394         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8395
8396 2019-02-07  Tom Tromey  <tom@tromey.com>
8397
8398         * yy-remap.h: Add include guard.
8399         * xtensa-tdep.h: Add include guard.
8400         * xcoffread.h: Rename include guard.
8401         * varobj-iter.h: Add include guard.
8402         * tui/tui.h: Rename include guard.
8403         * tui/tui-winsource.h: Rename include guard.
8404         * tui/tui-wingeneral.h: Rename include guard.
8405         * tui/tui-windata.h: Rename include guard.
8406         * tui/tui-win.h: Rename include guard.
8407         * tui/tui-stack.h: Rename include guard.
8408         * tui/tui-source.h: Rename include guard.
8409         * tui/tui-regs.h: Rename include guard.
8410         * tui/tui-out.h: Rename include guard.
8411         * tui/tui-layout.h: Rename include guard.
8412         * tui/tui-io.h: Rename include guard.
8413         * tui/tui-hooks.h: Rename include guard.
8414         * tui/tui-file.h: Rename include guard.
8415         * tui/tui-disasm.h: Rename include guard.
8416         * tui/tui-data.h: Rename include guard.
8417         * tui/tui-command.h: Rename include guard.
8418         * tic6x-tdep.h: Add include guard.
8419         * target/waitstatus.h: Rename include guard.
8420         * target/wait.h: Rename include guard.
8421         * target/target.h: Rename include guard.
8422         * target/resume.h: Rename include guard.
8423         * target-float.h: Rename include guard.
8424         * stabsread.h: Add include guard.
8425         * rs6000-tdep.h: Add include guard.
8426         * riscv-fbsd-tdep.h: Add include guard.
8427         * regformats/regdef.h: Rename include guard.
8428         * record.h: Rename include guard.
8429         * python/python.h: Rename include guard.
8430         * python/python-internal.h: Rename include guard.
8431         * python/py-stopevent.h: Rename include guard.
8432         * python/py-ref.h: Rename include guard.
8433         * python/py-record.h: Rename include guard.
8434         * python/py-record-full.h: Rename include guard.
8435         * python/py-record-btrace.h: Rename include guard.
8436         * python/py-instruction.h: Rename include guard.
8437         * python/py-events.h: Rename include guard.
8438         * python/py-event.h: Rename include guard.
8439         * procfs.h: Add include guard.
8440         * proc-utils.h: Add include guard.
8441         * p-lang.h: Add include guard.
8442         * or1k-tdep.h: Rename include guard.
8443         * observable.h: Rename include guard.
8444         * nto-tdep.h: Rename include guard.
8445         * nat/x86-linux.h: Rename include guard.
8446         * nat/x86-linux-dregs.h: Rename include guard.
8447         * nat/x86-gcc-cpuid.h: Add include guard.
8448         * nat/x86-dregs.h: Rename include guard.
8449         * nat/x86-cpuid.h: Rename include guard.
8450         * nat/ppc-linux.h: Rename include guard.
8451         * nat/mips-linux-watch.h: Rename include guard.
8452         * nat/linux-waitpid.h: Rename include guard.
8453         * nat/linux-ptrace.h: Rename include guard.
8454         * nat/linux-procfs.h: Rename include guard.
8455         * nat/linux-osdata.h: Rename include guard.
8456         * nat/linux-nat.h: Rename include guard.
8457         * nat/linux-namespaces.h: Rename include guard.
8458         * nat/linux-btrace.h: Rename include guard.
8459         * nat/glibc_thread_db.h: Rename include guard.
8460         * nat/gdb_thread_db.h: Rename include guard.
8461         * nat/gdb_ptrace.h: Rename include guard.
8462         * nat/fork-inferior.h: Rename include guard.
8463         * nat/amd64-linux-siginfo.h: Rename include guard.
8464         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8465         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8466         * nat/aarch64-linux.h: Rename include guard.
8467         * nat/aarch64-linux-hw-point.h: Rename include guard.
8468         * mn10300-tdep.h: Add include guard.
8469         * mips-linux-tdep.h: Add include guard.
8470         * mi/mi-parse.h: Rename include guard.
8471         * mi/mi-out.h: Rename include guard.
8472         * mi/mi-main.h: Rename include guard.
8473         * mi/mi-interp.h: Rename include guard.
8474         * mi/mi-getopt.h: Rename include guard.
8475         * mi/mi-console.h: Rename include guard.
8476         * mi/mi-common.h: Rename include guard.
8477         * mi/mi-cmds.h: Rename include guard.
8478         * mi/mi-cmd-break.h: Rename include guard.
8479         * m2-lang.h: Add include guard.
8480         * location.h: Rename include guard.
8481         * linux-record.h: Rename include guard.
8482         * linux-nat.h: Add include guard.
8483         * linux-fork.h: Add include guard.
8484         * i386-darwin-tdep.h: Rename include guard.
8485         * hppa-linux-offsets.h: Add include guard.
8486         * guile/guile.h: Rename include guard.
8487         * guile/guile-internal.h: Rename include guard.
8488         * gnu-nat.h: Rename include guard.
8489         * gdb-stabs.h: Rename include guard.
8490         * frv-tdep.h: Add include guard.
8491         * f-lang.h: Add include guard.
8492         * event-loop.h: Add include guard.
8493         * darwin-nat.h: Rename include guard.
8494         * cp-abi.h: Rename include guard.
8495         * config/sparc/nm-sol2.h: Rename include guard.
8496         * config/nm-nto.h: Rename include guard.
8497         * config/nm-linux.h: Add include guard.
8498         * config/i386/nm-i386gnu.h: Rename include guard.
8499         * config/djgpp/nl_types.h: Rename include guard.
8500         * config/djgpp/langinfo.h: Rename include guard.
8501         * compile/gcc-cp-plugin.h: Add include guard.
8502         * compile/gcc-c-plugin.h: Add include guard.
8503         * compile/compile.h: Rename include guard.
8504         * compile/compile-object-run.h: Rename include guard.
8505         * compile/compile-object-load.h: Rename include guard.
8506         * compile/compile-internal.h: Rename include guard.
8507         * compile/compile-cplus.h: Rename include guard.
8508         * compile/compile-c.h: Rename include guard.
8509         * common/xml-utils.h: Rename include guard.
8510         * common/x86-xstate.h: Rename include guard.
8511         * common/version.h: Rename include guard.
8512         * common/vec.h: Rename include guard.
8513         * common/tdesc.h: Rename include guard.
8514         * common/selftest.h: Rename include guard.
8515         * common/scoped_restore.h: Rename include guard.
8516         * common/scoped_mmap.h: Rename include guard.
8517         * common/scoped_fd.h: Rename include guard.
8518         * common/safe-iterator.h: Rename include guard.
8519         * common/run-time-clock.h: Rename include guard.
8520         * common/refcounted-object.h: Rename include guard.
8521         * common/queue.h: Rename include guard.
8522         * common/ptid.h: Rename include guard.
8523         * common/print-utils.h: Rename include guard.
8524         * common/preprocessor.h: Rename include guard.
8525         * common/pathstuff.h: Rename include guard.
8526         * common/observable.h: Rename include guard.
8527         * common/netstuff.h: Rename include guard.
8528         * common/job-control.h: Rename include guard.
8529         * common/host-defs.h: Rename include guard.
8530         * common/gdb_wait.h: Rename include guard.
8531         * common/gdb_vecs.h: Rename include guard.
8532         * common/gdb_unlinker.h: Rename include guard.
8533         * common/gdb_unique_ptr.h: Rename include guard.
8534         * common/gdb_tilde_expand.h: Rename include guard.
8535         * common/gdb_sys_time.h: Rename include guard.
8536         * common/gdb_string_view.h: Rename include guard.
8537         * common/gdb_splay_tree.h: Rename include guard.
8538         * common/gdb_setjmp.h: Rename include guard.
8539         * common/gdb_ref_ptr.h: Rename include guard.
8540         * common/gdb_optional.h: Rename include guard.
8541         * common/gdb_locale.h: Rename include guard.
8542         * common/gdb_assert.h: Rename include guard.
8543         * common/filtered-iterator.h: Rename include guard.
8544         * common/filestuff.h: Rename include guard.
8545         * common/fileio.h: Rename include guard.
8546         * common/environ.h: Rename include guard.
8547         * common/common-utils.h: Rename include guard.
8548         * common/common-types.h: Rename include guard.
8549         * common/common-regcache.h: Rename include guard.
8550         * common/common-inferior.h: Rename include guard.
8551         * common/common-gdbthread.h: Rename include guard.
8552         * common/common-exceptions.h: Rename include guard.
8553         * common/common-defs.h: Rename include guard.
8554         * common/common-debug.h: Rename include guard.
8555         * common/cleanups.h: Rename include guard.
8556         * common/buffer.h: Rename include guard.
8557         * common/btrace-common.h: Rename include guard.
8558         * common/break-common.h: Rename include guard.
8559         * cli/cli-utils.h: Rename include guard.
8560         * cli/cli-style.h: Rename include guard.
8561         * cli/cli-setshow.h: Rename include guard.
8562         * cli/cli-script.h: Rename include guard.
8563         * cli/cli-interp.h: Rename include guard.
8564         * cli/cli-decode.h: Rename include guard.
8565         * cli/cli-cmds.h: Rename include guard.
8566         * charset-list.h: Add include guard.
8567         * buildsym-legacy.h: Rename include guard.
8568         * bfin-tdep.h: Add include guard.
8569         * ax.h: Rename include guard.
8570         * arm-linux-tdep.h: Add include guard.
8571         * arm-fbsd-tdep.h: Add include guard.
8572         * arch/xtensa.h: Rename include guard.
8573         * arch/tic6x.h: Add include guard.
8574         * arch/i386.h: Add include guard.
8575         * arch/arm.h: Rename include guard.
8576         * arch/arm-linux.h: Rename include guard.
8577         * arch/arm-get-next-pcs.h: Rename include guard.
8578         * arch/amd64.h: Add include guard.
8579         * arch/aarch64-insn.h: Rename include guard.
8580         * arch-utils.h: Rename include guard.
8581         * annotate.h: Add include guard.
8582         * amd64-darwin-tdep.h: Rename include guard.
8583         * aarch64-linux-tdep.h: Add include guard.
8584         * aarch64-fbsd-tdep.h: Add include guard.
8585         * aarch32-linux-nat.h: Add include guard.
8586
8587 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8588
8589         * macrotab.c (macro_define_internal): New function that
8590         factorizes macro_define_object_internal and macro_define_function
8591         code.
8592         (macro_define_object_internal): Use macro_define_internal.
8593         (macro_define_function): Likewise.
8594
8595 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8596
8597         * macrocmd.c (extract_identifier): Return
8598         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8599         callers.
8600
8601 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8602
8603         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8604
8605 2019-02-05  Tom Tromey  <tom@tromey.com>
8606
8607         * target.c (target_stack::unpush): Move assertion earlier.
8608
8609 2019-01-30  Tom Tromey  <tom@tromey.com>
8610
8611         PR python/23615:
8612         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8613         (gdbpy_parse_and_eval): Likewise.
8614         * python/python-internal.h (gdbpy_allow_threads): New class.
8615
8616 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8617
8618         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8619         (aarch64_fbsd_fpregmap): Move earlier.
8620         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8621         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8622         instead of individual calls to trad_frame_set_reg_addr.
8623         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8624         earlier.
8625         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8626         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8627         instead of individual calls to trad_frame_set_reg_addr.
8628
8629 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8630
8631         * CONTRIBUTE: Replace contribution list with wiki link.
8632
8633 2019-01-25  Tom Tromey  <tom@tromey.com>
8634
8635         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8636
8637 2019-01-25  Tom Tromey  <tom@tromey.com>
8638
8639         * xtensa-linux-nat.c: Fix common/ includes.
8640         * xml-support.h: Fix common/ includes.
8641         * xml-support.c: Fix common/ includes.
8642         * x86-linux-nat.c: Fix common/ includes.
8643         * windows-nat.c: Fix common/ includes.
8644         * varobj.h: Fix common/ includes.
8645         * varobj.c: Fix common/ includes.
8646         * value.c: Fix common/ includes.
8647         * valops.c: Fix common/ includes.
8648         * utils.c: Fix common/ includes.
8649         * unittests/xml-utils-selftests.c: Fix common/ includes.
8650         * unittests/utils-selftests.c: Fix common/ includes.
8651         * unittests/unpack-selftests.c: Fix common/ includes.
8652         * unittests/tracepoint-selftests.c: Fix common/ includes.
8653         * unittests/style-selftests.c: Fix common/ includes.
8654         * unittests/string_view-selftests.c: Fix common/ includes.
8655         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8656         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8657         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8658         * unittests/rsp-low-selftests.c: Fix common/ includes.
8659         * unittests/parse-connection-spec-selftests.c: Fix common/
8660         includes.
8661         * unittests/optional-selftests.c: Fix common/ includes.
8662         * unittests/offset-type-selftests.c: Fix common/ includes.
8663         * unittests/observable-selftests.c: Fix common/ includes.
8664         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8665         * unittests/memrange-selftests.c: Fix common/ includes.
8666         * unittests/memory-map-selftests.c: Fix common/ includes.
8667         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8668         * unittests/function-view-selftests.c: Fix common/ includes.
8669         * unittests/environ-selftests.c: Fix common/ includes.
8670         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8671         * unittests/common-utils-selftests.c: Fix common/ includes.
8672         * unittests/cli-utils-selftests.c: Fix common/ includes.
8673         * unittests/array-view-selftests.c: Fix common/ includes.
8674         * ui-file.c: Fix common/ includes.
8675         * tui/tui-io.c: Fix common/ includes.
8676         * tracepoint.h: Fix common/ includes.
8677         * tracepoint.c: Fix common/ includes.
8678         * tracefile-tfile.c: Fix common/ includes.
8679         * top.h: Fix common/ includes.
8680         * top.c: Fix common/ includes.
8681         * thread.c: Fix common/ includes.
8682         * target/waitstatus.h: Fix common/ includes.
8683         * target/waitstatus.c: Fix common/ includes.
8684         * target.h: Fix common/ includes.
8685         * target.c: Fix common/ includes.
8686         * target-memory.c: Fix common/ includes.
8687         * target-descriptions.c: Fix common/ includes.
8688         * symtab.h: Fix common/ includes.
8689         * symfile.c: Fix common/ includes.
8690         * stap-probe.c: Fix common/ includes.
8691         * spu-linux-nat.c: Fix common/ includes.
8692         * sparc-nat.c: Fix common/ includes.
8693         * source.c: Fix common/ includes.
8694         * solib.c: Fix common/ includes.
8695         * solib-target.c: Fix common/ includes.
8696         * ser-unix.c: Fix common/ includes.
8697         * ser-tcp.c: Fix common/ includes.
8698         * ser-pipe.c: Fix common/ includes.
8699         * ser-base.c: Fix common/ includes.
8700         * selftest-arch.c: Fix common/ includes.
8701         * s12z-tdep.c: Fix common/ includes.
8702         * rust-exp.y: Fix common/ includes.
8703         * rs6000-aix-tdep.c: Fix common/ includes.
8704         * riscv-tdep.c: Fix common/ includes.
8705         * remote.c: Fix common/ includes.
8706         * remote-notif.h: Fix common/ includes.
8707         * remote-fileio.h: Fix common/ includes.
8708         * remote-fileio.c: Fix common/ includes.
8709         * regcache.h: Fix common/ includes.
8710         * regcache.c: Fix common/ includes.
8711         * record-btrace.c: Fix common/ includes.
8712         * python/python.c: Fix common/ includes.
8713         * python/py-type.c: Fix common/ includes.
8714         * python/py-inferior.c: Fix common/ includes.
8715         * progspace.h: Fix common/ includes.
8716         * producer.c: Fix common/ includes.
8717         * procfs.c: Fix common/ includes.
8718         * proc-api.c: Fix common/ includes.
8719         * printcmd.c: Fix common/ includes.
8720         * ppc-linux-nat.c: Fix common/ includes.
8721         * parser-defs.h: Fix common/ includes.
8722         * osdata.c: Fix common/ includes.
8723         * obsd-nat.c: Fix common/ includes.
8724         * nat/x86-linux.c: Fix common/ includes.
8725         * nat/x86-linux-dregs.c: Fix common/ includes.
8726         * nat/x86-dregs.h: Fix common/ includes.
8727         * nat/x86-dregs.c: Fix common/ includes.
8728         * nat/ppc-linux.c: Fix common/ includes.
8729         * nat/mips-linux-watch.h: Fix common/ includes.
8730         * nat/mips-linux-watch.c: Fix common/ includes.
8731         * nat/linux-waitpid.c: Fix common/ includes.
8732         * nat/linux-ptrace.h: Fix common/ includes.
8733         * nat/linux-ptrace.c: Fix common/ includes.
8734         * nat/linux-procfs.c: Fix common/ includes.
8735         * nat/linux-personality.c: Fix common/ includes.
8736         * nat/linux-osdata.c: Fix common/ includes.
8737         * nat/linux-namespaces.c: Fix common/ includes.
8738         * nat/linux-btrace.h: Fix common/ includes.
8739         * nat/linux-btrace.c: Fix common/ includes.
8740         * nat/fork-inferior.c: Fix common/ includes.
8741         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8742         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8743         * nat/aarch64-linux.c: Fix common/ includes.
8744         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8745         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8746         * namespace.h: Fix common/ includes.
8747         * mips-linux-tdep.c: Fix common/ includes.
8748         * minsyms.c: Fix common/ includes.
8749         * mi/mi-parse.h: Fix common/ includes.
8750         * mi/mi-main.c: Fix common/ includes.
8751         * mi/mi-cmd-env.c: Fix common/ includes.
8752         * memrange.h: Fix common/ includes.
8753         * memattr.c: Fix common/ includes.
8754         * maint.h: Fix common/ includes.
8755         * maint.c: Fix common/ includes.
8756         * main.c: Fix common/ includes.
8757         * machoread.c: Fix common/ includes.
8758         * location.c: Fix common/ includes.
8759         * linux-thread-db.c: Fix common/ includes.
8760         * linux-nat.c: Fix common/ includes.
8761         * linux-fork.c: Fix common/ includes.
8762         * inline-frame.c: Fix common/ includes.
8763         * infrun.c: Fix common/ includes.
8764         * inflow.c: Fix common/ includes.
8765         * inferior.h: Fix common/ includes.
8766         * inferior.c: Fix common/ includes.
8767         * infcmd.c: Fix common/ includes.
8768         * inf-ptrace.c: Fix common/ includes.
8769         * inf-child.c: Fix common/ includes.
8770         * ia64-linux-nat.c: Fix common/ includes.
8771         * i387-tdep.c: Fix common/ includes.
8772         * i386-tdep.c: Fix common/ includes.
8773         * i386-linux-tdep.c: Fix common/ includes.
8774         * i386-linux-nat.c: Fix common/ includes.
8775         * i386-go32-tdep.c: Fix common/ includes.
8776         * i386-fbsd-tdep.c: Fix common/ includes.
8777         * i386-fbsd-nat.c: Fix common/ includes.
8778         * guile/scm-type.c: Fix common/ includes.
8779         * guile/guile.c: Fix common/ includes.
8780         * go32-nat.c: Fix common/ includes.
8781         * gnu-nat.c: Fix common/ includes.
8782         * gdbthread.h: Fix common/ includes.
8783         * gdbarch-selftests.c: Fix common/ includes.
8784         * gdb_usleep.c: Fix common/ includes.
8785         * gdb_select.h: Fix common/ includes.
8786         * gdb_bfd.c: Fix common/ includes.
8787         * gcore.c: Fix common/ includes.
8788         * fork-child.c: Fix common/ includes.
8789         * findvar.c: Fix common/ includes.
8790         * fbsd-nat.c: Fix common/ includes.
8791         * event-top.c: Fix common/ includes.
8792         * event-loop.c: Fix common/ includes.
8793         * dwarf2read.c: Fix common/ includes.
8794         * dwarf2loc.c: Fix common/ includes.
8795         * dwarf2-frame.c: Fix common/ includes.
8796         * dwarf-index-cache.c: Fix common/ includes.
8797         * dtrace-probe.c: Fix common/ includes.
8798         * disasm-selftests.c: Fix common/ includes.
8799         * defs.h: Fix common/ includes.
8800         * csky-tdep.c: Fix common/ includes.
8801         * cp-valprint.c: Fix common/ includes.
8802         * cp-support.h: Fix common/ includes.
8803         * cp-support.c: Fix common/ includes.
8804         * corelow.c: Fix common/ includes.
8805         * completer.h: Fix common/ includes.
8806         * completer.c: Fix common/ includes.
8807         * compile/compile.c: Fix common/ includes.
8808         * compile/compile-loc2c.c: Fix common/ includes.
8809         * compile/compile-cplus-types.c: Fix common/ includes.
8810         * compile/compile-cplus-symbols.c: Fix common/ includes.
8811         * command.h: Fix common/ includes.
8812         * cli/cli-dump.c: Fix common/ includes.
8813         * cli/cli-cmds.c: Fix common/ includes.
8814         * charset.c: Fix common/ includes.
8815         * build-id.c: Fix common/ includes.
8816         * btrace.h: Fix common/ includes.
8817         * btrace.c: Fix common/ includes.
8818         * breakpoint.h: Fix common/ includes.
8819         * breakpoint.c: Fix common/ includes.
8820         * ax.h:
8821         (enum agent_op): Fix common/ includes.
8822         * ax-general.c (struct aop_map): Fix common/ includes.
8823         * ax-gdb.c: Fix common/ includes.
8824         * auxv.c: Fix common/ includes.
8825         * auto-load.c: Fix common/ includes.
8826         * arm-tdep.c: Fix common/ includes.
8827         * arch/riscv.c: Fix common/ includes.
8828         * arch/ppc-linux-common.c: Fix common/ includes.
8829         * arch/i386.c: Fix common/ includes.
8830         * arch/arm.c: Fix common/ includes.
8831         * arch/arm-linux.c: Fix common/ includes.
8832         * arch/arm-get-next-pcs.c: Fix common/ includes.
8833         * arch/amd64.c: Fix common/ includes.
8834         * arch/aarch64.c: Fix common/ includes.
8835         * arch/aarch64-insn.c: Fix common/ includes.
8836         * arch-utils.c: Fix common/ includes.
8837         * amd64-windows-tdep.c: Fix common/ includes.
8838         * amd64-tdep.c: Fix common/ includes.
8839         * amd64-sol2-tdep.c: Fix common/ includes.
8840         * amd64-obsd-tdep.c: Fix common/ includes.
8841         * amd64-nbsd-tdep.c: Fix common/ includes.
8842         * amd64-linux-tdep.c: Fix common/ includes.
8843         * amd64-linux-nat.c: Fix common/ includes.
8844         * amd64-fbsd-tdep.c: Fix common/ includes.
8845         * amd64-fbsd-nat.c: Fix common/ includes.
8846         * amd64-dicos-tdep.c: Fix common/ includes.
8847         * amd64-darwin-tdep.c: Fix common/ includes.
8848         * agent.c: Fix common/ includes.
8849         * ada-lang.h: Fix common/ includes.
8850         * ada-lang.c: Fix common/ includes.
8851         * aarch64-tdep.c: Fix common/ includes.
8852
8853 2019-01-25  Tom Tromey  <tom@tromey.com>
8854
8855         * common/create-version.sh: Use common/version.h.
8856
8857 2019-01-24  Pedro Alves  <palves@redhat.com>
8858
8859         * infrun.c (signal_stop, signal_print, signal_program)
8860         (signal_catch, signal_pass): Now arrays instead of pointers.
8861         (update_signals_program_target, do_target_resume)
8862         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8863         * linux-nat.c (linux_nat_target::pass_signals)
8864         (linux_nat_target::create_inferior, linux_nat_target::attach):
8865         Adjust.
8866         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8867         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8868         * procfs.c (procfs_target::pass_signals): Adjust.
8869         * record-full.c (record_full_target::resume): Adjust.
8870         * remote.c (remote_target::pass_signals)
8871         (remote_target::program_signals): Adjust.
8872         * target-debug.h (target_debug_print_signals): Now takes a
8873         gdb::array_view as parameter.  Adjust.
8874         * target.h (target_ops) <pass_signals, program_signals>: Replace
8875         pointer and length parameters with gdb::array_view.
8876         (target_pass_signals, target_program_signals): Likewise.
8877         * target-delegates.c: Regenerate.
8878
8879 2019-01-24  Pedro Alves  <palves@redhat.com>
8880
8881         * common/forward-scope-exit.h
8882         (forward_scope_exit::forward_scope_exit): Pass arguments to
8883         m_bind_function directly, instead of creating a std::bind and
8884         copying that.
8885
8886 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8887
8888         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8889         for static members.
8890         (pass_in_v_vfp_candidate): Likewise.
8891
8892 2019-01-23  Tom Tromey  <tom@tromey.com>
8893             Pedro Alves  <palves@redhat.com>
8894
8895         * regcache.c (class regcache_invalidator): Remove.
8896         (regcache::raw_write): Use make_scope_exit.
8897
8898 2019-01-23  Tom Tromey  <tom@tromey.com>
8899
8900         * ui-out.h (class ui_out_emit_type): Update comment.
8901
8902 2019-01-23  Tom Tromey  <tom@tromey.com>
8903
8904         * infrun.c (fetch_inferior_event): Update comment.
8905
8906 2019-01-23  Tom Tromey  <tom@tromey.com>
8907             Pedro Alves  <palves@redhat.com>
8908
8909         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8910         parameter.
8911         (fetch_inferior_event): Use SCOPE_EXIT.
8912
8913
8914 2019-01-23  Tom Tromey  <tom@tromey.com>
8915             Pedro Alves  <palves@redhat.com>
8916
8917         * infrun.c (disable_thread_events): Delete.
8918         (stop_all_threads): Use SCOPE_EXIT.
8919
8920 2019-01-23  Tom Tromey  <tom@tromey.com>
8921             Pedro Alves  <palves@redhat.com>
8922
8923         * symfile.c: Include forward-scope-exit.h.
8924         (clear_symtab_users_cleanup): Replace forward declaration with
8925         a FORWARD_SCOPE_EXIT.
8926         (syms_from_objfile_1): Use the forward_scope_exit and
8927         gdb::optional instead of cleanup_function.
8928         (reread_symbols): Use the forward_scope_exit instead of
8929         cleanup_function.
8930         (clear_symtab_users_cleanup): Remove function.
8931
8932 2019-01-23  Tom Tromey  <tom@tromey.com>
8933             Pedro Alves  <palves@redhat.com>
8934
8935         * linux-nat.c: Include scope-exit.h.
8936         (cleanup_target_stop): Remove.
8937         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8938         SCOPE_EXIT.
8939
8940 2019-01-23  Tom Tromey  <tom@tromey.com>
8941             Pedro Alves  <palves@redhat.com>
8942
8943         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8944         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8945
8946 2019-01-23  Tom Tromey  <tom@tromey.com>
8947             Andrew Burgess  <andrew.burgess@embecosm.com>
8948             Pedro Alves  <palves@redhat.com>
8949
8950         * infrun.c (fetch_inferior_event): Use scope_exit.
8951         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8952         * top.c (execute_command): Use scope_exit.
8953         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8954         * utils.c (do_bpstat_clear_actions_cleanup)
8955         (make_bpstat_clear_actions_cleanup): Remove.
8956
8957 2019-01-23  Tom Tromey  <tom@tromey.com>
8958             Pedro Alves  <palves@redhat.com>
8959
8960         * infrun.c: Include "common/scope-exit.h"
8961         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8962         (wait_for_inferior): Use SCOPE_EXIT.
8963         (fetch_inferior_event): Use scope_exit.
8964
8965 2019-01-23  Tom Tromey  <tom@tromey.com>
8966             Pedro Alves  <palves@redhat.com>
8967
8968         * breakpoint.c (create_breakpoint): Remove cleanup.
8969
8970 2019-01-23  Tom Tromey  <tom@tromey.com>
8971             Andrew Burgess  <andrew.burgess@embecosm.com>
8972             Pedro Alves  <palves@redhat.com>
8973
8974 2019-01-23  Pedro Alves  <palves@redhat.com>
8975
8976         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8977
8978 2019-01-23  Pedro Alves  <palves@redhat.com>
8979             Andrew Burgess  <andrew.burgess@embecosm.com>
8980
8981         * gdbthread.h: Include "common/forward-scope-exit.h".
8982         (scoped_finish_thread_state): Redefine custom class in terms of
8983         forward_scope_exit.
8984
8985 2019-01-23  Pedro Alves  <palves@redhat.com>
8986             Andrew Burgess  <andrew.burgess@embecosm.com>
8987
8988         * common/forward-scope-exit.h: New file.
8989
8990 2019-01-23  Pedro Alves  <palves@redhat.com>
8991             Andrew Burgess  <andrew.burgess@embecosm.com>
8992             Tom Tromey  <tom@tromey.com>
8993
8994         * common/scope-exit.h: New file.
8995
8996 2019-01-23  Pedro Alves  <palves@redhat.com>
8997
8998         * common/preprocessor.h (ESC): Rename to ...
8999         (ESC_PARENS): ... this.
9000         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9001         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9002
9003 2019-01-23  Tom Tromey  <tom@tromey.com>
9004
9005         * language.h (class scoped_switch_to_sym_language_if_auto):
9006         Initialize m_lang in both cases.
9007
9008 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9009
9010         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9011         with XCNEW.
9012
9013 2019-01-22  Tom Tromey  <tom@tromey.com>
9014
9015         * corelow.c: Do not include sys/file.h.
9016
9017 2019-01-22  Tom Tromey  <tom@tromey.com>
9018
9019         * tui/tui-wingeneral.h: Include gdb_curses.h.
9020
9021 2019-01-22  Tom Tromey  <tom@tromey.com>
9022
9023         * source-cache.h (class source_cache) <get_source_lines,
9024         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9025
9026 2019-01-22  Tom Tromey  <tom@tromey.com>
9027
9028         * remote-fileio.h (struct remote_target): Declare.
9029
9030 2019-01-22  Tom Tromey  <tom@tromey.com>
9031
9032         * python/py-arch.c: Do not include py-ref.h.
9033         * python/py-bpevent.c: Do not include py-ref.h.
9034         * python/py-cmd.c: Do not include py-ref.h.
9035         * python/py-continueevent.c: Do not include py-ref.h.
9036         * python/py-event.h: Do not include py-ref.h.
9037         * python/py-evtregistry.c: Do not include py-ref.h.
9038         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9039         * python/py-frame.c: Do not include py-ref.h.
9040         * python/py-framefilter.c: Do not include py-ref.h.
9041         * python/py-function.c: Do not include py-ref.h.
9042         * python/py-infevents.c: Do not include py-ref.h.
9043         * python/py-linetable.c: Do not include py-ref.h.
9044         * python/py-objfile.c: Do not include py-ref.h.
9045         * python/py-param.c: Do not include py-ref.h.
9046         * python/py-prettyprint.c: Do not include py-ref.h.
9047         * python/py-progspace.c: Do not include py-ref.h.
9048         * python/py-symbol.c: Do not include py-ref.h.
9049         * python/py-symtab.c: Do not include py-ref.h.
9050         * python/py-type.c: Do not include py-ref.h.
9051         * python/py-unwind.c: Do not include py-ref.h.
9052         * python/py-utils.c: Do not include py-ref.h.
9053         * python/py-value.c: Do not include py-ref.h.
9054         * python/py-varobj.c: Do not include py-ref.h.
9055         * python/py-xmethods.c: Do not include py-ref.h.
9056         * python/python.c: Do not include py-ref.h.
9057         * varobj.c: Do not include py-ref.h.
9058
9059 2019-01-22  Tom Tromey  <tom@tromey.com>
9060
9061         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9062         keyword for bcache.
9063
9064 2019-01-22  Tom Tromey  <tom@tromey.com>
9065
9066         * compile/compile-cplus-types.c: Remove a comment by #include.
9067
9068 2019-01-22  Tom Tromey  <tom@tromey.com>
9069
9070         * compile/gcc-c-plugin.h: Include compile-internal.h.
9071
9072 2019-01-22  Tom Tromey  <tom@tromey.com>
9073
9074         * stabsread.c (EXTERN): Do not define.
9075         (symnum, next_symbol_text_func, processing_gcc_compilation)
9076         (within_function, global_sym_chain, global_stabs)
9077         (previous_stab_code, this_object_header_files)
9078         (n_this_object_header_files)
9079         (n_allocated_this_object_header_files): Define.
9080         * stabsread.h (EXTERN): Never define.  Use "extern".
9081
9082 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9083
9084         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9085         history_value.
9086
9087 2019-01-21  Tom Tromey  <tom@tromey.com>
9088
9089         * ui-out.c: Fix includes.
9090         * tui/tui-source.c: Fix includes.
9091         * target.c: Fix includes.
9092         * remote.c: Fix includes.
9093         * regcache.c: Fix includes.
9094         * python/py-block.c: Fix includes.
9095         * printcmd.c: Fix includes.
9096         * or1k-tdep.c: Fix includes.
9097         * mi/mi-main.c: Fix includes.
9098         * m32r-tdep.c: Fix includes.
9099         * csky-tdep.c: Fix includes.
9100         * compile/compile-cplus-types.c: Fix includes.
9101         * cli/cli-interp.c: Fix includes.
9102
9103 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9104
9105         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9106         for padding.
9107
9108 2019-01-16  Tom Tromey  <tom@tromey.com>
9109
9110         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9111         earlier.
9112         (struct objfile) <msymbols_range>: Move from top level.
9113         <msymbols>: New method.
9114         (class objfile_msymbols): Remove.
9115         * symtab.c (default_collect_symbol_completion_matches_break_on):
9116         Update.
9117         * symmisc.c (dump_msymbols): Update.
9118         * stabsread.c (scan_file_globals): Update.
9119         * objc-lang.c (info_selectors_command, info_classes_command)
9120         (find_methods): Update.
9121         * minsyms.c (find_solib_trampoline_target): Update.
9122         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9123         * coffread.c (coff_symfile_read): Update.
9124         * ada-lang.c (ada_lookup_simple_minsym)
9125         (ada_collect_symbol_completion_matches): Update.
9126
9127 2019-01-16  Tom Tromey  <tom@tromey.com>
9128
9129         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9130         type.  Remove no-argument constructor.
9131         <iterator::operator++>: Simplify.
9132         <begin>: Update.
9133         <end>: Use minimal_symbol_count.
9134
9135 2019-01-16  Tom Tromey  <tom@tromey.com>
9136
9137         * objfiles.h (struct objfile) <psymtabs>: New method.
9138         (class objfile_psymtabs): Remove.
9139         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9140         typedef.
9141         <range>: New method.
9142         (require_partial_symbols): Change return type.
9143         * psymtab.c (require_partial_symbols)
9144         (psym_expand_symtabs_matching): Update.
9145         * mdebugread.c (parse_partial_symbols): Update.
9146         * dbxread.c (dbx_end_psymtab): Update.
9147
9148 2019-01-15  Tom Tromey  <tom@tromey.com>
9149
9150         * symtab.c (lookup_objfile_from_block)
9151         (lookup_symbol_in_objfile_symtabs)
9152         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9153         (find_line_symtab, info_sources_command)
9154         (default_collect_symbol_completion_matches_break_on)
9155         (make_source_files_completion_list): Update.
9156         * symmisc.c (print_objfile_statistics, dump_objfile)
9157         (maintenance_print_symbols, maintenance_info_symtabs)
9158         (maintenance_check_symtabs, maintenance_info_line_tables):
9159         Update.
9160         * source.c (select_source_symtab)
9161         (forget_cached_source_info_for_objfile): Update.
9162         * objfiles.h (class objfile_compunits): Remove.
9163         (struct objfile) <compunits_range>: New typedef.
9164         (compunits): New method.
9165         * objfiles.c (objfile_relocate1): Update.
9166         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9167         * maint.c (count_symtabs_and_blocks): Update.
9168         * linespec.c (iterate_over_all_matching_symtabs): Update.
9169         * cp-support.c (add_symbol_overload_list_qualified): Update.
9170         * coffread.c (coff_symtab_read): Update.
9171         * ada-lang.c (add_nonlocal_symbols)
9172         (ada_collect_symbol_completion_matches)
9173         (ada_add_global_exceptions): Update.
9174
9175 2019-01-15  Tom Tromey  <tom@tromey.com>
9176
9177         * progspace.h (program_space) <objfiles_safe_range>: New
9178         typedef.
9179         <objfiles_safe>: New method.
9180         * objfiles.h (class all_objfiles_safe): Remove.
9181         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9182         * jit.c (jit_inferior_exit_hook): Update.
9183
9184 2019-01-17  Tom Tromey  <tom@tromey.com>
9185
9186         * progspace.h (program_space) <objfiles_range>: New typedef.
9187         <objfiles>: New method.
9188         <objfiles_head>: Rename from objfiles.
9189         (object_files): Update.
9190         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9191         * guile/scm-pretty-print.c
9192         (ppscm_find_pretty_printer_from_objfiles): Update.
9193         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9194         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9195         Update.
9196         * python/py-progspace.c (pspy_get_objfiles): Update.
9197         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9198         Update.
9199         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9200         (objfpy_lookup_objfile_by_build_id): Update.
9201         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9202         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9203         Update.
9204         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9205         (expand_symtab_containing_pc, lookup_objfile_from_block)
9206         (lookup_static_symbol, basic_lookup_transparent_type)
9207         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9208         (find_line_symtab, info_sources_command)
9209         (default_collect_symbol_completion_matches_break_on)
9210         (make_source_files_completion_list, find_main_name): Update.
9211         * symmisc.c (print_symbol_bcache_statistics)
9212         (print_objfile_statistics, maintenance_print_symbols)
9213         (maintenance_print_msymbols, maintenance_print_objfiles)
9214         (maintenance_info_symtabs, maintenance_check_symtabs)
9215         (maintenance_expand_symtabs, maintenance_info_line_tables):
9216         Update.
9217         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9218         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9219         (map_overlay_command, unmap_overlay_command)
9220         (simple_overlay_update, expand_symtabs_matching)
9221         (map_symbol_filenames): Update.
9222         * symfile-debug.c (set_debug_symfile): Update.
9223         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9224         Update.
9225         * source.c (select_source_symtab, forget_cached_source_info):
9226         Update.
9227         * solib.c (solib_read_symbols): Update.
9228         * solib-spu.c (append_ocl_sos): Update.
9229         * psymtab.c (maintenance_print_psymbols)
9230         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9231         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9232         * printcmd.c (info_symbol_command): Update.
9233         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9234         Update.
9235         * objfiles.h (class all_objfiles): Remove.
9236         * objfiles.c (have_partial_symbols, have_full_symbols)
9237         (have_minimal_symbols, qsort_cmp, update_section_map)
9238         (shared_objfile_contains_address_p)
9239         (default_iterate_over_objfiles_in_search_order): Update.
9240         * objc-lang.c (info_selectors_command, info_classes_command)
9241         (find_methods): Update.
9242         * minsyms.c (find_solib_trampoline_target): Update.
9243         * maint.c (maintenance_info_sections)
9244         (maintenance_translate_address, count_symtabs_and_blocks):
9245         Update.
9246         * main.c (captured_main_1): Update.
9247         * linux-thread-db.c (try_thread_db_load_from_pdir)
9248         (has_libpthread): Update.
9249         * linespec.c (iterate_over_all_matching_symtabs)
9250         (search_minsyms_for_name): Update.
9251         * jit.c (jit_find_objf_with_entry_addr): Update.
9252         * hppa-tdep.c (find_unwind_entry)
9253         (hppa_lookup_stub_minimal_symbol): Update.
9254         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9255         Update.
9256         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9257         (elf_gnu_ifunc_resolve_by_got): Update.
9258         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9259         * dwarf-index-write.c (save_gdb_index_command): Update.
9260         * cp-support.c (add_symbol_overload_list_qualified): Update.
9261         * breakpoint.c (create_overlay_event_breakpoint)
9262         (create_longjmp_master_breakpoint)
9263         (create_std_terminate_master_breakpoint)
9264         (create_exception_master_breakpoint): Update.
9265         * blockframe.c (find_pc_partial_function): Update.
9266         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9267         (ada_collect_symbol_completion_matches)
9268         (ada_add_global_exceptions): Update.
9269
9270 2019-01-17  Tom Tromey  <tom@tromey.com>
9271
9272         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9273         declare VEC.
9274         (solib_target_parse_libraries): Change return type.
9275         (library_list_start_segment, library_list_start_section)
9276         (library_list_end_library, library_list_start_library); Update.
9277         (solib_target_free_library_list): Remove.
9278         (solib_target_parse_libraries): Remove cleanup.  Change return
9279         type.
9280         (solib_target_current_sos): Update.
9281
9282 2019-01-17  Tom Tromey  <tromey@bapiya>
9283
9284         * valprint.c: Replace "the the" with "the".
9285         * symtab.c: Replace "the the" with "the".
9286         * solib.c: Replace "the the" with "the".
9287         * solib-dsbt.c: Replace "the the" with "the".
9288         * linespec.c: Replace "the the" with "the".
9289         * dwarf2loc.h: Replace "the the" with "the".
9290         * amd64-windows-tdep.c: Replace "the the" with "the".
9291         * aarch64-tdep.c: Replace "the the" with "the".
9292
9293 2019-01-16  Keith Seitz  <keiths@redhat.com>
9294
9295         PR gdb/23773
9296         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9297         <builder>: Rename to ..
9298         <m_builder>: ... this and make private.
9299         (dwarf2_cu::get_builder): New method.  Change all users of
9300         `builder' to use this method.
9301         (dwarf2_start_symtab): Move to ...
9302         (dwarf2_cu::start_symtab): ... here.  Update all callers
9303         (setup_type_unit_groups): Move to ...
9304         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9305         callers.
9306         (dwarf2_cu::reset_builder): New method.
9307         (process_full_compunit, process_full_type_unit): Use
9308         dwarf2_cu::reset_builder.
9309         (follow_die_offset): Record the ancestor CU if it is different
9310         from the followed DIE's CU.
9311         (follow_die_sig_1): Likewise.
9312
9313 2019-01-15  Tom Tromey  <tom@tromey.com>
9314
9315         * remote.c (class remote_state) <buf>: Now a char_vector.
9316         <buf_size>: Remove.
9317         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9318         parameter.
9319         (remote_target::getpkt_or_notif_sane_1)
9320         (remote_target::getpkt_sane)
9321         (remote_target::getpkt_or_notif_sane): Likewise.
9322         (class remote_target) <putpkt>: New overload.
9323         (remote_target::read_frame): Change type of "buf_p".  Remove
9324         sizeof_p parameter.
9325         (packet_ok): New overload.
9326         (packet_check_result): New overload.
9327         Update all uses.
9328
9329 2019-01-14  Tom Tromey  <tom@tromey.com>
9330
9331         * remote-notif.c (handle_notification, remote_notif_ack)
9332         (remote_notif_parse): Make "buf" const.
9333         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9334         const.
9335         (remote_notif_parse, remote_notif_ack, handle_notification):
9336         Likewise.
9337         * remote.c (remote_notif_stop_parse): Make "buf" const.
9338         (remote_target::remote_parse_stop_reply): Make "buf" const.
9339         (remote_notif_stop_ack): Make "buf" const.
9340
9341 2019-01-14  Tom Tromey  <tom@tromey.com>
9342
9343         * remote.c (remote_console_output): Make parameter const.
9344
9345 2019-01-14  Tom Tromey  <tom@tromey.com>
9346
9347         * target-debug.h (target_debug_print_signals): Constify.
9348         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9349         * procfs.c (procfs_target::pass_signals): Update.
9350         * linux-nat.c (linux_nat_target::pass_signals): Update.
9351         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9352         * target-delegates.c: Rebuild.
9353         * remote.c (remote_target::program_signals): Update.
9354         (remote_target::pass_signals): Update.
9355         * target.c (target_pass_signals): Constify argument.
9356         (target_program_signals): Likewise.
9357         * target.h (struct target_ops) <pass_signals, program_signals>:
9358         Constify argument.
9359         (target_pass_signals, target_program_signals): Constify argument.
9360
9361 2019-01-14  Tom Tromey  <tom@tromey.com>
9362
9363         PR tui/28819:
9364         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9365
9366 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9367
9368         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9369         field.
9370         * rs6000-tdep.c: Include reggroups.h.
9371         (IS_V_ALIAS_PSEUDOREG): Define.
9372         (rs6000_register_name): Return names for the "vX" aliases.
9373         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9374         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9375         aliases.  Call default_register_reggroup_p for all other
9376         pseudo-registers.
9377         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9378         New functions.
9379         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9380         Handle "vX" aliases.
9381         (v_alias_pseudo_register_collect): New function.
9382         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9383         (rs6000_gdbarch_init): Initialize "vX" aliases as
9384         pseudo-registers.  Restore registration of
9385         rs6000_pseudo_register_reggroup_p with
9386         set_tdesc_pseudo_register_reggroup_p.
9387
9388 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9389
9390         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9391         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9392         set_gdbarch_num_pseudo_regs.
9393
9394 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9395
9396         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9397         Remove arg prefixname, add do_set and do_show.
9398         Add member functions set_list and show_list.
9399         * cli/cli-style.c (class cli_style_option): Update accordingly.
9400         (style_set_list): Move to file scope.
9401         (style_show_list): Likewise.
9402         (set_style): Call help_list.
9403         (show_style): Call cmd_show_list.
9404         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9405         Update to use the new macro.
9406
9407 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9408
9409         * ada-lang.c (_initialize_ada_language): Expand the help text
9410         for the "catch exception" command.
9411
9412 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9413
9414         * symtab.c (matching_obj_sections): Initialize obj,
9415         declare it closer to its usage.
9416
9417 2019-01-10  Tom Tromey  <tom@tromey.com>
9418
9419         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9420         (basic_inf_threads_range): Remove.
9421         (inf_threads_range, inf_non_exited_threads_range)
9422         (safe_inf_threads_range): Use next_adapter.
9423
9424 2019-01-10  Keith Seitz  <keiths@redhat.com>
9425
9426         PR gdb/23712
9427         PR symtab/23010
9428         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9429         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9430
9431 2019-01-10  Keith Seitz  <keiths@redhat.com>
9432
9433         PR gdb/23712
9434         PR symtab/23010
9435         * dictionary.c (pending_to_vector): Remove.
9436         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9437         Remove _1 suffix, replacing functions of the same name.  Update
9438         all callers.
9439         (dict_create_hashed, dict_create_hashed_expandable)
9440         (dict_create_linear, dict_create_linear_expandable, dict_free)
9441         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9442         Make functions static.
9443
9444 2019-01-10  Keith Seitz  <keiths@redhat.com>
9445
9446         PR gdb/23712
9447         PR symtab/23010
9448         * dictionary.h (struct dictionary): Replace declaration with
9449         multidictionary.
9450         (dict_create_hashed, dict_create_hashed_expandable)
9451         (dict_create_linear, dict_create_linear_expandable)
9452         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9453         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9454         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9455         taking multidictionary argument.
9456         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9457         * block.h (struct block) <dict>: Change to multidictionary
9458         and rename `multidict'.
9459         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9460         symmisc.c: Update all dictionary references to multidictionary.
9461
9462 2019-01-10  Keith Seitz  <keiths@redhat.com>
9463
9464         PR gdb/23712
9465         PR symtab/23010
9466         * dictionary.c: Include unordered_map.
9467         (pending_to_vector): New function.
9468         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9469         Rewrite the non-"_1" functions to take vector instead
9470         of linked list.
9471         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9472         "new" _1 versions of the same name.
9473         (multidictionary): Define.
9474         (std::hash<enum language): New definition.
9475         (collate_pending_symbols_by_language, mdict_create_hashed)
9476         (mdict_create_hashed_expandable, mdict_create_linear)
9477         (mdict_create_linear_expandable, mdict_free)
9478         (find_language_dictionary, create_new_language_dictionary)
9479         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9480         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9481         (mdict_size, mdict_empty): New functions.
9482         * dictionary.h (mdict_iterator): Define.
9483
9484 2019-01-10  Pedro Alves  <palves@redhat.com>
9485
9486         * breakpoint.c (read_uploaded_action)
9487         (create_tracepoint_from_upload): Adjust to use
9488         gdb::unique_xmalloc_ptr.
9489         * ctf.c (ctf_write_uploaded_tp):
9490         (SET_ARRAY_FIELD): Use emplace_back.
9491         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9492         * tracefile-tfile.c (tfile_write_uploaded_tp):
9493         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9494         gdb::unique_xmalloc_ptr.
9495         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9496         at_string, cond_string, cmd_strings>: Replace char pointers
9497         with gdb::unique_xmalloc_ptr.
9498
9499 2019-01-10  Pedro Alves  <palves@redhat.com>
9500
9501         * solib-target.c (library_list_start_library): Don't xstrdup name.
9502
9503 2019-01-10  Pedro Alves  <palves@redhat.com>
9504
9505         * mdebugread.c (parse_partial_symbols): Use
9506         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9507
9508 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9509
9510         * linux-fork.c (scoped_switch_fork_info)
9511         <~scoped_switch_fork_info>: Fix incorrect variable name.
9512
9513 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9514
9515         * linux-fork.c (scoped_switch_fork_info)
9516         <scoped_switch_fork_info>: Make explicit.
9517         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9518
9519 2019-01-10  Tom Tromey  <tom@tromey.com>
9520
9521         * objfiles.h (objfile::reset_psymtabs): Update.
9522         * objfiles.c (objfile::objfile): Update.
9523         * psymtab.h (psymtab_storage::obstack): Update.
9524         (psymtab_storage::m_obstack): Use gdb::optional.
9525         (class psymtab_storage): Update comment.  Remove objfile
9526         parameter.
9527         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9528
9529 2019-01-10  Tom Tromey  <tom@tromey.com>
9530
9531         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9532         <free_psymtabs>: Now private.
9533         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9534         (allocate_psymtab): Use new method.
9535
9536 2019-01-10  Tom Tromey  <tom@tromey.com>
9537
9538         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9539         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9540         * mdebugread.c (parse_partial_symbols): Use
9541         allocate_dependencies.
9542         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9543         allocate_dependencies.
9544         (process_psymtab_comp_unit_reader)
9545         (build_type_psymtab_dependencies): Likewise.
9546         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9547
9548 2019-01-10  Tom Tromey  <tom@tromey.com>
9549
9550         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9551         PSYMBOL_SET_LANGUAGE.
9552         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9553
9554 2019-01-10  Tom Tromey  <tom@tromey.com>
9555
9556         * psymtab.h (psymtab_storage::obstack): New method.
9557         <m_obstack>: Rename from obstack; now private.
9558         * psymtab.c (psymtab_storage): Update.
9559         * dwarf2read.c (create_addrmap_from_index)
9560         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9561         Update.
9562
9563 2019-01-10  Tom Tromey  <tom@tromey.com>
9564
9565         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9566         * objfiles.h (objfile::reset_psymtabs): New method.
9567
9568 2019-01-10  Tom Tromey  <tom@tromey.com>
9569
9570         * symmisc.c (print_symbol_bcache_statistics): Update.
9571         (print_objfile_statistics): Update.
9572         * symfile.c (reread_symbols): Update.
9573         * psymtab.h (class psymtab_storage): New.
9574         * psymtab.c (psymtab_storage): New constructor.
9575         (~psymtab_storage): New destructor.
9576         (require_partial_symbols): Update.
9577         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9578         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9579         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9580         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9581         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9582         (start_psymtab_common, end_psymtab_common)
9583         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9584         (allocate_psymtab): Update.
9585         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9586         Update.
9587         (dump_psymtab_addrmap, maintenance_print_psymbols)
9588         (maintenance_check_psymtabs): Update.
9589         (class objfile_psymtabs): Move to objfiles.h.
9590         * psympriv.h (discard_psymtab): Now inline.
9591         (psymtab_discarder::psymtab_discarder): Update.
9592         (psymtab_discarder::~psymtab_discarder): Update.
9593         (ALL_OBJFILE_PSYMTABS): Rewrite.
9594         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9595         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9596         Remove fields.
9597         <partial_symtabs>: New field.
9598         (class objfile_psymtabs): Move from psymtab.h.  Update.
9599         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9600         psymbol_cache.
9601         (objfile::~objfile): Don't destroy psymbol_cache.
9602         * mdebugread.c (parse_partial_symbols): Update.
9603         * dwarf2read.c (create_addrmap_from_index)
9604         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9605         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9606         (add_partial_subprogram, dwarf2_ranges_read): Update.
9607         * dwarf-index-write.c (write_address_map)
9608         (write_one_signatured_type, recursively_write_psymbols)
9609         (class debug_names, class debug_names, write_psymtabs_to_index):
9610         Update.
9611
9612 2019-01-10  Tom Tromey  <tom@tromey.com>
9613
9614         * symtab.h (SYMBOL_SET_NAMES): Update.
9615         (symbol_set_names): Update.
9616         (MSYMBOL_SET_NAMES): Update.
9617         * symtab.c (symbol_set_names): Change argument to be an
9618         objfile_per_bfd_storage.
9619         * psymtab.c (add_psymbol_to_bcache): Update.
9620         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9621
9622 2019-01-10  Tom Tromey  <tom@tromey.com>
9623
9624         * symtab.c (create_demangled_names_hash): Change argument to be an
9625         objfile_per_bfd_storage.
9626         (symbol_set_names): Update.
9627
9628 2019-01-10  Tom Tromey  <tom@tromey.com>
9629
9630         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9631         init_psymbol_list.
9632         * psymtab.c (init_psymbol_list): Do nothing if already called.
9633         * psympriv.h (init_psymbol_list): Add comment.
9634         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9635         init_psymbol_list.
9636         * dbxread.c (dbx_symfile_read): Unconditionally call
9637         init_psymbol_list.
9638
9639 2019-01-10  Tom Tromey  <tom@tromey.com>
9640
9641         * xcoffread.c (scan_xcoff_symtab): Update.
9642         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9643         "where".
9644         * mdebugread.c (parse_partial_symbols)
9645         (handle_psymbol_enumerators): Update.
9646         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9647         * dbxread.c (read_dbx_symtab): Update.
9648         * psympriv.h (psymbol_placement): New enum.
9649         (add_psymbol_to_list): Update.
9650
9651 2019-01-10  Tom Tromey  <tom@tromey.com>
9652
9653         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9654         static_psymbols parameters.
9655         (scan_xcoff_symtab): Update.
9656         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9657         static_psymbols parameters.
9658         * psympriv.h (start_psymtab_common): Update.
9659         * mdebugread.c (parse_partial_symbols): Update.
9660         * dwarf2read.c (create_partial_symtab): Update.
9661         * dbxread.c (read_dbx_symtab): Update.
9662         (start_psymtab): Remove global_psymbols and static_psymbols
9663         parameters.
9664
9665 2019-01-10  Tom Tromey  <tom@tromey.com>
9666
9667         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9668         * psymtab.c (allocate_psymtab): Add comment.
9669         * psympriv.h (allocate_psymtab): Add comment.
9670         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9671         initializations.
9672         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9673
9674 2019-01-10  Tom Tromey  <tom@tromey.com>
9675
9676         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9677         Don't declare.
9678         * mipsread.c: Include mdebugread.h.
9679         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9680         Declare.
9681         * elfread.c: Include mdebugread.h.
9682
9683 2019-01-09  Tom Tromey  <tom@tromey.com>
9684
9685         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9686         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9687         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9688         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9689         (psym_lookup_symbol, psym_find_last_source_symtab)
9690         (psym_forget_cached_source_info, psym_print_stats)
9691         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9692         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9693         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9694         (psym_find_compunit_symtab_by_address)
9695         (maintenance_print_psymbols, maintenance_info_psymtabs)
9696         (maintenance_check_psymtabs): Use ranged for.
9697         * psymtab.h (class objfile_psymtabs): New.
9698         (require_partial_symbols): Return objfile_psymtabs.
9699         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9700
9701 2019-01-09  Tom Tromey  <tom@tromey.com>
9702
9703         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9704         (find_pc_mapped_section, list_overlays_command)
9705         (map_overlay_command, unmap_overlay_command)
9706         (simple_overlay_update): Use all_objfiles.
9707         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9708         * printcmd.c (info_symbol_command): Use all_objfiles.
9709         * objfiles.h (ALL_OBJSECTIONS): Remove.
9710         * maint.c (maintenance_translate_address): Use all_objfiles.
9711         * gcore.c (gcore_create_callback): Use all_objfiles.
9712         (objfile_find_memory_regions): Likewise.
9713
9714 2019-01-09  Tom Tromey  <tom@tromey.com>
9715
9716         * symtab.c (find_line_symtab, info_sources_command)
9717         (make_source_files_completion_list): Use objfile_compunits.
9718         * source.c (select_source_symtab): Use objfile_compunits.
9719         * objfiles.h (struct objfile): Update comment.
9720         (ALL_OBJFILES): Remove.
9721         (ALL_FILETABS): Remove.
9722         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9723         objfile_compunits.
9724
9725 2019-01-09  Tom Tromey  <tom@tromey.com>
9726
9727         * symmisc.c (print_objfile_statistics, dump_objfile)
9728         (maintenance_print_symbols): Use compunit_filetabs.
9729         * source.c (forget_cached_source_info_for_objfile): Use
9730         compunit_filetabs.
9731         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9732         (ALL_FILETABS): Use compunit_filetabs.
9733         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9734         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9735
9736 2019-01-09  Tom Tromey  <tom@tromey.com>
9737
9738         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9739         (compunit_filetabs): New.
9740         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9741         compunit_filetabs.
9742         (info_sources_command, make_source_files_completion_list): Remove
9743         declaration.
9744         * symmisc.c (print_objfile_statistics, dump_objfile)
9745         (maintenance_print_symbols): Remove declaration.
9746         (maintenance_info_symtabs): Use compunit_filetabs.
9747         (maintenance_info_line_tables): Likewise.
9748         * source.c (select_source_symtab): Change local variable name.
9749         (forget_cached_source_info_for_objfile): Remove declaration.
9750         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9751         * objfiles.c (objfile_relocate1): Remove declaration.
9752         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9753         declaration.
9754         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9755         * coffread.c (coff_symtab_read): Remove declaration.
9756         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9757         compunit_filetabs.
9758
9759 2019-01-09  Tom Tromey  <tom@tromey.com>
9760
9761         * symtab.c (lookup_objfile_from_block)
9762         (find_pc_sect_compunit_symtab, search_symbols)
9763         (default_collect_symbol_completion_matches_break_on): Use
9764         objfile_compunits.
9765         * objfiles.h (ALL_COMPUNITS): Remove.
9766         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9767         * cp-support.c (add_symbol_overload_list_qualified): Use
9768         objfile_compunits.
9769         * ada-lang.c (ada_collect_symbol_completion_matches)
9770         (ada_add_global_exceptions): Use objfile_compunits.
9771
9772 2019-01-09  Tom Tromey  <tom@tromey.com>
9773
9774         * source.c (select_source_symtab)
9775         (forget_cached_source_info_for_objfile): Remove declaration.
9776         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9777         declaration.
9778         * maint.c (count_symtabs_and_blocks): Remove declaration.
9779         * cp-support.c (add_symbol_overload_list_qualified): Remove
9780         declaration.
9781         * coffread.c (coff_symtab_read): Remove declaration.
9782         * symtab.c (lookup_symbol_in_objfile_symtabs)
9783         (basic_lookup_transparent_type_1): Use objfile_compunits.
9784         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9785         (info_sources_command, search_symbols)
9786         (default_collect_symbol_completion_matches_break_on)
9787         (make_source_files_completion_list): Remove declaration.
9788         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9789         (ada_collect_symbol_completion_matches)
9790         (ada_add_global_exceptions): Remove declaration.
9791         * linespec.c (iterate_over_all_matching_symtabs): Use
9792         objfile_compunits.
9793         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9794         (class objfile_compunits): New.
9795         (ALL_COMPUNITS): Use objfile_compunits.
9796         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9797         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9798         objfile_compunits.
9799         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9800
9801 2019-01-09  Tom Tromey  <tom@tromey.com>
9802
9803         * symtab.c (search_symbols)
9804         (default_collect_symbol_completion_matches_break_on): Use
9805         objfile_msymbols.
9806         * ada-lang.c (ada_lookup_simple_minsym)
9807         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9808         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9809         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9810         objfile_msymbols.
9811         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9812         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9813         * objc-lang.c (find_methods): Use objfile_msymbols.
9814         (info_selectors_command, info_classes_command): Likewise.
9815         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9816         * objfiles.h (class objfile_msymbols): New.
9817         (ALL_OBJFILE_MSYMBOLS): Remove.
9818         (ALL_MSYMBOLS): Remove.
9819
9820 2019-01-09  Tom Tromey  <tom@tromey.com>
9821
9822         * common/next-iterator.h (next_adapter): Add Iterator template
9823         parameter.
9824         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9825         (class all_objfiles_safe): New.
9826         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9827         * objfiles.c (put_objfile_before): Update comment.
9828         (add_separate_debug_objfile): Likewise.
9829         (free_all_objfiles): Use all_objfiles_safe.
9830         (objfile_purge_solibs): Likewise.
9831
9832 2019-01-09  Tom Tromey  <tom@tromey.com>
9833
9834         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9835         (expand_symtab_containing_pc, lookup_static_symbol)
9836         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9837         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9838         all_objfiles.
9839         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9840         * breakpoint.c (create_overlay_event_breakpoint)
9841         (create_longjmp_master_breakpoint)
9842         (create_std_terminate_master_breakpoint)
9843         (create_exception_master_breakpoint): Use all_objfiles.
9844         * linux-thread-db.c (try_thread_db_load_from_pdir)
9845         (has_libpthread): Use all_objfiles.
9846         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9847         * linespec.c (iterate_over_all_matching_symtabs)
9848         (search_minsyms_for_name): Use all_objfiles.
9849         * maint.c (maintenance_info_sections): Use all_objfiles.
9850         * main.c (captured_main_1): Use all_objfiles.
9851         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9852         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9853         * guile/scm-pretty-print.c
9854         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9855         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9856         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9857         (maintenance_print_msymbols): Use all_objfiles.
9858         * source.c (select_source_symtab): Use all_objfiles.
9859         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9860         * symfile.c (remove_symbol_file_command)
9861         (expand_symtabs_matching, map_symbol_filenames): Use
9862         all_objfiles.
9863         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9864         all_objfiles.
9865         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9866         * objc-lang.c (find_methods): Use all_objfiles.
9867         * objfiles.c (have_partial_symbols, have_full_symbols)
9868         (have_minimal_symbols, qsort_cmp)
9869         (default_iterate_over_objfiles_in_search_order): Use
9870         all_objfiles.
9871         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9872         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9873         (maintenance_check_psymtabs): Use all_objfiles.
9874         (ALL_PSYMTABS): Remove.
9875         * compile/compile-object-run.c (do_module_cleanup): Use
9876         all_objfiles.
9877         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9878         * cp-support.c (add_symbol_overload_list_qualified): Use
9879         all_objfiles.
9880         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9881         Use all_objfiles.
9882         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9883         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9884         all_objfiles.
9885         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9886         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9887         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9888         Uses all_objfiles.
9889         * solib.c (solib_read_symbols): Use all_objfiles
9890
9891 2019-01-09  Tom Tromey  <tom@tromey.com>
9892
9893         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9894         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9895         all_objfiles.
9896         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9897         * symmisc.c (print_symbol_bcache_statistics)
9898         (print_objfile_statistics, maintenance_print_objfiles)
9899         (maintenance_info_symtabs, maintenance_check_symtabs)
9900         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9901         all_objfiles.
9902         * source.c (forget_cached_source_info): Use all_objfiles.
9903         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9904         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9905         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9906         * objfiles.c (update_section_map): Use all_objfiles.
9907         (shared_objfile_contains_address_p): Likewise.
9908         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9909         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9910
9911 2019-01-09  Tom Tromey  <tom@tromey.com>
9912
9913         * common/next-iterator.h: New file.
9914         * objfiles.h (class all_objfiles): New.
9915         (struct objfile_iterator): New.
9916
9917 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9918
9919         * NEWS: Move the description of the changed "frame", "select-frame",
9920          and "info frame" commands to the Changed commands section.
9921
9922 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9923
9924         * gdbtypes.c (check_stub_method_group): Remove handling of old
9925         mangling schemes.
9926         * linespec.c (find_methods): Likewise.
9927         * stabsread.c (read_member_functions): Likewise.
9928         * valops.c (search_struct_method): Likewise.
9929         (value_struct_elt_for_reference): Likewise.
9930         * NEWS: Mention this change.
9931
9932 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9933
9934         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9935         print_source_lines.
9936         * source.c (print_source_lines_base): Update line number check.
9937         (print_source_lines): New function.
9938         (source_lines_range::source_lines_range): New function.
9939         * source.h (class source_lines_range): New class.
9940         (print_source_lines): New declaration.
9941
9942 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9943
9944         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9945
9946 2019-01-08  Tom Tromey  <tom@tromey.com>
9947             Simon Marchi  <simon.marchi@ericsson.com>
9948
9949         PR gdb/24060
9950         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9951         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9952         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9953         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9954         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9955         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9956
9957 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9958
9959         * source.c (select_source_symtab): Move header comment to
9960         declaration in source.h.
9961         (forget_cached_source_info_for_objfile): Likewise.
9962         (forget_cached_source_info): Likewise.
9963         (identify_source_line): Likewise.
9964         * source.h (identify_source_line): Move declaration from symtab.h
9965         and add comment from source.c
9966         (print_source_lines): Likewise.
9967         (forget_cached_source_info_for_objfile): Likewise.
9968         (forget_cached_source_info): Likewise.
9969         (select_source_symtab): Likewise.
9970         (enum print_source_lines_flag): Move definition from symtab.h.
9971         * symtab.h (identify_source_line): Move declaration to source.h.
9972         (print_source_lines): Likewise.
9973         (forget_cached_source_info_for_objfile): Likewise.
9974         (forget_cached_source_info): Likewise.
9975         (select_source_symtab): Likewise.
9976         (enum print_source_lines_flag): Move definition to source.h.
9977         * tui/tui-hooks.c: Add 'source.h' include.
9978
9979 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9980
9981         * source.c (print_source_lines_base): Handle requests to print
9982         reverse line number sequences, and guard against empty lines
9983         string.
9984
9985 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9986
9987         * source.c (print_source_lines_base): Fix skip of '\r' if next
9988         character is '\n'.
9989
9990 2019-01-06  Tom Tromey  <tom@tromey.com>
9991
9992         * c-exp.y (struct c_parse_state) <macro_original_text,
9993         expansion_obstack>: New member.
9994         (macro_original_text, expansion_obstack): Remove globals.
9995         (scan_macro_expansion, scanning_macro_expansion)
9996         (finished_macro_expansion): Update.
9997         (scan_macro_cleanup): Remove.
9998         (yylex, c_parse): Update.
9999
10000 2019-01-06  Tom Tromey  <tom@tromey.com>
10001
10002         * c-exp.y (struct c_parse_state) <strings>: New member.
10003         (operator_stoken): Update.
10004
10005 2019-01-06  Tom Tromey  <tom@tromey.com>
10006
10007         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10008         (union type_stack_elt) <typelist_val>: Now a pointer to
10009         std::vector.
10010         (type_stack_cleanup): Don't declare.
10011         (push_typelist): Update.
10012         * parse.c (pop_typelist): Return a std::vector.
10013         (push_typelist): Take a std::vector.
10014         (follow_types): Update.  Do not free args.
10015         (type_stack_cleanup): Remove.
10016         * c-exp.y (struct c_parse_state): New.
10017         (cpstate): New global.
10018         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10019         (nonempty_typelist): Update.
10020         (func_mod): Create a new vector.
10021         (c_parse): Create a c_parse_state.
10022         (check_parameter_typelist): Do not delete params.
10023         (function_method): Update.  Do not delete type_list.
10024
10025 2019-01-06  Tom Tromey  <tom@tromey.com>
10026
10027         PR gdb/28155:
10028         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10029         check_typedef.
10030         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10031         (print_return_value): Likewise.
10032
10033 2019-01-05  Tom Tromey  <tom@tromey.com>
10034
10035         * contrib/cleanup_check.py: Remove.
10036         * contrib/gcc-with-excheck: Remove.
10037         * contrib/exsummary.py: Remove.
10038         * contrib/excheck.py: Remove.
10039
10040 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10041
10042         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10043         NULL. Initialize tpprev to NULL instead of assigning it
10044         to NULL on the next statement.
10045         * windows-nat.c (windows_delete_thread): Remove check for
10046         main_thread_id before printing thread exit notifications.
10047         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10048         Remove thread ID check against main_thread_id.
10049         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10050         windows_delete_thread.
10051         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10052
10053 2019-01-04  Tom Tromey  <tom@tromey.com>
10054
10055         * compile/compile.c (_initialize_compile): Use upper case for
10056         metasyntactic variables.
10057         * symmisc.c (_initialize_symmisc): Use upper case for
10058         metasyntactic variables.
10059         * psymtab.c (_initialize_psymtab): Use upper case for
10060         metasyntactic variables.
10061         * demangle.c (demangle_command): Use upper case for metasyntactic
10062         variables.
10063         (_initialize_demangler): Likewise.
10064         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10065         variables.
10066
10067 2019-01-03  Tom Tromey  <tom@tromey.com>
10068
10069         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10070
10071 2019-01-03  Tom Tromey  <tom@tromey.com>
10072
10073         * python/py-symtab.c (salpy_str): Update.
10074         (struct salpy_sal_object) <symtab>: Now a PyObject.
10075         (salpy_dealloc): Update.
10076         (del_objfile_sal): Use gdbpy_ref.
10077
10078 2019-01-03  Tom Tromey  <tom@tromey.com>
10079
10080         * python/py-type.c (convert_field): Use new_reference.  Return
10081         gdbpy_ref.
10082         (make_fielditem): Return gdbpy_ref.
10083         (typy_fields): Update.
10084         (typy_getitem): Update.
10085         (field_name): Return gdbpy_ref.  Use new_reference.
10086         (typy_iterator_iternext): Update.
10087
10088 2019-01-03  Tom Tromey  <tom@tromey.com>
10089
10090         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10091
10092 2019-01-03  Tom Tromey  <tom@tromey.com>
10093
10094         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10095         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10096         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10097         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10098         (pspy_set_type_printers): Likewise.
10099         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10100         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10101         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10102         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10103         (objfpy_set_type_printers): Likewise.
10104
10105 2019-01-03  Tom Tromey  <tom@tromey.com>
10106
10107         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10108         (gdbpy_print_stack): Use gdbpy_err_fetch.
10109         * python/python-internal.h (class gdbpy_err_fetch): New class.
10110         (class gdbpy_enter) <m_error_type, m_error_value,
10111         m_error_traceback>: Remove.
10112         <m_error>: New member.
10113         (gdbpy_exception_to_string): Don't declare.
10114         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10115         * python/py-value.c (convert_value_from_python): Use
10116         gdbpy_err_fetch.
10117         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10118         gdbpy_exception_to_string.
10119         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10120         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10121         gdbpy_err_fetch.
10122
10123 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10124
10125         * linux-nat.c (delete_lwp_cleanup): Delete.
10126         (struct lwp_deleter): New struct.
10127         (lwp_info_up): New typedef.
10128         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10129         lwp_info_up.
10130
10131 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10132
10133         * linux-fork.c (class scoped_switch_fork_info): New class.
10134         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10135
10136 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10137
10138         * valops.c (find_overload_match): Remove use of null_cleanup, and
10139         calls to do_cleanups.
10140
10141 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10142
10143         * compile/compile-cplus-types.c
10144         (compile_cplus_instance::decl_name): Handle changes to
10145         cp_func_name.
10146         * cp-support.c (cp_func_name): Update header comment, update
10147         return type.
10148         * cp-support.h (cp_func_name): Update return type in declaration.
10149         * valops.c (find_overload_match): Move temp_func local to top
10150         level of function and change its type.  Use temp_func to hold and
10151         delete temporary string obtained from cp_func_name.
10152
10153 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10154
10155         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10156         gdb::char_vector, remove cleanup, and update uses of `msg`.
10157
10158 2019-01-03  Jim Wilson  <jimw@sifive.com>
10159
10160         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10161
10162 2019-01-02  Tom Tromey  <tom@tromey.com>
10163
10164         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10165         (tdesc_parse_xml): Remove cleanups.
10166         * target-descriptions.h (make_cleanup_free_target_description):
10167         Don't declare.
10168         (target_desc_deleter): New struct.
10169         (target_desc_up): New typedef.
10170         * target-descriptions.c (target_desc_deleter::operator()): Rename
10171         from free_target_description.
10172         (make_cleanup_free_target_description): Remove.
10173
10174 2019-01-02  Tom Tromey  <tom@tromey.com>
10175
10176         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10177         constructor, destructor.
10178         (linespec_parser): Remove typedef.
10179         (~linespec_parser): Rename from linespec_parser_delete.
10180         (linespec_lex_to_end, linespec_complete_label)
10181         (linespec_complete): Update.
10182         (decode_line_full): Remove cleanups.
10183         (decode_line_1): Update.
10184
10185 2019-01-02  Tom Tromey  <tom@tromey.com>
10186
10187         * python/python-internal.h (inferior_to_inferior_object): Change
10188         return type.
10189         * python/py-exitedevent.c (create_exited_event_object): Update.
10190         * python/py-inferior.c (inferior_to_inferior_object): Return
10191         gdbpy_ref.
10192         (python_new_inferior, python_inferior_deleted)
10193         (thread_to_thread_object, delete_thread_object)
10194         (build_inferior_list, gdbpy_selected_inferior): Update.
10195         * python/py-infthread.c (create_thread_object): Update.  Also fail
10196         if inferior_to_inferior_object fails.
10197
10198 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10199
10200         * inferior.h (class inferior) <displaced_step_state>: New field.
10201         * infrun.h (struct displaced_step_state): Move here from
10202         infrun.c.  Initialize fields, add constructor.
10203         <inf>: Remove field.
10204         <reset>: New method.
10205         * infrun.c (struct displaced_step_inferior_state): Move to
10206         infrun.h.
10207         (displaced_step_inferior_states): Remove.
10208         (get_displaced_stepping_state): Adust.
10209         (displaced_step_in_progress_any_inferior): Adjust.
10210         (displaced_step_in_progress_thread): Adjust.
10211         (displaced_step_in_progress): Adjust.
10212         (add_displaced_stepping_state): Remove.
10213         (get_displaced_step_closure_by_addr): Adjust.
10214         (remove_displaced_stepping_state): Remove.
10215         (infrun_inferior_exit): Call displaced_step_state.reset.
10216         (use_displaced_stepping): Don't check for NULL.
10217         (displaced_step_prepare_throw): Call
10218         get_displaced_stepping_state.
10219         (displaced_step_fixup): Don't check for NULL.
10220         (prepare_for_detach): Don't check for NULL.
10221
10222 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10223
10224         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10225          in case of call that did not complete.
10226
10227 2019-01-02  Andrey Utkin  <autkin@undo.io>
10228
10229         * symfile.c (find_separate_debug_file): Fix search of debug files for
10230         remote debuggee.
10231
10232 2019-01-02  Tom Tromey  <tom@tromey.com>
10233
10234         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10235         indentation.
10236         * python/py-frame.c (frapy_older): Remove cast.
10237         (frapy_newer): Likewise.
10238         * python/py-breakpoint.c (local_setattro): Remove cast.
10239         * python/py-arch.c (archpy_name): Remove local variable.
10240         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10241
10242 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10243
10244         * unittests/basic_string_view/element_access/char/empty.cc:
10245         Fix year range in copyright header.
10246
10247 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10248
10249         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10250         Delete.
10251         <operator==>: Update with for removed field.
10252         <hash>: Likewise.
10253         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10254         <isa_features>: ...this.
10255         <abi_features>: New field.
10256         (riscv_isa_flen): Update comment.
10257         (riscv_abi_xlen): New declaration.
10258         (riscv_abi_flen): New declaration.
10259         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10260         isa_features.
10261         (riscv_abi_xlen): New function.
10262         (riscv_isa_flen): Update to get answer from isa_features.
10263         (riscv_abi_flen): New function.
10264         (riscv_has_fp_abi): Update to get answer from abi_features.
10265         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10266         xlen and flen.
10267         (riscv_call_info) <xlen, flen>: Update comment.
10268         (riscv_call_arg_struct): Remove invalid assertions
10269         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10270         is removed.
10271         (riscv_gdbarch_init): Gather isa features and abi features
10272         separately, ensure both match on the gdbarch when reusing an old
10273         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10274         a target with 64-bit float hardware.
10275
10276 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10277
10278         * source.c (search_command_helper): Stop reverse search
10279         when line 1 has been searched.
10280
10281 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10282
10283         * record-full.c (record_full_base_target::close): Rewrite
10284         record_full_core_buf_list free logic.
10285
10286 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10287
10288         * break-catch-syscall.c (print_one_catch_syscall): xfree
10289         the last text.
10290
10291 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10292
10293         * top.c (print_gdb_version): Update Copyright year in version
10294         message.
10295
10296 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10297
10298         Update copyright year range in all GDB files.
10299
10300 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10301
10302         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10303
10304 For older changes see ChangeLog-2018.
10305 \f
10306 Local Variables:
10307 mode: change-log
10308 left-margin: 8
10309 fill-column: 74
10310 version-control: never
10311 coding: utf-8
10312 End:
10313