gdb/ChangeLog

   1 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
   2
   3         * cli/cli-cmds.c (alias_command): Compare the alias prefix
   4         with the command prefix.
   5
   6 2019-06-25  Tom Tromey  <tom@tromey.com>
   7
   8         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
   9         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
  10
  11 2019-06-25  Tom Tromey  <tom@tromey.com>
  12
  13         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
  14         type.
  15         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
  16         protected.
  17
  18 2019-06-25  Tom Tromey  <tom@tromey.com>
  19
  20         * tui/tui-winsource.c
  21         (tui_source_window_base::set_is_exec_point_at): Add check against
  22         LOA_ADDRESS.
  23
  24 2019-06-25  Tom Tromey  <tom@tromey.com>
  25
  26         * tui/tui-source.c (tui_set_source_content): Don't check before
  27         xfree.
  28         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
  29
  30 2019-06-25  Tom Tromey  <tom@tromey.com>
  31
  32         * tui/tui-winsource.h (tui_update_source_window_as_is)
  33         (tui_alloc_source_buffer, tui_line_is_displayed)
  34         (tui_addr_is_displayed): Change type of win_info.
  35         * tui/tui-winsource.c (tui_update_source_window_as_is)
  36         (tui_clear_source_content, tui_show_source_line)
  37         (tui_show_source_content, tui_source_window_base::refill)
  38         (tui_source_window_base::set_is_exec_point_at)
  39         (tui_source_window_base::set_is_exec_point_at)
  40         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
  41         (tui_alloc_source_buffer, tui_line_is_displayed)
  42         (tui_addr_is_displayed): Change type of win_info.  Update.
  43         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
  44         (tui_source_window_base::do_make_visible_with_new_height):
  45         Update.
  46         * tui/tui-source.c (tui_set_source_content)
  47         (tui_set_source_content_nil)
  48         (tui_source_window::do_scroll_vertical): Update.
  49         * tui/tui-layout.c (show_layout): Update.
  50         * tui/tui-disasm.c (tui_set_disassem_content)
  51         (tui_disasm_window::do_scroll_vertical): Update.
  52         * tui/tui-data.h (tui_win_content): Remove.
  53         (struct tui_gen_win_info) <content, content_size>: Remove.
  54         (struct tui_source_element): Add initializers and destructor.
  55         (union tui_which_element, struct tui_win_element): Remove.
  56         (struct tui_source_window_base) <content>: New field.
  57         (struct tui_data_window): Remove destructor.
  58         (tui_alloc_content, tui_free_win_content)
  59         (tui_free_all_source_wins_content): Don't declare.
  60         * tui/tui-data.c (tui_initialize_static_data): Update.
  61         (init_content_element, tui_alloc_content): Remove.
  62         (~tui_gen_win_info): Update.
  63         (~tui_data_window, tui_free_all_source_wins_content)
  64         (tui_free_win_content, free_content, free_content_elements):
  65         Remove.
  66
  67 2019-06-25  Tom Tromey  <tom@tromey.com>
  68
  69         * tui/tui-winsource.h (tui_clear_source_content)
  70         (tui_erase_source_content, tui_show_source_content): Change type
  71         of win_info.
  72         * tui/tui-winsource.c (tui_clear_source_content)
  73         (tui_erase_source_content, tui_show_source_content): Change type
  74         of win_info.
  75         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
  76         * tui/tui-source.h (tui_set_source_content_nil): Change type of
  77         win_info.
  78         * tui/tui-source.c (tui_set_source_content_nil): Change type of
  79         win_info.
  80         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
  81
  82 2019-06-25  Tom Tromey  <tom@tromey.com>
  83
  84         * tui/tui-winsource.c (tui_clear_source_content)
  85         (tui_source_window_base::set_is_exec_point_at): Update.
  86         * tui/tui-source.c (tui_set_source_content_nil): Update.
  87         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
  88         a bool.
  89         * tui/tui-data.c (init_content_element): Update.
  90
  91 2019-06-25  Tom Tromey  <tom@tromey.com>
  92
  93         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
  94         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
  95         * tui/tui-layout.c (init_and_make_win): Update.
  96         * tui/tui.h (enum tui_win_type): Update.
  97         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
  98         tui_win_is_auxillary.
  99         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
 100         tui_win_is_auxillary.
 101
 102 2019-06-25  Tom Tromey  <tom@tromey.com>
 103
 104         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
 105         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
 106         (tui_delete_data_content_windows, tui_display_all_data)
 107         (tui_data_window::do_scroll_vertical, tui_display_data_from):
 108         Update.
 109         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
 110         * tui/tui-regs.c (tui_last_regs_line_no)
 111         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 112         (tui_show_registers): Update.
 113         (tui_show_register_group): Return void.  Update.
 114         (tui_display_registers_from, tui_display_reg_element_at_line)
 115         (tui_display_registers_from_line, tui_check_register_values):
 116         Update.
 117         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
 118         member.
 119         (struct tui_data_window) <regs_content>: Now a std::vector.
 120         <regs_content_count>: Remove.
 121         (tui_add_content_elements, tui_free_data_content): Don't declare.
 122         * tui/tui-data.c (tui_data_window::clear_detail): Update.
 123         (init_content_element): Remove DATA_WIN case.  Add assert.
 124         (tui_add_content_elements): Remove.
 125         (tui_data_window): Update.
 126         (tui_free_data_content): Remove.
 127         (free_content_elements): Remove DATA_WIN case.
 128
 129 2019-06-25  Tom Tromey  <tom@tromey.com>
 130
 131         * tui/tui-data.c (tui_data_item_window): Update.
 132         * tui/tui-windata.h (tui_check_data_values): Don't declare.
 133         * tui/tui-windata.c (tui_display_all_data)
 134         (tui_display_data_from_line): Update.
 135         (tui_check_data_values): Remove.
 136         * tui/tui-regs.c (tui_show_register_group)
 137         (tui_display_reg_element_at_line): Update.
 138         * tui/tui-hooks.c (tui_register_changed)
 139         (tui_refresh_frame_and_register_information): Call
 140         tui_check_register_values.
 141         * tui/tui-data.h (struct tui_data_window) <data_content,
 142         data_content_count, data_type>: Remove.
 143         (enum tui_data_type): Remove.
 144
 145         * tui/tui-data.c (tui_data_window::clear_detail)
 146         (~tui_data_window): Update.
 147
 148 2019-06-25  Tom Tromey  <tom@tromey.com>
 149
 150         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
 151         declare.
 152         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
 153         Rename from tui_first_data_item_displayed.  Update.
 154         (tui_data_window::refresh_all)
 155         (tui_data_window::do_scroll_vertical): Update.
 156         * tui/tui-data.h (struct tui_data_window)
 157         <first_data_item_displayed>: Declare new method.
 158
 159 2019-06-25  Tom Tromey  <tom@tromey.com>
 160
 161         * tui/tui-data.h (tui_init_generic_part): Don't declare.
 162         * tui/tui-data.c (tui_init_generic_part): Remove, moving
 163         contents...
 164         (tui_initialize_static_data): ...here.
 165
 166 2019-06-25  Tom Tromey  <tom@tromey.com>
 167
 168         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 169         (tui_display_registers_from, tui_check_register_values): Update.
 170         (tui_display_register): Remove win_info parameter; update.
 171         (tui_get_register): Change type of parameters.
 172         * tui/tui-data.h (struct tui_data_element): Remove.
 173         (union tui_which_element) <data>: Remove.
 174         <data_window>: Change type.
 175         (struct tui_data_item_window): New.
 176         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
 177         case.  Add assert.
 178         (~tui_data_item_window): New destructor.
 179         (free_content_elements): Remove DATA_ITEM_WIN case.
 180
 181 2019-06-25  Tom Tromey  <tom@tromey.com>
 182
 183         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
 184         Remove.
 185
 186 2019-06-25  Tom Tromey  <tom@tromey.com>
 187
 188         * tui/tui-data.h (struct tui_command_element): Remove.
 189         (union tui_which_element) <command>: Remove.
 190         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
 191         assert.
 192         (free_content_elements): Remove CMD_WIN case.
 193
 194 2019-06-25  Tom Tromey  <tom@tromey.com>
 195
 196         * tui/tui-layout.c (tui_set_layout): Update.
 197         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
 198         * tui/tui-data.c (layout_def): Update.
 199
 200 2019-06-25  Tom Tromey  <tom@tromey.com>
 201
 202         * tui/tui-wingeneral.c (tui_refresh_all): Update.
 203         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 204         (tui_source_window_base::set_new_height): Update.
 205         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
 206         Update.
 207         (tui_set_locator_fullname, tui_set_locator_info)
 208         (tui_show_frame_info): Update.
 209         * tui/tui-source.c (tui_set_source_content)
 210         (tui_source_is_displayed): Update.
 211         * tui/tui-layout.c (show_source_disasm_command, show_data)
 212         (show_source_or_disasm_and_command): Update.
 213         * tui/tui-disasm.c (tui_set_disassem_content)
 214         (tui_get_begin_asm_address): Update.
 215         * tui/tui-data.h (struct tui_locator_element): Remove.
 216         (union tui_which_element) <locator>: Remove.
 217         (struct tui_locator_window): New.
 218         (tui_locator_win_info_ptr): Change return type.
 219         * tui/tui-data.c (_locator): Change type.
 220         (tui_locator_win_info_ptr): Change return type.
 221         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
 222         (tui_alloc_content): Add assert.
 223
 224 2019-06-25  Tom Tromey  <tom@tromey.com>
 225
 226         * tui/tui-winsource.c
 227         (tui_exec_info_window::maybe_allocate_content): New method.
 228         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
 229         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
 230         (make_source_or_disasm_window): Add cast.
 231         * tui/tui-data.h (union tui_which_element) <simple_string>:
 232         Remove.
 233         (struct tui_source_info): New.
 234         (struct tui_source_window_base) <execution_info>: Change type.
 235         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
 236         case, and add assert.
 237         (tui_alloc_content): Add assert.
 238
 239 2019-06-25  Tom Tromey  <tom@tromey.com>
 240
 241         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
 242         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
 243         * tui/tui-data.c (tui_alloc_win_info): Remove.
 244
 245 2019-06-25  Tom Tromey  <tom@tromey.com>
 246
 247         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
 248         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
 249         can_highlight.
 250
 251 2019-06-25  Tom Tromey  <tom@tromey.com>
 252
 253         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
 254         make_visible_with_new_height method.
 255         (tui_win_info::make_visible_with_new_height): New method.
 256         (tui_source_window_base::do_make_visible_with_new_height)
 257         (tui_data_window::do_make_visible_with_new_height)
 258         (tui_cmd_window::do_make_visible_with_new_height): New methods.
 259         (make_visible_with_new_height): Remove.
 260         (tui_resize_all, tui_adjust_win_heights): Use
 261         make_visible_with_new_height method.
 262         * tui/tui-data.h (struct tui_win_info)
 263         <do_make_visible_with_new_height, make_visible_with_new_height>:
 264         New methods.
 265         (struct tui_source_window_base, struct tui_data_window)
 266         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
 267         methods.
 268
 269 2019-06-25  Tom Tromey  <tom@tromey.com>
 270
 271         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
 272         method.
 273         (update_tab_width): Call update_tab_width method.
 274         * tui/tui-data.h (struct tui_win_info)
 275         (struct tui_source_window_base) <update_tab_width>: New methods.
 276
 277 2019-06-25  Tom Tromey  <tom@tromey.com>
 278
 279         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
 280         parameter.
 281         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
 282         parameter.
 283         (tui_gen_win_info::make_visible): Update.
 284         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
 285         parameter.
 286         * tui/tui-data.h (enum tui_box): New enum.
 287         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
 288
 289 2019-06-25  Tom Tromey  <tom@tromey.com>
 290
 291         * tui/tui-layout.c (make_source_or_disasm_window): Always use
 292         init_and_make_win for EXEC_INFO_WIN.
 293         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
 294         longer inline.
 295         (struct tui_win_info) <~tui_win_info>: Inline.
 296         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 297         Don't declare.
 298         * tui/tui-data.c (source_win, disasm_win): Remove globals.
 299         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 300         Remove.
 301         (tui_initialize_static_data): Update.
 302         (~tui_gen_win_info): Handle more cleanup here.
 303         (~tui_source_window_base): Delete "execution_info".
 304         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
 305
 306 2019-06-25  Tom Tromey  <tom@tromey.com>
 307
 308         * tui/tui-layout.c (make_command_window): Don't set
 309         can_highlight.
 310         (show_source_disasm_command): Call the reset method.
 311         (show_data): Don't set can_highlight.  Call the reset method.
 312         (tui_gen_win_info::reset): Rename from init_gen_win_info
 313         (init_and_make_win): Simplify.  Return tui_gen_win_info.
 314         (show_source_or_disasm_and_command): Call the reset method.
 315         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
 316         (struct tui_cmd_window): Set can_highlight.
 317
 318 2019-06-25  Tom Tromey  <tom@tromey.com>
 319
 320         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
 321         from make_visible.
 322         (tui_make_visible, tui_make_invisible): Rewrite.
 323         (tui_win_info::make_visible): Remove.
 324         (tui_source_window_base::make_visible): Update.
 325         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
 326         method.  Moved from...
 327         (struct tui_win_info) <make_visible>: ...here.
 328
 329 2019-06-25  Tom Tromey  <tom@tromey.com>
 330
 331         * tui/tui-winsource.c
 332         (tui_source_window_base::do_scroll_horizontal): Remove direction
 333         parameter.
 334         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
 335         direction parameter.
 336         * tui/tui-win.c (tui_win_info::forward_scroll)
 337         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 338         (tui_win_info::right_scroll): Update.
 339         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
 340         direction parameter.
 341         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
 342         direction parameter.
 343         * tui/tui-data.h (enum tui_scroll_direction): Remove.
 344         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
 345         Remove direction parameter.
 346         (struct tui_source_window_base, struct tui_source_window)
 347         (struct tui_disasm_window, struct tui_data_window)
 348         (struct tui_cmd_window): Update.
 349
 350 2019-06-25  Tom Tromey  <tom@tromey.com>
 351
 352         * tui/tui-winsource.h (tui_set_exec_info_content)
 353         (tui_show_exec_info_content, tui_erase_exec_info_content)
 354         (tui_clear_exec_info_content, tui_update_exec_info): Change
 355         argument to tui_source_window_base.
 356         * tui/tui-winsource.c (tui_set_exec_info_content)
 357         (tui_show_exec_info_content, tui_erase_exec_info_content)
 358         (tui_clear_exec_info_content, tui_update_exec_info): Change
 359         argument to tui_source_window_base.
 360
 361 2019-06-25  Tom Tromey  <tom@tromey.com>
 362
 363         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
 364         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
 365
 366 2019-06-25  Tom Tromey  <tom@tromey.com>
 367
 368         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
 369         check.
 370
 371 2019-06-25  Tom Tromey  <tom@tromey.com>
 372
 373         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
 374         type to void.
 375         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
 376         type to void.
 377         * tui/tui-source.c (tui_set_source_content): Update.
 378         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 379
 380 2019-06-25  Tom Tromey  <tom@tromey.com>
 381
 382         * tui/tui-win.c (window_name_completer, tui_set_focus)
 383         (tui_all_windows_info): Use name method.
 384         * tui/tui-data.h (struct tui_gen_win_info)
 385         (struct tui_source_window, struct tui_disasm_window)
 386         (struct tui_data_window, struct tui_cmd_window) <name>: New
 387         method.
 388         (tui_win_name): Don't declare.
 389         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
 390         (tui_win_name): Remove.
 391
 392 2019-06-25  Tom Tromey  <tom@tromey.com>
 393
 394         * tui/tui-winsource.h (tui_update_source_window)
 395         (tui_update_source_window_as_is): Change parameter type.
 396         * tui/tui-winsource.c (tui_update_source_window): Change win_info
 397         to be a tui_source_window_base.
 398         (tui_update_source_window_as_is): Likewise.
 399         * tui/tui-win.c (make_visible_with_new_height): Update.
 400
 401 2019-06-25  Tom Tromey  <tom@tromey.com>
 402
 403         * tui/tui-winsource.c (tui_erase_source_content)
 404         (tui_show_source_content, tui_show_exec_info_content)
 405         (tui_erase_exec_info_content): Use refresh_window method.
 406         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
 407         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
 408         from tui_refresh_win.
 409         (tui_data_window::refresh_window): New method.
 410         (tui_win_info::refresh, tui_source_window_base::refresh)
 411         (tui_refresh_all): Use refresh_window method.
 412         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
 413         method.
 414         * tui/tui-regs.c (tui_display_register): Call refresh_window
 415         method.
 416         * tui/tui-layout.c (show_source_disasm_command)
 417         (show_source_or_disasm_and_command): Call refresh_window method.
 418         * tui/tui-data.h (struct tui_gen_win_info)
 419         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
 420         New method.
 421
 422 2019-06-25  Tom Tromey  <tom@tromey.com>
 423
 424         * tui/tui.c (tui_rl_other_window, tui_enable)
 425         (tui_is_window_visible, tui_get_command_dimension): Update.
 426         * tui/tui-winsource.c (tui_update_source_window_as_is)
 427         (tui_clear_source_content, tui_erase_source_content)
 428         (tui_show_source_line, tui_source_window_base::refill)
 429         (tui_source_window_base::do_scroll_horizontal)
 430         (tui_source_window_base::set_is_exec_point_at)
 431         (tui_update_breakpoint_info, tui_set_exec_info_content)
 432         (tui_alloc_source_buffer, tui_line_is_displayed)
 433         (tui_addr_is_displayed): Update.
 434         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 435         (tui_check_and_display_highlight_if_needed)
 436         (tui_win_info::make_visible, tui_win_info::refresh)
 437         (tui_refresh_all): Update.
 438         * tui/tui-windata.c (tui_first_data_item_displayed)
 439         (tui_delete_data_content_windows, tui_erase_data_content)
 440         (tui_display_all_data, tui_data_window::refresh_all)
 441         (tui_check_data_values): Update.
 442         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
 443         (tui_set_win_focus_to, tui_win_info::forward_scroll)
 444         (tui_win_info::backward_scroll, tui_refresh_all_win)
 445         (tui_resize_all, tui_set_focus, tui_all_windows_info)
 446         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
 447         (tui_source_window_base::set_new_height)
 448         (tui_data_window::set_new_height)
 449         (make_invisible_and_set_new_height)
 450         (make_visible_with_new_height, new_height_ok)
 451         (parse_scrolling_args): Update.
 452         * tui/tui-stack.c (tui_show_frame_info): Update.
 453         * tui/tui-source.c (tui_set_source_content)
 454         (tui_set_source_content_nil, tui_source_is_displayed)
 455         (tui_source_window::do_scroll_vertical): Update.
 456         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 457         (tui_display_registers_from, tui_display_reg_element_at_line)
 458         (tui_check_register_values, tui_reg_command): Update.
 459         * tui/tui-layout.c (tui_default_win_height)
 460         (show_source_disasm_command, show_data, init_and_make_win)
 461         (show_source_or_disasm_and_command): Update.
 462         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 463         (tui_redisplay_readline, tui_mld_flush)
 464         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
 465         (tui_getc): Update.
 466         * tui/tui-disasm.c (tui_set_disassem_content)
 467         (tui_disasm_window::do_scroll_vertical): Update.
 468         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
 469         Now virtual.
 470         (struct tui_win_info): Derive from tui_gen_win_info.
 471         <~tui_win_info>: Mark as override.
 472         <generic>: Remove member.
 473         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
 474         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
 475         (~tui_data_window, ~tui_win_info)
 476         (tui_free_all_source_wins_content): Update.
 477         * tui/tui-command.c (tui_refresh_cmd_win): Update.
 478
 479 2019-06-25  Tom Tromey  <tom@tromey.com>
 480
 481         * tui/tui-layout.c (init_and_make_win): Use new.
 482         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
 483         destructor, initializers.
 484         (tui_alloc_generic_win_info): Don't declare.
 485         * tui/tui-data.c (_locator): Add argument to constructor.
 486         (source_win, disasm_win): New globals.
 487         (exec_info): Remove.
 488         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 489         Update.
 490         (tui_alloc_generic_win_info): Remove.
 491         (init_content_element): Use new.
 492         (tui_win_info::tui_win_info): Update.
 493         (free_content_elements) <case DATA_WIN>: Use delete.
 494
 495 2019-06-25  Tom Tromey  <tom@tromey.com>
 496
 497         * tui/tui-wingeneral.c (tui_refresh_win): Update.
 498         * tui/tui-windata.c (tui_first_data_item_displayed)
 499         (tui_delete_data_content_windows): Update.
 500         * tui/tui-win.c (tui_data_window::set_new_height): Update.
 501         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 502         (tui_display_registers_from, tui_check_register_values): Update.
 503         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
 504         pointer.
 505         * tui/tui-data.c (init_content_element): Update.  Allocate the new
 506         window.
 507         (tui_free_data_content): Update.
 508         (free_content_elements) <case DATA_WIN>: Free the window.
 509
 510 2019-06-25  Tom Tromey  <tom@tromey.com>
 511
 512         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
 513         Update.
 514         * tui/tui-layout.c (make_command_window)
 515         (show_source_disasm_command, show_data, init_and_make_win)
 516         (show_source_or_disasm_and_command): Update.
 517         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
 518         method.
 519         <can_highight, is_highlighted>: Now bool.
 520         (tui_set_win_highlight): Don't declare.
 521         * tui/tui-data.c (tui_set_win_highlight): Remove.
 522
 523 2019-06-25  Tom Tromey  <tom@tromey.com>
 524
 525         * tui/tui-wingeneral.c (make_visible): Remove check of window
 526         type.
 527
 528 2019-06-25  Tom Tromey  <tom@tromey.com>
 529
 530         * tui/tui-win.c (tui_win_info::max_height)
 531         (tui_cmd_window::max_height): New methods.
 532         (new_height_ok): Call max_height.
 533         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
 534         <max_height>: New method.
 535
 536 2019-06-25  Tom Tromey  <tom@tromey.com>
 537
 538         * tui/tui-win.c (tui_source_window_base::set_new_height)
 539         (tui_data_window::set_new_height): New methods.
 540         (make_invisible_and_set_new_height): Call set_new_height method.
 541         * tui/tui-data.h (struct tui_win_info)
 542         (struct tui_source_window_base, struct tui_data_window)
 543         <set_new_height>: New method.
 544
 545 2019-06-25  Tom Tromey  <tom@tromey.com>
 546
 547         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
 548         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
 549         tui_refresh_data_win.
 550         * tui/tui-win.c (tui_source_window_base::refresh_all): New
 551         method.
 552         (tui_refresh_all_win): Call the refresh_all method.
 553         (tui_set_focus): Likewise.
 554         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
 555         (struct tui_source_window_base, struct tui_data_window) <refresh>:
 556         Likewise.
 557
 558 2019-06-25  Tom Tromey  <tom@tromey.com>
 559
 560         * tui/tui-winsource.h (tui_refill_source_window)
 561         (tui_set_is_exec_point_at): Don't declare.
 562         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 563         (tui_source_window_base::refill): Rename from
 564         tui_refill_source_window.
 565         (tui_source_window_base::do_scroll_horizontal): Update.
 566         (tui_source_window_base::set_is_exec_point_at): Rename from
 567         tui_set_is_exec_point_at.
 568         (tui_update_all_breakpoint_info): Update.
 569         * tui/tui-stack.c (tui_show_frame_info): Update.
 570         * tui/tui-layout.c (show_data): Add cast.
 571         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
 572         * tui/tui-data.h (struct tui_source_window_base) <refill,
 573         set_is_exec_point_at>: New methods.
 574         (tui_source_windows, tui_add_to_source_windows): Update types.
 575         (tui_add_to_source_windows): Remove redundant declaration.
 576         * tui/tui-data.c (source_windows): Store tui_source_window_base.
 577         (tui_source_windows): Change return type.
 578         (tui_clear_source_windows_detail): Update.
 579         (tui_add_to_source_windows): Change type of parameter.
 580         (tui_free_all_source_wins_content): Update.
 581
 582 2019-06-25  Tom Tromey  <tom@tromey.com>
 583
 584         * tui/tui-wingeneral.c (tui_win_info::refresh)
 585         (tui_source_window_base::refresh): New methods.
 586         (tui_refresh_all): Call the refresh method.
 587         * tui/tui-data.h (struct tui_win_info)
 588         (struct tui_source_window_base) <refresh>: New method.
 589
 590 2019-06-25  Tom Tromey  <tom@tromey.com>
 591
 592         * tui/tui.h (tui_is_window_visible): Return bool.
 593         * tui/tui.c (tui_is_window_visible): Return bool.
 594         * tui/tui-wingeneral.c (tui_make_window, make_visible)
 595         (tui_make_visible, tui_make_invisible)
 596         (tui_win_info::make_visible)
 597         (tui_source_window_base::make_visible, make_all_visible)
 598         (tui_make_all_visible, tui_make_all_invisible): Update.
 599         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
 600         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
 601         bool.
 602         (struct tui_win_info, struct tui_source_window_base)
 603         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
 604         * tui/tui-data.c (tui_init_generic_part): Update.
 605
 606 2019-06-25  Tom Tromey  <tom@tromey.com>
 607
 608         * tui/tui-wingeneral.c (tui_win_info::make_visible)
 609         (tui_source_window_base::make_visible): New methods.
 610         (make_all_visible): Make method call.
 611         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
 612         (struct tui_source_window_base, struct tui_cmd_window): Override
 613         make_visible.
 614         (tui_win_is_source_type): Don't declare.
 615         * tui/tui-data.c (tui_win_is_source_type): Remove.
 616
 617 2019-06-25  Tom Tromey  <tom@tromey.com>
 618
 619         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
 620         NULL check.
 621
 622 2019-06-25  Tom Tromey  <tom@tromey.com>
 623
 624         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
 625         Inline constructor.  Add initializers for members.
 626         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
 627         constructors; now inline in class.
 628
 629 2019-06-25  Tom Tromey  <tom@tromey.com>
 630
 631         * tui/tui-regs.c (tui_show_registers): Update.
 632         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
 633         bool.
 634         * tui/tui-data.c (tui_data_window::clear_detail)
 635         (tui_data_window): Update.
 636
 637 2019-06-25  Tom Tromey  <tom@tromey.com>
 638
 639         * tui/tui-windata.c (tui_display_all_data)
 640         (tui_display_data_from_line, tui_display_data_from)
 641         (tui_check_data_values, tui_data_window::do_scroll_vertical):
 642         Update.
 643         * tui/tui-regs.c (tui_last_regs_line_no)
 644         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 645         (tui_show_registers, tui_show_register_group)
 646         (tui_display_registers_from, tui_display_reg_element_at_line)
 647         (tui_display_registers_from_line, tui_check_register_values)
 648         (tui_reg_next, tui_reg_prev): Update.
 649         * tui/tui-layout.c (tui_set_layout, show_data): Update.
 650         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
 651         tui_data_window.
 652         (struct tui_win_info) <detail>: Remove.  Add new fields from
 653         tui_data_info.
 654         (TUI_DATA_WIN): Add cast.
 655         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
 656         (~tui_data_window): Simplify.
 657
 658 2019-06-25  Tom Tromey  <tom@tromey.com>
 659
 660         * tui/tui-layout.c (show_source_disasm_command)
 661         (show_source_or_disasm_and_command): Update.
 662         * tui/tui-io.c (update_cmdwin_start_line)
 663         (tui_redisplay_readline): Update.
 664         * tui/tui-data.h (struct tui_command_info): Remove.
 665         (struct tui_win_info) <detail>: Remove command_info member.
 666         (struct tui_data_window) <start_line>: New member, from
 667         tui_command_info.
 668         (TUI_CMD_WIN): Add casts.
 669
 670 2019-06-25  Tom Tromey  <tom@tromey.com>
 671
 672         * tui/tui-winsource.c (tui_update_source_window)
 673         (tui_refill_source_window)
 674         (tui_source_window_base::do_scroll_horizontal)
 675         (tui_update_breakpoint_info, tui_set_exec_info_content)
 676         (tui_show_exec_info_content, tui_erase_exec_info_content)
 677         (tui_clear_exec_info_content): Update.
 678         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
 679         Update.
 680         * tui/tui-win.c (make_invisible_and_set_new_height)
 681         (make_visible_with_new_height): Update.
 682         * tui/tui-source.c (tui_set_source_content)
 683         (tui_show_symtab_source): Update.
 684         * tui/tui-layout.c (extract_display_start_addr)
 685         (show_source_disasm_command, show_data)
 686         (make_source_or_disasm_window)
 687         (show_source_or_disasm_and_command): Update.
 688         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
 689         (tui_disasm_window::do_scroll_vertical): Remove shadowing
 690         "gdbarch".
 691         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
 692         to tui_source_window_base.
 693         (struct tui_win_info) <detail>: Remove source_info member.
 694         (struct tui_source_window_base) <has_locator>: Inline.
 695         Move contents from tui_source_info; rename has_locator member to
 696         m_has_locator.
 697         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
 698         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
 699         header file.
 700         (tui_source_window_base::clear_detail, ~tui_source_window_base):
 701         Simplify.
 702         (tui_free_all_source_wins_content): Cast to
 703         tui_source_window_base.
 704
 705 2019-06-25  Tom Tromey  <tom@tromey.com>
 706
 707         * tui/tui-win.c (make_invisible_and_set_new_height)
 708         (make_visible_with_new_height): Call has_locator method.
 709         * tui/tui-layout.c (show_source_disasm_command, show_data)
 710         (show_source_or_disasm_and_command): Update for bool change.
 711         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
 712         (tui_win_info) <has_locator>: New method.
 713         (struct tui_source_window_base) <has_locator>: New method.
 714         (tui_win_has_locator): Don't declare.
 715         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
 716         from tui_win_has_locator.
 717         (tui_source_window_base): Use false, not FALSE.
 718
 719 2019-06-25  Tom Tromey  <tom@tromey.com>
 720
 721         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
 722         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
 723         clear_detail method directly.
 724         (tui_clear_win_detail): Remove.
 725
 726 2019-06-25  Tom Tromey  <tom@tromey.com>
 727
 728         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 729         "this", not TUI_DISASM_WIN.
 730
 731 2019-06-25  Tom Tromey  <tom@tromey.com>
 732
 733         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
 734         declare.
 735         * tui/tui-winsource.c
 736         (tui_source_window_base::do_scroll_horizontal): Rename from
 737         tui_horizontal_source_scroll.
 738         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
 739         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
 740         from tui_vertical_data_scroll.
 741         * tui/tui-win.h (tui_scroll): Don't declare.
 742         * tui/tui-win.c (tui_win_info::forward_scroll)
 743         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 744         (tui_win_info::right_scroll): Rename and update.
 745         (tui_scroll_forward_command, tui_scroll_backward_command)
 746         (tui_scroll_left_command, tui_scroll_right_command): Update.
 747         (tui_scroll): Remove.
 748         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
 749         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
 750         from tui_vertical_source_scroll.
 751         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
 752         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
 753         from tui_vertical_disassem_scroll.
 754         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
 755         do_scroll_horizontal>: New methods.
 756         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
 757         Likewise.
 758         (struct tui_source_window_base): Add do_scroll_horizontal.
 759         (struct tui_source_window, struct tui_disasm_window): Add
 760         do_scroll_vertical.
 761         (struct tui_data_window, struct tui_cmd_window): Add
 762         do_scroll_horizontal and do_scroll_vertical.
 763         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
 764
 765 2019-06-25  Tom Tromey  <tom@tromey.com>
 766
 767         * tui/tui-data.h (struct tui_source_window_base): New struct.
 768         (struct tui_source_window): Derive from tui_source_window_base.
 769         (struct tui_disasm_window): New struct.
 770         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
 771         from tui_source_window::clear_detail.
 772         (tui_source_window_base): Rename from tui_source_window.
 773         (~tui_source_window_base): Rename from ~tui_source_window.
 774         (tui_alloc_win_info): Create a tui_disasm_window.
 775
 776 2019-06-25  Tom Tromey  <tom@tromey.com>
 777
 778         * tui/tui-data.h (struct tui_source_window)
 779         (struct tui_data_window): Declare destructors.
 780         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
 781         destructors.
 782         (tui_win_info): Simplify.
 783
 784 2019-06-25  Tom Tromey  <tom@tromey.com>
 785
 786         * tui/tui-winsource.c (tui_display_main)
 787         (tui_update_source_windows_with_addr)
 788         (tui_update_all_breakpoint_info): Update.
 789         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 790         (new_height_ok, parse_scrolling_args): Update.
 791         * tui/tui-stack.c (tui_show_frame_info): Update.
 792         * tui/tui-data.h (struct tui_list): Remove.
 793         (tui_source_windows): Return a reference to a std::vector.
 794         * tui/tui-data.c (source_windows): Now a std::vector.
 795         (tui_source_windows): Change return type.
 796         (tui_clear_source_windows): Rewrite.
 797         (tui_clear_source_windows_detail, tui_add_to_source_windows)
 798         (tui_free_all_source_wins_content): Rewrite.
 799
 800 2019-06-25  Tom Tromey  <tom@tromey.com>
 801
 802         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
 803         (struct tui_data_window, struct tui_cmd_window): Declare
 804         clear_detail method.
 805         * tui/tui-data.c (tui_source_window::clear_detail)
 806         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
 807         methods.
 808         (tui_clear_win_detail): Simplify.
 809
 810 2019-06-25  Tom Tromey  <tom@tromey.com>
 811
 812         * tui/tui-layout.c (make_source_window, make_disasm_window)
 813         (make_source_or_disasm_window): Remove win_info_ptr parameter.
 814         Return the new window.
 815         (show_source_disasm_command, show_data)
 816         (show_source_or_disasm_and_command): Update.
 817
 818 2019-06-25  Tom Tromey  <tom@tromey.com>
 819
 820         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
 821         parameter.  Return the new window.
 822         (show_source_disasm_command): Update and remove NULL check.
 823         (show_source_or_disasm_and_command): Update.
 824
 825 2019-06-25  Tom Tromey  <tom@tromey.com>
 826
 827         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
 828
 829 2019-06-25  Tom Tromey  <tom@tromey.com>
 830
 831         * tui/tui-data.h (struct tui_win_info): Make constructor
 832         protected.  Make destructor virtual.  Add initializers.
 833         (tui_source_window, tui_data_window, tui_cmd_window): New
 834         classes.
 835         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
 836         constructor.  Add "type" parameter.
 837         (tui_source_window, tui_data_window, tui_cmd_window): New
 838         constructors.
 839         (tui_alloc_win_info): Instantiate the appropriate subclass.
 840
 841 2019-06-25  Tom Tromey  <tom@tromey.com>
 842
 843         * tui/tui-win.c (tui_resize_all): Use delete.
 844         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
 845         destructor.
 846         (tui_free_window): Don't declare.
 847         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
 848         Update.
 849
 850 2019-06-25  Tom Tromey  <tom@tromey.com>
 851
 852         * tui/tui-data.h (struct tui_win_info): Add constructor.
 853         * tui/tui-data.c (tui_alloc_win_info): Use new.
 854         (tui_free_window): Use delete.
 855
 856 2019-06-22  Tom Tromey  <tom@tromey.com>
 857
 858         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
 859         declare.
 860         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
 861
 862 2019-06-22  Tom Tromey  <tom@tromey.com>
 863
 864         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
 865         declare.
 866         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
 867
 868 2019-06-22  Tom de Vries  <tdevries@suse.de>
 869
 870         * dwarf2read.c (create_addrmap_from_aranges)
 871         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
 872         instead of '%zu'.
 873
 874 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
 875
 876         * dwarf2read.h (dwarf2_section_info_def): Remove.
 877         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
 878         * dwarf2read.c (struct dwo_sections) <types>: Change type to
 879         std::vector<dwarf2_section_info>.
 880         (struct dwo_file) <~dwo_file>: Remove.
 881         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
 882         types field.
 883         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
 884         (dwarf2_read_debug_names): Likewise.
 885         (create_debug_types_hash_table): Change parameter type to
 886         array_view, adjust code accordingly.
 887         (dwarf2_locate_dwo_sections): Adjust to std::vector.
 888         (partial_die_info::fixup): Likewise.
 889         (determine_prefix): Likewise.
 890         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
 891
 892 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 893
 894         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
 895         gdb_bfd_ref_ptr.
 896         <~dwo_file>: Remove call to gdb_bfd_unref.
 897         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
 898         gdb_bfd_ref_ptr::get.
 899
 900 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 901
 902         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
 903         type to htab_up.
 904         * dwarf2read.c (struct dwo_file): Initialize fields.
 905         <~dwo_file>: New.
 906         (free_dwo_file): Remove, move content to ~dwo_file.
 907         (struct dwo_file_deleter): Remove.
 908         (dwo_file_up>: Remove custom deleter.
 909         (free_dwo_files): Remove.
 910         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
 911         dwo_files.
 912         (process_skeletonless_type_units): Call unique_ptr::get.
 913         (allocate_dwo_file_hash_table): Add deleter to created hash
 914         table.  Change return type to htab_up.
 915         (lookup_dwo_file_slot): Don't memset dwo_file, call
 916         unique_ptr::get.
 917         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
 918         (create_dwo_unit_in_dwp_v2): Likewise.
 919         (open_and_init_dwo_file): Likewise.
 920         (free_dwo_file_from_slot): Remove.
 921
 922 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 923
 924         * dwarf2read.h (struct dwarf2_section_info) <readin,
 925         is_virtual>: Change type to bool.
 926         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
 927         true instead of 1.
 928
 929 2019-06-19  Tom Tromey  <tom@tromey.com>
 930
 931         * tui/tui-data.h (tui_init_content_element): Don't declare.
 932
 933 2019-06-19  Tom Tromey  <tom@tromey.com>
 934
 935         * tui/tui-data.h (tui_init_win_info): Don't declare.
 936
 937 2019-06-19  Tom de Vries  <tdevries@suse.de>
 938
 939         * dwarf2read.h (abstract_to_concrete): Change type to
 940         std::unordered_map<sect_offset, std::vector<sect_offset>,
 941         gdb::hash_enum<sect_offset>>.
 942
 943 2019-06-19  Tom Tromey  <tromey@adacore.com>
 944
 945         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
 946         EVAL_AVOID_SIDE_EFFECTS specially.
 947
 948 2019-06-19  Tom Tromey  <tromey@adacore.com>
 949
 950         * source-cache.c (highlighter): New global.
 951         (source_cache::get_source_lines): Create a highlighter on demand.
 952
 953 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 954
 955         * defs.h (deprecated_interactive_hook): Delete declaration.
 956         * interps.c (clear_interpreter_hooks): Remove use of
 957         deprecated_interactive_hook.
 958         * top.c (deprecated_interactive_hook): Delete definition.
 959         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
 960
 961 2019-06-18  Tom de Vries  <tdevries@suse.de>
 962
 963         PR gdb/24515
 964         * dwarf2read.h (abstract_to_concrete): Change type from
 965         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
 966         std::unordered_map<sect_offset, std::vector<sect_offset>>.
 967         * dwarf2read.c (read_variable): Update.
 968         (dwarf2_fetch_die_loc_sect_off): Update.
 969
 970 2019-06-17  Tom de Vries  <tdevries@suse.de>
 971
 972         PR gdb/24617
 973         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
 974         accessing parent[parent_len - 1].
 975
 976 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
 977
 978         PR gdb/24364
 979         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
 980         call dtrace_process_dof with NULL dof.
 981
 982 2019-06-16  Tom de Vries  <tdevries@suse.de>
 983
 984         PR gdb/24445
 985         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
 986
 987 2019-06-16  Tom Tromey  <tom@tromey.com>
 988
 989         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 990         (make_all_visible): Use address of member.
 991
 992 2019-06-16  Tom Tromey  <tom@tromey.com>
 993
 994         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
 995         (tui_free_window, free_content, free_content_elements): Remove
 996         unnecessary cast.
 997         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
 998         cast.
 999         * tui/tui-regs.c (tui_show_register_group)
1000         (tui_display_registers_from, tui_display_reg_element_at_line):
1001         Remove unnecessary cast.
1002
1003 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1004
1005         * linux-nat.c (normal_mask): Delete.
1006         (_initialize_linux_nat): Don't initialise normal_mask.
1007
1008 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1009
1010         PR gdb/24445
1011         * dwarf-index-write.h (write_psymtabs_to_index): Add
1012         dwz_basename parameter.
1013         * dwarf-index-write.c (write_gdbindex): Move file writing to
1014         write_gdbindex_1.  Change return type void.
1015         (assert_file_size): Move up, remove filename parameter.
1016         (write_gdbindex_1): New function.
1017         (write_debug_names): Change return type to void, call
1018         assert_file_size.
1019         (struct index_wip_file): New struct.
1020         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1021         file logic to index_wip_file.  Write index for dwz file if
1022         needed.
1023         (save_gdb_index_command): Pass basename of dwz file, if present.
1024         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1025         build-id of dwz file, if present.
1026         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1027         (dwarf2_get_dwz_file): Likewise.
1028         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1029         (dwarf2_get_dwz_file): Likewise.
1030
1031 2019-06-16  Tom Tromey  <tom@tromey.com>
1032
1033         * coffread.c (process_coff_symbol): Use xstrdup.
1034         * value.c (create_internalvar): Use xstrdup.
1035
1036 2019-06-16  Tom Tromey  <tom@tromey.com>
1037
1038         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1039         * breakpoint.c (stopin_command, stopat_command)
1040         (until_break_command, decode_location_default): Remove unnecessary
1041         cast.
1042         * utils.c (subset_compare): Remove unnecessary cast.
1043         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1044         cast.
1045         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1046         cast.
1047         * infcmd.c (path_command): Remove unnecessary cast.
1048         * coffread.c (decode_type): Remove unnecessary cast.
1049         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1050         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1051         * tui/tui-stack.c (tui_show_locator_content)
1052         (tui_show_frame_info): Remove unnecessary cast.
1053         * tui/tui-win.c (tui_scroll_forward_command)
1054         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1055         (parse_scrolling_args): Remove unnecessary cast.
1056         * tui/tui-data.c (init_win_info, tui_del_window)
1057         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1058         (free_content_elements): Remove unnecessary cast.
1059         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1060         unnecessary cast.
1061         * tui/tui-source.c (tui_set_source_content)
1062         (tui_vertical_source_scroll): Remove unnecessary cast.
1063         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1064         cast.
1065         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1066         * tui/tui-regs.c (tui_display_registers_from)
1067         (tui_display_register): Remove unnecessary cast.
1068         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1069         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1070         (make_visible): Remove unnecessary cast.
1071         * tui/tui-winsource.c (tui_erase_source_content)
1072         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1073         unnecessary cast.
1074         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1075         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1076         * stabsread.c (read_type, read_array_type, read_range_type):
1077         Remove unnecessary cast.
1078         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1079         (parse_symbol, parse_type, upgrade_type, parse_external)
1080         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1081         unnecessary cast.
1082         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1083
1084 2019-06-16  Tom Tromey  <tom@tromey.com>
1085
1086         * tui/tui-data.c (tui_alloc_generic_win_info)
1087         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1088         checks.
1089
1090 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1091             Andrew Burgess  <andrew.burgess@embecosm.com>
1092
1093         * f-typeprint.c (f_print_type): Don't return early for not
1094         associated or not allocated types.
1095         (f_type_print_varspec_suffix): Add print_rank parameter and print
1096         ranks of array types in case they dangling.
1097         (f_type_print_base): Add print_rank parameter.
1098
1099 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1100
1101         * NEWS: Mention new MI commands.
1102         * break-catch-throw.c (enum exception_event_kind): Move to
1103         breakpoint.h.
1104         (print_mention_exception_catchpoint): Output text as a single
1105         message.
1106         (catch_exception_command_1): Rename to...
1107         (catch_exception_event): ...this, make non-static, update header
1108         command, and change some parameter types.
1109         (catch_catch_command): Update for changes to
1110         catch_exception_command_1.
1111         (catch_throw_command): Likewise.
1112         (catch_rethrow_command): Likewise.
1113         * breakpoint.c (enum exception_event_kind): Delete.
1114         * breakpoint.h (enum exception_event_kind): Moved here from
1115         break-catch-throw.c.
1116         (catch_exception_event): Declare.
1117         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1118         (mi_cmd_catch_throw): New function.
1119         (mi_cmd_catch_rethrow): New function.
1120         (mi_cmd_catch_catch): New function.
1121         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1122         'catch-catch' entries.
1123         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1124         (mi_cmd_catch_rethrow): Declare.
1125         (mi_cmd_catch_catch): Declare.
1126
1127 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1128
1129         * annotate.c (annotate_source_line): Change return type to void,
1130         update implementation to match.
1131         * annotate.h (annotate_source_line): Change return type to void,
1132         update header comment.
1133         * stack.c (print_frame_info): Don't change what frame information
1134         is printed based on whether annotations are on or not.
1135
1136 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1137
1138         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1139         (annotate_source): Make static.
1140         (annotate_source_line): Moved from source.c and renamed from
1141         identify_source_line.  Update the return type.
1142         * annotate.h (annotate_source): Delete declaration.
1143         (annotate_source_line): Declaration moved from source.h, and
1144         renamed from identify_source_line.  Return type updated.
1145         * source.c (identify_source_line): Moved to annotate.c and renamed
1146         to annotate_source_line.
1147         (info_line_command): Remove check of annotation_level.
1148         * source.h (identify_source_line): Move declaration to annotate.h
1149         and rename to annotate_source_line.
1150         * stack.c: Add 'annotate.h' include.
1151         (print_frame_info): Remove check of annotation_level before
1152         calling annotate_source_line.
1153
1154 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1155
1156         * source-cache.c (source_cache::get_plain_source_lines): Use
1157         open_source_file_with_line_charpos instead of just
1158         open_source_file, remove call to find_source_lines.
1159         (source_cache::get_source_lines): Likewise.
1160         * source.c (find_source_lines): Make static.
1161         (get_filename_and_charpos): Renamed into...
1162         (open_source_file_with_line_charpos): ..this along with changes to
1163         return a scoped_fd, and some other minor clean ups.
1164         (identify_source_line): Use open_source_file_with_line_charpos.
1165         (search_command_helper): Use open_source_file_with_line_charpos
1166         instead of just open_source_file, remove call to
1167         find_source_lines.
1168         * source.h (open_source_file_with_line_charpos): Declare new
1169         function.
1170         (find_source_lines): Delete declaration.
1171
1172 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1173
1174         * source.c (get_filename_and_charpos): Remove fullname
1175         parameter.
1176         (identify_source_line): Update call to get_filename_and_charpos.
1177
1178 2019-06-14  Tom Tromey  <tromey@adacore.com>
1179
1180         PR gdb/24502:
1181         * ui-style.h (skip_ansi_escape): Update comment.
1182         * ui-file.h (class no_terminal_escape_file): New class.
1183         * ui-file.c (no_terminal_escape_file::write)
1184         (no_terminal_escape_file::puts): New methods.
1185         * cli/cli-logging.c (handle_redirections): Use
1186         no_terminal_escape_file.
1187
1188 2019-06-14  Tom Tromey  <tromey@adacore.com>
1189
1190         * NEWS: Move convenience variable news above Python news.
1191
1192 2019-06-14  Tom Tromey  <tom@tromey.com>
1193
1194         * gnulib: Move directory to top-level.
1195         * configure.ac: Don't configure gnulib.
1196         * configure: Rebuild.
1197         * common/common-defs.h: Use new path to gnulib.
1198         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1199         (GNULIB_H): Remove.
1200         (INCGNU): Look in new gnulib location.
1201         (HFILES_NO_SRCDIR): Remove gnulib files.
1202         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1203         (generated_files): Remove GNULIB_H.
1204         ($(LIBGNU), all-lib): Remove targets.
1205         (distclean): Don't mention GNULIB_BUILDDIR.
1206         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1207
1208 2019-06-14  Tom Tromey  <tromey@adacore.com>
1209
1210         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1211         Warn if symbol file does not provide any symbols.
1212
1213 2019-06-14  Tom Tromey  <tromey@adacore.com>
1214
1215         * source.c (find_and_open_source): Respect basenames_may_differ.
1216
1217 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1218
1219         * annotate.c (annotate_breakpoints_invalid): Make use of
1220         scoped_restore_terminal_state.
1221         (annotate_frames_invalid): Likewise.
1222
1223 2019-06-14  Tom Tromey  <tromey@adacore.com>
1224
1225         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1226         allow assignment to an internalvar.
1227
1228 2019-06-14  Tom Tromey  <tromey@adacore.com>
1229
1230         * ada-lex.l: Allow "_" in attribute names.
1231
1232 2019-06-14  Tom Tromey  <tromey@adacore.com>
1233
1234         PR gdb/24653:
1235         * regcache.c (registers_changed): Don't call alloca.
1236         * top.c (execute_command): Don't call alloca.
1237
1238 2019-06-13  Pedro Alves  <palves@redhat.com>
1239
1240         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1241         'expression'.  When parsing an expression, error out if there's
1242         junk after "unlimited".
1243         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1244         (do_set_command): Adjust calls to is_unlimited_literal.
1245
1246 2019-06-13  Pedro Alves  <palves@redhat.com>
1247
1248         * compile/compile.c (make_compile_options_def_group): Add braces
1249         around array_view initializer.
1250         * thread.c (make_thread_apply_all_options_def_group)
1251         (make_thread_apply_all_options_def_group): Likewise.
1252
1253 2019-06-13  Pedro Alves  <palves@redhat.com>
1254
1255         * NEWS (New commands): Mention "maint test-options
1256         require-delimiter", "maint test-options unknown-is-error", "maint
1257         test-options unknown-is-operand" and "maint show
1258         test-options-completion-result".
1259         (New command options, command completion): New section.
1260         (Completion improvements): New section.
1261         Mention that you can abbreviate "unlimited".
1262
1263 2019-06-13  Pedro Alves  <palves@redhat.com>
1264
1265         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1266         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1267         * unittests/cli-utils-selftests.c (test_parse_flags)
1268         (test_parse_flags_qcs): Delete.
1269         (test_cli_utils): Don't call deleted functions.
1270
1271 2019-06-13  Pedro Alves  <palves@redhat.com>
1272
1273         * thread.c: Include "cli/cli-option.h".
1274         (tp_array_compar_ascending): Global.
1275         (tp_array_compar): Delete function.
1276         (tp_array_compar_ascending, tp_array_compar_descending): New
1277         functions.
1278         (ascending_option_def, qcs_flag_option_def)
1279         (thr_qcs_flags_option_defs)
1280         (make_thread_apply_all_options_def_group)
1281         (make_thread_apply_options_def_group): New.
1282         (thread_apply_all_command): Use gdb::option::process_options.
1283         (thread_apply_command_completer)
1284         (thread_apply_all_command_completer): New.
1285         (thread_apply_command): Use gdb::option::process_options.
1286         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1287         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1288         to generate help text of "thread apply".  Adjust "taas"'s help.
1289         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1290         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1291
1292 2019-06-13  Pedro Alves  <palves@redhat.com>
1293
1294         * thread.c (thread_apply_command): Check for invalid TID with
1295         isdigit instead of !isalpha.
1296
1297 2019-06-13  Pedro Alves  <palves@redhat.com>
1298
1299         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1300         (validate_flags_qcs): New.
1301         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1302         (validate_flags_qcs): Declare.
1303         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1304         (make_frame_apply_options_def_group): New.
1305         (frame_apply_command_count): Process options with
1306         gdb::option::process_options.
1307         (frame_apply_completer): New.
1308         (frame_apply_level_completer, frame_apply_all_completer)
1309         (frame_apply_completer): New.
1310         (_initialize_stack): Update help of "frame apply", "frame apply
1311         level", "frame apply all" and "faas" to mention supported options
1312         and install command completers.
1313         * stack.h (frame_apply_all_completer): Declare.
1314         * thread.c: Include "stack.h".
1315         (tfaas_command): Add "--".
1316         (_initialize_thread): Update help "tfaas" to mention supported
1317         options and install command completer.
1318
1319 2019-06-13  Pedro Alves  <palves@redhat.com>
1320
1321         * completer.c (complete_nested_command_line): New.
1322         (gdb_completion_word_break_characters_throw): Add assertion.
1323         * completer.h (complete_nested_command_line): Declare.
1324
1325 2019-06-13  Pedro Alves  <palves@redhat.com>
1326
1327         * stack.c (parse_backtrace_qualifiers): New.
1328         (backtrace_command): Use it.
1329         (backtrace_command_completer): Complete on qualifiers.
1330
1331 2019-06-13  Pedro Alves  <palves@redhat.com>
1332
1333         * frame.c: Include "cli/cli-option.h.
1334         (user_set_backtrace_options): New.
1335         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1336         Delete.
1337         (get_prev_frame): Adjust.
1338         (boolean_option_def, uinteger_option_def)
1339         (set_backtrace_option_defs): New.
1340         (_initialize_frame): Adjust and use
1341         gdb::option::add_setshow_cmds_for_options to install "set
1342         backtrace past-main" and "set backtrace past-entry".
1343         * frame.h: Include "cli/cli-option.h".
1344         (struct frame_print_options): Forward declare.
1345         (print_frame_arguments_all, print_frame_arguments_scalars)
1346         (print_frame_arguments_none): Declare.
1347         (print_entry_values): Delete declaration.
1348         (struct frame_print_options, user_frame_print_options): New.
1349         (struct set_backtrace_options): New.
1350         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1351         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1352         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1353         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1354         (list_args_or_locals): Add frame_print_options parameter.
1355         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1356         * python/py-framefilter.c (enumerate_args): Pass down
1357         USER_FRAME_PRINT_OPTIONS.
1358         * stack.c: Include "cli/cli-option.h".
1359         (print_frame_arguments_all, print_frame_arguments_scalars)
1360         (print_frame_arguments_none): Declare.
1361         (print_raw_frame_arguments, print_entry_values): Delete.
1362         (user_frame_print_options): New.
1363         (boolean_option_def, enum_option_def, frame_print_option_defs):
1364         New.
1365         (struct backtrace_cmd_options): New.
1366         (bt_flag_option_def): New.
1367         (backtrace_command_option_defs): New.
1368         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1369         (print_frame_arg, read_frame_arg, print_frame_args)
1370         (print_frame_info, print_frame): Add frame_print_options parameter
1371         and use it.
1372         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1373         (backtrace_command_1): Add frame_print_options and
1374         backtrace_cmd_options parameters and use them.
1375         (make_backtrace_options_def_group): New.
1376         (backtrace_command): Process command options with
1377         gdb::option::process_options.
1378         (backtrace_command_completer): New.
1379         (_initialize_stack): Extend "backtrace"'s help to mention
1380         supported options.  Install completer for "backtrace".
1381         Install some settings commands with add_setshow_cmds_for_options.
1382
1383 2019-06-13  Pedro Alves  <palves@redhat.com>
1384
1385         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1386         and that "set/show print raw frame-arguments" are now deprecated.
1387
1388         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1389         command.
1390         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1391         * stack.c (_initialize_stack): Install "set/show print
1392         raw-frame-arguments", and deprecate "set/show print raw
1393         frame-arguments".
1394         * valprint.c (_initialize_valprint): Deprecate "set/show print
1395         raw".
1396
1397 2019-06-13  Pedro Alves  <palves@redhat.com>
1398
1399         * compile/compile.c (struct compile_options): New.
1400         (compile_flag_option_def, compile_command_option_defs)
1401         (make_compile_options_def_group): New.
1402         (compile_file_command): Handle options with
1403         gdb::option::process_options.
1404         (compile_file_command_completer): New function.
1405         (compile_code_command): Handle options with
1406         gdb::option::process_options.
1407         (compile_code_command_completer): New function.
1408         (_initialize_compiler): Install completers for "compile code" and
1409         "compile file".  Mention available options in "compile code" and
1410         "compile code"'s help.
1411         * completer.c (advance_to_completion_word): New, factored out from
1412         ...
1413         (advance_to_expression_complete_word_point): ... this.
1414         (advance_to_filename_complete_word_point): New.
1415         * completer.h (advance_to_filename_complete_word_point): New
1416         declaration.
1417
1418 2019-06-13  Pedro Alves  <palves@redhat.com>
1419
1420         * compile/compile.c: Include "cli/cli-option.h".
1421         (compile_print_value): Scope data pointer is now a
1422         value_print_options pointer; adjust.
1423         (compile_print_command): Process options.  Scope data pointer is
1424         now a value_print_options pointer; adjust.
1425         (_initialize_compile): Update "compile print"'s help to include
1426         supported options.  Install a completer for "compile print".
1427         * cp-valprint.c (show_vtblprint, show_objectprint)
1428         (show_static_field_print): Delete.
1429         (_initialize_cp_valprint): Don't install "set print
1430         static-members", "set print vtbl", "set print object" here.
1431         * printcmd.c: Include "cli/cli-option.h" and
1432         "common/gdb_optional.h".
1433         (print_command_parse_format): Rework to fill in a
1434         value_print_options instead of a format_data.
1435         (print_value): Change parameter type from format_data pointer to
1436         value_print_options reference.  Adjust.
1437         (print_command_1): Process options.  Adjust to pass down a
1438         value_print_options.
1439         (print_command_completer): New.
1440         (_initialize_printcmd): Install print_command_completer as
1441         handle_brkchars completer for the "print" command.  Update
1442         "print"'s help to include supported options.
1443         * valprint.c: Include "cli/cli-option.h".
1444         (show_vtblprint, show_objectprint, show_static_field_print): Moved
1445         here from cp-valprint.c.
1446         (boolean_option_def, uinteger_option_def)
1447         (value_print_option_defs, make_value_print_options_def_group):
1448         New.  Use gdb::option::add_setshow_cmds_for_options to install
1449         "set print elements", "set print null-stop", "set print repeats",
1450         "set print pretty", "set print union", "set print array", "set
1451         print address", "set print symbol", "set print array-indexes".
1452         * valprint.h: Include <string> and "cli/cli-option.h".
1453         (make_value_print_options_def_group): Declare.
1454         (print_value): Change parameter type from format_data pointer to
1455         value_print_options reference.
1456         (print_command_completer): Declare.
1457
1458 2019-06-13  Pedro Alves  <palves@redhat.com>
1459
1460         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
1461         (COMMON_SFILES): Add maint-test-settings.c.
1462         * cli/cli-decode.c (boolean_enums): New global, factored out from
1463         ...
1464         (add_setshow_boolean_cmd): ... here.
1465         * cli/cli-decode.h (boolean_enums): Declare.
1466         * cli/cli-option.c: New file.
1467         * cli/cli-option.h: New file.
1468         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
1469         factored out from ...
1470         (parse_cli_boolean_value(const char *)): ... this.
1471         (is_unlimited_literal): Change parameter type to pointer to
1472         pointer.  Adjust and advance ARG pointer.
1473         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1474         (parse_cli_var_enum): New, factored out from ...
1475         (do_set_command): ... this.  Adjust.
1476         * cli/cli-setshow.h (parse_cli_boolean_value)
1477         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1478         (parse_cli_var_enum): Declare.
1479         * cli/cli-utils.c: Include "cli/cli-option.h".
1480         (get_ulongest): New.
1481         * cli/cli-utils.h (get_ulongest): Declare.
1482         (check_for_argument): New overloads.
1483         * maint-test-options.c: New file.
1484
1485 2019-06-13  Pedro Alves  <palves@redhat.com>
1486
1487         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
1488         parse a range if "-" is at the end of the string.
1489
1490 2019-06-13  Pedro Alves  <palves@redhat.com>
1491
1492         * cli/cli-setshow.c (parse_auto_binary_operation)
1493         (parse_cli_boolean_value): Don't allow "o".
1494
1495 2019-06-13  Pedro Alves  <palves@redhat.com>
1496
1497         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
1498         * NEWS: Mention maint test-settings KIND.
1499         * maint-test-settings.c: New file.
1500
1501 2019-06-13  Pedro Alves  <palves@redhat.com>
1502
1503         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
1504         completer.
1505         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
1506         "set" completers.
1507
1508 2019-06-13  Pedro Alves  <palves@redhat.com>
1509
1510         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
1511         after item.
1512
1513 2019-06-13  Pedro Alves  <palves@redhat.com>
1514
1515         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
1516
1517 2019-06-13  Pedro Alves <palves@redhat.com>
1518
1519         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
1520         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
1521         call.
1522         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
1523         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
1524         calls.
1525         (check_for_argument): Skip spaces after argument.
1526
1527 2019-06-13  Pedro Alves  <palves@redhat.com>
1528
1529         * thread.c (thread_apply_command): Adjust TID parsing.
1530         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
1531         detected before end of string.
1532         (tid_is_in_list): Error out if LIST is invalid.
1533
1534 2019-06-13  Pedro Alves  <palves@redhat.com>
1535
1536         * completer.c (complete_line_internal_1): Rewind completion word
1537         point.
1538         (completion_tracker::advance_custom_word_point_by): Change
1539         parameter type to int.
1540         * completer.h (completion_tracker::advance_custom_word_point_by):
1541         Likewise.
1542
1543 2019-06-13  Pedro Alves  <palves@redhat.com>
1544
1545         * completer.c (advance_to_completion_word): Handle delimiters.
1546
1547 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
1548
1549         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1550
1551 2019-06-11  Tom Tromey  <tom@tromey.com>
1552
1553         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1554         (xmalloc_failed): Move to alloc.c.
1555         * alloc.c: New file.
1556         * Makefile.in (COMMON_SFILES): Add alloc.c.
1557
1558 2019-06-11  Tom Tromey  <tom@tromey.com>
1559
1560         * nat/linux-waitpid.c: Don't include server.h.
1561         (linux_debug): Remove.
1562         (my_waitpid): Update.
1563
1564 2019-06-11  Tom Tromey  <tromey@adacore.com>
1565
1566         * infcall.c (_initialize_infcall): Remove trailing newline from
1567         help.
1568         * user-regs.c (_initialize_user_regs): Remove trailing newline
1569         from help.
1570         * typeprint.c (_initialize_typeprint): Remove trailing newline
1571         from help.
1572         * reverse.c (_initialize_reverse): Remove trailing newlines from
1573         help.
1574         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1575         from help.
1576         * language.c (add_set_language_command): Remove trailing newline
1577         from help.
1578         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1579         help.
1580         * disasm.c (_initialize_disasm): Remove trailing newline from
1581         help.
1582         * top.c (init_main): Remove trailing newline from help.
1583         * interps.c (_initialize_interpreter): Remove trailing newline
1584         from help.
1585         * btrace.c (_initialize_btrace): Remove trailing newlines from
1586         help.
1587         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1588         from help.
1589         * python/python.c (_initialize_python): Remove trailing newline
1590         from help.
1591         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1592         help.
1593         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1594         from help.  Reformat some text.
1595         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1596         from help.
1597         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1598         newline from help.
1599
1600 2019-06-11  Tom Tromey  <tromey@adacore.com>
1601
1602         * darwin-nat.c (darwin_decode_exception_message)
1603         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1604
1605 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1606
1607         * valops.c (value_slice): Check for not allocated or not
1608         associated values.
1609
1610 2019-06-10  Tom de Vries  <tdevries@suse.de>
1611
1612         PR gdb/24618
1613         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1614         sure an empty slot (defined by a 32-bit zero pair) is recognized as
1615         invalid.
1616
1617 2019-06-10  Tom de Vries  <tdevries@suse.de>
1618
1619         PR gdb/24611
1620         * linespec.c (linespec_lexer_lex_string): Remove incorrect
1621         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
1622
1623 2019-06-10  Tom de Vries  <tdevries@suse.de>
1624
1625         PR symtab/24545
1626         * symtab.c (struct demangled_name_entry): Add language field.
1627         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1628         static minimal symbol".  Set and use language field.
1629
1630 2019-06-10  Tom Tromey  <tromey@adacore.com>
1631
1632         * ada-lang.c (_initialize_ada_language): Update help text.
1633
1634 2019-06-10  Tom Tromey  <tromey@adacore.com>
1635
1636         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1637         with a newline.
1638         * guile/guile.c (handle_boot_error): Don't end warning with a
1639         newline.
1640         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1641         warning with a newline.
1642         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1643         newline.
1644         (s12z_frame_cache): Likewise.
1645         * dwarf-index-cache.c (index_cache::store): Don't end warning with
1646         a newline.
1647         * solib-svr4.c (disable_probes_interface): Don't end warning with
1648         a newline.
1649         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
1650         newline.
1651         * python/python.c (do_finish_initialization): Don't end warning
1652         with a newline.
1653
1654 2019-06-10  Tom Tromey  <tom@tromey.com>
1655
1656         * python/py-breakpoint.c (gdbpy_breakpoint_created)
1657         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1658         gdbpy_enter.
1659
1660 2019-06-10  Tom Tromey  <tromey@adacore.com>
1661
1662         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1663         data.
1664         (elf_new_init): Don't call stabsread_new_init.
1665         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1666         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
1667         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1668
1669 2019-06-10  Tom de Vries  <tdevries@suse.de>
1670
1671         PR symtab/16264
1672         PR symtab/24517
1673         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1674
1675 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1676
1677         * source.c (find_and_open_source): Also rewrite relative file
1678         names.
1679
1680 2019-04-26  Amos Bird  <amosbird@gmail.com>
1681
1682         * annotate.c (annotate_thread_exited): Add "thread-exited"
1683         annotation.
1684
1685 2019-06-06  Tom Tromey  <tromey@adacore.com>
1686
1687         * maint.h (class scoped_command_stats): Use
1688         DISABLE_COPY_AND_ASSIGN.
1689         <print_time>: New method.
1690         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1691         print_time.
1692         (scoped_command_stats::print_time): New method.
1693
1694 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1695
1696         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1697         instructions of lengths 6 or 8 bytes.
1698
1699 2019-06-04  Pedro Alves  <palves@redhat.com>
1700
1701         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1702
1703         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1704         * breakpoint.c (condition_completer): Likewise.
1705         * cli/cli-dump.c (scan_expression): Likewise.
1706         * common/filestuff.c (mkdir_recursive): Likewise.
1707         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1708         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1709         (gdb_abspath): Likewise.
1710         * compile/compile-cplus-types.c
1711         (compile_cplus_instance::decl_name): Likewise.
1712         * completer.c (complete_explicit_location):
1713         (signal_completer, reg_or_group_completer_1): Likewise.
1714         * cp-support.c (cp_remove_params_if_any): Likewise.
1715         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1716         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1717         * infcmd.c (strip_bg_char): Likewise.
1718         * linespec.c (copy_token_string): Likewise.
1719         * mi/mi-main.c (output_cores): Likewise.
1720         * psymtab.c (psymtab_search_name):
1721         * symfile.c (test_set_ext_lang_command): Likewise.
1722         * target.c (target_fileio_read_stralloc): Likewise.
1723         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1724         * value.c (complete_internalvar): Likewise.
1725
1726 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1727
1728         Add objfile property to gdb.Type.
1729         * NEWS: Mention Python API addition.
1730         * python/py-type.c (typy_get_objfile): New method.
1731
1732 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1733
1734         * NEWS: Mention the new set|show style [title|highlight].
1735         Mention changes to "show style", "help" and "apropos".
1736
1737 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1738
1739         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1740         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
1741         instead of print_help_for_command.
1742         (print_doc_of_command): New function.
1743         (help_list): Add 'apropos -v word' suggestion.
1744         (print_help_for_command): Style the command name using title style.
1745         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1746         (_initialize_cli_cmds): Describe -v in apropos_command help.
1747
1748 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1749
1750         * cli/cli-style.h (cli_style_option): Add name in constructor,
1751         add m_name class member, add constructor with intensity,
1752         add name class function.
1753         (cli_style_option::add_setshow_commands): Remove name argument.
1754         (highlight_style, title_style): New styles.
1755         * cli/cli-style.c (do_show): New function that shows a style
1756         characteristic styling the style name with itself.
1757         (set_style_name): New function.
1758         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1759         Update all callers according to the changes in cli/cli-style.h.
1760         * utils.h (fputs_highlighted): New function.
1761         * utils.c (fputs_highlighted): Likewise.
1762
1763 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1764
1765         * NEWS: Mention new pipe command and new convenience variables.
1766
1767 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1768
1769         * cli/cli-cmds.c (pipe_command): New function.
1770         (_initialize_cli_cmds): Call add_com for pipe_command.
1771         Define | as an alias for pipe.
1772         (exit_status_set_internal_vars): New function.
1773         (shell_escape): Call exit_status_set_internal_vars.
1774         cli/cli-decode.c (find_command_name_length): Recognize | as
1775         a single character command.
1776
1777 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1778
1779         * gdbcmd.h (execute_command_to_ui_file): New declaration.
1780         top.c (execute_command_to_ui_file): New function, mostly a copy
1781         of execute_command_to_string.
1782         (execute_command_to_string): Implement by calling
1783         execute_command_to_ui_file.
1784
1785 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1786
1787         * top.h (saved_command_line): Remove declaration.
1788         * top.c (previous_saved_command_line, previous_repeat_arguments):
1789         New variables.
1790         (saved_command_line): Make static, define together with other
1791         'repeat variables'.
1792         (dont_repeat): Clear repeat_arguments.
1793         (repeat_previous, get_saved_command_line, save_command_line):
1794         New functions.
1795         (gdb_init): Initialize saved_command_line
1796         and previous_saved_command_line.
1797         * main.c (captured_main_1): Remove saved_command_line initialization.
1798         * event-top.c (handle_line_of_input): Update to use
1799         the new 'repeat' related functions instead of direct access to
1800         saved_command_line.
1801         * command.h (repeat_previous, get_saved_command_line,
1802         save_command_line): New declarations.
1803         (dont_repeat): Add comment.
1804
1805 2019-05-30  Tom Tromey  <tromey@adacore.com>
1806
1807         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1808         Fix comment.
1809         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1810
1811 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1812
1813         PR cli/24587
1814         * completer.c (complete): Initialize variable word.
1815
1816 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1817
1818         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1819         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1820         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1821         'body' is NULL to the outter 'if', protecting the '!is_define'
1822         situation as well.
1823
1824 2019-05-29  Tom Tromey  <tromey@adacore.com>
1825
1826         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1827         (dwarf_unknown): New function.
1828         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1829         (dwarf_type_encoding_name): Use dwarf_unknown.
1830
1831 2019-05-29  Tom Tromey  <tromey@adacore.com>
1832
1833         PR c++/20020:
1834         * cp-valprint.c (cp_print_value_fields): Call
1835         cp_print_static_field inside "try".
1836
1837 2019-05-29  Tom Tromey  <tromey@adacore.com>
1838
1839         * inflow.c (struct terminal_info): Add default operator=.
1840         * configure: Rebuild.
1841         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1842         -Wdeprecated-copy-dtor, -Wredundant-move.
1843
1844 2019-05-29  Tom Tromey  <tromey@adacore.com>
1845
1846         * NEWS: Add entry.
1847         * infcmd.c (print_return_value_1): Handle finish_print
1848         option.
1849         (show_print_finish): New function.
1850         (_initialize_infcmd): Add "set/show print finish" commands.
1851         * valprint.c (user_print_options): Initialize new member.
1852         * valprint.h (struct value_print_options) <finish_print>: New
1853         member.
1854
1855 2019-05-28  Tom Tromey  <tromey@adacore.com>
1856
1857         * ada-lang.c (ada_remove_Xbn_suffix)
1858         (find_old_style_renaming_symbol)
1859         (parse_old_style_renaming): Remove.
1860         (ada_find_renaming_symbol): Don't call
1861         find_old_style_renaming_symbol.
1862         (ada_is_renaming_symbol): Rename from
1863         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1864         bool.  Now static.
1865         (ada_read_var_value): Update and simplify.
1866         * ada-exp.y (write_var_or_type): Remove old code.
1867
1868 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1869
1870         * event-top.c: Remove include comment.
1871         * inflow.c (class scoped_ignore_sigttou): Move from here...
1872         * inflow.h (class scoped_ignore_sigttou): ...to here.
1873         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1874         * top.c:  Remove include comment.
1875
1876 2019-05-27  Tom Tromey  <tom@tromey.com>
1877
1878         * NEWS: Fix typo.
1879
1880 2019-05-22  Tom Tromey  <tromey@adacore.com>
1881
1882         * target.c (target_follow_exec): Constify parameter.
1883         * target-delegates.c: Rebuild.
1884         * remote.c (remote_target::follow_exec): Constify parameter.
1885         * infrun.c (follow_exec): Constify parameter.
1886         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1887         (target_follow_exec): Likewise.
1888
1889 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1890
1891         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1892         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1893
1894 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1895
1896         * NEWS: Add debugredirect and testsuite sections.
1897
1898 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1899
1900         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1901         target descriptions using exclusively floating point register name
1902         aliases.
1903
1904 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1905
1906         PR gdb/18644:
1907         * f-lang.c (build_fortran_types): Handle the case where
1908         gdbarch_floatformat_for_type returns a nullptr.
1909
1910 2019-05-21  Tom de Vries  <tdevries@suse.de>
1911
1912         PR cli/24587
1913         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1914
1915 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1916
1917         PR gdb/18644:
1918         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1919         16-byte floats.
1920         * i386-tdep.c (i386_floatformat_for_type): Use
1921         floatformats_ia64_quad for the 16-byte floating point component
1922         within a fortran 32-byte complex number.
1923
1924 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1925
1926         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1927         delete default constructor.
1928         (find_partial_die): Update to return const struct.
1929         (partial_die_parent_scope): Move variable declaration into scope
1930         of its use and change its type to auto.
1931         (guess_partial_die_structure_name): Likewise.
1932         (partial_die_info::fixup): Likewise.
1933
1934 2019-05-17  Tom Tromey  <tromey@adacore.com>
1935
1936         * source.c (find_and_open_source): Remove cast.
1937
1938 2019-05-17  Tom Tromey  <tromey@adacore.com>
1939
1940         * annotate.c (annotate_source): Make "filename" const.
1941         * annotate.h (annotate_source): Use const.
1942
1943 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1944
1945         * disasm.c (set_disassembler_options): Send errors to stderr.
1946
1947 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1948
1949         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1950         (cli_interp_base::set_logging): Check debug_redirect.
1951         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1952         * cli/cli-logging.c (debug_redirect): Add static variable.
1953         (pop_output_files): Add default param.
1954         (handle_redirections): Print debug setting.
1955         (show_logging_command): Likewise.
1956         (_initialize_cli_logging): Add debugredirect command.
1957         * interps.c (current_interp_set_logging): Add debug_redirect
1958         parameter.
1959         * interps.h (set_logging): Add debug_redirect parameter.
1960         (current_interp_set_logging): Likewise.
1961         * mi/mi-common.h: Likewise.
1962         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1963
1964 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1965             Tom Tromey  <tromey@adacore.com>
1966
1967         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1968         directly.
1969         * cli/cli-interp.h (make_logging_output): Remove declaration.
1970         * cli/cli-logging.c (make_logging_output): Remove function.
1971         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1972         directly.
1973         * ui-file.c (tee_file::tee_file): Remove bools.
1974         (tee_file::~tee_file): Remove deletes.
1975         * ui-file.h (tee_file): Remove bools.
1976
1977 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1978
1979         * mi/mi-cmds.h (mi_cmd_complete): New function.
1980         * mi/mi-main.c (mi_cmd_complete): Likewise.
1981         * mi/mi-cmds.c: Define new MI command -complete.
1982         * NEWS: Mention new -complete command.
1983
1984 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1985
1986         * completer.h (complete): New function.
1987         * completer.c (complete): Likewise.
1988         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1989         function defined in completer.h.
1990
1991 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1992
1993         * MAINTAINERS (Write After Approval): Add myself.
1994
1995 2019-05-17  Tom de Vries  <tdevries@suse.de>
1996
1997         PR gdb/24094
1998         * dwarf2read.c (struct cu_partial_die_info): New struct.
1999         (find_partial_die): Return cu_partial_die_info.
2000         (partial_die_parent_scope, guess_partial_die_structure_name)
2001         (partial_die_info::fixup): Handle new return type of find_partial_die.
2002
2003 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2004
2005         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2006         "std::string", simplifying the algorithm.
2007
2008 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2009
2010         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2011         (stap_static_probe_ops::get_probes): Likewise.
2012
2013 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2014
2015         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2016         '-')" and "else if".
2017         (stap_parse_single_operand): Join checks for
2018         "gdbarch_stap_parse_special_token_p" and
2019         "gdbarch_stap_parse_special_token" in the same "if" statement.
2020         Invert check when verifying for operation on register
2021         displacement.
2022
2023 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2024
2025         * stap-probe.c (stap_get_opcode): Update comment.
2026         (stap_get_expected_argument_type): Likewise.
2027         (handle_stap_probe): Likewise.
2028
2029 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2030
2031         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2032         return type to 'bool'.  Adjust comment.  Use 'bool' when
2033         appropriate.
2034         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2035         * stap-probe.c (stap_parse_argument_1): Likewise.
2036         (stap_is_operator): Likewise.
2037         (stap_is_generic_prefix): Likewise.
2038         (stap_is_register_prefix): Likewise.
2039         (stap_is_register_indirection_prefix): Likewise.
2040         (stap_is_integer_prefix): Likewise.
2041         (stap_generic_check_suffix): Likewise.
2042         (stap_check_integer_suffix): Likewise.
2043         (stap_check_register_suffix): Likewise.
2044         (stap_check_register_indirection_suffix): Likewise.
2045         (stap_parse_register_operand): Likewise.
2046         (stap_parse_single_operand): Likewise.
2047         (stap_parse_argument_1): Likewise.
2048         (stap_probe::get_argument_count): Likewise.
2049         (stap_is_operator): Likewise.
2050
2051 2019-05-16  Tom Tromey  <tromey@adacore.com>
2052
2053         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2054         keyword to foreach.
2055
2056 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2057
2058         * linux-thread-db.c (try_thread_db_load_1): Change return type
2059         to bool.
2060         (try_thread_db_load): Likewise.
2061         (try_thread_db_load_from_pdir_1): Likewise.
2062         (try_thread_db_load_from_pdir): Likewise.
2063         (try_thread_db_load_from_sdir): Likewise.
2064         (try_thread_db_load_from_dir): Likewise.
2065         (thread_db_load_search): Likewise.
2066         (has_libpthread): Likewise.
2067         (thread_db_load): Likewise.
2068
2069 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2070
2071         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2072         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2073         NULL, and complain/return if that's the case.
2074
2075 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2076
2077         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2078         (advance, posn, abstract_read_memory): New functions.
2079         [struct mem_read_abstraction]: New struct.
2080         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2081
2082 2019-05-14  Tom Tromey  <tromey@adacore.com>
2083
2084         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2085         value is not lval_memory.
2086
2087 2019-05-14  Tom Tromey  <tromey@adacore.com>
2088
2089         * solib.c (info_sharedlibrary_command): Style the file name.
2090
2091 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2092
2093         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2094         (aarch64_vnv_type): Likewise.
2095         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2096         * common/tdesc.c: Likewise.
2097         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2098         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2099         * features/aarch64-fpu.xml: Add ieee half view.
2100         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2101         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2102         * gdbtypes.h (struct builtin_type): Likewise.
2103         (struct objfile_type): Likewise.
2104
2105 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2106
2107         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2108         typo.
2109         * location.h (string_to_event_location): Likewise.
2110
2111 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2112
2113         GDB 8.3 released.
2114
2115 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2116
2117         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2118         New variable declaration.
2119         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2120         New variable.
2121         (print_one_breakpoint): Use ui_out::test_flags and new global
2122         variable to compute use_fixed_output.
2123         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2124         Remove.
2125         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2126         (mi_multi_location_breakpoint_output_fixed): Remove.
2127         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2128         new variable.
2129         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2130         fix_multi_location_breakpoint_output flag if version >= 3.
2131         * ui-out.h (enum ui_out_flag)
2132         <fix_multi_location_breakpoint_output>: New enumerator.
2133
2134 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2135
2136         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2137
2138 2019-05-10  Tom Tromey  <tromey@adacore.com>
2139
2140         * ada-lang.c (catch_ada_completer): New function.
2141         (_initialize_ada_language): Use it.
2142
2143 2019-05-10  Tom Tromey  <tromey@adacore.com>
2144
2145         * thread.c (print_thread_info): Make "requested_threads" const.
2146         * gdbthread.h (print_thread_info): Make "requested_threads"
2147         const.
2148         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2149         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2150
2151 2019-05-08  Tom Tromey  <tom@tromey.com>
2152
2153         * gdbtypes.c (objfile_type_data): Change type.
2154         (objfile_type, _initialize_gdbtypes): Update.
2155
2156 2019-05-08  Tom Tromey  <tom@tromey.com>
2157
2158         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2159         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2160         (_initialize_dwarf2_frame): Update.
2161
2162 2019-05-08  Tom Tromey  <tom@tromey.com>
2163
2164         * objc-lang.c (objc_objfile_data): Change type.
2165         (find_methods): Update.
2166         (_initialize_objc_lang): Remove.
2167
2168 2019-05-08  Tom Tromey  <tom@tromey.com>
2169
2170         * stabsread.c (rs6000_builtin_type_data): Change type.
2171         (rs6000_builtin_type, _initialize_stabsread): Update.
2172
2173 2019-05-08  Tom Tromey  <tom@tromey.com>
2174
2175         * mips-tdep.c (mips_pdr_data): Remove.
2176         (_initialize_mips_tdep): Update.
2177
2178 2019-05-08  Tom Tromey  <tom@tromey.com>
2179
2180         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2181         (hppa_init_objfile_priv_data, read_unwind_info)
2182         (find_unwind_entry, _initialize_hppa_tdep): Update.
2183
2184 2019-05-08  Tom Tromey  <tom@tromey.com>
2185
2186         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2187         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2188         on obstack.
2189         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2190
2191 2019-05-08  Tom Tromey  <tom@tromey.com>
2192
2193         * mdebugread.c (basic_type_data): Change type.
2194         (basic_type, _initialize_mdebugread): Update.
2195
2196 2019-05-08  Tom Tromey  <tom@tromey.com>
2197
2198         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2199
2200 2019-05-08  Tom Tromey  <tom@tromey.com>
2201
2202         * nto-tdep.c (nto_inferior_data_reg): Change type.
2203         (nto_inferior_data): Update.
2204         (nto_inferior_data_cleanup, nto_new_inferior_data)
2205         (_initialize_nto_tdep): Remove.
2206         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2207
2208 2019-05-08  Tom Tromey  <tom@tromey.com>
2209
2210         * ada-lang.c (struct ada_inferior_data): Add initializers.
2211         (ada_inferior_data): Change type.
2212         (ada_inferior_data_cleanup): Remove.
2213         (get_ada_inferior_data, ada_inferior_exit)
2214         (struct ada_pspace_data): Add initializers, destructor.
2215         (ada_pspace_data_handle): Change type.
2216         (get_ada_pspace_data): Update.
2217         (ada_pspace_data_cleanup): Remove.
2218
2219 2019-05-08  Tom Tromey  <tom@tromey.com>
2220
2221         * coffread.c (struct coff_symfile_info): Add initializers.
2222         (coff_objfile_data_key): Move lower.  Change type.
2223         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2224         Update.
2225         (coff_free_info): Remove.
2226
2227 2019-05-08  Tom Tromey  <tom@tromey.com>
2228
2229         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2230         (fbsd_pspace_data_handle): Move lower.  Change type.
2231         (get_fbsd_pspace_data): Update.
2232         (fbsd_pspace_data_cleanup): Remove.
2233         (_initialize_fbsd_tdep): Update.
2234
2235 2019-05-08  Tom Tromey  <tom@tromey.com>
2236
2237         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2238         (get_ada_tasks_pspace_data): Update.
2239         (ada_tasks_pspace_data_cleanup): Remove.
2240         (_initialize_tasks): Update.
2241         (ada_tasks_inferior_data_handle): Change type.
2242         (get_ada_tasks_inferior_data): Update.
2243         (ada_tasks_inferior_data_cleanup): Remove.
2244         (struct ada_tasks_pspace_data): Add initializers.
2245
2246 2019-05-08  Tom Tromey  <tom@tromey.com>
2247
2248         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2249         * symfile-debug.c (debug_sym_get_probes): Change type.
2250         * stap-probe.c (handle_stap_probe):
2251         (stap_static_probe_ops::get_probes): Change type.
2252         * probe.h (class static_probe_ops) <get_probes>: Change type.
2253         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2254         (parse_probes_in_pspace): Update.
2255         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2256         Update.
2257         (any_static_probe_ops::get_probes): Change type.
2258         * elfread.c (elfread_data): New typedef.
2259         (probe_key): Change type.
2260         (elf_get_probes): Likewise.  Update.
2261         (probe_key_free): Remove.
2262         (_initialize_elfread): Update.
2263         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2264         Change type.
2265         (dtrace_process_dof_probe, dtrace_process_dof)
2266         (dtrace_static_probe_ops::get_probe): Change type.
2267
2268 2019-05-08  Tom Tromey  <tom@tromey.com>
2269
2270         * xcoffread.c (struct xcoff_symfile_info): Rename from
2271         coff_symfile_info.  Add initializers.
2272         (xcoff_objfile_data_key): Move lower.  Change type.
2273         (XCOFF_DATA): Rewrite.
2274         (xcoff_free_info): Remove.
2275         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2276         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2277         (xcoff_initial_scan): Update.
2278
2279 2019-05-08  Tom Tromey  <tom@tromey.com>
2280
2281         * solib-svr4.c (struct svr4_info): Add initializers and
2282         destructor.
2283         <probes_table>: Now an htab_up.
2284         (solib_svr4_pspace_data): Change type.
2285         (free_probes_table): Simplify.
2286         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2287         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2288         (probes_table_remove_objfile_probes, register_solib_event_probe)
2289         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2290         (_initialize_svr4_solib): Update.
2291
2292 2019-05-08  Tom Tromey  <tom@tromey.com>
2293
2294         * remote.c (remote_pspace_data): Change type.
2295         (remote_pspace_data_cleanup): Remove.
2296         (get_remote_exec_file, set_pspace_remote_exec_file)
2297         (_initialize_remote): Update.
2298
2299 2019-05-08  Tom Tromey  <tom@tromey.com>
2300
2301         * breakpoint.c (breakpoint_objfile_key): Change type.
2302         (get_breakpoint_objfile_data): Update.
2303         (free_breakpoint_objfile_data): Remove.
2304         (_initialize_breakpoint): Update.
2305
2306 2019-05-08  Tom Tromey  <tom@tromey.com>
2307
2308         * linux-tdep.c (struct linux_info): Add initializers.
2309         (linux_inferior_data): Move.  Change type.
2310         (invalidate_linux_cache_inf): Update.
2311         (linux_inferior_data_cleanup): Remove.
2312         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2313
2314 2019-05-08  Tom Tromey  <tom@tromey.com>
2315
2316         * auxv.c (auxv_inferior_data): Move.  Change type.
2317         (auxv_inferior_data_cleanup): Remove.
2318         (invalidate_auxv_cache_inf): Rewrite.
2319         (get_auxv_inferior_data, _initialize_auxv): Update.
2320
2321 2019-05-08  Tom Tromey  <tom@tromey.com>
2322
2323         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2324         (symfile_debug_objfile_data_key): Change type.
2325         (symfile_debug_installed, debug_qf_has_symbols)
2326         (debug_qf_find_last_source_symtab)
2327         (debug_qf_forget_cached_source_info)
2328         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2329         (debug_qf_print_stats, debug_qf_dump)
2330         (debug_qf_expand_symtabs_for_function)
2331         (debug_qf_expand_all_symtabs)
2332         (debug_qf_expand_symtabs_with_fullname)
2333         (debug_qf_map_matching_symbols)
2334         (debug_qf_expand_symtabs_matching)
2335         (debug_qf_find_pc_sect_compunit_symtab)
2336         (debug_qf_map_symbol_filenames)
2337         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2338         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2339         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2340         (debug_sym_read_linetable, debug_sym_relocate): Update.
2341         (symfile_debug_free_objfile): Remove.
2342         (install_symfile_debug_logging, _initialize_symfile_debug):
2343         Update.
2344
2345 2019-05-08  Tom Tromey  <tom@tromey.com>
2346
2347         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2348         allocate_on_obstack.
2349         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2350         (get_dwarf2_per_objfile): Update.
2351         (set_dwarf2_per_objfile): Remove.
2352         (dwarf2_has_info, dwarf2_get_section_info): Update.
2353         (dwarf2_free_objfile): Remove.
2354         (_initialize_dwarf2_read): Update.
2355
2356 2019-05-08  Tom Tromey  <tom@tromey.com>
2357
2358         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2359         initializers.
2360         <unsupported_script_warning_printed,
2361         script_not_found_warning_printed>: Now bool.
2362         (auto_load_pspace_data): Change type.
2363         (~auto_load_pspace_info): Rename from
2364         auto_load_pspace_data_cleanup.
2365         (get_auto_load_pspace_data, init_loaded_scripts_info)
2366         (clear_section_scripts, maybe_print_unsupported_script_warning)
2367         (maybe_print_script_not_found_warning, _initialize_auto_load):
2368         Update.
2369
2370 2019-05-08  Tom Tromey  <tom@tromey.com>
2371
2372         * objfiles.c (objfile_pspace_info): Add destructor and
2373         initializers.
2374         (objfiles_pspace_data): Change type.
2375         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2376         (get_objfile_pspace_data): Update.
2377         (objfiles_bfd_data): Change type.
2378         (get_objfile_bfd_data): Update.
2379         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2380
2381 2019-05-08  Tom Tromey  <tom@tromey.com>
2382
2383         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2384         Change type.
2385         (get_catch_syscall_inferior_data): Update.
2386         (catch_syscall_inferior_data_cleanup): Remove.
2387         (_initialize_break_catch_syscall): Update.
2388
2389 2019-05-08  Tom Tromey  <tom@tromey.com>
2390
2391         * inflow.c (struct terminal_info): Add destructor and
2392         initializers.
2393         (inflow_inferior_data): Change type.
2394         (~terminal_info): Rename from inflow_inferior_data_cleanup.
2395         (get_inflow_inferior_data, inflow_inferior_exit)
2396         (swap_terminal_info, _initialize_inflow): Update.
2397
2398 2019-05-08  Tom Tromey  <tom@tromey.com>
2399
2400         * target-dcache.c (target_dcache_cleanup): Remove.
2401         (target_dcache_aspace_key): Change type.
2402         (target_dcache_init_p, target_dcache_invalidate)
2403         (target_dcache_get, target_dcache_get_or_init)
2404         (_initialize_target_dcache): Update.
2405         * dcache.h (struct dcache_deleter): New.
2406
2407 2019-05-08  Tom Tromey  <tom@tromey.com>
2408
2409         * symtab.c (struct symbol_cache): Add destructor and
2410         initializers.
2411         (symbol_cache_key): Move.  Change type.
2412         (make_symbol_cache, free_symbol_cache): Remove.
2413         (get_symbol_cache): Update.
2414         (symbol_cache_cleanup): Remove.
2415         (ALL_PSPACES, symbol_cache_flush)
2416         (maintenance_print_symbol_cache)
2417         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
2418         Update.
2419
2420 2019-05-08  Tom Tromey  <tom@tromey.com>
2421
2422         * symtab.c (struct main_info): Add destructor and initializers.
2423         (main_progspace_key): Move.  Change type.
2424         (get_main_info): Update.
2425         (main_info_cleanup): Remove.
2426         (_initialize_symtab): Update.
2427
2428 2019-05-08  Tom Tromey  <tom@tromey.com>
2429
2430         * registry.h (DECLARE_REGISTRY): Define the _key class.
2431
2432 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2433
2434         * NEWS: Merge two 'New commands' sections.
2435
2436 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
2437
2438         * ada-valprint.c (ada_val_print_gnat_array): Remove language
2439         parameter and use Ada language definition instead.
2440         (ada_val_print_ptr): Remove unused language parameter.
2441         (ada_val_print_num): Remove language parameter and use Ada language
2442         definition instead.
2443         (ada_val_print_enum, ada_val_print_flt): Remove unused language
2444         parameter.
2445         (ada_val_print_struct_union, ada_val_print_ref): Remove language
2446         parameter and use Ada language definition instead.
2447         (ada_val_print_1): Update all ada_val_print_xxx calls.
2448         Remove language parameter.
2449         (ada_val_print): Update ada_val_print_1 call.
2450
2451 2019-05-08  Tom Tromey  <tromey@adacore.com>
2452
2453         * remote.c (remote_hw_watchpoint_limit)
2454         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
2455         Now static.
2456
2457 2019-05-08  Tom Tromey  <tromey@adacore.com>
2458
2459         * maint.c (_initialize_maint_cmds): Move initialization code to
2460         remote.c.
2461         (watchdog, show_watchdog): Move to remote.c.
2462         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
2463         "watchdog" static.
2464         (_initialize_remote): Move initialization code from maint.c.
2465         * defs.h (watchdog): Don't declare.
2466
2467 2019-05-08  Tom Tromey  <tromey@adacore.com>
2468
2469         * tui/tui-interp.c: Include main.h.
2470         * interps.c: Include main.h.
2471         * main.h (interpreter_p): Declare.
2472         * defs.h (interpreter_p): Don't declare.
2473
2474 2019-05-08  Tom Tromey  <tromey@adacore.com>
2475
2476         * dwarf2loc.c: Include dwarf2read.h.
2477         * defs.h (read_unsigned_leb128): Don't declare.
2478         * dwarf2read.h (read_unsigned_leb128): Declare.
2479
2480 2019-05-08  Tom Tromey  <tromey@adacore.com>
2481
2482         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
2483         method.
2484
2485 2019-05-08  Tom Tromey  <tromey@adacore.com>
2486
2487         * utils.c (fputs_maybe_filtered): Reset style after paging, even
2488         when no wrap column is set.
2489
2490 2019-05-08  Tom Tromey  <tromey@adacore.com>
2491
2492         * c-lang.c (c_get_string): Handle non-C-style arrays.
2493
2494 2019-05-08  Tom Tromey  <tromey@adacore.com>
2495
2496         * typeprint.c (print_offset_data::update): Print the bit offset,
2497         not the number of bits remaining.
2498
2499 2019-05-08  Tom Tromey  <tromey@adacore.com>
2500
2501         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
2502         padding at end of comment.
2503
2504 2019-05-08  Tom Tromey  <tromey@adacore.com>
2505
2506         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
2507         Compare main types.
2508
2509 2019-05-06  Tom Tromey  <tom@tromey.com>
2510
2511         * common/scoped_mmap.c: Include common-defs.h.
2512         * common/scoped_mmap.h: Don't include config.h.
2513
2514 2019-05-04  Tom Tromey  <tom@tromey.com>
2515
2516         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
2517         (struct aarch64_call_info): Add initializers.
2518         <si>: Now a std::vector.
2519         (pass_on_stack, aarch64_push_dummy_call): Update.
2520
2521 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
2522             Tom Tromey  <tom@tromey.com>
2523
2524         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
2525         (ppc_threads): Now a std::vector.  Now static.
2526         (hwdebug_find_thread_points_by_tid)
2527         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
2528         Update.
2529
2530 2019-05-04  Tom Tromey  <tom@tromey.com>
2531
2532         * arc-tdep.c (arc_tdesc_init): Return bool.
2533
2534 2019-05-04  Tom Tromey  <tom@tromey.com>
2535
2536         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2537         Use gdb_assert_not_reached.
2538
2539 2019-05-04  Tom Tromey  <tom@tromey.com>
2540
2541         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2542         "false".
2543
2544 2019-05-04  Tom Tromey  <tom@tromey.com>
2545
2546         * arc-tdep.c (arc_tdesc_init): Use bool.
2547
2548 2019-05-04  Tom Tromey  <tom@tromey.com>
2549
2550         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2551
2552 2019-05-04  Tom Tromey  <tom@tromey.com>
2553
2554         * cli/cli-cmds.c (valid_command_p): Return bool.
2555
2556 2019-05-04  Tom Tromey  <tom@tromey.com>
2557
2558         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2559         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2560
2561 2019-05-04  Raul Tambre  <raul@tambre.ee>
2562
2563         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2564         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2565         operator for comparison.
2566
2567 2019-05-04  Tom Tromey  <tom@tromey.com>
2568
2569         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2570         (lookup_partial_symbol, print_partial_symbols)
2571         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2572         (psymbol_compare): Update.
2573         (add_psymbol_to_bcache): Clear the entire psymbol.
2574         (maintenance_check_psymtabs): Update.
2575         * psympriv.h (struct partial_symbol): Don't derive from
2576         general_symbol_info.
2577         <obj_section, unrelocated_address, address,
2578         set_unrelocated_address>: Update.
2579         <ginfo>: New member.
2580         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2581         (debug_names::write_psymbols): Update.
2582
2583 2019-05-04  Tom de Vries  <tdevries@suse.de>
2584
2585         * contrib/cc-with-tweaks.sh: Support -n arg.
2586
2587 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2588
2589         * corelow.c (core_target::detach): Ensure frame cache and
2590         register caches are cleared.
2591         inferior.c (exit_inferior_1): Likewise.
2592
2593 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2594             Tom Tromey  <tom@tromey.com>
2595
2596         * dictionary.c (collate_pending_symbols_by_language): Remove
2597         "struct" from foreach.
2598         * symtab.c (lookup_global_symbol_from_objfile)
2599         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2600         foreach.
2601         * ser-tcp.c (net_open): Remove "struct" from foreach.
2602         * objfiles.c (objfile_relocate, objfile_rebase)
2603         (objfile_has_symbols): Remove "struct" from foreach.
2604         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2605         from foreach.
2606         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2607         foreach.
2608         * darwin-nat.c (thread_info_from_private_thread_info): Remove
2609         "struct" from foreach.
2610         * ada-lang.c (create_excep_cond_exprs)
2611         (ada_exception_catchpoint_cond_string): Remove "struct" from
2612         foreach.
2613
2614 2019-05-03  Tom Tromey  <tromey@adacore.com>
2615
2616         * ada-exp.y (convert_char_literal): Check suffix of each
2617         enumerator.
2618
2619 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
2620
2621         PR ada/21406:
2622         * ada-exp.y (yywrap): Don't define.
2623         * ada-lex.l (%option): Add noyywrap
2624         (yywrap): Remove.
2625
2626 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2627
2628         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2629         _WIN32_WINNT to the XP level, unless already defined to a higher
2630         level.
2631
2632         * unittests/parse-connection-spec-selftests.c:
2633         * ser-tcp.c:
2634         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
2635         override.
2636
2637         * symfile.c (find_separate_debug_file): Remove colon from the
2638         drive spec of DOS/Windows file names of the target, so that the
2639         file name produced from DEBUGDIR and the target's directory will
2640         be valid on DOS/Windows systems.
2641
2642 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2643
2644         * rust-lang.c (val_print_struct): Handle printing structures
2645         containing strings.
2646
2647 2019-05-02  Tom Tromey  <tromey@adacore.com>
2648
2649         * valarith.c (_initialize_valarith): Remove.
2650
2651 2019-05-01  Tom Tromey  <tromey@adacore.com>
2652
2653         * ada-lang.c (ada_value_primitive_field): Treat more fields as
2654         bitfields.
2655
2656 2019-05-01  Tom Tromey  <tromey@adacore.com>
2657
2658         * ada-lang.c (ada_value_assign): Correctly compute starting offset
2659         for big-endian copies.
2660
2661 2019-04-30  Ali Tamur  <tamur@google.com>
2662         * gdb/dwarf2read.c (read_3_bytes): New declaration.
2663         (read_attribute_value): Added DW_FORM_strx1-4 cases.
2664         (read_3_bytes): New function.
2665
2666 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2667
2668         * windows-nat.c (main_thread_id): Delete.
2669         (handle_output_debug_string): Replace main_thread_id by
2670         current_event.dwThreadId.
2671         (fake_create_process): Likewise.
2672         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2673         Do not set main_thread_id.
2674         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2675         current_event.dwThreadId.
2676         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2677
2678 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2679
2680         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2681         Use current_event.dwThreadId instead of main_thread_id.
2682
2683 2019-04-30  Tom Tromey  <tromey@adacore.com>
2684
2685         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2686         (create_excep_cond_exprs): Iterate over program spaces.
2687         (ada_exception_catchpoint_cond_string): Examine all minimal
2688         symbols for exception types.
2689
2690 2019-04-30  Tom Tromey  <tromey@adacore.com>
2691
2692         PR c++/24470:
2693         * dwarf2read.c (process_structure_scope): Handle case where type
2694         has template parameters but no symbol was created.
2695
2696 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2697             Chris January  <chris.january@arm.com>
2698
2699         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2700         qualifier.
2701         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2702
2703 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2704
2705         * f-typeprint.c (f_print_type): Update rules for printing
2706         whitespace.
2707         (f_type_print_varspec_suffix): Likewise.
2708
2709 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2710             Chris January  <chris.january@arm.com>
2711
2712         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2713         function arguments.
2714
2715 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2716
2717         * f-lang.c (build_fortran_types): Change name of void type to
2718         lower case.
2719         * f-typeprint.c (f_type_print_base): Print the name of the void
2720         type, rather than a fixed string.
2721         * f-valprint.c (f_decorations): Use lower case void string.
2722
2723 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2724             Chris January  <chris.january@arm.com>
2725
2726         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2727         types for Fortran.
2728
2729 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2730             Chris January  <chris.january@arm.com>
2731             David Lecomber  <david.lecomber@arm.com>
2732
2733         * f-exp.y (BINOP_INTRINSIC): New token.
2734         (exp): New parser rule handling BINOP_INTRINSIC.
2735         (f77_keywords): Add new builtin procedures.
2736         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2737         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2738         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2739         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2740         (print_unop_subexp_f): New function.
2741         (print_binop_subexp_f): New function.
2742         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2743         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2744         (dump_subexp_body_f): Likewise.
2745         (operator_check_f): Likewise.
2746         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2747         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2748
2749 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2750
2751         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2752         UNOP_KIND.
2753         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2754         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2755         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2756         (operator_length_f): New fuction.
2757         (print_subexp_f): New function.
2758         (op_name_f): New function.
2759         (dump_subexp_body_f): New function.
2760         (operator_check_f): New function.
2761         (exp_descriptor_f): Replace standard expression handling functions
2762         with new functions.
2763         * gdb/fortran-operator.def: New file.
2764         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2765         * gdb/std-operator.def: Remove UNOP_KIND.
2766
2767 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2768
2769         * std-operator.def: Remove unbalanced, stray double quote
2770         character.
2771
2772 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2773             Chris January  <chris.january@arm.com>
2774             Daniel Everett  <daniel.everett@arm.com>
2775             Nick Forrington  <nick.forrington@arm.com>
2776             Richard Bunt  <richard.bunt@arm.com>
2777
2778         * cp-valprint.c (cp_print_value_fields): Allow an additional level
2779         of depth when printing anonymous structs or unions.
2780         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2781         Don't print either the top-level value, or the children if the
2782         max-depth is exceeded.
2783         (ppscm_print_children): When printing the key of a map, allow one
2784         extra level of depth.
2785         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2786         print either the top-level value, or the children if the max-depth
2787         is exceeded.
2788         (print_children): When printing the key of a map, allow one extra
2789         level of depth.
2790         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2791         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2792         (user_print_options): Initialise max_depth field.
2793         (val_print_scalar_or_string_type_p): New function.
2794         (val_print): Check to see if the max depth has been reached.
2795         (val_print_check_max_depth): Define new function.
2796         (show_print_max_depth): New function.
2797         (_initialize_valprint): Add 'print max-depth' option.
2798         * valprint.h (struct value_print_options) <max_depth>: New field.
2799         (val_print_check_max_depth): Declare new function.
2800         * NEWS: Document new feature.
2801
2802 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2803
2804         * ada-lang.c (ada_language_defn): Initialise new field.
2805         * c-lang.c (c_is_string_type_p): New function.
2806         (c_language_defn): Initialise new field.
2807         (cplus_language_defn): Initialise new field.
2808         (asm_language_defn): Initialise new field.
2809         (minimal_language_defn): Initialise new field.
2810         * c-lang.h (c_is_string_type_p): Declare new function.
2811         * d-lang.c (d_language_defn): Initialise new field.
2812         * f-lang.c (f_is_string_type_p): New function.
2813         (f_language_defn): Initialise new field.
2814         * go-lang.c (go_is_string_type_p): New function.
2815         (go_language_defn): Initialise new field.
2816         * language.c (default_is_string_type_p): New function.
2817         (unknown_language_defn): Initialise new field.
2818         (auto_language_defn): Initialise new field.
2819         * language.h (struct language_defn) <la_is_string_type_p>: New
2820         member variable.
2821         (default_is_string_type_p): Declare new function.
2822         * m2-lang.c (m2_language_defn): Initialise new field.
2823         * objc-lang.c (objc_language_defn): Initialise new field.
2824         * opencl-lang.c (opencl_language_defn): Initialise new field.
2825         * p-lang.c (pascal_is_string_type_p): New function.
2826         (pascal_language_defn): Initialise new field.
2827         * rust-lang.c (rust_is_string_type_p): New function.
2828         (rust_language_defn): Initialise new field.
2829
2830 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2831
2832         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2833         New field.
2834         * ada-lang.c (ada_language_defn): Initialise new field.
2835         * c-lang.c (c_language_defn): Likewise.
2836         (cplus_language_defn): Likewise.
2837         (asm_language_defn): Likewise.
2838         (minimal_language_defn): Likewise.
2839         * d-lang.c (d_language_defn): Likewise.
2840         * f-lang.c (f_language_defn): Likewise.
2841         * go-lang.c (go_language_defn): Likewise.
2842         * language.c (unknown_language_defn): Likewise.
2843         (auto_language_defn): Likewise.
2844         * m2-lang.c (m2_language_defn): Likewise.
2845         * objc-lang.c (objc_language_defn): Likewise.
2846         * opencl-lang.c (opencl_language_defn): Likewise.
2847         * p-lang.c (pascal_language_defn): Likewise.
2848         * rust-lang.c (rust_language_defn): Likewise.
2849
2850 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2851
2852         * ada-lang.c (ada_is_character_type): Change return type to bool.
2853         (ada_is_string_type): Likewise.
2854         * ada-lang.h (ada_is_character_type): Update declaration
2855         (ada_is_string_type): Likewise.
2856
2857 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2858
2859         Support style in 'frame|thread apply'
2860
2861         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2862         * record.c (record_start, record_stop): Update callers of
2863         execute_command_to_string with false.
2864         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2865         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2866         methods.
2867         (class string_file): New constructor with term_out parameter.
2868         Override methods term_out and can_emit_style_escape.  New member
2869         term_out.
2870         (class stdio_file): Override can_emit_style_escape.
2871         (class tee_file): Override term_out and can_emit_style_escape.
2872         * utils.h (can_emit_style_escape): Remove.
2873         * utils.c (can_emit_style_escape): Likewise.
2874         Update all callers of can_emit_style_escape (SOMESTREAM) to
2875         SOMESTREAM->can_emit_style_escape.
2876         * source-cache.c (source_cache::get_source_lines): Likewise.
2877         * stack.c (frame_apply_command_count): Call execute_command_to_string
2878         passing the term_out characteristic of the current gdb_stdout.
2879         * thread.c (thr_try_catch_cmd): Likewise.
2880         * top.c (execute_command_to_string): pass term_out parameter
2881         to construct the string_file for the command output.
2882         * ui-file.c (term_cli_styling): New function (most code moved
2883         from utils.c can_emit_style_escape).
2884         (string_file::string_file, string_file::can_emit_style_escape,
2885         stdio_file::can_emit_style_escape, tee_file::term_out,
2886         tee_file::can_emit_style_escape): New functions.
2887
2888 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2889
2890         * NEWS: Mention the new set|show may-call-functions.
2891         * infcall.c (may_call_functions_p): New variable.
2892         (show_may_call_functions_p): New function.
2893         (call_function_by_hand_dummy): Throws an error if not
2894         may-call-functions.
2895         (_initialize_infcall): Call add_setshow_boolean_cmd for
2896         may-call-functions.
2897
2898 2019-04-25  Keith Seitz  <keiths@redhat.com>
2899
2900         PR c++/24367
2901         * cp-support.c (inspect_type): Don't attempt substitutions
2902         of symbol with the same name.
2903
2904 2019-04-25  Tom Tromey  <tromey@adacore.com>
2905
2906         PR gdb/24475:
2907         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2908         static.
2909
2910 2019-04-25  Tom Tromey  <tromey@adacore.com>
2911
2912         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2913         rvalue reference.
2914         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2915         (gdb_xml_parser::parse): Use std::move.
2916         * python/python-internal.h (gdbpy_convert_exception): Take a const
2917         reference.
2918         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2919         std::move.
2920         * python/py-utils.c (gdbpy_convert_exception): Take a const
2921         reference.
2922         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2923         Use std::move.
2924         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2925         Use std::move.
2926         * mi/mi-main.c (mi_print_exception): Take a const reference.
2927         * main.c (handle_command_errors): Take a const reference.
2928         * linespec.c (parse_linespec): Use std::move.
2929         * infcall.c (run_inferior_call): Use std::move.
2930         (call_function_by_hand_dummy): Use std::move.
2931         * exec.c (try_open_exec_file): Use std::move.
2932         * exceptions.h (exception_print, exception_fprintf)
2933         (exception_print_same): Update.
2934         * exceptions.c (print_exception, exception_print)
2935         (exception_fprintf, exception_print_same): Change parameters to
2936         const reference.
2937         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2938         * common/new-op.c: Use std::move.
2939         * common/common-exceptions.h (struct gdb_exception): Add move
2940         constructor.
2941         (struct gdb_exception_error, struct gdb_exception_quit, struct
2942         gdb_quit_bad_alloc): Change constructor to move constructor.
2943         (throw_exception): Change parameter to rvalue reference.
2944         * common/common-exceptions.c (throw_exception): Take rvalue
2945         reference.
2946         * cli/cli-interp.c (safe_execute_command): Use std::move.
2947         * breakpoint.c (insert_bp_location, location_to_sals): Use
2948         std::move.
2949
2950 2019-04-25  Tom Tromey  <tromey@adacore.com>
2951
2952         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2953         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2954         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2955         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2956         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2957         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2958         guile/scm-value.c: Use unpack.
2959         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2960         gdbscm_gdb_exception.
2961         (gdbscm_throw_gdb_exception): Likewise.
2962         (struct gdbscm_gdb_exception): New.
2963         (unpack): New function.
2964         (gdbscm_wrap): Use unpack.
2965
2966 2019-04-25  Tom Tromey  <tromey@adacore.com>
2967
2968         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2969         (gdb_rl_callback_handler): Use std::move.
2970         * common/common-exceptions.h (struct gdb_exception): Add move
2971         assignment operator.
2972         (throw_exception_sjlj): Change "exception" to const reference.
2973         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2974         (throw_exception_sjlj): Change "exception" to const reference.
2975
2976 2019-04-25  Tom Tromey  <tromey@adacore.com>
2977
2978         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2979         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2980         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2981         Update.
2982         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2983         Update.
2984         * mi/mi-interp.c (mi_interp::exec): Update.
2985         * linespec.c (parse_linespec): Update.
2986         * infcall.c (run_inferior_call): Update.
2987         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2988         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2989         (gdbscm_lookup_global_symbol): Update.
2990         * guile/scm-param.c (gdbscm_parameter_value): Update.
2991         * guile/scm-frame.c (gdbscm_frame_read_register)
2992         (gdbscm_frame_read_var): Update.
2993         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2994         * exec.c (try_open_exec_file): Update.
2995         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2996         (gdb_rl_callback_handler): Update.
2997         * common/common-exceptions.h (exception_none): Don't declare.
2998         * common/common-exceptions.c (exception_none): Don't define.
2999         (struct catcher) <exception>: Update.
3000         * cli/cli-interp.c (safe_execute_command): Update.
3001         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3002
3003 2019-04-25  Ali Tamur  <tamur@google.com>
3004
3005         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3006         (read_attribute_value): Likewise.
3007         (dwarf2_read_addr_index): Update comment.
3008         (read_str_index): Add DW_FORM_strx.
3009         (dwarf2_string_attr): Likewise.
3010         (dwarf2_const_value_attr): Likewise.
3011         (dump_die_shallow): Likewise.
3012         (dwarf2_fetch_constant_bytes): Likewise.
3013         (skip_form_bytes): Likewise.
3014         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3015
3016 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3017
3018         PR corefiles/11608
3019         PR corefiles/18187
3020         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3021         OFFSET.  Verify if current mapping contains an ELF header.
3022         (linux_find_memory_regions_full): Adjust call to
3023         dump_mapping_p.
3024
3025 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3026             Kang Li <kanglictf@gmail.com>
3027
3028         PR gdb/21600
3029
3030         * dwarf2-frame.c (read_initial_length): Be consistent about using
3031         unsigned representation of length.
3032         (decode_frame_entry_1): Likewise.  Check for wraparound of
3033         end pointer as well as buffer overflow.
3034
3035 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3036
3037         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3038         "vq".
3039
3040 2019-04-24  Tom Tromey  <tromey@adacore.com>
3041
3042         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3043
3044 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3045
3046         * s12z-tdep.c (s12z_unwind_pc): Delete.
3047         (s12z_unwind_sp): Delete.
3048         (s12z_gdbarch_init): Don't register deleted functions with
3049         gdbarch.
3050
3051 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3052
3053         * rl78-tdep.c (rl78_unwind_sp): Delete.
3054         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3055
3056 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3057
3058         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3059         (xstormy16_unwind_pc): Delete.
3060         (xstormy16_dummy_id): Delete.
3061         (xstormy16_gdbarch_init): Don't register deleted functions with
3062         gdbarch.
3063
3064 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3065
3066         * vax-tdep.c (vax_unwind_pc): Delete.
3067         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3068
3069 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3070
3071         * v850-tdep.c (v850_unwind_sp): Delete.
3072         (v850_unwind_pc): Delete.
3073         (v850_dummy_id): Delete.
3074         (v850_gdbarch_init): Don't register deleted functions with
3075         gdbarch.
3076
3077 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3078
3079         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3080         (tilegx_unwind_pc): Delete.
3081         (tilegx_unwind_dummy_id): Delete.
3082         (tilegx_gdbarch_init): Don't register deleted functions with
3083         gdbarch.
3084
3085 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3086
3087         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3088         (tic6x_dummy_id): Delete.
3089         (tic6x_gdbarch_init): Don't register deleted functions with
3090         gdbarch.
3091
3092 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3093
3094         * sparc-tdep.c (sparc_unwind_pc): Delete.
3095         (sparc32_gdbarch_init): Don't register deleted function with
3096         gdbarch.
3097
3098 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3099
3100         * sh-tdep.c (sh_unwind_sp): Delete.
3101         (sh_unwind_pc): Delete.
3102         (sh_dummy_id): Delete.
3103         (sh_gdbarch_init): Don't register deleted functions with
3104         gdbarch.
3105
3106 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3107
3108         * score-tdep.c (score_unwind_sp): Delete.
3109         (score_unwind_pc): Delete.
3110         (score_dummy_id): Delete.
3111         (score_gdbarch_init): Don't register deleted functions with
3112         gdbarch.
3113
3114 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3115
3116         * rx-tdep.c (rx_unwind_pc): Delete.
3117         (rx_unwind_sp): Delete.
3118         (rx_dummy_id): Delete.
3119         (rx_gdbarch_init): Don't register deleted functions with
3120         gdbarch.  Update comment.
3121
3122 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3123
3124         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3125         (rs6000_dummy_id): Delete.
3126         (rs6000_gdbarch_init): Don't register deleted functions with
3127         gdbarch.
3128
3129 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3130
3131         * or1k-tdep.c (or1k_dummy_id): Delete.
3132         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3133
3134 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3135
3136         * nios2-tdep.c (nios2_dummy_id): Delete.
3137         (nios2_unwind_sp): Delete.
3138         (nios2_gdbarch_init): Don't register deleted functions with
3139         gdbarch.
3140
3141 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3142
3143         * nds32-tdep.c (nds32_dummy_id): Delete.
3144         (nds32_unwind_pc): Delete.
3145         (nds32_unwind_sp): Delete.
3146         (nds32_gdbarch_init): Don't register deleted functions with
3147         gdbarch.
3148
3149 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3150
3151         * msp430-tdep.c (msp430_unwind_pc): Delete.
3152         (msp430_unwind_sp): Delete.
3153         (msp430_dummy_id): Delete.
3154         (msp430_gdbarch_init): Don't register deleted functions with
3155         gdbarch.
3156
3157 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3158
3159         * moxie-tdep.c (moxie_unwind_sp): Delete.
3160         (moxie_unwind_pc): Delete.
3161         (moxie_dummy_id): Delete.
3162         (moxie_gdbarch_init): Don't register deleted functions with
3163         gdbarch.
3164
3165 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3166
3167         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3168         (mn10300_unwind_pc): Delete.
3169         (mn10300_unwind_sp): Delete.
3170         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3171         mn10300_unwind_sp.
3172         (mn10300_frame_unwind_init): Don't register deleted functions with
3173         gdbarch.
3174
3175 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3176
3177         * mep-tdep.c (mep_unwind_pc): Delete.
3178         (mep_unwind_sp): Delete.
3179         (mep_dummy_id): Delete.
3180         (mep_gdbarch_init): Don't register deleted functions with
3181         gdbarch.
3182
3183 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3184
3185         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3186         (m68hc11_unwind_sp): Delete.
3187         (m68hc11_gdbarch_init): Don't register deleted functions with
3188         gdbarch.
3189
3190 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3191
3192         * m32r-tdep.c (m32r_unwind_sp): Delete.
3193         (m32r_unwind_pc): Delete.
3194         (m32r_dummy_id): Delete.
3195         (m32r_gdbarch_init): Don't register deleted functions with
3196         gdbarch.
3197
3198 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3199
3200         * m32c-tdep.c (m32c_unwind_pc): Delete.
3201         (m32c_unwind_sp): Delete.
3202         (m32c_dummy_id): Delete.
3203         (m32c_gdbarch_init): Don't register deleted functions with
3204         gdbarch.
3205
3206 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3207
3208         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3209         (lm32_unwind_pc): Delete.
3210         (lm32_dummy_id): Delete.
3211         (lm32_gdbarch_init): Don't register deleted functions with
3212         gdbarch.
3213
3214 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3215
3216         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3217         (iq2000_unwind_pc): Delete.
3218         (iq2000_dummy_id): Delete.
3219         (iq2000_gdbarch_init): Don't register deleted functions with
3220         gdbarch.
3221
3222 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3223
3224         * nds32-tdep.c (nds32_type_align): Delete.
3225         (nds32_push_dummy_call): Use type_align instead.
3226
3227 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3228
3229         * arm-tdep.c (arm_type_align): Only handle vector override case.
3230         (arm_push_dummy_call): Use type_align.
3231         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3232
3233 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3234
3235         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3236         case.
3237         (pass_on_stack): Use type_align.
3238         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3239         function.
3240
3241 2019-04-23  Tom Tromey  <tromey@adacore.com>
3242
3243         * dwarf2read.c (line_header::file_name_at): Remove unused
3244         overload.
3245
3246 2019-04-23  Tom de Vries  <tdevries@suse.de>
3247
3248         PR gdb/24438
3249         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3250         invocation.
3251
3252
3253 2019-03-27  Ali Tamur  <tamur@google.com>
3254
3255         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3256         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3257         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3258         (dwarf_expr_context::get_addr_index): Likewise
3259         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3260         (symbol_needs_eval_context::get_addr_index): Likewise
3261         (disassemble_dwarf_expression): Add DW_OP_addrx
3262         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3263         (read_cutu_die_from_dwo): Update comment
3264         (skip_one_die): Add DW_FORM_addrx
3265         (read_attribute_value): Likewise
3266         (var_decode_location): Add DW_OP_addrx
3267         (dwarf2_const_value_attr): Add DW_FORM_addrx
3268         (dump_die_shallow): Likewise
3269         (dwarf2_fetch_constant_bytes): Likewise
3270         (decode_locdesc): Add DW_OP_addrx
3271         (skip_form_bytes): Add DW_FORM_addrx
3272
3273 2019-04-22  Ali Tamur  <tamur@google.com>
3274
3275         * MAINTAINERS (Write After Approval): Add self.
3276
3277 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3278
3279         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3280         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3281         (open_symbol_file_object): Likewise.
3282         (svr4_default_sos): Add info parameter.
3283         (svr4_read_so_list): Likewise.
3284         (svr4_current_sos_direct): Adjust functions calls to pass down
3285         info.
3286         (svr4_current_sos_1): Add info parameter.
3287         (svr4_current_sos): Call get_svr4_info, pass info down to
3288         svr4_current_sos_1.
3289         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3290         get_svr4_info.
3291         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3292         get_svr4_info.
3293         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3294         to get_svr4_info.
3295         (probes_table_remove_objfile_probes): Likewise.
3296         (register_solib_event_probe): Add info parameter.
3297         (solist_update_incremental): Pass info parameter down to
3298         svr4_read_so_list.
3299         (disable_probes_interface): Add info parameter.
3300         (svr4_handle_solib_event): Pass current_program_space to
3301         get_svr4_info.  Adjust disable_probes_interface cleanup.
3302         (svr4_create_probe_breakpoints): Add info parameter, pass it
3303         down to register_solib_event_probe.
3304         (svr4_create_solib_event_breakpoints): Add info parameter,
3305         pass it down to svr4_create_probe_breakpoints.
3306         (enable_break): Pass info down to
3307         svr4_create_solib_event_breakpoints.
3308         (svr4_solib_create_inferior_hook): Pass current_program_space to
3309         get_svr4_info.
3310         (svr4_clear_solib): Likewise.
3311
3312 2019-04-22  Pedro Alves  <palves@redhat.com>
3313
3314         * solib-svr4.c (svr4_free_objfile_observer): New.
3315         (probe_and_action::objfile): New field.
3316         (probes_table_htab_remove_objfile_probes)
3317         (probes_table_remove_objfile_probes): New functions.
3318         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3319         in the new probe_and_action.  Don't store the probe in 'lookup'.
3320         (svr4_create_probe_breakpoints): Pass objfile to
3321         register_solib_event_probe.
3322         (_initialize_svr4_solib): Register a free_objfile observer.
3323
3324 2019-04-19  Tom Tromey  <tom@tromey.com>
3325
3326         * common/queue.h: Remove.
3327
3328 2019-04-19  Tom Tromey  <tom@tromey.com>
3329
3330         * event-loop.c: Don't include "common/queue.h".
3331
3332 2019-04-19  Tom Tromey  <tom@tromey.com>
3333
3334         * remote.c (remote_target): Use delete.
3335         * remote-notif.h: Include <list>, not "common/queue.h".
3336         (notif_client_p): Remove typedef.
3337         (remote_notif_state): Add constructor, destructor, initializer.
3338         <notif_queue>: Now a std::list.
3339         (remote_notif_state_xfree): Don't declare.
3340         * remote-notif.c (remote_notif_process, handle_notification)
3341         (remote_notif_state_allocate): Update.
3342         (~remote_notif_state): Rename from remote_notif_state_xfree.
3343
3344 2019-04-19  Tom Tromey  <tom@tromey.com>
3345
3346         * symfile.c (reread_symbols): Update.
3347         * objfiles.c (objfile_register_static_link)
3348         (objfile_lookup_static_link): Update
3349         (~objfile) Don't delete static_links.
3350         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3351
3352 2019-04-19  Tom Tromey  <tom@tromey.com>
3353
3354         * type-stack.h (struct type_stack) <insert>: Constify string.
3355         * type-stack.c (type_stack::insert): Constify string.
3356         * gdbtypes.h (lookup_template_type): Update.
3357         (address_space_name_to_int): Update.
3358         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3359         const.
3360         (lookup_template_type): Make name const.
3361         * c-exp.y: Update rules.
3362         (lex_one_token, classify_name, classify_inner_name)
3363         (c_print_token): Update.
3364         * p-exp.y: Update rules.
3365         (yylex): Update.
3366         * f-exp.y: Update rules.
3367         (yylex): Update.
3368         * d-exp.y: Update rules.
3369         (lex_one_token, classify_name, classify_inner_name): Update.
3370         * parse.c (write_dollar_variable, copy_name): Return std::string.
3371         * parser-defs.h (copy_name): Change return type.
3372         * m2-exp.y: Update rules.
3373         (yylex): Update.
3374         * go-exp.y (lex_one_token): Update.
3375         Update rules.
3376         (classify_unsafe_function, classify_packaged_name)
3377         (classify_name, yylex): Update.
3378
3379 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3380
3381         * configure.ac: add --enable-source-highlight switch.
3382         * configure: Regenerate.
3383         * top.c (print_gdb_version): plumb --enable-source-highlight
3384         status to "show configuration".
3385
3386 2019-04-19  Tom Tromey  <tromey@adacore.com>
3387
3388         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3389         Check ADA_TYPE_P.
3390         (empty_record, ada_template_to_fixed_record_type_1)
3391         (template_to_static_fixed_type)
3392         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3393         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3394         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3395         macros.
3396
3397 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
3398
3399         PR symtab/24423:
3400         * source.c (print_source_lines_base): Advance "iter" when a
3401         control character is seen.
3402
3403 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3404
3405         * inferior.h (struct infcall_suspend_state_deleter):
3406         Catch exception in destructor to avoid crash.
3407
3408 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3409
3410         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3411         close to the add_com "shell".
3412
3413 2019-04-18  Tom Tromey  <tromey@adacore.com>
3414
3415         * process-stratum-target.h (class process_stratum_target)
3416         <stratum>: Add "final".
3417
3418 2019-04-17  Tom Tromey  <tromey@adacore.com>
3419
3420         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
3421         against nullptr before use.
3422
3423 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
3424
3425         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
3426
3427 2019-04-17  Jim Wilson  <jimw@sifive.com>
3428             Andrew Burgess  <andrew.burgess@embecosm.com>
3429
3430         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
3431         code read might fail, assume 4-byte breakpoint in that case.
3432
3433 2019-04-15  Leszek Swirski  <leszeks@google.com>
3434
3435         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
3436         rather than a hand-rolled POD check when checking for forced MEMORY
3437         classification.
3438
3439 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3440
3441         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
3442         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
3443         function.
3444         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
3445         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
3446         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
3447         declaration.
3448
3449 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3450
3451         * aarch64-linux-nat.c
3452         (aarch64_linux_nat_target::thread_architecture): Add override.
3453         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
3454         each VQ.
3455
3456 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3457
3458         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
3459
3460 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3461
3462         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
3463         target types of size 96-bits, add some additional comments, and
3464         check that the builtin type we found was the correct size.
3465
3466 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
3467
3468         * utils.c (prompt_for_continue): Don't restore the styling at the
3469         end, as applied_style has the wrong value.  This fixes styling in
3470         long lists of file names that are interrupted by the "Continue?"
3471         prompt.
3472
3473 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3474
3475         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
3476         * c-lang.c (c_language_defn): Likewise.
3477         (cplus_language_defn): Likewise.
3478         (asm_language_defn): Likewise.
3479         (minimal_language_defn): Likewise.
3480         * d-lang.c (d_language_defn): Likewise.
3481         * f-lang.c (f_language_defn): Likewise.
3482         * go-lang.c (go_language_defn): Likewise.
3483         * language.c (unknown_language_defn): Likewise.
3484         (auto_language_defn): Likewise.
3485         * language.h (struct language_defn): Remove la_magic field.
3486         (LANG_MAGIC): Delete.
3487         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
3488         * objc-lang.c (objc_language_defn): Likewise.
3489         * opencl-lang.c (opencl_language_defn): Likewise.
3490         * p-lang.c (pascal_language_defn): Likewise.
3491         * rust-lang.c (rust_language_defn): Likewise.
3492
3493 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3494
3495         * riscv-tdep.c (riscv_type_align): New function.
3496         (riscv_type_alignment): Delete.
3497         (riscv_arg_location): Use 'type_align'.
3498         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
3499
3500 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3501
3502         * gdbtypes.c (type_align): A struct with no non-static fields also
3503         has alignment of 1.
3504
3505 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3506
3507         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
3508         component to 0.
3509         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
3510         member.
3511         (riscv_struct_info::analyse): New implementation using new
3512         analyse_inner member function.
3513         (riscv_struct_info::field_offset): New member function.
3514         (riscv_struct_info::m_offsets): New member variable.
3515         (riscv_struct_info::analyse_inner): New private member function,
3516         takes the old implementation of riscv_struct_info::analyse but
3517         extended to track field offsets.
3518         (riscv_call_arg_struct): Update the struct folding special cases
3519         to handle cases where empty C++ structs, which are non-zero
3520         length, are found.
3521         (riscv_arg_location): Initialise the length of each location, a
3522         non-zero length now indicates the location is in use.
3523         (riscv_push_dummy_call): Allow for the first location having a
3524         non-zero offset when setting up arguments.
3525         (riscv_return_value): Likewise, but for return values.
3526
3527 2019-04-11  Tom Tromey  <tromey@adacore.com>
3528
3529         * utils.c (internal_vproblem): Make "msg" const.
3530
3531 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
3532
3533         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
3534         * trad-frame.c (trad_frame_reset_saved_regs): New function.
3535         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3536         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3537
3538 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
3539
3540         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3541         function.
3542         (fill_gregset): Call amd64_linux_collect_native_gregset instead
3543         of amd64_collect_native_gregset.
3544         (amd64_linux_nat_target::store_registers): Likewise.
3545
3546 2019-04-10  Tom Tromey  <tom@tromey.com>
3547
3548         * symtab.c (lookup_global_symbol_from_objfile)
3549         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3550         * objfiles.h (class separate_debug_iterator): New.
3551         (class separate_debug_range): New.
3552         (struct objfile) <separate_debug_objfiles>: New method.
3553         (objfile_separate_debug_iterate): Don't declare.
3554         * objfiles.c (separate_debug_iterator::operator++): Rename from
3555         objfile_separate_debug_iterate.
3556         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3557         iterator.
3558         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3559         iterator.
3560
3561 2019-04-10  Tom Tromey  <tom@tromey.com>
3562
3563         * symfile.c (reread_symbols): Remove old comment.
3564         * objfiles.c (free_all_objfiles): Fix a typo.
3565
3566 2019-04-10  Tom Tromey  <tom@tromey.com>
3567
3568         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3569         * minsyms.c (lookup_minimal_symbol): Use foreach.
3570         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3571         (lookup_minimal_symbol_solib_trampoline): Likewise.
3572         * symfile.c (reread_symbols): Use foreach.
3573
3574 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3575             Tom Tromey  <tromey@adacore.com>
3576
3577         PR rust/24414:
3578         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3579         (rust_lex_int_test): Change "value" to be LONGEST.
3580         (rust_lex_tests): Add test for long integer literal.
3581
3582 2019-04-09  Tom Tromey  <tromey@adacore.com>
3583
3584         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3585         to bool.
3586         (extended_remote_target::attach): Update.
3587         (remote_target::remote_notice_new_inferior): Update.
3588         (remote_target::add_current_inferior_and_thread): Update.
3589         * inferior.c (exit_inferior_1): Use "false".
3590         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3591
3592 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3593
3594         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3595         the "start" command.
3596
3597 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3598
3599         * python/py-inferior.c (infpy_thread_from_thread_handle):
3600         Adjust comments to reflect renaming of thread_from_thread_handle
3601         to thread_from_handle.  Adjust keywords.  Fix type error message.
3602         (inferior_object_methods): Add thread_from_handle.  Retain
3603         thread_from_thread_handle, but mark it as deprecated.
3604
3605 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3606
3607         * gdbthread.h (find_thread_by_handle): Revise declaration.
3608         * thread.c (find_thread_by_handle): Likewise.  Adjust
3609         implementation too.
3610         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3611         support for buffer objects as handles.
3612
3613 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3614
3615         * python/py-infthread.c (thpy_thread_handle): New function.
3616         (thread_object_methods): Register thpy_thread_handle.
3617
3618 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3619
3620         * gdbthread.h (thread_to_thread_handle): Declare.
3621         * thread.c (gdbtypes.h): Include.
3622         (thread_to_thread_handle): New function.
3623
3624         * target.h (struct target_ops): Add thread_info_to_thread_handle.
3625         (target_thread_info_to_thread_handle): Declare.
3626         * target.c (target_thread_info_to_thread_handle): New function.
3627         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3628         * target-delegates.c: Regenerate.
3629
3630         * linux-thread-db.c (class thread_db_target): Add method
3631         thread_info_to_thread_handle.
3632         (thread_db_target::thread_info_to_thread_handle): Define.
3633         * remote.c (class remote_target): Add new method
3634         thread_info_to_thread_handle.
3635         (remote_target::thread_info_to_thread_handle): Define.
3636
3637 2019-04-08  Pedro Alves  <palves@redhat.com>
3638
3639         * common/common-exceptions.c (throw_exception): Don't create
3640         named object to throw; throw directly.
3641         (throw_it): Likewise.  Don't initialize gdb_exception::message
3642         here, with new; pass FMT and AP to the ctor instead.
3643         * common/common-exceptions.h: Include <string>.
3644         (gdb_exception::gdb_exception(enum return_reason, enum errors,
3645         const char *, va_list)): New ctor.  Use std::make_shared.
3646         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3647         errors)): Delete.
3648         (gdb_exception_error::gdb_exception_error(enum errors, const char
3649         *, va_list)): New.
3650         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
3651         Add assertion.
3652         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
3653         errors)): Delete.
3654         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
3655         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
3656         Add assertion.
3657
3658 2019-04-08  Tom Tromey  <tom@tromey.com>
3659
3660         * valops.c (value_rtti_indirect_type): Replace throw_exception
3661         with throw.
3662         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3663         with throw.
3664         * thread.c (thr_try_catch_cmd): Replace throw_exception with
3665         throw.
3666         * target.c (target_translate_tls_address): Replace throw_exception
3667         with throw.
3668         * stack.c (frame_apply_command_count): Replace throw_exception
3669         with throw.
3670         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3671         throw.
3672         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3673         with throw.
3674         * rs6000-tdep.c (rs6000_frame_cache)
3675         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3676         * remote.c: Replace throw_exception with throw.
3677         * record-full.c (record_full_message, record_full_wait_1)
3678         (record_full_restore): Replace throw_exception with throw.
3679         * record-btrace.c:
3680         (get_thread_current_frame_id, record_btrace_start_replaying)
3681         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3682         (cmd_record_btrace_start): Replace throw_exception with throw.
3683         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3684         throw.
3685         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3686         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3687         * linespec.c:
3688         (find_linespec_symbols): Replace throw_exception with throw.
3689         * infrun.c (displaced_step_prepare, resume): Replace
3690         throw_exception with throw.
3691         * infcmd.c (post_create_inferior): Replace throw_exception with
3692         throw.
3693         * inf-loop.c (inferior_event_handler): Replace throw_exception
3694         with throw.
3695         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3696         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3697         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3698         (get_prev_frame_always, get_frame_pc_if_available)
3699         (get_frame_address_in_block_if_available, get_frame_language):
3700         Replace throw_exception with throw.
3701         * frame-unwind.c (frame_unwind_try_unwinder): Replace
3702         throw_exception with throw.
3703         * eval.c (fetch_subexp_value, evaluate_var_value)
3704         (evaluate_funcall, evaluate_subexp_standard): Replace
3705         throw_exception with throw.
3706         * dwarf2loc.c (call_site_find_chain)
3707         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3708         Replace throw_exception with throw.
3709         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3710         with throw.
3711         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3712         throw.
3713         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3714         * completer.c (complete_line_internal): Replace throw_exception
3715         with throw.
3716         * compile/compile-object-run.c (compile_object_run): Replace
3717         throw_exception with throw.
3718         * cli/cli-script.c (process_next_line): Replace throw_exception
3719         with throw.
3720         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3721         (btrace_enable, btrace_maint_update_pt_packets): Replace
3722         throw_exception with throw.
3723         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3724         throw_exception with throw.
3725         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3726         throw_exception with throw.
3727         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3728         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3729         * aarch64-tdep.c (aarch64_make_prologue_cache)
3730         (aarch64_make_stub_cache): Replace throw_exception with throw.
3731
3732 2019-04-08  Tom Tromey  <tom@tromey.com>
3733
3734         * common/common-exceptions.c (throw_exception): Rename from
3735         throw_exception_cxx.  Remove old copy.  Make argument const.
3736         (throw_it): Create and throw exception objects directly.
3737         * common/common-exceptions.h (throw_exception): Make argument
3738         const.
3739         (struct gdb_exception_error): Add constructor.
3740         (struct gdb_exception_quit): Add constructor.
3741
3742 2019-04-08  Tom Tromey  <tom@tromey.com>
3743
3744         * common/common-exceptions.h (exception_rethrow): Don't declare.
3745         (TRY_SJLJ): Update comment.
3746         (TRY, CATCH, END_CATCH): Remove.
3747         * common/common-exceptions.c (exception_rethrow): Remove.
3748
3749 2019-04-08  Tom Tromey  <tom@tromey.com>
3750
3751         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3752         Remove.
3753         (gdb_exception_error): Rename from
3754         gdb_exception_RETURN_MASK_ERROR.
3755         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3756         (gdb_quit_bad_alloc): Update.
3757         * aarch64-tdep.c: Update.
3758         * ada-lang.c: Update.
3759         * ada-typeprint.c: Update.
3760         * ada-valprint.c: Update.
3761         * amd64-tdep.c: Update.
3762         * arch-utils.c: Update.
3763         * break-catch-throw.c: Update.
3764         * breakpoint.c: Update.
3765         * btrace.c: Update.
3766         * c-varobj.c: Update.
3767         * cli/cli-cmds.c: Update.
3768         * cli/cli-interp.c: Update.
3769         * cli/cli-script.c: Update.
3770         * common/common-exceptions.c: Update.
3771         * common/new-op.c: Update.
3772         * common/selftest.c: Update.
3773         * compile/compile-c-symbols.c: Update.
3774         * compile/compile-cplus-symbols.c: Update.
3775         * compile/compile-object-load.c: Update.
3776         * compile/compile-object-run.c: Update.
3777         * completer.c: Update.
3778         * corelow.c: Update.
3779         * cp-abi.c: Update.
3780         * cp-support.c: Update.
3781         * cp-valprint.c: Update.
3782         * darwin-nat.c: Update.
3783         * disasm-selftests.c: Update.
3784         * dtrace-probe.c: Update.
3785         * dwarf-index-cache.c: Update.
3786         * dwarf-index-write.c: Update.
3787         * dwarf2-frame-tailcall.c: Update.
3788         * dwarf2-frame.c: Update.
3789         * dwarf2loc.c: Update.
3790         * dwarf2read.c: Update.
3791         * eval.c: Update.
3792         * event-loop.c: Update.
3793         * event-top.c: Update.
3794         * exec.c: Update.
3795         * f-valprint.c: Update.
3796         * fbsd-tdep.c: Update.
3797         * frame-unwind.c: Update.
3798         * frame.c: Update.
3799         * gdbtypes.c: Update.
3800         * gnu-v3-abi.c: Update.
3801         * guile/guile-internal.h: Update.
3802         * guile/scm-block.c: Update.
3803         * guile/scm-breakpoint.c: Update.
3804         * guile/scm-cmd.c: Update.
3805         * guile/scm-disasm.c: Update.
3806         * guile/scm-frame.c: Update.
3807         * guile/scm-lazy-string.c: Update.
3808         * guile/scm-math.c: Update.
3809         * guile/scm-param.c: Update.
3810         * guile/scm-ports.c: Update.
3811         * guile/scm-pretty-print.c: Update.
3812         * guile/scm-symbol.c: Update.
3813         * guile/scm-symtab.c: Update.
3814         * guile/scm-type.c: Update.
3815         * guile/scm-value.c: Update.
3816         * i386-linux-tdep.c: Update.
3817         * i386-tdep.c: Update.
3818         * inf-loop.c: Update.
3819         * infcall.c: Update.
3820         * infcmd.c: Update.
3821         * infrun.c: Update.
3822         * jit.c: Update.
3823         * language.c: Update.
3824         * linespec.c: Update.
3825         * linux-fork.c: Update.
3826         * linux-nat.c: Update.
3827         * linux-tdep.c: Update.
3828         * linux-thread-db.c: Update.
3829         * main.c: Update.
3830         * mi/mi-cmd-break.c: Update.
3831         * mi/mi-cmd-stack.c: Update.
3832         * mi/mi-interp.c: Update.
3833         * mi/mi-main.c: Update.
3834         * objc-lang.c: Update.
3835         * p-valprint.c: Update.
3836         * parse.c: Update.
3837         * ppc-linux-tdep.c: Update.
3838         * printcmd.c: Update.
3839         * python/py-arch.c: Update.
3840         * python/py-breakpoint.c: Update.
3841         * python/py-cmd.c: Update.
3842         * python/py-finishbreakpoint.c: Update.
3843         * python/py-frame.c: Update.
3844         * python/py-framefilter.c: Update.
3845         * python/py-gdb-readline.c: Update.
3846         * python/py-inferior.c: Update.
3847         * python/py-infthread.c: Update.
3848         * python/py-lazy-string.c: Update.
3849         * python/py-linetable.c: Update.
3850         * python/py-objfile.c: Update.
3851         * python/py-param.c: Update.
3852         * python/py-prettyprint.c: Update.
3853         * python/py-progspace.c: Update.
3854         * python/py-record-btrace.c: Update.
3855         * python/py-record.c: Update.
3856         * python/py-symbol.c: Update.
3857         * python/py-type.c: Update.
3858         * python/py-unwind.c: Update.
3859         * python/py-utils.c: Update.
3860         * python/py-value.c: Update.
3861         * python/python.c: Update.
3862         * record-btrace.c: Update.
3863         * record-full.c: Update.
3864         * remote-fileio.c: Update.
3865         * remote.c: Update.
3866         * riscv-tdep.c: Update.
3867         * rs6000-aix-tdep.c: Update.
3868         * rs6000-tdep.c: Update.
3869         * rust-exp.y: Update.
3870         * rust-lang.c: Update.
3871         * s390-tdep.c: Update.
3872         * selftest-arch.c: Update.
3873         * solib-dsbt.c: Update.
3874         * solib-frv.c: Update.
3875         * solib-spu.c: Update.
3876         * solib-svr4.c: Update.
3877         * solib.c: Update.
3878         * sparc64-linux-tdep.c: Update.
3879         * stack.c: Update.
3880         * symfile-mem.c: Update.
3881         * symmisc.c: Update.
3882         * target.c: Update.
3883         * thread.c: Update.
3884         * top.c: Update.
3885         * tracefile-tfile.c: Update.
3886         * tui/tui.c: Update.
3887         * typeprint.c: Update.
3888         * unittests/cli-utils-selftests.c: Update.
3889         * unittests/parse-connection-spec-selftests.c: Update.
3890         * valops.c: Update.
3891         * valprint.c: Update.
3892         * value.c: Update.
3893         * varobj.c: Update.
3894         * windows-nat.c: Update.
3895         * x86-linux-nat.c: Update.
3896         * xml-support.c: Update.
3897
3898 2019-04-08  Tom Tromey  <tom@tromey.com>
3899
3900         * xml-support.c: Use C++ exception handling.
3901         * x86-linux-nat.c: Use C++ exception handling.
3902         * windows-nat.c: Use C++ exception handling.
3903         * varobj.c: Use C++ exception handling.
3904         * value.c: Use C++ exception handling.
3905         * valprint.c: Use C++ exception handling.
3906         * valops.c: Use C++ exception handling.
3907         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3908         handling.
3909         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3910         * typeprint.c: Use C++ exception handling.
3911         * tui/tui.c: Use C++ exception handling.
3912         * tracefile-tfile.c: Use C++ exception handling.
3913         * top.c: Use C++ exception handling.
3914         * thread.c: Use C++ exception handling.
3915         * target.c: Use C++ exception handling.
3916         * symmisc.c: Use C++ exception handling.
3917         * symfile-mem.c: Use C++ exception handling.
3918         * stack.c: Use C++ exception handling.
3919         * sparc64-linux-tdep.c: Use C++ exception handling.
3920         * solib.c: Use C++ exception handling.
3921         * solib-svr4.c: Use C++ exception handling.
3922         * solib-spu.c: Use C++ exception handling.
3923         * solib-frv.c: Use C++ exception handling.
3924         * solib-dsbt.c: Use C++ exception handling.
3925         * selftest-arch.c: Use C++ exception handling.
3926         * s390-tdep.c: Use C++ exception handling.
3927         * rust-lang.c: Use C++ exception handling.
3928         * rust-exp.y: Use C++ exception handling.
3929         * rs6000-tdep.c: Use C++ exception handling.
3930         * rs6000-aix-tdep.c: Use C++ exception handling.
3931         * riscv-tdep.c: Use C++ exception handling.
3932         * remote.c: Use C++ exception handling.
3933         * remote-fileio.c: Use C++ exception handling.
3934         * record-full.c: Use C++ exception handling.
3935         * record-btrace.c: Use C++ exception handling.
3936         * python/python.c: Use C++ exception handling.
3937         * python/py-value.c: Use C++ exception handling.
3938         * python/py-utils.c: Use C++ exception handling.
3939         * python/py-unwind.c: Use C++ exception handling.
3940         * python/py-type.c: Use C++ exception handling.
3941         * python/py-symbol.c: Use C++ exception handling.
3942         * python/py-record.c: Use C++ exception handling.
3943         * python/py-record-btrace.c: Use C++ exception handling.
3944         * python/py-progspace.c: Use C++ exception handling.
3945         * python/py-prettyprint.c: Use C++ exception handling.
3946         * python/py-param.c: Use C++ exception handling.
3947         * python/py-objfile.c: Use C++ exception handling.
3948         * python/py-linetable.c: Use C++ exception handling.
3949         * python/py-lazy-string.c: Use C++ exception handling.
3950         * python/py-infthread.c: Use C++ exception handling.
3951         * python/py-inferior.c: Use C++ exception handling.
3952         * python/py-gdb-readline.c: Use C++ exception handling.
3953         * python/py-framefilter.c: Use C++ exception handling.
3954         * python/py-frame.c: Use C++ exception handling.
3955         * python/py-finishbreakpoint.c: Use C++ exception handling.
3956         * python/py-cmd.c: Use C++ exception handling.
3957         * python/py-breakpoint.c: Use C++ exception handling.
3958         * python/py-arch.c: Use C++ exception handling.
3959         * printcmd.c: Use C++ exception handling.
3960         * ppc-linux-tdep.c: Use C++ exception handling.
3961         * parse.c: Use C++ exception handling.
3962         * p-valprint.c: Use C++ exception handling.
3963         * objc-lang.c: Use C++ exception handling.
3964         * mi/mi-main.c: Use C++ exception handling.
3965         * mi/mi-interp.c: Use C++ exception handling.
3966         * mi/mi-cmd-stack.c: Use C++ exception handling.
3967         * mi/mi-cmd-break.c: Use C++ exception handling.
3968         * main.c: Use C++ exception handling.
3969         * linux-thread-db.c: Use C++ exception handling.
3970         * linux-tdep.c: Use C++ exception handling.
3971         * linux-nat.c: Use C++ exception handling.
3972         * linux-fork.c: Use C++ exception handling.
3973         * linespec.c: Use C++ exception handling.
3974         * language.c: Use C++ exception handling.
3975         * jit.c: Use C++ exception handling.
3976         * infrun.c: Use C++ exception handling.
3977         * infcmd.c: Use C++ exception handling.
3978         * infcall.c: Use C++ exception handling.
3979         * inf-loop.c: Use C++ exception handling.
3980         * i386-tdep.c: Use C++ exception handling.
3981         * i386-linux-tdep.c: Use C++ exception handling.
3982         * guile/scm-value.c: Use C++ exception handling.
3983         * guile/scm-type.c: Use C++ exception handling.
3984         * guile/scm-symtab.c: Use C++ exception handling.
3985         * guile/scm-symbol.c: Use C++ exception handling.
3986         * guile/scm-pretty-print.c: Use C++ exception handling.
3987         * guile/scm-ports.c: Use C++ exception handling.
3988         * guile/scm-param.c: Use C++ exception handling.
3989         * guile/scm-math.c: Use C++ exception handling.
3990         * guile/scm-lazy-string.c: Use C++ exception handling.
3991         * guile/scm-frame.c: Use C++ exception handling.
3992         * guile/scm-disasm.c: Use C++ exception handling.
3993         * guile/scm-cmd.c: Use C++ exception handling.
3994         * guile/scm-breakpoint.c: Use C++ exception handling.
3995         * guile/scm-block.c: Use C++ exception handling.
3996         * guile/guile-internal.h: Use C++ exception handling.
3997         * gnu-v3-abi.c: Use C++ exception handling.
3998         * gdbtypes.c: Use C++ exception handling.
3999         * frame.c: Use C++ exception handling.
4000         * frame-unwind.c: Use C++ exception handling.
4001         * fbsd-tdep.c: Use C++ exception handling.
4002         * f-valprint.c: Use C++ exception handling.
4003         * exec.c: Use C++ exception handling.
4004         * event-top.c: Use C++ exception handling.
4005         * event-loop.c: Use C++ exception handling.
4006         * eval.c: Use C++ exception handling.
4007         * dwarf2read.c: Use C++ exception handling.
4008         * dwarf2loc.c: Use C++ exception handling.
4009         * dwarf2-frame.c: Use C++ exception handling.
4010         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4011         * dwarf-index-write.c: Use C++ exception handling.
4012         * dwarf-index-cache.c: Use C++ exception handling.
4013         * dtrace-probe.c: Use C++ exception handling.
4014         * disasm-selftests.c: Use C++ exception handling.
4015         * darwin-nat.c: Use C++ exception handling.
4016         * cp-valprint.c: Use C++ exception handling.
4017         * cp-support.c: Use C++ exception handling.
4018         * cp-abi.c: Use C++ exception handling.
4019         * corelow.c: Use C++ exception handling.
4020         * completer.c: Use C++ exception handling.
4021         * compile/compile-object-run.c: Use C++ exception handling.
4022         * compile/compile-object-load.c: Use C++ exception handling.
4023         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4024         * compile/compile-c-symbols.c: Use C++ exception handling.
4025         * common/selftest.c: Use C++ exception handling.
4026         * common/new-op.c: Use C++ exception handling.
4027         * cli/cli-script.c: Use C++ exception handling.
4028         * cli/cli-interp.c: Use C++ exception handling.
4029         * cli/cli-cmds.c: Use C++ exception handling.
4030         * c-varobj.c: Use C++ exception handling.
4031         * btrace.c: Use C++ exception handling.
4032         * breakpoint.c: Use C++ exception handling.
4033         * break-catch-throw.c: Use C++ exception handling.
4034         * arch-utils.c: Use C++ exception handling.
4035         * amd64-tdep.c: Use C++ exception handling.
4036         * ada-valprint.c: Use C++ exception handling.
4037         * ada-typeprint.c: Use C++ exception handling.
4038         * ada-lang.c: Use C++ exception handling.
4039         * aarch64-tdep.c: Use C++ exception handling.
4040
4041 2019-04-08  Tom Tromey  <tom@tromey.com>
4042
4043         * xml-support.c (gdb_xml_parser::parse): Update.
4044         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4045         * value.c (show_convenience): Update.
4046         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4047         (test_parse_flags_qcs): Update.
4048         * thread.c (thr_try_catch_cmd): Update.
4049         * target.c (target_translate_tls_address): Update.
4050         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4051         (info_frame_command_core, frame_apply_command_count): Update.
4052         * rust-exp.y (rust_lex_exception_test): Update.
4053         * riscv-tdep.c (riscv_print_one_register_info): Update.
4054         * remote.c (remote_target::enable_btrace): Update.
4055         * record-btrace.c (record_btrace_enable_warn): Update.
4056         * python/py-utils.c (gdbpy_convert_exception): Update.
4057         * printcmd.c (do_one_display, print_variable_and_value): Update.
4058         * mi/mi-main.c (mi_print_exception): Update.
4059         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4060         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4061         * linux-nat.c (linux_nat_target::attach): Update.
4062         * linux-fork.c (class scoped_switch_fork_info): Update.
4063         * infrun.c (displaced_step_prepare): Update.
4064         * infcall.c (call_function_by_hand_dummy): Update.
4065         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4066         * gnu-v3-abi.c (print_one_vtable): Update.
4067         * frame.c (get_prev_frame_always): Update.
4068         * f-valprint.c (info_common_command_for_block): Update.
4069         * exec.c (try_open_exec_file): Update.
4070         * exceptions.c (print_exception, exception_print)
4071         (exception_fprintf, exception_print_same): Update.
4072         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4073         * dwarf-index-cache.c (index_cache::store)
4074         (index_cache::lookup_gdb_index): Update.
4075         * darwin-nat.c (maybe_cache_shell): Update.
4076         * cp-valprint.c (cp_print_value_fields): Update.
4077         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4078         (gcc_cplus_symbol_address): Update.
4079         * compile/compile-c-symbols.c (gcc_convert_symbol)
4080         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4081         * common/selftest.c: Update.
4082         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4083         a std::string.
4084         (exception_try_scope_entry, exception_try_scope_exit): Don't
4085         declare.
4086         (struct exception_try_scope): Remove.
4087         (TRY): Don't use exception_try_scope.
4088         (struct gdb_exception): Add constructor, operator=.
4089         <what>: New method.
4090         (struct gdb_exception_RETURN_MASK_ALL)
4091         (struct gdb_exception_RETURN_MASK_ERROR)
4092         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4093         (struct gdb_quit_bad_alloc): Update.
4094         * common/common-exceptions.c (exception_none): Change
4095         initializer.
4096         (struct catcher) <state, exception>: Initialize inline.
4097         <prev>: Remove member.
4098         (current_catcher): Remove.
4099         (catchers): New global.
4100         (exceptions_state_mc_init): Simplify.
4101         (catcher_pop): Remove.
4102         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4103         (try_scope_depth, exception_try_scope_entry)
4104         (exception_try_scope_exit): Remove.
4105         (throw_exception_sjlj): Update.
4106         (exception_messages, exception_messages_size): Remove.
4107         (throw_it): Simplify.
4108         (gdb_exception_sliced_copy): Remove.
4109         (throw_exception_cxx): Update.
4110         * cli/cli-script.c (script_from_file): Update.
4111         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4112         Update.
4113         * ada-valprint.c (ada_val_print): Update.
4114         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4115         (create_excep_cond_exprs): Update.
4116
4117 2019-04-08  Tom Tromey  <tom@tromey.com>
4118
4119         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4120         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4121         (TRY, CATCH, END_CATCH): Remove some definitions.
4122         * common/common-exceptions.c: Don't use GDB_XCPT.
4123         (catcher_list_size): Remove.
4124         (throw_exception, throw_it): Simplify.
4125
4126 2019-04-05  Tom Tromey  <tom@tromey.com>
4127
4128         Revert the header-sorting patch.
4129         * ft32-tdep.c: Revert.
4130         * frv-tdep.c: Revert.
4131         * frv-linux-tdep.c: Revert.
4132         * frame.c: Revert.
4133         * frame-unwind.c: Revert.
4134         * frame-base.c: Revert.
4135         * fork-child.c: Revert.
4136         * findvar.c: Revert.
4137         * findcmd.c: Revert.
4138         * filesystem.c: Revert.
4139         * filename-seen-cache.h: Revert.
4140         * filename-seen-cache.c: Revert.
4141         * fbsd-tdep.c: Revert.
4142         * fbsd-nat.h: Revert.
4143         * fbsd-nat.c: Revert.
4144         * f-valprint.c: Revert.
4145         * f-typeprint.c: Revert.
4146         * f-lang.c: Revert.
4147         * extension.h: Revert.
4148         * extension.c: Revert.
4149         * extension-priv.h: Revert.
4150         * expprint.c: Revert.
4151         * exec.h: Revert.
4152         * exec.c: Revert.
4153         * exceptions.c: Revert.
4154         * event-top.c: Revert.
4155         * event-loop.c: Revert.
4156         * eval.c: Revert.
4157         * elfread.c: Revert.
4158         * dwarf2read.h: Revert.
4159         * dwarf2read.c: Revert.
4160         * dwarf2loc.c: Revert.
4161         * dwarf2expr.h: Revert.
4162         * dwarf2expr.c: Revert.
4163         * dwarf2-frame.c: Revert.
4164         * dwarf2-frame-tailcall.c: Revert.
4165         * dwarf-index-write.h: Revert.
4166         * dwarf-index-write.c: Revert.
4167         * dwarf-index-common.c: Revert.
4168         * dwarf-index-cache.h: Revert.
4169         * dwarf-index-cache.c: Revert.
4170         * dummy-frame.c: Revert.
4171         * dtrace-probe.c: Revert.
4172         * disasm.h: Revert.
4173         * disasm.c: Revert.
4174         * disasm-selftests.c: Revert.
4175         * dictionary.c: Revert.
4176         * dicos-tdep.c: Revert.
4177         * demangle.c: Revert.
4178         * dcache.h: Revert.
4179         * dcache.c: Revert.
4180         * darwin-nat.h: Revert.
4181         * darwin-nat.c: Revert.
4182         * darwin-nat-info.c: Revert.
4183         * d-valprint.c: Revert.
4184         * d-namespace.c: Revert.
4185         * d-lang.c: Revert.
4186         * ctf.c: Revert.
4187         * csky-tdep.c: Revert.
4188         * csky-linux-tdep.c: Revert.
4189         * cris-tdep.c: Revert.
4190         * cris-linux-tdep.c: Revert.
4191         * cp-valprint.c: Revert.
4192         * cp-support.c: Revert.
4193         * cp-namespace.c: Revert.
4194         * cp-abi.c: Revert.
4195         * corelow.c: Revert.
4196         * corefile.c: Revert.
4197         * continuations.c: Revert.
4198         * completer.h: Revert.
4199         * completer.c: Revert.
4200         * complaints.c: Revert.
4201         * coffread.c: Revert.
4202         * coff-pe-read.c: Revert.
4203         * cli-out.h: Revert.
4204         * cli-out.c: Revert.
4205         * charset.c: Revert.
4206         * c-varobj.c: Revert.
4207         * c-valprint.c: Revert.
4208         * c-typeprint.c: Revert.
4209         * c-lang.c: Revert.
4210         * buildsym.c: Revert.
4211         * buildsym-legacy.c: Revert.
4212         * build-id.h: Revert.
4213         * build-id.c: Revert.
4214         * btrace.c: Revert.
4215         * bsd-uthread.c: Revert.
4216         * breakpoint.h: Revert.
4217         * breakpoint.c: Revert.
4218         * break-catch-throw.c: Revert.
4219         * break-catch-syscall.c: Revert.
4220         * break-catch-sig.c: Revert.
4221         * blockframe.c: Revert.
4222         * block.c: Revert.
4223         * bfin-tdep.c: Revert.
4224         * bfin-linux-tdep.c: Revert.
4225         * bfd-target.c: Revert.
4226         * bcache.c: Revert.
4227         * ax-general.c: Revert.
4228         * ax-gdb.h: Revert.
4229         * ax-gdb.c: Revert.
4230         * avr-tdep.c: Revert.
4231         * auxv.c: Revert.
4232         * auto-load.c: Revert.
4233         * arm-wince-tdep.c: Revert.
4234         * arm-tdep.c: Revert.
4235         * arm-symbian-tdep.c: Revert.
4236         * arm-pikeos-tdep.c: Revert.
4237         * arm-obsd-tdep.c: Revert.
4238         * arm-nbsd-tdep.c: Revert.
4239         * arm-nbsd-nat.c: Revert.
4240         * arm-linux-tdep.c: Revert.
4241         * arm-linux-nat.c: Revert.
4242         * arm-fbsd-tdep.c: Revert.
4243         * arm-fbsd-nat.c: Revert.
4244         * arm-bsd-tdep.c: Revert.
4245         * arch-utils.c: Revert.
4246         * arc-tdep.c: Revert.
4247         * arc-newlib-tdep.c: Revert.
4248         * annotate.h: Revert.
4249         * annotate.c: Revert.
4250         * amd64-windows-tdep.c: Revert.
4251         * amd64-windows-nat.c: Revert.
4252         * amd64-tdep.c: Revert.
4253         * amd64-sol2-tdep.c: Revert.
4254         * amd64-obsd-tdep.c: Revert.
4255         * amd64-obsd-nat.c: Revert.
4256         * amd64-nbsd-tdep.c: Revert.
4257         * amd64-nbsd-nat.c: Revert.
4258         * amd64-nat.c: Revert.
4259         * amd64-linux-tdep.c: Revert.
4260         * amd64-linux-nat.c: Revert.
4261         * amd64-fbsd-tdep.c: Revert.
4262         * amd64-fbsd-nat.c: Revert.
4263         * amd64-dicos-tdep.c: Revert.
4264         * amd64-darwin-tdep.c: Revert.
4265         * amd64-bsd-nat.c: Revert.
4266         * alpha-tdep.c: Revert.
4267         * alpha-obsd-tdep.c: Revert.
4268         * alpha-nbsd-tdep.c: Revert.
4269         * alpha-mdebug-tdep.c: Revert.
4270         * alpha-linux-tdep.c: Revert.
4271         * alpha-linux-nat.c: Revert.
4272         * alpha-bsd-tdep.c: Revert.
4273         * alpha-bsd-nat.c: Revert.
4274         * aix-thread.c: Revert.
4275         * agent.c: Revert.
4276         * addrmap.c: Revert.
4277         * ada-varobj.c: Revert.
4278         * ada-valprint.c: Revert.
4279         * ada-typeprint.c: Revert.
4280         * ada-tasks.c: Revert.
4281         * ada-lang.c: Revert.
4282         * aarch64-tdep.c: Revert.
4283         * aarch64-ravenscar-thread.c: Revert.
4284         * aarch64-newlib-tdep.c: Revert.
4285         * aarch64-linux-tdep.c: Revert.
4286         * aarch64-linux-nat.c: Revert.
4287         * aarch64-fbsd-tdep.c: Revert.
4288         * aarch64-fbsd-nat.c: Revert.
4289         * aarch32-linux-nat.c: Revert.
4290
4291 2019-04-05  Tom Tromey  <tom@tromey.com>
4292
4293         * ft32-tdep.c: Sort headers.
4294         * frv-tdep.c: Sort headers.
4295         * frv-linux-tdep.c: Sort headers.
4296         * frame.c: Sort headers.
4297         * frame-unwind.c: Sort headers.
4298         * frame-base.c: Sort headers.
4299         * fork-child.c: Sort headers.
4300         * findvar.c: Sort headers.
4301         * findcmd.c: Sort headers.
4302         * filesystem.c: Sort headers.
4303         * filename-seen-cache.h: Sort headers.
4304         * filename-seen-cache.c: Sort headers.
4305         * fbsd-tdep.c: Sort headers.
4306         * fbsd-nat.h: Sort headers.
4307         * fbsd-nat.c: Sort headers.
4308         * f-valprint.c: Sort headers.
4309         * f-typeprint.c: Sort headers.
4310         * f-lang.c: Sort headers.
4311         * extension.h: Sort headers.
4312         * extension.c: Sort headers.
4313         * extension-priv.h: Sort headers.
4314         * expprint.c: Sort headers.
4315         * exec.h: Sort headers.
4316         * exec.c: Sort headers.
4317         * exceptions.c: Sort headers.
4318         * event-top.c: Sort headers.
4319         * event-loop.c: Sort headers.
4320         * eval.c: Sort headers.
4321         * elfread.c: Sort headers.
4322         * dwarf2read.h: Sort headers.
4323         * dwarf2read.c: Sort headers.
4324         * dwarf2loc.c: Sort headers.
4325         * dwarf2expr.h: Sort headers.
4326         * dwarf2expr.c: Sort headers.
4327         * dwarf2-frame.c: Sort headers.
4328         * dwarf2-frame-tailcall.c: Sort headers.
4329         * dwarf-index-write.h: Sort headers.
4330         * dwarf-index-write.c: Sort headers.
4331         * dwarf-index-common.c: Sort headers.
4332         * dwarf-index-cache.h: Sort headers.
4333         * dwarf-index-cache.c: Sort headers.
4334         * dummy-frame.c: Sort headers.
4335         * dtrace-probe.c: Sort headers.
4336         * disasm.h: Sort headers.
4337         * disasm.c: Sort headers.
4338         * disasm-selftests.c: Sort headers.
4339         * dictionary.c: Sort headers.
4340         * dicos-tdep.c: Sort headers.
4341         * demangle.c: Sort headers.
4342         * dcache.h: Sort headers.
4343         * dcache.c: Sort headers.
4344         * darwin-nat.h: Sort headers.
4345         * darwin-nat.c: Sort headers.
4346         * darwin-nat-info.c: Sort headers.
4347         * d-valprint.c: Sort headers.
4348         * d-namespace.c: Sort headers.
4349         * d-lang.c: Sort headers.
4350         * ctf.c: Sort headers.
4351         * csky-tdep.c: Sort headers.
4352         * csky-linux-tdep.c: Sort headers.
4353         * cris-tdep.c: Sort headers.
4354         * cris-linux-tdep.c: Sort headers.
4355         * cp-valprint.c: Sort headers.
4356         * cp-support.c: Sort headers.
4357         * cp-namespace.c: Sort headers.
4358         * cp-abi.c: Sort headers.
4359         * corelow.c: Sort headers.
4360         * corefile.c: Sort headers.
4361         * continuations.c: Sort headers.
4362         * completer.h: Sort headers.
4363         * completer.c: Sort headers.
4364         * complaints.c: Sort headers.
4365         * coffread.c: Sort headers.
4366         * coff-pe-read.c: Sort headers.
4367         * cli-out.h: Sort headers.
4368         * cli-out.c: Sort headers.
4369         * charset.c: Sort headers.
4370         * c-varobj.c: Sort headers.
4371         * c-valprint.c: Sort headers.
4372         * c-typeprint.c: Sort headers.
4373         * c-lang.c: Sort headers.
4374         * buildsym.c: Sort headers.
4375         * buildsym-legacy.c: Sort headers.
4376         * build-id.h: Sort headers.
4377         * build-id.c: Sort headers.
4378         * btrace.c: Sort headers.
4379         * bsd-uthread.c: Sort headers.
4380         * breakpoint.h: Sort headers.
4381         * breakpoint.c: Sort headers.
4382         * break-catch-throw.c: Sort headers.
4383         * break-catch-syscall.c: Sort headers.
4384         * break-catch-sig.c: Sort headers.
4385         * blockframe.c: Sort headers.
4386         * block.c: Sort headers.
4387         * bfin-tdep.c: Sort headers.
4388         * bfin-linux-tdep.c: Sort headers.
4389         * bfd-target.c: Sort headers.
4390         * bcache.c: Sort headers.
4391         * ax-general.c: Sort headers.
4392         * ax-gdb.h: Sort headers.
4393         * ax-gdb.c: Sort headers.
4394         * avr-tdep.c: Sort headers.
4395         * auxv.c: Sort headers.
4396         * auto-load.c: Sort headers.
4397         * arm-wince-tdep.c: Sort headers.
4398         * arm-tdep.c: Sort headers.
4399         * arm-symbian-tdep.c: Sort headers.
4400         * arm-pikeos-tdep.c: Sort headers.
4401         * arm-obsd-tdep.c: Sort headers.
4402         * arm-nbsd-tdep.c: Sort headers.
4403         * arm-nbsd-nat.c: Sort headers.
4404         * arm-linux-tdep.c: Sort headers.
4405         * arm-linux-nat.c: Sort headers.
4406         * arm-fbsd-tdep.c: Sort headers.
4407         * arm-fbsd-nat.c: Sort headers.
4408         * arm-bsd-tdep.c: Sort headers.
4409         * arch-utils.c: Sort headers.
4410         * arc-tdep.c: Sort headers.
4411         * arc-newlib-tdep.c: Sort headers.
4412         * annotate.h: Sort headers.
4413         * annotate.c: Sort headers.
4414         * amd64-windows-tdep.c: Sort headers.
4415         * amd64-windows-nat.c: Sort headers.
4416         * amd64-tdep.c: Sort headers.
4417         * amd64-sol2-tdep.c: Sort headers.
4418         * amd64-obsd-tdep.c: Sort headers.
4419         * amd64-obsd-nat.c: Sort headers.
4420         * amd64-nbsd-tdep.c: Sort headers.
4421         * amd64-nbsd-nat.c: Sort headers.
4422         * amd64-nat.c: Sort headers.
4423         * amd64-linux-tdep.c: Sort headers.
4424         * amd64-linux-nat.c: Sort headers.
4425         * amd64-fbsd-tdep.c: Sort headers.
4426         * amd64-fbsd-nat.c: Sort headers.
4427         * amd64-dicos-tdep.c: Sort headers.
4428         * amd64-darwin-tdep.c: Sort headers.
4429         * amd64-bsd-nat.c: Sort headers.
4430         * alpha-tdep.c: Sort headers.
4431         * alpha-obsd-tdep.c: Sort headers.
4432         * alpha-nbsd-tdep.c: Sort headers.
4433         * alpha-mdebug-tdep.c: Sort headers.
4434         * alpha-linux-tdep.c: Sort headers.
4435         * alpha-linux-nat.c: Sort headers.
4436         * alpha-bsd-tdep.c: Sort headers.
4437         * alpha-bsd-nat.c: Sort headers.
4438         * aix-thread.c: Sort headers.
4439         * agent.c: Sort headers.
4440         * addrmap.c: Sort headers.
4441         * ada-varobj.c: Sort headers.
4442         * ada-valprint.c: Sort headers.
4443         * ada-typeprint.c: Sort headers.
4444         * ada-tasks.c: Sort headers.
4445         * ada-lang.c: Sort headers.
4446         * aarch64-tdep.c: Sort headers.
4447         * aarch64-ravenscar-thread.c: Sort headers.
4448         * aarch64-newlib-tdep.c: Sort headers.
4449         * aarch64-linux-tdep.c: Sort headers.
4450         * aarch64-linux-nat.c: Sort headers.
4451         * aarch64-fbsd-tdep.c: Sort headers.
4452         * aarch64-fbsd-nat.c: Sort headers.
4453         * aarch32-linux-nat.c: Sort headers.
4454
4455 2019-04-04  Tom Tromey  <tom@tromey.com>
4456
4457         * varobj.c (varobj_create): Update.
4458         * rust-exp.y (struct rust_parser) <update_innermost_block,
4459         lookup_symbol>: New methods.
4460         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
4461         Rename.
4462         (rust_parser::rust_lookup_type)
4463         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4464         * printcmd.c (display_command, do_one_display): Update.
4465         * parser-defs.h (struct parser_state) <parser_state>: Add
4466         "tracker" parameter.
4467         (block_tracker): New member.
4468         (class innermost_block_tracker) <innermost_block_tracker>: Add
4469         "types" parameter.
4470         <reset>: Remove method.
4471         (innermost_block): Don't declare.
4472         (null_post_parser): Update.
4473         * parse.c (innermost_block): Remove global.
4474         (write_dollar_variable): Update.
4475         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
4476         Remove "tracker_types" parameter.
4477         (parse_expression): Add "tracker" parameter.
4478         (parse_expression_for_completion): Update.
4479         (null_post_parser): Add "tracker" parameter.
4480         * p-exp.y: Update rules.
4481         * m2-exp.y: Update rules.
4482         * language.h (struct language_defn) <la_post_parser>: Add
4483         "tracker" parameter.
4484         * go-exp.y: Update rules.
4485         * f-exp.y: Update rules.
4486         * expression.h (parse_expression, parse_exp_1): Add "tracker"
4487         parameter.
4488         * d-exp.y: Update rules.
4489         * c-exp.y: Update rules.
4490         * breakpoint.c (set_breakpoint_condition): Create an
4491         innermost_block_tracker.
4492         (watch_command_1): Likewise.
4493         * ada-lang.c (resolve): Add "tracker" parameter.
4494         (resolve_subexp): Likewise.
4495         * ada-exp.y (write_var_from_sym): Update.
4496
4497 2019-04-04  Tom Tromey  <tom@tromey.com>
4498
4499         * type-stack.h: New file.
4500         * type-stack.c: New file.
4501         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
4502         type-stack.h.
4503         (insert_into_type_stack, insert_type, push_type, push_type_int)
4504         (insert_type_address_space, pop_type, pop_type_int)
4505         (pop_typelist, pop_type_stack, append_type_stack)
4506         (push_type_stack, get_type_stack, push_typelist)
4507         (follow_type_instance_flags, follow_types): Don't declare.
4508         * parse.c (type_stack): Remove global.
4509         (parse_exp_in_context): Update.
4510         (insert_into_type_stack, insert_type, push_type, push_type_int)
4511         (insert_type_address_space, pop_type, pop_type_int)
4512         (pop_typelist, pop_type_stack, append_type_stack)
4513         (push_type_stack, get_type_stack, push_typelist)
4514         (follow_type_instance_flags, follow_types): Remove (moved to
4515         type-stack.c).
4516         * f-exp.y (type_stack): New global.
4517         Update rules.
4518         (push_kind_type, f_parse): Update.
4519         * d-exp.y (type_stack): New global.
4520         Update rules.
4521         (d_parse): Update.
4522         * c-exp.y (struct c_parse_state) <type_stack>: New member.
4523         Update rules.
4524         * Makefile.in (COMMON_SFILES): Add type-stack.c.
4525         (HFILES_NO_SRCDIR): Add type-stack.h.
4526
4527 2019-04-04  Tom Tromey  <tom@tromey.com>
4528
4529         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
4530         (rust_parser::convert_ast_to_expression, rust_parse)
4531         (rust_lex_test_completion, rust_lex_tests): Update.
4532         * parser-defs.h (struct expr_completion_state): New.
4533         (struct parser_state) <parser_state>: Add completion parameter.
4534         <mark_struct_expression, mark_completion_tag>: New methods.
4535         <parse_completion, m_completion_state>: New members.
4536         (prefixify_expression, null_post_parser): Update.
4537         (mark_struct_expression, mark_completion_tag): Don't declare.
4538         * parse.c (parse_completion, expout_last_struct)
4539         (expout_tag_completion_type, expout_completion_name): Remove
4540         globals.
4541         (parser_state::mark_struct_expression)
4542         (parser_state::mark_completion_tag): Now methods.
4543         (prefixify_expression): Add last_struct parameter.
4544         (prefixify_subexp): Likewise.
4545         (parse_exp_1): Update.
4546         (parse_exp_in_context): Add cstate parameter.  Update.
4547         (parse_expression_for_completion): Create an
4548         expr_completion_state.
4549         (null_post_parser): Add "completion" parameter.
4550         * p-exp.y: Update rules.
4551         (yylex): Update.
4552         * language.h (struct language_defn) <la_post_parser>: Add
4553         "completing" parameter.
4554         * go-exp.y: Update rules.
4555         (lex_one_token): Update.
4556         * expression.h (parse_completion): Don't declare.
4557         * d-exp.y: Update rules.
4558         (lex_one_token): Update rules.
4559         * c-exp.y: Update rules.
4560         (lex_one_token): Update.
4561         * ada-lang.c (resolve): Add "parse_completion" parameter.
4562         (resolve_subexp): Likewise.
4563         (ada_resolve_function): Likewise.
4564
4565 2019-04-04  Tom Tromey  <tom@tromey.com>
4566
4567         * parser-defs.h (struct parser_state) <start_arglist,
4568         end_arglist>: New methods.
4569         <arglist_len, m_funcall_chain>: New members.
4570         (arglist_len, start_arglist, end_arglist): Don't declare.
4571         * parse.c (arglist_len, funcall_chain): Remove global.
4572         (start_arglist, end_arglist): Remove functions.
4573         (parse_exp_in_context): Update.
4574         * p-exp.y: Update rules.
4575         * m2-exp.y: Update rules.
4576         * go-exp.y: Update rules.
4577         * f-exp.y: Update rules.
4578         * d-exp.y: Update rules.
4579         * c-exp.y: Update rules.
4580
4581 2019-04-04  Tom Tromey  <tom@tromey.com>
4582
4583         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4584         lex_operator, push_back>: New methods.
4585         Update all rules.
4586         (rust_parser::lex_hex, lex_escape): Rename and update.
4587         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4588         (rust_parser::lex_operator): Rename and update.
4589         (rust_parser::lex_number, rustyylex, rustyyerror)
4590         (rust_lex_test_init, rust_lex_test_sequence)
4591         (rust_lex_test_push_back, rust_lex_tests): Update.
4592         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4593         parameter.
4594         <lexptr, prev_lexptr>: New members.
4595         (lexptr, prev_lexptr): Don't declare.
4596         * parse.c (lexptr, prev_lexptr): Remove globals.
4597         (parse_exp_in_context): Update.
4598         * p-exp.y (yylex, yyerror): Update.
4599         * m2-exp.y (parse_number, yylex, yyerror): Update.
4600         * go-exp.y (lex_one_token, yyerror): Update.
4601         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4602         * d-exp.y (lex_one_token, yyerror): Update.
4603         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4604         (lex_one_token, yyerror): Update.
4605         * ada-lex.l (YY_INPUT): Update.
4606         (rewind_to_char): Update.
4607         * ada-exp.y (yyerror): Update.
4608
4609 2019-04-04  Tom Tromey  <tom@tromey.com>
4610
4611         * rust-exp.y (rustyylex, rust_lex_tests): Update.
4612         * parser-defs.h (struct parser_state) <parser_state>: Add new
4613         parameter.
4614         <comma_terminates>: New member.
4615         (comma_terminates): Don't declare global.
4616         * parse.c (comma_terminates): Remove global.
4617         (parse_exp_in_context): Update.
4618         * p-exp.y (yylex): Update.
4619         * m2-exp.y (yylex): Update.
4620         * go-exp.y (lex_one_token): Update.
4621         * f-exp.y (yylex): Update.
4622         * d-exp.y (lex_one_token): Update.
4623         * c-exp.y (lex_one_token): Update.
4624         * ada-lex.l: Update.
4625
4626 2019-04-04  Tom Tromey  <tom@tromey.com>
4627
4628         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4629         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4630         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4631         * parser-defs.h (paren_depth): Don't declare.
4632         * parse.c (paren_depth): Remove global.
4633         (parse_exp_in_context): Update.
4634         * p-exp.y (paren_depth): New global.
4635         (pascal_parse): Initialize it.
4636         * m2-exp.y (paren_depth): New global.
4637         (m2_parse): Initialize it.
4638         * go-exp.y (paren_depth): New global.
4639         (go_parse): Initialize it.
4640         * f-exp.y (paren_depth): New global.
4641         (f_parse): Initialize it.
4642         * d-exp.y (paren_depth): New global.
4643         (d_parse): Initialize it.
4644         * c-exp.y (paren_depth): New global.
4645         (c_parse): Initialize it.
4646         * ada-lex.l (paren_depth): New global.
4647         (lexer_init): Initialize it.
4648
4649 2019-04-04  Tom Tromey  <tom@tromey.com>
4650
4651         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
4652         (rust_parser::convert_ast_to_type)
4653         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4654         * parser-defs.h (struct parser_state) <parser_state>: Add
4655         parameters.  Initialize new members.
4656         <expression_context_block, expression_context_pc>: New members.
4657         * parse.c (expression_context_block, expression_context_pc):
4658         Remove globals.
4659         (parse_exp_in_context): Update.
4660         * p-exp.y: Update all rules.
4661         (yylex): Update.
4662         * m2-exp.y: Update all rules.
4663         (yylex): Update.
4664         * go-exp.y (yylex): Update.
4665         * f-exp.y (yylex): Update.
4666         * d-exp.y: Update all rules.
4667         (yylex): Update.
4668         * c-exp.y: Update all rules.
4669         (lex_one_token, classify_name, yylex, c_parse): Update.
4670         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4671
4672 2019-04-04  Tom Tromey  <tom@tromey.com>
4673
4674         * gdbarch.h, gdbarch.c: Rebuild.
4675         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4676         * stap-probe.h:
4677         (struct stap_parse_info): Replace "parser_state" with
4678         "expr_builder".
4679         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4680         (parser_state): New class.
4681         * parse.c (expr_builder): Rename.
4682         (expr_builder::release): Rename.
4683         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4684         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4685         (write_exp_elt_longcst, write_exp_elt_floatcst)
4686         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4687         (write_exp_string_vector, write_exp_bitstring)
4688         (write_exp_msymbol, mark_struct_expression)
4689         (write_dollar_variable)
4690         (insert_type_address_space, increase_expout_size): Replace
4691         "parser_state" with "expr_builder".
4692         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4693         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4694         "parser_state" with "expr_builder".
4695
4696 2019-04-04  Tom Tromey  <tom@tromey.com>
4697
4698         * rust-exp.y: Replace "parse_language" with method call.
4699         * p-exp.y:
4700         (yylex): Replace "parse_language" with method call.
4701         * m2-exp.y:
4702         (yylex): Replace "parse_language" with method call.
4703         * go-exp.y (classify_name): Replace "parse_language" with method
4704         call.
4705         * f-exp.y (yylex): Replace "parse_language" with method call.
4706         * d-exp.y (lex_one_token): Replace "parse_language" with method
4707         call.
4708         * c-exp.y:
4709         (lex_one_token, classify_name, yylex): Replace "parse_language"
4710         with method call.
4711         * ada-exp.y (find_primitive_type, type_char)
4712         (type_system_address): Replace "parse_language" with method call.
4713
4714 2019-04-04  Tom Tromey  <tom@tromey.com>
4715
4716         * rust-exp.y: Replace "parse_gdbarch" with method call.
4717         * parse.c (write_dollar_variable, insert_type_address_space):
4718         Replace "parse_gdbarch" with method call.
4719         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4720         call.
4721         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4722         call.
4723         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4724         "parse_gdbarch" with method call.
4725         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4726         with method call.
4727         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4728         "parse_gdbarch" with method call.
4729         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4730         "parse_gdbarch" with method call.
4731         * c-exp.y (parse_type, parse_number, classify_name): Replace
4732         "parse_gdbarch" with method call.
4733         * ada-lex.l: Replace "parse_gdbarch" with method call.
4734         * ada-exp.y (parse_type, find_primitive_type, type_char)
4735         (type_system_address): Replace "parse_gdbarch" with method call.
4736
4737 2019-04-04  Tom Tromey  <tom@tromey.com>
4738
4739         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4740         * stap-probe.c (stap_parse_argument): Update.
4741         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4742         initial_size parameter.
4743         * rust-exp.y (rust_lex_tests): Update.
4744         * parse.c (parser_state): Update.
4745         (parse_exp_in_context): Update.
4746         * parser-defs.h (struct parser_state) <parser_state>: Remove
4747         "initial_size" parameter.
4748
4749 2019-04-04  Tom Tromey  <tom@tromey.com>
4750
4751         * parser-defs.h (increase_expout_size): Don't declare.
4752         * parse.c (increase_expout_size): Now static.
4753
4754 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
4755
4756         * gnu-nat.c (gnu_nat_target::wait): Fix
4757         target_waitstatus_to_string call.
4758
4759 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4760
4761         * eval.c (evaluate_subexp_standard): Handle internal functions
4762         during Fortran function call handling.
4763
4764 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4765
4766         * NEWS: Mention new internal functions.
4767         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4768         (read_base_type): Use dwarf2_init_complex_target_type.
4769         * value.c (creal_internal_fn): New function.
4770         (cimag_internal_fn): New function.
4771         (_initialize_values): Register new internal functions.
4772
4773 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4774
4775         * infrun.c (stop_all_threads): If debug_infrun, always
4776         trace the wait status after wait_one, using
4777         target_waitstatus_to_string and target_pid_to_str.
4778         (handle_inferior_event): Replace various trace of
4779         wait status kind by a single trace.
4780         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4781         wait status kind image by target_waitstatus_to_string.
4782         * target/waitstatus.c (target_waitstatus_to_string): Fix
4783         obsolete comment.
4784
4785 2019-04-01  Tom Tromey  <tromey@adacore.com>
4786
4787         PR symtab/23331:
4788         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4789
4790 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4791             Pedro Alves  <palves@redhat.com>
4792
4793         * top.c (quit_force): Call 'finalize_values'.
4794         * value.c (finalize_values): New function.
4795         * value.h (finalize_values): Declare.
4796
4797 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4798
4799         * NEWS: Announce $_gdb_major and $_gdb_minor.
4800
4801         * top.c (init_gdb_version_vars): New function.
4802         (gdb_init): Call init_gdb_version_vars.
4803
4804 2019-03-29  Tom Tromey  <tromey@adacore.com>
4805
4806         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4807         help text.  Remove dead code.
4808
4809 2019-03-29  Keith Seitz  <keiths@redhat.com>
4810
4811         From Siddhesh Poyarekar:
4812         * f-lang.h (f77_get_upperbound): Return LONGEST.
4813         (f77_get_lowerbound): Likewise.
4814         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4815         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4816         print them.
4817         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4818         plongest to format print it.
4819         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4820         (f77_get_upperbound): Likewise.
4821         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4822         LOWER_BOUND to LONGEST.
4823         (f77_create_arrayprint_offset_tbl): Likewise.
4824
4825 2019-03-29  Keith Seitz  <keiths@redhat.com>
4826
4827         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4828         %s/pulongest for TYPE_LENGTH instead of %d in format
4829         strings.
4830         * ada-typerint.c (ada_print_type): Likewise.
4831         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4832         * compile/compile-c-support.c (generate_register_struct): Likewise.
4833         * gdbtypes.c (recursive_dump_type): Likewise.
4834         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4835         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4836         instead of %d in format strings.
4837         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4838         to std::min to ULONGEST.
4839         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4840         instead of %d in format strings.
4841         * tracepoint.c (info_scope_command): Likewise.
4842         * typeprint.c (print_offset_data::update)
4843         (print_offset_data::finish): Likewise.
4844         * xtensa-tdep.c (xtensa_store_return_value)
4845         (xtensa_push_dummy_call): Likewise.
4846
4847 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4848
4849         * windows-nat.c (display_selector): Fixed format specifications
4850         for 64-bit Cygwin.
4851
4852 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4853
4854         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4855
4856 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4857
4858         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4859         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4860         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4861         (nios2_linux_init_abi): Install it.
4862
4863 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4864
4865         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4866
4867 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4868
4869         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4870
4871 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4872             Tom Tromey  <tromey@adacore.com>
4873
4874         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4875
4876 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4877
4878         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4879         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4880         method to compute the bounds of range types. Also print "[evaluated]"
4881         if the bounds' values come from a dynamic evaluation.
4882
4883 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4884
4885         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4886         whitespace when pretty printing is on.
4887
4888 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4889
4890         * ppc-linux-nat.c: Add include.
4891
4892 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4893
4894         * NEWS: Mention AArch64 Pointer Authentication.
4895
4896 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4897
4898         * arm-linux-nat.c: Add include.
4899
4900 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4901
4902         * source-cache.c (source_cache::get_source_lines): Re-read
4903         fullname after calling open_source_file.
4904
4905 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4906
4907         * NEWS: Mention TLS support for FreeBSD.
4908
4909 2019-03-25  Tom Tromey  <tromey@adacore.com>
4910
4911         * minsyms.c (BUNCH_SIZE): Update comment.
4912         (~minimal_symbol_reader): Remove old comment.
4913         (compact_minimal_symbols): Update comment.
4914         (minimal_symbol_reader::install): Remove old comment.  Update
4915         other comments.
4916
4917 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4918
4919         * s390-linux-nat.c: Add include.
4920
4921 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4922
4923         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4924         Call linux_get_hwcap.
4925         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4926         Likewise.
4927         (aarch64_linux_get_hwcap): Remove function.
4928         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4929         declaration.
4930         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4931         linux_get_hwcap.
4932         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4933         * linux-tdep.c (linux_get_hwcap): Add function.
4934         (linux_get_hwcap2): Likewise.
4935         * linux-tdep.h (linux_get_hwcap): Add declaration.
4936         (linux_get_hwcap2): Likewise.
4937         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4938         (ppc_linux_get_hwcap2): Likewise.
4939         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4940         linux_get_hwcap.
4941         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4942         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4943         (ppc_linux_nat_target::read_description): Likewise.
4944         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4945         * s390-linux-nat.c: Likewise.
4946         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4947
4948 2019-03-24  Tom Tromey  <tom@tromey.com>
4949
4950         * ada-lang.c (standard_lookup): Simplify initialization.
4951         (ada_lookup_symbol_nonlocal): Simplify return.
4952         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4953         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4954         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4955         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4956         initialization.
4957         * solib.c (solib_global_lookup): Simplify.
4958         * symtab.c (null_block_symbol): Remove.
4959         (symbol_cache_lookup): Simplify returns.
4960         (lookup_language_this): Simplify returns.
4961         (lookup_symbol_aux): Simplify return.
4962         (lookup_local_symbol): Simplify returns.
4963         (lookup_global_symbol_from_objfile): Simplify return.
4964         (lookup_symbol_in_objfile_symtabs)
4965         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4966         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4967         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4968         * cp-namespace.c (cp_lookup_bare_symbol)
4969         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4970         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4971         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4972         (cp_lookup_symbol_via_imports): Simplify initialization.
4973         (find_symbol_in_baseclass): Likewise.
4974         * symtab.h (null_block_symbol): Remove.
4975         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4976         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4977         (d_lookup_symbol_module): Likewise.
4978         (find_symbol_in_baseclass): Simplify initialization.
4979
4980 2019-03-24  Tom Tromey  <tom@tromey.com>
4981
4982         * expression.h: Don't include symtab.h.
4983         (struct block): Forward declare.
4984
4985 2019-03-24  Tom Tromey  <tom@tromey.com>
4986
4987         * c-exp.y (typebase): Remove casts.
4988         * gdbtypes.c (lookup_unsigned_typename, )
4989         (lookup_signed_typename): Remove cast.
4990         * eval.c (parse_to_comma_and_eval): Remove cast.
4991         * parse.c (write_dollar_variable): Remove cast.
4992         * block.h (struct block) <superblock>: Now const.
4993         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4994         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4995         (map_block): Make "block" const.
4996         * symfile.h (struct quick_symbol_functions)
4997         <map_matching_symbols>: Constify block argument to "callback".
4998         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4999         const.
5000         (find_pc_sect_compunit_symtab): Make "b" const.
5001         (find_symbol_at_address): Likewise.
5002         (search_symbols): Likewise.
5003         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5004         (dw2_debug_names_lookup_symbol): Likewise.
5005         (dw2_map_matching_symbols): Update.
5006         * p-valprint.c (pascal_val_print): Remove "block".
5007         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5008         (aux_add_nonlocal_symbols): Make "block" const.
5009         (resolve_subexp): Remove cast.
5010         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5011         const.
5012         (iterate_over_file_blocks): Likewise.
5013         * f-exp.y (%union) <bval>: Remove.
5014         * coffread.c (patch_opaque_types): Make "b" const.
5015         * spu-tdep.c (spu_catch_start): Make "block" const.
5016         * c-valprint.c (print_unpacked_pointer): Remove "block".
5017         * symmisc.c (dump_symtab_1): Make "b" const.
5018         (block_depth): Make "block" const.
5019         * d-exp.y (%union) <bval>: Remove.
5020         * cp-support.h (cp_lookup_rtti_type): Update.
5021         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5022         * psymtab.c (psym_lookup_symbol): Make "block" const.
5023         (maintenance_check_psymtabs): Make "b" const.
5024         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5025         (enumerate_locals, enumerate_args): Update.
5026         * python/py-symtab.c (stpy_global_block): Make "block" const.
5027         (stpy_static_block): Likewise.
5028         * inline-frame.c (block_starting_point_at): Make "new_block"
5029         const.
5030         * block.c (find_block_in_blockvector): Make return type const.
5031         (blockvector_for_pc_sect): Make "b" const.
5032         (find_block_in_blockvector): Make "b" const.
5033
5034 2019-03-23  Tom Tromey  <tom@tromey.com>
5035
5036         * varobj.c (varobj_create): Update.
5037         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5038         * printcmd.c (display_command, do_one_display): Don't reset
5039         innermost_block.
5040         * parser-defs.h (enum innermost_block_tracker_type): Move to
5041         expression.h.
5042         (innermost_block): Update comment.
5043         * parse.c (parse_exp_1): Add tracker_types parameter.
5044         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5045         tracker_types parameter.  Reset innermost_block.
5046         (parse_exp_in_context): Remove.
5047         (parse_expression_for_completion): Update.
5048         * objfiles.c (~objfile): Don't reset expression_context_block or
5049         innermost_block.
5050         * expression.h (enum innermost_block_tracker_type): Move from
5051         parser-defs.h.
5052         (parse_exp_1): Add tracker_types parameter.
5053         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5054         reset innermost_block.
5055
5056 2019-03-23  Tom Tromey  <tom@tromey.com>
5057
5058         * objfiles.h: Include bcache.h.
5059
5060 2019-03-23  Tom Tromey  <tom@tromey.com>
5061
5062         * linespec.c (get_current_search_block): Use
5063         scoped_restore_current_language.
5064         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5065
5066 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5067             Jiong Wang  <jiong.wang@arm.com>
5068
5069         * aarch64-linux-tdep.c
5070         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5071         section.
5072         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5073
5074 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5075             Jiong Wang  <jiong.wang@arm.com>
5076
5077         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5078         instructions.
5079         (aarch64_analyze_prologue_test): Add PACIASP test.
5080         (aarch64_prologue_prev_register): Unmask PC value.
5081
5082 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5083             Jiong Wang  <jiong.wang@arm.com>
5084
5085         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5086         (aarch64_dwarf2_prev_register): Unmask PC value.
5087         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5088         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5089         DW_CFA_AARCH64_negate_ra_state.
5090         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5091
5092 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5093             Jiong Wang  <jiong.wang@arm.com>
5094
5095         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5096         registers.
5097         (aarch64_pseudo_register_name): Likewise.
5098         (aarch64_pseudo_register_type): Likewise.
5099         (aarch64_pseudo_register_reggroup_p): Likewise.
5100         (aarch64_gdbarch_init): Add pauth registers.
5101         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5102         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5103         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5104         (struct gdbarch_tdep): Add regnum for ra_state.
5105
5106 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5107             Jiong Wang  <jiong.wang@arm.com>
5108
5109         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5110
5111 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5112             Jiong Wang  <jiong.wang@arm.com>
5113
5114         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5115         function.
5116         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5117         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5118         (aarch64_gdbarch_init): Add puth registers.
5119         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5120         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5121         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5122
5123 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5124             Jiong Wang  <jiong.wang@arm.com>
5125
5126         * aarch64-linux-nat.c
5127         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5128         * aarch64-linux-tdep.c
5129         (aarch64_linux_core_read_description): Likewise.
5130         (aarch64_linux_get_hwcap): New function.
5131         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5132         (aarch64_linux_get_hwcap): New declaration.
5133
5134 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5135             Jiong Wang  <jiong.wang@arm.com>
5136
5137         * aarch64-linux-nat.c
5138         (aarch64_linux_nat_target::read_description): Add pauth param.
5139         * aarch64-linux-tdep.c
5140         (aarch64_linux_core_read_description): Likewise.
5141         * aarch64-tdep.c (struct target_desc): Add in pauth.
5142         (aarch64_read_description): Add pauth param.
5143         (aarch64_gdbarch_init): Likewise.
5144         * aarch64-tdep.h (aarch64_read_description): Likewise.
5145         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5146         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5147         * features/Makefile: Add new files.
5148         * features/aarch64-pauth.c: New file.
5149         * features/aarch64-pauth.xml: New file.
5150
5151 2019-03-20  Tom Tromey  <tromey@adacore.com>
5152
5153         * infrun.c (handle_inferior_event): Rename from
5154         handle_inferior_event_1.  Create a scoped_value_mark.
5155         (handle_inferior_event): Remove.
5156
5157 2019-03-19  Tom Tromey  <tromey@adacore.com>
5158
5159         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5160         * infrun.h (print_stop_event): Add "displays" parameter.
5161         * infrun.c (print_stop_event): Add "displays" parameter.
5162
5163 2019-03-19  Pedro Alves  <palves@redhat.com>
5164
5165         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5166         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5167         to -1.  Fix TABs vs spaces.
5168         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5169         * tui/tui-out.h (tui_ui_out) Add intro comments.
5170         <m_line, m_start_of_line>: In-class initialize, and add describing
5171         comment.
5172
5173 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5174
5175         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5176         variable names.
5177         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5178
5179 2019-03-18  Pedro Alves  <palves@redhat.com>
5180             Eli Zaretskii <eliz@gnu.org>
5181
5182         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5183         m_line and m_start_of_line.
5184
5185 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5186
5187         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5188         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5189         it returns a newline.  This fixes a regression in TU mode, whereby
5190         the next line is output on the same screen line as the user input.
5191
5192 2019-03-18  Tom Tromey  <tromey@adacore.com>
5193
5194         * minsyms.c (minimal_symbol_reader::install): Remove call to
5195         obstack_blank.
5196
5197 2019-03-18  Pedro Alves  <palves@redhat.com>
5198
5199         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5200         New globals.
5201         (apply_style): New, factored out from ...
5202         (apply_ansi_escape): ... this.  Handle reverse video mode.
5203         (tui_set_reverse_mode): New function.
5204         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5205         * tui/tui-winsource.c (tui_show_source_line): Use
5206         tui_set_reverse_mode instead of setting A_STANDOUT.
5207         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5208         New setter methods.
5209
5210 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5211
5212         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5213         Handle tabs.
5214
5215 2019-03-18  Tom Tromey  <tromey@adacore.com>
5216
5217         * ada-lang.c (empty_array): Add "high" parameter.
5218         (ada_evaluate_subexp): Update.
5219
5220 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5221
5222         * unittests/string_view-selftests.c: Define
5223         _initialize_string_view_selftests unconditionally.
5224
5225 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5226
5227         PR gdb/24350
5228         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5229
5230 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5231
5232         PR gdb/24351
5233         * windows-nat.c (display_selector): Fix format specifiers.
5234
5235 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5236
5237         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5238         tui_refill_source_window instead of tui_refresh_win, to update the
5239         current execution line.  This fixes redisplay of the current line
5240         when stepping through the code with "next" or "step".
5241
5242 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5243
5244         * source-cache.c (source_cache::get_source_lines): Call
5245         find_source_lines to initialize s->nlines.  This fixes vertical
5246         scrolling of TUI source window when the DOWN arrow is pressed.
5247
5248 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5249
5250         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5251         linux-thread-db.c (_initialize_thread_db): Likewise.
5252
5253 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5254
5255         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5256         wclrtoeol in tui_show_source_line".  This reverts changes made in
5257         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5258
5259 2019-03-15  Tom Tromey  <tom@tromey.com>
5260
5261         * symtab.h (struct minimal_symbol): Derive from
5262         general_symbol_info.
5263         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5264         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5265         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5266         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5267         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5268         (MSYMBOL_SEARCH_NAME): Update.
5269         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5270         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5271         * minsyms.c (minimal_symbol_reader::record_full): Update.
5272
5273 2019-03-15  Tom Tromey  <tom@tromey.com>
5274
5275         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5276
5277 2019-03-15  Tom Tromey  <tom@tromey.com>
5278
5279         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5280         unique_xmalloc_ptr.
5281         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5282         Update.
5283         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5284         (build_minimal_symbol_hash_tables)
5285         (minimal_symbol_reader::install): Update.
5286
5287 2019-03-15  Tom Tromey  <tom@tromey.com>
5288
5289         * symtab.c (create_demangled_names_hash): Update.
5290         (symbol_set_names): Update.
5291         * objfiles.h (struct objfile_per_bfd_storage)
5292         <demangled_names_hash>: Now an htab_up.
5293         * objfiles.c (objfile_per_bfd_storage): Simplify.
5294
5295 2019-03-15  Tom Tromey  <tom@tromey.com>
5296
5297         * objfiles.h (struct objfile_per_bfd_storage): Declare
5298         destructor.
5299         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5300         New.
5301         (get_objfile_bfd_data): Use new.  Don't initialize
5302         language_of_main.
5303         (free_objfile_per_bfd_storage): Remove.
5304         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5305
5306 2019-03-15  Tom Tromey  <tom@tromey.com>
5307
5308         * symfile.c (reread_symbols): Update.
5309         * objfiles.c (objfile::objfile): Update.
5310         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5311         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5312         comment.
5313         (minimal_symbol_reader::install): Update.
5314         (terminate_minimal_symbol_table): Remove.
5315         * jit.c (jit_object_close_impl): Update.
5316
5317 2019-03-15  Tom Tromey  <tom@tromey.com>
5318
5319         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5320         initializations.
5321
5322 2019-03-15  Tom Tromey  <tom@tromey.com>
5323
5324         * objfiles.h (struct objfile_per_bfd_storage)
5325         <demangled_hash_languages>: Now a bitset.
5326         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5327         (lookup_minimal_symbol): Update.
5328
5329 2019-03-15  Tom Tromey  <tom@tromey.com>
5330
5331         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5332         Don't return the symbol.
5333         * coffread.c (record_minimal_symbol): Use record_full.
5334
5335 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5336
5337         The MS-Windows port of ncurses fails to switch to a color pair if
5338         one or both of the colors are the implicit default colors.  This
5339         change records the default colors when TUI is initialized, and
5340         then specifies them explicitly when a color pair uses the default
5341         colors.  This allows color styling in TUI mode on MS-Windows.
5342
5343         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5344         ncurses_norm_attr.
5345         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5346         colors in ncurses_norm_attr.
5347         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5348         "none", replace it with the default color recorded in
5349         ncurses_norm_attr.
5350
5351 2019-03-14  Tom Tromey  <tromey@adacore.com>
5352
5353         * source-cache.h (class source_cache) <get_source_lines>: Return
5354         std::string.
5355         * source-cache.c (source_cache::extract_lines): Handle case where
5356         first_pos==npos.  Return std::string.
5357         (source_cache::get_source_lines): Update.
5358
5359 2019-03-14  Tom Tromey  <tromey@adacore.com>
5360
5361         * NEWS: Add item for "style sources" commands.
5362         * source-cache.c (source_cache::get_source_lines): Check
5363         source_styling.
5364         * cli/cli-style.c (source_styling): New global.
5365         (_initialize_cli_style): Add "style sources" commands.
5366         (show_style_sources): New function.
5367         * cli/cli-style.h (source_styling): Declare.
5368
5369 2019-03-14  Pedro Alves  <palves@redhat.com>
5370             Tom Tromey  <tromey@adacore.com>
5371
5372         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5373         * tui/tui-winsource.c (tui_refill_source_window): New function,
5374         from...
5375         (tui_horizontal_source_scroll): ... here.  Move some logic.
5376         * cli/cli-style.c (set_style_enabled): Notify new observable.
5377         * tui/tui-hooks.c (tui_redisplay_source): New function.
5378         (tui_attach_detach_observers): Attach or detach
5379         tui_redisplay_source.
5380         * observable.h (source_styling_changed): New observable.
5381         * observable.c: Define source_styling_changed observable.
5382
5383 2019-03-13  Tom Tromey  <tromey@adacore.com>
5384
5385         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5386         (i386_gnu_nat_target::store_registers): Update.
5387         * target-debug.h (target_debug_print_std_string): New macro.
5388         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5389         * windows-tdep.c (display_one_tib): Update.
5390         * tui/tui-stack.c (tui_make_status_line): Update.
5391         * top.c (print_inferior_quit_action): Update.
5392         * thread.c (thr_try_catch_cmd): Update.
5393         (add_thread_with_info): Update.
5394         (thread_target_id_str): Update.
5395         (thr_try_catch_cmd): Update.
5396         (thread_command): Update.
5397         (thread_find_command): Update.
5398         * record-btrace.c (record_btrace_target::info_record)
5399         (record_btrace_resume_thread, record_btrace_target::resume)
5400         (record_btrace_cancel_resume, record_btrace_step_thread)
5401         (record_btrace_target::wait, record_btrace_target::wait)
5402         (record_btrace_target::wait, record_btrace_target::stop): Update.
5403         * progspace.c (print_program_space): Update.
5404         * process-stratum-target.c
5405         (process_stratum_target::thread_address_space): Update.
5406         * linux-fork.c (linux_fork_mourn_inferior)
5407         (detach_checkpoint_command, info_checkpoints_command)
5408         (linux_fork_context): Update.
5409         (linux_fork_detach): Update.
5410         (class scoped_switch_fork_info): Update.
5411         (delete_checkpoint_command): Update.
5412         * infrun.c (follow_fork_inferior): Update.
5413         (follow_fork_inferior): Update.
5414         (proceed_after_vfork_done): Update.
5415         (handle_vfork_child_exec_or_exit): Update.
5416         (follow_exec): Update.
5417         (displaced_step_prepare_throw): Update.
5418         (displaced_step_restore): Update.
5419         (start_step_over): Update.
5420         (resume_1): Update.
5421         (clear_proceed_status_thread): Update.
5422         (proceed): Update.
5423         (print_target_wait_results): Update.
5424         (do_target_wait): Update.
5425         (context_switch): Update.
5426         (stop_all_threads): Update.
5427         (restart_threads): Update.
5428         (finish_step_over): Update.
5429         (handle_signal_stop): Update.
5430         (switch_back_to_stepped_thread): Update.
5431         (keep_going_pass_signal): Update.
5432         (print_exited_reason): Update.
5433         (normal_stop): Update.
5434         * inferior.c (inferior_pid_to_str): Change return type.
5435         (print_selected_inferior): Update.
5436         (add_inferior): Update.
5437         (detach_inferior): Update.
5438         * dummy-frame.c (fprint_dummy_frames): Update.
5439         * dcache.c (dcache_info_1): Update.
5440         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
5441         (btrace_fetch, btrace_clear): Update.
5442         * linux-tdep.c (linux_core_pid_to_str): Change return type.
5443         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
5444         type.
5445         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
5446         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
5447         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
5448         * gdbarch.c, gdbarch.h: Rebuild.
5449         * gdbarch.sh (core_pid_to_str): Change return type.
5450         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
5451         return type.
5452         (windows_nat_target::pid_to_str): Change return type.
5453         (windows_delete_thread): Update.
5454         (windows_nat_target::attach): Update.
5455         (windows_nat_target::files_info): Update.
5456         * target-delegates.c: Rebuild.
5457         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
5458         return type.
5459         (sol_thread_target::pid_to_str): Change return type.
5460         * remote.c (class remote_target) <pid_to_str>: Change return
5461         type.
5462         (remote_target::pid_to_str): Change return type.
5463         (extended_remote_target::attach, remote_target::remote_stop_ns)
5464         (remote_target::remote_notif_remove_queued_reply)
5465         (remote_target::push_stop_reply, remote_target::disable_btrace):
5466         Update.
5467         (extended_remote_target::attach): Update.
5468         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
5469         type.
5470         (gdbsim_target::pid_to_str): Change return type.
5471         * ravenscar-thread.c (struct ravenscar_thread_target)
5472         <pid_to_str>: Change return type.
5473         (ravenscar_thread_target::pid_to_str): Change return type.
5474         * procfs.c (class procfs_target) <pid_to_str>: Change return
5475         type.
5476         (procfs_target::pid_to_str): Change return type.
5477         (procfs_target::attach): Update.
5478         (procfs_target::detach): Update.
5479         (procfs_target::fetch_registers): Update.
5480         (procfs_target::store_registers): Update.
5481         (procfs_target::wait): Update.
5482         (procfs_target::files_info): Update.
5483         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
5484         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
5485         return type.
5486         (nto_procfs_target::pid_to_str): Change return type.
5487         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
5488         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
5489         return type.
5490         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
5491         (exit_lwp): Update.
5492         (attach_proc_task_lwp_callback, get_detach_signal)
5493         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
5494         (linux_nat_target::resume, wait_lwp, stop_callback)
5495         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
5496         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
5497         (linux_nat_wait_1, resume_stopped_resumed_lwps)
5498         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
5499         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
5500         type.
5501         (inf_ptrace_target::attach): Update.
5502         (inf_ptrace_target::files_info): Update.
5503         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
5504         type.
5505         (go32_nat_target::pid_to_str): Change return type.
5506         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
5507         (gnu_nat_target::wait): Update.
5508         (gnu_nat_target::wait): Update.
5509         (gnu_nat_target::resume): Update.
5510         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
5511         (fbsd_nat_target::wait): Update.
5512         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
5513         type.
5514         (darwin_nat_target::attach): Update.
5515         * corelow.c (class core_target) <pid_to_str>: Change return type.
5516         (core_target::pid_to_str): Change return type.
5517         * target.c (normal_pid_to_str): Change return type.
5518         (default_pid_to_str): Likewise.
5519         (target_pid_to_str): Change return type.
5520         (target_translate_tls_address): Update.
5521         (target_announce_detach): Update.
5522         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
5523         return type.
5524         (bsd_uthread_target::pid_to_str): Change return type.
5525         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
5526         type.
5527         (bsd_kvm_target::pid_to_str): Change return type.
5528         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
5529         return type.
5530         (aix_thread_target::pid_to_str): Change return type.
5531         * target.h (struct target_ops) <pid_to_str>: Change return type.
5532         (target_pid_to_str, normal_pid_to_str): Likewise.
5533         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
5534         type.
5535         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5536         type.
5537         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5538         return type.
5539         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5540         type.
5541         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5542         type.
5543         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5544         return type.
5545
5546 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
5547
5548         * NEWS: Mention that the new default MI version is 3.  Mention
5549         changes to the output of commands and events that deal with
5550         multi-location breakpoints.
5551         * breakpoint.c: Include "mi/mi-out.h".
5552         (print_one_breakpoint): Change output syntax if using MI version
5553         >= 3.
5554         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5555         New.
5556         (mi_multi_location_breakpoint_output_fixed): New.
5557         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5558         (mi_cmd_fix_multi_location_breakpoint_output): New.
5559         (mi_multi_location_breakpoint_output_fixed): New.
5560         * mi/mi-cmds.c (mi_cmds): Register command
5561         -fix-multi-location-breakpoint-output.
5562         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5563         interpreter "mi".
5564
5565 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5566
5567         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5568         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5569         instantiate mi_ui_out based on interpreter name.
5570         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5571         * mi/mi-main.c (mi_load_progress): Likewise.
5572
5573 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5574
5575         * NEWS: Combine separate "New targets" sections for 8.3.
5576
5577 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5578
5579         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5580         (ppcfbsd_init_abi): Install gdbarch
5581         "fetch_tls_load_module_address" and "get_thread_local_address"
5582         methods.
5583
5584 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5585
5586         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5587         (riscv_fbsd_init_abi): Install gdbarch
5588         "fetch_tls_load_module_address" and "get_thread_local_address"
5589         methods.
5590
5591 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5592
5593         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5594         (i386fbsd_init_abi): Install gdbarch
5595         "fetch_tls_load_module_address" and "get_thread_local_address"
5596         methods.
5597
5598 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5599
5600         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5601         (amd64fbsd_init_abi): Install gdbarch
5602         "fetch_tls_load_module_address" and "get_thread_local_address"
5603         methods.
5604
5605 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5606
5607         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5608         (struct fbsd_pspace_data): New type.
5609         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5610         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5611         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5612         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5613         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5614
5615 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5616
5617         * gdbtypes.c (lookup_struct_elt): New function.
5618         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5619         * gdbtypes.h (struct struct_elt): New type.
5620         (lookup_struct_elt): New prototype.
5621
5622 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5623
5624         * gdbtypes.c (lookup_struct_elt_type): Update comment and
5625         remove disabled code block.
5626
5627 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5628
5629         * gdbarch.sh (get_thread_local_address): New method.
5630         * gdbarch.h, gdbarch.c: Regenerate.
5631         * target.c (target_translate_tls_address): Use
5632         gdbarch_get_thread_local_address if present instead of
5633         target::get_thread_local_address.
5634
5635 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5636
5637         * target.h (target::get_thread_local_address): Update comment.
5638
5639 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5640
5641         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5642         objfile->separate_debug_objfile_backlink if not NULL.
5643
5644 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5645
5646         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5647         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5648         (amd64bsd_store_inferior_registers): Likewise.
5649         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5650         Enable segment base registers.
5651         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
5652         PT_GETFSBASE and PT_GETGSBASE.
5653         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
5654         PT_SETGSBASE.
5655         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
5656         segment base registers.
5657         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5658
5659 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5660
5661         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5662         Update calls to i386_target_description to add 'segments'
5663         parameter.
5664         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
5665         add segment base registers.
5666         * arch/i386.c (i386_create_target_description): Add 'segments'
5667         parameter to enable segment base registers.
5668         * arch/i386.h (i386_create_target_description): Likewise.
5669         * features/i386/32bit-segments.xml: New file.
5670         * features/i386/32bit-segments.c: Generate.
5671         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5672         call to i386_target_description to add 'segments' parameter.
5673         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5674         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5675         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5676         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5677         if feature is present.
5678         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5679         Add 'segments' parameter to call to i386_target_description.
5680         (i386_target_description): Add 'segments' parameter to enable
5681         segment base registers.
5682         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5683         to call to i386_target_description.
5684         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5685         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5686         Define I386_NUM_REGS.
5687         (i386_target_description): Add 'segments' parameter to enable
5688         segment base registers.
5689
5690 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
5691
5692         PR/24325
5693         * source-cache.c: #undef open and close, to avoid unresolved
5694         externals during linking.
5695
5696 2019-03-12  Tom Tromey  <tromey@adacore.com>
5697
5698         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5699         const.  Add initializers.
5700         (_initialize_remote): Don't initialize ptid globals.
5701
5702 2019-03-12  Pedro Alves  <palves@redhat.com>
5703
5704         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5705
5706 2019-03-12  Pedro Alves  <palves@redhat.com>
5707
5708         * cp-name-parser.y (main): Remove unused 'len' variable.
5709
5710 2019-03-12  Tom Tromey  <tromey@adacore.com>
5711
5712         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5713         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5714
5715 2019-03-12  Tom Tromey  <tromey@adacore.com>
5716
5717         * linux-nat.c (iterate_over_lwps): Update.
5718         (stop_callback): Remove parameter.
5719         (stop_wait_callback, detach_callback, resume_set_callback)
5720         (select_singlestep_lwp_callback, set_ignore_sigint)
5721         (status_callback, resumed_callback, resume_clear_callback)
5722         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5723         data parameter.
5724         (linux_nat_target::detach, linux_nat_target::resume)
5725         (linux_stop_and_wait_all_lwps, select_event_lwp)
5726         (linux_nat_filter_event, linux_nat_wait_1)
5727         (linux_nat_target::kill, linux_nat_target::stop)
5728         (linux_nat_target::stop): Update.
5729         (linux_nat_resume_callback): Change type.
5730         (resume_stopped_resumed_lwps, count_events_callback)
5731         (select_event_lwp_callback): Likewise.
5732         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5733         * arm-linux-nat.c (struct update_registers_data): Remove.
5734         (update_registers_callback): Change type.
5735         (arm_linux_insert_hw_breakpoint1): Update.
5736         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5737         parameter.
5738         (x86_linux_dr_set_addr): Update.
5739         (x86_linux_dr_set_control): Update.
5740         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5741         (iterate_over_lwps): Use gdb::function_view.
5742         * nat/aarch64-linux-hw-point.c (struct
5743         aarch64_dr_update_callback_param): Remove.
5744         (debug_reg_change_callback): Change type.
5745         (aarch64_notify_debug_reg_change): Update.
5746         * s390-linux-nat.c (s390_refresh_per_info): Update.
5747
5748 2019-03-11  Tom Tromey  <tromey@adacore.com>
5749
5750         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5751         redundant assignment to "this_cu".
5752
5753 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5754
5755         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5756
5757 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5758
5759         * gdbtypes.c (rank_one_type_parm_set): New function extracted
5760         from...
5761         (rank_one_type): ... this.
5762
5763 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5764
5765         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5766         from...
5767         (rank_one_type): ... this.
5768
5769 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5770
5771         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5772         from...
5773         (rank_one_type): ... this.
5774
5775 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5776
5777         * gdbtypes.c (rank_one_type_parm_float): New function extracted
5778         from...
5779         (rank_one_type): ... this.
5780
5781 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5782
5783         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5784         from...
5785         (rank_one_type): ... this.
5786
5787 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5788
5789         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5790         from...
5791         (rank_one_type): ... this.
5792
5793 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5794
5795         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5796         from...
5797         (rank_one_type): ... this.
5798
5799 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5800
5801         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5802         from...
5803         (rank_one_type): ... this.
5804
5805 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5806
5807         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5808         from...
5809         (rank_one_type): ... this.
5810
5811 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5812
5813         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5814         from...
5815         (rank_one_type): ... this.
5816
5817 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5818
5819         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5820         from...
5821         (rank_one_type): ... this.
5822
5823 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5824
5825         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5826         from...
5827         (rank_one_type): ... this.
5828
5829 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5830
5831         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5832         inferior-events' shows the example events.
5833
5834 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5835
5836         Support styling on native MS-Windows console
5837
5838         PR/24315
5839         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5840         on MS-Windows if $TERM is not defined.
5841
5842         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5843
5844         * posix-hdep.c (gdb_console_fputs):
5845         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5846         functions.
5847         * ui-file.h (gdb_console_fputs): Add prototype.
5848
5849         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5850         back to fputs only if the former returns zero.
5851
5852 2019-03-07  Tom Tromey  <tom@tromey.com>
5853
5854         * symmisc.c (print_symbol_bcache_statistics): Update.
5855         (print_objfile_statistics): Update.
5856         * symfile.c (allocate_symtab): Update.
5857         * stabsread.c: Don't include bcache.h.
5858         * psymtab.h (struct psymbol_bcache): Don't declare.
5859         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5860         (psymbol_bcache_init, psymbol_bcache_free)
5861         (psymbol_bcache_get_bcache): Don't declare.
5862         * psymtab.c (struct psymbol_bcache): Remove.
5863         (psymtab_storage::psymtab_storage): Update.
5864         (psymtab_storage::~psymtab_storage): Update.
5865         (psymbol_bcache_init, psymbol_bcache_free)
5866         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5867         (add_psymbol_to_bcache): Update.
5868         (allocate_psymtab): Update.
5869         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5870         macro_cache>: No longer pointers.
5871         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5872         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5873         * macrotab.c (macro_bcache): Update.
5874         * macroexp.c: Don't include bcache.h.
5875         * gdbtypes.c (check_types_worklist): Update.
5876         (types_deeply_equal): Remove TRY/CATCH.  Update.
5877         * elfread.c (elf_symtab_read): Update.
5878         * dwarf2read.c: Don't include bcache.h.
5879         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5880         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5881         (print_bcache_statistics, bcache_memory_used): Don't declare.
5882         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5883         methods.  Rename all data members.
5884         * bcache.c (struct bcache): Move to bcache.h.
5885         (bcache::expand_hash_table): Rename from expand_hash_table.
5886         (bcache): Remove.
5887         (bcache::insert): Rename from bcache_full.
5888         (bcache::compare): Rename from bcache_compare.
5889         (bcache_xmalloc): Remove.
5890         (bcache::~bcache): Rename from bcache_xfree.
5891         (bcache::print_statistics): Rename from print_bcache_statistics.
5892         (bcache::memory_used): Rename from bcache_memory_used.
5893
5894 2019-03-07  Pedro Alves  <palves@redhat.com>
5895
5896         * infrun.c (normal_stop): Also check for
5897         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5898
5899 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5900
5901         * f-lang.c (value_from_host_double): Moved to...
5902         * value.c (value_from_host_double): ...here.
5903         * value.h (value_from_host_double): Declare.
5904         * guile/scm-math.c (vlscm_convert_typed_number): Use
5905         value_from_host_double.
5906         (vlscm_convert_number): Likewise.
5907         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5908         * python/py-value.c (convert_value_from_python): Likewise.
5909
5910 2019-03-06  Tom Tromey  <tom@tromey.com>
5911
5912         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5913
5914 2019-03-06  Tom Tromey  <tom@tromey.com>
5915
5916         * utils.h (free_current_contents): Don't declare.
5917         * utils.c (free_current_contents): Remove.
5918
5919 2019-03-06  Tom Tromey  <tom@tromey.com>
5920
5921         * top.c (quit_force): Update.
5922         * main.c (captured_command_loop): Update.
5923         * common/new-op.c (operator new): Update.
5924         * common/common-exceptions.c (struct catcher)
5925         <save_cleanup_chain>: Remove member.
5926         (exceptions_state_mc_init): Update.
5927         (exception_try_scope_entry): Return nullptr.
5928         (exception_try_scope_exit, exception_rethrow)
5929         (throw_exception_sjlj, throw_exception_cxx): Update.
5930         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5931         (all_cleanups, do_cleanups, discard_cleanups)
5932         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5933         (restore_cleanups, restore_final_cleanups): Don't declare.
5934         (do_final_cleanups): Remove parameter.
5935         * common/cleanups.c (cleanup_chain, make_cleanup)
5936         (make_cleanup_dtor, all_cleanups, do_cleanups)
5937         (discard_my_cleanups, discard_cleanups)
5938         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5939         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5940         (null_cleanup): Remove.
5941         (do_final_cleanups): Remove parameter.
5942
5943 2019-03-06  Tom Tromey  <tom@tromey.com>
5944
5945         * remote.c (remote_target::remote_parse_stop_reply): Use
5946         unique_xmalloc_ptr.
5947
5948 2019-03-06  Tom Tromey  <tom@tromey.com>
5949
5950         * stabsread.c (struct stabs_field_info): Rename from field_info.
5951         <list, fnlist>: Add initializers.
5952         <obstack>: New member.
5953         (read_member_functions, read_struct_fields, read_baseclasses):
5954         Allocate on obstack.  Don't use cleanups.
5955         (read_one_struct_field, read_member_functions, read_struct_fields)
5956         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5957         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5958         (read_struct_type): Update.
5959
5960 2019-03-06  Tom Tromey  <tom@tromey.com>
5961
5962         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5963         * common/filestuff.h (make_cleanup_close): Don't declare.
5964         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5965         Remove.
5966
5967 2019-03-06  Tom Tromey  <tom@tromey.com>
5968
5969         * solib-aix.c: Use make_scope_exit.
5970
5971 2019-03-06  Tom Tromey  <tom@tromey.com>
5972
5973         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5974         Use make_scope_exit.
5975
5976 2019-03-06  Tom Tromey  <tom@tromey.com>
5977
5978         * solib-svr4.c (disable_probes_interface): Remove parameter.
5979         (svr4_handle_solib_event): Use make_scope_exit.
5980
5981 2019-03-06  Tom Tromey  <tom@tromey.com>
5982
5983         * remote.c (struct stop_reply_deleter): Remove.
5984         (stop_reply_up): Update.
5985         (struct stop_reply): Derive from notif_event.  Don't typedef.
5986         <regcache>: Now a std::vector.
5987         (stop_reply_xfree): Remove.
5988         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5989         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5990         (remote_target::discard_pending_stop_replies): Use delete.
5991         (remote_target::remote_parse_stop_reply): Update.
5992         (remote_target::process_stop_reply): Update.
5993         * remote-notif.h (struct notif_event): Add virtual destructor.
5994         Remove "dtr" member.
5995         (struct notif_client) <alloc_event>: Return a unique_ptr.
5996         (notif_event_xfree): Don't declare.
5997         (notif_event_up): New typedef.
5998         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5999         (notif_event_xfree, do_notif_event_xfree): Remove.
6000         (remote_notif_state_xfree): Update.
6001
6002 2019-03-06  Tom Tromey  <tom@tromey.com>
6003
6004         * infrun.c (displaced_step_clear_cleanup): Now a
6005         forward_scope_exit type.
6006         (displaced_step_prepare_throw): Update.
6007         (displaced_step_fixup): Update.
6008
6009 2019-03-06  Tom Tromey  <tom@tromey.com>
6010
6011         * inferior.h (class inferior): Update comment.
6012         * gdbthread.h (class thread_info): Update comment.
6013
6014 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6015             Tom Tromey  <tom@tromey.com>
6016
6017         * stabsread.h (struct stab_section_list): Remove.
6018         (coffstab_build_psymtabs): Update.
6019         * dbxread.c (symbuf_sections): Now a std::vector.
6020         (sect_idx): New global.
6021         (fill_symbuf): Update.
6022         (coffstab_build_psymtabs): Change type of stabsects parameter.
6023         Update.
6024         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6025         std::vector.
6026         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6027         (coff_locate_sections): Update.
6028         (coff_symfile_read): Remove cleanups.  Update.
6029         (init_stringtab): Add storage parameter.
6030         (free_stringtab, free_stringtab_cleanup): Remove.
6031         (init_lineno): Add storage parameter.
6032         (free_linetab, free_linetab_cleanup): Remove.
6033
6034 2019-03-06  Pedro Alves  <palves@redhat.com>
6035
6036         * linux-fork.c (fork_info::clobber_regs): Delete.
6037         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6038         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6039         comment.  Adjust.
6040         (scoped_switch_fork_info::scoped_switch_fork_info)
6041         (checkpoint_command, linux_fork_context): Adjust
6042         fork_save_infrun_state calls.
6043
6044 2019-03-06  Pedro Alves  <palves@redhat.com>
6045
6046         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6047         (inf_has_multiple_threads): Return 'bool' and rewrite using
6048         inferior_info::threads().
6049
6050 2019-03-06  Pedro Alves  <palves@redhat.com>
6051
6052         * linux-fork.c: Include <list>.
6053         (fork_list): Now a std::list instance.
6054         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6055         (forks_exist_p, find_last_fork): Adjust.
6056         (new_fork): Delete.
6057         (one_fork_p): New.
6058         (add_fork): Adjust.
6059         (free_fork): Delete, folded into fork_info::~fork_info().
6060         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6061         Adjust.
6062         (init_fork_list): Delete.
6063         (linux_fork_killall, linux_fork_mourn_inferior)
6064         (linux_fork_detach, info_checkpoints_command): Adjust.
6065         (_initialize_linux_fork): No longer call init_fork_list.
6066
6067 2019-03-06  Pedro Alves  <palves@redhat.com>
6068
6069         * linux-fork.c (new_fork): New, split out of ...
6070         (add_fork): ... this.  Return void.  Move "first fork" special
6071         case from here, to ...
6072         (checkpoint_command): ... here.
6073         * linux-linux.h (add_fork): Return void.
6074
6075 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6076
6077         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6078
6079 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6080             Chris January  <chris.january@arm.com>
6081             David Lecomber  <david.lecomber@arm.com>
6082
6083         * f-exp.y: New token, UNOP_INTRINSIC.
6084         (exp): New pattern using UNOP_INTRINSIC token.
6085         (f77_keywords): Add 'abs' keyword.
6086         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6087         (value_from_host_double): New function.
6088         (evaluate_subexp_f): Support UNOP_ABS.
6089
6090 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6091
6092         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6093         types.
6094
6095 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6096
6097         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6098         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6099         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6100
6101 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6102
6103         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6104
6105 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6106             Chris January  <chris.january@arm.com>
6107
6108         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6109         * f-exp.y: Define 'KIND' token.
6110         (exp): New pattern for KIND expressions.
6111         (ptype): Handle types with a kind extension.
6112         (direct_abs_decl): Extend to spot kind extensions.
6113         (f77_keywords): Add 'kind' to the list.
6114         (push_kind_type): New function.
6115         (convert_to_kind_type): New function.
6116         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6117         * parse.c (operator_length_standard): Likewise.
6118         * parser-defs.h (enum type_pieces): Add tp_kind.
6119         * std-operator.def: Add UNOP_KIND.
6120
6121 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6122
6123         * f-exp.y (f_parse): Set yydebug.
6124
6125 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6126
6127         * f-lang.c (evaluate_subexp_f): New function.
6128         (exp_descriptor_f): New global.
6129         (f_language_defn): Use exp_descriptor_f instead of
6130         exp_descriptor_standard.
6131
6132 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6133
6134         * f-exp.y (struct token): Add comments.
6135         (dot_ops): Remove uppercase versions and the end marker.
6136         (f77_keywords): Likewise.
6137         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6138         entries in the dot_ops array are case insensitive, and use
6139         strncasecmp to compare strings.  Also some whitespace cleanup in
6140         this area.  Similar for the f77_keywords array, except entries in
6141         this list might be case sensitive.
6142
6143 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6144
6145         * f-exp.y (struct f77_boolean_val): Add comments.
6146         (boolean_values): Remove uppercase versions, and end marker.
6147         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6148         and use strncasecmp to achieve case insensitivity.  Additionally,
6149         perform whitespace cleanup around this code.
6150
6151 2019-03-06  Tom Tromey  <tromey@adacore.com>
6152
6153         * remote-sim.c (gdbsim_target_open): Use result of
6154         gdb_argv::release.
6155
6156 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6157         Dirk Schubert  <dirk.schubert@arm.com>
6158         Chris January  <chris.january@arm.com>
6159
6160         * eval.c (evaluate_subexp_standard): Call Fortran argument
6161         wrapping logic.
6162         * f-lang.c (struct value): A value which can be passed into a
6163         Fortran function call.
6164         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6165         where appropriate.
6166         (struct type): Value ready for a Fortran function call.
6167         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6168         is needed.
6169         * f-lang.h (fortran_argument_convert): Declaration.
6170         (fortran_preserve_arg_pointer): Declaration.
6171         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6172
6173 2019-03-05  Tom Tromey  <tromey@adacore.com>
6174
6175         * python/py-prettyprint.c (print_string_repr): Remove #if.
6176         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6177
6178 2019-03-05  Tom Tromey  <tromey@adacore.com>
6179
6180         * target.c (the_dummy_target): Move later.  Change type to
6181         "dummy_target".
6182         (initialize_targets): Don't initialize the_dummy_target.
6183
6184 2019-03-05  Tom Tromey  <tromey@adacore.com>
6185
6186         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6187         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6188
6189 2019-03-05  Tom Tromey  <tromey@adacore.com>
6190
6191         * windows-nat.c (windows_nat_target::attach)
6192         (windows_nat_target::detach): Don't call gdb_flush.
6193         * valprint.c (generic_val_print, val_print, val_print_string):
6194         Don't call gdb_flush.
6195         * utils.c (defaulted_query): Don't call gdb_flush.
6196         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6197         * target.c (target_announce_detach): Don't call gdb_flush.
6198         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6199         * remote.c (extended_remote_target::attach): Don't call
6200         gdb_flush.
6201         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6202         * printcmd.c (do_examine): Don't call gdb_flush.
6203         (info_display_command): Don't call gdb_flush.
6204         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6205         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6206         * memattr.c (info_mem_command): Don't call gdb_flush.
6207         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6208         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6209         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6210         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6211         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6212         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6213         (gnu_nat_target::detach): Don't call gdb_flush.
6214         * f-valprint.c (f_val_print): Don't call gdb_flush.
6215         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6216         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6217         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6218         gdb_flush.
6219         * c-valprint.c (c_val_print): Don't call gdb_flush.
6220         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6221
6222 2019-03-05  Tom Tromey  <tromey@adacore.com>
6223
6224         * varobj.c (update_dynamic_varobj_children): Update.
6225         (install_default_visualizer): Use reset, not release.
6226         * value.c (set_internalvar): Update.
6227         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6228         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6229         ATTRIBUTE_UNUSED_RESULT.
6230
6231 2019-03-05  Tom Tromey  <tromey@adacore.com>
6232
6233         * remote.c (class scoped_remote_fd) <release>: Add
6234         ATTRIBUTE_UNUSED_RESULT.
6235
6236 2019-03-05  Tom Tromey  <tromey@adacore.com>
6237
6238         * macroexp.c (struct macro_buffer) <release>: Add
6239         ATTRIBUTE_UNUSED_RESULT.
6240
6241 2019-03-05  Tom Tromey  <tromey@adacore.com>
6242
6243         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6244         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6245         ATTRIBUTE_UNUSED_RESULT.
6246
6247 2019-03-05  Tom Tromey  <tromey@adacore.com>
6248
6249         * common/scoped_fd.h (class scoped_fd) <release>: Add
6250         ATTRIBUTE_UNUSED_RESULT.
6251
6252 2019-03-05  Tom Tromey  <tromey@adacore.com>
6253
6254         * parser-defs.h (struct parser_state) <release>: Add
6255         ATTRIBUTE_UNUSED_RESULT.
6256
6257 2019-03-05  Tom Tromey  <tromey@adacore.com>
6258
6259         * utils.h (class gdb_argv) <release>: Add
6260         ATTRIBUTE_UNUSED_RESULT.
6261         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6262
6263 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6264
6265         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6266         for-loop range, to avoid compiler warnings.
6267
6268         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6269         avoid compiler warnings about unused variables.
6270
6271         * NEWS: Mention end of support for native debugging on MS-Windows
6272         before XP.
6273
6274         PR gdb/24292
6275         * common/netstuff.c:
6276         * gdbserver/gdbreplay.c
6277         * gdbserver/remote-utils.c:
6278         * ser-tcp.c:
6279         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6280         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6281         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6282         'getaddrinfo' and 'freeaddrinfo' were not available before
6283         Windows XP, and mingw.org's MinGW headers by default define
6284         _WIN32_WINNT to 0x500.
6285
6286 2019-03-01  Gary Benson <gbenson@redhat.com>
6287
6288         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6289
6290 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6291             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6292
6293         PR gdb/8527
6294         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6295         set_sigint_trap, clear_sigint_trap.
6296
6297 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6298
6299         * target.c (target_detach): Clear the regcache and the
6300         frame cache.
6301
6302 2019-02-27  Pedro Alves  <palves@redhat.com>
6303
6304         * utils.c (set_screen_size): When we cap the height/width sizes,
6305         tweak the corresponding command variable to show "unlimited":
6306
6307 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6308             Pedro Alves  <palves@redhat.com>
6309
6310         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6311         before calling rl_set_screen_size.
6312
6313 2019-02-27  Tom Tromey  <tromey@adacore.com>
6314
6315         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6316         define.
6317         * python/py-value.c: Remove Python 2.4 workaround.
6318         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6319         workaround.
6320         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6321         Python 2.4 workaround.
6322         * python/python-internal.h: Remove Python 2.4 comment.
6323         (Py_ssize_t): Don't define.
6324         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6325         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6326         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6327         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6328         * python/python.c (do_start_initialization): Remove Python 2.4
6329         workaround.
6330         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6331         (print_children): Remove Python 2.4 workaround.
6332         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6333         workaround.
6334         (CHARBUFFERPROC_NAME): Remove.
6335         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6336         Python 2.4 workaround.
6337
6338 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6339
6340         * NEWS: Note minimum Python version.
6341
6342 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6343
6344         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6345         code from these functions.  Remove corresponding ifdefs.  Use
6346         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6347         Remove gotos and target of gotos.
6348         (infpy_search_memory): Likewise.
6349
6350 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6351
6352         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6353         (hppa_gdbarch_init): Don't register deleted functions with
6354         gdbarch.
6355
6356 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6357
6358         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6359         (h8300_unwind_sp): Delete.
6360         (h8300_dummy_id): Delete.
6361         (h8300_gdbarch_init): Don't register deleted functions with
6362         gdbarch.
6363
6364 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6365
6366         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6367         (ft32_unwind_pc): Delete.
6368         (ft32_unwind_sp): Delete.
6369         (ft32_gdbarch_init): Don't register deleted functions with
6370         gdbarch.
6371
6372 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6373
6374         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6375         (frv_unwind_pc): Delete.
6376         (frv_unwind_sp): Delete.
6377         (frv_gdbarch_init): Don't register deleted functions with
6378         gdbarch.
6379
6380 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6381
6382         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6383         (riscv_unwind_pc): Delete.
6384         (riscv_unwind_sp): Delete.
6385         (riscv_gdbarch_init): Don't register deleted functions with
6386         gdbarch.
6387
6388 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6389
6390         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6391         (csky_unwind_pc): Delete.
6392         (csky_unwind_sp): Delete.
6393         (csky_gdbarch_init): Don't register deleted functions with
6394         gdbarch.
6395
6396 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6397
6398         * gdb/cris-tdep.c (cris_dummy_id): Delete.
6399         (cris_unwind_pc): Delete.
6400         (cris_unwind_sp): Delete.
6401         (cris_gdbarch_init): Don't register deleted functions with
6402         gdbarch.
6403
6404 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6405
6406         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6407         (bfin_unwind_pc): Delete.
6408         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6409
6410 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6411
6412         * gdb/arm-tdep.c (arm_dummy_id): Delete.
6413         (arm_unwind_pc): Delete.
6414         (arm_unwind_sp): Delete.
6415         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
6416
6417 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6418
6419         * gdb/arc-tdep.c (arc_dummy_id): Delete.
6420         (arc_unwind_pc): Delete.
6421         (arc_unwind_sp): Delete.
6422         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
6423
6424 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6425
6426         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
6427         (alpha_unwind_pc): Delete.
6428         (alpha_gdbarch_init): Don't register deleted functions with
6429         gdbarch.
6430
6431 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6432
6433         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
6434         (aarch64_unwind_pc): Delete.
6435         (aarch64_unwind_sp): Delete.
6436         (aarch64_gdbarch_init): Don't register deleted functions with
6437         gdbarch.
6438
6439 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6440
6441         * gdbtypes.c (type_align): Don't consider static members when
6442         computing structure alignment.
6443
6444 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6445
6446         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
6447         return 0 for other types.
6448         * arch-utils.c (default_type_align): Always return 0.
6449         * gdbarch.h: Regenerate.
6450         * gdbarch.sh (type_align): Extend comment.
6451         * gdbtypes.c (type_align): Add additional comments, always call
6452         gdbarch_type_align before applying the default rules.
6453         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
6454         generic code will then apply a suitable default.
6455         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
6456         types, return 0 for other types.
6457
6458 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6459
6460         * NEWS: Create a new section for the next release branch.
6461         Rename the section of the current branch, now that it has
6462         been cut.
6463
6464 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6465
6466         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
6467         * version.in: Bump version to 8.3.50.DATE-git.
6468
6469 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
6470
6471         * aix-thread.c (ptid_cmp): Remove unused variable.
6472         (get_signaled_thread): Likewise.
6473         (store_regs_user_thread): Likewise.
6474         (store_regs_kernel_thread): Likewise.
6475         (fetch_regs_kernel_thread): Remove shadowed variable.
6476
6477 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6478
6479         * features/riscv/32bit-cpu.xml: Add register numbers.
6480         * features/riscv/32bit-fpu.c: Regenerate.
6481         * features/riscv/32bit-fpu.xml: Add register numbers.
6482         * features/riscv/64bit-cpu.xml: Add register numbers.
6483         * features/riscv/64bit-fpu.c: Regenerate.
6484         * features/riscv/64bit-fpu.xml: Add register numbers.
6485
6486 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
6487
6488         * NEWS: Mention two argument form of gdb.Value constructor.
6489         * python/py-value.c (convert_buffer_and_type_to_value): New
6490         function.
6491         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
6492         Add support for handling an optional second argument.  Call
6493         convert_buffer_and_type_to_value as appropriate.
6494         * python/python-internal.h (Py_buffer_deleter): New struct.
6495         (Py_buffer_up): New typedef.
6496
6497 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
6498
6499         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
6500         instead of releasing ownership.
6501
6502 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
6503
6504         * dwarf2read.c (open_and_init_dwp_file): Call
6505         elf_numsections instead of bfd_count_sections to initialize
6506         dwp_file->num_sections.
6507
6508 2019-02-25  Tom Tromey  <tromey@adacore.com>
6509
6510         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
6511
6512 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
6513
6514         * gcore.in: Add '--readnever' option when invoking GDB.
6515
6516 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6517
6518         * MAINTAINERS: Update my email address.
6519
6520 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6521
6522         * build-id.c (build_id_to_debug_bfd_1): New function.
6523         (build_id_to_debug_bfd): Look for separate debug file in
6524         sysroot.
6525
6526 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6527
6528         * gdbarch.sh: Update the copyright year range that is placed into
6529         generated files.
6530
6531 2019-02-22  Keith Seitz  <keiths@redhat.com>
6532
6533         PR symtab/23853
6534         * linespec.c (create_sals_line_offset): Search for the default
6535         symtab's filename instead of its fullname.
6536
6537 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6538
6539         * NEWS: Update style defaults.
6540
6541 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6542
6543         * main.c (captured_main_1): Disable styling in batch mode.
6544
6545 2019-02-20  Tom Tromey  <tom@tromey.com>
6546
6547         * symtab.c (symtab_symbol_info): Fix typos.
6548
6549 2019-02-20  Tom Tromey  <tromey@adacore.com>
6550
6551         * findcmd.c (_initialize_mem_search): Use upper case for
6552         metasyntactic variables.
6553
6554 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
6555
6556         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6557         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6558
6559 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6560
6561         * top.h (source_file_name): Change to std::string.
6562         * top.c (source_file_name): Likewise.
6563         (command_line_input): Adjust.
6564         * cli/cli-script.c (script_from_file): Adjust.
6565
6566 2019-02-19  Tom Tromey  <tromey@adacore.com>
6567
6568         * ravenscar-thread.c
6569         (ravenscar_thread_target::update_thread_list): Don't call
6570         ada_build_task_list.
6571         * ada-lang.h (ada_build_task_list): Don't declare.
6572         * ada-tasks.c (struct ada_tasks_inferior_data)
6573         <task_list_valid_p>: Now bool.
6574         (read_known_tasks, ada_task_list_changed)
6575         (ada_tasks_invalidate_inferior_data): Update.
6576         (read_known_tasks_array): Return bool.
6577         (read_known_tasks_list): Likewise.
6578         (read_known_tasks): Return void.
6579         (ada_build_task_list): Now static.
6580
6581 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6582
6583         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6584         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6585
6586 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6587
6588         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6589         variant for ada_tasks_pspace_data_handle and
6590         ada_tasks_inferior_data_handle.
6591         (ada_tasks_pspace_data_cleanup): New function.
6592         (ada_tasks_inferior_data_cleanup): New function.
6593
6594 2019-02-17  Tom Tromey  <tom@tromey.com>
6595
6596         * macrotab.h (macro_source_fullname): Return a std::string.
6597         * macrotab.c (macro_include, check_for_redefinition)
6598         (macro_undef, macro_lookup_definition, foreach_macro)
6599         (foreach_macro_in_scope): Update.
6600         (macro_source_fullname): Return a std::string.
6601         * macrocmd.c (show_pp_source_pos): Update.
6602
6603 2019-02-17  Tom Tromey  <tom@tromey.com>
6604
6605         * macrocmd.c (show_pp_source_pos): Style the file names.
6606
6607 2019-02-17  Tom Tromey  <tom@tromey.com>
6608
6609         PR tui/24197:
6610         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6611
6612 2019-02-17  Tom Tromey  <tom@tromey.com>
6613
6614         * ada-lang.c (user_select_syms): Use filtered printing.
6615         * utils.c (wrap_style): New global.
6616         (desired_style): Remove.
6617         (emit_style_escape): Add stream parameter.
6618         (set_output_style, reset_terminal_style, prompt_for_continue):
6619         Update.
6620         (flush_wrap_buffer): Only flush gdb_stdout.
6621         (wrap_here): Set wrap_style.
6622         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
6623         treat escape sequences as a character.  Change when wrap buffer is
6624         flushed.
6625         (fputs_styled): Do not set the output style when the default is
6626         requested.
6627         * ui-style.h (struct ui_file_style) <is_default>: New method.
6628         * source.c (print_source_lines_base): Emit escape sequences in one
6629         piece.
6630
6631 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6632
6633         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6634         integers and enumeration types.
6635
6636 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6637
6638         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6639         instead of lookup_symbol_in_language
6640         (do_exact_match): New function.
6641         (ada_get_symbol_name_matcher): Return do_exact_match when
6642         doing a verbatim match.
6643
6644 2019-02-15  Tom Tromey  <tromey@adacore.com>
6645
6646         * ravenscar-thread.c (ravenscar_thread_target::resume)
6647         (ravenscar_thread_target::wait): Special case wildcard requests.
6648
6649 2019-02-15  Tom Tromey  <tromey@adacore.com>
6650
6651         * ravenscar-thread.c (base_ptid): Remove.
6652         (struct ravenscar_thread_target) <close>: New method.
6653         <m_base_ptid>: New member.
6654         <update_inferior_ptid, active_task, task_is_currently_active,
6655         runtime_initialized>: Declare methods.
6656         <ravenscar_thread_target>: Add constructor.
6657         (ravenscar_thread_target::task_is_currently_active)
6658         (ravenscar_thread_target::update_inferior_ptid)
6659         (ravenscar_runtime_initialized): Rename.  Now methods.
6660         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6661         (ravenscar_thread_target::update_thread_list): Update.
6662         (ravenscar_thread_target::active_task): Now method.
6663         (ravenscar_thread_target::store_registers)
6664         (ravenscar_thread_target::prepare_to_store)
6665         (ravenscar_thread_target::prepare_to_store)
6666         (ravenscar_thread_target::mourn_inferior): Update.
6667         (ravenscar_inferior_created): Use "new" to create target.
6668         (ravenscar_thread_target::get_ada_task_ptid): Update.
6669         (_initialize_ravenscar): Don't initialize base_ptid.
6670         (ravenscar_ops): Remove global.
6671
6672 2019-02-15  Tom Tromey  <tromey@adacore.com>
6673
6674         * target.h (push_target): Declare new overload.
6675         * target.c (push_target): New overload, taking an rvalue reference.
6676         * remote.c (remote_target::open_1): Use push_target overload.
6677         * corelow.c (core_target_open): Use push_target overload.
6678
6679 2019-02-15  Tom Tromey  <tromey@adacore.com>
6680
6681         * ravenscar-thread.c (is_ravenscar_task)
6682         (ravenscar_task_is_currently_active): Return bool.
6683         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6684         (_initialize_ravenscar): Remove "(void)".
6685         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6686         Return bool.
6687
6688 2019-02-15  Tom Tromey  <tromey@adacore.com>
6689
6690         * ravenscar-thread.c (ravenscar_runtime_initializer)
6691         (has_ravenscar_runtime, get_running_thread_id)
6692         (ravenscar_thread_target::resume): Fix indentation.
6693
6694 2019-02-15  Tom Tromey  <tromey@adacore.com>
6695
6696         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6697         from ravenscar_arch_ops.
6698         (sparc_ravenscar_ops::fetch_registers)
6699         (sparc_ravenscar_ops::store_registers): Now methods.
6700         (sparc_ravenscar_prepare_to_store): Remove.
6701         (sparc_ravenscar_ops): Redefine.
6702         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
6703         methods and destructor.  Remove members.
6704         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6705         (ravenscar_thread_target::store_registers)
6706         (ravenscar_thread_target::prepare_to_store): Update.
6707         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6708         Remove.
6709         (struct ppc_ravenscar_powerpc_ops): Derive from
6710         ravenscar_arch_ops.
6711         (ppc_ravenscar_powerpc_ops::fetch_registers)
6712         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6713         (ppc_ravenscar_powerpc_ops): Redefine.
6714         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6715         (ppc_ravenscar_e500_ops::fetch_registers)
6716         (ppc_ravenscar_e500_ops::store_registers): Now methods.
6717         (ppc_ravenscar_e500_ops): Redefine.
6718         * aarch64-ravenscar-thread.c
6719         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6720         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6721         (aarch64_ravenscar_fetch_registers)
6722         (aarch64_ravenscar_store_registers): Now methods.
6723         (aarch64_ravenscar_ops): Redefine.
6724
6725 2019-02-15  Tom Tromey  <tromey@adacore.com>
6726
6727         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6728         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6729         (ravenscar_thread_target::stopped_by_watchpoint)
6730         (ravenscar_thread_target::stopped_data_address)
6731         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6732
6733 2019-02-15  Tom Tromey  <tromey@adacore.com>
6734
6735         * ravenscar-thread.c: Fix some typos.
6736
6737 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6738             Tom Tromey  <tromey@adacore.com>
6739
6740         * ada-lang.c (ada_exception_sal): Change addr_string to a
6741         std::string.
6742         (create_ada_exception_catchpoint): Update.
6743
6744 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6745             Tom Tromey  <tromey@adacore.com>
6746
6747         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6748         (bp_location_ops): Remove.
6749         (base_breakpoint_allocate_location): Update.
6750         (free_bp_location): Update.
6751         * ada-lang.c (class ada_catchpoint_location)
6752         <ada_catchpoint_location>: Remove ops parameter.
6753         (ada_catchpoint_location_dtor): Remove.
6754         (ada_catchpoint_location_ops): Remove.
6755         (allocate_location_exception): Update.
6756         * breakpoint.h (struct bp_location_ops): Remove.
6757         (class bp_location) <bp_location>: Remove bp_location_ops
6758         parameter.
6759         <~bp_location>: Add destructor.
6760         <ops>: Remove.
6761
6762 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6763             Pedro Alves  <palves@redhat.com>
6764
6765         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6766         'PATH_MAX'.
6767
6768 2019-02-14  David Michael  <fedora.dm0@gmail.com>
6769             Samuel Thibault  <samuel.thibault@gnu.org>
6770             Thomas Schwinge  <thomas@codesourcery.com>
6771
6772         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6773         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6774
6775 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6776
6777         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6778         (check_empty): Use "const char *".
6779
6780         * gnu-nat.c (gnu_nat_target::detach): Instead of
6781         'detach_inferior (pid)' call
6782         'detach_inferior (find_inferior_pid (pid))'.
6783
6784         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6785         'nat/fork-inferior.o'.
6786         * gnu-nat.c: #include "nat/fork-inferior.h".
6787
6788         * gnu-nat.c (gnu_nat_target::detach): Instead of
6789         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6790         * gnu-nat.h: #include "inf-child.h".
6791         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6792         'i386_gnu_nat_target::fetch_registers'.
6793         (gnu_store_registers): Rename/move to
6794         'i386_gnu_nat_target::store_registers'.
6795
6796         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6797         * gnu-nat.h (mach_thread_info): New function.
6798         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6799
6800         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6801
6802 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6803
6804         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6805
6806 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6807
6808         * windows-nat.c (windows_add_thread): Add new parameter
6809         "main_thread_p" with default value set to false.  Update
6810         function documentation as well as all callers.
6811         (windows_delete_thread): Likewise.
6812         (fake_create_process): Update call to windows_add_thread.
6813         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6814         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6815         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6816         call to windows_delete_thread.
6817
6818 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6819
6820         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6821
6822 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6823
6824         * symfile.c (find_separate_debug_file): Use canonical path of
6825         sysroot with child_path instead of gdb_sysroot if it is valid.
6826
6827 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6828
6829         * symfile.c (find_separate_debug_file): Use child_path to
6830         determine if an object file is under a sysroot.
6831
6832 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6833
6834         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6835         unittests/child-path-selftests.c.
6836         * common/pathstuff.c (child_path): New function.
6837         * common/pathstuff.h (child_path): New prototype.
6838         * unittests/child-path-selftests.c: New file.
6839
6840 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6841
6842         * symfile.c (find_separate_debug_file): Look for separate debug
6843         files in debug directories under the sysroot.
6844
6845 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6846
6847         * symtab.h (struct minimal_symbol data_p): New const method.
6848         (struct minimal_symbol text_p): Likewise.
6849         * symtab.c (output_source_filename): Use file name style
6850         to print file name.
6851         (print_symbol_info): Likewise.
6852         (print_msymbol_info): Use address style to print addresses.
6853         Use function name style to print executable text symbols.
6854         (expand_symtab_containing_pc): Use data_p.
6855         (find_pc_sect_compunit_symtab): Likewise.
6856
6857 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6858
6859         * breakpoint.c (describe_other_breakpoints): Use address style
6860         to print addresses.
6861         (say_where): Likewise.
6862
6863 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6864
6865         * ada-typeprint.c (print_func_type): Print function name
6866         style to print function name.
6867         * c-typeprint.c (c_print_type_1): Likewise.
6868
6869 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6870
6871         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6872         for execve.
6873
6874 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6875
6876         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6877         type_stack.
6878
6879 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6880
6881         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6882         TYPE_CODE_REF types.
6883
6884 2019-02-08  Jim Wilson  <jimw@sifive.com>
6885
6886         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6887         (riscv_linux_fregset): New.
6888         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6889
6890 2019-02-07  Tom Tromey  <tom@tromey.com>
6891
6892         * thread.c (thread_cancel_execution_command): Update.
6893         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6894         methods.
6895         (struct thread_fsm_ops): Remove.
6896         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6897         (thread_fsm_should_stop, thread_fsm_return_value)
6898         (thread_fsm_set_finished, thread_fsm_finished_p)
6899         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6900         Don't declare.
6901         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6902         * infrun.c (clear_proceed_status_thread)
6903         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6904         (print_stop_event): Update.
6905         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6906         Add constructor.
6907         (step_command_fsm_ops): Remove.
6908         (new_step_command_fsm): Remove.
6909         (step_1): Update.
6910         (step_command_fsm::should_stop): Rename from
6911         step_command_fsm_should_stop.
6912         (step_command_fsm::clean_up): Rename from
6913         step_command_fsm_clean_up.
6914         (step_command_fsm::do_async_reply_reason): Rename from
6915         step_command_fsm_async_reply_reason.
6916         (struct until_next_fsm): Inherit from thread_fsm.  Add
6917         constructor.
6918         (until_next_fsm_ops): Remove.
6919         (new_until_next_fsm): Remove.
6920         (until_next_fsm::should_stop): Rename from
6921         until_next_fsm_should_stop.
6922         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6923         (until_next_fsm::do_async_reply_reason): Rename from
6924         until_next_fsm_async_reply_reason.
6925         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6926         constructor.  Change type of breakpoint.
6927         (finish_command_fsm_ops): Remove.
6928         (new_finish_command_fsm): Remove.
6929         (finish_command_fsm::should_stop): Rename from
6930         finish_command_fsm_should_stop.
6931         (finish_command_fsm::clean_up): Rename from
6932         finish_command_fsm_clean_up.
6933         (finish_command_fsm::return_value): Rename from
6934         finish_command_fsm_return_value.
6935         (finish_command_fsm::do_async_reply_reason): Rename from
6936         finish_command_fsm_async_reply_reason.
6937         (finish_command): Update.
6938         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6939         Add constructor.
6940         (call_thread_fsm_ops): Remove.
6941         (call_thread_fsm::call_thread_fsm): Rename from
6942         new_call_thread_fsm.
6943         (call_thread_fsm::should_stop): Rename from
6944         call_thread_fsm_should_stop.
6945         (call_thread_fsm::should_notify_stop): Rename from
6946         call_thread_fsm_should_notify_stop.
6947         (run_inferior_call, call_function_by_hand_dummy): Update.
6948         * cli/cli-interp.c (should_print_stop_to_console): Update.
6949         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6950         Add constructor.  Change type of location_breakpoint,
6951         caller_breakpoint.
6952         (until_break_fsm_ops): Remove.
6953         (new_until_break_fsm): Remove.
6954         (until_break_fsm::should_stop): Rename from
6955         until_break_fsm_should_stop.
6956         (until_break_fsm::clean_up): Rename from
6957         until_break_fsm_clean_up.
6958         (until_break_fsm::do_async_reply_reason): Rename from
6959         until_break_fsm_async_reply_reason.
6960         (until_break_command): Update.
6961         * thread-fsm.c: Remove.
6962         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6963
6964 2019-02-07  Tom Tromey  <tom@tromey.com>
6965
6966         * yy-remap.h: Add include guard.
6967         * xtensa-tdep.h: Add include guard.
6968         * xcoffread.h: Rename include guard.
6969         * varobj-iter.h: Add include guard.
6970         * tui/tui.h: Rename include guard.
6971         * tui/tui-winsource.h: Rename include guard.
6972         * tui/tui-wingeneral.h: Rename include guard.
6973         * tui/tui-windata.h: Rename include guard.
6974         * tui/tui-win.h: Rename include guard.
6975         * tui/tui-stack.h: Rename include guard.
6976         * tui/tui-source.h: Rename include guard.
6977         * tui/tui-regs.h: Rename include guard.
6978         * tui/tui-out.h: Rename include guard.
6979         * tui/tui-layout.h: Rename include guard.
6980         * tui/tui-io.h: Rename include guard.
6981         * tui/tui-hooks.h: Rename include guard.
6982         * tui/tui-file.h: Rename include guard.
6983         * tui/tui-disasm.h: Rename include guard.
6984         * tui/tui-data.h: Rename include guard.
6985         * tui/tui-command.h: Rename include guard.
6986         * tic6x-tdep.h: Add include guard.
6987         * target/waitstatus.h: Rename include guard.
6988         * target/wait.h: Rename include guard.
6989         * target/target.h: Rename include guard.
6990         * target/resume.h: Rename include guard.
6991         * target-float.h: Rename include guard.
6992         * stabsread.h: Add include guard.
6993         * rs6000-tdep.h: Add include guard.
6994         * riscv-fbsd-tdep.h: Add include guard.
6995         * regformats/regdef.h: Rename include guard.
6996         * record.h: Rename include guard.
6997         * python/python.h: Rename include guard.
6998         * python/python-internal.h: Rename include guard.
6999         * python/py-stopevent.h: Rename include guard.
7000         * python/py-ref.h: Rename include guard.
7001         * python/py-record.h: Rename include guard.
7002         * python/py-record-full.h: Rename include guard.
7003         * python/py-record-btrace.h: Rename include guard.
7004         * python/py-instruction.h: Rename include guard.
7005         * python/py-events.h: Rename include guard.
7006         * python/py-event.h: Rename include guard.
7007         * procfs.h: Add include guard.
7008         * proc-utils.h: Add include guard.
7009         * p-lang.h: Add include guard.
7010         * or1k-tdep.h: Rename include guard.
7011         * observable.h: Rename include guard.
7012         * nto-tdep.h: Rename include guard.
7013         * nat/x86-linux.h: Rename include guard.
7014         * nat/x86-linux-dregs.h: Rename include guard.
7015         * nat/x86-gcc-cpuid.h: Add include guard.
7016         * nat/x86-dregs.h: Rename include guard.
7017         * nat/x86-cpuid.h: Rename include guard.
7018         * nat/ppc-linux.h: Rename include guard.
7019         * nat/mips-linux-watch.h: Rename include guard.
7020         * nat/linux-waitpid.h: Rename include guard.
7021         * nat/linux-ptrace.h: Rename include guard.
7022         * nat/linux-procfs.h: Rename include guard.
7023         * nat/linux-osdata.h: Rename include guard.
7024         * nat/linux-nat.h: Rename include guard.
7025         * nat/linux-namespaces.h: Rename include guard.
7026         * nat/linux-btrace.h: Rename include guard.
7027         * nat/glibc_thread_db.h: Rename include guard.
7028         * nat/gdb_thread_db.h: Rename include guard.
7029         * nat/gdb_ptrace.h: Rename include guard.
7030         * nat/fork-inferior.h: Rename include guard.
7031         * nat/amd64-linux-siginfo.h: Rename include guard.
7032         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7033         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7034         * nat/aarch64-linux.h: Rename include guard.
7035         * nat/aarch64-linux-hw-point.h: Rename include guard.
7036         * mn10300-tdep.h: Add include guard.
7037         * mips-linux-tdep.h: Add include guard.
7038         * mi/mi-parse.h: Rename include guard.
7039         * mi/mi-out.h: Rename include guard.
7040         * mi/mi-main.h: Rename include guard.
7041         * mi/mi-interp.h: Rename include guard.
7042         * mi/mi-getopt.h: Rename include guard.
7043         * mi/mi-console.h: Rename include guard.
7044         * mi/mi-common.h: Rename include guard.
7045         * mi/mi-cmds.h: Rename include guard.
7046         * mi/mi-cmd-break.h: Rename include guard.
7047         * m2-lang.h: Add include guard.
7048         * location.h: Rename include guard.
7049         * linux-record.h: Rename include guard.
7050         * linux-nat.h: Add include guard.
7051         * linux-fork.h: Add include guard.
7052         * i386-darwin-tdep.h: Rename include guard.
7053         * hppa-linux-offsets.h: Add include guard.
7054         * guile/guile.h: Rename include guard.
7055         * guile/guile-internal.h: Rename include guard.
7056         * gnu-nat.h: Rename include guard.
7057         * gdb-stabs.h: Rename include guard.
7058         * frv-tdep.h: Add include guard.
7059         * f-lang.h: Add include guard.
7060         * event-loop.h: Add include guard.
7061         * darwin-nat.h: Rename include guard.
7062         * cp-abi.h: Rename include guard.
7063         * config/sparc/nm-sol2.h: Rename include guard.
7064         * config/nm-nto.h: Rename include guard.
7065         * config/nm-linux.h: Add include guard.
7066         * config/i386/nm-i386gnu.h: Rename include guard.
7067         * config/djgpp/nl_types.h: Rename include guard.
7068         * config/djgpp/langinfo.h: Rename include guard.
7069         * compile/gcc-cp-plugin.h: Add include guard.
7070         * compile/gcc-c-plugin.h: Add include guard.
7071         * compile/compile.h: Rename include guard.
7072         * compile/compile-object-run.h: Rename include guard.
7073         * compile/compile-object-load.h: Rename include guard.
7074         * compile/compile-internal.h: Rename include guard.
7075         * compile/compile-cplus.h: Rename include guard.
7076         * compile/compile-c.h: Rename include guard.
7077         * common/xml-utils.h: Rename include guard.
7078         * common/x86-xstate.h: Rename include guard.
7079         * common/version.h: Rename include guard.
7080         * common/vec.h: Rename include guard.
7081         * common/tdesc.h: Rename include guard.
7082         * common/selftest.h: Rename include guard.
7083         * common/scoped_restore.h: Rename include guard.
7084         * common/scoped_mmap.h: Rename include guard.
7085         * common/scoped_fd.h: Rename include guard.
7086         * common/safe-iterator.h: Rename include guard.
7087         * common/run-time-clock.h: Rename include guard.
7088         * common/refcounted-object.h: Rename include guard.
7089         * common/queue.h: Rename include guard.
7090         * common/ptid.h: Rename include guard.
7091         * common/print-utils.h: Rename include guard.
7092         * common/preprocessor.h: Rename include guard.
7093         * common/pathstuff.h: Rename include guard.
7094         * common/observable.h: Rename include guard.
7095         * common/netstuff.h: Rename include guard.
7096         * common/job-control.h: Rename include guard.
7097         * common/host-defs.h: Rename include guard.
7098         * common/gdb_wait.h: Rename include guard.
7099         * common/gdb_vecs.h: Rename include guard.
7100         * common/gdb_unlinker.h: Rename include guard.
7101         * common/gdb_unique_ptr.h: Rename include guard.
7102         * common/gdb_tilde_expand.h: Rename include guard.
7103         * common/gdb_sys_time.h: Rename include guard.
7104         * common/gdb_string_view.h: Rename include guard.
7105         * common/gdb_splay_tree.h: Rename include guard.
7106         * common/gdb_setjmp.h: Rename include guard.
7107         * common/gdb_ref_ptr.h: Rename include guard.
7108         * common/gdb_optional.h: Rename include guard.
7109         * common/gdb_locale.h: Rename include guard.
7110         * common/gdb_assert.h: Rename include guard.
7111         * common/filtered-iterator.h: Rename include guard.
7112         * common/filestuff.h: Rename include guard.
7113         * common/fileio.h: Rename include guard.
7114         * common/environ.h: Rename include guard.
7115         * common/common-utils.h: Rename include guard.
7116         * common/common-types.h: Rename include guard.
7117         * common/common-regcache.h: Rename include guard.
7118         * common/common-inferior.h: Rename include guard.
7119         * common/common-gdbthread.h: Rename include guard.
7120         * common/common-exceptions.h: Rename include guard.
7121         * common/common-defs.h: Rename include guard.
7122         * common/common-debug.h: Rename include guard.
7123         * common/cleanups.h: Rename include guard.
7124         * common/buffer.h: Rename include guard.
7125         * common/btrace-common.h: Rename include guard.
7126         * common/break-common.h: Rename include guard.
7127         * cli/cli-utils.h: Rename include guard.
7128         * cli/cli-style.h: Rename include guard.
7129         * cli/cli-setshow.h: Rename include guard.
7130         * cli/cli-script.h: Rename include guard.
7131         * cli/cli-interp.h: Rename include guard.
7132         * cli/cli-decode.h: Rename include guard.
7133         * cli/cli-cmds.h: Rename include guard.
7134         * charset-list.h: Add include guard.
7135         * buildsym-legacy.h: Rename include guard.
7136         * bfin-tdep.h: Add include guard.
7137         * ax.h: Rename include guard.
7138         * arm-linux-tdep.h: Add include guard.
7139         * arm-fbsd-tdep.h: Add include guard.
7140         * arch/xtensa.h: Rename include guard.
7141         * arch/tic6x.h: Add include guard.
7142         * arch/i386.h: Add include guard.
7143         * arch/arm.h: Rename include guard.
7144         * arch/arm-linux.h: Rename include guard.
7145         * arch/arm-get-next-pcs.h: Rename include guard.
7146         * arch/amd64.h: Add include guard.
7147         * arch/aarch64-insn.h: Rename include guard.
7148         * arch-utils.h: Rename include guard.
7149         * annotate.h: Add include guard.
7150         * amd64-darwin-tdep.h: Rename include guard.
7151         * aarch64-linux-tdep.h: Add include guard.
7152         * aarch64-fbsd-tdep.h: Add include guard.
7153         * aarch32-linux-nat.h: Add include guard.
7154
7155 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7156
7157         * macrotab.c (macro_define_internal): New function that
7158         factorizes macro_define_object_internal and macro_define_function
7159         code.
7160         (macro_define_object_internal): Use macro_define_internal.
7161         (macro_define_function): Likewise.
7162
7163 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7164
7165         * macrocmd.c (extract_identifier): Return
7166         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7167         callers.
7168
7169 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7170
7171         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7172
7173 2019-02-05  Tom Tromey  <tom@tromey.com>
7174
7175         * target.c (target_stack::unpush): Move assertion earlier.
7176
7177 2019-01-30  Tom Tromey  <tom@tromey.com>
7178
7179         PR python/23615:
7180         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7181         (gdbpy_parse_and_eval): Likewise.
7182         * python/python-internal.h (gdbpy_allow_threads): New class.
7183
7184 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7185
7186         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7187         (aarch64_fbsd_fpregmap): Move earlier.
7188         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7189         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7190         instead of individual calls to trad_frame_set_reg_addr.
7191         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7192         earlier.
7193         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7194         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7195         instead of individual calls to trad_frame_set_reg_addr.
7196
7197 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7198
7199         * CONTRIBUTE: Replace contribution list with wiki link.
7200
7201 2019-01-25  Tom Tromey  <tom@tromey.com>
7202
7203         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7204
7205 2019-01-25  Tom Tromey  <tom@tromey.com>
7206
7207         * xtensa-linux-nat.c: Fix common/ includes.
7208         * xml-support.h: Fix common/ includes.
7209         * xml-support.c: Fix common/ includes.
7210         * x86-linux-nat.c: Fix common/ includes.
7211         * windows-nat.c: Fix common/ includes.
7212         * varobj.h: Fix common/ includes.
7213         * varobj.c: Fix common/ includes.
7214         * value.c: Fix common/ includes.
7215         * valops.c: Fix common/ includes.
7216         * utils.c: Fix common/ includes.
7217         * unittests/xml-utils-selftests.c: Fix common/ includes.
7218         * unittests/utils-selftests.c: Fix common/ includes.
7219         * unittests/unpack-selftests.c: Fix common/ includes.
7220         * unittests/tracepoint-selftests.c: Fix common/ includes.
7221         * unittests/style-selftests.c: Fix common/ includes.
7222         * unittests/string_view-selftests.c: Fix common/ includes.
7223         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7224         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7225         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7226         * unittests/rsp-low-selftests.c: Fix common/ includes.
7227         * unittests/parse-connection-spec-selftests.c: Fix common/
7228         includes.
7229         * unittests/optional-selftests.c: Fix common/ includes.
7230         * unittests/offset-type-selftests.c: Fix common/ includes.
7231         * unittests/observable-selftests.c: Fix common/ includes.
7232         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7233         * unittests/memrange-selftests.c: Fix common/ includes.
7234         * unittests/memory-map-selftests.c: Fix common/ includes.
7235         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7236         * unittests/function-view-selftests.c: Fix common/ includes.
7237         * unittests/environ-selftests.c: Fix common/ includes.
7238         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7239         * unittests/common-utils-selftests.c: Fix common/ includes.
7240         * unittests/cli-utils-selftests.c: Fix common/ includes.
7241         * unittests/array-view-selftests.c: Fix common/ includes.
7242         * ui-file.c: Fix common/ includes.
7243         * tui/tui-io.c: Fix common/ includes.
7244         * tracepoint.h: Fix common/ includes.
7245         * tracepoint.c: Fix common/ includes.
7246         * tracefile-tfile.c: Fix common/ includes.
7247         * top.h: Fix common/ includes.
7248         * top.c: Fix common/ includes.
7249         * thread.c: Fix common/ includes.
7250         * target/waitstatus.h: Fix common/ includes.
7251         * target/waitstatus.c: Fix common/ includes.
7252         * target.h: Fix common/ includes.
7253         * target.c: Fix common/ includes.
7254         * target-memory.c: Fix common/ includes.
7255         * target-descriptions.c: Fix common/ includes.
7256         * symtab.h: Fix common/ includes.
7257         * symfile.c: Fix common/ includes.
7258         * stap-probe.c: Fix common/ includes.
7259         * spu-linux-nat.c: Fix common/ includes.
7260         * sparc-nat.c: Fix common/ includes.
7261         * source.c: Fix common/ includes.
7262         * solib.c: Fix common/ includes.
7263         * solib-target.c: Fix common/ includes.
7264         * ser-unix.c: Fix common/ includes.
7265         * ser-tcp.c: Fix common/ includes.
7266         * ser-pipe.c: Fix common/ includes.
7267         * ser-base.c: Fix common/ includes.
7268         * selftest-arch.c: Fix common/ includes.
7269         * s12z-tdep.c: Fix common/ includes.
7270         * rust-exp.y: Fix common/ includes.
7271         * rs6000-aix-tdep.c: Fix common/ includes.
7272         * riscv-tdep.c: Fix common/ includes.
7273         * remote.c: Fix common/ includes.
7274         * remote-notif.h: Fix common/ includes.
7275         * remote-fileio.h: Fix common/ includes.
7276         * remote-fileio.c: Fix common/ includes.
7277         * regcache.h: Fix common/ includes.
7278         * regcache.c: Fix common/ includes.
7279         * record-btrace.c: Fix common/ includes.
7280         * python/python.c: Fix common/ includes.
7281         * python/py-type.c: Fix common/ includes.
7282         * python/py-inferior.c: Fix common/ includes.
7283         * progspace.h: Fix common/ includes.
7284         * producer.c: Fix common/ includes.
7285         * procfs.c: Fix common/ includes.
7286         * proc-api.c: Fix common/ includes.
7287         * printcmd.c: Fix common/ includes.
7288         * ppc-linux-nat.c: Fix common/ includes.
7289         * parser-defs.h: Fix common/ includes.
7290         * osdata.c: Fix common/ includes.
7291         * obsd-nat.c: Fix common/ includes.
7292         * nat/x86-linux.c: Fix common/ includes.
7293         * nat/x86-linux-dregs.c: Fix common/ includes.
7294         * nat/x86-dregs.h: Fix common/ includes.
7295         * nat/x86-dregs.c: Fix common/ includes.
7296         * nat/ppc-linux.c: Fix common/ includes.
7297         * nat/mips-linux-watch.h: Fix common/ includes.
7298         * nat/mips-linux-watch.c: Fix common/ includes.
7299         * nat/linux-waitpid.c: Fix common/ includes.
7300         * nat/linux-ptrace.h: Fix common/ includes.
7301         * nat/linux-ptrace.c: Fix common/ includes.
7302         * nat/linux-procfs.c: Fix common/ includes.
7303         * nat/linux-personality.c: Fix common/ includes.
7304         * nat/linux-osdata.c: Fix common/ includes.
7305         * nat/linux-namespaces.c: Fix common/ includes.
7306         * nat/linux-btrace.h: Fix common/ includes.
7307         * nat/linux-btrace.c: Fix common/ includes.
7308         * nat/fork-inferior.c: Fix common/ includes.
7309         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7310         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7311         * nat/aarch64-linux.c: Fix common/ includes.
7312         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7313         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7314         * namespace.h: Fix common/ includes.
7315         * mips-linux-tdep.c: Fix common/ includes.
7316         * minsyms.c: Fix common/ includes.
7317         * mi/mi-parse.h: Fix common/ includes.
7318         * mi/mi-main.c: Fix common/ includes.
7319         * mi/mi-cmd-env.c: Fix common/ includes.
7320         * memrange.h: Fix common/ includes.
7321         * memattr.c: Fix common/ includes.
7322         * maint.h: Fix common/ includes.
7323         * maint.c: Fix common/ includes.
7324         * main.c: Fix common/ includes.
7325         * machoread.c: Fix common/ includes.
7326         * location.c: Fix common/ includes.
7327         * linux-thread-db.c: Fix common/ includes.
7328         * linux-nat.c: Fix common/ includes.
7329         * linux-fork.c: Fix common/ includes.
7330         * inline-frame.c: Fix common/ includes.
7331         * infrun.c: Fix common/ includes.
7332         * inflow.c: Fix common/ includes.
7333         * inferior.h: Fix common/ includes.
7334         * inferior.c: Fix common/ includes.
7335         * infcmd.c: Fix common/ includes.
7336         * inf-ptrace.c: Fix common/ includes.
7337         * inf-child.c: Fix common/ includes.
7338         * ia64-linux-nat.c: Fix common/ includes.
7339         * i387-tdep.c: Fix common/ includes.
7340         * i386-tdep.c: Fix common/ includes.
7341         * i386-linux-tdep.c: Fix common/ includes.
7342         * i386-linux-nat.c: Fix common/ includes.
7343         * i386-go32-tdep.c: Fix common/ includes.
7344         * i386-fbsd-tdep.c: Fix common/ includes.
7345         * i386-fbsd-nat.c: Fix common/ includes.
7346         * guile/scm-type.c: Fix common/ includes.
7347         * guile/guile.c: Fix common/ includes.
7348         * go32-nat.c: Fix common/ includes.
7349         * gnu-nat.c: Fix common/ includes.
7350         * gdbthread.h: Fix common/ includes.
7351         * gdbarch-selftests.c: Fix common/ includes.
7352         * gdb_usleep.c: Fix common/ includes.
7353         * gdb_select.h: Fix common/ includes.
7354         * gdb_bfd.c: Fix common/ includes.
7355         * gcore.c: Fix common/ includes.
7356         * fork-child.c: Fix common/ includes.
7357         * findvar.c: Fix common/ includes.
7358         * fbsd-nat.c: Fix common/ includes.
7359         * event-top.c: Fix common/ includes.
7360         * event-loop.c: Fix common/ includes.
7361         * dwarf2read.c: Fix common/ includes.
7362         * dwarf2loc.c: Fix common/ includes.
7363         * dwarf2-frame.c: Fix common/ includes.
7364         * dwarf-index-cache.c: Fix common/ includes.
7365         * dtrace-probe.c: Fix common/ includes.
7366         * disasm-selftests.c: Fix common/ includes.
7367         * defs.h: Fix common/ includes.
7368         * csky-tdep.c: Fix common/ includes.
7369         * cp-valprint.c: Fix common/ includes.
7370         * cp-support.h: Fix common/ includes.
7371         * cp-support.c: Fix common/ includes.
7372         * corelow.c: Fix common/ includes.
7373         * completer.h: Fix common/ includes.
7374         * completer.c: Fix common/ includes.
7375         * compile/compile.c: Fix common/ includes.
7376         * compile/compile-loc2c.c: Fix common/ includes.
7377         * compile/compile-cplus-types.c: Fix common/ includes.
7378         * compile/compile-cplus-symbols.c: Fix common/ includes.
7379         * command.h: Fix common/ includes.
7380         * cli/cli-dump.c: Fix common/ includes.
7381         * cli/cli-cmds.c: Fix common/ includes.
7382         * charset.c: Fix common/ includes.
7383         * build-id.c: Fix common/ includes.
7384         * btrace.h: Fix common/ includes.
7385         * btrace.c: Fix common/ includes.
7386         * breakpoint.h: Fix common/ includes.
7387         * breakpoint.c: Fix common/ includes.
7388         * ax.h:
7389         (enum agent_op): Fix common/ includes.
7390         * ax-general.c (struct aop_map): Fix common/ includes.
7391         * ax-gdb.c: Fix common/ includes.
7392         * auxv.c: Fix common/ includes.
7393         * auto-load.c: Fix common/ includes.
7394         * arm-tdep.c: Fix common/ includes.
7395         * arch/riscv.c: Fix common/ includes.
7396         * arch/ppc-linux-common.c: Fix common/ includes.
7397         * arch/i386.c: Fix common/ includes.
7398         * arch/arm.c: Fix common/ includes.
7399         * arch/arm-linux.c: Fix common/ includes.
7400         * arch/arm-get-next-pcs.c: Fix common/ includes.
7401         * arch/amd64.c: Fix common/ includes.
7402         * arch/aarch64.c: Fix common/ includes.
7403         * arch/aarch64-insn.c: Fix common/ includes.
7404         * arch-utils.c: Fix common/ includes.
7405         * amd64-windows-tdep.c: Fix common/ includes.
7406         * amd64-tdep.c: Fix common/ includes.
7407         * amd64-sol2-tdep.c: Fix common/ includes.
7408         * amd64-obsd-tdep.c: Fix common/ includes.
7409         * amd64-nbsd-tdep.c: Fix common/ includes.
7410         * amd64-linux-tdep.c: Fix common/ includes.
7411         * amd64-linux-nat.c: Fix common/ includes.
7412         * amd64-fbsd-tdep.c: Fix common/ includes.
7413         * amd64-fbsd-nat.c: Fix common/ includes.
7414         * amd64-dicos-tdep.c: Fix common/ includes.
7415         * amd64-darwin-tdep.c: Fix common/ includes.
7416         * agent.c: Fix common/ includes.
7417         * ada-lang.h: Fix common/ includes.
7418         * ada-lang.c: Fix common/ includes.
7419         * aarch64-tdep.c: Fix common/ includes.
7420
7421 2019-01-25  Tom Tromey  <tom@tromey.com>
7422
7423         * common/create-version.sh: Use common/version.h.
7424
7425 2019-01-24  Pedro Alves  <palves@redhat.com>
7426
7427         * infrun.c (signal_stop, signal_print, signal_program)
7428         (signal_catch, signal_pass): Now arrays instead of pointers.
7429         (update_signals_program_target, do_target_resume)
7430         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
7431         * linux-nat.c (linux_nat_target::pass_signals)
7432         (linux_nat_target::create_inferior, linux_nat_target::attach):
7433         Adjust.
7434         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
7435         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
7436         * procfs.c (procfs_target::pass_signals): Adjust.
7437         * record-full.c (record_full_target::resume): Adjust.
7438         * remote.c (remote_target::pass_signals)
7439         (remote_target::program_signals): Adjust.
7440         * target-debug.h (target_debug_print_signals): Now takes a
7441         gdb::array_view as parameter.  Adjust.
7442         * target.h (target_ops) <pass_signals, program_signals>: Replace
7443         pointer and length parameters with gdb::array_view.
7444         (target_pass_signals, target_program_signals): Likewise.
7445         * target-delegates.c: Regenerate.
7446
7447 2019-01-24  Pedro Alves  <palves@redhat.com>
7448
7449         * common/forward-scope-exit.h
7450         (forward_scope_exit::forward_scope_exit): Pass arguments to
7451         m_bind_function directly, instead of creating a std::bind and
7452         copying that.
7453
7454 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
7455
7456         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7457         for static members.
7458         (pass_in_v_vfp_candidate): Likewise.
7459
7460 2019-01-23  Tom Tromey  <tom@tromey.com>
7461             Pedro Alves  <palves@redhat.com>
7462
7463         * regcache.c (class regcache_invalidator): Remove.
7464         (regcache::raw_write): Use make_scope_exit.
7465
7466 2019-01-23  Tom Tromey  <tom@tromey.com>
7467
7468         * ui-out.h (class ui_out_emit_type): Update comment.
7469
7470 2019-01-23  Tom Tromey  <tom@tromey.com>
7471
7472         * infrun.c (fetch_inferior_event): Update comment.
7473
7474 2019-01-23  Tom Tromey  <tom@tromey.com>
7475             Pedro Alves  <palves@redhat.com>
7476
7477         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
7478         parameter.
7479         (fetch_inferior_event): Use SCOPE_EXIT.
7480
7481
7482 2019-01-23  Tom Tromey  <tom@tromey.com>
7483             Pedro Alves  <palves@redhat.com>
7484
7485         * infrun.c (disable_thread_events): Delete.
7486         (stop_all_threads): Use SCOPE_EXIT.
7487
7488 2019-01-23  Tom Tromey  <tom@tromey.com>
7489             Pedro Alves  <palves@redhat.com>
7490
7491         * symfile.c: Include forward-scope-exit.h.
7492         (clear_symtab_users_cleanup): Replace forward declaration with
7493         a FORWARD_SCOPE_EXIT.
7494         (syms_from_objfile_1): Use the forward_scope_exit and
7495         gdb::optional instead of cleanup_function.
7496         (reread_symbols): Use the forward_scope_exit instead of
7497         cleanup_function.
7498         (clear_symtab_users_cleanup): Remove function.
7499
7500 2019-01-23  Tom Tromey  <tom@tromey.com>
7501             Pedro Alves  <palves@redhat.com>
7502
7503         * linux-nat.c: Include scope-exit.h.
7504         (cleanup_target_stop): Remove.
7505         (linux_nat_target::static_tracepoint_markers_by_strid): Use
7506         SCOPE_EXIT.
7507
7508 2019-01-23  Tom Tromey  <tom@tromey.com>
7509             Pedro Alves  <palves@redhat.com>
7510
7511         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
7512         (call_function_by_hand_dummy): Use SCOPE_EXIT.
7513
7514 2019-01-23  Tom Tromey  <tom@tromey.com>
7515             Andrew Burgess  <andrew.burgess@embecosm.com>
7516             Pedro Alves  <palves@redhat.com>
7517
7518         * infrun.c (fetch_inferior_event): Use scope_exit.
7519         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
7520         * top.c (execute_command): Use scope_exit.
7521         * breakpoint.c (bpstat_do_actions): Use scope_exit.
7522         * utils.c (do_bpstat_clear_actions_cleanup)
7523         (make_bpstat_clear_actions_cleanup): Remove.
7524
7525 2019-01-23  Tom Tromey  <tom@tromey.com>
7526             Pedro Alves  <palves@redhat.com>
7527
7528         * infrun.c: Include "common/scope-exit.h"
7529         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
7530         (wait_for_inferior): Use SCOPE_EXIT.
7531         (fetch_inferior_event): Use scope_exit.
7532
7533 2019-01-23  Tom Tromey  <tom@tromey.com>
7534             Pedro Alves  <palves@redhat.com>
7535
7536         * breakpoint.c (create_breakpoint): Remove cleanup.
7537
7538 2019-01-23  Tom Tromey  <tom@tromey.com>
7539             Andrew Burgess  <andrew.burgess@embecosm.com>
7540             Pedro Alves  <palves@redhat.com>
7541
7542 2019-01-23  Pedro Alves  <palves@redhat.com>
7543
7544         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7545
7546 2019-01-23  Pedro Alves  <palves@redhat.com>
7547             Andrew Burgess  <andrew.burgess@embecosm.com>
7548
7549         * gdbthread.h: Include "common/forward-scope-exit.h".
7550         (scoped_finish_thread_state): Redefine custom class in terms of
7551         forward_scope_exit.
7552
7553 2019-01-23  Pedro Alves  <palves@redhat.com>
7554             Andrew Burgess  <andrew.burgess@embecosm.com>
7555
7556         * common/forward-scope-exit.h: New file.
7557
7558 2019-01-23  Pedro Alves  <palves@redhat.com>
7559             Andrew Burgess  <andrew.burgess@embecosm.com>
7560             Tom Tromey  <tom@tromey.com>
7561
7562         * common/scope-exit.h: New file.
7563
7564 2019-01-23  Pedro Alves  <palves@redhat.com>
7565
7566         * common/preprocessor.h (ESC): Rename to ...
7567         (ESC_PARENS): ... this.
7568         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7569         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7570
7571 2019-01-23  Tom Tromey  <tom@tromey.com>
7572
7573         * language.h (class scoped_switch_to_sym_language_if_auto):
7574         Initialize m_lang in both cases.
7575
7576 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7577
7578         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7579         with XCNEW.
7580
7581 2019-01-22  Tom Tromey  <tom@tromey.com>
7582
7583         * corelow.c: Do not include sys/file.h.
7584
7585 2019-01-22  Tom Tromey  <tom@tromey.com>
7586
7587         * tui/tui-wingeneral.h: Include gdb_curses.h.
7588
7589 2019-01-22  Tom Tromey  <tom@tromey.com>
7590
7591         * source-cache.h (class source_cache) <get_source_lines,
7592         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7593
7594 2019-01-22  Tom Tromey  <tom@tromey.com>
7595
7596         * remote-fileio.h (struct remote_target): Declare.
7597
7598 2019-01-22  Tom Tromey  <tom@tromey.com>
7599
7600         * python/py-arch.c: Do not include py-ref.h.
7601         * python/py-bpevent.c: Do not include py-ref.h.
7602         * python/py-cmd.c: Do not include py-ref.h.
7603         * python/py-continueevent.c: Do not include py-ref.h.
7604         * python/py-event.h: Do not include py-ref.h.
7605         * python/py-evtregistry.c: Do not include py-ref.h.
7606         * python/py-finishbreakpoint.c: Do not include py-ref.h.
7607         * python/py-frame.c: Do not include py-ref.h.
7608         * python/py-framefilter.c: Do not include py-ref.h.
7609         * python/py-function.c: Do not include py-ref.h.
7610         * python/py-infevents.c: Do not include py-ref.h.
7611         * python/py-linetable.c: Do not include py-ref.h.
7612         * python/py-objfile.c: Do not include py-ref.h.
7613         * python/py-param.c: Do not include py-ref.h.
7614         * python/py-prettyprint.c: Do not include py-ref.h.
7615         * python/py-progspace.c: Do not include py-ref.h.
7616         * python/py-symbol.c: Do not include py-ref.h.
7617         * python/py-symtab.c: Do not include py-ref.h.
7618         * python/py-type.c: Do not include py-ref.h.
7619         * python/py-unwind.c: Do not include py-ref.h.
7620         * python/py-utils.c: Do not include py-ref.h.
7621         * python/py-value.c: Do not include py-ref.h.
7622         * python/py-varobj.c: Do not include py-ref.h.
7623         * python/py-xmethods.c: Do not include py-ref.h.
7624         * python/python.c: Do not include py-ref.h.
7625         * varobj.c: Do not include py-ref.h.
7626
7627 2019-01-22  Tom Tromey  <tom@tromey.com>
7628
7629         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7630         keyword for bcache.
7631
7632 2019-01-22  Tom Tromey  <tom@tromey.com>
7633
7634         * compile/compile-cplus-types.c: Remove a comment by #include.
7635
7636 2019-01-22  Tom Tromey  <tom@tromey.com>
7637
7638         * compile/gcc-c-plugin.h: Include compile-internal.h.
7639
7640 2019-01-22  Tom Tromey  <tom@tromey.com>
7641
7642         * stabsread.c (EXTERN): Do not define.
7643         (symnum, next_symbol_text_func, processing_gcc_compilation)
7644         (within_function, global_sym_chain, global_stabs)
7645         (previous_stab_code, this_object_header_files)
7646         (n_this_object_header_files)
7647         (n_allocated_this_object_header_files): Define.
7648         * stabsread.h (EXTERN): Never define.  Use "extern".
7649
7650 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7651
7652         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
7653         history_value.
7654
7655 2019-01-21  Tom Tromey  <tom@tromey.com>
7656
7657         * ui-out.c: Fix includes.
7658         * tui/tui-source.c: Fix includes.
7659         * target.c: Fix includes.
7660         * remote.c: Fix includes.
7661         * regcache.c: Fix includes.
7662         * python/py-block.c: Fix includes.
7663         * printcmd.c: Fix includes.
7664         * or1k-tdep.c: Fix includes.
7665         * mi/mi-main.c: Fix includes.
7666         * m32r-tdep.c: Fix includes.
7667         * csky-tdep.c: Fix includes.
7668         * compile/compile-cplus-types.c: Fix includes.
7669         * cli/cli-interp.c: Fix includes.
7670
7671 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7672
7673         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7674         for padding.
7675
7676 2019-01-16  Tom Tromey  <tom@tromey.com>
7677
7678         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7679         earlier.
7680         (struct objfile) <msymbols_range>: Move from top level.
7681         <msymbols>: New method.
7682         (class objfile_msymbols): Remove.
7683         * symtab.c (default_collect_symbol_completion_matches_break_on):
7684         Update.
7685         * symmisc.c (dump_msymbols): Update.
7686         * stabsread.c (scan_file_globals): Update.
7687         * objc-lang.c (info_selectors_command, info_classes_command)
7688         (find_methods): Update.
7689         * minsyms.c (find_solib_trampoline_target): Update.
7690         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7691         * coffread.c (coff_symfile_read): Update.
7692         * ada-lang.c (ada_lookup_simple_minsym)
7693         (ada_collect_symbol_completion_matches): Update.
7694
7695 2019-01-16  Tom Tromey  <tom@tromey.com>
7696
7697         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7698         type.  Remove no-argument constructor.
7699         <iterator::operator++>: Simplify.
7700         <begin>: Update.
7701         <end>: Use minimal_symbol_count.
7702
7703 2019-01-16  Tom Tromey  <tom@tromey.com>
7704
7705         * objfiles.h (struct objfile) <psymtabs>: New method.
7706         (class objfile_psymtabs): Remove.
7707         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7708         typedef.
7709         <range>: New method.
7710         (require_partial_symbols): Change return type.
7711         * psymtab.c (require_partial_symbols)
7712         (psym_expand_symtabs_matching): Update.
7713         * mdebugread.c (parse_partial_symbols): Update.
7714         * dbxread.c (dbx_end_psymtab): Update.
7715
7716 2019-01-15  Tom Tromey  <tom@tromey.com>
7717
7718         * symtab.c (lookup_objfile_from_block)
7719         (lookup_symbol_in_objfile_symtabs)
7720         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7721         (find_line_symtab, info_sources_command)
7722         (default_collect_symbol_completion_matches_break_on)
7723         (make_source_files_completion_list): Update.
7724         * symmisc.c (print_objfile_statistics, dump_objfile)
7725         (maintenance_print_symbols, maintenance_info_symtabs)
7726         (maintenance_check_symtabs, maintenance_info_line_tables):
7727         Update.
7728         * source.c (select_source_symtab)
7729         (forget_cached_source_info_for_objfile): Update.
7730         * objfiles.h (class objfile_compunits): Remove.
7731         (struct objfile) <compunits_range>: New typedef.
7732         (compunits): New method.
7733         * objfiles.c (objfile_relocate1): Update.
7734         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7735         * maint.c (count_symtabs_and_blocks): Update.
7736         * linespec.c (iterate_over_all_matching_symtabs): Update.
7737         * cp-support.c (add_symbol_overload_list_qualified): Update.
7738         * coffread.c (coff_symtab_read): Update.
7739         * ada-lang.c (add_nonlocal_symbols)
7740         (ada_collect_symbol_completion_matches)
7741         (ada_add_global_exceptions): Update.
7742
7743 2019-01-15  Tom Tromey  <tom@tromey.com>
7744
7745         * progspace.h (program_space) <objfiles_safe_range>: New
7746         typedef.
7747         <objfiles_safe>: New method.
7748         * objfiles.h (class all_objfiles_safe): Remove.
7749         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7750         * jit.c (jit_inferior_exit_hook): Update.
7751
7752 2019-01-17  Tom Tromey  <tom@tromey.com>
7753
7754         * progspace.h (program_space) <objfiles_range>: New typedef.
7755         <objfiles>: New method.
7756         <objfiles_head>: Rename from objfiles.
7757         (object_files): Update.
7758         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7759         * guile/scm-pretty-print.c
7760         (ppscm_find_pretty_printer_from_objfiles): Update.
7761         * guile/scm-objfile.c (gdbscm_objfiles): Update.
7762         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7763         Update.
7764         * python/py-progspace.c (pspy_get_objfiles): Update.
7765         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7766         Update.
7767         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7768         (objfpy_lookup_objfile_by_build_id): Update.
7769         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7770         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7771         Update.
7772         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7773         (expand_symtab_containing_pc, lookup_objfile_from_block)
7774         (lookup_static_symbol, basic_lookup_transparent_type)
7775         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7776         (find_line_symtab, info_sources_command)
7777         (default_collect_symbol_completion_matches_break_on)
7778         (make_source_files_completion_list, find_main_name): Update.
7779         * symmisc.c (print_symbol_bcache_statistics)
7780         (print_objfile_statistics, maintenance_print_symbols)
7781         (maintenance_print_msymbols, maintenance_print_objfiles)
7782         (maintenance_info_symtabs, maintenance_check_symtabs)
7783         (maintenance_expand_symtabs, maintenance_info_line_tables):
7784         Update.
7785         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7786         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7787         (map_overlay_command, unmap_overlay_command)
7788         (simple_overlay_update, expand_symtabs_matching)
7789         (map_symbol_filenames): Update.
7790         * symfile-debug.c (set_debug_symfile): Update.
7791         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7792         Update.
7793         * source.c (select_source_symtab, forget_cached_source_info):
7794         Update.
7795         * solib.c (solib_read_symbols): Update.
7796         * solib-spu.c (append_ocl_sos): Update.
7797         * psymtab.c (maintenance_print_psymbols)
7798         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7799         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7800         * printcmd.c (info_symbol_command): Update.
7801         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7802         Update.
7803         * objfiles.h (class all_objfiles): Remove.
7804         * objfiles.c (have_partial_symbols, have_full_symbols)
7805         (have_minimal_symbols, qsort_cmp, update_section_map)
7806         (shared_objfile_contains_address_p)
7807         (default_iterate_over_objfiles_in_search_order): Update.
7808         * objc-lang.c (info_selectors_command, info_classes_command)
7809         (find_methods): Update.
7810         * minsyms.c (find_solib_trampoline_target): Update.
7811         * maint.c (maintenance_info_sections)
7812         (maintenance_translate_address, count_symtabs_and_blocks):
7813         Update.
7814         * main.c (captured_main_1): Update.
7815         * linux-thread-db.c (try_thread_db_load_from_pdir)
7816         (has_libpthread): Update.
7817         * linespec.c (iterate_over_all_matching_symtabs)
7818         (search_minsyms_for_name): Update.
7819         * jit.c (jit_find_objf_with_entry_addr): Update.
7820         * hppa-tdep.c (find_unwind_entry)
7821         (hppa_lookup_stub_minimal_symbol): Update.
7822         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7823         Update.
7824         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7825         (elf_gnu_ifunc_resolve_by_got): Update.
7826         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7827         * dwarf-index-write.c (save_gdb_index_command): Update.
7828         * cp-support.c (add_symbol_overload_list_qualified): Update.
7829         * breakpoint.c (create_overlay_event_breakpoint)
7830         (create_longjmp_master_breakpoint)
7831         (create_std_terminate_master_breakpoint)
7832         (create_exception_master_breakpoint): Update.
7833         * blockframe.c (find_pc_partial_function): Update.
7834         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7835         (ada_collect_symbol_completion_matches)
7836         (ada_add_global_exceptions): Update.
7837
7838 2019-01-17  Tom Tromey  <tom@tromey.com>
7839
7840         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7841         declare VEC.
7842         (solib_target_parse_libraries): Change return type.
7843         (library_list_start_segment, library_list_start_section)
7844         (library_list_end_library, library_list_start_library); Update.
7845         (solib_target_free_library_list): Remove.
7846         (solib_target_parse_libraries): Remove cleanup.  Change return
7847         type.
7848         (solib_target_current_sos): Update.
7849
7850 2019-01-17  Tom Tromey  <tromey@bapiya>
7851
7852         * valprint.c: Replace "the the" with "the".
7853         * symtab.c: Replace "the the" with "the".
7854         * solib.c: Replace "the the" with "the".
7855         * solib-dsbt.c: Replace "the the" with "the".
7856         * linespec.c: Replace "the the" with "the".
7857         * dwarf2loc.h: Replace "the the" with "the".
7858         * amd64-windows-tdep.c: Replace "the the" with "the".
7859         * aarch64-tdep.c: Replace "the the" with "the".
7860
7861 2019-01-16  Keith Seitz  <keiths@redhat.com>
7862
7863         PR gdb/23773
7864         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7865         <builder>: Rename to ..
7866         <m_builder>: ... this and make private.
7867         (dwarf2_cu::get_builder): New method.  Change all users of
7868         `builder' to use this method.
7869         (dwarf2_start_symtab): Move to ...
7870         (dwarf2_cu::start_symtab): ... here.  Update all callers
7871         (setup_type_unit_groups): Move to ...
7872         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7873         callers.
7874         (dwarf2_cu::reset_builder): New method.
7875         (process_full_compunit, process_full_type_unit): Use
7876         dwarf2_cu::reset_builder.
7877         (follow_die_offset): Record the ancestor CU if it is different
7878         from the followed DIE's CU.
7879         (follow_die_sig_1): Likewise.
7880
7881 2019-01-15  Tom Tromey  <tom@tromey.com>
7882
7883         * remote.c (class remote_state) <buf>: Now a char_vector.
7884         <buf_size>: Remove.
7885         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7886         parameter.
7887         (remote_target::getpkt_or_notif_sane_1)
7888         (remote_target::getpkt_sane)
7889         (remote_target::getpkt_or_notif_sane): Likewise.
7890         (class remote_target) <putpkt>: New overload.
7891         (remote_target::read_frame): Change type of "buf_p".  Remove
7892         sizeof_p parameter.
7893         (packet_ok): New overload.
7894         (packet_check_result): New overload.
7895         Update all uses.
7896
7897 2019-01-14  Tom Tromey  <tom@tromey.com>
7898
7899         * remote-notif.c (handle_notification, remote_notif_ack)
7900         (remote_notif_parse): Make "buf" const.
7901         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7902         const.
7903         (remote_notif_parse, remote_notif_ack, handle_notification):
7904         Likewise.
7905         * remote.c (remote_notif_stop_parse): Make "buf" const.
7906         (remote_target::remote_parse_stop_reply): Make "buf" const.
7907         (remote_notif_stop_ack): Make "buf" const.
7908
7909 2019-01-14  Tom Tromey  <tom@tromey.com>
7910
7911         * remote.c (remote_console_output): Make parameter const.
7912
7913 2019-01-14  Tom Tromey  <tom@tromey.com>
7914
7915         * target-debug.h (target_debug_print_signals): Constify.
7916         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7917         * procfs.c (procfs_target::pass_signals): Update.
7918         * linux-nat.c (linux_nat_target::pass_signals): Update.
7919         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7920         * target-delegates.c: Rebuild.
7921         * remote.c (remote_target::program_signals): Update.
7922         (remote_target::pass_signals): Update.
7923         * target.c (target_pass_signals): Constify argument.
7924         (target_program_signals): Likewise.
7925         * target.h (struct target_ops) <pass_signals, program_signals>:
7926         Constify argument.
7927         (target_pass_signals, target_program_signals): Constify argument.
7928
7929 2019-01-14  Tom Tromey  <tom@tromey.com>
7930
7931         PR tui/28819:
7932         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7933
7934 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7935
7936         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7937         field.
7938         * rs6000-tdep.c: Include reggroups.h.
7939         (IS_V_ALIAS_PSEUDOREG): Define.
7940         (rs6000_register_name): Return names for the "vX" aliases.
7941         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7942         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7943         aliases.  Call default_register_reggroup_p for all other
7944         pseudo-registers.
7945         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7946         New functions.
7947         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7948         Handle "vX" aliases.
7949         (v_alias_pseudo_register_collect): New function.
7950         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7951         (rs6000_gdbarch_init): Initialize "vX" aliases as
7952         pseudo-registers.  Restore registration of
7953         rs6000_pseudo_register_reggroup_p with
7954         set_tdesc_pseudo_register_reggroup_p.
7955
7956 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7957
7958         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7959         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7960         set_gdbarch_num_pseudo_regs.
7961
7962 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7963
7964         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7965         Remove arg prefixname, add do_set and do_show.
7966         Add member functions set_list and show_list.
7967         * cli/cli-style.c (class cli_style_option): Update accordingly.
7968         (style_set_list): Move to file scope.
7969         (style_show_list): Likewise.
7970         (set_style): Call help_list.
7971         (show_style): Call cmd_show_list.
7972         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7973         Update to use the new macro.
7974
7975 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7976
7977         * ada-lang.c (_initialize_ada_language): Expand the help text
7978         for the "catch exception" command.
7979
7980 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7981
7982         * symtab.c (matching_obj_sections): Initialize obj,
7983         declare it closer to its usage.
7984
7985 2019-01-10  Tom Tromey  <tom@tromey.com>
7986
7987         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7988         (basic_inf_threads_range): Remove.
7989         (inf_threads_range, inf_non_exited_threads_range)
7990         (safe_inf_threads_range): Use next_adapter.
7991
7992 2019-01-10  Keith Seitz  <keiths@redhat.com>
7993
7994         PR gdb/23712
7995         PR symtab/23010
7996         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7997         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7998
7999 2019-01-10  Keith Seitz  <keiths@redhat.com>
8000
8001         PR gdb/23712
8002         PR symtab/23010
8003         * dictionary.c (pending_to_vector): Remove.
8004         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8005         Remove _1 suffix, replacing functions of the same name.  Update
8006         all callers.
8007         (dict_create_hashed, dict_create_hashed_expandable)
8008         (dict_create_linear, dict_create_linear_expandable, dict_free)
8009         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8010         Make functions static.
8011
8012 2019-01-10  Keith Seitz  <keiths@redhat.com>
8013
8014         PR gdb/23712
8015         PR symtab/23010
8016         * dictionary.h (struct dictionary): Replace declaration with
8017         multidictionary.
8018         (dict_create_hashed, dict_create_hashed_expandable)
8019         (dict_create_linear, dict_create_linear_expandable)
8020         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8021         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8022         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8023         taking multidictionary argument.
8024         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8025         * block.h (struct block) <dict>: Change to multidictionary
8026         and rename `multidict'.
8027         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8028         symmisc.c: Update all dictionary references to multidictionary.
8029
8030 2019-01-10  Keith Seitz  <keiths@redhat.com>
8031
8032         PR gdb/23712
8033         PR symtab/23010
8034         * dictionary.c: Include unordered_map.
8035         (pending_to_vector): New function.
8036         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8037         Rewrite the non-"_1" functions to take vector instead
8038         of linked list.
8039         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8040         "new" _1 versions of the same name.
8041         (multidictionary): Define.
8042         (std::hash<enum language): New definition.
8043         (collate_pending_symbols_by_language, mdict_create_hashed)
8044         (mdict_create_hashed_expandable, mdict_create_linear)
8045         (mdict_create_linear_expandable, mdict_free)
8046         (find_language_dictionary, create_new_language_dictionary)
8047         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8048         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8049         (mdict_size, mdict_empty): New functions.
8050         * dictionary.h (mdict_iterator): Define.
8051
8052 2019-01-10  Pedro Alves  <palves@redhat.com>
8053
8054         * breakpoint.c (read_uploaded_action)
8055         (create_tracepoint_from_upload): Adjust to use
8056         gdb::unique_xmalloc_ptr.
8057         * ctf.c (ctf_write_uploaded_tp):
8058         (SET_ARRAY_FIELD): Use emplace_back.
8059         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8060         * tracefile-tfile.c (tfile_write_uploaded_tp):
8061         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8062         gdb::unique_xmalloc_ptr.
8063         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8064         at_string, cond_string, cmd_strings>: Replace char pointers
8065         with gdb::unique_xmalloc_ptr.
8066
8067 2019-01-10  Pedro Alves  <palves@redhat.com>
8068
8069         * solib-target.c (library_list_start_library): Don't xstrdup name.
8070
8071 2019-01-10  Pedro Alves  <palves@redhat.com>
8072
8073         * mdebugread.c (parse_partial_symbols): Use
8074         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8075
8076 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8077
8078         * linux-fork.c (scoped_switch_fork_info)
8079         <~scoped_switch_fork_info>: Fix incorrect variable name.
8080
8081 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8082
8083         * linux-fork.c (scoped_switch_fork_info)
8084         <scoped_switch_fork_info>: Make explicit.
8085         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8086
8087 2019-01-10  Tom Tromey  <tom@tromey.com>
8088
8089         * objfiles.h (objfile::reset_psymtabs): Update.
8090         * objfiles.c (objfile::objfile): Update.
8091         * psymtab.h (psymtab_storage::obstack): Update.
8092         (psymtab_storage::m_obstack): Use gdb::optional.
8093         (class psymtab_storage): Update comment.  Remove objfile
8094         parameter.
8095         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8096
8097 2019-01-10  Tom Tromey  <tom@tromey.com>
8098
8099         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8100         <free_psymtabs>: Now private.
8101         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8102         (allocate_psymtab): Use new method.
8103
8104 2019-01-10  Tom Tromey  <tom@tromey.com>
8105
8106         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8107         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8108         * mdebugread.c (parse_partial_symbols): Use
8109         allocate_dependencies.
8110         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8111         allocate_dependencies.
8112         (process_psymtab_comp_unit_reader)
8113         (build_type_psymtab_dependencies): Likewise.
8114         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8115
8116 2019-01-10  Tom Tromey  <tom@tromey.com>
8117
8118         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8119         PSYMBOL_SET_LANGUAGE.
8120         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8121
8122 2019-01-10  Tom Tromey  <tom@tromey.com>
8123
8124         * psymtab.h (psymtab_storage::obstack): New method.
8125         <m_obstack>: Rename from obstack; now private.
8126         * psymtab.c (psymtab_storage): Update.
8127         * dwarf2read.c (create_addrmap_from_index)
8128         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8129         Update.
8130
8131 2019-01-10  Tom Tromey  <tom@tromey.com>
8132
8133         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8134         * objfiles.h (objfile::reset_psymtabs): New method.
8135
8136 2019-01-10  Tom Tromey  <tom@tromey.com>
8137
8138         * symmisc.c (print_symbol_bcache_statistics): Update.
8139         (print_objfile_statistics): Update.
8140         * symfile.c (reread_symbols): Update.
8141         * psymtab.h (class psymtab_storage): New.
8142         * psymtab.c (psymtab_storage): New constructor.
8143         (~psymtab_storage): New destructor.
8144         (require_partial_symbols): Update.
8145         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8146         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8147         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8148         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8149         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8150         (start_psymtab_common, end_psymtab_common)
8151         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8152         (allocate_psymtab): Update.
8153         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8154         Update.
8155         (dump_psymtab_addrmap, maintenance_print_psymbols)
8156         (maintenance_check_psymtabs): Update.
8157         (class objfile_psymtabs): Move to objfiles.h.
8158         * psympriv.h (discard_psymtab): Now inline.
8159         (psymtab_discarder::psymtab_discarder): Update.
8160         (psymtab_discarder::~psymtab_discarder): Update.
8161         (ALL_OBJFILE_PSYMTABS): Rewrite.
8162         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8163         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8164         Remove fields.
8165         <partial_symtabs>: New field.
8166         (class objfile_psymtabs): Move from psymtab.h.  Update.
8167         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8168         psymbol_cache.
8169         (objfile::~objfile): Don't destroy psymbol_cache.
8170         * mdebugread.c (parse_partial_symbols): Update.
8171         * dwarf2read.c (create_addrmap_from_index)
8172         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8173         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8174         (add_partial_subprogram, dwarf2_ranges_read): Update.
8175         * dwarf-index-write.c (write_address_map)
8176         (write_one_signatured_type, recursively_write_psymbols)
8177         (class debug_names, class debug_names, write_psymtabs_to_index):
8178         Update.
8179
8180 2019-01-10  Tom Tromey  <tom@tromey.com>
8181
8182         * symtab.h (SYMBOL_SET_NAMES): Update.
8183         (symbol_set_names): Update.
8184         (MSYMBOL_SET_NAMES): Update.
8185         * symtab.c (symbol_set_names): Change argument to be an
8186         objfile_per_bfd_storage.
8187         * psymtab.c (add_psymbol_to_bcache): Update.
8188         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8189
8190 2019-01-10  Tom Tromey  <tom@tromey.com>
8191
8192         * symtab.c (create_demangled_names_hash): Change argument to be an
8193         objfile_per_bfd_storage.
8194         (symbol_set_names): Update.
8195
8196 2019-01-10  Tom Tromey  <tom@tromey.com>
8197
8198         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8199         init_psymbol_list.
8200         * psymtab.c (init_psymbol_list): Do nothing if already called.
8201         * psympriv.h (init_psymbol_list): Add comment.
8202         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8203         init_psymbol_list.
8204         * dbxread.c (dbx_symfile_read): Unconditionally call
8205         init_psymbol_list.
8206
8207 2019-01-10  Tom Tromey  <tom@tromey.com>
8208
8209         * xcoffread.c (scan_xcoff_symtab): Update.
8210         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8211         "where".
8212         * mdebugread.c (parse_partial_symbols)
8213         (handle_psymbol_enumerators): Update.
8214         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8215         * dbxread.c (read_dbx_symtab): Update.
8216         * psympriv.h (psymbol_placement): New enum.
8217         (add_psymbol_to_list): Update.
8218
8219 2019-01-10  Tom Tromey  <tom@tromey.com>
8220
8221         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8222         static_psymbols parameters.
8223         (scan_xcoff_symtab): Update.
8224         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8225         static_psymbols parameters.
8226         * psympriv.h (start_psymtab_common): Update.
8227         * mdebugread.c (parse_partial_symbols): Update.
8228         * dwarf2read.c (create_partial_symtab): Update.
8229         * dbxread.c (read_dbx_symtab): Update.
8230         (start_psymtab): Remove global_psymbols and static_psymbols
8231         parameters.
8232
8233 2019-01-10  Tom Tromey  <tom@tromey.com>
8234
8235         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8236         * psymtab.c (allocate_psymtab): Add comment.
8237         * psympriv.h (allocate_psymtab): Add comment.
8238         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8239         initializations.
8240         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8241
8242 2019-01-10  Tom Tromey  <tom@tromey.com>
8243
8244         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8245         Don't declare.
8246         * mipsread.c: Include mdebugread.h.
8247         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8248         Declare.
8249         * elfread.c: Include mdebugread.h.
8250
8251 2019-01-09  Tom Tromey  <tom@tromey.com>
8252
8253         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8254         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8255         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8256         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8257         (psym_lookup_symbol, psym_find_last_source_symtab)
8258         (psym_forget_cached_source_info, psym_print_stats)
8259         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8260         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8261         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8262         (psym_find_compunit_symtab_by_address)
8263         (maintenance_print_psymbols, maintenance_info_psymtabs)
8264         (maintenance_check_psymtabs): Use ranged for.
8265         * psymtab.h (class objfile_psymtabs): New.
8266         (require_partial_symbols): Return objfile_psymtabs.
8267         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8268
8269 2019-01-09  Tom Tromey  <tom@tromey.com>
8270
8271         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8272         (find_pc_mapped_section, list_overlays_command)
8273         (map_overlay_command, unmap_overlay_command)
8274         (simple_overlay_update): Use all_objfiles.
8275         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8276         * printcmd.c (info_symbol_command): Use all_objfiles.
8277         * objfiles.h (ALL_OBJSECTIONS): Remove.
8278         * maint.c (maintenance_translate_address): Use all_objfiles.
8279         * gcore.c (gcore_create_callback): Use all_objfiles.
8280         (objfile_find_memory_regions): Likewise.
8281
8282 2019-01-09  Tom Tromey  <tom@tromey.com>
8283
8284         * symtab.c (find_line_symtab, info_sources_command)
8285         (make_source_files_completion_list): Use objfile_compunits.
8286         * source.c (select_source_symtab): Use objfile_compunits.
8287         * objfiles.h (struct objfile): Update comment.
8288         (ALL_OBJFILES): Remove.
8289         (ALL_FILETABS): Remove.
8290         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8291         objfile_compunits.
8292
8293 2019-01-09  Tom Tromey  <tom@tromey.com>
8294
8295         * symmisc.c (print_objfile_statistics, dump_objfile)
8296         (maintenance_print_symbols): Use compunit_filetabs.
8297         * source.c (forget_cached_source_info_for_objfile): Use
8298         compunit_filetabs.
8299         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8300         (ALL_FILETABS): Use compunit_filetabs.
8301         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8302         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8303
8304 2019-01-09  Tom Tromey  <tom@tromey.com>
8305
8306         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8307         (compunit_filetabs): New.
8308         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8309         compunit_filetabs.
8310         (info_sources_command, make_source_files_completion_list): Remove
8311         declaration.
8312         * symmisc.c (print_objfile_statistics, dump_objfile)
8313         (maintenance_print_symbols): Remove declaration.
8314         (maintenance_info_symtabs): Use compunit_filetabs.
8315         (maintenance_info_line_tables): Likewise.
8316         * source.c (select_source_symtab): Change local variable name.
8317         (forget_cached_source_info_for_objfile): Remove declaration.
8318         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8319         * objfiles.c (objfile_relocate1): Remove declaration.
8320         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8321         declaration.
8322         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8323         * coffread.c (coff_symtab_read): Remove declaration.
8324         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8325         compunit_filetabs.
8326
8327 2019-01-09  Tom Tromey  <tom@tromey.com>
8328
8329         * symtab.c (lookup_objfile_from_block)
8330         (find_pc_sect_compunit_symtab, search_symbols)
8331         (default_collect_symbol_completion_matches_break_on): Use
8332         objfile_compunits.
8333         * objfiles.h (ALL_COMPUNITS): Remove.
8334         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8335         * cp-support.c (add_symbol_overload_list_qualified): Use
8336         objfile_compunits.
8337         * ada-lang.c (ada_collect_symbol_completion_matches)
8338         (ada_add_global_exceptions): Use objfile_compunits.
8339
8340 2019-01-09  Tom Tromey  <tom@tromey.com>
8341
8342         * source.c (select_source_symtab)
8343         (forget_cached_source_info_for_objfile): Remove declaration.
8344         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8345         declaration.
8346         * maint.c (count_symtabs_and_blocks): Remove declaration.
8347         * cp-support.c (add_symbol_overload_list_qualified): Remove
8348         declaration.
8349         * coffread.c (coff_symtab_read): Remove declaration.
8350         * symtab.c (lookup_symbol_in_objfile_symtabs)
8351         (basic_lookup_transparent_type_1): Use objfile_compunits.
8352         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8353         (info_sources_command, search_symbols)
8354         (default_collect_symbol_completion_matches_break_on)
8355         (make_source_files_completion_list): Remove declaration.
8356         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8357         (ada_collect_symbol_completion_matches)
8358         (ada_add_global_exceptions): Remove declaration.
8359         * linespec.c (iterate_over_all_matching_symtabs): Use
8360         objfile_compunits.
8361         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8362         (class objfile_compunits): New.
8363         (ALL_COMPUNITS): Use objfile_compunits.
8364         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8365         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8366         objfile_compunits.
8367         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8368
8369 2019-01-09  Tom Tromey  <tom@tromey.com>
8370
8371         * symtab.c (search_symbols)
8372         (default_collect_symbol_completion_matches_break_on): Use
8373         objfile_msymbols.
8374         * ada-lang.c (ada_lookup_simple_minsym)
8375         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8376         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8377         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8378         objfile_msymbols.
8379         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8380         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8381         * objc-lang.c (find_methods): Use objfile_msymbols.
8382         (info_selectors_command, info_classes_command): Likewise.
8383         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8384         * objfiles.h (class objfile_msymbols): New.
8385         (ALL_OBJFILE_MSYMBOLS): Remove.
8386         (ALL_MSYMBOLS): Remove.
8387
8388 2019-01-09  Tom Tromey  <tom@tromey.com>
8389
8390         * common/next-iterator.h (next_adapter): Add Iterator template
8391         parameter.
8392         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8393         (class all_objfiles_safe): New.
8394         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8395         * objfiles.c (put_objfile_before): Update comment.
8396         (add_separate_debug_objfile): Likewise.
8397         (free_all_objfiles): Use all_objfiles_safe.
8398         (objfile_purge_solibs): Likewise.
8399
8400 2019-01-09  Tom Tromey  <tom@tromey.com>
8401
8402         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8403         (expand_symtab_containing_pc, lookup_static_symbol)
8404         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8405         (find_symbol_at_address, find_line_symtab, find_main_name): Use
8406         all_objfiles.
8407         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8408         * breakpoint.c (create_overlay_event_breakpoint)
8409         (create_longjmp_master_breakpoint)
8410         (create_std_terminate_master_breakpoint)
8411         (create_exception_master_breakpoint): Use all_objfiles.
8412         * linux-thread-db.c (try_thread_db_load_from_pdir)
8413         (has_libpthread): Use all_objfiles.
8414         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
8415         * linespec.c (iterate_over_all_matching_symtabs)
8416         (search_minsyms_for_name): Use all_objfiles.
8417         * maint.c (maintenance_info_sections): Use all_objfiles.
8418         * main.c (captured_main_1): Use all_objfiles.
8419         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
8420         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
8421         * guile/scm-pretty-print.c
8422         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
8423         * solib-spu.c (append_ocl_sos): Use all_objfiles.
8424         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
8425         (maintenance_print_msymbols): Use all_objfiles.
8426         * source.c (select_source_symtab): Use all_objfiles.
8427         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
8428         * symfile.c (remove_symbol_file_command)
8429         (expand_symtabs_matching, map_symbol_filenames): Use
8430         all_objfiles.
8431         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
8432         all_objfiles.
8433         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
8434         * objc-lang.c (find_methods): Use all_objfiles.
8435         * objfiles.c (have_partial_symbols, have_full_symbols)
8436         (have_minimal_symbols, qsort_cmp)
8437         (default_iterate_over_objfiles_in_search_order): Use
8438         all_objfiles.
8439         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
8440         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
8441         (maintenance_check_psymtabs): Use all_objfiles.
8442         (ALL_PSYMTABS): Remove.
8443         * compile/compile-object-run.c (do_module_cleanup): Use
8444         all_objfiles.
8445         * blockframe.c (find_pc_partial_function): Use all_objfiles.
8446         * cp-support.c (add_symbol_overload_list_qualified): Use
8447         all_objfiles.
8448         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8449         Use all_objfiles.
8450         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
8451         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
8452         all_objfiles.
8453         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8454         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
8455         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8456         Uses all_objfiles.
8457         * solib.c (solib_read_symbols): Use all_objfiles
8458
8459 2019-01-09  Tom Tromey  <tom@tromey.com>
8460
8461         * probe.c (parse_probes_in_pspace): Use all_objfiles.
8462         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
8463         all_objfiles.
8464         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
8465         * symmisc.c (print_symbol_bcache_statistics)
8466         (print_objfile_statistics, maintenance_print_objfiles)
8467         (maintenance_info_symtabs, maintenance_check_symtabs)
8468         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
8469         all_objfiles.
8470         * source.c (forget_cached_source_info): Use all_objfiles.
8471         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
8472         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8473         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
8474         * objfiles.c (update_section_map): Use all_objfiles.
8475         (shared_objfile_contains_address_p): Likewise.
8476         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
8477         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
8478
8479 2019-01-09  Tom Tromey  <tom@tromey.com>
8480
8481         * common/next-iterator.h: New file.
8482         * objfiles.h (class all_objfiles): New.
8483         (struct objfile_iterator): New.
8484
8485 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8486
8487         * NEWS: Move the description of the changed "frame", "select-frame",
8488          and "info frame" commands to the Changed commands section.
8489
8490 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
8491
8492         * gdbtypes.c (check_stub_method_group): Remove handling of old
8493         mangling schemes.
8494         * linespec.c (find_methods): Likewise.
8495         * stabsread.c (read_member_functions): Likewise.
8496         * valops.c (search_struct_method): Likewise.
8497         (value_struct_elt_for_reference): Likewise.
8498         * NEWS: Mention this change.
8499
8500 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8501
8502         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
8503         print_source_lines.
8504         * source.c (print_source_lines_base): Update line number check.
8505         (print_source_lines): New function.
8506         (source_lines_range::source_lines_range): New function.
8507         * source.h (class source_lines_range): New class.
8508         (print_source_lines): New declaration.
8509
8510 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8511
8512         * linespec.c (linespec_state_destructor): Free self->canonical_names.
8513
8514 2019-01-08  Tom Tromey  <tom@tromey.com>
8515             Simon Marchi  <simon.marchi@ericsson.com>
8516
8517         PR gdb/24060
8518         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
8519         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
8520         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8521         * f-exp.y (DOLLAR_VARIABLE): Likewise.
8522         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
8523         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8524
8525 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8526
8527         * source.c (select_source_symtab): Move header comment to
8528         declaration in source.h.
8529         (forget_cached_source_info_for_objfile): Likewise.
8530         (forget_cached_source_info): Likewise.
8531         (identify_source_line): Likewise.
8532         * source.h (identify_source_line): Move declaration from symtab.h
8533         and add comment from source.c
8534         (print_source_lines): Likewise.
8535         (forget_cached_source_info_for_objfile): Likewise.
8536         (forget_cached_source_info): Likewise.
8537         (select_source_symtab): Likewise.
8538         (enum print_source_lines_flag): Move definition from symtab.h.
8539         * symtab.h (identify_source_line): Move declaration to source.h.
8540         (print_source_lines): Likewise.
8541         (forget_cached_source_info_for_objfile): Likewise.
8542         (forget_cached_source_info): Likewise.
8543         (select_source_symtab): Likewise.
8544         (enum print_source_lines_flag): Move definition to source.h.
8545         * tui/tui-hooks.c: Add 'source.h' include.
8546
8547 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8548
8549         * source.c (print_source_lines_base): Handle requests to print
8550         reverse line number sequences, and guard against empty lines
8551         string.
8552
8553 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8554
8555         * source.c (print_source_lines_base): Fix skip of '\r' if next
8556         character is '\n'.
8557
8558 2019-01-06  Tom Tromey  <tom@tromey.com>
8559
8560         * c-exp.y (struct c_parse_state) <macro_original_text,
8561         expansion_obstack>: New member.
8562         (macro_original_text, expansion_obstack): Remove globals.
8563         (scan_macro_expansion, scanning_macro_expansion)
8564         (finished_macro_expansion): Update.
8565         (scan_macro_cleanup): Remove.
8566         (yylex, c_parse): Update.
8567
8568 2019-01-06  Tom Tromey  <tom@tromey.com>
8569
8570         * c-exp.y (struct c_parse_state) <strings>: New member.
8571         (operator_stoken): Update.
8572
8573 2019-01-06  Tom Tromey  <tom@tromey.com>
8574
8575         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8576         (union type_stack_elt) <typelist_val>: Now a pointer to
8577         std::vector.
8578         (type_stack_cleanup): Don't declare.
8579         (push_typelist): Update.
8580         * parse.c (pop_typelist): Return a std::vector.
8581         (push_typelist): Take a std::vector.
8582         (follow_types): Update.  Do not free args.
8583         (type_stack_cleanup): Remove.
8584         * c-exp.y (struct c_parse_state): New.
8585         (cpstate): New global.
8586         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8587         (nonempty_typelist): Update.
8588         (func_mod): Create a new vector.
8589         (c_parse): Create a c_parse_state.
8590         (check_parameter_typelist): Do not delete params.
8591         (function_method): Update.  Do not delete type_list.
8592
8593 2019-01-06  Tom Tromey  <tom@tromey.com>
8594
8595         PR gdb/28155:
8596         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8597         check_typedef.
8598         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8599         (print_return_value): Likewise.
8600
8601 2019-01-05  Tom Tromey  <tom@tromey.com>
8602
8603         * contrib/cleanup_check.py: Remove.
8604         * contrib/gcc-with-excheck: Remove.
8605         * contrib/exsummary.py: Remove.
8606         * contrib/excheck.py: Remove.
8607
8608 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
8609
8610         * thread.c (delete_thread_1): Add gdb_assert that THR is not
8611         NULL. Initialize tpprev to NULL instead of assigning it
8612         to NULL on the next statement.
8613         * windows-nat.c (windows_delete_thread): Remove check for
8614         main_thread_id before printing thread exit notifications.
8615         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8616         Remove thread ID check against main_thread_id.
8617         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8618         windows_delete_thread.
8619         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8620
8621 2019-01-04  Tom Tromey  <tom@tromey.com>
8622
8623         * compile/compile.c (_initialize_compile): Use upper case for
8624         metasyntactic variables.
8625         * symmisc.c (_initialize_symmisc): Use upper case for
8626         metasyntactic variables.
8627         * psymtab.c (_initialize_psymtab): Use upper case for
8628         metasyntactic variables.
8629         * demangle.c (demangle_command): Use upper case for metasyntactic
8630         variables.
8631         (_initialize_demangler): Likewise.
8632         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8633         variables.
8634
8635 2019-01-03  Tom Tromey  <tom@tromey.com>
8636
8637         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8638
8639 2019-01-03  Tom Tromey  <tom@tromey.com>
8640
8641         * python/py-symtab.c (salpy_str): Update.
8642         (struct salpy_sal_object) <symtab>: Now a PyObject.
8643         (salpy_dealloc): Update.
8644         (del_objfile_sal): Use gdbpy_ref.
8645
8646 2019-01-03  Tom Tromey  <tom@tromey.com>
8647
8648         * python/py-type.c (convert_field): Use new_reference.  Return
8649         gdbpy_ref.
8650         (make_fielditem): Return gdbpy_ref.
8651         (typy_fields): Update.
8652         (typy_getitem): Update.
8653         (field_name): Return gdbpy_ref.  Use new_reference.
8654         (typy_iterator_iternext): Update.
8655
8656 2019-01-03  Tom Tromey  <tom@tromey.com>
8657
8658         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8659
8660 2019-01-03  Tom Tromey  <tom@tromey.com>
8661
8662         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8663         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8664         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8665         (pspy_set_frame_filters, pspy_set_frame_unwinders)
8666         (pspy_set_type_printers): Likewise.
8667         * python/py-function.c (fnpy_init): Use gdbpy_ref.
8668         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8669         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8670         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8671         (objfpy_set_type_printers): Likewise.
8672
8673 2019-01-03  Tom Tromey  <tom@tromey.com>
8674
8675         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8676         (gdbpy_print_stack): Use gdbpy_err_fetch.
8677         * python/python-internal.h (class gdbpy_err_fetch): New class.
8678         (class gdbpy_enter) <m_error_type, m_error_value,
8679         m_error_traceback>: Remove.
8680         <m_error>: New member.
8681         (gdbpy_exception_to_string): Don't declare.
8682         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8683         * python/py-value.c (convert_value_from_python): Use
8684         gdbpy_err_fetch.
8685         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8686         gdbpy_exception_to_string.
8687         (gdbpy_handle_exception): Use gdbpy_err_fetch.
8688         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8689         gdbpy_err_fetch.
8690
8691 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8692
8693         * linux-nat.c (delete_lwp_cleanup): Delete.
8694         (struct lwp_deleter): New struct.
8695         (lwp_info_up): New typedef.
8696         (linux_nat_target::follow_fork): Delete cleanup, and make use of
8697         lwp_info_up.
8698
8699 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8700
8701         * linux-fork.c (class scoped_switch_fork_info): New class.
8702         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
8703
8704 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8705
8706         * valops.c (find_overload_match): Remove use of null_cleanup, and
8707         calls to do_cleanups.
8708
8709 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8710
8711         * compile/compile-cplus-types.c
8712         (compile_cplus_instance::decl_name): Handle changes to
8713         cp_func_name.
8714         * cp-support.c (cp_func_name): Update header comment, update
8715         return type.
8716         * cp-support.h (cp_func_name): Update return type in declaration.
8717         * valops.c (find_overload_match): Move temp_func local to top
8718         level of function and change its type.  Use temp_func to hold and
8719         delete temporary string obtained from cp_func_name.
8720
8721 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8722
8723         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8724         gdb::char_vector, remove cleanup, and update uses of `msg`.
8725
8726 2019-01-03  Jim Wilson  <jimw@sifive.com>
8727
8728         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8729
8730 2019-01-02  Tom Tromey  <tom@tromey.com>
8731
8732         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8733         (tdesc_parse_xml): Remove cleanups.
8734         * target-descriptions.h (make_cleanup_free_target_description):
8735         Don't declare.
8736         (target_desc_deleter): New struct.
8737         (target_desc_up): New typedef.
8738         * target-descriptions.c (target_desc_deleter::operator()): Rename
8739         from free_target_description.
8740         (make_cleanup_free_target_description): Remove.
8741
8742 2019-01-02  Tom Tromey  <tom@tromey.com>
8743
8744         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
8745         constructor, destructor.
8746         (linespec_parser): Remove typedef.
8747         (~linespec_parser): Rename from linespec_parser_delete.
8748         (linespec_lex_to_end, linespec_complete_label)
8749         (linespec_complete): Update.
8750         (decode_line_full): Remove cleanups.
8751         (decode_line_1): Update.
8752
8753 2019-01-02  Tom Tromey  <tom@tromey.com>
8754
8755         * python/python-internal.h (inferior_to_inferior_object): Change
8756         return type.
8757         * python/py-exitedevent.c (create_exited_event_object): Update.
8758         * python/py-inferior.c (inferior_to_inferior_object): Return
8759         gdbpy_ref.
8760         (python_new_inferior, python_inferior_deleted)
8761         (thread_to_thread_object, delete_thread_object)
8762         (build_inferior_list, gdbpy_selected_inferior): Update.
8763         * python/py-infthread.c (create_thread_object): Update.  Also fail
8764         if inferior_to_inferior_object fails.
8765
8766 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
8767
8768         * inferior.h (class inferior) <displaced_step_state>: New field.
8769         * infrun.h (struct displaced_step_state): Move here from
8770         infrun.c.  Initialize fields, add constructor.
8771         <inf>: Remove field.
8772         <reset>: New method.
8773         * infrun.c (struct displaced_step_inferior_state): Move to
8774         infrun.h.
8775         (displaced_step_inferior_states): Remove.
8776         (get_displaced_stepping_state): Adust.
8777         (displaced_step_in_progress_any_inferior): Adjust.
8778         (displaced_step_in_progress_thread): Adjust.
8779         (displaced_step_in_progress): Adjust.
8780         (add_displaced_stepping_state): Remove.
8781         (get_displaced_step_closure_by_addr): Adjust.
8782         (remove_displaced_stepping_state): Remove.
8783         (infrun_inferior_exit): Call displaced_step_state.reset.
8784         (use_displaced_stepping): Don't check for NULL.
8785         (displaced_step_prepare_throw): Call
8786         get_displaced_stepping_state.
8787         (displaced_step_fixup): Don't check for NULL.
8788         (prepare_for_detach): Don't check for NULL.
8789
8790 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8791
8792         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8793          in case of call that did not complete.
8794
8795 2019-01-02  Andrey Utkin  <autkin@undo.io>
8796
8797         * symfile.c (find_separate_debug_file): Fix search of debug files for
8798         remote debuggee.
8799
8800 2019-01-02  Tom Tromey  <tom@tromey.com>
8801
8802         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8803         indentation.
8804         * python/py-frame.c (frapy_older): Remove cast.
8805         (frapy_newer): Likewise.
8806         * python/py-breakpoint.c (local_setattro): Remove cast.
8807         * python/py-arch.c (archpy_name): Remove local variable.
8808         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8809
8810 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8811
8812         * unittests/basic_string_view/element_access/char/empty.cc:
8813         Fix year range in copyright header.
8814
8815 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8816
8817         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8818         Delete.
8819         <operator==>: Update with for removed field.
8820         <hash>: Likewise.
8821         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8822         <isa_features>: ...this.
8823         <abi_features>: New field.
8824         (riscv_isa_flen): Update comment.
8825         (riscv_abi_xlen): New declaration.
8826         (riscv_abi_flen): New declaration.
8827         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8828         isa_features.
8829         (riscv_abi_xlen): New function.
8830         (riscv_isa_flen): Update to get answer from isa_features.
8831         (riscv_abi_flen): New function.
8832         (riscv_has_fp_abi): Update to get answer from abi_features.
8833         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8834         xlen and flen.
8835         (riscv_call_info) <xlen, flen>: Update comment.
8836         (riscv_call_arg_struct): Remove invalid assertions
8837         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8838         is removed.
8839         (riscv_gdbarch_init): Gather isa features and abi features
8840         separately, ensure both match on the gdbarch when reusing an old
8841         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8842         a target with 64-bit float hardware.
8843
8844 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8845
8846         * source.c (search_command_helper): Stop reverse search
8847         when line 1 has been searched.
8848
8849 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8850
8851         * record-full.c (record_full_base_target::close): Rewrite
8852         record_full_core_buf_list free logic.
8853
8854 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8855
8856         * break-catch-syscall.c (print_one_catch_syscall): xfree
8857         the last text.
8858
8859 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8860
8861         * top.c (print_gdb_version): Update Copyright year in version
8862         message.
8863
8864 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8865
8866         Update copyright year range in all GDB files.
8867
8868 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8869
8870         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8871
8872 For older changes see ChangeLog-2018.
8873 \f
8874 Local Variables:
8875 mode: change-log
8876 left-margin: 8
8877 fill-column: 74
8878 version-control: never
8879 coding: utf-8
8880 End:
8881