gdb/ChangeLog

   1 2019-01-22  Tom Tromey  <tom@tromey.com>
   2
   3         * python/py-arch.c: Do not include py-ref.h.
   4         * python/py-bpevent.c: Do not include py-ref.h.
   5         * python/py-cmd.c: Do not include py-ref.h.
   6         * python/py-continueevent.c: Do not include py-ref.h.
   7         * python/py-event.h: Do not include py-ref.h.
   8         * python/py-evtregistry.c: Do not include py-ref.h.
   9         * python/py-finishbreakpoint.c: Do not include py-ref.h.
  10         * python/py-frame.c: Do not include py-ref.h.
  11         * python/py-framefilter.c: Do not include py-ref.h.
  12         * python/py-function.c: Do not include py-ref.h.
  13         * python/py-infevents.c: Do not include py-ref.h.
  14         * python/py-linetable.c: Do not include py-ref.h.
  15         * python/py-objfile.c: Do not include py-ref.h.
  16         * python/py-param.c: Do not include py-ref.h.
  17         * python/py-prettyprint.c: Do not include py-ref.h.
  18         * python/py-progspace.c: Do not include py-ref.h.
  19         * python/py-symbol.c: Do not include py-ref.h.
  20         * python/py-symtab.c: Do not include py-ref.h.
  21         * python/py-type.c: Do not include py-ref.h.
  22         * python/py-unwind.c: Do not include py-ref.h.
  23         * python/py-utils.c: Do not include py-ref.h.
  24         * python/py-value.c: Do not include py-ref.h.
  25         * python/py-varobj.c: Do not include py-ref.h.
  26         * python/py-xmethods.c: Do not include py-ref.h.
  27         * python/python.c: Do not include py-ref.h.
  28         * varobj.c: Do not include py-ref.h.
  29
  30 2019-01-22  Tom Tromey  <tom@tromey.com>
  31
  32         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
  33         keyword for bcache.
  34
  35 2019-01-22  Tom Tromey  <tom@tromey.com>
  36
  37         * compile/compile-cplus-types.c: Remove a comment by #include.
  38
  39 2019-01-22  Tom Tromey  <tom@tromey.com>
  40
  41         * compile/gcc-c-plugin.h: Include compile-internal.h.
  42
  43 2019-01-22  Tom Tromey  <tom@tromey.com>
  44
  45         * stabsread.c (EXTERN): Do not define.
  46         (symnum, next_symbol_text_func, processing_gcc_compilation)
  47         (within_function, global_sym_chain, global_stabs)
  48         (previous_stab_code, this_object_header_files)
  49         (n_this_object_header_files)
  50         (n_allocated_this_object_header_files): Define.
  51         * stabsread.h (EXTERN): Never define.  Use "extern".
  52
  53 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  54
  55         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
  56         history_value.
  57
  58 2019-01-21  Tom Tromey  <tom@tromey.com>
  59
  60         * ui-out.c: Fix includes.
  61         * tui/tui-source.c: Fix includes.
  62         * target.c: Fix includes.
  63         * remote.c: Fix includes.
  64         * regcache.c: Fix includes.
  65         * python/py-block.c: Fix includes.
  66         * printcmd.c: Fix includes.
  67         * or1k-tdep.c: Fix includes.
  68         * mi/mi-main.c: Fix includes.
  69         * m32r-tdep.c: Fix includes.
  70         * csky-tdep.c: Fix includes.
  71         * compile/compile-cplus-types.c: Fix includes.
  72         * cli/cli-interp.c: Fix includes.
  73
  74 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
  75
  76         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
  77         for padding.
  78
  79 2019-01-16  Tom Tromey  <tom@tromey.com>
  80
  81         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
  82         earlier.
  83         (struct objfile) <msymbols_range>: Move from top level.
  84         <msymbols>: New method.
  85         (class objfile_msymbols): Remove.
  86         * symtab.c (default_collect_symbol_completion_matches_break_on):
  87         Update.
  88         * symmisc.c (dump_msymbols): Update.
  89         * stabsread.c (scan_file_globals): Update.
  90         * objc-lang.c (info_selectors_command, info_classes_command)
  91         (find_methods): Update.
  92         * minsyms.c (find_solib_trampoline_target): Update.
  93         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
  94         * coffread.c (coff_symfile_read): Update.
  95         * ada-lang.c (ada_lookup_simple_minsym)
  96         (ada_collect_symbol_completion_matches): Update.
  97
  98 2019-01-16  Tom Tromey  <tom@tromey.com>
  99
 100         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
 101         type.  Remove no-argument constructor.
 102         <iterator::operator++>: Simplify.
 103         <begin>: Update.
 104         <end>: Use minimal_symbol_count.
 105
 106 2019-01-16  Tom Tromey  <tom@tromey.com>
 107
 108         * objfiles.h (struct objfile) <psymtabs>: New method.
 109         (class objfile_psymtabs): Remove.
 110         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
 111         typedef.
 112         <range>: New method.
 113         (require_partial_symbols): Change return type.
 114         * psymtab.c (require_partial_symbols)
 115         (psym_expand_symtabs_matching): Update.
 116         * mdebugread.c (parse_partial_symbols): Update.
 117         * dbxread.c (dbx_end_psymtab): Update.
 118
 119 2019-01-15  Tom Tromey  <tom@tromey.com>
 120
 121         * symtab.c (lookup_objfile_from_block)
 122         (lookup_symbol_in_objfile_symtabs)
 123         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
 124         (find_line_symtab, info_sources_command)
 125         (default_collect_symbol_completion_matches_break_on)
 126         (make_source_files_completion_list): Update.
 127         * symmisc.c (print_objfile_statistics, dump_objfile)
 128         (maintenance_print_symbols, maintenance_info_symtabs)
 129         (maintenance_check_symtabs, maintenance_info_line_tables):
 130         Update.
 131         * source.c (select_source_symtab)
 132         (forget_cached_source_info_for_objfile): Update.
 133         * objfiles.h (class objfile_compunits): Remove.
 134         (struct objfile) <compunits_range>: New typedef.
 135         (compunits): New method.
 136         * objfiles.c (objfile_relocate1): Update.
 137         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 138         * maint.c (count_symtabs_and_blocks): Update.
 139         * linespec.c (iterate_over_all_matching_symtabs): Update.
 140         * cp-support.c (add_symbol_overload_list_qualified): Update.
 141         * coffread.c (coff_symtab_read): Update.
 142         * ada-lang.c (add_nonlocal_symbols)
 143         (ada_collect_symbol_completion_matches)
 144         (ada_add_global_exceptions): Update.
 145
 146 2019-01-15  Tom Tromey  <tom@tromey.com>
 147
 148         * progspace.h (program_space) <objfiles_safe_range>: New
 149         typedef.
 150         <objfiles_safe>: New method.
 151         * objfiles.h (class all_objfiles_safe): Remove.
 152         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
 153         * jit.c (jit_inferior_exit_hook): Update.
 154
 155 2019-01-17  Tom Tromey  <tom@tromey.com>
 156
 157         * progspace.h (program_space) <objfiles_range>: New typedef.
 158         <objfiles>: New method.
 159         <objfiles_head>: Rename from objfiles.
 160         (object_files): Update.
 161         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
 162         * guile/scm-pretty-print.c
 163         (ppscm_find_pretty_printer_from_objfiles): Update.
 164         * guile/scm-objfile.c (gdbscm_objfiles): Update.
 165         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
 166         Update.
 167         * python/py-progspace.c (pspy_get_objfiles): Update.
 168         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 169         Update.
 170         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 171         (objfpy_lookup_objfile_by_build_id): Update.
 172         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 173         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 174         Update.
 175         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 176         (expand_symtab_containing_pc, lookup_objfile_from_block)
 177         (lookup_static_symbol, basic_lookup_transparent_type)
 178         (find_pc_sect_compunit_symtab, find_symbol_at_address)
 179         (find_line_symtab, info_sources_command)
 180         (default_collect_symbol_completion_matches_break_on)
 181         (make_source_files_completion_list, find_main_name): Update.
 182         * symmisc.c (print_symbol_bcache_statistics)
 183         (print_objfile_statistics, maintenance_print_symbols)
 184         (maintenance_print_msymbols, maintenance_print_objfiles)
 185         (maintenance_info_symtabs, maintenance_check_symtabs)
 186         (maintenance_expand_symtabs, maintenance_info_line_tables):
 187         Update.
 188         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
 189         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
 190         (map_overlay_command, unmap_overlay_command)
 191         (simple_overlay_update, expand_symtabs_matching)
 192         (map_symbol_filenames): Update.
 193         * symfile-debug.c (set_debug_symfile): Update.
 194         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
 195         Update.
 196         * source.c (select_source_symtab, forget_cached_source_info):
 197         Update.
 198         * solib.c (solib_read_symbols): Update.
 199         * solib-spu.c (append_ocl_sos): Update.
 200         * psymtab.c (maintenance_print_psymbols)
 201         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
 202         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
 203         * printcmd.c (info_symbol_command): Update.
 204         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
 205         Update.
 206         * objfiles.h (class all_objfiles): Remove.
 207         * objfiles.c (have_partial_symbols, have_full_symbols)
 208         (have_minimal_symbols, qsort_cmp, update_section_map)
 209         (shared_objfile_contains_address_p)
 210         (default_iterate_over_objfiles_in_search_order): Update.
 211         * objc-lang.c (info_selectors_command, info_classes_command)
 212         (find_methods): Update.
 213         * minsyms.c (find_solib_trampoline_target): Update.
 214         * maint.c (maintenance_info_sections)
 215         (maintenance_translate_address, count_symtabs_and_blocks):
 216         Update.
 217         * main.c (captured_main_1): Update.
 218         * linux-thread-db.c (try_thread_db_load_from_pdir)
 219         (has_libpthread): Update.
 220         * linespec.c (iterate_over_all_matching_symtabs)
 221         (search_minsyms_for_name): Update.
 222         * jit.c (jit_find_objf_with_entry_addr): Update.
 223         * hppa-tdep.c (find_unwind_entry)
 224         (hppa_lookup_stub_minimal_symbol): Update.
 225         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
 226         Update.
 227         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 228         (elf_gnu_ifunc_resolve_by_got): Update.
 229         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
 230         * dwarf-index-write.c (save_gdb_index_command): Update.
 231         * cp-support.c (add_symbol_overload_list_qualified): Update.
 232         * breakpoint.c (create_overlay_event_breakpoint)
 233         (create_longjmp_master_breakpoint)
 234         (create_std_terminate_master_breakpoint)
 235         (create_exception_master_breakpoint): Update.
 236         * blockframe.c (find_pc_partial_function): Update.
 237         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
 238         (ada_collect_symbol_completion_matches)
 239         (ada_add_global_exceptions): Update.
 240
 241 2019-01-17  Tom Tromey  <tom@tromey.com>
 242
 243         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
 244         declare VEC.
 245         (solib_target_parse_libraries): Change return type.
 246         (library_list_start_segment, library_list_start_section)
 247         (library_list_end_library, library_list_start_library); Update.
 248         (solib_target_free_library_list): Remove.
 249         (solib_target_parse_libraries): Remove cleanup.  Change return
 250         type.
 251         (solib_target_current_sos): Update.
 252
 253 2019-01-17  Tom Tromey  <tromey@bapiya>
 254
 255         * valprint.c: Replace "the the" with "the".
 256         * symtab.c: Replace "the the" with "the".
 257         * solib.c: Replace "the the" with "the".
 258         * solib-dsbt.c: Replace "the the" with "the".
 259         * linespec.c: Replace "the the" with "the".
 260         * dwarf2loc.h: Replace "the the" with "the".
 261         * amd64-windows-tdep.c: Replace "the the" with "the".
 262         * aarch64-tdep.c: Replace "the the" with "the".
 263
 264 2019-01-16  Keith Seitz  <keiths@redhat.com>
 265
 266         PR gdb/23773
 267         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
 268         <builder>: Rename to ..
 269         <m_builder>: ... this and make private.
 270         (dwarf2_cu::get_builder): New method.  Change all users of
 271         `builder' to use this method.
 272         (dwarf2_start_symtab): Move to ...
 273         (dwarf2_cu::start_symtab): ... here.  Update all callers
 274         (setup_type_unit_groups): Move to ...
 275         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
 276         callers.
 277         (dwarf2_cu::reset_builder): New method.
 278         (process_full_compunit, process_full_type_unit): Use
 279         dwarf2_cu::reset_builder.
 280         (follow_die_offset): Record the ancestor CU if it is different
 281         from the followed DIE's CU.
 282         (follow_die_sig_1): Likewise.
 283
 284 2019-01-15  Tom Tromey  <tom@tromey.com>
 285
 286         * remote.c (class remote_state) <buf>: Now a char_vector.
 287         <buf_size>: Remove.
 288         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
 289         parameter.
 290         (remote_target::getpkt_or_notif_sane_1)
 291         (remote_target::getpkt_sane)
 292         (remote_target::getpkt_or_notif_sane): Likewise.
 293         (class remote_target) <putpkt>: New overload.
 294         (remote_target::read_frame): Change type of "buf_p".  Remove
 295         sizeof_p parameter.
 296         (packet_ok): New overload.
 297         (packet_check_result): New overload.
 298         Update all uses.
 299
 300 2019-01-14  Tom Tromey  <tom@tromey.com>
 301
 302         * remote-notif.c (handle_notification, remote_notif_ack)
 303         (remote_notif_parse): Make "buf" const.
 304         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
 305         const.
 306         (remote_notif_parse, remote_notif_ack, handle_notification):
 307         Likewise.
 308         * remote.c (remote_notif_stop_parse): Make "buf" const.
 309         (remote_target::remote_parse_stop_reply): Make "buf" const.
 310         (remote_notif_stop_ack): Make "buf" const.
 311
 312 2019-01-14  Tom Tromey  <tom@tromey.com>
 313
 314         * remote.c (remote_console_output): Make parameter const.
 315
 316 2019-01-14  Tom Tromey  <tom@tromey.com>
 317
 318         * target-debug.h (target_debug_print_signals): Constify.
 319         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
 320         * procfs.c (procfs_target::pass_signals): Update.
 321         * linux-nat.c (linux_nat_target::pass_signals): Update.
 322         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
 323         * target-delegates.c: Rebuild.
 324         * remote.c (remote_target::program_signals): Update.
 325         (remote_target::pass_signals): Update.
 326         * target.c (target_pass_signals): Constify argument.
 327         (target_program_signals): Likewise.
 328         * target.h (struct target_ops) <pass_signals, program_signals>:
 329         Constify argument.
 330         (target_pass_signals, target_program_signals): Constify argument.
 331
 332 2019-01-14  Tom Tromey  <tom@tromey.com>
 333
 334         PR tui/28819:
 335         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
 336
 337 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 338
 339         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
 340         field.
 341         * rs6000-tdep.c: Include reggroups.h.
 342         (IS_V_ALIAS_PSEUDOREG): Define.
 343         (rs6000_register_name): Return names for the "vX" aliases.
 344         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
 345         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
 346         aliases.  Call default_register_reggroup_p for all other
 347         pseudo-registers.
 348         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
 349         New functions.
 350         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
 351         Handle "vX" aliases.
 352         (v_alias_pseudo_register_collect): New function.
 353         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
 354         (rs6000_gdbarch_init): Initialize "vX" aliases as
 355         pseudo-registers.  Restore registration of
 356         rs6000_pseudo_register_reggroup_p with
 357         set_tdesc_pseudo_register_reggroup_p.
 358
 359 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
 360
 361         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
 362         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
 363         set_gdbarch_num_pseudo_regs.
 364
 365 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 366
 367         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
 368         Remove arg prefixname, add do_set and do_show.
 369         Add member functions set_list and show_list.
 370         * cli/cli-style.c (class cli_style_option): Update accordingly.
 371         (style_set_list): Move to file scope.
 372         (style_show_list): Likewise.
 373         (set_style): Call help_list.
 374         (show_style): Call cmd_show_list.
 375         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
 376         Update to use the new macro.
 377
 378 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
 379
 380         * ada-lang.c (_initialize_ada_language): Expand the help text
 381         for the "catch exception" command.
 382
 383 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 384
 385         * symtab.c (matching_obj_sections): Initialize obj,
 386         declare it closer to its usage.
 387
 388 2019-01-10  Tom Tromey  <tom@tromey.com>
 389
 390         * thread-iter.h (inf_threads_iterator): Use next_iterator.
 391         (basic_inf_threads_range): Remove.
 392         (inf_threads_range, inf_non_exited_threads_range)
 393         (safe_inf_threads_range): Use next_adapter.
 394
 395 2019-01-10  Keith Seitz  <keiths@redhat.com>
 396
 397         PR gdb/23712
 398         PR symtab/23010
 399         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
 400         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
 401
 402 2019-01-10  Keith Seitz  <keiths@redhat.com>
 403
 404         PR gdb/23712
 405         PR symtab/23010
 406         * dictionary.c (pending_to_vector): Remove.
 407         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 408         Remove _1 suffix, replacing functions of the same name.  Update
 409         all callers.
 410         (dict_create_hashed, dict_create_hashed_expandable)
 411         (dict_create_linear, dict_create_linear_expandable, dict_free)
 412         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
 413         Make functions static.
 414
 415 2019-01-10  Keith Seitz  <keiths@redhat.com>
 416
 417         PR gdb/23712
 418         PR symtab/23010
 419         * dictionary.h (struct dictionary): Replace declaration with
 420         multidictionary.
 421         (dict_create_hashed, dict_create_hashed_expandable)
 422         (dict_create_linear, dict_create_linear_expandable)
 423         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
 424         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
 425         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
 426         taking multidictionary argument.
 427         [ALL_DICT_SYMBOLS]: Update for multidictionary.
 428         * block.h (struct block) <dict>: Change to multidictionary
 429         and rename `multidict'.
 430         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
 431         symmisc.c: Update all dictionary references to multidictionary.
 432
 433 2019-01-10  Keith Seitz  <keiths@redhat.com>
 434
 435         PR gdb/23712
 436         PR symtab/23010
 437         * dictionary.c: Include unordered_map.
 438         (pending_to_vector): New function.
 439         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 440         Rewrite the non-"_1" functions to take vector instead
 441         of linked list.
 442         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
 443         "new" _1 versions of the same name.
 444         (multidictionary): Define.
 445         (std::hash<enum language): New definition.
 446         (collate_pending_symbols_by_language, mdict_create_hashed)
 447         (mdict_create_hashed_expandable, mdict_create_linear)
 448         (mdict_create_linear_expandable, mdict_free)
 449         (find_language_dictionary, create_new_language_dictionary)
 450         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
 451         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
 452         (mdict_size, mdict_empty): New functions.
 453         * dictionary.h (mdict_iterator): Define.
 454
 455 2019-01-10  Pedro Alves  <palves@redhat.com>
 456
 457         * breakpoint.c (read_uploaded_action)
 458         (create_tracepoint_from_upload): Adjust to use
 459         gdb::unique_xmalloc_ptr.
 460         * ctf.c (ctf_write_uploaded_tp):
 461         (SET_ARRAY_FIELD): Use emplace_back.
 462         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
 463         * tracefile-tfile.c (tfile_write_uploaded_tp):
 464         * tracepoint.c (parse_tracepoint_definition): Adjust to use
 465         gdb::unique_xmalloc_ptr.
 466         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
 467         at_string, cond_string, cmd_strings>: Replace char pointers
 468         with gdb::unique_xmalloc_ptr.
 469
 470 2019-01-10  Pedro Alves  <palves@redhat.com>
 471
 472         * solib-target.c (library_list_start_library): Don't xstrdup name.
 473
 474 2019-01-10  Pedro Alves  <palves@redhat.com>
 475
 476         * mdebugread.c (parse_partial_symbols): Use
 477         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
 478
 479 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 480
 481         * linux-fork.c (scoped_switch_fork_info)
 482         <~scoped_switch_fork_info>: Fix incorrect variable name.
 483
 484 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 485
 486         * linux-fork.c (scoped_switch_fork_info)
 487         <scoped_switch_fork_info>: Make explicit.
 488         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
 489
 490 2019-01-10  Tom Tromey  <tom@tromey.com>
 491
 492         * objfiles.h (objfile::reset_psymtabs): Update.
 493         * objfiles.c (objfile::objfile): Update.
 494         * psymtab.h (psymtab_storage::obstack): Update.
 495         (psymtab_storage::m_obstack): Use gdb::optional.
 496         (class psymtab_storage): Update comment.  Remove objfile
 497         parameter.
 498         * psymtab.c (psymtab_storage::psymtab_storage): Update.
 499
 500 2019-01-10  Tom Tromey  <tom@tromey.com>
 501
 502         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
 503         <free_psymtabs>: Now private.
 504         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
 505         (allocate_psymtab): Use new method.
 506
 507 2019-01-10  Tom Tromey  <tom@tromey.com>
 508
 509         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
 510         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
 511         * mdebugread.c (parse_partial_symbols): Use
 512         allocate_dependencies.
 513         * dwarf2read.c (dwarf2_create_include_psymtab): Use
 514         allocate_dependencies.
 515         (process_psymtab_comp_unit_reader)
 516         (build_type_psymtab_dependencies): Likewise.
 517         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
 518
 519 2019-01-10  Tom Tromey  <tom@tromey.com>
 520
 521         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
 522         PSYMBOL_SET_LANGUAGE.
 523         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
 524
 525 2019-01-10  Tom Tromey  <tom@tromey.com>
 526
 527         * psymtab.h (psymtab_storage::obstack): New method.
 528         <m_obstack>: Rename from obstack; now private.
 529         * psymtab.c (psymtab_storage): Update.
 530         * dwarf2read.c (create_addrmap_from_index)
 531         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
 532         Update.
 533
 534 2019-01-10  Tom Tromey  <tom@tromey.com>
 535
 536         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
 537         * objfiles.h (objfile::reset_psymtabs): New method.
 538
 539 2019-01-10  Tom Tromey  <tom@tromey.com>
 540
 541         * symmisc.c (print_symbol_bcache_statistics): Update.
 542         (print_objfile_statistics): Update.
 543         * symfile.c (reread_symbols): Update.
 544         * psymtab.h (class psymtab_storage): New.
 545         * psymtab.c (psymtab_storage): New constructor.
 546         (~psymtab_storage): New destructor.
 547         (require_partial_symbols): Update.
 548         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
 549         (find_pc_sect_psymtab, find_pc_sect_psymbol)
 550         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
 551         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
 552         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
 553         (start_psymtab_common, end_psymtab_common)
 554         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
 555         (allocate_psymtab): Update.
 556         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
 557         Update.
 558         (dump_psymtab_addrmap, maintenance_print_psymbols)
 559         (maintenance_check_psymtabs): Update.
 560         (class objfile_psymtabs): Move to objfiles.h.
 561         * psympriv.h (discard_psymtab): Now inline.
 562         (psymtab_discarder::psymtab_discarder): Update.
 563         (psymtab_discarder::~psymtab_discarder): Update.
 564         (ALL_OBJFILE_PSYMTABS): Rewrite.
 565         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
 566         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
 567         Remove fields.
 568         <partial_symtabs>: New field.
 569         (class objfile_psymtabs): Move from psymtab.h.  Update.
 570         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
 571         psymbol_cache.
 572         (objfile::~objfile): Don't destroy psymbol_cache.
 573         * mdebugread.c (parse_partial_symbols): Update.
 574         * dwarf2read.c (create_addrmap_from_index)
 575         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
 576         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
 577         (add_partial_subprogram, dwarf2_ranges_read): Update.
 578         * dwarf-index-write.c (write_address_map)
 579         (write_one_signatured_type, recursively_write_psymbols)
 580         (class debug_names, class debug_names, write_psymtabs_to_index):
 581         Update.
 582
 583 2019-01-10  Tom Tromey  <tom@tromey.com>
 584
 585         * symtab.h (SYMBOL_SET_NAMES): Update.
 586         (symbol_set_names): Update.
 587         (MSYMBOL_SET_NAMES): Update.
 588         * symtab.c (symbol_set_names): Change argument to be an
 589         objfile_per_bfd_storage.
 590         * psymtab.c (add_psymbol_to_bcache): Update.
 591         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
 592
 593 2019-01-10  Tom Tromey  <tom@tromey.com>
 594
 595         * symtab.c (create_demangled_names_hash): Change argument to be an
 596         objfile_per_bfd_storage.
 597         (symbol_set_names): Update.
 598
 599 2019-01-10  Tom Tromey  <tom@tromey.com>
 600
 601         * xcoffread.c (xcoff_initial_scan): Unconditionally call
 602         init_psymbol_list.
 603         * psymtab.c (init_psymbol_list): Do nothing if already called.
 604         * psympriv.h (init_psymbol_list): Add comment.
 605         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
 606         init_psymbol_list.
 607         * dbxread.c (dbx_symfile_read): Unconditionally call
 608         init_psymbol_list.
 609
 610 2019-01-10  Tom Tromey  <tom@tromey.com>
 611
 612         * xcoffread.c (scan_xcoff_symtab): Update.
 613         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
 614         "where".
 615         * mdebugread.c (parse_partial_symbols)
 616         (handle_psymbol_enumerators): Update.
 617         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
 618         * dbxread.c (read_dbx_symtab): Update.
 619         * psympriv.h (psymbol_placement): New enum.
 620         (add_psymbol_to_list): Update.
 621
 622 2019-01-10  Tom Tromey  <tom@tromey.com>
 623
 624         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
 625         static_psymbols parameters.
 626         (scan_xcoff_symtab): Update.
 627         * psymtab.c (start_psymtab_common): Remove global_psymbols and
 628         static_psymbols parameters.
 629         * psympriv.h (start_psymtab_common): Update.
 630         * mdebugread.c (parse_partial_symbols): Update.
 631         * dwarf2read.c (create_partial_symtab): Update.
 632         * dbxread.c (read_dbx_symtab): Update.
 633         (start_psymtab): Remove global_psymbols and static_psymbols
 634         parameters.
 635
 636 2019-01-10  Tom Tromey  <tom@tromey.com>
 637
 638         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
 639         * psymtab.c (allocate_psymtab): Add comment.
 640         * psympriv.h (allocate_psymtab): Add comment.
 641         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
 642         initializations.
 643         * dbxread.c (dbx_end_psymtab): Remove some initializations.
 644
 645 2019-01-10  Tom Tromey  <tom@tromey.com>
 646
 647         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 648         Don't declare.
 649         * mipsread.c: Include mdebugread.h.
 650         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 651         Declare.
 652         * elfread.c: Include mdebugread.h.
 653
 654 2019-01-09  Tom Tromey  <tom@tromey.com>
 655
 656         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
 657         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
 658         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
 659         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
 660         (psym_lookup_symbol, psym_find_last_source_symtab)
 661         (psym_forget_cached_source_info, psym_print_stats)
 662         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
 663         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
 664         (psym_map_matching_symbols, psym_expand_symtabs_matching)
 665         (psym_find_compunit_symtab_by_address)
 666         (maintenance_print_psymbols, maintenance_info_psymtabs)
 667         (maintenance_check_psymtabs): Use ranged for.
 668         * psymtab.h (class objfile_psymtabs): New.
 669         (require_partial_symbols): Return objfile_psymtabs.
 670         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
 671
 672 2019-01-09  Tom Tromey  <tom@tromey.com>
 673
 674         * symfile.c (overlay_invalidate_all, find_pc_overlay)
 675         (find_pc_mapped_section, list_overlays_command)
 676         (map_overlay_command, unmap_overlay_command)
 677         (simple_overlay_update): Use all_objfiles.
 678         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
 679         * printcmd.c (info_symbol_command): Use all_objfiles.
 680         * objfiles.h (ALL_OBJSECTIONS): Remove.
 681         * maint.c (maintenance_translate_address): Use all_objfiles.
 682         * gcore.c (gcore_create_callback): Use all_objfiles.
 683         (objfile_find_memory_regions): Likewise.
 684
 685 2019-01-09  Tom Tromey  <tom@tromey.com>
 686
 687         * symtab.c (find_line_symtab, info_sources_command)
 688         (make_source_files_completion_list): Use objfile_compunits.
 689         * source.c (select_source_symtab): Use objfile_compunits.
 690         * objfiles.h (struct objfile): Update comment.
 691         (ALL_OBJFILES): Remove.
 692         (ALL_FILETABS): Remove.
 693         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
 694         objfile_compunits.
 695
 696 2019-01-09  Tom Tromey  <tom@tromey.com>
 697
 698         * symmisc.c (print_objfile_statistics, dump_objfile)
 699         (maintenance_print_symbols): Use compunit_filetabs.
 700         * source.c (forget_cached_source_info_for_objfile): Use
 701         compunit_filetabs.
 702         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
 703         (ALL_FILETABS): Use compunit_filetabs.
 704         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
 705         * coffread.c (coff_symtab_read): Use compunit_filetabs.
 706
 707 2019-01-09  Tom Tromey  <tom@tromey.com>
 708
 709         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
 710         (compunit_filetabs): New.
 711         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
 712         compunit_filetabs.
 713         (info_sources_command, make_source_files_completion_list): Remove
 714         declaration.
 715         * symmisc.c (print_objfile_statistics, dump_objfile)
 716         (maintenance_print_symbols): Remove declaration.
 717         (maintenance_info_symtabs): Use compunit_filetabs.
 718         (maintenance_info_line_tables): Likewise.
 719         * source.c (select_source_symtab): Change local variable name.
 720         (forget_cached_source_info_for_objfile): Remove declaration.
 721         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
 722         * objfiles.c (objfile_relocate1): Remove declaration.
 723         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 724         declaration.
 725         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
 726         * coffread.c (coff_symtab_read): Remove declaration.
 727         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 728         compunit_filetabs.
 729
 730 2019-01-09  Tom Tromey  <tom@tromey.com>
 731
 732         * symtab.c (lookup_objfile_from_block)
 733         (find_pc_sect_compunit_symtab, search_symbols)
 734         (default_collect_symbol_completion_matches_break_on): Use
 735         objfile_compunits.
 736         * objfiles.h (ALL_COMPUNITS): Remove.
 737         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
 738         * cp-support.c (add_symbol_overload_list_qualified): Use
 739         objfile_compunits.
 740         * ada-lang.c (ada_collect_symbol_completion_matches)
 741         (ada_add_global_exceptions): Use objfile_compunits.
 742
 743 2019-01-09  Tom Tromey  <tom@tromey.com>
 744
 745         * source.c (select_source_symtab)
 746         (forget_cached_source_info_for_objfile): Remove declaration.
 747         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 748         declaration.
 749         * maint.c (count_symtabs_and_blocks): Remove declaration.
 750         * cp-support.c (add_symbol_overload_list_qualified): Remove
 751         declaration.
 752         * coffread.c (coff_symtab_read): Remove declaration.
 753         * symtab.c (lookup_symbol_in_objfile_symtabs)
 754         (basic_lookup_transparent_type_1): Use objfile_compunits.
 755         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
 756         (info_sources_command, search_symbols)
 757         (default_collect_symbol_completion_matches_break_on)
 758         (make_source_files_completion_list): Remove declaration.
 759         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
 760         (ada_collect_symbol_completion_matches)
 761         (ada_add_global_exceptions): Remove declaration.
 762         * linespec.c (iterate_over_all_matching_symtabs): Use
 763         objfile_compunits.
 764         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
 765         (class objfile_compunits): New.
 766         (ALL_COMPUNITS): Use objfile_compunits.
 767         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
 768         (maintenance_check_symtabs, maintenance_info_line_tables): Use
 769         objfile_compunits.
 770         * objfiles.c (objfile_relocate1): Use objfile_compunits.
 771
 772 2019-01-09  Tom Tromey  <tom@tromey.com>
 773
 774         * symtab.c (search_symbols)
 775         (default_collect_symbol_completion_matches_break_on): Use
 776         objfile_msymbols.
 777         * ada-lang.c (ada_lookup_simple_minsym)
 778         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
 779         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
 780         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
 781         objfile_msymbols.
 782         * coffread.c (coff_symfile_read): Use objfile_msymbols.
 783         * symmisc.c (dump_msymbols): Use objfile_msymbols.
 784         * objc-lang.c (find_methods): Use objfile_msymbols.
 785         (info_selectors_command, info_classes_command): Likewise.
 786         * stabsread.c (scan_file_globals): Use objfile_msymbols.
 787         * objfiles.h (class objfile_msymbols): New.
 788         (ALL_OBJFILE_MSYMBOLS): Remove.
 789         (ALL_MSYMBOLS): Remove.
 790
 791 2019-01-09  Tom Tromey  <tom@tromey.com>
 792
 793         * common/next-iterator.h (next_adapter): Add Iterator template
 794         parameter.
 795         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
 796         (class all_objfiles_safe): New.
 797         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
 798         * objfiles.c (put_objfile_before): Update comment.
 799         (add_separate_debug_objfile): Likewise.
 800         (free_all_objfiles): Use all_objfiles_safe.
 801         (objfile_purge_solibs): Likewise.
 802
 803 2019-01-09  Tom Tromey  <tom@tromey.com>
 804
 805         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 806         (expand_symtab_containing_pc, lookup_static_symbol)
 807         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
 808         (find_symbol_at_address, find_line_symtab, find_main_name): Use
 809         all_objfiles.
 810         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
 811         * breakpoint.c (create_overlay_event_breakpoint)
 812         (create_longjmp_master_breakpoint)
 813         (create_std_terminate_master_breakpoint)
 814         (create_exception_master_breakpoint): Use all_objfiles.
 815         * linux-thread-db.c (try_thread_db_load_from_pdir)
 816         (has_libpthread): Use all_objfiles.
 817         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
 818         * linespec.c (iterate_over_all_matching_symtabs)
 819         (search_minsyms_for_name): Use all_objfiles.
 820         * maint.c (maintenance_info_sections): Use all_objfiles.
 821         * main.c (captured_main_1): Use all_objfiles.
 822         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
 823         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
 824         * guile/scm-pretty-print.c
 825         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
 826         * solib-spu.c (append_ocl_sos): Use all_objfiles.
 827         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
 828         (maintenance_print_msymbols): Use all_objfiles.
 829         * source.c (select_source_symtab): Use all_objfiles.
 830         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
 831         * symfile.c (remove_symbol_file_command)
 832         (expand_symtabs_matching, map_symbol_filenames): Use
 833         all_objfiles.
 834         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
 835         all_objfiles.
 836         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
 837         * objc-lang.c (find_methods): Use all_objfiles.
 838         * objfiles.c (have_partial_symbols, have_full_symbols)
 839         (have_minimal_symbols, qsort_cmp)
 840         (default_iterate_over_objfiles_in_search_order): Use
 841         all_objfiles.
 842         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
 843         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
 844         (maintenance_check_psymtabs): Use all_objfiles.
 845         (ALL_PSYMTABS): Remove.
 846         * compile/compile-object-run.c (do_module_cleanup): Use
 847         all_objfiles.
 848         * blockframe.c (find_pc_partial_function): Use all_objfiles.
 849         * cp-support.c (add_symbol_overload_list_qualified): Use
 850         all_objfiles.
 851         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 852         Use all_objfiles.
 853         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
 854         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
 855         all_objfiles.
 856         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 857         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
 858         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 859         Uses all_objfiles.
 860         * solib.c (solib_read_symbols): Use all_objfiles
 861
 862 2019-01-09  Tom Tromey  <tom@tromey.com>
 863
 864         * probe.c (parse_probes_in_pspace): Use all_objfiles.
 865         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
 866         all_objfiles.
 867         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
 868         * symmisc.c (print_symbol_bcache_statistics)
 869         (print_objfile_statistics, maintenance_print_objfiles)
 870         (maintenance_info_symtabs, maintenance_check_symtabs)
 871         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
 872         all_objfiles.
 873         * source.c (forget_cached_source_info): Use all_objfiles.
 874         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
 875         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 876         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
 877         * objfiles.c (update_section_map): Use all_objfiles.
 878         (shared_objfile_contains_address_p): Likewise.
 879         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
 880         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
 881
 882 2019-01-09  Tom Tromey  <tom@tromey.com>
 883
 884         * common/next-iterator.h: New file.
 885         * objfiles.h (class all_objfiles): New.
 886         (struct objfile_iterator): New.
 887
 888 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 889
 890         * NEWS: Move the description of the changed "frame", "select-frame",
 891          and "info frame" commands to the Changed commands section.
 892
 893 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
 894
 895         * gdbtypes.c (check_stub_method_group): Remove handling of old
 896         mangling schemes.
 897         * linespec.c (find_methods): Likewise.
 898         * stabsread.c (read_member_functions): Likewise.
 899         * valops.c (search_struct_method): Likewise.
 900         (value_struct_elt_for_reference): Likewise.
 901         * NEWS: Mention this change.
 902
 903 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 904
 905         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
 906         print_source_lines.
 907         * source.c (print_source_lines_base): Update line number check.
 908         (print_source_lines): New function.
 909         (source_lines_range::source_lines_range): New function.
 910         * source.h (class source_lines_range): New class.
 911         (print_source_lines): New declaration.
 912
 913 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 914
 915         * linespec.c (linespec_state_destructor): Free self->canonical_names.
 916
 917 2019-01-08  Tom Tromey  <tom@tromey.com>
 918             Simon Marchi  <simon.marchi@ericsson.com>
 919
 920         PR gdb/24060
 921         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
 922         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
 923         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 924         * f-exp.y (DOLLAR_VARIABLE): Likewise.
 925         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
 926         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 927
 928 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 929
 930         * source.c (select_source_symtab): Move header comment to
 931         declaration in source.h.
 932         (forget_cached_source_info_for_objfile): Likewise.
 933         (forget_cached_source_info): Likewise.
 934         (identify_source_line): Likewise.
 935         * source.h (identify_source_line): Move declaration from symtab.h
 936         and add comment from source.c
 937         (print_source_lines): Likewise.
 938         (forget_cached_source_info_for_objfile): Likewise.
 939         (forget_cached_source_info): Likewise.
 940         (select_source_symtab): Likewise.
 941         (enum print_source_lines_flag): Move definition from symtab.h.
 942         * symtab.h (identify_source_line): Move declaration to source.h.
 943         (print_source_lines): Likewise.
 944         (forget_cached_source_info_for_objfile): Likewise.
 945         (forget_cached_source_info): Likewise.
 946         (select_source_symtab): Likewise.
 947         (enum print_source_lines_flag): Move definition to source.h.
 948         * tui/tui-hooks.c: Add 'source.h' include.
 949
 950 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 951
 952         * source.c (print_source_lines_base): Handle requests to print
 953         reverse line number sequences, and guard against empty lines
 954         string.
 955
 956 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 957
 958         * source.c (print_source_lines_base): Fix skip of '\r' if next
 959         character is '\n'.
 960
 961 2019-01-06  Tom Tromey  <tom@tromey.com>
 962
 963         * c-exp.y (struct c_parse_state) <macro_original_text,
 964         expansion_obstack>: New member.
 965         (macro_original_text, expansion_obstack): Remove globals.
 966         (scan_macro_expansion, scanning_macro_expansion)
 967         (finished_macro_expansion): Update.
 968         (scan_macro_cleanup): Remove.
 969         (yylex, c_parse): Update.
 970
 971 2019-01-06  Tom Tromey  <tom@tromey.com>
 972
 973         * c-exp.y (struct c_parse_state) <strings>: New member.
 974         (operator_stoken): Update.
 975
 976 2019-01-06  Tom Tromey  <tom@tromey.com>
 977
 978         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
 979         (union type_stack_elt) <typelist_val>: Now a pointer to
 980         std::vector.
 981         (type_stack_cleanup): Don't declare.
 982         (push_typelist): Update.
 983         * parse.c (pop_typelist): Return a std::vector.
 984         (push_typelist): Take a std::vector.
 985         (follow_types): Update.  Do not free args.
 986         (type_stack_cleanup): Remove.
 987         * c-exp.y (struct c_parse_state): New.
 988         (cpstate): New global.
 989         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
 990         (nonempty_typelist): Update.
 991         (func_mod): Create a new vector.
 992         (c_parse): Create a c_parse_state.
 993         (check_parameter_typelist): Do not delete params.
 994         (function_method): Update.  Do not delete type_list.
 995
 996 2019-01-06  Tom Tromey  <tom@tromey.com>
 997
 998         PR gdb/28155:
 999         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
1000         check_typedef.
1001         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
1002         (print_return_value): Likewise.
1003
1004 2019-01-05  Tom Tromey  <tom@tromey.com>
1005
1006         * contrib/cleanup_check.py: Remove.
1007         * contrib/gcc-with-excheck: Remove.
1008         * contrib/exsummary.py: Remove.
1009         * contrib/excheck.py: Remove.
1010
1011 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
1012
1013         * thread.c (delete_thread_1): Add gdb_assert that THR is not
1014         NULL. Initialize tpprev to NULL instead of assigning it
1015         to NULL on the next statement.
1016         * windows-nat.c (windows_delete_thread): Remove check for
1017         main_thread_id before printing thread exit notifications.
1018         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
1019         Remove thread ID check against main_thread_id.
1020         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
1021         windows_delete_thread.
1022         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
1023
1024 2019-01-04  Tom Tromey  <tom@tromey.com>
1025
1026         * compile/compile.c (_initialize_compile): Use upper case for
1027         metasyntactic variables.
1028         * symmisc.c (_initialize_symmisc): Use upper case for
1029         metasyntactic variables.
1030         * psymtab.c (_initialize_psymtab): Use upper case for
1031         metasyntactic variables.
1032         * demangle.c (demangle_command): Use upper case for metasyntactic
1033         variables.
1034         (_initialize_demangler): Likewise.
1035         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
1036         variables.
1037
1038 2019-01-03  Tom Tromey  <tom@tromey.com>
1039
1040         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
1041
1042 2019-01-03  Tom Tromey  <tom@tromey.com>
1043
1044         * python/py-symtab.c (salpy_str): Update.
1045         (struct salpy_sal_object) <symtab>: Now a PyObject.
1046         (salpy_dealloc): Update.
1047         (del_objfile_sal): Use gdbpy_ref.
1048
1049 2019-01-03  Tom Tromey  <tom@tromey.com>
1050
1051         * python/py-type.c (convert_field): Use new_reference.  Return
1052         gdbpy_ref.
1053         (make_fielditem): Return gdbpy_ref.
1054         (typy_fields): Update.
1055         (typy_getitem): Update.
1056         (field_name): Return gdbpy_ref.  Use new_reference.
1057         (typy_iterator_iternext): Update.
1058
1059 2019-01-03  Tom Tromey  <tom@tromey.com>
1060
1061         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
1062
1063 2019-01-03  Tom Tromey  <tom@tromey.com>
1064
1065         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
1066         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
1067         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
1068         (pspy_set_frame_filters, pspy_set_frame_unwinders)
1069         (pspy_set_type_printers): Likewise.
1070         * python/py-function.c (fnpy_init): Use gdbpy_ref.
1071         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
1072         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
1073         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
1074         (objfpy_set_type_printers): Likewise.
1075
1076 2019-01-03  Tom Tromey  <tom@tromey.com>
1077
1078         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
1079         (gdbpy_print_stack): Use gdbpy_err_fetch.
1080         * python/python-internal.h (class gdbpy_err_fetch): New class.
1081         (class gdbpy_enter) <m_error_type, m_error_value,
1082         m_error_traceback>: Remove.
1083         <m_error>: New member.
1084         (gdbpy_exception_to_string): Don't declare.
1085         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
1086         * python/py-value.c (convert_value_from_python): Use
1087         gdbpy_err_fetch.
1088         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
1089         gdbpy_exception_to_string.
1090         (gdbpy_handle_exception): Use gdbpy_err_fetch.
1091         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1092         gdbpy_err_fetch.
1093
1094 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1095
1096         * linux-nat.c (delete_lwp_cleanup): Delete.
1097         (struct lwp_deleter): New struct.
1098         (lwp_info_up): New typedef.
1099         (linux_nat_target::follow_fork): Delete cleanup, and make use of
1100         lwp_info_up.
1101
1102 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1103
1104         * linux-fork.c (class scoped_switch_fork_info): New class.
1105         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
1106
1107 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1108
1109         * valops.c (find_overload_match): Remove use of null_cleanup, and
1110         calls to do_cleanups.
1111
1112 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1113
1114         * compile/compile-cplus-types.c
1115         (compile_cplus_instance::decl_name): Handle changes to
1116         cp_func_name.
1117         * cp-support.c (cp_func_name): Update header comment, update
1118         return type.
1119         * cp-support.h (cp_func_name): Update return type in declaration.
1120         * valops.c (find_overload_match): Move temp_func local to top
1121         level of function and change its type.  Use temp_func to hold and
1122         delete temporary string obtained from cp_func_name.
1123
1124 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1125
1126         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
1127         gdb::char_vector, remove cleanup, and update uses of `msg`.
1128
1129 2019-01-03  Jim Wilson  <jimw@sifive.com>
1130
1131         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
1132
1133 2019-01-02  Tom Tromey  <tom@tromey.com>
1134
1135         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
1136         (tdesc_parse_xml): Remove cleanups.
1137         * target-descriptions.h (make_cleanup_free_target_description):
1138         Don't declare.
1139         (target_desc_deleter): New struct.
1140         (target_desc_up): New typedef.
1141         * target-descriptions.c (target_desc_deleter::operator()): Rename
1142         from free_target_description.
1143         (make_cleanup_free_target_description): Remove.
1144
1145 2019-01-02  Tom Tromey  <tom@tromey.com>
1146
1147         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
1148         constructor, destructor.
1149         (linespec_parser): Remove typedef.
1150         (~linespec_parser): Rename from linespec_parser_delete.
1151         (linespec_lex_to_end, linespec_complete_label)
1152         (linespec_complete): Update.
1153         (decode_line_full): Remove cleanups.
1154         (decode_line_1): Update.
1155
1156 2019-01-02  Tom Tromey  <tom@tromey.com>
1157
1158         * python/python-internal.h (inferior_to_inferior_object): Change
1159         return type.
1160         * python/py-exitedevent.c (create_exited_event_object): Update.
1161         * python/py-inferior.c (inferior_to_inferior_object): Return
1162         gdbpy_ref.
1163         (python_new_inferior, python_inferior_deleted)
1164         (thread_to_thread_object, delete_thread_object)
1165         (build_inferior_list, gdbpy_selected_inferior): Update.
1166         * python/py-infthread.c (create_thread_object): Update.  Also fail
1167         if inferior_to_inferior_object fails.
1168
1169 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
1170
1171         * inferior.h (class inferior) <displaced_step_state>: New field.
1172         * infrun.h (struct displaced_step_state): Move here from
1173         infrun.c.  Initialize fields, add constructor.
1174         <inf>: Remove field.
1175         <reset>: New method.
1176         * infrun.c (struct displaced_step_inferior_state): Move to
1177         infrun.h.
1178         (displaced_step_inferior_states): Remove.
1179         (get_displaced_stepping_state): Adust.
1180         (displaced_step_in_progress_any_inferior): Adjust.
1181         (displaced_step_in_progress_thread): Adjust.
1182         (displaced_step_in_progress): Adjust.
1183         (add_displaced_stepping_state): Remove.
1184         (get_displaced_step_closure_by_addr): Adjust.
1185         (remove_displaced_stepping_state): Remove.
1186         (infrun_inferior_exit): Call displaced_step_state.reset.
1187         (use_displaced_stepping): Don't check for NULL.
1188         (displaced_step_prepare_throw): Call
1189         get_displaced_stepping_state.
1190         (displaced_step_fixup): Don't check for NULL.
1191         (prepare_for_detach): Don't check for NULL.
1192
1193 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1194
1195         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
1196          in case of call that did not complete.
1197
1198 2019-01-02  Andrey Utkin  <autkin@undo.io>
1199
1200         * symfile.c (find_separate_debug_file): Fix search of debug files for
1201         remote debuggee.
1202
1203 2019-01-02  Tom Tromey  <tom@tromey.com>
1204
1205         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
1206         indentation.
1207         * python/py-frame.c (frapy_older): Remove cast.
1208         (frapy_newer): Likewise.
1209         * python/py-breakpoint.c (local_setattro): Remove cast.
1210         * python/py-arch.c (archpy_name): Remove local variable.
1211         * python/py-type.c (gdbpy_lookup_type): Remove cast.
1212
1213 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
1214
1215         * unittests/basic_string_view/element_access/char/empty.cc:
1216         Fix year range in copyright header.
1217
1218 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1219
1220         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
1221         Delete.
1222         <operator==>: Update with for removed field.
1223         <hash>: Likewise.
1224         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
1225         <isa_features>: ...this.
1226         <abi_features>: New field.
1227         (riscv_isa_flen): Update comment.
1228         (riscv_abi_xlen): New declaration.
1229         (riscv_abi_flen): New declaration.
1230         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
1231         isa_features.
1232         (riscv_abi_xlen): New function.
1233         (riscv_isa_flen): Update to get answer from isa_features.
1234         (riscv_abi_flen): New function.
1235         (riscv_has_fp_abi): Update to get answer from abi_features.
1236         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
1237         xlen and flen.
1238         (riscv_call_info) <xlen, flen>: Update comment.
1239         (riscv_call_arg_struct): Remove invalid assertions
1240         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
1241         is removed.
1242         (riscv_gdbarch_init): Gather isa features and abi features
1243         separately, ensure both match on the gdbarch when reusing an old
1244         gdbarch.  Relax an error check to allow 32-bit abi float to run on
1245         a target with 64-bit float hardware.
1246
1247 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1248
1249         * source.c (search_command_helper): Stop reverse search
1250         when line 1 has been searched.
1251
1252 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1253
1254         * record-full.c (record_full_base_target::close): Rewrite
1255         record_full_core_buf_list free logic.
1256
1257 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1258
1259         * break-catch-syscall.c (print_one_catch_syscall): xfree
1260         the last text.
1261
1262 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1263
1264         * top.c (print_gdb_version): Update Copyright year in version
1265         message.
1266
1267 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1268
1269         Update copyright year range in all GDB files.
1270
1271 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
1272
1273         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
1274
1275 For older changes see ChangeLog-2018.
1276 \f
1277 Local Variables:
1278 mode: change-log
1279 left-margin: 8
1280 fill-column: 74
1281 version-control: never
1282 coding: utf-8
1283 End:
1284