61c566300da42eeb1779179033f1af234a27ab16
[external/binutils.git] / gdb / ChangeLog
1 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2
3         * f-exp.y (struct token): Add comments.
4         (dot_ops): Remove uppercase versions and the end marker.
5         (f77_keywords): Likewise.
6         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7         entries in the dot_ops array are case insensitive, and use
8         strncasecmp to compare strings.  Also some whitespace cleanup in
9         this area.  Similar for the f77_keywords array, except entries in
10         this list might be case sensitive.
11
12 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13
14         * f-exp.y (struct f77_boolean_val): Add comments.
15         (boolean_values): Remove uppercase versions, and end marker.
16         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
17         and use strncasecmp to achieve case insensitivity.  Additionally,
18         perform whitespace cleanup around this code.
19
20 2019-03-06  Tom Tromey  <tromey@adacore.com>
21
22         * remote-sim.c (gdbsim_target_open): Use result of
23         gdb_argv::release.
24
25 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
26         Dirk Schubert  <dirk.schubert@arm.com>
27         Chris January  <chris.january@arm.com>
28
29         * eval.c (evaluate_subexp_standard): Call Fortran argument
30         wrapping logic.
31         * f-lang.c (struct value): A value which can be passed into a
32         Fortran function call.
33         (fortran_argument_convert): Wrap Fortran arguments in a pointer
34         where appropriate.
35         (struct type): Value ready for a Fortran function call.
36         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
37         is needed.
38         * f-lang.h (fortran_argument_convert): Declaration.
39         (fortran_preserve_arg_pointer): Declaration.
40         * infcall.c (value_arg_coerce): Call Fortran argument logic.
41
42 2019-03-05  Tom Tromey  <tromey@adacore.com>
43
44         * python/py-prettyprint.c (print_string_repr): Remove #if.
45         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
46
47 2019-03-05  Tom Tromey  <tromey@adacore.com>
48
49         * target.c (the_dummy_target): Move later.  Change type to
50         "dummy_target".
51         (initialize_targets): Don't initialize the_dummy_target.
52
53 2019-03-05  Tom Tromey  <tromey@adacore.com>
54
55         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
56         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
57
58 2019-03-05  Tom Tromey  <tromey@adacore.com>
59
60         * windows-nat.c (windows_nat_target::attach)
61         (windows_nat_target::detach): Don't call gdb_flush.
62         * valprint.c (generic_val_print, val_print, val_print_string):
63         Don't call gdb_flush.
64         * utils.c (defaulted_query): Don't call gdb_flush.
65         * typeprint.c (print_type_scalar): Don't call gdb_flush.
66         * target.c (target_announce_detach): Don't call gdb_flush.
67         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
68         * remote.c (extended_remote_target::attach): Don't call
69         gdb_flush.
70         * procfs.c (procfs_target::detach): Don't call gdb_flush.
71         * printcmd.c (do_examine): Don't call gdb_flush.
72         (info_display_command): Don't call gdb_flush.
73         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
74         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
75         * memattr.c (info_mem_command): Don't call gdb_flush.
76         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
77         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
78         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
79         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
80         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
81         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
82         (gnu_nat_target::detach): Don't call gdb_flush.
83         * f-valprint.c (f_val_print): Don't call gdb_flush.
84         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
85         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
86         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
87         gdb_flush.
88         * c-valprint.c (c_val_print): Don't call gdb_flush.
89         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
90
91 2019-03-05  Tom Tromey  <tromey@adacore.com>
92
93         * varobj.c (update_dynamic_varobj_children): Update.
94         (install_default_visualizer): Use reset, not release.
95         * value.c (set_internalvar): Update.
96         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
97         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
98         ATTRIBUTE_UNUSED_RESULT.
99
100 2019-03-05  Tom Tromey  <tromey@adacore.com>
101
102         * remote.c (class scoped_remote_fd) <release>: Add
103         ATTRIBUTE_UNUSED_RESULT.
104
105 2019-03-05  Tom Tromey  <tromey@adacore.com>
106
107         * macroexp.c (struct macro_buffer) <release>: Add
108         ATTRIBUTE_UNUSED_RESULT.
109
110 2019-03-05  Tom Tromey  <tromey@adacore.com>
111
112         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
113         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
114         ATTRIBUTE_UNUSED_RESULT.
115
116 2019-03-05  Tom Tromey  <tromey@adacore.com>
117
118         * common/scoped_fd.h (class scoped_fd) <release>: Add
119         ATTRIBUTE_UNUSED_RESULT.
120
121 2019-03-05  Tom Tromey  <tromey@adacore.com>
122
123         * parser-defs.h (struct parser_state) <release>: Add
124         ATTRIBUTE_UNUSED_RESULT.
125
126 2019-03-05  Tom Tromey  <tromey@adacore.com>
127
128         * utils.h (class gdb_argv) <release>: Add
129         ATTRIBUTE_UNUSED_RESULT.
130         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
131
132 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
133
134         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
135         for-loop range, to avoid compiler warnings.
136
137         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
138         avoid compiler warnings about unused variables.
139
140         * NEWS: Mention end of support for native debugging on MS-Windows
141         before XP.
142
143         PR gdb/24292
144         * common/netstuff.c:
145         * gdbserver/gdbreplay.c
146         * gdbserver/remote-utils.c:
147         * ser-tcp.c:
148         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
149         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
150         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
151         'getaddrinfo' and 'freeaddrinfo' were not available before
152         Windows XP, and mingw.org's MinGW headers by default define
153         _WIN32_WINNT to 0x500.
154
155 2019-03-01  Gary Benson <gbenson@redhat.com>
156
157         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
158
159 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
160             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
161
162         PR gdb/8527
163         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
164         set_sigint_trap, clear_sigint_trap.
165
166 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
167
168         * target.c (target_detach): Clear the regcache and the
169         frame cache.
170
171 2019-02-27  Pedro Alves  <palves@redhat.com>
172
173         * utils.c (set_screen_size): When we cap the height/width sizes,
174         tweak the corresponding command variable to show "unlimited":
175
176 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
177             Pedro Alves  <palves@redhat.com>
178
179         * utils.c (set_screen_size): Reduce "infinite" rows and columns
180         before calling rl_set_screen_size.
181
182 2019-02-27  Tom Tromey  <tromey@adacore.com>
183
184         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
185         define.
186         * python/py-value.c: Remove Python 2.4 workaround.
187         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
188         workaround.
189         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
190         Python 2.4 workaround.
191         * python/python-internal.h: Remove Python 2.4 comment.
192         (Py_ssize_t): Don't define.
193         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
194         (gdb_Py_DECREF): Remove Python 2.4 workaround.
195         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
196         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
197         * python/python.c (do_start_initialization): Remove Python 2.4
198         workaround.
199         * python/py-prettyprint.c (class dummy_python_frame): Remove.
200         (print_children): Remove Python 2.4 workaround.
201         * python/py-inferior.c (buffer_procs): Remove Python 2.4
202         workaround.
203         (CHARBUFFERPROC_NAME): Remove.
204         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
205         Python 2.4 workaround.
206
207 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
208
209         * NEWS: Note minimum Python version.
210
211 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
212
213         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
214         code from these functions.  Remove corresponding ifdefs.  Use
215         Py_buffer_up instead of explicit calls to PyBuffer_Release.
216         Remove gotos and target of gotos.
217         (infpy_search_memory): Likewise.
218
219 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
220
221         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
222         (hppa_gdbarch_init): Don't register deleted functions with
223         gdbarch.
224
225 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
226
227         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
228         (h8300_unwind_sp): Delete.
229         (h8300_dummy_id): Delete.
230         (h8300_gdbarch_init): Don't register deleted functions with
231         gdbarch.
232
233 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
234
235         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
236         (ft32_unwind_pc): Delete.
237         (ft32_unwind_sp): Delete.
238         (ft32_gdbarch_init): Don't register deleted functions with
239         gdbarch.
240
241 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
242
243         * gdb/frv-tdep.c (frv_dummy_id): Delete.
244         (frv_unwind_pc): Delete.
245         (frv_unwind_sp): Delete.
246         (frv_gdbarch_init): Don't register deleted functions with
247         gdbarch.
248
249 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
250
251         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
252         (riscv_unwind_pc): Delete.
253         (riscv_unwind_sp): Delete.
254         (riscv_gdbarch_init): Don't register deleted functions with
255         gdbarch.
256
257 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
258
259         * gdb/csky-tdep.c (csky_dummy_id): Delete.
260         (csky_unwind_pc): Delete.
261         (csky_unwind_sp): Delete.
262         (csky_gdbarch_init): Don't register deleted functions with
263         gdbarch.
264
265 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
266
267         * gdb/cris-tdep.c (cris_dummy_id): Delete.
268         (cris_unwind_pc): Delete.
269         (cris_unwind_sp): Delete.
270         (cris_gdbarch_init): Don't register deleted functions with
271         gdbarch.
272
273 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
274
275         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
276         (bfin_unwind_pc): Delete.
277         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
278
279 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
280
281         * gdb/arm-tdep.c (arm_dummy_id): Delete.
282         (arm_unwind_pc): Delete.
283         (arm_unwind_sp): Delete.
284         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
285
286 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
287
288         * gdb/arc-tdep.c (arc_dummy_id): Delete.
289         (arc_unwind_pc): Delete.
290         (arc_unwind_sp): Delete.
291         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
292
293 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
294
295         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
296         (alpha_unwind_pc): Delete.
297         (alpha_gdbarch_init): Don't register deleted functions with
298         gdbarch.
299
300 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
301
302         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
303         (aarch64_unwind_pc): Delete.
304         (aarch64_unwind_sp): Delete.
305         (aarch64_gdbarch_init): Don't register deleted functions with
306         gdbarch.
307
308 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
309
310         * gdbtypes.c (type_align): Don't consider static members when
311         computing structure alignment.
312
313 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
314
315         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
316         return 0 for other types.
317         * arch-utils.c (default_type_align): Always return 0.
318         * gdbarch.h: Regenerate.
319         * gdbarch.sh (type_align): Extend comment.
320         * gdbtypes.c (type_align): Add additional comments, always call
321         gdbarch_type_align before applying the default rules.
322         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
323         generic code will then apply a suitable default.
324         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
325         types, return 0 for other types.
326
327 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
328
329         * NEWS: Create a new section for the next release branch.
330         Rename the section of the current branch, now that it has
331         been cut.
332
333 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
334
335         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
336         * version.in: Bump version to 8.3.50.DATE-git.
337
338 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
339
340         * aix-thread.c (ptid_cmp): Remove unused variable.
341         (get_signaled_thread): Likewise.
342         (store_regs_user_thread): Likewise.
343         (store_regs_kernel_thread): Likewise.
344         (fetch_regs_kernel_thread): Remove shadowed variable.
345
346 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
347
348         * features/riscv/32bit-cpu.xml: Add register numbers.
349         * features/riscv/32bit-fpu.c: Regenerate.
350         * features/riscv/32bit-fpu.xml: Add register numbers.
351         * features/riscv/64bit-cpu.xml: Add register numbers.
352         * features/riscv/64bit-fpu.c: Regenerate.
353         * features/riscv/64bit-fpu.xml: Add register numbers.
354
355 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
356
357         * NEWS: Mention two argument form of gdb.Value constructor.
358         * python/py-value.c (convert_buffer_and_type_to_value): New
359         function.
360         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
361         Add support for handling an optional second argument.  Call
362         convert_buffer_and_type_to_value as appropriate.
363         * python/python-internal.h (Py_buffer_deleter): New struct.
364         (Py_buffer_up): New typedef.
365
366 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
367
368         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
369         instead of releasing ownership.
370
371 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
372
373         * dwarf2read.c (open_and_init_dwp_file): Call
374         elf_numsections instead of bfd_count_sections to initialize
375         dwp_file->num_sections.
376
377 2019-02-25  Tom Tromey  <tromey@adacore.com>
378
379         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
380
381 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
382
383         * gcore.in: Add '--readnever' option when invoking GDB.
384
385 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
386
387         * MAINTAINERS: Update my email address.
388
389 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
390
391         * build-id.c (build_id_to_debug_bfd_1): New function.
392         (build_id_to_debug_bfd): Look for separate debug file in
393         sysroot.
394
395 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
396
397         * gdbarch.sh: Update the copyright year range that is placed into
398         generated files.
399
400 2019-02-22  Keith Seitz  <keiths@redhat.com>
401
402         PR symtab/23853
403         * linespec.c (create_sals_line_offset): Search for the default
404         symtab's filename instead of its fullname.
405
406 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
407
408         * NEWS: Update style defaults.
409
410 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
411
412         * main.c (captured_main_1): Disable styling in batch mode.
413
414 2019-02-20  Tom Tromey  <tom@tromey.com>
415
416         * symtab.c (symtab_symbol_info): Fix typos.
417
418 2019-02-20  Tom Tromey  <tromey@adacore.com>
419
420         * findcmd.c (_initialize_mem_search): Use upper case for
421         metasyntactic variables.
422
423 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
424
425         * aarch64-tdep.c (aarch64_add_reggroups): New function.
426         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
427
428 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
429
430         * top.h (source_file_name): Change to std::string.
431         * top.c (source_file_name): Likewise.
432         (command_line_input): Adjust.
433         * cli/cli-script.c (script_from_file): Adjust.
434
435 2019-02-19  Tom Tromey  <tromey@adacore.com>
436
437         * ravenscar-thread.c
438         (ravenscar_thread_target::update_thread_list): Don't call
439         ada_build_task_list.
440         * ada-lang.h (ada_build_task_list): Don't declare.
441         * ada-tasks.c (struct ada_tasks_inferior_data)
442         <task_list_valid_p>: Now bool.
443         (read_known_tasks, ada_task_list_changed)
444         (ada_tasks_invalidate_inferior_data): Update.
445         (read_known_tasks_array): Return bool.
446         (read_known_tasks_list): Likewise.
447         (read_known_tasks): Return void.
448         (ada_build_task_list): Now static.
449
450 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
451
452         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
453         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
454
455 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
456
457         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
458         variant for ada_tasks_pspace_data_handle and
459         ada_tasks_inferior_data_handle.
460         (ada_tasks_pspace_data_cleanup): New function.
461         (ada_tasks_inferior_data_cleanup): New function.
462
463 2019-02-17  Tom Tromey  <tom@tromey.com>
464
465         * macrotab.h (macro_source_fullname): Return a std::string.
466         * macrotab.c (macro_include, check_for_redefinition)
467         (macro_undef, macro_lookup_definition, foreach_macro)
468         (foreach_macro_in_scope): Update.
469         (macro_source_fullname): Return a std::string.
470         * macrocmd.c (show_pp_source_pos): Update.
471
472 2019-02-17  Tom Tromey  <tom@tromey.com>
473
474         * macrocmd.c (show_pp_source_pos): Style the file names.
475
476 2019-02-17  Tom Tromey  <tom@tromey.com>
477
478         PR tui/24197:
479         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
480
481 2019-02-17  Tom Tromey  <tom@tromey.com>
482
483         * ada-lang.c (user_select_syms): Use filtered printing.
484         * utils.c (wrap_style): New global.
485         (desired_style): Remove.
486         (emit_style_escape): Add stream parameter.
487         (set_output_style, reset_terminal_style, prompt_for_continue):
488         Update.
489         (flush_wrap_buffer): Only flush gdb_stdout.
490         (wrap_here): Set wrap_style.
491         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
492         treat escape sequences as a character.  Change when wrap buffer is
493         flushed.
494         (fputs_styled): Do not set the output style when the default is
495         requested.
496         * ui-style.h (struct ui_file_style) <is_default>: New method.
497         * source.c (print_source_lines_base): Emit escape sequences in one
498         piece.
499
500 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
501
502         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
503         integers and enumeration types.
504
505 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
506
507         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
508         instead of lookup_symbol_in_language
509         (do_exact_match): New function.
510         (ada_get_symbol_name_matcher): Return do_exact_match when
511         doing a verbatim match.
512
513 2019-02-15  Tom Tromey  <tromey@adacore.com>
514
515         * ravenscar-thread.c (ravenscar_thread_target::resume)
516         (ravenscar_thread_target::wait): Special case wildcard requests.
517
518 2019-02-15  Tom Tromey  <tromey@adacore.com>
519
520         * ravenscar-thread.c (base_ptid): Remove.
521         (struct ravenscar_thread_target) <close>: New method.
522         <m_base_ptid>: New member.
523         <update_inferior_ptid, active_task, task_is_currently_active,
524         runtime_initialized>: Declare methods.
525         <ravenscar_thread_target>: Add constructor.
526         (ravenscar_thread_target::task_is_currently_active)
527         (ravenscar_thread_target::update_inferior_ptid)
528         (ravenscar_runtime_initialized): Rename.  Now methods.
529         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
530         (ravenscar_thread_target::update_thread_list): Update.
531         (ravenscar_thread_target::active_task): Now method.
532         (ravenscar_thread_target::store_registers)
533         (ravenscar_thread_target::prepare_to_store)
534         (ravenscar_thread_target::prepare_to_store)
535         (ravenscar_thread_target::mourn_inferior): Update.
536         (ravenscar_inferior_created): Use "new" to create target.
537         (ravenscar_thread_target::get_ada_task_ptid): Update.
538         (_initialize_ravenscar): Don't initialize base_ptid.
539         (ravenscar_ops): Remove global.
540
541 2019-02-15  Tom Tromey  <tromey@adacore.com>
542
543         * target.h (push_target): Declare new overload.
544         * target.c (push_target): New overload, taking an rvalue reference.
545         * remote.c (remote_target::open_1): Use push_target overload.
546         * corelow.c (core_target_open): Use push_target overload.
547
548 2019-02-15  Tom Tromey  <tromey@adacore.com>
549
550         * ravenscar-thread.c (is_ravenscar_task)
551         (ravenscar_task_is_currently_active): Return bool.
552         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
553         (_initialize_ravenscar): Remove "(void)".
554         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
555         Return bool.
556
557 2019-02-15  Tom Tromey  <tromey@adacore.com>
558
559         * ravenscar-thread.c (ravenscar_runtime_initializer)
560         (has_ravenscar_runtime, get_running_thread_id)
561         (ravenscar_thread_target::resume): Fix indentation.
562
563 2019-02-15  Tom Tromey  <tromey@adacore.com>
564
565         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
566         from ravenscar_arch_ops.
567         (sparc_ravenscar_ops::fetch_registers)
568         (sparc_ravenscar_ops::store_registers): Now methods.
569         (sparc_ravenscar_prepare_to_store): Remove.
570         (sparc_ravenscar_ops): Redefine.
571         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
572         methods and destructor.  Remove members.
573         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
574         (ravenscar_thread_target::store_registers)
575         (ravenscar_thread_target::prepare_to_store): Update.
576         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
577         Remove.
578         (struct ppc_ravenscar_powerpc_ops): Derive from
579         ravenscar_arch_ops.
580         (ppc_ravenscar_powerpc_ops::fetch_registers)
581         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
582         (ppc_ravenscar_powerpc_ops): Redefine.
583         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
584         (ppc_ravenscar_e500_ops::fetch_registers)
585         (ppc_ravenscar_e500_ops::store_registers): Now methods.
586         (ppc_ravenscar_e500_ops): Redefine.
587         * aarch64-ravenscar-thread.c
588         (aarch64_ravenscar_generic_prepare_to_store): Remove.
589         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
590         (aarch64_ravenscar_fetch_registers)
591         (aarch64_ravenscar_store_registers): Now methods.
592         (aarch64_ravenscar_ops): Redefine.
593
594 2019-02-15  Tom Tromey  <tromey@adacore.com>
595
596         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
597         (ravenscar_thread_target::stopped_by_hw_breakpoint)
598         (ravenscar_thread_target::stopped_by_watchpoint)
599         (ravenscar_thread_target::stopped_data_address)
600         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
601
602 2019-02-15  Tom Tromey  <tromey@adacore.com>
603
604         * ravenscar-thread.c: Fix some typos.
605
606 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
607             Tom Tromey  <tromey@adacore.com>
608
609         * ada-lang.c (ada_exception_sal): Change addr_string to a
610         std::string.
611         (create_ada_exception_catchpoint): Update.
612
613 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
614             Tom Tromey  <tromey@adacore.com>
615
616         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
617         (bp_location_ops): Remove.
618         (base_breakpoint_allocate_location): Update.
619         (free_bp_location): Update.
620         * ada-lang.c (class ada_catchpoint_location)
621         <ada_catchpoint_location>: Remove ops parameter.
622         (ada_catchpoint_location_dtor): Remove.
623         (ada_catchpoint_location_ops): Remove.
624         (allocate_location_exception): Update.
625         * breakpoint.h (struct bp_location_ops): Remove.
626         (class bp_location) <bp_location>: Remove bp_location_ops
627         parameter.
628         <~bp_location>: Add destructor.
629         <ops>: Remove.
630
631 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
632             Pedro Alves  <palves@redhat.com>
633
634         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
635         'PATH_MAX'.
636
637 2019-02-14  David Michael  <fedora.dm0@gmail.com>
638             Samuel Thibault  <samuel.thibault@gnu.org>
639             Thomas Schwinge  <thomas@codesourcery.com>
640
641         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
642         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
643
644 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
645
646         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
647         (check_empty): Use "const char *".
648
649         * gnu-nat.c (gnu_nat_target::detach): Instead of
650         'detach_inferior (pid)' call
651         'detach_inferior (find_inferior_pid (pid))'.
652
653         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
654         'nat/fork-inferior.o'.
655         * gnu-nat.c: #include "nat/fork-inferior.h".
656
657         * gnu-nat.c (gnu_nat_target::detach): Instead of
658         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
659         * gnu-nat.h: #include "inf-child.h".
660         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
661         'i386_gnu_nat_target::fetch_registers'.
662         (gnu_store_registers): Rename/move to
663         'i386_gnu_nat_target::store_registers'.
664
665         * config/i386/nm-i386gnu.h: Don't "#include" any files.
666         * gnu-nat.h (mach_thread_info): New function.
667         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
668
669         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
670
671 2019-02-14  Frederic Konrad  <konrad@adacore.com>
672
673         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
674
675 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
676
677         * windows-nat.c (windows_add_thread): Add new parameter
678         "main_thread_p" with default value set to false.  Update
679         function documentation as well as all callers.
680         (windows_delete_thread): Likewise.
681         (fake_create_process): Update call to windows_add_thread.
682         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
683         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
684         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
685         call to windows_delete_thread.
686
687 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
688
689         * MAINTAINERS: Add Andrew Burgess as global maintainer.
690
691 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
692
693         * symfile.c (find_separate_debug_file): Use canonical path of
694         sysroot with child_path instead of gdb_sysroot if it is valid.
695
696 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
697
698         * symfile.c (find_separate_debug_file): Use child_path to
699         determine if an object file is under a sysroot.
700
701 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
702
703         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
704         unittests/child-path-selftests.c.
705         * common/pathstuff.c (child_path): New function.
706         * common/pathstuff.h (child_path): New prototype.
707         * unittests/child-path-selftests.c: New file.
708
709 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
710
711         * symfile.c (find_separate_debug_file): Look for separate debug
712         files in debug directories under the sysroot.
713
714 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
715
716         * symtab.h (struct minimal_symbol data_p): New const method.
717         (struct minimal_symbol text_p): Likewise.
718         * symtab.c (output_source_filename): Use file name style
719         to print file name.
720         (print_symbol_info): Likewise.
721         (print_msymbol_info): Use address style to print addresses.
722         Use function name style to print executable text symbols.
723         (expand_symtab_containing_pc): Use data_p.
724         (find_pc_sect_compunit_symtab): Likewise.
725
726 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
727
728         * breakpoint.c (describe_other_breakpoints): Use address style
729         to print addresses.
730         (say_where): Likewise.
731
732 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
733
734         * ada-typeprint.c (print_func_type): Print function name
735         style to print function name.
736         * c-typeprint.c (c_print_type_1): Likewise.
737
738 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
739
740         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
741         for execve.
742
743 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
744
745         * c-exp.y (direct_abs_decl): Use emplace_back to record the
746         type_stack.
747
748 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
749
750         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
751         TYPE_CODE_REF types.
752
753 2019-02-08  Jim Wilson  <jimw@sifive.com>
754
755         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
756         (riscv_linux_fregset): New.
757         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
758
759 2019-02-07  Tom Tromey  <tom@tromey.com>
760
761         * thread.c (thread_cancel_execution_command): Update.
762         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
763         methods.
764         (struct thread_fsm_ops): Remove.
765         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
766         (thread_fsm_should_stop, thread_fsm_return_value)
767         (thread_fsm_set_finished, thread_fsm_finished_p)
768         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
769         Don't declare.
770         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
771         * infrun.c (clear_proceed_status_thread)
772         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
773         (print_stop_event): Update.
774         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
775         Add constructor.
776         (step_command_fsm_ops): Remove.
777         (new_step_command_fsm): Remove.
778         (step_1): Update.
779         (step_command_fsm::should_stop): Rename from
780         step_command_fsm_should_stop.
781         (step_command_fsm::clean_up): Rename from
782         step_command_fsm_clean_up.
783         (step_command_fsm::do_async_reply_reason): Rename from
784         step_command_fsm_async_reply_reason.
785         (struct until_next_fsm): Inherit from thread_fsm.  Add
786         constructor.
787         (until_next_fsm_ops): Remove.
788         (new_until_next_fsm): Remove.
789         (until_next_fsm::should_stop): Rename from
790         until_next_fsm_should_stop.
791         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
792         (until_next_fsm::do_async_reply_reason): Rename from
793         until_next_fsm_async_reply_reason.
794         (struct finish_command_fsm): Inherit from thread_fsm.  Add
795         constructor.  Change type of breakpoint.
796         (finish_command_fsm_ops): Remove.
797         (new_finish_command_fsm): Remove.
798         (finish_command_fsm::should_stop): Rename from
799         finish_command_fsm_should_stop.
800         (finish_command_fsm::clean_up): Rename from
801         finish_command_fsm_clean_up.
802         (finish_command_fsm::return_value): Rename from
803         finish_command_fsm_return_value.
804         (finish_command_fsm::do_async_reply_reason): Rename from
805         finish_command_fsm_async_reply_reason.
806         (finish_command): Update.
807         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
808         Add constructor.
809         (call_thread_fsm_ops): Remove.
810         (call_thread_fsm::call_thread_fsm): Rename from
811         new_call_thread_fsm.
812         (call_thread_fsm::should_stop): Rename from
813         call_thread_fsm_should_stop.
814         (call_thread_fsm::should_notify_stop): Rename from
815         call_thread_fsm_should_notify_stop.
816         (run_inferior_call, call_function_by_hand_dummy): Update.
817         * cli/cli-interp.c (should_print_stop_to_console): Update.
818         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
819         Add constructor.  Change type of location_breakpoint,
820         caller_breakpoint.
821         (until_break_fsm_ops): Remove.
822         (new_until_break_fsm): Remove.
823         (until_break_fsm::should_stop): Rename from
824         until_break_fsm_should_stop.
825         (until_break_fsm::clean_up): Rename from
826         until_break_fsm_clean_up.
827         (until_break_fsm::do_async_reply_reason): Rename from
828         until_break_fsm_async_reply_reason.
829         (until_break_command): Update.
830         * thread-fsm.c: Remove.
831         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
832
833 2019-02-07  Tom Tromey  <tom@tromey.com>
834
835         * yy-remap.h: Add include guard.
836         * xtensa-tdep.h: Add include guard.
837         * xcoffread.h: Rename include guard.
838         * varobj-iter.h: Add include guard.
839         * tui/tui.h: Rename include guard.
840         * tui/tui-winsource.h: Rename include guard.
841         * tui/tui-wingeneral.h: Rename include guard.
842         * tui/tui-windata.h: Rename include guard.
843         * tui/tui-win.h: Rename include guard.
844         * tui/tui-stack.h: Rename include guard.
845         * tui/tui-source.h: Rename include guard.
846         * tui/tui-regs.h: Rename include guard.
847         * tui/tui-out.h: Rename include guard.
848         * tui/tui-layout.h: Rename include guard.
849         * tui/tui-io.h: Rename include guard.
850         * tui/tui-hooks.h: Rename include guard.
851         * tui/tui-file.h: Rename include guard.
852         * tui/tui-disasm.h: Rename include guard.
853         * tui/tui-data.h: Rename include guard.
854         * tui/tui-command.h: Rename include guard.
855         * tic6x-tdep.h: Add include guard.
856         * target/waitstatus.h: Rename include guard.
857         * target/wait.h: Rename include guard.
858         * target/target.h: Rename include guard.
859         * target/resume.h: Rename include guard.
860         * target-float.h: Rename include guard.
861         * stabsread.h: Add include guard.
862         * rs6000-tdep.h: Add include guard.
863         * riscv-fbsd-tdep.h: Add include guard.
864         * regformats/regdef.h: Rename include guard.
865         * record.h: Rename include guard.
866         * python/python.h: Rename include guard.
867         * python/python-internal.h: Rename include guard.
868         * python/py-stopevent.h: Rename include guard.
869         * python/py-ref.h: Rename include guard.
870         * python/py-record.h: Rename include guard.
871         * python/py-record-full.h: Rename include guard.
872         * python/py-record-btrace.h: Rename include guard.
873         * python/py-instruction.h: Rename include guard.
874         * python/py-events.h: Rename include guard.
875         * python/py-event.h: Rename include guard.
876         * procfs.h: Add include guard.
877         * proc-utils.h: Add include guard.
878         * p-lang.h: Add include guard.
879         * or1k-tdep.h: Rename include guard.
880         * observable.h: Rename include guard.
881         * nto-tdep.h: Rename include guard.
882         * nat/x86-linux.h: Rename include guard.
883         * nat/x86-linux-dregs.h: Rename include guard.
884         * nat/x86-gcc-cpuid.h: Add include guard.
885         * nat/x86-dregs.h: Rename include guard.
886         * nat/x86-cpuid.h: Rename include guard.
887         * nat/ppc-linux.h: Rename include guard.
888         * nat/mips-linux-watch.h: Rename include guard.
889         * nat/linux-waitpid.h: Rename include guard.
890         * nat/linux-ptrace.h: Rename include guard.
891         * nat/linux-procfs.h: Rename include guard.
892         * nat/linux-osdata.h: Rename include guard.
893         * nat/linux-nat.h: Rename include guard.
894         * nat/linux-namespaces.h: Rename include guard.
895         * nat/linux-btrace.h: Rename include guard.
896         * nat/glibc_thread_db.h: Rename include guard.
897         * nat/gdb_thread_db.h: Rename include guard.
898         * nat/gdb_ptrace.h: Rename include guard.
899         * nat/fork-inferior.h: Rename include guard.
900         * nat/amd64-linux-siginfo.h: Rename include guard.
901         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
902         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
903         * nat/aarch64-linux.h: Rename include guard.
904         * nat/aarch64-linux-hw-point.h: Rename include guard.
905         * mn10300-tdep.h: Add include guard.
906         * mips-linux-tdep.h: Add include guard.
907         * mi/mi-parse.h: Rename include guard.
908         * mi/mi-out.h: Rename include guard.
909         * mi/mi-main.h: Rename include guard.
910         * mi/mi-interp.h: Rename include guard.
911         * mi/mi-getopt.h: Rename include guard.
912         * mi/mi-console.h: Rename include guard.
913         * mi/mi-common.h: Rename include guard.
914         * mi/mi-cmds.h: Rename include guard.
915         * mi/mi-cmd-break.h: Rename include guard.
916         * m2-lang.h: Add include guard.
917         * location.h: Rename include guard.
918         * linux-record.h: Rename include guard.
919         * linux-nat.h: Add include guard.
920         * linux-fork.h: Add include guard.
921         * i386-darwin-tdep.h: Rename include guard.
922         * hppa-linux-offsets.h: Add include guard.
923         * guile/guile.h: Rename include guard.
924         * guile/guile-internal.h: Rename include guard.
925         * gnu-nat.h: Rename include guard.
926         * gdb-stabs.h: Rename include guard.
927         * frv-tdep.h: Add include guard.
928         * f-lang.h: Add include guard.
929         * event-loop.h: Add include guard.
930         * darwin-nat.h: Rename include guard.
931         * cp-abi.h: Rename include guard.
932         * config/sparc/nm-sol2.h: Rename include guard.
933         * config/nm-nto.h: Rename include guard.
934         * config/nm-linux.h: Add include guard.
935         * config/i386/nm-i386gnu.h: Rename include guard.
936         * config/djgpp/nl_types.h: Rename include guard.
937         * config/djgpp/langinfo.h: Rename include guard.
938         * compile/gcc-cp-plugin.h: Add include guard.
939         * compile/gcc-c-plugin.h: Add include guard.
940         * compile/compile.h: Rename include guard.
941         * compile/compile-object-run.h: Rename include guard.
942         * compile/compile-object-load.h: Rename include guard.
943         * compile/compile-internal.h: Rename include guard.
944         * compile/compile-cplus.h: Rename include guard.
945         * compile/compile-c.h: Rename include guard.
946         * common/xml-utils.h: Rename include guard.
947         * common/x86-xstate.h: Rename include guard.
948         * common/version.h: Rename include guard.
949         * common/vec.h: Rename include guard.
950         * common/tdesc.h: Rename include guard.
951         * common/selftest.h: Rename include guard.
952         * common/scoped_restore.h: Rename include guard.
953         * common/scoped_mmap.h: Rename include guard.
954         * common/scoped_fd.h: Rename include guard.
955         * common/safe-iterator.h: Rename include guard.
956         * common/run-time-clock.h: Rename include guard.
957         * common/refcounted-object.h: Rename include guard.
958         * common/queue.h: Rename include guard.
959         * common/ptid.h: Rename include guard.
960         * common/print-utils.h: Rename include guard.
961         * common/preprocessor.h: Rename include guard.
962         * common/pathstuff.h: Rename include guard.
963         * common/observable.h: Rename include guard.
964         * common/netstuff.h: Rename include guard.
965         * common/job-control.h: Rename include guard.
966         * common/host-defs.h: Rename include guard.
967         * common/gdb_wait.h: Rename include guard.
968         * common/gdb_vecs.h: Rename include guard.
969         * common/gdb_unlinker.h: Rename include guard.
970         * common/gdb_unique_ptr.h: Rename include guard.
971         * common/gdb_tilde_expand.h: Rename include guard.
972         * common/gdb_sys_time.h: Rename include guard.
973         * common/gdb_string_view.h: Rename include guard.
974         * common/gdb_splay_tree.h: Rename include guard.
975         * common/gdb_setjmp.h: Rename include guard.
976         * common/gdb_ref_ptr.h: Rename include guard.
977         * common/gdb_optional.h: Rename include guard.
978         * common/gdb_locale.h: Rename include guard.
979         * common/gdb_assert.h: Rename include guard.
980         * common/filtered-iterator.h: Rename include guard.
981         * common/filestuff.h: Rename include guard.
982         * common/fileio.h: Rename include guard.
983         * common/environ.h: Rename include guard.
984         * common/common-utils.h: Rename include guard.
985         * common/common-types.h: Rename include guard.
986         * common/common-regcache.h: Rename include guard.
987         * common/common-inferior.h: Rename include guard.
988         * common/common-gdbthread.h: Rename include guard.
989         * common/common-exceptions.h: Rename include guard.
990         * common/common-defs.h: Rename include guard.
991         * common/common-debug.h: Rename include guard.
992         * common/cleanups.h: Rename include guard.
993         * common/buffer.h: Rename include guard.
994         * common/btrace-common.h: Rename include guard.
995         * common/break-common.h: Rename include guard.
996         * cli/cli-utils.h: Rename include guard.
997         * cli/cli-style.h: Rename include guard.
998         * cli/cli-setshow.h: Rename include guard.
999         * cli/cli-script.h: Rename include guard.
1000         * cli/cli-interp.h: Rename include guard.
1001         * cli/cli-decode.h: Rename include guard.
1002         * cli/cli-cmds.h: Rename include guard.
1003         * charset-list.h: Add include guard.
1004         * buildsym-legacy.h: Rename include guard.
1005         * bfin-tdep.h: Add include guard.
1006         * ax.h: Rename include guard.
1007         * arm-linux-tdep.h: Add include guard.
1008         * arm-fbsd-tdep.h: Add include guard.
1009         * arch/xtensa.h: Rename include guard.
1010         * arch/tic6x.h: Add include guard.
1011         * arch/i386.h: Add include guard.
1012         * arch/arm.h: Rename include guard.
1013         * arch/arm-linux.h: Rename include guard.
1014         * arch/arm-get-next-pcs.h: Rename include guard.
1015         * arch/amd64.h: Add include guard.
1016         * arch/aarch64-insn.h: Rename include guard.
1017         * arch-utils.h: Rename include guard.
1018         * annotate.h: Add include guard.
1019         * amd64-darwin-tdep.h: Rename include guard.
1020         * aarch64-linux-tdep.h: Add include guard.
1021         * aarch64-fbsd-tdep.h: Add include guard.
1022         * aarch32-linux-nat.h: Add include guard.
1023
1024 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1025
1026         * macrotab.c (macro_define_internal): New function that
1027         factorizes macro_define_object_internal and macro_define_function
1028         code.
1029         (macro_define_object_internal): Use macro_define_internal.
1030         (macro_define_function): Likewise.
1031
1032 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1033
1034         * macrocmd.c (extract_identifier): Return
1035         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
1036         callers.
1037
1038 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1039
1040         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1041
1042 2019-02-05  Tom Tromey  <tom@tromey.com>
1043
1044         * target.c (target_stack::unpush): Move assertion earlier.
1045
1046 2019-01-30  Tom Tromey  <tom@tromey.com>
1047
1048         PR python/23615:
1049         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1050         (gdbpy_parse_and_eval): Likewise.
1051         * python/python-internal.h (gdbpy_allow_threads): New class.
1052
1053 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1054
1055         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1056         (aarch64_fbsd_fpregmap): Move earlier.
1057         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1058         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1059         instead of individual calls to trad_frame_set_reg_addr.
1060         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1061         earlier.
1062         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1063         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1064         instead of individual calls to trad_frame_set_reg_addr.
1065
1066 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1067
1068         * CONTRIBUTE: Replace contribution list with wiki link.
1069
1070 2019-01-25  Tom Tromey  <tom@tromey.com>
1071
1072         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1073
1074 2019-01-25  Tom Tromey  <tom@tromey.com>
1075
1076         * xtensa-linux-nat.c: Fix common/ includes.
1077         * xml-support.h: Fix common/ includes.
1078         * xml-support.c: Fix common/ includes.
1079         * x86-linux-nat.c: Fix common/ includes.
1080         * windows-nat.c: Fix common/ includes.
1081         * varobj.h: Fix common/ includes.
1082         * varobj.c: Fix common/ includes.
1083         * value.c: Fix common/ includes.
1084         * valops.c: Fix common/ includes.
1085         * utils.c: Fix common/ includes.
1086         * unittests/xml-utils-selftests.c: Fix common/ includes.
1087         * unittests/utils-selftests.c: Fix common/ includes.
1088         * unittests/unpack-selftests.c: Fix common/ includes.
1089         * unittests/tracepoint-selftests.c: Fix common/ includes.
1090         * unittests/style-selftests.c: Fix common/ includes.
1091         * unittests/string_view-selftests.c: Fix common/ includes.
1092         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1093         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1094         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1095         * unittests/rsp-low-selftests.c: Fix common/ includes.
1096         * unittests/parse-connection-spec-selftests.c: Fix common/
1097         includes.
1098         * unittests/optional-selftests.c: Fix common/ includes.
1099         * unittests/offset-type-selftests.c: Fix common/ includes.
1100         * unittests/observable-selftests.c: Fix common/ includes.
1101         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1102         * unittests/memrange-selftests.c: Fix common/ includes.
1103         * unittests/memory-map-selftests.c: Fix common/ includes.
1104         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1105         * unittests/function-view-selftests.c: Fix common/ includes.
1106         * unittests/environ-selftests.c: Fix common/ includes.
1107         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1108         * unittests/common-utils-selftests.c: Fix common/ includes.
1109         * unittests/cli-utils-selftests.c: Fix common/ includes.
1110         * unittests/array-view-selftests.c: Fix common/ includes.
1111         * ui-file.c: Fix common/ includes.
1112         * tui/tui-io.c: Fix common/ includes.
1113         * tracepoint.h: Fix common/ includes.
1114         * tracepoint.c: Fix common/ includes.
1115         * tracefile-tfile.c: Fix common/ includes.
1116         * top.h: Fix common/ includes.
1117         * top.c: Fix common/ includes.
1118         * thread.c: Fix common/ includes.
1119         * target/waitstatus.h: Fix common/ includes.
1120         * target/waitstatus.c: Fix common/ includes.
1121         * target.h: Fix common/ includes.
1122         * target.c: Fix common/ includes.
1123         * target-memory.c: Fix common/ includes.
1124         * target-descriptions.c: Fix common/ includes.
1125         * symtab.h: Fix common/ includes.
1126         * symfile.c: Fix common/ includes.
1127         * stap-probe.c: Fix common/ includes.
1128         * spu-linux-nat.c: Fix common/ includes.
1129         * sparc-nat.c: Fix common/ includes.
1130         * source.c: Fix common/ includes.
1131         * solib.c: Fix common/ includes.
1132         * solib-target.c: Fix common/ includes.
1133         * ser-unix.c: Fix common/ includes.
1134         * ser-tcp.c: Fix common/ includes.
1135         * ser-pipe.c: Fix common/ includes.
1136         * ser-base.c: Fix common/ includes.
1137         * selftest-arch.c: Fix common/ includes.
1138         * s12z-tdep.c: Fix common/ includes.
1139         * rust-exp.y: Fix common/ includes.
1140         * rs6000-aix-tdep.c: Fix common/ includes.
1141         * riscv-tdep.c: Fix common/ includes.
1142         * remote.c: Fix common/ includes.
1143         * remote-notif.h: Fix common/ includes.
1144         * remote-fileio.h: Fix common/ includes.
1145         * remote-fileio.c: Fix common/ includes.
1146         * regcache.h: Fix common/ includes.
1147         * regcache.c: Fix common/ includes.
1148         * record-btrace.c: Fix common/ includes.
1149         * python/python.c: Fix common/ includes.
1150         * python/py-type.c: Fix common/ includes.
1151         * python/py-inferior.c: Fix common/ includes.
1152         * progspace.h: Fix common/ includes.
1153         * producer.c: Fix common/ includes.
1154         * procfs.c: Fix common/ includes.
1155         * proc-api.c: Fix common/ includes.
1156         * printcmd.c: Fix common/ includes.
1157         * ppc-linux-nat.c: Fix common/ includes.
1158         * parser-defs.h: Fix common/ includes.
1159         * osdata.c: Fix common/ includes.
1160         * obsd-nat.c: Fix common/ includes.
1161         * nat/x86-linux.c: Fix common/ includes.
1162         * nat/x86-linux-dregs.c: Fix common/ includes.
1163         * nat/x86-dregs.h: Fix common/ includes.
1164         * nat/x86-dregs.c: Fix common/ includes.
1165         * nat/ppc-linux.c: Fix common/ includes.
1166         * nat/mips-linux-watch.h: Fix common/ includes.
1167         * nat/mips-linux-watch.c: Fix common/ includes.
1168         * nat/linux-waitpid.c: Fix common/ includes.
1169         * nat/linux-ptrace.h: Fix common/ includes.
1170         * nat/linux-ptrace.c: Fix common/ includes.
1171         * nat/linux-procfs.c: Fix common/ includes.
1172         * nat/linux-personality.c: Fix common/ includes.
1173         * nat/linux-osdata.c: Fix common/ includes.
1174         * nat/linux-namespaces.c: Fix common/ includes.
1175         * nat/linux-btrace.h: Fix common/ includes.
1176         * nat/linux-btrace.c: Fix common/ includes.
1177         * nat/fork-inferior.c: Fix common/ includes.
1178         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1179         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1180         * nat/aarch64-linux.c: Fix common/ includes.
1181         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1182         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1183         * namespace.h: Fix common/ includes.
1184         * mips-linux-tdep.c: Fix common/ includes.
1185         * minsyms.c: Fix common/ includes.
1186         * mi/mi-parse.h: Fix common/ includes.
1187         * mi/mi-main.c: Fix common/ includes.
1188         * mi/mi-cmd-env.c: Fix common/ includes.
1189         * memrange.h: Fix common/ includes.
1190         * memattr.c: Fix common/ includes.
1191         * maint.h: Fix common/ includes.
1192         * maint.c: Fix common/ includes.
1193         * main.c: Fix common/ includes.
1194         * machoread.c: Fix common/ includes.
1195         * location.c: Fix common/ includes.
1196         * linux-thread-db.c: Fix common/ includes.
1197         * linux-nat.c: Fix common/ includes.
1198         * linux-fork.c: Fix common/ includes.
1199         * inline-frame.c: Fix common/ includes.
1200         * infrun.c: Fix common/ includes.
1201         * inflow.c: Fix common/ includes.
1202         * inferior.h: Fix common/ includes.
1203         * inferior.c: Fix common/ includes.
1204         * infcmd.c: Fix common/ includes.
1205         * inf-ptrace.c: Fix common/ includes.
1206         * inf-child.c: Fix common/ includes.
1207         * ia64-linux-nat.c: Fix common/ includes.
1208         * i387-tdep.c: Fix common/ includes.
1209         * i386-tdep.c: Fix common/ includes.
1210         * i386-linux-tdep.c: Fix common/ includes.
1211         * i386-linux-nat.c: Fix common/ includes.
1212         * i386-go32-tdep.c: Fix common/ includes.
1213         * i386-fbsd-tdep.c: Fix common/ includes.
1214         * i386-fbsd-nat.c: Fix common/ includes.
1215         * guile/scm-type.c: Fix common/ includes.
1216         * guile/guile.c: Fix common/ includes.
1217         * go32-nat.c: Fix common/ includes.
1218         * gnu-nat.c: Fix common/ includes.
1219         * gdbthread.h: Fix common/ includes.
1220         * gdbarch-selftests.c: Fix common/ includes.
1221         * gdb_usleep.c: Fix common/ includes.
1222         * gdb_select.h: Fix common/ includes.
1223         * gdb_bfd.c: Fix common/ includes.
1224         * gcore.c: Fix common/ includes.
1225         * fork-child.c: Fix common/ includes.
1226         * findvar.c: Fix common/ includes.
1227         * fbsd-nat.c: Fix common/ includes.
1228         * event-top.c: Fix common/ includes.
1229         * event-loop.c: Fix common/ includes.
1230         * dwarf2read.c: Fix common/ includes.
1231         * dwarf2loc.c: Fix common/ includes.
1232         * dwarf2-frame.c: Fix common/ includes.
1233         * dwarf-index-cache.c: Fix common/ includes.
1234         * dtrace-probe.c: Fix common/ includes.
1235         * disasm-selftests.c: Fix common/ includes.
1236         * defs.h: Fix common/ includes.
1237         * csky-tdep.c: Fix common/ includes.
1238         * cp-valprint.c: Fix common/ includes.
1239         * cp-support.h: Fix common/ includes.
1240         * cp-support.c: Fix common/ includes.
1241         * corelow.c: Fix common/ includes.
1242         * completer.h: Fix common/ includes.
1243         * completer.c: Fix common/ includes.
1244         * compile/compile.c: Fix common/ includes.
1245         * compile/compile-loc2c.c: Fix common/ includes.
1246         * compile/compile-cplus-types.c: Fix common/ includes.
1247         * compile/compile-cplus-symbols.c: Fix common/ includes.
1248         * command.h: Fix common/ includes.
1249         * cli/cli-dump.c: Fix common/ includes.
1250         * cli/cli-cmds.c: Fix common/ includes.
1251         * charset.c: Fix common/ includes.
1252         * build-id.c: Fix common/ includes.
1253         * btrace.h: Fix common/ includes.
1254         * btrace.c: Fix common/ includes.
1255         * breakpoint.h: Fix common/ includes.
1256         * breakpoint.c: Fix common/ includes.
1257         * ax.h: 
1258         (enum agent_op): Fix common/ includes.
1259         * ax-general.c (struct aop_map): Fix common/ includes.
1260         * ax-gdb.c: Fix common/ includes.
1261         * auxv.c: Fix common/ includes.
1262         * auto-load.c: Fix common/ includes.
1263         * arm-tdep.c: Fix common/ includes.
1264         * arch/riscv.c: Fix common/ includes.
1265         * arch/ppc-linux-common.c: Fix common/ includes.
1266         * arch/i386.c: Fix common/ includes.
1267         * arch/arm.c: Fix common/ includes.
1268         * arch/arm-linux.c: Fix common/ includes.
1269         * arch/arm-get-next-pcs.c: Fix common/ includes.
1270         * arch/amd64.c: Fix common/ includes.
1271         * arch/aarch64.c: Fix common/ includes.
1272         * arch/aarch64-insn.c: Fix common/ includes.
1273         * arch-utils.c: Fix common/ includes.
1274         * amd64-windows-tdep.c: Fix common/ includes.
1275         * amd64-tdep.c: Fix common/ includes.
1276         * amd64-sol2-tdep.c: Fix common/ includes.
1277         * amd64-obsd-tdep.c: Fix common/ includes.
1278         * amd64-nbsd-tdep.c: Fix common/ includes.
1279         * amd64-linux-tdep.c: Fix common/ includes.
1280         * amd64-linux-nat.c: Fix common/ includes.
1281         * amd64-fbsd-tdep.c: Fix common/ includes.
1282         * amd64-fbsd-nat.c: Fix common/ includes.
1283         * amd64-dicos-tdep.c: Fix common/ includes.
1284         * amd64-darwin-tdep.c: Fix common/ includes.
1285         * agent.c: Fix common/ includes.
1286         * ada-lang.h: Fix common/ includes.
1287         * ada-lang.c: Fix common/ includes.
1288         * aarch64-tdep.c: Fix common/ includes.
1289
1290 2019-01-25  Tom Tromey  <tom@tromey.com>
1291
1292         * common/create-version.sh: Use common/version.h.
1293
1294 2019-01-24  Pedro Alves  <palves@redhat.com>
1295
1296         * infrun.c (signal_stop, signal_print, signal_program)
1297         (signal_catch, signal_pass): Now arrays instead of pointers.
1298         (update_signals_program_target, do_target_resume)
1299         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1300         * linux-nat.c (linux_nat_target::pass_signals)
1301         (linux_nat_target::create_inferior, linux_nat_target::attach):
1302         Adjust.
1303         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1304         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1305         * procfs.c (procfs_target::pass_signals): Adjust.
1306         * record-full.c (record_full_target::resume): Adjust.
1307         * remote.c (remote_target::pass_signals)
1308         (remote_target::program_signals): Adjust.
1309         * target-debug.h (target_debug_print_signals): Now takes a
1310         gdb::array_view as parameter.  Adjust.
1311         * target.h (target_ops) <pass_signals, program_signals>: Replace
1312         pointer and length parameters with gdb::array_view.
1313         (target_pass_signals, target_program_signals): Likewise.
1314         * target-delegates.c: Regenerate.
1315
1316 2019-01-24  Pedro Alves  <palves@redhat.com>
1317
1318         * common/forward-scope-exit.h
1319         (forward_scope_exit::forward_scope_exit): Pass arguments to
1320         m_bind_function directly, instead of creating a std::bind and
1321         copying that.
1322
1323 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1324
1325         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1326         for static members.
1327         (pass_in_v_vfp_candidate): Likewise.
1328
1329 2019-01-23  Tom Tromey  <tom@tromey.com>
1330             Pedro Alves  <palves@redhat.com>
1331
1332         * regcache.c (class regcache_invalidator): Remove.
1333         (regcache::raw_write): Use make_scope_exit.
1334
1335 2019-01-23  Tom Tromey  <tom@tromey.com>
1336
1337         * ui-out.h (class ui_out_emit_type): Update comment.
1338
1339 2019-01-23  Tom Tromey  <tom@tromey.com>
1340
1341         * infrun.c (fetch_inferior_event): Update comment.
1342
1343 2019-01-23  Tom Tromey  <tom@tromey.com>
1344             Pedro Alves  <palves@redhat.com>
1345
1346         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1347         parameter.
1348         (fetch_inferior_event): Use SCOPE_EXIT.
1349
1350
1351 2019-01-23  Tom Tromey  <tom@tromey.com>
1352             Pedro Alves  <palves@redhat.com>
1353
1354         * infrun.c (disable_thread_events): Delete.
1355         (stop_all_threads): Use SCOPE_EXIT.
1356
1357 2019-01-23  Tom Tromey  <tom@tromey.com>
1358             Pedro Alves  <palves@redhat.com>
1359
1360         * symfile.c: Include forward-scope-exit.h.
1361         (clear_symtab_users_cleanup): Replace forward declaration with
1362         a FORWARD_SCOPE_EXIT.
1363         (syms_from_objfile_1): Use the forward_scope_exit and
1364         gdb::optional instead of cleanup_function.
1365         (reread_symbols): Use the forward_scope_exit instead of
1366         cleanup_function.
1367         (clear_symtab_users_cleanup): Remove function.
1368
1369 2019-01-23  Tom Tromey  <tom@tromey.com>
1370             Pedro Alves  <palves@redhat.com>
1371
1372         * linux-nat.c: Include scope-exit.h.
1373         (cleanup_target_stop): Remove.
1374         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1375         SCOPE_EXIT.
1376
1377 2019-01-23  Tom Tromey  <tom@tromey.com>
1378             Pedro Alves  <palves@redhat.com>
1379
1380         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1381         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1382
1383 2019-01-23  Tom Tromey  <tom@tromey.com>
1384             Andrew Burgess  <andrew.burgess@embecosm.com>
1385             Pedro Alves  <palves@redhat.com>
1386
1387         * infrun.c (fetch_inferior_event): Use scope_exit.
1388         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1389         * top.c (execute_command): Use scope_exit.
1390         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1391         * utils.c (do_bpstat_clear_actions_cleanup)
1392         (make_bpstat_clear_actions_cleanup): Remove.
1393
1394 2019-01-23  Tom Tromey  <tom@tromey.com>
1395             Pedro Alves  <palves@redhat.com>
1396
1397         * infrun.c: Include "common/scope-exit.h"
1398         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1399         (wait_for_inferior): Use SCOPE_EXIT.
1400         (fetch_inferior_event): Use scope_exit.
1401
1402 2019-01-23  Tom Tromey  <tom@tromey.com>
1403             Pedro Alves  <palves@redhat.com>
1404
1405         * breakpoint.c (create_breakpoint): Remove cleanup.
1406
1407 2019-01-23  Tom Tromey  <tom@tromey.com>
1408             Andrew Burgess  <andrew.burgess@embecosm.com>
1409             Pedro Alves  <palves@redhat.com>
1410
1411 2019-01-23  Pedro Alves  <palves@redhat.com>
1412
1413         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1414
1415 2019-01-23  Pedro Alves  <palves@redhat.com>
1416             Andrew Burgess  <andrew.burgess@embecosm.com>
1417
1418         * gdbthread.h: Include "common/forward-scope-exit.h".
1419         (scoped_finish_thread_state): Redefine custom class in terms of
1420         forward_scope_exit.
1421
1422 2019-01-23  Pedro Alves  <palves@redhat.com>
1423             Andrew Burgess  <andrew.burgess@embecosm.com>
1424
1425         * common/forward-scope-exit.h: New file.
1426
1427 2019-01-23  Pedro Alves  <palves@redhat.com>
1428             Andrew Burgess  <andrew.burgess@embecosm.com>
1429             Tom Tromey  <tom@tromey.com>
1430
1431         * common/scope-exit.h: New file.
1432
1433 2019-01-23  Pedro Alves  <palves@redhat.com>
1434
1435         * common/preprocessor.h (ESC): Rename to ...
1436         (ESC_PARENS): ... this.
1437         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1438         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1439
1440 2019-01-23  Tom Tromey  <tom@tromey.com>
1441
1442         * language.h (class scoped_switch_to_sym_language_if_auto):
1443         Initialize m_lang in both cases.
1444
1445 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1446
1447         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1448         with XCNEW.
1449
1450 2019-01-22  Tom Tromey  <tom@tromey.com>
1451
1452         * corelow.c: Do not include sys/file.h.
1453
1454 2019-01-22  Tom Tromey  <tom@tromey.com>
1455
1456         * tui/tui-wingeneral.h: Include gdb_curses.h.
1457
1458 2019-01-22  Tom Tromey  <tom@tromey.com>
1459
1460         * source-cache.h (class source_cache) <get_source_lines,
1461         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1462
1463 2019-01-22  Tom Tromey  <tom@tromey.com>
1464
1465         * remote-fileio.h (struct remote_target): Declare.
1466
1467 2019-01-22  Tom Tromey  <tom@tromey.com>
1468
1469         * python/py-arch.c: Do not include py-ref.h.
1470         * python/py-bpevent.c: Do not include py-ref.h.
1471         * python/py-cmd.c: Do not include py-ref.h.
1472         * python/py-continueevent.c: Do not include py-ref.h.
1473         * python/py-event.h: Do not include py-ref.h.
1474         * python/py-evtregistry.c: Do not include py-ref.h.
1475         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1476         * python/py-frame.c: Do not include py-ref.h.
1477         * python/py-framefilter.c: Do not include py-ref.h.
1478         * python/py-function.c: Do not include py-ref.h.
1479         * python/py-infevents.c: Do not include py-ref.h.
1480         * python/py-linetable.c: Do not include py-ref.h.
1481         * python/py-objfile.c: Do not include py-ref.h.
1482         * python/py-param.c: Do not include py-ref.h.
1483         * python/py-prettyprint.c: Do not include py-ref.h.
1484         * python/py-progspace.c: Do not include py-ref.h.
1485         * python/py-symbol.c: Do not include py-ref.h.
1486         * python/py-symtab.c: Do not include py-ref.h.
1487         * python/py-type.c: Do not include py-ref.h.
1488         * python/py-unwind.c: Do not include py-ref.h.
1489         * python/py-utils.c: Do not include py-ref.h.
1490         * python/py-value.c: Do not include py-ref.h.
1491         * python/py-varobj.c: Do not include py-ref.h.
1492         * python/py-xmethods.c: Do not include py-ref.h.
1493         * python/python.c: Do not include py-ref.h.
1494         * varobj.c: Do not include py-ref.h.
1495
1496 2019-01-22  Tom Tromey  <tom@tromey.com>
1497
1498         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1499         keyword for bcache.
1500
1501 2019-01-22  Tom Tromey  <tom@tromey.com>
1502
1503         * compile/compile-cplus-types.c: Remove a comment by #include.
1504
1505 2019-01-22  Tom Tromey  <tom@tromey.com>
1506
1507         * compile/gcc-c-plugin.h: Include compile-internal.h.
1508
1509 2019-01-22  Tom Tromey  <tom@tromey.com>
1510
1511         * stabsread.c (EXTERN): Do not define.
1512         (symnum, next_symbol_text_func, processing_gcc_compilation)
1513         (within_function, global_sym_chain, global_stabs)
1514         (previous_stab_code, this_object_header_files)
1515         (n_this_object_header_files)
1516         (n_allocated_this_object_header_files): Define.
1517         * stabsread.h (EXTERN): Never define.  Use "extern".
1518
1519 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1520
1521         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1522         history_value.
1523
1524 2019-01-21  Tom Tromey  <tom@tromey.com>
1525
1526         * ui-out.c: Fix includes.
1527         * tui/tui-source.c: Fix includes.
1528         * target.c: Fix includes.
1529         * remote.c: Fix includes.
1530         * regcache.c: Fix includes.
1531         * python/py-block.c: Fix includes.
1532         * printcmd.c: Fix includes.
1533         * or1k-tdep.c: Fix includes.
1534         * mi/mi-main.c: Fix includes.
1535         * m32r-tdep.c: Fix includes.
1536         * csky-tdep.c: Fix includes.
1537         * compile/compile-cplus-types.c: Fix includes.
1538         * cli/cli-interp.c: Fix includes.
1539
1540 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1541
1542         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1543         for padding.
1544
1545 2019-01-16  Tom Tromey  <tom@tromey.com>
1546
1547         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1548         earlier.
1549         (struct objfile) <msymbols_range>: Move from top level.
1550         <msymbols>: New method.
1551         (class objfile_msymbols): Remove.
1552         * symtab.c (default_collect_symbol_completion_matches_break_on):
1553         Update.
1554         * symmisc.c (dump_msymbols): Update.
1555         * stabsread.c (scan_file_globals): Update.
1556         * objc-lang.c (info_selectors_command, info_classes_command)
1557         (find_methods): Update.
1558         * minsyms.c (find_solib_trampoline_target): Update.
1559         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1560         * coffread.c (coff_symfile_read): Update.
1561         * ada-lang.c (ada_lookup_simple_minsym)
1562         (ada_collect_symbol_completion_matches): Update.
1563
1564 2019-01-16  Tom Tromey  <tom@tromey.com>
1565
1566         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1567         type.  Remove no-argument constructor.
1568         <iterator::operator++>: Simplify.
1569         <begin>: Update.
1570         <end>: Use minimal_symbol_count.
1571
1572 2019-01-16  Tom Tromey  <tom@tromey.com>
1573
1574         * objfiles.h (struct objfile) <psymtabs>: New method.
1575         (class objfile_psymtabs): Remove.
1576         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1577         typedef.
1578         <range>: New method.
1579         (require_partial_symbols): Change return type.
1580         * psymtab.c (require_partial_symbols)
1581         (psym_expand_symtabs_matching): Update.
1582         * mdebugread.c (parse_partial_symbols): Update.
1583         * dbxread.c (dbx_end_psymtab): Update.
1584
1585 2019-01-15  Tom Tromey  <tom@tromey.com>
1586
1587         * symtab.c (lookup_objfile_from_block)
1588         (lookup_symbol_in_objfile_symtabs)
1589         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1590         (find_line_symtab, info_sources_command)
1591         (default_collect_symbol_completion_matches_break_on)
1592         (make_source_files_completion_list): Update.
1593         * symmisc.c (print_objfile_statistics, dump_objfile)
1594         (maintenance_print_symbols, maintenance_info_symtabs)
1595         (maintenance_check_symtabs, maintenance_info_line_tables):
1596         Update.
1597         * source.c (select_source_symtab)
1598         (forget_cached_source_info_for_objfile): Update.
1599         * objfiles.h (class objfile_compunits): Remove.
1600         (struct objfile) <compunits_range>: New typedef.
1601         (compunits): New method.
1602         * objfiles.c (objfile_relocate1): Update.
1603         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1604         * maint.c (count_symtabs_and_blocks): Update.
1605         * linespec.c (iterate_over_all_matching_symtabs): Update.
1606         * cp-support.c (add_symbol_overload_list_qualified): Update.
1607         * coffread.c (coff_symtab_read): Update.
1608         * ada-lang.c (add_nonlocal_symbols)
1609         (ada_collect_symbol_completion_matches)
1610         (ada_add_global_exceptions): Update.
1611
1612 2019-01-15  Tom Tromey  <tom@tromey.com>
1613
1614         * progspace.h (program_space) <objfiles_safe_range>: New
1615         typedef.
1616         <objfiles_safe>: New method.
1617         * objfiles.h (class all_objfiles_safe): Remove.
1618         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1619         * jit.c (jit_inferior_exit_hook): Update.
1620
1621 2019-01-17  Tom Tromey  <tom@tromey.com>
1622
1623         * progspace.h (program_space) <objfiles_range>: New typedef.
1624         <objfiles>: New method.
1625         <objfiles_head>: Rename from objfiles.
1626         (object_files): Update.
1627         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1628         * guile/scm-pretty-print.c
1629         (ppscm_find_pretty_printer_from_objfiles): Update.
1630         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1631         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1632         Update.
1633         * python/py-progspace.c (pspy_get_objfiles): Update.
1634         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1635         Update.
1636         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1637         (objfpy_lookup_objfile_by_build_id): Update.
1638         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1639         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1640         Update.
1641         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1642         (expand_symtab_containing_pc, lookup_objfile_from_block)
1643         (lookup_static_symbol, basic_lookup_transparent_type)
1644         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1645         (find_line_symtab, info_sources_command)
1646         (default_collect_symbol_completion_matches_break_on)
1647         (make_source_files_completion_list, find_main_name): Update.
1648         * symmisc.c (print_symbol_bcache_statistics)
1649         (print_objfile_statistics, maintenance_print_symbols)
1650         (maintenance_print_msymbols, maintenance_print_objfiles)
1651         (maintenance_info_symtabs, maintenance_check_symtabs)
1652         (maintenance_expand_symtabs, maintenance_info_line_tables):
1653         Update.
1654         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1655         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1656         (map_overlay_command, unmap_overlay_command)
1657         (simple_overlay_update, expand_symtabs_matching)
1658         (map_symbol_filenames): Update.
1659         * symfile-debug.c (set_debug_symfile): Update.
1660         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1661         Update.
1662         * source.c (select_source_symtab, forget_cached_source_info):
1663         Update.
1664         * solib.c (solib_read_symbols): Update.
1665         * solib-spu.c (append_ocl_sos): Update.
1666         * psymtab.c (maintenance_print_psymbols)
1667         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1668         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1669         * printcmd.c (info_symbol_command): Update.
1670         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1671         Update.
1672         * objfiles.h (class all_objfiles): Remove.
1673         * objfiles.c (have_partial_symbols, have_full_symbols)
1674         (have_minimal_symbols, qsort_cmp, update_section_map)
1675         (shared_objfile_contains_address_p)
1676         (default_iterate_over_objfiles_in_search_order): Update.
1677         * objc-lang.c (info_selectors_command, info_classes_command)
1678         (find_methods): Update.
1679         * minsyms.c (find_solib_trampoline_target): Update.
1680         * maint.c (maintenance_info_sections)
1681         (maintenance_translate_address, count_symtabs_and_blocks):
1682         Update.
1683         * main.c (captured_main_1): Update.
1684         * linux-thread-db.c (try_thread_db_load_from_pdir)
1685         (has_libpthread): Update.
1686         * linespec.c (iterate_over_all_matching_symtabs)
1687         (search_minsyms_for_name): Update.
1688         * jit.c (jit_find_objf_with_entry_addr): Update.
1689         * hppa-tdep.c (find_unwind_entry)
1690         (hppa_lookup_stub_minimal_symbol): Update.
1691         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1692         Update.
1693         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1694         (elf_gnu_ifunc_resolve_by_got): Update.
1695         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1696         * dwarf-index-write.c (save_gdb_index_command): Update.
1697         * cp-support.c (add_symbol_overload_list_qualified): Update.
1698         * breakpoint.c (create_overlay_event_breakpoint)
1699         (create_longjmp_master_breakpoint)
1700         (create_std_terminate_master_breakpoint)
1701         (create_exception_master_breakpoint): Update.
1702         * blockframe.c (find_pc_partial_function): Update.
1703         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1704         (ada_collect_symbol_completion_matches)
1705         (ada_add_global_exceptions): Update.
1706
1707 2019-01-17  Tom Tromey  <tom@tromey.com>
1708
1709         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1710         declare VEC.
1711         (solib_target_parse_libraries): Change return type.
1712         (library_list_start_segment, library_list_start_section)
1713         (library_list_end_library, library_list_start_library); Update.
1714         (solib_target_free_library_list): Remove.
1715         (solib_target_parse_libraries): Remove cleanup.  Change return
1716         type.
1717         (solib_target_current_sos): Update.
1718
1719 2019-01-17  Tom Tromey  <tromey@bapiya>
1720
1721         * valprint.c: Replace "the the" with "the".
1722         * symtab.c: Replace "the the" with "the".
1723         * solib.c: Replace "the the" with "the".
1724         * solib-dsbt.c: Replace "the the" with "the".
1725         * linespec.c: Replace "the the" with "the".
1726         * dwarf2loc.h: Replace "the the" with "the".
1727         * amd64-windows-tdep.c: Replace "the the" with "the".
1728         * aarch64-tdep.c: Replace "the the" with "the".
1729
1730 2019-01-16  Keith Seitz  <keiths@redhat.com>
1731
1732         PR gdb/23773
1733         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1734         <builder>: Rename to ..
1735         <m_builder>: ... this and make private.
1736         (dwarf2_cu::get_builder): New method.  Change all users of
1737         `builder' to use this method.
1738         (dwarf2_start_symtab): Move to ...
1739         (dwarf2_cu::start_symtab): ... here.  Update all callers
1740         (setup_type_unit_groups): Move to ...
1741         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1742         callers.
1743         (dwarf2_cu::reset_builder): New method.
1744         (process_full_compunit, process_full_type_unit): Use
1745         dwarf2_cu::reset_builder.
1746         (follow_die_offset): Record the ancestor CU if it is different
1747         from the followed DIE's CU.
1748         (follow_die_sig_1): Likewise.
1749
1750 2019-01-15  Tom Tromey  <tom@tromey.com>
1751
1752         * remote.c (class remote_state) <buf>: Now a char_vector.
1753         <buf_size>: Remove.
1754         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1755         parameter.
1756         (remote_target::getpkt_or_notif_sane_1)
1757         (remote_target::getpkt_sane)
1758         (remote_target::getpkt_or_notif_sane): Likewise.
1759         (class remote_target) <putpkt>: New overload.
1760         (remote_target::read_frame): Change type of "buf_p".  Remove
1761         sizeof_p parameter.
1762         (packet_ok): New overload.
1763         (packet_check_result): New overload.
1764         Update all uses.
1765
1766 2019-01-14  Tom Tromey  <tom@tromey.com>
1767
1768         * remote-notif.c (handle_notification, remote_notif_ack)
1769         (remote_notif_parse): Make "buf" const.
1770         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1771         const.
1772         (remote_notif_parse, remote_notif_ack, handle_notification):
1773         Likewise.
1774         * remote.c (remote_notif_stop_parse): Make "buf" const.
1775         (remote_target::remote_parse_stop_reply): Make "buf" const.
1776         (remote_notif_stop_ack): Make "buf" const.
1777
1778 2019-01-14  Tom Tromey  <tom@tromey.com>
1779
1780         * remote.c (remote_console_output): Make parameter const.
1781
1782 2019-01-14  Tom Tromey  <tom@tromey.com>
1783
1784         * target-debug.h (target_debug_print_signals): Constify.
1785         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1786         * procfs.c (procfs_target::pass_signals): Update.
1787         * linux-nat.c (linux_nat_target::pass_signals): Update.
1788         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1789         * target-delegates.c: Rebuild.
1790         * remote.c (remote_target::program_signals): Update.
1791         (remote_target::pass_signals): Update.
1792         * target.c (target_pass_signals): Constify argument.
1793         (target_program_signals): Likewise.
1794         * target.h (struct target_ops) <pass_signals, program_signals>:
1795         Constify argument.
1796         (target_pass_signals, target_program_signals): Constify argument.
1797
1798 2019-01-14  Tom Tromey  <tom@tromey.com>
1799
1800         PR tui/28819:
1801         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1802
1803 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1804
1805         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1806         field.
1807         * rs6000-tdep.c: Include reggroups.h.
1808         (IS_V_ALIAS_PSEUDOREG): Define.
1809         (rs6000_register_name): Return names for the "vX" aliases.
1810         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1811         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1812         aliases.  Call default_register_reggroup_p for all other
1813         pseudo-registers.
1814         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1815         New functions.
1816         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1817         Handle "vX" aliases.
1818         (v_alias_pseudo_register_collect): New function.
1819         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1820         (rs6000_gdbarch_init): Initialize "vX" aliases as
1821         pseudo-registers.  Restore registration of
1822         rs6000_pseudo_register_reggroup_p with
1823         set_tdesc_pseudo_register_reggroup_p.
1824
1825 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1826
1827         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1828         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1829         set_gdbarch_num_pseudo_regs.
1830
1831 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1832
1833         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1834         Remove arg prefixname, add do_set and do_show.
1835         Add member functions set_list and show_list.
1836         * cli/cli-style.c (class cli_style_option): Update accordingly.
1837         (style_set_list): Move to file scope.
1838         (style_show_list): Likewise.
1839         (set_style): Call help_list.
1840         (show_style): Call cmd_show_list.
1841         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1842         Update to use the new macro.
1843
1844 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1845
1846         * ada-lang.c (_initialize_ada_language): Expand the help text
1847         for the "catch exception" command.
1848
1849 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1850
1851         * symtab.c (matching_obj_sections): Initialize obj,
1852         declare it closer to its usage.
1853
1854 2019-01-10  Tom Tromey  <tom@tromey.com>
1855
1856         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1857         (basic_inf_threads_range): Remove.
1858         (inf_threads_range, inf_non_exited_threads_range)
1859         (safe_inf_threads_range): Use next_adapter.
1860
1861 2019-01-10  Keith Seitz  <keiths@redhat.com>
1862
1863         PR gdb/23712
1864         PR symtab/23010
1865         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1866         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1867
1868 2019-01-10  Keith Seitz  <keiths@redhat.com>
1869
1870         PR gdb/23712
1871         PR symtab/23010
1872         * dictionary.c (pending_to_vector): Remove.
1873         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1874         Remove _1 suffix, replacing functions of the same name.  Update
1875         all callers.
1876         (dict_create_hashed, dict_create_hashed_expandable)
1877         (dict_create_linear, dict_create_linear_expandable, dict_free)
1878         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1879         Make functions static.
1880
1881 2019-01-10  Keith Seitz  <keiths@redhat.com>
1882
1883         PR gdb/23712
1884         PR symtab/23010
1885         * dictionary.h (struct dictionary): Replace declaration with
1886         multidictionary.
1887         (dict_create_hashed, dict_create_hashed_expandable)
1888         (dict_create_linear, dict_create_linear_expandable)
1889         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1890         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1891         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1892         taking multidictionary argument.
1893         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1894         * block.h (struct block) <dict>: Change to multidictionary
1895         and rename `multidict'.
1896         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1897         symmisc.c: Update all dictionary references to multidictionary.
1898
1899 2019-01-10  Keith Seitz  <keiths@redhat.com>
1900
1901         PR gdb/23712
1902         PR symtab/23010
1903         * dictionary.c: Include unordered_map.
1904         (pending_to_vector): New function.
1905         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1906         Rewrite the non-"_1" functions to take vector instead
1907         of linked list.
1908         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1909         "new" _1 versions of the same name.
1910         (multidictionary): Define.
1911         (std::hash<enum language): New definition.
1912         (collate_pending_symbols_by_language, mdict_create_hashed)
1913         (mdict_create_hashed_expandable, mdict_create_linear)
1914         (mdict_create_linear_expandable, mdict_free)
1915         (find_language_dictionary, create_new_language_dictionary)
1916         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1917         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1918         (mdict_size, mdict_empty): New functions.
1919         * dictionary.h (mdict_iterator): Define.
1920
1921 2019-01-10  Pedro Alves  <palves@redhat.com>
1922
1923         * breakpoint.c (read_uploaded_action)
1924         (create_tracepoint_from_upload): Adjust to use
1925         gdb::unique_xmalloc_ptr.
1926         * ctf.c (ctf_write_uploaded_tp):
1927         (SET_ARRAY_FIELD): Use emplace_back.
1928         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1929         * tracefile-tfile.c (tfile_write_uploaded_tp):
1930         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1931         gdb::unique_xmalloc_ptr.
1932         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1933         at_string, cond_string, cmd_strings>: Replace char pointers
1934         with gdb::unique_xmalloc_ptr.
1935
1936 2019-01-10  Pedro Alves  <palves@redhat.com>
1937
1938         * solib-target.c (library_list_start_library): Don't xstrdup name.
1939
1940 2019-01-10  Pedro Alves  <palves@redhat.com>
1941
1942         * mdebugread.c (parse_partial_symbols): Use
1943         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1944
1945 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1946
1947         * linux-fork.c (scoped_switch_fork_info)
1948         <~scoped_switch_fork_info>: Fix incorrect variable name.
1949
1950 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1951
1952         * linux-fork.c (scoped_switch_fork_info)
1953         <scoped_switch_fork_info>: Make explicit.
1954         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1955
1956 2019-01-10  Tom Tromey  <tom@tromey.com>
1957
1958         * objfiles.h (objfile::reset_psymtabs): Update.
1959         * objfiles.c (objfile::objfile): Update.
1960         * psymtab.h (psymtab_storage::obstack): Update.
1961         (psymtab_storage::m_obstack): Use gdb::optional.
1962         (class psymtab_storage): Update comment.  Remove objfile
1963         parameter.
1964         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1965
1966 2019-01-10  Tom Tromey  <tom@tromey.com>
1967
1968         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1969         <free_psymtabs>: Now private.
1970         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1971         (allocate_psymtab): Use new method.
1972
1973 2019-01-10  Tom Tromey  <tom@tromey.com>
1974
1975         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1976         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1977         * mdebugread.c (parse_partial_symbols): Use
1978         allocate_dependencies.
1979         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1980         allocate_dependencies.
1981         (process_psymtab_comp_unit_reader)
1982         (build_type_psymtab_dependencies): Likewise.
1983         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1984
1985 2019-01-10  Tom Tromey  <tom@tromey.com>
1986
1987         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1988         PSYMBOL_SET_LANGUAGE.
1989         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1990
1991 2019-01-10  Tom Tromey  <tom@tromey.com>
1992
1993         * psymtab.h (psymtab_storage::obstack): New method.
1994         <m_obstack>: Rename from obstack; now private.
1995         * psymtab.c (psymtab_storage): Update.
1996         * dwarf2read.c (create_addrmap_from_index)
1997         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1998         Update.
1999
2000 2019-01-10  Tom Tromey  <tom@tromey.com>
2001
2002         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
2003         * objfiles.h (objfile::reset_psymtabs): New method.
2004
2005 2019-01-10  Tom Tromey  <tom@tromey.com>
2006
2007         * symmisc.c (print_symbol_bcache_statistics): Update.
2008         (print_objfile_statistics): Update.
2009         * symfile.c (reread_symbols): Update.
2010         * psymtab.h (class psymtab_storage): New.
2011         * psymtab.c (psymtab_storage): New constructor.
2012         (~psymtab_storage): New destructor.
2013         (require_partial_symbols): Update.
2014         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
2015         (find_pc_sect_psymtab, find_pc_sect_psymbol)
2016         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
2017         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
2018         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
2019         (start_psymtab_common, end_psymtab_common)
2020         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
2021         (allocate_psymtab): Update.
2022         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
2023         Update.
2024         (dump_psymtab_addrmap, maintenance_print_psymbols)
2025         (maintenance_check_psymtabs): Update.
2026         (class objfile_psymtabs): Move to objfiles.h.
2027         * psympriv.h (discard_psymtab): Now inline.
2028         (psymtab_discarder::psymtab_discarder): Update.
2029         (psymtab_discarder::~psymtab_discarder): Update.
2030         (ALL_OBJFILE_PSYMTABS): Rewrite.
2031         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
2032         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
2033         Remove fields.
2034         <partial_symtabs>: New field.
2035         (class objfile_psymtabs): Move from psymtab.h.  Update.
2036         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
2037         psymbol_cache.
2038         (objfile::~objfile): Don't destroy psymbol_cache.
2039         * mdebugread.c (parse_partial_symbols): Update.
2040         * dwarf2read.c (create_addrmap_from_index)
2041         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2042         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2043         (add_partial_subprogram, dwarf2_ranges_read): Update.
2044         * dwarf-index-write.c (write_address_map)
2045         (write_one_signatured_type, recursively_write_psymbols)
2046         (class debug_names, class debug_names, write_psymtabs_to_index):
2047         Update.
2048
2049 2019-01-10  Tom Tromey  <tom@tromey.com>
2050
2051         * symtab.h (SYMBOL_SET_NAMES): Update.
2052         (symbol_set_names): Update.
2053         (MSYMBOL_SET_NAMES): Update.
2054         * symtab.c (symbol_set_names): Change argument to be an
2055         objfile_per_bfd_storage.
2056         * psymtab.c (add_psymbol_to_bcache): Update.
2057         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2058
2059 2019-01-10  Tom Tromey  <tom@tromey.com>
2060
2061         * symtab.c (create_demangled_names_hash): Change argument to be an
2062         objfile_per_bfd_storage.
2063         (symbol_set_names): Update.
2064
2065 2019-01-10  Tom Tromey  <tom@tromey.com>
2066
2067         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2068         init_psymbol_list.
2069         * psymtab.c (init_psymbol_list): Do nothing if already called.
2070         * psympriv.h (init_psymbol_list): Add comment.
2071         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2072         init_psymbol_list.
2073         * dbxread.c (dbx_symfile_read): Unconditionally call
2074         init_psymbol_list.
2075
2076 2019-01-10  Tom Tromey  <tom@tromey.com>
2077
2078         * xcoffread.c (scan_xcoff_symtab): Update.
2079         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2080         "where".
2081         * mdebugread.c (parse_partial_symbols)
2082         (handle_psymbol_enumerators): Update.
2083         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2084         * dbxread.c (read_dbx_symtab): Update.
2085         * psympriv.h (psymbol_placement): New enum.
2086         (add_psymbol_to_list): Update.
2087
2088 2019-01-10  Tom Tromey  <tom@tromey.com>
2089
2090         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2091         static_psymbols parameters.
2092         (scan_xcoff_symtab): Update.
2093         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2094         static_psymbols parameters.
2095         * psympriv.h (start_psymtab_common): Update.
2096         * mdebugread.c (parse_partial_symbols): Update.
2097         * dwarf2read.c (create_partial_symtab): Update.
2098         * dbxread.c (read_dbx_symtab): Update.
2099         (start_psymtab): Remove global_psymbols and static_psymbols
2100         parameters.
2101
2102 2019-01-10  Tom Tromey  <tom@tromey.com>
2103
2104         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2105         * psymtab.c (allocate_psymtab): Add comment.
2106         * psympriv.h (allocate_psymtab): Add comment.
2107         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2108         initializations.
2109         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2110
2111 2019-01-10  Tom Tromey  <tom@tromey.com>
2112
2113         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2114         Don't declare.
2115         * mipsread.c: Include mdebugread.h.
2116         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2117         Declare.
2118         * elfread.c: Include mdebugread.h.
2119
2120 2019-01-09  Tom Tromey  <tom@tromey.com>
2121
2122         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2123         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2124         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2125         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2126         (psym_lookup_symbol, psym_find_last_source_symtab)
2127         (psym_forget_cached_source_info, psym_print_stats)
2128         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2129         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2130         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2131         (psym_find_compunit_symtab_by_address)
2132         (maintenance_print_psymbols, maintenance_info_psymtabs)
2133         (maintenance_check_psymtabs): Use ranged for.
2134         * psymtab.h (class objfile_psymtabs): New.
2135         (require_partial_symbols): Return objfile_psymtabs.
2136         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2137
2138 2019-01-09  Tom Tromey  <tom@tromey.com>
2139
2140         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2141         (find_pc_mapped_section, list_overlays_command)
2142         (map_overlay_command, unmap_overlay_command)
2143         (simple_overlay_update): Use all_objfiles.
2144         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2145         * printcmd.c (info_symbol_command): Use all_objfiles.
2146         * objfiles.h (ALL_OBJSECTIONS): Remove.
2147         * maint.c (maintenance_translate_address): Use all_objfiles.
2148         * gcore.c (gcore_create_callback): Use all_objfiles.
2149         (objfile_find_memory_regions): Likewise.
2150
2151 2019-01-09  Tom Tromey  <tom@tromey.com>
2152
2153         * symtab.c (find_line_symtab, info_sources_command)
2154         (make_source_files_completion_list): Use objfile_compunits.
2155         * source.c (select_source_symtab): Use objfile_compunits.
2156         * objfiles.h (struct objfile): Update comment.
2157         (ALL_OBJFILES): Remove.
2158         (ALL_FILETABS): Remove.
2159         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2160         objfile_compunits.
2161
2162 2019-01-09  Tom Tromey  <tom@tromey.com>
2163
2164         * symmisc.c (print_objfile_statistics, dump_objfile)
2165         (maintenance_print_symbols): Use compunit_filetabs.
2166         * source.c (forget_cached_source_info_for_objfile): Use
2167         compunit_filetabs.
2168         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2169         (ALL_FILETABS): Use compunit_filetabs.
2170         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2171         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2172
2173 2019-01-09  Tom Tromey  <tom@tromey.com>
2174
2175         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2176         (compunit_filetabs): New.
2177         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2178         compunit_filetabs.
2179         (info_sources_command, make_source_files_completion_list): Remove
2180         declaration.
2181         * symmisc.c (print_objfile_statistics, dump_objfile)
2182         (maintenance_print_symbols): Remove declaration.
2183         (maintenance_info_symtabs): Use compunit_filetabs.
2184         (maintenance_info_line_tables): Likewise.
2185         * source.c (select_source_symtab): Change local variable name.
2186         (forget_cached_source_info_for_objfile): Remove declaration.
2187         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2188         * objfiles.c (objfile_relocate1): Remove declaration.
2189         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2190         declaration.
2191         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2192         * coffread.c (coff_symtab_read): Remove declaration.
2193         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2194         compunit_filetabs.
2195
2196 2019-01-09  Tom Tromey  <tom@tromey.com>
2197
2198         * symtab.c (lookup_objfile_from_block)
2199         (find_pc_sect_compunit_symtab, search_symbols)
2200         (default_collect_symbol_completion_matches_break_on): Use
2201         objfile_compunits.
2202         * objfiles.h (ALL_COMPUNITS): Remove.
2203         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2204         * cp-support.c (add_symbol_overload_list_qualified): Use
2205         objfile_compunits.
2206         * ada-lang.c (ada_collect_symbol_completion_matches)
2207         (ada_add_global_exceptions): Use objfile_compunits.
2208
2209 2019-01-09  Tom Tromey  <tom@tromey.com>
2210
2211         * source.c (select_source_symtab)
2212         (forget_cached_source_info_for_objfile): Remove declaration.
2213         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2214         declaration.
2215         * maint.c (count_symtabs_and_blocks): Remove declaration.
2216         * cp-support.c (add_symbol_overload_list_qualified): Remove
2217         declaration.
2218         * coffread.c (coff_symtab_read): Remove declaration.
2219         * symtab.c (lookup_symbol_in_objfile_symtabs)
2220         (basic_lookup_transparent_type_1): Use objfile_compunits.
2221         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2222         (info_sources_command, search_symbols)
2223         (default_collect_symbol_completion_matches_break_on)
2224         (make_source_files_completion_list): Remove declaration.
2225         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2226         (ada_collect_symbol_completion_matches)
2227         (ada_add_global_exceptions): Remove declaration.
2228         * linespec.c (iterate_over_all_matching_symtabs): Use
2229         objfile_compunits.
2230         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2231         (class objfile_compunits): New.
2232         (ALL_COMPUNITS): Use objfile_compunits.
2233         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2234         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2235         objfile_compunits.
2236         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2237
2238 2019-01-09  Tom Tromey  <tom@tromey.com>
2239
2240         * symtab.c (search_symbols)
2241         (default_collect_symbol_completion_matches_break_on): Use
2242         objfile_msymbols.
2243         * ada-lang.c (ada_lookup_simple_minsym)
2244         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2245         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2246         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2247         objfile_msymbols.
2248         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2249         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2250         * objc-lang.c (find_methods): Use objfile_msymbols.
2251         (info_selectors_command, info_classes_command): Likewise.
2252         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2253         * objfiles.h (class objfile_msymbols): New.
2254         (ALL_OBJFILE_MSYMBOLS): Remove.
2255         (ALL_MSYMBOLS): Remove.
2256
2257 2019-01-09  Tom Tromey  <tom@tromey.com>
2258
2259         * common/next-iterator.h (next_adapter): Add Iterator template
2260         parameter.
2261         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2262         (class all_objfiles_safe): New.
2263         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2264         * objfiles.c (put_objfile_before): Update comment.
2265         (add_separate_debug_objfile): Likewise.
2266         (free_all_objfiles): Use all_objfiles_safe.
2267         (objfile_purge_solibs): Likewise.
2268
2269 2019-01-09  Tom Tromey  <tom@tromey.com>
2270
2271         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2272         (expand_symtab_containing_pc, lookup_static_symbol)
2273         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2274         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2275         all_objfiles.
2276         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2277         * breakpoint.c (create_overlay_event_breakpoint)
2278         (create_longjmp_master_breakpoint)
2279         (create_std_terminate_master_breakpoint)
2280         (create_exception_master_breakpoint): Use all_objfiles.
2281         * linux-thread-db.c (try_thread_db_load_from_pdir)
2282         (has_libpthread): Use all_objfiles.
2283         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2284         * linespec.c (iterate_over_all_matching_symtabs)
2285         (search_minsyms_for_name): Use all_objfiles.
2286         * maint.c (maintenance_info_sections): Use all_objfiles.
2287         * main.c (captured_main_1): Use all_objfiles.
2288         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2289         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2290         * guile/scm-pretty-print.c
2291         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2292         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2293         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2294         (maintenance_print_msymbols): Use all_objfiles.
2295         * source.c (select_source_symtab): Use all_objfiles.
2296         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2297         * symfile.c (remove_symbol_file_command)
2298         (expand_symtabs_matching, map_symbol_filenames): Use
2299         all_objfiles.
2300         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2301         all_objfiles.
2302         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2303         * objc-lang.c (find_methods): Use all_objfiles.
2304         * objfiles.c (have_partial_symbols, have_full_symbols)
2305         (have_minimal_symbols, qsort_cmp)
2306         (default_iterate_over_objfiles_in_search_order): Use
2307         all_objfiles.
2308         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2309         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2310         (maintenance_check_psymtabs): Use all_objfiles.
2311         (ALL_PSYMTABS): Remove.
2312         * compile/compile-object-run.c (do_module_cleanup): Use
2313         all_objfiles.
2314         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2315         * cp-support.c (add_symbol_overload_list_qualified): Use
2316         all_objfiles.
2317         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2318         Use all_objfiles.
2319         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2320         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2321         all_objfiles.
2322         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2323         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2324         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2325         Uses all_objfiles.
2326         * solib.c (solib_read_symbols): Use all_objfiles
2327
2328 2019-01-09  Tom Tromey  <tom@tromey.com>
2329
2330         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2331         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2332         all_objfiles.
2333         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2334         * symmisc.c (print_symbol_bcache_statistics)
2335         (print_objfile_statistics, maintenance_print_objfiles)
2336         (maintenance_info_symtabs, maintenance_check_symtabs)
2337         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2338         all_objfiles.
2339         * source.c (forget_cached_source_info): Use all_objfiles.
2340         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2341         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2342         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2343         * objfiles.c (update_section_map): Use all_objfiles.
2344         (shared_objfile_contains_address_p): Likewise.
2345         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2346         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2347
2348 2019-01-09  Tom Tromey  <tom@tromey.com>
2349
2350         * common/next-iterator.h: New file.
2351         * objfiles.h (class all_objfiles): New.
2352         (struct objfile_iterator): New.
2353
2354 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2355
2356         * NEWS: Move the description of the changed "frame", "select-frame",
2357          and "info frame" commands to the Changed commands section.
2358
2359 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2360
2361         * gdbtypes.c (check_stub_method_group): Remove handling of old
2362         mangling schemes.
2363         * linespec.c (find_methods): Likewise.
2364         * stabsread.c (read_member_functions): Likewise.
2365         * valops.c (search_struct_method): Likewise.
2366         (value_struct_elt_for_reference): Likewise.
2367         * NEWS: Mention this change.
2368
2369 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2370
2371         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2372         print_source_lines.
2373         * source.c (print_source_lines_base): Update line number check.
2374         (print_source_lines): New function.
2375         (source_lines_range::source_lines_range): New function.
2376         * source.h (class source_lines_range): New class.
2377         (print_source_lines): New declaration.
2378
2379 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2380
2381         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2382
2383 2019-01-08  Tom Tromey  <tom@tromey.com>
2384             Simon Marchi  <simon.marchi@ericsson.com>
2385
2386         PR gdb/24060
2387         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2388         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2389         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2390         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2391         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2392         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2393
2394 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2395
2396         * source.c (select_source_symtab): Move header comment to
2397         declaration in source.h.
2398         (forget_cached_source_info_for_objfile): Likewise.
2399         (forget_cached_source_info): Likewise.
2400         (identify_source_line): Likewise.
2401         * source.h (identify_source_line): Move declaration from symtab.h
2402         and add comment from source.c
2403         (print_source_lines): Likewise.
2404         (forget_cached_source_info_for_objfile): Likewise.
2405         (forget_cached_source_info): Likewise.
2406         (select_source_symtab): Likewise.
2407         (enum print_source_lines_flag): Move definition from symtab.h.
2408         * symtab.h (identify_source_line): Move declaration to source.h.
2409         (print_source_lines): Likewise.
2410         (forget_cached_source_info_for_objfile): Likewise.
2411         (forget_cached_source_info): Likewise.
2412         (select_source_symtab): Likewise.
2413         (enum print_source_lines_flag): Move definition to source.h.
2414         * tui/tui-hooks.c: Add 'source.h' include.
2415
2416 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2417
2418         * source.c (print_source_lines_base): Handle requests to print
2419         reverse line number sequences, and guard against empty lines
2420         string.
2421
2422 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2423
2424         * source.c (print_source_lines_base): Fix skip of '\r' if next
2425         character is '\n'.
2426
2427 2019-01-06  Tom Tromey  <tom@tromey.com>
2428
2429         * c-exp.y (struct c_parse_state) <macro_original_text,
2430         expansion_obstack>: New member.
2431         (macro_original_text, expansion_obstack): Remove globals.
2432         (scan_macro_expansion, scanning_macro_expansion)
2433         (finished_macro_expansion): Update.
2434         (scan_macro_cleanup): Remove.
2435         (yylex, c_parse): Update.
2436
2437 2019-01-06  Tom Tromey  <tom@tromey.com>
2438
2439         * c-exp.y (struct c_parse_state) <strings>: New member.
2440         (operator_stoken): Update.
2441
2442 2019-01-06  Tom Tromey  <tom@tromey.com>
2443
2444         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2445         (union type_stack_elt) <typelist_val>: Now a pointer to
2446         std::vector.
2447         (type_stack_cleanup): Don't declare.
2448         (push_typelist): Update.
2449         * parse.c (pop_typelist): Return a std::vector.
2450         (push_typelist): Take a std::vector.
2451         (follow_types): Update.  Do not free args.
2452         (type_stack_cleanup): Remove.
2453         * c-exp.y (struct c_parse_state): New.
2454         (cpstate): New global.
2455         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2456         (nonempty_typelist): Update.
2457         (func_mod): Create a new vector.
2458         (c_parse): Create a c_parse_state.
2459         (check_parameter_typelist): Do not delete params.
2460         (function_method): Update.  Do not delete type_list.
2461
2462 2019-01-06  Tom Tromey  <tom@tromey.com>
2463
2464         PR gdb/28155:
2465         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2466         check_typedef.
2467         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2468         (print_return_value): Likewise.
2469
2470 2019-01-05  Tom Tromey  <tom@tromey.com>
2471
2472         * contrib/cleanup_check.py: Remove.
2473         * contrib/gcc-with-excheck: Remove.
2474         * contrib/exsummary.py: Remove.
2475         * contrib/excheck.py: Remove.
2476
2477 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2478
2479         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2480         NULL. Initialize tpprev to NULL instead of assigning it
2481         to NULL on the next statement.
2482         * windows-nat.c (windows_delete_thread): Remove check for
2483         main_thread_id before printing thread exit notifications.
2484         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2485         Remove thread ID check against main_thread_id.
2486         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2487         windows_delete_thread.
2488         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2489
2490 2019-01-04  Tom Tromey  <tom@tromey.com>
2491
2492         * compile/compile.c (_initialize_compile): Use upper case for
2493         metasyntactic variables.
2494         * symmisc.c (_initialize_symmisc): Use upper case for
2495         metasyntactic variables.
2496         * psymtab.c (_initialize_psymtab): Use upper case for
2497         metasyntactic variables.
2498         * demangle.c (demangle_command): Use upper case for metasyntactic
2499         variables.
2500         (_initialize_demangler): Likewise.
2501         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2502         variables.
2503
2504 2019-01-03  Tom Tromey  <tom@tromey.com>
2505
2506         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2507
2508 2019-01-03  Tom Tromey  <tom@tromey.com>
2509
2510         * python/py-symtab.c (salpy_str): Update.
2511         (struct salpy_sal_object) <symtab>: Now a PyObject.
2512         (salpy_dealloc): Update.
2513         (del_objfile_sal): Use gdbpy_ref.
2514
2515 2019-01-03  Tom Tromey  <tom@tromey.com>
2516
2517         * python/py-type.c (convert_field): Use new_reference.  Return
2518         gdbpy_ref.
2519         (make_fielditem): Return gdbpy_ref.
2520         (typy_fields): Update.
2521         (typy_getitem): Update.
2522         (field_name): Return gdbpy_ref.  Use new_reference.
2523         (typy_iterator_iternext): Update.
2524
2525 2019-01-03  Tom Tromey  <tom@tromey.com>
2526
2527         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2528
2529 2019-01-03  Tom Tromey  <tom@tromey.com>
2530
2531         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2532         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2533         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2534         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2535         (pspy_set_type_printers): Likewise.
2536         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2537         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2538         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2539         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2540         (objfpy_set_type_printers): Likewise.
2541
2542 2019-01-03  Tom Tromey  <tom@tromey.com>
2543
2544         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2545         (gdbpy_print_stack): Use gdbpy_err_fetch.
2546         * python/python-internal.h (class gdbpy_err_fetch): New class.
2547         (class gdbpy_enter) <m_error_type, m_error_value,
2548         m_error_traceback>: Remove.
2549         <m_error>: New member.
2550         (gdbpy_exception_to_string): Don't declare.
2551         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2552         * python/py-value.c (convert_value_from_python): Use
2553         gdbpy_err_fetch.
2554         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2555         gdbpy_exception_to_string.
2556         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2557         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2558         gdbpy_err_fetch.
2559
2560 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2561
2562         * linux-nat.c (delete_lwp_cleanup): Delete.
2563         (struct lwp_deleter): New struct.
2564         (lwp_info_up): New typedef.
2565         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2566         lwp_info_up.
2567
2568 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2569
2570         * linux-fork.c (class scoped_switch_fork_info): New class.
2571         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2572
2573 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2574
2575         * valops.c (find_overload_match): Remove use of null_cleanup, and
2576         calls to do_cleanups.
2577
2578 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2579
2580         * compile/compile-cplus-types.c
2581         (compile_cplus_instance::decl_name): Handle changes to
2582         cp_func_name.
2583         * cp-support.c (cp_func_name): Update header comment, update
2584         return type.
2585         * cp-support.h (cp_func_name): Update return type in declaration.
2586         * valops.c (find_overload_match): Move temp_func local to top
2587         level of function and change its type.  Use temp_func to hold and
2588         delete temporary string obtained from cp_func_name.
2589
2590 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2591
2592         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2593         gdb::char_vector, remove cleanup, and update uses of `msg`.
2594
2595 2019-01-03  Jim Wilson  <jimw@sifive.com>
2596
2597         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2598
2599 2019-01-02  Tom Tromey  <tom@tromey.com>
2600
2601         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2602         (tdesc_parse_xml): Remove cleanups.
2603         * target-descriptions.h (make_cleanup_free_target_description):
2604         Don't declare.
2605         (target_desc_deleter): New struct.
2606         (target_desc_up): New typedef.
2607         * target-descriptions.c (target_desc_deleter::operator()): Rename
2608         from free_target_description.
2609         (make_cleanup_free_target_description): Remove.
2610
2611 2019-01-02  Tom Tromey  <tom@tromey.com>
2612
2613         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2614         constructor, destructor.
2615         (linespec_parser): Remove typedef.
2616         (~linespec_parser): Rename from linespec_parser_delete.
2617         (linespec_lex_to_end, linespec_complete_label)
2618         (linespec_complete): Update.
2619         (decode_line_full): Remove cleanups.
2620         (decode_line_1): Update.
2621
2622 2019-01-02  Tom Tromey  <tom@tromey.com>
2623
2624         * python/python-internal.h (inferior_to_inferior_object): Change
2625         return type.
2626         * python/py-exitedevent.c (create_exited_event_object): Update.
2627         * python/py-inferior.c (inferior_to_inferior_object): Return
2628         gdbpy_ref.
2629         (python_new_inferior, python_inferior_deleted)
2630         (thread_to_thread_object, delete_thread_object)
2631         (build_inferior_list, gdbpy_selected_inferior): Update.
2632         * python/py-infthread.c (create_thread_object): Update.  Also fail
2633         if inferior_to_inferior_object fails.
2634
2635 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2636
2637         * inferior.h (class inferior) <displaced_step_state>: New field.
2638         * infrun.h (struct displaced_step_state): Move here from
2639         infrun.c.  Initialize fields, add constructor.
2640         <inf>: Remove field.
2641         <reset>: New method.
2642         * infrun.c (struct displaced_step_inferior_state): Move to
2643         infrun.h.
2644         (displaced_step_inferior_states): Remove.
2645         (get_displaced_stepping_state): Adust.
2646         (displaced_step_in_progress_any_inferior): Adjust.
2647         (displaced_step_in_progress_thread): Adjust.
2648         (displaced_step_in_progress): Adjust.
2649         (add_displaced_stepping_state): Remove.
2650         (get_displaced_step_closure_by_addr): Adjust.
2651         (remove_displaced_stepping_state): Remove.
2652         (infrun_inferior_exit): Call displaced_step_state.reset.
2653         (use_displaced_stepping): Don't check for NULL.
2654         (displaced_step_prepare_throw): Call
2655         get_displaced_stepping_state.
2656         (displaced_step_fixup): Don't check for NULL.
2657         (prepare_for_detach): Don't check for NULL.
2658
2659 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2660
2661         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2662          in case of call that did not complete.
2663
2664 2019-01-02  Andrey Utkin  <autkin@undo.io>
2665
2666         * symfile.c (find_separate_debug_file): Fix search of debug files for
2667         remote debuggee.
2668
2669 2019-01-02  Tom Tromey  <tom@tromey.com>
2670
2671         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2672         indentation.
2673         * python/py-frame.c (frapy_older): Remove cast.
2674         (frapy_newer): Likewise.
2675         * python/py-breakpoint.c (local_setattro): Remove cast.
2676         * python/py-arch.c (archpy_name): Remove local variable.
2677         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2678
2679 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2680
2681         * unittests/basic_string_view/element_access/char/empty.cc:
2682         Fix year range in copyright header.
2683
2684 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2685
2686         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2687         Delete.
2688         <operator==>: Update with for removed field.
2689         <hash>: Likewise.
2690         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2691         <isa_features>: ...this.
2692         <abi_features>: New field.
2693         (riscv_isa_flen): Update comment.
2694         (riscv_abi_xlen): New declaration.
2695         (riscv_abi_flen): New declaration.
2696         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2697         isa_features.
2698         (riscv_abi_xlen): New function.
2699         (riscv_isa_flen): Update to get answer from isa_features.
2700         (riscv_abi_flen): New function.
2701         (riscv_has_fp_abi): Update to get answer from abi_features.
2702         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2703         xlen and flen.
2704         (riscv_call_info) <xlen, flen>: Update comment.
2705         (riscv_call_arg_struct): Remove invalid assertions
2706         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2707         is removed.
2708         (riscv_gdbarch_init): Gather isa features and abi features
2709         separately, ensure both match on the gdbarch when reusing an old
2710         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2711         a target with 64-bit float hardware.
2712
2713 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2714
2715         * source.c (search_command_helper): Stop reverse search
2716         when line 1 has been searched.
2717
2718 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2719
2720         * record-full.c (record_full_base_target::close): Rewrite
2721         record_full_core_buf_list free logic.
2722
2723 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2724
2725         * break-catch-syscall.c (print_one_catch_syscall): xfree
2726         the last text.
2727
2728 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2729
2730         * top.c (print_gdb_version): Update Copyright year in version
2731         message.
2732
2733 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2734
2735         Update copyright year range in all GDB files.
2736
2737 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2738
2739         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2740
2741 For older changes see ChangeLog-2018.
2742 \f
2743 Local Variables:
2744 mode: change-log
2745 left-margin: 8
2746 fill-column: 74
2747 version-control: never
2748 coding: utf-8
2749 End:
2750