Remove use of queue from remote.c
[external/binutils.git] / gdb / ChangeLog
1 2018-06-10  Tom Tromey  <tom@tromey.com>
2
3         * remote.c (stop_reply_p): Remove typedef.  Don't declare queue.
4         (class remote_state) <stop_reply_queue>: Now std::vector.
5         (remote_state::~remote_state)
6         (remote_target::stop_reply_queue_length): Update.
7         (struct queue_iter_param, remove_child_of_pending_fork)
8         (struct check_pending_event_prevents_wildcard_vcont_callback_data)
9         (check_pending_event_prevents_wildcard_vcont_callback)
10         (remove_stop_reply_for_inferior)
11         (remove_stop_reply_of_remote_state)
12         (remote_notif_remove_once_on_match)
13         (stop_reply_match_ptid_and_ws)
14         (remote_kill_child_of_pending_fork): Remove.
15         (remote_target::remove_new_fork_children)
16         (remote_target::check_pending_events_prevent_wildcard_vcont)
17         (remote_target::discard_pending_stop_replies)
18         (remote_target::discard_pending_stop_replies_in_queue)
19         (remote_target::remote_notif_remove_queued_reply)
20         (remote_target::queued_stop_reply)
21         (remote_target::push_stop_reply, remote_target::peek_stop_reply)
22         (remote_target::wait, remote_target::kill_new_fork_children)
23         (remote_target::async): Update.
24
25 2018-06-10  Tom Tromey  <tom@tromey.com>
26
27         * record-full.c (record_full_arch_list_cleanups): Remove.
28         (record_full_message): Use try/catch.
29         (record_full_wait_cleanups): Remove.
30         (record_full_wait_1): Use try/catch.
31         (record_full_restore): Likewise.
32
33 2018-06-10  Tom Tromey  <tom@tromey.com>
34
35         * record-full.c (record_full_breakpoint_p): Remove typedef.  Don't
36         declare VEC.  Add constructor.
37         <in_target_beneath>: Now bool.
38         (record_full_breakpoints): Now a std::vector, static.
39         (record_full_sync_record_breakpoints)
40         (record_full_init_record_breakpoints)
41         (record_full_target::insert_breakpoint)
42         (record_full_target::remove_breakpoint): Update.  Don't use XNEW.
43
44 2018-06-10  Simon Marchi  <simon.marchi@polymtl.ca>
45
46         * dwarf2read.c (process_cu_includes): Remove struct keyword.
47         * serial.c (serial_interface_lookup): Remove struct keyword.
48
49 2018-06-10  Tom Tromey  <tom@tromey.com>
50
51         * procfs.c (procfs_target::xfer_partial): Use "beneath" as a
52         method.
53         * nto-procfs.c (nto_procfs_target::xfer_partial): Use "beneath" as
54         a method.
55         * go32-nat.c (go32_nat_target::xfer_partial): Use "beneath" as a
56         method.
57         * arm-linux-nat.c (arm_linux_nat_target::read_description): Use
58         "beneath" as a method.
59         * arm-fbsd-nat.c (arm_fbsd_nat_target::read_description):
60         Use "beneath" as a method.
61
62 2018-06-10  Tom Tromey  <tom@tromey.com>
63
64         * tracefile.c (struct trace_file_writer_deleter): New.
65         <operator()>: Rename from trace_file_writer_xfree.
66         (trace_file_writer_up): New typedef.
67         (tsave_command, trace_save_tfile, trace_save_ctf): Update.
68
69 2018-06-09  Simon Marchi  <simon.marchi@ericsson.com>
70
71         * regcache.h (reg_buffer) <~reg_buffer>: Use default destructor.
72         <m_registers, m_register_status>: Change type to
73         std::unique_ptr.
74         * regcache.c (reg_buffer::reg_buffer): Use new instead of
75         XCNEWVEC.
76
77 2018-06-09  Simon Marchi  <simon.marchi@ericsson.com>
78
79         * common/common-regcache.h (enum register_status): Add
80         underlying type "signed char".
81         * regcache.h (reg_buffer) <m_register_status>: Change type to
82         register_status *.
83         * regcache.c (reg_buffer::reg_buffer): Alocate arrays of
84         register_status instead of signed char.
85         (reg_buffer::save): Use REG_UNKNOWN instead of 0.
86         (reg_buffer::get_register_status): Remove cast.
87         (readable_regcache::raw_read): Remove cast.
88         (readable_regcache::cooked_read): Remove cast.
89
90 2018-06-09  Tom Tromey  <tom@tromey.com>
91
92         * source.c (reverse_search_command, forward_search_command): Use
93         scoped_fd.
94
95 2018-06-09  Tom Tromey  <tom@tromey.com>
96
97         * serial.c (serial_ops_p): Remove typedef.  Don't declare VEC.
98         (serial_ops_list): Now static, std::vector.
99         (serial_interface_lookup, serial_add_interface): Update.
100
101 2018-06-09  Tom Tromey  <tom@tromey.com>
102
103         * dwarf2read.c (process_cu_includes): Update.
104         (process_full_comp_unit): Update.
105         * dwarf2read.h (struct dwarf2_per_objfile) <just_read_cus>: Now a
106         std::vector.
107
108 2018-06-08  Paul Koning  <paul_koning@dell.com>
109
110         PR gdb/23252
111
112         * python/python.c (do_start_initialization):
113         Avoid call to internal Python API.
114         (init__gdb_module): New function.
115
116 2018-06-08  Gary Benson <gbenson@redhat.com>
117
118         * linux-thread-db.c (valprint.h): New include.
119         (struct check_thread_db_info): New structure.
120         (check_thread_db_on_load, tdb_testinfo): New static globals.
121         (check_thread_db, check_thread_db_callback): New functions.
122         (try_thread_db_load_1): Run integrity checks if requested.
123         (maintenance_check_libthread_db): New function.
124         (_initialize_thread_db): Register "maint check libthread-db"
125         and "maint set/show check-libthread-db".
126         * NEWS: Mention the above new commands.
127
128 2018-06-08  Tom Tromey  <tom@tromey.com>
129
130         * windows-nat.c (windows_nat_target::xfer_partial): "beneath" is
131         now a method.
132
133 2018-06-08  Tom Tromey  <tom@tromey.com>
134
135         * btrace.c (parse_xml_raw): Use gdb::unique_xmalloc_ptr.
136
137 2018-06-08  Tom Tromey  <tom@tromey.com>
138
139         * common/btrace-common.h (struct btrace_data): Add constructor,
140         destructor, move assignment operator.
141         <empty, clear, fini>: New methods.
142         <format>: Initialize.
143         (btrace_data_init, btrace_data_fini, btrace_data_clear)
144         (btrace_data_empty): Don't declare.
145         * common/btrace-common.c (btrace_data_init): Remove.
146         (btrace_data::fini): Rename from btrace_data_fini.
147         (btrace_data::empty): Rename from btrace_data_empty.
148         (btrace_data::clear): Rename from btrace_data_clear.  Return
149         bool.
150         * btrace.h (make_cleanup_btrace_data): Don't declare.
151         * btrace.c (btrace_add_pc, btrace_stitch_trace, btrace_clear)
152         (parse_xml_btrace): Update.
153         (do_btrace_data_cleanup, make_cleanup_btrace_data): Remove.
154         (maint_btrace_clear_packet_history_cmd): Update.
155
156 2018-06-07  Pedro Alves  <palves@redhat.com>
157
158         * target.h (target_ops) <beneath>: Now a method.  All references
159         updated.
160         (class target_stack): New.
161         * target.c (g_target_stack): New.
162         (g_current_top_target): Delete.
163         (current_top_target): Get the top target out of g_target_stack.
164         (target_stack::push, target_stack::unpush): New.
165         (push_target, unpush_target): Reimplement.
166         (target_is_pushed): Reimplement in terms of g_target_stack.
167         (target_ops::beneath, target_stack::find_beneath): New.
168
169 2018-06-07  Pedro Alves  <palves@redhat.com>
170
171         * target.h (find_target_beneath): Delete declaration.
172         * target.c (find_target_beneath): Delete definition.
173         * aix-thread.c: All callers of find_target_beneath adjusted to
174         call target_ops::beneath instead.
175         * bsd-uthread.c: Likewise.
176         * linux-thread-db.c: Likewise.
177         * ravenscar-thread.c: Likewise.
178         * sol-thread.c: Likewise.
179         * spu-multiarch.c: Likewise.
180
181 2018-06-07  Pedro Alves  <palves@redhat.com>
182
183         * target.h (target_ops) <beneath>: Now a method.  All references
184         updated.
185         (target_ops) <m_beneath>: New.
186         * target.c (target_ops::beneath): New.
187         * corelow.c: Adjust all references to target_ops::beneath.
188         * linux-thread-db.c: Likewise.
189         * make-target-delegates: Likewise.
190         * record-btrace.c: Likewise.
191         * record-full.c: Likewise.
192         * remote.c: Likewise.
193         * target.c: Likewise.
194         * target-delegates.c: Regenerate.
195
196 2018-06-07  Pedro Alves  <palves@redhat.com>
197
198         * target.h (target_stack): Delete.
199         (current_top_target): Declare function.
200         * target.c (target_stack): Delete.
201         (g_current_top_target): New.
202         (current_top_target): New function.
203         * auxv.c: Use current_top_target instead of target_stack
204         throughout.
205         * avr-tdep.c: Likewise.
206         * breakpoint.c: Likewise.
207         * corefile.c: Likewise.
208         * elfread.c: Likewise.
209         * eval.c: Likewise.
210         * exceptions.c: Likewise.
211         * frame.c: Likewise.
212         * gdbarch-selftests.c: Likewise.
213         * gnu-v3-abi.c: Likewise.
214         * ia64-tdep.c: Likewise.
215         * ia64-vms-tdep.c: Likewise.
216         * infcall.c: Likewise.
217         * infcmd.c: Likewise.
218         * infrun.c: Likewise.
219         * linespec.c: Likewise.
220         * linux-tdep.c: Likewise.
221         * minsyms.c: Likewise.
222         * ppc-linux-nat.c: Likewise.
223         * ppc-linux-tdep.c: Likewise.
224         * procfs.c: Likewise.
225         * regcache.c: Likewise.
226         * remote.c: Likewise.
227         * rs6000-tdep.c: Likewise.
228         * s390-linux-nat.c: Likewise.
229         * s390-tdep.c: Likewise.
230         * solib-aix.c: Likewise.
231         * solib-darwin.c: Likewise.
232         * solib-dsbt.c: Likewise.
233         * solib-spu.c: Likewise.
234         * solib-svr4.c: Likewise.
235         * solib-target.c: Likewise.
236         * sparc-tdep.c: Likewise.
237         * sparc64-tdep.c: Likewise.
238         * spu-tdep.c: Likewise.
239         * symfile.c: Likewise.
240         * symtab.c: Likewise.
241         * target-descriptions.c: Likewise.
242         * target-memory.c: Likewise.
243         * target.c: Likewise.
244         * target.h: Likewise.
245         * tracefile-tfile.c: Likewise.
246         * tracepoint.c: Likewise.
247         * valops.c: Likewise.
248         * valprint.c: Likewise.
249         * value.c: Likewise.
250         * windows-tdep.c: Likewise.
251         * mi/mi-main.c: Likewise.
252
253 2018-06-07  Tom Tromey  <tom@tromey.com>
254
255         * valprint.h (build_address_symbolic): Declare.
256         * printcmd.c (print_address_symbolic): Update.
257         (build_address_symbolic): Change "name" and "filename" to
258         std::string.
259         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
260         Update.
261         * defs.h (build_address_symbolic): Remove declaration.
262
263 2018-06-07  Alan Hayward  <alan.hayward@arm.com>
264
265         * aarch64-tdep.c (AARCH64_SVE_V0_REGNUM): Add define.
266         (aarch64_vnv_type): Add function.
267         (aarch64_pseudo_register_name): Add V regs for SVE.
268         (aarch64_pseudo_register_type): Likewise.
269         (aarch64_pseudo_register_reggroup_p): Likewise.
270         (aarch64_pseudo_read_value_2): Use V0 offset for SVE
271         (aarch64_pseudo_read_value): Add V regs for SVE.
272         (aarch64_pseudo_write_2): Use V0 offset for SVE
273         (aarch64_pseudo_write): Add V regs for SVE.
274         * aarch64-tdep.h (struct gdbarch_tdep): Add vnv_type.
275
276 2018-06-06  Sergio Durigan Junior  <sergiodj@redhat.com>
277
278         * arch/aarch64.h (sve_vq_from_vl): Guard with #ifndef.
279         (sve_vl_from_vq): Likewise.
280
281 2018-06-05  Tom Tromey  <tom@tromey.com>
282
283         * cli/cli-cmds.c (show_version): Update.
284         * top.c (print_gdb_version): Add "interactive" parameter.
285         Update.
286         * main.c (captured_main_1): Update.
287         * top.h (print_gdb_version): Add "interactive" parameter and a
288         comment.
289
290 2018-06-05  David Malcolm  <dmalcolm@redhat.com>
291
292         * common/enum-flags.h: Add trailing semicolon to example in
293         comment.
294
295 2018-06-05  Tom Tromey  <tom@tromey.com>
296
297         PR cli/12326:
298         * NEWS: Add entry about pager.
299         * utils.c (pagination_disabled_for_command): New global.
300         (prompt_for_continue): Allow "c" response to prompt.
301         (reinitialize_more_filter): Clear
302         pagination_disabled_for_command.
303         (fputs_maybe_filtered): Check pagination_disabled_for_command.
304
305 2018-06-04  Tom Tromey  <tom@tromey.com>
306
307         * ada-lang.h (ada_lookup_symbol_list): Update.
308         * ada-lang.c (resolve_subexp): Update.
309         (symbols_are_identical_enums): Change type of syms.  Remove nsyms
310         parameter.
311         (remove_extra_symbols, remove_irrelevant_renamings): Likewise.
312         (ada_lookup_symbol_list_worker, ada_lookup_symbol_list): Change
313         results parameter to std::vector.
314         (ada_iterate_over_symbols, ada_lookup_symbol, get_var_value):
315         Update.
316         * ada-exp.y (block_lookup): Update.
317         (select_possible_type_sym): Change type of syms.  Remove nsyms
318         parameter.
319         (write_var_or_type, write_name_assoc): Update.
320
321 2018-06-04  Joel Brobecker  <brobecker@adacore.com>
322
323         * windows-nat.c (windows_nat_target::xfer_partial): Return
324         TARGET_XFER_E_IO if we need to delegate to the target beneath
325         but BENEATH is NULL.
326
327 2018-06-04  Simon Marchi  <simon.marchi@ericsson.com>
328
329         * Makefile.in (config.status): Add configure.nat as a
330         dependency.
331
332 2018-06-04  Tom Tromey  <tom@tromey.com>
333
334         * cp-name-parser.y (cpname_state): Add method declarations.
335         (HANDLE_QUAL): Update.
336         (cpname_state::d_grab, cpname_state::fill_comp)
337         (cpname_state::make_operator, cpname_state::make_dtor)
338         (cpname_state::make_builtin_type, cpname_state::make_name)
339         (cpname_state::d_qualify, cpname_state::d_int_type)
340         (cpname_state::d_unary, cpname_state::d_binary): Now methods.
341         (%union): Move earlier.
342
343 2018-06-04  Alan Hayward  <alan.hayward@arm.com>
344
345         * elfread.c (elf_symfile_segments): Use ELF_SECTION_IN_SEGMENT.
346
347 2018-06-04  Alan Hayward  <alan.hayward@arm.com>
348
349         * aarch64-tdep.c (aarch64_pseudo_read_value_1): New helper func.
350         (aarch64_pseudo_write_1): Likewise.
351         (aarch64_pseudo_read_value): Use helper.
352         (aarch64_pseudo_write): Likewise.
353
354 2018-06-04  Pedro Alves  <palves@redhat.com>
355
356         * darwin-nat.c (darwin_ops): Delete.
357         (darwin_attach_pid): Use get_native_target.
358
359 2018-06-04  Alan Hayward  <alan.hayward@arm.com>
360
361         * aarch64-tdep.c (aarch64_get_tdesc_vq): Use uint64_t for VQ.
362         * aarch64-tdep.h (struct gdbarch_tdep): Likewise.
363
364 2018-06-04  Alan Hayward  <alan.hayward@arm.com>
365
366         * aarch64-linux-nat.c (aarch64_linux_read_description): Support SVE.
367         * aarch64-tdep.c (aarch64_get_tdesc_vq): New function.
368         (aarch64_gdbarch_init): Check for SVE.
369         * aarch64-tdep.h (gdbarch_tdep::has_sve): New function.
370
371 2018-06-04  Alan Hayward  <alan.hayward@arm.com>
372
373         * aarch64-tdep.c (aarch64_read_description): Use uint64_t for VQ.
374         * aarch64-tdep.h (aarch64_read_description): Likewise.
375         * arch/aarch64.c (aarch64_create_target_description): Likewise.
376         * arch/aarch64.h (aarch64_create_target_description): Likewise.
377         * features/aarch64-sve.c (create_feature_aarch64_sve): Likewise.
378         * nat/aarch64-sve-linux-ptrace.c(aarch64_sve_get_vq): Likewise.
379         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_get_vq): Likewise.
380
381 2018-06-02  Simon Marchi  <simon.marchi@ericsson.com>
382
383         * value.c (value_fetch_lazy_bitfield): New.
384         (value_fetch_lazy_memory): New.
385         (value_fetch_lazy_register): New.
386         (value_fetch_lazy): Factor out to smaller functions.
387
388 2018-06-01  Tom Tromey  <tom@tromey.com>
389
390         * cp-name-parser.y (backslashable, represented): Now const.
391
392 2018-06-01  Tom Tromey  <tom@tromey.com>
393
394         * cp-name-parser.y: Include parser-defs.h.
395         (parser_fprintf): Remove declaration.
396
397 2018-06-01  Tom Tromey  <tom@tromey.com>
398
399         * cp-name-parser.y: Use %pure-parser, %lex-param, and
400         %parse-param.
401         (lexptr, prev_lexptr, error_lexptr, global_errmsg, demangle_info)
402         (global_result): Remove globals.
403         (struct cpname_state): New.
404         (yyparse): Don't declare.
405         (yylex, yyerror): Move declarations after %union.
406         (d_grab, fill_comp, make_operator, make_dtor, make_builtin_type)
407         (make_name): Add state parameter.
408         Update all callers.
409         (d_qualify, d_int_type, d_unary, d_binary, parse_number) Add state
410         parameter.
411         (HANDLE_QUAL, HANDLE_SPECIAL, HANDLE_TOKEN2, HANDLE_TOKEN3):
412         Update.
413         (yylex): Add lvalp, state parameters.
414         (yyerror): Add state parameter.
415         (cp_demangled_name_to_comp): Update.
416
417 2018-06-01  Tom Tromey  <tom@tromey.com>
418
419         * cp-name-parser.y (parser_fprintf): Declare.
420         (GDB_YY_REMAP_PREFIX): Define.
421         Include yy-remap.h.  Don't redefine yy* identifiers.
422
423 2018-06-01  Tom Tromey  <tom@tromey.com>
424
425         * python/py-type.c (typy_legacy_template_argument): Update.
426         * cp-support.h (cp_demangled_name_to_comp): Update.
427         * cp-name-parser.y (cp_demangled_name_to_comp): Change errmsg
428         parameter to be a "std::string *".
429         (main): Update.
430
431 2018-06-01  H.J. Lu  <hongjiu.lu@intel.com>
432
433         * ada-lex.l: Include "diagnostics.h" instead of
434         "common/diagnostics.h".
435         * unittests/environ-selftests.c: Likewise.
436         * common/diagnostics.h: Moved to ../include.
437
438 2018-06-01  Joel Brobecker  <brobecker@adacore.com>
439
440         * breakpoint.c (breakpoint_re_set): Temporarily force language_mode
441         to language_mode_manual while calling breakpoint_re_set_one.
442
443 2018-06-01  Tom Tromey  <tom@tromey.com>
444
445         * valops.c (value_cast_structs, destructor_name_p): Update.
446         * symtab.c (gdb_mangle_name): Update.
447         * stabsread.c (define_symbol, read_cpp_abbrev, read_baseclasses):
448         Update.
449         * p-valprint.c (pascal_object_is_vtbl_ptr_type)
450         (pascal_object_print_value_fields, pascal_object_print_value):
451         Update.
452         * p-typeprint.c (pascal_type_print_derivation_info): Update.
453         * linespec.c (find_methods): Update.
454         * gdbtypes.h (type_name_no_tag): Remove.
455         (type_name_or_error): Rename from type_name_no_tag_or_error.
456         * gdbtypes.c (type_name_no_tag): Remove.
457         (type_name_or_error): Rename from type_name_no_tag_or_error.
458         (lookup_struct_elt_type, check_typedef): Update.
459         * expprint.c (print_subexp_standard): Update.
460         * dwarf2read.c (dwarf2_add_field, load_partial_dies): Update.
461         * d-namespace.c (d_lookup_nested_symbol): Update.
462         * cp-valprint.c (cp_is_vtbl_ptr_type, cp_print_value_fields)
463         (cp_print_class_member): Update.
464         * cp-namespace.c (cp_lookup_nested_symbol): Update.
465         * completer.c (add_struct_fields): Update.
466         * c-typeprint.c (cp_type_print_derivation_info)
467         (c_type_print_varspec_prefix, c_type_print_base_struct_union):
468         Update.
469         * ada-lang.c (parse_old_style_renaming, xget_renaming_scope)
470         (ada_prefer_type, ada_is_exception_sym): Update.
471
472 2018-06-01  Tom Tromey  <tom@tromey.com>
473
474         * valops.c (enum_constant_from_type, value_namespace_elt)
475         (value_maybe_namespace_elt): Update.
476         * valarith.c (find_size_for_pointer_math): Update.
477         * target-descriptions.c (make_gdb_type): Update.
478         * symmisc.c (print_symbol): Update.
479         * stabsread.c (define_symbol, read_type)
480         (complain_about_struct_wipeout, add_undefined_type)
481         (cleanup_undefined_types_1): Update.
482         * rust-lang.c (rust_tuple_type_p, rust_slice_type_p)
483         (rust_range_type_p, val_print_struct, rust_print_struct_def)
484         (rust_internal_print_type, rust_composite_type)
485         (rust_evaluate_funcall, rust_evaluate_subexp)
486         (rust_inclusive_range_type_p): Update.
487         * python/py-type.c (typy_get_tag): Update.
488         * p-typeprint.c (pascal_type_print_base): Update.
489         * mdebugread.c (parse_symbol, parse_type): Update.
490         * m2-typeprint.c (m2_long_set, m2_record_fields, m2_enum):
491         Update.
492         * guile/scm-type.c (gdbscm_type_tag): Update.
493         * go-lang.c (sixg_string_p): Update.
494         * gnu-v3-abi.c (build_gdb_vtable_type, build_std_type_info_type):
495         Update.
496         * gdbtypes.h (struct main_type) <tag_name>: Remove.
497         (TYPE_TAG_NAME): Remove.
498         * gdbtypes.c (type_name_no_tag): Simplify.
499         (check_typedef, check_types_equal, recursive_dump_type)
500         (copy_type_recursive, arch_composite_type): Update.
501         * f-typeprint.c (f_type_print_base): Update.  Print "Type" prefix
502         in summary mode when needed.
503         * eval.c (evaluate_funcall): Update.
504         * dwarf2read.c (fixup_go_packaging, read_structure_type)
505         (process_structure_scope, read_enumeration_type)
506         (read_namespace_type, read_module_type, determine_prefix): Update.
507         * cp-support.c (inspect_type): Update.
508         * coffread.c (process_coff_symbol, decode_base_type): Update.
509         * c-varobj.c (c_is_path_expr_parent): Update.
510         * c-typeprint.c (c_type_print_base_struct_union): Update.
511         (c_type_print_base_1): Update.  Print struct/class/union/enum in
512         summary when using C language.
513         * ax-gdb.c (gen_struct_ref, gen_namespace_elt)
514         (gen_maybe_namespace_elt): Update.
515         * ada-lang.c (ada_type_name): Simplify.
516         (empty_record, ada_template_to_fixed_record_type_1)
517         (template_to_static_fixed_type)
518         (to_record_with_fixed_variant_part, ada_check_typedef): Update.
519
520 2018-06-01  Tom Tromey  <tom@tromey.com>
521
522         * dwarf2read.c (dwarf2_compute_name): Pass CU's language to
523         c_print_type.
524         * c-typeprint.c (c_print_type_1): Add "language" parameter.
525         (c_print_type): Update.
526         (c_print_type): New overload.
527         (c_type_print_varspec_prefix, c_type_print_args)
528         (c_type_print_varspec_suffix, c_print_type_no_offsets)
529         (c_type_print_base_struct_union, c_type_print_base_1)
530         (cp_type_print_method_args): Add "language" parameter.
531         (c_type_print_base): Update.
532         * c-lang.h (c_print_type): Add new overload.
533
534 2018-06-01  Tom Tromey  <tom@tromey.com>
535
536         * typeprint.h (c_type_print_varspec_suffix): Don't declare.
537         * c-typeprint.c (c_type_print_varspec_suffix): Now static.
538
539 2018-06-01  Alan Hayward  <alan.hayward@arm.com>
540
541         * aarch64-tdep.c (aarch64_sve_register_names): New const
542         var.
543         * arch/aarch64.h (enum aarch64_regnum): Add SVE entries.
544         (AARCH64_SVE_Z_REGS_NUM): New define.
545         (AARCH64_SVE_P_REGS_NUM): Likewise.
546         (AARCH64_SVE_NUM_REGS): Likewise.
547
548 2018-05-31  Uros Bizjak  <ubizjak@gmail.com>
549
550         * nat/linux-ptrace.h [__alpha__]
551         (GDB_ARCH_IS_TRAP_BRKPT, GDB_ARCH_IS_TRAP_HWBKPT): Remove
552         definitions.
553
554 2018-05-31  Maciej W. Rozycki  <macro@mips.com>
555
556         * arch-utils.c (gdbarch_info_fill): Set `default_byte_order' to
557         the endianness selected.
558         * NEWS: Document `set endian auto' mode operation update.
559
560 2018-05-31  Alan Hayward  <alan.hayward@arm.com>
561
562         * Makefile.in: Add new header.
563         * gdb/arch/aarch64.h (sve_vg_from_vl): New macro.
564         (sve_vl_from_vg): Likewise.
565         (sve_vq_from_vl): Likewise.
566         (sve_vl_from_vq): Likewise.
567         (sve_vq_from_vg): Likewise.
568         (sve_vg_from_vq): Likewise.
569         * configure.nat: Add new c file.
570         * nat/aarch64-sve-linux-ptrace.c: New file.
571         * nat/aarch64-sve-linux-ptrace.h: New file.
572
573 2018-05-31  Alan Hayward  <alan.hayward@arm.com>
574
575         * aarch64-linux-nat.c (aarch64_linux_read_description):
576         Add parmeter zero.
577         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
578         Likewise.
579         * aarch64-tdep.c (tdesc_aarch64_list): Add.
580         (aarch64_read_description): Use VQ to index tdesc_aarch64_list.
581         (aarch64_gdbarch_init): Add parmeter zero.
582         * aarch64-tdep.h (aarch64_read_description): Add VQ parmeter.
583         * arch/aarch64.c (aarch64_create_target_description): Check VQ.
584         * arch/aarch64.h (aarch64_create_target_description): Add VQ.
585         parmeter.
586         * doc/gdb.texinfo: Describe SVE feature
587         * features/aarch64-sve.c: New file.
588
589 2018-05-31  Omair Javaid  <omair.javaid@linaro.org>
590
591         PR gdb/23210
592         * gdbarch.sh (significant_addr_bit): Default to zero when
593         not set by target architecture.
594         * gdbarch.c: Re-generated.
595         * utils.c (address_significant): Update.
596
597 2018-05-30  Joel Brobecker  <brobecker@adacore.com>
598
599         * stack.c (func_command): Remove trailing newline in call to error.
600
601 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
602
603         * regcache.h (regcache_raw_collect): Remove, update callers to
604         use regcache::raw_collect.
605         * regcache.c (regcache_raw_collect): Remove.
606
607 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
608
609         * regcache.h (regcache_raw_supply): Remove, update callers to
610         use detached_regcache::raw_supply.
611         * regcache.c (regcache_raw_supply): Remove.
612
613 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
614
615         * regcache.h (regcache_cooked_write_part): Remove, update
616         callers to use regcache::cooked_write_part.
617         * regcache.c (regcache_cooked_write_part): Remove.
618
619 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
620
621         * regcache.h (regcache_cooked_read_part): Remove, update callers
622         to use readable_regcache::cooked_read_part.
623         * regcache.c (regcache_cooked_read_part): Remove.
624
625 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
626
627         * regcache.h (regcache_cooked_read_value): Remove, update
628         callers to use readable_regcache::cooked_read_value.
629         * regcache.c (regcache_cooked_read_value): Remove.
630
631 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
632
633         * regcache.h (regcache_cooked_write): Remove, update callers to
634         use regcache::cooked_write.
635         * regcache.c (regcache_cooked_write): Remove.
636
637 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
638
639         * regcache.h (regcache_invalidate): Remove, update callers to
640         use detached_regcache::invalidate instead.
641         * regcache.c (regcache_invalidate): Remove.
642
643 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
644
645         * regcache.h (regcache_raw_write_part): Remove, update callers
646         to use regcache::raw_write_part instead.
647         * regcache.c (regcache_raw_write_part): Remove.
648
649 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
650
651         * regcache.h (regcache_raw_read_part): Remove, update callers to
652         use readable_regcache::raw_read_part instead.
653         * regcache.c (regcache_raw_read_part): Remove.
654
655 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
656
657         * regcache.h (regcache_cooked_read): Remove, update callers to
658         use readable_regcache::cooked_read instead.
659         * regcache.c (regcache_cooked_read): Remove.
660
661 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
662
663         * regcache.h (regcache_raw_write): Remove, update callers to use
664         regcache::raw_write instead.
665         * regcache.c (regcache_raw_write): Remove.
666
667 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
668
669         * regcache.h (regcache_raw_read): Remove, update callers to use
670         readable_regcache::raw_read instead.
671         * regcache.c (regcache_raw_read): Remove.
672
673 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
674
675         * regcache.h (regcache_raw_update): Remove, update callers to
676         use readable_regcache::raw_update instead.
677         * regcache.c (regcache_raw_update): Remove.
678
679 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
680
681         * regcache.h (regcache_register_status): Remove, update callers
682         to use reg_buffer::get_register_status directly instead.
683         * regcache.c (regcache_register_status): Remove.
684
685 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
686
687         * regcache.h (regcache_get_ptid): Remove, update all callers to
688         call regcache::ptid instead.
689         * regcache.c (regcache_get_ptid): Remove.
690
691 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
692
693         * Makefile.in (ALL_TARGET_OBS): Add or1k-tdep.o.
694
695 2018-05-30  Pedro Alves  <palves@redhat.com>
696
697         * common/common-exceptions.h (exception_rethrow): Use
698         ATTRIBUTE_NORETURN.
699
700 2018-05-29  Simon Marchi  <simon.marchi@polymtl.ca>
701
702         * breakpoint.c (print_solib_event, check_status_catch_solib):
703         Remove struct keyword in range-based for loops.
704         * dbxread.c (find_corresponding_bincl_psymtab): Likewise.
705         * dwarf2read.c (compute_delayed_physnames, rust_union_quirks);
706         Likewise.
707         * linespec.c (find_superclass_methods, search_minsyms_for_name):
708         Likewise.
709         * symfile.c (addr_info_make_relative): Likewise.
710         * thread.c (value_in_thread_stack_temporaries): Likewise.
711
712 2018-05-29  Weimin Pan  <weimin.pan@oracle.com>
713
714         * minsyms.h (lookup_minimal_symbol_and_objfile): Remove declaration.
715         * minsyms.c (lookup_minimal_symbol_and_objfile): Remove definition.
716         * coff-pe-read.c (add_pe_forwarded_sym): Replace
717         lookup_minimal_symbol_and_objfile with lookup_bound_minimal_symbol.
718         * glibc-tdep.c (glibc_skip_solib_resolver): Likewise.
719         * jit.c (jit_breakpoint_re_set_internal): Likewise.
720         * printcmd.c (info_address_command): Likewise.
721
722 2018-05-29  Tom Tromey  <tom@tromey.com>
723
724         * windows-nat.c (handle_exception): Update fall-through comment.
725
726 2018-05-29  Tom Tromey  <tom@tromey.com>
727
728         * progspace.h (so_list_ptr): Remove typedef.  Don't declare VEC.
729         (struct program_space) <added_solibs>: Now a std::vector.
730         * breakpoint.c (print_solib_event): Update.
731         (check_status_catch_solib): Update.
732         * progspace.c (clear_program_space_solib_cache): Update.
733         * solib.c (update_solib_list): Update.
734
735 2018-05-29  Tom Tromey  <tom@tromey.com>
736
737         * python/py-type.c (typy_richcompare): Update.
738         * guile/scm-type.c (tyscm_equal_p_type_smob): Update.
739         * gdbtypes.h (types_deeply_equal): Return bool.
740         (types_equal): Likewise.
741         * gdbtypes.c (type_equality_entry_d): Remove typedef.  Don't
742         declare VEC.
743         (check_types_equal): Change worklist to std::vector.  Return
744         bool.
745         (struct type_equality_entry): Add constructor.
746         (compare_maybe_null_strings): Return bool.
747         (check_types_worklist): Return bool.  Change worklist to
748         std::vector.
749         (types_deeply_equal): Use std::vector.
750         (types_equal): Return bool.
751         (compare_maybe_null_strings): Simplify.
752
753 2018-05-29  Tom Tromey  <tom@tromey.com>
754
755         * record-btrace.c (tp_t): Remove typedef.  Don't declare VEC.
756
757 2018-05-29  Tom Tromey  <tom@tromey.com>
758
759         * objc-lang.h: Don't include cp-support.h.
760         * common/gdb_vecs.h (const_char_ptr): Remove typedef.  Don't
761         declare VEC.
762
763 2018-05-27  Tom Tromey  <tom@tromey.com>
764
765         * Makefile.in (DEPFILES): Don't reference REMOTE_OBS.
766
767 2018-05-25  Tom Tromey  <tom@tromey.com>
768
769         * value.c (value::location): Initialize.
770
771 2018-05-25  Tom Tromey  <tom@tromey.com>
772
773         * dbxread.c (init_bincl_list): Remove.
774         (bincl_list): Now a std::vector.
775         (bincls_allocated, next_bincl): Remove.
776         (free_bincl_list, do_free_bincl_list_cleanup)
777         (make_cleanup_free_bincl_list): Remove.
778         (dbx_read_symtab, elfstab_build_psymtabs): Use scoped_restore,
779         unique_xmalloc_ptr.
780         (find_corresponding_bincl_psymtab, read_dbx_symtab): Update.
781         (struct header_file_location): Add constructor.
782         (add_bincl_to_list): Remove.
783
784 2018-05-25  Tom Tromey  <tom@tromey.com>
785
786         * tui/tui.c (tui_enable): Update.
787         * mi/mi-interp.c (mi_interp::init): Update.
788         * interps.h (class interp) <name>: New method.
789         <m_name>: Rename from name.
790         (~scoped_restore_interp): Update.
791         * interps.c (interp::interp): Update.
792         (interp_add, interp_set, interp_lookup_existing)
793         (current_interp_named_p): Update.
794
795 2018-05-25  Tom Tromey  <tom@tromey.com>
796
797         * interps.c (interp_name): Remove.
798         * mi/mi-interp.c (mi_interp::init): Update.
799         * interps.h (interp_name): Remove.
800         (~scoped_restore_interp): Update.
801         * tui/tui.c (tui_enable): Update.
802
803 2018-05-25  Tom Tromey  <tom@tromey.com>
804
805         * utils.c (fputs_maybe_filtered): Update.
806         * linespec.c (decode_line_full): Update.
807         * mi/mi-interp.c (mi_on_normal_stop_1, mi_tsv_modified)
808         (mi_print_breakpoint_for_event, mi_solib_loaded)
809         (mi_solib_unloaded, mi_command_param_changed, mi_memory_changed)
810         (mi_user_selected_context_changed): Update.
811         * mi/mi-main.c (mi_execute_command): Update.
812         * cli/cli-script.c (execute_control_command): Update.
813         * python/python.c (execute_gdb_command): Update.
814         * solib.c (info_sharedlibrary_command): Update.
815         * interps.c (interp_ui_out): Remove.
816         * interps.h (interp_ui_out): Remove.
817
818 2018-05-25  Tom Tromey  <tom@tromey.com>
819
820         * tui/tui-interp.c (as_tui_interp): Use dynamic_cast.
821         * mi/mi-interp.c (as_mi_interp): Use dynamic_cast.
822         * cli/cli-interp.c (as_cli_interp): Use dynamic_cast.
823
824 2018-05-25  Tom Tromey  <tom@tromey.com>
825
826         * cli/cli-interp.c (safe_execute_command): Use scoped_restore.
827         * interps.c (interp_exec): Use scoped_restore.
828
829 2018-05-25  Tom Tromey  <tom@tromey.com>
830
831         * remote.c (remote_target::remote_file_get): Use
832         gdb::byte_vector.
833         (remote_target::remote_file_put): Likewise.
834
835 2018-05-25  Tom Tromey  <tom@tromey.com>
836
837         * coff-pe-read.c (struct read_pe_section_data) <section_name>: Now
838         a std::string.
839         (get_pe_section_index, add_pe_exported_sym): Update.
840         (read_pe_exported_syms): Use gdb::def_vector.
841
842 2018-05-25  Tom Tromey  <tom@tromey.com>
843
844         * frame.c (remove_prev_frame): Remove.
845         (get_prev_frame_if_no_cycle): Use TRY/CATCH.
846
847 2018-05-25  Maciej W. Rozycki  <macro@mips.com>
848
849         * mips-linux-tdep.h (mips_supply_fpregset, mips_fill_fpregset):
850         Remove prototypes.
851         * mips-linux-nat.c (supply_fpregset): Always call
852         `mips64_supply_fpregset' rather than `mips_supply_fpregset'.
853         (fill_fpregset): Always call `mips64_fill_fpregset' rather than
854         `mips_fill_fpregset'.
855         * mips-linux-tdep.c (mips_supply_fpregset)
856         (mips_supply_fpregset_wrapper, mips_fill_fpregset)
857         (mips_fill_fpregset_wrapper): Remove functions.
858         (mips64_supply_fpregset, mips64_fill_fpregset): Update comments.
859         (mips_linux_fpregset): Remove variable.
860         (mips_linux_iterate_over_regset_sections): Use
861         `mips64_linux_fpregset' in place of `mips_linux_fpregset'.
862         (mips_linux_o32_sigframe_init): Remove comment.
863
864 2018-05-25  Pedro Alves  <palves@redhat.com>
865
866         * remote.c (struct vCont_action_support, MAXTHREADLISTRESULTS)
867         (struct readahead_cache, struct packet_reg, struct
868         remote_arch_state, class remote_state): Move higher up in the
869         file.
870         (remote_target::m_remote_state): Now an object instead of a pointer.
871         (remote_target::get_remote_state): Adjust.
872
873 2018-05-24  Andrew Burgess  <andrew.burgess@embecosm.com>
874
875         * stack.c (select_and_print_frame): Delete.
876         (struct function_bounds): Move struct within function.
877         (func_command): Most content moved into new function
878         find_frame_for_function, use new function, print result, add
879         function comment.
880         (find_frame_for_function): New function, now returns a result.
881
882 2018-05-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
883
884         * stack.c (iterate_over_block_arg_vars): Fix comment.
885         (print_frame_arg_vars): Pass stream in cb_data, not gdb_stdout.
886
887 2018-05-24  Andrew Burgess  <andrew.burgess@embecosm.com>
888
889         PR gdb/23203
890         * frame.c
891         (scoped_restore_selected_frame::scoped_restore_selected_frame):
892         Define.
893         (scoped_restore_selected_frame::~scoped_restore_selected_frame):
894         Define.
895         * frame.h (class scoped_restore_selected_frame): New class.
896         * stack.c (print_frame_local_vars): Remove catching and rethrowing
897         of any exception, use scoped_restore_selected_frame to restore the
898         frame instead.
899
900 2018-05-24  Pedro Alves  <palves@redhat.com>
901
902         * darwin-nat.h (darwin_nat_target::create_inferior): Mark with
903         override.
904
905 2018-05-23  Tom Tromey  <tom@tromey.com>
906
907         * complaints.c (struct complaints): Remove.
908         (symfile_complaint_book): Remove.
909         (series): New global.
910         (complaint_internal): Update.
911         (clear_complaints): Update.
912
913 2018-05-23  Tom Tromey  <tom@tromey.com>
914
915         * complaints.c (counters): New global.
916         (struct complain): Remove.
917         (struct complaints) <root>: Remove.
918         (complaint_sentinel): Remove.
919         (symfile_complaint_book): Update.
920         (find_complaint) Remove.
921         (complaint_internal, clear_complaints): Update.
922
923 2018-05-23  Tom Tromey  <tom@tromey.com>
924
925         * complaints.c (struct complain) <file, line>: Remove.
926         (find_complaint): Remove file, line parameters.
927         (complaint_internal): Update.
928
929 2018-05-23  Tom Tromey  <tom@tromey.com>
930
931         * complaints.c (vcomplaint): Remove.
932         (complaint_internal) Merge in contents of vcomplaint.
933
934 2018-05-23  Tom Tromey  <tom@tromey.com>
935
936         * complaints.c (struct complaints) <explanation>: Remove.
937         (symfile_explanations): Remove.
938         (symfile_complaint_book): Update.
939         (vcomplaint): Update.
940         (struct explanation): Remove.
941
942 2018-05-23  Tom Tromey  <tom@tromey.com>
943
944         * complaints.c (symfile_complaints): Remove.
945         (complaint_internal): Remove "complaints" parameter.
946         (clear_complaints, vcomplaint): Remove "c" parameter.
947         (get_complaints): Remove.
948         * dwarf2read.c (dwarf2_statement_list_fits_in_line_number_section_complaint)
949         (dwarf2_debug_line_missing_file_complaint)
950         (dwarf2_debug_line_missing_end_sequence_complaint)
951         (dwarf2_complex_location_expr_complaint)
952         (dwarf2_const_value_length_mismatch_complaint)
953         (dwarf2_section_buffer_overflow_complaint)
954         (dwarf2_macro_malformed_definition_complaint)
955         (dwarf2_invalid_attrib_class_complaint)
956         (create_addrmap_from_index, dw2_symtab_iter_next)
957         (dw2_expand_marked_cus)
958         (dw2_debug_names_iterator::find_vec_in_debug_names)
959         (dw2_debug_names_iterator::next, dw2_debug_names_iterator::next)
960         (create_debug_type_hash_table, init_cutu_and_read_dies)
961         (partial_die_parent_scope, add_partial_enumeration)
962         (skip_one_die, fixup_go_packaging, quirk_rust_enum, process_die)
963         (dwarf2_compute_name, dwarf2_physname, read_namespace_alias)
964         (read_import_statement, read_file_scope, create_dwo_cu_reader)
965         (create_cus_hash_table, create_dwp_hash_table)
966         (inherit_abstract_dies, read_func_scope, read_call_site_scope)
967         (dwarf2_rnglists_process, dwarf2_ranges_process)
968         (dwarf2_add_type_defn, dwarf2_attach_fields_to_type)
969         (dwarf2_add_member_fn, get_alignment, maybe_set_alignment)
970         (handle_struct_member_die, process_structure_scope)
971         (read_array_type, read_common_block, read_module_type)
972         (read_tag_pointer_type, read_typedef, read_base_type)
973         (read_subrange_type, load_partial_dies, partial_die_info::read)
974         (partial_die_info::read, partial_die_info::read)
975         (partial_die_info::read, read_checked_initial_length_and_offset)
976         (dwarf2_string_attr, read_formatted_entries)
977         (dwarf_decode_line_header)
978         (lnp_state_machine::check_line_address, dwarf_decode_lines_1)
979         (new_symbol, dwarf2_const_value_attr, lookup_die_type)
980         (read_type_die_1, determine_prefix, dwarf2_get_ref_die_offset)
981         (dwarf2_get_attr_constant_value, dwarf2_fetch_constant_bytes)
982         (get_signatured_type, get_DW_AT_signature_type)
983         (decode_locdesc, file_file_name, consume_improper_spaces)
984         (skip_form_bytes, skip_unknown_opcode, dwarf_parse_macro_header)
985         (dwarf_decode_macro_bytes, dwarf_decode_macros)
986         (dwarf2_symbol_mark_computed, set_die_type)
987         (read_attribute_value): Update.
988         * stap-probe.c (handle_stap_probe, get_stap_base_address):
989         Update.
990         * dbxread.c (unknown_symtype_complaint)
991         (lbrac_mismatch_complaint, repeated_header_complaint)
992         (set_namestring, function_outside_compilation_unit_complaint)
993         (read_dbx_symtab, process_one_symbol): Update.
994         * gdbtypes.c (stub_noname_complaint): Update.
995         * windows-nat.c (handle_unload_dll): Update.
996         * coffread.c (coff_symtab_read, enter_linenos, decode_type)
997         (decode_base_type): Update.
998         * xcoffread.c (bf_notfound_complaint, ef_complaint)
999         (eb_complaint, record_include_begin, record_include_end)
1000         (enter_line_range, xcoff_next_symbol_text, read_xcoff_symtab)
1001         (process_xcoff_symbol, read_symbol)
1002         (function_outside_compilation_unit_complaint)
1003         (scan_xcoff_symtab): Update.
1004         * machoread.c (macho_symtab_read, macho_add_oso_symfile): Update.
1005         * buildsym.c (finish_block_internal, make_blockvector)
1006         (end_symtab_get_static_block, augment_type_symtab): Update.
1007         * dtrace-probe.c (dtrace_process_dof)
1008         (dtrace_static_probe_ops::get_probes): Update.
1009         * complaints.h (struct complaint): Don't declare.
1010         (symfile_complaints): Remove.
1011         (complaint_internal): Remove "complaints" parameter.
1012         (complaint): Likewise.
1013         (clear_complaints): Likewise.
1014         * symfile.c (syms_from_objfile_1, finish_new_objfile)
1015         (reread_symbols): Update.
1016         * dwarf2-frame.c (dwarf2_restore_rule, execute_cfa_program)
1017         (dwarf2_frame_cache, decode_frame_entry): Update.
1018         * dwarf2loc.c (dwarf_reg_to_regnum): Update.
1019         * objc-lang.c (lookup_objc_class, lookup_child_selector)
1020         (info_selectors_command): Update.
1021         * macrotab.c (macro_include, check_for_redefinition)
1022         (macro_undef): Update.
1023         * objfiles.c (filter_overlapping_sections): Update.
1024         * stabsread.c (invalid_cpp_abbrev_complaint)
1025         (reg_value_complaint, stabs_general_complaint, dbx_lookup_type)
1026         (define_symbol, error_type, read_type, rs6000_builtin_type)
1027         (stabs_method_name_from_physname, read_member_functions)
1028         (read_cpp_abbrev, read_baseclasses, read_tilde_fields)
1029         (attach_fields_to_type, complain_about_struct_wipeout)
1030         (read_range_type, read_args, common_block_start)
1031         (common_block_end, cleanup_undefined_types_1, scan_file_globals):
1032         Update.
1033         * mdebugread.c (index_complaint, unknown_ext_complaint)
1034         (basic_type_complaint, bad_tag_guess_complaint)
1035         (bad_rfd_entry_complaint, unexpected_type_code_complaint)
1036         (reg_value_complaint, parse_symbol, parse_type, upgrade_type)
1037         (parse_procedure, parse_lines)
1038         (function_outside_compilation_unit_complaint)
1039         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref)
1040         (bad_tag_guess_complaint, reg_value_complaint): Update.
1041         * cp-support.c (demangled_name_complaint): Update.
1042         * macroscope.c (sal_macro_scope): Update.
1043         * dwarf-index-write.c (class debug_names): Update.
1044
1045 2018-05-23  Tom Tromey  <tom@tromey.com>
1046
1047         * complaints.c (clear_complaints): Remove "noisy" parameter.
1048         * complaints.h (clear_complaints): Update.
1049         * symfile.c (syms_from_objfile_1, finish_new_objfile)
1050         (reread_symbols): Update.
1051
1052 2018-05-23  Tom Tromey  <tom@tromey.com>
1053
1054         * complaints.c (enum complaint_series): Remove FIRST_MESSAGE,
1055         SUBSEQUENT_MESSAGE.
1056         (vcomplaint, clear_complaints): Update.
1057         (symfile_explanations): Remove some messages.
1058
1059 2018-05-23  Tom Tromey  <tom@tromey.com>
1060
1061         * complaints.c (internal_complaint): Remove.
1062         * complaints.h (internal_complaint): Remove.
1063
1064 2018-05-22  Maciej W. Rozycki  <macro@mips.com>
1065
1066         * i387-tdep.c (i387_collect_xsave): Make `i' unsigned.
1067
1068 2018-05-22  Pedro Alves  <palves@redhat.com>
1069
1070         * remote-fileio.c (remote_fileio_reply, remote_fileio_ioerror)
1071         (remote_fileio_badfd, remote_fileio_return_errno)
1072         (remote_fileio_return_success, remote_fileio_func_open)
1073         (remote_fileio_func_open, remote_fileio_func_close)
1074         (remote_fileio_func_read, remote_fileio_func_write)
1075         (remote_fileio_func_lseek, remote_fileio_func_rename)
1076         (remote_fileio_func_unlink, remote_fileio_func_stat)
1077         (remote_fileio_func_fstat, remote_fileio_func_gettimeofday)
1078         (remote_fileio_func_isatty, remote_fileio_func_system): Add
1079         remote_target parameter.
1080         (remote_fio_func_map) <func>: Add remote_target parameter.
1081         (do_remote_fileio_request, remote_fileio_request):
1082         * remote-fileio.h (remote_fileio_request):
1083         * remote-notif.c (remote_notif_ack, remote_notif_parse, ): Add
1084         remote_target parameter.
1085         (remote_notif_process, handle_notification): Adjust to pass down
1086         the remote.
1087         (remote_notif_state_allocate): Add remote_target parameter.  Save
1088         it.
1089         * remote-notif.h (struct remote_target): Forward declare.
1090         (struct notif_client) <parse, ack, can_get_pending_events>: Add
1091         remote_target parameter.
1092         (struct remote_notif_state) <remote>: New field.
1093         (remote_notif_ack, remote_notif_parse): Add remote_target
1094         parameter.
1095         (remote_notif_state_allocate, remote_notif_state_allocate): Add
1096         remote_target parameter.
1097         * remote.c (OPAQUETHREADBYTES, threadref, gdb_ext_thread_info)
1098         (threads_listing_context, rmt_thread_action, protocol_feature)
1099         (packet_reg, stop_reply, stop_reply_p, enum packet_support)
1100         (packet_result, struct threads_listing_context, remote_state):
1101         Move definitions and declarations higher up.
1102         (remote_target) <~remote_target>: Declare.
1103         (remote_download_command_source, remote_file_put, remote_file_get)
1104         (remote_file_delete, remote_hostio_pread, remote_hostio_pwrite)
1105         (remote_hostio_pread_vFile, remote_hostio_send_command)
1106         (remote_hostio_set_filesystem, remote_hostio_open)
1107         (remote_hostio_close, remote_hostio_unlink, remote_state)
1108         (get_remote_state, get_remote_packet_size, get_memory_packet_size)
1109         (get_memory_write_packet_size, get_memory_read_packet_size)
1110         (append_pending_thread_resumptions, remote_detach_1)
1111         (append_resumption, remote_resume_with_vcont)
1112         (add_current_inferior_and_thread, wait_ns, wait_as)
1113         (process_stop_reply, remote_notice_new_inferior)
1114         (process_initial_stop_replies, remote_add_thread)
1115         (btrace_sync_conf, remote_btrace_maybe_reopen)
1116         (remove_new_fork_children, kill_new_fork_children)
1117         (discard_pending_stop_replies, stop_reply_queue_length)
1118         (check_pending_events_prevent_wildcard_vcont)
1119         (discard_pending_stop_replies_in_queue, stop_reply)
1120         (remote_notif_remove_queued_reply, stop_reply *queued_stop_reply)
1121         (peek_stop_reply, remote_parse_stop_reply, remote_stop_ns)
1122         (remote_interrupt_as, remote_interrupt_ns)
1123         (remote_get_noisy_reply, remote_query_attached)
1124         (remote_add_inferior, remote_current_thread, get_current_thread)
1125         (set_thread, set_general_thread, set_continue_thread)
1126         (set_general_process, write_ptid)
1127         (remote_unpack_thread_info_response, remote_get_threadinfo)
1128         (parse_threadlist_response, remote_get_threadlist)
1129         (remote_threadlist_iterator, remote_get_threads_with_ql)
1130         (remote_get_threads_with_qxfer)
1131         (remote_get_threads_with_qthreadinfo, extended_remote_restart)
1132         (get_offsets, remote_check_symbols, remote_supported_packet)
1133         (remote_query_supported, remote_packet_size)
1134         (remote_serial_quit_handler, remote_detach_pid)
1135         (remote_vcont_probe, remote_resume_with_hc)
1136         (send_interrupt_sequence, interrupt_query)
1137         (remote_notif_get_pending_events, fetch_register_using_p)
1138         (send_g_packet, process_g_packet, fetch_registers_using_g)
1139         (store_register_using_P, store_registers_using_G)
1140         (set_remote_traceframe, check_binary_download)
1141         (remote_write_bytes_aux, remote_write_bytes, remote_read_bytes_1)
1142         (remote_xfer_live_readonly_partial, remote_read_bytes)
1143         (remote_send_printf, remote_flash_write, readchar)
1144         (remote_serial_write, putpkt, putpkt_binary, skip_frame)
1145         (read_frame, getpkt, getpkt_or_notif_sane_1, getpkt_sane)
1146         (getpkt_or_notif_sane, remote_vkill, remote_kill_k)
1147         (extended_remote_disable_randomization, extended_remote_run)
1148         (send_environment_packet, extended_remote_environment_support)
1149         (extended_remote_set_inferior_cwd, remote_write_qxfer)
1150         (remote_read_qxfer, push_stop_reply, vcont_r_supported)
1151         (packet_command): Now methods of ...
1152         (remote_target): ... this class.
1153         (m_remote_state) <remote_target>: New field.
1154         (struct remote_state) <stop_reply_queue,
1155         remote_async_inferior_event_token, wait_forever_enabled_p>: New
1156         fields.
1157         (remote_state::remote_state): Allocate stop_reply_queue.
1158         (remote_state): Delete global.
1159         (get_remote_state_raw): Delete.
1160         (remote_target::get_remote_state): Allocate m_remote_state on
1161         demand.
1162         (get_current_remote_target): New.
1163         (remote_ops, extended_remote_ops): Delete.
1164         (wait_forever_enabled_p, remote_async_inferior_event_token):
1165         Delete, moved to struct remote_state.
1166         (remote_target::close): Delete self.  Destruction bits split to
1167         ...
1168         (remote_target::~remote_target): ... this.
1169         (show_memory_packet_size): Adjust to use
1170         get_current_remote_target.
1171         (struct protocol_feature) <func>: Add remote_target parameter.
1172         All callers adjusted.
1173         (curr_quit_handler_target): New.
1174         (remote_serial_quit_handler): Reimplement.
1175         (remote_target::open_1): Adjust to use get_current_remote_target.
1176         Heap-allocate remote_target/extended_remote_target instances.
1177         (vcont_builder::vcont_builder): Add remote_target parameter, and
1178         save it in m_remote.  All callers adjusted.
1179         (vcont_builder::m_remote): New field.
1180         (vcont_builder::restart, vcont_builder::flush)
1181         (vcont_builder::push_action): Use it.
1182         (remote_target::commit_resume): Use it.
1183         (struct queue_iter_param) <remote>: New field.
1184         (remote_target::remove_new_fork_children): Fill in 'remote' field.
1185         (check_pending_event_prevents_wildcard_vcont_callback_data): New.
1186         (check_pending_event_prevents_wildcard_vcont_callback)
1187         (remote_target::check_pending_events_prevent_wildcard_vcont)
1188         (remote_target::discard_pending_stop_replies)
1189         (remote_target::discard_pending_stop_replies_in_queue)
1190         (remote_target::remote_notif_remove_queued_reply): Fill in
1191         'remote' field.
1192         (remote_notif_get_pending_events): New.
1193         (remote_target::readchar, remote_target::remote_serial_write):
1194         Save/restore curr_quit_handler_target.
1195         (putpkt): New.
1196         (kill_new_fork_children): Fill in 'remote' field.
1197         (packet_command): Use get_current_remote_target, defer to
1198         remote_target method of same name.
1199         (scoped_remote_fd::scoped_remote_fd): Add 'remote_target'
1200         parameter, and save it in m_remote.  All callers adjusted.
1201         (scoped_remote_fd::release): Use m_remote.
1202         (scoped_remote_fd::m_remote): New field.
1203         (remote_file_put, remote_file_get, remote_file_delete): Use
1204         get_current_remote_target, defer to remote_target method of same
1205         name.
1206         (remote_btrace_reset): Add remote_state paremeter.  Update all
1207         callers.
1208         (remote_async_inferior_event_handler). Pass down 'data'.
1209         (remote_new_objfile): Use get_current_remote_target.
1210         (remote_target::vcont_r_supported): New.
1211         (set_range_stepping): Use get_current_remote_target and
1212         remote_target::vcont_r_supported.
1213         (_initialize_remote): Don't allocate 'remote_state' and
1214         'stop_reply_queue' globals.
1215         * remote.h (struct remote_target): Forward declare.
1216         (getpkt, putpkt, remote_notif_get_pending_events): Add
1217         'remote_target' parameter.
1218
1219 2018-05-22  Pedro Alves  <palves@redhat.com>
1220
1221         * remote.c (vcont_builder): Now a class.  Make all data members
1222         private.
1223         (vcont_builder) <vcont_builder, restart, flush, push_action>:
1224         Declare methods.
1225         (vcont_builder_restart): Rename to ...
1226         (vcont_builder::restart): ... this.
1227         (vcont_builder_flush): Rename to ...
1228         (vcont_builder::flush): ... this.
1229         (vcont_builder_push_action): Rename to ...
1230         (vcont_builder::push_action): ... this.
1231         (remote_target::commit_resume): Adjust.
1232
1233 2018-05-22  Pedro Alves  <palves@redhat.com>
1234
1235         * remote.c (DEFAULT_MAX_MEMORY_PACKET_SIZE): Rename to ...
1236         (DEFAULT_MAX_MEMORY_PACKET_SIZE_FIXED): ... this.
1237         (get_fixed_memory_packet_size): New.
1238         (get_memory_packet_size): Use it.
1239         (set_memory_packet_size): Don't override the config size with
1240         DEFAULT_MAX_MEMORY_PACKET_SIZE.
1241         (show_memory_packet_size): Use get_fixed_memory_packet_size.
1242         Don't refer to get_memory_packet_size if not connected to a remote
1243         target.  Show "(default)" if configured size is 0.
1244
1245 2018-05-22  Pedro Alves  <palves@redhat.com>
1246
1247         * remote.c (remote_target::mourn_inferior): Move
1248         discard_pending_stop_replies call here from ...
1249         (_initialize_remote): ... here.
1250
1251 2018-05-22  Pedro Alves  <palves@redhat.com>
1252
1253         * remote.c (compare_section_command): Remove set_general_process
1254         call.
1255
1256 2018-05-22  Pedro Alves  <palves@redhat.com>
1257
1258         * remote.c (struct packet_reg, struct remote_arch_state):
1259         Move higher up in the file.
1260         (remote_state) <m_arch_states>: Store remote_arch_state values
1261         instead of remote_arch_state pointers.
1262         (remote_state::get_remote_arch_state): Adjust.
1263
1264 2018-05-22  Pedro Alves  <palves@redhat.com>
1265
1266         * remote.c: Include <unordered_map>.
1267         (remote_state): Now a class.
1268         (remote_state) <get_remote_arch_state>: Declare method.
1269         <get_remote_arch_state>: New field.
1270         (remote_arch_state) <remote_arch_state>: Declare ctor.
1271         <regs>: Now a unique_ptr.
1272         (remote_gdbarch_data_handle): Delete.
1273         (get_remote_arch_state): Delete.
1274         (remote_state::get_remote_arch_state): New.
1275         (get_remote_state): Adjust to call remote_state's
1276         get_remote_arch_state method.
1277         (init_remote_state): Delete, bits factored out to ...
1278         (remote_arch_state::remote_arch_state): ... this new method.
1279         (get_remote_packet_size, get_memory_packet_size)
1280         (process_g_packet, remote_target::fetch_registers)
1281         (remote_target::prepare_to_store, store_registers_using_G)
1282         (remote_target::store_registers, remote_target::get_trace_status):
1283         Adjust to call remote_state's method.
1284         (_initialize_remote): Remove reference to
1285         remote_gdbarch_data_handle.
1286
1287 2018-05-22  Pedro Alves  <palves@redhat.com>
1288
1289         * remote.c (struct readahead_cache) <invalidate, invalidate_fd,
1290         pread>: New method declarations.
1291         (remote_target::open_1): Adjust.
1292         (readahead_cache_invalidate): Rename to ...
1293         (readahead_cache::invalidate): ... this, and adjust to be a class
1294         method.
1295         (readahead_cache_invalidate_fd): Rename to ...
1296         (readahead_cache::invalidate_fd): ... this, and adjust to be a
1297         class method.
1298         (remote_hostio_pwrite): Adjust.
1299         (remote_hostio_pread_from_cache): Rename to ...
1300         (readahead_cache::pread): ... this, and adjust to be a class
1301         method.
1302         (remote_hostio_close): Adjust.
1303
1304 2018-05-22  Pedro Alves  <palves@redhat.com>
1305
1306         * remote.c (remote_hostio_close_cleanup): Delete.
1307         (class scoped_remote_fd): New.
1308         (remote_file_put, remote_file_get): Use it.
1309
1310 2018-05-22  Pedro Alves  <palves@redhat.com>
1311
1312         (struct vCont_action_support): Use bool and initialize all fields.
1313         (struct readahead_cache): Initialize all fields.
1314         (remote_state): Use bool and initialize all fields.
1315         (remote_state::remote_state, remote_state::~remote_state): New.
1316         (new_remote_state): Delete.
1317         (_initialize_remote): Use new to allocate remote_state.
1318
1319 2018-05-22  Pedro Alves  <palves@redhat.com>
1320             張俊芝  <zjz@zjz.name>
1321
1322         PR gdb/22973
1323         * c-exp.y: Include "c-support.h".
1324         (parse_number, c_parse_escape, lex_one_token): Use TOLOWER instead
1325         of tolower.  Use c_ident_is_alpha to scan names.
1326         * c-lang.c: Include "c-support.h".
1327         (convert_ucn, convert_octal, convert_hex, convert_escape): Use
1328         ISXDIGIT instead of isxdigit and ISDIGIT instead of isdigit.
1329         * c-support.h: New file, with bits factored out from ...
1330         * cp-name-parser.y: ... this file.
1331         Include "c-support.h".
1332         (cp_ident_is_alpha, cp_ident_is_alnum): Deleted, moved to
1333         c-support.h and renamed.
1334         (symbol_end, yylex): Adjust.
1335
1336 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
1337
1338         * arch/ppc-linux-common.c (ppc_linux_has_isa205): Change the
1339         parameter type to CORE_ADDR.
1340         * arch/ppc-linux-common.h (ppc_linux_has_isa205): Change the
1341         parameter type in declaration to CORE_ADDR.
1342         * ppc-linux-tdep.c (ppc_linux_core_read_description): Call
1343         target_auxv_search to get AT_HWCAP and use the result to get the
1344         target description.
1345         * ppc-linux-nat.c (ppc_linux_get_hwcap): Change the return type
1346         to CORE_ADDR. Remove the cast of the return value to unsigned
1347         long. Fix error predicate of target_auxv_search.
1348         (ppc_linux_nat_target::read_description): Change the type of the
1349         hwcap variable to CORE_ADDR.
1350
1351 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
1352
1353         * rs6000-tdep.c (rs6000_gdbarch_init): Assign 1 to have_dfp only
1354         if the size of fpscr is larger than 32 bits.
1355
1356 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
1357
1358         * ppc-linux-tdep.c (ppc_linux_vsxregset): New function.
1359         (ppc32_linux_vsxregmap): New global.
1360         (ppc32_linux_vsxregset): Initialize with ppc32_linux_vsxregmap,
1361         regcache_supply_regset, and regcache_collect_regset.
1362         * ppc-linux-tdep.h (ppc_linux_vsxregset): Declare.
1363         * ppc-linux-nat.c (supply_vsxregset, fill_vsxregset): Remove.
1364         (fetch_vsx_register, store_vsx_register): Remove.
1365         (fetch_vsx_registers): Add regno parameter. Get regset using
1366         ppc_linux_vsxregset. Use regset to supply registers.
1367         (store_vsx_registers): Add regno parameter. Get regset using
1368         ppc_linux_vsxregset. Use regset to collect registers.
1369         (fetch_register): Call fetch_vsx_registers instead of
1370         fetch_vsx_register.
1371         (store_register): Call store_vsx_registers instead of
1372         store_vsx_register.
1373         (fetch_ppc_registers): Call fetch_vsx_registers with -1 for the
1374         new regno parameter.
1375         (store_ppc_registers): Call store_vsx_registers with -1 for the
1376         new regno parameter.
1377         * rs6000-tdep.c (ppc_vsx_support_p, ppc_supply_vsxreget)
1378         (ppc_collect_vsxregset): Remove.
1379
1380 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
1381
1382         * ppc-tdep.h (struct ppc_reg_offsets): Remove vector register
1383         offset fields.
1384         * ppc-fbsd-tdep.c (ppc32_fbsd_reg_offsets): Remove initializers
1385         for vector register offset fields.
1386         (ppc64_fbsd_reg_offsets): Likewise.
1387         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Remove assignment
1388         to vector register offset fields.
1389         * ppc-obsd-tdep.c (_initialize_ppcnbsd_tdep): Remove assignment
1390         to vector register offset fields.
1391         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Remove assignment to
1392         vector register offset fields.
1393         * rs6000-aix-tdep.c (rs6000_aix32_reg_offsets): Remove
1394         initializers for vector register offset fields.
1395         (rs6000_aix64_reg_offsets): Likewise.
1396         * rs6000-tdep.c (ppc_vrreg_offset): Remove.
1397         (ppc_supply_vrregset): Remove.
1398         (ppc_collect_vrregset): Remove.
1399         * ppc-linux-tdep.c (ppc_linux_collect_vrregset): New function.
1400         (ppc_linux_vrregset) : New function.
1401         (ppc32_le_linux_vrregmap, ppc32_be_linux_vrregmap)
1402         (ppc32_le_linux_vrregset, ppc32_be_linux_vrregset): New globals.
1403         (ppc32_linux_vrregset): Remove.
1404         (ppc_linux_iterate_over_regset_sections): Call ppc_linux_vrregset
1405         and use result instead of ppc32_linux_vrregset.
1406         (ppc32_linux_reg_offsets): Remove initializers for vector register
1407         offset fields.
1408         (ppc64_linux_reg_offsets): Likewise.
1409         * ppc-linux-tdep.h (ppc_linux_vrregset): New declaration.
1410         * ppc-linux-nat.c: Include regset.h.
1411         (gdb_vrregset_t): Adjust comment to account for little-endian
1412         mode.
1413         (supply_vrregset, fill_vrregset): Remove.
1414         (fetch_altivec_register, store_altivec_register): Remove.
1415         (fetch_altivec_registers): Add regno parameter. Get regset using
1416         ppc_linux_vrregset. Use regset to supply registers.
1417         (store_altivec_registers): Add regno parameter. Get regset using
1418         ppc_linux_vrregset. Use regset to collect registers.
1419         (fetch_register): Call fetch_altivec_registers instead of
1420         fetch_altivec_register.
1421         (store_register): Call store_altivec_registers instead of
1422         store_altivec_register.
1423         (fetch_ppc_registers): Call fetch_altivec_registers with -1 for
1424         the new regno parameter.
1425         (store_ppc_registers): Call store_altivec_registers with -1 for
1426         the new regno parameter.
1427
1428 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
1429
1430         * arch/ppc-linux-common.h (PPC_LINUX_SIZEOF_VRREGSET)
1431         (PPC_LINUX_SIZEOF_VSXREGSET): Define.
1432         * ppc-linux-nat.c (SIZEOF_VSXREGS, SIZEOF_VRREGS): Remove.
1433         (gdb_vrregset_t): Change array type size to
1434         PPC_LINUX_SIZEOF_VRREGSET.
1435         (gdb_vsxregset_t): Change array type size to
1436         PPC_LINUX_SIZEOF_VSXREGSET.
1437         * ppc-linux-tdep.c (ppc_linux_iterate_over_regset_sections):
1438         Change integer literals to PPC_LINUX_SIZEOF_VRREGSET and
1439         PPC_LINUX_SIZEOF_VSXREGSET.
1440
1441 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
1442
1443         * configure.nat <linux powerpc>: Add ppc-linux.o to NATDEPFILES.
1444         * ppc-linux-nat.c (ppc_linux_target_wordsize): Move to
1445         nat/ppc-linux.c.
1446         (ppc_linux_nat_target::auxv_parse): Get thread id tid. Call
1447         ppc_linux_target_wordsize with tid.
1448         (ppc_linux_nat_target::read_description): Call ppc_linux_target
1449         wordsize with tid.
1450         * nat/ppc-linux.c: Include nat/gdb_ptrace.h.
1451         (ppc64_64bit_inferior_p): Add static and inline specifiers.
1452         (ppc_linux_target_wordsize): Move here from ppc-linux-nat.c. Add
1453         tid parameter. Remove static specifier.
1454         * nat/ppc-linux.h (ppc64_64bit_inferior_p): Remove declaration.
1455         (ppc_linux_target_wordsize): New declaration.
1456
1457 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
1458
1459         * arch/ppc-linux-common.c: New file.
1460         * arch/ppc-linux-common.h: New file.
1461         * arch/ppc-linux-tdesc.h: New file.
1462         * configure.tgt (powerpc*-*-linux*): Add arch/ppc-linux-common.o.
1463         * Makefile.in (ALL_TARGET_OBS): Add arch/ppc-linux-common.o.
1464         (HFILES_NO_SRCDIR): Add arch/ppc-linux-common.h and
1465         arch/ppc-linux-tdesc.h.
1466         * ppc-linux-nat.c: Include arch/ppc-linux-common.h and
1467         arch/ppc-linux-tdesc.h.
1468         (ppc_linux_nat_target::read_description): Remove target
1469         description matching code. Fill a ppc_linux_features struct and
1470         call ppc_linux_match_description with it. Move comment about ISA
1471         2.05 to ppc-linux-common.c.
1472         * ppc-linux-tdep.c: Include arch/ppc-linux-common.h and
1473         arch/ppc-linux-tdesc.h.
1474         (ppc_linux_core_read_description): Remove target description
1475         matching code. Fill a ppc_linux_features struct and call
1476         ppc_linux_match_description with it.
1477         * ppc-linux-tdep.h (tdesc_powerpc_32l, tdesc_powerpc_64l)
1478         (tdesc_powerpc_altivec32l, tdesc_powerpc_altivec64l)
1479         (tdesc_powerpc_cell32l, tdesc_powerpc_cell64l)
1480         (tdesc_powerpc_vsx32l, tdesc_powerpc_vsx64l)
1481         (tdesc_powerpc_isa205_32l, tdesc_powerpc_isa205_64l)
1482         (tdesc_powerpc_isa205_altivec32l, tdesc_powerpc_isa205_altivec64l)
1483         (tdesc_powerpc_isa205_vsx32l, tdesc_powerpc_isa205_vsx64l)
1484         (tdesc_powerpc_e500l): Remove.
1485
1486 2018-05-22  Joel Brobecker  <brobecker@adacore.com>
1487
1488         * ada-lang.c (catch_assert_command): Pass empty string instead
1489         of NULL for excep_string argument.
1490
1491 2018-05-22  Maciej W. Rozycki  <macro@mips.com>
1492
1493         * mips-linux-nat.c (mips64_linux_register_addr): Return -1 if
1494         the width of the requested register exceeds the width of the
1495         `ptrace' data type.
1496
1497 2018-05-21  Tom Tromey  <tom@tromey.com>
1498
1499         * printcmd.c (output_command): Remove.
1500         (output_command_const): Rename to output_command.
1501         * valprint.h (output_command): Rename from output_command_const.
1502         * tracepoint.c (trace_dump_actions): Call output_command.
1503
1504 2018-05-21  Tom Tromey  <tom@tromey.com>
1505
1506         * mi/mi-cmd-catch.c (mi_cmd_catch_assert)
1507         (mi_cmd_catch_exception, mi_cmd_catch_handlers): Update.
1508         * ada-lang.h (create_ada_exception_catchpoint): Update.
1509         * ada-lang.c (struct ada_catchpoint) <excep_string>: Now a
1510         std::string.
1511         (create_excep_cond_exprs, ~ada_catchpoint)
1512         (should_stop_exception, print_one_exception)
1513         (print_mention_exception, print_recreate_exception): Update.
1514         (ada_get_next_arg): Remove.
1515         (catch_ada_exception_command_split): Use std::string.  Change type
1516         of "excep_string", "cond_string".
1517         (catch_ada_exception_command): Update.
1518         (create_ada_exception_catchpoint): Change type of excep_string.
1519         (ada_exception_sal): Remove excep_string parameter.
1520         (~ada_catchpoint): Remove.
1521
1522 2018-05-21  Tom Tromey  <tom@tromey.com>
1523
1524         * ada-lang.c (ada_collect_symbol_completion_matches): Remove
1525         cleanup.
1526
1527 2018-05-21  Tom Tromey  <tom@tromey.com>
1528
1529         * ada-lang.c (ada_exception_message_1, ada_exception_message):
1530         Return unique_xmalloc_ptr.
1531         (print_it_exception): Update.
1532
1533 2018-05-21  Tom Tromey  <tom@tromey.com>
1534
1535         * tracepoint.c (trace_dump_actions): Use std::string.
1536
1537 2018-05-21  Tom Tromey  <tom@tromey.com>
1538
1539         * symfile.c (reread_symbols): Use std::string for original_name.
1540
1541 2018-05-21  Tom Tromey  <tom@tromey.com>
1542
1543         * dwarf2read.c (dwarf2_read_debug_names): Use std::unique_ptr.
1544         (mapped_index_base): Use DISABLE_COPY_AND_ASSIGN.  Default
1545         constructor.
1546
1547 2018-05-20  Simon Marchi  <simon.marchi@polymtl.ca>
1548
1549         * common/traits.h (HAVE_IS_TRIVIALLY_COPYABLE): Rename the wrong
1550         instance to...
1551         (HAVE_IS_TRIVIALLY_CONSTRUCTIBLE): ... this.
1552         * objfiles.c (get_objfile_bfd_data): Allocate
1553         objfile_per_bfd_storage with obstack_new when allocating on
1554         obstack.
1555
1556 2018-05-20  Simon Marchi  <simon.marchi@ericsson.com>
1557
1558         * ada-lang.c (cache_symbol): Use XOBNEW and/or XOBNEWVEC and/or
1559         OBSTACK_ZALLOC.
1560         * dwarf2-frame.c (dwarf2_build_frame_info): Likewise.
1561         * hppa-tdep.c (hppa_init_objfile_priv_data): Likewise.
1562         * mdebugread.c (mdebug_build_psymtabs): Likewise.
1563         (add_pending): Likewise.
1564         (parse_symbol): Likewise.
1565         (parse_partial_symbols): Likewise.
1566         (psymtab_to_symtab_1): Likewise.
1567         (new_psymtab): Likewise.
1568         (elfmdebug_build_psymtabs): Likewise.
1569         * minsyms.c (terminate_minimal_symbol_table): Likewise.
1570         * objfiles.c (get_objfile_bfd_data): Likewise.
1571         (objfile_register_static_link): Likewise.
1572         * psymtab.c (allocate_psymtab): Likewise.
1573         * stabsread.c (read_member_functions): Likewise.
1574         * xcoffread.c (xcoff_end_psymtab): Likewise.
1575
1576 2018-05-20  Simon Marchi  <simon.marchi@ericsson.com>
1577
1578         * common/traits.h (HAVE_IS_TRIVIALLY_COPYABLE): Define if
1579         compiler supports std::is_trivially_constructible.
1580         * common/poison.h: Include obstack.h.
1581         (IsMallocable): Define to is_trivially_constructible if the
1582         compiler supports it, define to true_type otherwise.
1583         (xobnew): New.
1584         (XOBNEW): Redefine.
1585         (xobnewvec): New.
1586         (XOBNEWVEC): Redefine.
1587         * gdb_obstack.h (obstack_zalloc): New.
1588         (OBSTACK_ZALLOC): Redefine.
1589         (obstack_calloc): New.
1590         (OBSTACK_CALLOC): Redefine.
1591         (obstack_new): New.
1592         * gdbarch.sh: Include gdb_obstack in gdbarch.h.
1593         (gdbarch_obstack): New declaration in gdbarch.h, definition in
1594         gdbarch.c.
1595         (GDBARCH_OBSTACK_CALLOC, GDBARCH_OBSTACK_ZALLOC): Use
1596         obstack_calloc/obstack_zalloc.
1597         (gdbarch_obstack_zalloc): Remove.
1598         * target-descriptions.c (tdesc_data_init): Use obstack_new.
1599
1600 2018-05-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1601
1602         * stack.c (backtrace_command_1): Remove useless variable int i.
1603
1604 2018-05-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1605
1606         * stack.c (print_frame_info): Fix comment.
1607
1608 2018-05-18  Tom Tromey  <tom@tromey.com>
1609
1610         * dwarf2read.c (struct dwz_file): Add constructor, initializers.
1611         <dwz_bfd>: Now a gdb_bfd_ref_ptr.
1612         (~dwarf2_per_objfile): Update
1613         (dwarf2_get_dwz_file): Use new.
1614         * dwarf2read.h (struct dwarf2_per_objfile) <dwz_file>: Now a
1615         unique_ptr.
1616
1617 2018-05-18  Tom Tromey  <tom@tromey.com>
1618
1619         * dwarf2read.h (struct dwarf2_per_objfile) <dwp_file>: Now a
1620         unique_ptr.
1621         * dwarf2read.c (struct dwp_file): Add constructor and
1622         initializers.
1623         (open_and_init_dwp_file): Return a unique_ptr.
1624         (dwarf2_per_objfile, create_dwp_hash_table)
1625         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2)
1626         (lookup_dwo_unit_in_dwp): Update.
1627         (open_and_init_dwp_file, get_dwp_file): Update.
1628
1629 2018-05-18  Tom Tromey  <tom@tromey.com>
1630
1631         * dwarf2read.c (dwarf2_per_objfile): Update.
1632         (struct mapped_index): Add initializers.
1633         (dwarf2_read_index): Use new.
1634         (dw2_symtab_iter_init): Update.
1635         * dwarf2read.h (struct dwarf2_per_objfile) <index_table>: Now a
1636         unique_ptr.
1637
1638 2018-05-18  Simon Marchi  <simon.marchi@ericsson.com>
1639
1640         * dwarf2read.c (mapped_index) <total_size>: Remove.
1641
1642 2018-05-18  Simon Marchi  <simon.marchi@ericsson.com>
1643
1644         * unittests/format_pieces-selftests.c (test_format_specifier):
1645         Add ARI comments.
1646
1647 2018-05-18  Tom Tromey  <tom@tromey.com>
1648
1649         * c-typeprint.c (maybe_print_hole): New function.
1650         (c_print_type_struct_field_offset): Update.
1651         (c_type_print_base_struct_union): Call maybe_print_hole.
1652
1653 2018-05-17  Keith Seitz  <keiths@redhat.com>
1654
1655         * breakpoint.c (build_bpstat_chain): New function, moved from
1656         bpstat_stop_status.
1657         (bpstat_stop_status): Add optional parameter, `stop_chain'.
1658         If no stop chain is passed, call build_bpstat_chain to build it.
1659         * breakpoint.h (build_bpstat_chain): Declare.
1660         (bpstat_stop_status): Move documentation here from breakpoint.c.
1661         * infrun.c (handle_signal_stop): Before eliding inlined frames,
1662         build the stop chain and pass it to skip_inline_frames.
1663         Pass this stop chain to bpstat_stop_status.
1664         * inline-frame.c: Include breakpoint.h.
1665         (stopped_by_user_bp_inline_frame): New function.
1666         (skip_inline_frames): Add parameter `stop_chain'.
1667         Move documention to inline-frame.h.
1668         If non-NULL, use stopped_by_user_bp_inline_frame to determine
1669         whether the frame should be elided.
1670         * inline-frame.h (skip_inline_frames): Add parameter `stop_chain'.
1671         Add moved documentation and update for new parameter.
1672
1673 2018-05-17  Simon Marchi  <simon.marchi@ericsson.com>
1674
1675         PR cli/14975
1676         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1677         unittests/format_pieces-selftests.c.
1678         * common/format.h (format_piece) <operator==>: New.
1679         (format_pieces) <operator[]>: Remove.
1680         * common/format.c (format_pieces::format_pieces): Handle \e.
1681         * unittests/format_pieces-selftests.c: New.
1682
1683 2018-05-17  Tom Tromey  <tom@tromey.com>
1684
1685         PR symtab/23010:
1686         * dwarf2read.c (load_cu, dw2_do_instantiate_symtab)
1687         (dw2_instantiate_symtab): Add skip_partial parameter.
1688         (dw2_find_last_source_symtab, dw2_map_expand_apply)
1689         (dw2_lookup_symbol, dw2_expand_symtabs_for_function)
1690         (dw2_expand_all_symtabs, dw2_expand_symtabs_with_fullname)
1691         (dw2_expand_symtabs_matching_one)
1692         (dw2_find_pc_sect_compunit_symtab)
1693         (dw2_debug_names_lookup_symbol)
1694         (dw2_debug_names_expand_symtabs_for_function): Update.
1695         (init_cutu_and_read_dies): Add skip_partial parameter.
1696         (process_psymtab_comp_unit, build_type_psymtabs_1)
1697         (process_skeletonless_type_unit, load_partial_comp_unit)
1698         (psymtab_to_symtab_1): Update.
1699         (load_full_comp_unit): Add skip_partial parameter.
1700         (process_imported_unit_die, dwarf2_read_addr_index)
1701         (follow_die_offset, dwarf2_fetch_die_loc_sect_off)
1702         (dwarf2_fetch_constant_bytes, dwarf2_fetch_die_type_sect_off)
1703         (read_signatured_type): Update.
1704
1705 2018-05-17  Simon Marchi  <simon.marchi@ericsson.com>
1706
1707         * value.c (release_value): Remove unused variable.
1708         (record_latest_value): Likewise.
1709         (access_value_history): Likewise.
1710         (preserve_values): Likewise.
1711
1712 2018-05-17  Tom Tromey  <tom@tromey.com>
1713
1714         * extension.h (struct ext_lang_type_printers) <py_type_printers>:
1715         Initialize.
1716
1717 2018-05-16  Maciej W. Rozycki  <macro@mips.com>
1718
1719         PR gdb/22286
1720         * linux-nat-trad.c (linux_nat_trad_target::fetch_register):
1721         Also handle registers whose width is not a multiple of
1722         PTRACE_TYPE_RET.
1723         (linux_nat_trad_target::store_register): Likewise.
1724
1725 2018-05-16  Tom Tromey  <tom@tromey.com>
1726
1727         * gdbcore.h (core_bfd): Redefine.
1728         * corelow.c (core_target::close): Update.
1729         (core_target_open): Update.
1730         * progspace.h (struct program_space) <cbfd>: Now a
1731         gdb_bfd_ref_ptr.
1732
1733 2018-05-16  Tom Tromey  <tom@tromey.com>
1734
1735         PR cli/19551:
1736         * symfile-add-flags.h (enum symfile_add_flags)
1737         <SYMFILE_NOT_FILENAME>: New constant.
1738         * symfile.c (read_symbols): Use SYMFILE_NOT_FILENAME.  Get
1739         objfile name from BFD.
1740         (symbol_file_add_with_addrs): Check SYMFILE_NOT_FILENAME.
1741         * minidebug.c (find_separate_debug_file_in_section): Put
1742         ".gnu_debugdata" into BFD's file name.
1743
1744 2018-05-16  Simon Marchi  <simon.marchi@ericsson.com>
1745
1746         * regcache.c (regcache_read_ftype, regcache_write_ftype):
1747         Remove.
1748
1749 2018-05-15  Tamar Christina  <tamar.christina@arm.com>
1750
1751         PR binutils/21446
1752         * aarch64-tdep.c (aarch64_analyze_prologue,
1753         aarch64_software_single_step, aarch64_displaced_step_copy_insn):
1754         Indicate not interested in errors.
1755
1756 2018-05-15  Maciej W. Rozycki  <macro@mips.com>
1757
1758         * mips-linux-nat.c (mips_linux_nat_target::fetch_registers):
1759         Supply the MIPS_ZERO_REGNUM register.
1760
1761 2018-05-15  Maciej W. Rozycki  <macro@mips.com>
1762
1763         * mips-tdep.c (mask_address_var): Make variable static.
1764
1765 2018-05-14  Tom Tromey  <tom@tromey.com>
1766
1767         * dwarf2read.c (rust_union_quirks): Clear rust_unions.
1768
1769 2018-05-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1770
1771         * i387-tdep.c (i387_collect_xsave): Use FXSAVE_MXCSR_ADDR not
1772         FXSAVE_ADDR for the mxcsr register.
1773
1774 2018-05-11  Max Filippov  <jcmvbkbc@gmail.com>
1775
1776         * configure.tgt (xtensa*-*-linux*): Drop gdb_target definition.
1777
1778 2018-05-11  Pedro Alves  <palves@redhat.com>
1779
1780         * corelow.c (core_target) <core_target>: No longer inline.
1781         Initialize m_core_gdbarch, m_core_vec and build the section table
1782         here.
1783         <~core_target>: New.
1784         <core_gdbarch, get_core_register_section>: New methods.
1785         <m_core_section_table, m_core_vec, m_core_gdbarch>: New fields,
1786         factored out from ...
1787         <core_data, core_vec, core_gdbarch>: ... these deleted globals.
1788         (core_ops): Delete.
1789         (sniff_core_bfd): Add gdbarch parameter.
1790         (core_close): Delete, merged into ...
1791         (core_target::close): ... here.  Delete self.
1792         (core_close_cleanup): Delete.
1793         (core_target_open): Allocate a core_target on the heap.  Use a
1794         unique_ptr instead of a cleanup.  Bits moved into the core_target
1795         ctor.  Adjust to use core_target methods instead of globals.
1796         (get_core_register_section): Rename to ...
1797         (core_target::get_core_register_section): ... this and adjust.
1798         (struct get_core_registers_cb_data): New.
1799         (get_core_registers_cb): Use it.  Use bool.
1800         (core_target::fetch_registers, core_target::files_info)
1801         (core_target::xfer_partial, core_target::read_description)
1802         (core_target::pid_to, core_target::thread_name): Adjust to
1803         reference class fields instead of globals.
1804         * target.h (struct target_ops_deleter, target_ops_up): New.
1805
1806 2018-05-11  Pedro Alves  <palves@redhat.com>
1807
1808         * corefile.c (core_file_command): Move to corelow.c.
1809         * corelow.c (the_core_target): Delete.
1810         (core_file_command): Moved from corefile.c.  Check exec_bfd
1811         instead of the_core_target.  Use target_detach instead of calling
1812         into the_core_target directly.
1813         (maybe_say_no_core_file_now): New.
1814         (core_target::detach): Use it.
1815         (_initialize_corelow): Remove references to the_core_target.
1816         * gdbcore.h (the_core_target): Delete.
1817
1818 2018-05-11  Tom Tromey  <tromey@redhat.com>
1819             Pedro Alves  <palves@redhat.com>
1820
1821         * corefile.c (core_bfd): Remove.
1822         * gdbcore.h (core_bfd): Now a macro.
1823         * progspace.h (struct program_space) <cbfd>: New field.
1824
1825 2018-05-11  Tom Tromey  <tom@tromey.com>
1826
1827         * mdebugread.c (parse_partial_symbols, psymtab_to_symtab_1): Use
1828         gdb::def_vector.
1829
1830 2018-05-10  Tom Tromey  <tom@tromey.com>
1831
1832         * configure: Rebuild.
1833         * warning.m4 (AM_GDB_WARNINGS): Use -Wimplicit-fallthrough=3.
1834
1835 2018-05-10  Joel Brobecker  <brobecker@adacore.com>
1836
1837         PR server/23158:
1838         * regformats/regdat.sh: Adjust script, following the addition
1839         of the new expedite_regs parameter to init_target_desc.
1840
1841 2018-05-10  Omair Javaid  <omair.javaid@linaro.org>
1842     
1843         PR gdb/23127
1844         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Add call to
1845         set_gdbarch_significant_addr_bit.
1846         * aarch64-tdep.c (aarch64_gdbarch_init): Remove call to
1847         set_gdbarch_significant_addr_bit.
1848         * utils.c (address_significant): Update to sign extend addr.
1849
1850 2018-05-09  Max Filippov  <jcmvbkbc@gmail.com>
1851
1852         * xtensa-linux-tdep.c (xtensa-tdep.h): New include.
1853         (xtensa_linux_init_abi): Limit tdep->num_regs by
1854         tdep->num_nopriv_regs.
1855         * xtensa-tdep.c (xtensa_derive_tdep): Calculate
1856         tdep->num_nopriv_regs and only copy it to tdep->num_regs if it's
1857         not initialized.
1858
1859 2018-05-08  Simon Marchi  <simon.marchi@ericsson.com>
1860
1861         * unittests/string_view-selftests.c: Define GNULIB_NAMESPACE.
1862
1863 2018-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1864
1865         * common/x86-xstate.h (I387_FCTRL_INIT_VAL): New constant.
1866         (I387_MXCSR_INIT_VAL): New constant.
1867         * amd64-tdep.c (amd64_supply_xsave): Only read state from xsave
1868         buffer if it was supplied by the inferior.
1869         * i387-tdep.c (i387_supply_fsave): Use I387_MXCSR_INIT_VAL.
1870         (i387_xsave_get_clear_bv): New function.
1871         (i387_supply_xsave): Only read x87 control registers from the
1872         xsave buffer if the feature is enabled, and the state will have
1873         been written, otherwise, provide a suitable default.
1874         (i387_collect_xsave): Pre-clear all registers in xsave buffer,
1875         including x87 control registers.  Update control registers if they
1876         have changed from the default value, and mark features as enabled
1877         as required.
1878         * i387-tdep.h (i387_xsave_get_clear_bv): Declare.
1879
1880 2018-05-08  Ulrich Weigand  <uweigand@de.ibm.com>
1881
1882         * spu-tdep.c (info_spu_event_command): Fix output formatting.
1883
1884 2018-05-07  Tom Tromey  <tom@tromey.com>
1885
1886         * configure: Rebuild.
1887         * warning.m4 (AM_GDB_WARNINGS): Add -Wduplicated-cond.
1888
1889 2018-05-07  Tom Tromey  <tom@tromey.com>
1890
1891         PR tdep/20362:
1892         * arm-tdep.c (arm_record_vfp_data_proc_insn): Properly mask off D
1893         bit.  Use correct value for VDIV.
1894
1895 2018-05-04  Tom Tromey  <tom@tromey.com>
1896
1897         * configure: Rebuild.
1898         * warning.m4 (AM_GDB_WARNINGS): Add -Wimplicit-fallthrough.
1899
1900 2018-05-04  Tom Tromey  <tom@tromey.com>
1901
1902         * linux-record.c (record_linux_system_call) <case
1903         RECORD_SYS_RECVFROM>: Add "break".
1904
1905 2018-05-04  Tom Tromey  <tom@tromey.com>
1906
1907         * mi/mi-main.c (mi_cmd_trace_frame_collected) <REGISTERS_FORMAT>:
1908         Add missing "break".
1909         * mi/mi-cmd-stack.c (mi_cmd_stack_list_locals) <NO_FRAME_FILTERS>:
1910         Add missing "break".
1911
1912 2018-05-04  Tom Tromey  <tom@tromey.com>
1913
1914         * rs6000-tdep.c (ppc_process_record_op4)
1915         (ppc_process_record_op63): Add fall-through comment.
1916
1917 2018-05-04  Tom Tromey  <tom@tromey.com>
1918
1919         * i386-tdep.c (i386_process_record): Add fall-through comment.
1920
1921 2018-05-04  Tom Tromey  <tom@tromey.com>
1922
1923         * stabsread.c (define_symbol) <case 'p'>: Add fall-through
1924         comment.
1925
1926 2018-05-04  Tom Tromey  <tom@tromey.com>
1927
1928         * riscv-tdep.c (riscv_isa_xlen): Add fall-through comment.
1929         * utils.c (can_dump_core) <LIMIT_CUR>: Add fall-through comment.
1930         * eval.c (fetch_subexp_value) <MEMORY_ERROR>: Add fall-through
1931         comment.
1932         * d-valprint.c (d_val_print) <TYPE_CODE_STRUCT>: Add fall-through
1933         comment.
1934         * coffread.c (coff_symtab_read) <C_LABEL>: Add fall-through
1935         comment.
1936
1937 2018-05-04  Tom Tromey  <tom@tromey.com>
1938
1939         * dwarf2loc.c (unimplemented): Add ATTRIBUTE_NORETURN.
1940
1941 2018-05-04  Tom Tromey  <tom@tromey.com>
1942
1943         * s390-tdep.c (s390_process_record): Fix fall-through comments.
1944         * xcoffread.c (scan_xcoff_symtab): Move comment later.
1945         * symfile.c (section_is_mapped): Fix fall-through comment.
1946         * stabsread.c (define_symbol, read_member_functions): Fix
1947         fall-through comment.
1948         * s390-linux-tdep.c (s390_process_record): Fix fall-through
1949         comment.
1950         * remote.c (remote_wait_as): Fix fall-through comment.
1951         * p-exp.y (yylex): Fix fall-through comment.
1952         * nat/x86-dregs.c (x86_length_and_rw_bits): Fix fall-through
1953         comment.
1954         * msp430-tdep.c (msp430_gdbarch_init): Fix fall-through comment.
1955         * mdebugread.c (parse_partial_symbols): Fix fall-through comment.
1956         * jv-exp.y (yylex): Fix fall-through comment.
1957         * go-exp.y (lex_one_token): Fix fall-through comment.
1958         * gdbtypes.c (get_discrete_bounds, rank_one_type): Fix
1959         fall-through comment.
1960         * f-exp.y (yylex): Fix fall-through comment.
1961         * dwarf2read.c (process_die): Fix fall-through comments.
1962         * dbxread.c (process_one_symbol): Fix fall-through comment.
1963         * d-exp.y (lex_one_token): Fix fall-through comment.
1964         * cp-name-parser.y (yylex): Fix fall-through comment.
1965         * coffread.c (coff_symtab_read): Fix fall-through comment.
1966         * c-exp.y (lex_one_token): Fix fall-through comment.
1967         * arm-tdep.c (arm_decode_miscellaneous): Fix fall-through
1968         comment.
1969         * arch/arm.c (arm_instruction_changes_pc): Fix fall-through
1970         comment.
1971
1972 2018-05-04  Tom Tromey  <tom@tromey.com>
1973
1974         PR python/22730:
1975         * NEWS: Mention gdb.execute change.
1976         * gdbcmd.h (execute_control_command): Don't declare.
1977         * python/python.c (execute_gdb_command): Use read_command_lines_1,
1978         execute_control_commands, execute_control_commands_to_string.
1979         * cli/cli-script.h (execute_control_commands)
1980         (execute_control_commands_to_string): Declare.
1981         (execute_control_command): Add from_tty parameter.
1982         * cli/cli-script.c (execute_control_commands)
1983         (execute_control_commands_to_string): New functions.
1984         (execute_user_command): Use execute_control_commands.
1985         (execute_control_command_1): Add "from_tty" parameter.  Update.
1986         (execute_control_command): Likewise.
1987
1988 2018-05-04  Tom Tromey  <tom@tromey.com>
1989
1990         PR python/22731:
1991         * NEWS: Mention that breakpoint commands are writable.
1992         * python/py-breakpoint.c (bppy_set_commands): New function.
1993         (breakpoint_object_getset) <"commands">: Use it.
1994
1995 2018-05-04  Tom Tromey  <tom@tromey.com>
1996
1997         * tracepoint.c (actions_command): Update.
1998         * mi/mi-cmd-break.c (mi_command_line_array)
1999         (mi_command_line_array_cnt, mi_command_line_array_ptr)
2000         (mi_read_next_line): Remove.
2001         (mi_cmd_break_commands): Update.
2002         * cli/cli-script.h (read_command_lines, read_command_lines_1): Use
2003         function_view.
2004         * cli/cli-script.c (get_command_line): Update.
2005         (process_next_line): Use function_view.  Constify.
2006         (recurse_read_control_structure, read_command_lines)
2007         (read_command_lines_1): Change argument types to function_view.
2008         (do_define_command, document_command): Update.
2009         * breakpoint.h (check_tracepoint_command): Don't declare.
2010         * breakpoint.c (check_tracepoint_command): Remove.
2011         (commands_command_1, create_tracepoint_from_upload): Update.
2012
2013 2018-05-04  Tom Tromey  <tom@tromey.com>
2014
2015         PR gdb/11750:
2016         * cli/cli-script.h (enum command_control_type) <define_control>:
2017         New constant.
2018         * cli/cli-script.c (multi_line_command_p): Handle define_control.
2019         (build_command_line, execute_control_command_1)
2020         (process_next_line): Likewise.
2021         (do_define_command): New function, extracted from define_command.
2022         (define_command): Use it.
2023
2024 2018-05-04  Tom Tromey  <tom@tromey.com>
2025
2026         * tracepoint.c (actions_command): Update.
2027         * cli/cli-script.h (read_command_lines): Update.
2028         * cli/cli-script.c (read_command_lines): Constify prompt_arg.
2029         (MAX_TMPBUF): Remove define.
2030         (define_command): Use string_printf.
2031         (document_command): Likewise.
2032         * breakpoint.c (commands_command_1): Update.
2033
2034 2018-05-04  Tom Tromey  <tom@tromey.com>
2035
2036         * top.c (execute_command): Update.
2037         * cli/cli-script.h (print_command_lines): Now varargs.
2038         * cli/cli-script.c (print_command_lines): Now varargs.
2039         (execute_control_command_1) <case while_control, case if_control>:
2040         Update.
2041
2042 2018-05-04  Tom Tromey  <tom@tromey.com>
2043
2044         * tracepoint.c (all_tracepoint_actions): Rename from
2045         all_tracepoint_actions_and_cleanup.  Change return type.
2046         (actions_command, encode_actions_1, encode_actions)
2047         (trace_dump_actions, tdump_command): Update.
2048         * remote.c (remote_download_command_source): Update.
2049         * python/python.c (gdbpy_eval_from_control_command)
2050         (python_command, python_interactive_command): Update.
2051         * mi/mi-cmd-break.c (mi_cmd_break_commands): Update.
2052         * guile/guile.c (guile_command)
2053         (gdbscm_eval_from_control_command, guile_command): Update.
2054         * compile/compile.c (compile_code_command)
2055         (compile_print_command, compile_to_object): Update.
2056         * cli/cli-script.h (struct command_lines_deleter): New.
2057         (counted_command_line): New typedef.
2058         (struct command_line): Add constructor, destructor.
2059         <body_list>: Remove.
2060         <body_list_0, body_list_1>: New members.
2061         (command_line_up): Remove typedef.
2062         (read_command_lines, read_command_lines_1, get_command_line):
2063         Update.
2064         (copy_command_lines): Don't declare.
2065         * cli/cli-script.c (build_command_line): Use "new".
2066         (get_command_line): Return counted_command_line.
2067         (print_command_lines, execute_user_command)
2068         (execute_control_command_1, while_command, if_command): Update.
2069         (realloc_body_list): Remove.
2070         (process_next_line, recurse_read_control_structure): Update.
2071         (read_command_lines, read_command_lines_1): Return counted_command_line.
2072         (free_command_lines): Use "delete".
2073         (copy_command_lines): Remove.
2074         (define_command, document_command, show_user_1): Update.
2075         * cli/cli-decode.h (struct cmd_list_element) <user_commands>: Now
2076         a counted_command_line.
2077         * breakpoint.h (counted_command_line): Remove typedef.
2078         (breakpoint_set_commands): Update.
2079         * breakpoint.c (check_no_tracepoint_commands)
2080         (validate_commands_for_breakpoint): Update.
2081         (breakpoint_set_commands): Change commands to be a
2082         counted_command_line.
2083         (commands_command_1, update_dprintf_command_list)
2084         (create_tracepoint_from_upload): Update.
2085
2086 2018-05-04  Tom Tromey  <tom@tromey.com>
2087
2088         * cli/cli-decode.h (cmd_list_element): New constructor.
2089         (~cmd_list_element): New destructor.
2090         (struct cmd_list_element): Add initializers.
2091         * cli/cli-decode.c (do_add_cmd): Use "new".
2092         (delete_cmd): Use "delete".
2093
2094 2018-05-04  Jan Kratochvil  <jan.kratochvil@redhat.com>
2095             Pedro Alves <palves@redhat.com>
2096
2097         PR breakpoints/19806 and support for PR external/20207.
2098         * NEWS: Mention Aarch64 watchpoint improvements.
2099         * aarch64-linux-nat.c (aarch64_linux_stopped_data_address): Fix missed
2100         watchpoints and PR external/20207 watchpoints.
2101         * nat/aarch64-linux-hw-point.c
2102         (kernel_supports_any_contiguous_range): New.
2103         (aarch64_watchpoint_offset): New.
2104         (aarch64_watchpoint_length): Support PR external/20207 watchpoints.
2105         (aarch64_point_encode_ctrl_reg): New parameter offset, new asserts.
2106         (aarch64_point_is_aligned): Support PR external/20207 watchpoints.
2107         (aarch64_align_watchpoint): New parameters aligned_offset_p and
2108         next_addr_orig_p.  Support PR external/20207 watchpoints.
2109         (aarch64_downgrade_regs): New.
2110         (aarch64_dr_state_insert_one_point): New parameters offset and
2111         addr_orig.
2112         (aarch64_dr_state_remove_one_point): Likewise.
2113         (aarch64_handle_breakpoint): Update caller.
2114         (aarch64_handle_aligned_watchpoint): Likewise.
2115         (aarch64_handle_unaligned_watchpoint): Support addr_orig and
2116         aligned_offset.
2117         (aarch64_linux_set_debug_regs): Remove const from state.  Call
2118         aarch64_downgrade_regs.
2119         (aarch64_show_debug_reg_state): Print also dr_addr_orig_wp.
2120         * nat/aarch64-linux-hw-point.h (DR_CONTROL_LENGTH): Rename to ...
2121         (DR_CONTROL_MASK): ... this.
2122         (struct aarch64_debug_reg_state): New field dr_addr_orig_wp.
2123         (unsigned int aarch64_watchpoint_offset): New prototype.
2124         (aarch64_linux_set_debug_regs): Remove const from state.
2125         * utils.c (align_up, align_down): Move to ...
2126         * common/common-utils.c (align_up, align_down): ... here.
2127         * utils.h (align_up, align_down): Move to ...
2128         * common/common-utils.h (align_up, align_down): ... here.
2129
2130 2018-05-04  Joel Brobecker  <brobecker@adacore.com>
2131
2132         * sparc-tdep.c (sparc_structure_return_p): Re-implement to
2133         match the ABI as summarized in GCC's gcc/config/sparc/sparc.c.
2134         (sparc_arg_by_memory_p): Renamed from sparc_arg_on_registers_p.
2135         Re-implement to match the ABI as summarized in GCC's
2136         gcc/config/sparc/sparc.c.  All callers updated.
2137         (sparc32_store_arguments): Remove assertion.
2138
2139 2018-05-04  Tom Tromey  <tom@tromey.com>
2140
2141         * printcmd.c: Don't include tui.h.
2142         (decode_format): Use skip_spaces.
2143
2144 2018-05-04  Tom Tromey  <tom@tromey.com>
2145
2146         PR gdb/22619:
2147         * printcmd.c (last_count): New global.
2148         (x_command): Use saved count when repeating.
2149
2150 2018-05-04  Tom Tromey  <tom@tromey.com>
2151
2152         * nto-procfs.c (do_closedir_cleanup): Remove.
2153         (procfs_pidlist): Use gdb_dir_up.
2154         * procfs.c (do_closedir_cleanup): Remove.
2155         (proc_update_threads): Use gdb_dir_up.
2156         * common/filestuff.h (struct gdb_dir_deleter): New.
2157         (gdb_dir_up): New typedef.
2158
2159 2018-05-04  Tom Tromey  <tom@tromey.com>
2160
2161         * ada-lang.c (print_mention_exception): Use std::string.
2162
2163 2018-05-04  Tom Tromey  <tom@tromey.com>
2164
2165         * ada-lang.c (create_excep_cond_exprs): Update.
2166         (ada_exception_catchpoint_cond_string): Use std::string.
2167
2168 2018-05-04  Tom Tromey  <tom@tromey.com>
2169
2170         * ada-lang.c (xget_renaming_scope): Return std::string.
2171         (old_renaming_is_invisible): Update.
2172
2173 2018-05-04  Tom Tromey  <tom@tromey.com>
2174
2175         * bfd-target.c (target_bfd::m_bfd): Now a gdb_bfd_ref_ptr.
2176         (target_bfd::target_bfd, target_bfd::~target_bfd): Update.
2177
2178 2018-05-04  Ulrich Weigand  <uweigand@de.ibm.com>
2179
2180         * spu-linux-nat.c (spu_linux_nat_target::wait): Fix syntax error.
2181
2182 2018-05-04  Tom Tromey  <tom@tromey.com>
2183
2184         * remote.c (remote_query_supported_append): Change type.
2185         (remote_check_symbols): Update.
2186
2187 2018-05-04  Paul Pluzhnikov  <ppluzhnikov@google.com>
2188
2189         PR gdb/11420
2190         * configure.ac: Prepend libpython.
2191         * python/python-config.py: Likewise.
2192         * configure: Regenerate.
2193
2194 2018-05-03  Simon Marchi  <simon.marchi@ericsson.com>
2195
2196         * Makefile.in (%.c: %.l): Use -t instead of --stdout.
2197
2198 2018-05-03  Pedro Alves  <palves@redhat.com>
2199
2200         * s390-linux-nat.c
2201         (s390_linux_nat_target::have_continuable_watchpoint): Mark with
2202         override.  Write 'true' instead of '1'.
2203         (s390_linux_nat_target::watchpoint_addr_within_range): Remove
2204         declaration.
2205
2206 2018-05-02  Pedro Alves  <palves@redhat.com>
2207
2208         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Use
2209         add_inf_child_target.
2210         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Use
2211         add_inf_child_target.
2212         * aix-thread.c (aix_thread_target_info): New.
2213         (aix_thread_target) <shortname, longname, doc>: Delete.
2214         <info>: New.
2215         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Use
2216         add_inf_child_target.
2217         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Use
2218         add_inf_child_target.
2219         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Use
2220         add_inf_child_target.
2221         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Use
2222         add_inf_child_target.
2223         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Use
2224         add_inf_child_target.
2225         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Use
2226         add_inf_child_target.
2227         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Use
2228         add_inf_child_target.
2229         * arm-linux-nat.c (_initialize_arm_linux_nat): Use
2230         add_inf_child_target.
2231         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Use
2232         add_inf_child_target.
2233         * bfd-target.c (target_bfd_target_info): New.
2234         (target_bfd) <shortname, longname, doc>: Delete.
2235         <info>: New.
2236         * bsd-kvm.c (bsd_kvm_target_info): New.
2237         (bsd_kvm_target) <shortname, longname, doc>: Delete.
2238         <info>: New.
2239         (bsd_kvm_target::open): Rename to ...
2240         (bsd_kvm_target_open): ... this.  Adjust.
2241         * bsd-uthread.c (bsd_uthread_target_info): New.
2242         (bsd_uthread_target) <shortname, longname, doc>: Delete.
2243         <info>: New.
2244         * corefile.c (core_file_command): Adjust.
2245         * corelow.c (core_target_info): New.
2246         (core_target) <shortname, longname, doc>: Delete.
2247         <info>: New.
2248         (core_target::open): Rename to ...
2249         (core_target_open): ... this.  Adjust.
2250         * ctf.c (ctf_target_info): New.
2251         (ctf_target) <shortname, longname, doc>: Delete.
2252         <info>: New.
2253         (ctf_target::open): Rename to ...
2254         (ctf_target_open): ... this.
2255         (_initialize_ctf): Adjust.
2256         * exec.c (exec_target_info): New.
2257         (exec_target) <shortname, longname, doc>: Delete.
2258         <info>: New.
2259         (exec_target::open): Rename to ...
2260         (exec_target_open): ... this.
2261         * gdbcore.h (core_target_open): Declare.
2262         * go32-nat.c (_initialize_go32_nat): Use add_inf_child_target.
2263         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Use
2264         add_inf_child_target.
2265         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Use
2266         add_inf_child_target.
2267         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Use
2268         add_inf_child_target.
2269         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Use
2270         add_inf_child_target.
2271         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Use
2272         add_inf_child_target.
2273         * i386-gnu-nat.c (_initialize_i386gnu_nat): Use
2274         add_inf_child_target.
2275         * i386-linux-nat.c (_initialize_i386_linux_nat): Use
2276         add_inf_child_target.
2277         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Use
2278         add_inf_child_target.
2279         * i386-obsd-nat.c (_initialize_i386obsd_nat): Use
2280         add_inf_child_target.
2281         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Use
2282         add_inf_child_target.
2283         * inf-child.c (inf_child_target_info): New.
2284         (inf_child_target::info): New.
2285         (inf_child_open_target): Remove 'target' parameter.  Use
2286         get_native_target instead.
2287         (inf_child_target::open): Delete.
2288         (add_inf_child_target): New.
2289         * inf-child.h (inf_child_target) <shortname, longname, doc, open>:
2290         Delete.
2291         <info>: New.
2292         (add_inf_child_target): Declare.
2293         (inf_child_open_target): Declare.
2294         * linux-thread-db.c (thread_db_target_info): New.
2295         (thread_db_target) <shortname, longname, doc>: Delete.
2296         <info>: New.
2297         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Use
2298         add_inf_child_target.
2299         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Use
2300         add_inf_child_target.
2301         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Use
2302         add_inf_child_target.
2303         * m88k-bsd-nat.c (_initialize_m88kbsd_nat): Use
2304         add_inf_child_target.
2305         * make-target-delegates (print_class): Adjust.
2306         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Use
2307         add_inf_child_target.
2308         * mips-linux-nat.c (_initialize_mips_linux_nat): Use
2309         add_inf_child_target.
2310         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Use
2311         add_inf_child_target.
2312         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Use
2313         add_inf_child_target.
2314         * nto-procfs.c (nto_native_target_info): New.
2315         (nto_procfs_target_native) <shortname, longname, doc>:
2316         Delete.
2317         <info>: New.
2318         (nto_procfs_target_info): New.
2319         (nto_procfs_target_procfs) <shortname, longname, doc>:
2320         Delete.
2321         <info>: New.
2322         (init_procfs_targets): Adjust.
2323         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Use
2324         add_inf_child_target.
2325         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Use
2326         add_inf_child_target.
2327         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Use
2328         add_inf_child_target.
2329         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Use
2330         add_inf_child_target.
2331         * ravenscar-thread.c (ravenscar_target_info): New.
2332         (ravenscar_thread_target) <shortname, longname, doc>:
2333         Delete.
2334         <info>: New.
2335         * record-btrace.c (record_btrace_target_info):
2336         (record_btrace_target) <shortname, longname, doc>: Delete.
2337         <info>: New.
2338         (record_btrace_target::open): Rename to ...
2339         (record_btrace_target_open): ... this.  Adjust.
2340         * record-full.c (record_longname, record_doc): New.
2341         (record_full_base_target) <shortname, longname, doc>: Delete.
2342         <info>: New.
2343         (record_full_target_info): New.
2344         (record_full_target): <shortname>: Delete.
2345         <info>: New.
2346         (record_full_core_open_1, record_full_open_1): Update comments.
2347         (record_full_base_target::open): Rename to ...
2348         (record_full_open): ... this.
2349         (cmd_record_full_restore): Update.
2350         (_initialize_record_full): Update.
2351         * remote-sim.c (remote_sim_target_info): New.
2352         (gdbsim_target) <shortname, longname, doc>: Delete.
2353         <info>: New.
2354         (gdbsim_target::open): Rename to ...
2355         (gdbsim_target_open): ... this.
2356         (_initialize_remote_sim): Adjust.
2357         * remote.c (remote_doc): New.
2358         (remote_target_info): New.
2359         (remote_target) <shortname, longname, doc>: Delete.
2360         <info>: New.
2361         (extended_remote_target_info): New.
2362         (extended_remote_target) <shortname, longname, doc>: Delete.
2363         <info>: New.
2364         (remote_target::open_1): Make static.  Adjust.
2365         * rs6000-nat.c (_initialize_rs6000_nat): Use add_inf_child_target.
2366         * s390-linux-nat.c (_initialize_s390_nat): Use
2367         add_inf_child_target.
2368         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Use
2369         add_inf_child_target.
2370         * sol-thread.c (thread_db_target_info): New.
2371         (sol_thread_target) <shortname, longname, doc>: Delete.
2372         <info>: New.
2373         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Use
2374         add_inf_child_target.
2375         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Use
2376         add_inf_child_target.
2377         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Use
2378         add_inf_child_target.
2379         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Use
2380         add_inf_child_target.
2381         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Use
2382         add_inf_child_target.
2383         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Use
2384         add_inf_child_target.
2385         * spu-linux-nat.c (_initialize_spu_nat): Use
2386         add_inf_child_target.
2387         * spu-multiarch.c (spu_multiarch_target_info): New.
2388         (spu_multiarch_target) <shortname, longname, doc>: Delete.
2389         <info>: New.
2390         * target-delegates.c: Regenerate.
2391         * target.c: Include <unordered_map>.
2392         (target_ops_p): Delete.
2393         (DEF_VEC_P(target_ops_p)): Delete.
2394         (target_factories): New.
2395         (test_target_info): New.
2396         (test_target_ops::info): New.
2397         (open_target): Adjust to use target_factories.
2398         (add_target_with_completer): Rename to ...
2399         (add_target): ... this.  Change prototype.  Register target_info
2400         and open callback in target_factories.  Register target_info in
2401         command context instead of target_ops.
2402         (add_target): Delete old implementation.
2403         (add_deprecated_target_alias): Change prototype.  Adjust.
2404         (the_native_target): New.
2405         (set_native_target, get_native_target): New.
2406         (find_default_run_target): Use the_native_target.
2407         (find_attach_target, find_run_target): Simplify.
2408         (target_ops::open): Delete.
2409         (dummy_target_info): New.
2410         (dummy_target::shortname, dummy_target::longname)
2411         (dummy_target::doc): Delete.
2412         (dummy_target::info): New.
2413         (debug_target::shortname, debug_target::longname)
2414         (debug_target::doc): Delete.
2415         (debug_target::info): New.
2416         * target.h (struct target_info): New.
2417         (target_ops::~target_ops): Add comment.
2418         (target_ops::info): New.
2419         (target_ops::shortname, target_ops::longname, target_ops::doc): No
2420         longer virtual.  Implement in terms of target_info.
2421         (set_native_target, get_native_target): Declare.
2422         (target_open_ftype): New.
2423         (add_target, add_target_with_completer)
2424         (add_deprecated_target_alias): Change prototype.
2425         (test_target) <shortname, longname, doc>: Delete.
2426         <info>: New.
2427         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Use
2428         add_inf_child_target.
2429         * tracefile-tfile.c (tfile_target_info): New.
2430         (tfile_target) <shortname, longname, doc>: Delete.
2431         <info>: New.
2432         (tfile_target::open): Rename to ...
2433         (tfile_target_open): ... this.
2434         (_initialize_tracefile_tfile): Adjust.
2435         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Use
2436         add_inf_child_target.
2437         * windows-nat.c (_initialize_windows_nat): Use
2438         add_inf_child_target.
2439         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Use
2440         add_inf_child_target.
2441
2442 2018-05-02  Pedro Alves  <palves@redhat.com>
2443
2444         * linux-nat.h (linux_nat_target) <low_new_thread,
2445         low_delete_thread, low_new_fork, low_forget_process,
2446         low_prepare_to_resume, low_siginfo_fixup, low_status_is_event>:
2447         New virtual methods.
2448         (linux_nat_set_new_thread, linux_nat_set_delete_thread)
2449         (linux_nat_new_fork_ftype, linux_nat_set_new_fork)
2450         (linux_nat_forget_process_ftype, linux_nat_set_forget_process)
2451         (linux_nat_forget_process, linux_nat_set_siginfo_fixup)
2452         (linux_nat_set_prepare_to_resume, linux_nat_set_status_is_event):
2453         Delete.
2454         * linux-fork.c (delete_fork): Adjust to call low method.
2455         * linux-nat.c (linux_nat_new_thread, linux_nat_delete_thread)
2456         (linux_nat_new_fork, linux_nat_forget_process_hook)
2457         (linux_nat_prepare_to_resume, linux_nat_siginfo_fixup)
2458         (linux_nat_status_is_event):
2459         (linux_nat_target::follow_fork, lwp_free, add_lwp, detach_one_lwp)
2460         (linux_resume_one_lwp_throw, linux_handle_extended_wait): Adjust
2461         to call low method.
2462         (sigtrap_is_event): Rename to ...
2463         (linux_nat_target::low_status_is_event): ... this.
2464         (linux_nat_set_status_is_event): Delete.
2465         (save_stop_reason, linux_nat_wait_1)
2466         (linux_nat_target::mourn_inferior, siginfo_fixup): Adjust to call
2467         low methods.
2468         (linux_nat_set_new_thread, linux_nat_set_delete_thread)
2469         (linux_nat_set_new_fork, linux_nat_set_forget_process)
2470         (linux_nat_forget_process, linux_nat_set_siginfo_fixup)
2471         (linux_nat_set_prepare_to_resume): Delete.
2472         * aarch64-linux-nat.c: All linux_nat_set_* callbacks converted to
2473         low virtual methods.
2474         * amd64-linux-nat.c: Likewise.
2475         * arm-linux-nat.c: Likewise.
2476         * i386-linux-nat.c: Likewise.
2477         * ia64-linux-nat.c: Likewise.
2478         * mips-linux-nat.c: Likewise.
2479         * ppc-linux-nat.c: Likewise.
2480         * s390-linux-nat.c: Likewise.
2481         * sparc64-linux-nat.c: Likewise.
2482         * x86-linux-nat.c: Likewise.
2483         * x86-linux-nat.h: Include "nat/x86-linux.h".
2484         (x86_linux_nat_target) <low_new_fork, low_forget_process,
2485         low_prepare_to_resume, low_new_thread, low_delete_thread>:
2486         Override methods.
2487
2488 2018-05-02  Pedro Alves  <palves@redhat.com>
2489
2490         * target.h (target_ops)
2491         <stopped_by_sw_breakpoint, supports_stopped_by_sw_breakpoint,
2492         stopped_by_hw_breakpoint, supports_stopped_by_hw_breakpoint,
2493         stopped_by_watchpoint, have_continuable_watchpoint,
2494         stopped_data_address, watchpoint_addr_within_range,
2495         can_accel_watchpoint_condition, can_run, thread_alive,
2496         has_all_memory, has_memory, has_stack, has_registers,
2497         has_execution, can_async_p, is_async_p, supports_non_stop,
2498         always_non_stop_p, can_execute_reverse, supports_multi_process,
2499         supports_enable_disable_tracepoint,
2500         supports_disable_randomization, supports_string_tracing,
2501         supports_evaluation_of_breakpoint_conditions,
2502         can_run_breakpoint_commands, filesystem_is_local,
2503         can_download_tracepoint, get_trace_state_variable_value,
2504         set_trace_notes, get_tib_address, use_agent, can_use_agent,
2505         record_is_replaying, record_will_replay,
2506         augmented_libraries_svr4_read>: Adjust to return bool.
2507         * aarch64-linux-nat.c: All implementations adjusted.
2508         * aix-thread.c: All implementations adjusted.
2509         * arm-linux-nat.c: All implementations adjusted.
2510         * breakpoint.c: All implementations adjusted.
2511         * bsd-kvm.c: All implementations adjusted.
2512         * bsd-uthread.c: All implementations adjusted.
2513         * corelow.c: All implementations adjusted.
2514         * ctf.c: All implementations adjusted.
2515         * darwin-nat.c: All implementations adjusted.
2516         * darwin-nat.h: All implementations adjusted.
2517         * exec.c: All implementations adjusted.
2518         * fbsd-nat.c: All implementations adjusted.
2519         * fbsd-nat.h: All implementations adjusted.
2520         * gnu-nat.c: All implementations adjusted.
2521         * gnu-nat.h: All implementations adjusted.
2522         * go32-nat.c: All implementations adjusted.
2523         * ia64-linux-nat.c: All implementations adjusted.
2524         * inf-child.c: All implementations adjusted.
2525         * inf-child.h: All implementations adjusted.
2526         * inf-ptrace.c: All implementations adjusted.
2527         * inf-ptrace.h: All implementations adjusted.
2528         * linux-nat.c: All implementations adjusted.
2529         * linux-nat.h: All implementations adjusted.
2530         * mips-linux-nat.c: All implementations adjusted.
2531         * nto-procfs.c: All implementations adjusted.
2532         * ppc-linux-nat.c: All implementations adjusted.
2533         * procfs.c: All implementations adjusted.
2534         * ravenscar-thread.c: All implementations adjusted.
2535         * record-btrace.c: All implementations adjusted.
2536         * record-full.c: All implementations adjusted.
2537         * remote-sim.c: All implementations adjusted.
2538         * remote.c: All implementations adjusted.
2539         * s390-linux-nat.c: All implementations adjusted.
2540         * sol-thread.c: All implementations adjusted.
2541         * spu-multiarch.c: All implementations adjusted.
2542         * target-delegates.c: All implementations adjusted.
2543         * target.c: All implementations adjusted.
2544         * target.h: All implementations adjusted.
2545         * tracefile-tfile.c: All implementations adjusted.
2546         * tracefile.c: All implementations adjusted.
2547         * tracefile.h: All implementations adjusted.
2548         * windows-nat.c: All implementations adjusted.
2549         * x86-linux-nat.h: All implementations adjusted.
2550         * x86-nat.h: All implementations adjusted.
2551
2552 2018-05-02  Pedro Alves  <palves@redhat.com>
2553
2554         * make-target-delegates (scan_target_h): Don't trim lines here.
2555         Replace sequences of tabs and/or whitespace with a single
2556         whitespace.
2557         (top level, parsing methods): Trim each line before processing it
2558         here.
2559
2560 2018-05-02  Pedro Alves  <palves@redhat.com>
2561             John Baldwin  <jhb@freebsd.org>
2562
2563         * target.h (enum strata) <debug_stratum>: New.
2564         (struct target_ops) <all delegation methods>: Replace by C++
2565         virtual methods, and drop "to_" prefix.  All references updated
2566         throughout.
2567         <to_shortname, to_longname, to_doc, to_data,
2568         to_have_steppable_watchpoint, to_have_continuable_watchpoint,
2569         to_has_thread_control, to_attach_no_wait>: Delete, replaced by
2570         virtual methods.  All references updated throughout.
2571         <can_attach, supports_terminal_ours, can_create_inferior,
2572         get_thread_control_capabilities, attach_no_wait>: New
2573         virtual methods.
2574         <insert_breakpoint, remove_breakpoint>: Now
2575         TARGET_DEFAULT_NORETURN methods.
2576         <info_proc>: Now returns bool.
2577         <to_magic>: Delete.
2578         (OPS_MAGIC): Delete.
2579         (current_target): Delete.  All references replaced by references
2580         to ...
2581         (target_stack): ... this.  New.
2582         (target_shortname, target_longname): Adjust.
2583         (target_can_run): Now a function declaration.
2584         (default_child_has_all_memory, default_child_has_memory)
2585         (default_child_has_stack, default_child_has_registers)
2586         (default_child_has_execution): Remove target_ops parameter.
2587         (complete_target_initialization): Delete.
2588         (memory_breakpoint_target): New template class.
2589         (test_target_ops): Refactor as a C++ class with virtual methods.
2590         * make-target-delegates (NAME_PART): Tighten.
2591         (POINTER_PART, CP_SYMBOL): New.
2592         (SIMPLE_RETURN_PART): Reimplement.
2593         (VEC_RETURN_PART): Expect less.
2594         (RETURN_PART, VIRTUAL_PART): New.
2595         (METHOD): Adjust to C++ virtual methods.
2596         (scan_target_h): Remove reference to C99.
2597         (dname): Output "target_ops::" prefix.
2598         (write_function_header): Adjust to output a C++ class method.
2599         (write_declaration): New.
2600         (write_delegator): Adjust to output a C++ class method.
2601         (tdname): Output "dummy_target::" prefix.
2602         (write_tdefault, write_debugmethod): Adjust to output a C++ class
2603         method.
2604         (tdefault_names, debug_names): Delete.
2605         (return_types, tdefaults, styles, argtypes_array): New.
2606         (top level): All methods are delegators.
2607         (print_class): New.
2608         (top level): Print dummy_target and debug_target classes.
2609         * target-delegates.c: Regenerate.
2610         * target-debug.h (target_debug_print_enum_info_proc_what)
2611         (target_debug_print_thread_control_capabilities)
2612         (target_debug_print_thread_info_p): New.
2613         * target.c (dummy_target): Delete.
2614         (the_dummy_target, the_debug_target): New.
2615         (target_stack): Now extern.
2616         (set_targetdebug): Push/unpush debug target.
2617         (default_child_has_all_memory, default_child_has_memory)
2618         (default_child_has_stack, default_child_has_registers)
2619         (default_child_has_execution): Remove target_ops parameter.
2620         (complete_target_initialization): Delete.
2621         (add_target_with_completer): No longer call
2622         complete_target_initialization.
2623         (target_supports_terminal_ours): Use regular delegation.
2624         (update_current_target): Delete.
2625         (push_target): No longer check magic number.  Don't call
2626         update_current_target.
2627         (unpush_target): Don't call update_current_target.
2628         (target_is_pushed): No longer check magic number.
2629         (target_require_runnable): Skip for all stratums over
2630         process_stratum.
2631         (target_ops::info_proc): New.
2632         (target_info_proc): Use find_target_at and
2633         find_default_run_target.
2634         (target_supports_disable_randomization): Use regular delegation.
2635         (target_get_osdata): Use find_target_at.
2636         (target_ops::open, target_ops::close, target_ops::can_attach)
2637         (target_ops::attach, target_ops::can_create_inferior)
2638         (target_ops::create_inferior, target_ops::can_run)
2639         (target_can_run): New.
2640         (default_fileio_target): Use regular delegation.
2641         (target_ops::fileio_open, target_ops::fileio_pwrite)
2642         (target_ops::fileio_pread, target_ops::fileio_fstat)
2643         (target_ops::fileio_close, target_ops::fileio_unlink)
2644         (target_ops::fileio_readlink): New.
2645         (target_fileio_open_1, target_fileio_unlink)
2646         (target_fileio_readlink): Always call the target method.  Handle
2647         FILEIO_ENOSYS.
2648         (return_zero, return_zero_has_execution): Delete.
2649         (init_dummy_target): Delete.
2650         (dummy_target::dummy_target, dummy_target::shortname)
2651         (dummy_target::longname, dummy_target::doc)
2652         (debug_target::debug_target, debug_target::shortname)
2653         (debug_target::longname, debug_target::doc): New.
2654         (target_supports_delete_record): Use regular delegation.
2655         (setup_target_debug): Delete.
2656         (maintenance_print_target_stack): Skip debug_stratum.
2657         (initialize_targets): Instantiate the_dummy_target and
2658         the_debug_target.
2659         * auxv.c (target_auxv_parse): Remove 'ops' parameter.  Adjust to
2660         use target_stack.
2661         (target_auxv_search, fprint_target_auxv): Adjust.
2662         (info_auxv_command): Adjust to use target_stack.
2663         * auxv.h (target_auxv_parse): Remove 'ops' parameter.
2664         * exceptions.c (print_flush): Handle a NULL target_stack.
2665         * regcache.c (target_ops_no_register): Refactor as class with
2666         virtual methods.
2667
2668         * exec.c (exec_target): New class.
2669         (exec_ops): Now an exec_target.
2670         (exec_open, exec_close_1, exec_get_section_table)
2671         (exec_xfer_partial, exec_files_info, exec_has_memory)
2672         (exec_make_note_section): Refactor as exec_target methods.
2673         (exec_file_clear, ignore, exec_remove_breakpoint, init_exec_ops):
2674         Delete.
2675         (exec_target::find_memory_regions): New.
2676         (_initialize_exec): Don't call init_exec_ops.
2677         * gdbcore.h (exec_file_clear): Delete.
2678
2679         * corefile.c (core_target): Delete.
2680         (core_file_command): Adjust.
2681         * corelow.c (core_target): New class.
2682         (the_core_target): New.
2683         (core_close): Remove target_ops parameter.
2684         (core_close_cleanup): Adjust.
2685         (core_target::close): New.
2686         (core_open, core_detach, get_core_registers, core_files_info)
2687         (core_xfer_partial, core_thread_alive, core_read_description)
2688         (core_pid_to_str, core_thread_name, core_has_memory)
2689         (core_has_stack, core_has_registers, core_info_proc): Rework as
2690         core_target methods.
2691         (ignore, core_remove_breakpoint, init_core_ops): Delete.
2692         (_initialize_corelow): Initialize the_core_target.
2693         * gdbcore.h (core_target): Delete.
2694         (the_core_target): New.
2695
2696         * ctf.c: (ctf_target): New class.
2697         (ctf_ops): Now a ctf_target.
2698         (ctf_open, ctf_close, ctf_files_info, ctf_fetch_registers)
2699         (ctf_xfer_partial, ctf_get_trace_state_variable_value)
2700         (ctf_trace_find, ctf_traceframe_info): Refactor as ctf_target
2701         methods.
2702         (init_ctf_ops): Delete.
2703         (_initialize_ctf): Don't call it.
2704         * tracefile-tfile.c (tfile_target): New class.
2705         (tfile_ops): Now a tfile_target.
2706         (tfile_open, tfile_close, tfile_files_info)
2707         (tfile_get_tracepoint_status, tfile_trace_find)
2708         (tfile_fetch_registers, tfile_xfer_partial)
2709         (tfile_get_trace_state_variable_value, tfile_traceframe_info):
2710         Refactor as tfile_target methods.
2711         (tfile_xfer_partial_features): Remove target_ops parameter.
2712         (init_tfile_ops): Delete.
2713         (_initialize_tracefile_tfile): Don't call it.
2714         * tracefile.c (tracefile_has_all_memory, tracefile_has_memory)
2715         (tracefile_has_stack, tracefile_has_registers)
2716         (tracefile_thread_alive, tracefile_get_trace_status): Refactor as
2717         tracefile_target methods.
2718         (init_tracefile_ops): Delete.
2719         (tracefile_target::tracefile_target): New.
2720         * tracefile.h: Include "target.h".
2721         (tracefile_target): New class.
2722         (init_tracefile_ops): Delete.
2723
2724         * spu-multiarch.c (spu_multiarch_target): New class.
2725         (spu_ops): Now a spu_multiarch_target.
2726         (spu_thread_architecture, spu_region_ok_for_hw_watchpoint)
2727         (spu_fetch_registers, spu_store_registers, spu_xfer_partial)
2728         (spu_search_memory, spu_mourn_inferior): Refactor as
2729         spu_multiarch_target methods.
2730         (init_spu_ops): Delete.
2731         (_initialize_spu_multiarch): Remove references to init_spu_ops,
2732         complete_target_initialization.
2733
2734         * ravenscar-thread.c (ravenscar_thread_target): New class.
2735         (ravenscar_ops): Now a ravenscar_thread_target.
2736         (ravenscar_resume, ravenscar_wait, ravenscar_update_thread_list)
2737         (ravenscar_thread_alive, ravenscar_pid_to_str)
2738         (ravenscar_fetch_registers, ravenscar_store_registers)
2739         (ravenscar_prepare_to_store, ravenscar_stopped_by_sw_breakpoint)
2740         (ravenscar_stopped_by_hw_breakpoint)
2741         (ravenscar_stopped_by_watchpoint, ravenscar_stopped_data_address)
2742         (ravenscar_mourn_inferior, ravenscar_core_of_thread)
2743         (ravenscar_get_ada_task_ptid): Refactor as ravenscar_thread_target
2744         methods.
2745         (init_ravenscar_thread_ops): Delete.
2746         (_initialize_ravenscar): Remove references to
2747         init_ravenscar_thread_ops and complete_target_initialization.
2748
2749         * bsd-uthread.c (bsd_uthread_ops_hack): Delete.
2750         (bsd_uthread_target): New class.
2751         (bsd_uthread_ops): Now a bsd_uthread_target.
2752         (bsd_uthread_activate): Adjust to refer to bsd_uthread_ops.
2753         (bsd_uthread_close, bsd_uthread_mourn_inferior)
2754         (bsd_uthread_fetch_registers, bsd_uthread_store_registers)
2755         (bsd_uthread_wait, bsd_uthread_resume, bsd_uthread_thread_alive)
2756         (bsd_uthread_update_thread_list, bsd_uthread_extra_thread_info)
2757         (bsd_uthread_pid_to_str): Refactor as bsd_uthread_target methods.
2758         (bsd_uthread_target): Delete function.
2759         (_initialize_bsd_uthread): Remove reference to
2760         complete_target_initialization.
2761
2762         * bfd-target.c (target_bfd_data): Delete.  Fields folded into ...
2763         (target_bfd): ... this new class.
2764         (target_bfd_xfer_partial, target_bfd_get_section_table)
2765         (target_bfd_close): Refactor as target_bfd methods.
2766         (target_bfd::~target_bfd): New.
2767         (target_bfd_reopen): Adjust.
2768         (target_bfd::close): New.
2769
2770         * record-btrace.c (record_btrace_target): New class.
2771         (record_btrace_ops): Now a record_btrace_target.
2772         (record_btrace_open, record_btrace_stop_recording)
2773         (record_btrace_disconnect, record_btrace_close)
2774         (record_btrace_async, record_btrace_info)
2775         (record_btrace_insn_history, record_btrace_insn_history_range)
2776         (record_btrace_insn_history_from, record_btrace_call_history)
2777         (record_btrace_call_history_range)
2778         (record_btrace_call_history_from, record_btrace_record_method)
2779         (record_btrace_is_replaying, record_btrace_will_replay)
2780         (record_btrace_xfer_partial, record_btrace_insert_breakpoint)
2781         (record_btrace_remove_breakpoint, record_btrace_fetch_registers)
2782         (record_btrace_store_registers, record_btrace_prepare_to_store)
2783         (record_btrace_to_get_unwinder)
2784         (record_btrace_to_get_tailcall_unwinder, record_btrace_resume)
2785         (record_btrace_commit_resume, record_btrace_wait)
2786         (record_btrace_stop, record_btrace_can_execute_reverse)
2787         (record_btrace_stopped_by_sw_breakpoint)
2788         (record_btrace_supports_stopped_by_sw_breakpoint)
2789         (record_btrace_stopped_by_hw_breakpoint)
2790         (record_btrace_supports_stopped_by_hw_breakpoint)
2791         (record_btrace_update_thread_list, record_btrace_thread_alive)
2792         (record_btrace_goto_begin, record_btrace_goto_end)
2793         (record_btrace_goto, record_btrace_stop_replaying_all)
2794         (record_btrace_execution_direction)
2795         (record_btrace_prepare_to_generate_core)
2796         (record_btrace_done_generating_core): Refactor as
2797         record_btrace_target methods.
2798         (init_record_btrace_ops): Delete.
2799         (_initialize_record_btrace): Remove reference to
2800         init_record_btrace_ops.
2801         * record-full.c (RECORD_FULL_IS_REPLAY): Adjust to always refer to
2802         the execution_direction global.
2803         (record_full_base_target, record_full_target)
2804         (record_full_core_target): New classes.
2805         (record_full_ops): Now a record_full_target.
2806         (record_full_core_ops): Now a record_full_core_target.
2807         (record_full_target::detach, record_full_target::disconnect)
2808         (record_full_core_target::disconnect)
2809         (record_full_target::mourn_inferior, record_full_target::kill):
2810         New.
2811         (record_full_open, record_full_close, record_full_async): Refactor
2812         as methods of the record_full_base_target class.
2813         (record_full_resume, record_full_commit_resume): Refactor
2814         as methods of the record_full_target class.
2815         (record_full_wait, record_full_stopped_by_watchpoint)
2816         (record_full_stopped_data_address)
2817         (record_full_stopped_by_sw_breakpoint)
2818         (record_full_supports_stopped_by_sw_breakpoint)
2819         (record_full_stopped_by_hw_breakpoint)
2820         (record_full_supports_stopped_by_hw_breakpoint): Refactor as
2821         methods of the record_full_base_target class.
2822         (record_full_store_registers, record_full_xfer_partial)
2823         (record_full_insert_breakpoint, record_full_remove_breakpoint):
2824         Refactor as methods of the record_full_target class.
2825         (record_full_can_execute_reverse, record_full_get_bookmark)
2826         (record_full_goto_bookmark, record_full_execution_direction)
2827         (record_full_record_method, record_full_info, record_full_delete)
2828         (record_full_is_replaying, record_full_will_replay)
2829         (record_full_goto_begin, record_full_goto_end, record_full_goto)
2830         (record_full_stop_replaying): Refactor as methods of the
2831         record_full_base_target class.
2832         (record_full_core_resume, record_full_core_kill)
2833         (record_full_core_fetch_registers)
2834         (record_full_core_prepare_to_store)
2835         (record_full_core_store_registers, record_full_core_xfer_partial)
2836         (record_full_core_insert_breakpoint)
2837         (record_full_core_remove_breakpoint)
2838         (record_full_core_has_execution): Refactor
2839         as methods of the record_full_core_target class.
2840         (record_full_base_target::supports_delete_record): New.
2841         (init_record_full_ops): Delete.
2842         (init_record_full_core_ops): Delete.
2843         (record_full_save): Refactor as method of the
2844         record_full_base_target class.
2845         (_initialize_record_full): Remove references to
2846         init_record_full_ops and init_record_full_core_ops.
2847
2848         * remote.c (remote_target, extended_remote_target): New classes.
2849         (remote_ops): Now a remote_target.
2850         (extended_remote_ops): Now an extended_remote_target.
2851         (remote_insert_fork_catchpoint, remote_remove_fork_catchpoint)
2852         (remote_insert_vfork_catchpoint, remote_remove_vfork_catchpoint)
2853         (remote_insert_exec_catchpoint, remote_remove_exec_catchpoint)
2854         (remote_pass_signals, remote_set_syscall_catchpoint)
2855         (remote_program_signals, )
2856         (remote_thread_always_alive): Remove target_ops parameter.
2857         (remote_thread_alive, remote_thread_name)
2858         (remote_update_thread_list, remote_threads_extra_info)
2859         (remote_static_tracepoint_marker_at)
2860         (remote_static_tracepoint_markers_by_strid)
2861         (remote_get_ada_task_ptid, remote_close, remote_start_remote)
2862         (remote_open): Refactor as methods of remote_target.
2863         (extended_remote_open, extended_remote_detach)
2864         (extended_remote_attach, extended_remote_post_attach):
2865         (extended_remote_supports_disable_randomization)
2866         (extended_remote_create_inferior): : Refactor as method of
2867         extended_remote_target.
2868         (remote_set_permissions, remote_open_1, remote_detach)
2869         (remote_follow_fork, remote_follow_exec, remote_disconnect)
2870         (remote_resume, remote_commit_resume, remote_stop)
2871         (remote_interrupt, remote_pass_ctrlc, remote_terminal_inferior)
2872         (remote_terminal_ours, remote_wait, remote_fetch_registers)
2873         (remote_prepare_to_store, remote_store_registers)
2874         (remote_flash_erase, remote_flash_done, remote_files_info)
2875         (remote_kill, remote_mourn, remote_insert_breakpoint)
2876         (remote_remove_breakpoint, remote_insert_watchpoint)
2877         (remote_watchpoint_addr_within_range)
2878         (remote_remove_watchpoint, remote_region_ok_for_hw_watchpoint)
2879         (remote_check_watch_resources, remote_stopped_by_sw_breakpoint)
2880         (remote_supports_stopped_by_sw_breakpoint)
2881         (remote_stopped_by_hw_breakpoint)
2882         (remote_supports_stopped_by_hw_breakpoint)
2883         (remote_stopped_by_watchpoint, remote_stopped_data_address)
2884         (remote_insert_hw_breakpoint, remote_remove_hw_breakpoint)
2885         (remote_verify_memory): Refactor as methods of remote_target.
2886         (remote_write_qxfer, remote_read_qxfer): Remove target_ops
2887         parameter.
2888         (remote_xfer_partial, remote_get_memory_xfer_limit)
2889         (remote_search_memory, remote_rcmd, remote_memory_map)
2890         (remote_pid_to_str, remote_get_thread_local_address)
2891         (remote_get_tib_address, remote_read_description): Refactor as
2892         methods of remote_target.
2893         (remote_target::fileio_open, remote_target::fileio_pwrite)
2894         (remote_target::fileio_pread, remote_target::fileio_close): New.
2895         (remote_hostio_readlink, remote_hostio_fstat)
2896         (remote_filesystem_is_local, remote_can_execute_reverse)
2897         (remote_supports_non_stop, remote_supports_disable_randomization)
2898         (remote_supports_multi_process, remote_supports_cond_breakpoints)
2899         (remote_supports_enable_disable_tracepoint)
2900         (remote_supports_string_tracing)
2901         (remote_can_run_breakpoint_commands, remote_trace_init)
2902         (remote_download_tracepoint, remote_can_download_tracepoint)
2903         (remote_download_trace_state_variable, remote_enable_tracepoint)
2904         (remote_disable_tracepoint, remote_trace_set_readonly_regions)
2905         (remote_trace_start, remote_get_trace_status)
2906         (remote_get_tracepoint_status, remote_trace_stop)
2907         (remote_trace_find, remote_get_trace_state_variable_value)
2908         (remote_save_trace_data, remote_get_raw_trace_data)
2909         (remote_set_disconnected_tracing, remote_core_of_thread)
2910         (remote_set_circular_trace_buffer, remote_traceframe_info)
2911         (remote_get_min_fast_tracepoint_insn_len)
2912         (remote_set_trace_buffer_size, remote_set_trace_notes)
2913         (remote_use_agent, remote_can_use_agent, remote_enable_btrace)
2914         (remote_disable_btrace, remote_teardown_btrace)
2915         (remote_read_btrace, remote_btrace_conf)
2916         (remote_augmented_libraries_svr4_read, remote_load)
2917         (remote_pid_to_exec_file, remote_can_do_single_step)
2918         (remote_execution_direction, remote_thread_handle_to_thread_info):
2919         Refactor as methods of remote_target.
2920         (init_remote_ops, init_extended_remote_ops): Delete.
2921         (remote_can_async_p, remote_is_async_p, remote_async)
2922         (remote_thread_events, remote_upload_tracepoints)
2923         (remote_upload_trace_state_variables): Refactor as methods of
2924         remote_target.
2925         (_initialize_remote): Remove references to init_remote_ops and
2926         init_extended_remote_ops.
2927
2928         * remote-sim.c (gdbsim_target): New class.
2929         (gdbsim_fetch_register, gdbsim_store_register, gdbsim_kill)
2930         (gdbsim_load, gdbsim_create_inferior, gdbsim_open, gdbsim_close)
2931         (gdbsim_detach, gdbsim_resume, gdbsim_interrupt)
2932         (gdbsim_wait, gdbsim_prepare_to_store, gdbsim_xfer_partial)
2933         (gdbsim_files_info, gdbsim_mourn_inferior, gdbsim_thread_alive)
2934         (gdbsim_pid_to_str, gdbsim_has_all_memory, gdbsim_has_memory):
2935         Refactor as methods of gdbsim_target.
2936         (gdbsim_ops): Now a gdbsim_target.
2937         (init_gdbsim_ops): Delete.
2938         (gdbsim_cntrl_c): Adjust.
2939         (_initialize_remote_sim): Remove reference to init_gdbsim_ops.
2940
2941         * amd64-linux-nat.c (amd64_linux_nat_target): New class.
2942         (the_amd64_linux_nat_target): New.
2943         (amd64_linux_fetch_inferior_registers)
2944         (amd64_linux_store_inferior_registers): Refactor as methods of
2945         amd64_linux_nat_target.
2946         (_initialize_amd64_linux_nat): Adjust.  Set linux_target.
2947         * i386-linux-nat.c: Don't include "linux-nat.h".
2948         (i386_linux_nat_target): New class.
2949         (the_i386_linux_nat_target): New.
2950         (i386_linux_fetch_inferior_registers)
2951         (i386_linux_store_inferior_registers, i386_linux_resume): Refactor
2952         as methods of i386_linux_nat_target.
2953         (_initialize_i386_linux_nat): Adjust.  Set linux_target.
2954         * inf-child.c (inf_child_ops): Delete.
2955         (inf_child_fetch_inferior_registers)
2956         (inf_child_store_inferior_registers): Delete.
2957         (inf_child_post_attach, inf_child_prepare_to_store): Refactor as
2958         methods of inf_child_target.
2959         (inf_child_target::supports_terminal_ours)
2960         (inf_child_target::terminal_init)
2961         (inf_child_target::terminal_inferior)
2962         (inf_child_target::terminal_ours_for_output)
2963         (inf_child_target::terminal_ours, inf_child_target::interrupt)
2964         (inf_child_target::pass_ctrlc, inf_child_target::terminal_info):
2965         New.
2966         (inf_child_open, inf_child_disconnect, inf_child_close)
2967         (inf_child_mourn_inferior, inf_child_maybe_unpush_target)
2968         (inf_child_post_startup_inferior, inf_child_can_run)
2969         (inf_child_pid_to_exec_file): Refactor as methods of
2970         inf_child_target.
2971         (inf_child_follow_fork): Delete.
2972         (inf_child_target::can_create_inferior)
2973         (inf_child_target::can_attach): New.
2974         (inf_child_target::has_all_memory, inf_child_target::has_memory)
2975         (inf_child_target::has_stack, inf_child_target::has_registers)
2976         (inf_child_target::has_execution): New.
2977         (inf_child_fileio_open, inf_child_fileio_pwrite)
2978         (inf_child_fileio_pread, inf_child_fileio_fstat)
2979         (inf_child_fileio_close, inf_child_fileio_unlink)
2980         (inf_child_fileio_readlink, inf_child_use_agent)
2981         (inf_child_can_use_agent): Refactor as methods of
2982         inf_child_target.
2983         (return_zero, inf_child_target): Delete.
2984         (inf_child_target::inf_child_target): New.
2985         * inf-child.h: Include "target.h".
2986         (inf_child_target): Delete function prototype.
2987         (inf_child_target): New class.
2988         (inf_child_open_target, inf_child_mourn_inferior)
2989         (inf_child_maybe_unpush_target): Delete.
2990         * inf-ptrace.c (inf_ptrace_target::~inf_ptrace_target): New.
2991         (inf_ptrace_follow_fork, inf_ptrace_insert_fork_catchpoint)
2992         (inf_ptrace_remove_fork_catchpoint, inf_ptrace_create_inferior)
2993         (inf_ptrace_post_startup_inferior, inf_ptrace_mourn_inferior)
2994         (inf_ptrace_attach, inf_ptrace_post_attach, inf_ptrace_detach)
2995         (inf_ptrace_detach_success, inf_ptrace_kill, inf_ptrace_resume)
2996         (inf_ptrace_wait, inf_ptrace_xfer_partial)
2997         (inf_ptrace_thread_alive, inf_ptrace_files_info)
2998         (inf_ptrace_pid_to_str, inf_ptrace_auxv_parse): Refactor as
2999         methods of inf_ptrace_target.
3000         (inf_ptrace_target): Delete function.
3001         * inf-ptrace.h: Include "inf-child.h".
3002         (inf_ptrace_target): Delete function declaration.
3003         (inf_ptrace_target): New class.
3004         (inf_ptrace_trad_target, inf_ptrace_detach_success): Delete.
3005         * linux-nat.c (linux_target): New.
3006         (linux_ops, linux_ops_saved, super_xfer_partial): Delete.
3007         (linux_nat_target::~linux_nat_target): New.
3008         (linux_child_post_attach, linux_child_post_startup_inferior)
3009         (linux_child_follow_fork, linux_child_insert_fork_catchpoint)
3010         (linux_child_remove_fork_catchpoint)
3011         (linux_child_insert_vfork_catchpoint)
3012         (linux_child_remove_vfork_catchpoint)
3013         (linux_child_insert_exec_catchpoint)
3014         (linux_child_remove_exec_catchpoint)
3015         (linux_child_set_syscall_catchpoint, linux_nat_pass_signals)
3016         (linux_nat_create_inferior, linux_nat_attach, linux_nat_detach)
3017         (linux_nat_resume, linux_nat_stopped_by_watchpoint)
3018         (linux_nat_stopped_data_address)
3019         (linux_nat_stopped_by_sw_breakpoint)
3020         (linux_nat_supports_stopped_by_sw_breakpoint)
3021         (linux_nat_stopped_by_hw_breakpoint)
3022         (linux_nat_supports_stopped_by_hw_breakpoint, linux_nat_wait)
3023         (linux_nat_kill, linux_nat_mourn_inferior)
3024         (linux_nat_xfer_partial, linux_nat_thread_alive)
3025         (linux_nat_update_thread_list, linux_nat_pid_to_str)
3026         (linux_nat_thread_name, linux_child_pid_to_exec_file)
3027         (linux_child_static_tracepoint_markers_by_strid)
3028         (linux_nat_is_async_p, linux_nat_can_async_p)
3029         (linux_nat_supports_non_stop, linux_nat_always_non_stop_p)
3030         (linux_nat_supports_multi_process)
3031         (linux_nat_supports_disable_randomization, linux_nat_async)
3032         (linux_nat_stop, linux_nat_close, linux_nat_thread_address_space)
3033         (linux_nat_core_of_thread, linux_nat_filesystem_is_local)
3034         (linux_nat_fileio_open, linux_nat_fileio_readlink)
3035         (linux_nat_fileio_unlink, linux_nat_thread_events): Refactor as
3036         methods of linux_nat_target.
3037         (linux_nat_wait_1, linux_xfer_siginfo, linux_proc_xfer_partial)
3038         (linux_proc_xfer_spu, linux_nat_xfer_osdata): Remove target_ops
3039         parameter.
3040         (check_stopped_by_watchpoint): Adjust.
3041         (linux_xfer_partial): Delete.
3042         (linux_target_install_ops, linux_target, linux_nat_add_target):
3043         Delete.
3044         (linux_nat_target::linux_nat_target): New.
3045         * linux-nat.h: Include "inf-ptrace.h".
3046         (linux_nat_target): New.
3047         (linux_target, linux_target_install_ops, linux_nat_add_target):
3048         Delete function declarations.
3049         (linux_target): Declare global.
3050         * linux-thread-db.c (thread_db_target): New.
3051         (thread_db_target::thread_db_target): New.
3052         (thread_db_ops): Delete.
3053         (the_thread_db_target): New.
3054         (thread_db_detach, thread_db_wait, thread_db_mourn_inferior)
3055         (thread_db_update_thread_list, thread_db_pid_to_str)
3056         (thread_db_extra_thread_info)
3057         (thread_db_thread_handle_to_thread_info)
3058         (thread_db_get_thread_local_address, thread_db_get_ada_task_ptid)
3059         (thread_db_resume): Refactor as methods of thread_db_target.
3060         (init_thread_db_ops): Delete.
3061         (_initialize_thread_db): Remove reference to init_thread_db_ops.
3062         * x86-linux-nat.c: Don't include "linux-nat.h".
3063         (super_post_startup_inferior): Delete.
3064         (x86_linux_nat_target::~x86_linux_nat_target): New.
3065         (x86_linux_child_post_startup_inferior)
3066         (x86_linux_read_description, x86_linux_enable_btrace)
3067         (x86_linux_disable_btrace, x86_linux_teardown_btrace)
3068         (x86_linux_read_btrace, x86_linux_btrace_conf): Refactor as
3069         methods of x86_linux_nat_target.
3070         (x86_linux_create_target): Delete.  Bits folded ...
3071         (x86_linux_add_target): ... here.  Now takes a linux_nat_target
3072         pointer.
3073         * x86-linux-nat.h: Include "linux-nat.h" and "x86-nat.h".
3074         (x86_linux_nat_target): New class.
3075         (x86_linux_create_target): Delete.
3076         (x86_linux_add_target): Now takes a linux_nat_target pointer.
3077         * x86-nat.c (x86_insert_watchpoint, x86_remove_watchpoint)
3078         (x86_region_ok_for_watchpoint, x86_stopped_data_address)
3079         (x86_stopped_by_watchpoint, x86_insert_hw_breakpoint)
3080         (x86_remove_hw_breakpoint, x86_can_use_hw_breakpoint)
3081         (x86_stopped_by_hw_breakpoint): Remove target_ops parameter and
3082         make extern.
3083         (x86_use_watchpoints): Delete.
3084         * x86-nat.h: Include "breakpoint.h" and "target.h".
3085         (x86_use_watchpoints): Delete.
3086         (x86_can_use_hw_breakpoint, x86_region_ok_for_hw_watchpoint)
3087         (x86_stopped_by_watchpoint, x86_stopped_data_address)
3088         (x86_insert_watchpoint, x86_remove_watchpoint)
3089         (x86_insert_hw_breakpoint, x86_remove_hw_breakpoint)
3090         (x86_stopped_by_hw_breakpoint): New declarations.
3091         (x86_nat_target): New template class.
3092
3093         * ppc-linux-nat.c (ppc_linux_nat_target): New class.
3094         (the_ppc_linux_nat_target): New.
3095         (ppc_linux_fetch_inferior_registers)
3096         (ppc_linux_can_use_hw_breakpoint)
3097         (ppc_linux_region_ok_for_hw_watchpoint)
3098         (ppc_linux_ranged_break_num_registers)
3099         (ppc_linux_insert_hw_breakpoint, ppc_linux_remove_hw_breakpoint)
3100         (ppc_linux_insert_mask_watchpoint)
3101         (ppc_linux_remove_mask_watchpoint)
3102         (ppc_linux_can_accel_watchpoint_condition)
3103         (ppc_linux_insert_watchpoint, ppc_linux_remove_watchpoint)
3104         (ppc_linux_stopped_data_address, ppc_linux_stopped_by_watchpoint)
3105         (ppc_linux_watchpoint_addr_within_range)
3106         (ppc_linux_masked_watch_num_registers)
3107         (ppc_linux_store_inferior_registers, ppc_linux_auxv_parse)
3108         (ppc_linux_read_description): Refactor as methods of
3109         ppc_linux_nat_target.
3110         (_initialize_ppc_linux_nat): Adjust.  Set linux_target.
3111
3112         * procfs.c (procfs_xfer_partial): Delete forward declaration.
3113         (procfs_target): New class.
3114         (the_procfs_target): New.
3115         (procfs_target): Delete function.
3116         (procfs_auxv_parse, procfs_attach, procfs_detach)
3117         (procfs_fetch_registers, procfs_store_registers, procfs_wait)
3118         (procfs_xfer_partial, procfs_resume, procfs_pass_signals)
3119         (procfs_files_info, procfs_kill_inferior, procfs_mourn_inferior)
3120         (procfs_create_inferior, procfs_update_thread_list)
3121         (procfs_thread_alive, procfs_pid_to_str)
3122         (procfs_can_use_hw_breakpoint, procfs_stopped_by_watchpoint)
3123         (procfs_stopped_data_address, procfs_insert_watchpoint)
3124         (procfs_remove_watchpoint, procfs_region_ok_for_hw_watchpoint)
3125         (proc_find_memory_regions, procfs_info_proc)
3126         (procfs_make_note_section): Refactor as methods of procfs_target.
3127         (_initialize_procfs): Adjust.
3128         * sol-thread.c (sol_thread_target): New class.
3129         (sol_thread_ops): Now a sol_thread_target.
3130         (sol_thread_detach, sol_thread_resume, sol_thread_wait)
3131         (sol_thread_fetch_registers, sol_thread_store_registers)
3132         (sol_thread_xfer_partial, sol_thread_mourn_inferior)
3133         (sol_thread_alive, solaris_pid_to_str, sol_update_thread_list)
3134         (sol_get_ada_task_ptid): Refactor as methods of sol_thread_target.
3135         (init_sol_thread_ops): Delete.
3136         (_initialize_sol_thread): Adjust.  Remove references to
3137         init_sol_thread_ops and complete_target_initialization.
3138
3139         * windows-nat.c (windows_nat_target): New class.
3140         (windows_fetch_inferior_registers)
3141         (windows_store_inferior_registers, windows_resume, windows_wait)
3142         (windows_attach, windows_detach, windows_pid_to_exec_file)
3143         (windows_files_info, windows_create_inferior)
3144         (windows_mourn_inferior, windows_interrupt, windows_kill_inferior)
3145         (windows_close, windows_pid_to_str, windows_xfer_partial)
3146         (windows_get_tib_address, windows_get_ada_task_ptid)
3147         (windows_thread_name, windows_thread_alive): Refactor as
3148         windows_nat_target methods.
3149         (do_initial_windows_stuff): Adjust.
3150         (windows_target): Delete function.
3151         (_initialize_windows_nat): Adjust.
3152
3153         * darwin-nat.c (darwin_resume, darwin_wait_to, darwin_interrupt)
3154         (darwin_mourn_inferior, darwin_kill_inferior)
3155         (darwin_create_inferior, darwin_attach, darwin_detach)
3156         (darwin_pid_to_str, darwin_thread_alive, darwin_xfer_partial)
3157         (darwin_pid_to_exec_file, darwin_get_ada_task_ptid)
3158         (darwin_supports_multi_process): Refactor as darwin_nat_target
3159         methods.
3160         (darwin_resume_to, darwin_files_info): Delete.
3161         (_initialize_darwin_inferior): Rename to ...
3162         (_initialize_darwin_nat): ... this.  Adjust to C++ification.
3163         * darwin-nat.h: Include "inf-child.h".
3164         (darwin_nat_target): New class.
3165         (darwin_complete_target): Delete.
3166         * i386-darwin-nat.c (i386_darwin_nat_target): New class.
3167         (darwin_target): New.
3168         (i386_darwin_fetch_inferior_registers)
3169         (i386_darwin_store_inferior_registers): Refactor as methods of
3170         darwin_nat_target.
3171         (darwin_complete_target): Delete, with ...
3172         (_initialize_i386_darwin_nat): ... bits factored out here.
3173
3174         * alpha-linux-nat.c (alpha_linux_nat_target): New class.
3175         (the_alpha_linux_nat_target): New.
3176         (alpha_linux_register_u_offset): Refactor as
3177         alpha_linux_nat_target method.
3178         (_initialize_alpha_linux_nat): Adjust.
3179         * linux-nat-trad.c (inf_ptrace_register_u_offset): Delete.
3180         (inf_ptrace_fetch_register, inf_ptrace_fetch_registers)
3181         (inf_ptrace_store_register, inf_ptrace_store_registers): Refact as
3182         methods of linux_nat_trad_target.
3183         (linux_trad_target): Delete.
3184         * linux-nat-trad.h (linux_trad_target): Delete function.
3185         (linux_nat_trad_target): New class.
3186         * mips-linux-nat.c (mips_linux_nat_target): New class.
3187         (super_fetch_registers, super_store_registers, super_close):
3188         Delete.
3189         (the_mips_linux_nat_target): New.
3190         (mips64_linux_regsets_fetch_registers)
3191         (mips64_linux_regsets_store_registers)
3192         (mips64_linux_fetch_registers, mips64_linux_store_registers)
3193         (mips_linux_register_u_offset, mips_linux_read_description)
3194         (mips_linux_can_use_hw_breakpoint)
3195         (mips_linux_stopped_by_watchpoint)
3196         (mips_linux_stopped_data_address)
3197         (mips_linux_region_ok_for_hw_watchpoint)
3198         (mips_linux_insert_watchpoint, mips_linux_remove_watchpoint)
3199         (mips_linux_close): Refactor as methods of mips_linux_nat.
3200         (_initialize_mips_linux_nat): Adjust to C++ification.
3201
3202         * aix-thread.c (aix_thread_target): New class.
3203         (aix_thread_ops): Now an aix_thread_target.
3204         (aix_thread_detach, aix_thread_resume, aix_thread_wait)
3205         (aix_thread_fetch_registers, aix_thread_store_registers)
3206         (aix_thread_xfer_partial, aix_thread_mourn_inferior)
3207         (aix_thread_thread_alive, aix_thread_pid_to_str)
3208         (aix_thread_extra_thread_info, aix_thread_get_ada_task_ptid):
3209         Refactor as methods of aix_thread_target.
3210         (init_aix_thread_ops): Delete.
3211         (_initialize_aix_thread): Remove references to init_aix_thread_ops
3212         and complete_target_initialization.
3213         * rs6000-nat.c (rs6000_xfer_shared_libraries): Delete.
3214         (rs6000_nat_target): New class.
3215         (the_rs6000_nat_target): New.
3216         (rs6000_fetch_inferior_registers, rs6000_store_inferior_registers)
3217         (rs6000_xfer_partial, rs6000_wait, rs6000_create_inferior)
3218         (rs6000_xfer_shared_libraries): Refactor as rs6000_nat_target methods.
3219         (super_create_inferior): Delete.
3220         (_initialize_rs6000_nat): Adjust to C++ification.
3221
3222         * arm-linux-nat.c (arm_linux_nat_target): New class.
3223         (the_arm_linux_nat_target): New.
3224         (arm_linux_fetch_inferior_registers)
3225         (arm_linux_store_inferior_registers, arm_linux_read_description)
3226         (arm_linux_can_use_hw_breakpoint, arm_linux_insert_hw_breakpoint)
3227         (arm_linux_remove_hw_breakpoint)
3228         (arm_linux_region_ok_for_hw_watchpoint)
3229         (arm_linux_insert_watchpoint, arm_linux_remove_watchpoint)
3230         (arm_linux_stopped_data_address, arm_linux_stopped_by_watchpoint)
3231         (arm_linux_watchpoint_addr_within_range): Refactor as methods of
3232         arm_linux_nat_target.
3233         (_initialize_arm_linux_nat): Adjust to C++ification.
3234
3235         * aarch64-linux-nat.c (aarch64_linux_nat_target): New class.
3236         (the_aarch64_linux_nat_target): New.
3237         (aarch64_linux_fetch_inferior_registers)
3238         (aarch64_linux_store_inferior_registers)
3239         (aarch64_linux_child_post_startup_inferior)
3240         (aarch64_linux_read_description)
3241         (aarch64_linux_can_use_hw_breakpoint)
3242         (aarch64_linux_insert_hw_breakpoint)
3243         (aarch64_linux_remove_hw_breakpoint)
3244         (aarch64_linux_insert_watchpoint, aarch64_linux_remove_watchpoint)
3245         (aarch64_linux_region_ok_for_hw_watchpoint)
3246         (aarch64_linux_stopped_data_address)
3247         (aarch64_linux_stopped_by_watchpoint)
3248         (aarch64_linux_watchpoint_addr_within_range)
3249         (aarch64_linux_can_do_single_step): Refactor as methods of
3250         aarch64_linux_nat_target.
3251         (super_post_startup_inferior): Delete.
3252         (_initialize_aarch64_linux_nat): Adjust to C++ification.
3253
3254         * hppa-linux-nat.c (hppa_linux_nat_target): New class.
3255         (the_hppa_linux_nat_target): New.
3256         (hppa_linux_fetch_inferior_registers)
3257         (hppa_linux_store_inferior_registers): Refactor as methods of
3258         hppa_linux_nat_target.
3259         (_initialize_hppa_linux_nat): Adjust to C++ification.
3260
3261         * ia64-linux-nat.c (ia64_linux_nat_target): New class.
3262         (the_ia64_linux_nat_target): New.
3263         (ia64_linux_insert_watchpoint, ia64_linux_remove_watchpoint)
3264         (ia64_linux_stopped_data_address)
3265         (ia64_linux_stopped_by_watchpoint, ia64_linux_fetch_registers)
3266         (ia64_linux_store_registers, ia64_linux_xfer_partial): Refactor as
3267         ia64_linux_nat_target methods.
3268         (super_xfer_partial): Delete.
3269         (_initialize_ia64_linux_nat): Adjust to C++ification.
3270
3271         * m32r-linux-nat.c (m32r_linux_nat_target): New class.
3272         (the_m32r_linux_nat_target): New.
3273         (m32r_linux_fetch_inferior_registers)
3274         (m32r_linux_store_inferior_registers): Refactor as
3275         m32r_linux_nat_target methods.
3276         (_initialize_m32r_linux_nat): Adjust to C++ification.
3277
3278         * m68k-linux-nat.c (m68k_linux_nat_target): New class.
3279         (the_m68k_linux_nat_target): New.
3280         (m68k_linux_fetch_inferior_registers)
3281         (m68k_linux_store_inferior_registers): Refactor as
3282         m68k_linux_nat_target methods.
3283         (_initialize_m68k_linux_nat): Adjust to C++ification.
3284
3285         * s390-linux-nat.c (s390_linux_nat_target): New class.
3286         (the_s390_linux_nat_target): New.
3287         (s390_linux_fetch_inferior_registers)
3288         (s390_linux_store_inferior_registers, s390_stopped_by_watchpoint)
3289         (s390_insert_watchpoint, s390_remove_watchpoint)
3290         (s390_can_use_hw_breakpoint, s390_insert_hw_breakpoint)
3291         (s390_remove_hw_breakpoint, s390_region_ok_for_hw_watchpoint)
3292         (s390_auxv_parse, s390_read_description): Refactor as methods of
3293         s390_linux_nat_target.
3294         (_initialize_s390_nat): Adjust to C++ification.
3295
3296         * sparc-linux-nat.c (sparc_linux_nat_target): New class.
3297         (the_sparc_linux_nat_target): New.
3298         (_initialize_sparc_linux_nat): Adjust to C++ification.
3299         * sparc-nat.c (sparc_fetch_inferior_registers)
3300         (sparc_store_inferior_registers): Remove target_ops parameter.
3301         * sparc-nat.h (sparc_fetch_inferior_registers)
3302         (sparc_store_inferior_registers): Remove target_ops parameter.
3303         * sparc64-linux-nat.c (sparc64_linux_nat_target): New class.
3304         (the_sparc64_linux_nat_target): New.
3305         (_initialize_sparc64_linux_nat): Adjust to C++ification.
3306
3307         * spu-linux-nat.c (spu_linux_nat_target): New class.
3308         (the_spu_linux_nat_target): New.
3309         (spu_child_post_startup_inferior, spu_child_post_attach)
3310         (spu_child_wait, spu_fetch_inferior_registers)
3311         (spu_store_inferior_registers, spu_xfer_partial)
3312         (spu_can_use_hw_breakpoint): Refactor as spu_linux_nat_target
3313         methods.
3314         (_initialize_spu_nat): Adjust to C++ification.
3315
3316         * tilegx-linux-nat.c (tilegx_linux_nat_target): New class.
3317         (the_tilegx_linux_nat_target): New.
3318         (fetch_inferior_registers, store_inferior_registers):
3319         Refactor as methods.
3320         (_initialize_tile_linux_nat): Adjust to C++ification.
3321
3322         * xtensa-linux-nat.c (xtensa_linux_nat_target): New class.
3323         (the_xtensa_linux_nat_target): New.
3324         (xtensa_linux_fetch_inferior_registers)
3325         (xtensa_linux_store_inferior_registers): Refactor as
3326         xtensa_linux_nat_target methods.
3327         (_initialize_xtensa_linux_nat): Adjust to C++ification.
3328
3329         * fbsd-nat.c (USE_SIGTRAP_SIGINFO): Delete.
3330         (fbsd_pid_to_exec_file, fbsd_find_memory_regions)
3331         (fbsd_find_memory_regions, fbsd_info_proc, fbsd_xfer_partial)
3332         (fbsd_thread_alive, fbsd_pid_to_str, fbsd_thread_name)
3333         (fbsd_update_thread_list, fbsd_resume, fbsd_wait)
3334         (fbsd_stopped_by_sw_breakpoint)
3335         (fbsd_supports_stopped_by_sw_breakpoint, fbsd_follow_fork)
3336         (fbsd_insert_fork_catchpoint, fbsd_remove_fork_catchpoint)
3337         (fbsd_insert_vfork_catchpoint, fbsd_remove_vfork_catchpoint)
3338         (fbsd_post_startup_inferior, fbsd_post_attach)
3339         (fbsd_insert_exec_catchpoint, fbsd_remove_exec_catchpoint)
3340         (fbsd_set_syscall_catchpoint)
3341         (super_xfer_partial, super_resume, super_wait)
3342         (fbsd_supports_stopped_by_hw_breakpoint): Delete.
3343         (fbsd_handle_debug_trap): Remove target_ops parameter.
3344         (fbsd_nat_add_target): Delete.
3345         * fbsd-nat.h: Include "inf-ptrace.h".
3346         (fbsd_nat_add_target): Delete.
3347         (USE_SIGTRAP_SIGINFO): Define.
3348         (fbsd_nat_target): New class.
3349
3350         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers)
3351         (amd64bsd_store_inferior_registers): Remove target_ops parameter.
3352         (amd64bsd_target): Delete.
3353         * amd64-bsd-nat.h: New file.
3354         * amd64-fbsd-nat.c: Include "amd64-bsd-nat.h" instead of
3355         "x86-bsd-nat.h".
3356         (amd64_fbsd_nat_target): New class.
3357         (the_amd64_fbsd_nat_target): New.
3358         (amd64fbsd_read_description): Refactor as method of
3359         amd64_fbsd_nat_target.
3360         (amd64_fbsd_nat_target::supports_stopped_by_hw_breakpoint): New.
3361         (_initialize_amd64fbsd_nat): Adjust to C++ification.
3362         * amd64-nat.h (amd64bsd_target): Delete function declaration.
3363         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers)
3364         (i386bsd_store_inferior_registers): Remove target_ops parameter.
3365         (i386bsd_target): Delete.
3366         * i386-bsd-nat.h (i386bsd_target): Delete function declaration.
3367         (i386bsd_fetch_inferior_registers)
3368         (i386bsd_store_inferior_registers): Declare.
3369         (i386_bsd_nat_target): New class.
3370         * i386-fbsd-nat.c (i386_fbsd_nat_target): New class.
3371         (the_i386_fbsd_nat_target): New.
3372         (i386fbsd_resume, i386fbsd_read_description): Refactor as
3373         i386_fbsd_nat_target methods.
3374         (i386_fbsd_nat_target::supports_stopped_by_hw_breakpoint): New.
3375         (_initialize_i386fbsd_nat): Adjust to C++ification.
3376         * x86-bsd-nat.c (super_mourn_inferior): Delete.
3377         (x86bsd_mourn_inferior, x86bsd_target): Delete.
3378         (_initialize_x86_bsd_nat): Adjust to C++ification.
3379         * x86-bsd-nat.h: Include "x86-nat.h".
3380         (x86bsd_target): Delete declaration.
3381         (x86bsd_nat_target): New class.
3382
3383         * aarch64-fbsd-nat.c (aarch64_fbsd_nat_target): New class.
3384         (the_aarch64_fbsd_nat_target): New.
3385         (aarch64_fbsd_fetch_inferior_registers)
3386         (aarch64_fbsd_store_inferior_registers): Refactor as methods of
3387         aarch64_fbsd_nat_target.
3388         (_initialize_aarch64_fbsd_nat): Adjust to C++ification.
3389         * alpha-bsd-nat.c (alpha_bsd_nat_target): New class.
3390         (the_alpha_bsd_nat_target): New.
3391         (alphabsd_fetch_inferior_registers)
3392         (alphabsd_store_inferior_registers): Refactor as
3393         alpha_bsd_nat_target methods.
3394         (_initialize_alphabsd_nat): Refactor as methods of
3395         alpha_bsd_nat_target.
3396         * amd64-nbsd-nat.c: Include "amd64-bsd-nat.h".
3397         (the_amd64_nbsd_nat_target): New.
3398         (_initialize_amd64nbsd_nat): Adjust to C++ification.
3399         * amd64-obsd-nat.c: Include "amd64-bsd-nat.h".
3400         (the_amd64_obsd_nat_target): New.
3401         (_initialize_amd64obsd_nat): Adjust to C++ification.
3402         * arm-fbsd-nat.c (arm_fbsd_nat_target): New.
3403         (the_arm_fbsd_nat_target): New.
3404         (arm_fbsd_fetch_inferior_registers)
3405         (arm_fbsd_store_inferior_registers, arm_fbsd_read_description):
3406         (_initialize_arm_fbsd_nat): Refactor as methods of
3407         arm_fbsd_nat_target.
3408         (_initialize_arm_fbsd_nat): Adjust to C++ification.
3409         * arm-nbsd-nat.c (arm_netbsd_nat_target): New class.
3410         (the_arm_netbsd_nat_target): New.
3411         (armnbsd_fetch_registers, armnbsd_store_registers): Refactor as
3412         arm_netbsd_nat_target.
3413         (_initialize_arm_netbsd_nat): Adjust to C++ification.
3414         * hppa-nbsd-nat.c (hppa_nbsd_nat_target): New class.
3415         (the_hppa_nbsd_nat_target): New.
3416         (hppanbsd_fetch_registers, hppanbsd_store_registers): Refactor as
3417         hppa_nbsd_nat_target methods.
3418         (_initialize_hppanbsd_nat): Adjust to C++ification.
3419         * hppa-obsd-nat.c (hppa_obsd_nat_target): New class.
3420         (the_hppa_obsd_nat_target): New.
3421         (hppaobsd_fetch_registers, hppaobsd_store_registers): Refactor as
3422         methods of hppa_obsd_nat_target.
3423         (_initialize_hppaobsd_nat): Adjust to C++ification.  Use
3424         add_target.
3425         * i386-nbsd-nat.c (the_i386_nbsd_nat_target): New.
3426         (_initialize_i386nbsd_nat): Adjust to C++ification.  Use
3427         add_target.
3428         * i386-obsd-nat.c (the_i386_obsd_nat_target): New.
3429         (_initialize_i386obsd_nat): Use add_target.
3430         * m68k-bsd-nat.c (m68k_bsd_nat_target): New class.
3431         (the_m68k_bsd_nat_target): New.
3432         (m68kbsd_fetch_inferior_registers)
3433         (m68kbsd_store_inferior_registers): Refactor as methods of
3434         m68k_bsd_nat_target.
3435         (_initialize_m68kbsd_nat): Adjust to C++ification.
3436         * mips-fbsd-nat.c (mips_fbsd_nat_target): New class.
3437         (the_mips_fbsd_nat_target): New.
3438         (mips_fbsd_fetch_inferior_registers)
3439         (mips_fbsd_store_inferior_registers): Refactor as methods of
3440         mips_fbsd_nat_target.
3441         (_initialize_mips_fbsd_nat): Adjust to C++ification.  Use
3442         add_target.
3443         * mips-nbsd-nat.c (mips_nbsd_nat_target): New class.
3444         (the_mips_nbsd_nat_target): New.
3445         (mipsnbsd_fetch_inferior_registers)
3446         (mipsnbsd_store_inferior_registers): Refactor as methods of
3447         mips_nbsd_nat_target.
3448         (_initialize_mipsnbsd_nat): Adjust to C++ification.
3449         * mips64-obsd-nat.c (mips64_obsd_nat_target): New class.
3450         (the_mips64_obsd_nat_target): New.
3451         (mips64obsd_fetch_inferior_registers)
3452         (mips64obsd_store_inferior_registers): Refactor as methods of
3453         mips64_obsd_nat_target.
3454         (_initialize_mips64obsd_nat): Adjust to C++ification.  Use
3455         add_target.
3456         * nbsd-nat.c (nbsd_pid_to_exec_file): Refactor as method of
3457         nbsd_nat_target.
3458         * nbsd-nat.h: Include "inf-ptrace.h".
3459         (nbsd_nat_target): New class.
3460         * obsd-nat.c (obsd_pid_to_str, obsd_update_thread_list)
3461         (obsd_wait): Refactor as methods of obsd_nat_target.
3462         (obsd_add_target): Delete.
3463         * obsd-nat.h: Include "inf-ptrace.h".
3464         (obsd_nat_target): New class.
3465         * ppc-fbsd-nat.c (ppc_fbsd_nat_target): New class.
3466         (the_ppc_fbsd_nat_target): New.
3467         (ppcfbsd_fetch_inferior_registers)
3468         (ppcfbsd_store_inferior_registers): Refactor as methods of
3469         ppc_fbsd_nat_target.
3470         (_initialize_ppcfbsd_nat): Adjust to C++ification.  Use
3471         add_target.
3472         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): New class.
3473         (the_ppc_nbsd_nat_target): New.
3474         (ppcnbsd_fetch_inferior_registers)
3475         (ppcnbsd_store_inferior_registers): Refactor as methods of
3476         ppc_nbsd_nat_target.
3477         (_initialize_ppcnbsd_nat): Adjust to C++ification.
3478         * ppc-obsd-nat.c (ppc_obsd_nat_target): New class.
3479         (the_ppc_obsd_nat_target): New.
3480         (ppcobsd_fetch_registers, ppcobsd_store_registers): Refactor as
3481         methods of ppc_obsd_nat_target.
3482         (_initialize_ppcobsd_nat): Adjust to C++ification.  Use
3483         add_target.
3484         * sh-nbsd-nat.c (sh_nbsd_nat_target): New class.
3485         (the_sh_nbsd_nat_target): New.
3486         (shnbsd_fetch_inferior_registers)
3487         (shnbsd_store_inferior_registers): Refactor as methods of
3488         sh_nbsd_nat_target.
3489         (_initialize_shnbsd_nat): Adjust to C++ification.
3490         * sparc-nat.c (sparc_xfer_wcookie): Make extern.
3491         (inf_ptrace_xfer_partial): Delete.
3492         (sparc_xfer_partial, sparc_target): Delete.
3493         * sparc-nat.h (sparc_fetch_inferior_registers)
3494         (sparc_store_inferior_registers, sparc_xfer_wcookie): Declare.
3495         (sparc_target): Delete function declaration.
3496         (sparc_target): New template class.
3497         * sparc-nbsd-nat.c (the_sparc_nbsd_nat_target): New.
3498         (_initialize_sparcnbsd_nat): Adjust to C++ification.
3499         * sparc64-fbsd-nat.c (the_sparc64_fbsd_nat_target): New.
3500         (_initialize_sparc64fbsd_nat): Adjust to C++ification.  Use
3501         add_target.
3502         * sparc64-nbsd-nat.c (the_sparc64_nbsd_nat_target): New.
3503         (_initialize_sparc64nbsd_nat): Adjust to C++ification.
3504         * sparc64-obsd-nat.c (the_sparc64_obsd_nat_target): New.
3505         (_initialize_sparc64obsd_nat): Adjust to C++ification.  Use
3506         add_target.
3507         * vax-bsd-nat.c (vax_bsd_nat_target): New class.
3508         (the_vax_bsd_nat_target): New.
3509         (vaxbsd_fetch_inferior_registers)
3510         (vaxbsd_store_inferior_registers): Refactor as vax_bsd_nat_target
3511         methods.
3512         (_initialize_vaxbsd_nat): Adjust to C++ification.
3513
3514         * bsd-kvm.c (bsd_kvm_target): New class.
3515         (bsd_kvm_ops): Now a bsd_kvm_target.
3516         (bsd_kvm_open, bsd_kvm_close, bsd_kvm_xfer_partial)
3517         (bsd_kvm_files_info, bsd_kvm_fetch_registers)
3518         (bsd_kvm_thread_alive, bsd_kvm_pid_to_str): Refactor as methods of
3519         bsd_kvm_target.
3520         (bsd_kvm_return_one): Delete.
3521         (bsd_kvm_add_target): Adjust to C++ification.
3522
3523         * nto-procfs.c (nto_procfs_target, nto_procfs_target_native)
3524         (nto_procfs_target_procfs): New classes.
3525         (procfs_open_1, procfs_thread_alive, procfs_update_thread_list)
3526         (procfs_files_info, procfs_pid_to_exec_file, procfs_attach)
3527         (procfs_post_attach, procfs_wait, procfs_fetch_registers)
3528         (procfs_xfer_partial, procfs_detach, procfs_insert_breakpoint)
3529         (procfs_remove_breakpoint, procfs_insert_hw_breakpoint)
3530         (procfs_remove_hw_breakpoint, procfs_resume)
3531         (procfs_mourn_inferior, procfs_create_inferior, procfs_interrupt)
3532         (procfs_kill_inferior, procfs_store_registers)
3533         (procfs_pass_signals, procfs_pid_to_str, procfs_can_run): Refactor
3534         as methods of nto_procfs_target.
3535         (nto_procfs_ops): Now an nto_procfs_target_procfs.
3536         (nto_native_ops): Delete.
3537         (procfs_open, procfs_native_open): Delete.
3538         (nto_native_ops): Now an nto_procfs_target_native.
3539         (init_procfs_targets): Adjust to C++ification.
3540         (procfs_can_use_hw_breakpoint, procfs_remove_hw_watchpoint)
3541         (procfs_insert_hw_watchpoint, procfs_stopped_by_watchpoint):
3542         Refactor as methods of nto_procfs_target.
3543
3544         * go32-nat.c (go32_nat_target): New class.
3545         (the_go32_nat_target): New.
3546         (go32_attach, go32_resume, go32_wait, go32_fetch_registers)
3547         (go32_store_registers, go32_xfer_partial, go32_files_info)
3548         (go32_kill_inferior, go32_create_inferior, go32_mourn_inferior)
3549         (go32_terminal_init, go32_terminal_info, go32_terminal_inferior)
3550         (go32_terminal_ours, go32_pass_ctrlc, go32_thread_alive)
3551         (go32_pid_to_str): Refactor as methods of go32_nat_target.
3552         (go32_target): Delete.
3553         (_initialize_go32_nat): Adjust to C++ification.
3554
3555         * gnu-nat.c (gnu_wait, gnu_resume, gnu_kill_inferior)
3556         (gnu_mourn_inferior, gnu_create_inferior, gnu_attach, gnu_detach)
3557         (gnu_stop, gnu_thread_alive, gnu_xfer_partial)
3558         (gnu_find_memory_regions, gnu_pid_to_str): Refactor as methods of
3559         gnu_nat_target.
3560         (gnu_target): Delete.
3561         * gnu-nat.h (gnu_target): Delete.
3562         (gnu_nat_target): New class.
3563         * i386-gnu-nat.c (gnu_base_target): New.
3564         (i386_gnu_nat_target): New class.
3565         (the_i386_gnu_nat_target): New.
3566         (_initialize_i386gnu_nat): Adjust to C++ification.
3567
3568 2018-05-02  Pedro Alves  <palves@redhat.com>
3569
3570         * bfd-target.c (target_bfd_xclose): Rename to ...
3571         (target_bfd_close): ... this.
3572         (target_bfd_reopen): Adjust.
3573         * target.c (target_close): Remove references to to_xclose.
3574         * target.h (target_ops::to_xclose): Delete.
3575         (target_ops::to_close): Update comments.
3576
3577 2018-05-02  Pedro Alves  <palves@redhat.com>
3578
3579         * alpha-linux-nat.c: Include "linux-nat-trad.h" instead of
3580         "linux-nat.h".
3581         * configure.nat (alpha-linux, linux-mips): Add linux-nat-trad.o.
3582         * inf-ptrace.c (inf_ptrace_register_u_offset)
3583         (inf_ptrace_fetch_register, inf_ptrace_fetch_registers)
3584         (inf_ptrace_store_register, inf_ptrace_store_registers)
3585         (inf_ptrace_trad_target): Move to ...
3586         * linux-nat-trad.c: ... this new file.
3587         * linux-nat-trad.h: New file.
3588         * linux-nat.c (linux_target_install_ops): Make extern.
3589         (linux_trad_target): Delete.
3590         * linux-nat.h (linux_trad_target): Delete declaration.
3591         (linux_target_install_ops): Declare.
3592         * mips-linux-nat.c: Include "linux-nat-trad.h" instead of
3593         "linux-nat.h".
3594
3595 2018-05-02  Pedro Alves  <palves@redhat.com>
3596
3597         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Don't call
3598         procfs_target/add_target here.
3599         * procfs.c (procfs_target): Make static.
3600         (_initialize_procfs): Call add_target here.
3601         * procfs.h (struct target_ops): Remove forward declaration.
3602         (procfs_target): Remove declaration.
3603         * sparc-sol2-nat.c (_initialize_sparc_sol2_nat): Delete.
3604
3605 2018-05-02  Pedro Alves  <palves@redhat.com>
3606
3607         * procfs.c (procfs_stopped_by_watchpoint)
3608         (procfs_insert_watchpoint, procfs_remove_watchpoint)
3609         (procfs_region_ok_for_hw_watchpoint, procfs_stopped_data_address):
3610         Forward declare.
3611         (procfs_use_watchpoints): Delete, move contents...
3612         (procfs_target): ... here.
3613         * procfs.h (procfs_use_watchpoints): Delete declaration.
3614         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Don't call
3615         procfs_use_watchpoints.
3616         * sparc-sol2-nat.c (_initialize_sparc_sol2_nat): Don't call
3617         procfs_use_watchpoints.
3618
3619 2018-05-02  Tom Tromey  <tom@tromey.com>
3620
3621         PR python/20084:
3622         * python/python.c (gdbpy_parameter_value): Handle var_zuinteger
3623         and var_zuinteger_unlimited.
3624         * python/py-param.c (struct parm_constant): Add PARAM_ZUINTEGER
3625         and PARAM_ZUINTEGER_UNLIMITED.
3626         (set_parameter_value): Handle var_zuinteger and
3627         var_zuinteger_unlimited.
3628         (add_setshow_generic): Likewise.
3629         (parmpy_init): Likewise.
3630
3631 2018-04-28  Dan Robertson  <danlrobertson89@gmail.com>
3632
3633         PR rust/23124
3634         * gdb/rust-exp.y (convert_params_to_types): Ensure that the params
3635         pointer is not null before dereferencing it.
3636
3637 2018-04-30  Tom Tromey  <tom@tromey.com>
3638
3639         * darwin-nat-info.c (darwin_debug_regions_recurse): Remove use of
3640         is_mi_like_p.
3641
3642 2018-04-30  Tom Tromey  <tom@tromey.com>
3643
3644         * breakpoint.c (mention): Remove use of is_mi_like_p.
3645         (print_mention_ranged_breakpoint): Likewise.
3646         * break-catch-throw.c (print_it_exception_catchpoint): Remove use
3647         of is_mi_like_p.
3648
3649 2018-04-30  Tom Tromey  <tom@tromey.com>
3650
3651         * tracepoint.c (tvariables_info_1): Remove use of is_mi_like_p.
3652
3653 2018-04-30  Tom Tromey  <tom@tromey.com>
3654
3655         * spu-tdep.c (info_spu_mailbox_list, info_spu_dma_cmdlist)
3656         (info_spu_event_command): Remove some uses of is_mi_like_p.
3657
3658 2018-04-30  Tom Tromey  <tom@tromey.com>
3659
3660         * python/py-framefilter.c (py_print_single_arg)
3661         (enumerate_locals, py_print_args, py_print_frame): Remove some
3662         uses of is_mi_like_p.
3663
3664 2018-04-30  Tom Tromey  <tom@tromey.com>
3665
3666         * ui-out.c: Update.
3667         * cli-out.h (cli_ui_out::do_is_mi_like_p): Update.
3668         * ui-out.h (ui_out::is_mi_like_p): Now const.
3669         (ui_out::do_is_mi_like_p): Now const.
3670         * mi/mi-out.h (mi_ui_out::do_is_mi_like_p): Update.
3671
3672 2018-04-30  Tom Tromey  <tom@tromey.com>
3673
3674         * varobj.c (varobj_set_visualizer): Use new_reference.
3675         * python/python.c (gdbpy_decode_line): Use new_reference.
3676         * python/py-cmd.c (cmdpy_function, cmdpy_completer_helper): Use
3677         new_reference.
3678
3679 2018-04-30  Tom Tromey  <tom@tromey.com>
3680
3681         * varobj.c (install_new_value): Use new_reference.
3682         * value.h (value_incref): Return void.  Swap intro comment with
3683         value_decref.
3684         * value.c (set_value_parent): Use new_reference.
3685         (value_incref): Return void.  Update intro comment.
3686         (release_value): Use new_reference.
3687         * dwarf2loc.c (dwarf2_evaluate_loc_desc_full): Use new_reference.
3688
3689 2018-04-30  Tom Tromey  <tom@tromey.com>
3690
3691         * symfile-mem.c (symbol_file_add_from_memory): Use new_reference.
3692         * gdb_bfd.h (new_bfd_ref): Remove.
3693         (gdb_bfd_open): Update comment.
3694         * gdb_bfd.c (gdb_bfd_open, gdb_bfd_fopen, gdb_bfd_openr)
3695         (gdb_bfd_openw, gdb_bfd_openr_iovec, gdb_bfd_record_inclusion)
3696         (gdb_bfd_fdopenr): Use new_reference.
3697         * exec.c (exec_file_attach): Use new_reference.
3698
3699 2018-04-30  Tom Tromey  <tom@tromey.com>
3700
3701         * common/gdb_ref_ptr.h (ref_ptr::new_reference): New static
3702         method.
3703
3704 2018-04-30  Tom Tromey  <tom@tromey.com>
3705
3706         * jit.c (jit_read_code_entry): Use type_align.
3707         * i386-tdep.c (i386_gdbarch_init): Don't call
3708         set_gdbarch_long_long_align_bit.
3709         * gdbarch.sh: Remove long_long_align_bit.
3710         * gdbarch.c, gdbarch.h: Rebuild.
3711         * arc-tdep.c (arc_type_align): New function.
3712         (arc_gdbarch_init): Use arc_type_align.  Don't call
3713         set_gdbarch_long_long_align_bit.
3714
3715 2018-04-30  Tom Tromey  <tom@tromey.com>
3716
3717         * rust-lang.c (rust_type_alignment): Remove.
3718         (rust_composite_type): Use type_align.
3719
3720 2018-04-30  Tom Tromey  <tom@tromey.com>
3721
3722         * NEWS: Mention Type.align.
3723         * python/py-type.c (typy_get_alignof): New function.
3724         (type_object_getset): Add "alignof".
3725
3726 2018-04-30  Tom Tromey  <tom@tromey.com>
3727
3728         PR exp/17095:
3729         * NEWS: Update.
3730         * std-operator.def (UNOP_ALIGNOF): New operator.
3731         * expprint.c (dump_subexp_body_standard) <case UNOP_ALIGNOF>:
3732         New.
3733         * eval.c (evaluate_subexp_standard) <case UNOP_ALIGNOF>: New.
3734         * c-lang.c (c_op_print_tab): Add alignof.
3735         * c-exp.y (ALIGNOF): New token.
3736         (exp): Add "ALIGNOF" production.
3737         (ident_tokens): Add _Alignof and alignof.
3738
3739 2018-04-30  Tom Tromey  <tom@tromey.com>
3740
3741         * i386-tdep.c (i386_type_align): New function.
3742         (i386_gdbarch_init): Update.
3743         * gdbarch.sh (type_align): New method.
3744         * gdbarch.c, gdbarch.h: Rebuild.
3745         * arch-utils.h (default_type_align): Declare.
3746         * arch-utils.c (default_type_align): New function.
3747         * gdbtypes.h (TYPE_ALIGN_BITS): New define.
3748         (struct type) <align_log2>: New field.
3749         <instance_flags>: Now a bitfield.
3750         (TYPE_RAW_ALIGN): New macro.
3751         (type_align, type_raw_align, set_type_align): Declare.
3752         * gdbtypes.c (type_align, type_raw_align, set_type_align): New
3753         functions.
3754         * dwarf2read.c (quirk_rust_enum): Set type alignment.
3755         (get_alignment, maybe_set_alignment): New functions.
3756         (read_structure_type, read_enumeration_type, read_array_type)
3757         (read_set_type, read_tag_pointer_type, read_tag_reference_type)
3758         (read_subrange_type, read_base_type): Set type alignment.
3759
3760 2018-04-30  Simon Marchi  <simon.marchi@ericsson.com>
3761
3762         * dwarf2read.c (read_index_from_section): Use bool.
3763
3764 2018-04-29  Fabian Groffen  <grobian@gentoo.org>
3765
3766         PR gdb/22950
3767         * proc-events.c (init_syscall_table): Guard usage os SYS_uuidsys
3768         with #ifdef.
3769
3770 2018-04-29  John Reiser  <jreiser@BitWagon.com>
3771
3772         PR build/22873
3773         * gdb/Makefile.in: (.c:.l, .c:.y): Write the target only in the
3774         last step, and do it atomically.
3775
3776 2018-04-27  Alexandre Oliva  <aoliva@redhat.com>
3777
3778         * compile/compile-c-types.c (convert_int, convert_float):
3779         Update for C FE v1.
3780
3781 2018-04-27  Tom Tromey  <tom@tromey.com>
3782
3783         PR rust/22545:
3784         * rust-lang.c (rust_inclusive_range_type_p): New function.
3785         (rust_range): Handle inclusive ranges.
3786         (rust_compute_range): Likewise.
3787         * rust-exp.y (struct rust_op) <inclusive>: New field.
3788         (DOTDOTEQ): New constant.
3789         (range_expr): Add "..=" productions.
3790         (operator_tokens): Add "..=" token.
3791         (ast_range): Add "inclusive" parameter.
3792         (convert_ast_to_expression) <case OP_RANGE>: Handle inclusive
3793         ranges.
3794         * parse.c (operator_length_standard) <case OP_RANGE>: Handle new
3795         bounds values.
3796         * expression.h (enum range_type) <NONE_BOUND_DEFAULT_EXCLUSIVE,
3797         LOW_BOUND_DEFAULT_EXCLUSIVE>: New constants.
3798         Update comments.
3799         * expprint.c (print_subexp_standard): Handle new bounds values.
3800         (dump_subexp_body_standard): Likewise.
3801
3802 2018-04-27  Tom Tromey  <tom@tromey.com>
3803
3804         * configure: Rebuild.
3805         * warning.m4 (AM_GDB_WARNINGS): Add -Wsuggest-override.
3806         * dwarf2loc.c (class dwarf_evaluate_loc_desc): Use "override", not
3807         "OVERRIDE".
3808         (class symbol_needs_eval_context): Likewise.
3809         * dwarf2read.c (mock_mapped_index::symbol_name_count)
3810         (mock_mapped_index::symbol_name_at): Use "override".  Remove
3811         "virtual".
3812         * dwarf2-frame.c (dwarf_expr_executor::get_addr_index): Use
3813         "override".
3814         (class dwarf_expr_executor): Use "override", not "OVERRIDE".
3815         * aarch64-tdep.c (instruction_reader::read): Use "override".
3816         (instruction_reader_test::read): Likewise.
3817         * arm-tdep.c (instruction_reader::read): Use "override".
3818         (instruction_reader_thumb::read): Likewise.
3819
3820 2018-04-26  Andrzej Kaczmarek  <andrzej.kaczmarek@codecoup.pl>
3821
3822         PR remote/9665
3823         * remote.c (send_g_packet): Use putpkt/getpkt/packet_check_result
3824         instead of remote_send.
3825         (remote_send): Remove.
3826
3827 2018-04-26  Pedro Alves  <palves@redhat.com>
3828
3829         * elfread.c (elf_gnu_ifunc_resolver_return_stop): Use
3830         find_function_start_sal instead of find_pc_line.
3831
3832 2018-04-26  Pedro Alves  <palves@redhat.com>
3833
3834         * breakpoint.c (set_breakpoint_location_function): Handle
3835         mst_data_gnu_ifunc.
3836         * c-exp.y (variable production): Handle mst_data_gnu_ifunc.
3837         * elfread.c (elf_symtab_read): Give data symbols with
3838         BSF_GNU_INDIRECT_FUNCTION set mst_data_gnu_ifunc type.
3839         (elf_rel_plt_read): Update comment.
3840         * linespec.c (convert_linespec_to_sals): Handle
3841         mst_data_gnu_ifunc.
3842         (minsym_found): Handle mst_data_gnu_ifunc.
3843         * minsyms.c (msymbol_is_function, minimal_symbol_reader::record)
3844         (find_solib_trampoline_target): Handle mst_data_gnu_ifunc.
3845         * parse.c (find_minsym_type_and_address): Handle
3846         mst_data_gnu_ifunc.
3847         * symmisc.c (dump_msymbols): Handle mst_data_gnu_ifunc.
3848         * symtab.c (find_gnu_ifunc): Handle mst_data_gnu_ifunc.
3849         * symtab.h (minimal_symbol_type) <mst_text_gnu_ifunc>: Update
3850         comment.
3851         <mst_data_gnu_ifunc>: New enumerator.
3852
3853 2018-04-26  Pedro Alves  <palves@redhat.com>
3854
3855         * minsyms.c (lookup_minimal_symbol_by_pc_section_1): Rename to ...
3856         (lookup_minimal_symbol_by_pc_section): ... this.  Replace
3857         'want_trampoline' parameter by a lookup_msym_prefer parameter.
3858         Handle it.
3859         (lookup_minimal_symbol_by_pc_section): Delete old implementation.
3860         (lookup_minimal_symbol_by_pc): Adjust.
3861         (in_gnu_ifunc_stub): Prefer GNU ifunc symbols.
3862         (lookup_solib_trampoline_symbol_by_pc): Adjust.
3863         * minsyms.h (lookup_msym_prefer): New enum.
3864         (lookup_minimal_symbol_by_pc_section): Replace 'want_trampoline'
3865         parameter by a lookup_msym_prefer parameter.
3866
3867 2018-04-26  Pedro Alves  <palves@redhat.com>
3868
3869         * elfread.c (elf_gnu_ifunc_record_cache): Check if the symbol name
3870         ends in "@plt" instead of looking at the symbol's section.
3871
3872 2018-04-26  Pedro Alves  <palves@redhat.com>
3873
3874         * blockframe.c (cache_pc_function_is_gnu_ifunc): Delete.  Remove
3875         all references.
3876         (find_pc_partial_function_gnu_ifunc): Rename to ...
3877         (find_pc_partial_function): ... this, and remove references to
3878         'is_gnu_ifunc_p'.
3879         (find_pc_partial_function): Delete old implementation.
3880         * symtab.h (find_pc_partial_function_gnu_ifunc): Delete.
3881
3882 2018-04-26  Pedro Alves  <palves@redhat.com>
3883
3884         * linespec.c (struct bound_minimal_symbol_search_key): New.
3885         (convert_linespec_to_sals): Sort minimal symbols earlier.  Don't
3886         skip first line if we found a GNU ifunc minimal symbol by name.
3887         (compare_msymbols): Change parameters to work with a destructured
3888         lhs minsym.
3889         (compare_msymbols_for_qsort, compare_msymbols_for_bsearch): New
3890         functions.
3891
3892 2018-04-26  Pedro Alves  <palves@redhat.com>
3893
3894         * breakpoint.c (set_breakpoint_location_function): Don't resolve
3895         ifunc targets here.  Instead, if we have an ifunc minsym, use its
3896         address/name.
3897         (add_location_to_breakpoint): Store the minsym and the objfile in
3898         the breakpoint location.
3899         * breakpoint.h (bp_location) <msymbol, objfile>: New fields.
3900         * linespec.c (minsym_found): Resolve GNU ifunc targets here.
3901         Record the minsym in the sal.
3902         * symtab.h (symtab_and_line) <msymbol>: New field.
3903
3904 2018-04-26  Pedro Alves  <palves@redhat.com>
3905
3906         * elfread.c (elf_gnu_ifunc_resolve_by_got): Don't write to *ADDR_P
3907         unless we actually resolved the ifunc.
3908
3909 2018-04-26  Pedro Alves  <palves@redhat.com>
3910
3911         * c-exp.y (variable production): Prefer ifunc minsyms over
3912         regular function symbols.
3913         * symtab.c (find_gnu_ifunc): New function.
3914         * minsyms.h (lookup_msym_prefer): New enum.
3915         (lookup_minimal_symbol_by_pc_section): Replace 'want_trampoline'
3916         parameter by a lookup_msym_prefer parameter.
3917         * symtab.h (find_gnu_ifunc): New declaration.
3918
3919 2018-04-26  Pedro Alves  <palves@redhat.com>
3920
3921         * blockframe.c (find_gnu_ifunc_target_type): New function.
3922         (find_function_type): New.
3923         * eval.c (evaluate_var_msym_value): For GNU ifunc types, always
3924         return a value with a memory address.
3925         (eval_call): For calls to GNU ifunc functions, try to find the
3926         type of the target function from the type that the resolver
3927         returns.
3928         * gdbtypes.c (objfile_type): Don't install a return type for ifunc
3929         symbols.
3930         * infcall.c (find_function_return_type): Delete.
3931         (find_function_addr): Add 'function_type' parameter.  For calls to
3932         GNU ifunc functions, try to find the type of the target function
3933         from the type that the resolver returns, and return it via
3934         FUNCTION_TYPE.
3935         (call_function_by_hand_dummy): Adjust to use the function type
3936         returned by find_function_addr.
3937         (find_function_addr): Add 'function_type' parameter and move
3938         description here.
3939         * symtab.h (find_function_type, find_gnu_ifunc_target_type): New
3940         declarations.
3941
3942 2018-04-26  Pedro Alves  <palves@redhat.com>
3943
3944         * c-exp.y (variable production): Skip finding an alias for ifunc
3945         symbols.
3946
3947 2018-04-26  Pedro Alves  <palves@redhat.com>
3948
3949         * elfread.c (elf_rel_plt_read): Look for relocations for .got.plt too.
3950
3951 2018-04-25  Pedro Alves  <palves@redhat.com>
3952
3953         * infcmd.c (kill_command): Print the pid as string, not the whole
3954         thread's ptid.  Add comment.  s/has been killed/killed/ in output
3955         message.
3956         * remote.c (remote_detach_1): Print the pid as string, not the
3957         whole thread's ptid.
3958
3959 2018-04-24  Jan Kratochvil  <jan.kratochvil@redhat.com>
3960             Sergio Durigan Junior  <sergiodj@redhat.com>
3961             Pedro Alves  <palves@redhat.com>
3962
3963         * infcmd.c (kill_command): Print message when inferior has
3964         been killed.
3965         * inferior.c (print_inferior_events): Remove 'static'.  Set as
3966         '1'.
3967         (add_inferior): Improve message printed when
3968         'print_inferior_events' is on.
3969         (exit_inferior): Remove message printed when
3970         'print_inferior_events' is on.
3971         (detach_inferior): Improve message printed when
3972         'print_inferior_events' is on.
3973         (initialize_inferiors): Use 'add_inferior_silent' to set
3974         'current_inferior_'.
3975         * inferior.h (print_inferior_events): Declare here as
3976         'extern'.
3977         * infrun.c (follow_fork_inferior): Print '[Attaching...]' or
3978         '[Detaching...]' messages when 'print_inferior_events' is on.
3979         Use 'add_thread_silent' instead of 'add_thread'.  Add '[' and ']'
3980         as prefix/suffix for messages.  Remove periods.  Fix erroneous
3981         'Detaching after fork from child...', replace it by '... from
3982         parent...'.
3983         (handle_vfork_child_exec_or_exit): Add '[' and ']' as
3984         prefix/suffix when printing 'Detaching...' messages.  Print
3985         them when 'print_inferior_events' is on.
3986         * remote.c (remote_detach_1): Print message when detaching
3987         from inferior and '!is_fork_parent'.
3988
3989 2018-04-24  Tom Tromey  <tom@tromey.com>
3990
3991         * cli-out.h: Reindent.
3992
3993 2018-04-24  Tom Tromey  <tom@tromey.com>
3994
3995         * cli-out.c (cli_ui_out::out_field_fmt): Remove.
3996         (cli_ui_out::do_field_string): Use fputs_filtered.
3997         * cli-out.h (class cli_ui_out) <out_field_fmt>: Remove.
3998
3999 2018-04-23  Tom Tromey  <tom@tromey.com>
4000
4001         * guile/scm-frame.c (gdbscm_frame_read_var): Use
4002         gdb::unique_xmalloc_ptr.
4003
4004 2018-04-23  Tom Tromey  <tom@tromey.com>
4005
4006         * configure: Rebuild.
4007
4008 2018-04-22  Rajendra SY  <rajendra.sy@gmail.com>
4009
4010         PR gdb/23095
4011         * gdb/testsuite/gdb.base/break-probes.exp: Pass shlib_load to
4012         prepare_for_testing.  Set normal_bp to r_debug_state if target
4013         is bsd.
4014
4015 2018-04-21  Pedro Alves  <palves@redhat.com>
4016             Rajendra SY  <rajendra.sy@gmail.com>
4017
4018         * inf-ptrace.c (inf_ptrace_attach): Mark the thread as executing.
4019         * remote.c (extended_remote_attach): In all-stop mode, mark the
4020         thread as executing.
4021
4022 2018-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4023
4024         * thread.c (thread_apply_all_command): Fix comment.
4025         (thread_command): Fix comment.
4026
4027 2018-04-10  Alan Hayward  <alan.hayward@arm.com>
4028
4029         * common/tdesc.h (tdesc_create_feature): Remove xml filename
4030         parameter.
4031         * features/aarch64-core.c (create_feature_aarch64_core):
4032         Regenerate.
4033         * features/aarch64-fpu.c (create_feature_aarch64_fpu):
4034         Likewise.
4035         * features/i386/32bit-avx.c (create_feature_i386_32bit_avx):
4036         Likewise.
4037         * features/i386/32bit-avx512.c
4038         (create_feature_i386_32bit_avx512): Likewise.
4039         * features/i386/32bit-core.c (create_feature_i386_32bit_core):
4040         Likewise.
4041         * features/i386/32bit-linux.c (create_feature_i386_32bit_linux):
4042         Likewise.
4043         * features/i386/32bit-mpx.c (create_feature_i386_32bit_mpx):
4044         Likewise.
4045         * features/i386/32bit-pkeys.c (create_feature_i386_32bit_pkeys):
4046         Likewise.
4047         * features/i386/32bit-sse.c (create_feature_i386_32bit_sse):
4048         Likewise.
4049         * features/i386/64bit-avx.c (create_feature_i386_64bit_avx):
4050         Likewise.
4051         * features/i386/64bit-avx512.c
4052         (create_feature_i386_64bit_avx512): Likewise.
4053         * features/i386/64bit-core.c (create_feature_i386_64bit_core):
4054         Likewise.
4055         * features/i386/64bit-linux.c (create_feature_i386_64bit_linux):
4056         Likewise.
4057         * features/i386/64bit-mpx.c (create_feature_i386_64bit_mpx):
4058         Likewise.
4059         * features/i386/64bit-pkeys.c (create_feature_i386_64bit_pkeys):
4060         Likewise.
4061         * features/i386/64bit-segments.c
4062         (create_feature_i386_64bit_segments): Likewise.
4063         * features/i386/64bit-sse.c (create_feature_i386_64bit_sse):
4064         Likewise.
4065         * features/i386/x32-core.c
4066         (create_feature_i386_x32_core): Likewise.
4067         * features/tic6x-c6xp.c (create_feature_tic6x_c6xp): Likewise.
4068         * features/tic6x-core.c (create_feature_tic6x_core): Likewise.
4069         * features/tic6x-gp.c (create_feature_tic6x_gp): Likewise.
4070         * target-descriptions.c: In generated code, don't pass xml
4071         filename.
4072
4073 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
4074
4075         * common/tdesc.c (print_xml_feature::visit_pre): Add xml parsing.
4076         (print_xml_feature::visit_post): Likewise.
4077         (print_xml_feature::visit): Likewise.
4078         * common/tdesc.h (tdesc_get_features_xml): Use const tdesc.
4079         (print_xml_feature): Add new class.
4080         * regformats/regdat.sh: Null xmltarget on feature targets.
4081         * target-descriptions.c (struct target_desc): Add xmltarget.
4082         (maintenance_check_tdesc_xml_convert): Add unittest function.
4083         (tdesc_get_features_xml): Add function to get xml.
4084         (maintenance_check_xml_descriptions): Test xml generation.
4085         * xml-tdesc.c (string_read_description_xml): Add function.
4086         * xml-tdesc.h (string_read_description_xml): Add declaration.
4087
4088 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
4089
4090         * features/Makefile: Add feature marker to targets with new style
4091         target descriptions.
4092         * regformats/aarch64.dat: Regenerate.
4093         * regformats/i386/amd64-avx-avx512-linux.dat: Likewise.
4094         * regformats/i386/amd64-avx-linux.dat: Likewise.
4095         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Likewise.
4096         * regformats/i386/amd64-avx-mpx-linux.dat: Likewise.
4097         * regformats/i386/amd64-linux.dat: Likewise.
4098         * regformats/i386/amd64-mpx-linux.dat: Likewise.
4099         * regformats/i386/amd64.dat: Likewise.
4100         * regformats/i386/i386-avx-avx512-linux.dat: Likewise.
4101         * regformats/i386/i386-avx-linux.dat: Likewise.
4102         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Likewise.
4103         * regformats/i386/i386-avx-mpx-linux.dat: Likewise.
4104         * regformats/i386/i386-linux.dat: Likewise.
4105         * regformats/i386/i386-mmx-linux.dat: Likewise.
4106         * regformats/i386/i386-mpx-linux.dat: Likewise.
4107         * regformats/i386/i386.dat: Likewise.
4108         * regformats/i386/x32-avx-avx512-linux.dat: Likewise.
4109         * regformats/i386/x32-avx-linux.dat: Likewise.
4110         * regformats/i386/x32-linux.dat: Likewise.
4111         * regformats/tic6x-c62x-linux.dat: Likewise.
4112         * regformats/tic6x-c64x-linux.dat: Likewise.
4113         * regformats/tic6x-c64xp-linux.dat: Likewise.
4114         * regformats/regdat.sh: Parse feature marker.
4115
4116 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
4117
4118         * common/tdesc.h (tdesc_architecture_name): Add new declaration.
4119         (tdesc_osabi_name): Likewise.
4120         * target-descriptions.c (tdesc_architecture_name): Add new
4121         function.
4122         (tdesc_osabi_name): Likewise.
4123
4124 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
4125
4126         * common/tdesc.c (tdesc_predefined_type): Move to here.
4127         (tdesc_named_type): Likewise.
4128         (tdesc_create_vector): Likewise.
4129         (tdesc_create_struct): Likewise.
4130         (tdesc_set_struct_size): Likewise.
4131         (tdesc_create_union): Likewise.
4132         (tdesc_create_flags): Likewise.
4133         (tdesc_create_enum): Likewise.
4134         (tdesc_add_field): Likewise.
4135         (tdesc_add_typed_bitfield): Likewise.
4136         (tdesc_add_bitfield): Likewise.
4137         (tdesc_add_flag): Likewise.
4138         (tdesc_add_enum_value): Likewise.
4139         * common/tdesc.h (struct tdesc_type_builtin): Likewise.
4140         (struct tdesc_type_vector): Likewise.
4141         (struct tdesc_type_field): Likewise.
4142         (struct tdesc_type_with_fields): Likewise.
4143         (tdesc_create_enum): Add declaration.
4144         (tdesc_add_typed_bitfield): Likewise.
4145         (tdesc_add_enum_value): Likewise.
4146         * target-descriptions.c (tdesc_type_field): Move from here.
4147         (tdesc_type_builtin): Likewise.
4148         (tdesc_type_vector): Likewise.
4149         (tdesc_type_with_fields): Likewise.
4150         (tdesc_predefined_types): Likewise.
4151         (tdesc_named_type): Likewise.
4152         (tdesc_create_vector): Likewise.
4153         (tdesc_create_struct): Likewise.
4154         (tdesc_set_struct_size): Likewise.
4155         (tdesc_create_union): Likewise.
4156         (tdesc_create_flags): Likewise.
4157         (tdesc_create_enum): Likewise.
4158         (tdesc_add_field): Likewise.
4159         (tdesc_add_typed_bitfield): Likewise.
4160         (tdesc_add_bitfield): Likewise.
4161         (tdesc_add_flag): Likewise.
4162         (tdesc_add_enum_value): Likewise.
4163         * gdb/target-descriptions.h (tdesc_create_enum): Likewise.
4164         (tdesc_add_typed_bitfield): Likewise.
4165         (tdesc_add_enum_value): Likewise.
4166
4167 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
4168
4169         * common/tdesc.c (tdesc_feature::accept): Move to here.
4170         (tdesc_feature::operator==): Likewise.
4171         (tdesc_create_reg): Likewise.
4172         * common/tdesc.h (tdesc_type_kind): Likewise.
4173         (struct tdesc_type): Likewise.
4174         (struct tdesc_feature): Likewise.
4175         * regformats/regdat.sh: Create a feature.
4176         * target-descriptions.c (tdesc_type_kind): Move from here.
4177         (tdesc_type): Likewise.
4178         (tdesc_type_up): Likewise.
4179         (tdesc_feature): Likewise.
4180         (tdesc_create_reg): Likewise.
4181
4182 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
4183
4184         * Makefile.in: Add arch/tdesc.c
4185         * common/tdesc.c: New file.
4186         * common/tdesc.h (tdesc_element_visitor): Move to here.
4187         (tdesc_element): Likewise.
4188         (tdesc_reg): Likewise.
4189         (tdesc_reg_up): Likewise.
4190         * regformats/regdef.h (reg): Add offset to constructors.
4191         * target-descriptions.c (tdesc_element_visitor): Move from here.
4192         (tdesc_element): Likewise.
4193         (tdesc_reg): Likewise.
4194         (tdesc_reg_up): Likewise.
4195
4196 2018-04-17  Tom Tromey  <tom@tromey.com>
4197
4198         * dwarf2read.c (quirk_rust_enum): Conditionally drop the
4199         discriminant field.
4200
4201 2018-04-17  Tom Tromey  <tom@tromey.com>
4202
4203         * dwarf2read.c (quirk_rust_enum): Handle unions correctly.
4204
4205 2018-04-17  Andreas Arnez  <arnez@linux.vnet.ibm.com>
4206
4207         * symtab.c (print_symbol_info): Skip printing filename and line
4208         number when `last' is NULL.
4209         (symtab_symbol_info): Use empty string instead of NULL for first
4210         invocation of print_symbol_info.
4211         (rbreak_command): Pass NULL to `last' parameter of
4212         print_symbol_info.
4213
4214 2018-04-16  Simon Marchi  <simon.marchi@ericsson.com>
4215
4216         * linux-tdep.c (linux_spu_make_corefile_notes): Return note_data
4217         instead of nullptr.
4218
4219 2018-04-16  Pedro Alves  <palves@redhat.com>
4220
4221         * MAINTAINERS (sh): Remove.
4222         * Makefile.in (ALL_TARGET_OBS): Remove sh64-tdep.o.
4223         (HFILES_NO_SRCDIR): Remove sh64-tdep.h.
4224         (ALLDEPFILES): Remove sh64-tdep.c.
4225         * NEWS: Mentions that support for SH-5/SH64 is removed.
4226         * configure.tgt (sh*-*-linux*): Remove reference to sh64-tdep.o.
4227         (sh*-*-openbsd*): Ditto.
4228         (sh64-*-elf*): Remove.
4229         (sh*): Remove.
4230         * regcache.c (cooked_write_test): Remove bfd_mach_sh5 case.
4231         * sh-linux-tdep.c: Remove reference to bfd_mach_sh5.
4232         * sh-tdep.c: No longer include "sh64-tdep.h".
4233         (sh_gdbarch_init): Remove reference to bfd_mach_sh5.
4234         * sh64-tdep.c, sh64-tdep.h: Remove files.
4235
4236 2018-04-16  Pedro Alves  <palves@redhat.com>
4237
4238         * MAINTAINERS: Remove m88k.
4239         * Makefile.in (ALL_TARGET_OBS): Remove m88k-tdep.o.
4240         (HFILES_NO_SRCDIR): Remove m88k-tdep.h.
4241         (ALLDEPFILES): Remove m88k-bsd-nat.c and m88k-tdep.c.
4242         * NEWS: Mention that support for m88k was removed.
4243         * configure.host (m88*-*-*): Remove support.
4244         * configure.nat (m88k-*-*): Remove support.
4245         * configure.tgt (m88*-*-openbsd*): Remove.
4246         * m88k-bsd-nat.c, m88k-tdep.c, m88k-tdep.h: Delete.
4247
4248 2018-04-15  Simon Marchi  <simon.marchi@polymtl.ca>
4249
4250         * configure.tgt (x86_tobjs): New variable.
4251         (amd64_tobjs, i386_tobjs): Use it.
4252
4253 2018-04-13  Andreas Arnez  <arnez@linux.vnet.ibm.com>
4254
4255         * symtab.c (print_symbol_info): Precede the symbol definition by
4256         the line number when available.
4257         * NEWS: Advertise this enhancement.
4258
4259 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
4260
4261         * NEWS (New options): announce set/show record btrace cpu.
4262         * btrace.c: Include record-btrace.h.
4263         (btrace_compute_ftrace_pt): Skip enabling errata workarounds if
4264         the vendor is unknown.
4265         (btrace_compute_ftrace_1): Add cpu parameter.  Update callers.
4266         Maybe overwrite the btrace configuration's cpu.
4267         (btrace_compute_ftrace): Add cpu parameter.  Update callers.
4268         (btrace_fetch): Add cpu parameter.  Update callers.
4269         (btrace_maint_update_pt_packets): Call record_btrace_get_cpu.
4270         Maybe overwrite the btrace configuration's cpu.  Skip enabling
4271         errata workarounds if the vendor is unknown.
4272         * python/py-record-btrace.c: Include record-btrace.h.
4273         (recpy_bt_begin, recpy_bt_end, recpy_bt_instruction_history)
4274         (recpy_bt_function_call_history): Call record_btrace_get_cpu.
4275         * record-btrace.c (record_btrace_cpu_state_kind): New.
4276         (record_btrace_cpu): New.
4277         (set_record_btrace_cpu_cmdlist): New.
4278         (record_btrace_get_cpu): New.
4279         (require_btrace_thread, record_btrace_info)
4280         (record_btrace_resume_thread): Call record_btrace_get_cpu.
4281         (cmd_set_record_btrace_cpu_none): New.
4282         (cmd_set_record_btrace_cpu_auto): New.
4283         (cmd_set_record_btrace_cpu): New.
4284         (cmd_show_record_btrace_cpu): New.
4285         (_initialize_record_btrace): Initialize set/show record btrace cpu
4286         commands.
4287         * record-btrace.h (record_btrace_get_cpu): New.
4288
4289 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
4290
4291         * record.c (set_record_command): Fix typo in message.
4292
4293 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
4294
4295         * record-btrace.c (cmd_set_record_btrace): Print sub-commands.
4296
4297 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
4298
4299         * infrun.c (process_event_stop_test): Call
4300         gdbarch_in_indirect_branch_thunk.
4301         * gdbarch.sh (in_indirect_branch_thunk): New.
4302         * gdbarch.c: Regenerated.
4303         * gdbarch.h: Regenerated.
4304         * x86-tdep.h: New.
4305         * x86-tdep.c: New.
4306         * Makefile.in (ALL_TARGET_OBS): Add x86-tdep.o.
4307         (HFILES_NO_SRCDIR): Add x86-tdep.h.
4308         (ALLDEPFILES): Add x86-tdep.c.
4309         * arch-utils.h (default_in_indirect_branch_thunk): New.
4310         * arch-utils.c (default_in_indirect_branch_thunk): New.
4311         * i386-tdep: Include x86-tdep.h.
4312         (i386_in_indirect_branch_thunk): New.
4313         (i386_elf_init_abi): Set in_indirect_branch_thunk gdbarch
4314         function.
4315         * amd64-tdep: Include x86-tdep.h.
4316         (amd64_in_indirect_branch_thunk): New.
4317         (amd64_init_abi): Set in_indirect_branch_thunk gdbarch function.
4318
4319 2018-04-12  Jan Kratochvil  <jan.kratochvil@redhat.com>
4320
4321         PR gdb/23053
4322         * dwarf-index-write.c (data_buf::grow) (write_one_signatured_type)
4323         (recursively_write_psymbols) (debug_names::recursively_write_psymbols)
4324         (debug_names::write_one_signatured_type): Fix -D_GLIBCXX_DEBUG
4325         regression.
4326
4327 2018-04-12  Tom Tromey  <tom@tromey.com>
4328
4329         * rust-lang.c (rust_print_struct_def): Remove univariant code.
4330         (rust_evaluate_subexp): Likewise.
4331
4332 2018-04-12  Pedro Alves  <palves@redhat.com>
4333
4334         * procfs.c (procfs_detach): Make forward declaration's prototype
4335         match definition's protototype.
4336         (proc_get_LDT_entry): Remove stale do_cleanups call.
4337
4338 2018-04-12  Pedro Alves  <palves@redhat.com>
4339
4340         * target.h (target_ops::to_has_exited): Delete.
4341         (target_has_exited): Delete.
4342         * target-delegates.c: Regenerate.
4343
4344 2018-04-11  Pedro Alves  <palves@redhat.com>
4345
4346         * target.c (fileio_fh_t::t): Add comment.
4347         (target_fileio_pwrite, target_fileio_pread, target_fileio_fstat)
4348         (target_fileio_close): Handle a NULL target.
4349         (invalidate_fileio_fh): New.
4350         (target_close): Call it.
4351         * remote.c (remote_hostio_send_command): No longer check whether
4352         remote_desc is open.
4353
4354 2018-04-11  Pedro Alves  <palves@redhat.com>
4355
4356         * target.c (fileio_fh_t): Make it a named struct instead of a
4357         typedef.
4358         (fileio_fh_t::is_closed): New method.
4359         (DEF_VEC_O (fileio_fh_t)): Remove.
4360         (fileio_fhandles): Now a std::vector.
4361         (is_closed_fileio_fh): Delete.
4362         (acquire_fileio_fd): Adjust.  Rename parameters.
4363         (release_fileio_fd): Adjust.
4364         (fileio_fd_to_fh): Reimplement as a function instead of a macro.
4365         (target_fileio_pwrite, target_fileio_pread, target_fileio_fstat)
4366         (target_fileio_close): Adjust.
4367
4368 2018-04-10  Simon Marchi  <simon.marchi@ericsson.com>
4369
4370         * auto-load.c (auto_load_safe_path_vec_update): Iterate by
4371         index.
4372
4373 2018-04-10  Pedro Alves  <palves@redhat.com>
4374
4375         * gdbthread.h (finish_thread_state_cleanup): Delete declaration.
4376         (scoped_finish_thread_state): New class.
4377         * infcmd.c (run_command_1): Use it instead of finish_thread_state
4378         cleanup.
4379         * infrun.c (proceed, prepare_for_detach, wait_for_inferior)
4380         (fetch_inferior_event, normal_stop): Likewise.
4381         * thread.c (finish_thread_state_cleanup): Delete.
4382
4383 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
4384             Pedro Alves  <palves@redhat.com>
4385
4386         * value.c: Include "selftest.h" and "common/array-view.h".
4387         (struct range) <operator ==>: New.
4388         (test_ranges_contain): New.
4389         (check_ranges_vector): New.
4390         (test_insert_into_bit_range_vector): New.
4391         (_initialize_values): Register selftests.
4392         * common/array-view.h (operator==, operator!=): New.
4393
4394 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
4395
4396         * common/gdb_vecs.h (unordered_remove): Add overload that takes
4397         an iterator.
4398         * inline-frame.c: Include <algorithm>.
4399         (struct inline_state): Add constructor.
4400         (inline_state_s): Remove.
4401         (DEF_VEC_O(inline_state_s)): Remove.
4402         (inline_states): Change type to std::vector.
4403         (find_inline_frame_state): Adjust to std::vector.
4404         (allocate_inline_frame_state): Remove.
4405         (clear_inline_frame_state): Adjust to std::vector.
4406         (skip_inline_frames): Adjust to std::vector.
4407
4408 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
4409
4410         * tracepoint.h (struct trace_state_variable): Add constructor.
4411         <name>: Change type to std::string.
4412         * tracepoint.c (tsv_s): Remove.
4413         (DEF_VEC_O(tsv_s)): Remove.
4414         (tvariables): Change to std::vector.
4415         (create_trace_state_variable): Adjust to std::vector.
4416         (find_trace_state_variable): Likewise.
4417         (find_trace_state_variable_by_number): Likewise.
4418         (delete_trace_state_variable): Likewise.
4419         (trace_variable_command): Adjust to std::string.
4420         (delete_trace_variable_command): Likewise.
4421         (tvariables_info_1): Adjust to std::vector.
4422         (save_trace_state_variables): Likewise.
4423         (start_tracing): Likewise.
4424         (merge_uploaded_trace_state_variables): Adjust to std::vector
4425         and std::string.
4426         * target.h (struct target_ops)
4427         <to_download_trace_state_variable>: Pass reference to
4428         trace_state_variable.
4429         * target-debug.h (target_debug_print_const_trace_state_variable_r): New.
4430         * target-delegates.c: Re-generate.
4431         * mi/mi-interp.c (mi_tsv_created): Adjust to std::string.
4432         (mi_tsv_deleted): Likewise.
4433         * mi/mi-main.c (mi_cmd_trace_frame_collected): Likewise.
4434         * remote.c (remote_download_trace_state_variable): Change
4435         pointer to reference and adjust.
4436         * make-target-delegates (parse_argtypes): Handle references.
4437         (write_function_header): Likewise.
4438         (munge_type): Likewise.
4439
4440 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
4441
4442         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4443         string_view-selftests.c.
4444         * unittests/basic_string_view/capacity/1.cc: Adapt to GDB
4445         testsuite.
4446         * unittests/basic_string_view/cons/char/1.cc: Likewise.
4447         * unittests/basic_string_view/cons/char/2.cc: Likewise.
4448         * unittests/basic_string_view/cons/char/3.cc: Likewise.
4449         * unittests/basic_string_view/element_access/char/1.cc:
4450         Likewise.
4451         * unittests/basic_string_view/element_access/char/empty.cc:
4452         Likewise.
4453         * unittests/basic_string_view/element_access/char/front_back.cc:
4454         Likewise.
4455         * unittests/basic_string_view/inserters/char/2.cc: Likewise.
4456         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc:
4457         Likewise.
4458         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc:
4459         Likewise.
4460         * unittests/basic_string_view/modifiers/swap/char/1.cc:
4461         Likewise.
4462         * unittests/basic_string_view/operations/compare/char/1.cc:
4463         Likewise.
4464         * unittests/basic_string_view/operations/compare/char/13650.cc:
4465         Likewise.
4466         * unittests/basic_string_view/operations/copy/char/1.cc:
4467         Likewise.
4468         * unittests/basic_string_view/operations/data/char/1.cc:
4469         Likewise.
4470         * unittests/basic_string_view/operations/find/char/1.cc:
4471         Likewise.
4472         * unittests/basic_string_view/operations/find/char/2.cc:
4473         Likewise.
4474         * unittests/basic_string_view/operations/find/char/3.cc:
4475         Likewise.
4476         * unittests/basic_string_view/operations/find/char/4.cc:
4477         Likewise.
4478         * unittests/basic_string_view/operations/rfind/char/1.cc:
4479         Likewise.
4480         * unittests/basic_string_view/operations/rfind/char/2.cc:
4481         Likewise.
4482         * unittests/basic_string_view/operations/rfind/char/3.cc:
4483         Likewise.
4484         * unittests/basic_string_view/operations/substr/char/1.cc:
4485         Likewise.
4486         * unittests/basic_string_view/operators/char/2.cc: Likewise.
4487         * unittests/string_view-selftests.c: New file.
4488
4489 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
4490
4491         * unittests/basic_string_view/capacity/1.cc: New file.
4492         * unittests/basic_string_view/capacity/empty_neg.cc: New file.
4493         * unittests/basic_string_view/cons/char/1.cc: New file.
4494         * unittests/basic_string_view/cons/char/2.cc: New file.
4495         * unittests/basic_string_view/cons/char/3.cc: New file.
4496         * unittests/basic_string_view/cons/wchar_t/1.cc: New file.
4497         * unittests/basic_string_view/cons/wchar_t/2.cc: New file.
4498         * unittests/basic_string_view/cons/wchar_t/3.cc: New file.
4499         * unittests/basic_string_view/element_access/char/1.cc: New file.
4500         * unittests/basic_string_view/element_access/char/2.cc: New file.
4501         * unittests/basic_string_view/element_access/char/empty.cc: New file.
4502         * unittests/basic_string_view/element_access/char/front_back.cc: New file.
4503         * unittests/basic_string_view/element_access/wchar_t/1.cc: New file.
4504         * unittests/basic_string_view/element_access/wchar_t/2.cc: New file.
4505         * unittests/basic_string_view/element_access/wchar_t/empty.cc: New file.
4506         * unittests/basic_string_view/element_access/wchar_t/front_back.cc: New file.
4507         * unittests/basic_string_view/include.cc: New file.
4508         * unittests/basic_string_view/inserters/char/1.cc: New file.
4509         * unittests/basic_string_view/inserters/char/2.cc: New file.
4510         * unittests/basic_string_view/inserters/char/3.cc: New file.
4511         * unittests/basic_string_view/inserters/pod/10081-out.cc: New file.
4512         * unittests/basic_string_view/inserters/wchar_t/1.cc: New file.
4513         * unittests/basic_string_view/inserters/wchar_t/2.cc: New file.
4514         * unittests/basic_string_view/inserters/wchar_t/3.cc: New file.
4515         * unittests/basic_string_view/literals/types.cc: New file.
4516         * unittests/basic_string_view/literals/values.cc: New file.
4517         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc: New file.
4518         * unittests/basic_string_view/modifiers/remove_prefix/wchar_t/1.cc: New file.
4519         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc: New file.
4520         * unittests/basic_string_view/modifiers/remove_suffix/wchar_t/1.cc: New file.
4521         * unittests/basic_string_view/modifiers/swap/char/1.cc: New file.
4522         * unittests/basic_string_view/modifiers/swap/wchar_t/1.cc: New file.
4523         * unittests/basic_string_view/operations/compare/char/1.cc: New file.
4524         * unittests/basic_string_view/operations/compare/char/13650.cc: New file.
4525         * unittests/basic_string_view/operations/compare/char/2.cc: New file.
4526         * unittests/basic_string_view/operations/compare/char/70483.cc: New file.
4527         * unittests/basic_string_view/operations/compare/wchar_t/1.cc: New file.
4528         * unittests/basic_string_view/operations/compare/wchar_t/13650.cc: New file.
4529         * unittests/basic_string_view/operations/compare/wchar_t/2.cc: New file.
4530         * unittests/basic_string_view/operations/copy/char/1.cc: New file.
4531         * unittests/basic_string_view/operations/copy/wchar_t/1.cc: New file.
4532         * unittests/basic_string_view/operations/data/char/1.cc: New file.
4533         * unittests/basic_string_view/operations/data/wchar_t/1.cc: New file.
4534         * unittests/basic_string_view/operations/find/char/1.cc: New file.
4535         * unittests/basic_string_view/operations/find/char/2.cc: New file.
4536         * unittests/basic_string_view/operations/find/char/3.cc: New file.
4537         * unittests/basic_string_view/operations/find/char/4.cc: New file.
4538         * unittests/basic_string_view/operations/find/wchar_t/1.cc: New file.
4539         * unittests/basic_string_view/operations/find/wchar_t/2.cc: New file.
4540         * unittests/basic_string_view/operations/find/wchar_t/3.cc: New file.
4541         * unittests/basic_string_view/operations/find/wchar_t/4.cc: New file.
4542         * unittests/basic_string_view/operations/rfind/char/1.cc: New file.
4543         * unittests/basic_string_view/operations/rfind/char/2.cc: New file.
4544         * unittests/basic_string_view/operations/rfind/char/3.cc: New file.
4545         * unittests/basic_string_view/operations/rfind/wchar_t/1.cc: New file.
4546         * unittests/basic_string_view/operations/rfind/wchar_t/2.cc: New file.
4547         * unittests/basic_string_view/operations/rfind/wchar_t/3.cc: New file.
4548         * unittests/basic_string_view/operations/string_conversion/1.cc: New file.
4549         * unittests/basic_string_view/operations/substr/char/1.cc: New file.
4550         * unittests/basic_string_view/operations/substr/wchar_t/1.cc: New file.
4551         * unittests/basic_string_view/operators/char/2.cc: New file.
4552         * unittests/basic_string_view/operators/wchar_t/2.cc: New file.
4553         * unittests/basic_string_view/range_access/char/1.cc: New file.
4554         * unittests/basic_string_view/range_access/wchar_t/1.cc: New file.
4555         * unittests/basic_string_view/requirements/explicit_instantiation/1.cc: New file.
4556         * unittests/basic_string_view/requirements/explicit_instantiation/char/1.cc: New file.
4557         * unittests/basic_string_view/requirements/explicit_instantiation/char16_t/1.cc: New file.
4558         * unittests/basic_string_view/requirements/explicit_instantiation/char32_t/1.cc: New file.
4559         * unittests/basic_string_view/requirements/explicit_instantiation/wchar_t/1.cc: New file.
4560         * unittests/basic_string_view/requirements/typedefs.cc: New file.
4561         * unittests/basic_string_view/typedefs.cc: New file.
4562         * unittests/basic_string_view/types/1.cc: New file.
4563
4564 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
4565
4566         * common/gdb_string_view.h: Remove libstdc++ implementation
4567         details, adjust to gdb reality.
4568         * common/gdb_string_view.tcc: Likewise.
4569         * cli/cli-script.c (struct string_view): Remove.
4570         (user_args) <m_args>: Change element type to gdb::string_view.
4571         (user_args::insert_args): Adjust.
4572
4573 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
4574
4575         * common/gdb_string_view.h: New file.
4576         * common/gdb_string_view.tcc: New file.
4577
4578 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
4579
4580         * ax_cxx_compile_stdcxx.m4: Sync with upstream.
4581         * configure: Re-generate.
4582
4583 2018-04-09  Pedro Alves  <palves@redhat.com>
4584
4585         * gdbarch.sh: Include "observable.h" instead of "observer.h".
4586         (set_target_gdbarch): Call
4587         gdb::observers::architecture_changed.notify instead of
4588         observer_notify_architecture_changed.
4589
4590 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4591
4592         * tracepoint.c (struct current_traceframe_cleanup): Remove.
4593         (do_restore_current_traceframe_cleanup): Remove.
4594         (restore_current_traceframe_cleanup_dtor): Remove.
4595         (make_cleanup_restore_current_traceframe): Remove.
4596         (scoped_restore_current_traceframe::scoped_restore_current_traceframe):
4597         New.
4598         * tracepoint.h (struct scoped_restore_current_traceframe): New.
4599         * infrun.c (fetch_inferior_event): Use
4600         scoped_restore_current_traceframe.
4601
4602 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4603
4604         * dwarf2read.h (struct dwarf2_per_objfile) <n_type_units>:
4605         Remove.
4606         <n_allocated_type_units>: Remove.
4607         <all_type_units>: Change to std::vector.
4608         * dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile): Adjust
4609         to std::vector change.
4610         (dwarf2_per_objfile::get_cutu): Likewise.
4611         (dwarf2_per_objfile::get_tu): Likewise.
4612         (create_signatured_type_table_from_index): Likewise.
4613         (create_signatured_type_table_from_debug_names): Likewise.
4614         (dw2_symtab_iter_next): Likewise.
4615         (dw2_print_stats): Likewise.
4616         (dw2_expand_all_symtabs): Likewise.
4617         (dw2_expand_marked_cus): Likewise.
4618         (dw2_debug_names_iterator::next): Likewise.
4619         (dwarf2_initialize_objfile): Likewise.
4620         (add_signatured_type_cu_to_table): Likewise.
4621         (create_all_type_units): Likewise.
4622         (add_type_unit): Likewise.
4623         (struct tu_abbrev_offset): Add constructor.
4624         (build_type_psymtabs_1): Adjust to std::vector change.
4625         (print_tu_stats): Likewise.
4626         * dwarf-index-write.c (check_dwarf64_offsets): Likewise.
4627         (write_debug_names): Likewise.
4628
4629 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4630
4631         * dwarf2read.h (struct dwarf2_per_objfile) <all_comp_units>: Likewise.
4632         Make an std::vector.
4633         <n_comp_units>: Remove.
4634         * dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile): Adjust
4635         to std::vector change.
4636         (dwarf2_per_objfile::get_cutu): Likewise.
4637         (dwarf2_per_objfile::get_cu): Likewise.
4638         (create_cus_from_index): Likewise.
4639         (create_addrmap_from_index): Likewise.
4640         (create_addrmap_from_aranges): Likewise.
4641         (dwarf2_read_index): Likewise.
4642         (dw2_find_last_source_symtab): Likewise.
4643         (dw2_map_symtabs_matching_filename): Likewise.
4644         (dw2_symtab_iter_next): Likewise.
4645         (dw2_print_stats): Likewise.
4646         (dw2_expand_all_symtabs): Likewise.
4647         (dw2_expand_symtabs_with_fullname): Likewise.
4648         (dw2_expand_marked_cus): Likewise.
4649         (dw2_map_symbol_filenames): Likewise.
4650         (create_cus_from_debug_names): Likewise.
4651         (dwarf2_read_debug_names): Likewise.
4652         (dw2_debug_names_iterator::next): Likewise.
4653         (dwarf2_initialize_objfile): Likewise.
4654         (set_partial_user): Likewise.
4655         (dwarf2_build_psymtabs_hard): Likewise.
4656         (read_comp_units_from_section): Remove arguments, adjust to
4657         std::vector change.
4658         (create_all_comp_units): Adjust to std::vector and
4659         read_comp_units_from_section changes.
4660         (dwarf2_find_containing_comp_unit): Adjust to std::vector
4661         change.
4662         * dwarf-index-write.c (check_dwarf64_offsets): Likewise.
4663         (psyms_seen_size): Likewise.
4664         (write_gdbindex): Likewise.
4665         (write_debug_names): Likewise.
4666
4667 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4668
4669         * dwarf2read.c (create_cus_from_index_list): Replace objfile arg
4670         with dwarf2_per_objfile.
4671         (create_cus_from_index): Likewise.
4672         (create_signatured_type_table_from_index): Likewise.
4673         (dwarf2_read_index): Likewise.
4674         (dwarf2_initialize_objfile): Likewise.
4675         (dwarf2_fetch_die_loc_sect_off):  Get dwarf2_per_objfile from
4676         per_cu rather than get_dwarf2_per_objfile.
4677
4678 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4679
4680         * dwarf2read.h (struct signatured_type): Forward declare.
4681         (struct dwarf2_per_objfile) <get_cutu, get_cu, get_tu>:
4682         New methods.
4683         * dwarf2read.c (dwarf2_per_objfile::get_cutu): Rename from...
4684         (dw2_get_cutu): ...this.
4685         (dwarf2_per_objfile::get_cu): Rename from...
4686         (dw2_get_cu): ...this.
4687         (dwarf2_per_objfile::get_tu): New.
4688         (create_addrmap_from_index): Adjust.
4689         (create_addrmap_from_aranges): Adjust.
4690         (dw2_find_last_source_symtab): Adjust.
4691         (dw2_map_symtabs_matching_filename): Adjust.
4692         (dw2_symtab_iter_next): Adjust.
4693         (dw2_print_stats): Adjust.
4694         (dw2_expand_all_symtabs): Adjust.
4695         (dw2_expand_symtabs_with_fullname): Adjust.
4696         (dw2_expand_marked_cus): Adjust.
4697         (dw_expand_symtabs_matching_file_matcher): Adjust.
4698         (dw2_map_symbol_filenames): Adjust.
4699         (dw2_debug_names_iterator::next): Adjust.
4700         (dwarf2_initialize_objfile): Adjust.
4701         (set_partial_user): Adjust.
4702         (dwarf2_build_psymtabs_hard): Adjust.
4703
4704 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4705
4706         * dwarf2read.c (create_signatured_type_table_from_debug_names):
4707         Remove unused variables.
4708         (dw2_map_symtabs_matching_filename): Likewise.
4709         (dwarf2_record_block_ranges): Likewise.
4710         (dwarf2_read_addr_index): Likewise.
4711         (follow_die_offset): Likewise.
4712
4713 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4714
4715         * progspace.c (clone_program_space): Pass SYMFILE_DEFER_BP_RESET
4716         to symbol_file_add_main.
4717
4718 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4719
4720         PR mi/22299
4721         * mi/mi-console.c (do_fputc_async_safe): New.
4722         (mi_console_file::write_async_safe): New.
4723         (mi_console_file::flush): Adjust calls to fputstrn_unfiltered.
4724         * mi/mi-console.h (class mi_console_file) <write_async_safe>:
4725         New.
4726         * ui-file.c (ui_file::putstrn): Adjust call to
4727         fputstrn_unfiltered.
4728         * utils.c (printchar): Replace do_fputs and do_fprintf
4729         parameters by do_fputc.
4730         (fputstr_filtered): Adjust call to printchar.
4731         (fputstr_unfiltered): Likewise.
4732         (fputstrn_filtered): Likewise.
4733         (fputstrn_unfiltered): Add do_fputc parameter, pass to
4734         printchar.
4735         * utils.h (do_fputc_ftype): New typedef.
4736         (fputstrn_unfiltered): Add do_fputc parameter.
4737
4738 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4739
4740         * regformats/i386/i386-avx.dat: Remove.
4741
4742 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
4743
4744         PR gdb/22979
4745         * amd64-tdep.c (amd64_none_init_abi): New function.
4746         (amd64_x32_none_init_abi): New function.
4747         (_initialize_amd64_tdep): Register handlers for x86-64 and
4748         x64_32 with GDB_OSABI_NONE.
4749         * osabi.c (gdbarch_init_osabi): Allow running handlers for the
4750         GDB_OSABI_NONE osabi.
4751
4752 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
4753
4754         PR gdb/22980
4755         * defs.h (enum gdb_osabi): Remove GDB_OSABI_UNINITIALIZED, add
4756         GDB_OSABI_NONE.
4757         * arch-utils.c (gdbarch_info_init): Don't set info->osabi.
4758         * osabi.c (gdb_osabi_names): Add "unknown" entry.
4759
4760 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
4761
4762         * common/byte-vector.h (char_vector): New type.
4763         * target.h (target_read_alloc): Return
4764         gdb::optional<byte_vector>.
4765         (target_read_stralloc): Return gdb::optional<char_vector>.
4766         (target_get_osdata): Return gdb::optional<char_vector>.
4767         * target.c (target_read_alloc_1): Templatize.  Replacement
4768         manual memory management with vector.
4769         (target_read_alloc): Change return type, adjust.
4770         (target_read_stralloc): Change return type, adjust.
4771         (target_get_osdata): Change return type, adjust.
4772         * auxv.c (struct auxv_info) <length>: Remove.
4773         <data>: Change type to gdb::optional<byte_vector>.
4774         (auxv_inferior_data_cleanup): Free auxv_info with delete.
4775         (get_auxv_inferior_data): Allocate auxv_info with new, adjust.
4776         (target_auxv_search): Adjust.
4777         (fprint_target_auxv): Adjust.
4778         * avr-tdep.c (avr_io_reg_read_command): Adjust.
4779         * linux-tdep.c (linux_spu_make_corefile_notes): Adjust.
4780         (linux_make_corefile_notes): Adjust.
4781         * osdata.c (get_osdata): Adjust.
4782         * remote.c (remote_get_threads_with_qxfer): Adjust.
4783         (remote_memory_map): Adjust.
4784         (remote_traceframe_info): Adjust.
4785         (btrace_read_config): Adjust.
4786         (remote_read_btrace): Adjust.
4787         (remote_pid_to_exec_file): Adjust.
4788         * solib-aix.c (solib_aix_get_library_list): Adjust.
4789         * solib-dsbt.c (decode_loadmap): Don't free buf.
4790         (dsbt_get_initial_loadmaps): Adjust.
4791         * solib-svr4.c (svr4_current_sos_via_xfer_libraries): Adjust.
4792         * solib-target.c (solib_target_current_sos): Adjust.
4793         * tracepoint.c (sdata_make_value): Adjust.
4794         * xml-support.c (xinclude_start_include): Adjust.
4795         (xml_fetch_content_from_file): Adjust.
4796         * xml-support.h (xml_fetch_another): Change return type.
4797         (xml_fetch_content_from_file): Change return type.
4798         * xml-syscall.c (xml_init_syscalls_info): Adjust.
4799         * xml-tdesc.c (file_read_description_xml): Adjust.
4800         (fetch_available_features_from_target): Change return type.
4801         (target_fetch_description_xml): Adjust.
4802         (target_read_description_xml): Adjust.
4803
4804 2018-04-06  Tom Tromey  <tom@tromey.com>
4805
4806         * value.c (~value): Update.
4807         (struct value) <contents>: Now unique_xmalloc_ptr.
4808         (value_contents_bits_eq, allocate_value_contents)
4809         (value_contents_raw, value_contents_all_raw)
4810         (value_contents_for_printing, value_contents_for_printing_const)
4811         (set_value_enclosing_type): Update.
4812
4813 2018-04-06  Tom Tromey  <tom@tromey.com>
4814
4815         * value.c (range_s): Remove typedef, VEC.
4816         (struct range): Add operator<.
4817         (range_lessthan): Remove.
4818         (ranges_contain): Change type.
4819         (~value): Update.
4820         (struct value) <unavailable, optimized_out>: Now std::vector.
4821         (value_entirely_available)
4822         (value_entirely_covered_by_range_vector)
4823         (value_entirely_unavailable, value_entirely_optimized_out):
4824         Update.
4825         (insert_into_bit_range_vector): Change argument type.
4826         (find_first_range_overlap): Likewise.
4827         (struct ranges_and_idx, value_contents_bits_eq)
4828         (require_not_optimized_out, require_available): Update.
4829         (ranges_copy_adjusted): Change argument types.
4830         (value_optimized_out, value_copy, value_fetch_lazy): Update.
4831
4832 2018-04-06  Tom Tromey  <tom@tromey.com>
4833
4834         * value.c (~value): Update.
4835         (struct value) <parent>: Now a value_ref_ptr.
4836         (value_parent, set_value_parent, value_address, value_copy):
4837         Update.
4838
4839 2018-04-06  Tom Tromey  <tom@tromey.com>
4840
4841         * value.c (struct value): Add constructor, destructor, and member
4842         initializers.
4843         (allocate_value_lazy, value_decref): Update.
4844
4845 2018-04-06  Tom Tromey  <tom@tromey.com>
4846
4847         * value.c (struct value) <released, next>: Remove.
4848         (all_values): Now a std::vector.
4849         (allocate_value_lazy): Update.
4850         (value_next): Remove.
4851         (value_mark, value_free_to_mark, release_value)
4852         (value_release_to_mark): Update.
4853
4854 2018-04-06  Tom Tromey  <tom@tromey.com>
4855
4856         * value.h (fetch_subexp_value, value_release_to_mark): Update.
4857         (free_value_chain): Remove.
4858         * value.c (free_value_chain): Remove.
4859         (value_release_to_mark): Return a std::vector.
4860         * ppc-linux-nat.c (num_memory_accesses): Change "chain" to a
4861         std::vector.
4862         (check_condition): Update.
4863         * eval.c (fetch_subexp_value): Change "val_chain" to a
4864         std::vector.
4865         * breakpoint.c (update_watchpoint): Update.
4866         (can_use_hardware_watchpoint): Change "vals" to a std::vector.
4867
4868 2018-04-06  Tom Tromey  <tom@tromey.com>
4869
4870         * value.h (free_all_values): Remove.
4871         * value.c (free_all_values): Remove.
4872
4873 2018-04-06  Tom Tromey  <tom@tromey.com>
4874
4875         * value.c (VALUE_HISTORY_CHUNK, struct value_history_chunk)
4876         (value_history_chain, value_history_count): Remove.
4877         (value_history): New global.
4878         (record_latest_value, access_value_history, show_values)
4879         (preserve_values): Update.
4880
4881 2018-04-06  Tom Tromey  <tom@tromey.com>
4882
4883         * varobj.h (struct varobj) <value>: Now a value_ref_ptr.
4884         * varobj.c (varobj_set_display_format, varobj_set_value)
4885         (install_default_visualizer, construct_visualizer)
4886         (install_new_value, ~varobj, varobj_get_value_type)
4887         (my_value_of_variable, varobj_editable_p): Update.
4888         * c-varobj.c (c_describe_child, c_value_of_variable)
4889         (cplus_number_of_children, cplus_describe_child): Update.
4890         * ada-varobj.c (ada_number_of_children, ada_name_of_child)
4891         (ada_path_expr_of_child, ada_value_of_child, ada_type_of_child)
4892         (ada_value_of_variable, ada_value_is_changeable_p): Update.
4893
4894 2018-04-06  Tom Tromey  <tom@tromey.com>
4895
4896         * printcmd.c (last_examine_address): Change type to
4897         value_ref_ptr.
4898         (do_examine, x_command): Update.
4899
4900 2018-04-06  Tom Tromey  <tom@tromey.com>
4901
4902         * value.c (release_value): Update.
4903         * breakpoint.h (struct watchpoint) <val>: Now a value_ref_ptr.
4904         (struct bpstats) <val>: Now a value_ref_ptr.
4905         * breakpoint.c (update_watchpoint, breakpoint_init_inferior)
4906         (~bpstats, bpstats, bpstat_clear_actions, watchpoint_check)
4907         (~watchpoint, print_it_watchpoint, watch_command_1)
4908         (invalidate_bp_value_on_memory_change): Update.
4909
4910 2018-04-06  Tom Tromey  <tom@tromey.com>
4911
4912         * varobj.c (varobj_clear_saved_item)
4913         (update_dynamic_varobj_children, install_new_value, ~varobj):
4914         Update.
4915         * value.h (value_incref): Move declaration earlier.
4916         (value_decref): Rename from value_free.
4917         (struct value_ref_policy): New.
4918         (value_ref_ptr): New typedef.
4919         (struct value_deleter): Remove.
4920         (gdb_value_up): Remove typedef.
4921         (release_value): Change return type.
4922         (release_value_or_incref): Remove.
4923         * value.c (set_value_parent): Update.
4924         (value_incref): Change return type.
4925         (value_decref): Rename from value_free.
4926         (value_free_to_mark, free_all_values, free_value_chain): Update.
4927         (release_value): Return value_ref_ptr.
4928         (release_value_or_incref): Remove.
4929         (record_latest_value, set_internalvar, clear_internalvar):
4930         Update.
4931         * stack.c (info_frame_command): Don't call value_free.
4932         * python/py-value.c (valpy_dealloc, valpy_new)
4933         (value_to_value_object): Update.
4934         * printcmd.c (do_examine): Update.
4935         * opencl-lang.c (lval_func_free_closure): Update.
4936         * mi/mi-main.c (register_changed_p): Don't call value_free.
4937         * mep-tdep.c (mep_frame_prev_register): Don't call value_free.
4938         * m88k-tdep.c (m88k_frame_prev_register): Don't call value_free.
4939         * m68hc11-tdep.c (m68hc11_frame_prev_register): Don't call
4940         value_free.
4941         * guile/scm-value.c (vlscm_free_value_smob)
4942         (vlscm_scm_from_value): Update.
4943         * frame.c (frame_register_unwind, frame_unwind_register_signed)
4944         (frame_unwind_register_unsigned, get_frame_register_bytes)
4945         (put_frame_register_bytes): Don't call value_free.
4946         * findvar.c (address_from_register): Don't call value_free.
4947         * dwarf2read.c (dwarf2_compute_name): Don't call value_free.
4948         * dwarf2loc.c (entry_data_value_free_closure)
4949         (value_of_dwarf_reg_entry, free_pieced_value_closure)
4950         (dwarf2_evaluate_loc_desc_full): Update.
4951         * breakpoint.c (update_watchpoint, breakpoint_init_inferior)
4952         (~bpstats, bpstats, bpstat_clear_actions, watchpoint_check)
4953         (~watchpoint, watch_command_1)
4954         (invalidate_bp_value_on_memory_change): Update.
4955         * alpha-tdep.c (alpha_register_to_value): Don't call value_free.
4956
4957 2018-04-06  Simon Marchi  <simon.marchi@polymtl.ca>
4958
4959         PR gdb/23022
4960         * warning.m4: Add -Wno-error=deprecated-register.
4961         * configure: Re-generate.
4962
4963 2018-04-05  Tom Tromey  <tom@tromey.com>
4964
4965         * linespec.h: Remove include of "vec.h".
4966
4967 2018-04-05  Tom Tromey  <tom@tromey.com>
4968
4969         * linespec.c (typep): Remove typedef.
4970         (find_methods, find_superclass_methods): Take a std::vector.
4971         (find_method): Use std::vector.
4972
4973 2018-04-05  Tom Tromey  <tom@tromey.com>
4974
4975         * utils.c (compare_strings): Remove.
4976         * utils.h (compare_strings): Remove.
4977         * objc-lang.h (find_imps): Update.
4978         * objc-lang.c (find_methods): Take a std::vector.
4979         (uniquify_strings, find_imps): Likewise.
4980         * linespec.c (find_methods): Take a std::vector.
4981         (decode_objc): Use std::vector.
4982         (add_all_symbol_names_from_pspace, find_superclass_methods): Take
4983         a std::vector.
4984         (find_method, find_function_symbols): Use std::vector.
4985
4986 2018-04-05  Tom Tromey  <tom@tromey.com>
4987
4988         * completer.c (completion_tracker::completion_tracker): Remove
4989         cast.
4990         (completion_tracker::discard_completions): Likewise.
4991         * breakpoint.c (ambiguous_names_p): Remove cast.
4992         * ada-lang.c (_initialize_ada_language): Remove cast.
4993         * utils.h (streq): Update.
4994         (streq_hash): Add new declaration.
4995         * utils.c (streq): Return bool.
4996         (streq_hash): New function.
4997
4998 2018-04-05  Tom Tromey  <tom@tromey.com>
4999
5000         * linespec.c (event_location_to_sals) <case ADDRESS_LOCATION>:
5001         Remove a string copy.
5002
5003 2018-04-05  Tom Tromey  <tom@tromey.com>
5004
5005         * linespec.c (filter_results): Use std::vector.
5006         (decode_line_2, decode_line_full): Update.
5007
5008 2018-04-05  Tom Tromey  <tom@tromey.com>
5009
5010         * linespec.c (canonical_to_fullform): Return std::string.
5011         (filter_results): Update.
5012         (struct decode_line_2_item): Add constructor.
5013         <fullform, displayform>: Now std::string.
5014         (decode_line_2_compare_items): Now a std::sort comparator.
5015         (decode_line_2): Update.
5016
5017 2018-04-05  Tom Tromey  <tom@tromey.com>
5018
5019         * linespec.c (copy_token_string): Return a unique_xmalloc_ptr.
5020         (unexpected_linespec_error): Update.
5021         (linespec_parse_basic, parse_linespec): Update.
5022
5023 2018-04-05  Tom Tromey  <tom@tromey.com>
5024
5025         * linespec.c (linespec_parse_basic): Reindent.
5026
5027 2018-04-05  Tom Tromey  <tom@tromey.com>
5028
5029         * minsyms.h (iterate_over_minimal_symbols): Update.
5030         * minsyms.c (iterate_over_minimal_symbols): Take a
5031         gdb::function_view.
5032         * linespec.c (struct collect_minsyms): Remove.
5033         (compare_msyms): Now a std::sort comparator.
5034         (add_minsym): Add parameters.
5035         (search_minsyms_for_name): Update.  Use std::vector.
5036
5037 2018-04-03  Tom Tromey  <tom@tromey.com>
5038
5039         * mipsread.c (read_alphacoff_dynamic_symtab): Use
5040         gdb::byte_vector.
5041
5042 2018-04-02  Weimin Pan  <weimin.pan@oracle.com>
5043
5044         * MAINTAINERS (Write After Approval): Add Weimin Pan.
5045
5046 2018-04-02  Weimin Pan  <weimin.pan@oracle.com>
5047
5048         PR gdb/16959
5049         * cp-valprint.c: (cp_print_static_field) Fix infinite recursion when 
5050         printing static type.
5051
5052 2018-04-01  Tom Tromey  <tom@tromey.com>
5053
5054         * rs6000-nat.c (rs6000_ptrace_ldinfo): Return a byte_vector.
5055         (rs6000_xfer_shared_libraries): Update.
5056
5057 2018-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
5058
5059         * common/gdb_vecs.h (char_ptr): Remove.
5060         * tracepoint.c (encode_actions_1): Remove usage of char_ptr.
5061
5062 2018-03-30  Simon Marchi  <simon.marchi@polymtl.ca>
5063
5064         * guile/scm-utils.c (gdbscm_parse_function_args): Replace VEC
5065         with std::vector.
5066         * common/gdb_vecs.h (DEF_VEC_P (char_ptr)): Remove.
5067
5068 2018-03-30  Simon Marchi  <simon.marchi@polymtl.ca>
5069
5070         * tracepoint.h (struct uploaded_tp): Initialize fields.
5071         <actions, step_actions, cmd_strings>: Change type to
5072         std::vector<char *>.
5073         * tracepoint.c (get_uploaded_tp): Allocate with new.
5074         (free_uploaded_tps): Free with delete.
5075         (parse_tracepoint_definition): Adjust to std::vector change.
5076         * breakpoint.c (read_uploaded_action): Likewise.
5077         (create_tracepoint_from_upload): Likewise.
5078         * ctf.c (ctf_write_uploaded_tp): Likewise.
5079         (SET_ARRAY_FIELD): Likewise.
5080         * tracefile-tfile.c (tfile_write_uploaded_tp): Likewise.
5081
5082 2018-03-30  Tom Tromey  <tom@tromey.com>
5083
5084         * solib-svr4.c (lm_info_read): Use gdb::byte_vector.  Return
5085         std::unique_ptr.
5086         (svr4_keep_data_in_core): Update.
5087         (svr4_read_so_list): Update.
5088
5089 2018-03-30  Tom Tromey  <tom@tromey.com>
5090
5091         * windows-nat.c (handle_output_debug_string, handle_exception):
5092         Update.
5093         * target.h (target_read_string): Update.
5094         * target.c (target_read_string): Change "string" to
5095         unique_xmalloc_ptr.
5096         * solib-svr4.c (open_symbol_file_object, svr4_read_so_list):
5097         Update.
5098         * solib-frv.c (frv_current_sos): Update.
5099         * solib-dsbt.c (dsbt_current_sos): Update.
5100         * solib-darwin.c (darwin_current_sos): Update.
5101         * linux-thread-db.c (inferior_has_bug): Update.
5102         * expprint.c (print_subexp_standard) <case OP_OBJC_MSGCALL>:
5103         Update.  Remove alloca.
5104         * ada-lang.c (ada_main_name): Update.
5105
5106 2018-03-30  Tom Tromey  <tom@tromey.com>
5107
5108         * dwarf2read.c (struct free_dwo_file_cleanup_data): Remove.
5109         (struct dwo_file_deleter): New.
5110         (dwo_file_up): New typedef.
5111         (open_and_init_dwo_file): Use dwo_file_up.
5112         (free_dwo_file_cleanup): Remove.
5113
5114 2018-03-30  Tom Tromey  <tom@tromey.com>
5115
5116         * dwarf2read.c (free_dwo_file): Remove "objfile" parameter.
5117         (free_dwo_file_cleanup, free_dwo_file_from_slot): Update.
5118
5119 2018-03-30  Tom Tromey  <tom@tromey.com>
5120
5121         * dwarf2read.c (class free_cached_comp_units): New class.
5122         (dw2_instantiate_symtab, dwarf2_build_psymtabs_hard): Use it.
5123         (free_cached_comp_units): Remove function.
5124
5125 2018-03-30  Tom Tromey  <tom@tromey.com>
5126
5127         * utils.h (make_cleanup_unpush_target): Remove.
5128         * inf-ptrace.c (struct target_unpusher): New.
5129         (target_unpush_up) New typedef.
5130         (inf_ptrace_create_inferior, inf_ptrace_attach): Use
5131         target_unpush_up.
5132         * utils.c (do_unpush_target, make_cleanup_unpush_target): Remove.
5133
5134 2018-03-27  Tom Tromey  <tom@tromey.com>
5135
5136         * utils.c (prompt_for_continue): Use unique_xmalloc_ptr.
5137
5138 2018-03-27  Pedro Alves  <palves@redhat.com>
5139             Tom Tromey  <tom@tromey.com>
5140
5141         * top.c (class gdb_readline_wrapper_cleanup): Add constructor,
5142         destructor.  Now a class.
5143         (gdb_readline_wrapper_cleanup): Remove function.
5144         (gdb_readline_wrapper): Remove cleanups.
5145
5146 2018-03-27  Tom Tromey  <tom@tromey.com>
5147
5148         * typeprint.h (struct type_print_options) <local_typedefs,
5149         global_typedefs>: Remove "struct" keyword.
5150         (class typedef_hash_table): New class.
5151         (recursively_update_typedef_hash, add_template_parameters)
5152         (create_typedef_hash, free_typedef_hash, copy_typedef_hash)
5153         (find_typedef_in_hash): Don't declare.
5154         * typeprint.c (struct typedef_hash_table): Move to typeprint.h.
5155         (typedef_hash_table::recursively_update): Rename from
5156         recursively_update_typedef_hash.  Now a member.
5157         (typedef_hash_table::add_template_parameters): Rename from
5158         add_template_parameters.  Now a member.
5159         (typedef_hash_table::typedef_hash_table): Now a constructor;
5160         rename from create_typedef_hash.
5161         (typedef_hash_table::~typedef_hash_table): Now a destructor;
5162         rename from free_typedef_hash.
5163         (do_free_typedef_hash, make_cleanup_free_typedef_hash)
5164         (do_free_global_table): Remove.
5165         (typedef_hash_table::typedef_hash_table): New constructor; renamed
5166         from copy_type_recursive.
5167         (create_global_typedef_table): Remove.
5168         (typedef_hash_table::find_global_typedef): Now a member of
5169         typedef_hash_table.
5170         (typedef_hash_table::find_typedef): Rename from
5171         find_typedef_in_hash; now a member.
5172         (whatis_exp): Update.
5173         * extension.h (struct ext_lang_type_printers): Add constructor and
5174         destructor.
5175         (start_ext_lang_type_printers, free_ext_lang_type_printers): Don't
5176         declare.
5177         * extension.c (ext_lang_type_printers::ext_lang_type_printers):
5178         Now a constructor; rename from start_ext_lang_type_printers.
5179         (ext_lang_type_printers): Now a destructor; rename from
5180         free_ext_lang_type_printers.
5181         * c-typeprint.c (find_typedef_for_canonicalize, c_print_type_1):
5182         Update.
5183         (c_type_print_base_struct_union): Update.  Remove cleanups.
5184
5185 2018-03-27  Tom Tromey  <tom@tromey.com>
5186
5187         * dwarf-index-write.c: Include <cmath>.
5188
5189 2018-03-27  Joel Brobecker  <brobecker@adacore.com>
5190
5191         * NEWS: Add entry describing new "set|show varsize-limit" command.
5192         * ada-lang.c (_initialize_ada_language): Add "set/show varsize-limit"
5193         command.
5194         * printcmd.c (_initialize_printcmd): Add "set var" alias of
5195         "set variable".
5196
5197 2018-03-27  Simon Marchi  <simon.marchi@ericsson.com>
5198
5199         * Makefile.in (COMMON_SFILES): Add dwarf-index-common.c and
5200         dwarf-index-write.c
5201         (HFILES_NO_SRCDIR): Add dwarf-index-common.h and dwarf2read.h.
5202         * dwarf-index-common.c: New file.
5203         * dwarf-index-common.h: New file.
5204         * dwarf-index-write.c: New file.
5205         * dwarf2read.c: Include dwarf2read.h and dwarf-index-common.h.
5206         (struct dwarf2_section_info): Move from here.
5207         (dwarf2_section_info_def): Likewise.
5208         (DEF_VEC_O (dwarf2_section_info_def)): Likewise.
5209         (offset_type): Likewise.
5210         (DW2_GDB_INDEX_SYMBOL_STATIC_SET_VALUE): Likewise.
5211         (DW2_GDB_INDEX_SYMBOL_KIND_SET_VALUE): Likewise.
5212         (DW2_GDB_INDEX_CU_SET_VALUE): Likewise.
5213         (byte_swap): Likewise.
5214         (MAYBE_SWAP): Likewise.
5215         (dwarf2_per_cu_ptr): Likewise.
5216         (DEF_VEC_P (dwarf2_per_cu_ptr)): Likewise.
5217         (struct tu_stats): Likewise.
5218         (struct dwarf2_per_objfile): Likewise.
5219         (struct dwarf2_per_cu_data): Likewise.
5220         (struct signatured_type): Likewise.
5221         (sig_type_ptr): Likewise.
5222         (DEF_VEC_P (sig_type_ptr)): Likewise.
5223         (INDEX4_SUFFIX): Likewise.
5224         (INDEX5_SUFFIX): Likewise.
5225         (DEBUG_STR_SUFFIX): Likewise.
5226         (dwarf2_read_section): Make non-static.
5227         (mapped_index_string_hash): Move from here.
5228         (dwarf5_djb_hash): Likewise.
5229         (file_write): Likewise.
5230         (class data_buf): Likewise.
5231         (struct symtab_index_entry): Likewise.
5232         (struct mapped_symtab): Likewise.
5233         (find_slot): Likewise.
5234         (hash_expand): Likewise.
5235         (add_index_entry): Likewise.
5236         (uniquify_cu_indices): Likewise.
5237         (class c_str_view): Likewise.
5238         (class c_str_view_hasher): Likewise.
5239         (class vector_hasher): Likewise.
5240         (write_hash_table): Likewise.
5241         (psym_index_map): Likewise.
5242         (struct addrmap_index_data): Likewise.
5243         (add_address_entry): Likewise.
5244         (add_address_entry_worker): Likewise.
5245         (write_address_map): Likewise.
5246         (symbol_kind): Likewise.
5247         (write_psymbols): Likewise.
5248         (struct signatured_type_index_data): Likewise.
5249         (write_one_signatured_type): Likewise.
5250         (recursively_count_psymbols): Likewise.
5251         (recursively_write_psymbols): Likewise.
5252         (class debug_names): Likewise.
5253         (check_dwarf64_offsets): Likewise.
5254         (psyms_seen_size): Likewise.
5255         (write_gdbindex): Likewise.
5256         (write_debug_names): Likewise.
5257         (assert_file_size): Likewise.
5258         (write_psymtabs_to_index): Likewise.
5259         (save_gdb_index_command): Likewise.
5260         (_initialize_dwarf2_read): Don't register the "save gdb-index"
5261         command.
5262         * dwarf2read.h: New file.
5263
5264 2018-03-27  Joel Brobecker  <brobecker@adacore.com>
5265
5266         PR gdb/22670
5267         * dwarf2read.c (dwarf2_physname): Do not return the demangled
5268         symbol name if the CU's language stores symbol names in linkage
5269         format.
5270         * language.h (struct language_defn)
5271         <la_store_sym_names_in_linkage_form_p>: New field.  Adjust
5272         all instances of this struct.
5273
5274 2018-03-26  Tom Tromey  <tom@tromey.com>
5275
5276         * stack.c (backtrace_command_1): Remove verbose code.
5277
5278 2018-03-26  Tom Tromey  <tom@tromey.com>
5279
5280         * python/py-framefilter.c (py_print_type): Don't catch
5281         exceptions.  Return void.
5282         (py_print_value): Likewise.
5283         (py_print_single_arg): Likewise.
5284         (enumerate_args): Don't catch exceptions.
5285         (py_print_args): Likewise.
5286         (py_print_frame): Likewise.
5287         (gdbpy_apply_frame_filter): Catch exceptions here.
5288
5289 2018-03-26  Tom Tromey  <tom@tromey.com>
5290
5291         * stack.c (_initialize_stack): Remove trailing newlines from help
5292         text.  Add "Usage" line to "backtrace" help.
5293
5294 2018-03-26  Tom Tromey  <tom@tromey.com>
5295
5296         PR python/16486:
5297         * python/py-framefilter.c (py_print_args): Call wrap_hint.
5298
5299 2018-03-26  Tom Tromey  <tom@tromey.com>
5300
5301         * python/py-framefilter.c (py_print_single_arg): Return
5302         EXT_LANG_BT_ERROR from catch.
5303
5304 2018-03-26  Tom Tromey  <tom@tromey.com>
5305
5306         PR backtrace/15584:
5307         * stack.c (backtrace_command_1): Move some code into no-filters
5308         "if".
5309
5310 2018-03-26  Tom Tromey  <tom@tromey.com>
5311
5312         * python/py-framefilter.c (throw_quit_or_print_exception): New
5313         function.
5314         (gdbpy_apply_frame_filter): Use it.
5315
5316 2018-03-26  Tom Tromey  <tom@tromey.com>
5317
5318         PR cli/17716:
5319         * python/py-framefilter.c (py_print_type, py_print_value)
5320         (enumerate_args, py_print_args, gdbpy_apply_frame_filter): Use
5321         RETURN_MASK_ERROR.
5322
5323 2018-03-26  Tom Tromey  <tom@tromey.com>
5324
5325         * python/py-framefilter.c (enumerate_args): Use
5326         gdb::unique_xmalloc_ptr.
5327
5328 2018-03-26  Tom Tromey  <tom@tromey.com>
5329
5330         * python/py-framefilter.c (py_print_frame): Return
5331         EXT_LANG_BT_OK.
5332         (gdbpy_apply_frame_filter): Update comment.
5333         * extension.h (enum ext_lang_bt_status) <EXT_LANG_BT_COMPLETED>:
5334         Remove.
5335         <EXT_LANG_BT_NO_FILTERS>: Change value.
5336
5337 2018-03-26  Tom Tromey  <tom@tromey.com>
5338
5339         PR backtrace/15582:
5340         * stack.c (backtrace_command): Parse "hide" argument.
5341         * python/py-framefilter.c (py_print_frame): Handle PRINT_HIDE.
5342         * extension.h (enum frame_filter_flags) <PRINT_HIDE>: New
5343         constant.
5344
5345 2018-03-26  Tom Tromey  <tom@tromey.com>
5346
5347         * stack.c (backtrace_command_1): Remove "show_locals" parameter,
5348         add "flags".
5349         (backtrace_command): Remove "fulltrace", add "flags".
5350
5351 2018-03-26  Tom Tromey  <tom@tromey.com>
5352
5353         * stack.c (backtrace_command): Rewrite command line parsing.
5354
5355 2018-03-26  Simon Marchi  <simon.marchi@ericsson.com>
5356
5357         * dwarf2read.c (DEF_VEC_I(offset_type)): Remove.
5358
5359 2018-03-26  Simon Marchi  <simon.marchi@ericsson.com>
5360
5361         * filename-seen-cache.h: Add include guard.
5362
5363 2018-03-26  Keith Seitz  <keiths@redhat.com>
5364
5365         * symfile.c (place_section): Remove "struct" from section_addr_info
5366         in comment.
5367         * windows-nat.c (struct safe_symbol_file_add_args) <addrs>: Remove
5368         "struct" keyword from section_addr_info.
5369
5370 2018-03-26  Alan Hayward  <alan.hayward@arm.com>
5371
5372         * regformats/regdef.h (reg): Add constructors.
5373
5374 2018-03-25  Pedro Alves  <palves@redhat.com>
5375
5376         * eval.c (evaluate_funcall): Swap OP_VAR_MSYM_VALUE/OP_VAR_VALUE
5377         if then/else bodies in var_func_name extraction.
5378
5379 2018-03-23  Weimin Pan  <weimin.pan@oracle.com>
5380
5381         * minsyms.c (lookup_minimal_symbol_and_objfile): Use
5382         lookup_minimal_symbol() to find symbol entry.
5383         * minsyms.h (lookup_minimal_symbol_and_objfile): Update comment.
5384
5385 2018-03-23  Keith Seitz  <keiths@redhat.com>
5386
5387         PR c++/22968
5388         * dwarf2read.c (scan_partial_symbols): Scan structs/classes for
5389         nested type definitions for C++, too.
5390
5391 2018-03-23  Tom Tromey  <tom@tromey.com>
5392
5393         * machoread.c (struct oso_el): Add a constructor.  Don't define as
5394         a typedef.
5395         (macho_register_oso): Remove.
5396         (macho_symtab_read): Take a std::vector.
5397         (oso_el_compare_name): Now a std::sort comparator.
5398         (macho_symfile_read_all_oso): Take a std::vector.
5399         (macho_symfile_read): Use std::vector.  Remove cleanups.
5400
5401 2018-03-22  Tom Tromey  <tom@tromey.com>
5402
5403         * record-full.c (record_full_exec_insn): Use gdb::byte_vector.
5404         (record_full_goto_bookmark): Use std::string.
5405
5406 2018-03-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
5407
5408         PR tdep/18295
5409         * rs6000-tdep.c (skip_prologue): Match both stwux and stdux
5410         a single mask.
5411
5412 2018-03-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
5413
5414         * rs6000-tdep.c (store_insn_p): New function.
5415         (skip_prologue): New variable alloca_reg_offset. Set lr_reg
5416         and cr_reg to their unshifted values. Use store_insn_p to
5417         match LR saves using either R1 or fdata->alloca_reg. Use
5418         store_insn_p to match CR saves. Set alloca_reg_offset
5419         when alloca_reg and framep are set. Remove lr_reg shift
5420         when assigning to fdata->lr_register.
5421
5422 2018-03-22  Andreas Arnez  <arnez@linux.vnet.ibm.com>
5423
5424         * linux-tdep.c (linux_info_proc): For "info proc cmdline", print
5425         command line args instead of emitting a warning.
5426
5427 2018-03-22  Simon Marchi  <simon.marchi@polymtl.ca>
5428
5429         * tracepoint.h (struct static_tracepoint_marker): Initialize
5430         fields, define default constructor, move constructor and move
5431         assignment, disable the rest.
5432         <str_id, extra>: Make std::string.
5433         (release_static_tracepoint_marker): Remove.
5434         (free_current_marker): Remove.
5435         * tracepoint.c (free_current_marker): Remove.
5436         (parse_static_tracepoint_marker_definition): Adjust to
5437         std::string, use new hex2str overload.
5438         (release_static_tracepoint_marker): Remove.
5439         (print_one_static_tracepoint_marker): Get marker by reference
5440         and adjust to std::string.
5441         (info_static_tracepoint_markers_command): Adjust to std::vector
5442         changes
5443         * target.h (static_tracepoint_marker_p): Remove typedef.
5444         (DEF_VEC_P(static_tracepoint_marker_p)): Remove.
5445         (struct target_ops) <to_static_tracepoint_marker_at>: Return
5446         bool.
5447         <to_static_tracepoint_markers_by_strid>: Return std::vector.
5448         * target-debug.h
5449         (target_debug_print_VEC_static_tracepoint_marker_p_p): Remove.
5450         (target_debug_print_std_vector_static_tracepoint_marker): New.
5451         (target_debug_print_struct_static_tracepoint_marker_p): Rename
5452         to...
5453         (target_debug_print_static_tracepoint_marker_p): ... this.
5454         * target-delegates.c: Re-generate.
5455         * breakpoint.h (struct tracepoint) <static_trace_marker_id>:
5456         Make std::string.
5457         * breakpoint.c (init_breakpoint_sal): Adjust to std::string.
5458         (decode_static_tracepoint_spec): Adjust to std::vector.
5459         (tracepoint_print_one_detail): Adjust to std::string.
5460         (strace_marker_decode_location): Adjust to std::string.
5461         (update_static_tracepoint): Adjust to std::string, remove call
5462         to release_static_tracepoint_marker.
5463         * linux-nat.c (linux_child_static_tracepoint_markers_by_strid):
5464         Adjust to std::vector.
5465         * remote.c (remote_static_tracepoint_marker_at): Return bool.
5466         (remote_static_tracepoint_markers_by_strid): Adjust to
5467         std::vector.
5468         * common/rsp-low.h (hex2str): New overload with explicit count
5469         of bytes.
5470         * common/rsp-low.c (hex2str): New overload with explicit count
5471         of bytes.
5472         * unittests/rsp-low-selftests.c (test_hex2str): New function.
5473         (_initialize_rsp_low_selftests): Add test_hex2str test.
5474         * unittests/tracepoint-selftests.c
5475         (test_parse_static_tracepoint_marker_definition): Adjust to
5476         std::string.
5477
5478 2018-03-22  Simon Marchi  <simon.marchi@polymtl.ca>
5479
5480         * tracepoint.c (parse_static_tracepoint_marker_definition):
5481         Consider case where the definition is followed by more
5482         definitions.
5483         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5484         tracepoint-selftests.c.
5485         * unittests/tracepoint-selftests.c: New.
5486
5487 2018-03-21  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
5488
5489         * MAINTAINERS (Write After Approval): Add Pedro Franco de
5490         Carvalho.
5491
5492 2018-03-20  Stephen Roberts  <stephen.roberts@arm.com>
5493
5494         * symtab.c (find_pc_sect_line): fixed indentation.
5495
5496 2018-03-20  Stephen Roberts  <stephen.roberts@arm.com>
5497
5498         * symtab.c (find_pc_sect_line): now uses binary search.
5499
5500 2018-03-19  Tom Tromey  <tom@tromey.com>
5501
5502         * rust-exp.y (struct_expr_tail, struct_expr_list): Add plain
5503         "IDENT" production.
5504
5505 2018-03-19  Pedro Alves  <palves@redhat.com>
5506             Tom Tromey  <tom@tromey.com>
5507
5508         * unittests/observable-selftests.c: New file.
5509         * common/observable.h: New file.
5510         * observable.h: New file.
5511         * ada-lang.c, ada-tasks.c, agent.c, aix-thread.c, annotate.c,
5512         arm-tdep.c, auto-load.c, auxv.c, break-catch-syscall.c,
5513         breakpoint.c, bsd-uthread.c, cli/cli-interp.c, cli/cli-setshow.c,
5514         corefile.c, dummy-frame.c, event-loop.c, event-top.c, exec.c,
5515         extension.c, frame.c, gdbarch.c, guile/scm-breakpoint.c,
5516         infcall.c, infcmd.c, inferior.c, inflow.c, infrun.c, jit.c,
5517         linux-tdep.c, linux-thread-db.c, m68klinux-tdep.c,
5518         mi/mi-cmd-break.c, mi/mi-interp.c, mi/mi-main.c, objfiles.c,
5519         ppc-linux-nat.c, ppc-linux-tdep.c, printcmd.c, procfs.c,
5520         python/py-breakpoint.c, python/py-finishbreakpoint.c,
5521         python/py-inferior.c, python/py-unwind.c, ravenscar-thread.c,
5522         record-btrace.c, record-full.c, record.c, regcache.c, remote.c,
5523         riscv-tdep.c, sol-thread.c, solib-aix.c, solib-spu.c, solib.c,
5524         spu-multiarch.c, spu-tdep.c, stack.c, symfile-mem.c, symfile.c,
5525         symtab.c, thread.c, top.c, tracepoint.c, tui/tui-hooks.c,
5526         tui/tui-interp.c, valops.c: Update all users.
5527         * tui/tui-hooks.c (tui_bp_created_observer)
5528         (tui_bp_deleted_observer, tui_bp_modified_observer)
5529         (tui_inferior_exit_observer, tui_before_prompt_observer)
5530         (tui_normal_stop_observer, tui_register_changed_observer):
5531         Remove.
5532         (tui_observers_token): New global.
5533         (attach_or_detach, tui_attach_detach_observers): New functions.
5534         (tui_install_hooks, tui_remove_hooks): Use
5535         tui_attach_detach_observers.
5536         * record-btrace.c (record_btrace_thread_observer): Remove.
5537         (record_btrace_thread_observer_token): New global.
5538         * observer.sh: Remove.
5539         * observer.c: Rename to observable.c.
5540         * observable.c (namespace gdb_observers): Define new objects.
5541         (observer_debug): Move into gdb_observers namespace.
5542         (struct observer, struct observer_list, xalloc_observer_list_node)
5543         (xfree_observer_list_node, generic_observer_attach)
5544         (generic_observer_detach, generic_observer_notify): Remove.
5545         (_initialize_observer): Update.
5546         Don't include observer.inc.
5547         * Makefile.in (generated_files): Remove observer.h, observer.inc.
5548         (clean mostlyclean): Likewise.
5549         (observer.h, observer.inc): Remove targets.
5550         (SUBDIR_UNITTESTS_SRCS): Add observable-selftests.c.
5551         (COMMON_SFILES): Use observable.c, not observer.c.
5552         * .gitignore: Remove observer.h.
5553
5554 2018-03-18  Tom Tromey  <tom@tromey.com>
5555
5556         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Use
5557         gdb::def_vector.
5558         (bfd_lookup_symbol_from_dyn_symtab): Likewise.
5559
5560 2018-03-17  Tom Tromey  <tom@tromey.com>
5561
5562         * auto-load.c (auto_load_objfile_script_1): Use std::string.
5563
5564 2018-03-17  Tom Tromey  <tom@tromey.com>
5565
5566         * target.c (class scoped_target_fd): New.
5567         (target_fileio_close_cleanup): Remove.
5568         (target_fileio_read_alloc_1): Use scoped_target_fd.
5569
5570 2018-03-16  Simon Marchi  <simon.marchi@polymtl.ca>
5571
5572         * silent-rules.mk: New.
5573         * Makefile.in: Include silent-rules.mk
5574         (srcdir, VPATH, top_srcdir): Move up.
5575         (COMPILE): Add ECHO_CXX.
5576         (test-cp-name-parser$(EXEEXT)): Add ECHO_CXXLD.
5577         (init.c): Add ECHO_INIT_C.
5578         (gdb$(EXEEXT)): Add SILENCE and ECHO_CXXLD.
5579         (version.c): Add ECHO_GEN.
5580         (printcmd.o): Add ECHO_CXX.
5581         (target-float.o): Add ECHO_CXX.
5582         (ada-exp.o): Add ECHO_CXX.
5583         (stamp-xml): Add SILENCE and ECHO_GEN_XML_BUILTIN.
5584         (insight$(EXEEXT)): Add ECHO_CXXLD.
5585         * gnulib/configure.ac: Add AM_SILENT_RULES.
5586         * gnulib/aclocal.m4: Re-generate.
5587         * gnulib/configure: Re-generate.
5588         * gnulib/import/Makefile.in: Re-generate.
5589
5590 2018-03-16  Tom Tromey  <tom@tromey.com>
5591
5592         * xcoffread.c (xcoff_symfile_offsets): Change type of "addrs".
5593         * utils.h (make_cleanup_free_section_addr_info): Don't declare.
5594         * utils.c (do_free_section_addr_info)
5595         (make_cleanup_free_section_addr_info): Remove.
5596         * symfile.h (struct other_sections): Add constructor.
5597         (struct section_addr_info): Remove.
5598         (section_addr_info): New typedef.
5599         (struct sym_fns) <sym_offsets>: Change type of parameter.
5600         (build_section_addr_info_from_objfile)
5601         (relative_addr_info_to_section_offsets, addr_info_make_relative)
5602         (default_symfile_offsets, symbol_file_add)
5603         (symbol_file_add_from_bfd)
5604         (build_section_addr_info_from_section_table): Update.
5605         (alloc_section_addr_info, free_section_addr_info): Don't declare.
5606         * symfile.c (alloc_section_addr_info): Remove.
5607         (build_section_addr_info_from_section_table): Change return type.
5608         Update.
5609         (build_section_addr_info_from_bfd)
5610         (build_section_addr_info_from_objfile): Likewise.
5611         (free_section_addr_info): Remove.
5612         (relative_addr_info_to_section_offsets): Change type of "addrs".
5613         (addrs_section_compar): Now a std::sort comparator.
5614         (addrs_section_sort): Change return type.
5615         (addr_info_make_relative): Change type of "addrs".  Update.
5616         (default_symfile_offsets, syms_from_objfile_1)
5617         (syms_from_objfile, symbol_file_add_with_addrs): Likewise.
5618         (symbol_file_add_separate): Update.
5619         (symbol_file_add): Change type of "addrs".  Update.
5620         (add_symbol_file_command): Update.  Remove cleanups.
5621         * symfile-mem.c (symbol_file_add_from_memory): Update.  Remove
5622         cleanups.
5623         * symfile-debug.c (debug_sym_offsets): Change type of "info".
5624         * solib.c (solib_read_symbols): Update.
5625         * objfiles.c (objfile_relocate): Update.  Remove cleanups.
5626         * machoread.c (macho_symfile_offsets): Update.
5627         * jit.c (jit_bfd_try_read_symtab): Update.
5628
5629 2018-03-15  Simon Marchi  <simon.marchi@polymtl.ca>
5630
5631         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5632         unittests/utils-selftests.c.
5633         * unittests/utils-selftests.c: New file.
5634
5635 2018-03-14  Tom Tromey  <tom@tromey.com>
5636
5637         PR cli/14977:
5638         * printcmd.c (printf_c_string, printf_wide_c_string): Special case
5639         for NULL.
5640
5641 2018-03-14  Tom Tromey  <tom@tromey.com>
5642
5643         PR cli/19918:
5644         * printcmd.c (printf_pointer): Allow "-" in format.
5645
5646 2018-03-14  Tom Tromey  <tom@tromey.com>
5647
5648         * printcmd.c (_initialize_printcmd): Add usage to printf.
5649
5650 2018-03-14  Yao Qi  <qiyao@sourceware.org>
5651
5652         * MAINTAINERS: Update my email address.
5653
5654 2018-03-13  Tom Tromey  <tom@tromey.com>
5655
5656         * machoread.c (macho_check_dsym): Change filenamep to a
5657         std::string*.
5658         (macho_symfile_read): Update.
5659         * symfile.c (load_command): Use std::string.
5660
5661 2018-03-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5662
5663         * riscv-tdep.c (riscv_sw_breakpoint_from_kind): Add localization
5664         to error message string.
5665         (riscv_register_name): Use xsnprintf instead of sprintf.
5666         (riscv_insn::fetch_instruction): Use gdb_assert instead of
5667         internal_error.
5668         (riscv_print_arg_location): Use gdb_assert_not_reached instead of
5669         error.
5670         (riscv_push_dummy_call): Likewise.
5671
5672 2018-03-12  Tom Tromey  <tom@tromey.com>
5673
5674         * rs6000-aix-tdep.c (rs6000_aix_core_xfer_shared_libraries_aix):
5675         Use gdb::byte_vector.
5676         * arm-tdep.c (arm_exidx_new_objfile): Use gdb::byte_vector.
5677
5678 2018-03-12  Yao Qi  <yao.qi@linaro.org>
5679
5680         * ia64-libunwind-tdep.c (libunwind_get_reg_special): Change
5681         parameter type to readable_regcache.
5682         * ia64-libunwind-tdep.h (libunwind_get_reg_special): Update
5683         the declaration.
5684
5685 2018-03-11  Tom Tromey  <tom@tromey.com>
5686
5687         * dwarf2read.c (struct nextfield): Add initializers.
5688         (struct nextfnfield): Remove.
5689         (struct fnfieldlist): Add initializers.  Remove "length" and
5690         "head", use std::vector.
5691         (struct decl_field_list): Remove.
5692         (struct field_info): Add initializers.
5693         <fields, baseclasses>: Now std::vector.
5694         <nbaseclasses, nfnfields, typedef_field_list_count,
5695         nested_types_list_count>: Remove.
5696         (dwarf2_add_field, dwarf2_add_type_defn)
5697         (dwarf2_attach_fields_to_type, dwarf2_add_member_fn)
5698         (dwarf2_attach_fn_fields_to_type, handle_struct_member_die)
5699         (process_structure_scope): Update.
5700
5701 2018-03-11  Tom Tromey  <tom@tromey.com>
5702
5703         * dwarf2read.c (sort_tu_by_abbrev_offset): Change to be suitable
5704         for use by std::sort.
5705         (build_type_psymtabs_1): Use std::vector.
5706
5707 2018-03-09  Eli Zaretskii  <eliz@gnu.org>
5708
5709         * top.c (print_gdb_configuration): Reflect LIBIPT, LIBMEMCHECK,
5710         and LIBMPFR in the printed configuration.
5711
5712 2018-03-08  Tom Tromey  <tom@tromey.com>
5713
5714         * source.c (get_filename_and_charpos): Use scoped_fd.
5715         * nto-procfs.c (procfs_open_1): Use scoped_fd.
5716         (procfs_pidlist): Likewise.
5717         * procfs.c (proc_get_LDT_entry): Use scoped_fd.
5718         (iterate_over_mappings): Likewise.
5719
5720 2018-03-08  Tom Tromey  <tom@tromey.com>
5721
5722         * infcall.c (struct call_return_meta_info)
5723         <stack_temporaries_enabled>: Remove.
5724         (get_call_return_value, call_function_by_hand_dummy): Update.
5725         * thread.c (disable_thread_stack_temporaries): Remove.
5726         (enable_thread_stack_temporaries): Remove.
5727         (thread_stack_temporaries_enabled_p): Return bool.
5728         (push_thread_stack_temporary, value_in_thread_stack_temporaries)
5729         (get_last_thread_stack_temporary): Update.
5730         * eval.c (evaluate_subexp): Update.
5731         * gdbthread.h (class enable_thread_stack_temporaries): Now a
5732         class, not a function.
5733         (value_ptr, value_vec): Remove typedefs.
5734         (class thread_info) <stack_temporaries_enabled>: Now bool.
5735         <stack_temporaries>: Now a std::vector.
5736         (thread_stack_temporaries_enabled_p)
5737         (value_in_thread_stack_temporaries): Return bool.
5738
5739 2018-03-08  Simon Marchi  <simon.marchi@ericsson.com>
5740
5741         * remote.c (putpkt_binary): Fix omitted bytes reporting.
5742         (getpkt_or_notif_sane_1): Likewise.
5743
5744 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
5745
5746         * build-id.c (build_id_to_debug_bfd): Use std::string.
5747
5748 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
5749
5750         * build-id.c (find_separate_debug_file_by_buildid): Return
5751         std::string.
5752         * build-id.h (find_separate_debug_file_by_buildid): Return
5753         std::string.
5754         * coffread.c (coff_symfile_read): Adjust to std::string.
5755         * elfread.c (elf_symfile_read): Adjust to std::string.
5756         * symfile.c (separate_debug_file_exists): Change parameter to
5757         std::string.
5758         (find_separate_debug_file): Return std::string.
5759         (find_separate_debug_file_by_debuglink): Return std::string.
5760         * symfile.h (find_separate_debug_file_by_debuglink): Return
5761         std::string.
5762
5763 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
5764
5765         * common/xml-utils.c (xml_escape_text): Move code to...
5766         (xml_escape_text_append): ... this new function.
5767         * common/xml-utils.h (xml_escape_text_append): New declaration.
5768         * unittests/xml-utils-selftests.c (test_xml_escape_text_append):
5769         New function.
5770         (_initialize_xml_utils): register test_xml_escape_text_append as
5771         a selftest.
5772
5773 2018-03-07  Alan Hayward  <alan.hayward@arm.com>
5774
5775         * defs.h: Remove MAX_REGISTER_SIZE.
5776         * regcache.c (init_regcache_descr): Remove MAX_REGISTER_SIZE
5777         asserts.
5778         * python/py-unwind.c (pyuw_sniffer): Likewise.
5779
5780 2018-03-07  Tom Tromey  <tom@tromey.com>
5781
5782         * linux-tdep.c (linux_info_proc): Update.
5783         * target.h (struct target_ops) <to_fileio_readlink>: Return
5784         optional<string>.
5785         (target_fileio_readlink): Return optional<string>.
5786         * remote.c (remote_hostio_readlink): Return optional<string>.
5787         * inf-child.c (inf_child_fileio_readlink): Return
5788         optional<string>.
5789         * target.c (target_fileio_readlink): Return optional<string>.
5790
5791 2018-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5792
5793         * regcache.c (cooked_read_test): Add riscv to the list of
5794         architectures that have a save_reggroup.
5795
5796 2018-03-07  Andreas Arnez  <arnez@linux.vnet.ibm.com>
5797
5798         * gnu-v3-abi.c (gnuv3_rtti_type): Add early exit if the given
5799         value is not a dynamic class object.
5800
5801 2018-03-06  Tom Tromey  <tom@tromey.com>
5802
5803         * rust-exp.y: Formatting fixes.
5804
5805 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5806
5807         * riscv-tdep.c (riscv_register_name): Remove target description
5808         support.
5809         (riscv_gdbarch_init): Remove target description check.
5810
5811 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5812
5813         * riscv-tdep.c: Remove 'Contributed by ...' lines from header
5814         comment.
5815         * riscv-tdep.h: Likewise.
5816
5817 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5818
5819         * riscv-tdep.c (riscv_pseudo_register_read): Delete.
5820         (riscv_pseudo_register_write): Delete.
5821         (riscv_gdbarch_init): Remove all use of pseudo registers.
5822
5823 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
5824
5825         * record-btrace.c (btrace_print_lines): Replace cleanup
5826         parameter with RAII equivalents.
5827         (btrace_insn_history): Replace cleanup with RAII equivalents.
5828         * ui-out.h (make_cleanup_ui_out_list_begin_end,
5829         make_cleanup_ui_out_tuple_begin_end): Remove.
5830         * ui-out.c (struct ui_out_end_cleanup_data, do_cleanup_end,
5831         make_cleanup_ui_out_end, make_cleanup_ui_out_tuple_begin_end,
5832         make_cleanup_ui_out_list_begin_end): Remove.
5833
5834 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
5835
5836         * record-btrace.c (record_btrace_maybe_mark_async_event): Change
5837         parameter types to std::vector.  Use bool.
5838         (record_btrace_wait): Replace VEC(tp_t) with
5839         std::vector<thread_info *>.
5840         * common/gdb_vecs.h (unordered_remove, ordered_remove): New.
5841
5842 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
5843
5844         * record-btrace.c (record_btrace_disable_callback): Remove.
5845         (struct scoped_btrace_disable): New.
5846         (record_btrace_open): Use scoped_btrace_disable.
5847
5848 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5849
5850         * riscv-tdep.c (riscv_return_value): Change type to ULONGEST for
5851         reading values from registers.
5852
5853 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5854
5855         * riscv-tdep.c (riscv_push_dummy_call): Use core_addr_to_string_nz
5856         where appropriate.
5857
5858 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5859
5860         * riscv-tdep.c (riscv_print_arg_location): Add header comment,
5861         change parameter type.  Use GDB's print functions, and use
5862         core_addr_to_string where appropriate.
5863         (riscv_push_dummy_call): Use core_addr_to_string where
5864         appropriate, update call to riscv_print_arg_location, and reindent
5865         a few lines.
5866         (riscv_return_value): Update call to riscv_print_arg_location.
5867
5868 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5869             Tim Newsome <tim@sifive.com>
5870             Albert Ou <a0u@eecs.berkeley.edu>
5871             Darius Rad <darius@bluespec.com>
5872
5873         * Makefile.in (ALL_TARGET_OBS): Add riscv-tdep.o
5874         (HFILES_NO_SRCDIR): Add riscv-tdep.h.
5875         (ALLDEPFILES): Add riscv-tdep.c
5876         * configure.tgt: Add riscv support.
5877         * riscv-tdep.c: New file.
5878         * riscv-tdep.h: New file.
5879         * NEWS: Mention new target.
5880         * MAINTAINERS: Add entry for riscv.
5881
5882 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5883
5884         * amd64-tdep.c (amd64_classify_aggregate): Ignore zero sized
5885         fields within aggregates.
5886
5887 2018-03-04  Simon Marchi  <simon.marchi@polymtl.ca>
5888
5889         * record-btrace.c (btrace_print_lines): Change type of flags to
5890         gdb_disassembly_flags.
5891
5892 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
5893
5894         * fbsd-nat.c: Include "inf-ptrace.h".
5895         (USE_SIGTRAP_SIGINFO): Conditionally define.
5896         [USE_SIGTRAP_SIGINFO] (fbsd_handle_debug_trap): New function.
5897         (fbsd_wait) [USE_SIGTRAP_SIGINFO]: Call "fbsd_handle_debug_trap".
5898         [USE_SIGTRAP_SIGINFO] (fbsd_stopped_by_sw_breakpoint): New
5899         function.
5900         [USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_sw_breakpoint):
5901         Likewise.
5902         [USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_hw_breakpoint):
5903         Likewise.
5904         (fbsd_nat_add_target) [USE_SIGTRAP_SIGINFO]: Set
5905         "stopped_by_sw_breakpoint", "supports_stopped_by_sw_breakpoint",
5906         "supports_stopped_by_hw_breakpoint" target methods.
5907
5908 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
5909
5910         * NEWS (Changes since GDB 8.1): Add "set/show debug fbsd-nat".
5911         * fbsd-nat.c (debug_fbsd_nat): New variable.
5912         (show_fbsd_nat_debug): New function.
5913         (fbsd_wait): Log LWP info if "debug_fbsd_nat" is enabled.
5914         (_initialize_fbsd_nat): Add "fbsd-nat" debug boolean command.
5915
5916 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
5917
5918         * nat/x86-dregs.c (x86_dr_stopped_by_hw_breakpoint): New function.
5919         * nat/x86-dregs.h (x86_dr_stopped_by_hw_breakpoint): New
5920         prototype.
5921         * x86-nat.c (x86_stopped_by_hw_breakpoint): New function.
5922         (x86_use_watchpoints): Set "stopped_by_hw_breakpoint" target
5923         method.
5924
5925 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5926
5927         * common/gdb_vecs.c (free_char_ptr_vec): Remove.
5928         * common/gdb_vecs.h (free_char_ptr_vec): Remove.
5929
5930 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5931
5932         * charset.c (struct charset_vector): New.
5933         (charsets): Change type to charset_vector.
5934         (find_charset_names): Adjust.
5935         (add_one): Adjust.
5936         (_initialize_charset): Adjust.
5937
5938 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5939
5940         * progspace.h (struct program_space) <deleted_solibs>: Change
5941         type to std::vector<std::string>.
5942         * progspace.c (clear_program_space_solib_cache): Adjust.
5943         * breakpoint.c (print_solib_event): Adjust.
5944         (check_status_catch_solib): Adjust.
5945         * solib.c (update_solib_list): Adjust.
5946         * ui-out.h (class ui_out) <field_string>: New overload.
5947         * ui-out.c (ui_out::field_string): New overload.
5948
5949 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5950
5951         * progspace.h (struct program_space): Add constructor and
5952         destructor, initialize fields.
5953         (add_program_space): Remove.
5954         * progspace.c (add_program_space): Rename to...
5955         (program_space::program_space): ... this.
5956         (release_program_space): Rename to...
5957         (program_space::~program_space): ... this.
5958         (delete_program_space): Use delete to delete program_space.
5959         (initialize_progspace): Use new to allocate program_space.
5960         * inferior.c (add_inferior_with_spaces): Likewise.
5961         (clone_inferior_command): Likewise.
5962         * infrun.c (follow_fork_inferior): Likewise.
5963         (handle_vfork_child_exec_or_exit): Likewise.
5964
5965 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5966
5967         * common/gdb_vecs.h (make_cleanup_free_char_ptr_vec): Remove.
5968         (delim_string_to_char_ptr_vec): Return std::vector of
5969         gdb::unique_xmalloc_ptr.
5970         (dirnames_to_char_ptr_vec_append): Take std::vector of
5971         gdb::unique_xmalloc_ptr.
5972         (dirnames_to_char_ptr_vec): Return std::vector of
5973         gdb::unique_xmalloc_ptr.
5974         * common/gdb_vecs.c (delim_string_to_char_ptr_vec_append):
5975         Take std::vector of gdb::unique_xmalloc_ptr, adjust the code.
5976         (delim_string_to_char_ptr_vec): Return an std::vector of
5977         gdb::unique_xmalloc_ptr, adjust the code.
5978         (dirnames_to_char_ptr_vec_append): Take an std::vector of
5979         gdb::unique_xmalloc_ptr, adjust the code.
5980         (dirnames_to_char_ptr_vec): Return an std::vector of
5981         gdb::unique_xmalloc_ptr, adjust the code.
5982         * auto-load.c (auto_load_safe_path_vec): Change type to
5983         std::vector of gdb::unique_xmalloc_ptr.
5984         (auto_load_expand_dir_vars): Return an std::vector of
5985         gdb::unique_xmalloc_ptr, adjust the code.
5986         (auto_load_safe_path_vec_update): Adjust.
5987         (filename_is_in_auto_load_safe_path_vec): Adjust.
5988         (auto_load_objfile_script_1): Adjust.
5989         * build-id.c (build_id_to_debug_bfd): Adjust.
5990         * linux-thread-db.c (thread_db_load_search): Adjust.
5991         * source.c (add_path): Adjust.
5992         (openp): Adjust.
5993         * symfile.c (find_separate_debug_file): Adjust.
5994         * utils.c (do_free_char_ptr_vec): Remove.
5995         (make_cleanup_free_char_ptr_vec): Remove.
5996
5997 2018-03-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5998
5999         PR gdb/22907
6000         * common/pathstuff.c: Conditionally include "<windows.h>".
6001
6002 2018-03-01  Georg Sauthoff  <mail@georg.so>
6003
6004         PR gdb/22888
6005         * gcore.in: Quote variables and switch interpreter to bash.
6006
6007 2018-03-01  Tom Tromey  <tom@tromey.com>
6008
6009         * dwarf2read.c (alloc_discriminant_info): Fix default_index
6010         assertion.  Add assertion for discriminant_index.
6011         (quirk_rust_enum): Use correct base type name in univariant case.
6012
6013 2018-03-01  Simon Marchi  <simon.marchi@ericsson.com>
6014
6015         * record.c (get_call_history_modifiers): Return a
6016         record_print_flags.
6017         (cmd_record_call_history): Adjust.
6018         * record-btrace.c (record_btrace_call_history): Adjust.
6019         (record_btrace_call_history_range): Adjust.
6020         (record_btrace_call_history_from): Adjust.
6021         * target-debug.h (target_debug_print_record_print_flags): New.
6022         * target-delegates.c: Re-generate.
6023         * target.c (target_call_history): Change flags type.
6024         (target_call_history_from): Likewise.
6025         (target_call_history_range): Likewise.
6026         * target.h (struct target_ops) <target_call_history>: Likewise.
6027         (target_call_history_from): Likewise.
6028         (target_call_history_range): Likewise.
6029
6030 2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>
6031             Simon Marchi  <simon.marchi@polymtl.ca>
6032
6033         * common/common-utils.c: Include "sys/stat.h".
6034         (is_regular_file): Move here from "source.c"; change return
6035         type to "bool".
6036         * common/common-utils.h (is_regular_file): New prototype.
6037         * common/pathstuff.c (contains_dir_separator): New function.
6038         * common/pathstuff.h (contains_dir_separator): New prototype.
6039         * source.c: Don't include "sys/stat.h".
6040         (is_regular_file): Move to "common/common-utils.c".
6041
6042 2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>
6043
6044         * Makefile.in (COMMON_SFILES): Add "common/pathstuff.c".
6045         (HFILES_NO_SRCDIR): Add "common/pathstuff.h".
6046         * auto-load.c: Include "common/pathstuff.h".
6047         * common/common-def.h (current_directory): Move here.
6048         * common/gdb_tilde_expand.c (gdb_tilde_expand_up): New
6049         function.
6050         * common/gdb_tilde_expand.h (gdb_tilde_expand_up): New
6051         prototype.
6052         * common/pathstuff.c: New file.
6053         * common/pathstuff.h: New file.
6054         * compile/compile.c: Include "common/pathstuff.h".
6055         * defs.h (current_directory): Move to "common/common-defs.h".
6056         * dwarf2read.c: Include "common/pathstuff.h".
6057         * exec.c: Likewise.
6058         * guile/scm-safe-call.c: Likewise.
6059         * linux-thread-db.c: Likewise.
6060         * main.c: Likewise.
6061         * nto-tdep.c: Likewise.
6062         * objfiles.c: Likewise.
6063         * source.c: Likewise.
6064         * symtab.c: Likewise.
6065         * utils.c: Include "common/pathstuff.h".
6066         (gdb_realpath): Move to "common/pathstuff.c".
6067         (gdb_realpath_keepfile): Likewise.
6068         (gdb_abspath): Likewise.
6069         * utils.h (gdb_realpath): Move to "common/pathstuff.h".
6070         (gdb_realpath_keepfile): Likewise.
6071         (gdb_abspath): Likewise.
6072
6073 2018-02-28  John Baldwin  <jhb@FreeBSD.org>
6074
6075         * fbsd-nat.c (fbsd_resume): Use PT_SETSTEP for stepping and a
6076         wildcard process pid for super_resume for kernels with a
6077         specific bug.
6078
6079 2018-02-27  Phil Muldoon  <pmuldoon@redhat.com>
6080
6081         * compile/compile.c (get_args): Add additional comments
6082         explaining function.
6083
6084 2018-02-27  Simon Marchi  <simon.marchi@polymtl.ca>
6085             Tom Tromey  <tom@tromey.com>
6086
6087         * target.h (memory_write_request_s): Remove typedef.  Don't define
6088         VEC.
6089         (target_write_memory_blocks): Change argument to std::vector.
6090         (struct memory_write_request): Add constructor.
6091         * target-memory.c (compare_block_starting_address): Return bool.
6092         Change argument types.
6093         (claim_memory): Change arguments to use std::vector.
6094         (split_regular_and_flash_blocks, blocks_to_erase)
6095         (compute_garbled_blocks): Likewise.
6096         (cleanup_request_data, cleanup_write_requests_vector): Remove.
6097         (target_write_memory_blocks): Change argument to std::vector.
6098         * symfile.c (struct load_section_data): Add constructor and
6099         destructor.  Use std::vector for "requests".
6100         (struct load_progress_data): Add initializers.
6101         (load_section_callback): Update.  Use "new".
6102         (clear_memory_write_data): Remove.
6103         (generic_load): Update.
6104
6105 2018-02-27  Alan Hayward  <alan.hayward@arm.com>
6106
6107         * arch/aarch64.h: Use common/tdesc.h.
6108
6109 2018-02-26  Maciej W. Rozycki  <macro@mips.com>
6110
6111         * mips-tdep.c (mips_gdbarch_init): Don't use a 32-bit BFD
6112         architecture with a 64-bit ABI.
6113
6114 2018-02-26  Maciej W. Rozycki  <macro@mips.com>
6115
6116         * gdb/mips-tdep.c (mips_gdbarch_init): Reorder ABI determination
6117         ahead of target description loading.
6118
6119 2018-02-26  Tom Tromey  <tom@tromey.com>
6120
6121         * stack.c (backtrace_command_1): Update.
6122         * python/python-internal.h (gdbpy_apply_frame_filter): Change type
6123         of "flags".
6124         * python/py-framefilter.c (py_print_frame)
6125         (gdbpy_apply_frame_filter): Change type of "flags".
6126         * mi/mi-cmd-stack.c (mi_apply_ext_lang_frame_filter): Change type
6127         of "flags".
6128         (mi_cmd_stack_list_frames, mi_cmd_stack_list_locals)
6129         (mi_cmd_stack_list_args, mi_cmd_stack_list_variables): Update.
6130         * extension.h (enum frame_filter_flag): Rename from
6131         frame_filter_flags.
6132         (frame_filter_flags): Define using DEF_ENUM_FLAGS_TYPE.
6133         (apply_ext_lang_frame_filter): Change type of "flags".
6134         * extension.c (apply_ext_lang_frame_filter): Change type of
6135         "flags".
6136         * extension-priv.h (struct extension_language_ops)
6137         <apply_frame_filter>: Change type of "flags".
6138
6139 2018-02-26  Tom Tromey  <tom@tromey.com>
6140
6141         PR python/16497:
6142         * stack.c (backtrace_command_1): Set PRINT_MORE_FRAMES flag.  Fix
6143         off-by-one in py_end computation.
6144         * python/py-framefilter.c (gdbpy_apply_frame_filter): Handle
6145         PRINT_MORE_FRAMES.
6146         * extension.h (enum frame_filter_flags) <PRINT_MORE_FRAMES>: New
6147         constant.
6148
6149 2018-02-26  Tom Tromey  <tom@tromey.com>
6150
6151         * dwarf2read.c (struct variant_field): New.
6152         (struct nextfield) <variant>: New field.
6153         (dwarf2_add_field): Handle DW_TAG_variant_part.
6154         (dwarf2_attach_fields_to_type): Attach a discriminant_info to a
6155         discriminated union.
6156         (read_structure_type): Handle DW_TAG_variant_part.
6157         (handle_struct_member_die): New function, extracted from
6158         process_structure_scope.  Handle DW_TAG_variant.
6159         (process_structure_scope): Handle discriminated unions.  Call
6160         handle_struct_member_die.
6161
6162 2018-02-26  Tom Tromey  <tom@tromey.com>
6163
6164         * rust-lang.h (rust_last_path_segment): Declare.
6165         * rust-lang.c (rust_last_path_segment): Now public.  Change
6166         contract.
6167         (struct disr_info): Remove.
6168         (RUST_ENUM_PREFIX, RUST_ENCODED_ENUM_REAL)
6169         (RUST_ENCODED_ENUM_HIDDEN, rust_union_is_untagged)
6170         (rust_get_disr_info, rust_tuple_variant_type_p): Remove.
6171         (rust_enum_p, rust_enum_variant): New function.
6172         (rust_underscore_fields): Remove "offset" parameter.
6173         (rust_print_enum): New function.
6174         (rust_val_print) <TYPE_CODE_UNION>: Remove enum code.
6175         <TYPE_CODE_STRUCT>: Call rust_print_enum when appropriate.
6176         (rust_print_struct_def): Add "for_rust_enum" parameter.  Handle
6177         enums.
6178         (rust_internal_print_type): New function, from rust_print_type.
6179         Remove enum code.
6180         (rust_print_type): Call rust_internal_print_type.
6181         (rust_evaluate_subexp) <STRUCTOP_ANONYMOUS, STRUCTOP_STRUCT>:
6182         Update enum handling.
6183         * dwarf2read.c (struct dwarf2_cu) <rust_unions>: New field.
6184         (rust_fully_qualify, alloc_discriminant_info, quirk_rust_enum)
6185         (rust_union_quirks): New functions.
6186         (process_full_comp_unit, process_full_type_unit): Call
6187         rust_union_quirks.
6188         (process_structure_scope): Update rust_unions if necessary.
6189
6190 2018-02-26  Tom Tromey  <tom@tromey.com>
6191
6192         * value.h (value_union_variant): Declare.
6193         * valops.c (value_union_variant): New function.
6194         * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): New macro.
6195         (struct discriminant_info): New.
6196         (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: New
6197         enumerator.
6198         (struct main_type) <flag_discriminated_union>: New field.
6199
6200 2018-02-26  Tom Tromey  <tom@tromey.com>
6201
6202         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6203         unittests/unpack-selftests.c.
6204         * unittests/unpack-selftests.c: New file.
6205         * value.c (unpack_bits_as_long): Fix bugs in non-bitfield cases.
6206
6207 2018-02-26  Yao Qi  <yao.qi@linaro.org>
6208
6209         * dwarf2read.c (struct partial_die_info) <read>: New method.
6210         (read_partial_die): Remove the declaration.
6211         (load_partial_dies): Update.
6212         (partial_die_info::partial_die_info):
6213         (read_partial_die): Change it to partial_die_info::read.
6214
6215 2018-02-26  Yao Qi  <yao.qi@linaro.org>
6216
6217         * dwarf2read.c (struct partial_die_info) <fixup>: New method.
6218         (fixup_partial_die): Remove declaration.
6219         (scan_partial_symbols): Update.
6220         (partial_die_parent_scope): Likewise.
6221         (partial_die_full_name): Likewise.
6222         (fixup_partial_die): Change it to partial_die_info::fixup.
6223
6224 2018-02-26  Yao Qi  <yao.qi@linaro.org>
6225
6226         * dwarf2read.c (read_partial_die): Update the declaration.
6227         (load_partial_dies): Caller update.
6228         (read_partial_die): Remove one argument abbrev_len.
6229
6230 2018-02-26  Yao Qi  <yao.qi@linaro.org>
6231
6232         * dwarf2read.c (struct partial_die_info): Add ctor, delete
6233         assignment operator.
6234         (load_partial_dies): Use ctor and copy ctor.
6235         (read_partial_die): Update.
6236         (dwarf2_cu::find_partial_die): Use ctor.
6237
6238 2018-02-26  Yao Qi  <yao.qi@linaro.org>
6239
6240         * dwarf2read.c (struct dwarf2_cu) <find_partial_die>: New method.
6241         (find_partial_die_in_comp_unit): Change it to
6242         dwarf2_cu::find_partial_die.
6243         (find_partial_die): Update.
6244
6245 2018-02-26  Yao Qi  <yao.qi@linaro.org>
6246
6247         * dwarf2read.c (read_partial_die): Remove the code checking abbrev
6248         is NULL.
6249
6250 2018-02-26  Yao Qi  <yao.qi@linaro.org>
6251
6252         * dwarf2read.c (load_partial_dies): Move the location of XOBNEW.
6253
6254 2018-02-26  Alan Hayward  <alan.hayward@arm.com>
6255
6256         * arch/amd64.h: Use common/tdesc.h.
6257         * arch/i386.c: Likewise.
6258         * arch/i386.h: Likewise.
6259         * arch/tic6x.c: Likewise.
6260         * arch/tdesc.h: Move file from here...
6261         * common/tdesc.h: ...to here.
6262         * features/aarch64-core.c: Regenerate.
6263         * features/aarch64-fpu.c: Regenerate.
6264         * features/i386/32bit-avx.c: Regenerate.
6265         * features/i386/32bit-avx512.c: Regenerate.
6266         * features/i386/32bit-core.c: Regenerate.
6267         * features/i386/32bit-linux.c: Regenerate.
6268         * features/i386/32bit-mpx.c: Regenerate.
6269         * features/i386/32bit-pkeys.c: Regenerate.
6270         * features/i386/32bit-sse.c: Regenerate.
6271         * features/i386/64bit-avx.c: Regenerate.
6272         * features/i386/64bit-avx512.c: Regenerate.
6273         * features/i386/64bit-core.c: Regenerate.
6274         * features/i386/64bit-linux.c: Regenerate.
6275         * features/i386/64bit-mpx.c: Regenerate.
6276         * features/i386/64bit-pkeys.c: Regenerate.
6277         * features/i386/64bit-segments.c: Regenerate.
6278         * features/i386/64bit-sse.c: Regenerate.
6279         * features/i386/x32-core.c: Regenerate.
6280         * features/tic6x-c6xp.c: Regenerate.
6281         * features/tic6x-core.c: Regenerate.
6282         * features/tic6x-gp.c: Regenerate.
6283         * target-descriptions.c: Use common/tdesc.h.
6284         * target-descriptions.h: Likewise.
6285
6286 2018-02-24  Tom Tromey  <tom@tromey.com>
6287
6288         * linux-thread-db.c (try_thread_db_load_from_pdir_1)
6289         (try_thread_db_load_from_dir, thread_db_load_search): Use
6290         std::string.
6291         (info_auto_load_libthread_db_compare): Return bool.  Change
6292         argument types.
6293         (info_auto_load_libthread_db): Use std::vector, std::string.
6294         Remove cleanups.
6295
6296 2018-02-24  Tom Tromey  <tom@tromey.com>
6297
6298         * i386-tdep.c (i386_fast_tracepoint_valid_at): "msg" now a
6299         std::string.
6300         * gdbarch.sh (fast_tracepoint_valid_at): Change "msg" to a
6301         std::string*.
6302         * gdbarch.c: Rebuild.
6303         * gdbarch.h: Rebuild.
6304         * breakpoint.c (check_fast_tracepoint_sals): Use std::string.
6305         * arch-utils.h (default_fast_tracepoint_valid_at): Update.
6306         * arch-utils.c (default_fast_tracepoint_valid_at): "msg" now a
6307         std::string*.
6308
6309 2018-02-23  Simon Marchi  <simon.marchi@polymtl.ca>
6310
6311         * gdbtypes.h (sect_offset): Change type to uint64_t.
6312         (sect_offset_str): New function.
6313         * dwarf2read.c (create_addrmap_from_aranges): Use
6314         sect_offset_str.
6315         (error_check_comp_unit_head): Likewise.
6316         (create_debug_type_hash_table): Likewise.
6317         (read_cutu_die_from_dwo): Likewise.
6318         (init_cutu_and_read_dies): Likewise.
6319         (init_cutu_and_read_dies_no_follow): Likewise.
6320         (process_psymtab_comp_unit_reader): Likewise.
6321         (partial_die_parent_scope): Likewise.
6322         (peek_die_abbrev): Likewise.
6323         (process_queue): Likewise.
6324         (dwarf2_physname): Likewise.
6325         (read_namespace_alias): Likewise.
6326         (read_import_statement): Likewise.
6327         (create_dwo_cu_reader): Likewise.
6328         (create_cus_hash_table): Likewise.
6329         (lookup_dwo_cutu): Likewise.
6330         (inherit_abstract_dies): Likewise.
6331         (read_func_scope): Likewise.
6332         (read_call_site_scope): Likewise.
6333         (dwarf2_add_member_fn): Likewise.
6334         (read_common_block): Likewise.
6335         (read_module_type): Likewise.
6336         (read_typedef): Likewise.
6337         (read_subrange_type): Likewise.
6338         (load_partial_dies): Likewise.
6339         (read_partial_die): Likewise.
6340         (find_partial_die): Likewise.
6341         (read_str_index): Likewise.
6342         (dwarf2_string_attr): Likewise.
6343         (build_error_marker_type): Likewise.
6344         (lookup_die_type): Likewise.
6345         (dump_die_shallow): Likewise.
6346         (follow_die_ref): Likewise.
6347         (dwarf2_fetch_die_loc_sect_off): Likewise.
6348         (dwarf2_fetch_constant_bytes): Likewise.
6349         (follow_die_sig): Likewise.
6350         (get_signatured_type): Likewise.
6351         (get_DW_AT_signature_type): Likewise.
6352         (dwarf2_find_containing_comp_unit): Likewise.
6353         (set_die_type): Likewise.
6354
6355 2018-02-21  John Baldwin  <jhb@FreeBSD.org>
6356
6357         * arch/aarch64.c: Include "common-defs.h".
6358         * arch/amd64.c: Likewise.
6359         * arch/i386.c: Likewise.
6360
6361 2018-02-21  Tom Tromey  <tom@tromey.com>
6362
6363         * value.h: (extract_field_op): Update.
6364         * eval.c (extract_field_op): Return a const char *.
6365         * expression.h (parse_expression_for_completion): Update.
6366         * completer.c (complete_expression): Update.
6367         (add_struct_fields): Make fieldname const.
6368         * parse.c (expout_completion_name): Now a unique_xmalloc_ptr.
6369         (mark_completion_tag, parse_exp_in_context_1): Update.
6370         (parse_expression_for_completion): Change "name" to
6371         unique_xmalloc_ptr*.
6372
6373 2018-02-21  Tom Tromey  <tom@tromey.com>
6374
6375         * infcall.c (call_function_by_hand_dummy): Use std::vector.
6376
6377 2018-02-21  Yao Qi  <yao.qi@linaro.org>
6378
6379         * avr-tdep.c (avr_read_pc): Change parameter type to
6380         readable_regcache.
6381         * gdbarch.sh (read_pc): Likewise.
6382         * gdbarch.c: Re-generated.
6383         * gdbarch.h: Re-generated.
6384         * hppa-tdep.c (hppa_read_pc): Change parameter type to
6385         readable_regcache.
6386         * ia64-tdep.c (ia64_read_pc): Likewise.
6387         * mips-tdep.c (mips_read_pc): Likewise.
6388         * spu-tdep.c (spu_read_pc): Likewise.
6389
6390 2018-02-21  Yao Qi  <yao.qi@linaro.org>
6391
6392         * Makefile.in (COMMON_SFILES): Add regcache-dump.c
6393         * regcache-dump.c: New file.
6394         * regcache.c: Move register_dump to regcache-dump.c.
6395         (maintenance_print_registers): Likewise.
6396         (maintenance_print_raw_registers): Likewise.
6397         (maintenance_print_cooked_registers): Likewise.
6398         (maintenance_print_register_groups): Likewise.
6399         (maintenance_print_remote_registers): Likewise.
6400         (_initialize_regcache): Likewise.
6401         * regcache.h (register_dump): Moved from regcache.c.
6402
6403 2018-02-21  Yao Qi  <yao.qi@linaro.org>
6404
6405         * regcache.c (regcache::regcache): Update.
6406         (regcache::invalidate): Move it to detached_regcache::invalidate.
6407         (get_thread_arch_aspace_regcache): Update.
6408         (regcache::raw_update): Update.
6409         (regcache::cooked_read): Remove some code.
6410         (regcache::cooked_read_value): Likewise.
6411         (regcache::raw_write): Remove assert on m_readonly_p.
6412         (regcache::raw_supply_integer): Move it to
6413         detached_regcache::raw_supply_integer.
6414         (regcache::raw_supply_zeroed): Likewise.
6415         * regcache.h (detached_regcache) <raw_supply_integer>: New
6416         declaration.
6417         <raw_supply_zeroed, invalidate>: Likewise.
6418         (regcache) <raw_supply_integer, raw_supply_zeroed>: Removed.
6419         <invalidate>: Likewise.
6420         <m_readonly_p>: Removed.
6421
6422 2018-02-21  Yao Qi  <yao.qi@linaro.org>
6423
6424         * infcmd.c (get_return_value): Let stop_regs point to
6425         get_current_regcache.
6426         * regcache.c (regcache::regcache): Remove.
6427         (register_dump_reg_buffer): New class.
6428         (regcache_print): Adjust.
6429         * regcache.h (regcache): Remove constructors.
6430
6431 2018-02-21  Yao Qi  <yao.qi@linaro.org>
6432
6433         * regcache.c (class register_dump): New class.
6434         (register_dump_regcache, register_dump_none): New class.
6435         (register_dump_remote, register_dump_groups): New class.
6436         (regcache_print): Update.
6437         * regcache.h (regcache_dump_what): Move it to regcache.c.
6438         (regcache) <dump>: Remove.
6439
6440 2018-02-21  Yao Qi  <yao.qi@linaro.org>
6441
6442         * jit.c (struct jit_unwind_private) <regcache>: Change its type to
6443          reg_buffer_rw *.
6444         (jit_unwind_reg_set_impl): Call raw_supply.
6445         (jit_frame_sniffer): Use reg_buffer_rw.
6446         * record-full.c (record_full_core_regbuf): Change its type.
6447         (record_full_core_open_1): Use reg_buffer_rw.
6448         (record_full_close): Likewise.
6449         (record_full_core_fetch_registers): Use regcache->raw_supply.
6450         (record_full_core_store_registers): Likewise.
6451         * regcache.c (regcache::get_register_status): Move it to
6452         reg_buffer.
6453         (regcache_raw_set_cached_value): Remove.
6454         (regcache::raw_set_cached_value): Remove.
6455         (regcache::raw_write): Call raw_supply.
6456         (regcache::raw_supply): Move it to reg_buffer_rw.
6457         * regcache.h (regcache_raw_set_cached_value): Remove.
6458         (reg_buffer_rw): New class.
6459
6460 2018-02-21  Yao Qi  <yao.qi@linaro.org>
6461
6462         * dummy-frame.c (dummy_frame_cache) <prev_regcache>: Use
6463         readonly_detached_regcache.
6464         (dummy_frame_prev_register): Use regcache->cooked_read.
6465         * frame.c (frame_save_as_regcache): Change return type.
6466         (frame_pop): Update.
6467         * frame.h (frame_save_as_regcache): Update declaration.
6468         * inferior.h (get_infcall_suspend_state_regcache): Update
6469         declaration.
6470         * infrun.c (infcall_suspend_state) <registers>: use
6471         readonly_detached_regcache.
6472         (save_infcall_suspend_state): Don't use regcache_dup.
6473         (get_infcall_suspend_state_regcache): Change return type.
6474         * linux-fork.c (struct fork_info) <savedregs>: Change to
6475         readonly_detached_regcache.
6476         <pc>: New field.
6477         (fork_save_infrun_state): Don't use regcache_dup.
6478         (info_checkpoints_command): Adjust.
6479         * mi/mi-main.c (register_changed_p): Update declaration.
6480         (mi_cmd_data_list_changed_registers): Use
6481         readonly_detached_regcache.
6482         (register_changed_p): Change parameter type to
6483         readonly_detached_regcache.
6484         * ppc-linux-tdep.c (ppu2spu_cache) <regcache>: Use
6485         readonly_detached_regcache.
6486         (ppu2spu_sniffer): Construct a new readonly_detached_regcache.
6487         * regcache.c (readonly_detached_regcache::readonly_detached_regcache):
6488         New.
6489         (regcache::save): Move it to reg_buffer.
6490         (regcache::restore): Change parameter type.
6491         (regcache_dup): Remove.
6492         * regcache.h (reg_buffer) <save>: New method.
6493         (readonly_detached_regcache): New class.
6494         * spu-tdep.c (spu2ppu_cache) <regcache>: Use
6495         readonly_detached_regcache.
6496         (spu2ppu_sniffer): Construct a new readonly_detached_regcache.
6497
6498 2018-02-21  Yao Qi  <yao.qi@linaro.org>
6499
6500         * frame.c (frame_save_as_regcache): Use regcache method save.
6501         (frame_pop): Use regcache method restore.
6502         * infrun.c (restore_infcall_suspend_state): Likewise.
6503         * linux-fork.c (fork_load_infrun_state): Likewise.
6504         * ppc-linux-tdep.c (ppu2spu_sniffer): User regcache method
6505         save.
6506         * regcache.c (regcache_save): Remove.
6507         (regcache::restore): More asserts.
6508         (regcache_cpy): Remove.
6509         * regcache.h (regcache_save): Remove the declaration.
6510         (regcache::restore): Move from private to public.
6511         Remove the friend declaration of regcache_cpy.
6512         (regcache_cpy): Remove declaration.
6513
6514 2018-02-21  Yao Qi  <yao.qi@linaro.org>
6515
6516         * aarch64-tdep.c (aarch64_pseudo_register_read_value): Change
6517         parameter type to 'readable_regcache *'.
6518         * amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
6519         * arm-tdep.c (arm_neon_quad_read): Likewise.
6520         (arm_pseudo_read): Likewise.
6521         * avr-tdep.c (avr_pseudo_register_read): Likewise.
6522         * bfin-tdep.c (bfin_pseudo_register_read): Likewise.
6523         * frv-tdep.c (frv_pseudo_register_read): Likewise.
6524         * gdbarch.c: Re-generated.
6525         * gdbarch.h: Re-generated.
6526         * gdbarch.sh (pseudo_register_read): Change parameter type to
6527         'readable_regcache *'.
6528         (pseudo_register_read_value): Likewise.
6529         * h8300-tdep.c (pseudo_from_raw_register): Likewise.
6530         (h8300_pseudo_register_read): Likewise.
6531         * hppa-tdep.c (hppa_pseudo_register_read): Likewise.
6532         * i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
6533         (i386_pseudo_register_read_into_value): Likewise.
6534         (i386_pseudo_register_read_value): Likewise.
6535         * i386-tdep.h (i386_pseudo_register_read_into_value): Update
6536         declaration.
6537         * ia64-tdep.c (ia64_pseudo_register_read): Likewise.
6538         * m32c-tdep.c (m32c_raw_read): Likewise.
6539         (m32c_read_flg): Likewise.
6540         (m32c_banked_register): Likewise.
6541         (m32c_banked_read): Likewise.
6542         (m32c_sb_read): Likewise.
6543         (m32c_part_read): Likewise.
6544         (m32c_cat_read): Likewise.
6545         (m32c_r3r2r1r0_read): Likewise.
6546         (m32c_pseudo_register_read): Likewise.
6547         * m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
6548         * mep-tdep.c (mep_pseudo_cr32_read): Likewise.
6549         (mep_pseudo_cr64_read): Likewise.
6550         (mep_pseudo_register_read): Likewise.
6551         * mips-tdep.c (mips_pseudo_register_read): Likewise.
6552         * msp430-tdep.c (msp430_pseudo_register_read): Likewise.
6553         * nds32-tdep.c (nds32_pseudo_register_read): Likewise.
6554         * regcache.c (regcache::raw_read): Move it to readable_regcache.
6555         (regcache::cooked_read): Likewise.
6556         (regcache::cooked_read_value): Likewise.
6557         (regcache_cooked_read_signed):
6558         (regcache::cooked_read): Likewise.
6559         * regcache.h (readable_regcache): New class.
6560         (regcache): Inherit readable_regcache.  Move some methods to
6561         readable_regcache.
6562         * rl78-tdep.c (rl78_pseudo_register_read): Change
6563         parameter type to 'readable_regcache *'.
6564         * rs6000-tdep.c (do_regcache_raw_read): Remove.
6565         (e500_pseudo_register_read): Change parameter type to
6566         'readable_regcache *'.
6567         (dfp_pseudo_register_read): Likewise.
6568         (vsx_pseudo_register_read): Likewise.
6569         (efpr_pseudo_register_read): Likewise.
6570         * s390-tdep.c (s390_pseudo_register_read): Likewise.
6571         * sh-tdep.c (sh_pseudo_register_read): Likewise.
6572         * sh64-tdep.c (pseudo_register_read_portions): Likewise.
6573         (sh64_pseudo_register_read): Likewise.
6574         * sparc-tdep.c (sparc32_pseudo_register_read): Likewise.
6575         * sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
6576         * spu-tdep.c (spu_pseudo_register_read_spu): Likewise.
6577         (spu_pseudo_register_read): Likewise.
6578         * xtensa-tdep.c (xtensa_register_read_masked): Likewise.
6579         (xtensa_pseudo_register_read): Likewise.
6580
6581 2018-02-21  Yao Qi  <yao.qi@linaro.org>
6582
6583         * regcache.c (regcache::regcache): Call reg_buffer ctor.
6584         (regcache::arch): Move it to reg_buffer::arch.
6585         (regcache::register_buffer): Likewise.
6586         (regcache::assert_regnum): Likewise.
6587         (regcache::num_raw_registers): Likewise.
6588         * regcache.h (reg_buffer): New class.
6589         (regcache): Inherit reg_buffer.
6590
6591 2018-02-20  Simon Marchi  <simon.marchi@ericsson.com>
6592
6593         * remote-sim.c (gdb_os_printf_filtered, gdb_os_vprintf_filtered,
6594         gdb_os_evprintf_filtered, gdb_os_error): Add ATTRIBUTE_PRINTF.
6595
6596 2018-02-20  Markus Metzger  <markus.t.metzger@intel.com>
6597
6598         * gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Add mkstemp.
6599
6600 2018-02-19  Alan Hayward  <alan.hayward@arm.com>
6601
6602         * Makefile.in: (COMMON_SFILES): Add common/*.c files.
6603         (SFILES): Remove common/*.c files.
6604         (COMMON_OBS): Remove some *.o files built from common/*.c files.
6605         * common/common.host: Add common reference.
6606         * configure.ac: Likewise.
6607         * configure: Regenerate.
6608
6609 2018-02-16  Yao Qi  <yao.qi@linaro.org>
6610
6611         * block.c (block_namespace_info): Inherit allocate_on_obstack.
6612         (block_initialize_namespace): Use new.
6613         * dwarf2read.c (dwarf2_per_objfile): Inherit allocate_on_obstack.
6614         (dwarf2_free_objfile): Use delete.
6615         * gdbtypes.c (type_pair): Inherit allocate_on_obstack.
6616         (copy_type_recursive): Use new.
6617         * gdb_obstack.h (allocate_on_obstack): New.
6618
6619 2018-02-15  Yao Qi  <yao.qi@linaro.org>
6620
6621         PR gdb/22849
6622         * inferior.c (exit_inferior_1): Reset inf->control.
6623
6624 2018-02-15  Joel Brobecker  <brobecker@adacore.com>
6625
6626         * ada-lang.c (ada_to_fixed_value_create): Delete advance
6627         declaration.
6628
6629 2018-02-14  Pedro Alves  <palves@redhat.com>
6630
6631         * frame-unwind.c (frame_unwind_try_unwinder): Always call
6632         frame_cleanup_after_sniffer on exception.
6633
6634 2018-02-14  Tom Tromey  <tom@tromey.com>
6635
6636         * solist.h (struct target_so_ops) <bfd_open>: Make pathname
6637         const.
6638         (solib_bfd_open): Make pathname const.
6639         * solib.c (solib_bfd_open): Make pathname const.
6640         * solib-spu.c (spu_bfd_fopen): Make name const.
6641         (spu_bfd_open): Make pathname const.
6642         * solib-darwin.c (darwin_bfd_open): Make pathname const.
6643         * solib-aix.c (solib_aix_bfd_open): Make pathname const.
6644
6645 2018-02-14  Tom Tromey  <tom@tromey.com>
6646
6647         * symfile.c (symfile_bfd_open): Update.
6648         * source.h (openp, source_full_path_of, find_and_open_source):
6649         Change argument type to unique_xmalloc_ptr.
6650         * source.c (openp): Take a unique_xmalloc_ptr.
6651         (source_full_path_of, find_and_open_source): Likewise.
6652         (open_source_file, symtab_to_fullname): Update.
6653         * solist.h (struct target_so_ops) <find_and_open_solib>: Take a
6654         unique_xmalloc_ptr.
6655         * solib.c (solib_find_1): Use unique_xmalloc_ptr.
6656         (exec_file_find): Update.
6657         * psymtab.c (psymtab_to_fullname): Update.
6658         * nto-tdep.h (nto_find_and_open_solib): Update.
6659         * nto-tdep.c (nto_find_and_open_solib): Change temp_path to a
6660         unique_xmalloc_ptr.
6661         * exec.c (exec_file_attach): Update.
6662         * dwarf2read.c (try_open_dwop_file): Use unique_xmalloc_ptr.
6663         * cli/cli-cmds.c (find_and_open_script): Use unique_xmalloc_ptr.
6664
6665 2018-02-14  Tom Tromey  <tom@tromey.com>
6666
6667         * solib.c: Include source.h.
6668         * nto-tdep.c: Include source.h.
6669         * mi/mi-cmd-env.c: Include source.h.
6670         * infcmd.c: Include source.h.
6671         * exec.c: Include source.h.
6672         * defs.h (enum openp_flag, openp, source_full_path_of, mod_path)
6673         (add_path, directory_switch, source_path, init_source_path): Move
6674         declarations...
6675         * source.h (enum openp_flag, openp, source_full_path_of, mod_path)
6676         (add_path, directory_switch, source_path, init_source_path):
6677         ...here.
6678
6679 2018-02-14  Tom Tromey  <tom@tromey.com>
6680
6681         * solist.h (exec_file_find, solib_find): Return
6682         unique_xmalloc_ptr.
6683         (solib_bfd_fopen): Take a const char *.
6684         * solib.c (solib_find_1): Return unique_xmalloc_ptr.
6685         (exec_file_find, solib_find): Likewise.
6686         (solib_bfd_fopen): Do not take ownership of "pathname".
6687         (solib_bfd_open): Use unique_xmalloc_ptr.
6688         * solib-darwin.c (darwin_bfd_open): Use unique_xmalloc_ptr.
6689         * solib-aix.c (solib_aix_bfd_open): Use unique_xmalloc_ptr.
6690         * infrun.c (follow_exec): Use unique_xmalloc_ptr.
6691         * exec.c (exec_file_locate_attach): Use unique_xmalloc_ptr.
6692
6693 2018-02-14  Joel Brobecker  <brobecker@adacore.com>
6694
6695         * ada-lang.c (name_match_type_from_name): Remove reference to
6696         ada_name_for_lookup in function's documentation.
6697         * ada-lang.h (ada_name_for_lookup): Delete declaration.
6698
6699 2018-02-13  Simon Marchi  <simon.marchi@polymtl.ca>
6700
6701         * defs.h (enum openp_flags): New enum.
6702         (OPF_TRY_CWD_FIRST, OPF_SEARCH_IN_PATH, OPF_RETURN_REALPATH):
6703         Move to enum openp_flags.
6704         (openp_flags): New enum flags.
6705         (openp): Change parameter type to openp_flags.
6706         * source.c (openp): Change parameter type to openp_flags.
6707         * cli/cli-cmds.c (find_and_open_script): Use openp_flags.
6708         * dwarf2read.c (try_open_dwop_file): Use openp_flags.
6709
6710 2018-02-13  Simon Marchi  <simon.marchi@polymtl.ca>
6711
6712         * maint.c (_initialize_maint_cmds): Fix prefix of maint set/show
6713         per-command.
6714
6715 2018-02-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6716
6717         * dwarf2read.c (dwarf2_release_queue): Delete function, move body
6718         into...
6719         (class dwarf2_queue_guard): ...the destructor of this new class.
6720         (dw2_do_instantiate_symtab): Create instance of the new class
6721         dwarf2_queue_guard, remove cleanup.
6722
6723 2018-02-09  Tom Tromey  <tom@tromey.com>
6724
6725         * source.c (find_source_lines): Don't reference past the end of
6726         the vector.
6727
6728 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6729
6730         * remote.c (remote_btrace_maybe_reopen): Change error message.
6731         * btrace.c (btrace_enable): Likewise.
6732         (parse_xml_btrace): Likewise.
6733         (parse_xml_btrace_conf): Likewise.
6734
6735 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6736
6737         * nat/linux-btrace.c (diagnose_perf_event_open_fail): New.
6738         (linux_enable_pt, linux_enable_bts): Call
6739         diagnose_perf_event_open_fail.
6740
6741 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6742
6743         * nat/linux-btrace.c (perf_event_pt_event_type): Improve error message.
6744         Remove parameter and change return type.  Update callers.  Move it.
6745         (linux_enable_bts, linux_enable_pt): Improve error message.
6746         (linux_enable_pt): Remove zero buffer size check.
6747         (linux_enable_btrace): Improve error messages.  Remove NULL return
6748         check.
6749
6750 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6751
6752         * btrace.c (btrace_enable): Remove target_supports_btrace call.
6753         * nat/linux-btrace.c (perf_event_pt_event_type): Move.
6754         (kernel_supports_bts, kernel_supports_pt, linux_supports_bts)
6755         (linux_supports_pt, linux_supports_btrace): Remove.
6756         (linux_enable_bts): Call cpu_supports_bts.
6757         * nat/linux-btrace.h (linux_supports_btrace): Remove.
6758         * remote.c (remote_supports_btrace): Remove.
6759         (init_remote_ops): Remove remote_supports_btrace.
6760         * target-delegates.c: Regenerated.
6761         * target.c (target_supports_btrace): Remove.
6762         * target.h (target_ops) <to_supports_btrace>: Remove
6763         (target_supports_btrace): Remove.
6764         * x86-linux-nat.c (x86_linux_create_target): Remove
6765         linux_supports_btrace.
6766
6767 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6768
6769         * nat/linux-btrace.c (linux_enable_btrace): Throw exception if enabling
6770         btrace failed.
6771         * x86-linux-nat.c (x86_linux_enable_btrace): Catch btrace enabling
6772         exception and use message in own exception.
6773
6774 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6775
6776         * nat/linux-btrace.c: Include scoped_fd.h and scoped_mmap.h.
6777         (perf_event_pt_event_type): Use gdb_file_up.
6778         (linux_enable_bts, linux_enable_pt): Use gdb::unique_xmalloc_ptr,
6779         scoped_fd, and scoped_mmap.
6780
6781 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6782
6783         * common/scoped_mmap.h: New.
6784         * unittests/scoped_mmap-selftest.c: New.
6785         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6786         unittests/scoped_mmap-selftest.c.
6787
6788 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6789
6790         * common/scoped_fd.h: New.
6791         * unittests/scoped_fd-selftest.c: New.
6792         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6793         unittests/scoped_fd-selftest.c.
6794
6795 2018-02-09  Tom Tromey  <tom@tromey.com>
6796
6797         * auto-load.c (auto_load_section_scripts): Use
6798         gdb::unique_xmalloc_ptr.
6799
6800 2018-02-09  Tom Tromey  <tom@tromey.com>
6801
6802         * auto-load.c (execute_script_contents): Use std::string.
6803
6804 2018-02-09  Joel Brobecker  <brobecker@adacore.com>
6805
6806         * NEWS <Changes in GDB 8.1>: Clarify that "rbreak" is a new
6807         Python function, rather than a new command.
6808
6809 2018-02-08  Tom Tromey  <tom@tromey.com>
6810
6811         * solib.c (solib_find_1): Use std::string.
6812         (solib_bfd_fopen): Use unique_xmalloc_ptr.
6813
6814 2018-02-08  Tom Tromey  <tom@tromey.com>
6815
6816         * build-id.c (build_id_to_debug_bfd): Use unique_xmalloc_ptr.
6817
6818 2018-02-08  Tom Tromey  <tom@tromey.com>
6819
6820         * source.c (find_source_lines): Use gdb::def_vector.
6821
6822 2018-02-08  Tom Tromey  <tom@tromey.com>
6823
6824         * macrocmd.c (struct temporary_macro_definition): New.
6825         (macro_define_command): Use temporary_macro_definition.  Remove
6826         cleanups.
6827         (free_macro_definition_ptr): Remove.
6828
6829 2018-02-08  Tom Tromey  <tom@tromey.com>
6830
6831         * macroexp.c (maybe_expand): Use std::string.
6832
6833 2018-02-08  Tom Tromey  <tom@tromey.com>
6834
6835         * macroexp.c (struct macro_buffer): Add initializers for some
6836         members.
6837         (init_buffer, init_shared_buffer, free_buffer)
6838         (free_buffer_return_text): Remove.
6839         (macro_buffer): New constructors.
6840         (~macro_buffer): New destructor.
6841         (macro_buffer::set_shared): New method.
6842         (macro_buffer::resize_buffer, macro_buffer::appendc)
6843         (macro_buffer::appendmem): Now methods, not free functions.
6844         (set_token, append_tokens_without_splicing, stringify)
6845         (macro_stringify): Update.
6846         (gather_arguments): Change return type.  Remove argc_p argument,
6847         add args_ptr argument.  Use std::vector.
6848         (substitute_args): Remove argc argument.  Accept std::vector.
6849         (expand): Update.  Use std::vector.
6850         (scan, macro_expand, macro_expand_next): Update.
6851
6852 2018-02-08  Tom Tromey  <tom@tromey.com>
6853
6854         * symtab.c (default_collect_symbol_completion_matches_break_on):
6855         Use unique_xmalloc_ptr.
6856         * macroscope.h: (sal_macro_scope, user_macro_scope)
6857         (default_macro_scope): Return unique_xmalloc_ptr.
6858         * macroscope.c (sal_macro_scope, user_macro_scope)
6859         (default_macro_scope): Return unique_xmalloc_ptr.
6860         * macroexp.h (macro_expand, macro_expand_once): Return
6861         unique_xmalloc_ptr.
6862         * macroexp.c (macro_expand, macro_expand_once): Return
6863         unique_xmalloc_ptr.
6864         * macrocmd.c (macro_expand_command, macro_expand_once_command)
6865         (info_macro_command, info_macros_command): Use
6866         unique_xmalloc_ptr.
6867         * compile/compile-c-support.c (write_macro_definitions): Use
6868         unique_xmalloc_ptr.
6869         * c-exp.y (c_parse): Use unique_xmalloc_ptr.
6870
6871 2018-02-07  Simon Marchi  <simon.marchi@ericsson.com>
6872
6873         * value.c (value_static_field): Assign field type instead of
6874         containing type when returning an optimized out value.
6875
6876 2018-02-06  Yao Qi  <yao.qi@linaro.org>
6877
6878         * ft32-tdep.c (ft32_read_pc): Remove.
6879         (ft32_write_pc): Remove.
6880         (ft32_gdbarch_init): Update.
6881         * m32r-tdep.c (m32r_read_pc): Remove.
6882         (m32r_gdbarch_init): Update.
6883         * mep-tdep.c (mep_read_pc): Remove.
6884         (mep_gdbarch_init): Update.
6885         * microblaze-tdep.c (microblaze_write_pc): Remove.
6886         (microblaze_gdbarch_init): Update.
6887         * mn10300-tdep.c (mn10300_read_pc): Remove.
6888         (mn10300_write_pc): Remove.
6889         (mn10300_gdbarch_init): Update.
6890         * moxie-tdep.c (moxie_read_pc): Remove.
6891         (moxie_write_pc): Remove.
6892         (moxie_gdbarch_init): Update.
6893
6894 2018-02-06  Yao Qi  <yao.qi@linaro.org>
6895
6896         * expprint.c (print_subexp_standard): Handle
6897         OP_F77_UNDETERMINED_ARGLIST.
6898         (dump_subexp_body_standard): Likewise.
6899
6900 2018-02-05  Alan Hayward  <alan.hayward@arm.com>
6901
6902         * target-descriptions.c (tdesc_element_visitor) Add empty
6903         implementations.
6904         (tdesc_type): Move make_gdb_type from here.
6905         (tdesc_type_builtin): Likewise.
6906         (tdesc_type_vector): Likewise.
6907         (tdesc_type_with_fields): Move make_gdb_type_ functions from here.
6908         (make_gdb_type_struct): Move from tdesc_type_with_fields.
6909         (make_gdb_type_union): Likewise.
6910         (make_gdb_type_flags): Likewise.
6911         (make_gdb_type_enum): Likewise.
6912         (make_gdb_type): New function.
6913         (tdesc_register_type): Use static make_gdb_type.
6914
6915 2018-02-05  Ruslan Kabatsayev <b7.10110111@gmail.com>
6916
6917         * infcmd.c (default_print_one_register_info): Align natural-format
6918         column values consistently one under another.
6919         (pad_to_column): New function.
6920
6921 2018-02-05  Joel Brobecker  <brobecker@adacore.com>
6922
6923         * dwarf2read.c (dwarf2_physname): Move commment.
6924
6925 2018-02-01  Leszek Swirski  <leszeks@google.com>
6926
6927         * varobj.c (varobj_formatted_print_options): Allow recursive
6928         pretty printing if pretty printing is enabled.
6929
6930 2018-02-01  Leszek Swirski  <leszeks@google.com>
6931
6932         * c-exp.y (lex_one_token, classify_name, yylex): Don't classify
6933         names after a structop as a filename.
6934
6935 2018-02-01  Yao Qi  <yao.qi@linaro.org>
6936
6937         * arm-tdep.c (arm_record_data_proc_misc_ld_str): Rewrite it.
6938         (arm_record_coproc_data_proc): Likewise.
6939
6940 2018-02-01  Yao Qi  <yao.qi@linaro.org>
6941
6942         * arm-tdep.c (arm_record_extension_space): Change ret to signed.
6943
6944 2018-01-31  Nikola Prica  <nikola.prica@rt-rk.com>
6945
6946         * rs6000-tdep.c (skip_prologue): Remove shifting for lr_reg and
6947         assign shifted lr_reg to fdata->lr_register when lr_reg is set.
6948
6949 2018-01-31  Pedro Alves  <palves@redhat.com>
6950
6951         * darwin-nat.c (darwin_interrupt): Remove ptid_t parameter.
6952         * inflow.c (child_terminal_save_inferior): Wrap reference to
6953         tcgetpgrp in HAVE_TERMIOS_H.
6954         (child_interrupt, child_pass_ctrlc): Wrap references to signal in
6955         _WIN32.
6956         * remote-sim.c (gdbsim_interrupt): Remove ptid_t parameter and
6957         always iterate over all inferiors.
6958         (gdbsim_cntrl_c): Adjust.
6959         * windows-nat.c (windows_interrupt): Remove 'ptid_t' parameter.
6960
6961 2018-01-31  Joel Brobecker  <brobecker@adacore.com>
6962
6963         * gdbtypes.c (lookup_array_range_type): Make sure the array's
6964         index type is objfile-owned if the element type is as well.
6965
6966 2018-01-31  Joel Brobecker  <brobecker@adacore.com>
6967
6968         GDB 8.1 released.
6969
6970 2018-01-30  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6971
6972         * s390-linux-tdep.c: Remove includes "features/s390-linux32.c" and
6973         "features/s390x-linux64.c".
6974         (_initialize_s390_linux_tdep): Remove initialization of tdescs
6975         s390_linux32 and s390x_linux64.
6976         (s390_linux_init_abi_31, s390_linux_init_abi_64): Don't set
6977         default tdesc.
6978         * s390-tdep.c: Include "features/s390-linux32.c" and
6979         "features/s390x-linux64.c".
6980         (s390_tdesc_valid): Add check for tdesc_has_registers.
6981         (s390_gdbarch_init): Make sure there is always a valid tdesc.
6982         (_initialize_s390_tdep): Initialize tdesc_s390_linux32 and
6983         tdesc_s390x_linux64.
6984         * s390-linux-tdep.h: Move export of tdesc_s390_linux32 and
6985         tdesc_s390x_linux64 to...
6986         * s390-tdep.h: ...here.
6987
6988 2018-01-30  Pedro Alves  <palves@redhat.com>
6989
6990         PR gdb/13211
6991         * config.in, configure: Regenerate.
6992         * configure.ac: Check for getpgid.
6993         * go32-nat.c (go32_pass_ctrlc): New.
6994         (go32_target): Install it.
6995         * inf-child.c (inf_child_target): Install
6996         child_terminal_save_inferior, child_pass_ctrlc and
6997         child_interrupt.
6998         * inf-ptrace.c (inf_ptrace_interrupt): Delete.
6999         (inf_ptrace_target): No longer install it.
7000         * infcmd.c (interrupt_target_1): Adjust.
7001         * inferior.h (child_terminal_save_inferior, child_pass_ctrlc)
7002         (child_interrupt): Declare.
7003         (inferior::terminal_state): New.
7004         * inflow.c (struct terminal_info): Update comments.
7005         (inferior_process_group): Delete.
7006         (terminal_is_ours): Delete.
7007         (gdb_tty_state): New.
7008         (child_terminal_init): Adjust.
7009         (is_gdb_terminal, sharing_input_terminal_1)
7010         (sharing_input_terminal): New functions.
7011         (child_terminal_inferior): Adjust.  Use sharing_input_terminal.
7012         Set the process's actual process group in the foreground if
7013         possible.  Handle is_ours_for_output/is_ours distinction.  Don't
7014         mark terminal as the inferior's if not sharing GDB's terminal.
7015         Don't check attach_flag.
7016         (child_terminal_ours_for_output, child_terminal_ours): Adjust to
7017         pass down a target_terminal_state.
7018         (child_terminal_save_inferior): New, factored out from ...
7019         (child_terminal_ours_1): ... this.  Handle
7020         target_terminal_state::is_ours_for_output.
7021         (child_interrupt, child_pass_ctrlc): New.
7022         (inflow_inferior_exit): Clear the inferior's terminal_state.
7023         (copy_terminal_info): Copy the inferior's terminal state.
7024         (_initialize_inflow): Remove reference to terminal_is_ours.
7025         * inflow.h (inferior_process_group): Delete.
7026         * nto-procfs.c (nto_handle_sigint, procfs_interrupt): Adjust.
7027         * procfs.c (procfs_target): Don't install procfs_interrupt.
7028         (procfs_interrupt): Delete.
7029         * remote.c (remote_serial_quit_handler): Adjust.
7030         (remote_interrupt): Remove ptid parameter.  Adjust.
7031         * target-delegates.c: Regenerate.
7032         * target.c: Include "terminal.h".
7033         (target_terminal::terminal_state): Rename to ...
7034         (target_terminal::m_terminal_state): ... this.
7035         (target_terminal::init): Adjust.
7036         (target_terminal::inferior): Adjust to per-inferior
7037         terminal_state.
7038         (target_terminal::restore_inferior, target_terminal_is_ours_kind): New.
7039         (target_terminal::ours, target_terminal::ours_for_output): Use
7040         target_terminal_is_ours_kind.
7041         (target_interrupt): Remove ptid parameter.  Adjust.
7042         (default_target_pass_ctrlc): Adjust.
7043         * target.h (target_ops::to_terminal_save_inferior): New field.
7044         (target_ops::to_interrupt): Remove ptid_t parameter.
7045         (target_interrupt): Remove ptid_t parameter.  Update comment.
7046         (target_pass_ctrlc): Update comment.
7047         * target/target.h (target_terminal_state): New scoped enum,
7048         factored out of ...
7049         (target_terminal::terminal_state): ... here.
7050         (target_terminal::inferior): Update comments.
7051         (target_terminal::restore_inferior): New.
7052         (target_terminal::is_inferior, target_terminal::is_ours)
7053         (target_terminal::is_ours_for_output): Adjust.
7054         (target_terminal::scoped_restore_terminal_state): Adjust to
7055         rename, and call restore_inferior() instead of inferior().
7056         (target_terminal::scoped_restore_terminal_state::m_state): Change
7057         type.
7058         (target_terminal::terminal_state): Rename to ...
7059         (target_terminal::m_terminal_state): ... this and change type.
7060
7061 2018-01-30  Pedro Alves  <palves@redhat.com>
7062
7063         * linux-nat.c (wait_for_signal): New function.
7064         (wait_lwp, linux_nat_wait_1): Use it instead of calling sigsuspend
7065         directly.
7066         (async_terminal_is_ours)
7067         (linux_nat_terminal_inferior, linux_nat_terminal_ours): Delete.
7068         (linux_nat_add_target): Don't override
7069         to_terminal_inferior/to_terminal_ours.
7070
7071 2018-01-29  Sergio Durigan Junior  <sergiodj@redhat.com>
7072
7073         * remote.c (remote_follow_fork): Don't call "detach_inferior".
7074
7075 2018-01-28  Simon Marchi  <simon.marchi@ericsson.com>
7076
7077         * dwarf2read.c (free_dwo_files): Add forward-declaration.
7078         (dwarf2_per_objfile::~dwarf2_per_objfile): Move content from
7079         dwarf2_per_objfile_free here.
7080         (dwarf2_per_objfile_free): Remove.
7081         (_initialize_dwarf2_read): Don't register
7082         dwarf2_per_objfile_free as a registry cleanup.
7083
7084 2018-01-27  Eli Zaretskii  <eliz@gnu.org>
7085
7086         Avoid compilation errors in MinGW native builds
7087
7088         The error is triggered by including python-internal.h, and the
7089         error message is:
7090
7091              In file included from d:\usr\lib\gcc\mingw32\6.3.0\include\c++\math.h:36:0,
7092                       from build-gnulib/import/math.h:27,
7093                       from d:/usr/Python26/include/pyport.h:235,
7094                       from d:/usr/Python26/include/Python.h:58,
7095                       from python/python-internal.h:94,
7096                       from python/py-arch.c:24:
7097              d:\usr\lib\gcc\mingw32\6.3.0\include\c++\cmath:1157:11: error: '::hypot' has not been declared
7098         using ::hypot;
7099                 ^~~~~
7100
7101         This happens because Python headers define 'hypot' to expand t
7102         '_hypot' in the Windows builds.
7103         * python/python-internal.h (_hypot) [__MINGW32__]: Define back to
7104         'hypoth'.  This avoids a compilation error.
7105
7106 2018-01-26  Alan Hayward  <alan.hayward@arm.com>
7107
7108         * MAINTAINERS (Write After Approval): Fix ordering.
7109
7110 2018-01-26  Alan Hayward  <alan.hayward@arm.com>
7111
7112         * MAINTAINERS (Write After Approval): Add Alan Hayward.
7113
7114 2018-01-26  Alan Modra  <amodra@gmail.com>
7115
7116         * ppc-linux-tdep.c (powerpc32_plt_stub): Make const.
7117         (powerpc32_plt_stub_so_1): Rename from powerpc32_plt_stub_so.
7118         Remove nop.  Make const.  Comment.
7119         (powerpc32_plt_stub_so_2): New.
7120         (POWERPC32_PLT_CHECK_LEN): Rename from POWERPC32_PLT_STUB_LEN.
7121         Correct count.  Update uses.
7122         (ppc_skip_trampoline_code): Match powerpc32_plt_stub_so_2 too.
7123         Move common code reading PLT entry word.  Correct
7124         powerpc32_plt_stub PLT address calculation.
7125         * ppc64-tdep.c (ppc64_standard_linkage1): Make const.
7126         (ppc64_standard_linkage2, ppc64_standard_linkage3): Likewise.
7127         (ppc64_standard_linkage4, ppc64_standard_linkage5): Likewise.
7128         (ppc64_standard_linkage6, ppc64_standard_linkage7): Likewise.
7129         (ppc64_standard_linkage8): Likewise.
7130         * rs6000-tdep.c (ppc_insns_match_pattern): Make pattern const.
7131         Correct insns description.
7132         * ppc-tdep.h (ppc_insns_match_pattern): Update prototype.
7133
7134 2018-01-24  Pedro Alves  <palves@redhat.com>
7135
7136         GCC PR libstdc++/83906
7137         * gdbtypes.c (operator==(const dynamic_prop &,
7138         const dynamic_prop &)): New.
7139         (operator==(const range_bounds &, const range_bounds &)): New.
7140         (check_types_equal): Use them instead of memcmp.
7141         * gdbtypes.h (operator==(const dynamic_prop &,
7142         const dynamic_prop &)): Declare.
7143         (operator!=(const dynamic_prop &, const dynamic_prop &)): Declare.
7144         (operator==(const range_bounds &, const range_bounds &)): Declare.
7145         (operator!=(const range_bounds &, const range_bounds &)): Declare.
7146
7147 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
7148
7149         * s390-linux-tdep.c (s390_record_address_mask)
7150         (s390_record_calc_disp_common, s390_record_calc_disp)
7151         (s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
7152         (s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
7153         (s390_process_record): Move to s390-tdep.c.
7154         (s390_linux_init_abi_any): Adjust.
7155         * s390-tdep.c (s390_record_address_mask)
7156         (s390_record_calc_disp_common, s390_record_calc_disp)
7157         (s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
7158         (s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
7159         (s390_process_record): Moved from s390-linux-tdep.c
7160         (s390_gdbarch_init): Adjust.
7161
7162 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
7163
7164         * s390-linux-nat.c (s390-tdep.h): New include.
7165         * Makefile.in (ALL_TARGET_OBS): Add s390-tdep.o.
7166         (HFILES_NO_SRCDIR): Add s390-tdep.h.
7167         (ALLDEPFILES): Add s390-tdep.c.
7168         * configure.tgt (s390*-*-linux*): Add s390-tdep.o.
7169         * s390-linux-tdep.h (HWCAP_S390_*, S390_*_REGNUM): Move to...
7170         * s390-tdep.h: ...this.  New file.
7171         * s390-linux-tdep.c (s390-tdep.h): New include.
7172         (_initialize_s390_tdep): Rename to...
7173         (_initialize_s390_linux_tdep): ...this and adjust.
7174         (s390_abi_kind, s390_vector_abi_kind, gdbarch_tdep)
7175         (enum named opcodes, S390_NUM_GPRS, S390_NUM_FPRS): Move to
7176         s390-tdep.h.
7177         (s390_break_insn, s390_breakpoint, s390_readinstruction, is_ri)
7178         (is_ril, is_rr, is_rre, is_rs, is_rsy, is_rx, is_rxy)
7179         (s390_is_partial_instruction, s390_software_single_step)
7180         (is_non_branch_ril, s390_displaced_step_copy_insn)
7181         (s390_displaced_step_fixup, s390_displaced_step_hw_singlestep)
7182         (s390_prologue_data, s390_addr, s390_store, s390_load)
7183         (s390_check_for_saved, s390_analyze_prologue, s390_skip_prologue)
7184         (s390_register_call_saved, s390_guess_tracepoint_registers)
7185         (s390_register_name, s390_dwarf_regmap, s390_dwarf_reg_to_regnum)
7186         (regnum_is_gpr_full, regnum_is_vxr_full, s390_value_from_register)
7187         (s390_pseudo_register_name, s390_pseudo_register_type)
7188         (s390_pseudo_register_read, s390_pseudo_register_write)
7189         (s390_pseudo_register_reggroup_p, s390_ax_pseudo_register_collect)
7190         (s390_ax_pseudo_register_push_stack, s390_gen_return_address)
7191         (s390_addr_bits_remove, s390_address_class_type_flags)
7192         (s390_address_class_type_flags_to_name)
7193         (s390_address_class_name_to_type_flags, s390_effective_inner_type)
7194         (s390_function_arg_float, s390_function_arg_vector)
7195         (is_power_of_two, s390_function_arg_integer, s390_arg_state)
7196         (s390_handle_arg, s390_push_dummy_call, s390_dummy_id)
7197         (s390_frame_align, s390_register_return_value, s390_return_value)
7198         (s390_stack_frame_destroyed_p, s390_unwind_pc, s390_unwind_sp)
7199         (s390_unwind_pseudo_register, s390_adjust_frame_regnum)
7200         (s390_dwarf2_prev_register, s390_dwarf2_frame_init_reg)
7201         (s390_trad_frame_prev_register, s390_unwind_cache)
7202         (s390_prologue_frame_unwind_cache)
7203         (s390_backchain_frame_unwind_cache, s390_frame_unwind_cache)
7204         (s390_frame_this_id, s390_frame_prev_register, s390_frame_unwind)
7205         (s390_stub_unwind_cache, s390_stub_frame_unwind_cache)
7206         (s390_stub_frame_this_id, s390_stub_frame_prev_register)
7207         (s390_stub_frame_sniffer, s390_stub_frame_unwind)
7208         (s390_frame_base_address, s390_local_base_address)
7209         (s390_frame_base, s390_gcc_target_options)
7210         (s390_gnu_triplet_regexp, s390_stap_is_single_operand)
7211         (s390_validate_reg_range, s390_tdesc_valid)
7212         (s390_gdbarch_tdep_alloc, s390_gdbarch_init): Move to...
7213         * s390-tdep.c: ...this.  New file.
7214
7215 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
7216
7217         * s390-linux-tdep.c (gdbarch_tdep.s390_syscall_record): New hook.
7218         (s390_process_record, s390_gdbarch_tdep_alloc)
7219         (s390_linux_init_abi_any): Use/set new hook.
7220
7221 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
7222
7223         * s390-linux-tdep.c (osabi.h): New include.
7224         (s390_linux_init_abi_31, s390_linux_init_abi_64)
7225         (s390_linux_init_abi_any): New functions.
7226         (s390_gdbarch_init, _initialize_s390_tdep): Adjust.
7227
7228 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
7229
7230         * s390-linux-tdep.c (s390_gdbarch_init): Use gdb_assert for
7231         tdesc_has_registers check
7232
7233 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
7234
7235         * s390-linux-tdep.c (s390_tdesc_valid): New function.
7236         (s390_validate_reg_range): New macro.
7237         (s390_gdbarch_init): Adjust.
7238
7239 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
7240
7241         * s390-linux-tdep.c (gdbarch_tdep) <tdesc>: New field.
7242         (s390_gdbarch_tdep_alloc): Adjust.
7243         (s390_gdbarch_init): Adjust.
7244
7245 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
7246
7247         * s390-linux-tdep.c (gdbarch_tdep) <have_linux_v1, have_linux_v2>
7248         <have_tdb>: Change type to bool.
7249         (s390_gdbarch_tdep_alloc): Adjust.
7250         (s390_gdbarch_init): Adjust.
7251
7252 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
7253
7254         * s390-linux-tdep (s390_abi_kind) <ABI_NONE>: New default field.
7255         (gdbarch_tdep) <have_upper, have_vx>: New fields.
7256         (s390_gdbarch_tdep_alloc): New function.
7257         (s390_gdbarch_init): Allocate tdep at start and use its fields
7258         instead of separate variables.
7259
7260 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
7261
7262         * s390-linux-tdep.c (s390_gdbarch_init): Remove duplicate checks
7263         when looking for cached gdbarch and add comment for remaining.
7264
7265 2018-01-22  Pedro Alves  <palves@redhat.com>
7266             Sergio Durigan Junior  <sergiodj@redhat.com>
7267
7268         * typeprint.c (whatis_exp): Initialize "val" in the "whatis type"
7269         case.
7270
7271 2018-01-22  Maciej W. Rozycki  <macro@mips.com>
7272
7273         * MAINTAINERS: Update my company e-mail address.
7274
7275 2018-01-22  Yao Qi  <yao.qi@linaro.org>
7276
7277         * regcache.c (cooked_write_test): New function.
7278         (_initialize_regcache): Register the test.
7279
7280 2018-01-22  Yao Qi  <yao.qi@linaro.org>
7281
7282         * ia64-tdep.c (ia64_pseudo_register_read): Call
7283         regcache->cooked_read instead of regcache_cooked_read_unsigned.
7284         * m32c-tdep.c (m32c_cat_read): Likewise.
7285         (m32c_r3r2r1r0_read): Likewise.
7286         * m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
7287         * xtensa-tdep.c (xtensa_register_read_masked): Likewise.
7288
7289 2018-01-22  Yao Qi  <yao.qi@linaro.org>
7290
7291         * aarch64-tdep.c (aarch64_pseudo_read_value): Call regcache
7292         method raw_read instead of regcache_raw_read.
7293         * amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
7294         * arm-tdep.c (arm_neon_quad_read): Likewise.
7295         * avr-tdep.c (avr_pseudo_register_read): Likewise.
7296         * bfin-tdep.c (bfin_pseudo_register_read): Likewise.
7297         * frv-tdep.c (frv_pseudo_register_read): Likewise.
7298         * h8300-tdep.c (h8300_pseudo_register_read): Likewise.
7299         * i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
7300         (i386_pseudo_register_read_into_value): Likewise.
7301         * mep-tdep.c (mep_pseudo_cr32_read): Likewise.
7302         * msp430-tdep.c (msp430_pseudo_register_read): Likewise.
7303         * nds32-tdep.c (nds32_pseudo_register_read): Likewise.
7304         * rl78-tdep.c (rl78_pseudo_register_read): Likewise.
7305         * s390-linux-tdep.c (s390_pseudo_register_read): Likewise.
7306         * sparc-tdep.c (sparc32_pseudo_register_read):  Likewise.
7307         * sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
7308         * spu-tdep.c (spu_pseudo_register_read_spu):  Likewise.
7309         * xtensa-tdep.c (xtensa_pseudo_register_read): Likewise.
7310
7311 2018-01-22  Yao Qi  <yao.qi@linaro.org>
7312
7313         * Makefile.in (ALL_TARGET_OBS): Remove mt-tdep.o.
7314         * configure.tgt: Remove target mt.
7315         * mt-tdep.c: Remove.
7316         * regcache.c (cooked_read_test): Remove the check for mt.
7317
7318 2018-01-22  Yao Qi  <yao.qi@linaro.org>
7319
7320         * jit.c (jit_frame_prev_register): Call regcache::cooked_read
7321         instead of gdbarch_pseudo_register_read_value.
7322
7323 2018-01-22  Joel Brobecker  <brobecker@adacore.com>
7324
7325         * dwarf2read.c (need_gnat_info): Return nonzero if the cu's
7326         language is Ada.
7327
7328 2018-01-22  Joel Brobecker  <brobecker@adacore.com>
7329
7330         * linespec.c (create_sals_line_offset): Remove code that preserved
7331         the symtab_and_line's line number.
7332
7333 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
7334
7335         * varobj.c (varobj_create): Don't set valid_block when creating a
7336         floating varobj.
7337
7338 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
7339
7340         * varobj.c (varobj_create): Remove out of date comment.
7341
7342 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
7343
7344         PR mi/20395
7345         * ada-exp.y (write_var_from_sym): Pass extra parameter when
7346         updating innermost block.
7347         * parse.c (innermost_block_tracker::update): Take extra type
7348         parameter, and check types match before updating innermost block.
7349         (write_dollar_variable): Update innermost block for registers.
7350         * parser-defs.h (enum innermost_block_tracker_type): New enum.
7351         (innermost_block_tracker::innermost_block_tracker): Initialise
7352         m_types member.
7353         (innermost_block_tracker::reset): Take type parameter.
7354         (innermost_block_tracker::update): Take type parameter, and pass
7355         type through as needed.
7356         (innermost_block_tracker::m_types): New member.
7357         * varobj.c (varobj_create): Pass type when reseting innermost
7358         block.
7359
7360 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
7361
7362         * ada-exp.y (write_var_from_sym): Switch to innermost_block API.
7363         * ada-lang.c (resolve_subexp): Likewise.
7364         * breakpoint.c (set_breakpoint_condition) Likewise.
7365         (watch_command_1) Likewise.
7366         * c-exp.y (variable): Likewise.
7367         * d-exp.y (PrimaryExpression): Likewise.
7368         * f-exp.y (variable): Likewise.
7369         * go-exp.y (variable): Likewise.
7370         * m2-exp.y (variable): Likewise.
7371         * objfiles.c (objfile::~objfile): Likewise.
7372         * p-exp.y (variable): Likewise.
7373         * parse.c (innermost_block): Change type.
7374         * parser-defs.h (class innermost_block_tracker): New.
7375         (innermost_block): Change to innermost_block_tracker.
7376         * printcmd.c (display_command): Switch to innermost_block API.
7377         (do_one_display): Likewise.
7378         * rust-exp.y (do_one_display): Likewise.
7379         * symfile.c (clear_symtab_users): Likewise.
7380         * varobj.c (varobj_create): Switch to innermost_block API, replace
7381         use of innermost_block with block stored on varobj object.
7382
7383 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
7384
7385         * expression.h (innermost_block): Remove declaration.
7386         * varobj.c: Add 'parser-defs.h' include.
7387
7388 2018-01-19  Tom Tromey  <tom@tromey.com>
7389
7390         * rust-lang.c (rust_lookup_symbol_nonlocal): Look up qualified
7391         symbols in the static and global blocks.
7392
7393 2018-01-19  James Clarke  <jrtc27@jrtc27.com>
7394
7395         * nat/linux-ptrace.c: Remove unnecessary reinclusion of
7396         gdb_ptrace.h, and move including gdb_wait.h ...
7397         * nat/linux-ptrace.h: ... to here.
7398
7399 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
7400
7401         * inf-ptrace.c (inf_ptrace_detach): Adjust call to
7402         inf_ptrace_detach_success.
7403         (inf_ptrace_detach_success): Add inferior parameter, use it
7404         instead of inferior_ptid, pass it to detach_inferior.
7405         * inf-ptrace.h (inf_ptrace_detach_success): Add inferior
7406         parameter.
7407         * inferior.c (detach_inferior): Add overload that takes an
7408         inferior object.
7409         * inferior.h (detach_inferior): Likewise.
7410         * linux-nat.c (linux_nat_detach): Use the inf parameter, don't
7411         use inferior_ptid, adjust call to inf_ptrace_detach_success.
7412         * linux-thread-db.c (thread_db_detach): Use inf parameter.
7413
7414 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
7415
7416         * target.h (struct target_ops) <to_detach>: Add inferior
7417         parameter.
7418         (target_detach): Likewise.
7419         * target.c (dispose_inferior): Pass inferior down.
7420         (target_detach): Pass inferior down.  Assert that it is equal to
7421         the current inferior.
7422         * aix-thread.c (aix_thread_detach): Pass inferior down.
7423         * corefile.c (core_file_command): Pass current_inferior() down.
7424         * corelow.c (core_detach): Add inferior parameter.
7425         * darwin-nat.c (darwin_detach): Likewise.
7426         * gnu-nat.c (gnu_detach): Likewise.
7427         * inf-ptrace.c (inf_ptrace_detach): Likewise.
7428         * infcmd.c (detach_command): Pass current_inferior() down to
7429         target_detach.
7430         * infrun.c (follow_fork_inferior): Pass parent_inf to
7431         target_detach.
7432         (handle_vfork_child_exec_or_exit): Pass inf->vfork_parent to
7433         target_detach.
7434         * linux-nat.c (linux_nat_detach): Add inferior parameter.
7435         * linux-thread-db.c (thread_db_detach): Likewise.
7436         * nto-procfs.c (procfs_detach): Likewise.
7437         * procfs.c (procfs_detach): Likewise.
7438         * record.c (record_detach): Likewise.
7439         * record.h (struct inferior): Forward-declare.
7440         (record_detach): Add inferior parameter.
7441         * remote-sim.c (gdbsim_detach): Likewise.
7442         * remote.c (remote_detach_1): Likewise.
7443         (remote_detach): Likewise.
7444         (extended_remote_detach): Likewise.
7445         * sol-thread.c (sol_thread_detach): Likewise.
7446         * target-debug.h (target_debug_print_inferior_p): New macro.
7447         * target-delegates.c: Re-generate.
7448         * top.c (kill_or_detach): Pass inferior down to target_detach.
7449         * windows-nat.c (windows_detach): Add inferior parameter.
7450
7451 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
7452
7453         * target.h (struct target_ops) <to_detach>: Remove args
7454         parameter.
7455         (target_detach): Likewise.
7456         * target.c (dispose_inferior): Adjust.
7457         (target_detach): Remove args parameter, adjust.
7458         * aix-thread.c (aix_thread_detach): Adjust.
7459         * corefile.c (core_file_command): Adjust.
7460         * corelow.c (core_detach): Adjust.
7461         * darwin-nat.c (darwin_detach): Adjust.
7462         * gnu-nat.c (gnu_detach): Adjust.
7463         * inf-ptrace.c (inf_ptrace_detach): Adjust.
7464         * infcmd.c (detach_command): Adjust
7465         * infrun.c (follow_fork_inferior): Adjust.
7466         (handle_vfork_child_exec_or_exit): Adjust.
7467         * linux-fork.c (linux_fork_detach): Remove args parameter.
7468         * linux-fork.h (linux_fork_detach): Likewise.
7469         * linux-nat.c (linux_nat_detach): Likewise, and adjust.
7470         * linux-thread-db.c (thread_db_detach): Likewise.
7471         * nto-procfs.c (procfs_detach): Likewise.
7472         * procfs.c (procfs_detach): Likewise.
7473         (do_detach): Remove signo parameter.
7474         * record.c (record_detach): Remove args parameter.
7475         * record.h (record_detach): Likewise.
7476         * remote-sim.c (gdbsim_detach): Likewise.
7477         * remote.c (remote_detach_1): Likewise.
7478         (remote_detach): Likewise.
7479         (extended_remote_detach): Likewise.
7480         * sol-thread.c (sol_thread_detach): Likewise.
7481         * target-delegates.c: Re-generate.
7482         * top.c (struct qt_args) <args>: Remove field.
7483         (kill_or_detach): Don't pass args.
7484         (quit_force): Don't set args.
7485         * windows-nat.c (windows_detach): Remove args parameter.
7486
7487 2018-01-19  Yao Qi  <yao.qi@linaro.org>
7488
7489         * arm-linux-tdep.c (arm_linux_gcc_target_options): New function.
7490         (arm_linux_init_abi): Install it.
7491
7492 2018-01-19  Yao Qi  <yao.qi@linaro.org>
7493
7494         * osabi.c (gdb_osabi_names): Extend the regexp for
7495         arm-linux-gnueabihf.
7496
7497 2018-01-18  Yao Qi  <yao.qi@linaro.org>
7498
7499         * dwarf2read.c (abbrev_table) <abbrevs>: Rename it to
7500         m_abbrevs.
7501         (abbrev_table::add_abbrev): Update.
7502         (abbrev_table::lookup_abbrev): Update.
7503
7504 2018-01-18  Yao Qi  <yao.qi@linaro.org>
7505
7506         * ppc-linux-tdep.c (ppu2spu_prev_register): Call cooked_read.
7507
7508 2018-01-17  Sergio Durigan Junior  <sergiodj@redhat.com>
7509
7510         * compile/compile.c (compile_to_object): Convert "triplet_rx"
7511         to "std::string".
7512
7513 2018-01-17  Tom Tromey  <tom@tromey.com>
7514
7515         * dwarf2read.c (symbolp): Remove typedef.  Don't instantiate VEC.
7516
7517 2018-01-17  Tom Tromey  <tom@tromey.com>
7518
7519         * gdbtypes.h (add_dyn_prop): Remove objfile parameter.
7520         * gdbtypes.c (add_dyn_prop): Remove objfile parameter.
7521         (create_array_type_with_stride): Update.
7522         * dwarf2read.c (set_die_type): Update.
7523
7524 2018-01-17  Tom Tromey  <tom@tromey.com>
7525
7526         * dwarf2read.c (delayed_method_info): Remove typedef.
7527         (dwarf2_cu::method_info): Now a std::vector.
7528         (add_to_method_list): Update.
7529         (free_delayed_list): Remove.
7530         (compute_delayed_physnames): Update.
7531         (process_full_comp_unit, process_full_type_unit): Clear the method
7532         list.  Remove cleanups.
7533         (psymtab_include_file_name): Add name_holder parameter.  Use
7534         unique_xmalloc_ptr.
7535         (dwarf_decode_lines): Update.
7536
7537 2018-01-17  Tom Tromey  <tom@tromey.com>
7538             Simon Marchi  <simon.marchi@ericsson.com>
7539
7540         * dwarf2read.c (struct dwarf2_cu): Add constructor, destructor.
7541         (dwarf2_per_objfile::free_cached_comp_units)
7542         (init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
7543         (init_cutu_and_read_dies_no_follow): Update.
7544         (dwarf2_cu::dwarf2_cu): Rename from init_one_comp_unit.
7545         (dwarf2_cu::~dwarf2_cu): New.
7546         (free_heap_comp_unit, free_stack_comp_unit): Remove.
7547         (age_cached_comp_units, free_one_cached_comp_unit): Update.
7548
7549 2018-01-17  Tom Tromey  <tom@tromey.com>
7550             Simon Marchi  <simon.marchi@ericsson.com>
7551
7552         * dwarf2read.c (struct dwarf2_cu) <abbrev_table>: Remove.
7553         (struct die_reader_specs) <abbrev_table>: New member.
7554         (struct abbrev_table): Add constructor.
7555         <alloc_abbrev, add_abbrev, lookup_abbrev>: Declare.
7556         <abbrev_obstack>: Now an auto_obstack.
7557         (abbrev_table_up): New typedef.
7558         (init_cu_die_reader): Add abbrev_table parameter.
7559         (read_cutu_die_from_dwo): Remove abbrev_table_provided parameter.
7560         Add result_dwo_abbrev_table.
7561         (init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
7562         (init_cutu_and_read_dies_no_follow, build_type_psymtabs_1):
7563         Update.
7564         (peek_die_abbrev): Take die_reader_specs, not dwarf_cu as
7565         parameter.
7566         (skip_children): Update.
7567         (abbrev_table::alloc_abbrev): Rename from
7568         abbrev_table_alloc_abbrev.
7569         (abbrev_table::add_abbrev): Rename from abbrev_table_add_abbrev.
7570         (abbrev_table::lookup_abbrev): Rename from
7571         abbrev_table_lookup_abbrev.
7572         (abbrev_table_read_table): Return abbrev_table_up.
7573         (abbrev_table_free, abbrev_table_free_cleanup)
7574         (dwarf2_read_abbrevs, dwarf2_free_abbrev_table): Remove.
7575         (load_partial_dies): Update.
7576
7577 2018-01-17  Tom Tromey  <tom@tromey.com>
7578
7579         * dwarf2read.c (dwarf2_compute_name): Update comment.
7580         (read_func_scope, read_variable): Update.
7581         (new_symbol): Remove.
7582         (new_symbol_full): Rename to new_symbol.
7583
7584 2018-01-17  Mike Gulick  <mgulick@mathworks.com>
7585
7586         PR gdb/16577
7587         * gdb_bfd.c (gdb_bfd_map_section): If unable to read object file, issue
7588         a warning instead of throwing an error, set section size to 0 and return
7589         NULL.
7590         * gdb_bfd.h (gdb_bfd_map_section): Update description.
7591
7592 2018-01-17  Simon Marchi  <simon.marchi@ericsson.com>
7593
7594         * nat/linux-ptrace.h (linux_ptrace_attach_fail_reason): Return
7595         std::string.
7596         (linux_ptrace_attach_fail_reason_string): Likewise.
7597         * nat/linux-ptrace.c (linux_ptrace_attach_fail_reason):
7598         Likewise.
7599         (linux_ptrace_attach_fail_reason_string): Likewise.
7600         * linux-nat.c (attach_proc_task_lwp_callback): Adjust.
7601
7602 2018-01-17  Simon Marchi  <simon.marchi@ericsson.com>
7603
7604         * linux-nat.c (linux_nat_attach): Remove xstrdup.
7605
7606 2018-01-17  Eldar Abusalimov  <eldar.abusalimov@jetbrains.com>
7607
7608         PR gdb/21559
7609         * configure.ac: Include <sys/types.h> prior to <sys/user.h> when
7610         checking for fs_base/gs_base fields in struct user_regs_struct.
7611         * configure: Regenerate.
7612
7613 2018-01-17  Yao Qi  <yao.qi@linaro.org>
7614
7615         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): New
7616         function.
7617         (aarch64_linux_init_abi): Install it to gdbarch hook
7618         gcc_target_options.
7619
7620 2018-01-15  Pedro Alves  <palves@redhat.com>
7621
7622         * common/signals-state-save-restore.c
7623         (save_original_signals_state): Fix typos.
7624
7625 2017-01-12  Tom Tromey  <tom@tromey.com>
7626             Sergio Durigan Junior  <sergiodj@redhat.com>
7627
7628         * Makefile.in (install-only): Install gdb-add-index.
7629
7630 2018-01-12  John Baldwin  <jhb@FreeBSD.org>
7631
7632         * fbsd-tdep.c (KVE_PROTECTION): Correct value.
7633
7634 2018-01-12  Andreas Arnez  <arnez@linux.vnet.ibm.com>
7635
7636         * infrun.c (keep_going_pass_signal): Clear step-over info when
7637         insert_breakpoints fails.
7638
7639 2018-01-11  Pedro Alves  <palves@redhat.com>
7640
7641         PR gdb/22583
7642         * infrun.c (resume): Rename to ...
7643         (resume_1): ... this.
7644         (resume): Reimplement as wrapper around resume_1.
7645
7646 2018-01-11  Pedro Alves  <palves@redhat.com>
7647
7648         PR remote/22597
7649         * remote.c (remote_parse_stop_reply): Default to the last-set
7650         general thread instead of to 'magic_null_ptid'.
7651
7652 2018-01-10  Pedro Alves  <palves@redhat.com>
7653
7654         * language.h (language_get_symbol_name_matcher): Rename ...
7655         (get_symbol_name_matcher): ... this.
7656         * language.c (language_get_symbol_name_matcher): Ditto.
7657         * dictionary.c, linespec.c, minsyms.c, psymtab.c, symtab.c: All
7658         callers adjusted.
7659
7660 2018-01-10  Pedro Alves  <palves@redhat.com>
7661
7662         PR gdb/22670
7663         * dwarf2read.c
7664         (gdb_index_symbol_name_matcher::gdb_index_symbol_name_matcher):
7665         Adjust to use language_get_symbol_name_matcher instead of
7666         language_defn::la_get_symbol_name_matcher.
7667         * language.c (language_get_symbol_name_matcher): If in Ada mode
7668         and the lookup name is a verbatim match, return Ada's matcher.
7669         * language.h (language_get_symbol_name_matcher): Adjust comment.
7670         (ada_lookup_name_info::verbatim_p):: New method.
7671
7672 2018-01-10  Pedro Alves  <palves@redhat.com>
7673
7674         PR gdb/22670
7675         * ada-lang.c (ada_collect_symbol_completion_matches): If the
7676         minsym's language is language_auto or language_cplus, pass down
7677         language_ada instead.
7678         * symtab.c (compare_symbol_name): Don't frob symbol language here.
7679
7680 2018-01-10  Pedro Alves  <palves@redhat.com>
7681
7682         PR gdb/22670
7683         * minsyms.c (linkage_name_str): New function.
7684         (iterate_over_minimal_symbols): Use it.
7685
7686 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
7687
7688         * NEWS: Document that 'info proc' now works on FreeBSD.
7689
7690 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
7691
7692         * configure.ac: Check for kinfo_getfile in libutil.
7693         * configure: Regenerate.
7694         * config.in: Regenerate.
7695         * fbsd-nat.c: Include "fbsd-tdep.h".
7696         (fbsd_fetch_cmdline): New.
7697         (fbsd_fetch_kinfo_proc): Move earlier and change to return a bool
7698         rather than calling error.
7699         (fbsd_info_proc): New.
7700         (fbsd_thread_name): Report error if fbsd_fetch_kinfo_proc fails.
7701         (fbsd_wait): Report warning if fbsd_fetch_kinfo_proc fails.
7702         (fbsd_nat_add_target): Set "to_info_proc" to "fbsd_info_proc".
7703
7704 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
7705
7706         * fbsd-nat.c (struct free_deleter): Remove.
7707         (fbsd_find_memory_regions): Use gdb::unique_xmalloc_ptr<>.
7708
7709 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
7710
7711         * fbsd-nat.c (fbsd_pid_to_exec_file) [KERN_PROC_PATHNAME]: Return
7712         NULL for an empty pathname.
7713
7714 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
7715
7716         * fbsd-tdep.c (KVE_STRUCTSIZE, KVE_START, KVE_END, KVE_OFFSET)
7717         (KVE_FLAGS, KVE_PROTECTION, KVE_PATH, KINFO_VME_PROT_READ)
7718         (KINFO_VME_PROT_WRITE, KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
7719         (KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
7720         (KINFO_VME_FLAG_SUPER, KINFO_VME_FLAG_GROWS_UP)
7721         (KINFO_VME_FLAG_GROWS_DOWN, KF_STRUCTSIZE, KF_TYPE, KF_FD)
7722         (KF_PATH, KINFO_FILE_TYPE_VNODE, KINFO_FILE_FD_TYPE_CWD)
7723         (KINFO_FILE_FD_TYPE_TEXT, SIG_WORDS, struct kinfo_proc_layout)
7724         (kinfo_proc_layout_32, kinfo_proc_layout_i386)
7725         (kinfo_proc_layout_64, fbsd_vm_map_entry_flags)
7726         (fbsd_core_info_proc_mappings, fbsd_core_vnode_path)
7727         (fbsd_core_fetch_timeval, fbsd_print_sigset)
7728         (fbsd_core_info_proc_status, fbsd_core_info_proc): New.
7729         (fbsd_init_abi):  Install gdbarch "core_info_proc" method.
7730         * fbsd-tdep.h (fbsd_vm_map_entry_flags): New.
7731
7732 2018-01-08  Samuel Thibault  <samuel.thibault@ens-lyon.org>
7733
7734         * gdb/gnu-nat.c: Include <elf.h> and <link.h>.
7735         (gnu_xfer_auxv): New function.
7736         (gnu_xfer_partial): Call gnu_xfer_auxv when `object' is
7737         TARGET_OBJECT_AUXV.
7738
7739 2018-01-08  Yao Qi  <yao.qi@linaro.org>
7740             Simon Marchi  <simon.marchi@ericsson.com>
7741
7742         * Makefile.in (COMMON_SFILES): Remove selftest-arch.c and
7743         common/selftest.c.
7744         (COMMON_OBS): Remove selftest.o.
7745         * configure.ac: Append selftest-arch.c and common/selftest.c to
7746         CONFIG_SRCS.  Append selftest-arch.o and selftest.o to COMMON_OBS.
7747         * configure: Re-generated.
7748         * maint.c (maintenance_selftest): Wrap selftests::run_tests with
7749         GDB_SELF_TEST.
7750         (maintenance_info_selftests): Likewise.
7751
7752 2018-01-08  Xavier Roirand  <roirand@adacore.com>
7753
7754         * ada-valprint.c (val_print_packed_array_elements): Use
7755         proper number of elements when printing an array indexed
7756         by an enumeration type.
7757
7758 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
7759
7760         * dwarf2read.c (struct dwarf2_cu) <dwarf2_per_objfile>: Remove.
7761         (dw2_get_file_names_reader): Adjust.
7762         (lookup_dwo_signatured_type): Adjust.
7763         (lookup_dwp_signatured_type): Adjust.
7764         (lookup_signatured_type): Adjust.
7765         (create_type_unit_group): Adjust.
7766         (get_type_unit_group): Adjust.
7767         (process_psymtab_comp_unit_reader): Adjust.
7768         (build_type_psymtabs_reader): Adjust.
7769         (scan_partial_symbols): Adjust.
7770         (add_partial_symbol): Adjust.
7771         (add_partial_subprogram): Adjust.
7772         (peek_die_abbrev): Adjust.
7773         (fixup_go_packaging): Adjust.
7774         (process_imported_unit_die): Adjust.
7775         (dwarf2_compute_name): Adjust.
7776         (dwarf2_physname): Adjust.
7777         (read_import_statement): Adjust.
7778         (handle_DW_AT_stmt_list): Adjust.
7779         (read_file_scope): Adjust.
7780         (read_func_scope): Adjust.
7781         (read_lexical_block_scope): Adjust.
7782         (read_call_site_scope): Adjust.
7783         (read_variable): Adjust.
7784         (dwarf2_rnglists_process): Adjust.
7785         (dwarf2_ranges_process): Adjust.
7786         (dwarf2_ranges_read): Adjust.
7787         (dwarf2_get_pc_bounds): Adjust.
7788         (dwarf2_record_block_ranges): Adjust.
7789         (dwarf2_add_field): Adjust.
7790         (dwarf2_add_member_fn): Adjust.
7791         (read_structure_type): Adjust.
7792         (process_structure_scope): Adjust.
7793         (read_enumeration_type): Adjust.
7794         (read_array_type): Adjust.
7795         (mark_common_block_symbol_computed): Adjust.
7796         (read_common_block): Adjust.
7797         (read_namespace_type): Adjust.
7798         (read_namespace): Adjust.
7799         (read_module_type): Adjust.
7800         (read_tag_pointer_type): Adjust.
7801         (read_tag_ptr_to_member_type): Adjust.
7802         (read_tag_string_type): Adjust.
7803         (read_subroutine_type): Adjust.
7804         (read_typedef): Adjust.
7805         (read_base_type): Adjust.
7806         (attr_to_dynamic_prop): Adjust.
7807         (read_subrange_type): Adjust.
7808         (read_unspecified_type): Adjust.
7809         (dwarf2_read_abbrevs): Adjust.
7810         (load_partial_dies): Adjust.
7811         (read_partial_die): Adjust.
7812         (find_partial_die): Adjust.
7813         (guess_partial_die_structure_name): Adjust.
7814         (fixup_partial_die): Adjust.
7815         (read_attribute_value): Adjust.
7816         (read_addr_index): Adjust.
7817         (read_addr_index_from_leb128): Adjust.
7818         (read_str_index): Adjust.
7819         (dwarf2_string_attr): Adjust.
7820         (get_debug_line_section): Adjust.
7821         (dwarf_decode_line_header): Adjust.
7822         (lnp_state_machine::check_line_address): Adjust.
7823         (dwarf_decode_lines_1): Adjust.
7824         (dwarf_decode_lines): Adjust.
7825         (dwarf2_start_symtab): Adjust.
7826         (var_decode_location): Adjust.
7827         (new_symbol_full): Adjust.
7828         (dwarf2_const_value_data): Adjust.
7829         (dwarf2_const_value_attr): Adjust.
7830         (dwarf2_const_value): Adjust.
7831         (die_type): Adjust.
7832         (die_containing_type): Adjust.
7833         (build_error_marker_type): Adjust.
7834         (lookup_die_type): Adjust.
7835         (guess_full_die_structure_name): Adjust.
7836         (anonymous_struct_prefix): Adjust.
7837         (determine_prefix): Adjust.
7838         (dwarf2_name): Adjust.
7839         (follow_die_ref_or_sig): Adjust.
7840         (follow_die_offset): Adjust.
7841         (follow_die_ref): Adjust.
7842         (follow_die_sig_1): Adjust.
7843         (follow_die_sig): Adjust.
7844         (get_signatured_type): Adjust.
7845         (get_DW_AT_signature_type): Adjust.
7846         (decode_locdesc): Adjust.
7847         (dwarf_decode_macros): Adjust.
7848         (cu_debug_loc_section): Adjust.
7849         (fill_in_loclist_baton): Adjust.
7850         (dwarf2_symbol_mark_computed): Adjust.
7851         (init_one_comp_unit): Don't assign
7852         dwarf2_cu::dwarf2_per_objfile.
7853         (set_die_type): Adjust.
7854
7855 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
7856
7857         * dwarf2read.c (struct mapped_debug_names): Add constructor.
7858         <dwarf2_per_objfile>: New field.
7859         (dwarf2_per_objfile): Remove global.
7860         (get_dwarf2_per_objfile): New function.
7861         (set_dwarf2_per_objfile): New function.
7862         (dwarf2_build_psymtabs_hard): Change objfile parameter to
7863         dwarf2_per_objfile.
7864         (abbrev_table_read_table): Add dwarf2_per_objfile parameter.
7865         (read_abbrev_offset): Likewise.
7866         (read_indirect_string): Likewise.
7867         (read_indirect_line_string): Likewise.
7868         (read_indirect_string_at_offset): Likewise.
7869         (read_indirect_string_from_dwz): Likewise.
7870         (dwarf2_find_containing_comp_unit): Change objfile parameter to
7871         dwarf2_per_objfile.
7872         (age_cached_comp_units): Add dwarf2_per_objfile parameter.
7873         (create_all_comp_units): Change objfile parameter to
7874         dwarf2_per_objfile.
7875         (create_all_type_units): Likewise.
7876         (process_queue): Add dwarf2_per_objfile parameter.
7877         (read_and_check_comp_unit_head): Likewise.
7878         (lookup_dwo_unit_in_dwp): Likewise.
7879         (get_dwp_file): Likewise.
7880         (process_cu_includes): Likewise.
7881         (struct free_dwo_file_cleanup_data): New struct.
7882         (dwarf2_has_info): Use get_dwarf2_per_objfile and
7883         set_dwarf2_per_objfile.
7884         (dwarf2_get_dwz_file): Add dwarf2_per_objfile parameter.
7885         (dw2_do_instantiate_symtab): Get dwarf2_per_objfile from
7886         context, adjust calls.
7887         (dw2_instantiate_symtab): Likewise.
7888         (dw2_get_cutu): Add dwarf2_per_objfile parameter.
7889         (dw2_get_cu): Likewise.
7890         (create_cu_from_index_list): Change objfile parameter to
7891         dwarf2_per_objfile.
7892         (create_cus_from_index_list): Get dwarf2_per_objfile from
7893         context, adjust calls.
7894         (create_cus_from_index): Likewise.
7895         (create_signatured_type_table_from_index): Change objfile
7896         parameter to dwarf2_per_objfile.
7897         (create_signatured_type_table_from_debug_names): Change objfile
7898         parameter to dwarf2_per_objfile.
7899         (create_addrmap_from_index): Likewise.
7900         (create_addrmap_from_aranges): Likewise.
7901         (dwarf2_read_index): Use get_dwarf2_per_objfile, adjust calls.
7902         (dw2_setup): Remove.
7903         (dw2_get_file_names_reader): Get dwarf2_per_objfile from
7904         context.
7905         (dw2_find_last_source_symtab): Get dwarf2_per_objfile using
7906         get_dwarf2_per_objfile.
7907         (dw2_forget_cached_source_info): Likewise.
7908         (dw2_map_symtabs_matching_filename): Likewise.
7909         (struct dw2_symtab_iterator) <index>: Remove.
7910         <dwarf2_per_objfile>: New field.
7911         (dw2_symtab_iter_init): Replace index parameter with
7912         dwarf2_per_objfile.
7913         (dw2_symtab_iter_next): Use dwarf2_per_objfile from iter.
7914         (dw2_lookup_symbol): Use get_dwarf2_per_objfile and adjust.
7915         (dw2_print_stats): Likewise.
7916         (dw2_dump): Likewise.
7917         (dw2_expand_symtabs_for_function): Likewise.
7918         (dw2_expand_all_symtabs): Likewise.
7919         (dw2_expand_symtabs_with_fullname): Likewise.
7920         (dw2_expand_marked_cus): Replace index and objfile parameters
7921         with dwarf2_per_objfile.
7922         (dw_expand_symtabs_matching_file_matcher): Add
7923         dwarf2_per_objfile parameter and adjust calls.
7924         (dw2_expand_symtabs_matching): Use get_dwarf2_per_objfile and
7925         adjust calls.
7926         (dw2_find_pc_sect_compunit_symtab): Don't call dw2_setup.
7927         (dw2_map_symbol_filenames): Use get_dwarf2_per_objfile and
7928         adjust calls.
7929         (create_cus_from_debug_names_list): Replace objfile parameter
7930         with dwarf2_per_objfile and adjust calls.
7931         (create_cus_from_debug_names): Likewise.
7932         (dwarf2_read_debug_names): Likewise.
7933         (mapped_debug_names::namei_to_name): Adjust call.
7934         (dw2_debug_names_iterator::next): Likewise.
7935         (dw2_debug_names_iterator::find_vec_in_debug_names): Likewise.
7936         (dw2_debug_names_lookup_symbol): Use get_dwarf2_per_objfile.
7937         (dw2_debug_names_dump): Likewise.
7938         (dw2_debug_names_expand_symtabs_for_function): Likewise.
7939         (dw2_debug_names_expand_symtabs_matching): Likewise.
7940         (dwarf2_initialize_objfile): Likewise.
7941         (dwarf2_build_psymtabs): Likewise.
7942         (get_abbrev_section_for_cu): Get dwarf2_per_objfile from
7943         this_cu.
7944         (error_check_comp_unit_head): Add dwarf2_per_objfile parameter.
7945         (read_and_check_comp_unit_head): Likewise.
7946         (read_abbrev_offset): Likewise.
7947         (create_debug_type_hash_table): Likewise.
7948         (create_debug_types_hash_table): Likewise.
7949         (create_all_type_units): Replace objfile parameter with
7950         dwarf2_per_objfile.
7951         (add_type_unit): Add dwarf2_per_objfile parameter.
7952         (fill_in_sig_entry_from_dwo_entry): Replace objfile parameter
7953         with dwarf2_per_objfile.
7954         (lookup_dwo_signatured_type): Get dwarf2_per_objfile from cu.
7955         (lookup_dwp_signatured_type): Likewise.
7956         (lookup_signatured_type): Likewise.
7957         (read_cutu_die_from_dwo): Likewise.
7958         (init_tu_and_read_dwo_dies): Likewise.
7959         (init_cutu_and_read_dies): Likewise.
7960         (init_cutu_and_read_dies_no_follow): Likewise.
7961         (allocate_type_unit_groups_table): Add objfile parameter.
7962         (create_type_unit_group): Use dwarf2_per_objfile from cu.
7963         (get_type_unit_group): Likewise.
7964         (process_psymtab_comp_unit): Update call.
7965         (build_type_psymtabs_reader): Use dwarf2_per_objfile from cu.
7966         (build_type_psymtabs_1): Add dwarf2_per_objfile parameter.
7967         (print_tu_stats): Likewise.
7968         (build_type_psymtab_dependencies): Use dwarf2_per_objfile passed
7969         in void* parameter.
7970         (build_type_psymtabs): Change objfile parameter to
7971         dwarf2_per_objfile.
7972         (process_skeletonless_type_unit): Use dwarf2_per_objfile
7973         passed in void* parameter.
7974         (process_skeletonless_type_units): Change objfile parameter to
7975         dwarf2_per_objfile.
7976         (set_partial_user): Likewise.
7977         (dwarf2_build_psymtabs_hard): Likewise.
7978         (read_comp_units_from_section): Likewise.
7979         (create_all_comp_units): Likewise.
7980         (scan_partial_symbols): Update calls.
7981         (add_partial_symbol): Likewise.
7982         (dwarf2_read_symtab): Use get_dwarf2_per_objfile.
7983         (maybe_queue_comp_unit): Use dwarf2_read_symtab from cu.
7984         (process_queue): Add dwarf2_per_objfile parameter.
7985         (get_compunit_symtab): Use dwarf2_per_objfile from cu.
7986         (compute_compunit_symtab_includes): Likewise.
7987         (process_cu_includes): Add dwarf2_per_objfile parameter.
7988         (process_full_comp_unit): Use dwarf2_per_objfile from cu.
7989         (process_full_type_unit): Likewise.
7990         (process_imported_unit_die): Update call.
7991         (handle_DW_AT_stmt_list): Use dwarf2_per_objfile from cu.
7992         (read_file_scope): Likewise.
7993         (allocate_dwo_file_hash_table): Add objfile parameter.
7994         (lookup_dwo_file_slot): Add dwarf2_per_objfile parameter.
7995         (create_cus_hash_table): Likewise.
7996         (create_dwp_hash_table): Likewise.
7997         (create_dwo_unit_in_dwp_v1): Likewise.
7998         (create_dwp_v2_section): Likewise.
7999         (create_dwo_unit_in_dwp_v2): Likewise.
8000         (lookup_dwo_unit_in_dwp): Likewise.
8001         (try_open_dwop_file): Likewise.
8002         (open_dwo_file): Likewise. Use dwarf2_per_objfile from cu.
8003         (open_and_init_dwo_file): Use dwarf2_per_objfile from cu, update
8004         cleanup to include a reference to dwarf2_per_objfile.
8005         (open_dwp_file): Add dwarf2_per_objfile parameter.
8006         (open_and_init_dwp_file): Likewise.
8007         (get_dwp_file): Likewise.
8008         (lookup_dwo_cutu): Use dwarf2_per_objfile from cu.
8009         (queue_and_load_all_dwo_tus): Update call.
8010         (free_dwo_file_cleanup): Use dwarf2_per_objfile from cleanup
8011         data.
8012         (dwarf2_rnglists_process): Use dwarf2_per_objfile from cu.
8013         (dwarf2_ranges_process): Likewise.
8014         (dwarf2_get_pc_bounds): Likewise.
8015         (mark_common_block_symbol_computed): Likewise.
8016         (abbrev_table_read_table): Add dwarf2_per_objfile parameter.
8017         (dwarf2_read_abbrevs): Update call.
8018         (read_partial_die): Use dwarf2_per_objfile from cu.
8019         (find_partial_die): Likewise.
8020         (fixup_partial_die): Likewise.
8021         (read_attribute_value): Likewise.
8022         (read_indirect_string_at_offset_from): Add objfile parameter.
8023         (read_indirect_string_at_offset): Add dwarf2_per_objfile
8024         parameter.
8025         (read_indirect_string_from_dwz): Add objfile parameter.
8026         (read_indirect_string): Add objfile parameter.
8027         (read_addr_index_1): Add dwarf2_per_objfile parameter.
8028         (read_addr_index): Use dwarf2_per_objfile from cu.
8029         (dwarf2_read_addr_index): Use dwarf2_per_objfile from cu, don't
8030         call dw2_setup.
8031         (read_str_index): Use dwarf2_per_objfile from cu.
8032         (get_debug_line_section): Likewise.
8033         (read_formatted_entries): Add dwarf2_per_objfile parameter.
8034         (dwarf_decode_line_header): Use dwarf2_per_objfile from cu.
8035         (new_symbol_full): Use dwarf2_per_objfile from cu.
8036         (build_error_marker_type): Likewise.
8037         (lookup_die_type): Likewise.
8038         (determine_prefix): Likewise.
8039         (follow_die_offset): Likewise.
8040         (dwarf2_fetch_die_loc_sect_off): Use get_dwarf2_per_objfile.
8041         (dwarf2_fetch_constant_bytes): Don't call dw2_setup.
8042         (dwarf2_fetch_die_type_sect_off): Likewise.
8043         (dwarf2_get_die_type): Likewise.
8044         (follow_die_sig_1): Use dwarf2_per_objfile from cu.
8045         (get_signatured_type): Likewise.
8046         (get_DW_AT_signature_type): Likewise.
8047         (dwarf_decode_macro_bytes): Add dwarf2_per_objfile parameter.
8048         (dwarf_decode_macros): Use dwarf2_per_objfile from cu.
8049         (cu_debug_loc_section): Likewise.
8050         (fill_in_loclist_baton): Likewise.
8051         (dwarf2_symbol_mark_computed): Likewise.
8052         (dwarf2_find_containing_comp_unit): Change objfile parameter to
8053         dwarf2_per_objfile.
8054         (free_cached_comp_units): Use dwarf2_per_objfile passed in void*
8055         parameter.
8056         (age_cached_comp_units): Add dwarf2_per_objfile parameter.
8057         (free_one_cached_comp_unit): Use dwarf2_per_objfile from cu.
8058         (dwarf2_free_objfile): Use get_dwarf2_per_objfile.
8059         (set_die_type): Use dwarf2_free_objfile from cu.
8060         (get_die_type_at_offset): Likewise.
8061         (dwarf2_per_objfile_free): Don't assign global variable.
8062         (debug_names) <constructor>: Add dwarf2_per_objfile
8063         parameter, update m_debugstrlookup construction.
8064         (debug_names::debug_str_lookup): Add dwarf2_per_objfile
8065         parameter.
8066         <m_dwarf2_per_objfile>: New field.
8067         <lookup>: Use m_dwarf2_per_objfile.
8068         (check_dwarf64_offsets): Add dwarf2_per_objfile parameter.
8069         (psyms_seen_size): Likewise.
8070         (write_gdbindex): Replace objfile parameter with
8071         dwarf2_per_objfile.
8072         (write_debug_names): Likewise.
8073         (write_psymtabs_to_index): Likewise.
8074         (save_gdb_index_command): Use get_dwarf2_per_objfile, update
8075         calls.
8076
8077 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
8078
8079         * dwarf2read.c (struct dwarf2_cu) <objfile>: Remove.
8080         <dwarf2_per_objfile>: New field.
8081         (struct dwarf2_per_cu_data) <objfile>: Remove.
8082         <dwarf2_per_objfile>: New field.
8083         (create_cu_from_index_list): Assign dwarf2_per_objfile instead
8084         of objfile.
8085         (create_signatured_type_table_from_index): Likewise.
8086         (create_debug_type_hash_table): Likewise.
8087         (fill_in_sig_entry_from_dwo_entry): Likewise.
8088         (lookup_dwo_unit): Access objfile through dwarf2_per_objfile.
8089         (create_type_unit_group): Assign dwarf2_per_objfile instead of
8090         objfile.
8091         (create_partial_symtab): Access objfile through
8092         dwarf2_per_objfile.
8093         (process_psymtab_comp_unit_reader): Likewise.
8094         (read_comp_units_from_section): Likewise.
8095         (scan_partial_symbols): Likewise.
8096         (add_partial_symbol): Likewise.
8097         (add_partial_subprogram): Likewise.
8098         (peek_die_abbrev): Likewise.
8099         (fixup_go_packaging): Likewise.
8100         (process_full_comp_unit): Likewise.
8101         (process_full_type_unit): Likewise.
8102         (process_imported_unit_die): Likewise.
8103         (dwarf2_compute_name): Likewise.
8104         (dwarf2_physname): Likewise.
8105         (read_import_statement): Likewise.
8106         (create_cus_hash_table): Assign dwarf2_physname instead of
8107         objfile.
8108         (read_func_scope): Access objfile through dwarf2_per_objfile.
8109         (read_lexical_block_scope): Likewise.
8110         (read_call_site_scope): Likewise.
8111         (read_variable): Likewise.
8112         (dwarf2_rnglists_process): Likewise.
8113         (dwarf2_ranges_process): Likewise.
8114         (dwarf2_ranges_read): Likewise.
8115         (dwarf2_record_block_ranges): Likewise.
8116         (dwarf2_add_field): Likewise.
8117         (dwarf2_add_member_fn): Likewise.
8118         (read_structure_type): Likewise.
8119         (process_structure_scope): Likewise.
8120         (read_enumeration_type): Likewise.
8121         (read_array_type): Likewise.
8122         (read_common_block): Likewise.
8123         (read_namespace_type): Likewise.
8124         (read_namespace): Likewise.
8125         (read_module_type): Likewise.
8126         (read_tag_pointer_type): Likewise.
8127         (read_tag_ptr_to_member_type): Likewise.
8128         (read_tag_string_type): Likewise.
8129         (read_subroutine_type): Likewise.
8130         (read_typedef): Likewise.
8131         (read_base_type): Likewise.
8132         (attr_to_dynamic_prop): Likewise.
8133         (read_subrange_type): Likewise.
8134         (read_unspecified_type): Likewise.
8135         (load_partial_dies): Likewise.
8136         (read_partial_die): Likewise.
8137         (find_partial_die): Likewise.
8138         (guess_partial_die_structure_name): Likewise.
8139         (fixup_partial_die): Likewise.
8140         (read_attribute_value): Likewise.
8141         (read_addr_index_from_leb128): Likewise.
8142         (dwarf2_read_addr_index): Likewise.
8143         (dwarf2_string_attr): Likewise.
8144         (lnp_state_machine::check_line_address): Likewise.
8145         (dwarf_decode_lines_1): Likewise.
8146         (dwarf_decode_lines): Likewise.
8147         (dwarf2_start_symtab): Likewise.
8148         (var_decode_location): Likewise.
8149         (new_symbol_full): Likewise.
8150         (dwarf2_const_value_data): Likewise.
8151         (dwarf2_const_value_attr): Likewise.
8152         (dwarf2_const_value): Likewise.
8153         (die_type): Likewise.
8154         (die_containing_type): Likewise.
8155         (lookup_die_type): Likewise.
8156         (guess_full_die_structure_name): Likewise.
8157         (anonymous_struct_prefix): Likewise.
8158         (dwarf2_name): Likewise.
8159         (follow_die_ref_or_sig): Likewise.
8160         (follow_die_offset): Likewise.
8161         (follow_die_ref): Likewise.
8162         (dwarf2_fetch_die_loc_sect_off): Likewise.
8163         (dwarf2_fetch_constant_bytes): Likewise.
8164         (dwarf2_fetch_die_type_sect_off): Likewise.
8165         (dwarf2_get_die_type): Likewise.
8166         (follow_die_sig): Likewise.
8167         (decode_locdesc): Likewise.
8168         (dwarf2_per_cu_objfile): Likewise.
8169         (dwarf2_per_cu_text_offset): Likewise.
8170         (init_one_comp_unit): Assign dwarf2_per_objfile instead of
8171         objfile.
8172         (set_die_type): Access objfile through
8173         dwarf2_per_objfile.
8174
8175 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
8176
8177         * valprint.c (converted_character_d): Remove typedef.
8178         (DEF_VEC_O (converted_character_d)): Remove.
8179         (count_next_character): Use std::vector.
8180         (print_converted_chars_to_obstack): Likewise.
8181         (generic_printstr): Likewise.
8182
8183 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
8184
8185         * xml-support.h (struct gdb_xml_value): Add constructor.
8186         <value>: Change type to unique_xmalloc_ptr.
8187         (gdb_xml_value_s): Remove typedef.
8188         (DEF_VEC_O (gdb_xml_value_s)): Remove.
8189         (gdb_xml_element_start_handler): Change parameter type to
8190         std::vector.
8191         (xml_find_attribute): Likewise.
8192         * xml-support.c (xml_find_attribute): Change parameter type to
8193         std::vector and adjust.
8194         (gdb_xml_values_cleanup): Remove.
8195         (gdb_xml_parser::start_element): Adjust to std::vector.
8196         (xinclude_start_include): Change paraeter type to std::vector
8197         and adjust.
8198         * btrace.c (check_xml_btrace_version): Likewise.
8199         (parse_xml_btrace_block): Likewise.
8200         (parse_xml_btrace_pt_config_cpu): Likewise.
8201         (parse_xml_btrace_pt): Likewise.
8202         (parse_xml_btrace_conf_bts): Likewise.
8203         (parse_xml_btrace_conf_pt): Likewise.
8204         * memory-map.c (memory_map_start_memory): Likewise.
8205         (memory_map_start_property): Likewise.
8206         * osdata.c (osdata_start_osdata): Likewise.
8207         (osdata_start_item): Likewise.
8208         (osdata_start_column): Likewise.
8209         * remote.c (start_thread): Likewise.
8210         * solib-aix.c (library_list_start_library): Likewise.
8211         (library_list_start_list): Likewise.
8212         * solib-svr4.c (library_list_start_library): Likewise.
8213         (svr4_library_list_start_list): Likewise.
8214         * solib-target.c (library_list_start_segment): Likewise.
8215         (library_list_start_section): Likewise.
8216         (library_list_start_library): Likewise.
8217         (library_list_start_list): Likewise.
8218         * tracepoint.c (traceframe_info_start_memory): Likewise.
8219         (traceframe_info_start_tvar): Likewise.
8220         * xml-syscall.c (syscall_start_syscall): Likewise.
8221         * xml-tdesc.c (tdesc_start_target): Likewise.
8222         (tdesc_start_feature): Likewise.
8223         (tdesc_start_reg): Likewise.
8224         (tdesc_start_union): Likewise.
8225         (tdesc_start_struct): Likewise.
8226         (tdesc_start_flags): Likewise.
8227         (tdesc_start_enum): Likewise.
8228         (tdesc_start_field): Likewise.
8229         (tdesc_start_enum_value): Likewise.
8230         (tdesc_start_vector): Likewise.
8231
8232 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
8233
8234         * extension.h (struct xmethod_worker) <clone>: Remove.
8235         * python/py-xmethods.c (struct python_xmethod_worker) <clone>:
8236         Remove.
8237         (python_xmethod_worker::clone): Remove.
8238         * valops.c (find_overload_match): Use std::move instead of
8239         clone.
8240
8241 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
8242
8243         * extension-priv.h (enum ext_lang_rc): Remove, move to extension.h.
8244         (struct extension_language_ops) <clone_xmethod_worker_data>: Remove.
8245         <free_xmethod_worker_data>: Remove.
8246         <get_matching_xmethod_workers>: Chance VEC to std::vector.
8247         <get_xmethod_arg_types>: Remove.
8248         <get_xmethod_result_type>: Remove.
8249         <invoke_xmethod>: Remove.
8250         * extension.c (new_xmethod_worker): Remove.
8251         (clone_xmethod_worker): Remove.
8252         (get_matching_xmethod_workers): Return void, pass std::vector by
8253         pointer.
8254         (get_xmethod_arg_types): Rename to...
8255         (xmethod_worker::get_arg_types): ... this, and adjust.
8256         (get_xmethod_result_type): Rename to...
8257         (xmethod_worker::get_result_type): ... this, and adjust.
8258         (invoke_xmethod): Remove.
8259         (free_xmethod_worker): Remove.
8260         (free_xmethod_worker_vec): Remove.
8261         * extension.h (enum ext_lang_rc): Move here from
8262         extension-priv.h.
8263         (struct xmethod_worker): Add constructor and destructor.
8264         <data>: Remove.
8265         <value>: Remove.
8266         <invoke, clone, do_get_result_type, do_get_arg_types>: New
8267         virtual pure methods.
8268         <get_arg_types, get_result_type>: New methods.
8269         (xmethod_worker_ptr): Remove typedef.
8270         (DEF_VEC_P (xmethod_worker_ptr)): Remove.
8271         (xmethod_worker_vec): Remove typedef.
8272         (xmethod_worker_up): New typedef.
8273         (invoke_xmethod): Remove.
8274         (clone_xmethod_worker): Remove.
8275         (free_xmethod_worker): Remove.
8276         (free_xmethod_worker_vec): Remove.
8277         (get_xmethod_arg_types): Remove.
8278         (get_xmethod_result_type): Remove.
8279         * valops.c (find_method_list): Use std::vector, don't use
8280         intermediate vector.
8281         (value_find_oload_method_list): Use std::vector.
8282         (find_overload_match): Use std::vector.
8283         (find_oload_champ): Use std::vector.
8284         * value.c (value_free): Use operator delete.
8285         (value_of_xmethod): Rename to...
8286         (value_from_xmethod): ... this.  Don't assign
8287         xmethod_worker::value, take rvalue-reference.
8288         (result_type_of_xmethod): Adjust.
8289         (call_xmethod): Adjust.
8290         * value.h: Include extension.h.
8291         (struct xmethod_worker): Don't forward-declare.
8292         (value_of_xmethod): Rename to...
8293         (value_from_xmethod): ... this, take rvalue-reference.
8294         * python/py-xmethods.c (struct gdbpy_worker_data): Rename to...
8295         (struct python_xmethod_worker): ... this, add constructor and
8296         destructor.
8297         <invoke, clone, do_get_arg_types, do_get_result_type>: Implement.
8298         (gdbpy_free_xmethod_worker_data): Rename to...
8299         (python_xmethod_worker::~python_xmethod_worker): ... this and
8300         adjust.
8301         (gdbpy_clone_xmethod_worker_data): Rename to...
8302         (python_xmethod_worker::clone): ... this and adjust.
8303         (gdbpy_get_matching_xmethod_workers): Use std::vector, don't use
8304         temporary vector.
8305         (gdbpy_get_xmethod_arg_types): Rename to...
8306         (python_xmethod_worker::do_get_arg_types): ... this and adjust.
8307         (gdbpy_get_xmethod_result_type): Rename to...
8308         (python_xmethod_worker::do_get_result_type): ... this and
8309         adjust.
8310         (gdbpy_invoke_xmethod): Rename to...
8311         (python_xmethod_worker::invoke): ... this and adjust.
8312         (new_python_xmethod_worker): Rename to...
8313         (python_xmethod_worker::python_xmethod_worker): ... this and
8314         adjust.
8315         * python/python-internal.h (gdbpy_clone_xmethod_worker_data):
8316         Remove.
8317         (gdbpy_free_xmethod_worker_data): Remove.
8318         (gdbpy_get_matching_xmethod_workers): Use std::vector.
8319         (gdbpy_get_xmethod_arg_types): Remove.
8320         (gdbpy_get_xmethod_result_type): Remove.
8321         (gdbpy_invoke_xmethod): Remove.
8322         * python/python.c (python_extension_ops): Remove obsolete
8323         callbacks.
8324
8325 2018-01-05  Pedro Alves  <palves@redhat.com>
8326
8327         PR gdb/18653
8328         * common/signals-state-save-restore.c
8329         (save_original_signals_state): New parameter 'quiet'.  Warn if we
8330         find a custom handler preinstalled, instead of internal erroring.
8331         But only warn if !quiet.
8332         * common/signals-state-save-restore.h
8333         (save_original_signals_state): New parameter 'quiet'.
8334         * main.c (captured_main_1): Move save_original_signals_state call
8335         after option handling, and pass QUIET.
8336
8337 2018-01-05  Pedro Alves  <palves@redhat.com>
8338
8339         * spu-tdep.c (spu_catch_start): Pass
8340         symbol_name_match_type::SEARCH_NAME to block_lookup_symbol.
8341
8342 2018-01-05  Pedro Alves  <palves@redhat.com>
8343
8344         PR gdb/22670
8345         * ada-lang.c (literal_symbol_name_matcher): New function.
8346         (ada_get_symbol_name_matcher): Use it for
8347         symbol_name_match_type::SEARCH_NAME.
8348         * block.c (block_lookup_symbol): New parameter 'match_type'.  Pass
8349         it down instead of assuming symbol_name_match_type::FULL.
8350         * block.h (block_lookup_symbol): New parameter 'match_type'.
8351         * c-valprint.c (print_unpacked_pointer): Use
8352         lookup_symbol_search_name instead of lookup_symbol.
8353         * compile/compile-object-load.c (get_out_value_type): Pass down
8354         symbol_name_match_type::SEARCH_NAME.
8355         * cp-namespace.c (cp_basic_lookup_symbol): Pass down
8356         symbol_name_match_type::FULL.
8357         * cp-support.c (cp_get_symbol_name_matcher): Handle
8358         symbol_name_match_type::SEARCH_NAME.
8359         * infrun.c (insert_exception_resume_breakpoint): Use
8360         lookup_symbol_search_name.
8361         * p-valprint.c (pascal_val_print): Use lookup_symbol_search_name.
8362         * psymtab.c (maintenance_check_psymtabs): Use
8363         symbol_name_match_type::SEARCH_NAME and SYMBOL_SEARCH_NAME.
8364         * stack.c (print_frame_args): Use lookup_symbol_search_name and
8365         SYMBOL_SEARCH_NAME.
8366         * symtab.c (lookup_local_symbol): Don't demangle the lookup name
8367         if symbol_name_match_type::SEARCH_NAME.
8368         (lookup_symbol_in_language): Pass down
8369         symbol_name_match_type::FULL.
8370         (lookup_symbol_search_name): New.
8371         (lookup_language_this): Pass down
8372         symbol_name_match_type::SEARCH_NAME.
8373         (lookup_symbol_aux, lookup_local_symbol): New parameter
8374         'match_type'.  Pass it down.
8375         * symtab.h (symbol_name_match_type::SEARCH_NAME): New enumerator.
8376         (lookup_symbol_search_name): New declaration.
8377         (lookup_symbol_in_block): New 'match_type' parameter.
8378
8379 2018-01-05  Pedro Alves  <palves@redhat.com>
8380
8381         PR gdb/22670
8382         * ada-lang.c (ada_lookup_encoded_symbol): Reimplement in terms of
8383         ada_lookup_symbol.
8384         (ada_lookup_symbol): Reimplement in terms of
8385         ada_lookup_symbol_list, bits factored out from
8386         ada_lookup_encoded_symbol.
8387
8388 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
8389
8390         * ada-exp.y (write_object_renaming): When subscripting an array
8391         using a symbol as the index, pass the block in call to
8392         ada_lookup_encoded_symbol when looking that symbol up.
8393
8394 2018-01-05  Jerome Guitton  <guitton@adacore.com>
8395
8396         * ada-lang.c (ada_array_length): Use ada_index_type instead of
8397         TYPE_INDEX_TYPE.
8398
8399 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
8400
8401         * ada-lang.c (ada_to_fixed_value_create): Add handling of
8402         the case where VALUE_LVAL (val0) is not lval_memory.
8403
8404 2018-01-05  Xavier Roirand  <roirand@adacore.com>
8405
8406         * ada-valprint.c (print_optional_low_bound): Handle
8407         character-indexed array printing like boolean-indexed array
8408         printing.
8409
8410 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
8411
8412         * NEWS: Create a new section for the next release branch.
8413         Rename the section of the current branch, now that it has
8414         been cut.
8415
8416 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
8417
8418         GDB 8.1 branch created (5219ac6237c272b938c28517bf371429260c71e7):
8419         * version.in: Bump version to 8.1.50.DATE-git.
8420
8421 2018-01-03  Xavier Roirand  <roirand@adacore.com>
8422
8423         * ada-lang.h (ada_exception_catchpoint_kind) <ada_catch_handlers>:
8424         Add field.
8425         * ada-lang.c (struct exception_support_info) <catch_handlers_sym>:
8426         Add field.
8427         (default_exception_support_info) <catch_handlers_sym>: Add field.
8428         (exception_support_info_fallback) <catch_handlers_sym>: Add field.
8429         (ada_exception_name_addr_1): Add "catch handlers" handling.
8430         (ada_exception_catchpoint_cond_string) <ex>: New parameter.
8431         Update all callers.
8432         (create_excep_cond_exprs) <ex>: Add parameter.
8433         (re_set_exception): Update create_excep_cond_exprs call.
8434         (print_it_exception, print_one_exception, print_mention_exception)
8435         (print_recreate_exception): Add "catch handler" handling.
8436         (allocate_location_catch_handlers, re_set_catch_handlers)
8437         (check_status_catch_handlers, print_it_catch_handlers)
8438         (print_one_catch_handlers, print_mention_catch_handlers)
8439         (print_recreate_catch_handlers): New function.
8440         (catch_handlers_breakpoint_ops): New variable.
8441         (catch_ada_exception_command_split) <is_catch_handlers_cmd>:
8442         Add parameter.  Add "catch handler" handling.
8443         (ada_exception_sym_name, ada_exception_breakpoint_ops):
8444         Add "catch handler" handling.
8445         (ada_exception_catchpoint_cond_string): Add "catch handler"
8446         handling.
8447         (create_ada_exception_catchpoint): Update create_excep_cond_exprs
8448         call.
8449         (catch_ada_handlers_command): New function.
8450         (initialize_ada_catchpoint_ops): Initialize "catch handlers"
8451         operations structure.
8452         (_initialize_ada_language): Add "catch handlers" command entry.
8453         * NEWS: Document "catch handlers" feature.
8454
8455 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
8456
8457         * ada-lang.c (ada_value_slice_from_ptr): Take array stride into
8458         account when creating the array type of the slice.
8459         (ada_value_slice): Likewise.
8460
8461 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
8462
8463         * gdbtypes.h (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_STRIDE>:
8464         New enum value.
8465         (create_array_type_with_stride): Add byte_stride_prop parameter.
8466         * gdbtypes.c (create_array_type_with_stride) <byte_stride_prop>:
8467         New parameter.  Update all callers in this file.
8468         (array_type_has_dynamic_stride): New function.
8469         (is_dynamic_type_internal, resolve_dynamic_array): Add handling
8470         of arrays with dynamic byte strides.
8471         * dwarf2read.c (read_array_type): Add support for dynamic
8472         DW_AT_byte_stride attributes.
8473
8474 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
8475
8476         * dwarf2read.c (read_unspecified_type): Treat
8477         DW_TAG_enumeration_type DIEs from Ada units as stubs.
8478
8479 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
8480
8481         Update copyright year range in all GDB files.
8482
8483 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
8484
8485         * copyright.py (BY_HAND): Remove gdb/testsuite/gdb.base/step-line.inp
8486         and gdb/testsuite/gdb.base/step-line.c.
8487
8488 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
8489
8490         * copyright.py (main): Dump the contents of
8491         MULTIPLE_COPYRIGHT_HEADERS (separately) from BY_HAND,
8492         even if BY_HAND is empty.
8493
8494 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
8495
8496         * top.c (print_gdb_version): Update Copyright year in version
8497         message.
8498
8499 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
8500
8501         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2017.
8502
8503 For older changes see ChangeLog-2017.
8504 \f
8505 Local Variables:
8506 mode: change-log
8507 left-margin: 8
8508 fill-column: 74
8509 version-control: never
8510 coding: utf-8
8511 End: