gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-layout.c (make_command_window): Remove.
   4         (show_source_disasm_command, show_source_or_disasm_and_command):
   5         Unify creation and re-initialization cases.
   6
   7 2019-07-17  Tom Tromey  <tom@tromey.com>
   8
   9         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
  10         creation and re-initialization cases.
  11
  12 2019-07-17  Tom Tromey  <tom@tromey.com>
  13
  14         * tui/tui-regs.c (tui_get_register): Return void.
  15
  16 2019-07-17  Tom Tromey  <tom@tromey.com>
  17
  18         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
  19         Simplify.
  20
  21 2019-07-17  Tom Tromey  <tom@tromey.com>
  22
  23         * tui/tui-layout.c (show_source_disasm_command): Simplify window
  24         resetting.
  25
  26 2019-07-17  Tom Tromey  <tom@tromey.com>
  27
  28         * tui/tui.h (tui_set_layout_by_name): Don't declare.
  29         * tui/tui-regs.c (tui_reg_layout): New function.
  30         (tui_show_registers, tui_reg_command): Use it.
  31         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
  32         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
  33         parameters.
  34         (tui_layout_command): Remove.
  35
  36 2019-07-17  Tom Tromey  <tom@tromey.com>
  37
  38         * tui/tui-layout.h (tui/tui-layout): Return void.
  39         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
  40
  41 2019-07-17  Tom Tromey  <tom@tromey.com>
  42
  43         * tui/tui-layout.c (show_source_disasm_command, show_data):
  44         Update.
  45         (reset_locator): Remove.
  46         (show_source_or_disasm_and_command): Update.
  47
  48 2019-07-17  Tom Tromey  <tom@tromey.com>
  49
  50         * tui/tui-source.c (tui_source_window_base::reset): Remove
  51         win_type parameter.
  52         * tui/tui-layout.c (make_command_window, make_source_window)
  53         (make_disasm_window, make_data_window)
  54         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
  55         (reset_locator, show_source_or_disasm_and_command): Update.
  56         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
  57         win_type parameter.
  58         (struct tui_source_window_base) <reset>: Likewise.
  59
  60 2019-07-17  Tom Tromey  <tom@tromey.com>
  61
  62         * tui/tui-layout.c (show_source_disasm_command): Use
  63         reset_locator.
  64         (reset_locator): New function.
  65         (init_and_make_win): Remove.
  66         (show_source_or_disasm_and_command): Use reset_locator.
  67
  68 2019-07-17  Tom Tromey  <tom@tromey.com>
  69
  70         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
  71         condition.
  72         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
  73         Remove condition.
  74         * tui/tui-source.c (tui_source_window_base::reset): New method.
  75         * tui/tui-layout.c (make_command_window): Don't call
  76         init_and_make_win.
  77         (make_source_window, make_disasm_window): Don't call
  78         make_source_or_disasm_window.
  79         (make_data_window): Don't call init_and_make_win.  Change calling
  80         convention.
  81         (show_source_disasm_command, show_data): Simplify.
  82         (make_source_or_disasm_window): Remove.
  83         (show_source_or_disasm_and_command): Simplify.
  84         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
  85         (struct tui_source_window_base) <reset>: Likewise.
  86         <execution_info>: Remove initializer.
  87         * tui/tui-data.c (tui_source_window_base): Initialize
  88         execution_info.
  89
  90 2019-07-17  Tom Tromey  <tom@tromey.com>
  91
  92         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
  93         variable.
  94
  95 2019-07-17  Tom Tromey  <tom@tromey.com>
  96
  97         * tui/tui.c (tui_rl_other_window): Update.
  98         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
  99         superclass method first.  Always iterate over regs_content.
 100         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 101         method.
 102         * tui/tui-win.c (tui_set_focus_command): Update.
 103
 104 2019-07-17  Tom Tromey  <tom@tromey.com>
 105
 106         * tui/tui-win.c (tui_set_focus_command): Rename from
 107         tui_set_focus.  Call tui_enable.
 108         (tui_set_focus_command): Remove.
 109
 110 2019-07-17  Tom Tromey  <tom@tromey.com>
 111
 112         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 113         refresh_window.
 114         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 115         touchwin.
 116         (tui_data_window::refresh_window): Call refresh_window on data
 117         items.  Always call superclass refresh_window.
 118         (tui_win_info::refresh): Remove.
 119         (tui_source_window_base::refresh_window): Update.
 120         (tui_refresh_all): Update.
 121         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 122         refresh_window.
 123         (show_source_or_disasm_and_command): Likewise.
 124         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 125         (struct tui_source_window_base) <refresh>: Likewise.
 126
 127 2019-07-17  Tom Tromey  <tom@tromey.com>
 128
 129         * tui/tui-winsource.c (tui_clear_source_content)
 130         (tui_show_source_content): Update.
 131         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 132         whether content is empty.
 133         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 134         Remove.
 135
 136 2019-07-17  Tom Tromey  <tom@tromey.com>
 137
 138         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 139         window's contents.
 140         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 141         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 142
 143 2019-07-17  Tom Tromey  <tom@tromey.com>
 144
 145         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 146         (struct tui_data_item_window): Update.
 147
 148 2019-07-17  Tom Tromey  <tom@tromey.com>
 149
 150         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 151         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 152         defines.
 153
 154 2019-07-17  Tom Tromey  <tom@tromey.com>
 155
 156         * tui/tui-winsource.h (tui_erase_source_content)
 157         (tui_clear_source_content): Remove "display_prompt" parameter.
 158         * tui/tui-winsource.c (tui_update_source_window_as_is)
 159         (tui_update_source_windows_with_addr): Update.
 160         (tui_clear_source_content): Remove "display_prompt" parameter.
 161         (tui_erase_source_content): Likewise.  Simplify.
 162         (tui_show_source_content): Update.
 163         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 164         * tui/tui-stack.c (tui_show_frame_info): Update.
 165         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 166         Remove defines.
 167
 168 2019-07-17  Tom Tromey  <tom@tromey.com>
 169
 170         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 171         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 172         parameter.
 173         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 174         parameter.
 175
 176 2019-07-17  Tom Tromey  <tom@tromey.com>
 177
 178         * tui/tui-winsource.c (tui_clear_source_content)
 179         (tui_show_source_content, tui_show_exec_info_content)
 180         (tui_clear_exec_info_content): Update.
 181         * tui/tui-stack.c (tui_show_locator_content): Update.
 182         (tui_show_frame_info): Update.
 183         * tui/tui-source.h (tui_source_window): Don't declare.
 184         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 185         from tui_source_is_displayed.
 186         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 187         Remove field.
 188         (struct tui_source_window_base) <content_in_use>: New field.  Now
 189         bool.
 190         (struct tui_source_window) <showing_source_p>: New method.
 191         (TUI_SRC_WIN): Change cast.
 192         * tui/tui-data.c (tui_initialize_static_data): Update.
 193
 194 2019-07-17  Tom Tromey  <tom@tromey.com>
 195
 196         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 197         location_matches_p.
 198         * tui/tui-source.c (tui_source_window::location_matches_p): New
 199         method.
 200         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 201         method.
 202         * tui/tui-data.h (struct tui_source_window_base)
 203         <location_matches_p>: New method.
 204         (struct tui_source_window, struct tui_disasm_window)
 205         <location_matches_p>: Likewise.
 206
 207 2019-07-17  Tom Tromey  <tom@tromey.com>
 208
 209         * tui/tui-win.c (tui_set_win_height_command): Rename from
 210         tui_set_win_height.
 211         (tui_set_win_height_command): Remove.
 212
 213 2019-07-17  Tom Tromey  <tom@tromey.com>
 214
 215         * tui/tui-source.c (tui_source_window): New constructor.  Add
 216         observer.
 217         (~tui_source_window): New destructor.
 218         (tui_source_window::style_changed): New method.
 219         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 220         (tui_attach_detach_observers): Update.
 221         * tui/tui-data.h (struct tui_source_window): Make constructor not
 222         inline.  Add destructor.
 223         (struct tui_source_window) <style_changed>: New method.
 224         <m_observable>: New member.
 225
 226 2019-07-17  Tom Tromey  <tom@tromey.com>
 227
 228         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 229         * tui/tui-win.c (tui_resize_all): Fix typo.
 230
 231 2019-07-17  Tom Tromey  <tom@tromey.com>
 232
 233         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 234         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 235         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 236         * tui/tui-win.c (window_name_completer): Use foreach.
 237         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 238         (update_tab_width): Likewise.
 239         * tui/tui-layout.c (show_layout): Update.
 240         * tui/tui-data.h (class tui_window_iterator): New.
 241         (struct all_tui_windows): New.
 242         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 243
 244 2019-07-17  Tom Tromey  <tom@tromey.com>
 245
 246         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 247         parameter.  Don't reference globals.
 248         (tui_reg_command): Update.
 249
 250 2019-07-17  Tom Tromey  <tom@tromey.com>
 251
 252         * tui/tui-regs.c (tui_show_registers): Simplify.
 253
 254 2019-07-17  Tom Tromey  <tom@tromey.com>
 255
 256         * tui/tui-regs.c (tui_show_registers): Update.
 257         (tui_show_register_group): Add win_info parameter.
 258
 259 2019-07-17  Tom Tromey  <tom@tromey.com>
 260
 261         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 262         Rename from tui_display_reg_element_at_line.
 263         (tui_data_window::display_registers_from_line): Update.
 264         * tui/tui-data.h (struct tui_data_window)
 265         <display_reg_element_at_line>: New method.
 266
 267 2019-07-17  Tom Tromey  <tom@tromey.com>
 268
 269         * tui/tui-regs.h (tui_display_registers_from)
 270         (tui_display_registers_from_line): Don't declare.
 271         * tui/tui-windata.c (tui_data_window::display_all_data)
 272         (tui_data_window::refresh_all)
 273         (tui_data_window::do_scroll_vertical): Update.
 274         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 275         from tui_display_registers_from.
 276         (tui_display_reg_element_at_line): Update.
 277         (tui_data_window::display_registers_from_line): Rename from
 278         tui_display_registers_from_line.
 279         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 280         display_registers_from_line>: New methods.
 281
 282 2019-07-17  Tom Tromey  <tom@tromey.com>
 283
 284         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 285         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 286         from tui_erase_data_content.
 287         (tui_data_window::display_all_data)
 288         (tui_data_window::refresh_all)
 289         (tui_data_window::do_scroll_vertical): Update.
 290         * tui/tui-regs.c (tui_show_registers): Update.
 291         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 292         New method.
 293
 294 2019-07-17  Tom Tromey  <tom@tromey.com>
 295
 296         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 297         declare.
 298         * tui/tui-windata.c
 299         (tui_data_window::delete_data_content_windows): Rename from
 300         tui_delete_data_content_windows.
 301         (tui_data_window::display_all_data)
 302         (tui_data_window::do_scroll_vertical): Update.
 303         * tui/tui-data.h (struct tui_data_window)
 304         <delete_data_content_windows>: New method.
 305
 306 2019-07-17  Tom Tromey  <tom@tromey.com>
 307
 308         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 309         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 310
 311 2019-07-17  Tom Tromey  <tom@tromey.com>
 312
 313         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 314         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 315         from tui_display_all_data.
 316         * tui/tui-win.c
 317         (tui_data_window::do_make_visible_with_new_height): Update.
 318         * tui/tui-regs.c (tui_show_registers): Update.
 319         * tui/tui-layout.c (tui_set_layout): Update.
 320         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 321         method.
 322
 323 2019-07-17  Tom Tromey  <tom@tromey.com>
 324
 325         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 326         * tui/tui-windata.c (tui_display_data_from): Remove.
 327         (tui_data_window::refresh_all): Update.
 328
 329 2019-07-17  Tom Tromey  <tom@tromey.com>
 330
 331         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 332         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 333         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 334         tui_display_registers_from_line.
 335         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 336         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 337         "force_display" parameter.
 338
 339 2019-07-17  Tom Tromey  <tom@tromey.com>
 340
 341         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 342         declare.
 343         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 344         Rename from tui_first_reg_element_no_inline.
 345         (tui_display_reg_element_at_line)
 346         (tui_display_registers_from_line): Update.
 347         * tui/tui-data.h (struct tui_data_window)
 348         <first_reg_element_no_inline>: New method.
 349
 350 2019-07-17  Tom Tromey  <tom@tromey.com>
 351
 352         * tui/tui-windata.c (tui_display_data_from)
 353         (tui_data_window::do_scroll_vertical): Update.
 354         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 355         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 356         Rename from tui_line_from_reg_element_no.
 357         (tui_display_registers_from_line): Update.
 358         * tui/tui-data.h (struct tui_data_window)
 359         <line_from_reg_element_no>: New method.
 360
 361 2019-07-17  Tom Tromey  <tom@tromey.com>
 362
 363         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 364         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 365         tui_last_regs_line_no.
 366         (tui_display_reg_element_at_line)
 367         (tui_display_registers_from_line): Update.
 368         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 369         method.
 370
 371 2019-07-17  Tom Tromey  <tom@tromey.com>
 372
 373         PR tui/24722:
 374         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 375         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 376         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 377         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 378         (tui_update_breakpoint_info): Likewise.
 379         * tui/tui-hooks.c (tui_event_create_breakpoint)
 380         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 381         Update.
 382
 383 2019-07-17  Tom Tromey  <tom@tromey.com>
 384
 385         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 386
 387 2019-07-17  Tom Tromey  <tom@tromey.com>
 388
 389         * tui/tui-winsource.c (tui_update_source_window_as_is)
 390         (tui_update_source_windows_with_addr): Update.
 391         * tui/tui-source.h (tui_set_source_content)
 392         (tui_show_symtab_source): Add "win_info" parameter.
 393         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 394         parameter.
 395         (tui_show_symtab_source): Likewise.
 396
 397 2019-07-17  Tom Tromey  <tom@tromey.com>
 398
 399         * tui/tui-wingeneral.c
 400         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 401
 402 2019-07-17  Tom Tromey  <tom@tromey.com>
 403
 404         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 405         (struct tui_cmd_window) <can_scroll>: New method.
 406         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 407         method.
 408
 409 2019-07-17  Tom Tromey  <tromey@adacore.com>
 410
 411         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 412         do_field_signed>: Rename.  Change type of "value".
 413         * ui-out.c (ui_out::field_signed): Rename from field_int.
 414         Change type of "value".
 415         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 416         type of "value".
 417         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 418         do_field_int.  Change type of "value".
 419         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 420         do_field_int.  Change type of "value".
 421         * tracepoint.c (trace_status_mi, tfind_1)
 422         (print_one_static_tracepoint_marker): Update.
 423         * thread.c (print_thread_info_1, print_selected_thread_frame):
 424         Update.
 425         * stack.c (print_frame, print_frame_info): Update.
 426         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 427         Update.
 428         * source.c (print_source_lines_base): Update.
 429         * skip.c (info_skip_command): Update.
 430         * record-btrace.c (btrace_ui_out_decode_error)
 431         (btrace_call_history_src_line): Update.
 432         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 433         Update.
 434         * progspace.c (print_program_space): Update.
 435         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 436         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 437         do_field_int.  Change type of "value".
 438         * mi/mi-out.c (mi_ui_out::do_table_begin)
 439         (mi_ui_out::do_table_header): Update.
 440         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 441         type of "value".
 442         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 443         (mi_cmd_data_list_changed_registers, output_register)
 444         (mi_cmd_data_read_memory, mi_load_progress)
 445         (mi_cmd_trace_frame_collected): Update.
 446         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 447         Update.
 448         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 449         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 450         (mi_cmd_var_list_children, varobj_update_one): Update.
 451         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 452         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 453         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 454         * inferior.c (print_inferior): Update.
 455         * gdb_bfd.c (print_one_bfd): Update.
 456         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 457         Update.
 458         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 459         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 460         do_field_int.  Change type of "value".
 461         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 462         do_field_int.  Change type of "value".
 463         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 464         (print_one_breakpoint_location, print_it_catch_fork)
 465         (print_one_catch_fork, print_it_catch_vfork)
 466         (print_one_catch_vfork, print_it_catch_solib)
 467         (print_it_catch_exec, print_it_ranged_breakpoint)
 468         (print_mention_watchpoint, print_mention_masked_watchpoint)
 469         (bkpt_print_it, update_static_tracepoint): Update.
 470         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 471         * break-catch-syscall.c (print_it_catch_syscall): Update.
 472         * ada-tasks.c (print_ada_task_info): Update.
 473         * ada-lang.c (print_it_exception, print_mention_exception):
 474         Update.
 475
 476 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 477
 478         PR breakpoints/24541
 479         * gdbarch.c: Regenerate.
 480         * gdbarch.h: Regenerate.
 481         * gdbarch.sh: Adjust return type and parameter types for
 482         'stap_adjust_register'.
 483         (i386_stap_adjust_register): Adjust signature and return new
 484         register name.
 485         * stap-probe.c (stap_parse_register_operand): Adjust use of
 486         'gdbarch_stap_adjust_register'.
 487
 488 2019-07-17  Tom Tromey  <tromey@adacore.com>
 489
 490         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 491         declare VEC.
 492         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 493         std::vector.
 494         (struct s390_process_info): Add initializers.
 495         (s390_add_process): Use new.
 496         (s390_linux_nat_target::low_forget_process): Use delete.
 497         (s390_linux_nat_target::low_new_fork)
 498         (s390_linux_nat_target::stopped_by_watchpoint)
 499         (s390_linux_nat_target::low_prepare_to_resume)
 500         (s390_linux_nat_target::insert_watchpoint)
 501         (s390_linux_nat_target::insert_hw_breakpoint)
 502         (s390_linux_nat_target::remove_watchpoint)
 503         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 504
 505 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 506
 507         * aarch64-fbsd-nat.c: Include regcache.h.
 508         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 509         argument.
 510         (aarch64_fbsd_nat_target::fetch_registers)
 511         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 512         variable.
 513         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 514
 515 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 516
 517         * fbsd-nat.c: Include gdbarch.h.
 518
 519 2019-07-15  Tom Tromey  <tromey@adacore.com>
 520
 521         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 522
 523 2019-07-15  Tom Tromey  <tromey@adacore.com>
 524
 525         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 526         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 527         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 528         * cli-out.c (cli_ui_out::do_field_int): New method.
 529         * ui-out.c (ui_out::field_unsigned): New method.
 530         * symfile.c (generic_load): Use field_unsigned.
 531         (print_transfer_performance): Likewise.
 532         * record-btrace.c (ui_out_field_uint): Remove.
 533         (btrace_call_history_insn_range, btrace_call_history): Use
 534         field_unsigned.
 535         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 536         field_unsigned.
 537         * ui-out.h (class ui_out) <field_unsigned>: New method.
 538         <do_field_unsigned>: Likewise.
 539
 540 2019-07-15  Tom Tromey  <tromey@adacore.com>
 541
 542         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 543         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 544         * target.c (flash_erase_command): Use field_string.
 545         * infrun.c (print_signal_received_reason): Use field_string.
 546         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 547         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 548         field_string.
 549         * ada-tasks.c (print_ada_task_info): Use field_string.
 550
 551 2019-07-15  Tom Tromey  <tromey@adacore.com>
 552
 553         * target.c (flash_erase_command): Use field_core_addr.
 554         * symfile.c (generic_load): Use field_core_addr.
 555         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 556         Use field_core_addr.
 557         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 558         field_core_addr.
 559
 560 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 561
 562         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 563         value if its desired type is smaller than a CORE_ADDR and signed.
 564
 565 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 566
 567         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 568         of changes to field names, and use new is_reference field to
 569         decide if a property is a reference or not.
 570         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 571         field.
 572         (struct dwarf2_property_baton): Update header comment, rename
 573         'referenced_type' to 'property_type' and update comments.
 574         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 575         default property type, store in property baton, update to take
 576         accound of renamed field.
 577         (read_func_scope): Update call to attr_to_dynamic_prop.
 578         (read_array_type): Likewise.
 579         (dwarf2_per_cu_addr_sized_int_type): New function.
 580         (read_subrange_index_type): Move type finding code to
 581         dwarf2_per_cu_addr_sized_int_type.
 582         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 583         (dwarf2_per_cu_addr_type): New function.
 584         (set_die_type): Update calls to attr_to_dynamic_prop.
 585
 586 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 587
 588         * dwarf2read.c (read_subrange_index_type): New function.
 589         (read_subrange_type): Move code into new function and call it.
 590         * gdbtypes.c (create_range_type): Add some asserts.
 591
 592 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 593
 594         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 595         update return statements.
 596         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 597         declaration, and update comment to match.
 598         * gdbtypes.c (resolve_dynamic_array): Update call to
 599         dwarf2_evaluate_property to match new return type.
 600
 601 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 602
 603         * valarith.c (value_subscripted_rvalue): Change lowerbound
 604         parameter type from int to LONGEST.
 605         * value.h (value_subscripted_rvalue): Likewise in declaration.
 606
 607 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 608
 609         * cli/cli-utils.c (info_print_command_completer): New function.
 610         * cli/cli-utils.h: Add 'completer.h' include, and forward
 611         declaration for 'struct cmd_list_element'.
 612         (info_print_command_completer): Declare.
 613         * stack.c (_initialize_stack): Add completer for 'info locals' and
 614         'info args'.
 615         * symtab.c (_initialize_symtab): Add completer for 'info
 616         variables' and 'info functions'.
 617         * NEWS: Mention completion for additional info commands.
 618
 619 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 620
 621         * cli/cli-utils.c (extract_info_print_args): Delete.
 622         (extract_arg_maybe_quoted): Delete.
 623         (info_print_options_defs): New variable.
 624         (make_info_print_options_def_group): New function.
 625         (extract_info_print_options): Define new function.
 626         * cli/cli-utils.h (extract_info_print_args): Delete.
 627         (struct info_print_options): New structure.
 628         (extract_info_print_options): Declare new function.
 629         * stack.c (info_locals_command): Update to use new
 630         extract_info_print_options, also add a header comment.
 631         (info_args_command): Likewise.
 632         * symtab.c (info_variables_command): Likewise.
 633         (info_functions_command): Likewise.
 634
 635 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 636
 637         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 638         to extract string arguments.
 639         * common/common-utils.c (extract_string_maybe_quoted): New function.
 640         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 641
 642 2019-07-11  Tom Tromey  <tromey@adacore.com>
 643
 644         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 645         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 646         * top.h (gdbinit): Don't declare.
 647         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 648         into...
 649         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 650         * top.c (gdb_init): Don't call init_cli_cmds.
 651         (gdbinit): Remove.
 652         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 653
 654 2019-07-11  Tom Tromey  <tromey@adacore.com>
 655
 656         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 657         after it has been moved.
 658
 659 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 660
 661         * valops.c (value_must_coerce_to_target): Change return type to
 662         bool.
 663         * value.h (value_must_coerce_to_target): Likewise.
 664
 665 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 666
 667         * breakpoint.c (is_hardware_watchpoint): Remove
 668         forward-declaration.
 669         (is_masked_watchpoint): Change return type to bool.
 670         (is_tracepoint): Likewise.
 671         (is_breakpoint): Likewise.
 672         (is_hardware_watchpoint): Likewise.
 673         (is_watchpoint): Likewise.
 674         (is_no_memory_software_watchpoint): Likewise.
 675         (is_catchpoint): Likewise.
 676         (breakpoint_1): Make FILTER parameter's return type bool.
 677         is_masked_watchpoint): Change return type to bool.
 678         (save_breakpoints): Make FILTER parameter's return type bool.
 679         * breakpoint.h (is_breakpoint): Change return type to bool.
 680         (is_watchpoint): Likewise.
 681         (is_catchpoint): Likewise.
 682         (is_tracepoint): Likewise.
 683
 684 2019-07-10  Tom Tromey  <tom@tromey.com>
 685
 686         * defs.h: Don't include gdbarch.h.
 687         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 688         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 689         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 690         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 691         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 692         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 693         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 694         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 695         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 696         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 697         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 698         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 699         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 700         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 701         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 702         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 703         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 704         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 705         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 706         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 707         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 708         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 709         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 710         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 711         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 712         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 713         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 714
 715 2019-07-10  Tom Tromey  <tromey@adacore.com>
 716
 717         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 718         * breakpoint.c (init_ada_exception_breakpoint): Register as
 719         bp_catchpoint.
 720         (print_one_breakpoint_location, print_one_breakpoint): Use
 721         is_ada_exception_catchpoint.
 722         * ada-lang.c (class ada_catchpoint_location): Pass
 723         bp_loc_software_breakpoint to bp_location constructor.
 724         (is_ada_exception_catchpoint): New function.
 725
 726 2019-07-10  Tom Tromey  <tromey@adacore.com>
 727
 728         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 729         VEC.
 730         (struct arm_exidx_entry): New method operator<.
 731         (struct arm_exidx_data) <section_maps>: Change type.
 732         (arm_exidx_data_free): Remove.
 733         (arm_exidx_data_key): Change type.  Move lower.
 734         (arm_exidx_new_objfile): Update.
 735         (arm_compare_exidx_entries): Remove.
 736         (arm_find_exidx_entry, _initialize_arm_tdep)
 737
 738 2019-07-10  Tom Tromey  <tromey@adacore.com>
 739
 740         * solib-spu.c (ocl_program_data_key): Change type.
 741         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 742         Update.
 743
 744 2019-07-10  Tom Tromey  <tromey@adacore.com>
 745
 746         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 747         (struct solib_aix_inferior_data) <library_list>: Change type.
 748         (solib_aix_inferior_data_handle): Change type.
 749         (get_solib_aix_inferior_data): Update.
 750         (solib_aix_free_library_list): Remove.
 751         (library_list_start_library): Update.
 752         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 753         return type.
 754         (solib_aix_get_library_list)
 755         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 756         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 757
 758 2019-07-10  Tom Tromey  <tromey@adacore.com>
 759
 760         * solib-dsbt.c (struct dsbt_info): Add initializers.
 761         (solib_dsbt_pspace_data): Change type.
 762         (dsbt_pspace_data_cleanup): Remove.
 763         (get_dsbt_info, _initialize_dsbt_solib): Update.
 764
 765 2019-07-10  Tom Tromey  <tromey@adacore.com>
 766
 767         * spu-tdep.c (spu_overlay_data): Change type.
 768         (spu_get_overlay_table, spu_overlay_new_objfile)
 769         (_initialize_spu_tdep): Update.
 770
 771 2019-07-10  Tom Tromey  <tromey@adacore.com>
 772
 773         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 774         destructor.
 775         (dbx_objfile_data_key): Change type and declare later.
 776         (DBX_SYMFILE_INFO): Rewrite.
 777         * dbxread.c (dbx_objfile_data_key): Change type.
 778         (dbx_symfile_init): Update.
 779         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 780         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 781         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 782
 783 2019-07-10  Tom Tromey  <tromey@adacore.com>
 784
 785         * jit.c (jit_program_space_key): Change type.  Move lower.
 786         (get_jit_program_space_data): Update.
 787         (jit_program_space_data_cleanup): Remove.
 788         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 789         Update.
 790         (struct jit_program_space_data): Add initializers.
 791
 792 2019-07-10  Tom Tromey  <tromey@adacore.com>
 793
 794         * solib-darwin.c (struct darwin_info): Add initializers.
 795         (solib_darwin_pspace_data): Change type.
 796         (darwin_pspace_data_cleanup): Remove.
 797         (get_darwin_info, _initialize_darwin_solib): Update.
 798
 799 2019-07-10  Tom Tromey  <tromey@adacore.com>
 800
 801         * remote-sim.c (struct sim_inferior_data): Add initializers,
 802         constructor, and destructor.
 803         (sim_inferior_data_key): Change type.  Move lower.
 804         (check_for_duplicate_sim_descriptor): Update.
 805         (get_sim_inferior_data): Use new.  Update.
 806         (~sim_inferior_data_cleanup): Rename from
 807         sim_inferior_data_cleanup.  Simplify.
 808         (gdbsim_close_inferior, simulator_command)
 809         (sim_command_completer, _initialize_remote_sim): Update.
 810         (next_pid, INITIAL_PID): Move earlier.
 811
 812 2019-07-10  Tom Tromey  <tromey@adacore.com>
 813
 814         * python/python-internal.h (create_thread_object): Return
 815         gdbpy_ref.
 816         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 817         * python/py-inferior.c (struct threadlist_entry): Add
 818         constructor.
 819         <thread_obj>: Now a gdbpy_ref.
 820         (thread_to_thread_object): Update.
 821         (add_thread_object): Use new.
 822         (delete_thread_object): Use delete.
 823         (infpy_threads): Update.
 824         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 825         GIL.
 826
 827 2019-07-10  Tom Tromey  <tromey@adacore.com>
 828
 829         * valops.c (value_cast): Specialize error message for Ada.
 830
 831 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 832
 833         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 834
 835 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 836
 837         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 838         bpstat_should_step): Return bool, adjust comments.
 839         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 840         bpstat_should_step): Likewise.
 841
 842 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 843
 844         * features/Makefile: Use feature target descriptions for Arm.
 845         * features/arm/arm-core.c: Generate new file.
 846         * features/arm/arm-fpa.c: Likewise.
 847         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 848         * features/arm/arm-m-profile.c: Likewise.
 849         * features/arm/arm-vfpv2.c: Likewise.
 850         * features/arm/arm-vfpv3.c: Likewise.
 851         * features/arm/xscale-iwmmxt.c: Likewise.
 852         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 853
 854 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 855
 856         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 857         ptrace earlier.
 858
 859 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 860
 861         * features/aarch64-pauth.c: Regenerate.
 862
 863 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 864
 865         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 866         bool.
 867         (bpstat_what): Use false instead of 0.
 868
 869 2019-07-09  Pedro Alves  <palves@redhat.com>
 870
 871         * break-catch-throw.c (is_exception_catchpoint): New.
 872         * breakpoint.c (print_one_breakpoint_location): New parameter
 873         'raw_loc'.  Handle it.  Use
 874         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 875         looking at the breakpoint's type.
 876         (print_one_breakpoint): If handling "maint info breakpoints", also
 877         print locations of exception catchpoints.
 878         * breakpoint.h (is_exception_catchpoint): Declare.
 879
 880 2019-07-09  Pedro Alves  <palves@redhat.com>
 881
 882         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 883         "addr" field.
 884         (allocate_location_exception_catchpoint): New.
 885         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 886         (initialize_throw_catchpoint_ops): Install
 887         allocate_location_exception_catchpoint as allocate_location
 888         method.
 889         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 890         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 891         bp_loc_other.
 892         (breakpoint_address_is_meaningful): Delete.
 893         (bl_address_is_meaningful): New.
 894         (breakpoint_locations_match): Adjust comment.
 895         (bp_location_from_bp_type): New, factored out of...
 896         (bp_location::bp_location(breakpoint *)): ... this.
 897         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 898         factored out of...
 899         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 900         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 901         breakpoint_address_is_meaningful.
 902         (bp_locations_compare): Adjust comment.
 903         (update_global_location_list): Use bl_address_is_meaningful
 904         instead of breakpoint_address_is_meaningful.
 905         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 906         explicit.
 907         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 908         * python/py-breakpoint.c (bppy_get_location): No longer check
 909         whether location is null.
 910
 911 2019-07-09  Pedro Alves  <palves@redhat.com>
 912
 913         PR c++/15468
 914         * breakpoint.c (print_one_breakpoint_location): Remove
 915         single-location assert.
 916
 917 2019-07-09  Tom Tromey  <tom@tromey.com>
 918
 919         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 920         * configure: Rebuild.
 921         * configure.ac: Change common to gdbsupport.
 922         * gdbsupport: Rename from common.
 923         * acinclude.m4: Change common to gdbsupport.
 924         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 925         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 926         gdbsupport.
 927         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 928         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 929         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 930         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 931         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 932         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 933         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 934         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 935         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 936         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 937         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 938         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 939         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 940         coff-pe-read.c, command.h, compile/compile-c-support.c,
 941         compile/compile-c.h, compile/compile-cplus-symbols.c,
 942         compile/compile-cplus-types.c, compile/compile-cplus.h,
 943         compile/compile-loc2c.c, compile/compile.c, completer.c,
 944         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 945         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 946         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 947         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 948         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 949         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 950         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 951         features/aarch64-core.c, features/aarch64-fpu.c,
 952         features/aarch64-pauth.c, features/aarch64-sve.c,
 953         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 954         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 955         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 956         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 957         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 958         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 959         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 960         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 961         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 962         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 963         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 964         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 965         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 966         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 967         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 968         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 969         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 970         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 971         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 972         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 973         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 974         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 975         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 976         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 977         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 978         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 979         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 980         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 981         minsyms.c, mips-linux-tdep.c, namespace.h,
 982         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 983         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 984         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 985         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 986         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 987         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 988         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 989         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 990         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 991         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 992         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 993         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 994         procfs.c, producer.c, progspace.h, psymtab.h,
 995         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 996         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 997         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 998         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 999         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1000         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1001         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1002         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1003         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1004         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1005         target-memory.c, target.c, target.h, target/waitstatus.c,
1006         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1007         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1008         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1009         unittests/array-view-selftests.c,
1010         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1011         unittests/common-utils-selftests.c,
1012         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1013         unittests/format_pieces-selftests.c,
1014         unittests/function-view-selftests.c,
1015         unittests/lookup_name_info-selftests.c,
1016         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1017         unittests/mkdir-recursive-selftests.c,
1018         unittests/observable-selftests.c,
1019         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1020         unittests/parse-connection-spec-selftests.c,
1021         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1022         unittests/scoped_fd-selftests.c,
1023         unittests/scoped_mmap-selftests.c,
1024         unittests/scoped_restore-selftests.c,
1025         unittests/string_view-selftests.c, unittests/style-selftests.c,
1026         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1027         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1028         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1029         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1030         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1031         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1032
1033 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1034
1035         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1036         bool value.
1037         (decode_digits_ordinary): Set explicit_line field in sal.
1038         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1039         symtab_and_line that was set on an explicit line number in
1040         assembler code.  Do always update the recorded symtab and line if
1041         we do skip the prologue.
1042
1043 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1044
1045         * breakpoint.c (set_breakpoint_location_function): Remove
1046         explicit_loc parameter.
1047         (momentary_breakpoint_from_master): Update call to
1048         set_breakpoint_location_function.
1049         (add_location_to_breakpoint): Likewise.
1050
1051 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1052
1053         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1054         required features based on default bfd type when no specific bfd
1055         is present.
1056
1057 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1058
1059         * NEWS: Mention that GDB printf and eval commands can now print
1060         C-style and Ada-style convenience var strings without
1061         calling the inferior.
1062         * printcmd.c (printf_c_string): Locally print GDB internal var
1063         instead of transiting via the inferior.
1064         (printf_wide_c_string): Likewise.
1065
1066 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1067
1068         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1069
1070 2019-07-04  Tom Tromey  <tom@tromey.com>
1071
1072         PR tui/24724:
1073         * tui/tui-winsource.c (tui_clear_source_content): Update.
1074         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1075         (tui_update_breakpoint_info): Update.
1076         (tui_set_exec_info_content): Update.
1077         * tui/tui-source.c (tui_set_source_content_nil): Update.
1078         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1079         has_break.
1080         * tui/tui-data.h (enum tui_bp_flag): New.
1081         (tui_bp_flags): New enum flags type.
1082         (struct tui_source_element) <break_mode>: Change type.  Rename
1083         from has_break.
1084         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1085         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1086         constants.
1087         * tui/tui-winsource.h: Fix comment.
1088
1089 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1090
1091         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1092         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1093         (store_fpregs_to_thread)
1094         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1095         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1096         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1097         (IWMMXT_REGS_SIZE): Add define.
1098         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1099         (fetch_vfp_regs, store_vfp_regs)
1100         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1101         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1102
1103 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1104
1105         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1106         defines.
1107         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1108         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1109         (ARM_INT_REGISTER_SIZE): ...to this.
1110         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1111         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1112         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1113         (arm_linux_collect_gregset, supply_nwfpe_register)
1114         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1115         defines.
1116         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1117         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1118         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1119         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1120         (arm_return_in_memory, arm_store_return_value)
1121         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1122         (arm_record_ld_st_multiple): Likewise.
1123         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1124         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1125
1126 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1127
1128         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1129         AARCH64_DISPLACED_MODIFIED_INSNS.
1130         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1131         (aarch64_displaced_step_copy_insn): Likewise.
1132         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1133         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1134         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1135         ARM_DISPLACED_MODIFIED_INSNS.
1136         * arm-tdep.c (arm_gdbarch_init): Likewise.
1137         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1138         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1139         (struct arm_displaced_step_closure): Use
1140         ARM_DISPLACED_MODIFIED_INSNS.
1141
1142 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1143
1144         * features/Makefile: Remove unused xml files.
1145         * features/aarch64.xml: Remove.
1146         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1147         * features/i386/amd64-avx-avx512.xml: Remove.
1148         * features/i386/amd64-avx-linux.xml: Remove.
1149         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1150         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1151         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1152         * features/i386/amd64-avx-mpx.xml: Remove.
1153         * features/i386/amd64-avx.xml: Remove.
1154         * features/i386/amd64-linux.xml: Remove.
1155         * features/i386/amd64-mpx-linux.xml: Remove.
1156         * features/i386/amd64-mpx.xml: Remove.
1157         * features/i386/amd64.xml: Remove.
1158         * features/i386/i386-avx-avx512-linux.xml: Remove.
1159         * features/i386/i386-avx-avx512.xml: Remove.
1160         * features/i386/i386-avx-linux.xml: Remove.
1161         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1162         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1163         * features/i386/i386-avx-mpx-linux.xml: Remove.
1164         * features/i386/i386-avx-mpx.xml: Remove.
1165         * features/i386/i386-avx.xml: Remove.
1166         * features/i386/i386-linux.xml: Remove.
1167         * features/i386/i386-mmx-linux.xml: Remove.
1168         * features/i386/i386-mmx.xml: Remove.
1169         * features/i386/i386-mpx-linux.xml: Remove.
1170         * features/i386/i386-mpx.xml: Remove.
1171         * features/i386/i386.xml: Remove.
1172         * features/i386/x32-avx-avx512-linux.xml: Remove.
1173         * features/i386/x32-avx-linux.xml: Remove.
1174         * features/i386/x32-linux.xml: Remove.
1175
1176 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1177
1178         * regformats/aarch64.dat: Remove.
1179         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1180         * regformats/i386/amd64-avx-linux.dat: Remove.
1181         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1182         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1183         * regformats/i386/amd64-linux.dat: Remove.
1184         * regformats/i386/amd64-mpx-linux.dat: Remove.
1185         * regformats/i386/amd64.dat: Remove.
1186         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1187         * regformats/i386/i386-avx-linux.dat: Remove.
1188         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1189         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1190         * regformats/i386/i386-linux.dat: Remove.
1191         * regformats/i386/i386-mmx-linux.dat: Remove.
1192         * regformats/i386/i386-mpx-linux.dat: Remove.
1193         * regformats/i386/i386.dat: Remove.
1194         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1195         * regformats/i386/x32-avx-linux.dat: Remove.
1196         * regformats/i386/x32-linux.dat: Remove.
1197
1198 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1199
1200         * aarch64-tdep.c: Remove xml self tests.
1201         * amd64-linux-tdep.c: Likewise.
1202         * amd64-tdep.c: Likewise.
1203         * i386-linux-tdep.c: Likewise.
1204         * i386-tdep.c: Likewise.
1205
1206 2019-07-03  Pedro Alves  <palves@redhat.com>
1207
1208         PR cli/24732
1209         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1210         (pipe_cmd_option_defs): New.
1211         (make_pipe_cmd_options_def_group): New.
1212         (pipe_command): Use gdb::option::process_options.
1213         (pipe_command_completer): New function.
1214         (_initialize_cli_cmds): Install completer for "pipe" command.
1215
1216 2019-07-03  Pedro Alves  <palves@redhat.com>
1217
1218         * cli/cli-option.c (union option_value) <string>: New field.
1219         (struct option_def_and_value): Add ctor, move ctor, dtor and
1220         use DISABLE_COPY_AND_ASSIGN.
1221         (option_def_and_value::clear_value): New.
1222         (parse_option, save_option_value_in_ctx, get_val_type_str)
1223         (add_setshow_cmds_for_options): Handle var_string.
1224         * cli-option.h (union option_def::var_address) <string>: New
1225         field.
1226         (struct string_option_def): New.
1227         * maint-test-options.c (struct test_options_opts): Add default
1228         ctor and use DISABLE_COPY_AND_ASSIGN.
1229         <string_opt>: New field.
1230         (test_options_opts::~test_options_opts): New.
1231         (test_options_opts::dump): Also dump "-string".
1232         (test_options_option_defs): Install "string.
1233
1234 2019-07-03  Pedro Alves  <palves@redhat.com>
1235
1236         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1237         option_value with a null enumeration.
1238         (complete_options): Save the option values in the context.
1239         (save_option_value_in_ctx): New, factored out from ...
1240         (process_options): ... here.
1241         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1242         of the function.
1243         * maint-test-options.c (test_options_opts::dump): New, factored
1244         out from ...
1245         (maintenance_test_options_command_mode): ... here.
1246         (maintenance_test_options_command_completion_result): Delete.
1247         (maintenance_test_options_command_completion_text): Update
1248         comment.
1249         (maintenance_show_test_options_completion_result): Change
1250         prototype.  Just print
1251         maintenance_test_options_command_completion_text.
1252         (save_completion_result): New.
1253         (maintenance_test_options_completer_mode): Pass options context to
1254         complete_options, and then save a dump.
1255         (_initialize_maint_test_options): Use add_cmd to install "maint
1256         show test-options-completion-result".
1257
1258 2019-07-03  Pedro Alves  <palves@redhat.com>
1259
1260         * NEWS (New commands): Mention "with" and "maint with".
1261         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1262         (with_command, with_command_completer): New.
1263         (pipe_command): Adjust to new repeat_previous
1264         interface.
1265         (_initialize_cli_cmds): Install the "with" command and its "w"
1266         alias.
1267         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1268         declarations.
1269         * cli/cli-setshow.c (parse_cli_var_uinteger)
1270         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1271         argument strings for all var_types.
1272         (get_setshow_command_value_string): New, factored out from ...
1273         (do_show_command): ... this.
1274         * cli/cli-setshow.h: Include <string>.
1275         (get_setshow_command_value_string): Declare.
1276         * command.h (repeat_previous): Now returns const char *.  Adjust
1277         comment.
1278         * maint.c: Include "cli/cli-cmds.h".
1279         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1280         (_initialize_maint_cmds): Register the "maintenance with" command.
1281         * top.c (repeat_previous): Move bits from pipe_command here:
1282         Return the saved command line, if any; error out if there's no
1283         command to relaunch.
1284
1285 2019-07-03  Pedro Alves  <palves@redhat.com>
1286
1287         * NEWS (New commands): Mention "maint set/show test-settings"
1288         instead of "maint test-settings".
1289         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1290         (maintenance_test_settings_set_list): Rename to ...
1291         (maintenance_set_test_settings_list): ... this.
1292         (maintenance_test_settings_show_list): Rename to  ...
1293         (maintenance_show_test_settings_list): ... this.
1294         (maintenance_test_settings_cmd): Delete.
1295         (maintenance_test_settings_set_cmd): ...
1296         (maintenance_set_test_settings_cmd): ... this.
1297         (maintenance_test_settings_show_cmd): ...
1298         (maintenance_show_test_settings_cmd): ... this.
1299         (maintenance_test_settings_show_value_cmd):
1300         (maintenance_show_test_settings_value_cmd): ... this.
1301         (_initialize_maint_test_settings): No longer install the "maint
1302         test-settings" prefix command.  Rename "maint test-settings set"
1303         to "maint set test-settings", and "maint test-settings show" to
1304         "maint show test-settings".  Adjust all subcommands.
1305
1306 2019-07-03  Pedro Alves  <palves@redhat.com>
1307
1308         * maint-test-settings.c: Fix file's intro comment.  Replace all
1309         references to "test-options" with references to "test-settings",
1310         in comments.
1311
1312 2019-07-03  Pedro Alves  <palves@redhat.com>
1313
1314         * maint-test-settings.c (maintenance_test_settings_xxx)
1315         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1316         New.
1317         (maintenance_test_settings_enums): Use them.
1318         (maintenance_test_settings_enum): Default to
1319         maintenance_test_settings_xxx.
1320         (_initialize_maint_test_settings): Initialize
1321         MAINTENANCE_TEST_SETTINGS_FILENAME.
1322
1323 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1324
1325         * breakpoint.h (remove_breakpoints_inf): Change return type to
1326         void, move function documentation here.
1327         * breakpoint.c (remove_breakpoints_inf): Change return type to
1328         void, move function documentation to header.
1329
1330 2019-07-02  Pedro Alves  <palves@redhat.com>
1331
1332         * NEWS (Completion improvements): Mention "info threads".
1333         * thread.c (struct info_threads_opts, info_threads_option_defs)
1334         (make_info_threads_options_def_group): New.
1335         (info_threads_command): Use gdb::option::process_options.
1336         (info_threads_command_completer): New.
1337         (_initialize_thread): Use gdb::option::build_help to build the
1338         help text for "info threads".
1339
1340 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1341
1342         * defs.h (generic_load): Move from here...
1343         * symfile.h (generic_load): ... to here.  Rename name parameter
1344         to args.
1345         * symfile.c (generic_load): Add comment.
1346
1347 2019-07-01  Tom Tromey  <tromey@adacore.com>
1348
1349         * dwarf2read.c
1350         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1351         declaration of without_params.  Fix formatting.
1352
1353 2019-07-01  Tom Tromey  <tromey@adacore.com>
1354
1355         * ada-exp.y (find_primitive_type): Update.
1356         * ada-lang.h (ada_lookup_symbol): Update.
1357         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1358         parameter.
1359         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1360
1361 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1362
1363         PR breakpoints/24541
1364         * gdbarch.c: Regenerate.
1365         * gdbarch.h: Regenerate.
1366         * gdbarch.sh: Add 'stap_adjust_register'.
1367         * i386-tdep.c: Include '<unordered_set>'.
1368         (i386_stap_adjust_register): New function.
1369         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1370         * stap-probe.c (stap_parse_register_operand): Call
1371         'gdbarch_stap_adjust_register'.
1372
1373 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1374
1375         PR python/24742
1376         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1377         * python/python.c (do_start_initialization): Use 'xmalloc'
1378         instead of 'PyMem_Malloc'.
1379
1380 2019-06-28  Tom Tromey  <tromey@adacore.com>
1381
1382         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1383         for Ada.
1384
1385 2019-06-27  Tom Tromey  <tromey@adacore.com>
1386
1387         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1388         objfile_key.
1389         (arm_find_mapping_symbol, arm_record_special_symbol)
1390         (_initialize_arm_tdep): Update.
1391         (arm_objfile_data_free): Remove.
1392
1393 2019-06-27  Tom Tromey  <tromey@adacore.com>
1394
1395         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1396         to cp_print_static_field.
1397
1398 2019-06-26  Tom Tromey  <tromey@adacore.com>
1399
1400         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1401         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1402         declare.
1403
1404 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1405
1406         * features/aarch64-core.c (create_feature_aarch64_core):
1407         Regenerate.
1408         * features/aarch64-core.xml: Add cpsr flags.
1409
1410 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1411
1412         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1413         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1414
1415 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1416
1417         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1418         field.
1419         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1420         use.
1421         (arm_record_special_symbol): Don't insert new symbol in sorted
1422         position, push it at the end.
1423
1424 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1425
1426         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1427         (arm_mapping_symbol_s): Remove.
1428         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1429         (arm_mapping_symbol_vec): New typedef.
1430         (struct arm_per_objfile): Add constructor.
1431         <section_maps>: Change type to
1432         std::unique_ptr<arm_mapping_symbol_vec[]>.
1433         (arm_compare_mapping_symbols): Remove.
1434         (arm_find_mapping_symbol): Adjust to section_maps type change.
1435         (arm_objfile_data_free): Call delete on arm_per_objfile.
1436         (arm_record_special_symbol): Adjust to section_maps type change.
1437         Allocate arm_per_objfile with new.
1438
1439 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1440
1441         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1442         with the command prefix.
1443
1444 2019-06-25  Tom Tromey  <tom@tromey.com>
1445
1446         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1447         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1448
1449 2019-06-25  Tom Tromey  <tom@tromey.com>
1450
1451         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1452         type.
1453         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1454         protected.
1455
1456 2019-06-25  Tom Tromey  <tom@tromey.com>
1457
1458         * tui/tui-winsource.c
1459         (tui_source_window_base::set_is_exec_point_at): Add check against
1460         LOA_ADDRESS.
1461
1462 2019-06-25  Tom Tromey  <tom@tromey.com>
1463
1464         * tui/tui-source.c (tui_set_source_content): Don't check before
1465         xfree.
1466         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1467
1468 2019-06-25  Tom Tromey  <tom@tromey.com>
1469
1470         * tui/tui-winsource.h (tui_update_source_window_as_is)
1471         (tui_alloc_source_buffer, tui_line_is_displayed)
1472         (tui_addr_is_displayed): Change type of win_info.
1473         * tui/tui-winsource.c (tui_update_source_window_as_is)
1474         (tui_clear_source_content, tui_show_source_line)
1475         (tui_show_source_content, tui_source_window_base::refill)
1476         (tui_source_window_base::set_is_exec_point_at)
1477         (tui_source_window_base::set_is_exec_point_at)
1478         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1479         (tui_alloc_source_buffer, tui_line_is_displayed)
1480         (tui_addr_is_displayed): Change type of win_info.  Update.
1481         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1482         (tui_source_window_base::do_make_visible_with_new_height):
1483         Update.
1484         * tui/tui-source.c (tui_set_source_content)
1485         (tui_set_source_content_nil)
1486         (tui_source_window::do_scroll_vertical): Update.
1487         * tui/tui-layout.c (show_layout): Update.
1488         * tui/tui-disasm.c (tui_set_disassem_content)
1489         (tui_disasm_window::do_scroll_vertical): Update.
1490         * tui/tui-data.h (tui_win_content): Remove.
1491         (struct tui_gen_win_info) <content, content_size>: Remove.
1492         (struct tui_source_element): Add initializers and destructor.
1493         (union tui_which_element, struct tui_win_element): Remove.
1494         (struct tui_source_window_base) <content>: New field.
1495         (struct tui_data_window): Remove destructor.
1496         (tui_alloc_content, tui_free_win_content)
1497         (tui_free_all_source_wins_content): Don't declare.
1498         * tui/tui-data.c (tui_initialize_static_data): Update.
1499         (init_content_element, tui_alloc_content): Remove.
1500         (~tui_gen_win_info): Update.
1501         (~tui_data_window, tui_free_all_source_wins_content)
1502         (tui_free_win_content, free_content, free_content_elements):
1503         Remove.
1504
1505 2019-06-25  Tom Tromey  <tom@tromey.com>
1506
1507         * tui/tui-winsource.h (tui_clear_source_content)
1508         (tui_erase_source_content, tui_show_source_content): Change type
1509         of win_info.
1510         * tui/tui-winsource.c (tui_clear_source_content)
1511         (tui_erase_source_content, tui_show_source_content): Change type
1512         of win_info.
1513         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1514         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1515         win_info.
1516         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1517         win_info.
1518         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1519
1520 2019-06-25  Tom Tromey  <tom@tromey.com>
1521
1522         * tui/tui-winsource.c (tui_clear_source_content)
1523         (tui_source_window_base::set_is_exec_point_at): Update.
1524         * tui/tui-source.c (tui_set_source_content_nil): Update.
1525         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1526         a bool.
1527         * tui/tui-data.c (init_content_element): Update.
1528
1529 2019-06-25  Tom Tromey  <tom@tromey.com>
1530
1531         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1532         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1533         * tui/tui-layout.c (init_and_make_win): Update.
1534         * tui/tui.h (enum tui_win_type): Update.
1535         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1536         tui_win_is_auxillary.
1537         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1538         tui_win_is_auxillary.
1539
1540 2019-06-25  Tom Tromey  <tom@tromey.com>
1541
1542         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1543         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1544         (tui_delete_data_content_windows, tui_display_all_data)
1545         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1546         Update.
1547         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1548         * tui/tui-regs.c (tui_last_regs_line_no)
1549         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1550         (tui_show_registers): Update.
1551         (tui_show_register_group): Return void.  Update.
1552         (tui_display_registers_from, tui_display_reg_element_at_line)
1553         (tui_display_registers_from_line, tui_check_register_values):
1554         Update.
1555         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1556         member.
1557         (struct tui_data_window) <regs_content>: Now a std::vector.
1558         <regs_content_count>: Remove.
1559         (tui_add_content_elements, tui_free_data_content): Don't declare.
1560         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1561         (init_content_element): Remove DATA_WIN case.  Add assert.
1562         (tui_add_content_elements): Remove.
1563         (tui_data_window): Update.
1564         (tui_free_data_content): Remove.
1565         (free_content_elements): Remove DATA_WIN case.
1566
1567 2019-06-25  Tom Tromey  <tom@tromey.com>
1568
1569         * tui/tui-data.c (tui_data_item_window): Update.
1570         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1571         * tui/tui-windata.c (tui_display_all_data)
1572         (tui_display_data_from_line): Update.
1573         (tui_check_data_values): Remove.
1574         * tui/tui-regs.c (tui_show_register_group)
1575         (tui_display_reg_element_at_line): Update.
1576         * tui/tui-hooks.c (tui_register_changed)
1577         (tui_refresh_frame_and_register_information): Call
1578         tui_check_register_values.
1579         * tui/tui-data.h (struct tui_data_window) <data_content,
1580         data_content_count, data_type>: Remove.
1581         (enum tui_data_type): Remove.
1582
1583         * tui/tui-data.c (tui_data_window::clear_detail)
1584         (~tui_data_window): Update.
1585
1586 2019-06-25  Tom Tromey  <tom@tromey.com>
1587
1588         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1589         declare.
1590         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1591         Rename from tui_first_data_item_displayed.  Update.
1592         (tui_data_window::refresh_all)
1593         (tui_data_window::do_scroll_vertical): Update.
1594         * tui/tui-data.h (struct tui_data_window)
1595         <first_data_item_displayed>: Declare new method.
1596
1597 2019-06-25  Tom Tromey  <tom@tromey.com>
1598
1599         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1600         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1601         contents...
1602         (tui_initialize_static_data): ...here.
1603
1604 2019-06-25  Tom Tromey  <tom@tromey.com>
1605
1606         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1607         (tui_display_registers_from, tui_check_register_values): Update.
1608         (tui_display_register): Remove win_info parameter; update.
1609         (tui_get_register): Change type of parameters.
1610         * tui/tui-data.h (struct tui_data_element): Remove.
1611         (union tui_which_element) <data>: Remove.
1612         <data_window>: Change type.
1613         (struct tui_data_item_window): New.
1614         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1615         case.  Add assert.
1616         (~tui_data_item_window): New destructor.
1617         (free_content_elements): Remove DATA_ITEM_WIN case.
1618
1619 2019-06-25  Tom Tromey  <tom@tromey.com>
1620
1621         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1622         Remove.
1623
1624 2019-06-25  Tom Tromey  <tom@tromey.com>
1625
1626         * tui/tui-data.h (struct tui_command_element): Remove.
1627         (union tui_which_element) <command>: Remove.
1628         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1629         assert.
1630         (free_content_elements): Remove CMD_WIN case.
1631
1632 2019-06-25  Tom Tromey  <tom@tromey.com>
1633
1634         * tui/tui-layout.c (tui_set_layout): Update.
1635         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1636         * tui/tui-data.c (layout_def): Update.
1637
1638 2019-06-25  Tom Tromey  <tom@tromey.com>
1639
1640         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1641         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1642         (tui_source_window_base::set_new_height): Update.
1643         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1644         Update.
1645         (tui_set_locator_fullname, tui_set_locator_info)
1646         (tui_show_frame_info): Update.
1647         * tui/tui-source.c (tui_set_source_content)
1648         (tui_source_is_displayed): Update.
1649         * tui/tui-layout.c (show_source_disasm_command, show_data)
1650         (show_source_or_disasm_and_command): Update.
1651         * tui/tui-disasm.c (tui_set_disassem_content)
1652         (tui_get_begin_asm_address): Update.
1653         * tui/tui-data.h (struct tui_locator_element): Remove.
1654         (union tui_which_element) <locator>: Remove.
1655         (struct tui_locator_window): New.
1656         (tui_locator_win_info_ptr): Change return type.
1657         * tui/tui-data.c (_locator): Change type.
1658         (tui_locator_win_info_ptr): Change return type.
1659         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1660         (tui_alloc_content): Add assert.
1661
1662 2019-06-25  Tom Tromey  <tom@tromey.com>
1663
1664         * tui/tui-winsource.c
1665         (tui_exec_info_window::maybe_allocate_content): New method.
1666         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1667         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1668         (make_source_or_disasm_window): Add cast.
1669         * tui/tui-data.h (union tui_which_element) <simple_string>:
1670         Remove.
1671         (struct tui_source_info): New.
1672         (struct tui_source_window_base) <execution_info>: Change type.
1673         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1674         case, and add assert.
1675         (tui_alloc_content): Add assert.
1676
1677 2019-06-25  Tom Tromey  <tom@tromey.com>
1678
1679         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1680         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1681         * tui/tui-data.c (tui_alloc_win_info): Remove.
1682
1683 2019-06-25  Tom Tromey  <tom@tromey.com>
1684
1685         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1686         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1687         can_highlight.
1688
1689 2019-06-25  Tom Tromey  <tom@tromey.com>
1690
1691         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1692         make_visible_with_new_height method.
1693         (tui_win_info::make_visible_with_new_height): New method.
1694         (tui_source_window_base::do_make_visible_with_new_height)
1695         (tui_data_window::do_make_visible_with_new_height)
1696         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1697         (make_visible_with_new_height): Remove.
1698         (tui_resize_all, tui_adjust_win_heights): Use
1699         make_visible_with_new_height method.
1700         * tui/tui-data.h (struct tui_win_info)
1701         <do_make_visible_with_new_height, make_visible_with_new_height>:
1702         New methods.
1703         (struct tui_source_window_base, struct tui_data_window)
1704         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1705         methods.
1706
1707 2019-06-25  Tom Tromey  <tom@tromey.com>
1708
1709         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1710         method.
1711         (update_tab_width): Call update_tab_width method.
1712         * tui/tui-data.h (struct tui_win_info)
1713         (struct tui_source_window_base) <update_tab_width>: New methods.
1714
1715 2019-06-25  Tom Tromey  <tom@tromey.com>
1716
1717         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1718         parameter.
1719         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1720         parameter.
1721         (tui_gen_win_info::make_visible): Update.
1722         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1723         parameter.
1724         * tui/tui-data.h (enum tui_box): New enum.
1725         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1726
1727 2019-06-25  Tom Tromey  <tom@tromey.com>
1728
1729         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1730         init_and_make_win for EXEC_INFO_WIN.
1731         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1732         longer inline.
1733         (struct tui_win_info) <~tui_win_info>: Inline.
1734         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1735         Don't declare.
1736         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1737         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1738         Remove.
1739         (tui_initialize_static_data): Update.
1740         (~tui_gen_win_info): Handle more cleanup here.
1741         (~tui_source_window_base): Delete "execution_info".
1742         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1743
1744 2019-06-25  Tom Tromey  <tom@tromey.com>
1745
1746         * tui/tui-layout.c (make_command_window): Don't set
1747         can_highlight.
1748         (show_source_disasm_command): Call the reset method.
1749         (show_data): Don't set can_highlight.  Call the reset method.
1750         (tui_gen_win_info::reset): Rename from init_gen_win_info
1751         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1752         (show_source_or_disasm_and_command): Call the reset method.
1753         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1754         (struct tui_cmd_window): Set can_highlight.
1755
1756 2019-06-25  Tom Tromey  <tom@tromey.com>
1757
1758         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1759         from make_visible.
1760         (tui_make_visible, tui_make_invisible): Rewrite.
1761         (tui_win_info::make_visible): Remove.
1762         (tui_source_window_base::make_visible): Update.
1763         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1764         method.  Moved from...
1765         (struct tui_win_info) <make_visible>: ...here.
1766
1767 2019-06-25  Tom Tromey  <tom@tromey.com>
1768
1769         * tui/tui-winsource.c
1770         (tui_source_window_base::do_scroll_horizontal): Remove direction
1771         parameter.
1772         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1773         direction parameter.
1774         * tui/tui-win.c (tui_win_info::forward_scroll)
1775         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1776         (tui_win_info::right_scroll): Update.
1777         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1778         direction parameter.
1779         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1780         direction parameter.
1781         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1782         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1783         Remove direction parameter.
1784         (struct tui_source_window_base, struct tui_source_window)
1785         (struct tui_disasm_window, struct tui_data_window)
1786         (struct tui_cmd_window): Update.
1787
1788 2019-06-25  Tom Tromey  <tom@tromey.com>
1789
1790         * tui/tui-winsource.h (tui_set_exec_info_content)
1791         (tui_show_exec_info_content, tui_erase_exec_info_content)
1792         (tui_clear_exec_info_content, tui_update_exec_info): Change
1793         argument to tui_source_window_base.
1794         * tui/tui-winsource.c (tui_set_exec_info_content)
1795         (tui_show_exec_info_content, tui_erase_exec_info_content)
1796         (tui_clear_exec_info_content, tui_update_exec_info): Change
1797         argument to tui_source_window_base.
1798
1799 2019-06-25  Tom Tromey  <tom@tromey.com>
1800
1801         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1802         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1803
1804 2019-06-25  Tom Tromey  <tom@tromey.com>
1805
1806         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1807         check.
1808
1809 2019-06-25  Tom Tromey  <tom@tromey.com>
1810
1811         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1812         type to void.
1813         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1814         type to void.
1815         * tui/tui-source.c (tui_set_source_content): Update.
1816         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1817
1818 2019-06-25  Tom Tromey  <tom@tromey.com>
1819
1820         * tui/tui-win.c (window_name_completer, tui_set_focus)
1821         (tui_all_windows_info): Use name method.
1822         * tui/tui-data.h (struct tui_gen_win_info)
1823         (struct tui_source_window, struct tui_disasm_window)
1824         (struct tui_data_window, struct tui_cmd_window) <name>: New
1825         method.
1826         (tui_win_name): Don't declare.
1827         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1828         (tui_win_name): Remove.
1829
1830 2019-06-25  Tom Tromey  <tom@tromey.com>
1831
1832         * tui/tui-winsource.h (tui_update_source_window)
1833         (tui_update_source_window_as_is): Change parameter type.
1834         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1835         to be a tui_source_window_base.
1836         (tui_update_source_window_as_is): Likewise.
1837         * tui/tui-win.c (make_visible_with_new_height): Update.
1838
1839 2019-06-25  Tom Tromey  <tom@tromey.com>
1840
1841         * tui/tui-winsource.c (tui_erase_source_content)
1842         (tui_show_source_content, tui_show_exec_info_content)
1843         (tui_erase_exec_info_content): Use refresh_window method.
1844         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1845         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1846         from tui_refresh_win.
1847         (tui_data_window::refresh_window): New method.
1848         (tui_win_info::refresh, tui_source_window_base::refresh)
1849         (tui_refresh_all): Use refresh_window method.
1850         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1851         method.
1852         * tui/tui-regs.c (tui_display_register): Call refresh_window
1853         method.
1854         * tui/tui-layout.c (show_source_disasm_command)
1855         (show_source_or_disasm_and_command): Call refresh_window method.
1856         * tui/tui-data.h (struct tui_gen_win_info)
1857         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1858         New method.
1859
1860 2019-06-25  Tom Tromey  <tom@tromey.com>
1861
1862         * tui/tui.c (tui_rl_other_window, tui_enable)
1863         (tui_is_window_visible, tui_get_command_dimension): Update.
1864         * tui/tui-winsource.c (tui_update_source_window_as_is)
1865         (tui_clear_source_content, tui_erase_source_content)
1866         (tui_show_source_line, tui_source_window_base::refill)
1867         (tui_source_window_base::do_scroll_horizontal)
1868         (tui_source_window_base::set_is_exec_point_at)
1869         (tui_update_breakpoint_info, tui_set_exec_info_content)
1870         (tui_alloc_source_buffer, tui_line_is_displayed)
1871         (tui_addr_is_displayed): Update.
1872         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1873         (tui_check_and_display_highlight_if_needed)
1874         (tui_win_info::make_visible, tui_win_info::refresh)
1875         (tui_refresh_all): Update.
1876         * tui/tui-windata.c (tui_first_data_item_displayed)
1877         (tui_delete_data_content_windows, tui_erase_data_content)
1878         (tui_display_all_data, tui_data_window::refresh_all)
1879         (tui_check_data_values): Update.
1880         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1881         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1882         (tui_win_info::backward_scroll, tui_refresh_all_win)
1883         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1884         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1885         (tui_source_window_base::set_new_height)
1886         (tui_data_window::set_new_height)
1887         (make_invisible_and_set_new_height)
1888         (make_visible_with_new_height, new_height_ok)
1889         (parse_scrolling_args): Update.
1890         * tui/tui-stack.c (tui_show_frame_info): Update.
1891         * tui/tui-source.c (tui_set_source_content)
1892         (tui_set_source_content_nil, tui_source_is_displayed)
1893         (tui_source_window::do_scroll_vertical): Update.
1894         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1895         (tui_display_registers_from, tui_display_reg_element_at_line)
1896         (tui_check_register_values, tui_reg_command): Update.
1897         * tui/tui-layout.c (tui_default_win_height)
1898         (show_source_disasm_command, show_data, init_and_make_win)
1899         (show_source_or_disasm_and_command): Update.
1900         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1901         (tui_redisplay_readline, tui_mld_flush)
1902         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1903         (tui_getc): Update.
1904         * tui/tui-disasm.c (tui_set_disassem_content)
1905         (tui_disasm_window::do_scroll_vertical): Update.
1906         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1907         Now virtual.
1908         (struct tui_win_info): Derive from tui_gen_win_info.
1909         <~tui_win_info>: Mark as override.
1910         <generic>: Remove member.
1911         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1912         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1913         (~tui_data_window, ~tui_win_info)
1914         (tui_free_all_source_wins_content): Update.
1915         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1916
1917 2019-06-25  Tom Tromey  <tom@tromey.com>
1918
1919         * tui/tui-layout.c (init_and_make_win): Use new.
1920         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1921         destructor, initializers.
1922         (tui_alloc_generic_win_info): Don't declare.
1923         * tui/tui-data.c (_locator): Add argument to constructor.
1924         (source_win, disasm_win): New globals.
1925         (exec_info): Remove.
1926         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1927         Update.
1928         (tui_alloc_generic_win_info): Remove.
1929         (init_content_element): Use new.
1930         (tui_win_info::tui_win_info): Update.
1931         (free_content_elements) <case DATA_WIN>: Use delete.
1932
1933 2019-06-25  Tom Tromey  <tom@tromey.com>
1934
1935         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1936         * tui/tui-windata.c (tui_first_data_item_displayed)
1937         (tui_delete_data_content_windows): Update.
1938         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1939         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1940         (tui_display_registers_from, tui_check_register_values): Update.
1941         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1942         pointer.
1943         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1944         window.
1945         (tui_free_data_content): Update.
1946         (free_content_elements) <case DATA_WIN>: Free the window.
1947
1948 2019-06-25  Tom Tromey  <tom@tromey.com>
1949
1950         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1951         Update.
1952         * tui/tui-layout.c (make_command_window)
1953         (show_source_disasm_command, show_data, init_and_make_win)
1954         (show_source_or_disasm_and_command): Update.
1955         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1956         method.
1957         <can_highight, is_highlighted>: Now bool.
1958         (tui_set_win_highlight): Don't declare.
1959         * tui/tui-data.c (tui_set_win_highlight): Remove.
1960
1961 2019-06-25  Tom Tromey  <tom@tromey.com>
1962
1963         * tui/tui-wingeneral.c (make_visible): Remove check of window
1964         type.
1965
1966 2019-06-25  Tom Tromey  <tom@tromey.com>
1967
1968         * tui/tui-win.c (tui_win_info::max_height)
1969         (tui_cmd_window::max_height): New methods.
1970         (new_height_ok): Call max_height.
1971         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1972         <max_height>: New method.
1973
1974 2019-06-25  Tom Tromey  <tom@tromey.com>
1975
1976         * tui/tui-win.c (tui_source_window_base::set_new_height)
1977         (tui_data_window::set_new_height): New methods.
1978         (make_invisible_and_set_new_height): Call set_new_height method.
1979         * tui/tui-data.h (struct tui_win_info)
1980         (struct tui_source_window_base, struct tui_data_window)
1981         <set_new_height>: New method.
1982
1983 2019-06-25  Tom Tromey  <tom@tromey.com>
1984
1985         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1986         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1987         tui_refresh_data_win.
1988         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1989         method.
1990         (tui_refresh_all_win): Call the refresh_all method.
1991         (tui_set_focus): Likewise.
1992         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1993         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1994         Likewise.
1995
1996 2019-06-25  Tom Tromey  <tom@tromey.com>
1997
1998         * tui/tui-winsource.h (tui_refill_source_window)
1999         (tui_set_is_exec_point_at): Don't declare.
2000         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2001         (tui_source_window_base::refill): Rename from
2002         tui_refill_source_window.
2003         (tui_source_window_base::do_scroll_horizontal): Update.
2004         (tui_source_window_base::set_is_exec_point_at): Rename from
2005         tui_set_is_exec_point_at.
2006         (tui_update_all_breakpoint_info): Update.
2007         * tui/tui-stack.c (tui_show_frame_info): Update.
2008         * tui/tui-layout.c (show_data): Add cast.
2009         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2010         * tui/tui-data.h (struct tui_source_window_base) <refill,
2011         set_is_exec_point_at>: New methods.
2012         (tui_source_windows, tui_add_to_source_windows): Update types.
2013         (tui_add_to_source_windows): Remove redundant declaration.
2014         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2015         (tui_source_windows): Change return type.
2016         (tui_clear_source_windows_detail): Update.
2017         (tui_add_to_source_windows): Change type of parameter.
2018         (tui_free_all_source_wins_content): Update.
2019
2020 2019-06-25  Tom Tromey  <tom@tromey.com>
2021
2022         * tui/tui-wingeneral.c (tui_win_info::refresh)
2023         (tui_source_window_base::refresh): New methods.
2024         (tui_refresh_all): Call the refresh method.
2025         * tui/tui-data.h (struct tui_win_info)
2026         (struct tui_source_window_base) <refresh>: New method.
2027
2028 2019-06-25  Tom Tromey  <tom@tromey.com>
2029
2030         * tui/tui.h (tui_is_window_visible): Return bool.
2031         * tui/tui.c (tui_is_window_visible): Return bool.
2032         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2033         (tui_make_visible, tui_make_invisible)
2034         (tui_win_info::make_visible)
2035         (tui_source_window_base::make_visible, make_all_visible)
2036         (tui_make_all_visible, tui_make_all_invisible): Update.
2037         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2038         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2039         bool.
2040         (struct tui_win_info, struct tui_source_window_base)
2041         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2042         * tui/tui-data.c (tui_init_generic_part): Update.
2043
2044 2019-06-25  Tom Tromey  <tom@tromey.com>
2045
2046         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2047         (tui_source_window_base::make_visible): New methods.
2048         (make_all_visible): Make method call.
2049         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2050         (struct tui_source_window_base, struct tui_cmd_window): Override
2051         make_visible.
2052         (tui_win_is_source_type): Don't declare.
2053         * tui/tui-data.c (tui_win_is_source_type): Remove.
2054
2055 2019-06-25  Tom Tromey  <tom@tromey.com>
2056
2057         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2058         NULL check.
2059
2060 2019-06-25  Tom Tromey  <tom@tromey.com>
2061
2062         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2063         Inline constructor.  Add initializers for members.
2064         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2065         constructors; now inline in class.
2066
2067 2019-06-25  Tom Tromey  <tom@tromey.com>
2068
2069         * tui/tui-regs.c (tui_show_registers): Update.
2070         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2071         bool.
2072         * tui/tui-data.c (tui_data_window::clear_detail)
2073         (tui_data_window): Update.
2074
2075 2019-06-25  Tom Tromey  <tom@tromey.com>
2076
2077         * tui/tui-windata.c (tui_display_all_data)
2078         (tui_display_data_from_line, tui_display_data_from)
2079         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2080         Update.
2081         * tui/tui-regs.c (tui_last_regs_line_no)
2082         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2083         (tui_show_registers, tui_show_register_group)
2084         (tui_display_registers_from, tui_display_reg_element_at_line)
2085         (tui_display_registers_from_line, tui_check_register_values)
2086         (tui_reg_next, tui_reg_prev): Update.
2087         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2088         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2089         tui_data_window.
2090         (struct tui_win_info) <detail>: Remove.  Add new fields from
2091         tui_data_info.
2092         (TUI_DATA_WIN): Add cast.
2093         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2094         (~tui_data_window): Simplify.
2095
2096 2019-06-25  Tom Tromey  <tom@tromey.com>
2097
2098         * tui/tui-layout.c (show_source_disasm_command)
2099         (show_source_or_disasm_and_command): Update.
2100         * tui/tui-io.c (update_cmdwin_start_line)
2101         (tui_redisplay_readline): Update.
2102         * tui/tui-data.h (struct tui_command_info): Remove.
2103         (struct tui_win_info) <detail>: Remove command_info member.
2104         (struct tui_data_window) <start_line>: New member, from
2105         tui_command_info.
2106         (TUI_CMD_WIN): Add casts.
2107
2108 2019-06-25  Tom Tromey  <tom@tromey.com>
2109
2110         * tui/tui-winsource.c (tui_update_source_window)
2111         (tui_refill_source_window)
2112         (tui_source_window_base::do_scroll_horizontal)
2113         (tui_update_breakpoint_info, tui_set_exec_info_content)
2114         (tui_show_exec_info_content, tui_erase_exec_info_content)
2115         (tui_clear_exec_info_content): Update.
2116         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2117         Update.
2118         * tui/tui-win.c (make_invisible_and_set_new_height)
2119         (make_visible_with_new_height): Update.
2120         * tui/tui-source.c (tui_set_source_content)
2121         (tui_show_symtab_source): Update.
2122         * tui/tui-layout.c (extract_display_start_addr)
2123         (show_source_disasm_command, show_data)
2124         (make_source_or_disasm_window)
2125         (show_source_or_disasm_and_command): Update.
2126         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2127         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2128         "gdbarch".
2129         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2130         to tui_source_window_base.
2131         (struct tui_win_info) <detail>: Remove source_info member.
2132         (struct tui_source_window_base) <has_locator>: Inline.
2133         Move contents from tui_source_info; rename has_locator member to
2134         m_has_locator.
2135         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2136         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2137         header file.
2138         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2139         Simplify.
2140         (tui_free_all_source_wins_content): Cast to
2141         tui_source_window_base.
2142
2143 2019-06-25  Tom Tromey  <tom@tromey.com>
2144
2145         * tui/tui-win.c (make_invisible_and_set_new_height)
2146         (make_visible_with_new_height): Call has_locator method.
2147         * tui/tui-layout.c (show_source_disasm_command, show_data)
2148         (show_source_or_disasm_and_command): Update for bool change.
2149         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2150         (tui_win_info) <has_locator>: New method.
2151         (struct tui_source_window_base) <has_locator>: New method.
2152         (tui_win_has_locator): Don't declare.
2153         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2154         from tui_win_has_locator.
2155         (tui_source_window_base): Use false, not FALSE.
2156
2157 2019-06-25  Tom Tromey  <tom@tromey.com>
2158
2159         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2160         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2161         clear_detail method directly.
2162         (tui_clear_win_detail): Remove.
2163
2164 2019-06-25  Tom Tromey  <tom@tromey.com>
2165
2166         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2167         "this", not TUI_DISASM_WIN.
2168
2169 2019-06-25  Tom Tromey  <tom@tromey.com>
2170
2171         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2172         declare.
2173         * tui/tui-winsource.c
2174         (tui_source_window_base::do_scroll_horizontal): Rename from
2175         tui_horizontal_source_scroll.
2176         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2177         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2178         from tui_vertical_data_scroll.
2179         * tui/tui-win.h (tui_scroll): Don't declare.
2180         * tui/tui-win.c (tui_win_info::forward_scroll)
2181         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2182         (tui_win_info::right_scroll): Rename and update.
2183         (tui_scroll_forward_command, tui_scroll_backward_command)
2184         (tui_scroll_left_command, tui_scroll_right_command): Update.
2185         (tui_scroll): Remove.
2186         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2187         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2188         from tui_vertical_source_scroll.
2189         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2190         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2191         from tui_vertical_disassem_scroll.
2192         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2193         do_scroll_horizontal>: New methods.
2194         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2195         Likewise.
2196         (struct tui_source_window_base): Add do_scroll_horizontal.
2197         (struct tui_source_window, struct tui_disasm_window): Add
2198         do_scroll_vertical.
2199         (struct tui_data_window, struct tui_cmd_window): Add
2200         do_scroll_horizontal and do_scroll_vertical.
2201         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2202
2203 2019-06-25  Tom Tromey  <tom@tromey.com>
2204
2205         * tui/tui-data.h (struct tui_source_window_base): New struct.
2206         (struct tui_source_window): Derive from tui_source_window_base.
2207         (struct tui_disasm_window): New struct.
2208         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2209         from tui_source_window::clear_detail.
2210         (tui_source_window_base): Rename from tui_source_window.
2211         (~tui_source_window_base): Rename from ~tui_source_window.
2212         (tui_alloc_win_info): Create a tui_disasm_window.
2213
2214 2019-06-25  Tom Tromey  <tom@tromey.com>
2215
2216         * tui/tui-data.h (struct tui_source_window)
2217         (struct tui_data_window): Declare destructors.
2218         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2219         destructors.
2220         (tui_win_info): Simplify.
2221
2222 2019-06-25  Tom Tromey  <tom@tromey.com>
2223
2224         * tui/tui-winsource.c (tui_display_main)
2225         (tui_update_source_windows_with_addr)
2226         (tui_update_all_breakpoint_info): Update.
2227         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2228         (new_height_ok, parse_scrolling_args): Update.
2229         * tui/tui-stack.c (tui_show_frame_info): Update.
2230         * tui/tui-data.h (struct tui_list): Remove.
2231         (tui_source_windows): Return a reference to a std::vector.
2232         * tui/tui-data.c (source_windows): Now a std::vector.
2233         (tui_source_windows): Change return type.
2234         (tui_clear_source_windows): Rewrite.
2235         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2236         (tui_free_all_source_wins_content): Rewrite.
2237
2238 2019-06-25  Tom Tromey  <tom@tromey.com>
2239
2240         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2241         (struct tui_data_window, struct tui_cmd_window): Declare
2242         clear_detail method.
2243         * tui/tui-data.c (tui_source_window::clear_detail)
2244         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2245         methods.
2246         (tui_clear_win_detail): Simplify.
2247
2248 2019-06-25  Tom Tromey  <tom@tromey.com>
2249
2250         * tui/tui-layout.c (make_source_window, make_disasm_window)
2251         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2252         Return the new window.
2253         (show_source_disasm_command, show_data)
2254         (show_source_or_disasm_and_command): Update.
2255
2256 2019-06-25  Tom Tromey  <tom@tromey.com>
2257
2258         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2259         parameter.  Return the new window.
2260         (show_source_disasm_command): Update and remove NULL check.
2261         (show_source_or_disasm_and_command): Update.
2262
2263 2019-06-25  Tom Tromey  <tom@tromey.com>
2264
2265         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2266
2267 2019-06-25  Tom Tromey  <tom@tromey.com>
2268
2269         * tui/tui-data.h (struct tui_win_info): Make constructor
2270         protected.  Make destructor virtual.  Add initializers.
2271         (tui_source_window, tui_data_window, tui_cmd_window): New
2272         classes.
2273         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2274         constructor.  Add "type" parameter.
2275         (tui_source_window, tui_data_window, tui_cmd_window): New
2276         constructors.
2277         (tui_alloc_win_info): Instantiate the appropriate subclass.
2278
2279 2019-06-25  Tom Tromey  <tom@tromey.com>
2280
2281         * tui/tui-win.c (tui_resize_all): Use delete.
2282         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2283         destructor.
2284         (tui_free_window): Don't declare.
2285         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2286         Update.
2287
2288 2019-06-25  Tom Tromey  <tom@tromey.com>
2289
2290         * tui/tui-data.h (struct tui_win_info): Add constructor.
2291         * tui/tui-data.c (tui_alloc_win_info): Use new.
2292         (tui_free_window): Use delete.
2293
2294 2019-06-22  Tom Tromey  <tom@tromey.com>
2295
2296         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2297         declare.
2298         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2299
2300 2019-06-22  Tom Tromey  <tom@tromey.com>
2301
2302         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2303         declare.
2304         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2305
2306 2019-06-22  Tom de Vries  <tdevries@suse.de>
2307
2308         * dwarf2read.c (create_addrmap_from_aranges)
2309         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2310         instead of '%zu'.
2311
2312 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2313
2314         * dwarf2read.h (dwarf2_section_info_def): Remove.
2315         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2316         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2317         std::vector<dwarf2_section_info>.
2318         (struct dwo_file) <~dwo_file>: Remove.
2319         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2320         types field.
2321         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2322         (dwarf2_read_debug_names): Likewise.
2323         (create_debug_types_hash_table): Change parameter type to
2324         array_view, adjust code accordingly.
2325         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2326         (partial_die_info::fixup): Likewise.
2327         (determine_prefix): Likewise.
2328         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2329
2330 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2331
2332         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2333         gdb_bfd_ref_ptr.
2334         <~dwo_file>: Remove call to gdb_bfd_unref.
2335         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2336         gdb_bfd_ref_ptr::get.
2337
2338 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2339
2340         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2341         type to htab_up.
2342         * dwarf2read.c (struct dwo_file): Initialize fields.
2343         <~dwo_file>: New.
2344         (free_dwo_file): Remove, move content to ~dwo_file.
2345         (struct dwo_file_deleter): Remove.
2346         (dwo_file_up>: Remove custom deleter.
2347         (free_dwo_files): Remove.
2348         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2349         dwo_files.
2350         (process_skeletonless_type_units): Call unique_ptr::get.
2351         (allocate_dwo_file_hash_table): Add deleter to created hash
2352         table.  Change return type to htab_up.
2353         (lookup_dwo_file_slot): Don't memset dwo_file, call
2354         unique_ptr::get.
2355         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2356         (create_dwo_unit_in_dwp_v2): Likewise.
2357         (open_and_init_dwo_file): Likewise.
2358         (free_dwo_file_from_slot): Remove.
2359
2360 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2361
2362         * dwarf2read.h (struct dwarf2_section_info) <readin,
2363         is_virtual>: Change type to bool.
2364         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2365         true instead of 1.
2366
2367 2019-06-19  Tom Tromey  <tom@tromey.com>
2368
2369         * tui/tui-data.h (tui_init_content_element): Don't declare.
2370
2371 2019-06-19  Tom Tromey  <tom@tromey.com>
2372
2373         * tui/tui-data.h (tui_init_win_info): Don't declare.
2374
2375 2019-06-19  Tom de Vries  <tdevries@suse.de>
2376
2377         * dwarf2read.h (abstract_to_concrete): Change type to
2378         std::unordered_map<sect_offset, std::vector<sect_offset>,
2379         gdb::hash_enum<sect_offset>>.
2380
2381 2019-06-19  Tom Tromey  <tromey@adacore.com>
2382
2383         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2384         EVAL_AVOID_SIDE_EFFECTS specially.
2385
2386 2019-06-19  Tom Tromey  <tromey@adacore.com>
2387
2388         * source-cache.c (highlighter): New global.
2389         (source_cache::get_source_lines): Create a highlighter on demand.
2390
2391 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2392
2393         * defs.h (deprecated_interactive_hook): Delete declaration.
2394         * interps.c (clear_interpreter_hooks): Remove use of
2395         deprecated_interactive_hook.
2396         * top.c (deprecated_interactive_hook): Delete definition.
2397         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2398
2399 2019-06-18  Tom de Vries  <tdevries@suse.de>
2400
2401         PR gdb/24515
2402         * dwarf2read.h (abstract_to_concrete): Change type from
2403         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2404         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2405         * dwarf2read.c (read_variable): Update.
2406         (dwarf2_fetch_die_loc_sect_off): Update.
2407
2408 2019-06-17  Tom de Vries  <tdevries@suse.de>
2409
2410         PR gdb/24617
2411         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2412         accessing parent[parent_len - 1].
2413
2414 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2415
2416         PR gdb/24364
2417         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2418         call dtrace_process_dof with NULL dof.
2419
2420 2019-06-16  Tom de Vries  <tdevries@suse.de>
2421
2422         PR gdb/24445
2423         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2424
2425 2019-06-16  Tom Tromey  <tom@tromey.com>
2426
2427         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2428         (make_all_visible): Use address of member.
2429
2430 2019-06-16  Tom Tromey  <tom@tromey.com>
2431
2432         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2433         (tui_free_window, free_content, free_content_elements): Remove
2434         unnecessary cast.
2435         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2436         cast.
2437         * tui/tui-regs.c (tui_show_register_group)
2438         (tui_display_registers_from, tui_display_reg_element_at_line):
2439         Remove unnecessary cast.
2440
2441 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2442
2443         * linux-nat.c (normal_mask): Delete.
2444         (_initialize_linux_nat): Don't initialise normal_mask.
2445
2446 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2447
2448         PR gdb/24445
2449         * dwarf-index-write.h (write_psymtabs_to_index): Add
2450         dwz_basename parameter.
2451         * dwarf-index-write.c (write_gdbindex): Move file writing to
2452         write_gdbindex_1.  Change return type void.
2453         (assert_file_size): Move up, remove filename parameter.
2454         (write_gdbindex_1): New function.
2455         (write_debug_names): Change return type to void, call
2456         assert_file_size.
2457         (struct index_wip_file): New struct.
2458         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2459         file logic to index_wip_file.  Write index for dwz file if
2460         needed.
2461         (save_gdb_index_command): Pass basename of dwz file, if present.
2462         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2463         build-id of dwz file, if present.
2464         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2465         (dwarf2_get_dwz_file): Likewise.
2466         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2467         (dwarf2_get_dwz_file): Likewise.
2468
2469 2019-06-16  Tom Tromey  <tom@tromey.com>
2470
2471         * coffread.c (process_coff_symbol): Use xstrdup.
2472         * value.c (create_internalvar): Use xstrdup.
2473
2474 2019-06-16  Tom Tromey  <tom@tromey.com>
2475
2476         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2477         * breakpoint.c (stopin_command, stopat_command)
2478         (until_break_command, decode_location_default): Remove unnecessary
2479         cast.
2480         * utils.c (subset_compare): Remove unnecessary cast.
2481         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2482         cast.
2483         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2484         cast.
2485         * infcmd.c (path_command): Remove unnecessary cast.
2486         * coffread.c (decode_type): Remove unnecessary cast.
2487         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2488         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2489         * tui/tui-stack.c (tui_show_locator_content)
2490         (tui_show_frame_info): Remove unnecessary cast.
2491         * tui/tui-win.c (tui_scroll_forward_command)
2492         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2493         (parse_scrolling_args): Remove unnecessary cast.
2494         * tui/tui-data.c (init_win_info, tui_del_window)
2495         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2496         (free_content_elements): Remove unnecessary cast.
2497         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2498         unnecessary cast.
2499         * tui/tui-source.c (tui_set_source_content)
2500         (tui_vertical_source_scroll): Remove unnecessary cast.
2501         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2502         cast.
2503         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2504         * tui/tui-regs.c (tui_display_registers_from)
2505         (tui_display_register): Remove unnecessary cast.
2506         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2507         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2508         (make_visible): Remove unnecessary cast.
2509         * tui/tui-winsource.c (tui_erase_source_content)
2510         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2511         unnecessary cast.
2512         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2513         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2514         * stabsread.c (read_type, read_array_type, read_range_type):
2515         Remove unnecessary cast.
2516         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2517         (parse_symbol, parse_type, upgrade_type, parse_external)
2518         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2519         unnecessary cast.
2520         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2521
2522 2019-06-16  Tom Tromey  <tom@tromey.com>
2523
2524         * tui/tui-data.c (tui_alloc_generic_win_info)
2525         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2526         checks.
2527
2528 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2529             Andrew Burgess  <andrew.burgess@embecosm.com>
2530
2531         * f-typeprint.c (f_print_type): Don't return early for not
2532         associated or not allocated types.
2533         (f_type_print_varspec_suffix): Add print_rank parameter and print
2534         ranks of array types in case they dangling.
2535         (f_type_print_base): Add print_rank parameter.
2536
2537 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2538
2539         * NEWS: Mention new MI commands.
2540         * break-catch-throw.c (enum exception_event_kind): Move to
2541         breakpoint.h.
2542         (print_mention_exception_catchpoint): Output text as a single
2543         message.
2544         (catch_exception_command_1): Rename to...
2545         (catch_exception_event): ...this, make non-static, update header
2546         command, and change some parameter types.
2547         (catch_catch_command): Update for changes to
2548         catch_exception_command_1.
2549         (catch_throw_command): Likewise.
2550         (catch_rethrow_command): Likewise.
2551         * breakpoint.c (enum exception_event_kind): Delete.
2552         * breakpoint.h (enum exception_event_kind): Moved here from
2553         break-catch-throw.c.
2554         (catch_exception_event): Declare.
2555         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2556         (mi_cmd_catch_throw): New function.
2557         (mi_cmd_catch_rethrow): New function.
2558         (mi_cmd_catch_catch): New function.
2559         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2560         'catch-catch' entries.
2561         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2562         (mi_cmd_catch_rethrow): Declare.
2563         (mi_cmd_catch_catch): Declare.
2564
2565 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2566
2567         * annotate.c (annotate_source_line): Change return type to void,
2568         update implementation to match.
2569         * annotate.h (annotate_source_line): Change return type to void,
2570         update header comment.
2571         * stack.c (print_frame_info): Don't change what frame information
2572         is printed based on whether annotations are on or not.
2573
2574 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2575
2576         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2577         (annotate_source): Make static.
2578         (annotate_source_line): Moved from source.c and renamed from
2579         identify_source_line.  Update the return type.
2580         * annotate.h (annotate_source): Delete declaration.
2581         (annotate_source_line): Declaration moved from source.h, and
2582         renamed from identify_source_line.  Return type updated.
2583         * source.c (identify_source_line): Moved to annotate.c and renamed
2584         to annotate_source_line.
2585         (info_line_command): Remove check of annotation_level.
2586         * source.h (identify_source_line): Move declaration to annotate.h
2587         and rename to annotate_source_line.
2588         * stack.c: Add 'annotate.h' include.
2589         (print_frame_info): Remove check of annotation_level before
2590         calling annotate_source_line.
2591
2592 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2593
2594         * source-cache.c (source_cache::get_plain_source_lines): Use
2595         open_source_file_with_line_charpos instead of just
2596         open_source_file, remove call to find_source_lines.
2597         (source_cache::get_source_lines): Likewise.
2598         * source.c (find_source_lines): Make static.
2599         (get_filename_and_charpos): Renamed into...
2600         (open_source_file_with_line_charpos): ..this along with changes to
2601         return a scoped_fd, and some other minor clean ups.
2602         (identify_source_line): Use open_source_file_with_line_charpos.
2603         (search_command_helper): Use open_source_file_with_line_charpos
2604         instead of just open_source_file, remove call to
2605         find_source_lines.
2606         * source.h (open_source_file_with_line_charpos): Declare new
2607         function.
2608         (find_source_lines): Delete declaration.
2609
2610 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2611
2612         * source.c (get_filename_and_charpos): Remove fullname
2613         parameter.
2614         (identify_source_line): Update call to get_filename_and_charpos.
2615
2616 2019-06-14  Tom Tromey  <tromey@adacore.com>
2617
2618         PR gdb/24502:
2619         * ui-style.h (skip_ansi_escape): Update comment.
2620         * ui-file.h (class no_terminal_escape_file): New class.
2621         * ui-file.c (no_terminal_escape_file::write)
2622         (no_terminal_escape_file::puts): New methods.
2623         * cli/cli-logging.c (handle_redirections): Use
2624         no_terminal_escape_file.
2625
2626 2019-06-14  Tom Tromey  <tromey@adacore.com>
2627
2628         * NEWS: Move convenience variable news above Python news.
2629
2630 2019-06-14  Tom Tromey  <tom@tromey.com>
2631
2632         * gnulib: Move directory to top-level.
2633         * configure.ac: Don't configure gnulib.
2634         * configure: Rebuild.
2635         * common/common-defs.h: Use new path to gnulib.
2636         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2637         (GNULIB_H): Remove.
2638         (INCGNU): Look in new gnulib location.
2639         (HFILES_NO_SRCDIR): Remove gnulib files.
2640         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2641         (generated_files): Remove GNULIB_H.
2642         ($(LIBGNU), all-lib): Remove targets.
2643         (distclean): Don't mention GNULIB_BUILDDIR.
2644         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2645
2646 2019-06-14  Tom Tromey  <tromey@adacore.com>
2647
2648         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2649         Warn if symbol file does not provide any symbols.
2650
2651 2019-06-14  Tom Tromey  <tromey@adacore.com>
2652
2653         * source.c (find_and_open_source): Respect basenames_may_differ.
2654
2655 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2656
2657         * annotate.c (annotate_breakpoints_invalid): Make use of
2658         scoped_restore_terminal_state.
2659         (annotate_frames_invalid): Likewise.
2660
2661 2019-06-14  Tom Tromey  <tromey@adacore.com>
2662
2663         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2664         allow assignment to an internalvar.
2665
2666 2019-06-14  Tom Tromey  <tromey@adacore.com>
2667
2668         * ada-lex.l: Allow "_" in attribute names.
2669
2670 2019-06-14  Tom Tromey  <tromey@adacore.com>
2671
2672         PR gdb/24653:
2673         * regcache.c (registers_changed): Don't call alloca.
2674         * top.c (execute_command): Don't call alloca.
2675
2676 2019-06-13  Pedro Alves  <palves@redhat.com>
2677
2678         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2679         'expression'.  When parsing an expression, error out if there's
2680         junk after "unlimited".
2681         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2682         (do_set_command): Adjust calls to is_unlimited_literal.
2683
2684 2019-06-13  Pedro Alves  <palves@redhat.com>
2685
2686         * compile/compile.c (make_compile_options_def_group): Add braces
2687         around array_view initializer.
2688         * thread.c (make_thread_apply_all_options_def_group)
2689         (make_thread_apply_all_options_def_group): Likewise.
2690
2691 2019-06-13  Pedro Alves  <palves@redhat.com>
2692
2693         * NEWS (New commands): Mention "maint test-options
2694         require-delimiter", "maint test-options unknown-is-error", "maint
2695         test-options unknown-is-operand" and "maint show
2696         test-options-completion-result".
2697         (New command options, command completion): New section.
2698         (Completion improvements): New section.
2699         Mention that you can abbreviate "unlimited".
2700
2701 2019-06-13  Pedro Alves  <palves@redhat.com>
2702
2703         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2704         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2705         * unittests/cli-utils-selftests.c (test_parse_flags)
2706         (test_parse_flags_qcs): Delete.
2707         (test_cli_utils): Don't call deleted functions.
2708
2709 2019-06-13  Pedro Alves  <palves@redhat.com>
2710
2711         * thread.c: Include "cli/cli-option.h".
2712         (tp_array_compar_ascending): Global.
2713         (tp_array_compar): Delete function.
2714         (tp_array_compar_ascending, tp_array_compar_descending): New
2715         functions.
2716         (ascending_option_def, qcs_flag_option_def)
2717         (thr_qcs_flags_option_defs)
2718         (make_thread_apply_all_options_def_group)
2719         (make_thread_apply_options_def_group): New.
2720         (thread_apply_all_command): Use gdb::option::process_options.
2721         (thread_apply_command_completer)
2722         (thread_apply_all_command_completer): New.
2723         (thread_apply_command): Use gdb::option::process_options.
2724         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2725         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2726         to generate help text of "thread apply".  Adjust "taas"'s help.
2727         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2728         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2729
2730 2019-06-13  Pedro Alves  <palves@redhat.com>
2731
2732         * thread.c (thread_apply_command): Check for invalid TID with
2733         isdigit instead of !isalpha.
2734
2735 2019-06-13  Pedro Alves  <palves@redhat.com>
2736
2737         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2738         (validate_flags_qcs): New.
2739         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2740         (validate_flags_qcs): Declare.
2741         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2742         (make_frame_apply_options_def_group): New.
2743         (frame_apply_command_count): Process options with
2744         gdb::option::process_options.
2745         (frame_apply_completer): New.
2746         (frame_apply_level_completer, frame_apply_all_completer)
2747         (frame_apply_completer): New.
2748         (_initialize_stack): Update help of "frame apply", "frame apply
2749         level", "frame apply all" and "faas" to mention supported options
2750         and install command completers.
2751         * stack.h (frame_apply_all_completer): Declare.
2752         * thread.c: Include "stack.h".
2753         (tfaas_command): Add "--".
2754         (_initialize_thread): Update help "tfaas" to mention supported
2755         options and install command completer.
2756
2757 2019-06-13  Pedro Alves  <palves@redhat.com>
2758
2759         * completer.c (complete_nested_command_line): New.
2760         (gdb_completion_word_break_characters_throw): Add assertion.
2761         * completer.h (complete_nested_command_line): Declare.
2762
2763 2019-06-13  Pedro Alves  <palves@redhat.com>
2764
2765         * stack.c (parse_backtrace_qualifiers): New.
2766         (backtrace_command): Use it.
2767         (backtrace_command_completer): Complete on qualifiers.
2768
2769 2019-06-13  Pedro Alves  <palves@redhat.com>
2770
2771         * frame.c: Include "cli/cli-option.h.
2772         (user_set_backtrace_options): New.
2773         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2774         Delete.
2775         (get_prev_frame): Adjust.
2776         (boolean_option_def, uinteger_option_def)
2777         (set_backtrace_option_defs): New.
2778         (_initialize_frame): Adjust and use
2779         gdb::option::add_setshow_cmds_for_options to install "set
2780         backtrace past-main" and "set backtrace past-entry".
2781         * frame.h: Include "cli/cli-option.h".
2782         (struct frame_print_options): Forward declare.
2783         (print_frame_arguments_all, print_frame_arguments_scalars)
2784         (print_frame_arguments_none): Declare.
2785         (print_entry_values): Delete declaration.
2786         (struct frame_print_options, user_frame_print_options): New.
2787         (struct set_backtrace_options): New.
2788         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2789         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2790         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2791         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2792         (list_args_or_locals): Add frame_print_options parameter.
2793         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2794         * python/py-framefilter.c (enumerate_args): Pass down
2795         USER_FRAME_PRINT_OPTIONS.
2796         * stack.c: Include "cli/cli-option.h".
2797         (print_frame_arguments_all, print_frame_arguments_scalars)
2798         (print_frame_arguments_none): Declare.
2799         (print_raw_frame_arguments, print_entry_values): Delete.
2800         (user_frame_print_options): New.
2801         (boolean_option_def, enum_option_def, frame_print_option_defs):
2802         New.
2803         (struct backtrace_cmd_options): New.
2804         (bt_flag_option_def): New.
2805         (backtrace_command_option_defs): New.
2806         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2807         (print_frame_arg, read_frame_arg, print_frame_args)
2808         (print_frame_info, print_frame): Add frame_print_options parameter
2809         and use it.
2810         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2811         (backtrace_command_1): Add frame_print_options and
2812         backtrace_cmd_options parameters and use them.
2813         (make_backtrace_options_def_group): New.
2814         (backtrace_command): Process command options with
2815         gdb::option::process_options.
2816         (backtrace_command_completer): New.
2817         (_initialize_stack): Extend "backtrace"'s help to mention
2818         supported options.  Install completer for "backtrace".
2819         Install some settings commands with add_setshow_cmds_for_options.
2820
2821 2019-06-13  Pedro Alves  <palves@redhat.com>
2822
2823         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2824         and that "set/show print raw frame-arguments" are now deprecated.
2825
2826         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2827         command.
2828         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2829         * stack.c (_initialize_stack): Install "set/show print
2830         raw-frame-arguments", and deprecate "set/show print raw
2831         frame-arguments".
2832         * valprint.c (_initialize_valprint): Deprecate "set/show print
2833         raw".
2834
2835 2019-06-13  Pedro Alves  <palves@redhat.com>
2836
2837         * compile/compile.c (struct compile_options): New.
2838         (compile_flag_option_def, compile_command_option_defs)
2839         (make_compile_options_def_group): New.
2840         (compile_file_command): Handle options with
2841         gdb::option::process_options.
2842         (compile_file_command_completer): New function.
2843         (compile_code_command): Handle options with
2844         gdb::option::process_options.
2845         (compile_code_command_completer): New function.
2846         (_initialize_compiler): Install completers for "compile code" and
2847         "compile file".  Mention available options in "compile code" and
2848         "compile code"'s help.
2849         * completer.c (advance_to_completion_word): New, factored out from
2850         ...
2851         (advance_to_expression_complete_word_point): ... this.
2852         (advance_to_filename_complete_word_point): New.
2853         * completer.h (advance_to_filename_complete_word_point): New
2854         declaration.
2855
2856 2019-06-13  Pedro Alves  <palves@redhat.com>
2857
2858         * compile/compile.c: Include "cli/cli-option.h".
2859         (compile_print_value): Scope data pointer is now a
2860         value_print_options pointer; adjust.
2861         (compile_print_command): Process options.  Scope data pointer is
2862         now a value_print_options pointer; adjust.
2863         (_initialize_compile): Update "compile print"'s help to include
2864         supported options.  Install a completer for "compile print".
2865         * cp-valprint.c (show_vtblprint, show_objectprint)
2866         (show_static_field_print): Delete.
2867         (_initialize_cp_valprint): Don't install "set print
2868         static-members", "set print vtbl", "set print object" here.
2869         * printcmd.c: Include "cli/cli-option.h" and
2870         "common/gdb_optional.h".
2871         (print_command_parse_format): Rework to fill in a
2872         value_print_options instead of a format_data.
2873         (print_value): Change parameter type from format_data pointer to
2874         value_print_options reference.  Adjust.
2875         (print_command_1): Process options.  Adjust to pass down a
2876         value_print_options.
2877         (print_command_completer): New.
2878         (_initialize_printcmd): Install print_command_completer as
2879         handle_brkchars completer for the "print" command.  Update
2880         "print"'s help to include supported options.
2881         * valprint.c: Include "cli/cli-option.h".
2882         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2883         here from cp-valprint.c.
2884         (boolean_option_def, uinteger_option_def)
2885         (value_print_option_defs, make_value_print_options_def_group):
2886         New.  Use gdb::option::add_setshow_cmds_for_options to install
2887         "set print elements", "set print null-stop", "set print repeats",
2888         "set print pretty", "set print union", "set print array", "set
2889         print address", "set print symbol", "set print array-indexes".
2890         * valprint.h: Include <string> and "cli/cli-option.h".
2891         (make_value_print_options_def_group): Declare.
2892         (print_value): Change parameter type from format_data pointer to
2893         value_print_options reference.
2894         (print_command_completer): Declare.
2895
2896 2019-06-13  Pedro Alves  <palves@redhat.com>
2897
2898         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2899         (COMMON_SFILES): Add maint-test-settings.c.
2900         * cli/cli-decode.c (boolean_enums): New global, factored out from
2901         ...
2902         (add_setshow_boolean_cmd): ... here.
2903         * cli/cli-decode.h (boolean_enums): Declare.
2904         * cli/cli-option.c: New file.
2905         * cli/cli-option.h: New file.
2906         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2907         factored out from ...
2908         (parse_cli_boolean_value(const char *)): ... this.
2909         (is_unlimited_literal): Change parameter type to pointer to
2910         pointer.  Adjust and advance ARG pointer.
2911         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2912         (parse_cli_var_enum): New, factored out from ...
2913         (do_set_command): ... this.  Adjust.
2914         * cli/cli-setshow.h (parse_cli_boolean_value)
2915         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2916         (parse_cli_var_enum): Declare.
2917         * cli/cli-utils.c: Include "cli/cli-option.h".
2918         (get_ulongest): New.
2919         * cli/cli-utils.h (get_ulongest): Declare.
2920         (check_for_argument): New overloads.
2921         * maint-test-options.c: New file.
2922
2923 2019-06-13  Pedro Alves  <palves@redhat.com>
2924
2925         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2926         parse a range if "-" is at the end of the string.
2927
2928 2019-06-13  Pedro Alves  <palves@redhat.com>
2929
2930         * cli/cli-setshow.c (parse_auto_binary_operation)
2931         (parse_cli_boolean_value): Don't allow "o".
2932
2933 2019-06-13  Pedro Alves  <palves@redhat.com>
2934
2935         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2936         * NEWS: Mention maint test-settings KIND.
2937         * maint-test-settings.c: New file.
2938
2939 2019-06-13  Pedro Alves  <palves@redhat.com>
2940
2941         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2942         completer.
2943         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2944         "set" completers.
2945
2946 2019-06-13  Pedro Alves  <palves@redhat.com>
2947
2948         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2949         after item.
2950
2951 2019-06-13  Pedro Alves  <palves@redhat.com>
2952
2953         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2954
2955 2019-06-13  Pedro Alves <palves@redhat.com>
2956
2957         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2958         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2959         call.
2960         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2961         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2962         calls.
2963         (check_for_argument): Skip spaces after argument.
2964
2965 2019-06-13  Pedro Alves  <palves@redhat.com>
2966
2967         * thread.c (thread_apply_command): Adjust TID parsing.
2968         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2969         detected before end of string.
2970         (tid_is_in_list): Error out if LIST is invalid.
2971
2972 2019-06-13  Pedro Alves  <palves@redhat.com>
2973
2974         * completer.c (complete_line_internal_1): Rewind completion word
2975         point.
2976         (completion_tracker::advance_custom_word_point_by): Change
2977         parameter type to int.
2978         * completer.h (completion_tracker::advance_custom_word_point_by):
2979         Likewise.
2980
2981 2019-06-13  Pedro Alves  <palves@redhat.com>
2982
2983         * completer.c (advance_to_completion_word): Handle delimiters.
2984
2985 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2986
2987         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2988
2989 2019-06-11  Tom Tromey  <tom@tromey.com>
2990
2991         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2992         (xmalloc_failed): Move to alloc.c.
2993         * alloc.c: New file.
2994         * Makefile.in (COMMON_SFILES): Add alloc.c.
2995
2996 2019-06-11  Tom Tromey  <tom@tromey.com>
2997
2998         * nat/linux-waitpid.c: Don't include server.h.
2999         (linux_debug): Remove.
3000         (my_waitpid): Update.
3001
3002 2019-06-11  Tom Tromey  <tromey@adacore.com>
3003
3004         * infcall.c (_initialize_infcall): Remove trailing newline from
3005         help.
3006         * user-regs.c (_initialize_user_regs): Remove trailing newline
3007         from help.
3008         * typeprint.c (_initialize_typeprint): Remove trailing newline
3009         from help.
3010         * reverse.c (_initialize_reverse): Remove trailing newlines from
3011         help.
3012         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3013         from help.
3014         * language.c (add_set_language_command): Remove trailing newline
3015         from help.
3016         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3017         help.
3018         * disasm.c (_initialize_disasm): Remove trailing newline from
3019         help.
3020         * top.c (init_main): Remove trailing newline from help.
3021         * interps.c (_initialize_interpreter): Remove trailing newline
3022         from help.
3023         * btrace.c (_initialize_btrace): Remove trailing newlines from
3024         help.
3025         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3026         from help.
3027         * python/python.c (_initialize_python): Remove trailing newline
3028         from help.
3029         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3030         help.
3031         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3032         from help.  Reformat some text.
3033         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3034         from help.
3035         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3036         newline from help.
3037
3038 2019-06-11  Tom Tromey  <tromey@adacore.com>
3039
3040         * darwin-nat.c (darwin_decode_exception_message)
3041         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3042
3043 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3044
3045         * valops.c (value_slice): Check for not allocated or not
3046         associated values.
3047
3048 2019-06-10  Tom de Vries  <tdevries@suse.de>
3049
3050         PR gdb/24618
3051         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3052         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3053         invalid.
3054
3055 2019-06-10  Tom de Vries  <tdevries@suse.de>
3056
3057         PR gdb/24611
3058         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3059         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3060
3061 2019-06-10  Tom de Vries  <tdevries@suse.de>
3062
3063         PR symtab/24545
3064         * symtab.c (struct demangled_name_entry): Add language field.
3065         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3066         static minimal symbol".  Set and use language field.
3067
3068 2019-06-10  Tom Tromey  <tromey@adacore.com>
3069
3070         * ada-lang.c (_initialize_ada_language): Update help text.
3071
3072 2019-06-10  Tom Tromey  <tromey@adacore.com>
3073
3074         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3075         with a newline.
3076         * guile/guile.c (handle_boot_error): Don't end warning with a
3077         newline.
3078         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3079         warning with a newline.
3080         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3081         newline.
3082         (s12z_frame_cache): Likewise.
3083         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3084         a newline.
3085         * solib-svr4.c (disable_probes_interface): Don't end warning with
3086         a newline.
3087         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3088         newline.
3089         * python/python.c (do_finish_initialization): Don't end warning
3090         with a newline.
3091
3092 2019-06-10  Tom Tromey  <tom@tromey.com>
3093
3094         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3095         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3096         gdbpy_enter.
3097
3098 2019-06-10  Tom Tromey  <tromey@adacore.com>
3099
3100         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3101         data.
3102         (elf_new_init): Don't call stabsread_new_init.
3103         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3104         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3105         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3106
3107 2019-06-10  Tom de Vries  <tdevries@suse.de>
3108
3109         PR symtab/16264
3110         PR symtab/24517
3111         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3112
3113 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3114
3115         * source.c (find_and_open_source): Also rewrite relative file
3116         names.
3117
3118 2019-04-26  Amos Bird  <amosbird@gmail.com>
3119
3120         * annotate.c (annotate_thread_exited): Add "thread-exited"
3121         annotation.
3122
3123 2019-06-06  Tom Tromey  <tromey@adacore.com>
3124
3125         * maint.h (class scoped_command_stats): Use
3126         DISABLE_COPY_AND_ASSIGN.
3127         <print_time>: New method.
3128         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3129         print_time.
3130         (scoped_command_stats::print_time): New method.
3131
3132 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3133
3134         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3135         instructions of lengths 6 or 8 bytes.
3136
3137 2019-06-04  Pedro Alves  <palves@redhat.com>
3138
3139         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3140
3141         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3142         * breakpoint.c (condition_completer): Likewise.
3143         * cli/cli-dump.c (scan_expression): Likewise.
3144         * common/filestuff.c (mkdir_recursive): Likewise.
3145         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3146         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3147         (gdb_abspath): Likewise.
3148         * compile/compile-cplus-types.c
3149         (compile_cplus_instance::decl_name): Likewise.
3150         * completer.c (complete_explicit_location):
3151         (signal_completer, reg_or_group_completer_1): Likewise.
3152         * cp-support.c (cp_remove_params_if_any): Likewise.
3153         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3154         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3155         * infcmd.c (strip_bg_char): Likewise.
3156         * linespec.c (copy_token_string): Likewise.
3157         * mi/mi-main.c (output_cores): Likewise.
3158         * psymtab.c (psymtab_search_name):
3159         * symfile.c (test_set_ext_lang_command): Likewise.
3160         * target.c (target_fileio_read_stralloc): Likewise.
3161         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3162         * value.c (complete_internalvar): Likewise.
3163
3164 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3165
3166         Add objfile property to gdb.Type.
3167         * NEWS: Mention Python API addition.
3168         * python/py-type.c (typy_get_objfile): New method.
3169
3170 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3171
3172         * NEWS: Mention the new set|show style [title|highlight].
3173         Mention changes to "show style", "help" and "apropos".
3174
3175 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3176
3177         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3178         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3179         instead of print_help_for_command.
3180         (print_doc_of_command): New function.
3181         (help_list): Add 'apropos -v word' suggestion.
3182         (print_help_for_command): Style the command name using title style.
3183         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3184         (_initialize_cli_cmds): Describe -v in apropos_command help.
3185
3186 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3187
3188         * cli/cli-style.h (cli_style_option): Add name in constructor,
3189         add m_name class member, add constructor with intensity,
3190         add name class function.
3191         (cli_style_option::add_setshow_commands): Remove name argument.
3192         (highlight_style, title_style): New styles.
3193         * cli/cli-style.c (do_show): New function that shows a style
3194         characteristic styling the style name with itself.
3195         (set_style_name): New function.
3196         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3197         Update all callers according to the changes in cli/cli-style.h.
3198         * utils.h (fputs_highlighted): New function.
3199         * utils.c (fputs_highlighted): Likewise.
3200
3201 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3202
3203         * NEWS: Mention new pipe command and new convenience variables.
3204
3205 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3206
3207         * cli/cli-cmds.c (pipe_command): New function.
3208         (_initialize_cli_cmds): Call add_com for pipe_command.
3209         Define | as an alias for pipe.
3210         (exit_status_set_internal_vars): New function.
3211         (shell_escape): Call exit_status_set_internal_vars.
3212         cli/cli-decode.c (find_command_name_length): Recognize | as
3213         a single character command.
3214
3215 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3216
3217         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3218         top.c (execute_command_to_ui_file): New function, mostly a copy
3219         of execute_command_to_string.
3220         (execute_command_to_string): Implement by calling
3221         execute_command_to_ui_file.
3222
3223 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3224
3225         * top.h (saved_command_line): Remove declaration.
3226         * top.c (previous_saved_command_line, previous_repeat_arguments):
3227         New variables.
3228         (saved_command_line): Make static, define together with other
3229         'repeat variables'.
3230         (dont_repeat): Clear repeat_arguments.
3231         (repeat_previous, get_saved_command_line, save_command_line):
3232         New functions.
3233         (gdb_init): Initialize saved_command_line
3234         and previous_saved_command_line.
3235         * main.c (captured_main_1): Remove saved_command_line initialization.
3236         * event-top.c (handle_line_of_input): Update to use
3237         the new 'repeat' related functions instead of direct access to
3238         saved_command_line.
3239         * command.h (repeat_previous, get_saved_command_line,
3240         save_command_line): New declarations.
3241         (dont_repeat): Add comment.
3242
3243 2019-05-30  Tom Tromey  <tromey@adacore.com>
3244
3245         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3246         Fix comment.
3247         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3248
3249 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3250
3251         PR cli/24587
3252         * completer.c (complete): Initialize variable word.
3253
3254 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3255
3256         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3257         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3258         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3259         'body' is NULL to the outter 'if', protecting the '!is_define'
3260         situation as well.
3261
3262 2019-05-29  Tom Tromey  <tromey@adacore.com>
3263
3264         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3265         (dwarf_unknown): New function.
3266         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3267         (dwarf_type_encoding_name): Use dwarf_unknown.
3268
3269 2019-05-29  Tom Tromey  <tromey@adacore.com>
3270
3271         PR c++/20020:
3272         * cp-valprint.c (cp_print_value_fields): Call
3273         cp_print_static_field inside "try".
3274
3275 2019-05-29  Tom Tromey  <tromey@adacore.com>
3276
3277         * inflow.c (struct terminal_info): Add default operator=.
3278         * configure: Rebuild.
3279         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3280         -Wdeprecated-copy-dtor, -Wredundant-move.
3281
3282 2019-05-29  Tom Tromey  <tromey@adacore.com>
3283
3284         * NEWS: Add entry.
3285         * infcmd.c (print_return_value_1): Handle finish_print
3286         option.
3287         (show_print_finish): New function.
3288         (_initialize_infcmd): Add "set/show print finish" commands.
3289         * valprint.c (user_print_options): Initialize new member.
3290         * valprint.h (struct value_print_options) <finish_print>: New
3291         member.
3292
3293 2019-05-28  Tom Tromey  <tromey@adacore.com>
3294
3295         * ada-lang.c (ada_remove_Xbn_suffix)
3296         (find_old_style_renaming_symbol)
3297         (parse_old_style_renaming): Remove.
3298         (ada_find_renaming_symbol): Don't call
3299         find_old_style_renaming_symbol.
3300         (ada_is_renaming_symbol): Rename from
3301         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3302         bool.  Now static.
3303         (ada_read_var_value): Update and simplify.
3304         * ada-exp.y (write_var_or_type): Remove old code.
3305
3306 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3307
3308         * event-top.c: Remove include comment.
3309         * inflow.c (class scoped_ignore_sigttou): Move from here...
3310         * inflow.h (class scoped_ignore_sigttou): ...to here.
3311         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3312         * top.c:  Remove include comment.
3313
3314 2019-05-27  Tom Tromey  <tom@tromey.com>
3315
3316         * NEWS: Fix typo.
3317
3318 2019-05-22  Tom Tromey  <tromey@adacore.com>
3319
3320         * target.c (target_follow_exec): Constify parameter.
3321         * target-delegates.c: Rebuild.
3322         * remote.c (remote_target::follow_exec): Constify parameter.
3323         * infrun.c (follow_exec): Constify parameter.
3324         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3325         (target_follow_exec): Likewise.
3326
3327 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3328
3329         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3330         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3331
3332 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3333
3334         * NEWS: Add debugredirect and testsuite sections.
3335
3336 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3337
3338         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3339         target descriptions using exclusively floating point register name
3340         aliases.
3341
3342 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3343
3344         PR gdb/18644:
3345         * f-lang.c (build_fortran_types): Handle the case where
3346         gdbarch_floatformat_for_type returns a nullptr.
3347
3348 2019-05-21  Tom de Vries  <tdevries@suse.de>
3349
3350         PR cli/24587
3351         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3352
3353 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3354
3355         PR gdb/18644:
3356         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3357         16-byte floats.
3358         * i386-tdep.c (i386_floatformat_for_type): Use
3359         floatformats_ia64_quad for the 16-byte floating point component
3360         within a fortran 32-byte complex number.
3361
3362 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3363
3364         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3365         delete default constructor.
3366         (find_partial_die): Update to return const struct.
3367         (partial_die_parent_scope): Move variable declaration into scope
3368         of its use and change its type to auto.
3369         (guess_partial_die_structure_name): Likewise.
3370         (partial_die_info::fixup): Likewise.
3371
3372 2019-05-17  Tom Tromey  <tromey@adacore.com>
3373
3374         * source.c (find_and_open_source): Remove cast.
3375
3376 2019-05-17  Tom Tromey  <tromey@adacore.com>
3377
3378         * annotate.c (annotate_source): Make "filename" const.
3379         * annotate.h (annotate_source): Use const.
3380
3381 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3382
3383         * disasm.c (set_disassembler_options): Send errors to stderr.
3384
3385 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3386
3387         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3388         (cli_interp_base::set_logging): Check debug_redirect.
3389         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3390         * cli/cli-logging.c (debug_redirect): Add static variable.
3391         (pop_output_files): Add default param.
3392         (handle_redirections): Print debug setting.
3393         (show_logging_command): Likewise.
3394         (_initialize_cli_logging): Add debugredirect command.
3395         * interps.c (current_interp_set_logging): Add debug_redirect
3396         parameter.
3397         * interps.h (set_logging): Add debug_redirect parameter.
3398         (current_interp_set_logging): Likewise.
3399         * mi/mi-common.h: Likewise.
3400         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3401
3402 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3403             Tom Tromey  <tromey@adacore.com>
3404
3405         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3406         directly.
3407         * cli/cli-interp.h (make_logging_output): Remove declaration.
3408         * cli/cli-logging.c (make_logging_output): Remove function.
3409         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3410         directly.
3411         * ui-file.c (tee_file::tee_file): Remove bools.
3412         (tee_file::~tee_file): Remove deletes.
3413         * ui-file.h (tee_file): Remove bools.
3414
3415 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3416
3417         * mi/mi-cmds.h (mi_cmd_complete): New function.
3418         * mi/mi-main.c (mi_cmd_complete): Likewise.
3419         * mi/mi-cmds.c: Define new MI command -complete.
3420         * NEWS: Mention new -complete command.
3421
3422 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3423
3424         * completer.h (complete): New function.
3425         * completer.c (complete): Likewise.
3426         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3427         function defined in completer.h.
3428
3429 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3430
3431         * MAINTAINERS (Write After Approval): Add myself.
3432
3433 2019-05-17  Tom de Vries  <tdevries@suse.de>
3434
3435         PR gdb/24094
3436         * dwarf2read.c (struct cu_partial_die_info): New struct.
3437         (find_partial_die): Return cu_partial_die_info.
3438         (partial_die_parent_scope, guess_partial_die_structure_name)
3439         (partial_die_info::fixup): Handle new return type of find_partial_die.
3440
3441 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3442
3443         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3444         "std::string", simplifying the algorithm.
3445
3446 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3447
3448         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3449         (stap_static_probe_ops::get_probes): Likewise.
3450
3451 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3452
3453         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3454         '-')" and "else if".
3455         (stap_parse_single_operand): Join checks for
3456         "gdbarch_stap_parse_special_token_p" and
3457         "gdbarch_stap_parse_special_token" in the same "if" statement.
3458         Invert check when verifying for operation on register
3459         displacement.
3460
3461 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3462
3463         * stap-probe.c (stap_get_opcode): Update comment.
3464         (stap_get_expected_argument_type): Likewise.
3465         (handle_stap_probe): Likewise.
3466
3467 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3468
3469         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3470         return type to 'bool'.  Adjust comment.  Use 'bool' when
3471         appropriate.
3472         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3473         * stap-probe.c (stap_parse_argument_1): Likewise.
3474         (stap_is_operator): Likewise.
3475         (stap_is_generic_prefix): Likewise.
3476         (stap_is_register_prefix): Likewise.
3477         (stap_is_register_indirection_prefix): Likewise.
3478         (stap_is_integer_prefix): Likewise.
3479         (stap_generic_check_suffix): Likewise.
3480         (stap_check_integer_suffix): Likewise.
3481         (stap_check_register_suffix): Likewise.
3482         (stap_check_register_indirection_suffix): Likewise.
3483         (stap_parse_register_operand): Likewise.
3484         (stap_parse_single_operand): Likewise.
3485         (stap_parse_argument_1): Likewise.
3486         (stap_probe::get_argument_count): Likewise.
3487         (stap_is_operator): Likewise.
3488
3489 2019-05-16  Tom Tromey  <tromey@adacore.com>
3490
3491         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3492         keyword to foreach.
3493
3494 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3495
3496         * linux-thread-db.c (try_thread_db_load_1): Change return type
3497         to bool.
3498         (try_thread_db_load): Likewise.
3499         (try_thread_db_load_from_pdir_1): Likewise.
3500         (try_thread_db_load_from_pdir): Likewise.
3501         (try_thread_db_load_from_sdir): Likewise.
3502         (try_thread_db_load_from_dir): Likewise.
3503         (thread_db_load_search): Likewise.
3504         (has_libpthread): Likewise.
3505         (thread_db_load): Likewise.
3506
3507 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3508
3509         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3510         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3511         NULL, and complain/return if that's the case.
3512
3513 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3514
3515         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3516         (advance, posn, abstract_read_memory): New functions.
3517         [struct mem_read_abstraction]: New struct.
3518         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3519
3520 2019-05-14  Tom Tromey  <tromey@adacore.com>
3521
3522         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3523         value is not lval_memory.
3524
3525 2019-05-14  Tom Tromey  <tromey@adacore.com>
3526
3527         * solib.c (info_sharedlibrary_command): Style the file name.
3528
3529 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3530
3531         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3532         (aarch64_vnv_type): Likewise.
3533         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3534         * common/tdesc.c: Likewise.
3535         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3536         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3537         * features/aarch64-fpu.xml: Add ieee half view.
3538         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3539         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3540         * gdbtypes.h (struct builtin_type): Likewise.
3541         (struct objfile_type): Likewise.
3542
3543 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3544
3545         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3546         typo.
3547         * location.h (string_to_event_location): Likewise.
3548
3549 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3550
3551         GDB 8.3 released.
3552
3553 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3554
3555         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3556         New variable declaration.
3557         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3558         New variable.
3559         (print_one_breakpoint): Use ui_out::test_flags and new global
3560         variable to compute use_fixed_output.
3561         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3562         Remove.
3563         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3564         (mi_multi_location_breakpoint_output_fixed): Remove.
3565         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3566         new variable.
3567         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3568         fix_multi_location_breakpoint_output flag if version >= 3.
3569         * ui-out.h (enum ui_out_flag)
3570         <fix_multi_location_breakpoint_output>: New enumerator.
3571
3572 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3573
3574         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3575
3576 2019-05-10  Tom Tromey  <tromey@adacore.com>
3577
3578         * ada-lang.c (catch_ada_completer): New function.
3579         (_initialize_ada_language): Use it.
3580
3581 2019-05-10  Tom Tromey  <tromey@adacore.com>
3582
3583         * thread.c (print_thread_info): Make "requested_threads" const.
3584         * gdbthread.h (print_thread_info): Make "requested_threads"
3585         const.
3586         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3587         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3588
3589 2019-05-08  Tom Tromey  <tom@tromey.com>
3590
3591         * gdbtypes.c (objfile_type_data): Change type.
3592         (objfile_type, _initialize_gdbtypes): Update.
3593
3594 2019-05-08  Tom Tromey  <tom@tromey.com>
3595
3596         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3597         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3598         (_initialize_dwarf2_frame): Update.
3599
3600 2019-05-08  Tom Tromey  <tom@tromey.com>
3601
3602         * objc-lang.c (objc_objfile_data): Change type.
3603         (find_methods): Update.
3604         (_initialize_objc_lang): Remove.
3605
3606 2019-05-08  Tom Tromey  <tom@tromey.com>
3607
3608         * stabsread.c (rs6000_builtin_type_data): Change type.
3609         (rs6000_builtin_type, _initialize_stabsread): Update.
3610
3611 2019-05-08  Tom Tromey  <tom@tromey.com>
3612
3613         * mips-tdep.c (mips_pdr_data): Remove.
3614         (_initialize_mips_tdep): Update.
3615
3616 2019-05-08  Tom Tromey  <tom@tromey.com>
3617
3618         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3619         (hppa_init_objfile_priv_data, read_unwind_info)
3620         (find_unwind_entry, _initialize_hppa_tdep): Update.
3621
3622 2019-05-08  Tom Tromey  <tom@tromey.com>
3623
3624         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3625         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3626         on obstack.
3627         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3628
3629 2019-05-08  Tom Tromey  <tom@tromey.com>
3630
3631         * mdebugread.c (basic_type_data): Change type.
3632         (basic_type, _initialize_mdebugread): Update.
3633
3634 2019-05-08  Tom Tromey  <tom@tromey.com>
3635
3636         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3637
3638 2019-05-08  Tom Tromey  <tom@tromey.com>
3639
3640         * nto-tdep.c (nto_inferior_data_reg): Change type.
3641         (nto_inferior_data): Update.
3642         (nto_inferior_data_cleanup, nto_new_inferior_data)
3643         (_initialize_nto_tdep): Remove.
3644         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3645
3646 2019-05-08  Tom Tromey  <tom@tromey.com>
3647
3648         * ada-lang.c (struct ada_inferior_data): Add initializers.
3649         (ada_inferior_data): Change type.
3650         (ada_inferior_data_cleanup): Remove.
3651         (get_ada_inferior_data, ada_inferior_exit)
3652         (struct ada_pspace_data): Add initializers, destructor.
3653         (ada_pspace_data_handle): Change type.
3654         (get_ada_pspace_data): Update.
3655         (ada_pspace_data_cleanup): Remove.
3656
3657 2019-05-08  Tom Tromey  <tom@tromey.com>
3658
3659         * coffread.c (struct coff_symfile_info): Add initializers.
3660         (coff_objfile_data_key): Move lower.  Change type.
3661         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3662         Update.
3663         (coff_free_info): Remove.
3664
3665 2019-05-08  Tom Tromey  <tom@tromey.com>
3666
3667         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3668         (fbsd_pspace_data_handle): Move lower.  Change type.
3669         (get_fbsd_pspace_data): Update.
3670         (fbsd_pspace_data_cleanup): Remove.
3671         (_initialize_fbsd_tdep): Update.
3672
3673 2019-05-08  Tom Tromey  <tom@tromey.com>
3674
3675         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3676         (get_ada_tasks_pspace_data): Update.
3677         (ada_tasks_pspace_data_cleanup): Remove.
3678         (_initialize_tasks): Update.
3679         (ada_tasks_inferior_data_handle): Change type.
3680         (get_ada_tasks_inferior_data): Update.
3681         (ada_tasks_inferior_data_cleanup): Remove.
3682         (struct ada_tasks_pspace_data): Add initializers.
3683
3684 2019-05-08  Tom Tromey  <tom@tromey.com>
3685
3686         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3687         * symfile-debug.c (debug_sym_get_probes): Change type.
3688         * stap-probe.c (handle_stap_probe):
3689         (stap_static_probe_ops::get_probes): Change type.
3690         * probe.h (class static_probe_ops) <get_probes>: Change type.
3691         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3692         (parse_probes_in_pspace): Update.
3693         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3694         Update.
3695         (any_static_probe_ops::get_probes): Change type.
3696         * elfread.c (elfread_data): New typedef.
3697         (probe_key): Change type.
3698         (elf_get_probes): Likewise.  Update.
3699         (probe_key_free): Remove.
3700         (_initialize_elfread): Update.
3701         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3702         Change type.
3703         (dtrace_process_dof_probe, dtrace_process_dof)
3704         (dtrace_static_probe_ops::get_probe): Change type.
3705
3706 2019-05-08  Tom Tromey  <tom@tromey.com>
3707
3708         * xcoffread.c (struct xcoff_symfile_info): Rename from
3709         coff_symfile_info.  Add initializers.
3710         (xcoff_objfile_data_key): Move lower.  Change type.
3711         (XCOFF_DATA): Rewrite.
3712         (xcoff_free_info): Remove.
3713         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3714         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3715         (xcoff_initial_scan): Update.
3716
3717 2019-05-08  Tom Tromey  <tom@tromey.com>
3718
3719         * solib-svr4.c (struct svr4_info): Add initializers and
3720         destructor.
3721         <probes_table>: Now an htab_up.
3722         (solib_svr4_pspace_data): Change type.
3723         (free_probes_table): Simplify.
3724         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3725         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3726         (probes_table_remove_objfile_probes, register_solib_event_probe)
3727         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3728         (_initialize_svr4_solib): Update.
3729
3730 2019-05-08  Tom Tromey  <tom@tromey.com>
3731
3732         * remote.c (remote_pspace_data): Change type.
3733         (remote_pspace_data_cleanup): Remove.
3734         (get_remote_exec_file, set_pspace_remote_exec_file)
3735         (_initialize_remote): Update.
3736
3737 2019-05-08  Tom Tromey  <tom@tromey.com>
3738
3739         * breakpoint.c (breakpoint_objfile_key): Change type.
3740         (get_breakpoint_objfile_data): Update.
3741         (free_breakpoint_objfile_data): Remove.
3742         (_initialize_breakpoint): Update.
3743
3744 2019-05-08  Tom Tromey  <tom@tromey.com>
3745
3746         * linux-tdep.c (struct linux_info): Add initializers.
3747         (linux_inferior_data): Move.  Change type.
3748         (invalidate_linux_cache_inf): Update.
3749         (linux_inferior_data_cleanup): Remove.
3750         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3751
3752 2019-05-08  Tom Tromey  <tom@tromey.com>
3753
3754         * auxv.c (auxv_inferior_data): Move.  Change type.
3755         (auxv_inferior_data_cleanup): Remove.
3756         (invalidate_auxv_cache_inf): Rewrite.
3757         (get_auxv_inferior_data, _initialize_auxv): Update.
3758
3759 2019-05-08  Tom Tromey  <tom@tromey.com>
3760
3761         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3762         (symfile_debug_objfile_data_key): Change type.
3763         (symfile_debug_installed, debug_qf_has_symbols)
3764         (debug_qf_find_last_source_symtab)
3765         (debug_qf_forget_cached_source_info)
3766         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3767         (debug_qf_print_stats, debug_qf_dump)
3768         (debug_qf_expand_symtabs_for_function)
3769         (debug_qf_expand_all_symtabs)
3770         (debug_qf_expand_symtabs_with_fullname)
3771         (debug_qf_map_matching_symbols)
3772         (debug_qf_expand_symtabs_matching)
3773         (debug_qf_find_pc_sect_compunit_symtab)
3774         (debug_qf_map_symbol_filenames)
3775         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3776         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3777         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3778         (debug_sym_read_linetable, debug_sym_relocate): Update.
3779         (symfile_debug_free_objfile): Remove.
3780         (install_symfile_debug_logging, _initialize_symfile_debug):
3781         Update.
3782
3783 2019-05-08  Tom Tromey  <tom@tromey.com>
3784
3785         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3786         allocate_on_obstack.
3787         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3788         (get_dwarf2_per_objfile): Update.
3789         (set_dwarf2_per_objfile): Remove.
3790         (dwarf2_has_info, dwarf2_get_section_info): Update.
3791         (dwarf2_free_objfile): Remove.
3792         (_initialize_dwarf2_read): Update.
3793
3794 2019-05-08  Tom Tromey  <tom@tromey.com>
3795
3796         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3797         initializers.
3798         <unsupported_script_warning_printed,
3799         script_not_found_warning_printed>: Now bool.
3800         (auto_load_pspace_data): Change type.
3801         (~auto_load_pspace_info): Rename from
3802         auto_load_pspace_data_cleanup.
3803         (get_auto_load_pspace_data, init_loaded_scripts_info)
3804         (clear_section_scripts, maybe_print_unsupported_script_warning)
3805         (maybe_print_script_not_found_warning, _initialize_auto_load):
3806         Update.
3807
3808 2019-05-08  Tom Tromey  <tom@tromey.com>
3809
3810         * objfiles.c (objfile_pspace_info): Add destructor and
3811         initializers.
3812         (objfiles_pspace_data): Change type.
3813         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3814         (get_objfile_pspace_data): Update.
3815         (objfiles_bfd_data): Change type.
3816         (get_objfile_bfd_data): Update.
3817         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3818
3819 2019-05-08  Tom Tromey  <tom@tromey.com>
3820
3821         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3822         Change type.
3823         (get_catch_syscall_inferior_data): Update.
3824         (catch_syscall_inferior_data_cleanup): Remove.
3825         (_initialize_break_catch_syscall): Update.
3826
3827 2019-05-08  Tom Tromey  <tom@tromey.com>
3828
3829         * inflow.c (struct terminal_info): Add destructor and
3830         initializers.
3831         (inflow_inferior_data): Change type.
3832         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3833         (get_inflow_inferior_data, inflow_inferior_exit)
3834         (swap_terminal_info, _initialize_inflow): Update.
3835
3836 2019-05-08  Tom Tromey  <tom@tromey.com>
3837
3838         * target-dcache.c (target_dcache_cleanup): Remove.
3839         (target_dcache_aspace_key): Change type.
3840         (target_dcache_init_p, target_dcache_invalidate)
3841         (target_dcache_get, target_dcache_get_or_init)
3842         (_initialize_target_dcache): Update.
3843         * dcache.h (struct dcache_deleter): New.
3844
3845 2019-05-08  Tom Tromey  <tom@tromey.com>
3846
3847         * symtab.c (struct symbol_cache): Add destructor and
3848         initializers.
3849         (symbol_cache_key): Move.  Change type.
3850         (make_symbol_cache, free_symbol_cache): Remove.
3851         (get_symbol_cache): Update.
3852         (symbol_cache_cleanup): Remove.
3853         (ALL_PSPACES, symbol_cache_flush)
3854         (maintenance_print_symbol_cache)
3855         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3856         Update.
3857
3858 2019-05-08  Tom Tromey  <tom@tromey.com>
3859
3860         * symtab.c (struct main_info): Add destructor and initializers.
3861         (main_progspace_key): Move.  Change type.
3862         (get_main_info): Update.
3863         (main_info_cleanup): Remove.
3864         (_initialize_symtab): Update.
3865
3866 2019-05-08  Tom Tromey  <tom@tromey.com>
3867
3868         * registry.h (DECLARE_REGISTRY): Define the _key class.
3869
3870 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3871
3872         * NEWS: Merge two 'New commands' sections.
3873
3874 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3875
3876         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3877         parameter and use Ada language definition instead.
3878         (ada_val_print_ptr): Remove unused language parameter.
3879         (ada_val_print_num): Remove language parameter and use Ada language
3880         definition instead.
3881         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3882         parameter.
3883         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3884         parameter and use Ada language definition instead.
3885         (ada_val_print_1): Update all ada_val_print_xxx calls.
3886         Remove language parameter.
3887         (ada_val_print): Update ada_val_print_1 call.
3888
3889 2019-05-08  Tom Tromey  <tromey@adacore.com>
3890
3891         * remote.c (remote_hw_watchpoint_limit)
3892         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3893         Now static.
3894
3895 2019-05-08  Tom Tromey  <tromey@adacore.com>
3896
3897         * maint.c (_initialize_maint_cmds): Move initialization code to
3898         remote.c.
3899         (watchdog, show_watchdog): Move to remote.c.
3900         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3901         "watchdog" static.
3902         (_initialize_remote): Move initialization code from maint.c.
3903         * defs.h (watchdog): Don't declare.
3904
3905 2019-05-08  Tom Tromey  <tromey@adacore.com>
3906
3907         * tui/tui-interp.c: Include main.h.
3908         * interps.c: Include main.h.
3909         * main.h (interpreter_p): Declare.
3910         * defs.h (interpreter_p): Don't declare.
3911
3912 2019-05-08  Tom Tromey  <tromey@adacore.com>
3913
3914         * dwarf2loc.c: Include dwarf2read.h.
3915         * defs.h (read_unsigned_leb128): Don't declare.
3916         * dwarf2read.h (read_unsigned_leb128): Declare.
3917
3918 2019-05-08  Tom Tromey  <tromey@adacore.com>
3919
3920         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3921         method.
3922
3923 2019-05-08  Tom Tromey  <tromey@adacore.com>
3924
3925         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3926         when no wrap column is set.
3927
3928 2019-05-08  Tom Tromey  <tromey@adacore.com>
3929
3930         * c-lang.c (c_get_string): Handle non-C-style arrays.
3931
3932 2019-05-08  Tom Tromey  <tromey@adacore.com>
3933
3934         * typeprint.c (print_offset_data::update): Print the bit offset,
3935         not the number of bits remaining.
3936
3937 2019-05-08  Tom Tromey  <tromey@adacore.com>
3938
3939         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3940         padding at end of comment.
3941
3942 2019-05-08  Tom Tromey  <tromey@adacore.com>
3943
3944         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3945         Compare main types.
3946
3947 2019-05-06  Tom Tromey  <tom@tromey.com>
3948
3949         * common/scoped_mmap.c: Include common-defs.h.
3950         * common/scoped_mmap.h: Don't include config.h.
3951
3952 2019-05-04  Tom Tromey  <tom@tromey.com>
3953
3954         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3955         (struct aarch64_call_info): Add initializers.
3956         <si>: Now a std::vector.
3957         (pass_on_stack, aarch64_push_dummy_call): Update.
3958
3959 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3960             Tom Tromey  <tom@tromey.com>
3961
3962         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3963         (ppc_threads): Now a std::vector.  Now static.
3964         (hwdebug_find_thread_points_by_tid)
3965         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3966         Update.
3967
3968 2019-05-04  Tom Tromey  <tom@tromey.com>
3969
3970         * arc-tdep.c (arc_tdesc_init): Return bool.
3971
3972 2019-05-04  Tom Tromey  <tom@tromey.com>
3973
3974         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3975         Use gdb_assert_not_reached.
3976
3977 2019-05-04  Tom Tromey  <tom@tromey.com>
3978
3979         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3980         "false".
3981
3982 2019-05-04  Tom Tromey  <tom@tromey.com>
3983
3984         * arc-tdep.c (arc_tdesc_init): Use bool.
3985
3986 2019-05-04  Tom Tromey  <tom@tromey.com>
3987
3988         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3989
3990 2019-05-04  Tom Tromey  <tom@tromey.com>
3991
3992         * cli/cli-cmds.c (valid_command_p): Return bool.
3993
3994 2019-05-04  Tom Tromey  <tom@tromey.com>
3995
3996         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3997         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3998
3999 2019-05-04  Raul Tambre  <raul@tambre.ee>
4000
4001         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4002         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4003         operator for comparison.
4004
4005 2019-05-04  Tom Tromey  <tom@tromey.com>
4006
4007         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4008         (lookup_partial_symbol, print_partial_symbols)
4009         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4010         (psymbol_compare): Update.
4011         (add_psymbol_to_bcache): Clear the entire psymbol.
4012         (maintenance_check_psymtabs): Update.
4013         * psympriv.h (struct partial_symbol): Don't derive from
4014         general_symbol_info.
4015         <obj_section, unrelocated_address, address,
4016         set_unrelocated_address>: Update.
4017         <ginfo>: New member.
4018         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4019         (debug_names::write_psymbols): Update.
4020
4021 2019-05-04  Tom de Vries  <tdevries@suse.de>
4022
4023         * contrib/cc-with-tweaks.sh: Support -n arg.
4024
4025 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4026
4027         * corelow.c (core_target::detach): Ensure frame cache and
4028         register caches are cleared.
4029         inferior.c (exit_inferior_1): Likewise.
4030
4031 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4032             Tom Tromey  <tom@tromey.com>
4033
4034         * dictionary.c (collate_pending_symbols_by_language): Remove
4035         "struct" from foreach.
4036         * symtab.c (lookup_global_symbol_from_objfile)
4037         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4038         foreach.
4039         * ser-tcp.c (net_open): Remove "struct" from foreach.
4040         * objfiles.c (objfile_relocate, objfile_rebase)
4041         (objfile_has_symbols): Remove "struct" from foreach.
4042         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4043         from foreach.
4044         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4045         foreach.
4046         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4047         "struct" from foreach.
4048         * ada-lang.c (create_excep_cond_exprs)
4049         (ada_exception_catchpoint_cond_string): Remove "struct" from
4050         foreach.
4051
4052 2019-05-03  Tom Tromey  <tromey@adacore.com>
4053
4054         * ada-exp.y (convert_char_literal): Check suffix of each
4055         enumerator.
4056
4057 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4058
4059         PR ada/21406:
4060         * ada-exp.y (yywrap): Don't define.
4061         * ada-lex.l (%option): Add noyywrap
4062         (yywrap): Remove.
4063
4064 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4065
4066         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4067         _WIN32_WINNT to the XP level, unless already defined to a higher
4068         level.
4069
4070         * unittests/parse-connection-spec-selftests.c:
4071         * ser-tcp.c:
4072         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4073         override.
4074
4075         * symfile.c (find_separate_debug_file): Remove colon from the
4076         drive spec of DOS/Windows file names of the target, so that the
4077         file name produced from DEBUGDIR and the target's directory will
4078         be valid on DOS/Windows systems.
4079
4080 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4081
4082         * rust-lang.c (val_print_struct): Handle printing structures
4083         containing strings.
4084
4085 2019-05-02  Tom Tromey  <tromey@adacore.com>
4086
4087         * valarith.c (_initialize_valarith): Remove.
4088
4089 2019-05-01  Tom Tromey  <tromey@adacore.com>
4090
4091         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4092         bitfields.
4093
4094 2019-05-01  Tom Tromey  <tromey@adacore.com>
4095
4096         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4097         for big-endian copies.
4098
4099 2019-04-30  Ali Tamur  <tamur@google.com>
4100         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4101         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4102         (read_3_bytes): New function.
4103
4104 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4105
4106         * windows-nat.c (main_thread_id): Delete.
4107         (handle_output_debug_string): Replace main_thread_id by
4108         current_event.dwThreadId.
4109         (fake_create_process): Likewise.
4110         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4111         Do not set main_thread_id.
4112         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4113         current_event.dwThreadId.
4114         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4115
4116 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4117
4118         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4119         Use current_event.dwThreadId instead of main_thread_id.
4120
4121 2019-04-30  Tom Tromey  <tromey@adacore.com>
4122
4123         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4124         (create_excep_cond_exprs): Iterate over program spaces.
4125         (ada_exception_catchpoint_cond_string): Examine all minimal
4126         symbols for exception types.
4127
4128 2019-04-30  Tom Tromey  <tromey@adacore.com>
4129
4130         PR c++/24470:
4131         * dwarf2read.c (process_structure_scope): Handle case where type
4132         has template parameters but no symbol was created.
4133
4134 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4135             Chris January  <chris.january@arm.com>
4136
4137         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4138         qualifier.
4139         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4140
4141 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4142
4143         * f-typeprint.c (f_print_type): Update rules for printing
4144         whitespace.
4145         (f_type_print_varspec_suffix): Likewise.
4146
4147 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4148             Chris January  <chris.january@arm.com>
4149
4150         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4151         function arguments.
4152
4153 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4154
4155         * f-lang.c (build_fortran_types): Change name of void type to
4156         lower case.
4157         * f-typeprint.c (f_type_print_base): Print the name of the void
4158         type, rather than a fixed string.
4159         * f-valprint.c (f_decorations): Use lower case void string.
4160
4161 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4162             Chris January  <chris.january@arm.com>
4163
4164         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4165         types for Fortran.
4166
4167 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4168             Chris January  <chris.january@arm.com>
4169             David Lecomber  <david.lecomber@arm.com>
4170
4171         * f-exp.y (BINOP_INTRINSIC): New token.
4172         (exp): New parser rule handling BINOP_INTRINSIC.
4173         (f77_keywords): Add new builtin procedures.
4174         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4175         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4176         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4177         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4178         (print_unop_subexp_f): New function.
4179         (print_binop_subexp_f): New function.
4180         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4181         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4182         (dump_subexp_body_f): Likewise.
4183         (operator_check_f): Likewise.
4184         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4185         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4186
4187 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4188
4189         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4190         UNOP_KIND.
4191         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4192         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4193         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4194         (operator_length_f): New fuction.
4195         (print_subexp_f): New function.
4196         (op_name_f): New function.
4197         (dump_subexp_body_f): New function.
4198         (operator_check_f): New function.
4199         (exp_descriptor_f): Replace standard expression handling functions
4200         with new functions.
4201         * gdb/fortran-operator.def: New file.
4202         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4203         * gdb/std-operator.def: Remove UNOP_KIND.
4204
4205 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4206
4207         * std-operator.def: Remove unbalanced, stray double quote
4208         character.
4209
4210 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4211             Chris January  <chris.january@arm.com>
4212             Daniel Everett  <daniel.everett@arm.com>
4213             Nick Forrington  <nick.forrington@arm.com>
4214             Richard Bunt  <richard.bunt@arm.com>
4215
4216         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4217         of depth when printing anonymous structs or unions.
4218         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4219         Don't print either the top-level value, or the children if the
4220         max-depth is exceeded.
4221         (ppscm_print_children): When printing the key of a map, allow one
4222         extra level of depth.
4223         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4224         print either the top-level value, or the children if the max-depth
4225         is exceeded.
4226         (print_children): When printing the key of a map, allow one extra
4227         level of depth.
4228         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4229         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4230         (user_print_options): Initialise max_depth field.
4231         (val_print_scalar_or_string_type_p): New function.
4232         (val_print): Check to see if the max depth has been reached.
4233         (val_print_check_max_depth): Define new function.
4234         (show_print_max_depth): New function.
4235         (_initialize_valprint): Add 'print max-depth' option.
4236         * valprint.h (struct value_print_options) <max_depth>: New field.
4237         (val_print_check_max_depth): Declare new function.
4238         * NEWS: Document new feature.
4239
4240 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4241
4242         * ada-lang.c (ada_language_defn): Initialise new field.
4243         * c-lang.c (c_is_string_type_p): New function.
4244         (c_language_defn): Initialise new field.
4245         (cplus_language_defn): Initialise new field.
4246         (asm_language_defn): Initialise new field.
4247         (minimal_language_defn): Initialise new field.
4248         * c-lang.h (c_is_string_type_p): Declare new function.
4249         * d-lang.c (d_language_defn): Initialise new field.
4250         * f-lang.c (f_is_string_type_p): New function.
4251         (f_language_defn): Initialise new field.
4252         * go-lang.c (go_is_string_type_p): New function.
4253         (go_language_defn): Initialise new field.
4254         * language.c (default_is_string_type_p): New function.
4255         (unknown_language_defn): Initialise new field.
4256         (auto_language_defn): Initialise new field.
4257         * language.h (struct language_defn) <la_is_string_type_p>: New
4258         member variable.
4259         (default_is_string_type_p): Declare new function.
4260         * m2-lang.c (m2_language_defn): Initialise new field.
4261         * objc-lang.c (objc_language_defn): Initialise new field.
4262         * opencl-lang.c (opencl_language_defn): Initialise new field.
4263         * p-lang.c (pascal_is_string_type_p): New function.
4264         (pascal_language_defn): Initialise new field.
4265         * rust-lang.c (rust_is_string_type_p): New function.
4266         (rust_language_defn): Initialise new field.
4267
4268 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4269
4270         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4271         New field.
4272         * ada-lang.c (ada_language_defn): Initialise new field.
4273         * c-lang.c (c_language_defn): Likewise.
4274         (cplus_language_defn): Likewise.
4275         (asm_language_defn): Likewise.
4276         (minimal_language_defn): Likewise.
4277         * d-lang.c (d_language_defn): Likewise.
4278         * f-lang.c (f_language_defn): Likewise.
4279         * go-lang.c (go_language_defn): Likewise.
4280         * language.c (unknown_language_defn): Likewise.
4281         (auto_language_defn): Likewise.
4282         * m2-lang.c (m2_language_defn): Likewise.
4283         * objc-lang.c (objc_language_defn): Likewise.
4284         * opencl-lang.c (opencl_language_defn): Likewise.
4285         * p-lang.c (pascal_language_defn): Likewise.
4286         * rust-lang.c (rust_language_defn): Likewise.
4287
4288 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4289
4290         * ada-lang.c (ada_is_character_type): Change return type to bool.
4291         (ada_is_string_type): Likewise.
4292         * ada-lang.h (ada_is_character_type): Update declaration
4293         (ada_is_string_type): Likewise.
4294
4295 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4296
4297         Support style in 'frame|thread apply'
4298
4299         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4300         * record.c (record_start, record_stop): Update callers of
4301         execute_command_to_string with false.
4302         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4303         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4304         methods.
4305         (class string_file): New constructor with term_out parameter.
4306         Override methods term_out and can_emit_style_escape.  New member
4307         term_out.
4308         (class stdio_file): Override can_emit_style_escape.
4309         (class tee_file): Override term_out and can_emit_style_escape.
4310         * utils.h (can_emit_style_escape): Remove.
4311         * utils.c (can_emit_style_escape): Likewise.
4312         Update all callers of can_emit_style_escape (SOMESTREAM) to
4313         SOMESTREAM->can_emit_style_escape.
4314         * source-cache.c (source_cache::get_source_lines): Likewise.
4315         * stack.c (frame_apply_command_count): Call execute_command_to_string
4316         passing the term_out characteristic of the current gdb_stdout.
4317         * thread.c (thr_try_catch_cmd): Likewise.
4318         * top.c (execute_command_to_string): pass term_out parameter
4319         to construct the string_file for the command output.
4320         * ui-file.c (term_cli_styling): New function (most code moved
4321         from utils.c can_emit_style_escape).
4322         (string_file::string_file, string_file::can_emit_style_escape,
4323         stdio_file::can_emit_style_escape, tee_file::term_out,
4324         tee_file::can_emit_style_escape): New functions.
4325
4326 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4327
4328         * NEWS: Mention the new set|show may-call-functions.
4329         * infcall.c (may_call_functions_p): New variable.
4330         (show_may_call_functions_p): New function.
4331         (call_function_by_hand_dummy): Throws an error if not
4332         may-call-functions.
4333         (_initialize_infcall): Call add_setshow_boolean_cmd for
4334         may-call-functions.
4335
4336 2019-04-25  Keith Seitz  <keiths@redhat.com>
4337
4338         PR c++/24367
4339         * cp-support.c (inspect_type): Don't attempt substitutions
4340         of symbol with the same name.
4341
4342 2019-04-25  Tom Tromey  <tromey@adacore.com>
4343
4344         PR gdb/24475:
4345         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4346         static.
4347
4348 2019-04-25  Tom Tromey  <tromey@adacore.com>
4349
4350         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4351         rvalue reference.
4352         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4353         (gdb_xml_parser::parse): Use std::move.
4354         * python/python-internal.h (gdbpy_convert_exception): Take a const
4355         reference.
4356         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4357         std::move.
4358         * python/py-utils.c (gdbpy_convert_exception): Take a const
4359         reference.
4360         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4361         Use std::move.
4362         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4363         Use std::move.
4364         * mi/mi-main.c (mi_print_exception): Take a const reference.
4365         * main.c (handle_command_errors): Take a const reference.
4366         * linespec.c (parse_linespec): Use std::move.
4367         * infcall.c (run_inferior_call): Use std::move.
4368         (call_function_by_hand_dummy): Use std::move.
4369         * exec.c (try_open_exec_file): Use std::move.
4370         * exceptions.h (exception_print, exception_fprintf)
4371         (exception_print_same): Update.
4372         * exceptions.c (print_exception, exception_print)
4373         (exception_fprintf, exception_print_same): Change parameters to
4374         const reference.
4375         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4376         * common/new-op.c: Use std::move.
4377         * common/common-exceptions.h (struct gdb_exception): Add move
4378         constructor.
4379         (struct gdb_exception_error, struct gdb_exception_quit, struct
4380         gdb_quit_bad_alloc): Change constructor to move constructor.
4381         (throw_exception): Change parameter to rvalue reference.
4382         * common/common-exceptions.c (throw_exception): Take rvalue
4383         reference.
4384         * cli/cli-interp.c (safe_execute_command): Use std::move.
4385         * breakpoint.c (insert_bp_location, location_to_sals): Use
4386         std::move.
4387
4388 2019-04-25  Tom Tromey  <tromey@adacore.com>
4389
4390         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4391         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4392         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4393         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4394         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4395         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4396         guile/scm-value.c: Use unpack.
4397         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4398         gdbscm_gdb_exception.
4399         (gdbscm_throw_gdb_exception): Likewise.
4400         (struct gdbscm_gdb_exception): New.
4401         (unpack): New function.
4402         (gdbscm_wrap): Use unpack.
4403
4404 2019-04-25  Tom Tromey  <tromey@adacore.com>
4405
4406         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4407         (gdb_rl_callback_handler): Use std::move.
4408         * common/common-exceptions.h (struct gdb_exception): Add move
4409         assignment operator.
4410         (throw_exception_sjlj): Change "exception" to const reference.
4411         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4412         (throw_exception_sjlj): Change "exception" to const reference.
4413
4414 2019-04-25  Tom Tromey  <tromey@adacore.com>
4415
4416         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4417         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4418         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4419         Update.
4420         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4421         Update.
4422         * mi/mi-interp.c (mi_interp::exec): Update.
4423         * linespec.c (parse_linespec): Update.
4424         * infcall.c (run_inferior_call): Update.
4425         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4426         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4427         (gdbscm_lookup_global_symbol): Update.
4428         * guile/scm-param.c (gdbscm_parameter_value): Update.
4429         * guile/scm-frame.c (gdbscm_frame_read_register)
4430         (gdbscm_frame_read_var): Update.
4431         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4432         * exec.c (try_open_exec_file): Update.
4433         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4434         (gdb_rl_callback_handler): Update.
4435         * common/common-exceptions.h (exception_none): Don't declare.
4436         * common/common-exceptions.c (exception_none): Don't define.
4437         (struct catcher) <exception>: Update.
4438         * cli/cli-interp.c (safe_execute_command): Update.
4439         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4440
4441 2019-04-25  Ali Tamur  <tamur@google.com>
4442
4443         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4444         (read_attribute_value): Likewise.
4445         (dwarf2_read_addr_index): Update comment.
4446         (read_str_index): Add DW_FORM_strx.
4447         (dwarf2_string_attr): Likewise.
4448         (dwarf2_const_value_attr): Likewise.
4449         (dump_die_shallow): Likewise.
4450         (dwarf2_fetch_constant_bytes): Likewise.
4451         (skip_form_bytes): Likewise.
4452         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4453
4454 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4455
4456         PR corefiles/11608
4457         PR corefiles/18187
4458         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4459         OFFSET.  Verify if current mapping contains an ELF header.
4460         (linux_find_memory_regions_full): Adjust call to
4461         dump_mapping_p.
4462
4463 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4464             Kang Li <kanglictf@gmail.com>
4465
4466         PR gdb/21600
4467
4468         * dwarf2-frame.c (read_initial_length): Be consistent about using
4469         unsigned representation of length.
4470         (decode_frame_entry_1): Likewise.  Check for wraparound of
4471         end pointer as well as buffer overflow.
4472
4473 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4474
4475         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4476         "vq".
4477
4478 2019-04-24  Tom Tromey  <tromey@adacore.com>
4479
4480         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4481
4482 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4483
4484         * s12z-tdep.c (s12z_unwind_pc): Delete.
4485         (s12z_unwind_sp): Delete.
4486         (s12z_gdbarch_init): Don't register deleted functions with
4487         gdbarch.
4488
4489 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4490
4491         * rl78-tdep.c (rl78_unwind_sp): Delete.
4492         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4493
4494 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4495
4496         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4497         (xstormy16_unwind_pc): Delete.
4498         (xstormy16_dummy_id): Delete.
4499         (xstormy16_gdbarch_init): Don't register deleted functions with
4500         gdbarch.
4501
4502 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4503
4504         * vax-tdep.c (vax_unwind_pc): Delete.
4505         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4506
4507 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4508
4509         * v850-tdep.c (v850_unwind_sp): Delete.
4510         (v850_unwind_pc): Delete.
4511         (v850_dummy_id): Delete.
4512         (v850_gdbarch_init): Don't register deleted functions with
4513         gdbarch.
4514
4515 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4516
4517         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4518         (tilegx_unwind_pc): Delete.
4519         (tilegx_unwind_dummy_id): Delete.
4520         (tilegx_gdbarch_init): Don't register deleted functions with
4521         gdbarch.
4522
4523 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4524
4525         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4526         (tic6x_dummy_id): Delete.
4527         (tic6x_gdbarch_init): Don't register deleted functions with
4528         gdbarch.
4529
4530 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4531
4532         * sparc-tdep.c (sparc_unwind_pc): Delete.
4533         (sparc32_gdbarch_init): Don't register deleted function with
4534         gdbarch.
4535
4536 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4537
4538         * sh-tdep.c (sh_unwind_sp): Delete.
4539         (sh_unwind_pc): Delete.
4540         (sh_dummy_id): Delete.
4541         (sh_gdbarch_init): Don't register deleted functions with
4542         gdbarch.
4543
4544 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4545
4546         * score-tdep.c (score_unwind_sp): Delete.
4547         (score_unwind_pc): Delete.
4548         (score_dummy_id): Delete.
4549         (score_gdbarch_init): Don't register deleted functions with
4550         gdbarch.
4551
4552 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4553
4554         * rx-tdep.c (rx_unwind_pc): Delete.
4555         (rx_unwind_sp): Delete.
4556         (rx_dummy_id): Delete.
4557         (rx_gdbarch_init): Don't register deleted functions with
4558         gdbarch.  Update comment.
4559
4560 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4561
4562         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4563         (rs6000_dummy_id): Delete.
4564         (rs6000_gdbarch_init): Don't register deleted functions with
4565         gdbarch.
4566
4567 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4568
4569         * or1k-tdep.c (or1k_dummy_id): Delete.
4570         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4571
4572 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4573
4574         * nios2-tdep.c (nios2_dummy_id): Delete.
4575         (nios2_unwind_sp): Delete.
4576         (nios2_gdbarch_init): Don't register deleted functions with
4577         gdbarch.
4578
4579 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4580
4581         * nds32-tdep.c (nds32_dummy_id): Delete.
4582         (nds32_unwind_pc): Delete.
4583         (nds32_unwind_sp): Delete.
4584         (nds32_gdbarch_init): Don't register deleted functions with
4585         gdbarch.
4586
4587 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4588
4589         * msp430-tdep.c (msp430_unwind_pc): Delete.
4590         (msp430_unwind_sp): Delete.
4591         (msp430_dummy_id): Delete.
4592         (msp430_gdbarch_init): Don't register deleted functions with
4593         gdbarch.
4594
4595 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4596
4597         * moxie-tdep.c (moxie_unwind_sp): Delete.
4598         (moxie_unwind_pc): Delete.
4599         (moxie_dummy_id): Delete.
4600         (moxie_gdbarch_init): Don't register deleted functions with
4601         gdbarch.
4602
4603 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4604
4605         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4606         (mn10300_unwind_pc): Delete.
4607         (mn10300_unwind_sp): Delete.
4608         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4609         mn10300_unwind_sp.
4610         (mn10300_frame_unwind_init): Don't register deleted functions with
4611         gdbarch.
4612
4613 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4614
4615         * mep-tdep.c (mep_unwind_pc): Delete.
4616         (mep_unwind_sp): Delete.
4617         (mep_dummy_id): Delete.
4618         (mep_gdbarch_init): Don't register deleted functions with
4619         gdbarch.
4620
4621 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4622
4623         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4624         (m68hc11_unwind_sp): Delete.
4625         (m68hc11_gdbarch_init): Don't register deleted functions with
4626         gdbarch.
4627
4628 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4629
4630         * m32r-tdep.c (m32r_unwind_sp): Delete.
4631         (m32r_unwind_pc): Delete.
4632         (m32r_dummy_id): Delete.
4633         (m32r_gdbarch_init): Don't register deleted functions with
4634         gdbarch.
4635
4636 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4637
4638         * m32c-tdep.c (m32c_unwind_pc): Delete.
4639         (m32c_unwind_sp): Delete.
4640         (m32c_dummy_id): Delete.
4641         (m32c_gdbarch_init): Don't register deleted functions with
4642         gdbarch.
4643
4644 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4645
4646         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4647         (lm32_unwind_pc): Delete.
4648         (lm32_dummy_id): Delete.
4649         (lm32_gdbarch_init): Don't register deleted functions with
4650         gdbarch.
4651
4652 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4653
4654         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4655         (iq2000_unwind_pc): Delete.
4656         (iq2000_dummy_id): Delete.
4657         (iq2000_gdbarch_init): Don't register deleted functions with
4658         gdbarch.
4659
4660 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4661
4662         * nds32-tdep.c (nds32_type_align): Delete.
4663         (nds32_push_dummy_call): Use type_align instead.
4664
4665 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4666
4667         * arm-tdep.c (arm_type_align): Only handle vector override case.
4668         (arm_push_dummy_call): Use type_align.
4669         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4670
4671 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4672
4673         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4674         case.
4675         (pass_on_stack): Use type_align.
4676         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4677         function.
4678
4679 2019-04-23  Tom Tromey  <tromey@adacore.com>
4680
4681         * dwarf2read.c (line_header::file_name_at): Remove unused
4682         overload.
4683
4684 2019-04-23  Tom de Vries  <tdevries@suse.de>
4685
4686         PR gdb/24438
4687         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4688         invocation.
4689
4690
4691 2019-03-27  Ali Tamur  <tamur@google.com>
4692
4693         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4694         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4695         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4696         (dwarf_expr_context::get_addr_index): Likewise
4697         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4698         (symbol_needs_eval_context::get_addr_index): Likewise
4699         (disassemble_dwarf_expression): Add DW_OP_addrx
4700         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4701         (read_cutu_die_from_dwo): Update comment
4702         (skip_one_die): Add DW_FORM_addrx
4703         (read_attribute_value): Likewise
4704         (var_decode_location): Add DW_OP_addrx
4705         (dwarf2_const_value_attr): Add DW_FORM_addrx
4706         (dump_die_shallow): Likewise
4707         (dwarf2_fetch_constant_bytes): Likewise
4708         (decode_locdesc): Add DW_OP_addrx
4709         (skip_form_bytes): Add DW_FORM_addrx
4710
4711 2019-04-22  Ali Tamur  <tamur@google.com>
4712
4713         * MAINTAINERS (Write After Approval): Add self.
4714
4715 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4716
4717         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4718         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4719         (open_symbol_file_object): Likewise.
4720         (svr4_default_sos): Add info parameter.
4721         (svr4_read_so_list): Likewise.
4722         (svr4_current_sos_direct): Adjust functions calls to pass down
4723         info.
4724         (svr4_current_sos_1): Add info parameter.
4725         (svr4_current_sos): Call get_svr4_info, pass info down to
4726         svr4_current_sos_1.
4727         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4728         get_svr4_info.
4729         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4730         get_svr4_info.
4731         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4732         to get_svr4_info.
4733         (probes_table_remove_objfile_probes): Likewise.
4734         (register_solib_event_probe): Add info parameter.
4735         (solist_update_incremental): Pass info parameter down to
4736         svr4_read_so_list.
4737         (disable_probes_interface): Add info parameter.
4738         (svr4_handle_solib_event): Pass current_program_space to
4739         get_svr4_info.  Adjust disable_probes_interface cleanup.
4740         (svr4_create_probe_breakpoints): Add info parameter, pass it
4741         down to register_solib_event_probe.
4742         (svr4_create_solib_event_breakpoints): Add info parameter,
4743         pass it down to svr4_create_probe_breakpoints.
4744         (enable_break): Pass info down to
4745         svr4_create_solib_event_breakpoints.
4746         (svr4_solib_create_inferior_hook): Pass current_program_space to
4747         get_svr4_info.
4748         (svr4_clear_solib): Likewise.
4749
4750 2019-04-22  Pedro Alves  <palves@redhat.com>
4751
4752         * solib-svr4.c (svr4_free_objfile_observer): New.
4753         (probe_and_action::objfile): New field.
4754         (probes_table_htab_remove_objfile_probes)
4755         (probes_table_remove_objfile_probes): New functions.
4756         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4757         in the new probe_and_action.  Don't store the probe in 'lookup'.
4758         (svr4_create_probe_breakpoints): Pass objfile to
4759         register_solib_event_probe.
4760         (_initialize_svr4_solib): Register a free_objfile observer.
4761
4762 2019-04-19  Tom Tromey  <tom@tromey.com>
4763
4764         * common/queue.h: Remove.
4765
4766 2019-04-19  Tom Tromey  <tom@tromey.com>
4767
4768         * event-loop.c: Don't include "common/queue.h".
4769
4770 2019-04-19  Tom Tromey  <tom@tromey.com>
4771
4772         * remote.c (remote_target): Use delete.
4773         * remote-notif.h: Include <list>, not "common/queue.h".
4774         (notif_client_p): Remove typedef.
4775         (remote_notif_state): Add constructor, destructor, initializer.
4776         <notif_queue>: Now a std::list.
4777         (remote_notif_state_xfree): Don't declare.
4778         * remote-notif.c (remote_notif_process, handle_notification)
4779         (remote_notif_state_allocate): Update.
4780         (~remote_notif_state): Rename from remote_notif_state_xfree.
4781
4782 2019-04-19  Tom Tromey  <tom@tromey.com>
4783
4784         * symfile.c (reread_symbols): Update.
4785         * objfiles.c (objfile_register_static_link)
4786         (objfile_lookup_static_link): Update
4787         (~objfile) Don't delete static_links.
4788         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4789
4790 2019-04-19  Tom Tromey  <tom@tromey.com>
4791
4792         * type-stack.h (struct type_stack) <insert>: Constify string.
4793         * type-stack.c (type_stack::insert): Constify string.
4794         * gdbtypes.h (lookup_template_type): Update.
4795         (address_space_name_to_int): Update.
4796         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4797         const.
4798         (lookup_template_type): Make name const.
4799         * c-exp.y: Update rules.
4800         (lex_one_token, classify_name, classify_inner_name)
4801         (c_print_token): Update.
4802         * p-exp.y: Update rules.
4803         (yylex): Update.
4804         * f-exp.y: Update rules.
4805         (yylex): Update.
4806         * d-exp.y: Update rules.
4807         (lex_one_token, classify_name, classify_inner_name): Update.
4808         * parse.c (write_dollar_variable, copy_name): Return std::string.
4809         * parser-defs.h (copy_name): Change return type.
4810         * m2-exp.y: Update rules.
4811         (yylex): Update.
4812         * go-exp.y (lex_one_token): Update.
4813         Update rules.
4814         (classify_unsafe_function, classify_packaged_name)
4815         (classify_name, yylex): Update.
4816
4817 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4818
4819         * configure.ac: add --enable-source-highlight switch.
4820         * configure: Regenerate.
4821         * top.c (print_gdb_version): plumb --enable-source-highlight
4822         status to "show configuration".
4823
4824 2019-04-19  Tom Tromey  <tromey@adacore.com>
4825
4826         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4827         Check ADA_TYPE_P.
4828         (empty_record, ada_template_to_fixed_record_type_1)
4829         (template_to_static_fixed_type)
4830         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4831         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4832         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4833         macros.
4834
4835 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4836
4837         PR symtab/24423:
4838         * source.c (print_source_lines_base): Advance "iter" when a
4839         control character is seen.
4840
4841 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4842
4843         * inferior.h (struct infcall_suspend_state_deleter):
4844         Catch exception in destructor to avoid crash.
4845
4846 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4847
4848         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4849         close to the add_com "shell".
4850
4851 2019-04-18  Tom Tromey  <tromey@adacore.com>
4852
4853         * process-stratum-target.h (class process_stratum_target)
4854         <stratum>: Add "final".
4855
4856 2019-04-17  Tom Tromey  <tromey@adacore.com>
4857
4858         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4859         against nullptr before use.
4860
4861 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4862
4863         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4864
4865 2019-04-17  Jim Wilson  <jimw@sifive.com>
4866             Andrew Burgess  <andrew.burgess@embecosm.com>
4867
4868         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4869         code read might fail, assume 4-byte breakpoint in that case.
4870
4871 2019-04-15  Leszek Swirski  <leszeks@google.com>
4872
4873         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4874         rather than a hand-rolled POD check when checking for forced MEMORY
4875         classification.
4876
4877 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4878
4879         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4880         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4881         function.
4882         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4883         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4884         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4885         declaration.
4886
4887 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4888
4889         * aarch64-linux-nat.c
4890         (aarch64_linux_nat_target::thread_architecture): Add override.
4891         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4892         each VQ.
4893
4894 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4895
4896         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4897
4898 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4899
4900         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4901         target types of size 96-bits, add some additional comments, and
4902         check that the builtin type we found was the correct size.
4903
4904 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4905
4906         * utils.c (prompt_for_continue): Don't restore the styling at the
4907         end, as applied_style has the wrong value.  This fixes styling in
4908         long lists of file names that are interrupted by the "Continue?"
4909         prompt.
4910
4911 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4912
4913         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4914         * c-lang.c (c_language_defn): Likewise.
4915         (cplus_language_defn): Likewise.
4916         (asm_language_defn): Likewise.
4917         (minimal_language_defn): Likewise.
4918         * d-lang.c (d_language_defn): Likewise.
4919         * f-lang.c (f_language_defn): Likewise.
4920         * go-lang.c (go_language_defn): Likewise.
4921         * language.c (unknown_language_defn): Likewise.
4922         (auto_language_defn): Likewise.
4923         * language.h (struct language_defn): Remove la_magic field.
4924         (LANG_MAGIC): Delete.
4925         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4926         * objc-lang.c (objc_language_defn): Likewise.
4927         * opencl-lang.c (opencl_language_defn): Likewise.
4928         * p-lang.c (pascal_language_defn): Likewise.
4929         * rust-lang.c (rust_language_defn): Likewise.
4930
4931 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4932
4933         * riscv-tdep.c (riscv_type_align): New function.
4934         (riscv_type_alignment): Delete.
4935         (riscv_arg_location): Use 'type_align'.
4936         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4937
4938 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4939
4940         * gdbtypes.c (type_align): A struct with no non-static fields also
4941         has alignment of 1.
4942
4943 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4944
4945         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4946         component to 0.
4947         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4948         member.
4949         (riscv_struct_info::analyse): New implementation using new
4950         analyse_inner member function.
4951         (riscv_struct_info::field_offset): New member function.
4952         (riscv_struct_info::m_offsets): New member variable.
4953         (riscv_struct_info::analyse_inner): New private member function,
4954         takes the old implementation of riscv_struct_info::analyse but
4955         extended to track field offsets.
4956         (riscv_call_arg_struct): Update the struct folding special cases
4957         to handle cases where empty C++ structs, which are non-zero
4958         length, are found.
4959         (riscv_arg_location): Initialise the length of each location, a
4960         non-zero length now indicates the location is in use.
4961         (riscv_push_dummy_call): Allow for the first location having a
4962         non-zero offset when setting up arguments.
4963         (riscv_return_value): Likewise, but for return values.
4964
4965 2019-04-11  Tom Tromey  <tromey@adacore.com>
4966
4967         * utils.c (internal_vproblem): Make "msg" const.
4968
4969 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4970
4971         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4972         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4973         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4974         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4975
4976 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4977
4978         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4979         function.
4980         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4981         of amd64_collect_native_gregset.
4982         (amd64_linux_nat_target::store_registers): Likewise.
4983
4984 2019-04-10  Tom Tromey  <tom@tromey.com>
4985
4986         * symtab.c (lookup_global_symbol_from_objfile)
4987         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4988         * objfiles.h (class separate_debug_iterator): New.
4989         (class separate_debug_range): New.
4990         (struct objfile) <separate_debug_objfiles>: New method.
4991         (objfile_separate_debug_iterate): Don't declare.
4992         * objfiles.c (separate_debug_iterator::operator++): Rename from
4993         objfile_separate_debug_iterate.
4994         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4995         iterator.
4996         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4997         iterator.
4998
4999 2019-04-10  Tom Tromey  <tom@tromey.com>
5000
5001         * symfile.c (reread_symbols): Remove old comment.
5002         * objfiles.c (free_all_objfiles): Fix a typo.
5003
5004 2019-04-10  Tom Tromey  <tom@tromey.com>
5005
5006         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5007         * minsyms.c (lookup_minimal_symbol): Use foreach.
5008         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5009         (lookup_minimal_symbol_solib_trampoline): Likewise.
5010         * symfile.c (reread_symbols): Use foreach.
5011
5012 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5013             Tom Tromey  <tromey@adacore.com>
5014
5015         PR rust/24414:
5016         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5017         (rust_lex_int_test): Change "value" to be LONGEST.
5018         (rust_lex_tests): Add test for long integer literal.
5019
5020 2019-04-09  Tom Tromey  <tromey@adacore.com>
5021
5022         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5023         to bool.
5024         (extended_remote_target::attach): Update.
5025         (remote_target::remote_notice_new_inferior): Update.
5026         (remote_target::add_current_inferior_and_thread): Update.
5027         * inferior.c (exit_inferior_1): Use "false".
5028         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5029
5030 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5031
5032         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5033         the "start" command.
5034
5035 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5036
5037         * python/py-inferior.c (infpy_thread_from_thread_handle):
5038         Adjust comments to reflect renaming of thread_from_thread_handle
5039         to thread_from_handle.  Adjust keywords.  Fix type error message.
5040         (inferior_object_methods): Add thread_from_handle.  Retain
5041         thread_from_thread_handle, but mark it as deprecated.
5042
5043 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5044
5045         * gdbthread.h (find_thread_by_handle): Revise declaration.
5046         * thread.c (find_thread_by_handle): Likewise.  Adjust
5047         implementation too.
5048         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5049         support for buffer objects as handles.
5050
5051 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5052
5053         * python/py-infthread.c (thpy_thread_handle): New function.
5054         (thread_object_methods): Register thpy_thread_handle.
5055
5056 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5057
5058         * gdbthread.h (thread_to_thread_handle): Declare.
5059         * thread.c (gdbtypes.h): Include.
5060         (thread_to_thread_handle): New function.
5061
5062         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5063         (target_thread_info_to_thread_handle): Declare.
5064         * target.c (target_thread_info_to_thread_handle): New function.
5065         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5066         * target-delegates.c: Regenerate.
5067
5068         * linux-thread-db.c (class thread_db_target): Add method
5069         thread_info_to_thread_handle.
5070         (thread_db_target::thread_info_to_thread_handle): Define.
5071         * remote.c (class remote_target): Add new method
5072         thread_info_to_thread_handle.
5073         (remote_target::thread_info_to_thread_handle): Define.
5074
5075 2019-04-08  Pedro Alves  <palves@redhat.com>
5076
5077         * common/common-exceptions.c (throw_exception): Don't create
5078         named object to throw; throw directly.
5079         (throw_it): Likewise.  Don't initialize gdb_exception::message
5080         here, with new; pass FMT and AP to the ctor instead.
5081         * common/common-exceptions.h: Include <string>.
5082         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5083         const char *, va_list)): New ctor.  Use std::make_shared.
5084         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5085         errors)): Delete.
5086         (gdb_exception_error::gdb_exception_error(enum errors, const char
5087         *, va_list)): New.
5088         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5089         Add assertion.
5090         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5091         errors)): Delete.
5092         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5093         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5094         Add assertion.
5095
5096 2019-04-08  Tom Tromey  <tom@tromey.com>
5097
5098         * valops.c (value_rtti_indirect_type): Replace throw_exception
5099         with throw.
5100         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5101         with throw.
5102         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5103         throw.
5104         * target.c (target_translate_tls_address): Replace throw_exception
5105         with throw.
5106         * stack.c (frame_apply_command_count): Replace throw_exception
5107         with throw.
5108         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5109         throw.
5110         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5111         with throw.
5112         * rs6000-tdep.c (rs6000_frame_cache)
5113         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5114         * remote.c: Replace throw_exception with throw.
5115         * record-full.c (record_full_message, record_full_wait_1)
5116         (record_full_restore): Replace throw_exception with throw.
5117         * record-btrace.c:
5118         (get_thread_current_frame_id, record_btrace_start_replaying)
5119         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5120         (cmd_record_btrace_start): Replace throw_exception with throw.
5121         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5122         throw.
5123         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5124         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5125         * linespec.c:
5126         (find_linespec_symbols): Replace throw_exception with throw.
5127         * infrun.c (displaced_step_prepare, resume): Replace
5128         throw_exception with throw.
5129         * infcmd.c (post_create_inferior): Replace throw_exception with
5130         throw.
5131         * inf-loop.c (inferior_event_handler): Replace throw_exception
5132         with throw.
5133         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5134         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5135         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5136         (get_prev_frame_always, get_frame_pc_if_available)
5137         (get_frame_address_in_block_if_available, get_frame_language):
5138         Replace throw_exception with throw.
5139         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5140         throw_exception with throw.
5141         * eval.c (fetch_subexp_value, evaluate_var_value)
5142         (evaluate_funcall, evaluate_subexp_standard): Replace
5143         throw_exception with throw.
5144         * dwarf2loc.c (call_site_find_chain)
5145         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5146         Replace throw_exception with throw.
5147         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5148         with throw.
5149         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5150         throw.
5151         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5152         * completer.c (complete_line_internal): Replace throw_exception
5153         with throw.
5154         * compile/compile-object-run.c (compile_object_run): Replace
5155         throw_exception with throw.
5156         * cli/cli-script.c (process_next_line): Replace throw_exception
5157         with throw.
5158         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5159         (btrace_enable, btrace_maint_update_pt_packets): Replace
5160         throw_exception with throw.
5161         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5162         throw_exception with throw.
5163         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5164         throw_exception with throw.
5165         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5166         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5167         * aarch64-tdep.c (aarch64_make_prologue_cache)
5168         (aarch64_make_stub_cache): Replace throw_exception with throw.
5169
5170 2019-04-08  Tom Tromey  <tom@tromey.com>
5171
5172         * common/common-exceptions.c (throw_exception): Rename from
5173         throw_exception_cxx.  Remove old copy.  Make argument const.
5174         (throw_it): Create and throw exception objects directly.
5175         * common/common-exceptions.h (throw_exception): Make argument
5176         const.
5177         (struct gdb_exception_error): Add constructor.
5178         (struct gdb_exception_quit): Add constructor.
5179
5180 2019-04-08  Tom Tromey  <tom@tromey.com>
5181
5182         * common/common-exceptions.h (exception_rethrow): Don't declare.
5183         (TRY_SJLJ): Update comment.
5184         (TRY, CATCH, END_CATCH): Remove.
5185         * common/common-exceptions.c (exception_rethrow): Remove.
5186
5187 2019-04-08  Tom Tromey  <tom@tromey.com>
5188
5189         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5190         Remove.
5191         (gdb_exception_error): Rename from
5192         gdb_exception_RETURN_MASK_ERROR.
5193         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5194         (gdb_quit_bad_alloc): Update.
5195         * aarch64-tdep.c: Update.
5196         * ada-lang.c: Update.
5197         * ada-typeprint.c: Update.
5198         * ada-valprint.c: Update.
5199         * amd64-tdep.c: Update.
5200         * arch-utils.c: Update.
5201         * break-catch-throw.c: Update.
5202         * breakpoint.c: Update.
5203         * btrace.c: Update.
5204         * c-varobj.c: Update.
5205         * cli/cli-cmds.c: Update.
5206         * cli/cli-interp.c: Update.
5207         * cli/cli-script.c: Update.
5208         * common/common-exceptions.c: Update.
5209         * common/new-op.c: Update.
5210         * common/selftest.c: Update.
5211         * compile/compile-c-symbols.c: Update.
5212         * compile/compile-cplus-symbols.c: Update.
5213         * compile/compile-object-load.c: Update.
5214         * compile/compile-object-run.c: Update.
5215         * completer.c: Update.
5216         * corelow.c: Update.
5217         * cp-abi.c: Update.
5218         * cp-support.c: Update.
5219         * cp-valprint.c: Update.
5220         * darwin-nat.c: Update.
5221         * disasm-selftests.c: Update.
5222         * dtrace-probe.c: Update.
5223         * dwarf-index-cache.c: Update.
5224         * dwarf-index-write.c: Update.
5225         * dwarf2-frame-tailcall.c: Update.
5226         * dwarf2-frame.c: Update.
5227         * dwarf2loc.c: Update.
5228         * dwarf2read.c: Update.
5229         * eval.c: Update.
5230         * event-loop.c: Update.
5231         * event-top.c: Update.
5232         * exec.c: Update.
5233         * f-valprint.c: Update.
5234         * fbsd-tdep.c: Update.
5235         * frame-unwind.c: Update.
5236         * frame.c: Update.
5237         * gdbtypes.c: Update.
5238         * gnu-v3-abi.c: Update.
5239         * guile/guile-internal.h: Update.
5240         * guile/scm-block.c: Update.
5241         * guile/scm-breakpoint.c: Update.
5242         * guile/scm-cmd.c: Update.
5243         * guile/scm-disasm.c: Update.
5244         * guile/scm-frame.c: Update.
5245         * guile/scm-lazy-string.c: Update.
5246         * guile/scm-math.c: Update.
5247         * guile/scm-param.c: Update.
5248         * guile/scm-ports.c: Update.
5249         * guile/scm-pretty-print.c: Update.
5250         * guile/scm-symbol.c: Update.
5251         * guile/scm-symtab.c: Update.
5252         * guile/scm-type.c: Update.
5253         * guile/scm-value.c: Update.
5254         * i386-linux-tdep.c: Update.
5255         * i386-tdep.c: Update.
5256         * inf-loop.c: Update.
5257         * infcall.c: Update.
5258         * infcmd.c: Update.
5259         * infrun.c: Update.
5260         * jit.c: Update.
5261         * language.c: Update.
5262         * linespec.c: Update.
5263         * linux-fork.c: Update.
5264         * linux-nat.c: Update.
5265         * linux-tdep.c: Update.
5266         * linux-thread-db.c: Update.
5267         * main.c: Update.
5268         * mi/mi-cmd-break.c: Update.
5269         * mi/mi-cmd-stack.c: Update.
5270         * mi/mi-interp.c: Update.
5271         * mi/mi-main.c: Update.
5272         * objc-lang.c: Update.
5273         * p-valprint.c: Update.
5274         * parse.c: Update.
5275         * ppc-linux-tdep.c: Update.
5276         * printcmd.c: Update.
5277         * python/py-arch.c: Update.
5278         * python/py-breakpoint.c: Update.
5279         * python/py-cmd.c: Update.
5280         * python/py-finishbreakpoint.c: Update.
5281         * python/py-frame.c: Update.
5282         * python/py-framefilter.c: Update.
5283         * python/py-gdb-readline.c: Update.
5284         * python/py-inferior.c: Update.
5285         * python/py-infthread.c: Update.
5286         * python/py-lazy-string.c: Update.
5287         * python/py-linetable.c: Update.
5288         * python/py-objfile.c: Update.
5289         * python/py-param.c: Update.
5290         * python/py-prettyprint.c: Update.
5291         * python/py-progspace.c: Update.
5292         * python/py-record-btrace.c: Update.
5293         * python/py-record.c: Update.
5294         * python/py-symbol.c: Update.
5295         * python/py-type.c: Update.
5296         * python/py-unwind.c: Update.
5297         * python/py-utils.c: Update.
5298         * python/py-value.c: Update.
5299         * python/python.c: Update.
5300         * record-btrace.c: Update.
5301         * record-full.c: Update.
5302         * remote-fileio.c: Update.
5303         * remote.c: Update.
5304         * riscv-tdep.c: Update.
5305         * rs6000-aix-tdep.c: Update.
5306         * rs6000-tdep.c: Update.
5307         * rust-exp.y: Update.
5308         * rust-lang.c: Update.
5309         * s390-tdep.c: Update.
5310         * selftest-arch.c: Update.
5311         * solib-dsbt.c: Update.
5312         * solib-frv.c: Update.
5313         * solib-spu.c: Update.
5314         * solib-svr4.c: Update.
5315         * solib.c: Update.
5316         * sparc64-linux-tdep.c: Update.
5317         * stack.c: Update.
5318         * symfile-mem.c: Update.
5319         * symmisc.c: Update.
5320         * target.c: Update.
5321         * thread.c: Update.
5322         * top.c: Update.
5323         * tracefile-tfile.c: Update.
5324         * tui/tui.c: Update.
5325         * typeprint.c: Update.
5326         * unittests/cli-utils-selftests.c: Update.
5327         * unittests/parse-connection-spec-selftests.c: Update.
5328         * valops.c: Update.
5329         * valprint.c: Update.
5330         * value.c: Update.
5331         * varobj.c: Update.
5332         * windows-nat.c: Update.
5333         * x86-linux-nat.c: Update.
5334         * xml-support.c: Update.
5335
5336 2019-04-08  Tom Tromey  <tom@tromey.com>
5337
5338         * xml-support.c: Use C++ exception handling.
5339         * x86-linux-nat.c: Use C++ exception handling.
5340         * windows-nat.c: Use C++ exception handling.
5341         * varobj.c: Use C++ exception handling.
5342         * value.c: Use C++ exception handling.
5343         * valprint.c: Use C++ exception handling.
5344         * valops.c: Use C++ exception handling.
5345         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5346         handling.
5347         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5348         * typeprint.c: Use C++ exception handling.
5349         * tui/tui.c: Use C++ exception handling.
5350         * tracefile-tfile.c: Use C++ exception handling.
5351         * top.c: Use C++ exception handling.
5352         * thread.c: Use C++ exception handling.
5353         * target.c: Use C++ exception handling.
5354         * symmisc.c: Use C++ exception handling.
5355         * symfile-mem.c: Use C++ exception handling.
5356         * stack.c: Use C++ exception handling.
5357         * sparc64-linux-tdep.c: Use C++ exception handling.
5358         * solib.c: Use C++ exception handling.
5359         * solib-svr4.c: Use C++ exception handling.
5360         * solib-spu.c: Use C++ exception handling.
5361         * solib-frv.c: Use C++ exception handling.
5362         * solib-dsbt.c: Use C++ exception handling.
5363         * selftest-arch.c: Use C++ exception handling.
5364         * s390-tdep.c: Use C++ exception handling.
5365         * rust-lang.c: Use C++ exception handling.
5366         * rust-exp.y: Use C++ exception handling.
5367         * rs6000-tdep.c: Use C++ exception handling.
5368         * rs6000-aix-tdep.c: Use C++ exception handling.
5369         * riscv-tdep.c: Use C++ exception handling.
5370         * remote.c: Use C++ exception handling.
5371         * remote-fileio.c: Use C++ exception handling.
5372         * record-full.c: Use C++ exception handling.
5373         * record-btrace.c: Use C++ exception handling.
5374         * python/python.c: Use C++ exception handling.
5375         * python/py-value.c: Use C++ exception handling.
5376         * python/py-utils.c: Use C++ exception handling.
5377         * python/py-unwind.c: Use C++ exception handling.
5378         * python/py-type.c: Use C++ exception handling.
5379         * python/py-symbol.c: Use C++ exception handling.
5380         * python/py-record.c: Use C++ exception handling.
5381         * python/py-record-btrace.c: Use C++ exception handling.
5382         * python/py-progspace.c: Use C++ exception handling.
5383         * python/py-prettyprint.c: Use C++ exception handling.
5384         * python/py-param.c: Use C++ exception handling.
5385         * python/py-objfile.c: Use C++ exception handling.
5386         * python/py-linetable.c: Use C++ exception handling.
5387         * python/py-lazy-string.c: Use C++ exception handling.
5388         * python/py-infthread.c: Use C++ exception handling.
5389         * python/py-inferior.c: Use C++ exception handling.
5390         * python/py-gdb-readline.c: Use C++ exception handling.
5391         * python/py-framefilter.c: Use C++ exception handling.
5392         * python/py-frame.c: Use C++ exception handling.
5393         * python/py-finishbreakpoint.c: Use C++ exception handling.
5394         * python/py-cmd.c: Use C++ exception handling.
5395         * python/py-breakpoint.c: Use C++ exception handling.
5396         * python/py-arch.c: Use C++ exception handling.
5397         * printcmd.c: Use C++ exception handling.
5398         * ppc-linux-tdep.c: Use C++ exception handling.
5399         * parse.c: Use C++ exception handling.
5400         * p-valprint.c: Use C++ exception handling.
5401         * objc-lang.c: Use C++ exception handling.
5402         * mi/mi-main.c: Use C++ exception handling.
5403         * mi/mi-interp.c: Use C++ exception handling.
5404         * mi/mi-cmd-stack.c: Use C++ exception handling.
5405         * mi/mi-cmd-break.c: Use C++ exception handling.
5406         * main.c: Use C++ exception handling.
5407         * linux-thread-db.c: Use C++ exception handling.
5408         * linux-tdep.c: Use C++ exception handling.
5409         * linux-nat.c: Use C++ exception handling.
5410         * linux-fork.c: Use C++ exception handling.
5411         * linespec.c: Use C++ exception handling.
5412         * language.c: Use C++ exception handling.
5413         * jit.c: Use C++ exception handling.
5414         * infrun.c: Use C++ exception handling.
5415         * infcmd.c: Use C++ exception handling.
5416         * infcall.c: Use C++ exception handling.
5417         * inf-loop.c: Use C++ exception handling.
5418         * i386-tdep.c: Use C++ exception handling.
5419         * i386-linux-tdep.c: Use C++ exception handling.
5420         * guile/scm-value.c: Use C++ exception handling.
5421         * guile/scm-type.c: Use C++ exception handling.
5422         * guile/scm-symtab.c: Use C++ exception handling.
5423         * guile/scm-symbol.c: Use C++ exception handling.
5424         * guile/scm-pretty-print.c: Use C++ exception handling.
5425         * guile/scm-ports.c: Use C++ exception handling.
5426         * guile/scm-param.c: Use C++ exception handling.
5427         * guile/scm-math.c: Use C++ exception handling.
5428         * guile/scm-lazy-string.c: Use C++ exception handling.
5429         * guile/scm-frame.c: Use C++ exception handling.
5430         * guile/scm-disasm.c: Use C++ exception handling.
5431         * guile/scm-cmd.c: Use C++ exception handling.
5432         * guile/scm-breakpoint.c: Use C++ exception handling.
5433         * guile/scm-block.c: Use C++ exception handling.
5434         * guile/guile-internal.h: Use C++ exception handling.
5435         * gnu-v3-abi.c: Use C++ exception handling.
5436         * gdbtypes.c: Use C++ exception handling.
5437         * frame.c: Use C++ exception handling.
5438         * frame-unwind.c: Use C++ exception handling.
5439         * fbsd-tdep.c: Use C++ exception handling.
5440         * f-valprint.c: Use C++ exception handling.
5441         * exec.c: Use C++ exception handling.
5442         * event-top.c: Use C++ exception handling.
5443         * event-loop.c: Use C++ exception handling.
5444         * eval.c: Use C++ exception handling.
5445         * dwarf2read.c: Use C++ exception handling.
5446         * dwarf2loc.c: Use C++ exception handling.
5447         * dwarf2-frame.c: Use C++ exception handling.
5448         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5449         * dwarf-index-write.c: Use C++ exception handling.
5450         * dwarf-index-cache.c: Use C++ exception handling.
5451         * dtrace-probe.c: Use C++ exception handling.
5452         * disasm-selftests.c: Use C++ exception handling.
5453         * darwin-nat.c: Use C++ exception handling.
5454         * cp-valprint.c: Use C++ exception handling.
5455         * cp-support.c: Use C++ exception handling.
5456         * cp-abi.c: Use C++ exception handling.
5457         * corelow.c: Use C++ exception handling.
5458         * completer.c: Use C++ exception handling.
5459         * compile/compile-object-run.c: Use C++ exception handling.
5460         * compile/compile-object-load.c: Use C++ exception handling.
5461         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5462         * compile/compile-c-symbols.c: Use C++ exception handling.
5463         * common/selftest.c: Use C++ exception handling.
5464         * common/new-op.c: Use C++ exception handling.
5465         * cli/cli-script.c: Use C++ exception handling.
5466         * cli/cli-interp.c: Use C++ exception handling.
5467         * cli/cli-cmds.c: Use C++ exception handling.
5468         * c-varobj.c: Use C++ exception handling.
5469         * btrace.c: Use C++ exception handling.
5470         * breakpoint.c: Use C++ exception handling.
5471         * break-catch-throw.c: Use C++ exception handling.
5472         * arch-utils.c: Use C++ exception handling.
5473         * amd64-tdep.c: Use C++ exception handling.
5474         * ada-valprint.c: Use C++ exception handling.
5475         * ada-typeprint.c: Use C++ exception handling.
5476         * ada-lang.c: Use C++ exception handling.
5477         * aarch64-tdep.c: Use C++ exception handling.
5478
5479 2019-04-08  Tom Tromey  <tom@tromey.com>
5480
5481         * xml-support.c (gdb_xml_parser::parse): Update.
5482         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5483         * value.c (show_convenience): Update.
5484         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5485         (test_parse_flags_qcs): Update.
5486         * thread.c (thr_try_catch_cmd): Update.
5487         * target.c (target_translate_tls_address): Update.
5488         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5489         (info_frame_command_core, frame_apply_command_count): Update.
5490         * rust-exp.y (rust_lex_exception_test): Update.
5491         * riscv-tdep.c (riscv_print_one_register_info): Update.
5492         * remote.c (remote_target::enable_btrace): Update.
5493         * record-btrace.c (record_btrace_enable_warn): Update.
5494         * python/py-utils.c (gdbpy_convert_exception): Update.
5495         * printcmd.c (do_one_display, print_variable_and_value): Update.
5496         * mi/mi-main.c (mi_print_exception): Update.
5497         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5498         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5499         * linux-nat.c (linux_nat_target::attach): Update.
5500         * linux-fork.c (class scoped_switch_fork_info): Update.
5501         * infrun.c (displaced_step_prepare): Update.
5502         * infcall.c (call_function_by_hand_dummy): Update.
5503         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5504         * gnu-v3-abi.c (print_one_vtable): Update.
5505         * frame.c (get_prev_frame_always): Update.
5506         * f-valprint.c (info_common_command_for_block): Update.
5507         * exec.c (try_open_exec_file): Update.
5508         * exceptions.c (print_exception, exception_print)
5509         (exception_fprintf, exception_print_same): Update.
5510         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5511         * dwarf-index-cache.c (index_cache::store)
5512         (index_cache::lookup_gdb_index): Update.
5513         * darwin-nat.c (maybe_cache_shell): Update.
5514         * cp-valprint.c (cp_print_value_fields): Update.
5515         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5516         (gcc_cplus_symbol_address): Update.
5517         * compile/compile-c-symbols.c (gcc_convert_symbol)
5518         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5519         * common/selftest.c: Update.
5520         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5521         a std::string.
5522         (exception_try_scope_entry, exception_try_scope_exit): Don't
5523         declare.
5524         (struct exception_try_scope): Remove.
5525         (TRY): Don't use exception_try_scope.
5526         (struct gdb_exception): Add constructor, operator=.
5527         <what>: New method.
5528         (struct gdb_exception_RETURN_MASK_ALL)
5529         (struct gdb_exception_RETURN_MASK_ERROR)
5530         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5531         (struct gdb_quit_bad_alloc): Update.
5532         * common/common-exceptions.c (exception_none): Change
5533         initializer.
5534         (struct catcher) <state, exception>: Initialize inline.
5535         <prev>: Remove member.
5536         (current_catcher): Remove.
5537         (catchers): New global.
5538         (exceptions_state_mc_init): Simplify.
5539         (catcher_pop): Remove.
5540         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5541         (try_scope_depth, exception_try_scope_entry)
5542         (exception_try_scope_exit): Remove.
5543         (throw_exception_sjlj): Update.
5544         (exception_messages, exception_messages_size): Remove.
5545         (throw_it): Simplify.
5546         (gdb_exception_sliced_copy): Remove.
5547         (throw_exception_cxx): Update.
5548         * cli/cli-script.c (script_from_file): Update.
5549         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5550         Update.
5551         * ada-valprint.c (ada_val_print): Update.
5552         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5553         (create_excep_cond_exprs): Update.
5554
5555 2019-04-08  Tom Tromey  <tom@tromey.com>
5556
5557         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5558         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5559         (TRY, CATCH, END_CATCH): Remove some definitions.
5560         * common/common-exceptions.c: Don't use GDB_XCPT.
5561         (catcher_list_size): Remove.
5562         (throw_exception, throw_it): Simplify.
5563
5564 2019-04-05  Tom Tromey  <tom@tromey.com>
5565
5566         Revert the header-sorting patch.
5567         * ft32-tdep.c: Revert.
5568         * frv-tdep.c: Revert.
5569         * frv-linux-tdep.c: Revert.
5570         * frame.c: Revert.
5571         * frame-unwind.c: Revert.
5572         * frame-base.c: Revert.
5573         * fork-child.c: Revert.
5574         * findvar.c: Revert.
5575         * findcmd.c: Revert.
5576         * filesystem.c: Revert.
5577         * filename-seen-cache.h: Revert.
5578         * filename-seen-cache.c: Revert.
5579         * fbsd-tdep.c: Revert.
5580         * fbsd-nat.h: Revert.
5581         * fbsd-nat.c: Revert.
5582         * f-valprint.c: Revert.
5583         * f-typeprint.c: Revert.
5584         * f-lang.c: Revert.
5585         * extension.h: Revert.
5586         * extension.c: Revert.
5587         * extension-priv.h: Revert.
5588         * expprint.c: Revert.
5589         * exec.h: Revert.
5590         * exec.c: Revert.
5591         * exceptions.c: Revert.
5592         * event-top.c: Revert.
5593         * event-loop.c: Revert.
5594         * eval.c: Revert.
5595         * elfread.c: Revert.
5596         * dwarf2read.h: Revert.
5597         * dwarf2read.c: Revert.
5598         * dwarf2loc.c: Revert.
5599         * dwarf2expr.h: Revert.
5600         * dwarf2expr.c: Revert.
5601         * dwarf2-frame.c: Revert.
5602         * dwarf2-frame-tailcall.c: Revert.
5603         * dwarf-index-write.h: Revert.
5604         * dwarf-index-write.c: Revert.
5605         * dwarf-index-common.c: Revert.
5606         * dwarf-index-cache.h: Revert.
5607         * dwarf-index-cache.c: Revert.
5608         * dummy-frame.c: Revert.
5609         * dtrace-probe.c: Revert.
5610         * disasm.h: Revert.
5611         * disasm.c: Revert.
5612         * disasm-selftests.c: Revert.
5613         * dictionary.c: Revert.
5614         * dicos-tdep.c: Revert.
5615         * demangle.c: Revert.
5616         * dcache.h: Revert.
5617         * dcache.c: Revert.
5618         * darwin-nat.h: Revert.
5619         * darwin-nat.c: Revert.
5620         * darwin-nat-info.c: Revert.
5621         * d-valprint.c: Revert.
5622         * d-namespace.c: Revert.
5623         * d-lang.c: Revert.
5624         * ctf.c: Revert.
5625         * csky-tdep.c: Revert.
5626         * csky-linux-tdep.c: Revert.
5627         * cris-tdep.c: Revert.
5628         * cris-linux-tdep.c: Revert.
5629         * cp-valprint.c: Revert.
5630         * cp-support.c: Revert.
5631         * cp-namespace.c: Revert.
5632         * cp-abi.c: Revert.
5633         * corelow.c: Revert.
5634         * corefile.c: Revert.
5635         * continuations.c: Revert.
5636         * completer.h: Revert.
5637         * completer.c: Revert.
5638         * complaints.c: Revert.
5639         * coffread.c: Revert.
5640         * coff-pe-read.c: Revert.
5641         * cli-out.h: Revert.
5642         * cli-out.c: Revert.
5643         * charset.c: Revert.
5644         * c-varobj.c: Revert.
5645         * c-valprint.c: Revert.
5646         * c-typeprint.c: Revert.
5647         * c-lang.c: Revert.
5648         * buildsym.c: Revert.
5649         * buildsym-legacy.c: Revert.
5650         * build-id.h: Revert.
5651         * build-id.c: Revert.
5652         * btrace.c: Revert.
5653         * bsd-uthread.c: Revert.
5654         * breakpoint.h: Revert.
5655         * breakpoint.c: Revert.
5656         * break-catch-throw.c: Revert.
5657         * break-catch-syscall.c: Revert.
5658         * break-catch-sig.c: Revert.
5659         * blockframe.c: Revert.
5660         * block.c: Revert.
5661         * bfin-tdep.c: Revert.
5662         * bfin-linux-tdep.c: Revert.
5663         * bfd-target.c: Revert.
5664         * bcache.c: Revert.
5665         * ax-general.c: Revert.
5666         * ax-gdb.h: Revert.
5667         * ax-gdb.c: Revert.
5668         * avr-tdep.c: Revert.
5669         * auxv.c: Revert.
5670         * auto-load.c: Revert.
5671         * arm-wince-tdep.c: Revert.
5672         * arm-tdep.c: Revert.
5673         * arm-symbian-tdep.c: Revert.
5674         * arm-pikeos-tdep.c: Revert.
5675         * arm-obsd-tdep.c: Revert.
5676         * arm-nbsd-tdep.c: Revert.
5677         * arm-nbsd-nat.c: Revert.
5678         * arm-linux-tdep.c: Revert.
5679         * arm-linux-nat.c: Revert.
5680         * arm-fbsd-tdep.c: Revert.
5681         * arm-fbsd-nat.c: Revert.
5682         * arm-bsd-tdep.c: Revert.
5683         * arch-utils.c: Revert.
5684         * arc-tdep.c: Revert.
5685         * arc-newlib-tdep.c: Revert.
5686         * annotate.h: Revert.
5687         * annotate.c: Revert.
5688         * amd64-windows-tdep.c: Revert.
5689         * amd64-windows-nat.c: Revert.
5690         * amd64-tdep.c: Revert.
5691         * amd64-sol2-tdep.c: Revert.
5692         * amd64-obsd-tdep.c: Revert.
5693         * amd64-obsd-nat.c: Revert.
5694         * amd64-nbsd-tdep.c: Revert.
5695         * amd64-nbsd-nat.c: Revert.
5696         * amd64-nat.c: Revert.
5697         * amd64-linux-tdep.c: Revert.
5698         * amd64-linux-nat.c: Revert.
5699         * amd64-fbsd-tdep.c: Revert.
5700         * amd64-fbsd-nat.c: Revert.
5701         * amd64-dicos-tdep.c: Revert.
5702         * amd64-darwin-tdep.c: Revert.
5703         * amd64-bsd-nat.c: Revert.
5704         * alpha-tdep.c: Revert.
5705         * alpha-obsd-tdep.c: Revert.
5706         * alpha-nbsd-tdep.c: Revert.
5707         * alpha-mdebug-tdep.c: Revert.
5708         * alpha-linux-tdep.c: Revert.
5709         * alpha-linux-nat.c: Revert.
5710         * alpha-bsd-tdep.c: Revert.
5711         * alpha-bsd-nat.c: Revert.
5712         * aix-thread.c: Revert.
5713         * agent.c: Revert.
5714         * addrmap.c: Revert.
5715         * ada-varobj.c: Revert.
5716         * ada-valprint.c: Revert.
5717         * ada-typeprint.c: Revert.
5718         * ada-tasks.c: Revert.
5719         * ada-lang.c: Revert.
5720         * aarch64-tdep.c: Revert.
5721         * aarch64-ravenscar-thread.c: Revert.
5722         * aarch64-newlib-tdep.c: Revert.
5723         * aarch64-linux-tdep.c: Revert.
5724         * aarch64-linux-nat.c: Revert.
5725         * aarch64-fbsd-tdep.c: Revert.
5726         * aarch64-fbsd-nat.c: Revert.
5727         * aarch32-linux-nat.c: Revert.
5728
5729 2019-04-05  Tom Tromey  <tom@tromey.com>
5730
5731         * ft32-tdep.c: Sort headers.
5732         * frv-tdep.c: Sort headers.
5733         * frv-linux-tdep.c: Sort headers.
5734         * frame.c: Sort headers.
5735         * frame-unwind.c: Sort headers.
5736         * frame-base.c: Sort headers.
5737         * fork-child.c: Sort headers.
5738         * findvar.c: Sort headers.
5739         * findcmd.c: Sort headers.
5740         * filesystem.c: Sort headers.
5741         * filename-seen-cache.h: Sort headers.
5742         * filename-seen-cache.c: Sort headers.
5743         * fbsd-tdep.c: Sort headers.
5744         * fbsd-nat.h: Sort headers.
5745         * fbsd-nat.c: Sort headers.
5746         * f-valprint.c: Sort headers.
5747         * f-typeprint.c: Sort headers.
5748         * f-lang.c: Sort headers.
5749         * extension.h: Sort headers.
5750         * extension.c: Sort headers.
5751         * extension-priv.h: Sort headers.
5752         * expprint.c: Sort headers.
5753         * exec.h: Sort headers.
5754         * exec.c: Sort headers.
5755         * exceptions.c: Sort headers.
5756         * event-top.c: Sort headers.
5757         * event-loop.c: Sort headers.
5758         * eval.c: Sort headers.
5759         * elfread.c: Sort headers.
5760         * dwarf2read.h: Sort headers.
5761         * dwarf2read.c: Sort headers.
5762         * dwarf2loc.c: Sort headers.
5763         * dwarf2expr.h: Sort headers.
5764         * dwarf2expr.c: Sort headers.
5765         * dwarf2-frame.c: Sort headers.
5766         * dwarf2-frame-tailcall.c: Sort headers.
5767         * dwarf-index-write.h: Sort headers.
5768         * dwarf-index-write.c: Sort headers.
5769         * dwarf-index-common.c: Sort headers.
5770         * dwarf-index-cache.h: Sort headers.
5771         * dwarf-index-cache.c: Sort headers.
5772         * dummy-frame.c: Sort headers.
5773         * dtrace-probe.c: Sort headers.
5774         * disasm.h: Sort headers.
5775         * disasm.c: Sort headers.
5776         * disasm-selftests.c: Sort headers.
5777         * dictionary.c: Sort headers.
5778         * dicos-tdep.c: Sort headers.
5779         * demangle.c: Sort headers.
5780         * dcache.h: Sort headers.
5781         * dcache.c: Sort headers.
5782         * darwin-nat.h: Sort headers.
5783         * darwin-nat.c: Sort headers.
5784         * darwin-nat-info.c: Sort headers.
5785         * d-valprint.c: Sort headers.
5786         * d-namespace.c: Sort headers.
5787         * d-lang.c: Sort headers.
5788         * ctf.c: Sort headers.
5789         * csky-tdep.c: Sort headers.
5790         * csky-linux-tdep.c: Sort headers.
5791         * cris-tdep.c: Sort headers.
5792         * cris-linux-tdep.c: Sort headers.
5793         * cp-valprint.c: Sort headers.
5794         * cp-support.c: Sort headers.
5795         * cp-namespace.c: Sort headers.
5796         * cp-abi.c: Sort headers.
5797         * corelow.c: Sort headers.
5798         * corefile.c: Sort headers.
5799         * continuations.c: Sort headers.
5800         * completer.h: Sort headers.
5801         * completer.c: Sort headers.
5802         * complaints.c: Sort headers.
5803         * coffread.c: Sort headers.
5804         * coff-pe-read.c: Sort headers.
5805         * cli-out.h: Sort headers.
5806         * cli-out.c: Sort headers.
5807         * charset.c: Sort headers.
5808         * c-varobj.c: Sort headers.
5809         * c-valprint.c: Sort headers.
5810         * c-typeprint.c: Sort headers.
5811         * c-lang.c: Sort headers.
5812         * buildsym.c: Sort headers.
5813         * buildsym-legacy.c: Sort headers.
5814         * build-id.h: Sort headers.
5815         * build-id.c: Sort headers.
5816         * btrace.c: Sort headers.
5817         * bsd-uthread.c: Sort headers.
5818         * breakpoint.h: Sort headers.
5819         * breakpoint.c: Sort headers.
5820         * break-catch-throw.c: Sort headers.
5821         * break-catch-syscall.c: Sort headers.
5822         * break-catch-sig.c: Sort headers.
5823         * blockframe.c: Sort headers.
5824         * block.c: Sort headers.
5825         * bfin-tdep.c: Sort headers.
5826         * bfin-linux-tdep.c: Sort headers.
5827         * bfd-target.c: Sort headers.
5828         * bcache.c: Sort headers.
5829         * ax-general.c: Sort headers.
5830         * ax-gdb.h: Sort headers.
5831         * ax-gdb.c: Sort headers.
5832         * avr-tdep.c: Sort headers.
5833         * auxv.c: Sort headers.
5834         * auto-load.c: Sort headers.
5835         * arm-wince-tdep.c: Sort headers.
5836         * arm-tdep.c: Sort headers.
5837         * arm-symbian-tdep.c: Sort headers.
5838         * arm-pikeos-tdep.c: Sort headers.
5839         * arm-obsd-tdep.c: Sort headers.
5840         * arm-nbsd-tdep.c: Sort headers.
5841         * arm-nbsd-nat.c: Sort headers.
5842         * arm-linux-tdep.c: Sort headers.
5843         * arm-linux-nat.c: Sort headers.
5844         * arm-fbsd-tdep.c: Sort headers.
5845         * arm-fbsd-nat.c: Sort headers.
5846         * arm-bsd-tdep.c: Sort headers.
5847         * arch-utils.c: Sort headers.
5848         * arc-tdep.c: Sort headers.
5849         * arc-newlib-tdep.c: Sort headers.
5850         * annotate.h: Sort headers.
5851         * annotate.c: Sort headers.
5852         * amd64-windows-tdep.c: Sort headers.
5853         * amd64-windows-nat.c: Sort headers.
5854         * amd64-tdep.c: Sort headers.
5855         * amd64-sol2-tdep.c: Sort headers.
5856         * amd64-obsd-tdep.c: Sort headers.
5857         * amd64-obsd-nat.c: Sort headers.
5858         * amd64-nbsd-tdep.c: Sort headers.
5859         * amd64-nbsd-nat.c: Sort headers.
5860         * amd64-nat.c: Sort headers.
5861         * amd64-linux-tdep.c: Sort headers.
5862         * amd64-linux-nat.c: Sort headers.
5863         * amd64-fbsd-tdep.c: Sort headers.
5864         * amd64-fbsd-nat.c: Sort headers.
5865         * amd64-dicos-tdep.c: Sort headers.
5866         * amd64-darwin-tdep.c: Sort headers.
5867         * amd64-bsd-nat.c: Sort headers.
5868         * alpha-tdep.c: Sort headers.
5869         * alpha-obsd-tdep.c: Sort headers.
5870         * alpha-nbsd-tdep.c: Sort headers.
5871         * alpha-mdebug-tdep.c: Sort headers.
5872         * alpha-linux-tdep.c: Sort headers.
5873         * alpha-linux-nat.c: Sort headers.
5874         * alpha-bsd-tdep.c: Sort headers.
5875         * alpha-bsd-nat.c: Sort headers.
5876         * aix-thread.c: Sort headers.
5877         * agent.c: Sort headers.
5878         * addrmap.c: Sort headers.
5879         * ada-varobj.c: Sort headers.
5880         * ada-valprint.c: Sort headers.
5881         * ada-typeprint.c: Sort headers.
5882         * ada-tasks.c: Sort headers.
5883         * ada-lang.c: Sort headers.
5884         * aarch64-tdep.c: Sort headers.
5885         * aarch64-ravenscar-thread.c: Sort headers.
5886         * aarch64-newlib-tdep.c: Sort headers.
5887         * aarch64-linux-tdep.c: Sort headers.
5888         * aarch64-linux-nat.c: Sort headers.
5889         * aarch64-fbsd-tdep.c: Sort headers.
5890         * aarch64-fbsd-nat.c: Sort headers.
5891         * aarch32-linux-nat.c: Sort headers.
5892
5893 2019-04-04  Tom Tromey  <tom@tromey.com>
5894
5895         * varobj.c (varobj_create): Update.
5896         * rust-exp.y (struct rust_parser) <update_innermost_block,
5897         lookup_symbol>: New methods.
5898         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5899         Rename.
5900         (rust_parser::rust_lookup_type)
5901         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5902         * printcmd.c (display_command, do_one_display): Update.
5903         * parser-defs.h (struct parser_state) <parser_state>: Add
5904         "tracker" parameter.
5905         (block_tracker): New member.
5906         (class innermost_block_tracker) <innermost_block_tracker>: Add
5907         "types" parameter.
5908         <reset>: Remove method.
5909         (innermost_block): Don't declare.
5910         (null_post_parser): Update.
5911         * parse.c (innermost_block): Remove global.
5912         (write_dollar_variable): Update.
5913         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5914         Remove "tracker_types" parameter.
5915         (parse_expression): Add "tracker" parameter.
5916         (parse_expression_for_completion): Update.
5917         (null_post_parser): Add "tracker" parameter.
5918         * p-exp.y: Update rules.
5919         * m2-exp.y: Update rules.
5920         * language.h (struct language_defn) <la_post_parser>: Add
5921         "tracker" parameter.
5922         * go-exp.y: Update rules.
5923         * f-exp.y: Update rules.
5924         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5925         parameter.
5926         * d-exp.y: Update rules.
5927         * c-exp.y: Update rules.
5928         * breakpoint.c (set_breakpoint_condition): Create an
5929         innermost_block_tracker.
5930         (watch_command_1): Likewise.
5931         * ada-lang.c (resolve): Add "tracker" parameter.
5932         (resolve_subexp): Likewise.
5933         * ada-exp.y (write_var_from_sym): Update.
5934
5935 2019-04-04  Tom Tromey  <tom@tromey.com>
5936
5937         * type-stack.h: New file.
5938         * type-stack.c: New file.
5939         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5940         type-stack.h.
5941         (insert_into_type_stack, insert_type, push_type, push_type_int)
5942         (insert_type_address_space, pop_type, pop_type_int)
5943         (pop_typelist, pop_type_stack, append_type_stack)
5944         (push_type_stack, get_type_stack, push_typelist)
5945         (follow_type_instance_flags, follow_types): Don't declare.
5946         * parse.c (type_stack): Remove global.
5947         (parse_exp_in_context): Update.
5948         (insert_into_type_stack, insert_type, push_type, push_type_int)
5949         (insert_type_address_space, pop_type, pop_type_int)
5950         (pop_typelist, pop_type_stack, append_type_stack)
5951         (push_type_stack, get_type_stack, push_typelist)
5952         (follow_type_instance_flags, follow_types): Remove (moved to
5953         type-stack.c).
5954         * f-exp.y (type_stack): New global.
5955         Update rules.
5956         (push_kind_type, f_parse): Update.
5957         * d-exp.y (type_stack): New global.
5958         Update rules.
5959         (d_parse): Update.
5960         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5961         Update rules.
5962         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5963         (HFILES_NO_SRCDIR): Add type-stack.h.
5964
5965 2019-04-04  Tom Tromey  <tom@tromey.com>
5966
5967         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5968         (rust_parser::convert_ast_to_expression, rust_parse)
5969         (rust_lex_test_completion, rust_lex_tests): Update.
5970         * parser-defs.h (struct expr_completion_state): New.
5971         (struct parser_state) <parser_state>: Add completion parameter.
5972         <mark_struct_expression, mark_completion_tag>: New methods.
5973         <parse_completion, m_completion_state>: New members.
5974         (prefixify_expression, null_post_parser): Update.
5975         (mark_struct_expression, mark_completion_tag): Don't declare.
5976         * parse.c (parse_completion, expout_last_struct)
5977         (expout_tag_completion_type, expout_completion_name): Remove
5978         globals.
5979         (parser_state::mark_struct_expression)
5980         (parser_state::mark_completion_tag): Now methods.
5981         (prefixify_expression): Add last_struct parameter.
5982         (prefixify_subexp): Likewise.
5983         (parse_exp_1): Update.
5984         (parse_exp_in_context): Add cstate parameter.  Update.
5985         (parse_expression_for_completion): Create an
5986         expr_completion_state.
5987         (null_post_parser): Add "completion" parameter.
5988         * p-exp.y: Update rules.
5989         (yylex): Update.
5990         * language.h (struct language_defn) <la_post_parser>: Add
5991         "completing" parameter.
5992         * go-exp.y: Update rules.
5993         (lex_one_token): Update.
5994         * expression.h (parse_completion): Don't declare.
5995         * d-exp.y: Update rules.
5996         (lex_one_token): Update rules.
5997         * c-exp.y: Update rules.
5998         (lex_one_token): Update.
5999         * ada-lang.c (resolve): Add "parse_completion" parameter.
6000         (resolve_subexp): Likewise.
6001         (ada_resolve_function): Likewise.
6002
6003 2019-04-04  Tom Tromey  <tom@tromey.com>
6004
6005         * parser-defs.h (struct parser_state) <start_arglist,
6006         end_arglist>: New methods.
6007         <arglist_len, m_funcall_chain>: New members.
6008         (arglist_len, start_arglist, end_arglist): Don't declare.
6009         * parse.c (arglist_len, funcall_chain): Remove global.
6010         (start_arglist, end_arglist): Remove functions.
6011         (parse_exp_in_context): Update.
6012         * p-exp.y: Update rules.
6013         * m2-exp.y: Update rules.
6014         * go-exp.y: Update rules.
6015         * f-exp.y: Update rules.
6016         * d-exp.y: Update rules.
6017         * c-exp.y: Update rules.
6018
6019 2019-04-04  Tom Tromey  <tom@tromey.com>
6020
6021         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6022         lex_operator, push_back>: New methods.
6023         Update all rules.
6024         (rust_parser::lex_hex, lex_escape): Rename and update.
6025         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6026         (rust_parser::lex_operator): Rename and update.
6027         (rust_parser::lex_number, rustyylex, rustyyerror)
6028         (rust_lex_test_init, rust_lex_test_sequence)
6029         (rust_lex_test_push_back, rust_lex_tests): Update.
6030         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6031         parameter.
6032         <lexptr, prev_lexptr>: New members.
6033         (lexptr, prev_lexptr): Don't declare.
6034         * parse.c (lexptr, prev_lexptr): Remove globals.
6035         (parse_exp_in_context): Update.
6036         * p-exp.y (yylex, yyerror): Update.
6037         * m2-exp.y (parse_number, yylex, yyerror): Update.
6038         * go-exp.y (lex_one_token, yyerror): Update.
6039         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6040         * d-exp.y (lex_one_token, yyerror): Update.
6041         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6042         (lex_one_token, yyerror): Update.
6043         * ada-lex.l (YY_INPUT): Update.
6044         (rewind_to_char): Update.
6045         * ada-exp.y (yyerror): Update.
6046
6047 2019-04-04  Tom Tromey  <tom@tromey.com>
6048
6049         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6050         * parser-defs.h (struct parser_state) <parser_state>: Add new
6051         parameter.
6052         <comma_terminates>: New member.
6053         (comma_terminates): Don't declare global.
6054         * parse.c (comma_terminates): Remove global.
6055         (parse_exp_in_context): Update.
6056         * p-exp.y (yylex): Update.
6057         * m2-exp.y (yylex): Update.
6058         * go-exp.y (lex_one_token): Update.
6059         * f-exp.y (yylex): Update.
6060         * d-exp.y (lex_one_token): Update.
6061         * c-exp.y (lex_one_token): Update.
6062         * ada-lex.l: Update.
6063
6064 2019-04-04  Tom Tromey  <tom@tromey.com>
6065
6066         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6067         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6068         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6069         * parser-defs.h (paren_depth): Don't declare.
6070         * parse.c (paren_depth): Remove global.
6071         (parse_exp_in_context): Update.
6072         * p-exp.y (paren_depth): New global.
6073         (pascal_parse): Initialize it.
6074         * m2-exp.y (paren_depth): New global.
6075         (m2_parse): Initialize it.
6076         * go-exp.y (paren_depth): New global.
6077         (go_parse): Initialize it.
6078         * f-exp.y (paren_depth): New global.
6079         (f_parse): Initialize it.
6080         * d-exp.y (paren_depth): New global.
6081         (d_parse): Initialize it.
6082         * c-exp.y (paren_depth): New global.
6083         (c_parse): Initialize it.
6084         * ada-lex.l (paren_depth): New global.
6085         (lexer_init): Initialize it.
6086
6087 2019-04-04  Tom Tromey  <tom@tromey.com>
6088
6089         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6090         (rust_parser::convert_ast_to_type)
6091         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6092         * parser-defs.h (struct parser_state) <parser_state>: Add
6093         parameters.  Initialize new members.
6094         <expression_context_block, expression_context_pc>: New members.
6095         * parse.c (expression_context_block, expression_context_pc):
6096         Remove globals.
6097         (parse_exp_in_context): Update.
6098         * p-exp.y: Update all rules.
6099         (yylex): Update.
6100         * m2-exp.y: Update all rules.
6101         (yylex): Update.
6102         * go-exp.y (yylex): Update.
6103         * f-exp.y (yylex): Update.
6104         * d-exp.y: Update all rules.
6105         (yylex): Update.
6106         * c-exp.y: Update all rules.
6107         (lex_one_token, classify_name, yylex, c_parse): Update.
6108         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6109
6110 2019-04-04  Tom Tromey  <tom@tromey.com>
6111
6112         * gdbarch.h, gdbarch.c: Rebuild.
6113         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6114         * stap-probe.h:
6115         (struct stap_parse_info): Replace "parser_state" with
6116         "expr_builder".
6117         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6118         (parser_state): New class.
6119         * parse.c (expr_builder): Rename.
6120         (expr_builder::release): Rename.
6121         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6122         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6123         (write_exp_elt_longcst, write_exp_elt_floatcst)
6124         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6125         (write_exp_string_vector, write_exp_bitstring)
6126         (write_exp_msymbol, mark_struct_expression)
6127         (write_dollar_variable)
6128         (insert_type_address_space, increase_expout_size): Replace
6129         "parser_state" with "expr_builder".
6130         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6131         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6132         "parser_state" with "expr_builder".
6133
6134 2019-04-04  Tom Tromey  <tom@tromey.com>
6135
6136         * rust-exp.y: Replace "parse_language" with method call.
6137         * p-exp.y:
6138         (yylex): Replace "parse_language" with method call.
6139         * m2-exp.y:
6140         (yylex): Replace "parse_language" with method call.
6141         * go-exp.y (classify_name): Replace "parse_language" with method
6142         call.
6143         * f-exp.y (yylex): Replace "parse_language" with method call.
6144         * d-exp.y (lex_one_token): Replace "parse_language" with method
6145         call.
6146         * c-exp.y:
6147         (lex_one_token, classify_name, yylex): Replace "parse_language"
6148         with method call.
6149         * ada-exp.y (find_primitive_type, type_char)
6150         (type_system_address): Replace "parse_language" with method call.
6151
6152 2019-04-04  Tom Tromey  <tom@tromey.com>
6153
6154         * rust-exp.y: Replace "parse_gdbarch" with method call.
6155         * parse.c (write_dollar_variable, insert_type_address_space):
6156         Replace "parse_gdbarch" with method call.
6157         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6158         call.
6159         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6160         call.
6161         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6162         "parse_gdbarch" with method call.
6163         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6164         with method call.
6165         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6166         "parse_gdbarch" with method call.
6167         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6168         "parse_gdbarch" with method call.
6169         * c-exp.y (parse_type, parse_number, classify_name): Replace
6170         "parse_gdbarch" with method call.
6171         * ada-lex.l: Replace "parse_gdbarch" with method call.
6172         * ada-exp.y (parse_type, find_primitive_type, type_char)
6173         (type_system_address): Replace "parse_gdbarch" with method call.
6174
6175 2019-04-04  Tom Tromey  <tom@tromey.com>
6176
6177         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6178         * stap-probe.c (stap_parse_argument): Update.
6179         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6180         initial_size parameter.
6181         * rust-exp.y (rust_lex_tests): Update.
6182         * parse.c (parser_state): Update.
6183         (parse_exp_in_context): Update.
6184         * parser-defs.h (struct parser_state) <parser_state>: Remove
6185         "initial_size" parameter.
6186
6187 2019-04-04  Tom Tromey  <tom@tromey.com>
6188
6189         * parser-defs.h (increase_expout_size): Don't declare.
6190         * parse.c (increase_expout_size): Now static.
6191
6192 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6193
6194         * gnu-nat.c (gnu_nat_target::wait): Fix
6195         target_waitstatus_to_string call.
6196
6197 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6198
6199         * eval.c (evaluate_subexp_standard): Handle internal functions
6200         during Fortran function call handling.
6201
6202 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6203
6204         * NEWS: Mention new internal functions.
6205         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6206         (read_base_type): Use dwarf2_init_complex_target_type.
6207         * value.c (creal_internal_fn): New function.
6208         (cimag_internal_fn): New function.
6209         (_initialize_values): Register new internal functions.
6210
6211 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6212
6213         * infrun.c (stop_all_threads): If debug_infrun, always
6214         trace the wait status after wait_one, using
6215         target_waitstatus_to_string and target_pid_to_str.
6216         (handle_inferior_event): Replace various trace of
6217         wait status kind by a single trace.
6218         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6219         wait status kind image by target_waitstatus_to_string.
6220         * target/waitstatus.c (target_waitstatus_to_string): Fix
6221         obsolete comment.
6222
6223 2019-04-01  Tom Tromey  <tromey@adacore.com>
6224
6225         PR symtab/23331:
6226         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6227
6228 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6229             Pedro Alves  <palves@redhat.com>
6230
6231         * top.c (quit_force): Call 'finalize_values'.
6232         * value.c (finalize_values): New function.
6233         * value.h (finalize_values): Declare.
6234
6235 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6236
6237         * NEWS: Announce $_gdb_major and $_gdb_minor.
6238
6239         * top.c (init_gdb_version_vars): New function.
6240         (gdb_init): Call init_gdb_version_vars.
6241
6242 2019-03-29  Tom Tromey  <tromey@adacore.com>
6243
6244         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6245         help text.  Remove dead code.
6246
6247 2019-03-29  Keith Seitz  <keiths@redhat.com>
6248
6249         From Siddhesh Poyarekar:
6250         * f-lang.h (f77_get_upperbound): Return LONGEST.
6251         (f77_get_lowerbound): Likewise.
6252         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6253         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6254         print them.
6255         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6256         plongest to format print it.
6257         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6258         (f77_get_upperbound): Likewise.
6259         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6260         LOWER_BOUND to LONGEST.
6261         (f77_create_arrayprint_offset_tbl): Likewise.
6262
6263 2019-03-29  Keith Seitz  <keiths@redhat.com>
6264
6265         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6266         %s/pulongest for TYPE_LENGTH instead of %d in format
6267         strings.
6268         * ada-typerint.c (ada_print_type): Likewise.
6269         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6270         * compile/compile-c-support.c (generate_register_struct): Likewise.
6271         * gdbtypes.c (recursive_dump_type): Likewise.
6272         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6273         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6274         instead of %d in format strings.
6275         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6276         to std::min to ULONGEST.
6277         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6278         instead of %d in format strings.
6279         * tracepoint.c (info_scope_command): Likewise.
6280         * typeprint.c (print_offset_data::update)
6281         (print_offset_data::finish): Likewise.
6282         * xtensa-tdep.c (xtensa_store_return_value)
6283         (xtensa_push_dummy_call): Likewise.
6284
6285 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6286
6287         * windows-nat.c (display_selector): Fixed format specifications
6288         for 64-bit Cygwin.
6289
6290 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6291
6292         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6293
6294 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6295
6296         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6297         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6298         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6299         (nios2_linux_init_abi): Install it.
6300
6301 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6302
6303         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6304
6305 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6306
6307         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6308
6309 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6310             Tom Tromey  <tromey@adacore.com>
6311
6312         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6313
6314 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6315
6316         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6317         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6318         method to compute the bounds of range types. Also print "[evaluated]"
6319         if the bounds' values come from a dynamic evaluation.
6320
6321 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6322
6323         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6324         whitespace when pretty printing is on.
6325
6326 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6327
6328         * ppc-linux-nat.c: Add include.
6329
6330 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6331
6332         * NEWS: Mention AArch64 Pointer Authentication.
6333
6334 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6335
6336         * arm-linux-nat.c: Add include.
6337
6338 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6339
6340         * source-cache.c (source_cache::get_source_lines): Re-read
6341         fullname after calling open_source_file.
6342
6343 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6344
6345         * NEWS: Mention TLS support for FreeBSD.
6346
6347 2019-03-25  Tom Tromey  <tromey@adacore.com>
6348
6349         * minsyms.c (BUNCH_SIZE): Update comment.
6350         (~minimal_symbol_reader): Remove old comment.
6351         (compact_minimal_symbols): Update comment.
6352         (minimal_symbol_reader::install): Remove old comment.  Update
6353         other comments.
6354
6355 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6356
6357         * s390-linux-nat.c: Add include.
6358
6359 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6360
6361         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6362         Call linux_get_hwcap.
6363         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6364         Likewise.
6365         (aarch64_linux_get_hwcap): Remove function.
6366         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6367         declaration.
6368         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6369         linux_get_hwcap.
6370         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6371         * linux-tdep.c (linux_get_hwcap): Add function.
6372         (linux_get_hwcap2): Likewise.
6373         * linux-tdep.h (linux_get_hwcap): Add declaration.
6374         (linux_get_hwcap2): Likewise.
6375         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6376         (ppc_linux_get_hwcap2): Likewise.
6377         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6378         linux_get_hwcap.
6379         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6380         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6381         (ppc_linux_nat_target::read_description): Likewise.
6382         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6383         * s390-linux-nat.c: Likewise.
6384         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6385
6386 2019-03-24  Tom Tromey  <tom@tromey.com>
6387
6388         * ada-lang.c (standard_lookup): Simplify initialization.
6389         (ada_lookup_symbol_nonlocal): Simplify return.
6390         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6391         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6392         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6393         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6394         initialization.
6395         * solib.c (solib_global_lookup): Simplify.
6396         * symtab.c (null_block_symbol): Remove.
6397         (symbol_cache_lookup): Simplify returns.
6398         (lookup_language_this): Simplify returns.
6399         (lookup_symbol_aux): Simplify return.
6400         (lookup_local_symbol): Simplify returns.
6401         (lookup_global_symbol_from_objfile): Simplify return.
6402         (lookup_symbol_in_objfile_symtabs)
6403         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6404         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6405         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6406         * cp-namespace.c (cp_lookup_bare_symbol)
6407         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6408         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6409         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6410         (cp_lookup_symbol_via_imports): Simplify initialization.
6411         (find_symbol_in_baseclass): Likewise.
6412         * symtab.h (null_block_symbol): Remove.
6413         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6414         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6415         (d_lookup_symbol_module): Likewise.
6416         (find_symbol_in_baseclass): Simplify initialization.
6417
6418 2019-03-24  Tom Tromey  <tom@tromey.com>
6419
6420         * expression.h: Don't include symtab.h.
6421         (struct block): Forward declare.
6422
6423 2019-03-24  Tom Tromey  <tom@tromey.com>
6424
6425         * c-exp.y (typebase): Remove casts.
6426         * gdbtypes.c (lookup_unsigned_typename, )
6427         (lookup_signed_typename): Remove cast.
6428         * eval.c (parse_to_comma_and_eval): Remove cast.
6429         * parse.c (write_dollar_variable): Remove cast.
6430         * block.h (struct block) <superblock>: Now const.
6431         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6432         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6433         (map_block): Make "block" const.
6434         * symfile.h (struct quick_symbol_functions)
6435         <map_matching_symbols>: Constify block argument to "callback".
6436         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6437         const.
6438         (find_pc_sect_compunit_symtab): Make "b" const.
6439         (find_symbol_at_address): Likewise.
6440         (search_symbols): Likewise.
6441         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6442         (dw2_debug_names_lookup_symbol): Likewise.
6443         (dw2_map_matching_symbols): Update.
6444         * p-valprint.c (pascal_val_print): Remove "block".
6445         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6446         (aux_add_nonlocal_symbols): Make "block" const.
6447         (resolve_subexp): Remove cast.
6448         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6449         const.
6450         (iterate_over_file_blocks): Likewise.
6451         * f-exp.y (%union) <bval>: Remove.
6452         * coffread.c (patch_opaque_types): Make "b" const.
6453         * spu-tdep.c (spu_catch_start): Make "block" const.
6454         * c-valprint.c (print_unpacked_pointer): Remove "block".
6455         * symmisc.c (dump_symtab_1): Make "b" const.
6456         (block_depth): Make "block" const.
6457         * d-exp.y (%union) <bval>: Remove.
6458         * cp-support.h (cp_lookup_rtti_type): Update.
6459         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6460         * psymtab.c (psym_lookup_symbol): Make "block" const.
6461         (maintenance_check_psymtabs): Make "b" const.
6462         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6463         (enumerate_locals, enumerate_args): Update.
6464         * python/py-symtab.c (stpy_global_block): Make "block" const.
6465         (stpy_static_block): Likewise.
6466         * inline-frame.c (block_starting_point_at): Make "new_block"
6467         const.
6468         * block.c (find_block_in_blockvector): Make return type const.
6469         (blockvector_for_pc_sect): Make "b" const.
6470         (find_block_in_blockvector): Make "b" const.
6471
6472 2019-03-23  Tom Tromey  <tom@tromey.com>
6473
6474         * varobj.c (varobj_create): Update.
6475         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6476         * printcmd.c (display_command, do_one_display): Don't reset
6477         innermost_block.
6478         * parser-defs.h (enum innermost_block_tracker_type): Move to
6479         expression.h.
6480         (innermost_block): Update comment.
6481         * parse.c (parse_exp_1): Add tracker_types parameter.
6482         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6483         tracker_types parameter.  Reset innermost_block.
6484         (parse_exp_in_context): Remove.
6485         (parse_expression_for_completion): Update.
6486         * objfiles.c (~objfile): Don't reset expression_context_block or
6487         innermost_block.
6488         * expression.h (enum innermost_block_tracker_type): Move from
6489         parser-defs.h.
6490         (parse_exp_1): Add tracker_types parameter.
6491         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6492         reset innermost_block.
6493
6494 2019-03-23  Tom Tromey  <tom@tromey.com>
6495
6496         * objfiles.h: Include bcache.h.
6497
6498 2019-03-23  Tom Tromey  <tom@tromey.com>
6499
6500         * linespec.c (get_current_search_block): Use
6501         scoped_restore_current_language.
6502         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6503
6504 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6505             Jiong Wang  <jiong.wang@arm.com>
6506
6507         * aarch64-linux-tdep.c
6508         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6509         section.
6510         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6511
6512 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6513             Jiong Wang  <jiong.wang@arm.com>
6514
6515         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6516         instructions.
6517         (aarch64_analyze_prologue_test): Add PACIASP test.
6518         (aarch64_prologue_prev_register): Unmask PC value.
6519
6520 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6521             Jiong Wang  <jiong.wang@arm.com>
6522
6523         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6524         (aarch64_dwarf2_prev_register): Unmask PC value.
6525         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6526         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6527         DW_CFA_AARCH64_negate_ra_state.
6528         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6529
6530 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6531             Jiong Wang  <jiong.wang@arm.com>
6532
6533         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6534         registers.
6535         (aarch64_pseudo_register_name): Likewise.
6536         (aarch64_pseudo_register_type): Likewise.
6537         (aarch64_pseudo_register_reggroup_p): Likewise.
6538         (aarch64_gdbarch_init): Add pauth registers.
6539         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6540         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6541         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6542         (struct gdbarch_tdep): Add regnum for ra_state.
6543
6544 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6545             Jiong Wang  <jiong.wang@arm.com>
6546
6547         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6548
6549 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6550             Jiong Wang  <jiong.wang@arm.com>
6551
6552         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6553         function.
6554         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6555         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6556         (aarch64_gdbarch_init): Add puth registers.
6557         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6558         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6559         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6560
6561 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6562             Jiong Wang  <jiong.wang@arm.com>
6563
6564         * aarch64-linux-nat.c
6565         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6566         * aarch64-linux-tdep.c
6567         (aarch64_linux_core_read_description): Likewise.
6568         (aarch64_linux_get_hwcap): New function.
6569         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6570         (aarch64_linux_get_hwcap): New declaration.
6571
6572 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6573             Jiong Wang  <jiong.wang@arm.com>
6574
6575         * aarch64-linux-nat.c
6576         (aarch64_linux_nat_target::read_description): Add pauth param.
6577         * aarch64-linux-tdep.c
6578         (aarch64_linux_core_read_description): Likewise.
6579         * aarch64-tdep.c (struct target_desc): Add in pauth.
6580         (aarch64_read_description): Add pauth param.
6581         (aarch64_gdbarch_init): Likewise.
6582         * aarch64-tdep.h (aarch64_read_description): Likewise.
6583         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6584         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6585         * features/Makefile: Add new files.
6586         * features/aarch64-pauth.c: New file.
6587         * features/aarch64-pauth.xml: New file.
6588
6589 2019-03-20  Tom Tromey  <tromey@adacore.com>
6590
6591         * infrun.c (handle_inferior_event): Rename from
6592         handle_inferior_event_1.  Create a scoped_value_mark.
6593         (handle_inferior_event): Remove.
6594
6595 2019-03-19  Tom Tromey  <tromey@adacore.com>
6596
6597         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6598         * infrun.h (print_stop_event): Add "displays" parameter.
6599         * infrun.c (print_stop_event): Add "displays" parameter.
6600
6601 2019-03-19  Pedro Alves  <palves@redhat.com>
6602
6603         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6604         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6605         to -1.  Fix TABs vs spaces.
6606         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6607         * tui/tui-out.h (tui_ui_out) Add intro comments.
6608         <m_line, m_start_of_line>: In-class initialize, and add describing
6609         comment.
6610
6611 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6612
6613         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6614         variable names.
6615         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6616
6617 2019-03-18  Pedro Alves  <palves@redhat.com>
6618             Eli Zaretskii <eliz@gnu.org>
6619
6620         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6621         m_line and m_start_of_line.
6622
6623 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6624
6625         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6626         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6627         it returns a newline.  This fixes a regression in TU mode, whereby
6628         the next line is output on the same screen line as the user input.
6629
6630 2019-03-18  Tom Tromey  <tromey@adacore.com>
6631
6632         * minsyms.c (minimal_symbol_reader::install): Remove call to
6633         obstack_blank.
6634
6635 2019-03-18  Pedro Alves  <palves@redhat.com>
6636
6637         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6638         New globals.
6639         (apply_style): New, factored out from ...
6640         (apply_ansi_escape): ... this.  Handle reverse video mode.
6641         (tui_set_reverse_mode): New function.
6642         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6643         * tui/tui-winsource.c (tui_show_source_line): Use
6644         tui_set_reverse_mode instead of setting A_STANDOUT.
6645         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6646         New setter methods.
6647
6648 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6649
6650         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6651         Handle tabs.
6652
6653 2019-03-18  Tom Tromey  <tromey@adacore.com>
6654
6655         * ada-lang.c (empty_array): Add "high" parameter.
6656         (ada_evaluate_subexp): Update.
6657
6658 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6659
6660         * unittests/string_view-selftests.c: Define
6661         _initialize_string_view_selftests unconditionally.
6662
6663 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6664
6665         PR gdb/24350
6666         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6667
6668 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6669
6670         PR gdb/24351
6671         * windows-nat.c (display_selector): Fix format specifiers.
6672
6673 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6674
6675         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6676         tui_refill_source_window instead of tui_refresh_win, to update the
6677         current execution line.  This fixes redisplay of the current line
6678         when stepping through the code with "next" or "step".
6679
6680 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6681
6682         * source-cache.c (source_cache::get_source_lines): Call
6683         find_source_lines to initialize s->nlines.  This fixes vertical
6684         scrolling of TUI source window when the DOWN arrow is pressed.
6685
6686 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6687
6688         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6689         linux-thread-db.c (_initialize_thread_db): Likewise.
6690
6691 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6692
6693         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6694         wclrtoeol in tui_show_source_line".  This reverts changes made in
6695         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6696
6697 2019-03-15  Tom Tromey  <tom@tromey.com>
6698
6699         * symtab.h (struct minimal_symbol): Derive from
6700         general_symbol_info.
6701         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6702         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6703         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6704         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6705         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6706         (MSYMBOL_SEARCH_NAME): Update.
6707         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6708         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6709         * minsyms.c (minimal_symbol_reader::record_full): Update.
6710
6711 2019-03-15  Tom Tromey  <tom@tromey.com>
6712
6713         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6714
6715 2019-03-15  Tom Tromey  <tom@tromey.com>
6716
6717         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6718         unique_xmalloc_ptr.
6719         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6720         Update.
6721         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6722         (build_minimal_symbol_hash_tables)
6723         (minimal_symbol_reader::install): Update.
6724
6725 2019-03-15  Tom Tromey  <tom@tromey.com>
6726
6727         * symtab.c (create_demangled_names_hash): Update.
6728         (symbol_set_names): Update.
6729         * objfiles.h (struct objfile_per_bfd_storage)
6730         <demangled_names_hash>: Now an htab_up.
6731         * objfiles.c (objfile_per_bfd_storage): Simplify.
6732
6733 2019-03-15  Tom Tromey  <tom@tromey.com>
6734
6735         * objfiles.h (struct objfile_per_bfd_storage): Declare
6736         destructor.
6737         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6738         New.
6739         (get_objfile_bfd_data): Use new.  Don't initialize
6740         language_of_main.
6741         (free_objfile_per_bfd_storage): Remove.
6742         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6743
6744 2019-03-15  Tom Tromey  <tom@tromey.com>
6745
6746         * symfile.c (reread_symbols): Update.
6747         * objfiles.c (objfile::objfile): Update.
6748         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6749         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6750         comment.
6751         (minimal_symbol_reader::install): Update.
6752         (terminate_minimal_symbol_table): Remove.
6753         * jit.c (jit_object_close_impl): Update.
6754
6755 2019-03-15  Tom Tromey  <tom@tromey.com>
6756
6757         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6758         initializations.
6759
6760 2019-03-15  Tom Tromey  <tom@tromey.com>
6761
6762         * objfiles.h (struct objfile_per_bfd_storage)
6763         <demangled_hash_languages>: Now a bitset.
6764         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6765         (lookup_minimal_symbol): Update.
6766
6767 2019-03-15  Tom Tromey  <tom@tromey.com>
6768
6769         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6770         Don't return the symbol.
6771         * coffread.c (record_minimal_symbol): Use record_full.
6772
6773 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6774
6775         The MS-Windows port of ncurses fails to switch to a color pair if
6776         one or both of the colors are the implicit default colors.  This
6777         change records the default colors when TUI is initialized, and
6778         then specifies them explicitly when a color pair uses the default
6779         colors.  This allows color styling in TUI mode on MS-Windows.
6780
6781         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6782         ncurses_norm_attr.
6783         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6784         colors in ncurses_norm_attr.
6785         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6786         "none", replace it with the default color recorded in
6787         ncurses_norm_attr.
6788
6789 2019-03-14  Tom Tromey  <tromey@adacore.com>
6790
6791         * source-cache.h (class source_cache) <get_source_lines>: Return
6792         std::string.
6793         * source-cache.c (source_cache::extract_lines): Handle case where
6794         first_pos==npos.  Return std::string.
6795         (source_cache::get_source_lines): Update.
6796
6797 2019-03-14  Tom Tromey  <tromey@adacore.com>
6798
6799         * NEWS: Add item for "style sources" commands.
6800         * source-cache.c (source_cache::get_source_lines): Check
6801         source_styling.
6802         * cli/cli-style.c (source_styling): New global.
6803         (_initialize_cli_style): Add "style sources" commands.
6804         (show_style_sources): New function.
6805         * cli/cli-style.h (source_styling): Declare.
6806
6807 2019-03-14  Pedro Alves  <palves@redhat.com>
6808             Tom Tromey  <tromey@adacore.com>
6809
6810         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6811         * tui/tui-winsource.c (tui_refill_source_window): New function,
6812         from...
6813         (tui_horizontal_source_scroll): ... here.  Move some logic.
6814         * cli/cli-style.c (set_style_enabled): Notify new observable.
6815         * tui/tui-hooks.c (tui_redisplay_source): New function.
6816         (tui_attach_detach_observers): Attach or detach
6817         tui_redisplay_source.
6818         * observable.h (source_styling_changed): New observable.
6819         * observable.c: Define source_styling_changed observable.
6820
6821 2019-03-13  Tom Tromey  <tromey@adacore.com>
6822
6823         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6824         (i386_gnu_nat_target::store_registers): Update.
6825         * target-debug.h (target_debug_print_std_string): New macro.
6826         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6827         * windows-tdep.c (display_one_tib): Update.
6828         * tui/tui-stack.c (tui_make_status_line): Update.
6829         * top.c (print_inferior_quit_action): Update.
6830         * thread.c (thr_try_catch_cmd): Update.
6831         (add_thread_with_info): Update.
6832         (thread_target_id_str): Update.
6833         (thr_try_catch_cmd): Update.
6834         (thread_command): Update.
6835         (thread_find_command): Update.
6836         * record-btrace.c (record_btrace_target::info_record)
6837         (record_btrace_resume_thread, record_btrace_target::resume)
6838         (record_btrace_cancel_resume, record_btrace_step_thread)
6839         (record_btrace_target::wait, record_btrace_target::wait)
6840         (record_btrace_target::wait, record_btrace_target::stop): Update.
6841         * progspace.c (print_program_space): Update.
6842         * process-stratum-target.c
6843         (process_stratum_target::thread_address_space): Update.
6844         * linux-fork.c (linux_fork_mourn_inferior)
6845         (detach_checkpoint_command, info_checkpoints_command)
6846         (linux_fork_context): Update.
6847         (linux_fork_detach): Update.
6848         (class scoped_switch_fork_info): Update.
6849         (delete_checkpoint_command): Update.
6850         * infrun.c (follow_fork_inferior): Update.
6851         (follow_fork_inferior): Update.
6852         (proceed_after_vfork_done): Update.
6853         (handle_vfork_child_exec_or_exit): Update.
6854         (follow_exec): Update.
6855         (displaced_step_prepare_throw): Update.
6856         (displaced_step_restore): Update.
6857         (start_step_over): Update.
6858         (resume_1): Update.
6859         (clear_proceed_status_thread): Update.
6860         (proceed): Update.
6861         (print_target_wait_results): Update.
6862         (do_target_wait): Update.
6863         (context_switch): Update.
6864         (stop_all_threads): Update.
6865         (restart_threads): Update.
6866         (finish_step_over): Update.
6867         (handle_signal_stop): Update.
6868         (switch_back_to_stepped_thread): Update.
6869         (keep_going_pass_signal): Update.
6870         (print_exited_reason): Update.
6871         (normal_stop): Update.
6872         * inferior.c (inferior_pid_to_str): Change return type.
6873         (print_selected_inferior): Update.
6874         (add_inferior): Update.
6875         (detach_inferior): Update.
6876         * dummy-frame.c (fprint_dummy_frames): Update.
6877         * dcache.c (dcache_info_1): Update.
6878         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6879         (btrace_fetch, btrace_clear): Update.
6880         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6881         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6882         type.
6883         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6884         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6885         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6886         * gdbarch.c, gdbarch.h: Rebuild.
6887         * gdbarch.sh (core_pid_to_str): Change return type.
6888         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6889         return type.
6890         (windows_nat_target::pid_to_str): Change return type.
6891         (windows_delete_thread): Update.
6892         (windows_nat_target::attach): Update.
6893         (windows_nat_target::files_info): Update.
6894         * target-delegates.c: Rebuild.
6895         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6896         return type.
6897         (sol_thread_target::pid_to_str): Change return type.
6898         * remote.c (class remote_target) <pid_to_str>: Change return
6899         type.
6900         (remote_target::pid_to_str): Change return type.
6901         (extended_remote_target::attach, remote_target::remote_stop_ns)
6902         (remote_target::remote_notif_remove_queued_reply)
6903         (remote_target::push_stop_reply, remote_target::disable_btrace):
6904         Update.
6905         (extended_remote_target::attach): Update.
6906         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6907         type.
6908         (gdbsim_target::pid_to_str): Change return type.
6909         * ravenscar-thread.c (struct ravenscar_thread_target)
6910         <pid_to_str>: Change return type.
6911         (ravenscar_thread_target::pid_to_str): Change return type.
6912         * procfs.c (class procfs_target) <pid_to_str>: Change return
6913         type.
6914         (procfs_target::pid_to_str): Change return type.
6915         (procfs_target::attach): Update.
6916         (procfs_target::detach): Update.
6917         (procfs_target::fetch_registers): Update.
6918         (procfs_target::store_registers): Update.
6919         (procfs_target::wait): Update.
6920         (procfs_target::files_info): Update.
6921         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6922         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6923         return type.
6924         (nto_procfs_target::pid_to_str): Change return type.
6925         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6926         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6927         return type.
6928         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6929         (exit_lwp): Update.
6930         (attach_proc_task_lwp_callback, get_detach_signal)
6931         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6932         (linux_nat_target::resume, wait_lwp, stop_callback)
6933         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6934         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6935         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6936         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6937         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6938         type.
6939         (inf_ptrace_target::attach): Update.
6940         (inf_ptrace_target::files_info): Update.
6941         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6942         type.
6943         (go32_nat_target::pid_to_str): Change return type.
6944         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6945         (gnu_nat_target::wait): Update.
6946         (gnu_nat_target::wait): Update.
6947         (gnu_nat_target::resume): Update.
6948         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6949         (fbsd_nat_target::wait): Update.
6950         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6951         type.
6952         (darwin_nat_target::attach): Update.
6953         * corelow.c (class core_target) <pid_to_str>: Change return type.
6954         (core_target::pid_to_str): Change return type.
6955         * target.c (normal_pid_to_str): Change return type.
6956         (default_pid_to_str): Likewise.
6957         (target_pid_to_str): Change return type.
6958         (target_translate_tls_address): Update.
6959         (target_announce_detach): Update.
6960         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6961         return type.
6962         (bsd_uthread_target::pid_to_str): Change return type.
6963         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6964         type.
6965         (bsd_kvm_target::pid_to_str): Change return type.
6966         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6967         return type.
6968         (aix_thread_target::pid_to_str): Change return type.
6969         * target.h (struct target_ops) <pid_to_str>: Change return type.
6970         (target_pid_to_str, normal_pid_to_str): Likewise.
6971         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6972         type.
6973         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6974         type.
6975         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6976         return type.
6977         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6978         type.
6979         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6980         type.
6981         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6982         return type.
6983
6984 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6985
6986         * NEWS: Mention that the new default MI version is 3.  Mention
6987         changes to the output of commands and events that deal with
6988         multi-location breakpoints.
6989         * breakpoint.c: Include "mi/mi-out.h".
6990         (print_one_breakpoint): Change output syntax if using MI version
6991         >= 3.
6992         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6993         New.
6994         (mi_multi_location_breakpoint_output_fixed): New.
6995         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6996         (mi_cmd_fix_multi_location_breakpoint_output): New.
6997         (mi_multi_location_breakpoint_output_fixed): New.
6998         * mi/mi-cmds.c (mi_cmds): Register command
6999         -fix-multi-location-breakpoint-output.
7000         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7001         interpreter "mi".
7002
7003 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7004
7005         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7006         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7007         instantiate mi_ui_out based on interpreter name.
7008         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7009         * mi/mi-main.c (mi_load_progress): Likewise.
7010
7011 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7012
7013         * NEWS: Combine separate "New targets" sections for 8.3.
7014
7015 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7016
7017         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7018         (ppcfbsd_init_abi): Install gdbarch
7019         "fetch_tls_load_module_address" and "get_thread_local_address"
7020         methods.
7021
7022 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7023
7024         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7025         (riscv_fbsd_init_abi): Install gdbarch
7026         "fetch_tls_load_module_address" and "get_thread_local_address"
7027         methods.
7028
7029 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7030
7031         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7032         (i386fbsd_init_abi): Install gdbarch
7033         "fetch_tls_load_module_address" and "get_thread_local_address"
7034         methods.
7035
7036 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7037
7038         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7039         (amd64fbsd_init_abi): Install gdbarch
7040         "fetch_tls_load_module_address" and "get_thread_local_address"
7041         methods.
7042
7043 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7044
7045         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7046         (struct fbsd_pspace_data): New type.
7047         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7048         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7049         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7050         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7051         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7052
7053 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7054
7055         * gdbtypes.c (lookup_struct_elt): New function.
7056         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7057         * gdbtypes.h (struct struct_elt): New type.
7058         (lookup_struct_elt): New prototype.
7059
7060 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7061
7062         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7063         remove disabled code block.
7064
7065 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7066
7067         * gdbarch.sh (get_thread_local_address): New method.
7068         * gdbarch.h, gdbarch.c: Regenerate.
7069         * target.c (target_translate_tls_address): Use
7070         gdbarch_get_thread_local_address if present instead of
7071         target::get_thread_local_address.
7072
7073 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7074
7075         * target.h (target::get_thread_local_address): Update comment.
7076
7077 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7078
7079         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7080         objfile->separate_debug_objfile_backlink if not NULL.
7081
7082 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7083
7084         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7085         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7086         (amd64bsd_store_inferior_registers): Likewise.
7087         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7088         Enable segment base registers.
7089         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7090         PT_GETFSBASE and PT_GETGSBASE.
7091         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7092         PT_SETGSBASE.
7093         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7094         segment base registers.
7095         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7096
7097 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7098
7099         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7100         Update calls to i386_target_description to add 'segments'
7101         parameter.
7102         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7103         add segment base registers.
7104         * arch/i386.c (i386_create_target_description): Add 'segments'
7105         parameter to enable segment base registers.
7106         * arch/i386.h (i386_create_target_description): Likewise.
7107         * features/i386/32bit-segments.xml: New file.
7108         * features/i386/32bit-segments.c: Generate.
7109         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7110         call to i386_target_description to add 'segments' parameter.
7111         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7112         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7113         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7114         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7115         if feature is present.
7116         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7117         Add 'segments' parameter to call to i386_target_description.
7118         (i386_target_description): Add 'segments' parameter to enable
7119         segment base registers.
7120         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7121         to call to i386_target_description.
7122         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7123         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7124         Define I386_NUM_REGS.
7125         (i386_target_description): Add 'segments' parameter to enable
7126         segment base registers.
7127
7128 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7129
7130         PR/24325
7131         * source-cache.c: #undef open and close, to avoid unresolved
7132         externals during linking.
7133
7134 2019-03-12  Tom Tromey  <tromey@adacore.com>
7135
7136         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7137         const.  Add initializers.
7138         (_initialize_remote): Don't initialize ptid globals.
7139
7140 2019-03-12  Pedro Alves  <palves@redhat.com>
7141
7142         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7143
7144 2019-03-12  Pedro Alves  <palves@redhat.com>
7145
7146         * cp-name-parser.y (main): Remove unused 'len' variable.
7147
7148 2019-03-12  Tom Tromey  <tromey@adacore.com>
7149
7150         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7151         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7152
7153 2019-03-12  Tom Tromey  <tromey@adacore.com>
7154
7155         * linux-nat.c (iterate_over_lwps): Update.
7156         (stop_callback): Remove parameter.
7157         (stop_wait_callback, detach_callback, resume_set_callback)
7158         (select_singlestep_lwp_callback, set_ignore_sigint)
7159         (status_callback, resumed_callback, resume_clear_callback)
7160         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7161         data parameter.
7162         (linux_nat_target::detach, linux_nat_target::resume)
7163         (linux_stop_and_wait_all_lwps, select_event_lwp)
7164         (linux_nat_filter_event, linux_nat_wait_1)
7165         (linux_nat_target::kill, linux_nat_target::stop)
7166         (linux_nat_target::stop): Update.
7167         (linux_nat_resume_callback): Change type.
7168         (resume_stopped_resumed_lwps, count_events_callback)
7169         (select_event_lwp_callback): Likewise.
7170         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7171         * arm-linux-nat.c (struct update_registers_data): Remove.
7172         (update_registers_callback): Change type.
7173         (arm_linux_insert_hw_breakpoint1): Update.
7174         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7175         parameter.
7176         (x86_linux_dr_set_addr): Update.
7177         (x86_linux_dr_set_control): Update.
7178         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7179         (iterate_over_lwps): Use gdb::function_view.
7180         * nat/aarch64-linux-hw-point.c (struct
7181         aarch64_dr_update_callback_param): Remove.
7182         (debug_reg_change_callback): Change type.
7183         (aarch64_notify_debug_reg_change): Update.
7184         * s390-linux-nat.c (s390_refresh_per_info): Update.
7185
7186 2019-03-11  Tom Tromey  <tromey@adacore.com>
7187
7188         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7189         redundant assignment to "this_cu".
7190
7191 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7192
7193         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7194
7195 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7196
7197         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7198         from...
7199         (rank_one_type): ... this.
7200
7201 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7202
7203         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7204         from...
7205         (rank_one_type): ... this.
7206
7207 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7208
7209         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7210         from...
7211         (rank_one_type): ... this.
7212
7213 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7214
7215         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7216         from...
7217         (rank_one_type): ... this.
7218
7219 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7220
7221         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7222         from...
7223         (rank_one_type): ... this.
7224
7225 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7226
7227         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7228         from...
7229         (rank_one_type): ... this.
7230
7231 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7232
7233         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7234         from...
7235         (rank_one_type): ... this.
7236
7237 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7238
7239         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7240         from...
7241         (rank_one_type): ... this.
7242
7243 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7244
7245         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7246         from...
7247         (rank_one_type): ... this.
7248
7249 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7250
7251         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7252         from...
7253         (rank_one_type): ... this.
7254
7255 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7256
7257         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7258         from...
7259         (rank_one_type): ... this.
7260
7261 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7262
7263         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7264         from...
7265         (rank_one_type): ... this.
7266
7267 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7268
7269         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7270         inferior-events' shows the example events.
7271
7272 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7273
7274         Support styling on native MS-Windows console
7275
7276         PR/24315
7277         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7278         on MS-Windows if $TERM is not defined.
7279
7280         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7281
7282         * posix-hdep.c (gdb_console_fputs):
7283         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7284         functions.
7285         * ui-file.h (gdb_console_fputs): Add prototype.
7286
7287         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7288         back to fputs only if the former returns zero.
7289
7290 2019-03-07  Tom Tromey  <tom@tromey.com>
7291
7292         * symmisc.c (print_symbol_bcache_statistics): Update.
7293         (print_objfile_statistics): Update.
7294         * symfile.c (allocate_symtab): Update.
7295         * stabsread.c: Don't include bcache.h.
7296         * psymtab.h (struct psymbol_bcache): Don't declare.
7297         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7298         (psymbol_bcache_init, psymbol_bcache_free)
7299         (psymbol_bcache_get_bcache): Don't declare.
7300         * psymtab.c (struct psymbol_bcache): Remove.
7301         (psymtab_storage::psymtab_storage): Update.
7302         (psymtab_storage::~psymtab_storage): Update.
7303         (psymbol_bcache_init, psymbol_bcache_free)
7304         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7305         (add_psymbol_to_bcache): Update.
7306         (allocate_psymtab): Update.
7307         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7308         macro_cache>: No longer pointers.
7309         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7310         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7311         * macrotab.c (macro_bcache): Update.
7312         * macroexp.c: Don't include bcache.h.
7313         * gdbtypes.c (check_types_worklist): Update.
7314         (types_deeply_equal): Remove TRY/CATCH.  Update.
7315         * elfread.c (elf_symtab_read): Update.
7316         * dwarf2read.c: Don't include bcache.h.
7317         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7318         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7319         (print_bcache_statistics, bcache_memory_used): Don't declare.
7320         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7321         methods.  Rename all data members.
7322         * bcache.c (struct bcache): Move to bcache.h.
7323         (bcache::expand_hash_table): Rename from expand_hash_table.
7324         (bcache): Remove.
7325         (bcache::insert): Rename from bcache_full.
7326         (bcache::compare): Rename from bcache_compare.
7327         (bcache_xmalloc): Remove.
7328         (bcache::~bcache): Rename from bcache_xfree.
7329         (bcache::print_statistics): Rename from print_bcache_statistics.
7330         (bcache::memory_used): Rename from bcache_memory_used.
7331
7332 2019-03-07  Pedro Alves  <palves@redhat.com>
7333
7334         * infrun.c (normal_stop): Also check for
7335         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7336
7337 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7338
7339         * f-lang.c (value_from_host_double): Moved to...
7340         * value.c (value_from_host_double): ...here.
7341         * value.h (value_from_host_double): Declare.
7342         * guile/scm-math.c (vlscm_convert_typed_number): Use
7343         value_from_host_double.
7344         (vlscm_convert_number): Likewise.
7345         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7346         * python/py-value.c (convert_value_from_python): Likewise.
7347
7348 2019-03-06  Tom Tromey  <tom@tromey.com>
7349
7350         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7351
7352 2019-03-06  Tom Tromey  <tom@tromey.com>
7353
7354         * utils.h (free_current_contents): Don't declare.
7355         * utils.c (free_current_contents): Remove.
7356
7357 2019-03-06  Tom Tromey  <tom@tromey.com>
7358
7359         * top.c (quit_force): Update.
7360         * main.c (captured_command_loop): Update.
7361         * common/new-op.c (operator new): Update.
7362         * common/common-exceptions.c (struct catcher)
7363         <save_cleanup_chain>: Remove member.
7364         (exceptions_state_mc_init): Update.
7365         (exception_try_scope_entry): Return nullptr.
7366         (exception_try_scope_exit, exception_rethrow)
7367         (throw_exception_sjlj, throw_exception_cxx): Update.
7368         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7369         (all_cleanups, do_cleanups, discard_cleanups)
7370         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7371         (restore_cleanups, restore_final_cleanups): Don't declare.
7372         (do_final_cleanups): Remove parameter.
7373         * common/cleanups.c (cleanup_chain, make_cleanup)
7374         (make_cleanup_dtor, all_cleanups, do_cleanups)
7375         (discard_my_cleanups, discard_cleanups)
7376         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7377         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7378         (null_cleanup): Remove.
7379         (do_final_cleanups): Remove parameter.
7380
7381 2019-03-06  Tom Tromey  <tom@tromey.com>
7382
7383         * remote.c (remote_target::remote_parse_stop_reply): Use
7384         unique_xmalloc_ptr.
7385
7386 2019-03-06  Tom Tromey  <tom@tromey.com>
7387
7388         * stabsread.c (struct stabs_field_info): Rename from field_info.
7389         <list, fnlist>: Add initializers.
7390         <obstack>: New member.
7391         (read_member_functions, read_struct_fields, read_baseclasses):
7392         Allocate on obstack.  Don't use cleanups.
7393         (read_one_struct_field, read_member_functions, read_struct_fields)
7394         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7395         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7396         (read_struct_type): Update.
7397
7398 2019-03-06  Tom Tromey  <tom@tromey.com>
7399
7400         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7401         * common/filestuff.h (make_cleanup_close): Don't declare.
7402         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7403         Remove.
7404
7405 2019-03-06  Tom Tromey  <tom@tromey.com>
7406
7407         * solib-aix.c: Use make_scope_exit.
7408
7409 2019-03-06  Tom Tromey  <tom@tromey.com>
7410
7411         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7412         Use make_scope_exit.
7413
7414 2019-03-06  Tom Tromey  <tom@tromey.com>
7415
7416         * solib-svr4.c (disable_probes_interface): Remove parameter.
7417         (svr4_handle_solib_event): Use make_scope_exit.
7418
7419 2019-03-06  Tom Tromey  <tom@tromey.com>
7420
7421         * remote.c (struct stop_reply_deleter): Remove.
7422         (stop_reply_up): Update.
7423         (struct stop_reply): Derive from notif_event.  Don't typedef.
7424         <regcache>: Now a std::vector.
7425         (stop_reply_xfree): Remove.
7426         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7427         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7428         (remote_target::discard_pending_stop_replies): Use delete.
7429         (remote_target::remote_parse_stop_reply): Update.
7430         (remote_target::process_stop_reply): Update.
7431         * remote-notif.h (struct notif_event): Add virtual destructor.
7432         Remove "dtr" member.
7433         (struct notif_client) <alloc_event>: Return a unique_ptr.
7434         (notif_event_xfree): Don't declare.
7435         (notif_event_up): New typedef.
7436         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7437         (notif_event_xfree, do_notif_event_xfree): Remove.
7438         (remote_notif_state_xfree): Update.
7439
7440 2019-03-06  Tom Tromey  <tom@tromey.com>
7441
7442         * infrun.c (displaced_step_clear_cleanup): Now a
7443         forward_scope_exit type.
7444         (displaced_step_prepare_throw): Update.
7445         (displaced_step_fixup): Update.
7446
7447 2019-03-06  Tom Tromey  <tom@tromey.com>
7448
7449         * inferior.h (class inferior): Update comment.
7450         * gdbthread.h (class thread_info): Update comment.
7451
7452 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7453             Tom Tromey  <tom@tromey.com>
7454
7455         * stabsread.h (struct stab_section_list): Remove.
7456         (coffstab_build_psymtabs): Update.
7457         * dbxread.c (symbuf_sections): Now a std::vector.
7458         (sect_idx): New global.
7459         (fill_symbuf): Update.
7460         (coffstab_build_psymtabs): Change type of stabsects parameter.
7461         Update.
7462         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7463         std::vector.
7464         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7465         (coff_locate_sections): Update.
7466         (coff_symfile_read): Remove cleanups.  Update.
7467         (init_stringtab): Add storage parameter.
7468         (free_stringtab, free_stringtab_cleanup): Remove.
7469         (init_lineno): Add storage parameter.
7470         (free_linetab, free_linetab_cleanup): Remove.
7471
7472 2019-03-06  Pedro Alves  <palves@redhat.com>
7473
7474         * linux-fork.c (fork_info::clobber_regs): Delete.
7475         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7476         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7477         comment.  Adjust.
7478         (scoped_switch_fork_info::scoped_switch_fork_info)
7479         (checkpoint_command, linux_fork_context): Adjust
7480         fork_save_infrun_state calls.
7481
7482 2019-03-06  Pedro Alves  <palves@redhat.com>
7483
7484         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7485         (inf_has_multiple_threads): Return 'bool' and rewrite using
7486         inferior_info::threads().
7487
7488 2019-03-06  Pedro Alves  <palves@redhat.com>
7489
7490         * linux-fork.c: Include <list>.
7491         (fork_list): Now a std::list instance.
7492         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7493         (forks_exist_p, find_last_fork): Adjust.
7494         (new_fork): Delete.
7495         (one_fork_p): New.
7496         (add_fork): Adjust.
7497         (free_fork): Delete, folded into fork_info::~fork_info().
7498         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7499         Adjust.
7500         (init_fork_list): Delete.
7501         (linux_fork_killall, linux_fork_mourn_inferior)
7502         (linux_fork_detach, info_checkpoints_command): Adjust.
7503         (_initialize_linux_fork): No longer call init_fork_list.
7504
7505 2019-03-06  Pedro Alves  <palves@redhat.com>
7506
7507         * linux-fork.c (new_fork): New, split out of ...
7508         (add_fork): ... this.  Return void.  Move "first fork" special
7509         case from here, to ...
7510         (checkpoint_command): ... here.
7511         * linux-linux.h (add_fork): Return void.
7512
7513 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7514
7515         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7516
7517 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7518             Chris January  <chris.january@arm.com>
7519             David Lecomber  <david.lecomber@arm.com>
7520
7521         * f-exp.y: New token, UNOP_INTRINSIC.
7522         (exp): New pattern using UNOP_INTRINSIC token.
7523         (f77_keywords): Add 'abs' keyword.
7524         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7525         (value_from_host_double): New function.
7526         (evaluate_subexp_f): Support UNOP_ABS.
7527
7528 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7529
7530         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7531         types.
7532
7533 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7534
7535         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7536         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7537         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7538
7539 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7540
7541         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7542
7543 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7544             Chris January  <chris.january@arm.com>
7545
7546         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7547         * f-exp.y: Define 'KIND' token.
7548         (exp): New pattern for KIND expressions.
7549         (ptype): Handle types with a kind extension.
7550         (direct_abs_decl): Extend to spot kind extensions.
7551         (f77_keywords): Add 'kind' to the list.
7552         (push_kind_type): New function.
7553         (convert_to_kind_type): New function.
7554         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7555         * parse.c (operator_length_standard): Likewise.
7556         * parser-defs.h (enum type_pieces): Add tp_kind.
7557         * std-operator.def: Add UNOP_KIND.
7558
7559 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7560
7561         * f-exp.y (f_parse): Set yydebug.
7562
7563 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7564
7565         * f-lang.c (evaluate_subexp_f): New function.
7566         (exp_descriptor_f): New global.
7567         (f_language_defn): Use exp_descriptor_f instead of
7568         exp_descriptor_standard.
7569
7570 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7571
7572         * f-exp.y (struct token): Add comments.
7573         (dot_ops): Remove uppercase versions and the end marker.
7574         (f77_keywords): Likewise.
7575         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7576         entries in the dot_ops array are case insensitive, and use
7577         strncasecmp to compare strings.  Also some whitespace cleanup in
7578         this area.  Similar for the f77_keywords array, except entries in
7579         this list might be case sensitive.
7580
7581 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7582
7583         * f-exp.y (struct f77_boolean_val): Add comments.
7584         (boolean_values): Remove uppercase versions, and end marker.
7585         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7586         and use strncasecmp to achieve case insensitivity.  Additionally,
7587         perform whitespace cleanup around this code.
7588
7589 2019-03-06  Tom Tromey  <tromey@adacore.com>
7590
7591         * remote-sim.c (gdbsim_target_open): Use result of
7592         gdb_argv::release.
7593
7594 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7595         Dirk Schubert  <dirk.schubert@arm.com>
7596         Chris January  <chris.january@arm.com>
7597
7598         * eval.c (evaluate_subexp_standard): Call Fortran argument
7599         wrapping logic.
7600         * f-lang.c (struct value): A value which can be passed into a
7601         Fortran function call.
7602         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7603         where appropriate.
7604         (struct type): Value ready for a Fortran function call.
7605         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7606         is needed.
7607         * f-lang.h (fortran_argument_convert): Declaration.
7608         (fortran_preserve_arg_pointer): Declaration.
7609         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7610
7611 2019-03-05  Tom Tromey  <tromey@adacore.com>
7612
7613         * python/py-prettyprint.c (print_string_repr): Remove #if.
7614         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7615
7616 2019-03-05  Tom Tromey  <tromey@adacore.com>
7617
7618         * target.c (the_dummy_target): Move later.  Change type to
7619         "dummy_target".
7620         (initialize_targets): Don't initialize the_dummy_target.
7621
7622 2019-03-05  Tom Tromey  <tromey@adacore.com>
7623
7624         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7625         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7626
7627 2019-03-05  Tom Tromey  <tromey@adacore.com>
7628
7629         * windows-nat.c (windows_nat_target::attach)
7630         (windows_nat_target::detach): Don't call gdb_flush.
7631         * valprint.c (generic_val_print, val_print, val_print_string):
7632         Don't call gdb_flush.
7633         * utils.c (defaulted_query): Don't call gdb_flush.
7634         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7635         * target.c (target_announce_detach): Don't call gdb_flush.
7636         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7637         * remote.c (extended_remote_target::attach): Don't call
7638         gdb_flush.
7639         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7640         * printcmd.c (do_examine): Don't call gdb_flush.
7641         (info_display_command): Don't call gdb_flush.
7642         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7643         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7644         * memattr.c (info_mem_command): Don't call gdb_flush.
7645         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7646         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7647         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7648         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7649         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7650         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7651         (gnu_nat_target::detach): Don't call gdb_flush.
7652         * f-valprint.c (f_val_print): Don't call gdb_flush.
7653         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7654         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7655         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7656         gdb_flush.
7657         * c-valprint.c (c_val_print): Don't call gdb_flush.
7658         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7659
7660 2019-03-05  Tom Tromey  <tromey@adacore.com>
7661
7662         * varobj.c (update_dynamic_varobj_children): Update.
7663         (install_default_visualizer): Use reset, not release.
7664         * value.c (set_internalvar): Update.
7665         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7666         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7667         ATTRIBUTE_UNUSED_RESULT.
7668
7669 2019-03-05  Tom Tromey  <tromey@adacore.com>
7670
7671         * remote.c (class scoped_remote_fd) <release>: Add
7672         ATTRIBUTE_UNUSED_RESULT.
7673
7674 2019-03-05  Tom Tromey  <tromey@adacore.com>
7675
7676         * macroexp.c (struct macro_buffer) <release>: Add
7677         ATTRIBUTE_UNUSED_RESULT.
7678
7679 2019-03-05  Tom Tromey  <tromey@adacore.com>
7680
7681         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7682         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7683         ATTRIBUTE_UNUSED_RESULT.
7684
7685 2019-03-05  Tom Tromey  <tromey@adacore.com>
7686
7687         * common/scoped_fd.h (class scoped_fd) <release>: Add
7688         ATTRIBUTE_UNUSED_RESULT.
7689
7690 2019-03-05  Tom Tromey  <tromey@adacore.com>
7691
7692         * parser-defs.h (struct parser_state) <release>: Add
7693         ATTRIBUTE_UNUSED_RESULT.
7694
7695 2019-03-05  Tom Tromey  <tromey@adacore.com>
7696
7697         * utils.h (class gdb_argv) <release>: Add
7698         ATTRIBUTE_UNUSED_RESULT.
7699         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7700
7701 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7702
7703         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7704         for-loop range, to avoid compiler warnings.
7705
7706         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7707         avoid compiler warnings about unused variables.
7708
7709         * NEWS: Mention end of support for native debugging on MS-Windows
7710         before XP.
7711
7712         PR gdb/24292
7713         * common/netstuff.c:
7714         * gdbserver/gdbreplay.c
7715         * gdbserver/remote-utils.c:
7716         * ser-tcp.c:
7717         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7718         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7719         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7720         'getaddrinfo' and 'freeaddrinfo' were not available before
7721         Windows XP, and mingw.org's MinGW headers by default define
7722         _WIN32_WINNT to 0x500.
7723
7724 2019-03-01  Gary Benson <gbenson@redhat.com>
7725
7726         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7727
7728 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7729             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7730
7731         PR gdb/8527
7732         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7733         set_sigint_trap, clear_sigint_trap.
7734
7735 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7736
7737         * target.c (target_detach): Clear the regcache and the
7738         frame cache.
7739
7740 2019-02-27  Pedro Alves  <palves@redhat.com>
7741
7742         * utils.c (set_screen_size): When we cap the height/width sizes,
7743         tweak the corresponding command variable to show "unlimited":
7744
7745 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7746             Pedro Alves  <palves@redhat.com>
7747
7748         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7749         before calling rl_set_screen_size.
7750
7751 2019-02-27  Tom Tromey  <tromey@adacore.com>
7752
7753         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7754         define.
7755         * python/py-value.c: Remove Python 2.4 workaround.
7756         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7757         workaround.
7758         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7759         Python 2.4 workaround.
7760         * python/python-internal.h: Remove Python 2.4 comment.
7761         (Py_ssize_t): Don't define.
7762         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7763         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7764         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7765         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7766         * python/python.c (do_start_initialization): Remove Python 2.4
7767         workaround.
7768         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7769         (print_children): Remove Python 2.4 workaround.
7770         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7771         workaround.
7772         (CHARBUFFERPROC_NAME): Remove.
7773         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7774         Python 2.4 workaround.
7775
7776 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7777
7778         * NEWS: Note minimum Python version.
7779
7780 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7781
7782         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7783         code from these functions.  Remove corresponding ifdefs.  Use
7784         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7785         Remove gotos and target of gotos.
7786         (infpy_search_memory): Likewise.
7787
7788 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7789
7790         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7791         (hppa_gdbarch_init): Don't register deleted functions with
7792         gdbarch.
7793
7794 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7795
7796         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7797         (h8300_unwind_sp): Delete.
7798         (h8300_dummy_id): Delete.
7799         (h8300_gdbarch_init): Don't register deleted functions with
7800         gdbarch.
7801
7802 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7803
7804         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7805         (ft32_unwind_pc): Delete.
7806         (ft32_unwind_sp): Delete.
7807         (ft32_gdbarch_init): Don't register deleted functions with
7808         gdbarch.
7809
7810 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7811
7812         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7813         (frv_unwind_pc): Delete.
7814         (frv_unwind_sp): Delete.
7815         (frv_gdbarch_init): Don't register deleted functions with
7816         gdbarch.
7817
7818 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7819
7820         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7821         (riscv_unwind_pc): Delete.
7822         (riscv_unwind_sp): Delete.
7823         (riscv_gdbarch_init): Don't register deleted functions with
7824         gdbarch.
7825
7826 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7827
7828         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7829         (csky_unwind_pc): Delete.
7830         (csky_unwind_sp): Delete.
7831         (csky_gdbarch_init): Don't register deleted functions with
7832         gdbarch.
7833
7834 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7835
7836         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7837         (cris_unwind_pc): Delete.
7838         (cris_unwind_sp): Delete.
7839         (cris_gdbarch_init): Don't register deleted functions with
7840         gdbarch.
7841
7842 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7843
7844         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7845         (bfin_unwind_pc): Delete.
7846         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7847
7848 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7849
7850         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7851         (arm_unwind_pc): Delete.
7852         (arm_unwind_sp): Delete.
7853         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7854
7855 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7856
7857         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7858         (arc_unwind_pc): Delete.
7859         (arc_unwind_sp): Delete.
7860         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7861
7862 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7863
7864         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7865         (alpha_unwind_pc): Delete.
7866         (alpha_gdbarch_init): Don't register deleted functions with
7867         gdbarch.
7868
7869 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7870
7871         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7872         (aarch64_unwind_pc): Delete.
7873         (aarch64_unwind_sp): Delete.
7874         (aarch64_gdbarch_init): Don't register deleted functions with
7875         gdbarch.
7876
7877 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7878
7879         * gdbtypes.c (type_align): Don't consider static members when
7880         computing structure alignment.
7881
7882 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7883
7884         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7885         return 0 for other types.
7886         * arch-utils.c (default_type_align): Always return 0.
7887         * gdbarch.h: Regenerate.
7888         * gdbarch.sh (type_align): Extend comment.
7889         * gdbtypes.c (type_align): Add additional comments, always call
7890         gdbarch_type_align before applying the default rules.
7891         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7892         generic code will then apply a suitable default.
7893         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7894         types, return 0 for other types.
7895
7896 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7897
7898         * NEWS: Create a new section for the next release branch.
7899         Rename the section of the current branch, now that it has
7900         been cut.
7901
7902 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7903
7904         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7905         * version.in: Bump version to 8.3.50.DATE-git.
7906
7907 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7908
7909         * aix-thread.c (ptid_cmp): Remove unused variable.
7910         (get_signaled_thread): Likewise.
7911         (store_regs_user_thread): Likewise.
7912         (store_regs_kernel_thread): Likewise.
7913         (fetch_regs_kernel_thread): Remove shadowed variable.
7914
7915 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7916
7917         * features/riscv/32bit-cpu.xml: Add register numbers.
7918         * features/riscv/32bit-fpu.c: Regenerate.
7919         * features/riscv/32bit-fpu.xml: Add register numbers.
7920         * features/riscv/64bit-cpu.xml: Add register numbers.
7921         * features/riscv/64bit-fpu.c: Regenerate.
7922         * features/riscv/64bit-fpu.xml: Add register numbers.
7923
7924 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7925
7926         * NEWS: Mention two argument form of gdb.Value constructor.
7927         * python/py-value.c (convert_buffer_and_type_to_value): New
7928         function.
7929         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7930         Add support for handling an optional second argument.  Call
7931         convert_buffer_and_type_to_value as appropriate.
7932         * python/python-internal.h (Py_buffer_deleter): New struct.
7933         (Py_buffer_up): New typedef.
7934
7935 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7936
7937         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7938         instead of releasing ownership.
7939
7940 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7941
7942         * dwarf2read.c (open_and_init_dwp_file): Call
7943         elf_numsections instead of bfd_count_sections to initialize
7944         dwp_file->num_sections.
7945
7946 2019-02-25  Tom Tromey  <tromey@adacore.com>
7947
7948         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7949
7950 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7951
7952         * gcore.in: Add '--readnever' option when invoking GDB.
7953
7954 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7955
7956         * MAINTAINERS: Update my email address.
7957
7958 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7959
7960         * build-id.c (build_id_to_debug_bfd_1): New function.
7961         (build_id_to_debug_bfd): Look for separate debug file in
7962         sysroot.
7963
7964 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7965
7966         * gdbarch.sh: Update the copyright year range that is placed into
7967         generated files.
7968
7969 2019-02-22  Keith Seitz  <keiths@redhat.com>
7970
7971         PR symtab/23853
7972         * linespec.c (create_sals_line_offset): Search for the default
7973         symtab's filename instead of its fullname.
7974
7975 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7976
7977         * NEWS: Update style defaults.
7978
7979 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7980
7981         * main.c (captured_main_1): Disable styling in batch mode.
7982
7983 2019-02-20  Tom Tromey  <tom@tromey.com>
7984
7985         * symtab.c (symtab_symbol_info): Fix typos.
7986
7987 2019-02-20  Tom Tromey  <tromey@adacore.com>
7988
7989         * findcmd.c (_initialize_mem_search): Use upper case for
7990         metasyntactic variables.
7991
7992 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7993
7994         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7995         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7996
7997 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7998
7999         * top.h (source_file_name): Change to std::string.
8000         * top.c (source_file_name): Likewise.
8001         (command_line_input): Adjust.
8002         * cli/cli-script.c (script_from_file): Adjust.
8003
8004 2019-02-19  Tom Tromey  <tromey@adacore.com>
8005
8006         * ravenscar-thread.c
8007         (ravenscar_thread_target::update_thread_list): Don't call
8008         ada_build_task_list.
8009         * ada-lang.h (ada_build_task_list): Don't declare.
8010         * ada-tasks.c (struct ada_tasks_inferior_data)
8011         <task_list_valid_p>: Now bool.
8012         (read_known_tasks, ada_task_list_changed)
8013         (ada_tasks_invalidate_inferior_data): Update.
8014         (read_known_tasks_array): Return bool.
8015         (read_known_tasks_list): Likewise.
8016         (read_known_tasks): Return void.
8017         (ada_build_task_list): Now static.
8018
8019 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8020
8021         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8022         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8023
8024 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8025
8026         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8027         variant for ada_tasks_pspace_data_handle and
8028         ada_tasks_inferior_data_handle.
8029         (ada_tasks_pspace_data_cleanup): New function.
8030         (ada_tasks_inferior_data_cleanup): New function.
8031
8032 2019-02-17  Tom Tromey  <tom@tromey.com>
8033
8034         * macrotab.h (macro_source_fullname): Return a std::string.
8035         * macrotab.c (macro_include, check_for_redefinition)
8036         (macro_undef, macro_lookup_definition, foreach_macro)
8037         (foreach_macro_in_scope): Update.
8038         (macro_source_fullname): Return a std::string.
8039         * macrocmd.c (show_pp_source_pos): Update.
8040
8041 2019-02-17  Tom Tromey  <tom@tromey.com>
8042
8043         * macrocmd.c (show_pp_source_pos): Style the file names.
8044
8045 2019-02-17  Tom Tromey  <tom@tromey.com>
8046
8047         PR tui/24197:
8048         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8049
8050 2019-02-17  Tom Tromey  <tom@tromey.com>
8051
8052         * ada-lang.c (user_select_syms): Use filtered printing.
8053         * utils.c (wrap_style): New global.
8054         (desired_style): Remove.
8055         (emit_style_escape): Add stream parameter.
8056         (set_output_style, reset_terminal_style, prompt_for_continue):
8057         Update.
8058         (flush_wrap_buffer): Only flush gdb_stdout.
8059         (wrap_here): Set wrap_style.
8060         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8061         treat escape sequences as a character.  Change when wrap buffer is
8062         flushed.
8063         (fputs_styled): Do not set the output style when the default is
8064         requested.
8065         * ui-style.h (struct ui_file_style) <is_default>: New method.
8066         * source.c (print_source_lines_base): Emit escape sequences in one
8067         piece.
8068
8069 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8070
8071         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8072         integers and enumeration types.
8073
8074 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8075
8076         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8077         instead of lookup_symbol_in_language
8078         (do_exact_match): New function.
8079         (ada_get_symbol_name_matcher): Return do_exact_match when
8080         doing a verbatim match.
8081
8082 2019-02-15  Tom Tromey  <tromey@adacore.com>
8083
8084         * ravenscar-thread.c (ravenscar_thread_target::resume)
8085         (ravenscar_thread_target::wait): Special case wildcard requests.
8086
8087 2019-02-15  Tom Tromey  <tromey@adacore.com>
8088
8089         * ravenscar-thread.c (base_ptid): Remove.
8090         (struct ravenscar_thread_target) <close>: New method.
8091         <m_base_ptid>: New member.
8092         <update_inferior_ptid, active_task, task_is_currently_active,
8093         runtime_initialized>: Declare methods.
8094         <ravenscar_thread_target>: Add constructor.
8095         (ravenscar_thread_target::task_is_currently_active)
8096         (ravenscar_thread_target::update_inferior_ptid)
8097         (ravenscar_runtime_initialized): Rename.  Now methods.
8098         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8099         (ravenscar_thread_target::update_thread_list): Update.
8100         (ravenscar_thread_target::active_task): Now method.
8101         (ravenscar_thread_target::store_registers)
8102         (ravenscar_thread_target::prepare_to_store)
8103         (ravenscar_thread_target::prepare_to_store)
8104         (ravenscar_thread_target::mourn_inferior): Update.
8105         (ravenscar_inferior_created): Use "new" to create target.
8106         (ravenscar_thread_target::get_ada_task_ptid): Update.
8107         (_initialize_ravenscar): Don't initialize base_ptid.
8108         (ravenscar_ops): Remove global.
8109
8110 2019-02-15  Tom Tromey  <tromey@adacore.com>
8111
8112         * target.h (push_target): Declare new overload.
8113         * target.c (push_target): New overload, taking an rvalue reference.
8114         * remote.c (remote_target::open_1): Use push_target overload.
8115         * corelow.c (core_target_open): Use push_target overload.
8116
8117 2019-02-15  Tom Tromey  <tromey@adacore.com>
8118
8119         * ravenscar-thread.c (is_ravenscar_task)
8120         (ravenscar_task_is_currently_active): Return bool.
8121         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8122         (_initialize_ravenscar): Remove "(void)".
8123         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8124         Return bool.
8125
8126 2019-02-15  Tom Tromey  <tromey@adacore.com>
8127
8128         * ravenscar-thread.c (ravenscar_runtime_initializer)
8129         (has_ravenscar_runtime, get_running_thread_id)
8130         (ravenscar_thread_target::resume): Fix indentation.
8131
8132 2019-02-15  Tom Tromey  <tromey@adacore.com>
8133
8134         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8135         from ravenscar_arch_ops.
8136         (sparc_ravenscar_ops::fetch_registers)
8137         (sparc_ravenscar_ops::store_registers): Now methods.
8138         (sparc_ravenscar_prepare_to_store): Remove.
8139         (sparc_ravenscar_ops): Redefine.
8140         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8141         methods and destructor.  Remove members.
8142         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8143         (ravenscar_thread_target::store_registers)
8144         (ravenscar_thread_target::prepare_to_store): Update.
8145         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8146         Remove.
8147         (struct ppc_ravenscar_powerpc_ops): Derive from
8148         ravenscar_arch_ops.
8149         (ppc_ravenscar_powerpc_ops::fetch_registers)
8150         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8151         (ppc_ravenscar_powerpc_ops): Redefine.
8152         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8153         (ppc_ravenscar_e500_ops::fetch_registers)
8154         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8155         (ppc_ravenscar_e500_ops): Redefine.
8156         * aarch64-ravenscar-thread.c
8157         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8158         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8159         (aarch64_ravenscar_fetch_registers)
8160         (aarch64_ravenscar_store_registers): Now methods.
8161         (aarch64_ravenscar_ops): Redefine.
8162
8163 2019-02-15  Tom Tromey  <tromey@adacore.com>
8164
8165         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8166         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8167         (ravenscar_thread_target::stopped_by_watchpoint)
8168         (ravenscar_thread_target::stopped_data_address)
8169         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8170
8171 2019-02-15  Tom Tromey  <tromey@adacore.com>
8172
8173         * ravenscar-thread.c: Fix some typos.
8174
8175 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8176             Tom Tromey  <tromey@adacore.com>
8177
8178         * ada-lang.c (ada_exception_sal): Change addr_string to a
8179         std::string.
8180         (create_ada_exception_catchpoint): Update.
8181
8182 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8183             Tom Tromey  <tromey@adacore.com>
8184
8185         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8186         (bp_location_ops): Remove.
8187         (base_breakpoint_allocate_location): Update.
8188         (free_bp_location): Update.
8189         * ada-lang.c (class ada_catchpoint_location)
8190         <ada_catchpoint_location>: Remove ops parameter.
8191         (ada_catchpoint_location_dtor): Remove.
8192         (ada_catchpoint_location_ops): Remove.
8193         (allocate_location_exception): Update.
8194         * breakpoint.h (struct bp_location_ops): Remove.
8195         (class bp_location) <bp_location>: Remove bp_location_ops
8196         parameter.
8197         <~bp_location>: Add destructor.
8198         <ops>: Remove.
8199
8200 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8201             Pedro Alves  <palves@redhat.com>
8202
8203         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8204         'PATH_MAX'.
8205
8206 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8207             Samuel Thibault  <samuel.thibault@gnu.org>
8208             Thomas Schwinge  <thomas@codesourcery.com>
8209
8210         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8211         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8212
8213 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8214
8215         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8216         (check_empty): Use "const char *".
8217
8218         * gnu-nat.c (gnu_nat_target::detach): Instead of
8219         'detach_inferior (pid)' call
8220         'detach_inferior (find_inferior_pid (pid))'.
8221
8222         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8223         'nat/fork-inferior.o'.
8224         * gnu-nat.c: #include "nat/fork-inferior.h".
8225
8226         * gnu-nat.c (gnu_nat_target::detach): Instead of
8227         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8228         * gnu-nat.h: #include "inf-child.h".
8229         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8230         'i386_gnu_nat_target::fetch_registers'.
8231         (gnu_store_registers): Rename/move to
8232         'i386_gnu_nat_target::store_registers'.
8233
8234         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8235         * gnu-nat.h (mach_thread_info): New function.
8236         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8237
8238         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8239
8240 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8241
8242         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8243
8244 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8245
8246         * windows-nat.c (windows_add_thread): Add new parameter
8247         "main_thread_p" with default value set to false.  Update
8248         function documentation as well as all callers.
8249         (windows_delete_thread): Likewise.
8250         (fake_create_process): Update call to windows_add_thread.
8251         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8252         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8253         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8254         call to windows_delete_thread.
8255
8256 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8257
8258         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8259
8260 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8261
8262         * symfile.c (find_separate_debug_file): Use canonical path of
8263         sysroot with child_path instead of gdb_sysroot if it is valid.
8264
8265 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8266
8267         * symfile.c (find_separate_debug_file): Use child_path to
8268         determine if an object file is under a sysroot.
8269
8270 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8271
8272         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8273         unittests/child-path-selftests.c.
8274         * common/pathstuff.c (child_path): New function.
8275         * common/pathstuff.h (child_path): New prototype.
8276         * unittests/child-path-selftests.c: New file.
8277
8278 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8279
8280         * symfile.c (find_separate_debug_file): Look for separate debug
8281         files in debug directories under the sysroot.
8282
8283 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8284
8285         * symtab.h (struct minimal_symbol data_p): New const method.
8286         (struct minimal_symbol text_p): Likewise.
8287         * symtab.c (output_source_filename): Use file name style
8288         to print file name.
8289         (print_symbol_info): Likewise.
8290         (print_msymbol_info): Use address style to print addresses.
8291         Use function name style to print executable text symbols.
8292         (expand_symtab_containing_pc): Use data_p.
8293         (find_pc_sect_compunit_symtab): Likewise.
8294
8295 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8296
8297         * breakpoint.c (describe_other_breakpoints): Use address style
8298         to print addresses.
8299         (say_where): Likewise.
8300
8301 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8302
8303         * ada-typeprint.c (print_func_type): Print function name
8304         style to print function name.
8305         * c-typeprint.c (c_print_type_1): Likewise.
8306
8307 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8308
8309         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8310         for execve.
8311
8312 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8313
8314         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8315         type_stack.
8316
8317 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8318
8319         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8320         TYPE_CODE_REF types.
8321
8322 2019-02-08  Jim Wilson  <jimw@sifive.com>
8323
8324         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8325         (riscv_linux_fregset): New.
8326         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8327
8328 2019-02-07  Tom Tromey  <tom@tromey.com>
8329
8330         * thread.c (thread_cancel_execution_command): Update.
8331         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8332         methods.
8333         (struct thread_fsm_ops): Remove.
8334         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8335         (thread_fsm_should_stop, thread_fsm_return_value)
8336         (thread_fsm_set_finished, thread_fsm_finished_p)
8337         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8338         Don't declare.
8339         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8340         * infrun.c (clear_proceed_status_thread)
8341         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8342         (print_stop_event): Update.
8343         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8344         Add constructor.
8345         (step_command_fsm_ops): Remove.
8346         (new_step_command_fsm): Remove.
8347         (step_1): Update.
8348         (step_command_fsm::should_stop): Rename from
8349         step_command_fsm_should_stop.
8350         (step_command_fsm::clean_up): Rename from
8351         step_command_fsm_clean_up.
8352         (step_command_fsm::do_async_reply_reason): Rename from
8353         step_command_fsm_async_reply_reason.
8354         (struct until_next_fsm): Inherit from thread_fsm.  Add
8355         constructor.
8356         (until_next_fsm_ops): Remove.
8357         (new_until_next_fsm): Remove.
8358         (until_next_fsm::should_stop): Rename from
8359         until_next_fsm_should_stop.
8360         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8361         (until_next_fsm::do_async_reply_reason): Rename from
8362         until_next_fsm_async_reply_reason.
8363         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8364         constructor.  Change type of breakpoint.
8365         (finish_command_fsm_ops): Remove.
8366         (new_finish_command_fsm): Remove.
8367         (finish_command_fsm::should_stop): Rename from
8368         finish_command_fsm_should_stop.
8369         (finish_command_fsm::clean_up): Rename from
8370         finish_command_fsm_clean_up.
8371         (finish_command_fsm::return_value): Rename from
8372         finish_command_fsm_return_value.
8373         (finish_command_fsm::do_async_reply_reason): Rename from
8374         finish_command_fsm_async_reply_reason.
8375         (finish_command): Update.
8376         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8377         Add constructor.
8378         (call_thread_fsm_ops): Remove.
8379         (call_thread_fsm::call_thread_fsm): Rename from
8380         new_call_thread_fsm.
8381         (call_thread_fsm::should_stop): Rename from
8382         call_thread_fsm_should_stop.
8383         (call_thread_fsm::should_notify_stop): Rename from
8384         call_thread_fsm_should_notify_stop.
8385         (run_inferior_call, call_function_by_hand_dummy): Update.
8386         * cli/cli-interp.c (should_print_stop_to_console): Update.
8387         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8388         Add constructor.  Change type of location_breakpoint,
8389         caller_breakpoint.
8390         (until_break_fsm_ops): Remove.
8391         (new_until_break_fsm): Remove.
8392         (until_break_fsm::should_stop): Rename from
8393         until_break_fsm_should_stop.
8394         (until_break_fsm::clean_up): Rename from
8395         until_break_fsm_clean_up.
8396         (until_break_fsm::do_async_reply_reason): Rename from
8397         until_break_fsm_async_reply_reason.
8398         (until_break_command): Update.
8399         * thread-fsm.c: Remove.
8400         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8401
8402 2019-02-07  Tom Tromey  <tom@tromey.com>
8403
8404         * yy-remap.h: Add include guard.
8405         * xtensa-tdep.h: Add include guard.
8406         * xcoffread.h: Rename include guard.
8407         * varobj-iter.h: Add include guard.
8408         * tui/tui.h: Rename include guard.
8409         * tui/tui-winsource.h: Rename include guard.
8410         * tui/tui-wingeneral.h: Rename include guard.
8411         * tui/tui-windata.h: Rename include guard.
8412         * tui/tui-win.h: Rename include guard.
8413         * tui/tui-stack.h: Rename include guard.
8414         * tui/tui-source.h: Rename include guard.
8415         * tui/tui-regs.h: Rename include guard.
8416         * tui/tui-out.h: Rename include guard.
8417         * tui/tui-layout.h: Rename include guard.
8418         * tui/tui-io.h: Rename include guard.
8419         * tui/tui-hooks.h: Rename include guard.
8420         * tui/tui-file.h: Rename include guard.
8421         * tui/tui-disasm.h: Rename include guard.
8422         * tui/tui-data.h: Rename include guard.
8423         * tui/tui-command.h: Rename include guard.
8424         * tic6x-tdep.h: Add include guard.
8425         * target/waitstatus.h: Rename include guard.
8426         * target/wait.h: Rename include guard.
8427         * target/target.h: Rename include guard.
8428         * target/resume.h: Rename include guard.
8429         * target-float.h: Rename include guard.
8430         * stabsread.h: Add include guard.
8431         * rs6000-tdep.h: Add include guard.
8432         * riscv-fbsd-tdep.h: Add include guard.
8433         * regformats/regdef.h: Rename include guard.
8434         * record.h: Rename include guard.
8435         * python/python.h: Rename include guard.
8436         * python/python-internal.h: Rename include guard.
8437         * python/py-stopevent.h: Rename include guard.
8438         * python/py-ref.h: Rename include guard.
8439         * python/py-record.h: Rename include guard.
8440         * python/py-record-full.h: Rename include guard.
8441         * python/py-record-btrace.h: Rename include guard.
8442         * python/py-instruction.h: Rename include guard.
8443         * python/py-events.h: Rename include guard.
8444         * python/py-event.h: Rename include guard.
8445         * procfs.h: Add include guard.
8446         * proc-utils.h: Add include guard.
8447         * p-lang.h: Add include guard.
8448         * or1k-tdep.h: Rename include guard.
8449         * observable.h: Rename include guard.
8450         * nto-tdep.h: Rename include guard.
8451         * nat/x86-linux.h: Rename include guard.
8452         * nat/x86-linux-dregs.h: Rename include guard.
8453         * nat/x86-gcc-cpuid.h: Add include guard.
8454         * nat/x86-dregs.h: Rename include guard.
8455         * nat/x86-cpuid.h: Rename include guard.
8456         * nat/ppc-linux.h: Rename include guard.
8457         * nat/mips-linux-watch.h: Rename include guard.
8458         * nat/linux-waitpid.h: Rename include guard.
8459         * nat/linux-ptrace.h: Rename include guard.
8460         * nat/linux-procfs.h: Rename include guard.
8461         * nat/linux-osdata.h: Rename include guard.
8462         * nat/linux-nat.h: Rename include guard.
8463         * nat/linux-namespaces.h: Rename include guard.
8464         * nat/linux-btrace.h: Rename include guard.
8465         * nat/glibc_thread_db.h: Rename include guard.
8466         * nat/gdb_thread_db.h: Rename include guard.
8467         * nat/gdb_ptrace.h: Rename include guard.
8468         * nat/fork-inferior.h: Rename include guard.
8469         * nat/amd64-linux-siginfo.h: Rename include guard.
8470         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8471         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8472         * nat/aarch64-linux.h: Rename include guard.
8473         * nat/aarch64-linux-hw-point.h: Rename include guard.
8474         * mn10300-tdep.h: Add include guard.
8475         * mips-linux-tdep.h: Add include guard.
8476         * mi/mi-parse.h: Rename include guard.
8477         * mi/mi-out.h: Rename include guard.
8478         * mi/mi-main.h: Rename include guard.
8479         * mi/mi-interp.h: Rename include guard.
8480         * mi/mi-getopt.h: Rename include guard.
8481         * mi/mi-console.h: Rename include guard.
8482         * mi/mi-common.h: Rename include guard.
8483         * mi/mi-cmds.h: Rename include guard.
8484         * mi/mi-cmd-break.h: Rename include guard.
8485         * m2-lang.h: Add include guard.
8486         * location.h: Rename include guard.
8487         * linux-record.h: Rename include guard.
8488         * linux-nat.h: Add include guard.
8489         * linux-fork.h: Add include guard.
8490         * i386-darwin-tdep.h: Rename include guard.
8491         * hppa-linux-offsets.h: Add include guard.
8492         * guile/guile.h: Rename include guard.
8493         * guile/guile-internal.h: Rename include guard.
8494         * gnu-nat.h: Rename include guard.
8495         * gdb-stabs.h: Rename include guard.
8496         * frv-tdep.h: Add include guard.
8497         * f-lang.h: Add include guard.
8498         * event-loop.h: Add include guard.
8499         * darwin-nat.h: Rename include guard.
8500         * cp-abi.h: Rename include guard.
8501         * config/sparc/nm-sol2.h: Rename include guard.
8502         * config/nm-nto.h: Rename include guard.
8503         * config/nm-linux.h: Add include guard.
8504         * config/i386/nm-i386gnu.h: Rename include guard.
8505         * config/djgpp/nl_types.h: Rename include guard.
8506         * config/djgpp/langinfo.h: Rename include guard.
8507         * compile/gcc-cp-plugin.h: Add include guard.
8508         * compile/gcc-c-plugin.h: Add include guard.
8509         * compile/compile.h: Rename include guard.
8510         * compile/compile-object-run.h: Rename include guard.
8511         * compile/compile-object-load.h: Rename include guard.
8512         * compile/compile-internal.h: Rename include guard.
8513         * compile/compile-cplus.h: Rename include guard.
8514         * compile/compile-c.h: Rename include guard.
8515         * common/xml-utils.h: Rename include guard.
8516         * common/x86-xstate.h: Rename include guard.
8517         * common/version.h: Rename include guard.
8518         * common/vec.h: Rename include guard.
8519         * common/tdesc.h: Rename include guard.
8520         * common/selftest.h: Rename include guard.
8521         * common/scoped_restore.h: Rename include guard.
8522         * common/scoped_mmap.h: Rename include guard.
8523         * common/scoped_fd.h: Rename include guard.
8524         * common/safe-iterator.h: Rename include guard.
8525         * common/run-time-clock.h: Rename include guard.
8526         * common/refcounted-object.h: Rename include guard.
8527         * common/queue.h: Rename include guard.
8528         * common/ptid.h: Rename include guard.
8529         * common/print-utils.h: Rename include guard.
8530         * common/preprocessor.h: Rename include guard.
8531         * common/pathstuff.h: Rename include guard.
8532         * common/observable.h: Rename include guard.
8533         * common/netstuff.h: Rename include guard.
8534         * common/job-control.h: Rename include guard.
8535         * common/host-defs.h: Rename include guard.
8536         * common/gdb_wait.h: Rename include guard.
8537         * common/gdb_vecs.h: Rename include guard.
8538         * common/gdb_unlinker.h: Rename include guard.
8539         * common/gdb_unique_ptr.h: Rename include guard.
8540         * common/gdb_tilde_expand.h: Rename include guard.
8541         * common/gdb_sys_time.h: Rename include guard.
8542         * common/gdb_string_view.h: Rename include guard.
8543         * common/gdb_splay_tree.h: Rename include guard.
8544         * common/gdb_setjmp.h: Rename include guard.
8545         * common/gdb_ref_ptr.h: Rename include guard.
8546         * common/gdb_optional.h: Rename include guard.
8547         * common/gdb_locale.h: Rename include guard.
8548         * common/gdb_assert.h: Rename include guard.
8549         * common/filtered-iterator.h: Rename include guard.
8550         * common/filestuff.h: Rename include guard.
8551         * common/fileio.h: Rename include guard.
8552         * common/environ.h: Rename include guard.
8553         * common/common-utils.h: Rename include guard.
8554         * common/common-types.h: Rename include guard.
8555         * common/common-regcache.h: Rename include guard.
8556         * common/common-inferior.h: Rename include guard.
8557         * common/common-gdbthread.h: Rename include guard.
8558         * common/common-exceptions.h: Rename include guard.
8559         * common/common-defs.h: Rename include guard.
8560         * common/common-debug.h: Rename include guard.
8561         * common/cleanups.h: Rename include guard.
8562         * common/buffer.h: Rename include guard.
8563         * common/btrace-common.h: Rename include guard.
8564         * common/break-common.h: Rename include guard.
8565         * cli/cli-utils.h: Rename include guard.
8566         * cli/cli-style.h: Rename include guard.
8567         * cli/cli-setshow.h: Rename include guard.
8568         * cli/cli-script.h: Rename include guard.
8569         * cli/cli-interp.h: Rename include guard.
8570         * cli/cli-decode.h: Rename include guard.
8571         * cli/cli-cmds.h: Rename include guard.
8572         * charset-list.h: Add include guard.
8573         * buildsym-legacy.h: Rename include guard.
8574         * bfin-tdep.h: Add include guard.
8575         * ax.h: Rename include guard.
8576         * arm-linux-tdep.h: Add include guard.
8577         * arm-fbsd-tdep.h: Add include guard.
8578         * arch/xtensa.h: Rename include guard.
8579         * arch/tic6x.h: Add include guard.
8580         * arch/i386.h: Add include guard.
8581         * arch/arm.h: Rename include guard.
8582         * arch/arm-linux.h: Rename include guard.
8583         * arch/arm-get-next-pcs.h: Rename include guard.
8584         * arch/amd64.h: Add include guard.
8585         * arch/aarch64-insn.h: Rename include guard.
8586         * arch-utils.h: Rename include guard.
8587         * annotate.h: Add include guard.
8588         * amd64-darwin-tdep.h: Rename include guard.
8589         * aarch64-linux-tdep.h: Add include guard.
8590         * aarch64-fbsd-tdep.h: Add include guard.
8591         * aarch32-linux-nat.h: Add include guard.
8592
8593 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8594
8595         * macrotab.c (macro_define_internal): New function that
8596         factorizes macro_define_object_internal and macro_define_function
8597         code.
8598         (macro_define_object_internal): Use macro_define_internal.
8599         (macro_define_function): Likewise.
8600
8601 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8602
8603         * macrocmd.c (extract_identifier): Return
8604         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8605         callers.
8606
8607 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8608
8609         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8610
8611 2019-02-05  Tom Tromey  <tom@tromey.com>
8612
8613         * target.c (target_stack::unpush): Move assertion earlier.
8614
8615 2019-01-30  Tom Tromey  <tom@tromey.com>
8616
8617         PR python/23615:
8618         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8619         (gdbpy_parse_and_eval): Likewise.
8620         * python/python-internal.h (gdbpy_allow_threads): New class.
8621
8622 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8623
8624         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8625         (aarch64_fbsd_fpregmap): Move earlier.
8626         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8627         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8628         instead of individual calls to trad_frame_set_reg_addr.
8629         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8630         earlier.
8631         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8632         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8633         instead of individual calls to trad_frame_set_reg_addr.
8634
8635 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8636
8637         * CONTRIBUTE: Replace contribution list with wiki link.
8638
8639 2019-01-25  Tom Tromey  <tom@tromey.com>
8640
8641         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8642
8643 2019-01-25  Tom Tromey  <tom@tromey.com>
8644
8645         * xtensa-linux-nat.c: Fix common/ includes.
8646         * xml-support.h: Fix common/ includes.
8647         * xml-support.c: Fix common/ includes.
8648         * x86-linux-nat.c: Fix common/ includes.
8649         * windows-nat.c: Fix common/ includes.
8650         * varobj.h: Fix common/ includes.
8651         * varobj.c: Fix common/ includes.
8652         * value.c: Fix common/ includes.
8653         * valops.c: Fix common/ includes.
8654         * utils.c: Fix common/ includes.
8655         * unittests/xml-utils-selftests.c: Fix common/ includes.
8656         * unittests/utils-selftests.c: Fix common/ includes.
8657         * unittests/unpack-selftests.c: Fix common/ includes.
8658         * unittests/tracepoint-selftests.c: Fix common/ includes.
8659         * unittests/style-selftests.c: Fix common/ includes.
8660         * unittests/string_view-selftests.c: Fix common/ includes.
8661         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8662         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8663         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8664         * unittests/rsp-low-selftests.c: Fix common/ includes.
8665         * unittests/parse-connection-spec-selftests.c: Fix common/
8666         includes.
8667         * unittests/optional-selftests.c: Fix common/ includes.
8668         * unittests/offset-type-selftests.c: Fix common/ includes.
8669         * unittests/observable-selftests.c: Fix common/ includes.
8670         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8671         * unittests/memrange-selftests.c: Fix common/ includes.
8672         * unittests/memory-map-selftests.c: Fix common/ includes.
8673         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8674         * unittests/function-view-selftests.c: Fix common/ includes.
8675         * unittests/environ-selftests.c: Fix common/ includes.
8676         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8677         * unittests/common-utils-selftests.c: Fix common/ includes.
8678         * unittests/cli-utils-selftests.c: Fix common/ includes.
8679         * unittests/array-view-selftests.c: Fix common/ includes.
8680         * ui-file.c: Fix common/ includes.
8681         * tui/tui-io.c: Fix common/ includes.
8682         * tracepoint.h: Fix common/ includes.
8683         * tracepoint.c: Fix common/ includes.
8684         * tracefile-tfile.c: Fix common/ includes.
8685         * top.h: Fix common/ includes.
8686         * top.c: Fix common/ includes.
8687         * thread.c: Fix common/ includes.
8688         * target/waitstatus.h: Fix common/ includes.
8689         * target/waitstatus.c: Fix common/ includes.
8690         * target.h: Fix common/ includes.
8691         * target.c: Fix common/ includes.
8692         * target-memory.c: Fix common/ includes.
8693         * target-descriptions.c: Fix common/ includes.
8694         * symtab.h: Fix common/ includes.
8695         * symfile.c: Fix common/ includes.
8696         * stap-probe.c: Fix common/ includes.
8697         * spu-linux-nat.c: Fix common/ includes.
8698         * sparc-nat.c: Fix common/ includes.
8699         * source.c: Fix common/ includes.
8700         * solib.c: Fix common/ includes.
8701         * solib-target.c: Fix common/ includes.
8702         * ser-unix.c: Fix common/ includes.
8703         * ser-tcp.c: Fix common/ includes.
8704         * ser-pipe.c: Fix common/ includes.
8705         * ser-base.c: Fix common/ includes.
8706         * selftest-arch.c: Fix common/ includes.
8707         * s12z-tdep.c: Fix common/ includes.
8708         * rust-exp.y: Fix common/ includes.
8709         * rs6000-aix-tdep.c: Fix common/ includes.
8710         * riscv-tdep.c: Fix common/ includes.
8711         * remote.c: Fix common/ includes.
8712         * remote-notif.h: Fix common/ includes.
8713         * remote-fileio.h: Fix common/ includes.
8714         * remote-fileio.c: Fix common/ includes.
8715         * regcache.h: Fix common/ includes.
8716         * regcache.c: Fix common/ includes.
8717         * record-btrace.c: Fix common/ includes.
8718         * python/python.c: Fix common/ includes.
8719         * python/py-type.c: Fix common/ includes.
8720         * python/py-inferior.c: Fix common/ includes.
8721         * progspace.h: Fix common/ includes.
8722         * producer.c: Fix common/ includes.
8723         * procfs.c: Fix common/ includes.
8724         * proc-api.c: Fix common/ includes.
8725         * printcmd.c: Fix common/ includes.
8726         * ppc-linux-nat.c: Fix common/ includes.
8727         * parser-defs.h: Fix common/ includes.
8728         * osdata.c: Fix common/ includes.
8729         * obsd-nat.c: Fix common/ includes.
8730         * nat/x86-linux.c: Fix common/ includes.
8731         * nat/x86-linux-dregs.c: Fix common/ includes.
8732         * nat/x86-dregs.h: Fix common/ includes.
8733         * nat/x86-dregs.c: Fix common/ includes.
8734         * nat/ppc-linux.c: Fix common/ includes.
8735         * nat/mips-linux-watch.h: Fix common/ includes.
8736         * nat/mips-linux-watch.c: Fix common/ includes.
8737         * nat/linux-waitpid.c: Fix common/ includes.
8738         * nat/linux-ptrace.h: Fix common/ includes.
8739         * nat/linux-ptrace.c: Fix common/ includes.
8740         * nat/linux-procfs.c: Fix common/ includes.
8741         * nat/linux-personality.c: Fix common/ includes.
8742         * nat/linux-osdata.c: Fix common/ includes.
8743         * nat/linux-namespaces.c: Fix common/ includes.
8744         * nat/linux-btrace.h: Fix common/ includes.
8745         * nat/linux-btrace.c: Fix common/ includes.
8746         * nat/fork-inferior.c: Fix common/ includes.
8747         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8748         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8749         * nat/aarch64-linux.c: Fix common/ includes.
8750         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8751         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8752         * namespace.h: Fix common/ includes.
8753         * mips-linux-tdep.c: Fix common/ includes.
8754         * minsyms.c: Fix common/ includes.
8755         * mi/mi-parse.h: Fix common/ includes.
8756         * mi/mi-main.c: Fix common/ includes.
8757         * mi/mi-cmd-env.c: Fix common/ includes.
8758         * memrange.h: Fix common/ includes.
8759         * memattr.c: Fix common/ includes.
8760         * maint.h: Fix common/ includes.
8761         * maint.c: Fix common/ includes.
8762         * main.c: Fix common/ includes.
8763         * machoread.c: Fix common/ includes.
8764         * location.c: Fix common/ includes.
8765         * linux-thread-db.c: Fix common/ includes.
8766         * linux-nat.c: Fix common/ includes.
8767         * linux-fork.c: Fix common/ includes.
8768         * inline-frame.c: Fix common/ includes.
8769         * infrun.c: Fix common/ includes.
8770         * inflow.c: Fix common/ includes.
8771         * inferior.h: Fix common/ includes.
8772         * inferior.c: Fix common/ includes.
8773         * infcmd.c: Fix common/ includes.
8774         * inf-ptrace.c: Fix common/ includes.
8775         * inf-child.c: Fix common/ includes.
8776         * ia64-linux-nat.c: Fix common/ includes.
8777         * i387-tdep.c: Fix common/ includes.
8778         * i386-tdep.c: Fix common/ includes.
8779         * i386-linux-tdep.c: Fix common/ includes.
8780         * i386-linux-nat.c: Fix common/ includes.
8781         * i386-go32-tdep.c: Fix common/ includes.
8782         * i386-fbsd-tdep.c: Fix common/ includes.
8783         * i386-fbsd-nat.c: Fix common/ includes.
8784         * guile/scm-type.c: Fix common/ includes.
8785         * guile/guile.c: Fix common/ includes.
8786         * go32-nat.c: Fix common/ includes.
8787         * gnu-nat.c: Fix common/ includes.
8788         * gdbthread.h: Fix common/ includes.
8789         * gdbarch-selftests.c: Fix common/ includes.
8790         * gdb_usleep.c: Fix common/ includes.
8791         * gdb_select.h: Fix common/ includes.
8792         * gdb_bfd.c: Fix common/ includes.
8793         * gcore.c: Fix common/ includes.
8794         * fork-child.c: Fix common/ includes.
8795         * findvar.c: Fix common/ includes.
8796         * fbsd-nat.c: Fix common/ includes.
8797         * event-top.c: Fix common/ includes.
8798         * event-loop.c: Fix common/ includes.
8799         * dwarf2read.c: Fix common/ includes.
8800         * dwarf2loc.c: Fix common/ includes.
8801         * dwarf2-frame.c: Fix common/ includes.
8802         * dwarf-index-cache.c: Fix common/ includes.
8803         * dtrace-probe.c: Fix common/ includes.
8804         * disasm-selftests.c: Fix common/ includes.
8805         * defs.h: Fix common/ includes.
8806         * csky-tdep.c: Fix common/ includes.
8807         * cp-valprint.c: Fix common/ includes.
8808         * cp-support.h: Fix common/ includes.
8809         * cp-support.c: Fix common/ includes.
8810         * corelow.c: Fix common/ includes.
8811         * completer.h: Fix common/ includes.
8812         * completer.c: Fix common/ includes.
8813         * compile/compile.c: Fix common/ includes.
8814         * compile/compile-loc2c.c: Fix common/ includes.
8815         * compile/compile-cplus-types.c: Fix common/ includes.
8816         * compile/compile-cplus-symbols.c: Fix common/ includes.
8817         * command.h: Fix common/ includes.
8818         * cli/cli-dump.c: Fix common/ includes.
8819         * cli/cli-cmds.c: Fix common/ includes.
8820         * charset.c: Fix common/ includes.
8821         * build-id.c: Fix common/ includes.
8822         * btrace.h: Fix common/ includes.
8823         * btrace.c: Fix common/ includes.
8824         * breakpoint.h: Fix common/ includes.
8825         * breakpoint.c: Fix common/ includes.
8826         * ax.h:
8827         (enum agent_op): Fix common/ includes.
8828         * ax-general.c (struct aop_map): Fix common/ includes.
8829         * ax-gdb.c: Fix common/ includes.
8830         * auxv.c: Fix common/ includes.
8831         * auto-load.c: Fix common/ includes.
8832         * arm-tdep.c: Fix common/ includes.
8833         * arch/riscv.c: Fix common/ includes.
8834         * arch/ppc-linux-common.c: Fix common/ includes.
8835         * arch/i386.c: Fix common/ includes.
8836         * arch/arm.c: Fix common/ includes.
8837         * arch/arm-linux.c: Fix common/ includes.
8838         * arch/arm-get-next-pcs.c: Fix common/ includes.
8839         * arch/amd64.c: Fix common/ includes.
8840         * arch/aarch64.c: Fix common/ includes.
8841         * arch/aarch64-insn.c: Fix common/ includes.
8842         * arch-utils.c: Fix common/ includes.
8843         * amd64-windows-tdep.c: Fix common/ includes.
8844         * amd64-tdep.c: Fix common/ includes.
8845         * amd64-sol2-tdep.c: Fix common/ includes.
8846         * amd64-obsd-tdep.c: Fix common/ includes.
8847         * amd64-nbsd-tdep.c: Fix common/ includes.
8848         * amd64-linux-tdep.c: Fix common/ includes.
8849         * amd64-linux-nat.c: Fix common/ includes.
8850         * amd64-fbsd-tdep.c: Fix common/ includes.
8851         * amd64-fbsd-nat.c: Fix common/ includes.
8852         * amd64-dicos-tdep.c: Fix common/ includes.
8853         * amd64-darwin-tdep.c: Fix common/ includes.
8854         * agent.c: Fix common/ includes.
8855         * ada-lang.h: Fix common/ includes.
8856         * ada-lang.c: Fix common/ includes.
8857         * aarch64-tdep.c: Fix common/ includes.
8858
8859 2019-01-25  Tom Tromey  <tom@tromey.com>
8860
8861         * common/create-version.sh: Use common/version.h.
8862
8863 2019-01-24  Pedro Alves  <palves@redhat.com>
8864
8865         * infrun.c (signal_stop, signal_print, signal_program)
8866         (signal_catch, signal_pass): Now arrays instead of pointers.
8867         (update_signals_program_target, do_target_resume)
8868         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8869         * linux-nat.c (linux_nat_target::pass_signals)
8870         (linux_nat_target::create_inferior, linux_nat_target::attach):
8871         Adjust.
8872         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8873         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8874         * procfs.c (procfs_target::pass_signals): Adjust.
8875         * record-full.c (record_full_target::resume): Adjust.
8876         * remote.c (remote_target::pass_signals)
8877         (remote_target::program_signals): Adjust.
8878         * target-debug.h (target_debug_print_signals): Now takes a
8879         gdb::array_view as parameter.  Adjust.
8880         * target.h (target_ops) <pass_signals, program_signals>: Replace
8881         pointer and length parameters with gdb::array_view.
8882         (target_pass_signals, target_program_signals): Likewise.
8883         * target-delegates.c: Regenerate.
8884
8885 2019-01-24  Pedro Alves  <palves@redhat.com>
8886
8887         * common/forward-scope-exit.h
8888         (forward_scope_exit::forward_scope_exit): Pass arguments to
8889         m_bind_function directly, instead of creating a std::bind and
8890         copying that.
8891
8892 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8893
8894         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8895         for static members.
8896         (pass_in_v_vfp_candidate): Likewise.
8897
8898 2019-01-23  Tom Tromey  <tom@tromey.com>
8899             Pedro Alves  <palves@redhat.com>
8900
8901         * regcache.c (class regcache_invalidator): Remove.
8902         (regcache::raw_write): Use make_scope_exit.
8903
8904 2019-01-23  Tom Tromey  <tom@tromey.com>
8905
8906         * ui-out.h (class ui_out_emit_type): Update comment.
8907
8908 2019-01-23  Tom Tromey  <tom@tromey.com>
8909
8910         * infrun.c (fetch_inferior_event): Update comment.
8911
8912 2019-01-23  Tom Tromey  <tom@tromey.com>
8913             Pedro Alves  <palves@redhat.com>
8914
8915         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8916         parameter.
8917         (fetch_inferior_event): Use SCOPE_EXIT.
8918
8919
8920 2019-01-23  Tom Tromey  <tom@tromey.com>
8921             Pedro Alves  <palves@redhat.com>
8922
8923         * infrun.c (disable_thread_events): Delete.
8924         (stop_all_threads): Use SCOPE_EXIT.
8925
8926 2019-01-23  Tom Tromey  <tom@tromey.com>
8927             Pedro Alves  <palves@redhat.com>
8928
8929         * symfile.c: Include forward-scope-exit.h.
8930         (clear_symtab_users_cleanup): Replace forward declaration with
8931         a FORWARD_SCOPE_EXIT.
8932         (syms_from_objfile_1): Use the forward_scope_exit and
8933         gdb::optional instead of cleanup_function.
8934         (reread_symbols): Use the forward_scope_exit instead of
8935         cleanup_function.
8936         (clear_symtab_users_cleanup): Remove function.
8937
8938 2019-01-23  Tom Tromey  <tom@tromey.com>
8939             Pedro Alves  <palves@redhat.com>
8940
8941         * linux-nat.c: Include scope-exit.h.
8942         (cleanup_target_stop): Remove.
8943         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8944         SCOPE_EXIT.
8945
8946 2019-01-23  Tom Tromey  <tom@tromey.com>
8947             Pedro Alves  <palves@redhat.com>
8948
8949         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8950         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8951
8952 2019-01-23  Tom Tromey  <tom@tromey.com>
8953             Andrew Burgess  <andrew.burgess@embecosm.com>
8954             Pedro Alves  <palves@redhat.com>
8955
8956         * infrun.c (fetch_inferior_event): Use scope_exit.
8957         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8958         * top.c (execute_command): Use scope_exit.
8959         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8960         * utils.c (do_bpstat_clear_actions_cleanup)
8961         (make_bpstat_clear_actions_cleanup): Remove.
8962
8963 2019-01-23  Tom Tromey  <tom@tromey.com>
8964             Pedro Alves  <palves@redhat.com>
8965
8966         * infrun.c: Include "common/scope-exit.h"
8967         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8968         (wait_for_inferior): Use SCOPE_EXIT.
8969         (fetch_inferior_event): Use scope_exit.
8970
8971 2019-01-23  Tom Tromey  <tom@tromey.com>
8972             Pedro Alves  <palves@redhat.com>
8973
8974         * breakpoint.c (create_breakpoint): Remove cleanup.
8975
8976 2019-01-23  Tom Tromey  <tom@tromey.com>
8977             Andrew Burgess  <andrew.burgess@embecosm.com>
8978             Pedro Alves  <palves@redhat.com>
8979
8980 2019-01-23  Pedro Alves  <palves@redhat.com>
8981
8982         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8983
8984 2019-01-23  Pedro Alves  <palves@redhat.com>
8985             Andrew Burgess  <andrew.burgess@embecosm.com>
8986
8987         * gdbthread.h: Include "common/forward-scope-exit.h".
8988         (scoped_finish_thread_state): Redefine custom class in terms of
8989         forward_scope_exit.
8990
8991 2019-01-23  Pedro Alves  <palves@redhat.com>
8992             Andrew Burgess  <andrew.burgess@embecosm.com>
8993
8994         * common/forward-scope-exit.h: New file.
8995
8996 2019-01-23  Pedro Alves  <palves@redhat.com>
8997             Andrew Burgess  <andrew.burgess@embecosm.com>
8998             Tom Tromey  <tom@tromey.com>
8999
9000         * common/scope-exit.h: New file.
9001
9002 2019-01-23  Pedro Alves  <palves@redhat.com>
9003
9004         * common/preprocessor.h (ESC): Rename to ...
9005         (ESC_PARENS): ... this.
9006         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9007         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9008
9009 2019-01-23  Tom Tromey  <tom@tromey.com>
9010
9011         * language.h (class scoped_switch_to_sym_language_if_auto):
9012         Initialize m_lang in both cases.
9013
9014 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9015
9016         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9017         with XCNEW.
9018
9019 2019-01-22  Tom Tromey  <tom@tromey.com>
9020
9021         * corelow.c: Do not include sys/file.h.
9022
9023 2019-01-22  Tom Tromey  <tom@tromey.com>
9024
9025         * tui/tui-wingeneral.h: Include gdb_curses.h.
9026
9027 2019-01-22  Tom Tromey  <tom@tromey.com>
9028
9029         * source-cache.h (class source_cache) <get_source_lines,
9030         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9031
9032 2019-01-22  Tom Tromey  <tom@tromey.com>
9033
9034         * remote-fileio.h (struct remote_target): Declare.
9035
9036 2019-01-22  Tom Tromey  <tom@tromey.com>
9037
9038         * python/py-arch.c: Do not include py-ref.h.
9039         * python/py-bpevent.c: Do not include py-ref.h.
9040         * python/py-cmd.c: Do not include py-ref.h.
9041         * python/py-continueevent.c: Do not include py-ref.h.
9042         * python/py-event.h: Do not include py-ref.h.
9043         * python/py-evtregistry.c: Do not include py-ref.h.
9044         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9045         * python/py-frame.c: Do not include py-ref.h.
9046         * python/py-framefilter.c: Do not include py-ref.h.
9047         * python/py-function.c: Do not include py-ref.h.
9048         * python/py-infevents.c: Do not include py-ref.h.
9049         * python/py-linetable.c: Do not include py-ref.h.
9050         * python/py-objfile.c: Do not include py-ref.h.
9051         * python/py-param.c: Do not include py-ref.h.
9052         * python/py-prettyprint.c: Do not include py-ref.h.
9053         * python/py-progspace.c: Do not include py-ref.h.
9054         * python/py-symbol.c: Do not include py-ref.h.
9055         * python/py-symtab.c: Do not include py-ref.h.
9056         * python/py-type.c: Do not include py-ref.h.
9057         * python/py-unwind.c: Do not include py-ref.h.
9058         * python/py-utils.c: Do not include py-ref.h.
9059         * python/py-value.c: Do not include py-ref.h.
9060         * python/py-varobj.c: Do not include py-ref.h.
9061         * python/py-xmethods.c: Do not include py-ref.h.
9062         * python/python.c: Do not include py-ref.h.
9063         * varobj.c: Do not include py-ref.h.
9064
9065 2019-01-22  Tom Tromey  <tom@tromey.com>
9066
9067         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9068         keyword for bcache.
9069
9070 2019-01-22  Tom Tromey  <tom@tromey.com>
9071
9072         * compile/compile-cplus-types.c: Remove a comment by #include.
9073
9074 2019-01-22  Tom Tromey  <tom@tromey.com>
9075
9076         * compile/gcc-c-plugin.h: Include compile-internal.h.
9077
9078 2019-01-22  Tom Tromey  <tom@tromey.com>
9079
9080         * stabsread.c (EXTERN): Do not define.
9081         (symnum, next_symbol_text_func, processing_gcc_compilation)
9082         (within_function, global_sym_chain, global_stabs)
9083         (previous_stab_code, this_object_header_files)
9084         (n_this_object_header_files)
9085         (n_allocated_this_object_header_files): Define.
9086         * stabsread.h (EXTERN): Never define.  Use "extern".
9087
9088 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9089
9090         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9091         history_value.
9092
9093 2019-01-21  Tom Tromey  <tom@tromey.com>
9094
9095         * ui-out.c: Fix includes.
9096         * tui/tui-source.c: Fix includes.
9097         * target.c: Fix includes.
9098         * remote.c: Fix includes.
9099         * regcache.c: Fix includes.
9100         * python/py-block.c: Fix includes.
9101         * printcmd.c: Fix includes.
9102         * or1k-tdep.c: Fix includes.
9103         * mi/mi-main.c: Fix includes.
9104         * m32r-tdep.c: Fix includes.
9105         * csky-tdep.c: Fix includes.
9106         * compile/compile-cplus-types.c: Fix includes.
9107         * cli/cli-interp.c: Fix includes.
9108
9109 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9110
9111         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9112         for padding.
9113
9114 2019-01-16  Tom Tromey  <tom@tromey.com>
9115
9116         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9117         earlier.
9118         (struct objfile) <msymbols_range>: Move from top level.
9119         <msymbols>: New method.
9120         (class objfile_msymbols): Remove.
9121         * symtab.c (default_collect_symbol_completion_matches_break_on):
9122         Update.
9123         * symmisc.c (dump_msymbols): Update.
9124         * stabsread.c (scan_file_globals): Update.
9125         * objc-lang.c (info_selectors_command, info_classes_command)
9126         (find_methods): Update.
9127         * minsyms.c (find_solib_trampoline_target): Update.
9128         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9129         * coffread.c (coff_symfile_read): Update.
9130         * ada-lang.c (ada_lookup_simple_minsym)
9131         (ada_collect_symbol_completion_matches): Update.
9132
9133 2019-01-16  Tom Tromey  <tom@tromey.com>
9134
9135         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9136         type.  Remove no-argument constructor.
9137         <iterator::operator++>: Simplify.
9138         <begin>: Update.
9139         <end>: Use minimal_symbol_count.
9140
9141 2019-01-16  Tom Tromey  <tom@tromey.com>
9142
9143         * objfiles.h (struct objfile) <psymtabs>: New method.
9144         (class objfile_psymtabs): Remove.
9145         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9146         typedef.
9147         <range>: New method.
9148         (require_partial_symbols): Change return type.
9149         * psymtab.c (require_partial_symbols)
9150         (psym_expand_symtabs_matching): Update.
9151         * mdebugread.c (parse_partial_symbols): Update.
9152         * dbxread.c (dbx_end_psymtab): Update.
9153
9154 2019-01-15  Tom Tromey  <tom@tromey.com>
9155
9156         * symtab.c (lookup_objfile_from_block)
9157         (lookup_symbol_in_objfile_symtabs)
9158         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9159         (find_line_symtab, info_sources_command)
9160         (default_collect_symbol_completion_matches_break_on)
9161         (make_source_files_completion_list): Update.
9162         * symmisc.c (print_objfile_statistics, dump_objfile)
9163         (maintenance_print_symbols, maintenance_info_symtabs)
9164         (maintenance_check_symtabs, maintenance_info_line_tables):
9165         Update.
9166         * source.c (select_source_symtab)
9167         (forget_cached_source_info_for_objfile): Update.
9168         * objfiles.h (class objfile_compunits): Remove.
9169         (struct objfile) <compunits_range>: New typedef.
9170         (compunits): New method.
9171         * objfiles.c (objfile_relocate1): Update.
9172         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9173         * maint.c (count_symtabs_and_blocks): Update.
9174         * linespec.c (iterate_over_all_matching_symtabs): Update.
9175         * cp-support.c (add_symbol_overload_list_qualified): Update.
9176         * coffread.c (coff_symtab_read): Update.
9177         * ada-lang.c (add_nonlocal_symbols)
9178         (ada_collect_symbol_completion_matches)
9179         (ada_add_global_exceptions): Update.
9180
9181 2019-01-15  Tom Tromey  <tom@tromey.com>
9182
9183         * progspace.h (program_space) <objfiles_safe_range>: New
9184         typedef.
9185         <objfiles_safe>: New method.
9186         * objfiles.h (class all_objfiles_safe): Remove.
9187         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9188         * jit.c (jit_inferior_exit_hook): Update.
9189
9190 2019-01-17  Tom Tromey  <tom@tromey.com>
9191
9192         * progspace.h (program_space) <objfiles_range>: New typedef.
9193         <objfiles>: New method.
9194         <objfiles_head>: Rename from objfiles.
9195         (object_files): Update.
9196         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9197         * guile/scm-pretty-print.c
9198         (ppscm_find_pretty_printer_from_objfiles): Update.
9199         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9200         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9201         Update.
9202         * python/py-progspace.c (pspy_get_objfiles): Update.
9203         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9204         Update.
9205         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9206         (objfpy_lookup_objfile_by_build_id): Update.
9207         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9208         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9209         Update.
9210         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9211         (expand_symtab_containing_pc, lookup_objfile_from_block)
9212         (lookup_static_symbol, basic_lookup_transparent_type)
9213         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9214         (find_line_symtab, info_sources_command)
9215         (default_collect_symbol_completion_matches_break_on)
9216         (make_source_files_completion_list, find_main_name): Update.
9217         * symmisc.c (print_symbol_bcache_statistics)
9218         (print_objfile_statistics, maintenance_print_symbols)
9219         (maintenance_print_msymbols, maintenance_print_objfiles)
9220         (maintenance_info_symtabs, maintenance_check_symtabs)
9221         (maintenance_expand_symtabs, maintenance_info_line_tables):
9222         Update.
9223         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9224         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9225         (map_overlay_command, unmap_overlay_command)
9226         (simple_overlay_update, expand_symtabs_matching)
9227         (map_symbol_filenames): Update.
9228         * symfile-debug.c (set_debug_symfile): Update.
9229         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9230         Update.
9231         * source.c (select_source_symtab, forget_cached_source_info):
9232         Update.
9233         * solib.c (solib_read_symbols): Update.
9234         * solib-spu.c (append_ocl_sos): Update.
9235         * psymtab.c (maintenance_print_psymbols)
9236         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9237         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9238         * printcmd.c (info_symbol_command): Update.
9239         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9240         Update.
9241         * objfiles.h (class all_objfiles): Remove.
9242         * objfiles.c (have_partial_symbols, have_full_symbols)
9243         (have_minimal_symbols, qsort_cmp, update_section_map)
9244         (shared_objfile_contains_address_p)
9245         (default_iterate_over_objfiles_in_search_order): Update.
9246         * objc-lang.c (info_selectors_command, info_classes_command)
9247         (find_methods): Update.
9248         * minsyms.c (find_solib_trampoline_target): Update.
9249         * maint.c (maintenance_info_sections)
9250         (maintenance_translate_address, count_symtabs_and_blocks):
9251         Update.
9252         * main.c (captured_main_1): Update.
9253         * linux-thread-db.c (try_thread_db_load_from_pdir)
9254         (has_libpthread): Update.
9255         * linespec.c (iterate_over_all_matching_symtabs)
9256         (search_minsyms_for_name): Update.
9257         * jit.c (jit_find_objf_with_entry_addr): Update.
9258         * hppa-tdep.c (find_unwind_entry)
9259         (hppa_lookup_stub_minimal_symbol): Update.
9260         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9261         Update.
9262         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9263         (elf_gnu_ifunc_resolve_by_got): Update.
9264         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9265         * dwarf-index-write.c (save_gdb_index_command): Update.
9266         * cp-support.c (add_symbol_overload_list_qualified): Update.
9267         * breakpoint.c (create_overlay_event_breakpoint)
9268         (create_longjmp_master_breakpoint)
9269         (create_std_terminate_master_breakpoint)
9270         (create_exception_master_breakpoint): Update.
9271         * blockframe.c (find_pc_partial_function): Update.
9272         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9273         (ada_collect_symbol_completion_matches)
9274         (ada_add_global_exceptions): Update.
9275
9276 2019-01-17  Tom Tromey  <tom@tromey.com>
9277
9278         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9279         declare VEC.
9280         (solib_target_parse_libraries): Change return type.
9281         (library_list_start_segment, library_list_start_section)
9282         (library_list_end_library, library_list_start_library); Update.
9283         (solib_target_free_library_list): Remove.
9284         (solib_target_parse_libraries): Remove cleanup.  Change return
9285         type.
9286         (solib_target_current_sos): Update.
9287
9288 2019-01-17  Tom Tromey  <tromey@bapiya>
9289
9290         * valprint.c: Replace "the the" with "the".
9291         * symtab.c: Replace "the the" with "the".
9292         * solib.c: Replace "the the" with "the".
9293         * solib-dsbt.c: Replace "the the" with "the".
9294         * linespec.c: Replace "the the" with "the".
9295         * dwarf2loc.h: Replace "the the" with "the".
9296         * amd64-windows-tdep.c: Replace "the the" with "the".
9297         * aarch64-tdep.c: Replace "the the" with "the".
9298
9299 2019-01-16  Keith Seitz  <keiths@redhat.com>
9300
9301         PR gdb/23773
9302         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9303         <builder>: Rename to ..
9304         <m_builder>: ... this and make private.
9305         (dwarf2_cu::get_builder): New method.  Change all users of
9306         `builder' to use this method.
9307         (dwarf2_start_symtab): Move to ...
9308         (dwarf2_cu::start_symtab): ... here.  Update all callers
9309         (setup_type_unit_groups): Move to ...
9310         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9311         callers.
9312         (dwarf2_cu::reset_builder): New method.
9313         (process_full_compunit, process_full_type_unit): Use
9314         dwarf2_cu::reset_builder.
9315         (follow_die_offset): Record the ancestor CU if it is different
9316         from the followed DIE's CU.
9317         (follow_die_sig_1): Likewise.
9318
9319 2019-01-15  Tom Tromey  <tom@tromey.com>
9320
9321         * remote.c (class remote_state) <buf>: Now a char_vector.
9322         <buf_size>: Remove.
9323         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9324         parameter.
9325         (remote_target::getpkt_or_notif_sane_1)
9326         (remote_target::getpkt_sane)
9327         (remote_target::getpkt_or_notif_sane): Likewise.
9328         (class remote_target) <putpkt>: New overload.
9329         (remote_target::read_frame): Change type of "buf_p".  Remove
9330         sizeof_p parameter.
9331         (packet_ok): New overload.
9332         (packet_check_result): New overload.
9333         Update all uses.
9334
9335 2019-01-14  Tom Tromey  <tom@tromey.com>
9336
9337         * remote-notif.c (handle_notification, remote_notif_ack)
9338         (remote_notif_parse): Make "buf" const.
9339         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9340         const.
9341         (remote_notif_parse, remote_notif_ack, handle_notification):
9342         Likewise.
9343         * remote.c (remote_notif_stop_parse): Make "buf" const.
9344         (remote_target::remote_parse_stop_reply): Make "buf" const.
9345         (remote_notif_stop_ack): Make "buf" const.
9346
9347 2019-01-14  Tom Tromey  <tom@tromey.com>
9348
9349         * remote.c (remote_console_output): Make parameter const.
9350
9351 2019-01-14  Tom Tromey  <tom@tromey.com>
9352
9353         * target-debug.h (target_debug_print_signals): Constify.
9354         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9355         * procfs.c (procfs_target::pass_signals): Update.
9356         * linux-nat.c (linux_nat_target::pass_signals): Update.
9357         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9358         * target-delegates.c: Rebuild.
9359         * remote.c (remote_target::program_signals): Update.
9360         (remote_target::pass_signals): Update.
9361         * target.c (target_pass_signals): Constify argument.
9362         (target_program_signals): Likewise.
9363         * target.h (struct target_ops) <pass_signals, program_signals>:
9364         Constify argument.
9365         (target_pass_signals, target_program_signals): Constify argument.
9366
9367 2019-01-14  Tom Tromey  <tom@tromey.com>
9368
9369         PR tui/28819:
9370         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9371
9372 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9373
9374         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9375         field.
9376         * rs6000-tdep.c: Include reggroups.h.
9377         (IS_V_ALIAS_PSEUDOREG): Define.
9378         (rs6000_register_name): Return names for the "vX" aliases.
9379         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9380         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9381         aliases.  Call default_register_reggroup_p for all other
9382         pseudo-registers.
9383         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9384         New functions.
9385         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9386         Handle "vX" aliases.
9387         (v_alias_pseudo_register_collect): New function.
9388         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9389         (rs6000_gdbarch_init): Initialize "vX" aliases as
9390         pseudo-registers.  Restore registration of
9391         rs6000_pseudo_register_reggroup_p with
9392         set_tdesc_pseudo_register_reggroup_p.
9393
9394 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9395
9396         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9397         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9398         set_gdbarch_num_pseudo_regs.
9399
9400 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9401
9402         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9403         Remove arg prefixname, add do_set and do_show.
9404         Add member functions set_list and show_list.
9405         * cli/cli-style.c (class cli_style_option): Update accordingly.
9406         (style_set_list): Move to file scope.
9407         (style_show_list): Likewise.
9408         (set_style): Call help_list.
9409         (show_style): Call cmd_show_list.
9410         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9411         Update to use the new macro.
9412
9413 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9414
9415         * ada-lang.c (_initialize_ada_language): Expand the help text
9416         for the "catch exception" command.
9417
9418 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9419
9420         * symtab.c (matching_obj_sections): Initialize obj,
9421         declare it closer to its usage.
9422
9423 2019-01-10  Tom Tromey  <tom@tromey.com>
9424
9425         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9426         (basic_inf_threads_range): Remove.
9427         (inf_threads_range, inf_non_exited_threads_range)
9428         (safe_inf_threads_range): Use next_adapter.
9429
9430 2019-01-10  Keith Seitz  <keiths@redhat.com>
9431
9432         PR gdb/23712
9433         PR symtab/23010
9434         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9435         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9436
9437 2019-01-10  Keith Seitz  <keiths@redhat.com>
9438
9439         PR gdb/23712
9440         PR symtab/23010
9441         * dictionary.c (pending_to_vector): Remove.
9442         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9443         Remove _1 suffix, replacing functions of the same name.  Update
9444         all callers.
9445         (dict_create_hashed, dict_create_hashed_expandable)
9446         (dict_create_linear, dict_create_linear_expandable, dict_free)
9447         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9448         Make functions static.
9449
9450 2019-01-10  Keith Seitz  <keiths@redhat.com>
9451
9452         PR gdb/23712
9453         PR symtab/23010
9454         * dictionary.h (struct dictionary): Replace declaration with
9455         multidictionary.
9456         (dict_create_hashed, dict_create_hashed_expandable)
9457         (dict_create_linear, dict_create_linear_expandable)
9458         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9459         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9460         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9461         taking multidictionary argument.
9462         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9463         * block.h (struct block) <dict>: Change to multidictionary
9464         and rename `multidict'.
9465         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9466         symmisc.c: Update all dictionary references to multidictionary.
9467
9468 2019-01-10  Keith Seitz  <keiths@redhat.com>
9469
9470         PR gdb/23712
9471         PR symtab/23010
9472         * dictionary.c: Include unordered_map.
9473         (pending_to_vector): New function.
9474         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9475         Rewrite the non-"_1" functions to take vector instead
9476         of linked list.
9477         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9478         "new" _1 versions of the same name.
9479         (multidictionary): Define.
9480         (std::hash<enum language): New definition.
9481         (collate_pending_symbols_by_language, mdict_create_hashed)
9482         (mdict_create_hashed_expandable, mdict_create_linear)
9483         (mdict_create_linear_expandable, mdict_free)
9484         (find_language_dictionary, create_new_language_dictionary)
9485         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9486         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9487         (mdict_size, mdict_empty): New functions.
9488         * dictionary.h (mdict_iterator): Define.
9489
9490 2019-01-10  Pedro Alves  <palves@redhat.com>
9491
9492         * breakpoint.c (read_uploaded_action)
9493         (create_tracepoint_from_upload): Adjust to use
9494         gdb::unique_xmalloc_ptr.
9495         * ctf.c (ctf_write_uploaded_tp):
9496         (SET_ARRAY_FIELD): Use emplace_back.
9497         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9498         * tracefile-tfile.c (tfile_write_uploaded_tp):
9499         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9500         gdb::unique_xmalloc_ptr.
9501         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9502         at_string, cond_string, cmd_strings>: Replace char pointers
9503         with gdb::unique_xmalloc_ptr.
9504
9505 2019-01-10  Pedro Alves  <palves@redhat.com>
9506
9507         * solib-target.c (library_list_start_library): Don't xstrdup name.
9508
9509 2019-01-10  Pedro Alves  <palves@redhat.com>
9510
9511         * mdebugread.c (parse_partial_symbols): Use
9512         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9513
9514 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9515
9516         * linux-fork.c (scoped_switch_fork_info)
9517         <~scoped_switch_fork_info>: Fix incorrect variable name.
9518
9519 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9520
9521         * linux-fork.c (scoped_switch_fork_info)
9522         <scoped_switch_fork_info>: Make explicit.
9523         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9524
9525 2019-01-10  Tom Tromey  <tom@tromey.com>
9526
9527         * objfiles.h (objfile::reset_psymtabs): Update.
9528         * objfiles.c (objfile::objfile): Update.
9529         * psymtab.h (psymtab_storage::obstack): Update.
9530         (psymtab_storage::m_obstack): Use gdb::optional.
9531         (class psymtab_storage): Update comment.  Remove objfile
9532         parameter.
9533         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9534
9535 2019-01-10  Tom Tromey  <tom@tromey.com>
9536
9537         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9538         <free_psymtabs>: Now private.
9539         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9540         (allocate_psymtab): Use new method.
9541
9542 2019-01-10  Tom Tromey  <tom@tromey.com>
9543
9544         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9545         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9546         * mdebugread.c (parse_partial_symbols): Use
9547         allocate_dependencies.
9548         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9549         allocate_dependencies.
9550         (process_psymtab_comp_unit_reader)
9551         (build_type_psymtab_dependencies): Likewise.
9552         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9553
9554 2019-01-10  Tom Tromey  <tom@tromey.com>
9555
9556         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9557         PSYMBOL_SET_LANGUAGE.
9558         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9559
9560 2019-01-10  Tom Tromey  <tom@tromey.com>
9561
9562         * psymtab.h (psymtab_storage::obstack): New method.
9563         <m_obstack>: Rename from obstack; now private.
9564         * psymtab.c (psymtab_storage): Update.
9565         * dwarf2read.c (create_addrmap_from_index)
9566         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9567         Update.
9568
9569 2019-01-10  Tom Tromey  <tom@tromey.com>
9570
9571         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9572         * objfiles.h (objfile::reset_psymtabs): New method.
9573
9574 2019-01-10  Tom Tromey  <tom@tromey.com>
9575
9576         * symmisc.c (print_symbol_bcache_statistics): Update.
9577         (print_objfile_statistics): Update.
9578         * symfile.c (reread_symbols): Update.
9579         * psymtab.h (class psymtab_storage): New.
9580         * psymtab.c (psymtab_storage): New constructor.
9581         (~psymtab_storage): New destructor.
9582         (require_partial_symbols): Update.
9583         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9584         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9585         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9586         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9587         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9588         (start_psymtab_common, end_psymtab_common)
9589         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9590         (allocate_psymtab): Update.
9591         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9592         Update.
9593         (dump_psymtab_addrmap, maintenance_print_psymbols)
9594         (maintenance_check_psymtabs): Update.
9595         (class objfile_psymtabs): Move to objfiles.h.
9596         * psympriv.h (discard_psymtab): Now inline.
9597         (psymtab_discarder::psymtab_discarder): Update.
9598         (psymtab_discarder::~psymtab_discarder): Update.
9599         (ALL_OBJFILE_PSYMTABS): Rewrite.
9600         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9601         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9602         Remove fields.
9603         <partial_symtabs>: New field.
9604         (class objfile_psymtabs): Move from psymtab.h.  Update.
9605         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9606         psymbol_cache.
9607         (objfile::~objfile): Don't destroy psymbol_cache.
9608         * mdebugread.c (parse_partial_symbols): Update.
9609         * dwarf2read.c (create_addrmap_from_index)
9610         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9611         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9612         (add_partial_subprogram, dwarf2_ranges_read): Update.
9613         * dwarf-index-write.c (write_address_map)
9614         (write_one_signatured_type, recursively_write_psymbols)
9615         (class debug_names, class debug_names, write_psymtabs_to_index):
9616         Update.
9617
9618 2019-01-10  Tom Tromey  <tom@tromey.com>
9619
9620         * symtab.h (SYMBOL_SET_NAMES): Update.
9621         (symbol_set_names): Update.
9622         (MSYMBOL_SET_NAMES): Update.
9623         * symtab.c (symbol_set_names): Change argument to be an
9624         objfile_per_bfd_storage.
9625         * psymtab.c (add_psymbol_to_bcache): Update.
9626         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9627
9628 2019-01-10  Tom Tromey  <tom@tromey.com>
9629
9630         * symtab.c (create_demangled_names_hash): Change argument to be an
9631         objfile_per_bfd_storage.
9632         (symbol_set_names): Update.
9633
9634 2019-01-10  Tom Tromey  <tom@tromey.com>
9635
9636         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9637         init_psymbol_list.
9638         * psymtab.c (init_psymbol_list): Do nothing if already called.
9639         * psympriv.h (init_psymbol_list): Add comment.
9640         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9641         init_psymbol_list.
9642         * dbxread.c (dbx_symfile_read): Unconditionally call
9643         init_psymbol_list.
9644
9645 2019-01-10  Tom Tromey  <tom@tromey.com>
9646
9647         * xcoffread.c (scan_xcoff_symtab): Update.
9648         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9649         "where".
9650         * mdebugread.c (parse_partial_symbols)
9651         (handle_psymbol_enumerators): Update.
9652         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9653         * dbxread.c (read_dbx_symtab): Update.
9654         * psympriv.h (psymbol_placement): New enum.
9655         (add_psymbol_to_list): Update.
9656
9657 2019-01-10  Tom Tromey  <tom@tromey.com>
9658
9659         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9660         static_psymbols parameters.
9661         (scan_xcoff_symtab): Update.
9662         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9663         static_psymbols parameters.
9664         * psympriv.h (start_psymtab_common): Update.
9665         * mdebugread.c (parse_partial_symbols): Update.
9666         * dwarf2read.c (create_partial_symtab): Update.
9667         * dbxread.c (read_dbx_symtab): Update.
9668         (start_psymtab): Remove global_psymbols and static_psymbols
9669         parameters.
9670
9671 2019-01-10  Tom Tromey  <tom@tromey.com>
9672
9673         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9674         * psymtab.c (allocate_psymtab): Add comment.
9675         * psympriv.h (allocate_psymtab): Add comment.
9676         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9677         initializations.
9678         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9679
9680 2019-01-10  Tom Tromey  <tom@tromey.com>
9681
9682         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9683         Don't declare.
9684         * mipsread.c: Include mdebugread.h.
9685         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9686         Declare.
9687         * elfread.c: Include mdebugread.h.
9688
9689 2019-01-09  Tom Tromey  <tom@tromey.com>
9690
9691         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9692         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9693         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9694         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9695         (psym_lookup_symbol, psym_find_last_source_symtab)
9696         (psym_forget_cached_source_info, psym_print_stats)
9697         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9698         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9699         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9700         (psym_find_compunit_symtab_by_address)
9701         (maintenance_print_psymbols, maintenance_info_psymtabs)
9702         (maintenance_check_psymtabs): Use ranged for.
9703         * psymtab.h (class objfile_psymtabs): New.
9704         (require_partial_symbols): Return objfile_psymtabs.
9705         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9706
9707 2019-01-09  Tom Tromey  <tom@tromey.com>
9708
9709         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9710         (find_pc_mapped_section, list_overlays_command)
9711         (map_overlay_command, unmap_overlay_command)
9712         (simple_overlay_update): Use all_objfiles.
9713         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9714         * printcmd.c (info_symbol_command): Use all_objfiles.
9715         * objfiles.h (ALL_OBJSECTIONS): Remove.
9716         * maint.c (maintenance_translate_address): Use all_objfiles.
9717         * gcore.c (gcore_create_callback): Use all_objfiles.
9718         (objfile_find_memory_regions): Likewise.
9719
9720 2019-01-09  Tom Tromey  <tom@tromey.com>
9721
9722         * symtab.c (find_line_symtab, info_sources_command)
9723         (make_source_files_completion_list): Use objfile_compunits.
9724         * source.c (select_source_symtab): Use objfile_compunits.
9725         * objfiles.h (struct objfile): Update comment.
9726         (ALL_OBJFILES): Remove.
9727         (ALL_FILETABS): Remove.
9728         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9729         objfile_compunits.
9730
9731 2019-01-09  Tom Tromey  <tom@tromey.com>
9732
9733         * symmisc.c (print_objfile_statistics, dump_objfile)
9734         (maintenance_print_symbols): Use compunit_filetabs.
9735         * source.c (forget_cached_source_info_for_objfile): Use
9736         compunit_filetabs.
9737         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9738         (ALL_FILETABS): Use compunit_filetabs.
9739         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9740         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9741
9742 2019-01-09  Tom Tromey  <tom@tromey.com>
9743
9744         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9745         (compunit_filetabs): New.
9746         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9747         compunit_filetabs.
9748         (info_sources_command, make_source_files_completion_list): Remove
9749         declaration.
9750         * symmisc.c (print_objfile_statistics, dump_objfile)
9751         (maintenance_print_symbols): Remove declaration.
9752         (maintenance_info_symtabs): Use compunit_filetabs.
9753         (maintenance_info_line_tables): Likewise.
9754         * source.c (select_source_symtab): Change local variable name.
9755         (forget_cached_source_info_for_objfile): Remove declaration.
9756         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9757         * objfiles.c (objfile_relocate1): Remove declaration.
9758         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9759         declaration.
9760         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9761         * coffread.c (coff_symtab_read): Remove declaration.
9762         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9763         compunit_filetabs.
9764
9765 2019-01-09  Tom Tromey  <tom@tromey.com>
9766
9767         * symtab.c (lookup_objfile_from_block)
9768         (find_pc_sect_compunit_symtab, search_symbols)
9769         (default_collect_symbol_completion_matches_break_on): Use
9770         objfile_compunits.
9771         * objfiles.h (ALL_COMPUNITS): Remove.
9772         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9773         * cp-support.c (add_symbol_overload_list_qualified): Use
9774         objfile_compunits.
9775         * ada-lang.c (ada_collect_symbol_completion_matches)
9776         (ada_add_global_exceptions): Use objfile_compunits.
9777
9778 2019-01-09  Tom Tromey  <tom@tromey.com>
9779
9780         * source.c (select_source_symtab)
9781         (forget_cached_source_info_for_objfile): Remove declaration.
9782         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9783         declaration.
9784         * maint.c (count_symtabs_and_blocks): Remove declaration.
9785         * cp-support.c (add_symbol_overload_list_qualified): Remove
9786         declaration.
9787         * coffread.c (coff_symtab_read): Remove declaration.
9788         * symtab.c (lookup_symbol_in_objfile_symtabs)
9789         (basic_lookup_transparent_type_1): Use objfile_compunits.
9790         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9791         (info_sources_command, search_symbols)
9792         (default_collect_symbol_completion_matches_break_on)
9793         (make_source_files_completion_list): Remove declaration.
9794         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9795         (ada_collect_symbol_completion_matches)
9796         (ada_add_global_exceptions): Remove declaration.
9797         * linespec.c (iterate_over_all_matching_symtabs): Use
9798         objfile_compunits.
9799         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9800         (class objfile_compunits): New.
9801         (ALL_COMPUNITS): Use objfile_compunits.
9802         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9803         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9804         objfile_compunits.
9805         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9806
9807 2019-01-09  Tom Tromey  <tom@tromey.com>
9808
9809         * symtab.c (search_symbols)
9810         (default_collect_symbol_completion_matches_break_on): Use
9811         objfile_msymbols.
9812         * ada-lang.c (ada_lookup_simple_minsym)
9813         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9814         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9815         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9816         objfile_msymbols.
9817         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9818         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9819         * objc-lang.c (find_methods): Use objfile_msymbols.
9820         (info_selectors_command, info_classes_command): Likewise.
9821         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9822         * objfiles.h (class objfile_msymbols): New.
9823         (ALL_OBJFILE_MSYMBOLS): Remove.
9824         (ALL_MSYMBOLS): Remove.
9825
9826 2019-01-09  Tom Tromey  <tom@tromey.com>
9827
9828         * common/next-iterator.h (next_adapter): Add Iterator template
9829         parameter.
9830         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9831         (class all_objfiles_safe): New.
9832         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9833         * objfiles.c (put_objfile_before): Update comment.
9834         (add_separate_debug_objfile): Likewise.
9835         (free_all_objfiles): Use all_objfiles_safe.
9836         (objfile_purge_solibs): Likewise.
9837
9838 2019-01-09  Tom Tromey  <tom@tromey.com>
9839
9840         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9841         (expand_symtab_containing_pc, lookup_static_symbol)
9842         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9843         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9844         all_objfiles.
9845         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9846         * breakpoint.c (create_overlay_event_breakpoint)
9847         (create_longjmp_master_breakpoint)
9848         (create_std_terminate_master_breakpoint)
9849         (create_exception_master_breakpoint): Use all_objfiles.
9850         * linux-thread-db.c (try_thread_db_load_from_pdir)
9851         (has_libpthread): Use all_objfiles.
9852         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9853         * linespec.c (iterate_over_all_matching_symtabs)
9854         (search_minsyms_for_name): Use all_objfiles.
9855         * maint.c (maintenance_info_sections): Use all_objfiles.
9856         * main.c (captured_main_1): Use all_objfiles.
9857         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9858         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9859         * guile/scm-pretty-print.c
9860         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9861         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9862         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9863         (maintenance_print_msymbols): Use all_objfiles.
9864         * source.c (select_source_symtab): Use all_objfiles.
9865         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9866         * symfile.c (remove_symbol_file_command)
9867         (expand_symtabs_matching, map_symbol_filenames): Use
9868         all_objfiles.
9869         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9870         all_objfiles.
9871         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9872         * objc-lang.c (find_methods): Use all_objfiles.
9873         * objfiles.c (have_partial_symbols, have_full_symbols)
9874         (have_minimal_symbols, qsort_cmp)
9875         (default_iterate_over_objfiles_in_search_order): Use
9876         all_objfiles.
9877         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9878         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9879         (maintenance_check_psymtabs): Use all_objfiles.
9880         (ALL_PSYMTABS): Remove.
9881         * compile/compile-object-run.c (do_module_cleanup): Use
9882         all_objfiles.
9883         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9884         * cp-support.c (add_symbol_overload_list_qualified): Use
9885         all_objfiles.
9886         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9887         Use all_objfiles.
9888         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9889         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9890         all_objfiles.
9891         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9892         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9893         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9894         Uses all_objfiles.
9895         * solib.c (solib_read_symbols): Use all_objfiles
9896
9897 2019-01-09  Tom Tromey  <tom@tromey.com>
9898
9899         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9900         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9901         all_objfiles.
9902         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9903         * symmisc.c (print_symbol_bcache_statistics)
9904         (print_objfile_statistics, maintenance_print_objfiles)
9905         (maintenance_info_symtabs, maintenance_check_symtabs)
9906         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9907         all_objfiles.
9908         * source.c (forget_cached_source_info): Use all_objfiles.
9909         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9910         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9911         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9912         * objfiles.c (update_section_map): Use all_objfiles.
9913         (shared_objfile_contains_address_p): Likewise.
9914         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9915         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9916
9917 2019-01-09  Tom Tromey  <tom@tromey.com>
9918
9919         * common/next-iterator.h: New file.
9920         * objfiles.h (class all_objfiles): New.
9921         (struct objfile_iterator): New.
9922
9923 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9924
9925         * NEWS: Move the description of the changed "frame", "select-frame",
9926          and "info frame" commands to the Changed commands section.
9927
9928 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9929
9930         * gdbtypes.c (check_stub_method_group): Remove handling of old
9931         mangling schemes.
9932         * linespec.c (find_methods): Likewise.
9933         * stabsread.c (read_member_functions): Likewise.
9934         * valops.c (search_struct_method): Likewise.
9935         (value_struct_elt_for_reference): Likewise.
9936         * NEWS: Mention this change.
9937
9938 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9939
9940         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9941         print_source_lines.
9942         * source.c (print_source_lines_base): Update line number check.
9943         (print_source_lines): New function.
9944         (source_lines_range::source_lines_range): New function.
9945         * source.h (class source_lines_range): New class.
9946         (print_source_lines): New declaration.
9947
9948 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9949
9950         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9951
9952 2019-01-08  Tom Tromey  <tom@tromey.com>
9953             Simon Marchi  <simon.marchi@ericsson.com>
9954
9955         PR gdb/24060
9956         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9957         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9958         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9959         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9960         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9961         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9962
9963 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9964
9965         * source.c (select_source_symtab): Move header comment to
9966         declaration in source.h.
9967         (forget_cached_source_info_for_objfile): Likewise.
9968         (forget_cached_source_info): Likewise.
9969         (identify_source_line): Likewise.
9970         * source.h (identify_source_line): Move declaration from symtab.h
9971         and add comment from source.c
9972         (print_source_lines): Likewise.
9973         (forget_cached_source_info_for_objfile): Likewise.
9974         (forget_cached_source_info): Likewise.
9975         (select_source_symtab): Likewise.
9976         (enum print_source_lines_flag): Move definition from symtab.h.
9977         * symtab.h (identify_source_line): Move declaration to source.h.
9978         (print_source_lines): Likewise.
9979         (forget_cached_source_info_for_objfile): Likewise.
9980         (forget_cached_source_info): Likewise.
9981         (select_source_symtab): Likewise.
9982         (enum print_source_lines_flag): Move definition to source.h.
9983         * tui/tui-hooks.c: Add 'source.h' include.
9984
9985 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9986
9987         * source.c (print_source_lines_base): Handle requests to print
9988         reverse line number sequences, and guard against empty lines
9989         string.
9990
9991 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9992
9993         * source.c (print_source_lines_base): Fix skip of '\r' if next
9994         character is '\n'.
9995
9996 2019-01-06  Tom Tromey  <tom@tromey.com>
9997
9998         * c-exp.y (struct c_parse_state) <macro_original_text,
9999         expansion_obstack>: New member.
10000         (macro_original_text, expansion_obstack): Remove globals.
10001         (scan_macro_expansion, scanning_macro_expansion)
10002         (finished_macro_expansion): Update.
10003         (scan_macro_cleanup): Remove.
10004         (yylex, c_parse): Update.
10005
10006 2019-01-06  Tom Tromey  <tom@tromey.com>
10007
10008         * c-exp.y (struct c_parse_state) <strings>: New member.
10009         (operator_stoken): Update.
10010
10011 2019-01-06  Tom Tromey  <tom@tromey.com>
10012
10013         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10014         (union type_stack_elt) <typelist_val>: Now a pointer to
10015         std::vector.
10016         (type_stack_cleanup): Don't declare.
10017         (push_typelist): Update.
10018         * parse.c (pop_typelist): Return a std::vector.
10019         (push_typelist): Take a std::vector.
10020         (follow_types): Update.  Do not free args.
10021         (type_stack_cleanup): Remove.
10022         * c-exp.y (struct c_parse_state): New.
10023         (cpstate): New global.
10024         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10025         (nonempty_typelist): Update.
10026         (func_mod): Create a new vector.
10027         (c_parse): Create a c_parse_state.
10028         (check_parameter_typelist): Do not delete params.
10029         (function_method): Update.  Do not delete type_list.
10030
10031 2019-01-06  Tom Tromey  <tom@tromey.com>
10032
10033         PR gdb/28155:
10034         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10035         check_typedef.
10036         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10037         (print_return_value): Likewise.
10038
10039 2019-01-05  Tom Tromey  <tom@tromey.com>
10040
10041         * contrib/cleanup_check.py: Remove.
10042         * contrib/gcc-with-excheck: Remove.
10043         * contrib/exsummary.py: Remove.
10044         * contrib/excheck.py: Remove.
10045
10046 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10047
10048         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10049         NULL. Initialize tpprev to NULL instead of assigning it
10050         to NULL on the next statement.
10051         * windows-nat.c (windows_delete_thread): Remove check for
10052         main_thread_id before printing thread exit notifications.
10053         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10054         Remove thread ID check against main_thread_id.
10055         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10056         windows_delete_thread.
10057         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10058
10059 2019-01-04  Tom Tromey  <tom@tromey.com>
10060
10061         * compile/compile.c (_initialize_compile): Use upper case for
10062         metasyntactic variables.
10063         * symmisc.c (_initialize_symmisc): Use upper case for
10064         metasyntactic variables.
10065         * psymtab.c (_initialize_psymtab): Use upper case for
10066         metasyntactic variables.
10067         * demangle.c (demangle_command): Use upper case for metasyntactic
10068         variables.
10069         (_initialize_demangler): Likewise.
10070         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10071         variables.
10072
10073 2019-01-03  Tom Tromey  <tom@tromey.com>
10074
10075         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10076
10077 2019-01-03  Tom Tromey  <tom@tromey.com>
10078
10079         * python/py-symtab.c (salpy_str): Update.
10080         (struct salpy_sal_object) <symtab>: Now a PyObject.
10081         (salpy_dealloc): Update.
10082         (del_objfile_sal): Use gdbpy_ref.
10083
10084 2019-01-03  Tom Tromey  <tom@tromey.com>
10085
10086         * python/py-type.c (convert_field): Use new_reference.  Return
10087         gdbpy_ref.
10088         (make_fielditem): Return gdbpy_ref.
10089         (typy_fields): Update.
10090         (typy_getitem): Update.
10091         (field_name): Return gdbpy_ref.  Use new_reference.
10092         (typy_iterator_iternext): Update.
10093
10094 2019-01-03  Tom Tromey  <tom@tromey.com>
10095
10096         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10097
10098 2019-01-03  Tom Tromey  <tom@tromey.com>
10099
10100         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10101         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10102         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10103         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10104         (pspy_set_type_printers): Likewise.
10105         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10106         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10107         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10108         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10109         (objfpy_set_type_printers): Likewise.
10110
10111 2019-01-03  Tom Tromey  <tom@tromey.com>
10112
10113         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10114         (gdbpy_print_stack): Use gdbpy_err_fetch.
10115         * python/python-internal.h (class gdbpy_err_fetch): New class.
10116         (class gdbpy_enter) <m_error_type, m_error_value,
10117         m_error_traceback>: Remove.
10118         <m_error>: New member.
10119         (gdbpy_exception_to_string): Don't declare.
10120         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10121         * python/py-value.c (convert_value_from_python): Use
10122         gdbpy_err_fetch.
10123         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10124         gdbpy_exception_to_string.
10125         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10126         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10127         gdbpy_err_fetch.
10128
10129 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10130
10131         * linux-nat.c (delete_lwp_cleanup): Delete.
10132         (struct lwp_deleter): New struct.
10133         (lwp_info_up): New typedef.
10134         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10135         lwp_info_up.
10136
10137 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10138
10139         * linux-fork.c (class scoped_switch_fork_info): New class.
10140         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10141
10142 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10143
10144         * valops.c (find_overload_match): Remove use of null_cleanup, and
10145         calls to do_cleanups.
10146
10147 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10148
10149         * compile/compile-cplus-types.c
10150         (compile_cplus_instance::decl_name): Handle changes to
10151         cp_func_name.
10152         * cp-support.c (cp_func_name): Update header comment, update
10153         return type.
10154         * cp-support.h (cp_func_name): Update return type in declaration.
10155         * valops.c (find_overload_match): Move temp_func local to top
10156         level of function and change its type.  Use temp_func to hold and
10157         delete temporary string obtained from cp_func_name.
10158
10159 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10160
10161         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10162         gdb::char_vector, remove cleanup, and update uses of `msg`.
10163
10164 2019-01-03  Jim Wilson  <jimw@sifive.com>
10165
10166         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10167
10168 2019-01-02  Tom Tromey  <tom@tromey.com>
10169
10170         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10171         (tdesc_parse_xml): Remove cleanups.
10172         * target-descriptions.h (make_cleanup_free_target_description):
10173         Don't declare.
10174         (target_desc_deleter): New struct.
10175         (target_desc_up): New typedef.
10176         * target-descriptions.c (target_desc_deleter::operator()): Rename
10177         from free_target_description.
10178         (make_cleanup_free_target_description): Remove.
10179
10180 2019-01-02  Tom Tromey  <tom@tromey.com>
10181
10182         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10183         constructor, destructor.
10184         (linespec_parser): Remove typedef.
10185         (~linespec_parser): Rename from linespec_parser_delete.
10186         (linespec_lex_to_end, linespec_complete_label)
10187         (linespec_complete): Update.
10188         (decode_line_full): Remove cleanups.
10189         (decode_line_1): Update.
10190
10191 2019-01-02  Tom Tromey  <tom@tromey.com>
10192
10193         * python/python-internal.h (inferior_to_inferior_object): Change
10194         return type.
10195         * python/py-exitedevent.c (create_exited_event_object): Update.
10196         * python/py-inferior.c (inferior_to_inferior_object): Return
10197         gdbpy_ref.
10198         (python_new_inferior, python_inferior_deleted)
10199         (thread_to_thread_object, delete_thread_object)
10200         (build_inferior_list, gdbpy_selected_inferior): Update.
10201         * python/py-infthread.c (create_thread_object): Update.  Also fail
10202         if inferior_to_inferior_object fails.
10203
10204 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10205
10206         * inferior.h (class inferior) <displaced_step_state>: New field.
10207         * infrun.h (struct displaced_step_state): Move here from
10208         infrun.c.  Initialize fields, add constructor.
10209         <inf>: Remove field.
10210         <reset>: New method.
10211         * infrun.c (struct displaced_step_inferior_state): Move to
10212         infrun.h.
10213         (displaced_step_inferior_states): Remove.
10214         (get_displaced_stepping_state): Adust.
10215         (displaced_step_in_progress_any_inferior): Adjust.
10216         (displaced_step_in_progress_thread): Adjust.
10217         (displaced_step_in_progress): Adjust.
10218         (add_displaced_stepping_state): Remove.
10219         (get_displaced_step_closure_by_addr): Adjust.
10220         (remove_displaced_stepping_state): Remove.
10221         (infrun_inferior_exit): Call displaced_step_state.reset.
10222         (use_displaced_stepping): Don't check for NULL.
10223         (displaced_step_prepare_throw): Call
10224         get_displaced_stepping_state.
10225         (displaced_step_fixup): Don't check for NULL.
10226         (prepare_for_detach): Don't check for NULL.
10227
10228 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10229
10230         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10231          in case of call that did not complete.
10232
10233 2019-01-02  Andrey Utkin  <autkin@undo.io>
10234
10235         * symfile.c (find_separate_debug_file): Fix search of debug files for
10236         remote debuggee.
10237
10238 2019-01-02  Tom Tromey  <tom@tromey.com>
10239
10240         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10241         indentation.
10242         * python/py-frame.c (frapy_older): Remove cast.
10243         (frapy_newer): Likewise.
10244         * python/py-breakpoint.c (local_setattro): Remove cast.
10245         * python/py-arch.c (archpy_name): Remove local variable.
10246         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10247
10248 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10249
10250         * unittests/basic_string_view/element_access/char/empty.cc:
10251         Fix year range in copyright header.
10252
10253 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10254
10255         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10256         Delete.
10257         <operator==>: Update with for removed field.
10258         <hash>: Likewise.
10259         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10260         <isa_features>: ...this.
10261         <abi_features>: New field.
10262         (riscv_isa_flen): Update comment.
10263         (riscv_abi_xlen): New declaration.
10264         (riscv_abi_flen): New declaration.
10265         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10266         isa_features.
10267         (riscv_abi_xlen): New function.
10268         (riscv_isa_flen): Update to get answer from isa_features.
10269         (riscv_abi_flen): New function.
10270         (riscv_has_fp_abi): Update to get answer from abi_features.
10271         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10272         xlen and flen.
10273         (riscv_call_info) <xlen, flen>: Update comment.
10274         (riscv_call_arg_struct): Remove invalid assertions
10275         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10276         is removed.
10277         (riscv_gdbarch_init): Gather isa features and abi features
10278         separately, ensure both match on the gdbarch when reusing an old
10279         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10280         a target with 64-bit float hardware.
10281
10282 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10283
10284         * source.c (search_command_helper): Stop reverse search
10285         when line 1 has been searched.
10286
10287 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10288
10289         * record-full.c (record_full_base_target::close): Rewrite
10290         record_full_core_buf_list free logic.
10291
10292 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10293
10294         * break-catch-syscall.c (print_one_catch_syscall): xfree
10295         the last text.
10296
10297 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10298
10299         * top.c (print_gdb_version): Update Copyright year in version
10300         message.
10301
10302 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10303
10304         Update copyright year range in all GDB files.
10305
10306 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10307
10308         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10309
10310 For older changes see ChangeLog-2018.
10311 \f
10312 Local Variables:
10313 mode: change-log
10314 left-margin: 8
10315 fill-column: 74
10316 version-control: never
10317 coding: utf-8
10318 End:
10319