gdb/ChangeLog

   1 2019-05-08  Tom Tromey  <tom@tromey.com>
   2
   3         * gdbtypes.c (objfile_type_data): Change type.
   4         (objfile_type, _initialize_gdbtypes): Update.
   5
   6 2019-05-08  Tom Tromey  <tom@tromey.com>
   7
   8         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
   9         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
  10         (_initialize_dwarf2_frame): Update.
  11
  12 2019-05-08  Tom Tromey  <tom@tromey.com>
  13
  14         * objc-lang.c (objc_objfile_data): Change type.
  15         (find_methods): Update.
  16         (_initialize_objc_lang): Remove.
  17
  18 2019-05-08  Tom Tromey  <tom@tromey.com>
  19
  20         * stabsread.c (rs6000_builtin_type_data): Change type.
  21         (rs6000_builtin_type, _initialize_stabsread): Update.
  22
  23 2019-05-08  Tom Tromey  <tom@tromey.com>
  24
  25         * mips-tdep.c (mips_pdr_data): Remove.
  26         (_initialize_mips_tdep): Update.
  27
  28 2019-05-08  Tom Tromey  <tom@tromey.com>
  29
  30         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
  31         (hppa_init_objfile_priv_data, read_unwind_info)
  32         (find_unwind_entry, _initialize_hppa_tdep): Update.
  33
  34 2019-05-08  Tom Tromey  <tom@tromey.com>
  35
  36         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
  37         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
  38         on obstack.
  39         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
  40
  41 2019-05-08  Tom Tromey  <tom@tromey.com>
  42
  43         * mdebugread.c (basic_type_data): Change type.
  44         (basic_type, _initialize_mdebugread): Update.
  45
  46 2019-05-08  Tom Tromey  <tom@tromey.com>
  47
  48         * common/gdb_unique_ptr.h (struct noop_deleter): New.
  49
  50 2019-05-08  Tom Tromey  <tom@tromey.com>
  51
  52         * nto-tdep.c (nto_inferior_data_reg): Change type.
  53         (nto_inferior_data): Update.
  54         (nto_inferior_data_cleanup, nto_new_inferior_data)
  55         (_initialize_nto_tdep): Remove.
  56         * nto-tdep.h (struct nto_inferior_data): Add initializers.
  57
  58 2019-05-08  Tom Tromey  <tom@tromey.com>
  59
  60         * ada-lang.c (struct ada_inferior_data): Add initializers.
  61         (ada_inferior_data): Change type.
  62         (ada_inferior_data_cleanup): Remove.
  63         (get_ada_inferior_data, ada_inferior_exit)
  64         (struct ada_pspace_data): Add initializers, destructor.
  65         (ada_pspace_data_handle): Change type.
  66         (get_ada_pspace_data): Update.
  67         (ada_pspace_data_cleanup): Remove.
  68
  69 2019-05-08  Tom Tromey  <tom@tromey.com>
  70
  71         * coffread.c (struct coff_symfile_info): Add initializers.
  72         (coff_objfile_data_key): Move lower.  Change type.
  73         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
  74         Update.
  75         (coff_free_info): Remove.
  76
  77 2019-05-08  Tom Tromey  <tom@tromey.com>
  78
  79         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
  80         (fbsd_pspace_data_handle): Move lower.  Change type.
  81         (get_fbsd_pspace_data): Update.
  82         (fbsd_pspace_data_cleanup): Remove.
  83         (_initialize_fbsd_tdep): Update.
  84
  85 2019-05-08  Tom Tromey  <tom@tromey.com>
  86
  87         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
  88         (get_ada_tasks_pspace_data): Update.
  89         (ada_tasks_pspace_data_cleanup): Remove.
  90         (_initialize_tasks): Update.
  91         (ada_tasks_inferior_data_handle): Change type.
  92         (get_ada_tasks_inferior_data): Update.
  93         (ada_tasks_inferior_data_cleanup): Remove.
  94         (struct ada_tasks_pspace_data): Add initializers.
  95
  96 2019-05-08  Tom Tromey  <tom@tromey.com>
  97
  98         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
  99         * symfile-debug.c (debug_sym_get_probes): Change type.
 100         * stap-probe.c (handle_stap_probe):
 101         (stap_static_probe_ops::get_probes): Change type.
 102         * probe.h (class static_probe_ops) <get_probes>: Change type.
 103         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
 104         (parse_probes_in_pspace): Update.
 105         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
 106         Update.
 107         (any_static_probe_ops::get_probes): Change type.
 108         * elfread.c (elfread_data): New typedef.
 109         (probe_key): Change type.
 110         (elf_get_probes): Likewise.  Update.
 111         (probe_key_free): Remove.
 112         (_initialize_elfread): Update.
 113         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
 114         Change type.
 115         (dtrace_process_dof_probe, dtrace_process_dof)
 116         (dtrace_static_probe_ops::get_probe): Change type.
 117
 118 2019-05-08  Tom Tromey  <tom@tromey.com>
 119
 120         * xcoffread.c (struct xcoff_symfile_info): Rename from
 121         coff_symfile_info.  Add initializers.
 122         (xcoff_objfile_data_key): Move lower.  Change type.
 123         (XCOFF_DATA): Rewrite.
 124         (xcoff_free_info): Remove.
 125         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
 126         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
 127         (xcoff_initial_scan): Update.
 128
 129 2019-05-08  Tom Tromey  <tom@tromey.com>
 130
 131         * solib-svr4.c (struct svr4_info): Add initializers and
 132         destructor.
 133         <probes_table>: Now an htab_up.
 134         (solib_svr4_pspace_data): Change type.
 135         (free_probes_table): Simplify.
 136         (~svr4_info): Rename from svr4_pspace_data_cleanup.
 137         (get_svr4_info, probes_table_htab_remove_objfile_probes)
 138         (probes_table_remove_objfile_probes, register_solib_event_probe)
 139         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
 140         (_initialize_svr4_solib): Update.
 141
 142 2019-05-08  Tom Tromey  <tom@tromey.com>
 143
 144         * remote.c (remote_pspace_data): Change type.
 145         (remote_pspace_data_cleanup): Remove.
 146         (get_remote_exec_file, set_pspace_remote_exec_file)
 147         (_initialize_remote): Update.
 148
 149 2019-05-08  Tom Tromey  <tom@tromey.com>
 150
 151         * breakpoint.c (breakpoint_objfile_key): Change type.
 152         (get_breakpoint_objfile_data): Update.
 153         (free_breakpoint_objfile_data): Remove.
 154         (_initialize_breakpoint): Update.
 155
 156 2019-05-08  Tom Tromey  <tom@tromey.com>
 157
 158         * linux-tdep.c (struct linux_info): Add initializers.
 159         (linux_inferior_data): Move.  Change type.
 160         (invalidate_linux_cache_inf): Update.
 161         (linux_inferior_data_cleanup): Remove.
 162         (get_linux_inferior_data, _initialize_linux_tdep): Update.
 163
 164 2019-05-08  Tom Tromey  <tom@tromey.com>
 165
 166         * auxv.c (auxv_inferior_data): Move.  Change type.
 167         (auxv_inferior_data_cleanup): Remove.
 168         (invalidate_auxv_cache_inf): Rewrite.
 169         (get_auxv_inferior_data, _initialize_auxv): Update.
 170
 171 2019-05-08  Tom Tromey  <tom@tromey.com>
 172
 173         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
 174         (symfile_debug_objfile_data_key): Change type.
 175         (symfile_debug_installed, debug_qf_has_symbols)
 176         (debug_qf_find_last_source_symtab)
 177         (debug_qf_forget_cached_source_info)
 178         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
 179         (debug_qf_print_stats, debug_qf_dump)
 180         (debug_qf_expand_symtabs_for_function)
 181         (debug_qf_expand_all_symtabs)
 182         (debug_qf_expand_symtabs_with_fullname)
 183         (debug_qf_map_matching_symbols)
 184         (debug_qf_expand_symtabs_matching)
 185         (debug_qf_find_pc_sect_compunit_symtab)
 186         (debug_qf_map_symbol_filenames)
 187         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
 188         (debug_sym_new_init, debug_sym_init, debug_sym_read)
 189         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
 190         (debug_sym_read_linetable, debug_sym_relocate): Update.
 191         (symfile_debug_free_objfile): Remove.
 192         (install_symfile_debug_logging, _initialize_symfile_debug):
 193         Update.
 194
 195 2019-05-08  Tom Tromey  <tom@tromey.com>
 196
 197         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
 198         allocate_on_obstack.
 199         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
 200         (get_dwarf2_per_objfile): Update.
 201         (set_dwarf2_per_objfile): Remove.
 202         (dwarf2_has_info, dwarf2_get_section_info): Update.
 203         (dwarf2_free_objfile): Remove.
 204         (_initialize_dwarf2_read): Update.
 205
 206 2019-05-08  Tom Tromey  <tom@tromey.com>
 207
 208         * auto-load.c (struct auto_load_pspace_info): Add destructor and
 209         initializers.
 210         <unsupported_script_warning_printed,
 211         script_not_found_warning_printed>: Now bool.
 212         (auto_load_pspace_data): Change type.
 213         (~auto_load_pspace_info): Rename from
 214         auto_load_pspace_data_cleanup.
 215         (get_auto_load_pspace_data, init_loaded_scripts_info)
 216         (clear_section_scripts, maybe_print_unsupported_script_warning)
 217         (maybe_print_script_not_found_warning, _initialize_auto_load):
 218         Update.
 219
 220 2019-05-08  Tom Tromey  <tom@tromey.com>
 221
 222         * objfiles.c (objfile_pspace_info): Add destructor and
 223         initializers.
 224         (objfiles_pspace_data): Change type.
 225         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
 226         (get_objfile_pspace_data): Update.
 227         (objfiles_bfd_data): Change type.
 228         (get_objfile_bfd_data): Update.
 229         (objfile_bfd_data_free, _initialize_objfiles): Remove.
 230
 231 2019-05-08  Tom Tromey  <tom@tromey.com>
 232
 233         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
 234         Change type.
 235         (get_catch_syscall_inferior_data): Update.
 236         (catch_syscall_inferior_data_cleanup): Remove.
 237         (_initialize_break_catch_syscall): Update.
 238
 239 2019-05-08  Tom Tromey  <tom@tromey.com>
 240
 241         * inflow.c (struct terminal_info): Add destructor and
 242         initializers.
 243         (inflow_inferior_data): Change type.
 244         (~terminal_info): Rename from inflow_inferior_data_cleanup.
 245         (get_inflow_inferior_data, inflow_inferior_exit)
 246         (swap_terminal_info, _initialize_inflow): Update.
 247
 248 2019-05-08  Tom Tromey  <tom@tromey.com>
 249
 250         * target-dcache.c (target_dcache_cleanup): Remove.
 251         (target_dcache_aspace_key): Change type.
 252         (target_dcache_init_p, target_dcache_invalidate)
 253         (target_dcache_get, target_dcache_get_or_init)
 254         (_initialize_target_dcache): Update.
 255         * dcache.h (struct dcache_deleter): New.
 256
 257 2019-05-08  Tom Tromey  <tom@tromey.com>
 258
 259         * symtab.c (struct symbol_cache): Add destructor and
 260         initializers.
 261         (symbol_cache_key): Move.  Change type.
 262         (make_symbol_cache, free_symbol_cache): Remove.
 263         (get_symbol_cache): Update.
 264         (symbol_cache_cleanup): Remove.
 265         (ALL_PSPACES, symbol_cache_flush)
 266         (maintenance_print_symbol_cache)
 267         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
 268         Update.
 269
 270 2019-05-08  Tom Tromey  <tom@tromey.com>
 271
 272         * symtab.c (struct main_info): Add destructor and initializers.
 273         (main_progspace_key): Move.  Change type.
 274         (get_main_info): Update.
 275         (main_info_cleanup): Remove.
 276         (_initialize_symtab): Update.
 277
 278 2019-05-08  Tom Tromey  <tom@tromey.com>
 279
 280         * registry.h (DECLARE_REGISTRY): Define the _key class.
 281
 282 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 283
 284         * NEWS: Merge two 'New commands' sections.
 285
 286 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 287
 288         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 289         parameter and use Ada language definition instead.
 290         (ada_val_print_ptr): Remove unused language parameter.
 291         (ada_val_print_num): Remove language parameter and use Ada language
 292         definition instead.
 293         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 294         parameter.
 295         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 296         parameter and use Ada language definition instead.
 297         (ada_val_print_1): Update all ada_val_print_xxx calls.
 298         Remove language parameter.
 299         (ada_val_print): Update ada_val_print_1 call.
 300
 301 2019-05-08  Tom Tromey  <tromey@adacore.com>
 302
 303         * remote.c (remote_hw_watchpoint_limit)
 304         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 305         Now static.
 306
 307 2019-05-08  Tom Tromey  <tromey@adacore.com>
 308
 309         * maint.c (_initialize_maint_cmds): Move initialization code to
 310         remote.c.
 311         (watchdog, show_watchdog): Move to remote.c.
 312         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 313         "watchdog" static.
 314         (_initialize_remote): Move initialization code from maint.c.
 315         * defs.h (watchdog): Don't declare.
 316
 317 2019-05-08  Tom Tromey  <tromey@adacore.com>
 318
 319         * tui/tui-interp.c: Include main.h.
 320         * interps.c: Include main.h.
 321         * main.h (interpreter_p): Declare.
 322         * defs.h (interpreter_p): Don't declare.
 323
 324 2019-05-08  Tom Tromey  <tromey@adacore.com>
 325
 326         * dwarf2loc.c: Include dwarf2read.h.
 327         * defs.h (read_unsigned_leb128): Don't declare.
 328         * dwarf2read.h (read_unsigned_leb128): Declare.
 329
 330 2019-05-08  Tom Tromey  <tromey@adacore.com>
 331
 332         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 333         method.
 334
 335 2019-05-08  Tom Tromey  <tromey@adacore.com>
 336
 337         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 338         when no wrap column is set.
 339
 340 2019-05-08  Tom Tromey  <tromey@adacore.com>
 341
 342         * c-lang.c (c_get_string): Handle non-C-style arrays.
 343
 344 2019-05-08  Tom Tromey  <tromey@adacore.com>
 345
 346         * typeprint.c (print_offset_data::update): Print the bit offset,
 347         not the number of bits remaining.
 348
 349 2019-05-08  Tom Tromey  <tromey@adacore.com>
 350
 351         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 352         padding at end of comment.
 353
 354 2019-05-08  Tom Tromey  <tromey@adacore.com>
 355
 356         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 357         Compare main types.
 358
 359 2019-05-06  Tom Tromey  <tom@tromey.com>
 360
 361         * common/scoped_mmap.c: Include common-defs.h.
 362         * common/scoped_mmap.h: Don't include config.h.
 363
 364 2019-05-04  Tom Tromey  <tom@tromey.com>
 365
 366         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 367         (struct aarch64_call_info): Add initializers.
 368         <si>: Now a std::vector.
 369         (pass_on_stack, aarch64_push_dummy_call): Update.
 370
 371 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 372             Tom Tromey  <tom@tromey.com>
 373
 374         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 375         (ppc_threads): Now a std::vector.  Now static.
 376         (hwdebug_find_thread_points_by_tid)
 377         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 378         Update.
 379
 380 2019-05-04  Tom Tromey  <tom@tromey.com>
 381
 382         * arc-tdep.c (arc_tdesc_init): Return bool.
 383
 384 2019-05-04  Tom Tromey  <tom@tromey.com>
 385
 386         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 387         Use gdb_assert_not_reached.
 388
 389 2019-05-04  Tom Tromey  <tom@tromey.com>
 390
 391         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 392         "false".
 393
 394 2019-05-04  Tom Tromey  <tom@tromey.com>
 395
 396         * arc-tdep.c (arc_tdesc_init): Use bool.
 397
 398 2019-05-04  Tom Tromey  <tom@tromey.com>
 399
 400         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 401
 402 2019-05-04  Tom Tromey  <tom@tromey.com>
 403
 404         * cli/cli-cmds.c (valid_command_p): Return bool.
 405
 406 2019-05-04  Tom Tromey  <tom@tromey.com>
 407
 408         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 409         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 410
 411 2019-05-04  Raul Tambre  <raul@tambre.ee>
 412
 413         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 414         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 415         operator for comparison.
 416
 417 2019-05-04  Tom Tromey  <tom@tromey.com>
 418
 419         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 420         (lookup_partial_symbol, print_partial_symbols)
 421         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 422         (psymbol_compare): Update.
 423         (add_psymbol_to_bcache): Clear the entire psymbol.
 424         (maintenance_check_psymtabs): Update.
 425         * psympriv.h (struct partial_symbol): Don't derive from
 426         general_symbol_info.
 427         <obj_section, unrelocated_address, address,
 428         set_unrelocated_address>: Update.
 429         <ginfo>: New member.
 430         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 431         (debug_names::write_psymbols): Update.
 432
 433 2019-05-04  Tom de Vries  <tdevries@suse.de>
 434
 435         * contrib/cc-with-tweaks.sh: Support -n arg.
 436
 437 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 438
 439         * corelow.c (core_target::detach): Ensure frame cache and
 440         register caches are cleared.
 441         inferior.c (exit_inferior_1): Likewise.
 442
 443 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 444             Tom Tromey  <tom@tromey.com>
 445
 446         * dictionary.c (collate_pending_symbols_by_language): Remove
 447         "struct" from foreach.
 448         * symtab.c (lookup_global_symbol_from_objfile)
 449         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 450         foreach.
 451         * ser-tcp.c (net_open): Remove "struct" from foreach.
 452         * objfiles.c (objfile_relocate, objfile_rebase)
 453         (objfile_has_symbols): Remove "struct" from foreach.
 454         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 455         from foreach.
 456         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 457         foreach.
 458         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 459         "struct" from foreach.
 460         * ada-lang.c (create_excep_cond_exprs)
 461         (ada_exception_catchpoint_cond_string): Remove "struct" from
 462         foreach.
 463
 464 2019-05-03  Tom Tromey  <tromey@adacore.com>
 465
 466         * ada-exp.y (convert_char_literal): Check suffix of each
 467         enumerator.
 468
 469 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 470
 471         PR ada/21406:
 472         * ada-exp.y (yywrap): Don't define.
 473         * ada-lex.l (%option): Add noyywrap
 474         (yywrap): Remove.
 475
 476 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 477
 478         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 479         _WIN32_WINNT to the XP level, unless already defined to a higher
 480         level.
 481
 482         * unittests/parse-connection-spec-selftests.c:
 483         * ser-tcp.c:
 484         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 485         override.
 486
 487         * symfile.c (find_separate_debug_file): Remove colon from the
 488         drive spec of DOS/Windows file names of the target, so that the
 489         file name produced from DEBUGDIR and the target's directory will
 490         be valid on DOS/Windows systems.
 491
 492 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 493
 494         * rust-lang.c (val_print_struct): Handle printing structures
 495         containing strings.
 496
 497 2019-05-02  Tom Tromey  <tromey@adacore.com>
 498
 499         * valarith.c (_initialize_valarith): Remove.
 500
 501 2019-05-01  Tom Tromey  <tromey@adacore.com>
 502
 503         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 504         bitfields.
 505
 506 2019-05-01  Tom Tromey  <tromey@adacore.com>
 507
 508         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 509         for big-endian copies.
 510
 511 2019-04-30  Ali Tamur  <tamur@google.com>
 512         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 513         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 514         (read_3_bytes): New function.
 515
 516 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 517
 518         * windows-nat.c (main_thread_id): Delete.
 519         (handle_output_debug_string): Replace main_thread_id by
 520         current_event.dwThreadId.
 521         (fake_create_process): Likewise.
 522         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 523         Do not set main_thread_id.
 524         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 525         current_event.dwThreadId.
 526         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 527
 528 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 529
 530         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 531         Use current_event.dwThreadId instead of main_thread_id.
 532
 533 2019-04-30  Tom Tromey  <tromey@adacore.com>
 534
 535         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 536         (create_excep_cond_exprs): Iterate over program spaces.
 537         (ada_exception_catchpoint_cond_string): Examine all minimal
 538         symbols for exception types.
 539
 540 2019-04-30  Tom Tromey  <tromey@adacore.com>
 541
 542         PR c++/24470:
 543         * dwarf2read.c (process_structure_scope): Handle case where type
 544         has template parameters but no symbol was created.
 545
 546 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 547             Chris January  <chris.january@arm.com>
 548
 549         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 550         qualifier.
 551         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 552
 553 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 554
 555         * f-typeprint.c (f_print_type): Update rules for printing
 556         whitespace.
 557         (f_type_print_varspec_suffix): Likewise.
 558
 559 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 560             Chris January  <chris.january@arm.com>
 561
 562         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 563         function arguments.
 564
 565 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 566
 567         * f-lang.c (build_fortran_types): Change name of void type to
 568         lower case.
 569         * f-typeprint.c (f_type_print_base): Print the name of the void
 570         type, rather than a fixed string.
 571         * f-valprint.c (f_decorations): Use lower case void string.
 572
 573 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 574             Chris January  <chris.january@arm.com>
 575
 576         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 577         types for Fortran.
 578
 579 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 580             Chris January  <chris.january@arm.com>
 581             David Lecomber  <david.lecomber@arm.com>
 582
 583         * f-exp.y (BINOP_INTRINSIC): New token.
 584         (exp): New parser rule handling BINOP_INTRINSIC.
 585         (f77_keywords): Add new builtin procedures.
 586         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 587         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 588         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 589         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 590         (print_unop_subexp_f): New function.
 591         (print_binop_subexp_f): New function.
 592         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 593         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 594         (dump_subexp_body_f): Likewise.
 595         (operator_check_f): Likewise.
 596         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 597         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 598
 599 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 600
 601         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 602         UNOP_KIND.
 603         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 604         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 605         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 606         (operator_length_f): New fuction.
 607         (print_subexp_f): New function.
 608         (op_name_f): New function.
 609         (dump_subexp_body_f): New function.
 610         (operator_check_f): New function.
 611         (exp_descriptor_f): Replace standard expression handling functions
 612         with new functions.
 613         * gdb/fortran-operator.def: New file.
 614         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 615         * gdb/std-operator.def: Remove UNOP_KIND.
 616
 617 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 618
 619         * std-operator.def: Remove unbalanced, stray double quote
 620         character.
 621
 622 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 623             Chris January  <chris.january@arm.com>
 624             Daniel Everett  <daniel.everett@arm.com>
 625             Nick Forrington  <nick.forrington@arm.com>
 626             Richard Bunt  <richard.bunt@arm.com>
 627
 628         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 629         of depth when printing anonymous structs or unions.
 630         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 631         Don't print either the top-level value, or the children if the
 632         max-depth is exceeded.
 633         (ppscm_print_children): When printing the key of a map, allow one
 634         extra level of depth.
 635         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 636         print either the top-level value, or the children if the max-depth
 637         is exceeded.
 638         (print_children): When printing the key of a map, allow one extra
 639         level of depth.
 640         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 641         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 642         (user_print_options): Initialise max_depth field.
 643         (val_print_scalar_or_string_type_p): New function.
 644         (val_print): Check to see if the max depth has been reached.
 645         (val_print_check_max_depth): Define new function.
 646         (show_print_max_depth): New function.
 647         (_initialize_valprint): Add 'print max-depth' option.
 648         * valprint.h (struct value_print_options) <max_depth>: New field.
 649         (val_print_check_max_depth): Declare new function.
 650         * NEWS: Document new feature.
 651
 652 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 653
 654         * ada-lang.c (ada_language_defn): Initialise new field.
 655         * c-lang.c (c_is_string_type_p): New function.
 656         (c_language_defn): Initialise new field.
 657         (cplus_language_defn): Initialise new field.
 658         (asm_language_defn): Initialise new field.
 659         (minimal_language_defn): Initialise new field.
 660         * c-lang.h (c_is_string_type_p): Declare new function.
 661         * d-lang.c (d_language_defn): Initialise new field.
 662         * f-lang.c (f_is_string_type_p): New function.
 663         (f_language_defn): Initialise new field.
 664         * go-lang.c (go_is_string_type_p): New function.
 665         (go_language_defn): Initialise new field.
 666         * language.c (default_is_string_type_p): New function.
 667         (unknown_language_defn): Initialise new field.
 668         (auto_language_defn): Initialise new field.
 669         * language.h (struct language_defn) <la_is_string_type_p>: New
 670         member variable.
 671         (default_is_string_type_p): Declare new function.
 672         * m2-lang.c (m2_language_defn): Initialise new field.
 673         * objc-lang.c (objc_language_defn): Initialise new field.
 674         * opencl-lang.c (opencl_language_defn): Initialise new field.
 675         * p-lang.c (pascal_is_string_type_p): New function.
 676         (pascal_language_defn): Initialise new field.
 677         * rust-lang.c (rust_is_string_type_p): New function.
 678         (rust_language_defn): Initialise new field.
 679
 680 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 681
 682         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 683         New field.
 684         * ada-lang.c (ada_language_defn): Initialise new field.
 685         * c-lang.c (c_language_defn): Likewise.
 686         (cplus_language_defn): Likewise.
 687         (asm_language_defn): Likewise.
 688         (minimal_language_defn): Likewise.
 689         * d-lang.c (d_language_defn): Likewise.
 690         * f-lang.c (f_language_defn): Likewise.
 691         * go-lang.c (go_language_defn): Likewise.
 692         * language.c (unknown_language_defn): Likewise.
 693         (auto_language_defn): Likewise.
 694         * m2-lang.c (m2_language_defn): Likewise.
 695         * objc-lang.c (objc_language_defn): Likewise.
 696         * opencl-lang.c (opencl_language_defn): Likewise.
 697         * p-lang.c (pascal_language_defn): Likewise.
 698         * rust-lang.c (rust_language_defn): Likewise.
 699
 700 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 701
 702         * ada-lang.c (ada_is_character_type): Change return type to bool.
 703         (ada_is_string_type): Likewise.
 704         * ada-lang.h (ada_is_character_type): Update declaration
 705         (ada_is_string_type): Likewise.
 706
 707 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 708
 709         Support style in 'frame|thread apply'
 710
 711         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 712         * record.c (record_start, record_stop): Update callers of
 713         execute_command_to_string with false.
 714         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 715         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 716         methods.
 717         (class string_file): New constructor with term_out parameter.
 718         Override methods term_out and can_emit_style_escape.  New member
 719         term_out.
 720         (class stdio_file): Override can_emit_style_escape.
 721         (class tee_file): Override term_out and can_emit_style_escape.
 722         * utils.h (can_emit_style_escape): Remove.
 723         * utils.c (can_emit_style_escape): Likewise.
 724         Update all callers of can_emit_style_escape (SOMESTREAM) to
 725         SOMESTREAM->can_emit_style_escape.
 726         * source-cache.c (source_cache::get_source_lines): Likewise.
 727         * stack.c (frame_apply_command_count): Call execute_command_to_string
 728         passing the term_out characteristic of the current gdb_stdout.
 729         * thread.c (thr_try_catch_cmd): Likewise.
 730         * top.c (execute_command_to_string): pass term_out parameter
 731         to construct the string_file for the command output.
 732         * ui-file.c (term_cli_styling): New function (most code moved
 733         from utils.c can_emit_style_escape).
 734         (string_file::string_file, string_file::can_emit_style_escape,
 735         stdio_file::can_emit_style_escape, tee_file::term_out,
 736         tee_file::can_emit_style_escape): New functions.
 737
 738 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 739
 740         * NEWS: Mention the new set|show may-call-functions.
 741         * infcall.c (may_call_functions_p): New variable.
 742         (show_may_call_functions_p): New function.
 743         (call_function_by_hand_dummy): Throws an error if not
 744         may-call-functions.
 745         (_initialize_infcall): Call add_setshow_boolean_cmd for
 746         may-call-functions.
 747
 748 2019-04-25  Keith Seitz  <keiths@redhat.com>
 749
 750         PR c++/24367
 751         * cp-support.c (inspect_type): Don't attempt substitutions
 752         of symbol with the same name.
 753
 754 2019-04-25  Tom Tromey  <tromey@adacore.com>
 755
 756         PR gdb/24475:
 757         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 758         static.
 759
 760 2019-04-25  Tom Tromey  <tromey@adacore.com>
 761
 762         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 763         rvalue reference.
 764         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 765         (gdb_xml_parser::parse): Use std::move.
 766         * python/python-internal.h (gdbpy_convert_exception): Take a const
 767         reference.
 768         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 769         std::move.
 770         * python/py-utils.c (gdbpy_convert_exception): Take a const
 771         reference.
 772         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 773         Use std::move.
 774         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 775         Use std::move.
 776         * mi/mi-main.c (mi_print_exception): Take a const reference.
 777         * main.c (handle_command_errors): Take a const reference.
 778         * linespec.c (parse_linespec): Use std::move.
 779         * infcall.c (run_inferior_call): Use std::move.
 780         (call_function_by_hand_dummy): Use std::move.
 781         * exec.c (try_open_exec_file): Use std::move.
 782         * exceptions.h (exception_print, exception_fprintf)
 783         (exception_print_same): Update.
 784         * exceptions.c (print_exception, exception_print)
 785         (exception_fprintf, exception_print_same): Change parameters to
 786         const reference.
 787         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 788         * common/new-op.c: Use std::move.
 789         * common/common-exceptions.h (struct gdb_exception): Add move
 790         constructor.
 791         (struct gdb_exception_error, struct gdb_exception_quit, struct
 792         gdb_quit_bad_alloc): Change constructor to move constructor.
 793         (throw_exception): Change parameter to rvalue reference.
 794         * common/common-exceptions.c (throw_exception): Take rvalue
 795         reference.
 796         * cli/cli-interp.c (safe_execute_command): Use std::move.
 797         * breakpoint.c (insert_bp_location, location_to_sals): Use
 798         std::move.
 799
 800 2019-04-25  Tom Tromey  <tromey@adacore.com>
 801
 802         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 803         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 804         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 805         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 806         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 807         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 808         guile/scm-value.c: Use unpack.
 809         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 810         gdbscm_gdb_exception.
 811         (gdbscm_throw_gdb_exception): Likewise.
 812         (struct gdbscm_gdb_exception): New.
 813         (unpack): New function.
 814         (gdbscm_wrap): Use unpack.
 815
 816 2019-04-25  Tom Tromey  <tromey@adacore.com>
 817
 818         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 819         (gdb_rl_callback_handler): Use std::move.
 820         * common/common-exceptions.h (struct gdb_exception): Add move
 821         assignment operator.
 822         (throw_exception_sjlj): Change "exception" to const reference.
 823         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 824         (throw_exception_sjlj): Change "exception" to const reference.
 825
 826 2019-04-25  Tom Tromey  <tromey@adacore.com>
 827
 828         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 829         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 830         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 831         Update.
 832         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 833         Update.
 834         * mi/mi-interp.c (mi_interp::exec): Update.
 835         * linespec.c (parse_linespec): Update.
 836         * infcall.c (run_inferior_call): Update.
 837         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 838         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 839         (gdbscm_lookup_global_symbol): Update.
 840         * guile/scm-param.c (gdbscm_parameter_value): Update.
 841         * guile/scm-frame.c (gdbscm_frame_read_register)
 842         (gdbscm_frame_read_var): Update.
 843         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 844         * exec.c (try_open_exec_file): Update.
 845         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 846         (gdb_rl_callback_handler): Update.
 847         * common/common-exceptions.h (exception_none): Don't declare.
 848         * common/common-exceptions.c (exception_none): Don't define.
 849         (struct catcher) <exception>: Update.
 850         * cli/cli-interp.c (safe_execute_command): Update.
 851         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 852
 853 2019-04-25  Ali Tamur  <tamur@google.com>
 854
 855         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 856         (read_attribute_value): Likewise.
 857         (dwarf2_read_addr_index): Update comment.
 858         (read_str_index): Add DW_FORM_strx.
 859         (dwarf2_string_attr): Likewise.
 860         (dwarf2_const_value_attr): Likewise.
 861         (dump_die_shallow): Likewise.
 862         (dwarf2_fetch_constant_bytes): Likewise.
 863         (skip_form_bytes): Likewise.
 864         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 865
 866 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 867
 868         PR corefiles/11608
 869         PR corefiles/18187
 870         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 871         OFFSET.  Verify if current mapping contains an ELF header.
 872         (linux_find_memory_regions_full): Adjust call to
 873         dump_mapping_p.
 874
 875 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 876             Kang Li <kanglictf@gmail.com>
 877
 878         PR gdb/21600
 879
 880         * dwarf2-frame.c (read_initial_length): Be consistent about using
 881         unsigned representation of length.
 882         (decode_frame_entry_1): Likewise.  Check for wraparound of
 883         end pointer as well as buffer overflow.
 884
 885 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 886
 887         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 888         "vq".
 889
 890 2019-04-24  Tom Tromey  <tromey@adacore.com>
 891
 892         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 893
 894 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 895
 896         * s12z-tdep.c (s12z_unwind_pc): Delete.
 897         (s12z_unwind_sp): Delete.
 898         (s12z_gdbarch_init): Don't register deleted functions with
 899         gdbarch.
 900
 901 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 902
 903         * rl78-tdep.c (rl78_unwind_sp): Delete.
 904         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 905
 906 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 907
 908         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 909         (xstormy16_unwind_pc): Delete.
 910         (xstormy16_dummy_id): Delete.
 911         (xstormy16_gdbarch_init): Don't register deleted functions with
 912         gdbarch.
 913
 914 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 915
 916         * vax-tdep.c (vax_unwind_pc): Delete.
 917         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 918
 919 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 920
 921         * v850-tdep.c (v850_unwind_sp): Delete.
 922         (v850_unwind_pc): Delete.
 923         (v850_dummy_id): Delete.
 924         (v850_gdbarch_init): Don't register deleted functions with
 925         gdbarch.
 926
 927 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 928
 929         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 930         (tilegx_unwind_pc): Delete.
 931         (tilegx_unwind_dummy_id): Delete.
 932         (tilegx_gdbarch_init): Don't register deleted functions with
 933         gdbarch.
 934
 935 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 936
 937         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 938         (tic6x_dummy_id): Delete.
 939         (tic6x_gdbarch_init): Don't register deleted functions with
 940         gdbarch.
 941
 942 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 943
 944         * sparc-tdep.c (sparc_unwind_pc): Delete.
 945         (sparc32_gdbarch_init): Don't register deleted function with
 946         gdbarch.
 947
 948 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 949
 950         * sh-tdep.c (sh_unwind_sp): Delete.
 951         (sh_unwind_pc): Delete.
 952         (sh_dummy_id): Delete.
 953         (sh_gdbarch_init): Don't register deleted functions with
 954         gdbarch.
 955
 956 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 957
 958         * score-tdep.c (score_unwind_sp): Delete.
 959         (score_unwind_pc): Delete.
 960         (score_dummy_id): Delete.
 961         (score_gdbarch_init): Don't register deleted functions with
 962         gdbarch.
 963
 964 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 965
 966         * rx-tdep.c (rx_unwind_pc): Delete.
 967         (rx_unwind_sp): Delete.
 968         (rx_dummy_id): Delete.
 969         (rx_gdbarch_init): Don't register deleted functions with
 970         gdbarch.  Update comment.
 971
 972 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 973
 974         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 975         (rs6000_dummy_id): Delete.
 976         (rs6000_gdbarch_init): Don't register deleted functions with
 977         gdbarch.
 978
 979 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 980
 981         * or1k-tdep.c (or1k_dummy_id): Delete.
 982         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 983
 984 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 985
 986         * nios2-tdep.c (nios2_dummy_id): Delete.
 987         (nios2_unwind_sp): Delete.
 988         (nios2_gdbarch_init): Don't register deleted functions with
 989         gdbarch.
 990
 991 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 992
 993         * nds32-tdep.c (nds32_dummy_id): Delete.
 994         (nds32_unwind_pc): Delete.
 995         (nds32_unwind_sp): Delete.
 996         (nds32_gdbarch_init): Don't register deleted functions with
 997         gdbarch.
 998
 999 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1000
1001         * msp430-tdep.c (msp430_unwind_pc): Delete.
1002         (msp430_unwind_sp): Delete.
1003         (msp430_dummy_id): Delete.
1004         (msp430_gdbarch_init): Don't register deleted functions with
1005         gdbarch.
1006
1007 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1008
1009         * moxie-tdep.c (moxie_unwind_sp): Delete.
1010         (moxie_unwind_pc): Delete.
1011         (moxie_dummy_id): Delete.
1012         (moxie_gdbarch_init): Don't register deleted functions with
1013         gdbarch.
1014
1015 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1016
1017         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1018         (mn10300_unwind_pc): Delete.
1019         (mn10300_unwind_sp): Delete.
1020         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1021         mn10300_unwind_sp.
1022         (mn10300_frame_unwind_init): Don't register deleted functions with
1023         gdbarch.
1024
1025 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1026
1027         * mep-tdep.c (mep_unwind_pc): Delete.
1028         (mep_unwind_sp): Delete.
1029         (mep_dummy_id): Delete.
1030         (mep_gdbarch_init): Don't register deleted functions with
1031         gdbarch.
1032
1033 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1034
1035         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1036         (m68hc11_unwind_sp): Delete.
1037         (m68hc11_gdbarch_init): Don't register deleted functions with
1038         gdbarch.
1039
1040 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1041
1042         * m32r-tdep.c (m32r_unwind_sp): Delete.
1043         (m32r_unwind_pc): Delete.
1044         (m32r_dummy_id): Delete.
1045         (m32r_gdbarch_init): Don't register deleted functions with
1046         gdbarch.
1047
1048 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1049
1050         * m32c-tdep.c (m32c_unwind_pc): Delete.
1051         (m32c_unwind_sp): Delete.
1052         (m32c_dummy_id): Delete.
1053         (m32c_gdbarch_init): Don't register deleted functions with
1054         gdbarch.
1055
1056 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1057
1058         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1059         (lm32_unwind_pc): Delete.
1060         (lm32_dummy_id): Delete.
1061         (lm32_gdbarch_init): Don't register deleted functions with
1062         gdbarch.
1063
1064 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1065
1066         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1067         (iq2000_unwind_pc): Delete.
1068         (iq2000_dummy_id): Delete.
1069         (iq2000_gdbarch_init): Don't register deleted functions with
1070         gdbarch.
1071
1072 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1073
1074         * nds32-tdep.c (nds32_type_align): Delete.
1075         (nds32_push_dummy_call): Use type_align instead.
1076
1077 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1078
1079         * arm-tdep.c (arm_type_align): Only handle vector override case.
1080         (arm_push_dummy_call): Use type_align.
1081         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1082
1083 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1084
1085         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1086         case.
1087         (pass_on_stack): Use type_align.
1088         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1089         function.
1090
1091 2019-04-23  Tom Tromey  <tromey@adacore.com>
1092
1093         * dwarf2read.c (line_header::file_name_at): Remove unused
1094         overload.
1095
1096 2019-04-23  Tom de Vries  <tdevries@suse.de>
1097
1098         PR gdb/24438
1099         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1100         invocation.
1101
1102
1103 2019-03-27  Ali Tamur  <tamur@google.com>
1104
1105         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1106         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1107         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1108         (dwarf_expr_context::get_addr_index): Likewise
1109         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1110         (symbol_needs_eval_context::get_addr_index): Likewise
1111         (disassemble_dwarf_expression): Add DW_OP_addrx
1112         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1113         (read_cutu_die_from_dwo): Update comment
1114         (skip_one_die): Add DW_FORM_addrx
1115         (read_attribute_value): Likewise
1116         (var_decode_location): Add DW_OP_addrx
1117         (dwarf2_const_value_attr): Add DW_FORM_addrx
1118         (dump_die_shallow): Likewise
1119         (dwarf2_fetch_constant_bytes): Likewise
1120         (decode_locdesc): Add DW_OP_addrx
1121         (skip_form_bytes): Add DW_FORM_addrx
1122
1123 2019-04-22  Ali Tamur  <tamur@google.com>
1124
1125         * MAINTAINERS (Write After Approval): Add self.
1126
1127 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1128
1129         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1130         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1131         (open_symbol_file_object): Likewise.
1132         (svr4_default_sos): Add info parameter.
1133         (svr4_read_so_list): Likewise.
1134         (svr4_current_sos_direct): Adjust functions calls to pass down
1135         info.
1136         (svr4_current_sos_1): Add info parameter.
1137         (svr4_current_sos): Call get_svr4_info, pass info down to
1138         svr4_current_sos_1.
1139         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1140         get_svr4_info.
1141         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1142         get_svr4_info.
1143         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1144         to get_svr4_info.
1145         (probes_table_remove_objfile_probes): Likewise.
1146         (register_solib_event_probe): Add info parameter.
1147         (solist_update_incremental): Pass info parameter down to
1148         svr4_read_so_list.
1149         (disable_probes_interface): Add info parameter.
1150         (svr4_handle_solib_event): Pass current_program_space to
1151         get_svr4_info.  Adjust disable_probes_interface cleanup.
1152         (svr4_create_probe_breakpoints): Add info parameter, pass it
1153         down to register_solib_event_probe.
1154         (svr4_create_solib_event_breakpoints): Add info parameter,
1155         pass it down to svr4_create_probe_breakpoints.
1156         (enable_break): Pass info down to
1157         svr4_create_solib_event_breakpoints.
1158         (svr4_solib_create_inferior_hook): Pass current_program_space to
1159         get_svr4_info.
1160         (svr4_clear_solib): Likewise.
1161
1162 2019-04-22  Pedro Alves  <palves@redhat.com>
1163
1164         * solib-svr4.c (svr4_free_objfile_observer): New.
1165         (probe_and_action::objfile): New field.
1166         (probes_table_htab_remove_objfile_probes)
1167         (probes_table_remove_objfile_probes): New functions.
1168         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1169         in the new probe_and_action.  Don't store the probe in 'lookup'.
1170         (svr4_create_probe_breakpoints): Pass objfile to
1171         register_solib_event_probe.
1172         (_initialize_svr4_solib): Register a free_objfile observer.
1173
1174 2019-04-19  Tom Tromey  <tom@tromey.com>
1175
1176         * common/queue.h: Remove.
1177
1178 2019-04-19  Tom Tromey  <tom@tromey.com>
1179
1180         * event-loop.c: Don't include "common/queue.h".
1181
1182 2019-04-19  Tom Tromey  <tom@tromey.com>
1183
1184         * remote.c (remote_target): Use delete.
1185         * remote-notif.h: Include <list>, not "common/queue.h".
1186         (notif_client_p): Remove typedef.
1187         (remote_notif_state): Add constructor, destructor, initializer.
1188         <notif_queue>: Now a std::list.
1189         (remote_notif_state_xfree): Don't declare.
1190         * remote-notif.c (remote_notif_process, handle_notification)
1191         (remote_notif_state_allocate): Update.
1192         (~remote_notif_state): Rename from remote_notif_state_xfree.
1193
1194 2019-04-19  Tom Tromey  <tom@tromey.com>
1195
1196         * symfile.c (reread_symbols): Update.
1197         * objfiles.c (objfile_register_static_link)
1198         (objfile_lookup_static_link): Update
1199         (~objfile) Don't delete static_links.
1200         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1201
1202 2019-04-19  Tom Tromey  <tom@tromey.com>
1203
1204         * type-stack.h (struct type_stack) <insert>: Constify string.
1205         * type-stack.c (type_stack::insert): Constify string.
1206         * gdbtypes.h (lookup_template_type): Update.
1207         (address_space_name_to_int): Update.
1208         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1209         const.
1210         (lookup_template_type): Make name const.
1211         * c-exp.y: Update rules.
1212         (lex_one_token, classify_name, classify_inner_name)
1213         (c_print_token): Update.
1214         * p-exp.y: Update rules.
1215         (yylex): Update.
1216         * f-exp.y: Update rules.
1217         (yylex): Update.
1218         * d-exp.y: Update rules.
1219         (lex_one_token, classify_name, classify_inner_name): Update.
1220         * parse.c (write_dollar_variable, copy_name): Return std::string.
1221         * parser-defs.h (copy_name): Change return type.
1222         * m2-exp.y: Update rules.
1223         (yylex): Update.
1224         * go-exp.y (lex_one_token): Update.
1225         Update rules.
1226         (classify_unsafe_function, classify_packaged_name)
1227         (classify_name, yylex): Update.
1228
1229 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1230
1231         * configure.ac: add --enable-source-highlight switch.
1232         * configure: Regenerate.
1233         * top.c (print_gdb_version): plumb --enable-source-highlight
1234         status to "show configuration".
1235
1236 2019-04-19  Tom Tromey  <tromey@adacore.com>
1237
1238         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1239         Check ADA_TYPE_P.
1240         (empty_record, ada_template_to_fixed_record_type_1)
1241         (template_to_static_fixed_type)
1242         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1243         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1244         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1245         macros.
1246
1247 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1248
1249         PR symtab/24423:
1250         * source.c (print_source_lines_base): Advance "iter" when a
1251         control character is seen.
1252
1253 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1254
1255         * inferior.h (struct infcall_suspend_state_deleter):
1256         Catch exception in destructor to avoid crash.
1257
1258 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1259
1260         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1261         close to the add_com "shell".
1262
1263 2019-04-18  Tom Tromey  <tromey@adacore.com>
1264
1265         * process-stratum-target.h (class process_stratum_target)
1266         <stratum>: Add "final".
1267
1268 2019-04-17  Tom Tromey  <tromey@adacore.com>
1269
1270         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1271         against nullptr before use.
1272
1273 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1274
1275         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1276
1277 2019-04-17  Jim Wilson  <jimw@sifive.com>
1278             Andrew Burgess  <andrew.burgess@embecosm.com>
1279
1280         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1281         code read might fail, assume 4-byte breakpoint in that case.
1282
1283 2019-04-15  Leszek Swirski  <leszeks@google.com>
1284
1285         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1286         rather than a hand-rolled POD check when checking for forced MEMORY
1287         classification.
1288
1289 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1290
1291         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1292         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1293         function.
1294         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1295         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1296         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1297         declaration.
1298
1299 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1300
1301         * aarch64-linux-nat.c
1302         (aarch64_linux_nat_target::thread_architecture): Add override.
1303         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1304         each VQ.
1305
1306 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1307
1308         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1309
1310 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1311
1312         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1313         target types of size 96-bits, add some additional comments, and
1314         check that the builtin type we found was the correct size.
1315
1316 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1317
1318         * utils.c (prompt_for_continue): Don't restore the styling at the
1319         end, as applied_style has the wrong value.  This fixes styling in
1320         long lists of file names that are interrupted by the "Continue?"
1321         prompt.
1322
1323 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1324
1325         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1326         * c-lang.c (c_language_defn): Likewise.
1327         (cplus_language_defn): Likewise.
1328         (asm_language_defn): Likewise.
1329         (minimal_language_defn): Likewise.
1330         * d-lang.c (d_language_defn): Likewise.
1331         * f-lang.c (f_language_defn): Likewise.
1332         * go-lang.c (go_language_defn): Likewise.
1333         * language.c (unknown_language_defn): Likewise.
1334         (auto_language_defn): Likewise.
1335         * language.h (struct language_defn): Remove la_magic field.
1336         (LANG_MAGIC): Delete.
1337         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1338         * objc-lang.c (objc_language_defn): Likewise.
1339         * opencl-lang.c (opencl_language_defn): Likewise.
1340         * p-lang.c (pascal_language_defn): Likewise.
1341         * rust-lang.c (rust_language_defn): Likewise.
1342
1343 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1344
1345         * riscv-tdep.c (riscv_type_align): New function.
1346         (riscv_type_alignment): Delete.
1347         (riscv_arg_location): Use 'type_align'.
1348         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1349
1350 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1351
1352         * gdbtypes.c (type_align): A struct with no non-static fields also
1353         has alignment of 1.
1354
1355 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1356
1357         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1358         component to 0.
1359         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1360         member.
1361         (riscv_struct_info::analyse): New implementation using new
1362         analyse_inner member function.
1363         (riscv_struct_info::field_offset): New member function.
1364         (riscv_struct_info::m_offsets): New member variable.
1365         (riscv_struct_info::analyse_inner): New private member function,
1366         takes the old implementation of riscv_struct_info::analyse but
1367         extended to track field offsets.
1368         (riscv_call_arg_struct): Update the struct folding special cases
1369         to handle cases where empty C++ structs, which are non-zero
1370         length, are found.
1371         (riscv_arg_location): Initialise the length of each location, a
1372         non-zero length now indicates the location is in use.
1373         (riscv_push_dummy_call): Allow for the first location having a
1374         non-zero offset when setting up arguments.
1375         (riscv_return_value): Likewise, but for return values.
1376
1377 2019-04-11  Tom Tromey  <tromey@adacore.com>
1378
1379         * utils.c (internal_vproblem): Make "msg" const.
1380
1381 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1382
1383         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1384         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1385         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1386         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1387
1388 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1389
1390         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1391         function.
1392         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1393         of amd64_collect_native_gregset.
1394         (amd64_linux_nat_target::store_registers): Likewise.
1395
1396 2019-04-10  Tom Tromey  <tom@tromey.com>
1397
1398         * symtab.c (lookup_global_symbol_from_objfile)
1399         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1400         * objfiles.h (class separate_debug_iterator): New.
1401         (class separate_debug_range): New.
1402         (struct objfile) <separate_debug_objfiles>: New method.
1403         (objfile_separate_debug_iterate): Don't declare.
1404         * objfiles.c (separate_debug_iterator::operator++): Rename from
1405         objfile_separate_debug_iterate.
1406         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1407         iterator.
1408         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1409         iterator.
1410
1411 2019-04-10  Tom Tromey  <tom@tromey.com>
1412
1413         * symfile.c (reread_symbols): Remove old comment.
1414         * objfiles.c (free_all_objfiles): Fix a typo.
1415
1416 2019-04-10  Tom Tromey  <tom@tromey.com>
1417
1418         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1419         * minsyms.c (lookup_minimal_symbol): Use foreach.
1420         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1421         (lookup_minimal_symbol_solib_trampoline): Likewise.
1422         * symfile.c (reread_symbols): Use foreach.
1423
1424 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1425             Tom Tromey  <tromey@adacore.com>
1426
1427         PR rust/24414:
1428         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1429         (rust_lex_int_test): Change "value" to be LONGEST.
1430         (rust_lex_tests): Add test for long integer literal.
1431
1432 2019-04-09  Tom Tromey  <tromey@adacore.com>
1433
1434         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1435         to bool.
1436         (extended_remote_target::attach): Update.
1437         (remote_target::remote_notice_new_inferior): Update.
1438         (remote_target::add_current_inferior_and_thread): Update.
1439         * inferior.c (exit_inferior_1): Use "false".
1440         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1441
1442 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1443
1444         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1445         the "start" command.
1446
1447 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1448
1449         * python/py-inferior.c (infpy_thread_from_thread_handle):
1450         Adjust comments to reflect renaming of thread_from_thread_handle
1451         to thread_from_handle.  Adjust keywords.  Fix type error message.
1452         (inferior_object_methods): Add thread_from_handle.  Retain
1453         thread_from_thread_handle, but mark it as deprecated.
1454
1455 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1456
1457         * gdbthread.h (find_thread_by_handle): Revise declaration.
1458         * thread.c (find_thread_by_handle): Likewise.  Adjust
1459         implementation too.
1460         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1461         support for buffer objects as handles.
1462
1463 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1464
1465         * python/py-infthread.c (thpy_thread_handle): New function.
1466         (thread_object_methods): Register thpy_thread_handle.
1467
1468 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1469
1470         * gdbthread.h (thread_to_thread_handle): Declare.
1471         * thread.c (gdbtypes.h): Include.
1472         (thread_to_thread_handle): New function.
1473
1474         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1475         (target_thread_info_to_thread_handle): Declare.
1476         * target.c (target_thread_info_to_thread_handle): New function.
1477         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1478         * target-delegates.c: Regenerate.
1479
1480         * linux-thread-db.c (class thread_db_target): Add method
1481         thread_info_to_thread_handle.
1482         (thread_db_target::thread_info_to_thread_handle): Define.
1483         * remote.c (class remote_target): Add new method
1484         thread_info_to_thread_handle.
1485         (remote_target::thread_info_to_thread_handle): Define.
1486
1487 2019-04-08  Pedro Alves  <palves@redhat.com>
1488
1489         * common/common-exceptions.c (throw_exception): Don't create
1490         named object to throw; throw directly.
1491         (throw_it): Likewise.  Don't initialize gdb_exception::message
1492         here, with new; pass FMT and AP to the ctor instead.
1493         * common/common-exceptions.h: Include <string>.
1494         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1495         const char *, va_list)): New ctor.  Use std::make_shared.
1496         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1497         errors)): Delete.
1498         (gdb_exception_error::gdb_exception_error(enum errors, const char
1499         *, va_list)): New.
1500         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1501         Add assertion.
1502         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1503         errors)): Delete.
1504         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1505         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1506         Add assertion.
1507
1508 2019-04-08  Tom Tromey  <tom@tromey.com>
1509
1510         * valops.c (value_rtti_indirect_type): Replace throw_exception
1511         with throw.
1512         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1513         with throw.
1514         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1515         throw.
1516         * target.c (target_translate_tls_address): Replace throw_exception
1517         with throw.
1518         * stack.c (frame_apply_command_count): Replace throw_exception
1519         with throw.
1520         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1521         throw.
1522         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1523         with throw.
1524         * rs6000-tdep.c (rs6000_frame_cache)
1525         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1526         * remote.c: Replace throw_exception with throw.
1527         * record-full.c (record_full_message, record_full_wait_1)
1528         (record_full_restore): Replace throw_exception with throw.
1529         * record-btrace.c:
1530         (get_thread_current_frame_id, record_btrace_start_replaying)
1531         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1532         (cmd_record_btrace_start): Replace throw_exception with throw.
1533         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1534         throw.
1535         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1536         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1537         * linespec.c:
1538         (find_linespec_symbols): Replace throw_exception with throw.
1539         * infrun.c (displaced_step_prepare, resume): Replace
1540         throw_exception with throw.
1541         * infcmd.c (post_create_inferior): Replace throw_exception with
1542         throw.
1543         * inf-loop.c (inferior_event_handler): Replace throw_exception
1544         with throw.
1545         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1546         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1547         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1548         (get_prev_frame_always, get_frame_pc_if_available)
1549         (get_frame_address_in_block_if_available, get_frame_language):
1550         Replace throw_exception with throw.
1551         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1552         throw_exception with throw.
1553         * eval.c (fetch_subexp_value, evaluate_var_value)
1554         (evaluate_funcall, evaluate_subexp_standard): Replace
1555         throw_exception with throw.
1556         * dwarf2loc.c (call_site_find_chain)
1557         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1558         Replace throw_exception with throw.
1559         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1560         with throw.
1561         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1562         throw.
1563         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1564         * completer.c (complete_line_internal): Replace throw_exception
1565         with throw.
1566         * compile/compile-object-run.c (compile_object_run): Replace
1567         throw_exception with throw.
1568         * cli/cli-script.c (process_next_line): Replace throw_exception
1569         with throw.
1570         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1571         (btrace_enable, btrace_maint_update_pt_packets): Replace
1572         throw_exception with throw.
1573         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1574         throw_exception with throw.
1575         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1576         throw_exception with throw.
1577         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1578         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1579         * aarch64-tdep.c (aarch64_make_prologue_cache)
1580         (aarch64_make_stub_cache): Replace throw_exception with throw.
1581
1582 2019-04-08  Tom Tromey  <tom@tromey.com>
1583
1584         * common/common-exceptions.c (throw_exception): Rename from
1585         throw_exception_cxx.  Remove old copy.  Make argument const.
1586         (throw_it): Create and throw exception objects directly.
1587         * common/common-exceptions.h (throw_exception): Make argument
1588         const.
1589         (struct gdb_exception_error): Add constructor.
1590         (struct gdb_exception_quit): Add constructor.
1591
1592 2019-04-08  Tom Tromey  <tom@tromey.com>
1593
1594         * common/common-exceptions.h (exception_rethrow): Don't declare.
1595         (TRY_SJLJ): Update comment.
1596         (TRY, CATCH, END_CATCH): Remove.
1597         * common/common-exceptions.c (exception_rethrow): Remove.
1598
1599 2019-04-08  Tom Tromey  <tom@tromey.com>
1600
1601         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1602         Remove.
1603         (gdb_exception_error): Rename from
1604         gdb_exception_RETURN_MASK_ERROR.
1605         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1606         (gdb_quit_bad_alloc): Update.
1607         * aarch64-tdep.c: Update.
1608         * ada-lang.c: Update.
1609         * ada-typeprint.c: Update.
1610         * ada-valprint.c: Update.
1611         * amd64-tdep.c: Update.
1612         * arch-utils.c: Update.
1613         * break-catch-throw.c: Update.
1614         * breakpoint.c: Update.
1615         * btrace.c: Update.
1616         * c-varobj.c: Update.
1617         * cli/cli-cmds.c: Update.
1618         * cli/cli-interp.c: Update.
1619         * cli/cli-script.c: Update.
1620         * common/common-exceptions.c: Update.
1621         * common/new-op.c: Update.
1622         * common/selftest.c: Update.
1623         * compile/compile-c-symbols.c: Update.
1624         * compile/compile-cplus-symbols.c: Update.
1625         * compile/compile-object-load.c: Update.
1626         * compile/compile-object-run.c: Update.
1627         * completer.c: Update.
1628         * corelow.c: Update.
1629         * cp-abi.c: Update.
1630         * cp-support.c: Update.
1631         * cp-valprint.c: Update.
1632         * darwin-nat.c: Update.
1633         * disasm-selftests.c: Update.
1634         * dtrace-probe.c: Update.
1635         * dwarf-index-cache.c: Update.
1636         * dwarf-index-write.c: Update.
1637         * dwarf2-frame-tailcall.c: Update.
1638         * dwarf2-frame.c: Update.
1639         * dwarf2loc.c: Update.
1640         * dwarf2read.c: Update.
1641         * eval.c: Update.
1642         * event-loop.c: Update.
1643         * event-top.c: Update.
1644         * exec.c: Update.
1645         * f-valprint.c: Update.
1646         * fbsd-tdep.c: Update.
1647         * frame-unwind.c: Update.
1648         * frame.c: Update.
1649         * gdbtypes.c: Update.
1650         * gnu-v3-abi.c: Update.
1651         * guile/guile-internal.h: Update.
1652         * guile/scm-block.c: Update.
1653         * guile/scm-breakpoint.c: Update.
1654         * guile/scm-cmd.c: Update.
1655         * guile/scm-disasm.c: Update.
1656         * guile/scm-frame.c: Update.
1657         * guile/scm-lazy-string.c: Update.
1658         * guile/scm-math.c: Update.
1659         * guile/scm-param.c: Update.
1660         * guile/scm-ports.c: Update.
1661         * guile/scm-pretty-print.c: Update.
1662         * guile/scm-symbol.c: Update.
1663         * guile/scm-symtab.c: Update.
1664         * guile/scm-type.c: Update.
1665         * guile/scm-value.c: Update.
1666         * i386-linux-tdep.c: Update.
1667         * i386-tdep.c: Update.
1668         * inf-loop.c: Update.
1669         * infcall.c: Update.
1670         * infcmd.c: Update.
1671         * infrun.c: Update.
1672         * jit.c: Update.
1673         * language.c: Update.
1674         * linespec.c: Update.
1675         * linux-fork.c: Update.
1676         * linux-nat.c: Update.
1677         * linux-tdep.c: Update.
1678         * linux-thread-db.c: Update.
1679         * main.c: Update.
1680         * mi/mi-cmd-break.c: Update.
1681         * mi/mi-cmd-stack.c: Update.
1682         * mi/mi-interp.c: Update.
1683         * mi/mi-main.c: Update.
1684         * objc-lang.c: Update.
1685         * p-valprint.c: Update.
1686         * parse.c: Update.
1687         * ppc-linux-tdep.c: Update.
1688         * printcmd.c: Update.
1689         * python/py-arch.c: Update.
1690         * python/py-breakpoint.c: Update.
1691         * python/py-cmd.c: Update.
1692         * python/py-finishbreakpoint.c: Update.
1693         * python/py-frame.c: Update.
1694         * python/py-framefilter.c: Update.
1695         * python/py-gdb-readline.c: Update.
1696         * python/py-inferior.c: Update.
1697         * python/py-infthread.c: Update.
1698         * python/py-lazy-string.c: Update.
1699         * python/py-linetable.c: Update.
1700         * python/py-objfile.c: Update.
1701         * python/py-param.c: Update.
1702         * python/py-prettyprint.c: Update.
1703         * python/py-progspace.c: Update.
1704         * python/py-record-btrace.c: Update.
1705         * python/py-record.c: Update.
1706         * python/py-symbol.c: Update.
1707         * python/py-type.c: Update.
1708         * python/py-unwind.c: Update.
1709         * python/py-utils.c: Update.
1710         * python/py-value.c: Update.
1711         * python/python.c: Update.
1712         * record-btrace.c: Update.
1713         * record-full.c: Update.
1714         * remote-fileio.c: Update.
1715         * remote.c: Update.
1716         * riscv-tdep.c: Update.
1717         * rs6000-aix-tdep.c: Update.
1718         * rs6000-tdep.c: Update.
1719         * rust-exp.y: Update.
1720         * rust-lang.c: Update.
1721         * s390-tdep.c: Update.
1722         * selftest-arch.c: Update.
1723         * solib-dsbt.c: Update.
1724         * solib-frv.c: Update.
1725         * solib-spu.c: Update.
1726         * solib-svr4.c: Update.
1727         * solib.c: Update.
1728         * sparc64-linux-tdep.c: Update.
1729         * stack.c: Update.
1730         * symfile-mem.c: Update.
1731         * symmisc.c: Update.
1732         * target.c: Update.
1733         * thread.c: Update.
1734         * top.c: Update.
1735         * tracefile-tfile.c: Update.
1736         * tui/tui.c: Update.
1737         * typeprint.c: Update.
1738         * unittests/cli-utils-selftests.c: Update.
1739         * unittests/parse-connection-spec-selftests.c: Update.
1740         * valops.c: Update.
1741         * valprint.c: Update.
1742         * value.c: Update.
1743         * varobj.c: Update.
1744         * windows-nat.c: Update.
1745         * x86-linux-nat.c: Update.
1746         * xml-support.c: Update.
1747
1748 2019-04-08  Tom Tromey  <tom@tromey.com>
1749
1750         * xml-support.c: Use C++ exception handling.
1751         * x86-linux-nat.c: Use C++ exception handling.
1752         * windows-nat.c: Use C++ exception handling.
1753         * varobj.c: Use C++ exception handling.
1754         * value.c: Use C++ exception handling.
1755         * valprint.c: Use C++ exception handling.
1756         * valops.c: Use C++ exception handling.
1757         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1758         handling.
1759         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1760         * typeprint.c: Use C++ exception handling.
1761         * tui/tui.c: Use C++ exception handling.
1762         * tracefile-tfile.c: Use C++ exception handling.
1763         * top.c: Use C++ exception handling.
1764         * thread.c: Use C++ exception handling.
1765         * target.c: Use C++ exception handling.
1766         * symmisc.c: Use C++ exception handling.
1767         * symfile-mem.c: Use C++ exception handling.
1768         * stack.c: Use C++ exception handling.
1769         * sparc64-linux-tdep.c: Use C++ exception handling.
1770         * solib.c: Use C++ exception handling.
1771         * solib-svr4.c: Use C++ exception handling.
1772         * solib-spu.c: Use C++ exception handling.
1773         * solib-frv.c: Use C++ exception handling.
1774         * solib-dsbt.c: Use C++ exception handling.
1775         * selftest-arch.c: Use C++ exception handling.
1776         * s390-tdep.c: Use C++ exception handling.
1777         * rust-lang.c: Use C++ exception handling.
1778         * rust-exp.y: Use C++ exception handling.
1779         * rs6000-tdep.c: Use C++ exception handling.
1780         * rs6000-aix-tdep.c: Use C++ exception handling.
1781         * riscv-tdep.c: Use C++ exception handling.
1782         * remote.c: Use C++ exception handling.
1783         * remote-fileio.c: Use C++ exception handling.
1784         * record-full.c: Use C++ exception handling.
1785         * record-btrace.c: Use C++ exception handling.
1786         * python/python.c: Use C++ exception handling.
1787         * python/py-value.c: Use C++ exception handling.
1788         * python/py-utils.c: Use C++ exception handling.
1789         * python/py-unwind.c: Use C++ exception handling.
1790         * python/py-type.c: Use C++ exception handling.
1791         * python/py-symbol.c: Use C++ exception handling.
1792         * python/py-record.c: Use C++ exception handling.
1793         * python/py-record-btrace.c: Use C++ exception handling.
1794         * python/py-progspace.c: Use C++ exception handling.
1795         * python/py-prettyprint.c: Use C++ exception handling.
1796         * python/py-param.c: Use C++ exception handling.
1797         * python/py-objfile.c: Use C++ exception handling.
1798         * python/py-linetable.c: Use C++ exception handling.
1799         * python/py-lazy-string.c: Use C++ exception handling.
1800         * python/py-infthread.c: Use C++ exception handling.
1801         * python/py-inferior.c: Use C++ exception handling.
1802         * python/py-gdb-readline.c: Use C++ exception handling.
1803         * python/py-framefilter.c: Use C++ exception handling.
1804         * python/py-frame.c: Use C++ exception handling.
1805         * python/py-finishbreakpoint.c: Use C++ exception handling.
1806         * python/py-cmd.c: Use C++ exception handling.
1807         * python/py-breakpoint.c: Use C++ exception handling.
1808         * python/py-arch.c: Use C++ exception handling.
1809         * printcmd.c: Use C++ exception handling.
1810         * ppc-linux-tdep.c: Use C++ exception handling.
1811         * parse.c: Use C++ exception handling.
1812         * p-valprint.c: Use C++ exception handling.
1813         * objc-lang.c: Use C++ exception handling.
1814         * mi/mi-main.c: Use C++ exception handling.
1815         * mi/mi-interp.c: Use C++ exception handling.
1816         * mi/mi-cmd-stack.c: Use C++ exception handling.
1817         * mi/mi-cmd-break.c: Use C++ exception handling.
1818         * main.c: Use C++ exception handling.
1819         * linux-thread-db.c: Use C++ exception handling.
1820         * linux-tdep.c: Use C++ exception handling.
1821         * linux-nat.c: Use C++ exception handling.
1822         * linux-fork.c: Use C++ exception handling.
1823         * linespec.c: Use C++ exception handling.
1824         * language.c: Use C++ exception handling.
1825         * jit.c: Use C++ exception handling.
1826         * infrun.c: Use C++ exception handling.
1827         * infcmd.c: Use C++ exception handling.
1828         * infcall.c: Use C++ exception handling.
1829         * inf-loop.c: Use C++ exception handling.
1830         * i386-tdep.c: Use C++ exception handling.
1831         * i386-linux-tdep.c: Use C++ exception handling.
1832         * guile/scm-value.c: Use C++ exception handling.
1833         * guile/scm-type.c: Use C++ exception handling.
1834         * guile/scm-symtab.c: Use C++ exception handling.
1835         * guile/scm-symbol.c: Use C++ exception handling.
1836         * guile/scm-pretty-print.c: Use C++ exception handling.
1837         * guile/scm-ports.c: Use C++ exception handling.
1838         * guile/scm-param.c: Use C++ exception handling.
1839         * guile/scm-math.c: Use C++ exception handling.
1840         * guile/scm-lazy-string.c: Use C++ exception handling.
1841         * guile/scm-frame.c: Use C++ exception handling.
1842         * guile/scm-disasm.c: Use C++ exception handling.
1843         * guile/scm-cmd.c: Use C++ exception handling.
1844         * guile/scm-breakpoint.c: Use C++ exception handling.
1845         * guile/scm-block.c: Use C++ exception handling.
1846         * guile/guile-internal.h: Use C++ exception handling.
1847         * gnu-v3-abi.c: Use C++ exception handling.
1848         * gdbtypes.c: Use C++ exception handling.
1849         * frame.c: Use C++ exception handling.
1850         * frame-unwind.c: Use C++ exception handling.
1851         * fbsd-tdep.c: Use C++ exception handling.
1852         * f-valprint.c: Use C++ exception handling.
1853         * exec.c: Use C++ exception handling.
1854         * event-top.c: Use C++ exception handling.
1855         * event-loop.c: Use C++ exception handling.
1856         * eval.c: Use C++ exception handling.
1857         * dwarf2read.c: Use C++ exception handling.
1858         * dwarf2loc.c: Use C++ exception handling.
1859         * dwarf2-frame.c: Use C++ exception handling.
1860         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1861         * dwarf-index-write.c: Use C++ exception handling.
1862         * dwarf-index-cache.c: Use C++ exception handling.
1863         * dtrace-probe.c: Use C++ exception handling.
1864         * disasm-selftests.c: Use C++ exception handling.
1865         * darwin-nat.c: Use C++ exception handling.
1866         * cp-valprint.c: Use C++ exception handling.
1867         * cp-support.c: Use C++ exception handling.
1868         * cp-abi.c: Use C++ exception handling.
1869         * corelow.c: Use C++ exception handling.
1870         * completer.c: Use C++ exception handling.
1871         * compile/compile-object-run.c: Use C++ exception handling.
1872         * compile/compile-object-load.c: Use C++ exception handling.
1873         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1874         * compile/compile-c-symbols.c: Use C++ exception handling.
1875         * common/selftest.c: Use C++ exception handling.
1876         * common/new-op.c: Use C++ exception handling.
1877         * cli/cli-script.c: Use C++ exception handling.
1878         * cli/cli-interp.c: Use C++ exception handling.
1879         * cli/cli-cmds.c: Use C++ exception handling.
1880         * c-varobj.c: Use C++ exception handling.
1881         * btrace.c: Use C++ exception handling.
1882         * breakpoint.c: Use C++ exception handling.
1883         * break-catch-throw.c: Use C++ exception handling.
1884         * arch-utils.c: Use C++ exception handling.
1885         * amd64-tdep.c: Use C++ exception handling.
1886         * ada-valprint.c: Use C++ exception handling.
1887         * ada-typeprint.c: Use C++ exception handling.
1888         * ada-lang.c: Use C++ exception handling.
1889         * aarch64-tdep.c: Use C++ exception handling.
1890
1891 2019-04-08  Tom Tromey  <tom@tromey.com>
1892
1893         * xml-support.c (gdb_xml_parser::parse): Update.
1894         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1895         * value.c (show_convenience): Update.
1896         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1897         (test_parse_flags_qcs): Update.
1898         * thread.c (thr_try_catch_cmd): Update.
1899         * target.c (target_translate_tls_address): Update.
1900         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1901         (info_frame_command_core, frame_apply_command_count): Update.
1902         * rust-exp.y (rust_lex_exception_test): Update.
1903         * riscv-tdep.c (riscv_print_one_register_info): Update.
1904         * remote.c (remote_target::enable_btrace): Update.
1905         * record-btrace.c (record_btrace_enable_warn): Update.
1906         * python/py-utils.c (gdbpy_convert_exception): Update.
1907         * printcmd.c (do_one_display, print_variable_and_value): Update.
1908         * mi/mi-main.c (mi_print_exception): Update.
1909         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1910         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1911         * linux-nat.c (linux_nat_target::attach): Update.
1912         * linux-fork.c (class scoped_switch_fork_info): Update.
1913         * infrun.c (displaced_step_prepare): Update.
1914         * infcall.c (call_function_by_hand_dummy): Update.
1915         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1916         * gnu-v3-abi.c (print_one_vtable): Update.
1917         * frame.c (get_prev_frame_always): Update.
1918         * f-valprint.c (info_common_command_for_block): Update.
1919         * exec.c (try_open_exec_file): Update.
1920         * exceptions.c (print_exception, exception_print)
1921         (exception_fprintf, exception_print_same): Update.
1922         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1923         * dwarf-index-cache.c (index_cache::store)
1924         (index_cache::lookup_gdb_index): Update.
1925         * darwin-nat.c (maybe_cache_shell): Update.
1926         * cp-valprint.c (cp_print_value_fields): Update.
1927         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1928         (gcc_cplus_symbol_address): Update.
1929         * compile/compile-c-symbols.c (gcc_convert_symbol)
1930         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1931         * common/selftest.c: Update.
1932         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1933         a std::string.
1934         (exception_try_scope_entry, exception_try_scope_exit): Don't
1935         declare.
1936         (struct exception_try_scope): Remove.
1937         (TRY): Don't use exception_try_scope.
1938         (struct gdb_exception): Add constructor, operator=.
1939         <what>: New method.
1940         (struct gdb_exception_RETURN_MASK_ALL)
1941         (struct gdb_exception_RETURN_MASK_ERROR)
1942         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1943         (struct gdb_quit_bad_alloc): Update.
1944         * common/common-exceptions.c (exception_none): Change
1945         initializer.
1946         (struct catcher) <state, exception>: Initialize inline.
1947         <prev>: Remove member.
1948         (current_catcher): Remove.
1949         (catchers): New global.
1950         (exceptions_state_mc_init): Simplify.
1951         (catcher_pop): Remove.
1952         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1953         (try_scope_depth, exception_try_scope_entry)
1954         (exception_try_scope_exit): Remove.
1955         (throw_exception_sjlj): Update.
1956         (exception_messages, exception_messages_size): Remove.
1957         (throw_it): Simplify.
1958         (gdb_exception_sliced_copy): Remove.
1959         (throw_exception_cxx): Update.
1960         * cli/cli-script.c (script_from_file): Update.
1961         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1962         Update.
1963         * ada-valprint.c (ada_val_print): Update.
1964         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1965         (create_excep_cond_exprs): Update.
1966
1967 2019-04-08  Tom Tromey  <tom@tromey.com>
1968
1969         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1970         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1971         (TRY, CATCH, END_CATCH): Remove some definitions.
1972         * common/common-exceptions.c: Don't use GDB_XCPT.
1973         (catcher_list_size): Remove.
1974         (throw_exception, throw_it): Simplify.
1975
1976 2019-04-05  Tom Tromey  <tom@tromey.com>
1977
1978         Revert the header-sorting patch.
1979         * ft32-tdep.c: Revert.
1980         * frv-tdep.c: Revert.
1981         * frv-linux-tdep.c: Revert.
1982         * frame.c: Revert.
1983         * frame-unwind.c: Revert.
1984         * frame-base.c: Revert.
1985         * fork-child.c: Revert.
1986         * findvar.c: Revert.
1987         * findcmd.c: Revert.
1988         * filesystem.c: Revert.
1989         * filename-seen-cache.h: Revert.
1990         * filename-seen-cache.c: Revert.
1991         * fbsd-tdep.c: Revert.
1992         * fbsd-nat.h: Revert.
1993         * fbsd-nat.c: Revert.
1994         * f-valprint.c: Revert.
1995         * f-typeprint.c: Revert.
1996         * f-lang.c: Revert.
1997         * extension.h: Revert.
1998         * extension.c: Revert.
1999         * extension-priv.h: Revert.
2000         * expprint.c: Revert.
2001         * exec.h: Revert.
2002         * exec.c: Revert.
2003         * exceptions.c: Revert.
2004         * event-top.c: Revert.
2005         * event-loop.c: Revert.
2006         * eval.c: Revert.
2007         * elfread.c: Revert.
2008         * dwarf2read.h: Revert.
2009         * dwarf2read.c: Revert.
2010         * dwarf2loc.c: Revert.
2011         * dwarf2expr.h: Revert.
2012         * dwarf2expr.c: Revert.
2013         * dwarf2-frame.c: Revert.
2014         * dwarf2-frame-tailcall.c: Revert.
2015         * dwarf-index-write.h: Revert.
2016         * dwarf-index-write.c: Revert.
2017         * dwarf-index-common.c: Revert.
2018         * dwarf-index-cache.h: Revert.
2019         * dwarf-index-cache.c: Revert.
2020         * dummy-frame.c: Revert.
2021         * dtrace-probe.c: Revert.
2022         * disasm.h: Revert.
2023         * disasm.c: Revert.
2024         * disasm-selftests.c: Revert.
2025         * dictionary.c: Revert.
2026         * dicos-tdep.c: Revert.
2027         * demangle.c: Revert.
2028         * dcache.h: Revert.
2029         * dcache.c: Revert.
2030         * darwin-nat.h: Revert.
2031         * darwin-nat.c: Revert.
2032         * darwin-nat-info.c: Revert.
2033         * d-valprint.c: Revert.
2034         * d-namespace.c: Revert.
2035         * d-lang.c: Revert.
2036         * ctf.c: Revert.
2037         * csky-tdep.c: Revert.
2038         * csky-linux-tdep.c: Revert.
2039         * cris-tdep.c: Revert.
2040         * cris-linux-tdep.c: Revert.
2041         * cp-valprint.c: Revert.
2042         * cp-support.c: Revert.
2043         * cp-namespace.c: Revert.
2044         * cp-abi.c: Revert.
2045         * corelow.c: Revert.
2046         * corefile.c: Revert.
2047         * continuations.c: Revert.
2048         * completer.h: Revert.
2049         * completer.c: Revert.
2050         * complaints.c: Revert.
2051         * coffread.c: Revert.
2052         * coff-pe-read.c: Revert.
2053         * cli-out.h: Revert.
2054         * cli-out.c: Revert.
2055         * charset.c: Revert.
2056         * c-varobj.c: Revert.
2057         * c-valprint.c: Revert.
2058         * c-typeprint.c: Revert.
2059         * c-lang.c: Revert.
2060         * buildsym.c: Revert.
2061         * buildsym-legacy.c: Revert.
2062         * build-id.h: Revert.
2063         * build-id.c: Revert.
2064         * btrace.c: Revert.
2065         * bsd-uthread.c: Revert.
2066         * breakpoint.h: Revert.
2067         * breakpoint.c: Revert.
2068         * break-catch-throw.c: Revert.
2069         * break-catch-syscall.c: Revert.
2070         * break-catch-sig.c: Revert.
2071         * blockframe.c: Revert.
2072         * block.c: Revert.
2073         * bfin-tdep.c: Revert.
2074         * bfin-linux-tdep.c: Revert.
2075         * bfd-target.c: Revert.
2076         * bcache.c: Revert.
2077         * ax-general.c: Revert.
2078         * ax-gdb.h: Revert.
2079         * ax-gdb.c: Revert.
2080         * avr-tdep.c: Revert.
2081         * auxv.c: Revert.
2082         * auto-load.c: Revert.
2083         * arm-wince-tdep.c: Revert.
2084         * arm-tdep.c: Revert.
2085         * arm-symbian-tdep.c: Revert.
2086         * arm-pikeos-tdep.c: Revert.
2087         * arm-obsd-tdep.c: Revert.
2088         * arm-nbsd-tdep.c: Revert.
2089         * arm-nbsd-nat.c: Revert.
2090         * arm-linux-tdep.c: Revert.
2091         * arm-linux-nat.c: Revert.
2092         * arm-fbsd-tdep.c: Revert.
2093         * arm-fbsd-nat.c: Revert.
2094         * arm-bsd-tdep.c: Revert.
2095         * arch-utils.c: Revert.
2096         * arc-tdep.c: Revert.
2097         * arc-newlib-tdep.c: Revert.
2098         * annotate.h: Revert.
2099         * annotate.c: Revert.
2100         * amd64-windows-tdep.c: Revert.
2101         * amd64-windows-nat.c: Revert.
2102         * amd64-tdep.c: Revert.
2103         * amd64-sol2-tdep.c: Revert.
2104         * amd64-obsd-tdep.c: Revert.
2105         * amd64-obsd-nat.c: Revert.
2106         * amd64-nbsd-tdep.c: Revert.
2107         * amd64-nbsd-nat.c: Revert.
2108         * amd64-nat.c: Revert.
2109         * amd64-linux-tdep.c: Revert.
2110         * amd64-linux-nat.c: Revert.
2111         * amd64-fbsd-tdep.c: Revert.
2112         * amd64-fbsd-nat.c: Revert.
2113         * amd64-dicos-tdep.c: Revert.
2114         * amd64-darwin-tdep.c: Revert.
2115         * amd64-bsd-nat.c: Revert.
2116         * alpha-tdep.c: Revert.
2117         * alpha-obsd-tdep.c: Revert.
2118         * alpha-nbsd-tdep.c: Revert.
2119         * alpha-mdebug-tdep.c: Revert.
2120         * alpha-linux-tdep.c: Revert.
2121         * alpha-linux-nat.c: Revert.
2122         * alpha-bsd-tdep.c: Revert.
2123         * alpha-bsd-nat.c: Revert.
2124         * aix-thread.c: Revert.
2125         * agent.c: Revert.
2126         * addrmap.c: Revert.
2127         * ada-varobj.c: Revert.
2128         * ada-valprint.c: Revert.
2129         * ada-typeprint.c: Revert.
2130         * ada-tasks.c: Revert.
2131         * ada-lang.c: Revert.
2132         * aarch64-tdep.c: Revert.
2133         * aarch64-ravenscar-thread.c: Revert.
2134         * aarch64-newlib-tdep.c: Revert.
2135         * aarch64-linux-tdep.c: Revert.
2136         * aarch64-linux-nat.c: Revert.
2137         * aarch64-fbsd-tdep.c: Revert.
2138         * aarch64-fbsd-nat.c: Revert.
2139         * aarch32-linux-nat.c: Revert.
2140
2141 2019-04-05  Tom Tromey  <tom@tromey.com>
2142
2143         * ft32-tdep.c: Sort headers.
2144         * frv-tdep.c: Sort headers.
2145         * frv-linux-tdep.c: Sort headers.
2146         * frame.c: Sort headers.
2147         * frame-unwind.c: Sort headers.
2148         * frame-base.c: Sort headers.
2149         * fork-child.c: Sort headers.
2150         * findvar.c: Sort headers.
2151         * findcmd.c: Sort headers.
2152         * filesystem.c: Sort headers.
2153         * filename-seen-cache.h: Sort headers.
2154         * filename-seen-cache.c: Sort headers.
2155         * fbsd-tdep.c: Sort headers.
2156         * fbsd-nat.h: Sort headers.
2157         * fbsd-nat.c: Sort headers.
2158         * f-valprint.c: Sort headers.
2159         * f-typeprint.c: Sort headers.
2160         * f-lang.c: Sort headers.
2161         * extension.h: Sort headers.
2162         * extension.c: Sort headers.
2163         * extension-priv.h: Sort headers.
2164         * expprint.c: Sort headers.
2165         * exec.h: Sort headers.
2166         * exec.c: Sort headers.
2167         * exceptions.c: Sort headers.
2168         * event-top.c: Sort headers.
2169         * event-loop.c: Sort headers.
2170         * eval.c: Sort headers.
2171         * elfread.c: Sort headers.
2172         * dwarf2read.h: Sort headers.
2173         * dwarf2read.c: Sort headers.
2174         * dwarf2loc.c: Sort headers.
2175         * dwarf2expr.h: Sort headers.
2176         * dwarf2expr.c: Sort headers.
2177         * dwarf2-frame.c: Sort headers.
2178         * dwarf2-frame-tailcall.c: Sort headers.
2179         * dwarf-index-write.h: Sort headers.
2180         * dwarf-index-write.c: Sort headers.
2181         * dwarf-index-common.c: Sort headers.
2182         * dwarf-index-cache.h: Sort headers.
2183         * dwarf-index-cache.c: Sort headers.
2184         * dummy-frame.c: Sort headers.
2185         * dtrace-probe.c: Sort headers.
2186         * disasm.h: Sort headers.
2187         * disasm.c: Sort headers.
2188         * disasm-selftests.c: Sort headers.
2189         * dictionary.c: Sort headers.
2190         * dicos-tdep.c: Sort headers.
2191         * demangle.c: Sort headers.
2192         * dcache.h: Sort headers.
2193         * dcache.c: Sort headers.
2194         * darwin-nat.h: Sort headers.
2195         * darwin-nat.c: Sort headers.
2196         * darwin-nat-info.c: Sort headers.
2197         * d-valprint.c: Sort headers.
2198         * d-namespace.c: Sort headers.
2199         * d-lang.c: Sort headers.
2200         * ctf.c: Sort headers.
2201         * csky-tdep.c: Sort headers.
2202         * csky-linux-tdep.c: Sort headers.
2203         * cris-tdep.c: Sort headers.
2204         * cris-linux-tdep.c: Sort headers.
2205         * cp-valprint.c: Sort headers.
2206         * cp-support.c: Sort headers.
2207         * cp-namespace.c: Sort headers.
2208         * cp-abi.c: Sort headers.
2209         * corelow.c: Sort headers.
2210         * corefile.c: Sort headers.
2211         * continuations.c: Sort headers.
2212         * completer.h: Sort headers.
2213         * completer.c: Sort headers.
2214         * complaints.c: Sort headers.
2215         * coffread.c: Sort headers.
2216         * coff-pe-read.c: Sort headers.
2217         * cli-out.h: Sort headers.
2218         * cli-out.c: Sort headers.
2219         * charset.c: Sort headers.
2220         * c-varobj.c: Sort headers.
2221         * c-valprint.c: Sort headers.
2222         * c-typeprint.c: Sort headers.
2223         * c-lang.c: Sort headers.
2224         * buildsym.c: Sort headers.
2225         * buildsym-legacy.c: Sort headers.
2226         * build-id.h: Sort headers.
2227         * build-id.c: Sort headers.
2228         * btrace.c: Sort headers.
2229         * bsd-uthread.c: Sort headers.
2230         * breakpoint.h: Sort headers.
2231         * breakpoint.c: Sort headers.
2232         * break-catch-throw.c: Sort headers.
2233         * break-catch-syscall.c: Sort headers.
2234         * break-catch-sig.c: Sort headers.
2235         * blockframe.c: Sort headers.
2236         * block.c: Sort headers.
2237         * bfin-tdep.c: Sort headers.
2238         * bfin-linux-tdep.c: Sort headers.
2239         * bfd-target.c: Sort headers.
2240         * bcache.c: Sort headers.
2241         * ax-general.c: Sort headers.
2242         * ax-gdb.h: Sort headers.
2243         * ax-gdb.c: Sort headers.
2244         * avr-tdep.c: Sort headers.
2245         * auxv.c: Sort headers.
2246         * auto-load.c: Sort headers.
2247         * arm-wince-tdep.c: Sort headers.
2248         * arm-tdep.c: Sort headers.
2249         * arm-symbian-tdep.c: Sort headers.
2250         * arm-pikeos-tdep.c: Sort headers.
2251         * arm-obsd-tdep.c: Sort headers.
2252         * arm-nbsd-tdep.c: Sort headers.
2253         * arm-nbsd-nat.c: Sort headers.
2254         * arm-linux-tdep.c: Sort headers.
2255         * arm-linux-nat.c: Sort headers.
2256         * arm-fbsd-tdep.c: Sort headers.
2257         * arm-fbsd-nat.c: Sort headers.
2258         * arm-bsd-tdep.c: Sort headers.
2259         * arch-utils.c: Sort headers.
2260         * arc-tdep.c: Sort headers.
2261         * arc-newlib-tdep.c: Sort headers.
2262         * annotate.h: Sort headers.
2263         * annotate.c: Sort headers.
2264         * amd64-windows-tdep.c: Sort headers.
2265         * amd64-windows-nat.c: Sort headers.
2266         * amd64-tdep.c: Sort headers.
2267         * amd64-sol2-tdep.c: Sort headers.
2268         * amd64-obsd-tdep.c: Sort headers.
2269         * amd64-obsd-nat.c: Sort headers.
2270         * amd64-nbsd-tdep.c: Sort headers.
2271         * amd64-nbsd-nat.c: Sort headers.
2272         * amd64-nat.c: Sort headers.
2273         * amd64-linux-tdep.c: Sort headers.
2274         * amd64-linux-nat.c: Sort headers.
2275         * amd64-fbsd-tdep.c: Sort headers.
2276         * amd64-fbsd-nat.c: Sort headers.
2277         * amd64-dicos-tdep.c: Sort headers.
2278         * amd64-darwin-tdep.c: Sort headers.
2279         * amd64-bsd-nat.c: Sort headers.
2280         * alpha-tdep.c: Sort headers.
2281         * alpha-obsd-tdep.c: Sort headers.
2282         * alpha-nbsd-tdep.c: Sort headers.
2283         * alpha-mdebug-tdep.c: Sort headers.
2284         * alpha-linux-tdep.c: Sort headers.
2285         * alpha-linux-nat.c: Sort headers.
2286         * alpha-bsd-tdep.c: Sort headers.
2287         * alpha-bsd-nat.c: Sort headers.
2288         * aix-thread.c: Sort headers.
2289         * agent.c: Sort headers.
2290         * addrmap.c: Sort headers.
2291         * ada-varobj.c: Sort headers.
2292         * ada-valprint.c: Sort headers.
2293         * ada-typeprint.c: Sort headers.
2294         * ada-tasks.c: Sort headers.
2295         * ada-lang.c: Sort headers.
2296         * aarch64-tdep.c: Sort headers.
2297         * aarch64-ravenscar-thread.c: Sort headers.
2298         * aarch64-newlib-tdep.c: Sort headers.
2299         * aarch64-linux-tdep.c: Sort headers.
2300         * aarch64-linux-nat.c: Sort headers.
2301         * aarch64-fbsd-tdep.c: Sort headers.
2302         * aarch64-fbsd-nat.c: Sort headers.
2303         * aarch32-linux-nat.c: Sort headers.
2304
2305 2019-04-04  Tom Tromey  <tom@tromey.com>
2306
2307         * varobj.c (varobj_create): Update.
2308         * rust-exp.y (struct rust_parser) <update_innermost_block,
2309         lookup_symbol>: New methods.
2310         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2311         Rename.
2312         (rust_parser::rust_lookup_type)
2313         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2314         * printcmd.c (display_command, do_one_display): Update.
2315         * parser-defs.h (struct parser_state) <parser_state>: Add
2316         "tracker" parameter.
2317         (block_tracker): New member.
2318         (class innermost_block_tracker) <innermost_block_tracker>: Add
2319         "types" parameter.
2320         <reset>: Remove method.
2321         (innermost_block): Don't declare.
2322         (null_post_parser): Update.
2323         * parse.c (innermost_block): Remove global.
2324         (write_dollar_variable): Update.
2325         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2326         Remove "tracker_types" parameter.
2327         (parse_expression): Add "tracker" parameter.
2328         (parse_expression_for_completion): Update.
2329         (null_post_parser): Add "tracker" parameter.
2330         * p-exp.y: Update rules.
2331         * m2-exp.y: Update rules.
2332         * language.h (struct language_defn) <la_post_parser>: Add
2333         "tracker" parameter.
2334         * go-exp.y: Update rules.
2335         * f-exp.y: Update rules.
2336         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2337         parameter.
2338         * d-exp.y: Update rules.
2339         * c-exp.y: Update rules.
2340         * breakpoint.c (set_breakpoint_condition): Create an
2341         innermost_block_tracker.
2342         (watch_command_1): Likewise.
2343         * ada-lang.c (resolve): Add "tracker" parameter.
2344         (resolve_subexp): Likewise.
2345         * ada-exp.y (write_var_from_sym): Update.
2346
2347 2019-04-04  Tom Tromey  <tom@tromey.com>
2348
2349         * type-stack.h: New file.
2350         * type-stack.c: New file.
2351         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2352         type-stack.h.
2353         (insert_into_type_stack, insert_type, push_type, push_type_int)
2354         (insert_type_address_space, pop_type, pop_type_int)
2355         (pop_typelist, pop_type_stack, append_type_stack)
2356         (push_type_stack, get_type_stack, push_typelist)
2357         (follow_type_instance_flags, follow_types): Don't declare.
2358         * parse.c (type_stack): Remove global.
2359         (parse_exp_in_context): Update.
2360         (insert_into_type_stack, insert_type, push_type, push_type_int)
2361         (insert_type_address_space, pop_type, pop_type_int)
2362         (pop_typelist, pop_type_stack, append_type_stack)
2363         (push_type_stack, get_type_stack, push_typelist)
2364         (follow_type_instance_flags, follow_types): Remove (moved to
2365         type-stack.c).
2366         * f-exp.y (type_stack): New global.
2367         Update rules.
2368         (push_kind_type, f_parse): Update.
2369         * d-exp.y (type_stack): New global.
2370         Update rules.
2371         (d_parse): Update.
2372         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2373         Update rules.
2374         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2375         (HFILES_NO_SRCDIR): Add type-stack.h.
2376
2377 2019-04-04  Tom Tromey  <tom@tromey.com>
2378
2379         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2380         (rust_parser::convert_ast_to_expression, rust_parse)
2381         (rust_lex_test_completion, rust_lex_tests): Update.
2382         * parser-defs.h (struct expr_completion_state): New.
2383         (struct parser_state) <parser_state>: Add completion parameter.
2384         <mark_struct_expression, mark_completion_tag>: New methods.
2385         <parse_completion, m_completion_state>: New members.
2386         (prefixify_expression, null_post_parser): Update.
2387         (mark_struct_expression, mark_completion_tag): Don't declare.
2388         * parse.c (parse_completion, expout_last_struct)
2389         (expout_tag_completion_type, expout_completion_name): Remove
2390         globals.
2391         (parser_state::mark_struct_expression)
2392         (parser_state::mark_completion_tag): Now methods.
2393         (prefixify_expression): Add last_struct parameter.
2394         (prefixify_subexp): Likewise.
2395         (parse_exp_1): Update.
2396         (parse_exp_in_context): Add cstate parameter.  Update.
2397         (parse_expression_for_completion): Create an
2398         expr_completion_state.
2399         (null_post_parser): Add "completion" parameter.
2400         * p-exp.y: Update rules.
2401         (yylex): Update.
2402         * language.h (struct language_defn) <la_post_parser>: Add
2403         "completing" parameter.
2404         * go-exp.y: Update rules.
2405         (lex_one_token): Update.
2406         * expression.h (parse_completion): Don't declare.
2407         * d-exp.y: Update rules.
2408         (lex_one_token): Update rules.
2409         * c-exp.y: Update rules.
2410         (lex_one_token): Update.
2411         * ada-lang.c (resolve): Add "parse_completion" parameter.
2412         (resolve_subexp): Likewise.
2413         (ada_resolve_function): Likewise.
2414
2415 2019-04-04  Tom Tromey  <tom@tromey.com>
2416
2417         * parser-defs.h (struct parser_state) <start_arglist,
2418         end_arglist>: New methods.
2419         <arglist_len, m_funcall_chain>: New members.
2420         (arglist_len, start_arglist, end_arglist): Don't declare.
2421         * parse.c (arglist_len, funcall_chain): Remove global.
2422         (start_arglist, end_arglist): Remove functions.
2423         (parse_exp_in_context): Update.
2424         * p-exp.y: Update rules.
2425         * m2-exp.y: Update rules.
2426         * go-exp.y: Update rules.
2427         * f-exp.y: Update rules.
2428         * d-exp.y: Update rules.
2429         * c-exp.y: Update rules.
2430
2431 2019-04-04  Tom Tromey  <tom@tromey.com>
2432
2433         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2434         lex_operator, push_back>: New methods.
2435         Update all rules.
2436         (rust_parser::lex_hex, lex_escape): Rename and update.
2437         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2438         (rust_parser::lex_operator): Rename and update.
2439         (rust_parser::lex_number, rustyylex, rustyyerror)
2440         (rust_lex_test_init, rust_lex_test_sequence)
2441         (rust_lex_test_push_back, rust_lex_tests): Update.
2442         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2443         parameter.
2444         <lexptr, prev_lexptr>: New members.
2445         (lexptr, prev_lexptr): Don't declare.
2446         * parse.c (lexptr, prev_lexptr): Remove globals.
2447         (parse_exp_in_context): Update.
2448         * p-exp.y (yylex, yyerror): Update.
2449         * m2-exp.y (parse_number, yylex, yyerror): Update.
2450         * go-exp.y (lex_one_token, yyerror): Update.
2451         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2452         * d-exp.y (lex_one_token, yyerror): Update.
2453         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2454         (lex_one_token, yyerror): Update.
2455         * ada-lex.l (YY_INPUT): Update.
2456         (rewind_to_char): Update.
2457         * ada-exp.y (yyerror): Update.
2458
2459 2019-04-04  Tom Tromey  <tom@tromey.com>
2460
2461         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2462         * parser-defs.h (struct parser_state) <parser_state>: Add new
2463         parameter.
2464         <comma_terminates>: New member.
2465         (comma_terminates): Don't declare global.
2466         * parse.c (comma_terminates): Remove global.
2467         (parse_exp_in_context): Update.
2468         * p-exp.y (yylex): Update.
2469         * m2-exp.y (yylex): Update.
2470         * go-exp.y (lex_one_token): Update.
2471         * f-exp.y (yylex): Update.
2472         * d-exp.y (lex_one_token): Update.
2473         * c-exp.y (lex_one_token): Update.
2474         * ada-lex.l: Update.
2475
2476 2019-04-04  Tom Tromey  <tom@tromey.com>
2477
2478         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2479         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2480         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2481         * parser-defs.h (paren_depth): Don't declare.
2482         * parse.c (paren_depth): Remove global.
2483         (parse_exp_in_context): Update.
2484         * p-exp.y (paren_depth): New global.
2485         (pascal_parse): Initialize it.
2486         * m2-exp.y (paren_depth): New global.
2487         (m2_parse): Initialize it.
2488         * go-exp.y (paren_depth): New global.
2489         (go_parse): Initialize it.
2490         * f-exp.y (paren_depth): New global.
2491         (f_parse): Initialize it.
2492         * d-exp.y (paren_depth): New global.
2493         (d_parse): Initialize it.
2494         * c-exp.y (paren_depth): New global.
2495         (c_parse): Initialize it.
2496         * ada-lex.l (paren_depth): New global.
2497         (lexer_init): Initialize it.
2498
2499 2019-04-04  Tom Tromey  <tom@tromey.com>
2500
2501         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2502         (rust_parser::convert_ast_to_type)
2503         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2504         * parser-defs.h (struct parser_state) <parser_state>: Add
2505         parameters.  Initialize new members.
2506         <expression_context_block, expression_context_pc>: New members.
2507         * parse.c (expression_context_block, expression_context_pc):
2508         Remove globals.
2509         (parse_exp_in_context): Update.
2510         * p-exp.y: Update all rules.
2511         (yylex): Update.
2512         * m2-exp.y: Update all rules.
2513         (yylex): Update.
2514         * go-exp.y (yylex): Update.
2515         * f-exp.y (yylex): Update.
2516         * d-exp.y: Update all rules.
2517         (yylex): Update.
2518         * c-exp.y: Update all rules.
2519         (lex_one_token, classify_name, yylex, c_parse): Update.
2520         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2521
2522 2019-04-04  Tom Tromey  <tom@tromey.com>
2523
2524         * gdbarch.h, gdbarch.c: Rebuild.
2525         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2526         * stap-probe.h:
2527         (struct stap_parse_info): Replace "parser_state" with
2528         "expr_builder".
2529         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2530         (parser_state): New class.
2531         * parse.c (expr_builder): Rename.
2532         (expr_builder::release): Rename.
2533         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2534         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2535         (write_exp_elt_longcst, write_exp_elt_floatcst)
2536         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2537         (write_exp_string_vector, write_exp_bitstring)
2538         (write_exp_msymbol, mark_struct_expression)
2539         (write_dollar_variable)
2540         (insert_type_address_space, increase_expout_size): Replace
2541         "parser_state" with "expr_builder".
2542         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2543         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2544         "parser_state" with "expr_builder".
2545
2546 2019-04-04  Tom Tromey  <tom@tromey.com>
2547
2548         * rust-exp.y: Replace "parse_language" with method call.
2549         * p-exp.y:
2550         (yylex): Replace "parse_language" with method call.
2551         * m2-exp.y:
2552         (yylex): Replace "parse_language" with method call.
2553         * go-exp.y (classify_name): Replace "parse_language" with method
2554         call.
2555         * f-exp.y (yylex): Replace "parse_language" with method call.
2556         * d-exp.y (lex_one_token): Replace "parse_language" with method
2557         call.
2558         * c-exp.y:
2559         (lex_one_token, classify_name, yylex): Replace "parse_language"
2560         with method call.
2561         * ada-exp.y (find_primitive_type, type_char)
2562         (type_system_address): Replace "parse_language" with method call.
2563
2564 2019-04-04  Tom Tromey  <tom@tromey.com>
2565
2566         * rust-exp.y: Replace "parse_gdbarch" with method call.
2567         * parse.c (write_dollar_variable, insert_type_address_space):
2568         Replace "parse_gdbarch" with method call.
2569         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2570         call.
2571         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2572         call.
2573         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2574         "parse_gdbarch" with method call.
2575         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2576         with method call.
2577         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2578         "parse_gdbarch" with method call.
2579         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2580         "parse_gdbarch" with method call.
2581         * c-exp.y (parse_type, parse_number, classify_name): Replace
2582         "parse_gdbarch" with method call.
2583         * ada-lex.l: Replace "parse_gdbarch" with method call.
2584         * ada-exp.y (parse_type, find_primitive_type, type_char)
2585         (type_system_address): Replace "parse_gdbarch" with method call.
2586
2587 2019-04-04  Tom Tromey  <tom@tromey.com>
2588
2589         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2590         * stap-probe.c (stap_parse_argument): Update.
2591         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2592         initial_size parameter.
2593         * rust-exp.y (rust_lex_tests): Update.
2594         * parse.c (parser_state): Update.
2595         (parse_exp_in_context): Update.
2596         * parser-defs.h (struct parser_state) <parser_state>: Remove
2597         "initial_size" parameter.
2598
2599 2019-04-04  Tom Tromey  <tom@tromey.com>
2600
2601         * parser-defs.h (increase_expout_size): Don't declare.
2602         * parse.c (increase_expout_size): Now static.
2603
2604 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2605
2606         * gnu-nat.c (gnu_nat_target::wait): Fix
2607         target_waitstatus_to_string call.
2608
2609 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2610
2611         * eval.c (evaluate_subexp_standard): Handle internal functions
2612         during Fortran function call handling.
2613
2614 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2615
2616         * NEWS: Mention new internal functions.
2617         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2618         (read_base_type): Use dwarf2_init_complex_target_type.
2619         * value.c (creal_internal_fn): New function.
2620         (cimag_internal_fn): New function.
2621         (_initialize_values): Register new internal functions.
2622
2623 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2624
2625         * infrun.c (stop_all_threads): If debug_infrun, always
2626         trace the wait status after wait_one, using
2627         target_waitstatus_to_string and target_pid_to_str.
2628         (handle_inferior_event): Replace various trace of
2629         wait status kind by a single trace.
2630         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2631         wait status kind image by target_waitstatus_to_string.
2632         * target/waitstatus.c (target_waitstatus_to_string): Fix
2633         obsolete comment.
2634
2635 2019-04-01  Tom Tromey  <tromey@adacore.com>
2636
2637         PR symtab/23331:
2638         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2639
2640 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2641             Pedro Alves  <palves@redhat.com>
2642
2643         * top.c (quit_force): Call 'finalize_values'.
2644         * value.c (finalize_values): New function.
2645         * value.h (finalize_values): Declare.
2646
2647 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2648
2649         * NEWS: Announce $_gdb_major and $_gdb_minor.
2650
2651         * top.c (init_gdb_version_vars): New function.
2652         (gdb_init): Call init_gdb_version_vars.
2653
2654 2019-03-29  Tom Tromey  <tromey@adacore.com>
2655
2656         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2657         help text.  Remove dead code.
2658
2659 2019-03-29  Keith Seitz  <keiths@redhat.com>
2660
2661         From Siddhesh Poyarekar:
2662         * f-lang.h (f77_get_upperbound): Return LONGEST.
2663         (f77_get_lowerbound): Likewise.
2664         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2665         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2666         print them.
2667         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2668         plongest to format print it.
2669         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2670         (f77_get_upperbound): Likewise.
2671         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2672         LOWER_BOUND to LONGEST.
2673         (f77_create_arrayprint_offset_tbl): Likewise.
2674
2675 2019-03-29  Keith Seitz  <keiths@redhat.com>
2676
2677         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2678         %s/pulongest for TYPE_LENGTH instead of %d in format
2679         strings.
2680         * ada-typerint.c (ada_print_type): Likewise.
2681         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2682         * compile/compile-c-support.c (generate_register_struct): Likewise.
2683         * gdbtypes.c (recursive_dump_type): Likewise.
2684         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2685         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2686         instead of %d in format strings.
2687         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2688         to std::min to ULONGEST.
2689         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2690         instead of %d in format strings.
2691         * tracepoint.c (info_scope_command): Likewise.
2692         * typeprint.c (print_offset_data::update)
2693         (print_offset_data::finish): Likewise.
2694         * xtensa-tdep.c (xtensa_store_return_value)
2695         (xtensa_push_dummy_call): Likewise.
2696
2697 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2698
2699         * windows-nat.c (display_selector): Fixed format specifications
2700         for 64-bit Cygwin.
2701
2702 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2703
2704         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2705
2706 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2707
2708         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2709         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2710         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2711         (nios2_linux_init_abi): Install it.
2712
2713 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2714
2715         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2716
2717 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2718
2719         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2720
2721 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2722             Tom Tromey  <tromey@adacore.com>
2723
2724         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2725
2726 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2727
2728         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2729         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2730         method to compute the bounds of range types. Also print "[evaluated]"
2731         if the bounds' values come from a dynamic evaluation.
2732
2733 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2734
2735         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2736         whitespace when pretty printing is on.
2737
2738 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2739
2740         * ppc-linux-nat.c: Add include.
2741
2742 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2743
2744         * NEWS: Mention AArch64 Pointer Authentication.
2745
2746 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2747
2748         * arm-linux-nat.c: Add include.
2749
2750 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2751
2752         * source-cache.c (source_cache::get_source_lines): Re-read
2753         fullname after calling open_source_file.
2754
2755 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2756
2757         * NEWS: Mention TLS support for FreeBSD.
2758
2759 2019-03-25  Tom Tromey  <tromey@adacore.com>
2760
2761         * minsyms.c (BUNCH_SIZE): Update comment.
2762         (~minimal_symbol_reader): Remove old comment.
2763         (compact_minimal_symbols): Update comment.
2764         (minimal_symbol_reader::install): Remove old comment.  Update
2765         other comments.
2766
2767 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2768
2769         * s390-linux-nat.c: Add include.
2770
2771 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2772
2773         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2774         Call linux_get_hwcap.
2775         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2776         Likewise.
2777         (aarch64_linux_get_hwcap): Remove function.
2778         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2779         declaration.
2780         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2781         linux_get_hwcap.
2782         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2783         * linux-tdep.c (linux_get_hwcap): Add function.
2784         (linux_get_hwcap2): Likewise.
2785         * linux-tdep.h (linux_get_hwcap): Add declaration.
2786         (linux_get_hwcap2): Likewise.
2787         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2788         (ppc_linux_get_hwcap2): Likewise.
2789         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2790         linux_get_hwcap.
2791         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2792         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2793         (ppc_linux_nat_target::read_description): Likewise.
2794         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2795         * s390-linux-nat.c: Likewise.
2796         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2797
2798 2019-03-24  Tom Tromey  <tom@tromey.com>
2799
2800         * ada-lang.c (standard_lookup): Simplify initialization.
2801         (ada_lookup_symbol_nonlocal): Simplify return.
2802         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2803         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2804         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2805         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2806         initialization.
2807         * solib.c (solib_global_lookup): Simplify.
2808         * symtab.c (null_block_symbol): Remove.
2809         (symbol_cache_lookup): Simplify returns.
2810         (lookup_language_this): Simplify returns.
2811         (lookup_symbol_aux): Simplify return.
2812         (lookup_local_symbol): Simplify returns.
2813         (lookup_global_symbol_from_objfile): Simplify return.
2814         (lookup_symbol_in_objfile_symtabs)
2815         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2816         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2817         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2818         * cp-namespace.c (cp_lookup_bare_symbol)
2819         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2820         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2821         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2822         (cp_lookup_symbol_via_imports): Simplify initialization.
2823         (find_symbol_in_baseclass): Likewise.
2824         * symtab.h (null_block_symbol): Remove.
2825         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2826         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2827         (d_lookup_symbol_module): Likewise.
2828         (find_symbol_in_baseclass): Simplify initialization.
2829
2830 2019-03-24  Tom Tromey  <tom@tromey.com>
2831
2832         * expression.h: Don't include symtab.h.
2833         (struct block): Forward declare.
2834
2835 2019-03-24  Tom Tromey  <tom@tromey.com>
2836
2837         * c-exp.y (typebase): Remove casts.
2838         * gdbtypes.c (lookup_unsigned_typename, )
2839         (lookup_signed_typename): Remove cast.
2840         * eval.c (parse_to_comma_and_eval): Remove cast.
2841         * parse.c (write_dollar_variable): Remove cast.
2842         * block.h (struct block) <superblock>: Now const.
2843         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2844         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2845         (map_block): Make "block" const.
2846         * symfile.h (struct quick_symbol_functions)
2847         <map_matching_symbols>: Constify block argument to "callback".
2848         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2849         const.
2850         (find_pc_sect_compunit_symtab): Make "b" const.
2851         (find_symbol_at_address): Likewise.
2852         (search_symbols): Likewise.
2853         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2854         (dw2_debug_names_lookup_symbol): Likewise.
2855         (dw2_map_matching_symbols): Update.
2856         * p-valprint.c (pascal_val_print): Remove "block".
2857         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2858         (aux_add_nonlocal_symbols): Make "block" const.
2859         (resolve_subexp): Remove cast.
2860         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2861         const.
2862         (iterate_over_file_blocks): Likewise.
2863         * f-exp.y (%union) <bval>: Remove.
2864         * coffread.c (patch_opaque_types): Make "b" const.
2865         * spu-tdep.c (spu_catch_start): Make "block" const.
2866         * c-valprint.c (print_unpacked_pointer): Remove "block".
2867         * symmisc.c (dump_symtab_1): Make "b" const.
2868         (block_depth): Make "block" const.
2869         * d-exp.y (%union) <bval>: Remove.
2870         * cp-support.h (cp_lookup_rtti_type): Update.
2871         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2872         * psymtab.c (psym_lookup_symbol): Make "block" const.
2873         (maintenance_check_psymtabs): Make "b" const.
2874         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2875         (enumerate_locals, enumerate_args): Update.
2876         * python/py-symtab.c (stpy_global_block): Make "block" const.
2877         (stpy_static_block): Likewise.
2878         * inline-frame.c (block_starting_point_at): Make "new_block"
2879         const.
2880         * block.c (find_block_in_blockvector): Make return type const.
2881         (blockvector_for_pc_sect): Make "b" const.
2882         (find_block_in_blockvector): Make "b" const.
2883
2884 2019-03-23  Tom Tromey  <tom@tromey.com>
2885
2886         * varobj.c (varobj_create): Update.
2887         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2888         * printcmd.c (display_command, do_one_display): Don't reset
2889         innermost_block.
2890         * parser-defs.h (enum innermost_block_tracker_type): Move to
2891         expression.h.
2892         (innermost_block): Update comment.
2893         * parse.c (parse_exp_1): Add tracker_types parameter.
2894         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2895         tracker_types parameter.  Reset innermost_block.
2896         (parse_exp_in_context): Remove.
2897         (parse_expression_for_completion): Update.
2898         * objfiles.c (~objfile): Don't reset expression_context_block or
2899         innermost_block.
2900         * expression.h (enum innermost_block_tracker_type): Move from
2901         parser-defs.h.
2902         (parse_exp_1): Add tracker_types parameter.
2903         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2904         reset innermost_block.
2905
2906 2019-03-23  Tom Tromey  <tom@tromey.com>
2907
2908         * objfiles.h: Include bcache.h.
2909
2910 2019-03-23  Tom Tromey  <tom@tromey.com>
2911
2912         * linespec.c (get_current_search_block): Use
2913         scoped_restore_current_language.
2914         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2915
2916 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2917             Jiong Wang  <jiong.wang@arm.com>
2918
2919         * aarch64-linux-tdep.c
2920         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2921         section.
2922         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2923
2924 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2925             Jiong Wang  <jiong.wang@arm.com>
2926
2927         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2928         instructions.
2929         (aarch64_analyze_prologue_test): Add PACIASP test.
2930         (aarch64_prologue_prev_register): Unmask PC value.
2931
2932 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2933             Jiong Wang  <jiong.wang@arm.com>
2934
2935         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2936         (aarch64_dwarf2_prev_register): Unmask PC value.
2937         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2938         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2939         DW_CFA_AARCH64_negate_ra_state.
2940         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2941
2942 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2943             Jiong Wang  <jiong.wang@arm.com>
2944
2945         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2946         registers.
2947         (aarch64_pseudo_register_name): Likewise.
2948         (aarch64_pseudo_register_type): Likewise.
2949         (aarch64_pseudo_register_reggroup_p): Likewise.
2950         (aarch64_gdbarch_init): Add pauth registers.
2951         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2952         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2953         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2954         (struct gdbarch_tdep): Add regnum for ra_state.
2955
2956 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2957             Jiong Wang  <jiong.wang@arm.com>
2958
2959         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2960
2961 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2962             Jiong Wang  <jiong.wang@arm.com>
2963
2964         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2965         function.
2966         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2967         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2968         (aarch64_gdbarch_init): Add puth registers.
2969         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2970         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2971         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2972
2973 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2974             Jiong Wang  <jiong.wang@arm.com>
2975
2976         * aarch64-linux-nat.c
2977         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2978         * aarch64-linux-tdep.c
2979         (aarch64_linux_core_read_description): Likewise.
2980         (aarch64_linux_get_hwcap): New function.
2981         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2982         (aarch64_linux_get_hwcap): New declaration.
2983
2984 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2985             Jiong Wang  <jiong.wang@arm.com>
2986
2987         * aarch64-linux-nat.c
2988         (aarch64_linux_nat_target::read_description): Add pauth param.
2989         * aarch64-linux-tdep.c
2990         (aarch64_linux_core_read_description): Likewise.
2991         * aarch64-tdep.c (struct target_desc): Add in pauth.
2992         (aarch64_read_description): Add pauth param.
2993         (aarch64_gdbarch_init): Likewise.
2994         * aarch64-tdep.h (aarch64_read_description): Likewise.
2995         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2996         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2997         * features/Makefile: Add new files.
2998         * features/aarch64-pauth.c: New file.
2999         * features/aarch64-pauth.xml: New file.
3000
3001 2019-03-20  Tom Tromey  <tromey@adacore.com>
3002
3003         * infrun.c (handle_inferior_event): Rename from
3004         handle_inferior_event_1.  Create a scoped_value_mark.
3005         (handle_inferior_event): Remove.
3006
3007 2019-03-19  Tom Tromey  <tromey@adacore.com>
3008
3009         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3010         * infrun.h (print_stop_event): Add "displays" parameter.
3011         * infrun.c (print_stop_event): Add "displays" parameter.
3012
3013 2019-03-19  Pedro Alves  <palves@redhat.com>
3014
3015         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3016         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3017         to -1.  Fix TABs vs spaces.
3018         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3019         * tui/tui-out.h (tui_ui_out) Add intro comments.
3020         <m_line, m_start_of_line>: In-class initialize, and add describing
3021         comment.
3022
3023 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3024
3025         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3026         variable names.
3027         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3028
3029 2019-03-18  Pedro Alves  <palves@redhat.com>
3030             Eli Zaretskii <eliz@gnu.org>
3031
3032         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3033         m_line and m_start_of_line.
3034
3035 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3036
3037         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3038         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3039         it returns a newline.  This fixes a regression in TU mode, whereby
3040         the next line is output on the same screen line as the user input.
3041
3042 2019-03-18  Tom Tromey  <tromey@adacore.com>
3043
3044         * minsyms.c (minimal_symbol_reader::install): Remove call to
3045         obstack_blank.
3046
3047 2019-03-18  Pedro Alves  <palves@redhat.com>
3048
3049         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3050         New globals.
3051         (apply_style): New, factored out from ...
3052         (apply_ansi_escape): ... this.  Handle reverse video mode.
3053         (tui_set_reverse_mode): New function.
3054         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3055         * tui/tui-winsource.c (tui_show_source_line): Use
3056         tui_set_reverse_mode instead of setting A_STANDOUT.
3057         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3058         New setter methods.
3059
3060 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3061
3062         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3063         Handle tabs.
3064
3065 2019-03-18  Tom Tromey  <tromey@adacore.com>
3066
3067         * ada-lang.c (empty_array): Add "high" parameter.
3068         (ada_evaluate_subexp): Update.
3069
3070 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3071
3072         * unittests/string_view-selftests.c: Define
3073         _initialize_string_view_selftests unconditionally.
3074
3075 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3076
3077         PR gdb/24350
3078         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3079
3080 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3081
3082         PR gdb/24351
3083         * windows-nat.c (display_selector): Fix format specifiers.
3084
3085 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3086
3087         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3088         tui_refill_source_window instead of tui_refresh_win, to update the
3089         current execution line.  This fixes redisplay of the current line
3090         when stepping through the code with "next" or "step".
3091
3092 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3093
3094         * source-cache.c (source_cache::get_source_lines): Call
3095         find_source_lines to initialize s->nlines.  This fixes vertical
3096         scrolling of TUI source window when the DOWN arrow is pressed.
3097
3098 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3099
3100         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3101         linux-thread-db.c (_initialize_thread_db): Likewise.
3102
3103 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3104
3105         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3106         wclrtoeol in tui_show_source_line".  This reverts changes made in
3107         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3108
3109 2019-03-15  Tom Tromey  <tom@tromey.com>
3110
3111         * symtab.h (struct minimal_symbol): Derive from
3112         general_symbol_info.
3113         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3114         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3115         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3116         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3117         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3118         (MSYMBOL_SEARCH_NAME): Update.
3119         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3120         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3121         * minsyms.c (minimal_symbol_reader::record_full): Update.
3122
3123 2019-03-15  Tom Tromey  <tom@tromey.com>
3124
3125         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3126
3127 2019-03-15  Tom Tromey  <tom@tromey.com>
3128
3129         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3130         unique_xmalloc_ptr.
3131         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3132         Update.
3133         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3134         (build_minimal_symbol_hash_tables)
3135         (minimal_symbol_reader::install): Update.
3136
3137 2019-03-15  Tom Tromey  <tom@tromey.com>
3138
3139         * symtab.c (create_demangled_names_hash): Update.
3140         (symbol_set_names): Update.
3141         * objfiles.h (struct objfile_per_bfd_storage)
3142         <demangled_names_hash>: Now an htab_up.
3143         * objfiles.c (objfile_per_bfd_storage): Simplify.
3144
3145 2019-03-15  Tom Tromey  <tom@tromey.com>
3146
3147         * objfiles.h (struct objfile_per_bfd_storage): Declare
3148         destructor.
3149         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3150         New.
3151         (get_objfile_bfd_data): Use new.  Don't initialize
3152         language_of_main.
3153         (free_objfile_per_bfd_storage): Remove.
3154         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3155
3156 2019-03-15  Tom Tromey  <tom@tromey.com>
3157
3158         * symfile.c (reread_symbols): Update.
3159         * objfiles.c (objfile::objfile): Update.
3160         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3161         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3162         comment.
3163         (minimal_symbol_reader::install): Update.
3164         (terminate_minimal_symbol_table): Remove.
3165         * jit.c (jit_object_close_impl): Update.
3166
3167 2019-03-15  Tom Tromey  <tom@tromey.com>
3168
3169         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3170         initializations.
3171
3172 2019-03-15  Tom Tromey  <tom@tromey.com>
3173
3174         * objfiles.h (struct objfile_per_bfd_storage)
3175         <demangled_hash_languages>: Now a bitset.
3176         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3177         (lookup_minimal_symbol): Update.
3178
3179 2019-03-15  Tom Tromey  <tom@tromey.com>
3180
3181         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3182         Don't return the symbol.
3183         * coffread.c (record_minimal_symbol): Use record_full.
3184
3185 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3186
3187         The MS-Windows port of ncurses fails to switch to a color pair if
3188         one or both of the colors are the implicit default colors.  This
3189         change records the default colors when TUI is initialized, and
3190         then specifies them explicitly when a color pair uses the default
3191         colors.  This allows color styling in TUI mode on MS-Windows.
3192
3193         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3194         ncurses_norm_attr.
3195         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3196         colors in ncurses_norm_attr.
3197         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3198         "none", replace it with the default color recorded in
3199         ncurses_norm_attr.
3200
3201 2019-03-14  Tom Tromey  <tromey@adacore.com>
3202
3203         * source-cache.h (class source_cache) <get_source_lines>: Return
3204         std::string.
3205         * source-cache.c (source_cache::extract_lines): Handle case where
3206         first_pos==npos.  Return std::string.
3207         (source_cache::get_source_lines): Update.
3208
3209 2019-03-14  Tom Tromey  <tromey@adacore.com>
3210
3211         * NEWS: Add item for "style sources" commands.
3212         * source-cache.c (source_cache::get_source_lines): Check
3213         source_styling.
3214         * cli/cli-style.c (source_styling): New global.
3215         (_initialize_cli_style): Add "style sources" commands.
3216         (show_style_sources): New function.
3217         * cli/cli-style.h (source_styling): Declare.
3218
3219 2019-03-14  Pedro Alves  <palves@redhat.com>
3220             Tom Tromey  <tromey@adacore.com>
3221
3222         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3223         * tui/tui-winsource.c (tui_refill_source_window): New function,
3224         from...
3225         (tui_horizontal_source_scroll): ... here.  Move some logic.
3226         * cli/cli-style.c (set_style_enabled): Notify new observable.
3227         * tui/tui-hooks.c (tui_redisplay_source): New function.
3228         (tui_attach_detach_observers): Attach or detach
3229         tui_redisplay_source.
3230         * observable.h (source_styling_changed): New observable.
3231         * observable.c: Define source_styling_changed observable.
3232
3233 2019-03-13  Tom Tromey  <tromey@adacore.com>
3234
3235         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3236         (i386_gnu_nat_target::store_registers): Update.
3237         * target-debug.h (target_debug_print_std_string): New macro.
3238         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3239         * windows-tdep.c (display_one_tib): Update.
3240         * tui/tui-stack.c (tui_make_status_line): Update.
3241         * top.c (print_inferior_quit_action): Update.
3242         * thread.c (thr_try_catch_cmd): Update.
3243         (add_thread_with_info): Update.
3244         (thread_target_id_str): Update.
3245         (thr_try_catch_cmd): Update.
3246         (thread_command): Update.
3247         (thread_find_command): Update.
3248         * record-btrace.c (record_btrace_target::info_record)
3249         (record_btrace_resume_thread, record_btrace_target::resume)
3250         (record_btrace_cancel_resume, record_btrace_step_thread)
3251         (record_btrace_target::wait, record_btrace_target::wait)
3252         (record_btrace_target::wait, record_btrace_target::stop): Update.
3253         * progspace.c (print_program_space): Update.
3254         * process-stratum-target.c
3255         (process_stratum_target::thread_address_space): Update.
3256         * linux-fork.c (linux_fork_mourn_inferior)
3257         (detach_checkpoint_command, info_checkpoints_command)
3258         (linux_fork_context): Update.
3259         (linux_fork_detach): Update.
3260         (class scoped_switch_fork_info): Update.
3261         (delete_checkpoint_command): Update.
3262         * infrun.c (follow_fork_inferior): Update.
3263         (follow_fork_inferior): Update.
3264         (proceed_after_vfork_done): Update.
3265         (handle_vfork_child_exec_or_exit): Update.
3266         (follow_exec): Update.
3267         (displaced_step_prepare_throw): Update.
3268         (displaced_step_restore): Update.
3269         (start_step_over): Update.
3270         (resume_1): Update.
3271         (clear_proceed_status_thread): Update.
3272         (proceed): Update.
3273         (print_target_wait_results): Update.
3274         (do_target_wait): Update.
3275         (context_switch): Update.
3276         (stop_all_threads): Update.
3277         (restart_threads): Update.
3278         (finish_step_over): Update.
3279         (handle_signal_stop): Update.
3280         (switch_back_to_stepped_thread): Update.
3281         (keep_going_pass_signal): Update.
3282         (print_exited_reason): Update.
3283         (normal_stop): Update.
3284         * inferior.c (inferior_pid_to_str): Change return type.
3285         (print_selected_inferior): Update.
3286         (add_inferior): Update.
3287         (detach_inferior): Update.
3288         * dummy-frame.c (fprint_dummy_frames): Update.
3289         * dcache.c (dcache_info_1): Update.
3290         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3291         (btrace_fetch, btrace_clear): Update.
3292         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3293         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3294         type.
3295         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3296         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3297         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3298         * gdbarch.c, gdbarch.h: Rebuild.
3299         * gdbarch.sh (core_pid_to_str): Change return type.
3300         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3301         return type.
3302         (windows_nat_target::pid_to_str): Change return type.
3303         (windows_delete_thread): Update.
3304         (windows_nat_target::attach): Update.
3305         (windows_nat_target::files_info): Update.
3306         * target-delegates.c: Rebuild.
3307         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3308         return type.
3309         (sol_thread_target::pid_to_str): Change return type.
3310         * remote.c (class remote_target) <pid_to_str>: Change return
3311         type.
3312         (remote_target::pid_to_str): Change return type.
3313         (extended_remote_target::attach, remote_target::remote_stop_ns)
3314         (remote_target::remote_notif_remove_queued_reply)
3315         (remote_target::push_stop_reply, remote_target::disable_btrace):
3316         Update.
3317         (extended_remote_target::attach): Update.
3318         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3319         type.
3320         (gdbsim_target::pid_to_str): Change return type.
3321         * ravenscar-thread.c (struct ravenscar_thread_target)
3322         <pid_to_str>: Change return type.
3323         (ravenscar_thread_target::pid_to_str): Change return type.
3324         * procfs.c (class procfs_target) <pid_to_str>: Change return
3325         type.
3326         (procfs_target::pid_to_str): Change return type.
3327         (procfs_target::attach): Update.
3328         (procfs_target::detach): Update.
3329         (procfs_target::fetch_registers): Update.
3330         (procfs_target::store_registers): Update.
3331         (procfs_target::wait): Update.
3332         (procfs_target::files_info): Update.
3333         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3334         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3335         return type.
3336         (nto_procfs_target::pid_to_str): Change return type.
3337         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3338         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3339         return type.
3340         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3341         (exit_lwp): Update.
3342         (attach_proc_task_lwp_callback, get_detach_signal)
3343         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3344         (linux_nat_target::resume, wait_lwp, stop_callback)
3345         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3346         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3347         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3348         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3349         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3350         type.
3351         (inf_ptrace_target::attach): Update.
3352         (inf_ptrace_target::files_info): Update.
3353         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3354         type.
3355         (go32_nat_target::pid_to_str): Change return type.
3356         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3357         (gnu_nat_target::wait): Update.
3358         (gnu_nat_target::wait): Update.
3359         (gnu_nat_target::resume): Update.
3360         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3361         (fbsd_nat_target::wait): Update.
3362         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3363         type.
3364         (darwin_nat_target::attach): Update.
3365         * corelow.c (class core_target) <pid_to_str>: Change return type.
3366         (core_target::pid_to_str): Change return type.
3367         * target.c (normal_pid_to_str): Change return type.
3368         (default_pid_to_str): Likewise.
3369         (target_pid_to_str): Change return type.
3370         (target_translate_tls_address): Update.
3371         (target_announce_detach): Update.
3372         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3373         return type.
3374         (bsd_uthread_target::pid_to_str): Change return type.
3375         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3376         type.
3377         (bsd_kvm_target::pid_to_str): Change return type.
3378         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3379         return type.
3380         (aix_thread_target::pid_to_str): Change return type.
3381         * target.h (struct target_ops) <pid_to_str>: Change return type.
3382         (target_pid_to_str, normal_pid_to_str): Likewise.
3383         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3384         type.
3385         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3386         type.
3387         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3388         return type.
3389         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3390         type.
3391         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3392         type.
3393         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3394         return type.
3395
3396 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3397
3398         * NEWS: Mention that the new default MI version is 3.  Mention
3399         changes to the output of commands and events that deal with
3400         multi-location breakpoints.
3401         * breakpoint.c: Include "mi/mi-out.h".
3402         (print_one_breakpoint): Change output syntax if using MI version
3403         >= 3.
3404         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3405         New.
3406         (mi_multi_location_breakpoint_output_fixed): New.
3407         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3408         (mi_cmd_fix_multi_location_breakpoint_output): New.
3409         (mi_multi_location_breakpoint_output_fixed): New.
3410         * mi/mi-cmds.c (mi_cmds): Register command
3411         -fix-multi-location-breakpoint-output.
3412         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3413         interpreter "mi".
3414
3415 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3416
3417         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3418         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3419         instantiate mi_ui_out based on interpreter name.
3420         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3421         * mi/mi-main.c (mi_load_progress): Likewise.
3422
3423 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3424
3425         * NEWS: Combine separate "New targets" sections for 8.3.
3426
3427 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3428
3429         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3430         (ppcfbsd_init_abi): Install gdbarch
3431         "fetch_tls_load_module_address" and "get_thread_local_address"
3432         methods.
3433
3434 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3435
3436         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3437         (riscv_fbsd_init_abi): Install gdbarch
3438         "fetch_tls_load_module_address" and "get_thread_local_address"
3439         methods.
3440
3441 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3442
3443         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3444         (i386fbsd_init_abi): Install gdbarch
3445         "fetch_tls_load_module_address" and "get_thread_local_address"
3446         methods.
3447
3448 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3449
3450         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3451         (amd64fbsd_init_abi): Install gdbarch
3452         "fetch_tls_load_module_address" and "get_thread_local_address"
3453         methods.
3454
3455 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3456
3457         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3458         (struct fbsd_pspace_data): New type.
3459         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3460         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3461         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3462         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3463         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3464
3465 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3466
3467         * gdbtypes.c (lookup_struct_elt): New function.
3468         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3469         * gdbtypes.h (struct struct_elt): New type.
3470         (lookup_struct_elt): New prototype.
3471
3472 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3473
3474         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3475         remove disabled code block.
3476
3477 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3478
3479         * gdbarch.sh (get_thread_local_address): New method.
3480         * gdbarch.h, gdbarch.c: Regenerate.
3481         * target.c (target_translate_tls_address): Use
3482         gdbarch_get_thread_local_address if present instead of
3483         target::get_thread_local_address.
3484
3485 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3486
3487         * target.h (target::get_thread_local_address): Update comment.
3488
3489 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3490
3491         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3492         objfile->separate_debug_objfile_backlink if not NULL.
3493
3494 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3495
3496         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3497         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3498         (amd64bsd_store_inferior_registers): Likewise.
3499         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3500         Enable segment base registers.
3501         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3502         PT_GETFSBASE and PT_GETGSBASE.
3503         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3504         PT_SETGSBASE.
3505         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3506         segment base registers.
3507         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3508
3509 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3510
3511         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3512         Update calls to i386_target_description to add 'segments'
3513         parameter.
3514         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3515         add segment base registers.
3516         * arch/i386.c (i386_create_target_description): Add 'segments'
3517         parameter to enable segment base registers.
3518         * arch/i386.h (i386_create_target_description): Likewise.
3519         * features/i386/32bit-segments.xml: New file.
3520         * features/i386/32bit-segments.c: Generate.
3521         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3522         call to i386_target_description to add 'segments' parameter.
3523         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3524         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3525         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3526         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3527         if feature is present.
3528         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3529         Add 'segments' parameter to call to i386_target_description.
3530         (i386_target_description): Add 'segments' parameter to enable
3531         segment base registers.
3532         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3533         to call to i386_target_description.
3534         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3535         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3536         Define I386_NUM_REGS.
3537         (i386_target_description): Add 'segments' parameter to enable
3538         segment base registers.
3539
3540 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3541
3542         PR/24325
3543         * source-cache.c: #undef open and close, to avoid unresolved
3544         externals during linking.
3545
3546 2019-03-12  Tom Tromey  <tromey@adacore.com>
3547
3548         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3549         const.  Add initializers.
3550         (_initialize_remote): Don't initialize ptid globals.
3551
3552 2019-03-12  Pedro Alves  <palves@redhat.com>
3553
3554         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3555
3556 2019-03-12  Pedro Alves  <palves@redhat.com>
3557
3558         * cp-name-parser.y (main): Remove unused 'len' variable.
3559
3560 2019-03-12  Tom Tromey  <tromey@adacore.com>
3561
3562         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3563         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3564
3565 2019-03-12  Tom Tromey  <tromey@adacore.com>
3566
3567         * linux-nat.c (iterate_over_lwps): Update.
3568         (stop_callback): Remove parameter.
3569         (stop_wait_callback, detach_callback, resume_set_callback)
3570         (select_singlestep_lwp_callback, set_ignore_sigint)
3571         (status_callback, resumed_callback, resume_clear_callback)
3572         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3573         data parameter.
3574         (linux_nat_target::detach, linux_nat_target::resume)
3575         (linux_stop_and_wait_all_lwps, select_event_lwp)
3576         (linux_nat_filter_event, linux_nat_wait_1)
3577         (linux_nat_target::kill, linux_nat_target::stop)
3578         (linux_nat_target::stop): Update.
3579         (linux_nat_resume_callback): Change type.
3580         (resume_stopped_resumed_lwps, count_events_callback)
3581         (select_event_lwp_callback): Likewise.
3582         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3583         * arm-linux-nat.c (struct update_registers_data): Remove.
3584         (update_registers_callback): Change type.
3585         (arm_linux_insert_hw_breakpoint1): Update.
3586         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3587         parameter.
3588         (x86_linux_dr_set_addr): Update.
3589         (x86_linux_dr_set_control): Update.
3590         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3591         (iterate_over_lwps): Use gdb::function_view.
3592         * nat/aarch64-linux-hw-point.c (struct
3593         aarch64_dr_update_callback_param): Remove.
3594         (debug_reg_change_callback): Change type.
3595         (aarch64_notify_debug_reg_change): Update.
3596         * s390-linux-nat.c (s390_refresh_per_info): Update.
3597
3598 2019-03-11  Tom Tromey  <tromey@adacore.com>
3599
3600         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3601         redundant assignment to "this_cu".
3602
3603 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3604
3605         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3606
3607 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3608
3609         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3610         from...
3611         (rank_one_type): ... this.
3612
3613 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3614
3615         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3616         from...
3617         (rank_one_type): ... this.
3618
3619 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3620
3621         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3622         from...
3623         (rank_one_type): ... this.
3624
3625 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3626
3627         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3628         from...
3629         (rank_one_type): ... this.
3630
3631 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3632
3633         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3634         from...
3635         (rank_one_type): ... this.
3636
3637 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3638
3639         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3640         from...
3641         (rank_one_type): ... this.
3642
3643 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3644
3645         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3646         from...
3647         (rank_one_type): ... this.
3648
3649 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3650
3651         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3652         from...
3653         (rank_one_type): ... this.
3654
3655 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3656
3657         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3658         from...
3659         (rank_one_type): ... this.
3660
3661 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3662
3663         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3664         from...
3665         (rank_one_type): ... this.
3666
3667 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3668
3669         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3670         from...
3671         (rank_one_type): ... this.
3672
3673 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3674
3675         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3676         from...
3677         (rank_one_type): ... this.
3678
3679 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3680
3681         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3682         inferior-events' shows the example events.
3683
3684 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3685
3686         Support styling on native MS-Windows console
3687
3688         PR/24315
3689         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3690         on MS-Windows if $TERM is not defined.
3691
3692         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3693
3694         * posix-hdep.c (gdb_console_fputs):
3695         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3696         functions.
3697         * ui-file.h (gdb_console_fputs): Add prototype.
3698
3699         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3700         back to fputs only if the former returns zero.
3701
3702 2019-03-07  Tom Tromey  <tom@tromey.com>
3703
3704         * symmisc.c (print_symbol_bcache_statistics): Update.
3705         (print_objfile_statistics): Update.
3706         * symfile.c (allocate_symtab): Update.
3707         * stabsread.c: Don't include bcache.h.
3708         * psymtab.h (struct psymbol_bcache): Don't declare.
3709         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3710         (psymbol_bcache_init, psymbol_bcache_free)
3711         (psymbol_bcache_get_bcache): Don't declare.
3712         * psymtab.c (struct psymbol_bcache): Remove.
3713         (psymtab_storage::psymtab_storage): Update.
3714         (psymtab_storage::~psymtab_storage): Update.
3715         (psymbol_bcache_init, psymbol_bcache_free)
3716         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3717         (add_psymbol_to_bcache): Update.
3718         (allocate_psymtab): Update.
3719         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3720         macro_cache>: No longer pointers.
3721         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3722         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3723         * macrotab.c (macro_bcache): Update.
3724         * macroexp.c: Don't include bcache.h.
3725         * gdbtypes.c (check_types_worklist): Update.
3726         (types_deeply_equal): Remove TRY/CATCH.  Update.
3727         * elfread.c (elf_symtab_read): Update.
3728         * dwarf2read.c: Don't include bcache.h.
3729         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3730         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3731         (print_bcache_statistics, bcache_memory_used): Don't declare.
3732         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3733         methods.  Rename all data members.
3734         * bcache.c (struct bcache): Move to bcache.h.
3735         (bcache::expand_hash_table): Rename from expand_hash_table.
3736         (bcache): Remove.
3737         (bcache::insert): Rename from bcache_full.
3738         (bcache::compare): Rename from bcache_compare.
3739         (bcache_xmalloc): Remove.
3740         (bcache::~bcache): Rename from bcache_xfree.
3741         (bcache::print_statistics): Rename from print_bcache_statistics.
3742         (bcache::memory_used): Rename from bcache_memory_used.
3743
3744 2019-03-07  Pedro Alves  <palves@redhat.com>
3745
3746         * infrun.c (normal_stop): Also check for
3747         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3748
3749 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3750
3751         * f-lang.c (value_from_host_double): Moved to...
3752         * value.c (value_from_host_double): ...here.
3753         * value.h (value_from_host_double): Declare.
3754         * guile/scm-math.c (vlscm_convert_typed_number): Use
3755         value_from_host_double.
3756         (vlscm_convert_number): Likewise.
3757         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3758         * python/py-value.c (convert_value_from_python): Likewise.
3759
3760 2019-03-06  Tom Tromey  <tom@tromey.com>
3761
3762         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3763
3764 2019-03-06  Tom Tromey  <tom@tromey.com>
3765
3766         * utils.h (free_current_contents): Don't declare.
3767         * utils.c (free_current_contents): Remove.
3768
3769 2019-03-06  Tom Tromey  <tom@tromey.com>
3770
3771         * top.c (quit_force): Update.
3772         * main.c (captured_command_loop): Update.
3773         * common/new-op.c (operator new): Update.
3774         * common/common-exceptions.c (struct catcher)
3775         <save_cleanup_chain>: Remove member.
3776         (exceptions_state_mc_init): Update.
3777         (exception_try_scope_entry): Return nullptr.
3778         (exception_try_scope_exit, exception_rethrow)
3779         (throw_exception_sjlj, throw_exception_cxx): Update.
3780         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3781         (all_cleanups, do_cleanups, discard_cleanups)
3782         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3783         (restore_cleanups, restore_final_cleanups): Don't declare.
3784         (do_final_cleanups): Remove parameter.
3785         * common/cleanups.c (cleanup_chain, make_cleanup)
3786         (make_cleanup_dtor, all_cleanups, do_cleanups)
3787         (discard_my_cleanups, discard_cleanups)
3788         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3789         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3790         (null_cleanup): Remove.
3791         (do_final_cleanups): Remove parameter.
3792
3793 2019-03-06  Tom Tromey  <tom@tromey.com>
3794
3795         * remote.c (remote_target::remote_parse_stop_reply): Use
3796         unique_xmalloc_ptr.
3797
3798 2019-03-06  Tom Tromey  <tom@tromey.com>
3799
3800         * stabsread.c (struct stabs_field_info): Rename from field_info.
3801         <list, fnlist>: Add initializers.
3802         <obstack>: New member.
3803         (read_member_functions, read_struct_fields, read_baseclasses):
3804         Allocate on obstack.  Don't use cleanups.
3805         (read_one_struct_field, read_member_functions, read_struct_fields)
3806         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3807         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3808         (read_struct_type): Update.
3809
3810 2019-03-06  Tom Tromey  <tom@tromey.com>
3811
3812         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3813         * common/filestuff.h (make_cleanup_close): Don't declare.
3814         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3815         Remove.
3816
3817 2019-03-06  Tom Tromey  <tom@tromey.com>
3818
3819         * solib-aix.c: Use make_scope_exit.
3820
3821 2019-03-06  Tom Tromey  <tom@tromey.com>
3822
3823         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3824         Use make_scope_exit.
3825
3826 2019-03-06  Tom Tromey  <tom@tromey.com>
3827
3828         * solib-svr4.c (disable_probes_interface): Remove parameter.
3829         (svr4_handle_solib_event): Use make_scope_exit.
3830
3831 2019-03-06  Tom Tromey  <tom@tromey.com>
3832
3833         * remote.c (struct stop_reply_deleter): Remove.
3834         (stop_reply_up): Update.
3835         (struct stop_reply): Derive from notif_event.  Don't typedef.
3836         <regcache>: Now a std::vector.
3837         (stop_reply_xfree): Remove.
3838         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3839         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3840         (remote_target::discard_pending_stop_replies): Use delete.
3841         (remote_target::remote_parse_stop_reply): Update.
3842         (remote_target::process_stop_reply): Update.
3843         * remote-notif.h (struct notif_event): Add virtual destructor.
3844         Remove "dtr" member.
3845         (struct notif_client) <alloc_event>: Return a unique_ptr.
3846         (notif_event_xfree): Don't declare.
3847         (notif_event_up): New typedef.
3848         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3849         (notif_event_xfree, do_notif_event_xfree): Remove.
3850         (remote_notif_state_xfree): Update.
3851
3852 2019-03-06  Tom Tromey  <tom@tromey.com>
3853
3854         * infrun.c (displaced_step_clear_cleanup): Now a
3855         forward_scope_exit type.
3856         (displaced_step_prepare_throw): Update.
3857         (displaced_step_fixup): Update.
3858
3859 2019-03-06  Tom Tromey  <tom@tromey.com>
3860
3861         * inferior.h (class inferior): Update comment.
3862         * gdbthread.h (class thread_info): Update comment.
3863
3864 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3865             Tom Tromey  <tom@tromey.com>
3866
3867         * stabsread.h (struct stab_section_list): Remove.
3868         (coffstab_build_psymtabs): Update.
3869         * dbxread.c (symbuf_sections): Now a std::vector.
3870         (sect_idx): New global.
3871         (fill_symbuf): Update.
3872         (coffstab_build_psymtabs): Change type of stabsects parameter.
3873         Update.
3874         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3875         std::vector.
3876         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3877         (coff_locate_sections): Update.
3878         (coff_symfile_read): Remove cleanups.  Update.
3879         (init_stringtab): Add storage parameter.
3880         (free_stringtab, free_stringtab_cleanup): Remove.
3881         (init_lineno): Add storage parameter.
3882         (free_linetab, free_linetab_cleanup): Remove.
3883
3884 2019-03-06  Pedro Alves  <palves@redhat.com>
3885
3886         * linux-fork.c (fork_info::clobber_regs): Delete.
3887         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3888         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3889         comment.  Adjust.
3890         (scoped_switch_fork_info::scoped_switch_fork_info)
3891         (checkpoint_command, linux_fork_context): Adjust
3892         fork_save_infrun_state calls.
3893
3894 2019-03-06  Pedro Alves  <palves@redhat.com>
3895
3896         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3897         (inf_has_multiple_threads): Return 'bool' and rewrite using
3898         inferior_info::threads().
3899
3900 2019-03-06  Pedro Alves  <palves@redhat.com>
3901
3902         * linux-fork.c: Include <list>.
3903         (fork_list): Now a std::list instance.
3904         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3905         (forks_exist_p, find_last_fork): Adjust.
3906         (new_fork): Delete.
3907         (one_fork_p): New.
3908         (add_fork): Adjust.
3909         (free_fork): Delete, folded into fork_info::~fork_info().
3910         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3911         Adjust.
3912         (init_fork_list): Delete.
3913         (linux_fork_killall, linux_fork_mourn_inferior)
3914         (linux_fork_detach, info_checkpoints_command): Adjust.
3915         (_initialize_linux_fork): No longer call init_fork_list.
3916
3917 2019-03-06  Pedro Alves  <palves@redhat.com>
3918
3919         * linux-fork.c (new_fork): New, split out of ...
3920         (add_fork): ... this.  Return void.  Move "first fork" special
3921         case from here, to ...
3922         (checkpoint_command): ... here.
3923         * linux-linux.h (add_fork): Return void.
3924
3925 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3926
3927         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3928
3929 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3930             Chris January  <chris.january@arm.com>
3931             David Lecomber  <david.lecomber@arm.com>
3932
3933         * f-exp.y: New token, UNOP_INTRINSIC.
3934         (exp): New pattern using UNOP_INTRINSIC token.
3935         (f77_keywords): Add 'abs' keyword.
3936         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3937         (value_from_host_double): New function.
3938         (evaluate_subexp_f): Support UNOP_ABS.
3939
3940 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3941
3942         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3943         types.
3944
3945 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3946
3947         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3948         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3949         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3950
3951 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3952
3953         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3954
3955 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3956             Chris January  <chris.january@arm.com>
3957
3958         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3959         * f-exp.y: Define 'KIND' token.
3960         (exp): New pattern for KIND expressions.
3961         (ptype): Handle types with a kind extension.
3962         (direct_abs_decl): Extend to spot kind extensions.
3963         (f77_keywords): Add 'kind' to the list.
3964         (push_kind_type): New function.
3965         (convert_to_kind_type): New function.
3966         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3967         * parse.c (operator_length_standard): Likewise.
3968         * parser-defs.h (enum type_pieces): Add tp_kind.
3969         * std-operator.def: Add UNOP_KIND.
3970
3971 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3972
3973         * f-exp.y (f_parse): Set yydebug.
3974
3975 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3976
3977         * f-lang.c (evaluate_subexp_f): New function.
3978         (exp_descriptor_f): New global.
3979         (f_language_defn): Use exp_descriptor_f instead of
3980         exp_descriptor_standard.
3981
3982 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3983
3984         * f-exp.y (struct token): Add comments.
3985         (dot_ops): Remove uppercase versions and the end marker.
3986         (f77_keywords): Likewise.
3987         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3988         entries in the dot_ops array are case insensitive, and use
3989         strncasecmp to compare strings.  Also some whitespace cleanup in
3990         this area.  Similar for the f77_keywords array, except entries in
3991         this list might be case sensitive.
3992
3993 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3994
3995         * f-exp.y (struct f77_boolean_val): Add comments.
3996         (boolean_values): Remove uppercase versions, and end marker.
3997         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3998         and use strncasecmp to achieve case insensitivity.  Additionally,
3999         perform whitespace cleanup around this code.
4000
4001 2019-03-06  Tom Tromey  <tromey@adacore.com>
4002
4003         * remote-sim.c (gdbsim_target_open): Use result of
4004         gdb_argv::release.
4005
4006 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4007         Dirk Schubert  <dirk.schubert@arm.com>
4008         Chris January  <chris.january@arm.com>
4009
4010         * eval.c (evaluate_subexp_standard): Call Fortran argument
4011         wrapping logic.
4012         * f-lang.c (struct value): A value which can be passed into a
4013         Fortran function call.
4014         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4015         where appropriate.
4016         (struct type): Value ready for a Fortran function call.
4017         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4018         is needed.
4019         * f-lang.h (fortran_argument_convert): Declaration.
4020         (fortran_preserve_arg_pointer): Declaration.
4021         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4022
4023 2019-03-05  Tom Tromey  <tromey@adacore.com>
4024
4025         * python/py-prettyprint.c (print_string_repr): Remove #if.
4026         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4027
4028 2019-03-05  Tom Tromey  <tromey@adacore.com>
4029
4030         * target.c (the_dummy_target): Move later.  Change type to
4031         "dummy_target".
4032         (initialize_targets): Don't initialize the_dummy_target.
4033
4034 2019-03-05  Tom Tromey  <tromey@adacore.com>
4035
4036         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4037         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4038
4039 2019-03-05  Tom Tromey  <tromey@adacore.com>
4040
4041         * windows-nat.c (windows_nat_target::attach)
4042         (windows_nat_target::detach): Don't call gdb_flush.
4043         * valprint.c (generic_val_print, val_print, val_print_string):
4044         Don't call gdb_flush.
4045         * utils.c (defaulted_query): Don't call gdb_flush.
4046         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4047         * target.c (target_announce_detach): Don't call gdb_flush.
4048         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4049         * remote.c (extended_remote_target::attach): Don't call
4050         gdb_flush.
4051         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4052         * printcmd.c (do_examine): Don't call gdb_flush.
4053         (info_display_command): Don't call gdb_flush.
4054         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4055         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4056         * memattr.c (info_mem_command): Don't call gdb_flush.
4057         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4058         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4059         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4060         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4061         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4062         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4063         (gnu_nat_target::detach): Don't call gdb_flush.
4064         * f-valprint.c (f_val_print): Don't call gdb_flush.
4065         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4066         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4067         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4068         gdb_flush.
4069         * c-valprint.c (c_val_print): Don't call gdb_flush.
4070         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4071
4072 2019-03-05  Tom Tromey  <tromey@adacore.com>
4073
4074         * varobj.c (update_dynamic_varobj_children): Update.
4075         (install_default_visualizer): Use reset, not release.
4076         * value.c (set_internalvar): Update.
4077         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4078         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4079         ATTRIBUTE_UNUSED_RESULT.
4080
4081 2019-03-05  Tom Tromey  <tromey@adacore.com>
4082
4083         * remote.c (class scoped_remote_fd) <release>: Add
4084         ATTRIBUTE_UNUSED_RESULT.
4085
4086 2019-03-05  Tom Tromey  <tromey@adacore.com>
4087
4088         * macroexp.c (struct macro_buffer) <release>: Add
4089         ATTRIBUTE_UNUSED_RESULT.
4090
4091 2019-03-05  Tom Tromey  <tromey@adacore.com>
4092
4093         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4094         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4095         ATTRIBUTE_UNUSED_RESULT.
4096
4097 2019-03-05  Tom Tromey  <tromey@adacore.com>
4098
4099         * common/scoped_fd.h (class scoped_fd) <release>: Add
4100         ATTRIBUTE_UNUSED_RESULT.
4101
4102 2019-03-05  Tom Tromey  <tromey@adacore.com>
4103
4104         * parser-defs.h (struct parser_state) <release>: Add
4105         ATTRIBUTE_UNUSED_RESULT.
4106
4107 2019-03-05  Tom Tromey  <tromey@adacore.com>
4108
4109         * utils.h (class gdb_argv) <release>: Add
4110         ATTRIBUTE_UNUSED_RESULT.
4111         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4112
4113 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4114
4115         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4116         for-loop range, to avoid compiler warnings.
4117
4118         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4119         avoid compiler warnings about unused variables.
4120
4121         * NEWS: Mention end of support for native debugging on MS-Windows
4122         before XP.
4123
4124         PR gdb/24292
4125         * common/netstuff.c:
4126         * gdbserver/gdbreplay.c
4127         * gdbserver/remote-utils.c:
4128         * ser-tcp.c:
4129         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4130         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4131         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4132         'getaddrinfo' and 'freeaddrinfo' were not available before
4133         Windows XP, and mingw.org's MinGW headers by default define
4134         _WIN32_WINNT to 0x500.
4135
4136 2019-03-01  Gary Benson <gbenson@redhat.com>
4137
4138         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4139
4140 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4141             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4142
4143         PR gdb/8527
4144         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4145         set_sigint_trap, clear_sigint_trap.
4146
4147 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4148
4149         * target.c (target_detach): Clear the regcache and the
4150         frame cache.
4151
4152 2019-02-27  Pedro Alves  <palves@redhat.com>
4153
4154         * utils.c (set_screen_size): When we cap the height/width sizes,
4155         tweak the corresponding command variable to show "unlimited":
4156
4157 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4158             Pedro Alves  <palves@redhat.com>
4159
4160         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4161         before calling rl_set_screen_size.
4162
4163 2019-02-27  Tom Tromey  <tromey@adacore.com>
4164
4165         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4166         define.
4167         * python/py-value.c: Remove Python 2.4 workaround.
4168         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4169         workaround.
4170         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4171         Python 2.4 workaround.
4172         * python/python-internal.h: Remove Python 2.4 comment.
4173         (Py_ssize_t): Don't define.
4174         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4175         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4176         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4177         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4178         * python/python.c (do_start_initialization): Remove Python 2.4
4179         workaround.
4180         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4181         (print_children): Remove Python 2.4 workaround.
4182         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4183         workaround.
4184         (CHARBUFFERPROC_NAME): Remove.
4185         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4186         Python 2.4 workaround.
4187
4188 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4189
4190         * NEWS: Note minimum Python version.
4191
4192 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4193
4194         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4195         code from these functions.  Remove corresponding ifdefs.  Use
4196         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4197         Remove gotos and target of gotos.
4198         (infpy_search_memory): Likewise.
4199
4200 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4201
4202         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4203         (hppa_gdbarch_init): Don't register deleted functions with
4204         gdbarch.
4205
4206 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4207
4208         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4209         (h8300_unwind_sp): Delete.
4210         (h8300_dummy_id): Delete.
4211         (h8300_gdbarch_init): Don't register deleted functions with
4212         gdbarch.
4213
4214 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4215
4216         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4217         (ft32_unwind_pc): Delete.
4218         (ft32_unwind_sp): Delete.
4219         (ft32_gdbarch_init): Don't register deleted functions with
4220         gdbarch.
4221
4222 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4223
4224         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4225         (frv_unwind_pc): Delete.
4226         (frv_unwind_sp): Delete.
4227         (frv_gdbarch_init): Don't register deleted functions with
4228         gdbarch.
4229
4230 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4231
4232         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4233         (riscv_unwind_pc): Delete.
4234         (riscv_unwind_sp): Delete.
4235         (riscv_gdbarch_init): Don't register deleted functions with
4236         gdbarch.
4237
4238 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4239
4240         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4241         (csky_unwind_pc): Delete.
4242         (csky_unwind_sp): Delete.
4243         (csky_gdbarch_init): Don't register deleted functions with
4244         gdbarch.
4245
4246 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4247
4248         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4249         (cris_unwind_pc): Delete.
4250         (cris_unwind_sp): Delete.
4251         (cris_gdbarch_init): Don't register deleted functions with
4252         gdbarch.
4253
4254 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4255
4256         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4257         (bfin_unwind_pc): Delete.
4258         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4259
4260 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4261
4262         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4263         (arm_unwind_pc): Delete.
4264         (arm_unwind_sp): Delete.
4265         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4266
4267 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4268
4269         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4270         (arc_unwind_pc): Delete.
4271         (arc_unwind_sp): Delete.
4272         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4273
4274 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4275
4276         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4277         (alpha_unwind_pc): Delete.
4278         (alpha_gdbarch_init): Don't register deleted functions with
4279         gdbarch.
4280
4281 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4282
4283         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4284         (aarch64_unwind_pc): Delete.
4285         (aarch64_unwind_sp): Delete.
4286         (aarch64_gdbarch_init): Don't register deleted functions with
4287         gdbarch.
4288
4289 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4290
4291         * gdbtypes.c (type_align): Don't consider static members when
4292         computing structure alignment.
4293
4294 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4295
4296         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4297         return 0 for other types.
4298         * arch-utils.c (default_type_align): Always return 0.
4299         * gdbarch.h: Regenerate.
4300         * gdbarch.sh (type_align): Extend comment.
4301         * gdbtypes.c (type_align): Add additional comments, always call
4302         gdbarch_type_align before applying the default rules.
4303         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4304         generic code will then apply a suitable default.
4305         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4306         types, return 0 for other types.
4307
4308 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4309
4310         * NEWS: Create a new section for the next release branch.
4311         Rename the section of the current branch, now that it has
4312         been cut.
4313
4314 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4315
4316         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4317         * version.in: Bump version to 8.3.50.DATE-git.
4318
4319 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4320
4321         * aix-thread.c (ptid_cmp): Remove unused variable.
4322         (get_signaled_thread): Likewise.
4323         (store_regs_user_thread): Likewise.
4324         (store_regs_kernel_thread): Likewise.
4325         (fetch_regs_kernel_thread): Remove shadowed variable.
4326
4327 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4328
4329         * features/riscv/32bit-cpu.xml: Add register numbers.
4330         * features/riscv/32bit-fpu.c: Regenerate.
4331         * features/riscv/32bit-fpu.xml: Add register numbers.
4332         * features/riscv/64bit-cpu.xml: Add register numbers.
4333         * features/riscv/64bit-fpu.c: Regenerate.
4334         * features/riscv/64bit-fpu.xml: Add register numbers.
4335
4336 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4337
4338         * NEWS: Mention two argument form of gdb.Value constructor.
4339         * python/py-value.c (convert_buffer_and_type_to_value): New
4340         function.
4341         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4342         Add support for handling an optional second argument.  Call
4343         convert_buffer_and_type_to_value as appropriate.
4344         * python/python-internal.h (Py_buffer_deleter): New struct.
4345         (Py_buffer_up): New typedef.
4346
4347 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4348
4349         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4350         instead of releasing ownership.
4351
4352 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4353
4354         * dwarf2read.c (open_and_init_dwp_file): Call
4355         elf_numsections instead of bfd_count_sections to initialize
4356         dwp_file->num_sections.
4357
4358 2019-02-25  Tom Tromey  <tromey@adacore.com>
4359
4360         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4361
4362 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4363
4364         * gcore.in: Add '--readnever' option when invoking GDB.
4365
4366 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4367
4368         * MAINTAINERS: Update my email address.
4369
4370 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4371
4372         * build-id.c (build_id_to_debug_bfd_1): New function.
4373         (build_id_to_debug_bfd): Look for separate debug file in
4374         sysroot.
4375
4376 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4377
4378         * gdbarch.sh: Update the copyright year range that is placed into
4379         generated files.
4380
4381 2019-02-22  Keith Seitz  <keiths@redhat.com>
4382
4383         PR symtab/23853
4384         * linespec.c (create_sals_line_offset): Search for the default
4385         symtab's filename instead of its fullname.
4386
4387 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4388
4389         * NEWS: Update style defaults.
4390
4391 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4392
4393         * main.c (captured_main_1): Disable styling in batch mode.
4394
4395 2019-02-20  Tom Tromey  <tom@tromey.com>
4396
4397         * symtab.c (symtab_symbol_info): Fix typos.
4398
4399 2019-02-20  Tom Tromey  <tromey@adacore.com>
4400
4401         * findcmd.c (_initialize_mem_search): Use upper case for
4402         metasyntactic variables.
4403
4404 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4405
4406         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4407         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4408
4409 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4410
4411         * top.h (source_file_name): Change to std::string.
4412         * top.c (source_file_name): Likewise.
4413         (command_line_input): Adjust.
4414         * cli/cli-script.c (script_from_file): Adjust.
4415
4416 2019-02-19  Tom Tromey  <tromey@adacore.com>
4417
4418         * ravenscar-thread.c
4419         (ravenscar_thread_target::update_thread_list): Don't call
4420         ada_build_task_list.
4421         * ada-lang.h (ada_build_task_list): Don't declare.
4422         * ada-tasks.c (struct ada_tasks_inferior_data)
4423         <task_list_valid_p>: Now bool.
4424         (read_known_tasks, ada_task_list_changed)
4425         (ada_tasks_invalidate_inferior_data): Update.
4426         (read_known_tasks_array): Return bool.
4427         (read_known_tasks_list): Likewise.
4428         (read_known_tasks): Return void.
4429         (ada_build_task_list): Now static.
4430
4431 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4432
4433         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4434         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4435
4436 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4437
4438         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4439         variant for ada_tasks_pspace_data_handle and
4440         ada_tasks_inferior_data_handle.
4441         (ada_tasks_pspace_data_cleanup): New function.
4442         (ada_tasks_inferior_data_cleanup): New function.
4443
4444 2019-02-17  Tom Tromey  <tom@tromey.com>
4445
4446         * macrotab.h (macro_source_fullname): Return a std::string.
4447         * macrotab.c (macro_include, check_for_redefinition)
4448         (macro_undef, macro_lookup_definition, foreach_macro)
4449         (foreach_macro_in_scope): Update.
4450         (macro_source_fullname): Return a std::string.
4451         * macrocmd.c (show_pp_source_pos): Update.
4452
4453 2019-02-17  Tom Tromey  <tom@tromey.com>
4454
4455         * macrocmd.c (show_pp_source_pos): Style the file names.
4456
4457 2019-02-17  Tom Tromey  <tom@tromey.com>
4458
4459         PR tui/24197:
4460         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4461
4462 2019-02-17  Tom Tromey  <tom@tromey.com>
4463
4464         * ada-lang.c (user_select_syms): Use filtered printing.
4465         * utils.c (wrap_style): New global.
4466         (desired_style): Remove.
4467         (emit_style_escape): Add stream parameter.
4468         (set_output_style, reset_terminal_style, prompt_for_continue):
4469         Update.
4470         (flush_wrap_buffer): Only flush gdb_stdout.
4471         (wrap_here): Set wrap_style.
4472         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4473         treat escape sequences as a character.  Change when wrap buffer is
4474         flushed.
4475         (fputs_styled): Do not set the output style when the default is
4476         requested.
4477         * ui-style.h (struct ui_file_style) <is_default>: New method.
4478         * source.c (print_source_lines_base): Emit escape sequences in one
4479         piece.
4480
4481 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4482
4483         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4484         integers and enumeration types.
4485
4486 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4487
4488         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4489         instead of lookup_symbol_in_language
4490         (do_exact_match): New function.
4491         (ada_get_symbol_name_matcher): Return do_exact_match when
4492         doing a verbatim match.
4493
4494 2019-02-15  Tom Tromey  <tromey@adacore.com>
4495
4496         * ravenscar-thread.c (ravenscar_thread_target::resume)
4497         (ravenscar_thread_target::wait): Special case wildcard requests.
4498
4499 2019-02-15  Tom Tromey  <tromey@adacore.com>
4500
4501         * ravenscar-thread.c (base_ptid): Remove.
4502         (struct ravenscar_thread_target) <close>: New method.
4503         <m_base_ptid>: New member.
4504         <update_inferior_ptid, active_task, task_is_currently_active,
4505         runtime_initialized>: Declare methods.
4506         <ravenscar_thread_target>: Add constructor.
4507         (ravenscar_thread_target::task_is_currently_active)
4508         (ravenscar_thread_target::update_inferior_ptid)
4509         (ravenscar_runtime_initialized): Rename.  Now methods.
4510         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4511         (ravenscar_thread_target::update_thread_list): Update.
4512         (ravenscar_thread_target::active_task): Now method.
4513         (ravenscar_thread_target::store_registers)
4514         (ravenscar_thread_target::prepare_to_store)
4515         (ravenscar_thread_target::prepare_to_store)
4516         (ravenscar_thread_target::mourn_inferior): Update.
4517         (ravenscar_inferior_created): Use "new" to create target.
4518         (ravenscar_thread_target::get_ada_task_ptid): Update.
4519         (_initialize_ravenscar): Don't initialize base_ptid.
4520         (ravenscar_ops): Remove global.
4521
4522 2019-02-15  Tom Tromey  <tromey@adacore.com>
4523
4524         * target.h (push_target): Declare new overload.
4525         * target.c (push_target): New overload, taking an rvalue reference.
4526         * remote.c (remote_target::open_1): Use push_target overload.
4527         * corelow.c (core_target_open): Use push_target overload.
4528
4529 2019-02-15  Tom Tromey  <tromey@adacore.com>
4530
4531         * ravenscar-thread.c (is_ravenscar_task)
4532         (ravenscar_task_is_currently_active): Return bool.
4533         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4534         (_initialize_ravenscar): Remove "(void)".
4535         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4536         Return bool.
4537
4538 2019-02-15  Tom Tromey  <tromey@adacore.com>
4539
4540         * ravenscar-thread.c (ravenscar_runtime_initializer)
4541         (has_ravenscar_runtime, get_running_thread_id)
4542         (ravenscar_thread_target::resume): Fix indentation.
4543
4544 2019-02-15  Tom Tromey  <tromey@adacore.com>
4545
4546         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4547         from ravenscar_arch_ops.
4548         (sparc_ravenscar_ops::fetch_registers)
4549         (sparc_ravenscar_ops::store_registers): Now methods.
4550         (sparc_ravenscar_prepare_to_store): Remove.
4551         (sparc_ravenscar_ops): Redefine.
4552         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4553         methods and destructor.  Remove members.
4554         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4555         (ravenscar_thread_target::store_registers)
4556         (ravenscar_thread_target::prepare_to_store): Update.
4557         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4558         Remove.
4559         (struct ppc_ravenscar_powerpc_ops): Derive from
4560         ravenscar_arch_ops.
4561         (ppc_ravenscar_powerpc_ops::fetch_registers)
4562         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4563         (ppc_ravenscar_powerpc_ops): Redefine.
4564         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4565         (ppc_ravenscar_e500_ops::fetch_registers)
4566         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4567         (ppc_ravenscar_e500_ops): Redefine.
4568         * aarch64-ravenscar-thread.c
4569         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4570         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4571         (aarch64_ravenscar_fetch_registers)
4572         (aarch64_ravenscar_store_registers): Now methods.
4573         (aarch64_ravenscar_ops): Redefine.
4574
4575 2019-02-15  Tom Tromey  <tromey@adacore.com>
4576
4577         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4578         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4579         (ravenscar_thread_target::stopped_by_watchpoint)
4580         (ravenscar_thread_target::stopped_data_address)
4581         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4582
4583 2019-02-15  Tom Tromey  <tromey@adacore.com>
4584
4585         * ravenscar-thread.c: Fix some typos.
4586
4587 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4588             Tom Tromey  <tromey@adacore.com>
4589
4590         * ada-lang.c (ada_exception_sal): Change addr_string to a
4591         std::string.
4592         (create_ada_exception_catchpoint): Update.
4593
4594 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4595             Tom Tromey  <tromey@adacore.com>
4596
4597         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4598         (bp_location_ops): Remove.
4599         (base_breakpoint_allocate_location): Update.
4600         (free_bp_location): Update.
4601         * ada-lang.c (class ada_catchpoint_location)
4602         <ada_catchpoint_location>: Remove ops parameter.
4603         (ada_catchpoint_location_dtor): Remove.
4604         (ada_catchpoint_location_ops): Remove.
4605         (allocate_location_exception): Update.
4606         * breakpoint.h (struct bp_location_ops): Remove.
4607         (class bp_location) <bp_location>: Remove bp_location_ops
4608         parameter.
4609         <~bp_location>: Add destructor.
4610         <ops>: Remove.
4611
4612 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4613             Pedro Alves  <palves@redhat.com>
4614
4615         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4616         'PATH_MAX'.
4617
4618 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4619             Samuel Thibault  <samuel.thibault@gnu.org>
4620             Thomas Schwinge  <thomas@codesourcery.com>
4621
4622         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4623         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4624
4625 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4626
4627         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4628         (check_empty): Use "const char *".
4629
4630         * gnu-nat.c (gnu_nat_target::detach): Instead of
4631         'detach_inferior (pid)' call
4632         'detach_inferior (find_inferior_pid (pid))'.
4633
4634         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4635         'nat/fork-inferior.o'.
4636         * gnu-nat.c: #include "nat/fork-inferior.h".
4637
4638         * gnu-nat.c (gnu_nat_target::detach): Instead of
4639         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4640         * gnu-nat.h: #include "inf-child.h".
4641         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4642         'i386_gnu_nat_target::fetch_registers'.
4643         (gnu_store_registers): Rename/move to
4644         'i386_gnu_nat_target::store_registers'.
4645
4646         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4647         * gnu-nat.h (mach_thread_info): New function.
4648         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4649
4650         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4651
4652 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4653
4654         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4655
4656 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4657
4658         * windows-nat.c (windows_add_thread): Add new parameter
4659         "main_thread_p" with default value set to false.  Update
4660         function documentation as well as all callers.
4661         (windows_delete_thread): Likewise.
4662         (fake_create_process): Update call to windows_add_thread.
4663         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4664         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4665         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4666         call to windows_delete_thread.
4667
4668 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4669
4670         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4671
4672 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4673
4674         * symfile.c (find_separate_debug_file): Use canonical path of
4675         sysroot with child_path instead of gdb_sysroot if it is valid.
4676
4677 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4678
4679         * symfile.c (find_separate_debug_file): Use child_path to
4680         determine if an object file is under a sysroot.
4681
4682 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4683
4684         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4685         unittests/child-path-selftests.c.
4686         * common/pathstuff.c (child_path): New function.
4687         * common/pathstuff.h (child_path): New prototype.
4688         * unittests/child-path-selftests.c: New file.
4689
4690 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4691
4692         * symfile.c (find_separate_debug_file): Look for separate debug
4693         files in debug directories under the sysroot.
4694
4695 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4696
4697         * symtab.h (struct minimal_symbol data_p): New const method.
4698         (struct minimal_symbol text_p): Likewise.
4699         * symtab.c (output_source_filename): Use file name style
4700         to print file name.
4701         (print_symbol_info): Likewise.
4702         (print_msymbol_info): Use address style to print addresses.
4703         Use function name style to print executable text symbols.
4704         (expand_symtab_containing_pc): Use data_p.
4705         (find_pc_sect_compunit_symtab): Likewise.
4706
4707 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4708
4709         * breakpoint.c (describe_other_breakpoints): Use address style
4710         to print addresses.
4711         (say_where): Likewise.
4712
4713 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4714
4715         * ada-typeprint.c (print_func_type): Print function name
4716         style to print function name.
4717         * c-typeprint.c (c_print_type_1): Likewise.
4718
4719 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4720
4721         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4722         for execve.
4723
4724 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4725
4726         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4727         type_stack.
4728
4729 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4730
4731         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4732         TYPE_CODE_REF types.
4733
4734 2019-02-08  Jim Wilson  <jimw@sifive.com>
4735
4736         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4737         (riscv_linux_fregset): New.
4738         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4739
4740 2019-02-07  Tom Tromey  <tom@tromey.com>
4741
4742         * thread.c (thread_cancel_execution_command): Update.
4743         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4744         methods.
4745         (struct thread_fsm_ops): Remove.
4746         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4747         (thread_fsm_should_stop, thread_fsm_return_value)
4748         (thread_fsm_set_finished, thread_fsm_finished_p)
4749         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4750         Don't declare.
4751         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4752         * infrun.c (clear_proceed_status_thread)
4753         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4754         (print_stop_event): Update.
4755         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4756         Add constructor.
4757         (step_command_fsm_ops): Remove.
4758         (new_step_command_fsm): Remove.
4759         (step_1): Update.
4760         (step_command_fsm::should_stop): Rename from
4761         step_command_fsm_should_stop.
4762         (step_command_fsm::clean_up): Rename from
4763         step_command_fsm_clean_up.
4764         (step_command_fsm::do_async_reply_reason): Rename from
4765         step_command_fsm_async_reply_reason.
4766         (struct until_next_fsm): Inherit from thread_fsm.  Add
4767         constructor.
4768         (until_next_fsm_ops): Remove.
4769         (new_until_next_fsm): Remove.
4770         (until_next_fsm::should_stop): Rename from
4771         until_next_fsm_should_stop.
4772         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4773         (until_next_fsm::do_async_reply_reason): Rename from
4774         until_next_fsm_async_reply_reason.
4775         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4776         constructor.  Change type of breakpoint.
4777         (finish_command_fsm_ops): Remove.
4778         (new_finish_command_fsm): Remove.
4779         (finish_command_fsm::should_stop): Rename from
4780         finish_command_fsm_should_stop.
4781         (finish_command_fsm::clean_up): Rename from
4782         finish_command_fsm_clean_up.
4783         (finish_command_fsm::return_value): Rename from
4784         finish_command_fsm_return_value.
4785         (finish_command_fsm::do_async_reply_reason): Rename from
4786         finish_command_fsm_async_reply_reason.
4787         (finish_command): Update.
4788         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4789         Add constructor.
4790         (call_thread_fsm_ops): Remove.
4791         (call_thread_fsm::call_thread_fsm): Rename from
4792         new_call_thread_fsm.
4793         (call_thread_fsm::should_stop): Rename from
4794         call_thread_fsm_should_stop.
4795         (call_thread_fsm::should_notify_stop): Rename from
4796         call_thread_fsm_should_notify_stop.
4797         (run_inferior_call, call_function_by_hand_dummy): Update.
4798         * cli/cli-interp.c (should_print_stop_to_console): Update.
4799         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4800         Add constructor.  Change type of location_breakpoint,
4801         caller_breakpoint.
4802         (until_break_fsm_ops): Remove.
4803         (new_until_break_fsm): Remove.
4804         (until_break_fsm::should_stop): Rename from
4805         until_break_fsm_should_stop.
4806         (until_break_fsm::clean_up): Rename from
4807         until_break_fsm_clean_up.
4808         (until_break_fsm::do_async_reply_reason): Rename from
4809         until_break_fsm_async_reply_reason.
4810         (until_break_command): Update.
4811         * thread-fsm.c: Remove.
4812         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4813
4814 2019-02-07  Tom Tromey  <tom@tromey.com>
4815
4816         * yy-remap.h: Add include guard.
4817         * xtensa-tdep.h: Add include guard.
4818         * xcoffread.h: Rename include guard.
4819         * varobj-iter.h: Add include guard.
4820         * tui/tui.h: Rename include guard.
4821         * tui/tui-winsource.h: Rename include guard.
4822         * tui/tui-wingeneral.h: Rename include guard.
4823         * tui/tui-windata.h: Rename include guard.
4824         * tui/tui-win.h: Rename include guard.
4825         * tui/tui-stack.h: Rename include guard.
4826         * tui/tui-source.h: Rename include guard.
4827         * tui/tui-regs.h: Rename include guard.
4828         * tui/tui-out.h: Rename include guard.
4829         * tui/tui-layout.h: Rename include guard.
4830         * tui/tui-io.h: Rename include guard.
4831         * tui/tui-hooks.h: Rename include guard.
4832         * tui/tui-file.h: Rename include guard.
4833         * tui/tui-disasm.h: Rename include guard.
4834         * tui/tui-data.h: Rename include guard.
4835         * tui/tui-command.h: Rename include guard.
4836         * tic6x-tdep.h: Add include guard.
4837         * target/waitstatus.h: Rename include guard.
4838         * target/wait.h: Rename include guard.
4839         * target/target.h: Rename include guard.
4840         * target/resume.h: Rename include guard.
4841         * target-float.h: Rename include guard.
4842         * stabsread.h: Add include guard.
4843         * rs6000-tdep.h: Add include guard.
4844         * riscv-fbsd-tdep.h: Add include guard.
4845         * regformats/regdef.h: Rename include guard.
4846         * record.h: Rename include guard.
4847         * python/python.h: Rename include guard.
4848         * python/python-internal.h: Rename include guard.
4849         * python/py-stopevent.h: Rename include guard.
4850         * python/py-ref.h: Rename include guard.
4851         * python/py-record.h: Rename include guard.
4852         * python/py-record-full.h: Rename include guard.
4853         * python/py-record-btrace.h: Rename include guard.
4854         * python/py-instruction.h: Rename include guard.
4855         * python/py-events.h: Rename include guard.
4856         * python/py-event.h: Rename include guard.
4857         * procfs.h: Add include guard.
4858         * proc-utils.h: Add include guard.
4859         * p-lang.h: Add include guard.
4860         * or1k-tdep.h: Rename include guard.
4861         * observable.h: Rename include guard.
4862         * nto-tdep.h: Rename include guard.
4863         * nat/x86-linux.h: Rename include guard.
4864         * nat/x86-linux-dregs.h: Rename include guard.
4865         * nat/x86-gcc-cpuid.h: Add include guard.
4866         * nat/x86-dregs.h: Rename include guard.
4867         * nat/x86-cpuid.h: Rename include guard.
4868         * nat/ppc-linux.h: Rename include guard.
4869         * nat/mips-linux-watch.h: Rename include guard.
4870         * nat/linux-waitpid.h: Rename include guard.
4871         * nat/linux-ptrace.h: Rename include guard.
4872         * nat/linux-procfs.h: Rename include guard.
4873         * nat/linux-osdata.h: Rename include guard.
4874         * nat/linux-nat.h: Rename include guard.
4875         * nat/linux-namespaces.h: Rename include guard.
4876         * nat/linux-btrace.h: Rename include guard.
4877         * nat/glibc_thread_db.h: Rename include guard.
4878         * nat/gdb_thread_db.h: Rename include guard.
4879         * nat/gdb_ptrace.h: Rename include guard.
4880         * nat/fork-inferior.h: Rename include guard.
4881         * nat/amd64-linux-siginfo.h: Rename include guard.
4882         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4883         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4884         * nat/aarch64-linux.h: Rename include guard.
4885         * nat/aarch64-linux-hw-point.h: Rename include guard.
4886         * mn10300-tdep.h: Add include guard.
4887         * mips-linux-tdep.h: Add include guard.
4888         * mi/mi-parse.h: Rename include guard.
4889         * mi/mi-out.h: Rename include guard.
4890         * mi/mi-main.h: Rename include guard.
4891         * mi/mi-interp.h: Rename include guard.
4892         * mi/mi-getopt.h: Rename include guard.
4893         * mi/mi-console.h: Rename include guard.
4894         * mi/mi-common.h: Rename include guard.
4895         * mi/mi-cmds.h: Rename include guard.
4896         * mi/mi-cmd-break.h: Rename include guard.
4897         * m2-lang.h: Add include guard.
4898         * location.h: Rename include guard.
4899         * linux-record.h: Rename include guard.
4900         * linux-nat.h: Add include guard.
4901         * linux-fork.h: Add include guard.
4902         * i386-darwin-tdep.h: Rename include guard.
4903         * hppa-linux-offsets.h: Add include guard.
4904         * guile/guile.h: Rename include guard.
4905         * guile/guile-internal.h: Rename include guard.
4906         * gnu-nat.h: Rename include guard.
4907         * gdb-stabs.h: Rename include guard.
4908         * frv-tdep.h: Add include guard.
4909         * f-lang.h: Add include guard.
4910         * event-loop.h: Add include guard.
4911         * darwin-nat.h: Rename include guard.
4912         * cp-abi.h: Rename include guard.
4913         * config/sparc/nm-sol2.h: Rename include guard.
4914         * config/nm-nto.h: Rename include guard.
4915         * config/nm-linux.h: Add include guard.
4916         * config/i386/nm-i386gnu.h: Rename include guard.
4917         * config/djgpp/nl_types.h: Rename include guard.
4918         * config/djgpp/langinfo.h: Rename include guard.
4919         * compile/gcc-cp-plugin.h: Add include guard.
4920         * compile/gcc-c-plugin.h: Add include guard.
4921         * compile/compile.h: Rename include guard.
4922         * compile/compile-object-run.h: Rename include guard.
4923         * compile/compile-object-load.h: Rename include guard.
4924         * compile/compile-internal.h: Rename include guard.
4925         * compile/compile-cplus.h: Rename include guard.
4926         * compile/compile-c.h: Rename include guard.
4927         * common/xml-utils.h: Rename include guard.
4928         * common/x86-xstate.h: Rename include guard.
4929         * common/version.h: Rename include guard.
4930         * common/vec.h: Rename include guard.
4931         * common/tdesc.h: Rename include guard.
4932         * common/selftest.h: Rename include guard.
4933         * common/scoped_restore.h: Rename include guard.
4934         * common/scoped_mmap.h: Rename include guard.
4935         * common/scoped_fd.h: Rename include guard.
4936         * common/safe-iterator.h: Rename include guard.
4937         * common/run-time-clock.h: Rename include guard.
4938         * common/refcounted-object.h: Rename include guard.
4939         * common/queue.h: Rename include guard.
4940         * common/ptid.h: Rename include guard.
4941         * common/print-utils.h: Rename include guard.
4942         * common/preprocessor.h: Rename include guard.
4943         * common/pathstuff.h: Rename include guard.
4944         * common/observable.h: Rename include guard.
4945         * common/netstuff.h: Rename include guard.
4946         * common/job-control.h: Rename include guard.
4947         * common/host-defs.h: Rename include guard.
4948         * common/gdb_wait.h: Rename include guard.
4949         * common/gdb_vecs.h: Rename include guard.
4950         * common/gdb_unlinker.h: Rename include guard.
4951         * common/gdb_unique_ptr.h: Rename include guard.
4952         * common/gdb_tilde_expand.h: Rename include guard.
4953         * common/gdb_sys_time.h: Rename include guard.
4954         * common/gdb_string_view.h: Rename include guard.
4955         * common/gdb_splay_tree.h: Rename include guard.
4956         * common/gdb_setjmp.h: Rename include guard.
4957         * common/gdb_ref_ptr.h: Rename include guard.
4958         * common/gdb_optional.h: Rename include guard.
4959         * common/gdb_locale.h: Rename include guard.
4960         * common/gdb_assert.h: Rename include guard.
4961         * common/filtered-iterator.h: Rename include guard.
4962         * common/filestuff.h: Rename include guard.
4963         * common/fileio.h: Rename include guard.
4964         * common/environ.h: Rename include guard.
4965         * common/common-utils.h: Rename include guard.
4966         * common/common-types.h: Rename include guard.
4967         * common/common-regcache.h: Rename include guard.
4968         * common/common-inferior.h: Rename include guard.
4969         * common/common-gdbthread.h: Rename include guard.
4970         * common/common-exceptions.h: Rename include guard.
4971         * common/common-defs.h: Rename include guard.
4972         * common/common-debug.h: Rename include guard.
4973         * common/cleanups.h: Rename include guard.
4974         * common/buffer.h: Rename include guard.
4975         * common/btrace-common.h: Rename include guard.
4976         * common/break-common.h: Rename include guard.
4977         * cli/cli-utils.h: Rename include guard.
4978         * cli/cli-style.h: Rename include guard.
4979         * cli/cli-setshow.h: Rename include guard.
4980         * cli/cli-script.h: Rename include guard.
4981         * cli/cli-interp.h: Rename include guard.
4982         * cli/cli-decode.h: Rename include guard.
4983         * cli/cli-cmds.h: Rename include guard.
4984         * charset-list.h: Add include guard.
4985         * buildsym-legacy.h: Rename include guard.
4986         * bfin-tdep.h: Add include guard.
4987         * ax.h: Rename include guard.
4988         * arm-linux-tdep.h: Add include guard.
4989         * arm-fbsd-tdep.h: Add include guard.
4990         * arch/xtensa.h: Rename include guard.
4991         * arch/tic6x.h: Add include guard.
4992         * arch/i386.h: Add include guard.
4993         * arch/arm.h: Rename include guard.
4994         * arch/arm-linux.h: Rename include guard.
4995         * arch/arm-get-next-pcs.h: Rename include guard.
4996         * arch/amd64.h: Add include guard.
4997         * arch/aarch64-insn.h: Rename include guard.
4998         * arch-utils.h: Rename include guard.
4999         * annotate.h: Add include guard.
5000         * amd64-darwin-tdep.h: Rename include guard.
5001         * aarch64-linux-tdep.h: Add include guard.
5002         * aarch64-fbsd-tdep.h: Add include guard.
5003         * aarch32-linux-nat.h: Add include guard.
5004
5005 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5006
5007         * macrotab.c (macro_define_internal): New function that
5008         factorizes macro_define_object_internal and macro_define_function
5009         code.
5010         (macro_define_object_internal): Use macro_define_internal.
5011         (macro_define_function): Likewise.
5012
5013 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5014
5015         * macrocmd.c (extract_identifier): Return
5016         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5017         callers.
5018
5019 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5020
5021         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5022
5023 2019-02-05  Tom Tromey  <tom@tromey.com>
5024
5025         * target.c (target_stack::unpush): Move assertion earlier.
5026
5027 2019-01-30  Tom Tromey  <tom@tromey.com>
5028
5029         PR python/23615:
5030         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5031         (gdbpy_parse_and_eval): Likewise.
5032         * python/python-internal.h (gdbpy_allow_threads): New class.
5033
5034 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5035
5036         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5037         (aarch64_fbsd_fpregmap): Move earlier.
5038         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5039         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5040         instead of individual calls to trad_frame_set_reg_addr.
5041         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5042         earlier.
5043         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5044         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5045         instead of individual calls to trad_frame_set_reg_addr.
5046
5047 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5048
5049         * CONTRIBUTE: Replace contribution list with wiki link.
5050
5051 2019-01-25  Tom Tromey  <tom@tromey.com>
5052
5053         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5054
5055 2019-01-25  Tom Tromey  <tom@tromey.com>
5056
5057         * xtensa-linux-nat.c: Fix common/ includes.
5058         * xml-support.h: Fix common/ includes.
5059         * xml-support.c: Fix common/ includes.
5060         * x86-linux-nat.c: Fix common/ includes.
5061         * windows-nat.c: Fix common/ includes.
5062         * varobj.h: Fix common/ includes.
5063         * varobj.c: Fix common/ includes.
5064         * value.c: Fix common/ includes.
5065         * valops.c: Fix common/ includes.
5066         * utils.c: Fix common/ includes.
5067         * unittests/xml-utils-selftests.c: Fix common/ includes.
5068         * unittests/utils-selftests.c: Fix common/ includes.
5069         * unittests/unpack-selftests.c: Fix common/ includes.
5070         * unittests/tracepoint-selftests.c: Fix common/ includes.
5071         * unittests/style-selftests.c: Fix common/ includes.
5072         * unittests/string_view-selftests.c: Fix common/ includes.
5073         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5074         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5075         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5076         * unittests/rsp-low-selftests.c: Fix common/ includes.
5077         * unittests/parse-connection-spec-selftests.c: Fix common/
5078         includes.
5079         * unittests/optional-selftests.c: Fix common/ includes.
5080         * unittests/offset-type-selftests.c: Fix common/ includes.
5081         * unittests/observable-selftests.c: Fix common/ includes.
5082         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5083         * unittests/memrange-selftests.c: Fix common/ includes.
5084         * unittests/memory-map-selftests.c: Fix common/ includes.
5085         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5086         * unittests/function-view-selftests.c: Fix common/ includes.
5087         * unittests/environ-selftests.c: Fix common/ includes.
5088         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5089         * unittests/common-utils-selftests.c: Fix common/ includes.
5090         * unittests/cli-utils-selftests.c: Fix common/ includes.
5091         * unittests/array-view-selftests.c: Fix common/ includes.
5092         * ui-file.c: Fix common/ includes.
5093         * tui/tui-io.c: Fix common/ includes.
5094         * tracepoint.h: Fix common/ includes.
5095         * tracepoint.c: Fix common/ includes.
5096         * tracefile-tfile.c: Fix common/ includes.
5097         * top.h: Fix common/ includes.
5098         * top.c: Fix common/ includes.
5099         * thread.c: Fix common/ includes.
5100         * target/waitstatus.h: Fix common/ includes.
5101         * target/waitstatus.c: Fix common/ includes.
5102         * target.h: Fix common/ includes.
5103         * target.c: Fix common/ includes.
5104         * target-memory.c: Fix common/ includes.
5105         * target-descriptions.c: Fix common/ includes.
5106         * symtab.h: Fix common/ includes.
5107         * symfile.c: Fix common/ includes.
5108         * stap-probe.c: Fix common/ includes.
5109         * spu-linux-nat.c: Fix common/ includes.
5110         * sparc-nat.c: Fix common/ includes.
5111         * source.c: Fix common/ includes.
5112         * solib.c: Fix common/ includes.
5113         * solib-target.c: Fix common/ includes.
5114         * ser-unix.c: Fix common/ includes.
5115         * ser-tcp.c: Fix common/ includes.
5116         * ser-pipe.c: Fix common/ includes.
5117         * ser-base.c: Fix common/ includes.
5118         * selftest-arch.c: Fix common/ includes.
5119         * s12z-tdep.c: Fix common/ includes.
5120         * rust-exp.y: Fix common/ includes.
5121         * rs6000-aix-tdep.c: Fix common/ includes.
5122         * riscv-tdep.c: Fix common/ includes.
5123         * remote.c: Fix common/ includes.
5124         * remote-notif.h: Fix common/ includes.
5125         * remote-fileio.h: Fix common/ includes.
5126         * remote-fileio.c: Fix common/ includes.
5127         * regcache.h: Fix common/ includes.
5128         * regcache.c: Fix common/ includes.
5129         * record-btrace.c: Fix common/ includes.
5130         * python/python.c: Fix common/ includes.
5131         * python/py-type.c: Fix common/ includes.
5132         * python/py-inferior.c: Fix common/ includes.
5133         * progspace.h: Fix common/ includes.
5134         * producer.c: Fix common/ includes.
5135         * procfs.c: Fix common/ includes.
5136         * proc-api.c: Fix common/ includes.
5137         * printcmd.c: Fix common/ includes.
5138         * ppc-linux-nat.c: Fix common/ includes.
5139         * parser-defs.h: Fix common/ includes.
5140         * osdata.c: Fix common/ includes.
5141         * obsd-nat.c: Fix common/ includes.
5142         * nat/x86-linux.c: Fix common/ includes.
5143         * nat/x86-linux-dregs.c: Fix common/ includes.
5144         * nat/x86-dregs.h: Fix common/ includes.
5145         * nat/x86-dregs.c: Fix common/ includes.
5146         * nat/ppc-linux.c: Fix common/ includes.
5147         * nat/mips-linux-watch.h: Fix common/ includes.
5148         * nat/mips-linux-watch.c: Fix common/ includes.
5149         * nat/linux-waitpid.c: Fix common/ includes.
5150         * nat/linux-ptrace.h: Fix common/ includes.
5151         * nat/linux-ptrace.c: Fix common/ includes.
5152         * nat/linux-procfs.c: Fix common/ includes.
5153         * nat/linux-personality.c: Fix common/ includes.
5154         * nat/linux-osdata.c: Fix common/ includes.
5155         * nat/linux-namespaces.c: Fix common/ includes.
5156         * nat/linux-btrace.h: Fix common/ includes.
5157         * nat/linux-btrace.c: Fix common/ includes.
5158         * nat/fork-inferior.c: Fix common/ includes.
5159         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5160         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5161         * nat/aarch64-linux.c: Fix common/ includes.
5162         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5163         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5164         * namespace.h: Fix common/ includes.
5165         * mips-linux-tdep.c: Fix common/ includes.
5166         * minsyms.c: Fix common/ includes.
5167         * mi/mi-parse.h: Fix common/ includes.
5168         * mi/mi-main.c: Fix common/ includes.
5169         * mi/mi-cmd-env.c: Fix common/ includes.
5170         * memrange.h: Fix common/ includes.
5171         * memattr.c: Fix common/ includes.
5172         * maint.h: Fix common/ includes.
5173         * maint.c: Fix common/ includes.
5174         * main.c: Fix common/ includes.
5175         * machoread.c: Fix common/ includes.
5176         * location.c: Fix common/ includes.
5177         * linux-thread-db.c: Fix common/ includes.
5178         * linux-nat.c: Fix common/ includes.
5179         * linux-fork.c: Fix common/ includes.
5180         * inline-frame.c: Fix common/ includes.
5181         * infrun.c: Fix common/ includes.
5182         * inflow.c: Fix common/ includes.
5183         * inferior.h: Fix common/ includes.
5184         * inferior.c: Fix common/ includes.
5185         * infcmd.c: Fix common/ includes.
5186         * inf-ptrace.c: Fix common/ includes.
5187         * inf-child.c: Fix common/ includes.
5188         * ia64-linux-nat.c: Fix common/ includes.
5189         * i387-tdep.c: Fix common/ includes.
5190         * i386-tdep.c: Fix common/ includes.
5191         * i386-linux-tdep.c: Fix common/ includes.
5192         * i386-linux-nat.c: Fix common/ includes.
5193         * i386-go32-tdep.c: Fix common/ includes.
5194         * i386-fbsd-tdep.c: Fix common/ includes.
5195         * i386-fbsd-nat.c: Fix common/ includes.
5196         * guile/scm-type.c: Fix common/ includes.
5197         * guile/guile.c: Fix common/ includes.
5198         * go32-nat.c: Fix common/ includes.
5199         * gnu-nat.c: Fix common/ includes.
5200         * gdbthread.h: Fix common/ includes.
5201         * gdbarch-selftests.c: Fix common/ includes.
5202         * gdb_usleep.c: Fix common/ includes.
5203         * gdb_select.h: Fix common/ includes.
5204         * gdb_bfd.c: Fix common/ includes.
5205         * gcore.c: Fix common/ includes.
5206         * fork-child.c: Fix common/ includes.
5207         * findvar.c: Fix common/ includes.
5208         * fbsd-nat.c: Fix common/ includes.
5209         * event-top.c: Fix common/ includes.
5210         * event-loop.c: Fix common/ includes.
5211         * dwarf2read.c: Fix common/ includes.
5212         * dwarf2loc.c: Fix common/ includes.
5213         * dwarf2-frame.c: Fix common/ includes.
5214         * dwarf-index-cache.c: Fix common/ includes.
5215         * dtrace-probe.c: Fix common/ includes.
5216         * disasm-selftests.c: Fix common/ includes.
5217         * defs.h: Fix common/ includes.
5218         * csky-tdep.c: Fix common/ includes.
5219         * cp-valprint.c: Fix common/ includes.
5220         * cp-support.h: Fix common/ includes.
5221         * cp-support.c: Fix common/ includes.
5222         * corelow.c: Fix common/ includes.
5223         * completer.h: Fix common/ includes.
5224         * completer.c: Fix common/ includes.
5225         * compile/compile.c: Fix common/ includes.
5226         * compile/compile-loc2c.c: Fix common/ includes.
5227         * compile/compile-cplus-types.c: Fix common/ includes.
5228         * compile/compile-cplus-symbols.c: Fix common/ includes.
5229         * command.h: Fix common/ includes.
5230         * cli/cli-dump.c: Fix common/ includes.
5231         * cli/cli-cmds.c: Fix common/ includes.
5232         * charset.c: Fix common/ includes.
5233         * build-id.c: Fix common/ includes.
5234         * btrace.h: Fix common/ includes.
5235         * btrace.c: Fix common/ includes.
5236         * breakpoint.h: Fix common/ includes.
5237         * breakpoint.c: Fix common/ includes.
5238         * ax.h:
5239         (enum agent_op): Fix common/ includes.
5240         * ax-general.c (struct aop_map): Fix common/ includes.
5241         * ax-gdb.c: Fix common/ includes.
5242         * auxv.c: Fix common/ includes.
5243         * auto-load.c: Fix common/ includes.
5244         * arm-tdep.c: Fix common/ includes.
5245         * arch/riscv.c: Fix common/ includes.
5246         * arch/ppc-linux-common.c: Fix common/ includes.
5247         * arch/i386.c: Fix common/ includes.
5248         * arch/arm.c: Fix common/ includes.
5249         * arch/arm-linux.c: Fix common/ includes.
5250         * arch/arm-get-next-pcs.c: Fix common/ includes.
5251         * arch/amd64.c: Fix common/ includes.
5252         * arch/aarch64.c: Fix common/ includes.
5253         * arch/aarch64-insn.c: Fix common/ includes.
5254         * arch-utils.c: Fix common/ includes.
5255         * amd64-windows-tdep.c: Fix common/ includes.
5256         * amd64-tdep.c: Fix common/ includes.
5257         * amd64-sol2-tdep.c: Fix common/ includes.
5258         * amd64-obsd-tdep.c: Fix common/ includes.
5259         * amd64-nbsd-tdep.c: Fix common/ includes.
5260         * amd64-linux-tdep.c: Fix common/ includes.
5261         * amd64-linux-nat.c: Fix common/ includes.
5262         * amd64-fbsd-tdep.c: Fix common/ includes.
5263         * amd64-fbsd-nat.c: Fix common/ includes.
5264         * amd64-dicos-tdep.c: Fix common/ includes.
5265         * amd64-darwin-tdep.c: Fix common/ includes.
5266         * agent.c: Fix common/ includes.
5267         * ada-lang.h: Fix common/ includes.
5268         * ada-lang.c: Fix common/ includes.
5269         * aarch64-tdep.c: Fix common/ includes.
5270
5271 2019-01-25  Tom Tromey  <tom@tromey.com>
5272
5273         * common/create-version.sh: Use common/version.h.
5274
5275 2019-01-24  Pedro Alves  <palves@redhat.com>
5276
5277         * infrun.c (signal_stop, signal_print, signal_program)
5278         (signal_catch, signal_pass): Now arrays instead of pointers.
5279         (update_signals_program_target, do_target_resume)
5280         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5281         * linux-nat.c (linux_nat_target::pass_signals)
5282         (linux_nat_target::create_inferior, linux_nat_target::attach):
5283         Adjust.
5284         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5285         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5286         * procfs.c (procfs_target::pass_signals): Adjust.
5287         * record-full.c (record_full_target::resume): Adjust.
5288         * remote.c (remote_target::pass_signals)
5289         (remote_target::program_signals): Adjust.
5290         * target-debug.h (target_debug_print_signals): Now takes a
5291         gdb::array_view as parameter.  Adjust.
5292         * target.h (target_ops) <pass_signals, program_signals>: Replace
5293         pointer and length parameters with gdb::array_view.
5294         (target_pass_signals, target_program_signals): Likewise.
5295         * target-delegates.c: Regenerate.
5296
5297 2019-01-24  Pedro Alves  <palves@redhat.com>
5298
5299         * common/forward-scope-exit.h
5300         (forward_scope_exit::forward_scope_exit): Pass arguments to
5301         m_bind_function directly, instead of creating a std::bind and
5302         copying that.
5303
5304 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5305
5306         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5307         for static members.
5308         (pass_in_v_vfp_candidate): Likewise.
5309
5310 2019-01-23  Tom Tromey  <tom@tromey.com>
5311             Pedro Alves  <palves@redhat.com>
5312
5313         * regcache.c (class regcache_invalidator): Remove.
5314         (regcache::raw_write): Use make_scope_exit.
5315
5316 2019-01-23  Tom Tromey  <tom@tromey.com>
5317
5318         * ui-out.h (class ui_out_emit_type): Update comment.
5319
5320 2019-01-23  Tom Tromey  <tom@tromey.com>
5321
5322         * infrun.c (fetch_inferior_event): Update comment.
5323
5324 2019-01-23  Tom Tromey  <tom@tromey.com>
5325             Pedro Alves  <palves@redhat.com>
5326
5327         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5328         parameter.
5329         (fetch_inferior_event): Use SCOPE_EXIT.
5330
5331
5332 2019-01-23  Tom Tromey  <tom@tromey.com>
5333             Pedro Alves  <palves@redhat.com>
5334
5335         * infrun.c (disable_thread_events): Delete.
5336         (stop_all_threads): Use SCOPE_EXIT.
5337
5338 2019-01-23  Tom Tromey  <tom@tromey.com>
5339             Pedro Alves  <palves@redhat.com>
5340
5341         * symfile.c: Include forward-scope-exit.h.
5342         (clear_symtab_users_cleanup): Replace forward declaration with
5343         a FORWARD_SCOPE_EXIT.
5344         (syms_from_objfile_1): Use the forward_scope_exit and
5345         gdb::optional instead of cleanup_function.
5346         (reread_symbols): Use the forward_scope_exit instead of
5347         cleanup_function.
5348         (clear_symtab_users_cleanup): Remove function.
5349
5350 2019-01-23  Tom Tromey  <tom@tromey.com>
5351             Pedro Alves  <palves@redhat.com>
5352
5353         * linux-nat.c: Include scope-exit.h.
5354         (cleanup_target_stop): Remove.
5355         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5356         SCOPE_EXIT.
5357
5358 2019-01-23  Tom Tromey  <tom@tromey.com>
5359             Pedro Alves  <palves@redhat.com>
5360
5361         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5362         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5363
5364 2019-01-23  Tom Tromey  <tom@tromey.com>
5365             Andrew Burgess  <andrew.burgess@embecosm.com>
5366             Pedro Alves  <palves@redhat.com>
5367
5368         * infrun.c (fetch_inferior_event): Use scope_exit.
5369         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5370         * top.c (execute_command): Use scope_exit.
5371         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5372         * utils.c (do_bpstat_clear_actions_cleanup)
5373         (make_bpstat_clear_actions_cleanup): Remove.
5374
5375 2019-01-23  Tom Tromey  <tom@tromey.com>
5376             Pedro Alves  <palves@redhat.com>
5377
5378         * infrun.c: Include "common/scope-exit.h"
5379         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5380         (wait_for_inferior): Use SCOPE_EXIT.
5381         (fetch_inferior_event): Use scope_exit.
5382
5383 2019-01-23  Tom Tromey  <tom@tromey.com>
5384             Pedro Alves  <palves@redhat.com>
5385
5386         * breakpoint.c (create_breakpoint): Remove cleanup.
5387
5388 2019-01-23  Tom Tromey  <tom@tromey.com>
5389             Andrew Burgess  <andrew.burgess@embecosm.com>
5390             Pedro Alves  <palves@redhat.com>
5391
5392 2019-01-23  Pedro Alves  <palves@redhat.com>
5393
5394         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5395
5396 2019-01-23  Pedro Alves  <palves@redhat.com>
5397             Andrew Burgess  <andrew.burgess@embecosm.com>
5398
5399         * gdbthread.h: Include "common/forward-scope-exit.h".
5400         (scoped_finish_thread_state): Redefine custom class in terms of
5401         forward_scope_exit.
5402
5403 2019-01-23  Pedro Alves  <palves@redhat.com>
5404             Andrew Burgess  <andrew.burgess@embecosm.com>
5405
5406         * common/forward-scope-exit.h: New file.
5407
5408 2019-01-23  Pedro Alves  <palves@redhat.com>
5409             Andrew Burgess  <andrew.burgess@embecosm.com>
5410             Tom Tromey  <tom@tromey.com>
5411
5412         * common/scope-exit.h: New file.
5413
5414 2019-01-23  Pedro Alves  <palves@redhat.com>
5415
5416         * common/preprocessor.h (ESC): Rename to ...
5417         (ESC_PARENS): ... this.
5418         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5419         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5420
5421 2019-01-23  Tom Tromey  <tom@tromey.com>
5422
5423         * language.h (class scoped_switch_to_sym_language_if_auto):
5424         Initialize m_lang in both cases.
5425
5426 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5427
5428         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5429         with XCNEW.
5430
5431 2019-01-22  Tom Tromey  <tom@tromey.com>
5432
5433         * corelow.c: Do not include sys/file.h.
5434
5435 2019-01-22  Tom Tromey  <tom@tromey.com>
5436
5437         * tui/tui-wingeneral.h: Include gdb_curses.h.
5438
5439 2019-01-22  Tom Tromey  <tom@tromey.com>
5440
5441         * source-cache.h (class source_cache) <get_source_lines,
5442         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5443
5444 2019-01-22  Tom Tromey  <tom@tromey.com>
5445
5446         * remote-fileio.h (struct remote_target): Declare.
5447
5448 2019-01-22  Tom Tromey  <tom@tromey.com>
5449
5450         * python/py-arch.c: Do not include py-ref.h.
5451         * python/py-bpevent.c: Do not include py-ref.h.
5452         * python/py-cmd.c: Do not include py-ref.h.
5453         * python/py-continueevent.c: Do not include py-ref.h.
5454         * python/py-event.h: Do not include py-ref.h.
5455         * python/py-evtregistry.c: Do not include py-ref.h.
5456         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5457         * python/py-frame.c: Do not include py-ref.h.
5458         * python/py-framefilter.c: Do not include py-ref.h.
5459         * python/py-function.c: Do not include py-ref.h.
5460         * python/py-infevents.c: Do not include py-ref.h.
5461         * python/py-linetable.c: Do not include py-ref.h.
5462         * python/py-objfile.c: Do not include py-ref.h.
5463         * python/py-param.c: Do not include py-ref.h.
5464         * python/py-prettyprint.c: Do not include py-ref.h.
5465         * python/py-progspace.c: Do not include py-ref.h.
5466         * python/py-symbol.c: Do not include py-ref.h.
5467         * python/py-symtab.c: Do not include py-ref.h.
5468         * python/py-type.c: Do not include py-ref.h.
5469         * python/py-unwind.c: Do not include py-ref.h.
5470         * python/py-utils.c: Do not include py-ref.h.
5471         * python/py-value.c: Do not include py-ref.h.
5472         * python/py-varobj.c: Do not include py-ref.h.
5473         * python/py-xmethods.c: Do not include py-ref.h.
5474         * python/python.c: Do not include py-ref.h.
5475         * varobj.c: Do not include py-ref.h.
5476
5477 2019-01-22  Tom Tromey  <tom@tromey.com>
5478
5479         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5480         keyword for bcache.
5481
5482 2019-01-22  Tom Tromey  <tom@tromey.com>
5483
5484         * compile/compile-cplus-types.c: Remove a comment by #include.
5485
5486 2019-01-22  Tom Tromey  <tom@tromey.com>
5487
5488         * compile/gcc-c-plugin.h: Include compile-internal.h.
5489
5490 2019-01-22  Tom Tromey  <tom@tromey.com>
5491
5492         * stabsread.c (EXTERN): Do not define.
5493         (symnum, next_symbol_text_func, processing_gcc_compilation)
5494         (within_function, global_sym_chain, global_stabs)
5495         (previous_stab_code, this_object_header_files)
5496         (n_this_object_header_files)
5497         (n_allocated_this_object_header_files): Define.
5498         * stabsread.h (EXTERN): Never define.  Use "extern".
5499
5500 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5501
5502         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5503         history_value.
5504
5505 2019-01-21  Tom Tromey  <tom@tromey.com>
5506
5507         * ui-out.c: Fix includes.
5508         * tui/tui-source.c: Fix includes.
5509         * target.c: Fix includes.
5510         * remote.c: Fix includes.
5511         * regcache.c: Fix includes.
5512         * python/py-block.c: Fix includes.
5513         * printcmd.c: Fix includes.
5514         * or1k-tdep.c: Fix includes.
5515         * mi/mi-main.c: Fix includes.
5516         * m32r-tdep.c: Fix includes.
5517         * csky-tdep.c: Fix includes.
5518         * compile/compile-cplus-types.c: Fix includes.
5519         * cli/cli-interp.c: Fix includes.
5520
5521 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5522
5523         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5524         for padding.
5525
5526 2019-01-16  Tom Tromey  <tom@tromey.com>
5527
5528         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5529         earlier.
5530         (struct objfile) <msymbols_range>: Move from top level.
5531         <msymbols>: New method.
5532         (class objfile_msymbols): Remove.
5533         * symtab.c (default_collect_symbol_completion_matches_break_on):
5534         Update.
5535         * symmisc.c (dump_msymbols): Update.
5536         * stabsread.c (scan_file_globals): Update.
5537         * objc-lang.c (info_selectors_command, info_classes_command)
5538         (find_methods): Update.
5539         * minsyms.c (find_solib_trampoline_target): Update.
5540         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5541         * coffread.c (coff_symfile_read): Update.
5542         * ada-lang.c (ada_lookup_simple_minsym)
5543         (ada_collect_symbol_completion_matches): Update.
5544
5545 2019-01-16  Tom Tromey  <tom@tromey.com>
5546
5547         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5548         type.  Remove no-argument constructor.
5549         <iterator::operator++>: Simplify.
5550         <begin>: Update.
5551         <end>: Use minimal_symbol_count.
5552
5553 2019-01-16  Tom Tromey  <tom@tromey.com>
5554
5555         * objfiles.h (struct objfile) <psymtabs>: New method.
5556         (class objfile_psymtabs): Remove.
5557         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5558         typedef.
5559         <range>: New method.
5560         (require_partial_symbols): Change return type.
5561         * psymtab.c (require_partial_symbols)
5562         (psym_expand_symtabs_matching): Update.
5563         * mdebugread.c (parse_partial_symbols): Update.
5564         * dbxread.c (dbx_end_psymtab): Update.
5565
5566 2019-01-15  Tom Tromey  <tom@tromey.com>
5567
5568         * symtab.c (lookup_objfile_from_block)
5569         (lookup_symbol_in_objfile_symtabs)
5570         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5571         (find_line_symtab, info_sources_command)
5572         (default_collect_symbol_completion_matches_break_on)
5573         (make_source_files_completion_list): Update.
5574         * symmisc.c (print_objfile_statistics, dump_objfile)
5575         (maintenance_print_symbols, maintenance_info_symtabs)
5576         (maintenance_check_symtabs, maintenance_info_line_tables):
5577         Update.
5578         * source.c (select_source_symtab)
5579         (forget_cached_source_info_for_objfile): Update.
5580         * objfiles.h (class objfile_compunits): Remove.
5581         (struct objfile) <compunits_range>: New typedef.
5582         (compunits): New method.
5583         * objfiles.c (objfile_relocate1): Update.
5584         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5585         * maint.c (count_symtabs_and_blocks): Update.
5586         * linespec.c (iterate_over_all_matching_symtabs): Update.
5587         * cp-support.c (add_symbol_overload_list_qualified): Update.
5588         * coffread.c (coff_symtab_read): Update.
5589         * ada-lang.c (add_nonlocal_symbols)
5590         (ada_collect_symbol_completion_matches)
5591         (ada_add_global_exceptions): Update.
5592
5593 2019-01-15  Tom Tromey  <tom@tromey.com>
5594
5595         * progspace.h (program_space) <objfiles_safe_range>: New
5596         typedef.
5597         <objfiles_safe>: New method.
5598         * objfiles.h (class all_objfiles_safe): Remove.
5599         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5600         * jit.c (jit_inferior_exit_hook): Update.
5601
5602 2019-01-17  Tom Tromey  <tom@tromey.com>
5603
5604         * progspace.h (program_space) <objfiles_range>: New typedef.
5605         <objfiles>: New method.
5606         <objfiles_head>: Rename from objfiles.
5607         (object_files): Update.
5608         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5609         * guile/scm-pretty-print.c
5610         (ppscm_find_pretty_printer_from_objfiles): Update.
5611         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5612         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5613         Update.
5614         * python/py-progspace.c (pspy_get_objfiles): Update.
5615         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5616         Update.
5617         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5618         (objfpy_lookup_objfile_by_build_id): Update.
5619         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5620         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5621         Update.
5622         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5623         (expand_symtab_containing_pc, lookup_objfile_from_block)
5624         (lookup_static_symbol, basic_lookup_transparent_type)
5625         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5626         (find_line_symtab, info_sources_command)
5627         (default_collect_symbol_completion_matches_break_on)
5628         (make_source_files_completion_list, find_main_name): Update.
5629         * symmisc.c (print_symbol_bcache_statistics)
5630         (print_objfile_statistics, maintenance_print_symbols)
5631         (maintenance_print_msymbols, maintenance_print_objfiles)
5632         (maintenance_info_symtabs, maintenance_check_symtabs)
5633         (maintenance_expand_symtabs, maintenance_info_line_tables):
5634         Update.
5635         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5636         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5637         (map_overlay_command, unmap_overlay_command)
5638         (simple_overlay_update, expand_symtabs_matching)
5639         (map_symbol_filenames): Update.
5640         * symfile-debug.c (set_debug_symfile): Update.
5641         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5642         Update.
5643         * source.c (select_source_symtab, forget_cached_source_info):
5644         Update.
5645         * solib.c (solib_read_symbols): Update.
5646         * solib-spu.c (append_ocl_sos): Update.
5647         * psymtab.c (maintenance_print_psymbols)
5648         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5649         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5650         * printcmd.c (info_symbol_command): Update.
5651         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5652         Update.
5653         * objfiles.h (class all_objfiles): Remove.
5654         * objfiles.c (have_partial_symbols, have_full_symbols)
5655         (have_minimal_symbols, qsort_cmp, update_section_map)
5656         (shared_objfile_contains_address_p)
5657         (default_iterate_over_objfiles_in_search_order): Update.
5658         * objc-lang.c (info_selectors_command, info_classes_command)
5659         (find_methods): Update.
5660         * minsyms.c (find_solib_trampoline_target): Update.
5661         * maint.c (maintenance_info_sections)
5662         (maintenance_translate_address, count_symtabs_and_blocks):
5663         Update.
5664         * main.c (captured_main_1): Update.
5665         * linux-thread-db.c (try_thread_db_load_from_pdir)
5666         (has_libpthread): Update.
5667         * linespec.c (iterate_over_all_matching_symtabs)
5668         (search_minsyms_for_name): Update.
5669         * jit.c (jit_find_objf_with_entry_addr): Update.
5670         * hppa-tdep.c (find_unwind_entry)
5671         (hppa_lookup_stub_minimal_symbol): Update.
5672         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5673         Update.
5674         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5675         (elf_gnu_ifunc_resolve_by_got): Update.
5676         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5677         * dwarf-index-write.c (save_gdb_index_command): Update.
5678         * cp-support.c (add_symbol_overload_list_qualified): Update.
5679         * breakpoint.c (create_overlay_event_breakpoint)
5680         (create_longjmp_master_breakpoint)
5681         (create_std_terminate_master_breakpoint)
5682         (create_exception_master_breakpoint): Update.
5683         * blockframe.c (find_pc_partial_function): Update.
5684         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5685         (ada_collect_symbol_completion_matches)
5686         (ada_add_global_exceptions): Update.
5687
5688 2019-01-17  Tom Tromey  <tom@tromey.com>
5689
5690         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5691         declare VEC.
5692         (solib_target_parse_libraries): Change return type.
5693         (library_list_start_segment, library_list_start_section)
5694         (library_list_end_library, library_list_start_library); Update.
5695         (solib_target_free_library_list): Remove.
5696         (solib_target_parse_libraries): Remove cleanup.  Change return
5697         type.
5698         (solib_target_current_sos): Update.
5699
5700 2019-01-17  Tom Tromey  <tromey@bapiya>
5701
5702         * valprint.c: Replace "the the" with "the".
5703         * symtab.c: Replace "the the" with "the".
5704         * solib.c: Replace "the the" with "the".
5705         * solib-dsbt.c: Replace "the the" with "the".
5706         * linespec.c: Replace "the the" with "the".
5707         * dwarf2loc.h: Replace "the the" with "the".
5708         * amd64-windows-tdep.c: Replace "the the" with "the".
5709         * aarch64-tdep.c: Replace "the the" with "the".
5710
5711 2019-01-16  Keith Seitz  <keiths@redhat.com>
5712
5713         PR gdb/23773
5714         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5715         <builder>: Rename to ..
5716         <m_builder>: ... this and make private.
5717         (dwarf2_cu::get_builder): New method.  Change all users of
5718         `builder' to use this method.
5719         (dwarf2_start_symtab): Move to ...
5720         (dwarf2_cu::start_symtab): ... here.  Update all callers
5721         (setup_type_unit_groups): Move to ...
5722         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5723         callers.
5724         (dwarf2_cu::reset_builder): New method.
5725         (process_full_compunit, process_full_type_unit): Use
5726         dwarf2_cu::reset_builder.
5727         (follow_die_offset): Record the ancestor CU if it is different
5728         from the followed DIE's CU.
5729         (follow_die_sig_1): Likewise.
5730
5731 2019-01-15  Tom Tromey  <tom@tromey.com>
5732
5733         * remote.c (class remote_state) <buf>: Now a char_vector.
5734         <buf_size>: Remove.
5735         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5736         parameter.
5737         (remote_target::getpkt_or_notif_sane_1)
5738         (remote_target::getpkt_sane)
5739         (remote_target::getpkt_or_notif_sane): Likewise.
5740         (class remote_target) <putpkt>: New overload.
5741         (remote_target::read_frame): Change type of "buf_p".  Remove
5742         sizeof_p parameter.
5743         (packet_ok): New overload.
5744         (packet_check_result): New overload.
5745         Update all uses.
5746
5747 2019-01-14  Tom Tromey  <tom@tromey.com>
5748
5749         * remote-notif.c (handle_notification, remote_notif_ack)
5750         (remote_notif_parse): Make "buf" const.
5751         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5752         const.
5753         (remote_notif_parse, remote_notif_ack, handle_notification):
5754         Likewise.
5755         * remote.c (remote_notif_stop_parse): Make "buf" const.
5756         (remote_target::remote_parse_stop_reply): Make "buf" const.
5757         (remote_notif_stop_ack): Make "buf" const.
5758
5759 2019-01-14  Tom Tromey  <tom@tromey.com>
5760
5761         * remote.c (remote_console_output): Make parameter const.
5762
5763 2019-01-14  Tom Tromey  <tom@tromey.com>
5764
5765         * target-debug.h (target_debug_print_signals): Constify.
5766         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5767         * procfs.c (procfs_target::pass_signals): Update.
5768         * linux-nat.c (linux_nat_target::pass_signals): Update.
5769         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5770         * target-delegates.c: Rebuild.
5771         * remote.c (remote_target::program_signals): Update.
5772         (remote_target::pass_signals): Update.
5773         * target.c (target_pass_signals): Constify argument.
5774         (target_program_signals): Likewise.
5775         * target.h (struct target_ops) <pass_signals, program_signals>:
5776         Constify argument.
5777         (target_pass_signals, target_program_signals): Constify argument.
5778
5779 2019-01-14  Tom Tromey  <tom@tromey.com>
5780
5781         PR tui/28819:
5782         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5783
5784 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5785
5786         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5787         field.
5788         * rs6000-tdep.c: Include reggroups.h.
5789         (IS_V_ALIAS_PSEUDOREG): Define.
5790         (rs6000_register_name): Return names for the "vX" aliases.
5791         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5792         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5793         aliases.  Call default_register_reggroup_p for all other
5794         pseudo-registers.
5795         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5796         New functions.
5797         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5798         Handle "vX" aliases.
5799         (v_alias_pseudo_register_collect): New function.
5800         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5801         (rs6000_gdbarch_init): Initialize "vX" aliases as
5802         pseudo-registers.  Restore registration of
5803         rs6000_pseudo_register_reggroup_p with
5804         set_tdesc_pseudo_register_reggroup_p.
5805
5806 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5807
5808         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5809         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5810         set_gdbarch_num_pseudo_regs.
5811
5812 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5813
5814         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5815         Remove arg prefixname, add do_set and do_show.
5816         Add member functions set_list and show_list.
5817         * cli/cli-style.c (class cli_style_option): Update accordingly.
5818         (style_set_list): Move to file scope.
5819         (style_show_list): Likewise.
5820         (set_style): Call help_list.
5821         (show_style): Call cmd_show_list.
5822         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5823         Update to use the new macro.
5824
5825 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5826
5827         * ada-lang.c (_initialize_ada_language): Expand the help text
5828         for the "catch exception" command.
5829
5830 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5831
5832         * symtab.c (matching_obj_sections): Initialize obj,
5833         declare it closer to its usage.
5834
5835 2019-01-10  Tom Tromey  <tom@tromey.com>
5836
5837         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5838         (basic_inf_threads_range): Remove.
5839         (inf_threads_range, inf_non_exited_threads_range)
5840         (safe_inf_threads_range): Use next_adapter.
5841
5842 2019-01-10  Keith Seitz  <keiths@redhat.com>
5843
5844         PR gdb/23712
5845         PR symtab/23010
5846         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5847         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5848
5849 2019-01-10  Keith Seitz  <keiths@redhat.com>
5850
5851         PR gdb/23712
5852         PR symtab/23010
5853         * dictionary.c (pending_to_vector): Remove.
5854         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5855         Remove _1 suffix, replacing functions of the same name.  Update
5856         all callers.
5857         (dict_create_hashed, dict_create_hashed_expandable)
5858         (dict_create_linear, dict_create_linear_expandable, dict_free)
5859         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5860         Make functions static.
5861
5862 2019-01-10  Keith Seitz  <keiths@redhat.com>
5863
5864         PR gdb/23712
5865         PR symtab/23010
5866         * dictionary.h (struct dictionary): Replace declaration with
5867         multidictionary.
5868         (dict_create_hashed, dict_create_hashed_expandable)
5869         (dict_create_linear, dict_create_linear_expandable)
5870         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5871         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5872         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5873         taking multidictionary argument.
5874         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5875         * block.h (struct block) <dict>: Change to multidictionary
5876         and rename `multidict'.
5877         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5878         symmisc.c: Update all dictionary references to multidictionary.
5879
5880 2019-01-10  Keith Seitz  <keiths@redhat.com>
5881
5882         PR gdb/23712
5883         PR symtab/23010
5884         * dictionary.c: Include unordered_map.
5885         (pending_to_vector): New function.
5886         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5887         Rewrite the non-"_1" functions to take vector instead
5888         of linked list.
5889         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5890         "new" _1 versions of the same name.
5891         (multidictionary): Define.
5892         (std::hash<enum language): New definition.
5893         (collate_pending_symbols_by_language, mdict_create_hashed)
5894         (mdict_create_hashed_expandable, mdict_create_linear)
5895         (mdict_create_linear_expandable, mdict_free)
5896         (find_language_dictionary, create_new_language_dictionary)
5897         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5898         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5899         (mdict_size, mdict_empty): New functions.
5900         * dictionary.h (mdict_iterator): Define.
5901
5902 2019-01-10  Pedro Alves  <palves@redhat.com>
5903
5904         * breakpoint.c (read_uploaded_action)
5905         (create_tracepoint_from_upload): Adjust to use
5906         gdb::unique_xmalloc_ptr.
5907         * ctf.c (ctf_write_uploaded_tp):
5908         (SET_ARRAY_FIELD): Use emplace_back.
5909         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5910         * tracefile-tfile.c (tfile_write_uploaded_tp):
5911         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5912         gdb::unique_xmalloc_ptr.
5913         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5914         at_string, cond_string, cmd_strings>: Replace char pointers
5915         with gdb::unique_xmalloc_ptr.
5916
5917 2019-01-10  Pedro Alves  <palves@redhat.com>
5918
5919         * solib-target.c (library_list_start_library): Don't xstrdup name.
5920
5921 2019-01-10  Pedro Alves  <palves@redhat.com>
5922
5923         * mdebugread.c (parse_partial_symbols): Use
5924         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5925
5926 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5927
5928         * linux-fork.c (scoped_switch_fork_info)
5929         <~scoped_switch_fork_info>: Fix incorrect variable name.
5930
5931 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5932
5933         * linux-fork.c (scoped_switch_fork_info)
5934         <scoped_switch_fork_info>: Make explicit.
5935         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5936
5937 2019-01-10  Tom Tromey  <tom@tromey.com>
5938
5939         * objfiles.h (objfile::reset_psymtabs): Update.
5940         * objfiles.c (objfile::objfile): Update.
5941         * psymtab.h (psymtab_storage::obstack): Update.
5942         (psymtab_storage::m_obstack): Use gdb::optional.
5943         (class psymtab_storage): Update comment.  Remove objfile
5944         parameter.
5945         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5946
5947 2019-01-10  Tom Tromey  <tom@tromey.com>
5948
5949         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5950         <free_psymtabs>: Now private.
5951         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5952         (allocate_psymtab): Use new method.
5953
5954 2019-01-10  Tom Tromey  <tom@tromey.com>
5955
5956         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5957         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5958         * mdebugread.c (parse_partial_symbols): Use
5959         allocate_dependencies.
5960         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5961         allocate_dependencies.
5962         (process_psymtab_comp_unit_reader)
5963         (build_type_psymtab_dependencies): Likewise.
5964         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5965
5966 2019-01-10  Tom Tromey  <tom@tromey.com>
5967
5968         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5969         PSYMBOL_SET_LANGUAGE.
5970         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5971
5972 2019-01-10  Tom Tromey  <tom@tromey.com>
5973
5974         * psymtab.h (psymtab_storage::obstack): New method.
5975         <m_obstack>: Rename from obstack; now private.
5976         * psymtab.c (psymtab_storage): Update.
5977         * dwarf2read.c (create_addrmap_from_index)
5978         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5979         Update.
5980
5981 2019-01-10  Tom Tromey  <tom@tromey.com>
5982
5983         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5984         * objfiles.h (objfile::reset_psymtabs): New method.
5985
5986 2019-01-10  Tom Tromey  <tom@tromey.com>
5987
5988         * symmisc.c (print_symbol_bcache_statistics): Update.
5989         (print_objfile_statistics): Update.
5990         * symfile.c (reread_symbols): Update.
5991         * psymtab.h (class psymtab_storage): New.
5992         * psymtab.c (psymtab_storage): New constructor.
5993         (~psymtab_storage): New destructor.
5994         (require_partial_symbols): Update.
5995         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5996         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5997         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5998         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5999         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
6000         (start_psymtab_common, end_psymtab_common)
6001         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
6002         (allocate_psymtab): Update.
6003         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
6004         Update.
6005         (dump_psymtab_addrmap, maintenance_print_psymbols)
6006         (maintenance_check_psymtabs): Update.
6007         (class objfile_psymtabs): Move to objfiles.h.
6008         * psympriv.h (discard_psymtab): Now inline.
6009         (psymtab_discarder::psymtab_discarder): Update.
6010         (psymtab_discarder::~psymtab_discarder): Update.
6011         (ALL_OBJFILE_PSYMTABS): Rewrite.
6012         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6013         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6014         Remove fields.
6015         <partial_symtabs>: New field.
6016         (class objfile_psymtabs): Move from psymtab.h.  Update.
6017         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6018         psymbol_cache.
6019         (objfile::~objfile): Don't destroy psymbol_cache.
6020         * mdebugread.c (parse_partial_symbols): Update.
6021         * dwarf2read.c (create_addrmap_from_index)
6022         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6023         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6024         (add_partial_subprogram, dwarf2_ranges_read): Update.
6025         * dwarf-index-write.c (write_address_map)
6026         (write_one_signatured_type, recursively_write_psymbols)
6027         (class debug_names, class debug_names, write_psymtabs_to_index):
6028         Update.
6029
6030 2019-01-10  Tom Tromey  <tom@tromey.com>
6031
6032         * symtab.h (SYMBOL_SET_NAMES): Update.
6033         (symbol_set_names): Update.
6034         (MSYMBOL_SET_NAMES): Update.
6035         * symtab.c (symbol_set_names): Change argument to be an
6036         objfile_per_bfd_storage.
6037         * psymtab.c (add_psymbol_to_bcache): Update.
6038         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6039
6040 2019-01-10  Tom Tromey  <tom@tromey.com>
6041
6042         * symtab.c (create_demangled_names_hash): Change argument to be an
6043         objfile_per_bfd_storage.
6044         (symbol_set_names): Update.
6045
6046 2019-01-10  Tom Tromey  <tom@tromey.com>
6047
6048         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6049         init_psymbol_list.
6050         * psymtab.c (init_psymbol_list): Do nothing if already called.
6051         * psympriv.h (init_psymbol_list): Add comment.
6052         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6053         init_psymbol_list.
6054         * dbxread.c (dbx_symfile_read): Unconditionally call
6055         init_psymbol_list.
6056
6057 2019-01-10  Tom Tromey  <tom@tromey.com>
6058
6059         * xcoffread.c (scan_xcoff_symtab): Update.
6060         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6061         "where".
6062         * mdebugread.c (parse_partial_symbols)
6063         (handle_psymbol_enumerators): Update.
6064         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6065         * dbxread.c (read_dbx_symtab): Update.
6066         * psympriv.h (psymbol_placement): New enum.
6067         (add_psymbol_to_list): Update.
6068
6069 2019-01-10  Tom Tromey  <tom@tromey.com>
6070
6071         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6072         static_psymbols parameters.
6073         (scan_xcoff_symtab): Update.
6074         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6075         static_psymbols parameters.
6076         * psympriv.h (start_psymtab_common): Update.
6077         * mdebugread.c (parse_partial_symbols): Update.
6078         * dwarf2read.c (create_partial_symtab): Update.
6079         * dbxread.c (read_dbx_symtab): Update.
6080         (start_psymtab): Remove global_psymbols and static_psymbols
6081         parameters.
6082
6083 2019-01-10  Tom Tromey  <tom@tromey.com>
6084
6085         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6086         * psymtab.c (allocate_psymtab): Add comment.
6087         * psympriv.h (allocate_psymtab): Add comment.
6088         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6089         initializations.
6090         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6091
6092 2019-01-10  Tom Tromey  <tom@tromey.com>
6093
6094         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6095         Don't declare.
6096         * mipsread.c: Include mdebugread.h.
6097         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6098         Declare.
6099         * elfread.c: Include mdebugread.h.
6100
6101 2019-01-09  Tom Tromey  <tom@tromey.com>
6102
6103         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6104         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6105         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6106         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6107         (psym_lookup_symbol, psym_find_last_source_symtab)
6108         (psym_forget_cached_source_info, psym_print_stats)
6109         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6110         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6111         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6112         (psym_find_compunit_symtab_by_address)
6113         (maintenance_print_psymbols, maintenance_info_psymtabs)
6114         (maintenance_check_psymtabs): Use ranged for.
6115         * psymtab.h (class objfile_psymtabs): New.
6116         (require_partial_symbols): Return objfile_psymtabs.
6117         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6118
6119 2019-01-09  Tom Tromey  <tom@tromey.com>
6120
6121         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6122         (find_pc_mapped_section, list_overlays_command)
6123         (map_overlay_command, unmap_overlay_command)
6124         (simple_overlay_update): Use all_objfiles.
6125         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6126         * printcmd.c (info_symbol_command): Use all_objfiles.
6127         * objfiles.h (ALL_OBJSECTIONS): Remove.
6128         * maint.c (maintenance_translate_address): Use all_objfiles.
6129         * gcore.c (gcore_create_callback): Use all_objfiles.
6130         (objfile_find_memory_regions): Likewise.
6131
6132 2019-01-09  Tom Tromey  <tom@tromey.com>
6133
6134         * symtab.c (find_line_symtab, info_sources_command)
6135         (make_source_files_completion_list): Use objfile_compunits.
6136         * source.c (select_source_symtab): Use objfile_compunits.
6137         * objfiles.h (struct objfile): Update comment.
6138         (ALL_OBJFILES): Remove.
6139         (ALL_FILETABS): Remove.
6140         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6141         objfile_compunits.
6142
6143 2019-01-09  Tom Tromey  <tom@tromey.com>
6144
6145         * symmisc.c (print_objfile_statistics, dump_objfile)
6146         (maintenance_print_symbols): Use compunit_filetabs.
6147         * source.c (forget_cached_source_info_for_objfile): Use
6148         compunit_filetabs.
6149         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6150         (ALL_FILETABS): Use compunit_filetabs.
6151         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6152         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6153
6154 2019-01-09  Tom Tromey  <tom@tromey.com>
6155
6156         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6157         (compunit_filetabs): New.
6158         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6159         compunit_filetabs.
6160         (info_sources_command, make_source_files_completion_list): Remove
6161         declaration.
6162         * symmisc.c (print_objfile_statistics, dump_objfile)
6163         (maintenance_print_symbols): Remove declaration.
6164         (maintenance_info_symtabs): Use compunit_filetabs.
6165         (maintenance_info_line_tables): Likewise.
6166         * source.c (select_source_symtab): Change local variable name.
6167         (forget_cached_source_info_for_objfile): Remove declaration.
6168         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6169         * objfiles.c (objfile_relocate1): Remove declaration.
6170         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6171         declaration.
6172         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6173         * coffread.c (coff_symtab_read): Remove declaration.
6174         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6175         compunit_filetabs.
6176
6177 2019-01-09  Tom Tromey  <tom@tromey.com>
6178
6179         * symtab.c (lookup_objfile_from_block)
6180         (find_pc_sect_compunit_symtab, search_symbols)
6181         (default_collect_symbol_completion_matches_break_on): Use
6182         objfile_compunits.
6183         * objfiles.h (ALL_COMPUNITS): Remove.
6184         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6185         * cp-support.c (add_symbol_overload_list_qualified): Use
6186         objfile_compunits.
6187         * ada-lang.c (ada_collect_symbol_completion_matches)
6188         (ada_add_global_exceptions): Use objfile_compunits.
6189
6190 2019-01-09  Tom Tromey  <tom@tromey.com>
6191
6192         * source.c (select_source_symtab)
6193         (forget_cached_source_info_for_objfile): Remove declaration.
6194         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6195         declaration.
6196         * maint.c (count_symtabs_and_blocks): Remove declaration.
6197         * cp-support.c (add_symbol_overload_list_qualified): Remove
6198         declaration.
6199         * coffread.c (coff_symtab_read): Remove declaration.
6200         * symtab.c (lookup_symbol_in_objfile_symtabs)
6201         (basic_lookup_transparent_type_1): Use objfile_compunits.
6202         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6203         (info_sources_command, search_symbols)
6204         (default_collect_symbol_completion_matches_break_on)
6205         (make_source_files_completion_list): Remove declaration.
6206         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6207         (ada_collect_symbol_completion_matches)
6208         (ada_add_global_exceptions): Remove declaration.
6209         * linespec.c (iterate_over_all_matching_symtabs): Use
6210         objfile_compunits.
6211         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6212         (class objfile_compunits): New.
6213         (ALL_COMPUNITS): Use objfile_compunits.
6214         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6215         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6216         objfile_compunits.
6217         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6218
6219 2019-01-09  Tom Tromey  <tom@tromey.com>
6220
6221         * symtab.c (search_symbols)
6222         (default_collect_symbol_completion_matches_break_on): Use
6223         objfile_msymbols.
6224         * ada-lang.c (ada_lookup_simple_minsym)
6225         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6226         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6227         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6228         objfile_msymbols.
6229         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6230         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6231         * objc-lang.c (find_methods): Use objfile_msymbols.
6232         (info_selectors_command, info_classes_command): Likewise.
6233         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6234         * objfiles.h (class objfile_msymbols): New.
6235         (ALL_OBJFILE_MSYMBOLS): Remove.
6236         (ALL_MSYMBOLS): Remove.
6237
6238 2019-01-09  Tom Tromey  <tom@tromey.com>
6239
6240         * common/next-iterator.h (next_adapter): Add Iterator template
6241         parameter.
6242         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6243         (class all_objfiles_safe): New.
6244         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6245         * objfiles.c (put_objfile_before): Update comment.
6246         (add_separate_debug_objfile): Likewise.
6247         (free_all_objfiles): Use all_objfiles_safe.
6248         (objfile_purge_solibs): Likewise.
6249
6250 2019-01-09  Tom Tromey  <tom@tromey.com>
6251
6252         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6253         (expand_symtab_containing_pc, lookup_static_symbol)
6254         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6255         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6256         all_objfiles.
6257         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6258         * breakpoint.c (create_overlay_event_breakpoint)
6259         (create_longjmp_master_breakpoint)
6260         (create_std_terminate_master_breakpoint)
6261         (create_exception_master_breakpoint): Use all_objfiles.
6262         * linux-thread-db.c (try_thread_db_load_from_pdir)
6263         (has_libpthread): Use all_objfiles.
6264         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6265         * linespec.c (iterate_over_all_matching_symtabs)
6266         (search_minsyms_for_name): Use all_objfiles.
6267         * maint.c (maintenance_info_sections): Use all_objfiles.
6268         * main.c (captured_main_1): Use all_objfiles.
6269         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6270         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6271         * guile/scm-pretty-print.c
6272         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6273         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6274         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6275         (maintenance_print_msymbols): Use all_objfiles.
6276         * source.c (select_source_symtab): Use all_objfiles.
6277         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6278         * symfile.c (remove_symbol_file_command)
6279         (expand_symtabs_matching, map_symbol_filenames): Use
6280         all_objfiles.
6281         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6282         all_objfiles.
6283         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6284         * objc-lang.c (find_methods): Use all_objfiles.
6285         * objfiles.c (have_partial_symbols, have_full_symbols)
6286         (have_minimal_symbols, qsort_cmp)
6287         (default_iterate_over_objfiles_in_search_order): Use
6288         all_objfiles.
6289         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6290         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6291         (maintenance_check_psymtabs): Use all_objfiles.
6292         (ALL_PSYMTABS): Remove.
6293         * compile/compile-object-run.c (do_module_cleanup): Use
6294         all_objfiles.
6295         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6296         * cp-support.c (add_symbol_overload_list_qualified): Use
6297         all_objfiles.
6298         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6299         Use all_objfiles.
6300         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6301         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6302         all_objfiles.
6303         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6304         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6305         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6306         Uses all_objfiles.
6307         * solib.c (solib_read_symbols): Use all_objfiles
6308
6309 2019-01-09  Tom Tromey  <tom@tromey.com>
6310
6311         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6312         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6313         all_objfiles.
6314         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6315         * symmisc.c (print_symbol_bcache_statistics)
6316         (print_objfile_statistics, maintenance_print_objfiles)
6317         (maintenance_info_symtabs, maintenance_check_symtabs)
6318         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6319         all_objfiles.
6320         * source.c (forget_cached_source_info): Use all_objfiles.
6321         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6322         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6323         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6324         * objfiles.c (update_section_map): Use all_objfiles.
6325         (shared_objfile_contains_address_p): Likewise.
6326         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6327         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6328
6329 2019-01-09  Tom Tromey  <tom@tromey.com>
6330
6331         * common/next-iterator.h: New file.
6332         * objfiles.h (class all_objfiles): New.
6333         (struct objfile_iterator): New.
6334
6335 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6336
6337         * NEWS: Move the description of the changed "frame", "select-frame",
6338          and "info frame" commands to the Changed commands section.
6339
6340 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6341
6342         * gdbtypes.c (check_stub_method_group): Remove handling of old
6343         mangling schemes.
6344         * linespec.c (find_methods): Likewise.
6345         * stabsread.c (read_member_functions): Likewise.
6346         * valops.c (search_struct_method): Likewise.
6347         (value_struct_elt_for_reference): Likewise.
6348         * NEWS: Mention this change.
6349
6350 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6351
6352         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6353         print_source_lines.
6354         * source.c (print_source_lines_base): Update line number check.
6355         (print_source_lines): New function.
6356         (source_lines_range::source_lines_range): New function.
6357         * source.h (class source_lines_range): New class.
6358         (print_source_lines): New declaration.
6359
6360 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6361
6362         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6363
6364 2019-01-08  Tom Tromey  <tom@tromey.com>
6365             Simon Marchi  <simon.marchi@ericsson.com>
6366
6367         PR gdb/24060
6368         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6369         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6370         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6371         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6372         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6373         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6374
6375 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6376
6377         * source.c (select_source_symtab): Move header comment to
6378         declaration in source.h.
6379         (forget_cached_source_info_for_objfile): Likewise.
6380         (forget_cached_source_info): Likewise.
6381         (identify_source_line): Likewise.
6382         * source.h (identify_source_line): Move declaration from symtab.h
6383         and add comment from source.c
6384         (print_source_lines): Likewise.
6385         (forget_cached_source_info_for_objfile): Likewise.
6386         (forget_cached_source_info): Likewise.
6387         (select_source_symtab): Likewise.
6388         (enum print_source_lines_flag): Move definition from symtab.h.
6389         * symtab.h (identify_source_line): Move declaration to source.h.
6390         (print_source_lines): Likewise.
6391         (forget_cached_source_info_for_objfile): Likewise.
6392         (forget_cached_source_info): Likewise.
6393         (select_source_symtab): Likewise.
6394         (enum print_source_lines_flag): Move definition to source.h.
6395         * tui/tui-hooks.c: Add 'source.h' include.
6396
6397 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6398
6399         * source.c (print_source_lines_base): Handle requests to print
6400         reverse line number sequences, and guard against empty lines
6401         string.
6402
6403 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6404
6405         * source.c (print_source_lines_base): Fix skip of '\r' if next
6406         character is '\n'.
6407
6408 2019-01-06  Tom Tromey  <tom@tromey.com>
6409
6410         * c-exp.y (struct c_parse_state) <macro_original_text,
6411         expansion_obstack>: New member.
6412         (macro_original_text, expansion_obstack): Remove globals.
6413         (scan_macro_expansion, scanning_macro_expansion)
6414         (finished_macro_expansion): Update.
6415         (scan_macro_cleanup): Remove.
6416         (yylex, c_parse): Update.
6417
6418 2019-01-06  Tom Tromey  <tom@tromey.com>
6419
6420         * c-exp.y (struct c_parse_state) <strings>: New member.
6421         (operator_stoken): Update.
6422
6423 2019-01-06  Tom Tromey  <tom@tromey.com>
6424
6425         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6426         (union type_stack_elt) <typelist_val>: Now a pointer to
6427         std::vector.
6428         (type_stack_cleanup): Don't declare.
6429         (push_typelist): Update.
6430         * parse.c (pop_typelist): Return a std::vector.
6431         (push_typelist): Take a std::vector.
6432         (follow_types): Update.  Do not free args.
6433         (type_stack_cleanup): Remove.
6434         * c-exp.y (struct c_parse_state): New.
6435         (cpstate): New global.
6436         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6437         (nonempty_typelist): Update.
6438         (func_mod): Create a new vector.
6439         (c_parse): Create a c_parse_state.
6440         (check_parameter_typelist): Do not delete params.
6441         (function_method): Update.  Do not delete type_list.
6442
6443 2019-01-06  Tom Tromey  <tom@tromey.com>
6444
6445         PR gdb/28155:
6446         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6447         check_typedef.
6448         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6449         (print_return_value): Likewise.
6450
6451 2019-01-05  Tom Tromey  <tom@tromey.com>
6452
6453         * contrib/cleanup_check.py: Remove.
6454         * contrib/gcc-with-excheck: Remove.
6455         * contrib/exsummary.py: Remove.
6456         * contrib/excheck.py: Remove.
6457
6458 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6459
6460         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6461         NULL. Initialize tpprev to NULL instead of assigning it
6462         to NULL on the next statement.
6463         * windows-nat.c (windows_delete_thread): Remove check for
6464         main_thread_id before printing thread exit notifications.
6465         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6466         Remove thread ID check against main_thread_id.
6467         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6468         windows_delete_thread.
6469         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6470
6471 2019-01-04  Tom Tromey  <tom@tromey.com>
6472
6473         * compile/compile.c (_initialize_compile): Use upper case for
6474         metasyntactic variables.
6475         * symmisc.c (_initialize_symmisc): Use upper case for
6476         metasyntactic variables.
6477         * psymtab.c (_initialize_psymtab): Use upper case for
6478         metasyntactic variables.
6479         * demangle.c (demangle_command): Use upper case for metasyntactic
6480         variables.
6481         (_initialize_demangler): Likewise.
6482         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6483         variables.
6484
6485 2019-01-03  Tom Tromey  <tom@tromey.com>
6486
6487         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6488
6489 2019-01-03  Tom Tromey  <tom@tromey.com>
6490
6491         * python/py-symtab.c (salpy_str): Update.
6492         (struct salpy_sal_object) <symtab>: Now a PyObject.
6493         (salpy_dealloc): Update.
6494         (del_objfile_sal): Use gdbpy_ref.
6495
6496 2019-01-03  Tom Tromey  <tom@tromey.com>
6497
6498         * python/py-type.c (convert_field): Use new_reference.  Return
6499         gdbpy_ref.
6500         (make_fielditem): Return gdbpy_ref.
6501         (typy_fields): Update.
6502         (typy_getitem): Update.
6503         (field_name): Return gdbpy_ref.  Use new_reference.
6504         (typy_iterator_iternext): Update.
6505
6506 2019-01-03  Tom Tromey  <tom@tromey.com>
6507
6508         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6509
6510 2019-01-03  Tom Tromey  <tom@tromey.com>
6511
6512         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6513         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6514         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6515         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6516         (pspy_set_type_printers): Likewise.
6517         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6518         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6519         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6520         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6521         (objfpy_set_type_printers): Likewise.
6522
6523 2019-01-03  Tom Tromey  <tom@tromey.com>
6524
6525         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6526         (gdbpy_print_stack): Use gdbpy_err_fetch.
6527         * python/python-internal.h (class gdbpy_err_fetch): New class.
6528         (class gdbpy_enter) <m_error_type, m_error_value,
6529         m_error_traceback>: Remove.
6530         <m_error>: New member.
6531         (gdbpy_exception_to_string): Don't declare.
6532         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6533         * python/py-value.c (convert_value_from_python): Use
6534         gdbpy_err_fetch.
6535         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6536         gdbpy_exception_to_string.
6537         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6538         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6539         gdbpy_err_fetch.
6540
6541 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6542
6543         * linux-nat.c (delete_lwp_cleanup): Delete.
6544         (struct lwp_deleter): New struct.
6545         (lwp_info_up): New typedef.
6546         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6547         lwp_info_up.
6548
6549 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6550
6551         * linux-fork.c (class scoped_switch_fork_info): New class.
6552         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6553
6554 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6555
6556         * valops.c (find_overload_match): Remove use of null_cleanup, and
6557         calls to do_cleanups.
6558
6559 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6560
6561         * compile/compile-cplus-types.c
6562         (compile_cplus_instance::decl_name): Handle changes to
6563         cp_func_name.
6564         * cp-support.c (cp_func_name): Update header comment, update
6565         return type.
6566         * cp-support.h (cp_func_name): Update return type in declaration.
6567         * valops.c (find_overload_match): Move temp_func local to top
6568         level of function and change its type.  Use temp_func to hold and
6569         delete temporary string obtained from cp_func_name.
6570
6571 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6572
6573         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6574         gdb::char_vector, remove cleanup, and update uses of `msg`.
6575
6576 2019-01-03  Jim Wilson  <jimw@sifive.com>
6577
6578         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6579
6580 2019-01-02  Tom Tromey  <tom@tromey.com>
6581
6582         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6583         (tdesc_parse_xml): Remove cleanups.
6584         * target-descriptions.h (make_cleanup_free_target_description):
6585         Don't declare.
6586         (target_desc_deleter): New struct.
6587         (target_desc_up): New typedef.
6588         * target-descriptions.c (target_desc_deleter::operator()): Rename
6589         from free_target_description.
6590         (make_cleanup_free_target_description): Remove.
6591
6592 2019-01-02  Tom Tromey  <tom@tromey.com>
6593
6594         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6595         constructor, destructor.
6596         (linespec_parser): Remove typedef.
6597         (~linespec_parser): Rename from linespec_parser_delete.
6598         (linespec_lex_to_end, linespec_complete_label)
6599         (linespec_complete): Update.
6600         (decode_line_full): Remove cleanups.
6601         (decode_line_1): Update.
6602
6603 2019-01-02  Tom Tromey  <tom@tromey.com>
6604
6605         * python/python-internal.h (inferior_to_inferior_object): Change
6606         return type.
6607         * python/py-exitedevent.c (create_exited_event_object): Update.
6608         * python/py-inferior.c (inferior_to_inferior_object): Return
6609         gdbpy_ref.
6610         (python_new_inferior, python_inferior_deleted)
6611         (thread_to_thread_object, delete_thread_object)
6612         (build_inferior_list, gdbpy_selected_inferior): Update.
6613         * python/py-infthread.c (create_thread_object): Update.  Also fail
6614         if inferior_to_inferior_object fails.
6615
6616 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6617
6618         * inferior.h (class inferior) <displaced_step_state>: New field.
6619         * infrun.h (struct displaced_step_state): Move here from
6620         infrun.c.  Initialize fields, add constructor.
6621         <inf>: Remove field.
6622         <reset>: New method.
6623         * infrun.c (struct displaced_step_inferior_state): Move to
6624         infrun.h.
6625         (displaced_step_inferior_states): Remove.
6626         (get_displaced_stepping_state): Adust.
6627         (displaced_step_in_progress_any_inferior): Adjust.
6628         (displaced_step_in_progress_thread): Adjust.
6629         (displaced_step_in_progress): Adjust.
6630         (add_displaced_stepping_state): Remove.
6631         (get_displaced_step_closure_by_addr): Adjust.
6632         (remove_displaced_stepping_state): Remove.
6633         (infrun_inferior_exit): Call displaced_step_state.reset.
6634         (use_displaced_stepping): Don't check for NULL.
6635         (displaced_step_prepare_throw): Call
6636         get_displaced_stepping_state.
6637         (displaced_step_fixup): Don't check for NULL.
6638         (prepare_for_detach): Don't check for NULL.
6639
6640 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6641
6642         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6643          in case of call that did not complete.
6644
6645 2019-01-02  Andrey Utkin  <autkin@undo.io>
6646
6647         * symfile.c (find_separate_debug_file): Fix search of debug files for
6648         remote debuggee.
6649
6650 2019-01-02  Tom Tromey  <tom@tromey.com>
6651
6652         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6653         indentation.
6654         * python/py-frame.c (frapy_older): Remove cast.
6655         (frapy_newer): Likewise.
6656         * python/py-breakpoint.c (local_setattro): Remove cast.
6657         * python/py-arch.c (archpy_name): Remove local variable.
6658         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6659
6660 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6661
6662         * unittests/basic_string_view/element_access/char/empty.cc:
6663         Fix year range in copyright header.
6664
6665 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6666
6667         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6668         Delete.
6669         <operator==>: Update with for removed field.
6670         <hash>: Likewise.
6671         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6672         <isa_features>: ...this.
6673         <abi_features>: New field.
6674         (riscv_isa_flen): Update comment.
6675         (riscv_abi_xlen): New declaration.
6676         (riscv_abi_flen): New declaration.
6677         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6678         isa_features.
6679         (riscv_abi_xlen): New function.
6680         (riscv_isa_flen): Update to get answer from isa_features.
6681         (riscv_abi_flen): New function.
6682         (riscv_has_fp_abi): Update to get answer from abi_features.
6683         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6684         xlen and flen.
6685         (riscv_call_info) <xlen, flen>: Update comment.
6686         (riscv_call_arg_struct): Remove invalid assertions
6687         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6688         is removed.
6689         (riscv_gdbarch_init): Gather isa features and abi features
6690         separately, ensure both match on the gdbarch when reusing an old
6691         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6692         a target with 64-bit float hardware.
6693
6694 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6695
6696         * source.c (search_command_helper): Stop reverse search
6697         when line 1 has been searched.
6698
6699 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6700
6701         * record-full.c (record_full_base_target::close): Rewrite
6702         record_full_core_buf_list free logic.
6703
6704 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6705
6706         * break-catch-syscall.c (print_one_catch_syscall): xfree
6707         the last text.
6708
6709 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6710
6711         * top.c (print_gdb_version): Update Copyright year in version
6712         message.
6713
6714 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6715
6716         Update copyright year range in all GDB files.
6717
6718 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6719
6720         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6721
6722 For older changes see ChangeLog-2018.
6723 \f
6724 Local Variables:
6725 mode: change-log
6726 left-margin: 8
6727 fill-column: 74
6728 version-control: never
6729 coding: utf-8
6730 End:
6731