gdb/ChangeLog

   1 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
   2
   3         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
   4         bpstat_should_step): Return bool, adjust comments.
   5         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
   6         bpstat_should_step): Likewise.
   7
   8 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
   9
  10         * features/Makefile: Use feature target descriptions for Arm.
  11         * features/arm/arm-core.c: Generate new file.
  12         * features/arm/arm-fpa.c: Likewise.
  13         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
  14         * features/arm/arm-m-profile.c: Likewise.
  15         * features/arm/arm-vfpv2.c: Likewise.
  16         * features/arm/arm-vfpv3.c: Likewise.
  17         * features/arm/xscale-iwmmxt.c: Likewise.
  18         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
  19
  20 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
  21
  22         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
  23         ptrace earlier.
  24
  25 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
  26
  27         * features/aarch64-pauth.c: Regenerate.
  28
  29 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
  30
  31         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
  32         bool.
  33         (bpstat_what): Use false instead of 0.
  34
  35 2019-07-09  Pedro Alves  <palves@redhat.com>
  36
  37         * break-catch-throw.c (is_exception_catchpoint): New.
  38         * breakpoint.c (print_one_breakpoint_location): New parameter
  39         'raw_loc'.  Handle it.  Use
  40         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
  41         looking at the breakpoint's type.
  42         (print_one_breakpoint): If handling "maint info breakpoints", also
  43         print locations of exception catchpoints.
  44         * breakpoint.h (is_exception_catchpoint): Declare.
  45
  46 2019-07-09  Pedro Alves  <palves@redhat.com>
  47
  48         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
  49         "addr" field.
  50         (allocate_location_exception_catchpoint): New.
  51         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
  52         (initialize_throw_catchpoint_ops): Install
  53         allocate_location_exception_catchpoint as allocate_location
  54         method.
  55         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
  56         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
  57         bp_loc_other.
  58         (breakpoint_address_is_meaningful): Delete.
  59         (bl_address_is_meaningful): New.
  60         (breakpoint_locations_match): Adjust comment.
  61         (bp_location_from_bp_type): New, factored out of...
  62         (bp_location::bp_location(breakpoint *)): ... this.
  63         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
  64         factored out of...
  65         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
  66         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
  67         breakpoint_address_is_meaningful.
  68         (bp_locations_compare): Adjust comment.
  69         (update_global_location_list): Use bl_address_is_meaningful
  70         instead of breakpoint_address_is_meaningful.
  71         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
  72         explicit.
  73         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
  74         * python/py-breakpoint.c (bppy_get_location): No longer check
  75         whether location is null.
  76
  77 2019-07-09  Pedro Alves  <palves@redhat.com>
  78
  79         PR c++/15468
  80         * breakpoint.c (print_one_breakpoint_location): Remove
  81         single-location assert.
  82
  83 2019-07-09  Tom Tromey  <tom@tromey.com>
  84
  85         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
  86         * configure: Rebuild.
  87         * configure.ac: Change common to gdbsupport.
  88         * gdbsupport: Rename from common.
  89         * acinclude.m4: Change common to gdbsupport.
  90         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
  91         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
  92         gdbsupport.
  93         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
  94         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
  95         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
  96         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
  97         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
  98         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
  99         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 100         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 101         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 102         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 103         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 104         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 105         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 106         coff-pe-read.c, command.h, compile/compile-c-support.c,
 107         compile/compile-c.h, compile/compile-cplus-symbols.c,
 108         compile/compile-cplus-types.c, compile/compile-cplus.h,
 109         compile/compile-loc2c.c, compile/compile.c, completer.c,
 110         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 111         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 112         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 113         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 114         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 115         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 116         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 117         features/aarch64-core.c, features/aarch64-fpu.c,
 118         features/aarch64-pauth.c, features/aarch64-sve.c,
 119         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 120         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 121         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 122         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 123         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 124         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 125         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 126         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 127         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 128         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 129         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 130         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 131         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 132         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 133         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 134         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 135         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 136         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 137         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 138         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 139         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 140         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 141         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 142         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 143         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 144         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 145         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 146         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 147         minsyms.c, mips-linux-tdep.c, namespace.h,
 148         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 149         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 150         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 151         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 152         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 153         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 154         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 155         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 156         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 157         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 158         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 159         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 160         procfs.c, producer.c, progspace.h, psymtab.h,
 161         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 162         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 163         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 164         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 165         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 166         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 167         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 168         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 169         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 170         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 171         target-memory.c, target.c, target.h, target/waitstatus.c,
 172         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 173         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 174         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 175         unittests/array-view-selftests.c,
 176         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 177         unittests/common-utils-selftests.c,
 178         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 179         unittests/format_pieces-selftests.c,
 180         unittests/function-view-selftests.c,
 181         unittests/lookup_name_info-selftests.c,
 182         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 183         unittests/mkdir-recursive-selftests.c,
 184         unittests/observable-selftests.c,
 185         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 186         unittests/parse-connection-spec-selftests.c,
 187         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 188         unittests/scoped_fd-selftests.c,
 189         unittests/scoped_mmap-selftests.c,
 190         unittests/scoped_restore-selftests.c,
 191         unittests/string_view-selftests.c, unittests/style-selftests.c,
 192         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 193         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 194         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 195         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 196         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 197         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 198
 199 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 200
 201         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 202         bool value.
 203         (decode_digits_ordinary): Set explicit_line field in sal.
 204         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 205         symtab_and_line that was set on an explicit line number in
 206         assembler code.  Do always update the recorded symtab and line if
 207         we do skip the prologue.
 208
 209 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 210
 211         * breakpoint.c (set_breakpoint_location_function): Remove
 212         explicit_loc parameter.
 213         (momentary_breakpoint_from_master): Update call to
 214         set_breakpoint_location_function.
 215         (add_location_to_breakpoint): Likewise.
 216
 217 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 218
 219         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 220         required features based on default bfd type when no specific bfd
 221         is present.
 222
 223 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 224
 225         * NEWS: Mention that GDB printf and eval commands can now print
 226         C-style and Ada-style convenience var strings without
 227         calling the inferior.
 228         * printcmd.c (printf_c_string): Locally print GDB internal var
 229         instead of transiting via the inferior.
 230         (printf_wide_c_string): Likewise.
 231
 232 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 233
 234         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 235
 236 2019-07-04  Tom Tromey  <tom@tromey.com>
 237
 238         PR tui/24724:
 239         * tui/tui-winsource.c (tui_clear_source_content): Update.
 240         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 241         (tui_update_breakpoint_info): Update.
 242         (tui_set_exec_info_content): Update.
 243         * tui/tui-source.c (tui_set_source_content_nil): Update.
 244         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 245         has_break.
 246         * tui/tui-data.h (enum tui_bp_flag): New.
 247         (tui_bp_flags): New enum flags type.
 248         (struct tui_source_element) <break_mode>: Change type.  Rename
 249         from has_break.
 250         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 251         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 252         constants.
 253         * tui/tui-winsource.h: Fix comment.
 254
 255 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 256
 257         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 258         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 259         (store_fpregs_to_thread)
 260         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 261         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 262         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 263         (IWMMXT_REGS_SIZE): Add define.
 264         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 265         (fetch_vfp_regs, store_vfp_regs)
 266         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 267         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 268
 269 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 270
 271         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 272         defines.
 273         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 274         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 275         (ARM_INT_REGISTER_SIZE): ...to this.
 276         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 277         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 278         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 279         (arm_linux_collect_gregset, supply_nwfpe_register)
 280         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 281         defines.
 282         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 283         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 284         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 285         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 286         (arm_return_in_memory, arm_store_return_value)
 287         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 288         (arm_record_ld_st_multiple): Likewise.
 289         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 290         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 291
 292 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 293
 294         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 295         AARCH64_DISPLACED_MODIFIED_INSNS.
 296         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 297         (aarch64_displaced_step_copy_insn): Likewise.
 298         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 299         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 300         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 301         ARM_DISPLACED_MODIFIED_INSNS.
 302         * arm-tdep.c (arm_gdbarch_init): Likewise.
 303         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 304         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 305         (struct arm_displaced_step_closure): Use
 306         ARM_DISPLACED_MODIFIED_INSNS.
 307
 308 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 309
 310         * features/Makefile: Remove unused xml files.
 311         * features/aarch64.xml: Remove.
 312         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 313         * features/i386/amd64-avx-avx512.xml: Remove.
 314         * features/i386/amd64-avx-linux.xml: Remove.
 315         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 316         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 317         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 318         * features/i386/amd64-avx-mpx.xml: Remove.
 319         * features/i386/amd64-avx.xml: Remove.
 320         * features/i386/amd64-linux.xml: Remove.
 321         * features/i386/amd64-mpx-linux.xml: Remove.
 322         * features/i386/amd64-mpx.xml: Remove.
 323         * features/i386/amd64.xml: Remove.
 324         * features/i386/i386-avx-avx512-linux.xml: Remove.
 325         * features/i386/i386-avx-avx512.xml: Remove.
 326         * features/i386/i386-avx-linux.xml: Remove.
 327         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 328         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 329         * features/i386/i386-avx-mpx-linux.xml: Remove.
 330         * features/i386/i386-avx-mpx.xml: Remove.
 331         * features/i386/i386-avx.xml: Remove.
 332         * features/i386/i386-linux.xml: Remove.
 333         * features/i386/i386-mmx-linux.xml: Remove.
 334         * features/i386/i386-mmx.xml: Remove.
 335         * features/i386/i386-mpx-linux.xml: Remove.
 336         * features/i386/i386-mpx.xml: Remove.
 337         * features/i386/i386.xml: Remove.
 338         * features/i386/x32-avx-avx512-linux.xml: Remove.
 339         * features/i386/x32-avx-linux.xml: Remove.
 340         * features/i386/x32-linux.xml: Remove.
 341
 342 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 343
 344         * regformats/aarch64.dat: Remove.
 345         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 346         * regformats/i386/amd64-avx-linux.dat: Remove.
 347         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 348         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 349         * regformats/i386/amd64-linux.dat: Remove.
 350         * regformats/i386/amd64-mpx-linux.dat: Remove.
 351         * regformats/i386/amd64.dat: Remove.
 352         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 353         * regformats/i386/i386-avx-linux.dat: Remove.
 354         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 355         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 356         * regformats/i386/i386-linux.dat: Remove.
 357         * regformats/i386/i386-mmx-linux.dat: Remove.
 358         * regformats/i386/i386-mpx-linux.dat: Remove.
 359         * regformats/i386/i386.dat: Remove.
 360         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 361         * regformats/i386/x32-avx-linux.dat: Remove.
 362         * regformats/i386/x32-linux.dat: Remove.
 363
 364 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 365
 366         * aarch64-tdep.c: Remove xml self tests.
 367         * amd64-linux-tdep.c: Likewise.
 368         * amd64-tdep.c: Likewise.
 369         * i386-linux-tdep.c: Likewise.
 370         * i386-tdep.c: Likewise.
 371
 372 2019-07-03  Pedro Alves  <palves@redhat.com>
 373
 374         PR cli/24732
 375         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
 376         (pipe_cmd_option_defs): New.
 377         (make_pipe_cmd_options_def_group): New.
 378         (pipe_command): Use gdb::option::process_options.
 379         (pipe_command_completer): New function.
 380         (_initialize_cli_cmds): Install completer for "pipe" command.
 381
 382 2019-07-03  Pedro Alves  <palves@redhat.com>
 383
 384         * cli/cli-option.c (union option_value) <string>: New field.
 385         (struct option_def_and_value): Add ctor, move ctor, dtor and
 386         use DISABLE_COPY_AND_ASSIGN.
 387         (option_def_and_value::clear_value): New.
 388         (parse_option, save_option_value_in_ctx, get_val_type_str)
 389         (add_setshow_cmds_for_options): Handle var_string.
 390         * cli-option.h (union option_def::var_address) <string>: New
 391         field.
 392         (struct string_option_def): New.
 393         * maint-test-options.c (struct test_options_opts): Add default
 394         ctor and use DISABLE_COPY_AND_ASSIGN.
 395         <string_opt>: New field.
 396         (test_options_opts::~test_options_opts): New.
 397         (test_options_opts::dump): Also dump "-string".
 398         (test_options_option_defs): Install "string.
 399
 400 2019-07-03  Pedro Alves  <palves@redhat.com>
 401
 402         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
 403         option_value with a null enumeration.
 404         (complete_options): Save the option values in the context.
 405         (save_option_value_in_ctx): New, factored out from ...
 406         (process_options): ... here.
 407         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
 408         of the function.
 409         * maint-test-options.c (test_options_opts::dump): New, factored
 410         out from ...
 411         (maintenance_test_options_command_mode): ... here.
 412         (maintenance_test_options_command_completion_result): Delete.
 413         (maintenance_test_options_command_completion_text): Update
 414         comment.
 415         (maintenance_show_test_options_completion_result): Change
 416         prototype.  Just print
 417         maintenance_test_options_command_completion_text.
 418         (save_completion_result): New.
 419         (maintenance_test_options_completer_mode): Pass options context to
 420         complete_options, and then save a dump.
 421         (_initialize_maint_test_options): Use add_cmd to install "maint
 422         show test-options-completion-result".
 423
 424 2019-07-03  Pedro Alves  <palves@redhat.com>
 425
 426         * NEWS (New commands): Mention "with" and "maint with".
 427         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
 428         (with_command, with_command_completer): New.
 429         (pipe_command): Adjust to new repeat_previous
 430         interface.
 431         (_initialize_cli_cmds): Install the "with" command and its "w"
 432         alias.
 433         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
 434         declarations.
 435         * cli/cli-setshow.c (parse_cli_var_uinteger)
 436         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
 437         argument strings for all var_types.
 438         (get_setshow_command_value_string): New, factored out from ...
 439         (do_show_command): ... this.
 440         * cli/cli-setshow.h: Include <string>.
 441         (get_setshow_command_value_string): Declare.
 442         * command.h (repeat_previous): Now returns const char *.  Adjust
 443         comment.
 444         * maint.c: Include "cli/cli-cmds.h".
 445         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
 446         (_initialize_maint_cmds): Register the "maintenance with" command.
 447         * top.c (repeat_previous): Move bits from pipe_command here:
 448         Return the saved command line, if any; error out if there's no
 449         command to relaunch.
 450
 451 2019-07-03  Pedro Alves  <palves@redhat.com>
 452
 453         * NEWS (New commands): Mention "maint set/show test-settings"
 454         instead of "maint test-settings".
 455         * maint-test-settings.c (maintenance_test_settings_list): Delete.
 456         (maintenance_test_settings_set_list): Rename to ...
 457         (maintenance_set_test_settings_list): ... this.
 458         (maintenance_test_settings_show_list): Rename to  ...
 459         (maintenance_show_test_settings_list): ... this.
 460         (maintenance_test_settings_cmd): Delete.
 461         (maintenance_test_settings_set_cmd): ...
 462         (maintenance_set_test_settings_cmd): ... this.
 463         (maintenance_test_settings_show_cmd): ...
 464         (maintenance_show_test_settings_cmd): ... this.
 465         (maintenance_test_settings_show_value_cmd):
 466         (maintenance_show_test_settings_value_cmd): ... this.
 467         (_initialize_maint_test_settings): No longer install the "maint
 468         test-settings" prefix command.  Rename "maint test-settings set"
 469         to "maint set test-settings", and "maint test-settings show" to
 470         "maint show test-settings".  Adjust all subcommands.
 471
 472 2019-07-03  Pedro Alves  <palves@redhat.com>
 473
 474         * maint-test-settings.c: Fix file's intro comment.  Replace all
 475         references to "test-options" with references to "test-settings",
 476         in comments.
 477
 478 2019-07-03  Pedro Alves  <palves@redhat.com>
 479
 480         * maint-test-settings.c (maintenance_test_settings_xxx)
 481         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
 482         New.
 483         (maintenance_test_settings_enums): Use them.
 484         (maintenance_test_settings_enum): Default to
 485         maintenance_test_settings_xxx.
 486         (_initialize_maint_test_settings): Initialize
 487         MAINTENANCE_TEST_SETTINGS_FILENAME.
 488
 489 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 490
 491         * breakpoint.h (remove_breakpoints_inf): Change return type to
 492         void, move function documentation here.
 493         * breakpoint.c (remove_breakpoints_inf): Change return type to
 494         void, move function documentation to header.
 495
 496 2019-07-02  Pedro Alves  <palves@redhat.com>
 497
 498         * NEWS (Completion improvements): Mention "info threads".
 499         * thread.c (struct info_threads_opts, info_threads_option_defs)
 500         (make_info_threads_options_def_group): New.
 501         (info_threads_command): Use gdb::option::process_options.
 502         (info_threads_command_completer): New.
 503         (_initialize_thread): Use gdb::option::build_help to build the
 504         help text for "info threads".
 505
 506 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 507
 508         * defs.h (generic_load): Move from here...
 509         * symfile.h (generic_load): ... to here.  Rename name parameter
 510         to args.
 511         * symfile.c (generic_load): Add comment.
 512
 513 2019-07-01  Tom Tromey  <tromey@adacore.com>
 514
 515         * dwarf2read.c
 516         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
 517         declaration of without_params.  Fix formatting.
 518
 519 2019-07-01  Tom Tromey  <tromey@adacore.com>
 520
 521         * ada-exp.y (find_primitive_type): Update.
 522         * ada-lang.h (ada_lookup_symbol): Update.
 523         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
 524         parameter.
 525         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
 526
 527 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 528
 529         PR breakpoints/24541
 530         * gdbarch.c: Regenerate.
 531         * gdbarch.h: Regenerate.
 532         * gdbarch.sh: Add 'stap_adjust_register'.
 533         * i386-tdep.c: Include '<unordered_set>'.
 534         (i386_stap_adjust_register): New function.
 535         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
 536         * stap-probe.c (stap_parse_register_operand): Call
 537         'gdbarch_stap_adjust_register'.
 538
 539 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 540
 541         PR python/24742
 542         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
 543         * python/python.c (do_start_initialization): Use 'xmalloc'
 544         instead of 'PyMem_Malloc'.
 545
 546 2019-06-28  Tom Tromey  <tromey@adacore.com>
 547
 548         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
 549         for Ada.
 550
 551 2019-06-27  Tom Tromey  <tromey@adacore.com>
 552
 553         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
 554         objfile_key.
 555         (arm_find_mapping_symbol, arm_record_special_symbol)
 556         (_initialize_arm_tdep): Update.
 557         (arm_objfile_data_free): Remove.
 558
 559 2019-06-27  Tom Tromey  <tromey@adacore.com>
 560
 561         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
 562         to cp_print_static_field.
 563
 564 2019-06-26  Tom Tromey  <tromey@adacore.com>
 565
 566         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
 567         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
 568         declare.
 569
 570 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 571
 572         * features/aarch64-core.c (create_feature_aarch64_core):
 573         Regenerate.
 574         * features/aarch64-core.xml: Add cpsr flags.
 575
 576 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 577
 578         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
 579         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
 580
 581 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 582
 583         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
 584         field.
 585         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
 586         use.
 587         (arm_record_special_symbol): Don't insert new symbol in sorted
 588         position, push it at the end.
 589
 590 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 591
 592         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
 593         (arm_mapping_symbol_s): Remove.
 594         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
 595         (arm_mapping_symbol_vec): New typedef.
 596         (struct arm_per_objfile): Add constructor.
 597         <section_maps>: Change type to
 598         std::unique_ptr<arm_mapping_symbol_vec[]>.
 599         (arm_compare_mapping_symbols): Remove.
 600         (arm_find_mapping_symbol): Adjust to section_maps type change.
 601         (arm_objfile_data_free): Call delete on arm_per_objfile.
 602         (arm_record_special_symbol): Adjust to section_maps type change.
 603         Allocate arm_per_objfile with new.
 604
 605 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 606
 607         * cli/cli-cmds.c (alias_command): Compare the alias prefix
 608         with the command prefix.
 609
 610 2019-06-25  Tom Tromey  <tom@tromey.com>
 611
 612         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
 613         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
 614
 615 2019-06-25  Tom Tromey  <tom@tromey.com>
 616
 617         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
 618         type.
 619         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
 620         protected.
 621
 622 2019-06-25  Tom Tromey  <tom@tromey.com>
 623
 624         * tui/tui-winsource.c
 625         (tui_source_window_base::set_is_exec_point_at): Add check against
 626         LOA_ADDRESS.
 627
 628 2019-06-25  Tom Tromey  <tom@tromey.com>
 629
 630         * tui/tui-source.c (tui_set_source_content): Don't check before
 631         xfree.
 632         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
 633
 634 2019-06-25  Tom Tromey  <tom@tromey.com>
 635
 636         * tui/tui-winsource.h (tui_update_source_window_as_is)
 637         (tui_alloc_source_buffer, tui_line_is_displayed)
 638         (tui_addr_is_displayed): Change type of win_info.
 639         * tui/tui-winsource.c (tui_update_source_window_as_is)
 640         (tui_clear_source_content, tui_show_source_line)
 641         (tui_show_source_content, tui_source_window_base::refill)
 642         (tui_source_window_base::set_is_exec_point_at)
 643         (tui_source_window_base::set_is_exec_point_at)
 644         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
 645         (tui_alloc_source_buffer, tui_line_is_displayed)
 646         (tui_addr_is_displayed): Change type of win_info.  Update.
 647         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 648         (tui_source_window_base::do_make_visible_with_new_height):
 649         Update.
 650         * tui/tui-source.c (tui_set_source_content)
 651         (tui_set_source_content_nil)
 652         (tui_source_window::do_scroll_vertical): Update.
 653         * tui/tui-layout.c (show_layout): Update.
 654         * tui/tui-disasm.c (tui_set_disassem_content)
 655         (tui_disasm_window::do_scroll_vertical): Update.
 656         * tui/tui-data.h (tui_win_content): Remove.
 657         (struct tui_gen_win_info) <content, content_size>: Remove.
 658         (struct tui_source_element): Add initializers and destructor.
 659         (union tui_which_element, struct tui_win_element): Remove.
 660         (struct tui_source_window_base) <content>: New field.
 661         (struct tui_data_window): Remove destructor.
 662         (tui_alloc_content, tui_free_win_content)
 663         (tui_free_all_source_wins_content): Don't declare.
 664         * tui/tui-data.c (tui_initialize_static_data): Update.
 665         (init_content_element, tui_alloc_content): Remove.
 666         (~tui_gen_win_info): Update.
 667         (~tui_data_window, tui_free_all_source_wins_content)
 668         (tui_free_win_content, free_content, free_content_elements):
 669         Remove.
 670
 671 2019-06-25  Tom Tromey  <tom@tromey.com>
 672
 673         * tui/tui-winsource.h (tui_clear_source_content)
 674         (tui_erase_source_content, tui_show_source_content): Change type
 675         of win_info.
 676         * tui/tui-winsource.c (tui_clear_source_content)
 677         (tui_erase_source_content, tui_show_source_content): Change type
 678         of win_info.
 679         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 680         * tui/tui-source.h (tui_set_source_content_nil): Change type of
 681         win_info.
 682         * tui/tui-source.c (tui_set_source_content_nil): Change type of
 683         win_info.
 684         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
 685
 686 2019-06-25  Tom Tromey  <tom@tromey.com>
 687
 688         * tui/tui-winsource.c (tui_clear_source_content)
 689         (tui_source_window_base::set_is_exec_point_at): Update.
 690         * tui/tui-source.c (tui_set_source_content_nil): Update.
 691         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
 692         a bool.
 693         * tui/tui-data.c (init_content_element): Update.
 694
 695 2019-06-25  Tom Tromey  <tom@tromey.com>
 696
 697         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
 698         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
 699         * tui/tui-layout.c (init_and_make_win): Update.
 700         * tui/tui.h (enum tui_win_type): Update.
 701         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
 702         tui_win_is_auxillary.
 703         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
 704         tui_win_is_auxillary.
 705
 706 2019-06-25  Tom Tromey  <tom@tromey.com>
 707
 708         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
 709         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
 710         (tui_delete_data_content_windows, tui_display_all_data)
 711         (tui_data_window::do_scroll_vertical, tui_display_data_from):
 712         Update.
 713         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
 714         * tui/tui-regs.c (tui_last_regs_line_no)
 715         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 716         (tui_show_registers): Update.
 717         (tui_show_register_group): Return void.  Update.
 718         (tui_display_registers_from, tui_display_reg_element_at_line)
 719         (tui_display_registers_from_line, tui_check_register_values):
 720         Update.
 721         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
 722         member.
 723         (struct tui_data_window) <regs_content>: Now a std::vector.
 724         <regs_content_count>: Remove.
 725         (tui_add_content_elements, tui_free_data_content): Don't declare.
 726         * tui/tui-data.c (tui_data_window::clear_detail): Update.
 727         (init_content_element): Remove DATA_WIN case.  Add assert.
 728         (tui_add_content_elements): Remove.
 729         (tui_data_window): Update.
 730         (tui_free_data_content): Remove.
 731         (free_content_elements): Remove DATA_WIN case.
 732
 733 2019-06-25  Tom Tromey  <tom@tromey.com>
 734
 735         * tui/tui-data.c (tui_data_item_window): Update.
 736         * tui/tui-windata.h (tui_check_data_values): Don't declare.
 737         * tui/tui-windata.c (tui_display_all_data)
 738         (tui_display_data_from_line): Update.
 739         (tui_check_data_values): Remove.
 740         * tui/tui-regs.c (tui_show_register_group)
 741         (tui_display_reg_element_at_line): Update.
 742         * tui/tui-hooks.c (tui_register_changed)
 743         (tui_refresh_frame_and_register_information): Call
 744         tui_check_register_values.
 745         * tui/tui-data.h (struct tui_data_window) <data_content,
 746         data_content_count, data_type>: Remove.
 747         (enum tui_data_type): Remove.
 748
 749         * tui/tui-data.c (tui_data_window::clear_detail)
 750         (~tui_data_window): Update.
 751
 752 2019-06-25  Tom Tromey  <tom@tromey.com>
 753
 754         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
 755         declare.
 756         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
 757         Rename from tui_first_data_item_displayed.  Update.
 758         (tui_data_window::refresh_all)
 759         (tui_data_window::do_scroll_vertical): Update.
 760         * tui/tui-data.h (struct tui_data_window)
 761         <first_data_item_displayed>: Declare new method.
 762
 763 2019-06-25  Tom Tromey  <tom@tromey.com>
 764
 765         * tui/tui-data.h (tui_init_generic_part): Don't declare.
 766         * tui/tui-data.c (tui_init_generic_part): Remove, moving
 767         contents...
 768         (tui_initialize_static_data): ...here.
 769
 770 2019-06-25  Tom Tromey  <tom@tromey.com>
 771
 772         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 773         (tui_display_registers_from, tui_check_register_values): Update.
 774         (tui_display_register): Remove win_info parameter; update.
 775         (tui_get_register): Change type of parameters.
 776         * tui/tui-data.h (struct tui_data_element): Remove.
 777         (union tui_which_element) <data>: Remove.
 778         <data_window>: Change type.
 779         (struct tui_data_item_window): New.
 780         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
 781         case.  Add assert.
 782         (~tui_data_item_window): New destructor.
 783         (free_content_elements): Remove DATA_ITEM_WIN case.
 784
 785 2019-06-25  Tom Tromey  <tom@tromey.com>
 786
 787         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
 788         Remove.
 789
 790 2019-06-25  Tom Tromey  <tom@tromey.com>
 791
 792         * tui/tui-data.h (struct tui_command_element): Remove.
 793         (union tui_which_element) <command>: Remove.
 794         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
 795         assert.
 796         (free_content_elements): Remove CMD_WIN case.
 797
 798 2019-06-25  Tom Tromey  <tom@tromey.com>
 799
 800         * tui/tui-layout.c (tui_set_layout): Update.
 801         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
 802         * tui/tui-data.c (layout_def): Update.
 803
 804 2019-06-25  Tom Tromey  <tom@tromey.com>
 805
 806         * tui/tui-wingeneral.c (tui_refresh_all): Update.
 807         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 808         (tui_source_window_base::set_new_height): Update.
 809         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
 810         Update.
 811         (tui_set_locator_fullname, tui_set_locator_info)
 812         (tui_show_frame_info): Update.
 813         * tui/tui-source.c (tui_set_source_content)
 814         (tui_source_is_displayed): Update.
 815         * tui/tui-layout.c (show_source_disasm_command, show_data)
 816         (show_source_or_disasm_and_command): Update.
 817         * tui/tui-disasm.c (tui_set_disassem_content)
 818         (tui_get_begin_asm_address): Update.
 819         * tui/tui-data.h (struct tui_locator_element): Remove.
 820         (union tui_which_element) <locator>: Remove.
 821         (struct tui_locator_window): New.
 822         (tui_locator_win_info_ptr): Change return type.
 823         * tui/tui-data.c (_locator): Change type.
 824         (tui_locator_win_info_ptr): Change return type.
 825         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
 826         (tui_alloc_content): Add assert.
 827
 828 2019-06-25  Tom Tromey  <tom@tromey.com>
 829
 830         * tui/tui-winsource.c
 831         (tui_exec_info_window::maybe_allocate_content): New method.
 832         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
 833         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
 834         (make_source_or_disasm_window): Add cast.
 835         * tui/tui-data.h (union tui_which_element) <simple_string>:
 836         Remove.
 837         (struct tui_source_info): New.
 838         (struct tui_source_window_base) <execution_info>: Change type.
 839         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
 840         case, and add assert.
 841         (tui_alloc_content): Add assert.
 842
 843 2019-06-25  Tom Tromey  <tom@tromey.com>
 844
 845         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
 846         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
 847         * tui/tui-data.c (tui_alloc_win_info): Remove.
 848
 849 2019-06-25  Tom Tromey  <tom@tromey.com>
 850
 851         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
 852         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
 853         can_highlight.
 854
 855 2019-06-25  Tom Tromey  <tom@tromey.com>
 856
 857         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
 858         make_visible_with_new_height method.
 859         (tui_win_info::make_visible_with_new_height): New method.
 860         (tui_source_window_base::do_make_visible_with_new_height)
 861         (tui_data_window::do_make_visible_with_new_height)
 862         (tui_cmd_window::do_make_visible_with_new_height): New methods.
 863         (make_visible_with_new_height): Remove.
 864         (tui_resize_all, tui_adjust_win_heights): Use
 865         make_visible_with_new_height method.
 866         * tui/tui-data.h (struct tui_win_info)
 867         <do_make_visible_with_new_height, make_visible_with_new_height>:
 868         New methods.
 869         (struct tui_source_window_base, struct tui_data_window)
 870         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
 871         methods.
 872
 873 2019-06-25  Tom Tromey  <tom@tromey.com>
 874
 875         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
 876         method.
 877         (update_tab_width): Call update_tab_width method.
 878         * tui/tui-data.h (struct tui_win_info)
 879         (struct tui_source_window_base) <update_tab_width>: New methods.
 880
 881 2019-06-25  Tom Tromey  <tom@tromey.com>
 882
 883         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
 884         parameter.
 885         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
 886         parameter.
 887         (tui_gen_win_info::make_visible): Update.
 888         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
 889         parameter.
 890         * tui/tui-data.h (enum tui_box): New enum.
 891         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
 892
 893 2019-06-25  Tom Tromey  <tom@tromey.com>
 894
 895         * tui/tui-layout.c (make_source_or_disasm_window): Always use
 896         init_and_make_win for EXEC_INFO_WIN.
 897         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
 898         longer inline.
 899         (struct tui_win_info) <~tui_win_info>: Inline.
 900         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 901         Don't declare.
 902         * tui/tui-data.c (source_win, disasm_win): Remove globals.
 903         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 904         Remove.
 905         (tui_initialize_static_data): Update.
 906         (~tui_gen_win_info): Handle more cleanup here.
 907         (~tui_source_window_base): Delete "execution_info".
 908         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
 909
 910 2019-06-25  Tom Tromey  <tom@tromey.com>
 911
 912         * tui/tui-layout.c (make_command_window): Don't set
 913         can_highlight.
 914         (show_source_disasm_command): Call the reset method.
 915         (show_data): Don't set can_highlight.  Call the reset method.
 916         (tui_gen_win_info::reset): Rename from init_gen_win_info
 917         (init_and_make_win): Simplify.  Return tui_gen_win_info.
 918         (show_source_or_disasm_and_command): Call the reset method.
 919         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
 920         (struct tui_cmd_window): Set can_highlight.
 921
 922 2019-06-25  Tom Tromey  <tom@tromey.com>
 923
 924         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
 925         from make_visible.
 926         (tui_make_visible, tui_make_invisible): Rewrite.
 927         (tui_win_info::make_visible): Remove.
 928         (tui_source_window_base::make_visible): Update.
 929         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
 930         method.  Moved from...
 931         (struct tui_win_info) <make_visible>: ...here.
 932
 933 2019-06-25  Tom Tromey  <tom@tromey.com>
 934
 935         * tui/tui-winsource.c
 936         (tui_source_window_base::do_scroll_horizontal): Remove direction
 937         parameter.
 938         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
 939         direction parameter.
 940         * tui/tui-win.c (tui_win_info::forward_scroll)
 941         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 942         (tui_win_info::right_scroll): Update.
 943         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
 944         direction parameter.
 945         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
 946         direction parameter.
 947         * tui/tui-data.h (enum tui_scroll_direction): Remove.
 948         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
 949         Remove direction parameter.
 950         (struct tui_source_window_base, struct tui_source_window)
 951         (struct tui_disasm_window, struct tui_data_window)
 952         (struct tui_cmd_window): Update.
 953
 954 2019-06-25  Tom Tromey  <tom@tromey.com>
 955
 956         * tui/tui-winsource.h (tui_set_exec_info_content)
 957         (tui_show_exec_info_content, tui_erase_exec_info_content)
 958         (tui_clear_exec_info_content, tui_update_exec_info): Change
 959         argument to tui_source_window_base.
 960         * tui/tui-winsource.c (tui_set_exec_info_content)
 961         (tui_show_exec_info_content, tui_erase_exec_info_content)
 962         (tui_clear_exec_info_content, tui_update_exec_info): Change
 963         argument to tui_source_window_base.
 964
 965 2019-06-25  Tom Tromey  <tom@tromey.com>
 966
 967         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
 968         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
 969
 970 2019-06-25  Tom Tromey  <tom@tromey.com>
 971
 972         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
 973         check.
 974
 975 2019-06-25  Tom Tromey  <tom@tromey.com>
 976
 977         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
 978         type to void.
 979         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
 980         type to void.
 981         * tui/tui-source.c (tui_set_source_content): Update.
 982         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 983
 984 2019-06-25  Tom Tromey  <tom@tromey.com>
 985
 986         * tui/tui-win.c (window_name_completer, tui_set_focus)
 987         (tui_all_windows_info): Use name method.
 988         * tui/tui-data.h (struct tui_gen_win_info)
 989         (struct tui_source_window, struct tui_disasm_window)
 990         (struct tui_data_window, struct tui_cmd_window) <name>: New
 991         method.
 992         (tui_win_name): Don't declare.
 993         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
 994         (tui_win_name): Remove.
 995
 996 2019-06-25  Tom Tromey  <tom@tromey.com>
 997
 998         * tui/tui-winsource.h (tui_update_source_window)
 999         (tui_update_source_window_as_is): Change parameter type.
1000         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1001         to be a tui_source_window_base.
1002         (tui_update_source_window_as_is): Likewise.
1003         * tui/tui-win.c (make_visible_with_new_height): Update.
1004
1005 2019-06-25  Tom Tromey  <tom@tromey.com>
1006
1007         * tui/tui-winsource.c (tui_erase_source_content)
1008         (tui_show_source_content, tui_show_exec_info_content)
1009         (tui_erase_exec_info_content): Use refresh_window method.
1010         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1011         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1012         from tui_refresh_win.
1013         (tui_data_window::refresh_window): New method.
1014         (tui_win_info::refresh, tui_source_window_base::refresh)
1015         (tui_refresh_all): Use refresh_window method.
1016         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1017         method.
1018         * tui/tui-regs.c (tui_display_register): Call refresh_window
1019         method.
1020         * tui/tui-layout.c (show_source_disasm_command)
1021         (show_source_or_disasm_and_command): Call refresh_window method.
1022         * tui/tui-data.h (struct tui_gen_win_info)
1023         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1024         New method.
1025
1026 2019-06-25  Tom Tromey  <tom@tromey.com>
1027
1028         * tui/tui.c (tui_rl_other_window, tui_enable)
1029         (tui_is_window_visible, tui_get_command_dimension): Update.
1030         * tui/tui-winsource.c (tui_update_source_window_as_is)
1031         (tui_clear_source_content, tui_erase_source_content)
1032         (tui_show_source_line, tui_source_window_base::refill)
1033         (tui_source_window_base::do_scroll_horizontal)
1034         (tui_source_window_base::set_is_exec_point_at)
1035         (tui_update_breakpoint_info, tui_set_exec_info_content)
1036         (tui_alloc_source_buffer, tui_line_is_displayed)
1037         (tui_addr_is_displayed): Update.
1038         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1039         (tui_check_and_display_highlight_if_needed)
1040         (tui_win_info::make_visible, tui_win_info::refresh)
1041         (tui_refresh_all): Update.
1042         * tui/tui-windata.c (tui_first_data_item_displayed)
1043         (tui_delete_data_content_windows, tui_erase_data_content)
1044         (tui_display_all_data, tui_data_window::refresh_all)
1045         (tui_check_data_values): Update.
1046         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1047         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1048         (tui_win_info::backward_scroll, tui_refresh_all_win)
1049         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1050         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1051         (tui_source_window_base::set_new_height)
1052         (tui_data_window::set_new_height)
1053         (make_invisible_and_set_new_height)
1054         (make_visible_with_new_height, new_height_ok)
1055         (parse_scrolling_args): Update.
1056         * tui/tui-stack.c (tui_show_frame_info): Update.
1057         * tui/tui-source.c (tui_set_source_content)
1058         (tui_set_source_content_nil, tui_source_is_displayed)
1059         (tui_source_window::do_scroll_vertical): Update.
1060         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1061         (tui_display_registers_from, tui_display_reg_element_at_line)
1062         (tui_check_register_values, tui_reg_command): Update.
1063         * tui/tui-layout.c (tui_default_win_height)
1064         (show_source_disasm_command, show_data, init_and_make_win)
1065         (show_source_or_disasm_and_command): Update.
1066         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1067         (tui_redisplay_readline, tui_mld_flush)
1068         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1069         (tui_getc): Update.
1070         * tui/tui-disasm.c (tui_set_disassem_content)
1071         (tui_disasm_window::do_scroll_vertical): Update.
1072         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1073         Now virtual.
1074         (struct tui_win_info): Derive from tui_gen_win_info.
1075         <~tui_win_info>: Mark as override.
1076         <generic>: Remove member.
1077         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1078         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1079         (~tui_data_window, ~tui_win_info)
1080         (tui_free_all_source_wins_content): Update.
1081         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1082
1083 2019-06-25  Tom Tromey  <tom@tromey.com>
1084
1085         * tui/tui-layout.c (init_and_make_win): Use new.
1086         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1087         destructor, initializers.
1088         (tui_alloc_generic_win_info): Don't declare.
1089         * tui/tui-data.c (_locator): Add argument to constructor.
1090         (source_win, disasm_win): New globals.
1091         (exec_info): Remove.
1092         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1093         Update.
1094         (tui_alloc_generic_win_info): Remove.
1095         (init_content_element): Use new.
1096         (tui_win_info::tui_win_info): Update.
1097         (free_content_elements) <case DATA_WIN>: Use delete.
1098
1099 2019-06-25  Tom Tromey  <tom@tromey.com>
1100
1101         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1102         * tui/tui-windata.c (tui_first_data_item_displayed)
1103         (tui_delete_data_content_windows): Update.
1104         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1105         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1106         (tui_display_registers_from, tui_check_register_values): Update.
1107         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1108         pointer.
1109         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1110         window.
1111         (tui_free_data_content): Update.
1112         (free_content_elements) <case DATA_WIN>: Free the window.
1113
1114 2019-06-25  Tom Tromey  <tom@tromey.com>
1115
1116         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1117         Update.
1118         * tui/tui-layout.c (make_command_window)
1119         (show_source_disasm_command, show_data, init_and_make_win)
1120         (show_source_or_disasm_and_command): Update.
1121         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1122         method.
1123         <can_highight, is_highlighted>: Now bool.
1124         (tui_set_win_highlight): Don't declare.
1125         * tui/tui-data.c (tui_set_win_highlight): Remove.
1126
1127 2019-06-25  Tom Tromey  <tom@tromey.com>
1128
1129         * tui/tui-wingeneral.c (make_visible): Remove check of window
1130         type.
1131
1132 2019-06-25  Tom Tromey  <tom@tromey.com>
1133
1134         * tui/tui-win.c (tui_win_info::max_height)
1135         (tui_cmd_window::max_height): New methods.
1136         (new_height_ok): Call max_height.
1137         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1138         <max_height>: New method.
1139
1140 2019-06-25  Tom Tromey  <tom@tromey.com>
1141
1142         * tui/tui-win.c (tui_source_window_base::set_new_height)
1143         (tui_data_window::set_new_height): New methods.
1144         (make_invisible_and_set_new_height): Call set_new_height method.
1145         * tui/tui-data.h (struct tui_win_info)
1146         (struct tui_source_window_base, struct tui_data_window)
1147         <set_new_height>: New method.
1148
1149 2019-06-25  Tom Tromey  <tom@tromey.com>
1150
1151         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1152         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1153         tui_refresh_data_win.
1154         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1155         method.
1156         (tui_refresh_all_win): Call the refresh_all method.
1157         (tui_set_focus): Likewise.
1158         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1159         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1160         Likewise.
1161
1162 2019-06-25  Tom Tromey  <tom@tromey.com>
1163
1164         * tui/tui-winsource.h (tui_refill_source_window)
1165         (tui_set_is_exec_point_at): Don't declare.
1166         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1167         (tui_source_window_base::refill): Rename from
1168         tui_refill_source_window.
1169         (tui_source_window_base::do_scroll_horizontal): Update.
1170         (tui_source_window_base::set_is_exec_point_at): Rename from
1171         tui_set_is_exec_point_at.
1172         (tui_update_all_breakpoint_info): Update.
1173         * tui/tui-stack.c (tui_show_frame_info): Update.
1174         * tui/tui-layout.c (show_data): Add cast.
1175         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1176         * tui/tui-data.h (struct tui_source_window_base) <refill,
1177         set_is_exec_point_at>: New methods.
1178         (tui_source_windows, tui_add_to_source_windows): Update types.
1179         (tui_add_to_source_windows): Remove redundant declaration.
1180         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1181         (tui_source_windows): Change return type.
1182         (tui_clear_source_windows_detail): Update.
1183         (tui_add_to_source_windows): Change type of parameter.
1184         (tui_free_all_source_wins_content): Update.
1185
1186 2019-06-25  Tom Tromey  <tom@tromey.com>
1187
1188         * tui/tui-wingeneral.c (tui_win_info::refresh)
1189         (tui_source_window_base::refresh): New methods.
1190         (tui_refresh_all): Call the refresh method.
1191         * tui/tui-data.h (struct tui_win_info)
1192         (struct tui_source_window_base) <refresh>: New method.
1193
1194 2019-06-25  Tom Tromey  <tom@tromey.com>
1195
1196         * tui/tui.h (tui_is_window_visible): Return bool.
1197         * tui/tui.c (tui_is_window_visible): Return bool.
1198         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1199         (tui_make_visible, tui_make_invisible)
1200         (tui_win_info::make_visible)
1201         (tui_source_window_base::make_visible, make_all_visible)
1202         (tui_make_all_visible, tui_make_all_invisible): Update.
1203         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1204         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1205         bool.
1206         (struct tui_win_info, struct tui_source_window_base)
1207         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1208         * tui/tui-data.c (tui_init_generic_part): Update.
1209
1210 2019-06-25  Tom Tromey  <tom@tromey.com>
1211
1212         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1213         (tui_source_window_base::make_visible): New methods.
1214         (make_all_visible): Make method call.
1215         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1216         (struct tui_source_window_base, struct tui_cmd_window): Override
1217         make_visible.
1218         (tui_win_is_source_type): Don't declare.
1219         * tui/tui-data.c (tui_win_is_source_type): Remove.
1220
1221 2019-06-25  Tom Tromey  <tom@tromey.com>
1222
1223         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1224         NULL check.
1225
1226 2019-06-25  Tom Tromey  <tom@tromey.com>
1227
1228         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1229         Inline constructor.  Add initializers for members.
1230         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1231         constructors; now inline in class.
1232
1233 2019-06-25  Tom Tromey  <tom@tromey.com>
1234
1235         * tui/tui-regs.c (tui_show_registers): Update.
1236         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1237         bool.
1238         * tui/tui-data.c (tui_data_window::clear_detail)
1239         (tui_data_window): Update.
1240
1241 2019-06-25  Tom Tromey  <tom@tromey.com>
1242
1243         * tui/tui-windata.c (tui_display_all_data)
1244         (tui_display_data_from_line, tui_display_data_from)
1245         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1246         Update.
1247         * tui/tui-regs.c (tui_last_regs_line_no)
1248         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1249         (tui_show_registers, tui_show_register_group)
1250         (tui_display_registers_from, tui_display_reg_element_at_line)
1251         (tui_display_registers_from_line, tui_check_register_values)
1252         (tui_reg_next, tui_reg_prev): Update.
1253         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1254         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1255         tui_data_window.
1256         (struct tui_win_info) <detail>: Remove.  Add new fields from
1257         tui_data_info.
1258         (TUI_DATA_WIN): Add cast.
1259         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1260         (~tui_data_window): Simplify.
1261
1262 2019-06-25  Tom Tromey  <tom@tromey.com>
1263
1264         * tui/tui-layout.c (show_source_disasm_command)
1265         (show_source_or_disasm_and_command): Update.
1266         * tui/tui-io.c (update_cmdwin_start_line)
1267         (tui_redisplay_readline): Update.
1268         * tui/tui-data.h (struct tui_command_info): Remove.
1269         (struct tui_win_info) <detail>: Remove command_info member.
1270         (struct tui_data_window) <start_line>: New member, from
1271         tui_command_info.
1272         (TUI_CMD_WIN): Add casts.
1273
1274 2019-06-25  Tom Tromey  <tom@tromey.com>
1275
1276         * tui/tui-winsource.c (tui_update_source_window)
1277         (tui_refill_source_window)
1278         (tui_source_window_base::do_scroll_horizontal)
1279         (tui_update_breakpoint_info, tui_set_exec_info_content)
1280         (tui_show_exec_info_content, tui_erase_exec_info_content)
1281         (tui_clear_exec_info_content): Update.
1282         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1283         Update.
1284         * tui/tui-win.c (make_invisible_and_set_new_height)
1285         (make_visible_with_new_height): Update.
1286         * tui/tui-source.c (tui_set_source_content)
1287         (tui_show_symtab_source): Update.
1288         * tui/tui-layout.c (extract_display_start_addr)
1289         (show_source_disasm_command, show_data)
1290         (make_source_or_disasm_window)
1291         (show_source_or_disasm_and_command): Update.
1292         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1293         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1294         "gdbarch".
1295         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1296         to tui_source_window_base.
1297         (struct tui_win_info) <detail>: Remove source_info member.
1298         (struct tui_source_window_base) <has_locator>: Inline.
1299         Move contents from tui_source_info; rename has_locator member to
1300         m_has_locator.
1301         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1302         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1303         header file.
1304         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1305         Simplify.
1306         (tui_free_all_source_wins_content): Cast to
1307         tui_source_window_base.
1308
1309 2019-06-25  Tom Tromey  <tom@tromey.com>
1310
1311         * tui/tui-win.c (make_invisible_and_set_new_height)
1312         (make_visible_with_new_height): Call has_locator method.
1313         * tui/tui-layout.c (show_source_disasm_command, show_data)
1314         (show_source_or_disasm_and_command): Update for bool change.
1315         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1316         (tui_win_info) <has_locator>: New method.
1317         (struct tui_source_window_base) <has_locator>: New method.
1318         (tui_win_has_locator): Don't declare.
1319         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1320         from tui_win_has_locator.
1321         (tui_source_window_base): Use false, not FALSE.
1322
1323 2019-06-25  Tom Tromey  <tom@tromey.com>
1324
1325         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1326         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1327         clear_detail method directly.
1328         (tui_clear_win_detail): Remove.
1329
1330 2019-06-25  Tom Tromey  <tom@tromey.com>
1331
1332         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1333         "this", not TUI_DISASM_WIN.
1334
1335 2019-06-25  Tom Tromey  <tom@tromey.com>
1336
1337         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1338         declare.
1339         * tui/tui-winsource.c
1340         (tui_source_window_base::do_scroll_horizontal): Rename from
1341         tui_horizontal_source_scroll.
1342         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1343         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1344         from tui_vertical_data_scroll.
1345         * tui/tui-win.h (tui_scroll): Don't declare.
1346         * tui/tui-win.c (tui_win_info::forward_scroll)
1347         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1348         (tui_win_info::right_scroll): Rename and update.
1349         (tui_scroll_forward_command, tui_scroll_backward_command)
1350         (tui_scroll_left_command, tui_scroll_right_command): Update.
1351         (tui_scroll): Remove.
1352         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1353         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1354         from tui_vertical_source_scroll.
1355         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1356         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1357         from tui_vertical_disassem_scroll.
1358         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1359         do_scroll_horizontal>: New methods.
1360         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1361         Likewise.
1362         (struct tui_source_window_base): Add do_scroll_horizontal.
1363         (struct tui_source_window, struct tui_disasm_window): Add
1364         do_scroll_vertical.
1365         (struct tui_data_window, struct tui_cmd_window): Add
1366         do_scroll_horizontal and do_scroll_vertical.
1367         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1368
1369 2019-06-25  Tom Tromey  <tom@tromey.com>
1370
1371         * tui/tui-data.h (struct tui_source_window_base): New struct.
1372         (struct tui_source_window): Derive from tui_source_window_base.
1373         (struct tui_disasm_window): New struct.
1374         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1375         from tui_source_window::clear_detail.
1376         (tui_source_window_base): Rename from tui_source_window.
1377         (~tui_source_window_base): Rename from ~tui_source_window.
1378         (tui_alloc_win_info): Create a tui_disasm_window.
1379
1380 2019-06-25  Tom Tromey  <tom@tromey.com>
1381
1382         * tui/tui-data.h (struct tui_source_window)
1383         (struct tui_data_window): Declare destructors.
1384         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1385         destructors.
1386         (tui_win_info): Simplify.
1387
1388 2019-06-25  Tom Tromey  <tom@tromey.com>
1389
1390         * tui/tui-winsource.c (tui_display_main)
1391         (tui_update_source_windows_with_addr)
1392         (tui_update_all_breakpoint_info): Update.
1393         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1394         (new_height_ok, parse_scrolling_args): Update.
1395         * tui/tui-stack.c (tui_show_frame_info): Update.
1396         * tui/tui-data.h (struct tui_list): Remove.
1397         (tui_source_windows): Return a reference to a std::vector.
1398         * tui/tui-data.c (source_windows): Now a std::vector.
1399         (tui_source_windows): Change return type.
1400         (tui_clear_source_windows): Rewrite.
1401         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1402         (tui_free_all_source_wins_content): Rewrite.
1403
1404 2019-06-25  Tom Tromey  <tom@tromey.com>
1405
1406         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1407         (struct tui_data_window, struct tui_cmd_window): Declare
1408         clear_detail method.
1409         * tui/tui-data.c (tui_source_window::clear_detail)
1410         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1411         methods.
1412         (tui_clear_win_detail): Simplify.
1413
1414 2019-06-25  Tom Tromey  <tom@tromey.com>
1415
1416         * tui/tui-layout.c (make_source_window, make_disasm_window)
1417         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1418         Return the new window.
1419         (show_source_disasm_command, show_data)
1420         (show_source_or_disasm_and_command): Update.
1421
1422 2019-06-25  Tom Tromey  <tom@tromey.com>
1423
1424         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1425         parameter.  Return the new window.
1426         (show_source_disasm_command): Update and remove NULL check.
1427         (show_source_or_disasm_and_command): Update.
1428
1429 2019-06-25  Tom Tromey  <tom@tromey.com>
1430
1431         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1432
1433 2019-06-25  Tom Tromey  <tom@tromey.com>
1434
1435         * tui/tui-data.h (struct tui_win_info): Make constructor
1436         protected.  Make destructor virtual.  Add initializers.
1437         (tui_source_window, tui_data_window, tui_cmd_window): New
1438         classes.
1439         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1440         constructor.  Add "type" parameter.
1441         (tui_source_window, tui_data_window, tui_cmd_window): New
1442         constructors.
1443         (tui_alloc_win_info): Instantiate the appropriate subclass.
1444
1445 2019-06-25  Tom Tromey  <tom@tromey.com>
1446
1447         * tui/tui-win.c (tui_resize_all): Use delete.
1448         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1449         destructor.
1450         (tui_free_window): Don't declare.
1451         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1452         Update.
1453
1454 2019-06-25  Tom Tromey  <tom@tromey.com>
1455
1456         * tui/tui-data.h (struct tui_win_info): Add constructor.
1457         * tui/tui-data.c (tui_alloc_win_info): Use new.
1458         (tui_free_window): Use delete.
1459
1460 2019-06-22  Tom Tromey  <tom@tromey.com>
1461
1462         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1463         declare.
1464         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1465
1466 2019-06-22  Tom Tromey  <tom@tromey.com>
1467
1468         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1469         declare.
1470         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1471
1472 2019-06-22  Tom de Vries  <tdevries@suse.de>
1473
1474         * dwarf2read.c (create_addrmap_from_aranges)
1475         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1476         instead of '%zu'.
1477
1478 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1479
1480         * dwarf2read.h (dwarf2_section_info_def): Remove.
1481         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1482         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1483         std::vector<dwarf2_section_info>.
1484         (struct dwo_file) <~dwo_file>: Remove.
1485         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1486         types field.
1487         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1488         (dwarf2_read_debug_names): Likewise.
1489         (create_debug_types_hash_table): Change parameter type to
1490         array_view, adjust code accordingly.
1491         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1492         (partial_die_info::fixup): Likewise.
1493         (determine_prefix): Likewise.
1494         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1495
1496 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1497
1498         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1499         gdb_bfd_ref_ptr.
1500         <~dwo_file>: Remove call to gdb_bfd_unref.
1501         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1502         gdb_bfd_ref_ptr::get.
1503
1504 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1505
1506         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1507         type to htab_up.
1508         * dwarf2read.c (struct dwo_file): Initialize fields.
1509         <~dwo_file>: New.
1510         (free_dwo_file): Remove, move content to ~dwo_file.
1511         (struct dwo_file_deleter): Remove.
1512         (dwo_file_up>: Remove custom deleter.
1513         (free_dwo_files): Remove.
1514         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1515         dwo_files.
1516         (process_skeletonless_type_units): Call unique_ptr::get.
1517         (allocate_dwo_file_hash_table): Add deleter to created hash
1518         table.  Change return type to htab_up.
1519         (lookup_dwo_file_slot): Don't memset dwo_file, call
1520         unique_ptr::get.
1521         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1522         (create_dwo_unit_in_dwp_v2): Likewise.
1523         (open_and_init_dwo_file): Likewise.
1524         (free_dwo_file_from_slot): Remove.
1525
1526 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1527
1528         * dwarf2read.h (struct dwarf2_section_info) <readin,
1529         is_virtual>: Change type to bool.
1530         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1531         true instead of 1.
1532
1533 2019-06-19  Tom Tromey  <tom@tromey.com>
1534
1535         * tui/tui-data.h (tui_init_content_element): Don't declare.
1536
1537 2019-06-19  Tom Tromey  <tom@tromey.com>
1538
1539         * tui/tui-data.h (tui_init_win_info): Don't declare.
1540
1541 2019-06-19  Tom de Vries  <tdevries@suse.de>
1542
1543         * dwarf2read.h (abstract_to_concrete): Change type to
1544         std::unordered_map<sect_offset, std::vector<sect_offset>,
1545         gdb::hash_enum<sect_offset>>.
1546
1547 2019-06-19  Tom Tromey  <tromey@adacore.com>
1548
1549         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1550         EVAL_AVOID_SIDE_EFFECTS specially.
1551
1552 2019-06-19  Tom Tromey  <tromey@adacore.com>
1553
1554         * source-cache.c (highlighter): New global.
1555         (source_cache::get_source_lines): Create a highlighter on demand.
1556
1557 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1558
1559         * defs.h (deprecated_interactive_hook): Delete declaration.
1560         * interps.c (clear_interpreter_hooks): Remove use of
1561         deprecated_interactive_hook.
1562         * top.c (deprecated_interactive_hook): Delete definition.
1563         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1564
1565 2019-06-18  Tom de Vries  <tdevries@suse.de>
1566
1567         PR gdb/24515
1568         * dwarf2read.h (abstract_to_concrete): Change type from
1569         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1570         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1571         * dwarf2read.c (read_variable): Update.
1572         (dwarf2_fetch_die_loc_sect_off): Update.
1573
1574 2019-06-17  Tom de Vries  <tdevries@suse.de>
1575
1576         PR gdb/24617
1577         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1578         accessing parent[parent_len - 1].
1579
1580 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1581
1582         PR gdb/24364
1583         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1584         call dtrace_process_dof with NULL dof.
1585
1586 2019-06-16  Tom de Vries  <tdevries@suse.de>
1587
1588         PR gdb/24445
1589         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1590
1591 2019-06-16  Tom Tromey  <tom@tromey.com>
1592
1593         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1594         (make_all_visible): Use address of member.
1595
1596 2019-06-16  Tom Tromey  <tom@tromey.com>
1597
1598         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1599         (tui_free_window, free_content, free_content_elements): Remove
1600         unnecessary cast.
1601         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1602         cast.
1603         * tui/tui-regs.c (tui_show_register_group)
1604         (tui_display_registers_from, tui_display_reg_element_at_line):
1605         Remove unnecessary cast.
1606
1607 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1608
1609         * linux-nat.c (normal_mask): Delete.
1610         (_initialize_linux_nat): Don't initialise normal_mask.
1611
1612 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1613
1614         PR gdb/24445
1615         * dwarf-index-write.h (write_psymtabs_to_index): Add
1616         dwz_basename parameter.
1617         * dwarf-index-write.c (write_gdbindex): Move file writing to
1618         write_gdbindex_1.  Change return type void.
1619         (assert_file_size): Move up, remove filename parameter.
1620         (write_gdbindex_1): New function.
1621         (write_debug_names): Change return type to void, call
1622         assert_file_size.
1623         (struct index_wip_file): New struct.
1624         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1625         file logic to index_wip_file.  Write index for dwz file if
1626         needed.
1627         (save_gdb_index_command): Pass basename of dwz file, if present.
1628         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1629         build-id of dwz file, if present.
1630         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1631         (dwarf2_get_dwz_file): Likewise.
1632         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1633         (dwarf2_get_dwz_file): Likewise.
1634
1635 2019-06-16  Tom Tromey  <tom@tromey.com>
1636
1637         * coffread.c (process_coff_symbol): Use xstrdup.
1638         * value.c (create_internalvar): Use xstrdup.
1639
1640 2019-06-16  Tom Tromey  <tom@tromey.com>
1641
1642         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1643         * breakpoint.c (stopin_command, stopat_command)
1644         (until_break_command, decode_location_default): Remove unnecessary
1645         cast.
1646         * utils.c (subset_compare): Remove unnecessary cast.
1647         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1648         cast.
1649         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1650         cast.
1651         * infcmd.c (path_command): Remove unnecessary cast.
1652         * coffread.c (decode_type): Remove unnecessary cast.
1653         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1654         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1655         * tui/tui-stack.c (tui_show_locator_content)
1656         (tui_show_frame_info): Remove unnecessary cast.
1657         * tui/tui-win.c (tui_scroll_forward_command)
1658         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1659         (parse_scrolling_args): Remove unnecessary cast.
1660         * tui/tui-data.c (init_win_info, tui_del_window)
1661         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1662         (free_content_elements): Remove unnecessary cast.
1663         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1664         unnecessary cast.
1665         * tui/tui-source.c (tui_set_source_content)
1666         (tui_vertical_source_scroll): Remove unnecessary cast.
1667         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1668         cast.
1669         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1670         * tui/tui-regs.c (tui_display_registers_from)
1671         (tui_display_register): Remove unnecessary cast.
1672         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1673         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1674         (make_visible): Remove unnecessary cast.
1675         * tui/tui-winsource.c (tui_erase_source_content)
1676         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1677         unnecessary cast.
1678         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1679         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1680         * stabsread.c (read_type, read_array_type, read_range_type):
1681         Remove unnecessary cast.
1682         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1683         (parse_symbol, parse_type, upgrade_type, parse_external)
1684         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1685         unnecessary cast.
1686         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1687
1688 2019-06-16  Tom Tromey  <tom@tromey.com>
1689
1690         * tui/tui-data.c (tui_alloc_generic_win_info)
1691         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1692         checks.
1693
1694 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1695             Andrew Burgess  <andrew.burgess@embecosm.com>
1696
1697         * f-typeprint.c (f_print_type): Don't return early for not
1698         associated or not allocated types.
1699         (f_type_print_varspec_suffix): Add print_rank parameter and print
1700         ranks of array types in case they dangling.
1701         (f_type_print_base): Add print_rank parameter.
1702
1703 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1704
1705         * NEWS: Mention new MI commands.
1706         * break-catch-throw.c (enum exception_event_kind): Move to
1707         breakpoint.h.
1708         (print_mention_exception_catchpoint): Output text as a single
1709         message.
1710         (catch_exception_command_1): Rename to...
1711         (catch_exception_event): ...this, make non-static, update header
1712         command, and change some parameter types.
1713         (catch_catch_command): Update for changes to
1714         catch_exception_command_1.
1715         (catch_throw_command): Likewise.
1716         (catch_rethrow_command): Likewise.
1717         * breakpoint.c (enum exception_event_kind): Delete.
1718         * breakpoint.h (enum exception_event_kind): Moved here from
1719         break-catch-throw.c.
1720         (catch_exception_event): Declare.
1721         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1722         (mi_cmd_catch_throw): New function.
1723         (mi_cmd_catch_rethrow): New function.
1724         (mi_cmd_catch_catch): New function.
1725         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1726         'catch-catch' entries.
1727         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1728         (mi_cmd_catch_rethrow): Declare.
1729         (mi_cmd_catch_catch): Declare.
1730
1731 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1732
1733         * annotate.c (annotate_source_line): Change return type to void,
1734         update implementation to match.
1735         * annotate.h (annotate_source_line): Change return type to void,
1736         update header comment.
1737         * stack.c (print_frame_info): Don't change what frame information
1738         is printed based on whether annotations are on or not.
1739
1740 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1741
1742         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1743         (annotate_source): Make static.
1744         (annotate_source_line): Moved from source.c and renamed from
1745         identify_source_line.  Update the return type.
1746         * annotate.h (annotate_source): Delete declaration.
1747         (annotate_source_line): Declaration moved from source.h, and
1748         renamed from identify_source_line.  Return type updated.
1749         * source.c (identify_source_line): Moved to annotate.c and renamed
1750         to annotate_source_line.
1751         (info_line_command): Remove check of annotation_level.
1752         * source.h (identify_source_line): Move declaration to annotate.h
1753         and rename to annotate_source_line.
1754         * stack.c: Add 'annotate.h' include.
1755         (print_frame_info): Remove check of annotation_level before
1756         calling annotate_source_line.
1757
1758 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1759
1760         * source-cache.c (source_cache::get_plain_source_lines): Use
1761         open_source_file_with_line_charpos instead of just
1762         open_source_file, remove call to find_source_lines.
1763         (source_cache::get_source_lines): Likewise.
1764         * source.c (find_source_lines): Make static.
1765         (get_filename_and_charpos): Renamed into...
1766         (open_source_file_with_line_charpos): ..this along with changes to
1767         return a scoped_fd, and some other minor clean ups.
1768         (identify_source_line): Use open_source_file_with_line_charpos.
1769         (search_command_helper): Use open_source_file_with_line_charpos
1770         instead of just open_source_file, remove call to
1771         find_source_lines.
1772         * source.h (open_source_file_with_line_charpos): Declare new
1773         function.
1774         (find_source_lines): Delete declaration.
1775
1776 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1777
1778         * source.c (get_filename_and_charpos): Remove fullname
1779         parameter.
1780         (identify_source_line): Update call to get_filename_and_charpos.
1781
1782 2019-06-14  Tom Tromey  <tromey@adacore.com>
1783
1784         PR gdb/24502:
1785         * ui-style.h (skip_ansi_escape): Update comment.
1786         * ui-file.h (class no_terminal_escape_file): New class.
1787         * ui-file.c (no_terminal_escape_file::write)
1788         (no_terminal_escape_file::puts): New methods.
1789         * cli/cli-logging.c (handle_redirections): Use
1790         no_terminal_escape_file.
1791
1792 2019-06-14  Tom Tromey  <tromey@adacore.com>
1793
1794         * NEWS: Move convenience variable news above Python news.
1795
1796 2019-06-14  Tom Tromey  <tom@tromey.com>
1797
1798         * gnulib: Move directory to top-level.
1799         * configure.ac: Don't configure gnulib.
1800         * configure: Rebuild.
1801         * common/common-defs.h: Use new path to gnulib.
1802         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1803         (GNULIB_H): Remove.
1804         (INCGNU): Look in new gnulib location.
1805         (HFILES_NO_SRCDIR): Remove gnulib files.
1806         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1807         (generated_files): Remove GNULIB_H.
1808         ($(LIBGNU), all-lib): Remove targets.
1809         (distclean): Don't mention GNULIB_BUILDDIR.
1810         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1811
1812 2019-06-14  Tom Tromey  <tromey@adacore.com>
1813
1814         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1815         Warn if symbol file does not provide any symbols.
1816
1817 2019-06-14  Tom Tromey  <tromey@adacore.com>
1818
1819         * source.c (find_and_open_source): Respect basenames_may_differ.
1820
1821 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1822
1823         * annotate.c (annotate_breakpoints_invalid): Make use of
1824         scoped_restore_terminal_state.
1825         (annotate_frames_invalid): Likewise.
1826
1827 2019-06-14  Tom Tromey  <tromey@adacore.com>
1828
1829         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1830         allow assignment to an internalvar.
1831
1832 2019-06-14  Tom Tromey  <tromey@adacore.com>
1833
1834         * ada-lex.l: Allow "_" in attribute names.
1835
1836 2019-06-14  Tom Tromey  <tromey@adacore.com>
1837
1838         PR gdb/24653:
1839         * regcache.c (registers_changed): Don't call alloca.
1840         * top.c (execute_command): Don't call alloca.
1841
1842 2019-06-13  Pedro Alves  <palves@redhat.com>
1843
1844         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1845         'expression'.  When parsing an expression, error out if there's
1846         junk after "unlimited".
1847         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1848         (do_set_command): Adjust calls to is_unlimited_literal.
1849
1850 2019-06-13  Pedro Alves  <palves@redhat.com>
1851
1852         * compile/compile.c (make_compile_options_def_group): Add braces
1853         around array_view initializer.
1854         * thread.c (make_thread_apply_all_options_def_group)
1855         (make_thread_apply_all_options_def_group): Likewise.
1856
1857 2019-06-13  Pedro Alves  <palves@redhat.com>
1858
1859         * NEWS (New commands): Mention "maint test-options
1860         require-delimiter", "maint test-options unknown-is-error", "maint
1861         test-options unknown-is-operand" and "maint show
1862         test-options-completion-result".
1863         (New command options, command completion): New section.
1864         (Completion improvements): New section.
1865         Mention that you can abbreviate "unlimited".
1866
1867 2019-06-13  Pedro Alves  <palves@redhat.com>
1868
1869         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1870         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1871         * unittests/cli-utils-selftests.c (test_parse_flags)
1872         (test_parse_flags_qcs): Delete.
1873         (test_cli_utils): Don't call deleted functions.
1874
1875 2019-06-13  Pedro Alves  <palves@redhat.com>
1876
1877         * thread.c: Include "cli/cli-option.h".
1878         (tp_array_compar_ascending): Global.
1879         (tp_array_compar): Delete function.
1880         (tp_array_compar_ascending, tp_array_compar_descending): New
1881         functions.
1882         (ascending_option_def, qcs_flag_option_def)
1883         (thr_qcs_flags_option_defs)
1884         (make_thread_apply_all_options_def_group)
1885         (make_thread_apply_options_def_group): New.
1886         (thread_apply_all_command): Use gdb::option::process_options.
1887         (thread_apply_command_completer)
1888         (thread_apply_all_command_completer): New.
1889         (thread_apply_command): Use gdb::option::process_options.
1890         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1891         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1892         to generate help text of "thread apply".  Adjust "taas"'s help.
1893         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1894         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1895
1896 2019-06-13  Pedro Alves  <palves@redhat.com>
1897
1898         * thread.c (thread_apply_command): Check for invalid TID with
1899         isdigit instead of !isalpha.
1900
1901 2019-06-13  Pedro Alves  <palves@redhat.com>
1902
1903         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1904         (validate_flags_qcs): New.
1905         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1906         (validate_flags_qcs): Declare.
1907         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1908         (make_frame_apply_options_def_group): New.
1909         (frame_apply_command_count): Process options with
1910         gdb::option::process_options.
1911         (frame_apply_completer): New.
1912         (frame_apply_level_completer, frame_apply_all_completer)
1913         (frame_apply_completer): New.
1914         (_initialize_stack): Update help of "frame apply", "frame apply
1915         level", "frame apply all" and "faas" to mention supported options
1916         and install command completers.
1917         * stack.h (frame_apply_all_completer): Declare.
1918         * thread.c: Include "stack.h".
1919         (tfaas_command): Add "--".
1920         (_initialize_thread): Update help "tfaas" to mention supported
1921         options and install command completer.
1922
1923 2019-06-13  Pedro Alves  <palves@redhat.com>
1924
1925         * completer.c (complete_nested_command_line): New.
1926         (gdb_completion_word_break_characters_throw): Add assertion.
1927         * completer.h (complete_nested_command_line): Declare.
1928
1929 2019-06-13  Pedro Alves  <palves@redhat.com>
1930
1931         * stack.c (parse_backtrace_qualifiers): New.
1932         (backtrace_command): Use it.
1933         (backtrace_command_completer): Complete on qualifiers.
1934
1935 2019-06-13  Pedro Alves  <palves@redhat.com>
1936
1937         * frame.c: Include "cli/cli-option.h.
1938         (user_set_backtrace_options): New.
1939         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1940         Delete.
1941         (get_prev_frame): Adjust.
1942         (boolean_option_def, uinteger_option_def)
1943         (set_backtrace_option_defs): New.
1944         (_initialize_frame): Adjust and use
1945         gdb::option::add_setshow_cmds_for_options to install "set
1946         backtrace past-main" and "set backtrace past-entry".
1947         * frame.h: Include "cli/cli-option.h".
1948         (struct frame_print_options): Forward declare.
1949         (print_frame_arguments_all, print_frame_arguments_scalars)
1950         (print_frame_arguments_none): Declare.
1951         (print_entry_values): Delete declaration.
1952         (struct frame_print_options, user_frame_print_options): New.
1953         (struct set_backtrace_options): New.
1954         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1955         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1956         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1957         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1958         (list_args_or_locals): Add frame_print_options parameter.
1959         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1960         * python/py-framefilter.c (enumerate_args): Pass down
1961         USER_FRAME_PRINT_OPTIONS.
1962         * stack.c: Include "cli/cli-option.h".
1963         (print_frame_arguments_all, print_frame_arguments_scalars)
1964         (print_frame_arguments_none): Declare.
1965         (print_raw_frame_arguments, print_entry_values): Delete.
1966         (user_frame_print_options): New.
1967         (boolean_option_def, enum_option_def, frame_print_option_defs):
1968         New.
1969         (struct backtrace_cmd_options): New.
1970         (bt_flag_option_def): New.
1971         (backtrace_command_option_defs): New.
1972         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1973         (print_frame_arg, read_frame_arg, print_frame_args)
1974         (print_frame_info, print_frame): Add frame_print_options parameter
1975         and use it.
1976         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1977         (backtrace_command_1): Add frame_print_options and
1978         backtrace_cmd_options parameters and use them.
1979         (make_backtrace_options_def_group): New.
1980         (backtrace_command): Process command options with
1981         gdb::option::process_options.
1982         (backtrace_command_completer): New.
1983         (_initialize_stack): Extend "backtrace"'s help to mention
1984         supported options.  Install completer for "backtrace".
1985         Install some settings commands with add_setshow_cmds_for_options.
1986
1987 2019-06-13  Pedro Alves  <palves@redhat.com>
1988
1989         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1990         and that "set/show print raw frame-arguments" are now deprecated.
1991
1992         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1993         command.
1994         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1995         * stack.c (_initialize_stack): Install "set/show print
1996         raw-frame-arguments", and deprecate "set/show print raw
1997         frame-arguments".
1998         * valprint.c (_initialize_valprint): Deprecate "set/show print
1999         raw".
2000
2001 2019-06-13  Pedro Alves  <palves@redhat.com>
2002
2003         * compile/compile.c (struct compile_options): New.
2004         (compile_flag_option_def, compile_command_option_defs)
2005         (make_compile_options_def_group): New.
2006         (compile_file_command): Handle options with
2007         gdb::option::process_options.
2008         (compile_file_command_completer): New function.
2009         (compile_code_command): Handle options with
2010         gdb::option::process_options.
2011         (compile_code_command_completer): New function.
2012         (_initialize_compiler): Install completers for "compile code" and
2013         "compile file".  Mention available options in "compile code" and
2014         "compile code"'s help.
2015         * completer.c (advance_to_completion_word): New, factored out from
2016         ...
2017         (advance_to_expression_complete_word_point): ... this.
2018         (advance_to_filename_complete_word_point): New.
2019         * completer.h (advance_to_filename_complete_word_point): New
2020         declaration.
2021
2022 2019-06-13  Pedro Alves  <palves@redhat.com>
2023
2024         * compile/compile.c: Include "cli/cli-option.h".
2025         (compile_print_value): Scope data pointer is now a
2026         value_print_options pointer; adjust.
2027         (compile_print_command): Process options.  Scope data pointer is
2028         now a value_print_options pointer; adjust.
2029         (_initialize_compile): Update "compile print"'s help to include
2030         supported options.  Install a completer for "compile print".
2031         * cp-valprint.c (show_vtblprint, show_objectprint)
2032         (show_static_field_print): Delete.
2033         (_initialize_cp_valprint): Don't install "set print
2034         static-members", "set print vtbl", "set print object" here.
2035         * printcmd.c: Include "cli/cli-option.h" and
2036         "common/gdb_optional.h".
2037         (print_command_parse_format): Rework to fill in a
2038         value_print_options instead of a format_data.
2039         (print_value): Change parameter type from format_data pointer to
2040         value_print_options reference.  Adjust.
2041         (print_command_1): Process options.  Adjust to pass down a
2042         value_print_options.
2043         (print_command_completer): New.
2044         (_initialize_printcmd): Install print_command_completer as
2045         handle_brkchars completer for the "print" command.  Update
2046         "print"'s help to include supported options.
2047         * valprint.c: Include "cli/cli-option.h".
2048         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2049         here from cp-valprint.c.
2050         (boolean_option_def, uinteger_option_def)
2051         (value_print_option_defs, make_value_print_options_def_group):
2052         New.  Use gdb::option::add_setshow_cmds_for_options to install
2053         "set print elements", "set print null-stop", "set print repeats",
2054         "set print pretty", "set print union", "set print array", "set
2055         print address", "set print symbol", "set print array-indexes".
2056         * valprint.h: Include <string> and "cli/cli-option.h".
2057         (make_value_print_options_def_group): Declare.
2058         (print_value): Change parameter type from format_data pointer to
2059         value_print_options reference.
2060         (print_command_completer): Declare.
2061
2062 2019-06-13  Pedro Alves  <palves@redhat.com>
2063
2064         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2065         (COMMON_SFILES): Add maint-test-settings.c.
2066         * cli/cli-decode.c (boolean_enums): New global, factored out from
2067         ...
2068         (add_setshow_boolean_cmd): ... here.
2069         * cli/cli-decode.h (boolean_enums): Declare.
2070         * cli/cli-option.c: New file.
2071         * cli/cli-option.h: New file.
2072         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2073         factored out from ...
2074         (parse_cli_boolean_value(const char *)): ... this.
2075         (is_unlimited_literal): Change parameter type to pointer to
2076         pointer.  Adjust and advance ARG pointer.
2077         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2078         (parse_cli_var_enum): New, factored out from ...
2079         (do_set_command): ... this.  Adjust.
2080         * cli/cli-setshow.h (parse_cli_boolean_value)
2081         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2082         (parse_cli_var_enum): Declare.
2083         * cli/cli-utils.c: Include "cli/cli-option.h".
2084         (get_ulongest): New.
2085         * cli/cli-utils.h (get_ulongest): Declare.
2086         (check_for_argument): New overloads.
2087         * maint-test-options.c: New file.
2088
2089 2019-06-13  Pedro Alves  <palves@redhat.com>
2090
2091         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2092         parse a range if "-" is at the end of the string.
2093
2094 2019-06-13  Pedro Alves  <palves@redhat.com>
2095
2096         * cli/cli-setshow.c (parse_auto_binary_operation)
2097         (parse_cli_boolean_value): Don't allow "o".
2098
2099 2019-06-13  Pedro Alves  <palves@redhat.com>
2100
2101         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2102         * NEWS: Mention maint test-settings KIND.
2103         * maint-test-settings.c: New file.
2104
2105 2019-06-13  Pedro Alves  <palves@redhat.com>
2106
2107         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2108         completer.
2109         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2110         "set" completers.
2111
2112 2019-06-13  Pedro Alves  <palves@redhat.com>
2113
2114         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2115         after item.
2116
2117 2019-06-13  Pedro Alves  <palves@redhat.com>
2118
2119         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2120
2121 2019-06-13  Pedro Alves <palves@redhat.com>
2122
2123         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2124         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2125         call.
2126         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2127         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2128         calls.
2129         (check_for_argument): Skip spaces after argument.
2130
2131 2019-06-13  Pedro Alves  <palves@redhat.com>
2132
2133         * thread.c (thread_apply_command): Adjust TID parsing.
2134         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2135         detected before end of string.
2136         (tid_is_in_list): Error out if LIST is invalid.
2137
2138 2019-06-13  Pedro Alves  <palves@redhat.com>
2139
2140         * completer.c (complete_line_internal_1): Rewind completion word
2141         point.
2142         (completion_tracker::advance_custom_word_point_by): Change
2143         parameter type to int.
2144         * completer.h (completion_tracker::advance_custom_word_point_by):
2145         Likewise.
2146
2147 2019-06-13  Pedro Alves  <palves@redhat.com>
2148
2149         * completer.c (advance_to_completion_word): Handle delimiters.
2150
2151 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2152
2153         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2154
2155 2019-06-11  Tom Tromey  <tom@tromey.com>
2156
2157         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2158         (xmalloc_failed): Move to alloc.c.
2159         * alloc.c: New file.
2160         * Makefile.in (COMMON_SFILES): Add alloc.c.
2161
2162 2019-06-11  Tom Tromey  <tom@tromey.com>
2163
2164         * nat/linux-waitpid.c: Don't include server.h.
2165         (linux_debug): Remove.
2166         (my_waitpid): Update.
2167
2168 2019-06-11  Tom Tromey  <tromey@adacore.com>
2169
2170         * infcall.c (_initialize_infcall): Remove trailing newline from
2171         help.
2172         * user-regs.c (_initialize_user_regs): Remove trailing newline
2173         from help.
2174         * typeprint.c (_initialize_typeprint): Remove trailing newline
2175         from help.
2176         * reverse.c (_initialize_reverse): Remove trailing newlines from
2177         help.
2178         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2179         from help.
2180         * language.c (add_set_language_command): Remove trailing newline
2181         from help.
2182         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2183         help.
2184         * disasm.c (_initialize_disasm): Remove trailing newline from
2185         help.
2186         * top.c (init_main): Remove trailing newline from help.
2187         * interps.c (_initialize_interpreter): Remove trailing newline
2188         from help.
2189         * btrace.c (_initialize_btrace): Remove trailing newlines from
2190         help.
2191         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2192         from help.
2193         * python/python.c (_initialize_python): Remove trailing newline
2194         from help.
2195         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2196         help.
2197         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2198         from help.  Reformat some text.
2199         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2200         from help.
2201         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2202         newline from help.
2203
2204 2019-06-11  Tom Tromey  <tromey@adacore.com>
2205
2206         * darwin-nat.c (darwin_decode_exception_message)
2207         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2208
2209 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2210
2211         * valops.c (value_slice): Check for not allocated or not
2212         associated values.
2213
2214 2019-06-10  Tom de Vries  <tdevries@suse.de>
2215
2216         PR gdb/24618
2217         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2218         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2219         invalid.
2220
2221 2019-06-10  Tom de Vries  <tdevries@suse.de>
2222
2223         PR gdb/24611
2224         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2225         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2226
2227 2019-06-10  Tom de Vries  <tdevries@suse.de>
2228
2229         PR symtab/24545
2230         * symtab.c (struct demangled_name_entry): Add language field.
2231         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2232         static minimal symbol".  Set and use language field.
2233
2234 2019-06-10  Tom Tromey  <tromey@adacore.com>
2235
2236         * ada-lang.c (_initialize_ada_language): Update help text.
2237
2238 2019-06-10  Tom Tromey  <tromey@adacore.com>
2239
2240         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2241         with a newline.
2242         * guile/guile.c (handle_boot_error): Don't end warning with a
2243         newline.
2244         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2245         warning with a newline.
2246         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2247         newline.
2248         (s12z_frame_cache): Likewise.
2249         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2250         a newline.
2251         * solib-svr4.c (disable_probes_interface): Don't end warning with
2252         a newline.
2253         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2254         newline.
2255         * python/python.c (do_finish_initialization): Don't end warning
2256         with a newline.
2257
2258 2019-06-10  Tom Tromey  <tom@tromey.com>
2259
2260         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2261         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2262         gdbpy_enter.
2263
2264 2019-06-10  Tom Tromey  <tromey@adacore.com>
2265
2266         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2267         data.
2268         (elf_new_init): Don't call stabsread_new_init.
2269         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2270         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2271         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2272
2273 2019-06-10  Tom de Vries  <tdevries@suse.de>
2274
2275         PR symtab/16264
2276         PR symtab/24517
2277         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2278
2279 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2280
2281         * source.c (find_and_open_source): Also rewrite relative file
2282         names.
2283
2284 2019-04-26  Amos Bird  <amosbird@gmail.com>
2285
2286         * annotate.c (annotate_thread_exited): Add "thread-exited"
2287         annotation.
2288
2289 2019-06-06  Tom Tromey  <tromey@adacore.com>
2290
2291         * maint.h (class scoped_command_stats): Use
2292         DISABLE_COPY_AND_ASSIGN.
2293         <print_time>: New method.
2294         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2295         print_time.
2296         (scoped_command_stats::print_time): New method.
2297
2298 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2299
2300         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2301         instructions of lengths 6 or 8 bytes.
2302
2303 2019-06-04  Pedro Alves  <palves@redhat.com>
2304
2305         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2306
2307         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2308         * breakpoint.c (condition_completer): Likewise.
2309         * cli/cli-dump.c (scan_expression): Likewise.
2310         * common/filestuff.c (mkdir_recursive): Likewise.
2311         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2312         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2313         (gdb_abspath): Likewise.
2314         * compile/compile-cplus-types.c
2315         (compile_cplus_instance::decl_name): Likewise.
2316         * completer.c (complete_explicit_location):
2317         (signal_completer, reg_or_group_completer_1): Likewise.
2318         * cp-support.c (cp_remove_params_if_any): Likewise.
2319         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2320         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2321         * infcmd.c (strip_bg_char): Likewise.
2322         * linespec.c (copy_token_string): Likewise.
2323         * mi/mi-main.c (output_cores): Likewise.
2324         * psymtab.c (psymtab_search_name):
2325         * symfile.c (test_set_ext_lang_command): Likewise.
2326         * target.c (target_fileio_read_stralloc): Likewise.
2327         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2328         * value.c (complete_internalvar): Likewise.
2329
2330 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2331
2332         Add objfile property to gdb.Type.
2333         * NEWS: Mention Python API addition.
2334         * python/py-type.c (typy_get_objfile): New method.
2335
2336 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2337
2338         * NEWS: Mention the new set|show style [title|highlight].
2339         Mention changes to "show style", "help" and "apropos".
2340
2341 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2342
2343         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2344         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2345         instead of print_help_for_command.
2346         (print_doc_of_command): New function.
2347         (help_list): Add 'apropos -v word' suggestion.
2348         (print_help_for_command): Style the command name using title style.
2349         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2350         (_initialize_cli_cmds): Describe -v in apropos_command help.
2351
2352 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2353
2354         * cli/cli-style.h (cli_style_option): Add name in constructor,
2355         add m_name class member, add constructor with intensity,
2356         add name class function.
2357         (cli_style_option::add_setshow_commands): Remove name argument.
2358         (highlight_style, title_style): New styles.
2359         * cli/cli-style.c (do_show): New function that shows a style
2360         characteristic styling the style name with itself.
2361         (set_style_name): New function.
2362         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2363         Update all callers according to the changes in cli/cli-style.h.
2364         * utils.h (fputs_highlighted): New function.
2365         * utils.c (fputs_highlighted): Likewise.
2366
2367 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2368
2369         * NEWS: Mention new pipe command and new convenience variables.
2370
2371 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2372
2373         * cli/cli-cmds.c (pipe_command): New function.
2374         (_initialize_cli_cmds): Call add_com for pipe_command.
2375         Define | as an alias for pipe.
2376         (exit_status_set_internal_vars): New function.
2377         (shell_escape): Call exit_status_set_internal_vars.
2378         cli/cli-decode.c (find_command_name_length): Recognize | as
2379         a single character command.
2380
2381 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2382
2383         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2384         top.c (execute_command_to_ui_file): New function, mostly a copy
2385         of execute_command_to_string.
2386         (execute_command_to_string): Implement by calling
2387         execute_command_to_ui_file.
2388
2389 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2390
2391         * top.h (saved_command_line): Remove declaration.
2392         * top.c (previous_saved_command_line, previous_repeat_arguments):
2393         New variables.
2394         (saved_command_line): Make static, define together with other
2395         'repeat variables'.
2396         (dont_repeat): Clear repeat_arguments.
2397         (repeat_previous, get_saved_command_line, save_command_line):
2398         New functions.
2399         (gdb_init): Initialize saved_command_line
2400         and previous_saved_command_line.
2401         * main.c (captured_main_1): Remove saved_command_line initialization.
2402         * event-top.c (handle_line_of_input): Update to use
2403         the new 'repeat' related functions instead of direct access to
2404         saved_command_line.
2405         * command.h (repeat_previous, get_saved_command_line,
2406         save_command_line): New declarations.
2407         (dont_repeat): Add comment.
2408
2409 2019-05-30  Tom Tromey  <tromey@adacore.com>
2410
2411         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2412         Fix comment.
2413         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2414
2415 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2416
2417         PR cli/24587
2418         * completer.c (complete): Initialize variable word.
2419
2420 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2421
2422         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2423         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2424         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2425         'body' is NULL to the outter 'if', protecting the '!is_define'
2426         situation as well.
2427
2428 2019-05-29  Tom Tromey  <tromey@adacore.com>
2429
2430         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2431         (dwarf_unknown): New function.
2432         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2433         (dwarf_type_encoding_name): Use dwarf_unknown.
2434
2435 2019-05-29  Tom Tromey  <tromey@adacore.com>
2436
2437         PR c++/20020:
2438         * cp-valprint.c (cp_print_value_fields): Call
2439         cp_print_static_field inside "try".
2440
2441 2019-05-29  Tom Tromey  <tromey@adacore.com>
2442
2443         * inflow.c (struct terminal_info): Add default operator=.
2444         * configure: Rebuild.
2445         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2446         -Wdeprecated-copy-dtor, -Wredundant-move.
2447
2448 2019-05-29  Tom Tromey  <tromey@adacore.com>
2449
2450         * NEWS: Add entry.
2451         * infcmd.c (print_return_value_1): Handle finish_print
2452         option.
2453         (show_print_finish): New function.
2454         (_initialize_infcmd): Add "set/show print finish" commands.
2455         * valprint.c (user_print_options): Initialize new member.
2456         * valprint.h (struct value_print_options) <finish_print>: New
2457         member.
2458
2459 2019-05-28  Tom Tromey  <tromey@adacore.com>
2460
2461         * ada-lang.c (ada_remove_Xbn_suffix)
2462         (find_old_style_renaming_symbol)
2463         (parse_old_style_renaming): Remove.
2464         (ada_find_renaming_symbol): Don't call
2465         find_old_style_renaming_symbol.
2466         (ada_is_renaming_symbol): Rename from
2467         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2468         bool.  Now static.
2469         (ada_read_var_value): Update and simplify.
2470         * ada-exp.y (write_var_or_type): Remove old code.
2471
2472 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2473
2474         * event-top.c: Remove include comment.
2475         * inflow.c (class scoped_ignore_sigttou): Move from here...
2476         * inflow.h (class scoped_ignore_sigttou): ...to here.
2477         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2478         * top.c:  Remove include comment.
2479
2480 2019-05-27  Tom Tromey  <tom@tromey.com>
2481
2482         * NEWS: Fix typo.
2483
2484 2019-05-22  Tom Tromey  <tromey@adacore.com>
2485
2486         * target.c (target_follow_exec): Constify parameter.
2487         * target-delegates.c: Rebuild.
2488         * remote.c (remote_target::follow_exec): Constify parameter.
2489         * infrun.c (follow_exec): Constify parameter.
2490         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2491         (target_follow_exec): Likewise.
2492
2493 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2494
2495         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2496         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2497
2498 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2499
2500         * NEWS: Add debugredirect and testsuite sections.
2501
2502 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2503
2504         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2505         target descriptions using exclusively floating point register name
2506         aliases.
2507
2508 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2509
2510         PR gdb/18644:
2511         * f-lang.c (build_fortran_types): Handle the case where
2512         gdbarch_floatformat_for_type returns a nullptr.
2513
2514 2019-05-21  Tom de Vries  <tdevries@suse.de>
2515
2516         PR cli/24587
2517         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2518
2519 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2520
2521         PR gdb/18644:
2522         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2523         16-byte floats.
2524         * i386-tdep.c (i386_floatformat_for_type): Use
2525         floatformats_ia64_quad for the 16-byte floating point component
2526         within a fortran 32-byte complex number.
2527
2528 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2529
2530         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2531         delete default constructor.
2532         (find_partial_die): Update to return const struct.
2533         (partial_die_parent_scope): Move variable declaration into scope
2534         of its use and change its type to auto.
2535         (guess_partial_die_structure_name): Likewise.
2536         (partial_die_info::fixup): Likewise.
2537
2538 2019-05-17  Tom Tromey  <tromey@adacore.com>
2539
2540         * source.c (find_and_open_source): Remove cast.
2541
2542 2019-05-17  Tom Tromey  <tromey@adacore.com>
2543
2544         * annotate.c (annotate_source): Make "filename" const.
2545         * annotate.h (annotate_source): Use const.
2546
2547 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2548
2549         * disasm.c (set_disassembler_options): Send errors to stderr.
2550
2551 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2552
2553         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2554         (cli_interp_base::set_logging): Check debug_redirect.
2555         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2556         * cli/cli-logging.c (debug_redirect): Add static variable.
2557         (pop_output_files): Add default param.
2558         (handle_redirections): Print debug setting.
2559         (show_logging_command): Likewise.
2560         (_initialize_cli_logging): Add debugredirect command.
2561         * interps.c (current_interp_set_logging): Add debug_redirect
2562         parameter.
2563         * interps.h (set_logging): Add debug_redirect parameter.
2564         (current_interp_set_logging): Likewise.
2565         * mi/mi-common.h: Likewise.
2566         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2567
2568 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2569             Tom Tromey  <tromey@adacore.com>
2570
2571         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2572         directly.
2573         * cli/cli-interp.h (make_logging_output): Remove declaration.
2574         * cli/cli-logging.c (make_logging_output): Remove function.
2575         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2576         directly.
2577         * ui-file.c (tee_file::tee_file): Remove bools.
2578         (tee_file::~tee_file): Remove deletes.
2579         * ui-file.h (tee_file): Remove bools.
2580
2581 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2582
2583         * mi/mi-cmds.h (mi_cmd_complete): New function.
2584         * mi/mi-main.c (mi_cmd_complete): Likewise.
2585         * mi/mi-cmds.c: Define new MI command -complete.
2586         * NEWS: Mention new -complete command.
2587
2588 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2589
2590         * completer.h (complete): New function.
2591         * completer.c (complete): Likewise.
2592         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2593         function defined in completer.h.
2594
2595 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2596
2597         * MAINTAINERS (Write After Approval): Add myself.
2598
2599 2019-05-17  Tom de Vries  <tdevries@suse.de>
2600
2601         PR gdb/24094
2602         * dwarf2read.c (struct cu_partial_die_info): New struct.
2603         (find_partial_die): Return cu_partial_die_info.
2604         (partial_die_parent_scope, guess_partial_die_structure_name)
2605         (partial_die_info::fixup): Handle new return type of find_partial_die.
2606
2607 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2608
2609         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2610         "std::string", simplifying the algorithm.
2611
2612 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2613
2614         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2615         (stap_static_probe_ops::get_probes): Likewise.
2616
2617 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2618
2619         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2620         '-')" and "else if".
2621         (stap_parse_single_operand): Join checks for
2622         "gdbarch_stap_parse_special_token_p" and
2623         "gdbarch_stap_parse_special_token" in the same "if" statement.
2624         Invert check when verifying for operation on register
2625         displacement.
2626
2627 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2628
2629         * stap-probe.c (stap_get_opcode): Update comment.
2630         (stap_get_expected_argument_type): Likewise.
2631         (handle_stap_probe): Likewise.
2632
2633 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2634
2635         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2636         return type to 'bool'.  Adjust comment.  Use 'bool' when
2637         appropriate.
2638         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2639         * stap-probe.c (stap_parse_argument_1): Likewise.
2640         (stap_is_operator): Likewise.
2641         (stap_is_generic_prefix): Likewise.
2642         (stap_is_register_prefix): Likewise.
2643         (stap_is_register_indirection_prefix): Likewise.
2644         (stap_is_integer_prefix): Likewise.
2645         (stap_generic_check_suffix): Likewise.
2646         (stap_check_integer_suffix): Likewise.
2647         (stap_check_register_suffix): Likewise.
2648         (stap_check_register_indirection_suffix): Likewise.
2649         (stap_parse_register_operand): Likewise.
2650         (stap_parse_single_operand): Likewise.
2651         (stap_parse_argument_1): Likewise.
2652         (stap_probe::get_argument_count): Likewise.
2653         (stap_is_operator): Likewise.
2654
2655 2019-05-16  Tom Tromey  <tromey@adacore.com>
2656
2657         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2658         keyword to foreach.
2659
2660 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2661
2662         * linux-thread-db.c (try_thread_db_load_1): Change return type
2663         to bool.
2664         (try_thread_db_load): Likewise.
2665         (try_thread_db_load_from_pdir_1): Likewise.
2666         (try_thread_db_load_from_pdir): Likewise.
2667         (try_thread_db_load_from_sdir): Likewise.
2668         (try_thread_db_load_from_dir): Likewise.
2669         (thread_db_load_search): Likewise.
2670         (has_libpthread): Likewise.
2671         (thread_db_load): Likewise.
2672
2673 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2674
2675         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2676         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2677         NULL, and complain/return if that's the case.
2678
2679 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2680
2681         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2682         (advance, posn, abstract_read_memory): New functions.
2683         [struct mem_read_abstraction]: New struct.
2684         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2685
2686 2019-05-14  Tom Tromey  <tromey@adacore.com>
2687
2688         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2689         value is not lval_memory.
2690
2691 2019-05-14  Tom Tromey  <tromey@adacore.com>
2692
2693         * solib.c (info_sharedlibrary_command): Style the file name.
2694
2695 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2696
2697         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2698         (aarch64_vnv_type): Likewise.
2699         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2700         * common/tdesc.c: Likewise.
2701         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2702         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2703         * features/aarch64-fpu.xml: Add ieee half view.
2704         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2705         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2706         * gdbtypes.h (struct builtin_type): Likewise.
2707         (struct objfile_type): Likewise.
2708
2709 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2710
2711         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2712         typo.
2713         * location.h (string_to_event_location): Likewise.
2714
2715 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2716
2717         GDB 8.3 released.
2718
2719 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2720
2721         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2722         New variable declaration.
2723         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2724         New variable.
2725         (print_one_breakpoint): Use ui_out::test_flags and new global
2726         variable to compute use_fixed_output.
2727         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2728         Remove.
2729         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2730         (mi_multi_location_breakpoint_output_fixed): Remove.
2731         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2732         new variable.
2733         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2734         fix_multi_location_breakpoint_output flag if version >= 3.
2735         * ui-out.h (enum ui_out_flag)
2736         <fix_multi_location_breakpoint_output>: New enumerator.
2737
2738 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2739
2740         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2741
2742 2019-05-10  Tom Tromey  <tromey@adacore.com>
2743
2744         * ada-lang.c (catch_ada_completer): New function.
2745         (_initialize_ada_language): Use it.
2746
2747 2019-05-10  Tom Tromey  <tromey@adacore.com>
2748
2749         * thread.c (print_thread_info): Make "requested_threads" const.
2750         * gdbthread.h (print_thread_info): Make "requested_threads"
2751         const.
2752         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2753         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2754
2755 2019-05-08  Tom Tromey  <tom@tromey.com>
2756
2757         * gdbtypes.c (objfile_type_data): Change type.
2758         (objfile_type, _initialize_gdbtypes): Update.
2759
2760 2019-05-08  Tom Tromey  <tom@tromey.com>
2761
2762         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2763         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2764         (_initialize_dwarf2_frame): Update.
2765
2766 2019-05-08  Tom Tromey  <tom@tromey.com>
2767
2768         * objc-lang.c (objc_objfile_data): Change type.
2769         (find_methods): Update.
2770         (_initialize_objc_lang): Remove.
2771
2772 2019-05-08  Tom Tromey  <tom@tromey.com>
2773
2774         * stabsread.c (rs6000_builtin_type_data): Change type.
2775         (rs6000_builtin_type, _initialize_stabsread): Update.
2776
2777 2019-05-08  Tom Tromey  <tom@tromey.com>
2778
2779         * mips-tdep.c (mips_pdr_data): Remove.
2780         (_initialize_mips_tdep): Update.
2781
2782 2019-05-08  Tom Tromey  <tom@tromey.com>
2783
2784         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2785         (hppa_init_objfile_priv_data, read_unwind_info)
2786         (find_unwind_entry, _initialize_hppa_tdep): Update.
2787
2788 2019-05-08  Tom Tromey  <tom@tromey.com>
2789
2790         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2791         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2792         on obstack.
2793         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2794
2795 2019-05-08  Tom Tromey  <tom@tromey.com>
2796
2797         * mdebugread.c (basic_type_data): Change type.
2798         (basic_type, _initialize_mdebugread): Update.
2799
2800 2019-05-08  Tom Tromey  <tom@tromey.com>
2801
2802         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2803
2804 2019-05-08  Tom Tromey  <tom@tromey.com>
2805
2806         * nto-tdep.c (nto_inferior_data_reg): Change type.
2807         (nto_inferior_data): Update.
2808         (nto_inferior_data_cleanup, nto_new_inferior_data)
2809         (_initialize_nto_tdep): Remove.
2810         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2811
2812 2019-05-08  Tom Tromey  <tom@tromey.com>
2813
2814         * ada-lang.c (struct ada_inferior_data): Add initializers.
2815         (ada_inferior_data): Change type.
2816         (ada_inferior_data_cleanup): Remove.
2817         (get_ada_inferior_data, ada_inferior_exit)
2818         (struct ada_pspace_data): Add initializers, destructor.
2819         (ada_pspace_data_handle): Change type.
2820         (get_ada_pspace_data): Update.
2821         (ada_pspace_data_cleanup): Remove.
2822
2823 2019-05-08  Tom Tromey  <tom@tromey.com>
2824
2825         * coffread.c (struct coff_symfile_info): Add initializers.
2826         (coff_objfile_data_key): Move lower.  Change type.
2827         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2828         Update.
2829         (coff_free_info): Remove.
2830
2831 2019-05-08  Tom Tromey  <tom@tromey.com>
2832
2833         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2834         (fbsd_pspace_data_handle): Move lower.  Change type.
2835         (get_fbsd_pspace_data): Update.
2836         (fbsd_pspace_data_cleanup): Remove.
2837         (_initialize_fbsd_tdep): Update.
2838
2839 2019-05-08  Tom Tromey  <tom@tromey.com>
2840
2841         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2842         (get_ada_tasks_pspace_data): Update.
2843         (ada_tasks_pspace_data_cleanup): Remove.
2844         (_initialize_tasks): Update.
2845         (ada_tasks_inferior_data_handle): Change type.
2846         (get_ada_tasks_inferior_data): Update.
2847         (ada_tasks_inferior_data_cleanup): Remove.
2848         (struct ada_tasks_pspace_data): Add initializers.
2849
2850 2019-05-08  Tom Tromey  <tom@tromey.com>
2851
2852         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2853         * symfile-debug.c (debug_sym_get_probes): Change type.
2854         * stap-probe.c (handle_stap_probe):
2855         (stap_static_probe_ops::get_probes): Change type.
2856         * probe.h (class static_probe_ops) <get_probes>: Change type.
2857         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2858         (parse_probes_in_pspace): Update.
2859         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2860         Update.
2861         (any_static_probe_ops::get_probes): Change type.
2862         * elfread.c (elfread_data): New typedef.
2863         (probe_key): Change type.
2864         (elf_get_probes): Likewise.  Update.
2865         (probe_key_free): Remove.
2866         (_initialize_elfread): Update.
2867         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2868         Change type.
2869         (dtrace_process_dof_probe, dtrace_process_dof)
2870         (dtrace_static_probe_ops::get_probe): Change type.
2871
2872 2019-05-08  Tom Tromey  <tom@tromey.com>
2873
2874         * xcoffread.c (struct xcoff_symfile_info): Rename from
2875         coff_symfile_info.  Add initializers.
2876         (xcoff_objfile_data_key): Move lower.  Change type.
2877         (XCOFF_DATA): Rewrite.
2878         (xcoff_free_info): Remove.
2879         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2880         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2881         (xcoff_initial_scan): Update.
2882
2883 2019-05-08  Tom Tromey  <tom@tromey.com>
2884
2885         * solib-svr4.c (struct svr4_info): Add initializers and
2886         destructor.
2887         <probes_table>: Now an htab_up.
2888         (solib_svr4_pspace_data): Change type.
2889         (free_probes_table): Simplify.
2890         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2891         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2892         (probes_table_remove_objfile_probes, register_solib_event_probe)
2893         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2894         (_initialize_svr4_solib): Update.
2895
2896 2019-05-08  Tom Tromey  <tom@tromey.com>
2897
2898         * remote.c (remote_pspace_data): Change type.
2899         (remote_pspace_data_cleanup): Remove.
2900         (get_remote_exec_file, set_pspace_remote_exec_file)
2901         (_initialize_remote): Update.
2902
2903 2019-05-08  Tom Tromey  <tom@tromey.com>
2904
2905         * breakpoint.c (breakpoint_objfile_key): Change type.
2906         (get_breakpoint_objfile_data): Update.
2907         (free_breakpoint_objfile_data): Remove.
2908         (_initialize_breakpoint): Update.
2909
2910 2019-05-08  Tom Tromey  <tom@tromey.com>
2911
2912         * linux-tdep.c (struct linux_info): Add initializers.
2913         (linux_inferior_data): Move.  Change type.
2914         (invalidate_linux_cache_inf): Update.
2915         (linux_inferior_data_cleanup): Remove.
2916         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2917
2918 2019-05-08  Tom Tromey  <tom@tromey.com>
2919
2920         * auxv.c (auxv_inferior_data): Move.  Change type.
2921         (auxv_inferior_data_cleanup): Remove.
2922         (invalidate_auxv_cache_inf): Rewrite.
2923         (get_auxv_inferior_data, _initialize_auxv): Update.
2924
2925 2019-05-08  Tom Tromey  <tom@tromey.com>
2926
2927         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2928         (symfile_debug_objfile_data_key): Change type.
2929         (symfile_debug_installed, debug_qf_has_symbols)
2930         (debug_qf_find_last_source_symtab)
2931         (debug_qf_forget_cached_source_info)
2932         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2933         (debug_qf_print_stats, debug_qf_dump)
2934         (debug_qf_expand_symtabs_for_function)
2935         (debug_qf_expand_all_symtabs)
2936         (debug_qf_expand_symtabs_with_fullname)
2937         (debug_qf_map_matching_symbols)
2938         (debug_qf_expand_symtabs_matching)
2939         (debug_qf_find_pc_sect_compunit_symtab)
2940         (debug_qf_map_symbol_filenames)
2941         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2942         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2943         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2944         (debug_sym_read_linetable, debug_sym_relocate): Update.
2945         (symfile_debug_free_objfile): Remove.
2946         (install_symfile_debug_logging, _initialize_symfile_debug):
2947         Update.
2948
2949 2019-05-08  Tom Tromey  <tom@tromey.com>
2950
2951         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2952         allocate_on_obstack.
2953         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2954         (get_dwarf2_per_objfile): Update.
2955         (set_dwarf2_per_objfile): Remove.
2956         (dwarf2_has_info, dwarf2_get_section_info): Update.
2957         (dwarf2_free_objfile): Remove.
2958         (_initialize_dwarf2_read): Update.
2959
2960 2019-05-08  Tom Tromey  <tom@tromey.com>
2961
2962         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2963         initializers.
2964         <unsupported_script_warning_printed,
2965         script_not_found_warning_printed>: Now bool.
2966         (auto_load_pspace_data): Change type.
2967         (~auto_load_pspace_info): Rename from
2968         auto_load_pspace_data_cleanup.
2969         (get_auto_load_pspace_data, init_loaded_scripts_info)
2970         (clear_section_scripts, maybe_print_unsupported_script_warning)
2971         (maybe_print_script_not_found_warning, _initialize_auto_load):
2972         Update.
2973
2974 2019-05-08  Tom Tromey  <tom@tromey.com>
2975
2976         * objfiles.c (objfile_pspace_info): Add destructor and
2977         initializers.
2978         (objfiles_pspace_data): Change type.
2979         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2980         (get_objfile_pspace_data): Update.
2981         (objfiles_bfd_data): Change type.
2982         (get_objfile_bfd_data): Update.
2983         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2984
2985 2019-05-08  Tom Tromey  <tom@tromey.com>
2986
2987         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2988         Change type.
2989         (get_catch_syscall_inferior_data): Update.
2990         (catch_syscall_inferior_data_cleanup): Remove.
2991         (_initialize_break_catch_syscall): Update.
2992
2993 2019-05-08  Tom Tromey  <tom@tromey.com>
2994
2995         * inflow.c (struct terminal_info): Add destructor and
2996         initializers.
2997         (inflow_inferior_data): Change type.
2998         (~terminal_info): Rename from inflow_inferior_data_cleanup.
2999         (get_inflow_inferior_data, inflow_inferior_exit)
3000         (swap_terminal_info, _initialize_inflow): Update.
3001
3002 2019-05-08  Tom Tromey  <tom@tromey.com>
3003
3004         * target-dcache.c (target_dcache_cleanup): Remove.
3005         (target_dcache_aspace_key): Change type.
3006         (target_dcache_init_p, target_dcache_invalidate)
3007         (target_dcache_get, target_dcache_get_or_init)
3008         (_initialize_target_dcache): Update.
3009         * dcache.h (struct dcache_deleter): New.
3010
3011 2019-05-08  Tom Tromey  <tom@tromey.com>
3012
3013         * symtab.c (struct symbol_cache): Add destructor and
3014         initializers.
3015         (symbol_cache_key): Move.  Change type.
3016         (make_symbol_cache, free_symbol_cache): Remove.
3017         (get_symbol_cache): Update.
3018         (symbol_cache_cleanup): Remove.
3019         (ALL_PSPACES, symbol_cache_flush)
3020         (maintenance_print_symbol_cache)
3021         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3022         Update.
3023
3024 2019-05-08  Tom Tromey  <tom@tromey.com>
3025
3026         * symtab.c (struct main_info): Add destructor and initializers.
3027         (main_progspace_key): Move.  Change type.
3028         (get_main_info): Update.
3029         (main_info_cleanup): Remove.
3030         (_initialize_symtab): Update.
3031
3032 2019-05-08  Tom Tromey  <tom@tromey.com>
3033
3034         * registry.h (DECLARE_REGISTRY): Define the _key class.
3035
3036 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3037
3038         * NEWS: Merge two 'New commands' sections.
3039
3040 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3041
3042         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3043         parameter and use Ada language definition instead.
3044         (ada_val_print_ptr): Remove unused language parameter.
3045         (ada_val_print_num): Remove language parameter and use Ada language
3046         definition instead.
3047         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3048         parameter.
3049         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3050         parameter and use Ada language definition instead.
3051         (ada_val_print_1): Update all ada_val_print_xxx calls.
3052         Remove language parameter.
3053         (ada_val_print): Update ada_val_print_1 call.
3054
3055 2019-05-08  Tom Tromey  <tromey@adacore.com>
3056
3057         * remote.c (remote_hw_watchpoint_limit)
3058         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3059         Now static.
3060
3061 2019-05-08  Tom Tromey  <tromey@adacore.com>
3062
3063         * maint.c (_initialize_maint_cmds): Move initialization code to
3064         remote.c.
3065         (watchdog, show_watchdog): Move to remote.c.
3066         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3067         "watchdog" static.
3068         (_initialize_remote): Move initialization code from maint.c.
3069         * defs.h (watchdog): Don't declare.
3070
3071 2019-05-08  Tom Tromey  <tromey@adacore.com>
3072
3073         * tui/tui-interp.c: Include main.h.
3074         * interps.c: Include main.h.
3075         * main.h (interpreter_p): Declare.
3076         * defs.h (interpreter_p): Don't declare.
3077
3078 2019-05-08  Tom Tromey  <tromey@adacore.com>
3079
3080         * dwarf2loc.c: Include dwarf2read.h.
3081         * defs.h (read_unsigned_leb128): Don't declare.
3082         * dwarf2read.h (read_unsigned_leb128): Declare.
3083
3084 2019-05-08  Tom Tromey  <tromey@adacore.com>
3085
3086         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3087         method.
3088
3089 2019-05-08  Tom Tromey  <tromey@adacore.com>
3090
3091         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3092         when no wrap column is set.
3093
3094 2019-05-08  Tom Tromey  <tromey@adacore.com>
3095
3096         * c-lang.c (c_get_string): Handle non-C-style arrays.
3097
3098 2019-05-08  Tom Tromey  <tromey@adacore.com>
3099
3100         * typeprint.c (print_offset_data::update): Print the bit offset,
3101         not the number of bits remaining.
3102
3103 2019-05-08  Tom Tromey  <tromey@adacore.com>
3104
3105         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3106         padding at end of comment.
3107
3108 2019-05-08  Tom Tromey  <tromey@adacore.com>
3109
3110         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3111         Compare main types.
3112
3113 2019-05-06  Tom Tromey  <tom@tromey.com>
3114
3115         * common/scoped_mmap.c: Include common-defs.h.
3116         * common/scoped_mmap.h: Don't include config.h.
3117
3118 2019-05-04  Tom Tromey  <tom@tromey.com>
3119
3120         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3121         (struct aarch64_call_info): Add initializers.
3122         <si>: Now a std::vector.
3123         (pass_on_stack, aarch64_push_dummy_call): Update.
3124
3125 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3126             Tom Tromey  <tom@tromey.com>
3127
3128         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3129         (ppc_threads): Now a std::vector.  Now static.
3130         (hwdebug_find_thread_points_by_tid)
3131         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3132         Update.
3133
3134 2019-05-04  Tom Tromey  <tom@tromey.com>
3135
3136         * arc-tdep.c (arc_tdesc_init): Return bool.
3137
3138 2019-05-04  Tom Tromey  <tom@tromey.com>
3139
3140         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3141         Use gdb_assert_not_reached.
3142
3143 2019-05-04  Tom Tromey  <tom@tromey.com>
3144
3145         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3146         "false".
3147
3148 2019-05-04  Tom Tromey  <tom@tromey.com>
3149
3150         * arc-tdep.c (arc_tdesc_init): Use bool.
3151
3152 2019-05-04  Tom Tromey  <tom@tromey.com>
3153
3154         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3155
3156 2019-05-04  Tom Tromey  <tom@tromey.com>
3157
3158         * cli/cli-cmds.c (valid_command_p): Return bool.
3159
3160 2019-05-04  Tom Tromey  <tom@tromey.com>
3161
3162         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3163         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3164
3165 2019-05-04  Raul Tambre  <raul@tambre.ee>
3166
3167         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3168         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3169         operator for comparison.
3170
3171 2019-05-04  Tom Tromey  <tom@tromey.com>
3172
3173         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3174         (lookup_partial_symbol, print_partial_symbols)
3175         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3176         (psymbol_compare): Update.
3177         (add_psymbol_to_bcache): Clear the entire psymbol.
3178         (maintenance_check_psymtabs): Update.
3179         * psympriv.h (struct partial_symbol): Don't derive from
3180         general_symbol_info.
3181         <obj_section, unrelocated_address, address,
3182         set_unrelocated_address>: Update.
3183         <ginfo>: New member.
3184         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3185         (debug_names::write_psymbols): Update.
3186
3187 2019-05-04  Tom de Vries  <tdevries@suse.de>
3188
3189         * contrib/cc-with-tweaks.sh: Support -n arg.
3190
3191 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3192
3193         * corelow.c (core_target::detach): Ensure frame cache and
3194         register caches are cleared.
3195         inferior.c (exit_inferior_1): Likewise.
3196
3197 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3198             Tom Tromey  <tom@tromey.com>
3199
3200         * dictionary.c (collate_pending_symbols_by_language): Remove
3201         "struct" from foreach.
3202         * symtab.c (lookup_global_symbol_from_objfile)
3203         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3204         foreach.
3205         * ser-tcp.c (net_open): Remove "struct" from foreach.
3206         * objfiles.c (objfile_relocate, objfile_rebase)
3207         (objfile_has_symbols): Remove "struct" from foreach.
3208         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3209         from foreach.
3210         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3211         foreach.
3212         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3213         "struct" from foreach.
3214         * ada-lang.c (create_excep_cond_exprs)
3215         (ada_exception_catchpoint_cond_string): Remove "struct" from
3216         foreach.
3217
3218 2019-05-03  Tom Tromey  <tromey@adacore.com>
3219
3220         * ada-exp.y (convert_char_literal): Check suffix of each
3221         enumerator.
3222
3223 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3224
3225         PR ada/21406:
3226         * ada-exp.y (yywrap): Don't define.
3227         * ada-lex.l (%option): Add noyywrap
3228         (yywrap): Remove.
3229
3230 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3231
3232         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3233         _WIN32_WINNT to the XP level, unless already defined to a higher
3234         level.
3235
3236         * unittests/parse-connection-spec-selftests.c:
3237         * ser-tcp.c:
3238         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3239         override.
3240
3241         * symfile.c (find_separate_debug_file): Remove colon from the
3242         drive spec of DOS/Windows file names of the target, so that the
3243         file name produced from DEBUGDIR and the target's directory will
3244         be valid on DOS/Windows systems.
3245
3246 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3247
3248         * rust-lang.c (val_print_struct): Handle printing structures
3249         containing strings.
3250
3251 2019-05-02  Tom Tromey  <tromey@adacore.com>
3252
3253         * valarith.c (_initialize_valarith): Remove.
3254
3255 2019-05-01  Tom Tromey  <tromey@adacore.com>
3256
3257         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3258         bitfields.
3259
3260 2019-05-01  Tom Tromey  <tromey@adacore.com>
3261
3262         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3263         for big-endian copies.
3264
3265 2019-04-30  Ali Tamur  <tamur@google.com>
3266         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3267         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3268         (read_3_bytes): New function.
3269
3270 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3271
3272         * windows-nat.c (main_thread_id): Delete.
3273         (handle_output_debug_string): Replace main_thread_id by
3274         current_event.dwThreadId.
3275         (fake_create_process): Likewise.
3276         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3277         Do not set main_thread_id.
3278         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3279         current_event.dwThreadId.
3280         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3281
3282 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3283
3284         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3285         Use current_event.dwThreadId instead of main_thread_id.
3286
3287 2019-04-30  Tom Tromey  <tromey@adacore.com>
3288
3289         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3290         (create_excep_cond_exprs): Iterate over program spaces.
3291         (ada_exception_catchpoint_cond_string): Examine all minimal
3292         symbols for exception types.
3293
3294 2019-04-30  Tom Tromey  <tromey@adacore.com>
3295
3296         PR c++/24470:
3297         * dwarf2read.c (process_structure_scope): Handle case where type
3298         has template parameters but no symbol was created.
3299
3300 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3301             Chris January  <chris.january@arm.com>
3302
3303         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3304         qualifier.
3305         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3306
3307 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3308
3309         * f-typeprint.c (f_print_type): Update rules for printing
3310         whitespace.
3311         (f_type_print_varspec_suffix): Likewise.
3312
3313 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3314             Chris January  <chris.january@arm.com>
3315
3316         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3317         function arguments.
3318
3319 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3320
3321         * f-lang.c (build_fortran_types): Change name of void type to
3322         lower case.
3323         * f-typeprint.c (f_type_print_base): Print the name of the void
3324         type, rather than a fixed string.
3325         * f-valprint.c (f_decorations): Use lower case void string.
3326
3327 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3328             Chris January  <chris.january@arm.com>
3329
3330         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3331         types for Fortran.
3332
3333 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3334             Chris January  <chris.january@arm.com>
3335             David Lecomber  <david.lecomber@arm.com>
3336
3337         * f-exp.y (BINOP_INTRINSIC): New token.
3338         (exp): New parser rule handling BINOP_INTRINSIC.
3339         (f77_keywords): Add new builtin procedures.
3340         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3341         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3342         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3343         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3344         (print_unop_subexp_f): New function.
3345         (print_binop_subexp_f): New function.
3346         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3347         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3348         (dump_subexp_body_f): Likewise.
3349         (operator_check_f): Likewise.
3350         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3351         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3352
3353 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3354
3355         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3356         UNOP_KIND.
3357         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3358         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3359         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3360         (operator_length_f): New fuction.
3361         (print_subexp_f): New function.
3362         (op_name_f): New function.
3363         (dump_subexp_body_f): New function.
3364         (operator_check_f): New function.
3365         (exp_descriptor_f): Replace standard expression handling functions
3366         with new functions.
3367         * gdb/fortran-operator.def: New file.
3368         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3369         * gdb/std-operator.def: Remove UNOP_KIND.
3370
3371 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3372
3373         * std-operator.def: Remove unbalanced, stray double quote
3374         character.
3375
3376 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3377             Chris January  <chris.january@arm.com>
3378             Daniel Everett  <daniel.everett@arm.com>
3379             Nick Forrington  <nick.forrington@arm.com>
3380             Richard Bunt  <richard.bunt@arm.com>
3381
3382         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3383         of depth when printing anonymous structs or unions.
3384         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3385         Don't print either the top-level value, or the children if the
3386         max-depth is exceeded.
3387         (ppscm_print_children): When printing the key of a map, allow one
3388         extra level of depth.
3389         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3390         print either the top-level value, or the children if the max-depth
3391         is exceeded.
3392         (print_children): When printing the key of a map, allow one extra
3393         level of depth.
3394         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3395         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3396         (user_print_options): Initialise max_depth field.
3397         (val_print_scalar_or_string_type_p): New function.
3398         (val_print): Check to see if the max depth has been reached.
3399         (val_print_check_max_depth): Define new function.
3400         (show_print_max_depth): New function.
3401         (_initialize_valprint): Add 'print max-depth' option.
3402         * valprint.h (struct value_print_options) <max_depth>: New field.
3403         (val_print_check_max_depth): Declare new function.
3404         * NEWS: Document new feature.
3405
3406 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3407
3408         * ada-lang.c (ada_language_defn): Initialise new field.
3409         * c-lang.c (c_is_string_type_p): New function.
3410         (c_language_defn): Initialise new field.
3411         (cplus_language_defn): Initialise new field.
3412         (asm_language_defn): Initialise new field.
3413         (minimal_language_defn): Initialise new field.
3414         * c-lang.h (c_is_string_type_p): Declare new function.
3415         * d-lang.c (d_language_defn): Initialise new field.
3416         * f-lang.c (f_is_string_type_p): New function.
3417         (f_language_defn): Initialise new field.
3418         * go-lang.c (go_is_string_type_p): New function.
3419         (go_language_defn): Initialise new field.
3420         * language.c (default_is_string_type_p): New function.
3421         (unknown_language_defn): Initialise new field.
3422         (auto_language_defn): Initialise new field.
3423         * language.h (struct language_defn) <la_is_string_type_p>: New
3424         member variable.
3425         (default_is_string_type_p): Declare new function.
3426         * m2-lang.c (m2_language_defn): Initialise new field.
3427         * objc-lang.c (objc_language_defn): Initialise new field.
3428         * opencl-lang.c (opencl_language_defn): Initialise new field.
3429         * p-lang.c (pascal_is_string_type_p): New function.
3430         (pascal_language_defn): Initialise new field.
3431         * rust-lang.c (rust_is_string_type_p): New function.
3432         (rust_language_defn): Initialise new field.
3433
3434 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3435
3436         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3437         New field.
3438         * ada-lang.c (ada_language_defn): Initialise new field.
3439         * c-lang.c (c_language_defn): Likewise.
3440         (cplus_language_defn): Likewise.
3441         (asm_language_defn): Likewise.
3442         (minimal_language_defn): Likewise.
3443         * d-lang.c (d_language_defn): Likewise.
3444         * f-lang.c (f_language_defn): Likewise.
3445         * go-lang.c (go_language_defn): Likewise.
3446         * language.c (unknown_language_defn): Likewise.
3447         (auto_language_defn): Likewise.
3448         * m2-lang.c (m2_language_defn): Likewise.
3449         * objc-lang.c (objc_language_defn): Likewise.
3450         * opencl-lang.c (opencl_language_defn): Likewise.
3451         * p-lang.c (pascal_language_defn): Likewise.
3452         * rust-lang.c (rust_language_defn): Likewise.
3453
3454 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3455
3456         * ada-lang.c (ada_is_character_type): Change return type to bool.
3457         (ada_is_string_type): Likewise.
3458         * ada-lang.h (ada_is_character_type): Update declaration
3459         (ada_is_string_type): Likewise.
3460
3461 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3462
3463         Support style in 'frame|thread apply'
3464
3465         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3466         * record.c (record_start, record_stop): Update callers of
3467         execute_command_to_string with false.
3468         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3469         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3470         methods.
3471         (class string_file): New constructor with term_out parameter.
3472         Override methods term_out and can_emit_style_escape.  New member
3473         term_out.
3474         (class stdio_file): Override can_emit_style_escape.
3475         (class tee_file): Override term_out and can_emit_style_escape.
3476         * utils.h (can_emit_style_escape): Remove.
3477         * utils.c (can_emit_style_escape): Likewise.
3478         Update all callers of can_emit_style_escape (SOMESTREAM) to
3479         SOMESTREAM->can_emit_style_escape.
3480         * source-cache.c (source_cache::get_source_lines): Likewise.
3481         * stack.c (frame_apply_command_count): Call execute_command_to_string
3482         passing the term_out characteristic of the current gdb_stdout.
3483         * thread.c (thr_try_catch_cmd): Likewise.
3484         * top.c (execute_command_to_string): pass term_out parameter
3485         to construct the string_file for the command output.
3486         * ui-file.c (term_cli_styling): New function (most code moved
3487         from utils.c can_emit_style_escape).
3488         (string_file::string_file, string_file::can_emit_style_escape,
3489         stdio_file::can_emit_style_escape, tee_file::term_out,
3490         tee_file::can_emit_style_escape): New functions.
3491
3492 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3493
3494         * NEWS: Mention the new set|show may-call-functions.
3495         * infcall.c (may_call_functions_p): New variable.
3496         (show_may_call_functions_p): New function.
3497         (call_function_by_hand_dummy): Throws an error if not
3498         may-call-functions.
3499         (_initialize_infcall): Call add_setshow_boolean_cmd for
3500         may-call-functions.
3501
3502 2019-04-25  Keith Seitz  <keiths@redhat.com>
3503
3504         PR c++/24367
3505         * cp-support.c (inspect_type): Don't attempt substitutions
3506         of symbol with the same name.
3507
3508 2019-04-25  Tom Tromey  <tromey@adacore.com>
3509
3510         PR gdb/24475:
3511         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3512         static.
3513
3514 2019-04-25  Tom Tromey  <tromey@adacore.com>
3515
3516         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3517         rvalue reference.
3518         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3519         (gdb_xml_parser::parse): Use std::move.
3520         * python/python-internal.h (gdbpy_convert_exception): Take a const
3521         reference.
3522         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3523         std::move.
3524         * python/py-utils.c (gdbpy_convert_exception): Take a const
3525         reference.
3526         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3527         Use std::move.
3528         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3529         Use std::move.
3530         * mi/mi-main.c (mi_print_exception): Take a const reference.
3531         * main.c (handle_command_errors): Take a const reference.
3532         * linespec.c (parse_linespec): Use std::move.
3533         * infcall.c (run_inferior_call): Use std::move.
3534         (call_function_by_hand_dummy): Use std::move.
3535         * exec.c (try_open_exec_file): Use std::move.
3536         * exceptions.h (exception_print, exception_fprintf)
3537         (exception_print_same): Update.
3538         * exceptions.c (print_exception, exception_print)
3539         (exception_fprintf, exception_print_same): Change parameters to
3540         const reference.
3541         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3542         * common/new-op.c: Use std::move.
3543         * common/common-exceptions.h (struct gdb_exception): Add move
3544         constructor.
3545         (struct gdb_exception_error, struct gdb_exception_quit, struct
3546         gdb_quit_bad_alloc): Change constructor to move constructor.
3547         (throw_exception): Change parameter to rvalue reference.
3548         * common/common-exceptions.c (throw_exception): Take rvalue
3549         reference.
3550         * cli/cli-interp.c (safe_execute_command): Use std::move.
3551         * breakpoint.c (insert_bp_location, location_to_sals): Use
3552         std::move.
3553
3554 2019-04-25  Tom Tromey  <tromey@adacore.com>
3555
3556         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3557         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3558         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3559         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3560         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3561         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3562         guile/scm-value.c: Use unpack.
3563         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3564         gdbscm_gdb_exception.
3565         (gdbscm_throw_gdb_exception): Likewise.
3566         (struct gdbscm_gdb_exception): New.
3567         (unpack): New function.
3568         (gdbscm_wrap): Use unpack.
3569
3570 2019-04-25  Tom Tromey  <tromey@adacore.com>
3571
3572         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3573         (gdb_rl_callback_handler): Use std::move.
3574         * common/common-exceptions.h (struct gdb_exception): Add move
3575         assignment operator.
3576         (throw_exception_sjlj): Change "exception" to const reference.
3577         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3578         (throw_exception_sjlj): Change "exception" to const reference.
3579
3580 2019-04-25  Tom Tromey  <tromey@adacore.com>
3581
3582         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3583         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3584         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3585         Update.
3586         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3587         Update.
3588         * mi/mi-interp.c (mi_interp::exec): Update.
3589         * linespec.c (parse_linespec): Update.
3590         * infcall.c (run_inferior_call): Update.
3591         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3592         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3593         (gdbscm_lookup_global_symbol): Update.
3594         * guile/scm-param.c (gdbscm_parameter_value): Update.
3595         * guile/scm-frame.c (gdbscm_frame_read_register)
3596         (gdbscm_frame_read_var): Update.
3597         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3598         * exec.c (try_open_exec_file): Update.
3599         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3600         (gdb_rl_callback_handler): Update.
3601         * common/common-exceptions.h (exception_none): Don't declare.
3602         * common/common-exceptions.c (exception_none): Don't define.
3603         (struct catcher) <exception>: Update.
3604         * cli/cli-interp.c (safe_execute_command): Update.
3605         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3606
3607 2019-04-25  Ali Tamur  <tamur@google.com>
3608
3609         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3610         (read_attribute_value): Likewise.
3611         (dwarf2_read_addr_index): Update comment.
3612         (read_str_index): Add DW_FORM_strx.
3613         (dwarf2_string_attr): Likewise.
3614         (dwarf2_const_value_attr): Likewise.
3615         (dump_die_shallow): Likewise.
3616         (dwarf2_fetch_constant_bytes): Likewise.
3617         (skip_form_bytes): Likewise.
3618         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3619
3620 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3621
3622         PR corefiles/11608
3623         PR corefiles/18187
3624         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3625         OFFSET.  Verify if current mapping contains an ELF header.
3626         (linux_find_memory_regions_full): Adjust call to
3627         dump_mapping_p.
3628
3629 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3630             Kang Li <kanglictf@gmail.com>
3631
3632         PR gdb/21600
3633
3634         * dwarf2-frame.c (read_initial_length): Be consistent about using
3635         unsigned representation of length.
3636         (decode_frame_entry_1): Likewise.  Check for wraparound of
3637         end pointer as well as buffer overflow.
3638
3639 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3640
3641         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3642         "vq".
3643
3644 2019-04-24  Tom Tromey  <tromey@adacore.com>
3645
3646         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3647
3648 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3649
3650         * s12z-tdep.c (s12z_unwind_pc): Delete.
3651         (s12z_unwind_sp): Delete.
3652         (s12z_gdbarch_init): Don't register deleted functions with
3653         gdbarch.
3654
3655 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3656
3657         * rl78-tdep.c (rl78_unwind_sp): Delete.
3658         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3659
3660 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3661
3662         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3663         (xstormy16_unwind_pc): Delete.
3664         (xstormy16_dummy_id): Delete.
3665         (xstormy16_gdbarch_init): Don't register deleted functions with
3666         gdbarch.
3667
3668 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3669
3670         * vax-tdep.c (vax_unwind_pc): Delete.
3671         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3672
3673 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3674
3675         * v850-tdep.c (v850_unwind_sp): Delete.
3676         (v850_unwind_pc): Delete.
3677         (v850_dummy_id): Delete.
3678         (v850_gdbarch_init): Don't register deleted functions with
3679         gdbarch.
3680
3681 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3682
3683         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3684         (tilegx_unwind_pc): Delete.
3685         (tilegx_unwind_dummy_id): Delete.
3686         (tilegx_gdbarch_init): Don't register deleted functions with
3687         gdbarch.
3688
3689 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3690
3691         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3692         (tic6x_dummy_id): Delete.
3693         (tic6x_gdbarch_init): Don't register deleted functions with
3694         gdbarch.
3695
3696 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3697
3698         * sparc-tdep.c (sparc_unwind_pc): Delete.
3699         (sparc32_gdbarch_init): Don't register deleted function with
3700         gdbarch.
3701
3702 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3703
3704         * sh-tdep.c (sh_unwind_sp): Delete.
3705         (sh_unwind_pc): Delete.
3706         (sh_dummy_id): Delete.
3707         (sh_gdbarch_init): Don't register deleted functions with
3708         gdbarch.
3709
3710 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3711
3712         * score-tdep.c (score_unwind_sp): Delete.
3713         (score_unwind_pc): Delete.
3714         (score_dummy_id): Delete.
3715         (score_gdbarch_init): Don't register deleted functions with
3716         gdbarch.
3717
3718 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3719
3720         * rx-tdep.c (rx_unwind_pc): Delete.
3721         (rx_unwind_sp): Delete.
3722         (rx_dummy_id): Delete.
3723         (rx_gdbarch_init): Don't register deleted functions with
3724         gdbarch.  Update comment.
3725
3726 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3727
3728         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3729         (rs6000_dummy_id): Delete.
3730         (rs6000_gdbarch_init): Don't register deleted functions with
3731         gdbarch.
3732
3733 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3734
3735         * or1k-tdep.c (or1k_dummy_id): Delete.
3736         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3737
3738 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3739
3740         * nios2-tdep.c (nios2_dummy_id): Delete.
3741         (nios2_unwind_sp): Delete.
3742         (nios2_gdbarch_init): Don't register deleted functions with
3743         gdbarch.
3744
3745 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3746
3747         * nds32-tdep.c (nds32_dummy_id): Delete.
3748         (nds32_unwind_pc): Delete.
3749         (nds32_unwind_sp): Delete.
3750         (nds32_gdbarch_init): Don't register deleted functions with
3751         gdbarch.
3752
3753 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3754
3755         * msp430-tdep.c (msp430_unwind_pc): Delete.
3756         (msp430_unwind_sp): Delete.
3757         (msp430_dummy_id): Delete.
3758         (msp430_gdbarch_init): Don't register deleted functions with
3759         gdbarch.
3760
3761 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3762
3763         * moxie-tdep.c (moxie_unwind_sp): Delete.
3764         (moxie_unwind_pc): Delete.
3765         (moxie_dummy_id): Delete.
3766         (moxie_gdbarch_init): Don't register deleted functions with
3767         gdbarch.
3768
3769 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3770
3771         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3772         (mn10300_unwind_pc): Delete.
3773         (mn10300_unwind_sp): Delete.
3774         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3775         mn10300_unwind_sp.
3776         (mn10300_frame_unwind_init): Don't register deleted functions with
3777         gdbarch.
3778
3779 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3780
3781         * mep-tdep.c (mep_unwind_pc): Delete.
3782         (mep_unwind_sp): Delete.
3783         (mep_dummy_id): Delete.
3784         (mep_gdbarch_init): Don't register deleted functions with
3785         gdbarch.
3786
3787 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3788
3789         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3790         (m68hc11_unwind_sp): Delete.
3791         (m68hc11_gdbarch_init): Don't register deleted functions with
3792         gdbarch.
3793
3794 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3795
3796         * m32r-tdep.c (m32r_unwind_sp): Delete.
3797         (m32r_unwind_pc): Delete.
3798         (m32r_dummy_id): Delete.
3799         (m32r_gdbarch_init): Don't register deleted functions with
3800         gdbarch.
3801
3802 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3803
3804         * m32c-tdep.c (m32c_unwind_pc): Delete.
3805         (m32c_unwind_sp): Delete.
3806         (m32c_dummy_id): Delete.
3807         (m32c_gdbarch_init): Don't register deleted functions with
3808         gdbarch.
3809
3810 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3811
3812         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3813         (lm32_unwind_pc): Delete.
3814         (lm32_dummy_id): Delete.
3815         (lm32_gdbarch_init): Don't register deleted functions with
3816         gdbarch.
3817
3818 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3819
3820         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3821         (iq2000_unwind_pc): Delete.
3822         (iq2000_dummy_id): Delete.
3823         (iq2000_gdbarch_init): Don't register deleted functions with
3824         gdbarch.
3825
3826 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3827
3828         * nds32-tdep.c (nds32_type_align): Delete.
3829         (nds32_push_dummy_call): Use type_align instead.
3830
3831 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3832
3833         * arm-tdep.c (arm_type_align): Only handle vector override case.
3834         (arm_push_dummy_call): Use type_align.
3835         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3836
3837 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3838
3839         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3840         case.
3841         (pass_on_stack): Use type_align.
3842         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3843         function.
3844
3845 2019-04-23  Tom Tromey  <tromey@adacore.com>
3846
3847         * dwarf2read.c (line_header::file_name_at): Remove unused
3848         overload.
3849
3850 2019-04-23  Tom de Vries  <tdevries@suse.de>
3851
3852         PR gdb/24438
3853         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3854         invocation.
3855
3856
3857 2019-03-27  Ali Tamur  <tamur@google.com>
3858
3859         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3860         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3861         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3862         (dwarf_expr_context::get_addr_index): Likewise
3863         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3864         (symbol_needs_eval_context::get_addr_index): Likewise
3865         (disassemble_dwarf_expression): Add DW_OP_addrx
3866         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3867         (read_cutu_die_from_dwo): Update comment
3868         (skip_one_die): Add DW_FORM_addrx
3869         (read_attribute_value): Likewise
3870         (var_decode_location): Add DW_OP_addrx
3871         (dwarf2_const_value_attr): Add DW_FORM_addrx
3872         (dump_die_shallow): Likewise
3873         (dwarf2_fetch_constant_bytes): Likewise
3874         (decode_locdesc): Add DW_OP_addrx
3875         (skip_form_bytes): Add DW_FORM_addrx
3876
3877 2019-04-22  Ali Tamur  <tamur@google.com>
3878
3879         * MAINTAINERS (Write After Approval): Add self.
3880
3881 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3882
3883         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3884         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3885         (open_symbol_file_object): Likewise.
3886         (svr4_default_sos): Add info parameter.
3887         (svr4_read_so_list): Likewise.
3888         (svr4_current_sos_direct): Adjust functions calls to pass down
3889         info.
3890         (svr4_current_sos_1): Add info parameter.
3891         (svr4_current_sos): Call get_svr4_info, pass info down to
3892         svr4_current_sos_1.
3893         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3894         get_svr4_info.
3895         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3896         get_svr4_info.
3897         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3898         to get_svr4_info.
3899         (probes_table_remove_objfile_probes): Likewise.
3900         (register_solib_event_probe): Add info parameter.
3901         (solist_update_incremental): Pass info parameter down to
3902         svr4_read_so_list.
3903         (disable_probes_interface): Add info parameter.
3904         (svr4_handle_solib_event): Pass current_program_space to
3905         get_svr4_info.  Adjust disable_probes_interface cleanup.
3906         (svr4_create_probe_breakpoints): Add info parameter, pass it
3907         down to register_solib_event_probe.
3908         (svr4_create_solib_event_breakpoints): Add info parameter,
3909         pass it down to svr4_create_probe_breakpoints.
3910         (enable_break): Pass info down to
3911         svr4_create_solib_event_breakpoints.
3912         (svr4_solib_create_inferior_hook): Pass current_program_space to
3913         get_svr4_info.
3914         (svr4_clear_solib): Likewise.
3915
3916 2019-04-22  Pedro Alves  <palves@redhat.com>
3917
3918         * solib-svr4.c (svr4_free_objfile_observer): New.
3919         (probe_and_action::objfile): New field.
3920         (probes_table_htab_remove_objfile_probes)
3921         (probes_table_remove_objfile_probes): New functions.
3922         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3923         in the new probe_and_action.  Don't store the probe in 'lookup'.
3924         (svr4_create_probe_breakpoints): Pass objfile to
3925         register_solib_event_probe.
3926         (_initialize_svr4_solib): Register a free_objfile observer.
3927
3928 2019-04-19  Tom Tromey  <tom@tromey.com>
3929
3930         * common/queue.h: Remove.
3931
3932 2019-04-19  Tom Tromey  <tom@tromey.com>
3933
3934         * event-loop.c: Don't include "common/queue.h".
3935
3936 2019-04-19  Tom Tromey  <tom@tromey.com>
3937
3938         * remote.c (remote_target): Use delete.
3939         * remote-notif.h: Include <list>, not "common/queue.h".
3940         (notif_client_p): Remove typedef.
3941         (remote_notif_state): Add constructor, destructor, initializer.
3942         <notif_queue>: Now a std::list.
3943         (remote_notif_state_xfree): Don't declare.
3944         * remote-notif.c (remote_notif_process, handle_notification)
3945         (remote_notif_state_allocate): Update.
3946         (~remote_notif_state): Rename from remote_notif_state_xfree.
3947
3948 2019-04-19  Tom Tromey  <tom@tromey.com>
3949
3950         * symfile.c (reread_symbols): Update.
3951         * objfiles.c (objfile_register_static_link)
3952         (objfile_lookup_static_link): Update
3953         (~objfile) Don't delete static_links.
3954         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3955
3956 2019-04-19  Tom Tromey  <tom@tromey.com>
3957
3958         * type-stack.h (struct type_stack) <insert>: Constify string.
3959         * type-stack.c (type_stack::insert): Constify string.
3960         * gdbtypes.h (lookup_template_type): Update.
3961         (address_space_name_to_int): Update.
3962         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3963         const.
3964         (lookup_template_type): Make name const.
3965         * c-exp.y: Update rules.
3966         (lex_one_token, classify_name, classify_inner_name)
3967         (c_print_token): Update.
3968         * p-exp.y: Update rules.
3969         (yylex): Update.
3970         * f-exp.y: Update rules.
3971         (yylex): Update.
3972         * d-exp.y: Update rules.
3973         (lex_one_token, classify_name, classify_inner_name): Update.
3974         * parse.c (write_dollar_variable, copy_name): Return std::string.
3975         * parser-defs.h (copy_name): Change return type.
3976         * m2-exp.y: Update rules.
3977         (yylex): Update.
3978         * go-exp.y (lex_one_token): Update.
3979         Update rules.
3980         (classify_unsafe_function, classify_packaged_name)
3981         (classify_name, yylex): Update.
3982
3983 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3984
3985         * configure.ac: add --enable-source-highlight switch.
3986         * configure: Regenerate.
3987         * top.c (print_gdb_version): plumb --enable-source-highlight
3988         status to "show configuration".
3989
3990 2019-04-19  Tom Tromey  <tromey@adacore.com>
3991
3992         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3993         Check ADA_TYPE_P.
3994         (empty_record, ada_template_to_fixed_record_type_1)
3995         (template_to_static_fixed_type)
3996         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3997         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3998         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3999         macros.
4000
4001 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4002
4003         PR symtab/24423:
4004         * source.c (print_source_lines_base): Advance "iter" when a
4005         control character is seen.
4006
4007 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4008
4009         * inferior.h (struct infcall_suspend_state_deleter):
4010         Catch exception in destructor to avoid crash.
4011
4012 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4013
4014         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4015         close to the add_com "shell".
4016
4017 2019-04-18  Tom Tromey  <tromey@adacore.com>
4018
4019         * process-stratum-target.h (class process_stratum_target)
4020         <stratum>: Add "final".
4021
4022 2019-04-17  Tom Tromey  <tromey@adacore.com>
4023
4024         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4025         against nullptr before use.
4026
4027 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4028
4029         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4030
4031 2019-04-17  Jim Wilson  <jimw@sifive.com>
4032             Andrew Burgess  <andrew.burgess@embecosm.com>
4033
4034         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4035         code read might fail, assume 4-byte breakpoint in that case.
4036
4037 2019-04-15  Leszek Swirski  <leszeks@google.com>
4038
4039         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4040         rather than a hand-rolled POD check when checking for forced MEMORY
4041         classification.
4042
4043 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4044
4045         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4046         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4047         function.
4048         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4049         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4050         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4051         declaration.
4052
4053 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4054
4055         * aarch64-linux-nat.c
4056         (aarch64_linux_nat_target::thread_architecture): Add override.
4057         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4058         each VQ.
4059
4060 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4061
4062         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4063
4064 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4065
4066         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4067         target types of size 96-bits, add some additional comments, and
4068         check that the builtin type we found was the correct size.
4069
4070 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4071
4072         * utils.c (prompt_for_continue): Don't restore the styling at the
4073         end, as applied_style has the wrong value.  This fixes styling in
4074         long lists of file names that are interrupted by the "Continue?"
4075         prompt.
4076
4077 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4078
4079         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4080         * c-lang.c (c_language_defn): Likewise.
4081         (cplus_language_defn): Likewise.
4082         (asm_language_defn): Likewise.
4083         (minimal_language_defn): Likewise.
4084         * d-lang.c (d_language_defn): Likewise.
4085         * f-lang.c (f_language_defn): Likewise.
4086         * go-lang.c (go_language_defn): Likewise.
4087         * language.c (unknown_language_defn): Likewise.
4088         (auto_language_defn): Likewise.
4089         * language.h (struct language_defn): Remove la_magic field.
4090         (LANG_MAGIC): Delete.
4091         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4092         * objc-lang.c (objc_language_defn): Likewise.
4093         * opencl-lang.c (opencl_language_defn): Likewise.
4094         * p-lang.c (pascal_language_defn): Likewise.
4095         * rust-lang.c (rust_language_defn): Likewise.
4096
4097 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4098
4099         * riscv-tdep.c (riscv_type_align): New function.
4100         (riscv_type_alignment): Delete.
4101         (riscv_arg_location): Use 'type_align'.
4102         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4103
4104 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4105
4106         * gdbtypes.c (type_align): A struct with no non-static fields also
4107         has alignment of 1.
4108
4109 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4110
4111         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4112         component to 0.
4113         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4114         member.
4115         (riscv_struct_info::analyse): New implementation using new
4116         analyse_inner member function.
4117         (riscv_struct_info::field_offset): New member function.
4118         (riscv_struct_info::m_offsets): New member variable.
4119         (riscv_struct_info::analyse_inner): New private member function,
4120         takes the old implementation of riscv_struct_info::analyse but
4121         extended to track field offsets.
4122         (riscv_call_arg_struct): Update the struct folding special cases
4123         to handle cases where empty C++ structs, which are non-zero
4124         length, are found.
4125         (riscv_arg_location): Initialise the length of each location, a
4126         non-zero length now indicates the location is in use.
4127         (riscv_push_dummy_call): Allow for the first location having a
4128         non-zero offset when setting up arguments.
4129         (riscv_return_value): Likewise, but for return values.
4130
4131 2019-04-11  Tom Tromey  <tromey@adacore.com>
4132
4133         * utils.c (internal_vproblem): Make "msg" const.
4134
4135 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4136
4137         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4138         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4139         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4140         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4141
4142 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4143
4144         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4145         function.
4146         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4147         of amd64_collect_native_gregset.
4148         (amd64_linux_nat_target::store_registers): Likewise.
4149
4150 2019-04-10  Tom Tromey  <tom@tromey.com>
4151
4152         * symtab.c (lookup_global_symbol_from_objfile)
4153         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4154         * objfiles.h (class separate_debug_iterator): New.
4155         (class separate_debug_range): New.
4156         (struct objfile) <separate_debug_objfiles>: New method.
4157         (objfile_separate_debug_iterate): Don't declare.
4158         * objfiles.c (separate_debug_iterator::operator++): Rename from
4159         objfile_separate_debug_iterate.
4160         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4161         iterator.
4162         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4163         iterator.
4164
4165 2019-04-10  Tom Tromey  <tom@tromey.com>
4166
4167         * symfile.c (reread_symbols): Remove old comment.
4168         * objfiles.c (free_all_objfiles): Fix a typo.
4169
4170 2019-04-10  Tom Tromey  <tom@tromey.com>
4171
4172         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4173         * minsyms.c (lookup_minimal_symbol): Use foreach.
4174         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4175         (lookup_minimal_symbol_solib_trampoline): Likewise.
4176         * symfile.c (reread_symbols): Use foreach.
4177
4178 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4179             Tom Tromey  <tromey@adacore.com>
4180
4181         PR rust/24414:
4182         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4183         (rust_lex_int_test): Change "value" to be LONGEST.
4184         (rust_lex_tests): Add test for long integer literal.
4185
4186 2019-04-09  Tom Tromey  <tromey@adacore.com>
4187
4188         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4189         to bool.
4190         (extended_remote_target::attach): Update.
4191         (remote_target::remote_notice_new_inferior): Update.
4192         (remote_target::add_current_inferior_and_thread): Update.
4193         * inferior.c (exit_inferior_1): Use "false".
4194         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4195
4196 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4197
4198         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4199         the "start" command.
4200
4201 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4202
4203         * python/py-inferior.c (infpy_thread_from_thread_handle):
4204         Adjust comments to reflect renaming of thread_from_thread_handle
4205         to thread_from_handle.  Adjust keywords.  Fix type error message.
4206         (inferior_object_methods): Add thread_from_handle.  Retain
4207         thread_from_thread_handle, but mark it as deprecated.
4208
4209 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4210
4211         * gdbthread.h (find_thread_by_handle): Revise declaration.
4212         * thread.c (find_thread_by_handle): Likewise.  Adjust
4213         implementation too.
4214         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4215         support for buffer objects as handles.
4216
4217 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4218
4219         * python/py-infthread.c (thpy_thread_handle): New function.
4220         (thread_object_methods): Register thpy_thread_handle.
4221
4222 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4223
4224         * gdbthread.h (thread_to_thread_handle): Declare.
4225         * thread.c (gdbtypes.h): Include.
4226         (thread_to_thread_handle): New function.
4227
4228         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4229         (target_thread_info_to_thread_handle): Declare.
4230         * target.c (target_thread_info_to_thread_handle): New function.
4231         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4232         * target-delegates.c: Regenerate.
4233
4234         * linux-thread-db.c (class thread_db_target): Add method
4235         thread_info_to_thread_handle.
4236         (thread_db_target::thread_info_to_thread_handle): Define.
4237         * remote.c (class remote_target): Add new method
4238         thread_info_to_thread_handle.
4239         (remote_target::thread_info_to_thread_handle): Define.
4240
4241 2019-04-08  Pedro Alves  <palves@redhat.com>
4242
4243         * common/common-exceptions.c (throw_exception): Don't create
4244         named object to throw; throw directly.
4245         (throw_it): Likewise.  Don't initialize gdb_exception::message
4246         here, with new; pass FMT and AP to the ctor instead.
4247         * common/common-exceptions.h: Include <string>.
4248         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4249         const char *, va_list)): New ctor.  Use std::make_shared.
4250         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4251         errors)): Delete.
4252         (gdb_exception_error::gdb_exception_error(enum errors, const char
4253         *, va_list)): New.
4254         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4255         Add assertion.
4256         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4257         errors)): Delete.
4258         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4259         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4260         Add assertion.
4261
4262 2019-04-08  Tom Tromey  <tom@tromey.com>
4263
4264         * valops.c (value_rtti_indirect_type): Replace throw_exception
4265         with throw.
4266         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4267         with throw.
4268         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4269         throw.
4270         * target.c (target_translate_tls_address): Replace throw_exception
4271         with throw.
4272         * stack.c (frame_apply_command_count): Replace throw_exception
4273         with throw.
4274         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4275         throw.
4276         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4277         with throw.
4278         * rs6000-tdep.c (rs6000_frame_cache)
4279         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4280         * remote.c: Replace throw_exception with throw.
4281         * record-full.c (record_full_message, record_full_wait_1)
4282         (record_full_restore): Replace throw_exception with throw.
4283         * record-btrace.c:
4284         (get_thread_current_frame_id, record_btrace_start_replaying)
4285         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4286         (cmd_record_btrace_start): Replace throw_exception with throw.
4287         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4288         throw.
4289         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4290         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4291         * linespec.c:
4292         (find_linespec_symbols): Replace throw_exception with throw.
4293         * infrun.c (displaced_step_prepare, resume): Replace
4294         throw_exception with throw.
4295         * infcmd.c (post_create_inferior): Replace throw_exception with
4296         throw.
4297         * inf-loop.c (inferior_event_handler): Replace throw_exception
4298         with throw.
4299         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4300         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4301         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4302         (get_prev_frame_always, get_frame_pc_if_available)
4303         (get_frame_address_in_block_if_available, get_frame_language):
4304         Replace throw_exception with throw.
4305         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4306         throw_exception with throw.
4307         * eval.c (fetch_subexp_value, evaluate_var_value)
4308         (evaluate_funcall, evaluate_subexp_standard): Replace
4309         throw_exception with throw.
4310         * dwarf2loc.c (call_site_find_chain)
4311         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4312         Replace throw_exception with throw.
4313         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4314         with throw.
4315         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4316         throw.
4317         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4318         * completer.c (complete_line_internal): Replace throw_exception
4319         with throw.
4320         * compile/compile-object-run.c (compile_object_run): Replace
4321         throw_exception with throw.
4322         * cli/cli-script.c (process_next_line): Replace throw_exception
4323         with throw.
4324         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4325         (btrace_enable, btrace_maint_update_pt_packets): Replace
4326         throw_exception with throw.
4327         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4328         throw_exception with throw.
4329         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4330         throw_exception with throw.
4331         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4332         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4333         * aarch64-tdep.c (aarch64_make_prologue_cache)
4334         (aarch64_make_stub_cache): Replace throw_exception with throw.
4335
4336 2019-04-08  Tom Tromey  <tom@tromey.com>
4337
4338         * common/common-exceptions.c (throw_exception): Rename from
4339         throw_exception_cxx.  Remove old copy.  Make argument const.
4340         (throw_it): Create and throw exception objects directly.
4341         * common/common-exceptions.h (throw_exception): Make argument
4342         const.
4343         (struct gdb_exception_error): Add constructor.
4344         (struct gdb_exception_quit): Add constructor.
4345
4346 2019-04-08  Tom Tromey  <tom@tromey.com>
4347
4348         * common/common-exceptions.h (exception_rethrow): Don't declare.
4349         (TRY_SJLJ): Update comment.
4350         (TRY, CATCH, END_CATCH): Remove.
4351         * common/common-exceptions.c (exception_rethrow): Remove.
4352
4353 2019-04-08  Tom Tromey  <tom@tromey.com>
4354
4355         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4356         Remove.
4357         (gdb_exception_error): Rename from
4358         gdb_exception_RETURN_MASK_ERROR.
4359         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4360         (gdb_quit_bad_alloc): Update.
4361         * aarch64-tdep.c: Update.
4362         * ada-lang.c: Update.
4363         * ada-typeprint.c: Update.
4364         * ada-valprint.c: Update.
4365         * amd64-tdep.c: Update.
4366         * arch-utils.c: Update.
4367         * break-catch-throw.c: Update.
4368         * breakpoint.c: Update.
4369         * btrace.c: Update.
4370         * c-varobj.c: Update.
4371         * cli/cli-cmds.c: Update.
4372         * cli/cli-interp.c: Update.
4373         * cli/cli-script.c: Update.
4374         * common/common-exceptions.c: Update.
4375         * common/new-op.c: Update.
4376         * common/selftest.c: Update.
4377         * compile/compile-c-symbols.c: Update.
4378         * compile/compile-cplus-symbols.c: Update.
4379         * compile/compile-object-load.c: Update.
4380         * compile/compile-object-run.c: Update.
4381         * completer.c: Update.
4382         * corelow.c: Update.
4383         * cp-abi.c: Update.
4384         * cp-support.c: Update.
4385         * cp-valprint.c: Update.
4386         * darwin-nat.c: Update.
4387         * disasm-selftests.c: Update.
4388         * dtrace-probe.c: Update.
4389         * dwarf-index-cache.c: Update.
4390         * dwarf-index-write.c: Update.
4391         * dwarf2-frame-tailcall.c: Update.
4392         * dwarf2-frame.c: Update.
4393         * dwarf2loc.c: Update.
4394         * dwarf2read.c: Update.
4395         * eval.c: Update.
4396         * event-loop.c: Update.
4397         * event-top.c: Update.
4398         * exec.c: Update.
4399         * f-valprint.c: Update.
4400         * fbsd-tdep.c: Update.
4401         * frame-unwind.c: Update.
4402         * frame.c: Update.
4403         * gdbtypes.c: Update.
4404         * gnu-v3-abi.c: Update.
4405         * guile/guile-internal.h: Update.
4406         * guile/scm-block.c: Update.
4407         * guile/scm-breakpoint.c: Update.
4408         * guile/scm-cmd.c: Update.
4409         * guile/scm-disasm.c: Update.
4410         * guile/scm-frame.c: Update.
4411         * guile/scm-lazy-string.c: Update.
4412         * guile/scm-math.c: Update.
4413         * guile/scm-param.c: Update.
4414         * guile/scm-ports.c: Update.
4415         * guile/scm-pretty-print.c: Update.
4416         * guile/scm-symbol.c: Update.
4417         * guile/scm-symtab.c: Update.
4418         * guile/scm-type.c: Update.
4419         * guile/scm-value.c: Update.
4420         * i386-linux-tdep.c: Update.
4421         * i386-tdep.c: Update.
4422         * inf-loop.c: Update.
4423         * infcall.c: Update.
4424         * infcmd.c: Update.
4425         * infrun.c: Update.
4426         * jit.c: Update.
4427         * language.c: Update.
4428         * linespec.c: Update.
4429         * linux-fork.c: Update.
4430         * linux-nat.c: Update.
4431         * linux-tdep.c: Update.
4432         * linux-thread-db.c: Update.
4433         * main.c: Update.
4434         * mi/mi-cmd-break.c: Update.
4435         * mi/mi-cmd-stack.c: Update.
4436         * mi/mi-interp.c: Update.
4437         * mi/mi-main.c: Update.
4438         * objc-lang.c: Update.
4439         * p-valprint.c: Update.
4440         * parse.c: Update.
4441         * ppc-linux-tdep.c: Update.
4442         * printcmd.c: Update.
4443         * python/py-arch.c: Update.
4444         * python/py-breakpoint.c: Update.
4445         * python/py-cmd.c: Update.
4446         * python/py-finishbreakpoint.c: Update.
4447         * python/py-frame.c: Update.
4448         * python/py-framefilter.c: Update.
4449         * python/py-gdb-readline.c: Update.
4450         * python/py-inferior.c: Update.
4451         * python/py-infthread.c: Update.
4452         * python/py-lazy-string.c: Update.
4453         * python/py-linetable.c: Update.
4454         * python/py-objfile.c: Update.
4455         * python/py-param.c: Update.
4456         * python/py-prettyprint.c: Update.
4457         * python/py-progspace.c: Update.
4458         * python/py-record-btrace.c: Update.
4459         * python/py-record.c: Update.
4460         * python/py-symbol.c: Update.
4461         * python/py-type.c: Update.
4462         * python/py-unwind.c: Update.
4463         * python/py-utils.c: Update.
4464         * python/py-value.c: Update.
4465         * python/python.c: Update.
4466         * record-btrace.c: Update.
4467         * record-full.c: Update.
4468         * remote-fileio.c: Update.
4469         * remote.c: Update.
4470         * riscv-tdep.c: Update.
4471         * rs6000-aix-tdep.c: Update.
4472         * rs6000-tdep.c: Update.
4473         * rust-exp.y: Update.
4474         * rust-lang.c: Update.
4475         * s390-tdep.c: Update.
4476         * selftest-arch.c: Update.
4477         * solib-dsbt.c: Update.
4478         * solib-frv.c: Update.
4479         * solib-spu.c: Update.
4480         * solib-svr4.c: Update.
4481         * solib.c: Update.
4482         * sparc64-linux-tdep.c: Update.
4483         * stack.c: Update.
4484         * symfile-mem.c: Update.
4485         * symmisc.c: Update.
4486         * target.c: Update.
4487         * thread.c: Update.
4488         * top.c: Update.
4489         * tracefile-tfile.c: Update.
4490         * tui/tui.c: Update.
4491         * typeprint.c: Update.
4492         * unittests/cli-utils-selftests.c: Update.
4493         * unittests/parse-connection-spec-selftests.c: Update.
4494         * valops.c: Update.
4495         * valprint.c: Update.
4496         * value.c: Update.
4497         * varobj.c: Update.
4498         * windows-nat.c: Update.
4499         * x86-linux-nat.c: Update.
4500         * xml-support.c: Update.
4501
4502 2019-04-08  Tom Tromey  <tom@tromey.com>
4503
4504         * xml-support.c: Use C++ exception handling.
4505         * x86-linux-nat.c: Use C++ exception handling.
4506         * windows-nat.c: Use C++ exception handling.
4507         * varobj.c: Use C++ exception handling.
4508         * value.c: Use C++ exception handling.
4509         * valprint.c: Use C++ exception handling.
4510         * valops.c: Use C++ exception handling.
4511         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4512         handling.
4513         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4514         * typeprint.c: Use C++ exception handling.
4515         * tui/tui.c: Use C++ exception handling.
4516         * tracefile-tfile.c: Use C++ exception handling.
4517         * top.c: Use C++ exception handling.
4518         * thread.c: Use C++ exception handling.
4519         * target.c: Use C++ exception handling.
4520         * symmisc.c: Use C++ exception handling.
4521         * symfile-mem.c: Use C++ exception handling.
4522         * stack.c: Use C++ exception handling.
4523         * sparc64-linux-tdep.c: Use C++ exception handling.
4524         * solib.c: Use C++ exception handling.
4525         * solib-svr4.c: Use C++ exception handling.
4526         * solib-spu.c: Use C++ exception handling.
4527         * solib-frv.c: Use C++ exception handling.
4528         * solib-dsbt.c: Use C++ exception handling.
4529         * selftest-arch.c: Use C++ exception handling.
4530         * s390-tdep.c: Use C++ exception handling.
4531         * rust-lang.c: Use C++ exception handling.
4532         * rust-exp.y: Use C++ exception handling.
4533         * rs6000-tdep.c: Use C++ exception handling.
4534         * rs6000-aix-tdep.c: Use C++ exception handling.
4535         * riscv-tdep.c: Use C++ exception handling.
4536         * remote.c: Use C++ exception handling.
4537         * remote-fileio.c: Use C++ exception handling.
4538         * record-full.c: Use C++ exception handling.
4539         * record-btrace.c: Use C++ exception handling.
4540         * python/python.c: Use C++ exception handling.
4541         * python/py-value.c: Use C++ exception handling.
4542         * python/py-utils.c: Use C++ exception handling.
4543         * python/py-unwind.c: Use C++ exception handling.
4544         * python/py-type.c: Use C++ exception handling.
4545         * python/py-symbol.c: Use C++ exception handling.
4546         * python/py-record.c: Use C++ exception handling.
4547         * python/py-record-btrace.c: Use C++ exception handling.
4548         * python/py-progspace.c: Use C++ exception handling.
4549         * python/py-prettyprint.c: Use C++ exception handling.
4550         * python/py-param.c: Use C++ exception handling.
4551         * python/py-objfile.c: Use C++ exception handling.
4552         * python/py-linetable.c: Use C++ exception handling.
4553         * python/py-lazy-string.c: Use C++ exception handling.
4554         * python/py-infthread.c: Use C++ exception handling.
4555         * python/py-inferior.c: Use C++ exception handling.
4556         * python/py-gdb-readline.c: Use C++ exception handling.
4557         * python/py-framefilter.c: Use C++ exception handling.
4558         * python/py-frame.c: Use C++ exception handling.
4559         * python/py-finishbreakpoint.c: Use C++ exception handling.
4560         * python/py-cmd.c: Use C++ exception handling.
4561         * python/py-breakpoint.c: Use C++ exception handling.
4562         * python/py-arch.c: Use C++ exception handling.
4563         * printcmd.c: Use C++ exception handling.
4564         * ppc-linux-tdep.c: Use C++ exception handling.
4565         * parse.c: Use C++ exception handling.
4566         * p-valprint.c: Use C++ exception handling.
4567         * objc-lang.c: Use C++ exception handling.
4568         * mi/mi-main.c: Use C++ exception handling.
4569         * mi/mi-interp.c: Use C++ exception handling.
4570         * mi/mi-cmd-stack.c: Use C++ exception handling.
4571         * mi/mi-cmd-break.c: Use C++ exception handling.
4572         * main.c: Use C++ exception handling.
4573         * linux-thread-db.c: Use C++ exception handling.
4574         * linux-tdep.c: Use C++ exception handling.
4575         * linux-nat.c: Use C++ exception handling.
4576         * linux-fork.c: Use C++ exception handling.
4577         * linespec.c: Use C++ exception handling.
4578         * language.c: Use C++ exception handling.
4579         * jit.c: Use C++ exception handling.
4580         * infrun.c: Use C++ exception handling.
4581         * infcmd.c: Use C++ exception handling.
4582         * infcall.c: Use C++ exception handling.
4583         * inf-loop.c: Use C++ exception handling.
4584         * i386-tdep.c: Use C++ exception handling.
4585         * i386-linux-tdep.c: Use C++ exception handling.
4586         * guile/scm-value.c: Use C++ exception handling.
4587         * guile/scm-type.c: Use C++ exception handling.
4588         * guile/scm-symtab.c: Use C++ exception handling.
4589         * guile/scm-symbol.c: Use C++ exception handling.
4590         * guile/scm-pretty-print.c: Use C++ exception handling.
4591         * guile/scm-ports.c: Use C++ exception handling.
4592         * guile/scm-param.c: Use C++ exception handling.
4593         * guile/scm-math.c: Use C++ exception handling.
4594         * guile/scm-lazy-string.c: Use C++ exception handling.
4595         * guile/scm-frame.c: Use C++ exception handling.
4596         * guile/scm-disasm.c: Use C++ exception handling.
4597         * guile/scm-cmd.c: Use C++ exception handling.
4598         * guile/scm-breakpoint.c: Use C++ exception handling.
4599         * guile/scm-block.c: Use C++ exception handling.
4600         * guile/guile-internal.h: Use C++ exception handling.
4601         * gnu-v3-abi.c: Use C++ exception handling.
4602         * gdbtypes.c: Use C++ exception handling.
4603         * frame.c: Use C++ exception handling.
4604         * frame-unwind.c: Use C++ exception handling.
4605         * fbsd-tdep.c: Use C++ exception handling.
4606         * f-valprint.c: Use C++ exception handling.
4607         * exec.c: Use C++ exception handling.
4608         * event-top.c: Use C++ exception handling.
4609         * event-loop.c: Use C++ exception handling.
4610         * eval.c: Use C++ exception handling.
4611         * dwarf2read.c: Use C++ exception handling.
4612         * dwarf2loc.c: Use C++ exception handling.
4613         * dwarf2-frame.c: Use C++ exception handling.
4614         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4615         * dwarf-index-write.c: Use C++ exception handling.
4616         * dwarf-index-cache.c: Use C++ exception handling.
4617         * dtrace-probe.c: Use C++ exception handling.
4618         * disasm-selftests.c: Use C++ exception handling.
4619         * darwin-nat.c: Use C++ exception handling.
4620         * cp-valprint.c: Use C++ exception handling.
4621         * cp-support.c: Use C++ exception handling.
4622         * cp-abi.c: Use C++ exception handling.
4623         * corelow.c: Use C++ exception handling.
4624         * completer.c: Use C++ exception handling.
4625         * compile/compile-object-run.c: Use C++ exception handling.
4626         * compile/compile-object-load.c: Use C++ exception handling.
4627         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4628         * compile/compile-c-symbols.c: Use C++ exception handling.
4629         * common/selftest.c: Use C++ exception handling.
4630         * common/new-op.c: Use C++ exception handling.
4631         * cli/cli-script.c: Use C++ exception handling.
4632         * cli/cli-interp.c: Use C++ exception handling.
4633         * cli/cli-cmds.c: Use C++ exception handling.
4634         * c-varobj.c: Use C++ exception handling.
4635         * btrace.c: Use C++ exception handling.
4636         * breakpoint.c: Use C++ exception handling.
4637         * break-catch-throw.c: Use C++ exception handling.
4638         * arch-utils.c: Use C++ exception handling.
4639         * amd64-tdep.c: Use C++ exception handling.
4640         * ada-valprint.c: Use C++ exception handling.
4641         * ada-typeprint.c: Use C++ exception handling.
4642         * ada-lang.c: Use C++ exception handling.
4643         * aarch64-tdep.c: Use C++ exception handling.
4644
4645 2019-04-08  Tom Tromey  <tom@tromey.com>
4646
4647         * xml-support.c (gdb_xml_parser::parse): Update.
4648         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4649         * value.c (show_convenience): Update.
4650         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4651         (test_parse_flags_qcs): Update.
4652         * thread.c (thr_try_catch_cmd): Update.
4653         * target.c (target_translate_tls_address): Update.
4654         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4655         (info_frame_command_core, frame_apply_command_count): Update.
4656         * rust-exp.y (rust_lex_exception_test): Update.
4657         * riscv-tdep.c (riscv_print_one_register_info): Update.
4658         * remote.c (remote_target::enable_btrace): Update.
4659         * record-btrace.c (record_btrace_enable_warn): Update.
4660         * python/py-utils.c (gdbpy_convert_exception): Update.
4661         * printcmd.c (do_one_display, print_variable_and_value): Update.
4662         * mi/mi-main.c (mi_print_exception): Update.
4663         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4664         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4665         * linux-nat.c (linux_nat_target::attach): Update.
4666         * linux-fork.c (class scoped_switch_fork_info): Update.
4667         * infrun.c (displaced_step_prepare): Update.
4668         * infcall.c (call_function_by_hand_dummy): Update.
4669         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4670         * gnu-v3-abi.c (print_one_vtable): Update.
4671         * frame.c (get_prev_frame_always): Update.
4672         * f-valprint.c (info_common_command_for_block): Update.
4673         * exec.c (try_open_exec_file): Update.
4674         * exceptions.c (print_exception, exception_print)
4675         (exception_fprintf, exception_print_same): Update.
4676         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4677         * dwarf-index-cache.c (index_cache::store)
4678         (index_cache::lookup_gdb_index): Update.
4679         * darwin-nat.c (maybe_cache_shell): Update.
4680         * cp-valprint.c (cp_print_value_fields): Update.
4681         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4682         (gcc_cplus_symbol_address): Update.
4683         * compile/compile-c-symbols.c (gcc_convert_symbol)
4684         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4685         * common/selftest.c: Update.
4686         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4687         a std::string.
4688         (exception_try_scope_entry, exception_try_scope_exit): Don't
4689         declare.
4690         (struct exception_try_scope): Remove.
4691         (TRY): Don't use exception_try_scope.
4692         (struct gdb_exception): Add constructor, operator=.
4693         <what>: New method.
4694         (struct gdb_exception_RETURN_MASK_ALL)
4695         (struct gdb_exception_RETURN_MASK_ERROR)
4696         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4697         (struct gdb_quit_bad_alloc): Update.
4698         * common/common-exceptions.c (exception_none): Change
4699         initializer.
4700         (struct catcher) <state, exception>: Initialize inline.
4701         <prev>: Remove member.
4702         (current_catcher): Remove.
4703         (catchers): New global.
4704         (exceptions_state_mc_init): Simplify.
4705         (catcher_pop): Remove.
4706         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4707         (try_scope_depth, exception_try_scope_entry)
4708         (exception_try_scope_exit): Remove.
4709         (throw_exception_sjlj): Update.
4710         (exception_messages, exception_messages_size): Remove.
4711         (throw_it): Simplify.
4712         (gdb_exception_sliced_copy): Remove.
4713         (throw_exception_cxx): Update.
4714         * cli/cli-script.c (script_from_file): Update.
4715         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4716         Update.
4717         * ada-valprint.c (ada_val_print): Update.
4718         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4719         (create_excep_cond_exprs): Update.
4720
4721 2019-04-08  Tom Tromey  <tom@tromey.com>
4722
4723         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4724         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4725         (TRY, CATCH, END_CATCH): Remove some definitions.
4726         * common/common-exceptions.c: Don't use GDB_XCPT.
4727         (catcher_list_size): Remove.
4728         (throw_exception, throw_it): Simplify.
4729
4730 2019-04-05  Tom Tromey  <tom@tromey.com>
4731
4732         Revert the header-sorting patch.
4733         * ft32-tdep.c: Revert.
4734         * frv-tdep.c: Revert.
4735         * frv-linux-tdep.c: Revert.
4736         * frame.c: Revert.
4737         * frame-unwind.c: Revert.
4738         * frame-base.c: Revert.
4739         * fork-child.c: Revert.
4740         * findvar.c: Revert.
4741         * findcmd.c: Revert.
4742         * filesystem.c: Revert.
4743         * filename-seen-cache.h: Revert.
4744         * filename-seen-cache.c: Revert.
4745         * fbsd-tdep.c: Revert.
4746         * fbsd-nat.h: Revert.
4747         * fbsd-nat.c: Revert.
4748         * f-valprint.c: Revert.
4749         * f-typeprint.c: Revert.
4750         * f-lang.c: Revert.
4751         * extension.h: Revert.
4752         * extension.c: Revert.
4753         * extension-priv.h: Revert.
4754         * expprint.c: Revert.
4755         * exec.h: Revert.
4756         * exec.c: Revert.
4757         * exceptions.c: Revert.
4758         * event-top.c: Revert.
4759         * event-loop.c: Revert.
4760         * eval.c: Revert.
4761         * elfread.c: Revert.
4762         * dwarf2read.h: Revert.
4763         * dwarf2read.c: Revert.
4764         * dwarf2loc.c: Revert.
4765         * dwarf2expr.h: Revert.
4766         * dwarf2expr.c: Revert.
4767         * dwarf2-frame.c: Revert.
4768         * dwarf2-frame-tailcall.c: Revert.
4769         * dwarf-index-write.h: Revert.
4770         * dwarf-index-write.c: Revert.
4771         * dwarf-index-common.c: Revert.
4772         * dwarf-index-cache.h: Revert.
4773         * dwarf-index-cache.c: Revert.
4774         * dummy-frame.c: Revert.
4775         * dtrace-probe.c: Revert.
4776         * disasm.h: Revert.
4777         * disasm.c: Revert.
4778         * disasm-selftests.c: Revert.
4779         * dictionary.c: Revert.
4780         * dicos-tdep.c: Revert.
4781         * demangle.c: Revert.
4782         * dcache.h: Revert.
4783         * dcache.c: Revert.
4784         * darwin-nat.h: Revert.
4785         * darwin-nat.c: Revert.
4786         * darwin-nat-info.c: Revert.
4787         * d-valprint.c: Revert.
4788         * d-namespace.c: Revert.
4789         * d-lang.c: Revert.
4790         * ctf.c: Revert.
4791         * csky-tdep.c: Revert.
4792         * csky-linux-tdep.c: Revert.
4793         * cris-tdep.c: Revert.
4794         * cris-linux-tdep.c: Revert.
4795         * cp-valprint.c: Revert.
4796         * cp-support.c: Revert.
4797         * cp-namespace.c: Revert.
4798         * cp-abi.c: Revert.
4799         * corelow.c: Revert.
4800         * corefile.c: Revert.
4801         * continuations.c: Revert.
4802         * completer.h: Revert.
4803         * completer.c: Revert.
4804         * complaints.c: Revert.
4805         * coffread.c: Revert.
4806         * coff-pe-read.c: Revert.
4807         * cli-out.h: Revert.
4808         * cli-out.c: Revert.
4809         * charset.c: Revert.
4810         * c-varobj.c: Revert.
4811         * c-valprint.c: Revert.
4812         * c-typeprint.c: Revert.
4813         * c-lang.c: Revert.
4814         * buildsym.c: Revert.
4815         * buildsym-legacy.c: Revert.
4816         * build-id.h: Revert.
4817         * build-id.c: Revert.
4818         * btrace.c: Revert.
4819         * bsd-uthread.c: Revert.
4820         * breakpoint.h: Revert.
4821         * breakpoint.c: Revert.
4822         * break-catch-throw.c: Revert.
4823         * break-catch-syscall.c: Revert.
4824         * break-catch-sig.c: Revert.
4825         * blockframe.c: Revert.
4826         * block.c: Revert.
4827         * bfin-tdep.c: Revert.
4828         * bfin-linux-tdep.c: Revert.
4829         * bfd-target.c: Revert.
4830         * bcache.c: Revert.
4831         * ax-general.c: Revert.
4832         * ax-gdb.h: Revert.
4833         * ax-gdb.c: Revert.
4834         * avr-tdep.c: Revert.
4835         * auxv.c: Revert.
4836         * auto-load.c: Revert.
4837         * arm-wince-tdep.c: Revert.
4838         * arm-tdep.c: Revert.
4839         * arm-symbian-tdep.c: Revert.
4840         * arm-pikeos-tdep.c: Revert.
4841         * arm-obsd-tdep.c: Revert.
4842         * arm-nbsd-tdep.c: Revert.
4843         * arm-nbsd-nat.c: Revert.
4844         * arm-linux-tdep.c: Revert.
4845         * arm-linux-nat.c: Revert.
4846         * arm-fbsd-tdep.c: Revert.
4847         * arm-fbsd-nat.c: Revert.
4848         * arm-bsd-tdep.c: Revert.
4849         * arch-utils.c: Revert.
4850         * arc-tdep.c: Revert.
4851         * arc-newlib-tdep.c: Revert.
4852         * annotate.h: Revert.
4853         * annotate.c: Revert.
4854         * amd64-windows-tdep.c: Revert.
4855         * amd64-windows-nat.c: Revert.
4856         * amd64-tdep.c: Revert.
4857         * amd64-sol2-tdep.c: Revert.
4858         * amd64-obsd-tdep.c: Revert.
4859         * amd64-obsd-nat.c: Revert.
4860         * amd64-nbsd-tdep.c: Revert.
4861         * amd64-nbsd-nat.c: Revert.
4862         * amd64-nat.c: Revert.
4863         * amd64-linux-tdep.c: Revert.
4864         * amd64-linux-nat.c: Revert.
4865         * amd64-fbsd-tdep.c: Revert.
4866         * amd64-fbsd-nat.c: Revert.
4867         * amd64-dicos-tdep.c: Revert.
4868         * amd64-darwin-tdep.c: Revert.
4869         * amd64-bsd-nat.c: Revert.
4870         * alpha-tdep.c: Revert.
4871         * alpha-obsd-tdep.c: Revert.
4872         * alpha-nbsd-tdep.c: Revert.
4873         * alpha-mdebug-tdep.c: Revert.
4874         * alpha-linux-tdep.c: Revert.
4875         * alpha-linux-nat.c: Revert.
4876         * alpha-bsd-tdep.c: Revert.
4877         * alpha-bsd-nat.c: Revert.
4878         * aix-thread.c: Revert.
4879         * agent.c: Revert.
4880         * addrmap.c: Revert.
4881         * ada-varobj.c: Revert.
4882         * ada-valprint.c: Revert.
4883         * ada-typeprint.c: Revert.
4884         * ada-tasks.c: Revert.
4885         * ada-lang.c: Revert.
4886         * aarch64-tdep.c: Revert.
4887         * aarch64-ravenscar-thread.c: Revert.
4888         * aarch64-newlib-tdep.c: Revert.
4889         * aarch64-linux-tdep.c: Revert.
4890         * aarch64-linux-nat.c: Revert.
4891         * aarch64-fbsd-tdep.c: Revert.
4892         * aarch64-fbsd-nat.c: Revert.
4893         * aarch32-linux-nat.c: Revert.
4894
4895 2019-04-05  Tom Tromey  <tom@tromey.com>
4896
4897         * ft32-tdep.c: Sort headers.
4898         * frv-tdep.c: Sort headers.
4899         * frv-linux-tdep.c: Sort headers.
4900         * frame.c: Sort headers.
4901         * frame-unwind.c: Sort headers.
4902         * frame-base.c: Sort headers.
4903         * fork-child.c: Sort headers.
4904         * findvar.c: Sort headers.
4905         * findcmd.c: Sort headers.
4906         * filesystem.c: Sort headers.
4907         * filename-seen-cache.h: Sort headers.
4908         * filename-seen-cache.c: Sort headers.
4909         * fbsd-tdep.c: Sort headers.
4910         * fbsd-nat.h: Sort headers.
4911         * fbsd-nat.c: Sort headers.
4912         * f-valprint.c: Sort headers.
4913         * f-typeprint.c: Sort headers.
4914         * f-lang.c: Sort headers.
4915         * extension.h: Sort headers.
4916         * extension.c: Sort headers.
4917         * extension-priv.h: Sort headers.
4918         * expprint.c: Sort headers.
4919         * exec.h: Sort headers.
4920         * exec.c: Sort headers.
4921         * exceptions.c: Sort headers.
4922         * event-top.c: Sort headers.
4923         * event-loop.c: Sort headers.
4924         * eval.c: Sort headers.
4925         * elfread.c: Sort headers.
4926         * dwarf2read.h: Sort headers.
4927         * dwarf2read.c: Sort headers.
4928         * dwarf2loc.c: Sort headers.
4929         * dwarf2expr.h: Sort headers.
4930         * dwarf2expr.c: Sort headers.
4931         * dwarf2-frame.c: Sort headers.
4932         * dwarf2-frame-tailcall.c: Sort headers.
4933         * dwarf-index-write.h: Sort headers.
4934         * dwarf-index-write.c: Sort headers.
4935         * dwarf-index-common.c: Sort headers.
4936         * dwarf-index-cache.h: Sort headers.
4937         * dwarf-index-cache.c: Sort headers.
4938         * dummy-frame.c: Sort headers.
4939         * dtrace-probe.c: Sort headers.
4940         * disasm.h: Sort headers.
4941         * disasm.c: Sort headers.
4942         * disasm-selftests.c: Sort headers.
4943         * dictionary.c: Sort headers.
4944         * dicos-tdep.c: Sort headers.
4945         * demangle.c: Sort headers.
4946         * dcache.h: Sort headers.
4947         * dcache.c: Sort headers.
4948         * darwin-nat.h: Sort headers.
4949         * darwin-nat.c: Sort headers.
4950         * darwin-nat-info.c: Sort headers.
4951         * d-valprint.c: Sort headers.
4952         * d-namespace.c: Sort headers.
4953         * d-lang.c: Sort headers.
4954         * ctf.c: Sort headers.
4955         * csky-tdep.c: Sort headers.
4956         * csky-linux-tdep.c: Sort headers.
4957         * cris-tdep.c: Sort headers.
4958         * cris-linux-tdep.c: Sort headers.
4959         * cp-valprint.c: Sort headers.
4960         * cp-support.c: Sort headers.
4961         * cp-namespace.c: Sort headers.
4962         * cp-abi.c: Sort headers.
4963         * corelow.c: Sort headers.
4964         * corefile.c: Sort headers.
4965         * continuations.c: Sort headers.
4966         * completer.h: Sort headers.
4967         * completer.c: Sort headers.
4968         * complaints.c: Sort headers.
4969         * coffread.c: Sort headers.
4970         * coff-pe-read.c: Sort headers.
4971         * cli-out.h: Sort headers.
4972         * cli-out.c: Sort headers.
4973         * charset.c: Sort headers.
4974         * c-varobj.c: Sort headers.
4975         * c-valprint.c: Sort headers.
4976         * c-typeprint.c: Sort headers.
4977         * c-lang.c: Sort headers.
4978         * buildsym.c: Sort headers.
4979         * buildsym-legacy.c: Sort headers.
4980         * build-id.h: Sort headers.
4981         * build-id.c: Sort headers.
4982         * btrace.c: Sort headers.
4983         * bsd-uthread.c: Sort headers.
4984         * breakpoint.h: Sort headers.
4985         * breakpoint.c: Sort headers.
4986         * break-catch-throw.c: Sort headers.
4987         * break-catch-syscall.c: Sort headers.
4988         * break-catch-sig.c: Sort headers.
4989         * blockframe.c: Sort headers.
4990         * block.c: Sort headers.
4991         * bfin-tdep.c: Sort headers.
4992         * bfin-linux-tdep.c: Sort headers.
4993         * bfd-target.c: Sort headers.
4994         * bcache.c: Sort headers.
4995         * ax-general.c: Sort headers.
4996         * ax-gdb.h: Sort headers.
4997         * ax-gdb.c: Sort headers.
4998         * avr-tdep.c: Sort headers.
4999         * auxv.c: Sort headers.
5000         * auto-load.c: Sort headers.
5001         * arm-wince-tdep.c: Sort headers.
5002         * arm-tdep.c: Sort headers.
5003         * arm-symbian-tdep.c: Sort headers.
5004         * arm-pikeos-tdep.c: Sort headers.
5005         * arm-obsd-tdep.c: Sort headers.
5006         * arm-nbsd-tdep.c: Sort headers.
5007         * arm-nbsd-nat.c: Sort headers.
5008         * arm-linux-tdep.c: Sort headers.
5009         * arm-linux-nat.c: Sort headers.
5010         * arm-fbsd-tdep.c: Sort headers.
5011         * arm-fbsd-nat.c: Sort headers.
5012         * arm-bsd-tdep.c: Sort headers.
5013         * arch-utils.c: Sort headers.
5014         * arc-tdep.c: Sort headers.
5015         * arc-newlib-tdep.c: Sort headers.
5016         * annotate.h: Sort headers.
5017         * annotate.c: Sort headers.
5018         * amd64-windows-tdep.c: Sort headers.
5019         * amd64-windows-nat.c: Sort headers.
5020         * amd64-tdep.c: Sort headers.
5021         * amd64-sol2-tdep.c: Sort headers.
5022         * amd64-obsd-tdep.c: Sort headers.
5023         * amd64-obsd-nat.c: Sort headers.
5024         * amd64-nbsd-tdep.c: Sort headers.
5025         * amd64-nbsd-nat.c: Sort headers.
5026         * amd64-nat.c: Sort headers.
5027         * amd64-linux-tdep.c: Sort headers.
5028         * amd64-linux-nat.c: Sort headers.
5029         * amd64-fbsd-tdep.c: Sort headers.
5030         * amd64-fbsd-nat.c: Sort headers.
5031         * amd64-dicos-tdep.c: Sort headers.
5032         * amd64-darwin-tdep.c: Sort headers.
5033         * amd64-bsd-nat.c: Sort headers.
5034         * alpha-tdep.c: Sort headers.
5035         * alpha-obsd-tdep.c: Sort headers.
5036         * alpha-nbsd-tdep.c: Sort headers.
5037         * alpha-mdebug-tdep.c: Sort headers.
5038         * alpha-linux-tdep.c: Sort headers.
5039         * alpha-linux-nat.c: Sort headers.
5040         * alpha-bsd-tdep.c: Sort headers.
5041         * alpha-bsd-nat.c: Sort headers.
5042         * aix-thread.c: Sort headers.
5043         * agent.c: Sort headers.
5044         * addrmap.c: Sort headers.
5045         * ada-varobj.c: Sort headers.
5046         * ada-valprint.c: Sort headers.
5047         * ada-typeprint.c: Sort headers.
5048         * ada-tasks.c: Sort headers.
5049         * ada-lang.c: Sort headers.
5050         * aarch64-tdep.c: Sort headers.
5051         * aarch64-ravenscar-thread.c: Sort headers.
5052         * aarch64-newlib-tdep.c: Sort headers.
5053         * aarch64-linux-tdep.c: Sort headers.
5054         * aarch64-linux-nat.c: Sort headers.
5055         * aarch64-fbsd-tdep.c: Sort headers.
5056         * aarch64-fbsd-nat.c: Sort headers.
5057         * aarch32-linux-nat.c: Sort headers.
5058
5059 2019-04-04  Tom Tromey  <tom@tromey.com>
5060
5061         * varobj.c (varobj_create): Update.
5062         * rust-exp.y (struct rust_parser) <update_innermost_block,
5063         lookup_symbol>: New methods.
5064         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5065         Rename.
5066         (rust_parser::rust_lookup_type)
5067         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5068         * printcmd.c (display_command, do_one_display): Update.
5069         * parser-defs.h (struct parser_state) <parser_state>: Add
5070         "tracker" parameter.
5071         (block_tracker): New member.
5072         (class innermost_block_tracker) <innermost_block_tracker>: Add
5073         "types" parameter.
5074         <reset>: Remove method.
5075         (innermost_block): Don't declare.
5076         (null_post_parser): Update.
5077         * parse.c (innermost_block): Remove global.
5078         (write_dollar_variable): Update.
5079         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5080         Remove "tracker_types" parameter.
5081         (parse_expression): Add "tracker" parameter.
5082         (parse_expression_for_completion): Update.
5083         (null_post_parser): Add "tracker" parameter.
5084         * p-exp.y: Update rules.
5085         * m2-exp.y: Update rules.
5086         * language.h (struct language_defn) <la_post_parser>: Add
5087         "tracker" parameter.
5088         * go-exp.y: Update rules.
5089         * f-exp.y: Update rules.
5090         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5091         parameter.
5092         * d-exp.y: Update rules.
5093         * c-exp.y: Update rules.
5094         * breakpoint.c (set_breakpoint_condition): Create an
5095         innermost_block_tracker.
5096         (watch_command_1): Likewise.
5097         * ada-lang.c (resolve): Add "tracker" parameter.
5098         (resolve_subexp): Likewise.
5099         * ada-exp.y (write_var_from_sym): Update.
5100
5101 2019-04-04  Tom Tromey  <tom@tromey.com>
5102
5103         * type-stack.h: New file.
5104         * type-stack.c: New file.
5105         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5106         type-stack.h.
5107         (insert_into_type_stack, insert_type, push_type, push_type_int)
5108         (insert_type_address_space, pop_type, pop_type_int)
5109         (pop_typelist, pop_type_stack, append_type_stack)
5110         (push_type_stack, get_type_stack, push_typelist)
5111         (follow_type_instance_flags, follow_types): Don't declare.
5112         * parse.c (type_stack): Remove global.
5113         (parse_exp_in_context): Update.
5114         (insert_into_type_stack, insert_type, push_type, push_type_int)
5115         (insert_type_address_space, pop_type, pop_type_int)
5116         (pop_typelist, pop_type_stack, append_type_stack)
5117         (push_type_stack, get_type_stack, push_typelist)
5118         (follow_type_instance_flags, follow_types): Remove (moved to
5119         type-stack.c).
5120         * f-exp.y (type_stack): New global.
5121         Update rules.
5122         (push_kind_type, f_parse): Update.
5123         * d-exp.y (type_stack): New global.
5124         Update rules.
5125         (d_parse): Update.
5126         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5127         Update rules.
5128         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5129         (HFILES_NO_SRCDIR): Add type-stack.h.
5130
5131 2019-04-04  Tom Tromey  <tom@tromey.com>
5132
5133         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5134         (rust_parser::convert_ast_to_expression, rust_parse)
5135         (rust_lex_test_completion, rust_lex_tests): Update.
5136         * parser-defs.h (struct expr_completion_state): New.
5137         (struct parser_state) <parser_state>: Add completion parameter.
5138         <mark_struct_expression, mark_completion_tag>: New methods.
5139         <parse_completion, m_completion_state>: New members.
5140         (prefixify_expression, null_post_parser): Update.
5141         (mark_struct_expression, mark_completion_tag): Don't declare.
5142         * parse.c (parse_completion, expout_last_struct)
5143         (expout_tag_completion_type, expout_completion_name): Remove
5144         globals.
5145         (parser_state::mark_struct_expression)
5146         (parser_state::mark_completion_tag): Now methods.
5147         (prefixify_expression): Add last_struct parameter.
5148         (prefixify_subexp): Likewise.
5149         (parse_exp_1): Update.
5150         (parse_exp_in_context): Add cstate parameter.  Update.
5151         (parse_expression_for_completion): Create an
5152         expr_completion_state.
5153         (null_post_parser): Add "completion" parameter.
5154         * p-exp.y: Update rules.
5155         (yylex): Update.
5156         * language.h (struct language_defn) <la_post_parser>: Add
5157         "completing" parameter.
5158         * go-exp.y: Update rules.
5159         (lex_one_token): Update.
5160         * expression.h (parse_completion): Don't declare.
5161         * d-exp.y: Update rules.
5162         (lex_one_token): Update rules.
5163         * c-exp.y: Update rules.
5164         (lex_one_token): Update.
5165         * ada-lang.c (resolve): Add "parse_completion" parameter.
5166         (resolve_subexp): Likewise.
5167         (ada_resolve_function): Likewise.
5168
5169 2019-04-04  Tom Tromey  <tom@tromey.com>
5170
5171         * parser-defs.h (struct parser_state) <start_arglist,
5172         end_arglist>: New methods.
5173         <arglist_len, m_funcall_chain>: New members.
5174         (arglist_len, start_arglist, end_arglist): Don't declare.
5175         * parse.c (arglist_len, funcall_chain): Remove global.
5176         (start_arglist, end_arglist): Remove functions.
5177         (parse_exp_in_context): Update.
5178         * p-exp.y: Update rules.
5179         * m2-exp.y: Update rules.
5180         * go-exp.y: Update rules.
5181         * f-exp.y: Update rules.
5182         * d-exp.y: Update rules.
5183         * c-exp.y: Update rules.
5184
5185 2019-04-04  Tom Tromey  <tom@tromey.com>
5186
5187         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5188         lex_operator, push_back>: New methods.
5189         Update all rules.
5190         (rust_parser::lex_hex, lex_escape): Rename and update.
5191         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5192         (rust_parser::lex_operator): Rename and update.
5193         (rust_parser::lex_number, rustyylex, rustyyerror)
5194         (rust_lex_test_init, rust_lex_test_sequence)
5195         (rust_lex_test_push_back, rust_lex_tests): Update.
5196         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5197         parameter.
5198         <lexptr, prev_lexptr>: New members.
5199         (lexptr, prev_lexptr): Don't declare.
5200         * parse.c (lexptr, prev_lexptr): Remove globals.
5201         (parse_exp_in_context): Update.
5202         * p-exp.y (yylex, yyerror): Update.
5203         * m2-exp.y (parse_number, yylex, yyerror): Update.
5204         * go-exp.y (lex_one_token, yyerror): Update.
5205         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5206         * d-exp.y (lex_one_token, yyerror): Update.
5207         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5208         (lex_one_token, yyerror): Update.
5209         * ada-lex.l (YY_INPUT): Update.
5210         (rewind_to_char): Update.
5211         * ada-exp.y (yyerror): Update.
5212
5213 2019-04-04  Tom Tromey  <tom@tromey.com>
5214
5215         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5216         * parser-defs.h (struct parser_state) <parser_state>: Add new
5217         parameter.
5218         <comma_terminates>: New member.
5219         (comma_terminates): Don't declare global.
5220         * parse.c (comma_terminates): Remove global.
5221         (parse_exp_in_context): Update.
5222         * p-exp.y (yylex): Update.
5223         * m2-exp.y (yylex): Update.
5224         * go-exp.y (lex_one_token): Update.
5225         * f-exp.y (yylex): Update.
5226         * d-exp.y (lex_one_token): Update.
5227         * c-exp.y (lex_one_token): Update.
5228         * ada-lex.l: Update.
5229
5230 2019-04-04  Tom Tromey  <tom@tromey.com>
5231
5232         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5233         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5234         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5235         * parser-defs.h (paren_depth): Don't declare.
5236         * parse.c (paren_depth): Remove global.
5237         (parse_exp_in_context): Update.
5238         * p-exp.y (paren_depth): New global.
5239         (pascal_parse): Initialize it.
5240         * m2-exp.y (paren_depth): New global.
5241         (m2_parse): Initialize it.
5242         * go-exp.y (paren_depth): New global.
5243         (go_parse): Initialize it.
5244         * f-exp.y (paren_depth): New global.
5245         (f_parse): Initialize it.
5246         * d-exp.y (paren_depth): New global.
5247         (d_parse): Initialize it.
5248         * c-exp.y (paren_depth): New global.
5249         (c_parse): Initialize it.
5250         * ada-lex.l (paren_depth): New global.
5251         (lexer_init): Initialize it.
5252
5253 2019-04-04  Tom Tromey  <tom@tromey.com>
5254
5255         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5256         (rust_parser::convert_ast_to_type)
5257         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5258         * parser-defs.h (struct parser_state) <parser_state>: Add
5259         parameters.  Initialize new members.
5260         <expression_context_block, expression_context_pc>: New members.
5261         * parse.c (expression_context_block, expression_context_pc):
5262         Remove globals.
5263         (parse_exp_in_context): Update.
5264         * p-exp.y: Update all rules.
5265         (yylex): Update.
5266         * m2-exp.y: Update all rules.
5267         (yylex): Update.
5268         * go-exp.y (yylex): Update.
5269         * f-exp.y (yylex): Update.
5270         * d-exp.y: Update all rules.
5271         (yylex): Update.
5272         * c-exp.y: Update all rules.
5273         (lex_one_token, classify_name, yylex, c_parse): Update.
5274         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5275
5276 2019-04-04  Tom Tromey  <tom@tromey.com>
5277
5278         * gdbarch.h, gdbarch.c: Rebuild.
5279         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5280         * stap-probe.h:
5281         (struct stap_parse_info): Replace "parser_state" with
5282         "expr_builder".
5283         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5284         (parser_state): New class.
5285         * parse.c (expr_builder): Rename.
5286         (expr_builder::release): Rename.
5287         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5288         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5289         (write_exp_elt_longcst, write_exp_elt_floatcst)
5290         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5291         (write_exp_string_vector, write_exp_bitstring)
5292         (write_exp_msymbol, mark_struct_expression)
5293         (write_dollar_variable)
5294         (insert_type_address_space, increase_expout_size): Replace
5295         "parser_state" with "expr_builder".
5296         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5297         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5298         "parser_state" with "expr_builder".
5299
5300 2019-04-04  Tom Tromey  <tom@tromey.com>
5301
5302         * rust-exp.y: Replace "parse_language" with method call.
5303         * p-exp.y:
5304         (yylex): Replace "parse_language" with method call.
5305         * m2-exp.y:
5306         (yylex): Replace "parse_language" with method call.
5307         * go-exp.y (classify_name): Replace "parse_language" with method
5308         call.
5309         * f-exp.y (yylex): Replace "parse_language" with method call.
5310         * d-exp.y (lex_one_token): Replace "parse_language" with method
5311         call.
5312         * c-exp.y:
5313         (lex_one_token, classify_name, yylex): Replace "parse_language"
5314         with method call.
5315         * ada-exp.y (find_primitive_type, type_char)
5316         (type_system_address): Replace "parse_language" with method call.
5317
5318 2019-04-04  Tom Tromey  <tom@tromey.com>
5319
5320         * rust-exp.y: Replace "parse_gdbarch" with method call.
5321         * parse.c (write_dollar_variable, insert_type_address_space):
5322         Replace "parse_gdbarch" with method call.
5323         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5324         call.
5325         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5326         call.
5327         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5328         "parse_gdbarch" with method call.
5329         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5330         with method call.
5331         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5332         "parse_gdbarch" with method call.
5333         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5334         "parse_gdbarch" with method call.
5335         * c-exp.y (parse_type, parse_number, classify_name): Replace
5336         "parse_gdbarch" with method call.
5337         * ada-lex.l: Replace "parse_gdbarch" with method call.
5338         * ada-exp.y (parse_type, find_primitive_type, type_char)
5339         (type_system_address): Replace "parse_gdbarch" with method call.
5340
5341 2019-04-04  Tom Tromey  <tom@tromey.com>
5342
5343         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5344         * stap-probe.c (stap_parse_argument): Update.
5345         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5346         initial_size parameter.
5347         * rust-exp.y (rust_lex_tests): Update.
5348         * parse.c (parser_state): Update.
5349         (parse_exp_in_context): Update.
5350         * parser-defs.h (struct parser_state) <parser_state>: Remove
5351         "initial_size" parameter.
5352
5353 2019-04-04  Tom Tromey  <tom@tromey.com>
5354
5355         * parser-defs.h (increase_expout_size): Don't declare.
5356         * parse.c (increase_expout_size): Now static.
5357
5358 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5359
5360         * gnu-nat.c (gnu_nat_target::wait): Fix
5361         target_waitstatus_to_string call.
5362
5363 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5364
5365         * eval.c (evaluate_subexp_standard): Handle internal functions
5366         during Fortran function call handling.
5367
5368 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5369
5370         * NEWS: Mention new internal functions.
5371         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5372         (read_base_type): Use dwarf2_init_complex_target_type.
5373         * value.c (creal_internal_fn): New function.
5374         (cimag_internal_fn): New function.
5375         (_initialize_values): Register new internal functions.
5376
5377 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5378
5379         * infrun.c (stop_all_threads): If debug_infrun, always
5380         trace the wait status after wait_one, using
5381         target_waitstatus_to_string and target_pid_to_str.
5382         (handle_inferior_event): Replace various trace of
5383         wait status kind by a single trace.
5384         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5385         wait status kind image by target_waitstatus_to_string.
5386         * target/waitstatus.c (target_waitstatus_to_string): Fix
5387         obsolete comment.
5388
5389 2019-04-01  Tom Tromey  <tromey@adacore.com>
5390
5391         PR symtab/23331:
5392         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5393
5394 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5395             Pedro Alves  <palves@redhat.com>
5396
5397         * top.c (quit_force): Call 'finalize_values'.
5398         * value.c (finalize_values): New function.
5399         * value.h (finalize_values): Declare.
5400
5401 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5402
5403         * NEWS: Announce $_gdb_major and $_gdb_minor.
5404
5405         * top.c (init_gdb_version_vars): New function.
5406         (gdb_init): Call init_gdb_version_vars.
5407
5408 2019-03-29  Tom Tromey  <tromey@adacore.com>
5409
5410         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5411         help text.  Remove dead code.
5412
5413 2019-03-29  Keith Seitz  <keiths@redhat.com>
5414
5415         From Siddhesh Poyarekar:
5416         * f-lang.h (f77_get_upperbound): Return LONGEST.
5417         (f77_get_lowerbound): Likewise.
5418         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5419         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5420         print them.
5421         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5422         plongest to format print it.
5423         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5424         (f77_get_upperbound): Likewise.
5425         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5426         LOWER_BOUND to LONGEST.
5427         (f77_create_arrayprint_offset_tbl): Likewise.
5428
5429 2019-03-29  Keith Seitz  <keiths@redhat.com>
5430
5431         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5432         %s/pulongest for TYPE_LENGTH instead of %d in format
5433         strings.
5434         * ada-typerint.c (ada_print_type): Likewise.
5435         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5436         * compile/compile-c-support.c (generate_register_struct): Likewise.
5437         * gdbtypes.c (recursive_dump_type): Likewise.
5438         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5439         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5440         instead of %d in format strings.
5441         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5442         to std::min to ULONGEST.
5443         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5444         instead of %d in format strings.
5445         * tracepoint.c (info_scope_command): Likewise.
5446         * typeprint.c (print_offset_data::update)
5447         (print_offset_data::finish): Likewise.
5448         * xtensa-tdep.c (xtensa_store_return_value)
5449         (xtensa_push_dummy_call): Likewise.
5450
5451 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5452
5453         * windows-nat.c (display_selector): Fixed format specifications
5454         for 64-bit Cygwin.
5455
5456 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5457
5458         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5459
5460 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5461
5462         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5463         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5464         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5465         (nios2_linux_init_abi): Install it.
5466
5467 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5468
5469         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5470
5471 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5472
5473         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5474
5475 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5476             Tom Tromey  <tromey@adacore.com>
5477
5478         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5479
5480 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5481
5482         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5483         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5484         method to compute the bounds of range types. Also print "[evaluated]"
5485         if the bounds' values come from a dynamic evaluation.
5486
5487 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5488
5489         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5490         whitespace when pretty printing is on.
5491
5492 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5493
5494         * ppc-linux-nat.c: Add include.
5495
5496 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5497
5498         * NEWS: Mention AArch64 Pointer Authentication.
5499
5500 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5501
5502         * arm-linux-nat.c: Add include.
5503
5504 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5505
5506         * source-cache.c (source_cache::get_source_lines): Re-read
5507         fullname after calling open_source_file.
5508
5509 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5510
5511         * NEWS: Mention TLS support for FreeBSD.
5512
5513 2019-03-25  Tom Tromey  <tromey@adacore.com>
5514
5515         * minsyms.c (BUNCH_SIZE): Update comment.
5516         (~minimal_symbol_reader): Remove old comment.
5517         (compact_minimal_symbols): Update comment.
5518         (minimal_symbol_reader::install): Remove old comment.  Update
5519         other comments.
5520
5521 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5522
5523         * s390-linux-nat.c: Add include.
5524
5525 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5526
5527         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5528         Call linux_get_hwcap.
5529         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5530         Likewise.
5531         (aarch64_linux_get_hwcap): Remove function.
5532         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5533         declaration.
5534         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5535         linux_get_hwcap.
5536         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5537         * linux-tdep.c (linux_get_hwcap): Add function.
5538         (linux_get_hwcap2): Likewise.
5539         * linux-tdep.h (linux_get_hwcap): Add declaration.
5540         (linux_get_hwcap2): Likewise.
5541         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5542         (ppc_linux_get_hwcap2): Likewise.
5543         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5544         linux_get_hwcap.
5545         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5546         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5547         (ppc_linux_nat_target::read_description): Likewise.
5548         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5549         * s390-linux-nat.c: Likewise.
5550         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5551
5552 2019-03-24  Tom Tromey  <tom@tromey.com>
5553
5554         * ada-lang.c (standard_lookup): Simplify initialization.
5555         (ada_lookup_symbol_nonlocal): Simplify return.
5556         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5557         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5558         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5559         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5560         initialization.
5561         * solib.c (solib_global_lookup): Simplify.
5562         * symtab.c (null_block_symbol): Remove.
5563         (symbol_cache_lookup): Simplify returns.
5564         (lookup_language_this): Simplify returns.
5565         (lookup_symbol_aux): Simplify return.
5566         (lookup_local_symbol): Simplify returns.
5567         (lookup_global_symbol_from_objfile): Simplify return.
5568         (lookup_symbol_in_objfile_symtabs)
5569         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5570         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5571         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5572         * cp-namespace.c (cp_lookup_bare_symbol)
5573         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5574         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5575         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5576         (cp_lookup_symbol_via_imports): Simplify initialization.
5577         (find_symbol_in_baseclass): Likewise.
5578         * symtab.h (null_block_symbol): Remove.
5579         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5580         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5581         (d_lookup_symbol_module): Likewise.
5582         (find_symbol_in_baseclass): Simplify initialization.
5583
5584 2019-03-24  Tom Tromey  <tom@tromey.com>
5585
5586         * expression.h: Don't include symtab.h.
5587         (struct block): Forward declare.
5588
5589 2019-03-24  Tom Tromey  <tom@tromey.com>
5590
5591         * c-exp.y (typebase): Remove casts.
5592         * gdbtypes.c (lookup_unsigned_typename, )
5593         (lookup_signed_typename): Remove cast.
5594         * eval.c (parse_to_comma_and_eval): Remove cast.
5595         * parse.c (write_dollar_variable): Remove cast.
5596         * block.h (struct block) <superblock>: Now const.
5597         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5598         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5599         (map_block): Make "block" const.
5600         * symfile.h (struct quick_symbol_functions)
5601         <map_matching_symbols>: Constify block argument to "callback".
5602         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5603         const.
5604         (find_pc_sect_compunit_symtab): Make "b" const.
5605         (find_symbol_at_address): Likewise.
5606         (search_symbols): Likewise.
5607         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5608         (dw2_debug_names_lookup_symbol): Likewise.
5609         (dw2_map_matching_symbols): Update.
5610         * p-valprint.c (pascal_val_print): Remove "block".
5611         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5612         (aux_add_nonlocal_symbols): Make "block" const.
5613         (resolve_subexp): Remove cast.
5614         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5615         const.
5616         (iterate_over_file_blocks): Likewise.
5617         * f-exp.y (%union) <bval>: Remove.
5618         * coffread.c (patch_opaque_types): Make "b" const.
5619         * spu-tdep.c (spu_catch_start): Make "block" const.
5620         * c-valprint.c (print_unpacked_pointer): Remove "block".
5621         * symmisc.c (dump_symtab_1): Make "b" const.
5622         (block_depth): Make "block" const.
5623         * d-exp.y (%union) <bval>: Remove.
5624         * cp-support.h (cp_lookup_rtti_type): Update.
5625         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5626         * psymtab.c (psym_lookup_symbol): Make "block" const.
5627         (maintenance_check_psymtabs): Make "b" const.
5628         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5629         (enumerate_locals, enumerate_args): Update.
5630         * python/py-symtab.c (stpy_global_block): Make "block" const.
5631         (stpy_static_block): Likewise.
5632         * inline-frame.c (block_starting_point_at): Make "new_block"
5633         const.
5634         * block.c (find_block_in_blockvector): Make return type const.
5635         (blockvector_for_pc_sect): Make "b" const.
5636         (find_block_in_blockvector): Make "b" const.
5637
5638 2019-03-23  Tom Tromey  <tom@tromey.com>
5639
5640         * varobj.c (varobj_create): Update.
5641         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5642         * printcmd.c (display_command, do_one_display): Don't reset
5643         innermost_block.
5644         * parser-defs.h (enum innermost_block_tracker_type): Move to
5645         expression.h.
5646         (innermost_block): Update comment.
5647         * parse.c (parse_exp_1): Add tracker_types parameter.
5648         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5649         tracker_types parameter.  Reset innermost_block.
5650         (parse_exp_in_context): Remove.
5651         (parse_expression_for_completion): Update.
5652         * objfiles.c (~objfile): Don't reset expression_context_block or
5653         innermost_block.
5654         * expression.h (enum innermost_block_tracker_type): Move from
5655         parser-defs.h.
5656         (parse_exp_1): Add tracker_types parameter.
5657         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5658         reset innermost_block.
5659
5660 2019-03-23  Tom Tromey  <tom@tromey.com>
5661
5662         * objfiles.h: Include bcache.h.
5663
5664 2019-03-23  Tom Tromey  <tom@tromey.com>
5665
5666         * linespec.c (get_current_search_block): Use
5667         scoped_restore_current_language.
5668         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5669
5670 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5671             Jiong Wang  <jiong.wang@arm.com>
5672
5673         * aarch64-linux-tdep.c
5674         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5675         section.
5676         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5677
5678 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5679             Jiong Wang  <jiong.wang@arm.com>
5680
5681         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5682         instructions.
5683         (aarch64_analyze_prologue_test): Add PACIASP test.
5684         (aarch64_prologue_prev_register): Unmask PC value.
5685
5686 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5687             Jiong Wang  <jiong.wang@arm.com>
5688
5689         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5690         (aarch64_dwarf2_prev_register): Unmask PC value.
5691         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5692         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5693         DW_CFA_AARCH64_negate_ra_state.
5694         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5695
5696 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5697             Jiong Wang  <jiong.wang@arm.com>
5698
5699         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5700         registers.
5701         (aarch64_pseudo_register_name): Likewise.
5702         (aarch64_pseudo_register_type): Likewise.
5703         (aarch64_pseudo_register_reggroup_p): Likewise.
5704         (aarch64_gdbarch_init): Add pauth registers.
5705         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5706         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5707         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5708         (struct gdbarch_tdep): Add regnum for ra_state.
5709
5710 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5711             Jiong Wang  <jiong.wang@arm.com>
5712
5713         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5714
5715 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5716             Jiong Wang  <jiong.wang@arm.com>
5717
5718         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5719         function.
5720         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5721         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5722         (aarch64_gdbarch_init): Add puth registers.
5723         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5724         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5725         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5726
5727 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5728             Jiong Wang  <jiong.wang@arm.com>
5729
5730         * aarch64-linux-nat.c
5731         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5732         * aarch64-linux-tdep.c
5733         (aarch64_linux_core_read_description): Likewise.
5734         (aarch64_linux_get_hwcap): New function.
5735         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5736         (aarch64_linux_get_hwcap): New declaration.
5737
5738 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5739             Jiong Wang  <jiong.wang@arm.com>
5740
5741         * aarch64-linux-nat.c
5742         (aarch64_linux_nat_target::read_description): Add pauth param.
5743         * aarch64-linux-tdep.c
5744         (aarch64_linux_core_read_description): Likewise.
5745         * aarch64-tdep.c (struct target_desc): Add in pauth.
5746         (aarch64_read_description): Add pauth param.
5747         (aarch64_gdbarch_init): Likewise.
5748         * aarch64-tdep.h (aarch64_read_description): Likewise.
5749         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5750         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5751         * features/Makefile: Add new files.
5752         * features/aarch64-pauth.c: New file.
5753         * features/aarch64-pauth.xml: New file.
5754
5755 2019-03-20  Tom Tromey  <tromey@adacore.com>
5756
5757         * infrun.c (handle_inferior_event): Rename from
5758         handle_inferior_event_1.  Create a scoped_value_mark.
5759         (handle_inferior_event): Remove.
5760
5761 2019-03-19  Tom Tromey  <tromey@adacore.com>
5762
5763         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5764         * infrun.h (print_stop_event): Add "displays" parameter.
5765         * infrun.c (print_stop_event): Add "displays" parameter.
5766
5767 2019-03-19  Pedro Alves  <palves@redhat.com>
5768
5769         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5770         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5771         to -1.  Fix TABs vs spaces.
5772         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5773         * tui/tui-out.h (tui_ui_out) Add intro comments.
5774         <m_line, m_start_of_line>: In-class initialize, and add describing
5775         comment.
5776
5777 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5778
5779         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5780         variable names.
5781         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5782
5783 2019-03-18  Pedro Alves  <palves@redhat.com>
5784             Eli Zaretskii <eliz@gnu.org>
5785
5786         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5787         m_line and m_start_of_line.
5788
5789 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5790
5791         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5792         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5793         it returns a newline.  This fixes a regression in TU mode, whereby
5794         the next line is output on the same screen line as the user input.
5795
5796 2019-03-18  Tom Tromey  <tromey@adacore.com>
5797
5798         * minsyms.c (minimal_symbol_reader::install): Remove call to
5799         obstack_blank.
5800
5801 2019-03-18  Pedro Alves  <palves@redhat.com>
5802
5803         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5804         New globals.
5805         (apply_style): New, factored out from ...
5806         (apply_ansi_escape): ... this.  Handle reverse video mode.
5807         (tui_set_reverse_mode): New function.
5808         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5809         * tui/tui-winsource.c (tui_show_source_line): Use
5810         tui_set_reverse_mode instead of setting A_STANDOUT.
5811         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5812         New setter methods.
5813
5814 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5815
5816         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5817         Handle tabs.
5818
5819 2019-03-18  Tom Tromey  <tromey@adacore.com>
5820
5821         * ada-lang.c (empty_array): Add "high" parameter.
5822         (ada_evaluate_subexp): Update.
5823
5824 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5825
5826         * unittests/string_view-selftests.c: Define
5827         _initialize_string_view_selftests unconditionally.
5828
5829 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5830
5831         PR gdb/24350
5832         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5833
5834 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5835
5836         PR gdb/24351
5837         * windows-nat.c (display_selector): Fix format specifiers.
5838
5839 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5840
5841         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5842         tui_refill_source_window instead of tui_refresh_win, to update the
5843         current execution line.  This fixes redisplay of the current line
5844         when stepping through the code with "next" or "step".
5845
5846 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5847
5848         * source-cache.c (source_cache::get_source_lines): Call
5849         find_source_lines to initialize s->nlines.  This fixes vertical
5850         scrolling of TUI source window when the DOWN arrow is pressed.
5851
5852 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5853
5854         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5855         linux-thread-db.c (_initialize_thread_db): Likewise.
5856
5857 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5858
5859         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5860         wclrtoeol in tui_show_source_line".  This reverts changes made in
5861         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5862
5863 2019-03-15  Tom Tromey  <tom@tromey.com>
5864
5865         * symtab.h (struct minimal_symbol): Derive from
5866         general_symbol_info.
5867         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5868         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5869         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5870         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5871         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5872         (MSYMBOL_SEARCH_NAME): Update.
5873         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5874         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5875         * minsyms.c (minimal_symbol_reader::record_full): Update.
5876
5877 2019-03-15  Tom Tromey  <tom@tromey.com>
5878
5879         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5880
5881 2019-03-15  Tom Tromey  <tom@tromey.com>
5882
5883         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5884         unique_xmalloc_ptr.
5885         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5886         Update.
5887         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5888         (build_minimal_symbol_hash_tables)
5889         (minimal_symbol_reader::install): Update.
5890
5891 2019-03-15  Tom Tromey  <tom@tromey.com>
5892
5893         * symtab.c (create_demangled_names_hash): Update.
5894         (symbol_set_names): Update.
5895         * objfiles.h (struct objfile_per_bfd_storage)
5896         <demangled_names_hash>: Now an htab_up.
5897         * objfiles.c (objfile_per_bfd_storage): Simplify.
5898
5899 2019-03-15  Tom Tromey  <tom@tromey.com>
5900
5901         * objfiles.h (struct objfile_per_bfd_storage): Declare
5902         destructor.
5903         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5904         New.
5905         (get_objfile_bfd_data): Use new.  Don't initialize
5906         language_of_main.
5907         (free_objfile_per_bfd_storage): Remove.
5908         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5909
5910 2019-03-15  Tom Tromey  <tom@tromey.com>
5911
5912         * symfile.c (reread_symbols): Update.
5913         * objfiles.c (objfile::objfile): Update.
5914         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5915         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5916         comment.
5917         (minimal_symbol_reader::install): Update.
5918         (terminate_minimal_symbol_table): Remove.
5919         * jit.c (jit_object_close_impl): Update.
5920
5921 2019-03-15  Tom Tromey  <tom@tromey.com>
5922
5923         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5924         initializations.
5925
5926 2019-03-15  Tom Tromey  <tom@tromey.com>
5927
5928         * objfiles.h (struct objfile_per_bfd_storage)
5929         <demangled_hash_languages>: Now a bitset.
5930         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5931         (lookup_minimal_symbol): Update.
5932
5933 2019-03-15  Tom Tromey  <tom@tromey.com>
5934
5935         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5936         Don't return the symbol.
5937         * coffread.c (record_minimal_symbol): Use record_full.
5938
5939 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5940
5941         The MS-Windows port of ncurses fails to switch to a color pair if
5942         one or both of the colors are the implicit default colors.  This
5943         change records the default colors when TUI is initialized, and
5944         then specifies them explicitly when a color pair uses the default
5945         colors.  This allows color styling in TUI mode on MS-Windows.
5946
5947         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5948         ncurses_norm_attr.
5949         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5950         colors in ncurses_norm_attr.
5951         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5952         "none", replace it with the default color recorded in
5953         ncurses_norm_attr.
5954
5955 2019-03-14  Tom Tromey  <tromey@adacore.com>
5956
5957         * source-cache.h (class source_cache) <get_source_lines>: Return
5958         std::string.
5959         * source-cache.c (source_cache::extract_lines): Handle case where
5960         first_pos==npos.  Return std::string.
5961         (source_cache::get_source_lines): Update.
5962
5963 2019-03-14  Tom Tromey  <tromey@adacore.com>
5964
5965         * NEWS: Add item for "style sources" commands.
5966         * source-cache.c (source_cache::get_source_lines): Check
5967         source_styling.
5968         * cli/cli-style.c (source_styling): New global.
5969         (_initialize_cli_style): Add "style sources" commands.
5970         (show_style_sources): New function.
5971         * cli/cli-style.h (source_styling): Declare.
5972
5973 2019-03-14  Pedro Alves  <palves@redhat.com>
5974             Tom Tromey  <tromey@adacore.com>
5975
5976         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5977         * tui/tui-winsource.c (tui_refill_source_window): New function,
5978         from...
5979         (tui_horizontal_source_scroll): ... here.  Move some logic.
5980         * cli/cli-style.c (set_style_enabled): Notify new observable.
5981         * tui/tui-hooks.c (tui_redisplay_source): New function.
5982         (tui_attach_detach_observers): Attach or detach
5983         tui_redisplay_source.
5984         * observable.h (source_styling_changed): New observable.
5985         * observable.c: Define source_styling_changed observable.
5986
5987 2019-03-13  Tom Tromey  <tromey@adacore.com>
5988
5989         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5990         (i386_gnu_nat_target::store_registers): Update.
5991         * target-debug.h (target_debug_print_std_string): New macro.
5992         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5993         * windows-tdep.c (display_one_tib): Update.
5994         * tui/tui-stack.c (tui_make_status_line): Update.
5995         * top.c (print_inferior_quit_action): Update.
5996         * thread.c (thr_try_catch_cmd): Update.
5997         (add_thread_with_info): Update.
5998         (thread_target_id_str): Update.
5999         (thr_try_catch_cmd): Update.
6000         (thread_command): Update.
6001         (thread_find_command): Update.
6002         * record-btrace.c (record_btrace_target::info_record)
6003         (record_btrace_resume_thread, record_btrace_target::resume)
6004         (record_btrace_cancel_resume, record_btrace_step_thread)
6005         (record_btrace_target::wait, record_btrace_target::wait)
6006         (record_btrace_target::wait, record_btrace_target::stop): Update.
6007         * progspace.c (print_program_space): Update.
6008         * process-stratum-target.c
6009         (process_stratum_target::thread_address_space): Update.
6010         * linux-fork.c (linux_fork_mourn_inferior)
6011         (detach_checkpoint_command, info_checkpoints_command)
6012         (linux_fork_context): Update.
6013         (linux_fork_detach): Update.
6014         (class scoped_switch_fork_info): Update.
6015         (delete_checkpoint_command): Update.
6016         * infrun.c (follow_fork_inferior): Update.
6017         (follow_fork_inferior): Update.
6018         (proceed_after_vfork_done): Update.
6019         (handle_vfork_child_exec_or_exit): Update.
6020         (follow_exec): Update.
6021         (displaced_step_prepare_throw): Update.
6022         (displaced_step_restore): Update.
6023         (start_step_over): Update.
6024         (resume_1): Update.
6025         (clear_proceed_status_thread): Update.
6026         (proceed): Update.
6027         (print_target_wait_results): Update.
6028         (do_target_wait): Update.
6029         (context_switch): Update.
6030         (stop_all_threads): Update.
6031         (restart_threads): Update.
6032         (finish_step_over): Update.
6033         (handle_signal_stop): Update.
6034         (switch_back_to_stepped_thread): Update.
6035         (keep_going_pass_signal): Update.
6036         (print_exited_reason): Update.
6037         (normal_stop): Update.
6038         * inferior.c (inferior_pid_to_str): Change return type.
6039         (print_selected_inferior): Update.
6040         (add_inferior): Update.
6041         (detach_inferior): Update.
6042         * dummy-frame.c (fprint_dummy_frames): Update.
6043         * dcache.c (dcache_info_1): Update.
6044         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6045         (btrace_fetch, btrace_clear): Update.
6046         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6047         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6048         type.
6049         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6050         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6051         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6052         * gdbarch.c, gdbarch.h: Rebuild.
6053         * gdbarch.sh (core_pid_to_str): Change return type.
6054         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6055         return type.
6056         (windows_nat_target::pid_to_str): Change return type.
6057         (windows_delete_thread): Update.
6058         (windows_nat_target::attach): Update.
6059         (windows_nat_target::files_info): Update.
6060         * target-delegates.c: Rebuild.
6061         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6062         return type.
6063         (sol_thread_target::pid_to_str): Change return type.
6064         * remote.c (class remote_target) <pid_to_str>: Change return
6065         type.
6066         (remote_target::pid_to_str): Change return type.
6067         (extended_remote_target::attach, remote_target::remote_stop_ns)
6068         (remote_target::remote_notif_remove_queued_reply)
6069         (remote_target::push_stop_reply, remote_target::disable_btrace):
6070         Update.
6071         (extended_remote_target::attach): Update.
6072         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6073         type.
6074         (gdbsim_target::pid_to_str): Change return type.
6075         * ravenscar-thread.c (struct ravenscar_thread_target)
6076         <pid_to_str>: Change return type.
6077         (ravenscar_thread_target::pid_to_str): Change return type.
6078         * procfs.c (class procfs_target) <pid_to_str>: Change return
6079         type.
6080         (procfs_target::pid_to_str): Change return type.
6081         (procfs_target::attach): Update.
6082         (procfs_target::detach): Update.
6083         (procfs_target::fetch_registers): Update.
6084         (procfs_target::store_registers): Update.
6085         (procfs_target::wait): Update.
6086         (procfs_target::files_info): Update.
6087         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6088         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6089         return type.
6090         (nto_procfs_target::pid_to_str): Change return type.
6091         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6092         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6093         return type.
6094         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6095         (exit_lwp): Update.
6096         (attach_proc_task_lwp_callback, get_detach_signal)
6097         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6098         (linux_nat_target::resume, wait_lwp, stop_callback)
6099         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6100         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6101         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6102         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6103         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6104         type.
6105         (inf_ptrace_target::attach): Update.
6106         (inf_ptrace_target::files_info): Update.
6107         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6108         type.
6109         (go32_nat_target::pid_to_str): Change return type.
6110         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6111         (gnu_nat_target::wait): Update.
6112         (gnu_nat_target::wait): Update.
6113         (gnu_nat_target::resume): Update.
6114         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6115         (fbsd_nat_target::wait): Update.
6116         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6117         type.
6118         (darwin_nat_target::attach): Update.
6119         * corelow.c (class core_target) <pid_to_str>: Change return type.
6120         (core_target::pid_to_str): Change return type.
6121         * target.c (normal_pid_to_str): Change return type.
6122         (default_pid_to_str): Likewise.
6123         (target_pid_to_str): Change return type.
6124         (target_translate_tls_address): Update.
6125         (target_announce_detach): Update.
6126         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6127         return type.
6128         (bsd_uthread_target::pid_to_str): Change return type.
6129         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6130         type.
6131         (bsd_kvm_target::pid_to_str): Change return type.
6132         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6133         return type.
6134         (aix_thread_target::pid_to_str): Change return type.
6135         * target.h (struct target_ops) <pid_to_str>: Change return type.
6136         (target_pid_to_str, normal_pid_to_str): Likewise.
6137         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6138         type.
6139         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6140         type.
6141         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6142         return type.
6143         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6144         type.
6145         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6146         type.
6147         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6148         return type.
6149
6150 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6151
6152         * NEWS: Mention that the new default MI version is 3.  Mention
6153         changes to the output of commands and events that deal with
6154         multi-location breakpoints.
6155         * breakpoint.c: Include "mi/mi-out.h".
6156         (print_one_breakpoint): Change output syntax if using MI version
6157         >= 3.
6158         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6159         New.
6160         (mi_multi_location_breakpoint_output_fixed): New.
6161         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6162         (mi_cmd_fix_multi_location_breakpoint_output): New.
6163         (mi_multi_location_breakpoint_output_fixed): New.
6164         * mi/mi-cmds.c (mi_cmds): Register command
6165         -fix-multi-location-breakpoint-output.
6166         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6167         interpreter "mi".
6168
6169 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6170
6171         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6172         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6173         instantiate mi_ui_out based on interpreter name.
6174         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6175         * mi/mi-main.c (mi_load_progress): Likewise.
6176
6177 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6178
6179         * NEWS: Combine separate "New targets" sections for 8.3.
6180
6181 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6182
6183         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6184         (ppcfbsd_init_abi): Install gdbarch
6185         "fetch_tls_load_module_address" and "get_thread_local_address"
6186         methods.
6187
6188 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6189
6190         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6191         (riscv_fbsd_init_abi): Install gdbarch
6192         "fetch_tls_load_module_address" and "get_thread_local_address"
6193         methods.
6194
6195 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6196
6197         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6198         (i386fbsd_init_abi): Install gdbarch
6199         "fetch_tls_load_module_address" and "get_thread_local_address"
6200         methods.
6201
6202 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6203
6204         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6205         (amd64fbsd_init_abi): Install gdbarch
6206         "fetch_tls_load_module_address" and "get_thread_local_address"
6207         methods.
6208
6209 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6210
6211         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6212         (struct fbsd_pspace_data): New type.
6213         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6214         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6215         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6216         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6217         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6218
6219 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6220
6221         * gdbtypes.c (lookup_struct_elt): New function.
6222         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6223         * gdbtypes.h (struct struct_elt): New type.
6224         (lookup_struct_elt): New prototype.
6225
6226 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6227
6228         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6229         remove disabled code block.
6230
6231 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6232
6233         * gdbarch.sh (get_thread_local_address): New method.
6234         * gdbarch.h, gdbarch.c: Regenerate.
6235         * target.c (target_translate_tls_address): Use
6236         gdbarch_get_thread_local_address if present instead of
6237         target::get_thread_local_address.
6238
6239 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6240
6241         * target.h (target::get_thread_local_address): Update comment.
6242
6243 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6244
6245         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6246         objfile->separate_debug_objfile_backlink if not NULL.
6247
6248 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6249
6250         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6251         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6252         (amd64bsd_store_inferior_registers): Likewise.
6253         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6254         Enable segment base registers.
6255         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6256         PT_GETFSBASE and PT_GETGSBASE.
6257         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6258         PT_SETGSBASE.
6259         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6260         segment base registers.
6261         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6262
6263 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6264
6265         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6266         Update calls to i386_target_description to add 'segments'
6267         parameter.
6268         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6269         add segment base registers.
6270         * arch/i386.c (i386_create_target_description): Add 'segments'
6271         parameter to enable segment base registers.
6272         * arch/i386.h (i386_create_target_description): Likewise.
6273         * features/i386/32bit-segments.xml: New file.
6274         * features/i386/32bit-segments.c: Generate.
6275         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6276         call to i386_target_description to add 'segments' parameter.
6277         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6278         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6279         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6280         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6281         if feature is present.
6282         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6283         Add 'segments' parameter to call to i386_target_description.
6284         (i386_target_description): Add 'segments' parameter to enable
6285         segment base registers.
6286         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6287         to call to i386_target_description.
6288         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6289         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6290         Define I386_NUM_REGS.
6291         (i386_target_description): Add 'segments' parameter to enable
6292         segment base registers.
6293
6294 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6295
6296         PR/24325
6297         * source-cache.c: #undef open and close, to avoid unresolved
6298         externals during linking.
6299
6300 2019-03-12  Tom Tromey  <tromey@adacore.com>
6301
6302         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6303         const.  Add initializers.
6304         (_initialize_remote): Don't initialize ptid globals.
6305
6306 2019-03-12  Pedro Alves  <palves@redhat.com>
6307
6308         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6309
6310 2019-03-12  Pedro Alves  <palves@redhat.com>
6311
6312         * cp-name-parser.y (main): Remove unused 'len' variable.
6313
6314 2019-03-12  Tom Tromey  <tromey@adacore.com>
6315
6316         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6317         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6318
6319 2019-03-12  Tom Tromey  <tromey@adacore.com>
6320
6321         * linux-nat.c (iterate_over_lwps): Update.
6322         (stop_callback): Remove parameter.
6323         (stop_wait_callback, detach_callback, resume_set_callback)
6324         (select_singlestep_lwp_callback, set_ignore_sigint)
6325         (status_callback, resumed_callback, resume_clear_callback)
6326         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6327         data parameter.
6328         (linux_nat_target::detach, linux_nat_target::resume)
6329         (linux_stop_and_wait_all_lwps, select_event_lwp)
6330         (linux_nat_filter_event, linux_nat_wait_1)
6331         (linux_nat_target::kill, linux_nat_target::stop)
6332         (linux_nat_target::stop): Update.
6333         (linux_nat_resume_callback): Change type.
6334         (resume_stopped_resumed_lwps, count_events_callback)
6335         (select_event_lwp_callback): Likewise.
6336         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6337         * arm-linux-nat.c (struct update_registers_data): Remove.
6338         (update_registers_callback): Change type.
6339         (arm_linux_insert_hw_breakpoint1): Update.
6340         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6341         parameter.
6342         (x86_linux_dr_set_addr): Update.
6343         (x86_linux_dr_set_control): Update.
6344         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6345         (iterate_over_lwps): Use gdb::function_view.
6346         * nat/aarch64-linux-hw-point.c (struct
6347         aarch64_dr_update_callback_param): Remove.
6348         (debug_reg_change_callback): Change type.
6349         (aarch64_notify_debug_reg_change): Update.
6350         * s390-linux-nat.c (s390_refresh_per_info): Update.
6351
6352 2019-03-11  Tom Tromey  <tromey@adacore.com>
6353
6354         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6355         redundant assignment to "this_cu".
6356
6357 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6358
6359         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6360
6361 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6362
6363         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6364         from...
6365         (rank_one_type): ... this.
6366
6367 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6368
6369         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6370         from...
6371         (rank_one_type): ... this.
6372
6373 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6374
6375         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6376         from...
6377         (rank_one_type): ... this.
6378
6379 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6380
6381         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6382         from...
6383         (rank_one_type): ... this.
6384
6385 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6386
6387         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6388         from...
6389         (rank_one_type): ... this.
6390
6391 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6392
6393         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6394         from...
6395         (rank_one_type): ... this.
6396
6397 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6398
6399         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6400         from...
6401         (rank_one_type): ... this.
6402
6403 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6404
6405         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6406         from...
6407         (rank_one_type): ... this.
6408
6409 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6410
6411         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6412         from...
6413         (rank_one_type): ... this.
6414
6415 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6416
6417         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6418         from...
6419         (rank_one_type): ... this.
6420
6421 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6422
6423         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6424         from...
6425         (rank_one_type): ... this.
6426
6427 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6428
6429         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6430         from...
6431         (rank_one_type): ... this.
6432
6433 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6434
6435         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6436         inferior-events' shows the example events.
6437
6438 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6439
6440         Support styling on native MS-Windows console
6441
6442         PR/24315
6443         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6444         on MS-Windows if $TERM is not defined.
6445
6446         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6447
6448         * posix-hdep.c (gdb_console_fputs):
6449         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6450         functions.
6451         * ui-file.h (gdb_console_fputs): Add prototype.
6452
6453         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6454         back to fputs only if the former returns zero.
6455
6456 2019-03-07  Tom Tromey  <tom@tromey.com>
6457
6458         * symmisc.c (print_symbol_bcache_statistics): Update.
6459         (print_objfile_statistics): Update.
6460         * symfile.c (allocate_symtab): Update.
6461         * stabsread.c: Don't include bcache.h.
6462         * psymtab.h (struct psymbol_bcache): Don't declare.
6463         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6464         (psymbol_bcache_init, psymbol_bcache_free)
6465         (psymbol_bcache_get_bcache): Don't declare.
6466         * psymtab.c (struct psymbol_bcache): Remove.
6467         (psymtab_storage::psymtab_storage): Update.
6468         (psymtab_storage::~psymtab_storage): Update.
6469         (psymbol_bcache_init, psymbol_bcache_free)
6470         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6471         (add_psymbol_to_bcache): Update.
6472         (allocate_psymtab): Update.
6473         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6474         macro_cache>: No longer pointers.
6475         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6476         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6477         * macrotab.c (macro_bcache): Update.
6478         * macroexp.c: Don't include bcache.h.
6479         * gdbtypes.c (check_types_worklist): Update.
6480         (types_deeply_equal): Remove TRY/CATCH.  Update.
6481         * elfread.c (elf_symtab_read): Update.
6482         * dwarf2read.c: Don't include bcache.h.
6483         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6484         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6485         (print_bcache_statistics, bcache_memory_used): Don't declare.
6486         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6487         methods.  Rename all data members.
6488         * bcache.c (struct bcache): Move to bcache.h.
6489         (bcache::expand_hash_table): Rename from expand_hash_table.
6490         (bcache): Remove.
6491         (bcache::insert): Rename from bcache_full.
6492         (bcache::compare): Rename from bcache_compare.
6493         (bcache_xmalloc): Remove.
6494         (bcache::~bcache): Rename from bcache_xfree.
6495         (bcache::print_statistics): Rename from print_bcache_statistics.
6496         (bcache::memory_used): Rename from bcache_memory_used.
6497
6498 2019-03-07  Pedro Alves  <palves@redhat.com>
6499
6500         * infrun.c (normal_stop): Also check for
6501         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6502
6503 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6504
6505         * f-lang.c (value_from_host_double): Moved to...
6506         * value.c (value_from_host_double): ...here.
6507         * value.h (value_from_host_double): Declare.
6508         * guile/scm-math.c (vlscm_convert_typed_number): Use
6509         value_from_host_double.
6510         (vlscm_convert_number): Likewise.
6511         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6512         * python/py-value.c (convert_value_from_python): Likewise.
6513
6514 2019-03-06  Tom Tromey  <tom@tromey.com>
6515
6516         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6517
6518 2019-03-06  Tom Tromey  <tom@tromey.com>
6519
6520         * utils.h (free_current_contents): Don't declare.
6521         * utils.c (free_current_contents): Remove.
6522
6523 2019-03-06  Tom Tromey  <tom@tromey.com>
6524
6525         * top.c (quit_force): Update.
6526         * main.c (captured_command_loop): Update.
6527         * common/new-op.c (operator new): Update.
6528         * common/common-exceptions.c (struct catcher)
6529         <save_cleanup_chain>: Remove member.
6530         (exceptions_state_mc_init): Update.
6531         (exception_try_scope_entry): Return nullptr.
6532         (exception_try_scope_exit, exception_rethrow)
6533         (throw_exception_sjlj, throw_exception_cxx): Update.
6534         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6535         (all_cleanups, do_cleanups, discard_cleanups)
6536         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6537         (restore_cleanups, restore_final_cleanups): Don't declare.
6538         (do_final_cleanups): Remove parameter.
6539         * common/cleanups.c (cleanup_chain, make_cleanup)
6540         (make_cleanup_dtor, all_cleanups, do_cleanups)
6541         (discard_my_cleanups, discard_cleanups)
6542         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6543         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6544         (null_cleanup): Remove.
6545         (do_final_cleanups): Remove parameter.
6546
6547 2019-03-06  Tom Tromey  <tom@tromey.com>
6548
6549         * remote.c (remote_target::remote_parse_stop_reply): Use
6550         unique_xmalloc_ptr.
6551
6552 2019-03-06  Tom Tromey  <tom@tromey.com>
6553
6554         * stabsread.c (struct stabs_field_info): Rename from field_info.
6555         <list, fnlist>: Add initializers.
6556         <obstack>: New member.
6557         (read_member_functions, read_struct_fields, read_baseclasses):
6558         Allocate on obstack.  Don't use cleanups.
6559         (read_one_struct_field, read_member_functions, read_struct_fields)
6560         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6561         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6562         (read_struct_type): Update.
6563
6564 2019-03-06  Tom Tromey  <tom@tromey.com>
6565
6566         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6567         * common/filestuff.h (make_cleanup_close): Don't declare.
6568         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6569         Remove.
6570
6571 2019-03-06  Tom Tromey  <tom@tromey.com>
6572
6573         * solib-aix.c: Use make_scope_exit.
6574
6575 2019-03-06  Tom Tromey  <tom@tromey.com>
6576
6577         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6578         Use make_scope_exit.
6579
6580 2019-03-06  Tom Tromey  <tom@tromey.com>
6581
6582         * solib-svr4.c (disable_probes_interface): Remove parameter.
6583         (svr4_handle_solib_event): Use make_scope_exit.
6584
6585 2019-03-06  Tom Tromey  <tom@tromey.com>
6586
6587         * remote.c (struct stop_reply_deleter): Remove.
6588         (stop_reply_up): Update.
6589         (struct stop_reply): Derive from notif_event.  Don't typedef.
6590         <regcache>: Now a std::vector.
6591         (stop_reply_xfree): Remove.
6592         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6593         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6594         (remote_target::discard_pending_stop_replies): Use delete.
6595         (remote_target::remote_parse_stop_reply): Update.
6596         (remote_target::process_stop_reply): Update.
6597         * remote-notif.h (struct notif_event): Add virtual destructor.
6598         Remove "dtr" member.
6599         (struct notif_client) <alloc_event>: Return a unique_ptr.
6600         (notif_event_xfree): Don't declare.
6601         (notif_event_up): New typedef.
6602         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6603         (notif_event_xfree, do_notif_event_xfree): Remove.
6604         (remote_notif_state_xfree): Update.
6605
6606 2019-03-06  Tom Tromey  <tom@tromey.com>
6607
6608         * infrun.c (displaced_step_clear_cleanup): Now a
6609         forward_scope_exit type.
6610         (displaced_step_prepare_throw): Update.
6611         (displaced_step_fixup): Update.
6612
6613 2019-03-06  Tom Tromey  <tom@tromey.com>
6614
6615         * inferior.h (class inferior): Update comment.
6616         * gdbthread.h (class thread_info): Update comment.
6617
6618 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6619             Tom Tromey  <tom@tromey.com>
6620
6621         * stabsread.h (struct stab_section_list): Remove.
6622         (coffstab_build_psymtabs): Update.
6623         * dbxread.c (symbuf_sections): Now a std::vector.
6624         (sect_idx): New global.
6625         (fill_symbuf): Update.
6626         (coffstab_build_psymtabs): Change type of stabsects parameter.
6627         Update.
6628         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6629         std::vector.
6630         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6631         (coff_locate_sections): Update.
6632         (coff_symfile_read): Remove cleanups.  Update.
6633         (init_stringtab): Add storage parameter.
6634         (free_stringtab, free_stringtab_cleanup): Remove.
6635         (init_lineno): Add storage parameter.
6636         (free_linetab, free_linetab_cleanup): Remove.
6637
6638 2019-03-06  Pedro Alves  <palves@redhat.com>
6639
6640         * linux-fork.c (fork_info::clobber_regs): Delete.
6641         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6642         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6643         comment.  Adjust.
6644         (scoped_switch_fork_info::scoped_switch_fork_info)
6645         (checkpoint_command, linux_fork_context): Adjust
6646         fork_save_infrun_state calls.
6647
6648 2019-03-06  Pedro Alves  <palves@redhat.com>
6649
6650         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6651         (inf_has_multiple_threads): Return 'bool' and rewrite using
6652         inferior_info::threads().
6653
6654 2019-03-06  Pedro Alves  <palves@redhat.com>
6655
6656         * linux-fork.c: Include <list>.
6657         (fork_list): Now a std::list instance.
6658         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6659         (forks_exist_p, find_last_fork): Adjust.
6660         (new_fork): Delete.
6661         (one_fork_p): New.
6662         (add_fork): Adjust.
6663         (free_fork): Delete, folded into fork_info::~fork_info().
6664         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6665         Adjust.
6666         (init_fork_list): Delete.
6667         (linux_fork_killall, linux_fork_mourn_inferior)
6668         (linux_fork_detach, info_checkpoints_command): Adjust.
6669         (_initialize_linux_fork): No longer call init_fork_list.
6670
6671 2019-03-06  Pedro Alves  <palves@redhat.com>
6672
6673         * linux-fork.c (new_fork): New, split out of ...
6674         (add_fork): ... this.  Return void.  Move "first fork" special
6675         case from here, to ...
6676         (checkpoint_command): ... here.
6677         * linux-linux.h (add_fork): Return void.
6678
6679 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6680
6681         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6682
6683 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6684             Chris January  <chris.january@arm.com>
6685             David Lecomber  <david.lecomber@arm.com>
6686
6687         * f-exp.y: New token, UNOP_INTRINSIC.
6688         (exp): New pattern using UNOP_INTRINSIC token.
6689         (f77_keywords): Add 'abs' keyword.
6690         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6691         (value_from_host_double): New function.
6692         (evaluate_subexp_f): Support UNOP_ABS.
6693
6694 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6695
6696         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6697         types.
6698
6699 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6700
6701         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6702         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6703         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6704
6705 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6706
6707         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6708
6709 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6710             Chris January  <chris.january@arm.com>
6711
6712         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6713         * f-exp.y: Define 'KIND' token.
6714         (exp): New pattern for KIND expressions.
6715         (ptype): Handle types with a kind extension.
6716         (direct_abs_decl): Extend to spot kind extensions.
6717         (f77_keywords): Add 'kind' to the list.
6718         (push_kind_type): New function.
6719         (convert_to_kind_type): New function.
6720         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6721         * parse.c (operator_length_standard): Likewise.
6722         * parser-defs.h (enum type_pieces): Add tp_kind.
6723         * std-operator.def: Add UNOP_KIND.
6724
6725 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6726
6727         * f-exp.y (f_parse): Set yydebug.
6728
6729 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6730
6731         * f-lang.c (evaluate_subexp_f): New function.
6732         (exp_descriptor_f): New global.
6733         (f_language_defn): Use exp_descriptor_f instead of
6734         exp_descriptor_standard.
6735
6736 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6737
6738         * f-exp.y (struct token): Add comments.
6739         (dot_ops): Remove uppercase versions and the end marker.
6740         (f77_keywords): Likewise.
6741         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6742         entries in the dot_ops array are case insensitive, and use
6743         strncasecmp to compare strings.  Also some whitespace cleanup in
6744         this area.  Similar for the f77_keywords array, except entries in
6745         this list might be case sensitive.
6746
6747 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6748
6749         * f-exp.y (struct f77_boolean_val): Add comments.
6750         (boolean_values): Remove uppercase versions, and end marker.
6751         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6752         and use strncasecmp to achieve case insensitivity.  Additionally,
6753         perform whitespace cleanup around this code.
6754
6755 2019-03-06  Tom Tromey  <tromey@adacore.com>
6756
6757         * remote-sim.c (gdbsim_target_open): Use result of
6758         gdb_argv::release.
6759
6760 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6761         Dirk Schubert  <dirk.schubert@arm.com>
6762         Chris January  <chris.january@arm.com>
6763
6764         * eval.c (evaluate_subexp_standard): Call Fortran argument
6765         wrapping logic.
6766         * f-lang.c (struct value): A value which can be passed into a
6767         Fortran function call.
6768         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6769         where appropriate.
6770         (struct type): Value ready for a Fortran function call.
6771         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6772         is needed.
6773         * f-lang.h (fortran_argument_convert): Declaration.
6774         (fortran_preserve_arg_pointer): Declaration.
6775         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6776
6777 2019-03-05  Tom Tromey  <tromey@adacore.com>
6778
6779         * python/py-prettyprint.c (print_string_repr): Remove #if.
6780         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6781
6782 2019-03-05  Tom Tromey  <tromey@adacore.com>
6783
6784         * target.c (the_dummy_target): Move later.  Change type to
6785         "dummy_target".
6786         (initialize_targets): Don't initialize the_dummy_target.
6787
6788 2019-03-05  Tom Tromey  <tromey@adacore.com>
6789
6790         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6791         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6792
6793 2019-03-05  Tom Tromey  <tromey@adacore.com>
6794
6795         * windows-nat.c (windows_nat_target::attach)
6796         (windows_nat_target::detach): Don't call gdb_flush.
6797         * valprint.c (generic_val_print, val_print, val_print_string):
6798         Don't call gdb_flush.
6799         * utils.c (defaulted_query): Don't call gdb_flush.
6800         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6801         * target.c (target_announce_detach): Don't call gdb_flush.
6802         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6803         * remote.c (extended_remote_target::attach): Don't call
6804         gdb_flush.
6805         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6806         * printcmd.c (do_examine): Don't call gdb_flush.
6807         (info_display_command): Don't call gdb_flush.
6808         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6809         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6810         * memattr.c (info_mem_command): Don't call gdb_flush.
6811         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6812         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6813         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6814         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6815         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6816         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6817         (gnu_nat_target::detach): Don't call gdb_flush.
6818         * f-valprint.c (f_val_print): Don't call gdb_flush.
6819         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6820         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6821         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6822         gdb_flush.
6823         * c-valprint.c (c_val_print): Don't call gdb_flush.
6824         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6825
6826 2019-03-05  Tom Tromey  <tromey@adacore.com>
6827
6828         * varobj.c (update_dynamic_varobj_children): Update.
6829         (install_default_visualizer): Use reset, not release.
6830         * value.c (set_internalvar): Update.
6831         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6832         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6833         ATTRIBUTE_UNUSED_RESULT.
6834
6835 2019-03-05  Tom Tromey  <tromey@adacore.com>
6836
6837         * remote.c (class scoped_remote_fd) <release>: Add
6838         ATTRIBUTE_UNUSED_RESULT.
6839
6840 2019-03-05  Tom Tromey  <tromey@adacore.com>
6841
6842         * macroexp.c (struct macro_buffer) <release>: Add
6843         ATTRIBUTE_UNUSED_RESULT.
6844
6845 2019-03-05  Tom Tromey  <tromey@adacore.com>
6846
6847         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6848         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6849         ATTRIBUTE_UNUSED_RESULT.
6850
6851 2019-03-05  Tom Tromey  <tromey@adacore.com>
6852
6853         * common/scoped_fd.h (class scoped_fd) <release>: Add
6854         ATTRIBUTE_UNUSED_RESULT.
6855
6856 2019-03-05  Tom Tromey  <tromey@adacore.com>
6857
6858         * parser-defs.h (struct parser_state) <release>: Add
6859         ATTRIBUTE_UNUSED_RESULT.
6860
6861 2019-03-05  Tom Tromey  <tromey@adacore.com>
6862
6863         * utils.h (class gdb_argv) <release>: Add
6864         ATTRIBUTE_UNUSED_RESULT.
6865         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6866
6867 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6868
6869         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6870         for-loop range, to avoid compiler warnings.
6871
6872         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6873         avoid compiler warnings about unused variables.
6874
6875         * NEWS: Mention end of support for native debugging on MS-Windows
6876         before XP.
6877
6878         PR gdb/24292
6879         * common/netstuff.c:
6880         * gdbserver/gdbreplay.c
6881         * gdbserver/remote-utils.c:
6882         * ser-tcp.c:
6883         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6884         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6885         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6886         'getaddrinfo' and 'freeaddrinfo' were not available before
6887         Windows XP, and mingw.org's MinGW headers by default define
6888         _WIN32_WINNT to 0x500.
6889
6890 2019-03-01  Gary Benson <gbenson@redhat.com>
6891
6892         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6893
6894 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6895             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6896
6897         PR gdb/8527
6898         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6899         set_sigint_trap, clear_sigint_trap.
6900
6901 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6902
6903         * target.c (target_detach): Clear the regcache and the
6904         frame cache.
6905
6906 2019-02-27  Pedro Alves  <palves@redhat.com>
6907
6908         * utils.c (set_screen_size): When we cap the height/width sizes,
6909         tweak the corresponding command variable to show "unlimited":
6910
6911 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6912             Pedro Alves  <palves@redhat.com>
6913
6914         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6915         before calling rl_set_screen_size.
6916
6917 2019-02-27  Tom Tromey  <tromey@adacore.com>
6918
6919         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6920         define.
6921         * python/py-value.c: Remove Python 2.4 workaround.
6922         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6923         workaround.
6924         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6925         Python 2.4 workaround.
6926         * python/python-internal.h: Remove Python 2.4 comment.
6927         (Py_ssize_t): Don't define.
6928         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6929         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6930         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6931         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6932         * python/python.c (do_start_initialization): Remove Python 2.4
6933         workaround.
6934         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6935         (print_children): Remove Python 2.4 workaround.
6936         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6937         workaround.
6938         (CHARBUFFERPROC_NAME): Remove.
6939         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6940         Python 2.4 workaround.
6941
6942 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6943
6944         * NEWS: Note minimum Python version.
6945
6946 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6947
6948         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6949         code from these functions.  Remove corresponding ifdefs.  Use
6950         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6951         Remove gotos and target of gotos.
6952         (infpy_search_memory): Likewise.
6953
6954 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6955
6956         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6957         (hppa_gdbarch_init): Don't register deleted functions with
6958         gdbarch.
6959
6960 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6961
6962         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6963         (h8300_unwind_sp): Delete.
6964         (h8300_dummy_id): Delete.
6965         (h8300_gdbarch_init): Don't register deleted functions with
6966         gdbarch.
6967
6968 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6969
6970         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6971         (ft32_unwind_pc): Delete.
6972         (ft32_unwind_sp): Delete.
6973         (ft32_gdbarch_init): Don't register deleted functions with
6974         gdbarch.
6975
6976 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6977
6978         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6979         (frv_unwind_pc): Delete.
6980         (frv_unwind_sp): Delete.
6981         (frv_gdbarch_init): Don't register deleted functions with
6982         gdbarch.
6983
6984 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6985
6986         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6987         (riscv_unwind_pc): Delete.
6988         (riscv_unwind_sp): Delete.
6989         (riscv_gdbarch_init): Don't register deleted functions with
6990         gdbarch.
6991
6992 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6993
6994         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6995         (csky_unwind_pc): Delete.
6996         (csky_unwind_sp): Delete.
6997         (csky_gdbarch_init): Don't register deleted functions with
6998         gdbarch.
6999
7000 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7001
7002         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7003         (cris_unwind_pc): Delete.
7004         (cris_unwind_sp): Delete.
7005         (cris_gdbarch_init): Don't register deleted functions with
7006         gdbarch.
7007
7008 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7009
7010         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7011         (bfin_unwind_pc): Delete.
7012         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7013
7014 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7015
7016         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7017         (arm_unwind_pc): Delete.
7018         (arm_unwind_sp): Delete.
7019         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7020
7021 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7022
7023         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7024         (arc_unwind_pc): Delete.
7025         (arc_unwind_sp): Delete.
7026         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7027
7028 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7029
7030         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7031         (alpha_unwind_pc): Delete.
7032         (alpha_gdbarch_init): Don't register deleted functions with
7033         gdbarch.
7034
7035 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7036
7037         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7038         (aarch64_unwind_pc): Delete.
7039         (aarch64_unwind_sp): Delete.
7040         (aarch64_gdbarch_init): Don't register deleted functions with
7041         gdbarch.
7042
7043 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7044
7045         * gdbtypes.c (type_align): Don't consider static members when
7046         computing structure alignment.
7047
7048 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7049
7050         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7051         return 0 for other types.
7052         * arch-utils.c (default_type_align): Always return 0.
7053         * gdbarch.h: Regenerate.
7054         * gdbarch.sh (type_align): Extend comment.
7055         * gdbtypes.c (type_align): Add additional comments, always call
7056         gdbarch_type_align before applying the default rules.
7057         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7058         generic code will then apply a suitable default.
7059         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7060         types, return 0 for other types.
7061
7062 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7063
7064         * NEWS: Create a new section for the next release branch.
7065         Rename the section of the current branch, now that it has
7066         been cut.
7067
7068 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7069
7070         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7071         * version.in: Bump version to 8.3.50.DATE-git.
7072
7073 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7074
7075         * aix-thread.c (ptid_cmp): Remove unused variable.
7076         (get_signaled_thread): Likewise.
7077         (store_regs_user_thread): Likewise.
7078         (store_regs_kernel_thread): Likewise.
7079         (fetch_regs_kernel_thread): Remove shadowed variable.
7080
7081 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7082
7083         * features/riscv/32bit-cpu.xml: Add register numbers.
7084         * features/riscv/32bit-fpu.c: Regenerate.
7085         * features/riscv/32bit-fpu.xml: Add register numbers.
7086         * features/riscv/64bit-cpu.xml: Add register numbers.
7087         * features/riscv/64bit-fpu.c: Regenerate.
7088         * features/riscv/64bit-fpu.xml: Add register numbers.
7089
7090 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7091
7092         * NEWS: Mention two argument form of gdb.Value constructor.
7093         * python/py-value.c (convert_buffer_and_type_to_value): New
7094         function.
7095         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7096         Add support for handling an optional second argument.  Call
7097         convert_buffer_and_type_to_value as appropriate.
7098         * python/python-internal.h (Py_buffer_deleter): New struct.
7099         (Py_buffer_up): New typedef.
7100
7101 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7102
7103         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7104         instead of releasing ownership.
7105
7106 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7107
7108         * dwarf2read.c (open_and_init_dwp_file): Call
7109         elf_numsections instead of bfd_count_sections to initialize
7110         dwp_file->num_sections.
7111
7112 2019-02-25  Tom Tromey  <tromey@adacore.com>
7113
7114         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7115
7116 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7117
7118         * gcore.in: Add '--readnever' option when invoking GDB.
7119
7120 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7121
7122         * MAINTAINERS: Update my email address.
7123
7124 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7125
7126         * build-id.c (build_id_to_debug_bfd_1): New function.
7127         (build_id_to_debug_bfd): Look for separate debug file in
7128         sysroot.
7129
7130 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7131
7132         * gdbarch.sh: Update the copyright year range that is placed into
7133         generated files.
7134
7135 2019-02-22  Keith Seitz  <keiths@redhat.com>
7136
7137         PR symtab/23853
7138         * linespec.c (create_sals_line_offset): Search for the default
7139         symtab's filename instead of its fullname.
7140
7141 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7142
7143         * NEWS: Update style defaults.
7144
7145 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7146
7147         * main.c (captured_main_1): Disable styling in batch mode.
7148
7149 2019-02-20  Tom Tromey  <tom@tromey.com>
7150
7151         * symtab.c (symtab_symbol_info): Fix typos.
7152
7153 2019-02-20  Tom Tromey  <tromey@adacore.com>
7154
7155         * findcmd.c (_initialize_mem_search): Use upper case for
7156         metasyntactic variables.
7157
7158 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7159
7160         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7161         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7162
7163 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7164
7165         * top.h (source_file_name): Change to std::string.
7166         * top.c (source_file_name): Likewise.
7167         (command_line_input): Adjust.
7168         * cli/cli-script.c (script_from_file): Adjust.
7169
7170 2019-02-19  Tom Tromey  <tromey@adacore.com>
7171
7172         * ravenscar-thread.c
7173         (ravenscar_thread_target::update_thread_list): Don't call
7174         ada_build_task_list.
7175         * ada-lang.h (ada_build_task_list): Don't declare.
7176         * ada-tasks.c (struct ada_tasks_inferior_data)
7177         <task_list_valid_p>: Now bool.
7178         (read_known_tasks, ada_task_list_changed)
7179         (ada_tasks_invalidate_inferior_data): Update.
7180         (read_known_tasks_array): Return bool.
7181         (read_known_tasks_list): Likewise.
7182         (read_known_tasks): Return void.
7183         (ada_build_task_list): Now static.
7184
7185 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7186
7187         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7188         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7189
7190 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7191
7192         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7193         variant for ada_tasks_pspace_data_handle and
7194         ada_tasks_inferior_data_handle.
7195         (ada_tasks_pspace_data_cleanup): New function.
7196         (ada_tasks_inferior_data_cleanup): New function.
7197
7198 2019-02-17  Tom Tromey  <tom@tromey.com>
7199
7200         * macrotab.h (macro_source_fullname): Return a std::string.
7201         * macrotab.c (macro_include, check_for_redefinition)
7202         (macro_undef, macro_lookup_definition, foreach_macro)
7203         (foreach_macro_in_scope): Update.
7204         (macro_source_fullname): Return a std::string.
7205         * macrocmd.c (show_pp_source_pos): Update.
7206
7207 2019-02-17  Tom Tromey  <tom@tromey.com>
7208
7209         * macrocmd.c (show_pp_source_pos): Style the file names.
7210
7211 2019-02-17  Tom Tromey  <tom@tromey.com>
7212
7213         PR tui/24197:
7214         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7215
7216 2019-02-17  Tom Tromey  <tom@tromey.com>
7217
7218         * ada-lang.c (user_select_syms): Use filtered printing.
7219         * utils.c (wrap_style): New global.
7220         (desired_style): Remove.
7221         (emit_style_escape): Add stream parameter.
7222         (set_output_style, reset_terminal_style, prompt_for_continue):
7223         Update.
7224         (flush_wrap_buffer): Only flush gdb_stdout.
7225         (wrap_here): Set wrap_style.
7226         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7227         treat escape sequences as a character.  Change when wrap buffer is
7228         flushed.
7229         (fputs_styled): Do not set the output style when the default is
7230         requested.
7231         * ui-style.h (struct ui_file_style) <is_default>: New method.
7232         * source.c (print_source_lines_base): Emit escape sequences in one
7233         piece.
7234
7235 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7236
7237         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7238         integers and enumeration types.
7239
7240 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7241
7242         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7243         instead of lookup_symbol_in_language
7244         (do_exact_match): New function.
7245         (ada_get_symbol_name_matcher): Return do_exact_match when
7246         doing a verbatim match.
7247
7248 2019-02-15  Tom Tromey  <tromey@adacore.com>
7249
7250         * ravenscar-thread.c (ravenscar_thread_target::resume)
7251         (ravenscar_thread_target::wait): Special case wildcard requests.
7252
7253 2019-02-15  Tom Tromey  <tromey@adacore.com>
7254
7255         * ravenscar-thread.c (base_ptid): Remove.
7256         (struct ravenscar_thread_target) <close>: New method.
7257         <m_base_ptid>: New member.
7258         <update_inferior_ptid, active_task, task_is_currently_active,
7259         runtime_initialized>: Declare methods.
7260         <ravenscar_thread_target>: Add constructor.
7261         (ravenscar_thread_target::task_is_currently_active)
7262         (ravenscar_thread_target::update_inferior_ptid)
7263         (ravenscar_runtime_initialized): Rename.  Now methods.
7264         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7265         (ravenscar_thread_target::update_thread_list): Update.
7266         (ravenscar_thread_target::active_task): Now method.
7267         (ravenscar_thread_target::store_registers)
7268         (ravenscar_thread_target::prepare_to_store)
7269         (ravenscar_thread_target::prepare_to_store)
7270         (ravenscar_thread_target::mourn_inferior): Update.
7271         (ravenscar_inferior_created): Use "new" to create target.
7272         (ravenscar_thread_target::get_ada_task_ptid): Update.
7273         (_initialize_ravenscar): Don't initialize base_ptid.
7274         (ravenscar_ops): Remove global.
7275
7276 2019-02-15  Tom Tromey  <tromey@adacore.com>
7277
7278         * target.h (push_target): Declare new overload.
7279         * target.c (push_target): New overload, taking an rvalue reference.
7280         * remote.c (remote_target::open_1): Use push_target overload.
7281         * corelow.c (core_target_open): Use push_target overload.
7282
7283 2019-02-15  Tom Tromey  <tromey@adacore.com>
7284
7285         * ravenscar-thread.c (is_ravenscar_task)
7286         (ravenscar_task_is_currently_active): Return bool.
7287         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7288         (_initialize_ravenscar): Remove "(void)".
7289         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7290         Return bool.
7291
7292 2019-02-15  Tom Tromey  <tromey@adacore.com>
7293
7294         * ravenscar-thread.c (ravenscar_runtime_initializer)
7295         (has_ravenscar_runtime, get_running_thread_id)
7296         (ravenscar_thread_target::resume): Fix indentation.
7297
7298 2019-02-15  Tom Tromey  <tromey@adacore.com>
7299
7300         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7301         from ravenscar_arch_ops.
7302         (sparc_ravenscar_ops::fetch_registers)
7303         (sparc_ravenscar_ops::store_registers): Now methods.
7304         (sparc_ravenscar_prepare_to_store): Remove.
7305         (sparc_ravenscar_ops): Redefine.
7306         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7307         methods and destructor.  Remove members.
7308         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7309         (ravenscar_thread_target::store_registers)
7310         (ravenscar_thread_target::prepare_to_store): Update.
7311         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7312         Remove.
7313         (struct ppc_ravenscar_powerpc_ops): Derive from
7314         ravenscar_arch_ops.
7315         (ppc_ravenscar_powerpc_ops::fetch_registers)
7316         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7317         (ppc_ravenscar_powerpc_ops): Redefine.
7318         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7319         (ppc_ravenscar_e500_ops::fetch_registers)
7320         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7321         (ppc_ravenscar_e500_ops): Redefine.
7322         * aarch64-ravenscar-thread.c
7323         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7324         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7325         (aarch64_ravenscar_fetch_registers)
7326         (aarch64_ravenscar_store_registers): Now methods.
7327         (aarch64_ravenscar_ops): Redefine.
7328
7329 2019-02-15  Tom Tromey  <tromey@adacore.com>
7330
7331         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7332         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7333         (ravenscar_thread_target::stopped_by_watchpoint)
7334         (ravenscar_thread_target::stopped_data_address)
7335         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7336
7337 2019-02-15  Tom Tromey  <tromey@adacore.com>
7338
7339         * ravenscar-thread.c: Fix some typos.
7340
7341 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7342             Tom Tromey  <tromey@adacore.com>
7343
7344         * ada-lang.c (ada_exception_sal): Change addr_string to a
7345         std::string.
7346         (create_ada_exception_catchpoint): Update.
7347
7348 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7349             Tom Tromey  <tromey@adacore.com>
7350
7351         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7352         (bp_location_ops): Remove.
7353         (base_breakpoint_allocate_location): Update.
7354         (free_bp_location): Update.
7355         * ada-lang.c (class ada_catchpoint_location)
7356         <ada_catchpoint_location>: Remove ops parameter.
7357         (ada_catchpoint_location_dtor): Remove.
7358         (ada_catchpoint_location_ops): Remove.
7359         (allocate_location_exception): Update.
7360         * breakpoint.h (struct bp_location_ops): Remove.
7361         (class bp_location) <bp_location>: Remove bp_location_ops
7362         parameter.
7363         <~bp_location>: Add destructor.
7364         <ops>: Remove.
7365
7366 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7367             Pedro Alves  <palves@redhat.com>
7368
7369         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7370         'PATH_MAX'.
7371
7372 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7373             Samuel Thibault  <samuel.thibault@gnu.org>
7374             Thomas Schwinge  <thomas@codesourcery.com>
7375
7376         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7377         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7378
7379 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7380
7381         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7382         (check_empty): Use "const char *".
7383
7384         * gnu-nat.c (gnu_nat_target::detach): Instead of
7385         'detach_inferior (pid)' call
7386         'detach_inferior (find_inferior_pid (pid))'.
7387
7388         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7389         'nat/fork-inferior.o'.
7390         * gnu-nat.c: #include "nat/fork-inferior.h".
7391
7392         * gnu-nat.c (gnu_nat_target::detach): Instead of
7393         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7394         * gnu-nat.h: #include "inf-child.h".
7395         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7396         'i386_gnu_nat_target::fetch_registers'.
7397         (gnu_store_registers): Rename/move to
7398         'i386_gnu_nat_target::store_registers'.
7399
7400         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7401         * gnu-nat.h (mach_thread_info): New function.
7402         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7403
7404         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7405
7406 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7407
7408         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7409
7410 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7411
7412         * windows-nat.c (windows_add_thread): Add new parameter
7413         "main_thread_p" with default value set to false.  Update
7414         function documentation as well as all callers.
7415         (windows_delete_thread): Likewise.
7416         (fake_create_process): Update call to windows_add_thread.
7417         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7418         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7419         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7420         call to windows_delete_thread.
7421
7422 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7423
7424         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7425
7426 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7427
7428         * symfile.c (find_separate_debug_file): Use canonical path of
7429         sysroot with child_path instead of gdb_sysroot if it is valid.
7430
7431 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7432
7433         * symfile.c (find_separate_debug_file): Use child_path to
7434         determine if an object file is under a sysroot.
7435
7436 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7437
7438         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7439         unittests/child-path-selftests.c.
7440         * common/pathstuff.c (child_path): New function.
7441         * common/pathstuff.h (child_path): New prototype.
7442         * unittests/child-path-selftests.c: New file.
7443
7444 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7445
7446         * symfile.c (find_separate_debug_file): Look for separate debug
7447         files in debug directories under the sysroot.
7448
7449 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7450
7451         * symtab.h (struct minimal_symbol data_p): New const method.
7452         (struct minimal_symbol text_p): Likewise.
7453         * symtab.c (output_source_filename): Use file name style
7454         to print file name.
7455         (print_symbol_info): Likewise.
7456         (print_msymbol_info): Use address style to print addresses.
7457         Use function name style to print executable text symbols.
7458         (expand_symtab_containing_pc): Use data_p.
7459         (find_pc_sect_compunit_symtab): Likewise.
7460
7461 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7462
7463         * breakpoint.c (describe_other_breakpoints): Use address style
7464         to print addresses.
7465         (say_where): Likewise.
7466
7467 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7468
7469         * ada-typeprint.c (print_func_type): Print function name
7470         style to print function name.
7471         * c-typeprint.c (c_print_type_1): Likewise.
7472
7473 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7474
7475         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7476         for execve.
7477
7478 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7479
7480         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7481         type_stack.
7482
7483 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7484
7485         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7486         TYPE_CODE_REF types.
7487
7488 2019-02-08  Jim Wilson  <jimw@sifive.com>
7489
7490         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7491         (riscv_linux_fregset): New.
7492         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7493
7494 2019-02-07  Tom Tromey  <tom@tromey.com>
7495
7496         * thread.c (thread_cancel_execution_command): Update.
7497         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7498         methods.
7499         (struct thread_fsm_ops): Remove.
7500         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7501         (thread_fsm_should_stop, thread_fsm_return_value)
7502         (thread_fsm_set_finished, thread_fsm_finished_p)
7503         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7504         Don't declare.
7505         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7506         * infrun.c (clear_proceed_status_thread)
7507         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7508         (print_stop_event): Update.
7509         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7510         Add constructor.
7511         (step_command_fsm_ops): Remove.
7512         (new_step_command_fsm): Remove.
7513         (step_1): Update.
7514         (step_command_fsm::should_stop): Rename from
7515         step_command_fsm_should_stop.
7516         (step_command_fsm::clean_up): Rename from
7517         step_command_fsm_clean_up.
7518         (step_command_fsm::do_async_reply_reason): Rename from
7519         step_command_fsm_async_reply_reason.
7520         (struct until_next_fsm): Inherit from thread_fsm.  Add
7521         constructor.
7522         (until_next_fsm_ops): Remove.
7523         (new_until_next_fsm): Remove.
7524         (until_next_fsm::should_stop): Rename from
7525         until_next_fsm_should_stop.
7526         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7527         (until_next_fsm::do_async_reply_reason): Rename from
7528         until_next_fsm_async_reply_reason.
7529         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7530         constructor.  Change type of breakpoint.
7531         (finish_command_fsm_ops): Remove.
7532         (new_finish_command_fsm): Remove.
7533         (finish_command_fsm::should_stop): Rename from
7534         finish_command_fsm_should_stop.
7535         (finish_command_fsm::clean_up): Rename from
7536         finish_command_fsm_clean_up.
7537         (finish_command_fsm::return_value): Rename from
7538         finish_command_fsm_return_value.
7539         (finish_command_fsm::do_async_reply_reason): Rename from
7540         finish_command_fsm_async_reply_reason.
7541         (finish_command): Update.
7542         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7543         Add constructor.
7544         (call_thread_fsm_ops): Remove.
7545         (call_thread_fsm::call_thread_fsm): Rename from
7546         new_call_thread_fsm.
7547         (call_thread_fsm::should_stop): Rename from
7548         call_thread_fsm_should_stop.
7549         (call_thread_fsm::should_notify_stop): Rename from
7550         call_thread_fsm_should_notify_stop.
7551         (run_inferior_call, call_function_by_hand_dummy): Update.
7552         * cli/cli-interp.c (should_print_stop_to_console): Update.
7553         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7554         Add constructor.  Change type of location_breakpoint,
7555         caller_breakpoint.
7556         (until_break_fsm_ops): Remove.
7557         (new_until_break_fsm): Remove.
7558         (until_break_fsm::should_stop): Rename from
7559         until_break_fsm_should_stop.
7560         (until_break_fsm::clean_up): Rename from
7561         until_break_fsm_clean_up.
7562         (until_break_fsm::do_async_reply_reason): Rename from
7563         until_break_fsm_async_reply_reason.
7564         (until_break_command): Update.
7565         * thread-fsm.c: Remove.
7566         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7567
7568 2019-02-07  Tom Tromey  <tom@tromey.com>
7569
7570         * yy-remap.h: Add include guard.
7571         * xtensa-tdep.h: Add include guard.
7572         * xcoffread.h: Rename include guard.
7573         * varobj-iter.h: Add include guard.
7574         * tui/tui.h: Rename include guard.
7575         * tui/tui-winsource.h: Rename include guard.
7576         * tui/tui-wingeneral.h: Rename include guard.
7577         * tui/tui-windata.h: Rename include guard.
7578         * tui/tui-win.h: Rename include guard.
7579         * tui/tui-stack.h: Rename include guard.
7580         * tui/tui-source.h: Rename include guard.
7581         * tui/tui-regs.h: Rename include guard.
7582         * tui/tui-out.h: Rename include guard.
7583         * tui/tui-layout.h: Rename include guard.
7584         * tui/tui-io.h: Rename include guard.
7585         * tui/tui-hooks.h: Rename include guard.
7586         * tui/tui-file.h: Rename include guard.
7587         * tui/tui-disasm.h: Rename include guard.
7588         * tui/tui-data.h: Rename include guard.
7589         * tui/tui-command.h: Rename include guard.
7590         * tic6x-tdep.h: Add include guard.
7591         * target/waitstatus.h: Rename include guard.
7592         * target/wait.h: Rename include guard.
7593         * target/target.h: Rename include guard.
7594         * target/resume.h: Rename include guard.
7595         * target-float.h: Rename include guard.
7596         * stabsread.h: Add include guard.
7597         * rs6000-tdep.h: Add include guard.
7598         * riscv-fbsd-tdep.h: Add include guard.
7599         * regformats/regdef.h: Rename include guard.
7600         * record.h: Rename include guard.
7601         * python/python.h: Rename include guard.
7602         * python/python-internal.h: Rename include guard.
7603         * python/py-stopevent.h: Rename include guard.
7604         * python/py-ref.h: Rename include guard.
7605         * python/py-record.h: Rename include guard.
7606         * python/py-record-full.h: Rename include guard.
7607         * python/py-record-btrace.h: Rename include guard.
7608         * python/py-instruction.h: Rename include guard.
7609         * python/py-events.h: Rename include guard.
7610         * python/py-event.h: Rename include guard.
7611         * procfs.h: Add include guard.
7612         * proc-utils.h: Add include guard.
7613         * p-lang.h: Add include guard.
7614         * or1k-tdep.h: Rename include guard.
7615         * observable.h: Rename include guard.
7616         * nto-tdep.h: Rename include guard.
7617         * nat/x86-linux.h: Rename include guard.
7618         * nat/x86-linux-dregs.h: Rename include guard.
7619         * nat/x86-gcc-cpuid.h: Add include guard.
7620         * nat/x86-dregs.h: Rename include guard.
7621         * nat/x86-cpuid.h: Rename include guard.
7622         * nat/ppc-linux.h: Rename include guard.
7623         * nat/mips-linux-watch.h: Rename include guard.
7624         * nat/linux-waitpid.h: Rename include guard.
7625         * nat/linux-ptrace.h: Rename include guard.
7626         * nat/linux-procfs.h: Rename include guard.
7627         * nat/linux-osdata.h: Rename include guard.
7628         * nat/linux-nat.h: Rename include guard.
7629         * nat/linux-namespaces.h: Rename include guard.
7630         * nat/linux-btrace.h: Rename include guard.
7631         * nat/glibc_thread_db.h: Rename include guard.
7632         * nat/gdb_thread_db.h: Rename include guard.
7633         * nat/gdb_ptrace.h: Rename include guard.
7634         * nat/fork-inferior.h: Rename include guard.
7635         * nat/amd64-linux-siginfo.h: Rename include guard.
7636         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7637         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7638         * nat/aarch64-linux.h: Rename include guard.
7639         * nat/aarch64-linux-hw-point.h: Rename include guard.
7640         * mn10300-tdep.h: Add include guard.
7641         * mips-linux-tdep.h: Add include guard.
7642         * mi/mi-parse.h: Rename include guard.
7643         * mi/mi-out.h: Rename include guard.
7644         * mi/mi-main.h: Rename include guard.
7645         * mi/mi-interp.h: Rename include guard.
7646         * mi/mi-getopt.h: Rename include guard.
7647         * mi/mi-console.h: Rename include guard.
7648         * mi/mi-common.h: Rename include guard.
7649         * mi/mi-cmds.h: Rename include guard.
7650         * mi/mi-cmd-break.h: Rename include guard.
7651         * m2-lang.h: Add include guard.
7652         * location.h: Rename include guard.
7653         * linux-record.h: Rename include guard.
7654         * linux-nat.h: Add include guard.
7655         * linux-fork.h: Add include guard.
7656         * i386-darwin-tdep.h: Rename include guard.
7657         * hppa-linux-offsets.h: Add include guard.
7658         * guile/guile.h: Rename include guard.
7659         * guile/guile-internal.h: Rename include guard.
7660         * gnu-nat.h: Rename include guard.
7661         * gdb-stabs.h: Rename include guard.
7662         * frv-tdep.h: Add include guard.
7663         * f-lang.h: Add include guard.
7664         * event-loop.h: Add include guard.
7665         * darwin-nat.h: Rename include guard.
7666         * cp-abi.h: Rename include guard.
7667         * config/sparc/nm-sol2.h: Rename include guard.
7668         * config/nm-nto.h: Rename include guard.
7669         * config/nm-linux.h: Add include guard.
7670         * config/i386/nm-i386gnu.h: Rename include guard.
7671         * config/djgpp/nl_types.h: Rename include guard.
7672         * config/djgpp/langinfo.h: Rename include guard.
7673         * compile/gcc-cp-plugin.h: Add include guard.
7674         * compile/gcc-c-plugin.h: Add include guard.
7675         * compile/compile.h: Rename include guard.
7676         * compile/compile-object-run.h: Rename include guard.
7677         * compile/compile-object-load.h: Rename include guard.
7678         * compile/compile-internal.h: Rename include guard.
7679         * compile/compile-cplus.h: Rename include guard.
7680         * compile/compile-c.h: Rename include guard.
7681         * common/xml-utils.h: Rename include guard.
7682         * common/x86-xstate.h: Rename include guard.
7683         * common/version.h: Rename include guard.
7684         * common/vec.h: Rename include guard.
7685         * common/tdesc.h: Rename include guard.
7686         * common/selftest.h: Rename include guard.
7687         * common/scoped_restore.h: Rename include guard.
7688         * common/scoped_mmap.h: Rename include guard.
7689         * common/scoped_fd.h: Rename include guard.
7690         * common/safe-iterator.h: Rename include guard.
7691         * common/run-time-clock.h: Rename include guard.
7692         * common/refcounted-object.h: Rename include guard.
7693         * common/queue.h: Rename include guard.
7694         * common/ptid.h: Rename include guard.
7695         * common/print-utils.h: Rename include guard.
7696         * common/preprocessor.h: Rename include guard.
7697         * common/pathstuff.h: Rename include guard.
7698         * common/observable.h: Rename include guard.
7699         * common/netstuff.h: Rename include guard.
7700         * common/job-control.h: Rename include guard.
7701         * common/host-defs.h: Rename include guard.
7702         * common/gdb_wait.h: Rename include guard.
7703         * common/gdb_vecs.h: Rename include guard.
7704         * common/gdb_unlinker.h: Rename include guard.
7705         * common/gdb_unique_ptr.h: Rename include guard.
7706         * common/gdb_tilde_expand.h: Rename include guard.
7707         * common/gdb_sys_time.h: Rename include guard.
7708         * common/gdb_string_view.h: Rename include guard.
7709         * common/gdb_splay_tree.h: Rename include guard.
7710         * common/gdb_setjmp.h: Rename include guard.
7711         * common/gdb_ref_ptr.h: Rename include guard.
7712         * common/gdb_optional.h: Rename include guard.
7713         * common/gdb_locale.h: Rename include guard.
7714         * common/gdb_assert.h: Rename include guard.
7715         * common/filtered-iterator.h: Rename include guard.
7716         * common/filestuff.h: Rename include guard.
7717         * common/fileio.h: Rename include guard.
7718         * common/environ.h: Rename include guard.
7719         * common/common-utils.h: Rename include guard.
7720         * common/common-types.h: Rename include guard.
7721         * common/common-regcache.h: Rename include guard.
7722         * common/common-inferior.h: Rename include guard.
7723         * common/common-gdbthread.h: Rename include guard.
7724         * common/common-exceptions.h: Rename include guard.
7725         * common/common-defs.h: Rename include guard.
7726         * common/common-debug.h: Rename include guard.
7727         * common/cleanups.h: Rename include guard.
7728         * common/buffer.h: Rename include guard.
7729         * common/btrace-common.h: Rename include guard.
7730         * common/break-common.h: Rename include guard.
7731         * cli/cli-utils.h: Rename include guard.
7732         * cli/cli-style.h: Rename include guard.
7733         * cli/cli-setshow.h: Rename include guard.
7734         * cli/cli-script.h: Rename include guard.
7735         * cli/cli-interp.h: Rename include guard.
7736         * cli/cli-decode.h: Rename include guard.
7737         * cli/cli-cmds.h: Rename include guard.
7738         * charset-list.h: Add include guard.
7739         * buildsym-legacy.h: Rename include guard.
7740         * bfin-tdep.h: Add include guard.
7741         * ax.h: Rename include guard.
7742         * arm-linux-tdep.h: Add include guard.
7743         * arm-fbsd-tdep.h: Add include guard.
7744         * arch/xtensa.h: Rename include guard.
7745         * arch/tic6x.h: Add include guard.
7746         * arch/i386.h: Add include guard.
7747         * arch/arm.h: Rename include guard.
7748         * arch/arm-linux.h: Rename include guard.
7749         * arch/arm-get-next-pcs.h: Rename include guard.
7750         * arch/amd64.h: Add include guard.
7751         * arch/aarch64-insn.h: Rename include guard.
7752         * arch-utils.h: Rename include guard.
7753         * annotate.h: Add include guard.
7754         * amd64-darwin-tdep.h: Rename include guard.
7755         * aarch64-linux-tdep.h: Add include guard.
7756         * aarch64-fbsd-tdep.h: Add include guard.
7757         * aarch32-linux-nat.h: Add include guard.
7758
7759 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7760
7761         * macrotab.c (macro_define_internal): New function that
7762         factorizes macro_define_object_internal and macro_define_function
7763         code.
7764         (macro_define_object_internal): Use macro_define_internal.
7765         (macro_define_function): Likewise.
7766
7767 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7768
7769         * macrocmd.c (extract_identifier): Return
7770         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7771         callers.
7772
7773 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7774
7775         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7776
7777 2019-02-05  Tom Tromey  <tom@tromey.com>
7778
7779         * target.c (target_stack::unpush): Move assertion earlier.
7780
7781 2019-01-30  Tom Tromey  <tom@tromey.com>
7782
7783         PR python/23615:
7784         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7785         (gdbpy_parse_and_eval): Likewise.
7786         * python/python-internal.h (gdbpy_allow_threads): New class.
7787
7788 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7789
7790         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7791         (aarch64_fbsd_fpregmap): Move earlier.
7792         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7793         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7794         instead of individual calls to trad_frame_set_reg_addr.
7795         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7796         earlier.
7797         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7798         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7799         instead of individual calls to trad_frame_set_reg_addr.
7800
7801 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7802
7803         * CONTRIBUTE: Replace contribution list with wiki link.
7804
7805 2019-01-25  Tom Tromey  <tom@tromey.com>
7806
7807         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7808
7809 2019-01-25  Tom Tromey  <tom@tromey.com>
7810
7811         * xtensa-linux-nat.c: Fix common/ includes.
7812         * xml-support.h: Fix common/ includes.
7813         * xml-support.c: Fix common/ includes.
7814         * x86-linux-nat.c: Fix common/ includes.
7815         * windows-nat.c: Fix common/ includes.
7816         * varobj.h: Fix common/ includes.
7817         * varobj.c: Fix common/ includes.
7818         * value.c: Fix common/ includes.
7819         * valops.c: Fix common/ includes.
7820         * utils.c: Fix common/ includes.
7821         * unittests/xml-utils-selftests.c: Fix common/ includes.
7822         * unittests/utils-selftests.c: Fix common/ includes.
7823         * unittests/unpack-selftests.c: Fix common/ includes.
7824         * unittests/tracepoint-selftests.c: Fix common/ includes.
7825         * unittests/style-selftests.c: Fix common/ includes.
7826         * unittests/string_view-selftests.c: Fix common/ includes.
7827         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7828         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7829         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7830         * unittests/rsp-low-selftests.c: Fix common/ includes.
7831         * unittests/parse-connection-spec-selftests.c: Fix common/
7832         includes.
7833         * unittests/optional-selftests.c: Fix common/ includes.
7834         * unittests/offset-type-selftests.c: Fix common/ includes.
7835         * unittests/observable-selftests.c: Fix common/ includes.
7836         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7837         * unittests/memrange-selftests.c: Fix common/ includes.
7838         * unittests/memory-map-selftests.c: Fix common/ includes.
7839         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7840         * unittests/function-view-selftests.c: Fix common/ includes.
7841         * unittests/environ-selftests.c: Fix common/ includes.
7842         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7843         * unittests/common-utils-selftests.c: Fix common/ includes.
7844         * unittests/cli-utils-selftests.c: Fix common/ includes.
7845         * unittests/array-view-selftests.c: Fix common/ includes.
7846         * ui-file.c: Fix common/ includes.
7847         * tui/tui-io.c: Fix common/ includes.
7848         * tracepoint.h: Fix common/ includes.
7849         * tracepoint.c: Fix common/ includes.
7850         * tracefile-tfile.c: Fix common/ includes.
7851         * top.h: Fix common/ includes.
7852         * top.c: Fix common/ includes.
7853         * thread.c: Fix common/ includes.
7854         * target/waitstatus.h: Fix common/ includes.
7855         * target/waitstatus.c: Fix common/ includes.
7856         * target.h: Fix common/ includes.
7857         * target.c: Fix common/ includes.
7858         * target-memory.c: Fix common/ includes.
7859         * target-descriptions.c: Fix common/ includes.
7860         * symtab.h: Fix common/ includes.
7861         * symfile.c: Fix common/ includes.
7862         * stap-probe.c: Fix common/ includes.
7863         * spu-linux-nat.c: Fix common/ includes.
7864         * sparc-nat.c: Fix common/ includes.
7865         * source.c: Fix common/ includes.
7866         * solib.c: Fix common/ includes.
7867         * solib-target.c: Fix common/ includes.
7868         * ser-unix.c: Fix common/ includes.
7869         * ser-tcp.c: Fix common/ includes.
7870         * ser-pipe.c: Fix common/ includes.
7871         * ser-base.c: Fix common/ includes.
7872         * selftest-arch.c: Fix common/ includes.
7873         * s12z-tdep.c: Fix common/ includes.
7874         * rust-exp.y: Fix common/ includes.
7875         * rs6000-aix-tdep.c: Fix common/ includes.
7876         * riscv-tdep.c: Fix common/ includes.
7877         * remote.c: Fix common/ includes.
7878         * remote-notif.h: Fix common/ includes.
7879         * remote-fileio.h: Fix common/ includes.
7880         * remote-fileio.c: Fix common/ includes.
7881         * regcache.h: Fix common/ includes.
7882         * regcache.c: Fix common/ includes.
7883         * record-btrace.c: Fix common/ includes.
7884         * python/python.c: Fix common/ includes.
7885         * python/py-type.c: Fix common/ includes.
7886         * python/py-inferior.c: Fix common/ includes.
7887         * progspace.h: Fix common/ includes.
7888         * producer.c: Fix common/ includes.
7889         * procfs.c: Fix common/ includes.
7890         * proc-api.c: Fix common/ includes.
7891         * printcmd.c: Fix common/ includes.
7892         * ppc-linux-nat.c: Fix common/ includes.
7893         * parser-defs.h: Fix common/ includes.
7894         * osdata.c: Fix common/ includes.
7895         * obsd-nat.c: Fix common/ includes.
7896         * nat/x86-linux.c: Fix common/ includes.
7897         * nat/x86-linux-dregs.c: Fix common/ includes.
7898         * nat/x86-dregs.h: Fix common/ includes.
7899         * nat/x86-dregs.c: Fix common/ includes.
7900         * nat/ppc-linux.c: Fix common/ includes.
7901         * nat/mips-linux-watch.h: Fix common/ includes.
7902         * nat/mips-linux-watch.c: Fix common/ includes.
7903         * nat/linux-waitpid.c: Fix common/ includes.
7904         * nat/linux-ptrace.h: Fix common/ includes.
7905         * nat/linux-ptrace.c: Fix common/ includes.
7906         * nat/linux-procfs.c: Fix common/ includes.
7907         * nat/linux-personality.c: Fix common/ includes.
7908         * nat/linux-osdata.c: Fix common/ includes.
7909         * nat/linux-namespaces.c: Fix common/ includes.
7910         * nat/linux-btrace.h: Fix common/ includes.
7911         * nat/linux-btrace.c: Fix common/ includes.
7912         * nat/fork-inferior.c: Fix common/ includes.
7913         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7914         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7915         * nat/aarch64-linux.c: Fix common/ includes.
7916         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7917         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7918         * namespace.h: Fix common/ includes.
7919         * mips-linux-tdep.c: Fix common/ includes.
7920         * minsyms.c: Fix common/ includes.
7921         * mi/mi-parse.h: Fix common/ includes.
7922         * mi/mi-main.c: Fix common/ includes.
7923         * mi/mi-cmd-env.c: Fix common/ includes.
7924         * memrange.h: Fix common/ includes.
7925         * memattr.c: Fix common/ includes.
7926         * maint.h: Fix common/ includes.
7927         * maint.c: Fix common/ includes.
7928         * main.c: Fix common/ includes.
7929         * machoread.c: Fix common/ includes.
7930         * location.c: Fix common/ includes.
7931         * linux-thread-db.c: Fix common/ includes.
7932         * linux-nat.c: Fix common/ includes.
7933         * linux-fork.c: Fix common/ includes.
7934         * inline-frame.c: Fix common/ includes.
7935         * infrun.c: Fix common/ includes.
7936         * inflow.c: Fix common/ includes.
7937         * inferior.h: Fix common/ includes.
7938         * inferior.c: Fix common/ includes.
7939         * infcmd.c: Fix common/ includes.
7940         * inf-ptrace.c: Fix common/ includes.
7941         * inf-child.c: Fix common/ includes.
7942         * ia64-linux-nat.c: Fix common/ includes.
7943         * i387-tdep.c: Fix common/ includes.
7944         * i386-tdep.c: Fix common/ includes.
7945         * i386-linux-tdep.c: Fix common/ includes.
7946         * i386-linux-nat.c: Fix common/ includes.
7947         * i386-go32-tdep.c: Fix common/ includes.
7948         * i386-fbsd-tdep.c: Fix common/ includes.
7949         * i386-fbsd-nat.c: Fix common/ includes.
7950         * guile/scm-type.c: Fix common/ includes.
7951         * guile/guile.c: Fix common/ includes.
7952         * go32-nat.c: Fix common/ includes.
7953         * gnu-nat.c: Fix common/ includes.
7954         * gdbthread.h: Fix common/ includes.
7955         * gdbarch-selftests.c: Fix common/ includes.
7956         * gdb_usleep.c: Fix common/ includes.
7957         * gdb_select.h: Fix common/ includes.
7958         * gdb_bfd.c: Fix common/ includes.
7959         * gcore.c: Fix common/ includes.
7960         * fork-child.c: Fix common/ includes.
7961         * findvar.c: Fix common/ includes.
7962         * fbsd-nat.c: Fix common/ includes.
7963         * event-top.c: Fix common/ includes.
7964         * event-loop.c: Fix common/ includes.
7965         * dwarf2read.c: Fix common/ includes.
7966         * dwarf2loc.c: Fix common/ includes.
7967         * dwarf2-frame.c: Fix common/ includes.
7968         * dwarf-index-cache.c: Fix common/ includes.
7969         * dtrace-probe.c: Fix common/ includes.
7970         * disasm-selftests.c: Fix common/ includes.
7971         * defs.h: Fix common/ includes.
7972         * csky-tdep.c: Fix common/ includes.
7973         * cp-valprint.c: Fix common/ includes.
7974         * cp-support.h: Fix common/ includes.
7975         * cp-support.c: Fix common/ includes.
7976         * corelow.c: Fix common/ includes.
7977         * completer.h: Fix common/ includes.
7978         * completer.c: Fix common/ includes.
7979         * compile/compile.c: Fix common/ includes.
7980         * compile/compile-loc2c.c: Fix common/ includes.
7981         * compile/compile-cplus-types.c: Fix common/ includes.
7982         * compile/compile-cplus-symbols.c: Fix common/ includes.
7983         * command.h: Fix common/ includes.
7984         * cli/cli-dump.c: Fix common/ includes.
7985         * cli/cli-cmds.c: Fix common/ includes.
7986         * charset.c: Fix common/ includes.
7987         * build-id.c: Fix common/ includes.
7988         * btrace.h: Fix common/ includes.
7989         * btrace.c: Fix common/ includes.
7990         * breakpoint.h: Fix common/ includes.
7991         * breakpoint.c: Fix common/ includes.
7992         * ax.h:
7993         (enum agent_op): Fix common/ includes.
7994         * ax-general.c (struct aop_map): Fix common/ includes.
7995         * ax-gdb.c: Fix common/ includes.
7996         * auxv.c: Fix common/ includes.
7997         * auto-load.c: Fix common/ includes.
7998         * arm-tdep.c: Fix common/ includes.
7999         * arch/riscv.c: Fix common/ includes.
8000         * arch/ppc-linux-common.c: Fix common/ includes.
8001         * arch/i386.c: Fix common/ includes.
8002         * arch/arm.c: Fix common/ includes.
8003         * arch/arm-linux.c: Fix common/ includes.
8004         * arch/arm-get-next-pcs.c: Fix common/ includes.
8005         * arch/amd64.c: Fix common/ includes.
8006         * arch/aarch64.c: Fix common/ includes.
8007         * arch/aarch64-insn.c: Fix common/ includes.
8008         * arch-utils.c: Fix common/ includes.
8009         * amd64-windows-tdep.c: Fix common/ includes.
8010         * amd64-tdep.c: Fix common/ includes.
8011         * amd64-sol2-tdep.c: Fix common/ includes.
8012         * amd64-obsd-tdep.c: Fix common/ includes.
8013         * amd64-nbsd-tdep.c: Fix common/ includes.
8014         * amd64-linux-tdep.c: Fix common/ includes.
8015         * amd64-linux-nat.c: Fix common/ includes.
8016         * amd64-fbsd-tdep.c: Fix common/ includes.
8017         * amd64-fbsd-nat.c: Fix common/ includes.
8018         * amd64-dicos-tdep.c: Fix common/ includes.
8019         * amd64-darwin-tdep.c: Fix common/ includes.
8020         * agent.c: Fix common/ includes.
8021         * ada-lang.h: Fix common/ includes.
8022         * ada-lang.c: Fix common/ includes.
8023         * aarch64-tdep.c: Fix common/ includes.
8024
8025 2019-01-25  Tom Tromey  <tom@tromey.com>
8026
8027         * common/create-version.sh: Use common/version.h.
8028
8029 2019-01-24  Pedro Alves  <palves@redhat.com>
8030
8031         * infrun.c (signal_stop, signal_print, signal_program)
8032         (signal_catch, signal_pass): Now arrays instead of pointers.
8033         (update_signals_program_target, do_target_resume)
8034         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8035         * linux-nat.c (linux_nat_target::pass_signals)
8036         (linux_nat_target::create_inferior, linux_nat_target::attach):
8037         Adjust.
8038         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8039         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8040         * procfs.c (procfs_target::pass_signals): Adjust.
8041         * record-full.c (record_full_target::resume): Adjust.
8042         * remote.c (remote_target::pass_signals)
8043         (remote_target::program_signals): Adjust.
8044         * target-debug.h (target_debug_print_signals): Now takes a
8045         gdb::array_view as parameter.  Adjust.
8046         * target.h (target_ops) <pass_signals, program_signals>: Replace
8047         pointer and length parameters with gdb::array_view.
8048         (target_pass_signals, target_program_signals): Likewise.
8049         * target-delegates.c: Regenerate.
8050
8051 2019-01-24  Pedro Alves  <palves@redhat.com>
8052
8053         * common/forward-scope-exit.h
8054         (forward_scope_exit::forward_scope_exit): Pass arguments to
8055         m_bind_function directly, instead of creating a std::bind and
8056         copying that.
8057
8058 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8059
8060         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8061         for static members.
8062         (pass_in_v_vfp_candidate): Likewise.
8063
8064 2019-01-23  Tom Tromey  <tom@tromey.com>
8065             Pedro Alves  <palves@redhat.com>
8066
8067         * regcache.c (class regcache_invalidator): Remove.
8068         (regcache::raw_write): Use make_scope_exit.
8069
8070 2019-01-23  Tom Tromey  <tom@tromey.com>
8071
8072         * ui-out.h (class ui_out_emit_type): Update comment.
8073
8074 2019-01-23  Tom Tromey  <tom@tromey.com>
8075
8076         * infrun.c (fetch_inferior_event): Update comment.
8077
8078 2019-01-23  Tom Tromey  <tom@tromey.com>
8079             Pedro Alves  <palves@redhat.com>
8080
8081         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8082         parameter.
8083         (fetch_inferior_event): Use SCOPE_EXIT.
8084
8085
8086 2019-01-23  Tom Tromey  <tom@tromey.com>
8087             Pedro Alves  <palves@redhat.com>
8088
8089         * infrun.c (disable_thread_events): Delete.
8090         (stop_all_threads): Use SCOPE_EXIT.
8091
8092 2019-01-23  Tom Tromey  <tom@tromey.com>
8093             Pedro Alves  <palves@redhat.com>
8094
8095         * symfile.c: Include forward-scope-exit.h.
8096         (clear_symtab_users_cleanup): Replace forward declaration with
8097         a FORWARD_SCOPE_EXIT.
8098         (syms_from_objfile_1): Use the forward_scope_exit and
8099         gdb::optional instead of cleanup_function.
8100         (reread_symbols): Use the forward_scope_exit instead of
8101         cleanup_function.
8102         (clear_symtab_users_cleanup): Remove function.
8103
8104 2019-01-23  Tom Tromey  <tom@tromey.com>
8105             Pedro Alves  <palves@redhat.com>
8106
8107         * linux-nat.c: Include scope-exit.h.
8108         (cleanup_target_stop): Remove.
8109         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8110         SCOPE_EXIT.
8111
8112 2019-01-23  Tom Tromey  <tom@tromey.com>
8113             Pedro Alves  <palves@redhat.com>
8114
8115         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8116         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8117
8118 2019-01-23  Tom Tromey  <tom@tromey.com>
8119             Andrew Burgess  <andrew.burgess@embecosm.com>
8120             Pedro Alves  <palves@redhat.com>
8121
8122         * infrun.c (fetch_inferior_event): Use scope_exit.
8123         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8124         * top.c (execute_command): Use scope_exit.
8125         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8126         * utils.c (do_bpstat_clear_actions_cleanup)
8127         (make_bpstat_clear_actions_cleanup): Remove.
8128
8129 2019-01-23  Tom Tromey  <tom@tromey.com>
8130             Pedro Alves  <palves@redhat.com>
8131
8132         * infrun.c: Include "common/scope-exit.h"
8133         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8134         (wait_for_inferior): Use SCOPE_EXIT.
8135         (fetch_inferior_event): Use scope_exit.
8136
8137 2019-01-23  Tom Tromey  <tom@tromey.com>
8138             Pedro Alves  <palves@redhat.com>
8139
8140         * breakpoint.c (create_breakpoint): Remove cleanup.
8141
8142 2019-01-23  Tom Tromey  <tom@tromey.com>
8143             Andrew Burgess  <andrew.burgess@embecosm.com>
8144             Pedro Alves  <palves@redhat.com>
8145
8146 2019-01-23  Pedro Alves  <palves@redhat.com>
8147
8148         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8149
8150 2019-01-23  Pedro Alves  <palves@redhat.com>
8151             Andrew Burgess  <andrew.burgess@embecosm.com>
8152
8153         * gdbthread.h: Include "common/forward-scope-exit.h".
8154         (scoped_finish_thread_state): Redefine custom class in terms of
8155         forward_scope_exit.
8156
8157 2019-01-23  Pedro Alves  <palves@redhat.com>
8158             Andrew Burgess  <andrew.burgess@embecosm.com>
8159
8160         * common/forward-scope-exit.h: New file.
8161
8162 2019-01-23  Pedro Alves  <palves@redhat.com>
8163             Andrew Burgess  <andrew.burgess@embecosm.com>
8164             Tom Tromey  <tom@tromey.com>
8165
8166         * common/scope-exit.h: New file.
8167
8168 2019-01-23  Pedro Alves  <palves@redhat.com>
8169
8170         * common/preprocessor.h (ESC): Rename to ...
8171         (ESC_PARENS): ... this.
8172         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8173         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8174
8175 2019-01-23  Tom Tromey  <tom@tromey.com>
8176
8177         * language.h (class scoped_switch_to_sym_language_if_auto):
8178         Initialize m_lang in both cases.
8179
8180 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8181
8182         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8183         with XCNEW.
8184
8185 2019-01-22  Tom Tromey  <tom@tromey.com>
8186
8187         * corelow.c: Do not include sys/file.h.
8188
8189 2019-01-22  Tom Tromey  <tom@tromey.com>
8190
8191         * tui/tui-wingeneral.h: Include gdb_curses.h.
8192
8193 2019-01-22  Tom Tromey  <tom@tromey.com>
8194
8195         * source-cache.h (class source_cache) <get_source_lines,
8196         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8197
8198 2019-01-22  Tom Tromey  <tom@tromey.com>
8199
8200         * remote-fileio.h (struct remote_target): Declare.
8201
8202 2019-01-22  Tom Tromey  <tom@tromey.com>
8203
8204         * python/py-arch.c: Do not include py-ref.h.
8205         * python/py-bpevent.c: Do not include py-ref.h.
8206         * python/py-cmd.c: Do not include py-ref.h.
8207         * python/py-continueevent.c: Do not include py-ref.h.
8208         * python/py-event.h: Do not include py-ref.h.
8209         * python/py-evtregistry.c: Do not include py-ref.h.
8210         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8211         * python/py-frame.c: Do not include py-ref.h.
8212         * python/py-framefilter.c: Do not include py-ref.h.
8213         * python/py-function.c: Do not include py-ref.h.
8214         * python/py-infevents.c: Do not include py-ref.h.
8215         * python/py-linetable.c: Do not include py-ref.h.
8216         * python/py-objfile.c: Do not include py-ref.h.
8217         * python/py-param.c: Do not include py-ref.h.
8218         * python/py-prettyprint.c: Do not include py-ref.h.
8219         * python/py-progspace.c: Do not include py-ref.h.
8220         * python/py-symbol.c: Do not include py-ref.h.
8221         * python/py-symtab.c: Do not include py-ref.h.
8222         * python/py-type.c: Do not include py-ref.h.
8223         * python/py-unwind.c: Do not include py-ref.h.
8224         * python/py-utils.c: Do not include py-ref.h.
8225         * python/py-value.c: Do not include py-ref.h.
8226         * python/py-varobj.c: Do not include py-ref.h.
8227         * python/py-xmethods.c: Do not include py-ref.h.
8228         * python/python.c: Do not include py-ref.h.
8229         * varobj.c: Do not include py-ref.h.
8230
8231 2019-01-22  Tom Tromey  <tom@tromey.com>
8232
8233         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8234         keyword for bcache.
8235
8236 2019-01-22  Tom Tromey  <tom@tromey.com>
8237
8238         * compile/compile-cplus-types.c: Remove a comment by #include.
8239
8240 2019-01-22  Tom Tromey  <tom@tromey.com>
8241
8242         * compile/gcc-c-plugin.h: Include compile-internal.h.
8243
8244 2019-01-22  Tom Tromey  <tom@tromey.com>
8245
8246         * stabsread.c (EXTERN): Do not define.
8247         (symnum, next_symbol_text_func, processing_gcc_compilation)
8248         (within_function, global_sym_chain, global_stabs)
8249         (previous_stab_code, this_object_header_files)
8250         (n_this_object_header_files)
8251         (n_allocated_this_object_header_files): Define.
8252         * stabsread.h (EXTERN): Never define.  Use "extern".
8253
8254 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8255
8256         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8257         history_value.
8258
8259 2019-01-21  Tom Tromey  <tom@tromey.com>
8260
8261         * ui-out.c: Fix includes.
8262         * tui/tui-source.c: Fix includes.
8263         * target.c: Fix includes.
8264         * remote.c: Fix includes.
8265         * regcache.c: Fix includes.
8266         * python/py-block.c: Fix includes.
8267         * printcmd.c: Fix includes.
8268         * or1k-tdep.c: Fix includes.
8269         * mi/mi-main.c: Fix includes.
8270         * m32r-tdep.c: Fix includes.
8271         * csky-tdep.c: Fix includes.
8272         * compile/compile-cplus-types.c: Fix includes.
8273         * cli/cli-interp.c: Fix includes.
8274
8275 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8276
8277         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8278         for padding.
8279
8280 2019-01-16  Tom Tromey  <tom@tromey.com>
8281
8282         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8283         earlier.
8284         (struct objfile) <msymbols_range>: Move from top level.
8285         <msymbols>: New method.
8286         (class objfile_msymbols): Remove.
8287         * symtab.c (default_collect_symbol_completion_matches_break_on):
8288         Update.
8289         * symmisc.c (dump_msymbols): Update.
8290         * stabsread.c (scan_file_globals): Update.
8291         * objc-lang.c (info_selectors_command, info_classes_command)
8292         (find_methods): Update.
8293         * minsyms.c (find_solib_trampoline_target): Update.
8294         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8295         * coffread.c (coff_symfile_read): Update.
8296         * ada-lang.c (ada_lookup_simple_minsym)
8297         (ada_collect_symbol_completion_matches): Update.
8298
8299 2019-01-16  Tom Tromey  <tom@tromey.com>
8300
8301         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8302         type.  Remove no-argument constructor.
8303         <iterator::operator++>: Simplify.
8304         <begin>: Update.
8305         <end>: Use minimal_symbol_count.
8306
8307 2019-01-16  Tom Tromey  <tom@tromey.com>
8308
8309         * objfiles.h (struct objfile) <psymtabs>: New method.
8310         (class objfile_psymtabs): Remove.
8311         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8312         typedef.
8313         <range>: New method.
8314         (require_partial_symbols): Change return type.
8315         * psymtab.c (require_partial_symbols)
8316         (psym_expand_symtabs_matching): Update.
8317         * mdebugread.c (parse_partial_symbols): Update.
8318         * dbxread.c (dbx_end_psymtab): Update.
8319
8320 2019-01-15  Tom Tromey  <tom@tromey.com>
8321
8322         * symtab.c (lookup_objfile_from_block)
8323         (lookup_symbol_in_objfile_symtabs)
8324         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8325         (find_line_symtab, info_sources_command)
8326         (default_collect_symbol_completion_matches_break_on)
8327         (make_source_files_completion_list): Update.
8328         * symmisc.c (print_objfile_statistics, dump_objfile)
8329         (maintenance_print_symbols, maintenance_info_symtabs)
8330         (maintenance_check_symtabs, maintenance_info_line_tables):
8331         Update.
8332         * source.c (select_source_symtab)
8333         (forget_cached_source_info_for_objfile): Update.
8334         * objfiles.h (class objfile_compunits): Remove.
8335         (struct objfile) <compunits_range>: New typedef.
8336         (compunits): New method.
8337         * objfiles.c (objfile_relocate1): Update.
8338         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8339         * maint.c (count_symtabs_and_blocks): Update.
8340         * linespec.c (iterate_over_all_matching_symtabs): Update.
8341         * cp-support.c (add_symbol_overload_list_qualified): Update.
8342         * coffread.c (coff_symtab_read): Update.
8343         * ada-lang.c (add_nonlocal_symbols)
8344         (ada_collect_symbol_completion_matches)
8345         (ada_add_global_exceptions): Update.
8346
8347 2019-01-15  Tom Tromey  <tom@tromey.com>
8348
8349         * progspace.h (program_space) <objfiles_safe_range>: New
8350         typedef.
8351         <objfiles_safe>: New method.
8352         * objfiles.h (class all_objfiles_safe): Remove.
8353         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8354         * jit.c (jit_inferior_exit_hook): Update.
8355
8356 2019-01-17  Tom Tromey  <tom@tromey.com>
8357
8358         * progspace.h (program_space) <objfiles_range>: New typedef.
8359         <objfiles>: New method.
8360         <objfiles_head>: Rename from objfiles.
8361         (object_files): Update.
8362         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8363         * guile/scm-pretty-print.c
8364         (ppscm_find_pretty_printer_from_objfiles): Update.
8365         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8366         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8367         Update.
8368         * python/py-progspace.c (pspy_get_objfiles): Update.
8369         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8370         Update.
8371         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8372         (objfpy_lookup_objfile_by_build_id): Update.
8373         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8374         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8375         Update.
8376         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8377         (expand_symtab_containing_pc, lookup_objfile_from_block)
8378         (lookup_static_symbol, basic_lookup_transparent_type)
8379         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8380         (find_line_symtab, info_sources_command)
8381         (default_collect_symbol_completion_matches_break_on)
8382         (make_source_files_completion_list, find_main_name): Update.
8383         * symmisc.c (print_symbol_bcache_statistics)
8384         (print_objfile_statistics, maintenance_print_symbols)
8385         (maintenance_print_msymbols, maintenance_print_objfiles)
8386         (maintenance_info_symtabs, maintenance_check_symtabs)
8387         (maintenance_expand_symtabs, maintenance_info_line_tables):
8388         Update.
8389         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8390         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8391         (map_overlay_command, unmap_overlay_command)
8392         (simple_overlay_update, expand_symtabs_matching)
8393         (map_symbol_filenames): Update.
8394         * symfile-debug.c (set_debug_symfile): Update.
8395         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8396         Update.
8397         * source.c (select_source_symtab, forget_cached_source_info):
8398         Update.
8399         * solib.c (solib_read_symbols): Update.
8400         * solib-spu.c (append_ocl_sos): Update.
8401         * psymtab.c (maintenance_print_psymbols)
8402         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8403         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8404         * printcmd.c (info_symbol_command): Update.
8405         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8406         Update.
8407         * objfiles.h (class all_objfiles): Remove.
8408         * objfiles.c (have_partial_symbols, have_full_symbols)
8409         (have_minimal_symbols, qsort_cmp, update_section_map)
8410         (shared_objfile_contains_address_p)
8411         (default_iterate_over_objfiles_in_search_order): Update.
8412         * objc-lang.c (info_selectors_command, info_classes_command)
8413         (find_methods): Update.
8414         * minsyms.c (find_solib_trampoline_target): Update.
8415         * maint.c (maintenance_info_sections)
8416         (maintenance_translate_address, count_symtabs_and_blocks):
8417         Update.
8418         * main.c (captured_main_1): Update.
8419         * linux-thread-db.c (try_thread_db_load_from_pdir)
8420         (has_libpthread): Update.
8421         * linespec.c (iterate_over_all_matching_symtabs)
8422         (search_minsyms_for_name): Update.
8423         * jit.c (jit_find_objf_with_entry_addr): Update.
8424         * hppa-tdep.c (find_unwind_entry)
8425         (hppa_lookup_stub_minimal_symbol): Update.
8426         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8427         Update.
8428         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8429         (elf_gnu_ifunc_resolve_by_got): Update.
8430         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8431         * dwarf-index-write.c (save_gdb_index_command): Update.
8432         * cp-support.c (add_symbol_overload_list_qualified): Update.
8433         * breakpoint.c (create_overlay_event_breakpoint)
8434         (create_longjmp_master_breakpoint)
8435         (create_std_terminate_master_breakpoint)
8436         (create_exception_master_breakpoint): Update.
8437         * blockframe.c (find_pc_partial_function): Update.
8438         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8439         (ada_collect_symbol_completion_matches)
8440         (ada_add_global_exceptions): Update.
8441
8442 2019-01-17  Tom Tromey  <tom@tromey.com>
8443
8444         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8445         declare VEC.
8446         (solib_target_parse_libraries): Change return type.
8447         (library_list_start_segment, library_list_start_section)
8448         (library_list_end_library, library_list_start_library); Update.
8449         (solib_target_free_library_list): Remove.
8450         (solib_target_parse_libraries): Remove cleanup.  Change return
8451         type.
8452         (solib_target_current_sos): Update.
8453
8454 2019-01-17  Tom Tromey  <tromey@bapiya>
8455
8456         * valprint.c: Replace "the the" with "the".
8457         * symtab.c: Replace "the the" with "the".
8458         * solib.c: Replace "the the" with "the".
8459         * solib-dsbt.c: Replace "the the" with "the".
8460         * linespec.c: Replace "the the" with "the".
8461         * dwarf2loc.h: Replace "the the" with "the".
8462         * amd64-windows-tdep.c: Replace "the the" with "the".
8463         * aarch64-tdep.c: Replace "the the" with "the".
8464
8465 2019-01-16  Keith Seitz  <keiths@redhat.com>
8466
8467         PR gdb/23773
8468         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8469         <builder>: Rename to ..
8470         <m_builder>: ... this and make private.
8471         (dwarf2_cu::get_builder): New method.  Change all users of
8472         `builder' to use this method.
8473         (dwarf2_start_symtab): Move to ...
8474         (dwarf2_cu::start_symtab): ... here.  Update all callers
8475         (setup_type_unit_groups): Move to ...
8476         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8477         callers.
8478         (dwarf2_cu::reset_builder): New method.
8479         (process_full_compunit, process_full_type_unit): Use
8480         dwarf2_cu::reset_builder.
8481         (follow_die_offset): Record the ancestor CU if it is different
8482         from the followed DIE's CU.
8483         (follow_die_sig_1): Likewise.
8484
8485 2019-01-15  Tom Tromey  <tom@tromey.com>
8486
8487         * remote.c (class remote_state) <buf>: Now a char_vector.
8488         <buf_size>: Remove.
8489         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8490         parameter.
8491         (remote_target::getpkt_or_notif_sane_1)
8492         (remote_target::getpkt_sane)
8493         (remote_target::getpkt_or_notif_sane): Likewise.
8494         (class remote_target) <putpkt>: New overload.
8495         (remote_target::read_frame): Change type of "buf_p".  Remove
8496         sizeof_p parameter.
8497         (packet_ok): New overload.
8498         (packet_check_result): New overload.
8499         Update all uses.
8500
8501 2019-01-14  Tom Tromey  <tom@tromey.com>
8502
8503         * remote-notif.c (handle_notification, remote_notif_ack)
8504         (remote_notif_parse): Make "buf" const.
8505         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8506         const.
8507         (remote_notif_parse, remote_notif_ack, handle_notification):
8508         Likewise.
8509         * remote.c (remote_notif_stop_parse): Make "buf" const.
8510         (remote_target::remote_parse_stop_reply): Make "buf" const.
8511         (remote_notif_stop_ack): Make "buf" const.
8512
8513 2019-01-14  Tom Tromey  <tom@tromey.com>
8514
8515         * remote.c (remote_console_output): Make parameter const.
8516
8517 2019-01-14  Tom Tromey  <tom@tromey.com>
8518
8519         * target-debug.h (target_debug_print_signals): Constify.
8520         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8521         * procfs.c (procfs_target::pass_signals): Update.
8522         * linux-nat.c (linux_nat_target::pass_signals): Update.
8523         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8524         * target-delegates.c: Rebuild.
8525         * remote.c (remote_target::program_signals): Update.
8526         (remote_target::pass_signals): Update.
8527         * target.c (target_pass_signals): Constify argument.
8528         (target_program_signals): Likewise.
8529         * target.h (struct target_ops) <pass_signals, program_signals>:
8530         Constify argument.
8531         (target_pass_signals, target_program_signals): Constify argument.
8532
8533 2019-01-14  Tom Tromey  <tom@tromey.com>
8534
8535         PR tui/28819:
8536         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8537
8538 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8539
8540         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8541         field.
8542         * rs6000-tdep.c: Include reggroups.h.
8543         (IS_V_ALIAS_PSEUDOREG): Define.
8544         (rs6000_register_name): Return names for the "vX" aliases.
8545         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8546         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8547         aliases.  Call default_register_reggroup_p for all other
8548         pseudo-registers.
8549         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8550         New functions.
8551         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8552         Handle "vX" aliases.
8553         (v_alias_pseudo_register_collect): New function.
8554         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8555         (rs6000_gdbarch_init): Initialize "vX" aliases as
8556         pseudo-registers.  Restore registration of
8557         rs6000_pseudo_register_reggroup_p with
8558         set_tdesc_pseudo_register_reggroup_p.
8559
8560 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8561
8562         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8563         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8564         set_gdbarch_num_pseudo_regs.
8565
8566 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8567
8568         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8569         Remove arg prefixname, add do_set and do_show.
8570         Add member functions set_list and show_list.
8571         * cli/cli-style.c (class cli_style_option): Update accordingly.
8572         (style_set_list): Move to file scope.
8573         (style_show_list): Likewise.
8574         (set_style): Call help_list.
8575         (show_style): Call cmd_show_list.
8576         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8577         Update to use the new macro.
8578
8579 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8580
8581         * ada-lang.c (_initialize_ada_language): Expand the help text
8582         for the "catch exception" command.
8583
8584 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8585
8586         * symtab.c (matching_obj_sections): Initialize obj,
8587         declare it closer to its usage.
8588
8589 2019-01-10  Tom Tromey  <tom@tromey.com>
8590
8591         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8592         (basic_inf_threads_range): Remove.
8593         (inf_threads_range, inf_non_exited_threads_range)
8594         (safe_inf_threads_range): Use next_adapter.
8595
8596 2019-01-10  Keith Seitz  <keiths@redhat.com>
8597
8598         PR gdb/23712
8599         PR symtab/23010
8600         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8601         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8602
8603 2019-01-10  Keith Seitz  <keiths@redhat.com>
8604
8605         PR gdb/23712
8606         PR symtab/23010
8607         * dictionary.c (pending_to_vector): Remove.
8608         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8609         Remove _1 suffix, replacing functions of the same name.  Update
8610         all callers.
8611         (dict_create_hashed, dict_create_hashed_expandable)
8612         (dict_create_linear, dict_create_linear_expandable, dict_free)
8613         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8614         Make functions static.
8615
8616 2019-01-10  Keith Seitz  <keiths@redhat.com>
8617
8618         PR gdb/23712
8619         PR symtab/23010
8620         * dictionary.h (struct dictionary): Replace declaration with
8621         multidictionary.
8622         (dict_create_hashed, dict_create_hashed_expandable)
8623         (dict_create_linear, dict_create_linear_expandable)
8624         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8625         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8626         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8627         taking multidictionary argument.
8628         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8629         * block.h (struct block) <dict>: Change to multidictionary
8630         and rename `multidict'.
8631         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8632         symmisc.c: Update all dictionary references to multidictionary.
8633
8634 2019-01-10  Keith Seitz  <keiths@redhat.com>
8635
8636         PR gdb/23712
8637         PR symtab/23010
8638         * dictionary.c: Include unordered_map.
8639         (pending_to_vector): New function.
8640         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8641         Rewrite the non-"_1" functions to take vector instead
8642         of linked list.
8643         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8644         "new" _1 versions of the same name.
8645         (multidictionary): Define.
8646         (std::hash<enum language): New definition.
8647         (collate_pending_symbols_by_language, mdict_create_hashed)
8648         (mdict_create_hashed_expandable, mdict_create_linear)
8649         (mdict_create_linear_expandable, mdict_free)
8650         (find_language_dictionary, create_new_language_dictionary)
8651         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8652         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8653         (mdict_size, mdict_empty): New functions.
8654         * dictionary.h (mdict_iterator): Define.
8655
8656 2019-01-10  Pedro Alves  <palves@redhat.com>
8657
8658         * breakpoint.c (read_uploaded_action)
8659         (create_tracepoint_from_upload): Adjust to use
8660         gdb::unique_xmalloc_ptr.
8661         * ctf.c (ctf_write_uploaded_tp):
8662         (SET_ARRAY_FIELD): Use emplace_back.
8663         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8664         * tracefile-tfile.c (tfile_write_uploaded_tp):
8665         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8666         gdb::unique_xmalloc_ptr.
8667         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8668         at_string, cond_string, cmd_strings>: Replace char pointers
8669         with gdb::unique_xmalloc_ptr.
8670
8671 2019-01-10  Pedro Alves  <palves@redhat.com>
8672
8673         * solib-target.c (library_list_start_library): Don't xstrdup name.
8674
8675 2019-01-10  Pedro Alves  <palves@redhat.com>
8676
8677         * mdebugread.c (parse_partial_symbols): Use
8678         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8679
8680 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8681
8682         * linux-fork.c (scoped_switch_fork_info)
8683         <~scoped_switch_fork_info>: Fix incorrect variable name.
8684
8685 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8686
8687         * linux-fork.c (scoped_switch_fork_info)
8688         <scoped_switch_fork_info>: Make explicit.
8689         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8690
8691 2019-01-10  Tom Tromey  <tom@tromey.com>
8692
8693         * objfiles.h (objfile::reset_psymtabs): Update.
8694         * objfiles.c (objfile::objfile): Update.
8695         * psymtab.h (psymtab_storage::obstack): Update.
8696         (psymtab_storage::m_obstack): Use gdb::optional.
8697         (class psymtab_storage): Update comment.  Remove objfile
8698         parameter.
8699         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8700
8701 2019-01-10  Tom Tromey  <tom@tromey.com>
8702
8703         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8704         <free_psymtabs>: Now private.
8705         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8706         (allocate_psymtab): Use new method.
8707
8708 2019-01-10  Tom Tromey  <tom@tromey.com>
8709
8710         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8711         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8712         * mdebugread.c (parse_partial_symbols): Use
8713         allocate_dependencies.
8714         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8715         allocate_dependencies.
8716         (process_psymtab_comp_unit_reader)
8717         (build_type_psymtab_dependencies): Likewise.
8718         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8719
8720 2019-01-10  Tom Tromey  <tom@tromey.com>
8721
8722         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8723         PSYMBOL_SET_LANGUAGE.
8724         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8725
8726 2019-01-10  Tom Tromey  <tom@tromey.com>
8727
8728         * psymtab.h (psymtab_storage::obstack): New method.
8729         <m_obstack>: Rename from obstack; now private.
8730         * psymtab.c (psymtab_storage): Update.
8731         * dwarf2read.c (create_addrmap_from_index)
8732         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8733         Update.
8734
8735 2019-01-10  Tom Tromey  <tom@tromey.com>
8736
8737         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8738         * objfiles.h (objfile::reset_psymtabs): New method.
8739
8740 2019-01-10  Tom Tromey  <tom@tromey.com>
8741
8742         * symmisc.c (print_symbol_bcache_statistics): Update.
8743         (print_objfile_statistics): Update.
8744         * symfile.c (reread_symbols): Update.
8745         * psymtab.h (class psymtab_storage): New.
8746         * psymtab.c (psymtab_storage): New constructor.
8747         (~psymtab_storage): New destructor.
8748         (require_partial_symbols): Update.
8749         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8750         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8751         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8752         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8753         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8754         (start_psymtab_common, end_psymtab_common)
8755         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8756         (allocate_psymtab): Update.
8757         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8758         Update.
8759         (dump_psymtab_addrmap, maintenance_print_psymbols)
8760         (maintenance_check_psymtabs): Update.
8761         (class objfile_psymtabs): Move to objfiles.h.
8762         * psympriv.h (discard_psymtab): Now inline.
8763         (psymtab_discarder::psymtab_discarder): Update.
8764         (psymtab_discarder::~psymtab_discarder): Update.
8765         (ALL_OBJFILE_PSYMTABS): Rewrite.
8766         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8767         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8768         Remove fields.
8769         <partial_symtabs>: New field.
8770         (class objfile_psymtabs): Move from psymtab.h.  Update.
8771         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8772         psymbol_cache.
8773         (objfile::~objfile): Don't destroy psymbol_cache.
8774         * mdebugread.c (parse_partial_symbols): Update.
8775         * dwarf2read.c (create_addrmap_from_index)
8776         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8777         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8778         (add_partial_subprogram, dwarf2_ranges_read): Update.
8779         * dwarf-index-write.c (write_address_map)
8780         (write_one_signatured_type, recursively_write_psymbols)
8781         (class debug_names, class debug_names, write_psymtabs_to_index):
8782         Update.
8783
8784 2019-01-10  Tom Tromey  <tom@tromey.com>
8785
8786         * symtab.h (SYMBOL_SET_NAMES): Update.
8787         (symbol_set_names): Update.
8788         (MSYMBOL_SET_NAMES): Update.
8789         * symtab.c (symbol_set_names): Change argument to be an
8790         objfile_per_bfd_storage.
8791         * psymtab.c (add_psymbol_to_bcache): Update.
8792         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8793
8794 2019-01-10  Tom Tromey  <tom@tromey.com>
8795
8796         * symtab.c (create_demangled_names_hash): Change argument to be an
8797         objfile_per_bfd_storage.
8798         (symbol_set_names): Update.
8799
8800 2019-01-10  Tom Tromey  <tom@tromey.com>
8801
8802         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8803         init_psymbol_list.
8804         * psymtab.c (init_psymbol_list): Do nothing if already called.
8805         * psympriv.h (init_psymbol_list): Add comment.
8806         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8807         init_psymbol_list.
8808         * dbxread.c (dbx_symfile_read): Unconditionally call
8809         init_psymbol_list.
8810
8811 2019-01-10  Tom Tromey  <tom@tromey.com>
8812
8813         * xcoffread.c (scan_xcoff_symtab): Update.
8814         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8815         "where".
8816         * mdebugread.c (parse_partial_symbols)
8817         (handle_psymbol_enumerators): Update.
8818         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8819         * dbxread.c (read_dbx_symtab): Update.
8820         * psympriv.h (psymbol_placement): New enum.
8821         (add_psymbol_to_list): Update.
8822
8823 2019-01-10  Tom Tromey  <tom@tromey.com>
8824
8825         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8826         static_psymbols parameters.
8827         (scan_xcoff_symtab): Update.
8828         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8829         static_psymbols parameters.
8830         * psympriv.h (start_psymtab_common): Update.
8831         * mdebugread.c (parse_partial_symbols): Update.
8832         * dwarf2read.c (create_partial_symtab): Update.
8833         * dbxread.c (read_dbx_symtab): Update.
8834         (start_psymtab): Remove global_psymbols and static_psymbols
8835         parameters.
8836
8837 2019-01-10  Tom Tromey  <tom@tromey.com>
8838
8839         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8840         * psymtab.c (allocate_psymtab): Add comment.
8841         * psympriv.h (allocate_psymtab): Add comment.
8842         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8843         initializations.
8844         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8845
8846 2019-01-10  Tom Tromey  <tom@tromey.com>
8847
8848         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8849         Don't declare.
8850         * mipsread.c: Include mdebugread.h.
8851         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8852         Declare.
8853         * elfread.c: Include mdebugread.h.
8854
8855 2019-01-09  Tom Tromey  <tom@tromey.com>
8856
8857         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8858         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8859         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8860         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8861         (psym_lookup_symbol, psym_find_last_source_symtab)
8862         (psym_forget_cached_source_info, psym_print_stats)
8863         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8864         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8865         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8866         (psym_find_compunit_symtab_by_address)
8867         (maintenance_print_psymbols, maintenance_info_psymtabs)
8868         (maintenance_check_psymtabs): Use ranged for.
8869         * psymtab.h (class objfile_psymtabs): New.
8870         (require_partial_symbols): Return objfile_psymtabs.
8871         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8872
8873 2019-01-09  Tom Tromey  <tom@tromey.com>
8874
8875         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8876         (find_pc_mapped_section, list_overlays_command)
8877         (map_overlay_command, unmap_overlay_command)
8878         (simple_overlay_update): Use all_objfiles.
8879         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8880         * printcmd.c (info_symbol_command): Use all_objfiles.
8881         * objfiles.h (ALL_OBJSECTIONS): Remove.
8882         * maint.c (maintenance_translate_address): Use all_objfiles.
8883         * gcore.c (gcore_create_callback): Use all_objfiles.
8884         (objfile_find_memory_regions): Likewise.
8885
8886 2019-01-09  Tom Tromey  <tom@tromey.com>
8887
8888         * symtab.c (find_line_symtab, info_sources_command)
8889         (make_source_files_completion_list): Use objfile_compunits.
8890         * source.c (select_source_symtab): Use objfile_compunits.
8891         * objfiles.h (struct objfile): Update comment.
8892         (ALL_OBJFILES): Remove.
8893         (ALL_FILETABS): Remove.
8894         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8895         objfile_compunits.
8896
8897 2019-01-09  Tom Tromey  <tom@tromey.com>
8898
8899         * symmisc.c (print_objfile_statistics, dump_objfile)
8900         (maintenance_print_symbols): Use compunit_filetabs.
8901         * source.c (forget_cached_source_info_for_objfile): Use
8902         compunit_filetabs.
8903         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8904         (ALL_FILETABS): Use compunit_filetabs.
8905         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8906         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8907
8908 2019-01-09  Tom Tromey  <tom@tromey.com>
8909
8910         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8911         (compunit_filetabs): New.
8912         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8913         compunit_filetabs.
8914         (info_sources_command, make_source_files_completion_list): Remove
8915         declaration.
8916         * symmisc.c (print_objfile_statistics, dump_objfile)
8917         (maintenance_print_symbols): Remove declaration.
8918         (maintenance_info_symtabs): Use compunit_filetabs.
8919         (maintenance_info_line_tables): Likewise.
8920         * source.c (select_source_symtab): Change local variable name.
8921         (forget_cached_source_info_for_objfile): Remove declaration.
8922         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8923         * objfiles.c (objfile_relocate1): Remove declaration.
8924         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8925         declaration.
8926         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8927         * coffread.c (coff_symtab_read): Remove declaration.
8928         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8929         compunit_filetabs.
8930
8931 2019-01-09  Tom Tromey  <tom@tromey.com>
8932
8933         * symtab.c (lookup_objfile_from_block)
8934         (find_pc_sect_compunit_symtab, search_symbols)
8935         (default_collect_symbol_completion_matches_break_on): Use
8936         objfile_compunits.
8937         * objfiles.h (ALL_COMPUNITS): Remove.
8938         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8939         * cp-support.c (add_symbol_overload_list_qualified): Use
8940         objfile_compunits.
8941         * ada-lang.c (ada_collect_symbol_completion_matches)
8942         (ada_add_global_exceptions): Use objfile_compunits.
8943
8944 2019-01-09  Tom Tromey  <tom@tromey.com>
8945
8946         * source.c (select_source_symtab)
8947         (forget_cached_source_info_for_objfile): Remove declaration.
8948         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8949         declaration.
8950         * maint.c (count_symtabs_and_blocks): Remove declaration.
8951         * cp-support.c (add_symbol_overload_list_qualified): Remove
8952         declaration.
8953         * coffread.c (coff_symtab_read): Remove declaration.
8954         * symtab.c (lookup_symbol_in_objfile_symtabs)
8955         (basic_lookup_transparent_type_1): Use objfile_compunits.
8956         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8957         (info_sources_command, search_symbols)
8958         (default_collect_symbol_completion_matches_break_on)
8959         (make_source_files_completion_list): Remove declaration.
8960         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8961         (ada_collect_symbol_completion_matches)
8962         (ada_add_global_exceptions): Remove declaration.
8963         * linespec.c (iterate_over_all_matching_symtabs): Use
8964         objfile_compunits.
8965         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8966         (class objfile_compunits): New.
8967         (ALL_COMPUNITS): Use objfile_compunits.
8968         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8969         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8970         objfile_compunits.
8971         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8972
8973 2019-01-09  Tom Tromey  <tom@tromey.com>
8974
8975         * symtab.c (search_symbols)
8976         (default_collect_symbol_completion_matches_break_on): Use
8977         objfile_msymbols.
8978         * ada-lang.c (ada_lookup_simple_minsym)
8979         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8980         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8981         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8982         objfile_msymbols.
8983         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8984         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8985         * objc-lang.c (find_methods): Use objfile_msymbols.
8986         (info_selectors_command, info_classes_command): Likewise.
8987         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8988         * objfiles.h (class objfile_msymbols): New.
8989         (ALL_OBJFILE_MSYMBOLS): Remove.
8990         (ALL_MSYMBOLS): Remove.
8991
8992 2019-01-09  Tom Tromey  <tom@tromey.com>
8993
8994         * common/next-iterator.h (next_adapter): Add Iterator template
8995         parameter.
8996         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8997         (class all_objfiles_safe): New.
8998         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8999         * objfiles.c (put_objfile_before): Update comment.
9000         (add_separate_debug_objfile): Likewise.
9001         (free_all_objfiles): Use all_objfiles_safe.
9002         (objfile_purge_solibs): Likewise.
9003
9004 2019-01-09  Tom Tromey  <tom@tromey.com>
9005
9006         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9007         (expand_symtab_containing_pc, lookup_static_symbol)
9008         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9009         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9010         all_objfiles.
9011         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9012         * breakpoint.c (create_overlay_event_breakpoint)
9013         (create_longjmp_master_breakpoint)
9014         (create_std_terminate_master_breakpoint)
9015         (create_exception_master_breakpoint): Use all_objfiles.
9016         * linux-thread-db.c (try_thread_db_load_from_pdir)
9017         (has_libpthread): Use all_objfiles.
9018         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9019         * linespec.c (iterate_over_all_matching_symtabs)
9020         (search_minsyms_for_name): Use all_objfiles.
9021         * maint.c (maintenance_info_sections): Use all_objfiles.
9022         * main.c (captured_main_1): Use all_objfiles.
9023         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9024         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9025         * guile/scm-pretty-print.c
9026         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9027         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9028         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9029         (maintenance_print_msymbols): Use all_objfiles.
9030         * source.c (select_source_symtab): Use all_objfiles.
9031         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9032         * symfile.c (remove_symbol_file_command)
9033         (expand_symtabs_matching, map_symbol_filenames): Use
9034         all_objfiles.
9035         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9036         all_objfiles.
9037         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9038         * objc-lang.c (find_methods): Use all_objfiles.
9039         * objfiles.c (have_partial_symbols, have_full_symbols)
9040         (have_minimal_symbols, qsort_cmp)
9041         (default_iterate_over_objfiles_in_search_order): Use
9042         all_objfiles.
9043         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9044         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9045         (maintenance_check_psymtabs): Use all_objfiles.
9046         (ALL_PSYMTABS): Remove.
9047         * compile/compile-object-run.c (do_module_cleanup): Use
9048         all_objfiles.
9049         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9050         * cp-support.c (add_symbol_overload_list_qualified): Use
9051         all_objfiles.
9052         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9053         Use all_objfiles.
9054         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9055         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9056         all_objfiles.
9057         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9058         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9059         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9060         Uses all_objfiles.
9061         * solib.c (solib_read_symbols): Use all_objfiles
9062
9063 2019-01-09  Tom Tromey  <tom@tromey.com>
9064
9065         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9066         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9067         all_objfiles.
9068         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9069         * symmisc.c (print_symbol_bcache_statistics)
9070         (print_objfile_statistics, maintenance_print_objfiles)
9071         (maintenance_info_symtabs, maintenance_check_symtabs)
9072         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9073         all_objfiles.
9074         * source.c (forget_cached_source_info): Use all_objfiles.
9075         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9076         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9077         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9078         * objfiles.c (update_section_map): Use all_objfiles.
9079         (shared_objfile_contains_address_p): Likewise.
9080         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9081         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9082
9083 2019-01-09  Tom Tromey  <tom@tromey.com>
9084
9085         * common/next-iterator.h: New file.
9086         * objfiles.h (class all_objfiles): New.
9087         (struct objfile_iterator): New.
9088
9089 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9090
9091         * NEWS: Move the description of the changed "frame", "select-frame",
9092          and "info frame" commands to the Changed commands section.
9093
9094 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9095
9096         * gdbtypes.c (check_stub_method_group): Remove handling of old
9097         mangling schemes.
9098         * linespec.c (find_methods): Likewise.
9099         * stabsread.c (read_member_functions): Likewise.
9100         * valops.c (search_struct_method): Likewise.
9101         (value_struct_elt_for_reference): Likewise.
9102         * NEWS: Mention this change.
9103
9104 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9105
9106         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9107         print_source_lines.
9108         * source.c (print_source_lines_base): Update line number check.
9109         (print_source_lines): New function.
9110         (source_lines_range::source_lines_range): New function.
9111         * source.h (class source_lines_range): New class.
9112         (print_source_lines): New declaration.
9113
9114 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9115
9116         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9117
9118 2019-01-08  Tom Tromey  <tom@tromey.com>
9119             Simon Marchi  <simon.marchi@ericsson.com>
9120
9121         PR gdb/24060
9122         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9123         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9124         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9125         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9126         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9127         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9128
9129 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9130
9131         * source.c (select_source_symtab): Move header comment to
9132         declaration in source.h.
9133         (forget_cached_source_info_for_objfile): Likewise.
9134         (forget_cached_source_info): Likewise.
9135         (identify_source_line): Likewise.
9136         * source.h (identify_source_line): Move declaration from symtab.h
9137         and add comment from source.c
9138         (print_source_lines): Likewise.
9139         (forget_cached_source_info_for_objfile): Likewise.
9140         (forget_cached_source_info): Likewise.
9141         (select_source_symtab): Likewise.
9142         (enum print_source_lines_flag): Move definition from symtab.h.
9143         * symtab.h (identify_source_line): Move declaration to source.h.
9144         (print_source_lines): Likewise.
9145         (forget_cached_source_info_for_objfile): Likewise.
9146         (forget_cached_source_info): Likewise.
9147         (select_source_symtab): Likewise.
9148         (enum print_source_lines_flag): Move definition to source.h.
9149         * tui/tui-hooks.c: Add 'source.h' include.
9150
9151 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9152
9153         * source.c (print_source_lines_base): Handle requests to print
9154         reverse line number sequences, and guard against empty lines
9155         string.
9156
9157 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9158
9159         * source.c (print_source_lines_base): Fix skip of '\r' if next
9160         character is '\n'.
9161
9162 2019-01-06  Tom Tromey  <tom@tromey.com>
9163
9164         * c-exp.y (struct c_parse_state) <macro_original_text,
9165         expansion_obstack>: New member.
9166         (macro_original_text, expansion_obstack): Remove globals.
9167         (scan_macro_expansion, scanning_macro_expansion)
9168         (finished_macro_expansion): Update.
9169         (scan_macro_cleanup): Remove.
9170         (yylex, c_parse): Update.
9171
9172 2019-01-06  Tom Tromey  <tom@tromey.com>
9173
9174         * c-exp.y (struct c_parse_state) <strings>: New member.
9175         (operator_stoken): Update.
9176
9177 2019-01-06  Tom Tromey  <tom@tromey.com>
9178
9179         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9180         (union type_stack_elt) <typelist_val>: Now a pointer to
9181         std::vector.
9182         (type_stack_cleanup): Don't declare.
9183         (push_typelist): Update.
9184         * parse.c (pop_typelist): Return a std::vector.
9185         (push_typelist): Take a std::vector.
9186         (follow_types): Update.  Do not free args.
9187         (type_stack_cleanup): Remove.
9188         * c-exp.y (struct c_parse_state): New.
9189         (cpstate): New global.
9190         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9191         (nonempty_typelist): Update.
9192         (func_mod): Create a new vector.
9193         (c_parse): Create a c_parse_state.
9194         (check_parameter_typelist): Do not delete params.
9195         (function_method): Update.  Do not delete type_list.
9196
9197 2019-01-06  Tom Tromey  <tom@tromey.com>
9198
9199         PR gdb/28155:
9200         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9201         check_typedef.
9202         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9203         (print_return_value): Likewise.
9204
9205 2019-01-05  Tom Tromey  <tom@tromey.com>
9206
9207         * contrib/cleanup_check.py: Remove.
9208         * contrib/gcc-with-excheck: Remove.
9209         * contrib/exsummary.py: Remove.
9210         * contrib/excheck.py: Remove.
9211
9212 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9213
9214         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9215         NULL. Initialize tpprev to NULL instead of assigning it
9216         to NULL on the next statement.
9217         * windows-nat.c (windows_delete_thread): Remove check for
9218         main_thread_id before printing thread exit notifications.
9219         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9220         Remove thread ID check against main_thread_id.
9221         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9222         windows_delete_thread.
9223         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9224
9225 2019-01-04  Tom Tromey  <tom@tromey.com>
9226
9227         * compile/compile.c (_initialize_compile): Use upper case for
9228         metasyntactic variables.
9229         * symmisc.c (_initialize_symmisc): Use upper case for
9230         metasyntactic variables.
9231         * psymtab.c (_initialize_psymtab): Use upper case for
9232         metasyntactic variables.
9233         * demangle.c (demangle_command): Use upper case for metasyntactic
9234         variables.
9235         (_initialize_demangler): Likewise.
9236         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9237         variables.
9238
9239 2019-01-03  Tom Tromey  <tom@tromey.com>
9240
9241         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9242
9243 2019-01-03  Tom Tromey  <tom@tromey.com>
9244
9245         * python/py-symtab.c (salpy_str): Update.
9246         (struct salpy_sal_object) <symtab>: Now a PyObject.
9247         (salpy_dealloc): Update.
9248         (del_objfile_sal): Use gdbpy_ref.
9249
9250 2019-01-03  Tom Tromey  <tom@tromey.com>
9251
9252         * python/py-type.c (convert_field): Use new_reference.  Return
9253         gdbpy_ref.
9254         (make_fielditem): Return gdbpy_ref.
9255         (typy_fields): Update.
9256         (typy_getitem): Update.
9257         (field_name): Return gdbpy_ref.  Use new_reference.
9258         (typy_iterator_iternext): Update.
9259
9260 2019-01-03  Tom Tromey  <tom@tromey.com>
9261
9262         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9263
9264 2019-01-03  Tom Tromey  <tom@tromey.com>
9265
9266         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9267         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9268         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9269         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9270         (pspy_set_type_printers): Likewise.
9271         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9272         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9273         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9274         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9275         (objfpy_set_type_printers): Likewise.
9276
9277 2019-01-03  Tom Tromey  <tom@tromey.com>
9278
9279         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9280         (gdbpy_print_stack): Use gdbpy_err_fetch.
9281         * python/python-internal.h (class gdbpy_err_fetch): New class.
9282         (class gdbpy_enter) <m_error_type, m_error_value,
9283         m_error_traceback>: Remove.
9284         <m_error>: New member.
9285         (gdbpy_exception_to_string): Don't declare.
9286         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9287         * python/py-value.c (convert_value_from_python): Use
9288         gdbpy_err_fetch.
9289         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9290         gdbpy_exception_to_string.
9291         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9292         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9293         gdbpy_err_fetch.
9294
9295 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9296
9297         * linux-nat.c (delete_lwp_cleanup): Delete.
9298         (struct lwp_deleter): New struct.
9299         (lwp_info_up): New typedef.
9300         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9301         lwp_info_up.
9302
9303 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9304
9305         * linux-fork.c (class scoped_switch_fork_info): New class.
9306         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9307
9308 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9309
9310         * valops.c (find_overload_match): Remove use of null_cleanup, and
9311         calls to do_cleanups.
9312
9313 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9314
9315         * compile/compile-cplus-types.c
9316         (compile_cplus_instance::decl_name): Handle changes to
9317         cp_func_name.
9318         * cp-support.c (cp_func_name): Update header comment, update
9319         return type.
9320         * cp-support.h (cp_func_name): Update return type in declaration.
9321         * valops.c (find_overload_match): Move temp_func local to top
9322         level of function and change its type.  Use temp_func to hold and
9323         delete temporary string obtained from cp_func_name.
9324
9325 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9326
9327         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9328         gdb::char_vector, remove cleanup, and update uses of `msg`.
9329
9330 2019-01-03  Jim Wilson  <jimw@sifive.com>
9331
9332         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9333
9334 2019-01-02  Tom Tromey  <tom@tromey.com>
9335
9336         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9337         (tdesc_parse_xml): Remove cleanups.
9338         * target-descriptions.h (make_cleanup_free_target_description):
9339         Don't declare.
9340         (target_desc_deleter): New struct.
9341         (target_desc_up): New typedef.
9342         * target-descriptions.c (target_desc_deleter::operator()): Rename
9343         from free_target_description.
9344         (make_cleanup_free_target_description): Remove.
9345
9346 2019-01-02  Tom Tromey  <tom@tromey.com>
9347
9348         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9349         constructor, destructor.
9350         (linespec_parser): Remove typedef.
9351         (~linespec_parser): Rename from linespec_parser_delete.
9352         (linespec_lex_to_end, linespec_complete_label)
9353         (linespec_complete): Update.
9354         (decode_line_full): Remove cleanups.
9355         (decode_line_1): Update.
9356
9357 2019-01-02  Tom Tromey  <tom@tromey.com>
9358
9359         * python/python-internal.h (inferior_to_inferior_object): Change
9360         return type.
9361         * python/py-exitedevent.c (create_exited_event_object): Update.
9362         * python/py-inferior.c (inferior_to_inferior_object): Return
9363         gdbpy_ref.
9364         (python_new_inferior, python_inferior_deleted)
9365         (thread_to_thread_object, delete_thread_object)
9366         (build_inferior_list, gdbpy_selected_inferior): Update.
9367         * python/py-infthread.c (create_thread_object): Update.  Also fail
9368         if inferior_to_inferior_object fails.
9369
9370 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9371
9372         * inferior.h (class inferior) <displaced_step_state>: New field.
9373         * infrun.h (struct displaced_step_state): Move here from
9374         infrun.c.  Initialize fields, add constructor.
9375         <inf>: Remove field.
9376         <reset>: New method.
9377         * infrun.c (struct displaced_step_inferior_state): Move to
9378         infrun.h.
9379         (displaced_step_inferior_states): Remove.
9380         (get_displaced_stepping_state): Adust.
9381         (displaced_step_in_progress_any_inferior): Adjust.
9382         (displaced_step_in_progress_thread): Adjust.
9383         (displaced_step_in_progress): Adjust.
9384         (add_displaced_stepping_state): Remove.
9385         (get_displaced_step_closure_by_addr): Adjust.
9386         (remove_displaced_stepping_state): Remove.
9387         (infrun_inferior_exit): Call displaced_step_state.reset.
9388         (use_displaced_stepping): Don't check for NULL.
9389         (displaced_step_prepare_throw): Call
9390         get_displaced_stepping_state.
9391         (displaced_step_fixup): Don't check for NULL.
9392         (prepare_for_detach): Don't check for NULL.
9393
9394 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9395
9396         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9397          in case of call that did not complete.
9398
9399 2019-01-02  Andrey Utkin  <autkin@undo.io>
9400
9401         * symfile.c (find_separate_debug_file): Fix search of debug files for
9402         remote debuggee.
9403
9404 2019-01-02  Tom Tromey  <tom@tromey.com>
9405
9406         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9407         indentation.
9408         * python/py-frame.c (frapy_older): Remove cast.
9409         (frapy_newer): Likewise.
9410         * python/py-breakpoint.c (local_setattro): Remove cast.
9411         * python/py-arch.c (archpy_name): Remove local variable.
9412         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9413
9414 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9415
9416         * unittests/basic_string_view/element_access/char/empty.cc:
9417         Fix year range in copyright header.
9418
9419 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9420
9421         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9422         Delete.
9423         <operator==>: Update with for removed field.
9424         <hash>: Likewise.
9425         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9426         <isa_features>: ...this.
9427         <abi_features>: New field.
9428         (riscv_isa_flen): Update comment.
9429         (riscv_abi_xlen): New declaration.
9430         (riscv_abi_flen): New declaration.
9431         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9432         isa_features.
9433         (riscv_abi_xlen): New function.
9434         (riscv_isa_flen): Update to get answer from isa_features.
9435         (riscv_abi_flen): New function.
9436         (riscv_has_fp_abi): Update to get answer from abi_features.
9437         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9438         xlen and flen.
9439         (riscv_call_info) <xlen, flen>: Update comment.
9440         (riscv_call_arg_struct): Remove invalid assertions
9441         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9442         is removed.
9443         (riscv_gdbarch_init): Gather isa features and abi features
9444         separately, ensure both match on the gdbarch when reusing an old
9445         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9446         a target with 64-bit float hardware.
9447
9448 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9449
9450         * source.c (search_command_helper): Stop reverse search
9451         when line 1 has been searched.
9452
9453 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9454
9455         * record-full.c (record_full_base_target::close): Rewrite
9456         record_full_core_buf_list free logic.
9457
9458 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9459
9460         * break-catch-syscall.c (print_one_catch_syscall): xfree
9461         the last text.
9462
9463 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9464
9465         * top.c (print_gdb_version): Update Copyright year in version
9466         message.
9467
9468 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9469
9470         Update copyright year range in all GDB files.
9471
9472 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9473
9474         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9475
9476 For older changes see ChangeLog-2018.
9477 \f
9478 Local Variables:
9479 mode: change-log
9480 left-margin: 8
9481 fill-column: 74
9482 version-control: never
9483 coding: utf-8
9484 End:
9485