5687fada5b50458c1bf5df1090d78710dbb21736
[external/binutils.git] / gdb / ChangeLog
1 2017-03-27  Max Filippov  <jcmvbkbc@gmail.com>
2
3         * arch/xtensa.h (C0_NREGS): Add definition.
4         * xtensa-tdep.c (C0_NREGS): Remove definition.
5
6 2017-03-27  Max Filippov  <jcmvbkbc@gmail.com>
7
8         * xtensa-tdep.c (xtensa_scan_prologue, call0_analyze_prologue):
9         Drop xtensa_default_isa initialization.
10         (xtensa_gdbarch_init): Initialize xtensa_default_isa.
11
12 2017-03-27  Pedro Alves  <palves@redhat.com>
13
14         * dwarf2read.c (file_entry) <dir_index>: Add comment.
15         (file_entry::include_dir): New method.
16         (line_header::include_dir_at, line_header::file_name_at): New
17         methods.
18         (setup_type_unit_groups, setup_type_unit_groups)
19         (psymtab_include_file_name): Simplify using the new methods.
20         (lnp_state_machine) <the_line_header>: New field.
21         <file>: Add comment.
22         (lnp_state_machine::current_file): New method.
23         (dwarf_record_line): Simplify using the new methods.
24         (init_lnp_state_machine): Initialize the "the_line_header" field.
25         (dwarf_decode_lines_1, dwarf_decode_lines, file_file_name):
26         Simplify using the new methods.
27
28 2017-03-27  Pedro Alves  <palves@redhat.com>
29
30         * cp-name-parser.y (make_empty): Delete.
31         (demangler_special, nested_name, ptr_operator, array_indicator)
32         (direct_declarator, declarator_1): Use fill_comp instead of
33         make_empty.
34
35 2017-03-27  Pedro Alves  <palves@redhat.com>
36
37         * xml-support.h (gdb_xml_debug): Pass a "first-to-check" argument
38         to ATTRIBUTE_PRINTF.
39         * solib-target.c (library_list_start_list): Print "string" not
40         "version".
41         * xml-tdesc.c (tdesc_start_field): Pass "field_name" to
42         gdb_xml_error call.
43
44 2017-03-27  Pedro Alves  <palves@redhat.com>
45
46         * dwarf2read.c (struct file_and_directory): New.
47         (dwarf2_get_dwz_file): Adjust to use std::string.
48         (dw2_get_file_names_reader): Adjust to use file_and_directory.
49         (find_file_and_directory): Adjust to return a file_and_directory
50         object.
51         (read_file_scope): Adjust to use file_and_directory.  Remove
52         make_cleanup/do_cleanups calls.
53         (open_and_init_dwp_file): Adjust to use std::string.  Remove
54         make_cleanup/do_cleanups calls.
55         * python/python.c (do_start_initialization): Adjust to ldirname
56         returning a std::string.
57         * utils.c (ldirname): Now returns a std::string.
58         * utils.h (ldirname): Change return type to std::string.
59         * xml-syscall.c (xml_init_syscalls_info): Adjust to ldirname
60         returning a std::string.
61         * xml-tdesc.c (file_read_description_xml): Likewise.
62
63 2017-03-24  Alan Hayward  <alan.hayward@arm.com>
64
65         * regcache.c (regcache_debug_print_register): New function.
66         * regcache.h (regcache_debug_print_register): New declaration.
67         * target.c (debug_print_register): Remove.
68         (target_fetch_registers): Call regcache_debug_print_register.
69         (target_store_registers): Likewise.
70
71 2017-03-24  Pádraig Brady  <pbrady@fb.com>
72
73         * dwarf2read.c (setup_type_unit_groups): Ensure dir_index doesn't
74         reference beyond the 'lh->include_dirs' array before accessing to
75         it.
76         (psymtab_include_file_name): Likewise.
77         (dwarf_decode_lines_1): Likewise.
78         (dwarf_decode_lines): Likewise.
79         (file_file_name): Likewise.
80
81 2017-03-23  Simon Marchi  <simon.marchi@ericsson.com>
82
83         * fbsd-tdep.c (fbsd_corefile_thread): Don't set/restore
84         inferior_ptid.
85         * proc-service.c (ps_lgetregs, ps_lsetregs, ps_lgetfpregs,
86         ps_lsetfpregs): Likewise.
87         * regcache.c (regcache_raw_update, regcache_raw_write): Likewise.
88         * sol-thread.c (ps_lgetregs, ps_lsetregs, ps_lgetfpregs,
89         ps_lsetfpregs): Likewise.
90         * target.c (target_fetch_registers, target_store_registers):
91         Remove asserts.
92
93 2017-03-23  Alan Hayward  <alan.hayward@arm.com>
94
95         * sol-thread.c (sol_thread_store_registers): Remove regcache calls.
96
97 2017-03-23  Yao Qi  <yao.qi@linaro.org>
98
99         * aarch64-tdep.c (aarch64_process_record_test): Declare.
100         (_initialize_aarch64_tdep): Register it.
101         (aarch64_record_load_store): Handle PRFM instruction.
102         (aarch64_process_record_test): New function.
103
104 2017-03-23  Yao Qi  <yao.qi@linaro.org>
105
106         * aarch64-tdep.c (aarch64_record_load_store): Fix code
107         indentation.
108
109 2017-03-23  Yao Qi  <yao.qi@linaro.org>
110
111         * aarch64-tdep.c: Remove AARCH64_RECORD_FAILURE.
112
113 2017-03-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
114
115         python/python.c (do_start_initialization): Fix memory leak.
116
117 2017-03-22  Simon Marchi  <simon.marchi@polymtl.ca>
118
119         * inf-ptrace.c (inf_ptrace_xfer_partial): Get pid from ptid
120         using get_ptrace_pid.
121         * linux-nat.c (linux_nat_xfer_partial): Don't set/restore
122         inferior_ptid.
123         (linux_proc_xfer_partial, linux_proc_xfer_spu): Use lwp of
124         inferior_ptid instead of pid.
125
126 2017-03-22  Yao Qi  <yao.qi@linaro.org>
127
128         * aarch64-tdep.c: Wrap locally used classes in anonymous
129         namespace.
130         * arm-tdep.c: Likewise.
131         * linespec.c: Likewise.
132         * ui-out.c: Likewise.
133
134 2017-03-22  Jonah Graham  <jonah@kichwacoders.com>
135
136         PR gdb/19637
137         * python/lib/gdb/printer/bound_registers.py: Import sys.
138
139 2017-03-21  Simon Marchi  <simon.marchi@ericsson.com>
140
141         * windows-nat.c (do_windows_fetch_inferior_registers): Add
142         windows_thread_info parameter and use it instead of
143         current_thread.
144         (windows_fetch_inferior_registers): Don't set current_thread,
145         pass the thread to do_windows_fetch_inferior_registers.  Use
146         ptid from regcache instead of inferior_ptid.
147         (do_windows_store_inferior_registers): Add windows_thread_info
148         parameter and use it instead of current_thread.
149         (windows_store_inferior_registers): Don't set current_thread,
150         pass the thread to do_windows_store_inferior_registers.  Use
151         ptid from regcache instead of inferior_ptid.
152
153 2017-03-21  Simon Marchi  <simon.marchi@ericsson.com>
154
155         * ser-mingw.c (ser_windows_raw): Remove reference to
156         struct serial::current_timeout.
157
158 2017-03-21  Ivo Raisr  <ivo.raisr@oracle.com>
159
160         PR tdep/20928
161         * gdb/sparc-tdep.h (gdbarch_tdep) <sparc64_ccr_type>: New field.
162         * gdb/sparc64-tdep.c (sparc64_ccr_type): New function.
163         (sparc64_fsr_type): Fix %fsr decoding.
164
165 2017-03-21  Tim Wiederhake  <tim.wiederhake@intel.com>
166
167         * python/py-record-btrace.c (btpy_insn_data): Change return type
168         for Python 2.
169
170 2017-03-20  Simon Marchi  <simon.marchi@polymtl.ca>
171
172         * spu-linux-nat.c (spu_fetch_inferior_registers,
173         spu_store_inferior_registers): Use ptid from regcache, set and
174         restore inferior_ptid.
175         * spu-multiarch.c (spu_fetch_registers, spu_store_registers):
176         Likewise.
177
178 2017-03-20  Simon Marchi  <simon.marchi@polymtl.ca>
179
180         * i386-linux-nat.c (fetch_register, store_register,
181         i386_linux_fetch_inferior_registers,
182         i386_linux_store_inferior_registers): Use ptid from regcache.
183         * ia64-linux-nat.c (ia64_linux_fetch_register,
184         ia64_linux_store_register): Likewise.
185         * inf-ptrace.c (inf_ptrace_fetch_register,
186         inf_ptrace_store_register): Likewise.
187         * m32r-linux-nat.c (m32r_linux_fetch_inferior_registers,
188         m32r_linux_store_inferior_registers): Likewise.
189         * m68k-bsd-nat.c (m68kbsd_fetch_inferior_registers,
190         m68kbsd_store_inferior_registers): Likewise.
191         * m68k-linux-nat.c (fetch_register, store_register,
192         m68k_linux_fetch_inferior_registers,
193         m68k_linux_store_inferior_registers): Likewise.
194         * m88k-bsd-nat.c (m88kbsd_fetch_inferior_registers,
195         m88kbsd_store_inferior_registers): Likewise.
196         * mips-fbsd-nat.c (mips_fbsd_fetch_inferior_registers,
197         mips_fbsd_store_inferior_registers): Likewise.
198         * mips-linux-nat.c (mips64_linux_regsets_fetch_registers,
199         mips64_linux_regsets_store_registers): Likewise.
200         * mips-nbsd-nat.c (mipsnbsd_fetch_inferior_registers,
201         mipsnbsd_store_inferior_registers): Likewise.
202         * mips-obsd-nat.c (mips64obsd_fetch_inferior_registers,
203         mips64obsd_store_inferior_registers): Likewise.
204         * nto-procfs.c (procfs_fetch_registers, procfs_store_registers):
205         Likewise.
206         * ppc-fbsd-nat.c (ppcfbsd_fetch_inferior_registers,
207         ppcfbsd_store_inferior_registers): Likewise.
208         * ppc-linux-nat.c (ppc_linux_fetch_inferior_registers,
209         ppc_linux_store_inferior_registers): Likewise.
210         * ppc-nbsd-nat.c (ppcnbsd_fetch_inferior_registers,
211         ppcnbsd_store_inferior_registers): Likewise.
212         * ppc-obsd-nat.c (ppcobsd_fetch_registers,
213         ppcobsd_store_registers): Likewise.
214         * procfs.c (procfs_fetch_registers, procfs_store_registers):
215         Likewise.
216         * ravenscar-thread.c (ravenscar_fetch_registers,
217         ravenscar_store_registers, ravenscar_prepare_to_store):
218         Likewise.
219         * record-btrace.c (record_btrace_fetch_registers,
220         record_btrace_store_registers, record_btrace_prepare_to_store):
221         Likewise.
222         * remote-sim.c (gdbsim_fetch_register, gdbsim_store_register):
223         Lookup inferior using ptid from regcache, instead of
224         current_inferior.
225         * remote.c (remote_fetch_registers, remote_store_registers): Use
226         ptid from regcache.
227         * rs6000-nat.c (fetch_register, store_register): Likewise.
228         * s390-linux-nat.c (s390_linux_fetch_inferior_registers,
229         s390_linux_store_inferior_registers): Likewise.
230         * sh-nbsd-nat.c (shnbsd_fetch_inferior_registers,
231         shnbsd_store_inferior_registers): Likewise.
232         * sol-thread.c (sol_thread_fetch_registers,
233         sol_thread_store_registers): Likewise.
234         * sparc-nat.c (sparc_fetch_inferior_registers,
235         sparc_store_inferior_registers): Likewise.
236         * tilegx-linux-nat.c (fetch_inferior_registers,
237         store_inferior_registers): Likewise.
238         * vax-bsd-nat.c (vaxbsd_fetch_inferior_registers,
239         vaxbsd_store_inferior_registers): Likewise.
240         * xtensa-linux-nat.c (fetch_gregs, store_gregs, fetch_xtregs,
241         store_xtregs): Likewise.
242
243 2017-03-20  Artemiy Volkov  <artemiyv@acm.org>
244
245         PR gdb/14441
246         * NEWS: Mention support for rvalue references in GDB and python.
247         * doc/gdb.texinfo (C Plus Plus Expressions): Mention that GDB
248         supports both lvalue and rvalue references.
249
250 2017-03-20  Artemiy Volkov  <artemiyv@acm.org>
251
252         PR gdb/14441
253         * gdbtypes.c (rank_one_type): Implement overloading
254         resolution rules regarding rvalue references.
255
256 2017-03-20  Artemiy Volkov  <artemiyv@acm.org>
257
258         PR gdb/14441
259         * aarch64-tdep.c (aarch64_type_align)
260         (aarch64_extract_return_value, aarch64_store_return_value): Change
261         lvalue reference type checks to general reference type checks.
262         * amd64-tdep.c (amd64_classify): Likewise.
263         * amd64-windows-tdep.c (amd64_windows_passed_by_integer_register):
264         Likewise.
265         * arm-tdep.c (arm_type_align, arm_extract_return_value)
266         (arm_store_return_value): Likewise.
267         * ax-gdb.c (gen_fetch, gen_cast): Likewise.
268         * c-typeprint.c (c_print_type): Likewise.
269         * c-varobj.c (adjust_value_for_child_access, c_value_of_variable)
270         (cplus_number_of_children, cplus_describe_child): Likewise.
271         * compile/compile-c-symbols.c (generate_vla_size): Likewise.
272         * completer.c (expression_completer): Likewise.
273         * cp-support.c (make_symbol_overload_list_adl_namespace):
274         Likewise.
275         * darwin-nat-info.c (info_mach_region_command): Likewise.
276         * dwarf2loc.c (entry_data_value_coerce_ref)
277         (value_of_dwarf_reg_entry): Likewise.
278         * eval.c (ptrmath_type_p, evaluate_subexp_standard)
279         (evaluate_subexp_for_address, evaluate_subexp_for_sizeof):
280         Likewise.
281         * findvar.c (extract_typed_address, store_typed_address):
282         Likewise.
283         * gdbtypes.c (rank_one_type): Likewise.
284         * hppa-tdep.c (hppa64_integral_or_pointer_p): Likewise.
285         * infcall.c (value_arg_coerce): Likewise.
286         * language.c (pointer_type): Likewise.
287         * m32c-tdep.c (m32c_reg_arg_type, m32c_m16c_address_to_pointer):
288         Likewise.
289         * m88k-tdep.c (m88k_integral_or_pointer_p): Likewise.
290         * mn10300-tdep.c (mn10300_type_align): Likewise.
291         * msp430-tdep.c (msp430_push_dummy_call): Likewise.
292         * ppc-sysv-tdep.c (do_ppc_sysv_return_value)
293         (ppc64_sysv_abi_push_param, ppc64_sysv_abi_return_value):
294         Likewise.
295         * printcmd.c (print_formatted, x_command): Likewise.
296         * python/py-type.c (typy_get_composite, typy_template_argument):
297         Likewise.
298         * python/py-value.c (valpy_referenced_value)
299         (valpy_get_dynamic_type, value_has_field): Likewise.
300         * s390-linux-tdep.c (s390_function_arg_integer): Likewise.
301         * sparc-tdep.c (sparc_integral_or_pointer_p): Likewise.
302         * sparc64-tdep.c (sparc64_integral_or_pointer_p): Likewise.
303         * spu-tdep.c (spu_scalar_value_p): Likewise.
304         * symtab.c (lookup_symbol_aux): Likewise.
305         * typeprint.c (whatis_exp, print_type_scalar): Likewise.
306         * valarith.c (binop_types_user_defined_p, unop_user_defined_p):
307         Likewise.
308         * valops.c (value_cast_pointers, value_cast)
309         (value_reinterpret_cast, value_dynamic_cast, value_addr, typecmp)
310         (value_struct_elt, value_struct_elt_bitpos)
311         (value_find_oload_method_list, find_overload_match)
312         (value_rtti_indirect_type): Likewise.
313         * valprint.c (val_print_scalar_type_p, generic_val_print):
314         Likewise.
315         * value.c (value_actual_type, value_as_address, unpack_long)
316         (pack_long, pack_unsigned_long, coerce_ref_if_computed)
317         (coerce_ref): Likewise.
318         * varobj.c (varobj_get_value_type): Likewise.
319
320 2017-03-20  Artemiy Volkov  <artemiyv@acm.org>
321
322         PR gdb/14441
323         * doc/python.texi (Types in Python): Add TYPE_CODE_RVALUE_REF to
324         table of constants.
325         * python/lib/gdb/command/explore.py: Support exploring values
326         of rvalue reference types.
327         * python/lib/gdb/types.py: Implement get_basic_type() for
328         rvalue reference types.
329         * python/py-type.c (pyty_codes) <TYPE_CODE_RVALUE_REF>: New
330         constant.
331         * python/py-value.c (valpy_getitem): Add an rvalue reference
332         check.
333         (valpy_reference_value): Add new parameter "refcode".
334         (valpy_lvalue_reference_value, valpy_rvalue_reference_value):
335         New wrappers for valpy_reference_value().
336         * python/py-xmethods.c (gdbpy_get_xmethod_result_type)
337         (gdbpy_invoke_xmethod): Likewise.
338
339 2017-03-20  Artemiy Volkov  <artemiyv@acm.org>
340
341         PR gdb/14441
342         * dwarf2read.c (process_die, read_type_die_1): Handle the
343         DW_TAG_rvalue_reference_type DIE.
344         (read_tag_reference_type): Add new parameter "refcode".
345
346 2017-03-20  Artemiy Volkov  <artemiyv@acm.org>
347
348         PR gdb/14441
349         * c-typeprint.c (c_print_type, c_type_print_varspec_prefix)
350         (c_type_print_modifier, c_type_print_varspec_suffix)
351         (c_type_print_base): Support printing rvalue reference types.
352         * c-valprint.c (c_val_print, c_value_print): Support printing
353         rvalue reference values.
354
355 2017-03-20  Artemiy Volkov  <artemiyv@acm.org>
356
357         PR gdb/14441
358         * cp-name-parser.y (ptr_operator): Handle the '&&' token in
359         typename.
360         * cp-support.c (replace_typedefs): Handle
361         DEMANGLE_COMPONENT_RVALUE_REFERENCE.
362         * python/py-type.c (typy_lookup_type): Likewise.
363
364 2017-03-20  Artemiy Volkov  <artemiyv@acm.org>
365
366         PR gdb/14441
367         * c-exp.y (ptr_operator): Handle the '&&' token in the typename.
368         * parse.c (insert_type): Change assert statement.
369         (follow_types): Handle rvalue reference types.
370         * parser-defs.h (enum type_pieces) <tp_rvalue_reference>: New
371         constant.
372
373 2017-03-20  Artemiy Volkov  <artemiyv@acm.org>
374
375         PR gdb/14441
376         * ada-lang.c (ada_evaluate_subexp): Adhere to the new
377         value_ref() interface.
378         * c-valprint.c (c_value_print): Likewise.
379         * infcall.c (value_arg_coerce): Likewise.
380         * python/py-value.c (valpy_reference_value): Likewise.
381         * valops.c (value_cast, value_reinterpret_cast)
382         (value_dynamic_cast, typecmp): Likewise.
383         (value_ref): Parameterize by kind of return value reference type.
384         * value.h (value_ref): Add new parameter "refcode".
385
386 2017-03-20  Artemiy Volkov  <artemiyv@acm.org>
387
388         PR gdb/14441
389         * dwarf2read.c (read_tag_reference_type): Use
390         lookup_lvalue_reference_type() instead of lookup_reference_type().
391         * eval.c (evaluate_subexp_standard): Likewise.
392         * f-exp.y: Likewise.
393         * gdbtypes.c (make_reference_type, lookup_reference_type):
394         Generalize with rvalue reference types.
395         (lookup_lvalue_reference_type, lookup_rvalue_reference_type): New
396         convenience wrappers for lookup_reference_type().
397         * gdbtypes.h (make_reference_type, lookup_reference_type): Add a
398         reference kind parameter.
399         (lookup_lvalue_reference_type, lookup_rvalue_reference_type): Add
400         wrappers for lookup_reference_type().
401         * guile/scm-type.c (gdbscm_type_reference): Use
402         lookup_lvalue_reference_type() instead of lookup_reference_type().
403         * guile/scm-value.c (gdbscm_value_dynamic_type): Likewise.
404         * parse.c (follow_types): Likewise.
405         * python/py-type.c (typy_reference, typy_lookup_type): Likewise.
406         * python/py-value.c (valpy_get_dynamic_type, valpy_getitem):
407         Likewise.
408         * python/py-xmethods.c (gdbpy_get_xmethod_result_type)
409         (gdbpy_invoke_xmethod): Likewise.
410         * stabsread.c: Provide extra argument to make_reference_type()
411         call.
412         * valops.c (value_ref, value_rtti_indirect_type): Use
413         lookup_lvalue_reference_type() instead of lookup_reference_type().
414
415 2017-03-20  Artemiy Volkov  <artemiyv@acm.org>
416
417         PR gdb/14441
418         * gdbtypes.h (enum type_code) <TYPE_CODE_RVALUE_REF>: New constant.
419         (TYPE_IS_REFERENCE): New macro.
420         (struct type): Add rvalue_reference_type field.
421         (TYPE_RVALUE_REFERENCE_TYPE): New macro.
422
423 2017-03-20  Marc-Andre Laperle  <marc-andre.laperle@ericsson.com>
424
425         * NEWS: Add an entry about new '-file-list-shared-libraries' command.
426         * mi/mi-cmd-file.c (mi_cmd_file_list_shared_libraries):
427         New function definition.
428         * mi/mi-cmds.c (mi_cmds): Add -file-list-shared-libraries command.
429         * mi/mi-cmds.h (mi_cmd_file_list_shared_libraries):
430         New function declaration.
431         * mi/mi-interp.c (mi_output_solib_attribs): New Function.
432         * mi/mi-interp.h: New file.
433         * solib.c (info_sharedlibrary_command): Replace for loop with
434         ALL_SO_LIBS macro
435         * solib.h (update_solib_list): New function declaration.
436         (so_list_head): Move macro.
437         * solist.h (ALL_SO_LIBS): New macro.
438
439 2017-03-20  Marc-Andre Laperle  <marc-andre.laperle@ericsson.com>
440
441         * infcmd.c (post_create_inferior): Remove unused argument in
442         call to solib_add.
443         * remote.c (remote_start_remote): Likewise.
444         * solib-frv.c (frv_fetch_objfile_link_map): Likewise.
445         * solib-svr4.c: (svr4_fetch_objfile_link_map): Likewise.
446         (enable_break): Likewise.
447         * solib.c (update_solib_list): Remove unused target argument
448         and its documentation.
449         (solib_add): Remove unused target argument.  Remove unused
450         argument in call to update_solib_list.
451         (info_sharedlibrary_command): Remove unused argument in call
452         to update_solib_list.
453         (sharedlibrary_command): Remove unused argument in call to
454         solib_add.
455         (handle_solib_event): Likewise.
456         (reload_shared_libraries): Likewise.
457         * solib.h (solib_add): Remove unused target argument.
458
459 2017-03-20  Andreas Arnez  <arnez@linux.vnet.ibm.com>
460
461         * s390-linux-tdep.c (is_rsi, is_rie): Remove functions.
462         (s390_displaced_step_fixup): Cover relative branches with the
463         default fixup handling.  This fixes lack of support for some
464         relative branch instructions.
465
466 2017-03-17  Simon Marchi  <simon.marchi@polymtl.ca>
467
468         * i386-gnu-nat.c (gnu_fetch_registers, gnu_store_registers): Use
469         ptid from regcache.
470
471 2017-03-17  Simon Marchi  <simon.marchi@polymtl.ca>
472
473         * i386-darwin-nat.c (i386_darwin_fetch_inferior_registers,
474         i386_darwin_store_inferior_registers): Use ptid from regcache.
475
476 2017-03-17  Simon Marchi  <simon.marchi@polymtl.ca>
477
478         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers,
479         i386bsd_store_inferior_registers): Use ptid from regcache.
480
481 2017-03-17  Simon Marchi  <simon.marchi@polymtl.ca>
482
483         * hppa-obsd-nat.c (hppaobsd_fetch_registers,
484         hppaobsd_store_registers): Use ptid from regcache.
485
486 2017-03-17  Simon Marchi  <simon.marchi@polymtl.ca>
487
488         * hppa-nbsd-nat.c (hppanbsd_fetch_registers,
489         hppanbsd_store_registers): Use ptid from regcache.
490
491 2017-03-17  Simon Marchi  <simon.marchi@polymtl.ca>
492
493         * hppa-linux-nat.c (fetch_register, store_register): Use ptid
494         from regcache.  Use get_ptrace_pid.
495
496 2017-03-17  Simon Marchi  <simon.marchi@polymtl.ca>
497
498         * corelow.c (get_core_register_section): Use ptid from regcache,
499         update doc.
500
501 2017-03-17  Simon Marchi  <simon.marchi@polymtl.ca>
502
503         * bsd-uthread.c (bsd_uthread_fetch_registers,
504         bsd_uthread_store_registers): Use ptid from regcache, set and
505         restore inferior_ptid.
506
507 2017-03-17  Simon Marchi  <simon.marchi@polymtl.ca>
508
509         * arm-nbsd-nat.c (fetch_register, fetch_regs, fetch_fp_register,
510         fetch_fp_regs, store_register, store_regs, store_fp_register,
511         store_fp_regs): Use ptid from regcache.
512
513 2017-03-17  Simon Marchi  <simon.marchi@polymtl.ca>
514
515         * arm-linux-nat.c (fetch_fpregs, store_fpregs, fetch_regs,
516         store_regs, fetch_wmmx_regs, store_wmmx_regs, fetch_vfp_regs,
517         store_vfp_regs): Use ptid from regcache.
518
519 2017-03-17  Pedro Alves  <palves@redhat.com>
520
521         PR remote/21188
522         * ser-base.c (ser_base_wait_for): Add comment.
523         (do_ser_base_readchar): Improve comment based on the ser-unix.c's
524         version.
525         * ser-unix.c (hardwire_raw): Remove reference to
526         scb->current_timeout.
527         (wait_for, do_hardwire_readchar, hardwire_readchar): Delete.
528         (hardwire_ops): Install ser_base_readchar instead of
529         hardwire_readchar.
530         * serial.h (struct serial) <current_timeout, timeout_remaining>:
531         Remove fields.
532
533 2017-03-17  Jonah Graham  <jonah@kichwacoders.com>
534
535         PR gdb/19637
536         * python/lib/gdb/printer/bound_registers.py: Add support for
537         Python 3.
538
539 2017-03-16  Andreas Arnez  <arnez@linux.vnet.ibm.com>
540
541         * dwarf2loc.c (indirect_synthetic_pointer): Get data type of
542         pointed-to DIE and pass it to dwarf2_evaluate_loc_desc_full.
543         (dwarf2_evaluate_loc_desc_full): New parameter subobj_type; rename
544         byte_offset to subobj_byte_offset.  Fix the handling of
545         DWARF_VALUE_STACK on big-endian targets when coming via an
546         implicit pointer.
547         (dwarf2_evaluate_loc_desc): Adjust call to
548         dwarf2_evaluate_loc_desc_full.
549         * dwarf2loc.h (dwarf2_fetch_die_type_sect_off): New declaration.
550         * dwarf2read.c (dwarf2_fetch_die_type_sect_off): New function.
551
552 2017-03-16  Yao Qi  <yao.qi@linaro.org>
553
554         * arm-tdep.c (thumb_record_misc): Decode CBNZ, CBZ, REV16,
555         and REVSH instructions.
556
557 2017-03-16  Yao Qi  <yao.qi@linaro.org>
558
559         * arm-tdep.c [GDB_SELF_TEST]: include "selftests.h".
560         (arm_record_test): Declare.
561         (_initialize_arm_tdep) [GDB_SELF_TEST]: call register_self_test.
562         (thumb_record_ld_st_reg_offset): Rewrite the opcode matching to
563         align with the manual.
564         (thumb_record_misc): Adjust the code order to align with the
565         manual.
566         (thumb2_record_decode_insn_handler): Fix instruction matching.
567         (instruction_reader_thumb): New class.
568         (arm_record_test): New function.
569
570 2017-03-16  Yao Qi  <yao.qi@linaro.org>
571
572         * arm-tdep.c (abstract_memory_reader): New class.
573         (instruction_reader): New class.
574         (extract_arm_insn): Add argument 'reader'.  Callers updated.
575         (decode_insn): Likewise.
576
577 2017-03-16  Doug Evans  <dje@google.com>
578
579         * guile/scm-lazy-string.c (lazy_string_smob): Clarify use of LENGTH
580         member.  Change type of TYPE member to SCM.  All uses updated.
581         (lsscm_make_lazy_string_smob): Add assert.
582         (lsscm_make_lazy_string): Flag bad length values.
583         (lsscm_elt_type): New function.
584         (gdbscm_lazy_string_to_value): Rewrite to use
585         lsscm_safe_lazy_string_to_value.
586         (lsscm_safe_lazy_string_to_value): Fix handling of TYPE_CODE_PTR.
587         * guile/scm-value.c (gdbscm_value_to_lazy_string): Flag bad length
588         values.  Fix TYPE_CODE_PTR.  Handle TYPE_CODE_ARRAY.  Handle typedefs
589         in incoming type.
590         * guile/guile-internal.h (tyscm_scm_to_type): Declare.
591         * guile/scm-type.c (tyscm_scm_to_type): New function.
592
593 2017-03-15  Doug Evans  <dje@google.com>
594
595         PR python/17728, python/18439, python/18779
596         * python/py-lazy-string.c (lazy_string_object): Clarify use of LENGTH
597         member.  Change type of TYPE member to PyObject *.  All uses updated.
598         (stpy_convert_to_value): Fix handling of TYPE_CODE_PTR.
599         (gdbpy_create_lazy_string_object): Flag bad length values.
600         Handle TYPE_CODE_ARRAY with possibly different user-provided length.
601         Handle typedefs in incoming type.
602         (stpy_lazy_string_elt_type): New function.
603         (gdbpy_extract_lazy_string): Call it.
604         * python/py-value.c (valpy_lazy_string): Flag bad length values.
605         Fix handling of TYPE_CODE_PTR.  Handle TYPE_CODE_ARRAY.  Handle
606         typedefs in incoming type.
607
608 2017-03-16  Doug Evans  <dje@google.com>
609
610         * guile/guile-internal.h (tyscm_scm_to_type): Declare.
611         * guile/scm-type.c (tyscm_scm_to_type): New function.
612
613 2017-03-16  Jiong Wang  <jiong.wang@arm.com>
614
615         * inf-ptrace.c (inf_ptrace_peek_poke): Change the type to
616         "ULONGEST" for "skip".
617
618 2017-03-14  Andreas Arnez  <arnez@linux.vnet.ibm.com>
619
620         PR gdb/21220
621         * inf-ptrace.c (inf_ptrace_xfer_partial): In "case
622         TARGET_OBJECT_MEMORY", extract the logic for ptrace peek/poke...
623         (inf_ptrace_peek_poke): ...here.  New function.  Now also loop
624         over ptrace peek/poke until end of buffer or error.
625
626 2017-03-14  Simon Marchi  <simon.marchi@ericsson.com>
627
628         * parse.c (length_of_subexp): Make static.
629         * parser-defs.h (length_of_subexp): Remove.
630
631 2017-03-14  Andreas Arnez  <arnez@linux.vnet.ibm.com>
632
633         * linux-nat.c (linux_proc_xfer_partial): Handle write operations
634         as well.
635
636 2017-03-14  Pedro Alves  <palves@redhat.com>
637
638         * cp-name-parser.y (cp_demangled_name_to_comp): Update comment.
639         (main): Use std::unique_ptr.  Remove calls to
640         cp_demangled_name_parse_free.
641
642 2017-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
643
644         * alpha-bsd-nat.c (alphabsd_fetch_inferior_registers,
645         alphabsd_store_inferior_registers): Use regcache->ptid instead
646         of inferior_ptid.
647
648 2017-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
649
650         * aix-thread.c (aix_thread_fetch_registers,
651         aix_thread_store_registers): Use regcache->ptid instead of
652         inferior_ptid.
653
654 2017-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
655
656         * aarch64-linux-nat.c (fetch_gregs_from_thread,
657         store_gregs_to_thread, fetch_fpregs_from_thread,
658         store_fpregs_to_thread): Use regcache->ptid instead of
659         inferior_ptid.
660
661 2017-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
662
663         * amd64-linux-nat.c (amd64_linux_fetch_inferior_registers,
664         amd64_linux_fetch_inferior_registers): Use regcache->ptid
665         instead of inferior_ptid.
666
667 2017-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
668
669         * target.c (target_fetch_registers, target_store_registers): Add
670         assert.
671
672 2017-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
673
674         * regcache.h (regcache_get_ptid): New function.
675         * regcache.c (regcache_get_ptid): New function.
676
677 2017-03-13  Mark Wielaard  <mark@klomp.org>
678
679         * cp-name-parser.y (make_empty): Initialize d_printing to zero.
680
681 2017-03-10  Keith Seitz  <keiths@redhat.com>
682
683         PR c++/8218
684         * c-typeprint.c (cp_type_print_method_args): Skip artificial arguments.
685
686 2017-03-08  Pedro Alves  <palves@redhat.com>
687
688         PR gdb/18360
689         * infrun.c (start_step_over, do_target_resume, resume)
690         (restart_threads): Assert we're not resuming a thread that is
691         meant to be stopped.
692         (infrun_thread_stop_requested_callback): Delete.
693         (infrun_thread_stop_requested): If the thread is internally
694         stopped, queue a pending stop event and clear the thread's
695         inline-frame state.
696         (handle_stop_requested): New function.
697         (handle_syscall_event, handle_inferior_event_1): Use
698         handle_stop_requested.
699         (handle_stop_requested): New function.
700         (handle_signal_stop): Set the thread's stop_signal here instead of
701         at caller.
702         (finish_step_over): Clear step over info unconditionally.
703         (handle_signal_stop): If the user had interrupted the event
704         thread, consider the stop a random signal.
705         (handle_signal_stop) <signal arrived while stepping over
706         breakpoint>: Don't restart threads here.
707         (stop_waiting): Don't clear step-over info here.
708
709 2017-03-08  Pedro Alves  <palves@redhat.com>
710
711         PR 21206
712         * common/gdb_unlinker.h (unlinker::unlinker): Attribute nonnull
713         goes to argument 2, not 1.
714
715 2017-03-08  Pedro Alves  <palves@redhat.com>
716
717         PR cli/21218
718         * top.c (gdb_readline_wrapper): Avoid passing NULL to
719         display_gdb_prompt.
720         (command_line_input): Add comment.
721
722 2017-03-08  Pedro Alves  <palves@redhat.com>
723
724         PR tui/21216
725         * tui/tui-file.c (tui_file::write): New.
726         * tui/tui-file.h (tui_file): Override "write".
727         * tui/tui-io.c (do_tui_putc, update_start_line): New functions,
728         factored out from ...
729         (tui_puts): ... here.
730         (tui_putc): Use them.
731         (tui_write): New function.
732         * tui/tui-io.h (tui_write): Declare.
733
734 2017-03-07  Sergio Durigan Junior  <sergiodj@redhat.com>
735
736         * Makefile.in (SFILES): Replace "environ.c" with
737         "common/environ.c".
738         (HFILES_NO_SRCDIR): Likewise, for "environ.h".
739         * environ.c: Include "common-defs.h" instead of "defs.h.  Moved
740         to...
741         * common/environ.c: ... here.
742         * environ.h: Moved to...
743         * common/environ.h: ... here.
744
745 2017-03-07  Peter Bergner  <bergner@vnet.ibm.com>
746
747         * gdbarch.sh (pstring_ptr): New static function.
748         (gdbarch_disassembler_options): Use it.
749         (gdbarch_verify_disassembler_options): Print valid_disassembler_options,
750         not valid_disassembler_option->name.
751         * gdbarch.c: Regenerate.
752
753 2017-03-07  Peter Bergner  <bergner@vnet.ibm.com>
754
755         * config/powerpc/ppc64-linux.mh (MH_CFLAGS): Delete.
756
757 2017-03-07  Pedro Alves  <palves@redhat.com>
758
759         * tui/tui-regs.c (tui_restore_gdbout): Don't delete gdb_stdout.
760
761 2017-03-07  Walfred Tedeschi  <walfred.tedeschi@intel.com>
762
763         * i387-tdep.h (i387_reset_bnd_regs): Add function definition.
764         * i387-tdep.c (i387_reset_bnd_regs): Add function implementation.
765         * i386-tdep.c (i386_push_dummy_call): Call i387_reset_bnd_regs.
766         * amd64-tdep.c (amd64_push_dummy_call): Call i387_reset_bnd_regs.
767
768 2017-03-06  Simon Marchi  <simon.marchi@ericsson.com>
769
770         * xtensa-linux-nat.c (fetch_gregs): Remove const.
771
772 2017-03-03  Simon Marchi  <simon.marchi@ericsson.com>
773
774         * remote.c (remote_add_target_side_commands): Use range-based
775         for loop.
776
777 2017-03-03  Yao Qi  <yao.qi@linaro.org>
778
779         PR gdb/21165
780         * ada-valprint.c (ada_val_print_ref): Call value_fetch_lazy if
781         value is lazy.
782         * valprint.c (common_val_print): Likewise.
783
784 2017-02-28  Peter Bergner  <bergner@vnet.ibm.com>
785
786         * NEWS: Mention new set/show disassembler-options commands.
787         * doc/gdb.texinfo: Document new set/show disassembler-options commands.
788         * disasm.c: Include "arch-utils.h", "gdbcmd.h" and "safe-ctype.h".
789         (prospective_options): New static variable.
790         (gdb_disassembler::gdb_disassembler): Initialize
791         m_di.disassembler_options.
792         (gdb_buffered_insn_length_init_dis): Initilize di->disassembler_options.
793         (get_disassembler_options): New function.
794         (set_disassembler_options): Likewise.
795         (set_disassembler_options_sfunc): Likewise.
796         (show_disassembler_options_sfunc): Likewise.
797         (disassembler_options_completer): Likewise.
798         (_initialize_disasm): Likewise.
799         * disasm.h (get_disassembler_options): New prototype.
800         (set_disassembler_options): Likewise.
801         * gdbarch.sh (gdbarch_disassembler_options): New variable.
802         (gdbarch_verify_disassembler_options): Likewise.
803         * gdbarch.c: Regenerate.
804         * gdbarch.h: Likewise.
805         * arm-tdep.c (num_disassembly_options): Delete.
806         (set_disassembly_style): Likewise.
807         (arm_disassembler_options): New static variable.
808         (set_disassembly_style_sfunc): Convert short style name into long
809         option name.  Call set_disassembler_options.
810         (show_disassembly_style_sfunc): New function.
811         (arm_gdbarch_init): Call set_gdbarch_disassembler_options and
812         set_gdbarch_verify_disassembler_options.
813         (_initialize_arm_tdep): Delete regnames variable and update callers.
814         (arm_disassembler_options): Initialize.
815         (disasm_options): New variable.
816         (num_disassembly_options): Rename from this...
817         (num_disassembly_styles): ...to this.  Compute by scanning through
818         disasm_options.
819         (valid_disassembly_styles): Initialize using disasm_options.
820         Remove calls to parse_arm_disassembler_option, get_arm_regnames and
821         set_arm_regname_option.
822         Pass show_disassembly_style_sfunc to the "disassembler" setshow command.
823         * rs6000-tdep.c (powerpc_disassembler_options): New static variable.
824         (rs6000_gdbarch_init): Call set_gdbarch_disassembler_options and
825         set_gdbarch_verify_disassembler_options.
826         * s390-tdep.c (s390_disassembler_options): New static variable.
827         (s390_gdbarch_init):all set_gdbarch_disassembler_options and
828         set_gdbarch_verify_disassembler_options.
829
830 2017-02-27  Simon Marchi  <simon.marchi@ericsson.com>
831
832         * remote.c (remote_add_target_side_condition): Remove "struct"
833         keyword from range-based for loop.
834
835 2017-02-27  Simon Marchi  <simon.marchi@ericsson.com>
836
837         * remote.c (remote_add_target_side_condition): Use range-based
838         for loop.  Update comment.
839
840 2017-02-27  Yao Qi  <yao.qi@linaro.org>
841
842         * f-typeprint.c (f_print_type): Check "varstring" is empty first.
843
844 2017-02-26  Alan Hayward  <alan.hayward@arm.com>
845
846         * regcache.c (regcache_raw_update): New function.
847         (regcache_raw_read): Move code to regcache_raw_update.
848         * regcache.h (regcache_raw_update): New declaration.
849         * remote.c (remote_prepare_to_store): Call regcache_raw_update.
850
851 2017-02-26  Jan Kratochvil  <jan.kratochvil@redhat.com>
852
853         * dwarf2read.c (create_debug_type_hash_table): Initialize
854         header.signature and header.type_offset_in_tu.
855
856 2017-02-24  Pedro Alves  <palves@redhat.com>
857
858         * symtab.c (make_file_symbol_completion_list_1): Use
859         add_symtab_completions.
860
861 2017-02-24  Alan Hayward  <alan.hayward@arm.com>
862
863         * stack.c (frame_info): Use frame_unwind_register_value to avoid buf.
864
865 2017-02-24  Alan Hayward  <alan.hayward@arm.com>
866
867         * i386-tdep.c (i386_pseudo_register_read_into_value): Use
868         I386_MAX_REGISTER_SIZE.
869         (i386_pseudo_register_write): Likewise.
870         (i386_process_record): Likewise.
871         * i387-tdep.c (i387_supply_xsave): Likewise.
872         * m68k-linux-nat.c (fetch_register): Use M68K_MAX_REGISTER_SIZE.
873         (store_register): Likewise.
874
875 2017-02-23  Pedro Alves  <palves@redhat.com>
876
877         * ada-lang.c: Include "common/function-view.h".
878         (ada_iterate_over_symbols): Adjust to use function_view as
879         callback type.
880         (struct add_partial_datum, ada_complete_symbol_matcher): Delete.
881         (ada_make_symbol_completion_list): Use a lambda.
882         (ada_exc_search_name_matches): Delete.
883         (name_matches_regex): New.
884         (ada_add_global_exceptions): Use a lambda and name_matches_regex.
885         * compile/compile-c-support.c: Include "common/function-view.h".
886         (print_one_macro): Change prototype to accept a ui_file pointer.
887         (write_macro_definitions): Use a lambda.
888         * dwarf2read.c: Include "common/function-view.h".
889         (dw2_map_expand_apply, dw2_map_symtabs_matching_filename)
890         (dw2_expand_symtabs_matching): Adjust to use function_view as
891         callback type.
892         * language.h: Include "common/function-view.h".
893         (struct language_defn) <la_iterate_over_symbols>: Adjust to use
894         function_view as callback type.
895         (LA_ITERATE_OVER_SYMBOLS): Remove DATA parameter.
896         * linespec.c: Include "common/function-view.h".
897         (collect_info::add_symbol): New method.
898         (struct symbol_and_data_callback, iterate_inline_only, struct
899         symbol_matcher_data, iterate_name_matcher): Delete.
900         (iterate_over_all_matching_symtabs): Adjust to use function_view
901         as callback type and lambdas.
902         (iterate_over_file_blocks): Adjust to use function_view as
903         callback type.
904         (decode_compound_collector): Now a class with private fields.
905         (decode_compound_collector::release_symbols): New method.
906         (collect_one_symbol): Rename to...
907         (decode_compound_collector::operator()): ... this and adjust.
908         (lookup_prefix_sym): decode_compound_collector construction bits
909         move to decode_compound_collector ctor.  Pass the
910         decode_compound_collector object directly as callback.  Remove
911         cleanups and use decode_compound_collector::release_symbols
912         instead.
913         (symtab_collector): Now a class with private fields.
914         (symtab_collector::release_symtabs): New method.
915         (add_symtabs_to_list): Rename to...
916         (symtab_collector::operator()): ... this and adjust.
917         (collect_symtabs_from_filename): symtab_collector construction
918         bits move to symtab_collector ctor.  Pass the symtab_collector
919         object directly as callback.  Remove cleanups and use
920         symtab_collector::release_symtabs instead.
921         (collect_symbols): Delete.
922         (add_matching_symbols_to_info): Use lambdas.
923         * macrocmd.c (print_macro_callback): Delete.
924         (info_macro_command): Use a lambda.
925         (info_macros_command): Pass print_macro_definition as callable
926         directly.
927         (print_one_macro): Remove 'ignore' parameter.
928         (macro_list_command): Adjust.
929         * macrotab.c (macro_for_each_data::fn): Now a function_view.
930         (macro_for_each_data::user_data): Delete field.
931         (foreach_macro): Adjust to call the function_view.
932         (macro_for_each): Adjust to use function_view as callback type.
933         (foreach_macro_in_scope): Adjust to call the function_view.
934         (macro_for_each_in_scope): Adjust to use function_view as callback
935         type.
936         * macrotab.h: Include "common/function-view.h".
937         (macro_callback_fn): Declare a prototype instead of a pointer.
938         Remove "user_data" parameter.
939         (macro_for_each, macro_for_each_in_scope): Adjust to use
940         function_view as callback type.
941         * psymtab.c (partial_map_expand_apply)
942         (psym_map_symtabs_matching_filename, recursively_search_psymtabs):
943         Adjust to use function_view as callback type and to return bool.
944         (psym_expand_symtabs_matching): Adjust to use function_view as
945         callback types.
946         * symfile-debug.c (debug_qf_map_symtabs_matching_filename): Adjust
947         to use function_view as callback type and to return bool.
948         (debug_qf_expand_symtabs_matching): Adjust to use function_view as
949         callback types.
950         * symfile.c (expand_symtabs_matching): Adjust to use function_view
951         as callback types.
952         * symfile.h: Include "common/function-view.h".
953         (expand_symtabs_file_matcher_ftype)
954         (expand_symtabs_symbol_matcher_ftype)
955         (expand_symtabs_exp_notify_ftype): Remove "data" parameter and
956         return bool.
957         (quick_symbol_functions::map_symtabs_matching_filename)
958         (quick_symbol_functions::expand_symtabs_matching): Adjust to use
959         function_view as callback type and return bool.
960         (expand_symtabs_matching): Adjust to use function_view as callback
961         type.
962         (maintenance_expand_name_matcher)
963         (maintenance_expand_file_matcher): Delete.
964         (maintenance_expand_symtabs): Use lambdas.
965         * symtab.c (iterate_over_some_symtabs): Adjust to use
966         function_view as callback types and return bool.
967         (iterate_over_symtabs): Likewise.  Use unique_xmalloc_ptr instead
968         of a cleanup.
969         (lookup_symtab_callback): Delete.
970         (lookup_symtab): Use a lambda.
971         (iterate_over_symbols): Adjust to use function_view as callback
972         type.
973         (struct search_symbols_data, search_symbols_file_matches)
974         (search_symbols_name_matches): Delete.
975         (search_symbols): Use a pair of lambdas.
976         (struct add_name_data, add_macro_name, symbol_completion_matcher)
977         (symtab_expansion_callback): Delete.
978         (default_make_symbol_completion_list_break_on_1): Use lambdas.
979         * symtab.h: Include "common/function-view.h".
980         (iterate_over_some_symtabs): Adjust to use function_view as
981         callback type and return bool.
982         (iterate_over_symtabs): Adjust to use function_view as callback
983         type.
984         (symbol_found_callback_ftype): Remove 'data' parameter and return
985         bool.
986         (iterate_over_symbols): Adjust to use function_view as callback
987         type.
988
989 2017-02-23  Pedro Alves  <palves@redhat.com>
990
991         * Makefile.in (SUBDIR_UNITTESTS_SRCS, SUBDIR_UNITTESTS_OBS): New.
992         (%.o) <unittests/%.c>: New pattern.
993         * configure.ac ($development): Add $(SUBDIR_UNITTESTS_OBS) to
994         CONFIG_OBS, and $(SUBDIR_UNITTESTS_SRCS) to CONFIG_SRCS.
995         * common/function-view.h: New file.
996         * unittests/function-view-selftests.c: New file.
997         * configure: Regenerate.
998
999 2017-02-23  Simon Marchi  <simon.marchi@ericsson.com>
1000
1001         * bsd-uthread.c (bsd_uthread_thread_alive): Use ptid instead of
1002         inferior_ptid.
1003         * go32-nat.c (go32_thread_alive): Likewise.
1004
1005 2017-02-23  Yao Qi  <yao.qi@linaro.org>
1006
1007         * varobj-iter.h (varobj_iter_delete): Call xfree instead of
1008         delete.
1009
1010 2017-02-23  Yao Qi  <yao.qi@linaro.org>
1011
1012         * varobj.c (varobj_clear_saved_item): Use delete instead of
1013         xfree.
1014         (update_dynamic_varobj_children): Likewise.
1015
1016 2017-02-21  Jan Kratochvil  <jan.kratochvil@redhat.com>
1017
1018         * dwarf2read.c (dwarf2_record_block_ranges): Add forgotten BASEADDR.
1019
1020 2017-02-21  Simon Marchi  <simon.marchi@ericsson.com>
1021
1022         * common/enum-flags.h (enum_flags::enum_flags): Initialize
1023         m_enum_value to 0 in default constructor.
1024
1025 2017-02-21  Edjunior Barbosa Machado  <emachado@linux.vnet.ibm.com>
1026
1027         * rs6000-tdep.c (LOAD_AND_RESERVE_MASK): Rename from LWARX_MASK.
1028         (STORE_CONDITIONAL_MASK): Rename from STWCX_MASK.
1029         (LBARX_INSTRUCTION, LHARX_INSTRUCTION, LQARX_INSTRUCTION,
1030         STBCX_INSTRUCTION, STHCX_INSTRUCTION, STQCX_INSTRUCTION): New defines.
1031         (IS_LOAD_AND_RESERVE_INSN, IS_STORE_CONDITIONAL_INSN): New macros.
1032         (ppc_displaced_step_copy_insn): Use IS_LOAD_AND_RESERVE_INSN.
1033         (ppc_deal_with_atomic_sequence): Use IS_LOAD_AND_RESERVE_INSN and
1034         IS_STORE_CONDITIONAL_INSN.
1035
1036 2017-02-21  Jan Kratochvil  <jan.kratochvil@redhat.com>
1037
1038         * dwarf2_rnglists_process: Initialize range_beginning and range_end.
1039
1040 2017-02-20  Jan Kratochvil  <jan.kratochvil@redhat.com>
1041
1042         * NEWS (Changes since GDB 7.12): Add DWARF-5.
1043
1044 2017-02-20  Jan Kratochvil  <jan.kratochvil@redhat.com>
1045
1046         * dwarf2read.c (skip_one_die, read_attribute_value)
1047         (dwarf2_const_value_attr, dump_die_shallow)
1048         (dwarf2_get_attr_constant_value, dwarf2_fetch_constant_bytes)
1049         (skip_form_bytes, attr_form_is_constant): Handle DW_FORM_data16.
1050
1051 2017-02-20  Jan Kratochvil  <jan.kratochvil@redhat.com>
1052
1053         * dwarf2read.c (read_file_scope): Rename DW_MACRO_GNU_*.
1054         (dwarf_parse_macro_header): Accept DWARF version 5.
1055         (dwarf_decode_macro_bytes, dwarf_decode_macros): Rename DW_MACRO_GNU_*.
1056
1057 2017-02-20  Jan Kratochvil  <jan.kratochvil@redhat.com>
1058
1059         * block.c (call_site_for_pc): Rename DW_OP_GNU_*, DW_TAG_GNU_* and
1060         DW_AT_GNU_*.
1061         * common/common-exceptions.h (enum errors): Likewise.
1062         * dwarf2-frame.c (class dwarf_expr_executor): Likewise.
1063         * dwarf2expr.c (dwarf_block_to_dwarf_reg)
1064         (dwarf_expr_context::execute_stack_op): Likewise.
1065         * dwarf2expr.h (struct dwarf_expr_context, struct dwarf_expr_piece):
1066         Likewise.
1067         * dwarf2loc.c (dwarf_evaluate_loc_desc::get_base_type)
1068         (dwarf_evaluate_loc_desc::push_dwarf_reg_entry_value)
1069         (show_entry_values_debug, call_site_to_target_addr)
1070         (func_addr_to_tail_call_list, func_verify_no_selftailcall)
1071         (dwarf_expr_reg_to_entry_parameter, dwarf_entry_parameter_to_value)
1072         (entry_data_value_free_closure, value_of_dwarf_reg_entry)
1073         (value_of_dwarf_block_entry, indirect_pieced_value)
1074         (symbol_needs_eval_context::push_dwarf_reg_entry_value):
1075         (disassemble_dwarf_expression): Likewise.
1076         * dwarf2read.c (process_die, inherit_abstract_dies)
1077         (read_call_site_scope): Likewise.
1078         * gdbtypes.h (struct func_type, struct call_site_parameter)
1079         (struct call_site): Likewise.
1080         * stack.c (read_frame_arg): Likewise.
1081         * std-operator.def (OP_VAR_ENTRY_VALUE): Likewise.
1082
1083 2017-02-20  Jan Kratochvil  <jan.kratochvil@redhat.com>
1084
1085         * defs.h (read_unsigned_leb128): New declaration.
1086         * dwarf2loc.c (decode_debug_loclists_addresses): New function.
1087         (decode_debug_loc_dwo_addresses): Update DEBUG_LOC_* to DW_LLE_*.
1088         (dwarf2_find_location_expression): Call also
1089         decode_debug_loclists_addresses.  Handle DWARF-5 ULEB128 length.
1090         * dwarf2loc.h (dwarf2_version): New declaration.
1091         * dwarf2read.c (struct dwarf2_per_objfile): Add loclists, line_str,
1092         rnglists.
1093         (dwarf2_elf_names): Add .debug_loclists, .debug_line_str,
1094         .debug_rnglists.
1095         (struct dwop_section_names): Add loclists_dwo.
1096         (dwop_section_names): Add .debug_loclists.dwo.
1097         (struct comp_unit_head): Add unit_type, signature, type_offset_in_tu.
1098         (struct dwarf2_per_cu_data): Add dwarf_version.
1099         (struct dwo_sections): Add loclists.
1100         (struct attr_abbrev): Add implicit_const.
1101         (read_indirect_line_string): New declaration.
1102         (read_unsigned_leb128): Delete declaration.
1103         (rcuh_kind): New definition.
1104         (read_and_check_comp_unit_head): Change parameter
1105         is_debug_types_section to section_kind.
1106         (dwarf2_locate_sections): Handle loclists, line_str and rnglists.
1107         (read_comp_unit_head): Change parameter abfd to section, add parameter
1108         section_kind.  Handle DWARF-5.
1109         (error_check_comp_unit_head): Accept also DWARF version 5.
1110         (read_and_check_comp_unit_head): Change parameter
1111         is_debug_types_section to section_kind.
1112         (read_and_check_type_unit_head): Delete function.
1113         (read_abbrev_offset): Handle DWARF-5.
1114         (create_debug_type_hash_table): Add parameter section_kind.  Process
1115         only DW_UT_type.  Use signature and type_offset_in_tu from struct
1116         comp_unit_head.
1117         (create_debug_types_hash_table): Update create_debug_type_hash_table
1118         caller.
1119         (create_all_type_units): Call create_debug_type_hash_table.
1120         (read_cutu_die_from_dwo, init_cutu_and_read_dies): Change
1121         read_and_check_type_unit_head caller to read_and_check_comp_unit_head
1122         caller.
1123         (skip_one_die): Handle DW_FORM_implicit_const.
1124         (dwarf2_rnglists_process): New function.
1125         (dwarf2_ranges_process): Call dwarf2_rnglists_process for DWARF-5.
1126         (abbrev_table_read_table): Handle DW_FORM_implicit_const.
1127         (read_attribute_value): Handle DW_FORM_implicit_const,
1128         DW_FORM_line_strp.
1129         (read_attribute): Handle DW_FORM_implicit_const.
1130         (read_indirect_string_at_offset_from): New function from
1131         read_indirect_string_at_offset.
1132         (read_indirect_string_at_offset): Call
1133         read_indirect_string_at_offset_from.
1134         (read_indirect_line_string_at_offset): New function.
1135         (read_indirect_string): New function comment.
1136         (read_indirect_line_string): New function.
1137         (read_unsigned_leb128): Make it global.
1138         (dwarf2_string_attr): Handle DWARF-5.
1139         (add_include_dir_stub, read_formatted_entries): New functions.
1140         (dwarf_decode_line_header, dump_die_shallow, cu_debug_loc_section):
1141         Handle DWARF-5.
1142         (per_cu_header_read_in): Update read_comp_unit_head caller.
1143         (dwarf2_version): New function.
1144         * symfile.h (struct dwarf2_debug_sections): Add loclists, line_str and
1145         rnglists.
1146         * xcoffread.c (dwarf2_xcoff_names): Update struct dwarf2_debug_sections
1147         fields.
1148
1149 2017-02-20  Jan Kratochvil  <jan.kratochvil@redhat.com>
1150
1151         * dwarf2read.c (abbrev_table_read_table): Read the data only once.
1152
1153 2017-02-20  Jan Kratochvil  <jan.kratochvil@redhat.com>
1154
1155         * dwarf2read.c (dwarf2_ranges_process): New function from
1156         dwarf2_ranges_read.
1157         (dwarf2_ranges_read, dwarf2_record_block_ranges): Use
1158         dwarf2_ranges_process.
1159
1160 2017-02-20  Jan Kratochvil  <jan.kratochvil@redhat.com>
1161
1162         * dwarf2read.c (create_debug_type_hash_table): New function from
1163         create_debug_types_hash_table.
1164         (create_debug_types_hash_table): Call create_debug_type_hash_table.
1165         (create_all_type_units, open_and_init_dwo_file): Update
1166         create_debug_types_hash_table callers.
1167
1168 2017-02-20  Sergio Durigan Junior  <sergiodj@redhat.com>
1169
1170         PR gdb/16188
1171         * fork-child.c (trace_start_error): Fix thinko.  va_end should
1172         refer to 'ap', not 'args'.
1173
1174 2017-02-20  Sergio Durigan Junior  <sergiodj@redhat.com>
1175             Pedro Alves  <palves@redhat.com>
1176
1177         PR gdb/16188
1178         * darwin-nat.c (darwin_ptrace_me): Check if calls to system
1179         calls succeeded.
1180         * fork-child.c (trace_start_error): New function.
1181         (trace_start_error_with_name): Likewise.
1182         * gnu-nat.c (gnu_ptrace_me): Check if call to PTRACE succeeded.
1183         * inf-ptrace.c (inf_ptrace_me): Likewise.
1184         * inferior.h (trace_start_error): New prototype.
1185         (trace_start_error_with_name): Likewise.
1186
1187 2017-02-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1188
1189         PR gdb/21164
1190         * psymtab.c (maintenance_print_psymbols): Verify if 'argv' is not
1191         NULL before using it.
1192         * symmisc.c (maintenance_print_symbols): Likewise.
1193         (maintenance_print_msymbols): Likewise.
1194
1195 2017-02-14  Tim Wiederhake  <tim.wiederhake@intel.com>
1196
1197         * NEWS: Add record Python bindings entry.
1198
1199 2017-02-14  Tim Wiederhake  <tim.wiederhake@intel.com>
1200
1201         * Makefile.in (SUBDIR_PYTHON_OBS): Add py-record-btrace.o,
1202         py-record-full.o.
1203         (SUBDIR_PYTHON_SRCS): Add py-record-btrace.c, py-record-full.c.
1204         * python/py-record-btrace.c, python/py-record-btrace.h,
1205         python/py-record-full.c, python/py-record-full.h: New file.
1206         * python/py-record.c: Add include for py-record-btrace.h and
1207         py-record-full.h.
1208         (recpy_method, recpy_format, recpy_goto, recpy_replay_position,
1209         recpy_instruction_history, recpy_function_call_history, recpy_begin,
1210         recpy_end): Use functions from py-record-btrace.c and py-record-full.c.
1211         * python/python-internal.h (PyInt_FromSsize_t, PyInt_AsSsize_t):
1212         New definition.
1213         (gdbpy_initialize_btrace): New export.
1214         * python/python.c (_initialize_python): Add gdbpy_initialize_btrace.
1215
1216 2017-02-14  Tim Wiederhake  <tim.wiederhake@intel.com>
1217
1218         * Makefile.in (SUBDIR_PYTHON_OBS): Add python/py-record.o.
1219         (SUBDIR_PYTHON_SRCS): Add python/py-record.c.
1220         * python/py-record.c: New file.
1221         * python/python-internal.h (gdbpy_start_recording,
1222         gdbpy_current_recording, gdpy_stop_recording,
1223         gdbpy_initialize_record): New export.
1224         * python/python.c (_initialize_python): Add gdbpy_initialize_record.
1225         (python_GdbMethods): Add gdbpy_start_recording,
1226         gdbpy_current_recording and gdbpy_stop_recording.
1227
1228 2017-02-14  Tim Wiederhake  <tim.wiederhake@intel.com>
1229
1230         * record-btrace.c (record_btrace_record_method): New function.
1231         (init_record_btrace_ops): Initialize to_record_method.
1232         * record-full.c (record_full_record_method): New function.
1233         (init_record_full_ops, init_record_full_core_ops): Add
1234         record_full_record_method.
1235         * record.h (enum record_method): New enum.
1236         * target-debug.h (target_debug_print_enum_record_method: New define.
1237         * target-delegates.c: Regenerate.
1238         * target.c (target_record_method): New function.
1239         * target.h: Include record.h.
1240         (struct target_ops) <to_record_method>: New field.
1241         (target_record_method): New export.
1242
1243 2017-02-14  Tim Wiederhake  <tim.wiederhake@intel.com>
1244
1245         * record.h (record_start, record_stop): New export.
1246         * record.c (record_start, record_stop): New function.
1247
1248 2017-02-14  Tim Wiederhake  <tim.wiederhake@intel.com>
1249
1250         * btrace.c (btrace_fetch): Copy function call segments pointer
1251         into a vector.
1252         (btrace_clear): Clear the vector.
1253         (btrace_find_insn_by_number): Use binary search to find the correct
1254         function call segment.
1255         * btrace.h (brace_fun_p): New typedef.
1256         (struct btrace_thread_info) <functions>: New field.
1257
1258 2017-02-14  Tim Wiederhake  <tim.wiederhake@intel.com>
1259
1260         * record-btrace.c (btrace_ui_out_decode_error): Move most of it ...
1261         * btrace.c (btrace_decode_error): ... here.  New function.
1262         * btrace.h (btrace_decode_error): New export.
1263
1264 2017-02-14  Tim Wiederhake  <tim.wiederhake@intel.com>
1265
1266         * btrace.c (ftrace_call_num_insn, btrace_insn_get_error): New function.
1267         (ftrace_new_function, btrace_insn_number, btrace_insn_cmp,
1268         btrace_find_insn_by_number): Remove special case for gaps.
1269         * btrace.h (btrace_insn_get_error): New export.
1270         (btrace_insn_number, btrace_find_insn_by_number): Adjust comment.
1271         * record-btrace.c (btrace_insn_history): Print number for gaps.
1272         (record_btrace_info, record_btrace_goto): Handle gaps.
1273
1274 2017-02-14  Tom Tromey  <tom@tromey.com>
1275
1276         PR python/13598:
1277         * python/python.c (gdbpy_before_prompt_hook): Emit before_prompt
1278         event.
1279         * python/py-evts.c (gdbpy_initialize_py_events): Add
1280         before_prompt registry.
1281         * python/py-events.h (events_object) <before_prompt>: New field.
1282
1283 2017-02-14  Markus Metzger  <markus.t.metzger@intel.com>
1284
1285         * btrace.c (ftrace_new_switch): Preserve up link and flags.
1286
1287 2017-02-13  Luis Machado  <lgustavo@codesourcery.com>
1288
1289         * symfile (_initialize_symfile): Add usage text to the load command's
1290         help text.
1291
1292 2017-02-10  Simon Marchi  <simon.marchi@ericsson.com>
1293
1294         * utils.c (defaulted_query): Don't query on secondary UIs.
1295
1296 2017-02-10  Tom Tromey  <tom@tromey.com>
1297
1298         * rust-lang.c (rust_get_disr_info): Remove unused variable.
1299
1300 2017-02-10  Tom Tromey  <tom@tromey.com>
1301
1302         * python/py-value.c (valpy_richcompare_throw): Remove unnecessary
1303         "cleanup" local.
1304         * python/py-type.c (typy_legacy_template_argument): Remove
1305         unnecessary "cleanup" local.
1306
1307 2017-02-10  Tom Tromey  <tom@tromey.com>
1308
1309         * python/python.c (do_start_initialization): New function, from
1310         _initialize_python.
1311         (_initialize_python): Call do_start_initialization.
1312         * python/py-linetable.c (ltpy_iternext): Use explicit returns, not
1313         goto.
1314
1315 2017-02-10  Tom Tromey  <tom@tromey.com>
1316
1317         * python/py-prettyprint.c (pretty_print_one_value): Use
1318         gdbpy_ref.
1319
1320 2017-02-10  Tom Tromey  <tom@tromey.com>
1321
1322         * python/py-cmd.c (cmdpy_destroyer): Use gdbpy_ref.
1323         * python/py-breakpoint.c (gdbpy_breakpoint_deleted): Use
1324         gdbpy_ref.
1325         * python/py-type.c (field_new): Use gdbpy_ref.
1326         * python/py-symtab.c (symtab_and_line_to_sal_object): Use
1327         gdbpy_ref.
1328         * python/py-progspace.c (pspy_new): Use gdbpy_ref.
1329         (py_free_pspace): Likewise.
1330         (pspace_to_pspace_object): Likewise.
1331         * python/py-objfile.c (objfpy_new): Use gdbpy_ref.
1332         (py_free_objfile): Likewise.
1333         (objfile_to_objfile_object): Likewise.
1334         * python/py-inferior.c (delete_thread_object): Use
1335         gdbpy_ref.
1336         (infpy_read_memory): Likewise.
1337         (py_free_inferior): Likewise.
1338         * python/py-evtregistry.c (create_eventregistry_object): Use
1339         gdbpy_ref.
1340         * python/py-event.c (create_event_object): Use gdbpy_ref.
1341
1342 2017-02-10  Tom Tromey  <tom@tromey.com>
1343
1344         * python/py-ref.h (gdbpy_ref_policy): Now a template.
1345         (gdbpy_ref): Now a template; allow subclasses of PyObject to be
1346         used.
1347         * python/py-arch.c, python/py-bpevent.c, python/py-breakpoint.c,
1348         python/py-cmd.c, python/py-continueevent.c, python/py-event.c,
1349         python/py-exitedevent.c, python/py-finishbreakpoint.c,
1350         python/py-framefilter.c, python/py-function.c,
1351         python/py-inferior.c, python/py-infevents.c,
1352         python/py-linetable.c, python/py-newobjfileevent.c,
1353         python/py-param.c, python/py-prettyprint.c, python/py-ref.h,
1354         python/py-signalevent.c, python/py-stopevent.c,
1355         python/py-symbol.c, python/py-threadevent.c, python/py-type.c,
1356         python/py-unwind.c, python/py-utils.c, python/py-value.c,
1357         python/py-varobj.c, python/py-xmethods.c, python/python.c,
1358         varobj.c: Change gdbpy_ref to gdbpy_ref<>.
1359
1360 2017-02-10  Tom Tromey  <tom@tromey.com>
1361
1362         * ui-out.h (ui_out_emit_type): New class.
1363         (ui_out_emit_tuple, ui_out_emit_list): New typedefs.
1364         * python/py-framefilter.c (py_print_single_arg): Use gdb::optional
1365         and ui_out_emit_tuple.
1366         (enumerate_locals): Likewise.
1367         (py_mi_print_variables, py_print_locals, py_print_args): Use
1368         ui_out_emit_list.
1369         (py_print_frame): Use gdb::optional, ui_out_emit_tuple,
1370         ui_out_emit_list.
1371         * common/gdb_optional.h: New file.
1372
1373 2017-02-10  Martin Galvan  <martingalvan@sourceware.org>
1374
1375         * MAINTAINERS (Write After Approval): Update my e-mail address.
1376
1377 2017-02-10  Martin Galvan  <martingalvan@sourceware.org>
1378
1379         PR gdb/21122
1380         * breakpoint.c (_initialize_breakpoint): Update the help description
1381         of the 'commands' command to indicate that it takes a list argument.
1382
1383 2017-02-09  Simon Marchi  <simon.marchi@ericsson.com>
1384
1385         * interps.c (current_interp_set_logging): Remove "return".
1386
1387 2017-02-09  Gary Benson  <gbenson@redhat.com>
1388
1389         * symtab.c (add_symtab_completions): Prevent NULL pointer
1390         dereference.
1391
1392 2017-02-08  Pedro Alves  <palves@redhat.com>
1393
1394         * interps.c (interp::interp): Remove reference to quiet_p.
1395         (interp_set): Make static.  Remove dead "Switching to" output
1396         code.
1397         (interp_quiet_p, interp_set_quiet): Delete.
1398         (interpreter_exec_cmd): Don't set the interpreter quiet.
1399         * interps.h (interp_quiet_p): Make static.
1400         (class interp) <quiet_p>: Remove field
1401
1402 2017-02-08  Jerome Guitton  <guitton@adacore.com>
1403
1404         * cli/cli-decode.c (find_command_name_length): Make it extern.
1405         * cli/cli-decode.h (find_command_name_length): Declare.
1406         * cli/cli-script.c (command_name_equals, line_first_arg):
1407         New functions.
1408         (process_next_line): Use cli-decode to parse command names.
1409         (build_command_line): Make args a constant pointer.
1410
1411 2017-02-08  Jerome Guitton  <guitton@adacore.com>
1412
1413         * cli-decode.c (lookup_cmd_1, lookup_cmd_composition):
1414         Remove case-insensitive search.
1415
1416 2017-02-07  Jose E. Marchesi  <jose.marchesi@oracle.com>
1417
1418         * sparc-tdep.c (sparc32_gdbarch_init): Do not place a + operator
1419         at the end of the line.  Avoids an ARI warning.
1420
1421 2017-02-06  Luis Machado  <lgustavo@codesourcery.com>
1422
1423         * NEWS: Mention support for record/replay of Intel 64 rdrand and
1424         rdseed instructions.
1425         i386-tdep.c (i386_process_record): Handle Intel 64 rdrand and rseed.
1426
1427 2017-02-06  Ivo Raisr  <ivo.raisr@oracle.com>
1428
1429         PR tdep/20936
1430         Provide and use sparc32 and sparc64 target description XML files.
1431         * features/sparc/sparc32-cp0.xml, features/sparc/sparc32-cpu.xml,
1432         features/sparc/sparc32-fpu.xml: New files for sparc 32-bit.
1433         * features/sparc/sparc64-cp0.xml, features/sparc/sparc64-cpu.xml,
1434         features/sparc/sparc64-fpu.xml: New files for sparc 64-bit.
1435         * features/sparc/sparc32-solaris.xml: New file.
1436         * features/sparc/sparc64-solaris.xml: New file.
1437         * features/sparc/sparc32-solaris.c: Generated.
1438         * features/sparc/sparc64-solaris.c: Generated.
1439         * sparc-tdep.h: Account for differences in target descriptions.
1440         * sparc-tdep.c (sparc32_register_name): Use target provided registers.
1441         (sparc32_register_type): Use target provided registers.
1442         (validate_tdesc_registers): New function.
1443         (sparc32_gdbarch_init): Use tdesc_has_registers.
1444         Set pseudoregister functions.
1445         * sparc64-tdep.c (sparc64_register_name): Use target provided registers.
1446         (sparc64_register_type): Use target provided registers.
1447         (sparc64_init_abi): Set pseudoregister functions.
1448
1449 2017-02-03  Tom Tromey  <tom@tromey.com>
1450
1451         PR rust/21097:
1452         * rust-lang.c (rust_print_type) <TYPE_CODE_UNION>: Handle enums
1453         with a single member.
1454
1455 2017-02-03  Pedro Alves  <palves@redhat.com>
1456
1457         * cli/cli-interp.c (cli_interp_base::cli_interp_base)
1458         (cli_interp_base::~cli_interp_base): New.
1459         (cli_interp): New struct.
1460         (as_cli_interp): Cast the interp itself to cli_interp.
1461         (cli_interpreter_pre_command_loop): Rename to ...
1462         (cli_interp_base::pre_command_loop): ... this.  Remove 'self'
1463         parameter.
1464         (cli_interpreter_init): Rename to ...
1465         (cli_interp::init): ... this.  Remove 'self' parameter.  Use
1466         boolean.  Make extern.
1467         (cli_interpreter_resume): Rename to ...
1468         (cli_interp::resume): ... this.  Remove 'data' parameter.  Make
1469         extern.
1470         (cli_interpreter_suspend): Rename to ...
1471         (cli_interp::suspend): ... this.  Remove 'data' parameter.  Make
1472         extern.
1473         (cli_interpreter_exec): Rename to ...
1474         (cli_interp::exec): ... this.  Remove 'data' parameter.  Make
1475         extern.
1476         (cli_interpreter_supports_command_editing): Rename to ...
1477         (cli_interp_base::supports_command_editing): ... this.  Remove
1478         'interp' parameter.  Make extern.
1479         (cli_ui_out): Rename to ...
1480         (cli_interp::interp_ui_out): ... this.  Remove 'interp' parameter.
1481         Make extern.
1482         (cli_set_logging): Rename to ...
1483         (cli_interp_base::set_logging): ... this.  Remove 'interp'
1484         parameter.  Make extern.
1485         (cli_interp_procs): Delete.
1486         (cli_interp_factory): Adjust to use "new".
1487         * cli/cli-interp.h: Include "interps.h".
1488         (struct cli_interp_base): New struct.
1489         * interps.c (struct interp): Delete.  Fields moved to interps.h.
1490         (interp_new): Delete.
1491         (interp::interp, interp::~interp): New.
1492         (interp_set): Use bool, and return void.  Assume the interpreter
1493         has suspend, init and resume methods, and that the all return
1494         void.
1495         (set_top_level_interpreter): interp_set returns void.
1496         (interp_ui_out): Adapt.
1497         (current_interp_set_logging): Adapt.
1498         (interp_data): Delete.
1499         (interp_pre_command_loop, interp_supports_command_editing): Adapt.
1500         (interp_exec): Adapt.
1501         (top_level_interpreter_data): Delete.
1502         * interps.h (interp_init_ftype, interp_resume_ftype)
1503         (interp_suspend_ftype, interp_exec_ftype)
1504         (interp_pre_command_loop_ftype, interp_ui_out_ftype): Delete.
1505         (class interp): New.
1506         (interp_new): Delete.
1507         (interp_set): Now returns void.  Use bool.
1508         (interp_data, top_level_interpreter_data): Delete.
1509         * mi/mi-common.h: Include interps.h.
1510         (class mi_interp): Inherit from interp.  Define a ctor.  Declare
1511         init, resume, suspect, exec, interp_ui_out, set_logging and
1512         pre_command_loop methods.
1513         * mi/mi-interp.c (as_mi_interp): Cast the interp itself.
1514         (mi_interpreter_init): Rename to ...
1515         (mi_interp::init): ... this.  Remove the 'interp' parameter, use
1516         bool, return void and make extern.  Adjust.
1517         (mi_interpreter_resume): ... Rename to ...
1518         (mi_interp::resume): ... this.  Remove the 'data' parameter,
1519         return void and make extern.  Adjust.
1520         (mi_interpreter_suspend): ... Rename to ...
1521         (mi_interp::suspend): ... this.  Remove the 'data' parameter,
1522         return void and make extern.  Adjust.
1523         (mi_interpreter_exec): ... Rename to ...
1524         (mi_interp::exec): ... this.  Remove the 'data' parameter and make
1525         extern.  Adjust.
1526         (mi_interpreter_pre_command_loop): ... Rename to ...
1527         (mi_interp::pre_command_loop): ... this.  Remove the 'self'
1528         parameter and make extern.
1529         (mi_on_normal_stop_1): Adjust.
1530         (mi_ui_out): Rename to ...
1531         (mi_interp::interp_ui_out): ... this.  Remove the 'interp'
1532         parameter and make extern.  Adjust.
1533         (mi_set_logging): Rename to ...
1534         (mi_interp::set_logging): ... this.  Remove the 'interp'
1535         parameter and make extern.  Adjust.
1536         (mi_interp_procs): Delete.
1537         (mi_interp_factory): Adjust to use 'new'.
1538         * mi/mi-main.c (mi_cmd_gdb_exit, captured_mi_execute_command)
1539         (mi_print_exception, mi_execute_command, mi_load_progress):
1540         Adjust.
1541         * tui/tui-interp.c (tui_interp): New class.
1542         (as_tui_interp): Return a tui_interp pointer.
1543         (tui_on_normal_stop, tui_on_signal_received)
1544         (tui_on_end_stepping_range, tui_on_signal_exited, tui_on_exited)
1545         (tui_on_no_history, tui_on_user_selected_context_changed): Adjust
1546         to use interp::interp_ui_out.
1547         (tui_init): Rename to ...
1548         (tui_interp::init): ... this.  Remove the 'self' parameter, use
1549         bool, return void and make extern.  Adjust.
1550         (tui_resume): Rename to ...
1551         (tui_interp::resume): ... this.  Remove the 'data' parameter,
1552         return void and make extern.  Adjust.
1553         (tui_suspend): Rename to ...
1554         (tui_interp::suspend): ... this.  Remove the 'data' parameter,
1555         return void and make extern.  Adjust.
1556         (tui_ui_out): Rename to ...
1557         (tui_interp::interp_ui_out): ... this.  Remove the 'self'
1558         parameter, and make extern.  Adjust.
1559         (tui_exec): Rename to ...
1560         (tui_interp::exec): ... this.  Remove the 'data' parameter and
1561         make extern.
1562         (tui_interp_procs): Delete.
1563         (tui_interp_factory): Use "new".
1564
1565 2017-02-02  Tom Tromey  <tom@tromey.com>
1566
1567         * rust-exp.y (ends_raw_string, space_then_number)
1568         (rust_identifier_start_p): Return bool.
1569         * rust-lang.c (rust_tuple_type_p, rust_underscore_fields)
1570         (rust_tuple_struct_type_p, rust_tuple_variant_type_p)
1571         (rust_slice_type_p, rust_range_type_p, rust_u8_type_p)
1572         (rust_chartype_p): Return bool.
1573         (val_print_struct, rust_print_struct_def, rust_print_type):
1574         Update.
1575         * rust-lang.h (rust_tuple_type_p, rust_tuple_struct_type_p):
1576         Return bool.
1577
1578 2017-02-02  Tom Tromey  <tom@tromey.com>
1579
1580         * rust-lang.c: Reindent.
1581
1582 2017-02-02  Tom Tromey  <tom@tromey.com>
1583
1584         * rust-lang.h (rust_crate_for_block): Update.
1585         * rust-lang.c (rust_crate_for_block): Return std::string.
1586         (rust_get_disr_info): Use std:;string, not
1587         gdb::unique_xmalloc_ptr.
1588         * rust-exp.y (crate_name): Update.
1589
1590 2017-02-02  Pedro Alves  <palves@redhat.com>
1591
1592         * disasm-selftests.c (print_one_insn_test): Move the "verbose"
1593         field out of gdb_disassembler_test and make it static.
1594
1595 2017-02-02  Pedro Alves  <palves@redhat.com>
1596
1597         * mi/mi-common.h (struct mi_interp): Delete the mi2_interp,
1598         mi1_interp and mi_interp fields.
1599
1600 2017-02-02  Pedro Alves  <palves@redhat.com>
1601
1602         * cli/cli-interp.c (struct saved_output_files, saved_output):
1603         Moved from cli/cli-logging.c.
1604         (cli_set_logging): New function.
1605         (cli_interp_procs): Install cli_set_logging.
1606         * cli/cli-interp.h (make_logging_output, cli_set_logging):
1607         Declare.
1608         * cli/cli-logging.c (struct saved_output_files, saved_output):
1609         Moved to cli/cli-interp.c.
1610         (pop_output_files): Don't save outputs here.
1611         (make_logging_output): New function.
1612         (handle_redirections): Don't build tee nor save previous outputs
1613         here.
1614         * interps.c (current_interp_set_logging): Change prototype.
1615         Assume there's always a set_logging_proc method installed.
1616         * interps.h (interp_set_logging_ftype): Change prototype.
1617         (current_interp_set_logging): Change prototype and adjust comment.
1618         * mi/mi-interp.c (mi_set_logging): Change protototype.  Adjust to
1619         use make_logging_output.
1620         * tui/tui-interp.c (tui_interp_procs): Install cli_set_logging.
1621 2017-02-02  Pedro Alves  <palves@redhat.com>
1622
1623         * cli/cli-logging.c (maybe_warn_already_logging): New factored out
1624         from ...
1625         (set_logging_overwrite): ... here.
1626         (logging_no_redirect_file): Delete.
1627         (set_logging_redirect): Don't handle redirection on the fly.
1628         Instead warn that "logging off" / "logging on" is necessary.
1629         (pop_output_files): Delete references to logging_no_redirect_file.
1630         (show_logging_command): Always speak in terms of what will happen
1631         once logging is reenabled.
1632
1633 2017-02-02  Pedro Alves  <palves@redhat.com>
1634
1635         * disasm.h (gdb_pretty_print_disassembler): Tweak intro comment.
1636
1637 2017-02-02  Pedro Alves  <palves@redhat.com>
1638
1639         * disasm.c (gdb_pretty_print_insn): Rename to ...
1640         (gdb_pretty_print_disassembler::pretty_print_insn): ... this.
1641         Remove gdbarch parameter.  Adapt to clear the object's buffers
1642         instead of allocating new buffers, and to print using the object's
1643         gdb_disassembler instead of calling gdb_print_insn.
1644         (dump_insns): Use gdb_pretty_print_disassembler.
1645         * disasm.h (gdb_pretty_print_insn): Delete declaration.
1646         (gdb_pretty_print_disassembler): New class.
1647         * record-btrace.c (btrace_insn_history): Use
1648         gdb_pretty_print_disassembler.
1649
1650 2017-02-02  Pedro Alves  <palves@redhat.com>
1651
1652         * ada-lang.c (type_as_string): Use string_file.
1653         * ada-valprint.c (ada_print_floating): Use string_file.
1654         * ada-varobj.c (ada_varobj_scalar_image)
1655         (ada_varobj_get_value_image): Use string_file.
1656         * aix-thread.c (aix_thread_extra_thread_info): Use string_file.
1657         * arm-tdep.c (_initialize_arm_tdep): Use string_printf.
1658         * breakpoint.c (update_inserted_breakpoint_locations)
1659         (insert_breakpoint_locations, reattach_breakpoints)
1660         (print_breakpoint_location, print_one_detail_ranged_breakpoint)
1661         (print_it_watchpoint): Use string_file.
1662         (save_breakpoints): Use stdio_file.
1663         * c-exp.y (oper): Use string_file.
1664         * cli/cli-logging.c (set_logging_redirect): Use ui_file_up and
1665         tee_file.
1666         (pop_output_files): Use delete.
1667         (handle_redirections): Use stdio_file and tee_file.
1668         * cli/cli-setshow.c (do_show_command): Use string_file.
1669         * compile/compile-c-support.c (c_compute_program): Use
1670         string_file.
1671         * compile/compile-c-symbols.c (generate_vla_size): Take a
1672         'string_file &' instead of a 'ui_file *'.
1673         (generate_c_for_for_one_variable): Take a 'string_file &' instead
1674         of a 'ui_file *'.  Use string_file.
1675         (generate_c_for_variable_locations): Take a 'string_file &'
1676         instead of a 'ui_file *'.
1677         * compile/compile-internal.h (generate_c_for_for_one_variable):
1678         Take a 'string_file &' instead of a 'ui_file *'.
1679         * compile/compile-loc2c.c (push, pushf, unary, binary)
1680         (print_label, pushf_register_address, pushf_register)
1681         (do_compile_dwarf_expr_to_c): Take a 'string_file &' instead of a
1682         'ui_file *'.  Adjust.
1683         * compile/compile.c (compile_to_object): Use string_file.
1684         * compile/compile.h (compile_dwarf_expr_to_c)
1685         (compile_dwarf_bounds_to_c): Take a 'string_file &' instead of a
1686         'ui_file *'.
1687         * cp-support.c (inspect_type): Use string_file and obstack_copy0.
1688         (replace_typedefs_qualified_name): Use string_file and
1689         obstack_copy0.
1690         * disasm.c (gdb_pretty_print_insn): Use string_file.
1691         (gdb_disassembly): Adjust reference the null_stream global.
1692         (do_ui_file_delete): Delete.
1693         (gdb_insn_length): Use null_stream.
1694         * dummy-frame.c (maintenance_print_dummy_frames): Use stdio_file.
1695         * dwarf2loc.c (dwarf2_compile_property_to_c)
1696         (locexpr_generate_c_location, loclist_generate_c_location): Take a
1697         'string_file &' instead of a 'ui_file *'.
1698         * dwarf2loc.h (dwarf2_compile_property_to_c): Likewise.
1699         * dwarf2read.c (do_ui_file_peek_last): Delete.
1700         (dwarf2_compute_name): Use string_file.
1701         * event-top.c (gdb_setup_readline): Use stdio_file.
1702         * gdbarch.sh (verify_gdbarch): Use string_file.
1703         * gdbtypes.c (safe_parse_type): Use null_stream.
1704         * guile/scm-breakpoint.c (gdbscm_breakpoint_commands): Use
1705         string_file.
1706         * guile/scm-disasm.c (gdbscm_print_insn_from_port): Take a
1707         'string_file *' instead of a 'ui_file *'.
1708         (gdbscm_arch_disassemble): Use string_file.
1709         * guile/scm-frame.c (frscm_print_frame_smob): Use string_file.
1710         * guile/scm-ports.c (class ioscm_file_port): Now a class that
1711         inherits from ui_file.
1712         (ioscm_file_port_delete, ioscm_file_port_rewind)
1713         (ioscm_file_port_put): Delete.
1714         (ioscm_file_port_write): Rename to ...
1715         (ioscm_file_port::write): ... this.  Remove file_port_magic
1716         checks.
1717         (ioscm_file_port_new): Delete.
1718         (ioscm_with_output_to_port_worker): Use ioscm_file_port and
1719         ui_file_up.
1720         * guile/scm-type.c (tyscm_type_name): Use string_file.
1721         * guile/scm-value.c (vlscm_print_value_smob, gdbscm_value_print):
1722         Use string_file.
1723         * infcmd.c (print_return_value_1): Use string_file.
1724         * infrun.c (print_target_wait_results): Use string_file.
1725         * language.c (add_language): Use string_file.
1726         * location.c (explicit_to_string_internal): Use string_file.
1727         * main.c (captured_main_1): Use null_file.
1728         * maint.c (maintenance_print_architecture): Use stdio_file.
1729         * mi/mi-cmd-stack.c (list_arg_or_local): Use string_file.
1730         * mi/mi-common.h (struct mi_interp) <out, err, log, targ,
1731         event_channel>: Change type to mi_console_file pointer.
1732         * mi/mi-console.c (mi_console_file_fputs, mi_console_file_flush)
1733         (mi_console_file_delete): Delete.
1734         (struct mi_console_file): Delete.
1735         (mi_console_file_magic): Delete.
1736         (mi_console_file_new): Delete.
1737         (mi_console_file::mi_console_file): New.
1738         (mi_console_file_delete): Delete.
1739         (mi_console_file_fputs): Delete.
1740         (mi_console_file::write): New.
1741         (mi_console_raw_packet): Delete.
1742         (mi_console_file::flush): New.
1743         (mi_console_file_flush): Delete.
1744         (mi_console_set_raw): Rename to ...
1745         (mi_console_file::set_raw): ... this.
1746         * mi/mi-console.h (class mi_console_file): New class.
1747         (mi_console_file_new, mi_console_set_raw): Delete.
1748         * mi/mi-interp.c (mi_interpreter_init): Use mi_console_file.
1749         (mi_set_logging): Use delete and tee_file.  Adjust.
1750         * mi/mi-main.c (output_register): Use string_file.
1751         (mi_cmd_data_evaluate_expression): Use string_file.
1752         (mi_cmd_data_read_memory): Use string_file.
1753         (mi_cmd_execute, print_variable_or_computed): Use string_file.
1754         * mi/mi-out.c (mi_ui_out::main_stream): New.
1755         (mi_ui_out::rewind): Use main_stream and
1756         string_file.
1757         (mi_ui_out::put): Use main_stream and string_file.
1758         (mi_ui_out::mi_ui_out): Remove 'stream' parameter.
1759         Allocate a 'string_file' instead.
1760         (mi_out_new): Don't allocate a mem_fileopen stream here.
1761         * mi/mi-out.h (mi_ui_out::mi_ui_out): Remove 'stream' parameter.
1762         (mi_ui_out::main_stream): Declare method.
1763         * printcmd.c (eval_command): Use string_file.
1764         * psymtab.c (maintenance_print_psymbols): Use stdio_file.
1765         * python/py-arch.c (archpy_disassemble): Use string_file.
1766         * python/py-breakpoint.c (bppy_get_commands): Use string_file.
1767         * python/py-frame.c (frapy_str): Use string_file.
1768         * python/py-framefilter.c (py_print_type, py_print_single_arg):
1769         Use string_file.
1770         * python/py-type.c (typy_str): Use string_file.
1771         * python/py-unwind.c (unwind_infopy_str): Use string_file.
1772         * python/py-value.c (valpy_str): Use string_file.
1773         * record-btrace.c (btrace_insn_history): Use string_file.
1774         * regcache.c (regcache_print): Use stdio_file.
1775         * reggroups.c (maintenance_print_reggroups): Use stdio_file.
1776         * remote.c (escape_buffer): Use string_file.
1777         * rust-lang.c (rust_get_disr_info): Use string_file.
1778         * serial.c (serial_open_ops_1): Use stdio_file.
1779         (do_serial_close): Use delete.
1780         * stack.c (print_frame_arg): Use string_file.
1781         (print_frame_args): Remove local mem_fileopen stream, not used.
1782         (print_frame): Use string_file.
1783         * symmisc.c (maintenance_print_symbols): Use stdio_file.
1784         * symtab.h (struct symbol_computed_ops) <generate_c_location>:
1785         Take a 'string_file *' instead of a 'ui_file *'.
1786         * top.c (new_ui): Use stdio_file and stderr_file.
1787         (free_ui): Use delete.
1788         (execute_command_to_string): Use string_file.
1789         (quit_confirm): Use string_file.
1790         * tracepoint.c (collection_list::append_exp): Use string_file.
1791         * tui/tui-disasm.c (tui_disassemble): Use string_file.
1792         * tui/tui-file.c: Don't include "ui-file.h".
1793         (enum streamtype, struct tui_stream): Delete.
1794         (tui_file_new, tui_file_delete, tui_fileopen, tui_sfileopen)
1795         (tui_file_isatty, tui_file_rewind, tui_file_put): Delete.
1796         (tui_file::tui_file): New method.
1797         (tui_file_fputs): Delete.
1798         (tui_file_get_strbuf): Delete.
1799         (tui_file::puts): New method.
1800         (tui_file_adjust_strbuf): Delete.
1801         (tui_file_flush): Delete.
1802         (tui_file::flush): New method.
1803         * tui/tui-file.h: Tweak intro comment.
1804         Include ui-file.h.
1805         (tui_fileopen, tui_sfileopen, tui_file_get_strbuf)
1806         (tui_file_adjust_strbuf): Delete declarations.
1807         (class tui_file): New class.
1808         * tui/tui-io.c (tui_initialize_io): Use tui_file.
1809         * tui/tui-regs.c (tui_restore_gdbout): Use delete.
1810         (tui_register_format): Use string_stream.
1811         * tui/tui-stack.c (tui_make_status_line): Use string_file.
1812         (tui_get_function_from_frame): Use string_file.
1813         * typeprint.c (type_to_string): Use string_file.
1814         * ui-file.c (struct ui_file, ui_file_magic, ui_file_new): Delete.
1815         (null_stream): New global.
1816         (ui_file_delete): Delete.
1817         (ui_file::ui_file): New.
1818         (null_file_isatty): Delete.
1819         (ui_file::~ui_file): New.
1820         (null_file_rewind): Delete.
1821         (ui_file::printf): New.
1822         (null_file_put): Delete.
1823         (null_file_flush): Delete.
1824         (ui_file::putstr): New.
1825         (null_file_write): Delete.
1826         (ui_file::putstrn): New.
1827         (null_file_read): Delete.
1828         (ui_file::putc): New.
1829         (null_file_fputs): Delete.
1830         (null_file_write_async_safe): Delete.
1831         (ui_file::vprintf): New.
1832         (null_file_delete): Delete.
1833         (null_file::write): New.
1834         (null_file_fseek): Delete.
1835         (null_file::puts): New.
1836         (ui_file_data): Delete.
1837         (null_file::write_async_safe): New.
1838         (gdb_flush, ui_file_isatty): Adjust.
1839         (ui_file_put, ui_file_rewind): Delete.
1840         (ui_file_write): Adjust.
1841         (ui_file_write_for_put): Delete.
1842         (ui_file_write_async_safe, ui_file_read): Adjust.
1843         (ui_file_fseek): Delete.
1844         (fputs_unfiltered): Adjust.
1845         (set_ui_file_flush, set_ui_file_isatty, set_ui_file_rewind)
1846         (set_ui_file_put, set_ui_file_write, set_ui_file_write_async_safe)
1847         (set_ui_file_read, set_ui_file_fputs, set_ui_file_fseek)
1848         (set_ui_file_data): Delete.
1849         (string_file::~string_file, string_file::write)
1850         (struct accumulated_ui_file, do_ui_file_xstrdup, ui_file_xstrdup)
1851         (do_ui_file_as_string, ui_file_as_string): Delete.
1852         (do_ui_file_obsavestring, ui_file_obsavestring): Delete.
1853         (struct mem_file): Delete.
1854         (mem_file_new): Delete.
1855         (stdio_file::stdio_file): New.
1856         (mem_file_delete): Delete.
1857         (stdio_file::stdio_file): New.
1858         (mem_fileopen): Delete.
1859         (stdio_file::~stdio_file): New.
1860         (mem_file_rewind): Delete.
1861         (stdio_file::set_stream): New.
1862         (mem_file_put): Delete.
1863         (stdio_file::open): New.
1864         (mem_file_write): Delete.
1865         (stdio_file_magic, struct stdio_file): Delete.
1866         (stdio_file_new, stdio_file_delete, stdio_file_flush): Delete.
1867         (stdio_file::flush): New.
1868         (stdio_file_read): Rename to ...
1869         (stdio_file::read): ... this.  Adjust.
1870         (stdio_file_write): Rename to ...
1871         (stdio_file::write): ... this.  Adjust.
1872         (stdio_file_write_async_safe): Rename to ...
1873         (stdio_file::write_async_safe) ... this.  Adjust.
1874         (stdio_file_fputs): Rename to ...
1875         (stdio_file::puts) ... this.  Adjust.
1876         (stdio_file_isatty): Delete.
1877         (stdio_file_fseek): Delete.
1878         (stdio_file::isatty): New.
1879         (stderr_file_write): Rename to ...
1880         (stderr_file::write) ... this.  Adjust.
1881         (stderr_file_fputs): Rename to ...
1882         (stderr_file::puts) ... this.  Adjust.
1883         (stderr_fileopen, stdio_fileopen, gdb_fopen): Delete.
1884         (stderr_file::stderr_file): New.
1885         (tee_file_magic): Delete.
1886         (struct tee_file): Delete.
1887         (tee_file::tee_file): New.
1888         (tee_file_new): Delete.
1889         (tee_file::~tee_file): New.
1890         (tee_file_delete): Delete.
1891         (tee_file_flush): Rename to ...
1892         (tee_file::flush): ... this.  Adjust.
1893         (tee_file_write): Rename to ...
1894         (tee_file::write): ... this.  Adjust.
1895         (tee_file::write_async_safe): New.
1896         (tee_file_fputs): Rename to ...
1897         (tee_file::puts): ... this.  Adjust.
1898         (tee_file_isatty): Rename to ...
1899         (tee_file::isatty): ... this.  Adjust.
1900         * ui-file.h (struct obstack, struct ui_file): Don't
1901         forward-declare.
1902         (ui_file_new, ui_file_flush_ftype, set_ui_file_flush)
1903         (ui_file_write_ftype)
1904         (set_ui_file_write, ui_file_fputs_ftype, set_ui_file_fputs)
1905         (ui_file_write_async_safe_ftype, set_ui_file_write_async_safe)
1906         (ui_file_read_ftype, set_ui_file_read, ui_file_isatty_ftype)
1907         (set_ui_file_isatty, ui_file_rewind_ftype, set_ui_file_rewind)
1908         (ui_file_put_method_ftype, ui_file_put_ftype, set_ui_file_put)
1909         (ui_file_delete_ftype, set_ui_file_data, ui_file_fseek_ftype)
1910         (set_ui_file_fseek): Delete.
1911         (ui_file_data, ui_file_delete, ui_file_rewind)
1912         (struct ui_file): New.
1913         (ui_file_up): New.
1914         (class null_file): New.
1915         (null_stream): Declare.
1916         (ui_file_write_for_put, ui_file_put): Delete.
1917         (ui_file_xstrdup, ui_file_as_string, ui_file_obsavestring):
1918         Delete.
1919         (ui_file_fseek, mem_fileopen, stdio_fileopen, stderr_fileopen)
1920         (gdb_fopen, tee_file_new): Delete.
1921         (struct string_file): New.
1922         (struct stdio_file): New.
1923         (stdio_file_up): New.
1924         (struct stderr_file): New.
1925         (class tee_file): New.
1926         * ui-out.c (ui_out::field_stream): Take a 'string_file &' instead
1927         of a 'ui_file *'.  Adjust.
1928         * ui-out.h (class ui_out) <field_stream>: Likewise.
1929         * utils.c (do_ui_file_delete, make_cleanup_ui_file_delete)
1930         (null_stream): Delete.
1931         (error_stream): Take a 'string_file &' instead of a 'ui_file *'.
1932         Adjust.
1933         * utils.h (struct ui_file): Delete forward declaration..
1934         (make_cleanup_ui_file_delete, null_stream): Delete declarations.
1935         (error_stream): Take a 'string_file &' instead of a
1936         'ui_file *'.
1937         * varobj.c (varobj_value_get_print_value): Use string_file.
1938         * xtensa-tdep.c (xtensa_verify_config): Use string_file.
1939         * gdbarch.c: Regenerate.
1940
1941 2017-02-02  Pedro Alves  <palves@redhat.com>
1942
1943         * disasm.c (gdb_disassembler::pretty_print_insn): Rename to...
1944         (gdb_pretty_print_insn): ... this.  Now a free function.  Add back
1945         a 'gdbarch' parameter.  Allocate a mem_fileopen stream here.
1946         Adjust to call gdb_print_insn instead of
1947         gdb_disassembler::print_insn.
1948         (dump_insns, do_mixed_source_and_assembly_deprecated)
1949         (do_mixed_source_and_assembly, do_assembly_only): Add back a
1950         'gdbarch' parameter.  Remove gdb_disassembler parameter.
1951         (gdb_disassembly): Don't allocate a gdb_disassembler here.
1952         * disasm.h (gdb_disassembler::pretty_print_insn): Delete
1953         declaration.
1954         (gdb_pretty_print_insn): Re-add declaration.
1955         * record-btrace.c (btrace_insn_history): Don't allocate a
1956         gdb_disassembler here.  Adjust to call gdb_pretty_print_insn.
1957
1958 2017-02-01  Simon Marchi  <simon.marchi@polymtl.ca>
1959
1960         * disasm.h (gdb_disassembly): Remove file_string parameter.
1961         * disasm.c (gdb_disassembly): Likewise.
1962         * cli/cli-cmds.c (print_disassembly): Adapt.
1963         * mi/mi-cmd-disas.c (mi_cmd_disassemble): Likewise.
1964         * stack.c (do_gdb_disassembly): Likewise.
1965
1966 2017-02-01  Andreas Arnez  <arnez@linux.vnet.ibm.com>
1967
1968         * dwarf2loc.c (dwarf2_evaluate_loc_desc_full): For
1969         DWARF_VALUE_LITERAL, no longer ignore the offset on big-endian
1970         targets.  And if the implicit value is longer than needed, extract
1971         the first bytes instead of the "least significant" ones.
1972
1973 2017-02-01  Markus Metzger  <markus.t.metzger@intel.com>
1974
1975         * btrace.c (btrace_enable): Do not call btrace_add_pc for
1976         BTRACE_FORMAT_PT or if can_access_registers_ptid returns false.
1977         (btrace_fetch): Assert can_access_registers_ptid.
1978         * record-btrace.c (require_btrace_thread, record_btrace_info): Call
1979         validate_registers_access.
1980
1981 2017-02-01  Markus Metzger  <markus.t.metzger@intel.com>
1982
1983         * gdbthread.h (can_access_registers_ptid): New.
1984         * thread.c (can_access_registers_ptid): New.
1985
1986 2017-02-01  Pedro Alves  <palves@redhat.com>
1987
1988         * i386-tdep.c (i386_fast_tracepoint_valid_at): Use gdb_insn_length.
1989
1990 2017-01-31  Pedro Alves  <palves@redhat.com>
1991
1992         * mi/mi-interp.c (mi_breakpoint_created, mi_breakpoint_modified):
1993         Fix typos.
1994
1995 2017-01-31  Pedro Alves  <palves@redhat.com>
1996
1997         * stack.c (print_frame_args): Remove local mem_fileopen stream,
1998         not used.
1999
2000 2017-01-31  Pedro Alves  <palves@redhat.com>
2001
2002         * varobj.c (varobj_value_get_print_value): Remove xstrdup call.
2003
2004 2017-01-31  Pedro Alves  <palves@redhat.com>
2005
2006         * common/scoped_restore.h
2007         (scoped_restore_tmpl::scoped_restore_tmpl): Template on T2, and
2008         change the value's parameter type to T2.
2009         (make_scoped_restore): Likewise.
2010
2011 2017-01-27  Walfred Tedeschi  <walfred.tedeschi@intel.com>
2012             Richard Henderson  <rth@redhat.com>
2013
2014         * amd64-linux-nat.c (PTRACE_ARCH_PRCTL): New define.
2015         (amd64_linux_fetch_inferior_registers): Add case to fetch FS_BASE
2016         GS_BASE for older kernels.
2017         (amd64_linux_store_inferior_registers): Add case to store FS_BASE
2018         GS_BASE for older kernels.
2019         * amd64-linux-tdep.c (amd64_linux_gregset_reg_offset): Add FS_BASE
2020         and GS_BASE to the offset table.
2021         (amd64_linux_register_reggroup_p): Add FS_BASE and GS_BASE to the
2022         system register group.
2023         * amd64-nat.c (amd64_native_gregset_reg_offset): Implements case
2024         for older kernels.
2025         * amd64-tdep.c (amd64_init_abi): Add segment registers for the
2026         amd64 ABI.
2027         * amd64-tdep.h (amd64_regnum): Add AMD64_FSBASE_REGNUM and
2028         AMD64_GSBASE_REGNUM.
2029         (AMD64_NUM_REGS): Set to AMD64_GSBASE_REGNUM + 1.
2030         * features/Makefile (amd64-linux.dat, amd64-avx-linux.dat)
2031         (amd64-mpx-linux.dat, amd64-avx512-linux.dat, x32-linux.dat)
2032         (x32-avx-linux.dat, x32-avx512-linux.dat): Add
2033         i386/64bit-segments.xml in those rules.
2034         * features/i386/64bit-segments.xml: New file.
2035         * features/i386/amd64-avx-mpx-linux.xml: Add 64bit-segments.xml.
2036         * features/i386/amd64-avx-linux.xml: Add 64bit-segments.xml.
2037         * features/i386/amd64-avx512-linux.xml: Add 64bit-segments.xml.
2038         * features/i386/amd64-mpx-linux.xml: Add 64bit-segments.xml.
2039         * features/i386/x32-avx512-linux.xml: Add 64bit-segments.xml.
2040         * features/i386/x32-avx-linux.xml: Add 64bit-segments.xml.
2041         * features/i386/amd64-linux.xml: Add 64bit-segments.xml.
2042         * features/i386/amd64-avx-linux.c: Regenerated.
2043         * features/i386/amd64-avx-mpx-linux.c: Regenerated.
2044         * features/i386/amd64-avx-mpx.c: Regenerated.
2045         * features/i386/amd64-avx512-linux.c: Regenerated.
2046         * features/i386/amd64-linux.c: Regenerated.
2047         * features/i386/amd64-mpx-linux.c: Regenerated.
2048         * features/i386/i386-avx-mpx-linux.c: Regenerated.
2049         * features/i386/i386-avx-mpx.c: Regenerated.
2050         * features/i386/x32-avx-linux.c: Regenerated.
2051         * features/i386/x32-avx512-linux.c: Regenerated.
2052         * regformats/i386/amd64-avx-linux.dat: Regenerated.
2053         * regformats/i386/amd64-avx-mpx-linux.dat: Regenerated.
2054         * regformats/i386/amd64-avx512-linux.dat: Regenerated.
2055         * regformats/i386/amd64-linux.dat: Regenerated.
2056         * regformats/i386/amd64-mpx-linux.dat: Regenerated.
2057         * regformats/i386/x32-avx-linux.dat: Regenerated.
2058         * regformats/i386/x32-avx512-linux.dat: Regenerated.
2059         * regformats/i386/x32-linux.dat: Regenerated.
2060
2061 2017-01-27  Walfred Tedeschi  <walfred.tedeschi@intel.com>
2062
2063         * amd64-linux-tdep.h (AMD64_LINUX_ORIG_RAX_REGNUM):
2064         Set to AMD64_NUM_REGS.
2065
2066 2017-01-27  Walfred Tedeschi  <walfred.tedeschi@intel.com>
2067
2068         * amd64-nat.c (amd64_native_gregset_reg_offset): Simplify logic
2069         that checks validity of a register number.
2070
2071 2017-01-27  Kees Cook  <keescook@google.com>
2072
2073         * gdb/arm-linux-nat.c (arm_linux_fetch_inferior_registers): Call
2074         fetch_fpregs if target has fpa registers.
2075         (arm_linux_store_inferior_registers): Call store_fpregs if target
2076         has fpa registers.
2077
2078 2017-01-26  Andreas Arnez  <arnez@linux.vnet.ibm.com>
2079
2080         * cris-tdep.c (cris_gdbarch_init): Remove check for
2081         info.byte_order and force it to BFD_ENDIAN_LITTLE.
2082
2083 2017-01-26  Antoine Tremblay  <antoine.tremblay@ericsson.com>
2084
2085         * corelow.c (get_core_register_section): Check for regset
2086         existence before checking for REGSET_VARIABLE_SIZE.
2087
2088 2017-01-26  Yao Qi  <yao.qi@linaro.org>
2089             Pedro Alves  <palves@redhat.com>
2090
2091         PR gdb/20939
2092         * disasm.c (gdb_disassembler::dis_asm_memory_error): Don't
2093         call memory_error, save memaddr instead.
2094         (gdb_disassembler::print_insn): If gdbarch_print_insn returns
2095         negative, cal memory_error.
2096         * disasm.h (gdb_disassembler) <m_err_memaddr>: New field.
2097
2098 2017-01-26  Yao Qi  <yao.qi@linaro.org>
2099
2100         * disasm-selftests.c (memory_error_test): New function.
2101         (_initialize_disasm_selftests): Register memory_error_test.
2102
2103 2017-01-26  Yao Qi  <yao.qi@linaro.org>
2104
2105         * Makefile.in (SFILES): Add disasm-selftests.c and
2106         selftest-arch.c.
2107         (COMMON_OBS): Add disasm-selftests.o and selftest-arch.o.
2108         * disasm-selftests.c: New file.
2109         * selftest-arch.c: New file.
2110         * selftest-arch.h: New file.
2111
2112 2017-01-26  Yao Qi  <yao.qi@linaro.org>
2113
2114         * mep-tdep.c (mep_gdb_print_insn): Set info->arch
2115         to bfd_arch_mep.  Don't return 0 if section is not
2116         found.  Call print_insn_mep.
2117
2118 2017-01-26  Pedro Alves  <palves@redhat.com>
2119             Yao Qi  <yao.qi@linaro.org>
2120
2121         * arm-tdep.c: Include "disasm.h".
2122         (gdb_print_insn_arm): Update code to get gdbarch.
2123         * disasm.c (dis_asm_read_memory): Change it to
2124         gdb_disassembler::dis_asm_read_memory.
2125         (dis_asm_memory_error): Likewise.
2126         (dis_asm_print_address): Likewise.
2127         (gdb_pretty_print_insn): Change it to
2128         gdb_disassembler::pretty_print_insn.
2129         (dump_insns): Add one argument gdb_disassemlber.  All
2130         callers updated.
2131         (do_mixed_source_and_assembly_deprecated): Likewise.
2132         (do_mixed_source_and_assembly): Likewise.
2133         (do_assembly_only): Likewise.
2134         (gdb_disassembler::gdb_disassembler): New.
2135         (gdb_disassembler::print_insn): New.
2136         * disasm.h (class gdb_disassembler): New.
2137         (gdb_pretty_print_insn): Remove declaration.
2138         (gdb_disassemble_info): Likewise.
2139         * guile/scm-disasm.c (class gdbscm_disassembler): New.
2140         (gdbscm_disasm_read_memory_worker): Update.
2141         (gdbscm_disasm_read_memory): Update.
2142         (gdbscm_disasm_memory_error): Remove.
2143         (gdbscm_disasm_print_address): Remove.
2144         (gdbscm_disassembler::gdbscm_disassembler): New.
2145         (gdbscm_print_insn_from_port): Update.
2146         * mips-tdep.c: Include disasm.h.
2147         (gdb_print_insn_mips): Update code to get gdbarch.
2148         * record-btrace.c (btrace_insn_history): Update.
2149         * spu-tdep.c: Include disasm.h.
2150         (struct spu_dis_asm_data): Remove.
2151         (struct spu_dis_asm_info): New.
2152         (spu_dis_asm_print_address): Use spu_dis_asm_info to get
2153         SPU id.
2154         (gdb_print_insn_spu): Cast disassemble_info to
2155         spu_dis_asm_info.
2156
2157 2017-01-26  Yao Qi  <yao.qi@linaro.org>
2158
2159         * disasm.c (do_ui_file_delete): Delete.
2160         (gdb_insn_length): Move code creating stream to ...
2161         * utils.c (null_stream): ... here.  New function.
2162         * utils.h (null_stream): Declare.
2163
2164 2017-01-23  Simon Marchi  <simon.marchi@polymtl.ca>
2165
2166         * python/py-inferior.c (find_thread_object): Return directly
2167         from the loop.  Remove "found" variable.
2168
2169 2017-01-21  Joel Brobecker  <brobecker@adacore.com>
2170
2171         GDB 7.12.1 released.
2172
2173 2017-01-20  Simon Marchi  <simon.marchi@ericsson.com>
2174
2175         * python/py-function.c (fnpy_call): Reorder declarations to have
2176         the gdbpy_enter object declared first.
2177         * python/py-xmethods.c (gdbpy_get_xmethod_arg_types): Likewise.
2178
2179 2017-01-20  Simon Marchi  <simon.marchi@ericsson.com>
2180
2181         PR python/21068
2182         * python/python-internal.h (PyMem_RawMalloc): Define for
2183         Python < 3.4.
2184         * python/py-gdb-readline.c (gdbpy_readline_wrapper): Use
2185         PyMem_RawMalloc instead of PyMem_Malloc.
2186
2187 2017-01-20  Mike Wrighton  <mike_wrighton@codesourcery.com>
2188             Luis Machado  <lgustavo@codesourcery.com>
2189
2190         * NEWS (New commands): Mention flash-erase.
2191         (New MI commands): Mention target-flash-erase.
2192         * mi/mi-cmds.c (mi_cmd_target_flash_erase): Add target-flash-erase MI
2193         command.
2194         * mi/mi-cmds.h (mi_cmd_target_flash_erase): New declaration.
2195         * mi/mi-main.c (mi_cmd_target_flash_erase): New function.
2196         * target.c (flash_erase_command): New function.
2197         (initialize_targets): Add new flash-erase command.
2198         * target.h (flash_erase_command): New declaration.
2199
2200 2017-01-20  Joel Brobecker  <brobecker@adacore.com>
2201
2202         * nat/linux-ptrace.c: Only include <sys/procfs.h> if
2203         HAVE_SYS_PROCFS_H is defined.
2204
2205 2017-01-18  Alan Hayward  <alan.hayward@arm.com>
2206
2207         * remote.c (struct cached_reg): Change data into a pointer.
2208         * (stop_reply_dtr): Free data pointers before deleting vector.
2209         (process_stop_reply): Likewise.
2210         (remote_parse_stop_reply): Allocate space for data
2211
2212 2017-01-18  Alan Hayward  <alan.hayward@arm.com>
2213
2214         * amd64-tdep.c (amd64_pseudo_register_read_value): remove
2215         MAX_REGISTER_SIZE.
2216         (amd64_pseudo_register_read_value): Likewise.
2217         * remote.c (fetch_register_using_p): Remove MAX_REGISTER_SIZE.
2218         (store_register_using_P): Likewise.
2219         * regcache.c (regcache_xfer_part): Likewise.
2220
2221 2017-01-16  Ivo Raisr  <ivo.raisr@oracle.com>
2222
2223         Split real and pseudo registers.
2224         * sparc-tdep.h (SPARC_CORE_REGISTERS): New macro.
2225         (sparc32_pseudo_regnum): New enum.
2226         * sparc64-tdep.h (sparc64_pseudo_regnum): New enum.
2227         * sparc-tdep.c (SPARC32_FPU_REGISTERS): New macro.
2228         (SPARC32_CP0_REGISTERS): New macro.
2229         (sparc32_pseudo_register_name): New function.
2230         (sparc32_register_name): Use sparc32_pseudo_register_name.
2231         (sparc32_pseudo_register_type): New function.
2232         (sparc32_register_type): Use sparc32_pseudo_register_type.
2233         (sparc32_pseudo_register_read, sparc32_pseudo_register_write): Handle
2234         pseudo register numbers.
2235         * sparc64-tdep.c SPARC64_FPU_REGISTERS): New macro.
2236         (SPARC64_CP0_REGISTERS): New macro.
2237         (sparc64_pseudo_register_name): New function.
2238         (sparc64_register_name): Use sparc64_pseudo_register_name.
2239         (sparc64_pseudo_register_type): New function.
2240         (sparc64_register_type): Use sparc64_pseudo_register_type.
2241         (sparc64_pseudo_register_read, sparc64_pseudo_register_write): Handle
2242         pseudo register numbers.
2243         (sparc64_store_floating_fields, sparc64_extract_floating_fields,
2244         sparc64_store_arguments): Handle pseudo register numbers.
2245
2246 2017-01-13  Yao Qi  <yao.qi@linaro.org>
2247
2248         * remote.c (REMOTE_DEBUG_MAX_CHAR): New macro.
2249         (putpkt_binary): Print only REMOTE_DEBUG_MAX_CHAR chars in debug
2250         output.
2251         (getpkt_or_notif_sane_1): Likewise.
2252
2253 2017-01-13  Yao Qi  <yao.qi@linaro.org>
2254
2255         * Makefile.in (checker-headers): Use CXX and CXX_DIALET instead
2256         of CC.  Pass "-x c++-header" instead of "-x c".
2257
2258 2017-01-12  Simon Marchi  <simon.marchi@ericsson.com>
2259
2260         * remote.c (remote_can_async_p): Update comment.
2261
2262 2017-01-12  Simon Marchi  <simon.marchi@ericsson.com>
2263
2264         * linux-nat.c (linux_nat_can_async_p): Update comment.
2265
2266 2017-01-12  Simon Marchi  <simon.marchi@ericsson.com>
2267
2268         * serial.c (serial_open): Forget about "pc" and "lpt" serial interface.
2269
2270 2017-01-11  Simon Marchi  <simon.marchi@ericsson.com>
2271
2272         * cli/cli-decode.c (lookup_cmd_1): Fix typo in comment.
2273
2274 2017-01-10  Tom Tromey  <tom@tromey.com>
2275
2276         * python/py-type.c (typy_legacy_template_argument): Update.
2277         * cp-support.h (struct demangle_parse_info) (demangle_parse_info,
2278         ~demangle_parse_info): Declare new members.
2279         (cp_demangled_name_to_comp): Return unique_ptr.
2280         (cp_demangled_name_parse_free)
2281         (make_cleanup_cp_demangled_name_parse_free)
2282         (cp_new_demangle_parse_info): Remove.
2283         * cp-support.c (do_demangled_name_parse_free_cleanup)
2284         (make_cleanup_cp_demangled_name_parse_free): Remove.
2285         (inspect_type, cp_canonicalize_string_full)
2286         (cp_canonicalize_string): Update.
2287         (mangled_name_to_comp): Change return type.
2288         (cp_class_name_from_physname, method_name_from_physname)
2289         (cp_func_name, cp_remove_params): Update.
2290         * cp-name-parser.y (demangle_parse_info): New constructor, from
2291         cp_new_demangle_parse_info.
2292         (~demangle_parse_info): New destructor, from
2293         cp_demangled_name_parse_free.
2294         (cp_merge_demangle_parse_infos): Update.
2295         (cp_demangled_name_to_comp): Change return type.
2296
2297 2017-01-10  Tom Tromey  <tom@tromey.com>
2298
2299         * top.c (prevent_dont_repeat): Change return type.
2300         * python/python.c (execute_gdb_command): Use std::string.
2301         Update.
2302         * guile/guile.c (gdbscm_execute_gdb_command): Update.
2303         * command.h (prevent_dont_repeat): Change return type.
2304         * breakpoint.c (bpstat_do_actions_1): Update.
2305
2306 2017-01-10  Tom Tromey  <tom@tromey.com>
2307
2308         * value.h (scoped_value_mark::~scoped_value_mark): Call
2309         free_to_mark.
2310         (scoped_value_mark::free_to_mark): New method.
2311         * dwarf2loc.c (dwarf2_evaluate_loc_desc_full): Use
2312         scoped_value_mark.
2313
2314 2017-01-10  Tom Tromey  <tom@tromey.com>
2315
2316         * python/py-value.c (valpy_dereference, valpy_referenced_value)
2317         (valpy_reference_value, valpy_const_value, valpy_get_address)
2318         (valpy_get_dynamic_type, valpy_lazy_string, valpy_do_cast)
2319         (valpy_getitem, valpy_call, valpy_binop_throw, valpy_negative)
2320         (valpy_absolute, valpy_richcompare_throw): Use scoped_value_mark.
2321         * dwarf2loc.c (dwarf2_loc_desc_get_symbol_read_needs): Use
2322         scoped_value_mark.
2323         * dwarf2-frame.c (execute_stack_op): Use scoped_value_mark.
2324         * value.h (scoped_value_mark): New class.
2325
2326 2017-01-10  Tom Tromey  <tom@tromey.com>
2327
2328         * dwarf2read.c (dwarf2_build_psymtabs): Use psymtab_discarder.
2329         * psympriv.h (make_cleanup_discard_psymtabs): Don't declare.
2330         * psymtab.c (discard_psymtabs_upto): Remove.
2331         (make_cleanup_discard_psymtabs): Remove.
2332         (struct psymtab_state): Remove.
2333
2334 2017-01-10  Tom Tromey  <tom@tromey.com>
2335
2336         * record-full.c (record_full_save_cleanups): Remove.
2337         (record_full_save): Use gdb::unlinker.
2338         * gcore.c (do_bfd_delete_cleanup): Remove.
2339         (gcore_command): Use gdb::unlinker, unique_xmalloc_ptr.  Remove
2340         cleanups.
2341         * dwarf2read.c (unlink_if_set): Remove.
2342         (write_psymtabs_to_index): Use gdb::unlinker.
2343         * common/gdb_unlinker.h: New file.
2344
2345 2017-01-10  Tom Tromey  <tom@tromey.com>
2346
2347         * windows-tdep.c (windows_xfer_shared_library): Update.
2348         * windows-nat.c (windows_make_so): Update.
2349         * utils.h (make_cleanup_bfd_unref): Remove.
2350         * utils.c (do_bfd_close_cleanup, make_cleanup_bfd_unref): Remove.
2351         * symfile.h (symfile_bfd_open)
2352         (find_separate_debug_file_in_section): Return gdb_bfd_ref_ptr.
2353         * symfile.c (read_symbols, symbol_file_add)
2354         (separate_debug_file_exists): Update.
2355         (symfile_bfd_open): Return gdb_bfd_ref_ptr.
2356         (generic_load, reread_symbols): Update.
2357         * symfile-mem.c (symbol_file_add_from_memory): Update.
2358         * spu-linux-nat.c (spu_bfd_open): Return gdb_bfd_ref_ptr.
2359         (spu_symbol_file_add_from_memory): Update.
2360         * solist.h (struct target_so_ops) <bfd_open>: Return
2361         gdb_bfd_ref_ptr.
2362         (solib_bfd_fopen, solib_bfd_open): Return gdb_bfd_ref_ptr.
2363         * solib.c (solib_bfd_fopen, solib_bfd_open): Return
2364         gdb_bfd_ref_ptr.
2365         (solib_map_sections, reload_shared_libraries_1): Update.
2366         * solib-svr4.c (enable_break): Update.
2367         * solib-spu.c (spu_bfd_fopen): Return gdb_bfd_ref_ptr.
2368         * solib-frv.c (enable_break2): Update.
2369         * solib-dsbt.c (enable_break): Update.
2370         * solib-darwin.c (gdb_bfd_mach_o_fat_extract): Return
2371         gdb_bfd_ref_ptr.
2372         (darwin_solib_get_all_image_info_addr_at_init): Update.
2373         (darwin_bfd_open): Return gdb_bfd_ref_ptr.
2374         * solib-aix.c (solib_aix_bfd_open): Return gdb_bfd_ref_ptr.
2375         * record-full.c (record_full_save): Update.
2376         * python/py-objfile.c (objfpy_add_separate_debug_file): Update.
2377         * procfs.c (insert_dbx_link_bpt_in_file): Update.
2378         * minidebug.c (find_separate_debug_file_in_section): Return
2379         gdb_bfd_ref_ptr.
2380         * machoread.c (macho_add_oso_symfile): Change abfd to
2381         gdb_bfd_ref_ptr.
2382         (macho_symfile_read_all_oso): Update.
2383         (macho_check_dsym): Return gdb_bfd_ref_ptr.
2384         (macho_symfile_read): Update.
2385         * jit.c (bfd_open_from_target_memory): Return gdb_bfd_ref_ptr.
2386         (jit_bfd_try_read_symtab): Update.
2387         * gdb_bfd.h (gdb_bfd_open, gdb_bfd_fopen, gdb_bfd_openr)
2388         (gdb_bfd_openw, gdb_bfd_openr_iovec)
2389         (gdb_bfd_openr_next_archived_file, gdb_bfd_fdopenr): Return
2390         gdb_bfd_ref_ptr.
2391         (gdb_bfd_ref_policy): New struct.
2392         (gdb_bfd_ref_ptr): New typedef.
2393         * gdb_bfd.c (gdb_bfd_open, gdb_bfd_fopen, gdb_bfd_openr)
2394         (gdb_bfd_openw, gdb_bfd_openr_iovec)
2395         (gdb_bfd_openr_next_archived_file, gdb_bfd_fdopenr): Return
2396         gdb_bfd_ref_ptr.
2397         * gcore.h (create_gcore_bfd): Return gdb_bfd_ref_ptr.
2398         * gcore.c (create_gcore_bfd): Return gdb_bfd_ref_ptr.
2399         (gcore_command): Update.
2400         * exec.c (exec_file_attach): Update.
2401         * elfread.c (elf_symfile_read): Update.
2402         * dwarf2read.c (dwarf2_get_dwz_file): Update.
2403         (try_open_dwop_file, open_dwo_file): Return gdb_bfd_ref_ptr.
2404         (open_and_init_dwo_file): Update.
2405         (open_dwp_file): Return gdb_bfd_ref_ptr.
2406         (open_and_init_dwp_file): Update.
2407         * corelow.c (core_open): Update.
2408         * compile/compile-object-load.c (compile_object_load): Update.
2409         * common/gdb_ref_ptr.h (ref_ptr::operator->): New operator.
2410         * coffread.c (coff_symfile_read): Update.
2411         * cli/cli-dump.c (bfd_openr_or_error, bfd_openw_or_error): Return
2412         gdb_bfd_ref_ptr.  Rename.
2413         (dump_bfd_file, restore_command): Update.
2414         * build-id.h (build_id_to_debug_bfd): Return gdb_bfd_ref_ptr.
2415         * build-id.c (build_id_to_debug_bfd): Return gdb_bfd_ref_ptr.
2416         (find_separate_debug_file_by_buildid): Update.
2417
2418 2017-01-10  Tom Tromey  <tom@tromey.com>
2419
2420         * common/gdb_ref_ptr.h: New file.
2421         * python/py-ref.h (struct gdbpy_ref_policy): New.
2422         (gdbpy_ref): Now a typedef.
2423
2424 2017-01-10  Tom Tromey  <tom@tromey.com>
2425
2426         * utils.h (make_cleanup_htab_delete): Don't declare.
2427         * utils.c (do_htab_delete_cleanup, make_cleanup_htab_delete):
2428         Remove.
2429         * linespec.c (decode_compound_collector): Add constructor,
2430         destructor.
2431         (lookup_prefix_sym): Remove cleanup.
2432         (symtab_collector): Add constructor, destructor.
2433         (collect_symtabs_from_filename): Remove cleanup.
2434         * disasm.c (do_mixed_source_and_assembly): Use htab_up.
2435         * compile/compile-c-symbols.c (generate_c_for_variable_locations):
2436         Use htab_up.
2437         * gnu-v3-abi.c (gnuv3_print_vtable): Use htab_up.
2438         * dwarf2read.c (dw2_expand_symtabs_matching)
2439         (dw2_map_symbol_filenames, dwarf_decode_macros)
2440         (write_psymtabs_to_index): Use htab_up.
2441         * dwarf2loc.c (func_verify_no_selftailcall)
2442         (call_site_find_chain_1, func_verify_no_selftailcall)
2443         (chain_candidate, call_site_find_chain_1): Use std::unordered_set,
2444         std::vector, gdb::unique_xmalloc_ptr.
2445         (call_sitep): Remove typedef.
2446         (dwarf2_locexpr_baton_eval): Remove unused variable.
2447
2448 2017-01-10  Tom Tromey  <tom@tromey.com>
2449
2450         * python/python-internal.h (make_cleanup_py_decref)
2451         (make_cleanup_py_xdecref): Don't declare.
2452         * python/py-utils.c (py_decref, make_cleanup_py_decref)
2453         (py_xdecref, make_cleanup_py_xdecref): Remove.
2454
2455 2017-01-10  Tom Tromey  <tom@tromey.com>
2456
2457         * python/py-framefilter.c (py_mi_print_variables): Use gdbpy_ref.
2458         (py_print_locals, enumerate_locals, py_print_args): Use gdbpy_ref.
2459
2460 2017-01-10  Tom Tromey  <tom@tromey.com>
2461
2462         * python/py-framefilter.c (enumerate_args): Use gdbpy_ref.
2463
2464 2017-01-10  Tom Tromey  <tom@tromey.com>
2465
2466         * python/py-utils.c (unicode_to_encoded_string)
2467         (python_string_to_target_string)
2468         (python_string_to_target_python_string)
2469         (python_string_to_host_string, gdbpy_obj_to_string)
2470         (get_addr_from_python): Use gdbpy_ref.
2471
2472 2017-01-10  Tom Tromey  <tom@tromey.com>
2473
2474         * python/py-unwind.c (pyuw_object_attribute_to_pointer): Use
2475         gdbpy_ref.
2476
2477 2017-01-10  Tom Tromey  <tom@tromey.com>
2478
2479         * python/python.c (eval_python_command, gdbpy_decode_line)
2480         (gdbpy_run_events, gdbpy_start_type_printers)
2481         (gdbpy_apply_type_printers): Use gdbpy_ref.
2482
2483 2017-01-10  Tom Tromey  <tom@tromey.com>
2484
2485         * python/py-param.c (get_doc_string, compute_enum_values): Use
2486         gdbpy_ref.
2487
2488 2017-01-10  Tom Tromey  <tom@tromey.com>
2489
2490         * python/py-inferior.c (find_thread_object, build_inferior_list):
2491         Use gdbpy_ref.
2492
2493 2017-01-10  Tom Tromey  <tom@tromey.com>
2494
2495         * python/py-framefilter.c (py_print_frame): Use gdbpy_ref.
2496
2497 2017-01-10  Tom Tromey  <tom@tromey.com>
2498
2499         * python/py-finishbreakpoint.c (bpfinishpy_out_of_scope): Use
2500         gdbpy_ref.
2501
2502 2017-01-10  Tom Tromey  <tom@tromey.com>
2503
2504         * python/py-cmd.c (cmdpy_completer_helper): Use gdbpy_ref.  Remove
2505         extra incref.
2506         (cmdpy_completer_handle_brkchars, cmdpy_completer, cmdpy_init):
2507         Use gdbpy_ref.
2508
2509 2017-01-10  Tom Tromey  <tom@tromey.com>
2510
2511         * python/py-breakpoint.c (gdbpy_breakpoint_cond_says_stop): Use
2512         gdbpy_ref.
2513
2514 2017-01-10  Tom Tromey  <tom@tromey.com>
2515
2516         * python/py-arch.c (archpy_disassemble): Use gdbpy_ref.  Don't
2517         decref results of PyArg_ParseTupleAndKeywords.
2518
2519 2017-01-10  Tom Tromey  <tom@tromey.com>
2520
2521         * python/python.c (python_run_simple_file): Use
2522         unique_xmalloc_ptr, gdbpy_ref.
2523
2524 2017-01-10  Tom Tromey  <tom@tromey.com>
2525
2526         * python/py-prettyprint.c (print_stack_unless_memory_error)
2527         (print_string_repr, print_children): Use gdbpy_ref.
2528         (dummy_python_frame): New class.
2529         (dummy_python_frame::dummy_python_frame): Rename from
2530         push_dummy_python_frame.
2531         (py_restore_tstate): Remove.
2532
2533 2017-01-10  Tom Tromey  <tom@tromey.com>
2534
2535         * python/py-framefilter.c (py_print_frame): Use gdbpy_ref.
2536
2537 2017-01-10  Tom Tromey  <tom@tromey.com>
2538
2539         * python/python.c (ensure_python_env, restore_python_env):
2540         Remove.
2541         * python/python-internal.h (ensure_python_env): Don't declare.
2542         * varobj.h (varobj_ensure_python_env): Don't declare.
2543         * varobj.c (varobj_ensure_python_env): Remove.
2544
2545 2017-01-10  Tom Tromey  <tom@tromey.com>
2546
2547         * varobj.c (varobj_value_get_print_value): Use
2548         gdbpy_enter_varobj.
2549
2550 2017-01-10  Tom Tromey  <tom@tromey.com>
2551
2552         * python/py-prettyprint.c (print_string_repr, print_children):
2553         Update.
2554         * python/py-lazy-string.c (gdbpy_extract_lazy_string): Change type
2555         of "encoding".
2556         * varobj.c (varobj_value_get_print_value): Update.
2557         * python/python-internal.h (gdbpy_extract_lazy_string): Update.
2558
2559 2017-01-10  Tom Tromey  <tom@tromey.com>
2560
2561         * varobj.c (varobj_get_display_hint)
2562         (dynamic_varobj_has_child_method, install_new_value_visualizer)
2563         (varobj_set_visualizer, free_variable): Use
2564         gdbpy_enter_varobj.
2565
2566 2017-01-10  Tom Tromey  <tom@tromey.com>
2567
2568         * python/python.c (python_command): Use gdbpy_enter, gdbpy_ref.
2569         (do_finish_initialization): New function.  Use gdbpy_ref.
2570         (gdbpy_finish_initialization): Use gdbpy_enter.  Call
2571         do_finish_initialization.
2572
2573 2017-01-10  Tom Tromey  <tom@tromey.com>
2574
2575         * python/py-param.c (get_set_value, get_show_value): Use
2576         gdbpy_enter, gdbpy_ref.
2577
2578 2017-01-10  Tom Tromey  <tom@tromey.com>
2579
2580         * python/py-function.c (fnpy_call): Use gdbpy_enter, gdbpy_ref.
2581
2582 2017-01-10  Tom Tromey  <tom@tromey.com>
2583
2584         * python/py-cmd.c (cmdpy_function): Use gdbpy_enter, gdbpy_ref.
2585
2586 2017-01-10  Tom Tromey  <tom@tromey.com>
2587
2588         * python/py-varobj.c (py_varobj_iter_dtor, py_varobj_iter_next):
2589         Use gdbpy_enter_varobj.
2590
2591 2017-01-10  Tom Tromey  <tom@tromey.com>
2592
2593         * varobj.c (gdbpy_enter_varobj): New constructor.
2594         * python/python-internal.h (gdbpy_enter_varobj): New class.
2595         * python/py-varobj.c (py_varobj_get_iterator): Use
2596         gdbpy_enter_varobj.
2597
2598 2017-01-10  Tom Tromey  <tom@tromey.com>
2599
2600         * python/py-xmethods.c (gdbpy_get_xmethod_result_type): Use
2601         gdbpy_enter, gdbpy_ref, unique_xmalloc_ptr.
2602         (gdbpy_invoke_xmethod): Use gdbpy_ref, gdbpy_enter.
2603         (gdbpy_get_xmethod_arg_types): Use gdbpy_ref,
2604         unique_xmalloc_ptr.
2605         (gdbpy_get_xmethod_arg_types): Use gdbpy_ref, gdbpy_enter.
2606
2607 2017-01-10  Tom Tromey  <tom@tromey.com>
2608
2609         * python/py-xmethods.c (invoke_match_method): Use
2610         gdbpy_ref.
2611
2612 2017-01-10  Tom Tromey  <tom@tromey.com>
2613
2614         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): use
2615         gdbpy_enter, gdbpy_ref.
2616
2617 2017-01-10  Tom Tromey  <tom@tromey.com>
2618
2619         * python/python.c (python_interactive_command): Use gdbpy_enter.
2620
2621 2017-01-10  Tom Tromey  <tom@tromey.com>
2622
2623         * python/python.c (gdbpy_before_prompt_hook): Use gdbpy_enter,
2624         gdbpy_ref.
2625
2626 2017-01-10  Tom Tromey  <tom@tromey.com>
2627
2628         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Use
2629         gdbpy_enter, gdbpy_ref, unique_xmalloc_ptr.
2630
2631 2017-01-10  Tom Tromey  <tom@tromey.com>
2632
2633         * utils.h (htab_deleter): New struct.
2634         (htab_up): New typedef.
2635         * python/py-framefilter.c (gdbpy_apply_frame_filter): Use
2636         gdbpy_enter, gdbpy_ref, htab_up.
2637
2638 2017-01-10  Tom Tromey  <tom@tromey.com>
2639
2640         * python/py-unwind.c (pending_frame_invalidate): Remove.
2641         (pyuw_sniffer): Use gdbpy_enter and gdbpy_ref.
2642
2643 2017-01-10  Tom Tromey  <tom@tromey.com>
2644
2645         * python/py-xmethods.c (gdbpy_free_xmethod_worker_data)
2646         (gdbpy_clone_xmethod_worker_data): Use gdbpy_enter.
2647
2648 2017-01-10  Tom Tromey  <tom@tromey.com>
2649
2650         * python/py-type.c (save_objfile_types): Use gdbpy_enter.
2651
2652 2017-01-10  Tom Tromey  <tom@tromey.com>
2653
2654         * python/python.c (gdbpy_eval_from_control_command)
2655         (gdbpy_source_script, gdbpy_run_events)
2656         (gdbpy_source_objfile_script, gdbpy_execute_objfile_script)
2657         (gdbpy_free_type_printers, gdbpy_finish_initialization): Use
2658         gdbpy_enter.
2659
2660 2017-01-10  Tom Tromey  <tom@tromey.com>
2661
2662         * python/py-progspace.c (py_free_pspace): Use gdbpy_enter.
2663
2664 2017-01-10  Tom Tromey  <tom@tromey.com>
2665
2666         * python/py-objfile.c (py_free_objfile): Use gdbpy_enter.
2667
2668 2017-01-10  Tom Tromey  <tom@tromey.com>
2669
2670         * python/py-inferior.c (python_on_normal_stop, python_on_resume)
2671         (python_on_inferior_call_pre, python_on_inferior_call_post)
2672         (python_on_memory_change, python_on_register_change)
2673         (python_inferior_exit, python_new_objfile, add_thread_object)
2674         (delete_thread_object, py_free_inferior): Use gdbpy_enter.
2675
2676 2017-01-10  Tom Tromey  <tom@tromey.com>
2677
2678         * python/py-finishbreakpoint.c (bpfinishpy_handle_stop)
2679         (bpfinishpy_handle_exit): Use gdbpy_enter.
2680
2681 2017-01-10  Tom Tromey  <tom@tromey.com>
2682
2683         * python/py-cmd.c (cmdpy_destroyer)
2684         (cmdpy_completer_handle_brkchars, cmdpy_completer): Use
2685         gdbpy_enter.
2686
2687 2017-01-10  Tom Tromey  <tom@tromey.com>
2688
2689         * python/py-breakpoint.c (gdbpy_breakpoint_cond_says_stop): Use
2690         gdbpy_enter.
2691         (gdbpy_breakpoint_has_cond): Likewise.
2692
2693 2017-01-10  Tom Tromey  <tom@tromey.com>
2694
2695         * python/python.c (gdbpy_enter): New constructor.
2696         (~gdbpy_enter): New destructor.
2697         (restore_python_env, ensure_python_env): Rewrite.
2698         * python/python-internal.h (gdbpy_enter): New class.
2699
2700 2017-01-10  Tom Tromey  <tom@tromey.com>
2701
2702         * python/py-symbol.c (gdbpy_lookup_symbol): Use gdbpy_ref.
2703
2704 2017-01-10  Tom Tromey  <tom@tromey.com>
2705
2706         * python/py-value.c (value_has_field, get_field_flag)
2707         (get_field_type, valpy_getitem, convert_value_from_python): Use
2708         gdbpy_ref.
2709
2710 2017-01-10  Tom Tromey  <tom@tromey.com>
2711
2712         * python/python.c (gdbpy_progspaces, gdbpy_objfiles): Use
2713         gdbpy_ref.
2714
2715 2017-01-10  Tom Tromey  <tom@tromey.com>
2716
2717         * python/py-prettyprint.c (search_pp_list)
2718         (find_pretty_printer_from_objfiles)
2719         (find_pretty_printer_from_progspace)
2720         (find_pretty_printer_from_gdb, find_pretty_printer)
2721         (gdbpy_get_display_hint, gdbpy_get_varobj_pretty_printer): Use
2722         gdbpy_ref.
2723
2724 2017-01-10  Tom Tromey  <tom@tromey.com>
2725
2726         * python/py-param.c (call_doc_function): Use gdbpy_ref.
2727
2728 2017-01-10  Tom Tromey  <tom@tromey.com>
2729
2730         * python/py-linetable.c (build_line_table_tuple_from_pcs)
2731         (ltpy_get_all_source_lines): Use gdbpy_ref.
2732
2733 2017-01-10  Tom Tromey  <tom@tromey.com>
2734
2735         * python/py-framefilter.c (extract_sym, extract_value)
2736         (get_py_iter_from_func, bootstrap_python_frame_filters): Use
2737         gdbpy_ref.
2738
2739 2017-01-10  Tom Tromey  <tom@tromey.com>
2740
2741         * python/py-breakpoint.c (gdbpy_breakpoints): Use gdbpy_ref.
2742
2743 2017-01-10  Tom Tromey  <tom@tromey.com>
2744
2745         * python/py-inferior.c (gdbpy_inferiors): Use gdbpy_ref.
2746
2747 2017-01-10  Tom Tromey  <tom@tromey.com>
2748
2749         * python/py-function.c (convert_values_to_python, fnpy_init): Use
2750         gdbpy_ref.
2751
2752 2017-01-10  Tom Tromey  <tom@tromey.com>
2753
2754         * python/py-cmd.c (gdbpy_string_to_argv): Use gdbpy_ref.
2755
2756 2017-01-10  Tom Tromey  <tom@tromey.com>
2757
2758         * python/py-type.c (convert_field, make_fielditem, typy_fields)
2759         (typy_range): Use gdbpy_ref.
2760
2761 2017-01-10  Tom Tromey  <tom@tromey.com>
2762
2763         * python/py-threadevent.c (create_thread_event_object): Use
2764         gdbpy_ref.
2765         * python/py-stopevent.c (create_stop_event_object): Simplify.
2766         (emit_stop_event): Use gdbpy_ref.
2767         * python/py-signalevent.c (create_signal_event_object): Use
2768         gdbpy_ref.
2769         * python/py-newobjfileevent.c (create_new_objfile_event_object)
2770         (emit_new_objfile_event, create_clear_objfiles_event_object)
2771         (emit_clear_objfiles_event): Use gdbpy_ref.
2772         * python/py-infevents.c (create_inferior_call_event_object)
2773         (create_register_changed_event_object)
2774         (create_memory_changed_event_object, emit_inferior_call_event)
2775         (emit_memory_changed_event, emit_register_changed_event): Use
2776         gdbpy_ref.
2777         * python/py-exitedevent.c (create_exited_event_object)
2778         (emit_exited_event): Use gdbpy_ref.
2779         * python/py-event.h (evpy_emit_event): Remove
2780         CPYCHECKER_STEALS_REFERENCE_TO_ARG annotation.
2781         * python/py-event.c (evpy_emit_event): Use gdbpy_ref.
2782         * python/py-continueevent.c (emit_continue_event): Use
2783         gdbpy_ref.
2784         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2785         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2786         gdbpy_ref.
2787         * python/py-bpevent.c (create_breakpoint_event_object): Use
2788         gdbpy_ref.
2789
2790 2017-01-10  Tom Tromey  <tom@tromey.com>
2791
2792         * python/py-ref.h: New file.
2793
2794 2017-01-10  Simon Marchi  <simon.marchi@ericsson.com>
2795
2796         * cli-out.c (cli_ui_out::do_redirect): Change return type to
2797         void.
2798         * cli-out.h (cli_ui_out::do_redirect): Likewise.
2799         * mi/mi-out.c (mi_ui_out::do_redirect): Likewise.
2800         * mi/mi-out.h (mi_ui_out::do_redirect): Likewise.
2801         * ui-out.c (ui_out::redirect): Likewise.
2802         * ui-out.h (ui_out::redirect, ui_out::do_redirect): Likewise.
2803         * cli/cli-logging.c (set_logging_redirect): Update call site of
2804         ui_out::redirect.
2805         (handle_redirections): Likewise.
2806         * scm-ports.c (ioscm_with_output_to_port_worker): Likewise.
2807         * top.c (execute_command_to_string): Likewise.
2808         * utils.c (do_ui_out_redirect_pop): Likewise.
2809
2810 2017-01-10  Simon Marchi  <simon.marchi@ericsson.com>
2811
2812         * stack.c (_initialize_stack): Update "frame" command help message.
2813
2814 2017-01-08  Iain Buclaw  <ibuclaw@gdcproject.org>
2815
2816         * d-exp.y (CastExpression): Emit UNOP_CAST_TYPE.
2817
2818 2017-01-06  Yao Qi  <yao.qi@linaro.org>
2819
2820         * x86-linux-nat.h: Include gdb_proc_service.h.
2821
2822 2017-01-06  Yao Qi  <yao.qi@linaro.org>
2823
2824         * ser-base.h: Include serial.h.
2825
2826 2017-01-06  Yao Qi  <yao.qi@linaro.org>
2827
2828         * ppc-linux-tdep.h: Include ppc-tdep.h.
2829
2830 2017-01-06  Yao Qi  <yao.qi@linaro.org>
2831
2832         * nat/amd64-linux-siginfo.h: Include signal.h.
2833
2834 2017-01-06  Yao Qi  <yao.qi@linaro.org>
2835
2836         * nat/aarch64-linux-hw-point.h: Include break-common.h.
2837
2838 2017-01-06  Yao Qi  <yao.qi@linaro.org>
2839
2840         * mi/mi-parse.h: Include mi-cmds.h.
2841
2842 2017-01-06  Yao Qi  <yao.qi@linaro.org>
2843
2844         * inf-loop.c: Don't include "target.h".
2845         * inf-loop.h: Include it here.
2846
2847 2017-01-06  Yao Qi  <yao.qi@linaro.org>
2848
2849         * dfp.h: Include "dboulest.h" and "expression.h".
2850
2851 2017-01-06  Yao Qi  <yao.qi@linaro.org>
2852
2853         * ax-gdb.h: Include "ax.h".
2854
2855 2017-01-06  Yao Qi  <yao.qi@linaro.org>
2856
2857         * Makefile.in (HFILES_NO_SRCDIR): Replace gdb_ptrace.h
2858         with nat/gdb_ptrace.h.
2859
2860 2017-01-05  Yao Qi  <yao.qi@linaro.org>
2861
2862         * mips-fbsd-tdep.c (mips_fbsd_sigframe_init): Move && to
2863         new line.
2864         (mips64_fbsd_sigframe_init): Likewise.
2865
2866 2017-01-04  John Baldwin  <jhb@FreeBSD.org>
2867
2868         * mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Use
2869         GDB_OSABI_FREEBSD instead of GDB_OSABI_FREEBSD_ELF.
2870
2871 2017-01-04  John Baldwin  <jhb@FreeBSD.org>
2872
2873         * Makefile.in (ALLDEPFILES): Add mips-fbsd-nat.c.
2874         * NEWS: Mention new FreeBSD/mips native configuration.
2875         * config/mips/fbsd.mh: New file.
2876         * configure.host: Add mips*-*-freebsd*.
2877         * mips-fbsd-nat.c: New file.
2878
2879 2017-01-04  John Baldwin  <jhb@FreeBSD.org>
2880
2881         * Makefile.in (ALL_TARGET_OBS): Add mips-fbsd-tdep.o.
2882         (ALLDEPFILES): Add mips-fbsd-tdep.c.
2883         * NEWS: Mention new FreeBSD/mips target.
2884         * configure.tgt: Add mips*-*-freebsd*.
2885         * mips-fbsd-tdep.c: New file.
2886         * mips-fbsd-tdep.h: New file.
2887
2888 2017-01-04  Yao Qi  <yao.qi@linaro.org>
2889
2890         * dwarf2loc.c (write_pieced_value): Don't use VALUE_FRAME_ID (to),
2891         use c->frame_id when the piece location is DWARF_VALUE_REGISTER.
2892
2893 2017-01-01  Joel Brobecker  <brobecker@adacore.com>
2894
2895         Update copyright year range in all GDB files.
2896
2897 2017-01-01  Joel Brobecker  <brobecker@adacore.com>
2898
2899         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2016.
2900
2901 For older changes see ChangeLog-2016.
2902 \f
2903 Local Variables:
2904 mode: change-log
2905 left-margin: 8
2906 fill-column: 74
2907 version-control: never
2908 coding: utf-8
2909 End: