gdb/ChangeLog

   1 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
   2
   3         * NEWS: Add debugredirect and testsuite sections.
   4
   5 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
   6
   7         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
   8         target descriptions using exclusively floating point register name
   9         aliases.
  10
  11 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
  12
  13         PR gdb/18644:
  14         * f-lang.c (build_fortran_types): Handle the case where
  15         gdbarch_floatformat_for_type returns a nullptr.
  16
  17 2019-05-21  Tom de Vries  <tdevries@suse.de>
  18
  19         PR cli/24587
  20         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
  21
  22 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
  23
  24         PR gdb/18644:
  25         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
  26         16-byte floats.
  27         * i386-tdep.c (i386_floatformat_for_type): Use
  28         floatformats_ia64_quad for the 16-byte floating point component
  29         within a fortran 32-byte complex number.
  30
  31 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
  32
  33         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
  34         delete default constructor.
  35         (find_partial_die): Update to return const struct.
  36         (partial_die_parent_scope): Move variable declaration into scope
  37         of its use and change its type to auto.
  38         (guess_partial_die_structure_name): Likewise.
  39         (partial_die_info::fixup): Likewise.
  40
  41 2019-05-17  Tom Tromey  <tromey@adacore.com>
  42
  43         * source.c (find_and_open_source): Remove cast.
  44
  45 2019-05-17  Tom Tromey  <tromey@adacore.com>
  46
  47         * annotate.c (annotate_source): Make "filename" const.
  48         * annotate.h (annotate_source): Use const.
  49
  50 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
  51
  52         * disasm.c (set_disassembler_options): Send errors to stderr.
  53
  54 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
  55
  56         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
  57         (cli_interp_base::set_logging): Check debug_redirect.
  58         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
  59         * cli/cli-logging.c (debug_redirect): Add static variable.
  60         (pop_output_files): Add default param.
  61         (handle_redirections): Print debug setting.
  62         (show_logging_command): Likewise.
  63         (_initialize_cli_logging): Add debugredirect command.
  64         * interps.c (current_interp_set_logging): Add debug_redirect
  65         parameter.
  66         * interps.h (set_logging): Add debug_redirect parameter.
  67         (current_interp_set_logging): Likewise.
  68         * mi/mi-common.h: Likewise.
  69         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
  70
  71 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
  72             Tom Tromey  <tromey@adacore.com>
  73
  74         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
  75         directly.
  76         * cli/cli-interp.h (make_logging_output): Remove declaration.
  77         * cli/cli-logging.c (make_logging_output): Remove function.
  78         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
  79         directly.
  80         * ui-file.c (tee_file::tee_file): Remove bools.
  81         (tee_file::~tee_file): Remove deletes.
  82         * ui-file.h (tee_file): Remove bools.
  83
  84 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
  85
  86         * mi/mi-cmds.h (mi_cmd_complete): New function.
  87         * mi/mi-main.c (mi_cmd_complete): Likewise.
  88         * mi/mi-cmds.c: Define new MI command -complete.
  89         * NEWS: Mention new -complete command.
  90
  91 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
  92
  93         * completer.h (complete): New function.
  94         * completer.c (complete): Likewise.
  95         * cli/cli-cmds.c: (complete_command): Update to use new complete()
  96         function defined in completer.h.
  97
  98 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
  99
 100        * MAINTAINERS (Write After Approval): Add myself.
 101
 102 2019-05-17  Tom de Vries  <tdevries@suse.de>
 103
 104         PR gdb/24094
 105         * dwarf2read.c (struct cu_partial_die_info): New struct.
 106         (find_partial_die): Return cu_partial_die_info.
 107         (partial_die_parent_scope, guess_partial_die_structure_name)
 108         (partial_die_info::fixup): Handle new return type of find_partial_die.
 109
 110 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 111
 112         * stap-probe.c (stap_parse_register_operand): Make "regname" an
 113         "std::string", simplifying the algorithm.
 114
 115 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 116
 117         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
 118         (stap_static_probe_ops::get_probes): Likewise.
 119
 120 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 121
 122         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
 123         '-')" and "else if".
 124         (stap_parse_single_operand): Join checks for
 125         "gdbarch_stap_parse_special_token_p" and
 126         "gdbarch_stap_parse_special_token" in the same "if" statement.
 127         Invert check when verifying for operation on register
 128         displacement.
 129
 130 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 131
 132         * stap-probe.c (stap_get_opcode): Update comment.
 133         (stap_get_expected_argument_type): Likewise.
 134         (handle_stap_probe): Likewise.
 135
 136 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 137
 138         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
 139         return type to 'bool'.  Adjust comment.  Use 'bool' when
 140         appropriate.
 141         (i386_stap_parse_special_token_three_arg_disp): Likewise.
 142         * stap-probe.c (stap_parse_argument_1): Likewise.
 143         (stap_is_operator): Likewise.
 144         (stap_is_generic_prefix): Likewise.
 145         (stap_is_register_prefix): Likewise.
 146         (stap_is_register_indirection_prefix): Likewise.
 147         (stap_is_integer_prefix): Likewise.
 148         (stap_generic_check_suffix): Likewise.
 149         (stap_check_integer_suffix): Likewise.
 150         (stap_check_register_suffix): Likewise.
 151         (stap_check_register_indirection_suffix): Likewise.
 152         (stap_parse_register_operand): Likewise.
 153         (stap_parse_single_operand): Likewise.
 154         (stap_parse_argument_1): Likewise.
 155         (stap_probe::get_argument_count): Likewise.
 156         (stap_is_operator): Likewise.
 157
 158 2019-05-16  Tom Tromey  <tromey@adacore.com>
 159
 160         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
 161         keyword to foreach.
 162
 163 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
 164
 165         * linux-thread-db.c (try_thread_db_load_1): Change return type
 166         to bool.
 167         (try_thread_db_load): Likewise.
 168         (try_thread_db_load_from_pdir_1): Likewise.
 169         (try_thread_db_load_from_pdir): Likewise.
 170         (try_thread_db_load_from_sdir): Likewise.
 171         (try_thread_db_load_from_dir): Likewise.
 172         (thread_db_load_search): Likewise.
 173         (has_libpthread): Likewise.
 174         (thread_db_load): Likewise.
 175
 176 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
 177
 178         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 179         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
 180         NULL, and complain/return if that's the case.
 181
 182 2019-05-15  John Darrington <john@darrington.wattle.id.au>
 183
 184         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
 185         (advance, posn, abstract_read_memory): New functions.
 186         [struct mem_read_abstraction]: New struct.
 187         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
 188
 189 2019-05-14  Tom Tromey  <tromey@adacore.com>
 190
 191         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
 192         value is not lval_memory.
 193
 194 2019-05-14  Tom Tromey  <tromey@adacore.com>
 195
 196         * solib.c (info_sharedlibrary_command): Style the file name.
 197
 198 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
 199
 200         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
 201         (aarch64_vnv_type): Likewise.
 202         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
 203         * common/tdesc.c: Likewise.
 204         * common/tdesc.h (enum tdesc_type_kind): Likewise.
 205         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
 206         * features/aarch64-fpu.xml: Add ieee half view.
 207         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
 208         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
 209         * gdbtypes.h (struct builtin_type): Likewise.
 210         (struct objfile_type): Likewise.
 211
 212 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
 213
 214         * language.c (language_sniff_from_mangled_name): Fix "langauge"
 215         typo.
 216         * location.h (string_to_event_location): Likewise.
 217
 218 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
 219
 220         GDB 8.3 released.
 221
 222 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 223
 224         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
 225         New variable declaration.
 226         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
 227         New variable.
 228         (print_one_breakpoint): Use ui_out::test_flags and new global
 229         variable to compute use_fixed_output.
 230         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
 231         Remove.
 232         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
 233         (mi_multi_location_breakpoint_output_fixed): Remove.
 234         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
 235         new variable.
 236         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
 237         fix_multi_location_breakpoint_output flag if version >= 3.
 238         * ui-out.h (enum ui_out_flag)
 239         <fix_multi_location_breakpoint_output>: New enumerator.
 240
 241 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 242
 243         * contrib/cc-with-tweaks.sh: Validate dwz's work.
 244
 245 2019-05-10  Tom Tromey  <tromey@adacore.com>
 246
 247         * ada-lang.c (catch_ada_completer): New function.
 248         (_initialize_ada_language): Use it.
 249
 250 2019-05-10  Tom Tromey  <tromey@adacore.com>
 251
 252         * thread.c (print_thread_info): Make "requested_threads" const.
 253         * gdbthread.h (print_thread_info): Make "requested_threads"
 254         const.
 255         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
 256         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
 257
 258 2019-05-08  Tom Tromey  <tom@tromey.com>
 259
 260         * gdbtypes.c (objfile_type_data): Change type.
 261         (objfile_type, _initialize_gdbtypes): Update.
 262
 263 2019-05-08  Tom Tromey  <tom@tromey.com>
 264
 265         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
 266         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
 267         (_initialize_dwarf2_frame): Update.
 268
 269 2019-05-08  Tom Tromey  <tom@tromey.com>
 270
 271         * objc-lang.c (objc_objfile_data): Change type.
 272         (find_methods): Update.
 273         (_initialize_objc_lang): Remove.
 274
 275 2019-05-08  Tom Tromey  <tom@tromey.com>
 276
 277         * stabsread.c (rs6000_builtin_type_data): Change type.
 278         (rs6000_builtin_type, _initialize_stabsread): Update.
 279
 280 2019-05-08  Tom Tromey  <tom@tromey.com>
 281
 282         * mips-tdep.c (mips_pdr_data): Remove.
 283         (_initialize_mips_tdep): Update.
 284
 285 2019-05-08  Tom Tromey  <tom@tromey.com>
 286
 287         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
 288         (hppa_init_objfile_priv_data, read_unwind_info)
 289         (find_unwind_entry, _initialize_hppa_tdep): Update.
 290
 291 2019-05-08  Tom Tromey  <tom@tromey.com>
 292
 293         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
 294         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
 295         on obstack.
 296         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
 297
 298 2019-05-08  Tom Tromey  <tom@tromey.com>
 299
 300         * mdebugread.c (basic_type_data): Change type.
 301         (basic_type, _initialize_mdebugread): Update.
 302
 303 2019-05-08  Tom Tromey  <tom@tromey.com>
 304
 305         * common/gdb_unique_ptr.h (struct noop_deleter): New.
 306
 307 2019-05-08  Tom Tromey  <tom@tromey.com>
 308
 309         * nto-tdep.c (nto_inferior_data_reg): Change type.
 310         (nto_inferior_data): Update.
 311         (nto_inferior_data_cleanup, nto_new_inferior_data)
 312         (_initialize_nto_tdep): Remove.
 313         * nto-tdep.h (struct nto_inferior_data): Add initializers.
 314
 315 2019-05-08  Tom Tromey  <tom@tromey.com>
 316
 317         * ada-lang.c (struct ada_inferior_data): Add initializers.
 318         (ada_inferior_data): Change type.
 319         (ada_inferior_data_cleanup): Remove.
 320         (get_ada_inferior_data, ada_inferior_exit)
 321         (struct ada_pspace_data): Add initializers, destructor.
 322         (ada_pspace_data_handle): Change type.
 323         (get_ada_pspace_data): Update.
 324         (ada_pspace_data_cleanup): Remove.
 325
 326 2019-05-08  Tom Tromey  <tom@tromey.com>
 327
 328         * coffread.c (struct coff_symfile_info): Add initializers.
 329         (coff_objfile_data_key): Move lower.  Change type.
 330         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
 331         Update.
 332         (coff_free_info): Remove.
 333
 334 2019-05-08  Tom Tromey  <tom@tromey.com>
 335
 336         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
 337         (fbsd_pspace_data_handle): Move lower.  Change type.
 338         (get_fbsd_pspace_data): Update.
 339         (fbsd_pspace_data_cleanup): Remove.
 340         (_initialize_fbsd_tdep): Update.
 341
 342 2019-05-08  Tom Tromey  <tom@tromey.com>
 343
 344         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
 345         (get_ada_tasks_pspace_data): Update.
 346         (ada_tasks_pspace_data_cleanup): Remove.
 347         (_initialize_tasks): Update.
 348         (ada_tasks_inferior_data_handle): Change type.
 349         (get_ada_tasks_inferior_data): Update.
 350         (ada_tasks_inferior_data_cleanup): Remove.
 351         (struct ada_tasks_pspace_data): Add initializers.
 352
 353 2019-05-08  Tom Tromey  <tom@tromey.com>
 354
 355         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
 356         * symfile-debug.c (debug_sym_get_probes): Change type.
 357         * stap-probe.c (handle_stap_probe):
 358         (stap_static_probe_ops::get_probes): Change type.
 359         * probe.h (class static_probe_ops) <get_probes>: Change type.
 360         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
 361         (parse_probes_in_pspace): Update.
 362         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
 363         Update.
 364         (any_static_probe_ops::get_probes): Change type.
 365         * elfread.c (elfread_data): New typedef.
 366         (probe_key): Change type.
 367         (elf_get_probes): Likewise.  Update.
 368         (probe_key_free): Remove.
 369         (_initialize_elfread): Update.
 370         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
 371         Change type.
 372         (dtrace_process_dof_probe, dtrace_process_dof)
 373         (dtrace_static_probe_ops::get_probe): Change type.
 374
 375 2019-05-08  Tom Tromey  <tom@tromey.com>
 376
 377         * xcoffread.c (struct xcoff_symfile_info): Rename from
 378         coff_symfile_info.  Add initializers.
 379         (xcoff_objfile_data_key): Move lower.  Change type.
 380         (XCOFF_DATA): Rewrite.
 381         (xcoff_free_info): Remove.
 382         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
 383         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
 384         (xcoff_initial_scan): Update.
 385
 386 2019-05-08  Tom Tromey  <tom@tromey.com>
 387
 388         * solib-svr4.c (struct svr4_info): Add initializers and
 389         destructor.
 390         <probes_table>: Now an htab_up.
 391         (solib_svr4_pspace_data): Change type.
 392         (free_probes_table): Simplify.
 393         (~svr4_info): Rename from svr4_pspace_data_cleanup.
 394         (get_svr4_info, probes_table_htab_remove_objfile_probes)
 395         (probes_table_remove_objfile_probes, register_solib_event_probe)
 396         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
 397         (_initialize_svr4_solib): Update.
 398
 399 2019-05-08  Tom Tromey  <tom@tromey.com>
 400
 401         * remote.c (remote_pspace_data): Change type.
 402         (remote_pspace_data_cleanup): Remove.
 403         (get_remote_exec_file, set_pspace_remote_exec_file)
 404         (_initialize_remote): Update.
 405
 406 2019-05-08  Tom Tromey  <tom@tromey.com>
 407
 408         * breakpoint.c (breakpoint_objfile_key): Change type.
 409         (get_breakpoint_objfile_data): Update.
 410         (free_breakpoint_objfile_data): Remove.
 411         (_initialize_breakpoint): Update.
 412
 413 2019-05-08  Tom Tromey  <tom@tromey.com>
 414
 415         * linux-tdep.c (struct linux_info): Add initializers.
 416         (linux_inferior_data): Move.  Change type.
 417         (invalidate_linux_cache_inf): Update.
 418         (linux_inferior_data_cleanup): Remove.
 419         (get_linux_inferior_data, _initialize_linux_tdep): Update.
 420
 421 2019-05-08  Tom Tromey  <tom@tromey.com>
 422
 423         * auxv.c (auxv_inferior_data): Move.  Change type.
 424         (auxv_inferior_data_cleanup): Remove.
 425         (invalidate_auxv_cache_inf): Rewrite.
 426         (get_auxv_inferior_data, _initialize_auxv): Update.
 427
 428 2019-05-08  Tom Tromey  <tom@tromey.com>
 429
 430         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
 431         (symfile_debug_objfile_data_key): Change type.
 432         (symfile_debug_installed, debug_qf_has_symbols)
 433         (debug_qf_find_last_source_symtab)
 434         (debug_qf_forget_cached_source_info)
 435         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
 436         (debug_qf_print_stats, debug_qf_dump)
 437         (debug_qf_expand_symtabs_for_function)
 438         (debug_qf_expand_all_symtabs)
 439         (debug_qf_expand_symtabs_with_fullname)
 440         (debug_qf_map_matching_symbols)
 441         (debug_qf_expand_symtabs_matching)
 442         (debug_qf_find_pc_sect_compunit_symtab)
 443         (debug_qf_map_symbol_filenames)
 444         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
 445         (debug_sym_new_init, debug_sym_init, debug_sym_read)
 446         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
 447         (debug_sym_read_linetable, debug_sym_relocate): Update.
 448         (symfile_debug_free_objfile): Remove.
 449         (install_symfile_debug_logging, _initialize_symfile_debug):
 450         Update.
 451
 452 2019-05-08  Tom Tromey  <tom@tromey.com>
 453
 454         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
 455         allocate_on_obstack.
 456         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
 457         (get_dwarf2_per_objfile): Update.
 458         (set_dwarf2_per_objfile): Remove.
 459         (dwarf2_has_info, dwarf2_get_section_info): Update.
 460         (dwarf2_free_objfile): Remove.
 461         (_initialize_dwarf2_read): Update.
 462
 463 2019-05-08  Tom Tromey  <tom@tromey.com>
 464
 465         * auto-load.c (struct auto_load_pspace_info): Add destructor and
 466         initializers.
 467         <unsupported_script_warning_printed,
 468         script_not_found_warning_printed>: Now bool.
 469         (auto_load_pspace_data): Change type.
 470         (~auto_load_pspace_info): Rename from
 471         auto_load_pspace_data_cleanup.
 472         (get_auto_load_pspace_data, init_loaded_scripts_info)
 473         (clear_section_scripts, maybe_print_unsupported_script_warning)
 474         (maybe_print_script_not_found_warning, _initialize_auto_load):
 475         Update.
 476
 477 2019-05-08  Tom Tromey  <tom@tromey.com>
 478
 479         * objfiles.c (objfile_pspace_info): Add destructor and
 480         initializers.
 481         (objfiles_pspace_data): Change type.
 482         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
 483         (get_objfile_pspace_data): Update.
 484         (objfiles_bfd_data): Change type.
 485         (get_objfile_bfd_data): Update.
 486         (objfile_bfd_data_free, _initialize_objfiles): Remove.
 487
 488 2019-05-08  Tom Tromey  <tom@tromey.com>
 489
 490         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
 491         Change type.
 492         (get_catch_syscall_inferior_data): Update.
 493         (catch_syscall_inferior_data_cleanup): Remove.
 494         (_initialize_break_catch_syscall): Update.
 495
 496 2019-05-08  Tom Tromey  <tom@tromey.com>
 497
 498         * inflow.c (struct terminal_info): Add destructor and
 499         initializers.
 500         (inflow_inferior_data): Change type.
 501         (~terminal_info): Rename from inflow_inferior_data_cleanup.
 502         (get_inflow_inferior_data, inflow_inferior_exit)
 503         (swap_terminal_info, _initialize_inflow): Update.
 504
 505 2019-05-08  Tom Tromey  <tom@tromey.com>
 506
 507         * target-dcache.c (target_dcache_cleanup): Remove.
 508         (target_dcache_aspace_key): Change type.
 509         (target_dcache_init_p, target_dcache_invalidate)
 510         (target_dcache_get, target_dcache_get_or_init)
 511         (_initialize_target_dcache): Update.
 512         * dcache.h (struct dcache_deleter): New.
 513
 514 2019-05-08  Tom Tromey  <tom@tromey.com>
 515
 516         * symtab.c (struct symbol_cache): Add destructor and
 517         initializers.
 518         (symbol_cache_key): Move.  Change type.
 519         (make_symbol_cache, free_symbol_cache): Remove.
 520         (get_symbol_cache): Update.
 521         (symbol_cache_cleanup): Remove.
 522         (ALL_PSPACES, symbol_cache_flush)
 523         (maintenance_print_symbol_cache)
 524         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
 525         Update.
 526
 527 2019-05-08  Tom Tromey  <tom@tromey.com>
 528
 529         * symtab.c (struct main_info): Add destructor and initializers.
 530         (main_progspace_key): Move.  Change type.
 531         (get_main_info): Update.
 532         (main_info_cleanup): Remove.
 533         (_initialize_symtab): Update.
 534
 535 2019-05-08  Tom Tromey  <tom@tromey.com>
 536
 537         * registry.h (DECLARE_REGISTRY): Define the _key class.
 538
 539 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 540
 541         * NEWS: Merge two 'New commands' sections.
 542
 543 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 544
 545         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 546         parameter and use Ada language definition instead.
 547         (ada_val_print_ptr): Remove unused language parameter.
 548         (ada_val_print_num): Remove language parameter and use Ada language
 549         definition instead.
 550         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 551         parameter.
 552         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 553         parameter and use Ada language definition instead.
 554         (ada_val_print_1): Update all ada_val_print_xxx calls.
 555         Remove language parameter.
 556         (ada_val_print): Update ada_val_print_1 call.
 557
 558 2019-05-08  Tom Tromey  <tromey@adacore.com>
 559
 560         * remote.c (remote_hw_watchpoint_limit)
 561         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 562         Now static.
 563
 564 2019-05-08  Tom Tromey  <tromey@adacore.com>
 565
 566         * maint.c (_initialize_maint_cmds): Move initialization code to
 567         remote.c.
 568         (watchdog, show_watchdog): Move to remote.c.
 569         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 570         "watchdog" static.
 571         (_initialize_remote): Move initialization code from maint.c.
 572         * defs.h (watchdog): Don't declare.
 573
 574 2019-05-08  Tom Tromey  <tromey@adacore.com>
 575
 576         * tui/tui-interp.c: Include main.h.
 577         * interps.c: Include main.h.
 578         * main.h (interpreter_p): Declare.
 579         * defs.h (interpreter_p): Don't declare.
 580
 581 2019-05-08  Tom Tromey  <tromey@adacore.com>
 582
 583         * dwarf2loc.c: Include dwarf2read.h.
 584         * defs.h (read_unsigned_leb128): Don't declare.
 585         * dwarf2read.h (read_unsigned_leb128): Declare.
 586
 587 2019-05-08  Tom Tromey  <tromey@adacore.com>
 588
 589         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 590         method.
 591
 592 2019-05-08  Tom Tromey  <tromey@adacore.com>
 593
 594         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 595         when no wrap column is set.
 596
 597 2019-05-08  Tom Tromey  <tromey@adacore.com>
 598
 599         * c-lang.c (c_get_string): Handle non-C-style arrays.
 600
 601 2019-05-08  Tom Tromey  <tromey@adacore.com>
 602
 603         * typeprint.c (print_offset_data::update): Print the bit offset,
 604         not the number of bits remaining.
 605
 606 2019-05-08  Tom Tromey  <tromey@adacore.com>
 607
 608         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 609         padding at end of comment.
 610
 611 2019-05-08  Tom Tromey  <tromey@adacore.com>
 612
 613         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 614         Compare main types.
 615
 616 2019-05-06  Tom Tromey  <tom@tromey.com>
 617
 618         * common/scoped_mmap.c: Include common-defs.h.
 619         * common/scoped_mmap.h: Don't include config.h.
 620
 621 2019-05-04  Tom Tromey  <tom@tromey.com>
 622
 623         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 624         (struct aarch64_call_info): Add initializers.
 625         <si>: Now a std::vector.
 626         (pass_on_stack, aarch64_push_dummy_call): Update.
 627
 628 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 629             Tom Tromey  <tom@tromey.com>
 630
 631         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 632         (ppc_threads): Now a std::vector.  Now static.
 633         (hwdebug_find_thread_points_by_tid)
 634         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 635         Update.
 636
 637 2019-05-04  Tom Tromey  <tom@tromey.com>
 638
 639         * arc-tdep.c (arc_tdesc_init): Return bool.
 640
 641 2019-05-04  Tom Tromey  <tom@tromey.com>
 642
 643         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 644         Use gdb_assert_not_reached.
 645
 646 2019-05-04  Tom Tromey  <tom@tromey.com>
 647
 648         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 649         "false".
 650
 651 2019-05-04  Tom Tromey  <tom@tromey.com>
 652
 653         * arc-tdep.c (arc_tdesc_init): Use bool.
 654
 655 2019-05-04  Tom Tromey  <tom@tromey.com>
 656
 657         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 658
 659 2019-05-04  Tom Tromey  <tom@tromey.com>
 660
 661         * cli/cli-cmds.c (valid_command_p): Return bool.
 662
 663 2019-05-04  Tom Tromey  <tom@tromey.com>
 664
 665         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 666         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 667
 668 2019-05-04  Raul Tambre  <raul@tambre.ee>
 669
 670         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 671         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 672         operator for comparison.
 673
 674 2019-05-04  Tom Tromey  <tom@tromey.com>
 675
 676         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 677         (lookup_partial_symbol, print_partial_symbols)
 678         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 679         (psymbol_compare): Update.
 680         (add_psymbol_to_bcache): Clear the entire psymbol.
 681         (maintenance_check_psymtabs): Update.
 682         * psympriv.h (struct partial_symbol): Don't derive from
 683         general_symbol_info.
 684         <obj_section, unrelocated_address, address,
 685         set_unrelocated_address>: Update.
 686         <ginfo>: New member.
 687         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 688         (debug_names::write_psymbols): Update.
 689
 690 2019-05-04  Tom de Vries  <tdevries@suse.de>
 691
 692         * contrib/cc-with-tweaks.sh: Support -n arg.
 693
 694 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 695
 696         * corelow.c (core_target::detach): Ensure frame cache and
 697         register caches are cleared.
 698         inferior.c (exit_inferior_1): Likewise.
 699
 700 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 701             Tom Tromey  <tom@tromey.com>
 702
 703         * dictionary.c (collate_pending_symbols_by_language): Remove
 704         "struct" from foreach.
 705         * symtab.c (lookup_global_symbol_from_objfile)
 706         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 707         foreach.
 708         * ser-tcp.c (net_open): Remove "struct" from foreach.
 709         * objfiles.c (objfile_relocate, objfile_rebase)
 710         (objfile_has_symbols): Remove "struct" from foreach.
 711         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 712         from foreach.
 713         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 714         foreach.
 715         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 716         "struct" from foreach.
 717         * ada-lang.c (create_excep_cond_exprs)
 718         (ada_exception_catchpoint_cond_string): Remove "struct" from
 719         foreach.
 720
 721 2019-05-03  Tom Tromey  <tromey@adacore.com>
 722
 723         * ada-exp.y (convert_char_literal): Check suffix of each
 724         enumerator.
 725
 726 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 727
 728         PR ada/21406:
 729         * ada-exp.y (yywrap): Don't define.
 730         * ada-lex.l (%option): Add noyywrap
 731         (yywrap): Remove.
 732
 733 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 734
 735         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 736         _WIN32_WINNT to the XP level, unless already defined to a higher
 737         level.
 738
 739         * unittests/parse-connection-spec-selftests.c:
 740         * ser-tcp.c:
 741         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 742         override.
 743
 744         * symfile.c (find_separate_debug_file): Remove colon from the
 745         drive spec of DOS/Windows file names of the target, so that the
 746         file name produced from DEBUGDIR and the target's directory will
 747         be valid on DOS/Windows systems.
 748
 749 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 750
 751         * rust-lang.c (val_print_struct): Handle printing structures
 752         containing strings.
 753
 754 2019-05-02  Tom Tromey  <tromey@adacore.com>
 755
 756         * valarith.c (_initialize_valarith): Remove.
 757
 758 2019-05-01  Tom Tromey  <tromey@adacore.com>
 759
 760         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 761         bitfields.
 762
 763 2019-05-01  Tom Tromey  <tromey@adacore.com>
 764
 765         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 766         for big-endian copies.
 767
 768 2019-04-30  Ali Tamur  <tamur@google.com>
 769         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 770         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 771         (read_3_bytes): New function.
 772
 773 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 774
 775         * windows-nat.c (main_thread_id): Delete.
 776         (handle_output_debug_string): Replace main_thread_id by
 777         current_event.dwThreadId.
 778         (fake_create_process): Likewise.
 779         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 780         Do not set main_thread_id.
 781         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 782         current_event.dwThreadId.
 783         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 784
 785 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 786
 787         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 788         Use current_event.dwThreadId instead of main_thread_id.
 789
 790 2019-04-30  Tom Tromey  <tromey@adacore.com>
 791
 792         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 793         (create_excep_cond_exprs): Iterate over program spaces.
 794         (ada_exception_catchpoint_cond_string): Examine all minimal
 795         symbols for exception types.
 796
 797 2019-04-30  Tom Tromey  <tromey@adacore.com>
 798
 799         PR c++/24470:
 800         * dwarf2read.c (process_structure_scope): Handle case where type
 801         has template parameters but no symbol was created.
 802
 803 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 804             Chris January  <chris.january@arm.com>
 805
 806         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 807         qualifier.
 808         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 809
 810 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 811
 812         * f-typeprint.c (f_print_type): Update rules for printing
 813         whitespace.
 814         (f_type_print_varspec_suffix): Likewise.
 815
 816 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 817             Chris January  <chris.january@arm.com>
 818
 819         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 820         function arguments.
 821
 822 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 823
 824         * f-lang.c (build_fortran_types): Change name of void type to
 825         lower case.
 826         * f-typeprint.c (f_type_print_base): Print the name of the void
 827         type, rather than a fixed string.
 828         * f-valprint.c (f_decorations): Use lower case void string.
 829
 830 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 831             Chris January  <chris.january@arm.com>
 832
 833         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 834         types for Fortran.
 835
 836 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 837             Chris January  <chris.january@arm.com>
 838             David Lecomber  <david.lecomber@arm.com>
 839
 840         * f-exp.y (BINOP_INTRINSIC): New token.
 841         (exp): New parser rule handling BINOP_INTRINSIC.
 842         (f77_keywords): Add new builtin procedures.
 843         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 844         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 845         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 846         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 847         (print_unop_subexp_f): New function.
 848         (print_binop_subexp_f): New function.
 849         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 850         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 851         (dump_subexp_body_f): Likewise.
 852         (operator_check_f): Likewise.
 853         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 854         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 855
 856 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 857
 858         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 859         UNOP_KIND.
 860         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 861         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 862         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 863         (operator_length_f): New fuction.
 864         (print_subexp_f): New function.
 865         (op_name_f): New function.
 866         (dump_subexp_body_f): New function.
 867         (operator_check_f): New function.
 868         (exp_descriptor_f): Replace standard expression handling functions
 869         with new functions.
 870         * gdb/fortran-operator.def: New file.
 871         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 872         * gdb/std-operator.def: Remove UNOP_KIND.
 873
 874 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 875
 876         * std-operator.def: Remove unbalanced, stray double quote
 877         character.
 878
 879 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 880             Chris January  <chris.january@arm.com>
 881             Daniel Everett  <daniel.everett@arm.com>
 882             Nick Forrington  <nick.forrington@arm.com>
 883             Richard Bunt  <richard.bunt@arm.com>
 884
 885         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 886         of depth when printing anonymous structs or unions.
 887         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 888         Don't print either the top-level value, or the children if the
 889         max-depth is exceeded.
 890         (ppscm_print_children): When printing the key of a map, allow one
 891         extra level of depth.
 892         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 893         print either the top-level value, or the children if the max-depth
 894         is exceeded.
 895         (print_children): When printing the key of a map, allow one extra
 896         level of depth.
 897         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 898         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 899         (user_print_options): Initialise max_depth field.
 900         (val_print_scalar_or_string_type_p): New function.
 901         (val_print): Check to see if the max depth has been reached.
 902         (val_print_check_max_depth): Define new function.
 903         (show_print_max_depth): New function.
 904         (_initialize_valprint): Add 'print max-depth' option.
 905         * valprint.h (struct value_print_options) <max_depth>: New field.
 906         (val_print_check_max_depth): Declare new function.
 907         * NEWS: Document new feature.
 908
 909 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 910
 911         * ada-lang.c (ada_language_defn): Initialise new field.
 912         * c-lang.c (c_is_string_type_p): New function.
 913         (c_language_defn): Initialise new field.
 914         (cplus_language_defn): Initialise new field.
 915         (asm_language_defn): Initialise new field.
 916         (minimal_language_defn): Initialise new field.
 917         * c-lang.h (c_is_string_type_p): Declare new function.
 918         * d-lang.c (d_language_defn): Initialise new field.
 919         * f-lang.c (f_is_string_type_p): New function.
 920         (f_language_defn): Initialise new field.
 921         * go-lang.c (go_is_string_type_p): New function.
 922         (go_language_defn): Initialise new field.
 923         * language.c (default_is_string_type_p): New function.
 924         (unknown_language_defn): Initialise new field.
 925         (auto_language_defn): Initialise new field.
 926         * language.h (struct language_defn) <la_is_string_type_p>: New
 927         member variable.
 928         (default_is_string_type_p): Declare new function.
 929         * m2-lang.c (m2_language_defn): Initialise new field.
 930         * objc-lang.c (objc_language_defn): Initialise new field.
 931         * opencl-lang.c (opencl_language_defn): Initialise new field.
 932         * p-lang.c (pascal_is_string_type_p): New function.
 933         (pascal_language_defn): Initialise new field.
 934         * rust-lang.c (rust_is_string_type_p): New function.
 935         (rust_language_defn): Initialise new field.
 936
 937 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 938
 939         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 940         New field.
 941         * ada-lang.c (ada_language_defn): Initialise new field.
 942         * c-lang.c (c_language_defn): Likewise.
 943         (cplus_language_defn): Likewise.
 944         (asm_language_defn): Likewise.
 945         (minimal_language_defn): Likewise.
 946         * d-lang.c (d_language_defn): Likewise.
 947         * f-lang.c (f_language_defn): Likewise.
 948         * go-lang.c (go_language_defn): Likewise.
 949         * language.c (unknown_language_defn): Likewise.
 950         (auto_language_defn): Likewise.
 951         * m2-lang.c (m2_language_defn): Likewise.
 952         * objc-lang.c (objc_language_defn): Likewise.
 953         * opencl-lang.c (opencl_language_defn): Likewise.
 954         * p-lang.c (pascal_language_defn): Likewise.
 955         * rust-lang.c (rust_language_defn): Likewise.
 956
 957 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 958
 959         * ada-lang.c (ada_is_character_type): Change return type to bool.
 960         (ada_is_string_type): Likewise.
 961         * ada-lang.h (ada_is_character_type): Update declaration
 962         (ada_is_string_type): Likewise.
 963
 964 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 965
 966         Support style in 'frame|thread apply'
 967
 968         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 969         * record.c (record_start, record_stop): Update callers of
 970         execute_command_to_string with false.
 971         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 972         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 973         methods.
 974         (class string_file): New constructor with term_out parameter.
 975         Override methods term_out and can_emit_style_escape.  New member
 976         term_out.
 977         (class stdio_file): Override can_emit_style_escape.
 978         (class tee_file): Override term_out and can_emit_style_escape.
 979         * utils.h (can_emit_style_escape): Remove.
 980         * utils.c (can_emit_style_escape): Likewise.
 981         Update all callers of can_emit_style_escape (SOMESTREAM) to
 982         SOMESTREAM->can_emit_style_escape.
 983         * source-cache.c (source_cache::get_source_lines): Likewise.
 984         * stack.c (frame_apply_command_count): Call execute_command_to_string
 985         passing the term_out characteristic of the current gdb_stdout.
 986         * thread.c (thr_try_catch_cmd): Likewise.
 987         * top.c (execute_command_to_string): pass term_out parameter
 988         to construct the string_file for the command output.
 989         * ui-file.c (term_cli_styling): New function (most code moved
 990         from utils.c can_emit_style_escape).
 991         (string_file::string_file, string_file::can_emit_style_escape,
 992         stdio_file::can_emit_style_escape, tee_file::term_out,
 993         tee_file::can_emit_style_escape): New functions.
 994
 995 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 996
 997         * NEWS: Mention the new set|show may-call-functions.
 998         * infcall.c (may_call_functions_p): New variable.
 999         (show_may_call_functions_p): New function.
1000         (call_function_by_hand_dummy): Throws an error if not
1001         may-call-functions.
1002         (_initialize_infcall): Call add_setshow_boolean_cmd for
1003         may-call-functions.
1004
1005 2019-04-25  Keith Seitz  <keiths@redhat.com>
1006
1007         PR c++/24367
1008         * cp-support.c (inspect_type): Don't attempt substitutions
1009         of symbol with the same name.
1010
1011 2019-04-25  Tom Tromey  <tromey@adacore.com>
1012
1013         PR gdb/24475:
1014         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
1015         static.
1016
1017 2019-04-25  Tom Tromey  <tromey@adacore.com>
1018
1019         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
1020         rvalue reference.
1021         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
1022         (gdb_xml_parser::parse): Use std::move.
1023         * python/python-internal.h (gdbpy_convert_exception): Take a const
1024         reference.
1025         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
1026         std::move.
1027         * python/py-utils.c (gdbpy_convert_exception): Take a const
1028         reference.
1029         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1030         Use std::move.
1031         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1032         Use std::move.
1033         * mi/mi-main.c (mi_print_exception): Take a const reference.
1034         * main.c (handle_command_errors): Take a const reference.
1035         * linespec.c (parse_linespec): Use std::move.
1036         * infcall.c (run_inferior_call): Use std::move.
1037         (call_function_by_hand_dummy): Use std::move.
1038         * exec.c (try_open_exec_file): Use std::move.
1039         * exceptions.h (exception_print, exception_fprintf)
1040         (exception_print_same): Update.
1041         * exceptions.c (print_exception, exception_print)
1042         (exception_fprintf, exception_print_same): Change parameters to
1043         const reference.
1044         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
1045         * common/new-op.c: Use std::move.
1046         * common/common-exceptions.h (struct gdb_exception): Add move
1047         constructor.
1048         (struct gdb_exception_error, struct gdb_exception_quit, struct
1049         gdb_quit_bad_alloc): Change constructor to move constructor.
1050         (throw_exception): Change parameter to rvalue reference.
1051         * common/common-exceptions.c (throw_exception): Take rvalue
1052         reference.
1053         * cli/cli-interp.c (safe_execute_command): Use std::move.
1054         * breakpoint.c (insert_bp_location, location_to_sals): Use
1055         std::move.
1056
1057 2019-04-25  Tom Tromey  <tromey@adacore.com>
1058
1059         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
1060         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
1061         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
1062         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
1063         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
1064         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
1065         guile/scm-value.c: Use unpack.
1066         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
1067         gdbscm_gdb_exception.
1068         (gdbscm_throw_gdb_exception): Likewise.
1069         (struct gdbscm_gdb_exception): New.
1070         (unpack): New function.
1071         (gdbscm_wrap): Use unpack.
1072
1073 2019-04-25  Tom Tromey  <tromey@adacore.com>
1074
1075         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1076         (gdb_rl_callback_handler): Use std::move.
1077         * common/common-exceptions.h (struct gdb_exception): Add move
1078         assignment operator.
1079         (throw_exception_sjlj): Change "exception" to const reference.
1080         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
1081         (throw_exception_sjlj): Change "exception" to const reference.
1082
1083 2019-04-25  Tom Tromey  <tromey@adacore.com>
1084
1085         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
1086         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
1087         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1088         Update.
1089         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1090         Update.
1091         * mi/mi-interp.c (mi_interp::exec): Update.
1092         * linespec.c (parse_linespec): Update.
1093         * infcall.c (run_inferior_call): Update.
1094         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
1095         * guile/scm-symbol.c (gdbscm_lookup_symbol)
1096         (gdbscm_lookup_global_symbol): Update.
1097         * guile/scm-param.c (gdbscm_parameter_value): Update.
1098         * guile/scm-frame.c (gdbscm_frame_read_register)
1099         (gdbscm_frame_read_var): Update.
1100         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
1101         * exec.c (try_open_exec_file): Update.
1102         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1103         (gdb_rl_callback_handler): Update.
1104         * common/common-exceptions.h (exception_none): Don't declare.
1105         * common/common-exceptions.c (exception_none): Don't define.
1106         (struct catcher) <exception>: Update.
1107         * cli/cli-interp.c (safe_execute_command): Update.
1108         * breakpoint.c (insert_bp_location, location_to_sals): Update.
1109
1110 2019-04-25  Ali Tamur  <tamur@google.com>
1111
1112         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
1113         (read_attribute_value): Likewise.
1114         (dwarf2_read_addr_index): Update comment.
1115         (read_str_index): Add DW_FORM_strx.
1116         (dwarf2_string_attr): Likewise.
1117         (dwarf2_const_value_attr): Likewise.
1118         (dump_die_shallow): Likewise.
1119         (dwarf2_fetch_constant_bytes): Likewise.
1120         (skip_form_bytes): Likewise.
1121         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
1122
1123 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
1124
1125         PR corefiles/11608
1126         PR corefiles/18187
1127         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
1128         OFFSET.  Verify if current mapping contains an ELF header.
1129         (linux_find_memory_regions_full): Adjust call to
1130         dump_mapping_p.
1131
1132 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
1133             Kang Li <kanglictf@gmail.com>
1134
1135         PR gdb/21600
1136
1137         * dwarf2-frame.c (read_initial_length): Be consistent about using
1138         unsigned representation of length.
1139         (decode_frame_entry_1): Likewise.  Check for wraparound of
1140         end pointer as well as buffer overflow.
1141
1142 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
1143
1144         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
1145         "vq".
1146
1147 2019-04-24  Tom Tromey  <tromey@adacore.com>
1148
1149         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
1150
1151 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1152
1153         * s12z-tdep.c (s12z_unwind_pc): Delete.
1154         (s12z_unwind_sp): Delete.
1155         (s12z_gdbarch_init): Don't register deleted functions with
1156         gdbarch.
1157
1158 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1159
1160         * rl78-tdep.c (rl78_unwind_sp): Delete.
1161         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
1162
1163 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1164
1165         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
1166         (xstormy16_unwind_pc): Delete.
1167         (xstormy16_dummy_id): Delete.
1168         (xstormy16_gdbarch_init): Don't register deleted functions with
1169         gdbarch.
1170
1171 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1172
1173         * vax-tdep.c (vax_unwind_pc): Delete.
1174         (vax_gdbarch_init): Don't register deleted function with gdbarch.
1175
1176 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1177
1178         * v850-tdep.c (v850_unwind_sp): Delete.
1179         (v850_unwind_pc): Delete.
1180         (v850_dummy_id): Delete.
1181         (v850_gdbarch_init): Don't register deleted functions with
1182         gdbarch.
1183
1184 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1185
1186         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
1187         (tilegx_unwind_pc): Delete.
1188         (tilegx_unwind_dummy_id): Delete.
1189         (tilegx_gdbarch_init): Don't register deleted functions with
1190         gdbarch.
1191
1192 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1193
1194         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
1195         (tic6x_dummy_id): Delete.
1196         (tic6x_gdbarch_init): Don't register deleted functions with
1197         gdbarch.
1198
1199 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1200
1201         * sparc-tdep.c (sparc_unwind_pc): Delete.
1202         (sparc32_gdbarch_init): Don't register deleted function with
1203         gdbarch.
1204
1205 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1206
1207         * sh-tdep.c (sh_unwind_sp): Delete.
1208         (sh_unwind_pc): Delete.
1209         (sh_dummy_id): Delete.
1210         (sh_gdbarch_init): Don't register deleted functions with
1211         gdbarch.
1212
1213 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1214
1215         * score-tdep.c (score_unwind_sp): Delete.
1216         (score_unwind_pc): Delete.
1217         (score_dummy_id): Delete.
1218         (score_gdbarch_init): Don't register deleted functions with
1219         gdbarch.
1220
1221 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1222
1223         * rx-tdep.c (rx_unwind_pc): Delete.
1224         (rx_unwind_sp): Delete.
1225         (rx_dummy_id): Delete.
1226         (rx_gdbarch_init): Don't register deleted functions with
1227         gdbarch.  Update comment.
1228
1229 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1230
1231         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
1232         (rs6000_dummy_id): Delete.
1233         (rs6000_gdbarch_init): Don't register deleted functions with
1234         gdbarch.
1235
1236 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1237
1238         * or1k-tdep.c (or1k_dummy_id): Delete.
1239         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
1240
1241 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1242
1243         * nios2-tdep.c (nios2_dummy_id): Delete.
1244         (nios2_unwind_sp): Delete.
1245         (nios2_gdbarch_init): Don't register deleted functions with
1246         gdbarch.
1247
1248 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1249
1250         * nds32-tdep.c (nds32_dummy_id): Delete.
1251         (nds32_unwind_pc): Delete.
1252         (nds32_unwind_sp): Delete.
1253         (nds32_gdbarch_init): Don't register deleted functions with
1254         gdbarch.
1255
1256 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1257
1258         * msp430-tdep.c (msp430_unwind_pc): Delete.
1259         (msp430_unwind_sp): Delete.
1260         (msp430_dummy_id): Delete.
1261         (msp430_gdbarch_init): Don't register deleted functions with
1262         gdbarch.
1263
1264 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1265
1266         * moxie-tdep.c (moxie_unwind_sp): Delete.
1267         (moxie_unwind_pc): Delete.
1268         (moxie_dummy_id): Delete.
1269         (moxie_gdbarch_init): Don't register deleted functions with
1270         gdbarch.
1271
1272 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1273
1274         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1275         (mn10300_unwind_pc): Delete.
1276         (mn10300_unwind_sp): Delete.
1277         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1278         mn10300_unwind_sp.
1279         (mn10300_frame_unwind_init): Don't register deleted functions with
1280         gdbarch.
1281
1282 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1283
1284         * mep-tdep.c (mep_unwind_pc): Delete.
1285         (mep_unwind_sp): Delete.
1286         (mep_dummy_id): Delete.
1287         (mep_gdbarch_init): Don't register deleted functions with
1288         gdbarch.
1289
1290 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1291
1292         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1293         (m68hc11_unwind_sp): Delete.
1294         (m68hc11_gdbarch_init): Don't register deleted functions with
1295         gdbarch.
1296
1297 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1298
1299         * m32r-tdep.c (m32r_unwind_sp): Delete.
1300         (m32r_unwind_pc): Delete.
1301         (m32r_dummy_id): Delete.
1302         (m32r_gdbarch_init): Don't register deleted functions with
1303         gdbarch.
1304
1305 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1306
1307         * m32c-tdep.c (m32c_unwind_pc): Delete.
1308         (m32c_unwind_sp): Delete.
1309         (m32c_dummy_id): Delete.
1310         (m32c_gdbarch_init): Don't register deleted functions with
1311         gdbarch.
1312
1313 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1314
1315         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1316         (lm32_unwind_pc): Delete.
1317         (lm32_dummy_id): Delete.
1318         (lm32_gdbarch_init): Don't register deleted functions with
1319         gdbarch.
1320
1321 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1322
1323         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1324         (iq2000_unwind_pc): Delete.
1325         (iq2000_dummy_id): Delete.
1326         (iq2000_gdbarch_init): Don't register deleted functions with
1327         gdbarch.
1328
1329 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1330
1331         * nds32-tdep.c (nds32_type_align): Delete.
1332         (nds32_push_dummy_call): Use type_align instead.
1333
1334 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1335
1336         * arm-tdep.c (arm_type_align): Only handle vector override case.
1337         (arm_push_dummy_call): Use type_align.
1338         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1339
1340 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1341
1342         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1343         case.
1344         (pass_on_stack): Use type_align.
1345         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1346         function.
1347
1348 2019-04-23  Tom Tromey  <tromey@adacore.com>
1349
1350         * dwarf2read.c (line_header::file_name_at): Remove unused
1351         overload.
1352
1353 2019-04-23  Tom de Vries  <tdevries@suse.de>
1354
1355         PR gdb/24438
1356         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1357         invocation.
1358
1359
1360 2019-03-27  Ali Tamur  <tamur@google.com>
1361
1362         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1363         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1364         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1365         (dwarf_expr_context::get_addr_index): Likewise
1366         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1367         (symbol_needs_eval_context::get_addr_index): Likewise
1368         (disassemble_dwarf_expression): Add DW_OP_addrx
1369         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1370         (read_cutu_die_from_dwo): Update comment
1371         (skip_one_die): Add DW_FORM_addrx
1372         (read_attribute_value): Likewise
1373         (var_decode_location): Add DW_OP_addrx
1374         (dwarf2_const_value_attr): Add DW_FORM_addrx
1375         (dump_die_shallow): Likewise
1376         (dwarf2_fetch_constant_bytes): Likewise
1377         (decode_locdesc): Add DW_OP_addrx
1378         (skip_form_bytes): Add DW_FORM_addrx
1379
1380 2019-04-22  Ali Tamur  <tamur@google.com>
1381
1382         * MAINTAINERS (Write After Approval): Add self.
1383
1384 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1385
1386         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1387         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1388         (open_symbol_file_object): Likewise.
1389         (svr4_default_sos): Add info parameter.
1390         (svr4_read_so_list): Likewise.
1391         (svr4_current_sos_direct): Adjust functions calls to pass down
1392         info.
1393         (svr4_current_sos_1): Add info parameter.
1394         (svr4_current_sos): Call get_svr4_info, pass info down to
1395         svr4_current_sos_1.
1396         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1397         get_svr4_info.
1398         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1399         get_svr4_info.
1400         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1401         to get_svr4_info.
1402         (probes_table_remove_objfile_probes): Likewise.
1403         (register_solib_event_probe): Add info parameter.
1404         (solist_update_incremental): Pass info parameter down to
1405         svr4_read_so_list.
1406         (disable_probes_interface): Add info parameter.
1407         (svr4_handle_solib_event): Pass current_program_space to
1408         get_svr4_info.  Adjust disable_probes_interface cleanup.
1409         (svr4_create_probe_breakpoints): Add info parameter, pass it
1410         down to register_solib_event_probe.
1411         (svr4_create_solib_event_breakpoints): Add info parameter,
1412         pass it down to svr4_create_probe_breakpoints.
1413         (enable_break): Pass info down to
1414         svr4_create_solib_event_breakpoints.
1415         (svr4_solib_create_inferior_hook): Pass current_program_space to
1416         get_svr4_info.
1417         (svr4_clear_solib): Likewise.
1418
1419 2019-04-22  Pedro Alves  <palves@redhat.com>
1420
1421         * solib-svr4.c (svr4_free_objfile_observer): New.
1422         (probe_and_action::objfile): New field.
1423         (probes_table_htab_remove_objfile_probes)
1424         (probes_table_remove_objfile_probes): New functions.
1425         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1426         in the new probe_and_action.  Don't store the probe in 'lookup'.
1427         (svr4_create_probe_breakpoints): Pass objfile to
1428         register_solib_event_probe.
1429         (_initialize_svr4_solib): Register a free_objfile observer.
1430
1431 2019-04-19  Tom Tromey  <tom@tromey.com>
1432
1433         * common/queue.h: Remove.
1434
1435 2019-04-19  Tom Tromey  <tom@tromey.com>
1436
1437         * event-loop.c: Don't include "common/queue.h".
1438
1439 2019-04-19  Tom Tromey  <tom@tromey.com>
1440
1441         * remote.c (remote_target): Use delete.
1442         * remote-notif.h: Include <list>, not "common/queue.h".
1443         (notif_client_p): Remove typedef.
1444         (remote_notif_state): Add constructor, destructor, initializer.
1445         <notif_queue>: Now a std::list.
1446         (remote_notif_state_xfree): Don't declare.
1447         * remote-notif.c (remote_notif_process, handle_notification)
1448         (remote_notif_state_allocate): Update.
1449         (~remote_notif_state): Rename from remote_notif_state_xfree.
1450
1451 2019-04-19  Tom Tromey  <tom@tromey.com>
1452
1453         * symfile.c (reread_symbols): Update.
1454         * objfiles.c (objfile_register_static_link)
1455         (objfile_lookup_static_link): Update
1456         (~objfile) Don't delete static_links.
1457         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1458
1459 2019-04-19  Tom Tromey  <tom@tromey.com>
1460
1461         * type-stack.h (struct type_stack) <insert>: Constify string.
1462         * type-stack.c (type_stack::insert): Constify string.
1463         * gdbtypes.h (lookup_template_type): Update.
1464         (address_space_name_to_int): Update.
1465         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1466         const.
1467         (lookup_template_type): Make name const.
1468         * c-exp.y: Update rules.
1469         (lex_one_token, classify_name, classify_inner_name)
1470         (c_print_token): Update.
1471         * p-exp.y: Update rules.
1472         (yylex): Update.
1473         * f-exp.y: Update rules.
1474         (yylex): Update.
1475         * d-exp.y: Update rules.
1476         (lex_one_token, classify_name, classify_inner_name): Update.
1477         * parse.c (write_dollar_variable, copy_name): Return std::string.
1478         * parser-defs.h (copy_name): Change return type.
1479         * m2-exp.y: Update rules.
1480         (yylex): Update.
1481         * go-exp.y (lex_one_token): Update.
1482         Update rules.
1483         (classify_unsafe_function, classify_packaged_name)
1484         (classify_name, yylex): Update.
1485
1486 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1487
1488         * configure.ac: add --enable-source-highlight switch.
1489         * configure: Regenerate.
1490         * top.c (print_gdb_version): plumb --enable-source-highlight
1491         status to "show configuration".
1492
1493 2019-04-19  Tom Tromey  <tromey@adacore.com>
1494
1495         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1496         Check ADA_TYPE_P.
1497         (empty_record, ada_template_to_fixed_record_type_1)
1498         (template_to_static_fixed_type)
1499         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1500         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1501         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1502         macros.
1503
1504 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1505
1506         PR symtab/24423:
1507         * source.c (print_source_lines_base): Advance "iter" when a
1508         control character is seen.
1509
1510 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1511
1512         * inferior.h (struct infcall_suspend_state_deleter):
1513         Catch exception in destructor to avoid crash.
1514
1515 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1516
1517         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1518         close to the add_com "shell".
1519
1520 2019-04-18  Tom Tromey  <tromey@adacore.com>
1521
1522         * process-stratum-target.h (class process_stratum_target)
1523         <stratum>: Add "final".
1524
1525 2019-04-17  Tom Tromey  <tromey@adacore.com>
1526
1527         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1528         against nullptr before use.
1529
1530 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1531
1532         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1533
1534 2019-04-17  Jim Wilson  <jimw@sifive.com>
1535             Andrew Burgess  <andrew.burgess@embecosm.com>
1536
1537         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1538         code read might fail, assume 4-byte breakpoint in that case.
1539
1540 2019-04-15  Leszek Swirski  <leszeks@google.com>
1541
1542         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1543         rather than a hand-rolled POD check when checking for forced MEMORY
1544         classification.
1545
1546 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1547
1548         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1549         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1550         function.
1551         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1552         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1553         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1554         declaration.
1555
1556 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1557
1558         * aarch64-linux-nat.c
1559         (aarch64_linux_nat_target::thread_architecture): Add override.
1560         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1561         each VQ.
1562
1563 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1564
1565         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1566
1567 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1568
1569         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1570         target types of size 96-bits, add some additional comments, and
1571         check that the builtin type we found was the correct size.
1572
1573 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1574
1575         * utils.c (prompt_for_continue): Don't restore the styling at the
1576         end, as applied_style has the wrong value.  This fixes styling in
1577         long lists of file names that are interrupted by the "Continue?"
1578         prompt.
1579
1580 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1581
1582         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1583         * c-lang.c (c_language_defn): Likewise.
1584         (cplus_language_defn): Likewise.
1585         (asm_language_defn): Likewise.
1586         (minimal_language_defn): Likewise.
1587         * d-lang.c (d_language_defn): Likewise.
1588         * f-lang.c (f_language_defn): Likewise.
1589         * go-lang.c (go_language_defn): Likewise.
1590         * language.c (unknown_language_defn): Likewise.
1591         (auto_language_defn): Likewise.
1592         * language.h (struct language_defn): Remove la_magic field.
1593         (LANG_MAGIC): Delete.
1594         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1595         * objc-lang.c (objc_language_defn): Likewise.
1596         * opencl-lang.c (opencl_language_defn): Likewise.
1597         * p-lang.c (pascal_language_defn): Likewise.
1598         * rust-lang.c (rust_language_defn): Likewise.
1599
1600 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1601
1602         * riscv-tdep.c (riscv_type_align): New function.
1603         (riscv_type_alignment): Delete.
1604         (riscv_arg_location): Use 'type_align'.
1605         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1606
1607 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1608
1609         * gdbtypes.c (type_align): A struct with no non-static fields also
1610         has alignment of 1.
1611
1612 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1613
1614         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1615         component to 0.
1616         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1617         member.
1618         (riscv_struct_info::analyse): New implementation using new
1619         analyse_inner member function.
1620         (riscv_struct_info::field_offset): New member function.
1621         (riscv_struct_info::m_offsets): New member variable.
1622         (riscv_struct_info::analyse_inner): New private member function,
1623         takes the old implementation of riscv_struct_info::analyse but
1624         extended to track field offsets.
1625         (riscv_call_arg_struct): Update the struct folding special cases
1626         to handle cases where empty C++ structs, which are non-zero
1627         length, are found.
1628         (riscv_arg_location): Initialise the length of each location, a
1629         non-zero length now indicates the location is in use.
1630         (riscv_push_dummy_call): Allow for the first location having a
1631         non-zero offset when setting up arguments.
1632         (riscv_return_value): Likewise, but for return values.
1633
1634 2019-04-11  Tom Tromey  <tromey@adacore.com>
1635
1636         * utils.c (internal_vproblem): Make "msg" const.
1637
1638 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1639
1640         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1641         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1642         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1643         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1644
1645 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1646
1647         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1648         function.
1649         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1650         of amd64_collect_native_gregset.
1651         (amd64_linux_nat_target::store_registers): Likewise.
1652
1653 2019-04-10  Tom Tromey  <tom@tromey.com>
1654
1655         * symtab.c (lookup_global_symbol_from_objfile)
1656         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1657         * objfiles.h (class separate_debug_iterator): New.
1658         (class separate_debug_range): New.
1659         (struct objfile) <separate_debug_objfiles>: New method.
1660         (objfile_separate_debug_iterate): Don't declare.
1661         * objfiles.c (separate_debug_iterator::operator++): Rename from
1662         objfile_separate_debug_iterate.
1663         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1664         iterator.
1665         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1666         iterator.
1667
1668 2019-04-10  Tom Tromey  <tom@tromey.com>
1669
1670         * symfile.c (reread_symbols): Remove old comment.
1671         * objfiles.c (free_all_objfiles): Fix a typo.
1672
1673 2019-04-10  Tom Tromey  <tom@tromey.com>
1674
1675         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1676         * minsyms.c (lookup_minimal_symbol): Use foreach.
1677         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1678         (lookup_minimal_symbol_solib_trampoline): Likewise.
1679         * symfile.c (reread_symbols): Use foreach.
1680
1681 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1682             Tom Tromey  <tromey@adacore.com>
1683
1684         PR rust/24414:
1685         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1686         (rust_lex_int_test): Change "value" to be LONGEST.
1687         (rust_lex_tests): Add test for long integer literal.
1688
1689 2019-04-09  Tom Tromey  <tromey@adacore.com>
1690
1691         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1692         to bool.
1693         (extended_remote_target::attach): Update.
1694         (remote_target::remote_notice_new_inferior): Update.
1695         (remote_target::add_current_inferior_and_thread): Update.
1696         * inferior.c (exit_inferior_1): Use "false".
1697         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1698
1699 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1700
1701         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1702         the "start" command.
1703
1704 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1705
1706         * python/py-inferior.c (infpy_thread_from_thread_handle):
1707         Adjust comments to reflect renaming of thread_from_thread_handle
1708         to thread_from_handle.  Adjust keywords.  Fix type error message.
1709         (inferior_object_methods): Add thread_from_handle.  Retain
1710         thread_from_thread_handle, but mark it as deprecated.
1711
1712 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1713
1714         * gdbthread.h (find_thread_by_handle): Revise declaration.
1715         * thread.c (find_thread_by_handle): Likewise.  Adjust
1716         implementation too.
1717         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1718         support for buffer objects as handles.
1719
1720 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1721
1722         * python/py-infthread.c (thpy_thread_handle): New function.
1723         (thread_object_methods): Register thpy_thread_handle.
1724
1725 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1726
1727         * gdbthread.h (thread_to_thread_handle): Declare.
1728         * thread.c (gdbtypes.h): Include.
1729         (thread_to_thread_handle): New function.
1730
1731         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1732         (target_thread_info_to_thread_handle): Declare.
1733         * target.c (target_thread_info_to_thread_handle): New function.
1734         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1735         * target-delegates.c: Regenerate.
1736
1737         * linux-thread-db.c (class thread_db_target): Add method
1738         thread_info_to_thread_handle.
1739         (thread_db_target::thread_info_to_thread_handle): Define.
1740         * remote.c (class remote_target): Add new method
1741         thread_info_to_thread_handle.
1742         (remote_target::thread_info_to_thread_handle): Define.
1743
1744 2019-04-08  Pedro Alves  <palves@redhat.com>
1745
1746         * common/common-exceptions.c (throw_exception): Don't create
1747         named object to throw; throw directly.
1748         (throw_it): Likewise.  Don't initialize gdb_exception::message
1749         here, with new; pass FMT and AP to the ctor instead.
1750         * common/common-exceptions.h: Include <string>.
1751         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1752         const char *, va_list)): New ctor.  Use std::make_shared.
1753         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1754         errors)): Delete.
1755         (gdb_exception_error::gdb_exception_error(enum errors, const char
1756         *, va_list)): New.
1757         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1758         Add assertion.
1759         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1760         errors)): Delete.
1761         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1762         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1763         Add assertion.
1764
1765 2019-04-08  Tom Tromey  <tom@tromey.com>
1766
1767         * valops.c (value_rtti_indirect_type): Replace throw_exception
1768         with throw.
1769         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1770         with throw.
1771         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1772         throw.
1773         * target.c (target_translate_tls_address): Replace throw_exception
1774         with throw.
1775         * stack.c (frame_apply_command_count): Replace throw_exception
1776         with throw.
1777         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1778         throw.
1779         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1780         with throw.
1781         * rs6000-tdep.c (rs6000_frame_cache)
1782         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1783         * remote.c: Replace throw_exception with throw.
1784         * record-full.c (record_full_message, record_full_wait_1)
1785         (record_full_restore): Replace throw_exception with throw.
1786         * record-btrace.c:
1787         (get_thread_current_frame_id, record_btrace_start_replaying)
1788         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1789         (cmd_record_btrace_start): Replace throw_exception with throw.
1790         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1791         throw.
1792         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1793         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1794         * linespec.c:
1795         (find_linespec_symbols): Replace throw_exception with throw.
1796         * infrun.c (displaced_step_prepare, resume): Replace
1797         throw_exception with throw.
1798         * infcmd.c (post_create_inferior): Replace throw_exception with
1799         throw.
1800         * inf-loop.c (inferior_event_handler): Replace throw_exception
1801         with throw.
1802         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1803         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1804         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1805         (get_prev_frame_always, get_frame_pc_if_available)
1806         (get_frame_address_in_block_if_available, get_frame_language):
1807         Replace throw_exception with throw.
1808         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1809         throw_exception with throw.
1810         * eval.c (fetch_subexp_value, evaluate_var_value)
1811         (evaluate_funcall, evaluate_subexp_standard): Replace
1812         throw_exception with throw.
1813         * dwarf2loc.c (call_site_find_chain)
1814         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1815         Replace throw_exception with throw.
1816         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1817         with throw.
1818         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1819         throw.
1820         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1821         * completer.c (complete_line_internal): Replace throw_exception
1822         with throw.
1823         * compile/compile-object-run.c (compile_object_run): Replace
1824         throw_exception with throw.
1825         * cli/cli-script.c (process_next_line): Replace throw_exception
1826         with throw.
1827         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1828         (btrace_enable, btrace_maint_update_pt_packets): Replace
1829         throw_exception with throw.
1830         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1831         throw_exception with throw.
1832         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1833         throw_exception with throw.
1834         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1835         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1836         * aarch64-tdep.c (aarch64_make_prologue_cache)
1837         (aarch64_make_stub_cache): Replace throw_exception with throw.
1838
1839 2019-04-08  Tom Tromey  <tom@tromey.com>
1840
1841         * common/common-exceptions.c (throw_exception): Rename from
1842         throw_exception_cxx.  Remove old copy.  Make argument const.
1843         (throw_it): Create and throw exception objects directly.
1844         * common/common-exceptions.h (throw_exception): Make argument
1845         const.
1846         (struct gdb_exception_error): Add constructor.
1847         (struct gdb_exception_quit): Add constructor.
1848
1849 2019-04-08  Tom Tromey  <tom@tromey.com>
1850
1851         * common/common-exceptions.h (exception_rethrow): Don't declare.
1852         (TRY_SJLJ): Update comment.
1853         (TRY, CATCH, END_CATCH): Remove.
1854         * common/common-exceptions.c (exception_rethrow): Remove.
1855
1856 2019-04-08  Tom Tromey  <tom@tromey.com>
1857
1858         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1859         Remove.
1860         (gdb_exception_error): Rename from
1861         gdb_exception_RETURN_MASK_ERROR.
1862         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1863         (gdb_quit_bad_alloc): Update.
1864         * aarch64-tdep.c: Update.
1865         * ada-lang.c: Update.
1866         * ada-typeprint.c: Update.
1867         * ada-valprint.c: Update.
1868         * amd64-tdep.c: Update.
1869         * arch-utils.c: Update.
1870         * break-catch-throw.c: Update.
1871         * breakpoint.c: Update.
1872         * btrace.c: Update.
1873         * c-varobj.c: Update.
1874         * cli/cli-cmds.c: Update.
1875         * cli/cli-interp.c: Update.
1876         * cli/cli-script.c: Update.
1877         * common/common-exceptions.c: Update.
1878         * common/new-op.c: Update.
1879         * common/selftest.c: Update.
1880         * compile/compile-c-symbols.c: Update.
1881         * compile/compile-cplus-symbols.c: Update.
1882         * compile/compile-object-load.c: Update.
1883         * compile/compile-object-run.c: Update.
1884         * completer.c: Update.
1885         * corelow.c: Update.
1886         * cp-abi.c: Update.
1887         * cp-support.c: Update.
1888         * cp-valprint.c: Update.
1889         * darwin-nat.c: Update.
1890         * disasm-selftests.c: Update.
1891         * dtrace-probe.c: Update.
1892         * dwarf-index-cache.c: Update.
1893         * dwarf-index-write.c: Update.
1894         * dwarf2-frame-tailcall.c: Update.
1895         * dwarf2-frame.c: Update.
1896         * dwarf2loc.c: Update.
1897         * dwarf2read.c: Update.
1898         * eval.c: Update.
1899         * event-loop.c: Update.
1900         * event-top.c: Update.
1901         * exec.c: Update.
1902         * f-valprint.c: Update.
1903         * fbsd-tdep.c: Update.
1904         * frame-unwind.c: Update.
1905         * frame.c: Update.
1906         * gdbtypes.c: Update.
1907         * gnu-v3-abi.c: Update.
1908         * guile/guile-internal.h: Update.
1909         * guile/scm-block.c: Update.
1910         * guile/scm-breakpoint.c: Update.
1911         * guile/scm-cmd.c: Update.
1912         * guile/scm-disasm.c: Update.
1913         * guile/scm-frame.c: Update.
1914         * guile/scm-lazy-string.c: Update.
1915         * guile/scm-math.c: Update.
1916         * guile/scm-param.c: Update.
1917         * guile/scm-ports.c: Update.
1918         * guile/scm-pretty-print.c: Update.
1919         * guile/scm-symbol.c: Update.
1920         * guile/scm-symtab.c: Update.
1921         * guile/scm-type.c: Update.
1922         * guile/scm-value.c: Update.
1923         * i386-linux-tdep.c: Update.
1924         * i386-tdep.c: Update.
1925         * inf-loop.c: Update.
1926         * infcall.c: Update.
1927         * infcmd.c: Update.
1928         * infrun.c: Update.
1929         * jit.c: Update.
1930         * language.c: Update.
1931         * linespec.c: Update.
1932         * linux-fork.c: Update.
1933         * linux-nat.c: Update.
1934         * linux-tdep.c: Update.
1935         * linux-thread-db.c: Update.
1936         * main.c: Update.
1937         * mi/mi-cmd-break.c: Update.
1938         * mi/mi-cmd-stack.c: Update.
1939         * mi/mi-interp.c: Update.
1940         * mi/mi-main.c: Update.
1941         * objc-lang.c: Update.
1942         * p-valprint.c: Update.
1943         * parse.c: Update.
1944         * ppc-linux-tdep.c: Update.
1945         * printcmd.c: Update.
1946         * python/py-arch.c: Update.
1947         * python/py-breakpoint.c: Update.
1948         * python/py-cmd.c: Update.
1949         * python/py-finishbreakpoint.c: Update.
1950         * python/py-frame.c: Update.
1951         * python/py-framefilter.c: Update.
1952         * python/py-gdb-readline.c: Update.
1953         * python/py-inferior.c: Update.
1954         * python/py-infthread.c: Update.
1955         * python/py-lazy-string.c: Update.
1956         * python/py-linetable.c: Update.
1957         * python/py-objfile.c: Update.
1958         * python/py-param.c: Update.
1959         * python/py-prettyprint.c: Update.
1960         * python/py-progspace.c: Update.
1961         * python/py-record-btrace.c: Update.
1962         * python/py-record.c: Update.
1963         * python/py-symbol.c: Update.
1964         * python/py-type.c: Update.
1965         * python/py-unwind.c: Update.
1966         * python/py-utils.c: Update.
1967         * python/py-value.c: Update.
1968         * python/python.c: Update.
1969         * record-btrace.c: Update.
1970         * record-full.c: Update.
1971         * remote-fileio.c: Update.
1972         * remote.c: Update.
1973         * riscv-tdep.c: Update.
1974         * rs6000-aix-tdep.c: Update.
1975         * rs6000-tdep.c: Update.
1976         * rust-exp.y: Update.
1977         * rust-lang.c: Update.
1978         * s390-tdep.c: Update.
1979         * selftest-arch.c: Update.
1980         * solib-dsbt.c: Update.
1981         * solib-frv.c: Update.
1982         * solib-spu.c: Update.
1983         * solib-svr4.c: Update.
1984         * solib.c: Update.
1985         * sparc64-linux-tdep.c: Update.
1986         * stack.c: Update.
1987         * symfile-mem.c: Update.
1988         * symmisc.c: Update.
1989         * target.c: Update.
1990         * thread.c: Update.
1991         * top.c: Update.
1992         * tracefile-tfile.c: Update.
1993         * tui/tui.c: Update.
1994         * typeprint.c: Update.
1995         * unittests/cli-utils-selftests.c: Update.
1996         * unittests/parse-connection-spec-selftests.c: Update.
1997         * valops.c: Update.
1998         * valprint.c: Update.
1999         * value.c: Update.
2000         * varobj.c: Update.
2001         * windows-nat.c: Update.
2002         * x86-linux-nat.c: Update.
2003         * xml-support.c: Update.
2004
2005 2019-04-08  Tom Tromey  <tom@tromey.com>
2006
2007         * xml-support.c: Use C++ exception handling.
2008         * x86-linux-nat.c: Use C++ exception handling.
2009         * windows-nat.c: Use C++ exception handling.
2010         * varobj.c: Use C++ exception handling.
2011         * value.c: Use C++ exception handling.
2012         * valprint.c: Use C++ exception handling.
2013         * valops.c: Use C++ exception handling.
2014         * unittests/parse-connection-spec-selftests.c: Use C++ exception
2015         handling.
2016         * unittests/cli-utils-selftests.c: Use C++ exception handling.
2017         * typeprint.c: Use C++ exception handling.
2018         * tui/tui.c: Use C++ exception handling.
2019         * tracefile-tfile.c: Use C++ exception handling.
2020         * top.c: Use C++ exception handling.
2021         * thread.c: Use C++ exception handling.
2022         * target.c: Use C++ exception handling.
2023         * symmisc.c: Use C++ exception handling.
2024         * symfile-mem.c: Use C++ exception handling.
2025         * stack.c: Use C++ exception handling.
2026         * sparc64-linux-tdep.c: Use C++ exception handling.
2027         * solib.c: Use C++ exception handling.
2028         * solib-svr4.c: Use C++ exception handling.
2029         * solib-spu.c: Use C++ exception handling.
2030         * solib-frv.c: Use C++ exception handling.
2031         * solib-dsbt.c: Use C++ exception handling.
2032         * selftest-arch.c: Use C++ exception handling.
2033         * s390-tdep.c: Use C++ exception handling.
2034         * rust-lang.c: Use C++ exception handling.
2035         * rust-exp.y: Use C++ exception handling.
2036         * rs6000-tdep.c: Use C++ exception handling.
2037         * rs6000-aix-tdep.c: Use C++ exception handling.
2038         * riscv-tdep.c: Use C++ exception handling.
2039         * remote.c: Use C++ exception handling.
2040         * remote-fileio.c: Use C++ exception handling.
2041         * record-full.c: Use C++ exception handling.
2042         * record-btrace.c: Use C++ exception handling.
2043         * python/python.c: Use C++ exception handling.
2044         * python/py-value.c: Use C++ exception handling.
2045         * python/py-utils.c: Use C++ exception handling.
2046         * python/py-unwind.c: Use C++ exception handling.
2047         * python/py-type.c: Use C++ exception handling.
2048         * python/py-symbol.c: Use C++ exception handling.
2049         * python/py-record.c: Use C++ exception handling.
2050         * python/py-record-btrace.c: Use C++ exception handling.
2051         * python/py-progspace.c: Use C++ exception handling.
2052         * python/py-prettyprint.c: Use C++ exception handling.
2053         * python/py-param.c: Use C++ exception handling.
2054         * python/py-objfile.c: Use C++ exception handling.
2055         * python/py-linetable.c: Use C++ exception handling.
2056         * python/py-lazy-string.c: Use C++ exception handling.
2057         * python/py-infthread.c: Use C++ exception handling.
2058         * python/py-inferior.c: Use C++ exception handling.
2059         * python/py-gdb-readline.c: Use C++ exception handling.
2060         * python/py-framefilter.c: Use C++ exception handling.
2061         * python/py-frame.c: Use C++ exception handling.
2062         * python/py-finishbreakpoint.c: Use C++ exception handling.
2063         * python/py-cmd.c: Use C++ exception handling.
2064         * python/py-breakpoint.c: Use C++ exception handling.
2065         * python/py-arch.c: Use C++ exception handling.
2066         * printcmd.c: Use C++ exception handling.
2067         * ppc-linux-tdep.c: Use C++ exception handling.
2068         * parse.c: Use C++ exception handling.
2069         * p-valprint.c: Use C++ exception handling.
2070         * objc-lang.c: Use C++ exception handling.
2071         * mi/mi-main.c: Use C++ exception handling.
2072         * mi/mi-interp.c: Use C++ exception handling.
2073         * mi/mi-cmd-stack.c: Use C++ exception handling.
2074         * mi/mi-cmd-break.c: Use C++ exception handling.
2075         * main.c: Use C++ exception handling.
2076         * linux-thread-db.c: Use C++ exception handling.
2077         * linux-tdep.c: Use C++ exception handling.
2078         * linux-nat.c: Use C++ exception handling.
2079         * linux-fork.c: Use C++ exception handling.
2080         * linespec.c: Use C++ exception handling.
2081         * language.c: Use C++ exception handling.
2082         * jit.c: Use C++ exception handling.
2083         * infrun.c: Use C++ exception handling.
2084         * infcmd.c: Use C++ exception handling.
2085         * infcall.c: Use C++ exception handling.
2086         * inf-loop.c: Use C++ exception handling.
2087         * i386-tdep.c: Use C++ exception handling.
2088         * i386-linux-tdep.c: Use C++ exception handling.
2089         * guile/scm-value.c: Use C++ exception handling.
2090         * guile/scm-type.c: Use C++ exception handling.
2091         * guile/scm-symtab.c: Use C++ exception handling.
2092         * guile/scm-symbol.c: Use C++ exception handling.
2093         * guile/scm-pretty-print.c: Use C++ exception handling.
2094         * guile/scm-ports.c: Use C++ exception handling.
2095         * guile/scm-param.c: Use C++ exception handling.
2096         * guile/scm-math.c: Use C++ exception handling.
2097         * guile/scm-lazy-string.c: Use C++ exception handling.
2098         * guile/scm-frame.c: Use C++ exception handling.
2099         * guile/scm-disasm.c: Use C++ exception handling.
2100         * guile/scm-cmd.c: Use C++ exception handling.
2101         * guile/scm-breakpoint.c: Use C++ exception handling.
2102         * guile/scm-block.c: Use C++ exception handling.
2103         * guile/guile-internal.h: Use C++ exception handling.
2104         * gnu-v3-abi.c: Use C++ exception handling.
2105         * gdbtypes.c: Use C++ exception handling.
2106         * frame.c: Use C++ exception handling.
2107         * frame-unwind.c: Use C++ exception handling.
2108         * fbsd-tdep.c: Use C++ exception handling.
2109         * f-valprint.c: Use C++ exception handling.
2110         * exec.c: Use C++ exception handling.
2111         * event-top.c: Use C++ exception handling.
2112         * event-loop.c: Use C++ exception handling.
2113         * eval.c: Use C++ exception handling.
2114         * dwarf2read.c: Use C++ exception handling.
2115         * dwarf2loc.c: Use C++ exception handling.
2116         * dwarf2-frame.c: Use C++ exception handling.
2117         * dwarf2-frame-tailcall.c: Use C++ exception handling.
2118         * dwarf-index-write.c: Use C++ exception handling.
2119         * dwarf-index-cache.c: Use C++ exception handling.
2120         * dtrace-probe.c: Use C++ exception handling.
2121         * disasm-selftests.c: Use C++ exception handling.
2122         * darwin-nat.c: Use C++ exception handling.
2123         * cp-valprint.c: Use C++ exception handling.
2124         * cp-support.c: Use C++ exception handling.
2125         * cp-abi.c: Use C++ exception handling.
2126         * corelow.c: Use C++ exception handling.
2127         * completer.c: Use C++ exception handling.
2128         * compile/compile-object-run.c: Use C++ exception handling.
2129         * compile/compile-object-load.c: Use C++ exception handling.
2130         * compile/compile-cplus-symbols.c: Use C++ exception handling.
2131         * compile/compile-c-symbols.c: Use C++ exception handling.
2132         * common/selftest.c: Use C++ exception handling.
2133         * common/new-op.c: Use C++ exception handling.
2134         * cli/cli-script.c: Use C++ exception handling.
2135         * cli/cli-interp.c: Use C++ exception handling.
2136         * cli/cli-cmds.c: Use C++ exception handling.
2137         * c-varobj.c: Use C++ exception handling.
2138         * btrace.c: Use C++ exception handling.
2139         * breakpoint.c: Use C++ exception handling.
2140         * break-catch-throw.c: Use C++ exception handling.
2141         * arch-utils.c: Use C++ exception handling.
2142         * amd64-tdep.c: Use C++ exception handling.
2143         * ada-valprint.c: Use C++ exception handling.
2144         * ada-typeprint.c: Use C++ exception handling.
2145         * ada-lang.c: Use C++ exception handling.
2146         * aarch64-tdep.c: Use C++ exception handling.
2147
2148 2019-04-08  Tom Tromey  <tom@tromey.com>
2149
2150         * xml-support.c (gdb_xml_parser::parse): Update.
2151         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2152         * value.c (show_convenience): Update.
2153         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
2154         (test_parse_flags_qcs): Update.
2155         * thread.c (thr_try_catch_cmd): Update.
2156         * target.c (target_translate_tls_address): Update.
2157         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2158         (info_frame_command_core, frame_apply_command_count): Update.
2159         * rust-exp.y (rust_lex_exception_test): Update.
2160         * riscv-tdep.c (riscv_print_one_register_info): Update.
2161         * remote.c (remote_target::enable_btrace): Update.
2162         * record-btrace.c (record_btrace_enable_warn): Update.
2163         * python/py-utils.c (gdbpy_convert_exception): Update.
2164         * printcmd.c (do_one_display, print_variable_and_value): Update.
2165         * mi/mi-main.c (mi_print_exception): Update.
2166         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
2167         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2168         * linux-nat.c (linux_nat_target::attach): Update.
2169         * linux-fork.c (class scoped_switch_fork_info): Update.
2170         * infrun.c (displaced_step_prepare): Update.
2171         * infcall.c (call_function_by_hand_dummy): Update.
2172         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
2173         * gnu-v3-abi.c (print_one_vtable): Update.
2174         * frame.c (get_prev_frame_always): Update.
2175         * f-valprint.c (info_common_command_for_block): Update.
2176         * exec.c (try_open_exec_file): Update.
2177         * exceptions.c (print_exception, exception_print)
2178         (exception_fprintf, exception_print_same): Update.
2179         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
2180         * dwarf-index-cache.c (index_cache::store)
2181         (index_cache::lookup_gdb_index): Update.
2182         * darwin-nat.c (maybe_cache_shell): Update.
2183         * cp-valprint.c (cp_print_value_fields): Update.
2184         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
2185         (gcc_cplus_symbol_address): Update.
2186         * compile/compile-c-symbols.c (gcc_convert_symbol)
2187         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
2188         * common/selftest.c: Update.
2189         * common/common-exceptions.h (struct gdb_exception) <message>: Now
2190         a std::string.
2191         (exception_try_scope_entry, exception_try_scope_exit): Don't
2192         declare.
2193         (struct exception_try_scope): Remove.
2194         (TRY): Don't use exception_try_scope.
2195         (struct gdb_exception): Add constructor, operator=.
2196         <what>: New method.
2197         (struct gdb_exception_RETURN_MASK_ALL)
2198         (struct gdb_exception_RETURN_MASK_ERROR)
2199         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
2200         (struct gdb_quit_bad_alloc): Update.
2201         * common/common-exceptions.c (exception_none): Change
2202         initializer.
2203         (struct catcher) <state, exception>: Initialize inline.
2204         <prev>: Remove member.
2205         (current_catcher): Remove.
2206         (catchers): New global.
2207         (exceptions_state_mc_init): Simplify.
2208         (catcher_pop): Remove.
2209         (exceptions_state_mc, exceptions_state_mc_catch): Update.
2210         (try_scope_depth, exception_try_scope_entry)
2211         (exception_try_scope_exit): Remove.
2212         (throw_exception_sjlj): Update.
2213         (exception_messages, exception_messages_size): Remove.
2214         (throw_it): Simplify.
2215         (gdb_exception_sliced_copy): Remove.
2216         (throw_exception_cxx): Update.
2217         * cli/cli-script.c (script_from_file): Update.
2218         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
2219         Update.
2220         * ada-valprint.c (ada_val_print): Update.
2221         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
2222         (create_excep_cond_exprs): Update.
2223
2224 2019-04-08  Tom Tromey  <tom@tromey.com>
2225
2226         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
2227         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
2228         (TRY, CATCH, END_CATCH): Remove some definitions.
2229         * common/common-exceptions.c: Don't use GDB_XCPT.
2230         (catcher_list_size): Remove.
2231         (throw_exception, throw_it): Simplify.
2232
2233 2019-04-05  Tom Tromey  <tom@tromey.com>
2234
2235         Revert the header-sorting patch.
2236         * ft32-tdep.c: Revert.
2237         * frv-tdep.c: Revert.
2238         * frv-linux-tdep.c: Revert.
2239         * frame.c: Revert.
2240         * frame-unwind.c: Revert.
2241         * frame-base.c: Revert.
2242         * fork-child.c: Revert.
2243         * findvar.c: Revert.
2244         * findcmd.c: Revert.
2245         * filesystem.c: Revert.
2246         * filename-seen-cache.h: Revert.
2247         * filename-seen-cache.c: Revert.
2248         * fbsd-tdep.c: Revert.
2249         * fbsd-nat.h: Revert.
2250         * fbsd-nat.c: Revert.
2251         * f-valprint.c: Revert.
2252         * f-typeprint.c: Revert.
2253         * f-lang.c: Revert.
2254         * extension.h: Revert.
2255         * extension.c: Revert.
2256         * extension-priv.h: Revert.
2257         * expprint.c: Revert.
2258         * exec.h: Revert.
2259         * exec.c: Revert.
2260         * exceptions.c: Revert.
2261         * event-top.c: Revert.
2262         * event-loop.c: Revert.
2263         * eval.c: Revert.
2264         * elfread.c: Revert.
2265         * dwarf2read.h: Revert.
2266         * dwarf2read.c: Revert.
2267         * dwarf2loc.c: Revert.
2268         * dwarf2expr.h: Revert.
2269         * dwarf2expr.c: Revert.
2270         * dwarf2-frame.c: Revert.
2271         * dwarf2-frame-tailcall.c: Revert.
2272         * dwarf-index-write.h: Revert.
2273         * dwarf-index-write.c: Revert.
2274         * dwarf-index-common.c: Revert.
2275         * dwarf-index-cache.h: Revert.
2276         * dwarf-index-cache.c: Revert.
2277         * dummy-frame.c: Revert.
2278         * dtrace-probe.c: Revert.
2279         * disasm.h: Revert.
2280         * disasm.c: Revert.
2281         * disasm-selftests.c: Revert.
2282         * dictionary.c: Revert.
2283         * dicos-tdep.c: Revert.
2284         * demangle.c: Revert.
2285         * dcache.h: Revert.
2286         * dcache.c: Revert.
2287         * darwin-nat.h: Revert.
2288         * darwin-nat.c: Revert.
2289         * darwin-nat-info.c: Revert.
2290         * d-valprint.c: Revert.
2291         * d-namespace.c: Revert.
2292         * d-lang.c: Revert.
2293         * ctf.c: Revert.
2294         * csky-tdep.c: Revert.
2295         * csky-linux-tdep.c: Revert.
2296         * cris-tdep.c: Revert.
2297         * cris-linux-tdep.c: Revert.
2298         * cp-valprint.c: Revert.
2299         * cp-support.c: Revert.
2300         * cp-namespace.c: Revert.
2301         * cp-abi.c: Revert.
2302         * corelow.c: Revert.
2303         * corefile.c: Revert.
2304         * continuations.c: Revert.
2305         * completer.h: Revert.
2306         * completer.c: Revert.
2307         * complaints.c: Revert.
2308         * coffread.c: Revert.
2309         * coff-pe-read.c: Revert.
2310         * cli-out.h: Revert.
2311         * cli-out.c: Revert.
2312         * charset.c: Revert.
2313         * c-varobj.c: Revert.
2314         * c-valprint.c: Revert.
2315         * c-typeprint.c: Revert.
2316         * c-lang.c: Revert.
2317         * buildsym.c: Revert.
2318         * buildsym-legacy.c: Revert.
2319         * build-id.h: Revert.
2320         * build-id.c: Revert.
2321         * btrace.c: Revert.
2322         * bsd-uthread.c: Revert.
2323         * breakpoint.h: Revert.
2324         * breakpoint.c: Revert.
2325         * break-catch-throw.c: Revert.
2326         * break-catch-syscall.c: Revert.
2327         * break-catch-sig.c: Revert.
2328         * blockframe.c: Revert.
2329         * block.c: Revert.
2330         * bfin-tdep.c: Revert.
2331         * bfin-linux-tdep.c: Revert.
2332         * bfd-target.c: Revert.
2333         * bcache.c: Revert.
2334         * ax-general.c: Revert.
2335         * ax-gdb.h: Revert.
2336         * ax-gdb.c: Revert.
2337         * avr-tdep.c: Revert.
2338         * auxv.c: Revert.
2339         * auto-load.c: Revert.
2340         * arm-wince-tdep.c: Revert.
2341         * arm-tdep.c: Revert.
2342         * arm-symbian-tdep.c: Revert.
2343         * arm-pikeos-tdep.c: Revert.
2344         * arm-obsd-tdep.c: Revert.
2345         * arm-nbsd-tdep.c: Revert.
2346         * arm-nbsd-nat.c: Revert.
2347         * arm-linux-tdep.c: Revert.
2348         * arm-linux-nat.c: Revert.
2349         * arm-fbsd-tdep.c: Revert.
2350         * arm-fbsd-nat.c: Revert.
2351         * arm-bsd-tdep.c: Revert.
2352         * arch-utils.c: Revert.
2353         * arc-tdep.c: Revert.
2354         * arc-newlib-tdep.c: Revert.
2355         * annotate.h: Revert.
2356         * annotate.c: Revert.
2357         * amd64-windows-tdep.c: Revert.
2358         * amd64-windows-nat.c: Revert.
2359         * amd64-tdep.c: Revert.
2360         * amd64-sol2-tdep.c: Revert.
2361         * amd64-obsd-tdep.c: Revert.
2362         * amd64-obsd-nat.c: Revert.
2363         * amd64-nbsd-tdep.c: Revert.
2364         * amd64-nbsd-nat.c: Revert.
2365         * amd64-nat.c: Revert.
2366         * amd64-linux-tdep.c: Revert.
2367         * amd64-linux-nat.c: Revert.
2368         * amd64-fbsd-tdep.c: Revert.
2369         * amd64-fbsd-nat.c: Revert.
2370         * amd64-dicos-tdep.c: Revert.
2371         * amd64-darwin-tdep.c: Revert.
2372         * amd64-bsd-nat.c: Revert.
2373         * alpha-tdep.c: Revert.
2374         * alpha-obsd-tdep.c: Revert.
2375         * alpha-nbsd-tdep.c: Revert.
2376         * alpha-mdebug-tdep.c: Revert.
2377         * alpha-linux-tdep.c: Revert.
2378         * alpha-linux-nat.c: Revert.
2379         * alpha-bsd-tdep.c: Revert.
2380         * alpha-bsd-nat.c: Revert.
2381         * aix-thread.c: Revert.
2382         * agent.c: Revert.
2383         * addrmap.c: Revert.
2384         * ada-varobj.c: Revert.
2385         * ada-valprint.c: Revert.
2386         * ada-typeprint.c: Revert.
2387         * ada-tasks.c: Revert.
2388         * ada-lang.c: Revert.
2389         * aarch64-tdep.c: Revert.
2390         * aarch64-ravenscar-thread.c: Revert.
2391         * aarch64-newlib-tdep.c: Revert.
2392         * aarch64-linux-tdep.c: Revert.
2393         * aarch64-linux-nat.c: Revert.
2394         * aarch64-fbsd-tdep.c: Revert.
2395         * aarch64-fbsd-nat.c: Revert.
2396         * aarch32-linux-nat.c: Revert.
2397
2398 2019-04-05  Tom Tromey  <tom@tromey.com>
2399
2400         * ft32-tdep.c: Sort headers.
2401         * frv-tdep.c: Sort headers.
2402         * frv-linux-tdep.c: Sort headers.
2403         * frame.c: Sort headers.
2404         * frame-unwind.c: Sort headers.
2405         * frame-base.c: Sort headers.
2406         * fork-child.c: Sort headers.
2407         * findvar.c: Sort headers.
2408         * findcmd.c: Sort headers.
2409         * filesystem.c: Sort headers.
2410         * filename-seen-cache.h: Sort headers.
2411         * filename-seen-cache.c: Sort headers.
2412         * fbsd-tdep.c: Sort headers.
2413         * fbsd-nat.h: Sort headers.
2414         * fbsd-nat.c: Sort headers.
2415         * f-valprint.c: Sort headers.
2416         * f-typeprint.c: Sort headers.
2417         * f-lang.c: Sort headers.
2418         * extension.h: Sort headers.
2419         * extension.c: Sort headers.
2420         * extension-priv.h: Sort headers.
2421         * expprint.c: Sort headers.
2422         * exec.h: Sort headers.
2423         * exec.c: Sort headers.
2424         * exceptions.c: Sort headers.
2425         * event-top.c: Sort headers.
2426         * event-loop.c: Sort headers.
2427         * eval.c: Sort headers.
2428         * elfread.c: Sort headers.
2429         * dwarf2read.h: Sort headers.
2430         * dwarf2read.c: Sort headers.
2431         * dwarf2loc.c: Sort headers.
2432         * dwarf2expr.h: Sort headers.
2433         * dwarf2expr.c: Sort headers.
2434         * dwarf2-frame.c: Sort headers.
2435         * dwarf2-frame-tailcall.c: Sort headers.
2436         * dwarf-index-write.h: Sort headers.
2437         * dwarf-index-write.c: Sort headers.
2438         * dwarf-index-common.c: Sort headers.
2439         * dwarf-index-cache.h: Sort headers.
2440         * dwarf-index-cache.c: Sort headers.
2441         * dummy-frame.c: Sort headers.
2442         * dtrace-probe.c: Sort headers.
2443         * disasm.h: Sort headers.
2444         * disasm.c: Sort headers.
2445         * disasm-selftests.c: Sort headers.
2446         * dictionary.c: Sort headers.
2447         * dicos-tdep.c: Sort headers.
2448         * demangle.c: Sort headers.
2449         * dcache.h: Sort headers.
2450         * dcache.c: Sort headers.
2451         * darwin-nat.h: Sort headers.
2452         * darwin-nat.c: Sort headers.
2453         * darwin-nat-info.c: Sort headers.
2454         * d-valprint.c: Sort headers.
2455         * d-namespace.c: Sort headers.
2456         * d-lang.c: Sort headers.
2457         * ctf.c: Sort headers.
2458         * csky-tdep.c: Sort headers.
2459         * csky-linux-tdep.c: Sort headers.
2460         * cris-tdep.c: Sort headers.
2461         * cris-linux-tdep.c: Sort headers.
2462         * cp-valprint.c: Sort headers.
2463         * cp-support.c: Sort headers.
2464         * cp-namespace.c: Sort headers.
2465         * cp-abi.c: Sort headers.
2466         * corelow.c: Sort headers.
2467         * corefile.c: Sort headers.
2468         * continuations.c: Sort headers.
2469         * completer.h: Sort headers.
2470         * completer.c: Sort headers.
2471         * complaints.c: Sort headers.
2472         * coffread.c: Sort headers.
2473         * coff-pe-read.c: Sort headers.
2474         * cli-out.h: Sort headers.
2475         * cli-out.c: Sort headers.
2476         * charset.c: Sort headers.
2477         * c-varobj.c: Sort headers.
2478         * c-valprint.c: Sort headers.
2479         * c-typeprint.c: Sort headers.
2480         * c-lang.c: Sort headers.
2481         * buildsym.c: Sort headers.
2482         * buildsym-legacy.c: Sort headers.
2483         * build-id.h: Sort headers.
2484         * build-id.c: Sort headers.
2485         * btrace.c: Sort headers.
2486         * bsd-uthread.c: Sort headers.
2487         * breakpoint.h: Sort headers.
2488         * breakpoint.c: Sort headers.
2489         * break-catch-throw.c: Sort headers.
2490         * break-catch-syscall.c: Sort headers.
2491         * break-catch-sig.c: Sort headers.
2492         * blockframe.c: Sort headers.
2493         * block.c: Sort headers.
2494         * bfin-tdep.c: Sort headers.
2495         * bfin-linux-tdep.c: Sort headers.
2496         * bfd-target.c: Sort headers.
2497         * bcache.c: Sort headers.
2498         * ax-general.c: Sort headers.
2499         * ax-gdb.h: Sort headers.
2500         * ax-gdb.c: Sort headers.
2501         * avr-tdep.c: Sort headers.
2502         * auxv.c: Sort headers.
2503         * auto-load.c: Sort headers.
2504         * arm-wince-tdep.c: Sort headers.
2505         * arm-tdep.c: Sort headers.
2506         * arm-symbian-tdep.c: Sort headers.
2507         * arm-pikeos-tdep.c: Sort headers.
2508         * arm-obsd-tdep.c: Sort headers.
2509         * arm-nbsd-tdep.c: Sort headers.
2510         * arm-nbsd-nat.c: Sort headers.
2511         * arm-linux-tdep.c: Sort headers.
2512         * arm-linux-nat.c: Sort headers.
2513         * arm-fbsd-tdep.c: Sort headers.
2514         * arm-fbsd-nat.c: Sort headers.
2515         * arm-bsd-tdep.c: Sort headers.
2516         * arch-utils.c: Sort headers.
2517         * arc-tdep.c: Sort headers.
2518         * arc-newlib-tdep.c: Sort headers.
2519         * annotate.h: Sort headers.
2520         * annotate.c: Sort headers.
2521         * amd64-windows-tdep.c: Sort headers.
2522         * amd64-windows-nat.c: Sort headers.
2523         * amd64-tdep.c: Sort headers.
2524         * amd64-sol2-tdep.c: Sort headers.
2525         * amd64-obsd-tdep.c: Sort headers.
2526         * amd64-obsd-nat.c: Sort headers.
2527         * amd64-nbsd-tdep.c: Sort headers.
2528         * amd64-nbsd-nat.c: Sort headers.
2529         * amd64-nat.c: Sort headers.
2530         * amd64-linux-tdep.c: Sort headers.
2531         * amd64-linux-nat.c: Sort headers.
2532         * amd64-fbsd-tdep.c: Sort headers.
2533         * amd64-fbsd-nat.c: Sort headers.
2534         * amd64-dicos-tdep.c: Sort headers.
2535         * amd64-darwin-tdep.c: Sort headers.
2536         * amd64-bsd-nat.c: Sort headers.
2537         * alpha-tdep.c: Sort headers.
2538         * alpha-obsd-tdep.c: Sort headers.
2539         * alpha-nbsd-tdep.c: Sort headers.
2540         * alpha-mdebug-tdep.c: Sort headers.
2541         * alpha-linux-tdep.c: Sort headers.
2542         * alpha-linux-nat.c: Sort headers.
2543         * alpha-bsd-tdep.c: Sort headers.
2544         * alpha-bsd-nat.c: Sort headers.
2545         * aix-thread.c: Sort headers.
2546         * agent.c: Sort headers.
2547         * addrmap.c: Sort headers.
2548         * ada-varobj.c: Sort headers.
2549         * ada-valprint.c: Sort headers.
2550         * ada-typeprint.c: Sort headers.
2551         * ada-tasks.c: Sort headers.
2552         * ada-lang.c: Sort headers.
2553         * aarch64-tdep.c: Sort headers.
2554         * aarch64-ravenscar-thread.c: Sort headers.
2555         * aarch64-newlib-tdep.c: Sort headers.
2556         * aarch64-linux-tdep.c: Sort headers.
2557         * aarch64-linux-nat.c: Sort headers.
2558         * aarch64-fbsd-tdep.c: Sort headers.
2559         * aarch64-fbsd-nat.c: Sort headers.
2560         * aarch32-linux-nat.c: Sort headers.
2561
2562 2019-04-04  Tom Tromey  <tom@tromey.com>
2563
2564         * varobj.c (varobj_create): Update.
2565         * rust-exp.y (struct rust_parser) <update_innermost_block,
2566         lookup_symbol>: New methods.
2567         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2568         Rename.
2569         (rust_parser::rust_lookup_type)
2570         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2571         * printcmd.c (display_command, do_one_display): Update.
2572         * parser-defs.h (struct parser_state) <parser_state>: Add
2573         "tracker" parameter.
2574         (block_tracker): New member.
2575         (class innermost_block_tracker) <innermost_block_tracker>: Add
2576         "types" parameter.
2577         <reset>: Remove method.
2578         (innermost_block): Don't declare.
2579         (null_post_parser): Update.
2580         * parse.c (innermost_block): Remove global.
2581         (write_dollar_variable): Update.
2582         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2583         Remove "tracker_types" parameter.
2584         (parse_expression): Add "tracker" parameter.
2585         (parse_expression_for_completion): Update.
2586         (null_post_parser): Add "tracker" parameter.
2587         * p-exp.y: Update rules.
2588         * m2-exp.y: Update rules.
2589         * language.h (struct language_defn) <la_post_parser>: Add
2590         "tracker" parameter.
2591         * go-exp.y: Update rules.
2592         * f-exp.y: Update rules.
2593         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2594         parameter.
2595         * d-exp.y: Update rules.
2596         * c-exp.y: Update rules.
2597         * breakpoint.c (set_breakpoint_condition): Create an
2598         innermost_block_tracker.
2599         (watch_command_1): Likewise.
2600         * ada-lang.c (resolve): Add "tracker" parameter.
2601         (resolve_subexp): Likewise.
2602         * ada-exp.y (write_var_from_sym): Update.
2603
2604 2019-04-04  Tom Tromey  <tom@tromey.com>
2605
2606         * type-stack.h: New file.
2607         * type-stack.c: New file.
2608         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2609         type-stack.h.
2610         (insert_into_type_stack, insert_type, push_type, push_type_int)
2611         (insert_type_address_space, pop_type, pop_type_int)
2612         (pop_typelist, pop_type_stack, append_type_stack)
2613         (push_type_stack, get_type_stack, push_typelist)
2614         (follow_type_instance_flags, follow_types): Don't declare.
2615         * parse.c (type_stack): Remove global.
2616         (parse_exp_in_context): Update.
2617         (insert_into_type_stack, insert_type, push_type, push_type_int)
2618         (insert_type_address_space, pop_type, pop_type_int)
2619         (pop_typelist, pop_type_stack, append_type_stack)
2620         (push_type_stack, get_type_stack, push_typelist)
2621         (follow_type_instance_flags, follow_types): Remove (moved to
2622         type-stack.c).
2623         * f-exp.y (type_stack): New global.
2624         Update rules.
2625         (push_kind_type, f_parse): Update.
2626         * d-exp.y (type_stack): New global.
2627         Update rules.
2628         (d_parse): Update.
2629         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2630         Update rules.
2631         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2632         (HFILES_NO_SRCDIR): Add type-stack.h.
2633
2634 2019-04-04  Tom Tromey  <tom@tromey.com>
2635
2636         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2637         (rust_parser::convert_ast_to_expression, rust_parse)
2638         (rust_lex_test_completion, rust_lex_tests): Update.
2639         * parser-defs.h (struct expr_completion_state): New.
2640         (struct parser_state) <parser_state>: Add completion parameter.
2641         <mark_struct_expression, mark_completion_tag>: New methods.
2642         <parse_completion, m_completion_state>: New members.
2643         (prefixify_expression, null_post_parser): Update.
2644         (mark_struct_expression, mark_completion_tag): Don't declare.
2645         * parse.c (parse_completion, expout_last_struct)
2646         (expout_tag_completion_type, expout_completion_name): Remove
2647         globals.
2648         (parser_state::mark_struct_expression)
2649         (parser_state::mark_completion_tag): Now methods.
2650         (prefixify_expression): Add last_struct parameter.
2651         (prefixify_subexp): Likewise.
2652         (parse_exp_1): Update.
2653         (parse_exp_in_context): Add cstate parameter.  Update.
2654         (parse_expression_for_completion): Create an
2655         expr_completion_state.
2656         (null_post_parser): Add "completion" parameter.
2657         * p-exp.y: Update rules.
2658         (yylex): Update.
2659         * language.h (struct language_defn) <la_post_parser>: Add
2660         "completing" parameter.
2661         * go-exp.y: Update rules.
2662         (lex_one_token): Update.
2663         * expression.h (parse_completion): Don't declare.
2664         * d-exp.y: Update rules.
2665         (lex_one_token): Update rules.
2666         * c-exp.y: Update rules.
2667         (lex_one_token): Update.
2668         * ada-lang.c (resolve): Add "parse_completion" parameter.
2669         (resolve_subexp): Likewise.
2670         (ada_resolve_function): Likewise.
2671
2672 2019-04-04  Tom Tromey  <tom@tromey.com>
2673
2674         * parser-defs.h (struct parser_state) <start_arglist,
2675         end_arglist>: New methods.
2676         <arglist_len, m_funcall_chain>: New members.
2677         (arglist_len, start_arglist, end_arglist): Don't declare.
2678         * parse.c (arglist_len, funcall_chain): Remove global.
2679         (start_arglist, end_arglist): Remove functions.
2680         (parse_exp_in_context): Update.
2681         * p-exp.y: Update rules.
2682         * m2-exp.y: Update rules.
2683         * go-exp.y: Update rules.
2684         * f-exp.y: Update rules.
2685         * d-exp.y: Update rules.
2686         * c-exp.y: Update rules.
2687
2688 2019-04-04  Tom Tromey  <tom@tromey.com>
2689
2690         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2691         lex_operator, push_back>: New methods.
2692         Update all rules.
2693         (rust_parser::lex_hex, lex_escape): Rename and update.
2694         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2695         (rust_parser::lex_operator): Rename and update.
2696         (rust_parser::lex_number, rustyylex, rustyyerror)
2697         (rust_lex_test_init, rust_lex_test_sequence)
2698         (rust_lex_test_push_back, rust_lex_tests): Update.
2699         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2700         parameter.
2701         <lexptr, prev_lexptr>: New members.
2702         (lexptr, prev_lexptr): Don't declare.
2703         * parse.c (lexptr, prev_lexptr): Remove globals.
2704         (parse_exp_in_context): Update.
2705         * p-exp.y (yylex, yyerror): Update.
2706         * m2-exp.y (parse_number, yylex, yyerror): Update.
2707         * go-exp.y (lex_one_token, yyerror): Update.
2708         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2709         * d-exp.y (lex_one_token, yyerror): Update.
2710         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2711         (lex_one_token, yyerror): Update.
2712         * ada-lex.l (YY_INPUT): Update.
2713         (rewind_to_char): Update.
2714         * ada-exp.y (yyerror): Update.
2715
2716 2019-04-04  Tom Tromey  <tom@tromey.com>
2717
2718         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2719         * parser-defs.h (struct parser_state) <parser_state>: Add new
2720         parameter.
2721         <comma_terminates>: New member.
2722         (comma_terminates): Don't declare global.
2723         * parse.c (comma_terminates): Remove global.
2724         (parse_exp_in_context): Update.
2725         * p-exp.y (yylex): Update.
2726         * m2-exp.y (yylex): Update.
2727         * go-exp.y (lex_one_token): Update.
2728         * f-exp.y (yylex): Update.
2729         * d-exp.y (lex_one_token): Update.
2730         * c-exp.y (lex_one_token): Update.
2731         * ada-lex.l: Update.
2732
2733 2019-04-04  Tom Tromey  <tom@tromey.com>
2734
2735         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2736         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2737         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2738         * parser-defs.h (paren_depth): Don't declare.
2739         * parse.c (paren_depth): Remove global.
2740         (parse_exp_in_context): Update.
2741         * p-exp.y (paren_depth): New global.
2742         (pascal_parse): Initialize it.
2743         * m2-exp.y (paren_depth): New global.
2744         (m2_parse): Initialize it.
2745         * go-exp.y (paren_depth): New global.
2746         (go_parse): Initialize it.
2747         * f-exp.y (paren_depth): New global.
2748         (f_parse): Initialize it.
2749         * d-exp.y (paren_depth): New global.
2750         (d_parse): Initialize it.
2751         * c-exp.y (paren_depth): New global.
2752         (c_parse): Initialize it.
2753         * ada-lex.l (paren_depth): New global.
2754         (lexer_init): Initialize it.
2755
2756 2019-04-04  Tom Tromey  <tom@tromey.com>
2757
2758         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2759         (rust_parser::convert_ast_to_type)
2760         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2761         * parser-defs.h (struct parser_state) <parser_state>: Add
2762         parameters.  Initialize new members.
2763         <expression_context_block, expression_context_pc>: New members.
2764         * parse.c (expression_context_block, expression_context_pc):
2765         Remove globals.
2766         (parse_exp_in_context): Update.
2767         * p-exp.y: Update all rules.
2768         (yylex): Update.
2769         * m2-exp.y: Update all rules.
2770         (yylex): Update.
2771         * go-exp.y (yylex): Update.
2772         * f-exp.y (yylex): Update.
2773         * d-exp.y: Update all rules.
2774         (yylex): Update.
2775         * c-exp.y: Update all rules.
2776         (lex_one_token, classify_name, yylex, c_parse): Update.
2777         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2778
2779 2019-04-04  Tom Tromey  <tom@tromey.com>
2780
2781         * gdbarch.h, gdbarch.c: Rebuild.
2782         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2783         * stap-probe.h:
2784         (struct stap_parse_info): Replace "parser_state" with
2785         "expr_builder".
2786         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2787         (parser_state): New class.
2788         * parse.c (expr_builder): Rename.
2789         (expr_builder::release): Rename.
2790         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2791         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2792         (write_exp_elt_longcst, write_exp_elt_floatcst)
2793         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2794         (write_exp_string_vector, write_exp_bitstring)
2795         (write_exp_msymbol, mark_struct_expression)
2796         (write_dollar_variable)
2797         (insert_type_address_space, increase_expout_size): Replace
2798         "parser_state" with "expr_builder".
2799         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2800         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2801         "parser_state" with "expr_builder".
2802
2803 2019-04-04  Tom Tromey  <tom@tromey.com>
2804
2805         * rust-exp.y: Replace "parse_language" with method call.
2806         * p-exp.y:
2807         (yylex): Replace "parse_language" with method call.
2808         * m2-exp.y:
2809         (yylex): Replace "parse_language" with method call.
2810         * go-exp.y (classify_name): Replace "parse_language" with method
2811         call.
2812         * f-exp.y (yylex): Replace "parse_language" with method call.
2813         * d-exp.y (lex_one_token): Replace "parse_language" with method
2814         call.
2815         * c-exp.y:
2816         (lex_one_token, classify_name, yylex): Replace "parse_language"
2817         with method call.
2818         * ada-exp.y (find_primitive_type, type_char)
2819         (type_system_address): Replace "parse_language" with method call.
2820
2821 2019-04-04  Tom Tromey  <tom@tromey.com>
2822
2823         * rust-exp.y: Replace "parse_gdbarch" with method call.
2824         * parse.c (write_dollar_variable, insert_type_address_space):
2825         Replace "parse_gdbarch" with method call.
2826         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2827         call.
2828         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2829         call.
2830         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2831         "parse_gdbarch" with method call.
2832         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2833         with method call.
2834         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2835         "parse_gdbarch" with method call.
2836         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2837         "parse_gdbarch" with method call.
2838         * c-exp.y (parse_type, parse_number, classify_name): Replace
2839         "parse_gdbarch" with method call.
2840         * ada-lex.l: Replace "parse_gdbarch" with method call.
2841         * ada-exp.y (parse_type, find_primitive_type, type_char)
2842         (type_system_address): Replace "parse_gdbarch" with method call.
2843
2844 2019-04-04  Tom Tromey  <tom@tromey.com>
2845
2846         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2847         * stap-probe.c (stap_parse_argument): Update.
2848         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2849         initial_size parameter.
2850         * rust-exp.y (rust_lex_tests): Update.
2851         * parse.c (parser_state): Update.
2852         (parse_exp_in_context): Update.
2853         * parser-defs.h (struct parser_state) <parser_state>: Remove
2854         "initial_size" parameter.
2855
2856 2019-04-04  Tom Tromey  <tom@tromey.com>
2857
2858         * parser-defs.h (increase_expout_size): Don't declare.
2859         * parse.c (increase_expout_size): Now static.
2860
2861 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2862
2863         * gnu-nat.c (gnu_nat_target::wait): Fix
2864         target_waitstatus_to_string call.
2865
2866 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2867
2868         * eval.c (evaluate_subexp_standard): Handle internal functions
2869         during Fortran function call handling.
2870
2871 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2872
2873         * NEWS: Mention new internal functions.
2874         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2875         (read_base_type): Use dwarf2_init_complex_target_type.
2876         * value.c (creal_internal_fn): New function.
2877         (cimag_internal_fn): New function.
2878         (_initialize_values): Register new internal functions.
2879
2880 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2881
2882         * infrun.c (stop_all_threads): If debug_infrun, always
2883         trace the wait status after wait_one, using
2884         target_waitstatus_to_string and target_pid_to_str.
2885         (handle_inferior_event): Replace various trace of
2886         wait status kind by a single trace.
2887         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2888         wait status kind image by target_waitstatus_to_string.
2889         * target/waitstatus.c (target_waitstatus_to_string): Fix
2890         obsolete comment.
2891
2892 2019-04-01  Tom Tromey  <tromey@adacore.com>
2893
2894         PR symtab/23331:
2895         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2896
2897 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2898             Pedro Alves  <palves@redhat.com>
2899
2900         * top.c (quit_force): Call 'finalize_values'.
2901         * value.c (finalize_values): New function.
2902         * value.h (finalize_values): Declare.
2903
2904 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2905
2906         * NEWS: Announce $_gdb_major and $_gdb_minor.
2907
2908         * top.c (init_gdb_version_vars): New function.
2909         (gdb_init): Call init_gdb_version_vars.
2910
2911 2019-03-29  Tom Tromey  <tromey@adacore.com>
2912
2913         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2914         help text.  Remove dead code.
2915
2916 2019-03-29  Keith Seitz  <keiths@redhat.com>
2917
2918         From Siddhesh Poyarekar:
2919         * f-lang.h (f77_get_upperbound): Return LONGEST.
2920         (f77_get_lowerbound): Likewise.
2921         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2922         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2923         print them.
2924         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2925         plongest to format print it.
2926         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2927         (f77_get_upperbound): Likewise.
2928         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2929         LOWER_BOUND to LONGEST.
2930         (f77_create_arrayprint_offset_tbl): Likewise.
2931
2932 2019-03-29  Keith Seitz  <keiths@redhat.com>
2933
2934         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2935         %s/pulongest for TYPE_LENGTH instead of %d in format
2936         strings.
2937         * ada-typerint.c (ada_print_type): Likewise.
2938         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2939         * compile/compile-c-support.c (generate_register_struct): Likewise.
2940         * gdbtypes.c (recursive_dump_type): Likewise.
2941         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2942         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2943         instead of %d in format strings.
2944         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2945         to std::min to ULONGEST.
2946         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2947         instead of %d in format strings.
2948         * tracepoint.c (info_scope_command): Likewise.
2949         * typeprint.c (print_offset_data::update)
2950         (print_offset_data::finish): Likewise.
2951         * xtensa-tdep.c (xtensa_store_return_value)
2952         (xtensa_push_dummy_call): Likewise.
2953
2954 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2955
2956         * windows-nat.c (display_selector): Fixed format specifications
2957         for 64-bit Cygwin.
2958
2959 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2960
2961         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2962
2963 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2964
2965         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2966         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2967         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2968         (nios2_linux_init_abi): Install it.
2969
2970 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2971
2972         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2973
2974 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2975
2976         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2977
2978 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2979             Tom Tromey  <tromey@adacore.com>
2980
2981         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2982
2983 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2984
2985         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2986         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2987         method to compute the bounds of range types. Also print "[evaluated]"
2988         if the bounds' values come from a dynamic evaluation.
2989
2990 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2991
2992         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2993         whitespace when pretty printing is on.
2994
2995 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2996
2997         * ppc-linux-nat.c: Add include.
2998
2999 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3000
3001         * NEWS: Mention AArch64 Pointer Authentication.
3002
3003 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3004
3005         * arm-linux-nat.c: Add include.
3006
3007 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
3008
3009         * source-cache.c (source_cache::get_source_lines): Re-read
3010         fullname after calling open_source_file.
3011
3012 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
3013
3014         * NEWS: Mention TLS support for FreeBSD.
3015
3016 2019-03-25  Tom Tromey  <tromey@adacore.com>
3017
3018         * minsyms.c (BUNCH_SIZE): Update comment.
3019         (~minimal_symbol_reader): Remove old comment.
3020         (compact_minimal_symbols): Update comment.
3021         (minimal_symbol_reader::install): Remove old comment.  Update
3022         other comments.
3023
3024 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3025
3026         * s390-linux-nat.c: Add include.
3027
3028 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3029
3030         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3031         Call linux_get_hwcap.
3032         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3033         Likewise.
3034         (aarch64_linux_get_hwcap): Remove function.
3035         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
3036         declaration.
3037         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
3038         linux_get_hwcap.
3039         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3040         * linux-tdep.c (linux_get_hwcap): Add function.
3041         (linux_get_hwcap2): Likewise.
3042         * linux-tdep.h (linux_get_hwcap): Add declaration.
3043         (linux_get_hwcap2): Likewise.
3044         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
3045         (ppc_linux_get_hwcap2): Likewise.
3046         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
3047         linux_get_hwcap.
3048         (ppc_linux_nat_target::insert_watchpoint): Likewise.
3049         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
3050         (ppc_linux_nat_target::read_description): Likewise.
3051         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
3052         * s390-linux-nat.c: Likewise.
3053         * s390-linux-tdep.c (s390_core_read_description): Likewise.
3054
3055 2019-03-24  Tom Tromey  <tom@tromey.com>
3056
3057         * ada-lang.c (standard_lookup): Simplify initialization.
3058         (ada_lookup_symbol_nonlocal): Simplify return.
3059         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
3060         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
3061         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
3062         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
3063         initialization.
3064         * solib.c (solib_global_lookup): Simplify.
3065         * symtab.c (null_block_symbol): Remove.
3066         (symbol_cache_lookup): Simplify returns.
3067         (lookup_language_this): Simplify returns.
3068         (lookup_symbol_aux): Simplify return.
3069         (lookup_local_symbol): Simplify returns.
3070         (lookup_global_symbol_from_objfile): Simplify return.
3071         (lookup_symbol_in_objfile_symtabs)
3072         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
3073         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
3074         (lookup_static_symbol, lookup_global_symbol): Simplify return.
3075         * cp-namespace.c (cp_lookup_bare_symbol)
3076         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
3077         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
3078         (cp_lookup_nested_symbol): Don't use null_block_symbol.
3079         (cp_lookup_symbol_via_imports): Simplify initialization.
3080         (find_symbol_in_baseclass): Likewise.
3081         * symtab.h (null_block_symbol): Remove.
3082         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
3083         (d_lookup_nested_symbol, d_lookup_symbol_imports)
3084         (d_lookup_symbol_module): Likewise.
3085         (find_symbol_in_baseclass): Simplify initialization.
3086
3087 2019-03-24  Tom Tromey  <tom@tromey.com>
3088
3089         * expression.h: Don't include symtab.h.
3090         (struct block): Forward declare.
3091
3092 2019-03-24  Tom Tromey  <tom@tromey.com>
3093
3094         * c-exp.y (typebase): Remove casts.
3095         * gdbtypes.c (lookup_unsigned_typename, )
3096         (lookup_signed_typename): Remove cast.
3097         * eval.c (parse_to_comma_and_eval): Remove cast.
3098         * parse.c (write_dollar_variable): Remove cast.
3099         * block.h (struct block) <superblock>: Now const.
3100         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
3101         * psymtab.c (psym_map_matching_symbols): Make "block" const.
3102         (map_block): Make "block" const.
3103         * symfile.h (struct quick_symbol_functions)
3104         <map_matching_symbols>: Constify block argument to "callback".
3105         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
3106         const.
3107         (find_pc_sect_compunit_symtab): Make "b" const.
3108         (find_symbol_at_address): Likewise.
3109         (search_symbols): Likewise.
3110         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
3111         (dw2_debug_names_lookup_symbol): Likewise.
3112         (dw2_map_matching_symbols): Update.
3113         * p-valprint.c (pascal_val_print): Remove "block".
3114         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
3115         (aux_add_nonlocal_symbols): Make "block" const.
3116         (resolve_subexp): Remove cast.
3117         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
3118         const.
3119         (iterate_over_file_blocks): Likewise.
3120         * f-exp.y (%union) <bval>: Remove.
3121         * coffread.c (patch_opaque_types): Make "b" const.
3122         * spu-tdep.c (spu_catch_start): Make "block" const.
3123         * c-valprint.c (print_unpacked_pointer): Remove "block".
3124         * symmisc.c (dump_symtab_1): Make "b" const.
3125         (block_depth): Make "block" const.
3126         * d-exp.y (%union) <bval>: Remove.
3127         * cp-support.h (cp_lookup_rtti_type): Update.
3128         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
3129         * psymtab.c (psym_lookup_symbol): Make "block" const.
3130         (maintenance_check_psymtabs): Make "b" const.
3131         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
3132         (enumerate_locals, enumerate_args): Update.
3133         * python/py-symtab.c (stpy_global_block): Make "block" const.
3134         (stpy_static_block): Likewise.
3135         * inline-frame.c (block_starting_point_at): Make "new_block"
3136         const.
3137         * block.c (find_block_in_blockvector): Make return type const.
3138         (blockvector_for_pc_sect): Make "b" const.
3139         (find_block_in_blockvector): Make "b" const.
3140
3141 2019-03-23  Tom Tromey  <tom@tromey.com>
3142
3143         * varobj.c (varobj_create): Update.
3144         * symfile.c (clear_symtab_users): Don't reset innermost_block.
3145         * printcmd.c (display_command, do_one_display): Don't reset
3146         innermost_block.
3147         * parser-defs.h (enum innermost_block_tracker_type): Move to
3148         expression.h.
3149         (innermost_block): Update comment.
3150         * parse.c (parse_exp_1): Add tracker_types parameter.
3151         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
3152         tracker_types parameter.  Reset innermost_block.
3153         (parse_exp_in_context): Remove.
3154         (parse_expression_for_completion): Update.
3155         * objfiles.c (~objfile): Don't reset expression_context_block or
3156         innermost_block.
3157         * expression.h (enum innermost_block_tracker_type): Move from
3158         parser-defs.h.
3159         (parse_exp_1): Add tracker_types parameter.
3160         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
3161         reset innermost_block.
3162
3163 2019-03-23  Tom Tromey  <tom@tromey.com>
3164
3165         * objfiles.h: Include bcache.h.
3166
3167 2019-03-23  Tom Tromey  <tom@tromey.com>
3168
3169         * linespec.c (get_current_search_block): Use
3170         scoped_restore_current_language.
3171         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
3172
3173 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3174             Jiong Wang  <jiong.wang@arm.com>
3175
3176         * aarch64-linux-tdep.c
3177         (aarch64_linux_iterate_over_regset_sections): Check for pauth
3178         section.
3179         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
3180
3181 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3182             Jiong Wang  <jiong.wang@arm.com>
3183
3184         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
3185         instructions.
3186         (aarch64_analyze_prologue_test): Add PACIASP test.
3187         (aarch64_prologue_prev_register): Unmask PC value.
3188
3189 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3190             Jiong Wang  <jiong.wang@arm.com>
3191
3192         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
3193         (aarch64_dwarf2_prev_register): Unmask PC value.
3194         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
3195         (aarch64_execute_dwarf_cfa_vendor_op): Check for
3196         DW_CFA_AARCH64_negate_ra_state.
3197         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
3198
3199 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3200             Jiong Wang  <jiong.wang@arm.com>
3201
3202         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
3203         registers.
3204         (aarch64_pseudo_register_name): Likewise.
3205         (aarch64_pseudo_register_type): Likewise.
3206         (aarch64_pseudo_register_reggroup_p): Likewise.
3207         (aarch64_gdbarch_init): Add pauth registers.
3208         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
3209         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
3210         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
3211         (struct gdbarch_tdep): Add regnum for ra_state.
3212
3213 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3214             Jiong Wang  <jiong.wang@arm.com>
3215
3216         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
3217
3218 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3219             Jiong Wang  <jiong.wang@arm.com>
3220
3221         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
3222         function.
3223         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
3224         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
3225         (aarch64_gdbarch_init): Add puth registers.
3226         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
3227         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
3228         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
3229
3230 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3231             Jiong Wang  <jiong.wang@arm.com>
3232
3233         * aarch64-linux-nat.c
3234         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
3235         * aarch64-linux-tdep.c
3236         (aarch64_linux_core_read_description): Likewise.
3237         (aarch64_linux_get_hwcap): New function.
3238         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
3239         (aarch64_linux_get_hwcap): New declaration.
3240
3241 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3242             Jiong Wang  <jiong.wang@arm.com>
3243
3244         * aarch64-linux-nat.c
3245         (aarch64_linux_nat_target::read_description): Add pauth param.
3246         * aarch64-linux-tdep.c
3247         (aarch64_linux_core_read_description): Likewise.
3248         * aarch64-tdep.c (struct target_desc): Add in pauth.
3249         (aarch64_read_description): Add pauth param.
3250         (aarch64_gdbarch_init): Likewise.
3251         * aarch64-tdep.h (aarch64_read_description): Likewise.
3252         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3253         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3254         * features/Makefile: Add new files.
3255         * features/aarch64-pauth.c: New file.
3256         * features/aarch64-pauth.xml: New file.
3257
3258 2019-03-20  Tom Tromey  <tromey@adacore.com>
3259
3260         * infrun.c (handle_inferior_event): Rename from
3261         handle_inferior_event_1.  Create a scoped_value_mark.
3262         (handle_inferior_event): Remove.
3263
3264 2019-03-19  Tom Tromey  <tromey@adacore.com>
3265
3266         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3267         * infrun.h (print_stop_event): Add "displays" parameter.
3268         * infrun.c (print_stop_event): Add "displays" parameter.
3269
3270 2019-03-19  Pedro Alves  <palves@redhat.com>
3271
3272         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3273         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3274         to -1.  Fix TABs vs spaces.
3275         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3276         * tui/tui-out.h (tui_ui_out) Add intro comments.
3277         <m_line, m_start_of_line>: In-class initialize, and add describing
3278         comment.
3279
3280 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3281
3282         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3283         variable names.
3284         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3285
3286 2019-03-18  Pedro Alves  <palves@redhat.com>
3287             Eli Zaretskii <eliz@gnu.org>
3288
3289         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3290         m_line and m_start_of_line.
3291
3292 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3293
3294         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3295         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3296         it returns a newline.  This fixes a regression in TU mode, whereby
3297         the next line is output on the same screen line as the user input.
3298
3299 2019-03-18  Tom Tromey  <tromey@adacore.com>
3300
3301         * minsyms.c (minimal_symbol_reader::install): Remove call to
3302         obstack_blank.
3303
3304 2019-03-18  Pedro Alves  <palves@redhat.com>
3305
3306         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3307         New globals.
3308         (apply_style): New, factored out from ...
3309         (apply_ansi_escape): ... this.  Handle reverse video mode.
3310         (tui_set_reverse_mode): New function.
3311         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3312         * tui/tui-winsource.c (tui_show_source_line): Use
3313         tui_set_reverse_mode instead of setting A_STANDOUT.
3314         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3315         New setter methods.
3316
3317 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3318
3319         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3320         Handle tabs.
3321
3322 2019-03-18  Tom Tromey  <tromey@adacore.com>
3323
3324         * ada-lang.c (empty_array): Add "high" parameter.
3325         (ada_evaluate_subexp): Update.
3326
3327 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3328
3329         * unittests/string_view-selftests.c: Define
3330         _initialize_string_view_selftests unconditionally.
3331
3332 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3333
3334         PR gdb/24350
3335         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3336
3337 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3338
3339         PR gdb/24351
3340         * windows-nat.c (display_selector): Fix format specifiers.
3341
3342 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3343
3344         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3345         tui_refill_source_window instead of tui_refresh_win, to update the
3346         current execution line.  This fixes redisplay of the current line
3347         when stepping through the code with "next" or "step".
3348
3349 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3350
3351         * source-cache.c (source_cache::get_source_lines): Call
3352         find_source_lines to initialize s->nlines.  This fixes vertical
3353         scrolling of TUI source window when the DOWN arrow is pressed.
3354
3355 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3356
3357         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3358         linux-thread-db.c (_initialize_thread_db): Likewise.
3359
3360 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3361
3362         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3363         wclrtoeol in tui_show_source_line".  This reverts changes made in
3364         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3365
3366 2019-03-15  Tom Tromey  <tom@tromey.com>
3367
3368         * symtab.h (struct minimal_symbol): Derive from
3369         general_symbol_info.
3370         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3371         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3372         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3373         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3374         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3375         (MSYMBOL_SEARCH_NAME): Update.
3376         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3377         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3378         * minsyms.c (minimal_symbol_reader::record_full): Update.
3379
3380 2019-03-15  Tom Tromey  <tom@tromey.com>
3381
3382         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3383
3384 2019-03-15  Tom Tromey  <tom@tromey.com>
3385
3386         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3387         unique_xmalloc_ptr.
3388         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3389         Update.
3390         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3391         (build_minimal_symbol_hash_tables)
3392         (minimal_symbol_reader::install): Update.
3393
3394 2019-03-15  Tom Tromey  <tom@tromey.com>
3395
3396         * symtab.c (create_demangled_names_hash): Update.
3397         (symbol_set_names): Update.
3398         * objfiles.h (struct objfile_per_bfd_storage)
3399         <demangled_names_hash>: Now an htab_up.
3400         * objfiles.c (objfile_per_bfd_storage): Simplify.
3401
3402 2019-03-15  Tom Tromey  <tom@tromey.com>
3403
3404         * objfiles.h (struct objfile_per_bfd_storage): Declare
3405         destructor.
3406         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3407         New.
3408         (get_objfile_bfd_data): Use new.  Don't initialize
3409         language_of_main.
3410         (free_objfile_per_bfd_storage): Remove.
3411         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3412
3413 2019-03-15  Tom Tromey  <tom@tromey.com>
3414
3415         * symfile.c (reread_symbols): Update.
3416         * objfiles.c (objfile::objfile): Update.
3417         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3418         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3419         comment.
3420         (minimal_symbol_reader::install): Update.
3421         (terminate_minimal_symbol_table): Remove.
3422         * jit.c (jit_object_close_impl): Update.
3423
3424 2019-03-15  Tom Tromey  <tom@tromey.com>
3425
3426         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3427         initializations.
3428
3429 2019-03-15  Tom Tromey  <tom@tromey.com>
3430
3431         * objfiles.h (struct objfile_per_bfd_storage)
3432         <demangled_hash_languages>: Now a bitset.
3433         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3434         (lookup_minimal_symbol): Update.
3435
3436 2019-03-15  Tom Tromey  <tom@tromey.com>
3437
3438         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3439         Don't return the symbol.
3440         * coffread.c (record_minimal_symbol): Use record_full.
3441
3442 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3443
3444         The MS-Windows port of ncurses fails to switch to a color pair if
3445         one or both of the colors are the implicit default colors.  This
3446         change records the default colors when TUI is initialized, and
3447         then specifies them explicitly when a color pair uses the default
3448         colors.  This allows color styling in TUI mode on MS-Windows.
3449
3450         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3451         ncurses_norm_attr.
3452         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3453         colors in ncurses_norm_attr.
3454         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3455         "none", replace it with the default color recorded in
3456         ncurses_norm_attr.
3457
3458 2019-03-14  Tom Tromey  <tromey@adacore.com>
3459
3460         * source-cache.h (class source_cache) <get_source_lines>: Return
3461         std::string.
3462         * source-cache.c (source_cache::extract_lines): Handle case where
3463         first_pos==npos.  Return std::string.
3464         (source_cache::get_source_lines): Update.
3465
3466 2019-03-14  Tom Tromey  <tromey@adacore.com>
3467
3468         * NEWS: Add item for "style sources" commands.
3469         * source-cache.c (source_cache::get_source_lines): Check
3470         source_styling.
3471         * cli/cli-style.c (source_styling): New global.
3472         (_initialize_cli_style): Add "style sources" commands.
3473         (show_style_sources): New function.
3474         * cli/cli-style.h (source_styling): Declare.
3475
3476 2019-03-14  Pedro Alves  <palves@redhat.com>
3477             Tom Tromey  <tromey@adacore.com>
3478
3479         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3480         * tui/tui-winsource.c (tui_refill_source_window): New function,
3481         from...
3482         (tui_horizontal_source_scroll): ... here.  Move some logic.
3483         * cli/cli-style.c (set_style_enabled): Notify new observable.
3484         * tui/tui-hooks.c (tui_redisplay_source): New function.
3485         (tui_attach_detach_observers): Attach or detach
3486         tui_redisplay_source.
3487         * observable.h (source_styling_changed): New observable.
3488         * observable.c: Define source_styling_changed observable.
3489
3490 2019-03-13  Tom Tromey  <tromey@adacore.com>
3491
3492         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3493         (i386_gnu_nat_target::store_registers): Update.
3494         * target-debug.h (target_debug_print_std_string): New macro.
3495         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3496         * windows-tdep.c (display_one_tib): Update.
3497         * tui/tui-stack.c (tui_make_status_line): Update.
3498         * top.c (print_inferior_quit_action): Update.
3499         * thread.c (thr_try_catch_cmd): Update.
3500         (add_thread_with_info): Update.
3501         (thread_target_id_str): Update.
3502         (thr_try_catch_cmd): Update.
3503         (thread_command): Update.
3504         (thread_find_command): Update.
3505         * record-btrace.c (record_btrace_target::info_record)
3506         (record_btrace_resume_thread, record_btrace_target::resume)
3507         (record_btrace_cancel_resume, record_btrace_step_thread)
3508         (record_btrace_target::wait, record_btrace_target::wait)
3509         (record_btrace_target::wait, record_btrace_target::stop): Update.
3510         * progspace.c (print_program_space): Update.
3511         * process-stratum-target.c
3512         (process_stratum_target::thread_address_space): Update.
3513         * linux-fork.c (linux_fork_mourn_inferior)
3514         (detach_checkpoint_command, info_checkpoints_command)
3515         (linux_fork_context): Update.
3516         (linux_fork_detach): Update.
3517         (class scoped_switch_fork_info): Update.
3518         (delete_checkpoint_command): Update.
3519         * infrun.c (follow_fork_inferior): Update.
3520         (follow_fork_inferior): Update.
3521         (proceed_after_vfork_done): Update.
3522         (handle_vfork_child_exec_or_exit): Update.
3523         (follow_exec): Update.
3524         (displaced_step_prepare_throw): Update.
3525         (displaced_step_restore): Update.
3526         (start_step_over): Update.
3527         (resume_1): Update.
3528         (clear_proceed_status_thread): Update.
3529         (proceed): Update.
3530         (print_target_wait_results): Update.
3531         (do_target_wait): Update.
3532         (context_switch): Update.
3533         (stop_all_threads): Update.
3534         (restart_threads): Update.
3535         (finish_step_over): Update.
3536         (handle_signal_stop): Update.
3537         (switch_back_to_stepped_thread): Update.
3538         (keep_going_pass_signal): Update.
3539         (print_exited_reason): Update.
3540         (normal_stop): Update.
3541         * inferior.c (inferior_pid_to_str): Change return type.
3542         (print_selected_inferior): Update.
3543         (add_inferior): Update.
3544         (detach_inferior): Update.
3545         * dummy-frame.c (fprint_dummy_frames): Update.
3546         * dcache.c (dcache_info_1): Update.
3547         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3548         (btrace_fetch, btrace_clear): Update.
3549         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3550         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3551         type.
3552         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3553         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3554         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3555         * gdbarch.c, gdbarch.h: Rebuild.
3556         * gdbarch.sh (core_pid_to_str): Change return type.
3557         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3558         return type.
3559         (windows_nat_target::pid_to_str): Change return type.
3560         (windows_delete_thread): Update.
3561         (windows_nat_target::attach): Update.
3562         (windows_nat_target::files_info): Update.
3563         * target-delegates.c: Rebuild.
3564         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3565         return type.
3566         (sol_thread_target::pid_to_str): Change return type.
3567         * remote.c (class remote_target) <pid_to_str>: Change return
3568         type.
3569         (remote_target::pid_to_str): Change return type.
3570         (extended_remote_target::attach, remote_target::remote_stop_ns)
3571         (remote_target::remote_notif_remove_queued_reply)
3572         (remote_target::push_stop_reply, remote_target::disable_btrace):
3573         Update.
3574         (extended_remote_target::attach): Update.
3575         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3576         type.
3577         (gdbsim_target::pid_to_str): Change return type.
3578         * ravenscar-thread.c (struct ravenscar_thread_target)
3579         <pid_to_str>: Change return type.
3580         (ravenscar_thread_target::pid_to_str): Change return type.
3581         * procfs.c (class procfs_target) <pid_to_str>: Change return
3582         type.
3583         (procfs_target::pid_to_str): Change return type.
3584         (procfs_target::attach): Update.
3585         (procfs_target::detach): Update.
3586         (procfs_target::fetch_registers): Update.
3587         (procfs_target::store_registers): Update.
3588         (procfs_target::wait): Update.
3589         (procfs_target::files_info): Update.
3590         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3591         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3592         return type.
3593         (nto_procfs_target::pid_to_str): Change return type.
3594         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3595         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3596         return type.
3597         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3598         (exit_lwp): Update.
3599         (attach_proc_task_lwp_callback, get_detach_signal)
3600         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3601         (linux_nat_target::resume, wait_lwp, stop_callback)
3602         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3603         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3604         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3605         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3606         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3607         type.
3608         (inf_ptrace_target::attach): Update.
3609         (inf_ptrace_target::files_info): Update.
3610         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3611         type.
3612         (go32_nat_target::pid_to_str): Change return type.
3613         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3614         (gnu_nat_target::wait): Update.
3615         (gnu_nat_target::wait): Update.
3616         (gnu_nat_target::resume): Update.
3617         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3618         (fbsd_nat_target::wait): Update.
3619         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3620         type.
3621         (darwin_nat_target::attach): Update.
3622         * corelow.c (class core_target) <pid_to_str>: Change return type.
3623         (core_target::pid_to_str): Change return type.
3624         * target.c (normal_pid_to_str): Change return type.
3625         (default_pid_to_str): Likewise.
3626         (target_pid_to_str): Change return type.
3627         (target_translate_tls_address): Update.
3628         (target_announce_detach): Update.
3629         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3630         return type.
3631         (bsd_uthread_target::pid_to_str): Change return type.
3632         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3633         type.
3634         (bsd_kvm_target::pid_to_str): Change return type.
3635         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3636         return type.
3637         (aix_thread_target::pid_to_str): Change return type.
3638         * target.h (struct target_ops) <pid_to_str>: Change return type.
3639         (target_pid_to_str, normal_pid_to_str): Likewise.
3640         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3641         type.
3642         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3643         type.
3644         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3645         return type.
3646         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3647         type.
3648         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3649         type.
3650         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3651         return type.
3652
3653 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3654
3655         * NEWS: Mention that the new default MI version is 3.  Mention
3656         changes to the output of commands and events that deal with
3657         multi-location breakpoints.
3658         * breakpoint.c: Include "mi/mi-out.h".
3659         (print_one_breakpoint): Change output syntax if using MI version
3660         >= 3.
3661         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3662         New.
3663         (mi_multi_location_breakpoint_output_fixed): New.
3664         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3665         (mi_cmd_fix_multi_location_breakpoint_output): New.
3666         (mi_multi_location_breakpoint_output_fixed): New.
3667         * mi/mi-cmds.c (mi_cmds): Register command
3668         -fix-multi-location-breakpoint-output.
3669         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3670         interpreter "mi".
3671
3672 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3673
3674         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3675         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3676         instantiate mi_ui_out based on interpreter name.
3677         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3678         * mi/mi-main.c (mi_load_progress): Likewise.
3679
3680 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3681
3682         * NEWS: Combine separate "New targets" sections for 8.3.
3683
3684 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3685
3686         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3687         (ppcfbsd_init_abi): Install gdbarch
3688         "fetch_tls_load_module_address" and "get_thread_local_address"
3689         methods.
3690
3691 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3692
3693         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3694         (riscv_fbsd_init_abi): Install gdbarch
3695         "fetch_tls_load_module_address" and "get_thread_local_address"
3696         methods.
3697
3698 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3699
3700         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3701         (i386fbsd_init_abi): Install gdbarch
3702         "fetch_tls_load_module_address" and "get_thread_local_address"
3703         methods.
3704
3705 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3706
3707         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3708         (amd64fbsd_init_abi): Install gdbarch
3709         "fetch_tls_load_module_address" and "get_thread_local_address"
3710         methods.
3711
3712 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3713
3714         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3715         (struct fbsd_pspace_data): New type.
3716         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3717         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3718         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3719         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3720         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3721
3722 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3723
3724         * gdbtypes.c (lookup_struct_elt): New function.
3725         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3726         * gdbtypes.h (struct struct_elt): New type.
3727         (lookup_struct_elt): New prototype.
3728
3729 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3730
3731         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3732         remove disabled code block.
3733
3734 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3735
3736         * gdbarch.sh (get_thread_local_address): New method.
3737         * gdbarch.h, gdbarch.c: Regenerate.
3738         * target.c (target_translate_tls_address): Use
3739         gdbarch_get_thread_local_address if present instead of
3740         target::get_thread_local_address.
3741
3742 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3743
3744         * target.h (target::get_thread_local_address): Update comment.
3745
3746 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3747
3748         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3749         objfile->separate_debug_objfile_backlink if not NULL.
3750
3751 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3752
3753         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3754         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3755         (amd64bsd_store_inferior_registers): Likewise.
3756         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3757         Enable segment base registers.
3758         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3759         PT_GETFSBASE and PT_GETGSBASE.
3760         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3761         PT_SETGSBASE.
3762         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3763         segment base registers.
3764         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3765
3766 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3767
3768         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3769         Update calls to i386_target_description to add 'segments'
3770         parameter.
3771         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3772         add segment base registers.
3773         * arch/i386.c (i386_create_target_description): Add 'segments'
3774         parameter to enable segment base registers.
3775         * arch/i386.h (i386_create_target_description): Likewise.
3776         * features/i386/32bit-segments.xml: New file.
3777         * features/i386/32bit-segments.c: Generate.
3778         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3779         call to i386_target_description to add 'segments' parameter.
3780         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3781         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3782         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3783         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3784         if feature is present.
3785         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3786         Add 'segments' parameter to call to i386_target_description.
3787         (i386_target_description): Add 'segments' parameter to enable
3788         segment base registers.
3789         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3790         to call to i386_target_description.
3791         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3792         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3793         Define I386_NUM_REGS.
3794         (i386_target_description): Add 'segments' parameter to enable
3795         segment base registers.
3796
3797 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3798
3799         PR/24325
3800         * source-cache.c: #undef open and close, to avoid unresolved
3801         externals during linking.
3802
3803 2019-03-12  Tom Tromey  <tromey@adacore.com>
3804
3805         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3806         const.  Add initializers.
3807         (_initialize_remote): Don't initialize ptid globals.
3808
3809 2019-03-12  Pedro Alves  <palves@redhat.com>
3810
3811         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3812
3813 2019-03-12  Pedro Alves  <palves@redhat.com>
3814
3815         * cp-name-parser.y (main): Remove unused 'len' variable.
3816
3817 2019-03-12  Tom Tromey  <tromey@adacore.com>
3818
3819         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3820         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3821
3822 2019-03-12  Tom Tromey  <tromey@adacore.com>
3823
3824         * linux-nat.c (iterate_over_lwps): Update.
3825         (stop_callback): Remove parameter.
3826         (stop_wait_callback, detach_callback, resume_set_callback)
3827         (select_singlestep_lwp_callback, set_ignore_sigint)
3828         (status_callback, resumed_callback, resume_clear_callback)
3829         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3830         data parameter.
3831         (linux_nat_target::detach, linux_nat_target::resume)
3832         (linux_stop_and_wait_all_lwps, select_event_lwp)
3833         (linux_nat_filter_event, linux_nat_wait_1)
3834         (linux_nat_target::kill, linux_nat_target::stop)
3835         (linux_nat_target::stop): Update.
3836         (linux_nat_resume_callback): Change type.
3837         (resume_stopped_resumed_lwps, count_events_callback)
3838         (select_event_lwp_callback): Likewise.
3839         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3840         * arm-linux-nat.c (struct update_registers_data): Remove.
3841         (update_registers_callback): Change type.
3842         (arm_linux_insert_hw_breakpoint1): Update.
3843         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3844         parameter.
3845         (x86_linux_dr_set_addr): Update.
3846         (x86_linux_dr_set_control): Update.
3847         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3848         (iterate_over_lwps): Use gdb::function_view.
3849         * nat/aarch64-linux-hw-point.c (struct
3850         aarch64_dr_update_callback_param): Remove.
3851         (debug_reg_change_callback): Change type.
3852         (aarch64_notify_debug_reg_change): Update.
3853         * s390-linux-nat.c (s390_refresh_per_info): Update.
3854
3855 2019-03-11  Tom Tromey  <tromey@adacore.com>
3856
3857         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3858         redundant assignment to "this_cu".
3859
3860 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3861
3862         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3863
3864 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3865
3866         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3867         from...
3868         (rank_one_type): ... this.
3869
3870 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3871
3872         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3873         from...
3874         (rank_one_type): ... this.
3875
3876 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3877
3878         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3879         from...
3880         (rank_one_type): ... this.
3881
3882 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3883
3884         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3885         from...
3886         (rank_one_type): ... this.
3887
3888 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3889
3890         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3891         from...
3892         (rank_one_type): ... this.
3893
3894 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3895
3896         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3897         from...
3898         (rank_one_type): ... this.
3899
3900 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3901
3902         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3903         from...
3904         (rank_one_type): ... this.
3905
3906 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3907
3908         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3909         from...
3910         (rank_one_type): ... this.
3911
3912 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3913
3914         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3915         from...
3916         (rank_one_type): ... this.
3917
3918 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3919
3920         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3921         from...
3922         (rank_one_type): ... this.
3923
3924 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3925
3926         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3927         from...
3928         (rank_one_type): ... this.
3929
3930 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3931
3932         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3933         from...
3934         (rank_one_type): ... this.
3935
3936 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3937
3938         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3939         inferior-events' shows the example events.
3940
3941 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3942
3943         Support styling on native MS-Windows console
3944
3945         PR/24315
3946         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3947         on MS-Windows if $TERM is not defined.
3948
3949         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3950
3951         * posix-hdep.c (gdb_console_fputs):
3952         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3953         functions.
3954         * ui-file.h (gdb_console_fputs): Add prototype.
3955
3956         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3957         back to fputs only if the former returns zero.
3958
3959 2019-03-07  Tom Tromey  <tom@tromey.com>
3960
3961         * symmisc.c (print_symbol_bcache_statistics): Update.
3962         (print_objfile_statistics): Update.
3963         * symfile.c (allocate_symtab): Update.
3964         * stabsread.c: Don't include bcache.h.
3965         * psymtab.h (struct psymbol_bcache): Don't declare.
3966         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3967         (psymbol_bcache_init, psymbol_bcache_free)
3968         (psymbol_bcache_get_bcache): Don't declare.
3969         * psymtab.c (struct psymbol_bcache): Remove.
3970         (psymtab_storage::psymtab_storage): Update.
3971         (psymtab_storage::~psymtab_storage): Update.
3972         (psymbol_bcache_init, psymbol_bcache_free)
3973         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3974         (add_psymbol_to_bcache): Update.
3975         (allocate_psymtab): Update.
3976         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3977         macro_cache>: No longer pointers.
3978         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3979         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3980         * macrotab.c (macro_bcache): Update.
3981         * macroexp.c: Don't include bcache.h.
3982         * gdbtypes.c (check_types_worklist): Update.
3983         (types_deeply_equal): Remove TRY/CATCH.  Update.
3984         * elfread.c (elf_symtab_read): Update.
3985         * dwarf2read.c: Don't include bcache.h.
3986         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3987         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3988         (print_bcache_statistics, bcache_memory_used): Don't declare.
3989         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3990         methods.  Rename all data members.
3991         * bcache.c (struct bcache): Move to bcache.h.
3992         (bcache::expand_hash_table): Rename from expand_hash_table.
3993         (bcache): Remove.
3994         (bcache::insert): Rename from bcache_full.
3995         (bcache::compare): Rename from bcache_compare.
3996         (bcache_xmalloc): Remove.
3997         (bcache::~bcache): Rename from bcache_xfree.
3998         (bcache::print_statistics): Rename from print_bcache_statistics.
3999         (bcache::memory_used): Rename from bcache_memory_used.
4000
4001 2019-03-07  Pedro Alves  <palves@redhat.com>
4002
4003         * infrun.c (normal_stop): Also check for
4004         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
4005
4006 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4007
4008         * f-lang.c (value_from_host_double): Moved to...
4009         * value.c (value_from_host_double): ...here.
4010         * value.h (value_from_host_double): Declare.
4011         * guile/scm-math.c (vlscm_convert_typed_number): Use
4012         value_from_host_double.
4013         (vlscm_convert_number): Likewise.
4014         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
4015         * python/py-value.c (convert_value_from_python): Likewise.
4016
4017 2019-03-06  Tom Tromey  <tom@tromey.com>
4018
4019         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
4020
4021 2019-03-06  Tom Tromey  <tom@tromey.com>
4022
4023         * utils.h (free_current_contents): Don't declare.
4024         * utils.c (free_current_contents): Remove.
4025
4026 2019-03-06  Tom Tromey  <tom@tromey.com>
4027
4028         * top.c (quit_force): Update.
4029         * main.c (captured_command_loop): Update.
4030         * common/new-op.c (operator new): Update.
4031         * common/common-exceptions.c (struct catcher)
4032         <save_cleanup_chain>: Remove member.
4033         (exceptions_state_mc_init): Update.
4034         (exception_try_scope_entry): Return nullptr.
4035         (exception_try_scope_exit, exception_rethrow)
4036         (throw_exception_sjlj, throw_exception_cxx): Update.
4037         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
4038         (all_cleanups, do_cleanups, discard_cleanups)
4039         (discard_final_cleanups, save_cleanups, save_final_cleanups)
4040         (restore_cleanups, restore_final_cleanups): Don't declare.
4041         (do_final_cleanups): Remove parameter.
4042         * common/cleanups.c (cleanup_chain, make_cleanup)
4043         (make_cleanup_dtor, all_cleanups, do_cleanups)
4044         (discard_my_cleanups, discard_cleanups)
4045         (discard_final_cleanups, save_my_cleanups, save_cleanups)
4046         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
4047         (null_cleanup): Remove.
4048         (do_final_cleanups): Remove parameter.
4049
4050 2019-03-06  Tom Tromey  <tom@tromey.com>
4051
4052         * remote.c (remote_target::remote_parse_stop_reply): Use
4053         unique_xmalloc_ptr.
4054
4055 2019-03-06  Tom Tromey  <tom@tromey.com>
4056
4057         * stabsread.c (struct stabs_field_info): Rename from field_info.
4058         <list, fnlist>: Add initializers.
4059         <obstack>: New member.
4060         (read_member_functions, read_struct_fields, read_baseclasses):
4061         Allocate on obstack.  Don't use cleanups.
4062         (read_one_struct_field, read_member_functions, read_struct_fields)
4063         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
4064         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
4065         (read_struct_type): Update.
4066
4067 2019-03-06  Tom Tromey  <tom@tromey.com>
4068
4069         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
4070         * common/filestuff.h (make_cleanup_close): Don't declare.
4071         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
4072         Remove.
4073
4074 2019-03-06  Tom Tromey  <tom@tromey.com>
4075
4076         * solib-aix.c: Use make_scope_exit.
4077
4078 2019-03-06  Tom Tromey  <tom@tromey.com>
4079
4080         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
4081         Use make_scope_exit.
4082
4083 2019-03-06  Tom Tromey  <tom@tromey.com>
4084
4085         * solib-svr4.c (disable_probes_interface): Remove parameter.
4086         (svr4_handle_solib_event): Use make_scope_exit.
4087
4088 2019-03-06  Tom Tromey  <tom@tromey.com>
4089
4090         * remote.c (struct stop_reply_deleter): Remove.
4091         (stop_reply_up): Update.
4092         (struct stop_reply): Derive from notif_event.  Don't typedef.
4093         <regcache>: Now a std::vector.
4094         (stop_reply_xfree): Remove.
4095         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
4096         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
4097         (remote_target::discard_pending_stop_replies): Use delete.
4098         (remote_target::remote_parse_stop_reply): Update.
4099         (remote_target::process_stop_reply): Update.
4100         * remote-notif.h (struct notif_event): Add virtual destructor.
4101         Remove "dtr" member.
4102         (struct notif_client) <alloc_event>: Return a unique_ptr.
4103         (notif_event_xfree): Don't declare.
4104         (notif_event_up): New typedef.
4105         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
4106         (notif_event_xfree, do_notif_event_xfree): Remove.
4107         (remote_notif_state_xfree): Update.
4108
4109 2019-03-06  Tom Tromey  <tom@tromey.com>
4110
4111         * infrun.c (displaced_step_clear_cleanup): Now a
4112         forward_scope_exit type.
4113         (displaced_step_prepare_throw): Update.
4114         (displaced_step_fixup): Update.
4115
4116 2019-03-06  Tom Tromey  <tom@tromey.com>
4117
4118         * inferior.h (class inferior): Update comment.
4119         * gdbthread.h (class thread_info): Update comment.
4120
4121 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
4122             Tom Tromey  <tom@tromey.com>
4123
4124         * stabsread.h (struct stab_section_list): Remove.
4125         (coffstab_build_psymtabs): Update.
4126         * dbxread.c (symbuf_sections): Now a std::vector.
4127         (sect_idx): New global.
4128         (fill_symbuf): Update.
4129         (coffstab_build_psymtabs): Change type of stabsects parameter.
4130         Update.
4131         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
4132         std::vector.
4133         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
4134         (coff_locate_sections): Update.
4135         (coff_symfile_read): Remove cleanups.  Update.
4136         (init_stringtab): Add storage parameter.
4137         (free_stringtab, free_stringtab_cleanup): Remove.
4138         (init_lineno): Add storage parameter.
4139         (free_linetab, free_linetab_cleanup): Remove.
4140
4141 2019-03-06  Pedro Alves  <palves@redhat.com>
4142
4143         * linux-fork.c (fork_info::clobber_regs): Delete.
4144         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
4145         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
4146         comment.  Adjust.
4147         (scoped_switch_fork_info::scoped_switch_fork_info)
4148         (checkpoint_command, linux_fork_context): Adjust
4149         fork_save_infrun_state calls.
4150
4151 2019-03-06  Pedro Alves  <palves@redhat.com>
4152
4153         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
4154         (inf_has_multiple_threads): Return 'bool' and rewrite using
4155         inferior_info::threads().
4156
4157 2019-03-06  Pedro Alves  <palves@redhat.com>
4158
4159         * linux-fork.c: Include <list>.
4160         (fork_list): Now a std::list instance.
4161         (fork_info): Add ctor, dtor, and in-class initialize all fields.
4162         (forks_exist_p, find_last_fork): Adjust.
4163         (new_fork): Delete.
4164         (one_fork_p): New.
4165         (add_fork): Adjust.
4166         (free_fork): Delete, folded into fork_info::~fork_info().
4167         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
4168         Adjust.
4169         (init_fork_list): Delete.
4170         (linux_fork_killall, linux_fork_mourn_inferior)
4171         (linux_fork_detach, info_checkpoints_command): Adjust.
4172         (_initialize_linux_fork): No longer call init_fork_list.
4173
4174 2019-03-06  Pedro Alves  <palves@redhat.com>
4175
4176         * linux-fork.c (new_fork): New, split out of ...
4177         (add_fork): ... this.  Return void.  Move "first fork" special
4178         case from here, to ...
4179         (checkpoint_command): ... here.
4180         * linux-linux.h (add_fork): Return void.
4181
4182 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4183
4184         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
4185
4186 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4187             Chris January  <chris.january@arm.com>
4188             David Lecomber  <david.lecomber@arm.com>
4189
4190         * f-exp.y: New token, UNOP_INTRINSIC.
4191         (exp): New pattern using UNOP_INTRINSIC token.
4192         (f77_keywords): Add 'abs' keyword.
4193         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
4194         (value_from_host_double): New function.
4195         (evaluate_subexp_f): Support UNOP_ABS.
4196
4197 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4198
4199         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
4200         types.
4201
4202 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4203
4204         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
4205         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
4206         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
4207
4208 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4209
4210         * f-exp.y (convert_to_kind_type): Handle more type kinds.
4211
4212 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4213             Chris January  <chris.january@arm.com>
4214
4215         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
4216         * f-exp.y: Define 'KIND' token.
4217         (exp): New pattern for KIND expressions.
4218         (ptype): Handle types with a kind extension.
4219         (direct_abs_decl): Extend to spot kind extensions.
4220         (f77_keywords): Add 'kind' to the list.
4221         (push_kind_type): New function.
4222         (convert_to_kind_type): New function.
4223         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
4224         * parse.c (operator_length_standard): Likewise.
4225         * parser-defs.h (enum type_pieces): Add tp_kind.
4226         * std-operator.def: Add UNOP_KIND.
4227
4228 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4229
4230         * f-exp.y (f_parse): Set yydebug.
4231
4232 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4233
4234         * f-lang.c (evaluate_subexp_f): New function.
4235         (exp_descriptor_f): New global.
4236         (f_language_defn): Use exp_descriptor_f instead of
4237         exp_descriptor_standard.
4238
4239 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4240
4241         * f-exp.y (struct token): Add comments.
4242         (dot_ops): Remove uppercase versions and the end marker.
4243         (f77_keywords): Likewise.
4244         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
4245         entries in the dot_ops array are case insensitive, and use
4246         strncasecmp to compare strings.  Also some whitespace cleanup in
4247         this area.  Similar for the f77_keywords array, except entries in
4248         this list might be case sensitive.
4249
4250 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4251
4252         * f-exp.y (struct f77_boolean_val): Add comments.
4253         (boolean_values): Remove uppercase versions, and end marker.
4254         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
4255         and use strncasecmp to achieve case insensitivity.  Additionally,
4256         perform whitespace cleanup around this code.
4257
4258 2019-03-06  Tom Tromey  <tromey@adacore.com>
4259
4260         * remote-sim.c (gdbsim_target_open): Use result of
4261         gdb_argv::release.
4262
4263 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4264         Dirk Schubert  <dirk.schubert@arm.com>
4265         Chris January  <chris.january@arm.com>
4266
4267         * eval.c (evaluate_subexp_standard): Call Fortran argument
4268         wrapping logic.
4269         * f-lang.c (struct value): A value which can be passed into a
4270         Fortran function call.
4271         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4272         where appropriate.
4273         (struct type): Value ready for a Fortran function call.
4274         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4275         is needed.
4276         * f-lang.h (fortran_argument_convert): Declaration.
4277         (fortran_preserve_arg_pointer): Declaration.
4278         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4279
4280 2019-03-05  Tom Tromey  <tromey@adacore.com>
4281
4282         * python/py-prettyprint.c (print_string_repr): Remove #if.
4283         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4284
4285 2019-03-05  Tom Tromey  <tromey@adacore.com>
4286
4287         * target.c (the_dummy_target): Move later.  Change type to
4288         "dummy_target".
4289         (initialize_targets): Don't initialize the_dummy_target.
4290
4291 2019-03-05  Tom Tromey  <tromey@adacore.com>
4292
4293         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4294         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4295
4296 2019-03-05  Tom Tromey  <tromey@adacore.com>
4297
4298         * windows-nat.c (windows_nat_target::attach)
4299         (windows_nat_target::detach): Don't call gdb_flush.
4300         * valprint.c (generic_val_print, val_print, val_print_string):
4301         Don't call gdb_flush.
4302         * utils.c (defaulted_query): Don't call gdb_flush.
4303         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4304         * target.c (target_announce_detach): Don't call gdb_flush.
4305         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4306         * remote.c (extended_remote_target::attach): Don't call
4307         gdb_flush.
4308         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4309         * printcmd.c (do_examine): Don't call gdb_flush.
4310         (info_display_command): Don't call gdb_flush.
4311         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4312         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4313         * memattr.c (info_mem_command): Don't call gdb_flush.
4314         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4315         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4316         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4317         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4318         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4319         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4320         (gnu_nat_target::detach): Don't call gdb_flush.
4321         * f-valprint.c (f_val_print): Don't call gdb_flush.
4322         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4323         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4324         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4325         gdb_flush.
4326         * c-valprint.c (c_val_print): Don't call gdb_flush.
4327         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4328
4329 2019-03-05  Tom Tromey  <tromey@adacore.com>
4330
4331         * varobj.c (update_dynamic_varobj_children): Update.
4332         (install_default_visualizer): Use reset, not release.
4333         * value.c (set_internalvar): Update.
4334         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4335         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4336         ATTRIBUTE_UNUSED_RESULT.
4337
4338 2019-03-05  Tom Tromey  <tromey@adacore.com>
4339
4340         * remote.c (class scoped_remote_fd) <release>: Add
4341         ATTRIBUTE_UNUSED_RESULT.
4342
4343 2019-03-05  Tom Tromey  <tromey@adacore.com>
4344
4345         * macroexp.c (struct macro_buffer) <release>: Add
4346         ATTRIBUTE_UNUSED_RESULT.
4347
4348 2019-03-05  Tom Tromey  <tromey@adacore.com>
4349
4350         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4351         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4352         ATTRIBUTE_UNUSED_RESULT.
4353
4354 2019-03-05  Tom Tromey  <tromey@adacore.com>
4355
4356         * common/scoped_fd.h (class scoped_fd) <release>: Add
4357         ATTRIBUTE_UNUSED_RESULT.
4358
4359 2019-03-05  Tom Tromey  <tromey@adacore.com>
4360
4361         * parser-defs.h (struct parser_state) <release>: Add
4362         ATTRIBUTE_UNUSED_RESULT.
4363
4364 2019-03-05  Tom Tromey  <tromey@adacore.com>
4365
4366         * utils.h (class gdb_argv) <release>: Add
4367         ATTRIBUTE_UNUSED_RESULT.
4368         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4369
4370 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4371
4372         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4373         for-loop range, to avoid compiler warnings.
4374
4375         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4376         avoid compiler warnings about unused variables.
4377
4378         * NEWS: Mention end of support for native debugging on MS-Windows
4379         before XP.
4380
4381         PR gdb/24292
4382         * common/netstuff.c:
4383         * gdbserver/gdbreplay.c
4384         * gdbserver/remote-utils.c:
4385         * ser-tcp.c:
4386         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4387         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4388         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4389         'getaddrinfo' and 'freeaddrinfo' were not available before
4390         Windows XP, and mingw.org's MinGW headers by default define
4391         _WIN32_WINNT to 0x500.
4392
4393 2019-03-01  Gary Benson <gbenson@redhat.com>
4394
4395         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4396
4397 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4398             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4399
4400         PR gdb/8527
4401         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4402         set_sigint_trap, clear_sigint_trap.
4403
4404 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4405
4406         * target.c (target_detach): Clear the regcache and the
4407         frame cache.
4408
4409 2019-02-27  Pedro Alves  <palves@redhat.com>
4410
4411         * utils.c (set_screen_size): When we cap the height/width sizes,
4412         tweak the corresponding command variable to show "unlimited":
4413
4414 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4415             Pedro Alves  <palves@redhat.com>
4416
4417         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4418         before calling rl_set_screen_size.
4419
4420 2019-02-27  Tom Tromey  <tromey@adacore.com>
4421
4422         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4423         define.
4424         * python/py-value.c: Remove Python 2.4 workaround.
4425         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4426         workaround.
4427         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4428         Python 2.4 workaround.
4429         * python/python-internal.h: Remove Python 2.4 comment.
4430         (Py_ssize_t): Don't define.
4431         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4432         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4433         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4434         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4435         * python/python.c (do_start_initialization): Remove Python 2.4
4436         workaround.
4437         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4438         (print_children): Remove Python 2.4 workaround.
4439         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4440         workaround.
4441         (CHARBUFFERPROC_NAME): Remove.
4442         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4443         Python 2.4 workaround.
4444
4445 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4446
4447         * NEWS: Note minimum Python version.
4448
4449 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4450
4451         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4452         code from these functions.  Remove corresponding ifdefs.  Use
4453         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4454         Remove gotos and target of gotos.
4455         (infpy_search_memory): Likewise.
4456
4457 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4458
4459         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4460         (hppa_gdbarch_init): Don't register deleted functions with
4461         gdbarch.
4462
4463 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4464
4465         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4466         (h8300_unwind_sp): Delete.
4467         (h8300_dummy_id): Delete.
4468         (h8300_gdbarch_init): Don't register deleted functions with
4469         gdbarch.
4470
4471 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4472
4473         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4474         (ft32_unwind_pc): Delete.
4475         (ft32_unwind_sp): Delete.
4476         (ft32_gdbarch_init): Don't register deleted functions with
4477         gdbarch.
4478
4479 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4480
4481         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4482         (frv_unwind_pc): Delete.
4483         (frv_unwind_sp): Delete.
4484         (frv_gdbarch_init): Don't register deleted functions with
4485         gdbarch.
4486
4487 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4488
4489         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4490         (riscv_unwind_pc): Delete.
4491         (riscv_unwind_sp): Delete.
4492         (riscv_gdbarch_init): Don't register deleted functions with
4493         gdbarch.
4494
4495 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4496
4497         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4498         (csky_unwind_pc): Delete.
4499         (csky_unwind_sp): Delete.
4500         (csky_gdbarch_init): Don't register deleted functions with
4501         gdbarch.
4502
4503 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4504
4505         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4506         (cris_unwind_pc): Delete.
4507         (cris_unwind_sp): Delete.
4508         (cris_gdbarch_init): Don't register deleted functions with
4509         gdbarch.
4510
4511 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4512
4513         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4514         (bfin_unwind_pc): Delete.
4515         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4516
4517 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4518
4519         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4520         (arm_unwind_pc): Delete.
4521         (arm_unwind_sp): Delete.
4522         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4523
4524 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4525
4526         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4527         (arc_unwind_pc): Delete.
4528         (arc_unwind_sp): Delete.
4529         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4530
4531 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4532
4533         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4534         (alpha_unwind_pc): Delete.
4535         (alpha_gdbarch_init): Don't register deleted functions with
4536         gdbarch.
4537
4538 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4539
4540         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4541         (aarch64_unwind_pc): Delete.
4542         (aarch64_unwind_sp): Delete.
4543         (aarch64_gdbarch_init): Don't register deleted functions with
4544         gdbarch.
4545
4546 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4547
4548         * gdbtypes.c (type_align): Don't consider static members when
4549         computing structure alignment.
4550
4551 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4552
4553         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4554         return 0 for other types.
4555         * arch-utils.c (default_type_align): Always return 0.
4556         * gdbarch.h: Regenerate.
4557         * gdbarch.sh (type_align): Extend comment.
4558         * gdbtypes.c (type_align): Add additional comments, always call
4559         gdbarch_type_align before applying the default rules.
4560         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4561         generic code will then apply a suitable default.
4562         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4563         types, return 0 for other types.
4564
4565 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4566
4567         * NEWS: Create a new section for the next release branch.
4568         Rename the section of the current branch, now that it has
4569         been cut.
4570
4571 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4572
4573         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4574         * version.in: Bump version to 8.3.50.DATE-git.
4575
4576 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4577
4578         * aix-thread.c (ptid_cmp): Remove unused variable.
4579         (get_signaled_thread): Likewise.
4580         (store_regs_user_thread): Likewise.
4581         (store_regs_kernel_thread): Likewise.
4582         (fetch_regs_kernel_thread): Remove shadowed variable.
4583
4584 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4585
4586         * features/riscv/32bit-cpu.xml: Add register numbers.
4587         * features/riscv/32bit-fpu.c: Regenerate.
4588         * features/riscv/32bit-fpu.xml: Add register numbers.
4589         * features/riscv/64bit-cpu.xml: Add register numbers.
4590         * features/riscv/64bit-fpu.c: Regenerate.
4591         * features/riscv/64bit-fpu.xml: Add register numbers.
4592
4593 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4594
4595         * NEWS: Mention two argument form of gdb.Value constructor.
4596         * python/py-value.c (convert_buffer_and_type_to_value): New
4597         function.
4598         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4599         Add support for handling an optional second argument.  Call
4600         convert_buffer_and_type_to_value as appropriate.
4601         * python/python-internal.h (Py_buffer_deleter): New struct.
4602         (Py_buffer_up): New typedef.
4603
4604 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4605
4606         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4607         instead of releasing ownership.
4608
4609 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4610
4611         * dwarf2read.c (open_and_init_dwp_file): Call
4612         elf_numsections instead of bfd_count_sections to initialize
4613         dwp_file->num_sections.
4614
4615 2019-02-25  Tom Tromey  <tromey@adacore.com>
4616
4617         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4618
4619 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4620
4621         * gcore.in: Add '--readnever' option when invoking GDB.
4622
4623 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4624
4625         * MAINTAINERS: Update my email address.
4626
4627 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4628
4629         * build-id.c (build_id_to_debug_bfd_1): New function.
4630         (build_id_to_debug_bfd): Look for separate debug file in
4631         sysroot.
4632
4633 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4634
4635         * gdbarch.sh: Update the copyright year range that is placed into
4636         generated files.
4637
4638 2019-02-22  Keith Seitz  <keiths@redhat.com>
4639
4640         PR symtab/23853
4641         * linespec.c (create_sals_line_offset): Search for the default
4642         symtab's filename instead of its fullname.
4643
4644 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4645
4646         * NEWS: Update style defaults.
4647
4648 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4649
4650         * main.c (captured_main_1): Disable styling in batch mode.
4651
4652 2019-02-20  Tom Tromey  <tom@tromey.com>
4653
4654         * symtab.c (symtab_symbol_info): Fix typos.
4655
4656 2019-02-20  Tom Tromey  <tromey@adacore.com>
4657
4658         * findcmd.c (_initialize_mem_search): Use upper case for
4659         metasyntactic variables.
4660
4661 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4662
4663         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4664         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4665
4666 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4667
4668         * top.h (source_file_name): Change to std::string.
4669         * top.c (source_file_name): Likewise.
4670         (command_line_input): Adjust.
4671         * cli/cli-script.c (script_from_file): Adjust.
4672
4673 2019-02-19  Tom Tromey  <tromey@adacore.com>
4674
4675         * ravenscar-thread.c
4676         (ravenscar_thread_target::update_thread_list): Don't call
4677         ada_build_task_list.
4678         * ada-lang.h (ada_build_task_list): Don't declare.
4679         * ada-tasks.c (struct ada_tasks_inferior_data)
4680         <task_list_valid_p>: Now bool.
4681         (read_known_tasks, ada_task_list_changed)
4682         (ada_tasks_invalidate_inferior_data): Update.
4683         (read_known_tasks_array): Return bool.
4684         (read_known_tasks_list): Likewise.
4685         (read_known_tasks): Return void.
4686         (ada_build_task_list): Now static.
4687
4688 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4689
4690         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4691         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4692
4693 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4694
4695         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4696         variant for ada_tasks_pspace_data_handle and
4697         ada_tasks_inferior_data_handle.
4698         (ada_tasks_pspace_data_cleanup): New function.
4699         (ada_tasks_inferior_data_cleanup): New function.
4700
4701 2019-02-17  Tom Tromey  <tom@tromey.com>
4702
4703         * macrotab.h (macro_source_fullname): Return a std::string.
4704         * macrotab.c (macro_include, check_for_redefinition)
4705         (macro_undef, macro_lookup_definition, foreach_macro)
4706         (foreach_macro_in_scope): Update.
4707         (macro_source_fullname): Return a std::string.
4708         * macrocmd.c (show_pp_source_pos): Update.
4709
4710 2019-02-17  Tom Tromey  <tom@tromey.com>
4711
4712         * macrocmd.c (show_pp_source_pos): Style the file names.
4713
4714 2019-02-17  Tom Tromey  <tom@tromey.com>
4715
4716         PR tui/24197:
4717         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4718
4719 2019-02-17  Tom Tromey  <tom@tromey.com>
4720
4721         * ada-lang.c (user_select_syms): Use filtered printing.
4722         * utils.c (wrap_style): New global.
4723         (desired_style): Remove.
4724         (emit_style_escape): Add stream parameter.
4725         (set_output_style, reset_terminal_style, prompt_for_continue):
4726         Update.
4727         (flush_wrap_buffer): Only flush gdb_stdout.
4728         (wrap_here): Set wrap_style.
4729         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4730         treat escape sequences as a character.  Change when wrap buffer is
4731         flushed.
4732         (fputs_styled): Do not set the output style when the default is
4733         requested.
4734         * ui-style.h (struct ui_file_style) <is_default>: New method.
4735         * source.c (print_source_lines_base): Emit escape sequences in one
4736         piece.
4737
4738 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4739
4740         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4741         integers and enumeration types.
4742
4743 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4744
4745         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4746         instead of lookup_symbol_in_language
4747         (do_exact_match): New function.
4748         (ada_get_symbol_name_matcher): Return do_exact_match when
4749         doing a verbatim match.
4750
4751 2019-02-15  Tom Tromey  <tromey@adacore.com>
4752
4753         * ravenscar-thread.c (ravenscar_thread_target::resume)
4754         (ravenscar_thread_target::wait): Special case wildcard requests.
4755
4756 2019-02-15  Tom Tromey  <tromey@adacore.com>
4757
4758         * ravenscar-thread.c (base_ptid): Remove.
4759         (struct ravenscar_thread_target) <close>: New method.
4760         <m_base_ptid>: New member.
4761         <update_inferior_ptid, active_task, task_is_currently_active,
4762         runtime_initialized>: Declare methods.
4763         <ravenscar_thread_target>: Add constructor.
4764         (ravenscar_thread_target::task_is_currently_active)
4765         (ravenscar_thread_target::update_inferior_ptid)
4766         (ravenscar_runtime_initialized): Rename.  Now methods.
4767         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4768         (ravenscar_thread_target::update_thread_list): Update.
4769         (ravenscar_thread_target::active_task): Now method.
4770         (ravenscar_thread_target::store_registers)
4771         (ravenscar_thread_target::prepare_to_store)
4772         (ravenscar_thread_target::prepare_to_store)
4773         (ravenscar_thread_target::mourn_inferior): Update.
4774         (ravenscar_inferior_created): Use "new" to create target.
4775         (ravenscar_thread_target::get_ada_task_ptid): Update.
4776         (_initialize_ravenscar): Don't initialize base_ptid.
4777         (ravenscar_ops): Remove global.
4778
4779 2019-02-15  Tom Tromey  <tromey@adacore.com>
4780
4781         * target.h (push_target): Declare new overload.
4782         * target.c (push_target): New overload, taking an rvalue reference.
4783         * remote.c (remote_target::open_1): Use push_target overload.
4784         * corelow.c (core_target_open): Use push_target overload.
4785
4786 2019-02-15  Tom Tromey  <tromey@adacore.com>
4787
4788         * ravenscar-thread.c (is_ravenscar_task)
4789         (ravenscar_task_is_currently_active): Return bool.
4790         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4791         (_initialize_ravenscar): Remove "(void)".
4792         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4793         Return bool.
4794
4795 2019-02-15  Tom Tromey  <tromey@adacore.com>
4796
4797         * ravenscar-thread.c (ravenscar_runtime_initializer)
4798         (has_ravenscar_runtime, get_running_thread_id)
4799         (ravenscar_thread_target::resume): Fix indentation.
4800
4801 2019-02-15  Tom Tromey  <tromey@adacore.com>
4802
4803         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4804         from ravenscar_arch_ops.
4805         (sparc_ravenscar_ops::fetch_registers)
4806         (sparc_ravenscar_ops::store_registers): Now methods.
4807         (sparc_ravenscar_prepare_to_store): Remove.
4808         (sparc_ravenscar_ops): Redefine.
4809         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4810         methods and destructor.  Remove members.
4811         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4812         (ravenscar_thread_target::store_registers)
4813         (ravenscar_thread_target::prepare_to_store): Update.
4814         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4815         Remove.
4816         (struct ppc_ravenscar_powerpc_ops): Derive from
4817         ravenscar_arch_ops.
4818         (ppc_ravenscar_powerpc_ops::fetch_registers)
4819         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4820         (ppc_ravenscar_powerpc_ops): Redefine.
4821         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4822         (ppc_ravenscar_e500_ops::fetch_registers)
4823         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4824         (ppc_ravenscar_e500_ops): Redefine.
4825         * aarch64-ravenscar-thread.c
4826         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4827         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4828         (aarch64_ravenscar_fetch_registers)
4829         (aarch64_ravenscar_store_registers): Now methods.
4830         (aarch64_ravenscar_ops): Redefine.
4831
4832 2019-02-15  Tom Tromey  <tromey@adacore.com>
4833
4834         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4835         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4836         (ravenscar_thread_target::stopped_by_watchpoint)
4837         (ravenscar_thread_target::stopped_data_address)
4838         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4839
4840 2019-02-15  Tom Tromey  <tromey@adacore.com>
4841
4842         * ravenscar-thread.c: Fix some typos.
4843
4844 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4845             Tom Tromey  <tromey@adacore.com>
4846
4847         * ada-lang.c (ada_exception_sal): Change addr_string to a
4848         std::string.
4849         (create_ada_exception_catchpoint): Update.
4850
4851 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4852             Tom Tromey  <tromey@adacore.com>
4853
4854         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4855         (bp_location_ops): Remove.
4856         (base_breakpoint_allocate_location): Update.
4857         (free_bp_location): Update.
4858         * ada-lang.c (class ada_catchpoint_location)
4859         <ada_catchpoint_location>: Remove ops parameter.
4860         (ada_catchpoint_location_dtor): Remove.
4861         (ada_catchpoint_location_ops): Remove.
4862         (allocate_location_exception): Update.
4863         * breakpoint.h (struct bp_location_ops): Remove.
4864         (class bp_location) <bp_location>: Remove bp_location_ops
4865         parameter.
4866         <~bp_location>: Add destructor.
4867         <ops>: Remove.
4868
4869 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4870             Pedro Alves  <palves@redhat.com>
4871
4872         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4873         'PATH_MAX'.
4874
4875 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4876             Samuel Thibault  <samuel.thibault@gnu.org>
4877             Thomas Schwinge  <thomas@codesourcery.com>
4878
4879         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4880         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4881
4882 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4883
4884         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4885         (check_empty): Use "const char *".
4886
4887         * gnu-nat.c (gnu_nat_target::detach): Instead of
4888         'detach_inferior (pid)' call
4889         'detach_inferior (find_inferior_pid (pid))'.
4890
4891         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4892         'nat/fork-inferior.o'.
4893         * gnu-nat.c: #include "nat/fork-inferior.h".
4894
4895         * gnu-nat.c (gnu_nat_target::detach): Instead of
4896         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4897         * gnu-nat.h: #include "inf-child.h".
4898         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4899         'i386_gnu_nat_target::fetch_registers'.
4900         (gnu_store_registers): Rename/move to
4901         'i386_gnu_nat_target::store_registers'.
4902
4903         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4904         * gnu-nat.h (mach_thread_info): New function.
4905         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4906
4907         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4908
4909 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4910
4911         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4912
4913 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4914
4915         * windows-nat.c (windows_add_thread): Add new parameter
4916         "main_thread_p" with default value set to false.  Update
4917         function documentation as well as all callers.
4918         (windows_delete_thread): Likewise.
4919         (fake_create_process): Update call to windows_add_thread.
4920         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4921         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4922         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4923         call to windows_delete_thread.
4924
4925 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4926
4927         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4928
4929 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4930
4931         * symfile.c (find_separate_debug_file): Use canonical path of
4932         sysroot with child_path instead of gdb_sysroot if it is valid.
4933
4934 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4935
4936         * symfile.c (find_separate_debug_file): Use child_path to
4937         determine if an object file is under a sysroot.
4938
4939 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4940
4941         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4942         unittests/child-path-selftests.c.
4943         * common/pathstuff.c (child_path): New function.
4944         * common/pathstuff.h (child_path): New prototype.
4945         * unittests/child-path-selftests.c: New file.
4946
4947 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4948
4949         * symfile.c (find_separate_debug_file): Look for separate debug
4950         files in debug directories under the sysroot.
4951
4952 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4953
4954         * symtab.h (struct minimal_symbol data_p): New const method.
4955         (struct minimal_symbol text_p): Likewise.
4956         * symtab.c (output_source_filename): Use file name style
4957         to print file name.
4958         (print_symbol_info): Likewise.
4959         (print_msymbol_info): Use address style to print addresses.
4960         Use function name style to print executable text symbols.
4961         (expand_symtab_containing_pc): Use data_p.
4962         (find_pc_sect_compunit_symtab): Likewise.
4963
4964 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4965
4966         * breakpoint.c (describe_other_breakpoints): Use address style
4967         to print addresses.
4968         (say_where): Likewise.
4969
4970 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4971
4972         * ada-typeprint.c (print_func_type): Print function name
4973         style to print function name.
4974         * c-typeprint.c (c_print_type_1): Likewise.
4975
4976 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4977
4978         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4979         for execve.
4980
4981 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4982
4983         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4984         type_stack.
4985
4986 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4987
4988         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4989         TYPE_CODE_REF types.
4990
4991 2019-02-08  Jim Wilson  <jimw@sifive.com>
4992
4993         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4994         (riscv_linux_fregset): New.
4995         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4996
4997 2019-02-07  Tom Tromey  <tom@tromey.com>
4998
4999         * thread.c (thread_cancel_execution_command): Update.
5000         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
5001         methods.
5002         (struct thread_fsm_ops): Remove.
5003         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
5004         (thread_fsm_should_stop, thread_fsm_return_value)
5005         (thread_fsm_set_finished, thread_fsm_finished_p)
5006         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
5007         Don't declare.
5008         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
5009         * infrun.c (clear_proceed_status_thread)
5010         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
5011         (print_stop_event): Update.
5012         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
5013         Add constructor.
5014         (step_command_fsm_ops): Remove.
5015         (new_step_command_fsm): Remove.
5016         (step_1): Update.
5017         (step_command_fsm::should_stop): Rename from
5018         step_command_fsm_should_stop.
5019         (step_command_fsm::clean_up): Rename from
5020         step_command_fsm_clean_up.
5021         (step_command_fsm::do_async_reply_reason): Rename from
5022         step_command_fsm_async_reply_reason.
5023         (struct until_next_fsm): Inherit from thread_fsm.  Add
5024         constructor.
5025         (until_next_fsm_ops): Remove.
5026         (new_until_next_fsm): Remove.
5027         (until_next_fsm::should_stop): Rename from
5028         until_next_fsm_should_stop.
5029         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
5030         (until_next_fsm::do_async_reply_reason): Rename from
5031         until_next_fsm_async_reply_reason.
5032         (struct finish_command_fsm): Inherit from thread_fsm.  Add
5033         constructor.  Change type of breakpoint.
5034         (finish_command_fsm_ops): Remove.
5035         (new_finish_command_fsm): Remove.
5036         (finish_command_fsm::should_stop): Rename from
5037         finish_command_fsm_should_stop.
5038         (finish_command_fsm::clean_up): Rename from
5039         finish_command_fsm_clean_up.
5040         (finish_command_fsm::return_value): Rename from
5041         finish_command_fsm_return_value.
5042         (finish_command_fsm::do_async_reply_reason): Rename from
5043         finish_command_fsm_async_reply_reason.
5044         (finish_command): Update.
5045         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
5046         Add constructor.
5047         (call_thread_fsm_ops): Remove.
5048         (call_thread_fsm::call_thread_fsm): Rename from
5049         new_call_thread_fsm.
5050         (call_thread_fsm::should_stop): Rename from
5051         call_thread_fsm_should_stop.
5052         (call_thread_fsm::should_notify_stop): Rename from
5053         call_thread_fsm_should_notify_stop.
5054         (run_inferior_call, call_function_by_hand_dummy): Update.
5055         * cli/cli-interp.c (should_print_stop_to_console): Update.
5056         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
5057         Add constructor.  Change type of location_breakpoint,
5058         caller_breakpoint.
5059         (until_break_fsm_ops): Remove.
5060         (new_until_break_fsm): Remove.
5061         (until_break_fsm::should_stop): Rename from
5062         until_break_fsm_should_stop.
5063         (until_break_fsm::clean_up): Rename from
5064         until_break_fsm_clean_up.
5065         (until_break_fsm::do_async_reply_reason): Rename from
5066         until_break_fsm_async_reply_reason.
5067         (until_break_command): Update.
5068         * thread-fsm.c: Remove.
5069         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
5070
5071 2019-02-07  Tom Tromey  <tom@tromey.com>
5072
5073         * yy-remap.h: Add include guard.
5074         * xtensa-tdep.h: Add include guard.
5075         * xcoffread.h: Rename include guard.
5076         * varobj-iter.h: Add include guard.
5077         * tui/tui.h: Rename include guard.
5078         * tui/tui-winsource.h: Rename include guard.
5079         * tui/tui-wingeneral.h: Rename include guard.
5080         * tui/tui-windata.h: Rename include guard.
5081         * tui/tui-win.h: Rename include guard.
5082         * tui/tui-stack.h: Rename include guard.
5083         * tui/tui-source.h: Rename include guard.
5084         * tui/tui-regs.h: Rename include guard.
5085         * tui/tui-out.h: Rename include guard.
5086         * tui/tui-layout.h: Rename include guard.
5087         * tui/tui-io.h: Rename include guard.
5088         * tui/tui-hooks.h: Rename include guard.
5089         * tui/tui-file.h: Rename include guard.
5090         * tui/tui-disasm.h: Rename include guard.
5091         * tui/tui-data.h: Rename include guard.
5092         * tui/tui-command.h: Rename include guard.
5093         * tic6x-tdep.h: Add include guard.
5094         * target/waitstatus.h: Rename include guard.
5095         * target/wait.h: Rename include guard.
5096         * target/target.h: Rename include guard.
5097         * target/resume.h: Rename include guard.
5098         * target-float.h: Rename include guard.
5099         * stabsread.h: Add include guard.
5100         * rs6000-tdep.h: Add include guard.
5101         * riscv-fbsd-tdep.h: Add include guard.
5102         * regformats/regdef.h: Rename include guard.
5103         * record.h: Rename include guard.
5104         * python/python.h: Rename include guard.
5105         * python/python-internal.h: Rename include guard.
5106         * python/py-stopevent.h: Rename include guard.
5107         * python/py-ref.h: Rename include guard.
5108         * python/py-record.h: Rename include guard.
5109         * python/py-record-full.h: Rename include guard.
5110         * python/py-record-btrace.h: Rename include guard.
5111         * python/py-instruction.h: Rename include guard.
5112         * python/py-events.h: Rename include guard.
5113         * python/py-event.h: Rename include guard.
5114         * procfs.h: Add include guard.
5115         * proc-utils.h: Add include guard.
5116         * p-lang.h: Add include guard.
5117         * or1k-tdep.h: Rename include guard.
5118         * observable.h: Rename include guard.
5119         * nto-tdep.h: Rename include guard.
5120         * nat/x86-linux.h: Rename include guard.
5121         * nat/x86-linux-dregs.h: Rename include guard.
5122         * nat/x86-gcc-cpuid.h: Add include guard.
5123         * nat/x86-dregs.h: Rename include guard.
5124         * nat/x86-cpuid.h: Rename include guard.
5125         * nat/ppc-linux.h: Rename include guard.
5126         * nat/mips-linux-watch.h: Rename include guard.
5127         * nat/linux-waitpid.h: Rename include guard.
5128         * nat/linux-ptrace.h: Rename include guard.
5129         * nat/linux-procfs.h: Rename include guard.
5130         * nat/linux-osdata.h: Rename include guard.
5131         * nat/linux-nat.h: Rename include guard.
5132         * nat/linux-namespaces.h: Rename include guard.
5133         * nat/linux-btrace.h: Rename include guard.
5134         * nat/glibc_thread_db.h: Rename include guard.
5135         * nat/gdb_thread_db.h: Rename include guard.
5136         * nat/gdb_ptrace.h: Rename include guard.
5137         * nat/fork-inferior.h: Rename include guard.
5138         * nat/amd64-linux-siginfo.h: Rename include guard.
5139         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
5140         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
5141         * nat/aarch64-linux.h: Rename include guard.
5142         * nat/aarch64-linux-hw-point.h: Rename include guard.
5143         * mn10300-tdep.h: Add include guard.
5144         * mips-linux-tdep.h: Add include guard.
5145         * mi/mi-parse.h: Rename include guard.
5146         * mi/mi-out.h: Rename include guard.
5147         * mi/mi-main.h: Rename include guard.
5148         * mi/mi-interp.h: Rename include guard.
5149         * mi/mi-getopt.h: Rename include guard.
5150         * mi/mi-console.h: Rename include guard.
5151         * mi/mi-common.h: Rename include guard.
5152         * mi/mi-cmds.h: Rename include guard.
5153         * mi/mi-cmd-break.h: Rename include guard.
5154         * m2-lang.h: Add include guard.
5155         * location.h: Rename include guard.
5156         * linux-record.h: Rename include guard.
5157         * linux-nat.h: Add include guard.
5158         * linux-fork.h: Add include guard.
5159         * i386-darwin-tdep.h: Rename include guard.
5160         * hppa-linux-offsets.h: Add include guard.
5161         * guile/guile.h: Rename include guard.
5162         * guile/guile-internal.h: Rename include guard.
5163         * gnu-nat.h: Rename include guard.
5164         * gdb-stabs.h: Rename include guard.
5165         * frv-tdep.h: Add include guard.
5166         * f-lang.h: Add include guard.
5167         * event-loop.h: Add include guard.
5168         * darwin-nat.h: Rename include guard.
5169         * cp-abi.h: Rename include guard.
5170         * config/sparc/nm-sol2.h: Rename include guard.
5171         * config/nm-nto.h: Rename include guard.
5172         * config/nm-linux.h: Add include guard.
5173         * config/i386/nm-i386gnu.h: Rename include guard.
5174         * config/djgpp/nl_types.h: Rename include guard.
5175         * config/djgpp/langinfo.h: Rename include guard.
5176         * compile/gcc-cp-plugin.h: Add include guard.
5177         * compile/gcc-c-plugin.h: Add include guard.
5178         * compile/compile.h: Rename include guard.
5179         * compile/compile-object-run.h: Rename include guard.
5180         * compile/compile-object-load.h: Rename include guard.
5181         * compile/compile-internal.h: Rename include guard.
5182         * compile/compile-cplus.h: Rename include guard.
5183         * compile/compile-c.h: Rename include guard.
5184         * common/xml-utils.h: Rename include guard.
5185         * common/x86-xstate.h: Rename include guard.
5186         * common/version.h: Rename include guard.
5187         * common/vec.h: Rename include guard.
5188         * common/tdesc.h: Rename include guard.
5189         * common/selftest.h: Rename include guard.
5190         * common/scoped_restore.h: Rename include guard.
5191         * common/scoped_mmap.h: Rename include guard.
5192         * common/scoped_fd.h: Rename include guard.
5193         * common/safe-iterator.h: Rename include guard.
5194         * common/run-time-clock.h: Rename include guard.
5195         * common/refcounted-object.h: Rename include guard.
5196         * common/queue.h: Rename include guard.
5197         * common/ptid.h: Rename include guard.
5198         * common/print-utils.h: Rename include guard.
5199         * common/preprocessor.h: Rename include guard.
5200         * common/pathstuff.h: Rename include guard.
5201         * common/observable.h: Rename include guard.
5202         * common/netstuff.h: Rename include guard.
5203         * common/job-control.h: Rename include guard.
5204         * common/host-defs.h: Rename include guard.
5205         * common/gdb_wait.h: Rename include guard.
5206         * common/gdb_vecs.h: Rename include guard.
5207         * common/gdb_unlinker.h: Rename include guard.
5208         * common/gdb_unique_ptr.h: Rename include guard.
5209         * common/gdb_tilde_expand.h: Rename include guard.
5210         * common/gdb_sys_time.h: Rename include guard.
5211         * common/gdb_string_view.h: Rename include guard.
5212         * common/gdb_splay_tree.h: Rename include guard.
5213         * common/gdb_setjmp.h: Rename include guard.
5214         * common/gdb_ref_ptr.h: Rename include guard.
5215         * common/gdb_optional.h: Rename include guard.
5216         * common/gdb_locale.h: Rename include guard.
5217         * common/gdb_assert.h: Rename include guard.
5218         * common/filtered-iterator.h: Rename include guard.
5219         * common/filestuff.h: Rename include guard.
5220         * common/fileio.h: Rename include guard.
5221         * common/environ.h: Rename include guard.
5222         * common/common-utils.h: Rename include guard.
5223         * common/common-types.h: Rename include guard.
5224         * common/common-regcache.h: Rename include guard.
5225         * common/common-inferior.h: Rename include guard.
5226         * common/common-gdbthread.h: Rename include guard.
5227         * common/common-exceptions.h: Rename include guard.
5228         * common/common-defs.h: Rename include guard.
5229         * common/common-debug.h: Rename include guard.
5230         * common/cleanups.h: Rename include guard.
5231         * common/buffer.h: Rename include guard.
5232         * common/btrace-common.h: Rename include guard.
5233         * common/break-common.h: Rename include guard.
5234         * cli/cli-utils.h: Rename include guard.
5235         * cli/cli-style.h: Rename include guard.
5236         * cli/cli-setshow.h: Rename include guard.
5237         * cli/cli-script.h: Rename include guard.
5238         * cli/cli-interp.h: Rename include guard.
5239         * cli/cli-decode.h: Rename include guard.
5240         * cli/cli-cmds.h: Rename include guard.
5241         * charset-list.h: Add include guard.
5242         * buildsym-legacy.h: Rename include guard.
5243         * bfin-tdep.h: Add include guard.
5244         * ax.h: Rename include guard.
5245         * arm-linux-tdep.h: Add include guard.
5246         * arm-fbsd-tdep.h: Add include guard.
5247         * arch/xtensa.h: Rename include guard.
5248         * arch/tic6x.h: Add include guard.
5249         * arch/i386.h: Add include guard.
5250         * arch/arm.h: Rename include guard.
5251         * arch/arm-linux.h: Rename include guard.
5252         * arch/arm-get-next-pcs.h: Rename include guard.
5253         * arch/amd64.h: Add include guard.
5254         * arch/aarch64-insn.h: Rename include guard.
5255         * arch-utils.h: Rename include guard.
5256         * annotate.h: Add include guard.
5257         * amd64-darwin-tdep.h: Rename include guard.
5258         * aarch64-linux-tdep.h: Add include guard.
5259         * aarch64-fbsd-tdep.h: Add include guard.
5260         * aarch32-linux-nat.h: Add include guard.
5261
5262 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5263
5264         * macrotab.c (macro_define_internal): New function that
5265         factorizes macro_define_object_internal and macro_define_function
5266         code.
5267         (macro_define_object_internal): Use macro_define_internal.
5268         (macro_define_function): Likewise.
5269
5270 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5271
5272         * macrocmd.c (extract_identifier): Return
5273         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5274         callers.
5275
5276 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5277
5278         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5279
5280 2019-02-05  Tom Tromey  <tom@tromey.com>
5281
5282         * target.c (target_stack::unpush): Move assertion earlier.
5283
5284 2019-01-30  Tom Tromey  <tom@tromey.com>
5285
5286         PR python/23615:
5287         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5288         (gdbpy_parse_and_eval): Likewise.
5289         * python/python-internal.h (gdbpy_allow_threads): New class.
5290
5291 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5292
5293         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5294         (aarch64_fbsd_fpregmap): Move earlier.
5295         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5296         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5297         instead of individual calls to trad_frame_set_reg_addr.
5298         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5299         earlier.
5300         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5301         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5302         instead of individual calls to trad_frame_set_reg_addr.
5303
5304 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5305
5306         * CONTRIBUTE: Replace contribution list with wiki link.
5307
5308 2019-01-25  Tom Tromey  <tom@tromey.com>
5309
5310         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5311
5312 2019-01-25  Tom Tromey  <tom@tromey.com>
5313
5314         * xtensa-linux-nat.c: Fix common/ includes.
5315         * xml-support.h: Fix common/ includes.
5316         * xml-support.c: Fix common/ includes.
5317         * x86-linux-nat.c: Fix common/ includes.
5318         * windows-nat.c: Fix common/ includes.
5319         * varobj.h: Fix common/ includes.
5320         * varobj.c: Fix common/ includes.
5321         * value.c: Fix common/ includes.
5322         * valops.c: Fix common/ includes.
5323         * utils.c: Fix common/ includes.
5324         * unittests/xml-utils-selftests.c: Fix common/ includes.
5325         * unittests/utils-selftests.c: Fix common/ includes.
5326         * unittests/unpack-selftests.c: Fix common/ includes.
5327         * unittests/tracepoint-selftests.c: Fix common/ includes.
5328         * unittests/style-selftests.c: Fix common/ includes.
5329         * unittests/string_view-selftests.c: Fix common/ includes.
5330         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5331         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5332         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5333         * unittests/rsp-low-selftests.c: Fix common/ includes.
5334         * unittests/parse-connection-spec-selftests.c: Fix common/
5335         includes.
5336         * unittests/optional-selftests.c: Fix common/ includes.
5337         * unittests/offset-type-selftests.c: Fix common/ includes.
5338         * unittests/observable-selftests.c: Fix common/ includes.
5339         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5340         * unittests/memrange-selftests.c: Fix common/ includes.
5341         * unittests/memory-map-selftests.c: Fix common/ includes.
5342         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5343         * unittests/function-view-selftests.c: Fix common/ includes.
5344         * unittests/environ-selftests.c: Fix common/ includes.
5345         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5346         * unittests/common-utils-selftests.c: Fix common/ includes.
5347         * unittests/cli-utils-selftests.c: Fix common/ includes.
5348         * unittests/array-view-selftests.c: Fix common/ includes.
5349         * ui-file.c: Fix common/ includes.
5350         * tui/tui-io.c: Fix common/ includes.
5351         * tracepoint.h: Fix common/ includes.
5352         * tracepoint.c: Fix common/ includes.
5353         * tracefile-tfile.c: Fix common/ includes.
5354         * top.h: Fix common/ includes.
5355         * top.c: Fix common/ includes.
5356         * thread.c: Fix common/ includes.
5357         * target/waitstatus.h: Fix common/ includes.
5358         * target/waitstatus.c: Fix common/ includes.
5359         * target.h: Fix common/ includes.
5360         * target.c: Fix common/ includes.
5361         * target-memory.c: Fix common/ includes.
5362         * target-descriptions.c: Fix common/ includes.
5363         * symtab.h: Fix common/ includes.
5364         * symfile.c: Fix common/ includes.
5365         * stap-probe.c: Fix common/ includes.
5366         * spu-linux-nat.c: Fix common/ includes.
5367         * sparc-nat.c: Fix common/ includes.
5368         * source.c: Fix common/ includes.
5369         * solib.c: Fix common/ includes.
5370         * solib-target.c: Fix common/ includes.
5371         * ser-unix.c: Fix common/ includes.
5372         * ser-tcp.c: Fix common/ includes.
5373         * ser-pipe.c: Fix common/ includes.
5374         * ser-base.c: Fix common/ includes.
5375         * selftest-arch.c: Fix common/ includes.
5376         * s12z-tdep.c: Fix common/ includes.
5377         * rust-exp.y: Fix common/ includes.
5378         * rs6000-aix-tdep.c: Fix common/ includes.
5379         * riscv-tdep.c: Fix common/ includes.
5380         * remote.c: Fix common/ includes.
5381         * remote-notif.h: Fix common/ includes.
5382         * remote-fileio.h: Fix common/ includes.
5383         * remote-fileio.c: Fix common/ includes.
5384         * regcache.h: Fix common/ includes.
5385         * regcache.c: Fix common/ includes.
5386         * record-btrace.c: Fix common/ includes.
5387         * python/python.c: Fix common/ includes.
5388         * python/py-type.c: Fix common/ includes.
5389         * python/py-inferior.c: Fix common/ includes.
5390         * progspace.h: Fix common/ includes.
5391         * producer.c: Fix common/ includes.
5392         * procfs.c: Fix common/ includes.
5393         * proc-api.c: Fix common/ includes.
5394         * printcmd.c: Fix common/ includes.
5395         * ppc-linux-nat.c: Fix common/ includes.
5396         * parser-defs.h: Fix common/ includes.
5397         * osdata.c: Fix common/ includes.
5398         * obsd-nat.c: Fix common/ includes.
5399         * nat/x86-linux.c: Fix common/ includes.
5400         * nat/x86-linux-dregs.c: Fix common/ includes.
5401         * nat/x86-dregs.h: Fix common/ includes.
5402         * nat/x86-dregs.c: Fix common/ includes.
5403         * nat/ppc-linux.c: Fix common/ includes.
5404         * nat/mips-linux-watch.h: Fix common/ includes.
5405         * nat/mips-linux-watch.c: Fix common/ includes.
5406         * nat/linux-waitpid.c: Fix common/ includes.
5407         * nat/linux-ptrace.h: Fix common/ includes.
5408         * nat/linux-ptrace.c: Fix common/ includes.
5409         * nat/linux-procfs.c: Fix common/ includes.
5410         * nat/linux-personality.c: Fix common/ includes.
5411         * nat/linux-osdata.c: Fix common/ includes.
5412         * nat/linux-namespaces.c: Fix common/ includes.
5413         * nat/linux-btrace.h: Fix common/ includes.
5414         * nat/linux-btrace.c: Fix common/ includes.
5415         * nat/fork-inferior.c: Fix common/ includes.
5416         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5417         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5418         * nat/aarch64-linux.c: Fix common/ includes.
5419         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5420         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5421         * namespace.h: Fix common/ includes.
5422         * mips-linux-tdep.c: Fix common/ includes.
5423         * minsyms.c: Fix common/ includes.
5424         * mi/mi-parse.h: Fix common/ includes.
5425         * mi/mi-main.c: Fix common/ includes.
5426         * mi/mi-cmd-env.c: Fix common/ includes.
5427         * memrange.h: Fix common/ includes.
5428         * memattr.c: Fix common/ includes.
5429         * maint.h: Fix common/ includes.
5430         * maint.c: Fix common/ includes.
5431         * main.c: Fix common/ includes.
5432         * machoread.c: Fix common/ includes.
5433         * location.c: Fix common/ includes.
5434         * linux-thread-db.c: Fix common/ includes.
5435         * linux-nat.c: Fix common/ includes.
5436         * linux-fork.c: Fix common/ includes.
5437         * inline-frame.c: Fix common/ includes.
5438         * infrun.c: Fix common/ includes.
5439         * inflow.c: Fix common/ includes.
5440         * inferior.h: Fix common/ includes.
5441         * inferior.c: Fix common/ includes.
5442         * infcmd.c: Fix common/ includes.
5443         * inf-ptrace.c: Fix common/ includes.
5444         * inf-child.c: Fix common/ includes.
5445         * ia64-linux-nat.c: Fix common/ includes.
5446         * i387-tdep.c: Fix common/ includes.
5447         * i386-tdep.c: Fix common/ includes.
5448         * i386-linux-tdep.c: Fix common/ includes.
5449         * i386-linux-nat.c: Fix common/ includes.
5450         * i386-go32-tdep.c: Fix common/ includes.
5451         * i386-fbsd-tdep.c: Fix common/ includes.
5452         * i386-fbsd-nat.c: Fix common/ includes.
5453         * guile/scm-type.c: Fix common/ includes.
5454         * guile/guile.c: Fix common/ includes.
5455         * go32-nat.c: Fix common/ includes.
5456         * gnu-nat.c: Fix common/ includes.
5457         * gdbthread.h: Fix common/ includes.
5458         * gdbarch-selftests.c: Fix common/ includes.
5459         * gdb_usleep.c: Fix common/ includes.
5460         * gdb_select.h: Fix common/ includes.
5461         * gdb_bfd.c: Fix common/ includes.
5462         * gcore.c: Fix common/ includes.
5463         * fork-child.c: Fix common/ includes.
5464         * findvar.c: Fix common/ includes.
5465         * fbsd-nat.c: Fix common/ includes.
5466         * event-top.c: Fix common/ includes.
5467         * event-loop.c: Fix common/ includes.
5468         * dwarf2read.c: Fix common/ includes.
5469         * dwarf2loc.c: Fix common/ includes.
5470         * dwarf2-frame.c: Fix common/ includes.
5471         * dwarf-index-cache.c: Fix common/ includes.
5472         * dtrace-probe.c: Fix common/ includes.
5473         * disasm-selftests.c: Fix common/ includes.
5474         * defs.h: Fix common/ includes.
5475         * csky-tdep.c: Fix common/ includes.
5476         * cp-valprint.c: Fix common/ includes.
5477         * cp-support.h: Fix common/ includes.
5478         * cp-support.c: Fix common/ includes.
5479         * corelow.c: Fix common/ includes.
5480         * completer.h: Fix common/ includes.
5481         * completer.c: Fix common/ includes.
5482         * compile/compile.c: Fix common/ includes.
5483         * compile/compile-loc2c.c: Fix common/ includes.
5484         * compile/compile-cplus-types.c: Fix common/ includes.
5485         * compile/compile-cplus-symbols.c: Fix common/ includes.
5486         * command.h: Fix common/ includes.
5487         * cli/cli-dump.c: Fix common/ includes.
5488         * cli/cli-cmds.c: Fix common/ includes.
5489         * charset.c: Fix common/ includes.
5490         * build-id.c: Fix common/ includes.
5491         * btrace.h: Fix common/ includes.
5492         * btrace.c: Fix common/ includes.
5493         * breakpoint.h: Fix common/ includes.
5494         * breakpoint.c: Fix common/ includes.
5495         * ax.h:
5496         (enum agent_op): Fix common/ includes.
5497         * ax-general.c (struct aop_map): Fix common/ includes.
5498         * ax-gdb.c: Fix common/ includes.
5499         * auxv.c: Fix common/ includes.
5500         * auto-load.c: Fix common/ includes.
5501         * arm-tdep.c: Fix common/ includes.
5502         * arch/riscv.c: Fix common/ includes.
5503         * arch/ppc-linux-common.c: Fix common/ includes.
5504         * arch/i386.c: Fix common/ includes.
5505         * arch/arm.c: Fix common/ includes.
5506         * arch/arm-linux.c: Fix common/ includes.
5507         * arch/arm-get-next-pcs.c: Fix common/ includes.
5508         * arch/amd64.c: Fix common/ includes.
5509         * arch/aarch64.c: Fix common/ includes.
5510         * arch/aarch64-insn.c: Fix common/ includes.
5511         * arch-utils.c: Fix common/ includes.
5512         * amd64-windows-tdep.c: Fix common/ includes.
5513         * amd64-tdep.c: Fix common/ includes.
5514         * amd64-sol2-tdep.c: Fix common/ includes.
5515         * amd64-obsd-tdep.c: Fix common/ includes.
5516         * amd64-nbsd-tdep.c: Fix common/ includes.
5517         * amd64-linux-tdep.c: Fix common/ includes.
5518         * amd64-linux-nat.c: Fix common/ includes.
5519         * amd64-fbsd-tdep.c: Fix common/ includes.
5520         * amd64-fbsd-nat.c: Fix common/ includes.
5521         * amd64-dicos-tdep.c: Fix common/ includes.
5522         * amd64-darwin-tdep.c: Fix common/ includes.
5523         * agent.c: Fix common/ includes.
5524         * ada-lang.h: Fix common/ includes.
5525         * ada-lang.c: Fix common/ includes.
5526         * aarch64-tdep.c: Fix common/ includes.
5527
5528 2019-01-25  Tom Tromey  <tom@tromey.com>
5529
5530         * common/create-version.sh: Use common/version.h.
5531
5532 2019-01-24  Pedro Alves  <palves@redhat.com>
5533
5534         * infrun.c (signal_stop, signal_print, signal_program)
5535         (signal_catch, signal_pass): Now arrays instead of pointers.
5536         (update_signals_program_target, do_target_resume)
5537         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5538         * linux-nat.c (linux_nat_target::pass_signals)
5539         (linux_nat_target::create_inferior, linux_nat_target::attach):
5540         Adjust.
5541         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5542         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5543         * procfs.c (procfs_target::pass_signals): Adjust.
5544         * record-full.c (record_full_target::resume): Adjust.
5545         * remote.c (remote_target::pass_signals)
5546         (remote_target::program_signals): Adjust.
5547         * target-debug.h (target_debug_print_signals): Now takes a
5548         gdb::array_view as parameter.  Adjust.
5549         * target.h (target_ops) <pass_signals, program_signals>: Replace
5550         pointer and length parameters with gdb::array_view.
5551         (target_pass_signals, target_program_signals): Likewise.
5552         * target-delegates.c: Regenerate.
5553
5554 2019-01-24  Pedro Alves  <palves@redhat.com>
5555
5556         * common/forward-scope-exit.h
5557         (forward_scope_exit::forward_scope_exit): Pass arguments to
5558         m_bind_function directly, instead of creating a std::bind and
5559         copying that.
5560
5561 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5562
5563         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5564         for static members.
5565         (pass_in_v_vfp_candidate): Likewise.
5566
5567 2019-01-23  Tom Tromey  <tom@tromey.com>
5568             Pedro Alves  <palves@redhat.com>
5569
5570         * regcache.c (class regcache_invalidator): Remove.
5571         (regcache::raw_write): Use make_scope_exit.
5572
5573 2019-01-23  Tom Tromey  <tom@tromey.com>
5574
5575         * ui-out.h (class ui_out_emit_type): Update comment.
5576
5577 2019-01-23  Tom Tromey  <tom@tromey.com>
5578
5579         * infrun.c (fetch_inferior_event): Update comment.
5580
5581 2019-01-23  Tom Tromey  <tom@tromey.com>
5582             Pedro Alves  <palves@redhat.com>
5583
5584         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5585         parameter.
5586         (fetch_inferior_event): Use SCOPE_EXIT.
5587
5588
5589 2019-01-23  Tom Tromey  <tom@tromey.com>
5590             Pedro Alves  <palves@redhat.com>
5591
5592         * infrun.c (disable_thread_events): Delete.
5593         (stop_all_threads): Use SCOPE_EXIT.
5594
5595 2019-01-23  Tom Tromey  <tom@tromey.com>
5596             Pedro Alves  <palves@redhat.com>
5597
5598         * symfile.c: Include forward-scope-exit.h.
5599         (clear_symtab_users_cleanup): Replace forward declaration with
5600         a FORWARD_SCOPE_EXIT.
5601         (syms_from_objfile_1): Use the forward_scope_exit and
5602         gdb::optional instead of cleanup_function.
5603         (reread_symbols): Use the forward_scope_exit instead of
5604         cleanup_function.
5605         (clear_symtab_users_cleanup): Remove function.
5606
5607 2019-01-23  Tom Tromey  <tom@tromey.com>
5608             Pedro Alves  <palves@redhat.com>
5609
5610         * linux-nat.c: Include scope-exit.h.
5611         (cleanup_target_stop): Remove.
5612         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5613         SCOPE_EXIT.
5614
5615 2019-01-23  Tom Tromey  <tom@tromey.com>
5616             Pedro Alves  <palves@redhat.com>
5617
5618         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5619         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5620
5621 2019-01-23  Tom Tromey  <tom@tromey.com>
5622             Andrew Burgess  <andrew.burgess@embecosm.com>
5623             Pedro Alves  <palves@redhat.com>
5624
5625         * infrun.c (fetch_inferior_event): Use scope_exit.
5626         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5627         * top.c (execute_command): Use scope_exit.
5628         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5629         * utils.c (do_bpstat_clear_actions_cleanup)
5630         (make_bpstat_clear_actions_cleanup): Remove.
5631
5632 2019-01-23  Tom Tromey  <tom@tromey.com>
5633             Pedro Alves  <palves@redhat.com>
5634
5635         * infrun.c: Include "common/scope-exit.h"
5636         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5637         (wait_for_inferior): Use SCOPE_EXIT.
5638         (fetch_inferior_event): Use scope_exit.
5639
5640 2019-01-23  Tom Tromey  <tom@tromey.com>
5641             Pedro Alves  <palves@redhat.com>
5642
5643         * breakpoint.c (create_breakpoint): Remove cleanup.
5644
5645 2019-01-23  Tom Tromey  <tom@tromey.com>
5646             Andrew Burgess  <andrew.burgess@embecosm.com>
5647             Pedro Alves  <palves@redhat.com>
5648
5649 2019-01-23  Pedro Alves  <palves@redhat.com>
5650
5651         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5652
5653 2019-01-23  Pedro Alves  <palves@redhat.com>
5654             Andrew Burgess  <andrew.burgess@embecosm.com>
5655
5656         * gdbthread.h: Include "common/forward-scope-exit.h".
5657         (scoped_finish_thread_state): Redefine custom class in terms of
5658         forward_scope_exit.
5659
5660 2019-01-23  Pedro Alves  <palves@redhat.com>
5661             Andrew Burgess  <andrew.burgess@embecosm.com>
5662
5663         * common/forward-scope-exit.h: New file.
5664
5665 2019-01-23  Pedro Alves  <palves@redhat.com>
5666             Andrew Burgess  <andrew.burgess@embecosm.com>
5667             Tom Tromey  <tom@tromey.com>
5668
5669         * common/scope-exit.h: New file.
5670
5671 2019-01-23  Pedro Alves  <palves@redhat.com>
5672
5673         * common/preprocessor.h (ESC): Rename to ...
5674         (ESC_PARENS): ... this.
5675         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5676         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5677
5678 2019-01-23  Tom Tromey  <tom@tromey.com>
5679
5680         * language.h (class scoped_switch_to_sym_language_if_auto):
5681         Initialize m_lang in both cases.
5682
5683 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5684
5685         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5686         with XCNEW.
5687
5688 2019-01-22  Tom Tromey  <tom@tromey.com>
5689
5690         * corelow.c: Do not include sys/file.h.
5691
5692 2019-01-22  Tom Tromey  <tom@tromey.com>
5693
5694         * tui/tui-wingeneral.h: Include gdb_curses.h.
5695
5696 2019-01-22  Tom Tromey  <tom@tromey.com>
5697
5698         * source-cache.h (class source_cache) <get_source_lines,
5699         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5700
5701 2019-01-22  Tom Tromey  <tom@tromey.com>
5702
5703         * remote-fileio.h (struct remote_target): Declare.
5704
5705 2019-01-22  Tom Tromey  <tom@tromey.com>
5706
5707         * python/py-arch.c: Do not include py-ref.h.
5708         * python/py-bpevent.c: Do not include py-ref.h.
5709         * python/py-cmd.c: Do not include py-ref.h.
5710         * python/py-continueevent.c: Do not include py-ref.h.
5711         * python/py-event.h: Do not include py-ref.h.
5712         * python/py-evtregistry.c: Do not include py-ref.h.
5713         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5714         * python/py-frame.c: Do not include py-ref.h.
5715         * python/py-framefilter.c: Do not include py-ref.h.
5716         * python/py-function.c: Do not include py-ref.h.
5717         * python/py-infevents.c: Do not include py-ref.h.
5718         * python/py-linetable.c: Do not include py-ref.h.
5719         * python/py-objfile.c: Do not include py-ref.h.
5720         * python/py-param.c: Do not include py-ref.h.
5721         * python/py-prettyprint.c: Do not include py-ref.h.
5722         * python/py-progspace.c: Do not include py-ref.h.
5723         * python/py-symbol.c: Do not include py-ref.h.
5724         * python/py-symtab.c: Do not include py-ref.h.
5725         * python/py-type.c: Do not include py-ref.h.
5726         * python/py-unwind.c: Do not include py-ref.h.
5727         * python/py-utils.c: Do not include py-ref.h.
5728         * python/py-value.c: Do not include py-ref.h.
5729         * python/py-varobj.c: Do not include py-ref.h.
5730         * python/py-xmethods.c: Do not include py-ref.h.
5731         * python/python.c: Do not include py-ref.h.
5732         * varobj.c: Do not include py-ref.h.
5733
5734 2019-01-22  Tom Tromey  <tom@tromey.com>
5735
5736         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5737         keyword for bcache.
5738
5739 2019-01-22  Tom Tromey  <tom@tromey.com>
5740
5741         * compile/compile-cplus-types.c: Remove a comment by #include.
5742
5743 2019-01-22  Tom Tromey  <tom@tromey.com>
5744
5745         * compile/gcc-c-plugin.h: Include compile-internal.h.
5746
5747 2019-01-22  Tom Tromey  <tom@tromey.com>
5748
5749         * stabsread.c (EXTERN): Do not define.
5750         (symnum, next_symbol_text_func, processing_gcc_compilation)
5751         (within_function, global_sym_chain, global_stabs)
5752         (previous_stab_code, this_object_header_files)
5753         (n_this_object_header_files)
5754         (n_allocated_this_object_header_files): Define.
5755         * stabsread.h (EXTERN): Never define.  Use "extern".
5756
5757 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5758
5759         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5760         history_value.
5761
5762 2019-01-21  Tom Tromey  <tom@tromey.com>
5763
5764         * ui-out.c: Fix includes.
5765         * tui/tui-source.c: Fix includes.
5766         * target.c: Fix includes.
5767         * remote.c: Fix includes.
5768         * regcache.c: Fix includes.
5769         * python/py-block.c: Fix includes.
5770         * printcmd.c: Fix includes.
5771         * or1k-tdep.c: Fix includes.
5772         * mi/mi-main.c: Fix includes.
5773         * m32r-tdep.c: Fix includes.
5774         * csky-tdep.c: Fix includes.
5775         * compile/compile-cplus-types.c: Fix includes.
5776         * cli/cli-interp.c: Fix includes.
5777
5778 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5779
5780         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5781         for padding.
5782
5783 2019-01-16  Tom Tromey  <tom@tromey.com>
5784
5785         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5786         earlier.
5787         (struct objfile) <msymbols_range>: Move from top level.
5788         <msymbols>: New method.
5789         (class objfile_msymbols): Remove.
5790         * symtab.c (default_collect_symbol_completion_matches_break_on):
5791         Update.
5792         * symmisc.c (dump_msymbols): Update.
5793         * stabsread.c (scan_file_globals): Update.
5794         * objc-lang.c (info_selectors_command, info_classes_command)
5795         (find_methods): Update.
5796         * minsyms.c (find_solib_trampoline_target): Update.
5797         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5798         * coffread.c (coff_symfile_read): Update.
5799         * ada-lang.c (ada_lookup_simple_minsym)
5800         (ada_collect_symbol_completion_matches): Update.
5801
5802 2019-01-16  Tom Tromey  <tom@tromey.com>
5803
5804         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5805         type.  Remove no-argument constructor.
5806         <iterator::operator++>: Simplify.
5807         <begin>: Update.
5808         <end>: Use minimal_symbol_count.
5809
5810 2019-01-16  Tom Tromey  <tom@tromey.com>
5811
5812         * objfiles.h (struct objfile) <psymtabs>: New method.
5813         (class objfile_psymtabs): Remove.
5814         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5815         typedef.
5816         <range>: New method.
5817         (require_partial_symbols): Change return type.
5818         * psymtab.c (require_partial_symbols)
5819         (psym_expand_symtabs_matching): Update.
5820         * mdebugread.c (parse_partial_symbols): Update.
5821         * dbxread.c (dbx_end_psymtab): Update.
5822
5823 2019-01-15  Tom Tromey  <tom@tromey.com>
5824
5825         * symtab.c (lookup_objfile_from_block)
5826         (lookup_symbol_in_objfile_symtabs)
5827         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5828         (find_line_symtab, info_sources_command)
5829         (default_collect_symbol_completion_matches_break_on)
5830         (make_source_files_completion_list): Update.
5831         * symmisc.c (print_objfile_statistics, dump_objfile)
5832         (maintenance_print_symbols, maintenance_info_symtabs)
5833         (maintenance_check_symtabs, maintenance_info_line_tables):
5834         Update.
5835         * source.c (select_source_symtab)
5836         (forget_cached_source_info_for_objfile): Update.
5837         * objfiles.h (class objfile_compunits): Remove.
5838         (struct objfile) <compunits_range>: New typedef.
5839         (compunits): New method.
5840         * objfiles.c (objfile_relocate1): Update.
5841         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5842         * maint.c (count_symtabs_and_blocks): Update.
5843         * linespec.c (iterate_over_all_matching_symtabs): Update.
5844         * cp-support.c (add_symbol_overload_list_qualified): Update.
5845         * coffread.c (coff_symtab_read): Update.
5846         * ada-lang.c (add_nonlocal_symbols)
5847         (ada_collect_symbol_completion_matches)
5848         (ada_add_global_exceptions): Update.
5849
5850 2019-01-15  Tom Tromey  <tom@tromey.com>
5851
5852         * progspace.h (program_space) <objfiles_safe_range>: New
5853         typedef.
5854         <objfiles_safe>: New method.
5855         * objfiles.h (class all_objfiles_safe): Remove.
5856         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5857         * jit.c (jit_inferior_exit_hook): Update.
5858
5859 2019-01-17  Tom Tromey  <tom@tromey.com>
5860
5861         * progspace.h (program_space) <objfiles_range>: New typedef.
5862         <objfiles>: New method.
5863         <objfiles_head>: Rename from objfiles.
5864         (object_files): Update.
5865         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5866         * guile/scm-pretty-print.c
5867         (ppscm_find_pretty_printer_from_objfiles): Update.
5868         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5869         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5870         Update.
5871         * python/py-progspace.c (pspy_get_objfiles): Update.
5872         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5873         Update.
5874         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5875         (objfpy_lookup_objfile_by_build_id): Update.
5876         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5877         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5878         Update.
5879         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5880         (expand_symtab_containing_pc, lookup_objfile_from_block)
5881         (lookup_static_symbol, basic_lookup_transparent_type)
5882         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5883         (find_line_symtab, info_sources_command)
5884         (default_collect_symbol_completion_matches_break_on)
5885         (make_source_files_completion_list, find_main_name): Update.
5886         * symmisc.c (print_symbol_bcache_statistics)
5887         (print_objfile_statistics, maintenance_print_symbols)
5888         (maintenance_print_msymbols, maintenance_print_objfiles)
5889         (maintenance_info_symtabs, maintenance_check_symtabs)
5890         (maintenance_expand_symtabs, maintenance_info_line_tables):
5891         Update.
5892         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5893         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5894         (map_overlay_command, unmap_overlay_command)
5895         (simple_overlay_update, expand_symtabs_matching)
5896         (map_symbol_filenames): Update.
5897         * symfile-debug.c (set_debug_symfile): Update.
5898         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5899         Update.
5900         * source.c (select_source_symtab, forget_cached_source_info):
5901         Update.
5902         * solib.c (solib_read_symbols): Update.
5903         * solib-spu.c (append_ocl_sos): Update.
5904         * psymtab.c (maintenance_print_psymbols)
5905         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5906         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5907         * printcmd.c (info_symbol_command): Update.
5908         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5909         Update.
5910         * objfiles.h (class all_objfiles): Remove.
5911         * objfiles.c (have_partial_symbols, have_full_symbols)
5912         (have_minimal_symbols, qsort_cmp, update_section_map)
5913         (shared_objfile_contains_address_p)
5914         (default_iterate_over_objfiles_in_search_order): Update.
5915         * objc-lang.c (info_selectors_command, info_classes_command)
5916         (find_methods): Update.
5917         * minsyms.c (find_solib_trampoline_target): Update.
5918         * maint.c (maintenance_info_sections)
5919         (maintenance_translate_address, count_symtabs_and_blocks):
5920         Update.
5921         * main.c (captured_main_1): Update.
5922         * linux-thread-db.c (try_thread_db_load_from_pdir)
5923         (has_libpthread): Update.
5924         * linespec.c (iterate_over_all_matching_symtabs)
5925         (search_minsyms_for_name): Update.
5926         * jit.c (jit_find_objf_with_entry_addr): Update.
5927         * hppa-tdep.c (find_unwind_entry)
5928         (hppa_lookup_stub_minimal_symbol): Update.
5929         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5930         Update.
5931         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5932         (elf_gnu_ifunc_resolve_by_got): Update.
5933         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5934         * dwarf-index-write.c (save_gdb_index_command): Update.
5935         * cp-support.c (add_symbol_overload_list_qualified): Update.
5936         * breakpoint.c (create_overlay_event_breakpoint)
5937         (create_longjmp_master_breakpoint)
5938         (create_std_terminate_master_breakpoint)
5939         (create_exception_master_breakpoint): Update.
5940         * blockframe.c (find_pc_partial_function): Update.
5941         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5942         (ada_collect_symbol_completion_matches)
5943         (ada_add_global_exceptions): Update.
5944
5945 2019-01-17  Tom Tromey  <tom@tromey.com>
5946
5947         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5948         declare VEC.
5949         (solib_target_parse_libraries): Change return type.
5950         (library_list_start_segment, library_list_start_section)
5951         (library_list_end_library, library_list_start_library); Update.
5952         (solib_target_free_library_list): Remove.
5953         (solib_target_parse_libraries): Remove cleanup.  Change return
5954         type.
5955         (solib_target_current_sos): Update.
5956
5957 2019-01-17  Tom Tromey  <tromey@bapiya>
5958
5959         * valprint.c: Replace "the the" with "the".
5960         * symtab.c: Replace "the the" with "the".
5961         * solib.c: Replace "the the" with "the".
5962         * solib-dsbt.c: Replace "the the" with "the".
5963         * linespec.c: Replace "the the" with "the".
5964         * dwarf2loc.h: Replace "the the" with "the".
5965         * amd64-windows-tdep.c: Replace "the the" with "the".
5966         * aarch64-tdep.c: Replace "the the" with "the".
5967
5968 2019-01-16  Keith Seitz  <keiths@redhat.com>
5969
5970         PR gdb/23773
5971         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5972         <builder>: Rename to ..
5973         <m_builder>: ... this and make private.
5974         (dwarf2_cu::get_builder): New method.  Change all users of
5975         `builder' to use this method.
5976         (dwarf2_start_symtab): Move to ...
5977         (dwarf2_cu::start_symtab): ... here.  Update all callers
5978         (setup_type_unit_groups): Move to ...
5979         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5980         callers.
5981         (dwarf2_cu::reset_builder): New method.
5982         (process_full_compunit, process_full_type_unit): Use
5983         dwarf2_cu::reset_builder.
5984         (follow_die_offset): Record the ancestor CU if it is different
5985         from the followed DIE's CU.
5986         (follow_die_sig_1): Likewise.
5987
5988 2019-01-15  Tom Tromey  <tom@tromey.com>
5989
5990         * remote.c (class remote_state) <buf>: Now a char_vector.
5991         <buf_size>: Remove.
5992         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5993         parameter.
5994         (remote_target::getpkt_or_notif_sane_1)
5995         (remote_target::getpkt_sane)
5996         (remote_target::getpkt_or_notif_sane): Likewise.
5997         (class remote_target) <putpkt>: New overload.
5998         (remote_target::read_frame): Change type of "buf_p".  Remove
5999         sizeof_p parameter.
6000         (packet_ok): New overload.
6001         (packet_check_result): New overload.
6002         Update all uses.
6003
6004 2019-01-14  Tom Tromey  <tom@tromey.com>
6005
6006         * remote-notif.c (handle_notification, remote_notif_ack)
6007         (remote_notif_parse): Make "buf" const.
6008         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
6009         const.
6010         (remote_notif_parse, remote_notif_ack, handle_notification):
6011         Likewise.
6012         * remote.c (remote_notif_stop_parse): Make "buf" const.
6013         (remote_target::remote_parse_stop_reply): Make "buf" const.
6014         (remote_notif_stop_ack): Make "buf" const.
6015
6016 2019-01-14  Tom Tromey  <tom@tromey.com>
6017
6018         * remote.c (remote_console_output): Make parameter const.
6019
6020 2019-01-14  Tom Tromey  <tom@tromey.com>
6021
6022         * target-debug.h (target_debug_print_signals): Constify.
6023         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
6024         * procfs.c (procfs_target::pass_signals): Update.
6025         * linux-nat.c (linux_nat_target::pass_signals): Update.
6026         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
6027         * target-delegates.c: Rebuild.
6028         * remote.c (remote_target::program_signals): Update.
6029         (remote_target::pass_signals): Update.
6030         * target.c (target_pass_signals): Constify argument.
6031         (target_program_signals): Likewise.
6032         * target.h (struct target_ops) <pass_signals, program_signals>:
6033         Constify argument.
6034         (target_pass_signals, target_program_signals): Constify argument.
6035
6036 2019-01-14  Tom Tromey  <tom@tromey.com>
6037
6038         PR tui/28819:
6039         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
6040
6041 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6042
6043         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
6044         field.
6045         * rs6000-tdep.c: Include reggroups.h.
6046         (IS_V_ALIAS_PSEUDOREG): Define.
6047         (rs6000_register_name): Return names for the "vX" aliases.
6048         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
6049         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
6050         aliases.  Call default_register_reggroup_p for all other
6051         pseudo-registers.
6052         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
6053         New functions.
6054         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
6055         Handle "vX" aliases.
6056         (v_alias_pseudo_register_collect): New function.
6057         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
6058         (rs6000_gdbarch_init): Initialize "vX" aliases as
6059         pseudo-registers.  Restore registration of
6060         rs6000_pseudo_register_reggroup_p with
6061         set_tdesc_pseudo_register_reggroup_p.
6062
6063 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
6064
6065         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
6066         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
6067         set_gdbarch_num_pseudo_regs.
6068
6069 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6070
6071         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
6072         Remove arg prefixname, add do_set and do_show.
6073         Add member functions set_list and show_list.
6074         * cli/cli-style.c (class cli_style_option): Update accordingly.
6075         (style_set_list): Move to file scope.
6076         (style_show_list): Likewise.
6077         (set_style): Call help_list.
6078         (show_style): Call cmd_show_list.
6079         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
6080         Update to use the new macro.
6081
6082 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
6083
6084         * ada-lang.c (_initialize_ada_language): Expand the help text
6085         for the "catch exception" command.
6086
6087 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6088
6089         * symtab.c (matching_obj_sections): Initialize obj,
6090         declare it closer to its usage.
6091
6092 2019-01-10  Tom Tromey  <tom@tromey.com>
6093
6094         * thread-iter.h (inf_threads_iterator): Use next_iterator.
6095         (basic_inf_threads_range): Remove.
6096         (inf_threads_range, inf_non_exited_threads_range)
6097         (safe_inf_threads_range): Use next_adapter.
6098
6099 2019-01-10  Keith Seitz  <keiths@redhat.com>
6100
6101         PR gdb/23712
6102         PR symtab/23010
6103         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
6104         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
6105
6106 2019-01-10  Keith Seitz  <keiths@redhat.com>
6107
6108         PR gdb/23712
6109         PR symtab/23010
6110         * dictionary.c (pending_to_vector): Remove.
6111         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6112         Remove _1 suffix, replacing functions of the same name.  Update
6113         all callers.
6114         (dict_create_hashed, dict_create_hashed_expandable)
6115         (dict_create_linear, dict_create_linear_expandable, dict_free)
6116         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
6117         Make functions static.
6118
6119 2019-01-10  Keith Seitz  <keiths@redhat.com>
6120
6121         PR gdb/23712
6122         PR symtab/23010
6123         * dictionary.h (struct dictionary): Replace declaration with
6124         multidictionary.
6125         (dict_create_hashed, dict_create_hashed_expandable)
6126         (dict_create_linear, dict_create_linear_expandable)
6127         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
6128         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
6129         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
6130         taking multidictionary argument.
6131         [ALL_DICT_SYMBOLS]: Update for multidictionary.
6132         * block.h (struct block) <dict>: Change to multidictionary
6133         and rename `multidict'.
6134         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
6135         symmisc.c: Update all dictionary references to multidictionary.
6136
6137 2019-01-10  Keith Seitz  <keiths@redhat.com>
6138
6139         PR gdb/23712
6140         PR symtab/23010
6141         * dictionary.c: Include unordered_map.
6142         (pending_to_vector): New function.
6143         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6144         Rewrite the non-"_1" functions to take vector instead
6145         of linked list.
6146         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
6147         "new" _1 versions of the same name.
6148         (multidictionary): Define.
6149         (std::hash<enum language): New definition.
6150         (collate_pending_symbols_by_language, mdict_create_hashed)
6151         (mdict_create_hashed_expandable, mdict_create_linear)
6152         (mdict_create_linear_expandable, mdict_free)
6153         (find_language_dictionary, create_new_language_dictionary)
6154         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
6155         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
6156         (mdict_size, mdict_empty): New functions.
6157         * dictionary.h (mdict_iterator): Define.
6158
6159 2019-01-10  Pedro Alves  <palves@redhat.com>
6160
6161         * breakpoint.c (read_uploaded_action)
6162         (create_tracepoint_from_upload): Adjust to use
6163         gdb::unique_xmalloc_ptr.
6164         * ctf.c (ctf_write_uploaded_tp):
6165         (SET_ARRAY_FIELD): Use emplace_back.
6166         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
6167         * tracefile-tfile.c (tfile_write_uploaded_tp):
6168         * tracepoint.c (parse_tracepoint_definition): Adjust to use
6169         gdb::unique_xmalloc_ptr.
6170         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
6171         at_string, cond_string, cmd_strings>: Replace char pointers
6172         with gdb::unique_xmalloc_ptr.
6173
6174 2019-01-10  Pedro Alves  <palves@redhat.com>
6175
6176         * solib-target.c (library_list_start_library): Don't xstrdup name.
6177
6178 2019-01-10  Pedro Alves  <palves@redhat.com>
6179
6180         * mdebugread.c (parse_partial_symbols): Use
6181         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
6182
6183 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6184
6185         * linux-fork.c (scoped_switch_fork_info)
6186         <~scoped_switch_fork_info>: Fix incorrect variable name.
6187
6188 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6189
6190         * linux-fork.c (scoped_switch_fork_info)
6191         <scoped_switch_fork_info>: Make explicit.
6192         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
6193
6194 2019-01-10  Tom Tromey  <tom@tromey.com>
6195
6196         * objfiles.h (objfile::reset_psymtabs): Update.
6197         * objfiles.c (objfile::objfile): Update.
6198         * psymtab.h (psymtab_storage::obstack): Update.
6199         (psymtab_storage::m_obstack): Use gdb::optional.
6200         (class psymtab_storage): Update comment.  Remove objfile
6201         parameter.
6202         * psymtab.c (psymtab_storage::psymtab_storage): Update.
6203
6204 2019-01-10  Tom Tromey  <tom@tromey.com>
6205
6206         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
6207         <free_psymtabs>: Now private.
6208         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
6209         (allocate_psymtab): Use new method.
6210
6211 2019-01-10  Tom Tromey  <tom@tromey.com>
6212
6213         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
6214         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
6215         * mdebugread.c (parse_partial_symbols): Use
6216         allocate_dependencies.
6217         * dwarf2read.c (dwarf2_create_include_psymtab): Use
6218         allocate_dependencies.
6219         (process_psymtab_comp_unit_reader)
6220         (build_type_psymtab_dependencies): Likewise.
6221         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
6222
6223 2019-01-10  Tom Tromey  <tom@tromey.com>
6224
6225         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
6226         PSYMBOL_SET_LANGUAGE.
6227         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
6228
6229 2019-01-10  Tom Tromey  <tom@tromey.com>
6230
6231         * psymtab.h (psymtab_storage::obstack): New method.
6232         <m_obstack>: Rename from obstack; now private.
6233         * psymtab.c (psymtab_storage): Update.
6234         * dwarf2read.c (create_addrmap_from_index)
6235         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
6236         Update.
6237
6238 2019-01-10  Tom Tromey  <tom@tromey.com>
6239
6240         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
6241         * objfiles.h (objfile::reset_psymtabs): New method.
6242
6243 2019-01-10  Tom Tromey  <tom@tromey.com>
6244
6245         * symmisc.c (print_symbol_bcache_statistics): Update.
6246         (print_objfile_statistics): Update.
6247         * symfile.c (reread_symbols): Update.
6248         * psymtab.h (class psymtab_storage): New.
6249         * psymtab.c (psymtab_storage): New constructor.
6250         (~psymtab_storage): New destructor.
6251         (require_partial_symbols): Update.
6252         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
6253         (find_pc_sect_psymtab, find_pc_sect_psymbol)
6254         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
6255         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
6256         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
6257         (start_psymtab_common, end_psymtab_common)
6258         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
6259         (allocate_psymtab): Update.
6260         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
6261         Update.
6262         (dump_psymtab_addrmap, maintenance_print_psymbols)
6263         (maintenance_check_psymtabs): Update.
6264         (class objfile_psymtabs): Move to objfiles.h.
6265         * psympriv.h (discard_psymtab): Now inline.
6266         (psymtab_discarder::psymtab_discarder): Update.
6267         (psymtab_discarder::~psymtab_discarder): Update.
6268         (ALL_OBJFILE_PSYMTABS): Rewrite.
6269         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6270         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6271         Remove fields.
6272         <partial_symtabs>: New field.
6273         (class objfile_psymtabs): Move from psymtab.h.  Update.
6274         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6275         psymbol_cache.
6276         (objfile::~objfile): Don't destroy psymbol_cache.
6277         * mdebugread.c (parse_partial_symbols): Update.
6278         * dwarf2read.c (create_addrmap_from_index)
6279         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6280         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6281         (add_partial_subprogram, dwarf2_ranges_read): Update.
6282         * dwarf-index-write.c (write_address_map)
6283         (write_one_signatured_type, recursively_write_psymbols)
6284         (class debug_names, class debug_names, write_psymtabs_to_index):
6285         Update.
6286
6287 2019-01-10  Tom Tromey  <tom@tromey.com>
6288
6289         * symtab.h (SYMBOL_SET_NAMES): Update.
6290         (symbol_set_names): Update.
6291         (MSYMBOL_SET_NAMES): Update.
6292         * symtab.c (symbol_set_names): Change argument to be an
6293         objfile_per_bfd_storage.
6294         * psymtab.c (add_psymbol_to_bcache): Update.
6295         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6296
6297 2019-01-10  Tom Tromey  <tom@tromey.com>
6298
6299         * symtab.c (create_demangled_names_hash): Change argument to be an
6300         objfile_per_bfd_storage.
6301         (symbol_set_names): Update.
6302
6303 2019-01-10  Tom Tromey  <tom@tromey.com>
6304
6305         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6306         init_psymbol_list.
6307         * psymtab.c (init_psymbol_list): Do nothing if already called.
6308         * psympriv.h (init_psymbol_list): Add comment.
6309         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6310         init_psymbol_list.
6311         * dbxread.c (dbx_symfile_read): Unconditionally call
6312         init_psymbol_list.
6313
6314 2019-01-10  Tom Tromey  <tom@tromey.com>
6315
6316         * xcoffread.c (scan_xcoff_symtab): Update.
6317         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6318         "where".
6319         * mdebugread.c (parse_partial_symbols)
6320         (handle_psymbol_enumerators): Update.
6321         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6322         * dbxread.c (read_dbx_symtab): Update.
6323         * psympriv.h (psymbol_placement): New enum.
6324         (add_psymbol_to_list): Update.
6325
6326 2019-01-10  Tom Tromey  <tom@tromey.com>
6327
6328         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6329         static_psymbols parameters.
6330         (scan_xcoff_symtab): Update.
6331         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6332         static_psymbols parameters.
6333         * psympriv.h (start_psymtab_common): Update.
6334         * mdebugread.c (parse_partial_symbols): Update.
6335         * dwarf2read.c (create_partial_symtab): Update.
6336         * dbxread.c (read_dbx_symtab): Update.
6337         (start_psymtab): Remove global_psymbols and static_psymbols
6338         parameters.
6339
6340 2019-01-10  Tom Tromey  <tom@tromey.com>
6341
6342         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6343         * psymtab.c (allocate_psymtab): Add comment.
6344         * psympriv.h (allocate_psymtab): Add comment.
6345         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6346         initializations.
6347         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6348
6349 2019-01-10  Tom Tromey  <tom@tromey.com>
6350
6351         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6352         Don't declare.
6353         * mipsread.c: Include mdebugread.h.
6354         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6355         Declare.
6356         * elfread.c: Include mdebugread.h.
6357
6358 2019-01-09  Tom Tromey  <tom@tromey.com>
6359
6360         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6361         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6362         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6363         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6364         (psym_lookup_symbol, psym_find_last_source_symtab)
6365         (psym_forget_cached_source_info, psym_print_stats)
6366         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6367         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6368         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6369         (psym_find_compunit_symtab_by_address)
6370         (maintenance_print_psymbols, maintenance_info_psymtabs)
6371         (maintenance_check_psymtabs): Use ranged for.
6372         * psymtab.h (class objfile_psymtabs): New.
6373         (require_partial_symbols): Return objfile_psymtabs.
6374         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6375
6376 2019-01-09  Tom Tromey  <tom@tromey.com>
6377
6378         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6379         (find_pc_mapped_section, list_overlays_command)
6380         (map_overlay_command, unmap_overlay_command)
6381         (simple_overlay_update): Use all_objfiles.
6382         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6383         * printcmd.c (info_symbol_command): Use all_objfiles.
6384         * objfiles.h (ALL_OBJSECTIONS): Remove.
6385         * maint.c (maintenance_translate_address): Use all_objfiles.
6386         * gcore.c (gcore_create_callback): Use all_objfiles.
6387         (objfile_find_memory_regions): Likewise.
6388
6389 2019-01-09  Tom Tromey  <tom@tromey.com>
6390
6391         * symtab.c (find_line_symtab, info_sources_command)
6392         (make_source_files_completion_list): Use objfile_compunits.
6393         * source.c (select_source_symtab): Use objfile_compunits.
6394         * objfiles.h (struct objfile): Update comment.
6395         (ALL_OBJFILES): Remove.
6396         (ALL_FILETABS): Remove.
6397         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6398         objfile_compunits.
6399
6400 2019-01-09  Tom Tromey  <tom@tromey.com>
6401
6402         * symmisc.c (print_objfile_statistics, dump_objfile)
6403         (maintenance_print_symbols): Use compunit_filetabs.
6404         * source.c (forget_cached_source_info_for_objfile): Use
6405         compunit_filetabs.
6406         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6407         (ALL_FILETABS): Use compunit_filetabs.
6408         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6409         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6410
6411 2019-01-09  Tom Tromey  <tom@tromey.com>
6412
6413         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6414         (compunit_filetabs): New.
6415         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6416         compunit_filetabs.
6417         (info_sources_command, make_source_files_completion_list): Remove
6418         declaration.
6419         * symmisc.c (print_objfile_statistics, dump_objfile)
6420         (maintenance_print_symbols): Remove declaration.
6421         (maintenance_info_symtabs): Use compunit_filetabs.
6422         (maintenance_info_line_tables): Likewise.
6423         * source.c (select_source_symtab): Change local variable name.
6424         (forget_cached_source_info_for_objfile): Remove declaration.
6425         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6426         * objfiles.c (objfile_relocate1): Remove declaration.
6427         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6428         declaration.
6429         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6430         * coffread.c (coff_symtab_read): Remove declaration.
6431         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6432         compunit_filetabs.
6433
6434 2019-01-09  Tom Tromey  <tom@tromey.com>
6435
6436         * symtab.c (lookup_objfile_from_block)
6437         (find_pc_sect_compunit_symtab, search_symbols)
6438         (default_collect_symbol_completion_matches_break_on): Use
6439         objfile_compunits.
6440         * objfiles.h (ALL_COMPUNITS): Remove.
6441         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6442         * cp-support.c (add_symbol_overload_list_qualified): Use
6443         objfile_compunits.
6444         * ada-lang.c (ada_collect_symbol_completion_matches)
6445         (ada_add_global_exceptions): Use objfile_compunits.
6446
6447 2019-01-09  Tom Tromey  <tom@tromey.com>
6448
6449         * source.c (select_source_symtab)
6450         (forget_cached_source_info_for_objfile): Remove declaration.
6451         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6452         declaration.
6453         * maint.c (count_symtabs_and_blocks): Remove declaration.
6454         * cp-support.c (add_symbol_overload_list_qualified): Remove
6455         declaration.
6456         * coffread.c (coff_symtab_read): Remove declaration.
6457         * symtab.c (lookup_symbol_in_objfile_symtabs)
6458         (basic_lookup_transparent_type_1): Use objfile_compunits.
6459         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6460         (info_sources_command, search_symbols)
6461         (default_collect_symbol_completion_matches_break_on)
6462         (make_source_files_completion_list): Remove declaration.
6463         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6464         (ada_collect_symbol_completion_matches)
6465         (ada_add_global_exceptions): Remove declaration.
6466         * linespec.c (iterate_over_all_matching_symtabs): Use
6467         objfile_compunits.
6468         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6469         (class objfile_compunits): New.
6470         (ALL_COMPUNITS): Use objfile_compunits.
6471         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6472         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6473         objfile_compunits.
6474         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6475
6476 2019-01-09  Tom Tromey  <tom@tromey.com>
6477
6478         * symtab.c (search_symbols)
6479         (default_collect_symbol_completion_matches_break_on): Use
6480         objfile_msymbols.
6481         * ada-lang.c (ada_lookup_simple_minsym)
6482         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6483         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6484         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6485         objfile_msymbols.
6486         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6487         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6488         * objc-lang.c (find_methods): Use objfile_msymbols.
6489         (info_selectors_command, info_classes_command): Likewise.
6490         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6491         * objfiles.h (class objfile_msymbols): New.
6492         (ALL_OBJFILE_MSYMBOLS): Remove.
6493         (ALL_MSYMBOLS): Remove.
6494
6495 2019-01-09  Tom Tromey  <tom@tromey.com>
6496
6497         * common/next-iterator.h (next_adapter): Add Iterator template
6498         parameter.
6499         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6500         (class all_objfiles_safe): New.
6501         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6502         * objfiles.c (put_objfile_before): Update comment.
6503         (add_separate_debug_objfile): Likewise.
6504         (free_all_objfiles): Use all_objfiles_safe.
6505         (objfile_purge_solibs): Likewise.
6506
6507 2019-01-09  Tom Tromey  <tom@tromey.com>
6508
6509         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6510         (expand_symtab_containing_pc, lookup_static_symbol)
6511         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6512         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6513         all_objfiles.
6514         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6515         * breakpoint.c (create_overlay_event_breakpoint)
6516         (create_longjmp_master_breakpoint)
6517         (create_std_terminate_master_breakpoint)
6518         (create_exception_master_breakpoint): Use all_objfiles.
6519         * linux-thread-db.c (try_thread_db_load_from_pdir)
6520         (has_libpthread): Use all_objfiles.
6521         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6522         * linespec.c (iterate_over_all_matching_symtabs)
6523         (search_minsyms_for_name): Use all_objfiles.
6524         * maint.c (maintenance_info_sections): Use all_objfiles.
6525         * main.c (captured_main_1): Use all_objfiles.
6526         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6527         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6528         * guile/scm-pretty-print.c
6529         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6530         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6531         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6532         (maintenance_print_msymbols): Use all_objfiles.
6533         * source.c (select_source_symtab): Use all_objfiles.
6534         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6535         * symfile.c (remove_symbol_file_command)
6536         (expand_symtabs_matching, map_symbol_filenames): Use
6537         all_objfiles.
6538         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6539         all_objfiles.
6540         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6541         * objc-lang.c (find_methods): Use all_objfiles.
6542         * objfiles.c (have_partial_symbols, have_full_symbols)
6543         (have_minimal_symbols, qsort_cmp)
6544         (default_iterate_over_objfiles_in_search_order): Use
6545         all_objfiles.
6546         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6547         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6548         (maintenance_check_psymtabs): Use all_objfiles.
6549         (ALL_PSYMTABS): Remove.
6550         * compile/compile-object-run.c (do_module_cleanup): Use
6551         all_objfiles.
6552         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6553         * cp-support.c (add_symbol_overload_list_qualified): Use
6554         all_objfiles.
6555         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6556         Use all_objfiles.
6557         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6558         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6559         all_objfiles.
6560         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6561         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6562         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6563         Uses all_objfiles.
6564         * solib.c (solib_read_symbols): Use all_objfiles
6565
6566 2019-01-09  Tom Tromey  <tom@tromey.com>
6567
6568         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6569         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6570         all_objfiles.
6571         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6572         * symmisc.c (print_symbol_bcache_statistics)
6573         (print_objfile_statistics, maintenance_print_objfiles)
6574         (maintenance_info_symtabs, maintenance_check_symtabs)
6575         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6576         all_objfiles.
6577         * source.c (forget_cached_source_info): Use all_objfiles.
6578         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6579         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6580         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6581         * objfiles.c (update_section_map): Use all_objfiles.
6582         (shared_objfile_contains_address_p): Likewise.
6583         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6584         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6585
6586 2019-01-09  Tom Tromey  <tom@tromey.com>
6587
6588         * common/next-iterator.h: New file.
6589         * objfiles.h (class all_objfiles): New.
6590         (struct objfile_iterator): New.
6591
6592 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6593
6594         * NEWS: Move the description of the changed "frame", "select-frame",
6595          and "info frame" commands to the Changed commands section.
6596
6597 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6598
6599         * gdbtypes.c (check_stub_method_group): Remove handling of old
6600         mangling schemes.
6601         * linespec.c (find_methods): Likewise.
6602         * stabsread.c (read_member_functions): Likewise.
6603         * valops.c (search_struct_method): Likewise.
6604         (value_struct_elt_for_reference): Likewise.
6605         * NEWS: Mention this change.
6606
6607 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6608
6609         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6610         print_source_lines.
6611         * source.c (print_source_lines_base): Update line number check.
6612         (print_source_lines): New function.
6613         (source_lines_range::source_lines_range): New function.
6614         * source.h (class source_lines_range): New class.
6615         (print_source_lines): New declaration.
6616
6617 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6618
6619         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6620
6621 2019-01-08  Tom Tromey  <tom@tromey.com>
6622             Simon Marchi  <simon.marchi@ericsson.com>
6623
6624         PR gdb/24060
6625         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6626         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6627         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6628         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6629         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6630         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6631
6632 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6633
6634         * source.c (select_source_symtab): Move header comment to
6635         declaration in source.h.
6636         (forget_cached_source_info_for_objfile): Likewise.
6637         (forget_cached_source_info): Likewise.
6638         (identify_source_line): Likewise.
6639         * source.h (identify_source_line): Move declaration from symtab.h
6640         and add comment from source.c
6641         (print_source_lines): Likewise.
6642         (forget_cached_source_info_for_objfile): Likewise.
6643         (forget_cached_source_info): Likewise.
6644         (select_source_symtab): Likewise.
6645         (enum print_source_lines_flag): Move definition from symtab.h.
6646         * symtab.h (identify_source_line): Move declaration to source.h.
6647         (print_source_lines): Likewise.
6648         (forget_cached_source_info_for_objfile): Likewise.
6649         (forget_cached_source_info): Likewise.
6650         (select_source_symtab): Likewise.
6651         (enum print_source_lines_flag): Move definition to source.h.
6652         * tui/tui-hooks.c: Add 'source.h' include.
6653
6654 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6655
6656         * source.c (print_source_lines_base): Handle requests to print
6657         reverse line number sequences, and guard against empty lines
6658         string.
6659
6660 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6661
6662         * source.c (print_source_lines_base): Fix skip of '\r' if next
6663         character is '\n'.
6664
6665 2019-01-06  Tom Tromey  <tom@tromey.com>
6666
6667         * c-exp.y (struct c_parse_state) <macro_original_text,
6668         expansion_obstack>: New member.
6669         (macro_original_text, expansion_obstack): Remove globals.
6670         (scan_macro_expansion, scanning_macro_expansion)
6671         (finished_macro_expansion): Update.
6672         (scan_macro_cleanup): Remove.
6673         (yylex, c_parse): Update.
6674
6675 2019-01-06  Tom Tromey  <tom@tromey.com>
6676
6677         * c-exp.y (struct c_parse_state) <strings>: New member.
6678         (operator_stoken): Update.
6679
6680 2019-01-06  Tom Tromey  <tom@tromey.com>
6681
6682         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6683         (union type_stack_elt) <typelist_val>: Now a pointer to
6684         std::vector.
6685         (type_stack_cleanup): Don't declare.
6686         (push_typelist): Update.
6687         * parse.c (pop_typelist): Return a std::vector.
6688         (push_typelist): Take a std::vector.
6689         (follow_types): Update.  Do not free args.
6690         (type_stack_cleanup): Remove.
6691         * c-exp.y (struct c_parse_state): New.
6692         (cpstate): New global.
6693         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6694         (nonempty_typelist): Update.
6695         (func_mod): Create a new vector.
6696         (c_parse): Create a c_parse_state.
6697         (check_parameter_typelist): Do not delete params.
6698         (function_method): Update.  Do not delete type_list.
6699
6700 2019-01-06  Tom Tromey  <tom@tromey.com>
6701
6702         PR gdb/28155:
6703         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6704         check_typedef.
6705         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6706         (print_return_value): Likewise.
6707
6708 2019-01-05  Tom Tromey  <tom@tromey.com>
6709
6710         * contrib/cleanup_check.py: Remove.
6711         * contrib/gcc-with-excheck: Remove.
6712         * contrib/exsummary.py: Remove.
6713         * contrib/excheck.py: Remove.
6714
6715 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6716
6717         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6718         NULL. Initialize tpprev to NULL instead of assigning it
6719         to NULL on the next statement.
6720         * windows-nat.c (windows_delete_thread): Remove check for
6721         main_thread_id before printing thread exit notifications.
6722         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6723         Remove thread ID check against main_thread_id.
6724         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6725         windows_delete_thread.
6726         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6727
6728 2019-01-04  Tom Tromey  <tom@tromey.com>
6729
6730         * compile/compile.c (_initialize_compile): Use upper case for
6731         metasyntactic variables.
6732         * symmisc.c (_initialize_symmisc): Use upper case for
6733         metasyntactic variables.
6734         * psymtab.c (_initialize_psymtab): Use upper case for
6735         metasyntactic variables.
6736         * demangle.c (demangle_command): Use upper case for metasyntactic
6737         variables.
6738         (_initialize_demangler): Likewise.
6739         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6740         variables.
6741
6742 2019-01-03  Tom Tromey  <tom@tromey.com>
6743
6744         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6745
6746 2019-01-03  Tom Tromey  <tom@tromey.com>
6747
6748         * python/py-symtab.c (salpy_str): Update.
6749         (struct salpy_sal_object) <symtab>: Now a PyObject.
6750         (salpy_dealloc): Update.
6751         (del_objfile_sal): Use gdbpy_ref.
6752
6753 2019-01-03  Tom Tromey  <tom@tromey.com>
6754
6755         * python/py-type.c (convert_field): Use new_reference.  Return
6756         gdbpy_ref.
6757         (make_fielditem): Return gdbpy_ref.
6758         (typy_fields): Update.
6759         (typy_getitem): Update.
6760         (field_name): Return gdbpy_ref.  Use new_reference.
6761         (typy_iterator_iternext): Update.
6762
6763 2019-01-03  Tom Tromey  <tom@tromey.com>
6764
6765         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6766
6767 2019-01-03  Tom Tromey  <tom@tromey.com>
6768
6769         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6770         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6771         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6772         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6773         (pspy_set_type_printers): Likewise.
6774         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6775         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6776         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6777         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6778         (objfpy_set_type_printers): Likewise.
6779
6780 2019-01-03  Tom Tromey  <tom@tromey.com>
6781
6782         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6783         (gdbpy_print_stack): Use gdbpy_err_fetch.
6784         * python/python-internal.h (class gdbpy_err_fetch): New class.
6785         (class gdbpy_enter) <m_error_type, m_error_value,
6786         m_error_traceback>: Remove.
6787         <m_error>: New member.
6788         (gdbpy_exception_to_string): Don't declare.
6789         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6790         * python/py-value.c (convert_value_from_python): Use
6791         gdbpy_err_fetch.
6792         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6793         gdbpy_exception_to_string.
6794         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6795         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6796         gdbpy_err_fetch.
6797
6798 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6799
6800         * linux-nat.c (delete_lwp_cleanup): Delete.
6801         (struct lwp_deleter): New struct.
6802         (lwp_info_up): New typedef.
6803         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6804         lwp_info_up.
6805
6806 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6807
6808         * linux-fork.c (class scoped_switch_fork_info): New class.
6809         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6810
6811 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6812
6813         * valops.c (find_overload_match): Remove use of null_cleanup, and
6814         calls to do_cleanups.
6815
6816 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6817
6818         * compile/compile-cplus-types.c
6819         (compile_cplus_instance::decl_name): Handle changes to
6820         cp_func_name.
6821         * cp-support.c (cp_func_name): Update header comment, update
6822         return type.
6823         * cp-support.h (cp_func_name): Update return type in declaration.
6824         * valops.c (find_overload_match): Move temp_func local to top
6825         level of function and change its type.  Use temp_func to hold and
6826         delete temporary string obtained from cp_func_name.
6827
6828 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6829
6830         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6831         gdb::char_vector, remove cleanup, and update uses of `msg`.
6832
6833 2019-01-03  Jim Wilson  <jimw@sifive.com>
6834
6835         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6836
6837 2019-01-02  Tom Tromey  <tom@tromey.com>
6838
6839         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6840         (tdesc_parse_xml): Remove cleanups.
6841         * target-descriptions.h (make_cleanup_free_target_description):
6842         Don't declare.
6843         (target_desc_deleter): New struct.
6844         (target_desc_up): New typedef.
6845         * target-descriptions.c (target_desc_deleter::operator()): Rename
6846         from free_target_description.
6847         (make_cleanup_free_target_description): Remove.
6848
6849 2019-01-02  Tom Tromey  <tom@tromey.com>
6850
6851         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6852         constructor, destructor.
6853         (linespec_parser): Remove typedef.
6854         (~linespec_parser): Rename from linespec_parser_delete.
6855         (linespec_lex_to_end, linespec_complete_label)
6856         (linespec_complete): Update.
6857         (decode_line_full): Remove cleanups.
6858         (decode_line_1): Update.
6859
6860 2019-01-02  Tom Tromey  <tom@tromey.com>
6861
6862         * python/python-internal.h (inferior_to_inferior_object): Change
6863         return type.
6864         * python/py-exitedevent.c (create_exited_event_object): Update.
6865         * python/py-inferior.c (inferior_to_inferior_object): Return
6866         gdbpy_ref.
6867         (python_new_inferior, python_inferior_deleted)
6868         (thread_to_thread_object, delete_thread_object)
6869         (build_inferior_list, gdbpy_selected_inferior): Update.
6870         * python/py-infthread.c (create_thread_object): Update.  Also fail
6871         if inferior_to_inferior_object fails.
6872
6873 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6874
6875         * inferior.h (class inferior) <displaced_step_state>: New field.
6876         * infrun.h (struct displaced_step_state): Move here from
6877         infrun.c.  Initialize fields, add constructor.
6878         <inf>: Remove field.
6879         <reset>: New method.
6880         * infrun.c (struct displaced_step_inferior_state): Move to
6881         infrun.h.
6882         (displaced_step_inferior_states): Remove.
6883         (get_displaced_stepping_state): Adust.
6884         (displaced_step_in_progress_any_inferior): Adjust.
6885         (displaced_step_in_progress_thread): Adjust.
6886         (displaced_step_in_progress): Adjust.
6887         (add_displaced_stepping_state): Remove.
6888         (get_displaced_step_closure_by_addr): Adjust.
6889         (remove_displaced_stepping_state): Remove.
6890         (infrun_inferior_exit): Call displaced_step_state.reset.
6891         (use_displaced_stepping): Don't check for NULL.
6892         (displaced_step_prepare_throw): Call
6893         get_displaced_stepping_state.
6894         (displaced_step_fixup): Don't check for NULL.
6895         (prepare_for_detach): Don't check for NULL.
6896
6897 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6898
6899         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6900          in case of call that did not complete.
6901
6902 2019-01-02  Andrey Utkin  <autkin@undo.io>
6903
6904         * symfile.c (find_separate_debug_file): Fix search of debug files for
6905         remote debuggee.
6906
6907 2019-01-02  Tom Tromey  <tom@tromey.com>
6908
6909         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6910         indentation.
6911         * python/py-frame.c (frapy_older): Remove cast.
6912         (frapy_newer): Likewise.
6913         * python/py-breakpoint.c (local_setattro): Remove cast.
6914         * python/py-arch.c (archpy_name): Remove local variable.
6915         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6916
6917 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6918
6919         * unittests/basic_string_view/element_access/char/empty.cc:
6920         Fix year range in copyright header.
6921
6922 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6923
6924         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6925         Delete.
6926         <operator==>: Update with for removed field.
6927         <hash>: Likewise.
6928         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6929         <isa_features>: ...this.
6930         <abi_features>: New field.
6931         (riscv_isa_flen): Update comment.
6932         (riscv_abi_xlen): New declaration.
6933         (riscv_abi_flen): New declaration.
6934         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6935         isa_features.
6936         (riscv_abi_xlen): New function.
6937         (riscv_isa_flen): Update to get answer from isa_features.
6938         (riscv_abi_flen): New function.
6939         (riscv_has_fp_abi): Update to get answer from abi_features.
6940         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6941         xlen and flen.
6942         (riscv_call_info) <xlen, flen>: Update comment.
6943         (riscv_call_arg_struct): Remove invalid assertions
6944         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6945         is removed.
6946         (riscv_gdbarch_init): Gather isa features and abi features
6947         separately, ensure both match on the gdbarch when reusing an old
6948         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6949         a target with 64-bit float hardware.
6950
6951 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6952
6953         * source.c (search_command_helper): Stop reverse search
6954         when line 1 has been searched.
6955
6956 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6957
6958         * record-full.c (record_full_base_target::close): Rewrite
6959         record_full_core_buf_list free logic.
6960
6961 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6962
6963         * break-catch-syscall.c (print_one_catch_syscall): xfree
6964         the last text.
6965
6966 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6967
6968         * top.c (print_gdb_version): Update Copyright year in version
6969         message.
6970
6971 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6972
6973         Update copyright year range in all GDB files.
6974
6975 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6976
6977         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6978
6979 For older changes see ChangeLog-2018.
6980 \f
6981 Local Variables:
6982 mode: change-log
6983 left-margin: 8
6984 fill-column: 74
6985 version-control: never
6986 coding: utf-8
6987 End:
6988