Avoid a crash in source_cache::extract_lines
[external/binutils.git] / gdb / ChangeLog
1 2019-03-14  Tom Tromey  <tromey@adacore.com>
2
3         * source-cache.h (class source_cache) <get_source_lines>: Return
4         std::string.
5         * source-cache.c (source_cache::extract_lines): Handle case where
6         first_pos==npos.  Return std::string.
7         (source_cache::get_source_lines): Update.
8
9 2019-03-14  Tom Tromey  <tromey@adacore.com>
10
11         * NEWS: Add item for "style sources" commands.
12         * source-cache.c (source_cache::get_source_lines): Check
13         source_styling.
14         * cli/cli-style.c (source_styling): New global.
15         (_initialize_cli_style): Add "style sources" commands.
16         (show_style_sources): New function.
17         * cli/cli-style.h (source_styling): Declare.
18
19 2019-03-14  Pedro Alves  <palves@redhat.com>
20             Tom Tromey  <tromey@adacore.com>
21
22         * tui/tui-winsource.h (tui_refill_source_window): Declare.
23         * tui/tui-winsource.c (tui_refill_source_window): New function,
24         from...
25         (tui_horizontal_source_scroll): ... here.  Move some logic.
26         * cli/cli-style.c (set_style_enabled): Notify new observable.
27         * tui/tui-hooks.c (tui_redisplay_source): New function.
28         (tui_attach_detach_observers): Attach or detach
29         tui_redisplay_source.
30         * observable.h (source_styling_changed): New observable.
31         * observable.c: Define source_styling_changed observable.
32
33 2019-03-13  Tom Tromey  <tromey@adacore.com>
34
35         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
36         (i386_gnu_nat_target::store_registers): Update.
37         * target-debug.h (target_debug_print_std_string): New macro.
38         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
39         * windows-tdep.c (display_one_tib): Update.
40         * tui/tui-stack.c (tui_make_status_line): Update.
41         * top.c (print_inferior_quit_action): Update.
42         * thread.c (thr_try_catch_cmd): Update.
43         (add_thread_with_info): Update.
44         (thread_target_id_str): Update.
45         (thr_try_catch_cmd): Update.
46         (thread_command): Update.
47         (thread_find_command): Update.
48         * record-btrace.c (record_btrace_target::info_record)
49         (record_btrace_resume_thread, record_btrace_target::resume)
50         (record_btrace_cancel_resume, record_btrace_step_thread)
51         (record_btrace_target::wait, record_btrace_target::wait)
52         (record_btrace_target::wait, record_btrace_target::stop): Update.
53         * progspace.c (print_program_space): Update.
54         * process-stratum-target.c
55         (process_stratum_target::thread_address_space): Update.
56         * linux-fork.c (linux_fork_mourn_inferior)
57         (detach_checkpoint_command, info_checkpoints_command)
58         (linux_fork_context): Update.
59         (linux_fork_detach): Update.
60         (class scoped_switch_fork_info): Update.
61         (delete_checkpoint_command): Update.
62         * infrun.c (follow_fork_inferior): Update.
63         (follow_fork_inferior): Update.
64         (proceed_after_vfork_done): Update.
65         (handle_vfork_child_exec_or_exit): Update.
66         (follow_exec): Update.
67         (displaced_step_prepare_throw): Update.
68         (displaced_step_restore): Update.
69         (start_step_over): Update.
70         (resume_1): Update.
71         (clear_proceed_status_thread): Update.
72         (proceed): Update.
73         (print_target_wait_results): Update.
74         (do_target_wait): Update.
75         (context_switch): Update.
76         (stop_all_threads): Update.
77         (restart_threads): Update.
78         (finish_step_over): Update.
79         (handle_signal_stop): Update.
80         (switch_back_to_stepped_thread): Update.
81         (keep_going_pass_signal): Update.
82         (print_exited_reason): Update.
83         (normal_stop): Update.
84         * inferior.c (inferior_pid_to_str): Change return type.
85         (print_selected_inferior): Update.
86         (add_inferior): Update.
87         (detach_inferior): Update.
88         * dummy-frame.c (fprint_dummy_frames): Update.
89         * dcache.c (dcache_info_1): Update.
90         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
91         (btrace_fetch, btrace_clear): Update.
92         * linux-tdep.c (linux_core_pid_to_str): Change return type.
93         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
94         type.
95         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
96         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
97         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
98         * gdbarch.c, gdbarch.h: Rebuild.
99         * gdbarch.sh (core_pid_to_str): Change return type.
100         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
101         return type.
102         (windows_nat_target::pid_to_str): Change return type.
103         (windows_delete_thread): Update.
104         (windows_nat_target::attach): Update.
105         (windows_nat_target::files_info): Update.
106         * target-delegates.c: Rebuild.
107         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
108         return type.
109         (sol_thread_target::pid_to_str): Change return type.
110         * remote.c (class remote_target) <pid_to_str>: Change return
111         type.
112         (remote_target::pid_to_str): Change return type.
113         (extended_remote_target::attach, remote_target::remote_stop_ns)
114         (remote_target::remote_notif_remove_queued_reply)
115         (remote_target::push_stop_reply, remote_target::disable_btrace):
116         Update.
117         (extended_remote_target::attach): Update.
118         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
119         type.
120         (gdbsim_target::pid_to_str): Change return type.
121         * ravenscar-thread.c (struct ravenscar_thread_target)
122         <pid_to_str>: Change return type.
123         (ravenscar_thread_target::pid_to_str): Change return type.
124         * procfs.c (class procfs_target) <pid_to_str>: Change return
125         type.
126         (procfs_target::pid_to_str): Change return type.
127         (procfs_target::attach): Update.
128         (procfs_target::detach): Update.
129         (procfs_target::fetch_registers): Update.
130         (procfs_target::store_registers): Update.
131         (procfs_target::wait): Update.
132         (procfs_target::files_info): Update.
133         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
134         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
135         return type.
136         (nto_procfs_target::pid_to_str): Change return type.
137         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
138         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
139         return type.
140         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
141         (exit_lwp): Update.
142         (attach_proc_task_lwp_callback, get_detach_signal)
143         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
144         (linux_nat_target::resume, wait_lwp, stop_callback)
145         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
146         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
147         (linux_nat_wait_1, resume_stopped_resumed_lwps)
148         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
149         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
150         type.
151         (inf_ptrace_target::attach): Update.
152         (inf_ptrace_target::files_info): Update.
153         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
154         type.
155         (go32_nat_target::pid_to_str): Change return type.
156         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
157         (gnu_nat_target::wait): Update.
158         (gnu_nat_target::wait): Update.
159         (gnu_nat_target::resume): Update.
160         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
161         (fbsd_nat_target::wait): Update.
162         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
163         type.
164         (darwin_nat_target::attach): Update.
165         * corelow.c (class core_target) <pid_to_str>: Change return type.
166         (core_target::pid_to_str): Change return type.
167         * target.c (normal_pid_to_str): Change return type.
168         (default_pid_to_str): Likewise.
169         (target_pid_to_str): Change return type.
170         (target_translate_tls_address): Update.
171         (target_announce_detach): Update.
172         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
173         return type.
174         (bsd_uthread_target::pid_to_str): Change return type.
175         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
176         type.
177         (bsd_kvm_target::pid_to_str): Change return type.
178         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
179         return type.
180         (aix_thread_target::pid_to_str): Change return type.
181         * target.h (struct target_ops) <pid_to_str>: Change return type.
182         (target_pid_to_str, normal_pid_to_str): Likewise.
183         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
184         type.
185         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
186         type.
187         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
188         return type.
189         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
190         type.
191         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
192         type.
193         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
194         return type.
195
196 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
197
198         * NEWS: Mention that the new default MI version is 3.  Mention
199         changes to the output of commands and events that deal with
200         multi-location breakpoints.
201         * breakpoint.c: Include "mi/mi-out.h".
202         (print_one_breakpoint): Change output syntax if using MI version
203         >= 3.
204         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
205         New.
206         (mi_multi_location_breakpoint_output_fixed): New.
207         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
208         (mi_cmd_fix_multi_location_breakpoint_output): New.
209         (mi_multi_location_breakpoint_output_fixed): New.
210         * mi/mi-cmds.c (mi_cmds): Register command
211         -fix-multi-location-breakpoint-output.
212         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
213         interpreter "mi".
214
215 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
216
217         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
218         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
219         instantiate mi_ui_out based on interpreter name.
220         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
221         * mi/mi-main.c (mi_load_progress): Likewise.
222
223 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
224
225         * NEWS: Combine separate "New targets" sections for 8.3.
226
227 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
228
229         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
230         (ppcfbsd_init_abi): Install gdbarch
231         "fetch_tls_load_module_address" and "get_thread_local_address"
232         methods.
233
234 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
235
236         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
237         (riscv_fbsd_init_abi): Install gdbarch
238         "fetch_tls_load_module_address" and "get_thread_local_address"
239         methods.
240
241 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
242
243         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
244         (i386fbsd_init_abi): Install gdbarch
245         "fetch_tls_load_module_address" and "get_thread_local_address"
246         methods.
247
248 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
249
250         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
251         (amd64fbsd_init_abi): Install gdbarch
252         "fetch_tls_load_module_address" and "get_thread_local_address"
253         methods.
254
255 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
256
257         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
258         (struct fbsd_pspace_data): New type.
259         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
260         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
261         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
262         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
263         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
264
265 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
266
267         * gdbtypes.c (lookup_struct_elt): New function.
268         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
269         * gdbtypes.h (struct struct_elt): New type.
270         (lookup_struct_elt): New prototype.
271
272 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
273
274         * gdbtypes.c (lookup_struct_elt_type): Update comment and
275         remove disabled code block.
276
277 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
278
279         * gdbarch.sh (get_thread_local_address): New method.
280         * gdbarch.h, gdbarch.c: Regenerate.
281         * target.c (target_translate_tls_address): Use
282         gdbarch_get_thread_local_address if present instead of
283         target::get_thread_local_address.
284
285 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
286
287         * target.h (target::get_thread_local_address): Update comment.
288
289 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
290
291         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
292         objfile->separate_debug_objfile_backlink if not NULL.
293
294 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
295
296         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
297         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
298         (amd64bsd_store_inferior_registers): Likewise.
299         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
300         Enable segment base registers.
301         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
302         PT_GETFSBASE and PT_GETGSBASE.
303         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
304         PT_SETGSBASE.
305         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
306         segment base registers.
307         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
308
309 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
310
311         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
312         Update calls to i386_target_description to add 'segments'
313         parameter.
314         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
315         add segment base registers.
316         * arch/i386.c (i386_create_target_description): Add 'segments'
317         parameter to enable segment base registers.
318         * arch/i386.h (i386_create_target_description): Likewise.
319         * features/i386/32bit-segments.xml: New file.
320         * features/i386/32bit-segments.c: Generate.
321         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
322         call to i386_target_description to add 'segments' parameter.
323         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
324         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
325         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
326         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
327         if feature is present.
328         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
329         Add 'segments' parameter to call to i386_target_description.
330         (i386_target_description): Add 'segments' parameter to enable
331         segment base registers.
332         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
333         to call to i386_target_description.
334         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
335         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
336         Define I386_NUM_REGS.
337         (i386_target_description): Add 'segments' parameter to enable
338         segment base registers.
339
340 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
341
342         PR/24325
343         * source-cache.c: #undef open and close, to avoid unresolved
344         externals during linking.
345
346 2019-03-12  Tom Tromey  <tromey@adacore.com>
347
348         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
349         const.  Add initializers.
350         (_initialize_remote): Don't initialize ptid globals.
351
352 2019-03-12  Pedro Alves  <palves@redhat.com>
353
354         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
355
356 2019-03-12  Pedro Alves  <palves@redhat.com>
357
358         * cp-name-parser.y (main): Remove unused 'len' variable.
359
360 2019-03-12  Tom Tromey  <tromey@adacore.com>
361
362         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
363         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
364
365 2019-03-12  Tom Tromey  <tromey@adacore.com>
366
367         * linux-nat.c (iterate_over_lwps): Update.
368         (stop_callback): Remove parameter.
369         (stop_wait_callback, detach_callback, resume_set_callback)
370         (select_singlestep_lwp_callback, set_ignore_sigint)
371         (status_callback, resumed_callback, resume_clear_callback)
372         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
373         data parameter.
374         (linux_nat_target::detach, linux_nat_target::resume)
375         (linux_stop_and_wait_all_lwps, select_event_lwp)
376         (linux_nat_filter_event, linux_nat_wait_1)
377         (linux_nat_target::kill, linux_nat_target::stop)
378         (linux_nat_target::stop): Update.
379         (linux_nat_resume_callback): Change type.
380         (resume_stopped_resumed_lwps, count_events_callback)
381         (select_event_lwp_callback): Likewise.
382         (linux_stop_lwp, linux_nat_stop_lwp): Update.
383         * arm-linux-nat.c (struct update_registers_data): Remove.
384         (update_registers_callback): Change type.
385         (arm_linux_insert_hw_breakpoint1): Update.
386         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
387         parameter.
388         (x86_linux_dr_set_addr): Update.
389         (x86_linux_dr_set_control): Update.
390         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
391         (iterate_over_lwps): Use gdb::function_view.
392         * nat/aarch64-linux-hw-point.c (struct
393         aarch64_dr_update_callback_param): Remove.
394         (debug_reg_change_callback): Change type.
395         (aarch64_notify_debug_reg_change): Update.
396         * s390-linux-nat.c (s390_refresh_per_info): Update.
397
398 2019-03-11  Tom Tromey  <tromey@adacore.com>
399
400         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
401         redundant assignment to "this_cu".
402
403 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
404
405         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
406
407 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
408
409         * gdbtypes.c (rank_one_type_parm_set): New function extracted
410         from...
411         (rank_one_type): ... this.
412
413 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
414
415         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
416         from...
417         (rank_one_type): ... this.
418
419 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
420
421         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
422         from...
423         (rank_one_type): ... this.
424
425 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
426
427         * gdbtypes.c (rank_one_type_parm_float): New function extracted
428         from...
429         (rank_one_type): ... this.
430
431 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
432
433         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
434         from...
435         (rank_one_type): ... this.
436
437 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
438
439         * gdbtypes.c (rank_one_type_parm_range): New function extracted
440         from...
441         (rank_one_type): ... this.
442
443 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
444
445         * gdbtypes.c (rank_one_type_parm_char): New function extracted
446         from...
447         (rank_one_type): ... this.
448
449 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
450
451         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
452         from...
453         (rank_one_type): ... this.
454
455 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
456
457         * gdbtypes.c (rank_one_type_parm_int): New function extracted
458         from...
459         (rank_one_type): ... this.
460
461 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
462
463         * gdbtypes.c (rank_one_type_parm_func): New function extracted
464         from...
465         (rank_one_type): ... this.
466
467 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
468
469         * gdbtypes.c (rank_one_type_parm_array): New function extracted
470         from...
471         (rank_one_type): ... this.
472
473 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
474
475         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
476         from...
477         (rank_one_type): ... this.
478
479 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
480
481         * inferior.c (initialize_inferiors): Ensure 'help set/show print
482         inferior-events' shows the example events.
483
484 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
485
486         Support styling on native MS-Windows console
487
488         PR/24315
489         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
490         on MS-Windows if $TERM is not defined.
491
492         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
493
494         * posix-hdep.c (gdb_console_fputs):
495         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
496         functions.
497         * ui-file.h (gdb_console_fputs): Add prototype.
498
499         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
500         back to fputs only if the former returns zero.
501
502 2019-03-07  Tom Tromey  <tom@tromey.com>
503
504         * symmisc.c (print_symbol_bcache_statistics): Update.
505         (print_objfile_statistics): Update.
506         * symfile.c (allocate_symtab): Update.
507         * stabsread.c: Don't include bcache.h.
508         * psymtab.h (struct psymbol_bcache): Don't declare.
509         (class psymtab_storage) <psymbol_cache>: Now a bcache.
510         (psymbol_bcache_init, psymbol_bcache_free)
511         (psymbol_bcache_get_bcache): Don't declare.
512         * psymtab.c (struct psymbol_bcache): Remove.
513         (psymtab_storage::psymtab_storage): Update.
514         (psymtab_storage::~psymtab_storage): Update.
515         (psymbol_bcache_init, psymbol_bcache_free)
516         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
517         (add_psymbol_to_bcache): Update.
518         (allocate_psymtab): Update.
519         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
520         macro_cache>: No longer pointers.
521         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
522         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
523         * macrotab.c (macro_bcache): Update.
524         * macroexp.c: Don't include bcache.h.
525         * gdbtypes.c (check_types_worklist): Update.
526         (types_deeply_equal): Remove TRY/CATCH.  Update.
527         * elfread.c (elf_symtab_read): Update.
528         * dwarf2read.c: Don't include bcache.h.
529         * buildsym.c (buildsym_compunit::get_macro_table): Update.
530         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
531         (print_bcache_statistics, bcache_memory_used): Don't declare.
532         (struct bcache): Move from bcache.c.  Add constructor, destructor,
533         methods.  Rename all data members.
534         * bcache.c (struct bcache): Move to bcache.h.
535         (bcache::expand_hash_table): Rename from expand_hash_table.
536         (bcache): Remove.
537         (bcache::insert): Rename from bcache_full.
538         (bcache::compare): Rename from bcache_compare.
539         (bcache_xmalloc): Remove.
540         (bcache::~bcache): Rename from bcache_xfree.
541         (bcache::print_statistics): Rename from print_bcache_statistics.
542         (bcache::memory_used): Rename from bcache_memory_used.
543
544 2019-03-07  Pedro Alves  <palves@redhat.com>
545
546         * infrun.c (normal_stop): Also check for
547         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
548
549 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
550
551         * f-lang.c (value_from_host_double): Moved to...
552         * value.c (value_from_host_double): ...here.
553         * value.h (value_from_host_double): Declare.
554         * guile/scm-math.c (vlscm_convert_typed_number): Use
555         value_from_host_double.
556         (vlscm_convert_number): Likewise.
557         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
558         * python/py-value.c (convert_value_from_python): Likewise.
559
560 2019-03-06  Tom Tromey  <tom@tromey.com>
561
562         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
563
564 2019-03-06  Tom Tromey  <tom@tromey.com>
565
566         * utils.h (free_current_contents): Don't declare.
567         * utils.c (free_current_contents): Remove.
568
569 2019-03-06  Tom Tromey  <tom@tromey.com>
570
571         * top.c (quit_force): Update.
572         * main.c (captured_command_loop): Update.
573         * common/new-op.c (operator new): Update.
574         * common/common-exceptions.c (struct catcher)
575         <save_cleanup_chain>: Remove member.
576         (exceptions_state_mc_init): Update.
577         (exception_try_scope_entry): Return nullptr.
578         (exception_try_scope_exit, exception_rethrow)
579         (throw_exception_sjlj, throw_exception_cxx): Update.
580         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
581         (all_cleanups, do_cleanups, discard_cleanups)
582         (discard_final_cleanups, save_cleanups, save_final_cleanups)
583         (restore_cleanups, restore_final_cleanups): Don't declare.
584         (do_final_cleanups): Remove parameter.
585         * common/cleanups.c (cleanup_chain, make_cleanup)
586         (make_cleanup_dtor, all_cleanups, do_cleanups)
587         (discard_my_cleanups, discard_cleanups)
588         (discard_final_cleanups, save_my_cleanups, save_cleanups)
589         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
590         (null_cleanup): Remove.
591         (do_final_cleanups): Remove parameter.
592
593 2019-03-06  Tom Tromey  <tom@tromey.com>
594
595         * remote.c (remote_target::remote_parse_stop_reply): Use
596         unique_xmalloc_ptr.
597
598 2019-03-06  Tom Tromey  <tom@tromey.com>
599
600         * stabsread.c (struct stabs_field_info): Rename from field_info.
601         <list, fnlist>: Add initializers.
602         <obstack>: New member.
603         (read_member_functions, read_struct_fields, read_baseclasses):
604         Allocate on obstack.  Don't use cleanups.
605         (read_one_struct_field, read_member_functions, read_struct_fields)
606         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
607         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
608         (read_struct_type): Update.
609
610 2019-03-06  Tom Tromey  <tom@tromey.com>
611
612         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
613         * common/filestuff.h (make_cleanup_close): Don't declare.
614         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
615         Remove.
616
617 2019-03-06  Tom Tromey  <tom@tromey.com>
618
619         * solib-aix.c: Use make_scope_exit.
620
621 2019-03-06  Tom Tromey  <tom@tromey.com>
622
623         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
624         Use make_scope_exit.
625
626 2019-03-06  Tom Tromey  <tom@tromey.com>
627
628         * solib-svr4.c (disable_probes_interface): Remove parameter.
629         (svr4_handle_solib_event): Use make_scope_exit.
630
631 2019-03-06  Tom Tromey  <tom@tromey.com>
632
633         * remote.c (struct stop_reply_deleter): Remove.
634         (stop_reply_up): Update.
635         (struct stop_reply): Derive from notif_event.  Don't typedef.
636         <regcache>: Now a std::vector.
637         (stop_reply_xfree): Remove.
638         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
639         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
640         (remote_target::discard_pending_stop_replies): Use delete.
641         (remote_target::remote_parse_stop_reply): Update.
642         (remote_target::process_stop_reply): Update.
643         * remote-notif.h (struct notif_event): Add virtual destructor.
644         Remove "dtr" member.
645         (struct notif_client) <alloc_event>: Return a unique_ptr.
646         (notif_event_xfree): Don't declare.
647         (notif_event_up): New typedef.
648         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
649         (notif_event_xfree, do_notif_event_xfree): Remove.
650         (remote_notif_state_xfree): Update.
651
652 2019-03-06  Tom Tromey  <tom@tromey.com>
653
654         * infrun.c (displaced_step_clear_cleanup): Now a
655         forward_scope_exit type.
656         (displaced_step_prepare_throw): Update.
657         (displaced_step_fixup): Update.
658
659 2019-03-06  Tom Tromey  <tom@tromey.com>
660
661         * inferior.h (class inferior): Update comment.
662         * gdbthread.h (class thread_info): Update comment.
663
664 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
665             Tom Tromey  <tom@tromey.com>
666
667         * stabsread.h (struct stab_section_list): Remove.
668         (coffstab_build_psymtabs): Update.
669         * dbxread.c (symbuf_sections): Now a std::vector.
670         (sect_idx): New global.
671         (fill_symbuf): Update.
672         (coffstab_build_psymtabs): Change type of stabsects parameter.
673         Update.
674         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
675         std::vector.
676         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
677         (coff_locate_sections): Update.
678         (coff_symfile_read): Remove cleanups.  Update.
679         (init_stringtab): Add storage parameter.
680         (free_stringtab, free_stringtab_cleanup): Remove.
681         (init_lineno): Add storage parameter.
682         (free_linetab, free_linetab_cleanup): Remove.
683
684 2019-03-06  Pedro Alves  <palves@redhat.com>
685
686         * linux-fork.c (fork_info::clobber_regs): Delete.
687         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
688         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
689         comment.  Adjust.
690         (scoped_switch_fork_info::scoped_switch_fork_info)
691         (checkpoint_command, linux_fork_context): Adjust
692         fork_save_infrun_state calls.
693
694 2019-03-06  Pedro Alves  <palves@redhat.com>
695
696         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
697         (inf_has_multiple_threads): Return 'bool' and rewrite using
698         inferior_info::threads().
699
700 2019-03-06  Pedro Alves  <palves@redhat.com>
701
702         * linux-fork.c: Include <list>.
703         (fork_list): Now a std::list instance.
704         (fork_info): Add ctor, dtor, and in-class initialize all fields.
705         (forks_exist_p, find_last_fork): Adjust.
706         (new_fork): Delete.
707         (one_fork_p): New.
708         (add_fork): Adjust.
709         (free_fork): Delete, folded into fork_info::~fork_info().
710         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
711         Adjust.
712         (init_fork_list): Delete.
713         (linux_fork_killall, linux_fork_mourn_inferior)
714         (linux_fork_detach, info_checkpoints_command): Adjust.
715         (_initialize_linux_fork): No longer call init_fork_list.
716
717 2019-03-06  Pedro Alves  <palves@redhat.com>
718
719         * linux-fork.c (new_fork): New, split out of ...
720         (add_fork): ... this.  Return void.  Move "first fork" special
721         case from here, to ...
722         (checkpoint_command): ... here.
723         * linux-linux.h (add_fork): Return void.
724
725 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
726
727         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
728
729 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
730             Chris January  <chris.january@arm.com>
731             David Lecomber  <david.lecomber@arm.com>
732
733         * f-exp.y: New token, UNOP_INTRINSIC.
734         (exp): New pattern using UNOP_INTRINSIC token.
735         (f77_keywords): Add 'abs' keyword.
736         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
737         (value_from_host_double): New function.
738         (evaluate_subexp_f): Support UNOP_ABS.
739
740 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
741
742         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
743         types.
744
745 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
746
747         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
748         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
749         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
750
751 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
752
753         * f-exp.y (convert_to_kind_type): Handle more type kinds.
754
755 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
756             Chris January  <chris.january@arm.com>
757
758         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
759         * f-exp.y: Define 'KIND' token.
760         (exp): New pattern for KIND expressions.
761         (ptype): Handle types with a kind extension.
762         (direct_abs_decl): Extend to spot kind extensions.
763         (f77_keywords): Add 'kind' to the list.
764         (push_kind_type): New function.
765         (convert_to_kind_type): New function.
766         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
767         * parse.c (operator_length_standard): Likewise.
768         * parser-defs.h (enum type_pieces): Add tp_kind.
769         * std-operator.def: Add UNOP_KIND.
770
771 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
772
773         * f-exp.y (f_parse): Set yydebug.
774
775 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
776
777         * f-lang.c (evaluate_subexp_f): New function.
778         (exp_descriptor_f): New global.
779         (f_language_defn): Use exp_descriptor_f instead of
780         exp_descriptor_standard.
781
782 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
783
784         * f-exp.y (struct token): Add comments.
785         (dot_ops): Remove uppercase versions and the end marker.
786         (f77_keywords): Likewise.
787         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
788         entries in the dot_ops array are case insensitive, and use
789         strncasecmp to compare strings.  Also some whitespace cleanup in
790         this area.  Similar for the f77_keywords array, except entries in
791         this list might be case sensitive.
792
793 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
794
795         * f-exp.y (struct f77_boolean_val): Add comments.
796         (boolean_values): Remove uppercase versions, and end marker.
797         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
798         and use strncasecmp to achieve case insensitivity.  Additionally,
799         perform whitespace cleanup around this code.
800
801 2019-03-06  Tom Tromey  <tromey@adacore.com>
802
803         * remote-sim.c (gdbsim_target_open): Use result of
804         gdb_argv::release.
805
806 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
807         Dirk Schubert  <dirk.schubert@arm.com>
808         Chris January  <chris.january@arm.com>
809
810         * eval.c (evaluate_subexp_standard): Call Fortran argument
811         wrapping logic.
812         * f-lang.c (struct value): A value which can be passed into a
813         Fortran function call.
814         (fortran_argument_convert): Wrap Fortran arguments in a pointer
815         where appropriate.
816         (struct type): Value ready for a Fortran function call.
817         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
818         is needed.
819         * f-lang.h (fortran_argument_convert): Declaration.
820         (fortran_preserve_arg_pointer): Declaration.
821         * infcall.c (value_arg_coerce): Call Fortran argument logic.
822
823 2019-03-05  Tom Tromey  <tromey@adacore.com>
824
825         * python/py-prettyprint.c (print_string_repr): Remove #if.
826         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
827
828 2019-03-05  Tom Tromey  <tromey@adacore.com>
829
830         * target.c (the_dummy_target): Move later.  Change type to
831         "dummy_target".
832         (initialize_targets): Don't initialize the_dummy_target.
833
834 2019-03-05  Tom Tromey  <tromey@adacore.com>
835
836         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
837         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
838
839 2019-03-05  Tom Tromey  <tromey@adacore.com>
840
841         * windows-nat.c (windows_nat_target::attach)
842         (windows_nat_target::detach): Don't call gdb_flush.
843         * valprint.c (generic_val_print, val_print, val_print_string):
844         Don't call gdb_flush.
845         * utils.c (defaulted_query): Don't call gdb_flush.
846         * typeprint.c (print_type_scalar): Don't call gdb_flush.
847         * target.c (target_announce_detach): Don't call gdb_flush.
848         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
849         * remote.c (extended_remote_target::attach): Don't call
850         gdb_flush.
851         * procfs.c (procfs_target::detach): Don't call gdb_flush.
852         * printcmd.c (do_examine): Don't call gdb_flush.
853         (info_display_command): Don't call gdb_flush.
854         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
855         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
856         * memattr.c (info_mem_command): Don't call gdb_flush.
857         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
858         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
859         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
860         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
861         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
862         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
863         (gnu_nat_target::detach): Don't call gdb_flush.
864         * f-valprint.c (f_val_print): Don't call gdb_flush.
865         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
866         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
867         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
868         gdb_flush.
869         * c-valprint.c (c_val_print): Don't call gdb_flush.
870         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
871
872 2019-03-05  Tom Tromey  <tromey@adacore.com>
873
874         * varobj.c (update_dynamic_varobj_children): Update.
875         (install_default_visualizer): Use reset, not release.
876         * value.c (set_internalvar): Update.
877         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
878         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
879         ATTRIBUTE_UNUSED_RESULT.
880
881 2019-03-05  Tom Tromey  <tromey@adacore.com>
882
883         * remote.c (class scoped_remote_fd) <release>: Add
884         ATTRIBUTE_UNUSED_RESULT.
885
886 2019-03-05  Tom Tromey  <tromey@adacore.com>
887
888         * macroexp.c (struct macro_buffer) <release>: Add
889         ATTRIBUTE_UNUSED_RESULT.
890
891 2019-03-05  Tom Tromey  <tromey@adacore.com>
892
893         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
894         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
895         ATTRIBUTE_UNUSED_RESULT.
896
897 2019-03-05  Tom Tromey  <tromey@adacore.com>
898
899         * common/scoped_fd.h (class scoped_fd) <release>: Add
900         ATTRIBUTE_UNUSED_RESULT.
901
902 2019-03-05  Tom Tromey  <tromey@adacore.com>
903
904         * parser-defs.h (struct parser_state) <release>: Add
905         ATTRIBUTE_UNUSED_RESULT.
906
907 2019-03-05  Tom Tromey  <tromey@adacore.com>
908
909         * utils.h (class gdb_argv) <release>: Add
910         ATTRIBUTE_UNUSED_RESULT.
911         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
912
913 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
914
915         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
916         for-loop range, to avoid compiler warnings.
917
918         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
919         avoid compiler warnings about unused variables.
920
921         * NEWS: Mention end of support for native debugging on MS-Windows
922         before XP.
923
924         PR gdb/24292
925         * common/netstuff.c:
926         * gdbserver/gdbreplay.c
927         * gdbserver/remote-utils.c:
928         * ser-tcp.c:
929         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
930         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
931         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
932         'getaddrinfo' and 'freeaddrinfo' were not available before
933         Windows XP, and mingw.org's MinGW headers by default define
934         _WIN32_WINNT to 0x500.
935
936 2019-03-01  Gary Benson <gbenson@redhat.com>
937
938         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
939
940 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
941             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
942
943         PR gdb/8527
944         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
945         set_sigint_trap, clear_sigint_trap.
946
947 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
948
949         * target.c (target_detach): Clear the regcache and the
950         frame cache.
951
952 2019-02-27  Pedro Alves  <palves@redhat.com>
953
954         * utils.c (set_screen_size): When we cap the height/width sizes,
955         tweak the corresponding command variable to show "unlimited":
956
957 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
958             Pedro Alves  <palves@redhat.com>
959
960         * utils.c (set_screen_size): Reduce "infinite" rows and columns
961         before calling rl_set_screen_size.
962
963 2019-02-27  Tom Tromey  <tromey@adacore.com>
964
965         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
966         define.
967         * python/py-value.c: Remove Python 2.4 workaround.
968         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
969         workaround.
970         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
971         Python 2.4 workaround.
972         * python/python-internal.h: Remove Python 2.4 comment.
973         (Py_ssize_t): Don't define.
974         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
975         (gdb_Py_DECREF): Remove Python 2.4 workaround.
976         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
977         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
978         * python/python.c (do_start_initialization): Remove Python 2.4
979         workaround.
980         * python/py-prettyprint.c (class dummy_python_frame): Remove.
981         (print_children): Remove Python 2.4 workaround.
982         * python/py-inferior.c (buffer_procs): Remove Python 2.4
983         workaround.
984         (CHARBUFFERPROC_NAME): Remove.
985         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
986         Python 2.4 workaround.
987
988 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
989
990         * NEWS: Note minimum Python version.
991
992 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
993
994         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
995         code from these functions.  Remove corresponding ifdefs.  Use
996         Py_buffer_up instead of explicit calls to PyBuffer_Release.
997         Remove gotos and target of gotos.
998         (infpy_search_memory): Likewise.
999
1000 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1001
1002         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1003         (hppa_gdbarch_init): Don't register deleted functions with
1004         gdbarch.
1005
1006 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1007
1008         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1009         (h8300_unwind_sp): Delete.
1010         (h8300_dummy_id): Delete.
1011         (h8300_gdbarch_init): Don't register deleted functions with
1012         gdbarch.
1013
1014 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1015
1016         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1017         (ft32_unwind_pc): Delete.
1018         (ft32_unwind_sp): Delete.
1019         (ft32_gdbarch_init): Don't register deleted functions with
1020         gdbarch.
1021
1022 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1023
1024         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1025         (frv_unwind_pc): Delete.
1026         (frv_unwind_sp): Delete.
1027         (frv_gdbarch_init): Don't register deleted functions with
1028         gdbarch.
1029
1030 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1031
1032         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1033         (riscv_unwind_pc): Delete.
1034         (riscv_unwind_sp): Delete.
1035         (riscv_gdbarch_init): Don't register deleted functions with
1036         gdbarch.
1037
1038 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1039
1040         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1041         (csky_unwind_pc): Delete.
1042         (csky_unwind_sp): Delete.
1043         (csky_gdbarch_init): Don't register deleted functions with
1044         gdbarch.
1045
1046 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1047
1048         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1049         (cris_unwind_pc): Delete.
1050         (cris_unwind_sp): Delete.
1051         (cris_gdbarch_init): Don't register deleted functions with
1052         gdbarch.
1053
1054 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1055
1056         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1057         (bfin_unwind_pc): Delete.
1058         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1059
1060 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1061
1062         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1063         (arm_unwind_pc): Delete.
1064         (arm_unwind_sp): Delete.
1065         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1066
1067 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1068
1069         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1070         (arc_unwind_pc): Delete.
1071         (arc_unwind_sp): Delete.
1072         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1073
1074 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1075
1076         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1077         (alpha_unwind_pc): Delete.
1078         (alpha_gdbarch_init): Don't register deleted functions with
1079         gdbarch.
1080
1081 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1082
1083         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1084         (aarch64_unwind_pc): Delete.
1085         (aarch64_unwind_sp): Delete.
1086         (aarch64_gdbarch_init): Don't register deleted functions with
1087         gdbarch.
1088
1089 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1090
1091         * gdbtypes.c (type_align): Don't consider static members when
1092         computing structure alignment.
1093
1094 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1095
1096         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1097         return 0 for other types.
1098         * arch-utils.c (default_type_align): Always return 0.
1099         * gdbarch.h: Regenerate.
1100         * gdbarch.sh (type_align): Extend comment.
1101         * gdbtypes.c (type_align): Add additional comments, always call
1102         gdbarch_type_align before applying the default rules.
1103         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1104         generic code will then apply a suitable default.
1105         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1106         types, return 0 for other types.
1107
1108 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1109
1110         * NEWS: Create a new section for the next release branch.
1111         Rename the section of the current branch, now that it has
1112         been cut.
1113
1114 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1115
1116         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1117         * version.in: Bump version to 8.3.50.DATE-git.
1118
1119 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1120
1121         * aix-thread.c (ptid_cmp): Remove unused variable.
1122         (get_signaled_thread): Likewise.
1123         (store_regs_user_thread): Likewise.
1124         (store_regs_kernel_thread): Likewise.
1125         (fetch_regs_kernel_thread): Remove shadowed variable.
1126
1127 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1128
1129         * features/riscv/32bit-cpu.xml: Add register numbers.
1130         * features/riscv/32bit-fpu.c: Regenerate.
1131         * features/riscv/32bit-fpu.xml: Add register numbers.
1132         * features/riscv/64bit-cpu.xml: Add register numbers.
1133         * features/riscv/64bit-fpu.c: Regenerate.
1134         * features/riscv/64bit-fpu.xml: Add register numbers.
1135
1136 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1137
1138         * NEWS: Mention two argument form of gdb.Value constructor.
1139         * python/py-value.c (convert_buffer_and_type_to_value): New
1140         function.
1141         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1142         Add support for handling an optional second argument.  Call
1143         convert_buffer_and_type_to_value as appropriate.
1144         * python/python-internal.h (Py_buffer_deleter): New struct.
1145         (Py_buffer_up): New typedef.
1146
1147 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1148
1149         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1150         instead of releasing ownership.
1151
1152 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1153
1154         * dwarf2read.c (open_and_init_dwp_file): Call
1155         elf_numsections instead of bfd_count_sections to initialize
1156         dwp_file->num_sections.
1157
1158 2019-02-25  Tom Tromey  <tromey@adacore.com>
1159
1160         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1161
1162 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1163
1164         * gcore.in: Add '--readnever' option when invoking GDB.
1165
1166 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1167
1168         * MAINTAINERS: Update my email address.
1169
1170 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1171
1172         * build-id.c (build_id_to_debug_bfd_1): New function.
1173         (build_id_to_debug_bfd): Look for separate debug file in
1174         sysroot.
1175
1176 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1177
1178         * gdbarch.sh: Update the copyright year range that is placed into
1179         generated files.
1180
1181 2019-02-22  Keith Seitz  <keiths@redhat.com>
1182
1183         PR symtab/23853
1184         * linespec.c (create_sals_line_offset): Search for the default
1185         symtab's filename instead of its fullname.
1186
1187 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1188
1189         * NEWS: Update style defaults.
1190
1191 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1192
1193         * main.c (captured_main_1): Disable styling in batch mode.
1194
1195 2019-02-20  Tom Tromey  <tom@tromey.com>
1196
1197         * symtab.c (symtab_symbol_info): Fix typos.
1198
1199 2019-02-20  Tom Tromey  <tromey@adacore.com>
1200
1201         * findcmd.c (_initialize_mem_search): Use upper case for
1202         metasyntactic variables.
1203
1204 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1205
1206         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1207         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1208
1209 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1210
1211         * top.h (source_file_name): Change to std::string.
1212         * top.c (source_file_name): Likewise.
1213         (command_line_input): Adjust.
1214         * cli/cli-script.c (script_from_file): Adjust.
1215
1216 2019-02-19  Tom Tromey  <tromey@adacore.com>
1217
1218         * ravenscar-thread.c
1219         (ravenscar_thread_target::update_thread_list): Don't call
1220         ada_build_task_list.
1221         * ada-lang.h (ada_build_task_list): Don't declare.
1222         * ada-tasks.c (struct ada_tasks_inferior_data)
1223         <task_list_valid_p>: Now bool.
1224         (read_known_tasks, ada_task_list_changed)
1225         (ada_tasks_invalidate_inferior_data): Update.
1226         (read_known_tasks_array): Return bool.
1227         (read_known_tasks_list): Likewise.
1228         (read_known_tasks): Return void.
1229         (ada_build_task_list): Now static.
1230
1231 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1232
1233         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1234         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1235
1236 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1237
1238         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1239         variant for ada_tasks_pspace_data_handle and
1240         ada_tasks_inferior_data_handle.
1241         (ada_tasks_pspace_data_cleanup): New function.
1242         (ada_tasks_inferior_data_cleanup): New function.
1243
1244 2019-02-17  Tom Tromey  <tom@tromey.com>
1245
1246         * macrotab.h (macro_source_fullname): Return a std::string.
1247         * macrotab.c (macro_include, check_for_redefinition)
1248         (macro_undef, macro_lookup_definition, foreach_macro)
1249         (foreach_macro_in_scope): Update.
1250         (macro_source_fullname): Return a std::string.
1251         * macrocmd.c (show_pp_source_pos): Update.
1252
1253 2019-02-17  Tom Tromey  <tom@tromey.com>
1254
1255         * macrocmd.c (show_pp_source_pos): Style the file names.
1256
1257 2019-02-17  Tom Tromey  <tom@tromey.com>
1258
1259         PR tui/24197:
1260         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1261
1262 2019-02-17  Tom Tromey  <tom@tromey.com>
1263
1264         * ada-lang.c (user_select_syms): Use filtered printing.
1265         * utils.c (wrap_style): New global.
1266         (desired_style): Remove.
1267         (emit_style_escape): Add stream parameter.
1268         (set_output_style, reset_terminal_style, prompt_for_continue):
1269         Update.
1270         (flush_wrap_buffer): Only flush gdb_stdout.
1271         (wrap_here): Set wrap_style.
1272         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1273         treat escape sequences as a character.  Change when wrap buffer is
1274         flushed.
1275         (fputs_styled): Do not set the output style when the default is
1276         requested.
1277         * ui-style.h (struct ui_file_style) <is_default>: New method.
1278         * source.c (print_source_lines_base): Emit escape sequences in one
1279         piece.
1280
1281 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1282
1283         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1284         integers and enumeration types.
1285
1286 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1287
1288         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1289         instead of lookup_symbol_in_language
1290         (do_exact_match): New function.
1291         (ada_get_symbol_name_matcher): Return do_exact_match when
1292         doing a verbatim match.
1293
1294 2019-02-15  Tom Tromey  <tromey@adacore.com>
1295
1296         * ravenscar-thread.c (ravenscar_thread_target::resume)
1297         (ravenscar_thread_target::wait): Special case wildcard requests.
1298
1299 2019-02-15  Tom Tromey  <tromey@adacore.com>
1300
1301         * ravenscar-thread.c (base_ptid): Remove.
1302         (struct ravenscar_thread_target) <close>: New method.
1303         <m_base_ptid>: New member.
1304         <update_inferior_ptid, active_task, task_is_currently_active,
1305         runtime_initialized>: Declare methods.
1306         <ravenscar_thread_target>: Add constructor.
1307         (ravenscar_thread_target::task_is_currently_active)
1308         (ravenscar_thread_target::update_inferior_ptid)
1309         (ravenscar_runtime_initialized): Rename.  Now methods.
1310         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1311         (ravenscar_thread_target::update_thread_list): Update.
1312         (ravenscar_thread_target::active_task): Now method.
1313         (ravenscar_thread_target::store_registers)
1314         (ravenscar_thread_target::prepare_to_store)
1315         (ravenscar_thread_target::prepare_to_store)
1316         (ravenscar_thread_target::mourn_inferior): Update.
1317         (ravenscar_inferior_created): Use "new" to create target.
1318         (ravenscar_thread_target::get_ada_task_ptid): Update.
1319         (_initialize_ravenscar): Don't initialize base_ptid.
1320         (ravenscar_ops): Remove global.
1321
1322 2019-02-15  Tom Tromey  <tromey@adacore.com>
1323
1324         * target.h (push_target): Declare new overload.
1325         * target.c (push_target): New overload, taking an rvalue reference.
1326         * remote.c (remote_target::open_1): Use push_target overload.
1327         * corelow.c (core_target_open): Use push_target overload.
1328
1329 2019-02-15  Tom Tromey  <tromey@adacore.com>
1330
1331         * ravenscar-thread.c (is_ravenscar_task)
1332         (ravenscar_task_is_currently_active): Return bool.
1333         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1334         (_initialize_ravenscar): Remove "(void)".
1335         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1336         Return bool.
1337
1338 2019-02-15  Tom Tromey  <tromey@adacore.com>
1339
1340         * ravenscar-thread.c (ravenscar_runtime_initializer)
1341         (has_ravenscar_runtime, get_running_thread_id)
1342         (ravenscar_thread_target::resume): Fix indentation.
1343
1344 2019-02-15  Tom Tromey  <tromey@adacore.com>
1345
1346         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1347         from ravenscar_arch_ops.
1348         (sparc_ravenscar_ops::fetch_registers)
1349         (sparc_ravenscar_ops::store_registers): Now methods.
1350         (sparc_ravenscar_prepare_to_store): Remove.
1351         (sparc_ravenscar_ops): Redefine.
1352         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1353         methods and destructor.  Remove members.
1354         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1355         (ravenscar_thread_target::store_registers)
1356         (ravenscar_thread_target::prepare_to_store): Update.
1357         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1358         Remove.
1359         (struct ppc_ravenscar_powerpc_ops): Derive from
1360         ravenscar_arch_ops.
1361         (ppc_ravenscar_powerpc_ops::fetch_registers)
1362         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1363         (ppc_ravenscar_powerpc_ops): Redefine.
1364         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1365         (ppc_ravenscar_e500_ops::fetch_registers)
1366         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1367         (ppc_ravenscar_e500_ops): Redefine.
1368         * aarch64-ravenscar-thread.c
1369         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1370         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1371         (aarch64_ravenscar_fetch_registers)
1372         (aarch64_ravenscar_store_registers): Now methods.
1373         (aarch64_ravenscar_ops): Redefine.
1374
1375 2019-02-15  Tom Tromey  <tromey@adacore.com>
1376
1377         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1378         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1379         (ravenscar_thread_target::stopped_by_watchpoint)
1380         (ravenscar_thread_target::stopped_data_address)
1381         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1382
1383 2019-02-15  Tom Tromey  <tromey@adacore.com>
1384
1385         * ravenscar-thread.c: Fix some typos.
1386
1387 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1388             Tom Tromey  <tromey@adacore.com>
1389
1390         * ada-lang.c (ada_exception_sal): Change addr_string to a
1391         std::string.
1392         (create_ada_exception_catchpoint): Update.
1393
1394 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1395             Tom Tromey  <tromey@adacore.com>
1396
1397         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1398         (bp_location_ops): Remove.
1399         (base_breakpoint_allocate_location): Update.
1400         (free_bp_location): Update.
1401         * ada-lang.c (class ada_catchpoint_location)
1402         <ada_catchpoint_location>: Remove ops parameter.
1403         (ada_catchpoint_location_dtor): Remove.
1404         (ada_catchpoint_location_ops): Remove.
1405         (allocate_location_exception): Update.
1406         * breakpoint.h (struct bp_location_ops): Remove.
1407         (class bp_location) <bp_location>: Remove bp_location_ops
1408         parameter.
1409         <~bp_location>: Add destructor.
1410         <ops>: Remove.
1411
1412 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1413             Pedro Alves  <palves@redhat.com>
1414
1415         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1416         'PATH_MAX'.
1417
1418 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1419             Samuel Thibault  <samuel.thibault@gnu.org>
1420             Thomas Schwinge  <thomas@codesourcery.com>
1421
1422         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1423         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1424
1425 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1426
1427         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1428         (check_empty): Use "const char *".
1429
1430         * gnu-nat.c (gnu_nat_target::detach): Instead of
1431         'detach_inferior (pid)' call
1432         'detach_inferior (find_inferior_pid (pid))'.
1433
1434         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1435         'nat/fork-inferior.o'.
1436         * gnu-nat.c: #include "nat/fork-inferior.h".
1437
1438         * gnu-nat.c (gnu_nat_target::detach): Instead of
1439         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1440         * gnu-nat.h: #include "inf-child.h".
1441         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1442         'i386_gnu_nat_target::fetch_registers'.
1443         (gnu_store_registers): Rename/move to
1444         'i386_gnu_nat_target::store_registers'.
1445
1446         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1447         * gnu-nat.h (mach_thread_info): New function.
1448         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1449
1450         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1451
1452 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1453
1454         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1455
1456 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1457
1458         * windows-nat.c (windows_add_thread): Add new parameter
1459         "main_thread_p" with default value set to false.  Update
1460         function documentation as well as all callers.
1461         (windows_delete_thread): Likewise.
1462         (fake_create_process): Update call to windows_add_thread.
1463         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1464         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1465         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1466         call to windows_delete_thread.
1467
1468 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1469
1470         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1471
1472 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1473
1474         * symfile.c (find_separate_debug_file): Use canonical path of
1475         sysroot with child_path instead of gdb_sysroot if it is valid.
1476
1477 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1478
1479         * symfile.c (find_separate_debug_file): Use child_path to
1480         determine if an object file is under a sysroot.
1481
1482 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1483
1484         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1485         unittests/child-path-selftests.c.
1486         * common/pathstuff.c (child_path): New function.
1487         * common/pathstuff.h (child_path): New prototype.
1488         * unittests/child-path-selftests.c: New file.
1489
1490 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1491
1492         * symfile.c (find_separate_debug_file): Look for separate debug
1493         files in debug directories under the sysroot.
1494
1495 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1496
1497         * symtab.h (struct minimal_symbol data_p): New const method.
1498         (struct minimal_symbol text_p): Likewise.
1499         * symtab.c (output_source_filename): Use file name style
1500         to print file name.
1501         (print_symbol_info): Likewise.
1502         (print_msymbol_info): Use address style to print addresses.
1503         Use function name style to print executable text symbols.
1504         (expand_symtab_containing_pc): Use data_p.
1505         (find_pc_sect_compunit_symtab): Likewise.
1506
1507 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1508
1509         * breakpoint.c (describe_other_breakpoints): Use address style
1510         to print addresses.
1511         (say_where): Likewise.
1512
1513 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1514
1515         * ada-typeprint.c (print_func_type): Print function name
1516         style to print function name.
1517         * c-typeprint.c (c_print_type_1): Likewise.
1518
1519 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
1520
1521         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
1522         for execve.
1523
1524 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1525
1526         * c-exp.y (direct_abs_decl): Use emplace_back to record the
1527         type_stack.
1528
1529 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
1530
1531         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
1532         TYPE_CODE_REF types.
1533
1534 2019-02-08  Jim Wilson  <jimw@sifive.com>
1535
1536         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
1537         (riscv_linux_fregset): New.
1538         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
1539
1540 2019-02-07  Tom Tromey  <tom@tromey.com>
1541
1542         * thread.c (thread_cancel_execution_command): Update.
1543         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
1544         methods.
1545         (struct thread_fsm_ops): Remove.
1546         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
1547         (thread_fsm_should_stop, thread_fsm_return_value)
1548         (thread_fsm_set_finished, thread_fsm_finished_p)
1549         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
1550         Don't declare.
1551         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
1552         * infrun.c (clear_proceed_status_thread)
1553         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
1554         (print_stop_event): Update.
1555         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
1556         Add constructor.
1557         (step_command_fsm_ops): Remove.
1558         (new_step_command_fsm): Remove.
1559         (step_1): Update.
1560         (step_command_fsm::should_stop): Rename from
1561         step_command_fsm_should_stop.
1562         (step_command_fsm::clean_up): Rename from
1563         step_command_fsm_clean_up.
1564         (step_command_fsm::do_async_reply_reason): Rename from
1565         step_command_fsm_async_reply_reason.
1566         (struct until_next_fsm): Inherit from thread_fsm.  Add
1567         constructor.
1568         (until_next_fsm_ops): Remove.
1569         (new_until_next_fsm): Remove.
1570         (until_next_fsm::should_stop): Rename from
1571         until_next_fsm_should_stop.
1572         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
1573         (until_next_fsm::do_async_reply_reason): Rename from
1574         until_next_fsm_async_reply_reason.
1575         (struct finish_command_fsm): Inherit from thread_fsm.  Add
1576         constructor.  Change type of breakpoint.
1577         (finish_command_fsm_ops): Remove.
1578         (new_finish_command_fsm): Remove.
1579         (finish_command_fsm::should_stop): Rename from
1580         finish_command_fsm_should_stop.
1581         (finish_command_fsm::clean_up): Rename from
1582         finish_command_fsm_clean_up.
1583         (finish_command_fsm::return_value): Rename from
1584         finish_command_fsm_return_value.
1585         (finish_command_fsm::do_async_reply_reason): Rename from
1586         finish_command_fsm_async_reply_reason.
1587         (finish_command): Update.
1588         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
1589         Add constructor.
1590         (call_thread_fsm_ops): Remove.
1591         (call_thread_fsm::call_thread_fsm): Rename from
1592         new_call_thread_fsm.
1593         (call_thread_fsm::should_stop): Rename from
1594         call_thread_fsm_should_stop.
1595         (call_thread_fsm::should_notify_stop): Rename from
1596         call_thread_fsm_should_notify_stop.
1597         (run_inferior_call, call_function_by_hand_dummy): Update.
1598         * cli/cli-interp.c (should_print_stop_to_console): Update.
1599         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
1600         Add constructor.  Change type of location_breakpoint,
1601         caller_breakpoint.
1602         (until_break_fsm_ops): Remove.
1603         (new_until_break_fsm): Remove.
1604         (until_break_fsm::should_stop): Rename from
1605         until_break_fsm_should_stop.
1606         (until_break_fsm::clean_up): Rename from
1607         until_break_fsm_clean_up.
1608         (until_break_fsm::do_async_reply_reason): Rename from
1609         until_break_fsm_async_reply_reason.
1610         (until_break_command): Update.
1611         * thread-fsm.c: Remove.
1612         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
1613
1614 2019-02-07  Tom Tromey  <tom@tromey.com>
1615
1616         * yy-remap.h: Add include guard.
1617         * xtensa-tdep.h: Add include guard.
1618         * xcoffread.h: Rename include guard.
1619         * varobj-iter.h: Add include guard.
1620         * tui/tui.h: Rename include guard.
1621         * tui/tui-winsource.h: Rename include guard.
1622         * tui/tui-wingeneral.h: Rename include guard.
1623         * tui/tui-windata.h: Rename include guard.
1624         * tui/tui-win.h: Rename include guard.
1625         * tui/tui-stack.h: Rename include guard.
1626         * tui/tui-source.h: Rename include guard.
1627         * tui/tui-regs.h: Rename include guard.
1628         * tui/tui-out.h: Rename include guard.
1629         * tui/tui-layout.h: Rename include guard.
1630         * tui/tui-io.h: Rename include guard.
1631         * tui/tui-hooks.h: Rename include guard.
1632         * tui/tui-file.h: Rename include guard.
1633         * tui/tui-disasm.h: Rename include guard.
1634         * tui/tui-data.h: Rename include guard.
1635         * tui/tui-command.h: Rename include guard.
1636         * tic6x-tdep.h: Add include guard.
1637         * target/waitstatus.h: Rename include guard.
1638         * target/wait.h: Rename include guard.
1639         * target/target.h: Rename include guard.
1640         * target/resume.h: Rename include guard.
1641         * target-float.h: Rename include guard.
1642         * stabsread.h: Add include guard.
1643         * rs6000-tdep.h: Add include guard.
1644         * riscv-fbsd-tdep.h: Add include guard.
1645         * regformats/regdef.h: Rename include guard.
1646         * record.h: Rename include guard.
1647         * python/python.h: Rename include guard.
1648         * python/python-internal.h: Rename include guard.
1649         * python/py-stopevent.h: Rename include guard.
1650         * python/py-ref.h: Rename include guard.
1651         * python/py-record.h: Rename include guard.
1652         * python/py-record-full.h: Rename include guard.
1653         * python/py-record-btrace.h: Rename include guard.
1654         * python/py-instruction.h: Rename include guard.
1655         * python/py-events.h: Rename include guard.
1656         * python/py-event.h: Rename include guard.
1657         * procfs.h: Add include guard.
1658         * proc-utils.h: Add include guard.
1659         * p-lang.h: Add include guard.
1660         * or1k-tdep.h: Rename include guard.
1661         * observable.h: Rename include guard.
1662         * nto-tdep.h: Rename include guard.
1663         * nat/x86-linux.h: Rename include guard.
1664         * nat/x86-linux-dregs.h: Rename include guard.
1665         * nat/x86-gcc-cpuid.h: Add include guard.
1666         * nat/x86-dregs.h: Rename include guard.
1667         * nat/x86-cpuid.h: Rename include guard.
1668         * nat/ppc-linux.h: Rename include guard.
1669         * nat/mips-linux-watch.h: Rename include guard.
1670         * nat/linux-waitpid.h: Rename include guard.
1671         * nat/linux-ptrace.h: Rename include guard.
1672         * nat/linux-procfs.h: Rename include guard.
1673         * nat/linux-osdata.h: Rename include guard.
1674         * nat/linux-nat.h: Rename include guard.
1675         * nat/linux-namespaces.h: Rename include guard.
1676         * nat/linux-btrace.h: Rename include guard.
1677         * nat/glibc_thread_db.h: Rename include guard.
1678         * nat/gdb_thread_db.h: Rename include guard.
1679         * nat/gdb_ptrace.h: Rename include guard.
1680         * nat/fork-inferior.h: Rename include guard.
1681         * nat/amd64-linux-siginfo.h: Rename include guard.
1682         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
1683         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
1684         * nat/aarch64-linux.h: Rename include guard.
1685         * nat/aarch64-linux-hw-point.h: Rename include guard.
1686         * mn10300-tdep.h: Add include guard.
1687         * mips-linux-tdep.h: Add include guard.
1688         * mi/mi-parse.h: Rename include guard.
1689         * mi/mi-out.h: Rename include guard.
1690         * mi/mi-main.h: Rename include guard.
1691         * mi/mi-interp.h: Rename include guard.
1692         * mi/mi-getopt.h: Rename include guard.
1693         * mi/mi-console.h: Rename include guard.
1694         * mi/mi-common.h: Rename include guard.
1695         * mi/mi-cmds.h: Rename include guard.
1696         * mi/mi-cmd-break.h: Rename include guard.
1697         * m2-lang.h: Add include guard.
1698         * location.h: Rename include guard.
1699         * linux-record.h: Rename include guard.
1700         * linux-nat.h: Add include guard.
1701         * linux-fork.h: Add include guard.
1702         * i386-darwin-tdep.h: Rename include guard.
1703         * hppa-linux-offsets.h: Add include guard.
1704         * guile/guile.h: Rename include guard.
1705         * guile/guile-internal.h: Rename include guard.
1706         * gnu-nat.h: Rename include guard.
1707         * gdb-stabs.h: Rename include guard.
1708         * frv-tdep.h: Add include guard.
1709         * f-lang.h: Add include guard.
1710         * event-loop.h: Add include guard.
1711         * darwin-nat.h: Rename include guard.
1712         * cp-abi.h: Rename include guard.
1713         * config/sparc/nm-sol2.h: Rename include guard.
1714         * config/nm-nto.h: Rename include guard.
1715         * config/nm-linux.h: Add include guard.
1716         * config/i386/nm-i386gnu.h: Rename include guard.
1717         * config/djgpp/nl_types.h: Rename include guard.
1718         * config/djgpp/langinfo.h: Rename include guard.
1719         * compile/gcc-cp-plugin.h: Add include guard.
1720         * compile/gcc-c-plugin.h: Add include guard.
1721         * compile/compile.h: Rename include guard.
1722         * compile/compile-object-run.h: Rename include guard.
1723         * compile/compile-object-load.h: Rename include guard.
1724         * compile/compile-internal.h: Rename include guard.
1725         * compile/compile-cplus.h: Rename include guard.
1726         * compile/compile-c.h: Rename include guard.
1727         * common/xml-utils.h: Rename include guard.
1728         * common/x86-xstate.h: Rename include guard.
1729         * common/version.h: Rename include guard.
1730         * common/vec.h: Rename include guard.
1731         * common/tdesc.h: Rename include guard.
1732         * common/selftest.h: Rename include guard.
1733         * common/scoped_restore.h: Rename include guard.
1734         * common/scoped_mmap.h: Rename include guard.
1735         * common/scoped_fd.h: Rename include guard.
1736         * common/safe-iterator.h: Rename include guard.
1737         * common/run-time-clock.h: Rename include guard.
1738         * common/refcounted-object.h: Rename include guard.
1739         * common/queue.h: Rename include guard.
1740         * common/ptid.h: Rename include guard.
1741         * common/print-utils.h: Rename include guard.
1742         * common/preprocessor.h: Rename include guard.
1743         * common/pathstuff.h: Rename include guard.
1744         * common/observable.h: Rename include guard.
1745         * common/netstuff.h: Rename include guard.
1746         * common/job-control.h: Rename include guard.
1747         * common/host-defs.h: Rename include guard.
1748         * common/gdb_wait.h: Rename include guard.
1749         * common/gdb_vecs.h: Rename include guard.
1750         * common/gdb_unlinker.h: Rename include guard.
1751         * common/gdb_unique_ptr.h: Rename include guard.
1752         * common/gdb_tilde_expand.h: Rename include guard.
1753         * common/gdb_sys_time.h: Rename include guard.
1754         * common/gdb_string_view.h: Rename include guard.
1755         * common/gdb_splay_tree.h: Rename include guard.
1756         * common/gdb_setjmp.h: Rename include guard.
1757         * common/gdb_ref_ptr.h: Rename include guard.
1758         * common/gdb_optional.h: Rename include guard.
1759         * common/gdb_locale.h: Rename include guard.
1760         * common/gdb_assert.h: Rename include guard.
1761         * common/filtered-iterator.h: Rename include guard.
1762         * common/filestuff.h: Rename include guard.
1763         * common/fileio.h: Rename include guard.
1764         * common/environ.h: Rename include guard.
1765         * common/common-utils.h: Rename include guard.
1766         * common/common-types.h: Rename include guard.
1767         * common/common-regcache.h: Rename include guard.
1768         * common/common-inferior.h: Rename include guard.
1769         * common/common-gdbthread.h: Rename include guard.
1770         * common/common-exceptions.h: Rename include guard.
1771         * common/common-defs.h: Rename include guard.
1772         * common/common-debug.h: Rename include guard.
1773         * common/cleanups.h: Rename include guard.
1774         * common/buffer.h: Rename include guard.
1775         * common/btrace-common.h: Rename include guard.
1776         * common/break-common.h: Rename include guard.
1777         * cli/cli-utils.h: Rename include guard.
1778         * cli/cli-style.h: Rename include guard.
1779         * cli/cli-setshow.h: Rename include guard.
1780         * cli/cli-script.h: Rename include guard.
1781         * cli/cli-interp.h: Rename include guard.
1782         * cli/cli-decode.h: Rename include guard.
1783         * cli/cli-cmds.h: Rename include guard.
1784         * charset-list.h: Add include guard.
1785         * buildsym-legacy.h: Rename include guard.
1786         * bfin-tdep.h: Add include guard.
1787         * ax.h: Rename include guard.
1788         * arm-linux-tdep.h: Add include guard.
1789         * arm-fbsd-tdep.h: Add include guard.
1790         * arch/xtensa.h: Rename include guard.
1791         * arch/tic6x.h: Add include guard.
1792         * arch/i386.h: Add include guard.
1793         * arch/arm.h: Rename include guard.
1794         * arch/arm-linux.h: Rename include guard.
1795         * arch/arm-get-next-pcs.h: Rename include guard.
1796         * arch/amd64.h: Add include guard.
1797         * arch/aarch64-insn.h: Rename include guard.
1798         * arch-utils.h: Rename include guard.
1799         * annotate.h: Add include guard.
1800         * amd64-darwin-tdep.h: Rename include guard.
1801         * aarch64-linux-tdep.h: Add include guard.
1802         * aarch64-fbsd-tdep.h: Add include guard.
1803         * aarch32-linux-nat.h: Add include guard.
1804
1805 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1806
1807         * macrotab.c (macro_define_internal): New function that
1808         factorizes macro_define_object_internal and macro_define_function
1809         code.
1810         (macro_define_object_internal): Use macro_define_internal.
1811         (macro_define_function): Likewise.
1812
1813 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1814
1815         * macrocmd.c (extract_identifier): Return
1816         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
1817         callers.
1818
1819 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1820
1821         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1822
1823 2019-02-05  Tom Tromey  <tom@tromey.com>
1824
1825         * target.c (target_stack::unpush): Move assertion earlier.
1826
1827 2019-01-30  Tom Tromey  <tom@tromey.com>
1828
1829         PR python/23615:
1830         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1831         (gdbpy_parse_and_eval): Likewise.
1832         * python/python-internal.h (gdbpy_allow_threads): New class.
1833
1834 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1835
1836         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1837         (aarch64_fbsd_fpregmap): Move earlier.
1838         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1839         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1840         instead of individual calls to trad_frame_set_reg_addr.
1841         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1842         earlier.
1843         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1844         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1845         instead of individual calls to trad_frame_set_reg_addr.
1846
1847 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1848
1849         * CONTRIBUTE: Replace contribution list with wiki link.
1850
1851 2019-01-25  Tom Tromey  <tom@tromey.com>
1852
1853         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1854
1855 2019-01-25  Tom Tromey  <tom@tromey.com>
1856
1857         * xtensa-linux-nat.c: Fix common/ includes.
1858         * xml-support.h: Fix common/ includes.
1859         * xml-support.c: Fix common/ includes.
1860         * x86-linux-nat.c: Fix common/ includes.
1861         * windows-nat.c: Fix common/ includes.
1862         * varobj.h: Fix common/ includes.
1863         * varobj.c: Fix common/ includes.
1864         * value.c: Fix common/ includes.
1865         * valops.c: Fix common/ includes.
1866         * utils.c: Fix common/ includes.
1867         * unittests/xml-utils-selftests.c: Fix common/ includes.
1868         * unittests/utils-selftests.c: Fix common/ includes.
1869         * unittests/unpack-selftests.c: Fix common/ includes.
1870         * unittests/tracepoint-selftests.c: Fix common/ includes.
1871         * unittests/style-selftests.c: Fix common/ includes.
1872         * unittests/string_view-selftests.c: Fix common/ includes.
1873         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1874         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1875         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1876         * unittests/rsp-low-selftests.c: Fix common/ includes.
1877         * unittests/parse-connection-spec-selftests.c: Fix common/
1878         includes.
1879         * unittests/optional-selftests.c: Fix common/ includes.
1880         * unittests/offset-type-selftests.c: Fix common/ includes.
1881         * unittests/observable-selftests.c: Fix common/ includes.
1882         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1883         * unittests/memrange-selftests.c: Fix common/ includes.
1884         * unittests/memory-map-selftests.c: Fix common/ includes.
1885         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1886         * unittests/function-view-selftests.c: Fix common/ includes.
1887         * unittests/environ-selftests.c: Fix common/ includes.
1888         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1889         * unittests/common-utils-selftests.c: Fix common/ includes.
1890         * unittests/cli-utils-selftests.c: Fix common/ includes.
1891         * unittests/array-view-selftests.c: Fix common/ includes.
1892         * ui-file.c: Fix common/ includes.
1893         * tui/tui-io.c: Fix common/ includes.
1894         * tracepoint.h: Fix common/ includes.
1895         * tracepoint.c: Fix common/ includes.
1896         * tracefile-tfile.c: Fix common/ includes.
1897         * top.h: Fix common/ includes.
1898         * top.c: Fix common/ includes.
1899         * thread.c: Fix common/ includes.
1900         * target/waitstatus.h: Fix common/ includes.
1901         * target/waitstatus.c: Fix common/ includes.
1902         * target.h: Fix common/ includes.
1903         * target.c: Fix common/ includes.
1904         * target-memory.c: Fix common/ includes.
1905         * target-descriptions.c: Fix common/ includes.
1906         * symtab.h: Fix common/ includes.
1907         * symfile.c: Fix common/ includes.
1908         * stap-probe.c: Fix common/ includes.
1909         * spu-linux-nat.c: Fix common/ includes.
1910         * sparc-nat.c: Fix common/ includes.
1911         * source.c: Fix common/ includes.
1912         * solib.c: Fix common/ includes.
1913         * solib-target.c: Fix common/ includes.
1914         * ser-unix.c: Fix common/ includes.
1915         * ser-tcp.c: Fix common/ includes.
1916         * ser-pipe.c: Fix common/ includes.
1917         * ser-base.c: Fix common/ includes.
1918         * selftest-arch.c: Fix common/ includes.
1919         * s12z-tdep.c: Fix common/ includes.
1920         * rust-exp.y: Fix common/ includes.
1921         * rs6000-aix-tdep.c: Fix common/ includes.
1922         * riscv-tdep.c: Fix common/ includes.
1923         * remote.c: Fix common/ includes.
1924         * remote-notif.h: Fix common/ includes.
1925         * remote-fileio.h: Fix common/ includes.
1926         * remote-fileio.c: Fix common/ includes.
1927         * regcache.h: Fix common/ includes.
1928         * regcache.c: Fix common/ includes.
1929         * record-btrace.c: Fix common/ includes.
1930         * python/python.c: Fix common/ includes.
1931         * python/py-type.c: Fix common/ includes.
1932         * python/py-inferior.c: Fix common/ includes.
1933         * progspace.h: Fix common/ includes.
1934         * producer.c: Fix common/ includes.
1935         * procfs.c: Fix common/ includes.
1936         * proc-api.c: Fix common/ includes.
1937         * printcmd.c: Fix common/ includes.
1938         * ppc-linux-nat.c: Fix common/ includes.
1939         * parser-defs.h: Fix common/ includes.
1940         * osdata.c: Fix common/ includes.
1941         * obsd-nat.c: Fix common/ includes.
1942         * nat/x86-linux.c: Fix common/ includes.
1943         * nat/x86-linux-dregs.c: Fix common/ includes.
1944         * nat/x86-dregs.h: Fix common/ includes.
1945         * nat/x86-dregs.c: Fix common/ includes.
1946         * nat/ppc-linux.c: Fix common/ includes.
1947         * nat/mips-linux-watch.h: Fix common/ includes.
1948         * nat/mips-linux-watch.c: Fix common/ includes.
1949         * nat/linux-waitpid.c: Fix common/ includes.
1950         * nat/linux-ptrace.h: Fix common/ includes.
1951         * nat/linux-ptrace.c: Fix common/ includes.
1952         * nat/linux-procfs.c: Fix common/ includes.
1953         * nat/linux-personality.c: Fix common/ includes.
1954         * nat/linux-osdata.c: Fix common/ includes.
1955         * nat/linux-namespaces.c: Fix common/ includes.
1956         * nat/linux-btrace.h: Fix common/ includes.
1957         * nat/linux-btrace.c: Fix common/ includes.
1958         * nat/fork-inferior.c: Fix common/ includes.
1959         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1960         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1961         * nat/aarch64-linux.c: Fix common/ includes.
1962         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1963         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1964         * namespace.h: Fix common/ includes.
1965         * mips-linux-tdep.c: Fix common/ includes.
1966         * minsyms.c: Fix common/ includes.
1967         * mi/mi-parse.h: Fix common/ includes.
1968         * mi/mi-main.c: Fix common/ includes.
1969         * mi/mi-cmd-env.c: Fix common/ includes.
1970         * memrange.h: Fix common/ includes.
1971         * memattr.c: Fix common/ includes.
1972         * maint.h: Fix common/ includes.
1973         * maint.c: Fix common/ includes.
1974         * main.c: Fix common/ includes.
1975         * machoread.c: Fix common/ includes.
1976         * location.c: Fix common/ includes.
1977         * linux-thread-db.c: Fix common/ includes.
1978         * linux-nat.c: Fix common/ includes.
1979         * linux-fork.c: Fix common/ includes.
1980         * inline-frame.c: Fix common/ includes.
1981         * infrun.c: Fix common/ includes.
1982         * inflow.c: Fix common/ includes.
1983         * inferior.h: Fix common/ includes.
1984         * inferior.c: Fix common/ includes.
1985         * infcmd.c: Fix common/ includes.
1986         * inf-ptrace.c: Fix common/ includes.
1987         * inf-child.c: Fix common/ includes.
1988         * ia64-linux-nat.c: Fix common/ includes.
1989         * i387-tdep.c: Fix common/ includes.
1990         * i386-tdep.c: Fix common/ includes.
1991         * i386-linux-tdep.c: Fix common/ includes.
1992         * i386-linux-nat.c: Fix common/ includes.
1993         * i386-go32-tdep.c: Fix common/ includes.
1994         * i386-fbsd-tdep.c: Fix common/ includes.
1995         * i386-fbsd-nat.c: Fix common/ includes.
1996         * guile/scm-type.c: Fix common/ includes.
1997         * guile/guile.c: Fix common/ includes.
1998         * go32-nat.c: Fix common/ includes.
1999         * gnu-nat.c: Fix common/ includes.
2000         * gdbthread.h: Fix common/ includes.
2001         * gdbarch-selftests.c: Fix common/ includes.
2002         * gdb_usleep.c: Fix common/ includes.
2003         * gdb_select.h: Fix common/ includes.
2004         * gdb_bfd.c: Fix common/ includes.
2005         * gcore.c: Fix common/ includes.
2006         * fork-child.c: Fix common/ includes.
2007         * findvar.c: Fix common/ includes.
2008         * fbsd-nat.c: Fix common/ includes.
2009         * event-top.c: Fix common/ includes.
2010         * event-loop.c: Fix common/ includes.
2011         * dwarf2read.c: Fix common/ includes.
2012         * dwarf2loc.c: Fix common/ includes.
2013         * dwarf2-frame.c: Fix common/ includes.
2014         * dwarf-index-cache.c: Fix common/ includes.
2015         * dtrace-probe.c: Fix common/ includes.
2016         * disasm-selftests.c: Fix common/ includes.
2017         * defs.h: Fix common/ includes.
2018         * csky-tdep.c: Fix common/ includes.
2019         * cp-valprint.c: Fix common/ includes.
2020         * cp-support.h: Fix common/ includes.
2021         * cp-support.c: Fix common/ includes.
2022         * corelow.c: Fix common/ includes.
2023         * completer.h: Fix common/ includes.
2024         * completer.c: Fix common/ includes.
2025         * compile/compile.c: Fix common/ includes.
2026         * compile/compile-loc2c.c: Fix common/ includes.
2027         * compile/compile-cplus-types.c: Fix common/ includes.
2028         * compile/compile-cplus-symbols.c: Fix common/ includes.
2029         * command.h: Fix common/ includes.
2030         * cli/cli-dump.c: Fix common/ includes.
2031         * cli/cli-cmds.c: Fix common/ includes.
2032         * charset.c: Fix common/ includes.
2033         * build-id.c: Fix common/ includes.
2034         * btrace.h: Fix common/ includes.
2035         * btrace.c: Fix common/ includes.
2036         * breakpoint.h: Fix common/ includes.
2037         * breakpoint.c: Fix common/ includes.
2038         * ax.h: 
2039         (enum agent_op): Fix common/ includes.
2040         * ax-general.c (struct aop_map): Fix common/ includes.
2041         * ax-gdb.c: Fix common/ includes.
2042         * auxv.c: Fix common/ includes.
2043         * auto-load.c: Fix common/ includes.
2044         * arm-tdep.c: Fix common/ includes.
2045         * arch/riscv.c: Fix common/ includes.
2046         * arch/ppc-linux-common.c: Fix common/ includes.
2047         * arch/i386.c: Fix common/ includes.
2048         * arch/arm.c: Fix common/ includes.
2049         * arch/arm-linux.c: Fix common/ includes.
2050         * arch/arm-get-next-pcs.c: Fix common/ includes.
2051         * arch/amd64.c: Fix common/ includes.
2052         * arch/aarch64.c: Fix common/ includes.
2053         * arch/aarch64-insn.c: Fix common/ includes.
2054         * arch-utils.c: Fix common/ includes.
2055         * amd64-windows-tdep.c: Fix common/ includes.
2056         * amd64-tdep.c: Fix common/ includes.
2057         * amd64-sol2-tdep.c: Fix common/ includes.
2058         * amd64-obsd-tdep.c: Fix common/ includes.
2059         * amd64-nbsd-tdep.c: Fix common/ includes.
2060         * amd64-linux-tdep.c: Fix common/ includes.
2061         * amd64-linux-nat.c: Fix common/ includes.
2062         * amd64-fbsd-tdep.c: Fix common/ includes.
2063         * amd64-fbsd-nat.c: Fix common/ includes.
2064         * amd64-dicos-tdep.c: Fix common/ includes.
2065         * amd64-darwin-tdep.c: Fix common/ includes.
2066         * agent.c: Fix common/ includes.
2067         * ada-lang.h: Fix common/ includes.
2068         * ada-lang.c: Fix common/ includes.
2069         * aarch64-tdep.c: Fix common/ includes.
2070
2071 2019-01-25  Tom Tromey  <tom@tromey.com>
2072
2073         * common/create-version.sh: Use common/version.h.
2074
2075 2019-01-24  Pedro Alves  <palves@redhat.com>
2076
2077         * infrun.c (signal_stop, signal_print, signal_program)
2078         (signal_catch, signal_pass): Now arrays instead of pointers.
2079         (update_signals_program_target, do_target_resume)
2080         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2081         * linux-nat.c (linux_nat_target::pass_signals)
2082         (linux_nat_target::create_inferior, linux_nat_target::attach):
2083         Adjust.
2084         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2085         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2086         * procfs.c (procfs_target::pass_signals): Adjust.
2087         * record-full.c (record_full_target::resume): Adjust.
2088         * remote.c (remote_target::pass_signals)
2089         (remote_target::program_signals): Adjust.
2090         * target-debug.h (target_debug_print_signals): Now takes a
2091         gdb::array_view as parameter.  Adjust.
2092         * target.h (target_ops) <pass_signals, program_signals>: Replace
2093         pointer and length parameters with gdb::array_view.
2094         (target_pass_signals, target_program_signals): Likewise.
2095         * target-delegates.c: Regenerate.
2096
2097 2019-01-24  Pedro Alves  <palves@redhat.com>
2098
2099         * common/forward-scope-exit.h
2100         (forward_scope_exit::forward_scope_exit): Pass arguments to
2101         m_bind_function directly, instead of creating a std::bind and
2102         copying that.
2103
2104 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2105
2106         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2107         for static members.
2108         (pass_in_v_vfp_candidate): Likewise.
2109
2110 2019-01-23  Tom Tromey  <tom@tromey.com>
2111             Pedro Alves  <palves@redhat.com>
2112
2113         * regcache.c (class regcache_invalidator): Remove.
2114         (regcache::raw_write): Use make_scope_exit.
2115
2116 2019-01-23  Tom Tromey  <tom@tromey.com>
2117
2118         * ui-out.h (class ui_out_emit_type): Update comment.
2119
2120 2019-01-23  Tom Tromey  <tom@tromey.com>
2121
2122         * infrun.c (fetch_inferior_event): Update comment.
2123
2124 2019-01-23  Tom Tromey  <tom@tromey.com>
2125             Pedro Alves  <palves@redhat.com>
2126
2127         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2128         parameter.
2129         (fetch_inferior_event): Use SCOPE_EXIT.
2130
2131
2132 2019-01-23  Tom Tromey  <tom@tromey.com>
2133             Pedro Alves  <palves@redhat.com>
2134
2135         * infrun.c (disable_thread_events): Delete.
2136         (stop_all_threads): Use SCOPE_EXIT.
2137
2138 2019-01-23  Tom Tromey  <tom@tromey.com>
2139             Pedro Alves  <palves@redhat.com>
2140
2141         * symfile.c: Include forward-scope-exit.h.
2142         (clear_symtab_users_cleanup): Replace forward declaration with
2143         a FORWARD_SCOPE_EXIT.
2144         (syms_from_objfile_1): Use the forward_scope_exit and
2145         gdb::optional instead of cleanup_function.
2146         (reread_symbols): Use the forward_scope_exit instead of
2147         cleanup_function.
2148         (clear_symtab_users_cleanup): Remove function.
2149
2150 2019-01-23  Tom Tromey  <tom@tromey.com>
2151             Pedro Alves  <palves@redhat.com>
2152
2153         * linux-nat.c: Include scope-exit.h.
2154         (cleanup_target_stop): Remove.
2155         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2156         SCOPE_EXIT.
2157
2158 2019-01-23  Tom Tromey  <tom@tromey.com>
2159             Pedro Alves  <palves@redhat.com>
2160
2161         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2162         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2163
2164 2019-01-23  Tom Tromey  <tom@tromey.com>
2165             Andrew Burgess  <andrew.burgess@embecosm.com>
2166             Pedro Alves  <palves@redhat.com>
2167
2168         * infrun.c (fetch_inferior_event): Use scope_exit.
2169         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2170         * top.c (execute_command): Use scope_exit.
2171         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2172         * utils.c (do_bpstat_clear_actions_cleanup)
2173         (make_bpstat_clear_actions_cleanup): Remove.
2174
2175 2019-01-23  Tom Tromey  <tom@tromey.com>
2176             Pedro Alves  <palves@redhat.com>
2177
2178         * infrun.c: Include "common/scope-exit.h"
2179         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2180         (wait_for_inferior): Use SCOPE_EXIT.
2181         (fetch_inferior_event): Use scope_exit.
2182
2183 2019-01-23  Tom Tromey  <tom@tromey.com>
2184             Pedro Alves  <palves@redhat.com>
2185
2186         * breakpoint.c (create_breakpoint): Remove cleanup.
2187
2188 2019-01-23  Tom Tromey  <tom@tromey.com>
2189             Andrew Burgess  <andrew.burgess@embecosm.com>
2190             Pedro Alves  <palves@redhat.com>
2191
2192 2019-01-23  Pedro Alves  <palves@redhat.com>
2193
2194         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2195
2196 2019-01-23  Pedro Alves  <palves@redhat.com>
2197             Andrew Burgess  <andrew.burgess@embecosm.com>
2198
2199         * gdbthread.h: Include "common/forward-scope-exit.h".
2200         (scoped_finish_thread_state): Redefine custom class in terms of
2201         forward_scope_exit.
2202
2203 2019-01-23  Pedro Alves  <palves@redhat.com>
2204             Andrew Burgess  <andrew.burgess@embecosm.com>
2205
2206         * common/forward-scope-exit.h: New file.
2207
2208 2019-01-23  Pedro Alves  <palves@redhat.com>
2209             Andrew Burgess  <andrew.burgess@embecosm.com>
2210             Tom Tromey  <tom@tromey.com>
2211
2212         * common/scope-exit.h: New file.
2213
2214 2019-01-23  Pedro Alves  <palves@redhat.com>
2215
2216         * common/preprocessor.h (ESC): Rename to ...
2217         (ESC_PARENS): ... this.
2218         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2219         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2220
2221 2019-01-23  Tom Tromey  <tom@tromey.com>
2222
2223         * language.h (class scoped_switch_to_sym_language_if_auto):
2224         Initialize m_lang in both cases.
2225
2226 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2227
2228         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2229         with XCNEW.
2230
2231 2019-01-22  Tom Tromey  <tom@tromey.com>
2232
2233         * corelow.c: Do not include sys/file.h.
2234
2235 2019-01-22  Tom Tromey  <tom@tromey.com>
2236
2237         * tui/tui-wingeneral.h: Include gdb_curses.h.
2238
2239 2019-01-22  Tom Tromey  <tom@tromey.com>
2240
2241         * source-cache.h (class source_cache) <get_source_lines,
2242         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2243
2244 2019-01-22  Tom Tromey  <tom@tromey.com>
2245
2246         * remote-fileio.h (struct remote_target): Declare.
2247
2248 2019-01-22  Tom Tromey  <tom@tromey.com>
2249
2250         * python/py-arch.c: Do not include py-ref.h.
2251         * python/py-bpevent.c: Do not include py-ref.h.
2252         * python/py-cmd.c: Do not include py-ref.h.
2253         * python/py-continueevent.c: Do not include py-ref.h.
2254         * python/py-event.h: Do not include py-ref.h.
2255         * python/py-evtregistry.c: Do not include py-ref.h.
2256         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2257         * python/py-frame.c: Do not include py-ref.h.
2258         * python/py-framefilter.c: Do not include py-ref.h.
2259         * python/py-function.c: Do not include py-ref.h.
2260         * python/py-infevents.c: Do not include py-ref.h.
2261         * python/py-linetable.c: Do not include py-ref.h.
2262         * python/py-objfile.c: Do not include py-ref.h.
2263         * python/py-param.c: Do not include py-ref.h.
2264         * python/py-prettyprint.c: Do not include py-ref.h.
2265         * python/py-progspace.c: Do not include py-ref.h.
2266         * python/py-symbol.c: Do not include py-ref.h.
2267         * python/py-symtab.c: Do not include py-ref.h.
2268         * python/py-type.c: Do not include py-ref.h.
2269         * python/py-unwind.c: Do not include py-ref.h.
2270         * python/py-utils.c: Do not include py-ref.h.
2271         * python/py-value.c: Do not include py-ref.h.
2272         * python/py-varobj.c: Do not include py-ref.h.
2273         * python/py-xmethods.c: Do not include py-ref.h.
2274         * python/python.c: Do not include py-ref.h.
2275         * varobj.c: Do not include py-ref.h.
2276
2277 2019-01-22  Tom Tromey  <tom@tromey.com>
2278
2279         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2280         keyword for bcache.
2281
2282 2019-01-22  Tom Tromey  <tom@tromey.com>
2283
2284         * compile/compile-cplus-types.c: Remove a comment by #include.
2285
2286 2019-01-22  Tom Tromey  <tom@tromey.com>
2287
2288         * compile/gcc-c-plugin.h: Include compile-internal.h.
2289
2290 2019-01-22  Tom Tromey  <tom@tromey.com>
2291
2292         * stabsread.c (EXTERN): Do not define.
2293         (symnum, next_symbol_text_func, processing_gcc_compilation)
2294         (within_function, global_sym_chain, global_stabs)
2295         (previous_stab_code, this_object_header_files)
2296         (n_this_object_header_files)
2297         (n_allocated_this_object_header_files): Define.
2298         * stabsread.h (EXTERN): Never define.  Use "extern".
2299
2300 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2301
2302         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2303         history_value.
2304
2305 2019-01-21  Tom Tromey  <tom@tromey.com>
2306
2307         * ui-out.c: Fix includes.
2308         * tui/tui-source.c: Fix includes.
2309         * target.c: Fix includes.
2310         * remote.c: Fix includes.
2311         * regcache.c: Fix includes.
2312         * python/py-block.c: Fix includes.
2313         * printcmd.c: Fix includes.
2314         * or1k-tdep.c: Fix includes.
2315         * mi/mi-main.c: Fix includes.
2316         * m32r-tdep.c: Fix includes.
2317         * csky-tdep.c: Fix includes.
2318         * compile/compile-cplus-types.c: Fix includes.
2319         * cli/cli-interp.c: Fix includes.
2320
2321 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2322
2323         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2324         for padding.
2325
2326 2019-01-16  Tom Tromey  <tom@tromey.com>
2327
2328         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2329         earlier.
2330         (struct objfile) <msymbols_range>: Move from top level.
2331         <msymbols>: New method.
2332         (class objfile_msymbols): Remove.
2333         * symtab.c (default_collect_symbol_completion_matches_break_on):
2334         Update.
2335         * symmisc.c (dump_msymbols): Update.
2336         * stabsread.c (scan_file_globals): Update.
2337         * objc-lang.c (info_selectors_command, info_classes_command)
2338         (find_methods): Update.
2339         * minsyms.c (find_solib_trampoline_target): Update.
2340         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2341         * coffread.c (coff_symfile_read): Update.
2342         * ada-lang.c (ada_lookup_simple_minsym)
2343         (ada_collect_symbol_completion_matches): Update.
2344
2345 2019-01-16  Tom Tromey  <tom@tromey.com>
2346
2347         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2348         type.  Remove no-argument constructor.
2349         <iterator::operator++>: Simplify.
2350         <begin>: Update.
2351         <end>: Use minimal_symbol_count.
2352
2353 2019-01-16  Tom Tromey  <tom@tromey.com>
2354
2355         * objfiles.h (struct objfile) <psymtabs>: New method.
2356         (class objfile_psymtabs): Remove.
2357         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2358         typedef.
2359         <range>: New method.
2360         (require_partial_symbols): Change return type.
2361         * psymtab.c (require_partial_symbols)
2362         (psym_expand_symtabs_matching): Update.
2363         * mdebugread.c (parse_partial_symbols): Update.
2364         * dbxread.c (dbx_end_psymtab): Update.
2365
2366 2019-01-15  Tom Tromey  <tom@tromey.com>
2367
2368         * symtab.c (lookup_objfile_from_block)
2369         (lookup_symbol_in_objfile_symtabs)
2370         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2371         (find_line_symtab, info_sources_command)
2372         (default_collect_symbol_completion_matches_break_on)
2373         (make_source_files_completion_list): Update.
2374         * symmisc.c (print_objfile_statistics, dump_objfile)
2375         (maintenance_print_symbols, maintenance_info_symtabs)
2376         (maintenance_check_symtabs, maintenance_info_line_tables):
2377         Update.
2378         * source.c (select_source_symtab)
2379         (forget_cached_source_info_for_objfile): Update.
2380         * objfiles.h (class objfile_compunits): Remove.
2381         (struct objfile) <compunits_range>: New typedef.
2382         (compunits): New method.
2383         * objfiles.c (objfile_relocate1): Update.
2384         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2385         * maint.c (count_symtabs_and_blocks): Update.
2386         * linespec.c (iterate_over_all_matching_symtabs): Update.
2387         * cp-support.c (add_symbol_overload_list_qualified): Update.
2388         * coffread.c (coff_symtab_read): Update.
2389         * ada-lang.c (add_nonlocal_symbols)
2390         (ada_collect_symbol_completion_matches)
2391         (ada_add_global_exceptions): Update.
2392
2393 2019-01-15  Tom Tromey  <tom@tromey.com>
2394
2395         * progspace.h (program_space) <objfiles_safe_range>: New
2396         typedef.
2397         <objfiles_safe>: New method.
2398         * objfiles.h (class all_objfiles_safe): Remove.
2399         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2400         * jit.c (jit_inferior_exit_hook): Update.
2401
2402 2019-01-17  Tom Tromey  <tom@tromey.com>
2403
2404         * progspace.h (program_space) <objfiles_range>: New typedef.
2405         <objfiles>: New method.
2406         <objfiles_head>: Rename from objfiles.
2407         (object_files): Update.
2408         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2409         * guile/scm-pretty-print.c
2410         (ppscm_find_pretty_printer_from_objfiles): Update.
2411         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2412         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2413         Update.
2414         * python/py-progspace.c (pspy_get_objfiles): Update.
2415         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2416         Update.
2417         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2418         (objfpy_lookup_objfile_by_build_id): Update.
2419         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2420         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2421         Update.
2422         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2423         (expand_symtab_containing_pc, lookup_objfile_from_block)
2424         (lookup_static_symbol, basic_lookup_transparent_type)
2425         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2426         (find_line_symtab, info_sources_command)
2427         (default_collect_symbol_completion_matches_break_on)
2428         (make_source_files_completion_list, find_main_name): Update.
2429         * symmisc.c (print_symbol_bcache_statistics)
2430         (print_objfile_statistics, maintenance_print_symbols)
2431         (maintenance_print_msymbols, maintenance_print_objfiles)
2432         (maintenance_info_symtabs, maintenance_check_symtabs)
2433         (maintenance_expand_symtabs, maintenance_info_line_tables):
2434         Update.
2435         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2436         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2437         (map_overlay_command, unmap_overlay_command)
2438         (simple_overlay_update, expand_symtabs_matching)
2439         (map_symbol_filenames): Update.
2440         * symfile-debug.c (set_debug_symfile): Update.
2441         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2442         Update.
2443         * source.c (select_source_symtab, forget_cached_source_info):
2444         Update.
2445         * solib.c (solib_read_symbols): Update.
2446         * solib-spu.c (append_ocl_sos): Update.
2447         * psymtab.c (maintenance_print_psymbols)
2448         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2449         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2450         * printcmd.c (info_symbol_command): Update.
2451         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2452         Update.
2453         * objfiles.h (class all_objfiles): Remove.
2454         * objfiles.c (have_partial_symbols, have_full_symbols)
2455         (have_minimal_symbols, qsort_cmp, update_section_map)
2456         (shared_objfile_contains_address_p)
2457         (default_iterate_over_objfiles_in_search_order): Update.
2458         * objc-lang.c (info_selectors_command, info_classes_command)
2459         (find_methods): Update.
2460         * minsyms.c (find_solib_trampoline_target): Update.
2461         * maint.c (maintenance_info_sections)
2462         (maintenance_translate_address, count_symtabs_and_blocks):
2463         Update.
2464         * main.c (captured_main_1): Update.
2465         * linux-thread-db.c (try_thread_db_load_from_pdir)
2466         (has_libpthread): Update.
2467         * linespec.c (iterate_over_all_matching_symtabs)
2468         (search_minsyms_for_name): Update.
2469         * jit.c (jit_find_objf_with_entry_addr): Update.
2470         * hppa-tdep.c (find_unwind_entry)
2471         (hppa_lookup_stub_minimal_symbol): Update.
2472         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2473         Update.
2474         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2475         (elf_gnu_ifunc_resolve_by_got): Update.
2476         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2477         * dwarf-index-write.c (save_gdb_index_command): Update.
2478         * cp-support.c (add_symbol_overload_list_qualified): Update.
2479         * breakpoint.c (create_overlay_event_breakpoint)
2480         (create_longjmp_master_breakpoint)
2481         (create_std_terminate_master_breakpoint)
2482         (create_exception_master_breakpoint): Update.
2483         * blockframe.c (find_pc_partial_function): Update.
2484         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2485         (ada_collect_symbol_completion_matches)
2486         (ada_add_global_exceptions): Update.
2487
2488 2019-01-17  Tom Tromey  <tom@tromey.com>
2489
2490         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2491         declare VEC.
2492         (solib_target_parse_libraries): Change return type.
2493         (library_list_start_segment, library_list_start_section)
2494         (library_list_end_library, library_list_start_library); Update.
2495         (solib_target_free_library_list): Remove.
2496         (solib_target_parse_libraries): Remove cleanup.  Change return
2497         type.
2498         (solib_target_current_sos): Update.
2499
2500 2019-01-17  Tom Tromey  <tromey@bapiya>
2501
2502         * valprint.c: Replace "the the" with "the".
2503         * symtab.c: Replace "the the" with "the".
2504         * solib.c: Replace "the the" with "the".
2505         * solib-dsbt.c: Replace "the the" with "the".
2506         * linespec.c: Replace "the the" with "the".
2507         * dwarf2loc.h: Replace "the the" with "the".
2508         * amd64-windows-tdep.c: Replace "the the" with "the".
2509         * aarch64-tdep.c: Replace "the the" with "the".
2510
2511 2019-01-16  Keith Seitz  <keiths@redhat.com>
2512
2513         PR gdb/23773
2514         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2515         <builder>: Rename to ..
2516         <m_builder>: ... this and make private.
2517         (dwarf2_cu::get_builder): New method.  Change all users of
2518         `builder' to use this method.
2519         (dwarf2_start_symtab): Move to ...
2520         (dwarf2_cu::start_symtab): ... here.  Update all callers
2521         (setup_type_unit_groups): Move to ...
2522         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
2523         callers.
2524         (dwarf2_cu::reset_builder): New method.
2525         (process_full_compunit, process_full_type_unit): Use
2526         dwarf2_cu::reset_builder.
2527         (follow_die_offset): Record the ancestor CU if it is different
2528         from the followed DIE's CU.
2529         (follow_die_sig_1): Likewise.
2530
2531 2019-01-15  Tom Tromey  <tom@tromey.com>
2532
2533         * remote.c (class remote_state) <buf>: Now a char_vector.
2534         <buf_size>: Remove.
2535         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
2536         parameter.
2537         (remote_target::getpkt_or_notif_sane_1)
2538         (remote_target::getpkt_sane)
2539         (remote_target::getpkt_or_notif_sane): Likewise.
2540         (class remote_target) <putpkt>: New overload.
2541         (remote_target::read_frame): Change type of "buf_p".  Remove
2542         sizeof_p parameter.
2543         (packet_ok): New overload.
2544         (packet_check_result): New overload.
2545         Update all uses.
2546
2547 2019-01-14  Tom Tromey  <tom@tromey.com>
2548
2549         * remote-notif.c (handle_notification, remote_notif_ack)
2550         (remote_notif_parse): Make "buf" const.
2551         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
2552         const.
2553         (remote_notif_parse, remote_notif_ack, handle_notification):
2554         Likewise.
2555         * remote.c (remote_notif_stop_parse): Make "buf" const.
2556         (remote_target::remote_parse_stop_reply): Make "buf" const.
2557         (remote_notif_stop_ack): Make "buf" const.
2558
2559 2019-01-14  Tom Tromey  <tom@tromey.com>
2560
2561         * remote.c (remote_console_output): Make parameter const.
2562
2563 2019-01-14  Tom Tromey  <tom@tromey.com>
2564
2565         * target-debug.h (target_debug_print_signals): Constify.
2566         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
2567         * procfs.c (procfs_target::pass_signals): Update.
2568         * linux-nat.c (linux_nat_target::pass_signals): Update.
2569         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
2570         * target-delegates.c: Rebuild.
2571         * remote.c (remote_target::program_signals): Update.
2572         (remote_target::pass_signals): Update.
2573         * target.c (target_pass_signals): Constify argument.
2574         (target_program_signals): Likewise.
2575         * target.h (struct target_ops) <pass_signals, program_signals>:
2576         Constify argument.
2577         (target_pass_signals, target_program_signals): Constify argument.
2578
2579 2019-01-14  Tom Tromey  <tom@tromey.com>
2580
2581         PR tui/28819:
2582         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
2583
2584 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2585
2586         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
2587         field.
2588         * rs6000-tdep.c: Include reggroups.h.
2589         (IS_V_ALIAS_PSEUDOREG): Define.
2590         (rs6000_register_name): Return names for the "vX" aliases.
2591         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
2592         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
2593         aliases.  Call default_register_reggroup_p for all other
2594         pseudo-registers.
2595         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
2596         New functions.
2597         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
2598         Handle "vX" aliases.
2599         (v_alias_pseudo_register_collect): New function.
2600         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
2601         (rs6000_gdbarch_init): Initialize "vX" aliases as
2602         pseudo-registers.  Restore registration of
2603         rs6000_pseudo_register_reggroup_p with
2604         set_tdesc_pseudo_register_reggroup_p.
2605
2606 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
2607
2608         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
2609         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
2610         set_gdbarch_num_pseudo_regs.
2611
2612 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2613
2614         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
2615         Remove arg prefixname, add do_set and do_show.
2616         Add member functions set_list and show_list.
2617         * cli/cli-style.c (class cli_style_option): Update accordingly.
2618         (style_set_list): Move to file scope.
2619         (style_show_list): Likewise.
2620         (set_style): Call help_list.
2621         (show_style): Call cmd_show_list.
2622         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
2623         Update to use the new macro.
2624
2625 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
2626
2627         * ada-lang.c (_initialize_ada_language): Expand the help text
2628         for the "catch exception" command.
2629
2630 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2631
2632         * symtab.c (matching_obj_sections): Initialize obj,
2633         declare it closer to its usage.
2634
2635 2019-01-10  Tom Tromey  <tom@tromey.com>
2636
2637         * thread-iter.h (inf_threads_iterator): Use next_iterator.
2638         (basic_inf_threads_range): Remove.
2639         (inf_threads_range, inf_non_exited_threads_range)
2640         (safe_inf_threads_range): Use next_adapter.
2641
2642 2019-01-10  Keith Seitz  <keiths@redhat.com>
2643
2644         PR gdb/23712
2645         PR symtab/23010
2646         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
2647         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
2648
2649 2019-01-10  Keith Seitz  <keiths@redhat.com>
2650
2651         PR gdb/23712
2652         PR symtab/23010
2653         * dictionary.c (pending_to_vector): Remove.
2654         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2655         Remove _1 suffix, replacing functions of the same name.  Update
2656         all callers.
2657         (dict_create_hashed, dict_create_hashed_expandable)
2658         (dict_create_linear, dict_create_linear_expandable, dict_free)
2659         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
2660         Make functions static.
2661
2662 2019-01-10  Keith Seitz  <keiths@redhat.com>
2663
2664         PR gdb/23712
2665         PR symtab/23010
2666         * dictionary.h (struct dictionary): Replace declaration with
2667         multidictionary.
2668         (dict_create_hashed, dict_create_hashed_expandable)
2669         (dict_create_linear, dict_create_linear_expandable)
2670         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
2671         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
2672         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
2673         taking multidictionary argument.
2674         [ALL_DICT_SYMBOLS]: Update for multidictionary.
2675         * block.h (struct block) <dict>: Change to multidictionary
2676         and rename `multidict'.
2677         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
2678         symmisc.c: Update all dictionary references to multidictionary.
2679
2680 2019-01-10  Keith Seitz  <keiths@redhat.com>
2681
2682         PR gdb/23712
2683         PR symtab/23010
2684         * dictionary.c: Include unordered_map.
2685         (pending_to_vector): New function.
2686         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2687         Rewrite the non-"_1" functions to take vector instead
2688         of linked list.
2689         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
2690         "new" _1 versions of the same name.
2691         (multidictionary): Define.
2692         (std::hash<enum language): New definition.
2693         (collate_pending_symbols_by_language, mdict_create_hashed)
2694         (mdict_create_hashed_expandable, mdict_create_linear)
2695         (mdict_create_linear_expandable, mdict_free)
2696         (find_language_dictionary, create_new_language_dictionary)
2697         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
2698         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
2699         (mdict_size, mdict_empty): New functions.
2700         * dictionary.h (mdict_iterator): Define.
2701
2702 2019-01-10  Pedro Alves  <palves@redhat.com>
2703
2704         * breakpoint.c (read_uploaded_action)
2705         (create_tracepoint_from_upload): Adjust to use
2706         gdb::unique_xmalloc_ptr.
2707         * ctf.c (ctf_write_uploaded_tp):
2708         (SET_ARRAY_FIELD): Use emplace_back.
2709         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
2710         * tracefile-tfile.c (tfile_write_uploaded_tp):
2711         * tracepoint.c (parse_tracepoint_definition): Adjust to use
2712         gdb::unique_xmalloc_ptr.
2713         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
2714         at_string, cond_string, cmd_strings>: Replace char pointers
2715         with gdb::unique_xmalloc_ptr.
2716
2717 2019-01-10  Pedro Alves  <palves@redhat.com>
2718
2719         * solib-target.c (library_list_start_library): Don't xstrdup name.
2720
2721 2019-01-10  Pedro Alves  <palves@redhat.com>
2722
2723         * mdebugread.c (parse_partial_symbols): Use
2724         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
2725
2726 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2727
2728         * linux-fork.c (scoped_switch_fork_info)
2729         <~scoped_switch_fork_info>: Fix incorrect variable name.
2730
2731 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2732
2733         * linux-fork.c (scoped_switch_fork_info)
2734         <scoped_switch_fork_info>: Make explicit.
2735         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
2736
2737 2019-01-10  Tom Tromey  <tom@tromey.com>
2738
2739         * objfiles.h (objfile::reset_psymtabs): Update.
2740         * objfiles.c (objfile::objfile): Update.
2741         * psymtab.h (psymtab_storage::obstack): Update.
2742         (psymtab_storage::m_obstack): Use gdb::optional.
2743         (class psymtab_storage): Update comment.  Remove objfile
2744         parameter.
2745         * psymtab.c (psymtab_storage::psymtab_storage): Update.
2746
2747 2019-01-10  Tom Tromey  <tom@tromey.com>
2748
2749         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
2750         <free_psymtabs>: Now private.
2751         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
2752         (allocate_psymtab): Use new method.
2753
2754 2019-01-10  Tom Tromey  <tom@tromey.com>
2755
2756         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
2757         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
2758         * mdebugread.c (parse_partial_symbols): Use
2759         allocate_dependencies.
2760         * dwarf2read.c (dwarf2_create_include_psymtab): Use
2761         allocate_dependencies.
2762         (process_psymtab_comp_unit_reader)
2763         (build_type_psymtab_dependencies): Likewise.
2764         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
2765
2766 2019-01-10  Tom Tromey  <tom@tromey.com>
2767
2768         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
2769         PSYMBOL_SET_LANGUAGE.
2770         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
2771
2772 2019-01-10  Tom Tromey  <tom@tromey.com>
2773
2774         * psymtab.h (psymtab_storage::obstack): New method.
2775         <m_obstack>: Rename from obstack; now private.
2776         * psymtab.c (psymtab_storage): Update.
2777         * dwarf2read.c (create_addrmap_from_index)
2778         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
2779         Update.
2780
2781 2019-01-10  Tom Tromey  <tom@tromey.com>
2782
2783         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
2784         * objfiles.h (objfile::reset_psymtabs): New method.
2785
2786 2019-01-10  Tom Tromey  <tom@tromey.com>
2787
2788         * symmisc.c (print_symbol_bcache_statistics): Update.
2789         (print_objfile_statistics): Update.
2790         * symfile.c (reread_symbols): Update.
2791         * psymtab.h (class psymtab_storage): New.
2792         * psymtab.c (psymtab_storage): New constructor.
2793         (~psymtab_storage): New destructor.
2794         (require_partial_symbols): Update.
2795         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
2796         (find_pc_sect_psymtab, find_pc_sect_psymbol)
2797         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
2798         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
2799         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
2800         (start_psymtab_common, end_psymtab_common)
2801         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
2802         (allocate_psymtab): Update.
2803         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
2804         Update.
2805         (dump_psymtab_addrmap, maintenance_print_psymbols)
2806         (maintenance_check_psymtabs): Update.
2807         (class objfile_psymtabs): Move to objfiles.h.
2808         * psympriv.h (discard_psymtab): Now inline.
2809         (psymtab_discarder::psymtab_discarder): Update.
2810         (psymtab_discarder::~psymtab_discarder): Update.
2811         (ALL_OBJFILE_PSYMTABS): Rewrite.
2812         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
2813         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
2814         Remove fields.
2815         <partial_symtabs>: New field.
2816         (class objfile_psymtabs): Move from psymtab.h.  Update.
2817         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
2818         psymbol_cache.
2819         (objfile::~objfile): Don't destroy psymbol_cache.
2820         * mdebugread.c (parse_partial_symbols): Update.
2821         * dwarf2read.c (create_addrmap_from_index)
2822         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2823         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2824         (add_partial_subprogram, dwarf2_ranges_read): Update.
2825         * dwarf-index-write.c (write_address_map)
2826         (write_one_signatured_type, recursively_write_psymbols)
2827         (class debug_names, class debug_names, write_psymtabs_to_index):
2828         Update.
2829
2830 2019-01-10  Tom Tromey  <tom@tromey.com>
2831
2832         * symtab.h (SYMBOL_SET_NAMES): Update.
2833         (symbol_set_names): Update.
2834         (MSYMBOL_SET_NAMES): Update.
2835         * symtab.c (symbol_set_names): Change argument to be an
2836         objfile_per_bfd_storage.
2837         * psymtab.c (add_psymbol_to_bcache): Update.
2838         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2839
2840 2019-01-10  Tom Tromey  <tom@tromey.com>
2841
2842         * symtab.c (create_demangled_names_hash): Change argument to be an
2843         objfile_per_bfd_storage.
2844         (symbol_set_names): Update.
2845
2846 2019-01-10  Tom Tromey  <tom@tromey.com>
2847
2848         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2849         init_psymbol_list.
2850         * psymtab.c (init_psymbol_list): Do nothing if already called.
2851         * psympriv.h (init_psymbol_list): Add comment.
2852         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2853         init_psymbol_list.
2854         * dbxread.c (dbx_symfile_read): Unconditionally call
2855         init_psymbol_list.
2856
2857 2019-01-10  Tom Tromey  <tom@tromey.com>
2858
2859         * xcoffread.c (scan_xcoff_symtab): Update.
2860         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2861         "where".
2862         * mdebugread.c (parse_partial_symbols)
2863         (handle_psymbol_enumerators): Update.
2864         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2865         * dbxread.c (read_dbx_symtab): Update.
2866         * psympriv.h (psymbol_placement): New enum.
2867         (add_psymbol_to_list): Update.
2868
2869 2019-01-10  Tom Tromey  <tom@tromey.com>
2870
2871         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2872         static_psymbols parameters.
2873         (scan_xcoff_symtab): Update.
2874         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2875         static_psymbols parameters.
2876         * psympriv.h (start_psymtab_common): Update.
2877         * mdebugread.c (parse_partial_symbols): Update.
2878         * dwarf2read.c (create_partial_symtab): Update.
2879         * dbxread.c (read_dbx_symtab): Update.
2880         (start_psymtab): Remove global_psymbols and static_psymbols
2881         parameters.
2882
2883 2019-01-10  Tom Tromey  <tom@tromey.com>
2884
2885         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2886         * psymtab.c (allocate_psymtab): Add comment.
2887         * psympriv.h (allocate_psymtab): Add comment.
2888         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2889         initializations.
2890         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2891
2892 2019-01-10  Tom Tromey  <tom@tromey.com>
2893
2894         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2895         Don't declare.
2896         * mipsread.c: Include mdebugread.h.
2897         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2898         Declare.
2899         * elfread.c: Include mdebugread.h.
2900
2901 2019-01-09  Tom Tromey  <tom@tromey.com>
2902
2903         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2904         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2905         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2906         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2907         (psym_lookup_symbol, psym_find_last_source_symtab)
2908         (psym_forget_cached_source_info, psym_print_stats)
2909         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2910         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2911         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2912         (psym_find_compunit_symtab_by_address)
2913         (maintenance_print_psymbols, maintenance_info_psymtabs)
2914         (maintenance_check_psymtabs): Use ranged for.
2915         * psymtab.h (class objfile_psymtabs): New.
2916         (require_partial_symbols): Return objfile_psymtabs.
2917         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2918
2919 2019-01-09  Tom Tromey  <tom@tromey.com>
2920
2921         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2922         (find_pc_mapped_section, list_overlays_command)
2923         (map_overlay_command, unmap_overlay_command)
2924         (simple_overlay_update): Use all_objfiles.
2925         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2926         * printcmd.c (info_symbol_command): Use all_objfiles.
2927         * objfiles.h (ALL_OBJSECTIONS): Remove.
2928         * maint.c (maintenance_translate_address): Use all_objfiles.
2929         * gcore.c (gcore_create_callback): Use all_objfiles.
2930         (objfile_find_memory_regions): Likewise.
2931
2932 2019-01-09  Tom Tromey  <tom@tromey.com>
2933
2934         * symtab.c (find_line_symtab, info_sources_command)
2935         (make_source_files_completion_list): Use objfile_compunits.
2936         * source.c (select_source_symtab): Use objfile_compunits.
2937         * objfiles.h (struct objfile): Update comment.
2938         (ALL_OBJFILES): Remove.
2939         (ALL_FILETABS): Remove.
2940         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2941         objfile_compunits.
2942
2943 2019-01-09  Tom Tromey  <tom@tromey.com>
2944
2945         * symmisc.c (print_objfile_statistics, dump_objfile)
2946         (maintenance_print_symbols): Use compunit_filetabs.
2947         * source.c (forget_cached_source_info_for_objfile): Use
2948         compunit_filetabs.
2949         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2950         (ALL_FILETABS): Use compunit_filetabs.
2951         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2952         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2953
2954 2019-01-09  Tom Tromey  <tom@tromey.com>
2955
2956         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2957         (compunit_filetabs): New.
2958         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2959         compunit_filetabs.
2960         (info_sources_command, make_source_files_completion_list): Remove
2961         declaration.
2962         * symmisc.c (print_objfile_statistics, dump_objfile)
2963         (maintenance_print_symbols): Remove declaration.
2964         (maintenance_info_symtabs): Use compunit_filetabs.
2965         (maintenance_info_line_tables): Likewise.
2966         * source.c (select_source_symtab): Change local variable name.
2967         (forget_cached_source_info_for_objfile): Remove declaration.
2968         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2969         * objfiles.c (objfile_relocate1): Remove declaration.
2970         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2971         declaration.
2972         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2973         * coffread.c (coff_symtab_read): Remove declaration.
2974         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2975         compunit_filetabs.
2976
2977 2019-01-09  Tom Tromey  <tom@tromey.com>
2978
2979         * symtab.c (lookup_objfile_from_block)
2980         (find_pc_sect_compunit_symtab, search_symbols)
2981         (default_collect_symbol_completion_matches_break_on): Use
2982         objfile_compunits.
2983         * objfiles.h (ALL_COMPUNITS): Remove.
2984         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2985         * cp-support.c (add_symbol_overload_list_qualified): Use
2986         objfile_compunits.
2987         * ada-lang.c (ada_collect_symbol_completion_matches)
2988         (ada_add_global_exceptions): Use objfile_compunits.
2989
2990 2019-01-09  Tom Tromey  <tom@tromey.com>
2991
2992         * source.c (select_source_symtab)
2993         (forget_cached_source_info_for_objfile): Remove declaration.
2994         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2995         declaration.
2996         * maint.c (count_symtabs_and_blocks): Remove declaration.
2997         * cp-support.c (add_symbol_overload_list_qualified): Remove
2998         declaration.
2999         * coffread.c (coff_symtab_read): Remove declaration.
3000         * symtab.c (lookup_symbol_in_objfile_symtabs)
3001         (basic_lookup_transparent_type_1): Use objfile_compunits.
3002         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3003         (info_sources_command, search_symbols)
3004         (default_collect_symbol_completion_matches_break_on)
3005         (make_source_files_completion_list): Remove declaration.
3006         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3007         (ada_collect_symbol_completion_matches)
3008         (ada_add_global_exceptions): Remove declaration.
3009         * linespec.c (iterate_over_all_matching_symtabs): Use
3010         objfile_compunits.
3011         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3012         (class objfile_compunits): New.
3013         (ALL_COMPUNITS): Use objfile_compunits.
3014         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3015         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3016         objfile_compunits.
3017         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3018
3019 2019-01-09  Tom Tromey  <tom@tromey.com>
3020
3021         * symtab.c (search_symbols)
3022         (default_collect_symbol_completion_matches_break_on): Use
3023         objfile_msymbols.
3024         * ada-lang.c (ada_lookup_simple_minsym)
3025         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3026         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3027         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3028         objfile_msymbols.
3029         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3030         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3031         * objc-lang.c (find_methods): Use objfile_msymbols.
3032         (info_selectors_command, info_classes_command): Likewise.
3033         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3034         * objfiles.h (class objfile_msymbols): New.
3035         (ALL_OBJFILE_MSYMBOLS): Remove.
3036         (ALL_MSYMBOLS): Remove.
3037
3038 2019-01-09  Tom Tromey  <tom@tromey.com>
3039
3040         * common/next-iterator.h (next_adapter): Add Iterator template
3041         parameter.
3042         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3043         (class all_objfiles_safe): New.
3044         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3045         * objfiles.c (put_objfile_before): Update comment.
3046         (add_separate_debug_objfile): Likewise.
3047         (free_all_objfiles): Use all_objfiles_safe.
3048         (objfile_purge_solibs): Likewise.
3049
3050 2019-01-09  Tom Tromey  <tom@tromey.com>
3051
3052         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3053         (expand_symtab_containing_pc, lookup_static_symbol)
3054         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3055         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3056         all_objfiles.
3057         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3058         * breakpoint.c (create_overlay_event_breakpoint)
3059         (create_longjmp_master_breakpoint)
3060         (create_std_terminate_master_breakpoint)
3061         (create_exception_master_breakpoint): Use all_objfiles.
3062         * linux-thread-db.c (try_thread_db_load_from_pdir)
3063         (has_libpthread): Use all_objfiles.
3064         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3065         * linespec.c (iterate_over_all_matching_symtabs)
3066         (search_minsyms_for_name): Use all_objfiles.
3067         * maint.c (maintenance_info_sections): Use all_objfiles.
3068         * main.c (captured_main_1): Use all_objfiles.
3069         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3070         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3071         * guile/scm-pretty-print.c
3072         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3073         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3074         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3075         (maintenance_print_msymbols): Use all_objfiles.
3076         * source.c (select_source_symtab): Use all_objfiles.
3077         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3078         * symfile.c (remove_symbol_file_command)
3079         (expand_symtabs_matching, map_symbol_filenames): Use
3080         all_objfiles.
3081         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3082         all_objfiles.
3083         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3084         * objc-lang.c (find_methods): Use all_objfiles.
3085         * objfiles.c (have_partial_symbols, have_full_symbols)
3086         (have_minimal_symbols, qsort_cmp)
3087         (default_iterate_over_objfiles_in_search_order): Use
3088         all_objfiles.
3089         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3090         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3091         (maintenance_check_psymtabs): Use all_objfiles.
3092         (ALL_PSYMTABS): Remove.
3093         * compile/compile-object-run.c (do_module_cleanup): Use
3094         all_objfiles.
3095         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3096         * cp-support.c (add_symbol_overload_list_qualified): Use
3097         all_objfiles.
3098         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3099         Use all_objfiles.
3100         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3101         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3102         all_objfiles.
3103         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3104         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3105         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3106         Uses all_objfiles.
3107         * solib.c (solib_read_symbols): Use all_objfiles
3108
3109 2019-01-09  Tom Tromey  <tom@tromey.com>
3110
3111         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3112         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3113         all_objfiles.
3114         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3115         * symmisc.c (print_symbol_bcache_statistics)
3116         (print_objfile_statistics, maintenance_print_objfiles)
3117         (maintenance_info_symtabs, maintenance_check_symtabs)
3118         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3119         all_objfiles.
3120         * source.c (forget_cached_source_info): Use all_objfiles.
3121         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3122         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3123         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3124         * objfiles.c (update_section_map): Use all_objfiles.
3125         (shared_objfile_contains_address_p): Likewise.
3126         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3127         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3128
3129 2019-01-09  Tom Tromey  <tom@tromey.com>
3130
3131         * common/next-iterator.h: New file.
3132         * objfiles.h (class all_objfiles): New.
3133         (struct objfile_iterator): New.
3134
3135 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3136
3137         * NEWS: Move the description of the changed "frame", "select-frame",
3138          and "info frame" commands to the Changed commands section.
3139
3140 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3141
3142         * gdbtypes.c (check_stub_method_group): Remove handling of old
3143         mangling schemes.
3144         * linespec.c (find_methods): Likewise.
3145         * stabsread.c (read_member_functions): Likewise.
3146         * valops.c (search_struct_method): Likewise.
3147         (value_struct_elt_for_reference): Likewise.
3148         * NEWS: Mention this change.
3149
3150 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3151
3152         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3153         print_source_lines.
3154         * source.c (print_source_lines_base): Update line number check.
3155         (print_source_lines): New function.
3156         (source_lines_range::source_lines_range): New function.
3157         * source.h (class source_lines_range): New class.
3158         (print_source_lines): New declaration.
3159
3160 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3161
3162         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3163
3164 2019-01-08  Tom Tromey  <tom@tromey.com>
3165             Simon Marchi  <simon.marchi@ericsson.com>
3166
3167         PR gdb/24060
3168         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3169         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3170         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3171         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3172         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3173         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3174
3175 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3176
3177         * source.c (select_source_symtab): Move header comment to
3178         declaration in source.h.
3179         (forget_cached_source_info_for_objfile): Likewise.
3180         (forget_cached_source_info): Likewise.
3181         (identify_source_line): Likewise.
3182         * source.h (identify_source_line): Move declaration from symtab.h
3183         and add comment from source.c
3184         (print_source_lines): Likewise.
3185         (forget_cached_source_info_for_objfile): Likewise.
3186         (forget_cached_source_info): Likewise.
3187         (select_source_symtab): Likewise.
3188         (enum print_source_lines_flag): Move definition from symtab.h.
3189         * symtab.h (identify_source_line): Move declaration to source.h.
3190         (print_source_lines): Likewise.
3191         (forget_cached_source_info_for_objfile): Likewise.
3192         (forget_cached_source_info): Likewise.
3193         (select_source_symtab): Likewise.
3194         (enum print_source_lines_flag): Move definition to source.h.
3195         * tui/tui-hooks.c: Add 'source.h' include.
3196
3197 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3198
3199         * source.c (print_source_lines_base): Handle requests to print
3200         reverse line number sequences, and guard against empty lines
3201         string.
3202
3203 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3204
3205         * source.c (print_source_lines_base): Fix skip of '\r' if next
3206         character is '\n'.
3207
3208 2019-01-06  Tom Tromey  <tom@tromey.com>
3209
3210         * c-exp.y (struct c_parse_state) <macro_original_text,
3211         expansion_obstack>: New member.
3212         (macro_original_text, expansion_obstack): Remove globals.
3213         (scan_macro_expansion, scanning_macro_expansion)
3214         (finished_macro_expansion): Update.
3215         (scan_macro_cleanup): Remove.
3216         (yylex, c_parse): Update.
3217
3218 2019-01-06  Tom Tromey  <tom@tromey.com>
3219
3220         * c-exp.y (struct c_parse_state) <strings>: New member.
3221         (operator_stoken): Update.
3222
3223 2019-01-06  Tom Tromey  <tom@tromey.com>
3224
3225         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3226         (union type_stack_elt) <typelist_val>: Now a pointer to
3227         std::vector.
3228         (type_stack_cleanup): Don't declare.
3229         (push_typelist): Update.
3230         * parse.c (pop_typelist): Return a std::vector.
3231         (push_typelist): Take a std::vector.
3232         (follow_types): Update.  Do not free args.
3233         (type_stack_cleanup): Remove.
3234         * c-exp.y (struct c_parse_state): New.
3235         (cpstate): New global.
3236         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3237         (nonempty_typelist): Update.
3238         (func_mod): Create a new vector.
3239         (c_parse): Create a c_parse_state.
3240         (check_parameter_typelist): Do not delete params.
3241         (function_method): Update.  Do not delete type_list.
3242
3243 2019-01-06  Tom Tromey  <tom@tromey.com>
3244
3245         PR gdb/28155:
3246         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3247         check_typedef.
3248         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3249         (print_return_value): Likewise.
3250
3251 2019-01-05  Tom Tromey  <tom@tromey.com>
3252
3253         * contrib/cleanup_check.py: Remove.
3254         * contrib/gcc-with-excheck: Remove.
3255         * contrib/exsummary.py: Remove.
3256         * contrib/excheck.py: Remove.
3257
3258 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3259
3260         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3261         NULL. Initialize tpprev to NULL instead of assigning it
3262         to NULL on the next statement.
3263         * windows-nat.c (windows_delete_thread): Remove check for
3264         main_thread_id before printing thread exit notifications.
3265         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3266         Remove thread ID check against main_thread_id.
3267         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3268         windows_delete_thread.
3269         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3270
3271 2019-01-04  Tom Tromey  <tom@tromey.com>
3272
3273         * compile/compile.c (_initialize_compile): Use upper case for
3274         metasyntactic variables.
3275         * symmisc.c (_initialize_symmisc): Use upper case for
3276         metasyntactic variables.
3277         * psymtab.c (_initialize_psymtab): Use upper case for
3278         metasyntactic variables.
3279         * demangle.c (demangle_command): Use upper case for metasyntactic
3280         variables.
3281         (_initialize_demangler): Likewise.
3282         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3283         variables.
3284
3285 2019-01-03  Tom Tromey  <tom@tromey.com>
3286
3287         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3288
3289 2019-01-03  Tom Tromey  <tom@tromey.com>
3290
3291         * python/py-symtab.c (salpy_str): Update.
3292         (struct salpy_sal_object) <symtab>: Now a PyObject.
3293         (salpy_dealloc): Update.
3294         (del_objfile_sal): Use gdbpy_ref.
3295
3296 2019-01-03  Tom Tromey  <tom@tromey.com>
3297
3298         * python/py-type.c (convert_field): Use new_reference.  Return
3299         gdbpy_ref.
3300         (make_fielditem): Return gdbpy_ref.
3301         (typy_fields): Update.
3302         (typy_getitem): Update.
3303         (field_name): Return gdbpy_ref.  Use new_reference.
3304         (typy_iterator_iternext): Update.
3305
3306 2019-01-03  Tom Tromey  <tom@tromey.com>
3307
3308         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3309
3310 2019-01-03  Tom Tromey  <tom@tromey.com>
3311
3312         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3313         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3314         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3315         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3316         (pspy_set_type_printers): Likewise.
3317         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3318         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3319         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3320         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3321         (objfpy_set_type_printers): Likewise.
3322
3323 2019-01-03  Tom Tromey  <tom@tromey.com>
3324
3325         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3326         (gdbpy_print_stack): Use gdbpy_err_fetch.
3327         * python/python-internal.h (class gdbpy_err_fetch): New class.
3328         (class gdbpy_enter) <m_error_type, m_error_value,
3329         m_error_traceback>: Remove.
3330         <m_error>: New member.
3331         (gdbpy_exception_to_string): Don't declare.
3332         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3333         * python/py-value.c (convert_value_from_python): Use
3334         gdbpy_err_fetch.
3335         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3336         gdbpy_exception_to_string.
3337         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3338         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3339         gdbpy_err_fetch.
3340
3341 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3342
3343         * linux-nat.c (delete_lwp_cleanup): Delete.
3344         (struct lwp_deleter): New struct.
3345         (lwp_info_up): New typedef.
3346         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3347         lwp_info_up.
3348
3349 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3350
3351         * linux-fork.c (class scoped_switch_fork_info): New class.
3352         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3353
3354 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3355
3356         * valops.c (find_overload_match): Remove use of null_cleanup, and
3357         calls to do_cleanups.
3358
3359 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3360
3361         * compile/compile-cplus-types.c
3362         (compile_cplus_instance::decl_name): Handle changes to
3363         cp_func_name.
3364         * cp-support.c (cp_func_name): Update header comment, update
3365         return type.
3366         * cp-support.h (cp_func_name): Update return type in declaration.
3367         * valops.c (find_overload_match): Move temp_func local to top
3368         level of function and change its type.  Use temp_func to hold and
3369         delete temporary string obtained from cp_func_name.
3370
3371 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3372
3373         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3374         gdb::char_vector, remove cleanup, and update uses of `msg`.
3375
3376 2019-01-03  Jim Wilson  <jimw@sifive.com>
3377
3378         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3379
3380 2019-01-02  Tom Tromey  <tom@tromey.com>
3381
3382         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3383         (tdesc_parse_xml): Remove cleanups.
3384         * target-descriptions.h (make_cleanup_free_target_description):
3385         Don't declare.
3386         (target_desc_deleter): New struct.
3387         (target_desc_up): New typedef.
3388         * target-descriptions.c (target_desc_deleter::operator()): Rename
3389         from free_target_description.
3390         (make_cleanup_free_target_description): Remove.
3391
3392 2019-01-02  Tom Tromey  <tom@tromey.com>
3393
3394         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3395         constructor, destructor.
3396         (linespec_parser): Remove typedef.
3397         (~linespec_parser): Rename from linespec_parser_delete.
3398         (linespec_lex_to_end, linespec_complete_label)
3399         (linespec_complete): Update.
3400         (decode_line_full): Remove cleanups.
3401         (decode_line_1): Update.
3402
3403 2019-01-02  Tom Tromey  <tom@tromey.com>
3404
3405         * python/python-internal.h (inferior_to_inferior_object): Change
3406         return type.
3407         * python/py-exitedevent.c (create_exited_event_object): Update.
3408         * python/py-inferior.c (inferior_to_inferior_object): Return
3409         gdbpy_ref.
3410         (python_new_inferior, python_inferior_deleted)
3411         (thread_to_thread_object, delete_thread_object)
3412         (build_inferior_list, gdbpy_selected_inferior): Update.
3413         * python/py-infthread.c (create_thread_object): Update.  Also fail
3414         if inferior_to_inferior_object fails.
3415
3416 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3417
3418         * inferior.h (class inferior) <displaced_step_state>: New field.
3419         * infrun.h (struct displaced_step_state): Move here from
3420         infrun.c.  Initialize fields, add constructor.
3421         <inf>: Remove field.
3422         <reset>: New method.
3423         * infrun.c (struct displaced_step_inferior_state): Move to
3424         infrun.h.
3425         (displaced_step_inferior_states): Remove.
3426         (get_displaced_stepping_state): Adust.
3427         (displaced_step_in_progress_any_inferior): Adjust.
3428         (displaced_step_in_progress_thread): Adjust.
3429         (displaced_step_in_progress): Adjust.
3430         (add_displaced_stepping_state): Remove.
3431         (get_displaced_step_closure_by_addr): Adjust.
3432         (remove_displaced_stepping_state): Remove.
3433         (infrun_inferior_exit): Call displaced_step_state.reset.
3434         (use_displaced_stepping): Don't check for NULL.
3435         (displaced_step_prepare_throw): Call
3436         get_displaced_stepping_state.
3437         (displaced_step_fixup): Don't check for NULL.
3438         (prepare_for_detach): Don't check for NULL.
3439
3440 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3441
3442         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3443          in case of call that did not complete.
3444
3445 2019-01-02  Andrey Utkin  <autkin@undo.io>
3446
3447         * symfile.c (find_separate_debug_file): Fix search of debug files for
3448         remote debuggee.
3449
3450 2019-01-02  Tom Tromey  <tom@tromey.com>
3451
3452         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3453         indentation.
3454         * python/py-frame.c (frapy_older): Remove cast.
3455         (frapy_newer): Likewise.
3456         * python/py-breakpoint.c (local_setattro): Remove cast.
3457         * python/py-arch.c (archpy_name): Remove local variable.
3458         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3459
3460 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3461
3462         * unittests/basic_string_view/element_access/char/empty.cc:
3463         Fix year range in copyright header.
3464
3465 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3466
3467         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3468         Delete.
3469         <operator==>: Update with for removed field.
3470         <hash>: Likewise.
3471         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3472         <isa_features>: ...this.
3473         <abi_features>: New field.
3474         (riscv_isa_flen): Update comment.
3475         (riscv_abi_xlen): New declaration.
3476         (riscv_abi_flen): New declaration.
3477         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3478         isa_features.
3479         (riscv_abi_xlen): New function.
3480         (riscv_isa_flen): Update to get answer from isa_features.
3481         (riscv_abi_flen): New function.
3482         (riscv_has_fp_abi): Update to get answer from abi_features.
3483         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3484         xlen and flen.
3485         (riscv_call_info) <xlen, flen>: Update comment.
3486         (riscv_call_arg_struct): Remove invalid assertions
3487         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3488         is removed.
3489         (riscv_gdbarch_init): Gather isa features and abi features
3490         separately, ensure both match on the gdbarch when reusing an old
3491         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3492         a target with 64-bit float hardware.
3493
3494 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3495
3496         * source.c (search_command_helper): Stop reverse search
3497         when line 1 has been searched.
3498
3499 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3500
3501         * record-full.c (record_full_base_target::close): Rewrite
3502         record_full_core_buf_list free logic.
3503
3504 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3505
3506         * break-catch-syscall.c (print_one_catch_syscall): xfree
3507         the last text.
3508
3509 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3510
3511         * top.c (print_gdb_version): Update Copyright year in version
3512         message.
3513
3514 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3515
3516         Update copyright year range in all GDB files.
3517
3518 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
3519
3520         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
3521
3522 For older changes see ChangeLog-2018.
3523 \f
3524 Local Variables:
3525 mode: change-log
3526 left-margin: 8
3527 fill-column: 74
3528 version-control: never
3529 coding: utf-8
3530 End:
3531