gdb/ChangeLog

   1 2019-08-13  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
   4         tui_add_win_to_layout.
   5
   6 2019-08-13  Tom Tromey  <tom@tromey.com>
   7
   8         * tui/tui-layout.h (tui_default_win_height): Don't declare.
   9         * tui/tui-layout.c (tui_default_win_height): Now static.
  10
  11 2019-08-13  Tom Tromey  <tom@tromey.com>
  12
  13         * tui/tui-layout.c (show_layout): Unify all layout cases into a
  14         single switch.
  15         (show_source_disasm_command, show_source_or_disasm_and_command):
  16         Don't check current layout.
  17
  18 2019-08-13  Tom Tromey  <tom@tromey.com>
  19
  20         * tui/tui-wingeneral.c (make_all_visible): Remove.
  21         (tui_make_all_invisible): Simplify.
  22         * tui/tui-layout.c (tui_make_all_invisible): Move from
  23         tui-wingeneral.c; simplify.
  24         (show_layout): Hoist call to tui_make_all_invisible.
  25         (show_data): Don't call tui_make_all_invisible.
  26
  27 2019-08-13  Tom Tromey  <tom@tromey.com>
  28
  29         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
  30         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
  31
  32 2019-08-13  Tom Tromey  <tom@tromey.com>
  33
  34         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
  35         tui-data.c.
  36         (show_source_disasm_command, show_data)
  37         (show_source_or_disasm_and_command): Don't use
  38         tui_set_current_layout_to.
  39         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
  40         * tui/tui-data.c (current_layout, tui_current_layout): Move to
  41         tui-layout.c.
  42         (tui_set_current_layout_to): Remove.
  43
  44 2019-08-13  Tom Tromey  <tom@tromey.com>
  45
  46         * tui/tui-layout.c (tui_set_layout): Update.
  47         * tui/tui-data.h (struct tui_layout_def): Remove.
  48         (tui_layout_def): Don't declare.
  49         * tui/tui-data.c (layout_def): Remove.
  50         (tui_layout_def): Remove.
  51
  52 2019-08-13  Tom Tromey  <tom@tromey.com>
  53
  54         * tui/tui-winsource.h (struct tui_source_window_base)
  55         <clear_detail>: No longer "override".
  56         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
  57         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
  58         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
  59         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
  60         Remove.
  61         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
  62
  63 2019-08-13  Tom Tromey  <tromey@adacore.com>
  64
  65         * tracepoint.c: Don't include readline.h or history.h.
  66
  67 2019-08-12  Tom Tromey  <tom@tromey.com>
  68
  69         * configure: Rebuild.
  70         * configure.ac: Check for readline 7.
  71         * NEWS: Mention readline 7 requirement.
  72         * README: Update.
  73
  74 2019-08-12  Tom Tromey  <tom@tromey.com>
  75
  76         * mingw-hdep.c (gdb_select): Remove readline hack.
  77
  78 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
  79
  80         * blockframe.c (find_pc_partial_function): Set *block to nullptr
  81         when the function fails.
  82
  83 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
  84
  85         * s390-tdep.c (s390_type_align): New function.
  86         (s390_gdbarch_init): Set it as type_align gdbarch method.
  87
  88 2019-08-09  Tom de Vries  <tdevries@suse.de>
  89
  90         PR gdb/24591
  91         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
  92         pc_low with relocation offset.
  93
  94 2019-08-07  Tom Tromey  <tromey@adacore.com>
  95
  96         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
  97         (print_frame_args): Update.
  98         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
  99         Update.
 100         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 101         * frame.h (struct frame_arg): Add initializers.
 102         <error>: Now a unique_xmalloc_ptr.
 103
 104 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 105
 106         * NEWS: Expand the Pointer Authentication entry.
 107         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 108         (aarch64_frame_unmask_lr): ... to this.
 109         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 110         Call aarch64_frame_unmask_lr.
 111         * frame.c (struct frame_info): Add "masked" variable.
 112         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 113         (fprint_frame): Check for masked pc.
 114         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 115         declarations.
 116         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 117         * stack.c (print_frame): Check for masked pc.
 118
 119 2019-08-06  Tom Tromey  <tom@tromey.com>
 120
 121         * stabsread.c (patch_block_stabs, read_one_struct_field)
 122         (read_enum_type): Use obstack_strndup.
 123         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
 124         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
 125         * dwarf2read.c (guess_full_die_structure_name)
 126         (anonymous_struct_prefix): Use obstack_strndup.
 127         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 128         * c-exp.y (yylex): Use obstack_strndup.
 129         * ada-exp.y (write_object_renaming, write_ambiguous_var)
 130         (write_var_or_type): Use obstack_strndup.
 131
 132 2019-08-06  Tom Tromey  <tom@tromey.com>
 133
 134         * symfile.c (reread_symbols): Use obstack_strdup.
 135         * stabsread.c (read_type): Use obstack_strdup.
 136         * gdb_obstack.h (obstack_strdup): New overload.
 137         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
 138         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
 139         (dwarf2_canonicalize_name): Use obstack_strdup.
 140         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
 141         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
 142         Use obstack_strdup.
 143
 144 2019-08-06  Tom Tromey  <tom@tromey.com>
 145
 146         * gdb_obstack.h (obstack_strdup): Define.
 147         * gdb_obstack.c (obstack_strdup): Don't define.
 148
 149 2019-08-06  Tom Tromey  <tom@tromey.com>
 150
 151         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
 152         obstack_strdup.
 153         * typeprint.c (typedef_hash_table::find_global_typedef): Use
 154         obstack_strdup.
 155         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
 156         * stabsread.c (common_block_start): Use obstack_strdup.
 157         * objfiles.c (set_objfile_main_name, objfile): Use
 158         obstack_strdup.
 159         * namespace.c (add_using_directive): Use obstack_strdup.
 160         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
 161         * jit.c (finalize_symtab): Use obstack_strdup.
 162         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
 163         (guess_partial_die_structure_name, partial_die_info::fixup)
 164         (dwarf2_name): Use obstack_strdup.
 165         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
 166         obstack_strdup.
 167         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
 168         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 169         obstack_strdup.
 170         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
 171
 172 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 173
 174         * unittests/help-doc-selftests.c: New file.
 175         * Makefile.in: Add the new file.
 176
 177 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 178
 179         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
 180         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
 181         the full first line, except when FOR_VALUE_PREFIX.  In this case,
 182         the trailing '.' is not output, and the first character is uppercased.
 183         (print_help_for_command): Update call to print_doc_line.
 184         (print_doc_of_command): Likewise.
 185         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
 186         * cli/cli-option.c (append_indented_doc): Do not append newline.
 187         (build_help_option): Append newline after first appended_indented_doc
 188         only if a second call is done.
 189         (build_help): Append 2 new lines before each option, except the first
 190         one.
 191         * compile/compile.c (_initialize_compile): Add new lines after
 192         %OPTIONS%, when not at the end of the help.
 193         Change help doc or code
 194         producing the help doc to respect the invariants.
 195         * maint-test-options.c (_initialize_maint_test_options): Likewise.
 196         Also removed the new line after 'Options:', as all other commands
 197         do not put an empty line between 'Options:' and the first option.
 198         * printcmd.c (_initialize_printcmd): Likewise.
 199         * stack.c (_initialize_stack): Likewise.
 200         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
 201         incorrectly telling COMMAND is optional.
 202         * ada-lang.c (_initialize_ada_language): Change help doc or code
 203         producing the help doc to respect the invariants.
 204         * ada-tasks.c (_initialize_ada_tasks): Likewise.
 205         * breakpoint.c (_initialize_breakpoint): Likewise.
 206         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
 207         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
 208         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
 209         * cli/cli-style.c (cli_style_option::add_setshow_commands,
 210         _initialize_cli_style): Likewise.
 211         * corelow.c (core_target_info): Likewise.
 212         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
 213         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
 214         * filesystem.c (_initialize_filesystem): Likewise.
 215         * frame.c (_initialize_frame): Likewise.
 216         * gnu-nat.c (add_task_commands): Likewise.
 217         * infcall.c (_initialize_infcall): Likewise.
 218         * infcmd.c (_initialize_infcmd): Likewise.
 219         * interps.c (_initialize_interpreter): Likewise.
 220         * language.c (_initialize_language): Likewise.
 221         * linux-fork.c (_initialize_linux_fork): Likewise.
 222         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
 223         * maint.c (_initialize_maint_cmds): Likewise.
 224         * memattr.c (_initialize_mem): Likewise.
 225         * printcmd.c (_initialize_printcmd): Likewise.
 226         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
 227         _RegEx): Likewise.
 228         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
 229         * record-btrace.c (_initialize_record_btrace): Likewise.
 230         * record-full.c (_initialize_record_full): Likewise.
 231         * record.c (_initialize_record): Likewise.
 232         * regcache-dump.c (_initialize_regcache_dump): Likewise.
 233         * regcache.c (_initialize_regcache): Likewise.
 234         * remote.c (add_packet_config_cmd, init_remote_threadtests,
 235         _initialize_remote): Likewise.
 236         * ser-tcp.c (_initialize_ser_tcp): Likewise.
 237         * serial.c (_initialize_serial): Likewise.
 238         * skip.c (_initialize_step_skip): Likewise.
 239         * source.c (_initialize_source): Likewise.
 240         * stack.c (_initialize_stack): Likewise.
 241         * symfile.c (_initialize_symfile): Likewise.
 242         * symtab.c (_initialize_symtab): Likewise.
 243         * target-descriptions.c (_initialize_target_descriptions): Likewise.
 244         * top.c (init_main): Likewise.
 245         * tracefile-tfile.c (tfile_target_info): Likewise.
 246         * tracepoint.c (_initialize_tracepoint): Likewise.
 247         * tui/tui-win.c (_initialize_tui_win): Likewise.
 248         * utils.c (add_internal_problem_command): Likewise.
 249         * valprint.c (value_print_option_defs): Likewise.
 250
 251 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
 252
 253         PR build/24886
 254         * configure.ac: Drop enable-libmcheck support.
 255         * configure, config.in: Rebuild.
 256         * libmcheck.m4: Remove.
 257         * acinclude.m4: Don't include it.
 258         * Makefile.in: Don't distribute it.
 259         * top.c (print_gdb_configuration): Don't mention it.
 260
 261 2019-08-06  Tom Tromey  <tom@tromey.com>
 262
 263         * utils.c (set_output_style): Sometimes pass stream to
 264         emit_style_escape.
 265         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
 266         * record-btrace.c (btrace_insn_history): Update.
 267         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
 268         method.
 269         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
 270         Update initializers.
 271         <m_uiout>: New field.
 272         <m_di>: Move lower.
 273         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 274         Remove "uiout" parameter.
 275         (dump_insns): Update.
 276         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
 277         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
 278
 279 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
 280
 281         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
 282         (error_in_psymtab_expansion): Likewise.
 283         (lookup_symbol_via_quick_fns): Likewise.
 284         (basic_lookup_transparent_type_quick): Likewise.
 285         (basic_lookup_transparent_type_1): Likewise.
 286
 287 2019-08-06  Tom Tromey  <tromey@adacore.com>
 288
 289         * source.c (last_source_error): Now bool.
 290         (print_source_lines_base): Make "noprint" bool.  Only open
 291         source file when last_source_visited changes.
 292
 293 2019-08-06  Tom Tromey  <tromey@adacore.com>
 294
 295         * annotate.c (annotate_source_line): Use g_source_cache.
 296         * source-cache.c (source_cache::get_plain_source_lines): Change
 297         parameters.  Populate m_offset_cache.
 298         (source_cache::ensure): New method.
 299         (source_cache::get_line_charpos): New method.
 300         (extract_lines): Move lower.  Change parameters.
 301         (source_cache::get_source_lines): Move lower.
 302         * source-cache.h (class source_cache): Update comment.
 303         <get_line_charpos>: New method.
 304         <get_source_lines>: Update comment.
 305         <clear>: Clear m_offset_cache.
 306         <get_plain_source_lines>: Change parameters.
 307         <ensure>: New method
 308         <m_offset_cache>: New member.
 309         * source.c (forget_cached_source_info_for_objfile): Update.
 310         (info_source_command): Use g_source_cache.
 311         (find_source_lines, open_source_file_with_line_charpos): Remove.
 312         (print_source_lines_base, search_command_helper): Use g_source_cache.
 313         * source.h (open_source_file_with_line_charpos): Don't declare.
 314         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
 315         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
 316         Use g_source_cache.
 317
 318 2019-08-06  Tom Tromey  <tromey@adacore.com>
 319
 320         * source-cache.c (source_cache::get_plain_source_lines):
 321         Remove "first_line" and "last_line" parameters.
 322         (source_cache::get_source_lines): Cache plain text.
 323         * source-cache.h (class source_cache)
 324         <get_plain_source_lines>: Update.
 325
 326 2019-08-06  Tom Tromey  <tromey@adacore.com>
 327
 328         * source-cache.c (extract_lines): No longer a method.
 329         Changed type of parameter.  Include final newline.
 330         (selftests::extract_lines_test): New function.
 331         (_initialize_source_cache): Likewise.
 332         * source-cache.h (class source_cache)
 333         <extract_lines>: Don't declare.
 334
 335 2019-08-06  Tom Tromey  <tromey@adacore.com>
 336
 337         * breakpoint.c (init_breakpoint_sal): Update.
 338         (breakpoint): Update.
 339         * breakpoint.h (struct breakpoint) <filter>: Now a
 340         unique_xmalloc_ptr.
 341
 342 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 343
 344         * NEWS: Mention dictionary access on blocks.
 345         * python/py-block.c (blpy_getitem): New function.
 346         (block_object_as_mapping): New struct.
 347         (block_object_type): Use new struct for tp_as_mapping field.
 348
 349 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 350
 351         * objfiles.h (objfile): Add a comment describing partial symbols.
 352
 353 2019-08-05  Tom Tromey  <tromey@adacore.com>
 354
 355         * compile/compile.c (_initialize_compile): Use _(), not N_().
 356         * thread.c (_initialize_thread): Use _(), not N_().
 357         * stack.c (_initialize_stack): Use _(), not N_().
 358         * printcmd.c (_initialize_printcmd): Use _(), not N_().
 359
 360 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
 361
 362         * dwarf2read.c (struct dw2_symtab_iterator):
 363         <want_specific_block>: Remove.
 364         <block_index>: Change type to gdb::optional.
 365         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
 366         change type of BLOCK_INDEX parameter to gdb::optional.
 367         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
 368         (dw2_lookup_symbol): Don't pass argument for
 369         WANT_SPECIFIC_BLOCK.
 370         (dw2_expand_symtabs_for_function): Don't pass argument for
 371         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
 372         (class dw2_debug_names_iterator)
 373         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
 374         parameter, change BLOCK_INDEX type to gdb::optional.
 375         <m_want_specific_block>: Remove.
 376         <m_block_index>: Change type to gdb::optional.
 377         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
 378         gdb::optional.  Re-write in function of gdb::optional.
 379         (dw2_debug_names_lookup_symbol): Don't pass argument for
 380         WANT_SPECIFIC_BLOCK.
 381         (dw2_debug_names_expand_symtabs_for_function): Don't pass
 382         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
 383         BLOCK_INDEX.
 384
 385 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 386
 387         * NEWS: Mention changes to "info sources" command.
 388
 389 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 390
 391         * symtab.c (filename_partial_match_opts): New struct type.
 392         (struct output_source_filename_data): New members
 393         regexp, c_regexp, partial_match.
 394         (output_source_filename): Use new members to decide to print file.
 395         (info_sources_option_defs): New variable.
 396         (make_info_sources_options_def_group, print_info_sources_header,
 397         info_sources_command_completer):
 398         New functions.
 399         (info_sources_command): Read new optional arguments.
 400         (_initialize_symtab): Update info sources help.
 401
 402 2019-08-02  Alexandre Oliva <oliva@adacore.com>
 403
 404         * ada-lang.c (exception_support_info_v0): Renamed from...
 405         (default_exception_support_info): ... this.  Create new
 406         definition for v1.
 407         (ada_has_this_exception_support): Look up catch_handlers_sym.
 408         (ada_exception_support_info_sniffer): Try v0 after default.
 409
 410 2019-08-01  Tom Tromey  <tromey@adacore.com>
 411
 412         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
 413         gdbarch.h.
 414
 415 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
 416
 417         * s12z-tdep.c: Fix include path for s12z-opc.h.
 418
 419 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
 420
 421         * NEWS: Require GNU make 3.82.
 422
 423 2019-07-16  Tom Tromey  <tom@tromey.com>
 424
 425         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
 426         declare.
 427
 428 2019-07-30  Tom Tromey  <tromey@adacore.com>
 429
 430         * block.c (contained_in): Remove BLOCK_FUNCTION check.
 431
 432 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
 433
 434         * printcmd.c (print_address_symbolic): Print negative offsets.
 435         (build_address_symbolic): Force signed arithmetic when computing
 436         offset.
 437
 438 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
 439
 440         PR/24474: Add a function to lookup static variables.
 441         * NEWS: Mention this new function.
 442         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
 443         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
 444         * python/python.c (python_GdbMethods): Add new function.
 445
 446 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
 447
 448         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
 449         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
 450         (objfpy_lookup_static_symbol): New function.
 451         (objfile_object_methods): Add new functions.
 452
 453 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 454
 455         * NEWS: Mention 'set|show print frame-info'.  Mention new
 456         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
 457         backtrace argument.  Mention that python frame filtering code
 458         is now consistent with what 'backtrace' command prints.
 459
 460 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 461
 462         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
 463         comments.
 464         (print_frame_info_auto, print_frame_info_source_line,
 465         print_frame_info_location, print_frame_info_source_and_location,
 466         print_frame_info_location_and_address, print_frame_info_short_location):
 467         New declarations.
 468         (struct frame_print_options): New member print_frame_info.
 469         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
 470         * stack.h (get_user_print_what_frame_info): New declaration.
 471         (frame_show_address): New declaration.
 472         * stack.c (print_frame_arguments_choices): New value 'presence'.
 473         (print_frame_info_auto, print_frame_info_source_line,
 474         print_frame_info_location, print_frame_info_source_and_location,
 475         print_frame_info_location_and_address, print_frame_info_short_location,
 476         print_frame_info_choices, print_frame_info_print_what): New definitions.
 477         (print_frame_args): Only print dots for args if print frame-arguments
 478         is 'presence'.
 479         (frame_print_option_defs): New element for "frame-info".
 480         (get_user_print_what_frame_info): New function.
 481         (frame_show_address): Make non static.  Move comment to stack.h.
 482         (print_frame_info_to_print_what): New function.
 483         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
 484         to decide what to print.
 485         (backtrace_command_1): Handle the new print_frame_arguments_presence
 486         value.
 487         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
 488         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
 489         (py_print_frame): In non-mi mode, use LOCATION as default for
 490         print_what, similarly to frame information printed directly by
 491         backtrace command. Handle frame-info user option in non MI mode.
 492
 493 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 494
 495         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
 496         Add case for debugging 32-bit target on 64-bit host.  Revise
 497         comment.
 498
 499 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 500
 501         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
 502         instead of find_function_entry_range_from_pc.
 503
 504 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 505
 506         * stack.c (find_frame_funname): Remove code which preferred
 507         minsym over symtab sym in "certain pathological cases".
 508
 509         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
 510         parameter.  Change type of "do_demangle" to bool.
 511         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 512         Pass suitable "prefer_sym_over_minsym" flag to
 513         build_address_symbolic().  Don't output "+" for negative offsets.
 514         * printcmd.c (print_address_symbolic): Update invocation of
 515         build_address_symbolic to include a "prefer_sym_over_minsym"
 516         flag.
 517         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
 518         Restrict cases in which use of minimal symbol is preferred to that
 519         of a found symbol.  Update comments.
 520
 521         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
 522         for entry pc when entry pc is out of range for that FDE.
 523
 524 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
 525
 526         PR gdb/24839:
 527         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
 528         type.
 529
 530 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
 531
 532         * python/py-objfile.c (add_separate_debug_file): Fix comment about
 533         this function's Python signature.
 534
 535
 536 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
 537
 538         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
 539         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 540         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 541         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
 542         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
 543
 544
 545 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
 546
 547         * h8300-tdep.c (h8300_register_name_common): New.
 548         h8300_register_name): Use h8300_register_name_common.
 549         (h8300s_register_name): Likewise.
 550         (h8300sx_register_name): Likewise.
 551         (h8300h_register_nam): New.
 552         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
 553
 554
 555 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
 556
 557         * arm-tdep.c (arm_skip_cmse_entry): New function.
 558         (arm_is_sgstubs_section): New function.
 559         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
 560
 561 2019-07-22  Tom Tromey  <tom@tromey.com>
 562
 563         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
 564         Don't self-assign.
 565
 566 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 567
 568         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
 569         type_print.
 570
 571 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 572
 573         * symtab.c (search_symbols): Adjust msymbol matching type arrays
 574         so that GDB doesn't match any msymbols when searching in the
 575         TYPES_DOMAIN.
 576         (print_symbol_info): Print using typedef_print or type_print based
 577         on the type of the symbol.  Add updated FIXME comment moved from...
 578         (_initialize_symtab): ... move and update FIXME comment to above.
 579
 580 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 581
 582         * NEWS: Mention adding -q option to "info types".
 583         * symtab.c (struct info_types_options): New struct.
 584         (info_types_options_defs): New variable.
 585         (make_info_types_options_def_group): New function.
 586         (info_types_command): Use gdb::option framework to parse options.
 587         (info_types_command_completer): New function.
 588         (_initialize_symtab): Extend the help text on "info types" and
 589         register command completer.
 590
 591 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
 592
 593         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
 594         (lookup_symbol_in_objfile): Change int to block_enum and add a
 595         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
 596
 597 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
 598
 599         * MAINTAINERS (Write After Approval): Add self.
 600
 601 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 602
 603         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
 604         instruction to the dummy code region.
 605
 606 2019-07-19  Tom Tromey  <tromey@adacore.com>
 607
 608         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
 609         (ARGSUSED, PARAMS, __func__): Remove rules.
 610
 611 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 612
 613         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
 614         * features/arm/arm-with-iwmmxt.c: Remove.
 615         * features/arm/arm-with-iwmmxt.xml: Remove.
 616         * features/arm/arm-with-m-fpa-layout.c: Remove.
 617         * features/arm/arm-with-m-fpa-layout.xml: Remove.
 618         * features/arm/arm-with-m-vfp-d16.c: Remove.
 619         * features/arm/arm-with-m-vfp-d16.xml: Remove.
 620         * features/arm/arm-with-m.c: Remove.
 621         * features/arm/arm-with-m.xml: Remove.
 622         * features/arm/arm-with-neon.c: Remove.
 623         * features/arm/arm-with-neon.xml: Remove.
 624         * features/arm/arm-with-vfpv2.c: Remove.
 625         * features/arm/arm-with-vfpv2.xml: Remove.
 626         * features/arm/arm-with-vfpv3.c: Remove.
 627         * features/arm/arm-with-vfpv3.xml: Remove.
 628
 629 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 630
 631         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
 632
 633 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 634
 635         * arch/aarch32.c (aarch32_create_target_description): Create
 636         target descriptions using features.
 637         * arch/arm.c (arm_create_target_description)
 638         (arm_create_mprofile_target_description): Likewise.
 639         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
 640
 641 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 642
 643         * Makefile.in: Add new files.
 644         * aarch32-tdep.c: New file.
 645         * aarch32-tdep.h: New file.
 646         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 647         Call aarch32_read_description.
 648         * arch/aarch32.c: New file.
 649         * arch/aarch32.h: New file.
 650         * arch/arm.c (arm_create_target_description)
 651         (arm_create_mprofile_target_description): New function.
 652         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
 653         (arm_create_target_description)
 654         (arm_create_mprofile_target_description): New declaration.
 655         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
 656         read_description functions.
 657         * arm-linux-nat.c (arm_linux_nat_target::read_description):
 658         Likewise.
 659         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 660         * arm-tdep.c (tdesc_arm_list): New variable.
 661         (arm_register_g_packet_guesses): Call create description functions.
 662         (arm_read_description) (arm_read_mprofile_description): New
 663         function.
 664         * arm-tdep.h (arm_read_description)
 665         (arm_read_mprofile_description): Add declaration.
 666         * configure.tgt: Add new files.
 667
 668 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 669
 670         * top.c (new_ui_command): Open specified terminal just once.
 671
 672 2019-07-18  Tom Tromey  <tromey@adacore.com>
 673
 674         * symtab.c (main_name): Constify return type.
 675         * symfile.c (set_initial_language): Update.
 676         * symtab.h (main_name): Constify return type.
 677
 678 2019-07-17  Tom Tromey  <tom@tromey.com>
 679
 680         * tui/tui-winsource.c (tui_update_source_window)
 681         (tui_update_source_window_as_is)
 682         (tui_update_source_windows_with_line): Remove return.
 683         * tui/tui-disasm.c (tui_show_disassem)
 684         (tui_show_disassem_and_update_source): Remove return.
 685         * tui/tui.c (tui_reset): Remove return.
 686         * tui/tui-wingeneral.c
 687         (tui_check_and_display_highlight_if_needed): Remove return.
 688
 689 2019-07-17  Tom Tromey  <tom@tromey.com>
 690
 691         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 692
 693 2019-07-17  Tom Tromey  <tom@tromey.com>
 694
 695         * tui/tui-winsource.h (struct tui_exec_info_window)
 696         (struct tui_source_window_base): Move from tui-data.h.
 697         * tui/tui-winsource.c: Move many method definitions from
 698         elsewhere.  Remove "structuring" comments.
 699         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 700         (tui_source_window_base::refresh_window): Move to
 701         tui-winsource.c.
 702         * tui/tui-win.c (tui_source_window_base::refresh_all)
 703         (tui_source_window_base::update_tab_width)
 704         (tui_source_window_base::set_new_height)
 705         (tui_source_window_base::do_make_visible_with_new_height): Move to
 706         tui-winsource.c.
 707         * tui/tui-source.h: Update.
 708         * tui/tui-source.c (tui_source_window_base::reset): Move to
 709         tui-winsource.c.
 710         * tui/tui-disasm.h: Update.
 711         * tui/tui-data.h (struct tui_exec_info_window): Move to
 712         tui-winsource.h.
 713         (struct tui_source_window_base): Likewise.
 714         * tui/tui-data.c (tui_source_window_base::clear_detail)
 715         (tui_source_window_base, ~tui_source_window_base): Move to
 716         tui-winsource.c.
 717
 718 2019-07-17  Tom Tromey  <tom@tromey.com>
 719
 720         * tui/tui-win.c (tui_resize_all)
 721         (tui_source_window_base::update_tab_width)
 722         (tui_adjust_win_heights): Update.
 723         (tui_win_info::make_invisible_and_set_new_height): Rename from
 724         make_invisible_and_set_new_height.
 725         * tui/tui-data.h (struct tui_win_info)
 726         <make_invisible_and_set_new_height>: New method.
 727
 728 2019-07-17  Tom Tromey  <tom@tromey.com>
 729
 730         * tui/tui.c: Update.
 731         * tui/tui-source.h (struct tui_source_window): Move from
 732         tui-data.h.
 733         * tui/tui-layout.c: Update.
 734         * tui/tui-disasm.c: Update.
 735         * tui/tui-data.h (struct tui_source_window): Move to
 736         tui-source.h.
 737
 738 2019-07-17  Tom Tromey  <tom@tromey.com>
 739
 740         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 741         tui-data.h.
 742         * tui/tui-data.h (struct tui_disasm_window): Move to
 743         tui-disasm.h.
 744
 745 2019-07-17  Tom Tromey  <tom@tromey.com>
 746
 747         * tui/tui-regs.h (struct tui_data_item_window): Move from
 748         tui-data.h.
 749         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 750         * tui/tui-data.h (struct tui_data_item_window): Move to
 751         tui-regs.h.
 752         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 753
 754 2019-07-17  Tom Tromey  <tom@tromey.com>
 755
 756         * tui/tui.c: Update.
 757         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 758         (tui_cmd_window::max_height): Move to tui-command.c.
 759         * tui/tui-layout.c: Update.
 760         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 761         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 762         tui-command.c.
 763         * tui/tui-command.h (struct tui_cmd_window): Move from
 764         tui-data.h.
 765         * tui/tui-command.c: Remove "structuring" comments.
 766         (tui_cmd_window::clear_detail)
 767         (tui_cmd_window::do_make_visible_with_new_height)
 768         (tui_cmd_window::max_height): Move from elsewhere.
 769
 770 2019-07-17  Tom Tromey  <tom@tromey.com>
 771
 772         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 773         Now static.
 774         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 775         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 776
 777 2019-07-17  Tom Tromey  <tom@tromey.com>
 778
 779         * tui/tui.c: Update.
 780         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 781         tui-regs.c.
 782         * tui/tui-windata.h: Remove file.
 783         * tui/tui-windata.c: Remove file.
 784         * tui/tui-win.c (tui_data_window::set_new_height)
 785         (tui_data_window::do_make_visible_with_new_height): Move to
 786         tui-regs.c.
 787         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 788         * tui/tui-regs.c: Remove "structuring" comments.
 789         (tui_data_window::first_data_item_displayed)
 790         (tui_data_window::delete_data_content_windows)
 791         (tui_data_window::erase_data_content)
 792         (tui_data_window::display_all_data)
 793         (tui_data_window::refresh_all)
 794         (tui_data_window::do_scroll_vertical)
 795         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 796         (tui_data_window::do_make_visible_with_new_height)
 797         (tui_data_window::refresh_window): Move from elsewhere.
 798         (_initialize_tui_regs): Move to end of file.
 799         * tui/tui-layout.c: Update.
 800         * tui/tui-hooks.c: Update.
 801         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 802         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 803         tui-regs.c.
 804         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 805
 806 2019-07-17  Tom Tromey  <tom@tromey.com>
 807
 808         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 809         seen.
 810
 811 2019-07-17  Tom Tromey  <tom@tromey.com>
 812
 813         * tui/tui-win.c (tui_source_window_base::set_new_height)
 814         (tui_source_window_base::do_make_visible_with_new_height): Use
 815         m_has_locator field directly.
 816         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 817         method.
 818         (struct tui_source_window_base) <has_locator>: Likewise.
 819
 820 2019-07-17  Tom Tromey  <tom@tromey.com>
 821
 822         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 823         Don't declare.
 824         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 825         Remove.
 826         * tui/tui-win.c (tui_source_window_base::set_new_height)
 827         (tui_source_window_base::set_new_height)
 828         (make_invisible_and_set_new_height)
 829         (tui_source_window_base::do_make_visible_with_new_height)
 830         (tui_source_window_base::do_make_visible_with_new_height):
 831         Update.
 832         * tui/tui-layout.c (show_source_disasm_command, show_data)
 833         (show_source_or_disasm_and_command): Update.
 834         * tui/tui-layout.c (show_layout): Update.
 835
 836 2019-07-17  Tom Tromey  <tom@tromey.com>
 837
 838         * tui/tui-layout.c (make_data_window): Remove.
 839         (show_data): Unify creation and re-initialization cases.
 840
 841 2019-07-17  Tom Tromey  <tom@tromey.com>
 842
 843         * tui/tui-layout.c (make_source_window, make_disasm_window):
 844         Remove.
 845         (show_data): Unify creation and re-initialization cases.
 846
 847 2019-07-17  Tom Tromey  <tom@tromey.com>
 848
 849         * tui/tui-layout.c (make_command_window): Remove.
 850         (show_source_disasm_command, show_source_or_disasm_and_command):
 851         Unify creation and re-initialization cases.
 852
 853 2019-07-17  Tom Tromey  <tom@tromey.com>
 854
 855         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 856         creation and re-initialization cases.
 857
 858 2019-07-17  Tom Tromey  <tom@tromey.com>
 859
 860         * tui/tui-regs.c (tui_get_register): Return void.
 861
 862 2019-07-17  Tom Tromey  <tom@tromey.com>
 863
 864         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 865         Simplify.
 866
 867 2019-07-17  Tom Tromey  <tom@tromey.com>
 868
 869         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 870         resetting.
 871
 872 2019-07-17  Tom Tromey  <tom@tromey.com>
 873
 874         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 875         * tui/tui-regs.c (tui_reg_layout): New function.
 876         (tui_show_registers, tui_reg_command): Use it.
 877         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 878         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 879         parameters.
 880         (tui_layout_command): Remove.
 881
 882 2019-07-17  Tom Tromey  <tom@tromey.com>
 883
 884         * tui/tui-layout.h (tui/tui-layout): Return void.
 885         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 886
 887 2019-07-17  Tom Tromey  <tom@tromey.com>
 888
 889         * tui/tui-layout.c (show_source_disasm_command, show_data):
 890         Update.
 891         (reset_locator): Remove.
 892         (show_source_or_disasm_and_command): Update.
 893
 894 2019-07-17  Tom Tromey  <tom@tromey.com>
 895
 896         * tui/tui-source.c (tui_source_window_base::reset): Remove
 897         win_type parameter.
 898         * tui/tui-layout.c (make_command_window, make_source_window)
 899         (make_disasm_window, make_data_window)
 900         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 901         (reset_locator, show_source_or_disasm_and_command): Update.
 902         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 903         win_type parameter.
 904         (struct tui_source_window_base) <reset>: Likewise.
 905
 906 2019-07-17  Tom Tromey  <tom@tromey.com>
 907
 908         * tui/tui-layout.c (show_source_disasm_command): Use
 909         reset_locator.
 910         (reset_locator): New function.
 911         (init_and_make_win): Remove.
 912         (show_source_or_disasm_and_command): Use reset_locator.
 913
 914 2019-07-17  Tom Tromey  <tom@tromey.com>
 915
 916         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 917         condition.
 918         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 919         Remove condition.
 920         * tui/tui-source.c (tui_source_window_base::reset): New method.
 921         * tui/tui-layout.c (make_command_window): Don't call
 922         init_and_make_win.
 923         (make_source_window, make_disasm_window): Don't call
 924         make_source_or_disasm_window.
 925         (make_data_window): Don't call init_and_make_win.  Change calling
 926         convention.
 927         (show_source_disasm_command, show_data): Simplify.
 928         (make_source_or_disasm_window): Remove.
 929         (show_source_or_disasm_and_command): Simplify.
 930         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 931         (struct tui_source_window_base) <reset>: Likewise.
 932         <execution_info>: Remove initializer.
 933         * tui/tui-data.c (tui_source_window_base): Initialize
 934         execution_info.
 935
 936 2019-07-17  Tom Tromey  <tom@tromey.com>
 937
 938         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 939         variable.
 940
 941 2019-07-17  Tom Tromey  <tom@tromey.com>
 942
 943         * tui/tui.c (tui_rl_other_window): Update.
 944         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 945         superclass method first.  Always iterate over regs_content.
 946         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 947         method.
 948         * tui/tui-win.c (tui_set_focus_command): Update.
 949
 950 2019-07-17  Tom Tromey  <tom@tromey.com>
 951
 952         * tui/tui-win.c (tui_set_focus_command): Rename from
 953         tui_set_focus.  Call tui_enable.
 954         (tui_set_focus_command): Remove.
 955
 956 2019-07-17  Tom Tromey  <tom@tromey.com>
 957
 958         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 959         refresh_window.
 960         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 961         touchwin.
 962         (tui_data_window::refresh_window): Call refresh_window on data
 963         items.  Always call superclass refresh_window.
 964         (tui_win_info::refresh): Remove.
 965         (tui_source_window_base::refresh_window): Update.
 966         (tui_refresh_all): Update.
 967         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 968         refresh_window.
 969         (show_source_or_disasm_and_command): Likewise.
 970         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 971         (struct tui_source_window_base) <refresh>: Likewise.
 972
 973 2019-07-17  Tom Tromey  <tom@tromey.com>
 974
 975         * tui/tui-winsource.c (tui_clear_source_content)
 976         (tui_show_source_content): Update.
 977         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 978         whether content is empty.
 979         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 980         Remove.
 981
 982 2019-07-17  Tom Tromey  <tom@tromey.com>
 983
 984         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 985         window's contents.
 986         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 987         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 988
 989 2019-07-17  Tom Tromey  <tom@tromey.com>
 990
 991         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 992         (struct tui_data_item_window): Update.
 993
 994 2019-07-17  Tom Tromey  <tom@tromey.com>
 995
 996         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 997         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 998         defines.
 999
1000 2019-07-17  Tom Tromey  <tom@tromey.com>
1001
1002         * tui/tui-winsource.h (tui_erase_source_content)
1003         (tui_clear_source_content): Remove "display_prompt" parameter.
1004         * tui/tui-winsource.c (tui_update_source_window_as_is)
1005         (tui_update_source_windows_with_addr): Update.
1006         (tui_clear_source_content): Remove "display_prompt" parameter.
1007         (tui_erase_source_content): Likewise.  Simplify.
1008         (tui_show_source_content): Update.
1009         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1010         * tui/tui-stack.c (tui_show_frame_info): Update.
1011         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1012         Remove defines.
1013
1014 2019-07-17  Tom Tromey  <tom@tromey.com>
1015
1016         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1017         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1018         parameter.
1019         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1020         parameter.
1021
1022 2019-07-17  Tom Tromey  <tom@tromey.com>
1023
1024         * tui/tui-winsource.c (tui_clear_source_content)
1025         (tui_show_source_content, tui_show_exec_info_content)
1026         (tui_clear_exec_info_content): Update.
1027         * tui/tui-stack.c (tui_show_locator_content): Update.
1028         (tui_show_frame_info): Update.
1029         * tui/tui-source.h (tui_source_window): Don't declare.
1030         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1031         from tui_source_is_displayed.
1032         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1033         Remove field.
1034         (struct tui_source_window_base) <content_in_use>: New field.  Now
1035         bool.
1036         (struct tui_source_window) <showing_source_p>: New method.
1037         (TUI_SRC_WIN): Change cast.
1038         * tui/tui-data.c (tui_initialize_static_data): Update.
1039
1040 2019-07-17  Tom Tromey  <tom@tromey.com>
1041
1042         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1043         location_matches_p.
1044         * tui/tui-source.c (tui_source_window::location_matches_p): New
1045         method.
1046         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1047         method.
1048         * tui/tui-data.h (struct tui_source_window_base)
1049         <location_matches_p>: New method.
1050         (struct tui_source_window, struct tui_disasm_window)
1051         <location_matches_p>: Likewise.
1052
1053 2019-07-17  Tom Tromey  <tom@tromey.com>
1054
1055         * tui/tui-win.c (tui_set_win_height_command): Rename from
1056         tui_set_win_height.
1057         (tui_set_win_height_command): Remove.
1058
1059 2019-07-17  Tom Tromey  <tom@tromey.com>
1060
1061         * tui/tui-source.c (tui_source_window): New constructor.  Add
1062         observer.
1063         (~tui_source_window): New destructor.
1064         (tui_source_window::style_changed): New method.
1065         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1066         (tui_attach_detach_observers): Update.
1067         * tui/tui-data.h (struct tui_source_window): Make constructor not
1068         inline.  Add destructor.
1069         (struct tui_source_window) <style_changed>: New method.
1070         <m_observable>: New member.
1071
1072 2019-07-17  Tom Tromey  <tom@tromey.com>
1073
1074         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1075         * tui/tui-win.c (tui_resize_all): Fix typo.
1076
1077 2019-07-17  Tom Tromey  <tom@tromey.com>
1078
1079         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1080         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1081         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1082         * tui/tui-win.c (window_name_completer): Use foreach.
1083         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1084         (update_tab_width): Likewise.
1085         * tui/tui-layout.c (show_layout): Update.
1086         * tui/tui-data.h (class tui_window_iterator): New.
1087         (struct all_tui_windows): New.
1088         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1089
1090 2019-07-17  Tom Tromey  <tom@tromey.com>
1091
1092         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1093         parameter.  Don't reference globals.
1094         (tui_reg_command): Update.
1095
1096 2019-07-17  Tom Tromey  <tom@tromey.com>
1097
1098         * tui/tui-regs.c (tui_show_registers): Simplify.
1099
1100 2019-07-17  Tom Tromey  <tom@tromey.com>
1101
1102         * tui/tui-regs.c (tui_show_registers): Update.
1103         (tui_show_register_group): Add win_info parameter.
1104
1105 2019-07-17  Tom Tromey  <tom@tromey.com>
1106
1107         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1108         Rename from tui_display_reg_element_at_line.
1109         (tui_data_window::display_registers_from_line): Update.
1110         * tui/tui-data.h (struct tui_data_window)
1111         <display_reg_element_at_line>: New method.
1112
1113 2019-07-17  Tom Tromey  <tom@tromey.com>
1114
1115         * tui/tui-regs.h (tui_display_registers_from)
1116         (tui_display_registers_from_line): Don't declare.
1117         * tui/tui-windata.c (tui_data_window::display_all_data)
1118         (tui_data_window::refresh_all)
1119         (tui_data_window::do_scroll_vertical): Update.
1120         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1121         from tui_display_registers_from.
1122         (tui_display_reg_element_at_line): Update.
1123         (tui_data_window::display_registers_from_line): Rename from
1124         tui_display_registers_from_line.
1125         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1126         display_registers_from_line>: New methods.
1127
1128 2019-07-17  Tom Tromey  <tom@tromey.com>
1129
1130         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1131         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1132         from tui_erase_data_content.
1133         (tui_data_window::display_all_data)
1134         (tui_data_window::refresh_all)
1135         (tui_data_window::do_scroll_vertical): Update.
1136         * tui/tui-regs.c (tui_show_registers): Update.
1137         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1138         New method.
1139
1140 2019-07-17  Tom Tromey  <tom@tromey.com>
1141
1142         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1143         declare.
1144         * tui/tui-windata.c
1145         (tui_data_window::delete_data_content_windows): Rename from
1146         tui_delete_data_content_windows.
1147         (tui_data_window::display_all_data)
1148         (tui_data_window::do_scroll_vertical): Update.
1149         * tui/tui-data.h (struct tui_data_window)
1150         <delete_data_content_windows>: New method.
1151
1152 2019-07-17  Tom Tromey  <tom@tromey.com>
1153
1154         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1155         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1156
1157 2019-07-17  Tom Tromey  <tom@tromey.com>
1158
1159         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1160         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1161         from tui_display_all_data.
1162         * tui/tui-win.c
1163         (tui_data_window::do_make_visible_with_new_height): Update.
1164         * tui/tui-regs.c (tui_show_registers): Update.
1165         * tui/tui-layout.c (tui_set_layout): Update.
1166         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1167         method.
1168
1169 2019-07-17  Tom Tromey  <tom@tromey.com>
1170
1171         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1172         * tui/tui-windata.c (tui_display_data_from): Remove.
1173         (tui_data_window::refresh_all): Update.
1174
1175 2019-07-17  Tom Tromey  <tom@tromey.com>
1176
1177         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1178         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1179         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1180         tui_display_registers_from_line.
1181         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1182         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1183         "force_display" parameter.
1184
1185 2019-07-17  Tom Tromey  <tom@tromey.com>
1186
1187         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1188         declare.
1189         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1190         Rename from tui_first_reg_element_no_inline.
1191         (tui_display_reg_element_at_line)
1192         (tui_display_registers_from_line): Update.
1193         * tui/tui-data.h (struct tui_data_window)
1194         <first_reg_element_no_inline>: New method.
1195
1196 2019-07-17  Tom Tromey  <tom@tromey.com>
1197
1198         * tui/tui-windata.c (tui_display_data_from)
1199         (tui_data_window::do_scroll_vertical): Update.
1200         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1201         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1202         Rename from tui_line_from_reg_element_no.
1203         (tui_display_registers_from_line): Update.
1204         * tui/tui-data.h (struct tui_data_window)
1205         <line_from_reg_element_no>: New method.
1206
1207 2019-07-17  Tom Tromey  <tom@tromey.com>
1208
1209         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1210         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1211         tui_last_regs_line_no.
1212         (tui_display_reg_element_at_line)
1213         (tui_display_registers_from_line): Update.
1214         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1215         method.
1216
1217 2019-07-17  Tom Tromey  <tom@tromey.com>
1218
1219         PR tui/24722:
1220         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1221         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1222         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1223         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1224         (tui_update_breakpoint_info): Likewise.
1225         * tui/tui-hooks.c (tui_event_create_breakpoint)
1226         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1227         Update.
1228
1229 2019-07-17  Tom Tromey  <tom@tromey.com>
1230
1231         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1232
1233 2019-07-17  Tom Tromey  <tom@tromey.com>
1234
1235         * tui/tui-winsource.c (tui_update_source_window_as_is)
1236         (tui_update_source_windows_with_addr): Update.
1237         * tui/tui-source.h (tui_set_source_content)
1238         (tui_show_symtab_source): Add "win_info" parameter.
1239         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1240         parameter.
1241         (tui_show_symtab_source): Likewise.
1242
1243 2019-07-17  Tom Tromey  <tom@tromey.com>
1244
1245         * tui/tui-wingeneral.c
1246         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1247
1248 2019-07-17  Tom Tromey  <tom@tromey.com>
1249
1250         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1251         (struct tui_cmd_window) <can_scroll>: New method.
1252         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1253         method.
1254
1255 2019-07-17  Tom Tromey  <tromey@adacore.com>
1256
1257         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1258         do_field_signed>: Rename.  Change type of "value".
1259         * ui-out.c (ui_out::field_signed): Rename from field_int.
1260         Change type of "value".
1261         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1262         type of "value".
1263         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1264         do_field_int.  Change type of "value".
1265         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1266         do_field_int.  Change type of "value".
1267         * tracepoint.c (trace_status_mi, tfind_1)
1268         (print_one_static_tracepoint_marker): Update.
1269         * thread.c (print_thread_info_1, print_selected_thread_frame):
1270         Update.
1271         * stack.c (print_frame, print_frame_info): Update.
1272         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1273         Update.
1274         * source.c (print_source_lines_base): Update.
1275         * skip.c (info_skip_command): Update.
1276         * record-btrace.c (btrace_ui_out_decode_error)
1277         (btrace_call_history_src_line): Update.
1278         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1279         Update.
1280         * progspace.c (print_program_space): Update.
1281         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1282         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1283         do_field_int.  Change type of "value".
1284         * mi/mi-out.c (mi_ui_out::do_table_begin)
1285         (mi_ui_out::do_table_header): Update.
1286         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1287         type of "value".
1288         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1289         (mi_cmd_data_list_changed_registers, output_register)
1290         (mi_cmd_data_read_memory, mi_load_progress)
1291         (mi_cmd_trace_frame_collected): Update.
1292         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1293         Update.
1294         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1295         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1296         (mi_cmd_var_list_children, varobj_update_one): Update.
1297         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1298         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1299         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1300         * inferior.c (print_inferior): Update.
1301         * gdb_bfd.c (print_one_bfd): Update.
1302         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1303         Update.
1304         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1305         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1306         do_field_int.  Change type of "value".
1307         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1308         do_field_int.  Change type of "value".
1309         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1310         (print_one_breakpoint_location, print_it_catch_fork)
1311         (print_one_catch_fork, print_it_catch_vfork)
1312         (print_one_catch_vfork, print_it_catch_solib)
1313         (print_it_catch_exec, print_it_ranged_breakpoint)
1314         (print_mention_watchpoint, print_mention_masked_watchpoint)
1315         (bkpt_print_it, update_static_tracepoint): Update.
1316         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1317         * break-catch-syscall.c (print_it_catch_syscall): Update.
1318         * ada-tasks.c (print_ada_task_info): Update.
1319         * ada-lang.c (print_it_exception, print_mention_exception):
1320         Update.
1321
1322 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1323
1324         PR breakpoints/24541
1325         * gdbarch.c: Regenerate.
1326         * gdbarch.h: Regenerate.
1327         * gdbarch.sh: Adjust return type and parameter types for
1328         'stap_adjust_register'.
1329         (i386_stap_adjust_register): Adjust signature and return new
1330         register name.
1331         * stap-probe.c (stap_parse_register_operand): Adjust use of
1332         'gdbarch_stap_adjust_register'.
1333
1334 2019-07-17  Tom Tromey  <tromey@adacore.com>
1335
1336         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1337         declare VEC.
1338         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1339         std::vector.
1340         (struct s390_process_info): Add initializers.
1341         (s390_add_process): Use new.
1342         (s390_linux_nat_target::low_forget_process): Use delete.
1343         (s390_linux_nat_target::low_new_fork)
1344         (s390_linux_nat_target::stopped_by_watchpoint)
1345         (s390_linux_nat_target::low_prepare_to_resume)
1346         (s390_linux_nat_target::insert_watchpoint)
1347         (s390_linux_nat_target::insert_hw_breakpoint)
1348         (s390_linux_nat_target::remove_watchpoint)
1349         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1350
1351 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1352
1353         * aarch64-fbsd-nat.c: Include regcache.h.
1354         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1355         argument.
1356         (aarch64_fbsd_nat_target::fetch_registers)
1357         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1358         variable.
1359         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1360
1361 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1362
1363         * fbsd-nat.c: Include gdbarch.h.
1364
1365 2019-07-15  Tom Tromey  <tromey@adacore.com>
1366
1367         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1368
1369 2019-07-15  Tom Tromey  <tromey@adacore.com>
1370
1371         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1372         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1373         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1374         * cli-out.c (cli_ui_out::do_field_int): New method.
1375         * ui-out.c (ui_out::field_unsigned): New method.
1376         * symfile.c (generic_load): Use field_unsigned.
1377         (print_transfer_performance): Likewise.
1378         * record-btrace.c (ui_out_field_uint): Remove.
1379         (btrace_call_history_insn_range, btrace_call_history): Use
1380         field_unsigned.
1381         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1382         field_unsigned.
1383         * ui-out.h (class ui_out) <field_unsigned>: New method.
1384         <do_field_unsigned>: Likewise.
1385
1386 2019-07-15  Tom Tromey  <tromey@adacore.com>
1387
1388         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1389         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1390         * target.c (flash_erase_command): Use field_string.
1391         * infrun.c (print_signal_received_reason): Use field_string.
1392         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1393         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1394         field_string.
1395         * ada-tasks.c (print_ada_task_info): Use field_string.
1396
1397 2019-07-15  Tom Tromey  <tromey@adacore.com>
1398
1399         * target.c (flash_erase_command): Use field_core_addr.
1400         * symfile.c (generic_load): Use field_core_addr.
1401         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1402         Use field_core_addr.
1403         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1404         field_core_addr.
1405
1406 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1407
1408         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1409         value if its desired type is smaller than a CORE_ADDR and signed.
1410
1411 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1412
1413         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1414         of changes to field names, and use new is_reference field to
1415         decide if a property is a reference or not.
1416         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1417         field.
1418         (struct dwarf2_property_baton): Update header comment, rename
1419         'referenced_type' to 'property_type' and update comments.
1420         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1421         default property type, store in property baton, update to take
1422         accound of renamed field.
1423         (read_func_scope): Update call to attr_to_dynamic_prop.
1424         (read_array_type): Likewise.
1425         (dwarf2_per_cu_addr_sized_int_type): New function.
1426         (read_subrange_index_type): Move type finding code to
1427         dwarf2_per_cu_addr_sized_int_type.
1428         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1429         (dwarf2_per_cu_addr_type): New function.
1430         (set_die_type): Update calls to attr_to_dynamic_prop.
1431
1432 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1433
1434         * dwarf2read.c (read_subrange_index_type): New function.
1435         (read_subrange_type): Move code into new function and call it.
1436         * gdbtypes.c (create_range_type): Add some asserts.
1437
1438 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1439
1440         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1441         update return statements.
1442         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1443         declaration, and update comment to match.
1444         * gdbtypes.c (resolve_dynamic_array): Update call to
1445         dwarf2_evaluate_property to match new return type.
1446
1447 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1448
1449         * valarith.c (value_subscripted_rvalue): Change lowerbound
1450         parameter type from int to LONGEST.
1451         * value.h (value_subscripted_rvalue): Likewise in declaration.
1452
1453 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1454
1455         * cli/cli-utils.c (info_print_command_completer): New function.
1456         * cli/cli-utils.h: Add 'completer.h' include, and forward
1457         declaration for 'struct cmd_list_element'.
1458         (info_print_command_completer): Declare.
1459         * stack.c (_initialize_stack): Add completer for 'info locals' and
1460         'info args'.
1461         * symtab.c (_initialize_symtab): Add completer for 'info
1462         variables' and 'info functions'.
1463         * NEWS: Mention completion for additional info commands.
1464
1465 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1466
1467         * cli/cli-utils.c (extract_info_print_args): Delete.
1468         (extract_arg_maybe_quoted): Delete.
1469         (info_print_options_defs): New variable.
1470         (make_info_print_options_def_group): New function.
1471         (extract_info_print_options): Define new function.
1472         * cli/cli-utils.h (extract_info_print_args): Delete.
1473         (struct info_print_options): New structure.
1474         (extract_info_print_options): Declare new function.
1475         * stack.c (info_locals_command): Update to use new
1476         extract_info_print_options, also add a header comment.
1477         (info_args_command): Likewise.
1478         * symtab.c (info_variables_command): Likewise.
1479         (info_functions_command): Likewise.
1480
1481 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1482
1483         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1484         to extract string arguments.
1485         * common/common-utils.c (extract_string_maybe_quoted): New function.
1486         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1487
1488 2019-07-11  Tom Tromey  <tromey@adacore.com>
1489
1490         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1491         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1492         * top.h (gdbinit): Don't declare.
1493         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1494         into...
1495         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1496         * top.c (gdb_init): Don't call init_cli_cmds.
1497         (gdbinit): Remove.
1498         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1499
1500 2019-07-11  Tom Tromey  <tromey@adacore.com>
1501
1502         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1503         after it has been moved.
1504
1505 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1506
1507         * valops.c (value_must_coerce_to_target): Change return type to
1508         bool.
1509         * value.h (value_must_coerce_to_target): Likewise.
1510
1511 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1512
1513         * breakpoint.c (is_hardware_watchpoint): Remove
1514         forward-declaration.
1515         (is_masked_watchpoint): Change return type to bool.
1516         (is_tracepoint): Likewise.
1517         (is_breakpoint): Likewise.
1518         (is_hardware_watchpoint): Likewise.
1519         (is_watchpoint): Likewise.
1520         (is_no_memory_software_watchpoint): Likewise.
1521         (is_catchpoint): Likewise.
1522         (breakpoint_1): Make FILTER parameter's return type bool.
1523         is_masked_watchpoint): Change return type to bool.
1524         (save_breakpoints): Make FILTER parameter's return type bool.
1525         * breakpoint.h (is_breakpoint): Change return type to bool.
1526         (is_watchpoint): Likewise.
1527         (is_catchpoint): Likewise.
1528         (is_tracepoint): Likewise.
1529
1530 2019-07-10  Tom Tromey  <tom@tromey.com>
1531
1532         * defs.h: Don't include gdbarch.h.
1533         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1534         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1535         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1536         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1537         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1538         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1539         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1540         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1541         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1542         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1543         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1544         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1545         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1546         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1547         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1548         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1549         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1550         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1551         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1552         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1553         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1554         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1555         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1556         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1557         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1558         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1559         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1560
1561 2019-07-10  Tom Tromey  <tromey@adacore.com>
1562
1563         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1564         * breakpoint.c (init_ada_exception_breakpoint): Register as
1565         bp_catchpoint.
1566         (print_one_breakpoint_location, print_one_breakpoint): Use
1567         is_ada_exception_catchpoint.
1568         * ada-lang.c (class ada_catchpoint_location): Pass
1569         bp_loc_software_breakpoint to bp_location constructor.
1570         (is_ada_exception_catchpoint): New function.
1571
1572 2019-07-10  Tom Tromey  <tromey@adacore.com>
1573
1574         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1575         VEC.
1576         (struct arm_exidx_entry): New method operator<.
1577         (struct arm_exidx_data) <section_maps>: Change type.
1578         (arm_exidx_data_free): Remove.
1579         (arm_exidx_data_key): Change type.  Move lower.
1580         (arm_exidx_new_objfile): Update.
1581         (arm_compare_exidx_entries): Remove.
1582         (arm_find_exidx_entry, _initialize_arm_tdep)
1583
1584 2019-07-10  Tom Tromey  <tromey@adacore.com>
1585
1586         * solib-spu.c (ocl_program_data_key): Change type.
1587         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1588         Update.
1589
1590 2019-07-10  Tom Tromey  <tromey@adacore.com>
1591
1592         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1593         (struct solib_aix_inferior_data) <library_list>: Change type.
1594         (solib_aix_inferior_data_handle): Change type.
1595         (get_solib_aix_inferior_data): Update.
1596         (solib_aix_free_library_list): Remove.
1597         (library_list_start_library): Update.
1598         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1599         return type.
1600         (solib_aix_get_library_list)
1601         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1602         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1603
1604 2019-07-10  Tom Tromey  <tromey@adacore.com>
1605
1606         * solib-dsbt.c (struct dsbt_info): Add initializers.
1607         (solib_dsbt_pspace_data): Change type.
1608         (dsbt_pspace_data_cleanup): Remove.
1609         (get_dsbt_info, _initialize_dsbt_solib): Update.
1610
1611 2019-07-10  Tom Tromey  <tromey@adacore.com>
1612
1613         * spu-tdep.c (spu_overlay_data): Change type.
1614         (spu_get_overlay_table, spu_overlay_new_objfile)
1615         (_initialize_spu_tdep): Update.
1616
1617 2019-07-10  Tom Tromey  <tromey@adacore.com>
1618
1619         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1620         destructor.
1621         (dbx_objfile_data_key): Change type and declare later.
1622         (DBX_SYMFILE_INFO): Rewrite.
1623         * dbxread.c (dbx_objfile_data_key): Change type.
1624         (dbx_symfile_init): Update.
1625         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1626         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1627         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1628
1629 2019-07-10  Tom Tromey  <tromey@adacore.com>
1630
1631         * jit.c (jit_program_space_key): Change type.  Move lower.
1632         (get_jit_program_space_data): Update.
1633         (jit_program_space_data_cleanup): Remove.
1634         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1635         Update.
1636         (struct jit_program_space_data): Add initializers.
1637
1638 2019-07-10  Tom Tromey  <tromey@adacore.com>
1639
1640         * solib-darwin.c (struct darwin_info): Add initializers.
1641         (solib_darwin_pspace_data): Change type.
1642         (darwin_pspace_data_cleanup): Remove.
1643         (get_darwin_info, _initialize_darwin_solib): Update.
1644
1645 2019-07-10  Tom Tromey  <tromey@adacore.com>
1646
1647         * remote-sim.c (struct sim_inferior_data): Add initializers,
1648         constructor, and destructor.
1649         (sim_inferior_data_key): Change type.  Move lower.
1650         (check_for_duplicate_sim_descriptor): Update.
1651         (get_sim_inferior_data): Use new.  Update.
1652         (~sim_inferior_data_cleanup): Rename from
1653         sim_inferior_data_cleanup.  Simplify.
1654         (gdbsim_close_inferior, simulator_command)
1655         (sim_command_completer, _initialize_remote_sim): Update.
1656         (next_pid, INITIAL_PID): Move earlier.
1657
1658 2019-07-10  Tom Tromey  <tromey@adacore.com>
1659
1660         * python/python-internal.h (create_thread_object): Return
1661         gdbpy_ref.
1662         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1663         * python/py-inferior.c (struct threadlist_entry): Add
1664         constructor.
1665         <thread_obj>: Now a gdbpy_ref.
1666         (thread_to_thread_object): Update.
1667         (add_thread_object): Use new.
1668         (delete_thread_object): Use delete.
1669         (infpy_threads): Update.
1670         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1671         GIL.
1672
1673 2019-07-10  Tom Tromey  <tromey@adacore.com>
1674
1675         * valops.c (value_cast): Specialize error message for Ada.
1676
1677 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1678
1679         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1680
1681 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1682
1683         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1684         bpstat_should_step): Return bool, adjust comments.
1685         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1686         bpstat_should_step): Likewise.
1687
1688 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1689
1690         * features/Makefile: Use feature target descriptions for Arm.
1691         * features/arm/arm-core.c: Generate new file.
1692         * features/arm/arm-fpa.c: Likewise.
1693         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1694         * features/arm/arm-m-profile.c: Likewise.
1695         * features/arm/arm-vfpv2.c: Likewise.
1696         * features/arm/arm-vfpv3.c: Likewise.
1697         * features/arm/xscale-iwmmxt.c: Likewise.
1698         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1699
1700 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1701
1702         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1703         ptrace earlier.
1704
1705 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1706
1707         * features/aarch64-pauth.c: Regenerate.
1708
1709 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1710
1711         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1712         bool.
1713         (bpstat_what): Use false instead of 0.
1714
1715 2019-07-09  Pedro Alves  <palves@redhat.com>
1716
1717         * break-catch-throw.c (is_exception_catchpoint): New.
1718         * breakpoint.c (print_one_breakpoint_location): New parameter
1719         'raw_loc'.  Handle it.  Use
1720         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1721         looking at the breakpoint's type.
1722         (print_one_breakpoint): If handling "maint info breakpoints", also
1723         print locations of exception catchpoints.
1724         * breakpoint.h (is_exception_catchpoint): Declare.
1725
1726 2019-07-09  Pedro Alves  <palves@redhat.com>
1727
1728         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1729         "addr" field.
1730         (allocate_location_exception_catchpoint): New.
1731         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1732         (initialize_throw_catchpoint_ops): Install
1733         allocate_location_exception_catchpoint as allocate_location
1734         method.
1735         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1736         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1737         bp_loc_other.
1738         (breakpoint_address_is_meaningful): Delete.
1739         (bl_address_is_meaningful): New.
1740         (breakpoint_locations_match): Adjust comment.
1741         (bp_location_from_bp_type): New, factored out of...
1742         (bp_location::bp_location(breakpoint *)): ... this.
1743         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1744         factored out of...
1745         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1746         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1747         breakpoint_address_is_meaningful.
1748         (bp_locations_compare): Adjust comment.
1749         (update_global_location_list): Use bl_address_is_meaningful
1750         instead of breakpoint_address_is_meaningful.
1751         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1752         explicit.
1753         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1754         * python/py-breakpoint.c (bppy_get_location): No longer check
1755         whether location is null.
1756
1757 2019-07-09  Pedro Alves  <palves@redhat.com>
1758
1759         PR c++/15468
1760         * breakpoint.c (print_one_breakpoint_location): Remove
1761         single-location assert.
1762
1763 2019-07-09  Tom Tromey  <tom@tromey.com>
1764
1765         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1766         * configure: Rebuild.
1767         * configure.ac: Change common to gdbsupport.
1768         * gdbsupport: Rename from common.
1769         * acinclude.m4: Change common to gdbsupport.
1770         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1771         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1772         gdbsupport.
1773         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1774         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1775         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1776         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1777         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1778         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1779         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1780         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1781         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1782         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1783         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1784         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1785         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1786         coff-pe-read.c, command.h, compile/compile-c-support.c,
1787         compile/compile-c.h, compile/compile-cplus-symbols.c,
1788         compile/compile-cplus-types.c, compile/compile-cplus.h,
1789         compile/compile-loc2c.c, compile/compile.c, completer.c,
1790         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1791         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1792         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1793         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1794         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1795         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1796         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1797         features/aarch64-core.c, features/aarch64-fpu.c,
1798         features/aarch64-pauth.c, features/aarch64-sve.c,
1799         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1800         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1801         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1802         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1803         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1804         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1805         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1806         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1807         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1808         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1809         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1810         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1811         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1812         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1813         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1814         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1815         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1816         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1817         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1818         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1819         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1820         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1821         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1822         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1823         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1824         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1825         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1826         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1827         minsyms.c, mips-linux-tdep.c, namespace.h,
1828         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1829         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1830         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1831         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1832         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1833         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1834         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1835         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1836         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1837         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1838         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1839         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1840         procfs.c, producer.c, progspace.h, psymtab.h,
1841         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1842         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1843         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1844         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1845         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1846         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1847         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1848         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1849         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1850         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1851         target-memory.c, target.c, target.h, target/waitstatus.c,
1852         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1853         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1854         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1855         unittests/array-view-selftests.c,
1856         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1857         unittests/common-utils-selftests.c,
1858         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1859         unittests/format_pieces-selftests.c,
1860         unittests/function-view-selftests.c,
1861         unittests/lookup_name_info-selftests.c,
1862         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1863         unittests/mkdir-recursive-selftests.c,
1864         unittests/observable-selftests.c,
1865         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1866         unittests/parse-connection-spec-selftests.c,
1867         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1868         unittests/scoped_fd-selftests.c,
1869         unittests/scoped_mmap-selftests.c,
1870         unittests/scoped_restore-selftests.c,
1871         unittests/string_view-selftests.c, unittests/style-selftests.c,
1872         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1873         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1874         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1875         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1876         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1877         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1878
1879 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1880
1881         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1882         bool value.
1883         (decode_digits_ordinary): Set explicit_line field in sal.
1884         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1885         symtab_and_line that was set on an explicit line number in
1886         assembler code.  Do always update the recorded symtab and line if
1887         we do skip the prologue.
1888
1889 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1890
1891         * breakpoint.c (set_breakpoint_location_function): Remove
1892         explicit_loc parameter.
1893         (momentary_breakpoint_from_master): Update call to
1894         set_breakpoint_location_function.
1895         (add_location_to_breakpoint): Likewise.
1896
1897 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1898
1899         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1900         required features based on default bfd type when no specific bfd
1901         is present.
1902
1903 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1904
1905         * NEWS: Mention that GDB printf and eval commands can now print
1906         C-style and Ada-style convenience var strings without
1907         calling the inferior.
1908         * printcmd.c (printf_c_string): Locally print GDB internal var
1909         instead of transiting via the inferior.
1910         (printf_wide_c_string): Likewise.
1911
1912 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1913
1914         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1915
1916 2019-07-04  Tom Tromey  <tom@tromey.com>
1917
1918         PR tui/24724:
1919         * tui/tui-winsource.c (tui_clear_source_content): Update.
1920         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1921         (tui_update_breakpoint_info): Update.
1922         (tui_set_exec_info_content): Update.
1923         * tui/tui-source.c (tui_set_source_content_nil): Update.
1924         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1925         has_break.
1926         * tui/tui-data.h (enum tui_bp_flag): New.
1927         (tui_bp_flags): New enum flags type.
1928         (struct tui_source_element) <break_mode>: Change type.  Rename
1929         from has_break.
1930         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1931         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1932         constants.
1933         * tui/tui-winsource.h: Fix comment.
1934
1935 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1936
1937         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1938         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1939         (store_fpregs_to_thread)
1940         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1941         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1942         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1943         (IWMMXT_REGS_SIZE): Add define.
1944         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1945         (fetch_vfp_regs, store_vfp_regs)
1946         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1947         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1948
1949 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1950
1951         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1952         defines.
1953         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1954         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1955         (ARM_INT_REGISTER_SIZE): ...to this.
1956         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1957         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1958         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1959         (arm_linux_collect_gregset, supply_nwfpe_register)
1960         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1961         defines.
1962         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1963         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1964         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1965         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1966         (arm_return_in_memory, arm_store_return_value)
1967         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1968         (arm_record_ld_st_multiple): Likewise.
1969         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1970         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1971
1972 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1973
1974         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1975         AARCH64_DISPLACED_MODIFIED_INSNS.
1976         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1977         (aarch64_displaced_step_copy_insn): Likewise.
1978         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1979         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1980         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1981         ARM_DISPLACED_MODIFIED_INSNS.
1982         * arm-tdep.c (arm_gdbarch_init): Likewise.
1983         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1984         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1985         (struct arm_displaced_step_closure): Use
1986         ARM_DISPLACED_MODIFIED_INSNS.
1987
1988 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1989
1990         * features/Makefile: Remove unused xml files.
1991         * features/aarch64.xml: Remove.
1992         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1993         * features/i386/amd64-avx-avx512.xml: Remove.
1994         * features/i386/amd64-avx-linux.xml: Remove.
1995         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1996         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1997         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1998         * features/i386/amd64-avx-mpx.xml: Remove.
1999         * features/i386/amd64-avx.xml: Remove.
2000         * features/i386/amd64-linux.xml: Remove.
2001         * features/i386/amd64-mpx-linux.xml: Remove.
2002         * features/i386/amd64-mpx.xml: Remove.
2003         * features/i386/amd64.xml: Remove.
2004         * features/i386/i386-avx-avx512-linux.xml: Remove.
2005         * features/i386/i386-avx-avx512.xml: Remove.
2006         * features/i386/i386-avx-linux.xml: Remove.
2007         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2008         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2009         * features/i386/i386-avx-mpx-linux.xml: Remove.
2010         * features/i386/i386-avx-mpx.xml: Remove.
2011         * features/i386/i386-avx.xml: Remove.
2012         * features/i386/i386-linux.xml: Remove.
2013         * features/i386/i386-mmx-linux.xml: Remove.
2014         * features/i386/i386-mmx.xml: Remove.
2015         * features/i386/i386-mpx-linux.xml: Remove.
2016         * features/i386/i386-mpx.xml: Remove.
2017         * features/i386/i386.xml: Remove.
2018         * features/i386/x32-avx-avx512-linux.xml: Remove.
2019         * features/i386/x32-avx-linux.xml: Remove.
2020         * features/i386/x32-linux.xml: Remove.
2021
2022 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2023
2024         * regformats/aarch64.dat: Remove.
2025         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2026         * regformats/i386/amd64-avx-linux.dat: Remove.
2027         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2028         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2029         * regformats/i386/amd64-linux.dat: Remove.
2030         * regformats/i386/amd64-mpx-linux.dat: Remove.
2031         * regformats/i386/amd64.dat: Remove.
2032         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2033         * regformats/i386/i386-avx-linux.dat: Remove.
2034         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2035         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2036         * regformats/i386/i386-linux.dat: Remove.
2037         * regformats/i386/i386-mmx-linux.dat: Remove.
2038         * regformats/i386/i386-mpx-linux.dat: Remove.
2039         * regformats/i386/i386.dat: Remove.
2040         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2041         * regformats/i386/x32-avx-linux.dat: Remove.
2042         * regformats/i386/x32-linux.dat: Remove.
2043
2044 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2045
2046         * aarch64-tdep.c: Remove xml self tests.
2047         * amd64-linux-tdep.c: Likewise.
2048         * amd64-tdep.c: Likewise.
2049         * i386-linux-tdep.c: Likewise.
2050         * i386-tdep.c: Likewise.
2051
2052 2019-07-03  Pedro Alves  <palves@redhat.com>
2053
2054         PR cli/24732
2055         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2056         (pipe_cmd_option_defs): New.
2057         (make_pipe_cmd_options_def_group): New.
2058         (pipe_command): Use gdb::option::process_options.
2059         (pipe_command_completer): New function.
2060         (_initialize_cli_cmds): Install completer for "pipe" command.
2061
2062 2019-07-03  Pedro Alves  <palves@redhat.com>
2063
2064         * cli/cli-option.c (union option_value) <string>: New field.
2065         (struct option_def_and_value): Add ctor, move ctor, dtor and
2066         use DISABLE_COPY_AND_ASSIGN.
2067         (option_def_and_value::clear_value): New.
2068         (parse_option, save_option_value_in_ctx, get_val_type_str)
2069         (add_setshow_cmds_for_options): Handle var_string.
2070         * cli-option.h (union option_def::var_address) <string>: New
2071         field.
2072         (struct string_option_def): New.
2073         * maint-test-options.c (struct test_options_opts): Add default
2074         ctor and use DISABLE_COPY_AND_ASSIGN.
2075         <string_opt>: New field.
2076         (test_options_opts::~test_options_opts): New.
2077         (test_options_opts::dump): Also dump "-string".
2078         (test_options_option_defs): Install "string.
2079
2080 2019-07-03  Pedro Alves  <palves@redhat.com>
2081
2082         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2083         option_value with a null enumeration.
2084         (complete_options): Save the option values in the context.
2085         (save_option_value_in_ctx): New, factored out from ...
2086         (process_options): ... here.
2087         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2088         of the function.
2089         * maint-test-options.c (test_options_opts::dump): New, factored
2090         out from ...
2091         (maintenance_test_options_command_mode): ... here.
2092         (maintenance_test_options_command_completion_result): Delete.
2093         (maintenance_test_options_command_completion_text): Update
2094         comment.
2095         (maintenance_show_test_options_completion_result): Change
2096         prototype.  Just print
2097         maintenance_test_options_command_completion_text.
2098         (save_completion_result): New.
2099         (maintenance_test_options_completer_mode): Pass options context to
2100         complete_options, and then save a dump.
2101         (_initialize_maint_test_options): Use add_cmd to install "maint
2102         show test-options-completion-result".
2103
2104 2019-07-03  Pedro Alves  <palves@redhat.com>
2105
2106         * NEWS (New commands): Mention "with" and "maint with".
2107         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2108         (with_command, with_command_completer): New.
2109         (pipe_command): Adjust to new repeat_previous
2110         interface.
2111         (_initialize_cli_cmds): Install the "with" command and its "w"
2112         alias.
2113         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2114         declarations.
2115         * cli/cli-setshow.c (parse_cli_var_uinteger)
2116         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2117         argument strings for all var_types.
2118         (get_setshow_command_value_string): New, factored out from ...
2119         (do_show_command): ... this.
2120         * cli/cli-setshow.h: Include <string>.
2121         (get_setshow_command_value_string): Declare.
2122         * command.h (repeat_previous): Now returns const char *.  Adjust
2123         comment.
2124         * maint.c: Include "cli/cli-cmds.h".
2125         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2126         (_initialize_maint_cmds): Register the "maintenance with" command.
2127         * top.c (repeat_previous): Move bits from pipe_command here:
2128         Return the saved command line, if any; error out if there's no
2129         command to relaunch.
2130
2131 2019-07-03  Pedro Alves  <palves@redhat.com>
2132
2133         * NEWS (New commands): Mention "maint set/show test-settings"
2134         instead of "maint test-settings".
2135         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2136         (maintenance_test_settings_set_list): Rename to ...
2137         (maintenance_set_test_settings_list): ... this.
2138         (maintenance_test_settings_show_list): Rename to  ...
2139         (maintenance_show_test_settings_list): ... this.
2140         (maintenance_test_settings_cmd): Delete.
2141         (maintenance_test_settings_set_cmd): ...
2142         (maintenance_set_test_settings_cmd): ... this.
2143         (maintenance_test_settings_show_cmd): ...
2144         (maintenance_show_test_settings_cmd): ... this.
2145         (maintenance_test_settings_show_value_cmd):
2146         (maintenance_show_test_settings_value_cmd): ... this.
2147         (_initialize_maint_test_settings): No longer install the "maint
2148         test-settings" prefix command.  Rename "maint test-settings set"
2149         to "maint set test-settings", and "maint test-settings show" to
2150         "maint show test-settings".  Adjust all subcommands.
2151
2152 2019-07-03  Pedro Alves  <palves@redhat.com>
2153
2154         * maint-test-settings.c: Fix file's intro comment.  Replace all
2155         references to "test-options" with references to "test-settings",
2156         in comments.
2157
2158 2019-07-03  Pedro Alves  <palves@redhat.com>
2159
2160         * maint-test-settings.c (maintenance_test_settings_xxx)
2161         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2162         New.
2163         (maintenance_test_settings_enums): Use them.
2164         (maintenance_test_settings_enum): Default to
2165         maintenance_test_settings_xxx.
2166         (_initialize_maint_test_settings): Initialize
2167         MAINTENANCE_TEST_SETTINGS_FILENAME.
2168
2169 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2170
2171         * breakpoint.h (remove_breakpoints_inf): Change return type to
2172         void, move function documentation here.
2173         * breakpoint.c (remove_breakpoints_inf): Change return type to
2174         void, move function documentation to header.
2175
2176 2019-07-02  Pedro Alves  <palves@redhat.com>
2177
2178         * NEWS (Completion improvements): Mention "info threads".
2179         * thread.c (struct info_threads_opts, info_threads_option_defs)
2180         (make_info_threads_options_def_group): New.
2181         (info_threads_command): Use gdb::option::process_options.
2182         (info_threads_command_completer): New.
2183         (_initialize_thread): Use gdb::option::build_help to build the
2184         help text for "info threads".
2185
2186 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2187
2188         * defs.h (generic_load): Move from here...
2189         * symfile.h (generic_load): ... to here.  Rename name parameter
2190         to args.
2191         * symfile.c (generic_load): Add comment.
2192
2193 2019-07-01  Tom Tromey  <tromey@adacore.com>
2194
2195         * dwarf2read.c
2196         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2197         declaration of without_params.  Fix formatting.
2198
2199 2019-07-01  Tom Tromey  <tromey@adacore.com>
2200
2201         * ada-exp.y (find_primitive_type): Update.
2202         * ada-lang.h (ada_lookup_symbol): Update.
2203         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2204         parameter.
2205         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2206
2207 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2208
2209         PR breakpoints/24541
2210         * gdbarch.c: Regenerate.
2211         * gdbarch.h: Regenerate.
2212         * gdbarch.sh: Add 'stap_adjust_register'.
2213         * i386-tdep.c: Include '<unordered_set>'.
2214         (i386_stap_adjust_register): New function.
2215         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2216         * stap-probe.c (stap_parse_register_operand): Call
2217         'gdbarch_stap_adjust_register'.
2218
2219 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2220
2221         PR python/24742
2222         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2223         * python/python.c (do_start_initialization): Use 'xmalloc'
2224         instead of 'PyMem_Malloc'.
2225
2226 2019-06-28  Tom Tromey  <tromey@adacore.com>
2227
2228         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2229         for Ada.
2230
2231 2019-06-27  Tom Tromey  <tromey@adacore.com>
2232
2233         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2234         objfile_key.
2235         (arm_find_mapping_symbol, arm_record_special_symbol)
2236         (_initialize_arm_tdep): Update.
2237         (arm_objfile_data_free): Remove.
2238
2239 2019-06-27  Tom Tromey  <tromey@adacore.com>
2240
2241         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2242         to cp_print_static_field.
2243
2244 2019-06-26  Tom Tromey  <tromey@adacore.com>
2245
2246         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2247         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2248         declare.
2249
2250 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2251
2252         * features/aarch64-core.c (create_feature_aarch64_core):
2253         Regenerate.
2254         * features/aarch64-core.xml: Add cpsr flags.
2255
2256 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2257
2258         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2259         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2260
2261 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2262
2263         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2264         field.
2265         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2266         use.
2267         (arm_record_special_symbol): Don't insert new symbol in sorted
2268         position, push it at the end.
2269
2270 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2271
2272         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2273         (arm_mapping_symbol_s): Remove.
2274         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2275         (arm_mapping_symbol_vec): New typedef.
2276         (struct arm_per_objfile): Add constructor.
2277         <section_maps>: Change type to
2278         std::unique_ptr<arm_mapping_symbol_vec[]>.
2279         (arm_compare_mapping_symbols): Remove.
2280         (arm_find_mapping_symbol): Adjust to section_maps type change.
2281         (arm_objfile_data_free): Call delete on arm_per_objfile.
2282         (arm_record_special_symbol): Adjust to section_maps type change.
2283         Allocate arm_per_objfile with new.
2284
2285 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2286
2287         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2288         with the command prefix.
2289
2290 2019-06-25  Tom Tromey  <tom@tromey.com>
2291
2292         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2293         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2294
2295 2019-06-25  Tom Tromey  <tom@tromey.com>
2296
2297         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2298         type.
2299         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2300         protected.
2301
2302 2019-06-25  Tom Tromey  <tom@tromey.com>
2303
2304         * tui/tui-winsource.c
2305         (tui_source_window_base::set_is_exec_point_at): Add check against
2306         LOA_ADDRESS.
2307
2308 2019-06-25  Tom Tromey  <tom@tromey.com>
2309
2310         * tui/tui-source.c (tui_set_source_content): Don't check before
2311         xfree.
2312         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2313
2314 2019-06-25  Tom Tromey  <tom@tromey.com>
2315
2316         * tui/tui-winsource.h (tui_update_source_window_as_is)
2317         (tui_alloc_source_buffer, tui_line_is_displayed)
2318         (tui_addr_is_displayed): Change type of win_info.
2319         * tui/tui-winsource.c (tui_update_source_window_as_is)
2320         (tui_clear_source_content, tui_show_source_line)
2321         (tui_show_source_content, tui_source_window_base::refill)
2322         (tui_source_window_base::set_is_exec_point_at)
2323         (tui_source_window_base::set_is_exec_point_at)
2324         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2325         (tui_alloc_source_buffer, tui_line_is_displayed)
2326         (tui_addr_is_displayed): Change type of win_info.  Update.
2327         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2328         (tui_source_window_base::do_make_visible_with_new_height):
2329         Update.
2330         * tui/tui-source.c (tui_set_source_content)
2331         (tui_set_source_content_nil)
2332         (tui_source_window::do_scroll_vertical): Update.
2333         * tui/tui-layout.c (show_layout): Update.
2334         * tui/tui-disasm.c (tui_set_disassem_content)
2335         (tui_disasm_window::do_scroll_vertical): Update.
2336         * tui/tui-data.h (tui_win_content): Remove.
2337         (struct tui_gen_win_info) <content, content_size>: Remove.
2338         (struct tui_source_element): Add initializers and destructor.
2339         (union tui_which_element, struct tui_win_element): Remove.
2340         (struct tui_source_window_base) <content>: New field.
2341         (struct tui_data_window): Remove destructor.
2342         (tui_alloc_content, tui_free_win_content)
2343         (tui_free_all_source_wins_content): Don't declare.
2344         * tui/tui-data.c (tui_initialize_static_data): Update.
2345         (init_content_element, tui_alloc_content): Remove.
2346         (~tui_gen_win_info): Update.
2347         (~tui_data_window, tui_free_all_source_wins_content)
2348         (tui_free_win_content, free_content, free_content_elements):
2349         Remove.
2350
2351 2019-06-25  Tom Tromey  <tom@tromey.com>
2352
2353         * tui/tui-winsource.h (tui_clear_source_content)
2354         (tui_erase_source_content, tui_show_source_content): Change type
2355         of win_info.
2356         * tui/tui-winsource.c (tui_clear_source_content)
2357         (tui_erase_source_content, tui_show_source_content): Change type
2358         of win_info.
2359         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2360         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2361         win_info.
2362         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2363         win_info.
2364         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2365
2366 2019-06-25  Tom Tromey  <tom@tromey.com>
2367
2368         * tui/tui-winsource.c (tui_clear_source_content)
2369         (tui_source_window_base::set_is_exec_point_at): Update.
2370         * tui/tui-source.c (tui_set_source_content_nil): Update.
2371         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2372         a bool.
2373         * tui/tui-data.c (init_content_element): Update.
2374
2375 2019-06-25  Tom Tromey  <tom@tromey.com>
2376
2377         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2378         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2379         * tui/tui-layout.c (init_and_make_win): Update.
2380         * tui/tui.h (enum tui_win_type): Update.
2381         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2382         tui_win_is_auxillary.
2383         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2384         tui_win_is_auxillary.
2385
2386 2019-06-25  Tom Tromey  <tom@tromey.com>
2387
2388         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2389         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2390         (tui_delete_data_content_windows, tui_display_all_data)
2391         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2392         Update.
2393         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2394         * tui/tui-regs.c (tui_last_regs_line_no)
2395         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2396         (tui_show_registers): Update.
2397         (tui_show_register_group): Return void.  Update.
2398         (tui_display_registers_from, tui_display_reg_element_at_line)
2399         (tui_display_registers_from_line, tui_check_register_values):
2400         Update.
2401         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2402         member.
2403         (struct tui_data_window) <regs_content>: Now a std::vector.
2404         <regs_content_count>: Remove.
2405         (tui_add_content_elements, tui_free_data_content): Don't declare.
2406         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2407         (init_content_element): Remove DATA_WIN case.  Add assert.
2408         (tui_add_content_elements): Remove.
2409         (tui_data_window): Update.
2410         (tui_free_data_content): Remove.
2411         (free_content_elements): Remove DATA_WIN case.
2412
2413 2019-06-25  Tom Tromey  <tom@tromey.com>
2414
2415         * tui/tui-data.c (tui_data_item_window): Update.
2416         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2417         * tui/tui-windata.c (tui_display_all_data)
2418         (tui_display_data_from_line): Update.
2419         (tui_check_data_values): Remove.
2420         * tui/tui-regs.c (tui_show_register_group)
2421         (tui_display_reg_element_at_line): Update.
2422         * tui/tui-hooks.c (tui_register_changed)
2423         (tui_refresh_frame_and_register_information): Call
2424         tui_check_register_values.
2425         * tui/tui-data.h (struct tui_data_window) <data_content,
2426         data_content_count, data_type>: Remove.
2427         (enum tui_data_type): Remove.
2428
2429         * tui/tui-data.c (tui_data_window::clear_detail)
2430         (~tui_data_window): Update.
2431
2432 2019-06-25  Tom Tromey  <tom@tromey.com>
2433
2434         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2435         declare.
2436         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2437         Rename from tui_first_data_item_displayed.  Update.
2438         (tui_data_window::refresh_all)
2439         (tui_data_window::do_scroll_vertical): Update.
2440         * tui/tui-data.h (struct tui_data_window)
2441         <first_data_item_displayed>: Declare new method.
2442
2443 2019-06-25  Tom Tromey  <tom@tromey.com>
2444
2445         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2446         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2447         contents...
2448         (tui_initialize_static_data): ...here.
2449
2450 2019-06-25  Tom Tromey  <tom@tromey.com>
2451
2452         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2453         (tui_display_registers_from, tui_check_register_values): Update.
2454         (tui_display_register): Remove win_info parameter; update.
2455         (tui_get_register): Change type of parameters.
2456         * tui/tui-data.h (struct tui_data_element): Remove.
2457         (union tui_which_element) <data>: Remove.
2458         <data_window>: Change type.
2459         (struct tui_data_item_window): New.
2460         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2461         case.  Add assert.
2462         (~tui_data_item_window): New destructor.
2463         (free_content_elements): Remove DATA_ITEM_WIN case.
2464
2465 2019-06-25  Tom Tromey  <tom@tromey.com>
2466
2467         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2468         Remove.
2469
2470 2019-06-25  Tom Tromey  <tom@tromey.com>
2471
2472         * tui/tui-data.h (struct tui_command_element): Remove.
2473         (union tui_which_element) <command>: Remove.
2474         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2475         assert.
2476         (free_content_elements): Remove CMD_WIN case.
2477
2478 2019-06-25  Tom Tromey  <tom@tromey.com>
2479
2480         * tui/tui-layout.c (tui_set_layout): Update.
2481         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2482         * tui/tui-data.c (layout_def): Update.
2483
2484 2019-06-25  Tom Tromey  <tom@tromey.com>
2485
2486         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2487         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2488         (tui_source_window_base::set_new_height): Update.
2489         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2490         Update.
2491         (tui_set_locator_fullname, tui_set_locator_info)
2492         (tui_show_frame_info): Update.
2493         * tui/tui-source.c (tui_set_source_content)
2494         (tui_source_is_displayed): Update.
2495         * tui/tui-layout.c (show_source_disasm_command, show_data)
2496         (show_source_or_disasm_and_command): Update.
2497         * tui/tui-disasm.c (tui_set_disassem_content)
2498         (tui_get_begin_asm_address): Update.
2499         * tui/tui-data.h (struct tui_locator_element): Remove.
2500         (union tui_which_element) <locator>: Remove.
2501         (struct tui_locator_window): New.
2502         (tui_locator_win_info_ptr): Change return type.
2503         * tui/tui-data.c (_locator): Change type.
2504         (tui_locator_win_info_ptr): Change return type.
2505         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2506         (tui_alloc_content): Add assert.
2507
2508 2019-06-25  Tom Tromey  <tom@tromey.com>
2509
2510         * tui/tui-winsource.c
2511         (tui_exec_info_window::maybe_allocate_content): New method.
2512         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2513         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2514         (make_source_or_disasm_window): Add cast.
2515         * tui/tui-data.h (union tui_which_element) <simple_string>:
2516         Remove.
2517         (struct tui_source_info): New.
2518         (struct tui_source_window_base) <execution_info>: Change type.
2519         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2520         case, and add assert.
2521         (tui_alloc_content): Add assert.
2522
2523 2019-06-25  Tom Tromey  <tom@tromey.com>
2524
2525         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2526         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2527         * tui/tui-data.c (tui_alloc_win_info): Remove.
2528
2529 2019-06-25  Tom Tromey  <tom@tromey.com>
2530
2531         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2532         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2533         can_highlight.
2534
2535 2019-06-25  Tom Tromey  <tom@tromey.com>
2536
2537         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2538         make_visible_with_new_height method.
2539         (tui_win_info::make_visible_with_new_height): New method.
2540         (tui_source_window_base::do_make_visible_with_new_height)
2541         (tui_data_window::do_make_visible_with_new_height)
2542         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2543         (make_visible_with_new_height): Remove.
2544         (tui_resize_all, tui_adjust_win_heights): Use
2545         make_visible_with_new_height method.
2546         * tui/tui-data.h (struct tui_win_info)
2547         <do_make_visible_with_new_height, make_visible_with_new_height>:
2548         New methods.
2549         (struct tui_source_window_base, struct tui_data_window)
2550         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2551         methods.
2552
2553 2019-06-25  Tom Tromey  <tom@tromey.com>
2554
2555         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2556         method.
2557         (update_tab_width): Call update_tab_width method.
2558         * tui/tui-data.h (struct tui_win_info)
2559         (struct tui_source_window_base) <update_tab_width>: New methods.
2560
2561 2019-06-25  Tom Tromey  <tom@tromey.com>
2562
2563         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2564         parameter.
2565         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2566         parameter.
2567         (tui_gen_win_info::make_visible): Update.
2568         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2569         parameter.
2570         * tui/tui-data.h (enum tui_box): New enum.
2571         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2572
2573 2019-06-25  Tom Tromey  <tom@tromey.com>
2574
2575         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2576         init_and_make_win for EXEC_INFO_WIN.
2577         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2578         longer inline.
2579         (struct tui_win_info) <~tui_win_info>: Inline.
2580         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2581         Don't declare.
2582         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2583         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2584         Remove.
2585         (tui_initialize_static_data): Update.
2586         (~tui_gen_win_info): Handle more cleanup here.
2587         (~tui_source_window_base): Delete "execution_info".
2588         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2589
2590 2019-06-25  Tom Tromey  <tom@tromey.com>
2591
2592         * tui/tui-layout.c (make_command_window): Don't set
2593         can_highlight.
2594         (show_source_disasm_command): Call the reset method.
2595         (show_data): Don't set can_highlight.  Call the reset method.
2596         (tui_gen_win_info::reset): Rename from init_gen_win_info
2597         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2598         (show_source_or_disasm_and_command): Call the reset method.
2599         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2600         (struct tui_cmd_window): Set can_highlight.
2601
2602 2019-06-25  Tom Tromey  <tom@tromey.com>
2603
2604         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2605         from make_visible.
2606         (tui_make_visible, tui_make_invisible): Rewrite.
2607         (tui_win_info::make_visible): Remove.
2608         (tui_source_window_base::make_visible): Update.
2609         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2610         method.  Moved from...
2611         (struct tui_win_info) <make_visible>: ...here.
2612
2613 2019-06-25  Tom Tromey  <tom@tromey.com>
2614
2615         * tui/tui-winsource.c
2616         (tui_source_window_base::do_scroll_horizontal): Remove direction
2617         parameter.
2618         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2619         direction parameter.
2620         * tui/tui-win.c (tui_win_info::forward_scroll)
2621         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2622         (tui_win_info::right_scroll): Update.
2623         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2624         direction parameter.
2625         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2626         direction parameter.
2627         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2628         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2629         Remove direction parameter.
2630         (struct tui_source_window_base, struct tui_source_window)
2631         (struct tui_disasm_window, struct tui_data_window)
2632         (struct tui_cmd_window): Update.
2633
2634 2019-06-25  Tom Tromey  <tom@tromey.com>
2635
2636         * tui/tui-winsource.h (tui_set_exec_info_content)
2637         (tui_show_exec_info_content, tui_erase_exec_info_content)
2638         (tui_clear_exec_info_content, tui_update_exec_info): Change
2639         argument to tui_source_window_base.
2640         * tui/tui-winsource.c (tui_set_exec_info_content)
2641         (tui_show_exec_info_content, tui_erase_exec_info_content)
2642         (tui_clear_exec_info_content, tui_update_exec_info): Change
2643         argument to tui_source_window_base.
2644
2645 2019-06-25  Tom Tromey  <tom@tromey.com>
2646
2647         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2648         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2649
2650 2019-06-25  Tom Tromey  <tom@tromey.com>
2651
2652         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2653         check.
2654
2655 2019-06-25  Tom Tromey  <tom@tromey.com>
2656
2657         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2658         type to void.
2659         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2660         type to void.
2661         * tui/tui-source.c (tui_set_source_content): Update.
2662         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2663
2664 2019-06-25  Tom Tromey  <tom@tromey.com>
2665
2666         * tui/tui-win.c (window_name_completer, tui_set_focus)
2667         (tui_all_windows_info): Use name method.
2668         * tui/tui-data.h (struct tui_gen_win_info)
2669         (struct tui_source_window, struct tui_disasm_window)
2670         (struct tui_data_window, struct tui_cmd_window) <name>: New
2671         method.
2672         (tui_win_name): Don't declare.
2673         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2674         (tui_win_name): Remove.
2675
2676 2019-06-25  Tom Tromey  <tom@tromey.com>
2677
2678         * tui/tui-winsource.h (tui_update_source_window)
2679         (tui_update_source_window_as_is): Change parameter type.
2680         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2681         to be a tui_source_window_base.
2682         (tui_update_source_window_as_is): Likewise.
2683         * tui/tui-win.c (make_visible_with_new_height): Update.
2684
2685 2019-06-25  Tom Tromey  <tom@tromey.com>
2686
2687         * tui/tui-winsource.c (tui_erase_source_content)
2688         (tui_show_source_content, tui_show_exec_info_content)
2689         (tui_erase_exec_info_content): Use refresh_window method.
2690         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2691         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2692         from tui_refresh_win.
2693         (tui_data_window::refresh_window): New method.
2694         (tui_win_info::refresh, tui_source_window_base::refresh)
2695         (tui_refresh_all): Use refresh_window method.
2696         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2697         method.
2698         * tui/tui-regs.c (tui_display_register): Call refresh_window
2699         method.
2700         * tui/tui-layout.c (show_source_disasm_command)
2701         (show_source_or_disasm_and_command): Call refresh_window method.
2702         * tui/tui-data.h (struct tui_gen_win_info)
2703         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2704         New method.
2705
2706 2019-06-25  Tom Tromey  <tom@tromey.com>
2707
2708         * tui/tui.c (tui_rl_other_window, tui_enable)
2709         (tui_is_window_visible, tui_get_command_dimension): Update.
2710         * tui/tui-winsource.c (tui_update_source_window_as_is)
2711         (tui_clear_source_content, tui_erase_source_content)
2712         (tui_show_source_line, tui_source_window_base::refill)
2713         (tui_source_window_base::do_scroll_horizontal)
2714         (tui_source_window_base::set_is_exec_point_at)
2715         (tui_update_breakpoint_info, tui_set_exec_info_content)
2716         (tui_alloc_source_buffer, tui_line_is_displayed)
2717         (tui_addr_is_displayed): Update.
2718         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2719         (tui_check_and_display_highlight_if_needed)
2720         (tui_win_info::make_visible, tui_win_info::refresh)
2721         (tui_refresh_all): Update.
2722         * tui/tui-windata.c (tui_first_data_item_displayed)
2723         (tui_delete_data_content_windows, tui_erase_data_content)
2724         (tui_display_all_data, tui_data_window::refresh_all)
2725         (tui_check_data_values): Update.
2726         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2727         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2728         (tui_win_info::backward_scroll, tui_refresh_all_win)
2729         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2730         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2731         (tui_source_window_base::set_new_height)
2732         (tui_data_window::set_new_height)
2733         (make_invisible_and_set_new_height)
2734         (make_visible_with_new_height, new_height_ok)
2735         (parse_scrolling_args): Update.
2736         * tui/tui-stack.c (tui_show_frame_info): Update.
2737         * tui/tui-source.c (tui_set_source_content)
2738         (tui_set_source_content_nil, tui_source_is_displayed)
2739         (tui_source_window::do_scroll_vertical): Update.
2740         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2741         (tui_display_registers_from, tui_display_reg_element_at_line)
2742         (tui_check_register_values, tui_reg_command): Update.
2743         * tui/tui-layout.c (tui_default_win_height)
2744         (show_source_disasm_command, show_data, init_and_make_win)
2745         (show_source_or_disasm_and_command): Update.
2746         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2747         (tui_redisplay_readline, tui_mld_flush)
2748         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2749         (tui_getc): Update.
2750         * tui/tui-disasm.c (tui_set_disassem_content)
2751         (tui_disasm_window::do_scroll_vertical): Update.
2752         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2753         Now virtual.
2754         (struct tui_win_info): Derive from tui_gen_win_info.
2755         <~tui_win_info>: Mark as override.
2756         <generic>: Remove member.
2757         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2758         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2759         (~tui_data_window, ~tui_win_info)
2760         (tui_free_all_source_wins_content): Update.
2761         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2762
2763 2019-06-25  Tom Tromey  <tom@tromey.com>
2764
2765         * tui/tui-layout.c (init_and_make_win): Use new.
2766         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2767         destructor, initializers.
2768         (tui_alloc_generic_win_info): Don't declare.
2769         * tui/tui-data.c (_locator): Add argument to constructor.
2770         (source_win, disasm_win): New globals.
2771         (exec_info): Remove.
2772         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2773         Update.
2774         (tui_alloc_generic_win_info): Remove.
2775         (init_content_element): Use new.
2776         (tui_win_info::tui_win_info): Update.
2777         (free_content_elements) <case DATA_WIN>: Use delete.
2778
2779 2019-06-25  Tom Tromey  <tom@tromey.com>
2780
2781         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2782         * tui/tui-windata.c (tui_first_data_item_displayed)
2783         (tui_delete_data_content_windows): Update.
2784         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2785         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2786         (tui_display_registers_from, tui_check_register_values): Update.
2787         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2788         pointer.
2789         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2790         window.
2791         (tui_free_data_content): Update.
2792         (free_content_elements) <case DATA_WIN>: Free the window.
2793
2794 2019-06-25  Tom Tromey  <tom@tromey.com>
2795
2796         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2797         Update.
2798         * tui/tui-layout.c (make_command_window)
2799         (show_source_disasm_command, show_data, init_and_make_win)
2800         (show_source_or_disasm_and_command): Update.
2801         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2802         method.
2803         <can_highight, is_highlighted>: Now bool.
2804         (tui_set_win_highlight): Don't declare.
2805         * tui/tui-data.c (tui_set_win_highlight): Remove.
2806
2807 2019-06-25  Tom Tromey  <tom@tromey.com>
2808
2809         * tui/tui-wingeneral.c (make_visible): Remove check of window
2810         type.
2811
2812 2019-06-25  Tom Tromey  <tom@tromey.com>
2813
2814         * tui/tui-win.c (tui_win_info::max_height)
2815         (tui_cmd_window::max_height): New methods.
2816         (new_height_ok): Call max_height.
2817         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2818         <max_height>: New method.
2819
2820 2019-06-25  Tom Tromey  <tom@tromey.com>
2821
2822         * tui/tui-win.c (tui_source_window_base::set_new_height)
2823         (tui_data_window::set_new_height): New methods.
2824         (make_invisible_and_set_new_height): Call set_new_height method.
2825         * tui/tui-data.h (struct tui_win_info)
2826         (struct tui_source_window_base, struct tui_data_window)
2827         <set_new_height>: New method.
2828
2829 2019-06-25  Tom Tromey  <tom@tromey.com>
2830
2831         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2832         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2833         tui_refresh_data_win.
2834         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2835         method.
2836         (tui_refresh_all_win): Call the refresh_all method.
2837         (tui_set_focus): Likewise.
2838         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2839         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2840         Likewise.
2841
2842 2019-06-25  Tom Tromey  <tom@tromey.com>
2843
2844         * tui/tui-winsource.h (tui_refill_source_window)
2845         (tui_set_is_exec_point_at): Don't declare.
2846         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2847         (tui_source_window_base::refill): Rename from
2848         tui_refill_source_window.
2849         (tui_source_window_base::do_scroll_horizontal): Update.
2850         (tui_source_window_base::set_is_exec_point_at): Rename from
2851         tui_set_is_exec_point_at.
2852         (tui_update_all_breakpoint_info): Update.
2853         * tui/tui-stack.c (tui_show_frame_info): Update.
2854         * tui/tui-layout.c (show_data): Add cast.
2855         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2856         * tui/tui-data.h (struct tui_source_window_base) <refill,
2857         set_is_exec_point_at>: New methods.
2858         (tui_source_windows, tui_add_to_source_windows): Update types.
2859         (tui_add_to_source_windows): Remove redundant declaration.
2860         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2861         (tui_source_windows): Change return type.
2862         (tui_clear_source_windows_detail): Update.
2863         (tui_add_to_source_windows): Change type of parameter.
2864         (tui_free_all_source_wins_content): Update.
2865
2866 2019-06-25  Tom Tromey  <tom@tromey.com>
2867
2868         * tui/tui-wingeneral.c (tui_win_info::refresh)
2869         (tui_source_window_base::refresh): New methods.
2870         (tui_refresh_all): Call the refresh method.
2871         * tui/tui-data.h (struct tui_win_info)
2872         (struct tui_source_window_base) <refresh>: New method.
2873
2874 2019-06-25  Tom Tromey  <tom@tromey.com>
2875
2876         * tui/tui.h (tui_is_window_visible): Return bool.
2877         * tui/tui.c (tui_is_window_visible): Return bool.
2878         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2879         (tui_make_visible, tui_make_invisible)
2880         (tui_win_info::make_visible)
2881         (tui_source_window_base::make_visible, make_all_visible)
2882         (tui_make_all_visible, tui_make_all_invisible): Update.
2883         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2884         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2885         bool.
2886         (struct tui_win_info, struct tui_source_window_base)
2887         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2888         * tui/tui-data.c (tui_init_generic_part): Update.
2889
2890 2019-06-25  Tom Tromey  <tom@tromey.com>
2891
2892         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2893         (tui_source_window_base::make_visible): New methods.
2894         (make_all_visible): Make method call.
2895         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2896         (struct tui_source_window_base, struct tui_cmd_window): Override
2897         make_visible.
2898         (tui_win_is_source_type): Don't declare.
2899         * tui/tui-data.c (tui_win_is_source_type): Remove.
2900
2901 2019-06-25  Tom Tromey  <tom@tromey.com>
2902
2903         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2904         NULL check.
2905
2906 2019-06-25  Tom Tromey  <tom@tromey.com>
2907
2908         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2909         Inline constructor.  Add initializers for members.
2910         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2911         constructors; now inline in class.
2912
2913 2019-06-25  Tom Tromey  <tom@tromey.com>
2914
2915         * tui/tui-regs.c (tui_show_registers): Update.
2916         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2917         bool.
2918         * tui/tui-data.c (tui_data_window::clear_detail)
2919         (tui_data_window): Update.
2920
2921 2019-06-25  Tom Tromey  <tom@tromey.com>
2922
2923         * tui/tui-windata.c (tui_display_all_data)
2924         (tui_display_data_from_line, tui_display_data_from)
2925         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2926         Update.
2927         * tui/tui-regs.c (tui_last_regs_line_no)
2928         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2929         (tui_show_registers, tui_show_register_group)
2930         (tui_display_registers_from, tui_display_reg_element_at_line)
2931         (tui_display_registers_from_line, tui_check_register_values)
2932         (tui_reg_next, tui_reg_prev): Update.
2933         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2934         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2935         tui_data_window.
2936         (struct tui_win_info) <detail>: Remove.  Add new fields from
2937         tui_data_info.
2938         (TUI_DATA_WIN): Add cast.
2939         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2940         (~tui_data_window): Simplify.
2941
2942 2019-06-25  Tom Tromey  <tom@tromey.com>
2943
2944         * tui/tui-layout.c (show_source_disasm_command)
2945         (show_source_or_disasm_and_command): Update.
2946         * tui/tui-io.c (update_cmdwin_start_line)
2947         (tui_redisplay_readline): Update.
2948         * tui/tui-data.h (struct tui_command_info): Remove.
2949         (struct tui_win_info) <detail>: Remove command_info member.
2950         (struct tui_data_window) <start_line>: New member, from
2951         tui_command_info.
2952         (TUI_CMD_WIN): Add casts.
2953
2954 2019-06-25  Tom Tromey  <tom@tromey.com>
2955
2956         * tui/tui-winsource.c (tui_update_source_window)
2957         (tui_refill_source_window)
2958         (tui_source_window_base::do_scroll_horizontal)
2959         (tui_update_breakpoint_info, tui_set_exec_info_content)
2960         (tui_show_exec_info_content, tui_erase_exec_info_content)
2961         (tui_clear_exec_info_content): Update.
2962         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2963         Update.
2964         * tui/tui-win.c (make_invisible_and_set_new_height)
2965         (make_visible_with_new_height): Update.
2966         * tui/tui-source.c (tui_set_source_content)
2967         (tui_show_symtab_source): Update.
2968         * tui/tui-layout.c (extract_display_start_addr)
2969         (show_source_disasm_command, show_data)
2970         (make_source_or_disasm_window)
2971         (show_source_or_disasm_and_command): Update.
2972         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2973         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2974         "gdbarch".
2975         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2976         to tui_source_window_base.
2977         (struct tui_win_info) <detail>: Remove source_info member.
2978         (struct tui_source_window_base) <has_locator>: Inline.
2979         Move contents from tui_source_info; rename has_locator member to
2980         m_has_locator.
2981         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2982         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2983         header file.
2984         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2985         Simplify.
2986         (tui_free_all_source_wins_content): Cast to
2987         tui_source_window_base.
2988
2989 2019-06-25  Tom Tromey  <tom@tromey.com>
2990
2991         * tui/tui-win.c (make_invisible_and_set_new_height)
2992         (make_visible_with_new_height): Call has_locator method.
2993         * tui/tui-layout.c (show_source_disasm_command, show_data)
2994         (show_source_or_disasm_and_command): Update for bool change.
2995         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2996         (tui_win_info) <has_locator>: New method.
2997         (struct tui_source_window_base) <has_locator>: New method.
2998         (tui_win_has_locator): Don't declare.
2999         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3000         from tui_win_has_locator.
3001         (tui_source_window_base): Use false, not FALSE.
3002
3003 2019-06-25  Tom Tromey  <tom@tromey.com>
3004
3005         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3006         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3007         clear_detail method directly.
3008         (tui_clear_win_detail): Remove.
3009
3010 2019-06-25  Tom Tromey  <tom@tromey.com>
3011
3012         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3013         "this", not TUI_DISASM_WIN.
3014
3015 2019-06-25  Tom Tromey  <tom@tromey.com>
3016
3017         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3018         declare.
3019         * tui/tui-winsource.c
3020         (tui_source_window_base::do_scroll_horizontal): Rename from
3021         tui_horizontal_source_scroll.
3022         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3023         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3024         from tui_vertical_data_scroll.
3025         * tui/tui-win.h (tui_scroll): Don't declare.
3026         * tui/tui-win.c (tui_win_info::forward_scroll)
3027         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3028         (tui_win_info::right_scroll): Rename and update.
3029         (tui_scroll_forward_command, tui_scroll_backward_command)
3030         (tui_scroll_left_command, tui_scroll_right_command): Update.
3031         (tui_scroll): Remove.
3032         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3033         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3034         from tui_vertical_source_scroll.
3035         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3036         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3037         from tui_vertical_disassem_scroll.
3038         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3039         do_scroll_horizontal>: New methods.
3040         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3041         Likewise.
3042         (struct tui_source_window_base): Add do_scroll_horizontal.
3043         (struct tui_source_window, struct tui_disasm_window): Add
3044         do_scroll_vertical.
3045         (struct tui_data_window, struct tui_cmd_window): Add
3046         do_scroll_horizontal and do_scroll_vertical.
3047         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3048
3049 2019-06-25  Tom Tromey  <tom@tromey.com>
3050
3051         * tui/tui-data.h (struct tui_source_window_base): New struct.
3052         (struct tui_source_window): Derive from tui_source_window_base.
3053         (struct tui_disasm_window): New struct.
3054         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3055         from tui_source_window::clear_detail.
3056         (tui_source_window_base): Rename from tui_source_window.
3057         (~tui_source_window_base): Rename from ~tui_source_window.
3058         (tui_alloc_win_info): Create a tui_disasm_window.
3059
3060 2019-06-25  Tom Tromey  <tom@tromey.com>
3061
3062         * tui/tui-data.h (struct tui_source_window)
3063         (struct tui_data_window): Declare destructors.
3064         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3065         destructors.
3066         (tui_win_info): Simplify.
3067
3068 2019-06-25  Tom Tromey  <tom@tromey.com>
3069
3070         * tui/tui-winsource.c (tui_display_main)
3071         (tui_update_source_windows_with_addr)
3072         (tui_update_all_breakpoint_info): Update.
3073         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3074         (new_height_ok, parse_scrolling_args): Update.
3075         * tui/tui-stack.c (tui_show_frame_info): Update.
3076         * tui/tui-data.h (struct tui_list): Remove.
3077         (tui_source_windows): Return a reference to a std::vector.
3078         * tui/tui-data.c (source_windows): Now a std::vector.
3079         (tui_source_windows): Change return type.
3080         (tui_clear_source_windows): Rewrite.
3081         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3082         (tui_free_all_source_wins_content): Rewrite.
3083
3084 2019-06-25  Tom Tromey  <tom@tromey.com>
3085
3086         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3087         (struct tui_data_window, struct tui_cmd_window): Declare
3088         clear_detail method.
3089         * tui/tui-data.c (tui_source_window::clear_detail)
3090         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3091         methods.
3092         (tui_clear_win_detail): Simplify.
3093
3094 2019-06-25  Tom Tromey  <tom@tromey.com>
3095
3096         * tui/tui-layout.c (make_source_window, make_disasm_window)
3097         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3098         Return the new window.
3099         (show_source_disasm_command, show_data)
3100         (show_source_or_disasm_and_command): Update.
3101
3102 2019-06-25  Tom Tromey  <tom@tromey.com>
3103
3104         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3105         parameter.  Return the new window.
3106         (show_source_disasm_command): Update and remove NULL check.
3107         (show_source_or_disasm_and_command): Update.
3108
3109 2019-06-25  Tom Tromey  <tom@tromey.com>
3110
3111         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3112
3113 2019-06-25  Tom Tromey  <tom@tromey.com>
3114
3115         * tui/tui-data.h (struct tui_win_info): Make constructor
3116         protected.  Make destructor virtual.  Add initializers.
3117         (tui_source_window, tui_data_window, tui_cmd_window): New
3118         classes.
3119         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3120         constructor.  Add "type" parameter.
3121         (tui_source_window, tui_data_window, tui_cmd_window): New
3122         constructors.
3123         (tui_alloc_win_info): Instantiate the appropriate subclass.
3124
3125 2019-06-25  Tom Tromey  <tom@tromey.com>
3126
3127         * tui/tui-win.c (tui_resize_all): Use delete.
3128         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3129         destructor.
3130         (tui_free_window): Don't declare.
3131         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3132         Update.
3133
3134 2019-06-25  Tom Tromey  <tom@tromey.com>
3135
3136         * tui/tui-data.h (struct tui_win_info): Add constructor.
3137         * tui/tui-data.c (tui_alloc_win_info): Use new.
3138         (tui_free_window): Use delete.
3139
3140 2019-06-22  Tom Tromey  <tom@tromey.com>
3141
3142         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3143         declare.
3144         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3145
3146 2019-06-22  Tom Tromey  <tom@tromey.com>
3147
3148         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3149         declare.
3150         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3151
3152 2019-06-22  Tom de Vries  <tdevries@suse.de>
3153
3154         * dwarf2read.c (create_addrmap_from_aranges)
3155         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3156         instead of '%zu'.
3157
3158 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3159
3160         * dwarf2read.h (dwarf2_section_info_def): Remove.
3161         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3162         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3163         std::vector<dwarf2_section_info>.
3164         (struct dwo_file) <~dwo_file>: Remove.
3165         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3166         types field.
3167         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3168         (dwarf2_read_debug_names): Likewise.
3169         (create_debug_types_hash_table): Change parameter type to
3170         array_view, adjust code accordingly.
3171         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3172         (partial_die_info::fixup): Likewise.
3173         (determine_prefix): Likewise.
3174         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3175
3176 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3177
3178         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3179         gdb_bfd_ref_ptr.
3180         <~dwo_file>: Remove call to gdb_bfd_unref.
3181         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3182         gdb_bfd_ref_ptr::get.
3183
3184 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3185
3186         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3187         type to htab_up.
3188         * dwarf2read.c (struct dwo_file): Initialize fields.
3189         <~dwo_file>: New.
3190         (free_dwo_file): Remove, move content to ~dwo_file.
3191         (struct dwo_file_deleter): Remove.
3192         (dwo_file_up>: Remove custom deleter.
3193         (free_dwo_files): Remove.
3194         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3195         dwo_files.
3196         (process_skeletonless_type_units): Call unique_ptr::get.
3197         (allocate_dwo_file_hash_table): Add deleter to created hash
3198         table.  Change return type to htab_up.
3199         (lookup_dwo_file_slot): Don't memset dwo_file, call
3200         unique_ptr::get.
3201         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3202         (create_dwo_unit_in_dwp_v2): Likewise.
3203         (open_and_init_dwo_file): Likewise.
3204         (free_dwo_file_from_slot): Remove.
3205
3206 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3207
3208         * dwarf2read.h (struct dwarf2_section_info) <readin,
3209         is_virtual>: Change type to bool.
3210         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3211         true instead of 1.
3212
3213 2019-06-19  Tom Tromey  <tom@tromey.com>
3214
3215         * tui/tui-data.h (tui_init_content_element): Don't declare.
3216
3217 2019-06-19  Tom Tromey  <tom@tromey.com>
3218
3219         * tui/tui-data.h (tui_init_win_info): Don't declare.
3220
3221 2019-06-19  Tom de Vries  <tdevries@suse.de>
3222
3223         * dwarf2read.h (abstract_to_concrete): Change type to
3224         std::unordered_map<sect_offset, std::vector<sect_offset>,
3225         gdb::hash_enum<sect_offset>>.
3226
3227 2019-06-19  Tom Tromey  <tromey@adacore.com>
3228
3229         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3230         EVAL_AVOID_SIDE_EFFECTS specially.
3231
3232 2019-06-19  Tom Tromey  <tromey@adacore.com>
3233
3234         * source-cache.c (highlighter): New global.
3235         (source_cache::get_source_lines): Create a highlighter on demand.
3236
3237 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3238
3239         * defs.h (deprecated_interactive_hook): Delete declaration.
3240         * interps.c (clear_interpreter_hooks): Remove use of
3241         deprecated_interactive_hook.
3242         * top.c (deprecated_interactive_hook): Delete definition.
3243         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3244
3245 2019-06-18  Tom de Vries  <tdevries@suse.de>
3246
3247         PR gdb/24515
3248         * dwarf2read.h (abstract_to_concrete): Change type from
3249         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3250         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3251         * dwarf2read.c (read_variable): Update.
3252         (dwarf2_fetch_die_loc_sect_off): Update.
3253
3254 2019-06-17  Tom de Vries  <tdevries@suse.de>
3255
3256         PR gdb/24617
3257         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3258         accessing parent[parent_len - 1].
3259
3260 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3261
3262         PR gdb/24364
3263         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3264         call dtrace_process_dof with NULL dof.
3265
3266 2019-06-16  Tom de Vries  <tdevries@suse.de>
3267
3268         PR gdb/24445
3269         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3270
3271 2019-06-16  Tom Tromey  <tom@tromey.com>
3272
3273         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3274         (make_all_visible): Use address of member.
3275
3276 2019-06-16  Tom Tromey  <tom@tromey.com>
3277
3278         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3279         (tui_free_window, free_content, free_content_elements): Remove
3280         unnecessary cast.
3281         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3282         cast.
3283         * tui/tui-regs.c (tui_show_register_group)
3284         (tui_display_registers_from, tui_display_reg_element_at_line):
3285         Remove unnecessary cast.
3286
3287 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3288
3289         * linux-nat.c (normal_mask): Delete.
3290         (_initialize_linux_nat): Don't initialise normal_mask.
3291
3292 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3293
3294         PR gdb/24445
3295         * dwarf-index-write.h (write_psymtabs_to_index): Add
3296         dwz_basename parameter.
3297         * dwarf-index-write.c (write_gdbindex): Move file writing to
3298         write_gdbindex_1.  Change return type void.
3299         (assert_file_size): Move up, remove filename parameter.
3300         (write_gdbindex_1): New function.
3301         (write_debug_names): Change return type to void, call
3302         assert_file_size.
3303         (struct index_wip_file): New struct.
3304         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3305         file logic to index_wip_file.  Write index for dwz file if
3306         needed.
3307         (save_gdb_index_command): Pass basename of dwz file, if present.
3308         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3309         build-id of dwz file, if present.
3310         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3311         (dwarf2_get_dwz_file): Likewise.
3312         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3313         (dwarf2_get_dwz_file): Likewise.
3314
3315 2019-06-16  Tom Tromey  <tom@tromey.com>
3316
3317         * coffread.c (process_coff_symbol): Use xstrdup.
3318         * value.c (create_internalvar): Use xstrdup.
3319
3320 2019-06-16  Tom Tromey  <tom@tromey.com>
3321
3322         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3323         * breakpoint.c (stopin_command, stopat_command)
3324         (until_break_command, decode_location_default): Remove unnecessary
3325         cast.
3326         * utils.c (subset_compare): Remove unnecessary cast.
3327         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3328         cast.
3329         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3330         cast.
3331         * infcmd.c (path_command): Remove unnecessary cast.
3332         * coffread.c (decode_type): Remove unnecessary cast.
3333         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3334         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3335         * tui/tui-stack.c (tui_show_locator_content)
3336         (tui_show_frame_info): Remove unnecessary cast.
3337         * tui/tui-win.c (tui_scroll_forward_command)
3338         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3339         (parse_scrolling_args): Remove unnecessary cast.
3340         * tui/tui-data.c (init_win_info, tui_del_window)
3341         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3342         (free_content_elements): Remove unnecessary cast.
3343         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3344         unnecessary cast.
3345         * tui/tui-source.c (tui_set_source_content)
3346         (tui_vertical_source_scroll): Remove unnecessary cast.
3347         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3348         cast.
3349         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3350         * tui/tui-regs.c (tui_display_registers_from)
3351         (tui_display_register): Remove unnecessary cast.
3352         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3353         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3354         (make_visible): Remove unnecessary cast.
3355         * tui/tui-winsource.c (tui_erase_source_content)
3356         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3357         unnecessary cast.
3358         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3359         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3360         * stabsread.c (read_type, read_array_type, read_range_type):
3361         Remove unnecessary cast.
3362         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3363         (parse_symbol, parse_type, upgrade_type, parse_external)
3364         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3365         unnecessary cast.
3366         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3367
3368 2019-06-16  Tom Tromey  <tom@tromey.com>
3369
3370         * tui/tui-data.c (tui_alloc_generic_win_info)
3371         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3372         checks.
3373
3374 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3375             Andrew Burgess  <andrew.burgess@embecosm.com>
3376
3377         * f-typeprint.c (f_print_type): Don't return early for not
3378         associated or not allocated types.
3379         (f_type_print_varspec_suffix): Add print_rank parameter and print
3380         ranks of array types in case they dangling.
3381         (f_type_print_base): Add print_rank parameter.
3382
3383 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3384
3385         * NEWS: Mention new MI commands.
3386         * break-catch-throw.c (enum exception_event_kind): Move to
3387         breakpoint.h.
3388         (print_mention_exception_catchpoint): Output text as a single
3389         message.
3390         (catch_exception_command_1): Rename to...
3391         (catch_exception_event): ...this, make non-static, update header
3392         command, and change some parameter types.
3393         (catch_catch_command): Update for changes to
3394         catch_exception_command_1.
3395         (catch_throw_command): Likewise.
3396         (catch_rethrow_command): Likewise.
3397         * breakpoint.c (enum exception_event_kind): Delete.
3398         * breakpoint.h (enum exception_event_kind): Moved here from
3399         break-catch-throw.c.
3400         (catch_exception_event): Declare.
3401         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3402         (mi_cmd_catch_throw): New function.
3403         (mi_cmd_catch_rethrow): New function.
3404         (mi_cmd_catch_catch): New function.
3405         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3406         'catch-catch' entries.
3407         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3408         (mi_cmd_catch_rethrow): Declare.
3409         (mi_cmd_catch_catch): Declare.
3410
3411 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3412
3413         * annotate.c (annotate_source_line): Change return type to void,
3414         update implementation to match.
3415         * annotate.h (annotate_source_line): Change return type to void,
3416         update header comment.
3417         * stack.c (print_frame_info): Don't change what frame information
3418         is printed based on whether annotations are on or not.
3419
3420 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3421
3422         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3423         (annotate_source): Make static.
3424         (annotate_source_line): Moved from source.c and renamed from
3425         identify_source_line.  Update the return type.
3426         * annotate.h (annotate_source): Delete declaration.
3427         (annotate_source_line): Declaration moved from source.h, and
3428         renamed from identify_source_line.  Return type updated.
3429         * source.c (identify_source_line): Moved to annotate.c and renamed
3430         to annotate_source_line.
3431         (info_line_command): Remove check of annotation_level.
3432         * source.h (identify_source_line): Move declaration to annotate.h
3433         and rename to annotate_source_line.
3434         * stack.c: Add 'annotate.h' include.
3435         (print_frame_info): Remove check of annotation_level before
3436         calling annotate_source_line.
3437
3438 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3439
3440         * source-cache.c (source_cache::get_plain_source_lines): Use
3441         open_source_file_with_line_charpos instead of just
3442         open_source_file, remove call to find_source_lines.
3443         (source_cache::get_source_lines): Likewise.
3444         * source.c (find_source_lines): Make static.
3445         (get_filename_and_charpos): Renamed into...
3446         (open_source_file_with_line_charpos): ..this along with changes to
3447         return a scoped_fd, and some other minor clean ups.
3448         (identify_source_line): Use open_source_file_with_line_charpos.
3449         (search_command_helper): Use open_source_file_with_line_charpos
3450         instead of just open_source_file, remove call to
3451         find_source_lines.
3452         * source.h (open_source_file_with_line_charpos): Declare new
3453         function.
3454         (find_source_lines): Delete declaration.
3455
3456 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3457
3458         * source.c (get_filename_and_charpos): Remove fullname
3459         parameter.
3460         (identify_source_line): Update call to get_filename_and_charpos.
3461
3462 2019-06-14  Tom Tromey  <tromey@adacore.com>
3463
3464         PR gdb/24502:
3465         * ui-style.h (skip_ansi_escape): Update comment.
3466         * ui-file.h (class no_terminal_escape_file): New class.
3467         * ui-file.c (no_terminal_escape_file::write)
3468         (no_terminal_escape_file::puts): New methods.
3469         * cli/cli-logging.c (handle_redirections): Use
3470         no_terminal_escape_file.
3471
3472 2019-06-14  Tom Tromey  <tromey@adacore.com>
3473
3474         * NEWS: Move convenience variable news above Python news.
3475
3476 2019-06-14  Tom Tromey  <tom@tromey.com>
3477
3478         * gnulib: Move directory to top-level.
3479         * configure.ac: Don't configure gnulib.
3480         * configure: Rebuild.
3481         * common/common-defs.h: Use new path to gnulib.
3482         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3483         (GNULIB_H): Remove.
3484         (INCGNU): Look in new gnulib location.
3485         (HFILES_NO_SRCDIR): Remove gnulib files.
3486         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3487         (generated_files): Remove GNULIB_H.
3488         ($(LIBGNU), all-lib): Remove targets.
3489         (distclean): Don't mention GNULIB_BUILDDIR.
3490         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3491
3492 2019-06-14  Tom Tromey  <tromey@adacore.com>
3493
3494         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3495         Warn if symbol file does not provide any symbols.
3496
3497 2019-06-14  Tom Tromey  <tromey@adacore.com>
3498
3499         * source.c (find_and_open_source): Respect basenames_may_differ.
3500
3501 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3502
3503         * annotate.c (annotate_breakpoints_invalid): Make use of
3504         scoped_restore_terminal_state.
3505         (annotate_frames_invalid): Likewise.
3506
3507 2019-06-14  Tom Tromey  <tromey@adacore.com>
3508
3509         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3510         allow assignment to an internalvar.
3511
3512 2019-06-14  Tom Tromey  <tromey@adacore.com>
3513
3514         * ada-lex.l: Allow "_" in attribute names.
3515
3516 2019-06-14  Tom Tromey  <tromey@adacore.com>
3517
3518         PR gdb/24653:
3519         * regcache.c (registers_changed): Don't call alloca.
3520         * top.c (execute_command): Don't call alloca.
3521
3522 2019-06-13  Pedro Alves  <palves@redhat.com>
3523
3524         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3525         'expression'.  When parsing an expression, error out if there's
3526         junk after "unlimited".
3527         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3528         (do_set_command): Adjust calls to is_unlimited_literal.
3529
3530 2019-06-13  Pedro Alves  <palves@redhat.com>
3531
3532         * compile/compile.c (make_compile_options_def_group): Add braces
3533         around array_view initializer.
3534         * thread.c (make_thread_apply_all_options_def_group)
3535         (make_thread_apply_all_options_def_group): Likewise.
3536
3537 2019-06-13  Pedro Alves  <palves@redhat.com>
3538
3539         * NEWS (New commands): Mention "maint test-options
3540         require-delimiter", "maint test-options unknown-is-error", "maint
3541         test-options unknown-is-operand" and "maint show
3542         test-options-completion-result".
3543         (New command options, command completion): New section.
3544         (Completion improvements): New section.
3545         Mention that you can abbreviate "unlimited".
3546
3547 2019-06-13  Pedro Alves  <palves@redhat.com>
3548
3549         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3550         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3551         * unittests/cli-utils-selftests.c (test_parse_flags)
3552         (test_parse_flags_qcs): Delete.
3553         (test_cli_utils): Don't call deleted functions.
3554
3555 2019-06-13  Pedro Alves  <palves@redhat.com>
3556
3557         * thread.c: Include "cli/cli-option.h".
3558         (tp_array_compar_ascending): Global.
3559         (tp_array_compar): Delete function.
3560         (tp_array_compar_ascending, tp_array_compar_descending): New
3561         functions.
3562         (ascending_option_def, qcs_flag_option_def)
3563         (thr_qcs_flags_option_defs)
3564         (make_thread_apply_all_options_def_group)
3565         (make_thread_apply_options_def_group): New.
3566         (thread_apply_all_command): Use gdb::option::process_options.
3567         (thread_apply_command_completer)
3568         (thread_apply_all_command_completer): New.
3569         (thread_apply_command): Use gdb::option::process_options.
3570         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3571         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3572         to generate help text of "thread apply".  Adjust "taas"'s help.
3573         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3574         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3575
3576 2019-06-13  Pedro Alves  <palves@redhat.com>
3577
3578         * thread.c (thread_apply_command): Check for invalid TID with
3579         isdigit instead of !isalpha.
3580
3581 2019-06-13  Pedro Alves  <palves@redhat.com>
3582
3583         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3584         (validate_flags_qcs): New.
3585         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3586         (validate_flags_qcs): Declare.
3587         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3588         (make_frame_apply_options_def_group): New.
3589         (frame_apply_command_count): Process options with
3590         gdb::option::process_options.
3591         (frame_apply_completer): New.
3592         (frame_apply_level_completer, frame_apply_all_completer)
3593         (frame_apply_completer): New.
3594         (_initialize_stack): Update help of "frame apply", "frame apply
3595         level", "frame apply all" and "faas" to mention supported options
3596         and install command completers.
3597         * stack.h (frame_apply_all_completer): Declare.
3598         * thread.c: Include "stack.h".
3599         (tfaas_command): Add "--".
3600         (_initialize_thread): Update help "tfaas" to mention supported
3601         options and install command completer.
3602
3603 2019-06-13  Pedro Alves  <palves@redhat.com>
3604
3605         * completer.c (complete_nested_command_line): New.
3606         (gdb_completion_word_break_characters_throw): Add assertion.
3607         * completer.h (complete_nested_command_line): Declare.
3608
3609 2019-06-13  Pedro Alves  <palves@redhat.com>
3610
3611         * stack.c (parse_backtrace_qualifiers): New.
3612         (backtrace_command): Use it.
3613         (backtrace_command_completer): Complete on qualifiers.
3614
3615 2019-06-13  Pedro Alves  <palves@redhat.com>
3616
3617         * frame.c: Include "cli/cli-option.h.
3618         (user_set_backtrace_options): New.
3619         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3620         Delete.
3621         (get_prev_frame): Adjust.
3622         (boolean_option_def, uinteger_option_def)
3623         (set_backtrace_option_defs): New.
3624         (_initialize_frame): Adjust and use
3625         gdb::option::add_setshow_cmds_for_options to install "set
3626         backtrace past-main" and "set backtrace past-entry".
3627         * frame.h: Include "cli/cli-option.h".
3628         (struct frame_print_options): Forward declare.
3629         (print_frame_arguments_all, print_frame_arguments_scalars)
3630         (print_frame_arguments_none): Declare.
3631         (print_entry_values): Delete declaration.
3632         (struct frame_print_options, user_frame_print_options): New.
3633         (struct set_backtrace_options): New.
3634         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3635         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3636         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3637         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3638         (list_args_or_locals): Add frame_print_options parameter.
3639         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3640         * python/py-framefilter.c (enumerate_args): Pass down
3641         USER_FRAME_PRINT_OPTIONS.
3642         * stack.c: Include "cli/cli-option.h".
3643         (print_frame_arguments_all, print_frame_arguments_scalars)
3644         (print_frame_arguments_none): Declare.
3645         (print_raw_frame_arguments, print_entry_values): Delete.
3646         (user_frame_print_options): New.
3647         (boolean_option_def, enum_option_def, frame_print_option_defs):
3648         New.
3649         (struct backtrace_cmd_options): New.
3650         (bt_flag_option_def): New.
3651         (backtrace_command_option_defs): New.
3652         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3653         (print_frame_arg, read_frame_arg, print_frame_args)
3654         (print_frame_info, print_frame): Add frame_print_options parameter
3655         and use it.
3656         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3657         (backtrace_command_1): Add frame_print_options and
3658         backtrace_cmd_options parameters and use them.
3659         (make_backtrace_options_def_group): New.
3660         (backtrace_command): Process command options with
3661         gdb::option::process_options.
3662         (backtrace_command_completer): New.
3663         (_initialize_stack): Extend "backtrace"'s help to mention
3664         supported options.  Install completer for "backtrace".
3665         Install some settings commands with add_setshow_cmds_for_options.
3666
3667 2019-06-13  Pedro Alves  <palves@redhat.com>
3668
3669         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3670         and that "set/show print raw frame-arguments" are now deprecated.
3671
3672         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3673         command.
3674         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3675         * stack.c (_initialize_stack): Install "set/show print
3676         raw-frame-arguments", and deprecate "set/show print raw
3677         frame-arguments".
3678         * valprint.c (_initialize_valprint): Deprecate "set/show print
3679         raw".
3680
3681 2019-06-13  Pedro Alves  <palves@redhat.com>
3682
3683         * compile/compile.c (struct compile_options): New.
3684         (compile_flag_option_def, compile_command_option_defs)
3685         (make_compile_options_def_group): New.
3686         (compile_file_command): Handle options with
3687         gdb::option::process_options.
3688         (compile_file_command_completer): New function.
3689         (compile_code_command): Handle options with
3690         gdb::option::process_options.
3691         (compile_code_command_completer): New function.
3692         (_initialize_compiler): Install completers for "compile code" and
3693         "compile file".  Mention available options in "compile code" and
3694         "compile code"'s help.
3695         * completer.c (advance_to_completion_word): New, factored out from
3696         ...
3697         (advance_to_expression_complete_word_point): ... this.
3698         (advance_to_filename_complete_word_point): New.
3699         * completer.h (advance_to_filename_complete_word_point): New
3700         declaration.
3701
3702 2019-06-13  Pedro Alves  <palves@redhat.com>
3703
3704         * compile/compile.c: Include "cli/cli-option.h".
3705         (compile_print_value): Scope data pointer is now a
3706         value_print_options pointer; adjust.
3707         (compile_print_command): Process options.  Scope data pointer is
3708         now a value_print_options pointer; adjust.
3709         (_initialize_compile): Update "compile print"'s help to include
3710         supported options.  Install a completer for "compile print".
3711         * cp-valprint.c (show_vtblprint, show_objectprint)
3712         (show_static_field_print): Delete.
3713         (_initialize_cp_valprint): Don't install "set print
3714         static-members", "set print vtbl", "set print object" here.
3715         * printcmd.c: Include "cli/cli-option.h" and
3716         "common/gdb_optional.h".
3717         (print_command_parse_format): Rework to fill in a
3718         value_print_options instead of a format_data.
3719         (print_value): Change parameter type from format_data pointer to
3720         value_print_options reference.  Adjust.
3721         (print_command_1): Process options.  Adjust to pass down a
3722         value_print_options.
3723         (print_command_completer): New.
3724         (_initialize_printcmd): Install print_command_completer as
3725         handle_brkchars completer for the "print" command.  Update
3726         "print"'s help to include supported options.
3727         * valprint.c: Include "cli/cli-option.h".
3728         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3729         here from cp-valprint.c.
3730         (boolean_option_def, uinteger_option_def)
3731         (value_print_option_defs, make_value_print_options_def_group):
3732         New.  Use gdb::option::add_setshow_cmds_for_options to install
3733         "set print elements", "set print null-stop", "set print repeats",
3734         "set print pretty", "set print union", "set print array", "set
3735         print address", "set print symbol", "set print array-indexes".
3736         * valprint.h: Include <string> and "cli/cli-option.h".
3737         (make_value_print_options_def_group): Declare.
3738         (print_value): Change parameter type from format_data pointer to
3739         value_print_options reference.
3740         (print_command_completer): Declare.
3741
3742 2019-06-13  Pedro Alves  <palves@redhat.com>
3743
3744         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3745         (COMMON_SFILES): Add maint-test-settings.c.
3746         * cli/cli-decode.c (boolean_enums): New global, factored out from
3747         ...
3748         (add_setshow_boolean_cmd): ... here.
3749         * cli/cli-decode.h (boolean_enums): Declare.
3750         * cli/cli-option.c: New file.
3751         * cli/cli-option.h: New file.
3752         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3753         factored out from ...
3754         (parse_cli_boolean_value(const char *)): ... this.
3755         (is_unlimited_literal): Change parameter type to pointer to
3756         pointer.  Adjust and advance ARG pointer.
3757         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3758         (parse_cli_var_enum): New, factored out from ...
3759         (do_set_command): ... this.  Adjust.
3760         * cli/cli-setshow.h (parse_cli_boolean_value)
3761         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3762         (parse_cli_var_enum): Declare.
3763         * cli/cli-utils.c: Include "cli/cli-option.h".
3764         (get_ulongest): New.
3765         * cli/cli-utils.h (get_ulongest): Declare.
3766         (check_for_argument): New overloads.
3767         * maint-test-options.c: New file.
3768
3769 2019-06-13  Pedro Alves  <palves@redhat.com>
3770
3771         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3772         parse a range if "-" is at the end of the string.
3773
3774 2019-06-13  Pedro Alves  <palves@redhat.com>
3775
3776         * cli/cli-setshow.c (parse_auto_binary_operation)
3777         (parse_cli_boolean_value): Don't allow "o".
3778
3779 2019-06-13  Pedro Alves  <palves@redhat.com>
3780
3781         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3782         * NEWS: Mention maint test-settings KIND.
3783         * maint-test-settings.c: New file.
3784
3785 2019-06-13  Pedro Alves  <palves@redhat.com>
3786
3787         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3788         completer.
3789         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3790         "set" completers.
3791
3792 2019-06-13  Pedro Alves  <palves@redhat.com>
3793
3794         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3795         after item.
3796
3797 2019-06-13  Pedro Alves  <palves@redhat.com>
3798
3799         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3800
3801 2019-06-13  Pedro Alves <palves@redhat.com>
3802
3803         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3804         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3805         call.
3806         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3807         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3808         calls.
3809         (check_for_argument): Skip spaces after argument.
3810
3811 2019-06-13  Pedro Alves  <palves@redhat.com>
3812
3813         * thread.c (thread_apply_command): Adjust TID parsing.
3814         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3815         detected before end of string.
3816         (tid_is_in_list): Error out if LIST is invalid.
3817
3818 2019-06-13  Pedro Alves  <palves@redhat.com>
3819
3820         * completer.c (complete_line_internal_1): Rewind completion word
3821         point.
3822         (completion_tracker::advance_custom_word_point_by): Change
3823         parameter type to int.
3824         * completer.h (completion_tracker::advance_custom_word_point_by):
3825         Likewise.
3826
3827 2019-06-13  Pedro Alves  <palves@redhat.com>
3828
3829         * completer.c (advance_to_completion_word): Handle delimiters.
3830
3831 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3832
3833         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3834
3835 2019-06-11  Tom Tromey  <tom@tromey.com>
3836
3837         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3838         (xmalloc_failed): Move to alloc.c.
3839         * alloc.c: New file.
3840         * Makefile.in (COMMON_SFILES): Add alloc.c.
3841
3842 2019-06-11  Tom Tromey  <tom@tromey.com>
3843
3844         * nat/linux-waitpid.c: Don't include server.h.
3845         (linux_debug): Remove.
3846         (my_waitpid): Update.
3847
3848 2019-06-11  Tom Tromey  <tromey@adacore.com>
3849
3850         * infcall.c (_initialize_infcall): Remove trailing newline from
3851         help.
3852         * user-regs.c (_initialize_user_regs): Remove trailing newline
3853         from help.
3854         * typeprint.c (_initialize_typeprint): Remove trailing newline
3855         from help.
3856         * reverse.c (_initialize_reverse): Remove trailing newlines from
3857         help.
3858         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3859         from help.
3860         * language.c (add_set_language_command): Remove trailing newline
3861         from help.
3862         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3863         help.
3864         * disasm.c (_initialize_disasm): Remove trailing newline from
3865         help.
3866         * top.c (init_main): Remove trailing newline from help.
3867         * interps.c (_initialize_interpreter): Remove trailing newline
3868         from help.
3869         * btrace.c (_initialize_btrace): Remove trailing newlines from
3870         help.
3871         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3872         from help.
3873         * python/python.c (_initialize_python): Remove trailing newline
3874         from help.
3875         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3876         help.
3877         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3878         from help.  Reformat some text.
3879         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3880         from help.
3881         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3882         newline from help.
3883
3884 2019-06-11  Tom Tromey  <tromey@adacore.com>
3885
3886         * darwin-nat.c (darwin_decode_exception_message)
3887         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3888
3889 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3890
3891         * valops.c (value_slice): Check for not allocated or not
3892         associated values.
3893
3894 2019-06-10  Tom de Vries  <tdevries@suse.de>
3895
3896         PR gdb/24618
3897         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3898         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3899         invalid.
3900
3901 2019-06-10  Tom de Vries  <tdevries@suse.de>
3902
3903         PR gdb/24611
3904         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3905         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3906
3907 2019-06-10  Tom de Vries  <tdevries@suse.de>
3908
3909         PR symtab/24545
3910         * symtab.c (struct demangled_name_entry): Add language field.
3911         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3912         static minimal symbol".  Set and use language field.
3913
3914 2019-06-10  Tom Tromey  <tromey@adacore.com>
3915
3916         * ada-lang.c (_initialize_ada_language): Update help text.
3917
3918 2019-06-10  Tom Tromey  <tromey@adacore.com>
3919
3920         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3921         with a newline.
3922         * guile/guile.c (handle_boot_error): Don't end warning with a
3923         newline.
3924         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3925         warning with a newline.
3926         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3927         newline.
3928         (s12z_frame_cache): Likewise.
3929         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3930         a newline.
3931         * solib-svr4.c (disable_probes_interface): Don't end warning with
3932         a newline.
3933         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3934         newline.
3935         * python/python.c (do_finish_initialization): Don't end warning
3936         with a newline.
3937
3938 2019-06-10  Tom Tromey  <tom@tromey.com>
3939
3940         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3941         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3942         gdbpy_enter.
3943
3944 2019-06-10  Tom Tromey  <tromey@adacore.com>
3945
3946         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3947         data.
3948         (elf_new_init): Don't call stabsread_new_init.
3949         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3950         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3951         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3952
3953 2019-06-10  Tom de Vries  <tdevries@suse.de>
3954
3955         PR symtab/16264
3956         PR symtab/24517
3957         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3958
3959 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3960
3961         * source.c (find_and_open_source): Also rewrite relative file
3962         names.
3963
3964 2019-04-26  Amos Bird  <amosbird@gmail.com>
3965
3966         * annotate.c (annotate_thread_exited): Add "thread-exited"
3967         annotation.
3968
3969 2019-06-06  Tom Tromey  <tromey@adacore.com>
3970
3971         * maint.h (class scoped_command_stats): Use
3972         DISABLE_COPY_AND_ASSIGN.
3973         <print_time>: New method.
3974         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3975         print_time.
3976         (scoped_command_stats::print_time): New method.
3977
3978 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3979
3980         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3981         instructions of lengths 6 or 8 bytes.
3982
3983 2019-06-04  Pedro Alves  <palves@redhat.com>
3984
3985         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3986
3987         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3988         * breakpoint.c (condition_completer): Likewise.
3989         * cli/cli-dump.c (scan_expression): Likewise.
3990         * common/filestuff.c (mkdir_recursive): Likewise.
3991         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3992         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3993         (gdb_abspath): Likewise.
3994         * compile/compile-cplus-types.c
3995         (compile_cplus_instance::decl_name): Likewise.
3996         * completer.c (complete_explicit_location):
3997         (signal_completer, reg_or_group_completer_1): Likewise.
3998         * cp-support.c (cp_remove_params_if_any): Likewise.
3999         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4000         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4001         * infcmd.c (strip_bg_char): Likewise.
4002         * linespec.c (copy_token_string): Likewise.
4003         * mi/mi-main.c (output_cores): Likewise.
4004         * psymtab.c (psymtab_search_name):
4005         * symfile.c (test_set_ext_lang_command): Likewise.
4006         * target.c (target_fileio_read_stralloc): Likewise.
4007         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4008         * value.c (complete_internalvar): Likewise.
4009
4010 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4011
4012         Add objfile property to gdb.Type.
4013         * NEWS: Mention Python API addition.
4014         * python/py-type.c (typy_get_objfile): New method.
4015
4016 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4017
4018         * NEWS: Mention the new set|show style [title|highlight].
4019         Mention changes to "show style", "help" and "apropos".
4020
4021 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4022
4023         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4024         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4025         instead of print_help_for_command.
4026         (print_doc_of_command): New function.
4027         (help_list): Add 'apropos -v word' suggestion.
4028         (print_help_for_command): Style the command name using title style.
4029         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4030         (_initialize_cli_cmds): Describe -v in apropos_command help.
4031
4032 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4033
4034         * cli/cli-style.h (cli_style_option): Add name in constructor,
4035         add m_name class member, add constructor with intensity,
4036         add name class function.
4037         (cli_style_option::add_setshow_commands): Remove name argument.
4038         (highlight_style, title_style): New styles.
4039         * cli/cli-style.c (do_show): New function that shows a style
4040         characteristic styling the style name with itself.
4041         (set_style_name): New function.
4042         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4043         Update all callers according to the changes in cli/cli-style.h.
4044         * utils.h (fputs_highlighted): New function.
4045         * utils.c (fputs_highlighted): Likewise.
4046
4047 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4048
4049         * NEWS: Mention new pipe command and new convenience variables.
4050
4051 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4052
4053         * cli/cli-cmds.c (pipe_command): New function.
4054         (_initialize_cli_cmds): Call add_com for pipe_command.
4055         Define | as an alias for pipe.
4056         (exit_status_set_internal_vars): New function.
4057         (shell_escape): Call exit_status_set_internal_vars.
4058         cli/cli-decode.c (find_command_name_length): Recognize | as
4059         a single character command.
4060
4061 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4062
4063         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4064         top.c (execute_command_to_ui_file): New function, mostly a copy
4065         of execute_command_to_string.
4066         (execute_command_to_string): Implement by calling
4067         execute_command_to_ui_file.
4068
4069 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4070
4071         * top.h (saved_command_line): Remove declaration.
4072         * top.c (previous_saved_command_line, previous_repeat_arguments):
4073         New variables.
4074         (saved_command_line): Make static, define together with other
4075         'repeat variables'.
4076         (dont_repeat): Clear repeat_arguments.
4077         (repeat_previous, get_saved_command_line, save_command_line):
4078         New functions.
4079         (gdb_init): Initialize saved_command_line
4080         and previous_saved_command_line.
4081         * main.c (captured_main_1): Remove saved_command_line initialization.
4082         * event-top.c (handle_line_of_input): Update to use
4083         the new 'repeat' related functions instead of direct access to
4084         saved_command_line.
4085         * command.h (repeat_previous, get_saved_command_line,
4086         save_command_line): New declarations.
4087         (dont_repeat): Add comment.
4088
4089 2019-05-30  Tom Tromey  <tromey@adacore.com>
4090
4091         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4092         Fix comment.
4093         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4094
4095 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4096
4097         PR cli/24587
4098         * completer.c (complete): Initialize variable word.
4099
4100 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4101
4102         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4103         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4104         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4105         'body' is NULL to the outter 'if', protecting the '!is_define'
4106         situation as well.
4107
4108 2019-05-29  Tom Tromey  <tromey@adacore.com>
4109
4110         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4111         (dwarf_unknown): New function.
4112         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4113         (dwarf_type_encoding_name): Use dwarf_unknown.
4114
4115 2019-05-29  Tom Tromey  <tromey@adacore.com>
4116
4117         PR c++/20020:
4118         * cp-valprint.c (cp_print_value_fields): Call
4119         cp_print_static_field inside "try".
4120
4121 2019-05-29  Tom Tromey  <tromey@adacore.com>
4122
4123         * inflow.c (struct terminal_info): Add default operator=.
4124         * configure: Rebuild.
4125         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4126         -Wdeprecated-copy-dtor, -Wredundant-move.
4127
4128 2019-05-29  Tom Tromey  <tromey@adacore.com>
4129
4130         * NEWS: Add entry.
4131         * infcmd.c (print_return_value_1): Handle finish_print
4132         option.
4133         (show_print_finish): New function.
4134         (_initialize_infcmd): Add "set/show print finish" commands.
4135         * valprint.c (user_print_options): Initialize new member.
4136         * valprint.h (struct value_print_options) <finish_print>: New
4137         member.
4138
4139 2019-05-28  Tom Tromey  <tromey@adacore.com>
4140
4141         * ada-lang.c (ada_remove_Xbn_suffix)
4142         (find_old_style_renaming_symbol)
4143         (parse_old_style_renaming): Remove.
4144         (ada_find_renaming_symbol): Don't call
4145         find_old_style_renaming_symbol.
4146         (ada_is_renaming_symbol): Rename from
4147         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4148         bool.  Now static.
4149         (ada_read_var_value): Update and simplify.
4150         * ada-exp.y (write_var_or_type): Remove old code.
4151
4152 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4153
4154         * event-top.c: Remove include comment.
4155         * inflow.c (class scoped_ignore_sigttou): Move from here...
4156         * inflow.h (class scoped_ignore_sigttou): ...to here.
4157         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4158         * top.c:  Remove include comment.
4159
4160 2019-05-27  Tom Tromey  <tom@tromey.com>
4161
4162         * NEWS: Fix typo.
4163
4164 2019-05-22  Tom Tromey  <tromey@adacore.com>
4165
4166         * target.c (target_follow_exec): Constify parameter.
4167         * target-delegates.c: Rebuild.
4168         * remote.c (remote_target::follow_exec): Constify parameter.
4169         * infrun.c (follow_exec): Constify parameter.
4170         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4171         (target_follow_exec): Likewise.
4172
4173 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4174
4175         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4176         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4177
4178 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4179
4180         * NEWS: Add debugredirect and testsuite sections.
4181
4182 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4183
4184         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4185         target descriptions using exclusively floating point register name
4186         aliases.
4187
4188 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4189
4190         PR gdb/18644:
4191         * f-lang.c (build_fortran_types): Handle the case where
4192         gdbarch_floatformat_for_type returns a nullptr.
4193
4194 2019-05-21  Tom de Vries  <tdevries@suse.de>
4195
4196         PR cli/24587
4197         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4198
4199 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4200
4201         PR gdb/18644:
4202         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4203         16-byte floats.
4204         * i386-tdep.c (i386_floatformat_for_type): Use
4205         floatformats_ia64_quad for the 16-byte floating point component
4206         within a fortran 32-byte complex number.
4207
4208 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4209
4210         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4211         delete default constructor.
4212         (find_partial_die): Update to return const struct.
4213         (partial_die_parent_scope): Move variable declaration into scope
4214         of its use and change its type to auto.
4215         (guess_partial_die_structure_name): Likewise.
4216         (partial_die_info::fixup): Likewise.
4217
4218 2019-05-17  Tom Tromey  <tromey@adacore.com>
4219
4220         * source.c (find_and_open_source): Remove cast.
4221
4222 2019-05-17  Tom Tromey  <tromey@adacore.com>
4223
4224         * annotate.c (annotate_source): Make "filename" const.
4225         * annotate.h (annotate_source): Use const.
4226
4227 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4228
4229         * disasm.c (set_disassembler_options): Send errors to stderr.
4230
4231 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4232
4233         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4234         (cli_interp_base::set_logging): Check debug_redirect.
4235         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4236         * cli/cli-logging.c (debug_redirect): Add static variable.
4237         (pop_output_files): Add default param.
4238         (handle_redirections): Print debug setting.
4239         (show_logging_command): Likewise.
4240         (_initialize_cli_logging): Add debugredirect command.
4241         * interps.c (current_interp_set_logging): Add debug_redirect
4242         parameter.
4243         * interps.h (set_logging): Add debug_redirect parameter.
4244         (current_interp_set_logging): Likewise.
4245         * mi/mi-common.h: Likewise.
4246         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4247
4248 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4249             Tom Tromey  <tromey@adacore.com>
4250
4251         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4252         directly.
4253         * cli/cli-interp.h (make_logging_output): Remove declaration.
4254         * cli/cli-logging.c (make_logging_output): Remove function.
4255         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4256         directly.
4257         * ui-file.c (tee_file::tee_file): Remove bools.
4258         (tee_file::~tee_file): Remove deletes.
4259         * ui-file.h (tee_file): Remove bools.
4260
4261 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4262
4263         * mi/mi-cmds.h (mi_cmd_complete): New function.
4264         * mi/mi-main.c (mi_cmd_complete): Likewise.
4265         * mi/mi-cmds.c: Define new MI command -complete.
4266         * NEWS: Mention new -complete command.
4267
4268 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4269
4270         * completer.h (complete): New function.
4271         * completer.c (complete): Likewise.
4272         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4273         function defined in completer.h.
4274
4275 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4276
4277         * MAINTAINERS (Write After Approval): Add myself.
4278
4279 2019-05-17  Tom de Vries  <tdevries@suse.de>
4280
4281         PR gdb/24094
4282         * dwarf2read.c (struct cu_partial_die_info): New struct.
4283         (find_partial_die): Return cu_partial_die_info.
4284         (partial_die_parent_scope, guess_partial_die_structure_name)
4285         (partial_die_info::fixup): Handle new return type of find_partial_die.
4286
4287 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4288
4289         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4290         "std::string", simplifying the algorithm.
4291
4292 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4293
4294         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4295         (stap_static_probe_ops::get_probes): Likewise.
4296
4297 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4298
4299         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4300         '-')" and "else if".
4301         (stap_parse_single_operand): Join checks for
4302         "gdbarch_stap_parse_special_token_p" and
4303         "gdbarch_stap_parse_special_token" in the same "if" statement.
4304         Invert check when verifying for operation on register
4305         displacement.
4306
4307 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4308
4309         * stap-probe.c (stap_get_opcode): Update comment.
4310         (stap_get_expected_argument_type): Likewise.
4311         (handle_stap_probe): Likewise.
4312
4313 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4314
4315         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4316         return type to 'bool'.  Adjust comment.  Use 'bool' when
4317         appropriate.
4318         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4319         * stap-probe.c (stap_parse_argument_1): Likewise.
4320         (stap_is_operator): Likewise.
4321         (stap_is_generic_prefix): Likewise.
4322         (stap_is_register_prefix): Likewise.
4323         (stap_is_register_indirection_prefix): Likewise.
4324         (stap_is_integer_prefix): Likewise.
4325         (stap_generic_check_suffix): Likewise.
4326         (stap_check_integer_suffix): Likewise.
4327         (stap_check_register_suffix): Likewise.
4328         (stap_check_register_indirection_suffix): Likewise.
4329         (stap_parse_register_operand): Likewise.
4330         (stap_parse_single_operand): Likewise.
4331         (stap_parse_argument_1): Likewise.
4332         (stap_probe::get_argument_count): Likewise.
4333         (stap_is_operator): Likewise.
4334
4335 2019-05-16  Tom Tromey  <tromey@adacore.com>
4336
4337         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4338         keyword to foreach.
4339
4340 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4341
4342         * linux-thread-db.c (try_thread_db_load_1): Change return type
4343         to bool.
4344         (try_thread_db_load): Likewise.
4345         (try_thread_db_load_from_pdir_1): Likewise.
4346         (try_thread_db_load_from_pdir): Likewise.
4347         (try_thread_db_load_from_sdir): Likewise.
4348         (try_thread_db_load_from_dir): Likewise.
4349         (thread_db_load_search): Likewise.
4350         (has_libpthread): Likewise.
4351         (thread_db_load): Likewise.
4352
4353 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4354
4355         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4356         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4357         NULL, and complain/return if that's the case.
4358
4359 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4360
4361         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4362         (advance, posn, abstract_read_memory): New functions.
4363         [struct mem_read_abstraction]: New struct.
4364         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4365
4366 2019-05-14  Tom Tromey  <tromey@adacore.com>
4367
4368         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4369         value is not lval_memory.
4370
4371 2019-05-14  Tom Tromey  <tromey@adacore.com>
4372
4373         * solib.c (info_sharedlibrary_command): Style the file name.
4374
4375 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4376
4377         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4378         (aarch64_vnv_type): Likewise.
4379         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4380         * common/tdesc.c: Likewise.
4381         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4382         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4383         * features/aarch64-fpu.xml: Add ieee half view.
4384         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4385         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4386         * gdbtypes.h (struct builtin_type): Likewise.
4387         (struct objfile_type): Likewise.
4388
4389 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4390
4391         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4392         typo.
4393         * location.h (string_to_event_location): Likewise.
4394
4395 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4396
4397         GDB 8.3 released.
4398
4399 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4400
4401         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4402         New variable declaration.
4403         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4404         New variable.
4405         (print_one_breakpoint): Use ui_out::test_flags and new global
4406         variable to compute use_fixed_output.
4407         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4408         Remove.
4409         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4410         (mi_multi_location_breakpoint_output_fixed): Remove.
4411         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4412         new variable.
4413         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4414         fix_multi_location_breakpoint_output flag if version >= 3.
4415         * ui-out.h (enum ui_out_flag)
4416         <fix_multi_location_breakpoint_output>: New enumerator.
4417
4418 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4419
4420         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4421
4422 2019-05-10  Tom Tromey  <tromey@adacore.com>
4423
4424         * ada-lang.c (catch_ada_completer): New function.
4425         (_initialize_ada_language): Use it.
4426
4427 2019-05-10  Tom Tromey  <tromey@adacore.com>
4428
4429         * thread.c (print_thread_info): Make "requested_threads" const.
4430         * gdbthread.h (print_thread_info): Make "requested_threads"
4431         const.
4432         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4433         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4434
4435 2019-05-08  Tom Tromey  <tom@tromey.com>
4436
4437         * gdbtypes.c (objfile_type_data): Change type.
4438         (objfile_type, _initialize_gdbtypes): Update.
4439
4440 2019-05-08  Tom Tromey  <tom@tromey.com>
4441
4442         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4443         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4444         (_initialize_dwarf2_frame): Update.
4445
4446 2019-05-08  Tom Tromey  <tom@tromey.com>
4447
4448         * objc-lang.c (objc_objfile_data): Change type.
4449         (find_methods): Update.
4450         (_initialize_objc_lang): Remove.
4451
4452 2019-05-08  Tom Tromey  <tom@tromey.com>
4453
4454         * stabsread.c (rs6000_builtin_type_data): Change type.
4455         (rs6000_builtin_type, _initialize_stabsread): Update.
4456
4457 2019-05-08  Tom Tromey  <tom@tromey.com>
4458
4459         * mips-tdep.c (mips_pdr_data): Remove.
4460         (_initialize_mips_tdep): Update.
4461
4462 2019-05-08  Tom Tromey  <tom@tromey.com>
4463
4464         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4465         (hppa_init_objfile_priv_data, read_unwind_info)
4466         (find_unwind_entry, _initialize_hppa_tdep): Update.
4467
4468 2019-05-08  Tom Tromey  <tom@tromey.com>
4469
4470         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4471         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4472         on obstack.
4473         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4474
4475 2019-05-08  Tom Tromey  <tom@tromey.com>
4476
4477         * mdebugread.c (basic_type_data): Change type.
4478         (basic_type, _initialize_mdebugread): Update.
4479
4480 2019-05-08  Tom Tromey  <tom@tromey.com>
4481
4482         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4483
4484 2019-05-08  Tom Tromey  <tom@tromey.com>
4485
4486         * nto-tdep.c (nto_inferior_data_reg): Change type.
4487         (nto_inferior_data): Update.
4488         (nto_inferior_data_cleanup, nto_new_inferior_data)
4489         (_initialize_nto_tdep): Remove.
4490         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4491
4492 2019-05-08  Tom Tromey  <tom@tromey.com>
4493
4494         * ada-lang.c (struct ada_inferior_data): Add initializers.
4495         (ada_inferior_data): Change type.
4496         (ada_inferior_data_cleanup): Remove.
4497         (get_ada_inferior_data, ada_inferior_exit)
4498         (struct ada_pspace_data): Add initializers, destructor.
4499         (ada_pspace_data_handle): Change type.
4500         (get_ada_pspace_data): Update.
4501         (ada_pspace_data_cleanup): Remove.
4502
4503 2019-05-08  Tom Tromey  <tom@tromey.com>
4504
4505         * coffread.c (struct coff_symfile_info): Add initializers.
4506         (coff_objfile_data_key): Move lower.  Change type.
4507         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4508         Update.
4509         (coff_free_info): Remove.
4510
4511 2019-05-08  Tom Tromey  <tom@tromey.com>
4512
4513         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4514         (fbsd_pspace_data_handle): Move lower.  Change type.
4515         (get_fbsd_pspace_data): Update.
4516         (fbsd_pspace_data_cleanup): Remove.
4517         (_initialize_fbsd_tdep): Update.
4518
4519 2019-05-08  Tom Tromey  <tom@tromey.com>
4520
4521         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4522         (get_ada_tasks_pspace_data): Update.
4523         (ada_tasks_pspace_data_cleanup): Remove.
4524         (_initialize_tasks): Update.
4525         (ada_tasks_inferior_data_handle): Change type.
4526         (get_ada_tasks_inferior_data): Update.
4527         (ada_tasks_inferior_data_cleanup): Remove.
4528         (struct ada_tasks_pspace_data): Add initializers.
4529
4530 2019-05-08  Tom Tromey  <tom@tromey.com>
4531
4532         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4533         * symfile-debug.c (debug_sym_get_probes): Change type.
4534         * stap-probe.c (handle_stap_probe):
4535         (stap_static_probe_ops::get_probes): Change type.
4536         * probe.h (class static_probe_ops) <get_probes>: Change type.
4537         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4538         (parse_probes_in_pspace): Update.
4539         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4540         Update.
4541         (any_static_probe_ops::get_probes): Change type.
4542         * elfread.c (elfread_data): New typedef.
4543         (probe_key): Change type.
4544         (elf_get_probes): Likewise.  Update.
4545         (probe_key_free): Remove.
4546         (_initialize_elfread): Update.
4547         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4548         Change type.
4549         (dtrace_process_dof_probe, dtrace_process_dof)
4550         (dtrace_static_probe_ops::get_probe): Change type.
4551
4552 2019-05-08  Tom Tromey  <tom@tromey.com>
4553
4554         * xcoffread.c (struct xcoff_symfile_info): Rename from
4555         coff_symfile_info.  Add initializers.
4556         (xcoff_objfile_data_key): Move lower.  Change type.
4557         (XCOFF_DATA): Rewrite.
4558         (xcoff_free_info): Remove.
4559         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4560         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4561         (xcoff_initial_scan): Update.
4562
4563 2019-05-08  Tom Tromey  <tom@tromey.com>
4564
4565         * solib-svr4.c (struct svr4_info): Add initializers and
4566         destructor.
4567         <probes_table>: Now an htab_up.
4568         (solib_svr4_pspace_data): Change type.
4569         (free_probes_table): Simplify.
4570         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4571         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4572         (probes_table_remove_objfile_probes, register_solib_event_probe)
4573         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4574         (_initialize_svr4_solib): Update.
4575
4576 2019-05-08  Tom Tromey  <tom@tromey.com>
4577
4578         * remote.c (remote_pspace_data): Change type.
4579         (remote_pspace_data_cleanup): Remove.
4580         (get_remote_exec_file, set_pspace_remote_exec_file)
4581         (_initialize_remote): Update.
4582
4583 2019-05-08  Tom Tromey  <tom@tromey.com>
4584
4585         * breakpoint.c (breakpoint_objfile_key): Change type.
4586         (get_breakpoint_objfile_data): Update.
4587         (free_breakpoint_objfile_data): Remove.
4588         (_initialize_breakpoint): Update.
4589
4590 2019-05-08  Tom Tromey  <tom@tromey.com>
4591
4592         * linux-tdep.c (struct linux_info): Add initializers.
4593         (linux_inferior_data): Move.  Change type.
4594         (invalidate_linux_cache_inf): Update.
4595         (linux_inferior_data_cleanup): Remove.
4596         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4597
4598 2019-05-08  Tom Tromey  <tom@tromey.com>
4599
4600         * auxv.c (auxv_inferior_data): Move.  Change type.
4601         (auxv_inferior_data_cleanup): Remove.
4602         (invalidate_auxv_cache_inf): Rewrite.
4603         (get_auxv_inferior_data, _initialize_auxv): Update.
4604
4605 2019-05-08  Tom Tromey  <tom@tromey.com>
4606
4607         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4608         (symfile_debug_objfile_data_key): Change type.
4609         (symfile_debug_installed, debug_qf_has_symbols)
4610         (debug_qf_find_last_source_symtab)
4611         (debug_qf_forget_cached_source_info)
4612         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4613         (debug_qf_print_stats, debug_qf_dump)
4614         (debug_qf_expand_symtabs_for_function)
4615         (debug_qf_expand_all_symtabs)
4616         (debug_qf_expand_symtabs_with_fullname)
4617         (debug_qf_map_matching_symbols)
4618         (debug_qf_expand_symtabs_matching)
4619         (debug_qf_find_pc_sect_compunit_symtab)
4620         (debug_qf_map_symbol_filenames)
4621         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4622         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4623         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4624         (debug_sym_read_linetable, debug_sym_relocate): Update.
4625         (symfile_debug_free_objfile): Remove.
4626         (install_symfile_debug_logging, _initialize_symfile_debug):
4627         Update.
4628
4629 2019-05-08  Tom Tromey  <tom@tromey.com>
4630
4631         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4632         allocate_on_obstack.
4633         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4634         (get_dwarf2_per_objfile): Update.
4635         (set_dwarf2_per_objfile): Remove.
4636         (dwarf2_has_info, dwarf2_get_section_info): Update.
4637         (dwarf2_free_objfile): Remove.
4638         (_initialize_dwarf2_read): Update.
4639
4640 2019-05-08  Tom Tromey  <tom@tromey.com>
4641
4642         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4643         initializers.
4644         <unsupported_script_warning_printed,
4645         script_not_found_warning_printed>: Now bool.
4646         (auto_load_pspace_data): Change type.
4647         (~auto_load_pspace_info): Rename from
4648         auto_load_pspace_data_cleanup.
4649         (get_auto_load_pspace_data, init_loaded_scripts_info)
4650         (clear_section_scripts, maybe_print_unsupported_script_warning)
4651         (maybe_print_script_not_found_warning, _initialize_auto_load):
4652         Update.
4653
4654 2019-05-08  Tom Tromey  <tom@tromey.com>
4655
4656         * objfiles.c (objfile_pspace_info): Add destructor and
4657         initializers.
4658         (objfiles_pspace_data): Change type.
4659         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4660         (get_objfile_pspace_data): Update.
4661         (objfiles_bfd_data): Change type.
4662         (get_objfile_bfd_data): Update.
4663         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4664
4665 2019-05-08  Tom Tromey  <tom@tromey.com>
4666
4667         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4668         Change type.
4669         (get_catch_syscall_inferior_data): Update.
4670         (catch_syscall_inferior_data_cleanup): Remove.
4671         (_initialize_break_catch_syscall): Update.
4672
4673 2019-05-08  Tom Tromey  <tom@tromey.com>
4674
4675         * inflow.c (struct terminal_info): Add destructor and
4676         initializers.
4677         (inflow_inferior_data): Change type.
4678         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4679         (get_inflow_inferior_data, inflow_inferior_exit)
4680         (swap_terminal_info, _initialize_inflow): Update.
4681
4682 2019-05-08  Tom Tromey  <tom@tromey.com>
4683
4684         * target-dcache.c (target_dcache_cleanup): Remove.
4685         (target_dcache_aspace_key): Change type.
4686         (target_dcache_init_p, target_dcache_invalidate)
4687         (target_dcache_get, target_dcache_get_or_init)
4688         (_initialize_target_dcache): Update.
4689         * dcache.h (struct dcache_deleter): New.
4690
4691 2019-05-08  Tom Tromey  <tom@tromey.com>
4692
4693         * symtab.c (struct symbol_cache): Add destructor and
4694         initializers.
4695         (symbol_cache_key): Move.  Change type.
4696         (make_symbol_cache, free_symbol_cache): Remove.
4697         (get_symbol_cache): Update.
4698         (symbol_cache_cleanup): Remove.
4699         (ALL_PSPACES, symbol_cache_flush)
4700         (maintenance_print_symbol_cache)
4701         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4702         Update.
4703
4704 2019-05-08  Tom Tromey  <tom@tromey.com>
4705
4706         * symtab.c (struct main_info): Add destructor and initializers.
4707         (main_progspace_key): Move.  Change type.
4708         (get_main_info): Update.
4709         (main_info_cleanup): Remove.
4710         (_initialize_symtab): Update.
4711
4712 2019-05-08  Tom Tromey  <tom@tromey.com>
4713
4714         * registry.h (DECLARE_REGISTRY): Define the _key class.
4715
4716 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4717
4718         * NEWS: Merge two 'New commands' sections.
4719
4720 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4721
4722         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4723         parameter and use Ada language definition instead.
4724         (ada_val_print_ptr): Remove unused language parameter.
4725         (ada_val_print_num): Remove language parameter and use Ada language
4726         definition instead.
4727         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4728         parameter.
4729         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4730         parameter and use Ada language definition instead.
4731         (ada_val_print_1): Update all ada_val_print_xxx calls.
4732         Remove language parameter.
4733         (ada_val_print): Update ada_val_print_1 call.
4734
4735 2019-05-08  Tom Tromey  <tromey@adacore.com>
4736
4737         * remote.c (remote_hw_watchpoint_limit)
4738         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4739         Now static.
4740
4741 2019-05-08  Tom Tromey  <tromey@adacore.com>
4742
4743         * maint.c (_initialize_maint_cmds): Move initialization code to
4744         remote.c.
4745         (watchdog, show_watchdog): Move to remote.c.
4746         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4747         "watchdog" static.
4748         (_initialize_remote): Move initialization code from maint.c.
4749         * defs.h (watchdog): Don't declare.
4750
4751 2019-05-08  Tom Tromey  <tromey@adacore.com>
4752
4753         * tui/tui-interp.c: Include main.h.
4754         * interps.c: Include main.h.
4755         * main.h (interpreter_p): Declare.
4756         * defs.h (interpreter_p): Don't declare.
4757
4758 2019-05-08  Tom Tromey  <tromey@adacore.com>
4759
4760         * dwarf2loc.c: Include dwarf2read.h.
4761         * defs.h (read_unsigned_leb128): Don't declare.
4762         * dwarf2read.h (read_unsigned_leb128): Declare.
4763
4764 2019-05-08  Tom Tromey  <tromey@adacore.com>
4765
4766         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4767         method.
4768
4769 2019-05-08  Tom Tromey  <tromey@adacore.com>
4770
4771         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4772         when no wrap column is set.
4773
4774 2019-05-08  Tom Tromey  <tromey@adacore.com>
4775
4776         * c-lang.c (c_get_string): Handle non-C-style arrays.
4777
4778 2019-05-08  Tom Tromey  <tromey@adacore.com>
4779
4780         * typeprint.c (print_offset_data::update): Print the bit offset,
4781         not the number of bits remaining.
4782
4783 2019-05-08  Tom Tromey  <tromey@adacore.com>
4784
4785         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4786         padding at end of comment.
4787
4788 2019-05-08  Tom Tromey  <tromey@adacore.com>
4789
4790         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4791         Compare main types.
4792
4793 2019-05-06  Tom Tromey  <tom@tromey.com>
4794
4795         * common/scoped_mmap.c: Include common-defs.h.
4796         * common/scoped_mmap.h: Don't include config.h.
4797
4798 2019-05-04  Tom Tromey  <tom@tromey.com>
4799
4800         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4801         (struct aarch64_call_info): Add initializers.
4802         <si>: Now a std::vector.
4803         (pass_on_stack, aarch64_push_dummy_call): Update.
4804
4805 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4806             Tom Tromey  <tom@tromey.com>
4807
4808         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4809         (ppc_threads): Now a std::vector.  Now static.
4810         (hwdebug_find_thread_points_by_tid)
4811         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4812         Update.
4813
4814 2019-05-04  Tom Tromey  <tom@tromey.com>
4815
4816         * arc-tdep.c (arc_tdesc_init): Return bool.
4817
4818 2019-05-04  Tom Tromey  <tom@tromey.com>
4819
4820         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4821         Use gdb_assert_not_reached.
4822
4823 2019-05-04  Tom Tromey  <tom@tromey.com>
4824
4825         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4826         "false".
4827
4828 2019-05-04  Tom Tromey  <tom@tromey.com>
4829
4830         * arc-tdep.c (arc_tdesc_init): Use bool.
4831
4832 2019-05-04  Tom Tromey  <tom@tromey.com>
4833
4834         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4835
4836 2019-05-04  Tom Tromey  <tom@tromey.com>
4837
4838         * cli/cli-cmds.c (valid_command_p): Return bool.
4839
4840 2019-05-04  Tom Tromey  <tom@tromey.com>
4841
4842         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4843         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4844
4845 2019-05-04  Raul Tambre  <raul@tambre.ee>
4846
4847         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4848         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4849         operator for comparison.
4850
4851 2019-05-04  Tom Tromey  <tom@tromey.com>
4852
4853         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4854         (lookup_partial_symbol, print_partial_symbols)
4855         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4856         (psymbol_compare): Update.
4857         (add_psymbol_to_bcache): Clear the entire psymbol.
4858         (maintenance_check_psymtabs): Update.
4859         * psympriv.h (struct partial_symbol): Don't derive from
4860         general_symbol_info.
4861         <obj_section, unrelocated_address, address,
4862         set_unrelocated_address>: Update.
4863         <ginfo>: New member.
4864         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4865         (debug_names::write_psymbols): Update.
4866
4867 2019-05-04  Tom de Vries  <tdevries@suse.de>
4868
4869         * contrib/cc-with-tweaks.sh: Support -n arg.
4870
4871 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4872
4873         * corelow.c (core_target::detach): Ensure frame cache and
4874         register caches are cleared.
4875         inferior.c (exit_inferior_1): Likewise.
4876
4877 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4878             Tom Tromey  <tom@tromey.com>
4879
4880         * dictionary.c (collate_pending_symbols_by_language): Remove
4881         "struct" from foreach.
4882         * symtab.c (lookup_global_symbol_from_objfile)
4883         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4884         foreach.
4885         * ser-tcp.c (net_open): Remove "struct" from foreach.
4886         * objfiles.c (objfile_relocate, objfile_rebase)
4887         (objfile_has_symbols): Remove "struct" from foreach.
4888         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4889         from foreach.
4890         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4891         foreach.
4892         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4893         "struct" from foreach.
4894         * ada-lang.c (create_excep_cond_exprs)
4895         (ada_exception_catchpoint_cond_string): Remove "struct" from
4896         foreach.
4897
4898 2019-05-03  Tom Tromey  <tromey@adacore.com>
4899
4900         * ada-exp.y (convert_char_literal): Check suffix of each
4901         enumerator.
4902
4903 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4904
4905         PR ada/21406:
4906         * ada-exp.y (yywrap): Don't define.
4907         * ada-lex.l (%option): Add noyywrap
4908         (yywrap): Remove.
4909
4910 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4911
4912         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4913         _WIN32_WINNT to the XP level, unless already defined to a higher
4914         level.
4915
4916         * unittests/parse-connection-spec-selftests.c:
4917         * ser-tcp.c:
4918         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4919         override.
4920
4921         * symfile.c (find_separate_debug_file): Remove colon from the
4922         drive spec of DOS/Windows file names of the target, so that the
4923         file name produced from DEBUGDIR and the target's directory will
4924         be valid on DOS/Windows systems.
4925
4926 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4927
4928         * rust-lang.c (val_print_struct): Handle printing structures
4929         containing strings.
4930
4931 2019-05-02  Tom Tromey  <tromey@adacore.com>
4932
4933         * valarith.c (_initialize_valarith): Remove.
4934
4935 2019-05-01  Tom Tromey  <tromey@adacore.com>
4936
4937         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4938         bitfields.
4939
4940 2019-05-01  Tom Tromey  <tromey@adacore.com>
4941
4942         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4943         for big-endian copies.
4944
4945 2019-04-30  Ali Tamur  <tamur@google.com>
4946         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4947         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4948         (read_3_bytes): New function.
4949
4950 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4951
4952         * windows-nat.c (main_thread_id): Delete.
4953         (handle_output_debug_string): Replace main_thread_id by
4954         current_event.dwThreadId.
4955         (fake_create_process): Likewise.
4956         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4957         Do not set main_thread_id.
4958         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4959         current_event.dwThreadId.
4960         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4961
4962 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4963
4964         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4965         Use current_event.dwThreadId instead of main_thread_id.
4966
4967 2019-04-30  Tom Tromey  <tromey@adacore.com>
4968
4969         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4970         (create_excep_cond_exprs): Iterate over program spaces.
4971         (ada_exception_catchpoint_cond_string): Examine all minimal
4972         symbols for exception types.
4973
4974 2019-04-30  Tom Tromey  <tromey@adacore.com>
4975
4976         PR c++/24470:
4977         * dwarf2read.c (process_structure_scope): Handle case where type
4978         has template parameters but no symbol was created.
4979
4980 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4981             Chris January  <chris.january@arm.com>
4982
4983         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4984         qualifier.
4985         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4986
4987 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4988
4989         * f-typeprint.c (f_print_type): Update rules for printing
4990         whitespace.
4991         (f_type_print_varspec_suffix): Likewise.
4992
4993 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4994             Chris January  <chris.january@arm.com>
4995
4996         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4997         function arguments.
4998
4999 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5000
5001         * f-lang.c (build_fortran_types): Change name of void type to
5002         lower case.
5003         * f-typeprint.c (f_type_print_base): Print the name of the void
5004         type, rather than a fixed string.
5005         * f-valprint.c (f_decorations): Use lower case void string.
5006
5007 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5008             Chris January  <chris.january@arm.com>
5009
5010         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5011         types for Fortran.
5012
5013 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5014             Chris January  <chris.january@arm.com>
5015             David Lecomber  <david.lecomber@arm.com>
5016
5017         * f-exp.y (BINOP_INTRINSIC): New token.
5018         (exp): New parser rule handling BINOP_INTRINSIC.
5019         (f77_keywords): Add new builtin procedures.
5020         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5021         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5022         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5023         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5024         (print_unop_subexp_f): New function.
5025         (print_binop_subexp_f): New function.
5026         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5027         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5028         (dump_subexp_body_f): Likewise.
5029         (operator_check_f): Likewise.
5030         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5031         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5032
5033 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5034
5035         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5036         UNOP_KIND.
5037         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5038         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5039         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5040         (operator_length_f): New fuction.
5041         (print_subexp_f): New function.
5042         (op_name_f): New function.
5043         (dump_subexp_body_f): New function.
5044         (operator_check_f): New function.
5045         (exp_descriptor_f): Replace standard expression handling functions
5046         with new functions.
5047         * gdb/fortran-operator.def: New file.
5048         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5049         * gdb/std-operator.def: Remove UNOP_KIND.
5050
5051 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5052
5053         * std-operator.def: Remove unbalanced, stray double quote
5054         character.
5055
5056 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5057             Chris January  <chris.january@arm.com>
5058             Daniel Everett  <daniel.everett@arm.com>
5059             Nick Forrington  <nick.forrington@arm.com>
5060             Richard Bunt  <richard.bunt@arm.com>
5061
5062         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5063         of depth when printing anonymous structs or unions.
5064         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5065         Don't print either the top-level value, or the children if the
5066         max-depth is exceeded.
5067         (ppscm_print_children): When printing the key of a map, allow one
5068         extra level of depth.
5069         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5070         print either the top-level value, or the children if the max-depth
5071         is exceeded.
5072         (print_children): When printing the key of a map, allow one extra
5073         level of depth.
5074         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5075         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5076         (user_print_options): Initialise max_depth field.
5077         (val_print_scalar_or_string_type_p): New function.
5078         (val_print): Check to see if the max depth has been reached.
5079         (val_print_check_max_depth): Define new function.
5080         (show_print_max_depth): New function.
5081         (_initialize_valprint): Add 'print max-depth' option.
5082         * valprint.h (struct value_print_options) <max_depth>: New field.
5083         (val_print_check_max_depth): Declare new function.
5084         * NEWS: Document new feature.
5085
5086 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5087
5088         * ada-lang.c (ada_language_defn): Initialise new field.
5089         * c-lang.c (c_is_string_type_p): New function.
5090         (c_language_defn): Initialise new field.
5091         (cplus_language_defn): Initialise new field.
5092         (asm_language_defn): Initialise new field.
5093         (minimal_language_defn): Initialise new field.
5094         * c-lang.h (c_is_string_type_p): Declare new function.
5095         * d-lang.c (d_language_defn): Initialise new field.
5096         * f-lang.c (f_is_string_type_p): New function.
5097         (f_language_defn): Initialise new field.
5098         * go-lang.c (go_is_string_type_p): New function.
5099         (go_language_defn): Initialise new field.
5100         * language.c (default_is_string_type_p): New function.
5101         (unknown_language_defn): Initialise new field.
5102         (auto_language_defn): Initialise new field.
5103         * language.h (struct language_defn) <la_is_string_type_p>: New
5104         member variable.
5105         (default_is_string_type_p): Declare new function.
5106         * m2-lang.c (m2_language_defn): Initialise new field.
5107         * objc-lang.c (objc_language_defn): Initialise new field.
5108         * opencl-lang.c (opencl_language_defn): Initialise new field.
5109         * p-lang.c (pascal_is_string_type_p): New function.
5110         (pascal_language_defn): Initialise new field.
5111         * rust-lang.c (rust_is_string_type_p): New function.
5112         (rust_language_defn): Initialise new field.
5113
5114 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5115
5116         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5117         New field.
5118         * ada-lang.c (ada_language_defn): Initialise new field.
5119         * c-lang.c (c_language_defn): Likewise.
5120         (cplus_language_defn): Likewise.
5121         (asm_language_defn): Likewise.
5122         (minimal_language_defn): Likewise.
5123         * d-lang.c (d_language_defn): Likewise.
5124         * f-lang.c (f_language_defn): Likewise.
5125         * go-lang.c (go_language_defn): Likewise.
5126         * language.c (unknown_language_defn): Likewise.
5127         (auto_language_defn): Likewise.
5128         * m2-lang.c (m2_language_defn): Likewise.
5129         * objc-lang.c (objc_language_defn): Likewise.
5130         * opencl-lang.c (opencl_language_defn): Likewise.
5131         * p-lang.c (pascal_language_defn): Likewise.
5132         * rust-lang.c (rust_language_defn): Likewise.
5133
5134 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5135
5136         * ada-lang.c (ada_is_character_type): Change return type to bool.
5137         (ada_is_string_type): Likewise.
5138         * ada-lang.h (ada_is_character_type): Update declaration
5139         (ada_is_string_type): Likewise.
5140
5141 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5142
5143         Support style in 'frame|thread apply'
5144
5145         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5146         * record.c (record_start, record_stop): Update callers of
5147         execute_command_to_string with false.
5148         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5149         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5150         methods.
5151         (class string_file): New constructor with term_out parameter.
5152         Override methods term_out and can_emit_style_escape.  New member
5153         term_out.
5154         (class stdio_file): Override can_emit_style_escape.
5155         (class tee_file): Override term_out and can_emit_style_escape.
5156         * utils.h (can_emit_style_escape): Remove.
5157         * utils.c (can_emit_style_escape): Likewise.
5158         Update all callers of can_emit_style_escape (SOMESTREAM) to
5159         SOMESTREAM->can_emit_style_escape.
5160         * source-cache.c (source_cache::get_source_lines): Likewise.
5161         * stack.c (frame_apply_command_count): Call execute_command_to_string
5162         passing the term_out characteristic of the current gdb_stdout.
5163         * thread.c (thr_try_catch_cmd): Likewise.
5164         * top.c (execute_command_to_string): pass term_out parameter
5165         to construct the string_file for the command output.
5166         * ui-file.c (term_cli_styling): New function (most code moved
5167         from utils.c can_emit_style_escape).
5168         (string_file::string_file, string_file::can_emit_style_escape,
5169         stdio_file::can_emit_style_escape, tee_file::term_out,
5170         tee_file::can_emit_style_escape): New functions.
5171
5172 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5173
5174         * NEWS: Mention the new set|show may-call-functions.
5175         * infcall.c (may_call_functions_p): New variable.
5176         (show_may_call_functions_p): New function.
5177         (call_function_by_hand_dummy): Throws an error if not
5178         may-call-functions.
5179         (_initialize_infcall): Call add_setshow_boolean_cmd for
5180         may-call-functions.
5181
5182 2019-04-25  Keith Seitz  <keiths@redhat.com>
5183
5184         PR c++/24367
5185         * cp-support.c (inspect_type): Don't attempt substitutions
5186         of symbol with the same name.
5187
5188 2019-04-25  Tom Tromey  <tromey@adacore.com>
5189
5190         PR gdb/24475:
5191         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5192         static.
5193
5194 2019-04-25  Tom Tromey  <tromey@adacore.com>
5195
5196         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5197         rvalue reference.
5198         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5199         (gdb_xml_parser::parse): Use std::move.
5200         * python/python-internal.h (gdbpy_convert_exception): Take a const
5201         reference.
5202         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5203         std::move.
5204         * python/py-utils.c (gdbpy_convert_exception): Take a const
5205         reference.
5206         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5207         Use std::move.
5208         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5209         Use std::move.
5210         * mi/mi-main.c (mi_print_exception): Take a const reference.
5211         * main.c (handle_command_errors): Take a const reference.
5212         * linespec.c (parse_linespec): Use std::move.
5213         * infcall.c (run_inferior_call): Use std::move.
5214         (call_function_by_hand_dummy): Use std::move.
5215         * exec.c (try_open_exec_file): Use std::move.
5216         * exceptions.h (exception_print, exception_fprintf)
5217         (exception_print_same): Update.
5218         * exceptions.c (print_exception, exception_print)
5219         (exception_fprintf, exception_print_same): Change parameters to
5220         const reference.
5221         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5222         * common/new-op.c: Use std::move.
5223         * common/common-exceptions.h (struct gdb_exception): Add move
5224         constructor.
5225         (struct gdb_exception_error, struct gdb_exception_quit, struct
5226         gdb_quit_bad_alloc): Change constructor to move constructor.
5227         (throw_exception): Change parameter to rvalue reference.
5228         * common/common-exceptions.c (throw_exception): Take rvalue
5229         reference.
5230         * cli/cli-interp.c (safe_execute_command): Use std::move.
5231         * breakpoint.c (insert_bp_location, location_to_sals): Use
5232         std::move.
5233
5234 2019-04-25  Tom Tromey  <tromey@adacore.com>
5235
5236         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5237         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5238         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5239         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5240         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5241         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5242         guile/scm-value.c: Use unpack.
5243         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5244         gdbscm_gdb_exception.
5245         (gdbscm_throw_gdb_exception): Likewise.
5246         (struct gdbscm_gdb_exception): New.
5247         (unpack): New function.
5248         (gdbscm_wrap): Use unpack.
5249
5250 2019-04-25  Tom Tromey  <tromey@adacore.com>
5251
5252         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5253         (gdb_rl_callback_handler): Use std::move.
5254         * common/common-exceptions.h (struct gdb_exception): Add move
5255         assignment operator.
5256         (throw_exception_sjlj): Change "exception" to const reference.
5257         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5258         (throw_exception_sjlj): Change "exception" to const reference.
5259
5260 2019-04-25  Tom Tromey  <tromey@adacore.com>
5261
5262         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5263         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5264         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5265         Update.
5266         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5267         Update.
5268         * mi/mi-interp.c (mi_interp::exec): Update.
5269         * linespec.c (parse_linespec): Update.
5270         * infcall.c (run_inferior_call): Update.
5271         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5272         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5273         (gdbscm_lookup_global_symbol): Update.
5274         * guile/scm-param.c (gdbscm_parameter_value): Update.
5275         * guile/scm-frame.c (gdbscm_frame_read_register)
5276         (gdbscm_frame_read_var): Update.
5277         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5278         * exec.c (try_open_exec_file): Update.
5279         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5280         (gdb_rl_callback_handler): Update.
5281         * common/common-exceptions.h (exception_none): Don't declare.
5282         * common/common-exceptions.c (exception_none): Don't define.
5283         (struct catcher) <exception>: Update.
5284         * cli/cli-interp.c (safe_execute_command): Update.
5285         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5286
5287 2019-04-25  Ali Tamur  <tamur@google.com>
5288
5289         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5290         (read_attribute_value): Likewise.
5291         (dwarf2_read_addr_index): Update comment.
5292         (read_str_index): Add DW_FORM_strx.
5293         (dwarf2_string_attr): Likewise.
5294         (dwarf2_const_value_attr): Likewise.
5295         (dump_die_shallow): Likewise.
5296         (dwarf2_fetch_constant_bytes): Likewise.
5297         (skip_form_bytes): Likewise.
5298         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5299
5300 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5301
5302         PR corefiles/11608
5303         PR corefiles/18187
5304         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5305         OFFSET.  Verify if current mapping contains an ELF header.
5306         (linux_find_memory_regions_full): Adjust call to
5307         dump_mapping_p.
5308
5309 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5310             Kang Li <kanglictf@gmail.com>
5311
5312         PR gdb/21600
5313
5314         * dwarf2-frame.c (read_initial_length): Be consistent about using
5315         unsigned representation of length.
5316         (decode_frame_entry_1): Likewise.  Check for wraparound of
5317         end pointer as well as buffer overflow.
5318
5319 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5320
5321         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5322         "vq".
5323
5324 2019-04-24  Tom Tromey  <tromey@adacore.com>
5325
5326         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5327
5328 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5329
5330         * s12z-tdep.c (s12z_unwind_pc): Delete.
5331         (s12z_unwind_sp): Delete.
5332         (s12z_gdbarch_init): Don't register deleted functions with
5333         gdbarch.
5334
5335 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5336
5337         * rl78-tdep.c (rl78_unwind_sp): Delete.
5338         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5339
5340 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5341
5342         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5343         (xstormy16_unwind_pc): Delete.
5344         (xstormy16_dummy_id): Delete.
5345         (xstormy16_gdbarch_init): Don't register deleted functions with
5346         gdbarch.
5347
5348 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5349
5350         * vax-tdep.c (vax_unwind_pc): Delete.
5351         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5352
5353 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5354
5355         * v850-tdep.c (v850_unwind_sp): Delete.
5356         (v850_unwind_pc): Delete.
5357         (v850_dummy_id): Delete.
5358         (v850_gdbarch_init): Don't register deleted functions with
5359         gdbarch.
5360
5361 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5362
5363         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5364         (tilegx_unwind_pc): Delete.
5365         (tilegx_unwind_dummy_id): Delete.
5366         (tilegx_gdbarch_init): Don't register deleted functions with
5367         gdbarch.
5368
5369 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5370
5371         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5372         (tic6x_dummy_id): Delete.
5373         (tic6x_gdbarch_init): Don't register deleted functions with
5374         gdbarch.
5375
5376 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5377
5378         * sparc-tdep.c (sparc_unwind_pc): Delete.
5379         (sparc32_gdbarch_init): Don't register deleted function with
5380         gdbarch.
5381
5382 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5383
5384         * sh-tdep.c (sh_unwind_sp): Delete.
5385         (sh_unwind_pc): Delete.
5386         (sh_dummy_id): Delete.
5387         (sh_gdbarch_init): Don't register deleted functions with
5388         gdbarch.
5389
5390 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5391
5392         * score-tdep.c (score_unwind_sp): Delete.
5393         (score_unwind_pc): Delete.
5394         (score_dummy_id): Delete.
5395         (score_gdbarch_init): Don't register deleted functions with
5396         gdbarch.
5397
5398 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5399
5400         * rx-tdep.c (rx_unwind_pc): Delete.
5401         (rx_unwind_sp): Delete.
5402         (rx_dummy_id): Delete.
5403         (rx_gdbarch_init): Don't register deleted functions with
5404         gdbarch.  Update comment.
5405
5406 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5407
5408         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5409         (rs6000_dummy_id): Delete.
5410         (rs6000_gdbarch_init): Don't register deleted functions with
5411         gdbarch.
5412
5413 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5414
5415         * or1k-tdep.c (or1k_dummy_id): Delete.
5416         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5417
5418 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5419
5420         * nios2-tdep.c (nios2_dummy_id): Delete.
5421         (nios2_unwind_sp): Delete.
5422         (nios2_gdbarch_init): Don't register deleted functions with
5423         gdbarch.
5424
5425 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5426
5427         * nds32-tdep.c (nds32_dummy_id): Delete.
5428         (nds32_unwind_pc): Delete.
5429         (nds32_unwind_sp): Delete.
5430         (nds32_gdbarch_init): Don't register deleted functions with
5431         gdbarch.
5432
5433 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5434
5435         * msp430-tdep.c (msp430_unwind_pc): Delete.
5436         (msp430_unwind_sp): Delete.
5437         (msp430_dummy_id): Delete.
5438         (msp430_gdbarch_init): Don't register deleted functions with
5439         gdbarch.
5440
5441 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5442
5443         * moxie-tdep.c (moxie_unwind_sp): Delete.
5444         (moxie_unwind_pc): Delete.
5445         (moxie_dummy_id): Delete.
5446         (moxie_gdbarch_init): Don't register deleted functions with
5447         gdbarch.
5448
5449 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5450
5451         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5452         (mn10300_unwind_pc): Delete.
5453         (mn10300_unwind_sp): Delete.
5454         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5455         mn10300_unwind_sp.
5456         (mn10300_frame_unwind_init): Don't register deleted functions with
5457         gdbarch.
5458
5459 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5460
5461         * mep-tdep.c (mep_unwind_pc): Delete.
5462         (mep_unwind_sp): Delete.
5463         (mep_dummy_id): Delete.
5464         (mep_gdbarch_init): Don't register deleted functions with
5465         gdbarch.
5466
5467 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5468
5469         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5470         (m68hc11_unwind_sp): Delete.
5471         (m68hc11_gdbarch_init): Don't register deleted functions with
5472         gdbarch.
5473
5474 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5475
5476         * m32r-tdep.c (m32r_unwind_sp): Delete.
5477         (m32r_unwind_pc): Delete.
5478         (m32r_dummy_id): Delete.
5479         (m32r_gdbarch_init): Don't register deleted functions with
5480         gdbarch.
5481
5482 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5483
5484         * m32c-tdep.c (m32c_unwind_pc): Delete.
5485         (m32c_unwind_sp): Delete.
5486         (m32c_dummy_id): Delete.
5487         (m32c_gdbarch_init): Don't register deleted functions with
5488         gdbarch.
5489
5490 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5491
5492         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5493         (lm32_unwind_pc): Delete.
5494         (lm32_dummy_id): Delete.
5495         (lm32_gdbarch_init): Don't register deleted functions with
5496         gdbarch.
5497
5498 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5499
5500         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5501         (iq2000_unwind_pc): Delete.
5502         (iq2000_dummy_id): Delete.
5503         (iq2000_gdbarch_init): Don't register deleted functions with
5504         gdbarch.
5505
5506 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5507
5508         * nds32-tdep.c (nds32_type_align): Delete.
5509         (nds32_push_dummy_call): Use type_align instead.
5510
5511 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5512
5513         * arm-tdep.c (arm_type_align): Only handle vector override case.
5514         (arm_push_dummy_call): Use type_align.
5515         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5516
5517 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5518
5519         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5520         case.
5521         (pass_on_stack): Use type_align.
5522         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5523         function.
5524
5525 2019-04-23  Tom Tromey  <tromey@adacore.com>
5526
5527         * dwarf2read.c (line_header::file_name_at): Remove unused
5528         overload.
5529
5530 2019-04-23  Tom de Vries  <tdevries@suse.de>
5531
5532         PR gdb/24438
5533         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5534         invocation.
5535
5536
5537 2019-03-27  Ali Tamur  <tamur@google.com>
5538
5539         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5540         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5541         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5542         (dwarf_expr_context::get_addr_index): Likewise
5543         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5544         (symbol_needs_eval_context::get_addr_index): Likewise
5545         (disassemble_dwarf_expression): Add DW_OP_addrx
5546         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5547         (read_cutu_die_from_dwo): Update comment
5548         (skip_one_die): Add DW_FORM_addrx
5549         (read_attribute_value): Likewise
5550         (var_decode_location): Add DW_OP_addrx
5551         (dwarf2_const_value_attr): Add DW_FORM_addrx
5552         (dump_die_shallow): Likewise
5553         (dwarf2_fetch_constant_bytes): Likewise
5554         (decode_locdesc): Add DW_OP_addrx
5555         (skip_form_bytes): Add DW_FORM_addrx
5556
5557 2019-04-22  Ali Tamur  <tamur@google.com>
5558
5559         * MAINTAINERS (Write After Approval): Add self.
5560
5561 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5562
5563         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5564         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5565         (open_symbol_file_object): Likewise.
5566         (svr4_default_sos): Add info parameter.
5567         (svr4_read_so_list): Likewise.
5568         (svr4_current_sos_direct): Adjust functions calls to pass down
5569         info.
5570         (svr4_current_sos_1): Add info parameter.
5571         (svr4_current_sos): Call get_svr4_info, pass info down to
5572         svr4_current_sos_1.
5573         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5574         get_svr4_info.
5575         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5576         get_svr4_info.
5577         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5578         to get_svr4_info.
5579         (probes_table_remove_objfile_probes): Likewise.
5580         (register_solib_event_probe): Add info parameter.
5581         (solist_update_incremental): Pass info parameter down to
5582         svr4_read_so_list.
5583         (disable_probes_interface): Add info parameter.
5584         (svr4_handle_solib_event): Pass current_program_space to
5585         get_svr4_info.  Adjust disable_probes_interface cleanup.
5586         (svr4_create_probe_breakpoints): Add info parameter, pass it
5587         down to register_solib_event_probe.
5588         (svr4_create_solib_event_breakpoints): Add info parameter,
5589         pass it down to svr4_create_probe_breakpoints.
5590         (enable_break): Pass info down to
5591         svr4_create_solib_event_breakpoints.
5592         (svr4_solib_create_inferior_hook): Pass current_program_space to
5593         get_svr4_info.
5594         (svr4_clear_solib): Likewise.
5595
5596 2019-04-22  Pedro Alves  <palves@redhat.com>
5597
5598         * solib-svr4.c (svr4_free_objfile_observer): New.
5599         (probe_and_action::objfile): New field.
5600         (probes_table_htab_remove_objfile_probes)
5601         (probes_table_remove_objfile_probes): New functions.
5602         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5603         in the new probe_and_action.  Don't store the probe in 'lookup'.
5604         (svr4_create_probe_breakpoints): Pass objfile to
5605         register_solib_event_probe.
5606         (_initialize_svr4_solib): Register a free_objfile observer.
5607
5608 2019-04-19  Tom Tromey  <tom@tromey.com>
5609
5610         * common/queue.h: Remove.
5611
5612 2019-04-19  Tom Tromey  <tom@tromey.com>
5613
5614         * event-loop.c: Don't include "common/queue.h".
5615
5616 2019-04-19  Tom Tromey  <tom@tromey.com>
5617
5618         * remote.c (remote_target): Use delete.
5619         * remote-notif.h: Include <list>, not "common/queue.h".
5620         (notif_client_p): Remove typedef.
5621         (remote_notif_state): Add constructor, destructor, initializer.
5622         <notif_queue>: Now a std::list.
5623         (remote_notif_state_xfree): Don't declare.
5624         * remote-notif.c (remote_notif_process, handle_notification)
5625         (remote_notif_state_allocate): Update.
5626         (~remote_notif_state): Rename from remote_notif_state_xfree.
5627
5628 2019-04-19  Tom Tromey  <tom@tromey.com>
5629
5630         * symfile.c (reread_symbols): Update.
5631         * objfiles.c (objfile_register_static_link)
5632         (objfile_lookup_static_link): Update
5633         (~objfile) Don't delete static_links.
5634         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5635
5636 2019-04-19  Tom Tromey  <tom@tromey.com>
5637
5638         * type-stack.h (struct type_stack) <insert>: Constify string.
5639         * type-stack.c (type_stack::insert): Constify string.
5640         * gdbtypes.h (lookup_template_type): Update.
5641         (address_space_name_to_int): Update.
5642         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5643         const.
5644         (lookup_template_type): Make name const.
5645         * c-exp.y: Update rules.
5646         (lex_one_token, classify_name, classify_inner_name)
5647         (c_print_token): Update.
5648         * p-exp.y: Update rules.
5649         (yylex): Update.
5650         * f-exp.y: Update rules.
5651         (yylex): Update.
5652         * d-exp.y: Update rules.
5653         (lex_one_token, classify_name, classify_inner_name): Update.
5654         * parse.c (write_dollar_variable, copy_name): Return std::string.
5655         * parser-defs.h (copy_name): Change return type.
5656         * m2-exp.y: Update rules.
5657         (yylex): Update.
5658         * go-exp.y (lex_one_token): Update.
5659         Update rules.
5660         (classify_unsafe_function, classify_packaged_name)
5661         (classify_name, yylex): Update.
5662
5663 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5664
5665         * configure.ac: add --enable-source-highlight switch.
5666         * configure: Regenerate.
5667         * top.c (print_gdb_version): plumb --enable-source-highlight
5668         status to "show configuration".
5669
5670 2019-04-19  Tom Tromey  <tromey@adacore.com>
5671
5672         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5673         Check ADA_TYPE_P.
5674         (empty_record, ada_template_to_fixed_record_type_1)
5675         (template_to_static_fixed_type)
5676         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5677         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5678         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5679         macros.
5680
5681 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5682
5683         PR symtab/24423:
5684         * source.c (print_source_lines_base): Advance "iter" when a
5685         control character is seen.
5686
5687 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5688
5689         * inferior.h (struct infcall_suspend_state_deleter):
5690         Catch exception in destructor to avoid crash.
5691
5692 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5693
5694         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5695         close to the add_com "shell".
5696
5697 2019-04-18  Tom Tromey  <tromey@adacore.com>
5698
5699         * process-stratum-target.h (class process_stratum_target)
5700         <stratum>: Add "final".
5701
5702 2019-04-17  Tom Tromey  <tromey@adacore.com>
5703
5704         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5705         against nullptr before use.
5706
5707 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5708
5709         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5710
5711 2019-04-17  Jim Wilson  <jimw@sifive.com>
5712             Andrew Burgess  <andrew.burgess@embecosm.com>
5713
5714         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5715         code read might fail, assume 4-byte breakpoint in that case.
5716
5717 2019-04-15  Leszek Swirski  <leszeks@google.com>
5718
5719         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5720         rather than a hand-rolled POD check when checking for forced MEMORY
5721         classification.
5722
5723 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5724
5725         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5726         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5727         function.
5728         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5729         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5730         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5731         declaration.
5732
5733 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5734
5735         * aarch64-linux-nat.c
5736         (aarch64_linux_nat_target::thread_architecture): Add override.
5737         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5738         each VQ.
5739
5740 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5741
5742         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5743
5744 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5745
5746         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5747         target types of size 96-bits, add some additional comments, and
5748         check that the builtin type we found was the correct size.
5749
5750 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5751
5752         * utils.c (prompt_for_continue): Don't restore the styling at the
5753         end, as applied_style has the wrong value.  This fixes styling in
5754         long lists of file names that are interrupted by the "Continue?"
5755         prompt.
5756
5757 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5758
5759         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5760         * c-lang.c (c_language_defn): Likewise.
5761         (cplus_language_defn): Likewise.
5762         (asm_language_defn): Likewise.
5763         (minimal_language_defn): Likewise.
5764         * d-lang.c (d_language_defn): Likewise.
5765         * f-lang.c (f_language_defn): Likewise.
5766         * go-lang.c (go_language_defn): Likewise.
5767         * language.c (unknown_language_defn): Likewise.
5768         (auto_language_defn): Likewise.
5769         * language.h (struct language_defn): Remove la_magic field.
5770         (LANG_MAGIC): Delete.
5771         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5772         * objc-lang.c (objc_language_defn): Likewise.
5773         * opencl-lang.c (opencl_language_defn): Likewise.
5774         * p-lang.c (pascal_language_defn): Likewise.
5775         * rust-lang.c (rust_language_defn): Likewise.
5776
5777 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5778
5779         * riscv-tdep.c (riscv_type_align): New function.
5780         (riscv_type_alignment): Delete.
5781         (riscv_arg_location): Use 'type_align'.
5782         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5783
5784 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5785
5786         * gdbtypes.c (type_align): A struct with no non-static fields also
5787         has alignment of 1.
5788
5789 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5790
5791         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5792         component to 0.
5793         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5794         member.
5795         (riscv_struct_info::analyse): New implementation using new
5796         analyse_inner member function.
5797         (riscv_struct_info::field_offset): New member function.
5798         (riscv_struct_info::m_offsets): New member variable.
5799         (riscv_struct_info::analyse_inner): New private member function,
5800         takes the old implementation of riscv_struct_info::analyse but
5801         extended to track field offsets.
5802         (riscv_call_arg_struct): Update the struct folding special cases
5803         to handle cases where empty C++ structs, which are non-zero
5804         length, are found.
5805         (riscv_arg_location): Initialise the length of each location, a
5806         non-zero length now indicates the location is in use.
5807         (riscv_push_dummy_call): Allow for the first location having a
5808         non-zero offset when setting up arguments.
5809         (riscv_return_value): Likewise, but for return values.
5810
5811 2019-04-11  Tom Tromey  <tromey@adacore.com>
5812
5813         * utils.c (internal_vproblem): Make "msg" const.
5814
5815 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5816
5817         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5818         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5819         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5820         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5821
5822 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5823
5824         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5825         function.
5826         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5827         of amd64_collect_native_gregset.
5828         (amd64_linux_nat_target::store_registers): Likewise.
5829
5830 2019-04-10  Tom Tromey  <tom@tromey.com>
5831
5832         * symtab.c (lookup_global_symbol_from_objfile)
5833         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5834         * objfiles.h (class separate_debug_iterator): New.
5835         (class separate_debug_range): New.
5836         (struct objfile) <separate_debug_objfiles>: New method.
5837         (objfile_separate_debug_iterate): Don't declare.
5838         * objfiles.c (separate_debug_iterator::operator++): Rename from
5839         objfile_separate_debug_iterate.
5840         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5841         iterator.
5842         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5843         iterator.
5844
5845 2019-04-10  Tom Tromey  <tom@tromey.com>
5846
5847         * symfile.c (reread_symbols): Remove old comment.
5848         * objfiles.c (free_all_objfiles): Fix a typo.
5849
5850 2019-04-10  Tom Tromey  <tom@tromey.com>
5851
5852         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5853         * minsyms.c (lookup_minimal_symbol): Use foreach.
5854         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5855         (lookup_minimal_symbol_solib_trampoline): Likewise.
5856         * symfile.c (reread_symbols): Use foreach.
5857
5858 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5859             Tom Tromey  <tromey@adacore.com>
5860
5861         PR rust/24414:
5862         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5863         (rust_lex_int_test): Change "value" to be LONGEST.
5864         (rust_lex_tests): Add test for long integer literal.
5865
5866 2019-04-09  Tom Tromey  <tromey@adacore.com>
5867
5868         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5869         to bool.
5870         (extended_remote_target::attach): Update.
5871         (remote_target::remote_notice_new_inferior): Update.
5872         (remote_target::add_current_inferior_and_thread): Update.
5873         * inferior.c (exit_inferior_1): Use "false".
5874         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5875
5876 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5877
5878         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5879         the "start" command.
5880
5881 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5882
5883         * python/py-inferior.c (infpy_thread_from_thread_handle):
5884         Adjust comments to reflect renaming of thread_from_thread_handle
5885         to thread_from_handle.  Adjust keywords.  Fix type error message.
5886         (inferior_object_methods): Add thread_from_handle.  Retain
5887         thread_from_thread_handle, but mark it as deprecated.
5888
5889 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5890
5891         * gdbthread.h (find_thread_by_handle): Revise declaration.
5892         * thread.c (find_thread_by_handle): Likewise.  Adjust
5893         implementation too.
5894         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5895         support for buffer objects as handles.
5896
5897 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5898
5899         * python/py-infthread.c (thpy_thread_handle): New function.
5900         (thread_object_methods): Register thpy_thread_handle.
5901
5902 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5903
5904         * gdbthread.h (thread_to_thread_handle): Declare.
5905         * thread.c (gdbtypes.h): Include.
5906         (thread_to_thread_handle): New function.
5907
5908         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5909         (target_thread_info_to_thread_handle): Declare.
5910         * target.c (target_thread_info_to_thread_handle): New function.
5911         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5912         * target-delegates.c: Regenerate.
5913
5914         * linux-thread-db.c (class thread_db_target): Add method
5915         thread_info_to_thread_handle.
5916         (thread_db_target::thread_info_to_thread_handle): Define.
5917         * remote.c (class remote_target): Add new method
5918         thread_info_to_thread_handle.
5919         (remote_target::thread_info_to_thread_handle): Define.
5920
5921 2019-04-08  Pedro Alves  <palves@redhat.com>
5922
5923         * common/common-exceptions.c (throw_exception): Don't create
5924         named object to throw; throw directly.
5925         (throw_it): Likewise.  Don't initialize gdb_exception::message
5926         here, with new; pass FMT and AP to the ctor instead.
5927         * common/common-exceptions.h: Include <string>.
5928         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5929         const char *, va_list)): New ctor.  Use std::make_shared.
5930         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5931         errors)): Delete.
5932         (gdb_exception_error::gdb_exception_error(enum errors, const char
5933         *, va_list)): New.
5934         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5935         Add assertion.
5936         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5937         errors)): Delete.
5938         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5939         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5940         Add assertion.
5941
5942 2019-04-08  Tom Tromey  <tom@tromey.com>
5943
5944         * valops.c (value_rtti_indirect_type): Replace throw_exception
5945         with throw.
5946         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5947         with throw.
5948         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5949         throw.
5950         * target.c (target_translate_tls_address): Replace throw_exception
5951         with throw.
5952         * stack.c (frame_apply_command_count): Replace throw_exception
5953         with throw.
5954         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5955         throw.
5956         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5957         with throw.
5958         * rs6000-tdep.c (rs6000_frame_cache)
5959         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5960         * remote.c: Replace throw_exception with throw.
5961         * record-full.c (record_full_message, record_full_wait_1)
5962         (record_full_restore): Replace throw_exception with throw.
5963         * record-btrace.c:
5964         (get_thread_current_frame_id, record_btrace_start_replaying)
5965         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5966         (cmd_record_btrace_start): Replace throw_exception with throw.
5967         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5968         throw.
5969         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5970         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5971         * linespec.c:
5972         (find_linespec_symbols): Replace throw_exception with throw.
5973         * infrun.c (displaced_step_prepare, resume): Replace
5974         throw_exception with throw.
5975         * infcmd.c (post_create_inferior): Replace throw_exception with
5976         throw.
5977         * inf-loop.c (inferior_event_handler): Replace throw_exception
5978         with throw.
5979         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5980         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5981         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5982         (get_prev_frame_always, get_frame_pc_if_available)
5983         (get_frame_address_in_block_if_available, get_frame_language):
5984         Replace throw_exception with throw.
5985         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5986         throw_exception with throw.
5987         * eval.c (fetch_subexp_value, evaluate_var_value)
5988         (evaluate_funcall, evaluate_subexp_standard): Replace
5989         throw_exception with throw.
5990         * dwarf2loc.c (call_site_find_chain)
5991         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5992         Replace throw_exception with throw.
5993         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5994         with throw.
5995         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5996         throw.
5997         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5998         * completer.c (complete_line_internal): Replace throw_exception
5999         with throw.
6000         * compile/compile-object-run.c (compile_object_run): Replace
6001         throw_exception with throw.
6002         * cli/cli-script.c (process_next_line): Replace throw_exception
6003         with throw.
6004         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6005         (btrace_enable, btrace_maint_update_pt_packets): Replace
6006         throw_exception with throw.
6007         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6008         throw_exception with throw.
6009         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6010         throw_exception with throw.
6011         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6012         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6013         * aarch64-tdep.c (aarch64_make_prologue_cache)
6014         (aarch64_make_stub_cache): Replace throw_exception with throw.
6015
6016 2019-04-08  Tom Tromey  <tom@tromey.com>
6017
6018         * common/common-exceptions.c (throw_exception): Rename from
6019         throw_exception_cxx.  Remove old copy.  Make argument const.
6020         (throw_it): Create and throw exception objects directly.
6021         * common/common-exceptions.h (throw_exception): Make argument
6022         const.
6023         (struct gdb_exception_error): Add constructor.
6024         (struct gdb_exception_quit): Add constructor.
6025
6026 2019-04-08  Tom Tromey  <tom@tromey.com>
6027
6028         * common/common-exceptions.h (exception_rethrow): Don't declare.
6029         (TRY_SJLJ): Update comment.
6030         (TRY, CATCH, END_CATCH): Remove.
6031         * common/common-exceptions.c (exception_rethrow): Remove.
6032
6033 2019-04-08  Tom Tromey  <tom@tromey.com>
6034
6035         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6036         Remove.
6037         (gdb_exception_error): Rename from
6038         gdb_exception_RETURN_MASK_ERROR.
6039         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6040         (gdb_quit_bad_alloc): Update.
6041         * aarch64-tdep.c: Update.
6042         * ada-lang.c: Update.
6043         * ada-typeprint.c: Update.
6044         * ada-valprint.c: Update.
6045         * amd64-tdep.c: Update.
6046         * arch-utils.c: Update.
6047         * break-catch-throw.c: Update.
6048         * breakpoint.c: Update.
6049         * btrace.c: Update.
6050         * c-varobj.c: Update.
6051         * cli/cli-cmds.c: Update.
6052         * cli/cli-interp.c: Update.
6053         * cli/cli-script.c: Update.
6054         * common/common-exceptions.c: Update.
6055         * common/new-op.c: Update.
6056         * common/selftest.c: Update.
6057         * compile/compile-c-symbols.c: Update.
6058         * compile/compile-cplus-symbols.c: Update.
6059         * compile/compile-object-load.c: Update.
6060         * compile/compile-object-run.c: Update.
6061         * completer.c: Update.
6062         * corelow.c: Update.
6063         * cp-abi.c: Update.
6064         * cp-support.c: Update.
6065         * cp-valprint.c: Update.
6066         * darwin-nat.c: Update.
6067         * disasm-selftests.c: Update.
6068         * dtrace-probe.c: Update.
6069         * dwarf-index-cache.c: Update.
6070         * dwarf-index-write.c: Update.
6071         * dwarf2-frame-tailcall.c: Update.
6072         * dwarf2-frame.c: Update.
6073         * dwarf2loc.c: Update.
6074         * dwarf2read.c: Update.
6075         * eval.c: Update.
6076         * event-loop.c: Update.
6077         * event-top.c: Update.
6078         * exec.c: Update.
6079         * f-valprint.c: Update.
6080         * fbsd-tdep.c: Update.
6081         * frame-unwind.c: Update.
6082         * frame.c: Update.
6083         * gdbtypes.c: Update.
6084         * gnu-v3-abi.c: Update.
6085         * guile/guile-internal.h: Update.
6086         * guile/scm-block.c: Update.
6087         * guile/scm-breakpoint.c: Update.
6088         * guile/scm-cmd.c: Update.
6089         * guile/scm-disasm.c: Update.
6090         * guile/scm-frame.c: Update.
6091         * guile/scm-lazy-string.c: Update.
6092         * guile/scm-math.c: Update.
6093         * guile/scm-param.c: Update.
6094         * guile/scm-ports.c: Update.
6095         * guile/scm-pretty-print.c: Update.
6096         * guile/scm-symbol.c: Update.
6097         * guile/scm-symtab.c: Update.
6098         * guile/scm-type.c: Update.
6099         * guile/scm-value.c: Update.
6100         * i386-linux-tdep.c: Update.
6101         * i386-tdep.c: Update.
6102         * inf-loop.c: Update.
6103         * infcall.c: Update.
6104         * infcmd.c: Update.
6105         * infrun.c: Update.
6106         * jit.c: Update.
6107         * language.c: Update.
6108         * linespec.c: Update.
6109         * linux-fork.c: Update.
6110         * linux-nat.c: Update.
6111         * linux-tdep.c: Update.
6112         * linux-thread-db.c: Update.
6113         * main.c: Update.
6114         * mi/mi-cmd-break.c: Update.
6115         * mi/mi-cmd-stack.c: Update.
6116         * mi/mi-interp.c: Update.
6117         * mi/mi-main.c: Update.
6118         * objc-lang.c: Update.
6119         * p-valprint.c: Update.
6120         * parse.c: Update.
6121         * ppc-linux-tdep.c: Update.
6122         * printcmd.c: Update.
6123         * python/py-arch.c: Update.
6124         * python/py-breakpoint.c: Update.
6125         * python/py-cmd.c: Update.
6126         * python/py-finishbreakpoint.c: Update.
6127         * python/py-frame.c: Update.
6128         * python/py-framefilter.c: Update.
6129         * python/py-gdb-readline.c: Update.
6130         * python/py-inferior.c: Update.
6131         * python/py-infthread.c: Update.
6132         * python/py-lazy-string.c: Update.
6133         * python/py-linetable.c: Update.
6134         * python/py-objfile.c: Update.
6135         * python/py-param.c: Update.
6136         * python/py-prettyprint.c: Update.
6137         * python/py-progspace.c: Update.
6138         * python/py-record-btrace.c: Update.
6139         * python/py-record.c: Update.
6140         * python/py-symbol.c: Update.
6141         * python/py-type.c: Update.
6142         * python/py-unwind.c: Update.
6143         * python/py-utils.c: Update.
6144         * python/py-value.c: Update.
6145         * python/python.c: Update.
6146         * record-btrace.c: Update.
6147         * record-full.c: Update.
6148         * remote-fileio.c: Update.
6149         * remote.c: Update.
6150         * riscv-tdep.c: Update.
6151         * rs6000-aix-tdep.c: Update.
6152         * rs6000-tdep.c: Update.
6153         * rust-exp.y: Update.
6154         * rust-lang.c: Update.
6155         * s390-tdep.c: Update.
6156         * selftest-arch.c: Update.
6157         * solib-dsbt.c: Update.
6158         * solib-frv.c: Update.
6159         * solib-spu.c: Update.
6160         * solib-svr4.c: Update.
6161         * solib.c: Update.
6162         * sparc64-linux-tdep.c: Update.
6163         * stack.c: Update.
6164         * symfile-mem.c: Update.
6165         * symmisc.c: Update.
6166         * target.c: Update.
6167         * thread.c: Update.
6168         * top.c: Update.
6169         * tracefile-tfile.c: Update.
6170         * tui/tui.c: Update.
6171         * typeprint.c: Update.
6172         * unittests/cli-utils-selftests.c: Update.
6173         * unittests/parse-connection-spec-selftests.c: Update.
6174         * valops.c: Update.
6175         * valprint.c: Update.
6176         * value.c: Update.
6177         * varobj.c: Update.
6178         * windows-nat.c: Update.
6179         * x86-linux-nat.c: Update.
6180         * xml-support.c: Update.
6181
6182 2019-04-08  Tom Tromey  <tom@tromey.com>
6183
6184         * xml-support.c: Use C++ exception handling.
6185         * x86-linux-nat.c: Use C++ exception handling.
6186         * windows-nat.c: Use C++ exception handling.
6187         * varobj.c: Use C++ exception handling.
6188         * value.c: Use C++ exception handling.
6189         * valprint.c: Use C++ exception handling.
6190         * valops.c: Use C++ exception handling.
6191         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6192         handling.
6193         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6194         * typeprint.c: Use C++ exception handling.
6195         * tui/tui.c: Use C++ exception handling.
6196         * tracefile-tfile.c: Use C++ exception handling.
6197         * top.c: Use C++ exception handling.
6198         * thread.c: Use C++ exception handling.
6199         * target.c: Use C++ exception handling.
6200         * symmisc.c: Use C++ exception handling.
6201         * symfile-mem.c: Use C++ exception handling.
6202         * stack.c: Use C++ exception handling.
6203         * sparc64-linux-tdep.c: Use C++ exception handling.
6204         * solib.c: Use C++ exception handling.
6205         * solib-svr4.c: Use C++ exception handling.
6206         * solib-spu.c: Use C++ exception handling.
6207         * solib-frv.c: Use C++ exception handling.
6208         * solib-dsbt.c: Use C++ exception handling.
6209         * selftest-arch.c: Use C++ exception handling.
6210         * s390-tdep.c: Use C++ exception handling.
6211         * rust-lang.c: Use C++ exception handling.
6212         * rust-exp.y: Use C++ exception handling.
6213         * rs6000-tdep.c: Use C++ exception handling.
6214         * rs6000-aix-tdep.c: Use C++ exception handling.
6215         * riscv-tdep.c: Use C++ exception handling.
6216         * remote.c: Use C++ exception handling.
6217         * remote-fileio.c: Use C++ exception handling.
6218         * record-full.c: Use C++ exception handling.
6219         * record-btrace.c: Use C++ exception handling.
6220         * python/python.c: Use C++ exception handling.
6221         * python/py-value.c: Use C++ exception handling.
6222         * python/py-utils.c: Use C++ exception handling.
6223         * python/py-unwind.c: Use C++ exception handling.
6224         * python/py-type.c: Use C++ exception handling.
6225         * python/py-symbol.c: Use C++ exception handling.
6226         * python/py-record.c: Use C++ exception handling.
6227         * python/py-record-btrace.c: Use C++ exception handling.
6228         * python/py-progspace.c: Use C++ exception handling.
6229         * python/py-prettyprint.c: Use C++ exception handling.
6230         * python/py-param.c: Use C++ exception handling.
6231         * python/py-objfile.c: Use C++ exception handling.
6232         * python/py-linetable.c: Use C++ exception handling.
6233         * python/py-lazy-string.c: Use C++ exception handling.
6234         * python/py-infthread.c: Use C++ exception handling.
6235         * python/py-inferior.c: Use C++ exception handling.
6236         * python/py-gdb-readline.c: Use C++ exception handling.
6237         * python/py-framefilter.c: Use C++ exception handling.
6238         * python/py-frame.c: Use C++ exception handling.
6239         * python/py-finishbreakpoint.c: Use C++ exception handling.
6240         * python/py-cmd.c: Use C++ exception handling.
6241         * python/py-breakpoint.c: Use C++ exception handling.
6242         * python/py-arch.c: Use C++ exception handling.
6243         * printcmd.c: Use C++ exception handling.
6244         * ppc-linux-tdep.c: Use C++ exception handling.
6245         * parse.c: Use C++ exception handling.
6246         * p-valprint.c: Use C++ exception handling.
6247         * objc-lang.c: Use C++ exception handling.
6248         * mi/mi-main.c: Use C++ exception handling.
6249         * mi/mi-interp.c: Use C++ exception handling.
6250         * mi/mi-cmd-stack.c: Use C++ exception handling.
6251         * mi/mi-cmd-break.c: Use C++ exception handling.
6252         * main.c: Use C++ exception handling.
6253         * linux-thread-db.c: Use C++ exception handling.
6254         * linux-tdep.c: Use C++ exception handling.
6255         * linux-nat.c: Use C++ exception handling.
6256         * linux-fork.c: Use C++ exception handling.
6257         * linespec.c: Use C++ exception handling.
6258         * language.c: Use C++ exception handling.
6259         * jit.c: Use C++ exception handling.
6260         * infrun.c: Use C++ exception handling.
6261         * infcmd.c: Use C++ exception handling.
6262         * infcall.c: Use C++ exception handling.
6263         * inf-loop.c: Use C++ exception handling.
6264         * i386-tdep.c: Use C++ exception handling.
6265         * i386-linux-tdep.c: Use C++ exception handling.
6266         * guile/scm-value.c: Use C++ exception handling.
6267         * guile/scm-type.c: Use C++ exception handling.
6268         * guile/scm-symtab.c: Use C++ exception handling.
6269         * guile/scm-symbol.c: Use C++ exception handling.
6270         * guile/scm-pretty-print.c: Use C++ exception handling.
6271         * guile/scm-ports.c: Use C++ exception handling.
6272         * guile/scm-param.c: Use C++ exception handling.
6273         * guile/scm-math.c: Use C++ exception handling.
6274         * guile/scm-lazy-string.c: Use C++ exception handling.
6275         * guile/scm-frame.c: Use C++ exception handling.
6276         * guile/scm-disasm.c: Use C++ exception handling.
6277         * guile/scm-cmd.c: Use C++ exception handling.
6278         * guile/scm-breakpoint.c: Use C++ exception handling.
6279         * guile/scm-block.c: Use C++ exception handling.
6280         * guile/guile-internal.h: Use C++ exception handling.
6281         * gnu-v3-abi.c: Use C++ exception handling.
6282         * gdbtypes.c: Use C++ exception handling.
6283         * frame.c: Use C++ exception handling.
6284         * frame-unwind.c: Use C++ exception handling.
6285         * fbsd-tdep.c: Use C++ exception handling.
6286         * f-valprint.c: Use C++ exception handling.
6287         * exec.c: Use C++ exception handling.
6288         * event-top.c: Use C++ exception handling.
6289         * event-loop.c: Use C++ exception handling.
6290         * eval.c: Use C++ exception handling.
6291         * dwarf2read.c: Use C++ exception handling.
6292         * dwarf2loc.c: Use C++ exception handling.
6293         * dwarf2-frame.c: Use C++ exception handling.
6294         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6295         * dwarf-index-write.c: Use C++ exception handling.
6296         * dwarf-index-cache.c: Use C++ exception handling.
6297         * dtrace-probe.c: Use C++ exception handling.
6298         * disasm-selftests.c: Use C++ exception handling.
6299         * darwin-nat.c: Use C++ exception handling.
6300         * cp-valprint.c: Use C++ exception handling.
6301         * cp-support.c: Use C++ exception handling.
6302         * cp-abi.c: Use C++ exception handling.
6303         * corelow.c: Use C++ exception handling.
6304         * completer.c: Use C++ exception handling.
6305         * compile/compile-object-run.c: Use C++ exception handling.
6306         * compile/compile-object-load.c: Use C++ exception handling.
6307         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6308         * compile/compile-c-symbols.c: Use C++ exception handling.
6309         * common/selftest.c: Use C++ exception handling.
6310         * common/new-op.c: Use C++ exception handling.
6311         * cli/cli-script.c: Use C++ exception handling.
6312         * cli/cli-interp.c: Use C++ exception handling.
6313         * cli/cli-cmds.c: Use C++ exception handling.
6314         * c-varobj.c: Use C++ exception handling.
6315         * btrace.c: Use C++ exception handling.
6316         * breakpoint.c: Use C++ exception handling.
6317         * break-catch-throw.c: Use C++ exception handling.
6318         * arch-utils.c: Use C++ exception handling.
6319         * amd64-tdep.c: Use C++ exception handling.
6320         * ada-valprint.c: Use C++ exception handling.
6321         * ada-typeprint.c: Use C++ exception handling.
6322         * ada-lang.c: Use C++ exception handling.
6323         * aarch64-tdep.c: Use C++ exception handling.
6324
6325 2019-04-08  Tom Tromey  <tom@tromey.com>
6326
6327         * xml-support.c (gdb_xml_parser::parse): Update.
6328         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6329         * value.c (show_convenience): Update.
6330         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6331         (test_parse_flags_qcs): Update.
6332         * thread.c (thr_try_catch_cmd): Update.
6333         * target.c (target_translate_tls_address): Update.
6334         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6335         (info_frame_command_core, frame_apply_command_count): Update.
6336         * rust-exp.y (rust_lex_exception_test): Update.
6337         * riscv-tdep.c (riscv_print_one_register_info): Update.
6338         * remote.c (remote_target::enable_btrace): Update.
6339         * record-btrace.c (record_btrace_enable_warn): Update.
6340         * python/py-utils.c (gdbpy_convert_exception): Update.
6341         * printcmd.c (do_one_display, print_variable_and_value): Update.
6342         * mi/mi-main.c (mi_print_exception): Update.
6343         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6344         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6345         * linux-nat.c (linux_nat_target::attach): Update.
6346         * linux-fork.c (class scoped_switch_fork_info): Update.
6347         * infrun.c (displaced_step_prepare): Update.
6348         * infcall.c (call_function_by_hand_dummy): Update.
6349         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6350         * gnu-v3-abi.c (print_one_vtable): Update.
6351         * frame.c (get_prev_frame_always): Update.
6352         * f-valprint.c (info_common_command_for_block): Update.
6353         * exec.c (try_open_exec_file): Update.
6354         * exceptions.c (print_exception, exception_print)
6355         (exception_fprintf, exception_print_same): Update.
6356         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6357         * dwarf-index-cache.c (index_cache::store)
6358         (index_cache::lookup_gdb_index): Update.
6359         * darwin-nat.c (maybe_cache_shell): Update.
6360         * cp-valprint.c (cp_print_value_fields): Update.
6361         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6362         (gcc_cplus_symbol_address): Update.
6363         * compile/compile-c-symbols.c (gcc_convert_symbol)
6364         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6365         * common/selftest.c: Update.
6366         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6367         a std::string.
6368         (exception_try_scope_entry, exception_try_scope_exit): Don't
6369         declare.
6370         (struct exception_try_scope): Remove.
6371         (TRY): Don't use exception_try_scope.
6372         (struct gdb_exception): Add constructor, operator=.
6373         <what>: New method.
6374         (struct gdb_exception_RETURN_MASK_ALL)
6375         (struct gdb_exception_RETURN_MASK_ERROR)
6376         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6377         (struct gdb_quit_bad_alloc): Update.
6378         * common/common-exceptions.c (exception_none): Change
6379         initializer.
6380         (struct catcher) <state, exception>: Initialize inline.
6381         <prev>: Remove member.
6382         (current_catcher): Remove.
6383         (catchers): New global.
6384         (exceptions_state_mc_init): Simplify.
6385         (catcher_pop): Remove.
6386         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6387         (try_scope_depth, exception_try_scope_entry)
6388         (exception_try_scope_exit): Remove.
6389         (throw_exception_sjlj): Update.
6390         (exception_messages, exception_messages_size): Remove.
6391         (throw_it): Simplify.
6392         (gdb_exception_sliced_copy): Remove.
6393         (throw_exception_cxx): Update.
6394         * cli/cli-script.c (script_from_file): Update.
6395         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6396         Update.
6397         * ada-valprint.c (ada_val_print): Update.
6398         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6399         (create_excep_cond_exprs): Update.
6400
6401 2019-04-08  Tom Tromey  <tom@tromey.com>
6402
6403         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6404         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6405         (TRY, CATCH, END_CATCH): Remove some definitions.
6406         * common/common-exceptions.c: Don't use GDB_XCPT.
6407         (catcher_list_size): Remove.
6408         (throw_exception, throw_it): Simplify.
6409
6410 2019-04-05  Tom Tromey  <tom@tromey.com>
6411
6412         Revert the header-sorting patch.
6413         * ft32-tdep.c: Revert.
6414         * frv-tdep.c: Revert.
6415         * frv-linux-tdep.c: Revert.
6416         * frame.c: Revert.
6417         * frame-unwind.c: Revert.
6418         * frame-base.c: Revert.
6419         * fork-child.c: Revert.
6420         * findvar.c: Revert.
6421         * findcmd.c: Revert.
6422         * filesystem.c: Revert.
6423         * filename-seen-cache.h: Revert.
6424         * filename-seen-cache.c: Revert.
6425         * fbsd-tdep.c: Revert.
6426         * fbsd-nat.h: Revert.
6427         * fbsd-nat.c: Revert.
6428         * f-valprint.c: Revert.
6429         * f-typeprint.c: Revert.
6430         * f-lang.c: Revert.
6431         * extension.h: Revert.
6432         * extension.c: Revert.
6433         * extension-priv.h: Revert.
6434         * expprint.c: Revert.
6435         * exec.h: Revert.
6436         * exec.c: Revert.
6437         * exceptions.c: Revert.
6438         * event-top.c: Revert.
6439         * event-loop.c: Revert.
6440         * eval.c: Revert.
6441         * elfread.c: Revert.
6442         * dwarf2read.h: Revert.
6443         * dwarf2read.c: Revert.
6444         * dwarf2loc.c: Revert.
6445         * dwarf2expr.h: Revert.
6446         * dwarf2expr.c: Revert.
6447         * dwarf2-frame.c: Revert.
6448         * dwarf2-frame-tailcall.c: Revert.
6449         * dwarf-index-write.h: Revert.
6450         * dwarf-index-write.c: Revert.
6451         * dwarf-index-common.c: Revert.
6452         * dwarf-index-cache.h: Revert.
6453         * dwarf-index-cache.c: Revert.
6454         * dummy-frame.c: Revert.
6455         * dtrace-probe.c: Revert.
6456         * disasm.h: Revert.
6457         * disasm.c: Revert.
6458         * disasm-selftests.c: Revert.
6459         * dictionary.c: Revert.
6460         * dicos-tdep.c: Revert.
6461         * demangle.c: Revert.
6462         * dcache.h: Revert.
6463         * dcache.c: Revert.
6464         * darwin-nat.h: Revert.
6465         * darwin-nat.c: Revert.
6466         * darwin-nat-info.c: Revert.
6467         * d-valprint.c: Revert.
6468         * d-namespace.c: Revert.
6469         * d-lang.c: Revert.
6470         * ctf.c: Revert.
6471         * csky-tdep.c: Revert.
6472         * csky-linux-tdep.c: Revert.
6473         * cris-tdep.c: Revert.
6474         * cris-linux-tdep.c: Revert.
6475         * cp-valprint.c: Revert.
6476         * cp-support.c: Revert.
6477         * cp-namespace.c: Revert.
6478         * cp-abi.c: Revert.
6479         * corelow.c: Revert.
6480         * corefile.c: Revert.
6481         * continuations.c: Revert.
6482         * completer.h: Revert.
6483         * completer.c: Revert.
6484         * complaints.c: Revert.
6485         * coffread.c: Revert.
6486         * coff-pe-read.c: Revert.
6487         * cli-out.h: Revert.
6488         * cli-out.c: Revert.
6489         * charset.c: Revert.
6490         * c-varobj.c: Revert.
6491         * c-valprint.c: Revert.
6492         * c-typeprint.c: Revert.
6493         * c-lang.c: Revert.
6494         * buildsym.c: Revert.
6495         * buildsym-legacy.c: Revert.
6496         * build-id.h: Revert.
6497         * build-id.c: Revert.
6498         * btrace.c: Revert.
6499         * bsd-uthread.c: Revert.
6500         * breakpoint.h: Revert.
6501         * breakpoint.c: Revert.
6502         * break-catch-throw.c: Revert.
6503         * break-catch-syscall.c: Revert.
6504         * break-catch-sig.c: Revert.
6505         * blockframe.c: Revert.
6506         * block.c: Revert.
6507         * bfin-tdep.c: Revert.
6508         * bfin-linux-tdep.c: Revert.
6509         * bfd-target.c: Revert.
6510         * bcache.c: Revert.
6511         * ax-general.c: Revert.
6512         * ax-gdb.h: Revert.
6513         * ax-gdb.c: Revert.
6514         * avr-tdep.c: Revert.
6515         * auxv.c: Revert.
6516         * auto-load.c: Revert.
6517         * arm-wince-tdep.c: Revert.
6518         * arm-tdep.c: Revert.
6519         * arm-symbian-tdep.c: Revert.
6520         * arm-pikeos-tdep.c: Revert.
6521         * arm-obsd-tdep.c: Revert.
6522         * arm-nbsd-tdep.c: Revert.
6523         * arm-nbsd-nat.c: Revert.
6524         * arm-linux-tdep.c: Revert.
6525         * arm-linux-nat.c: Revert.
6526         * arm-fbsd-tdep.c: Revert.
6527         * arm-fbsd-nat.c: Revert.
6528         * arm-bsd-tdep.c: Revert.
6529         * arch-utils.c: Revert.
6530         * arc-tdep.c: Revert.
6531         * arc-newlib-tdep.c: Revert.
6532         * annotate.h: Revert.
6533         * annotate.c: Revert.
6534         * amd64-windows-tdep.c: Revert.
6535         * amd64-windows-nat.c: Revert.
6536         * amd64-tdep.c: Revert.
6537         * amd64-sol2-tdep.c: Revert.
6538         * amd64-obsd-tdep.c: Revert.
6539         * amd64-obsd-nat.c: Revert.
6540         * amd64-nbsd-tdep.c: Revert.
6541         * amd64-nbsd-nat.c: Revert.
6542         * amd64-nat.c: Revert.
6543         * amd64-linux-tdep.c: Revert.
6544         * amd64-linux-nat.c: Revert.
6545         * amd64-fbsd-tdep.c: Revert.
6546         * amd64-fbsd-nat.c: Revert.
6547         * amd64-dicos-tdep.c: Revert.
6548         * amd64-darwin-tdep.c: Revert.
6549         * amd64-bsd-nat.c: Revert.
6550         * alpha-tdep.c: Revert.
6551         * alpha-obsd-tdep.c: Revert.
6552         * alpha-nbsd-tdep.c: Revert.
6553         * alpha-mdebug-tdep.c: Revert.
6554         * alpha-linux-tdep.c: Revert.
6555         * alpha-linux-nat.c: Revert.
6556         * alpha-bsd-tdep.c: Revert.
6557         * alpha-bsd-nat.c: Revert.
6558         * aix-thread.c: Revert.
6559         * agent.c: Revert.
6560         * addrmap.c: Revert.
6561         * ada-varobj.c: Revert.
6562         * ada-valprint.c: Revert.
6563         * ada-typeprint.c: Revert.
6564         * ada-tasks.c: Revert.
6565         * ada-lang.c: Revert.
6566         * aarch64-tdep.c: Revert.
6567         * aarch64-ravenscar-thread.c: Revert.
6568         * aarch64-newlib-tdep.c: Revert.
6569         * aarch64-linux-tdep.c: Revert.
6570         * aarch64-linux-nat.c: Revert.
6571         * aarch64-fbsd-tdep.c: Revert.
6572         * aarch64-fbsd-nat.c: Revert.
6573         * aarch32-linux-nat.c: Revert.
6574
6575 2019-04-05  Tom Tromey  <tom@tromey.com>
6576
6577         * ft32-tdep.c: Sort headers.
6578         * frv-tdep.c: Sort headers.
6579         * frv-linux-tdep.c: Sort headers.
6580         * frame.c: Sort headers.
6581         * frame-unwind.c: Sort headers.
6582         * frame-base.c: Sort headers.
6583         * fork-child.c: Sort headers.
6584         * findvar.c: Sort headers.
6585         * findcmd.c: Sort headers.
6586         * filesystem.c: Sort headers.
6587         * filename-seen-cache.h: Sort headers.
6588         * filename-seen-cache.c: Sort headers.
6589         * fbsd-tdep.c: Sort headers.
6590         * fbsd-nat.h: Sort headers.
6591         * fbsd-nat.c: Sort headers.
6592         * f-valprint.c: Sort headers.
6593         * f-typeprint.c: Sort headers.
6594         * f-lang.c: Sort headers.
6595         * extension.h: Sort headers.
6596         * extension.c: Sort headers.
6597         * extension-priv.h: Sort headers.
6598         * expprint.c: Sort headers.
6599         * exec.h: Sort headers.
6600         * exec.c: Sort headers.
6601         * exceptions.c: Sort headers.
6602         * event-top.c: Sort headers.
6603         * event-loop.c: Sort headers.
6604         * eval.c: Sort headers.
6605         * elfread.c: Sort headers.
6606         * dwarf2read.h: Sort headers.
6607         * dwarf2read.c: Sort headers.
6608         * dwarf2loc.c: Sort headers.
6609         * dwarf2expr.h: Sort headers.
6610         * dwarf2expr.c: Sort headers.
6611         * dwarf2-frame.c: Sort headers.
6612         * dwarf2-frame-tailcall.c: Sort headers.
6613         * dwarf-index-write.h: Sort headers.
6614         * dwarf-index-write.c: Sort headers.
6615         * dwarf-index-common.c: Sort headers.
6616         * dwarf-index-cache.h: Sort headers.
6617         * dwarf-index-cache.c: Sort headers.
6618         * dummy-frame.c: Sort headers.
6619         * dtrace-probe.c: Sort headers.
6620         * disasm.h: Sort headers.
6621         * disasm.c: Sort headers.
6622         * disasm-selftests.c: Sort headers.
6623         * dictionary.c: Sort headers.
6624         * dicos-tdep.c: Sort headers.
6625         * demangle.c: Sort headers.
6626         * dcache.h: Sort headers.
6627         * dcache.c: Sort headers.
6628         * darwin-nat.h: Sort headers.
6629         * darwin-nat.c: Sort headers.
6630         * darwin-nat-info.c: Sort headers.
6631         * d-valprint.c: Sort headers.
6632         * d-namespace.c: Sort headers.
6633         * d-lang.c: Sort headers.
6634         * ctf.c: Sort headers.
6635         * csky-tdep.c: Sort headers.
6636         * csky-linux-tdep.c: Sort headers.
6637         * cris-tdep.c: Sort headers.
6638         * cris-linux-tdep.c: Sort headers.
6639         * cp-valprint.c: Sort headers.
6640         * cp-support.c: Sort headers.
6641         * cp-namespace.c: Sort headers.
6642         * cp-abi.c: Sort headers.
6643         * corelow.c: Sort headers.
6644         * corefile.c: Sort headers.
6645         * continuations.c: Sort headers.
6646         * completer.h: Sort headers.
6647         * completer.c: Sort headers.
6648         * complaints.c: Sort headers.
6649         * coffread.c: Sort headers.
6650         * coff-pe-read.c: Sort headers.
6651         * cli-out.h: Sort headers.
6652         * cli-out.c: Sort headers.
6653         * charset.c: Sort headers.
6654         * c-varobj.c: Sort headers.
6655         * c-valprint.c: Sort headers.
6656         * c-typeprint.c: Sort headers.
6657         * c-lang.c: Sort headers.
6658         * buildsym.c: Sort headers.
6659         * buildsym-legacy.c: Sort headers.
6660         * build-id.h: Sort headers.
6661         * build-id.c: Sort headers.
6662         * btrace.c: Sort headers.
6663         * bsd-uthread.c: Sort headers.
6664         * breakpoint.h: Sort headers.
6665         * breakpoint.c: Sort headers.
6666         * break-catch-throw.c: Sort headers.
6667         * break-catch-syscall.c: Sort headers.
6668         * break-catch-sig.c: Sort headers.
6669         * blockframe.c: Sort headers.
6670         * block.c: Sort headers.
6671         * bfin-tdep.c: Sort headers.
6672         * bfin-linux-tdep.c: Sort headers.
6673         * bfd-target.c: Sort headers.
6674         * bcache.c: Sort headers.
6675         * ax-general.c: Sort headers.
6676         * ax-gdb.h: Sort headers.
6677         * ax-gdb.c: Sort headers.
6678         * avr-tdep.c: Sort headers.
6679         * auxv.c: Sort headers.
6680         * auto-load.c: Sort headers.
6681         * arm-wince-tdep.c: Sort headers.
6682         * arm-tdep.c: Sort headers.
6683         * arm-symbian-tdep.c: Sort headers.
6684         * arm-pikeos-tdep.c: Sort headers.
6685         * arm-obsd-tdep.c: Sort headers.
6686         * arm-nbsd-tdep.c: Sort headers.
6687         * arm-nbsd-nat.c: Sort headers.
6688         * arm-linux-tdep.c: Sort headers.
6689         * arm-linux-nat.c: Sort headers.
6690         * arm-fbsd-tdep.c: Sort headers.
6691         * arm-fbsd-nat.c: Sort headers.
6692         * arm-bsd-tdep.c: Sort headers.
6693         * arch-utils.c: Sort headers.
6694         * arc-tdep.c: Sort headers.
6695         * arc-newlib-tdep.c: Sort headers.
6696         * annotate.h: Sort headers.
6697         * annotate.c: Sort headers.
6698         * amd64-windows-tdep.c: Sort headers.
6699         * amd64-windows-nat.c: Sort headers.
6700         * amd64-tdep.c: Sort headers.
6701         * amd64-sol2-tdep.c: Sort headers.
6702         * amd64-obsd-tdep.c: Sort headers.
6703         * amd64-obsd-nat.c: Sort headers.
6704         * amd64-nbsd-tdep.c: Sort headers.
6705         * amd64-nbsd-nat.c: Sort headers.
6706         * amd64-nat.c: Sort headers.
6707         * amd64-linux-tdep.c: Sort headers.
6708         * amd64-linux-nat.c: Sort headers.
6709         * amd64-fbsd-tdep.c: Sort headers.
6710         * amd64-fbsd-nat.c: Sort headers.
6711         * amd64-dicos-tdep.c: Sort headers.
6712         * amd64-darwin-tdep.c: Sort headers.
6713         * amd64-bsd-nat.c: Sort headers.
6714         * alpha-tdep.c: Sort headers.
6715         * alpha-obsd-tdep.c: Sort headers.
6716         * alpha-nbsd-tdep.c: Sort headers.
6717         * alpha-mdebug-tdep.c: Sort headers.
6718         * alpha-linux-tdep.c: Sort headers.
6719         * alpha-linux-nat.c: Sort headers.
6720         * alpha-bsd-tdep.c: Sort headers.
6721         * alpha-bsd-nat.c: Sort headers.
6722         * aix-thread.c: Sort headers.
6723         * agent.c: Sort headers.
6724         * addrmap.c: Sort headers.
6725         * ada-varobj.c: Sort headers.
6726         * ada-valprint.c: Sort headers.
6727         * ada-typeprint.c: Sort headers.
6728         * ada-tasks.c: Sort headers.
6729         * ada-lang.c: Sort headers.
6730         * aarch64-tdep.c: Sort headers.
6731         * aarch64-ravenscar-thread.c: Sort headers.
6732         * aarch64-newlib-tdep.c: Sort headers.
6733         * aarch64-linux-tdep.c: Sort headers.
6734         * aarch64-linux-nat.c: Sort headers.
6735         * aarch64-fbsd-tdep.c: Sort headers.
6736         * aarch64-fbsd-nat.c: Sort headers.
6737         * aarch32-linux-nat.c: Sort headers.
6738
6739 2019-04-04  Tom Tromey  <tom@tromey.com>
6740
6741         * varobj.c (varobj_create): Update.
6742         * rust-exp.y (struct rust_parser) <update_innermost_block,
6743         lookup_symbol>: New methods.
6744         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6745         Rename.
6746         (rust_parser::rust_lookup_type)
6747         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6748         * printcmd.c (display_command, do_one_display): Update.
6749         * parser-defs.h (struct parser_state) <parser_state>: Add
6750         "tracker" parameter.
6751         (block_tracker): New member.
6752         (class innermost_block_tracker) <innermost_block_tracker>: Add
6753         "types" parameter.
6754         <reset>: Remove method.
6755         (innermost_block): Don't declare.
6756         (null_post_parser): Update.
6757         * parse.c (innermost_block): Remove global.
6758         (write_dollar_variable): Update.
6759         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6760         Remove "tracker_types" parameter.
6761         (parse_expression): Add "tracker" parameter.
6762         (parse_expression_for_completion): Update.
6763         (null_post_parser): Add "tracker" parameter.
6764         * p-exp.y: Update rules.
6765         * m2-exp.y: Update rules.
6766         * language.h (struct language_defn) <la_post_parser>: Add
6767         "tracker" parameter.
6768         * go-exp.y: Update rules.
6769         * f-exp.y: Update rules.
6770         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6771         parameter.
6772         * d-exp.y: Update rules.
6773         * c-exp.y: Update rules.
6774         * breakpoint.c (set_breakpoint_condition): Create an
6775         innermost_block_tracker.
6776         (watch_command_1): Likewise.
6777         * ada-lang.c (resolve): Add "tracker" parameter.
6778         (resolve_subexp): Likewise.
6779         * ada-exp.y (write_var_from_sym): Update.
6780
6781 2019-04-04  Tom Tromey  <tom@tromey.com>
6782
6783         * type-stack.h: New file.
6784         * type-stack.c: New file.
6785         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6786         type-stack.h.
6787         (insert_into_type_stack, insert_type, push_type, push_type_int)
6788         (insert_type_address_space, pop_type, pop_type_int)
6789         (pop_typelist, pop_type_stack, append_type_stack)
6790         (push_type_stack, get_type_stack, push_typelist)
6791         (follow_type_instance_flags, follow_types): Don't declare.
6792         * parse.c (type_stack): Remove global.
6793         (parse_exp_in_context): Update.
6794         (insert_into_type_stack, insert_type, push_type, push_type_int)
6795         (insert_type_address_space, pop_type, pop_type_int)
6796         (pop_typelist, pop_type_stack, append_type_stack)
6797         (push_type_stack, get_type_stack, push_typelist)
6798         (follow_type_instance_flags, follow_types): Remove (moved to
6799         type-stack.c).
6800         * f-exp.y (type_stack): New global.
6801         Update rules.
6802         (push_kind_type, f_parse): Update.
6803         * d-exp.y (type_stack): New global.
6804         Update rules.
6805         (d_parse): Update.
6806         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6807         Update rules.
6808         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6809         (HFILES_NO_SRCDIR): Add type-stack.h.
6810
6811 2019-04-04  Tom Tromey  <tom@tromey.com>
6812
6813         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6814         (rust_parser::convert_ast_to_expression, rust_parse)
6815         (rust_lex_test_completion, rust_lex_tests): Update.
6816         * parser-defs.h (struct expr_completion_state): New.
6817         (struct parser_state) <parser_state>: Add completion parameter.
6818         <mark_struct_expression, mark_completion_tag>: New methods.
6819         <parse_completion, m_completion_state>: New members.
6820         (prefixify_expression, null_post_parser): Update.
6821         (mark_struct_expression, mark_completion_tag): Don't declare.
6822         * parse.c (parse_completion, expout_last_struct)
6823         (expout_tag_completion_type, expout_completion_name): Remove
6824         globals.
6825         (parser_state::mark_struct_expression)
6826         (parser_state::mark_completion_tag): Now methods.
6827         (prefixify_expression): Add last_struct parameter.
6828         (prefixify_subexp): Likewise.
6829         (parse_exp_1): Update.
6830         (parse_exp_in_context): Add cstate parameter.  Update.
6831         (parse_expression_for_completion): Create an
6832         expr_completion_state.
6833         (null_post_parser): Add "completion" parameter.
6834         * p-exp.y: Update rules.
6835         (yylex): Update.
6836         * language.h (struct language_defn) <la_post_parser>: Add
6837         "completing" parameter.
6838         * go-exp.y: Update rules.
6839         (lex_one_token): Update.
6840         * expression.h (parse_completion): Don't declare.
6841         * d-exp.y: Update rules.
6842         (lex_one_token): Update rules.
6843         * c-exp.y: Update rules.
6844         (lex_one_token): Update.
6845         * ada-lang.c (resolve): Add "parse_completion" parameter.
6846         (resolve_subexp): Likewise.
6847         (ada_resolve_function): Likewise.
6848
6849 2019-04-04  Tom Tromey  <tom@tromey.com>
6850
6851         * parser-defs.h (struct parser_state) <start_arglist,
6852         end_arglist>: New methods.
6853         <arglist_len, m_funcall_chain>: New members.
6854         (arglist_len, start_arglist, end_arglist): Don't declare.
6855         * parse.c (arglist_len, funcall_chain): Remove global.
6856         (start_arglist, end_arglist): Remove functions.
6857         (parse_exp_in_context): Update.
6858         * p-exp.y: Update rules.
6859         * m2-exp.y: Update rules.
6860         * go-exp.y: Update rules.
6861         * f-exp.y: Update rules.
6862         * d-exp.y: Update rules.
6863         * c-exp.y: Update rules.
6864
6865 2019-04-04  Tom Tromey  <tom@tromey.com>
6866
6867         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6868         lex_operator, push_back>: New methods.
6869         Update all rules.
6870         (rust_parser::lex_hex, lex_escape): Rename and update.
6871         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6872         (rust_parser::lex_operator): Rename and update.
6873         (rust_parser::lex_number, rustyylex, rustyyerror)
6874         (rust_lex_test_init, rust_lex_test_sequence)
6875         (rust_lex_test_push_back, rust_lex_tests): Update.
6876         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6877         parameter.
6878         <lexptr, prev_lexptr>: New members.
6879         (lexptr, prev_lexptr): Don't declare.
6880         * parse.c (lexptr, prev_lexptr): Remove globals.
6881         (parse_exp_in_context): Update.
6882         * p-exp.y (yylex, yyerror): Update.
6883         * m2-exp.y (parse_number, yylex, yyerror): Update.
6884         * go-exp.y (lex_one_token, yyerror): Update.
6885         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6886         * d-exp.y (lex_one_token, yyerror): Update.
6887         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6888         (lex_one_token, yyerror): Update.
6889         * ada-lex.l (YY_INPUT): Update.
6890         (rewind_to_char): Update.
6891         * ada-exp.y (yyerror): Update.
6892
6893 2019-04-04  Tom Tromey  <tom@tromey.com>
6894
6895         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6896         * parser-defs.h (struct parser_state) <parser_state>: Add new
6897         parameter.
6898         <comma_terminates>: New member.
6899         (comma_terminates): Don't declare global.
6900         * parse.c (comma_terminates): Remove global.
6901         (parse_exp_in_context): Update.
6902         * p-exp.y (yylex): Update.
6903         * m2-exp.y (yylex): Update.
6904         * go-exp.y (lex_one_token): Update.
6905         * f-exp.y (yylex): Update.
6906         * d-exp.y (lex_one_token): Update.
6907         * c-exp.y (lex_one_token): Update.
6908         * ada-lex.l: Update.
6909
6910 2019-04-04  Tom Tromey  <tom@tromey.com>
6911
6912         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6913         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6914         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6915         * parser-defs.h (paren_depth): Don't declare.
6916         * parse.c (paren_depth): Remove global.
6917         (parse_exp_in_context): Update.
6918         * p-exp.y (paren_depth): New global.
6919         (pascal_parse): Initialize it.
6920         * m2-exp.y (paren_depth): New global.
6921         (m2_parse): Initialize it.
6922         * go-exp.y (paren_depth): New global.
6923         (go_parse): Initialize it.
6924         * f-exp.y (paren_depth): New global.
6925         (f_parse): Initialize it.
6926         * d-exp.y (paren_depth): New global.
6927         (d_parse): Initialize it.
6928         * c-exp.y (paren_depth): New global.
6929         (c_parse): Initialize it.
6930         * ada-lex.l (paren_depth): New global.
6931         (lexer_init): Initialize it.
6932
6933 2019-04-04  Tom Tromey  <tom@tromey.com>
6934
6935         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6936         (rust_parser::convert_ast_to_type)
6937         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6938         * parser-defs.h (struct parser_state) <parser_state>: Add
6939         parameters.  Initialize new members.
6940         <expression_context_block, expression_context_pc>: New members.
6941         * parse.c (expression_context_block, expression_context_pc):
6942         Remove globals.
6943         (parse_exp_in_context): Update.
6944         * p-exp.y: Update all rules.
6945         (yylex): Update.
6946         * m2-exp.y: Update all rules.
6947         (yylex): Update.
6948         * go-exp.y (yylex): Update.
6949         * f-exp.y (yylex): Update.
6950         * d-exp.y: Update all rules.
6951         (yylex): Update.
6952         * c-exp.y: Update all rules.
6953         (lex_one_token, classify_name, yylex, c_parse): Update.
6954         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6955
6956 2019-04-04  Tom Tromey  <tom@tromey.com>
6957
6958         * gdbarch.h, gdbarch.c: Rebuild.
6959         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6960         * stap-probe.h:
6961         (struct stap_parse_info): Replace "parser_state" with
6962         "expr_builder".
6963         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6964         (parser_state): New class.
6965         * parse.c (expr_builder): Rename.
6966         (expr_builder::release): Rename.
6967         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6968         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6969         (write_exp_elt_longcst, write_exp_elt_floatcst)
6970         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6971         (write_exp_string_vector, write_exp_bitstring)
6972         (write_exp_msymbol, mark_struct_expression)
6973         (write_dollar_variable)
6974         (insert_type_address_space, increase_expout_size): Replace
6975         "parser_state" with "expr_builder".
6976         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6977         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6978         "parser_state" with "expr_builder".
6979
6980 2019-04-04  Tom Tromey  <tom@tromey.com>
6981
6982         * rust-exp.y: Replace "parse_language" with method call.
6983         * p-exp.y:
6984         (yylex): Replace "parse_language" with method call.
6985         * m2-exp.y:
6986         (yylex): Replace "parse_language" with method call.
6987         * go-exp.y (classify_name): Replace "parse_language" with method
6988         call.
6989         * f-exp.y (yylex): Replace "parse_language" with method call.
6990         * d-exp.y (lex_one_token): Replace "parse_language" with method
6991         call.
6992         * c-exp.y:
6993         (lex_one_token, classify_name, yylex): Replace "parse_language"
6994         with method call.
6995         * ada-exp.y (find_primitive_type, type_char)
6996         (type_system_address): Replace "parse_language" with method call.
6997
6998 2019-04-04  Tom Tromey  <tom@tromey.com>
6999
7000         * rust-exp.y: Replace "parse_gdbarch" with method call.
7001         * parse.c (write_dollar_variable, insert_type_address_space):
7002         Replace "parse_gdbarch" with method call.
7003         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7004         call.
7005         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7006         call.
7007         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7008         "parse_gdbarch" with method call.
7009         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7010         with method call.
7011         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7012         "parse_gdbarch" with method call.
7013         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7014         "parse_gdbarch" with method call.
7015         * c-exp.y (parse_type, parse_number, classify_name): Replace
7016         "parse_gdbarch" with method call.
7017         * ada-lex.l: Replace "parse_gdbarch" with method call.
7018         * ada-exp.y (parse_type, find_primitive_type, type_char)
7019         (type_system_address): Replace "parse_gdbarch" with method call.
7020
7021 2019-04-04  Tom Tromey  <tom@tromey.com>
7022
7023         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7024         * stap-probe.c (stap_parse_argument): Update.
7025         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7026         initial_size parameter.
7027         * rust-exp.y (rust_lex_tests): Update.
7028         * parse.c (parser_state): Update.
7029         (parse_exp_in_context): Update.
7030         * parser-defs.h (struct parser_state) <parser_state>: Remove
7031         "initial_size" parameter.
7032
7033 2019-04-04  Tom Tromey  <tom@tromey.com>
7034
7035         * parser-defs.h (increase_expout_size): Don't declare.
7036         * parse.c (increase_expout_size): Now static.
7037
7038 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7039
7040         * gnu-nat.c (gnu_nat_target::wait): Fix
7041         target_waitstatus_to_string call.
7042
7043 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7044
7045         * eval.c (evaluate_subexp_standard): Handle internal functions
7046         during Fortran function call handling.
7047
7048 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7049
7050         * NEWS: Mention new internal functions.
7051         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7052         (read_base_type): Use dwarf2_init_complex_target_type.
7053         * value.c (creal_internal_fn): New function.
7054         (cimag_internal_fn): New function.
7055         (_initialize_values): Register new internal functions.
7056
7057 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7058
7059         * infrun.c (stop_all_threads): If debug_infrun, always
7060         trace the wait status after wait_one, using
7061         target_waitstatus_to_string and target_pid_to_str.
7062         (handle_inferior_event): Replace various trace of
7063         wait status kind by a single trace.
7064         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7065         wait status kind image by target_waitstatus_to_string.
7066         * target/waitstatus.c (target_waitstatus_to_string): Fix
7067         obsolete comment.
7068
7069 2019-04-01  Tom Tromey  <tromey@adacore.com>
7070
7071         PR symtab/23331:
7072         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7073
7074 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7075             Pedro Alves  <palves@redhat.com>
7076
7077         * top.c (quit_force): Call 'finalize_values'.
7078         * value.c (finalize_values): New function.
7079         * value.h (finalize_values): Declare.
7080
7081 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7082
7083         * NEWS: Announce $_gdb_major and $_gdb_minor.
7084
7085         * top.c (init_gdb_version_vars): New function.
7086         (gdb_init): Call init_gdb_version_vars.
7087
7088 2019-03-29  Tom Tromey  <tromey@adacore.com>
7089
7090         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7091         help text.  Remove dead code.
7092
7093 2019-03-29  Keith Seitz  <keiths@redhat.com>
7094
7095         From Siddhesh Poyarekar:
7096         * f-lang.h (f77_get_upperbound): Return LONGEST.
7097         (f77_get_lowerbound): Likewise.
7098         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7099         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7100         print them.
7101         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7102         plongest to format print it.
7103         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7104         (f77_get_upperbound): Likewise.
7105         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7106         LOWER_BOUND to LONGEST.
7107         (f77_create_arrayprint_offset_tbl): Likewise.
7108
7109 2019-03-29  Keith Seitz  <keiths@redhat.com>
7110
7111         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7112         %s/pulongest for TYPE_LENGTH instead of %d in format
7113         strings.
7114         * ada-typerint.c (ada_print_type): Likewise.
7115         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7116         * compile/compile-c-support.c (generate_register_struct): Likewise.
7117         * gdbtypes.c (recursive_dump_type): Likewise.
7118         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7119         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7120         instead of %d in format strings.
7121         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7122         to std::min to ULONGEST.
7123         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7124         instead of %d in format strings.
7125         * tracepoint.c (info_scope_command): Likewise.
7126         * typeprint.c (print_offset_data::update)
7127         (print_offset_data::finish): Likewise.
7128         * xtensa-tdep.c (xtensa_store_return_value)
7129         (xtensa_push_dummy_call): Likewise.
7130
7131 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7132
7133         * windows-nat.c (display_selector): Fixed format specifications
7134         for 64-bit Cygwin.
7135
7136 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7137
7138         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7139
7140 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7141
7142         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7143         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7144         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7145         (nios2_linux_init_abi): Install it.
7146
7147 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7148
7149         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7150
7151 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7152
7153         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7154
7155 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7156             Tom Tromey  <tromey@adacore.com>
7157
7158         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7159
7160 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7161
7162         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7163         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7164         method to compute the bounds of range types. Also print "[evaluated]"
7165         if the bounds' values come from a dynamic evaluation.
7166
7167 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7168
7169         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7170         whitespace when pretty printing is on.
7171
7172 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7173
7174         * ppc-linux-nat.c: Add include.
7175
7176 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7177
7178         * NEWS: Mention AArch64 Pointer Authentication.
7179
7180 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7181
7182         * arm-linux-nat.c: Add include.
7183
7184 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7185
7186         * source-cache.c (source_cache::get_source_lines): Re-read
7187         fullname after calling open_source_file.
7188
7189 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7190
7191         * NEWS: Mention TLS support for FreeBSD.
7192
7193 2019-03-25  Tom Tromey  <tromey@adacore.com>
7194
7195         * minsyms.c (BUNCH_SIZE): Update comment.
7196         (~minimal_symbol_reader): Remove old comment.
7197         (compact_minimal_symbols): Update comment.
7198         (minimal_symbol_reader::install): Remove old comment.  Update
7199         other comments.
7200
7201 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7202
7203         * s390-linux-nat.c: Add include.
7204
7205 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7206
7207         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7208         Call linux_get_hwcap.
7209         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7210         Likewise.
7211         (aarch64_linux_get_hwcap): Remove function.
7212         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7213         declaration.
7214         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7215         linux_get_hwcap.
7216         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7217         * linux-tdep.c (linux_get_hwcap): Add function.
7218         (linux_get_hwcap2): Likewise.
7219         * linux-tdep.h (linux_get_hwcap): Add declaration.
7220         (linux_get_hwcap2): Likewise.
7221         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7222         (ppc_linux_get_hwcap2): Likewise.
7223         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7224         linux_get_hwcap.
7225         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7226         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7227         (ppc_linux_nat_target::read_description): Likewise.
7228         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7229         * s390-linux-nat.c: Likewise.
7230         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7231
7232 2019-03-24  Tom Tromey  <tom@tromey.com>
7233
7234         * ada-lang.c (standard_lookup): Simplify initialization.
7235         (ada_lookup_symbol_nonlocal): Simplify return.
7236         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7237         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7238         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7239         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7240         initialization.
7241         * solib.c (solib_global_lookup): Simplify.
7242         * symtab.c (null_block_symbol): Remove.
7243         (symbol_cache_lookup): Simplify returns.
7244         (lookup_language_this): Simplify returns.
7245         (lookup_symbol_aux): Simplify return.
7246         (lookup_local_symbol): Simplify returns.
7247         (lookup_global_symbol_from_objfile): Simplify return.
7248         (lookup_symbol_in_objfile_symtabs)
7249         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7250         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7251         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7252         * cp-namespace.c (cp_lookup_bare_symbol)
7253         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7254         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7255         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7256         (cp_lookup_symbol_via_imports): Simplify initialization.
7257         (find_symbol_in_baseclass): Likewise.
7258         * symtab.h (null_block_symbol): Remove.
7259         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7260         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7261         (d_lookup_symbol_module): Likewise.
7262         (find_symbol_in_baseclass): Simplify initialization.
7263
7264 2019-03-24  Tom Tromey  <tom@tromey.com>
7265
7266         * expression.h: Don't include symtab.h.
7267         (struct block): Forward declare.
7268
7269 2019-03-24  Tom Tromey  <tom@tromey.com>
7270
7271         * c-exp.y (typebase): Remove casts.
7272         * gdbtypes.c (lookup_unsigned_typename, )
7273         (lookup_signed_typename): Remove cast.
7274         * eval.c (parse_to_comma_and_eval): Remove cast.
7275         * parse.c (write_dollar_variable): Remove cast.
7276         * block.h (struct block) <superblock>: Now const.
7277         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7278         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7279         (map_block): Make "block" const.
7280         * symfile.h (struct quick_symbol_functions)
7281         <map_matching_symbols>: Constify block argument to "callback".
7282         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7283         const.
7284         (find_pc_sect_compunit_symtab): Make "b" const.
7285         (find_symbol_at_address): Likewise.
7286         (search_symbols): Likewise.
7287         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7288         (dw2_debug_names_lookup_symbol): Likewise.
7289         (dw2_map_matching_symbols): Update.
7290         * p-valprint.c (pascal_val_print): Remove "block".
7291         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7292         (aux_add_nonlocal_symbols): Make "block" const.
7293         (resolve_subexp): Remove cast.
7294         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7295         const.
7296         (iterate_over_file_blocks): Likewise.
7297         * f-exp.y (%union) <bval>: Remove.
7298         * coffread.c (patch_opaque_types): Make "b" const.
7299         * spu-tdep.c (spu_catch_start): Make "block" const.
7300         * c-valprint.c (print_unpacked_pointer): Remove "block".
7301         * symmisc.c (dump_symtab_1): Make "b" const.
7302         (block_depth): Make "block" const.
7303         * d-exp.y (%union) <bval>: Remove.
7304         * cp-support.h (cp_lookup_rtti_type): Update.
7305         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7306         * psymtab.c (psym_lookup_symbol): Make "block" const.
7307         (maintenance_check_psymtabs): Make "b" const.
7308         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7309         (enumerate_locals, enumerate_args): Update.
7310         * python/py-symtab.c (stpy_global_block): Make "block" const.
7311         (stpy_static_block): Likewise.
7312         * inline-frame.c (block_starting_point_at): Make "new_block"
7313         const.
7314         * block.c (find_block_in_blockvector): Make return type const.
7315         (blockvector_for_pc_sect): Make "b" const.
7316         (find_block_in_blockvector): Make "b" const.
7317
7318 2019-03-23  Tom Tromey  <tom@tromey.com>
7319
7320         * varobj.c (varobj_create): Update.
7321         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7322         * printcmd.c (display_command, do_one_display): Don't reset
7323         innermost_block.
7324         * parser-defs.h (enum innermost_block_tracker_type): Move to
7325         expression.h.
7326         (innermost_block): Update comment.
7327         * parse.c (parse_exp_1): Add tracker_types parameter.
7328         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7329         tracker_types parameter.  Reset innermost_block.
7330         (parse_exp_in_context): Remove.
7331         (parse_expression_for_completion): Update.
7332         * objfiles.c (~objfile): Don't reset expression_context_block or
7333         innermost_block.
7334         * expression.h (enum innermost_block_tracker_type): Move from
7335         parser-defs.h.
7336         (parse_exp_1): Add tracker_types parameter.
7337         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7338         reset innermost_block.
7339
7340 2019-03-23  Tom Tromey  <tom@tromey.com>
7341
7342         * objfiles.h: Include bcache.h.
7343
7344 2019-03-23  Tom Tromey  <tom@tromey.com>
7345
7346         * linespec.c (get_current_search_block): Use
7347         scoped_restore_current_language.
7348         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7349
7350 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7351             Jiong Wang  <jiong.wang@arm.com>
7352
7353         * aarch64-linux-tdep.c
7354         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7355         section.
7356         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7357
7358 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7359             Jiong Wang  <jiong.wang@arm.com>
7360
7361         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7362         instructions.
7363         (aarch64_analyze_prologue_test): Add PACIASP test.
7364         (aarch64_prologue_prev_register): Unmask PC value.
7365
7366 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7367             Jiong Wang  <jiong.wang@arm.com>
7368
7369         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7370         (aarch64_dwarf2_prev_register): Unmask PC value.
7371         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7372         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7373         DW_CFA_AARCH64_negate_ra_state.
7374         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7375
7376 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7377             Jiong Wang  <jiong.wang@arm.com>
7378
7379         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7380         registers.
7381         (aarch64_pseudo_register_name): Likewise.
7382         (aarch64_pseudo_register_type): Likewise.
7383         (aarch64_pseudo_register_reggroup_p): Likewise.
7384         (aarch64_gdbarch_init): Add pauth registers.
7385         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7386         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7387         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7388         (struct gdbarch_tdep): Add regnum for ra_state.
7389
7390 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7391             Jiong Wang  <jiong.wang@arm.com>
7392
7393         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7394
7395 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7396             Jiong Wang  <jiong.wang@arm.com>
7397
7398         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7399         function.
7400         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7401         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7402         (aarch64_gdbarch_init): Add puth registers.
7403         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7404         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7405         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7406
7407 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7408             Jiong Wang  <jiong.wang@arm.com>
7409
7410         * aarch64-linux-nat.c
7411         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7412         * aarch64-linux-tdep.c
7413         (aarch64_linux_core_read_description): Likewise.
7414         (aarch64_linux_get_hwcap): New function.
7415         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7416         (aarch64_linux_get_hwcap): New declaration.
7417
7418 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7419             Jiong Wang  <jiong.wang@arm.com>
7420
7421         * aarch64-linux-nat.c
7422         (aarch64_linux_nat_target::read_description): Add pauth param.
7423         * aarch64-linux-tdep.c
7424         (aarch64_linux_core_read_description): Likewise.
7425         * aarch64-tdep.c (struct target_desc): Add in pauth.
7426         (aarch64_read_description): Add pauth param.
7427         (aarch64_gdbarch_init): Likewise.
7428         * aarch64-tdep.h (aarch64_read_description): Likewise.
7429         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7430         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7431         * features/Makefile: Add new files.
7432         * features/aarch64-pauth.c: New file.
7433         * features/aarch64-pauth.xml: New file.
7434
7435 2019-03-20  Tom Tromey  <tromey@adacore.com>
7436
7437         * infrun.c (handle_inferior_event): Rename from
7438         handle_inferior_event_1.  Create a scoped_value_mark.
7439         (handle_inferior_event): Remove.
7440
7441 2019-03-19  Tom Tromey  <tromey@adacore.com>
7442
7443         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7444         * infrun.h (print_stop_event): Add "displays" parameter.
7445         * infrun.c (print_stop_event): Add "displays" parameter.
7446
7447 2019-03-19  Pedro Alves  <palves@redhat.com>
7448
7449         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7450         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7451         to -1.  Fix TABs vs spaces.
7452         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7453         * tui/tui-out.h (tui_ui_out) Add intro comments.
7454         <m_line, m_start_of_line>: In-class initialize, and add describing
7455         comment.
7456
7457 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7458
7459         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7460         variable names.
7461         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7462
7463 2019-03-18  Pedro Alves  <palves@redhat.com>
7464             Eli Zaretskii <eliz@gnu.org>
7465
7466         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7467         m_line and m_start_of_line.
7468
7469 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7470
7471         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7472         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7473         it returns a newline.  This fixes a regression in TU mode, whereby
7474         the next line is output on the same screen line as the user input.
7475
7476 2019-03-18  Tom Tromey  <tromey@adacore.com>
7477
7478         * minsyms.c (minimal_symbol_reader::install): Remove call to
7479         obstack_blank.
7480
7481 2019-03-18  Pedro Alves  <palves@redhat.com>
7482
7483         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7484         New globals.
7485         (apply_style): New, factored out from ...
7486         (apply_ansi_escape): ... this.  Handle reverse video mode.
7487         (tui_set_reverse_mode): New function.
7488         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7489         * tui/tui-winsource.c (tui_show_source_line): Use
7490         tui_set_reverse_mode instead of setting A_STANDOUT.
7491         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7492         New setter methods.
7493
7494 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7495
7496         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7497         Handle tabs.
7498
7499 2019-03-18  Tom Tromey  <tromey@adacore.com>
7500
7501         * ada-lang.c (empty_array): Add "high" parameter.
7502         (ada_evaluate_subexp): Update.
7503
7504 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7505
7506         * unittests/string_view-selftests.c: Define
7507         _initialize_string_view_selftests unconditionally.
7508
7509 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7510
7511         PR gdb/24350
7512         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7513
7514 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7515
7516         PR gdb/24351
7517         * windows-nat.c (display_selector): Fix format specifiers.
7518
7519 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7520
7521         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7522         tui_refill_source_window instead of tui_refresh_win, to update the
7523         current execution line.  This fixes redisplay of the current line
7524         when stepping through the code with "next" or "step".
7525
7526 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7527
7528         * source-cache.c (source_cache::get_source_lines): Call
7529         find_source_lines to initialize s->nlines.  This fixes vertical
7530         scrolling of TUI source window when the DOWN arrow is pressed.
7531
7532 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7533
7534         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7535         linux-thread-db.c (_initialize_thread_db): Likewise.
7536
7537 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7538
7539         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7540         wclrtoeol in tui_show_source_line".  This reverts changes made in
7541         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7542
7543 2019-03-15  Tom Tromey  <tom@tromey.com>
7544
7545         * symtab.h (struct minimal_symbol): Derive from
7546         general_symbol_info.
7547         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7548         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7549         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7550         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7551         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7552         (MSYMBOL_SEARCH_NAME): Update.
7553         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7554         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7555         * minsyms.c (minimal_symbol_reader::record_full): Update.
7556
7557 2019-03-15  Tom Tromey  <tom@tromey.com>
7558
7559         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7560
7561 2019-03-15  Tom Tromey  <tom@tromey.com>
7562
7563         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7564         unique_xmalloc_ptr.
7565         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7566         Update.
7567         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7568         (build_minimal_symbol_hash_tables)
7569         (minimal_symbol_reader::install): Update.
7570
7571 2019-03-15  Tom Tromey  <tom@tromey.com>
7572
7573         * symtab.c (create_demangled_names_hash): Update.
7574         (symbol_set_names): Update.
7575         * objfiles.h (struct objfile_per_bfd_storage)
7576         <demangled_names_hash>: Now an htab_up.
7577         * objfiles.c (objfile_per_bfd_storage): Simplify.
7578
7579 2019-03-15  Tom Tromey  <tom@tromey.com>
7580
7581         * objfiles.h (struct objfile_per_bfd_storage): Declare
7582         destructor.
7583         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7584         New.
7585         (get_objfile_bfd_data): Use new.  Don't initialize
7586         language_of_main.
7587         (free_objfile_per_bfd_storage): Remove.
7588         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7589
7590 2019-03-15  Tom Tromey  <tom@tromey.com>
7591
7592         * symfile.c (reread_symbols): Update.
7593         * objfiles.c (objfile::objfile): Update.
7594         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7595         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7596         comment.
7597         (minimal_symbol_reader::install): Update.
7598         (terminate_minimal_symbol_table): Remove.
7599         * jit.c (jit_object_close_impl): Update.
7600
7601 2019-03-15  Tom Tromey  <tom@tromey.com>
7602
7603         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7604         initializations.
7605
7606 2019-03-15  Tom Tromey  <tom@tromey.com>
7607
7608         * objfiles.h (struct objfile_per_bfd_storage)
7609         <demangled_hash_languages>: Now a bitset.
7610         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7611         (lookup_minimal_symbol): Update.
7612
7613 2019-03-15  Tom Tromey  <tom@tromey.com>
7614
7615         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7616         Don't return the symbol.
7617         * coffread.c (record_minimal_symbol): Use record_full.
7618
7619 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7620
7621         The MS-Windows port of ncurses fails to switch to a color pair if
7622         one or both of the colors are the implicit default colors.  This
7623         change records the default colors when TUI is initialized, and
7624         then specifies them explicitly when a color pair uses the default
7625         colors.  This allows color styling in TUI mode on MS-Windows.
7626
7627         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7628         ncurses_norm_attr.
7629         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7630         colors in ncurses_norm_attr.
7631         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7632         "none", replace it with the default color recorded in
7633         ncurses_norm_attr.
7634
7635 2019-03-14  Tom Tromey  <tromey@adacore.com>
7636
7637         * source-cache.h (class source_cache) <get_source_lines>: Return
7638         std::string.
7639         * source-cache.c (source_cache::extract_lines): Handle case where
7640         first_pos==npos.  Return std::string.
7641         (source_cache::get_source_lines): Update.
7642
7643 2019-03-14  Tom Tromey  <tromey@adacore.com>
7644
7645         * NEWS: Add item for "style sources" commands.
7646         * source-cache.c (source_cache::get_source_lines): Check
7647         source_styling.
7648         * cli/cli-style.c (source_styling): New global.
7649         (_initialize_cli_style): Add "style sources" commands.
7650         (show_style_sources): New function.
7651         * cli/cli-style.h (source_styling): Declare.
7652
7653 2019-03-14  Pedro Alves  <palves@redhat.com>
7654             Tom Tromey  <tromey@adacore.com>
7655
7656         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7657         * tui/tui-winsource.c (tui_refill_source_window): New function,
7658         from...
7659         (tui_horizontal_source_scroll): ... here.  Move some logic.
7660         * cli/cli-style.c (set_style_enabled): Notify new observable.
7661         * tui/tui-hooks.c (tui_redisplay_source): New function.
7662         (tui_attach_detach_observers): Attach or detach
7663         tui_redisplay_source.
7664         * observable.h (source_styling_changed): New observable.
7665         * observable.c: Define source_styling_changed observable.
7666
7667 2019-03-13  Tom Tromey  <tromey@adacore.com>
7668
7669         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7670         (i386_gnu_nat_target::store_registers): Update.
7671         * target-debug.h (target_debug_print_std_string): New macro.
7672         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7673         * windows-tdep.c (display_one_tib): Update.
7674         * tui/tui-stack.c (tui_make_status_line): Update.
7675         * top.c (print_inferior_quit_action): Update.
7676         * thread.c (thr_try_catch_cmd): Update.
7677         (add_thread_with_info): Update.
7678         (thread_target_id_str): Update.
7679         (thr_try_catch_cmd): Update.
7680         (thread_command): Update.
7681         (thread_find_command): Update.
7682         * record-btrace.c (record_btrace_target::info_record)
7683         (record_btrace_resume_thread, record_btrace_target::resume)
7684         (record_btrace_cancel_resume, record_btrace_step_thread)
7685         (record_btrace_target::wait, record_btrace_target::wait)
7686         (record_btrace_target::wait, record_btrace_target::stop): Update.
7687         * progspace.c (print_program_space): Update.
7688         * process-stratum-target.c
7689         (process_stratum_target::thread_address_space): Update.
7690         * linux-fork.c (linux_fork_mourn_inferior)
7691         (detach_checkpoint_command, info_checkpoints_command)
7692         (linux_fork_context): Update.
7693         (linux_fork_detach): Update.
7694         (class scoped_switch_fork_info): Update.
7695         (delete_checkpoint_command): Update.
7696         * infrun.c (follow_fork_inferior): Update.
7697         (follow_fork_inferior): Update.
7698         (proceed_after_vfork_done): Update.
7699         (handle_vfork_child_exec_or_exit): Update.
7700         (follow_exec): Update.
7701         (displaced_step_prepare_throw): Update.
7702         (displaced_step_restore): Update.
7703         (start_step_over): Update.
7704         (resume_1): Update.
7705         (clear_proceed_status_thread): Update.
7706         (proceed): Update.
7707         (print_target_wait_results): Update.
7708         (do_target_wait): Update.
7709         (context_switch): Update.
7710         (stop_all_threads): Update.
7711         (restart_threads): Update.
7712         (finish_step_over): Update.
7713         (handle_signal_stop): Update.
7714         (switch_back_to_stepped_thread): Update.
7715         (keep_going_pass_signal): Update.
7716         (print_exited_reason): Update.
7717         (normal_stop): Update.
7718         * inferior.c (inferior_pid_to_str): Change return type.
7719         (print_selected_inferior): Update.
7720         (add_inferior): Update.
7721         (detach_inferior): Update.
7722         * dummy-frame.c (fprint_dummy_frames): Update.
7723         * dcache.c (dcache_info_1): Update.
7724         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7725         (btrace_fetch, btrace_clear): Update.
7726         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7727         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7728         type.
7729         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7730         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7731         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7732         * gdbarch.c, gdbarch.h: Rebuild.
7733         * gdbarch.sh (core_pid_to_str): Change return type.
7734         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7735         return type.
7736         (windows_nat_target::pid_to_str): Change return type.
7737         (windows_delete_thread): Update.
7738         (windows_nat_target::attach): Update.
7739         (windows_nat_target::files_info): Update.
7740         * target-delegates.c: Rebuild.
7741         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7742         return type.
7743         (sol_thread_target::pid_to_str): Change return type.
7744         * remote.c (class remote_target) <pid_to_str>: Change return
7745         type.
7746         (remote_target::pid_to_str): Change return type.
7747         (extended_remote_target::attach, remote_target::remote_stop_ns)
7748         (remote_target::remote_notif_remove_queued_reply)
7749         (remote_target::push_stop_reply, remote_target::disable_btrace):
7750         Update.
7751         (extended_remote_target::attach): Update.
7752         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7753         type.
7754         (gdbsim_target::pid_to_str): Change return type.
7755         * ravenscar-thread.c (struct ravenscar_thread_target)
7756         <pid_to_str>: Change return type.
7757         (ravenscar_thread_target::pid_to_str): Change return type.
7758         * procfs.c (class procfs_target) <pid_to_str>: Change return
7759         type.
7760         (procfs_target::pid_to_str): Change return type.
7761         (procfs_target::attach): Update.
7762         (procfs_target::detach): Update.
7763         (procfs_target::fetch_registers): Update.
7764         (procfs_target::store_registers): Update.
7765         (procfs_target::wait): Update.
7766         (procfs_target::files_info): Update.
7767         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7768         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7769         return type.
7770         (nto_procfs_target::pid_to_str): Change return type.
7771         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7772         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7773         return type.
7774         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7775         (exit_lwp): Update.
7776         (attach_proc_task_lwp_callback, get_detach_signal)
7777         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7778         (linux_nat_target::resume, wait_lwp, stop_callback)
7779         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7780         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7781         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7782         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7783         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7784         type.
7785         (inf_ptrace_target::attach): Update.
7786         (inf_ptrace_target::files_info): Update.
7787         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7788         type.
7789         (go32_nat_target::pid_to_str): Change return type.
7790         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7791         (gnu_nat_target::wait): Update.
7792         (gnu_nat_target::wait): Update.
7793         (gnu_nat_target::resume): Update.
7794         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7795         (fbsd_nat_target::wait): Update.
7796         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7797         type.
7798         (darwin_nat_target::attach): Update.
7799         * corelow.c (class core_target) <pid_to_str>: Change return type.
7800         (core_target::pid_to_str): Change return type.
7801         * target.c (normal_pid_to_str): Change return type.
7802         (default_pid_to_str): Likewise.
7803         (target_pid_to_str): Change return type.
7804         (target_translate_tls_address): Update.
7805         (target_announce_detach): Update.
7806         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7807         return type.
7808         (bsd_uthread_target::pid_to_str): Change return type.
7809         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7810         type.
7811         (bsd_kvm_target::pid_to_str): Change return type.
7812         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7813         return type.
7814         (aix_thread_target::pid_to_str): Change return type.
7815         * target.h (struct target_ops) <pid_to_str>: Change return type.
7816         (target_pid_to_str, normal_pid_to_str): Likewise.
7817         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7818         type.
7819         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7820         type.
7821         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7822         return type.
7823         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7824         type.
7825         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7826         type.
7827         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7828         return type.
7829
7830 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7831
7832         * NEWS: Mention that the new default MI version is 3.  Mention
7833         changes to the output of commands and events that deal with
7834         multi-location breakpoints.
7835         * breakpoint.c: Include "mi/mi-out.h".
7836         (print_one_breakpoint): Change output syntax if using MI version
7837         >= 3.
7838         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7839         New.
7840         (mi_multi_location_breakpoint_output_fixed): New.
7841         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7842         (mi_cmd_fix_multi_location_breakpoint_output): New.
7843         (mi_multi_location_breakpoint_output_fixed): New.
7844         * mi/mi-cmds.c (mi_cmds): Register command
7845         -fix-multi-location-breakpoint-output.
7846         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7847         interpreter "mi".
7848
7849 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7850
7851         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7852         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7853         instantiate mi_ui_out based on interpreter name.
7854         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7855         * mi/mi-main.c (mi_load_progress): Likewise.
7856
7857 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7858
7859         * NEWS: Combine separate "New targets" sections for 8.3.
7860
7861 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7862
7863         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7864         (ppcfbsd_init_abi): Install gdbarch
7865         "fetch_tls_load_module_address" and "get_thread_local_address"
7866         methods.
7867
7868 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7869
7870         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7871         (riscv_fbsd_init_abi): Install gdbarch
7872         "fetch_tls_load_module_address" and "get_thread_local_address"
7873         methods.
7874
7875 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7876
7877         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7878         (i386fbsd_init_abi): Install gdbarch
7879         "fetch_tls_load_module_address" and "get_thread_local_address"
7880         methods.
7881
7882 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7883
7884         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7885         (amd64fbsd_init_abi): Install gdbarch
7886         "fetch_tls_load_module_address" and "get_thread_local_address"
7887         methods.
7888
7889 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7890
7891         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7892         (struct fbsd_pspace_data): New type.
7893         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7894         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7895         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7896         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7897         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7898
7899 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7900
7901         * gdbtypes.c (lookup_struct_elt): New function.
7902         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7903         * gdbtypes.h (struct struct_elt): New type.
7904         (lookup_struct_elt): New prototype.
7905
7906 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7907
7908         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7909         remove disabled code block.
7910
7911 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7912
7913         * gdbarch.sh (get_thread_local_address): New method.
7914         * gdbarch.h, gdbarch.c: Regenerate.
7915         * target.c (target_translate_tls_address): Use
7916         gdbarch_get_thread_local_address if present instead of
7917         target::get_thread_local_address.
7918
7919 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7920
7921         * target.h (target::get_thread_local_address): Update comment.
7922
7923 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7924
7925         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7926         objfile->separate_debug_objfile_backlink if not NULL.
7927
7928 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7929
7930         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7931         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7932         (amd64bsd_store_inferior_registers): Likewise.
7933         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7934         Enable segment base registers.
7935         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7936         PT_GETFSBASE and PT_GETGSBASE.
7937         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7938         PT_SETGSBASE.
7939         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7940         segment base registers.
7941         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7942
7943 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7944
7945         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7946         Update calls to i386_target_description to add 'segments'
7947         parameter.
7948         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7949         add segment base registers.
7950         * arch/i386.c (i386_create_target_description): Add 'segments'
7951         parameter to enable segment base registers.
7952         * arch/i386.h (i386_create_target_description): Likewise.
7953         * features/i386/32bit-segments.xml: New file.
7954         * features/i386/32bit-segments.c: Generate.
7955         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7956         call to i386_target_description to add 'segments' parameter.
7957         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7958         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7959         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7960         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7961         if feature is present.
7962         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7963         Add 'segments' parameter to call to i386_target_description.
7964         (i386_target_description): Add 'segments' parameter to enable
7965         segment base registers.
7966         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7967         to call to i386_target_description.
7968         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7969         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7970         Define I386_NUM_REGS.
7971         (i386_target_description): Add 'segments' parameter to enable
7972         segment base registers.
7973
7974 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7975
7976         PR/24325
7977         * source-cache.c: #undef open and close, to avoid unresolved
7978         externals during linking.
7979
7980 2019-03-12  Tom Tromey  <tromey@adacore.com>
7981
7982         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7983         const.  Add initializers.
7984         (_initialize_remote): Don't initialize ptid globals.
7985
7986 2019-03-12  Pedro Alves  <palves@redhat.com>
7987
7988         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7989
7990 2019-03-12  Pedro Alves  <palves@redhat.com>
7991
7992         * cp-name-parser.y (main): Remove unused 'len' variable.
7993
7994 2019-03-12  Tom Tromey  <tromey@adacore.com>
7995
7996         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7997         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7998
7999 2019-03-12  Tom Tromey  <tromey@adacore.com>
8000
8001         * linux-nat.c (iterate_over_lwps): Update.
8002         (stop_callback): Remove parameter.
8003         (stop_wait_callback, detach_callback, resume_set_callback)
8004         (select_singlestep_lwp_callback, set_ignore_sigint)
8005         (status_callback, resumed_callback, resume_clear_callback)
8006         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8007         data parameter.
8008         (linux_nat_target::detach, linux_nat_target::resume)
8009         (linux_stop_and_wait_all_lwps, select_event_lwp)
8010         (linux_nat_filter_event, linux_nat_wait_1)
8011         (linux_nat_target::kill, linux_nat_target::stop)
8012         (linux_nat_target::stop): Update.
8013         (linux_nat_resume_callback): Change type.
8014         (resume_stopped_resumed_lwps, count_events_callback)
8015         (select_event_lwp_callback): Likewise.
8016         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8017         * arm-linux-nat.c (struct update_registers_data): Remove.
8018         (update_registers_callback): Change type.
8019         (arm_linux_insert_hw_breakpoint1): Update.
8020         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8021         parameter.
8022         (x86_linux_dr_set_addr): Update.
8023         (x86_linux_dr_set_control): Update.
8024         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8025         (iterate_over_lwps): Use gdb::function_view.
8026         * nat/aarch64-linux-hw-point.c (struct
8027         aarch64_dr_update_callback_param): Remove.
8028         (debug_reg_change_callback): Change type.
8029         (aarch64_notify_debug_reg_change): Update.
8030         * s390-linux-nat.c (s390_refresh_per_info): Update.
8031
8032 2019-03-11  Tom Tromey  <tromey@adacore.com>
8033
8034         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8035         redundant assignment to "this_cu".
8036
8037 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8038
8039         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8040
8041 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8042
8043         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8044         from...
8045         (rank_one_type): ... this.
8046
8047 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8048
8049         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8050         from...
8051         (rank_one_type): ... this.
8052
8053 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8054
8055         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8056         from...
8057         (rank_one_type): ... this.
8058
8059 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8060
8061         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8062         from...
8063         (rank_one_type): ... this.
8064
8065 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8066
8067         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8068         from...
8069         (rank_one_type): ... this.
8070
8071 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8072
8073         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8074         from...
8075         (rank_one_type): ... this.
8076
8077 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8078
8079         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8080         from...
8081         (rank_one_type): ... this.
8082
8083 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8084
8085         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8086         from...
8087         (rank_one_type): ... this.
8088
8089 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8090
8091         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8092         from...
8093         (rank_one_type): ... this.
8094
8095 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8096
8097         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8098         from...
8099         (rank_one_type): ... this.
8100
8101 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8102
8103         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8104         from...
8105         (rank_one_type): ... this.
8106
8107 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8108
8109         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8110         from...
8111         (rank_one_type): ... this.
8112
8113 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8114
8115         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8116         inferior-events' shows the example events.
8117
8118 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8119
8120         Support styling on native MS-Windows console
8121
8122         PR/24315
8123         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8124         on MS-Windows if $TERM is not defined.
8125
8126         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8127
8128         * posix-hdep.c (gdb_console_fputs):
8129         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8130         functions.
8131         * ui-file.h (gdb_console_fputs): Add prototype.
8132
8133         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8134         back to fputs only if the former returns zero.
8135
8136 2019-03-07  Tom Tromey  <tom@tromey.com>
8137
8138         * symmisc.c (print_symbol_bcache_statistics): Update.
8139         (print_objfile_statistics): Update.
8140         * symfile.c (allocate_symtab): Update.
8141         * stabsread.c: Don't include bcache.h.
8142         * psymtab.h (struct psymbol_bcache): Don't declare.
8143         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8144         (psymbol_bcache_init, psymbol_bcache_free)
8145         (psymbol_bcache_get_bcache): Don't declare.
8146         * psymtab.c (struct psymbol_bcache): Remove.
8147         (psymtab_storage::psymtab_storage): Update.
8148         (psymtab_storage::~psymtab_storage): Update.
8149         (psymbol_bcache_init, psymbol_bcache_free)
8150         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8151         (add_psymbol_to_bcache): Update.
8152         (allocate_psymtab): Update.
8153         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8154         macro_cache>: No longer pointers.
8155         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8156         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8157         * macrotab.c (macro_bcache): Update.
8158         * macroexp.c: Don't include bcache.h.
8159         * gdbtypes.c (check_types_worklist): Update.
8160         (types_deeply_equal): Remove TRY/CATCH.  Update.
8161         * elfread.c (elf_symtab_read): Update.
8162         * dwarf2read.c: Don't include bcache.h.
8163         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8164         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8165         (print_bcache_statistics, bcache_memory_used): Don't declare.
8166         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8167         methods.  Rename all data members.
8168         * bcache.c (struct bcache): Move to bcache.h.
8169         (bcache::expand_hash_table): Rename from expand_hash_table.
8170         (bcache): Remove.
8171         (bcache::insert): Rename from bcache_full.
8172         (bcache::compare): Rename from bcache_compare.
8173         (bcache_xmalloc): Remove.
8174         (bcache::~bcache): Rename from bcache_xfree.
8175         (bcache::print_statistics): Rename from print_bcache_statistics.
8176         (bcache::memory_used): Rename from bcache_memory_used.
8177
8178 2019-03-07  Pedro Alves  <palves@redhat.com>
8179
8180         * infrun.c (normal_stop): Also check for
8181         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8182
8183 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8184
8185         * f-lang.c (value_from_host_double): Moved to...
8186         * value.c (value_from_host_double): ...here.
8187         * value.h (value_from_host_double): Declare.
8188         * guile/scm-math.c (vlscm_convert_typed_number): Use
8189         value_from_host_double.
8190         (vlscm_convert_number): Likewise.
8191         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8192         * python/py-value.c (convert_value_from_python): Likewise.
8193
8194 2019-03-06  Tom Tromey  <tom@tromey.com>
8195
8196         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8197
8198 2019-03-06  Tom Tromey  <tom@tromey.com>
8199
8200         * utils.h (free_current_contents): Don't declare.
8201         * utils.c (free_current_contents): Remove.
8202
8203 2019-03-06  Tom Tromey  <tom@tromey.com>
8204
8205         * top.c (quit_force): Update.
8206         * main.c (captured_command_loop): Update.
8207         * common/new-op.c (operator new): Update.
8208         * common/common-exceptions.c (struct catcher)
8209         <save_cleanup_chain>: Remove member.
8210         (exceptions_state_mc_init): Update.
8211         (exception_try_scope_entry): Return nullptr.
8212         (exception_try_scope_exit, exception_rethrow)
8213         (throw_exception_sjlj, throw_exception_cxx): Update.
8214         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8215         (all_cleanups, do_cleanups, discard_cleanups)
8216         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8217         (restore_cleanups, restore_final_cleanups): Don't declare.
8218         (do_final_cleanups): Remove parameter.
8219         * common/cleanups.c (cleanup_chain, make_cleanup)
8220         (make_cleanup_dtor, all_cleanups, do_cleanups)
8221         (discard_my_cleanups, discard_cleanups)
8222         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8223         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8224         (null_cleanup): Remove.
8225         (do_final_cleanups): Remove parameter.
8226
8227 2019-03-06  Tom Tromey  <tom@tromey.com>
8228
8229         * remote.c (remote_target::remote_parse_stop_reply): Use
8230         unique_xmalloc_ptr.
8231
8232 2019-03-06  Tom Tromey  <tom@tromey.com>
8233
8234         * stabsread.c (struct stabs_field_info): Rename from field_info.
8235         <list, fnlist>: Add initializers.
8236         <obstack>: New member.
8237         (read_member_functions, read_struct_fields, read_baseclasses):
8238         Allocate on obstack.  Don't use cleanups.
8239         (read_one_struct_field, read_member_functions, read_struct_fields)
8240         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8241         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8242         (read_struct_type): Update.
8243
8244 2019-03-06  Tom Tromey  <tom@tromey.com>
8245
8246         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8247         * common/filestuff.h (make_cleanup_close): Don't declare.
8248         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8249         Remove.
8250
8251 2019-03-06  Tom Tromey  <tom@tromey.com>
8252
8253         * solib-aix.c: Use make_scope_exit.
8254
8255 2019-03-06  Tom Tromey  <tom@tromey.com>
8256
8257         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8258         Use make_scope_exit.
8259
8260 2019-03-06  Tom Tromey  <tom@tromey.com>
8261
8262         * solib-svr4.c (disable_probes_interface): Remove parameter.
8263         (svr4_handle_solib_event): Use make_scope_exit.
8264
8265 2019-03-06  Tom Tromey  <tom@tromey.com>
8266
8267         * remote.c (struct stop_reply_deleter): Remove.
8268         (stop_reply_up): Update.
8269         (struct stop_reply): Derive from notif_event.  Don't typedef.
8270         <regcache>: Now a std::vector.
8271         (stop_reply_xfree): Remove.
8272         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8273         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8274         (remote_target::discard_pending_stop_replies): Use delete.
8275         (remote_target::remote_parse_stop_reply): Update.
8276         (remote_target::process_stop_reply): Update.
8277         * remote-notif.h (struct notif_event): Add virtual destructor.
8278         Remove "dtr" member.
8279         (struct notif_client) <alloc_event>: Return a unique_ptr.
8280         (notif_event_xfree): Don't declare.
8281         (notif_event_up): New typedef.
8282         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8283         (notif_event_xfree, do_notif_event_xfree): Remove.
8284         (remote_notif_state_xfree): Update.
8285
8286 2019-03-06  Tom Tromey  <tom@tromey.com>
8287
8288         * infrun.c (displaced_step_clear_cleanup): Now a
8289         forward_scope_exit type.
8290         (displaced_step_prepare_throw): Update.
8291         (displaced_step_fixup): Update.
8292
8293 2019-03-06  Tom Tromey  <tom@tromey.com>
8294
8295         * inferior.h (class inferior): Update comment.
8296         * gdbthread.h (class thread_info): Update comment.
8297
8298 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8299             Tom Tromey  <tom@tromey.com>
8300
8301         * stabsread.h (struct stab_section_list): Remove.
8302         (coffstab_build_psymtabs): Update.
8303         * dbxread.c (symbuf_sections): Now a std::vector.
8304         (sect_idx): New global.
8305         (fill_symbuf): Update.
8306         (coffstab_build_psymtabs): Change type of stabsects parameter.
8307         Update.
8308         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8309         std::vector.
8310         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8311         (coff_locate_sections): Update.
8312         (coff_symfile_read): Remove cleanups.  Update.
8313         (init_stringtab): Add storage parameter.
8314         (free_stringtab, free_stringtab_cleanup): Remove.
8315         (init_lineno): Add storage parameter.
8316         (free_linetab, free_linetab_cleanup): Remove.
8317
8318 2019-03-06  Pedro Alves  <palves@redhat.com>
8319
8320         * linux-fork.c (fork_info::clobber_regs): Delete.
8321         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8322         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8323         comment.  Adjust.
8324         (scoped_switch_fork_info::scoped_switch_fork_info)
8325         (checkpoint_command, linux_fork_context): Adjust
8326         fork_save_infrun_state calls.
8327
8328 2019-03-06  Pedro Alves  <palves@redhat.com>
8329
8330         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8331         (inf_has_multiple_threads): Return 'bool' and rewrite using
8332         inferior_info::threads().
8333
8334 2019-03-06  Pedro Alves  <palves@redhat.com>
8335
8336         * linux-fork.c: Include <list>.
8337         (fork_list): Now a std::list instance.
8338         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8339         (forks_exist_p, find_last_fork): Adjust.
8340         (new_fork): Delete.
8341         (one_fork_p): New.
8342         (add_fork): Adjust.
8343         (free_fork): Delete, folded into fork_info::~fork_info().
8344         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8345         Adjust.
8346         (init_fork_list): Delete.
8347         (linux_fork_killall, linux_fork_mourn_inferior)
8348         (linux_fork_detach, info_checkpoints_command): Adjust.
8349         (_initialize_linux_fork): No longer call init_fork_list.
8350
8351 2019-03-06  Pedro Alves  <palves@redhat.com>
8352
8353         * linux-fork.c (new_fork): New, split out of ...
8354         (add_fork): ... this.  Return void.  Move "first fork" special
8355         case from here, to ...
8356         (checkpoint_command): ... here.
8357         * linux-linux.h (add_fork): Return void.
8358
8359 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8360
8361         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8362
8363 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8364             Chris January  <chris.january@arm.com>
8365             David Lecomber  <david.lecomber@arm.com>
8366
8367         * f-exp.y: New token, UNOP_INTRINSIC.
8368         (exp): New pattern using UNOP_INTRINSIC token.
8369         (f77_keywords): Add 'abs' keyword.
8370         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8371         (value_from_host_double): New function.
8372         (evaluate_subexp_f): Support UNOP_ABS.
8373
8374 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8375
8376         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8377         types.
8378
8379 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8380
8381         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8382         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8383         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8384
8385 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8386
8387         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8388
8389 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8390             Chris January  <chris.january@arm.com>
8391
8392         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8393         * f-exp.y: Define 'KIND' token.
8394         (exp): New pattern for KIND expressions.
8395         (ptype): Handle types with a kind extension.
8396         (direct_abs_decl): Extend to spot kind extensions.
8397         (f77_keywords): Add 'kind' to the list.
8398         (push_kind_type): New function.
8399         (convert_to_kind_type): New function.
8400         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8401         * parse.c (operator_length_standard): Likewise.
8402         * parser-defs.h (enum type_pieces): Add tp_kind.
8403         * std-operator.def: Add UNOP_KIND.
8404
8405 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8406
8407         * f-exp.y (f_parse): Set yydebug.
8408
8409 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8410
8411         * f-lang.c (evaluate_subexp_f): New function.
8412         (exp_descriptor_f): New global.
8413         (f_language_defn): Use exp_descriptor_f instead of
8414         exp_descriptor_standard.
8415
8416 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8417
8418         * f-exp.y (struct token): Add comments.
8419         (dot_ops): Remove uppercase versions and the end marker.
8420         (f77_keywords): Likewise.
8421         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8422         entries in the dot_ops array are case insensitive, and use
8423         strncasecmp to compare strings.  Also some whitespace cleanup in
8424         this area.  Similar for the f77_keywords array, except entries in
8425         this list might be case sensitive.
8426
8427 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8428
8429         * f-exp.y (struct f77_boolean_val): Add comments.
8430         (boolean_values): Remove uppercase versions, and end marker.
8431         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8432         and use strncasecmp to achieve case insensitivity.  Additionally,
8433         perform whitespace cleanup around this code.
8434
8435 2019-03-06  Tom Tromey  <tromey@adacore.com>
8436
8437         * remote-sim.c (gdbsim_target_open): Use result of
8438         gdb_argv::release.
8439
8440 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8441         Dirk Schubert  <dirk.schubert@arm.com>
8442         Chris January  <chris.january@arm.com>
8443
8444         * eval.c (evaluate_subexp_standard): Call Fortran argument
8445         wrapping logic.
8446         * f-lang.c (struct value): A value which can be passed into a
8447         Fortran function call.
8448         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8449         where appropriate.
8450         (struct type): Value ready for a Fortran function call.
8451         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8452         is needed.
8453         * f-lang.h (fortran_argument_convert): Declaration.
8454         (fortran_preserve_arg_pointer): Declaration.
8455         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8456
8457 2019-03-05  Tom Tromey  <tromey@adacore.com>
8458
8459         * python/py-prettyprint.c (print_string_repr): Remove #if.
8460         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8461
8462 2019-03-05  Tom Tromey  <tromey@adacore.com>
8463
8464         * target.c (the_dummy_target): Move later.  Change type to
8465         "dummy_target".
8466         (initialize_targets): Don't initialize the_dummy_target.
8467
8468 2019-03-05  Tom Tromey  <tromey@adacore.com>
8469
8470         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8471         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8472
8473 2019-03-05  Tom Tromey  <tromey@adacore.com>
8474
8475         * windows-nat.c (windows_nat_target::attach)
8476         (windows_nat_target::detach): Don't call gdb_flush.
8477         * valprint.c (generic_val_print, val_print, val_print_string):
8478         Don't call gdb_flush.
8479         * utils.c (defaulted_query): Don't call gdb_flush.
8480         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8481         * target.c (target_announce_detach): Don't call gdb_flush.
8482         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8483         * remote.c (extended_remote_target::attach): Don't call
8484         gdb_flush.
8485         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8486         * printcmd.c (do_examine): Don't call gdb_flush.
8487         (info_display_command): Don't call gdb_flush.
8488         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8489         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8490         * memattr.c (info_mem_command): Don't call gdb_flush.
8491         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8492         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8493         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8494         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8495         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8496         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8497         (gnu_nat_target::detach): Don't call gdb_flush.
8498         * f-valprint.c (f_val_print): Don't call gdb_flush.
8499         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8500         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8501         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8502         gdb_flush.
8503         * c-valprint.c (c_val_print): Don't call gdb_flush.
8504         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8505
8506 2019-03-05  Tom Tromey  <tromey@adacore.com>
8507
8508         * varobj.c (update_dynamic_varobj_children): Update.
8509         (install_default_visualizer): Use reset, not release.
8510         * value.c (set_internalvar): Update.
8511         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8512         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8513         ATTRIBUTE_UNUSED_RESULT.
8514
8515 2019-03-05  Tom Tromey  <tromey@adacore.com>
8516
8517         * remote.c (class scoped_remote_fd) <release>: Add
8518         ATTRIBUTE_UNUSED_RESULT.
8519
8520 2019-03-05  Tom Tromey  <tromey@adacore.com>
8521
8522         * macroexp.c (struct macro_buffer) <release>: Add
8523         ATTRIBUTE_UNUSED_RESULT.
8524
8525 2019-03-05  Tom Tromey  <tromey@adacore.com>
8526
8527         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8528         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8529         ATTRIBUTE_UNUSED_RESULT.
8530
8531 2019-03-05  Tom Tromey  <tromey@adacore.com>
8532
8533         * common/scoped_fd.h (class scoped_fd) <release>: Add
8534         ATTRIBUTE_UNUSED_RESULT.
8535
8536 2019-03-05  Tom Tromey  <tromey@adacore.com>
8537
8538         * parser-defs.h (struct parser_state) <release>: Add
8539         ATTRIBUTE_UNUSED_RESULT.
8540
8541 2019-03-05  Tom Tromey  <tromey@adacore.com>
8542
8543         * utils.h (class gdb_argv) <release>: Add
8544         ATTRIBUTE_UNUSED_RESULT.
8545         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8546
8547 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8548
8549         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8550         for-loop range, to avoid compiler warnings.
8551
8552         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8553         avoid compiler warnings about unused variables.
8554
8555         * NEWS: Mention end of support for native debugging on MS-Windows
8556         before XP.
8557
8558         PR gdb/24292
8559         * common/netstuff.c:
8560         * gdbserver/gdbreplay.c
8561         * gdbserver/remote-utils.c:
8562         * ser-tcp.c:
8563         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8564         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8565         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8566         'getaddrinfo' and 'freeaddrinfo' were not available before
8567         Windows XP, and mingw.org's MinGW headers by default define
8568         _WIN32_WINNT to 0x500.
8569
8570 2019-03-01  Gary Benson <gbenson@redhat.com>
8571
8572         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8573
8574 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8575             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8576
8577         PR gdb/8527
8578         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8579         set_sigint_trap, clear_sigint_trap.
8580
8581 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8582
8583         * target.c (target_detach): Clear the regcache and the
8584         frame cache.
8585
8586 2019-02-27  Pedro Alves  <palves@redhat.com>
8587
8588         * utils.c (set_screen_size): When we cap the height/width sizes,
8589         tweak the corresponding command variable to show "unlimited":
8590
8591 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8592             Pedro Alves  <palves@redhat.com>
8593
8594         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8595         before calling rl_set_screen_size.
8596
8597 2019-02-27  Tom Tromey  <tromey@adacore.com>
8598
8599         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8600         define.
8601         * python/py-value.c: Remove Python 2.4 workaround.
8602         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8603         workaround.
8604         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8605         Python 2.4 workaround.
8606         * python/python-internal.h: Remove Python 2.4 comment.
8607         (Py_ssize_t): Don't define.
8608         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8609         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8610         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8611         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8612         * python/python.c (do_start_initialization): Remove Python 2.4
8613         workaround.
8614         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8615         (print_children): Remove Python 2.4 workaround.
8616         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8617         workaround.
8618         (CHARBUFFERPROC_NAME): Remove.
8619         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8620         Python 2.4 workaround.
8621
8622 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8623
8624         * NEWS: Note minimum Python version.
8625
8626 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8627
8628         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8629         code from these functions.  Remove corresponding ifdefs.  Use
8630         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8631         Remove gotos and target of gotos.
8632         (infpy_search_memory): Likewise.
8633
8634 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8635
8636         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8637         (hppa_gdbarch_init): Don't register deleted functions with
8638         gdbarch.
8639
8640 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8641
8642         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8643         (h8300_unwind_sp): Delete.
8644         (h8300_dummy_id): Delete.
8645         (h8300_gdbarch_init): Don't register deleted functions with
8646         gdbarch.
8647
8648 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8649
8650         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8651         (ft32_unwind_pc): Delete.
8652         (ft32_unwind_sp): Delete.
8653         (ft32_gdbarch_init): Don't register deleted functions with
8654         gdbarch.
8655
8656 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8657
8658         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8659         (frv_unwind_pc): Delete.
8660         (frv_unwind_sp): Delete.
8661         (frv_gdbarch_init): Don't register deleted functions with
8662         gdbarch.
8663
8664 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8665
8666         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8667         (riscv_unwind_pc): Delete.
8668         (riscv_unwind_sp): Delete.
8669         (riscv_gdbarch_init): Don't register deleted functions with
8670         gdbarch.
8671
8672 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8673
8674         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8675         (csky_unwind_pc): Delete.
8676         (csky_unwind_sp): Delete.
8677         (csky_gdbarch_init): Don't register deleted functions with
8678         gdbarch.
8679
8680 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8681
8682         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8683         (cris_unwind_pc): Delete.
8684         (cris_unwind_sp): Delete.
8685         (cris_gdbarch_init): Don't register deleted functions with
8686         gdbarch.
8687
8688 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8689
8690         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8691         (bfin_unwind_pc): Delete.
8692         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8693
8694 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8695
8696         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8697         (arm_unwind_pc): Delete.
8698         (arm_unwind_sp): Delete.
8699         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8700
8701 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8702
8703         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8704         (arc_unwind_pc): Delete.
8705         (arc_unwind_sp): Delete.
8706         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8707
8708 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8709
8710         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8711         (alpha_unwind_pc): Delete.
8712         (alpha_gdbarch_init): Don't register deleted functions with
8713         gdbarch.
8714
8715 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8716
8717         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8718         (aarch64_unwind_pc): Delete.
8719         (aarch64_unwind_sp): Delete.
8720         (aarch64_gdbarch_init): Don't register deleted functions with
8721         gdbarch.
8722
8723 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8724
8725         * gdbtypes.c (type_align): Don't consider static members when
8726         computing structure alignment.
8727
8728 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8729
8730         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8731         return 0 for other types.
8732         * arch-utils.c (default_type_align): Always return 0.
8733         * gdbarch.h: Regenerate.
8734         * gdbarch.sh (type_align): Extend comment.
8735         * gdbtypes.c (type_align): Add additional comments, always call
8736         gdbarch_type_align before applying the default rules.
8737         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8738         generic code will then apply a suitable default.
8739         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8740         types, return 0 for other types.
8741
8742 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8743
8744         * NEWS: Create a new section for the next release branch.
8745         Rename the section of the current branch, now that it has
8746         been cut.
8747
8748 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8749
8750         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8751         * version.in: Bump version to 8.3.50.DATE-git.
8752
8753 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8754
8755         * aix-thread.c (ptid_cmp): Remove unused variable.
8756         (get_signaled_thread): Likewise.
8757         (store_regs_user_thread): Likewise.
8758         (store_regs_kernel_thread): Likewise.
8759         (fetch_regs_kernel_thread): Remove shadowed variable.
8760
8761 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8762
8763         * features/riscv/32bit-cpu.xml: Add register numbers.
8764         * features/riscv/32bit-fpu.c: Regenerate.
8765         * features/riscv/32bit-fpu.xml: Add register numbers.
8766         * features/riscv/64bit-cpu.xml: Add register numbers.
8767         * features/riscv/64bit-fpu.c: Regenerate.
8768         * features/riscv/64bit-fpu.xml: Add register numbers.
8769
8770 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8771
8772         * NEWS: Mention two argument form of gdb.Value constructor.
8773         * python/py-value.c (convert_buffer_and_type_to_value): New
8774         function.
8775         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8776         Add support for handling an optional second argument.  Call
8777         convert_buffer_and_type_to_value as appropriate.
8778         * python/python-internal.h (Py_buffer_deleter): New struct.
8779         (Py_buffer_up): New typedef.
8780
8781 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8782
8783         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8784         instead of releasing ownership.
8785
8786 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8787
8788         * dwarf2read.c (open_and_init_dwp_file): Call
8789         elf_numsections instead of bfd_count_sections to initialize
8790         dwp_file->num_sections.
8791
8792 2019-02-25  Tom Tromey  <tromey@adacore.com>
8793
8794         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8795
8796 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8797
8798         * gcore.in: Add '--readnever' option when invoking GDB.
8799
8800 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8801
8802         * MAINTAINERS: Update my email address.
8803
8804 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8805
8806         * build-id.c (build_id_to_debug_bfd_1): New function.
8807         (build_id_to_debug_bfd): Look for separate debug file in
8808         sysroot.
8809
8810 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8811
8812         * gdbarch.sh: Update the copyright year range that is placed into
8813         generated files.
8814
8815 2019-02-22  Keith Seitz  <keiths@redhat.com>
8816
8817         PR symtab/23853
8818         * linespec.c (create_sals_line_offset): Search for the default
8819         symtab's filename instead of its fullname.
8820
8821 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8822
8823         * NEWS: Update style defaults.
8824
8825 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8826
8827         * main.c (captured_main_1): Disable styling in batch mode.
8828
8829 2019-02-20  Tom Tromey  <tom@tromey.com>
8830
8831         * symtab.c (symtab_symbol_info): Fix typos.
8832
8833 2019-02-20  Tom Tromey  <tromey@adacore.com>
8834
8835         * findcmd.c (_initialize_mem_search): Use upper case for
8836         metasyntactic variables.
8837
8838 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8839
8840         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8841         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8842
8843 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8844
8845         * top.h (source_file_name): Change to std::string.
8846         * top.c (source_file_name): Likewise.
8847         (command_line_input): Adjust.
8848         * cli/cli-script.c (script_from_file): Adjust.
8849
8850 2019-02-19  Tom Tromey  <tromey@adacore.com>
8851
8852         * ravenscar-thread.c
8853         (ravenscar_thread_target::update_thread_list): Don't call
8854         ada_build_task_list.
8855         * ada-lang.h (ada_build_task_list): Don't declare.
8856         * ada-tasks.c (struct ada_tasks_inferior_data)
8857         <task_list_valid_p>: Now bool.
8858         (read_known_tasks, ada_task_list_changed)
8859         (ada_tasks_invalidate_inferior_data): Update.
8860         (read_known_tasks_array): Return bool.
8861         (read_known_tasks_list): Likewise.
8862         (read_known_tasks): Return void.
8863         (ada_build_task_list): Now static.
8864
8865 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8866
8867         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8868         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8869
8870 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8871
8872         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8873         variant for ada_tasks_pspace_data_handle and
8874         ada_tasks_inferior_data_handle.
8875         (ada_tasks_pspace_data_cleanup): New function.
8876         (ada_tasks_inferior_data_cleanup): New function.
8877
8878 2019-02-17  Tom Tromey  <tom@tromey.com>
8879
8880         * macrotab.h (macro_source_fullname): Return a std::string.
8881         * macrotab.c (macro_include, check_for_redefinition)
8882         (macro_undef, macro_lookup_definition, foreach_macro)
8883         (foreach_macro_in_scope): Update.
8884         (macro_source_fullname): Return a std::string.
8885         * macrocmd.c (show_pp_source_pos): Update.
8886
8887 2019-02-17  Tom Tromey  <tom@tromey.com>
8888
8889         * macrocmd.c (show_pp_source_pos): Style the file names.
8890
8891 2019-02-17  Tom Tromey  <tom@tromey.com>
8892
8893         PR tui/24197:
8894         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8895
8896 2019-02-17  Tom Tromey  <tom@tromey.com>
8897
8898         * ada-lang.c (user_select_syms): Use filtered printing.
8899         * utils.c (wrap_style): New global.
8900         (desired_style): Remove.
8901         (emit_style_escape): Add stream parameter.
8902         (set_output_style, reset_terminal_style, prompt_for_continue):
8903         Update.
8904         (flush_wrap_buffer): Only flush gdb_stdout.
8905         (wrap_here): Set wrap_style.
8906         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8907         treat escape sequences as a character.  Change when wrap buffer is
8908         flushed.
8909         (fputs_styled): Do not set the output style when the default is
8910         requested.
8911         * ui-style.h (struct ui_file_style) <is_default>: New method.
8912         * source.c (print_source_lines_base): Emit escape sequences in one
8913         piece.
8914
8915 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8916
8917         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8918         integers and enumeration types.
8919
8920 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8921
8922         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8923         instead of lookup_symbol_in_language
8924         (do_exact_match): New function.
8925         (ada_get_symbol_name_matcher): Return do_exact_match when
8926         doing a verbatim match.
8927
8928 2019-02-15  Tom Tromey  <tromey@adacore.com>
8929
8930         * ravenscar-thread.c (ravenscar_thread_target::resume)
8931         (ravenscar_thread_target::wait): Special case wildcard requests.
8932
8933 2019-02-15  Tom Tromey  <tromey@adacore.com>
8934
8935         * ravenscar-thread.c (base_ptid): Remove.
8936         (struct ravenscar_thread_target) <close>: New method.
8937         <m_base_ptid>: New member.
8938         <update_inferior_ptid, active_task, task_is_currently_active,
8939         runtime_initialized>: Declare methods.
8940         <ravenscar_thread_target>: Add constructor.
8941         (ravenscar_thread_target::task_is_currently_active)
8942         (ravenscar_thread_target::update_inferior_ptid)
8943         (ravenscar_runtime_initialized): Rename.  Now methods.
8944         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8945         (ravenscar_thread_target::update_thread_list): Update.
8946         (ravenscar_thread_target::active_task): Now method.
8947         (ravenscar_thread_target::store_registers)
8948         (ravenscar_thread_target::prepare_to_store)
8949         (ravenscar_thread_target::prepare_to_store)
8950         (ravenscar_thread_target::mourn_inferior): Update.
8951         (ravenscar_inferior_created): Use "new" to create target.
8952         (ravenscar_thread_target::get_ada_task_ptid): Update.
8953         (_initialize_ravenscar): Don't initialize base_ptid.
8954         (ravenscar_ops): Remove global.
8955
8956 2019-02-15  Tom Tromey  <tromey@adacore.com>
8957
8958         * target.h (push_target): Declare new overload.
8959         * target.c (push_target): New overload, taking an rvalue reference.
8960         * remote.c (remote_target::open_1): Use push_target overload.
8961         * corelow.c (core_target_open): Use push_target overload.
8962
8963 2019-02-15  Tom Tromey  <tromey@adacore.com>
8964
8965         * ravenscar-thread.c (is_ravenscar_task)
8966         (ravenscar_task_is_currently_active): Return bool.
8967         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8968         (_initialize_ravenscar): Remove "(void)".
8969         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8970         Return bool.
8971
8972 2019-02-15  Tom Tromey  <tromey@adacore.com>
8973
8974         * ravenscar-thread.c (ravenscar_runtime_initializer)
8975         (has_ravenscar_runtime, get_running_thread_id)
8976         (ravenscar_thread_target::resume): Fix indentation.
8977
8978 2019-02-15  Tom Tromey  <tromey@adacore.com>
8979
8980         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8981         from ravenscar_arch_ops.
8982         (sparc_ravenscar_ops::fetch_registers)
8983         (sparc_ravenscar_ops::store_registers): Now methods.
8984         (sparc_ravenscar_prepare_to_store): Remove.
8985         (sparc_ravenscar_ops): Redefine.
8986         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8987         methods and destructor.  Remove members.
8988         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8989         (ravenscar_thread_target::store_registers)
8990         (ravenscar_thread_target::prepare_to_store): Update.
8991         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8992         Remove.
8993         (struct ppc_ravenscar_powerpc_ops): Derive from
8994         ravenscar_arch_ops.
8995         (ppc_ravenscar_powerpc_ops::fetch_registers)
8996         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8997         (ppc_ravenscar_powerpc_ops): Redefine.
8998         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8999         (ppc_ravenscar_e500_ops::fetch_registers)
9000         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9001         (ppc_ravenscar_e500_ops): Redefine.
9002         * aarch64-ravenscar-thread.c
9003         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9004         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9005         (aarch64_ravenscar_fetch_registers)
9006         (aarch64_ravenscar_store_registers): Now methods.
9007         (aarch64_ravenscar_ops): Redefine.
9008
9009 2019-02-15  Tom Tromey  <tromey@adacore.com>
9010
9011         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9012         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9013         (ravenscar_thread_target::stopped_by_watchpoint)
9014         (ravenscar_thread_target::stopped_data_address)
9015         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9016
9017 2019-02-15  Tom Tromey  <tromey@adacore.com>
9018
9019         * ravenscar-thread.c: Fix some typos.
9020
9021 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9022             Tom Tromey  <tromey@adacore.com>
9023
9024         * ada-lang.c (ada_exception_sal): Change addr_string to a
9025         std::string.
9026         (create_ada_exception_catchpoint): Update.
9027
9028 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9029             Tom Tromey  <tromey@adacore.com>
9030
9031         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9032         (bp_location_ops): Remove.
9033         (base_breakpoint_allocate_location): Update.
9034         (free_bp_location): Update.
9035         * ada-lang.c (class ada_catchpoint_location)
9036         <ada_catchpoint_location>: Remove ops parameter.
9037         (ada_catchpoint_location_dtor): Remove.
9038         (ada_catchpoint_location_ops): Remove.
9039         (allocate_location_exception): Update.
9040         * breakpoint.h (struct bp_location_ops): Remove.
9041         (class bp_location) <bp_location>: Remove bp_location_ops
9042         parameter.
9043         <~bp_location>: Add destructor.
9044         <ops>: Remove.
9045
9046 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9047             Pedro Alves  <palves@redhat.com>
9048
9049         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9050         'PATH_MAX'.
9051
9052 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9053             Samuel Thibault  <samuel.thibault@gnu.org>
9054             Thomas Schwinge  <thomas@codesourcery.com>
9055
9056         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9057         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9058
9059 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9060
9061         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9062         (check_empty): Use "const char *".
9063
9064         * gnu-nat.c (gnu_nat_target::detach): Instead of
9065         'detach_inferior (pid)' call
9066         'detach_inferior (find_inferior_pid (pid))'.
9067
9068         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9069         'nat/fork-inferior.o'.
9070         * gnu-nat.c: #include "nat/fork-inferior.h".
9071
9072         * gnu-nat.c (gnu_nat_target::detach): Instead of
9073         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9074         * gnu-nat.h: #include "inf-child.h".
9075         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9076         'i386_gnu_nat_target::fetch_registers'.
9077         (gnu_store_registers): Rename/move to
9078         'i386_gnu_nat_target::store_registers'.
9079
9080         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9081         * gnu-nat.h (mach_thread_info): New function.
9082         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9083
9084         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9085
9086 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9087
9088         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9089
9090 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9091
9092         * windows-nat.c (windows_add_thread): Add new parameter
9093         "main_thread_p" with default value set to false.  Update
9094         function documentation as well as all callers.
9095         (windows_delete_thread): Likewise.
9096         (fake_create_process): Update call to windows_add_thread.
9097         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9098         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9099         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9100         call to windows_delete_thread.
9101
9102 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9103
9104         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9105
9106 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9107
9108         * symfile.c (find_separate_debug_file): Use canonical path of
9109         sysroot with child_path instead of gdb_sysroot if it is valid.
9110
9111 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9112
9113         * symfile.c (find_separate_debug_file): Use child_path to
9114         determine if an object file is under a sysroot.
9115
9116 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9117
9118         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9119         unittests/child-path-selftests.c.
9120         * common/pathstuff.c (child_path): New function.
9121         * common/pathstuff.h (child_path): New prototype.
9122         * unittests/child-path-selftests.c: New file.
9123
9124 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9125
9126         * symfile.c (find_separate_debug_file): Look for separate debug
9127         files in debug directories under the sysroot.
9128
9129 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9130
9131         * symtab.h (struct minimal_symbol data_p): New const method.
9132         (struct minimal_symbol text_p): Likewise.
9133         * symtab.c (output_source_filename): Use file name style
9134         to print file name.
9135         (print_symbol_info): Likewise.
9136         (print_msymbol_info): Use address style to print addresses.
9137         Use function name style to print executable text symbols.
9138         (expand_symtab_containing_pc): Use data_p.
9139         (find_pc_sect_compunit_symtab): Likewise.
9140
9141 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9142
9143         * breakpoint.c (describe_other_breakpoints): Use address style
9144         to print addresses.
9145         (say_where): Likewise.
9146
9147 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9148
9149         * ada-typeprint.c (print_func_type): Print function name
9150         style to print function name.
9151         * c-typeprint.c (c_print_type_1): Likewise.
9152
9153 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9154
9155         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9156         for execve.
9157
9158 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9159
9160         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9161         type_stack.
9162
9163 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9164
9165         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9166         TYPE_CODE_REF types.
9167
9168 2019-02-08  Jim Wilson  <jimw@sifive.com>
9169
9170         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9171         (riscv_linux_fregset): New.
9172         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9173
9174 2019-02-07  Tom Tromey  <tom@tromey.com>
9175
9176         * thread.c (thread_cancel_execution_command): Update.
9177         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9178         methods.
9179         (struct thread_fsm_ops): Remove.
9180         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9181         (thread_fsm_should_stop, thread_fsm_return_value)
9182         (thread_fsm_set_finished, thread_fsm_finished_p)
9183         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9184         Don't declare.
9185         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9186         * infrun.c (clear_proceed_status_thread)
9187         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9188         (print_stop_event): Update.
9189         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9190         Add constructor.
9191         (step_command_fsm_ops): Remove.
9192         (new_step_command_fsm): Remove.
9193         (step_1): Update.
9194         (step_command_fsm::should_stop): Rename from
9195         step_command_fsm_should_stop.
9196         (step_command_fsm::clean_up): Rename from
9197         step_command_fsm_clean_up.
9198         (step_command_fsm::do_async_reply_reason): Rename from
9199         step_command_fsm_async_reply_reason.
9200         (struct until_next_fsm): Inherit from thread_fsm.  Add
9201         constructor.
9202         (until_next_fsm_ops): Remove.
9203         (new_until_next_fsm): Remove.
9204         (until_next_fsm::should_stop): Rename from
9205         until_next_fsm_should_stop.
9206         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9207         (until_next_fsm::do_async_reply_reason): Rename from
9208         until_next_fsm_async_reply_reason.
9209         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9210         constructor.  Change type of breakpoint.
9211         (finish_command_fsm_ops): Remove.
9212         (new_finish_command_fsm): Remove.
9213         (finish_command_fsm::should_stop): Rename from
9214         finish_command_fsm_should_stop.
9215         (finish_command_fsm::clean_up): Rename from
9216         finish_command_fsm_clean_up.
9217         (finish_command_fsm::return_value): Rename from
9218         finish_command_fsm_return_value.
9219         (finish_command_fsm::do_async_reply_reason): Rename from
9220         finish_command_fsm_async_reply_reason.
9221         (finish_command): Update.
9222         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9223         Add constructor.
9224         (call_thread_fsm_ops): Remove.
9225         (call_thread_fsm::call_thread_fsm): Rename from
9226         new_call_thread_fsm.
9227         (call_thread_fsm::should_stop): Rename from
9228         call_thread_fsm_should_stop.
9229         (call_thread_fsm::should_notify_stop): Rename from
9230         call_thread_fsm_should_notify_stop.
9231         (run_inferior_call, call_function_by_hand_dummy): Update.
9232         * cli/cli-interp.c (should_print_stop_to_console): Update.
9233         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9234         Add constructor.  Change type of location_breakpoint,
9235         caller_breakpoint.
9236         (until_break_fsm_ops): Remove.
9237         (new_until_break_fsm): Remove.
9238         (until_break_fsm::should_stop): Rename from
9239         until_break_fsm_should_stop.
9240         (until_break_fsm::clean_up): Rename from
9241         until_break_fsm_clean_up.
9242         (until_break_fsm::do_async_reply_reason): Rename from
9243         until_break_fsm_async_reply_reason.
9244         (until_break_command): Update.
9245         * thread-fsm.c: Remove.
9246         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9247
9248 2019-02-07  Tom Tromey  <tom@tromey.com>
9249
9250         * yy-remap.h: Add include guard.
9251         * xtensa-tdep.h: Add include guard.
9252         * xcoffread.h: Rename include guard.
9253         * varobj-iter.h: Add include guard.
9254         * tui/tui.h: Rename include guard.
9255         * tui/tui-winsource.h: Rename include guard.
9256         * tui/tui-wingeneral.h: Rename include guard.
9257         * tui/tui-windata.h: Rename include guard.
9258         * tui/tui-win.h: Rename include guard.
9259         * tui/tui-stack.h: Rename include guard.
9260         * tui/tui-source.h: Rename include guard.
9261         * tui/tui-regs.h: Rename include guard.
9262         * tui/tui-out.h: Rename include guard.
9263         * tui/tui-layout.h: Rename include guard.
9264         * tui/tui-io.h: Rename include guard.
9265         * tui/tui-hooks.h: Rename include guard.
9266         * tui/tui-file.h: Rename include guard.
9267         * tui/tui-disasm.h: Rename include guard.
9268         * tui/tui-data.h: Rename include guard.
9269         * tui/tui-command.h: Rename include guard.
9270         * tic6x-tdep.h: Add include guard.
9271         * target/waitstatus.h: Rename include guard.
9272         * target/wait.h: Rename include guard.
9273         * target/target.h: Rename include guard.
9274         * target/resume.h: Rename include guard.
9275         * target-float.h: Rename include guard.
9276         * stabsread.h: Add include guard.
9277         * rs6000-tdep.h: Add include guard.
9278         * riscv-fbsd-tdep.h: Add include guard.
9279         * regformats/regdef.h: Rename include guard.
9280         * record.h: Rename include guard.
9281         * python/python.h: Rename include guard.
9282         * python/python-internal.h: Rename include guard.
9283         * python/py-stopevent.h: Rename include guard.
9284         * python/py-ref.h: Rename include guard.
9285         * python/py-record.h: Rename include guard.
9286         * python/py-record-full.h: Rename include guard.
9287         * python/py-record-btrace.h: Rename include guard.
9288         * python/py-instruction.h: Rename include guard.
9289         * python/py-events.h: Rename include guard.
9290         * python/py-event.h: Rename include guard.
9291         * procfs.h: Add include guard.
9292         * proc-utils.h: Add include guard.
9293         * p-lang.h: Add include guard.
9294         * or1k-tdep.h: Rename include guard.
9295         * observable.h: Rename include guard.
9296         * nto-tdep.h: Rename include guard.
9297         * nat/x86-linux.h: Rename include guard.
9298         * nat/x86-linux-dregs.h: Rename include guard.
9299         * nat/x86-gcc-cpuid.h: Add include guard.
9300         * nat/x86-dregs.h: Rename include guard.
9301         * nat/x86-cpuid.h: Rename include guard.
9302         * nat/ppc-linux.h: Rename include guard.
9303         * nat/mips-linux-watch.h: Rename include guard.
9304         * nat/linux-waitpid.h: Rename include guard.
9305         * nat/linux-ptrace.h: Rename include guard.
9306         * nat/linux-procfs.h: Rename include guard.
9307         * nat/linux-osdata.h: Rename include guard.
9308         * nat/linux-nat.h: Rename include guard.
9309         * nat/linux-namespaces.h: Rename include guard.
9310         * nat/linux-btrace.h: Rename include guard.
9311         * nat/glibc_thread_db.h: Rename include guard.
9312         * nat/gdb_thread_db.h: Rename include guard.
9313         * nat/gdb_ptrace.h: Rename include guard.
9314         * nat/fork-inferior.h: Rename include guard.
9315         * nat/amd64-linux-siginfo.h: Rename include guard.
9316         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9317         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9318         * nat/aarch64-linux.h: Rename include guard.
9319         * nat/aarch64-linux-hw-point.h: Rename include guard.
9320         * mn10300-tdep.h: Add include guard.
9321         * mips-linux-tdep.h: Add include guard.
9322         * mi/mi-parse.h: Rename include guard.
9323         * mi/mi-out.h: Rename include guard.
9324         * mi/mi-main.h: Rename include guard.
9325         * mi/mi-interp.h: Rename include guard.
9326         * mi/mi-getopt.h: Rename include guard.
9327         * mi/mi-console.h: Rename include guard.
9328         * mi/mi-common.h: Rename include guard.
9329         * mi/mi-cmds.h: Rename include guard.
9330         * mi/mi-cmd-break.h: Rename include guard.
9331         * m2-lang.h: Add include guard.
9332         * location.h: Rename include guard.
9333         * linux-record.h: Rename include guard.
9334         * linux-nat.h: Add include guard.
9335         * linux-fork.h: Add include guard.
9336         * i386-darwin-tdep.h: Rename include guard.
9337         * hppa-linux-offsets.h: Add include guard.
9338         * guile/guile.h: Rename include guard.
9339         * guile/guile-internal.h: Rename include guard.
9340         * gnu-nat.h: Rename include guard.
9341         * gdb-stabs.h: Rename include guard.
9342         * frv-tdep.h: Add include guard.
9343         * f-lang.h: Add include guard.
9344         * event-loop.h: Add include guard.
9345         * darwin-nat.h: Rename include guard.
9346         * cp-abi.h: Rename include guard.
9347         * config/sparc/nm-sol2.h: Rename include guard.
9348         * config/nm-nto.h: Rename include guard.
9349         * config/nm-linux.h: Add include guard.
9350         * config/i386/nm-i386gnu.h: Rename include guard.
9351         * config/djgpp/nl_types.h: Rename include guard.
9352         * config/djgpp/langinfo.h: Rename include guard.
9353         * compile/gcc-cp-plugin.h: Add include guard.
9354         * compile/gcc-c-plugin.h: Add include guard.
9355         * compile/compile.h: Rename include guard.
9356         * compile/compile-object-run.h: Rename include guard.
9357         * compile/compile-object-load.h: Rename include guard.
9358         * compile/compile-internal.h: Rename include guard.
9359         * compile/compile-cplus.h: Rename include guard.
9360         * compile/compile-c.h: Rename include guard.
9361         * common/xml-utils.h: Rename include guard.
9362         * common/x86-xstate.h: Rename include guard.
9363         * common/version.h: Rename include guard.
9364         * common/vec.h: Rename include guard.
9365         * common/tdesc.h: Rename include guard.
9366         * common/selftest.h: Rename include guard.
9367         * common/scoped_restore.h: Rename include guard.
9368         * common/scoped_mmap.h: Rename include guard.
9369         * common/scoped_fd.h: Rename include guard.
9370         * common/safe-iterator.h: Rename include guard.
9371         * common/run-time-clock.h: Rename include guard.
9372         * common/refcounted-object.h: Rename include guard.
9373         * common/queue.h: Rename include guard.
9374         * common/ptid.h: Rename include guard.
9375         * common/print-utils.h: Rename include guard.
9376         * common/preprocessor.h: Rename include guard.
9377         * common/pathstuff.h: Rename include guard.
9378         * common/observable.h: Rename include guard.
9379         * common/netstuff.h: Rename include guard.
9380         * common/job-control.h: Rename include guard.
9381         * common/host-defs.h: Rename include guard.
9382         * common/gdb_wait.h: Rename include guard.
9383         * common/gdb_vecs.h: Rename include guard.
9384         * common/gdb_unlinker.h: Rename include guard.
9385         * common/gdb_unique_ptr.h: Rename include guard.
9386         * common/gdb_tilde_expand.h: Rename include guard.
9387         * common/gdb_sys_time.h: Rename include guard.
9388         * common/gdb_string_view.h: Rename include guard.
9389         * common/gdb_splay_tree.h: Rename include guard.
9390         * common/gdb_setjmp.h: Rename include guard.
9391         * common/gdb_ref_ptr.h: Rename include guard.
9392         * common/gdb_optional.h: Rename include guard.
9393         * common/gdb_locale.h: Rename include guard.
9394         * common/gdb_assert.h: Rename include guard.
9395         * common/filtered-iterator.h: Rename include guard.
9396         * common/filestuff.h: Rename include guard.
9397         * common/fileio.h: Rename include guard.
9398         * common/environ.h: Rename include guard.
9399         * common/common-utils.h: Rename include guard.
9400         * common/common-types.h: Rename include guard.
9401         * common/common-regcache.h: Rename include guard.
9402         * common/common-inferior.h: Rename include guard.
9403         * common/common-gdbthread.h: Rename include guard.
9404         * common/common-exceptions.h: Rename include guard.
9405         * common/common-defs.h: Rename include guard.
9406         * common/common-debug.h: Rename include guard.
9407         * common/cleanups.h: Rename include guard.
9408         * common/buffer.h: Rename include guard.
9409         * common/btrace-common.h: Rename include guard.
9410         * common/break-common.h: Rename include guard.
9411         * cli/cli-utils.h: Rename include guard.
9412         * cli/cli-style.h: Rename include guard.
9413         * cli/cli-setshow.h: Rename include guard.
9414         * cli/cli-script.h: Rename include guard.
9415         * cli/cli-interp.h: Rename include guard.
9416         * cli/cli-decode.h: Rename include guard.
9417         * cli/cli-cmds.h: Rename include guard.
9418         * charset-list.h: Add include guard.
9419         * buildsym-legacy.h: Rename include guard.
9420         * bfin-tdep.h: Add include guard.
9421         * ax.h: Rename include guard.
9422         * arm-linux-tdep.h: Add include guard.
9423         * arm-fbsd-tdep.h: Add include guard.
9424         * arch/xtensa.h: Rename include guard.
9425         * arch/tic6x.h: Add include guard.
9426         * arch/i386.h: Add include guard.
9427         * arch/arm.h: Rename include guard.
9428         * arch/arm-linux.h: Rename include guard.
9429         * arch/arm-get-next-pcs.h: Rename include guard.
9430         * arch/amd64.h: Add include guard.
9431         * arch/aarch64-insn.h: Rename include guard.
9432         * arch-utils.h: Rename include guard.
9433         * annotate.h: Add include guard.
9434         * amd64-darwin-tdep.h: Rename include guard.
9435         * aarch64-linux-tdep.h: Add include guard.
9436         * aarch64-fbsd-tdep.h: Add include guard.
9437         * aarch32-linux-nat.h: Add include guard.
9438
9439 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9440
9441         * macrotab.c (macro_define_internal): New function that
9442         factorizes macro_define_object_internal and macro_define_function
9443         code.
9444         (macro_define_object_internal): Use macro_define_internal.
9445         (macro_define_function): Likewise.
9446
9447 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9448
9449         * macrocmd.c (extract_identifier): Return
9450         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9451         callers.
9452
9453 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9454
9455         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9456
9457 2019-02-05  Tom Tromey  <tom@tromey.com>
9458
9459         * target.c (target_stack::unpush): Move assertion earlier.
9460
9461 2019-01-30  Tom Tromey  <tom@tromey.com>
9462
9463         PR python/23615:
9464         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9465         (gdbpy_parse_and_eval): Likewise.
9466         * python/python-internal.h (gdbpy_allow_threads): New class.
9467
9468 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9469
9470         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9471         (aarch64_fbsd_fpregmap): Move earlier.
9472         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9473         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9474         instead of individual calls to trad_frame_set_reg_addr.
9475         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9476         earlier.
9477         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9478         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9479         instead of individual calls to trad_frame_set_reg_addr.
9480
9481 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9482
9483         * CONTRIBUTE: Replace contribution list with wiki link.
9484
9485 2019-01-25  Tom Tromey  <tom@tromey.com>
9486
9487         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9488
9489 2019-01-25  Tom Tromey  <tom@tromey.com>
9490
9491         * xtensa-linux-nat.c: Fix common/ includes.
9492         * xml-support.h: Fix common/ includes.
9493         * xml-support.c: Fix common/ includes.
9494         * x86-linux-nat.c: Fix common/ includes.
9495         * windows-nat.c: Fix common/ includes.
9496         * varobj.h: Fix common/ includes.
9497         * varobj.c: Fix common/ includes.
9498         * value.c: Fix common/ includes.
9499         * valops.c: Fix common/ includes.
9500         * utils.c: Fix common/ includes.
9501         * unittests/xml-utils-selftests.c: Fix common/ includes.
9502         * unittests/utils-selftests.c: Fix common/ includes.
9503         * unittests/unpack-selftests.c: Fix common/ includes.
9504         * unittests/tracepoint-selftests.c: Fix common/ includes.
9505         * unittests/style-selftests.c: Fix common/ includes.
9506         * unittests/string_view-selftests.c: Fix common/ includes.
9507         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9508         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9509         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9510         * unittests/rsp-low-selftests.c: Fix common/ includes.
9511         * unittests/parse-connection-spec-selftests.c: Fix common/
9512         includes.
9513         * unittests/optional-selftests.c: Fix common/ includes.
9514         * unittests/offset-type-selftests.c: Fix common/ includes.
9515         * unittests/observable-selftests.c: Fix common/ includes.
9516         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9517         * unittests/memrange-selftests.c: Fix common/ includes.
9518         * unittests/memory-map-selftests.c: Fix common/ includes.
9519         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9520         * unittests/function-view-selftests.c: Fix common/ includes.
9521         * unittests/environ-selftests.c: Fix common/ includes.
9522         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9523         * unittests/common-utils-selftests.c: Fix common/ includes.
9524         * unittests/cli-utils-selftests.c: Fix common/ includes.
9525         * unittests/array-view-selftests.c: Fix common/ includes.
9526         * ui-file.c: Fix common/ includes.
9527         * tui/tui-io.c: Fix common/ includes.
9528         * tracepoint.h: Fix common/ includes.
9529         * tracepoint.c: Fix common/ includes.
9530         * tracefile-tfile.c: Fix common/ includes.
9531         * top.h: Fix common/ includes.
9532         * top.c: Fix common/ includes.
9533         * thread.c: Fix common/ includes.
9534         * target/waitstatus.h: Fix common/ includes.
9535         * target/waitstatus.c: Fix common/ includes.
9536         * target.h: Fix common/ includes.
9537         * target.c: Fix common/ includes.
9538         * target-memory.c: Fix common/ includes.
9539         * target-descriptions.c: Fix common/ includes.
9540         * symtab.h: Fix common/ includes.
9541         * symfile.c: Fix common/ includes.
9542         * stap-probe.c: Fix common/ includes.
9543         * spu-linux-nat.c: Fix common/ includes.
9544         * sparc-nat.c: Fix common/ includes.
9545         * source.c: Fix common/ includes.
9546         * solib.c: Fix common/ includes.
9547         * solib-target.c: Fix common/ includes.
9548         * ser-unix.c: Fix common/ includes.
9549         * ser-tcp.c: Fix common/ includes.
9550         * ser-pipe.c: Fix common/ includes.
9551         * ser-base.c: Fix common/ includes.
9552         * selftest-arch.c: Fix common/ includes.
9553         * s12z-tdep.c: Fix common/ includes.
9554         * rust-exp.y: Fix common/ includes.
9555         * rs6000-aix-tdep.c: Fix common/ includes.
9556         * riscv-tdep.c: Fix common/ includes.
9557         * remote.c: Fix common/ includes.
9558         * remote-notif.h: Fix common/ includes.
9559         * remote-fileio.h: Fix common/ includes.
9560         * remote-fileio.c: Fix common/ includes.
9561         * regcache.h: Fix common/ includes.
9562         * regcache.c: Fix common/ includes.
9563         * record-btrace.c: Fix common/ includes.
9564         * python/python.c: Fix common/ includes.
9565         * python/py-type.c: Fix common/ includes.
9566         * python/py-inferior.c: Fix common/ includes.
9567         * progspace.h: Fix common/ includes.
9568         * producer.c: Fix common/ includes.
9569         * procfs.c: Fix common/ includes.
9570         * proc-api.c: Fix common/ includes.
9571         * printcmd.c: Fix common/ includes.
9572         * ppc-linux-nat.c: Fix common/ includes.
9573         * parser-defs.h: Fix common/ includes.
9574         * osdata.c: Fix common/ includes.
9575         * obsd-nat.c: Fix common/ includes.
9576         * nat/x86-linux.c: Fix common/ includes.
9577         * nat/x86-linux-dregs.c: Fix common/ includes.
9578         * nat/x86-dregs.h: Fix common/ includes.
9579         * nat/x86-dregs.c: Fix common/ includes.
9580         * nat/ppc-linux.c: Fix common/ includes.
9581         * nat/mips-linux-watch.h: Fix common/ includes.
9582         * nat/mips-linux-watch.c: Fix common/ includes.
9583         * nat/linux-waitpid.c: Fix common/ includes.
9584         * nat/linux-ptrace.h: Fix common/ includes.
9585         * nat/linux-ptrace.c: Fix common/ includes.
9586         * nat/linux-procfs.c: Fix common/ includes.
9587         * nat/linux-personality.c: Fix common/ includes.
9588         * nat/linux-osdata.c: Fix common/ includes.
9589         * nat/linux-namespaces.c: Fix common/ includes.
9590         * nat/linux-btrace.h: Fix common/ includes.
9591         * nat/linux-btrace.c: Fix common/ includes.
9592         * nat/fork-inferior.c: Fix common/ includes.
9593         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9594         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9595         * nat/aarch64-linux.c: Fix common/ includes.
9596         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9597         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9598         * namespace.h: Fix common/ includes.
9599         * mips-linux-tdep.c: Fix common/ includes.
9600         * minsyms.c: Fix common/ includes.
9601         * mi/mi-parse.h: Fix common/ includes.
9602         * mi/mi-main.c: Fix common/ includes.
9603         * mi/mi-cmd-env.c: Fix common/ includes.
9604         * memrange.h: Fix common/ includes.
9605         * memattr.c: Fix common/ includes.
9606         * maint.h: Fix common/ includes.
9607         * maint.c: Fix common/ includes.
9608         * main.c: Fix common/ includes.
9609         * machoread.c: Fix common/ includes.
9610         * location.c: Fix common/ includes.
9611         * linux-thread-db.c: Fix common/ includes.
9612         * linux-nat.c: Fix common/ includes.
9613         * linux-fork.c: Fix common/ includes.
9614         * inline-frame.c: Fix common/ includes.
9615         * infrun.c: Fix common/ includes.
9616         * inflow.c: Fix common/ includes.
9617         * inferior.h: Fix common/ includes.
9618         * inferior.c: Fix common/ includes.
9619         * infcmd.c: Fix common/ includes.
9620         * inf-ptrace.c: Fix common/ includes.
9621         * inf-child.c: Fix common/ includes.
9622         * ia64-linux-nat.c: Fix common/ includes.
9623         * i387-tdep.c: Fix common/ includes.
9624         * i386-tdep.c: Fix common/ includes.
9625         * i386-linux-tdep.c: Fix common/ includes.
9626         * i386-linux-nat.c: Fix common/ includes.
9627         * i386-go32-tdep.c: Fix common/ includes.
9628         * i386-fbsd-tdep.c: Fix common/ includes.
9629         * i386-fbsd-nat.c: Fix common/ includes.
9630         * guile/scm-type.c: Fix common/ includes.
9631         * guile/guile.c: Fix common/ includes.
9632         * go32-nat.c: Fix common/ includes.
9633         * gnu-nat.c: Fix common/ includes.
9634         * gdbthread.h: Fix common/ includes.
9635         * gdbarch-selftests.c: Fix common/ includes.
9636         * gdb_usleep.c: Fix common/ includes.
9637         * gdb_select.h: Fix common/ includes.
9638         * gdb_bfd.c: Fix common/ includes.
9639         * gcore.c: Fix common/ includes.
9640         * fork-child.c: Fix common/ includes.
9641         * findvar.c: Fix common/ includes.
9642         * fbsd-nat.c: Fix common/ includes.
9643         * event-top.c: Fix common/ includes.
9644         * event-loop.c: Fix common/ includes.
9645         * dwarf2read.c: Fix common/ includes.
9646         * dwarf2loc.c: Fix common/ includes.
9647         * dwarf2-frame.c: Fix common/ includes.
9648         * dwarf-index-cache.c: Fix common/ includes.
9649         * dtrace-probe.c: Fix common/ includes.
9650         * disasm-selftests.c: Fix common/ includes.
9651         * defs.h: Fix common/ includes.
9652         * csky-tdep.c: Fix common/ includes.
9653         * cp-valprint.c: Fix common/ includes.
9654         * cp-support.h: Fix common/ includes.
9655         * cp-support.c: Fix common/ includes.
9656         * corelow.c: Fix common/ includes.
9657         * completer.h: Fix common/ includes.
9658         * completer.c: Fix common/ includes.
9659         * compile/compile.c: Fix common/ includes.
9660         * compile/compile-loc2c.c: Fix common/ includes.
9661         * compile/compile-cplus-types.c: Fix common/ includes.
9662         * compile/compile-cplus-symbols.c: Fix common/ includes.
9663         * command.h: Fix common/ includes.
9664         * cli/cli-dump.c: Fix common/ includes.
9665         * cli/cli-cmds.c: Fix common/ includes.
9666         * charset.c: Fix common/ includes.
9667         * build-id.c: Fix common/ includes.
9668         * btrace.h: Fix common/ includes.
9669         * btrace.c: Fix common/ includes.
9670         * breakpoint.h: Fix common/ includes.
9671         * breakpoint.c: Fix common/ includes.
9672         * ax.h:
9673         (enum agent_op): Fix common/ includes.
9674         * ax-general.c (struct aop_map): Fix common/ includes.
9675         * ax-gdb.c: Fix common/ includes.
9676         * auxv.c: Fix common/ includes.
9677         * auto-load.c: Fix common/ includes.
9678         * arm-tdep.c: Fix common/ includes.
9679         * arch/riscv.c: Fix common/ includes.
9680         * arch/ppc-linux-common.c: Fix common/ includes.
9681         * arch/i386.c: Fix common/ includes.
9682         * arch/arm.c: Fix common/ includes.
9683         * arch/arm-linux.c: Fix common/ includes.
9684         * arch/arm-get-next-pcs.c: Fix common/ includes.
9685         * arch/amd64.c: Fix common/ includes.
9686         * arch/aarch64.c: Fix common/ includes.
9687         * arch/aarch64-insn.c: Fix common/ includes.
9688         * arch-utils.c: Fix common/ includes.
9689         * amd64-windows-tdep.c: Fix common/ includes.
9690         * amd64-tdep.c: Fix common/ includes.
9691         * amd64-sol2-tdep.c: Fix common/ includes.
9692         * amd64-obsd-tdep.c: Fix common/ includes.
9693         * amd64-nbsd-tdep.c: Fix common/ includes.
9694         * amd64-linux-tdep.c: Fix common/ includes.
9695         * amd64-linux-nat.c: Fix common/ includes.
9696         * amd64-fbsd-tdep.c: Fix common/ includes.
9697         * amd64-fbsd-nat.c: Fix common/ includes.
9698         * amd64-dicos-tdep.c: Fix common/ includes.
9699         * amd64-darwin-tdep.c: Fix common/ includes.
9700         * agent.c: Fix common/ includes.
9701         * ada-lang.h: Fix common/ includes.
9702         * ada-lang.c: Fix common/ includes.
9703         * aarch64-tdep.c: Fix common/ includes.
9704
9705 2019-01-25  Tom Tromey  <tom@tromey.com>
9706
9707         * common/create-version.sh: Use common/version.h.
9708
9709 2019-01-24  Pedro Alves  <palves@redhat.com>
9710
9711         * infrun.c (signal_stop, signal_print, signal_program)
9712         (signal_catch, signal_pass): Now arrays instead of pointers.
9713         (update_signals_program_target, do_target_resume)
9714         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9715         * linux-nat.c (linux_nat_target::pass_signals)
9716         (linux_nat_target::create_inferior, linux_nat_target::attach):
9717         Adjust.
9718         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9719         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9720         * procfs.c (procfs_target::pass_signals): Adjust.
9721         * record-full.c (record_full_target::resume): Adjust.
9722         * remote.c (remote_target::pass_signals)
9723         (remote_target::program_signals): Adjust.
9724         * target-debug.h (target_debug_print_signals): Now takes a
9725         gdb::array_view as parameter.  Adjust.
9726         * target.h (target_ops) <pass_signals, program_signals>: Replace
9727         pointer and length parameters with gdb::array_view.
9728         (target_pass_signals, target_program_signals): Likewise.
9729         * target-delegates.c: Regenerate.
9730
9731 2019-01-24  Pedro Alves  <palves@redhat.com>
9732
9733         * common/forward-scope-exit.h
9734         (forward_scope_exit::forward_scope_exit): Pass arguments to
9735         m_bind_function directly, instead of creating a std::bind and
9736         copying that.
9737
9738 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9739
9740         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9741         for static members.
9742         (pass_in_v_vfp_candidate): Likewise.
9743
9744 2019-01-23  Tom Tromey  <tom@tromey.com>
9745             Pedro Alves  <palves@redhat.com>
9746
9747         * regcache.c (class regcache_invalidator): Remove.
9748         (regcache::raw_write): Use make_scope_exit.
9749
9750 2019-01-23  Tom Tromey  <tom@tromey.com>
9751
9752         * ui-out.h (class ui_out_emit_type): Update comment.
9753
9754 2019-01-23  Tom Tromey  <tom@tromey.com>
9755
9756         * infrun.c (fetch_inferior_event): Update comment.
9757
9758 2019-01-23  Tom Tromey  <tom@tromey.com>
9759             Pedro Alves  <palves@redhat.com>
9760
9761         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9762         parameter.
9763         (fetch_inferior_event): Use SCOPE_EXIT.
9764
9765
9766 2019-01-23  Tom Tromey  <tom@tromey.com>
9767             Pedro Alves  <palves@redhat.com>
9768
9769         * infrun.c (disable_thread_events): Delete.
9770         (stop_all_threads): Use SCOPE_EXIT.
9771
9772 2019-01-23  Tom Tromey  <tom@tromey.com>
9773             Pedro Alves  <palves@redhat.com>
9774
9775         * symfile.c: Include forward-scope-exit.h.
9776         (clear_symtab_users_cleanup): Replace forward declaration with
9777         a FORWARD_SCOPE_EXIT.
9778         (syms_from_objfile_1): Use the forward_scope_exit and
9779         gdb::optional instead of cleanup_function.
9780         (reread_symbols): Use the forward_scope_exit instead of
9781         cleanup_function.
9782         (clear_symtab_users_cleanup): Remove function.
9783
9784 2019-01-23  Tom Tromey  <tom@tromey.com>
9785             Pedro Alves  <palves@redhat.com>
9786
9787         * linux-nat.c: Include scope-exit.h.
9788         (cleanup_target_stop): Remove.
9789         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9790         SCOPE_EXIT.
9791
9792 2019-01-23  Tom Tromey  <tom@tromey.com>
9793             Pedro Alves  <palves@redhat.com>
9794
9795         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9796         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9797
9798 2019-01-23  Tom Tromey  <tom@tromey.com>
9799             Andrew Burgess  <andrew.burgess@embecosm.com>
9800             Pedro Alves  <palves@redhat.com>
9801
9802         * infrun.c (fetch_inferior_event): Use scope_exit.
9803         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9804         * top.c (execute_command): Use scope_exit.
9805         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9806         * utils.c (do_bpstat_clear_actions_cleanup)
9807         (make_bpstat_clear_actions_cleanup): Remove.
9808
9809 2019-01-23  Tom Tromey  <tom@tromey.com>
9810             Pedro Alves  <palves@redhat.com>
9811
9812         * infrun.c: Include "common/scope-exit.h"
9813         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9814         (wait_for_inferior): Use SCOPE_EXIT.
9815         (fetch_inferior_event): Use scope_exit.
9816
9817 2019-01-23  Tom Tromey  <tom@tromey.com>
9818             Pedro Alves  <palves@redhat.com>
9819
9820         * breakpoint.c (create_breakpoint): Remove cleanup.
9821
9822 2019-01-23  Tom Tromey  <tom@tromey.com>
9823             Andrew Burgess  <andrew.burgess@embecosm.com>
9824             Pedro Alves  <palves@redhat.com>
9825
9826 2019-01-23  Pedro Alves  <palves@redhat.com>
9827
9828         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9829
9830 2019-01-23  Pedro Alves  <palves@redhat.com>
9831             Andrew Burgess  <andrew.burgess@embecosm.com>
9832
9833         * gdbthread.h: Include "common/forward-scope-exit.h".
9834         (scoped_finish_thread_state): Redefine custom class in terms of
9835         forward_scope_exit.
9836
9837 2019-01-23  Pedro Alves  <palves@redhat.com>
9838             Andrew Burgess  <andrew.burgess@embecosm.com>
9839
9840         * common/forward-scope-exit.h: New file.
9841
9842 2019-01-23  Pedro Alves  <palves@redhat.com>
9843             Andrew Burgess  <andrew.burgess@embecosm.com>
9844             Tom Tromey  <tom@tromey.com>
9845
9846         * common/scope-exit.h: New file.
9847
9848 2019-01-23  Pedro Alves  <palves@redhat.com>
9849
9850         * common/preprocessor.h (ESC): Rename to ...
9851         (ESC_PARENS): ... this.
9852         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9853         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9854
9855 2019-01-23  Tom Tromey  <tom@tromey.com>
9856
9857         * language.h (class scoped_switch_to_sym_language_if_auto):
9858         Initialize m_lang in both cases.
9859
9860 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9861
9862         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9863         with XCNEW.
9864
9865 2019-01-22  Tom Tromey  <tom@tromey.com>
9866
9867         * corelow.c: Do not include sys/file.h.
9868
9869 2019-01-22  Tom Tromey  <tom@tromey.com>
9870
9871         * tui/tui-wingeneral.h: Include gdb_curses.h.
9872
9873 2019-01-22  Tom Tromey  <tom@tromey.com>
9874
9875         * source-cache.h (class source_cache) <get_source_lines,
9876         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9877
9878 2019-01-22  Tom Tromey  <tom@tromey.com>
9879
9880         * remote-fileio.h (struct remote_target): Declare.
9881
9882 2019-01-22  Tom Tromey  <tom@tromey.com>
9883
9884         * python/py-arch.c: Do not include py-ref.h.
9885         * python/py-bpevent.c: Do not include py-ref.h.
9886         * python/py-cmd.c: Do not include py-ref.h.
9887         * python/py-continueevent.c: Do not include py-ref.h.
9888         * python/py-event.h: Do not include py-ref.h.
9889         * python/py-evtregistry.c: Do not include py-ref.h.
9890         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9891         * python/py-frame.c: Do not include py-ref.h.
9892         * python/py-framefilter.c: Do not include py-ref.h.
9893         * python/py-function.c: Do not include py-ref.h.
9894         * python/py-infevents.c: Do not include py-ref.h.
9895         * python/py-linetable.c: Do not include py-ref.h.
9896         * python/py-objfile.c: Do not include py-ref.h.
9897         * python/py-param.c: Do not include py-ref.h.
9898         * python/py-prettyprint.c: Do not include py-ref.h.
9899         * python/py-progspace.c: Do not include py-ref.h.
9900         * python/py-symbol.c: Do not include py-ref.h.
9901         * python/py-symtab.c: Do not include py-ref.h.
9902         * python/py-type.c: Do not include py-ref.h.
9903         * python/py-unwind.c: Do not include py-ref.h.
9904         * python/py-utils.c: Do not include py-ref.h.
9905         * python/py-value.c: Do not include py-ref.h.
9906         * python/py-varobj.c: Do not include py-ref.h.
9907         * python/py-xmethods.c: Do not include py-ref.h.
9908         * python/python.c: Do not include py-ref.h.
9909         * varobj.c: Do not include py-ref.h.
9910
9911 2019-01-22  Tom Tromey  <tom@tromey.com>
9912
9913         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9914         keyword for bcache.
9915
9916 2019-01-22  Tom Tromey  <tom@tromey.com>
9917
9918         * compile/compile-cplus-types.c: Remove a comment by #include.
9919
9920 2019-01-22  Tom Tromey  <tom@tromey.com>
9921
9922         * compile/gcc-c-plugin.h: Include compile-internal.h.
9923
9924 2019-01-22  Tom Tromey  <tom@tromey.com>
9925
9926         * stabsread.c (EXTERN): Do not define.
9927         (symnum, next_symbol_text_func, processing_gcc_compilation)
9928         (within_function, global_sym_chain, global_stabs)
9929         (previous_stab_code, this_object_header_files)
9930         (n_this_object_header_files)
9931         (n_allocated_this_object_header_files): Define.
9932         * stabsread.h (EXTERN): Never define.  Use "extern".
9933
9934 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9935
9936         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9937         history_value.
9938
9939 2019-01-21  Tom Tromey  <tom@tromey.com>
9940
9941         * ui-out.c: Fix includes.
9942         * tui/tui-source.c: Fix includes.
9943         * target.c: Fix includes.
9944         * remote.c: Fix includes.
9945         * regcache.c: Fix includes.
9946         * python/py-block.c: Fix includes.
9947         * printcmd.c: Fix includes.
9948         * or1k-tdep.c: Fix includes.
9949         * mi/mi-main.c: Fix includes.
9950         * m32r-tdep.c: Fix includes.
9951         * csky-tdep.c: Fix includes.
9952         * compile/compile-cplus-types.c: Fix includes.
9953         * cli/cli-interp.c: Fix includes.
9954
9955 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9956
9957         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9958         for padding.
9959
9960 2019-01-16  Tom Tromey  <tom@tromey.com>
9961
9962         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9963         earlier.
9964         (struct objfile) <msymbols_range>: Move from top level.
9965         <msymbols>: New method.
9966         (class objfile_msymbols): Remove.
9967         * symtab.c (default_collect_symbol_completion_matches_break_on):
9968         Update.
9969         * symmisc.c (dump_msymbols): Update.
9970         * stabsread.c (scan_file_globals): Update.
9971         * objc-lang.c (info_selectors_command, info_classes_command)
9972         (find_methods): Update.
9973         * minsyms.c (find_solib_trampoline_target): Update.
9974         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9975         * coffread.c (coff_symfile_read): Update.
9976         * ada-lang.c (ada_lookup_simple_minsym)
9977         (ada_collect_symbol_completion_matches): Update.
9978
9979 2019-01-16  Tom Tromey  <tom@tromey.com>
9980
9981         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9982         type.  Remove no-argument constructor.
9983         <iterator::operator++>: Simplify.
9984         <begin>: Update.
9985         <end>: Use minimal_symbol_count.
9986
9987 2019-01-16  Tom Tromey  <tom@tromey.com>
9988
9989         * objfiles.h (struct objfile) <psymtabs>: New method.
9990         (class objfile_psymtabs): Remove.
9991         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9992         typedef.
9993         <range>: New method.
9994         (require_partial_symbols): Change return type.
9995         * psymtab.c (require_partial_symbols)
9996         (psym_expand_symtabs_matching): Update.
9997         * mdebugread.c (parse_partial_symbols): Update.
9998         * dbxread.c (dbx_end_psymtab): Update.
9999
10000 2019-01-15  Tom Tromey  <tom@tromey.com>
10001
10002         * symtab.c (lookup_objfile_from_block)
10003         (lookup_symbol_in_objfile_symtabs)
10004         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10005         (find_line_symtab, info_sources_command)
10006         (default_collect_symbol_completion_matches_break_on)
10007         (make_source_files_completion_list): Update.
10008         * symmisc.c (print_objfile_statistics, dump_objfile)
10009         (maintenance_print_symbols, maintenance_info_symtabs)
10010         (maintenance_check_symtabs, maintenance_info_line_tables):
10011         Update.
10012         * source.c (select_source_symtab)
10013         (forget_cached_source_info_for_objfile): Update.
10014         * objfiles.h (class objfile_compunits): Remove.
10015         (struct objfile) <compunits_range>: New typedef.
10016         (compunits): New method.
10017         * objfiles.c (objfile_relocate1): Update.
10018         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10019         * maint.c (count_symtabs_and_blocks): Update.
10020         * linespec.c (iterate_over_all_matching_symtabs): Update.
10021         * cp-support.c (add_symbol_overload_list_qualified): Update.
10022         * coffread.c (coff_symtab_read): Update.
10023         * ada-lang.c (add_nonlocal_symbols)
10024         (ada_collect_symbol_completion_matches)
10025         (ada_add_global_exceptions): Update.
10026
10027 2019-01-15  Tom Tromey  <tom@tromey.com>
10028
10029         * progspace.h (program_space) <objfiles_safe_range>: New
10030         typedef.
10031         <objfiles_safe>: New method.
10032         * objfiles.h (class all_objfiles_safe): Remove.
10033         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10034         * jit.c (jit_inferior_exit_hook): Update.
10035
10036 2019-01-17  Tom Tromey  <tom@tromey.com>
10037
10038         * progspace.h (program_space) <objfiles_range>: New typedef.
10039         <objfiles>: New method.
10040         <objfiles_head>: Rename from objfiles.
10041         (object_files): Update.
10042         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10043         * guile/scm-pretty-print.c
10044         (ppscm_find_pretty_printer_from_objfiles): Update.
10045         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10046         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10047         Update.
10048         * python/py-progspace.c (pspy_get_objfiles): Update.
10049         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10050         Update.
10051         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10052         (objfpy_lookup_objfile_by_build_id): Update.
10053         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10054         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10055         Update.
10056         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10057         (expand_symtab_containing_pc, lookup_objfile_from_block)
10058         (lookup_static_symbol, basic_lookup_transparent_type)
10059         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10060         (find_line_symtab, info_sources_command)
10061         (default_collect_symbol_completion_matches_break_on)
10062         (make_source_files_completion_list, find_main_name): Update.
10063         * symmisc.c (print_symbol_bcache_statistics)
10064         (print_objfile_statistics, maintenance_print_symbols)
10065         (maintenance_print_msymbols, maintenance_print_objfiles)
10066         (maintenance_info_symtabs, maintenance_check_symtabs)
10067         (maintenance_expand_symtabs, maintenance_info_line_tables):
10068         Update.
10069         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10070         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10071         (map_overlay_command, unmap_overlay_command)
10072         (simple_overlay_update, expand_symtabs_matching)
10073         (map_symbol_filenames): Update.
10074         * symfile-debug.c (set_debug_symfile): Update.
10075         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10076         Update.
10077         * source.c (select_source_symtab, forget_cached_source_info):
10078         Update.
10079         * solib.c (solib_read_symbols): Update.
10080         * solib-spu.c (append_ocl_sos): Update.
10081         * psymtab.c (maintenance_print_psymbols)
10082         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10083         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10084         * printcmd.c (info_symbol_command): Update.
10085         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10086         Update.
10087         * objfiles.h (class all_objfiles): Remove.
10088         * objfiles.c (have_partial_symbols, have_full_symbols)
10089         (have_minimal_symbols, qsort_cmp, update_section_map)
10090         (shared_objfile_contains_address_p)
10091         (default_iterate_over_objfiles_in_search_order): Update.
10092         * objc-lang.c (info_selectors_command, info_classes_command)
10093         (find_methods): Update.
10094         * minsyms.c (find_solib_trampoline_target): Update.
10095         * maint.c (maintenance_info_sections)
10096         (maintenance_translate_address, count_symtabs_and_blocks):
10097         Update.
10098         * main.c (captured_main_1): Update.
10099         * linux-thread-db.c (try_thread_db_load_from_pdir)
10100         (has_libpthread): Update.
10101         * linespec.c (iterate_over_all_matching_symtabs)
10102         (search_minsyms_for_name): Update.
10103         * jit.c (jit_find_objf_with_entry_addr): Update.
10104         * hppa-tdep.c (find_unwind_entry)
10105         (hppa_lookup_stub_minimal_symbol): Update.
10106         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10107         Update.
10108         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10109         (elf_gnu_ifunc_resolve_by_got): Update.
10110         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10111         * dwarf-index-write.c (save_gdb_index_command): Update.
10112         * cp-support.c (add_symbol_overload_list_qualified): Update.
10113         * breakpoint.c (create_overlay_event_breakpoint)
10114         (create_longjmp_master_breakpoint)
10115         (create_std_terminate_master_breakpoint)
10116         (create_exception_master_breakpoint): Update.
10117         * blockframe.c (find_pc_partial_function): Update.
10118         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10119         (ada_collect_symbol_completion_matches)
10120         (ada_add_global_exceptions): Update.
10121
10122 2019-01-17  Tom Tromey  <tom@tromey.com>
10123
10124         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10125         declare VEC.
10126         (solib_target_parse_libraries): Change return type.
10127         (library_list_start_segment, library_list_start_section)
10128         (library_list_end_library, library_list_start_library); Update.
10129         (solib_target_free_library_list): Remove.
10130         (solib_target_parse_libraries): Remove cleanup.  Change return
10131         type.
10132         (solib_target_current_sos): Update.
10133
10134 2019-01-17  Tom Tromey  <tromey@bapiya>
10135
10136         * valprint.c: Replace "the the" with "the".
10137         * symtab.c: Replace "the the" with "the".
10138         * solib.c: Replace "the the" with "the".
10139         * solib-dsbt.c: Replace "the the" with "the".
10140         * linespec.c: Replace "the the" with "the".
10141         * dwarf2loc.h: Replace "the the" with "the".
10142         * amd64-windows-tdep.c: Replace "the the" with "the".
10143         * aarch64-tdep.c: Replace "the the" with "the".
10144
10145 2019-01-16  Keith Seitz  <keiths@redhat.com>
10146
10147         PR gdb/23773
10148         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10149         <builder>: Rename to ..
10150         <m_builder>: ... this and make private.
10151         (dwarf2_cu::get_builder): New method.  Change all users of
10152         `builder' to use this method.
10153         (dwarf2_start_symtab): Move to ...
10154         (dwarf2_cu::start_symtab): ... here.  Update all callers
10155         (setup_type_unit_groups): Move to ...
10156         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10157         callers.
10158         (dwarf2_cu::reset_builder): New method.
10159         (process_full_compunit, process_full_type_unit): Use
10160         dwarf2_cu::reset_builder.
10161         (follow_die_offset): Record the ancestor CU if it is different
10162         from the followed DIE's CU.
10163         (follow_die_sig_1): Likewise.
10164
10165 2019-01-15  Tom Tromey  <tom@tromey.com>
10166
10167         * remote.c (class remote_state) <buf>: Now a char_vector.
10168         <buf_size>: Remove.
10169         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10170         parameter.
10171         (remote_target::getpkt_or_notif_sane_1)
10172         (remote_target::getpkt_sane)
10173         (remote_target::getpkt_or_notif_sane): Likewise.
10174         (class remote_target) <putpkt>: New overload.
10175         (remote_target::read_frame): Change type of "buf_p".  Remove
10176         sizeof_p parameter.
10177         (packet_ok): New overload.
10178         (packet_check_result): New overload.
10179         Update all uses.
10180
10181 2019-01-14  Tom Tromey  <tom@tromey.com>
10182
10183         * remote-notif.c (handle_notification, remote_notif_ack)
10184         (remote_notif_parse): Make "buf" const.
10185         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10186         const.
10187         (remote_notif_parse, remote_notif_ack, handle_notification):
10188         Likewise.
10189         * remote.c (remote_notif_stop_parse): Make "buf" const.
10190         (remote_target::remote_parse_stop_reply): Make "buf" const.
10191         (remote_notif_stop_ack): Make "buf" const.
10192
10193 2019-01-14  Tom Tromey  <tom@tromey.com>
10194
10195         * remote.c (remote_console_output): Make parameter const.
10196
10197 2019-01-14  Tom Tromey  <tom@tromey.com>
10198
10199         * target-debug.h (target_debug_print_signals): Constify.
10200         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10201         * procfs.c (procfs_target::pass_signals): Update.
10202         * linux-nat.c (linux_nat_target::pass_signals): Update.
10203         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10204         * target-delegates.c: Rebuild.
10205         * remote.c (remote_target::program_signals): Update.
10206         (remote_target::pass_signals): Update.
10207         * target.c (target_pass_signals): Constify argument.
10208         (target_program_signals): Likewise.
10209         * target.h (struct target_ops) <pass_signals, program_signals>:
10210         Constify argument.
10211         (target_pass_signals, target_program_signals): Constify argument.
10212
10213 2019-01-14  Tom Tromey  <tom@tromey.com>
10214
10215         PR tui/28819:
10216         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10217
10218 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10219
10220         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10221         field.
10222         * rs6000-tdep.c: Include reggroups.h.
10223         (IS_V_ALIAS_PSEUDOREG): Define.
10224         (rs6000_register_name): Return names for the "vX" aliases.
10225         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10226         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10227         aliases.  Call default_register_reggroup_p for all other
10228         pseudo-registers.
10229         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10230         New functions.
10231         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10232         Handle "vX" aliases.
10233         (v_alias_pseudo_register_collect): New function.
10234         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10235         (rs6000_gdbarch_init): Initialize "vX" aliases as
10236         pseudo-registers.  Restore registration of
10237         rs6000_pseudo_register_reggroup_p with
10238         set_tdesc_pseudo_register_reggroup_p.
10239
10240 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10241
10242         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10243         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10244         set_gdbarch_num_pseudo_regs.
10245
10246 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10247
10248         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10249         Remove arg prefixname, add do_set and do_show.
10250         Add member functions set_list and show_list.
10251         * cli/cli-style.c (class cli_style_option): Update accordingly.
10252         (style_set_list): Move to file scope.
10253         (style_show_list): Likewise.
10254         (set_style): Call help_list.
10255         (show_style): Call cmd_show_list.
10256         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10257         Update to use the new macro.
10258
10259 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10260
10261         * ada-lang.c (_initialize_ada_language): Expand the help text
10262         for the "catch exception" command.
10263
10264 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10265
10266         * symtab.c (matching_obj_sections): Initialize obj,
10267         declare it closer to its usage.
10268
10269 2019-01-10  Tom Tromey  <tom@tromey.com>
10270
10271         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10272         (basic_inf_threads_range): Remove.
10273         (inf_threads_range, inf_non_exited_threads_range)
10274         (safe_inf_threads_range): Use next_adapter.
10275
10276 2019-01-10  Keith Seitz  <keiths@redhat.com>
10277
10278         PR gdb/23712
10279         PR symtab/23010
10280         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10281         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10282
10283 2019-01-10  Keith Seitz  <keiths@redhat.com>
10284
10285         PR gdb/23712
10286         PR symtab/23010
10287         * dictionary.c (pending_to_vector): Remove.
10288         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10289         Remove _1 suffix, replacing functions of the same name.  Update
10290         all callers.
10291         (dict_create_hashed, dict_create_hashed_expandable)
10292         (dict_create_linear, dict_create_linear_expandable, dict_free)
10293         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10294         Make functions static.
10295
10296 2019-01-10  Keith Seitz  <keiths@redhat.com>
10297
10298         PR gdb/23712
10299         PR symtab/23010
10300         * dictionary.h (struct dictionary): Replace declaration with
10301         multidictionary.
10302         (dict_create_hashed, dict_create_hashed_expandable)
10303         (dict_create_linear, dict_create_linear_expandable)
10304         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10305         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10306         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10307         taking multidictionary argument.
10308         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10309         * block.h (struct block) <dict>: Change to multidictionary
10310         and rename `multidict'.
10311         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10312         symmisc.c: Update all dictionary references to multidictionary.
10313
10314 2019-01-10  Keith Seitz  <keiths@redhat.com>
10315
10316         PR gdb/23712
10317         PR symtab/23010
10318         * dictionary.c: Include unordered_map.
10319         (pending_to_vector): New function.
10320         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10321         Rewrite the non-"_1" functions to take vector instead
10322         of linked list.
10323         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10324         "new" _1 versions of the same name.
10325         (multidictionary): Define.
10326         (std::hash<enum language): New definition.
10327         (collate_pending_symbols_by_language, mdict_create_hashed)
10328         (mdict_create_hashed_expandable, mdict_create_linear)
10329         (mdict_create_linear_expandable, mdict_free)
10330         (find_language_dictionary, create_new_language_dictionary)
10331         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10332         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10333         (mdict_size, mdict_empty): New functions.
10334         * dictionary.h (mdict_iterator): Define.
10335
10336 2019-01-10  Pedro Alves  <palves@redhat.com>
10337
10338         * breakpoint.c (read_uploaded_action)
10339         (create_tracepoint_from_upload): Adjust to use
10340         gdb::unique_xmalloc_ptr.
10341         * ctf.c (ctf_write_uploaded_tp):
10342         (SET_ARRAY_FIELD): Use emplace_back.
10343         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10344         * tracefile-tfile.c (tfile_write_uploaded_tp):
10345         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10346         gdb::unique_xmalloc_ptr.
10347         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10348         at_string, cond_string, cmd_strings>: Replace char pointers
10349         with gdb::unique_xmalloc_ptr.
10350
10351 2019-01-10  Pedro Alves  <palves@redhat.com>
10352
10353         * solib-target.c (library_list_start_library): Don't xstrdup name.
10354
10355 2019-01-10  Pedro Alves  <palves@redhat.com>
10356
10357         * mdebugread.c (parse_partial_symbols): Use
10358         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10359
10360 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10361
10362         * linux-fork.c (scoped_switch_fork_info)
10363         <~scoped_switch_fork_info>: Fix incorrect variable name.
10364
10365 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10366
10367         * linux-fork.c (scoped_switch_fork_info)
10368         <scoped_switch_fork_info>: Make explicit.
10369         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10370
10371 2019-01-10  Tom Tromey  <tom@tromey.com>
10372
10373         * objfiles.h (objfile::reset_psymtabs): Update.
10374         * objfiles.c (objfile::objfile): Update.
10375         * psymtab.h (psymtab_storage::obstack): Update.
10376         (psymtab_storage::m_obstack): Use gdb::optional.
10377         (class psymtab_storage): Update comment.  Remove objfile
10378         parameter.
10379         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10380
10381 2019-01-10  Tom Tromey  <tom@tromey.com>
10382
10383         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10384         <free_psymtabs>: Now private.
10385         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10386         (allocate_psymtab): Use new method.
10387
10388 2019-01-10  Tom Tromey  <tom@tromey.com>
10389
10390         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10391         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10392         * mdebugread.c (parse_partial_symbols): Use
10393         allocate_dependencies.
10394         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10395         allocate_dependencies.
10396         (process_psymtab_comp_unit_reader)
10397         (build_type_psymtab_dependencies): Likewise.
10398         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10399
10400 2019-01-10  Tom Tromey  <tom@tromey.com>
10401
10402         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10403         PSYMBOL_SET_LANGUAGE.
10404         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10405
10406 2019-01-10  Tom Tromey  <tom@tromey.com>
10407
10408         * psymtab.h (psymtab_storage::obstack): New method.
10409         <m_obstack>: Rename from obstack; now private.
10410         * psymtab.c (psymtab_storage): Update.
10411         * dwarf2read.c (create_addrmap_from_index)
10412         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10413         Update.
10414
10415 2019-01-10  Tom Tromey  <tom@tromey.com>
10416
10417         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10418         * objfiles.h (objfile::reset_psymtabs): New method.
10419
10420 2019-01-10  Tom Tromey  <tom@tromey.com>
10421
10422         * symmisc.c (print_symbol_bcache_statistics): Update.
10423         (print_objfile_statistics): Update.
10424         * symfile.c (reread_symbols): Update.
10425         * psymtab.h (class psymtab_storage): New.
10426         * psymtab.c (psymtab_storage): New constructor.
10427         (~psymtab_storage): New destructor.
10428         (require_partial_symbols): Update.
10429         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10430         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10431         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10432         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10433         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10434         (start_psymtab_common, end_psymtab_common)
10435         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10436         (allocate_psymtab): Update.
10437         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10438         Update.
10439         (dump_psymtab_addrmap, maintenance_print_psymbols)
10440         (maintenance_check_psymtabs): Update.
10441         (class objfile_psymtabs): Move to objfiles.h.
10442         * psympriv.h (discard_psymtab): Now inline.
10443         (psymtab_discarder::psymtab_discarder): Update.
10444         (psymtab_discarder::~psymtab_discarder): Update.
10445         (ALL_OBJFILE_PSYMTABS): Rewrite.
10446         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10447         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10448         Remove fields.
10449         <partial_symtabs>: New field.
10450         (class objfile_psymtabs): Move from psymtab.h.  Update.
10451         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10452         psymbol_cache.
10453         (objfile::~objfile): Don't destroy psymbol_cache.
10454         * mdebugread.c (parse_partial_symbols): Update.
10455         * dwarf2read.c (create_addrmap_from_index)
10456         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10457         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10458         (add_partial_subprogram, dwarf2_ranges_read): Update.
10459         * dwarf-index-write.c (write_address_map)
10460         (write_one_signatured_type, recursively_write_psymbols)
10461         (class debug_names, class debug_names, write_psymtabs_to_index):
10462         Update.
10463
10464 2019-01-10  Tom Tromey  <tom@tromey.com>
10465
10466         * symtab.h (SYMBOL_SET_NAMES): Update.
10467         (symbol_set_names): Update.
10468         (MSYMBOL_SET_NAMES): Update.
10469         * symtab.c (symbol_set_names): Change argument to be an
10470         objfile_per_bfd_storage.
10471         * psymtab.c (add_psymbol_to_bcache): Update.
10472         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10473
10474 2019-01-10  Tom Tromey  <tom@tromey.com>
10475
10476         * symtab.c (create_demangled_names_hash): Change argument to be an
10477         objfile_per_bfd_storage.
10478         (symbol_set_names): Update.
10479
10480 2019-01-10  Tom Tromey  <tom@tromey.com>
10481
10482         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10483         init_psymbol_list.
10484         * psymtab.c (init_psymbol_list): Do nothing if already called.
10485         * psympriv.h (init_psymbol_list): Add comment.
10486         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10487         init_psymbol_list.
10488         * dbxread.c (dbx_symfile_read): Unconditionally call
10489         init_psymbol_list.
10490
10491 2019-01-10  Tom Tromey  <tom@tromey.com>
10492
10493         * xcoffread.c (scan_xcoff_symtab): Update.
10494         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10495         "where".
10496         * mdebugread.c (parse_partial_symbols)
10497         (handle_psymbol_enumerators): Update.
10498         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10499         * dbxread.c (read_dbx_symtab): Update.
10500         * psympriv.h (psymbol_placement): New enum.
10501         (add_psymbol_to_list): Update.
10502
10503 2019-01-10  Tom Tromey  <tom@tromey.com>
10504
10505         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10506         static_psymbols parameters.
10507         (scan_xcoff_symtab): Update.
10508         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10509         static_psymbols parameters.
10510         * psympriv.h (start_psymtab_common): Update.
10511         * mdebugread.c (parse_partial_symbols): Update.
10512         * dwarf2read.c (create_partial_symtab): Update.
10513         * dbxread.c (read_dbx_symtab): Update.
10514         (start_psymtab): Remove global_psymbols and static_psymbols
10515         parameters.
10516
10517 2019-01-10  Tom Tromey  <tom@tromey.com>
10518
10519         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10520         * psymtab.c (allocate_psymtab): Add comment.
10521         * psympriv.h (allocate_psymtab): Add comment.
10522         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10523         initializations.
10524         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10525
10526 2019-01-10  Tom Tromey  <tom@tromey.com>
10527
10528         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10529         Don't declare.
10530         * mipsread.c: Include mdebugread.h.
10531         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10532         Declare.
10533         * elfread.c: Include mdebugread.h.
10534
10535 2019-01-09  Tom Tromey  <tom@tromey.com>
10536
10537         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10538         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10539         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10540         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10541         (psym_lookup_symbol, psym_find_last_source_symtab)
10542         (psym_forget_cached_source_info, psym_print_stats)
10543         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10544         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10545         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10546         (psym_find_compunit_symtab_by_address)
10547         (maintenance_print_psymbols, maintenance_info_psymtabs)
10548         (maintenance_check_psymtabs): Use ranged for.
10549         * psymtab.h (class objfile_psymtabs): New.
10550         (require_partial_symbols): Return objfile_psymtabs.
10551         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10552
10553 2019-01-09  Tom Tromey  <tom@tromey.com>
10554
10555         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10556         (find_pc_mapped_section, list_overlays_command)
10557         (map_overlay_command, unmap_overlay_command)
10558         (simple_overlay_update): Use all_objfiles.
10559         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10560         * printcmd.c (info_symbol_command): Use all_objfiles.
10561         * objfiles.h (ALL_OBJSECTIONS): Remove.
10562         * maint.c (maintenance_translate_address): Use all_objfiles.
10563         * gcore.c (gcore_create_callback): Use all_objfiles.
10564         (objfile_find_memory_regions): Likewise.
10565
10566 2019-01-09  Tom Tromey  <tom@tromey.com>
10567
10568         * symtab.c (find_line_symtab, info_sources_command)
10569         (make_source_files_completion_list): Use objfile_compunits.
10570         * source.c (select_source_symtab): Use objfile_compunits.
10571         * objfiles.h (struct objfile): Update comment.
10572         (ALL_OBJFILES): Remove.
10573         (ALL_FILETABS): Remove.
10574         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10575         objfile_compunits.
10576
10577 2019-01-09  Tom Tromey  <tom@tromey.com>
10578
10579         * symmisc.c (print_objfile_statistics, dump_objfile)
10580         (maintenance_print_symbols): Use compunit_filetabs.
10581         * source.c (forget_cached_source_info_for_objfile): Use
10582         compunit_filetabs.
10583         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10584         (ALL_FILETABS): Use compunit_filetabs.
10585         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10586         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10587
10588 2019-01-09  Tom Tromey  <tom@tromey.com>
10589
10590         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10591         (compunit_filetabs): New.
10592         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10593         compunit_filetabs.
10594         (info_sources_command, make_source_files_completion_list): Remove
10595         declaration.
10596         * symmisc.c (print_objfile_statistics, dump_objfile)
10597         (maintenance_print_symbols): Remove declaration.
10598         (maintenance_info_symtabs): Use compunit_filetabs.
10599         (maintenance_info_line_tables): Likewise.
10600         * source.c (select_source_symtab): Change local variable name.
10601         (forget_cached_source_info_for_objfile): Remove declaration.
10602         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10603         * objfiles.c (objfile_relocate1): Remove declaration.
10604         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10605         declaration.
10606         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10607         * coffread.c (coff_symtab_read): Remove declaration.
10608         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10609         compunit_filetabs.
10610
10611 2019-01-09  Tom Tromey  <tom@tromey.com>
10612
10613         * symtab.c (lookup_objfile_from_block)
10614         (find_pc_sect_compunit_symtab, search_symbols)
10615         (default_collect_symbol_completion_matches_break_on): Use
10616         objfile_compunits.
10617         * objfiles.h (ALL_COMPUNITS): Remove.
10618         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10619         * cp-support.c (add_symbol_overload_list_qualified): Use
10620         objfile_compunits.
10621         * ada-lang.c (ada_collect_symbol_completion_matches)
10622         (ada_add_global_exceptions): Use objfile_compunits.
10623
10624 2019-01-09  Tom Tromey  <tom@tromey.com>
10625
10626         * source.c (select_source_symtab)
10627         (forget_cached_source_info_for_objfile): Remove declaration.
10628         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10629         declaration.
10630         * maint.c (count_symtabs_and_blocks): Remove declaration.
10631         * cp-support.c (add_symbol_overload_list_qualified): Remove
10632         declaration.
10633         * coffread.c (coff_symtab_read): Remove declaration.
10634         * symtab.c (lookup_symbol_in_objfile_symtabs)
10635         (basic_lookup_transparent_type_1): Use objfile_compunits.
10636         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10637         (info_sources_command, search_symbols)
10638         (default_collect_symbol_completion_matches_break_on)
10639         (make_source_files_completion_list): Remove declaration.
10640         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10641         (ada_collect_symbol_completion_matches)
10642         (ada_add_global_exceptions): Remove declaration.
10643         * linespec.c (iterate_over_all_matching_symtabs): Use
10644         objfile_compunits.
10645         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10646         (class objfile_compunits): New.
10647         (ALL_COMPUNITS): Use objfile_compunits.
10648         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10649         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10650         objfile_compunits.
10651         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10652
10653 2019-01-09  Tom Tromey  <tom@tromey.com>
10654
10655         * symtab.c (search_symbols)
10656         (default_collect_symbol_completion_matches_break_on): Use
10657         objfile_msymbols.
10658         * ada-lang.c (ada_lookup_simple_minsym)
10659         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10660         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10661         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10662         objfile_msymbols.
10663         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10664         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10665         * objc-lang.c (find_methods): Use objfile_msymbols.
10666         (info_selectors_command, info_classes_command): Likewise.
10667         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10668         * objfiles.h (class objfile_msymbols): New.
10669         (ALL_OBJFILE_MSYMBOLS): Remove.
10670         (ALL_MSYMBOLS): Remove.
10671
10672 2019-01-09  Tom Tromey  <tom@tromey.com>
10673
10674         * common/next-iterator.h (next_adapter): Add Iterator template
10675         parameter.
10676         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10677         (class all_objfiles_safe): New.
10678         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10679         * objfiles.c (put_objfile_before): Update comment.
10680         (add_separate_debug_objfile): Likewise.
10681         (free_all_objfiles): Use all_objfiles_safe.
10682         (objfile_purge_solibs): Likewise.
10683
10684 2019-01-09  Tom Tromey  <tom@tromey.com>
10685
10686         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10687         (expand_symtab_containing_pc, lookup_static_symbol)
10688         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10689         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10690         all_objfiles.
10691         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10692         * breakpoint.c (create_overlay_event_breakpoint)
10693         (create_longjmp_master_breakpoint)
10694         (create_std_terminate_master_breakpoint)
10695         (create_exception_master_breakpoint): Use all_objfiles.
10696         * linux-thread-db.c (try_thread_db_load_from_pdir)
10697         (has_libpthread): Use all_objfiles.
10698         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10699         * linespec.c (iterate_over_all_matching_symtabs)
10700         (search_minsyms_for_name): Use all_objfiles.
10701         * maint.c (maintenance_info_sections): Use all_objfiles.
10702         * main.c (captured_main_1): Use all_objfiles.
10703         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10704         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10705         * guile/scm-pretty-print.c
10706         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10707         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10708         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10709         (maintenance_print_msymbols): Use all_objfiles.
10710         * source.c (select_source_symtab): Use all_objfiles.
10711         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10712         * symfile.c (remove_symbol_file_command)
10713         (expand_symtabs_matching, map_symbol_filenames): Use
10714         all_objfiles.
10715         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10716         all_objfiles.
10717         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10718         * objc-lang.c (find_methods): Use all_objfiles.
10719         * objfiles.c (have_partial_symbols, have_full_symbols)
10720         (have_minimal_symbols, qsort_cmp)
10721         (default_iterate_over_objfiles_in_search_order): Use
10722         all_objfiles.
10723         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10724         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10725         (maintenance_check_psymtabs): Use all_objfiles.
10726         (ALL_PSYMTABS): Remove.
10727         * compile/compile-object-run.c (do_module_cleanup): Use
10728         all_objfiles.
10729         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10730         * cp-support.c (add_symbol_overload_list_qualified): Use
10731         all_objfiles.
10732         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10733         Use all_objfiles.
10734         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10735         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10736         all_objfiles.
10737         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10738         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10739         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10740         Uses all_objfiles.
10741         * solib.c (solib_read_symbols): Use all_objfiles
10742
10743 2019-01-09  Tom Tromey  <tom@tromey.com>
10744
10745         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10746         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10747         all_objfiles.
10748         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10749         * symmisc.c (print_symbol_bcache_statistics)
10750         (print_objfile_statistics, maintenance_print_objfiles)
10751         (maintenance_info_symtabs, maintenance_check_symtabs)
10752         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10753         all_objfiles.
10754         * source.c (forget_cached_source_info): Use all_objfiles.
10755         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10756         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10757         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10758         * objfiles.c (update_section_map): Use all_objfiles.
10759         (shared_objfile_contains_address_p): Likewise.
10760         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10761         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10762
10763 2019-01-09  Tom Tromey  <tom@tromey.com>
10764
10765         * common/next-iterator.h: New file.
10766         * objfiles.h (class all_objfiles): New.
10767         (struct objfile_iterator): New.
10768
10769 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10770
10771         * NEWS: Move the description of the changed "frame", "select-frame",
10772          and "info frame" commands to the Changed commands section.
10773
10774 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10775
10776         * gdbtypes.c (check_stub_method_group): Remove handling of old
10777         mangling schemes.
10778         * linespec.c (find_methods): Likewise.
10779         * stabsread.c (read_member_functions): Likewise.
10780         * valops.c (search_struct_method): Likewise.
10781         (value_struct_elt_for_reference): Likewise.
10782         * NEWS: Mention this change.
10783
10784 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10785
10786         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10787         print_source_lines.
10788         * source.c (print_source_lines_base): Update line number check.
10789         (print_source_lines): New function.
10790         (source_lines_range::source_lines_range): New function.
10791         * source.h (class source_lines_range): New class.
10792         (print_source_lines): New declaration.
10793
10794 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10795
10796         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10797
10798 2019-01-08  Tom Tromey  <tom@tromey.com>
10799             Simon Marchi  <simon.marchi@ericsson.com>
10800
10801         PR gdb/24060
10802         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10803         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10804         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10805         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10806         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10807         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10808
10809 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10810
10811         * source.c (select_source_symtab): Move header comment to
10812         declaration in source.h.
10813         (forget_cached_source_info_for_objfile): Likewise.
10814         (forget_cached_source_info): Likewise.
10815         (identify_source_line): Likewise.
10816         * source.h (identify_source_line): Move declaration from symtab.h
10817         and add comment from source.c
10818         (print_source_lines): Likewise.
10819         (forget_cached_source_info_for_objfile): Likewise.
10820         (forget_cached_source_info): Likewise.
10821         (select_source_symtab): Likewise.
10822         (enum print_source_lines_flag): Move definition from symtab.h.
10823         * symtab.h (identify_source_line): Move declaration to source.h.
10824         (print_source_lines): Likewise.
10825         (forget_cached_source_info_for_objfile): Likewise.
10826         (forget_cached_source_info): Likewise.
10827         (select_source_symtab): Likewise.
10828         (enum print_source_lines_flag): Move definition to source.h.
10829         * tui/tui-hooks.c: Add 'source.h' include.
10830
10831 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10832
10833         * source.c (print_source_lines_base): Handle requests to print
10834         reverse line number sequences, and guard against empty lines
10835         string.
10836
10837 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10838
10839         * source.c (print_source_lines_base): Fix skip of '\r' if next
10840         character is '\n'.
10841
10842 2019-01-06  Tom Tromey  <tom@tromey.com>
10843
10844         * c-exp.y (struct c_parse_state) <macro_original_text,
10845         expansion_obstack>: New member.
10846         (macro_original_text, expansion_obstack): Remove globals.
10847         (scan_macro_expansion, scanning_macro_expansion)
10848         (finished_macro_expansion): Update.
10849         (scan_macro_cleanup): Remove.
10850         (yylex, c_parse): Update.
10851
10852 2019-01-06  Tom Tromey  <tom@tromey.com>
10853
10854         * c-exp.y (struct c_parse_state) <strings>: New member.
10855         (operator_stoken): Update.
10856
10857 2019-01-06  Tom Tromey  <tom@tromey.com>
10858
10859         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10860         (union type_stack_elt) <typelist_val>: Now a pointer to
10861         std::vector.
10862         (type_stack_cleanup): Don't declare.
10863         (push_typelist): Update.
10864         * parse.c (pop_typelist): Return a std::vector.
10865         (push_typelist): Take a std::vector.
10866         (follow_types): Update.  Do not free args.
10867         (type_stack_cleanup): Remove.
10868         * c-exp.y (struct c_parse_state): New.
10869         (cpstate): New global.
10870         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10871         (nonempty_typelist): Update.
10872         (func_mod): Create a new vector.
10873         (c_parse): Create a c_parse_state.
10874         (check_parameter_typelist): Do not delete params.
10875         (function_method): Update.  Do not delete type_list.
10876
10877 2019-01-06  Tom Tromey  <tom@tromey.com>
10878
10879         PR gdb/28155:
10880         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10881         check_typedef.
10882         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10883         (print_return_value): Likewise.
10884
10885 2019-01-05  Tom Tromey  <tom@tromey.com>
10886
10887         * contrib/cleanup_check.py: Remove.
10888         * contrib/gcc-with-excheck: Remove.
10889         * contrib/exsummary.py: Remove.
10890         * contrib/excheck.py: Remove.
10891
10892 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10893
10894         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10895         NULL. Initialize tpprev to NULL instead of assigning it
10896         to NULL on the next statement.
10897         * windows-nat.c (windows_delete_thread): Remove check for
10898         main_thread_id before printing thread exit notifications.
10899         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10900         Remove thread ID check against main_thread_id.
10901         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10902         windows_delete_thread.
10903         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10904
10905 2019-01-04  Tom Tromey  <tom@tromey.com>
10906
10907         * compile/compile.c (_initialize_compile): Use upper case for
10908         metasyntactic variables.
10909         * symmisc.c (_initialize_symmisc): Use upper case for
10910         metasyntactic variables.
10911         * psymtab.c (_initialize_psymtab): Use upper case for
10912         metasyntactic variables.
10913         * demangle.c (demangle_command): Use upper case for metasyntactic
10914         variables.
10915         (_initialize_demangler): Likewise.
10916         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10917         variables.
10918
10919 2019-01-03  Tom Tromey  <tom@tromey.com>
10920
10921         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10922
10923 2019-01-03  Tom Tromey  <tom@tromey.com>
10924
10925         * python/py-symtab.c (salpy_str): Update.
10926         (struct salpy_sal_object) <symtab>: Now a PyObject.
10927         (salpy_dealloc): Update.
10928         (del_objfile_sal): Use gdbpy_ref.
10929
10930 2019-01-03  Tom Tromey  <tom@tromey.com>
10931
10932         * python/py-type.c (convert_field): Use new_reference.  Return
10933         gdbpy_ref.
10934         (make_fielditem): Return gdbpy_ref.
10935         (typy_fields): Update.
10936         (typy_getitem): Update.
10937         (field_name): Return gdbpy_ref.  Use new_reference.
10938         (typy_iterator_iternext): Update.
10939
10940 2019-01-03  Tom Tromey  <tom@tromey.com>
10941
10942         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10943
10944 2019-01-03  Tom Tromey  <tom@tromey.com>
10945
10946         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10947         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10948         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10949         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10950         (pspy_set_type_printers): Likewise.
10951         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10952         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10953         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10954         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10955         (objfpy_set_type_printers): Likewise.
10956
10957 2019-01-03  Tom Tromey  <tom@tromey.com>
10958
10959         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10960         (gdbpy_print_stack): Use gdbpy_err_fetch.
10961         * python/python-internal.h (class gdbpy_err_fetch): New class.
10962         (class gdbpy_enter) <m_error_type, m_error_value,
10963         m_error_traceback>: Remove.
10964         <m_error>: New member.
10965         (gdbpy_exception_to_string): Don't declare.
10966         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10967         * python/py-value.c (convert_value_from_python): Use
10968         gdbpy_err_fetch.
10969         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10970         gdbpy_exception_to_string.
10971         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10972         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10973         gdbpy_err_fetch.
10974
10975 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10976
10977         * linux-nat.c (delete_lwp_cleanup): Delete.
10978         (struct lwp_deleter): New struct.
10979         (lwp_info_up): New typedef.
10980         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10981         lwp_info_up.
10982
10983 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10984
10985         * linux-fork.c (class scoped_switch_fork_info): New class.
10986         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10987
10988 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10989
10990         * valops.c (find_overload_match): Remove use of null_cleanup, and
10991         calls to do_cleanups.
10992
10993 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10994
10995         * compile/compile-cplus-types.c
10996         (compile_cplus_instance::decl_name): Handle changes to
10997         cp_func_name.
10998         * cp-support.c (cp_func_name): Update header comment, update
10999         return type.
11000         * cp-support.h (cp_func_name): Update return type in declaration.
11001         * valops.c (find_overload_match): Move temp_func local to top
11002         level of function and change its type.  Use temp_func to hold and
11003         delete temporary string obtained from cp_func_name.
11004
11005 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11006
11007         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11008         gdb::char_vector, remove cleanup, and update uses of `msg`.
11009
11010 2019-01-03  Jim Wilson  <jimw@sifive.com>
11011
11012         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11013
11014 2019-01-02  Tom Tromey  <tom@tromey.com>
11015
11016         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11017         (tdesc_parse_xml): Remove cleanups.
11018         * target-descriptions.h (make_cleanup_free_target_description):
11019         Don't declare.
11020         (target_desc_deleter): New struct.
11021         (target_desc_up): New typedef.
11022         * target-descriptions.c (target_desc_deleter::operator()): Rename
11023         from free_target_description.
11024         (make_cleanup_free_target_description): Remove.
11025
11026 2019-01-02  Tom Tromey  <tom@tromey.com>
11027
11028         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11029         constructor, destructor.
11030         (linespec_parser): Remove typedef.
11031         (~linespec_parser): Rename from linespec_parser_delete.
11032         (linespec_lex_to_end, linespec_complete_label)
11033         (linespec_complete): Update.
11034         (decode_line_full): Remove cleanups.
11035         (decode_line_1): Update.
11036
11037 2019-01-02  Tom Tromey  <tom@tromey.com>
11038
11039         * python/python-internal.h (inferior_to_inferior_object): Change
11040         return type.
11041         * python/py-exitedevent.c (create_exited_event_object): Update.
11042         * python/py-inferior.c (inferior_to_inferior_object): Return
11043         gdbpy_ref.
11044         (python_new_inferior, python_inferior_deleted)
11045         (thread_to_thread_object, delete_thread_object)
11046         (build_inferior_list, gdbpy_selected_inferior): Update.
11047         * python/py-infthread.c (create_thread_object): Update.  Also fail
11048         if inferior_to_inferior_object fails.
11049
11050 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11051
11052         * inferior.h (class inferior) <displaced_step_state>: New field.
11053         * infrun.h (struct displaced_step_state): Move here from
11054         infrun.c.  Initialize fields, add constructor.
11055         <inf>: Remove field.
11056         <reset>: New method.
11057         * infrun.c (struct displaced_step_inferior_state): Move to
11058         infrun.h.
11059         (displaced_step_inferior_states): Remove.
11060         (get_displaced_stepping_state): Adust.
11061         (displaced_step_in_progress_any_inferior): Adjust.
11062         (displaced_step_in_progress_thread): Adjust.
11063         (displaced_step_in_progress): Adjust.
11064         (add_displaced_stepping_state): Remove.
11065         (get_displaced_step_closure_by_addr): Adjust.
11066         (remove_displaced_stepping_state): Remove.
11067         (infrun_inferior_exit): Call displaced_step_state.reset.
11068         (use_displaced_stepping): Don't check for NULL.
11069         (displaced_step_prepare_throw): Call
11070         get_displaced_stepping_state.
11071         (displaced_step_fixup): Don't check for NULL.
11072         (prepare_for_detach): Don't check for NULL.
11073
11074 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11075
11076         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11077          in case of call that did not complete.
11078
11079 2019-01-02  Andrey Utkin  <autkin@undo.io>
11080
11081         * symfile.c (find_separate_debug_file): Fix search of debug files for
11082         remote debuggee.
11083
11084 2019-01-02  Tom Tromey  <tom@tromey.com>
11085
11086         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11087         indentation.
11088         * python/py-frame.c (frapy_older): Remove cast.
11089         (frapy_newer): Likewise.
11090         * python/py-breakpoint.c (local_setattro): Remove cast.
11091         * python/py-arch.c (archpy_name): Remove local variable.
11092         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11093
11094 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11095
11096         * unittests/basic_string_view/element_access/char/empty.cc:
11097         Fix year range in copyright header.
11098
11099 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11100
11101         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11102         Delete.
11103         <operator==>: Update with for removed field.
11104         <hash>: Likewise.
11105         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11106         <isa_features>: ...this.
11107         <abi_features>: New field.
11108         (riscv_isa_flen): Update comment.
11109         (riscv_abi_xlen): New declaration.
11110         (riscv_abi_flen): New declaration.
11111         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11112         isa_features.
11113         (riscv_abi_xlen): New function.
11114         (riscv_isa_flen): Update to get answer from isa_features.
11115         (riscv_abi_flen): New function.
11116         (riscv_has_fp_abi): Update to get answer from abi_features.
11117         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11118         xlen and flen.
11119         (riscv_call_info) <xlen, flen>: Update comment.
11120         (riscv_call_arg_struct): Remove invalid assertions
11121         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11122         is removed.
11123         (riscv_gdbarch_init): Gather isa features and abi features
11124         separately, ensure both match on the gdbarch when reusing an old
11125         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11126         a target with 64-bit float hardware.
11127
11128 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11129
11130         * source.c (search_command_helper): Stop reverse search
11131         when line 1 has been searched.
11132
11133 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11134
11135         * record-full.c (record_full_base_target::close): Rewrite
11136         record_full_core_buf_list free logic.
11137
11138 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11139
11140         * break-catch-syscall.c (print_one_catch_syscall): xfree
11141         the last text.
11142
11143 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11144
11145         * top.c (print_gdb_version): Update Copyright year in version
11146         message.
11147
11148 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11149
11150         Update copyright year range in all GDB files.
11151
11152 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11153
11154         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11155
11156 For older changes see ChangeLog-2018.
11157 \f
11158 Local Variables:
11159 mode: change-log
11160 left-margin: 8
11161 fill-column: 74
11162 version-control: never
11163 coding: utf-8
11164 End:
11165