Remove tui_erase_exec_info_content
[external/binutils.git] / gdb / ChangeLog
1 2019-08-13  Tom Tromey  <tom@tromey.com>
2
3         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
4         declare.
5         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
6         call tui_erase_exec_info_content.
7         (tui_clear_exec_info_content): Rename from
8         tui_erase_exec_info_content.
9         (tui_clear_exec_info_content): Delete.
10
11 2019-08-13  Tom Tromey  <tom@tromey.com>
12
13         * tui/tui-winsource.h (struct tui_source_window_base)
14         <show_exec_info_content>: Declare.
15         (tui_show_exec_info_content): Don't declare.
16         * tui/tui-winsource.c
17         (tui_source_window_base::show_exec_info_content): Rename from
18         tui_show_exec_info_content.
19         (tui_source_window_base::update_exec_info): Update.
20
21 2019-08-13  Tom Tromey  <tom@tromey.com>
22
23         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
24         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
25         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
26         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
27         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
28         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
29         ... here.
30
31 2019-08-13  Tom Tromey  <tom@tromey.com>
32
33         * tui/tui-winsource.h (struct tui_source_window_base)
34         <update_exec_info>: Declare.
35         (tui_update_exec_info): Don't declare.
36         * tui/tui-winsource.c (tui_update_source_window_as_is)
37         (tui_source_window_base::refresh_all)
38         (tui_update_all_breakpoint_info): Update.
39         (tui_source_window_base::update_exec_info): Rename from
40         tui_update_exec_info.
41         * tui/tui-stack.c (tui_show_frame_info): Update.
42
43 2019-08-13  Tom Tromey  <tom@tromey.com>
44
45         * tui/tui-winsource.h (struct tui_source_window_base)
46         <set_exec_info_content>: Declare.
47         (tui_set_exec_info_content): Don't declare.
48         * tui/tui-winsource.c
49         (tui_source_window_base::set_exec_info_content): Rename from
50         tui_set_exec_info_content.
51         (tui_update_exec_info): Update.
52
53 2019-08-13  Tom Tromey  <tom@tromey.com>
54
55         * tui/tui-winsource.h (struct tui_source_window_base)
56         <show_source_content>: Declare.
57         (tui_show_source_content): Don't declare.
58         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
59         (tui_source_window_base::show_source_content): Rename from
60         tui_show_source_content.
61         (tui_source_window_base::refresh_all): Update.
62         * tui/tui-layout.c (show_source_disasm_command)
63         (show_source_or_disasm_and_command): Update.
64
65 2019-08-13  Tom Tromey  <tom@tromey.com>
66
67         * tui/tui-winsource.c (tui_erase_source_content)
68         (tui_show_source_content, tui_source_window_base::refresh_all):
69         Update.
70         * tui/tui-wingeneral.h
71         (tui_check_and_display_highlight_if_needed): Don't declare.
72         * tui/tui-wingeneral.c
73         (tui_win_info::check_and_display_highlight_if_needed): Rename from
74         check_and_display_highlight_if_needed.
75         * tui/tui-win.c (tui_rehighlight_all)
76         (tui_win_info::make_visible_with_new_height): Update.
77         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
78         (tui_data_window::erase_data_content)
79         (tui_data_window::display_all_data): Update.
80         * tui/tui-data.h (struct tui_win_info)
81         <check_and_display_highlight_if_needed>: Declare.
82
83 2019-08-13  Tom Tromey  <tom@tromey.com>
84
85         * tui/tui-win.c (tui_resize_all): Call
86         tui_delete_invisible_windows.
87         * tui/tui-layout.c (show_layout): Call
88         tui_delete_invisible_windows.
89         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
90         * tui/tui-data.c (tui_delete_invisible_windows): New function.
91
92 2019-08-13  Tom Tromey  <tom@tromey.com>
93
94         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
95         tui_add_win_to_layout.
96
97 2019-08-13  Tom Tromey  <tom@tromey.com>
98
99         * tui/tui-layout.h (tui_default_win_height): Don't declare.
100         * tui/tui-layout.c (tui_default_win_height): Now static.
101
102 2019-08-13  Tom Tromey  <tom@tromey.com>
103
104         * tui/tui-layout.c (show_layout): Unify all layout cases into a
105         single switch.
106         (show_source_disasm_command, show_source_or_disasm_and_command):
107         Don't check current layout.
108
109 2019-08-13  Tom Tromey  <tom@tromey.com>
110
111         * tui/tui-wingeneral.c (make_all_visible): Remove.
112         (tui_make_all_invisible): Simplify.
113         * tui/tui-layout.c (tui_make_all_invisible): Move from
114         tui-wingeneral.c; simplify.
115         (show_layout): Hoist call to tui_make_all_invisible.
116         (show_data): Don't call tui_make_all_invisible.
117
118 2019-08-13  Tom Tromey  <tom@tromey.com>
119
120         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
121         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
122
123 2019-08-13  Tom Tromey  <tom@tromey.com>
124
125         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
126         tui-data.c.
127         (show_source_disasm_command, show_data)
128         (show_source_or_disasm_and_command): Don't use
129         tui_set_current_layout_to.
130         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
131         * tui/tui-data.c (current_layout, tui_current_layout): Move to
132         tui-layout.c.
133         (tui_set_current_layout_to): Remove.
134
135 2019-08-13  Tom Tromey  <tom@tromey.com>
136
137         * tui/tui-layout.c (tui_set_layout): Update.
138         * tui/tui-data.h (struct tui_layout_def): Remove.
139         (tui_layout_def): Don't declare.
140         * tui/tui-data.c (layout_def): Remove.
141         (tui_layout_def): Remove.
142
143 2019-08-13  Tom Tromey  <tom@tromey.com>
144
145         * tui/tui-winsource.h (struct tui_source_window_base)
146         <clear_detail>: No longer "override".
147         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
148         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
149         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
150         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
151         Remove.
152         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
153
154 2019-08-13  Tom Tromey  <tromey@adacore.com>
155
156         * tracepoint.c: Don't include readline.h or history.h.
157
158 2019-08-12  Tom Tromey  <tom@tromey.com>
159
160         * configure: Rebuild.
161         * configure.ac: Check for readline 7.
162         * NEWS: Mention readline 7 requirement.
163         * README: Update.
164
165 2019-08-12  Tom Tromey  <tom@tromey.com>
166
167         * mingw-hdep.c (gdb_select): Remove readline hack.
168
169 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
170
171         * blockframe.c (find_pc_partial_function): Set *block to nullptr
172         when the function fails.
173
174 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
175
176         * s390-tdep.c (s390_type_align): New function.
177         (s390_gdbarch_init): Set it as type_align gdbarch method.
178
179 2019-08-09  Tom de Vries  <tdevries@suse.de>
180
181         PR gdb/24591
182         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
183         pc_low with relocation offset.
184
185 2019-08-07  Tom Tromey  <tromey@adacore.com>
186
187         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
188         (print_frame_args): Update.
189         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
190         Update.
191         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
192         * frame.h (struct frame_arg): Add initializers.
193         <error>: Now a unique_xmalloc_ptr.
194
195 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
196
197         * NEWS: Expand the Pointer Authentication entry.
198         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
199         (aarch64_frame_unmask_lr): ... to this.
200         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
201         Call aarch64_frame_unmask_lr.
202         * frame.c (struct frame_info): Add "masked" variable.
203         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
204         (fprint_frame): Check for masked pc.
205         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
206         declarations.
207         * python/py-framefilter.c (py_print_frame): Check for masked pc.
208         * stack.c (print_frame): Check for masked pc.
209
210 2019-08-06  Tom Tromey  <tom@tromey.com>
211
212         * stabsread.c (patch_block_stabs, read_one_struct_field)
213         (read_enum_type): Use obstack_strndup.
214         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
215         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
216         * dwarf2read.c (guess_full_die_structure_name)
217         (anonymous_struct_prefix): Use obstack_strndup.
218         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
219         * c-exp.y (yylex): Use obstack_strndup.
220         * ada-exp.y (write_object_renaming, write_ambiguous_var)
221         (write_var_or_type): Use obstack_strndup.
222
223 2019-08-06  Tom Tromey  <tom@tromey.com>
224
225         * symfile.c (reread_symbols): Use obstack_strdup.
226         * stabsread.c (read_type): Use obstack_strdup.
227         * gdb_obstack.h (obstack_strdup): New overload.
228         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
229         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
230         (dwarf2_canonicalize_name): Use obstack_strdup.
231         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
232         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
233         Use obstack_strdup.
234
235 2019-08-06  Tom Tromey  <tom@tromey.com>
236
237         * gdb_obstack.h (obstack_strdup): Define.
238         * gdb_obstack.c (obstack_strdup): Don't define.
239
240 2019-08-06  Tom Tromey  <tom@tromey.com>
241
242         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
243         obstack_strdup.
244         * typeprint.c (typedef_hash_table::find_global_typedef): Use
245         obstack_strdup.
246         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
247         * stabsread.c (common_block_start): Use obstack_strdup.
248         * objfiles.c (set_objfile_main_name, objfile): Use
249         obstack_strdup.
250         * namespace.c (add_using_directive): Use obstack_strdup.
251         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
252         * jit.c (finalize_symtab): Use obstack_strdup.
253         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
254         (guess_partial_die_structure_name, partial_die_info::fixup)
255         (dwarf2_name): Use obstack_strdup.
256         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
257         obstack_strdup.
258         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
259         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
260         obstack_strdup.
261         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
262
263 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
264
265         * unittests/help-doc-selftests.c: New file.
266         * Makefile.in: Add the new file.
267
268 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
269
270         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
271         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
272         the full first line, except when FOR_VALUE_PREFIX.  In this case,
273         the trailing '.' is not output, and the first character is uppercased.
274         (print_help_for_command): Update call to print_doc_line.
275         (print_doc_of_command): Likewise.
276         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
277         * cli/cli-option.c (append_indented_doc): Do not append newline.
278         (build_help_option): Append newline after first appended_indented_doc
279         only if a second call is done.
280         (build_help): Append 2 new lines before each option, except the first
281         one.
282         * compile/compile.c (_initialize_compile): Add new lines after
283         %OPTIONS%, when not at the end of the help.
284         Change help doc or code
285         producing the help doc to respect the invariants.
286         * maint-test-options.c (_initialize_maint_test_options): Likewise.
287         Also removed the new line after 'Options:', as all other commands
288         do not put an empty line between 'Options:' and the first option.
289         * printcmd.c (_initialize_printcmd): Likewise.
290         * stack.c (_initialize_stack): Likewise.
291         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
292         incorrectly telling COMMAND is optional.
293         * ada-lang.c (_initialize_ada_language): Change help doc or code
294         producing the help doc to respect the invariants.
295         * ada-tasks.c (_initialize_ada_tasks): Likewise.
296         * breakpoint.c (_initialize_breakpoint): Likewise.
297         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
298         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
299         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
300         * cli/cli-style.c (cli_style_option::add_setshow_commands,
301         _initialize_cli_style): Likewise.
302         * corelow.c (core_target_info): Likewise.
303         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
304         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
305         * filesystem.c (_initialize_filesystem): Likewise.
306         * frame.c (_initialize_frame): Likewise.
307         * gnu-nat.c (add_task_commands): Likewise.
308         * infcall.c (_initialize_infcall): Likewise.
309         * infcmd.c (_initialize_infcmd): Likewise.
310         * interps.c (_initialize_interpreter): Likewise.
311         * language.c (_initialize_language): Likewise.
312         * linux-fork.c (_initialize_linux_fork): Likewise.
313         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
314         * maint.c (_initialize_maint_cmds): Likewise.
315         * memattr.c (_initialize_mem): Likewise.
316         * printcmd.c (_initialize_printcmd): Likewise.
317         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
318         _RegEx): Likewise.
319         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
320         * record-btrace.c (_initialize_record_btrace): Likewise.
321         * record-full.c (_initialize_record_full): Likewise.
322         * record.c (_initialize_record): Likewise.
323         * regcache-dump.c (_initialize_regcache_dump): Likewise.
324         * regcache.c (_initialize_regcache): Likewise.
325         * remote.c (add_packet_config_cmd, init_remote_threadtests,
326         _initialize_remote): Likewise.
327         * ser-tcp.c (_initialize_ser_tcp): Likewise.
328         * serial.c (_initialize_serial): Likewise.
329         * skip.c (_initialize_step_skip): Likewise.
330         * source.c (_initialize_source): Likewise.
331         * stack.c (_initialize_stack): Likewise.
332         * symfile.c (_initialize_symfile): Likewise.
333         * symtab.c (_initialize_symtab): Likewise.
334         * target-descriptions.c (_initialize_target_descriptions): Likewise.
335         * top.c (init_main): Likewise.
336         * tracefile-tfile.c (tfile_target_info): Likewise.
337         * tracepoint.c (_initialize_tracepoint): Likewise.
338         * tui/tui-win.c (_initialize_tui_win): Likewise.
339         * utils.c (add_internal_problem_command): Likewise.
340         * valprint.c (value_print_option_defs): Likewise.
341
342 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
343
344         PR build/24886
345         * configure.ac: Drop enable-libmcheck support.
346         * configure, config.in: Rebuild.
347         * libmcheck.m4: Remove.
348         * acinclude.m4: Don't include it.
349         * Makefile.in: Don't distribute it.
350         * top.c (print_gdb_configuration): Don't mention it.
351
352 2019-08-06  Tom Tromey  <tom@tromey.com>
353
354         * utils.c (set_output_style): Sometimes pass stream to
355         emit_style_escape.
356         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
357         * record-btrace.c (btrace_insn_history): Update.
358         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
359         method.
360         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
361         Update initializers.
362         <m_uiout>: New field.
363         <m_di>: Move lower.
364         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
365         Remove "uiout" parameter.
366         (dump_insns): Update.
367         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
368         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
369
370 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
371
372         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
373         (error_in_psymtab_expansion): Likewise.
374         (lookup_symbol_via_quick_fns): Likewise.
375         (basic_lookup_transparent_type_quick): Likewise.
376         (basic_lookup_transparent_type_1): Likewise.
377
378 2019-08-06  Tom Tromey  <tromey@adacore.com>
379
380         * source.c (last_source_error): Now bool.
381         (print_source_lines_base): Make "noprint" bool.  Only open
382         source file when last_source_visited changes.
383
384 2019-08-06  Tom Tromey  <tromey@adacore.com>
385
386         * annotate.c (annotate_source_line): Use g_source_cache.
387         * source-cache.c (source_cache::get_plain_source_lines): Change
388         parameters.  Populate m_offset_cache.
389         (source_cache::ensure): New method.
390         (source_cache::get_line_charpos): New method.
391         (extract_lines): Move lower.  Change parameters.
392         (source_cache::get_source_lines): Move lower.
393         * source-cache.h (class source_cache): Update comment.
394         <get_line_charpos>: New method.
395         <get_source_lines>: Update comment.
396         <clear>: Clear m_offset_cache.
397         <get_plain_source_lines>: Change parameters.
398         <ensure>: New method
399         <m_offset_cache>: New member.
400         * source.c (forget_cached_source_info_for_objfile): Update.
401         (info_source_command): Use g_source_cache.
402         (find_source_lines, open_source_file_with_line_charpos): Remove.
403         (print_source_lines_base, search_command_helper): Use g_source_cache.
404         * source.h (open_source_file_with_line_charpos): Don't declare.
405         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
406         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
407         Use g_source_cache.
408
409 2019-08-06  Tom Tromey  <tromey@adacore.com>
410
411         * source-cache.c (source_cache::get_plain_source_lines):
412         Remove "first_line" and "last_line" parameters.
413         (source_cache::get_source_lines): Cache plain text.
414         * source-cache.h (class source_cache)
415         <get_plain_source_lines>: Update.
416
417 2019-08-06  Tom Tromey  <tromey@adacore.com>
418
419         * source-cache.c (extract_lines): No longer a method.
420         Changed type of parameter.  Include final newline.
421         (selftests::extract_lines_test): New function.
422         (_initialize_source_cache): Likewise.
423         * source-cache.h (class source_cache)
424         <extract_lines>: Don't declare.
425
426 2019-08-06  Tom Tromey  <tromey@adacore.com>
427
428         * breakpoint.c (init_breakpoint_sal): Update.
429         (breakpoint): Update.
430         * breakpoint.h (struct breakpoint) <filter>: Now a
431         unique_xmalloc_ptr.
432
433 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
434
435         * NEWS: Mention dictionary access on blocks.
436         * python/py-block.c (blpy_getitem): New function.
437         (block_object_as_mapping): New struct.
438         (block_object_type): Use new struct for tp_as_mapping field.
439
440 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
441
442         * objfiles.h (objfile): Add a comment describing partial symbols.
443
444 2019-08-05  Tom Tromey  <tromey@adacore.com>
445
446         * compile/compile.c (_initialize_compile): Use _(), not N_().
447         * thread.c (_initialize_thread): Use _(), not N_().
448         * stack.c (_initialize_stack): Use _(), not N_().
449         * printcmd.c (_initialize_printcmd): Use _(), not N_().
450
451 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
452
453         * dwarf2read.c (struct dw2_symtab_iterator):
454         <want_specific_block>: Remove.
455         <block_index>: Change type to gdb::optional.
456         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
457         change type of BLOCK_INDEX parameter to gdb::optional.
458         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
459         (dw2_lookup_symbol): Don't pass argument for
460         WANT_SPECIFIC_BLOCK.
461         (dw2_expand_symtabs_for_function): Don't pass argument for
462         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
463         (class dw2_debug_names_iterator)
464         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
465         parameter, change BLOCK_INDEX type to gdb::optional.
466         <m_want_specific_block>: Remove.
467         <m_block_index>: Change type to gdb::optional.
468         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
469         gdb::optional.  Re-write in function of gdb::optional.
470         (dw2_debug_names_lookup_symbol): Don't pass argument for
471         WANT_SPECIFIC_BLOCK.
472         (dw2_debug_names_expand_symtabs_for_function): Don't pass
473         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
474         BLOCK_INDEX.
475
476 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
477
478         * NEWS: Mention changes to "info sources" command.
479
480 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
481
482         * symtab.c (filename_partial_match_opts): New struct type.
483         (struct output_source_filename_data): New members
484         regexp, c_regexp, partial_match.
485         (output_source_filename): Use new members to decide to print file.
486         (info_sources_option_defs): New variable.
487         (make_info_sources_options_def_group, print_info_sources_header,
488         info_sources_command_completer):
489         New functions.
490         (info_sources_command): Read new optional arguments.
491         (_initialize_symtab): Update info sources help.
492
493 2019-08-02  Alexandre Oliva <oliva@adacore.com>
494
495         * ada-lang.c (exception_support_info_v0): Renamed from...
496         (default_exception_support_info): ... this.  Create new
497         definition for v1.
498         (ada_has_this_exception_support): Look up catch_handlers_sym.
499         (ada_exception_support_info_sniffer): Try v0 after default.
500
501 2019-08-01  Tom Tromey  <tromey@adacore.com>
502
503         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
504         gdbarch.h.
505
506 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
507
508         * s12z-tdep.c: Fix include path for s12z-opc.h.
509
510 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
511
512         * NEWS: Require GNU make 3.82.
513
514 2019-07-16  Tom Tromey  <tom@tromey.com>
515
516         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
517         declare.
518
519 2019-07-30  Tom Tromey  <tromey@adacore.com>
520
521         * block.c (contained_in): Remove BLOCK_FUNCTION check.
522
523 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
524
525         * printcmd.c (print_address_symbolic): Print negative offsets.
526         (build_address_symbolic): Force signed arithmetic when computing
527         offset.
528
529 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
530
531         PR/24474: Add a function to lookup static variables.
532         * NEWS: Mention this new function.
533         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
534         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
535         * python/python.c (python_GdbMethods): Add new function.
536
537 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
538
539         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
540         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
541         (objfpy_lookup_static_symbol): New function.
542         (objfile_object_methods): Add new functions.
543
544 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
545
546         * NEWS: Mention 'set|show print frame-info'.  Mention new
547         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
548         backtrace argument.  Mention that python frame filtering code
549         is now consistent with what 'backtrace' command prints.
550
551 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
552
553         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
554         comments.
555         (print_frame_info_auto, print_frame_info_source_line,
556         print_frame_info_location, print_frame_info_source_and_location,
557         print_frame_info_location_and_address, print_frame_info_short_location):
558         New declarations.
559         (struct frame_print_options): New member print_frame_info.
560         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
561         * stack.h (get_user_print_what_frame_info): New declaration.
562         (frame_show_address): New declaration.
563         * stack.c (print_frame_arguments_choices): New value 'presence'.
564         (print_frame_info_auto, print_frame_info_source_line,
565         print_frame_info_location, print_frame_info_source_and_location,
566         print_frame_info_location_and_address, print_frame_info_short_location,
567         print_frame_info_choices, print_frame_info_print_what): New definitions.
568         (print_frame_args): Only print dots for args if print frame-arguments
569         is 'presence'.
570         (frame_print_option_defs): New element for "frame-info".
571         (get_user_print_what_frame_info): New function.
572         (frame_show_address): Make non static.  Move comment to stack.h.
573         (print_frame_info_to_print_what): New function.
574         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
575         to decide what to print.
576         (backtrace_command_1): Handle the new print_frame_arguments_presence
577         value.
578         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
579         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
580         (py_print_frame): In non-mi mode, use LOCATION as default for
581         print_what, similarly to frame information printed directly by
582         backtrace command. Handle frame-info user option in non MI mode.
583
584 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
585
586         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
587         Add case for debugging 32-bit target on 64-bit host.  Revise
588         comment.
589
590 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
591
592         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
593         instead of find_function_entry_range_from_pc.
594
595 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
596
597         * stack.c (find_frame_funname): Remove code which preferred
598         minsym over symtab sym in "certain pathological cases".
599
600         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
601         parameter.  Change type of "do_demangle" to bool.
602         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
603         Pass suitable "prefer_sym_over_minsym" flag to
604         build_address_symbolic().  Don't output "+" for negative offsets.
605         * printcmd.c (print_address_symbolic): Update invocation of
606         build_address_symbolic to include a "prefer_sym_over_minsym"
607         flag.
608         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
609         Restrict cases in which use of minimal symbol is preferred to that
610         of a found symbol.  Update comments.
611
612         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
613         for entry pc when entry pc is out of range for that FDE.
614
615 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
616
617         PR gdb/24839:
618         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
619         type.
620
621 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
622
623         * python/py-objfile.c (add_separate_debug_file): Fix comment about
624         this function's Python signature.
625
626
627 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
628
629         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
630         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
631         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
632         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
633         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
634
635
636 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
637
638         * h8300-tdep.c (h8300_register_name_common): New.
639         h8300_register_name): Use h8300_register_name_common.
640         (h8300s_register_name): Likewise.
641         (h8300sx_register_name): Likewise.
642         (h8300h_register_nam): New.
643         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
644
645
646 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
647
648         * arm-tdep.c (arm_skip_cmse_entry): New function.
649         (arm_is_sgstubs_section): New function.
650         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
651
652 2019-07-22  Tom Tromey  <tom@tromey.com>
653
654         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
655         Don't self-assign.
656
657 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
658
659         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
660         type_print.
661
662 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
663
664         * symtab.c (search_symbols): Adjust msymbol matching type arrays
665         so that GDB doesn't match any msymbols when searching in the
666         TYPES_DOMAIN.
667         (print_symbol_info): Print using typedef_print or type_print based
668         on the type of the symbol.  Add updated FIXME comment moved from...
669         (_initialize_symtab): ... move and update FIXME comment to above.
670
671 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
672
673         * NEWS: Mention adding -q option to "info types".
674         * symtab.c (struct info_types_options): New struct.
675         (info_types_options_defs): New variable.
676         (make_info_types_options_def_group): New function.
677         (info_types_command): Use gdb::option framework to parse options.
678         (info_types_command_completer): New function.
679         (_initialize_symtab): Extend the help text on "info types" and
680         register command completer.
681
682 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
683
684         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
685         (lookup_symbol_in_objfile): Change int to block_enum and add a
686         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
687
688 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
689
690         * MAINTAINERS (Write After Approval): Add self.
691
692 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
693
694         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
695         instruction to the dummy code region.
696
697 2019-07-19  Tom Tromey  <tromey@adacore.com>
698
699         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
700         (ARGSUSED, PARAMS, __func__): Remove rules.
701
702 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
703
704         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
705         * features/arm/arm-with-iwmmxt.c: Remove.
706         * features/arm/arm-with-iwmmxt.xml: Remove.
707         * features/arm/arm-with-m-fpa-layout.c: Remove.
708         * features/arm/arm-with-m-fpa-layout.xml: Remove.
709         * features/arm/arm-with-m-vfp-d16.c: Remove.
710         * features/arm/arm-with-m-vfp-d16.xml: Remove.
711         * features/arm/arm-with-m.c: Remove.
712         * features/arm/arm-with-m.xml: Remove.
713         * features/arm/arm-with-neon.c: Remove.
714         * features/arm/arm-with-neon.xml: Remove.
715         * features/arm/arm-with-vfpv2.c: Remove.
716         * features/arm/arm-with-vfpv2.xml: Remove.
717         * features/arm/arm-with-vfpv3.c: Remove.
718         * features/arm/arm-with-vfpv3.xml: Remove.
719
720 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
721
722         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
723
724 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
725
726         * arch/aarch32.c (aarch32_create_target_description): Create
727         target descriptions using features.
728         * arch/arm.c (arm_create_target_description)
729         (arm_create_mprofile_target_description): Likewise.
730         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
731
732 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
733
734         * Makefile.in: Add new files.
735         * aarch32-tdep.c: New file.
736         * aarch32-tdep.h: New file.
737         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
738         Call aarch32_read_description.
739         * arch/aarch32.c: New file.
740         * arch/aarch32.h: New file.
741         * arch/arm.c (arm_create_target_description)
742         (arm_create_mprofile_target_description): New function.
743         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
744         (arm_create_target_description)
745         (arm_create_mprofile_target_description): New declaration.
746         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
747         read_description functions.
748         * arm-linux-nat.c (arm_linux_nat_target::read_description):
749         Likewise.
750         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
751         * arm-tdep.c (tdesc_arm_list): New variable.
752         (arm_register_g_packet_guesses): Call create description functions.
753         (arm_read_description) (arm_read_mprofile_description): New
754         function.
755         * arm-tdep.h (arm_read_description)
756         (arm_read_mprofile_description): Add declaration.
757         * configure.tgt: Add new files.
758
759 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
760
761         * top.c (new_ui_command): Open specified terminal just once.
762
763 2019-07-18  Tom Tromey  <tromey@adacore.com>
764
765         * symtab.c (main_name): Constify return type.
766         * symfile.c (set_initial_language): Update.
767         * symtab.h (main_name): Constify return type.
768
769 2019-07-17  Tom Tromey  <tom@tromey.com>
770
771         * tui/tui-winsource.c (tui_update_source_window)
772         (tui_update_source_window_as_is)
773         (tui_update_source_windows_with_line): Remove return.
774         * tui/tui-disasm.c (tui_show_disassem)
775         (tui_show_disassem_and_update_source): Remove return.
776         * tui/tui.c (tui_reset): Remove return.
777         * tui/tui-wingeneral.c
778         (tui_check_and_display_highlight_if_needed): Remove return.
779
780 2019-07-17  Tom Tromey  <tom@tromey.com>
781
782         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
783
784 2019-07-17  Tom Tromey  <tom@tromey.com>
785
786         * tui/tui-winsource.h (struct tui_exec_info_window)
787         (struct tui_source_window_base): Move from tui-data.h.
788         * tui/tui-winsource.c: Move many method definitions from
789         elsewhere.  Remove "structuring" comments.
790         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
791         (tui_source_window_base::refresh_window): Move to
792         tui-winsource.c.
793         * tui/tui-win.c (tui_source_window_base::refresh_all)
794         (tui_source_window_base::update_tab_width)
795         (tui_source_window_base::set_new_height)
796         (tui_source_window_base::do_make_visible_with_new_height): Move to
797         tui-winsource.c.
798         * tui/tui-source.h: Update.
799         * tui/tui-source.c (tui_source_window_base::reset): Move to
800         tui-winsource.c.
801         * tui/tui-disasm.h: Update.
802         * tui/tui-data.h (struct tui_exec_info_window): Move to
803         tui-winsource.h.
804         (struct tui_source_window_base): Likewise.
805         * tui/tui-data.c (tui_source_window_base::clear_detail)
806         (tui_source_window_base, ~tui_source_window_base): Move to
807         tui-winsource.c.
808
809 2019-07-17  Tom Tromey  <tom@tromey.com>
810
811         * tui/tui-win.c (tui_resize_all)
812         (tui_source_window_base::update_tab_width)
813         (tui_adjust_win_heights): Update.
814         (tui_win_info::make_invisible_and_set_new_height): Rename from
815         make_invisible_and_set_new_height.
816         * tui/tui-data.h (struct tui_win_info)
817         <make_invisible_and_set_new_height>: New method.
818
819 2019-07-17  Tom Tromey  <tom@tromey.com>
820
821         * tui/tui.c: Update.
822         * tui/tui-source.h (struct tui_source_window): Move from
823         tui-data.h.
824         * tui/tui-layout.c: Update.
825         * tui/tui-disasm.c: Update.
826         * tui/tui-data.h (struct tui_source_window): Move to
827         tui-source.h.
828
829 2019-07-17  Tom Tromey  <tom@tromey.com>
830
831         * tui/tui-disasm.h (struct tui_disasm_window): Move from
832         tui-data.h.
833         * tui/tui-data.h (struct tui_disasm_window): Move to
834         tui-disasm.h.
835
836 2019-07-17  Tom Tromey  <tom@tromey.com>
837
838         * tui/tui-regs.h (struct tui_data_item_window): Move from
839         tui-data.h.
840         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
841         * tui/tui-data.h (struct tui_data_item_window): Move to
842         tui-regs.h.
843         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
844
845 2019-07-17  Tom Tromey  <tom@tromey.com>
846
847         * tui/tui.c: Update.
848         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
849         (tui_cmd_window::max_height): Move to tui-command.c.
850         * tui/tui-layout.c: Update.
851         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
852         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
853         tui-command.c.
854         * tui/tui-command.h (struct tui_cmd_window): Move from
855         tui-data.h.
856         * tui/tui-command.c: Remove "structuring" comments.
857         (tui_cmd_window::clear_detail)
858         (tui_cmd_window::do_make_visible_with_new_height)
859         (tui_cmd_window::max_height): Move from elsewhere.
860
861 2019-07-17  Tom Tromey  <tom@tromey.com>
862
863         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
864         Now static.
865         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
866         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
867
868 2019-07-17  Tom Tromey  <tom@tromey.com>
869
870         * tui/tui.c: Update.
871         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
872         tui-regs.c.
873         * tui/tui-windata.h: Remove file.
874         * tui/tui-windata.c: Remove file.
875         * tui/tui-win.c (tui_data_window::set_new_height)
876         (tui_data_window::do_make_visible_with_new_height): Move to
877         tui-regs.c.
878         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
879         * tui/tui-regs.c: Remove "structuring" comments.
880         (tui_data_window::first_data_item_displayed)
881         (tui_data_window::delete_data_content_windows)
882         (tui_data_window::erase_data_content)
883         (tui_data_window::display_all_data)
884         (tui_data_window::refresh_all)
885         (tui_data_window::do_scroll_vertical)
886         (tui_data_window::clear_detail, tui_data_window::set_new_height)
887         (tui_data_window::do_make_visible_with_new_height)
888         (tui_data_window::refresh_window): Move from elsewhere.
889         (_initialize_tui_regs): Move to end of file.
890         * tui/tui-layout.c: Update.
891         * tui/tui-hooks.c: Update.
892         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
893         * tui/tui-data.c (tui_data_window::clear_detail): Move to
894         tui-regs.c.
895         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
896
897 2019-07-17  Tom Tromey  <tom@tromey.com>
898
899         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
900         seen.
901
902 2019-07-17  Tom Tromey  <tom@tromey.com>
903
904         * tui/tui-win.c (tui_source_window_base::set_new_height)
905         (tui_source_window_base::do_make_visible_with_new_height): Use
906         m_has_locator field directly.
907         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
908         method.
909         (struct tui_source_window_base) <has_locator>: Likewise.
910
911 2019-07-17  Tom Tromey  <tom@tromey.com>
912
913         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
914         Don't declare.
915         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
916         Remove.
917         * tui/tui-win.c (tui_source_window_base::set_new_height)
918         (tui_source_window_base::set_new_height)
919         (make_invisible_and_set_new_height)
920         (tui_source_window_base::do_make_visible_with_new_height)
921         (tui_source_window_base::do_make_visible_with_new_height):
922         Update.
923         * tui/tui-layout.c (show_source_disasm_command, show_data)
924         (show_source_or_disasm_and_command): Update.
925         * tui/tui-layout.c (show_layout): Update.
926
927 2019-07-17  Tom Tromey  <tom@tromey.com>
928
929         * tui/tui-layout.c (make_data_window): Remove.
930         (show_data): Unify creation and re-initialization cases.
931
932 2019-07-17  Tom Tromey  <tom@tromey.com>
933
934         * tui/tui-layout.c (make_source_window, make_disasm_window):
935         Remove.
936         (show_data): Unify creation and re-initialization cases.
937
938 2019-07-17  Tom Tromey  <tom@tromey.com>
939
940         * tui/tui-layout.c (make_command_window): Remove.
941         (show_source_disasm_command, show_source_or_disasm_and_command):
942         Unify creation and re-initialization cases.
943
944 2019-07-17  Tom Tromey  <tom@tromey.com>
945
946         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
947         creation and re-initialization cases.
948
949 2019-07-17  Tom Tromey  <tom@tromey.com>
950
951         * tui/tui-regs.c (tui_get_register): Return void.
952
953 2019-07-17  Tom Tromey  <tom@tromey.com>
954
955         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
956         Simplify.
957
958 2019-07-17  Tom Tromey  <tom@tromey.com>
959
960         * tui/tui-layout.c (show_source_disasm_command): Simplify window
961         resetting.
962
963 2019-07-17  Tom Tromey  <tom@tromey.com>
964
965         * tui/tui.h (tui_set_layout_by_name): Don't declare.
966         * tui/tui-regs.c (tui_reg_layout): New function.
967         (tui_show_registers, tui_reg_command): Use it.
968         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
969         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
970         parameters.
971         (tui_layout_command): Remove.
972
973 2019-07-17  Tom Tromey  <tom@tromey.com>
974
975         * tui/tui-layout.h (tui/tui-layout): Return void.
976         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
977
978 2019-07-17  Tom Tromey  <tom@tromey.com>
979
980         * tui/tui-layout.c (show_source_disasm_command, show_data):
981         Update.
982         (reset_locator): Remove.
983         (show_source_or_disasm_and_command): Update.
984
985 2019-07-17  Tom Tromey  <tom@tromey.com>
986
987         * tui/tui-source.c (tui_source_window_base::reset): Remove
988         win_type parameter.
989         * tui/tui-layout.c (make_command_window, make_source_window)
990         (make_disasm_window, make_data_window)
991         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
992         (reset_locator, show_source_or_disasm_and_command): Update.
993         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
994         win_type parameter.
995         (struct tui_source_window_base) <reset>: Likewise.
996
997 2019-07-17  Tom Tromey  <tom@tromey.com>
998
999         * tui/tui-layout.c (show_source_disasm_command): Use
1000         reset_locator.
1001         (reset_locator): New function.
1002         (init_and_make_win): Remove.
1003         (show_source_or_disasm_and_command): Use reset_locator.
1004
1005 2019-07-17  Tom Tromey  <tom@tromey.com>
1006
1007         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1008         condition.
1009         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1010         Remove condition.
1011         * tui/tui-source.c (tui_source_window_base::reset): New method.
1012         * tui/tui-layout.c (make_command_window): Don't call
1013         init_and_make_win.
1014         (make_source_window, make_disasm_window): Don't call
1015         make_source_or_disasm_window.
1016         (make_data_window): Don't call init_and_make_win.  Change calling
1017         convention.
1018         (show_source_disasm_command, show_data): Simplify.
1019         (make_source_or_disasm_window): Remove.
1020         (show_source_or_disasm_and_command): Simplify.
1021         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1022         (struct tui_source_window_base) <reset>: Likewise.
1023         <execution_info>: Remove initializer.
1024         * tui/tui-data.c (tui_source_window_base): Initialize
1025         execution_info.
1026
1027 2019-07-17  Tom Tromey  <tom@tromey.com>
1028
1029         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1030         variable.
1031
1032 2019-07-17  Tom Tromey  <tom@tromey.com>
1033
1034         * tui/tui.c (tui_rl_other_window): Update.
1035         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1036         superclass method first.  Always iterate over regs_content.
1037         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1038         method.
1039         * tui/tui-win.c (tui_set_focus_command): Update.
1040
1041 2019-07-17  Tom Tromey  <tom@tromey.com>
1042
1043         * tui/tui-win.c (tui_set_focus_command): Rename from
1044         tui_set_focus.  Call tui_enable.
1045         (tui_set_focus_command): Remove.
1046
1047 2019-07-17  Tom Tromey  <tom@tromey.com>
1048
1049         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1050         refresh_window.
1051         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1052         touchwin.
1053         (tui_data_window::refresh_window): Call refresh_window on data
1054         items.  Always call superclass refresh_window.
1055         (tui_win_info::refresh): Remove.
1056         (tui_source_window_base::refresh_window): Update.
1057         (tui_refresh_all): Update.
1058         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1059         refresh_window.
1060         (show_source_or_disasm_and_command): Likewise.
1061         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1062         (struct tui_source_window_base) <refresh>: Likewise.
1063
1064 2019-07-17  Tom Tromey  <tom@tromey.com>
1065
1066         * tui/tui-winsource.c (tui_clear_source_content)
1067         (tui_show_source_content): Update.
1068         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1069         whether content is empty.
1070         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1071         Remove.
1072
1073 2019-07-17  Tom Tromey  <tom@tromey.com>
1074
1075         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1076         window's contents.
1077         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1078         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1079
1080 2019-07-17  Tom Tromey  <tom@tromey.com>
1081
1082         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1083         (struct tui_data_item_window): Update.
1084
1085 2019-07-17  Tom Tromey  <tom@tromey.com>
1086
1087         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1088         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1089         defines.
1090
1091 2019-07-17  Tom Tromey  <tom@tromey.com>
1092
1093         * tui/tui-winsource.h (tui_erase_source_content)
1094         (tui_clear_source_content): Remove "display_prompt" parameter.
1095         * tui/tui-winsource.c (tui_update_source_window_as_is)
1096         (tui_update_source_windows_with_addr): Update.
1097         (tui_clear_source_content): Remove "display_prompt" parameter.
1098         (tui_erase_source_content): Likewise.  Simplify.
1099         (tui_show_source_content): Update.
1100         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1101         * tui/tui-stack.c (tui_show_frame_info): Update.
1102         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1103         Remove defines.
1104
1105 2019-07-17  Tom Tromey  <tom@tromey.com>
1106
1107         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1108         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1109         parameter.
1110         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1111         parameter.
1112
1113 2019-07-17  Tom Tromey  <tom@tromey.com>
1114
1115         * tui/tui-winsource.c (tui_clear_source_content)
1116         (tui_show_source_content, tui_show_exec_info_content)
1117         (tui_clear_exec_info_content): Update.
1118         * tui/tui-stack.c (tui_show_locator_content): Update.
1119         (tui_show_frame_info): Update.
1120         * tui/tui-source.h (tui_source_window): Don't declare.
1121         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1122         from tui_source_is_displayed.
1123         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1124         Remove field.
1125         (struct tui_source_window_base) <content_in_use>: New field.  Now
1126         bool.
1127         (struct tui_source_window) <showing_source_p>: New method.
1128         (TUI_SRC_WIN): Change cast.
1129         * tui/tui-data.c (tui_initialize_static_data): Update.
1130
1131 2019-07-17  Tom Tromey  <tom@tromey.com>
1132
1133         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1134         location_matches_p.
1135         * tui/tui-source.c (tui_source_window::location_matches_p): New
1136         method.
1137         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1138         method.
1139         * tui/tui-data.h (struct tui_source_window_base)
1140         <location_matches_p>: New method.
1141         (struct tui_source_window, struct tui_disasm_window)
1142         <location_matches_p>: Likewise.
1143
1144 2019-07-17  Tom Tromey  <tom@tromey.com>
1145
1146         * tui/tui-win.c (tui_set_win_height_command): Rename from
1147         tui_set_win_height.
1148         (tui_set_win_height_command): Remove.
1149
1150 2019-07-17  Tom Tromey  <tom@tromey.com>
1151
1152         * tui/tui-source.c (tui_source_window): New constructor.  Add
1153         observer.
1154         (~tui_source_window): New destructor.
1155         (tui_source_window::style_changed): New method.
1156         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1157         (tui_attach_detach_observers): Update.
1158         * tui/tui-data.h (struct tui_source_window): Make constructor not
1159         inline.  Add destructor.
1160         (struct tui_source_window) <style_changed>: New method.
1161         <m_observable>: New member.
1162
1163 2019-07-17  Tom Tromey  <tom@tromey.com>
1164
1165         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1166         * tui/tui-win.c (tui_resize_all): Fix typo.
1167
1168 2019-07-17  Tom Tromey  <tom@tromey.com>
1169
1170         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1171         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1172         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1173         * tui/tui-win.c (window_name_completer): Use foreach.
1174         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1175         (update_tab_width): Likewise.
1176         * tui/tui-layout.c (show_layout): Update.
1177         * tui/tui-data.h (class tui_window_iterator): New.
1178         (struct all_tui_windows): New.
1179         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1180
1181 2019-07-17  Tom Tromey  <tom@tromey.com>
1182
1183         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1184         parameter.  Don't reference globals.
1185         (tui_reg_command): Update.
1186
1187 2019-07-17  Tom Tromey  <tom@tromey.com>
1188
1189         * tui/tui-regs.c (tui_show_registers): Simplify.
1190
1191 2019-07-17  Tom Tromey  <tom@tromey.com>
1192
1193         * tui/tui-regs.c (tui_show_registers): Update.
1194         (tui_show_register_group): Add win_info parameter.
1195
1196 2019-07-17  Tom Tromey  <tom@tromey.com>
1197
1198         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1199         Rename from tui_display_reg_element_at_line.
1200         (tui_data_window::display_registers_from_line): Update.
1201         * tui/tui-data.h (struct tui_data_window)
1202         <display_reg_element_at_line>: New method.
1203
1204 2019-07-17  Tom Tromey  <tom@tromey.com>
1205
1206         * tui/tui-regs.h (tui_display_registers_from)
1207         (tui_display_registers_from_line): Don't declare.
1208         * tui/tui-windata.c (tui_data_window::display_all_data)
1209         (tui_data_window::refresh_all)
1210         (tui_data_window::do_scroll_vertical): Update.
1211         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1212         from tui_display_registers_from.
1213         (tui_display_reg_element_at_line): Update.
1214         (tui_data_window::display_registers_from_line): Rename from
1215         tui_display_registers_from_line.
1216         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1217         display_registers_from_line>: New methods.
1218
1219 2019-07-17  Tom Tromey  <tom@tromey.com>
1220
1221         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1222         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1223         from tui_erase_data_content.
1224         (tui_data_window::display_all_data)
1225         (tui_data_window::refresh_all)
1226         (tui_data_window::do_scroll_vertical): Update.
1227         * tui/tui-regs.c (tui_show_registers): Update.
1228         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1229         New method.
1230
1231 2019-07-17  Tom Tromey  <tom@tromey.com>
1232
1233         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1234         declare.
1235         * tui/tui-windata.c
1236         (tui_data_window::delete_data_content_windows): Rename from
1237         tui_delete_data_content_windows.
1238         (tui_data_window::display_all_data)
1239         (tui_data_window::do_scroll_vertical): Update.
1240         * tui/tui-data.h (struct tui_data_window)
1241         <delete_data_content_windows>: New method.
1242
1243 2019-07-17  Tom Tromey  <tom@tromey.com>
1244
1245         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1246         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1247
1248 2019-07-17  Tom Tromey  <tom@tromey.com>
1249
1250         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1251         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1252         from tui_display_all_data.
1253         * tui/tui-win.c
1254         (tui_data_window::do_make_visible_with_new_height): Update.
1255         * tui/tui-regs.c (tui_show_registers): Update.
1256         * tui/tui-layout.c (tui_set_layout): Update.
1257         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1258         method.
1259
1260 2019-07-17  Tom Tromey  <tom@tromey.com>
1261
1262         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1263         * tui/tui-windata.c (tui_display_data_from): Remove.
1264         (tui_data_window::refresh_all): Update.
1265
1266 2019-07-17  Tom Tromey  <tom@tromey.com>
1267
1268         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1269         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1270         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1271         tui_display_registers_from_line.
1272         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1273         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1274         "force_display" parameter.
1275
1276 2019-07-17  Tom Tromey  <tom@tromey.com>
1277
1278         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1279         declare.
1280         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1281         Rename from tui_first_reg_element_no_inline.
1282         (tui_display_reg_element_at_line)
1283         (tui_display_registers_from_line): Update.
1284         * tui/tui-data.h (struct tui_data_window)
1285         <first_reg_element_no_inline>: New method.
1286
1287 2019-07-17  Tom Tromey  <tom@tromey.com>
1288
1289         * tui/tui-windata.c (tui_display_data_from)
1290         (tui_data_window::do_scroll_vertical): Update.
1291         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1292         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1293         Rename from tui_line_from_reg_element_no.
1294         (tui_display_registers_from_line): Update.
1295         * tui/tui-data.h (struct tui_data_window)
1296         <line_from_reg_element_no>: New method.
1297
1298 2019-07-17  Tom Tromey  <tom@tromey.com>
1299
1300         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1301         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1302         tui_last_regs_line_no.
1303         (tui_display_reg_element_at_line)
1304         (tui_display_registers_from_line): Update.
1305         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1306         method.
1307
1308 2019-07-17  Tom Tromey  <tom@tromey.com>
1309
1310         PR tui/24722:
1311         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1312         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1313         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1314         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1315         (tui_update_breakpoint_info): Likewise.
1316         * tui/tui-hooks.c (tui_event_create_breakpoint)
1317         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1318         Update.
1319
1320 2019-07-17  Tom Tromey  <tom@tromey.com>
1321
1322         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1323
1324 2019-07-17  Tom Tromey  <tom@tromey.com>
1325
1326         * tui/tui-winsource.c (tui_update_source_window_as_is)
1327         (tui_update_source_windows_with_addr): Update.
1328         * tui/tui-source.h (tui_set_source_content)
1329         (tui_show_symtab_source): Add "win_info" parameter.
1330         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1331         parameter.
1332         (tui_show_symtab_source): Likewise.
1333
1334 2019-07-17  Tom Tromey  <tom@tromey.com>
1335
1336         * tui/tui-wingeneral.c
1337         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1338
1339 2019-07-17  Tom Tromey  <tom@tromey.com>
1340
1341         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1342         (struct tui_cmd_window) <can_scroll>: New method.
1343         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1344         method.
1345
1346 2019-07-17  Tom Tromey  <tromey@adacore.com>
1347
1348         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1349         do_field_signed>: Rename.  Change type of "value".
1350         * ui-out.c (ui_out::field_signed): Rename from field_int.
1351         Change type of "value".
1352         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1353         type of "value".
1354         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1355         do_field_int.  Change type of "value".
1356         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1357         do_field_int.  Change type of "value".
1358         * tracepoint.c (trace_status_mi, tfind_1)
1359         (print_one_static_tracepoint_marker): Update.
1360         * thread.c (print_thread_info_1, print_selected_thread_frame):
1361         Update.
1362         * stack.c (print_frame, print_frame_info): Update.
1363         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1364         Update.
1365         * source.c (print_source_lines_base): Update.
1366         * skip.c (info_skip_command): Update.
1367         * record-btrace.c (btrace_ui_out_decode_error)
1368         (btrace_call_history_src_line): Update.
1369         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1370         Update.
1371         * progspace.c (print_program_space): Update.
1372         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1373         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1374         do_field_int.  Change type of "value".
1375         * mi/mi-out.c (mi_ui_out::do_table_begin)
1376         (mi_ui_out::do_table_header): Update.
1377         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1378         type of "value".
1379         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1380         (mi_cmd_data_list_changed_registers, output_register)
1381         (mi_cmd_data_read_memory, mi_load_progress)
1382         (mi_cmd_trace_frame_collected): Update.
1383         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1384         Update.
1385         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1386         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1387         (mi_cmd_var_list_children, varobj_update_one): Update.
1388         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1389         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1390         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1391         * inferior.c (print_inferior): Update.
1392         * gdb_bfd.c (print_one_bfd): Update.
1393         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1394         Update.
1395         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1396         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1397         do_field_int.  Change type of "value".
1398         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1399         do_field_int.  Change type of "value".
1400         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1401         (print_one_breakpoint_location, print_it_catch_fork)
1402         (print_one_catch_fork, print_it_catch_vfork)
1403         (print_one_catch_vfork, print_it_catch_solib)
1404         (print_it_catch_exec, print_it_ranged_breakpoint)
1405         (print_mention_watchpoint, print_mention_masked_watchpoint)
1406         (bkpt_print_it, update_static_tracepoint): Update.
1407         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1408         * break-catch-syscall.c (print_it_catch_syscall): Update.
1409         * ada-tasks.c (print_ada_task_info): Update.
1410         * ada-lang.c (print_it_exception, print_mention_exception):
1411         Update.
1412
1413 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1414
1415         PR breakpoints/24541
1416         * gdbarch.c: Regenerate.
1417         * gdbarch.h: Regenerate.
1418         * gdbarch.sh: Adjust return type and parameter types for
1419         'stap_adjust_register'.
1420         (i386_stap_adjust_register): Adjust signature and return new
1421         register name.
1422         * stap-probe.c (stap_parse_register_operand): Adjust use of
1423         'gdbarch_stap_adjust_register'.
1424
1425 2019-07-17  Tom Tromey  <tromey@adacore.com>
1426
1427         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1428         declare VEC.
1429         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1430         std::vector.
1431         (struct s390_process_info): Add initializers.
1432         (s390_add_process): Use new.
1433         (s390_linux_nat_target::low_forget_process): Use delete.
1434         (s390_linux_nat_target::low_new_fork)
1435         (s390_linux_nat_target::stopped_by_watchpoint)
1436         (s390_linux_nat_target::low_prepare_to_resume)
1437         (s390_linux_nat_target::insert_watchpoint)
1438         (s390_linux_nat_target::insert_hw_breakpoint)
1439         (s390_linux_nat_target::remove_watchpoint)
1440         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1441
1442 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1443
1444         * aarch64-fbsd-nat.c: Include regcache.h.
1445         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1446         argument.
1447         (aarch64_fbsd_nat_target::fetch_registers)
1448         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1449         variable.
1450         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1451
1452 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1453
1454         * fbsd-nat.c: Include gdbarch.h.
1455
1456 2019-07-15  Tom Tromey  <tromey@adacore.com>
1457
1458         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1459
1460 2019-07-15  Tom Tromey  <tromey@adacore.com>
1461
1462         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1463         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1464         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1465         * cli-out.c (cli_ui_out::do_field_int): New method.
1466         * ui-out.c (ui_out::field_unsigned): New method.
1467         * symfile.c (generic_load): Use field_unsigned.
1468         (print_transfer_performance): Likewise.
1469         * record-btrace.c (ui_out_field_uint): Remove.
1470         (btrace_call_history_insn_range, btrace_call_history): Use
1471         field_unsigned.
1472         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1473         field_unsigned.
1474         * ui-out.h (class ui_out) <field_unsigned>: New method.
1475         <do_field_unsigned>: Likewise.
1476
1477 2019-07-15  Tom Tromey  <tromey@adacore.com>
1478
1479         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1480         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1481         * target.c (flash_erase_command): Use field_string.
1482         * infrun.c (print_signal_received_reason): Use field_string.
1483         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1484         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1485         field_string.
1486         * ada-tasks.c (print_ada_task_info): Use field_string.
1487
1488 2019-07-15  Tom Tromey  <tromey@adacore.com>
1489
1490         * target.c (flash_erase_command): Use field_core_addr.
1491         * symfile.c (generic_load): Use field_core_addr.
1492         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1493         Use field_core_addr.
1494         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1495         field_core_addr.
1496
1497 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1498
1499         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1500         value if its desired type is smaller than a CORE_ADDR and signed.
1501
1502 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1503
1504         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1505         of changes to field names, and use new is_reference field to
1506         decide if a property is a reference or not.
1507         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1508         field.
1509         (struct dwarf2_property_baton): Update header comment, rename
1510         'referenced_type' to 'property_type' and update comments.
1511         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1512         default property type, store in property baton, update to take
1513         accound of renamed field.
1514         (read_func_scope): Update call to attr_to_dynamic_prop.
1515         (read_array_type): Likewise.
1516         (dwarf2_per_cu_addr_sized_int_type): New function.
1517         (read_subrange_index_type): Move type finding code to
1518         dwarf2_per_cu_addr_sized_int_type.
1519         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1520         (dwarf2_per_cu_addr_type): New function.
1521         (set_die_type): Update calls to attr_to_dynamic_prop.
1522
1523 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1524
1525         * dwarf2read.c (read_subrange_index_type): New function.
1526         (read_subrange_type): Move code into new function and call it.
1527         * gdbtypes.c (create_range_type): Add some asserts.
1528
1529 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1530
1531         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1532         update return statements.
1533         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1534         declaration, and update comment to match.
1535         * gdbtypes.c (resolve_dynamic_array): Update call to
1536         dwarf2_evaluate_property to match new return type.
1537
1538 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1539
1540         * valarith.c (value_subscripted_rvalue): Change lowerbound
1541         parameter type from int to LONGEST.
1542         * value.h (value_subscripted_rvalue): Likewise in declaration.
1543
1544 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1545
1546         * cli/cli-utils.c (info_print_command_completer): New function.
1547         * cli/cli-utils.h: Add 'completer.h' include, and forward
1548         declaration for 'struct cmd_list_element'.
1549         (info_print_command_completer): Declare.
1550         * stack.c (_initialize_stack): Add completer for 'info locals' and
1551         'info args'.
1552         * symtab.c (_initialize_symtab): Add completer for 'info
1553         variables' and 'info functions'.
1554         * NEWS: Mention completion for additional info commands.
1555
1556 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1557
1558         * cli/cli-utils.c (extract_info_print_args): Delete.
1559         (extract_arg_maybe_quoted): Delete.
1560         (info_print_options_defs): New variable.
1561         (make_info_print_options_def_group): New function.
1562         (extract_info_print_options): Define new function.
1563         * cli/cli-utils.h (extract_info_print_args): Delete.
1564         (struct info_print_options): New structure.
1565         (extract_info_print_options): Declare new function.
1566         * stack.c (info_locals_command): Update to use new
1567         extract_info_print_options, also add a header comment.
1568         (info_args_command): Likewise.
1569         * symtab.c (info_variables_command): Likewise.
1570         (info_functions_command): Likewise.
1571
1572 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1573
1574         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1575         to extract string arguments.
1576         * common/common-utils.c (extract_string_maybe_quoted): New function.
1577         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1578
1579 2019-07-11  Tom Tromey  <tromey@adacore.com>
1580
1581         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1582         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1583         * top.h (gdbinit): Don't declare.
1584         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1585         into...
1586         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1587         * top.c (gdb_init): Don't call init_cli_cmds.
1588         (gdbinit): Remove.
1589         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1590
1591 2019-07-11  Tom Tromey  <tromey@adacore.com>
1592
1593         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1594         after it has been moved.
1595
1596 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1597
1598         * valops.c (value_must_coerce_to_target): Change return type to
1599         bool.
1600         * value.h (value_must_coerce_to_target): Likewise.
1601
1602 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1603
1604         * breakpoint.c (is_hardware_watchpoint): Remove
1605         forward-declaration.
1606         (is_masked_watchpoint): Change return type to bool.
1607         (is_tracepoint): Likewise.
1608         (is_breakpoint): Likewise.
1609         (is_hardware_watchpoint): Likewise.
1610         (is_watchpoint): Likewise.
1611         (is_no_memory_software_watchpoint): Likewise.
1612         (is_catchpoint): Likewise.
1613         (breakpoint_1): Make FILTER parameter's return type bool.
1614         is_masked_watchpoint): Change return type to bool.
1615         (save_breakpoints): Make FILTER parameter's return type bool.
1616         * breakpoint.h (is_breakpoint): Change return type to bool.
1617         (is_watchpoint): Likewise.
1618         (is_catchpoint): Likewise.
1619         (is_tracepoint): Likewise.
1620
1621 2019-07-10  Tom Tromey  <tom@tromey.com>
1622
1623         * defs.h: Don't include gdbarch.h.
1624         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1625         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1626         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1627         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1628         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1629         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1630         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1631         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1632         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1633         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1634         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1635         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1636         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1637         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1638         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1639         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1640         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1641         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1642         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1643         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1644         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1645         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1646         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1647         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1648         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1649         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1650         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1651
1652 2019-07-10  Tom Tromey  <tromey@adacore.com>
1653
1654         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1655         * breakpoint.c (init_ada_exception_breakpoint): Register as
1656         bp_catchpoint.
1657         (print_one_breakpoint_location, print_one_breakpoint): Use
1658         is_ada_exception_catchpoint.
1659         * ada-lang.c (class ada_catchpoint_location): Pass
1660         bp_loc_software_breakpoint to bp_location constructor.
1661         (is_ada_exception_catchpoint): New function.
1662
1663 2019-07-10  Tom Tromey  <tromey@adacore.com>
1664
1665         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1666         VEC.
1667         (struct arm_exidx_entry): New method operator<.
1668         (struct arm_exidx_data) <section_maps>: Change type.
1669         (arm_exidx_data_free): Remove.
1670         (arm_exidx_data_key): Change type.  Move lower.
1671         (arm_exidx_new_objfile): Update.
1672         (arm_compare_exidx_entries): Remove.
1673         (arm_find_exidx_entry, _initialize_arm_tdep)
1674
1675 2019-07-10  Tom Tromey  <tromey@adacore.com>
1676
1677         * solib-spu.c (ocl_program_data_key): Change type.
1678         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1679         Update.
1680
1681 2019-07-10  Tom Tromey  <tromey@adacore.com>
1682
1683         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1684         (struct solib_aix_inferior_data) <library_list>: Change type.
1685         (solib_aix_inferior_data_handle): Change type.
1686         (get_solib_aix_inferior_data): Update.
1687         (solib_aix_free_library_list): Remove.
1688         (library_list_start_library): Update.
1689         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1690         return type.
1691         (solib_aix_get_library_list)
1692         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1693         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1694
1695 2019-07-10  Tom Tromey  <tromey@adacore.com>
1696
1697         * solib-dsbt.c (struct dsbt_info): Add initializers.
1698         (solib_dsbt_pspace_data): Change type.
1699         (dsbt_pspace_data_cleanup): Remove.
1700         (get_dsbt_info, _initialize_dsbt_solib): Update.
1701
1702 2019-07-10  Tom Tromey  <tromey@adacore.com>
1703
1704         * spu-tdep.c (spu_overlay_data): Change type.
1705         (spu_get_overlay_table, spu_overlay_new_objfile)
1706         (_initialize_spu_tdep): Update.
1707
1708 2019-07-10  Tom Tromey  <tromey@adacore.com>
1709
1710         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1711         destructor.
1712         (dbx_objfile_data_key): Change type and declare later.
1713         (DBX_SYMFILE_INFO): Rewrite.
1714         * dbxread.c (dbx_objfile_data_key): Change type.
1715         (dbx_symfile_init): Update.
1716         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1717         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1718         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1719
1720 2019-07-10  Tom Tromey  <tromey@adacore.com>
1721
1722         * jit.c (jit_program_space_key): Change type.  Move lower.
1723         (get_jit_program_space_data): Update.
1724         (jit_program_space_data_cleanup): Remove.
1725         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1726         Update.
1727         (struct jit_program_space_data): Add initializers.
1728
1729 2019-07-10  Tom Tromey  <tromey@adacore.com>
1730
1731         * solib-darwin.c (struct darwin_info): Add initializers.
1732         (solib_darwin_pspace_data): Change type.
1733         (darwin_pspace_data_cleanup): Remove.
1734         (get_darwin_info, _initialize_darwin_solib): Update.
1735
1736 2019-07-10  Tom Tromey  <tromey@adacore.com>
1737
1738         * remote-sim.c (struct sim_inferior_data): Add initializers,
1739         constructor, and destructor.
1740         (sim_inferior_data_key): Change type.  Move lower.
1741         (check_for_duplicate_sim_descriptor): Update.
1742         (get_sim_inferior_data): Use new.  Update.
1743         (~sim_inferior_data_cleanup): Rename from
1744         sim_inferior_data_cleanup.  Simplify.
1745         (gdbsim_close_inferior, simulator_command)
1746         (sim_command_completer, _initialize_remote_sim): Update.
1747         (next_pid, INITIAL_PID): Move earlier.
1748
1749 2019-07-10  Tom Tromey  <tromey@adacore.com>
1750
1751         * python/python-internal.h (create_thread_object): Return
1752         gdbpy_ref.
1753         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1754         * python/py-inferior.c (struct threadlist_entry): Add
1755         constructor.
1756         <thread_obj>: Now a gdbpy_ref.
1757         (thread_to_thread_object): Update.
1758         (add_thread_object): Use new.
1759         (delete_thread_object): Use delete.
1760         (infpy_threads): Update.
1761         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1762         GIL.
1763
1764 2019-07-10  Tom Tromey  <tromey@adacore.com>
1765
1766         * valops.c (value_cast): Specialize error message for Ada.
1767
1768 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1769
1770         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1771
1772 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1773
1774         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1775         bpstat_should_step): Return bool, adjust comments.
1776         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1777         bpstat_should_step): Likewise.
1778
1779 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1780
1781         * features/Makefile: Use feature target descriptions for Arm.
1782         * features/arm/arm-core.c: Generate new file.
1783         * features/arm/arm-fpa.c: Likewise.
1784         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1785         * features/arm/arm-m-profile.c: Likewise.
1786         * features/arm/arm-vfpv2.c: Likewise.
1787         * features/arm/arm-vfpv3.c: Likewise.
1788         * features/arm/xscale-iwmmxt.c: Likewise.
1789         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1790
1791 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1792
1793         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1794         ptrace earlier.
1795
1796 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1797
1798         * features/aarch64-pauth.c: Regenerate.
1799
1800 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1801
1802         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1803         bool.
1804         (bpstat_what): Use false instead of 0.
1805
1806 2019-07-09  Pedro Alves  <palves@redhat.com>
1807
1808         * break-catch-throw.c (is_exception_catchpoint): New.
1809         * breakpoint.c (print_one_breakpoint_location): New parameter
1810         'raw_loc'.  Handle it.  Use
1811         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1812         looking at the breakpoint's type.
1813         (print_one_breakpoint): If handling "maint info breakpoints", also
1814         print locations of exception catchpoints.
1815         * breakpoint.h (is_exception_catchpoint): Declare.
1816
1817 2019-07-09  Pedro Alves  <palves@redhat.com>
1818
1819         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1820         "addr" field.
1821         (allocate_location_exception_catchpoint): New.
1822         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1823         (initialize_throw_catchpoint_ops): Install
1824         allocate_location_exception_catchpoint as allocate_location
1825         method.
1826         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1827         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1828         bp_loc_other.
1829         (breakpoint_address_is_meaningful): Delete.
1830         (bl_address_is_meaningful): New.
1831         (breakpoint_locations_match): Adjust comment.
1832         (bp_location_from_bp_type): New, factored out of...
1833         (bp_location::bp_location(breakpoint *)): ... this.
1834         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1835         factored out of...
1836         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1837         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1838         breakpoint_address_is_meaningful.
1839         (bp_locations_compare): Adjust comment.
1840         (update_global_location_list): Use bl_address_is_meaningful
1841         instead of breakpoint_address_is_meaningful.
1842         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1843         explicit.
1844         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1845         * python/py-breakpoint.c (bppy_get_location): No longer check
1846         whether location is null.
1847
1848 2019-07-09  Pedro Alves  <palves@redhat.com>
1849
1850         PR c++/15468
1851         * breakpoint.c (print_one_breakpoint_location): Remove
1852         single-location assert.
1853
1854 2019-07-09  Tom Tromey  <tom@tromey.com>
1855
1856         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1857         * configure: Rebuild.
1858         * configure.ac: Change common to gdbsupport.
1859         * gdbsupport: Rename from common.
1860         * acinclude.m4: Change common to gdbsupport.
1861         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1862         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1863         gdbsupport.
1864         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1865         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1866         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1867         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1868         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1869         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1870         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1871         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1872         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1873         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1874         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1875         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1876         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1877         coff-pe-read.c, command.h, compile/compile-c-support.c,
1878         compile/compile-c.h, compile/compile-cplus-symbols.c,
1879         compile/compile-cplus-types.c, compile/compile-cplus.h,
1880         compile/compile-loc2c.c, compile/compile.c, completer.c,
1881         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1882         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1883         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1884         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1885         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1886         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1887         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1888         features/aarch64-core.c, features/aarch64-fpu.c,
1889         features/aarch64-pauth.c, features/aarch64-sve.c,
1890         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1891         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1892         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1893         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1894         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1895         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1896         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1897         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1898         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1899         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1900         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1901         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1902         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1903         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1904         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1905         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1906         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1907         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1908         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1909         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1910         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1911         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1912         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1913         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1914         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1915         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1916         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1917         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1918         minsyms.c, mips-linux-tdep.c, namespace.h,
1919         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1920         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1921         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1922         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1923         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1924         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1925         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1926         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1927         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1928         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1929         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1930         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1931         procfs.c, producer.c, progspace.h, psymtab.h,
1932         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1933         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1934         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1935         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1936         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1937         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1938         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1939         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1940         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1941         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1942         target-memory.c, target.c, target.h, target/waitstatus.c,
1943         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1944         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1945         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1946         unittests/array-view-selftests.c,
1947         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1948         unittests/common-utils-selftests.c,
1949         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1950         unittests/format_pieces-selftests.c,
1951         unittests/function-view-selftests.c,
1952         unittests/lookup_name_info-selftests.c,
1953         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1954         unittests/mkdir-recursive-selftests.c,
1955         unittests/observable-selftests.c,
1956         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1957         unittests/parse-connection-spec-selftests.c,
1958         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1959         unittests/scoped_fd-selftests.c,
1960         unittests/scoped_mmap-selftests.c,
1961         unittests/scoped_restore-selftests.c,
1962         unittests/string_view-selftests.c, unittests/style-selftests.c,
1963         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1964         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1965         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1966         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1967         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1968         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1969
1970 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1971
1972         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1973         bool value.
1974         (decode_digits_ordinary): Set explicit_line field in sal.
1975         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1976         symtab_and_line that was set on an explicit line number in
1977         assembler code.  Do always update the recorded symtab and line if
1978         we do skip the prologue.
1979
1980 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1981
1982         * breakpoint.c (set_breakpoint_location_function): Remove
1983         explicit_loc parameter.
1984         (momentary_breakpoint_from_master): Update call to
1985         set_breakpoint_location_function.
1986         (add_location_to_breakpoint): Likewise.
1987
1988 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1989
1990         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1991         required features based on default bfd type when no specific bfd
1992         is present.
1993
1994 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1995
1996         * NEWS: Mention that GDB printf and eval commands can now print
1997         C-style and Ada-style convenience var strings without
1998         calling the inferior.
1999         * printcmd.c (printf_c_string): Locally print GDB internal var
2000         instead of transiting via the inferior.
2001         (printf_wide_c_string): Likewise.
2002
2003 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2004
2005         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2006
2007 2019-07-04  Tom Tromey  <tom@tromey.com>
2008
2009         PR tui/24724:
2010         * tui/tui-winsource.c (tui_clear_source_content): Update.
2011         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2012         (tui_update_breakpoint_info): Update.
2013         (tui_set_exec_info_content): Update.
2014         * tui/tui-source.c (tui_set_source_content_nil): Update.
2015         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2016         has_break.
2017         * tui/tui-data.h (enum tui_bp_flag): New.
2018         (tui_bp_flags): New enum flags type.
2019         (struct tui_source_element) <break_mode>: Change type.  Rename
2020         from has_break.
2021         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2022         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2023         constants.
2024         * tui/tui-winsource.h: Fix comment.
2025
2026 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2027
2028         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2029         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2030         (store_fpregs_to_thread)
2031         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2032         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2033         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2034         (IWMMXT_REGS_SIZE): Add define.
2035         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2036         (fetch_vfp_regs, store_vfp_regs)
2037         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2038         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2039
2040 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2041
2042         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2043         defines.
2044         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2045         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2046         (ARM_INT_REGISTER_SIZE): ...to this.
2047         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2048         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2049         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2050         (arm_linux_collect_gregset, supply_nwfpe_register)
2051         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2052         defines.
2053         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2054         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2055         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2056         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2057         (arm_return_in_memory, arm_store_return_value)
2058         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2059         (arm_record_ld_st_multiple): Likewise.
2060         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2061         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2062
2063 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2064
2065         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2066         AARCH64_DISPLACED_MODIFIED_INSNS.
2067         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2068         (aarch64_displaced_step_copy_insn): Likewise.
2069         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2070         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2071         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2072         ARM_DISPLACED_MODIFIED_INSNS.
2073         * arm-tdep.c (arm_gdbarch_init): Likewise.
2074         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2075         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2076         (struct arm_displaced_step_closure): Use
2077         ARM_DISPLACED_MODIFIED_INSNS.
2078
2079 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2080
2081         * features/Makefile: Remove unused xml files.
2082         * features/aarch64.xml: Remove.
2083         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2084         * features/i386/amd64-avx-avx512.xml: Remove.
2085         * features/i386/amd64-avx-linux.xml: Remove.
2086         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2087         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2088         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2089         * features/i386/amd64-avx-mpx.xml: Remove.
2090         * features/i386/amd64-avx.xml: Remove.
2091         * features/i386/amd64-linux.xml: Remove.
2092         * features/i386/amd64-mpx-linux.xml: Remove.
2093         * features/i386/amd64-mpx.xml: Remove.
2094         * features/i386/amd64.xml: Remove.
2095         * features/i386/i386-avx-avx512-linux.xml: Remove.
2096         * features/i386/i386-avx-avx512.xml: Remove.
2097         * features/i386/i386-avx-linux.xml: Remove.
2098         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2099         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2100         * features/i386/i386-avx-mpx-linux.xml: Remove.
2101         * features/i386/i386-avx-mpx.xml: Remove.
2102         * features/i386/i386-avx.xml: Remove.
2103         * features/i386/i386-linux.xml: Remove.
2104         * features/i386/i386-mmx-linux.xml: Remove.
2105         * features/i386/i386-mmx.xml: Remove.
2106         * features/i386/i386-mpx-linux.xml: Remove.
2107         * features/i386/i386-mpx.xml: Remove.
2108         * features/i386/i386.xml: Remove.
2109         * features/i386/x32-avx-avx512-linux.xml: Remove.
2110         * features/i386/x32-avx-linux.xml: Remove.
2111         * features/i386/x32-linux.xml: Remove.
2112
2113 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2114
2115         * regformats/aarch64.dat: Remove.
2116         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2117         * regformats/i386/amd64-avx-linux.dat: Remove.
2118         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2119         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2120         * regformats/i386/amd64-linux.dat: Remove.
2121         * regformats/i386/amd64-mpx-linux.dat: Remove.
2122         * regformats/i386/amd64.dat: Remove.
2123         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2124         * regformats/i386/i386-avx-linux.dat: Remove.
2125         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2126         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2127         * regformats/i386/i386-linux.dat: Remove.
2128         * regformats/i386/i386-mmx-linux.dat: Remove.
2129         * regformats/i386/i386-mpx-linux.dat: Remove.
2130         * regformats/i386/i386.dat: Remove.
2131         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2132         * regformats/i386/x32-avx-linux.dat: Remove.
2133         * regformats/i386/x32-linux.dat: Remove.
2134
2135 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2136
2137         * aarch64-tdep.c: Remove xml self tests.
2138         * amd64-linux-tdep.c: Likewise.
2139         * amd64-tdep.c: Likewise.
2140         * i386-linux-tdep.c: Likewise.
2141         * i386-tdep.c: Likewise.
2142
2143 2019-07-03  Pedro Alves  <palves@redhat.com>
2144
2145         PR cli/24732
2146         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2147         (pipe_cmd_option_defs): New.
2148         (make_pipe_cmd_options_def_group): New.
2149         (pipe_command): Use gdb::option::process_options.
2150         (pipe_command_completer): New function.
2151         (_initialize_cli_cmds): Install completer for "pipe" command.
2152
2153 2019-07-03  Pedro Alves  <palves@redhat.com>
2154
2155         * cli/cli-option.c (union option_value) <string>: New field.
2156         (struct option_def_and_value): Add ctor, move ctor, dtor and
2157         use DISABLE_COPY_AND_ASSIGN.
2158         (option_def_and_value::clear_value): New.
2159         (parse_option, save_option_value_in_ctx, get_val_type_str)
2160         (add_setshow_cmds_for_options): Handle var_string.
2161         * cli-option.h (union option_def::var_address) <string>: New
2162         field.
2163         (struct string_option_def): New.
2164         * maint-test-options.c (struct test_options_opts): Add default
2165         ctor and use DISABLE_COPY_AND_ASSIGN.
2166         <string_opt>: New field.
2167         (test_options_opts::~test_options_opts): New.
2168         (test_options_opts::dump): Also dump "-string".
2169         (test_options_option_defs): Install "string.
2170
2171 2019-07-03  Pedro Alves  <palves@redhat.com>
2172
2173         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2174         option_value with a null enumeration.
2175         (complete_options): Save the option values in the context.
2176         (save_option_value_in_ctx): New, factored out from ...
2177         (process_options): ... here.
2178         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2179         of the function.
2180         * maint-test-options.c (test_options_opts::dump): New, factored
2181         out from ...
2182         (maintenance_test_options_command_mode): ... here.
2183         (maintenance_test_options_command_completion_result): Delete.
2184         (maintenance_test_options_command_completion_text): Update
2185         comment.
2186         (maintenance_show_test_options_completion_result): Change
2187         prototype.  Just print
2188         maintenance_test_options_command_completion_text.
2189         (save_completion_result): New.
2190         (maintenance_test_options_completer_mode): Pass options context to
2191         complete_options, and then save a dump.
2192         (_initialize_maint_test_options): Use add_cmd to install "maint
2193         show test-options-completion-result".
2194
2195 2019-07-03  Pedro Alves  <palves@redhat.com>
2196
2197         * NEWS (New commands): Mention "with" and "maint with".
2198         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2199         (with_command, with_command_completer): New.
2200         (pipe_command): Adjust to new repeat_previous
2201         interface.
2202         (_initialize_cli_cmds): Install the "with" command and its "w"
2203         alias.
2204         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2205         declarations.
2206         * cli/cli-setshow.c (parse_cli_var_uinteger)
2207         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2208         argument strings for all var_types.
2209         (get_setshow_command_value_string): New, factored out from ...
2210         (do_show_command): ... this.
2211         * cli/cli-setshow.h: Include <string>.
2212         (get_setshow_command_value_string): Declare.
2213         * command.h (repeat_previous): Now returns const char *.  Adjust
2214         comment.
2215         * maint.c: Include "cli/cli-cmds.h".
2216         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2217         (_initialize_maint_cmds): Register the "maintenance with" command.
2218         * top.c (repeat_previous): Move bits from pipe_command here:
2219         Return the saved command line, if any; error out if there's no
2220         command to relaunch.
2221
2222 2019-07-03  Pedro Alves  <palves@redhat.com>
2223
2224         * NEWS (New commands): Mention "maint set/show test-settings"
2225         instead of "maint test-settings".
2226         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2227         (maintenance_test_settings_set_list): Rename to ...
2228         (maintenance_set_test_settings_list): ... this.
2229         (maintenance_test_settings_show_list): Rename to  ...
2230         (maintenance_show_test_settings_list): ... this.
2231         (maintenance_test_settings_cmd): Delete.
2232         (maintenance_test_settings_set_cmd): ...
2233         (maintenance_set_test_settings_cmd): ... this.
2234         (maintenance_test_settings_show_cmd): ...
2235         (maintenance_show_test_settings_cmd): ... this.
2236         (maintenance_test_settings_show_value_cmd):
2237         (maintenance_show_test_settings_value_cmd): ... this.
2238         (_initialize_maint_test_settings): No longer install the "maint
2239         test-settings" prefix command.  Rename "maint test-settings set"
2240         to "maint set test-settings", and "maint test-settings show" to
2241         "maint show test-settings".  Adjust all subcommands.
2242
2243 2019-07-03  Pedro Alves  <palves@redhat.com>
2244
2245         * maint-test-settings.c: Fix file's intro comment.  Replace all
2246         references to "test-options" with references to "test-settings",
2247         in comments.
2248
2249 2019-07-03  Pedro Alves  <palves@redhat.com>
2250
2251         * maint-test-settings.c (maintenance_test_settings_xxx)
2252         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2253         New.
2254         (maintenance_test_settings_enums): Use them.
2255         (maintenance_test_settings_enum): Default to
2256         maintenance_test_settings_xxx.
2257         (_initialize_maint_test_settings): Initialize
2258         MAINTENANCE_TEST_SETTINGS_FILENAME.
2259
2260 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2261
2262         * breakpoint.h (remove_breakpoints_inf): Change return type to
2263         void, move function documentation here.
2264         * breakpoint.c (remove_breakpoints_inf): Change return type to
2265         void, move function documentation to header.
2266
2267 2019-07-02  Pedro Alves  <palves@redhat.com>
2268
2269         * NEWS (Completion improvements): Mention "info threads".
2270         * thread.c (struct info_threads_opts, info_threads_option_defs)
2271         (make_info_threads_options_def_group): New.
2272         (info_threads_command): Use gdb::option::process_options.
2273         (info_threads_command_completer): New.
2274         (_initialize_thread): Use gdb::option::build_help to build the
2275         help text for "info threads".
2276
2277 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2278
2279         * defs.h (generic_load): Move from here...
2280         * symfile.h (generic_load): ... to here.  Rename name parameter
2281         to args.
2282         * symfile.c (generic_load): Add comment.
2283
2284 2019-07-01  Tom Tromey  <tromey@adacore.com>
2285
2286         * dwarf2read.c
2287         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2288         declaration of without_params.  Fix formatting.
2289
2290 2019-07-01  Tom Tromey  <tromey@adacore.com>
2291
2292         * ada-exp.y (find_primitive_type): Update.
2293         * ada-lang.h (ada_lookup_symbol): Update.
2294         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2295         parameter.
2296         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2297
2298 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2299
2300         PR breakpoints/24541
2301         * gdbarch.c: Regenerate.
2302         * gdbarch.h: Regenerate.
2303         * gdbarch.sh: Add 'stap_adjust_register'.
2304         * i386-tdep.c: Include '<unordered_set>'.
2305         (i386_stap_adjust_register): New function.
2306         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2307         * stap-probe.c (stap_parse_register_operand): Call
2308         'gdbarch_stap_adjust_register'.
2309
2310 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2311
2312         PR python/24742
2313         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2314         * python/python.c (do_start_initialization): Use 'xmalloc'
2315         instead of 'PyMem_Malloc'.
2316
2317 2019-06-28  Tom Tromey  <tromey@adacore.com>
2318
2319         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2320         for Ada.
2321
2322 2019-06-27  Tom Tromey  <tromey@adacore.com>
2323
2324         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2325         objfile_key.
2326         (arm_find_mapping_symbol, arm_record_special_symbol)
2327         (_initialize_arm_tdep): Update.
2328         (arm_objfile_data_free): Remove.
2329
2330 2019-06-27  Tom Tromey  <tromey@adacore.com>
2331
2332         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2333         to cp_print_static_field.
2334
2335 2019-06-26  Tom Tromey  <tromey@adacore.com>
2336
2337         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2338         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2339         declare.
2340
2341 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2342
2343         * features/aarch64-core.c (create_feature_aarch64_core):
2344         Regenerate.
2345         * features/aarch64-core.xml: Add cpsr flags.
2346
2347 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2348
2349         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2350         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2351
2352 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2353
2354         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2355         field.
2356         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2357         use.
2358         (arm_record_special_symbol): Don't insert new symbol in sorted
2359         position, push it at the end.
2360
2361 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2362
2363         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2364         (arm_mapping_symbol_s): Remove.
2365         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2366         (arm_mapping_symbol_vec): New typedef.
2367         (struct arm_per_objfile): Add constructor.
2368         <section_maps>: Change type to
2369         std::unique_ptr<arm_mapping_symbol_vec[]>.
2370         (arm_compare_mapping_symbols): Remove.
2371         (arm_find_mapping_symbol): Adjust to section_maps type change.
2372         (arm_objfile_data_free): Call delete on arm_per_objfile.
2373         (arm_record_special_symbol): Adjust to section_maps type change.
2374         Allocate arm_per_objfile with new.
2375
2376 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2377
2378         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2379         with the command prefix.
2380
2381 2019-06-25  Tom Tromey  <tom@tromey.com>
2382
2383         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2384         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2385
2386 2019-06-25  Tom Tromey  <tom@tromey.com>
2387
2388         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2389         type.
2390         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2391         protected.
2392
2393 2019-06-25  Tom Tromey  <tom@tromey.com>
2394
2395         * tui/tui-winsource.c
2396         (tui_source_window_base::set_is_exec_point_at): Add check against
2397         LOA_ADDRESS.
2398
2399 2019-06-25  Tom Tromey  <tom@tromey.com>
2400
2401         * tui/tui-source.c (tui_set_source_content): Don't check before
2402         xfree.
2403         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2404
2405 2019-06-25  Tom Tromey  <tom@tromey.com>
2406
2407         * tui/tui-winsource.h (tui_update_source_window_as_is)
2408         (tui_alloc_source_buffer, tui_line_is_displayed)
2409         (tui_addr_is_displayed): Change type of win_info.
2410         * tui/tui-winsource.c (tui_update_source_window_as_is)
2411         (tui_clear_source_content, tui_show_source_line)
2412         (tui_show_source_content, tui_source_window_base::refill)
2413         (tui_source_window_base::set_is_exec_point_at)
2414         (tui_source_window_base::set_is_exec_point_at)
2415         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2416         (tui_alloc_source_buffer, tui_line_is_displayed)
2417         (tui_addr_is_displayed): Change type of win_info.  Update.
2418         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2419         (tui_source_window_base::do_make_visible_with_new_height):
2420         Update.
2421         * tui/tui-source.c (tui_set_source_content)
2422         (tui_set_source_content_nil)
2423         (tui_source_window::do_scroll_vertical): Update.
2424         * tui/tui-layout.c (show_layout): Update.
2425         * tui/tui-disasm.c (tui_set_disassem_content)
2426         (tui_disasm_window::do_scroll_vertical): Update.
2427         * tui/tui-data.h (tui_win_content): Remove.
2428         (struct tui_gen_win_info) <content, content_size>: Remove.
2429         (struct tui_source_element): Add initializers and destructor.
2430         (union tui_which_element, struct tui_win_element): Remove.
2431         (struct tui_source_window_base) <content>: New field.
2432         (struct tui_data_window): Remove destructor.
2433         (tui_alloc_content, tui_free_win_content)
2434         (tui_free_all_source_wins_content): Don't declare.
2435         * tui/tui-data.c (tui_initialize_static_data): Update.
2436         (init_content_element, tui_alloc_content): Remove.
2437         (~tui_gen_win_info): Update.
2438         (~tui_data_window, tui_free_all_source_wins_content)
2439         (tui_free_win_content, free_content, free_content_elements):
2440         Remove.
2441
2442 2019-06-25  Tom Tromey  <tom@tromey.com>
2443
2444         * tui/tui-winsource.h (tui_clear_source_content)
2445         (tui_erase_source_content, tui_show_source_content): Change type
2446         of win_info.
2447         * tui/tui-winsource.c (tui_clear_source_content)
2448         (tui_erase_source_content, tui_show_source_content): Change type
2449         of win_info.
2450         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2451         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2452         win_info.
2453         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2454         win_info.
2455         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2456
2457 2019-06-25  Tom Tromey  <tom@tromey.com>
2458
2459         * tui/tui-winsource.c (tui_clear_source_content)
2460         (tui_source_window_base::set_is_exec_point_at): Update.
2461         * tui/tui-source.c (tui_set_source_content_nil): Update.
2462         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2463         a bool.
2464         * tui/tui-data.c (init_content_element): Update.
2465
2466 2019-06-25  Tom Tromey  <tom@tromey.com>
2467
2468         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2469         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2470         * tui/tui-layout.c (init_and_make_win): Update.
2471         * tui/tui.h (enum tui_win_type): Update.
2472         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2473         tui_win_is_auxillary.
2474         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2475         tui_win_is_auxillary.
2476
2477 2019-06-25  Tom Tromey  <tom@tromey.com>
2478
2479         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2480         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2481         (tui_delete_data_content_windows, tui_display_all_data)
2482         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2483         Update.
2484         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2485         * tui/tui-regs.c (tui_last_regs_line_no)
2486         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2487         (tui_show_registers): Update.
2488         (tui_show_register_group): Return void.  Update.
2489         (tui_display_registers_from, tui_display_reg_element_at_line)
2490         (tui_display_registers_from_line, tui_check_register_values):
2491         Update.
2492         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2493         member.
2494         (struct tui_data_window) <regs_content>: Now a std::vector.
2495         <regs_content_count>: Remove.
2496         (tui_add_content_elements, tui_free_data_content): Don't declare.
2497         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2498         (init_content_element): Remove DATA_WIN case.  Add assert.
2499         (tui_add_content_elements): Remove.
2500         (tui_data_window): Update.
2501         (tui_free_data_content): Remove.
2502         (free_content_elements): Remove DATA_WIN case.
2503
2504 2019-06-25  Tom Tromey  <tom@tromey.com>
2505
2506         * tui/tui-data.c (tui_data_item_window): Update.
2507         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2508         * tui/tui-windata.c (tui_display_all_data)
2509         (tui_display_data_from_line): Update.
2510         (tui_check_data_values): Remove.
2511         * tui/tui-regs.c (tui_show_register_group)
2512         (tui_display_reg_element_at_line): Update.
2513         * tui/tui-hooks.c (tui_register_changed)
2514         (tui_refresh_frame_and_register_information): Call
2515         tui_check_register_values.
2516         * tui/tui-data.h (struct tui_data_window) <data_content,
2517         data_content_count, data_type>: Remove.
2518         (enum tui_data_type): Remove.
2519
2520         * tui/tui-data.c (tui_data_window::clear_detail)
2521         (~tui_data_window): Update.
2522
2523 2019-06-25  Tom Tromey  <tom@tromey.com>
2524
2525         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2526         declare.
2527         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2528         Rename from tui_first_data_item_displayed.  Update.
2529         (tui_data_window::refresh_all)
2530         (tui_data_window::do_scroll_vertical): Update.
2531         * tui/tui-data.h (struct tui_data_window)
2532         <first_data_item_displayed>: Declare new method.
2533
2534 2019-06-25  Tom Tromey  <tom@tromey.com>
2535
2536         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2537         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2538         contents...
2539         (tui_initialize_static_data): ...here.
2540
2541 2019-06-25  Tom Tromey  <tom@tromey.com>
2542
2543         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2544         (tui_display_registers_from, tui_check_register_values): Update.
2545         (tui_display_register): Remove win_info parameter; update.
2546         (tui_get_register): Change type of parameters.
2547         * tui/tui-data.h (struct tui_data_element): Remove.
2548         (union tui_which_element) <data>: Remove.
2549         <data_window>: Change type.
2550         (struct tui_data_item_window): New.
2551         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2552         case.  Add assert.
2553         (~tui_data_item_window): New destructor.
2554         (free_content_elements): Remove DATA_ITEM_WIN case.
2555
2556 2019-06-25  Tom Tromey  <tom@tromey.com>
2557
2558         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2559         Remove.
2560
2561 2019-06-25  Tom Tromey  <tom@tromey.com>
2562
2563         * tui/tui-data.h (struct tui_command_element): Remove.
2564         (union tui_which_element) <command>: Remove.
2565         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2566         assert.
2567         (free_content_elements): Remove CMD_WIN case.
2568
2569 2019-06-25  Tom Tromey  <tom@tromey.com>
2570
2571         * tui/tui-layout.c (tui_set_layout): Update.
2572         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2573         * tui/tui-data.c (layout_def): Update.
2574
2575 2019-06-25  Tom Tromey  <tom@tromey.com>
2576
2577         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2578         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2579         (tui_source_window_base::set_new_height): Update.
2580         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2581         Update.
2582         (tui_set_locator_fullname, tui_set_locator_info)
2583         (tui_show_frame_info): Update.
2584         * tui/tui-source.c (tui_set_source_content)
2585         (tui_source_is_displayed): Update.
2586         * tui/tui-layout.c (show_source_disasm_command, show_data)
2587         (show_source_or_disasm_and_command): Update.
2588         * tui/tui-disasm.c (tui_set_disassem_content)
2589         (tui_get_begin_asm_address): Update.
2590         * tui/tui-data.h (struct tui_locator_element): Remove.
2591         (union tui_which_element) <locator>: Remove.
2592         (struct tui_locator_window): New.
2593         (tui_locator_win_info_ptr): Change return type.
2594         * tui/tui-data.c (_locator): Change type.
2595         (tui_locator_win_info_ptr): Change return type.
2596         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2597         (tui_alloc_content): Add assert.
2598
2599 2019-06-25  Tom Tromey  <tom@tromey.com>
2600
2601         * tui/tui-winsource.c
2602         (tui_exec_info_window::maybe_allocate_content): New method.
2603         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2604         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2605         (make_source_or_disasm_window): Add cast.
2606         * tui/tui-data.h (union tui_which_element) <simple_string>:
2607         Remove.
2608         (struct tui_source_info): New.
2609         (struct tui_source_window_base) <execution_info>: Change type.
2610         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2611         case, and add assert.
2612         (tui_alloc_content): Add assert.
2613
2614 2019-06-25  Tom Tromey  <tom@tromey.com>
2615
2616         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2617         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2618         * tui/tui-data.c (tui_alloc_win_info): Remove.
2619
2620 2019-06-25  Tom Tromey  <tom@tromey.com>
2621
2622         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2623         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2624         can_highlight.
2625
2626 2019-06-25  Tom Tromey  <tom@tromey.com>
2627
2628         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2629         make_visible_with_new_height method.
2630         (tui_win_info::make_visible_with_new_height): New method.
2631         (tui_source_window_base::do_make_visible_with_new_height)
2632         (tui_data_window::do_make_visible_with_new_height)
2633         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2634         (make_visible_with_new_height): Remove.
2635         (tui_resize_all, tui_adjust_win_heights): Use
2636         make_visible_with_new_height method.
2637         * tui/tui-data.h (struct tui_win_info)
2638         <do_make_visible_with_new_height, make_visible_with_new_height>:
2639         New methods.
2640         (struct tui_source_window_base, struct tui_data_window)
2641         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2642         methods.
2643
2644 2019-06-25  Tom Tromey  <tom@tromey.com>
2645
2646         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2647         method.
2648         (update_tab_width): Call update_tab_width method.
2649         * tui/tui-data.h (struct tui_win_info)
2650         (struct tui_source_window_base) <update_tab_width>: New methods.
2651
2652 2019-06-25  Tom Tromey  <tom@tromey.com>
2653
2654         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2655         parameter.
2656         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2657         parameter.
2658         (tui_gen_win_info::make_visible): Update.
2659         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2660         parameter.
2661         * tui/tui-data.h (enum tui_box): New enum.
2662         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2663
2664 2019-06-25  Tom Tromey  <tom@tromey.com>
2665
2666         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2667         init_and_make_win for EXEC_INFO_WIN.
2668         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2669         longer inline.
2670         (struct tui_win_info) <~tui_win_info>: Inline.
2671         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2672         Don't declare.
2673         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2674         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2675         Remove.
2676         (tui_initialize_static_data): Update.
2677         (~tui_gen_win_info): Handle more cleanup here.
2678         (~tui_source_window_base): Delete "execution_info".
2679         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2680
2681 2019-06-25  Tom Tromey  <tom@tromey.com>
2682
2683         * tui/tui-layout.c (make_command_window): Don't set
2684         can_highlight.
2685         (show_source_disasm_command): Call the reset method.
2686         (show_data): Don't set can_highlight.  Call the reset method.
2687         (tui_gen_win_info::reset): Rename from init_gen_win_info
2688         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2689         (show_source_or_disasm_and_command): Call the reset method.
2690         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2691         (struct tui_cmd_window): Set can_highlight.
2692
2693 2019-06-25  Tom Tromey  <tom@tromey.com>
2694
2695         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2696         from make_visible.
2697         (tui_make_visible, tui_make_invisible): Rewrite.
2698         (tui_win_info::make_visible): Remove.
2699         (tui_source_window_base::make_visible): Update.
2700         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2701         method.  Moved from...
2702         (struct tui_win_info) <make_visible>: ...here.
2703
2704 2019-06-25  Tom Tromey  <tom@tromey.com>
2705
2706         * tui/tui-winsource.c
2707         (tui_source_window_base::do_scroll_horizontal): Remove direction
2708         parameter.
2709         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2710         direction parameter.
2711         * tui/tui-win.c (tui_win_info::forward_scroll)
2712         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2713         (tui_win_info::right_scroll): Update.
2714         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2715         direction parameter.
2716         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2717         direction parameter.
2718         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2719         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2720         Remove direction parameter.
2721         (struct tui_source_window_base, struct tui_source_window)
2722         (struct tui_disasm_window, struct tui_data_window)
2723         (struct tui_cmd_window): Update.
2724
2725 2019-06-25  Tom Tromey  <tom@tromey.com>
2726
2727         * tui/tui-winsource.h (tui_set_exec_info_content)
2728         (tui_show_exec_info_content, tui_erase_exec_info_content)
2729         (tui_clear_exec_info_content, tui_update_exec_info): Change
2730         argument to tui_source_window_base.
2731         * tui/tui-winsource.c (tui_set_exec_info_content)
2732         (tui_show_exec_info_content, tui_erase_exec_info_content)
2733         (tui_clear_exec_info_content, tui_update_exec_info): Change
2734         argument to tui_source_window_base.
2735
2736 2019-06-25  Tom Tromey  <tom@tromey.com>
2737
2738         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2739         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2740
2741 2019-06-25  Tom Tromey  <tom@tromey.com>
2742
2743         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2744         check.
2745
2746 2019-06-25  Tom Tromey  <tom@tromey.com>
2747
2748         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2749         type to void.
2750         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2751         type to void.
2752         * tui/tui-source.c (tui_set_source_content): Update.
2753         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2754
2755 2019-06-25  Tom Tromey  <tom@tromey.com>
2756
2757         * tui/tui-win.c (window_name_completer, tui_set_focus)
2758         (tui_all_windows_info): Use name method.
2759         * tui/tui-data.h (struct tui_gen_win_info)
2760         (struct tui_source_window, struct tui_disasm_window)
2761         (struct tui_data_window, struct tui_cmd_window) <name>: New
2762         method.
2763         (tui_win_name): Don't declare.
2764         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2765         (tui_win_name): Remove.
2766
2767 2019-06-25  Tom Tromey  <tom@tromey.com>
2768
2769         * tui/tui-winsource.h (tui_update_source_window)
2770         (tui_update_source_window_as_is): Change parameter type.
2771         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2772         to be a tui_source_window_base.
2773         (tui_update_source_window_as_is): Likewise.
2774         * tui/tui-win.c (make_visible_with_new_height): Update.
2775
2776 2019-06-25  Tom Tromey  <tom@tromey.com>
2777
2778         * tui/tui-winsource.c (tui_erase_source_content)
2779         (tui_show_source_content, tui_show_exec_info_content)
2780         (tui_erase_exec_info_content): Use refresh_window method.
2781         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2782         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2783         from tui_refresh_win.
2784         (tui_data_window::refresh_window): New method.
2785         (tui_win_info::refresh, tui_source_window_base::refresh)
2786         (tui_refresh_all): Use refresh_window method.
2787         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2788         method.
2789         * tui/tui-regs.c (tui_display_register): Call refresh_window
2790         method.
2791         * tui/tui-layout.c (show_source_disasm_command)
2792         (show_source_or_disasm_and_command): Call refresh_window method.
2793         * tui/tui-data.h (struct tui_gen_win_info)
2794         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2795         New method.
2796
2797 2019-06-25  Tom Tromey  <tom@tromey.com>
2798
2799         * tui/tui.c (tui_rl_other_window, tui_enable)
2800         (tui_is_window_visible, tui_get_command_dimension): Update.
2801         * tui/tui-winsource.c (tui_update_source_window_as_is)
2802         (tui_clear_source_content, tui_erase_source_content)
2803         (tui_show_source_line, tui_source_window_base::refill)
2804         (tui_source_window_base::do_scroll_horizontal)
2805         (tui_source_window_base::set_is_exec_point_at)
2806         (tui_update_breakpoint_info, tui_set_exec_info_content)
2807         (tui_alloc_source_buffer, tui_line_is_displayed)
2808         (tui_addr_is_displayed): Update.
2809         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2810         (tui_check_and_display_highlight_if_needed)
2811         (tui_win_info::make_visible, tui_win_info::refresh)
2812         (tui_refresh_all): Update.
2813         * tui/tui-windata.c (tui_first_data_item_displayed)
2814         (tui_delete_data_content_windows, tui_erase_data_content)
2815         (tui_display_all_data, tui_data_window::refresh_all)
2816         (tui_check_data_values): Update.
2817         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2818         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2819         (tui_win_info::backward_scroll, tui_refresh_all_win)
2820         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2821         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2822         (tui_source_window_base::set_new_height)
2823         (tui_data_window::set_new_height)
2824         (make_invisible_and_set_new_height)
2825         (make_visible_with_new_height, new_height_ok)
2826         (parse_scrolling_args): Update.
2827         * tui/tui-stack.c (tui_show_frame_info): Update.
2828         * tui/tui-source.c (tui_set_source_content)
2829         (tui_set_source_content_nil, tui_source_is_displayed)
2830         (tui_source_window::do_scroll_vertical): Update.
2831         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2832         (tui_display_registers_from, tui_display_reg_element_at_line)
2833         (tui_check_register_values, tui_reg_command): Update.
2834         * tui/tui-layout.c (tui_default_win_height)
2835         (show_source_disasm_command, show_data, init_and_make_win)
2836         (show_source_or_disasm_and_command): Update.
2837         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2838         (tui_redisplay_readline, tui_mld_flush)
2839         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2840         (tui_getc): Update.
2841         * tui/tui-disasm.c (tui_set_disassem_content)
2842         (tui_disasm_window::do_scroll_vertical): Update.
2843         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2844         Now virtual.
2845         (struct tui_win_info): Derive from tui_gen_win_info.
2846         <~tui_win_info>: Mark as override.
2847         <generic>: Remove member.
2848         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2849         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2850         (~tui_data_window, ~tui_win_info)
2851         (tui_free_all_source_wins_content): Update.
2852         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2853
2854 2019-06-25  Tom Tromey  <tom@tromey.com>
2855
2856         * tui/tui-layout.c (init_and_make_win): Use new.
2857         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2858         destructor, initializers.
2859         (tui_alloc_generic_win_info): Don't declare.
2860         * tui/tui-data.c (_locator): Add argument to constructor.
2861         (source_win, disasm_win): New globals.
2862         (exec_info): Remove.
2863         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2864         Update.
2865         (tui_alloc_generic_win_info): Remove.
2866         (init_content_element): Use new.
2867         (tui_win_info::tui_win_info): Update.
2868         (free_content_elements) <case DATA_WIN>: Use delete.
2869
2870 2019-06-25  Tom Tromey  <tom@tromey.com>
2871
2872         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2873         * tui/tui-windata.c (tui_first_data_item_displayed)
2874         (tui_delete_data_content_windows): Update.
2875         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2876         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2877         (tui_display_registers_from, tui_check_register_values): Update.
2878         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2879         pointer.
2880         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2881         window.
2882         (tui_free_data_content): Update.
2883         (free_content_elements) <case DATA_WIN>: Free the window.
2884
2885 2019-06-25  Tom Tromey  <tom@tromey.com>
2886
2887         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2888         Update.
2889         * tui/tui-layout.c (make_command_window)
2890         (show_source_disasm_command, show_data, init_and_make_win)
2891         (show_source_or_disasm_and_command): Update.
2892         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2893         method.
2894         <can_highight, is_highlighted>: Now bool.
2895         (tui_set_win_highlight): Don't declare.
2896         * tui/tui-data.c (tui_set_win_highlight): Remove.
2897
2898 2019-06-25  Tom Tromey  <tom@tromey.com>
2899
2900         * tui/tui-wingeneral.c (make_visible): Remove check of window
2901         type.
2902
2903 2019-06-25  Tom Tromey  <tom@tromey.com>
2904
2905         * tui/tui-win.c (tui_win_info::max_height)
2906         (tui_cmd_window::max_height): New methods.
2907         (new_height_ok): Call max_height.
2908         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2909         <max_height>: New method.
2910
2911 2019-06-25  Tom Tromey  <tom@tromey.com>
2912
2913         * tui/tui-win.c (tui_source_window_base::set_new_height)
2914         (tui_data_window::set_new_height): New methods.
2915         (make_invisible_and_set_new_height): Call set_new_height method.
2916         * tui/tui-data.h (struct tui_win_info)
2917         (struct tui_source_window_base, struct tui_data_window)
2918         <set_new_height>: New method.
2919
2920 2019-06-25  Tom Tromey  <tom@tromey.com>
2921
2922         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2923         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2924         tui_refresh_data_win.
2925         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2926         method.
2927         (tui_refresh_all_win): Call the refresh_all method.
2928         (tui_set_focus): Likewise.
2929         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2930         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2931         Likewise.
2932
2933 2019-06-25  Tom Tromey  <tom@tromey.com>
2934
2935         * tui/tui-winsource.h (tui_refill_source_window)
2936         (tui_set_is_exec_point_at): Don't declare.
2937         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2938         (tui_source_window_base::refill): Rename from
2939         tui_refill_source_window.
2940         (tui_source_window_base::do_scroll_horizontal): Update.
2941         (tui_source_window_base::set_is_exec_point_at): Rename from
2942         tui_set_is_exec_point_at.
2943         (tui_update_all_breakpoint_info): Update.
2944         * tui/tui-stack.c (tui_show_frame_info): Update.
2945         * tui/tui-layout.c (show_data): Add cast.
2946         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2947         * tui/tui-data.h (struct tui_source_window_base) <refill,
2948         set_is_exec_point_at>: New methods.
2949         (tui_source_windows, tui_add_to_source_windows): Update types.
2950         (tui_add_to_source_windows): Remove redundant declaration.
2951         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2952         (tui_source_windows): Change return type.
2953         (tui_clear_source_windows_detail): Update.
2954         (tui_add_to_source_windows): Change type of parameter.
2955         (tui_free_all_source_wins_content): Update.
2956
2957 2019-06-25  Tom Tromey  <tom@tromey.com>
2958
2959         * tui/tui-wingeneral.c (tui_win_info::refresh)
2960         (tui_source_window_base::refresh): New methods.
2961         (tui_refresh_all): Call the refresh method.
2962         * tui/tui-data.h (struct tui_win_info)
2963         (struct tui_source_window_base) <refresh>: New method.
2964
2965 2019-06-25  Tom Tromey  <tom@tromey.com>
2966
2967         * tui/tui.h (tui_is_window_visible): Return bool.
2968         * tui/tui.c (tui_is_window_visible): Return bool.
2969         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2970         (tui_make_visible, tui_make_invisible)
2971         (tui_win_info::make_visible)
2972         (tui_source_window_base::make_visible, make_all_visible)
2973         (tui_make_all_visible, tui_make_all_invisible): Update.
2974         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2975         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2976         bool.
2977         (struct tui_win_info, struct tui_source_window_base)
2978         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2979         * tui/tui-data.c (tui_init_generic_part): Update.
2980
2981 2019-06-25  Tom Tromey  <tom@tromey.com>
2982
2983         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2984         (tui_source_window_base::make_visible): New methods.
2985         (make_all_visible): Make method call.
2986         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2987         (struct tui_source_window_base, struct tui_cmd_window): Override
2988         make_visible.
2989         (tui_win_is_source_type): Don't declare.
2990         * tui/tui-data.c (tui_win_is_source_type): Remove.
2991
2992 2019-06-25  Tom Tromey  <tom@tromey.com>
2993
2994         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2995         NULL check.
2996
2997 2019-06-25  Tom Tromey  <tom@tromey.com>
2998
2999         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3000         Inline constructor.  Add initializers for members.
3001         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3002         constructors; now inline in class.
3003
3004 2019-06-25  Tom Tromey  <tom@tromey.com>
3005
3006         * tui/tui-regs.c (tui_show_registers): Update.
3007         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3008         bool.
3009         * tui/tui-data.c (tui_data_window::clear_detail)
3010         (tui_data_window): Update.
3011
3012 2019-06-25  Tom Tromey  <tom@tromey.com>
3013
3014         * tui/tui-windata.c (tui_display_all_data)
3015         (tui_display_data_from_line, tui_display_data_from)
3016         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3017         Update.
3018         * tui/tui-regs.c (tui_last_regs_line_no)
3019         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3020         (tui_show_registers, tui_show_register_group)
3021         (tui_display_registers_from, tui_display_reg_element_at_line)
3022         (tui_display_registers_from_line, tui_check_register_values)
3023         (tui_reg_next, tui_reg_prev): Update.
3024         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3025         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3026         tui_data_window.
3027         (struct tui_win_info) <detail>: Remove.  Add new fields from
3028         tui_data_info.
3029         (TUI_DATA_WIN): Add cast.
3030         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3031         (~tui_data_window): Simplify.
3032
3033 2019-06-25  Tom Tromey  <tom@tromey.com>
3034
3035         * tui/tui-layout.c (show_source_disasm_command)
3036         (show_source_or_disasm_and_command): Update.
3037         * tui/tui-io.c (update_cmdwin_start_line)
3038         (tui_redisplay_readline): Update.
3039         * tui/tui-data.h (struct tui_command_info): Remove.
3040         (struct tui_win_info) <detail>: Remove command_info member.
3041         (struct tui_data_window) <start_line>: New member, from
3042         tui_command_info.
3043         (TUI_CMD_WIN): Add casts.
3044
3045 2019-06-25  Tom Tromey  <tom@tromey.com>
3046
3047         * tui/tui-winsource.c (tui_update_source_window)
3048         (tui_refill_source_window)
3049         (tui_source_window_base::do_scroll_horizontal)
3050         (tui_update_breakpoint_info, tui_set_exec_info_content)
3051         (tui_show_exec_info_content, tui_erase_exec_info_content)
3052         (tui_clear_exec_info_content): Update.
3053         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3054         Update.
3055         * tui/tui-win.c (make_invisible_and_set_new_height)
3056         (make_visible_with_new_height): Update.
3057         * tui/tui-source.c (tui_set_source_content)
3058         (tui_show_symtab_source): Update.
3059         * tui/tui-layout.c (extract_display_start_addr)
3060         (show_source_disasm_command, show_data)
3061         (make_source_or_disasm_window)
3062         (show_source_or_disasm_and_command): Update.
3063         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3064         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3065         "gdbarch".
3066         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3067         to tui_source_window_base.
3068         (struct tui_win_info) <detail>: Remove source_info member.
3069         (struct tui_source_window_base) <has_locator>: Inline.
3070         Move contents from tui_source_info; rename has_locator member to
3071         m_has_locator.
3072         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3073         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3074         header file.
3075         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3076         Simplify.
3077         (tui_free_all_source_wins_content): Cast to
3078         tui_source_window_base.
3079
3080 2019-06-25  Tom Tromey  <tom@tromey.com>
3081
3082         * tui/tui-win.c (make_invisible_and_set_new_height)
3083         (make_visible_with_new_height): Call has_locator method.
3084         * tui/tui-layout.c (show_source_disasm_command, show_data)
3085         (show_source_or_disasm_and_command): Update for bool change.
3086         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3087         (tui_win_info) <has_locator>: New method.
3088         (struct tui_source_window_base) <has_locator>: New method.
3089         (tui_win_has_locator): Don't declare.
3090         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3091         from tui_win_has_locator.
3092         (tui_source_window_base): Use false, not FALSE.
3093
3094 2019-06-25  Tom Tromey  <tom@tromey.com>
3095
3096         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3097         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3098         clear_detail method directly.
3099         (tui_clear_win_detail): Remove.
3100
3101 2019-06-25  Tom Tromey  <tom@tromey.com>
3102
3103         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3104         "this", not TUI_DISASM_WIN.
3105
3106 2019-06-25  Tom Tromey  <tom@tromey.com>
3107
3108         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3109         declare.
3110         * tui/tui-winsource.c
3111         (tui_source_window_base::do_scroll_horizontal): Rename from
3112         tui_horizontal_source_scroll.
3113         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3114         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3115         from tui_vertical_data_scroll.
3116         * tui/tui-win.h (tui_scroll): Don't declare.
3117         * tui/tui-win.c (tui_win_info::forward_scroll)
3118         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3119         (tui_win_info::right_scroll): Rename and update.
3120         (tui_scroll_forward_command, tui_scroll_backward_command)
3121         (tui_scroll_left_command, tui_scroll_right_command): Update.
3122         (tui_scroll): Remove.
3123         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3124         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3125         from tui_vertical_source_scroll.
3126         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3127         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3128         from tui_vertical_disassem_scroll.
3129         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3130         do_scroll_horizontal>: New methods.
3131         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3132         Likewise.
3133         (struct tui_source_window_base): Add do_scroll_horizontal.
3134         (struct tui_source_window, struct tui_disasm_window): Add
3135         do_scroll_vertical.
3136         (struct tui_data_window, struct tui_cmd_window): Add
3137         do_scroll_horizontal and do_scroll_vertical.
3138         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3139
3140 2019-06-25  Tom Tromey  <tom@tromey.com>
3141
3142         * tui/tui-data.h (struct tui_source_window_base): New struct.
3143         (struct tui_source_window): Derive from tui_source_window_base.
3144         (struct tui_disasm_window): New struct.
3145         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3146         from tui_source_window::clear_detail.
3147         (tui_source_window_base): Rename from tui_source_window.
3148         (~tui_source_window_base): Rename from ~tui_source_window.
3149         (tui_alloc_win_info): Create a tui_disasm_window.
3150
3151 2019-06-25  Tom Tromey  <tom@tromey.com>
3152
3153         * tui/tui-data.h (struct tui_source_window)
3154         (struct tui_data_window): Declare destructors.
3155         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3156         destructors.
3157         (tui_win_info): Simplify.
3158
3159 2019-06-25  Tom Tromey  <tom@tromey.com>
3160
3161         * tui/tui-winsource.c (tui_display_main)
3162         (tui_update_source_windows_with_addr)
3163         (tui_update_all_breakpoint_info): Update.
3164         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3165         (new_height_ok, parse_scrolling_args): Update.
3166         * tui/tui-stack.c (tui_show_frame_info): Update.
3167         * tui/tui-data.h (struct tui_list): Remove.
3168         (tui_source_windows): Return a reference to a std::vector.
3169         * tui/tui-data.c (source_windows): Now a std::vector.
3170         (tui_source_windows): Change return type.
3171         (tui_clear_source_windows): Rewrite.
3172         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3173         (tui_free_all_source_wins_content): Rewrite.
3174
3175 2019-06-25  Tom Tromey  <tom@tromey.com>
3176
3177         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3178         (struct tui_data_window, struct tui_cmd_window): Declare
3179         clear_detail method.
3180         * tui/tui-data.c (tui_source_window::clear_detail)
3181         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3182         methods.
3183         (tui_clear_win_detail): Simplify.
3184
3185 2019-06-25  Tom Tromey  <tom@tromey.com>
3186
3187         * tui/tui-layout.c (make_source_window, make_disasm_window)
3188         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3189         Return the new window.
3190         (show_source_disasm_command, show_data)
3191         (show_source_or_disasm_and_command): Update.
3192
3193 2019-06-25  Tom Tromey  <tom@tromey.com>
3194
3195         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3196         parameter.  Return the new window.
3197         (show_source_disasm_command): Update and remove NULL check.
3198         (show_source_or_disasm_and_command): Update.
3199
3200 2019-06-25  Tom Tromey  <tom@tromey.com>
3201
3202         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3203
3204 2019-06-25  Tom Tromey  <tom@tromey.com>
3205
3206         * tui/tui-data.h (struct tui_win_info): Make constructor
3207         protected.  Make destructor virtual.  Add initializers.
3208         (tui_source_window, tui_data_window, tui_cmd_window): New
3209         classes.
3210         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3211         constructor.  Add "type" parameter.
3212         (tui_source_window, tui_data_window, tui_cmd_window): New
3213         constructors.
3214         (tui_alloc_win_info): Instantiate the appropriate subclass.
3215
3216 2019-06-25  Tom Tromey  <tom@tromey.com>
3217
3218         * tui/tui-win.c (tui_resize_all): Use delete.
3219         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3220         destructor.
3221         (tui_free_window): Don't declare.
3222         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3223         Update.
3224
3225 2019-06-25  Tom Tromey  <tom@tromey.com>
3226
3227         * tui/tui-data.h (struct tui_win_info): Add constructor.
3228         * tui/tui-data.c (tui_alloc_win_info): Use new.
3229         (tui_free_window): Use delete.
3230
3231 2019-06-22  Tom Tromey  <tom@tromey.com>
3232
3233         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3234         declare.
3235         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3236
3237 2019-06-22  Tom Tromey  <tom@tromey.com>
3238
3239         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3240         declare.
3241         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3242
3243 2019-06-22  Tom de Vries  <tdevries@suse.de>
3244
3245         * dwarf2read.c (create_addrmap_from_aranges)
3246         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3247         instead of '%zu'.
3248
3249 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3250
3251         * dwarf2read.h (dwarf2_section_info_def): Remove.
3252         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3253         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3254         std::vector<dwarf2_section_info>.
3255         (struct dwo_file) <~dwo_file>: Remove.
3256         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3257         types field.
3258         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3259         (dwarf2_read_debug_names): Likewise.
3260         (create_debug_types_hash_table): Change parameter type to
3261         array_view, adjust code accordingly.
3262         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3263         (partial_die_info::fixup): Likewise.
3264         (determine_prefix): Likewise.
3265         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3266
3267 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3268
3269         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3270         gdb_bfd_ref_ptr.
3271         <~dwo_file>: Remove call to gdb_bfd_unref.
3272         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3273         gdb_bfd_ref_ptr::get.
3274
3275 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3276
3277         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3278         type to htab_up.
3279         * dwarf2read.c (struct dwo_file): Initialize fields.
3280         <~dwo_file>: New.
3281         (free_dwo_file): Remove, move content to ~dwo_file.
3282         (struct dwo_file_deleter): Remove.
3283         (dwo_file_up>: Remove custom deleter.
3284         (free_dwo_files): Remove.
3285         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3286         dwo_files.
3287         (process_skeletonless_type_units): Call unique_ptr::get.
3288         (allocate_dwo_file_hash_table): Add deleter to created hash
3289         table.  Change return type to htab_up.
3290         (lookup_dwo_file_slot): Don't memset dwo_file, call
3291         unique_ptr::get.
3292         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3293         (create_dwo_unit_in_dwp_v2): Likewise.
3294         (open_and_init_dwo_file): Likewise.
3295         (free_dwo_file_from_slot): Remove.
3296
3297 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3298
3299         * dwarf2read.h (struct dwarf2_section_info) <readin,
3300         is_virtual>: Change type to bool.
3301         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3302         true instead of 1.
3303
3304 2019-06-19  Tom Tromey  <tom@tromey.com>
3305
3306         * tui/tui-data.h (tui_init_content_element): Don't declare.
3307
3308 2019-06-19  Tom Tromey  <tom@tromey.com>
3309
3310         * tui/tui-data.h (tui_init_win_info): Don't declare.
3311
3312 2019-06-19  Tom de Vries  <tdevries@suse.de>
3313
3314         * dwarf2read.h (abstract_to_concrete): Change type to
3315         std::unordered_map<sect_offset, std::vector<sect_offset>,
3316         gdb::hash_enum<sect_offset>>.
3317
3318 2019-06-19  Tom Tromey  <tromey@adacore.com>
3319
3320         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3321         EVAL_AVOID_SIDE_EFFECTS specially.
3322
3323 2019-06-19  Tom Tromey  <tromey@adacore.com>
3324
3325         * source-cache.c (highlighter): New global.
3326         (source_cache::get_source_lines): Create a highlighter on demand.
3327
3328 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3329
3330         * defs.h (deprecated_interactive_hook): Delete declaration.
3331         * interps.c (clear_interpreter_hooks): Remove use of
3332         deprecated_interactive_hook.
3333         * top.c (deprecated_interactive_hook): Delete definition.
3334         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3335
3336 2019-06-18  Tom de Vries  <tdevries@suse.de>
3337
3338         PR gdb/24515
3339         * dwarf2read.h (abstract_to_concrete): Change type from
3340         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3341         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3342         * dwarf2read.c (read_variable): Update.
3343         (dwarf2_fetch_die_loc_sect_off): Update.
3344
3345 2019-06-17  Tom de Vries  <tdevries@suse.de>
3346
3347         PR gdb/24617
3348         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3349         accessing parent[parent_len - 1].
3350
3351 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3352
3353         PR gdb/24364
3354         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3355         call dtrace_process_dof with NULL dof.
3356
3357 2019-06-16  Tom de Vries  <tdevries@suse.de>
3358
3359         PR gdb/24445
3360         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3361
3362 2019-06-16  Tom Tromey  <tom@tromey.com>
3363
3364         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3365         (make_all_visible): Use address of member.
3366
3367 2019-06-16  Tom Tromey  <tom@tromey.com>
3368
3369         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3370         (tui_free_window, free_content, free_content_elements): Remove
3371         unnecessary cast.
3372         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3373         cast.
3374         * tui/tui-regs.c (tui_show_register_group)
3375         (tui_display_registers_from, tui_display_reg_element_at_line):
3376         Remove unnecessary cast.
3377
3378 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3379
3380         * linux-nat.c (normal_mask): Delete.
3381         (_initialize_linux_nat): Don't initialise normal_mask.
3382
3383 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3384
3385         PR gdb/24445
3386         * dwarf-index-write.h (write_psymtabs_to_index): Add
3387         dwz_basename parameter.
3388         * dwarf-index-write.c (write_gdbindex): Move file writing to
3389         write_gdbindex_1.  Change return type void.
3390         (assert_file_size): Move up, remove filename parameter.
3391         (write_gdbindex_1): New function.
3392         (write_debug_names): Change return type to void, call
3393         assert_file_size.
3394         (struct index_wip_file): New struct.
3395         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3396         file logic to index_wip_file.  Write index for dwz file if
3397         needed.
3398         (save_gdb_index_command): Pass basename of dwz file, if present.
3399         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3400         build-id of dwz file, if present.
3401         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3402         (dwarf2_get_dwz_file): Likewise.
3403         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3404         (dwarf2_get_dwz_file): Likewise.
3405
3406 2019-06-16  Tom Tromey  <tom@tromey.com>
3407
3408         * coffread.c (process_coff_symbol): Use xstrdup.
3409         * value.c (create_internalvar): Use xstrdup.
3410
3411 2019-06-16  Tom Tromey  <tom@tromey.com>
3412
3413         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3414         * breakpoint.c (stopin_command, stopat_command)
3415         (until_break_command, decode_location_default): Remove unnecessary
3416         cast.
3417         * utils.c (subset_compare): Remove unnecessary cast.
3418         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3419         cast.
3420         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3421         cast.
3422         * infcmd.c (path_command): Remove unnecessary cast.
3423         * coffread.c (decode_type): Remove unnecessary cast.
3424         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3425         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3426         * tui/tui-stack.c (tui_show_locator_content)
3427         (tui_show_frame_info): Remove unnecessary cast.
3428         * tui/tui-win.c (tui_scroll_forward_command)
3429         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3430         (parse_scrolling_args): Remove unnecessary cast.
3431         * tui/tui-data.c (init_win_info, tui_del_window)
3432         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3433         (free_content_elements): Remove unnecessary cast.
3434         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3435         unnecessary cast.
3436         * tui/tui-source.c (tui_set_source_content)
3437         (tui_vertical_source_scroll): Remove unnecessary cast.
3438         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3439         cast.
3440         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3441         * tui/tui-regs.c (tui_display_registers_from)
3442         (tui_display_register): Remove unnecessary cast.
3443         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3444         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3445         (make_visible): Remove unnecessary cast.
3446         * tui/tui-winsource.c (tui_erase_source_content)
3447         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3448         unnecessary cast.
3449         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3450         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3451         * stabsread.c (read_type, read_array_type, read_range_type):
3452         Remove unnecessary cast.
3453         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3454         (parse_symbol, parse_type, upgrade_type, parse_external)
3455         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3456         unnecessary cast.
3457         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3458
3459 2019-06-16  Tom Tromey  <tom@tromey.com>
3460
3461         * tui/tui-data.c (tui_alloc_generic_win_info)
3462         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3463         checks.
3464
3465 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3466             Andrew Burgess  <andrew.burgess@embecosm.com>
3467
3468         * f-typeprint.c (f_print_type): Don't return early for not
3469         associated or not allocated types.
3470         (f_type_print_varspec_suffix): Add print_rank parameter and print
3471         ranks of array types in case they dangling.
3472         (f_type_print_base): Add print_rank parameter.
3473
3474 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3475
3476         * NEWS: Mention new MI commands.
3477         * break-catch-throw.c (enum exception_event_kind): Move to
3478         breakpoint.h.
3479         (print_mention_exception_catchpoint): Output text as a single
3480         message.
3481         (catch_exception_command_1): Rename to...
3482         (catch_exception_event): ...this, make non-static, update header
3483         command, and change some parameter types.
3484         (catch_catch_command): Update for changes to
3485         catch_exception_command_1.
3486         (catch_throw_command): Likewise.
3487         (catch_rethrow_command): Likewise.
3488         * breakpoint.c (enum exception_event_kind): Delete.
3489         * breakpoint.h (enum exception_event_kind): Moved here from
3490         break-catch-throw.c.
3491         (catch_exception_event): Declare.
3492         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3493         (mi_cmd_catch_throw): New function.
3494         (mi_cmd_catch_rethrow): New function.
3495         (mi_cmd_catch_catch): New function.
3496         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3497         'catch-catch' entries.
3498         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3499         (mi_cmd_catch_rethrow): Declare.
3500         (mi_cmd_catch_catch): Declare.
3501
3502 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3503
3504         * annotate.c (annotate_source_line): Change return type to void,
3505         update implementation to match.
3506         * annotate.h (annotate_source_line): Change return type to void,
3507         update header comment.
3508         * stack.c (print_frame_info): Don't change what frame information
3509         is printed based on whether annotations are on or not.
3510
3511 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3512
3513         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3514         (annotate_source): Make static.
3515         (annotate_source_line): Moved from source.c and renamed from
3516         identify_source_line.  Update the return type.
3517         * annotate.h (annotate_source): Delete declaration.
3518         (annotate_source_line): Declaration moved from source.h, and
3519         renamed from identify_source_line.  Return type updated.
3520         * source.c (identify_source_line): Moved to annotate.c and renamed
3521         to annotate_source_line.
3522         (info_line_command): Remove check of annotation_level.
3523         * source.h (identify_source_line): Move declaration to annotate.h
3524         and rename to annotate_source_line.
3525         * stack.c: Add 'annotate.h' include.
3526         (print_frame_info): Remove check of annotation_level before
3527         calling annotate_source_line.
3528
3529 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3530
3531         * source-cache.c (source_cache::get_plain_source_lines): Use
3532         open_source_file_with_line_charpos instead of just
3533         open_source_file, remove call to find_source_lines.
3534         (source_cache::get_source_lines): Likewise.
3535         * source.c (find_source_lines): Make static.
3536         (get_filename_and_charpos): Renamed into...
3537         (open_source_file_with_line_charpos): ..this along with changes to
3538         return a scoped_fd, and some other minor clean ups.
3539         (identify_source_line): Use open_source_file_with_line_charpos.
3540         (search_command_helper): Use open_source_file_with_line_charpos
3541         instead of just open_source_file, remove call to
3542         find_source_lines.
3543         * source.h (open_source_file_with_line_charpos): Declare new
3544         function.
3545         (find_source_lines): Delete declaration.
3546
3547 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3548
3549         * source.c (get_filename_and_charpos): Remove fullname
3550         parameter.
3551         (identify_source_line): Update call to get_filename_and_charpos.
3552
3553 2019-06-14  Tom Tromey  <tromey@adacore.com>
3554
3555         PR gdb/24502:
3556         * ui-style.h (skip_ansi_escape): Update comment.
3557         * ui-file.h (class no_terminal_escape_file): New class.
3558         * ui-file.c (no_terminal_escape_file::write)
3559         (no_terminal_escape_file::puts): New methods.
3560         * cli/cli-logging.c (handle_redirections): Use
3561         no_terminal_escape_file.
3562
3563 2019-06-14  Tom Tromey  <tromey@adacore.com>
3564
3565         * NEWS: Move convenience variable news above Python news.
3566
3567 2019-06-14  Tom Tromey  <tom@tromey.com>
3568
3569         * gnulib: Move directory to top-level.
3570         * configure.ac: Don't configure gnulib.
3571         * configure: Rebuild.
3572         * common/common-defs.h: Use new path to gnulib.
3573         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3574         (GNULIB_H): Remove.
3575         (INCGNU): Look in new gnulib location.
3576         (HFILES_NO_SRCDIR): Remove gnulib files.
3577         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3578         (generated_files): Remove GNULIB_H.
3579         ($(LIBGNU), all-lib): Remove targets.
3580         (distclean): Don't mention GNULIB_BUILDDIR.
3581         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3582
3583 2019-06-14  Tom Tromey  <tromey@adacore.com>
3584
3585         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3586         Warn if symbol file does not provide any symbols.
3587
3588 2019-06-14  Tom Tromey  <tromey@adacore.com>
3589
3590         * source.c (find_and_open_source): Respect basenames_may_differ.
3591
3592 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3593
3594         * annotate.c (annotate_breakpoints_invalid): Make use of
3595         scoped_restore_terminal_state.
3596         (annotate_frames_invalid): Likewise.
3597
3598 2019-06-14  Tom Tromey  <tromey@adacore.com>
3599
3600         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3601         allow assignment to an internalvar.
3602
3603 2019-06-14  Tom Tromey  <tromey@adacore.com>
3604
3605         * ada-lex.l: Allow "_" in attribute names.
3606
3607 2019-06-14  Tom Tromey  <tromey@adacore.com>
3608
3609         PR gdb/24653:
3610         * regcache.c (registers_changed): Don't call alloca.
3611         * top.c (execute_command): Don't call alloca.
3612
3613 2019-06-13  Pedro Alves  <palves@redhat.com>
3614
3615         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3616         'expression'.  When parsing an expression, error out if there's
3617         junk after "unlimited".
3618         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3619         (do_set_command): Adjust calls to is_unlimited_literal.
3620
3621 2019-06-13  Pedro Alves  <palves@redhat.com>
3622
3623         * compile/compile.c (make_compile_options_def_group): Add braces
3624         around array_view initializer.
3625         * thread.c (make_thread_apply_all_options_def_group)
3626         (make_thread_apply_all_options_def_group): Likewise.
3627
3628 2019-06-13  Pedro Alves  <palves@redhat.com>
3629
3630         * NEWS (New commands): Mention "maint test-options
3631         require-delimiter", "maint test-options unknown-is-error", "maint
3632         test-options unknown-is-operand" and "maint show
3633         test-options-completion-result".
3634         (New command options, command completion): New section.
3635         (Completion improvements): New section.
3636         Mention that you can abbreviate "unlimited".
3637
3638 2019-06-13  Pedro Alves  <palves@redhat.com>
3639
3640         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3641         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3642         * unittests/cli-utils-selftests.c (test_parse_flags)
3643         (test_parse_flags_qcs): Delete.
3644         (test_cli_utils): Don't call deleted functions.
3645
3646 2019-06-13  Pedro Alves  <palves@redhat.com>
3647
3648         * thread.c: Include "cli/cli-option.h".
3649         (tp_array_compar_ascending): Global.
3650         (tp_array_compar): Delete function.
3651         (tp_array_compar_ascending, tp_array_compar_descending): New
3652         functions.
3653         (ascending_option_def, qcs_flag_option_def)
3654         (thr_qcs_flags_option_defs)
3655         (make_thread_apply_all_options_def_group)
3656         (make_thread_apply_options_def_group): New.
3657         (thread_apply_all_command): Use gdb::option::process_options.
3658         (thread_apply_command_completer)
3659         (thread_apply_all_command_completer): New.
3660         (thread_apply_command): Use gdb::option::process_options.
3661         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3662         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3663         to generate help text of "thread apply".  Adjust "taas"'s help.
3664         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3665         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3666
3667 2019-06-13  Pedro Alves  <palves@redhat.com>
3668
3669         * thread.c (thread_apply_command): Check for invalid TID with
3670         isdigit instead of !isalpha.
3671
3672 2019-06-13  Pedro Alves  <palves@redhat.com>
3673
3674         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3675         (validate_flags_qcs): New.
3676         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3677         (validate_flags_qcs): Declare.
3678         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3679         (make_frame_apply_options_def_group): New.
3680         (frame_apply_command_count): Process options with
3681         gdb::option::process_options.
3682         (frame_apply_completer): New.
3683         (frame_apply_level_completer, frame_apply_all_completer)
3684         (frame_apply_completer): New.
3685         (_initialize_stack): Update help of "frame apply", "frame apply
3686         level", "frame apply all" and "faas" to mention supported options
3687         and install command completers.
3688         * stack.h (frame_apply_all_completer): Declare.
3689         * thread.c: Include "stack.h".
3690         (tfaas_command): Add "--".
3691         (_initialize_thread): Update help "tfaas" to mention supported
3692         options and install command completer.
3693
3694 2019-06-13  Pedro Alves  <palves@redhat.com>
3695
3696         * completer.c (complete_nested_command_line): New.
3697         (gdb_completion_word_break_characters_throw): Add assertion.
3698         * completer.h (complete_nested_command_line): Declare.
3699
3700 2019-06-13  Pedro Alves  <palves@redhat.com>
3701
3702         * stack.c (parse_backtrace_qualifiers): New.
3703         (backtrace_command): Use it.
3704         (backtrace_command_completer): Complete on qualifiers.
3705
3706 2019-06-13  Pedro Alves  <palves@redhat.com>
3707
3708         * frame.c: Include "cli/cli-option.h.
3709         (user_set_backtrace_options): New.
3710         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3711         Delete.
3712         (get_prev_frame): Adjust.
3713         (boolean_option_def, uinteger_option_def)
3714         (set_backtrace_option_defs): New.
3715         (_initialize_frame): Adjust and use
3716         gdb::option::add_setshow_cmds_for_options to install "set
3717         backtrace past-main" and "set backtrace past-entry".
3718         * frame.h: Include "cli/cli-option.h".
3719         (struct frame_print_options): Forward declare.
3720         (print_frame_arguments_all, print_frame_arguments_scalars)
3721         (print_frame_arguments_none): Declare.
3722         (print_entry_values): Delete declaration.
3723         (struct frame_print_options, user_frame_print_options): New.
3724         (struct set_backtrace_options): New.
3725         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3726         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3727         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3728         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3729         (list_args_or_locals): Add frame_print_options parameter.
3730         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3731         * python/py-framefilter.c (enumerate_args): Pass down
3732         USER_FRAME_PRINT_OPTIONS.
3733         * stack.c: Include "cli/cli-option.h".
3734         (print_frame_arguments_all, print_frame_arguments_scalars)
3735         (print_frame_arguments_none): Declare.
3736         (print_raw_frame_arguments, print_entry_values): Delete.
3737         (user_frame_print_options): New.
3738         (boolean_option_def, enum_option_def, frame_print_option_defs):
3739         New.
3740         (struct backtrace_cmd_options): New.
3741         (bt_flag_option_def): New.
3742         (backtrace_command_option_defs): New.
3743         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3744         (print_frame_arg, read_frame_arg, print_frame_args)
3745         (print_frame_info, print_frame): Add frame_print_options parameter
3746         and use it.
3747         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3748         (backtrace_command_1): Add frame_print_options and
3749         backtrace_cmd_options parameters and use them.
3750         (make_backtrace_options_def_group): New.
3751         (backtrace_command): Process command options with
3752         gdb::option::process_options.
3753         (backtrace_command_completer): New.
3754         (_initialize_stack): Extend "backtrace"'s help to mention
3755         supported options.  Install completer for "backtrace".
3756         Install some settings commands with add_setshow_cmds_for_options.
3757
3758 2019-06-13  Pedro Alves  <palves@redhat.com>
3759
3760         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3761         and that "set/show print raw frame-arguments" are now deprecated.
3762
3763         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3764         command.
3765         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3766         * stack.c (_initialize_stack): Install "set/show print
3767         raw-frame-arguments", and deprecate "set/show print raw
3768         frame-arguments".
3769         * valprint.c (_initialize_valprint): Deprecate "set/show print
3770         raw".
3771
3772 2019-06-13  Pedro Alves  <palves@redhat.com>
3773
3774         * compile/compile.c (struct compile_options): New.
3775         (compile_flag_option_def, compile_command_option_defs)
3776         (make_compile_options_def_group): New.
3777         (compile_file_command): Handle options with
3778         gdb::option::process_options.
3779         (compile_file_command_completer): New function.
3780         (compile_code_command): Handle options with
3781         gdb::option::process_options.
3782         (compile_code_command_completer): New function.
3783         (_initialize_compiler): Install completers for "compile code" and
3784         "compile file".  Mention available options in "compile code" and
3785         "compile code"'s help.
3786         * completer.c (advance_to_completion_word): New, factored out from
3787         ...
3788         (advance_to_expression_complete_word_point): ... this.
3789         (advance_to_filename_complete_word_point): New.
3790         * completer.h (advance_to_filename_complete_word_point): New
3791         declaration.
3792
3793 2019-06-13  Pedro Alves  <palves@redhat.com>
3794
3795         * compile/compile.c: Include "cli/cli-option.h".
3796         (compile_print_value): Scope data pointer is now a
3797         value_print_options pointer; adjust.
3798         (compile_print_command): Process options.  Scope data pointer is
3799         now a value_print_options pointer; adjust.
3800         (_initialize_compile): Update "compile print"'s help to include
3801         supported options.  Install a completer for "compile print".
3802         * cp-valprint.c (show_vtblprint, show_objectprint)
3803         (show_static_field_print): Delete.
3804         (_initialize_cp_valprint): Don't install "set print
3805         static-members", "set print vtbl", "set print object" here.
3806         * printcmd.c: Include "cli/cli-option.h" and
3807         "common/gdb_optional.h".
3808         (print_command_parse_format): Rework to fill in a
3809         value_print_options instead of a format_data.
3810         (print_value): Change parameter type from format_data pointer to
3811         value_print_options reference.  Adjust.
3812         (print_command_1): Process options.  Adjust to pass down a
3813         value_print_options.
3814         (print_command_completer): New.
3815         (_initialize_printcmd): Install print_command_completer as
3816         handle_brkchars completer for the "print" command.  Update
3817         "print"'s help to include supported options.
3818         * valprint.c: Include "cli/cli-option.h".
3819         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3820         here from cp-valprint.c.
3821         (boolean_option_def, uinteger_option_def)
3822         (value_print_option_defs, make_value_print_options_def_group):
3823         New.  Use gdb::option::add_setshow_cmds_for_options to install
3824         "set print elements", "set print null-stop", "set print repeats",
3825         "set print pretty", "set print union", "set print array", "set
3826         print address", "set print symbol", "set print array-indexes".
3827         * valprint.h: Include <string> and "cli/cli-option.h".
3828         (make_value_print_options_def_group): Declare.
3829         (print_value): Change parameter type from format_data pointer to
3830         value_print_options reference.
3831         (print_command_completer): Declare.
3832
3833 2019-06-13  Pedro Alves  <palves@redhat.com>
3834
3835         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3836         (COMMON_SFILES): Add maint-test-settings.c.
3837         * cli/cli-decode.c (boolean_enums): New global, factored out from
3838         ...
3839         (add_setshow_boolean_cmd): ... here.
3840         * cli/cli-decode.h (boolean_enums): Declare.
3841         * cli/cli-option.c: New file.
3842         * cli/cli-option.h: New file.
3843         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3844         factored out from ...
3845         (parse_cli_boolean_value(const char *)): ... this.
3846         (is_unlimited_literal): Change parameter type to pointer to
3847         pointer.  Adjust and advance ARG pointer.
3848         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3849         (parse_cli_var_enum): New, factored out from ...
3850         (do_set_command): ... this.  Adjust.
3851         * cli/cli-setshow.h (parse_cli_boolean_value)
3852         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3853         (parse_cli_var_enum): Declare.
3854         * cli/cli-utils.c: Include "cli/cli-option.h".
3855         (get_ulongest): New.
3856         * cli/cli-utils.h (get_ulongest): Declare.
3857         (check_for_argument): New overloads.
3858         * maint-test-options.c: New file.
3859
3860 2019-06-13  Pedro Alves  <palves@redhat.com>
3861
3862         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3863         parse a range if "-" is at the end of the string.
3864
3865 2019-06-13  Pedro Alves  <palves@redhat.com>
3866
3867         * cli/cli-setshow.c (parse_auto_binary_operation)
3868         (parse_cli_boolean_value): Don't allow "o".
3869
3870 2019-06-13  Pedro Alves  <palves@redhat.com>
3871
3872         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3873         * NEWS: Mention maint test-settings KIND.
3874         * maint-test-settings.c: New file.
3875
3876 2019-06-13  Pedro Alves  <palves@redhat.com>
3877
3878         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3879         completer.
3880         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3881         "set" completers.
3882
3883 2019-06-13  Pedro Alves  <palves@redhat.com>
3884
3885         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3886         after item.
3887
3888 2019-06-13  Pedro Alves  <palves@redhat.com>
3889
3890         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3891
3892 2019-06-13  Pedro Alves <palves@redhat.com>
3893
3894         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3895         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3896         call.
3897         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3898         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3899         calls.
3900         (check_for_argument): Skip spaces after argument.
3901
3902 2019-06-13  Pedro Alves  <palves@redhat.com>
3903
3904         * thread.c (thread_apply_command): Adjust TID parsing.
3905         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3906         detected before end of string.
3907         (tid_is_in_list): Error out if LIST is invalid.
3908
3909 2019-06-13  Pedro Alves  <palves@redhat.com>
3910
3911         * completer.c (complete_line_internal_1): Rewind completion word
3912         point.
3913         (completion_tracker::advance_custom_word_point_by): Change
3914         parameter type to int.
3915         * completer.h (completion_tracker::advance_custom_word_point_by):
3916         Likewise.
3917
3918 2019-06-13  Pedro Alves  <palves@redhat.com>
3919
3920         * completer.c (advance_to_completion_word): Handle delimiters.
3921
3922 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3923
3924         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3925
3926 2019-06-11  Tom Tromey  <tom@tromey.com>
3927
3928         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3929         (xmalloc_failed): Move to alloc.c.
3930         * alloc.c: New file.
3931         * Makefile.in (COMMON_SFILES): Add alloc.c.
3932
3933 2019-06-11  Tom Tromey  <tom@tromey.com>
3934
3935         * nat/linux-waitpid.c: Don't include server.h.
3936         (linux_debug): Remove.
3937         (my_waitpid): Update.
3938
3939 2019-06-11  Tom Tromey  <tromey@adacore.com>
3940
3941         * infcall.c (_initialize_infcall): Remove trailing newline from
3942         help.
3943         * user-regs.c (_initialize_user_regs): Remove trailing newline
3944         from help.
3945         * typeprint.c (_initialize_typeprint): Remove trailing newline
3946         from help.
3947         * reverse.c (_initialize_reverse): Remove trailing newlines from
3948         help.
3949         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3950         from help.
3951         * language.c (add_set_language_command): Remove trailing newline
3952         from help.
3953         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3954         help.
3955         * disasm.c (_initialize_disasm): Remove trailing newline from
3956         help.
3957         * top.c (init_main): Remove trailing newline from help.
3958         * interps.c (_initialize_interpreter): Remove trailing newline
3959         from help.
3960         * btrace.c (_initialize_btrace): Remove trailing newlines from
3961         help.
3962         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3963         from help.
3964         * python/python.c (_initialize_python): Remove trailing newline
3965         from help.
3966         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3967         help.
3968         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3969         from help.  Reformat some text.
3970         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3971         from help.
3972         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3973         newline from help.
3974
3975 2019-06-11  Tom Tromey  <tromey@adacore.com>
3976
3977         * darwin-nat.c (darwin_decode_exception_message)
3978         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3979
3980 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3981
3982         * valops.c (value_slice): Check for not allocated or not
3983         associated values.
3984
3985 2019-06-10  Tom de Vries  <tdevries@suse.de>
3986
3987         PR gdb/24618
3988         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3989         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3990         invalid.
3991
3992 2019-06-10  Tom de Vries  <tdevries@suse.de>
3993
3994         PR gdb/24611
3995         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3996         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3997
3998 2019-06-10  Tom de Vries  <tdevries@suse.de>
3999
4000         PR symtab/24545
4001         * symtab.c (struct demangled_name_entry): Add language field.
4002         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4003         static minimal symbol".  Set and use language field.
4004
4005 2019-06-10  Tom Tromey  <tromey@adacore.com>
4006
4007         * ada-lang.c (_initialize_ada_language): Update help text.
4008
4009 2019-06-10  Tom Tromey  <tromey@adacore.com>
4010
4011         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4012         with a newline.
4013         * guile/guile.c (handle_boot_error): Don't end warning with a
4014         newline.
4015         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4016         warning with a newline.
4017         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4018         newline.
4019         (s12z_frame_cache): Likewise.
4020         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4021         a newline.
4022         * solib-svr4.c (disable_probes_interface): Don't end warning with
4023         a newline.
4024         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4025         newline.
4026         * python/python.c (do_finish_initialization): Don't end warning
4027         with a newline.
4028
4029 2019-06-10  Tom Tromey  <tom@tromey.com>
4030
4031         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4032         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4033         gdbpy_enter.
4034
4035 2019-06-10  Tom Tromey  <tromey@adacore.com>
4036
4037         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4038         data.
4039         (elf_new_init): Don't call stabsread_new_init.
4040         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4041         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4042         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4043
4044 2019-06-10  Tom de Vries  <tdevries@suse.de>
4045
4046         PR symtab/16264
4047         PR symtab/24517
4048         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4049
4050 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4051
4052         * source.c (find_and_open_source): Also rewrite relative file
4053         names.
4054
4055 2019-04-26  Amos Bird  <amosbird@gmail.com>
4056
4057         * annotate.c (annotate_thread_exited): Add "thread-exited"
4058         annotation.
4059
4060 2019-06-06  Tom Tromey  <tromey@adacore.com>
4061
4062         * maint.h (class scoped_command_stats): Use
4063         DISABLE_COPY_AND_ASSIGN.
4064         <print_time>: New method.
4065         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4066         print_time.
4067         (scoped_command_stats::print_time): New method.
4068
4069 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4070
4071         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4072         instructions of lengths 6 or 8 bytes.
4073
4074 2019-06-04  Pedro Alves  <palves@redhat.com>
4075
4076         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4077
4078         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4079         * breakpoint.c (condition_completer): Likewise.
4080         * cli/cli-dump.c (scan_expression): Likewise.
4081         * common/filestuff.c (mkdir_recursive): Likewise.
4082         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4083         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4084         (gdb_abspath): Likewise.
4085         * compile/compile-cplus-types.c
4086         (compile_cplus_instance::decl_name): Likewise.
4087         * completer.c (complete_explicit_location):
4088         (signal_completer, reg_or_group_completer_1): Likewise.
4089         * cp-support.c (cp_remove_params_if_any): Likewise.
4090         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4091         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4092         * infcmd.c (strip_bg_char): Likewise.
4093         * linespec.c (copy_token_string): Likewise.
4094         * mi/mi-main.c (output_cores): Likewise.
4095         * psymtab.c (psymtab_search_name):
4096         * symfile.c (test_set_ext_lang_command): Likewise.
4097         * target.c (target_fileio_read_stralloc): Likewise.
4098         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4099         * value.c (complete_internalvar): Likewise.
4100
4101 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4102
4103         Add objfile property to gdb.Type.
4104         * NEWS: Mention Python API addition.
4105         * python/py-type.c (typy_get_objfile): New method.
4106
4107 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4108
4109         * NEWS: Mention the new set|show style [title|highlight].
4110         Mention changes to "show style", "help" and "apropos".
4111
4112 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4113
4114         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4115         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4116         instead of print_help_for_command.
4117         (print_doc_of_command): New function.
4118         (help_list): Add 'apropos -v word' suggestion.
4119         (print_help_for_command): Style the command name using title style.
4120         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4121         (_initialize_cli_cmds): Describe -v in apropos_command help.
4122
4123 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4124
4125         * cli/cli-style.h (cli_style_option): Add name in constructor,
4126         add m_name class member, add constructor with intensity,
4127         add name class function.
4128         (cli_style_option::add_setshow_commands): Remove name argument.
4129         (highlight_style, title_style): New styles.
4130         * cli/cli-style.c (do_show): New function that shows a style
4131         characteristic styling the style name with itself.
4132         (set_style_name): New function.
4133         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4134         Update all callers according to the changes in cli/cli-style.h.
4135         * utils.h (fputs_highlighted): New function.
4136         * utils.c (fputs_highlighted): Likewise.
4137
4138 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4139
4140         * NEWS: Mention new pipe command and new convenience variables.
4141
4142 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4143
4144         * cli/cli-cmds.c (pipe_command): New function.
4145         (_initialize_cli_cmds): Call add_com for pipe_command.
4146         Define | as an alias for pipe.
4147         (exit_status_set_internal_vars): New function.
4148         (shell_escape): Call exit_status_set_internal_vars.
4149         cli/cli-decode.c (find_command_name_length): Recognize | as
4150         a single character command.
4151
4152 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4153
4154         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4155         top.c (execute_command_to_ui_file): New function, mostly a copy
4156         of execute_command_to_string.
4157         (execute_command_to_string): Implement by calling
4158         execute_command_to_ui_file.
4159
4160 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4161
4162         * top.h (saved_command_line): Remove declaration.
4163         * top.c (previous_saved_command_line, previous_repeat_arguments):
4164         New variables.
4165         (saved_command_line): Make static, define together with other
4166         'repeat variables'.
4167         (dont_repeat): Clear repeat_arguments.
4168         (repeat_previous, get_saved_command_line, save_command_line):
4169         New functions.
4170         (gdb_init): Initialize saved_command_line
4171         and previous_saved_command_line.
4172         * main.c (captured_main_1): Remove saved_command_line initialization.
4173         * event-top.c (handle_line_of_input): Update to use
4174         the new 'repeat' related functions instead of direct access to
4175         saved_command_line.
4176         * command.h (repeat_previous, get_saved_command_line,
4177         save_command_line): New declarations.
4178         (dont_repeat): Add comment.
4179
4180 2019-05-30  Tom Tromey  <tromey@adacore.com>
4181
4182         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4183         Fix comment.
4184         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4185
4186 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4187
4188         PR cli/24587
4189         * completer.c (complete): Initialize variable word.
4190
4191 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4192
4193         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4194         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4195         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4196         'body' is NULL to the outter 'if', protecting the '!is_define'
4197         situation as well.
4198
4199 2019-05-29  Tom Tromey  <tromey@adacore.com>
4200
4201         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4202         (dwarf_unknown): New function.
4203         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4204         (dwarf_type_encoding_name): Use dwarf_unknown.
4205
4206 2019-05-29  Tom Tromey  <tromey@adacore.com>
4207
4208         PR c++/20020:
4209         * cp-valprint.c (cp_print_value_fields): Call
4210         cp_print_static_field inside "try".
4211
4212 2019-05-29  Tom Tromey  <tromey@adacore.com>
4213
4214         * inflow.c (struct terminal_info): Add default operator=.
4215         * configure: Rebuild.
4216         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4217         -Wdeprecated-copy-dtor, -Wredundant-move.
4218
4219 2019-05-29  Tom Tromey  <tromey@adacore.com>
4220
4221         * NEWS: Add entry.
4222         * infcmd.c (print_return_value_1): Handle finish_print
4223         option.
4224         (show_print_finish): New function.
4225         (_initialize_infcmd): Add "set/show print finish" commands.
4226         * valprint.c (user_print_options): Initialize new member.
4227         * valprint.h (struct value_print_options) <finish_print>: New
4228         member.
4229
4230 2019-05-28  Tom Tromey  <tromey@adacore.com>
4231
4232         * ada-lang.c (ada_remove_Xbn_suffix)
4233         (find_old_style_renaming_symbol)
4234         (parse_old_style_renaming): Remove.
4235         (ada_find_renaming_symbol): Don't call
4236         find_old_style_renaming_symbol.
4237         (ada_is_renaming_symbol): Rename from
4238         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4239         bool.  Now static.
4240         (ada_read_var_value): Update and simplify.
4241         * ada-exp.y (write_var_or_type): Remove old code.
4242
4243 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4244
4245         * event-top.c: Remove include comment.
4246         * inflow.c (class scoped_ignore_sigttou): Move from here...
4247         * inflow.h (class scoped_ignore_sigttou): ...to here.
4248         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4249         * top.c:  Remove include comment.
4250
4251 2019-05-27  Tom Tromey  <tom@tromey.com>
4252
4253         * NEWS: Fix typo.
4254
4255 2019-05-22  Tom Tromey  <tromey@adacore.com>
4256
4257         * target.c (target_follow_exec): Constify parameter.
4258         * target-delegates.c: Rebuild.
4259         * remote.c (remote_target::follow_exec): Constify parameter.
4260         * infrun.c (follow_exec): Constify parameter.
4261         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4262         (target_follow_exec): Likewise.
4263
4264 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4265
4266         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4267         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4268
4269 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4270
4271         * NEWS: Add debugredirect and testsuite sections.
4272
4273 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4274
4275         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4276         target descriptions using exclusively floating point register name
4277         aliases.
4278
4279 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4280
4281         PR gdb/18644:
4282         * f-lang.c (build_fortran_types): Handle the case where
4283         gdbarch_floatformat_for_type returns a nullptr.
4284
4285 2019-05-21  Tom de Vries  <tdevries@suse.de>
4286
4287         PR cli/24587
4288         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4289
4290 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4291
4292         PR gdb/18644:
4293         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4294         16-byte floats.
4295         * i386-tdep.c (i386_floatformat_for_type): Use
4296         floatformats_ia64_quad for the 16-byte floating point component
4297         within a fortran 32-byte complex number.
4298
4299 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4300
4301         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4302         delete default constructor.
4303         (find_partial_die): Update to return const struct.
4304         (partial_die_parent_scope): Move variable declaration into scope
4305         of its use and change its type to auto.
4306         (guess_partial_die_structure_name): Likewise.
4307         (partial_die_info::fixup): Likewise.
4308
4309 2019-05-17  Tom Tromey  <tromey@adacore.com>
4310
4311         * source.c (find_and_open_source): Remove cast.
4312
4313 2019-05-17  Tom Tromey  <tromey@adacore.com>
4314
4315         * annotate.c (annotate_source): Make "filename" const.
4316         * annotate.h (annotate_source): Use const.
4317
4318 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4319
4320         * disasm.c (set_disassembler_options): Send errors to stderr.
4321
4322 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4323
4324         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4325         (cli_interp_base::set_logging): Check debug_redirect.
4326         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4327         * cli/cli-logging.c (debug_redirect): Add static variable.
4328         (pop_output_files): Add default param.
4329         (handle_redirections): Print debug setting.
4330         (show_logging_command): Likewise.
4331         (_initialize_cli_logging): Add debugredirect command.
4332         * interps.c (current_interp_set_logging): Add debug_redirect
4333         parameter.
4334         * interps.h (set_logging): Add debug_redirect parameter.
4335         (current_interp_set_logging): Likewise.
4336         * mi/mi-common.h: Likewise.
4337         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4338
4339 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4340             Tom Tromey  <tromey@adacore.com>
4341
4342         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4343         directly.
4344         * cli/cli-interp.h (make_logging_output): Remove declaration.
4345         * cli/cli-logging.c (make_logging_output): Remove function.
4346         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4347         directly.
4348         * ui-file.c (tee_file::tee_file): Remove bools.
4349         (tee_file::~tee_file): Remove deletes.
4350         * ui-file.h (tee_file): Remove bools.
4351
4352 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4353
4354         * mi/mi-cmds.h (mi_cmd_complete): New function.
4355         * mi/mi-main.c (mi_cmd_complete): Likewise.
4356         * mi/mi-cmds.c: Define new MI command -complete.
4357         * NEWS: Mention new -complete command.
4358
4359 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4360
4361         * completer.h (complete): New function.
4362         * completer.c (complete): Likewise.
4363         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4364         function defined in completer.h.
4365
4366 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4367
4368         * MAINTAINERS (Write After Approval): Add myself.
4369
4370 2019-05-17  Tom de Vries  <tdevries@suse.de>
4371
4372         PR gdb/24094
4373         * dwarf2read.c (struct cu_partial_die_info): New struct.
4374         (find_partial_die): Return cu_partial_die_info.
4375         (partial_die_parent_scope, guess_partial_die_structure_name)
4376         (partial_die_info::fixup): Handle new return type of find_partial_die.
4377
4378 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4379
4380         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4381         "std::string", simplifying the algorithm.
4382
4383 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4384
4385         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4386         (stap_static_probe_ops::get_probes): Likewise.
4387
4388 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4389
4390         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4391         '-')" and "else if".
4392         (stap_parse_single_operand): Join checks for
4393         "gdbarch_stap_parse_special_token_p" and
4394         "gdbarch_stap_parse_special_token" in the same "if" statement.
4395         Invert check when verifying for operation on register
4396         displacement.
4397
4398 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4399
4400         * stap-probe.c (stap_get_opcode): Update comment.
4401         (stap_get_expected_argument_type): Likewise.
4402         (handle_stap_probe): Likewise.
4403
4404 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4405
4406         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4407         return type to 'bool'.  Adjust comment.  Use 'bool' when
4408         appropriate.
4409         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4410         * stap-probe.c (stap_parse_argument_1): Likewise.
4411         (stap_is_operator): Likewise.
4412         (stap_is_generic_prefix): Likewise.
4413         (stap_is_register_prefix): Likewise.
4414         (stap_is_register_indirection_prefix): Likewise.
4415         (stap_is_integer_prefix): Likewise.
4416         (stap_generic_check_suffix): Likewise.
4417         (stap_check_integer_suffix): Likewise.
4418         (stap_check_register_suffix): Likewise.
4419         (stap_check_register_indirection_suffix): Likewise.
4420         (stap_parse_register_operand): Likewise.
4421         (stap_parse_single_operand): Likewise.
4422         (stap_parse_argument_1): Likewise.
4423         (stap_probe::get_argument_count): Likewise.
4424         (stap_is_operator): Likewise.
4425
4426 2019-05-16  Tom Tromey  <tromey@adacore.com>
4427
4428         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4429         keyword to foreach.
4430
4431 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4432
4433         * linux-thread-db.c (try_thread_db_load_1): Change return type
4434         to bool.
4435         (try_thread_db_load): Likewise.
4436         (try_thread_db_load_from_pdir_1): Likewise.
4437         (try_thread_db_load_from_pdir): Likewise.
4438         (try_thread_db_load_from_sdir): Likewise.
4439         (try_thread_db_load_from_dir): Likewise.
4440         (thread_db_load_search): Likewise.
4441         (has_libpthread): Likewise.
4442         (thread_db_load): Likewise.
4443
4444 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4445
4446         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4447         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4448         NULL, and complain/return if that's the case.
4449
4450 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4451
4452         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4453         (advance, posn, abstract_read_memory): New functions.
4454         [struct mem_read_abstraction]: New struct.
4455         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4456
4457 2019-05-14  Tom Tromey  <tromey@adacore.com>
4458
4459         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4460         value is not lval_memory.
4461
4462 2019-05-14  Tom Tromey  <tromey@adacore.com>
4463
4464         * solib.c (info_sharedlibrary_command): Style the file name.
4465
4466 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4467
4468         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4469         (aarch64_vnv_type): Likewise.
4470         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4471         * common/tdesc.c: Likewise.
4472         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4473         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4474         * features/aarch64-fpu.xml: Add ieee half view.
4475         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4476         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4477         * gdbtypes.h (struct builtin_type): Likewise.
4478         (struct objfile_type): Likewise.
4479
4480 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4481
4482         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4483         typo.
4484         * location.h (string_to_event_location): Likewise.
4485
4486 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4487
4488         GDB 8.3 released.
4489
4490 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4491
4492         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4493         New variable declaration.
4494         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4495         New variable.
4496         (print_one_breakpoint): Use ui_out::test_flags and new global
4497         variable to compute use_fixed_output.
4498         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4499         Remove.
4500         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4501         (mi_multi_location_breakpoint_output_fixed): Remove.
4502         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4503         new variable.
4504         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4505         fix_multi_location_breakpoint_output flag if version >= 3.
4506         * ui-out.h (enum ui_out_flag)
4507         <fix_multi_location_breakpoint_output>: New enumerator.
4508
4509 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4510
4511         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4512
4513 2019-05-10  Tom Tromey  <tromey@adacore.com>
4514
4515         * ada-lang.c (catch_ada_completer): New function.
4516         (_initialize_ada_language): Use it.
4517
4518 2019-05-10  Tom Tromey  <tromey@adacore.com>
4519
4520         * thread.c (print_thread_info): Make "requested_threads" const.
4521         * gdbthread.h (print_thread_info): Make "requested_threads"
4522         const.
4523         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4524         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4525
4526 2019-05-08  Tom Tromey  <tom@tromey.com>
4527
4528         * gdbtypes.c (objfile_type_data): Change type.
4529         (objfile_type, _initialize_gdbtypes): Update.
4530
4531 2019-05-08  Tom Tromey  <tom@tromey.com>
4532
4533         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4534         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4535         (_initialize_dwarf2_frame): Update.
4536
4537 2019-05-08  Tom Tromey  <tom@tromey.com>
4538
4539         * objc-lang.c (objc_objfile_data): Change type.
4540         (find_methods): Update.
4541         (_initialize_objc_lang): Remove.
4542
4543 2019-05-08  Tom Tromey  <tom@tromey.com>
4544
4545         * stabsread.c (rs6000_builtin_type_data): Change type.
4546         (rs6000_builtin_type, _initialize_stabsread): Update.
4547
4548 2019-05-08  Tom Tromey  <tom@tromey.com>
4549
4550         * mips-tdep.c (mips_pdr_data): Remove.
4551         (_initialize_mips_tdep): Update.
4552
4553 2019-05-08  Tom Tromey  <tom@tromey.com>
4554
4555         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4556         (hppa_init_objfile_priv_data, read_unwind_info)
4557         (find_unwind_entry, _initialize_hppa_tdep): Update.
4558
4559 2019-05-08  Tom Tromey  <tom@tromey.com>
4560
4561         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4562         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4563         on obstack.
4564         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4565
4566 2019-05-08  Tom Tromey  <tom@tromey.com>
4567
4568         * mdebugread.c (basic_type_data): Change type.
4569         (basic_type, _initialize_mdebugread): Update.
4570
4571 2019-05-08  Tom Tromey  <tom@tromey.com>
4572
4573         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4574
4575 2019-05-08  Tom Tromey  <tom@tromey.com>
4576
4577         * nto-tdep.c (nto_inferior_data_reg): Change type.
4578         (nto_inferior_data): Update.
4579         (nto_inferior_data_cleanup, nto_new_inferior_data)
4580         (_initialize_nto_tdep): Remove.
4581         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4582
4583 2019-05-08  Tom Tromey  <tom@tromey.com>
4584
4585         * ada-lang.c (struct ada_inferior_data): Add initializers.
4586         (ada_inferior_data): Change type.
4587         (ada_inferior_data_cleanup): Remove.
4588         (get_ada_inferior_data, ada_inferior_exit)
4589         (struct ada_pspace_data): Add initializers, destructor.
4590         (ada_pspace_data_handle): Change type.
4591         (get_ada_pspace_data): Update.
4592         (ada_pspace_data_cleanup): Remove.
4593
4594 2019-05-08  Tom Tromey  <tom@tromey.com>
4595
4596         * coffread.c (struct coff_symfile_info): Add initializers.
4597         (coff_objfile_data_key): Move lower.  Change type.
4598         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4599         Update.
4600         (coff_free_info): Remove.
4601
4602 2019-05-08  Tom Tromey  <tom@tromey.com>
4603
4604         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4605         (fbsd_pspace_data_handle): Move lower.  Change type.
4606         (get_fbsd_pspace_data): Update.
4607         (fbsd_pspace_data_cleanup): Remove.
4608         (_initialize_fbsd_tdep): Update.
4609
4610 2019-05-08  Tom Tromey  <tom@tromey.com>
4611
4612         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4613         (get_ada_tasks_pspace_data): Update.
4614         (ada_tasks_pspace_data_cleanup): Remove.
4615         (_initialize_tasks): Update.
4616         (ada_tasks_inferior_data_handle): Change type.
4617         (get_ada_tasks_inferior_data): Update.
4618         (ada_tasks_inferior_data_cleanup): Remove.
4619         (struct ada_tasks_pspace_data): Add initializers.
4620
4621 2019-05-08  Tom Tromey  <tom@tromey.com>
4622
4623         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4624         * symfile-debug.c (debug_sym_get_probes): Change type.
4625         * stap-probe.c (handle_stap_probe):
4626         (stap_static_probe_ops::get_probes): Change type.
4627         * probe.h (class static_probe_ops) <get_probes>: Change type.
4628         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4629         (parse_probes_in_pspace): Update.
4630         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4631         Update.
4632         (any_static_probe_ops::get_probes): Change type.
4633         * elfread.c (elfread_data): New typedef.
4634         (probe_key): Change type.
4635         (elf_get_probes): Likewise.  Update.
4636         (probe_key_free): Remove.
4637         (_initialize_elfread): Update.
4638         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4639         Change type.
4640         (dtrace_process_dof_probe, dtrace_process_dof)
4641         (dtrace_static_probe_ops::get_probe): Change type.
4642
4643 2019-05-08  Tom Tromey  <tom@tromey.com>
4644
4645         * xcoffread.c (struct xcoff_symfile_info): Rename from
4646         coff_symfile_info.  Add initializers.
4647         (xcoff_objfile_data_key): Move lower.  Change type.
4648         (XCOFF_DATA): Rewrite.
4649         (xcoff_free_info): Remove.
4650         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4651         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4652         (xcoff_initial_scan): Update.
4653
4654 2019-05-08  Tom Tromey  <tom@tromey.com>
4655
4656         * solib-svr4.c (struct svr4_info): Add initializers and
4657         destructor.
4658         <probes_table>: Now an htab_up.
4659         (solib_svr4_pspace_data): Change type.
4660         (free_probes_table): Simplify.
4661         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4662         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4663         (probes_table_remove_objfile_probes, register_solib_event_probe)
4664         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4665         (_initialize_svr4_solib): Update.
4666
4667 2019-05-08  Tom Tromey  <tom@tromey.com>
4668
4669         * remote.c (remote_pspace_data): Change type.
4670         (remote_pspace_data_cleanup): Remove.
4671         (get_remote_exec_file, set_pspace_remote_exec_file)
4672         (_initialize_remote): Update.
4673
4674 2019-05-08  Tom Tromey  <tom@tromey.com>
4675
4676         * breakpoint.c (breakpoint_objfile_key): Change type.
4677         (get_breakpoint_objfile_data): Update.
4678         (free_breakpoint_objfile_data): Remove.
4679         (_initialize_breakpoint): Update.
4680
4681 2019-05-08  Tom Tromey  <tom@tromey.com>
4682
4683         * linux-tdep.c (struct linux_info): Add initializers.
4684         (linux_inferior_data): Move.  Change type.
4685         (invalidate_linux_cache_inf): Update.
4686         (linux_inferior_data_cleanup): Remove.
4687         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4688
4689 2019-05-08  Tom Tromey  <tom@tromey.com>
4690
4691         * auxv.c (auxv_inferior_data): Move.  Change type.
4692         (auxv_inferior_data_cleanup): Remove.
4693         (invalidate_auxv_cache_inf): Rewrite.
4694         (get_auxv_inferior_data, _initialize_auxv): Update.
4695
4696 2019-05-08  Tom Tromey  <tom@tromey.com>
4697
4698         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4699         (symfile_debug_objfile_data_key): Change type.
4700         (symfile_debug_installed, debug_qf_has_symbols)
4701         (debug_qf_find_last_source_symtab)
4702         (debug_qf_forget_cached_source_info)
4703         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4704         (debug_qf_print_stats, debug_qf_dump)
4705         (debug_qf_expand_symtabs_for_function)
4706         (debug_qf_expand_all_symtabs)
4707         (debug_qf_expand_symtabs_with_fullname)
4708         (debug_qf_map_matching_symbols)
4709         (debug_qf_expand_symtabs_matching)
4710         (debug_qf_find_pc_sect_compunit_symtab)
4711         (debug_qf_map_symbol_filenames)
4712         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4713         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4714         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4715         (debug_sym_read_linetable, debug_sym_relocate): Update.
4716         (symfile_debug_free_objfile): Remove.
4717         (install_symfile_debug_logging, _initialize_symfile_debug):
4718         Update.
4719
4720 2019-05-08  Tom Tromey  <tom@tromey.com>
4721
4722         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4723         allocate_on_obstack.
4724         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4725         (get_dwarf2_per_objfile): Update.
4726         (set_dwarf2_per_objfile): Remove.
4727         (dwarf2_has_info, dwarf2_get_section_info): Update.
4728         (dwarf2_free_objfile): Remove.
4729         (_initialize_dwarf2_read): Update.
4730
4731 2019-05-08  Tom Tromey  <tom@tromey.com>
4732
4733         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4734         initializers.
4735         <unsupported_script_warning_printed,
4736         script_not_found_warning_printed>: Now bool.
4737         (auto_load_pspace_data): Change type.
4738         (~auto_load_pspace_info): Rename from
4739         auto_load_pspace_data_cleanup.
4740         (get_auto_load_pspace_data, init_loaded_scripts_info)
4741         (clear_section_scripts, maybe_print_unsupported_script_warning)
4742         (maybe_print_script_not_found_warning, _initialize_auto_load):
4743         Update.
4744
4745 2019-05-08  Tom Tromey  <tom@tromey.com>
4746
4747         * objfiles.c (objfile_pspace_info): Add destructor and
4748         initializers.
4749         (objfiles_pspace_data): Change type.
4750         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4751         (get_objfile_pspace_data): Update.
4752         (objfiles_bfd_data): Change type.
4753         (get_objfile_bfd_data): Update.
4754         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4755
4756 2019-05-08  Tom Tromey  <tom@tromey.com>
4757
4758         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4759         Change type.
4760         (get_catch_syscall_inferior_data): Update.
4761         (catch_syscall_inferior_data_cleanup): Remove.
4762         (_initialize_break_catch_syscall): Update.
4763
4764 2019-05-08  Tom Tromey  <tom@tromey.com>
4765
4766         * inflow.c (struct terminal_info): Add destructor and
4767         initializers.
4768         (inflow_inferior_data): Change type.
4769         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4770         (get_inflow_inferior_data, inflow_inferior_exit)
4771         (swap_terminal_info, _initialize_inflow): Update.
4772
4773 2019-05-08  Tom Tromey  <tom@tromey.com>
4774
4775         * target-dcache.c (target_dcache_cleanup): Remove.
4776         (target_dcache_aspace_key): Change type.
4777         (target_dcache_init_p, target_dcache_invalidate)
4778         (target_dcache_get, target_dcache_get_or_init)
4779         (_initialize_target_dcache): Update.
4780         * dcache.h (struct dcache_deleter): New.
4781
4782 2019-05-08  Tom Tromey  <tom@tromey.com>
4783
4784         * symtab.c (struct symbol_cache): Add destructor and
4785         initializers.
4786         (symbol_cache_key): Move.  Change type.
4787         (make_symbol_cache, free_symbol_cache): Remove.
4788         (get_symbol_cache): Update.
4789         (symbol_cache_cleanup): Remove.
4790         (ALL_PSPACES, symbol_cache_flush)
4791         (maintenance_print_symbol_cache)
4792         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4793         Update.
4794
4795 2019-05-08  Tom Tromey  <tom@tromey.com>
4796
4797         * symtab.c (struct main_info): Add destructor and initializers.
4798         (main_progspace_key): Move.  Change type.
4799         (get_main_info): Update.
4800         (main_info_cleanup): Remove.
4801         (_initialize_symtab): Update.
4802
4803 2019-05-08  Tom Tromey  <tom@tromey.com>
4804
4805         * registry.h (DECLARE_REGISTRY): Define the _key class.
4806
4807 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4808
4809         * NEWS: Merge two 'New commands' sections.
4810
4811 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4812
4813         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4814         parameter and use Ada language definition instead.
4815         (ada_val_print_ptr): Remove unused language parameter.
4816         (ada_val_print_num): Remove language parameter and use Ada language
4817         definition instead.
4818         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4819         parameter.
4820         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4821         parameter and use Ada language definition instead.
4822         (ada_val_print_1): Update all ada_val_print_xxx calls.
4823         Remove language parameter.
4824         (ada_val_print): Update ada_val_print_1 call.
4825
4826 2019-05-08  Tom Tromey  <tromey@adacore.com>
4827
4828         * remote.c (remote_hw_watchpoint_limit)
4829         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4830         Now static.
4831
4832 2019-05-08  Tom Tromey  <tromey@adacore.com>
4833
4834         * maint.c (_initialize_maint_cmds): Move initialization code to
4835         remote.c.
4836         (watchdog, show_watchdog): Move to remote.c.
4837         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4838         "watchdog" static.
4839         (_initialize_remote): Move initialization code from maint.c.
4840         * defs.h (watchdog): Don't declare.
4841
4842 2019-05-08  Tom Tromey  <tromey@adacore.com>
4843
4844         * tui/tui-interp.c: Include main.h.
4845         * interps.c: Include main.h.
4846         * main.h (interpreter_p): Declare.
4847         * defs.h (interpreter_p): Don't declare.
4848
4849 2019-05-08  Tom Tromey  <tromey@adacore.com>
4850
4851         * dwarf2loc.c: Include dwarf2read.h.
4852         * defs.h (read_unsigned_leb128): Don't declare.
4853         * dwarf2read.h (read_unsigned_leb128): Declare.
4854
4855 2019-05-08  Tom Tromey  <tromey@adacore.com>
4856
4857         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4858         method.
4859
4860 2019-05-08  Tom Tromey  <tromey@adacore.com>
4861
4862         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4863         when no wrap column is set.
4864
4865 2019-05-08  Tom Tromey  <tromey@adacore.com>
4866
4867         * c-lang.c (c_get_string): Handle non-C-style arrays.
4868
4869 2019-05-08  Tom Tromey  <tromey@adacore.com>
4870
4871         * typeprint.c (print_offset_data::update): Print the bit offset,
4872         not the number of bits remaining.
4873
4874 2019-05-08  Tom Tromey  <tromey@adacore.com>
4875
4876         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4877         padding at end of comment.
4878
4879 2019-05-08  Tom Tromey  <tromey@adacore.com>
4880
4881         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4882         Compare main types.
4883
4884 2019-05-06  Tom Tromey  <tom@tromey.com>
4885
4886         * common/scoped_mmap.c: Include common-defs.h.
4887         * common/scoped_mmap.h: Don't include config.h.
4888
4889 2019-05-04  Tom Tromey  <tom@tromey.com>
4890
4891         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4892         (struct aarch64_call_info): Add initializers.
4893         <si>: Now a std::vector.
4894         (pass_on_stack, aarch64_push_dummy_call): Update.
4895
4896 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4897             Tom Tromey  <tom@tromey.com>
4898
4899         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4900         (ppc_threads): Now a std::vector.  Now static.
4901         (hwdebug_find_thread_points_by_tid)
4902         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4903         Update.
4904
4905 2019-05-04  Tom Tromey  <tom@tromey.com>
4906
4907         * arc-tdep.c (arc_tdesc_init): Return bool.
4908
4909 2019-05-04  Tom Tromey  <tom@tromey.com>
4910
4911         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4912         Use gdb_assert_not_reached.
4913
4914 2019-05-04  Tom Tromey  <tom@tromey.com>
4915
4916         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4917         "false".
4918
4919 2019-05-04  Tom Tromey  <tom@tromey.com>
4920
4921         * arc-tdep.c (arc_tdesc_init): Use bool.
4922
4923 2019-05-04  Tom Tromey  <tom@tromey.com>
4924
4925         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4926
4927 2019-05-04  Tom Tromey  <tom@tromey.com>
4928
4929         * cli/cli-cmds.c (valid_command_p): Return bool.
4930
4931 2019-05-04  Tom Tromey  <tom@tromey.com>
4932
4933         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4934         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4935
4936 2019-05-04  Raul Tambre  <raul@tambre.ee>
4937
4938         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4939         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4940         operator for comparison.
4941
4942 2019-05-04  Tom Tromey  <tom@tromey.com>
4943
4944         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4945         (lookup_partial_symbol, print_partial_symbols)
4946         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4947         (psymbol_compare): Update.
4948         (add_psymbol_to_bcache): Clear the entire psymbol.
4949         (maintenance_check_psymtabs): Update.
4950         * psympriv.h (struct partial_symbol): Don't derive from
4951         general_symbol_info.
4952         <obj_section, unrelocated_address, address,
4953         set_unrelocated_address>: Update.
4954         <ginfo>: New member.
4955         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4956         (debug_names::write_psymbols): Update.
4957
4958 2019-05-04  Tom de Vries  <tdevries@suse.de>
4959
4960         * contrib/cc-with-tweaks.sh: Support -n arg.
4961
4962 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4963
4964         * corelow.c (core_target::detach): Ensure frame cache and
4965         register caches are cleared.
4966         inferior.c (exit_inferior_1): Likewise.
4967
4968 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4969             Tom Tromey  <tom@tromey.com>
4970
4971         * dictionary.c (collate_pending_symbols_by_language): Remove
4972         "struct" from foreach.
4973         * symtab.c (lookup_global_symbol_from_objfile)
4974         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4975         foreach.
4976         * ser-tcp.c (net_open): Remove "struct" from foreach.
4977         * objfiles.c (objfile_relocate, objfile_rebase)
4978         (objfile_has_symbols): Remove "struct" from foreach.
4979         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4980         from foreach.
4981         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4982         foreach.
4983         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4984         "struct" from foreach.
4985         * ada-lang.c (create_excep_cond_exprs)
4986         (ada_exception_catchpoint_cond_string): Remove "struct" from
4987         foreach.
4988
4989 2019-05-03  Tom Tromey  <tromey@adacore.com>
4990
4991         * ada-exp.y (convert_char_literal): Check suffix of each
4992         enumerator.
4993
4994 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4995
4996         PR ada/21406:
4997         * ada-exp.y (yywrap): Don't define.
4998         * ada-lex.l (%option): Add noyywrap
4999         (yywrap): Remove.
5000
5001 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5002
5003         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5004         _WIN32_WINNT to the XP level, unless already defined to a higher
5005         level.
5006
5007         * unittests/parse-connection-spec-selftests.c:
5008         * ser-tcp.c:
5009         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5010         override.
5011
5012         * symfile.c (find_separate_debug_file): Remove colon from the
5013         drive spec of DOS/Windows file names of the target, so that the
5014         file name produced from DEBUGDIR and the target's directory will
5015         be valid on DOS/Windows systems.
5016
5017 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5018
5019         * rust-lang.c (val_print_struct): Handle printing structures
5020         containing strings.
5021
5022 2019-05-02  Tom Tromey  <tromey@adacore.com>
5023
5024         * valarith.c (_initialize_valarith): Remove.
5025
5026 2019-05-01  Tom Tromey  <tromey@adacore.com>
5027
5028         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5029         bitfields.
5030
5031 2019-05-01  Tom Tromey  <tromey@adacore.com>
5032
5033         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5034         for big-endian copies.
5035
5036 2019-04-30  Ali Tamur  <tamur@google.com>
5037         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5038         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5039         (read_3_bytes): New function.
5040
5041 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5042
5043         * windows-nat.c (main_thread_id): Delete.
5044         (handle_output_debug_string): Replace main_thread_id by
5045         current_event.dwThreadId.
5046         (fake_create_process): Likewise.
5047         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5048         Do not set main_thread_id.
5049         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5050         current_event.dwThreadId.
5051         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5052
5053 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5054
5055         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5056         Use current_event.dwThreadId instead of main_thread_id.
5057
5058 2019-04-30  Tom Tromey  <tromey@adacore.com>
5059
5060         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5061         (create_excep_cond_exprs): Iterate over program spaces.
5062         (ada_exception_catchpoint_cond_string): Examine all minimal
5063         symbols for exception types.
5064
5065 2019-04-30  Tom Tromey  <tromey@adacore.com>
5066
5067         PR c++/24470:
5068         * dwarf2read.c (process_structure_scope): Handle case where type
5069         has template parameters but no symbol was created.
5070
5071 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5072             Chris January  <chris.january@arm.com>
5073
5074         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5075         qualifier.
5076         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5077
5078 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5079
5080         * f-typeprint.c (f_print_type): Update rules for printing
5081         whitespace.
5082         (f_type_print_varspec_suffix): Likewise.
5083
5084 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5085             Chris January  <chris.january@arm.com>
5086
5087         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5088         function arguments.
5089
5090 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5091
5092         * f-lang.c (build_fortran_types): Change name of void type to
5093         lower case.
5094         * f-typeprint.c (f_type_print_base): Print the name of the void
5095         type, rather than a fixed string.
5096         * f-valprint.c (f_decorations): Use lower case void string.
5097
5098 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5099             Chris January  <chris.january@arm.com>
5100
5101         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5102         types for Fortran.
5103
5104 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5105             Chris January  <chris.january@arm.com>
5106             David Lecomber  <david.lecomber@arm.com>
5107
5108         * f-exp.y (BINOP_INTRINSIC): New token.
5109         (exp): New parser rule handling BINOP_INTRINSIC.
5110         (f77_keywords): Add new builtin procedures.
5111         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5112         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5113         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5114         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5115         (print_unop_subexp_f): New function.
5116         (print_binop_subexp_f): New function.
5117         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5118         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5119         (dump_subexp_body_f): Likewise.
5120         (operator_check_f): Likewise.
5121         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5122         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5123
5124 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5125
5126         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5127         UNOP_KIND.
5128         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5129         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5130         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5131         (operator_length_f): New fuction.
5132         (print_subexp_f): New function.
5133         (op_name_f): New function.
5134         (dump_subexp_body_f): New function.
5135         (operator_check_f): New function.
5136         (exp_descriptor_f): Replace standard expression handling functions
5137         with new functions.
5138         * gdb/fortran-operator.def: New file.
5139         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5140         * gdb/std-operator.def: Remove UNOP_KIND.
5141
5142 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5143
5144         * std-operator.def: Remove unbalanced, stray double quote
5145         character.
5146
5147 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5148             Chris January  <chris.january@arm.com>
5149             Daniel Everett  <daniel.everett@arm.com>
5150             Nick Forrington  <nick.forrington@arm.com>
5151             Richard Bunt  <richard.bunt@arm.com>
5152
5153         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5154         of depth when printing anonymous structs or unions.
5155         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5156         Don't print either the top-level value, or the children if the
5157         max-depth is exceeded.
5158         (ppscm_print_children): When printing the key of a map, allow one
5159         extra level of depth.
5160         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5161         print either the top-level value, or the children if the max-depth
5162         is exceeded.
5163         (print_children): When printing the key of a map, allow one extra
5164         level of depth.
5165         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5166         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5167         (user_print_options): Initialise max_depth field.
5168         (val_print_scalar_or_string_type_p): New function.
5169         (val_print): Check to see if the max depth has been reached.
5170         (val_print_check_max_depth): Define new function.
5171         (show_print_max_depth): New function.
5172         (_initialize_valprint): Add 'print max-depth' option.
5173         * valprint.h (struct value_print_options) <max_depth>: New field.
5174         (val_print_check_max_depth): Declare new function.
5175         * NEWS: Document new feature.
5176
5177 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5178
5179         * ada-lang.c (ada_language_defn): Initialise new field.
5180         * c-lang.c (c_is_string_type_p): New function.
5181         (c_language_defn): Initialise new field.
5182         (cplus_language_defn): Initialise new field.
5183         (asm_language_defn): Initialise new field.
5184         (minimal_language_defn): Initialise new field.
5185         * c-lang.h (c_is_string_type_p): Declare new function.
5186         * d-lang.c (d_language_defn): Initialise new field.
5187         * f-lang.c (f_is_string_type_p): New function.
5188         (f_language_defn): Initialise new field.
5189         * go-lang.c (go_is_string_type_p): New function.
5190         (go_language_defn): Initialise new field.
5191         * language.c (default_is_string_type_p): New function.
5192         (unknown_language_defn): Initialise new field.
5193         (auto_language_defn): Initialise new field.
5194         * language.h (struct language_defn) <la_is_string_type_p>: New
5195         member variable.
5196         (default_is_string_type_p): Declare new function.
5197         * m2-lang.c (m2_language_defn): Initialise new field.
5198         * objc-lang.c (objc_language_defn): Initialise new field.
5199         * opencl-lang.c (opencl_language_defn): Initialise new field.
5200         * p-lang.c (pascal_is_string_type_p): New function.
5201         (pascal_language_defn): Initialise new field.
5202         * rust-lang.c (rust_is_string_type_p): New function.
5203         (rust_language_defn): Initialise new field.
5204
5205 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5206
5207         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5208         New field.
5209         * ada-lang.c (ada_language_defn): Initialise new field.
5210         * c-lang.c (c_language_defn): Likewise.
5211         (cplus_language_defn): Likewise.
5212         (asm_language_defn): Likewise.
5213         (minimal_language_defn): Likewise.
5214         * d-lang.c (d_language_defn): Likewise.
5215         * f-lang.c (f_language_defn): Likewise.
5216         * go-lang.c (go_language_defn): Likewise.
5217         * language.c (unknown_language_defn): Likewise.
5218         (auto_language_defn): Likewise.
5219         * m2-lang.c (m2_language_defn): Likewise.
5220         * objc-lang.c (objc_language_defn): Likewise.
5221         * opencl-lang.c (opencl_language_defn): Likewise.
5222         * p-lang.c (pascal_language_defn): Likewise.
5223         * rust-lang.c (rust_language_defn): Likewise.
5224
5225 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5226
5227         * ada-lang.c (ada_is_character_type): Change return type to bool.
5228         (ada_is_string_type): Likewise.
5229         * ada-lang.h (ada_is_character_type): Update declaration
5230         (ada_is_string_type): Likewise.
5231
5232 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5233
5234         Support style in 'frame|thread apply'
5235
5236         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5237         * record.c (record_start, record_stop): Update callers of
5238         execute_command_to_string with false.
5239         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5240         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5241         methods.
5242         (class string_file): New constructor with term_out parameter.
5243         Override methods term_out and can_emit_style_escape.  New member
5244         term_out.
5245         (class stdio_file): Override can_emit_style_escape.
5246         (class tee_file): Override term_out and can_emit_style_escape.
5247         * utils.h (can_emit_style_escape): Remove.
5248         * utils.c (can_emit_style_escape): Likewise.
5249         Update all callers of can_emit_style_escape (SOMESTREAM) to
5250         SOMESTREAM->can_emit_style_escape.
5251         * source-cache.c (source_cache::get_source_lines): Likewise.
5252         * stack.c (frame_apply_command_count): Call execute_command_to_string
5253         passing the term_out characteristic of the current gdb_stdout.
5254         * thread.c (thr_try_catch_cmd): Likewise.
5255         * top.c (execute_command_to_string): pass term_out parameter
5256         to construct the string_file for the command output.
5257         * ui-file.c (term_cli_styling): New function (most code moved
5258         from utils.c can_emit_style_escape).
5259         (string_file::string_file, string_file::can_emit_style_escape,
5260         stdio_file::can_emit_style_escape, tee_file::term_out,
5261         tee_file::can_emit_style_escape): New functions.
5262
5263 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5264
5265         * NEWS: Mention the new set|show may-call-functions.
5266         * infcall.c (may_call_functions_p): New variable.
5267         (show_may_call_functions_p): New function.
5268         (call_function_by_hand_dummy): Throws an error if not
5269         may-call-functions.
5270         (_initialize_infcall): Call add_setshow_boolean_cmd for
5271         may-call-functions.
5272
5273 2019-04-25  Keith Seitz  <keiths@redhat.com>
5274
5275         PR c++/24367
5276         * cp-support.c (inspect_type): Don't attempt substitutions
5277         of symbol with the same name.
5278
5279 2019-04-25  Tom Tromey  <tromey@adacore.com>
5280
5281         PR gdb/24475:
5282         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5283         static.
5284
5285 2019-04-25  Tom Tromey  <tromey@adacore.com>
5286
5287         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5288         rvalue reference.
5289         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5290         (gdb_xml_parser::parse): Use std::move.
5291         * python/python-internal.h (gdbpy_convert_exception): Take a const
5292         reference.
5293         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5294         std::move.
5295         * python/py-utils.c (gdbpy_convert_exception): Take a const
5296         reference.
5297         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5298         Use std::move.
5299         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5300         Use std::move.
5301         * mi/mi-main.c (mi_print_exception): Take a const reference.
5302         * main.c (handle_command_errors): Take a const reference.
5303         * linespec.c (parse_linespec): Use std::move.
5304         * infcall.c (run_inferior_call): Use std::move.
5305         (call_function_by_hand_dummy): Use std::move.
5306         * exec.c (try_open_exec_file): Use std::move.
5307         * exceptions.h (exception_print, exception_fprintf)
5308         (exception_print_same): Update.
5309         * exceptions.c (print_exception, exception_print)
5310         (exception_fprintf, exception_print_same): Change parameters to
5311         const reference.
5312         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5313         * common/new-op.c: Use std::move.
5314         * common/common-exceptions.h (struct gdb_exception): Add move
5315         constructor.
5316         (struct gdb_exception_error, struct gdb_exception_quit, struct
5317         gdb_quit_bad_alloc): Change constructor to move constructor.
5318         (throw_exception): Change parameter to rvalue reference.
5319         * common/common-exceptions.c (throw_exception): Take rvalue
5320         reference.
5321         * cli/cli-interp.c (safe_execute_command): Use std::move.
5322         * breakpoint.c (insert_bp_location, location_to_sals): Use
5323         std::move.
5324
5325 2019-04-25  Tom Tromey  <tromey@adacore.com>
5326
5327         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5328         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5329         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5330         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5331         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5332         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5333         guile/scm-value.c: Use unpack.
5334         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5335         gdbscm_gdb_exception.
5336         (gdbscm_throw_gdb_exception): Likewise.
5337         (struct gdbscm_gdb_exception): New.
5338         (unpack): New function.
5339         (gdbscm_wrap): Use unpack.
5340
5341 2019-04-25  Tom Tromey  <tromey@adacore.com>
5342
5343         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5344         (gdb_rl_callback_handler): Use std::move.
5345         * common/common-exceptions.h (struct gdb_exception): Add move
5346         assignment operator.
5347         (throw_exception_sjlj): Change "exception" to const reference.
5348         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5349         (throw_exception_sjlj): Change "exception" to const reference.
5350
5351 2019-04-25  Tom Tromey  <tromey@adacore.com>
5352
5353         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5354         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5355         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5356         Update.
5357         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5358         Update.
5359         * mi/mi-interp.c (mi_interp::exec): Update.
5360         * linespec.c (parse_linespec): Update.
5361         * infcall.c (run_inferior_call): Update.
5362         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5363         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5364         (gdbscm_lookup_global_symbol): Update.
5365         * guile/scm-param.c (gdbscm_parameter_value): Update.
5366         * guile/scm-frame.c (gdbscm_frame_read_register)
5367         (gdbscm_frame_read_var): Update.
5368         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5369         * exec.c (try_open_exec_file): Update.
5370         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5371         (gdb_rl_callback_handler): Update.
5372         * common/common-exceptions.h (exception_none): Don't declare.
5373         * common/common-exceptions.c (exception_none): Don't define.
5374         (struct catcher) <exception>: Update.
5375         * cli/cli-interp.c (safe_execute_command): Update.
5376         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5377
5378 2019-04-25  Ali Tamur  <tamur@google.com>
5379
5380         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5381         (read_attribute_value): Likewise.
5382         (dwarf2_read_addr_index): Update comment.
5383         (read_str_index): Add DW_FORM_strx.
5384         (dwarf2_string_attr): Likewise.
5385         (dwarf2_const_value_attr): Likewise.
5386         (dump_die_shallow): Likewise.
5387         (dwarf2_fetch_constant_bytes): Likewise.
5388         (skip_form_bytes): Likewise.
5389         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5390
5391 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5392
5393         PR corefiles/11608
5394         PR corefiles/18187
5395         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5396         OFFSET.  Verify if current mapping contains an ELF header.
5397         (linux_find_memory_regions_full): Adjust call to
5398         dump_mapping_p.
5399
5400 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5401             Kang Li <kanglictf@gmail.com>
5402
5403         PR gdb/21600
5404
5405         * dwarf2-frame.c (read_initial_length): Be consistent about using
5406         unsigned representation of length.
5407         (decode_frame_entry_1): Likewise.  Check for wraparound of
5408         end pointer as well as buffer overflow.
5409
5410 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5411
5412         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5413         "vq".
5414
5415 2019-04-24  Tom Tromey  <tromey@adacore.com>
5416
5417         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5418
5419 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5420
5421         * s12z-tdep.c (s12z_unwind_pc): Delete.
5422         (s12z_unwind_sp): Delete.
5423         (s12z_gdbarch_init): Don't register deleted functions with
5424         gdbarch.
5425
5426 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5427
5428         * rl78-tdep.c (rl78_unwind_sp): Delete.
5429         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5430
5431 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5432
5433         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5434         (xstormy16_unwind_pc): Delete.
5435         (xstormy16_dummy_id): Delete.
5436         (xstormy16_gdbarch_init): Don't register deleted functions with
5437         gdbarch.
5438
5439 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5440
5441         * vax-tdep.c (vax_unwind_pc): Delete.
5442         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5443
5444 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5445
5446         * v850-tdep.c (v850_unwind_sp): Delete.
5447         (v850_unwind_pc): Delete.
5448         (v850_dummy_id): Delete.
5449         (v850_gdbarch_init): Don't register deleted functions with
5450         gdbarch.
5451
5452 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5453
5454         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5455         (tilegx_unwind_pc): Delete.
5456         (tilegx_unwind_dummy_id): Delete.
5457         (tilegx_gdbarch_init): Don't register deleted functions with
5458         gdbarch.
5459
5460 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5461
5462         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5463         (tic6x_dummy_id): Delete.
5464         (tic6x_gdbarch_init): Don't register deleted functions with
5465         gdbarch.
5466
5467 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5468
5469         * sparc-tdep.c (sparc_unwind_pc): Delete.
5470         (sparc32_gdbarch_init): Don't register deleted function with
5471         gdbarch.
5472
5473 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5474
5475         * sh-tdep.c (sh_unwind_sp): Delete.
5476         (sh_unwind_pc): Delete.
5477         (sh_dummy_id): Delete.
5478         (sh_gdbarch_init): Don't register deleted functions with
5479         gdbarch.
5480
5481 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5482
5483         * score-tdep.c (score_unwind_sp): Delete.
5484         (score_unwind_pc): Delete.
5485         (score_dummy_id): Delete.
5486         (score_gdbarch_init): Don't register deleted functions with
5487         gdbarch.
5488
5489 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5490
5491         * rx-tdep.c (rx_unwind_pc): Delete.
5492         (rx_unwind_sp): Delete.
5493         (rx_dummy_id): Delete.
5494         (rx_gdbarch_init): Don't register deleted functions with
5495         gdbarch.  Update comment.
5496
5497 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5498
5499         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5500         (rs6000_dummy_id): Delete.
5501         (rs6000_gdbarch_init): Don't register deleted functions with
5502         gdbarch.
5503
5504 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5505
5506         * or1k-tdep.c (or1k_dummy_id): Delete.
5507         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5508
5509 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5510
5511         * nios2-tdep.c (nios2_dummy_id): Delete.
5512         (nios2_unwind_sp): Delete.
5513         (nios2_gdbarch_init): Don't register deleted functions with
5514         gdbarch.
5515
5516 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5517
5518         * nds32-tdep.c (nds32_dummy_id): Delete.
5519         (nds32_unwind_pc): Delete.
5520         (nds32_unwind_sp): Delete.
5521         (nds32_gdbarch_init): Don't register deleted functions with
5522         gdbarch.
5523
5524 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5525
5526         * msp430-tdep.c (msp430_unwind_pc): Delete.
5527         (msp430_unwind_sp): Delete.
5528         (msp430_dummy_id): Delete.
5529         (msp430_gdbarch_init): Don't register deleted functions with
5530         gdbarch.
5531
5532 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5533
5534         * moxie-tdep.c (moxie_unwind_sp): Delete.
5535         (moxie_unwind_pc): Delete.
5536         (moxie_dummy_id): Delete.
5537         (moxie_gdbarch_init): Don't register deleted functions with
5538         gdbarch.
5539
5540 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5541
5542         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5543         (mn10300_unwind_pc): Delete.
5544         (mn10300_unwind_sp): Delete.
5545         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5546         mn10300_unwind_sp.
5547         (mn10300_frame_unwind_init): Don't register deleted functions with
5548         gdbarch.
5549
5550 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5551
5552         * mep-tdep.c (mep_unwind_pc): Delete.
5553         (mep_unwind_sp): Delete.
5554         (mep_dummy_id): Delete.
5555         (mep_gdbarch_init): Don't register deleted functions with
5556         gdbarch.
5557
5558 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5559
5560         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5561         (m68hc11_unwind_sp): Delete.
5562         (m68hc11_gdbarch_init): Don't register deleted functions with
5563         gdbarch.
5564
5565 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5566
5567         * m32r-tdep.c (m32r_unwind_sp): Delete.
5568         (m32r_unwind_pc): Delete.
5569         (m32r_dummy_id): Delete.
5570         (m32r_gdbarch_init): Don't register deleted functions with
5571         gdbarch.
5572
5573 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5574
5575         * m32c-tdep.c (m32c_unwind_pc): Delete.
5576         (m32c_unwind_sp): Delete.
5577         (m32c_dummy_id): Delete.
5578         (m32c_gdbarch_init): Don't register deleted functions with
5579         gdbarch.
5580
5581 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5582
5583         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5584         (lm32_unwind_pc): Delete.
5585         (lm32_dummy_id): Delete.
5586         (lm32_gdbarch_init): Don't register deleted functions with
5587         gdbarch.
5588
5589 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5590
5591         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5592         (iq2000_unwind_pc): Delete.
5593         (iq2000_dummy_id): Delete.
5594         (iq2000_gdbarch_init): Don't register deleted functions with
5595         gdbarch.
5596
5597 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5598
5599         * nds32-tdep.c (nds32_type_align): Delete.
5600         (nds32_push_dummy_call): Use type_align instead.
5601
5602 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5603
5604         * arm-tdep.c (arm_type_align): Only handle vector override case.
5605         (arm_push_dummy_call): Use type_align.
5606         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5607
5608 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5609
5610         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5611         case.
5612         (pass_on_stack): Use type_align.
5613         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5614         function.
5615
5616 2019-04-23  Tom Tromey  <tromey@adacore.com>
5617
5618         * dwarf2read.c (line_header::file_name_at): Remove unused
5619         overload.
5620
5621 2019-04-23  Tom de Vries  <tdevries@suse.de>
5622
5623         PR gdb/24438
5624         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5625         invocation.
5626
5627
5628 2019-03-27  Ali Tamur  <tamur@google.com>
5629
5630         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5631         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5632         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5633         (dwarf_expr_context::get_addr_index): Likewise
5634         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5635         (symbol_needs_eval_context::get_addr_index): Likewise
5636         (disassemble_dwarf_expression): Add DW_OP_addrx
5637         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5638         (read_cutu_die_from_dwo): Update comment
5639         (skip_one_die): Add DW_FORM_addrx
5640         (read_attribute_value): Likewise
5641         (var_decode_location): Add DW_OP_addrx
5642         (dwarf2_const_value_attr): Add DW_FORM_addrx
5643         (dump_die_shallow): Likewise
5644         (dwarf2_fetch_constant_bytes): Likewise
5645         (decode_locdesc): Add DW_OP_addrx
5646         (skip_form_bytes): Add DW_FORM_addrx
5647
5648 2019-04-22  Ali Tamur  <tamur@google.com>
5649
5650         * MAINTAINERS (Write After Approval): Add self.
5651
5652 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5653
5654         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5655         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5656         (open_symbol_file_object): Likewise.
5657         (svr4_default_sos): Add info parameter.
5658         (svr4_read_so_list): Likewise.
5659         (svr4_current_sos_direct): Adjust functions calls to pass down
5660         info.
5661         (svr4_current_sos_1): Add info parameter.
5662         (svr4_current_sos): Call get_svr4_info, pass info down to
5663         svr4_current_sos_1.
5664         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5665         get_svr4_info.
5666         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5667         get_svr4_info.
5668         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5669         to get_svr4_info.
5670         (probes_table_remove_objfile_probes): Likewise.
5671         (register_solib_event_probe): Add info parameter.
5672         (solist_update_incremental): Pass info parameter down to
5673         svr4_read_so_list.
5674         (disable_probes_interface): Add info parameter.
5675         (svr4_handle_solib_event): Pass current_program_space to
5676         get_svr4_info.  Adjust disable_probes_interface cleanup.
5677         (svr4_create_probe_breakpoints): Add info parameter, pass it
5678         down to register_solib_event_probe.
5679         (svr4_create_solib_event_breakpoints): Add info parameter,
5680         pass it down to svr4_create_probe_breakpoints.
5681         (enable_break): Pass info down to
5682         svr4_create_solib_event_breakpoints.
5683         (svr4_solib_create_inferior_hook): Pass current_program_space to
5684         get_svr4_info.
5685         (svr4_clear_solib): Likewise.
5686
5687 2019-04-22  Pedro Alves  <palves@redhat.com>
5688
5689         * solib-svr4.c (svr4_free_objfile_observer): New.
5690         (probe_and_action::objfile): New field.
5691         (probes_table_htab_remove_objfile_probes)
5692         (probes_table_remove_objfile_probes): New functions.
5693         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5694         in the new probe_and_action.  Don't store the probe in 'lookup'.
5695         (svr4_create_probe_breakpoints): Pass objfile to
5696         register_solib_event_probe.
5697         (_initialize_svr4_solib): Register a free_objfile observer.
5698
5699 2019-04-19  Tom Tromey  <tom@tromey.com>
5700
5701         * common/queue.h: Remove.
5702
5703 2019-04-19  Tom Tromey  <tom@tromey.com>
5704
5705         * event-loop.c: Don't include "common/queue.h".
5706
5707 2019-04-19  Tom Tromey  <tom@tromey.com>
5708
5709         * remote.c (remote_target): Use delete.
5710         * remote-notif.h: Include <list>, not "common/queue.h".
5711         (notif_client_p): Remove typedef.
5712         (remote_notif_state): Add constructor, destructor, initializer.
5713         <notif_queue>: Now a std::list.
5714         (remote_notif_state_xfree): Don't declare.
5715         * remote-notif.c (remote_notif_process, handle_notification)
5716         (remote_notif_state_allocate): Update.
5717         (~remote_notif_state): Rename from remote_notif_state_xfree.
5718
5719 2019-04-19  Tom Tromey  <tom@tromey.com>
5720
5721         * symfile.c (reread_symbols): Update.
5722         * objfiles.c (objfile_register_static_link)
5723         (objfile_lookup_static_link): Update
5724         (~objfile) Don't delete static_links.
5725         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5726
5727 2019-04-19  Tom Tromey  <tom@tromey.com>
5728
5729         * type-stack.h (struct type_stack) <insert>: Constify string.
5730         * type-stack.c (type_stack::insert): Constify string.
5731         * gdbtypes.h (lookup_template_type): Update.
5732         (address_space_name_to_int): Update.
5733         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5734         const.
5735         (lookup_template_type): Make name const.
5736         * c-exp.y: Update rules.
5737         (lex_one_token, classify_name, classify_inner_name)
5738         (c_print_token): Update.
5739         * p-exp.y: Update rules.
5740         (yylex): Update.
5741         * f-exp.y: Update rules.
5742         (yylex): Update.
5743         * d-exp.y: Update rules.
5744         (lex_one_token, classify_name, classify_inner_name): Update.
5745         * parse.c (write_dollar_variable, copy_name): Return std::string.
5746         * parser-defs.h (copy_name): Change return type.
5747         * m2-exp.y: Update rules.
5748         (yylex): Update.
5749         * go-exp.y (lex_one_token): Update.
5750         Update rules.
5751         (classify_unsafe_function, classify_packaged_name)
5752         (classify_name, yylex): Update.
5753
5754 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5755
5756         * configure.ac: add --enable-source-highlight switch.
5757         * configure: Regenerate.
5758         * top.c (print_gdb_version): plumb --enable-source-highlight
5759         status to "show configuration".
5760
5761 2019-04-19  Tom Tromey  <tromey@adacore.com>
5762
5763         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5764         Check ADA_TYPE_P.
5765         (empty_record, ada_template_to_fixed_record_type_1)
5766         (template_to_static_fixed_type)
5767         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5768         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5769         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5770         macros.
5771
5772 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5773
5774         PR symtab/24423:
5775         * source.c (print_source_lines_base): Advance "iter" when a
5776         control character is seen.
5777
5778 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5779
5780         * inferior.h (struct infcall_suspend_state_deleter):
5781         Catch exception in destructor to avoid crash.
5782
5783 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5784
5785         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5786         close to the add_com "shell".
5787
5788 2019-04-18  Tom Tromey  <tromey@adacore.com>
5789
5790         * process-stratum-target.h (class process_stratum_target)
5791         <stratum>: Add "final".
5792
5793 2019-04-17  Tom Tromey  <tromey@adacore.com>
5794
5795         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5796         against nullptr before use.
5797
5798 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5799
5800         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5801
5802 2019-04-17  Jim Wilson  <jimw@sifive.com>
5803             Andrew Burgess  <andrew.burgess@embecosm.com>
5804
5805         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5806         code read might fail, assume 4-byte breakpoint in that case.
5807
5808 2019-04-15  Leszek Swirski  <leszeks@google.com>
5809
5810         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5811         rather than a hand-rolled POD check when checking for forced MEMORY
5812         classification.
5813
5814 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5815
5816         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5817         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5818         function.
5819         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5820         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5821         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5822         declaration.
5823
5824 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5825
5826         * aarch64-linux-nat.c
5827         (aarch64_linux_nat_target::thread_architecture): Add override.
5828         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5829         each VQ.
5830
5831 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5832
5833         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5834
5835 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5836
5837         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5838         target types of size 96-bits, add some additional comments, and
5839         check that the builtin type we found was the correct size.
5840
5841 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5842
5843         * utils.c (prompt_for_continue): Don't restore the styling at the
5844         end, as applied_style has the wrong value.  This fixes styling in
5845         long lists of file names that are interrupted by the "Continue?"
5846         prompt.
5847
5848 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5849
5850         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5851         * c-lang.c (c_language_defn): Likewise.
5852         (cplus_language_defn): Likewise.
5853         (asm_language_defn): Likewise.
5854         (minimal_language_defn): Likewise.
5855         * d-lang.c (d_language_defn): Likewise.
5856         * f-lang.c (f_language_defn): Likewise.
5857         * go-lang.c (go_language_defn): Likewise.
5858         * language.c (unknown_language_defn): Likewise.
5859         (auto_language_defn): Likewise.
5860         * language.h (struct language_defn): Remove la_magic field.
5861         (LANG_MAGIC): Delete.
5862         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5863         * objc-lang.c (objc_language_defn): Likewise.
5864         * opencl-lang.c (opencl_language_defn): Likewise.
5865         * p-lang.c (pascal_language_defn): Likewise.
5866         * rust-lang.c (rust_language_defn): Likewise.
5867
5868 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5869
5870         * riscv-tdep.c (riscv_type_align): New function.
5871         (riscv_type_alignment): Delete.
5872         (riscv_arg_location): Use 'type_align'.
5873         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5874
5875 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5876
5877         * gdbtypes.c (type_align): A struct with no non-static fields also
5878         has alignment of 1.
5879
5880 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5881
5882         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5883         component to 0.
5884         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5885         member.
5886         (riscv_struct_info::analyse): New implementation using new
5887         analyse_inner member function.
5888         (riscv_struct_info::field_offset): New member function.
5889         (riscv_struct_info::m_offsets): New member variable.
5890         (riscv_struct_info::analyse_inner): New private member function,
5891         takes the old implementation of riscv_struct_info::analyse but
5892         extended to track field offsets.
5893         (riscv_call_arg_struct): Update the struct folding special cases
5894         to handle cases where empty C++ structs, which are non-zero
5895         length, are found.
5896         (riscv_arg_location): Initialise the length of each location, a
5897         non-zero length now indicates the location is in use.
5898         (riscv_push_dummy_call): Allow for the first location having a
5899         non-zero offset when setting up arguments.
5900         (riscv_return_value): Likewise, but for return values.
5901
5902 2019-04-11  Tom Tromey  <tromey@adacore.com>
5903
5904         * utils.c (internal_vproblem): Make "msg" const.
5905
5906 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5907
5908         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5909         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5910         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5911         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5912
5913 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5914
5915         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5916         function.
5917         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5918         of amd64_collect_native_gregset.
5919         (amd64_linux_nat_target::store_registers): Likewise.
5920
5921 2019-04-10  Tom Tromey  <tom@tromey.com>
5922
5923         * symtab.c (lookup_global_symbol_from_objfile)
5924         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5925         * objfiles.h (class separate_debug_iterator): New.
5926         (class separate_debug_range): New.
5927         (struct objfile) <separate_debug_objfiles>: New method.
5928         (objfile_separate_debug_iterate): Don't declare.
5929         * objfiles.c (separate_debug_iterator::operator++): Rename from
5930         objfile_separate_debug_iterate.
5931         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5932         iterator.
5933         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5934         iterator.
5935
5936 2019-04-10  Tom Tromey  <tom@tromey.com>
5937
5938         * symfile.c (reread_symbols): Remove old comment.
5939         * objfiles.c (free_all_objfiles): Fix a typo.
5940
5941 2019-04-10  Tom Tromey  <tom@tromey.com>
5942
5943         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5944         * minsyms.c (lookup_minimal_symbol): Use foreach.
5945         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5946         (lookup_minimal_symbol_solib_trampoline): Likewise.
5947         * symfile.c (reread_symbols): Use foreach.
5948
5949 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5950             Tom Tromey  <tromey@adacore.com>
5951
5952         PR rust/24414:
5953         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5954         (rust_lex_int_test): Change "value" to be LONGEST.
5955         (rust_lex_tests): Add test for long integer literal.
5956
5957 2019-04-09  Tom Tromey  <tromey@adacore.com>
5958
5959         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5960         to bool.
5961         (extended_remote_target::attach): Update.
5962         (remote_target::remote_notice_new_inferior): Update.
5963         (remote_target::add_current_inferior_and_thread): Update.
5964         * inferior.c (exit_inferior_1): Use "false".
5965         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5966
5967 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5968
5969         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5970         the "start" command.
5971
5972 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5973
5974         * python/py-inferior.c (infpy_thread_from_thread_handle):
5975         Adjust comments to reflect renaming of thread_from_thread_handle
5976         to thread_from_handle.  Adjust keywords.  Fix type error message.
5977         (inferior_object_methods): Add thread_from_handle.  Retain
5978         thread_from_thread_handle, but mark it as deprecated.
5979
5980 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5981
5982         * gdbthread.h (find_thread_by_handle): Revise declaration.
5983         * thread.c (find_thread_by_handle): Likewise.  Adjust
5984         implementation too.
5985         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5986         support for buffer objects as handles.
5987
5988 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5989
5990         * python/py-infthread.c (thpy_thread_handle): New function.
5991         (thread_object_methods): Register thpy_thread_handle.
5992
5993 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5994
5995         * gdbthread.h (thread_to_thread_handle): Declare.
5996         * thread.c (gdbtypes.h): Include.
5997         (thread_to_thread_handle): New function.
5998
5999         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6000         (target_thread_info_to_thread_handle): Declare.
6001         * target.c (target_thread_info_to_thread_handle): New function.
6002         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6003         * target-delegates.c: Regenerate.
6004
6005         * linux-thread-db.c (class thread_db_target): Add method
6006         thread_info_to_thread_handle.
6007         (thread_db_target::thread_info_to_thread_handle): Define.
6008         * remote.c (class remote_target): Add new method
6009         thread_info_to_thread_handle.
6010         (remote_target::thread_info_to_thread_handle): Define.
6011
6012 2019-04-08  Pedro Alves  <palves@redhat.com>
6013
6014         * common/common-exceptions.c (throw_exception): Don't create
6015         named object to throw; throw directly.
6016         (throw_it): Likewise.  Don't initialize gdb_exception::message
6017         here, with new; pass FMT and AP to the ctor instead.
6018         * common/common-exceptions.h: Include <string>.
6019         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6020         const char *, va_list)): New ctor.  Use std::make_shared.
6021         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6022         errors)): Delete.
6023         (gdb_exception_error::gdb_exception_error(enum errors, const char
6024         *, va_list)): New.
6025         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6026         Add assertion.
6027         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6028         errors)): Delete.
6029         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6030         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6031         Add assertion.
6032
6033 2019-04-08  Tom Tromey  <tom@tromey.com>
6034
6035         * valops.c (value_rtti_indirect_type): Replace throw_exception
6036         with throw.
6037         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6038         with throw.
6039         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6040         throw.
6041         * target.c (target_translate_tls_address): Replace throw_exception
6042         with throw.
6043         * stack.c (frame_apply_command_count): Replace throw_exception
6044         with throw.
6045         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6046         throw.
6047         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6048         with throw.
6049         * rs6000-tdep.c (rs6000_frame_cache)
6050         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6051         * remote.c: Replace throw_exception with throw.
6052         * record-full.c (record_full_message, record_full_wait_1)
6053         (record_full_restore): Replace throw_exception with throw.
6054         * record-btrace.c:
6055         (get_thread_current_frame_id, record_btrace_start_replaying)
6056         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6057         (cmd_record_btrace_start): Replace throw_exception with throw.
6058         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6059         throw.
6060         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6061         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6062         * linespec.c:
6063         (find_linespec_symbols): Replace throw_exception with throw.
6064         * infrun.c (displaced_step_prepare, resume): Replace
6065         throw_exception with throw.
6066         * infcmd.c (post_create_inferior): Replace throw_exception with
6067         throw.
6068         * inf-loop.c (inferior_event_handler): Replace throw_exception
6069         with throw.
6070         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6071         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6072         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6073         (get_prev_frame_always, get_frame_pc_if_available)
6074         (get_frame_address_in_block_if_available, get_frame_language):
6075         Replace throw_exception with throw.
6076         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6077         throw_exception with throw.
6078         * eval.c (fetch_subexp_value, evaluate_var_value)
6079         (evaluate_funcall, evaluate_subexp_standard): Replace
6080         throw_exception with throw.
6081         * dwarf2loc.c (call_site_find_chain)
6082         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6083         Replace throw_exception with throw.
6084         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6085         with throw.
6086         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6087         throw.
6088         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6089         * completer.c (complete_line_internal): Replace throw_exception
6090         with throw.
6091         * compile/compile-object-run.c (compile_object_run): Replace
6092         throw_exception with throw.
6093         * cli/cli-script.c (process_next_line): Replace throw_exception
6094         with throw.
6095         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6096         (btrace_enable, btrace_maint_update_pt_packets): Replace
6097         throw_exception with throw.
6098         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6099         throw_exception with throw.
6100         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6101         throw_exception with throw.
6102         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6103         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6104         * aarch64-tdep.c (aarch64_make_prologue_cache)
6105         (aarch64_make_stub_cache): Replace throw_exception with throw.
6106
6107 2019-04-08  Tom Tromey  <tom@tromey.com>
6108
6109         * common/common-exceptions.c (throw_exception): Rename from
6110         throw_exception_cxx.  Remove old copy.  Make argument const.
6111         (throw_it): Create and throw exception objects directly.
6112         * common/common-exceptions.h (throw_exception): Make argument
6113         const.
6114         (struct gdb_exception_error): Add constructor.
6115         (struct gdb_exception_quit): Add constructor.
6116
6117 2019-04-08  Tom Tromey  <tom@tromey.com>
6118
6119         * common/common-exceptions.h (exception_rethrow): Don't declare.
6120         (TRY_SJLJ): Update comment.
6121         (TRY, CATCH, END_CATCH): Remove.
6122         * common/common-exceptions.c (exception_rethrow): Remove.
6123
6124 2019-04-08  Tom Tromey  <tom@tromey.com>
6125
6126         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6127         Remove.
6128         (gdb_exception_error): Rename from
6129         gdb_exception_RETURN_MASK_ERROR.
6130         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6131         (gdb_quit_bad_alloc): Update.
6132         * aarch64-tdep.c: Update.
6133         * ada-lang.c: Update.
6134         * ada-typeprint.c: Update.
6135         * ada-valprint.c: Update.
6136         * amd64-tdep.c: Update.
6137         * arch-utils.c: Update.
6138         * break-catch-throw.c: Update.
6139         * breakpoint.c: Update.
6140         * btrace.c: Update.
6141         * c-varobj.c: Update.
6142         * cli/cli-cmds.c: Update.
6143         * cli/cli-interp.c: Update.
6144         * cli/cli-script.c: Update.
6145         * common/common-exceptions.c: Update.
6146         * common/new-op.c: Update.
6147         * common/selftest.c: Update.
6148         * compile/compile-c-symbols.c: Update.
6149         * compile/compile-cplus-symbols.c: Update.
6150         * compile/compile-object-load.c: Update.
6151         * compile/compile-object-run.c: Update.
6152         * completer.c: Update.
6153         * corelow.c: Update.
6154         * cp-abi.c: Update.
6155         * cp-support.c: Update.
6156         * cp-valprint.c: Update.
6157         * darwin-nat.c: Update.
6158         * disasm-selftests.c: Update.
6159         * dtrace-probe.c: Update.
6160         * dwarf-index-cache.c: Update.
6161         * dwarf-index-write.c: Update.
6162         * dwarf2-frame-tailcall.c: Update.
6163         * dwarf2-frame.c: Update.
6164         * dwarf2loc.c: Update.
6165         * dwarf2read.c: Update.
6166         * eval.c: Update.
6167         * event-loop.c: Update.
6168         * event-top.c: Update.
6169         * exec.c: Update.
6170         * f-valprint.c: Update.
6171         * fbsd-tdep.c: Update.
6172         * frame-unwind.c: Update.
6173         * frame.c: Update.
6174         * gdbtypes.c: Update.
6175         * gnu-v3-abi.c: Update.
6176         * guile/guile-internal.h: Update.
6177         * guile/scm-block.c: Update.
6178         * guile/scm-breakpoint.c: Update.
6179         * guile/scm-cmd.c: Update.
6180         * guile/scm-disasm.c: Update.
6181         * guile/scm-frame.c: Update.
6182         * guile/scm-lazy-string.c: Update.
6183         * guile/scm-math.c: Update.
6184         * guile/scm-param.c: Update.
6185         * guile/scm-ports.c: Update.
6186         * guile/scm-pretty-print.c: Update.
6187         * guile/scm-symbol.c: Update.
6188         * guile/scm-symtab.c: Update.
6189         * guile/scm-type.c: Update.
6190         * guile/scm-value.c: Update.
6191         * i386-linux-tdep.c: Update.
6192         * i386-tdep.c: Update.
6193         * inf-loop.c: Update.
6194         * infcall.c: Update.
6195         * infcmd.c: Update.
6196         * infrun.c: Update.
6197         * jit.c: Update.
6198         * language.c: Update.
6199         * linespec.c: Update.
6200         * linux-fork.c: Update.
6201         * linux-nat.c: Update.
6202         * linux-tdep.c: Update.
6203         * linux-thread-db.c: Update.
6204         * main.c: Update.
6205         * mi/mi-cmd-break.c: Update.
6206         * mi/mi-cmd-stack.c: Update.
6207         * mi/mi-interp.c: Update.
6208         * mi/mi-main.c: Update.
6209         * objc-lang.c: Update.
6210         * p-valprint.c: Update.
6211         * parse.c: Update.
6212         * ppc-linux-tdep.c: Update.
6213         * printcmd.c: Update.
6214         * python/py-arch.c: Update.
6215         * python/py-breakpoint.c: Update.
6216         * python/py-cmd.c: Update.
6217         * python/py-finishbreakpoint.c: Update.
6218         * python/py-frame.c: Update.
6219         * python/py-framefilter.c: Update.
6220         * python/py-gdb-readline.c: Update.
6221         * python/py-inferior.c: Update.
6222         * python/py-infthread.c: Update.
6223         * python/py-lazy-string.c: Update.
6224         * python/py-linetable.c: Update.
6225         * python/py-objfile.c: Update.
6226         * python/py-param.c: Update.
6227         * python/py-prettyprint.c: Update.
6228         * python/py-progspace.c: Update.
6229         * python/py-record-btrace.c: Update.
6230         * python/py-record.c: Update.
6231         * python/py-symbol.c: Update.
6232         * python/py-type.c: Update.
6233         * python/py-unwind.c: Update.
6234         * python/py-utils.c: Update.
6235         * python/py-value.c: Update.
6236         * python/python.c: Update.
6237         * record-btrace.c: Update.
6238         * record-full.c: Update.
6239         * remote-fileio.c: Update.
6240         * remote.c: Update.
6241         * riscv-tdep.c: Update.
6242         * rs6000-aix-tdep.c: Update.
6243         * rs6000-tdep.c: Update.
6244         * rust-exp.y: Update.
6245         * rust-lang.c: Update.
6246         * s390-tdep.c: Update.
6247         * selftest-arch.c: Update.
6248         * solib-dsbt.c: Update.
6249         * solib-frv.c: Update.
6250         * solib-spu.c: Update.
6251         * solib-svr4.c: Update.
6252         * solib.c: Update.
6253         * sparc64-linux-tdep.c: Update.
6254         * stack.c: Update.
6255         * symfile-mem.c: Update.
6256         * symmisc.c: Update.
6257         * target.c: Update.
6258         * thread.c: Update.
6259         * top.c: Update.
6260         * tracefile-tfile.c: Update.
6261         * tui/tui.c: Update.
6262         * typeprint.c: Update.
6263         * unittests/cli-utils-selftests.c: Update.
6264         * unittests/parse-connection-spec-selftests.c: Update.
6265         * valops.c: Update.
6266         * valprint.c: Update.
6267         * value.c: Update.
6268         * varobj.c: Update.
6269         * windows-nat.c: Update.
6270         * x86-linux-nat.c: Update.
6271         * xml-support.c: Update.
6272
6273 2019-04-08  Tom Tromey  <tom@tromey.com>
6274
6275         * xml-support.c: Use C++ exception handling.
6276         * x86-linux-nat.c: Use C++ exception handling.
6277         * windows-nat.c: Use C++ exception handling.
6278         * varobj.c: Use C++ exception handling.
6279         * value.c: Use C++ exception handling.
6280         * valprint.c: Use C++ exception handling.
6281         * valops.c: Use C++ exception handling.
6282         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6283         handling.
6284         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6285         * typeprint.c: Use C++ exception handling.
6286         * tui/tui.c: Use C++ exception handling.
6287         * tracefile-tfile.c: Use C++ exception handling.
6288         * top.c: Use C++ exception handling.
6289         * thread.c: Use C++ exception handling.
6290         * target.c: Use C++ exception handling.
6291         * symmisc.c: Use C++ exception handling.
6292         * symfile-mem.c: Use C++ exception handling.
6293         * stack.c: Use C++ exception handling.
6294         * sparc64-linux-tdep.c: Use C++ exception handling.
6295         * solib.c: Use C++ exception handling.
6296         * solib-svr4.c: Use C++ exception handling.
6297         * solib-spu.c: Use C++ exception handling.
6298         * solib-frv.c: Use C++ exception handling.
6299         * solib-dsbt.c: Use C++ exception handling.
6300         * selftest-arch.c: Use C++ exception handling.
6301         * s390-tdep.c: Use C++ exception handling.
6302         * rust-lang.c: Use C++ exception handling.
6303         * rust-exp.y: Use C++ exception handling.
6304         * rs6000-tdep.c: Use C++ exception handling.
6305         * rs6000-aix-tdep.c: Use C++ exception handling.
6306         * riscv-tdep.c: Use C++ exception handling.
6307         * remote.c: Use C++ exception handling.
6308         * remote-fileio.c: Use C++ exception handling.
6309         * record-full.c: Use C++ exception handling.
6310         * record-btrace.c: Use C++ exception handling.
6311         * python/python.c: Use C++ exception handling.
6312         * python/py-value.c: Use C++ exception handling.
6313         * python/py-utils.c: Use C++ exception handling.
6314         * python/py-unwind.c: Use C++ exception handling.
6315         * python/py-type.c: Use C++ exception handling.
6316         * python/py-symbol.c: Use C++ exception handling.
6317         * python/py-record.c: Use C++ exception handling.
6318         * python/py-record-btrace.c: Use C++ exception handling.
6319         * python/py-progspace.c: Use C++ exception handling.
6320         * python/py-prettyprint.c: Use C++ exception handling.
6321         * python/py-param.c: Use C++ exception handling.
6322         * python/py-objfile.c: Use C++ exception handling.
6323         * python/py-linetable.c: Use C++ exception handling.
6324         * python/py-lazy-string.c: Use C++ exception handling.
6325         * python/py-infthread.c: Use C++ exception handling.
6326         * python/py-inferior.c: Use C++ exception handling.
6327         * python/py-gdb-readline.c: Use C++ exception handling.
6328         * python/py-framefilter.c: Use C++ exception handling.
6329         * python/py-frame.c: Use C++ exception handling.
6330         * python/py-finishbreakpoint.c: Use C++ exception handling.
6331         * python/py-cmd.c: Use C++ exception handling.
6332         * python/py-breakpoint.c: Use C++ exception handling.
6333         * python/py-arch.c: Use C++ exception handling.
6334         * printcmd.c: Use C++ exception handling.
6335         * ppc-linux-tdep.c: Use C++ exception handling.
6336         * parse.c: Use C++ exception handling.
6337         * p-valprint.c: Use C++ exception handling.
6338         * objc-lang.c: Use C++ exception handling.
6339         * mi/mi-main.c: Use C++ exception handling.
6340         * mi/mi-interp.c: Use C++ exception handling.
6341         * mi/mi-cmd-stack.c: Use C++ exception handling.
6342         * mi/mi-cmd-break.c: Use C++ exception handling.
6343         * main.c: Use C++ exception handling.
6344         * linux-thread-db.c: Use C++ exception handling.
6345         * linux-tdep.c: Use C++ exception handling.
6346         * linux-nat.c: Use C++ exception handling.
6347         * linux-fork.c: Use C++ exception handling.
6348         * linespec.c: Use C++ exception handling.
6349         * language.c: Use C++ exception handling.
6350         * jit.c: Use C++ exception handling.
6351         * infrun.c: Use C++ exception handling.
6352         * infcmd.c: Use C++ exception handling.
6353         * infcall.c: Use C++ exception handling.
6354         * inf-loop.c: Use C++ exception handling.
6355         * i386-tdep.c: Use C++ exception handling.
6356         * i386-linux-tdep.c: Use C++ exception handling.
6357         * guile/scm-value.c: Use C++ exception handling.
6358         * guile/scm-type.c: Use C++ exception handling.
6359         * guile/scm-symtab.c: Use C++ exception handling.
6360         * guile/scm-symbol.c: Use C++ exception handling.
6361         * guile/scm-pretty-print.c: Use C++ exception handling.
6362         * guile/scm-ports.c: Use C++ exception handling.
6363         * guile/scm-param.c: Use C++ exception handling.
6364         * guile/scm-math.c: Use C++ exception handling.
6365         * guile/scm-lazy-string.c: Use C++ exception handling.
6366         * guile/scm-frame.c: Use C++ exception handling.
6367         * guile/scm-disasm.c: Use C++ exception handling.
6368         * guile/scm-cmd.c: Use C++ exception handling.
6369         * guile/scm-breakpoint.c: Use C++ exception handling.
6370         * guile/scm-block.c: Use C++ exception handling.
6371         * guile/guile-internal.h: Use C++ exception handling.
6372         * gnu-v3-abi.c: Use C++ exception handling.
6373         * gdbtypes.c: Use C++ exception handling.
6374         * frame.c: Use C++ exception handling.
6375         * frame-unwind.c: Use C++ exception handling.
6376         * fbsd-tdep.c: Use C++ exception handling.
6377         * f-valprint.c: Use C++ exception handling.
6378         * exec.c: Use C++ exception handling.
6379         * event-top.c: Use C++ exception handling.
6380         * event-loop.c: Use C++ exception handling.
6381         * eval.c: Use C++ exception handling.
6382         * dwarf2read.c: Use C++ exception handling.
6383         * dwarf2loc.c: Use C++ exception handling.
6384         * dwarf2-frame.c: Use C++ exception handling.
6385         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6386         * dwarf-index-write.c: Use C++ exception handling.
6387         * dwarf-index-cache.c: Use C++ exception handling.
6388         * dtrace-probe.c: Use C++ exception handling.
6389         * disasm-selftests.c: Use C++ exception handling.
6390         * darwin-nat.c: Use C++ exception handling.
6391         * cp-valprint.c: Use C++ exception handling.
6392         * cp-support.c: Use C++ exception handling.
6393         * cp-abi.c: Use C++ exception handling.
6394         * corelow.c: Use C++ exception handling.
6395         * completer.c: Use C++ exception handling.
6396         * compile/compile-object-run.c: Use C++ exception handling.
6397         * compile/compile-object-load.c: Use C++ exception handling.
6398         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6399         * compile/compile-c-symbols.c: Use C++ exception handling.
6400         * common/selftest.c: Use C++ exception handling.
6401         * common/new-op.c: Use C++ exception handling.
6402         * cli/cli-script.c: Use C++ exception handling.
6403         * cli/cli-interp.c: Use C++ exception handling.
6404         * cli/cli-cmds.c: Use C++ exception handling.
6405         * c-varobj.c: Use C++ exception handling.
6406         * btrace.c: Use C++ exception handling.
6407         * breakpoint.c: Use C++ exception handling.
6408         * break-catch-throw.c: Use C++ exception handling.
6409         * arch-utils.c: Use C++ exception handling.
6410         * amd64-tdep.c: Use C++ exception handling.
6411         * ada-valprint.c: Use C++ exception handling.
6412         * ada-typeprint.c: Use C++ exception handling.
6413         * ada-lang.c: Use C++ exception handling.
6414         * aarch64-tdep.c: Use C++ exception handling.
6415
6416 2019-04-08  Tom Tromey  <tom@tromey.com>
6417
6418         * xml-support.c (gdb_xml_parser::parse): Update.
6419         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6420         * value.c (show_convenience): Update.
6421         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6422         (test_parse_flags_qcs): Update.
6423         * thread.c (thr_try_catch_cmd): Update.
6424         * target.c (target_translate_tls_address): Update.
6425         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6426         (info_frame_command_core, frame_apply_command_count): Update.
6427         * rust-exp.y (rust_lex_exception_test): Update.
6428         * riscv-tdep.c (riscv_print_one_register_info): Update.
6429         * remote.c (remote_target::enable_btrace): Update.
6430         * record-btrace.c (record_btrace_enable_warn): Update.
6431         * python/py-utils.c (gdbpy_convert_exception): Update.
6432         * printcmd.c (do_one_display, print_variable_and_value): Update.
6433         * mi/mi-main.c (mi_print_exception): Update.
6434         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6435         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6436         * linux-nat.c (linux_nat_target::attach): Update.
6437         * linux-fork.c (class scoped_switch_fork_info): Update.
6438         * infrun.c (displaced_step_prepare): Update.
6439         * infcall.c (call_function_by_hand_dummy): Update.
6440         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6441         * gnu-v3-abi.c (print_one_vtable): Update.
6442         * frame.c (get_prev_frame_always): Update.
6443         * f-valprint.c (info_common_command_for_block): Update.
6444         * exec.c (try_open_exec_file): Update.
6445         * exceptions.c (print_exception, exception_print)
6446         (exception_fprintf, exception_print_same): Update.
6447         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6448         * dwarf-index-cache.c (index_cache::store)
6449         (index_cache::lookup_gdb_index): Update.
6450         * darwin-nat.c (maybe_cache_shell): Update.
6451         * cp-valprint.c (cp_print_value_fields): Update.
6452         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6453         (gcc_cplus_symbol_address): Update.
6454         * compile/compile-c-symbols.c (gcc_convert_symbol)
6455         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6456         * common/selftest.c: Update.
6457         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6458         a std::string.
6459         (exception_try_scope_entry, exception_try_scope_exit): Don't
6460         declare.
6461         (struct exception_try_scope): Remove.
6462         (TRY): Don't use exception_try_scope.
6463         (struct gdb_exception): Add constructor, operator=.
6464         <what>: New method.
6465         (struct gdb_exception_RETURN_MASK_ALL)
6466         (struct gdb_exception_RETURN_MASK_ERROR)
6467         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6468         (struct gdb_quit_bad_alloc): Update.
6469         * common/common-exceptions.c (exception_none): Change
6470         initializer.
6471         (struct catcher) <state, exception>: Initialize inline.
6472         <prev>: Remove member.
6473         (current_catcher): Remove.
6474         (catchers): New global.
6475         (exceptions_state_mc_init): Simplify.
6476         (catcher_pop): Remove.
6477         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6478         (try_scope_depth, exception_try_scope_entry)
6479         (exception_try_scope_exit): Remove.
6480         (throw_exception_sjlj): Update.
6481         (exception_messages, exception_messages_size): Remove.
6482         (throw_it): Simplify.
6483         (gdb_exception_sliced_copy): Remove.
6484         (throw_exception_cxx): Update.
6485         * cli/cli-script.c (script_from_file): Update.
6486         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6487         Update.
6488         * ada-valprint.c (ada_val_print): Update.
6489         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6490         (create_excep_cond_exprs): Update.
6491
6492 2019-04-08  Tom Tromey  <tom@tromey.com>
6493
6494         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6495         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6496         (TRY, CATCH, END_CATCH): Remove some definitions.
6497         * common/common-exceptions.c: Don't use GDB_XCPT.
6498         (catcher_list_size): Remove.
6499         (throw_exception, throw_it): Simplify.
6500
6501 2019-04-05  Tom Tromey  <tom@tromey.com>
6502
6503         Revert the header-sorting patch.
6504         * ft32-tdep.c: Revert.
6505         * frv-tdep.c: Revert.
6506         * frv-linux-tdep.c: Revert.
6507         * frame.c: Revert.
6508         * frame-unwind.c: Revert.
6509         * frame-base.c: Revert.
6510         * fork-child.c: Revert.
6511         * findvar.c: Revert.
6512         * findcmd.c: Revert.
6513         * filesystem.c: Revert.
6514         * filename-seen-cache.h: Revert.
6515         * filename-seen-cache.c: Revert.
6516         * fbsd-tdep.c: Revert.
6517         * fbsd-nat.h: Revert.
6518         * fbsd-nat.c: Revert.
6519         * f-valprint.c: Revert.
6520         * f-typeprint.c: Revert.
6521         * f-lang.c: Revert.
6522         * extension.h: Revert.
6523         * extension.c: Revert.
6524         * extension-priv.h: Revert.
6525         * expprint.c: Revert.
6526         * exec.h: Revert.
6527         * exec.c: Revert.
6528         * exceptions.c: Revert.
6529         * event-top.c: Revert.
6530         * event-loop.c: Revert.
6531         * eval.c: Revert.
6532         * elfread.c: Revert.
6533         * dwarf2read.h: Revert.
6534         * dwarf2read.c: Revert.
6535         * dwarf2loc.c: Revert.
6536         * dwarf2expr.h: Revert.
6537         * dwarf2expr.c: Revert.
6538         * dwarf2-frame.c: Revert.
6539         * dwarf2-frame-tailcall.c: Revert.
6540         * dwarf-index-write.h: Revert.
6541         * dwarf-index-write.c: Revert.
6542         * dwarf-index-common.c: Revert.
6543         * dwarf-index-cache.h: Revert.
6544         * dwarf-index-cache.c: Revert.
6545         * dummy-frame.c: Revert.
6546         * dtrace-probe.c: Revert.
6547         * disasm.h: Revert.
6548         * disasm.c: Revert.
6549         * disasm-selftests.c: Revert.
6550         * dictionary.c: Revert.
6551         * dicos-tdep.c: Revert.
6552         * demangle.c: Revert.
6553         * dcache.h: Revert.
6554         * dcache.c: Revert.
6555         * darwin-nat.h: Revert.
6556         * darwin-nat.c: Revert.
6557         * darwin-nat-info.c: Revert.
6558         * d-valprint.c: Revert.
6559         * d-namespace.c: Revert.
6560         * d-lang.c: Revert.
6561         * ctf.c: Revert.
6562         * csky-tdep.c: Revert.
6563         * csky-linux-tdep.c: Revert.
6564         * cris-tdep.c: Revert.
6565         * cris-linux-tdep.c: Revert.
6566         * cp-valprint.c: Revert.
6567         * cp-support.c: Revert.
6568         * cp-namespace.c: Revert.
6569         * cp-abi.c: Revert.
6570         * corelow.c: Revert.
6571         * corefile.c: Revert.
6572         * continuations.c: Revert.
6573         * completer.h: Revert.
6574         * completer.c: Revert.
6575         * complaints.c: Revert.
6576         * coffread.c: Revert.
6577         * coff-pe-read.c: Revert.
6578         * cli-out.h: Revert.
6579         * cli-out.c: Revert.
6580         * charset.c: Revert.
6581         * c-varobj.c: Revert.
6582         * c-valprint.c: Revert.
6583         * c-typeprint.c: Revert.
6584         * c-lang.c: Revert.
6585         * buildsym.c: Revert.
6586         * buildsym-legacy.c: Revert.
6587         * build-id.h: Revert.
6588         * build-id.c: Revert.
6589         * btrace.c: Revert.
6590         * bsd-uthread.c: Revert.
6591         * breakpoint.h: Revert.
6592         * breakpoint.c: Revert.
6593         * break-catch-throw.c: Revert.
6594         * break-catch-syscall.c: Revert.
6595         * break-catch-sig.c: Revert.
6596         * blockframe.c: Revert.
6597         * block.c: Revert.
6598         * bfin-tdep.c: Revert.
6599         * bfin-linux-tdep.c: Revert.
6600         * bfd-target.c: Revert.
6601         * bcache.c: Revert.
6602         * ax-general.c: Revert.
6603         * ax-gdb.h: Revert.
6604         * ax-gdb.c: Revert.
6605         * avr-tdep.c: Revert.
6606         * auxv.c: Revert.
6607         * auto-load.c: Revert.
6608         * arm-wince-tdep.c: Revert.
6609         * arm-tdep.c: Revert.
6610         * arm-symbian-tdep.c: Revert.
6611         * arm-pikeos-tdep.c: Revert.
6612         * arm-obsd-tdep.c: Revert.
6613         * arm-nbsd-tdep.c: Revert.
6614         * arm-nbsd-nat.c: Revert.
6615         * arm-linux-tdep.c: Revert.
6616         * arm-linux-nat.c: Revert.
6617         * arm-fbsd-tdep.c: Revert.
6618         * arm-fbsd-nat.c: Revert.
6619         * arm-bsd-tdep.c: Revert.
6620         * arch-utils.c: Revert.
6621         * arc-tdep.c: Revert.
6622         * arc-newlib-tdep.c: Revert.
6623         * annotate.h: Revert.
6624         * annotate.c: Revert.
6625         * amd64-windows-tdep.c: Revert.
6626         * amd64-windows-nat.c: Revert.
6627         * amd64-tdep.c: Revert.
6628         * amd64-sol2-tdep.c: Revert.
6629         * amd64-obsd-tdep.c: Revert.
6630         * amd64-obsd-nat.c: Revert.
6631         * amd64-nbsd-tdep.c: Revert.
6632         * amd64-nbsd-nat.c: Revert.
6633         * amd64-nat.c: Revert.
6634         * amd64-linux-tdep.c: Revert.
6635         * amd64-linux-nat.c: Revert.
6636         * amd64-fbsd-tdep.c: Revert.
6637         * amd64-fbsd-nat.c: Revert.
6638         * amd64-dicos-tdep.c: Revert.
6639         * amd64-darwin-tdep.c: Revert.
6640         * amd64-bsd-nat.c: Revert.
6641         * alpha-tdep.c: Revert.
6642         * alpha-obsd-tdep.c: Revert.
6643         * alpha-nbsd-tdep.c: Revert.
6644         * alpha-mdebug-tdep.c: Revert.
6645         * alpha-linux-tdep.c: Revert.
6646         * alpha-linux-nat.c: Revert.
6647         * alpha-bsd-tdep.c: Revert.
6648         * alpha-bsd-nat.c: Revert.
6649         * aix-thread.c: Revert.
6650         * agent.c: Revert.
6651         * addrmap.c: Revert.
6652         * ada-varobj.c: Revert.
6653         * ada-valprint.c: Revert.
6654         * ada-typeprint.c: Revert.
6655         * ada-tasks.c: Revert.
6656         * ada-lang.c: Revert.
6657         * aarch64-tdep.c: Revert.
6658         * aarch64-ravenscar-thread.c: Revert.
6659         * aarch64-newlib-tdep.c: Revert.
6660         * aarch64-linux-tdep.c: Revert.
6661         * aarch64-linux-nat.c: Revert.
6662         * aarch64-fbsd-tdep.c: Revert.
6663         * aarch64-fbsd-nat.c: Revert.
6664         * aarch32-linux-nat.c: Revert.
6665
6666 2019-04-05  Tom Tromey  <tom@tromey.com>
6667
6668         * ft32-tdep.c: Sort headers.
6669         * frv-tdep.c: Sort headers.
6670         * frv-linux-tdep.c: Sort headers.
6671         * frame.c: Sort headers.
6672         * frame-unwind.c: Sort headers.
6673         * frame-base.c: Sort headers.
6674         * fork-child.c: Sort headers.
6675         * findvar.c: Sort headers.
6676         * findcmd.c: Sort headers.
6677         * filesystem.c: Sort headers.
6678         * filename-seen-cache.h: Sort headers.
6679         * filename-seen-cache.c: Sort headers.
6680         * fbsd-tdep.c: Sort headers.
6681         * fbsd-nat.h: Sort headers.
6682         * fbsd-nat.c: Sort headers.
6683         * f-valprint.c: Sort headers.
6684         * f-typeprint.c: Sort headers.
6685         * f-lang.c: Sort headers.
6686         * extension.h: Sort headers.
6687         * extension.c: Sort headers.
6688         * extension-priv.h: Sort headers.
6689         * expprint.c: Sort headers.
6690         * exec.h: Sort headers.
6691         * exec.c: Sort headers.
6692         * exceptions.c: Sort headers.
6693         * event-top.c: Sort headers.
6694         * event-loop.c: Sort headers.
6695         * eval.c: Sort headers.
6696         * elfread.c: Sort headers.
6697         * dwarf2read.h: Sort headers.
6698         * dwarf2read.c: Sort headers.
6699         * dwarf2loc.c: Sort headers.
6700         * dwarf2expr.h: Sort headers.
6701         * dwarf2expr.c: Sort headers.
6702         * dwarf2-frame.c: Sort headers.
6703         * dwarf2-frame-tailcall.c: Sort headers.
6704         * dwarf-index-write.h: Sort headers.
6705         * dwarf-index-write.c: Sort headers.
6706         * dwarf-index-common.c: Sort headers.
6707         * dwarf-index-cache.h: Sort headers.
6708         * dwarf-index-cache.c: Sort headers.
6709         * dummy-frame.c: Sort headers.
6710         * dtrace-probe.c: Sort headers.
6711         * disasm.h: Sort headers.
6712         * disasm.c: Sort headers.
6713         * disasm-selftests.c: Sort headers.
6714         * dictionary.c: Sort headers.
6715         * dicos-tdep.c: Sort headers.
6716         * demangle.c: Sort headers.
6717         * dcache.h: Sort headers.
6718         * dcache.c: Sort headers.
6719         * darwin-nat.h: Sort headers.
6720         * darwin-nat.c: Sort headers.
6721         * darwin-nat-info.c: Sort headers.
6722         * d-valprint.c: Sort headers.
6723         * d-namespace.c: Sort headers.
6724         * d-lang.c: Sort headers.
6725         * ctf.c: Sort headers.
6726         * csky-tdep.c: Sort headers.
6727         * csky-linux-tdep.c: Sort headers.
6728         * cris-tdep.c: Sort headers.
6729         * cris-linux-tdep.c: Sort headers.
6730         * cp-valprint.c: Sort headers.
6731         * cp-support.c: Sort headers.
6732         * cp-namespace.c: Sort headers.
6733         * cp-abi.c: Sort headers.
6734         * corelow.c: Sort headers.
6735         * corefile.c: Sort headers.
6736         * continuations.c: Sort headers.
6737         * completer.h: Sort headers.
6738         * completer.c: Sort headers.
6739         * complaints.c: Sort headers.
6740         * coffread.c: Sort headers.
6741         * coff-pe-read.c: Sort headers.
6742         * cli-out.h: Sort headers.
6743         * cli-out.c: Sort headers.
6744         * charset.c: Sort headers.
6745         * c-varobj.c: Sort headers.
6746         * c-valprint.c: Sort headers.
6747         * c-typeprint.c: Sort headers.
6748         * c-lang.c: Sort headers.
6749         * buildsym.c: Sort headers.
6750         * buildsym-legacy.c: Sort headers.
6751         * build-id.h: Sort headers.
6752         * build-id.c: Sort headers.
6753         * btrace.c: Sort headers.
6754         * bsd-uthread.c: Sort headers.
6755         * breakpoint.h: Sort headers.
6756         * breakpoint.c: Sort headers.
6757         * break-catch-throw.c: Sort headers.
6758         * break-catch-syscall.c: Sort headers.
6759         * break-catch-sig.c: Sort headers.
6760         * blockframe.c: Sort headers.
6761         * block.c: Sort headers.
6762         * bfin-tdep.c: Sort headers.
6763         * bfin-linux-tdep.c: Sort headers.
6764         * bfd-target.c: Sort headers.
6765         * bcache.c: Sort headers.
6766         * ax-general.c: Sort headers.
6767         * ax-gdb.h: Sort headers.
6768         * ax-gdb.c: Sort headers.
6769         * avr-tdep.c: Sort headers.
6770         * auxv.c: Sort headers.
6771         * auto-load.c: Sort headers.
6772         * arm-wince-tdep.c: Sort headers.
6773         * arm-tdep.c: Sort headers.
6774         * arm-symbian-tdep.c: Sort headers.
6775         * arm-pikeos-tdep.c: Sort headers.
6776         * arm-obsd-tdep.c: Sort headers.
6777         * arm-nbsd-tdep.c: Sort headers.
6778         * arm-nbsd-nat.c: Sort headers.
6779         * arm-linux-tdep.c: Sort headers.
6780         * arm-linux-nat.c: Sort headers.
6781         * arm-fbsd-tdep.c: Sort headers.
6782         * arm-fbsd-nat.c: Sort headers.
6783         * arm-bsd-tdep.c: Sort headers.
6784         * arch-utils.c: Sort headers.
6785         * arc-tdep.c: Sort headers.
6786         * arc-newlib-tdep.c: Sort headers.
6787         * annotate.h: Sort headers.
6788         * annotate.c: Sort headers.
6789         * amd64-windows-tdep.c: Sort headers.
6790         * amd64-windows-nat.c: Sort headers.
6791         * amd64-tdep.c: Sort headers.
6792         * amd64-sol2-tdep.c: Sort headers.
6793         * amd64-obsd-tdep.c: Sort headers.
6794         * amd64-obsd-nat.c: Sort headers.
6795         * amd64-nbsd-tdep.c: Sort headers.
6796         * amd64-nbsd-nat.c: Sort headers.
6797         * amd64-nat.c: Sort headers.
6798         * amd64-linux-tdep.c: Sort headers.
6799         * amd64-linux-nat.c: Sort headers.
6800         * amd64-fbsd-tdep.c: Sort headers.
6801         * amd64-fbsd-nat.c: Sort headers.
6802         * amd64-dicos-tdep.c: Sort headers.
6803         * amd64-darwin-tdep.c: Sort headers.
6804         * amd64-bsd-nat.c: Sort headers.
6805         * alpha-tdep.c: Sort headers.
6806         * alpha-obsd-tdep.c: Sort headers.
6807         * alpha-nbsd-tdep.c: Sort headers.
6808         * alpha-mdebug-tdep.c: Sort headers.
6809         * alpha-linux-tdep.c: Sort headers.
6810         * alpha-linux-nat.c: Sort headers.
6811         * alpha-bsd-tdep.c: Sort headers.
6812         * alpha-bsd-nat.c: Sort headers.
6813         * aix-thread.c: Sort headers.
6814         * agent.c: Sort headers.
6815         * addrmap.c: Sort headers.
6816         * ada-varobj.c: Sort headers.
6817         * ada-valprint.c: Sort headers.
6818         * ada-typeprint.c: Sort headers.
6819         * ada-tasks.c: Sort headers.
6820         * ada-lang.c: Sort headers.
6821         * aarch64-tdep.c: Sort headers.
6822         * aarch64-ravenscar-thread.c: Sort headers.
6823         * aarch64-newlib-tdep.c: Sort headers.
6824         * aarch64-linux-tdep.c: Sort headers.
6825         * aarch64-linux-nat.c: Sort headers.
6826         * aarch64-fbsd-tdep.c: Sort headers.
6827         * aarch64-fbsd-nat.c: Sort headers.
6828         * aarch32-linux-nat.c: Sort headers.
6829
6830 2019-04-04  Tom Tromey  <tom@tromey.com>
6831
6832         * varobj.c (varobj_create): Update.
6833         * rust-exp.y (struct rust_parser) <update_innermost_block,
6834         lookup_symbol>: New methods.
6835         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6836         Rename.
6837         (rust_parser::rust_lookup_type)
6838         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6839         * printcmd.c (display_command, do_one_display): Update.
6840         * parser-defs.h (struct parser_state) <parser_state>: Add
6841         "tracker" parameter.
6842         (block_tracker): New member.
6843         (class innermost_block_tracker) <innermost_block_tracker>: Add
6844         "types" parameter.
6845         <reset>: Remove method.
6846         (innermost_block): Don't declare.
6847         (null_post_parser): Update.
6848         * parse.c (innermost_block): Remove global.
6849         (write_dollar_variable): Update.
6850         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6851         Remove "tracker_types" parameter.
6852         (parse_expression): Add "tracker" parameter.
6853         (parse_expression_for_completion): Update.
6854         (null_post_parser): Add "tracker" parameter.
6855         * p-exp.y: Update rules.
6856         * m2-exp.y: Update rules.
6857         * language.h (struct language_defn) <la_post_parser>: Add
6858         "tracker" parameter.
6859         * go-exp.y: Update rules.
6860         * f-exp.y: Update rules.
6861         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6862         parameter.
6863         * d-exp.y: Update rules.
6864         * c-exp.y: Update rules.
6865         * breakpoint.c (set_breakpoint_condition): Create an
6866         innermost_block_tracker.
6867         (watch_command_1): Likewise.
6868         * ada-lang.c (resolve): Add "tracker" parameter.
6869         (resolve_subexp): Likewise.
6870         * ada-exp.y (write_var_from_sym): Update.
6871
6872 2019-04-04  Tom Tromey  <tom@tromey.com>
6873
6874         * type-stack.h: New file.
6875         * type-stack.c: New file.
6876         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6877         type-stack.h.
6878         (insert_into_type_stack, insert_type, push_type, push_type_int)
6879         (insert_type_address_space, pop_type, pop_type_int)
6880         (pop_typelist, pop_type_stack, append_type_stack)
6881         (push_type_stack, get_type_stack, push_typelist)
6882         (follow_type_instance_flags, follow_types): Don't declare.
6883         * parse.c (type_stack): Remove global.
6884         (parse_exp_in_context): Update.
6885         (insert_into_type_stack, insert_type, push_type, push_type_int)
6886         (insert_type_address_space, pop_type, pop_type_int)
6887         (pop_typelist, pop_type_stack, append_type_stack)
6888         (push_type_stack, get_type_stack, push_typelist)
6889         (follow_type_instance_flags, follow_types): Remove (moved to
6890         type-stack.c).
6891         * f-exp.y (type_stack): New global.
6892         Update rules.
6893         (push_kind_type, f_parse): Update.
6894         * d-exp.y (type_stack): New global.
6895         Update rules.
6896         (d_parse): Update.
6897         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6898         Update rules.
6899         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6900         (HFILES_NO_SRCDIR): Add type-stack.h.
6901
6902 2019-04-04  Tom Tromey  <tom@tromey.com>
6903
6904         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6905         (rust_parser::convert_ast_to_expression, rust_parse)
6906         (rust_lex_test_completion, rust_lex_tests): Update.
6907         * parser-defs.h (struct expr_completion_state): New.
6908         (struct parser_state) <parser_state>: Add completion parameter.
6909         <mark_struct_expression, mark_completion_tag>: New methods.
6910         <parse_completion, m_completion_state>: New members.
6911         (prefixify_expression, null_post_parser): Update.
6912         (mark_struct_expression, mark_completion_tag): Don't declare.
6913         * parse.c (parse_completion, expout_last_struct)
6914         (expout_tag_completion_type, expout_completion_name): Remove
6915         globals.
6916         (parser_state::mark_struct_expression)
6917         (parser_state::mark_completion_tag): Now methods.
6918         (prefixify_expression): Add last_struct parameter.
6919         (prefixify_subexp): Likewise.
6920         (parse_exp_1): Update.
6921         (parse_exp_in_context): Add cstate parameter.  Update.
6922         (parse_expression_for_completion): Create an
6923         expr_completion_state.
6924         (null_post_parser): Add "completion" parameter.
6925         * p-exp.y: Update rules.
6926         (yylex): Update.
6927         * language.h (struct language_defn) <la_post_parser>: Add
6928         "completing" parameter.
6929         * go-exp.y: Update rules.
6930         (lex_one_token): Update.
6931         * expression.h (parse_completion): Don't declare.
6932         * d-exp.y: Update rules.
6933         (lex_one_token): Update rules.
6934         * c-exp.y: Update rules.
6935         (lex_one_token): Update.
6936         * ada-lang.c (resolve): Add "parse_completion" parameter.
6937         (resolve_subexp): Likewise.
6938         (ada_resolve_function): Likewise.
6939
6940 2019-04-04  Tom Tromey  <tom@tromey.com>
6941
6942         * parser-defs.h (struct parser_state) <start_arglist,
6943         end_arglist>: New methods.
6944         <arglist_len, m_funcall_chain>: New members.
6945         (arglist_len, start_arglist, end_arglist): Don't declare.
6946         * parse.c (arglist_len, funcall_chain): Remove global.
6947         (start_arglist, end_arglist): Remove functions.
6948         (parse_exp_in_context): Update.
6949         * p-exp.y: Update rules.
6950         * m2-exp.y: Update rules.
6951         * go-exp.y: Update rules.
6952         * f-exp.y: Update rules.
6953         * d-exp.y: Update rules.
6954         * c-exp.y: Update rules.
6955
6956 2019-04-04  Tom Tromey  <tom@tromey.com>
6957
6958         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6959         lex_operator, push_back>: New methods.
6960         Update all rules.
6961         (rust_parser::lex_hex, lex_escape): Rename and update.
6962         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6963         (rust_parser::lex_operator): Rename and update.
6964         (rust_parser::lex_number, rustyylex, rustyyerror)
6965         (rust_lex_test_init, rust_lex_test_sequence)
6966         (rust_lex_test_push_back, rust_lex_tests): Update.
6967         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6968         parameter.
6969         <lexptr, prev_lexptr>: New members.
6970         (lexptr, prev_lexptr): Don't declare.
6971         * parse.c (lexptr, prev_lexptr): Remove globals.
6972         (parse_exp_in_context): Update.
6973         * p-exp.y (yylex, yyerror): Update.
6974         * m2-exp.y (parse_number, yylex, yyerror): Update.
6975         * go-exp.y (lex_one_token, yyerror): Update.
6976         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6977         * d-exp.y (lex_one_token, yyerror): Update.
6978         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6979         (lex_one_token, yyerror): Update.
6980         * ada-lex.l (YY_INPUT): Update.
6981         (rewind_to_char): Update.
6982         * ada-exp.y (yyerror): Update.
6983
6984 2019-04-04  Tom Tromey  <tom@tromey.com>
6985
6986         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6987         * parser-defs.h (struct parser_state) <parser_state>: Add new
6988         parameter.
6989         <comma_terminates>: New member.
6990         (comma_terminates): Don't declare global.
6991         * parse.c (comma_terminates): Remove global.
6992         (parse_exp_in_context): Update.
6993         * p-exp.y (yylex): Update.
6994         * m2-exp.y (yylex): Update.
6995         * go-exp.y (lex_one_token): Update.
6996         * f-exp.y (yylex): Update.
6997         * d-exp.y (lex_one_token): Update.
6998         * c-exp.y (lex_one_token): Update.
6999         * ada-lex.l: Update.
7000
7001 2019-04-04  Tom Tromey  <tom@tromey.com>
7002
7003         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7004         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7005         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7006         * parser-defs.h (paren_depth): Don't declare.
7007         * parse.c (paren_depth): Remove global.
7008         (parse_exp_in_context): Update.
7009         * p-exp.y (paren_depth): New global.
7010         (pascal_parse): Initialize it.
7011         * m2-exp.y (paren_depth): New global.
7012         (m2_parse): Initialize it.
7013         * go-exp.y (paren_depth): New global.
7014         (go_parse): Initialize it.
7015         * f-exp.y (paren_depth): New global.
7016         (f_parse): Initialize it.
7017         * d-exp.y (paren_depth): New global.
7018         (d_parse): Initialize it.
7019         * c-exp.y (paren_depth): New global.
7020         (c_parse): Initialize it.
7021         * ada-lex.l (paren_depth): New global.
7022         (lexer_init): Initialize it.
7023
7024 2019-04-04  Tom Tromey  <tom@tromey.com>
7025
7026         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7027         (rust_parser::convert_ast_to_type)
7028         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7029         * parser-defs.h (struct parser_state) <parser_state>: Add
7030         parameters.  Initialize new members.
7031         <expression_context_block, expression_context_pc>: New members.
7032         * parse.c (expression_context_block, expression_context_pc):
7033         Remove globals.
7034         (parse_exp_in_context): Update.
7035         * p-exp.y: Update all rules.
7036         (yylex): Update.
7037         * m2-exp.y: Update all rules.
7038         (yylex): Update.
7039         * go-exp.y (yylex): Update.
7040         * f-exp.y (yylex): Update.
7041         * d-exp.y: Update all rules.
7042         (yylex): Update.
7043         * c-exp.y: Update all rules.
7044         (lex_one_token, classify_name, yylex, c_parse): Update.
7045         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7046
7047 2019-04-04  Tom Tromey  <tom@tromey.com>
7048
7049         * gdbarch.h, gdbarch.c: Rebuild.
7050         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7051         * stap-probe.h: 
7052         (struct stap_parse_info): Replace "parser_state" with
7053         "expr_builder".
7054         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7055         (parser_state): New class.
7056         * parse.c (expr_builder): Rename.
7057         (expr_builder::release): Rename.
7058         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7059         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7060         (write_exp_elt_longcst, write_exp_elt_floatcst)
7061         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7062         (write_exp_string_vector, write_exp_bitstring)
7063         (write_exp_msymbol, mark_struct_expression)
7064         (write_dollar_variable)
7065         (insert_type_address_space, increase_expout_size): Replace
7066         "parser_state" with "expr_builder".
7067         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7068         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7069         "parser_state" with "expr_builder".
7070
7071 2019-04-04  Tom Tromey  <tom@tromey.com>
7072
7073         * rust-exp.y: Replace "parse_language" with method call.
7074         * p-exp.y: 
7075         (yylex): Replace "parse_language" with method call.
7076         * m2-exp.y: 
7077         (yylex): Replace "parse_language" with method call.
7078         * go-exp.y (classify_name): Replace "parse_language" with method
7079         call.
7080         * f-exp.y (yylex): Replace "parse_language" with method call.
7081         * d-exp.y (lex_one_token): Replace "parse_language" with method
7082         call.
7083         * c-exp.y: 
7084         (lex_one_token, classify_name, yylex): Replace "parse_language"
7085         with method call.
7086         * ada-exp.y (find_primitive_type, type_char)
7087         (type_system_address): Replace "parse_language" with method call.
7088
7089 2019-04-04  Tom Tromey  <tom@tromey.com>
7090
7091         * rust-exp.y: Replace "parse_gdbarch" with method call.
7092         * parse.c (write_dollar_variable, insert_type_address_space):
7093         Replace "parse_gdbarch" with method call.
7094         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7095         call.
7096         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7097         call.
7098         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7099         "parse_gdbarch" with method call.
7100         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7101         with method call.
7102         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7103         "parse_gdbarch" with method call.
7104         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7105         "parse_gdbarch" with method call.
7106         * c-exp.y (parse_type, parse_number, classify_name): Replace
7107         "parse_gdbarch" with method call.
7108         * ada-lex.l: Replace "parse_gdbarch" with method call.
7109         * ada-exp.y (parse_type, find_primitive_type, type_char)
7110         (type_system_address): Replace "parse_gdbarch" with method call.
7111
7112 2019-04-04  Tom Tromey  <tom@tromey.com>
7113
7114         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7115         * stap-probe.c (stap_parse_argument): Update.
7116         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7117         initial_size parameter.
7118         * rust-exp.y (rust_lex_tests): Update.
7119         * parse.c (parser_state): Update.
7120         (parse_exp_in_context): Update.
7121         * parser-defs.h (struct parser_state) <parser_state>: Remove
7122         "initial_size" parameter.
7123
7124 2019-04-04  Tom Tromey  <tom@tromey.com>
7125
7126         * parser-defs.h (increase_expout_size): Don't declare.
7127         * parse.c (increase_expout_size): Now static.
7128
7129 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7130
7131         * gnu-nat.c (gnu_nat_target::wait): Fix
7132         target_waitstatus_to_string call.
7133
7134 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7135
7136         * eval.c (evaluate_subexp_standard): Handle internal functions
7137         during Fortran function call handling.
7138
7139 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7140
7141         * NEWS: Mention new internal functions.
7142         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7143         (read_base_type): Use dwarf2_init_complex_target_type.
7144         * value.c (creal_internal_fn): New function.
7145         (cimag_internal_fn): New function.
7146         (_initialize_values): Register new internal functions.
7147
7148 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7149
7150         * infrun.c (stop_all_threads): If debug_infrun, always
7151         trace the wait status after wait_one, using
7152         target_waitstatus_to_string and target_pid_to_str.
7153         (handle_inferior_event): Replace various trace of
7154         wait status kind by a single trace.
7155         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7156         wait status kind image by target_waitstatus_to_string.
7157         * target/waitstatus.c (target_waitstatus_to_string): Fix
7158         obsolete comment.
7159
7160 2019-04-01  Tom Tromey  <tromey@adacore.com>
7161
7162         PR symtab/23331:
7163         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7164
7165 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7166             Pedro Alves  <palves@redhat.com>
7167
7168         * top.c (quit_force): Call 'finalize_values'.
7169         * value.c (finalize_values): New function.
7170         * value.h (finalize_values): Declare.
7171
7172 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7173
7174         * NEWS: Announce $_gdb_major and $_gdb_minor.
7175
7176         * top.c (init_gdb_version_vars): New function.
7177         (gdb_init): Call init_gdb_version_vars.
7178
7179 2019-03-29  Tom Tromey  <tromey@adacore.com>
7180
7181         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7182         help text.  Remove dead code.
7183
7184 2019-03-29  Keith Seitz  <keiths@redhat.com>
7185
7186         From Siddhesh Poyarekar:
7187         * f-lang.h (f77_get_upperbound): Return LONGEST.
7188         (f77_get_lowerbound): Likewise.
7189         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7190         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7191         print them.
7192         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7193         plongest to format print it.
7194         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7195         (f77_get_upperbound): Likewise.
7196         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7197         LOWER_BOUND to LONGEST.
7198         (f77_create_arrayprint_offset_tbl): Likewise.
7199
7200 2019-03-29  Keith Seitz  <keiths@redhat.com>
7201
7202         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7203         %s/pulongest for TYPE_LENGTH instead of %d in format
7204         strings.
7205         * ada-typerint.c (ada_print_type): Likewise.
7206         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7207         * compile/compile-c-support.c (generate_register_struct): Likewise.
7208         * gdbtypes.c (recursive_dump_type): Likewise.
7209         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7210         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7211         instead of %d in format strings.
7212         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7213         to std::min to ULONGEST.
7214         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7215         instead of %d in format strings.
7216         * tracepoint.c (info_scope_command): Likewise.
7217         * typeprint.c (print_offset_data::update)
7218         (print_offset_data::finish): Likewise.
7219         * xtensa-tdep.c (xtensa_store_return_value)
7220         (xtensa_push_dummy_call): Likewise.
7221
7222 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7223
7224         * windows-nat.c (display_selector): Fixed format specifications
7225         for 64-bit Cygwin.
7226
7227 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7228
7229         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7230
7231 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7232
7233         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7234         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7235         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7236         (nios2_linux_init_abi): Install it.
7237
7238 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7239
7240         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7241
7242 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7243
7244         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7245
7246 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7247             Tom Tromey  <tromey@adacore.com>
7248
7249         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7250
7251 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7252
7253         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7254         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7255         method to compute the bounds of range types. Also print "[evaluated]"
7256         if the bounds' values come from a dynamic evaluation.
7257
7258 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7259
7260         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7261         whitespace when pretty printing is on.
7262
7263 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7264
7265         * ppc-linux-nat.c: Add include.
7266
7267 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7268
7269         * NEWS: Mention AArch64 Pointer Authentication.
7270
7271 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7272
7273         * arm-linux-nat.c: Add include.
7274
7275 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7276
7277         * source-cache.c (source_cache::get_source_lines): Re-read
7278         fullname after calling open_source_file.
7279
7280 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7281
7282         * NEWS: Mention TLS support for FreeBSD.
7283
7284 2019-03-25  Tom Tromey  <tromey@adacore.com>
7285
7286         * minsyms.c (BUNCH_SIZE): Update comment.
7287         (~minimal_symbol_reader): Remove old comment.
7288         (compact_minimal_symbols): Update comment.
7289         (minimal_symbol_reader::install): Remove old comment.  Update
7290         other comments.
7291
7292 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7293
7294         * s390-linux-nat.c: Add include.
7295
7296 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7297
7298         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7299         Call linux_get_hwcap.
7300         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7301         Likewise.
7302         (aarch64_linux_get_hwcap): Remove function.
7303         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7304         declaration.
7305         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7306         linux_get_hwcap.
7307         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7308         * linux-tdep.c (linux_get_hwcap): Add function.
7309         (linux_get_hwcap2): Likewise.
7310         * linux-tdep.h (linux_get_hwcap): Add declaration.
7311         (linux_get_hwcap2): Likewise.
7312         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7313         (ppc_linux_get_hwcap2): Likewise.
7314         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7315         linux_get_hwcap.
7316         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7317         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7318         (ppc_linux_nat_target::read_description): Likewise.
7319         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7320         * s390-linux-nat.c: Likewise.
7321         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7322
7323 2019-03-24  Tom Tromey  <tom@tromey.com>
7324
7325         * ada-lang.c (standard_lookup): Simplify initialization.
7326         (ada_lookup_symbol_nonlocal): Simplify return.
7327         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7328         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7329         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7330         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7331         initialization.
7332         * solib.c (solib_global_lookup): Simplify.
7333         * symtab.c (null_block_symbol): Remove.
7334         (symbol_cache_lookup): Simplify returns.
7335         (lookup_language_this): Simplify returns.
7336         (lookup_symbol_aux): Simplify return.
7337         (lookup_local_symbol): Simplify returns.
7338         (lookup_global_symbol_from_objfile): Simplify return.
7339         (lookup_symbol_in_objfile_symtabs)
7340         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7341         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7342         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7343         * cp-namespace.c (cp_lookup_bare_symbol)
7344         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7345         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7346         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7347         (cp_lookup_symbol_via_imports): Simplify initialization.
7348         (find_symbol_in_baseclass): Likewise.
7349         * symtab.h (null_block_symbol): Remove.
7350         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7351         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7352         (d_lookup_symbol_module): Likewise.
7353         (find_symbol_in_baseclass): Simplify initialization.
7354
7355 2019-03-24  Tom Tromey  <tom@tromey.com>
7356
7357         * expression.h: Don't include symtab.h.
7358         (struct block): Forward declare.
7359
7360 2019-03-24  Tom Tromey  <tom@tromey.com>
7361
7362         * c-exp.y (typebase): Remove casts.
7363         * gdbtypes.c (lookup_unsigned_typename, )
7364         (lookup_signed_typename): Remove cast.
7365         * eval.c (parse_to_comma_and_eval): Remove cast.
7366         * parse.c (write_dollar_variable): Remove cast.
7367         * block.h (struct block) <superblock>: Now const.
7368         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7369         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7370         (map_block): Make "block" const.
7371         * symfile.h (struct quick_symbol_functions)
7372         <map_matching_symbols>: Constify block argument to "callback".
7373         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7374         const.
7375         (find_pc_sect_compunit_symtab): Make "b" const.
7376         (find_symbol_at_address): Likewise.
7377         (search_symbols): Likewise.
7378         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7379         (dw2_debug_names_lookup_symbol): Likewise.
7380         (dw2_map_matching_symbols): Update.
7381         * p-valprint.c (pascal_val_print): Remove "block".
7382         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7383         (aux_add_nonlocal_symbols): Make "block" const.
7384         (resolve_subexp): Remove cast.
7385         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7386         const.
7387         (iterate_over_file_blocks): Likewise.
7388         * f-exp.y (%union) <bval>: Remove.
7389         * coffread.c (patch_opaque_types): Make "b" const.
7390         * spu-tdep.c (spu_catch_start): Make "block" const.
7391         * c-valprint.c (print_unpacked_pointer): Remove "block".
7392         * symmisc.c (dump_symtab_1): Make "b" const.
7393         (block_depth): Make "block" const.
7394         * d-exp.y (%union) <bval>: Remove.
7395         * cp-support.h (cp_lookup_rtti_type): Update.
7396         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7397         * psymtab.c (psym_lookup_symbol): Make "block" const.
7398         (maintenance_check_psymtabs): Make "b" const.
7399         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7400         (enumerate_locals, enumerate_args): Update.
7401         * python/py-symtab.c (stpy_global_block): Make "block" const.
7402         (stpy_static_block): Likewise.
7403         * inline-frame.c (block_starting_point_at): Make "new_block"
7404         const.
7405         * block.c (find_block_in_blockvector): Make return type const.
7406         (blockvector_for_pc_sect): Make "b" const.
7407         (find_block_in_blockvector): Make "b" const.
7408
7409 2019-03-23  Tom Tromey  <tom@tromey.com>
7410
7411         * varobj.c (varobj_create): Update.
7412         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7413         * printcmd.c (display_command, do_one_display): Don't reset
7414         innermost_block.
7415         * parser-defs.h (enum innermost_block_tracker_type): Move to
7416         expression.h.
7417         (innermost_block): Update comment.
7418         * parse.c (parse_exp_1): Add tracker_types parameter.
7419         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7420         tracker_types parameter.  Reset innermost_block.
7421         (parse_exp_in_context): Remove.
7422         (parse_expression_for_completion): Update.
7423         * objfiles.c (~objfile): Don't reset expression_context_block or
7424         innermost_block.
7425         * expression.h (enum innermost_block_tracker_type): Move from
7426         parser-defs.h.
7427         (parse_exp_1): Add tracker_types parameter.
7428         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7429         reset innermost_block.
7430
7431 2019-03-23  Tom Tromey  <tom@tromey.com>
7432
7433         * objfiles.h: Include bcache.h.
7434
7435 2019-03-23  Tom Tromey  <tom@tromey.com>
7436
7437         * linespec.c (get_current_search_block): Use
7438         scoped_restore_current_language.
7439         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7440
7441 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7442             Jiong Wang  <jiong.wang@arm.com>
7443
7444         * aarch64-linux-tdep.c
7445         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7446         section.
7447         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7448
7449 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7450             Jiong Wang  <jiong.wang@arm.com>
7451
7452         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7453         instructions.
7454         (aarch64_analyze_prologue_test): Add PACIASP test.
7455         (aarch64_prologue_prev_register): Unmask PC value.
7456
7457 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7458             Jiong Wang  <jiong.wang@arm.com>
7459
7460         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7461         (aarch64_dwarf2_prev_register): Unmask PC value.
7462         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7463         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7464         DW_CFA_AARCH64_negate_ra_state.
7465         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7466
7467 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7468             Jiong Wang  <jiong.wang@arm.com>
7469
7470         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7471         registers.
7472         (aarch64_pseudo_register_name): Likewise.
7473         (aarch64_pseudo_register_type): Likewise.
7474         (aarch64_pseudo_register_reggroup_p): Likewise.
7475         (aarch64_gdbarch_init): Add pauth registers.
7476         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7477         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7478         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7479         (struct gdbarch_tdep): Add regnum for ra_state.
7480
7481 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7482             Jiong Wang  <jiong.wang@arm.com>
7483
7484         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7485
7486 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7487             Jiong Wang  <jiong.wang@arm.com>
7488
7489         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7490         function.
7491         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7492         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7493         (aarch64_gdbarch_init): Add puth registers.
7494         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7495         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7496         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7497
7498 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7499             Jiong Wang  <jiong.wang@arm.com>
7500
7501         * aarch64-linux-nat.c
7502         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7503         * aarch64-linux-tdep.c
7504         (aarch64_linux_core_read_description): Likewise.
7505         (aarch64_linux_get_hwcap): New function.
7506         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7507         (aarch64_linux_get_hwcap): New declaration.
7508
7509 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7510             Jiong Wang  <jiong.wang@arm.com>
7511
7512         * aarch64-linux-nat.c
7513         (aarch64_linux_nat_target::read_description): Add pauth param.
7514         * aarch64-linux-tdep.c
7515         (aarch64_linux_core_read_description): Likewise.
7516         * aarch64-tdep.c (struct target_desc): Add in pauth.
7517         (aarch64_read_description): Add pauth param.
7518         (aarch64_gdbarch_init): Likewise.
7519         * aarch64-tdep.h (aarch64_read_description): Likewise.
7520         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7521         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7522         * features/Makefile: Add new files.
7523         * features/aarch64-pauth.c: New file.
7524         * features/aarch64-pauth.xml: New file.
7525
7526 2019-03-20  Tom Tromey  <tromey@adacore.com>
7527
7528         * infrun.c (handle_inferior_event): Rename from
7529         handle_inferior_event_1.  Create a scoped_value_mark.
7530         (handle_inferior_event): Remove.
7531
7532 2019-03-19  Tom Tromey  <tromey@adacore.com>
7533
7534         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7535         * infrun.h (print_stop_event): Add "displays" parameter.
7536         * infrun.c (print_stop_event): Add "displays" parameter.
7537
7538 2019-03-19  Pedro Alves  <palves@redhat.com>
7539
7540         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7541         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7542         to -1.  Fix TABs vs spaces.
7543         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7544         * tui/tui-out.h (tui_ui_out) Add intro comments.
7545         <m_line, m_start_of_line>: In-class initialize, and add describing
7546         comment.
7547
7548 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7549
7550         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7551         variable names.
7552         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7553
7554 2019-03-18  Pedro Alves  <palves@redhat.com>
7555             Eli Zaretskii <eliz@gnu.org>
7556
7557         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7558         m_line and m_start_of_line.
7559
7560 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7561
7562         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7563         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7564         it returns a newline.  This fixes a regression in TU mode, whereby
7565         the next line is output on the same screen line as the user input.
7566
7567 2019-03-18  Tom Tromey  <tromey@adacore.com>
7568
7569         * minsyms.c (minimal_symbol_reader::install): Remove call to
7570         obstack_blank.
7571
7572 2019-03-18  Pedro Alves  <palves@redhat.com>
7573
7574         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7575         New globals.
7576         (apply_style): New, factored out from ...
7577         (apply_ansi_escape): ... this.  Handle reverse video mode.
7578         (tui_set_reverse_mode): New function.
7579         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7580         * tui/tui-winsource.c (tui_show_source_line): Use
7581         tui_set_reverse_mode instead of setting A_STANDOUT.
7582         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7583         New setter methods.
7584
7585 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7586
7587         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7588         Handle tabs.
7589
7590 2019-03-18  Tom Tromey  <tromey@adacore.com>
7591
7592         * ada-lang.c (empty_array): Add "high" parameter.
7593         (ada_evaluate_subexp): Update.
7594
7595 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7596
7597         * unittests/string_view-selftests.c: Define
7598         _initialize_string_view_selftests unconditionally.
7599
7600 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7601
7602         PR gdb/24350
7603         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7604
7605 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7606
7607         PR gdb/24351
7608         * windows-nat.c (display_selector): Fix format specifiers.
7609
7610 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7611
7612         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7613         tui_refill_source_window instead of tui_refresh_win, to update the
7614         current execution line.  This fixes redisplay of the current line
7615         when stepping through the code with "next" or "step".
7616
7617 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7618
7619         * source-cache.c (source_cache::get_source_lines): Call
7620         find_source_lines to initialize s->nlines.  This fixes vertical
7621         scrolling of TUI source window when the DOWN arrow is pressed.
7622
7623 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7624
7625         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7626         linux-thread-db.c (_initialize_thread_db): Likewise.
7627
7628 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7629
7630         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7631         wclrtoeol in tui_show_source_line".  This reverts changes made in
7632         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7633
7634 2019-03-15  Tom Tromey  <tom@tromey.com>
7635
7636         * symtab.h (struct minimal_symbol): Derive from
7637         general_symbol_info.
7638         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7639         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7640         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7641         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7642         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7643         (MSYMBOL_SEARCH_NAME): Update.
7644         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7645         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7646         * minsyms.c (minimal_symbol_reader::record_full): Update.
7647
7648 2019-03-15  Tom Tromey  <tom@tromey.com>
7649
7650         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7651
7652 2019-03-15  Tom Tromey  <tom@tromey.com>
7653
7654         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7655         unique_xmalloc_ptr.
7656         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7657         Update.
7658         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7659         (build_minimal_symbol_hash_tables)
7660         (minimal_symbol_reader::install): Update.
7661
7662 2019-03-15  Tom Tromey  <tom@tromey.com>
7663
7664         * symtab.c (create_demangled_names_hash): Update.
7665         (symbol_set_names): Update.
7666         * objfiles.h (struct objfile_per_bfd_storage)
7667         <demangled_names_hash>: Now an htab_up.
7668         * objfiles.c (objfile_per_bfd_storage): Simplify.
7669
7670 2019-03-15  Tom Tromey  <tom@tromey.com>
7671
7672         * objfiles.h (struct objfile_per_bfd_storage): Declare
7673         destructor.
7674         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7675         New.
7676         (get_objfile_bfd_data): Use new.  Don't initialize
7677         language_of_main.
7678         (free_objfile_per_bfd_storage): Remove.
7679         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7680
7681 2019-03-15  Tom Tromey  <tom@tromey.com>
7682
7683         * symfile.c (reread_symbols): Update.
7684         * objfiles.c (objfile::objfile): Update.
7685         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7686         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7687         comment.
7688         (minimal_symbol_reader::install): Update.
7689         (terminate_minimal_symbol_table): Remove.
7690         * jit.c (jit_object_close_impl): Update.
7691
7692 2019-03-15  Tom Tromey  <tom@tromey.com>
7693
7694         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7695         initializations.
7696
7697 2019-03-15  Tom Tromey  <tom@tromey.com>
7698
7699         * objfiles.h (struct objfile_per_bfd_storage)
7700         <demangled_hash_languages>: Now a bitset.
7701         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7702         (lookup_minimal_symbol): Update.
7703
7704 2019-03-15  Tom Tromey  <tom@tromey.com>
7705
7706         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7707         Don't return the symbol.
7708         * coffread.c (record_minimal_symbol): Use record_full.
7709
7710 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7711
7712         The MS-Windows port of ncurses fails to switch to a color pair if
7713         one or both of the colors are the implicit default colors.  This
7714         change records the default colors when TUI is initialized, and
7715         then specifies them explicitly when a color pair uses the default
7716         colors.  This allows color styling in TUI mode on MS-Windows.
7717
7718         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7719         ncurses_norm_attr.
7720         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7721         colors in ncurses_norm_attr.
7722         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7723         "none", replace it with the default color recorded in
7724         ncurses_norm_attr.
7725
7726 2019-03-14  Tom Tromey  <tromey@adacore.com>
7727
7728         * source-cache.h (class source_cache) <get_source_lines>: Return
7729         std::string.
7730         * source-cache.c (source_cache::extract_lines): Handle case where
7731         first_pos==npos.  Return std::string.
7732         (source_cache::get_source_lines): Update.
7733
7734 2019-03-14  Tom Tromey  <tromey@adacore.com>
7735
7736         * NEWS: Add item for "style sources" commands.
7737         * source-cache.c (source_cache::get_source_lines): Check
7738         source_styling.
7739         * cli/cli-style.c (source_styling): New global.
7740         (_initialize_cli_style): Add "style sources" commands.
7741         (show_style_sources): New function.
7742         * cli/cli-style.h (source_styling): Declare.
7743
7744 2019-03-14  Pedro Alves  <palves@redhat.com>
7745             Tom Tromey  <tromey@adacore.com>
7746
7747         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7748         * tui/tui-winsource.c (tui_refill_source_window): New function,
7749         from...
7750         (tui_horizontal_source_scroll): ... here.  Move some logic.
7751         * cli/cli-style.c (set_style_enabled): Notify new observable.
7752         * tui/tui-hooks.c (tui_redisplay_source): New function.
7753         (tui_attach_detach_observers): Attach or detach
7754         tui_redisplay_source.
7755         * observable.h (source_styling_changed): New observable.
7756         * observable.c: Define source_styling_changed observable.
7757
7758 2019-03-13  Tom Tromey  <tromey@adacore.com>
7759
7760         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7761         (i386_gnu_nat_target::store_registers): Update.
7762         * target-debug.h (target_debug_print_std_string): New macro.
7763         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7764         * windows-tdep.c (display_one_tib): Update.
7765         * tui/tui-stack.c (tui_make_status_line): Update.
7766         * top.c (print_inferior_quit_action): Update.
7767         * thread.c (thr_try_catch_cmd): Update.
7768         (add_thread_with_info): Update.
7769         (thread_target_id_str): Update.
7770         (thr_try_catch_cmd): Update.
7771         (thread_command): Update.
7772         (thread_find_command): Update.
7773         * record-btrace.c (record_btrace_target::info_record)
7774         (record_btrace_resume_thread, record_btrace_target::resume)
7775         (record_btrace_cancel_resume, record_btrace_step_thread)
7776         (record_btrace_target::wait, record_btrace_target::wait)
7777         (record_btrace_target::wait, record_btrace_target::stop): Update.
7778         * progspace.c (print_program_space): Update.
7779         * process-stratum-target.c
7780         (process_stratum_target::thread_address_space): Update.
7781         * linux-fork.c (linux_fork_mourn_inferior)
7782         (detach_checkpoint_command, info_checkpoints_command)
7783         (linux_fork_context): Update.
7784         (linux_fork_detach): Update.
7785         (class scoped_switch_fork_info): Update.
7786         (delete_checkpoint_command): Update.
7787         * infrun.c (follow_fork_inferior): Update.
7788         (follow_fork_inferior): Update.
7789         (proceed_after_vfork_done): Update.
7790         (handle_vfork_child_exec_or_exit): Update.
7791         (follow_exec): Update.
7792         (displaced_step_prepare_throw): Update.
7793         (displaced_step_restore): Update.
7794         (start_step_over): Update.
7795         (resume_1): Update.
7796         (clear_proceed_status_thread): Update.
7797         (proceed): Update.
7798         (print_target_wait_results): Update.
7799         (do_target_wait): Update.
7800         (context_switch): Update.
7801         (stop_all_threads): Update.
7802         (restart_threads): Update.
7803         (finish_step_over): Update.
7804         (handle_signal_stop): Update.
7805         (switch_back_to_stepped_thread): Update.
7806         (keep_going_pass_signal): Update.
7807         (print_exited_reason): Update.
7808         (normal_stop): Update.
7809         * inferior.c (inferior_pid_to_str): Change return type.
7810         (print_selected_inferior): Update.
7811         (add_inferior): Update.
7812         (detach_inferior): Update.
7813         * dummy-frame.c (fprint_dummy_frames): Update.
7814         * dcache.c (dcache_info_1): Update.
7815         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7816         (btrace_fetch, btrace_clear): Update.
7817         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7818         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7819         type.
7820         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7821         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7822         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7823         * gdbarch.c, gdbarch.h: Rebuild.
7824         * gdbarch.sh (core_pid_to_str): Change return type.
7825         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7826         return type.
7827         (windows_nat_target::pid_to_str): Change return type.
7828         (windows_delete_thread): Update.
7829         (windows_nat_target::attach): Update.
7830         (windows_nat_target::files_info): Update.
7831         * target-delegates.c: Rebuild.
7832         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7833         return type.
7834         (sol_thread_target::pid_to_str): Change return type.
7835         * remote.c (class remote_target) <pid_to_str>: Change return
7836         type.
7837         (remote_target::pid_to_str): Change return type.
7838         (extended_remote_target::attach, remote_target::remote_stop_ns)
7839         (remote_target::remote_notif_remove_queued_reply)
7840         (remote_target::push_stop_reply, remote_target::disable_btrace):
7841         Update.
7842         (extended_remote_target::attach): Update.
7843         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7844         type.
7845         (gdbsim_target::pid_to_str): Change return type.
7846         * ravenscar-thread.c (struct ravenscar_thread_target)
7847         <pid_to_str>: Change return type.
7848         (ravenscar_thread_target::pid_to_str): Change return type.
7849         * procfs.c (class procfs_target) <pid_to_str>: Change return
7850         type.
7851         (procfs_target::pid_to_str): Change return type.
7852         (procfs_target::attach): Update.
7853         (procfs_target::detach): Update.
7854         (procfs_target::fetch_registers): Update.
7855         (procfs_target::store_registers): Update.
7856         (procfs_target::wait): Update.
7857         (procfs_target::files_info): Update.
7858         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7859         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7860         return type.
7861         (nto_procfs_target::pid_to_str): Change return type.
7862         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7863         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7864         return type.
7865         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7866         (exit_lwp): Update.
7867         (attach_proc_task_lwp_callback, get_detach_signal)
7868         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7869         (linux_nat_target::resume, wait_lwp, stop_callback)
7870         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7871         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7872         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7873         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7874         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7875         type.
7876         (inf_ptrace_target::attach): Update.
7877         (inf_ptrace_target::files_info): Update.
7878         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7879         type.
7880         (go32_nat_target::pid_to_str): Change return type.
7881         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7882         (gnu_nat_target::wait): Update.
7883         (gnu_nat_target::wait): Update.
7884         (gnu_nat_target::resume): Update.
7885         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7886         (fbsd_nat_target::wait): Update.
7887         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7888         type.
7889         (darwin_nat_target::attach): Update.
7890         * corelow.c (class core_target) <pid_to_str>: Change return type.
7891         (core_target::pid_to_str): Change return type.
7892         * target.c (normal_pid_to_str): Change return type.
7893         (default_pid_to_str): Likewise.
7894         (target_pid_to_str): Change return type.
7895         (target_translate_tls_address): Update.
7896         (target_announce_detach): Update.
7897         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7898         return type.
7899         (bsd_uthread_target::pid_to_str): Change return type.
7900         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7901         type.
7902         (bsd_kvm_target::pid_to_str): Change return type.
7903         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7904         return type.
7905         (aix_thread_target::pid_to_str): Change return type.
7906         * target.h (struct target_ops) <pid_to_str>: Change return type.
7907         (target_pid_to_str, normal_pid_to_str): Likewise.
7908         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7909         type.
7910         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7911         type.
7912         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7913         return type.
7914         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7915         type.
7916         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7917         type.
7918         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7919         return type.
7920
7921 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7922
7923         * NEWS: Mention that the new default MI version is 3.  Mention
7924         changes to the output of commands and events that deal with
7925         multi-location breakpoints.
7926         * breakpoint.c: Include "mi/mi-out.h".
7927         (print_one_breakpoint): Change output syntax if using MI version
7928         >= 3.
7929         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7930         New.
7931         (mi_multi_location_breakpoint_output_fixed): New.
7932         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7933         (mi_cmd_fix_multi_location_breakpoint_output): New.
7934         (mi_multi_location_breakpoint_output_fixed): New.
7935         * mi/mi-cmds.c (mi_cmds): Register command
7936         -fix-multi-location-breakpoint-output.
7937         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7938         interpreter "mi".
7939
7940 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7941
7942         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7943         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7944         instantiate mi_ui_out based on interpreter name.
7945         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7946         * mi/mi-main.c (mi_load_progress): Likewise.
7947
7948 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7949
7950         * NEWS: Combine separate "New targets" sections for 8.3.
7951
7952 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7953
7954         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7955         (ppcfbsd_init_abi): Install gdbarch
7956         "fetch_tls_load_module_address" and "get_thread_local_address"
7957         methods.
7958
7959 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7960
7961         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7962         (riscv_fbsd_init_abi): Install gdbarch
7963         "fetch_tls_load_module_address" and "get_thread_local_address"
7964         methods.
7965
7966 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7967
7968         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7969         (i386fbsd_init_abi): Install gdbarch
7970         "fetch_tls_load_module_address" and "get_thread_local_address"
7971         methods.
7972
7973 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7974
7975         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7976         (amd64fbsd_init_abi): Install gdbarch
7977         "fetch_tls_load_module_address" and "get_thread_local_address"
7978         methods.
7979
7980 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7981
7982         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7983         (struct fbsd_pspace_data): New type.
7984         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7985         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7986         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7987         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7988         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7989
7990 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7991
7992         * gdbtypes.c (lookup_struct_elt): New function.
7993         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7994         * gdbtypes.h (struct struct_elt): New type.
7995         (lookup_struct_elt): New prototype.
7996
7997 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7998
7999         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8000         remove disabled code block.
8001
8002 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8003
8004         * gdbarch.sh (get_thread_local_address): New method.
8005         * gdbarch.h, gdbarch.c: Regenerate.
8006         * target.c (target_translate_tls_address): Use
8007         gdbarch_get_thread_local_address if present instead of
8008         target::get_thread_local_address.
8009
8010 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8011
8012         * target.h (target::get_thread_local_address): Update comment.
8013
8014 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8015
8016         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8017         objfile->separate_debug_objfile_backlink if not NULL.
8018
8019 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8020
8021         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8022         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8023         (amd64bsd_store_inferior_registers): Likewise.
8024         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8025         Enable segment base registers.
8026         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8027         PT_GETFSBASE and PT_GETGSBASE.
8028         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8029         PT_SETGSBASE.
8030         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8031         segment base registers.
8032         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8033
8034 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8035
8036         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8037         Update calls to i386_target_description to add 'segments'
8038         parameter.
8039         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8040         add segment base registers.
8041         * arch/i386.c (i386_create_target_description): Add 'segments'
8042         parameter to enable segment base registers.
8043         * arch/i386.h (i386_create_target_description): Likewise.
8044         * features/i386/32bit-segments.xml: New file.
8045         * features/i386/32bit-segments.c: Generate.
8046         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8047         call to i386_target_description to add 'segments' parameter.
8048         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8049         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8050         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8051         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8052         if feature is present.
8053         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8054         Add 'segments' parameter to call to i386_target_description.
8055         (i386_target_description): Add 'segments' parameter to enable
8056         segment base registers.
8057         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8058         to call to i386_target_description.
8059         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8060         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8061         Define I386_NUM_REGS.
8062         (i386_target_description): Add 'segments' parameter to enable
8063         segment base registers.
8064
8065 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8066
8067         PR/24325
8068         * source-cache.c: #undef open and close, to avoid unresolved
8069         externals during linking.
8070
8071 2019-03-12  Tom Tromey  <tromey@adacore.com>
8072
8073         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8074         const.  Add initializers.
8075         (_initialize_remote): Don't initialize ptid globals.
8076
8077 2019-03-12  Pedro Alves  <palves@redhat.com>
8078
8079         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8080
8081 2019-03-12  Pedro Alves  <palves@redhat.com>
8082
8083         * cp-name-parser.y (main): Remove unused 'len' variable.
8084
8085 2019-03-12  Tom Tromey  <tromey@adacore.com>
8086
8087         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8088         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8089
8090 2019-03-12  Tom Tromey  <tromey@adacore.com>
8091
8092         * linux-nat.c (iterate_over_lwps): Update.
8093         (stop_callback): Remove parameter.
8094         (stop_wait_callback, detach_callback, resume_set_callback)
8095         (select_singlestep_lwp_callback, set_ignore_sigint)
8096         (status_callback, resumed_callback, resume_clear_callback)
8097         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8098         data parameter.
8099         (linux_nat_target::detach, linux_nat_target::resume)
8100         (linux_stop_and_wait_all_lwps, select_event_lwp)
8101         (linux_nat_filter_event, linux_nat_wait_1)
8102         (linux_nat_target::kill, linux_nat_target::stop)
8103         (linux_nat_target::stop): Update.
8104         (linux_nat_resume_callback): Change type.
8105         (resume_stopped_resumed_lwps, count_events_callback)
8106         (select_event_lwp_callback): Likewise.
8107         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8108         * arm-linux-nat.c (struct update_registers_data): Remove.
8109         (update_registers_callback): Change type.
8110         (arm_linux_insert_hw_breakpoint1): Update.
8111         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8112         parameter.
8113         (x86_linux_dr_set_addr): Update.
8114         (x86_linux_dr_set_control): Update.
8115         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8116         (iterate_over_lwps): Use gdb::function_view.
8117         * nat/aarch64-linux-hw-point.c (struct
8118         aarch64_dr_update_callback_param): Remove.
8119         (debug_reg_change_callback): Change type.
8120         (aarch64_notify_debug_reg_change): Update.
8121         * s390-linux-nat.c (s390_refresh_per_info): Update.
8122
8123 2019-03-11  Tom Tromey  <tromey@adacore.com>
8124
8125         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8126         redundant assignment to "this_cu".
8127
8128 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8129
8130         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8131
8132 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8133
8134         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8135         from...
8136         (rank_one_type): ... this.
8137
8138 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8139
8140         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8141         from...
8142         (rank_one_type): ... this.
8143
8144 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8145
8146         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8147         from...
8148         (rank_one_type): ... this.
8149
8150 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8151
8152         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8153         from...
8154         (rank_one_type): ... this.
8155
8156 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8157
8158         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8159         from...
8160         (rank_one_type): ... this.
8161
8162 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8163
8164         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8165         from...
8166         (rank_one_type): ... this.
8167
8168 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8169
8170         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8171         from...
8172         (rank_one_type): ... this.
8173
8174 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8175
8176         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8177         from...
8178         (rank_one_type): ... this.
8179
8180 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8181
8182         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8183         from...
8184         (rank_one_type): ... this.
8185
8186 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8187
8188         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8189         from...
8190         (rank_one_type): ... this.
8191
8192 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8193
8194         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8195         from...
8196         (rank_one_type): ... this.
8197
8198 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8199
8200         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8201         from...
8202         (rank_one_type): ... this.
8203
8204 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8205
8206         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8207         inferior-events' shows the example events.
8208
8209 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8210
8211         Support styling on native MS-Windows console
8212
8213         PR/24315
8214         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8215         on MS-Windows if $TERM is not defined.
8216
8217         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8218
8219         * posix-hdep.c (gdb_console_fputs):
8220         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8221         functions.
8222         * ui-file.h (gdb_console_fputs): Add prototype.
8223
8224         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8225         back to fputs only if the former returns zero.
8226
8227 2019-03-07  Tom Tromey  <tom@tromey.com>
8228
8229         * symmisc.c (print_symbol_bcache_statistics): Update.
8230         (print_objfile_statistics): Update.
8231         * symfile.c (allocate_symtab): Update.
8232         * stabsread.c: Don't include bcache.h.
8233         * psymtab.h (struct psymbol_bcache): Don't declare.
8234         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8235         (psymbol_bcache_init, psymbol_bcache_free)
8236         (psymbol_bcache_get_bcache): Don't declare.
8237         * psymtab.c (struct psymbol_bcache): Remove.
8238         (psymtab_storage::psymtab_storage): Update.
8239         (psymtab_storage::~psymtab_storage): Update.
8240         (psymbol_bcache_init, psymbol_bcache_free)
8241         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8242         (add_psymbol_to_bcache): Update.
8243         (allocate_psymtab): Update.
8244         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8245         macro_cache>: No longer pointers.
8246         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8247         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8248         * macrotab.c (macro_bcache): Update.
8249         * macroexp.c: Don't include bcache.h.
8250         * gdbtypes.c (check_types_worklist): Update.
8251         (types_deeply_equal): Remove TRY/CATCH.  Update.
8252         * elfread.c (elf_symtab_read): Update.
8253         * dwarf2read.c: Don't include bcache.h.
8254         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8255         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8256         (print_bcache_statistics, bcache_memory_used): Don't declare.
8257         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8258         methods.  Rename all data members.
8259         * bcache.c (struct bcache): Move to bcache.h.
8260         (bcache::expand_hash_table): Rename from expand_hash_table.
8261         (bcache): Remove.
8262         (bcache::insert): Rename from bcache_full.
8263         (bcache::compare): Rename from bcache_compare.
8264         (bcache_xmalloc): Remove.
8265         (bcache::~bcache): Rename from bcache_xfree.
8266         (bcache::print_statistics): Rename from print_bcache_statistics.
8267         (bcache::memory_used): Rename from bcache_memory_used.
8268
8269 2019-03-07  Pedro Alves  <palves@redhat.com>
8270
8271         * infrun.c (normal_stop): Also check for
8272         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8273
8274 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8275
8276         * f-lang.c (value_from_host_double): Moved to...
8277         * value.c (value_from_host_double): ...here.
8278         * value.h (value_from_host_double): Declare.
8279         * guile/scm-math.c (vlscm_convert_typed_number): Use
8280         value_from_host_double.
8281         (vlscm_convert_number): Likewise.
8282         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8283         * python/py-value.c (convert_value_from_python): Likewise.
8284
8285 2019-03-06  Tom Tromey  <tom@tromey.com>
8286
8287         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8288
8289 2019-03-06  Tom Tromey  <tom@tromey.com>
8290
8291         * utils.h (free_current_contents): Don't declare.
8292         * utils.c (free_current_contents): Remove.
8293
8294 2019-03-06  Tom Tromey  <tom@tromey.com>
8295
8296         * top.c (quit_force): Update.
8297         * main.c (captured_command_loop): Update.
8298         * common/new-op.c (operator new): Update.
8299         * common/common-exceptions.c (struct catcher)
8300         <save_cleanup_chain>: Remove member.
8301         (exceptions_state_mc_init): Update.
8302         (exception_try_scope_entry): Return nullptr.
8303         (exception_try_scope_exit, exception_rethrow)
8304         (throw_exception_sjlj, throw_exception_cxx): Update.
8305         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8306         (all_cleanups, do_cleanups, discard_cleanups)
8307         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8308         (restore_cleanups, restore_final_cleanups): Don't declare.
8309         (do_final_cleanups): Remove parameter.
8310         * common/cleanups.c (cleanup_chain, make_cleanup)
8311         (make_cleanup_dtor, all_cleanups, do_cleanups)
8312         (discard_my_cleanups, discard_cleanups)
8313         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8314         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8315         (null_cleanup): Remove.
8316         (do_final_cleanups): Remove parameter.
8317
8318 2019-03-06  Tom Tromey  <tom@tromey.com>
8319
8320         * remote.c (remote_target::remote_parse_stop_reply): Use
8321         unique_xmalloc_ptr.
8322
8323 2019-03-06  Tom Tromey  <tom@tromey.com>
8324
8325         * stabsread.c (struct stabs_field_info): Rename from field_info.
8326         <list, fnlist>: Add initializers.
8327         <obstack>: New member.
8328         (read_member_functions, read_struct_fields, read_baseclasses):
8329         Allocate on obstack.  Don't use cleanups.
8330         (read_one_struct_field, read_member_functions, read_struct_fields)
8331         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8332         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8333         (read_struct_type): Update.
8334
8335 2019-03-06  Tom Tromey  <tom@tromey.com>
8336
8337         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8338         * common/filestuff.h (make_cleanup_close): Don't declare.
8339         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8340         Remove.
8341
8342 2019-03-06  Tom Tromey  <tom@tromey.com>
8343
8344         * solib-aix.c: Use make_scope_exit.
8345
8346 2019-03-06  Tom Tromey  <tom@tromey.com>
8347
8348         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8349         Use make_scope_exit.
8350
8351 2019-03-06  Tom Tromey  <tom@tromey.com>
8352
8353         * solib-svr4.c (disable_probes_interface): Remove parameter.
8354         (svr4_handle_solib_event): Use make_scope_exit.
8355
8356 2019-03-06  Tom Tromey  <tom@tromey.com>
8357
8358         * remote.c (struct stop_reply_deleter): Remove.
8359         (stop_reply_up): Update.
8360         (struct stop_reply): Derive from notif_event.  Don't typedef.
8361         <regcache>: Now a std::vector.
8362         (stop_reply_xfree): Remove.
8363         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8364         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8365         (remote_target::discard_pending_stop_replies): Use delete.
8366         (remote_target::remote_parse_stop_reply): Update.
8367         (remote_target::process_stop_reply): Update.
8368         * remote-notif.h (struct notif_event): Add virtual destructor.
8369         Remove "dtr" member.
8370         (struct notif_client) <alloc_event>: Return a unique_ptr.
8371         (notif_event_xfree): Don't declare.
8372         (notif_event_up): New typedef.
8373         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8374         (notif_event_xfree, do_notif_event_xfree): Remove.
8375         (remote_notif_state_xfree): Update.
8376
8377 2019-03-06  Tom Tromey  <tom@tromey.com>
8378
8379         * infrun.c (displaced_step_clear_cleanup): Now a
8380         forward_scope_exit type.
8381         (displaced_step_prepare_throw): Update.
8382         (displaced_step_fixup): Update.
8383
8384 2019-03-06  Tom Tromey  <tom@tromey.com>
8385
8386         * inferior.h (class inferior): Update comment.
8387         * gdbthread.h (class thread_info): Update comment.
8388
8389 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8390             Tom Tromey  <tom@tromey.com>
8391
8392         * stabsread.h (struct stab_section_list): Remove.
8393         (coffstab_build_psymtabs): Update.
8394         * dbxread.c (symbuf_sections): Now a std::vector.
8395         (sect_idx): New global.
8396         (fill_symbuf): Update.
8397         (coffstab_build_psymtabs): Change type of stabsects parameter.
8398         Update.
8399         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8400         std::vector.
8401         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8402         (coff_locate_sections): Update.
8403         (coff_symfile_read): Remove cleanups.  Update.
8404         (init_stringtab): Add storage parameter.
8405         (free_stringtab, free_stringtab_cleanup): Remove.
8406         (init_lineno): Add storage parameter.
8407         (free_linetab, free_linetab_cleanup): Remove.
8408
8409 2019-03-06  Pedro Alves  <palves@redhat.com>
8410
8411         * linux-fork.c (fork_info::clobber_regs): Delete.
8412         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8413         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8414         comment.  Adjust.
8415         (scoped_switch_fork_info::scoped_switch_fork_info)
8416         (checkpoint_command, linux_fork_context): Adjust
8417         fork_save_infrun_state calls.
8418
8419 2019-03-06  Pedro Alves  <palves@redhat.com>
8420
8421         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8422         (inf_has_multiple_threads): Return 'bool' and rewrite using
8423         inferior_info::threads().
8424
8425 2019-03-06  Pedro Alves  <palves@redhat.com>
8426
8427         * linux-fork.c: Include <list>.
8428         (fork_list): Now a std::list instance.
8429         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8430         (forks_exist_p, find_last_fork): Adjust.
8431         (new_fork): Delete.
8432         (one_fork_p): New.
8433         (add_fork): Adjust.
8434         (free_fork): Delete, folded into fork_info::~fork_info().
8435         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8436         Adjust.
8437         (init_fork_list): Delete.
8438         (linux_fork_killall, linux_fork_mourn_inferior)
8439         (linux_fork_detach, info_checkpoints_command): Adjust.
8440         (_initialize_linux_fork): No longer call init_fork_list.
8441
8442 2019-03-06  Pedro Alves  <palves@redhat.com>
8443
8444         * linux-fork.c (new_fork): New, split out of ...
8445         (add_fork): ... this.  Return void.  Move "first fork" special
8446         case from here, to ...
8447         (checkpoint_command): ... here.
8448         * linux-linux.h (add_fork): Return void.
8449
8450 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8451
8452         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8453
8454 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8455             Chris January  <chris.january@arm.com>
8456             David Lecomber  <david.lecomber@arm.com>
8457
8458         * f-exp.y: New token, UNOP_INTRINSIC.
8459         (exp): New pattern using UNOP_INTRINSIC token.
8460         (f77_keywords): Add 'abs' keyword.
8461         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8462         (value_from_host_double): New function.
8463         (evaluate_subexp_f): Support UNOP_ABS.
8464
8465 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8466
8467         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8468         types.
8469
8470 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8471
8472         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8473         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8474         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8475
8476 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8477
8478         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8479
8480 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8481             Chris January  <chris.january@arm.com>
8482
8483         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8484         * f-exp.y: Define 'KIND' token.
8485         (exp): New pattern for KIND expressions.
8486         (ptype): Handle types with a kind extension.
8487         (direct_abs_decl): Extend to spot kind extensions.
8488         (f77_keywords): Add 'kind' to the list.
8489         (push_kind_type): New function.
8490         (convert_to_kind_type): New function.
8491         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8492         * parse.c (operator_length_standard): Likewise.
8493         * parser-defs.h (enum type_pieces): Add tp_kind.
8494         * std-operator.def: Add UNOP_KIND.
8495
8496 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8497
8498         * f-exp.y (f_parse): Set yydebug.
8499
8500 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8501
8502         * f-lang.c (evaluate_subexp_f): New function.
8503         (exp_descriptor_f): New global.
8504         (f_language_defn): Use exp_descriptor_f instead of
8505         exp_descriptor_standard.
8506
8507 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8508
8509         * f-exp.y (struct token): Add comments.
8510         (dot_ops): Remove uppercase versions and the end marker.
8511         (f77_keywords): Likewise.
8512         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8513         entries in the dot_ops array are case insensitive, and use
8514         strncasecmp to compare strings.  Also some whitespace cleanup in
8515         this area.  Similar for the f77_keywords array, except entries in
8516         this list might be case sensitive.
8517
8518 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8519
8520         * f-exp.y (struct f77_boolean_val): Add comments.
8521         (boolean_values): Remove uppercase versions, and end marker.
8522         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8523         and use strncasecmp to achieve case insensitivity.  Additionally,
8524         perform whitespace cleanup around this code.
8525
8526 2019-03-06  Tom Tromey  <tromey@adacore.com>
8527
8528         * remote-sim.c (gdbsim_target_open): Use result of
8529         gdb_argv::release.
8530
8531 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8532         Dirk Schubert  <dirk.schubert@arm.com>
8533         Chris January  <chris.january@arm.com>
8534
8535         * eval.c (evaluate_subexp_standard): Call Fortran argument
8536         wrapping logic.
8537         * f-lang.c (struct value): A value which can be passed into a
8538         Fortran function call.
8539         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8540         where appropriate.
8541         (struct type): Value ready for a Fortran function call.
8542         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8543         is needed.
8544         * f-lang.h (fortran_argument_convert): Declaration.
8545         (fortran_preserve_arg_pointer): Declaration.
8546         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8547
8548 2019-03-05  Tom Tromey  <tromey@adacore.com>
8549
8550         * python/py-prettyprint.c (print_string_repr): Remove #if.
8551         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8552
8553 2019-03-05  Tom Tromey  <tromey@adacore.com>
8554
8555         * target.c (the_dummy_target): Move later.  Change type to
8556         "dummy_target".
8557         (initialize_targets): Don't initialize the_dummy_target.
8558
8559 2019-03-05  Tom Tromey  <tromey@adacore.com>
8560
8561         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8562         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8563
8564 2019-03-05  Tom Tromey  <tromey@adacore.com>
8565
8566         * windows-nat.c (windows_nat_target::attach)
8567         (windows_nat_target::detach): Don't call gdb_flush.
8568         * valprint.c (generic_val_print, val_print, val_print_string):
8569         Don't call gdb_flush.
8570         * utils.c (defaulted_query): Don't call gdb_flush.
8571         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8572         * target.c (target_announce_detach): Don't call gdb_flush.
8573         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8574         * remote.c (extended_remote_target::attach): Don't call
8575         gdb_flush.
8576         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8577         * printcmd.c (do_examine): Don't call gdb_flush.
8578         (info_display_command): Don't call gdb_flush.
8579         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8580         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8581         * memattr.c (info_mem_command): Don't call gdb_flush.
8582         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8583         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8584         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8585         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8586         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8587         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8588         (gnu_nat_target::detach): Don't call gdb_flush.
8589         * f-valprint.c (f_val_print): Don't call gdb_flush.
8590         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8591         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8592         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8593         gdb_flush.
8594         * c-valprint.c (c_val_print): Don't call gdb_flush.
8595         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8596
8597 2019-03-05  Tom Tromey  <tromey@adacore.com>
8598
8599         * varobj.c (update_dynamic_varobj_children): Update.
8600         (install_default_visualizer): Use reset, not release.
8601         * value.c (set_internalvar): Update.
8602         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8603         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8604         ATTRIBUTE_UNUSED_RESULT.
8605
8606 2019-03-05  Tom Tromey  <tromey@adacore.com>
8607
8608         * remote.c (class scoped_remote_fd) <release>: Add
8609         ATTRIBUTE_UNUSED_RESULT.
8610
8611 2019-03-05  Tom Tromey  <tromey@adacore.com>
8612
8613         * macroexp.c (struct macro_buffer) <release>: Add
8614         ATTRIBUTE_UNUSED_RESULT.
8615
8616 2019-03-05  Tom Tromey  <tromey@adacore.com>
8617
8618         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8619         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8620         ATTRIBUTE_UNUSED_RESULT.
8621
8622 2019-03-05  Tom Tromey  <tromey@adacore.com>
8623
8624         * common/scoped_fd.h (class scoped_fd) <release>: Add
8625         ATTRIBUTE_UNUSED_RESULT.
8626
8627 2019-03-05  Tom Tromey  <tromey@adacore.com>
8628
8629         * parser-defs.h (struct parser_state) <release>: Add
8630         ATTRIBUTE_UNUSED_RESULT.
8631
8632 2019-03-05  Tom Tromey  <tromey@adacore.com>
8633
8634         * utils.h (class gdb_argv) <release>: Add
8635         ATTRIBUTE_UNUSED_RESULT.
8636         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8637
8638 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8639
8640         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8641         for-loop range, to avoid compiler warnings.
8642
8643         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8644         avoid compiler warnings about unused variables.
8645
8646         * NEWS: Mention end of support for native debugging on MS-Windows
8647         before XP.
8648
8649         PR gdb/24292
8650         * common/netstuff.c:
8651         * gdbserver/gdbreplay.c
8652         * gdbserver/remote-utils.c:
8653         * ser-tcp.c:
8654         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8655         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8656         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8657         'getaddrinfo' and 'freeaddrinfo' were not available before
8658         Windows XP, and mingw.org's MinGW headers by default define
8659         _WIN32_WINNT to 0x500.
8660
8661 2019-03-01  Gary Benson <gbenson@redhat.com>
8662
8663         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8664
8665 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8666             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8667
8668         PR gdb/8527
8669         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8670         set_sigint_trap, clear_sigint_trap.
8671
8672 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8673
8674         * target.c (target_detach): Clear the regcache and the
8675         frame cache.
8676
8677 2019-02-27  Pedro Alves  <palves@redhat.com>
8678
8679         * utils.c (set_screen_size): When we cap the height/width sizes,
8680         tweak the corresponding command variable to show "unlimited":
8681
8682 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8683             Pedro Alves  <palves@redhat.com>
8684
8685         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8686         before calling rl_set_screen_size.
8687
8688 2019-02-27  Tom Tromey  <tromey@adacore.com>
8689
8690         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8691         define.
8692         * python/py-value.c: Remove Python 2.4 workaround.
8693         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8694         workaround.
8695         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8696         Python 2.4 workaround.
8697         * python/python-internal.h: Remove Python 2.4 comment.
8698         (Py_ssize_t): Don't define.
8699         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8700         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8701         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8702         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8703         * python/python.c (do_start_initialization): Remove Python 2.4
8704         workaround.
8705         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8706         (print_children): Remove Python 2.4 workaround.
8707         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8708         workaround.
8709         (CHARBUFFERPROC_NAME): Remove.
8710         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8711         Python 2.4 workaround.
8712
8713 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8714
8715         * NEWS: Note minimum Python version.
8716
8717 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8718
8719         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8720         code from these functions.  Remove corresponding ifdefs.  Use
8721         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8722         Remove gotos and target of gotos.
8723         (infpy_search_memory): Likewise.
8724
8725 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8726
8727         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8728         (hppa_gdbarch_init): Don't register deleted functions with
8729         gdbarch.
8730
8731 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8732
8733         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8734         (h8300_unwind_sp): Delete.
8735         (h8300_dummy_id): Delete.
8736         (h8300_gdbarch_init): Don't register deleted functions with
8737         gdbarch.
8738
8739 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8740
8741         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8742         (ft32_unwind_pc): Delete.
8743         (ft32_unwind_sp): Delete.
8744         (ft32_gdbarch_init): Don't register deleted functions with
8745         gdbarch.
8746
8747 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8748
8749         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8750         (frv_unwind_pc): Delete.
8751         (frv_unwind_sp): Delete.
8752         (frv_gdbarch_init): Don't register deleted functions with
8753         gdbarch.
8754
8755 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8756
8757         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8758         (riscv_unwind_pc): Delete.
8759         (riscv_unwind_sp): Delete.
8760         (riscv_gdbarch_init): Don't register deleted functions with
8761         gdbarch.
8762
8763 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8764
8765         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8766         (csky_unwind_pc): Delete.
8767         (csky_unwind_sp): Delete.
8768         (csky_gdbarch_init): Don't register deleted functions with
8769         gdbarch.
8770
8771 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8772
8773         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8774         (cris_unwind_pc): Delete.
8775         (cris_unwind_sp): Delete.
8776         (cris_gdbarch_init): Don't register deleted functions with
8777         gdbarch.
8778
8779 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8780
8781         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8782         (bfin_unwind_pc): Delete.
8783         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8784
8785 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8786
8787         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8788         (arm_unwind_pc): Delete.
8789         (arm_unwind_sp): Delete.
8790         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8791
8792 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8793
8794         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8795         (arc_unwind_pc): Delete.
8796         (arc_unwind_sp): Delete.
8797         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8798
8799 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8800
8801         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8802         (alpha_unwind_pc): Delete.
8803         (alpha_gdbarch_init): Don't register deleted functions with
8804         gdbarch.
8805
8806 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8807
8808         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8809         (aarch64_unwind_pc): Delete.
8810         (aarch64_unwind_sp): Delete.
8811         (aarch64_gdbarch_init): Don't register deleted functions with
8812         gdbarch.
8813
8814 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8815
8816         * gdbtypes.c (type_align): Don't consider static members when
8817         computing structure alignment.
8818
8819 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8820
8821         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8822         return 0 for other types.
8823         * arch-utils.c (default_type_align): Always return 0.
8824         * gdbarch.h: Regenerate.
8825         * gdbarch.sh (type_align): Extend comment.
8826         * gdbtypes.c (type_align): Add additional comments, always call
8827         gdbarch_type_align before applying the default rules.
8828         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8829         generic code will then apply a suitable default.
8830         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8831         types, return 0 for other types.
8832
8833 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8834
8835         * NEWS: Create a new section for the next release branch.
8836         Rename the section of the current branch, now that it has
8837         been cut.
8838
8839 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8840
8841         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8842         * version.in: Bump version to 8.3.50.DATE-git.
8843
8844 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8845
8846         * aix-thread.c (ptid_cmp): Remove unused variable.
8847         (get_signaled_thread): Likewise.
8848         (store_regs_user_thread): Likewise.
8849         (store_regs_kernel_thread): Likewise.
8850         (fetch_regs_kernel_thread): Remove shadowed variable.
8851
8852 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8853
8854         * features/riscv/32bit-cpu.xml: Add register numbers.
8855         * features/riscv/32bit-fpu.c: Regenerate.
8856         * features/riscv/32bit-fpu.xml: Add register numbers.
8857         * features/riscv/64bit-cpu.xml: Add register numbers.
8858         * features/riscv/64bit-fpu.c: Regenerate.
8859         * features/riscv/64bit-fpu.xml: Add register numbers.
8860
8861 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8862
8863         * NEWS: Mention two argument form of gdb.Value constructor.
8864         * python/py-value.c (convert_buffer_and_type_to_value): New
8865         function.
8866         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8867         Add support for handling an optional second argument.  Call
8868         convert_buffer_and_type_to_value as appropriate.
8869         * python/python-internal.h (Py_buffer_deleter): New struct.
8870         (Py_buffer_up): New typedef.
8871
8872 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8873
8874         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8875         instead of releasing ownership.
8876
8877 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8878
8879         * dwarf2read.c (open_and_init_dwp_file): Call
8880         elf_numsections instead of bfd_count_sections to initialize
8881         dwp_file->num_sections.
8882
8883 2019-02-25  Tom Tromey  <tromey@adacore.com>
8884
8885         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8886
8887 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8888
8889         * gcore.in: Add '--readnever' option when invoking GDB.
8890
8891 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8892
8893         * MAINTAINERS: Update my email address.
8894
8895 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8896
8897         * build-id.c (build_id_to_debug_bfd_1): New function.
8898         (build_id_to_debug_bfd): Look for separate debug file in
8899         sysroot.
8900
8901 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8902
8903         * gdbarch.sh: Update the copyright year range that is placed into
8904         generated files.
8905
8906 2019-02-22  Keith Seitz  <keiths@redhat.com>
8907
8908         PR symtab/23853
8909         * linespec.c (create_sals_line_offset): Search for the default
8910         symtab's filename instead of its fullname.
8911
8912 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8913
8914         * NEWS: Update style defaults.
8915
8916 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8917
8918         * main.c (captured_main_1): Disable styling in batch mode.
8919
8920 2019-02-20  Tom Tromey  <tom@tromey.com>
8921
8922         * symtab.c (symtab_symbol_info): Fix typos.
8923
8924 2019-02-20  Tom Tromey  <tromey@adacore.com>
8925
8926         * findcmd.c (_initialize_mem_search): Use upper case for
8927         metasyntactic variables.
8928
8929 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8930
8931         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8932         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8933
8934 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8935
8936         * top.h (source_file_name): Change to std::string.
8937         * top.c (source_file_name): Likewise.
8938         (command_line_input): Adjust.
8939         * cli/cli-script.c (script_from_file): Adjust.
8940
8941 2019-02-19  Tom Tromey  <tromey@adacore.com>
8942
8943         * ravenscar-thread.c
8944         (ravenscar_thread_target::update_thread_list): Don't call
8945         ada_build_task_list.
8946         * ada-lang.h (ada_build_task_list): Don't declare.
8947         * ada-tasks.c (struct ada_tasks_inferior_data)
8948         <task_list_valid_p>: Now bool.
8949         (read_known_tasks, ada_task_list_changed)
8950         (ada_tasks_invalidate_inferior_data): Update.
8951         (read_known_tasks_array): Return bool.
8952         (read_known_tasks_list): Likewise.
8953         (read_known_tasks): Return void.
8954         (ada_build_task_list): Now static.
8955
8956 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8957
8958         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8959         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8960
8961 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8962
8963         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8964         variant for ada_tasks_pspace_data_handle and
8965         ada_tasks_inferior_data_handle.
8966         (ada_tasks_pspace_data_cleanup): New function.
8967         (ada_tasks_inferior_data_cleanup): New function.
8968
8969 2019-02-17  Tom Tromey  <tom@tromey.com>
8970
8971         * macrotab.h (macro_source_fullname): Return a std::string.
8972         * macrotab.c (macro_include, check_for_redefinition)
8973         (macro_undef, macro_lookup_definition, foreach_macro)
8974         (foreach_macro_in_scope): Update.
8975         (macro_source_fullname): Return a std::string.
8976         * macrocmd.c (show_pp_source_pos): Update.
8977
8978 2019-02-17  Tom Tromey  <tom@tromey.com>
8979
8980         * macrocmd.c (show_pp_source_pos): Style the file names.
8981
8982 2019-02-17  Tom Tromey  <tom@tromey.com>
8983
8984         PR tui/24197:
8985         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8986
8987 2019-02-17  Tom Tromey  <tom@tromey.com>
8988
8989         * ada-lang.c (user_select_syms): Use filtered printing.
8990         * utils.c (wrap_style): New global.
8991         (desired_style): Remove.
8992         (emit_style_escape): Add stream parameter.
8993         (set_output_style, reset_terminal_style, prompt_for_continue):
8994         Update.
8995         (flush_wrap_buffer): Only flush gdb_stdout.
8996         (wrap_here): Set wrap_style.
8997         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8998         treat escape sequences as a character.  Change when wrap buffer is
8999         flushed.
9000         (fputs_styled): Do not set the output style when the default is
9001         requested.
9002         * ui-style.h (struct ui_file_style) <is_default>: New method.
9003         * source.c (print_source_lines_base): Emit escape sequences in one
9004         piece.
9005
9006 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9007
9008         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9009         integers and enumeration types.
9010
9011 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9012
9013         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9014         instead of lookup_symbol_in_language
9015         (do_exact_match): New function.
9016         (ada_get_symbol_name_matcher): Return do_exact_match when
9017         doing a verbatim match.
9018
9019 2019-02-15  Tom Tromey  <tromey@adacore.com>
9020
9021         * ravenscar-thread.c (ravenscar_thread_target::resume)
9022         (ravenscar_thread_target::wait): Special case wildcard requests.
9023
9024 2019-02-15  Tom Tromey  <tromey@adacore.com>
9025
9026         * ravenscar-thread.c (base_ptid): Remove.
9027         (struct ravenscar_thread_target) <close>: New method.
9028         <m_base_ptid>: New member.
9029         <update_inferior_ptid, active_task, task_is_currently_active,
9030         runtime_initialized>: Declare methods.
9031         <ravenscar_thread_target>: Add constructor.
9032         (ravenscar_thread_target::task_is_currently_active)
9033         (ravenscar_thread_target::update_inferior_ptid)
9034         (ravenscar_runtime_initialized): Rename.  Now methods.
9035         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9036         (ravenscar_thread_target::update_thread_list): Update.
9037         (ravenscar_thread_target::active_task): Now method.
9038         (ravenscar_thread_target::store_registers)
9039         (ravenscar_thread_target::prepare_to_store)
9040         (ravenscar_thread_target::prepare_to_store)
9041         (ravenscar_thread_target::mourn_inferior): Update.
9042         (ravenscar_inferior_created): Use "new" to create target.
9043         (ravenscar_thread_target::get_ada_task_ptid): Update.
9044         (_initialize_ravenscar): Don't initialize base_ptid.
9045         (ravenscar_ops): Remove global.
9046
9047 2019-02-15  Tom Tromey  <tromey@adacore.com>
9048
9049         * target.h (push_target): Declare new overload.
9050         * target.c (push_target): New overload, taking an rvalue reference.
9051         * remote.c (remote_target::open_1): Use push_target overload.
9052         * corelow.c (core_target_open): Use push_target overload.
9053
9054 2019-02-15  Tom Tromey  <tromey@adacore.com>
9055
9056         * ravenscar-thread.c (is_ravenscar_task)
9057         (ravenscar_task_is_currently_active): Return bool.
9058         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9059         (_initialize_ravenscar): Remove "(void)".
9060         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9061         Return bool.
9062
9063 2019-02-15  Tom Tromey  <tromey@adacore.com>
9064
9065         * ravenscar-thread.c (ravenscar_runtime_initializer)
9066         (has_ravenscar_runtime, get_running_thread_id)
9067         (ravenscar_thread_target::resume): Fix indentation.
9068
9069 2019-02-15  Tom Tromey  <tromey@adacore.com>
9070
9071         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9072         from ravenscar_arch_ops.
9073         (sparc_ravenscar_ops::fetch_registers)
9074         (sparc_ravenscar_ops::store_registers): Now methods.
9075         (sparc_ravenscar_prepare_to_store): Remove.
9076         (sparc_ravenscar_ops): Redefine.
9077         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9078         methods and destructor.  Remove members.
9079         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9080         (ravenscar_thread_target::store_registers)
9081         (ravenscar_thread_target::prepare_to_store): Update.
9082         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9083         Remove.
9084         (struct ppc_ravenscar_powerpc_ops): Derive from
9085         ravenscar_arch_ops.
9086         (ppc_ravenscar_powerpc_ops::fetch_registers)
9087         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9088         (ppc_ravenscar_powerpc_ops): Redefine.
9089         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9090         (ppc_ravenscar_e500_ops::fetch_registers)
9091         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9092         (ppc_ravenscar_e500_ops): Redefine.
9093         * aarch64-ravenscar-thread.c
9094         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9095         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9096         (aarch64_ravenscar_fetch_registers)
9097         (aarch64_ravenscar_store_registers): Now methods.
9098         (aarch64_ravenscar_ops): Redefine.
9099
9100 2019-02-15  Tom Tromey  <tromey@adacore.com>
9101
9102         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9103         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9104         (ravenscar_thread_target::stopped_by_watchpoint)
9105         (ravenscar_thread_target::stopped_data_address)
9106         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9107
9108 2019-02-15  Tom Tromey  <tromey@adacore.com>
9109
9110         * ravenscar-thread.c: Fix some typos.
9111
9112 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9113             Tom Tromey  <tromey@adacore.com>
9114
9115         * ada-lang.c (ada_exception_sal): Change addr_string to a
9116         std::string.
9117         (create_ada_exception_catchpoint): Update.
9118
9119 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9120             Tom Tromey  <tromey@adacore.com>
9121
9122         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9123         (bp_location_ops): Remove.
9124         (base_breakpoint_allocate_location): Update.
9125         (free_bp_location): Update.
9126         * ada-lang.c (class ada_catchpoint_location)
9127         <ada_catchpoint_location>: Remove ops parameter.
9128         (ada_catchpoint_location_dtor): Remove.
9129         (ada_catchpoint_location_ops): Remove.
9130         (allocate_location_exception): Update.
9131         * breakpoint.h (struct bp_location_ops): Remove.
9132         (class bp_location) <bp_location>: Remove bp_location_ops
9133         parameter.
9134         <~bp_location>: Add destructor.
9135         <ops>: Remove.
9136
9137 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9138             Pedro Alves  <palves@redhat.com>
9139
9140         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9141         'PATH_MAX'.
9142
9143 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9144             Samuel Thibault  <samuel.thibault@gnu.org>
9145             Thomas Schwinge  <thomas@codesourcery.com>
9146
9147         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9148         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9149
9150 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9151
9152         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9153         (check_empty): Use "const char *".
9154
9155         * gnu-nat.c (gnu_nat_target::detach): Instead of
9156         'detach_inferior (pid)' call
9157         'detach_inferior (find_inferior_pid (pid))'.
9158
9159         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9160         'nat/fork-inferior.o'.
9161         * gnu-nat.c: #include "nat/fork-inferior.h".
9162
9163         * gnu-nat.c (gnu_nat_target::detach): Instead of
9164         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9165         * gnu-nat.h: #include "inf-child.h".
9166         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9167         'i386_gnu_nat_target::fetch_registers'.
9168         (gnu_store_registers): Rename/move to
9169         'i386_gnu_nat_target::store_registers'.
9170
9171         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9172         * gnu-nat.h (mach_thread_info): New function.
9173         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9174
9175         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9176
9177 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9178
9179         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9180
9181 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9182
9183         * windows-nat.c (windows_add_thread): Add new parameter
9184         "main_thread_p" with default value set to false.  Update
9185         function documentation as well as all callers.
9186         (windows_delete_thread): Likewise.
9187         (fake_create_process): Update call to windows_add_thread.
9188         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9189         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9190         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9191         call to windows_delete_thread.
9192
9193 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9194
9195         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9196
9197 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9198
9199         * symfile.c (find_separate_debug_file): Use canonical path of
9200         sysroot with child_path instead of gdb_sysroot if it is valid.
9201
9202 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9203
9204         * symfile.c (find_separate_debug_file): Use child_path to
9205         determine if an object file is under a sysroot.
9206
9207 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9208
9209         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9210         unittests/child-path-selftests.c.
9211         * common/pathstuff.c (child_path): New function.
9212         * common/pathstuff.h (child_path): New prototype.
9213         * unittests/child-path-selftests.c: New file.
9214
9215 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9216
9217         * symfile.c (find_separate_debug_file): Look for separate debug
9218         files in debug directories under the sysroot.
9219
9220 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9221
9222         * symtab.h (struct minimal_symbol data_p): New const method.
9223         (struct minimal_symbol text_p): Likewise.
9224         * symtab.c (output_source_filename): Use file name style
9225         to print file name.
9226         (print_symbol_info): Likewise.
9227         (print_msymbol_info): Use address style to print addresses.
9228         Use function name style to print executable text symbols.
9229         (expand_symtab_containing_pc): Use data_p.
9230         (find_pc_sect_compunit_symtab): Likewise.
9231
9232 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9233
9234         * breakpoint.c (describe_other_breakpoints): Use address style
9235         to print addresses.
9236         (say_where): Likewise.
9237
9238 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9239
9240         * ada-typeprint.c (print_func_type): Print function name
9241         style to print function name.
9242         * c-typeprint.c (c_print_type_1): Likewise.
9243
9244 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9245
9246         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9247         for execve.
9248
9249 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9250
9251         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9252         type_stack.
9253
9254 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9255
9256         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9257         TYPE_CODE_REF types.
9258
9259 2019-02-08  Jim Wilson  <jimw@sifive.com>
9260
9261         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9262         (riscv_linux_fregset): New.
9263         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9264
9265 2019-02-07  Tom Tromey  <tom@tromey.com>
9266
9267         * thread.c (thread_cancel_execution_command): Update.
9268         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9269         methods.
9270         (struct thread_fsm_ops): Remove.
9271         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9272         (thread_fsm_should_stop, thread_fsm_return_value)
9273         (thread_fsm_set_finished, thread_fsm_finished_p)
9274         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9275         Don't declare.
9276         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9277         * infrun.c (clear_proceed_status_thread)
9278         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9279         (print_stop_event): Update.
9280         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9281         Add constructor.
9282         (step_command_fsm_ops): Remove.
9283         (new_step_command_fsm): Remove.
9284         (step_1): Update.
9285         (step_command_fsm::should_stop): Rename from
9286         step_command_fsm_should_stop.
9287         (step_command_fsm::clean_up): Rename from
9288         step_command_fsm_clean_up.
9289         (step_command_fsm::do_async_reply_reason): Rename from
9290         step_command_fsm_async_reply_reason.
9291         (struct until_next_fsm): Inherit from thread_fsm.  Add
9292         constructor.
9293         (until_next_fsm_ops): Remove.
9294         (new_until_next_fsm): Remove.
9295         (until_next_fsm::should_stop): Rename from
9296         until_next_fsm_should_stop.
9297         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9298         (until_next_fsm::do_async_reply_reason): Rename from
9299         until_next_fsm_async_reply_reason.
9300         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9301         constructor.  Change type of breakpoint.
9302         (finish_command_fsm_ops): Remove.
9303         (new_finish_command_fsm): Remove.
9304         (finish_command_fsm::should_stop): Rename from
9305         finish_command_fsm_should_stop.
9306         (finish_command_fsm::clean_up): Rename from
9307         finish_command_fsm_clean_up.
9308         (finish_command_fsm::return_value): Rename from
9309         finish_command_fsm_return_value.
9310         (finish_command_fsm::do_async_reply_reason): Rename from
9311         finish_command_fsm_async_reply_reason.
9312         (finish_command): Update.
9313         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9314         Add constructor.
9315         (call_thread_fsm_ops): Remove.
9316         (call_thread_fsm::call_thread_fsm): Rename from
9317         new_call_thread_fsm.
9318         (call_thread_fsm::should_stop): Rename from
9319         call_thread_fsm_should_stop.
9320         (call_thread_fsm::should_notify_stop): Rename from
9321         call_thread_fsm_should_notify_stop.
9322         (run_inferior_call, call_function_by_hand_dummy): Update.
9323         * cli/cli-interp.c (should_print_stop_to_console): Update.
9324         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9325         Add constructor.  Change type of location_breakpoint,
9326         caller_breakpoint.
9327         (until_break_fsm_ops): Remove.
9328         (new_until_break_fsm): Remove.
9329         (until_break_fsm::should_stop): Rename from
9330         until_break_fsm_should_stop.
9331         (until_break_fsm::clean_up): Rename from
9332         until_break_fsm_clean_up.
9333         (until_break_fsm::do_async_reply_reason): Rename from
9334         until_break_fsm_async_reply_reason.
9335         (until_break_command): Update.
9336         * thread-fsm.c: Remove.
9337         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9338
9339 2019-02-07  Tom Tromey  <tom@tromey.com>
9340
9341         * yy-remap.h: Add include guard.
9342         * xtensa-tdep.h: Add include guard.
9343         * xcoffread.h: Rename include guard.
9344         * varobj-iter.h: Add include guard.
9345         * tui/tui.h: Rename include guard.
9346         * tui/tui-winsource.h: Rename include guard.
9347         * tui/tui-wingeneral.h: Rename include guard.
9348         * tui/tui-windata.h: Rename include guard.
9349         * tui/tui-win.h: Rename include guard.
9350         * tui/tui-stack.h: Rename include guard.
9351         * tui/tui-source.h: Rename include guard.
9352         * tui/tui-regs.h: Rename include guard.
9353         * tui/tui-out.h: Rename include guard.
9354         * tui/tui-layout.h: Rename include guard.
9355         * tui/tui-io.h: Rename include guard.
9356         * tui/tui-hooks.h: Rename include guard.
9357         * tui/tui-file.h: Rename include guard.
9358         * tui/tui-disasm.h: Rename include guard.
9359         * tui/tui-data.h: Rename include guard.
9360         * tui/tui-command.h: Rename include guard.
9361         * tic6x-tdep.h: Add include guard.
9362         * target/waitstatus.h: Rename include guard.
9363         * target/wait.h: Rename include guard.
9364         * target/target.h: Rename include guard.
9365         * target/resume.h: Rename include guard.
9366         * target-float.h: Rename include guard.
9367         * stabsread.h: Add include guard.
9368         * rs6000-tdep.h: Add include guard.
9369         * riscv-fbsd-tdep.h: Add include guard.
9370         * regformats/regdef.h: Rename include guard.
9371         * record.h: Rename include guard.
9372         * python/python.h: Rename include guard.
9373         * python/python-internal.h: Rename include guard.
9374         * python/py-stopevent.h: Rename include guard.
9375         * python/py-ref.h: Rename include guard.
9376         * python/py-record.h: Rename include guard.
9377         * python/py-record-full.h: Rename include guard.
9378         * python/py-record-btrace.h: Rename include guard.
9379         * python/py-instruction.h: Rename include guard.
9380         * python/py-events.h: Rename include guard.
9381         * python/py-event.h: Rename include guard.
9382         * procfs.h: Add include guard.
9383         * proc-utils.h: Add include guard.
9384         * p-lang.h: Add include guard.
9385         * or1k-tdep.h: Rename include guard.
9386         * observable.h: Rename include guard.
9387         * nto-tdep.h: Rename include guard.
9388         * nat/x86-linux.h: Rename include guard.
9389         * nat/x86-linux-dregs.h: Rename include guard.
9390         * nat/x86-gcc-cpuid.h: Add include guard.
9391         * nat/x86-dregs.h: Rename include guard.
9392         * nat/x86-cpuid.h: Rename include guard.
9393         * nat/ppc-linux.h: Rename include guard.
9394         * nat/mips-linux-watch.h: Rename include guard.
9395         * nat/linux-waitpid.h: Rename include guard.
9396         * nat/linux-ptrace.h: Rename include guard.
9397         * nat/linux-procfs.h: Rename include guard.
9398         * nat/linux-osdata.h: Rename include guard.
9399         * nat/linux-nat.h: Rename include guard.
9400         * nat/linux-namespaces.h: Rename include guard.
9401         * nat/linux-btrace.h: Rename include guard.
9402         * nat/glibc_thread_db.h: Rename include guard.
9403         * nat/gdb_thread_db.h: Rename include guard.
9404         * nat/gdb_ptrace.h: Rename include guard.
9405         * nat/fork-inferior.h: Rename include guard.
9406         * nat/amd64-linux-siginfo.h: Rename include guard.
9407         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9408         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9409         * nat/aarch64-linux.h: Rename include guard.
9410         * nat/aarch64-linux-hw-point.h: Rename include guard.
9411         * mn10300-tdep.h: Add include guard.
9412         * mips-linux-tdep.h: Add include guard.
9413         * mi/mi-parse.h: Rename include guard.
9414         * mi/mi-out.h: Rename include guard.
9415         * mi/mi-main.h: Rename include guard.
9416         * mi/mi-interp.h: Rename include guard.
9417         * mi/mi-getopt.h: Rename include guard.
9418         * mi/mi-console.h: Rename include guard.
9419         * mi/mi-common.h: Rename include guard.
9420         * mi/mi-cmds.h: Rename include guard.
9421         * mi/mi-cmd-break.h: Rename include guard.
9422         * m2-lang.h: Add include guard.
9423         * location.h: Rename include guard.
9424         * linux-record.h: Rename include guard.
9425         * linux-nat.h: Add include guard.
9426         * linux-fork.h: Add include guard.
9427         * i386-darwin-tdep.h: Rename include guard.
9428         * hppa-linux-offsets.h: Add include guard.
9429         * guile/guile.h: Rename include guard.
9430         * guile/guile-internal.h: Rename include guard.
9431         * gnu-nat.h: Rename include guard.
9432         * gdb-stabs.h: Rename include guard.
9433         * frv-tdep.h: Add include guard.
9434         * f-lang.h: Add include guard.
9435         * event-loop.h: Add include guard.
9436         * darwin-nat.h: Rename include guard.
9437         * cp-abi.h: Rename include guard.
9438         * config/sparc/nm-sol2.h: Rename include guard.
9439         * config/nm-nto.h: Rename include guard.
9440         * config/nm-linux.h: Add include guard.
9441         * config/i386/nm-i386gnu.h: Rename include guard.
9442         * config/djgpp/nl_types.h: Rename include guard.
9443         * config/djgpp/langinfo.h: Rename include guard.
9444         * compile/gcc-cp-plugin.h: Add include guard.
9445         * compile/gcc-c-plugin.h: Add include guard.
9446         * compile/compile.h: Rename include guard.
9447         * compile/compile-object-run.h: Rename include guard.
9448         * compile/compile-object-load.h: Rename include guard.
9449         * compile/compile-internal.h: Rename include guard.
9450         * compile/compile-cplus.h: Rename include guard.
9451         * compile/compile-c.h: Rename include guard.
9452         * common/xml-utils.h: Rename include guard.
9453         * common/x86-xstate.h: Rename include guard.
9454         * common/version.h: Rename include guard.
9455         * common/vec.h: Rename include guard.
9456         * common/tdesc.h: Rename include guard.
9457         * common/selftest.h: Rename include guard.
9458         * common/scoped_restore.h: Rename include guard.
9459         * common/scoped_mmap.h: Rename include guard.
9460         * common/scoped_fd.h: Rename include guard.
9461         * common/safe-iterator.h: Rename include guard.
9462         * common/run-time-clock.h: Rename include guard.
9463         * common/refcounted-object.h: Rename include guard.
9464         * common/queue.h: Rename include guard.
9465         * common/ptid.h: Rename include guard.
9466         * common/print-utils.h: Rename include guard.
9467         * common/preprocessor.h: Rename include guard.
9468         * common/pathstuff.h: Rename include guard.
9469         * common/observable.h: Rename include guard.
9470         * common/netstuff.h: Rename include guard.
9471         * common/job-control.h: Rename include guard.
9472         * common/host-defs.h: Rename include guard.
9473         * common/gdb_wait.h: Rename include guard.
9474         * common/gdb_vecs.h: Rename include guard.
9475         * common/gdb_unlinker.h: Rename include guard.
9476         * common/gdb_unique_ptr.h: Rename include guard.
9477         * common/gdb_tilde_expand.h: Rename include guard.
9478         * common/gdb_sys_time.h: Rename include guard.
9479         * common/gdb_string_view.h: Rename include guard.
9480         * common/gdb_splay_tree.h: Rename include guard.
9481         * common/gdb_setjmp.h: Rename include guard.
9482         * common/gdb_ref_ptr.h: Rename include guard.
9483         * common/gdb_optional.h: Rename include guard.
9484         * common/gdb_locale.h: Rename include guard.
9485         * common/gdb_assert.h: Rename include guard.
9486         * common/filtered-iterator.h: Rename include guard.
9487         * common/filestuff.h: Rename include guard.
9488         * common/fileio.h: Rename include guard.
9489         * common/environ.h: Rename include guard.
9490         * common/common-utils.h: Rename include guard.
9491         * common/common-types.h: Rename include guard.
9492         * common/common-regcache.h: Rename include guard.
9493         * common/common-inferior.h: Rename include guard.
9494         * common/common-gdbthread.h: Rename include guard.
9495         * common/common-exceptions.h: Rename include guard.
9496         * common/common-defs.h: Rename include guard.
9497         * common/common-debug.h: Rename include guard.
9498         * common/cleanups.h: Rename include guard.
9499         * common/buffer.h: Rename include guard.
9500         * common/btrace-common.h: Rename include guard.
9501         * common/break-common.h: Rename include guard.
9502         * cli/cli-utils.h: Rename include guard.
9503         * cli/cli-style.h: Rename include guard.
9504         * cli/cli-setshow.h: Rename include guard.
9505         * cli/cli-script.h: Rename include guard.
9506         * cli/cli-interp.h: Rename include guard.
9507         * cli/cli-decode.h: Rename include guard.
9508         * cli/cli-cmds.h: Rename include guard.
9509         * charset-list.h: Add include guard.
9510         * buildsym-legacy.h: Rename include guard.
9511         * bfin-tdep.h: Add include guard.
9512         * ax.h: Rename include guard.
9513         * arm-linux-tdep.h: Add include guard.
9514         * arm-fbsd-tdep.h: Add include guard.
9515         * arch/xtensa.h: Rename include guard.
9516         * arch/tic6x.h: Add include guard.
9517         * arch/i386.h: Add include guard.
9518         * arch/arm.h: Rename include guard.
9519         * arch/arm-linux.h: Rename include guard.
9520         * arch/arm-get-next-pcs.h: Rename include guard.
9521         * arch/amd64.h: Add include guard.
9522         * arch/aarch64-insn.h: Rename include guard.
9523         * arch-utils.h: Rename include guard.
9524         * annotate.h: Add include guard.
9525         * amd64-darwin-tdep.h: Rename include guard.
9526         * aarch64-linux-tdep.h: Add include guard.
9527         * aarch64-fbsd-tdep.h: Add include guard.
9528         * aarch32-linux-nat.h: Add include guard.
9529
9530 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9531
9532         * macrotab.c (macro_define_internal): New function that
9533         factorizes macro_define_object_internal and macro_define_function
9534         code.
9535         (macro_define_object_internal): Use macro_define_internal.
9536         (macro_define_function): Likewise.
9537
9538 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9539
9540         * macrocmd.c (extract_identifier): Return
9541         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9542         callers.
9543
9544 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9545
9546         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9547
9548 2019-02-05  Tom Tromey  <tom@tromey.com>
9549
9550         * target.c (target_stack::unpush): Move assertion earlier.
9551
9552 2019-01-30  Tom Tromey  <tom@tromey.com>
9553
9554         PR python/23615:
9555         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9556         (gdbpy_parse_and_eval): Likewise.
9557         * python/python-internal.h (gdbpy_allow_threads): New class.
9558
9559 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9560
9561         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9562         (aarch64_fbsd_fpregmap): Move earlier.
9563         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9564         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9565         instead of individual calls to trad_frame_set_reg_addr.
9566         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9567         earlier.
9568         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9569         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9570         instead of individual calls to trad_frame_set_reg_addr.
9571
9572 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9573
9574         * CONTRIBUTE: Replace contribution list with wiki link.
9575
9576 2019-01-25  Tom Tromey  <tom@tromey.com>
9577
9578         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9579
9580 2019-01-25  Tom Tromey  <tom@tromey.com>
9581
9582         * xtensa-linux-nat.c: Fix common/ includes.
9583         * xml-support.h: Fix common/ includes.
9584         * xml-support.c: Fix common/ includes.
9585         * x86-linux-nat.c: Fix common/ includes.
9586         * windows-nat.c: Fix common/ includes.
9587         * varobj.h: Fix common/ includes.
9588         * varobj.c: Fix common/ includes.
9589         * value.c: Fix common/ includes.
9590         * valops.c: Fix common/ includes.
9591         * utils.c: Fix common/ includes.
9592         * unittests/xml-utils-selftests.c: Fix common/ includes.
9593         * unittests/utils-selftests.c: Fix common/ includes.
9594         * unittests/unpack-selftests.c: Fix common/ includes.
9595         * unittests/tracepoint-selftests.c: Fix common/ includes.
9596         * unittests/style-selftests.c: Fix common/ includes.
9597         * unittests/string_view-selftests.c: Fix common/ includes.
9598         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9599         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9600         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9601         * unittests/rsp-low-selftests.c: Fix common/ includes.
9602         * unittests/parse-connection-spec-selftests.c: Fix common/
9603         includes.
9604         * unittests/optional-selftests.c: Fix common/ includes.
9605         * unittests/offset-type-selftests.c: Fix common/ includes.
9606         * unittests/observable-selftests.c: Fix common/ includes.
9607         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9608         * unittests/memrange-selftests.c: Fix common/ includes.
9609         * unittests/memory-map-selftests.c: Fix common/ includes.
9610         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9611         * unittests/function-view-selftests.c: Fix common/ includes.
9612         * unittests/environ-selftests.c: Fix common/ includes.
9613         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9614         * unittests/common-utils-selftests.c: Fix common/ includes.
9615         * unittests/cli-utils-selftests.c: Fix common/ includes.
9616         * unittests/array-view-selftests.c: Fix common/ includes.
9617         * ui-file.c: Fix common/ includes.
9618         * tui/tui-io.c: Fix common/ includes.
9619         * tracepoint.h: Fix common/ includes.
9620         * tracepoint.c: Fix common/ includes.
9621         * tracefile-tfile.c: Fix common/ includes.
9622         * top.h: Fix common/ includes.
9623         * top.c: Fix common/ includes.
9624         * thread.c: Fix common/ includes.
9625         * target/waitstatus.h: Fix common/ includes.
9626         * target/waitstatus.c: Fix common/ includes.
9627         * target.h: Fix common/ includes.
9628         * target.c: Fix common/ includes.
9629         * target-memory.c: Fix common/ includes.
9630         * target-descriptions.c: Fix common/ includes.
9631         * symtab.h: Fix common/ includes.
9632         * symfile.c: Fix common/ includes.
9633         * stap-probe.c: Fix common/ includes.
9634         * spu-linux-nat.c: Fix common/ includes.
9635         * sparc-nat.c: Fix common/ includes.
9636         * source.c: Fix common/ includes.
9637         * solib.c: Fix common/ includes.
9638         * solib-target.c: Fix common/ includes.
9639         * ser-unix.c: Fix common/ includes.
9640         * ser-tcp.c: Fix common/ includes.
9641         * ser-pipe.c: Fix common/ includes.
9642         * ser-base.c: Fix common/ includes.
9643         * selftest-arch.c: Fix common/ includes.
9644         * s12z-tdep.c: Fix common/ includes.
9645         * rust-exp.y: Fix common/ includes.
9646         * rs6000-aix-tdep.c: Fix common/ includes.
9647         * riscv-tdep.c: Fix common/ includes.
9648         * remote.c: Fix common/ includes.
9649         * remote-notif.h: Fix common/ includes.
9650         * remote-fileio.h: Fix common/ includes.
9651         * remote-fileio.c: Fix common/ includes.
9652         * regcache.h: Fix common/ includes.
9653         * regcache.c: Fix common/ includes.
9654         * record-btrace.c: Fix common/ includes.
9655         * python/python.c: Fix common/ includes.
9656         * python/py-type.c: Fix common/ includes.
9657         * python/py-inferior.c: Fix common/ includes.
9658         * progspace.h: Fix common/ includes.
9659         * producer.c: Fix common/ includes.
9660         * procfs.c: Fix common/ includes.
9661         * proc-api.c: Fix common/ includes.
9662         * printcmd.c: Fix common/ includes.
9663         * ppc-linux-nat.c: Fix common/ includes.
9664         * parser-defs.h: Fix common/ includes.
9665         * osdata.c: Fix common/ includes.
9666         * obsd-nat.c: Fix common/ includes.
9667         * nat/x86-linux.c: Fix common/ includes.
9668         * nat/x86-linux-dregs.c: Fix common/ includes.
9669         * nat/x86-dregs.h: Fix common/ includes.
9670         * nat/x86-dregs.c: Fix common/ includes.
9671         * nat/ppc-linux.c: Fix common/ includes.
9672         * nat/mips-linux-watch.h: Fix common/ includes.
9673         * nat/mips-linux-watch.c: Fix common/ includes.
9674         * nat/linux-waitpid.c: Fix common/ includes.
9675         * nat/linux-ptrace.h: Fix common/ includes.
9676         * nat/linux-ptrace.c: Fix common/ includes.
9677         * nat/linux-procfs.c: Fix common/ includes.
9678         * nat/linux-personality.c: Fix common/ includes.
9679         * nat/linux-osdata.c: Fix common/ includes.
9680         * nat/linux-namespaces.c: Fix common/ includes.
9681         * nat/linux-btrace.h: Fix common/ includes.
9682         * nat/linux-btrace.c: Fix common/ includes.
9683         * nat/fork-inferior.c: Fix common/ includes.
9684         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9685         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9686         * nat/aarch64-linux.c: Fix common/ includes.
9687         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9688         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9689         * namespace.h: Fix common/ includes.
9690         * mips-linux-tdep.c: Fix common/ includes.
9691         * minsyms.c: Fix common/ includes.
9692         * mi/mi-parse.h: Fix common/ includes.
9693         * mi/mi-main.c: Fix common/ includes.
9694         * mi/mi-cmd-env.c: Fix common/ includes.
9695         * memrange.h: Fix common/ includes.
9696         * memattr.c: Fix common/ includes.
9697         * maint.h: Fix common/ includes.
9698         * maint.c: Fix common/ includes.
9699         * main.c: Fix common/ includes.
9700         * machoread.c: Fix common/ includes.
9701         * location.c: Fix common/ includes.
9702         * linux-thread-db.c: Fix common/ includes.
9703         * linux-nat.c: Fix common/ includes.
9704         * linux-fork.c: Fix common/ includes.
9705         * inline-frame.c: Fix common/ includes.
9706         * infrun.c: Fix common/ includes.
9707         * inflow.c: Fix common/ includes.
9708         * inferior.h: Fix common/ includes.
9709         * inferior.c: Fix common/ includes.
9710         * infcmd.c: Fix common/ includes.
9711         * inf-ptrace.c: Fix common/ includes.
9712         * inf-child.c: Fix common/ includes.
9713         * ia64-linux-nat.c: Fix common/ includes.
9714         * i387-tdep.c: Fix common/ includes.
9715         * i386-tdep.c: Fix common/ includes.
9716         * i386-linux-tdep.c: Fix common/ includes.
9717         * i386-linux-nat.c: Fix common/ includes.
9718         * i386-go32-tdep.c: Fix common/ includes.
9719         * i386-fbsd-tdep.c: Fix common/ includes.
9720         * i386-fbsd-nat.c: Fix common/ includes.
9721         * guile/scm-type.c: Fix common/ includes.
9722         * guile/guile.c: Fix common/ includes.
9723         * go32-nat.c: Fix common/ includes.
9724         * gnu-nat.c: Fix common/ includes.
9725         * gdbthread.h: Fix common/ includes.
9726         * gdbarch-selftests.c: Fix common/ includes.
9727         * gdb_usleep.c: Fix common/ includes.
9728         * gdb_select.h: Fix common/ includes.
9729         * gdb_bfd.c: Fix common/ includes.
9730         * gcore.c: Fix common/ includes.
9731         * fork-child.c: Fix common/ includes.
9732         * findvar.c: Fix common/ includes.
9733         * fbsd-nat.c: Fix common/ includes.
9734         * event-top.c: Fix common/ includes.
9735         * event-loop.c: Fix common/ includes.
9736         * dwarf2read.c: Fix common/ includes.
9737         * dwarf2loc.c: Fix common/ includes.
9738         * dwarf2-frame.c: Fix common/ includes.
9739         * dwarf-index-cache.c: Fix common/ includes.
9740         * dtrace-probe.c: Fix common/ includes.
9741         * disasm-selftests.c: Fix common/ includes.
9742         * defs.h: Fix common/ includes.
9743         * csky-tdep.c: Fix common/ includes.
9744         * cp-valprint.c: Fix common/ includes.
9745         * cp-support.h: Fix common/ includes.
9746         * cp-support.c: Fix common/ includes.
9747         * corelow.c: Fix common/ includes.
9748         * completer.h: Fix common/ includes.
9749         * completer.c: Fix common/ includes.
9750         * compile/compile.c: Fix common/ includes.
9751         * compile/compile-loc2c.c: Fix common/ includes.
9752         * compile/compile-cplus-types.c: Fix common/ includes.
9753         * compile/compile-cplus-symbols.c: Fix common/ includes.
9754         * command.h: Fix common/ includes.
9755         * cli/cli-dump.c: Fix common/ includes.
9756         * cli/cli-cmds.c: Fix common/ includes.
9757         * charset.c: Fix common/ includes.
9758         * build-id.c: Fix common/ includes.
9759         * btrace.h: Fix common/ includes.
9760         * btrace.c: Fix common/ includes.
9761         * breakpoint.h: Fix common/ includes.
9762         * breakpoint.c: Fix common/ includes.
9763         * ax.h: 
9764         (enum agent_op): Fix common/ includes.
9765         * ax-general.c (struct aop_map): Fix common/ includes.
9766         * ax-gdb.c: Fix common/ includes.
9767         * auxv.c: Fix common/ includes.
9768         * auto-load.c: Fix common/ includes.
9769         * arm-tdep.c: Fix common/ includes.
9770         * arch/riscv.c: Fix common/ includes.
9771         * arch/ppc-linux-common.c: Fix common/ includes.
9772         * arch/i386.c: Fix common/ includes.
9773         * arch/arm.c: Fix common/ includes.
9774         * arch/arm-linux.c: Fix common/ includes.
9775         * arch/arm-get-next-pcs.c: Fix common/ includes.
9776         * arch/amd64.c: Fix common/ includes.
9777         * arch/aarch64.c: Fix common/ includes.
9778         * arch/aarch64-insn.c: Fix common/ includes.
9779         * arch-utils.c: Fix common/ includes.
9780         * amd64-windows-tdep.c: Fix common/ includes.
9781         * amd64-tdep.c: Fix common/ includes.
9782         * amd64-sol2-tdep.c: Fix common/ includes.
9783         * amd64-obsd-tdep.c: Fix common/ includes.
9784         * amd64-nbsd-tdep.c: Fix common/ includes.
9785         * amd64-linux-tdep.c: Fix common/ includes.
9786         * amd64-linux-nat.c: Fix common/ includes.
9787         * amd64-fbsd-tdep.c: Fix common/ includes.
9788         * amd64-fbsd-nat.c: Fix common/ includes.
9789         * amd64-dicos-tdep.c: Fix common/ includes.
9790         * amd64-darwin-tdep.c: Fix common/ includes.
9791         * agent.c: Fix common/ includes.
9792         * ada-lang.h: Fix common/ includes.
9793         * ada-lang.c: Fix common/ includes.
9794         * aarch64-tdep.c: Fix common/ includes.
9795
9796 2019-01-25  Tom Tromey  <tom@tromey.com>
9797
9798         * common/create-version.sh: Use common/version.h.
9799
9800 2019-01-24  Pedro Alves  <palves@redhat.com>
9801
9802         * infrun.c (signal_stop, signal_print, signal_program)
9803         (signal_catch, signal_pass): Now arrays instead of pointers.
9804         (update_signals_program_target, do_target_resume)
9805         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9806         * linux-nat.c (linux_nat_target::pass_signals)
9807         (linux_nat_target::create_inferior, linux_nat_target::attach):
9808         Adjust.
9809         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9810         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9811         * procfs.c (procfs_target::pass_signals): Adjust.
9812         * record-full.c (record_full_target::resume): Adjust.
9813         * remote.c (remote_target::pass_signals)
9814         (remote_target::program_signals): Adjust.
9815         * target-debug.h (target_debug_print_signals): Now takes a
9816         gdb::array_view as parameter.  Adjust.
9817         * target.h (target_ops) <pass_signals, program_signals>: Replace
9818         pointer and length parameters with gdb::array_view.
9819         (target_pass_signals, target_program_signals): Likewise.
9820         * target-delegates.c: Regenerate.
9821
9822 2019-01-24  Pedro Alves  <palves@redhat.com>
9823
9824         * common/forward-scope-exit.h
9825         (forward_scope_exit::forward_scope_exit): Pass arguments to
9826         m_bind_function directly, instead of creating a std::bind and
9827         copying that.
9828
9829 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9830
9831         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9832         for static members.
9833         (pass_in_v_vfp_candidate): Likewise.
9834
9835 2019-01-23  Tom Tromey  <tom@tromey.com>
9836             Pedro Alves  <palves@redhat.com>
9837
9838         * regcache.c (class regcache_invalidator): Remove.
9839         (regcache::raw_write): Use make_scope_exit.
9840
9841 2019-01-23  Tom Tromey  <tom@tromey.com>
9842
9843         * ui-out.h (class ui_out_emit_type): Update comment.
9844
9845 2019-01-23  Tom Tromey  <tom@tromey.com>
9846
9847         * infrun.c (fetch_inferior_event): Update comment.
9848
9849 2019-01-23  Tom Tromey  <tom@tromey.com>
9850             Pedro Alves  <palves@redhat.com>
9851
9852         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9853         parameter.
9854         (fetch_inferior_event): Use SCOPE_EXIT.
9855
9856
9857 2019-01-23  Tom Tromey  <tom@tromey.com>
9858             Pedro Alves  <palves@redhat.com>
9859
9860         * infrun.c (disable_thread_events): Delete.
9861         (stop_all_threads): Use SCOPE_EXIT.
9862
9863 2019-01-23  Tom Tromey  <tom@tromey.com>
9864             Pedro Alves  <palves@redhat.com>
9865
9866         * symfile.c: Include forward-scope-exit.h.
9867         (clear_symtab_users_cleanup): Replace forward declaration with
9868         a FORWARD_SCOPE_EXIT.
9869         (syms_from_objfile_1): Use the forward_scope_exit and
9870         gdb::optional instead of cleanup_function.
9871         (reread_symbols): Use the forward_scope_exit instead of
9872         cleanup_function.
9873         (clear_symtab_users_cleanup): Remove function.
9874
9875 2019-01-23  Tom Tromey  <tom@tromey.com>
9876             Pedro Alves  <palves@redhat.com>
9877
9878         * linux-nat.c: Include scope-exit.h.
9879         (cleanup_target_stop): Remove.
9880         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9881         SCOPE_EXIT.
9882
9883 2019-01-23  Tom Tromey  <tom@tromey.com>
9884             Pedro Alves  <palves@redhat.com>
9885
9886         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9887         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9888
9889 2019-01-23  Tom Tromey  <tom@tromey.com>
9890             Andrew Burgess  <andrew.burgess@embecosm.com>
9891             Pedro Alves  <palves@redhat.com>
9892
9893         * infrun.c (fetch_inferior_event): Use scope_exit.
9894         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9895         * top.c (execute_command): Use scope_exit.
9896         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9897         * utils.c (do_bpstat_clear_actions_cleanup)
9898         (make_bpstat_clear_actions_cleanup): Remove.
9899
9900 2019-01-23  Tom Tromey  <tom@tromey.com>
9901             Pedro Alves  <palves@redhat.com>
9902
9903         * infrun.c: Include "common/scope-exit.h"
9904         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9905         (wait_for_inferior): Use SCOPE_EXIT.
9906         (fetch_inferior_event): Use scope_exit.
9907
9908 2019-01-23  Tom Tromey  <tom@tromey.com>
9909             Pedro Alves  <palves@redhat.com>
9910
9911         * breakpoint.c (create_breakpoint): Remove cleanup.
9912
9913 2019-01-23  Tom Tromey  <tom@tromey.com>
9914             Andrew Burgess  <andrew.burgess@embecosm.com>
9915             Pedro Alves  <palves@redhat.com>
9916
9917 2019-01-23  Pedro Alves  <palves@redhat.com>
9918
9919         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9920
9921 2019-01-23  Pedro Alves  <palves@redhat.com>
9922             Andrew Burgess  <andrew.burgess@embecosm.com>
9923
9924         * gdbthread.h: Include "common/forward-scope-exit.h".
9925         (scoped_finish_thread_state): Redefine custom class in terms of
9926         forward_scope_exit.
9927
9928 2019-01-23  Pedro Alves  <palves@redhat.com>
9929             Andrew Burgess  <andrew.burgess@embecosm.com>
9930
9931         * common/forward-scope-exit.h: New file.
9932
9933 2019-01-23  Pedro Alves  <palves@redhat.com>
9934             Andrew Burgess  <andrew.burgess@embecosm.com>
9935             Tom Tromey  <tom@tromey.com>
9936
9937         * common/scope-exit.h: New file.
9938
9939 2019-01-23  Pedro Alves  <palves@redhat.com>
9940
9941         * common/preprocessor.h (ESC): Rename to ...
9942         (ESC_PARENS): ... this.
9943         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9944         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9945
9946 2019-01-23  Tom Tromey  <tom@tromey.com>
9947
9948         * language.h (class scoped_switch_to_sym_language_if_auto):
9949         Initialize m_lang in both cases.
9950
9951 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9952
9953         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9954         with XCNEW.
9955
9956 2019-01-22  Tom Tromey  <tom@tromey.com>
9957
9958         * corelow.c: Do not include sys/file.h.
9959
9960 2019-01-22  Tom Tromey  <tom@tromey.com>
9961
9962         * tui/tui-wingeneral.h: Include gdb_curses.h.
9963
9964 2019-01-22  Tom Tromey  <tom@tromey.com>
9965
9966         * source-cache.h (class source_cache) <get_source_lines,
9967         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9968
9969 2019-01-22  Tom Tromey  <tom@tromey.com>
9970
9971         * remote-fileio.h (struct remote_target): Declare.
9972
9973 2019-01-22  Tom Tromey  <tom@tromey.com>
9974
9975         * python/py-arch.c: Do not include py-ref.h.
9976         * python/py-bpevent.c: Do not include py-ref.h.
9977         * python/py-cmd.c: Do not include py-ref.h.
9978         * python/py-continueevent.c: Do not include py-ref.h.
9979         * python/py-event.h: Do not include py-ref.h.
9980         * python/py-evtregistry.c: Do not include py-ref.h.
9981         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9982         * python/py-frame.c: Do not include py-ref.h.
9983         * python/py-framefilter.c: Do not include py-ref.h.
9984         * python/py-function.c: Do not include py-ref.h.
9985         * python/py-infevents.c: Do not include py-ref.h.
9986         * python/py-linetable.c: Do not include py-ref.h.
9987         * python/py-objfile.c: Do not include py-ref.h.
9988         * python/py-param.c: Do not include py-ref.h.
9989         * python/py-prettyprint.c: Do not include py-ref.h.
9990         * python/py-progspace.c: Do not include py-ref.h.
9991         * python/py-symbol.c: Do not include py-ref.h.
9992         * python/py-symtab.c: Do not include py-ref.h.
9993         * python/py-type.c: Do not include py-ref.h.
9994         * python/py-unwind.c: Do not include py-ref.h.
9995         * python/py-utils.c: Do not include py-ref.h.
9996         * python/py-value.c: Do not include py-ref.h.
9997         * python/py-varobj.c: Do not include py-ref.h.
9998         * python/py-xmethods.c: Do not include py-ref.h.
9999         * python/python.c: Do not include py-ref.h.
10000         * varobj.c: Do not include py-ref.h.
10001
10002 2019-01-22  Tom Tromey  <tom@tromey.com>
10003
10004         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10005         keyword for bcache.
10006
10007 2019-01-22  Tom Tromey  <tom@tromey.com>
10008
10009         * compile/compile-cplus-types.c: Remove a comment by #include.
10010
10011 2019-01-22  Tom Tromey  <tom@tromey.com>
10012
10013         * compile/gcc-c-plugin.h: Include compile-internal.h.
10014
10015 2019-01-22  Tom Tromey  <tom@tromey.com>
10016
10017         * stabsread.c (EXTERN): Do not define.
10018         (symnum, next_symbol_text_func, processing_gcc_compilation)
10019         (within_function, global_sym_chain, global_stabs)
10020         (previous_stab_code, this_object_header_files)
10021         (n_this_object_header_files)
10022         (n_allocated_this_object_header_files): Define.
10023         * stabsread.h (EXTERN): Never define.  Use "extern".
10024
10025 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10026
10027         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10028         history_value.
10029
10030 2019-01-21  Tom Tromey  <tom@tromey.com>
10031
10032         * ui-out.c: Fix includes.
10033         * tui/tui-source.c: Fix includes.
10034         * target.c: Fix includes.
10035         * remote.c: Fix includes.
10036         * regcache.c: Fix includes.
10037         * python/py-block.c: Fix includes.
10038         * printcmd.c: Fix includes.
10039         * or1k-tdep.c: Fix includes.
10040         * mi/mi-main.c: Fix includes.
10041         * m32r-tdep.c: Fix includes.
10042         * csky-tdep.c: Fix includes.
10043         * compile/compile-cplus-types.c: Fix includes.
10044         * cli/cli-interp.c: Fix includes.
10045
10046 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10047
10048         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10049         for padding.
10050
10051 2019-01-16  Tom Tromey  <tom@tromey.com>
10052
10053         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10054         earlier.
10055         (struct objfile) <msymbols_range>: Move from top level.
10056         <msymbols>: New method.
10057         (class objfile_msymbols): Remove.
10058         * symtab.c (default_collect_symbol_completion_matches_break_on):
10059         Update.
10060         * symmisc.c (dump_msymbols): Update.
10061         * stabsread.c (scan_file_globals): Update.
10062         * objc-lang.c (info_selectors_command, info_classes_command)
10063         (find_methods): Update.
10064         * minsyms.c (find_solib_trampoline_target): Update.
10065         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10066         * coffread.c (coff_symfile_read): Update.
10067         * ada-lang.c (ada_lookup_simple_minsym)
10068         (ada_collect_symbol_completion_matches): Update.
10069
10070 2019-01-16  Tom Tromey  <tom@tromey.com>
10071
10072         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10073         type.  Remove no-argument constructor.
10074         <iterator::operator++>: Simplify.
10075         <begin>: Update.
10076         <end>: Use minimal_symbol_count.
10077
10078 2019-01-16  Tom Tromey  <tom@tromey.com>
10079
10080         * objfiles.h (struct objfile) <psymtabs>: New method.
10081         (class objfile_psymtabs): Remove.
10082         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10083         typedef.
10084         <range>: New method.
10085         (require_partial_symbols): Change return type.
10086         * psymtab.c (require_partial_symbols)
10087         (psym_expand_symtabs_matching): Update.
10088         * mdebugread.c (parse_partial_symbols): Update.
10089         * dbxread.c (dbx_end_psymtab): Update.
10090
10091 2019-01-15  Tom Tromey  <tom@tromey.com>
10092
10093         * symtab.c (lookup_objfile_from_block)
10094         (lookup_symbol_in_objfile_symtabs)
10095         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10096         (find_line_symtab, info_sources_command)
10097         (default_collect_symbol_completion_matches_break_on)
10098         (make_source_files_completion_list): Update.
10099         * symmisc.c (print_objfile_statistics, dump_objfile)
10100         (maintenance_print_symbols, maintenance_info_symtabs)
10101         (maintenance_check_symtabs, maintenance_info_line_tables):
10102         Update.
10103         * source.c (select_source_symtab)
10104         (forget_cached_source_info_for_objfile): Update.
10105         * objfiles.h (class objfile_compunits): Remove.
10106         (struct objfile) <compunits_range>: New typedef.
10107         (compunits): New method.
10108         * objfiles.c (objfile_relocate1): Update.
10109         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10110         * maint.c (count_symtabs_and_blocks): Update.
10111         * linespec.c (iterate_over_all_matching_symtabs): Update.
10112         * cp-support.c (add_symbol_overload_list_qualified): Update.
10113         * coffread.c (coff_symtab_read): Update.
10114         * ada-lang.c (add_nonlocal_symbols)
10115         (ada_collect_symbol_completion_matches)
10116         (ada_add_global_exceptions): Update.
10117
10118 2019-01-15  Tom Tromey  <tom@tromey.com>
10119
10120         * progspace.h (program_space) <objfiles_safe_range>: New
10121         typedef.
10122         <objfiles_safe>: New method.
10123         * objfiles.h (class all_objfiles_safe): Remove.
10124         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10125         * jit.c (jit_inferior_exit_hook): Update.
10126
10127 2019-01-17  Tom Tromey  <tom@tromey.com>
10128
10129         * progspace.h (program_space) <objfiles_range>: New typedef.
10130         <objfiles>: New method.
10131         <objfiles_head>: Rename from objfiles.
10132         (object_files): Update.
10133         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10134         * guile/scm-pretty-print.c
10135         (ppscm_find_pretty_printer_from_objfiles): Update.
10136         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10137         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10138         Update.
10139         * python/py-progspace.c (pspy_get_objfiles): Update.
10140         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10141         Update.
10142         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10143         (objfpy_lookup_objfile_by_build_id): Update.
10144         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10145         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10146         Update.
10147         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10148         (expand_symtab_containing_pc, lookup_objfile_from_block)
10149         (lookup_static_symbol, basic_lookup_transparent_type)
10150         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10151         (find_line_symtab, info_sources_command)
10152         (default_collect_symbol_completion_matches_break_on)
10153         (make_source_files_completion_list, find_main_name): Update.
10154         * symmisc.c (print_symbol_bcache_statistics)
10155         (print_objfile_statistics, maintenance_print_symbols)
10156         (maintenance_print_msymbols, maintenance_print_objfiles)
10157         (maintenance_info_symtabs, maintenance_check_symtabs)
10158         (maintenance_expand_symtabs, maintenance_info_line_tables):
10159         Update.
10160         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10161         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10162         (map_overlay_command, unmap_overlay_command)
10163         (simple_overlay_update, expand_symtabs_matching)
10164         (map_symbol_filenames): Update.
10165         * symfile-debug.c (set_debug_symfile): Update.
10166         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10167         Update.
10168         * source.c (select_source_symtab, forget_cached_source_info):
10169         Update.
10170         * solib.c (solib_read_symbols): Update.
10171         * solib-spu.c (append_ocl_sos): Update.
10172         * psymtab.c (maintenance_print_psymbols)
10173         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10174         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10175         * printcmd.c (info_symbol_command): Update.
10176         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10177         Update.
10178         * objfiles.h (class all_objfiles): Remove.
10179         * objfiles.c (have_partial_symbols, have_full_symbols)
10180         (have_minimal_symbols, qsort_cmp, update_section_map)
10181         (shared_objfile_contains_address_p)
10182         (default_iterate_over_objfiles_in_search_order): Update.
10183         * objc-lang.c (info_selectors_command, info_classes_command)
10184         (find_methods): Update.
10185         * minsyms.c (find_solib_trampoline_target): Update.
10186         * maint.c (maintenance_info_sections)
10187         (maintenance_translate_address, count_symtabs_and_blocks):
10188         Update.
10189         * main.c (captured_main_1): Update.
10190         * linux-thread-db.c (try_thread_db_load_from_pdir)
10191         (has_libpthread): Update.
10192         * linespec.c (iterate_over_all_matching_symtabs)
10193         (search_minsyms_for_name): Update.
10194         * jit.c (jit_find_objf_with_entry_addr): Update.
10195         * hppa-tdep.c (find_unwind_entry)
10196         (hppa_lookup_stub_minimal_symbol): Update.
10197         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10198         Update.
10199         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10200         (elf_gnu_ifunc_resolve_by_got): Update.
10201         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10202         * dwarf-index-write.c (save_gdb_index_command): Update.
10203         * cp-support.c (add_symbol_overload_list_qualified): Update.
10204         * breakpoint.c (create_overlay_event_breakpoint)
10205         (create_longjmp_master_breakpoint)
10206         (create_std_terminate_master_breakpoint)
10207         (create_exception_master_breakpoint): Update.
10208         * blockframe.c (find_pc_partial_function): Update.
10209         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10210         (ada_collect_symbol_completion_matches)
10211         (ada_add_global_exceptions): Update.
10212
10213 2019-01-17  Tom Tromey  <tom@tromey.com>
10214
10215         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10216         declare VEC.
10217         (solib_target_parse_libraries): Change return type.
10218         (library_list_start_segment, library_list_start_section)
10219         (library_list_end_library, library_list_start_library); Update.
10220         (solib_target_free_library_list): Remove.
10221         (solib_target_parse_libraries): Remove cleanup.  Change return
10222         type.
10223         (solib_target_current_sos): Update.
10224
10225 2019-01-17  Tom Tromey  <tromey@bapiya>
10226
10227         * valprint.c: Replace "the the" with "the".
10228         * symtab.c: Replace "the the" with "the".
10229         * solib.c: Replace "the the" with "the".
10230         * solib-dsbt.c: Replace "the the" with "the".
10231         * linespec.c: Replace "the the" with "the".
10232         * dwarf2loc.h: Replace "the the" with "the".
10233         * amd64-windows-tdep.c: Replace "the the" with "the".
10234         * aarch64-tdep.c: Replace "the the" with "the".
10235
10236 2019-01-16  Keith Seitz  <keiths@redhat.com>
10237
10238         PR gdb/23773
10239         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10240         <builder>: Rename to ..
10241         <m_builder>: ... this and make private.
10242         (dwarf2_cu::get_builder): New method.  Change all users of
10243         `builder' to use this method.
10244         (dwarf2_start_symtab): Move to ...
10245         (dwarf2_cu::start_symtab): ... here.  Update all callers
10246         (setup_type_unit_groups): Move to ...
10247         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10248         callers.
10249         (dwarf2_cu::reset_builder): New method.
10250         (process_full_compunit, process_full_type_unit): Use
10251         dwarf2_cu::reset_builder.
10252         (follow_die_offset): Record the ancestor CU if it is different
10253         from the followed DIE's CU.
10254         (follow_die_sig_1): Likewise.
10255
10256 2019-01-15  Tom Tromey  <tom@tromey.com>
10257
10258         * remote.c (class remote_state) <buf>: Now a char_vector.
10259         <buf_size>: Remove.
10260         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10261         parameter.
10262         (remote_target::getpkt_or_notif_sane_1)
10263         (remote_target::getpkt_sane)
10264         (remote_target::getpkt_or_notif_sane): Likewise.
10265         (class remote_target) <putpkt>: New overload.
10266         (remote_target::read_frame): Change type of "buf_p".  Remove
10267         sizeof_p parameter.
10268         (packet_ok): New overload.
10269         (packet_check_result): New overload.
10270         Update all uses.
10271
10272 2019-01-14  Tom Tromey  <tom@tromey.com>
10273
10274         * remote-notif.c (handle_notification, remote_notif_ack)
10275         (remote_notif_parse): Make "buf" const.
10276         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10277         const.
10278         (remote_notif_parse, remote_notif_ack, handle_notification):
10279         Likewise.
10280         * remote.c (remote_notif_stop_parse): Make "buf" const.
10281         (remote_target::remote_parse_stop_reply): Make "buf" const.
10282         (remote_notif_stop_ack): Make "buf" const.
10283
10284 2019-01-14  Tom Tromey  <tom@tromey.com>
10285
10286         * remote.c (remote_console_output): Make parameter const.
10287
10288 2019-01-14  Tom Tromey  <tom@tromey.com>
10289
10290         * target-debug.h (target_debug_print_signals): Constify.
10291         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10292         * procfs.c (procfs_target::pass_signals): Update.
10293         * linux-nat.c (linux_nat_target::pass_signals): Update.
10294         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10295         * target-delegates.c: Rebuild.
10296         * remote.c (remote_target::program_signals): Update.
10297         (remote_target::pass_signals): Update.
10298         * target.c (target_pass_signals): Constify argument.
10299         (target_program_signals): Likewise.
10300         * target.h (struct target_ops) <pass_signals, program_signals>:
10301         Constify argument.
10302         (target_pass_signals, target_program_signals): Constify argument.
10303
10304 2019-01-14  Tom Tromey  <tom@tromey.com>
10305
10306         PR tui/28819:
10307         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10308
10309 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10310
10311         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10312         field.
10313         * rs6000-tdep.c: Include reggroups.h.
10314         (IS_V_ALIAS_PSEUDOREG): Define.
10315         (rs6000_register_name): Return names for the "vX" aliases.
10316         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10317         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10318         aliases.  Call default_register_reggroup_p for all other
10319         pseudo-registers.
10320         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10321         New functions.
10322         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10323         Handle "vX" aliases.
10324         (v_alias_pseudo_register_collect): New function.
10325         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10326         (rs6000_gdbarch_init): Initialize "vX" aliases as
10327         pseudo-registers.  Restore registration of
10328         rs6000_pseudo_register_reggroup_p with
10329         set_tdesc_pseudo_register_reggroup_p.
10330
10331 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10332
10333         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10334         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10335         set_gdbarch_num_pseudo_regs.
10336
10337 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10338
10339         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10340         Remove arg prefixname, add do_set and do_show.
10341         Add member functions set_list and show_list.
10342         * cli/cli-style.c (class cli_style_option): Update accordingly.
10343         (style_set_list): Move to file scope.
10344         (style_show_list): Likewise.
10345         (set_style): Call help_list.
10346         (show_style): Call cmd_show_list.
10347         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10348         Update to use the new macro.
10349
10350 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10351
10352         * ada-lang.c (_initialize_ada_language): Expand the help text
10353         for the "catch exception" command.
10354
10355 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10356
10357         * symtab.c (matching_obj_sections): Initialize obj,
10358         declare it closer to its usage.
10359
10360 2019-01-10  Tom Tromey  <tom@tromey.com>
10361
10362         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10363         (basic_inf_threads_range): Remove.
10364         (inf_threads_range, inf_non_exited_threads_range)
10365         (safe_inf_threads_range): Use next_adapter.
10366
10367 2019-01-10  Keith Seitz  <keiths@redhat.com>
10368
10369         PR gdb/23712
10370         PR symtab/23010
10371         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10372         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10373
10374 2019-01-10  Keith Seitz  <keiths@redhat.com>
10375
10376         PR gdb/23712
10377         PR symtab/23010
10378         * dictionary.c (pending_to_vector): Remove.
10379         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10380         Remove _1 suffix, replacing functions of the same name.  Update
10381         all callers.
10382         (dict_create_hashed, dict_create_hashed_expandable)
10383         (dict_create_linear, dict_create_linear_expandable, dict_free)
10384         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10385         Make functions static.
10386
10387 2019-01-10  Keith Seitz  <keiths@redhat.com>
10388
10389         PR gdb/23712
10390         PR symtab/23010
10391         * dictionary.h (struct dictionary): Replace declaration with
10392         multidictionary.
10393         (dict_create_hashed, dict_create_hashed_expandable)
10394         (dict_create_linear, dict_create_linear_expandable)
10395         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10396         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10397         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10398         taking multidictionary argument.
10399         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10400         * block.h (struct block) <dict>: Change to multidictionary
10401         and rename `multidict'.
10402         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10403         symmisc.c: Update all dictionary references to multidictionary.
10404
10405 2019-01-10  Keith Seitz  <keiths@redhat.com>
10406
10407         PR gdb/23712
10408         PR symtab/23010
10409         * dictionary.c: Include unordered_map.
10410         (pending_to_vector): New function.
10411         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10412         Rewrite the non-"_1" functions to take vector instead
10413         of linked list.
10414         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10415         "new" _1 versions of the same name.
10416         (multidictionary): Define.
10417         (std::hash<enum language): New definition.
10418         (collate_pending_symbols_by_language, mdict_create_hashed)
10419         (mdict_create_hashed_expandable, mdict_create_linear)
10420         (mdict_create_linear_expandable, mdict_free)
10421         (find_language_dictionary, create_new_language_dictionary)
10422         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10423         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10424         (mdict_size, mdict_empty): New functions.
10425         * dictionary.h (mdict_iterator): Define.
10426
10427 2019-01-10  Pedro Alves  <palves@redhat.com>
10428
10429         * breakpoint.c (read_uploaded_action)
10430         (create_tracepoint_from_upload): Adjust to use
10431         gdb::unique_xmalloc_ptr.
10432         * ctf.c (ctf_write_uploaded_tp):
10433         (SET_ARRAY_FIELD): Use emplace_back.
10434         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10435         * tracefile-tfile.c (tfile_write_uploaded_tp):
10436         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10437         gdb::unique_xmalloc_ptr.
10438         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10439         at_string, cond_string, cmd_strings>: Replace char pointers
10440         with gdb::unique_xmalloc_ptr.
10441
10442 2019-01-10  Pedro Alves  <palves@redhat.com>
10443
10444         * solib-target.c (library_list_start_library): Don't xstrdup name.
10445
10446 2019-01-10  Pedro Alves  <palves@redhat.com>
10447
10448         * mdebugread.c (parse_partial_symbols): Use
10449         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10450
10451 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10452
10453         * linux-fork.c (scoped_switch_fork_info)
10454         <~scoped_switch_fork_info>: Fix incorrect variable name.
10455
10456 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10457
10458         * linux-fork.c (scoped_switch_fork_info)
10459         <scoped_switch_fork_info>: Make explicit.
10460         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10461
10462 2019-01-10  Tom Tromey  <tom@tromey.com>
10463
10464         * objfiles.h (objfile::reset_psymtabs): Update.
10465         * objfiles.c (objfile::objfile): Update.
10466         * psymtab.h (psymtab_storage::obstack): Update.
10467         (psymtab_storage::m_obstack): Use gdb::optional.
10468         (class psymtab_storage): Update comment.  Remove objfile
10469         parameter.
10470         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10471
10472 2019-01-10  Tom Tromey  <tom@tromey.com>
10473
10474         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10475         <free_psymtabs>: Now private.
10476         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10477         (allocate_psymtab): Use new method.
10478
10479 2019-01-10  Tom Tromey  <tom@tromey.com>
10480
10481         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10482         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10483         * mdebugread.c (parse_partial_symbols): Use
10484         allocate_dependencies.
10485         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10486         allocate_dependencies.
10487         (process_psymtab_comp_unit_reader)
10488         (build_type_psymtab_dependencies): Likewise.
10489         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10490
10491 2019-01-10  Tom Tromey  <tom@tromey.com>
10492
10493         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10494         PSYMBOL_SET_LANGUAGE.
10495         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10496
10497 2019-01-10  Tom Tromey  <tom@tromey.com>
10498
10499         * psymtab.h (psymtab_storage::obstack): New method.
10500         <m_obstack>: Rename from obstack; now private.
10501         * psymtab.c (psymtab_storage): Update.
10502         * dwarf2read.c (create_addrmap_from_index)
10503         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10504         Update.
10505
10506 2019-01-10  Tom Tromey  <tom@tromey.com>
10507
10508         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10509         * objfiles.h (objfile::reset_psymtabs): New method.
10510
10511 2019-01-10  Tom Tromey  <tom@tromey.com>
10512
10513         * symmisc.c (print_symbol_bcache_statistics): Update.
10514         (print_objfile_statistics): Update.
10515         * symfile.c (reread_symbols): Update.
10516         * psymtab.h (class psymtab_storage): New.
10517         * psymtab.c (psymtab_storage): New constructor.
10518         (~psymtab_storage): New destructor.
10519         (require_partial_symbols): Update.
10520         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10521         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10522         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10523         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10524         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10525         (start_psymtab_common, end_psymtab_common)
10526         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10527         (allocate_psymtab): Update.
10528         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10529         Update.
10530         (dump_psymtab_addrmap, maintenance_print_psymbols)
10531         (maintenance_check_psymtabs): Update.
10532         (class objfile_psymtabs): Move to objfiles.h.
10533         * psympriv.h (discard_psymtab): Now inline.
10534         (psymtab_discarder::psymtab_discarder): Update.
10535         (psymtab_discarder::~psymtab_discarder): Update.
10536         (ALL_OBJFILE_PSYMTABS): Rewrite.
10537         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10538         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10539         Remove fields.
10540         <partial_symtabs>: New field.
10541         (class objfile_psymtabs): Move from psymtab.h.  Update.
10542         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10543         psymbol_cache.
10544         (objfile::~objfile): Don't destroy psymbol_cache.
10545         * mdebugread.c (parse_partial_symbols): Update.
10546         * dwarf2read.c (create_addrmap_from_index)
10547         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10548         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10549         (add_partial_subprogram, dwarf2_ranges_read): Update.
10550         * dwarf-index-write.c (write_address_map)
10551         (write_one_signatured_type, recursively_write_psymbols)
10552         (class debug_names, class debug_names, write_psymtabs_to_index):
10553         Update.
10554
10555 2019-01-10  Tom Tromey  <tom@tromey.com>
10556
10557         * symtab.h (SYMBOL_SET_NAMES): Update.
10558         (symbol_set_names): Update.
10559         (MSYMBOL_SET_NAMES): Update.
10560         * symtab.c (symbol_set_names): Change argument to be an
10561         objfile_per_bfd_storage.
10562         * psymtab.c (add_psymbol_to_bcache): Update.
10563         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10564
10565 2019-01-10  Tom Tromey  <tom@tromey.com>
10566
10567         * symtab.c (create_demangled_names_hash): Change argument to be an
10568         objfile_per_bfd_storage.
10569         (symbol_set_names): Update.
10570
10571 2019-01-10  Tom Tromey  <tom@tromey.com>
10572
10573         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10574         init_psymbol_list.
10575         * psymtab.c (init_psymbol_list): Do nothing if already called.
10576         * psympriv.h (init_psymbol_list): Add comment.
10577         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10578         init_psymbol_list.
10579         * dbxread.c (dbx_symfile_read): Unconditionally call
10580         init_psymbol_list.
10581
10582 2019-01-10  Tom Tromey  <tom@tromey.com>
10583
10584         * xcoffread.c (scan_xcoff_symtab): Update.
10585         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10586         "where".
10587         * mdebugread.c (parse_partial_symbols)
10588         (handle_psymbol_enumerators): Update.
10589         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10590         * dbxread.c (read_dbx_symtab): Update.
10591         * psympriv.h (psymbol_placement): New enum.
10592         (add_psymbol_to_list): Update.
10593
10594 2019-01-10  Tom Tromey  <tom@tromey.com>
10595
10596         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10597         static_psymbols parameters.
10598         (scan_xcoff_symtab): Update.
10599         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10600         static_psymbols parameters.
10601         * psympriv.h (start_psymtab_common): Update.
10602         * mdebugread.c (parse_partial_symbols): Update.
10603         * dwarf2read.c (create_partial_symtab): Update.
10604         * dbxread.c (read_dbx_symtab): Update.
10605         (start_psymtab): Remove global_psymbols and static_psymbols
10606         parameters.
10607
10608 2019-01-10  Tom Tromey  <tom@tromey.com>
10609
10610         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10611         * psymtab.c (allocate_psymtab): Add comment.
10612         * psympriv.h (allocate_psymtab): Add comment.
10613         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10614         initializations.
10615         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10616
10617 2019-01-10  Tom Tromey  <tom@tromey.com>
10618
10619         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10620         Don't declare.
10621         * mipsread.c: Include mdebugread.h.
10622         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10623         Declare.
10624         * elfread.c: Include mdebugread.h.
10625
10626 2019-01-09  Tom Tromey  <tom@tromey.com>
10627
10628         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10629         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10630         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10631         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10632         (psym_lookup_symbol, psym_find_last_source_symtab)
10633         (psym_forget_cached_source_info, psym_print_stats)
10634         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10635         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10636         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10637         (psym_find_compunit_symtab_by_address)
10638         (maintenance_print_psymbols, maintenance_info_psymtabs)
10639         (maintenance_check_psymtabs): Use ranged for.
10640         * psymtab.h (class objfile_psymtabs): New.
10641         (require_partial_symbols): Return objfile_psymtabs.
10642         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10643
10644 2019-01-09  Tom Tromey  <tom@tromey.com>
10645
10646         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10647         (find_pc_mapped_section, list_overlays_command)
10648         (map_overlay_command, unmap_overlay_command)
10649         (simple_overlay_update): Use all_objfiles.
10650         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10651         * printcmd.c (info_symbol_command): Use all_objfiles.
10652         * objfiles.h (ALL_OBJSECTIONS): Remove.
10653         * maint.c (maintenance_translate_address): Use all_objfiles.
10654         * gcore.c (gcore_create_callback): Use all_objfiles.
10655         (objfile_find_memory_regions): Likewise.
10656
10657 2019-01-09  Tom Tromey  <tom@tromey.com>
10658
10659         * symtab.c (find_line_symtab, info_sources_command)
10660         (make_source_files_completion_list): Use objfile_compunits.
10661         * source.c (select_source_symtab): Use objfile_compunits.
10662         * objfiles.h (struct objfile): Update comment.
10663         (ALL_OBJFILES): Remove.
10664         (ALL_FILETABS): Remove.
10665         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10666         objfile_compunits.
10667
10668 2019-01-09  Tom Tromey  <tom@tromey.com>
10669
10670         * symmisc.c (print_objfile_statistics, dump_objfile)
10671         (maintenance_print_symbols): Use compunit_filetabs.
10672         * source.c (forget_cached_source_info_for_objfile): Use
10673         compunit_filetabs.
10674         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10675         (ALL_FILETABS): Use compunit_filetabs.
10676         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10677         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10678
10679 2019-01-09  Tom Tromey  <tom@tromey.com>
10680
10681         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10682         (compunit_filetabs): New.
10683         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10684         compunit_filetabs.
10685         (info_sources_command, make_source_files_completion_list): Remove
10686         declaration.
10687         * symmisc.c (print_objfile_statistics, dump_objfile)
10688         (maintenance_print_symbols): Remove declaration.
10689         (maintenance_info_symtabs): Use compunit_filetabs.
10690         (maintenance_info_line_tables): Likewise.
10691         * source.c (select_source_symtab): Change local variable name.
10692         (forget_cached_source_info_for_objfile): Remove declaration.
10693         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10694         * objfiles.c (objfile_relocate1): Remove declaration.
10695         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10696         declaration.
10697         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10698         * coffread.c (coff_symtab_read): Remove declaration.
10699         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10700         compunit_filetabs.
10701
10702 2019-01-09  Tom Tromey  <tom@tromey.com>
10703
10704         * symtab.c (lookup_objfile_from_block)
10705         (find_pc_sect_compunit_symtab, search_symbols)
10706         (default_collect_symbol_completion_matches_break_on): Use
10707         objfile_compunits.
10708         * objfiles.h (ALL_COMPUNITS): Remove.
10709         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10710         * cp-support.c (add_symbol_overload_list_qualified): Use
10711         objfile_compunits.
10712         * ada-lang.c (ada_collect_symbol_completion_matches)
10713         (ada_add_global_exceptions): Use objfile_compunits.
10714
10715 2019-01-09  Tom Tromey  <tom@tromey.com>
10716
10717         * source.c (select_source_symtab)
10718         (forget_cached_source_info_for_objfile): Remove declaration.
10719         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10720         declaration.
10721         * maint.c (count_symtabs_and_blocks): Remove declaration.
10722         * cp-support.c (add_symbol_overload_list_qualified): Remove
10723         declaration.
10724         * coffread.c (coff_symtab_read): Remove declaration.
10725         * symtab.c (lookup_symbol_in_objfile_symtabs)
10726         (basic_lookup_transparent_type_1): Use objfile_compunits.
10727         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10728         (info_sources_command, search_symbols)
10729         (default_collect_symbol_completion_matches_break_on)
10730         (make_source_files_completion_list): Remove declaration.
10731         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10732         (ada_collect_symbol_completion_matches)
10733         (ada_add_global_exceptions): Remove declaration.
10734         * linespec.c (iterate_over_all_matching_symtabs): Use
10735         objfile_compunits.
10736         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10737         (class objfile_compunits): New.
10738         (ALL_COMPUNITS): Use objfile_compunits.
10739         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10740         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10741         objfile_compunits.
10742         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10743
10744 2019-01-09  Tom Tromey  <tom@tromey.com>
10745
10746         * symtab.c (search_symbols)
10747         (default_collect_symbol_completion_matches_break_on): Use
10748         objfile_msymbols.
10749         * ada-lang.c (ada_lookup_simple_minsym)
10750         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10751         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10752         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10753         objfile_msymbols.
10754         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10755         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10756         * objc-lang.c (find_methods): Use objfile_msymbols.
10757         (info_selectors_command, info_classes_command): Likewise.
10758         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10759         * objfiles.h (class objfile_msymbols): New.
10760         (ALL_OBJFILE_MSYMBOLS): Remove.
10761         (ALL_MSYMBOLS): Remove.
10762
10763 2019-01-09  Tom Tromey  <tom@tromey.com>
10764
10765         * common/next-iterator.h (next_adapter): Add Iterator template
10766         parameter.
10767         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10768         (class all_objfiles_safe): New.
10769         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10770         * objfiles.c (put_objfile_before): Update comment.
10771         (add_separate_debug_objfile): Likewise.
10772         (free_all_objfiles): Use all_objfiles_safe.
10773         (objfile_purge_solibs): Likewise.
10774
10775 2019-01-09  Tom Tromey  <tom@tromey.com>
10776
10777         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10778         (expand_symtab_containing_pc, lookup_static_symbol)
10779         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10780         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10781         all_objfiles.
10782         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10783         * breakpoint.c (create_overlay_event_breakpoint)
10784         (create_longjmp_master_breakpoint)
10785         (create_std_terminate_master_breakpoint)
10786         (create_exception_master_breakpoint): Use all_objfiles.
10787         * linux-thread-db.c (try_thread_db_load_from_pdir)
10788         (has_libpthread): Use all_objfiles.
10789         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10790         * linespec.c (iterate_over_all_matching_symtabs)
10791         (search_minsyms_for_name): Use all_objfiles.
10792         * maint.c (maintenance_info_sections): Use all_objfiles.
10793         * main.c (captured_main_1): Use all_objfiles.
10794         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10795         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10796         * guile/scm-pretty-print.c
10797         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10798         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10799         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10800         (maintenance_print_msymbols): Use all_objfiles.
10801         * source.c (select_source_symtab): Use all_objfiles.
10802         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10803         * symfile.c (remove_symbol_file_command)
10804         (expand_symtabs_matching, map_symbol_filenames): Use
10805         all_objfiles.
10806         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10807         all_objfiles.
10808         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10809         * objc-lang.c (find_methods): Use all_objfiles.
10810         * objfiles.c (have_partial_symbols, have_full_symbols)
10811         (have_minimal_symbols, qsort_cmp)
10812         (default_iterate_over_objfiles_in_search_order): Use
10813         all_objfiles.
10814         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10815         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10816         (maintenance_check_psymtabs): Use all_objfiles.
10817         (ALL_PSYMTABS): Remove.
10818         * compile/compile-object-run.c (do_module_cleanup): Use
10819         all_objfiles.
10820         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10821         * cp-support.c (add_symbol_overload_list_qualified): Use
10822         all_objfiles.
10823         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10824         Use all_objfiles.
10825         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10826         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10827         all_objfiles.
10828         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10829         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10830         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10831         Uses all_objfiles.
10832         * solib.c (solib_read_symbols): Use all_objfiles
10833
10834 2019-01-09  Tom Tromey  <tom@tromey.com>
10835
10836         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10837         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10838         all_objfiles.
10839         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10840         * symmisc.c (print_symbol_bcache_statistics)
10841         (print_objfile_statistics, maintenance_print_objfiles)
10842         (maintenance_info_symtabs, maintenance_check_symtabs)
10843         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10844         all_objfiles.
10845         * source.c (forget_cached_source_info): Use all_objfiles.
10846         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10847         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10848         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10849         * objfiles.c (update_section_map): Use all_objfiles.
10850         (shared_objfile_contains_address_p): Likewise.
10851         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10852         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10853
10854 2019-01-09  Tom Tromey  <tom@tromey.com>
10855
10856         * common/next-iterator.h: New file.
10857         * objfiles.h (class all_objfiles): New.
10858         (struct objfile_iterator): New.
10859
10860 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10861
10862         * NEWS: Move the description of the changed "frame", "select-frame",
10863          and "info frame" commands to the Changed commands section.
10864
10865 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10866
10867         * gdbtypes.c (check_stub_method_group): Remove handling of old
10868         mangling schemes.
10869         * linespec.c (find_methods): Likewise.
10870         * stabsread.c (read_member_functions): Likewise.
10871         * valops.c (search_struct_method): Likewise.
10872         (value_struct_elt_for_reference): Likewise.
10873         * NEWS: Mention this change.
10874
10875 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10876
10877         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10878         print_source_lines.
10879         * source.c (print_source_lines_base): Update line number check.
10880         (print_source_lines): New function.
10881         (source_lines_range::source_lines_range): New function.
10882         * source.h (class source_lines_range): New class.
10883         (print_source_lines): New declaration.
10884
10885 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10886
10887         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10888
10889 2019-01-08  Tom Tromey  <tom@tromey.com>
10890             Simon Marchi  <simon.marchi@ericsson.com>
10891
10892         PR gdb/24060
10893         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10894         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10895         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10896         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10897         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10898         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10899
10900 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10901
10902         * source.c (select_source_symtab): Move header comment to
10903         declaration in source.h.
10904         (forget_cached_source_info_for_objfile): Likewise.
10905         (forget_cached_source_info): Likewise.
10906         (identify_source_line): Likewise.
10907         * source.h (identify_source_line): Move declaration from symtab.h
10908         and add comment from source.c
10909         (print_source_lines): Likewise.
10910         (forget_cached_source_info_for_objfile): Likewise.
10911         (forget_cached_source_info): Likewise.
10912         (select_source_symtab): Likewise.
10913         (enum print_source_lines_flag): Move definition from symtab.h.
10914         * symtab.h (identify_source_line): Move declaration to source.h.
10915         (print_source_lines): Likewise.
10916         (forget_cached_source_info_for_objfile): Likewise.
10917         (forget_cached_source_info): Likewise.
10918         (select_source_symtab): Likewise.
10919         (enum print_source_lines_flag): Move definition to source.h.
10920         * tui/tui-hooks.c: Add 'source.h' include.
10921
10922 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10923
10924         * source.c (print_source_lines_base): Handle requests to print
10925         reverse line number sequences, and guard against empty lines
10926         string.
10927
10928 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10929
10930         * source.c (print_source_lines_base): Fix skip of '\r' if next
10931         character is '\n'.
10932
10933 2019-01-06  Tom Tromey  <tom@tromey.com>
10934
10935         * c-exp.y (struct c_parse_state) <macro_original_text,
10936         expansion_obstack>: New member.
10937         (macro_original_text, expansion_obstack): Remove globals.
10938         (scan_macro_expansion, scanning_macro_expansion)
10939         (finished_macro_expansion): Update.
10940         (scan_macro_cleanup): Remove.
10941         (yylex, c_parse): Update.
10942
10943 2019-01-06  Tom Tromey  <tom@tromey.com>
10944
10945         * c-exp.y (struct c_parse_state) <strings>: New member.
10946         (operator_stoken): Update.
10947
10948 2019-01-06  Tom Tromey  <tom@tromey.com>
10949
10950         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10951         (union type_stack_elt) <typelist_val>: Now a pointer to
10952         std::vector.
10953         (type_stack_cleanup): Don't declare.
10954         (push_typelist): Update.
10955         * parse.c (pop_typelist): Return a std::vector.
10956         (push_typelist): Take a std::vector.
10957         (follow_types): Update.  Do not free args.
10958         (type_stack_cleanup): Remove.
10959         * c-exp.y (struct c_parse_state): New.
10960         (cpstate): New global.
10961         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10962         (nonempty_typelist): Update.
10963         (func_mod): Create a new vector.
10964         (c_parse): Create a c_parse_state.
10965         (check_parameter_typelist): Do not delete params.
10966         (function_method): Update.  Do not delete type_list.
10967
10968 2019-01-06  Tom Tromey  <tom@tromey.com>
10969
10970         PR gdb/28155:
10971         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10972         check_typedef.
10973         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10974         (print_return_value): Likewise.
10975
10976 2019-01-05  Tom Tromey  <tom@tromey.com>
10977
10978         * contrib/cleanup_check.py: Remove.
10979         * contrib/gcc-with-excheck: Remove.
10980         * contrib/exsummary.py: Remove.
10981         * contrib/excheck.py: Remove.
10982
10983 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10984
10985         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10986         NULL. Initialize tpprev to NULL instead of assigning it
10987         to NULL on the next statement.
10988         * windows-nat.c (windows_delete_thread): Remove check for
10989         main_thread_id before printing thread exit notifications.
10990         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10991         Remove thread ID check against main_thread_id.
10992         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10993         windows_delete_thread.
10994         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10995
10996 2019-01-04  Tom Tromey  <tom@tromey.com>
10997
10998         * compile/compile.c (_initialize_compile): Use upper case for
10999         metasyntactic variables.
11000         * symmisc.c (_initialize_symmisc): Use upper case for
11001         metasyntactic variables.
11002         * psymtab.c (_initialize_psymtab): Use upper case for
11003         metasyntactic variables.
11004         * demangle.c (demangle_command): Use upper case for metasyntactic
11005         variables.
11006         (_initialize_demangler): Likewise.
11007         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11008         variables.
11009
11010 2019-01-03  Tom Tromey  <tom@tromey.com>
11011
11012         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11013
11014 2019-01-03  Tom Tromey  <tom@tromey.com>
11015
11016         * python/py-symtab.c (salpy_str): Update.
11017         (struct salpy_sal_object) <symtab>: Now a PyObject.
11018         (salpy_dealloc): Update.
11019         (del_objfile_sal): Use gdbpy_ref.
11020
11021 2019-01-03  Tom Tromey  <tom@tromey.com>
11022
11023         * python/py-type.c (convert_field): Use new_reference.  Return
11024         gdbpy_ref.
11025         (make_fielditem): Return gdbpy_ref.
11026         (typy_fields): Update.
11027         (typy_getitem): Update.
11028         (field_name): Return gdbpy_ref.  Use new_reference.
11029         (typy_iterator_iternext): Update.
11030
11031 2019-01-03  Tom Tromey  <tom@tromey.com>
11032
11033         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11034
11035 2019-01-03  Tom Tromey  <tom@tromey.com>
11036
11037         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11038         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11039         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11040         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11041         (pspy_set_type_printers): Likewise.
11042         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11043         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11044         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11045         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11046         (objfpy_set_type_printers): Likewise.
11047
11048 2019-01-03  Tom Tromey  <tom@tromey.com>
11049
11050         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11051         (gdbpy_print_stack): Use gdbpy_err_fetch.
11052         * python/python-internal.h (class gdbpy_err_fetch): New class.
11053         (class gdbpy_enter) <m_error_type, m_error_value,
11054         m_error_traceback>: Remove.
11055         <m_error>: New member.
11056         (gdbpy_exception_to_string): Don't declare.
11057         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11058         * python/py-value.c (convert_value_from_python): Use
11059         gdbpy_err_fetch.
11060         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11061         gdbpy_exception_to_string.
11062         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11063         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11064         gdbpy_err_fetch.
11065
11066 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11067
11068         * linux-nat.c (delete_lwp_cleanup): Delete.
11069         (struct lwp_deleter): New struct.
11070         (lwp_info_up): New typedef.
11071         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11072         lwp_info_up.
11073
11074 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11075
11076         * linux-fork.c (class scoped_switch_fork_info): New class.
11077         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11078
11079 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11080
11081         * valops.c (find_overload_match): Remove use of null_cleanup, and
11082         calls to do_cleanups.
11083
11084 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11085
11086         * compile/compile-cplus-types.c
11087         (compile_cplus_instance::decl_name): Handle changes to
11088         cp_func_name.
11089         * cp-support.c (cp_func_name): Update header comment, update
11090         return type.
11091         * cp-support.h (cp_func_name): Update return type in declaration.
11092         * valops.c (find_overload_match): Move temp_func local to top
11093         level of function and change its type.  Use temp_func to hold and
11094         delete temporary string obtained from cp_func_name.
11095
11096 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11097
11098         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11099         gdb::char_vector, remove cleanup, and update uses of `msg`.
11100
11101 2019-01-03  Jim Wilson  <jimw@sifive.com>
11102
11103         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11104
11105 2019-01-02  Tom Tromey  <tom@tromey.com>
11106
11107         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11108         (tdesc_parse_xml): Remove cleanups.
11109         * target-descriptions.h (make_cleanup_free_target_description):
11110         Don't declare.
11111         (target_desc_deleter): New struct.
11112         (target_desc_up): New typedef.
11113         * target-descriptions.c (target_desc_deleter::operator()): Rename
11114         from free_target_description.
11115         (make_cleanup_free_target_description): Remove.
11116
11117 2019-01-02  Tom Tromey  <tom@tromey.com>
11118
11119         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11120         constructor, destructor.
11121         (linespec_parser): Remove typedef.
11122         (~linespec_parser): Rename from linespec_parser_delete.
11123         (linespec_lex_to_end, linespec_complete_label)
11124         (linespec_complete): Update.
11125         (decode_line_full): Remove cleanups.
11126         (decode_line_1): Update.
11127
11128 2019-01-02  Tom Tromey  <tom@tromey.com>
11129
11130         * python/python-internal.h (inferior_to_inferior_object): Change
11131         return type.
11132         * python/py-exitedevent.c (create_exited_event_object): Update.
11133         * python/py-inferior.c (inferior_to_inferior_object): Return
11134         gdbpy_ref.
11135         (python_new_inferior, python_inferior_deleted)
11136         (thread_to_thread_object, delete_thread_object)
11137         (build_inferior_list, gdbpy_selected_inferior): Update.
11138         * python/py-infthread.c (create_thread_object): Update.  Also fail
11139         if inferior_to_inferior_object fails.
11140
11141 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11142
11143         * inferior.h (class inferior) <displaced_step_state>: New field.
11144         * infrun.h (struct displaced_step_state): Move here from
11145         infrun.c.  Initialize fields, add constructor.
11146         <inf>: Remove field.
11147         <reset>: New method.
11148         * infrun.c (struct displaced_step_inferior_state): Move to
11149         infrun.h.
11150         (displaced_step_inferior_states): Remove.
11151         (get_displaced_stepping_state): Adust.
11152         (displaced_step_in_progress_any_inferior): Adjust.
11153         (displaced_step_in_progress_thread): Adjust.
11154         (displaced_step_in_progress): Adjust.
11155         (add_displaced_stepping_state): Remove.
11156         (get_displaced_step_closure_by_addr): Adjust.
11157         (remove_displaced_stepping_state): Remove.
11158         (infrun_inferior_exit): Call displaced_step_state.reset.
11159         (use_displaced_stepping): Don't check for NULL.
11160         (displaced_step_prepare_throw): Call
11161         get_displaced_stepping_state.
11162         (displaced_step_fixup): Don't check for NULL.
11163         (prepare_for_detach): Don't check for NULL.
11164
11165 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11166
11167         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11168          in case of call that did not complete.
11169
11170 2019-01-02  Andrey Utkin  <autkin@undo.io>
11171
11172         * symfile.c (find_separate_debug_file): Fix search of debug files for
11173         remote debuggee.
11174
11175 2019-01-02  Tom Tromey  <tom@tromey.com>
11176
11177         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11178         indentation.
11179         * python/py-frame.c (frapy_older): Remove cast.
11180         (frapy_newer): Likewise.
11181         * python/py-breakpoint.c (local_setattro): Remove cast.
11182         * python/py-arch.c (archpy_name): Remove local variable.
11183         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11184
11185 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11186
11187         * unittests/basic_string_view/element_access/char/empty.cc:
11188         Fix year range in copyright header.
11189
11190 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11191
11192         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11193         Delete.
11194         <operator==>: Update with for removed field.
11195         <hash>: Likewise.
11196         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11197         <isa_features>: ...this.
11198         <abi_features>: New field.
11199         (riscv_isa_flen): Update comment.
11200         (riscv_abi_xlen): New declaration.
11201         (riscv_abi_flen): New declaration.
11202         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11203         isa_features.
11204         (riscv_abi_xlen): New function.
11205         (riscv_isa_flen): Update to get answer from isa_features.
11206         (riscv_abi_flen): New function.
11207         (riscv_has_fp_abi): Update to get answer from abi_features.
11208         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11209         xlen and flen.
11210         (riscv_call_info) <xlen, flen>: Update comment.
11211         (riscv_call_arg_struct): Remove invalid assertions
11212         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11213         is removed.
11214         (riscv_gdbarch_init): Gather isa features and abi features
11215         separately, ensure both match on the gdbarch when reusing an old
11216         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11217         a target with 64-bit float hardware.
11218
11219 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11220
11221         * source.c (search_command_helper): Stop reverse search
11222         when line 1 has been searched.
11223
11224 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11225
11226         * record-full.c (record_full_base_target::close): Rewrite
11227         record_full_core_buf_list free logic.
11228
11229 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11230
11231         * break-catch-syscall.c (print_one_catch_syscall): xfree
11232         the last text.
11233
11234 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11235
11236         * top.c (print_gdb_version): Update Copyright year in version
11237         message.
11238
11239 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11240
11241         Update copyright year range in all GDB files.
11242
11243 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11244
11245         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11246
11247 For older changes see ChangeLog-2018.
11248 \f
11249 Local Variables:
11250 mode: change-log
11251 left-margin: 8
11252 fill-column: 74
11253 version-control: never
11254 coding: utf-8
11255 End:
11256