4e562fc00900c4259d3f1c21cf2b8c004abc166f
[external/binutils.git] / gdb / ChangeLog
1 2019-01-16  Tom Tromey  <tom@tromey.com>
2
3         * objfiles.h (struct objfile) <psymtabs>: New method.
4         (class objfile_psymtabs): Remove.
5         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
6         typedef.
7         <range>: New method.
8         (require_partial_symbols): Change return type.
9         * psymtab.c (require_partial_symbols)
10         (psym_expand_symtabs_matching): Update.
11         * mdebugread.c (parse_partial_symbols): Update.
12         * dbxread.c (dbx_end_psymtab): Update.
13
14 2019-01-15  Tom Tromey  <tom@tromey.com>
15
16         * symtab.c (lookup_objfile_from_block)
17         (lookup_symbol_in_objfile_symtabs)
18         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
19         (find_line_symtab, info_sources_command)
20         (default_collect_symbol_completion_matches_break_on)
21         (make_source_files_completion_list): Update.
22         * symmisc.c (print_objfile_statistics, dump_objfile)
23         (maintenance_print_symbols, maintenance_info_symtabs)
24         (maintenance_check_symtabs, maintenance_info_line_tables):
25         Update.
26         * source.c (select_source_symtab)
27         (forget_cached_source_info_for_objfile): Update.
28         * objfiles.h (class objfile_compunits): Remove.
29         (struct objfile) <compunits_range>: New typedef.
30         (compunits): New method.
31         * objfiles.c (objfile_relocate1): Update.
32         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
33         * maint.c (count_symtabs_and_blocks): Update.
34         * linespec.c (iterate_over_all_matching_symtabs): Update.
35         * cp-support.c (add_symbol_overload_list_qualified): Update.
36         * coffread.c (coff_symtab_read): Update.
37         * ada-lang.c (add_nonlocal_symbols)
38         (ada_collect_symbol_completion_matches)
39         (ada_add_global_exceptions): Update.
40
41 2019-01-15  Tom Tromey  <tom@tromey.com>
42
43         * progspace.h (program_space) <objfiles_safe_range>: New
44         typedef.
45         <objfiles_safe>: New method.
46         * objfiles.h (class all_objfiles_safe): Remove.
47         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
48         * jit.c (jit_inferior_exit_hook): Update.
49
50 2019-01-17  Tom Tromey  <tom@tromey.com>
51
52         * progspace.h (program_space) <objfiles_range>: New typedef.
53         <objfiles>: New method.
54         <objfiles_head>: Rename from objfiles.
55         (object_files): Update.
56         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
57         * guile/scm-pretty-print.c
58         (ppscm_find_pretty_printer_from_objfiles): Update.
59         * guile/scm-objfile.c (gdbscm_objfiles): Update.
60         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
61         Update.
62         * python/py-progspace.c (pspy_get_objfiles): Update.
63         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
64         Update.
65         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
66         (objfpy_lookup_objfile_by_build_id): Update.
67         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
68         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
69         Update.
70         * symtab.c (iterate_over_symtabs, matching_obj_sections)
71         (expand_symtab_containing_pc, lookup_objfile_from_block)
72         (lookup_static_symbol, basic_lookup_transparent_type)
73         (find_pc_sect_compunit_symtab, find_symbol_at_address)
74         (find_line_symtab, info_sources_command)
75         (default_collect_symbol_completion_matches_break_on)
76         (make_source_files_completion_list, find_main_name): Update.
77         * symmisc.c (print_symbol_bcache_statistics)
78         (print_objfile_statistics, maintenance_print_symbols)
79         (maintenance_print_msymbols, maintenance_print_objfiles)
80         (maintenance_info_symtabs, maintenance_check_symtabs)
81         (maintenance_expand_symtabs, maintenance_info_line_tables):
82         Update.
83         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
84         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
85         (map_overlay_command, unmap_overlay_command)
86         (simple_overlay_update, expand_symtabs_matching)
87         (map_symbol_filenames): Update.
88         * symfile-debug.c (set_debug_symfile): Update.
89         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
90         Update.
91         * source.c (select_source_symtab, forget_cached_source_info):
92         Update.
93         * solib.c (solib_read_symbols): Update.
94         * solib-spu.c (append_ocl_sos): Update.
95         * psymtab.c (maintenance_print_psymbols)
96         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
97         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
98         * printcmd.c (info_symbol_command): Update.
99         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
100         Update.
101         * objfiles.h (class all_objfiles): Remove.
102         * objfiles.c (have_partial_symbols, have_full_symbols)
103         (have_minimal_symbols, qsort_cmp, update_section_map)
104         (shared_objfile_contains_address_p)
105         (default_iterate_over_objfiles_in_search_order): Update.
106         * objc-lang.c (info_selectors_command, info_classes_command)
107         (find_methods): Update.
108         * minsyms.c (find_solib_trampoline_target): Update.
109         * maint.c (maintenance_info_sections)
110         (maintenance_translate_address, count_symtabs_and_blocks):
111         Update.
112         * main.c (captured_main_1): Update.
113         * linux-thread-db.c (try_thread_db_load_from_pdir)
114         (has_libpthread): Update.
115         * linespec.c (iterate_over_all_matching_symtabs)
116         (search_minsyms_for_name): Update.
117         * jit.c (jit_find_objf_with_entry_addr): Update.
118         * hppa-tdep.c (find_unwind_entry)
119         (hppa_lookup_stub_minimal_symbol): Update.
120         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
121         Update.
122         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
123         (elf_gnu_ifunc_resolve_by_got): Update.
124         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
125         * dwarf-index-write.c (save_gdb_index_command): Update.
126         * cp-support.c (add_symbol_overload_list_qualified): Update.
127         * breakpoint.c (create_overlay_event_breakpoint)
128         (create_longjmp_master_breakpoint)
129         (create_std_terminate_master_breakpoint)
130         (create_exception_master_breakpoint): Update.
131         * blockframe.c (find_pc_partial_function): Update.
132         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
133         (ada_collect_symbol_completion_matches)
134         (ada_add_global_exceptions): Update.
135
136 2019-01-17  Tom Tromey  <tom@tromey.com>
137
138         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
139         declare VEC.
140         (solib_target_parse_libraries): Change return type.
141         (library_list_start_segment, library_list_start_section)
142         (library_list_end_library, library_list_start_library); Update.
143         (solib_target_free_library_list): Remove.
144         (solib_target_parse_libraries): Remove cleanup.  Change return
145         type.
146         (solib_target_current_sos): Update.
147
148 2019-01-17  Tom Tromey  <tromey@bapiya>
149
150         * valprint.c: Replace "the the" with "the".
151         * symtab.c: Replace "the the" with "the".
152         * solib.c: Replace "the the" with "the".
153         * solib-dsbt.c: Replace "the the" with "the".
154         * linespec.c: Replace "the the" with "the".
155         * dwarf2loc.h: Replace "the the" with "the".
156         * amd64-windows-tdep.c: Replace "the the" with "the".
157         * aarch64-tdep.c: Replace "the the" with "the".
158
159 2019-01-16  Keith Seitz  <keiths@redhat.com>
160
161         PR gdb/23773
162         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
163         <builder>: Rename to ..
164         <m_builder>: ... this and make private.
165         (dwarf2_cu::get_builder): New method.  Change all users of
166         `builder' to use this method.
167         (dwarf2_start_symtab): Move to ...
168         (dwarf2_cu::start_symtab): ... here.  Update all callers
169         (setup_type_unit_groups): Move to ...
170         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
171         callers.
172         (dwarf2_cu::reset_builder): New method.
173         (process_full_compunit, process_full_type_unit): Use
174         dwarf2_cu::reset_builder.
175         (follow_die_offset): Record the ancestor CU if it is different
176         from the followed DIE's CU.
177         (follow_die_sig_1): Likewise.
178
179 2019-01-15  Tom Tromey  <tom@tromey.com>
180
181         * remote.c (class remote_state) <buf>: Now a char_vector.
182         <buf_size>: Remove.
183         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
184         parameter.
185         (remote_target::getpkt_or_notif_sane_1)
186         (remote_target::getpkt_sane)
187         (remote_target::getpkt_or_notif_sane): Likewise.
188         (class remote_target) <putpkt>: New overload.
189         (remote_target::read_frame): Change type of "buf_p".  Remove
190         sizeof_p parameter.
191         (packet_ok): New overload.
192         (packet_check_result): New overload.
193         Update all uses.
194
195 2019-01-14  Tom Tromey  <tom@tromey.com>
196
197         * remote-notif.c (handle_notification, remote_notif_ack)
198         (remote_notif_parse): Make "buf" const.
199         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
200         const.
201         (remote_notif_parse, remote_notif_ack, handle_notification):
202         Likewise.
203         * remote.c (remote_notif_stop_parse): Make "buf" const.
204         (remote_target::remote_parse_stop_reply): Make "buf" const.
205         (remote_notif_stop_ack): Make "buf" const.
206
207 2019-01-14  Tom Tromey  <tom@tromey.com>
208
209         * remote.c (remote_console_output): Make parameter const.
210
211 2019-01-14  Tom Tromey  <tom@tromey.com>
212
213         * target-debug.h (target_debug_print_signals): Constify.
214         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
215         * procfs.c (procfs_target::pass_signals): Update.
216         * linux-nat.c (linux_nat_target::pass_signals): Update.
217         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
218         * target-delegates.c: Rebuild.
219         * remote.c (remote_target::program_signals): Update.
220         (remote_target::pass_signals): Update.
221         * target.c (target_pass_signals): Constify argument.
222         (target_program_signals): Likewise.
223         * target.h (struct target_ops) <pass_signals, program_signals>:
224         Constify argument.
225         (target_pass_signals, target_program_signals): Constify argument.
226
227 2019-01-14  Tom Tromey  <tom@tromey.com>
228
229         PR tui/28819:
230         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
231
232 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
233
234         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
235         field.
236         * rs6000-tdep.c: Include reggroups.h.
237         (IS_V_ALIAS_PSEUDOREG): Define.
238         (rs6000_register_name): Return names for the "vX" aliases.
239         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
240         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
241         aliases.  Call default_register_reggroup_p for all other
242         pseudo-registers.
243         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
244         New functions.
245         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
246         Handle "vX" aliases.
247         (v_alias_pseudo_register_collect): New function.
248         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
249         (rs6000_gdbarch_init): Initialize "vX" aliases as
250         pseudo-registers.  Restore registration of
251         rs6000_pseudo_register_reggroup_p with
252         set_tdesc_pseudo_register_reggroup_p.
253
254 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
255
256         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
257         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
258         set_gdbarch_num_pseudo_regs.
259
260 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
261
262         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
263         Remove arg prefixname, add do_set and do_show.
264         Add member functions set_list and show_list.
265         * cli/cli-style.c (class cli_style_option): Update accordingly.
266         (style_set_list): Move to file scope.
267         (style_show_list): Likewise.
268         (set_style): Call help_list.
269         (show_style): Call cmd_show_list.
270         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
271         Update to use the new macro.
272
273 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
274
275         * ada-lang.c (_initialize_ada_language): Expand the help text
276         for the "catch exception" command.
277
278 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
279
280         * symtab.c (matching_obj_sections): Initialize obj,
281         declare it closer to its usage.
282
283 2019-01-10  Tom Tromey  <tom@tromey.com>
284
285         * thread-iter.h (inf_threads_iterator): Use next_iterator.
286         (basic_inf_threads_range): Remove.
287         (inf_threads_range, inf_non_exited_threads_range)
288         (safe_inf_threads_range): Use next_adapter.
289
290 2019-01-10  Keith Seitz  <keiths@redhat.com>
291
292         PR gdb/23712
293         PR symtab/23010
294         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
295         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
296
297 2019-01-10  Keith Seitz  <keiths@redhat.com>
298
299         PR gdb/23712
300         PR symtab/23010
301         * dictionary.c (pending_to_vector): Remove.
302         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
303         Remove _1 suffix, replacing functions of the same name.  Update
304         all callers.
305         (dict_create_hashed, dict_create_hashed_expandable)
306         (dict_create_linear, dict_create_linear_expandable, dict_free)
307         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
308         Make functions static.
309
310 2019-01-10  Keith Seitz  <keiths@redhat.com>
311
312         PR gdb/23712
313         PR symtab/23010
314         * dictionary.h (struct dictionary): Replace declaration with
315         multidictionary.
316         (dict_create_hashed, dict_create_hashed_expandable)
317         (dict_create_linear, dict_create_linear_expandable)
318         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
319         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
320         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
321         taking multidictionary argument.
322         [ALL_DICT_SYMBOLS]: Update for multidictionary.
323         * block.h (struct block) <dict>: Change to multidictionary
324         and rename `multidict'.
325         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
326         symmisc.c: Update all dictionary references to multidictionary.
327
328 2019-01-10  Keith Seitz  <keiths@redhat.com>
329
330         PR gdb/23712
331         PR symtab/23010
332         * dictionary.c: Include unordered_map.
333         (pending_to_vector): New function.
334         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
335         Rewrite the non-"_1" functions to take vector instead
336         of linked list.
337         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
338         "new" _1 versions of the same name.
339         (multidictionary): Define.
340         (std::hash<enum language): New definition.
341         (collate_pending_symbols_by_language, mdict_create_hashed)
342         (mdict_create_hashed_expandable, mdict_create_linear)
343         (mdict_create_linear_expandable, mdict_free)
344         (find_language_dictionary, create_new_language_dictionary)
345         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
346         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
347         (mdict_size, mdict_empty): New functions.
348         * dictionary.h (mdict_iterator): Define.
349
350 2019-01-10  Pedro Alves  <palves@redhat.com>
351
352         * breakpoint.c (read_uploaded_action)
353         (create_tracepoint_from_upload): Adjust to use
354         gdb::unique_xmalloc_ptr.
355         * ctf.c (ctf_write_uploaded_tp):
356         (SET_ARRAY_FIELD): Use emplace_back.
357         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
358         * tracefile-tfile.c (tfile_write_uploaded_tp):
359         * tracepoint.c (parse_tracepoint_definition): Adjust to use
360         gdb::unique_xmalloc_ptr.
361         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
362         at_string, cond_string, cmd_strings>: Replace char pointers
363         with gdb::unique_xmalloc_ptr.
364
365 2019-01-10  Pedro Alves  <palves@redhat.com>
366
367         * solib-target.c (library_list_start_library): Don't xstrdup name.
368
369 2019-01-10  Pedro Alves  <palves@redhat.com>
370
371         * mdebugread.c (parse_partial_symbols): Use
372         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
373
374 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
375
376         * linux-fork.c (scoped_switch_fork_info)
377         <~scoped_switch_fork_info>: Fix incorrect variable name.
378
379 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
380
381         * linux-fork.c (scoped_switch_fork_info)
382         <scoped_switch_fork_info>: Make explicit.
383         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
384
385 2019-01-10  Tom Tromey  <tom@tromey.com>
386
387         * objfiles.h (objfile::reset_psymtabs): Update.
388         * objfiles.c (objfile::objfile): Update.
389         * psymtab.h (psymtab_storage::obstack): Update.
390         (psymtab_storage::m_obstack): Use gdb::optional.
391         (class psymtab_storage): Update comment.  Remove objfile
392         parameter.
393         * psymtab.c (psymtab_storage::psymtab_storage): Update.
394
395 2019-01-10  Tom Tromey  <tom@tromey.com>
396
397         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
398         <free_psymtabs>: Now private.
399         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
400         (allocate_psymtab): Use new method.
401
402 2019-01-10  Tom Tromey  <tom@tromey.com>
403
404         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
405         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
406         * mdebugread.c (parse_partial_symbols): Use
407         allocate_dependencies.
408         * dwarf2read.c (dwarf2_create_include_psymtab): Use
409         allocate_dependencies.
410         (process_psymtab_comp_unit_reader)
411         (build_type_psymtab_dependencies): Likewise.
412         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
413
414 2019-01-10  Tom Tromey  <tom@tromey.com>
415
416         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
417         PSYMBOL_SET_LANGUAGE.
418         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
419
420 2019-01-10  Tom Tromey  <tom@tromey.com>
421
422         * psymtab.h (psymtab_storage::obstack): New method.
423         <m_obstack>: Rename from obstack; now private.
424         * psymtab.c (psymtab_storage): Update.
425         * dwarf2read.c (create_addrmap_from_index)
426         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
427         Update.
428
429 2019-01-10  Tom Tromey  <tom@tromey.com>
430
431         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
432         * objfiles.h (objfile::reset_psymtabs): New method.
433
434 2019-01-10  Tom Tromey  <tom@tromey.com>
435
436         * symmisc.c (print_symbol_bcache_statistics): Update.
437         (print_objfile_statistics): Update.
438         * symfile.c (reread_symbols): Update.
439         * psymtab.h (class psymtab_storage): New.
440         * psymtab.c (psymtab_storage): New constructor.
441         (~psymtab_storage): New destructor.
442         (require_partial_symbols): Update.
443         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
444         (find_pc_sect_psymtab, find_pc_sect_psymbol)
445         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
446         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
447         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
448         (start_psymtab_common, end_psymtab_common)
449         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
450         (allocate_psymtab): Update.
451         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
452         Update.
453         (dump_psymtab_addrmap, maintenance_print_psymbols)
454         (maintenance_check_psymtabs): Update.
455         (class objfile_psymtabs): Move to objfiles.h.
456         * psympriv.h (discard_psymtab): Now inline.
457         (psymtab_discarder::psymtab_discarder): Update.
458         (psymtab_discarder::~psymtab_discarder): Update.
459         (ALL_OBJFILE_PSYMTABS): Rewrite.
460         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
461         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
462         Remove fields.
463         <partial_symtabs>: New field.
464         (class objfile_psymtabs): Move from psymtab.h.  Update.
465         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
466         psymbol_cache.
467         (objfile::~objfile): Don't destroy psymbol_cache.
468         * mdebugread.c (parse_partial_symbols): Update.
469         * dwarf2read.c (create_addrmap_from_index)
470         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
471         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
472         (add_partial_subprogram, dwarf2_ranges_read): Update.
473         * dwarf-index-write.c (write_address_map)
474         (write_one_signatured_type, recursively_write_psymbols)
475         (class debug_names, class debug_names, write_psymtabs_to_index):
476         Update.
477
478 2019-01-10  Tom Tromey  <tom@tromey.com>
479
480         * symtab.h (SYMBOL_SET_NAMES): Update.
481         (symbol_set_names): Update.
482         (MSYMBOL_SET_NAMES): Update.
483         * symtab.c (symbol_set_names): Change argument to be an
484         objfile_per_bfd_storage.
485         * psymtab.c (add_psymbol_to_bcache): Update.
486         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
487
488 2019-01-10  Tom Tromey  <tom@tromey.com>
489
490         * symtab.c (create_demangled_names_hash): Change argument to be an
491         objfile_per_bfd_storage.
492         (symbol_set_names): Update.
493
494 2019-01-10  Tom Tromey  <tom@tromey.com>
495
496         * xcoffread.c (xcoff_initial_scan): Unconditionally call
497         init_psymbol_list.
498         * psymtab.c (init_psymbol_list): Do nothing if already called.
499         * psympriv.h (init_psymbol_list): Add comment.
500         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
501         init_psymbol_list.
502         * dbxread.c (dbx_symfile_read): Unconditionally call
503         init_psymbol_list.
504
505 2019-01-10  Tom Tromey  <tom@tromey.com>
506
507         * xcoffread.c (scan_xcoff_symtab): Update.
508         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
509         "where".
510         * mdebugread.c (parse_partial_symbols)
511         (handle_psymbol_enumerators): Update.
512         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
513         * dbxread.c (read_dbx_symtab): Update.
514         * psympriv.h (psymbol_placement): New enum.
515         (add_psymbol_to_list): Update.
516
517 2019-01-10  Tom Tromey  <tom@tromey.com>
518
519         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
520         static_psymbols parameters.
521         (scan_xcoff_symtab): Update.
522         * psymtab.c (start_psymtab_common): Remove global_psymbols and
523         static_psymbols parameters.
524         * psympriv.h (start_psymtab_common): Update.
525         * mdebugread.c (parse_partial_symbols): Update.
526         * dwarf2read.c (create_partial_symtab): Update.
527         * dbxread.c (read_dbx_symtab): Update.
528         (start_psymtab): Remove global_psymbols and static_psymbols
529         parameters.
530
531 2019-01-10  Tom Tromey  <tom@tromey.com>
532
533         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
534         * psymtab.c (allocate_psymtab): Add comment.
535         * psympriv.h (allocate_psymtab): Add comment.
536         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
537         initializations.
538         * dbxread.c (dbx_end_psymtab): Remove some initializations.
539
540 2019-01-10  Tom Tromey  <tom@tromey.com>
541
542         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
543         Don't declare.
544         * mipsread.c: Include mdebugread.h.
545         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
546         Declare.
547         * elfread.c: Include mdebugread.h.
548
549 2019-01-09  Tom Tromey  <tom@tromey.com>
550
551         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
552         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
553         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
554         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
555         (psym_lookup_symbol, psym_find_last_source_symtab)
556         (psym_forget_cached_source_info, psym_print_stats)
557         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
558         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
559         (psym_map_matching_symbols, psym_expand_symtabs_matching)
560         (psym_find_compunit_symtab_by_address)
561         (maintenance_print_psymbols, maintenance_info_psymtabs)
562         (maintenance_check_psymtabs): Use ranged for.
563         * psymtab.h (class objfile_psymtabs): New.
564         (require_partial_symbols): Return objfile_psymtabs.
565         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
566
567 2019-01-09  Tom Tromey  <tom@tromey.com>
568
569         * symfile.c (overlay_invalidate_all, find_pc_overlay)
570         (find_pc_mapped_section, list_overlays_command)
571         (map_overlay_command, unmap_overlay_command)
572         (simple_overlay_update): Use all_objfiles.
573         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
574         * printcmd.c (info_symbol_command): Use all_objfiles.
575         * objfiles.h (ALL_OBJSECTIONS): Remove.
576         * maint.c (maintenance_translate_address): Use all_objfiles.
577         * gcore.c (gcore_create_callback): Use all_objfiles.
578         (objfile_find_memory_regions): Likewise.
579
580 2019-01-09  Tom Tromey  <tom@tromey.com>
581
582         * symtab.c (find_line_symtab, info_sources_command)
583         (make_source_files_completion_list): Use objfile_compunits.
584         * source.c (select_source_symtab): Use objfile_compunits.
585         * objfiles.h (struct objfile): Update comment.
586         (ALL_OBJFILES): Remove.
587         (ALL_FILETABS): Remove.
588         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
589         objfile_compunits.
590
591 2019-01-09  Tom Tromey  <tom@tromey.com>
592
593         * symmisc.c (print_objfile_statistics, dump_objfile)
594         (maintenance_print_symbols): Use compunit_filetabs.
595         * source.c (forget_cached_source_info_for_objfile): Use
596         compunit_filetabs.
597         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
598         (ALL_FILETABS): Use compunit_filetabs.
599         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
600         * coffread.c (coff_symtab_read): Use compunit_filetabs.
601
602 2019-01-09  Tom Tromey  <tom@tromey.com>
603
604         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
605         (compunit_filetabs): New.
606         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
607         compunit_filetabs.
608         (info_sources_command, make_source_files_completion_list): Remove
609         declaration.
610         * symmisc.c (print_objfile_statistics, dump_objfile)
611         (maintenance_print_symbols): Remove declaration.
612         (maintenance_info_symtabs): Use compunit_filetabs.
613         (maintenance_info_line_tables): Likewise.
614         * source.c (select_source_symtab): Change local variable name.
615         (forget_cached_source_info_for_objfile): Remove declaration.
616         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
617         * objfiles.c (objfile_relocate1): Remove declaration.
618         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
619         declaration.
620         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
621         * coffread.c (coff_symtab_read): Remove declaration.
622         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
623         compunit_filetabs.
624
625 2019-01-09  Tom Tromey  <tom@tromey.com>
626
627         * symtab.c (lookup_objfile_from_block)
628         (find_pc_sect_compunit_symtab, search_symbols)
629         (default_collect_symbol_completion_matches_break_on): Use
630         objfile_compunits.
631         * objfiles.h (ALL_COMPUNITS): Remove.
632         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
633         * cp-support.c (add_symbol_overload_list_qualified): Use
634         objfile_compunits.
635         * ada-lang.c (ada_collect_symbol_completion_matches)
636         (ada_add_global_exceptions): Use objfile_compunits.
637
638 2019-01-09  Tom Tromey  <tom@tromey.com>
639
640         * source.c (select_source_symtab)
641         (forget_cached_source_info_for_objfile): Remove declaration.
642         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
643         declaration.
644         * maint.c (count_symtabs_and_blocks): Remove declaration.
645         * cp-support.c (add_symbol_overload_list_qualified): Remove
646         declaration.
647         * coffread.c (coff_symtab_read): Remove declaration.
648         * symtab.c (lookup_symbol_in_objfile_symtabs)
649         (basic_lookup_transparent_type_1): Use objfile_compunits.
650         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
651         (info_sources_command, search_symbols)
652         (default_collect_symbol_completion_matches_break_on)
653         (make_source_files_completion_list): Remove declaration.
654         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
655         (ada_collect_symbol_completion_matches)
656         (ada_add_global_exceptions): Remove declaration.
657         * linespec.c (iterate_over_all_matching_symtabs): Use
658         objfile_compunits.
659         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
660         (class objfile_compunits): New.
661         (ALL_COMPUNITS): Use objfile_compunits.
662         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
663         (maintenance_check_symtabs, maintenance_info_line_tables): Use
664         objfile_compunits.
665         * objfiles.c (objfile_relocate1): Use objfile_compunits.
666
667 2019-01-09  Tom Tromey  <tom@tromey.com>
668
669         * symtab.c (search_symbols)
670         (default_collect_symbol_completion_matches_break_on): Use
671         objfile_msymbols.
672         * ada-lang.c (ada_lookup_simple_minsym)
673         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
674         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
675         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
676         objfile_msymbols.
677         * coffread.c (coff_symfile_read): Use objfile_msymbols.
678         * symmisc.c (dump_msymbols): Use objfile_msymbols.
679         * objc-lang.c (find_methods): Use objfile_msymbols.
680         (info_selectors_command, info_classes_command): Likewise.
681         * stabsread.c (scan_file_globals): Use objfile_msymbols.
682         * objfiles.h (class objfile_msymbols): New.
683         (ALL_OBJFILE_MSYMBOLS): Remove.
684         (ALL_MSYMBOLS): Remove.
685
686 2019-01-09  Tom Tromey  <tom@tromey.com>
687
688         * common/next-iterator.h (next_adapter): Add Iterator template
689         parameter.
690         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
691         (class all_objfiles_safe): New.
692         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
693         * objfiles.c (put_objfile_before): Update comment.
694         (add_separate_debug_objfile): Likewise.
695         (free_all_objfiles): Use all_objfiles_safe.
696         (objfile_purge_solibs): Likewise.
697
698 2019-01-09  Tom Tromey  <tom@tromey.com>
699
700         * symtab.c (iterate_over_symtabs, matching_obj_sections)
701         (expand_symtab_containing_pc, lookup_static_symbol)
702         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
703         (find_symbol_at_address, find_line_symtab, find_main_name): Use
704         all_objfiles.
705         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
706         * breakpoint.c (create_overlay_event_breakpoint)
707         (create_longjmp_master_breakpoint)
708         (create_std_terminate_master_breakpoint)
709         (create_exception_master_breakpoint): Use all_objfiles.
710         * linux-thread-db.c (try_thread_db_load_from_pdir)
711         (has_libpthread): Use all_objfiles.
712         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
713         * linespec.c (iterate_over_all_matching_symtabs)
714         (search_minsyms_for_name): Use all_objfiles.
715         * maint.c (maintenance_info_sections): Use all_objfiles.
716         * main.c (captured_main_1): Use all_objfiles.
717         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
718         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
719         * guile/scm-pretty-print.c
720         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
721         * solib-spu.c (append_ocl_sos): Use all_objfiles.
722         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
723         (maintenance_print_msymbols): Use all_objfiles.
724         * source.c (select_source_symtab): Use all_objfiles.
725         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
726         * symfile.c (remove_symbol_file_command)
727         (expand_symtabs_matching, map_symbol_filenames): Use
728         all_objfiles.
729         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
730         all_objfiles.
731         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
732         * objc-lang.c (find_methods): Use all_objfiles.
733         * objfiles.c (have_partial_symbols, have_full_symbols)
734         (have_minimal_symbols, qsort_cmp)
735         (default_iterate_over_objfiles_in_search_order): Use
736         all_objfiles.
737         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
738         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
739         (maintenance_check_psymtabs): Use all_objfiles.
740         (ALL_PSYMTABS): Remove.
741         * compile/compile-object-run.c (do_module_cleanup): Use
742         all_objfiles.
743         * blockframe.c (find_pc_partial_function): Use all_objfiles.
744         * cp-support.c (add_symbol_overload_list_qualified): Use
745         all_objfiles.
746         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
747         Use all_objfiles.
748         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
749         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
750         all_objfiles.
751         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
752         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
753         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
754         Uses all_objfiles.
755         * solib.c (solib_read_symbols): Use all_objfiles
756
757 2019-01-09  Tom Tromey  <tom@tromey.com>
758
759         * probe.c (parse_probes_in_pspace): Use all_objfiles.
760         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
761         all_objfiles.
762         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
763         * symmisc.c (print_symbol_bcache_statistics)
764         (print_objfile_statistics, maintenance_print_objfiles)
765         (maintenance_info_symtabs, maintenance_check_symtabs)
766         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
767         all_objfiles.
768         * source.c (forget_cached_source_info): Use all_objfiles.
769         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
770         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
771         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
772         * objfiles.c (update_section_map): Use all_objfiles.
773         (shared_objfile_contains_address_p): Likewise.
774         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
775         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
776
777 2019-01-09  Tom Tromey  <tom@tromey.com>
778
779         * common/next-iterator.h: New file.
780         * objfiles.h (class all_objfiles): New.
781         (struct objfile_iterator): New.
782
783 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
784
785         * NEWS: Move the description of the changed "frame", "select-frame",
786          and "info frame" commands to the Changed commands section.
787
788 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
789
790         * gdbtypes.c (check_stub_method_group): Remove handling of old
791         mangling schemes.
792         * linespec.c (find_methods): Likewise.
793         * stabsread.c (read_member_functions): Likewise.
794         * valops.c (search_struct_method): Likewise.
795         (value_struct_elt_for_reference): Likewise.
796         * NEWS: Mention this change.
797
798 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
799
800         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
801         print_source_lines.
802         * source.c (print_source_lines_base): Update line number check.
803         (print_source_lines): New function.
804         (source_lines_range::source_lines_range): New function.
805         * source.h (class source_lines_range): New class.
806         (print_source_lines): New declaration.
807
808 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
809
810         * linespec.c (linespec_state_destructor): Free self->canonical_names.
811
812 2019-01-08  Tom Tromey  <tom@tromey.com>
813             Simon Marchi  <simon.marchi@ericsson.com>
814
815         PR gdb/24060
816         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
817         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
818         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
819         * f-exp.y (DOLLAR_VARIABLE): Likewise.
820         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
821         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
822
823 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
824
825         * source.c (select_source_symtab): Move header comment to
826         declaration in source.h.
827         (forget_cached_source_info_for_objfile): Likewise.
828         (forget_cached_source_info): Likewise.
829         (identify_source_line): Likewise.
830         * source.h (identify_source_line): Move declaration from symtab.h
831         and add comment from source.c
832         (print_source_lines): Likewise.
833         (forget_cached_source_info_for_objfile): Likewise.
834         (forget_cached_source_info): Likewise.
835         (select_source_symtab): Likewise.
836         (enum print_source_lines_flag): Move definition from symtab.h.
837         * symtab.h (identify_source_line): Move declaration to source.h.
838         (print_source_lines): Likewise.
839         (forget_cached_source_info_for_objfile): Likewise.
840         (forget_cached_source_info): Likewise.
841         (select_source_symtab): Likewise.
842         (enum print_source_lines_flag): Move definition to source.h.
843         * tui/tui-hooks.c: Add 'source.h' include.
844
845 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
846
847         * source.c (print_source_lines_base): Handle requests to print
848         reverse line number sequences, and guard against empty lines
849         string.
850
851 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
852
853         * source.c (print_source_lines_base): Fix skip of '\r' if next
854         character is '\n'.
855
856 2019-01-06  Tom Tromey  <tom@tromey.com>
857
858         * c-exp.y (struct c_parse_state) <macro_original_text,
859         expansion_obstack>: New member.
860         (macro_original_text, expansion_obstack): Remove globals.
861         (scan_macro_expansion, scanning_macro_expansion)
862         (finished_macro_expansion): Update.
863         (scan_macro_cleanup): Remove.
864         (yylex, c_parse): Update.
865
866 2019-01-06  Tom Tromey  <tom@tromey.com>
867
868         * c-exp.y (struct c_parse_state) <strings>: New member.
869         (operator_stoken): Update.
870
871 2019-01-06  Tom Tromey  <tom@tromey.com>
872
873         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
874         (union type_stack_elt) <typelist_val>: Now a pointer to
875         std::vector.
876         (type_stack_cleanup): Don't declare.
877         (push_typelist): Update.
878         * parse.c (pop_typelist): Return a std::vector.
879         (push_typelist): Take a std::vector.
880         (follow_types): Update.  Do not free args.
881         (type_stack_cleanup): Remove.
882         * c-exp.y (struct c_parse_state): New.
883         (cpstate): New global.
884         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
885         (nonempty_typelist): Update.
886         (func_mod): Create a new vector.
887         (c_parse): Create a c_parse_state.
888         (check_parameter_typelist): Do not delete params.
889         (function_method): Update.  Do not delete type_list.
890
891 2019-01-06  Tom Tromey  <tom@tromey.com>
892
893         PR gdb/28155:
894         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
895         check_typedef.
896         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
897         (print_return_value): Likewise.
898
899 2019-01-05  Tom Tromey  <tom@tromey.com>
900
901         * contrib/cleanup_check.py: Remove.
902         * contrib/gcc-with-excheck: Remove.
903         * contrib/exsummary.py: Remove.
904         * contrib/excheck.py: Remove.
905
906 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
907
908         * thread.c (delete_thread_1): Add gdb_assert that THR is not
909         NULL. Initialize tpprev to NULL instead of assigning it
910         to NULL on the next statement.
911         * windows-nat.c (windows_delete_thread): Remove check for
912         main_thread_id before printing thread exit notifications.
913         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
914         Remove thread ID check against main_thread_id.
915         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
916         windows_delete_thread.
917         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
918
919 2019-01-04  Tom Tromey  <tom@tromey.com>
920
921         * compile/compile.c (_initialize_compile): Use upper case for
922         metasyntactic variables.
923         * symmisc.c (_initialize_symmisc): Use upper case for
924         metasyntactic variables.
925         * psymtab.c (_initialize_psymtab): Use upper case for
926         metasyntactic variables.
927         * demangle.c (demangle_command): Use upper case for metasyntactic
928         variables.
929         (_initialize_demangler): Likewise.
930         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
931         variables.
932
933 2019-01-03  Tom Tromey  <tom@tromey.com>
934
935         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
936
937 2019-01-03  Tom Tromey  <tom@tromey.com>
938
939         * python/py-symtab.c (salpy_str): Update.
940         (struct salpy_sal_object) <symtab>: Now a PyObject.
941         (salpy_dealloc): Update.
942         (del_objfile_sal): Use gdbpy_ref.
943
944 2019-01-03  Tom Tromey  <tom@tromey.com>
945
946         * python/py-type.c (convert_field): Use new_reference.  Return
947         gdbpy_ref.
948         (make_fielditem): Return gdbpy_ref.
949         (typy_fields): Update.
950         (typy_getitem): Update.
951         (field_name): Return gdbpy_ref.  Use new_reference.
952         (typy_iterator_iternext): Update.
953
954 2019-01-03  Tom Tromey  <tom@tromey.com>
955
956         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
957
958 2019-01-03  Tom Tromey  <tom@tromey.com>
959
960         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
961         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
962         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
963         (pspy_set_frame_filters, pspy_set_frame_unwinders)
964         (pspy_set_type_printers): Likewise.
965         * python/py-function.c (fnpy_init): Use gdbpy_ref.
966         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
967         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
968         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
969         (objfpy_set_type_printers): Likewise.
970
971 2019-01-03  Tom Tromey  <tom@tromey.com>
972
973         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
974         (gdbpy_print_stack): Use gdbpy_err_fetch.
975         * python/python-internal.h (class gdbpy_err_fetch): New class.
976         (class gdbpy_enter) <m_error_type, m_error_value,
977         m_error_traceback>: Remove.
978         <m_error>: New member.
979         (gdbpy_exception_to_string): Don't declare.
980         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
981         * python/py-value.c (convert_value_from_python): Use
982         gdbpy_err_fetch.
983         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
984         gdbpy_exception_to_string.
985         (gdbpy_handle_exception): Use gdbpy_err_fetch.
986         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
987         gdbpy_err_fetch.
988
989 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
990
991         * linux-nat.c (delete_lwp_cleanup): Delete.
992         (struct lwp_deleter): New struct.
993         (lwp_info_up): New typedef.
994         (linux_nat_target::follow_fork): Delete cleanup, and make use of
995         lwp_info_up.
996
997 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
998
999         * linux-fork.c (class scoped_switch_fork_info): New class.
1000         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
1001
1002 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1003
1004         * valops.c (find_overload_match): Remove use of null_cleanup, and
1005         calls to do_cleanups.
1006
1007 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1008
1009         * compile/compile-cplus-types.c
1010         (compile_cplus_instance::decl_name): Handle changes to
1011         cp_func_name.
1012         * cp-support.c (cp_func_name): Update header comment, update
1013         return type.
1014         * cp-support.h (cp_func_name): Update return type in declaration.
1015         * valops.c (find_overload_match): Move temp_func local to top
1016         level of function and change its type.  Use temp_func to hold and
1017         delete temporary string obtained from cp_func_name.
1018
1019 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1020
1021         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
1022         gdb::char_vector, remove cleanup, and update uses of `msg`.
1023
1024 2019-01-03  Jim Wilson  <jimw@sifive.com>
1025
1026         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
1027
1028 2019-01-02  Tom Tromey  <tom@tromey.com>
1029
1030         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
1031         (tdesc_parse_xml): Remove cleanups.
1032         * target-descriptions.h (make_cleanup_free_target_description):
1033         Don't declare.
1034         (target_desc_deleter): New struct.
1035         (target_desc_up): New typedef.
1036         * target-descriptions.c (target_desc_deleter::operator()): Rename
1037         from free_target_description.
1038         (make_cleanup_free_target_description): Remove.
1039
1040 2019-01-02  Tom Tromey  <tom@tromey.com>
1041
1042         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
1043         constructor, destructor.
1044         (linespec_parser): Remove typedef.
1045         (~linespec_parser): Rename from linespec_parser_delete.
1046         (linespec_lex_to_end, linespec_complete_label)
1047         (linespec_complete): Update.
1048         (decode_line_full): Remove cleanups.
1049         (decode_line_1): Update.
1050
1051 2019-01-02  Tom Tromey  <tom@tromey.com>
1052
1053         * python/python-internal.h (inferior_to_inferior_object): Change
1054         return type.
1055         * python/py-exitedevent.c (create_exited_event_object): Update.
1056         * python/py-inferior.c (inferior_to_inferior_object): Return
1057         gdbpy_ref.
1058         (python_new_inferior, python_inferior_deleted)
1059         (thread_to_thread_object, delete_thread_object)
1060         (build_inferior_list, gdbpy_selected_inferior): Update.
1061         * python/py-infthread.c (create_thread_object): Update.  Also fail
1062         if inferior_to_inferior_object fails.
1063
1064 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
1065
1066         * inferior.h (class inferior) <displaced_step_state>: New field.
1067         * infrun.h (struct displaced_step_state): Move here from
1068         infrun.c.  Initialize fields, add constructor.
1069         <inf>: Remove field.
1070         <reset>: New method.
1071         * infrun.c (struct displaced_step_inferior_state): Move to
1072         infrun.h.
1073         (displaced_step_inferior_states): Remove.
1074         (get_displaced_stepping_state): Adust.
1075         (displaced_step_in_progress_any_inferior): Adjust.
1076         (displaced_step_in_progress_thread): Adjust.
1077         (displaced_step_in_progress): Adjust.
1078         (add_displaced_stepping_state): Remove.
1079         (get_displaced_step_closure_by_addr): Adjust.
1080         (remove_displaced_stepping_state): Remove.
1081         (infrun_inferior_exit): Call displaced_step_state.reset.
1082         (use_displaced_stepping): Don't check for NULL.
1083         (displaced_step_prepare_throw): Call
1084         get_displaced_stepping_state.
1085         (displaced_step_fixup): Don't check for NULL.
1086         (prepare_for_detach): Don't check for NULL.
1087
1088 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1089
1090         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
1091          in case of call that did not complete.
1092
1093 2019-01-02  Andrey Utkin  <autkin@undo.io>
1094
1095         * symfile.c (find_separate_debug_file): Fix search of debug files for
1096         remote debuggee.
1097
1098 2019-01-02  Tom Tromey  <tom@tromey.com>
1099
1100         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
1101         indentation.
1102         * python/py-frame.c (frapy_older): Remove cast.
1103         (frapy_newer): Likewise.
1104         * python/py-breakpoint.c (local_setattro): Remove cast.
1105         * python/py-arch.c (archpy_name): Remove local variable.
1106         * python/py-type.c (gdbpy_lookup_type): Remove cast.
1107
1108 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
1109
1110         * unittests/basic_string_view/element_access/char/empty.cc:
1111         Fix year range in copyright header.
1112
1113 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1114
1115         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
1116         Delete.
1117         <operator==>: Update with for removed field.
1118         <hash>: Likewise.
1119         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
1120         <isa_features>: ...this.
1121         <abi_features>: New field.
1122         (riscv_isa_flen): Update comment.
1123         (riscv_abi_xlen): New declaration.
1124         (riscv_abi_flen): New declaration.
1125         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
1126         isa_features.
1127         (riscv_abi_xlen): New function.
1128         (riscv_isa_flen): Update to get answer from isa_features.
1129         (riscv_abi_flen): New function.
1130         (riscv_has_fp_abi): Update to get answer from abi_features.
1131         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
1132         xlen and flen.
1133         (riscv_call_info) <xlen, flen>: Update comment.
1134         (riscv_call_arg_struct): Remove invalid assertions
1135         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
1136         is removed.
1137         (riscv_gdbarch_init): Gather isa features and abi features
1138         separately, ensure both match on the gdbarch when reusing an old
1139         gdbarch.  Relax an error check to allow 32-bit abi float to run on
1140         a target with 64-bit float hardware.
1141
1142 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1143
1144         * source.c (search_command_helper): Stop reverse search
1145         when line 1 has been searched.
1146
1147 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1148
1149         * record-full.c (record_full_base_target::close): Rewrite
1150         record_full_core_buf_list free logic.
1151
1152 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1153
1154         * break-catch-syscall.c (print_one_catch_syscall): xfree
1155         the last text.
1156
1157 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1158
1159         * top.c (print_gdb_version): Update Copyright year in version
1160         message.
1161
1162 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1163
1164         Update copyright year range in all GDB files.
1165
1166 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
1167
1168         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
1169
1170 For older changes see ChangeLog-2018.
1171 \f
1172 Local Variables:
1173 mode: change-log
1174 left-margin: 8
1175 fill-column: 74
1176 version-control: never
1177 coding: utf-8
1178 End:
1179