gdb/ChangeLog

   1 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
   2
   3         The MS-Windows port of ncurses fails to switch to a color pair if
   4         one or both of the colors are the implicit default colors.  This
   5         change records the default colors when TUI is initialized, and
   6         then specifies them explicitly when a color pair uses the default
   7         colors.  This allows color styling in TUI mode on MS-Windows.
   8
   9         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
  10         ncurses_norm_attr.
  11         (tui_initialize_io) [__MINGW32__]: Record the default terminal
  12         colors in ncurses_norm_attr.
  13         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
  14         "none", replace it with the default color recorded in
  15         ncurses_norm_attr.
  16
  17 2019-03-14  Tom Tromey  <tromey@adacore.com>
  18
  19         * source-cache.h (class source_cache) <get_source_lines>: Return
  20         std::string.
  21         * source-cache.c (source_cache::extract_lines): Handle case where
  22         first_pos==npos.  Return std::string.
  23         (source_cache::get_source_lines): Update.
  24
  25 2019-03-14  Tom Tromey  <tromey@adacore.com>
  26
  27         * NEWS: Add item for "style sources" commands.
  28         * source-cache.c (source_cache::get_source_lines): Check
  29         source_styling.
  30         * cli/cli-style.c (source_styling): New global.
  31         (_initialize_cli_style): Add "style sources" commands.
  32         (show_style_sources): New function.
  33         * cli/cli-style.h (source_styling): Declare.
  34
  35 2019-03-14  Pedro Alves  <palves@redhat.com>
  36             Tom Tromey  <tromey@adacore.com>
  37
  38         * tui/tui-winsource.h (tui_refill_source_window): Declare.
  39         * tui/tui-winsource.c (tui_refill_source_window): New function,
  40         from...
  41         (tui_horizontal_source_scroll): ... here.  Move some logic.
  42         * cli/cli-style.c (set_style_enabled): Notify new observable.
  43         * tui/tui-hooks.c (tui_redisplay_source): New function.
  44         (tui_attach_detach_observers): Attach or detach
  45         tui_redisplay_source.
  46         * observable.h (source_styling_changed): New observable.
  47         * observable.c: Define source_styling_changed observable.
  48
  49 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
  50
  51         PR/24325
  52         * source-cache.c: #undef open and close, to avoid unresolved
  53         externals during linking.
  54
  55 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
  56
  57         Support styling on native MS-Windows console
  58
  59         PR/24315
  60         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
  61         on MS-Windows if $TERM is not defined.
  62
  63         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
  64
  65         * posix-hdep.c (gdb_console_fputs):
  66         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
  67         functions.
  68         * ui-file.h (gdb_console_fputs): Add prototype.
  69
  70         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
  71         back to fputs only if the former returns zero.
  72
  73 2019-03-07  Brian Vandenberg  <phantall@gmail.com>
  74             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
  75
  76         PR gdb/8527
  77         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
  78         set_sigint_trap, clear_sigint_trap.
  79
  80 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
  81
  82         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
  83         for-loop range, to avoid compiler warnings.
  84
  85         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
  86         avoid compiler warnings about unused variables.
  87
  88 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
  89
  90         * NEWS: Mention end of support for native debugging on MS-Windows
  91         before XP.
  92
  93 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
  94
  95         PR gdb/24292
  96         * common/netstuff.c:
  97         * gdbserver/gdbreplay.c
  98         * gdbserver/remote-utils.c:
  99         * ser-tcp.c:
 100         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
 101         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
 102         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
 103         'getaddrinfo' and 'freeaddrinfo' were not available before
 104         Windows XP, and mingw.org's MinGW headers by default define
 105         _WIN32_WINNT to 0x500.
 106
 107 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
 108
 109         * NEWS: Note minimum Python version.
 110
 111 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 112
 113         * version.in: Set GDB version number to 8.2.90.DATE-git.
 114
 115 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 116
 117         GDB 8.2.90 released.
 118
 119 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 120
 121         * version.in: Set GDB version number to 8.2.90.
 122
 123 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 124
 125         * NEWS: Change "Changes since GDB 8.2" into "Changes in GDB 8.3".
 126
 127 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 128
 129         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
 130         * version.in: Bump version to 8.2.90.DATE-git.
 131
 132 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
 133
 134         * aix-thread.c (ptid_cmp): Remove unused variable.
 135         (get_signaled_thread): Likewise.
 136         (store_regs_user_thread): Likewise.
 137         (store_regs_kernel_thread): Likewise.
 138         (fetch_regs_kernel_thread): Remove shadowed variable.
 139
 140 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 141
 142         * features/riscv/32bit-cpu.xml: Add register numbers.
 143         * features/riscv/32bit-fpu.c: Regenerate.
 144         * features/riscv/32bit-fpu.xml: Add register numbers.
 145         * features/riscv/64bit-cpu.xml: Add register numbers.
 146         * features/riscv/64bit-fpu.c: Regenerate.
 147         * features/riscv/64bit-fpu.xml: Add register numbers.
 148
 149 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
 150
 151         * NEWS: Mention two argument form of gdb.Value constructor.
 152         * python/py-value.c (convert_buffer_and_type_to_value): New
 153         function.
 154         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
 155         Add support for handling an optional second argument.  Call
 156         convert_buffer_and_type_to_value as appropriate.
 157         * python/python-internal.h (Py_buffer_deleter): New struct.
 158         (Py_buffer_up): New typedef.
 159
 160 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
 161
 162         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
 163         instead of releasing ownership.
 164
 165 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
 166
 167         * dwarf2read.c (open_and_init_dwp_file): Call
 168         elf_numsections instead of bfd_count_sections to initialize
 169         dwp_file->num_sections.
 170
 171 2019-02-25  Tom Tromey  <tromey@adacore.com>
 172
 173         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
 174
 175 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 176
 177         * gcore.in: Add '--readnever' option when invoking GDB.
 178
 179 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 180
 181         * MAINTAINERS: Update my email address.
 182
 183 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 184
 185         * build-id.c (build_id_to_debug_bfd_1): New function.
 186         (build_id_to_debug_bfd): Look for separate debug file in
 187         sysroot.
 188
 189 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 190
 191         * gdbarch.sh: Update the copyright year range that is placed into
 192         generated files.
 193
 194 2019-02-22  Keith Seitz  <keiths@redhat.com>
 195
 196         PR symtab/23853
 197         * linespec.c (create_sals_line_offset): Search for the default
 198         symtab's filename instead of its fullname.
 199
 200 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 201
 202         * NEWS: Update style defaults.
 203
 204 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 205
 206         * main.c (captured_main_1): Disable styling in batch mode.
 207
 208 2019-02-20  Tom Tromey  <tom@tromey.com>
 209
 210         * symtab.c (symtab_symbol_info): Fix typos.
 211
 212 2019-02-20  Tom Tromey  <tromey@adacore.com>
 213
 214         * findcmd.c (_initialize_mem_search): Use upper case for
 215         metasyntactic variables.
 216
 217 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
 218
 219         * aarch64-tdep.c (aarch64_add_reggroups): New function.
 220         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
 221
 222 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
 223
 224         * top.h (source_file_name): Change to std::string.
 225         * top.c (source_file_name): Likewise.
 226         (command_line_input): Adjust.
 227         * cli/cli-script.c (script_from_file): Adjust.
 228
 229 2019-02-19  Tom Tromey  <tromey@adacore.com>
 230
 231         * ravenscar-thread.c
 232         (ravenscar_thread_target::update_thread_list): Don't call
 233         ada_build_task_list.
 234         * ada-lang.h (ada_build_task_list): Don't declare.
 235         * ada-tasks.c (struct ada_tasks_inferior_data)
 236         <task_list_valid_p>: Now bool.
 237         (read_known_tasks, ada_task_list_changed)
 238         (ada_tasks_invalidate_inferior_data): Update.
 239         (read_known_tasks_array): Return bool.
 240         (read_known_tasks_list): Likewise.
 241         (read_known_tasks): Return void.
 242         (ada_build_task_list): Now static.
 243
 244 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 245
 246         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
 247         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
 248
 249 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 250
 251         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
 252         variant for ada_tasks_pspace_data_handle and
 253         ada_tasks_inferior_data_handle.
 254         (ada_tasks_pspace_data_cleanup): New function.
 255         (ada_tasks_inferior_data_cleanup): New function.
 256
 257 2019-02-17  Tom Tromey  <tom@tromey.com>
 258
 259         * macrotab.h (macro_source_fullname): Return a std::string.
 260         * macrotab.c (macro_include, check_for_redefinition)
 261         (macro_undef, macro_lookup_definition, foreach_macro)
 262         (foreach_macro_in_scope): Update.
 263         (macro_source_fullname): Return a std::string.
 264         * macrocmd.c (show_pp_source_pos): Update.
 265
 266 2019-02-17  Tom Tromey  <tom@tromey.com>
 267
 268         * macrocmd.c (show_pp_source_pos): Style the file names.
 269
 270 2019-02-17  Tom Tromey  <tom@tromey.com>
 271
 272         PR tui/24197:
 273         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
 274
 275 2019-02-17  Tom Tromey  <tom@tromey.com>
 276
 277         * ada-lang.c (user_select_syms): Use filtered printing.
 278         * utils.c (wrap_style): New global.
 279         (desired_style): Remove.
 280         (emit_style_escape): Add stream parameter.
 281         (set_output_style, reset_terminal_style, prompt_for_continue):
 282         Update.
 283         (flush_wrap_buffer): Only flush gdb_stdout.
 284         (wrap_here): Set wrap_style.
 285         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
 286         treat escape sequences as a character.  Change when wrap buffer is
 287         flushed.
 288         (fputs_styled): Do not set the output style when the default is
 289         requested.
 290         * ui-style.h (struct ui_file_style) <is_default>: New method.
 291         * source.c (print_source_lines_base): Emit escape sequences in one
 292         piece.
 293
 294 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 295
 296         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
 297         integers and enumeration types.
 298
 299 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 300
 301         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
 302         instead of lookup_symbol_in_language
 303         (do_exact_match): New function.
 304         (ada_get_symbol_name_matcher): Return do_exact_match when
 305         doing a verbatim match.
 306
 307 2019-02-15  Tom Tromey  <tromey@adacore.com>
 308
 309         * ravenscar-thread.c (ravenscar_thread_target::resume)
 310         (ravenscar_thread_target::wait): Special case wildcard requests.
 311
 312 2019-02-15  Tom Tromey  <tromey@adacore.com>
 313
 314         * ravenscar-thread.c (base_ptid): Remove.
 315         (struct ravenscar_thread_target) <close>: New method.
 316         <m_base_ptid>: New member.
 317         <update_inferior_ptid, active_task, task_is_currently_active,
 318         runtime_initialized>: Declare methods.
 319         <ravenscar_thread_target>: Add constructor.
 320         (ravenscar_thread_target::task_is_currently_active)
 321         (ravenscar_thread_target::update_inferior_ptid)
 322         (ravenscar_runtime_initialized): Rename.  Now methods.
 323         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
 324         (ravenscar_thread_target::update_thread_list): Update.
 325         (ravenscar_thread_target::active_task): Now method.
 326         (ravenscar_thread_target::store_registers)
 327         (ravenscar_thread_target::prepare_to_store)
 328         (ravenscar_thread_target::prepare_to_store)
 329         (ravenscar_thread_target::mourn_inferior): Update.
 330         (ravenscar_inferior_created): Use "new" to create target.
 331         (ravenscar_thread_target::get_ada_task_ptid): Update.
 332         (_initialize_ravenscar): Don't initialize base_ptid.
 333         (ravenscar_ops): Remove global.
 334
 335 2019-02-15  Tom Tromey  <tromey@adacore.com>
 336
 337         * target.h (push_target): Declare new overload.
 338         * target.c (push_target): New overload, taking an rvalue reference.
 339         * remote.c (remote_target::open_1): Use push_target overload.
 340         * corelow.c (core_target_open): Use push_target overload.
 341
 342 2019-02-15  Tom Tromey  <tromey@adacore.com>
 343
 344         * ravenscar-thread.c (is_ravenscar_task)
 345         (ravenscar_task_is_currently_active): Return bool.
 346         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
 347         (_initialize_ravenscar): Remove "(void)".
 348         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
 349         Return bool.
 350
 351 2019-02-15  Tom Tromey  <tromey@adacore.com>
 352
 353         * ravenscar-thread.c (ravenscar_runtime_initializer)
 354         (has_ravenscar_runtime, get_running_thread_id)
 355         (ravenscar_thread_target::resume): Fix indentation.
 356
 357 2019-02-15  Tom Tromey  <tromey@adacore.com>
 358
 359         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
 360         from ravenscar_arch_ops.
 361         (sparc_ravenscar_ops::fetch_registers)
 362         (sparc_ravenscar_ops::store_registers): Now methods.
 363         (sparc_ravenscar_prepare_to_store): Remove.
 364         (sparc_ravenscar_ops): Redefine.
 365         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 366         methods and destructor.  Remove members.
 367         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 368         (ravenscar_thread_target::store_registers)
 369         (ravenscar_thread_target::prepare_to_store): Update.
 370         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 371         Remove.
 372         (struct ppc_ravenscar_powerpc_ops): Derive from
 373         ravenscar_arch_ops.
 374         (ppc_ravenscar_powerpc_ops::fetch_registers)
 375         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 376         (ppc_ravenscar_powerpc_ops): Redefine.
 377         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 378         (ppc_ravenscar_e500_ops::fetch_registers)
 379         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 380         (ppc_ravenscar_e500_ops): Redefine.
 381         * aarch64-ravenscar-thread.c
 382         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 383         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 384         (aarch64_ravenscar_fetch_registers)
 385         (aarch64_ravenscar_store_registers): Now methods.
 386         (aarch64_ravenscar_ops): Redefine.
 387
 388 2019-02-15  Tom Tromey  <tromey@adacore.com>
 389
 390         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 391         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 392         (ravenscar_thread_target::stopped_by_watchpoint)
 393         (ravenscar_thread_target::stopped_data_address)
 394         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 395
 396 2019-02-15  Tom Tromey  <tromey@adacore.com>
 397
 398         * ravenscar-thread.c: Fix some typos.
 399
 400 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 401             Tom Tromey  <tromey@adacore.com>
 402
 403         * ada-lang.c (ada_exception_sal): Change addr_string to a
 404         std::string.
 405         (create_ada_exception_catchpoint): Update.
 406
 407 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 408             Tom Tromey  <tromey@adacore.com>
 409
 410         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 411         (bp_location_ops): Remove.
 412         (base_breakpoint_allocate_location): Update.
 413         (free_bp_location): Update.
 414         * ada-lang.c (class ada_catchpoint_location)
 415         <ada_catchpoint_location>: Remove ops parameter.
 416         (ada_catchpoint_location_dtor): Remove.
 417         (ada_catchpoint_location_ops): Remove.
 418         (allocate_location_exception): Update.
 419         * breakpoint.h (struct bp_location_ops): Remove.
 420         (class bp_location) <bp_location>: Remove bp_location_ops
 421         parameter.
 422         <~bp_location>: Add destructor.
 423         <ops>: Remove.
 424
 425 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 426             Pedro Alves  <palves@redhat.com>
 427
 428         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 429         'PATH_MAX'.
 430
 431 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 432             Samuel Thibault  <samuel.thibault@gnu.org>
 433             Thomas Schwinge  <thomas@codesourcery.com>
 434
 435         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 436         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 437
 438 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 439
 440         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 441         (check_empty): Use "const char *".
 442
 443         * gnu-nat.c (gnu_nat_target::detach): Instead of
 444         'detach_inferior (pid)' call
 445         'detach_inferior (find_inferior_pid (pid))'.
 446
 447         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 448         'nat/fork-inferior.o'.
 449         * gnu-nat.c: #include "nat/fork-inferior.h".
 450
 451         * gnu-nat.c (gnu_nat_target::detach): Instead of
 452         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 453         * gnu-nat.h: #include "inf-child.h".
 454         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 455         'i386_gnu_nat_target::fetch_registers'.
 456         (gnu_store_registers): Rename/move to
 457         'i386_gnu_nat_target::store_registers'.
 458
 459         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 460         * gnu-nat.h (mach_thread_info): New function.
 461         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 462
 463         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 464
 465 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 466
 467         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 468
 469 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 470
 471         * windows-nat.c (windows_add_thread): Add new parameter
 472         "main_thread_p" with default value set to false.  Update
 473         function documentation as well as all callers.
 474         (windows_delete_thread): Likewise.
 475         (fake_create_process): Update call to windows_add_thread.
 476         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 477         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 478         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 479         call to windows_delete_thread.
 480
 481 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 482
 483         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 484
 485 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 486
 487         * symfile.c (find_separate_debug_file): Use canonical path of
 488         sysroot with child_path instead of gdb_sysroot if it is valid.
 489
 490 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 491
 492         * symfile.c (find_separate_debug_file): Use child_path to
 493         determine if an object file is under a sysroot.
 494
 495 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 496
 497         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 498         unittests/child-path-selftests.c.
 499         * common/pathstuff.c (child_path): New function.
 500         * common/pathstuff.h (child_path): New prototype.
 501         * unittests/child-path-selftests.c: New file.
 502
 503 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 504
 505         * symfile.c (find_separate_debug_file): Look for separate debug
 506         files in debug directories under the sysroot.
 507
 508 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 509
 510         * symtab.h (struct minimal_symbol data_p): New const method.
 511         (struct minimal_symbol text_p): Likewise.
 512         * symtab.c (output_source_filename): Use file name style
 513         to print file name.
 514         (print_symbol_info): Likewise.
 515         (print_msymbol_info): Use address style to print addresses.
 516         Use function name style to print executable text symbols.
 517         (expand_symtab_containing_pc): Use data_p.
 518         (find_pc_sect_compunit_symtab): Likewise.
 519
 520 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 521
 522         * breakpoint.c (describe_other_breakpoints): Use address style
 523         to print addresses.
 524         (say_where): Likewise.
 525
 526 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 527
 528         * ada-typeprint.c (print_func_type): Print function name
 529         style to print function name.
 530         * c-typeprint.c (c_print_type_1): Likewise.
 531
 532 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 533
 534         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 535         for execve.
 536
 537 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 538
 539         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 540         type_stack.
 541
 542 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 543
 544         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 545         TYPE_CODE_REF types.
 546
 547 2019-02-08  Jim Wilson  <jimw@sifive.com>
 548
 549         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 550         (riscv_linux_fregset): New.
 551         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 552
 553 2019-02-07  Tom Tromey  <tom@tromey.com>
 554
 555         * thread.c (thread_cancel_execution_command): Update.
 556         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 557         methods.
 558         (struct thread_fsm_ops): Remove.
 559         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 560         (thread_fsm_should_stop, thread_fsm_return_value)
 561         (thread_fsm_set_finished, thread_fsm_finished_p)
 562         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 563         Don't declare.
 564         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 565         * infrun.c (clear_proceed_status_thread)
 566         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 567         (print_stop_event): Update.
 568         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 569         Add constructor.
 570         (step_command_fsm_ops): Remove.
 571         (new_step_command_fsm): Remove.
 572         (step_1): Update.
 573         (step_command_fsm::should_stop): Rename from
 574         step_command_fsm_should_stop.
 575         (step_command_fsm::clean_up): Rename from
 576         step_command_fsm_clean_up.
 577         (step_command_fsm::do_async_reply_reason): Rename from
 578         step_command_fsm_async_reply_reason.
 579         (struct until_next_fsm): Inherit from thread_fsm.  Add
 580         constructor.
 581         (until_next_fsm_ops): Remove.
 582         (new_until_next_fsm): Remove.
 583         (until_next_fsm::should_stop): Rename from
 584         until_next_fsm_should_stop.
 585         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 586         (until_next_fsm::do_async_reply_reason): Rename from
 587         until_next_fsm_async_reply_reason.
 588         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 589         constructor.  Change type of breakpoint.
 590         (finish_command_fsm_ops): Remove.
 591         (new_finish_command_fsm): Remove.
 592         (finish_command_fsm::should_stop): Rename from
 593         finish_command_fsm_should_stop.
 594         (finish_command_fsm::clean_up): Rename from
 595         finish_command_fsm_clean_up.
 596         (finish_command_fsm::return_value): Rename from
 597         finish_command_fsm_return_value.
 598         (finish_command_fsm::do_async_reply_reason): Rename from
 599         finish_command_fsm_async_reply_reason.
 600         (finish_command): Update.
 601         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 602         Add constructor.
 603         (call_thread_fsm_ops): Remove.
 604         (call_thread_fsm::call_thread_fsm): Rename from
 605         new_call_thread_fsm.
 606         (call_thread_fsm::should_stop): Rename from
 607         call_thread_fsm_should_stop.
 608         (call_thread_fsm::should_notify_stop): Rename from
 609         call_thread_fsm_should_notify_stop.
 610         (run_inferior_call, call_function_by_hand_dummy): Update.
 611         * cli/cli-interp.c (should_print_stop_to_console): Update.
 612         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 613         Add constructor.  Change type of location_breakpoint,
 614         caller_breakpoint.
 615         (until_break_fsm_ops): Remove.
 616         (new_until_break_fsm): Remove.
 617         (until_break_fsm::should_stop): Rename from
 618         until_break_fsm_should_stop.
 619         (until_break_fsm::clean_up): Rename from
 620         until_break_fsm_clean_up.
 621         (until_break_fsm::do_async_reply_reason): Rename from
 622         until_break_fsm_async_reply_reason.
 623         (until_break_command): Update.
 624         * thread-fsm.c: Remove.
 625         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 626
 627 2019-02-07  Tom Tromey  <tom@tromey.com>
 628
 629         * yy-remap.h: Add include guard.
 630         * xtensa-tdep.h: Add include guard.
 631         * xcoffread.h: Rename include guard.
 632         * varobj-iter.h: Add include guard.
 633         * tui/tui.h: Rename include guard.
 634         * tui/tui-winsource.h: Rename include guard.
 635         * tui/tui-wingeneral.h: Rename include guard.
 636         * tui/tui-windata.h: Rename include guard.
 637         * tui/tui-win.h: Rename include guard.
 638         * tui/tui-stack.h: Rename include guard.
 639         * tui/tui-source.h: Rename include guard.
 640         * tui/tui-regs.h: Rename include guard.
 641         * tui/tui-out.h: Rename include guard.
 642         * tui/tui-layout.h: Rename include guard.
 643         * tui/tui-io.h: Rename include guard.
 644         * tui/tui-hooks.h: Rename include guard.
 645         * tui/tui-file.h: Rename include guard.
 646         * tui/tui-disasm.h: Rename include guard.
 647         * tui/tui-data.h: Rename include guard.
 648         * tui/tui-command.h: Rename include guard.
 649         * tic6x-tdep.h: Add include guard.
 650         * target/waitstatus.h: Rename include guard.
 651         * target/wait.h: Rename include guard.
 652         * target/target.h: Rename include guard.
 653         * target/resume.h: Rename include guard.
 654         * target-float.h: Rename include guard.
 655         * stabsread.h: Add include guard.
 656         * rs6000-tdep.h: Add include guard.
 657         * riscv-fbsd-tdep.h: Add include guard.
 658         * regformats/regdef.h: Rename include guard.
 659         * record.h: Rename include guard.
 660         * python/python.h: Rename include guard.
 661         * python/python-internal.h: Rename include guard.
 662         * python/py-stopevent.h: Rename include guard.
 663         * python/py-ref.h: Rename include guard.
 664         * python/py-record.h: Rename include guard.
 665         * python/py-record-full.h: Rename include guard.
 666         * python/py-record-btrace.h: Rename include guard.
 667         * python/py-instruction.h: Rename include guard.
 668         * python/py-events.h: Rename include guard.
 669         * python/py-event.h: Rename include guard.
 670         * procfs.h: Add include guard.
 671         * proc-utils.h: Add include guard.
 672         * p-lang.h: Add include guard.
 673         * or1k-tdep.h: Rename include guard.
 674         * observable.h: Rename include guard.
 675         * nto-tdep.h: Rename include guard.
 676         * nat/x86-linux.h: Rename include guard.
 677         * nat/x86-linux-dregs.h: Rename include guard.
 678         * nat/x86-gcc-cpuid.h: Add include guard.
 679         * nat/x86-dregs.h: Rename include guard.
 680         * nat/x86-cpuid.h: Rename include guard.
 681         * nat/ppc-linux.h: Rename include guard.
 682         * nat/mips-linux-watch.h: Rename include guard.
 683         * nat/linux-waitpid.h: Rename include guard.
 684         * nat/linux-ptrace.h: Rename include guard.
 685         * nat/linux-procfs.h: Rename include guard.
 686         * nat/linux-osdata.h: Rename include guard.
 687         * nat/linux-nat.h: Rename include guard.
 688         * nat/linux-namespaces.h: Rename include guard.
 689         * nat/linux-btrace.h: Rename include guard.
 690         * nat/glibc_thread_db.h: Rename include guard.
 691         * nat/gdb_thread_db.h: Rename include guard.
 692         * nat/gdb_ptrace.h: Rename include guard.
 693         * nat/fork-inferior.h: Rename include guard.
 694         * nat/amd64-linux-siginfo.h: Rename include guard.
 695         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 696         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 697         * nat/aarch64-linux.h: Rename include guard.
 698         * nat/aarch64-linux-hw-point.h: Rename include guard.
 699         * mn10300-tdep.h: Add include guard.
 700         * mips-linux-tdep.h: Add include guard.
 701         * mi/mi-parse.h: Rename include guard.
 702         * mi/mi-out.h: Rename include guard.
 703         * mi/mi-main.h: Rename include guard.
 704         * mi/mi-interp.h: Rename include guard.
 705         * mi/mi-getopt.h: Rename include guard.
 706         * mi/mi-console.h: Rename include guard.
 707         * mi/mi-common.h: Rename include guard.
 708         * mi/mi-cmds.h: Rename include guard.
 709         * mi/mi-cmd-break.h: Rename include guard.
 710         * m2-lang.h: Add include guard.
 711         * location.h: Rename include guard.
 712         * linux-record.h: Rename include guard.
 713         * linux-nat.h: Add include guard.
 714         * linux-fork.h: Add include guard.
 715         * i386-darwin-tdep.h: Rename include guard.
 716         * hppa-linux-offsets.h: Add include guard.
 717         * guile/guile.h: Rename include guard.
 718         * guile/guile-internal.h: Rename include guard.
 719         * gnu-nat.h: Rename include guard.
 720         * gdb-stabs.h: Rename include guard.
 721         * frv-tdep.h: Add include guard.
 722         * f-lang.h: Add include guard.
 723         * event-loop.h: Add include guard.
 724         * darwin-nat.h: Rename include guard.
 725         * cp-abi.h: Rename include guard.
 726         * config/sparc/nm-sol2.h: Rename include guard.
 727         * config/nm-nto.h: Rename include guard.
 728         * config/nm-linux.h: Add include guard.
 729         * config/i386/nm-i386gnu.h: Rename include guard.
 730         * config/djgpp/nl_types.h: Rename include guard.
 731         * config/djgpp/langinfo.h: Rename include guard.
 732         * compile/gcc-cp-plugin.h: Add include guard.
 733         * compile/gcc-c-plugin.h: Add include guard.
 734         * compile/compile.h: Rename include guard.
 735         * compile/compile-object-run.h: Rename include guard.
 736         * compile/compile-object-load.h: Rename include guard.
 737         * compile/compile-internal.h: Rename include guard.
 738         * compile/compile-cplus.h: Rename include guard.
 739         * compile/compile-c.h: Rename include guard.
 740         * common/xml-utils.h: Rename include guard.
 741         * common/x86-xstate.h: Rename include guard.
 742         * common/version.h: Rename include guard.
 743         * common/vec.h: Rename include guard.
 744         * common/tdesc.h: Rename include guard.
 745         * common/selftest.h: Rename include guard.
 746         * common/scoped_restore.h: Rename include guard.
 747         * common/scoped_mmap.h: Rename include guard.
 748         * common/scoped_fd.h: Rename include guard.
 749         * common/safe-iterator.h: Rename include guard.
 750         * common/run-time-clock.h: Rename include guard.
 751         * common/refcounted-object.h: Rename include guard.
 752         * common/queue.h: Rename include guard.
 753         * common/ptid.h: Rename include guard.
 754         * common/print-utils.h: Rename include guard.
 755         * common/preprocessor.h: Rename include guard.
 756         * common/pathstuff.h: Rename include guard.
 757         * common/observable.h: Rename include guard.
 758         * common/netstuff.h: Rename include guard.
 759         * common/job-control.h: Rename include guard.
 760         * common/host-defs.h: Rename include guard.
 761         * common/gdb_wait.h: Rename include guard.
 762         * common/gdb_vecs.h: Rename include guard.
 763         * common/gdb_unlinker.h: Rename include guard.
 764         * common/gdb_unique_ptr.h: Rename include guard.
 765         * common/gdb_tilde_expand.h: Rename include guard.
 766         * common/gdb_sys_time.h: Rename include guard.
 767         * common/gdb_string_view.h: Rename include guard.
 768         * common/gdb_splay_tree.h: Rename include guard.
 769         * common/gdb_setjmp.h: Rename include guard.
 770         * common/gdb_ref_ptr.h: Rename include guard.
 771         * common/gdb_optional.h: Rename include guard.
 772         * common/gdb_locale.h: Rename include guard.
 773         * common/gdb_assert.h: Rename include guard.
 774         * common/filtered-iterator.h: Rename include guard.
 775         * common/filestuff.h: Rename include guard.
 776         * common/fileio.h: Rename include guard.
 777         * common/environ.h: Rename include guard.
 778         * common/common-utils.h: Rename include guard.
 779         * common/common-types.h: Rename include guard.
 780         * common/common-regcache.h: Rename include guard.
 781         * common/common-inferior.h: Rename include guard.
 782         * common/common-gdbthread.h: Rename include guard.
 783         * common/common-exceptions.h: Rename include guard.
 784         * common/common-defs.h: Rename include guard.
 785         * common/common-debug.h: Rename include guard.
 786         * common/cleanups.h: Rename include guard.
 787         * common/buffer.h: Rename include guard.
 788         * common/btrace-common.h: Rename include guard.
 789         * common/break-common.h: Rename include guard.
 790         * cli/cli-utils.h: Rename include guard.
 791         * cli/cli-style.h: Rename include guard.
 792         * cli/cli-setshow.h: Rename include guard.
 793         * cli/cli-script.h: Rename include guard.
 794         * cli/cli-interp.h: Rename include guard.
 795         * cli/cli-decode.h: Rename include guard.
 796         * cli/cli-cmds.h: Rename include guard.
 797         * charset-list.h: Add include guard.
 798         * buildsym-legacy.h: Rename include guard.
 799         * bfin-tdep.h: Add include guard.
 800         * ax.h: Rename include guard.
 801         * arm-linux-tdep.h: Add include guard.
 802         * arm-fbsd-tdep.h: Add include guard.
 803         * arch/xtensa.h: Rename include guard.
 804         * arch/tic6x.h: Add include guard.
 805         * arch/i386.h: Add include guard.
 806         * arch/arm.h: Rename include guard.
 807         * arch/arm-linux.h: Rename include guard.
 808         * arch/arm-get-next-pcs.h: Rename include guard.
 809         * arch/amd64.h: Add include guard.
 810         * arch/aarch64-insn.h: Rename include guard.
 811         * arch-utils.h: Rename include guard.
 812         * annotate.h: Add include guard.
 813         * amd64-darwin-tdep.h: Rename include guard.
 814         * aarch64-linux-tdep.h: Add include guard.
 815         * aarch64-fbsd-tdep.h: Add include guard.
 816         * aarch32-linux-nat.h: Add include guard.
 817
 818 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 819
 820         * macrotab.c (macro_define_internal): New function that
 821         factorizes macro_define_object_internal and macro_define_function
 822         code.
 823         (macro_define_object_internal): Use macro_define_internal.
 824         (macro_define_function): Likewise.
 825
 826 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 827
 828         * macrocmd.c (extract_identifier): Return
 829         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 830         callers.
 831
 832 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 833
 834         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 835
 836 2019-02-05  Tom Tromey  <tom@tromey.com>
 837
 838         * target.c (target_stack::unpush): Move assertion earlier.
 839
 840 2019-01-30  Tom Tromey  <tom@tromey.com>
 841
 842         PR python/23615:
 843         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 844         (gdbpy_parse_and_eval): Likewise.
 845         * python/python-internal.h (gdbpy_allow_threads): New class.
 846
 847 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 848
 849         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 850         (aarch64_fbsd_fpregmap): Move earlier.
 851         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 852         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 853         instead of individual calls to trad_frame_set_reg_addr.
 854         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 855         earlier.
 856         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 857         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 858         instead of individual calls to trad_frame_set_reg_addr.
 859
 860 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 861
 862         * CONTRIBUTE: Replace contribution list with wiki link.
 863
 864 2019-01-25  Tom Tromey  <tom@tromey.com>
 865
 866         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 867
 868 2019-01-25  Tom Tromey  <tom@tromey.com>
 869
 870         * xtensa-linux-nat.c: Fix common/ includes.
 871         * xml-support.h: Fix common/ includes.
 872         * xml-support.c: Fix common/ includes.
 873         * x86-linux-nat.c: Fix common/ includes.
 874         * windows-nat.c: Fix common/ includes.
 875         * varobj.h: Fix common/ includes.
 876         * varobj.c: Fix common/ includes.
 877         * value.c: Fix common/ includes.
 878         * valops.c: Fix common/ includes.
 879         * utils.c: Fix common/ includes.
 880         * unittests/xml-utils-selftests.c: Fix common/ includes.
 881         * unittests/utils-selftests.c: Fix common/ includes.
 882         * unittests/unpack-selftests.c: Fix common/ includes.
 883         * unittests/tracepoint-selftests.c: Fix common/ includes.
 884         * unittests/style-selftests.c: Fix common/ includes.
 885         * unittests/string_view-selftests.c: Fix common/ includes.
 886         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 887         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 888         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 889         * unittests/rsp-low-selftests.c: Fix common/ includes.
 890         * unittests/parse-connection-spec-selftests.c: Fix common/
 891         includes.
 892         * unittests/optional-selftests.c: Fix common/ includes.
 893         * unittests/offset-type-selftests.c: Fix common/ includes.
 894         * unittests/observable-selftests.c: Fix common/ includes.
 895         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 896         * unittests/memrange-selftests.c: Fix common/ includes.
 897         * unittests/memory-map-selftests.c: Fix common/ includes.
 898         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 899         * unittests/function-view-selftests.c: Fix common/ includes.
 900         * unittests/environ-selftests.c: Fix common/ includes.
 901         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 902         * unittests/common-utils-selftests.c: Fix common/ includes.
 903         * unittests/cli-utils-selftests.c: Fix common/ includes.
 904         * unittests/array-view-selftests.c: Fix common/ includes.
 905         * ui-file.c: Fix common/ includes.
 906         * tui/tui-io.c: Fix common/ includes.
 907         * tracepoint.h: Fix common/ includes.
 908         * tracepoint.c: Fix common/ includes.
 909         * tracefile-tfile.c: Fix common/ includes.
 910         * top.h: Fix common/ includes.
 911         * top.c: Fix common/ includes.
 912         * thread.c: Fix common/ includes.
 913         * target/waitstatus.h: Fix common/ includes.
 914         * target/waitstatus.c: Fix common/ includes.
 915         * target.h: Fix common/ includes.
 916         * target.c: Fix common/ includes.
 917         * target-memory.c: Fix common/ includes.
 918         * target-descriptions.c: Fix common/ includes.
 919         * symtab.h: Fix common/ includes.
 920         * symfile.c: Fix common/ includes.
 921         * stap-probe.c: Fix common/ includes.
 922         * spu-linux-nat.c: Fix common/ includes.
 923         * sparc-nat.c: Fix common/ includes.
 924         * source.c: Fix common/ includes.
 925         * solib.c: Fix common/ includes.
 926         * solib-target.c: Fix common/ includes.
 927         * ser-unix.c: Fix common/ includes.
 928         * ser-tcp.c: Fix common/ includes.
 929         * ser-pipe.c: Fix common/ includes.
 930         * ser-base.c: Fix common/ includes.
 931         * selftest-arch.c: Fix common/ includes.
 932         * s12z-tdep.c: Fix common/ includes.
 933         * rust-exp.y: Fix common/ includes.
 934         * rs6000-aix-tdep.c: Fix common/ includes.
 935         * riscv-tdep.c: Fix common/ includes.
 936         * remote.c: Fix common/ includes.
 937         * remote-notif.h: Fix common/ includes.
 938         * remote-fileio.h: Fix common/ includes.
 939         * remote-fileio.c: Fix common/ includes.
 940         * regcache.h: Fix common/ includes.
 941         * regcache.c: Fix common/ includes.
 942         * record-btrace.c: Fix common/ includes.
 943         * python/python.c: Fix common/ includes.
 944         * python/py-type.c: Fix common/ includes.
 945         * python/py-inferior.c: Fix common/ includes.
 946         * progspace.h: Fix common/ includes.
 947         * producer.c: Fix common/ includes.
 948         * procfs.c: Fix common/ includes.
 949         * proc-api.c: Fix common/ includes.
 950         * printcmd.c: Fix common/ includes.
 951         * ppc-linux-nat.c: Fix common/ includes.
 952         * parser-defs.h: Fix common/ includes.
 953         * osdata.c: Fix common/ includes.
 954         * obsd-nat.c: Fix common/ includes.
 955         * nat/x86-linux.c: Fix common/ includes.
 956         * nat/x86-linux-dregs.c: Fix common/ includes.
 957         * nat/x86-dregs.h: Fix common/ includes.
 958         * nat/x86-dregs.c: Fix common/ includes.
 959         * nat/ppc-linux.c: Fix common/ includes.
 960         * nat/mips-linux-watch.h: Fix common/ includes.
 961         * nat/mips-linux-watch.c: Fix common/ includes.
 962         * nat/linux-waitpid.c: Fix common/ includes.
 963         * nat/linux-ptrace.h: Fix common/ includes.
 964         * nat/linux-ptrace.c: Fix common/ includes.
 965         * nat/linux-procfs.c: Fix common/ includes.
 966         * nat/linux-personality.c: Fix common/ includes.
 967         * nat/linux-osdata.c: Fix common/ includes.
 968         * nat/linux-namespaces.c: Fix common/ includes.
 969         * nat/linux-btrace.h: Fix common/ includes.
 970         * nat/linux-btrace.c: Fix common/ includes.
 971         * nat/fork-inferior.c: Fix common/ includes.
 972         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 973         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 974         * nat/aarch64-linux.c: Fix common/ includes.
 975         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 976         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 977         * namespace.h: Fix common/ includes.
 978         * mips-linux-tdep.c: Fix common/ includes.
 979         * minsyms.c: Fix common/ includes.
 980         * mi/mi-parse.h: Fix common/ includes.
 981         * mi/mi-main.c: Fix common/ includes.
 982         * mi/mi-cmd-env.c: Fix common/ includes.
 983         * memrange.h: Fix common/ includes.
 984         * memattr.c: Fix common/ includes.
 985         * maint.h: Fix common/ includes.
 986         * maint.c: Fix common/ includes.
 987         * main.c: Fix common/ includes.
 988         * machoread.c: Fix common/ includes.
 989         * location.c: Fix common/ includes.
 990         * linux-thread-db.c: Fix common/ includes.
 991         * linux-nat.c: Fix common/ includes.
 992         * linux-fork.c: Fix common/ includes.
 993         * inline-frame.c: Fix common/ includes.
 994         * infrun.c: Fix common/ includes.
 995         * inflow.c: Fix common/ includes.
 996         * inferior.h: Fix common/ includes.
 997         * inferior.c: Fix common/ includes.
 998         * infcmd.c: Fix common/ includes.
 999         * inf-ptrace.c: Fix common/ includes.
1000         * inf-child.c: Fix common/ includes.
1001         * ia64-linux-nat.c: Fix common/ includes.
1002         * i387-tdep.c: Fix common/ includes.
1003         * i386-tdep.c: Fix common/ includes.
1004         * i386-linux-tdep.c: Fix common/ includes.
1005         * i386-linux-nat.c: Fix common/ includes.
1006         * i386-go32-tdep.c: Fix common/ includes.
1007         * i386-fbsd-tdep.c: Fix common/ includes.
1008         * i386-fbsd-nat.c: Fix common/ includes.
1009         * guile/scm-type.c: Fix common/ includes.
1010         * guile/guile.c: Fix common/ includes.
1011         * go32-nat.c: Fix common/ includes.
1012         * gnu-nat.c: Fix common/ includes.
1013         * gdbthread.h: Fix common/ includes.
1014         * gdbarch-selftests.c: Fix common/ includes.
1015         * gdb_usleep.c: Fix common/ includes.
1016         * gdb_select.h: Fix common/ includes.
1017         * gdb_bfd.c: Fix common/ includes.
1018         * gcore.c: Fix common/ includes.
1019         * fork-child.c: Fix common/ includes.
1020         * findvar.c: Fix common/ includes.
1021         * fbsd-nat.c: Fix common/ includes.
1022         * event-top.c: Fix common/ includes.
1023         * event-loop.c: Fix common/ includes.
1024         * dwarf2read.c: Fix common/ includes.
1025         * dwarf2loc.c: Fix common/ includes.
1026         * dwarf2-frame.c: Fix common/ includes.
1027         * dwarf-index-cache.c: Fix common/ includes.
1028         * dtrace-probe.c: Fix common/ includes.
1029         * disasm-selftests.c: Fix common/ includes.
1030         * defs.h: Fix common/ includes.
1031         * csky-tdep.c: Fix common/ includes.
1032         * cp-valprint.c: Fix common/ includes.
1033         * cp-support.h: Fix common/ includes.
1034         * cp-support.c: Fix common/ includes.
1035         * corelow.c: Fix common/ includes.
1036         * completer.h: Fix common/ includes.
1037         * completer.c: Fix common/ includes.
1038         * compile/compile.c: Fix common/ includes.
1039         * compile/compile-loc2c.c: Fix common/ includes.
1040         * compile/compile-cplus-types.c: Fix common/ includes.
1041         * compile/compile-cplus-symbols.c: Fix common/ includes.
1042         * command.h: Fix common/ includes.
1043         * cli/cli-dump.c: Fix common/ includes.
1044         * cli/cli-cmds.c: Fix common/ includes.
1045         * charset.c: Fix common/ includes.
1046         * build-id.c: Fix common/ includes.
1047         * btrace.h: Fix common/ includes.
1048         * btrace.c: Fix common/ includes.
1049         * breakpoint.h: Fix common/ includes.
1050         * breakpoint.c: Fix common/ includes.
1051         * ax.h:
1052         (enum agent_op): Fix common/ includes.
1053         * ax-general.c (struct aop_map): Fix common/ includes.
1054         * ax-gdb.c: Fix common/ includes.
1055         * auxv.c: Fix common/ includes.
1056         * auto-load.c: Fix common/ includes.
1057         * arm-tdep.c: Fix common/ includes.
1058         * arch/riscv.c: Fix common/ includes.
1059         * arch/ppc-linux-common.c: Fix common/ includes.
1060         * arch/i386.c: Fix common/ includes.
1061         * arch/arm.c: Fix common/ includes.
1062         * arch/arm-linux.c: Fix common/ includes.
1063         * arch/arm-get-next-pcs.c: Fix common/ includes.
1064         * arch/amd64.c: Fix common/ includes.
1065         * arch/aarch64.c: Fix common/ includes.
1066         * arch/aarch64-insn.c: Fix common/ includes.
1067         * arch-utils.c: Fix common/ includes.
1068         * amd64-windows-tdep.c: Fix common/ includes.
1069         * amd64-tdep.c: Fix common/ includes.
1070         * amd64-sol2-tdep.c: Fix common/ includes.
1071         * amd64-obsd-tdep.c: Fix common/ includes.
1072         * amd64-nbsd-tdep.c: Fix common/ includes.
1073         * amd64-linux-tdep.c: Fix common/ includes.
1074         * amd64-linux-nat.c: Fix common/ includes.
1075         * amd64-fbsd-tdep.c: Fix common/ includes.
1076         * amd64-fbsd-nat.c: Fix common/ includes.
1077         * amd64-dicos-tdep.c: Fix common/ includes.
1078         * amd64-darwin-tdep.c: Fix common/ includes.
1079         * agent.c: Fix common/ includes.
1080         * ada-lang.h: Fix common/ includes.
1081         * ada-lang.c: Fix common/ includes.
1082         * aarch64-tdep.c: Fix common/ includes.
1083
1084 2019-01-25  Tom Tromey  <tom@tromey.com>
1085
1086         * common/create-version.sh: Use common/version.h.
1087
1088 2019-01-24  Pedro Alves  <palves@redhat.com>
1089
1090         * infrun.c (signal_stop, signal_print, signal_program)
1091         (signal_catch, signal_pass): Now arrays instead of pointers.
1092         (update_signals_program_target, do_target_resume)
1093         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1094         * linux-nat.c (linux_nat_target::pass_signals)
1095         (linux_nat_target::create_inferior, linux_nat_target::attach):
1096         Adjust.
1097         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1098         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1099         * procfs.c (procfs_target::pass_signals): Adjust.
1100         * record-full.c (record_full_target::resume): Adjust.
1101         * remote.c (remote_target::pass_signals)
1102         (remote_target::program_signals): Adjust.
1103         * target-debug.h (target_debug_print_signals): Now takes a
1104         gdb::array_view as parameter.  Adjust.
1105         * target.h (target_ops) <pass_signals, program_signals>: Replace
1106         pointer and length parameters with gdb::array_view.
1107         (target_pass_signals, target_program_signals): Likewise.
1108         * target-delegates.c: Regenerate.
1109
1110 2019-01-24  Pedro Alves  <palves@redhat.com>
1111
1112         * common/forward-scope-exit.h
1113         (forward_scope_exit::forward_scope_exit): Pass arguments to
1114         m_bind_function directly, instead of creating a std::bind and
1115         copying that.
1116
1117 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1118
1119         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1120         for static members.
1121         (pass_in_v_vfp_candidate): Likewise.
1122
1123 2019-01-23  Tom Tromey  <tom@tromey.com>
1124             Pedro Alves  <palves@redhat.com>
1125
1126         * regcache.c (class regcache_invalidator): Remove.
1127         (regcache::raw_write): Use make_scope_exit.
1128
1129 2019-01-23  Tom Tromey  <tom@tromey.com>
1130
1131         * ui-out.h (class ui_out_emit_type): Update comment.
1132
1133 2019-01-23  Tom Tromey  <tom@tromey.com>
1134
1135         * infrun.c (fetch_inferior_event): Update comment.
1136
1137 2019-01-23  Tom Tromey  <tom@tromey.com>
1138             Pedro Alves  <palves@redhat.com>
1139
1140         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1141         parameter.
1142         (fetch_inferior_event): Use SCOPE_EXIT.
1143
1144
1145 2019-01-23  Tom Tromey  <tom@tromey.com>
1146             Pedro Alves  <palves@redhat.com>
1147
1148         * infrun.c (disable_thread_events): Delete.
1149         (stop_all_threads): Use SCOPE_EXIT.
1150
1151 2019-01-23  Tom Tromey  <tom@tromey.com>
1152             Pedro Alves  <palves@redhat.com>
1153
1154         * symfile.c: Include forward-scope-exit.h.
1155         (clear_symtab_users_cleanup): Replace forward declaration with
1156         a FORWARD_SCOPE_EXIT.
1157         (syms_from_objfile_1): Use the forward_scope_exit and
1158         gdb::optional instead of cleanup_function.
1159         (reread_symbols): Use the forward_scope_exit instead of
1160         cleanup_function.
1161         (clear_symtab_users_cleanup): Remove function.
1162
1163 2019-01-23  Tom Tromey  <tom@tromey.com>
1164             Pedro Alves  <palves@redhat.com>
1165
1166         * linux-nat.c: Include scope-exit.h.
1167         (cleanup_target_stop): Remove.
1168         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1169         SCOPE_EXIT.
1170
1171 2019-01-23  Tom Tromey  <tom@tromey.com>
1172             Pedro Alves  <palves@redhat.com>
1173
1174         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1175         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1176
1177 2019-01-23  Tom Tromey  <tom@tromey.com>
1178             Andrew Burgess  <andrew.burgess@embecosm.com>
1179             Pedro Alves  <palves@redhat.com>
1180
1181         * infrun.c (fetch_inferior_event): Use scope_exit.
1182         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1183         * top.c (execute_command): Use scope_exit.
1184         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1185         * utils.c (do_bpstat_clear_actions_cleanup)
1186         (make_bpstat_clear_actions_cleanup): Remove.
1187
1188 2019-01-23  Tom Tromey  <tom@tromey.com>
1189             Pedro Alves  <palves@redhat.com>
1190
1191         * infrun.c: Include "common/scope-exit.h"
1192         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1193         (wait_for_inferior): Use SCOPE_EXIT.
1194         (fetch_inferior_event): Use scope_exit.
1195
1196 2019-01-23  Tom Tromey  <tom@tromey.com>
1197             Pedro Alves  <palves@redhat.com>
1198
1199         * breakpoint.c (create_breakpoint): Remove cleanup.
1200
1201 2019-01-23  Tom Tromey  <tom@tromey.com>
1202             Andrew Burgess  <andrew.burgess@embecosm.com>
1203             Pedro Alves  <palves@redhat.com>
1204
1205 2019-01-23  Pedro Alves  <palves@redhat.com>
1206
1207         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1208
1209 2019-01-23  Pedro Alves  <palves@redhat.com>
1210             Andrew Burgess  <andrew.burgess@embecosm.com>
1211
1212         * gdbthread.h: Include "common/forward-scope-exit.h".
1213         (scoped_finish_thread_state): Redefine custom class in terms of
1214         forward_scope_exit.
1215
1216 2019-01-23  Pedro Alves  <palves@redhat.com>
1217             Andrew Burgess  <andrew.burgess@embecosm.com>
1218
1219         * common/forward-scope-exit.h: New file.
1220
1221 2019-01-23  Pedro Alves  <palves@redhat.com>
1222             Andrew Burgess  <andrew.burgess@embecosm.com>
1223             Tom Tromey  <tom@tromey.com>
1224
1225         * common/scope-exit.h: New file.
1226
1227 2019-01-23  Pedro Alves  <palves@redhat.com>
1228
1229         * common/preprocessor.h (ESC): Rename to ...
1230         (ESC_PARENS): ... this.
1231         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1232         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1233
1234 2019-01-23  Tom Tromey  <tom@tromey.com>
1235
1236         * language.h (class scoped_switch_to_sym_language_if_auto):
1237         Initialize m_lang in both cases.
1238
1239 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1240
1241         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1242         with XCNEW.
1243
1244 2019-01-22  Tom Tromey  <tom@tromey.com>
1245
1246         * corelow.c: Do not include sys/file.h.
1247
1248 2019-01-22  Tom Tromey  <tom@tromey.com>
1249
1250         * tui/tui-wingeneral.h: Include gdb_curses.h.
1251
1252 2019-01-22  Tom Tromey  <tom@tromey.com>
1253
1254         * source-cache.h (class source_cache) <get_source_lines,
1255         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1256
1257 2019-01-22  Tom Tromey  <tom@tromey.com>
1258
1259         * remote-fileio.h (struct remote_target): Declare.
1260
1261 2019-01-22  Tom Tromey  <tom@tromey.com>
1262
1263         * python/py-arch.c: Do not include py-ref.h.
1264         * python/py-bpevent.c: Do not include py-ref.h.
1265         * python/py-cmd.c: Do not include py-ref.h.
1266         * python/py-continueevent.c: Do not include py-ref.h.
1267         * python/py-event.h: Do not include py-ref.h.
1268         * python/py-evtregistry.c: Do not include py-ref.h.
1269         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1270         * python/py-frame.c: Do not include py-ref.h.
1271         * python/py-framefilter.c: Do not include py-ref.h.
1272         * python/py-function.c: Do not include py-ref.h.
1273         * python/py-infevents.c: Do not include py-ref.h.
1274         * python/py-linetable.c: Do not include py-ref.h.
1275         * python/py-objfile.c: Do not include py-ref.h.
1276         * python/py-param.c: Do not include py-ref.h.
1277         * python/py-prettyprint.c: Do not include py-ref.h.
1278         * python/py-progspace.c: Do not include py-ref.h.
1279         * python/py-symbol.c: Do not include py-ref.h.
1280         * python/py-symtab.c: Do not include py-ref.h.
1281         * python/py-type.c: Do not include py-ref.h.
1282         * python/py-unwind.c: Do not include py-ref.h.
1283         * python/py-utils.c: Do not include py-ref.h.
1284         * python/py-value.c: Do not include py-ref.h.
1285         * python/py-varobj.c: Do not include py-ref.h.
1286         * python/py-xmethods.c: Do not include py-ref.h.
1287         * python/python.c: Do not include py-ref.h.
1288         * varobj.c: Do not include py-ref.h.
1289
1290 2019-01-22  Tom Tromey  <tom@tromey.com>
1291
1292         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1293         keyword for bcache.
1294
1295 2019-01-22  Tom Tromey  <tom@tromey.com>
1296
1297         * compile/compile-cplus-types.c: Remove a comment by #include.
1298
1299 2019-01-22  Tom Tromey  <tom@tromey.com>
1300
1301         * compile/gcc-c-plugin.h: Include compile-internal.h.
1302
1303 2019-01-22  Tom Tromey  <tom@tromey.com>
1304
1305         * stabsread.c (EXTERN): Do not define.
1306         (symnum, next_symbol_text_func, processing_gcc_compilation)
1307         (within_function, global_sym_chain, global_stabs)
1308         (previous_stab_code, this_object_header_files)
1309         (n_this_object_header_files)
1310         (n_allocated_this_object_header_files): Define.
1311         * stabsread.h (EXTERN): Never define.  Use "extern".
1312
1313 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1314
1315         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1316         history_value.
1317
1318 2019-01-21  Tom Tromey  <tom@tromey.com>
1319
1320         * ui-out.c: Fix includes.
1321         * tui/tui-source.c: Fix includes.
1322         * target.c: Fix includes.
1323         * remote.c: Fix includes.
1324         * regcache.c: Fix includes.
1325         * python/py-block.c: Fix includes.
1326         * printcmd.c: Fix includes.
1327         * or1k-tdep.c: Fix includes.
1328         * mi/mi-main.c: Fix includes.
1329         * m32r-tdep.c: Fix includes.
1330         * csky-tdep.c: Fix includes.
1331         * compile/compile-cplus-types.c: Fix includes.
1332         * cli/cli-interp.c: Fix includes.
1333
1334 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1335
1336         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1337         for padding.
1338
1339 2019-01-16  Tom Tromey  <tom@tromey.com>
1340
1341         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1342         earlier.
1343         (struct objfile) <msymbols_range>: Move from top level.
1344         <msymbols>: New method.
1345         (class objfile_msymbols): Remove.
1346         * symtab.c (default_collect_symbol_completion_matches_break_on):
1347         Update.
1348         * symmisc.c (dump_msymbols): Update.
1349         * stabsread.c (scan_file_globals): Update.
1350         * objc-lang.c (info_selectors_command, info_classes_command)
1351         (find_methods): Update.
1352         * minsyms.c (find_solib_trampoline_target): Update.
1353         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1354         * coffread.c (coff_symfile_read): Update.
1355         * ada-lang.c (ada_lookup_simple_minsym)
1356         (ada_collect_symbol_completion_matches): Update.
1357
1358 2019-01-16  Tom Tromey  <tom@tromey.com>
1359
1360         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1361         type.  Remove no-argument constructor.
1362         <iterator::operator++>: Simplify.
1363         <begin>: Update.
1364         <end>: Use minimal_symbol_count.
1365
1366 2019-01-16  Tom Tromey  <tom@tromey.com>
1367
1368         * objfiles.h (struct objfile) <psymtabs>: New method.
1369         (class objfile_psymtabs): Remove.
1370         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1371         typedef.
1372         <range>: New method.
1373         (require_partial_symbols): Change return type.
1374         * psymtab.c (require_partial_symbols)
1375         (psym_expand_symtabs_matching): Update.
1376         * mdebugread.c (parse_partial_symbols): Update.
1377         * dbxread.c (dbx_end_psymtab): Update.
1378
1379 2019-01-15  Tom Tromey  <tom@tromey.com>
1380
1381         * symtab.c (lookup_objfile_from_block)
1382         (lookup_symbol_in_objfile_symtabs)
1383         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1384         (find_line_symtab, info_sources_command)
1385         (default_collect_symbol_completion_matches_break_on)
1386         (make_source_files_completion_list): Update.
1387         * symmisc.c (print_objfile_statistics, dump_objfile)
1388         (maintenance_print_symbols, maintenance_info_symtabs)
1389         (maintenance_check_symtabs, maintenance_info_line_tables):
1390         Update.
1391         * source.c (select_source_symtab)
1392         (forget_cached_source_info_for_objfile): Update.
1393         * objfiles.h (class objfile_compunits): Remove.
1394         (struct objfile) <compunits_range>: New typedef.
1395         (compunits): New method.
1396         * objfiles.c (objfile_relocate1): Update.
1397         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1398         * maint.c (count_symtabs_and_blocks): Update.
1399         * linespec.c (iterate_over_all_matching_symtabs): Update.
1400         * cp-support.c (add_symbol_overload_list_qualified): Update.
1401         * coffread.c (coff_symtab_read): Update.
1402         * ada-lang.c (add_nonlocal_symbols)
1403         (ada_collect_symbol_completion_matches)
1404         (ada_add_global_exceptions): Update.
1405
1406 2019-01-15  Tom Tromey  <tom@tromey.com>
1407
1408         * progspace.h (program_space) <objfiles_safe_range>: New
1409         typedef.
1410         <objfiles_safe>: New method.
1411         * objfiles.h (class all_objfiles_safe): Remove.
1412         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1413         * jit.c (jit_inferior_exit_hook): Update.
1414
1415 2019-01-17  Tom Tromey  <tom@tromey.com>
1416
1417         * progspace.h (program_space) <objfiles_range>: New typedef.
1418         <objfiles>: New method.
1419         <objfiles_head>: Rename from objfiles.
1420         (object_files): Update.
1421         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1422         * guile/scm-pretty-print.c
1423         (ppscm_find_pretty_printer_from_objfiles): Update.
1424         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1425         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1426         Update.
1427         * python/py-progspace.c (pspy_get_objfiles): Update.
1428         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1429         Update.
1430         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1431         (objfpy_lookup_objfile_by_build_id): Update.
1432         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1433         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1434         Update.
1435         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1436         (expand_symtab_containing_pc, lookup_objfile_from_block)
1437         (lookup_static_symbol, basic_lookup_transparent_type)
1438         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1439         (find_line_symtab, info_sources_command)
1440         (default_collect_symbol_completion_matches_break_on)
1441         (make_source_files_completion_list, find_main_name): Update.
1442         * symmisc.c (print_symbol_bcache_statistics)
1443         (print_objfile_statistics, maintenance_print_symbols)
1444         (maintenance_print_msymbols, maintenance_print_objfiles)
1445         (maintenance_info_symtabs, maintenance_check_symtabs)
1446         (maintenance_expand_symtabs, maintenance_info_line_tables):
1447         Update.
1448         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1449         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1450         (map_overlay_command, unmap_overlay_command)
1451         (simple_overlay_update, expand_symtabs_matching)
1452         (map_symbol_filenames): Update.
1453         * symfile-debug.c (set_debug_symfile): Update.
1454         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1455         Update.
1456         * source.c (select_source_symtab, forget_cached_source_info):
1457         Update.
1458         * solib.c (solib_read_symbols): Update.
1459         * solib-spu.c (append_ocl_sos): Update.
1460         * psymtab.c (maintenance_print_psymbols)
1461         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1462         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1463         * printcmd.c (info_symbol_command): Update.
1464         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1465         Update.
1466         * objfiles.h (class all_objfiles): Remove.
1467         * objfiles.c (have_partial_symbols, have_full_symbols)
1468         (have_minimal_symbols, qsort_cmp, update_section_map)
1469         (shared_objfile_contains_address_p)
1470         (default_iterate_over_objfiles_in_search_order): Update.
1471         * objc-lang.c (info_selectors_command, info_classes_command)
1472         (find_methods): Update.
1473         * minsyms.c (find_solib_trampoline_target): Update.
1474         * maint.c (maintenance_info_sections)
1475         (maintenance_translate_address, count_symtabs_and_blocks):
1476         Update.
1477         * main.c (captured_main_1): Update.
1478         * linux-thread-db.c (try_thread_db_load_from_pdir)
1479         (has_libpthread): Update.
1480         * linespec.c (iterate_over_all_matching_symtabs)
1481         (search_minsyms_for_name): Update.
1482         * jit.c (jit_find_objf_with_entry_addr): Update.
1483         * hppa-tdep.c (find_unwind_entry)
1484         (hppa_lookup_stub_minimal_symbol): Update.
1485         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1486         Update.
1487         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1488         (elf_gnu_ifunc_resolve_by_got): Update.
1489         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1490         * dwarf-index-write.c (save_gdb_index_command): Update.
1491         * cp-support.c (add_symbol_overload_list_qualified): Update.
1492         * breakpoint.c (create_overlay_event_breakpoint)
1493         (create_longjmp_master_breakpoint)
1494         (create_std_terminate_master_breakpoint)
1495         (create_exception_master_breakpoint): Update.
1496         * blockframe.c (find_pc_partial_function): Update.
1497         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1498         (ada_collect_symbol_completion_matches)
1499         (ada_add_global_exceptions): Update.
1500
1501 2019-01-17  Tom Tromey  <tom@tromey.com>
1502
1503         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1504         declare VEC.
1505         (solib_target_parse_libraries): Change return type.
1506         (library_list_start_segment, library_list_start_section)
1507         (library_list_end_library, library_list_start_library); Update.
1508         (solib_target_free_library_list): Remove.
1509         (solib_target_parse_libraries): Remove cleanup.  Change return
1510         type.
1511         (solib_target_current_sos): Update.
1512
1513 2019-01-17  Tom Tromey  <tromey@bapiya>
1514
1515         * valprint.c: Replace "the the" with "the".
1516         * symtab.c: Replace "the the" with "the".
1517         * solib.c: Replace "the the" with "the".
1518         * solib-dsbt.c: Replace "the the" with "the".
1519         * linespec.c: Replace "the the" with "the".
1520         * dwarf2loc.h: Replace "the the" with "the".
1521         * amd64-windows-tdep.c: Replace "the the" with "the".
1522         * aarch64-tdep.c: Replace "the the" with "the".
1523
1524 2019-01-16  Keith Seitz  <keiths@redhat.com>
1525
1526         PR gdb/23773
1527         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1528         <builder>: Rename to ..
1529         <m_builder>: ... this and make private.
1530         (dwarf2_cu::get_builder): New method.  Change all users of
1531         `builder' to use this method.
1532         (dwarf2_start_symtab): Move to ...
1533         (dwarf2_cu::start_symtab): ... here.  Update all callers
1534         (setup_type_unit_groups): Move to ...
1535         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1536         callers.
1537         (dwarf2_cu::reset_builder): New method.
1538         (process_full_compunit, process_full_type_unit): Use
1539         dwarf2_cu::reset_builder.
1540         (follow_die_offset): Record the ancestor CU if it is different
1541         from the followed DIE's CU.
1542         (follow_die_sig_1): Likewise.
1543
1544 2019-01-15  Tom Tromey  <tom@tromey.com>
1545
1546         * remote.c (class remote_state) <buf>: Now a char_vector.
1547         <buf_size>: Remove.
1548         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1549         parameter.
1550         (remote_target::getpkt_or_notif_sane_1)
1551         (remote_target::getpkt_sane)
1552         (remote_target::getpkt_or_notif_sane): Likewise.
1553         (class remote_target) <putpkt>: New overload.
1554         (remote_target::read_frame): Change type of "buf_p".  Remove
1555         sizeof_p parameter.
1556         (packet_ok): New overload.
1557         (packet_check_result): New overload.
1558         Update all uses.
1559
1560 2019-01-14  Tom Tromey  <tom@tromey.com>
1561
1562         * remote-notif.c (handle_notification, remote_notif_ack)
1563         (remote_notif_parse): Make "buf" const.
1564         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1565         const.
1566         (remote_notif_parse, remote_notif_ack, handle_notification):
1567         Likewise.
1568         * remote.c (remote_notif_stop_parse): Make "buf" const.
1569         (remote_target::remote_parse_stop_reply): Make "buf" const.
1570         (remote_notif_stop_ack): Make "buf" const.
1571
1572 2019-01-14  Tom Tromey  <tom@tromey.com>
1573
1574         * remote.c (remote_console_output): Make parameter const.
1575
1576 2019-01-14  Tom Tromey  <tom@tromey.com>
1577
1578         * target-debug.h (target_debug_print_signals): Constify.
1579         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1580         * procfs.c (procfs_target::pass_signals): Update.
1581         * linux-nat.c (linux_nat_target::pass_signals): Update.
1582         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1583         * target-delegates.c: Rebuild.
1584         * remote.c (remote_target::program_signals): Update.
1585         (remote_target::pass_signals): Update.
1586         * target.c (target_pass_signals): Constify argument.
1587         (target_program_signals): Likewise.
1588         * target.h (struct target_ops) <pass_signals, program_signals>:
1589         Constify argument.
1590         (target_pass_signals, target_program_signals): Constify argument.
1591
1592 2019-01-14  Tom Tromey  <tom@tromey.com>
1593
1594         PR tui/28819:
1595         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1596
1597 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1598
1599         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1600         field.
1601         * rs6000-tdep.c: Include reggroups.h.
1602         (IS_V_ALIAS_PSEUDOREG): Define.
1603         (rs6000_register_name): Return names for the "vX" aliases.
1604         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1605         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1606         aliases.  Call default_register_reggroup_p for all other
1607         pseudo-registers.
1608         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1609         New functions.
1610         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1611         Handle "vX" aliases.
1612         (v_alias_pseudo_register_collect): New function.
1613         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1614         (rs6000_gdbarch_init): Initialize "vX" aliases as
1615         pseudo-registers.  Restore registration of
1616         rs6000_pseudo_register_reggroup_p with
1617         set_tdesc_pseudo_register_reggroup_p.
1618
1619 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1620
1621         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1622         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1623         set_gdbarch_num_pseudo_regs.
1624
1625 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1626
1627         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1628         Remove arg prefixname, add do_set and do_show.
1629         Add member functions set_list and show_list.
1630         * cli/cli-style.c (class cli_style_option): Update accordingly.
1631         (style_set_list): Move to file scope.
1632         (style_show_list): Likewise.
1633         (set_style): Call help_list.
1634         (show_style): Call cmd_show_list.
1635         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1636         Update to use the new macro.
1637
1638 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1639
1640         * ada-lang.c (_initialize_ada_language): Expand the help text
1641         for the "catch exception" command.
1642
1643 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1644
1645         * symtab.c (matching_obj_sections): Initialize obj,
1646         declare it closer to its usage.
1647
1648 2019-01-10  Tom Tromey  <tom@tromey.com>
1649
1650         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1651         (basic_inf_threads_range): Remove.
1652         (inf_threads_range, inf_non_exited_threads_range)
1653         (safe_inf_threads_range): Use next_adapter.
1654
1655 2019-01-10  Keith Seitz  <keiths@redhat.com>
1656
1657         PR gdb/23712
1658         PR symtab/23010
1659         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1660         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1661
1662 2019-01-10  Keith Seitz  <keiths@redhat.com>
1663
1664         PR gdb/23712
1665         PR symtab/23010
1666         * dictionary.c (pending_to_vector): Remove.
1667         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1668         Remove _1 suffix, replacing functions of the same name.  Update
1669         all callers.
1670         (dict_create_hashed, dict_create_hashed_expandable)
1671         (dict_create_linear, dict_create_linear_expandable, dict_free)
1672         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1673         Make functions static.
1674
1675 2019-01-10  Keith Seitz  <keiths@redhat.com>
1676
1677         PR gdb/23712
1678         PR symtab/23010
1679         * dictionary.h (struct dictionary): Replace declaration with
1680         multidictionary.
1681         (dict_create_hashed, dict_create_hashed_expandable)
1682         (dict_create_linear, dict_create_linear_expandable)
1683         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1684         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1685         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1686         taking multidictionary argument.
1687         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1688         * block.h (struct block) <dict>: Change to multidictionary
1689         and rename `multidict'.
1690         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1691         symmisc.c: Update all dictionary references to multidictionary.
1692
1693 2019-01-10  Keith Seitz  <keiths@redhat.com>
1694
1695         PR gdb/23712
1696         PR symtab/23010
1697         * dictionary.c: Include unordered_map.
1698         (pending_to_vector): New function.
1699         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1700         Rewrite the non-"_1" functions to take vector instead
1701         of linked list.
1702         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1703         "new" _1 versions of the same name.
1704         (multidictionary): Define.
1705         (std::hash<enum language): New definition.
1706         (collate_pending_symbols_by_language, mdict_create_hashed)
1707         (mdict_create_hashed_expandable, mdict_create_linear)
1708         (mdict_create_linear_expandable, mdict_free)
1709         (find_language_dictionary, create_new_language_dictionary)
1710         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1711         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1712         (mdict_size, mdict_empty): New functions.
1713         * dictionary.h (mdict_iterator): Define.
1714
1715 2019-01-10  Pedro Alves  <palves@redhat.com>
1716
1717         * breakpoint.c (read_uploaded_action)
1718         (create_tracepoint_from_upload): Adjust to use
1719         gdb::unique_xmalloc_ptr.
1720         * ctf.c (ctf_write_uploaded_tp):
1721         (SET_ARRAY_FIELD): Use emplace_back.
1722         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1723         * tracefile-tfile.c (tfile_write_uploaded_tp):
1724         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1725         gdb::unique_xmalloc_ptr.
1726         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1727         at_string, cond_string, cmd_strings>: Replace char pointers
1728         with gdb::unique_xmalloc_ptr.
1729
1730 2019-01-10  Pedro Alves  <palves@redhat.com>
1731
1732         * solib-target.c (library_list_start_library): Don't xstrdup name.
1733
1734 2019-01-10  Pedro Alves  <palves@redhat.com>
1735
1736         * mdebugread.c (parse_partial_symbols): Use
1737         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1738
1739 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1740
1741         * linux-fork.c (scoped_switch_fork_info)
1742         <~scoped_switch_fork_info>: Fix incorrect variable name.
1743
1744 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1745
1746         * linux-fork.c (scoped_switch_fork_info)
1747         <scoped_switch_fork_info>: Make explicit.
1748         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1749
1750 2019-01-10  Tom Tromey  <tom@tromey.com>
1751
1752         * objfiles.h (objfile::reset_psymtabs): Update.
1753         * objfiles.c (objfile::objfile): Update.
1754         * psymtab.h (psymtab_storage::obstack): Update.
1755         (psymtab_storage::m_obstack): Use gdb::optional.
1756         (class psymtab_storage): Update comment.  Remove objfile
1757         parameter.
1758         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1759
1760 2019-01-10  Tom Tromey  <tom@tromey.com>
1761
1762         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1763         <free_psymtabs>: Now private.
1764         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1765         (allocate_psymtab): Use new method.
1766
1767 2019-01-10  Tom Tromey  <tom@tromey.com>
1768
1769         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1770         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1771         * mdebugread.c (parse_partial_symbols): Use
1772         allocate_dependencies.
1773         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1774         allocate_dependencies.
1775         (process_psymtab_comp_unit_reader)
1776         (build_type_psymtab_dependencies): Likewise.
1777         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1778
1779 2019-01-10  Tom Tromey  <tom@tromey.com>
1780
1781         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1782         PSYMBOL_SET_LANGUAGE.
1783         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1784
1785 2019-01-10  Tom Tromey  <tom@tromey.com>
1786
1787         * psymtab.h (psymtab_storage::obstack): New method.
1788         <m_obstack>: Rename from obstack; now private.
1789         * psymtab.c (psymtab_storage): Update.
1790         * dwarf2read.c (create_addrmap_from_index)
1791         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1792         Update.
1793
1794 2019-01-10  Tom Tromey  <tom@tromey.com>
1795
1796         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1797         * objfiles.h (objfile::reset_psymtabs): New method.
1798
1799 2019-01-10  Tom Tromey  <tom@tromey.com>
1800
1801         * symmisc.c (print_symbol_bcache_statistics): Update.
1802         (print_objfile_statistics): Update.
1803         * symfile.c (reread_symbols): Update.
1804         * psymtab.h (class psymtab_storage): New.
1805         * psymtab.c (psymtab_storage): New constructor.
1806         (~psymtab_storage): New destructor.
1807         (require_partial_symbols): Update.
1808         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1809         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1810         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1811         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1812         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1813         (start_psymtab_common, end_psymtab_common)
1814         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1815         (allocate_psymtab): Update.
1816         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1817         Update.
1818         (dump_psymtab_addrmap, maintenance_print_psymbols)
1819         (maintenance_check_psymtabs): Update.
1820         (class objfile_psymtabs): Move to objfiles.h.
1821         * psympriv.h (discard_psymtab): Now inline.
1822         (psymtab_discarder::psymtab_discarder): Update.
1823         (psymtab_discarder::~psymtab_discarder): Update.
1824         (ALL_OBJFILE_PSYMTABS): Rewrite.
1825         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1826         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1827         Remove fields.
1828         <partial_symtabs>: New field.
1829         (class objfile_psymtabs): Move from psymtab.h.  Update.
1830         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1831         psymbol_cache.
1832         (objfile::~objfile): Don't destroy psymbol_cache.
1833         * mdebugread.c (parse_partial_symbols): Update.
1834         * dwarf2read.c (create_addrmap_from_index)
1835         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1836         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1837         (add_partial_subprogram, dwarf2_ranges_read): Update.
1838         * dwarf-index-write.c (write_address_map)
1839         (write_one_signatured_type, recursively_write_psymbols)
1840         (class debug_names, class debug_names, write_psymtabs_to_index):
1841         Update.
1842
1843 2019-01-10  Tom Tromey  <tom@tromey.com>
1844
1845         * symtab.h (SYMBOL_SET_NAMES): Update.
1846         (symbol_set_names): Update.
1847         (MSYMBOL_SET_NAMES): Update.
1848         * symtab.c (symbol_set_names): Change argument to be an
1849         objfile_per_bfd_storage.
1850         * psymtab.c (add_psymbol_to_bcache): Update.
1851         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1852
1853 2019-01-10  Tom Tromey  <tom@tromey.com>
1854
1855         * symtab.c (create_demangled_names_hash): Change argument to be an
1856         objfile_per_bfd_storage.
1857         (symbol_set_names): Update.
1858
1859 2019-01-10  Tom Tromey  <tom@tromey.com>
1860
1861         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1862         init_psymbol_list.
1863         * psymtab.c (init_psymbol_list): Do nothing if already called.
1864         * psympriv.h (init_psymbol_list): Add comment.
1865         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1866         init_psymbol_list.
1867         * dbxread.c (dbx_symfile_read): Unconditionally call
1868         init_psymbol_list.
1869
1870 2019-01-10  Tom Tromey  <tom@tromey.com>
1871
1872         * xcoffread.c (scan_xcoff_symtab): Update.
1873         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1874         "where".
1875         * mdebugread.c (parse_partial_symbols)
1876         (handle_psymbol_enumerators): Update.
1877         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1878         * dbxread.c (read_dbx_symtab): Update.
1879         * psympriv.h (psymbol_placement): New enum.
1880         (add_psymbol_to_list): Update.
1881
1882 2019-01-10  Tom Tromey  <tom@tromey.com>
1883
1884         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1885         static_psymbols parameters.
1886         (scan_xcoff_symtab): Update.
1887         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1888         static_psymbols parameters.
1889         * psympriv.h (start_psymtab_common): Update.
1890         * mdebugread.c (parse_partial_symbols): Update.
1891         * dwarf2read.c (create_partial_symtab): Update.
1892         * dbxread.c (read_dbx_symtab): Update.
1893         (start_psymtab): Remove global_psymbols and static_psymbols
1894         parameters.
1895
1896 2019-01-10  Tom Tromey  <tom@tromey.com>
1897
1898         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1899         * psymtab.c (allocate_psymtab): Add comment.
1900         * psympriv.h (allocate_psymtab): Add comment.
1901         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1902         initializations.
1903         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1904
1905 2019-01-10  Tom Tromey  <tom@tromey.com>
1906
1907         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1908         Don't declare.
1909         * mipsread.c: Include mdebugread.h.
1910         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1911         Declare.
1912         * elfread.c: Include mdebugread.h.
1913
1914 2019-01-09  Tom Tromey  <tom@tromey.com>
1915
1916         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1917         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1918         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1919         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1920         (psym_lookup_symbol, psym_find_last_source_symtab)
1921         (psym_forget_cached_source_info, psym_print_stats)
1922         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1923         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1924         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1925         (psym_find_compunit_symtab_by_address)
1926         (maintenance_print_psymbols, maintenance_info_psymtabs)
1927         (maintenance_check_psymtabs): Use ranged for.
1928         * psymtab.h (class objfile_psymtabs): New.
1929         (require_partial_symbols): Return objfile_psymtabs.
1930         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1931
1932 2019-01-09  Tom Tromey  <tom@tromey.com>
1933
1934         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1935         (find_pc_mapped_section, list_overlays_command)
1936         (map_overlay_command, unmap_overlay_command)
1937         (simple_overlay_update): Use all_objfiles.
1938         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1939         * printcmd.c (info_symbol_command): Use all_objfiles.
1940         * objfiles.h (ALL_OBJSECTIONS): Remove.
1941         * maint.c (maintenance_translate_address): Use all_objfiles.
1942         * gcore.c (gcore_create_callback): Use all_objfiles.
1943         (objfile_find_memory_regions): Likewise.
1944
1945 2019-01-09  Tom Tromey  <tom@tromey.com>
1946
1947         * symtab.c (find_line_symtab, info_sources_command)
1948         (make_source_files_completion_list): Use objfile_compunits.
1949         * source.c (select_source_symtab): Use objfile_compunits.
1950         * objfiles.h (struct objfile): Update comment.
1951         (ALL_OBJFILES): Remove.
1952         (ALL_FILETABS): Remove.
1953         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1954         objfile_compunits.
1955
1956 2019-01-09  Tom Tromey  <tom@tromey.com>
1957
1958         * symmisc.c (print_objfile_statistics, dump_objfile)
1959         (maintenance_print_symbols): Use compunit_filetabs.
1960         * source.c (forget_cached_source_info_for_objfile): Use
1961         compunit_filetabs.
1962         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1963         (ALL_FILETABS): Use compunit_filetabs.
1964         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1965         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1966
1967 2019-01-09  Tom Tromey  <tom@tromey.com>
1968
1969         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1970         (compunit_filetabs): New.
1971         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1972         compunit_filetabs.
1973         (info_sources_command, make_source_files_completion_list): Remove
1974         declaration.
1975         * symmisc.c (print_objfile_statistics, dump_objfile)
1976         (maintenance_print_symbols): Remove declaration.
1977         (maintenance_info_symtabs): Use compunit_filetabs.
1978         (maintenance_info_line_tables): Likewise.
1979         * source.c (select_source_symtab): Change local variable name.
1980         (forget_cached_source_info_for_objfile): Remove declaration.
1981         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1982         * objfiles.c (objfile_relocate1): Remove declaration.
1983         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1984         declaration.
1985         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1986         * coffread.c (coff_symtab_read): Remove declaration.
1987         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1988         compunit_filetabs.
1989
1990 2019-01-09  Tom Tromey  <tom@tromey.com>
1991
1992         * symtab.c (lookup_objfile_from_block)
1993         (find_pc_sect_compunit_symtab, search_symbols)
1994         (default_collect_symbol_completion_matches_break_on): Use
1995         objfile_compunits.
1996         * objfiles.h (ALL_COMPUNITS): Remove.
1997         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1998         * cp-support.c (add_symbol_overload_list_qualified): Use
1999         objfile_compunits.
2000         * ada-lang.c (ada_collect_symbol_completion_matches)
2001         (ada_add_global_exceptions): Use objfile_compunits.
2002
2003 2019-01-09  Tom Tromey  <tom@tromey.com>
2004
2005         * source.c (select_source_symtab)
2006         (forget_cached_source_info_for_objfile): Remove declaration.
2007         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2008         declaration.
2009         * maint.c (count_symtabs_and_blocks): Remove declaration.
2010         * cp-support.c (add_symbol_overload_list_qualified): Remove
2011         declaration.
2012         * coffread.c (coff_symtab_read): Remove declaration.
2013         * symtab.c (lookup_symbol_in_objfile_symtabs)
2014         (basic_lookup_transparent_type_1): Use objfile_compunits.
2015         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2016         (info_sources_command, search_symbols)
2017         (default_collect_symbol_completion_matches_break_on)
2018         (make_source_files_completion_list): Remove declaration.
2019         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2020         (ada_collect_symbol_completion_matches)
2021         (ada_add_global_exceptions): Remove declaration.
2022         * linespec.c (iterate_over_all_matching_symtabs): Use
2023         objfile_compunits.
2024         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2025         (class objfile_compunits): New.
2026         (ALL_COMPUNITS): Use objfile_compunits.
2027         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2028         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2029         objfile_compunits.
2030         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2031
2032 2019-01-09  Tom Tromey  <tom@tromey.com>
2033
2034         * symtab.c (search_symbols)
2035         (default_collect_symbol_completion_matches_break_on): Use
2036         objfile_msymbols.
2037         * ada-lang.c (ada_lookup_simple_minsym)
2038         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2039         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2040         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2041         objfile_msymbols.
2042         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2043         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2044         * objc-lang.c (find_methods): Use objfile_msymbols.
2045         (info_selectors_command, info_classes_command): Likewise.
2046         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2047         * objfiles.h (class objfile_msymbols): New.
2048         (ALL_OBJFILE_MSYMBOLS): Remove.
2049         (ALL_MSYMBOLS): Remove.
2050
2051 2019-01-09  Tom Tromey  <tom@tromey.com>
2052
2053         * common/next-iterator.h (next_adapter): Add Iterator template
2054         parameter.
2055         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2056         (class all_objfiles_safe): New.
2057         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2058         * objfiles.c (put_objfile_before): Update comment.
2059         (add_separate_debug_objfile): Likewise.
2060         (free_all_objfiles): Use all_objfiles_safe.
2061         (objfile_purge_solibs): Likewise.
2062
2063 2019-01-09  Tom Tromey  <tom@tromey.com>
2064
2065         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2066         (expand_symtab_containing_pc, lookup_static_symbol)
2067         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2068         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2069         all_objfiles.
2070         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2071         * breakpoint.c (create_overlay_event_breakpoint)
2072         (create_longjmp_master_breakpoint)
2073         (create_std_terminate_master_breakpoint)
2074         (create_exception_master_breakpoint): Use all_objfiles.
2075         * linux-thread-db.c (try_thread_db_load_from_pdir)
2076         (has_libpthread): Use all_objfiles.
2077         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2078         * linespec.c (iterate_over_all_matching_symtabs)
2079         (search_minsyms_for_name): Use all_objfiles.
2080         * maint.c (maintenance_info_sections): Use all_objfiles.
2081         * main.c (captured_main_1): Use all_objfiles.
2082         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2083         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2084         * guile/scm-pretty-print.c
2085         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2086         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2087         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2088         (maintenance_print_msymbols): Use all_objfiles.
2089         * source.c (select_source_symtab): Use all_objfiles.
2090         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2091         * symfile.c (remove_symbol_file_command)
2092         (expand_symtabs_matching, map_symbol_filenames): Use
2093         all_objfiles.
2094         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2095         all_objfiles.
2096         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2097         * objc-lang.c (find_methods): Use all_objfiles.
2098         * objfiles.c (have_partial_symbols, have_full_symbols)
2099         (have_minimal_symbols, qsort_cmp)
2100         (default_iterate_over_objfiles_in_search_order): Use
2101         all_objfiles.
2102         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2103         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2104         (maintenance_check_psymtabs): Use all_objfiles.
2105         (ALL_PSYMTABS): Remove.
2106         * compile/compile-object-run.c (do_module_cleanup): Use
2107         all_objfiles.
2108         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2109         * cp-support.c (add_symbol_overload_list_qualified): Use
2110         all_objfiles.
2111         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2112         Use all_objfiles.
2113         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2114         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2115         all_objfiles.
2116         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2117         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2118         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2119         Uses all_objfiles.
2120         * solib.c (solib_read_symbols): Use all_objfiles
2121
2122 2019-01-09  Tom Tromey  <tom@tromey.com>
2123
2124         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2125         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2126         all_objfiles.
2127         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2128         * symmisc.c (print_symbol_bcache_statistics)
2129         (print_objfile_statistics, maintenance_print_objfiles)
2130         (maintenance_info_symtabs, maintenance_check_symtabs)
2131         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2132         all_objfiles.
2133         * source.c (forget_cached_source_info): Use all_objfiles.
2134         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2135         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2136         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2137         * objfiles.c (update_section_map): Use all_objfiles.
2138         (shared_objfile_contains_address_p): Likewise.
2139         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2140         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2141
2142 2019-01-09  Tom Tromey  <tom@tromey.com>
2143
2144         * common/next-iterator.h: New file.
2145         * objfiles.h (class all_objfiles): New.
2146         (struct objfile_iterator): New.
2147
2148 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2149
2150         * NEWS: Move the description of the changed "frame", "select-frame",
2151          and "info frame" commands to the Changed commands section.
2152
2153 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2154
2155         * gdbtypes.c (check_stub_method_group): Remove handling of old
2156         mangling schemes.
2157         * linespec.c (find_methods): Likewise.
2158         * stabsread.c (read_member_functions): Likewise.
2159         * valops.c (search_struct_method): Likewise.
2160         (value_struct_elt_for_reference): Likewise.
2161         * NEWS: Mention this change.
2162
2163 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2164
2165         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2166         print_source_lines.
2167         * source.c (print_source_lines_base): Update line number check.
2168         (print_source_lines): New function.
2169         (source_lines_range::source_lines_range): New function.
2170         * source.h (class source_lines_range): New class.
2171         (print_source_lines): New declaration.
2172
2173 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2174
2175         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2176
2177 2019-01-08  Tom Tromey  <tom@tromey.com>
2178             Simon Marchi  <simon.marchi@ericsson.com>
2179
2180         PR gdb/24060
2181         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2182         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2183         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2184         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2185         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2186         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2187
2188 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2189
2190         * source.c (select_source_symtab): Move header comment to
2191         declaration in source.h.
2192         (forget_cached_source_info_for_objfile): Likewise.
2193         (forget_cached_source_info): Likewise.
2194         (identify_source_line): Likewise.
2195         * source.h (identify_source_line): Move declaration from symtab.h
2196         and add comment from source.c
2197         (print_source_lines): Likewise.
2198         (forget_cached_source_info_for_objfile): Likewise.
2199         (forget_cached_source_info): Likewise.
2200         (select_source_symtab): Likewise.
2201         (enum print_source_lines_flag): Move definition from symtab.h.
2202         * symtab.h (identify_source_line): Move declaration to source.h.
2203         (print_source_lines): Likewise.
2204         (forget_cached_source_info_for_objfile): Likewise.
2205         (forget_cached_source_info): Likewise.
2206         (select_source_symtab): Likewise.
2207         (enum print_source_lines_flag): Move definition to source.h.
2208         * tui/tui-hooks.c: Add 'source.h' include.
2209
2210 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2211
2212         * source.c (print_source_lines_base): Handle requests to print
2213         reverse line number sequences, and guard against empty lines
2214         string.
2215
2216 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2217
2218         * source.c (print_source_lines_base): Fix skip of '\r' if next
2219         character is '\n'.
2220
2221 2019-01-06  Tom Tromey  <tom@tromey.com>
2222
2223         * c-exp.y (struct c_parse_state) <macro_original_text,
2224         expansion_obstack>: New member.
2225         (macro_original_text, expansion_obstack): Remove globals.
2226         (scan_macro_expansion, scanning_macro_expansion)
2227         (finished_macro_expansion): Update.
2228         (scan_macro_cleanup): Remove.
2229         (yylex, c_parse): Update.
2230
2231 2019-01-06  Tom Tromey  <tom@tromey.com>
2232
2233         * c-exp.y (struct c_parse_state) <strings>: New member.
2234         (operator_stoken): Update.
2235
2236 2019-01-06  Tom Tromey  <tom@tromey.com>
2237
2238         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2239         (union type_stack_elt) <typelist_val>: Now a pointer to
2240         std::vector.
2241         (type_stack_cleanup): Don't declare.
2242         (push_typelist): Update.
2243         * parse.c (pop_typelist): Return a std::vector.
2244         (push_typelist): Take a std::vector.
2245         (follow_types): Update.  Do not free args.
2246         (type_stack_cleanup): Remove.
2247         * c-exp.y (struct c_parse_state): New.
2248         (cpstate): New global.
2249         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2250         (nonempty_typelist): Update.
2251         (func_mod): Create a new vector.
2252         (c_parse): Create a c_parse_state.
2253         (check_parameter_typelist): Do not delete params.
2254         (function_method): Update.  Do not delete type_list.
2255
2256 2019-01-06  Tom Tromey  <tom@tromey.com>
2257
2258         PR gdb/28155:
2259         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2260         check_typedef.
2261         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2262         (print_return_value): Likewise.
2263
2264 2019-01-05  Tom Tromey  <tom@tromey.com>
2265
2266         * contrib/cleanup_check.py: Remove.
2267         * contrib/gcc-with-excheck: Remove.
2268         * contrib/exsummary.py: Remove.
2269         * contrib/excheck.py: Remove.
2270
2271 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2272
2273         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2274         NULL. Initialize tpprev to NULL instead of assigning it
2275         to NULL on the next statement.
2276         * windows-nat.c (windows_delete_thread): Remove check for
2277         main_thread_id before printing thread exit notifications.
2278         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2279         Remove thread ID check against main_thread_id.
2280         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2281         windows_delete_thread.
2282         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2283
2284 2019-01-04  Tom Tromey  <tom@tromey.com>
2285
2286         * compile/compile.c (_initialize_compile): Use upper case for
2287         metasyntactic variables.
2288         * symmisc.c (_initialize_symmisc): Use upper case for
2289         metasyntactic variables.
2290         * psymtab.c (_initialize_psymtab): Use upper case for
2291         metasyntactic variables.
2292         * demangle.c (demangle_command): Use upper case for metasyntactic
2293         variables.
2294         (_initialize_demangler): Likewise.
2295         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2296         variables.
2297
2298 2019-01-03  Tom Tromey  <tom@tromey.com>
2299
2300         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2301
2302 2019-01-03  Tom Tromey  <tom@tromey.com>
2303
2304         * python/py-symtab.c (salpy_str): Update.
2305         (struct salpy_sal_object) <symtab>: Now a PyObject.
2306         (salpy_dealloc): Update.
2307         (del_objfile_sal): Use gdbpy_ref.
2308
2309 2019-01-03  Tom Tromey  <tom@tromey.com>
2310
2311         * python/py-type.c (convert_field): Use new_reference.  Return
2312         gdbpy_ref.
2313         (make_fielditem): Return gdbpy_ref.
2314         (typy_fields): Update.
2315         (typy_getitem): Update.
2316         (field_name): Return gdbpy_ref.  Use new_reference.
2317         (typy_iterator_iternext): Update.
2318
2319 2019-01-03  Tom Tromey  <tom@tromey.com>
2320
2321         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2322
2323 2019-01-03  Tom Tromey  <tom@tromey.com>
2324
2325         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2326         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2327         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2328         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2329         (pspy_set_type_printers): Likewise.
2330         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2331         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2332         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2333         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2334         (objfpy_set_type_printers): Likewise.
2335
2336 2019-01-03  Tom Tromey  <tom@tromey.com>
2337
2338         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2339         (gdbpy_print_stack): Use gdbpy_err_fetch.
2340         * python/python-internal.h (class gdbpy_err_fetch): New class.
2341         (class gdbpy_enter) <m_error_type, m_error_value,
2342         m_error_traceback>: Remove.
2343         <m_error>: New member.
2344         (gdbpy_exception_to_string): Don't declare.
2345         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2346         * python/py-value.c (convert_value_from_python): Use
2347         gdbpy_err_fetch.
2348         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2349         gdbpy_exception_to_string.
2350         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2351         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2352         gdbpy_err_fetch.
2353
2354 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2355
2356         * linux-nat.c (delete_lwp_cleanup): Delete.
2357         (struct lwp_deleter): New struct.
2358         (lwp_info_up): New typedef.
2359         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2360         lwp_info_up.
2361
2362 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2363
2364         * linux-fork.c (class scoped_switch_fork_info): New class.
2365         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2366
2367 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2368
2369         * valops.c (find_overload_match): Remove use of null_cleanup, and
2370         calls to do_cleanups.
2371
2372 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2373
2374         * compile/compile-cplus-types.c
2375         (compile_cplus_instance::decl_name): Handle changes to
2376         cp_func_name.
2377         * cp-support.c (cp_func_name): Update header comment, update
2378         return type.
2379         * cp-support.h (cp_func_name): Update return type in declaration.
2380         * valops.c (find_overload_match): Move temp_func local to top
2381         level of function and change its type.  Use temp_func to hold and
2382         delete temporary string obtained from cp_func_name.
2383
2384 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2385
2386         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2387         gdb::char_vector, remove cleanup, and update uses of `msg`.
2388
2389 2019-01-03  Jim Wilson  <jimw@sifive.com>
2390
2391         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2392
2393 2019-01-02  Tom Tromey  <tom@tromey.com>
2394
2395         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2396         (tdesc_parse_xml): Remove cleanups.
2397         * target-descriptions.h (make_cleanup_free_target_description):
2398         Don't declare.
2399         (target_desc_deleter): New struct.
2400         (target_desc_up): New typedef.
2401         * target-descriptions.c (target_desc_deleter::operator()): Rename
2402         from free_target_description.
2403         (make_cleanup_free_target_description): Remove.
2404
2405 2019-01-02  Tom Tromey  <tom@tromey.com>
2406
2407         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2408         constructor, destructor.
2409         (linespec_parser): Remove typedef.
2410         (~linespec_parser): Rename from linespec_parser_delete.
2411         (linespec_lex_to_end, linespec_complete_label)
2412         (linespec_complete): Update.
2413         (decode_line_full): Remove cleanups.
2414         (decode_line_1): Update.
2415
2416 2019-01-02  Tom Tromey  <tom@tromey.com>
2417
2418         * python/python-internal.h (inferior_to_inferior_object): Change
2419         return type.
2420         * python/py-exitedevent.c (create_exited_event_object): Update.
2421         * python/py-inferior.c (inferior_to_inferior_object): Return
2422         gdbpy_ref.
2423         (python_new_inferior, python_inferior_deleted)
2424         (thread_to_thread_object, delete_thread_object)
2425         (build_inferior_list, gdbpy_selected_inferior): Update.
2426         * python/py-infthread.c (create_thread_object): Update.  Also fail
2427         if inferior_to_inferior_object fails.
2428
2429 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2430
2431         * inferior.h (class inferior) <displaced_step_state>: New field.
2432         * infrun.h (struct displaced_step_state): Move here from
2433         infrun.c.  Initialize fields, add constructor.
2434         <inf>: Remove field.
2435         <reset>: New method.
2436         * infrun.c (struct displaced_step_inferior_state): Move to
2437         infrun.h.
2438         (displaced_step_inferior_states): Remove.
2439         (get_displaced_stepping_state): Adust.
2440         (displaced_step_in_progress_any_inferior): Adjust.
2441         (displaced_step_in_progress_thread): Adjust.
2442         (displaced_step_in_progress): Adjust.
2443         (add_displaced_stepping_state): Remove.
2444         (get_displaced_step_closure_by_addr): Adjust.
2445         (remove_displaced_stepping_state): Remove.
2446         (infrun_inferior_exit): Call displaced_step_state.reset.
2447         (use_displaced_stepping): Don't check for NULL.
2448         (displaced_step_prepare_throw): Call
2449         get_displaced_stepping_state.
2450         (displaced_step_fixup): Don't check for NULL.
2451         (prepare_for_detach): Don't check for NULL.
2452
2453 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2454
2455         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2456          in case of call that did not complete.
2457
2458 2019-01-02  Andrey Utkin  <autkin@undo.io>
2459
2460         * symfile.c (find_separate_debug_file): Fix search of debug files for
2461         remote debuggee.
2462
2463 2019-01-02  Tom Tromey  <tom@tromey.com>
2464
2465         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2466         indentation.
2467         * python/py-frame.c (frapy_older): Remove cast.
2468         (frapy_newer): Likewise.
2469         * python/py-breakpoint.c (local_setattro): Remove cast.
2470         * python/py-arch.c (archpy_name): Remove local variable.
2471         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2472
2473 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2474
2475         * unittests/basic_string_view/element_access/char/empty.cc:
2476         Fix year range in copyright header.
2477
2478 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2479
2480         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2481         Delete.
2482         <operator==>: Update with for removed field.
2483         <hash>: Likewise.
2484         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2485         <isa_features>: ...this.
2486         <abi_features>: New field.
2487         (riscv_isa_flen): Update comment.
2488         (riscv_abi_xlen): New declaration.
2489         (riscv_abi_flen): New declaration.
2490         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2491         isa_features.
2492         (riscv_abi_xlen): New function.
2493         (riscv_isa_flen): Update to get answer from isa_features.
2494         (riscv_abi_flen): New function.
2495         (riscv_has_fp_abi): Update to get answer from abi_features.
2496         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2497         xlen and flen.
2498         (riscv_call_info) <xlen, flen>: Update comment.
2499         (riscv_call_arg_struct): Remove invalid assertions
2500         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2501         is removed.
2502         (riscv_gdbarch_init): Gather isa features and abi features
2503         separately, ensure both match on the gdbarch when reusing an old
2504         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2505         a target with 64-bit float hardware.
2506
2507 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2508
2509         * source.c (search_command_helper): Stop reverse search
2510         when line 1 has been searched.
2511
2512 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2513
2514         * record-full.c (record_full_base_target::close): Rewrite
2515         record_full_core_buf_list free logic.
2516
2517 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2518
2519         * break-catch-syscall.c (print_one_catch_syscall): xfree
2520         the last text.
2521
2522 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2523
2524         * top.c (print_gdb_version): Update Copyright year in version
2525         message.
2526
2527 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2528
2529         Update copyright year range in all GDB files.
2530
2531 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2532
2533         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2534
2535 For older changes see ChangeLog-2018.
2536 \f
2537 Local Variables:
2538 mode: change-log
2539 left-margin: 8
2540 fill-column: 74
2541 version-control: never
2542 coding: utf-8
2543 End:
2544