40fc45283707f29f61075033dc3c9d84ce7fd63f
[external/binutils.git] / gdb / ChangeLog
1 2019-05-08  Tom Tromey  <tromey@adacore.com>
2
3         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4         when no wrap column is set.
5
6 2019-05-04  Tom Tromey  <tom@tromey.com>
7
8         * psymtab.c (psymbol_name_matches, match_partial_symbol)
9         (lookup_partial_symbol, print_partial_symbols)
10         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
11         (psymbol_compare): Update.
12         (add_psymbol_to_bcache): Clear the entire psymbol.
13         (maintenance_check_psymtabs): Update.
14         * psympriv.h (struct partial_symbol): Don't derive from
15         general_symbol_info.
16         <obj_section, unrelocated_address, address,
17         set_unrelocated_address>: Update.
18         <ginfo>: New member.
19         * dwarf-index-write.c (write_psymbols, debug_names::insert)
20         (debug_names::write_psymbols): Update.
21
22 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
23
24         * windows-nat.c [_WIN32_WINNT]: Define _WIN32_WINNT to Windows XP
25         level, so that various Windows header files expose the necessary
26         declarations and definitions.
27
28         * symfile.c (find_separate_debug_file): Remove colon from the
29         drive spec of DOS/Windows file names of the target, so that the
30         file name produced from DEBUGDIR and the target's directory will
31         be valid on DOS/Windows systems.
32
33 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
34
35         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
36         Use current_event.dwThreadId instead of main_thread_id.
37
38 2019-04-30  Tom Tromey  <tromey@adacore.com>
39
40         PR c++/24470:
41         * dwarf2read.c (process_structure_scope): Handle case where type
42         has template parameters but no symbol was created.
43
44 2019-04-19  Sergei Trofimovich <siarheit@google.com>
45
46         * configure.ac: add --enable-source-highlight switch.
47         * configure: Regenerate.
48         * top.c (print_gdb_version): plumb --enable-source-highlight
49         status to "show configuration".
50
51 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
52
53         PR symtab/24423:
54         * source.c (print_source_lines_base): Advance "iter" when a
55         control character is seen.
56
57 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
58
59         * inferior.h (struct infcall_suspend_state_deleter):
60         Catch exception in destructor to avoid crash.
61
62 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
63
64         * utils.c (prompt_for_continue): Don't restore the styling at the
65         end, as applied_style has the wrong value.  This fixes styling in
66         long lists of file names that are interrupted by the "Continue?"
67         prompt.
68
69 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
70
71         * version.in: Set GDB version number to 8.2.91.DATE-git.
72
73 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
74
75         GDB 8.2.91 released.
76
77 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
78
79         * version.in: Set GDB version number to 8.2.91.
80
81 2019-03-20  Tom Tromey  <tromey@adacore.com>
82
83         PR gdb/24391
84         * infrun.c (handle_inferior_event): Rename from
85         handle_inferior_event_1.  Create a scoped_value_mark.
86         (handle_inferior_event): Remove.
87
88 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
89
90         * source-cache.c (source_cache::get_source_lines): Re-read
91         fullname after calling open_source_file.
92
93 2019-03-18  Pedro Alves  <palves@redhat.com>
94             Eli Zaretskii <eliz@gnu.org>
95
96         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
97         m_line and m_start_of_line.
98
99 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
100
101         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
102         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
103         it returns a newline.  This fixes a regression in TU mode, whereby
104         the next line is output on the same screen line as the user input.
105
106 2019-03-18  Pedro Alves  <palves@redhat.com>
107
108         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
109         New globals.
110         (apply_style): New, factored out from ...
111         (apply_ansi_escape): ... this.  Handle reverse video mode.
112         (tui_set_reverse_mode): New function.
113         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
114         * tui/tui-winsource.c (tui_show_source_line): Use
115         tui_set_reverse_mode instead of setting A_STANDOUT.
116         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
117         New setter methods.
118
119 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
120
121         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
122         Handle tabs.
123
124 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
125
126         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
127         tui_refill_source_window instead of tui_refresh_win, to update the
128         current execution line.  This fixes redisplay of the current line
129         when stepping through the code with "next" or "step".
130
131 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
132
133         * source-cache.c (source_cache::get_source_lines): Call
134         find_source_lines to initialize s->nlines.  This fixes vertical
135         scrolling of TUI source window when the DOWN arrow is pressed.
136
137 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
138
139         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
140         wclrtoeol in tui_show_source_line".  This reverts changes made in
141         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
142
143 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
144
145         * NEWS: Combine separate "New targets" sections for 8.3.
146
147 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
148
149         The MS-Windows port of ncurses fails to switch to a color pair if
150         one or both of the colors are the implicit default colors.  This
151         change records the default colors when TUI is initialized, and
152         then specifies them explicitly when a color pair uses the default
153         colors.  This allows color styling in TUI mode on MS-Windows.
154
155         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
156         ncurses_norm_attr.
157         (tui_initialize_io) [__MINGW32__]: Record the default terminal
158         colors in ncurses_norm_attr.
159         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
160         "none", replace it with the default color recorded in
161         ncurses_norm_attr.
162
163 2019-03-14  Tom Tromey  <tromey@adacore.com>
164
165         * source-cache.h (class source_cache) <get_source_lines>: Return
166         std::string.
167         * source-cache.c (source_cache::extract_lines): Handle case where
168         first_pos==npos.  Return std::string.
169         (source_cache::get_source_lines): Update.
170
171 2019-03-14  Tom Tromey  <tromey@adacore.com>
172
173         * NEWS: Add item for "style sources" commands.
174         * source-cache.c (source_cache::get_source_lines): Check
175         source_styling.
176         * cli/cli-style.c (source_styling): New global.
177         (_initialize_cli_style): Add "style sources" commands.
178         (show_style_sources): New function.
179         * cli/cli-style.h (source_styling): Declare.
180
181 2019-03-14  Pedro Alves  <palves@redhat.com>
182             Tom Tromey  <tromey@adacore.com>
183
184         * tui/tui-winsource.h (tui_refill_source_window): Declare.
185         * tui/tui-winsource.c (tui_refill_source_window): New function,
186         from...
187         (tui_horizontal_source_scroll): ... here.  Move some logic.
188         * cli/cli-style.c (set_style_enabled): Notify new observable.
189         * tui/tui-hooks.c (tui_redisplay_source): New function.
190         (tui_attach_detach_observers): Attach or detach
191         tui_redisplay_source.
192         * observable.h (source_styling_changed): New observable.
193         * observable.c: Define source_styling_changed observable.
194
195 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
196
197         PR/24325
198         * source-cache.c: #undef open and close, to avoid unresolved
199         externals during linking.
200
201 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
202
203         Support styling on native MS-Windows console
204
205         PR/24315
206         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
207         on MS-Windows if $TERM is not defined.
208
209         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
210
211         * posix-hdep.c (gdb_console_fputs):
212         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
213         functions.
214         * ui-file.h (gdb_console_fputs): Add prototype.
215
216         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
217         back to fputs only if the former returns zero.
218
219 2019-03-07  Brian Vandenberg  <phantall@gmail.com>
220             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
221
222         PR gdb/8527
223         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
224         set_sigint_trap, clear_sigint_trap.
225
226 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
227
228         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
229         for-loop range, to avoid compiler warnings.
230
231         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
232         avoid compiler warnings about unused variables.
233
234 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
235
236         * NEWS: Mention end of support for native debugging on MS-Windows
237         before XP.
238
239 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
240
241         PR gdb/24292
242         * common/netstuff.c:
243         * gdbserver/gdbreplay.c
244         * gdbserver/remote-utils.c:
245         * ser-tcp.c:
246         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
247         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
248         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
249         'getaddrinfo' and 'freeaddrinfo' were not available before
250         Windows XP, and mingw.org's MinGW headers by default define
251         _WIN32_WINNT to 0x500.
252
253 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
254     
255         * NEWS: Note minimum Python version.
256
257 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
258
259         * version.in: Set GDB version number to 8.2.90.DATE-git.
260
261 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
262
263         GDB 8.2.90 released.
264
265 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
266
267         * version.in: Set GDB version number to 8.2.90.
268
269 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
270
271         * NEWS: Change "Changes since GDB 8.2" into "Changes in GDB 8.3".
272
273 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
274
275         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
276         * version.in: Bump version to 8.2.90.DATE-git.
277
278 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
279
280         * aix-thread.c (ptid_cmp): Remove unused variable.
281         (get_signaled_thread): Likewise.
282         (store_regs_user_thread): Likewise.
283         (store_regs_kernel_thread): Likewise.
284         (fetch_regs_kernel_thread): Remove shadowed variable.
285
286 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
287
288         * features/riscv/32bit-cpu.xml: Add register numbers.
289         * features/riscv/32bit-fpu.c: Regenerate.
290         * features/riscv/32bit-fpu.xml: Add register numbers.
291         * features/riscv/64bit-cpu.xml: Add register numbers.
292         * features/riscv/64bit-fpu.c: Regenerate.
293         * features/riscv/64bit-fpu.xml: Add register numbers.
294
295 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
296
297         * NEWS: Mention two argument form of gdb.Value constructor.
298         * python/py-value.c (convert_buffer_and_type_to_value): New
299         function.
300         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
301         Add support for handling an optional second argument.  Call
302         convert_buffer_and_type_to_value as appropriate.
303         * python/python-internal.h (Py_buffer_deleter): New struct.
304         (Py_buffer_up): New typedef.
305
306 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
307
308         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
309         instead of releasing ownership.
310
311 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
312
313         * dwarf2read.c (open_and_init_dwp_file): Call
314         elf_numsections instead of bfd_count_sections to initialize
315         dwp_file->num_sections.
316
317 2019-02-25  Tom Tromey  <tromey@adacore.com>
318
319         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
320
321 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
322
323         * gcore.in: Add '--readnever' option when invoking GDB.
324
325 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
326
327         * MAINTAINERS: Update my email address.
328
329 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
330
331         * build-id.c (build_id_to_debug_bfd_1): New function.
332         (build_id_to_debug_bfd): Look for separate debug file in
333         sysroot.
334
335 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
336
337         * gdbarch.sh: Update the copyright year range that is placed into
338         generated files.
339
340 2019-02-22  Keith Seitz  <keiths@redhat.com>
341
342         PR symtab/23853
343         * linespec.c (create_sals_line_offset): Search for the default
344         symtab's filename instead of its fullname.
345
346 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
347
348         * NEWS: Update style defaults.
349
350 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
351
352         * main.c (captured_main_1): Disable styling in batch mode.
353
354 2019-02-20  Tom Tromey  <tom@tromey.com>
355
356         * symtab.c (symtab_symbol_info): Fix typos.
357
358 2019-02-20  Tom Tromey  <tromey@adacore.com>
359
360         * findcmd.c (_initialize_mem_search): Use upper case for
361         metasyntactic variables.
362
363 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
364
365         * aarch64-tdep.c (aarch64_add_reggroups): New function.
366         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
367
368 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
369
370         * top.h (source_file_name): Change to std::string.
371         * top.c (source_file_name): Likewise.
372         (command_line_input): Adjust.
373         * cli/cli-script.c (script_from_file): Adjust.
374
375 2019-02-19  Tom Tromey  <tromey@adacore.com>
376
377         * ravenscar-thread.c
378         (ravenscar_thread_target::update_thread_list): Don't call
379         ada_build_task_list.
380         * ada-lang.h (ada_build_task_list): Don't declare.
381         * ada-tasks.c (struct ada_tasks_inferior_data)
382         <task_list_valid_p>: Now bool.
383         (read_known_tasks, ada_task_list_changed)
384         (ada_tasks_invalidate_inferior_data): Update.
385         (read_known_tasks_array): Return bool.
386         (read_known_tasks_list): Likewise.
387         (read_known_tasks): Return void.
388         (ada_build_task_list): Now static.
389
390 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
391
392         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
393         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
394
395 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
396
397         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
398         variant for ada_tasks_pspace_data_handle and
399         ada_tasks_inferior_data_handle.
400         (ada_tasks_pspace_data_cleanup): New function.
401         (ada_tasks_inferior_data_cleanup): New function.
402
403 2019-02-17  Tom Tromey  <tom@tromey.com>
404
405         * macrotab.h (macro_source_fullname): Return a std::string.
406         * macrotab.c (macro_include, check_for_redefinition)
407         (macro_undef, macro_lookup_definition, foreach_macro)
408         (foreach_macro_in_scope): Update.
409         (macro_source_fullname): Return a std::string.
410         * macrocmd.c (show_pp_source_pos): Update.
411
412 2019-02-17  Tom Tromey  <tom@tromey.com>
413
414         * macrocmd.c (show_pp_source_pos): Style the file names.
415
416 2019-02-17  Tom Tromey  <tom@tromey.com>
417
418         PR tui/24197:
419         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
420
421 2019-02-17  Tom Tromey  <tom@tromey.com>
422
423         * ada-lang.c (user_select_syms): Use filtered printing.
424         * utils.c (wrap_style): New global.
425         (desired_style): Remove.
426         (emit_style_escape): Add stream parameter.
427         (set_output_style, reset_terminal_style, prompt_for_continue):
428         Update.
429         (flush_wrap_buffer): Only flush gdb_stdout.
430         (wrap_here): Set wrap_style.
431         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
432         treat escape sequences as a character.  Change when wrap buffer is
433         flushed.
434         (fputs_styled): Do not set the output style when the default is
435         requested.
436         * ui-style.h (struct ui_file_style) <is_default>: New method.
437         * source.c (print_source_lines_base): Emit escape sequences in one
438         piece.
439
440 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
441
442         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
443         integers and enumeration types.
444
445 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
446
447         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
448         instead of lookup_symbol_in_language
449         (do_exact_match): New function.
450         (ada_get_symbol_name_matcher): Return do_exact_match when
451         doing a verbatim match.
452
453 2019-02-15  Tom Tromey  <tromey@adacore.com>
454
455         * ravenscar-thread.c (ravenscar_thread_target::resume)
456         (ravenscar_thread_target::wait): Special case wildcard requests.
457
458 2019-02-15  Tom Tromey  <tromey@adacore.com>
459
460         * ravenscar-thread.c (base_ptid): Remove.
461         (struct ravenscar_thread_target) <close>: New method.
462         <m_base_ptid>: New member.
463         <update_inferior_ptid, active_task, task_is_currently_active,
464         runtime_initialized>: Declare methods.
465         <ravenscar_thread_target>: Add constructor.
466         (ravenscar_thread_target::task_is_currently_active)
467         (ravenscar_thread_target::update_inferior_ptid)
468         (ravenscar_runtime_initialized): Rename.  Now methods.
469         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
470         (ravenscar_thread_target::update_thread_list): Update.
471         (ravenscar_thread_target::active_task): Now method.
472         (ravenscar_thread_target::store_registers)
473         (ravenscar_thread_target::prepare_to_store)
474         (ravenscar_thread_target::prepare_to_store)
475         (ravenscar_thread_target::mourn_inferior): Update.
476         (ravenscar_inferior_created): Use "new" to create target.
477         (ravenscar_thread_target::get_ada_task_ptid): Update.
478         (_initialize_ravenscar): Don't initialize base_ptid.
479         (ravenscar_ops): Remove global.
480
481 2019-02-15  Tom Tromey  <tromey@adacore.com>
482
483         * target.h (push_target): Declare new overload.
484         * target.c (push_target): New overload, taking an rvalue reference.
485         * remote.c (remote_target::open_1): Use push_target overload.
486         * corelow.c (core_target_open): Use push_target overload.
487
488 2019-02-15  Tom Tromey  <tromey@adacore.com>
489
490         * ravenscar-thread.c (is_ravenscar_task)
491         (ravenscar_task_is_currently_active): Return bool.
492         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
493         (_initialize_ravenscar): Remove "(void)".
494         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
495         Return bool.
496
497 2019-02-15  Tom Tromey  <tromey@adacore.com>
498
499         * ravenscar-thread.c (ravenscar_runtime_initializer)
500         (has_ravenscar_runtime, get_running_thread_id)
501         (ravenscar_thread_target::resume): Fix indentation.
502
503 2019-02-15  Tom Tromey  <tromey@adacore.com>
504
505         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
506         from ravenscar_arch_ops.
507         (sparc_ravenscar_ops::fetch_registers)
508         (sparc_ravenscar_ops::store_registers): Now methods.
509         (sparc_ravenscar_prepare_to_store): Remove.
510         (sparc_ravenscar_ops): Redefine.
511         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
512         methods and destructor.  Remove members.
513         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
514         (ravenscar_thread_target::store_registers)
515         (ravenscar_thread_target::prepare_to_store): Update.
516         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
517         Remove.
518         (struct ppc_ravenscar_powerpc_ops): Derive from
519         ravenscar_arch_ops.
520         (ppc_ravenscar_powerpc_ops::fetch_registers)
521         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
522         (ppc_ravenscar_powerpc_ops): Redefine.
523         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
524         (ppc_ravenscar_e500_ops::fetch_registers)
525         (ppc_ravenscar_e500_ops::store_registers): Now methods.
526         (ppc_ravenscar_e500_ops): Redefine.
527         * aarch64-ravenscar-thread.c
528         (aarch64_ravenscar_generic_prepare_to_store): Remove.
529         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
530         (aarch64_ravenscar_fetch_registers)
531         (aarch64_ravenscar_store_registers): Now methods.
532         (aarch64_ravenscar_ops): Redefine.
533
534 2019-02-15  Tom Tromey  <tromey@adacore.com>
535
536         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
537         (ravenscar_thread_target::stopped_by_hw_breakpoint)
538         (ravenscar_thread_target::stopped_by_watchpoint)
539         (ravenscar_thread_target::stopped_data_address)
540         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
541
542 2019-02-15  Tom Tromey  <tromey@adacore.com>
543
544         * ravenscar-thread.c: Fix some typos.
545
546 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
547             Tom Tromey  <tromey@adacore.com>
548
549         * ada-lang.c (ada_exception_sal): Change addr_string to a
550         std::string.
551         (create_ada_exception_catchpoint): Update.
552
553 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
554             Tom Tromey  <tromey@adacore.com>
555
556         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
557         (bp_location_ops): Remove.
558         (base_breakpoint_allocate_location): Update.
559         (free_bp_location): Update.
560         * ada-lang.c (class ada_catchpoint_location)
561         <ada_catchpoint_location>: Remove ops parameter.
562         (ada_catchpoint_location_dtor): Remove.
563         (ada_catchpoint_location_ops): Remove.
564         (allocate_location_exception): Update.
565         * breakpoint.h (struct bp_location_ops): Remove.
566         (class bp_location) <bp_location>: Remove bp_location_ops
567         parameter.
568         <~bp_location>: Add destructor.
569         <ops>: Remove.
570
571 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
572             Pedro Alves  <palves@redhat.com>
573
574         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
575         'PATH_MAX'.
576
577 2019-02-14  David Michael  <fedora.dm0@gmail.com>
578             Samuel Thibault  <samuel.thibault@gnu.org>
579             Thomas Schwinge  <thomas@codesourcery.com>
580
581         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
582         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
583
584 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
585
586         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
587         (check_empty): Use "const char *".
588
589         * gnu-nat.c (gnu_nat_target::detach): Instead of
590         'detach_inferior (pid)' call
591         'detach_inferior (find_inferior_pid (pid))'.
592
593         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
594         'nat/fork-inferior.o'.
595         * gnu-nat.c: #include "nat/fork-inferior.h".
596
597         * gnu-nat.c (gnu_nat_target::detach): Instead of
598         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
599         * gnu-nat.h: #include "inf-child.h".
600         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
601         'i386_gnu_nat_target::fetch_registers'.
602         (gnu_store_registers): Rename/move to
603         'i386_gnu_nat_target::store_registers'.
604
605         * config/i386/nm-i386gnu.h: Don't "#include" any files.
606         * gnu-nat.h (mach_thread_info): New function.
607         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
608
609         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
610
611 2019-02-14  Frederic Konrad  <konrad@adacore.com>
612
613         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
614
615 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
616
617         * windows-nat.c (windows_add_thread): Add new parameter
618         "main_thread_p" with default value set to false.  Update
619         function documentation as well as all callers.
620         (windows_delete_thread): Likewise.
621         (fake_create_process): Update call to windows_add_thread.
622         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
623         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
624         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
625         call to windows_delete_thread.
626
627 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
628
629         * MAINTAINERS: Add Andrew Burgess as global maintainer.
630
631 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
632
633         * symfile.c (find_separate_debug_file): Use canonical path of
634         sysroot with child_path instead of gdb_sysroot if it is valid.
635
636 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
637
638         * symfile.c (find_separate_debug_file): Use child_path to
639         determine if an object file is under a sysroot.
640
641 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
642
643         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
644         unittests/child-path-selftests.c.
645         * common/pathstuff.c (child_path): New function.
646         * common/pathstuff.h (child_path): New prototype.
647         * unittests/child-path-selftests.c: New file.
648
649 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
650
651         * symfile.c (find_separate_debug_file): Look for separate debug
652         files in debug directories under the sysroot.
653
654 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
655
656         * symtab.h (struct minimal_symbol data_p): New const method.
657         (struct minimal_symbol text_p): Likewise.
658         * symtab.c (output_source_filename): Use file name style
659         to print file name.
660         (print_symbol_info): Likewise.
661         (print_msymbol_info): Use address style to print addresses.
662         Use function name style to print executable text symbols.
663         (expand_symtab_containing_pc): Use data_p.
664         (find_pc_sect_compunit_symtab): Likewise.
665
666 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
667
668         * breakpoint.c (describe_other_breakpoints): Use address style
669         to print addresses.
670         (say_where): Likewise.
671
672 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
673
674         * ada-typeprint.c (print_func_type): Print function name
675         style to print function name.
676         * c-typeprint.c (c_print_type_1): Likewise.
677
678 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
679
680         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
681         for execve.
682
683 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
684
685         * c-exp.y (direct_abs_decl): Use emplace_back to record the
686         type_stack.
687
688 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
689
690         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
691         TYPE_CODE_REF types.
692
693 2019-02-08  Jim Wilson  <jimw@sifive.com>
694
695         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
696         (riscv_linux_fregset): New.
697         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
698
699 2019-02-07  Tom Tromey  <tom@tromey.com>
700
701         * thread.c (thread_cancel_execution_command): Update.
702         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
703         methods.
704         (struct thread_fsm_ops): Remove.
705         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
706         (thread_fsm_should_stop, thread_fsm_return_value)
707         (thread_fsm_set_finished, thread_fsm_finished_p)
708         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
709         Don't declare.
710         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
711         * infrun.c (clear_proceed_status_thread)
712         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
713         (print_stop_event): Update.
714         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
715         Add constructor.
716         (step_command_fsm_ops): Remove.
717         (new_step_command_fsm): Remove.
718         (step_1): Update.
719         (step_command_fsm::should_stop): Rename from
720         step_command_fsm_should_stop.
721         (step_command_fsm::clean_up): Rename from
722         step_command_fsm_clean_up.
723         (step_command_fsm::do_async_reply_reason): Rename from
724         step_command_fsm_async_reply_reason.
725         (struct until_next_fsm): Inherit from thread_fsm.  Add
726         constructor.
727         (until_next_fsm_ops): Remove.
728         (new_until_next_fsm): Remove.
729         (until_next_fsm::should_stop): Rename from
730         until_next_fsm_should_stop.
731         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
732         (until_next_fsm::do_async_reply_reason): Rename from
733         until_next_fsm_async_reply_reason.
734         (struct finish_command_fsm): Inherit from thread_fsm.  Add
735         constructor.  Change type of breakpoint.
736         (finish_command_fsm_ops): Remove.
737         (new_finish_command_fsm): Remove.
738         (finish_command_fsm::should_stop): Rename from
739         finish_command_fsm_should_stop.
740         (finish_command_fsm::clean_up): Rename from
741         finish_command_fsm_clean_up.
742         (finish_command_fsm::return_value): Rename from
743         finish_command_fsm_return_value.
744         (finish_command_fsm::do_async_reply_reason): Rename from
745         finish_command_fsm_async_reply_reason.
746         (finish_command): Update.
747         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
748         Add constructor.
749         (call_thread_fsm_ops): Remove.
750         (call_thread_fsm::call_thread_fsm): Rename from
751         new_call_thread_fsm.
752         (call_thread_fsm::should_stop): Rename from
753         call_thread_fsm_should_stop.
754         (call_thread_fsm::should_notify_stop): Rename from
755         call_thread_fsm_should_notify_stop.
756         (run_inferior_call, call_function_by_hand_dummy): Update.
757         * cli/cli-interp.c (should_print_stop_to_console): Update.
758         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
759         Add constructor.  Change type of location_breakpoint,
760         caller_breakpoint.
761         (until_break_fsm_ops): Remove.
762         (new_until_break_fsm): Remove.
763         (until_break_fsm::should_stop): Rename from
764         until_break_fsm_should_stop.
765         (until_break_fsm::clean_up): Rename from
766         until_break_fsm_clean_up.
767         (until_break_fsm::do_async_reply_reason): Rename from
768         until_break_fsm_async_reply_reason.
769         (until_break_command): Update.
770         * thread-fsm.c: Remove.
771         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
772
773 2019-02-07  Tom Tromey  <tom@tromey.com>
774
775         * yy-remap.h: Add include guard.
776         * xtensa-tdep.h: Add include guard.
777         * xcoffread.h: Rename include guard.
778         * varobj-iter.h: Add include guard.
779         * tui/tui.h: Rename include guard.
780         * tui/tui-winsource.h: Rename include guard.
781         * tui/tui-wingeneral.h: Rename include guard.
782         * tui/tui-windata.h: Rename include guard.
783         * tui/tui-win.h: Rename include guard.
784         * tui/tui-stack.h: Rename include guard.
785         * tui/tui-source.h: Rename include guard.
786         * tui/tui-regs.h: Rename include guard.
787         * tui/tui-out.h: Rename include guard.
788         * tui/tui-layout.h: Rename include guard.
789         * tui/tui-io.h: Rename include guard.
790         * tui/tui-hooks.h: Rename include guard.
791         * tui/tui-file.h: Rename include guard.
792         * tui/tui-disasm.h: Rename include guard.
793         * tui/tui-data.h: Rename include guard.
794         * tui/tui-command.h: Rename include guard.
795         * tic6x-tdep.h: Add include guard.
796         * target/waitstatus.h: Rename include guard.
797         * target/wait.h: Rename include guard.
798         * target/target.h: Rename include guard.
799         * target/resume.h: Rename include guard.
800         * target-float.h: Rename include guard.
801         * stabsread.h: Add include guard.
802         * rs6000-tdep.h: Add include guard.
803         * riscv-fbsd-tdep.h: Add include guard.
804         * regformats/regdef.h: Rename include guard.
805         * record.h: Rename include guard.
806         * python/python.h: Rename include guard.
807         * python/python-internal.h: Rename include guard.
808         * python/py-stopevent.h: Rename include guard.
809         * python/py-ref.h: Rename include guard.
810         * python/py-record.h: Rename include guard.
811         * python/py-record-full.h: Rename include guard.
812         * python/py-record-btrace.h: Rename include guard.
813         * python/py-instruction.h: Rename include guard.
814         * python/py-events.h: Rename include guard.
815         * python/py-event.h: Rename include guard.
816         * procfs.h: Add include guard.
817         * proc-utils.h: Add include guard.
818         * p-lang.h: Add include guard.
819         * or1k-tdep.h: Rename include guard.
820         * observable.h: Rename include guard.
821         * nto-tdep.h: Rename include guard.
822         * nat/x86-linux.h: Rename include guard.
823         * nat/x86-linux-dregs.h: Rename include guard.
824         * nat/x86-gcc-cpuid.h: Add include guard.
825         * nat/x86-dregs.h: Rename include guard.
826         * nat/x86-cpuid.h: Rename include guard.
827         * nat/ppc-linux.h: Rename include guard.
828         * nat/mips-linux-watch.h: Rename include guard.
829         * nat/linux-waitpid.h: Rename include guard.
830         * nat/linux-ptrace.h: Rename include guard.
831         * nat/linux-procfs.h: Rename include guard.
832         * nat/linux-osdata.h: Rename include guard.
833         * nat/linux-nat.h: Rename include guard.
834         * nat/linux-namespaces.h: Rename include guard.
835         * nat/linux-btrace.h: Rename include guard.
836         * nat/glibc_thread_db.h: Rename include guard.
837         * nat/gdb_thread_db.h: Rename include guard.
838         * nat/gdb_ptrace.h: Rename include guard.
839         * nat/fork-inferior.h: Rename include guard.
840         * nat/amd64-linux-siginfo.h: Rename include guard.
841         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
842         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
843         * nat/aarch64-linux.h: Rename include guard.
844         * nat/aarch64-linux-hw-point.h: Rename include guard.
845         * mn10300-tdep.h: Add include guard.
846         * mips-linux-tdep.h: Add include guard.
847         * mi/mi-parse.h: Rename include guard.
848         * mi/mi-out.h: Rename include guard.
849         * mi/mi-main.h: Rename include guard.
850         * mi/mi-interp.h: Rename include guard.
851         * mi/mi-getopt.h: Rename include guard.
852         * mi/mi-console.h: Rename include guard.
853         * mi/mi-common.h: Rename include guard.
854         * mi/mi-cmds.h: Rename include guard.
855         * mi/mi-cmd-break.h: Rename include guard.
856         * m2-lang.h: Add include guard.
857         * location.h: Rename include guard.
858         * linux-record.h: Rename include guard.
859         * linux-nat.h: Add include guard.
860         * linux-fork.h: Add include guard.
861         * i386-darwin-tdep.h: Rename include guard.
862         * hppa-linux-offsets.h: Add include guard.
863         * guile/guile.h: Rename include guard.
864         * guile/guile-internal.h: Rename include guard.
865         * gnu-nat.h: Rename include guard.
866         * gdb-stabs.h: Rename include guard.
867         * frv-tdep.h: Add include guard.
868         * f-lang.h: Add include guard.
869         * event-loop.h: Add include guard.
870         * darwin-nat.h: Rename include guard.
871         * cp-abi.h: Rename include guard.
872         * config/sparc/nm-sol2.h: Rename include guard.
873         * config/nm-nto.h: Rename include guard.
874         * config/nm-linux.h: Add include guard.
875         * config/i386/nm-i386gnu.h: Rename include guard.
876         * config/djgpp/nl_types.h: Rename include guard.
877         * config/djgpp/langinfo.h: Rename include guard.
878         * compile/gcc-cp-plugin.h: Add include guard.
879         * compile/gcc-c-plugin.h: Add include guard.
880         * compile/compile.h: Rename include guard.
881         * compile/compile-object-run.h: Rename include guard.
882         * compile/compile-object-load.h: Rename include guard.
883         * compile/compile-internal.h: Rename include guard.
884         * compile/compile-cplus.h: Rename include guard.
885         * compile/compile-c.h: Rename include guard.
886         * common/xml-utils.h: Rename include guard.
887         * common/x86-xstate.h: Rename include guard.
888         * common/version.h: Rename include guard.
889         * common/vec.h: Rename include guard.
890         * common/tdesc.h: Rename include guard.
891         * common/selftest.h: Rename include guard.
892         * common/scoped_restore.h: Rename include guard.
893         * common/scoped_mmap.h: Rename include guard.
894         * common/scoped_fd.h: Rename include guard.
895         * common/safe-iterator.h: Rename include guard.
896         * common/run-time-clock.h: Rename include guard.
897         * common/refcounted-object.h: Rename include guard.
898         * common/queue.h: Rename include guard.
899         * common/ptid.h: Rename include guard.
900         * common/print-utils.h: Rename include guard.
901         * common/preprocessor.h: Rename include guard.
902         * common/pathstuff.h: Rename include guard.
903         * common/observable.h: Rename include guard.
904         * common/netstuff.h: Rename include guard.
905         * common/job-control.h: Rename include guard.
906         * common/host-defs.h: Rename include guard.
907         * common/gdb_wait.h: Rename include guard.
908         * common/gdb_vecs.h: Rename include guard.
909         * common/gdb_unlinker.h: Rename include guard.
910         * common/gdb_unique_ptr.h: Rename include guard.
911         * common/gdb_tilde_expand.h: Rename include guard.
912         * common/gdb_sys_time.h: Rename include guard.
913         * common/gdb_string_view.h: Rename include guard.
914         * common/gdb_splay_tree.h: Rename include guard.
915         * common/gdb_setjmp.h: Rename include guard.
916         * common/gdb_ref_ptr.h: Rename include guard.
917         * common/gdb_optional.h: Rename include guard.
918         * common/gdb_locale.h: Rename include guard.
919         * common/gdb_assert.h: Rename include guard.
920         * common/filtered-iterator.h: Rename include guard.
921         * common/filestuff.h: Rename include guard.
922         * common/fileio.h: Rename include guard.
923         * common/environ.h: Rename include guard.
924         * common/common-utils.h: Rename include guard.
925         * common/common-types.h: Rename include guard.
926         * common/common-regcache.h: Rename include guard.
927         * common/common-inferior.h: Rename include guard.
928         * common/common-gdbthread.h: Rename include guard.
929         * common/common-exceptions.h: Rename include guard.
930         * common/common-defs.h: Rename include guard.
931         * common/common-debug.h: Rename include guard.
932         * common/cleanups.h: Rename include guard.
933         * common/buffer.h: Rename include guard.
934         * common/btrace-common.h: Rename include guard.
935         * common/break-common.h: Rename include guard.
936         * cli/cli-utils.h: Rename include guard.
937         * cli/cli-style.h: Rename include guard.
938         * cli/cli-setshow.h: Rename include guard.
939         * cli/cli-script.h: Rename include guard.
940         * cli/cli-interp.h: Rename include guard.
941         * cli/cli-decode.h: Rename include guard.
942         * cli/cli-cmds.h: Rename include guard.
943         * charset-list.h: Add include guard.
944         * buildsym-legacy.h: Rename include guard.
945         * bfin-tdep.h: Add include guard.
946         * ax.h: Rename include guard.
947         * arm-linux-tdep.h: Add include guard.
948         * arm-fbsd-tdep.h: Add include guard.
949         * arch/xtensa.h: Rename include guard.
950         * arch/tic6x.h: Add include guard.
951         * arch/i386.h: Add include guard.
952         * arch/arm.h: Rename include guard.
953         * arch/arm-linux.h: Rename include guard.
954         * arch/arm-get-next-pcs.h: Rename include guard.
955         * arch/amd64.h: Add include guard.
956         * arch/aarch64-insn.h: Rename include guard.
957         * arch-utils.h: Rename include guard.
958         * annotate.h: Add include guard.
959         * amd64-darwin-tdep.h: Rename include guard.
960         * aarch64-linux-tdep.h: Add include guard.
961         * aarch64-fbsd-tdep.h: Add include guard.
962         * aarch32-linux-nat.h: Add include guard.
963
964 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
965
966         * macrotab.c (macro_define_internal): New function that
967         factorizes macro_define_object_internal and macro_define_function
968         code.
969         (macro_define_object_internal): Use macro_define_internal.
970         (macro_define_function): Likewise.
971
972 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
973
974         * macrocmd.c (extract_identifier): Return
975         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
976         callers.
977
978 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
979
980         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
981
982 2019-02-05  Tom Tromey  <tom@tromey.com>
983
984         * target.c (target_stack::unpush): Move assertion earlier.
985
986 2019-01-30  Tom Tromey  <tom@tromey.com>
987
988         PR python/23615:
989         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
990         (gdbpy_parse_and_eval): Likewise.
991         * python/python-internal.h (gdbpy_allow_threads): New class.
992
993 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
994
995         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
996         (aarch64_fbsd_fpregmap): Move earlier.
997         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
998         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
999         instead of individual calls to trad_frame_set_reg_addr.
1000         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1001         earlier.
1002         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1003         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1004         instead of individual calls to trad_frame_set_reg_addr.
1005
1006 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1007
1008         * CONTRIBUTE: Replace contribution list with wiki link.
1009
1010 2019-01-25  Tom Tromey  <tom@tromey.com>
1011
1012         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1013
1014 2019-01-25  Tom Tromey  <tom@tromey.com>
1015
1016         * xtensa-linux-nat.c: Fix common/ includes.
1017         * xml-support.h: Fix common/ includes.
1018         * xml-support.c: Fix common/ includes.
1019         * x86-linux-nat.c: Fix common/ includes.
1020         * windows-nat.c: Fix common/ includes.
1021         * varobj.h: Fix common/ includes.
1022         * varobj.c: Fix common/ includes.
1023         * value.c: Fix common/ includes.
1024         * valops.c: Fix common/ includes.
1025         * utils.c: Fix common/ includes.
1026         * unittests/xml-utils-selftests.c: Fix common/ includes.
1027         * unittests/utils-selftests.c: Fix common/ includes.
1028         * unittests/unpack-selftests.c: Fix common/ includes.
1029         * unittests/tracepoint-selftests.c: Fix common/ includes.
1030         * unittests/style-selftests.c: Fix common/ includes.
1031         * unittests/string_view-selftests.c: Fix common/ includes.
1032         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1033         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1034         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1035         * unittests/rsp-low-selftests.c: Fix common/ includes.
1036         * unittests/parse-connection-spec-selftests.c: Fix common/
1037         includes.
1038         * unittests/optional-selftests.c: Fix common/ includes.
1039         * unittests/offset-type-selftests.c: Fix common/ includes.
1040         * unittests/observable-selftests.c: Fix common/ includes.
1041         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1042         * unittests/memrange-selftests.c: Fix common/ includes.
1043         * unittests/memory-map-selftests.c: Fix common/ includes.
1044         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1045         * unittests/function-view-selftests.c: Fix common/ includes.
1046         * unittests/environ-selftests.c: Fix common/ includes.
1047         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1048         * unittests/common-utils-selftests.c: Fix common/ includes.
1049         * unittests/cli-utils-selftests.c: Fix common/ includes.
1050         * unittests/array-view-selftests.c: Fix common/ includes.
1051         * ui-file.c: Fix common/ includes.
1052         * tui/tui-io.c: Fix common/ includes.
1053         * tracepoint.h: Fix common/ includes.
1054         * tracepoint.c: Fix common/ includes.
1055         * tracefile-tfile.c: Fix common/ includes.
1056         * top.h: Fix common/ includes.
1057         * top.c: Fix common/ includes.
1058         * thread.c: Fix common/ includes.
1059         * target/waitstatus.h: Fix common/ includes.
1060         * target/waitstatus.c: Fix common/ includes.
1061         * target.h: Fix common/ includes.
1062         * target.c: Fix common/ includes.
1063         * target-memory.c: Fix common/ includes.
1064         * target-descriptions.c: Fix common/ includes.
1065         * symtab.h: Fix common/ includes.
1066         * symfile.c: Fix common/ includes.
1067         * stap-probe.c: Fix common/ includes.
1068         * spu-linux-nat.c: Fix common/ includes.
1069         * sparc-nat.c: Fix common/ includes.
1070         * source.c: Fix common/ includes.
1071         * solib.c: Fix common/ includes.
1072         * solib-target.c: Fix common/ includes.
1073         * ser-unix.c: Fix common/ includes.
1074         * ser-tcp.c: Fix common/ includes.
1075         * ser-pipe.c: Fix common/ includes.
1076         * ser-base.c: Fix common/ includes.
1077         * selftest-arch.c: Fix common/ includes.
1078         * s12z-tdep.c: Fix common/ includes.
1079         * rust-exp.y: Fix common/ includes.
1080         * rs6000-aix-tdep.c: Fix common/ includes.
1081         * riscv-tdep.c: Fix common/ includes.
1082         * remote.c: Fix common/ includes.
1083         * remote-notif.h: Fix common/ includes.
1084         * remote-fileio.h: Fix common/ includes.
1085         * remote-fileio.c: Fix common/ includes.
1086         * regcache.h: Fix common/ includes.
1087         * regcache.c: Fix common/ includes.
1088         * record-btrace.c: Fix common/ includes.
1089         * python/python.c: Fix common/ includes.
1090         * python/py-type.c: Fix common/ includes.
1091         * python/py-inferior.c: Fix common/ includes.
1092         * progspace.h: Fix common/ includes.
1093         * producer.c: Fix common/ includes.
1094         * procfs.c: Fix common/ includes.
1095         * proc-api.c: Fix common/ includes.
1096         * printcmd.c: Fix common/ includes.
1097         * ppc-linux-nat.c: Fix common/ includes.
1098         * parser-defs.h: Fix common/ includes.
1099         * osdata.c: Fix common/ includes.
1100         * obsd-nat.c: Fix common/ includes.
1101         * nat/x86-linux.c: Fix common/ includes.
1102         * nat/x86-linux-dregs.c: Fix common/ includes.
1103         * nat/x86-dregs.h: Fix common/ includes.
1104         * nat/x86-dregs.c: Fix common/ includes.
1105         * nat/ppc-linux.c: Fix common/ includes.
1106         * nat/mips-linux-watch.h: Fix common/ includes.
1107         * nat/mips-linux-watch.c: Fix common/ includes.
1108         * nat/linux-waitpid.c: Fix common/ includes.
1109         * nat/linux-ptrace.h: Fix common/ includes.
1110         * nat/linux-ptrace.c: Fix common/ includes.
1111         * nat/linux-procfs.c: Fix common/ includes.
1112         * nat/linux-personality.c: Fix common/ includes.
1113         * nat/linux-osdata.c: Fix common/ includes.
1114         * nat/linux-namespaces.c: Fix common/ includes.
1115         * nat/linux-btrace.h: Fix common/ includes.
1116         * nat/linux-btrace.c: Fix common/ includes.
1117         * nat/fork-inferior.c: Fix common/ includes.
1118         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1119         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1120         * nat/aarch64-linux.c: Fix common/ includes.
1121         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1122         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1123         * namespace.h: Fix common/ includes.
1124         * mips-linux-tdep.c: Fix common/ includes.
1125         * minsyms.c: Fix common/ includes.
1126         * mi/mi-parse.h: Fix common/ includes.
1127         * mi/mi-main.c: Fix common/ includes.
1128         * mi/mi-cmd-env.c: Fix common/ includes.
1129         * memrange.h: Fix common/ includes.
1130         * memattr.c: Fix common/ includes.
1131         * maint.h: Fix common/ includes.
1132         * maint.c: Fix common/ includes.
1133         * main.c: Fix common/ includes.
1134         * machoread.c: Fix common/ includes.
1135         * location.c: Fix common/ includes.
1136         * linux-thread-db.c: Fix common/ includes.
1137         * linux-nat.c: Fix common/ includes.
1138         * linux-fork.c: Fix common/ includes.
1139         * inline-frame.c: Fix common/ includes.
1140         * infrun.c: Fix common/ includes.
1141         * inflow.c: Fix common/ includes.
1142         * inferior.h: Fix common/ includes.
1143         * inferior.c: Fix common/ includes.
1144         * infcmd.c: Fix common/ includes.
1145         * inf-ptrace.c: Fix common/ includes.
1146         * inf-child.c: Fix common/ includes.
1147         * ia64-linux-nat.c: Fix common/ includes.
1148         * i387-tdep.c: Fix common/ includes.
1149         * i386-tdep.c: Fix common/ includes.
1150         * i386-linux-tdep.c: Fix common/ includes.
1151         * i386-linux-nat.c: Fix common/ includes.
1152         * i386-go32-tdep.c: Fix common/ includes.
1153         * i386-fbsd-tdep.c: Fix common/ includes.
1154         * i386-fbsd-nat.c: Fix common/ includes.
1155         * guile/scm-type.c: Fix common/ includes.
1156         * guile/guile.c: Fix common/ includes.
1157         * go32-nat.c: Fix common/ includes.
1158         * gnu-nat.c: Fix common/ includes.
1159         * gdbthread.h: Fix common/ includes.
1160         * gdbarch-selftests.c: Fix common/ includes.
1161         * gdb_usleep.c: Fix common/ includes.
1162         * gdb_select.h: Fix common/ includes.
1163         * gdb_bfd.c: Fix common/ includes.
1164         * gcore.c: Fix common/ includes.
1165         * fork-child.c: Fix common/ includes.
1166         * findvar.c: Fix common/ includes.
1167         * fbsd-nat.c: Fix common/ includes.
1168         * event-top.c: Fix common/ includes.
1169         * event-loop.c: Fix common/ includes.
1170         * dwarf2read.c: Fix common/ includes.
1171         * dwarf2loc.c: Fix common/ includes.
1172         * dwarf2-frame.c: Fix common/ includes.
1173         * dwarf-index-cache.c: Fix common/ includes.
1174         * dtrace-probe.c: Fix common/ includes.
1175         * disasm-selftests.c: Fix common/ includes.
1176         * defs.h: Fix common/ includes.
1177         * csky-tdep.c: Fix common/ includes.
1178         * cp-valprint.c: Fix common/ includes.
1179         * cp-support.h: Fix common/ includes.
1180         * cp-support.c: Fix common/ includes.
1181         * corelow.c: Fix common/ includes.
1182         * completer.h: Fix common/ includes.
1183         * completer.c: Fix common/ includes.
1184         * compile/compile.c: Fix common/ includes.
1185         * compile/compile-loc2c.c: Fix common/ includes.
1186         * compile/compile-cplus-types.c: Fix common/ includes.
1187         * compile/compile-cplus-symbols.c: Fix common/ includes.
1188         * command.h: Fix common/ includes.
1189         * cli/cli-dump.c: Fix common/ includes.
1190         * cli/cli-cmds.c: Fix common/ includes.
1191         * charset.c: Fix common/ includes.
1192         * build-id.c: Fix common/ includes.
1193         * btrace.h: Fix common/ includes.
1194         * btrace.c: Fix common/ includes.
1195         * breakpoint.h: Fix common/ includes.
1196         * breakpoint.c: Fix common/ includes.
1197         * ax.h: 
1198         (enum agent_op): Fix common/ includes.
1199         * ax-general.c (struct aop_map): Fix common/ includes.
1200         * ax-gdb.c: Fix common/ includes.
1201         * auxv.c: Fix common/ includes.
1202         * auto-load.c: Fix common/ includes.
1203         * arm-tdep.c: Fix common/ includes.
1204         * arch/riscv.c: Fix common/ includes.
1205         * arch/ppc-linux-common.c: Fix common/ includes.
1206         * arch/i386.c: Fix common/ includes.
1207         * arch/arm.c: Fix common/ includes.
1208         * arch/arm-linux.c: Fix common/ includes.
1209         * arch/arm-get-next-pcs.c: Fix common/ includes.
1210         * arch/amd64.c: Fix common/ includes.
1211         * arch/aarch64.c: Fix common/ includes.
1212         * arch/aarch64-insn.c: Fix common/ includes.
1213         * arch-utils.c: Fix common/ includes.
1214         * amd64-windows-tdep.c: Fix common/ includes.
1215         * amd64-tdep.c: Fix common/ includes.
1216         * amd64-sol2-tdep.c: Fix common/ includes.
1217         * amd64-obsd-tdep.c: Fix common/ includes.
1218         * amd64-nbsd-tdep.c: Fix common/ includes.
1219         * amd64-linux-tdep.c: Fix common/ includes.
1220         * amd64-linux-nat.c: Fix common/ includes.
1221         * amd64-fbsd-tdep.c: Fix common/ includes.
1222         * amd64-fbsd-nat.c: Fix common/ includes.
1223         * amd64-dicos-tdep.c: Fix common/ includes.
1224         * amd64-darwin-tdep.c: Fix common/ includes.
1225         * agent.c: Fix common/ includes.
1226         * ada-lang.h: Fix common/ includes.
1227         * ada-lang.c: Fix common/ includes.
1228         * aarch64-tdep.c: Fix common/ includes.
1229
1230 2019-01-25  Tom Tromey  <tom@tromey.com>
1231
1232         * common/create-version.sh: Use common/version.h.
1233
1234 2019-01-24  Pedro Alves  <palves@redhat.com>
1235
1236         * infrun.c (signal_stop, signal_print, signal_program)
1237         (signal_catch, signal_pass): Now arrays instead of pointers.
1238         (update_signals_program_target, do_target_resume)
1239         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1240         * linux-nat.c (linux_nat_target::pass_signals)
1241         (linux_nat_target::create_inferior, linux_nat_target::attach):
1242         Adjust.
1243         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1244         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1245         * procfs.c (procfs_target::pass_signals): Adjust.
1246         * record-full.c (record_full_target::resume): Adjust.
1247         * remote.c (remote_target::pass_signals)
1248         (remote_target::program_signals): Adjust.
1249         * target-debug.h (target_debug_print_signals): Now takes a
1250         gdb::array_view as parameter.  Adjust.
1251         * target.h (target_ops) <pass_signals, program_signals>: Replace
1252         pointer and length parameters with gdb::array_view.
1253         (target_pass_signals, target_program_signals): Likewise.
1254         * target-delegates.c: Regenerate.
1255
1256 2019-01-24  Pedro Alves  <palves@redhat.com>
1257
1258         * common/forward-scope-exit.h
1259         (forward_scope_exit::forward_scope_exit): Pass arguments to
1260         m_bind_function directly, instead of creating a std::bind and
1261         copying that.
1262
1263 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1264
1265         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1266         for static members.
1267         (pass_in_v_vfp_candidate): Likewise.
1268
1269 2019-01-23  Tom Tromey  <tom@tromey.com>
1270             Pedro Alves  <palves@redhat.com>
1271
1272         * regcache.c (class regcache_invalidator): Remove.
1273         (regcache::raw_write): Use make_scope_exit.
1274
1275 2019-01-23  Tom Tromey  <tom@tromey.com>
1276
1277         * ui-out.h (class ui_out_emit_type): Update comment.
1278
1279 2019-01-23  Tom Tromey  <tom@tromey.com>
1280
1281         * infrun.c (fetch_inferior_event): Update comment.
1282
1283 2019-01-23  Tom Tromey  <tom@tromey.com>
1284             Pedro Alves  <palves@redhat.com>
1285
1286         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1287         parameter.
1288         (fetch_inferior_event): Use SCOPE_EXIT.
1289
1290
1291 2019-01-23  Tom Tromey  <tom@tromey.com>
1292             Pedro Alves  <palves@redhat.com>
1293
1294         * infrun.c (disable_thread_events): Delete.
1295         (stop_all_threads): Use SCOPE_EXIT.
1296
1297 2019-01-23  Tom Tromey  <tom@tromey.com>
1298             Pedro Alves  <palves@redhat.com>
1299
1300         * symfile.c: Include forward-scope-exit.h.
1301         (clear_symtab_users_cleanup): Replace forward declaration with
1302         a FORWARD_SCOPE_EXIT.
1303         (syms_from_objfile_1): Use the forward_scope_exit and
1304         gdb::optional instead of cleanup_function.
1305         (reread_symbols): Use the forward_scope_exit instead of
1306         cleanup_function.
1307         (clear_symtab_users_cleanup): Remove function.
1308
1309 2019-01-23  Tom Tromey  <tom@tromey.com>
1310             Pedro Alves  <palves@redhat.com>
1311
1312         * linux-nat.c: Include scope-exit.h.
1313         (cleanup_target_stop): Remove.
1314         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1315         SCOPE_EXIT.
1316
1317 2019-01-23  Tom Tromey  <tom@tromey.com>
1318             Pedro Alves  <palves@redhat.com>
1319
1320         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1321         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1322
1323 2019-01-23  Tom Tromey  <tom@tromey.com>
1324             Andrew Burgess  <andrew.burgess@embecosm.com>
1325             Pedro Alves  <palves@redhat.com>
1326
1327         * infrun.c (fetch_inferior_event): Use scope_exit.
1328         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1329         * top.c (execute_command): Use scope_exit.
1330         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1331         * utils.c (do_bpstat_clear_actions_cleanup)
1332         (make_bpstat_clear_actions_cleanup): Remove.
1333
1334 2019-01-23  Tom Tromey  <tom@tromey.com>
1335             Pedro Alves  <palves@redhat.com>
1336
1337         * infrun.c: Include "common/scope-exit.h"
1338         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1339         (wait_for_inferior): Use SCOPE_EXIT.
1340         (fetch_inferior_event): Use scope_exit.
1341
1342 2019-01-23  Tom Tromey  <tom@tromey.com>
1343             Pedro Alves  <palves@redhat.com>
1344
1345         * breakpoint.c (create_breakpoint): Remove cleanup.
1346
1347 2019-01-23  Tom Tromey  <tom@tromey.com>
1348             Andrew Burgess  <andrew.burgess@embecosm.com>
1349             Pedro Alves  <palves@redhat.com>
1350
1351 2019-01-23  Pedro Alves  <palves@redhat.com>
1352
1353         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1354
1355 2019-01-23  Pedro Alves  <palves@redhat.com>
1356             Andrew Burgess  <andrew.burgess@embecosm.com>
1357
1358         * gdbthread.h: Include "common/forward-scope-exit.h".
1359         (scoped_finish_thread_state): Redefine custom class in terms of
1360         forward_scope_exit.
1361
1362 2019-01-23  Pedro Alves  <palves@redhat.com>
1363             Andrew Burgess  <andrew.burgess@embecosm.com>
1364
1365         * common/forward-scope-exit.h: New file.
1366
1367 2019-01-23  Pedro Alves  <palves@redhat.com>
1368             Andrew Burgess  <andrew.burgess@embecosm.com>
1369             Tom Tromey  <tom@tromey.com>
1370
1371         * common/scope-exit.h: New file.
1372
1373 2019-01-23  Pedro Alves  <palves@redhat.com>
1374
1375         * common/preprocessor.h (ESC): Rename to ...
1376         (ESC_PARENS): ... this.
1377         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1378         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1379
1380 2019-01-23  Tom Tromey  <tom@tromey.com>
1381
1382         * language.h (class scoped_switch_to_sym_language_if_auto):
1383         Initialize m_lang in both cases.
1384
1385 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1386
1387         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1388         with XCNEW.
1389
1390 2019-01-22  Tom Tromey  <tom@tromey.com>
1391
1392         * corelow.c: Do not include sys/file.h.
1393
1394 2019-01-22  Tom Tromey  <tom@tromey.com>
1395
1396         * tui/tui-wingeneral.h: Include gdb_curses.h.
1397
1398 2019-01-22  Tom Tromey  <tom@tromey.com>
1399
1400         * source-cache.h (class source_cache) <get_source_lines,
1401         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1402
1403 2019-01-22  Tom Tromey  <tom@tromey.com>
1404
1405         * remote-fileio.h (struct remote_target): Declare.
1406
1407 2019-01-22  Tom Tromey  <tom@tromey.com>
1408
1409         * python/py-arch.c: Do not include py-ref.h.
1410         * python/py-bpevent.c: Do not include py-ref.h.
1411         * python/py-cmd.c: Do not include py-ref.h.
1412         * python/py-continueevent.c: Do not include py-ref.h.
1413         * python/py-event.h: Do not include py-ref.h.
1414         * python/py-evtregistry.c: Do not include py-ref.h.
1415         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1416         * python/py-frame.c: Do not include py-ref.h.
1417         * python/py-framefilter.c: Do not include py-ref.h.
1418         * python/py-function.c: Do not include py-ref.h.
1419         * python/py-infevents.c: Do not include py-ref.h.
1420         * python/py-linetable.c: Do not include py-ref.h.
1421         * python/py-objfile.c: Do not include py-ref.h.
1422         * python/py-param.c: Do not include py-ref.h.
1423         * python/py-prettyprint.c: Do not include py-ref.h.
1424         * python/py-progspace.c: Do not include py-ref.h.
1425         * python/py-symbol.c: Do not include py-ref.h.
1426         * python/py-symtab.c: Do not include py-ref.h.
1427         * python/py-type.c: Do not include py-ref.h.
1428         * python/py-unwind.c: Do not include py-ref.h.
1429         * python/py-utils.c: Do not include py-ref.h.
1430         * python/py-value.c: Do not include py-ref.h.
1431         * python/py-varobj.c: Do not include py-ref.h.
1432         * python/py-xmethods.c: Do not include py-ref.h.
1433         * python/python.c: Do not include py-ref.h.
1434         * varobj.c: Do not include py-ref.h.
1435
1436 2019-01-22  Tom Tromey  <tom@tromey.com>
1437
1438         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1439         keyword for bcache.
1440
1441 2019-01-22  Tom Tromey  <tom@tromey.com>
1442
1443         * compile/compile-cplus-types.c: Remove a comment by #include.
1444
1445 2019-01-22  Tom Tromey  <tom@tromey.com>
1446
1447         * compile/gcc-c-plugin.h: Include compile-internal.h.
1448
1449 2019-01-22  Tom Tromey  <tom@tromey.com>
1450
1451         * stabsread.c (EXTERN): Do not define.
1452         (symnum, next_symbol_text_func, processing_gcc_compilation)
1453         (within_function, global_sym_chain, global_stabs)
1454         (previous_stab_code, this_object_header_files)
1455         (n_this_object_header_files)
1456         (n_allocated_this_object_header_files): Define.
1457         * stabsread.h (EXTERN): Never define.  Use "extern".
1458
1459 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1460
1461         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1462         history_value.
1463
1464 2019-01-21  Tom Tromey  <tom@tromey.com>
1465
1466         * ui-out.c: Fix includes.
1467         * tui/tui-source.c: Fix includes.
1468         * target.c: Fix includes.
1469         * remote.c: Fix includes.
1470         * regcache.c: Fix includes.
1471         * python/py-block.c: Fix includes.
1472         * printcmd.c: Fix includes.
1473         * or1k-tdep.c: Fix includes.
1474         * mi/mi-main.c: Fix includes.
1475         * m32r-tdep.c: Fix includes.
1476         * csky-tdep.c: Fix includes.
1477         * compile/compile-cplus-types.c: Fix includes.
1478         * cli/cli-interp.c: Fix includes.
1479
1480 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1481
1482         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1483         for padding.
1484
1485 2019-01-16  Tom Tromey  <tom@tromey.com>
1486
1487         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1488         earlier.
1489         (struct objfile) <msymbols_range>: Move from top level.
1490         <msymbols>: New method.
1491         (class objfile_msymbols): Remove.
1492         * symtab.c (default_collect_symbol_completion_matches_break_on):
1493         Update.
1494         * symmisc.c (dump_msymbols): Update.
1495         * stabsread.c (scan_file_globals): Update.
1496         * objc-lang.c (info_selectors_command, info_classes_command)
1497         (find_methods): Update.
1498         * minsyms.c (find_solib_trampoline_target): Update.
1499         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1500         * coffread.c (coff_symfile_read): Update.
1501         * ada-lang.c (ada_lookup_simple_minsym)
1502         (ada_collect_symbol_completion_matches): Update.
1503
1504 2019-01-16  Tom Tromey  <tom@tromey.com>
1505
1506         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1507         type.  Remove no-argument constructor.
1508         <iterator::operator++>: Simplify.
1509         <begin>: Update.
1510         <end>: Use minimal_symbol_count.
1511
1512 2019-01-16  Tom Tromey  <tom@tromey.com>
1513
1514         * objfiles.h (struct objfile) <psymtabs>: New method.
1515         (class objfile_psymtabs): Remove.
1516         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1517         typedef.
1518         <range>: New method.
1519         (require_partial_symbols): Change return type.
1520         * psymtab.c (require_partial_symbols)
1521         (psym_expand_symtabs_matching): Update.
1522         * mdebugread.c (parse_partial_symbols): Update.
1523         * dbxread.c (dbx_end_psymtab): Update.
1524
1525 2019-01-15  Tom Tromey  <tom@tromey.com>
1526
1527         * symtab.c (lookup_objfile_from_block)
1528         (lookup_symbol_in_objfile_symtabs)
1529         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1530         (find_line_symtab, info_sources_command)
1531         (default_collect_symbol_completion_matches_break_on)
1532         (make_source_files_completion_list): Update.
1533         * symmisc.c (print_objfile_statistics, dump_objfile)
1534         (maintenance_print_symbols, maintenance_info_symtabs)
1535         (maintenance_check_symtabs, maintenance_info_line_tables):
1536         Update.
1537         * source.c (select_source_symtab)
1538         (forget_cached_source_info_for_objfile): Update.
1539         * objfiles.h (class objfile_compunits): Remove.
1540         (struct objfile) <compunits_range>: New typedef.
1541         (compunits): New method.
1542         * objfiles.c (objfile_relocate1): Update.
1543         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1544         * maint.c (count_symtabs_and_blocks): Update.
1545         * linespec.c (iterate_over_all_matching_symtabs): Update.
1546         * cp-support.c (add_symbol_overload_list_qualified): Update.
1547         * coffread.c (coff_symtab_read): Update.
1548         * ada-lang.c (add_nonlocal_symbols)
1549         (ada_collect_symbol_completion_matches)
1550         (ada_add_global_exceptions): Update.
1551
1552 2019-01-15  Tom Tromey  <tom@tromey.com>
1553
1554         * progspace.h (program_space) <objfiles_safe_range>: New
1555         typedef.
1556         <objfiles_safe>: New method.
1557         * objfiles.h (class all_objfiles_safe): Remove.
1558         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1559         * jit.c (jit_inferior_exit_hook): Update.
1560
1561 2019-01-17  Tom Tromey  <tom@tromey.com>
1562
1563         * progspace.h (program_space) <objfiles_range>: New typedef.
1564         <objfiles>: New method.
1565         <objfiles_head>: Rename from objfiles.
1566         (object_files): Update.
1567         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1568         * guile/scm-pretty-print.c
1569         (ppscm_find_pretty_printer_from_objfiles): Update.
1570         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1571         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1572         Update.
1573         * python/py-progspace.c (pspy_get_objfiles): Update.
1574         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1575         Update.
1576         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1577         (objfpy_lookup_objfile_by_build_id): Update.
1578         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1579         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1580         Update.
1581         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1582         (expand_symtab_containing_pc, lookup_objfile_from_block)
1583         (lookup_static_symbol, basic_lookup_transparent_type)
1584         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1585         (find_line_symtab, info_sources_command)
1586         (default_collect_symbol_completion_matches_break_on)
1587         (make_source_files_completion_list, find_main_name): Update.
1588         * symmisc.c (print_symbol_bcache_statistics)
1589         (print_objfile_statistics, maintenance_print_symbols)
1590         (maintenance_print_msymbols, maintenance_print_objfiles)
1591         (maintenance_info_symtabs, maintenance_check_symtabs)
1592         (maintenance_expand_symtabs, maintenance_info_line_tables):
1593         Update.
1594         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1595         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1596         (map_overlay_command, unmap_overlay_command)
1597         (simple_overlay_update, expand_symtabs_matching)
1598         (map_symbol_filenames): Update.
1599         * symfile-debug.c (set_debug_symfile): Update.
1600         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1601         Update.
1602         * source.c (select_source_symtab, forget_cached_source_info):
1603         Update.
1604         * solib.c (solib_read_symbols): Update.
1605         * solib-spu.c (append_ocl_sos): Update.
1606         * psymtab.c (maintenance_print_psymbols)
1607         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1608         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1609         * printcmd.c (info_symbol_command): Update.
1610         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1611         Update.
1612         * objfiles.h (class all_objfiles): Remove.
1613         * objfiles.c (have_partial_symbols, have_full_symbols)
1614         (have_minimal_symbols, qsort_cmp, update_section_map)
1615         (shared_objfile_contains_address_p)
1616         (default_iterate_over_objfiles_in_search_order): Update.
1617         * objc-lang.c (info_selectors_command, info_classes_command)
1618         (find_methods): Update.
1619         * minsyms.c (find_solib_trampoline_target): Update.
1620         * maint.c (maintenance_info_sections)
1621         (maintenance_translate_address, count_symtabs_and_blocks):
1622         Update.
1623         * main.c (captured_main_1): Update.
1624         * linux-thread-db.c (try_thread_db_load_from_pdir)
1625         (has_libpthread): Update.
1626         * linespec.c (iterate_over_all_matching_symtabs)
1627         (search_minsyms_for_name): Update.
1628         * jit.c (jit_find_objf_with_entry_addr): Update.
1629         * hppa-tdep.c (find_unwind_entry)
1630         (hppa_lookup_stub_minimal_symbol): Update.
1631         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1632         Update.
1633         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1634         (elf_gnu_ifunc_resolve_by_got): Update.
1635         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1636         * dwarf-index-write.c (save_gdb_index_command): Update.
1637         * cp-support.c (add_symbol_overload_list_qualified): Update.
1638         * breakpoint.c (create_overlay_event_breakpoint)
1639         (create_longjmp_master_breakpoint)
1640         (create_std_terminate_master_breakpoint)
1641         (create_exception_master_breakpoint): Update.
1642         * blockframe.c (find_pc_partial_function): Update.
1643         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1644         (ada_collect_symbol_completion_matches)
1645         (ada_add_global_exceptions): Update.
1646
1647 2019-01-17  Tom Tromey  <tom@tromey.com>
1648
1649         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1650         declare VEC.
1651         (solib_target_parse_libraries): Change return type.
1652         (library_list_start_segment, library_list_start_section)
1653         (library_list_end_library, library_list_start_library); Update.
1654         (solib_target_free_library_list): Remove.
1655         (solib_target_parse_libraries): Remove cleanup.  Change return
1656         type.
1657         (solib_target_current_sos): Update.
1658
1659 2019-01-17  Tom Tromey  <tromey@bapiya>
1660
1661         * valprint.c: Replace "the the" with "the".
1662         * symtab.c: Replace "the the" with "the".
1663         * solib.c: Replace "the the" with "the".
1664         * solib-dsbt.c: Replace "the the" with "the".
1665         * linespec.c: Replace "the the" with "the".
1666         * dwarf2loc.h: Replace "the the" with "the".
1667         * amd64-windows-tdep.c: Replace "the the" with "the".
1668         * aarch64-tdep.c: Replace "the the" with "the".
1669
1670 2019-01-16  Keith Seitz  <keiths@redhat.com>
1671
1672         PR gdb/23773
1673         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1674         <builder>: Rename to ..
1675         <m_builder>: ... this and make private.
1676         (dwarf2_cu::get_builder): New method.  Change all users of
1677         `builder' to use this method.
1678         (dwarf2_start_symtab): Move to ...
1679         (dwarf2_cu::start_symtab): ... here.  Update all callers
1680         (setup_type_unit_groups): Move to ...
1681         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1682         callers.
1683         (dwarf2_cu::reset_builder): New method.
1684         (process_full_compunit, process_full_type_unit): Use
1685         dwarf2_cu::reset_builder.
1686         (follow_die_offset): Record the ancestor CU if it is different
1687         from the followed DIE's CU.
1688         (follow_die_sig_1): Likewise.
1689
1690 2019-01-15  Tom Tromey  <tom@tromey.com>
1691
1692         * remote.c (class remote_state) <buf>: Now a char_vector.
1693         <buf_size>: Remove.
1694         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1695         parameter.
1696         (remote_target::getpkt_or_notif_sane_1)
1697         (remote_target::getpkt_sane)
1698         (remote_target::getpkt_or_notif_sane): Likewise.
1699         (class remote_target) <putpkt>: New overload.
1700         (remote_target::read_frame): Change type of "buf_p".  Remove
1701         sizeof_p parameter.
1702         (packet_ok): New overload.
1703         (packet_check_result): New overload.
1704         Update all uses.
1705
1706 2019-01-14  Tom Tromey  <tom@tromey.com>
1707
1708         * remote-notif.c (handle_notification, remote_notif_ack)
1709         (remote_notif_parse): Make "buf" const.
1710         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1711         const.
1712         (remote_notif_parse, remote_notif_ack, handle_notification):
1713         Likewise.
1714         * remote.c (remote_notif_stop_parse): Make "buf" const.
1715         (remote_target::remote_parse_stop_reply): Make "buf" const.
1716         (remote_notif_stop_ack): Make "buf" const.
1717
1718 2019-01-14  Tom Tromey  <tom@tromey.com>
1719
1720         * remote.c (remote_console_output): Make parameter const.
1721
1722 2019-01-14  Tom Tromey  <tom@tromey.com>
1723
1724         * target-debug.h (target_debug_print_signals): Constify.
1725         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1726         * procfs.c (procfs_target::pass_signals): Update.
1727         * linux-nat.c (linux_nat_target::pass_signals): Update.
1728         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1729         * target-delegates.c: Rebuild.
1730         * remote.c (remote_target::program_signals): Update.
1731         (remote_target::pass_signals): Update.
1732         * target.c (target_pass_signals): Constify argument.
1733         (target_program_signals): Likewise.
1734         * target.h (struct target_ops) <pass_signals, program_signals>:
1735         Constify argument.
1736         (target_pass_signals, target_program_signals): Constify argument.
1737
1738 2019-01-14  Tom Tromey  <tom@tromey.com>
1739
1740         PR tui/28819:
1741         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1742
1743 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1744
1745         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1746         field.
1747         * rs6000-tdep.c: Include reggroups.h.
1748         (IS_V_ALIAS_PSEUDOREG): Define.
1749         (rs6000_register_name): Return names for the "vX" aliases.
1750         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1751         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1752         aliases.  Call default_register_reggroup_p for all other
1753         pseudo-registers.
1754         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1755         New functions.
1756         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1757         Handle "vX" aliases.
1758         (v_alias_pseudo_register_collect): New function.
1759         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1760         (rs6000_gdbarch_init): Initialize "vX" aliases as
1761         pseudo-registers.  Restore registration of
1762         rs6000_pseudo_register_reggroup_p with
1763         set_tdesc_pseudo_register_reggroup_p.
1764
1765 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1766
1767         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1768         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1769         set_gdbarch_num_pseudo_regs.
1770
1771 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1772
1773         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1774         Remove arg prefixname, add do_set and do_show.
1775         Add member functions set_list and show_list.
1776         * cli/cli-style.c (class cli_style_option): Update accordingly.
1777         (style_set_list): Move to file scope.
1778         (style_show_list): Likewise.
1779         (set_style): Call help_list.
1780         (show_style): Call cmd_show_list.
1781         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1782         Update to use the new macro.
1783
1784 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1785
1786         * ada-lang.c (_initialize_ada_language): Expand the help text
1787         for the "catch exception" command.
1788
1789 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1790
1791         * symtab.c (matching_obj_sections): Initialize obj,
1792         declare it closer to its usage.
1793
1794 2019-01-10  Tom Tromey  <tom@tromey.com>
1795
1796         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1797         (basic_inf_threads_range): Remove.
1798         (inf_threads_range, inf_non_exited_threads_range)
1799         (safe_inf_threads_range): Use next_adapter.
1800
1801 2019-01-10  Keith Seitz  <keiths@redhat.com>
1802
1803         PR gdb/23712
1804         PR symtab/23010
1805         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1806         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1807
1808 2019-01-10  Keith Seitz  <keiths@redhat.com>
1809
1810         PR gdb/23712
1811         PR symtab/23010
1812         * dictionary.c (pending_to_vector): Remove.
1813         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1814         Remove _1 suffix, replacing functions of the same name.  Update
1815         all callers.
1816         (dict_create_hashed, dict_create_hashed_expandable)
1817         (dict_create_linear, dict_create_linear_expandable, dict_free)
1818         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1819         Make functions static.
1820
1821 2019-01-10  Keith Seitz  <keiths@redhat.com>
1822
1823         PR gdb/23712
1824         PR symtab/23010
1825         * dictionary.h (struct dictionary): Replace declaration with
1826         multidictionary.
1827         (dict_create_hashed, dict_create_hashed_expandable)
1828         (dict_create_linear, dict_create_linear_expandable)
1829         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1830         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1831         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1832         taking multidictionary argument.
1833         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1834         * block.h (struct block) <dict>: Change to multidictionary
1835         and rename `multidict'.
1836         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1837         symmisc.c: Update all dictionary references to multidictionary.
1838
1839 2019-01-10  Keith Seitz  <keiths@redhat.com>
1840
1841         PR gdb/23712
1842         PR symtab/23010
1843         * dictionary.c: Include unordered_map.
1844         (pending_to_vector): New function.
1845         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1846         Rewrite the non-"_1" functions to take vector instead
1847         of linked list.
1848         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1849         "new" _1 versions of the same name.
1850         (multidictionary): Define.
1851         (std::hash<enum language): New definition.
1852         (collate_pending_symbols_by_language, mdict_create_hashed)
1853         (mdict_create_hashed_expandable, mdict_create_linear)
1854         (mdict_create_linear_expandable, mdict_free)
1855         (find_language_dictionary, create_new_language_dictionary)
1856         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1857         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1858         (mdict_size, mdict_empty): New functions.
1859         * dictionary.h (mdict_iterator): Define.
1860
1861 2019-01-10  Pedro Alves  <palves@redhat.com>
1862
1863         * breakpoint.c (read_uploaded_action)
1864         (create_tracepoint_from_upload): Adjust to use
1865         gdb::unique_xmalloc_ptr.
1866         * ctf.c (ctf_write_uploaded_tp):
1867         (SET_ARRAY_FIELD): Use emplace_back.
1868         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1869         * tracefile-tfile.c (tfile_write_uploaded_tp):
1870         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1871         gdb::unique_xmalloc_ptr.
1872         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1873         at_string, cond_string, cmd_strings>: Replace char pointers
1874         with gdb::unique_xmalloc_ptr.
1875
1876 2019-01-10  Pedro Alves  <palves@redhat.com>
1877
1878         * solib-target.c (library_list_start_library): Don't xstrdup name.
1879
1880 2019-01-10  Pedro Alves  <palves@redhat.com>
1881
1882         * mdebugread.c (parse_partial_symbols): Use
1883         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1884
1885 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1886
1887         * linux-fork.c (scoped_switch_fork_info)
1888         <~scoped_switch_fork_info>: Fix incorrect variable name.
1889
1890 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1891
1892         * linux-fork.c (scoped_switch_fork_info)
1893         <scoped_switch_fork_info>: Make explicit.
1894         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1895
1896 2019-01-10  Tom Tromey  <tom@tromey.com>
1897
1898         * objfiles.h (objfile::reset_psymtabs): Update.
1899         * objfiles.c (objfile::objfile): Update.
1900         * psymtab.h (psymtab_storage::obstack): Update.
1901         (psymtab_storage::m_obstack): Use gdb::optional.
1902         (class psymtab_storage): Update comment.  Remove objfile
1903         parameter.
1904         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1905
1906 2019-01-10  Tom Tromey  <tom@tromey.com>
1907
1908         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1909         <free_psymtabs>: Now private.
1910         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1911         (allocate_psymtab): Use new method.
1912
1913 2019-01-10  Tom Tromey  <tom@tromey.com>
1914
1915         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1916         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1917         * mdebugread.c (parse_partial_symbols): Use
1918         allocate_dependencies.
1919         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1920         allocate_dependencies.
1921         (process_psymtab_comp_unit_reader)
1922         (build_type_psymtab_dependencies): Likewise.
1923         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1924
1925 2019-01-10  Tom Tromey  <tom@tromey.com>
1926
1927         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1928         PSYMBOL_SET_LANGUAGE.
1929         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1930
1931 2019-01-10  Tom Tromey  <tom@tromey.com>
1932
1933         * psymtab.h (psymtab_storage::obstack): New method.
1934         <m_obstack>: Rename from obstack; now private.
1935         * psymtab.c (psymtab_storage): Update.
1936         * dwarf2read.c (create_addrmap_from_index)
1937         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1938         Update.
1939
1940 2019-01-10  Tom Tromey  <tom@tromey.com>
1941
1942         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1943         * objfiles.h (objfile::reset_psymtabs): New method.
1944
1945 2019-01-10  Tom Tromey  <tom@tromey.com>
1946
1947         * symmisc.c (print_symbol_bcache_statistics): Update.
1948         (print_objfile_statistics): Update.
1949         * symfile.c (reread_symbols): Update.
1950         * psymtab.h (class psymtab_storage): New.
1951         * psymtab.c (psymtab_storage): New constructor.
1952         (~psymtab_storage): New destructor.
1953         (require_partial_symbols): Update.
1954         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1955         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1956         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1957         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1958         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1959         (start_psymtab_common, end_psymtab_common)
1960         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1961         (allocate_psymtab): Update.
1962         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1963         Update.
1964         (dump_psymtab_addrmap, maintenance_print_psymbols)
1965         (maintenance_check_psymtabs): Update.
1966         (class objfile_psymtabs): Move to objfiles.h.
1967         * psympriv.h (discard_psymtab): Now inline.
1968         (psymtab_discarder::psymtab_discarder): Update.
1969         (psymtab_discarder::~psymtab_discarder): Update.
1970         (ALL_OBJFILE_PSYMTABS): Rewrite.
1971         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1972         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1973         Remove fields.
1974         <partial_symtabs>: New field.
1975         (class objfile_psymtabs): Move from psymtab.h.  Update.
1976         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1977         psymbol_cache.
1978         (objfile::~objfile): Don't destroy psymbol_cache.
1979         * mdebugread.c (parse_partial_symbols): Update.
1980         * dwarf2read.c (create_addrmap_from_index)
1981         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1982         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1983         (add_partial_subprogram, dwarf2_ranges_read): Update.
1984         * dwarf-index-write.c (write_address_map)
1985         (write_one_signatured_type, recursively_write_psymbols)
1986         (class debug_names, class debug_names, write_psymtabs_to_index):
1987         Update.
1988
1989 2019-01-10  Tom Tromey  <tom@tromey.com>
1990
1991         * symtab.h (SYMBOL_SET_NAMES): Update.
1992         (symbol_set_names): Update.
1993         (MSYMBOL_SET_NAMES): Update.
1994         * symtab.c (symbol_set_names): Change argument to be an
1995         objfile_per_bfd_storage.
1996         * psymtab.c (add_psymbol_to_bcache): Update.
1997         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1998
1999 2019-01-10  Tom Tromey  <tom@tromey.com>
2000
2001         * symtab.c (create_demangled_names_hash): Change argument to be an
2002         objfile_per_bfd_storage.
2003         (symbol_set_names): Update.
2004
2005 2019-01-10  Tom Tromey  <tom@tromey.com>
2006
2007         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2008         init_psymbol_list.
2009         * psymtab.c (init_psymbol_list): Do nothing if already called.
2010         * psympriv.h (init_psymbol_list): Add comment.
2011         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2012         init_psymbol_list.
2013         * dbxread.c (dbx_symfile_read): Unconditionally call
2014         init_psymbol_list.
2015
2016 2019-01-10  Tom Tromey  <tom@tromey.com>
2017
2018         * xcoffread.c (scan_xcoff_symtab): Update.
2019         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2020         "where".
2021         * mdebugread.c (parse_partial_symbols)
2022         (handle_psymbol_enumerators): Update.
2023         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2024         * dbxread.c (read_dbx_symtab): Update.
2025         * psympriv.h (psymbol_placement): New enum.
2026         (add_psymbol_to_list): Update.
2027
2028 2019-01-10  Tom Tromey  <tom@tromey.com>
2029
2030         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2031         static_psymbols parameters.
2032         (scan_xcoff_symtab): Update.
2033         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2034         static_psymbols parameters.
2035         * psympriv.h (start_psymtab_common): Update.
2036         * mdebugread.c (parse_partial_symbols): Update.
2037         * dwarf2read.c (create_partial_symtab): Update.
2038         * dbxread.c (read_dbx_symtab): Update.
2039         (start_psymtab): Remove global_psymbols and static_psymbols
2040         parameters.
2041
2042 2019-01-10  Tom Tromey  <tom@tromey.com>
2043
2044         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2045         * psymtab.c (allocate_psymtab): Add comment.
2046         * psympriv.h (allocate_psymtab): Add comment.
2047         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2048         initializations.
2049         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2050
2051 2019-01-10  Tom Tromey  <tom@tromey.com>
2052
2053         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2054         Don't declare.
2055         * mipsread.c: Include mdebugread.h.
2056         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2057         Declare.
2058         * elfread.c: Include mdebugread.h.
2059
2060 2019-01-09  Tom Tromey  <tom@tromey.com>
2061
2062         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2063         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2064         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2065         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2066         (psym_lookup_symbol, psym_find_last_source_symtab)
2067         (psym_forget_cached_source_info, psym_print_stats)
2068         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2069         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2070         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2071         (psym_find_compunit_symtab_by_address)
2072         (maintenance_print_psymbols, maintenance_info_psymtabs)
2073         (maintenance_check_psymtabs): Use ranged for.
2074         * psymtab.h (class objfile_psymtabs): New.
2075         (require_partial_symbols): Return objfile_psymtabs.
2076         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2077
2078 2019-01-09  Tom Tromey  <tom@tromey.com>
2079
2080         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2081         (find_pc_mapped_section, list_overlays_command)
2082         (map_overlay_command, unmap_overlay_command)
2083         (simple_overlay_update): Use all_objfiles.
2084         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2085         * printcmd.c (info_symbol_command): Use all_objfiles.
2086         * objfiles.h (ALL_OBJSECTIONS): Remove.
2087         * maint.c (maintenance_translate_address): Use all_objfiles.
2088         * gcore.c (gcore_create_callback): Use all_objfiles.
2089         (objfile_find_memory_regions): Likewise.
2090
2091 2019-01-09  Tom Tromey  <tom@tromey.com>
2092
2093         * symtab.c (find_line_symtab, info_sources_command)
2094         (make_source_files_completion_list): Use objfile_compunits.
2095         * source.c (select_source_symtab): Use objfile_compunits.
2096         * objfiles.h (struct objfile): Update comment.
2097         (ALL_OBJFILES): Remove.
2098         (ALL_FILETABS): Remove.
2099         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2100         objfile_compunits.
2101
2102 2019-01-09  Tom Tromey  <tom@tromey.com>
2103
2104         * symmisc.c (print_objfile_statistics, dump_objfile)
2105         (maintenance_print_symbols): Use compunit_filetabs.
2106         * source.c (forget_cached_source_info_for_objfile): Use
2107         compunit_filetabs.
2108         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2109         (ALL_FILETABS): Use compunit_filetabs.
2110         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2111         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2112
2113 2019-01-09  Tom Tromey  <tom@tromey.com>
2114
2115         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2116         (compunit_filetabs): New.
2117         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2118         compunit_filetabs.
2119         (info_sources_command, make_source_files_completion_list): Remove
2120         declaration.
2121         * symmisc.c (print_objfile_statistics, dump_objfile)
2122         (maintenance_print_symbols): Remove declaration.
2123         (maintenance_info_symtabs): Use compunit_filetabs.
2124         (maintenance_info_line_tables): Likewise.
2125         * source.c (select_source_symtab): Change local variable name.
2126         (forget_cached_source_info_for_objfile): Remove declaration.
2127         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2128         * objfiles.c (objfile_relocate1): Remove declaration.
2129         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2130         declaration.
2131         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2132         * coffread.c (coff_symtab_read): Remove declaration.
2133         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2134         compunit_filetabs.
2135
2136 2019-01-09  Tom Tromey  <tom@tromey.com>
2137
2138         * symtab.c (lookup_objfile_from_block)
2139         (find_pc_sect_compunit_symtab, search_symbols)
2140         (default_collect_symbol_completion_matches_break_on): Use
2141         objfile_compunits.
2142         * objfiles.h (ALL_COMPUNITS): Remove.
2143         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2144         * cp-support.c (add_symbol_overload_list_qualified): Use
2145         objfile_compunits.
2146         * ada-lang.c (ada_collect_symbol_completion_matches)
2147         (ada_add_global_exceptions): Use objfile_compunits.
2148
2149 2019-01-09  Tom Tromey  <tom@tromey.com>
2150
2151         * source.c (select_source_symtab)
2152         (forget_cached_source_info_for_objfile): Remove declaration.
2153         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2154         declaration.
2155         * maint.c (count_symtabs_and_blocks): Remove declaration.
2156         * cp-support.c (add_symbol_overload_list_qualified): Remove
2157         declaration.
2158         * coffread.c (coff_symtab_read): Remove declaration.
2159         * symtab.c (lookup_symbol_in_objfile_symtabs)
2160         (basic_lookup_transparent_type_1): Use objfile_compunits.
2161         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2162         (info_sources_command, search_symbols)
2163         (default_collect_symbol_completion_matches_break_on)
2164         (make_source_files_completion_list): Remove declaration.
2165         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2166         (ada_collect_symbol_completion_matches)
2167         (ada_add_global_exceptions): Remove declaration.
2168         * linespec.c (iterate_over_all_matching_symtabs): Use
2169         objfile_compunits.
2170         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2171         (class objfile_compunits): New.
2172         (ALL_COMPUNITS): Use objfile_compunits.
2173         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2174         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2175         objfile_compunits.
2176         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2177
2178 2019-01-09  Tom Tromey  <tom@tromey.com>
2179
2180         * symtab.c (search_symbols)
2181         (default_collect_symbol_completion_matches_break_on): Use
2182         objfile_msymbols.
2183         * ada-lang.c (ada_lookup_simple_minsym)
2184         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2185         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2186         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2187         objfile_msymbols.
2188         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2189         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2190         * objc-lang.c (find_methods): Use objfile_msymbols.
2191         (info_selectors_command, info_classes_command): Likewise.
2192         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2193         * objfiles.h (class objfile_msymbols): New.
2194         (ALL_OBJFILE_MSYMBOLS): Remove.
2195         (ALL_MSYMBOLS): Remove.
2196
2197 2019-01-09  Tom Tromey  <tom@tromey.com>
2198
2199         * common/next-iterator.h (next_adapter): Add Iterator template
2200         parameter.
2201         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2202         (class all_objfiles_safe): New.
2203         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2204         * objfiles.c (put_objfile_before): Update comment.
2205         (add_separate_debug_objfile): Likewise.
2206         (free_all_objfiles): Use all_objfiles_safe.
2207         (objfile_purge_solibs): Likewise.
2208
2209 2019-01-09  Tom Tromey  <tom@tromey.com>
2210
2211         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2212         (expand_symtab_containing_pc, lookup_static_symbol)
2213         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2214         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2215         all_objfiles.
2216         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2217         * breakpoint.c (create_overlay_event_breakpoint)
2218         (create_longjmp_master_breakpoint)
2219         (create_std_terminate_master_breakpoint)
2220         (create_exception_master_breakpoint): Use all_objfiles.
2221         * linux-thread-db.c (try_thread_db_load_from_pdir)
2222         (has_libpthread): Use all_objfiles.
2223         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2224         * linespec.c (iterate_over_all_matching_symtabs)
2225         (search_minsyms_for_name): Use all_objfiles.
2226         * maint.c (maintenance_info_sections): Use all_objfiles.
2227         * main.c (captured_main_1): Use all_objfiles.
2228         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2229         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2230         * guile/scm-pretty-print.c
2231         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2232         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2233         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2234         (maintenance_print_msymbols): Use all_objfiles.
2235         * source.c (select_source_symtab): Use all_objfiles.
2236         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2237         * symfile.c (remove_symbol_file_command)
2238         (expand_symtabs_matching, map_symbol_filenames): Use
2239         all_objfiles.
2240         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2241         all_objfiles.
2242         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2243         * objc-lang.c (find_methods): Use all_objfiles.
2244         * objfiles.c (have_partial_symbols, have_full_symbols)
2245         (have_minimal_symbols, qsort_cmp)
2246         (default_iterate_over_objfiles_in_search_order): Use
2247         all_objfiles.
2248         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2249         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2250         (maintenance_check_psymtabs): Use all_objfiles.
2251         (ALL_PSYMTABS): Remove.
2252         * compile/compile-object-run.c (do_module_cleanup): Use
2253         all_objfiles.
2254         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2255         * cp-support.c (add_symbol_overload_list_qualified): Use
2256         all_objfiles.
2257         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2258         Use all_objfiles.
2259         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2260         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2261         all_objfiles.
2262         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2263         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2264         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2265         Uses all_objfiles.
2266         * solib.c (solib_read_symbols): Use all_objfiles
2267
2268 2019-01-09  Tom Tromey  <tom@tromey.com>
2269
2270         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2271         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2272         all_objfiles.
2273         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2274         * symmisc.c (print_symbol_bcache_statistics)
2275         (print_objfile_statistics, maintenance_print_objfiles)
2276         (maintenance_info_symtabs, maintenance_check_symtabs)
2277         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2278         all_objfiles.
2279         * source.c (forget_cached_source_info): Use all_objfiles.
2280         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2281         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2282         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2283         * objfiles.c (update_section_map): Use all_objfiles.
2284         (shared_objfile_contains_address_p): Likewise.
2285         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2286         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2287
2288 2019-01-09  Tom Tromey  <tom@tromey.com>
2289
2290         * common/next-iterator.h: New file.
2291         * objfiles.h (class all_objfiles): New.
2292         (struct objfile_iterator): New.
2293
2294 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2295
2296         * NEWS: Move the description of the changed "frame", "select-frame",
2297          and "info frame" commands to the Changed commands section.
2298
2299 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2300
2301         * gdbtypes.c (check_stub_method_group): Remove handling of old
2302         mangling schemes.
2303         * linespec.c (find_methods): Likewise.
2304         * stabsread.c (read_member_functions): Likewise.
2305         * valops.c (search_struct_method): Likewise.
2306         (value_struct_elt_for_reference): Likewise.
2307         * NEWS: Mention this change.
2308
2309 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2310
2311         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2312         print_source_lines.
2313         * source.c (print_source_lines_base): Update line number check.
2314         (print_source_lines): New function.
2315         (source_lines_range::source_lines_range): New function.
2316         * source.h (class source_lines_range): New class.
2317         (print_source_lines): New declaration.
2318
2319 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2320
2321         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2322
2323 2019-01-08  Tom Tromey  <tom@tromey.com>
2324             Simon Marchi  <simon.marchi@ericsson.com>
2325
2326         PR gdb/24060
2327         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2328         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2329         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2330         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2331         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2332         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2333
2334 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2335
2336         * source.c (select_source_symtab): Move header comment to
2337         declaration in source.h.
2338         (forget_cached_source_info_for_objfile): Likewise.
2339         (forget_cached_source_info): Likewise.
2340         (identify_source_line): Likewise.
2341         * source.h (identify_source_line): Move declaration from symtab.h
2342         and add comment from source.c
2343         (print_source_lines): Likewise.
2344         (forget_cached_source_info_for_objfile): Likewise.
2345         (forget_cached_source_info): Likewise.
2346         (select_source_symtab): Likewise.
2347         (enum print_source_lines_flag): Move definition from symtab.h.
2348         * symtab.h (identify_source_line): Move declaration to source.h.
2349         (print_source_lines): Likewise.
2350         (forget_cached_source_info_for_objfile): Likewise.
2351         (forget_cached_source_info): Likewise.
2352         (select_source_symtab): Likewise.
2353         (enum print_source_lines_flag): Move definition to source.h.
2354         * tui/tui-hooks.c: Add 'source.h' include.
2355
2356 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2357
2358         * source.c (print_source_lines_base): Handle requests to print
2359         reverse line number sequences, and guard against empty lines
2360         string.
2361
2362 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2363
2364         * source.c (print_source_lines_base): Fix skip of '\r' if next
2365         character is '\n'.
2366
2367 2019-01-06  Tom Tromey  <tom@tromey.com>
2368
2369         * c-exp.y (struct c_parse_state) <macro_original_text,
2370         expansion_obstack>: New member.
2371         (macro_original_text, expansion_obstack): Remove globals.
2372         (scan_macro_expansion, scanning_macro_expansion)
2373         (finished_macro_expansion): Update.
2374         (scan_macro_cleanup): Remove.
2375         (yylex, c_parse): Update.
2376
2377 2019-01-06  Tom Tromey  <tom@tromey.com>
2378
2379         * c-exp.y (struct c_parse_state) <strings>: New member.
2380         (operator_stoken): Update.
2381
2382 2019-01-06  Tom Tromey  <tom@tromey.com>
2383
2384         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2385         (union type_stack_elt) <typelist_val>: Now a pointer to
2386         std::vector.
2387         (type_stack_cleanup): Don't declare.
2388         (push_typelist): Update.
2389         * parse.c (pop_typelist): Return a std::vector.
2390         (push_typelist): Take a std::vector.
2391         (follow_types): Update.  Do not free args.
2392         (type_stack_cleanup): Remove.
2393         * c-exp.y (struct c_parse_state): New.
2394         (cpstate): New global.
2395         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2396         (nonempty_typelist): Update.
2397         (func_mod): Create a new vector.
2398         (c_parse): Create a c_parse_state.
2399         (check_parameter_typelist): Do not delete params.
2400         (function_method): Update.  Do not delete type_list.
2401
2402 2019-01-06  Tom Tromey  <tom@tromey.com>
2403
2404         PR gdb/28155:
2405         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2406         check_typedef.
2407         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2408         (print_return_value): Likewise.
2409
2410 2019-01-05  Tom Tromey  <tom@tromey.com>
2411
2412         * contrib/cleanup_check.py: Remove.
2413         * contrib/gcc-with-excheck: Remove.
2414         * contrib/exsummary.py: Remove.
2415         * contrib/excheck.py: Remove.
2416
2417 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2418
2419         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2420         NULL. Initialize tpprev to NULL instead of assigning it
2421         to NULL on the next statement.
2422         * windows-nat.c (windows_delete_thread): Remove check for
2423         main_thread_id before printing thread exit notifications.
2424         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2425         Remove thread ID check against main_thread_id.
2426         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2427         windows_delete_thread.
2428         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2429
2430 2019-01-04  Tom Tromey  <tom@tromey.com>
2431
2432         * compile/compile.c (_initialize_compile): Use upper case for
2433         metasyntactic variables.
2434         * symmisc.c (_initialize_symmisc): Use upper case for
2435         metasyntactic variables.
2436         * psymtab.c (_initialize_psymtab): Use upper case for
2437         metasyntactic variables.
2438         * demangle.c (demangle_command): Use upper case for metasyntactic
2439         variables.
2440         (_initialize_demangler): Likewise.
2441         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2442         variables.
2443
2444 2019-01-03  Tom Tromey  <tom@tromey.com>
2445
2446         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2447
2448 2019-01-03  Tom Tromey  <tom@tromey.com>
2449
2450         * python/py-symtab.c (salpy_str): Update.
2451         (struct salpy_sal_object) <symtab>: Now a PyObject.
2452         (salpy_dealloc): Update.
2453         (del_objfile_sal): Use gdbpy_ref.
2454
2455 2019-01-03  Tom Tromey  <tom@tromey.com>
2456
2457         * python/py-type.c (convert_field): Use new_reference.  Return
2458         gdbpy_ref.
2459         (make_fielditem): Return gdbpy_ref.
2460         (typy_fields): Update.
2461         (typy_getitem): Update.
2462         (field_name): Return gdbpy_ref.  Use new_reference.
2463         (typy_iterator_iternext): Update.
2464
2465 2019-01-03  Tom Tromey  <tom@tromey.com>
2466
2467         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2468
2469 2019-01-03  Tom Tromey  <tom@tromey.com>
2470
2471         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2472         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2473         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2474         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2475         (pspy_set_type_printers): Likewise.
2476         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2477         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2478         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2479         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2480         (objfpy_set_type_printers): Likewise.
2481
2482 2019-01-03  Tom Tromey  <tom@tromey.com>
2483
2484         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2485         (gdbpy_print_stack): Use gdbpy_err_fetch.
2486         * python/python-internal.h (class gdbpy_err_fetch): New class.
2487         (class gdbpy_enter) <m_error_type, m_error_value,
2488         m_error_traceback>: Remove.
2489         <m_error>: New member.
2490         (gdbpy_exception_to_string): Don't declare.
2491         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2492         * python/py-value.c (convert_value_from_python): Use
2493         gdbpy_err_fetch.
2494         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2495         gdbpy_exception_to_string.
2496         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2497         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2498         gdbpy_err_fetch.
2499
2500 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2501
2502         * linux-nat.c (delete_lwp_cleanup): Delete.
2503         (struct lwp_deleter): New struct.
2504         (lwp_info_up): New typedef.
2505         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2506         lwp_info_up.
2507
2508 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2509
2510         * linux-fork.c (class scoped_switch_fork_info): New class.
2511         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2512
2513 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2514
2515         * valops.c (find_overload_match): Remove use of null_cleanup, and
2516         calls to do_cleanups.
2517
2518 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2519
2520         * compile/compile-cplus-types.c
2521         (compile_cplus_instance::decl_name): Handle changes to
2522         cp_func_name.
2523         * cp-support.c (cp_func_name): Update header comment, update
2524         return type.
2525         * cp-support.h (cp_func_name): Update return type in declaration.
2526         * valops.c (find_overload_match): Move temp_func local to top
2527         level of function and change its type.  Use temp_func to hold and
2528         delete temporary string obtained from cp_func_name.
2529
2530 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2531
2532         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2533         gdb::char_vector, remove cleanup, and update uses of `msg`.
2534
2535 2019-01-03  Jim Wilson  <jimw@sifive.com>
2536
2537         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2538
2539 2019-01-02  Tom Tromey  <tom@tromey.com>
2540
2541         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2542         (tdesc_parse_xml): Remove cleanups.
2543         * target-descriptions.h (make_cleanup_free_target_description):
2544         Don't declare.
2545         (target_desc_deleter): New struct.
2546         (target_desc_up): New typedef.
2547         * target-descriptions.c (target_desc_deleter::operator()): Rename
2548         from free_target_description.
2549         (make_cleanup_free_target_description): Remove.
2550
2551 2019-01-02  Tom Tromey  <tom@tromey.com>
2552
2553         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2554         constructor, destructor.
2555         (linespec_parser): Remove typedef.
2556         (~linespec_parser): Rename from linespec_parser_delete.
2557         (linespec_lex_to_end, linespec_complete_label)
2558         (linespec_complete): Update.
2559         (decode_line_full): Remove cleanups.
2560         (decode_line_1): Update.
2561
2562 2019-01-02  Tom Tromey  <tom@tromey.com>
2563
2564         * python/python-internal.h (inferior_to_inferior_object): Change
2565         return type.
2566         * python/py-exitedevent.c (create_exited_event_object): Update.
2567         * python/py-inferior.c (inferior_to_inferior_object): Return
2568         gdbpy_ref.
2569         (python_new_inferior, python_inferior_deleted)
2570         (thread_to_thread_object, delete_thread_object)
2571         (build_inferior_list, gdbpy_selected_inferior): Update.
2572         * python/py-infthread.c (create_thread_object): Update.  Also fail
2573         if inferior_to_inferior_object fails.
2574
2575 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2576
2577         * inferior.h (class inferior) <displaced_step_state>: New field.
2578         * infrun.h (struct displaced_step_state): Move here from
2579         infrun.c.  Initialize fields, add constructor.
2580         <inf>: Remove field.
2581         <reset>: New method.
2582         * infrun.c (struct displaced_step_inferior_state): Move to
2583         infrun.h.
2584         (displaced_step_inferior_states): Remove.
2585         (get_displaced_stepping_state): Adust.
2586         (displaced_step_in_progress_any_inferior): Adjust.
2587         (displaced_step_in_progress_thread): Adjust.
2588         (displaced_step_in_progress): Adjust.
2589         (add_displaced_stepping_state): Remove.
2590         (get_displaced_step_closure_by_addr): Adjust.
2591         (remove_displaced_stepping_state): Remove.
2592         (infrun_inferior_exit): Call displaced_step_state.reset.
2593         (use_displaced_stepping): Don't check for NULL.
2594         (displaced_step_prepare_throw): Call
2595         get_displaced_stepping_state.
2596         (displaced_step_fixup): Don't check for NULL.
2597         (prepare_for_detach): Don't check for NULL.
2598
2599 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2600
2601         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2602          in case of call that did not complete.
2603
2604 2019-01-02  Andrey Utkin  <autkin@undo.io>
2605
2606         * symfile.c (find_separate_debug_file): Fix search of debug files for
2607         remote debuggee.
2608
2609 2019-01-02  Tom Tromey  <tom@tromey.com>
2610
2611         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2612         indentation.
2613         * python/py-frame.c (frapy_older): Remove cast.
2614         (frapy_newer): Likewise.
2615         * python/py-breakpoint.c (local_setattro): Remove cast.
2616         * python/py-arch.c (archpy_name): Remove local variable.
2617         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2618
2619 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2620
2621         * unittests/basic_string_view/element_access/char/empty.cc:
2622         Fix year range in copyright header.
2623
2624 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2625
2626         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2627         Delete.
2628         <operator==>: Update with for removed field.
2629         <hash>: Likewise.
2630         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2631         <isa_features>: ...this.
2632         <abi_features>: New field.
2633         (riscv_isa_flen): Update comment.
2634         (riscv_abi_xlen): New declaration.
2635         (riscv_abi_flen): New declaration.
2636         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2637         isa_features.
2638         (riscv_abi_xlen): New function.
2639         (riscv_isa_flen): Update to get answer from isa_features.
2640         (riscv_abi_flen): New function.
2641         (riscv_has_fp_abi): Update to get answer from abi_features.
2642         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2643         xlen and flen.
2644         (riscv_call_info) <xlen, flen>: Update comment.
2645         (riscv_call_arg_struct): Remove invalid assertions
2646         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2647         is removed.
2648         (riscv_gdbarch_init): Gather isa features and abi features
2649         separately, ensure both match on the gdbarch when reusing an old
2650         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2651         a target with 64-bit float hardware.
2652
2653 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2654
2655         * source.c (search_command_helper): Stop reverse search
2656         when line 1 has been searched.
2657
2658 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2659
2660         * record-full.c (record_full_base_target::close): Rewrite
2661         record_full_core_buf_list free logic.
2662
2663 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2664
2665         * break-catch-syscall.c (print_one_catch_syscall): xfree
2666         the last text.
2667
2668 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2669
2670         * top.c (print_gdb_version): Update Copyright year in version
2671         message.
2672
2673 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2674
2675         Update copyright year range in all GDB files.
2676
2677 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2678
2679         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2680
2681 For older changes see ChangeLog-2018.
2682 \f
2683 Local Variables:
2684 mode: change-log
2685 left-margin: 8
2686 fill-column: 74
2687 version-control: never
2688 coding: utf-8
2689 End:
2690