Clean up some comments in minsyms.c
[external/binutils.git] / gdb / ChangeLog
1 2019-03-25  Tom Tromey  <tromey@adacore.com>
2
3         * minsyms.c (BUNCH_SIZE): Update comment.
4         (~minimal_symbol_reader): Remove old comment.
5         (compact_minimal_symbols): Update comment.
6         (minimal_symbol_reader::install): Remove old comment.  Update
7         other comments.
8
9 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10
11         * s390-linux-nat.c: Add include.
12
13 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
14
15         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
16         Call linux_get_hwcap.
17         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
18         Likewise.
19         (aarch64_linux_get_hwcap): Remove function.
20         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
21         declaration.
22         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
23         linux_get_hwcap.
24         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
25         * linux-tdep.c (linux_get_hwcap): Add function.
26         (linux_get_hwcap2): Likewise.
27         * linux-tdep.h (linux_get_hwcap): Add declaration.
28         (linux_get_hwcap2): Likewise.
29         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
30         (ppc_linux_get_hwcap2): Likewise.
31         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
32         linux_get_hwcap.
33         (ppc_linux_nat_target::insert_watchpoint): Likewise.
34         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
35         (ppc_linux_nat_target::read_description): Likewise.
36         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
37         * s390-linux-nat.c: Likewise.
38         * s390-linux-tdep.c (s390_core_read_description): Likewise.
39
40 2019-03-24  Tom Tromey  <tom@tromey.com>
41
42         * ada-lang.c (standard_lookup): Simplify initialization.
43         (ada_lookup_symbol_nonlocal): Simplify return.
44         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
45         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
46         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
47         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
48         initialization.
49         * solib.c (solib_global_lookup): Simplify.
50         * symtab.c (null_block_symbol): Remove.
51         (symbol_cache_lookup): Simplify returns.
52         (lookup_language_this): Simplify returns.
53         (lookup_symbol_aux): Simplify return.
54         (lookup_local_symbol): Simplify returns.
55         (lookup_global_symbol_from_objfile): Simplify return.
56         (lookup_symbol_in_objfile_symtabs)
57         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
58         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
59         (lookup_static_symbol, lookup_global_symbol): Simplify return.
60         * cp-namespace.c (cp_lookup_bare_symbol)
61         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
62         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
63         (cp_lookup_nested_symbol): Don't use null_block_symbol.
64         (cp_lookup_symbol_via_imports): Simplify initialization.
65         (find_symbol_in_baseclass): Likewise.
66         * symtab.h (null_block_symbol): Remove.
67         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
68         (d_lookup_nested_symbol, d_lookup_symbol_imports)
69         (d_lookup_symbol_module): Likewise.
70         (find_symbol_in_baseclass): Simplify initialization.
71
72 2019-03-24  Tom Tromey  <tom@tromey.com>
73
74         * expression.h: Don't include symtab.h.
75         (struct block): Forward declare.
76
77 2019-03-24  Tom Tromey  <tom@tromey.com>
78
79         * c-exp.y (typebase): Remove casts.
80         * gdbtypes.c (lookup_unsigned_typename, )
81         (lookup_signed_typename): Remove cast.
82         * eval.c (parse_to_comma_and_eval): Remove cast.
83         * parse.c (write_dollar_variable): Remove cast.
84         * block.h (struct block) <superblock>: Now const.
85         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
86         * psymtab.c (psym_map_matching_symbols): Make "block" const.
87         (map_block): Make "block" const.
88         * symfile.h (struct quick_symbol_functions)
89         <map_matching_symbols>: Constify block argument to "callback".
90         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
91         const.
92         (find_pc_sect_compunit_symtab): Make "b" const.
93         (find_symbol_at_address): Likewise.
94         (search_symbols): Likewise.
95         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
96         (dw2_debug_names_lookup_symbol): Likewise.
97         (dw2_map_matching_symbols): Update.
98         * p-valprint.c (pascal_val_print): Remove "block".
99         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
100         (aux_add_nonlocal_symbols): Make "block" const.
101         (resolve_subexp): Remove cast.
102         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
103         const.
104         (iterate_over_file_blocks): Likewise.
105         * f-exp.y (%union) <bval>: Remove.
106         * coffread.c (patch_opaque_types): Make "b" const.
107         * spu-tdep.c (spu_catch_start): Make "block" const.
108         * c-valprint.c (print_unpacked_pointer): Remove "block".
109         * symmisc.c (dump_symtab_1): Make "b" const.
110         (block_depth): Make "block" const.
111         * d-exp.y (%union) <bval>: Remove.
112         * cp-support.h (cp_lookup_rtti_type): Update.
113         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
114         * psymtab.c (psym_lookup_symbol): Make "block" const.
115         (maintenance_check_psymtabs): Make "b" const.
116         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
117         (enumerate_locals, enumerate_args): Update.
118         * python/py-symtab.c (stpy_global_block): Make "block" const.
119         (stpy_static_block): Likewise.
120         * inline-frame.c (block_starting_point_at): Make "new_block"
121         const.
122         * block.c (find_block_in_blockvector): Make return type const.
123         (blockvector_for_pc_sect): Make "b" const.
124         (find_block_in_blockvector): Make "b" const.
125
126 2019-03-23  Tom Tromey  <tom@tromey.com>
127
128         * varobj.c (varobj_create): Update.
129         * symfile.c (clear_symtab_users): Don't reset innermost_block.
130         * printcmd.c (display_command, do_one_display): Don't reset
131         innermost_block.
132         * parser-defs.h (enum innermost_block_tracker_type): Move to
133         expression.h.
134         (innermost_block): Update comment.
135         * parse.c (parse_exp_1): Add tracker_types parameter.
136         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
137         tracker_types parameter.  Reset innermost_block.
138         (parse_exp_in_context): Remove.
139         (parse_expression_for_completion): Update.
140         * objfiles.c (~objfile): Don't reset expression_context_block or
141         innermost_block.
142         * expression.h (enum innermost_block_tracker_type): Move from
143         parser-defs.h.
144         (parse_exp_1): Add tracker_types parameter.
145         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
146         reset innermost_block.
147
148 2019-03-23  Tom Tromey  <tom@tromey.com>
149
150         * objfiles.h: Include bcache.h.
151
152 2019-03-23  Tom Tromey  <tom@tromey.com>
153
154         * linespec.c (get_current_search_block): Use
155         scoped_restore_current_language.
156         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
157
158 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
159             Jiong Wang  <jiong.wang@arm.com>
160
161         * aarch64-linux-tdep.c
162         (aarch64_linux_iterate_over_regset_sections): Check for pauth
163         section.
164         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
165
166 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
167             Jiong Wang  <jiong.wang@arm.com>
168
169         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
170         instructions.
171         (aarch64_analyze_prologue_test): Add PACIASP test.
172         (aarch64_prologue_prev_register): Unmask PC value.
173
174 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
175             Jiong Wang  <jiong.wang@arm.com>
176
177         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
178         (aarch64_dwarf2_prev_register): Unmask PC value.
179         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
180         (aarch64_execute_dwarf_cfa_vendor_op): Check for
181         DW_CFA_AARCH64_negate_ra_state.
182         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
183
184 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
185             Jiong Wang  <jiong.wang@arm.com>
186
187         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
188         registers.
189         (aarch64_pseudo_register_name): Likewise.
190         (aarch64_pseudo_register_type): Likewise.
191         (aarch64_pseudo_register_reggroup_p): Likewise.
192         (aarch64_gdbarch_init): Add pauth registers.
193         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
194         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
195         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
196         (struct gdbarch_tdep): Add regnum for ra_state.
197
198 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
199             Jiong Wang  <jiong.wang@arm.com>
200
201         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
202
203 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
204             Jiong Wang  <jiong.wang@arm.com>
205
206         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
207         function.
208         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
209         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
210         (aarch64_gdbarch_init): Add puth registers.
211         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
212         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
213         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
214
215 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
216             Jiong Wang  <jiong.wang@arm.com>
217
218         * aarch64-linux-nat.c
219         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
220         * aarch64-linux-tdep.c
221         (aarch64_linux_core_read_description): Likewise.
222         (aarch64_linux_get_hwcap): New function.
223         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
224         (aarch64_linux_get_hwcap): New declaration.
225
226 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
227             Jiong Wang  <jiong.wang@arm.com>
228
229         * aarch64-linux-nat.c
230         (aarch64_linux_nat_target::read_description): Add pauth param.
231         * aarch64-linux-tdep.c
232         (aarch64_linux_core_read_description): Likewise.
233         * aarch64-tdep.c (struct target_desc): Add in pauth.
234         (aarch64_read_description): Add pauth param.
235         (aarch64_gdbarch_init): Likewise.
236         * aarch64-tdep.h (aarch64_read_description): Likewise.
237         * arch/aarch64.c (aarch64_create_target_description): Likewise.
238         * arch/aarch64.h (aarch64_create_target_description): Likewise.
239         * features/Makefile: Add new files.
240         * features/aarch64-pauth.c: New file.
241         * features/aarch64-pauth.xml: New file.
242
243 2019-03-20  Tom Tromey  <tromey@adacore.com>
244
245         * infrun.c (handle_inferior_event): Rename from
246         handle_inferior_event_1.  Create a scoped_value_mark.
247         (handle_inferior_event): Remove.
248
249 2019-03-19  Tom Tromey  <tromey@adacore.com>
250
251         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
252         * infrun.h (print_stop_event): Add "displays" parameter.
253         * infrun.c (print_stop_event): Add "displays" parameter.
254
255 2019-03-19  Pedro Alves  <palves@redhat.com>
256
257         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
258         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
259         to -1.  Fix TABs vs spaces.
260         (tui_ui_out::tui_ui_out): Don't initialize fields here.
261         * tui/tui-out.h (tui_ui_out) Add intro comments.
262         <m_line, m_start_of_line>: In-class initialize, and add describing
263         comment.
264
265 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
266
267         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
268         variable names.
269         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
270
271 2019-03-18  Pedro Alves  <palves@redhat.com>
272             Eli Zaretskii <eliz@gnu.org>
273
274         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
275         m_line and m_start_of_line.
276
277 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
278
279         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
280         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
281         it returns a newline.  This fixes a regression in TU mode, whereby
282         the next line is output on the same screen line as the user input.
283
284 2019-03-18  Tom Tromey  <tromey@adacore.com>
285
286         * minsyms.c (minimal_symbol_reader::install): Remove call to
287         obstack_blank.
288
289 2019-03-18  Pedro Alves  <palves@redhat.com>
290
291         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
292         New globals.
293         (apply_style): New, factored out from ...
294         (apply_ansi_escape): ... this.  Handle reverse video mode.
295         (tui_set_reverse_mode): New function.
296         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
297         * tui/tui-winsource.c (tui_show_source_line): Use
298         tui_set_reverse_mode instead of setting A_STANDOUT.
299         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
300         New setter methods.
301
302 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
303
304         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
305         Handle tabs.
306
307 2019-03-18  Tom Tromey  <tromey@adacore.com>
308
309         * ada-lang.c (empty_array): Add "high" parameter.
310         (ada_evaluate_subexp): Update.
311
312 2019-03-17  Sergei Trofimovich <siarheit@google.com>
313
314         * unittests/string_view-selftests.c: Define
315         _initialize_string_view_selftests unconditionally.
316
317 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
318
319         PR gdb/24350
320         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
321
322 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
323
324         PR gdb/24351
325         * windows-nat.c (display_selector): Fix format specifiers.
326
327 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
328
329         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
330         tui_refill_source_window instead of tui_refresh_win, to update the
331         current execution line.  This fixes redisplay of the current line
332         when stepping through the code with "next" or "step".
333
334 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
335
336         * source-cache.c (source_cache::get_source_lines): Call
337         find_source_lines to initialize s->nlines.  This fixes vertical
338         scrolling of TUI source window when the DOWN arrow is pressed.
339
340 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
341
342         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
343         linux-thread-db.c (_initialize_thread_db): Likewise.
344
345 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
346
347         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
348         wclrtoeol in tui_show_source_line".  This reverts changes made in
349         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
350
351 2019-03-15  Tom Tromey  <tom@tromey.com>
352
353         * symtab.h (struct minimal_symbol): Derive from
354         general_symbol_info.
355         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
356         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
357         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
358         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
359         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
360         (MSYMBOL_SEARCH_NAME): Update.
361         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
362         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
363         * minsyms.c (minimal_symbol_reader::record_full): Update.
364
365 2019-03-15  Tom Tromey  <tom@tromey.com>
366
367         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
368
369 2019-03-15  Tom Tromey  <tom@tromey.com>
370
371         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
372         unique_xmalloc_ptr.
373         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
374         Update.
375         * minsyms.c (lookup_minimal_symbol_by_pc_section)
376         (build_minimal_symbol_hash_tables)
377         (minimal_symbol_reader::install): Update.
378
379 2019-03-15  Tom Tromey  <tom@tromey.com>
380
381         * symtab.c (create_demangled_names_hash): Update.
382         (symbol_set_names): Update.
383         * objfiles.h (struct objfile_per_bfd_storage)
384         <demangled_names_hash>: Now an htab_up.
385         * objfiles.c (objfile_per_bfd_storage): Simplify.
386
387 2019-03-15  Tom Tromey  <tom@tromey.com>
388
389         * objfiles.h (struct objfile_per_bfd_storage): Declare
390         destructor.
391         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
392         New.
393         (get_objfile_bfd_data): Use new.  Don't initialize
394         language_of_main.
395         (free_objfile_per_bfd_storage): Remove.
396         (objfile_bfd_data_free, objfile::~objfile): Use delete.
397
398 2019-03-15  Tom Tromey  <tom@tromey.com>
399
400         * symfile.c (reread_symbols): Update.
401         * objfiles.c (objfile::objfile): Update.
402         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
403         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
404         comment.
405         (minimal_symbol_reader::install): Update.
406         (terminate_minimal_symbol_table): Remove.
407         * jit.c (jit_object_close_impl): Update.
408
409 2019-03-15  Tom Tromey  <tom@tromey.com>
410
411         * minsyms.c (minimal_symbol_reader::record_full): Remove some
412         initializations.
413
414 2019-03-15  Tom Tromey  <tom@tromey.com>
415
416         * objfiles.h (struct objfile_per_bfd_storage)
417         <demangled_hash_languages>: Now a bitset.
418         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
419         (lookup_minimal_symbol): Update.
420
421 2019-03-15  Tom Tromey  <tom@tromey.com>
422
423         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
424         Don't return the symbol.
425         * coffread.c (record_minimal_symbol): Use record_full.
426
427 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
428
429         The MS-Windows port of ncurses fails to switch to a color pair if
430         one or both of the colors are the implicit default colors.  This
431         change records the default colors when TUI is initialized, and
432         then specifies them explicitly when a color pair uses the default
433         colors.  This allows color styling in TUI mode on MS-Windows.
434
435         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
436         ncurses_norm_attr.
437         (tui_initialize_io) [__MINGW32__]: Record the default terminal
438         colors in ncurses_norm_attr.
439         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
440         "none", replace it with the default color recorded in
441         ncurses_norm_attr.
442
443 2019-03-14  Tom Tromey  <tromey@adacore.com>
444
445         * source-cache.h (class source_cache) <get_source_lines>: Return
446         std::string.
447         * source-cache.c (source_cache::extract_lines): Handle case where
448         first_pos==npos.  Return std::string.
449         (source_cache::get_source_lines): Update.
450
451 2019-03-14  Tom Tromey  <tromey@adacore.com>
452
453         * NEWS: Add item for "style sources" commands.
454         * source-cache.c (source_cache::get_source_lines): Check
455         source_styling.
456         * cli/cli-style.c (source_styling): New global.
457         (_initialize_cli_style): Add "style sources" commands.
458         (show_style_sources): New function.
459         * cli/cli-style.h (source_styling): Declare.
460
461 2019-03-14  Pedro Alves  <palves@redhat.com>
462             Tom Tromey  <tromey@adacore.com>
463
464         * tui/tui-winsource.h (tui_refill_source_window): Declare.
465         * tui/tui-winsource.c (tui_refill_source_window): New function,
466         from...
467         (tui_horizontal_source_scroll): ... here.  Move some logic.
468         * cli/cli-style.c (set_style_enabled): Notify new observable.
469         * tui/tui-hooks.c (tui_redisplay_source): New function.
470         (tui_attach_detach_observers): Attach or detach
471         tui_redisplay_source.
472         * observable.h (source_styling_changed): New observable.
473         * observable.c: Define source_styling_changed observable.
474
475 2019-03-13  Tom Tromey  <tromey@adacore.com>
476
477         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
478         (i386_gnu_nat_target::store_registers): Update.
479         * target-debug.h (target_debug_print_std_string): New macro.
480         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
481         * windows-tdep.c (display_one_tib): Update.
482         * tui/tui-stack.c (tui_make_status_line): Update.
483         * top.c (print_inferior_quit_action): Update.
484         * thread.c (thr_try_catch_cmd): Update.
485         (add_thread_with_info): Update.
486         (thread_target_id_str): Update.
487         (thr_try_catch_cmd): Update.
488         (thread_command): Update.
489         (thread_find_command): Update.
490         * record-btrace.c (record_btrace_target::info_record)
491         (record_btrace_resume_thread, record_btrace_target::resume)
492         (record_btrace_cancel_resume, record_btrace_step_thread)
493         (record_btrace_target::wait, record_btrace_target::wait)
494         (record_btrace_target::wait, record_btrace_target::stop): Update.
495         * progspace.c (print_program_space): Update.
496         * process-stratum-target.c
497         (process_stratum_target::thread_address_space): Update.
498         * linux-fork.c (linux_fork_mourn_inferior)
499         (detach_checkpoint_command, info_checkpoints_command)
500         (linux_fork_context): Update.
501         (linux_fork_detach): Update.
502         (class scoped_switch_fork_info): Update.
503         (delete_checkpoint_command): Update.
504         * infrun.c (follow_fork_inferior): Update.
505         (follow_fork_inferior): Update.
506         (proceed_after_vfork_done): Update.
507         (handle_vfork_child_exec_or_exit): Update.
508         (follow_exec): Update.
509         (displaced_step_prepare_throw): Update.
510         (displaced_step_restore): Update.
511         (start_step_over): Update.
512         (resume_1): Update.
513         (clear_proceed_status_thread): Update.
514         (proceed): Update.
515         (print_target_wait_results): Update.
516         (do_target_wait): Update.
517         (context_switch): Update.
518         (stop_all_threads): Update.
519         (restart_threads): Update.
520         (finish_step_over): Update.
521         (handle_signal_stop): Update.
522         (switch_back_to_stepped_thread): Update.
523         (keep_going_pass_signal): Update.
524         (print_exited_reason): Update.
525         (normal_stop): Update.
526         * inferior.c (inferior_pid_to_str): Change return type.
527         (print_selected_inferior): Update.
528         (add_inferior): Update.
529         (detach_inferior): Update.
530         * dummy-frame.c (fprint_dummy_frames): Update.
531         * dcache.c (dcache_info_1): Update.
532         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
533         (btrace_fetch, btrace_clear): Update.
534         * linux-tdep.c (linux_core_pid_to_str): Change return type.
535         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
536         type.
537         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
538         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
539         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
540         * gdbarch.c, gdbarch.h: Rebuild.
541         * gdbarch.sh (core_pid_to_str): Change return type.
542         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
543         return type.
544         (windows_nat_target::pid_to_str): Change return type.
545         (windows_delete_thread): Update.
546         (windows_nat_target::attach): Update.
547         (windows_nat_target::files_info): Update.
548         * target-delegates.c: Rebuild.
549         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
550         return type.
551         (sol_thread_target::pid_to_str): Change return type.
552         * remote.c (class remote_target) <pid_to_str>: Change return
553         type.
554         (remote_target::pid_to_str): Change return type.
555         (extended_remote_target::attach, remote_target::remote_stop_ns)
556         (remote_target::remote_notif_remove_queued_reply)
557         (remote_target::push_stop_reply, remote_target::disable_btrace):
558         Update.
559         (extended_remote_target::attach): Update.
560         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
561         type.
562         (gdbsim_target::pid_to_str): Change return type.
563         * ravenscar-thread.c (struct ravenscar_thread_target)
564         <pid_to_str>: Change return type.
565         (ravenscar_thread_target::pid_to_str): Change return type.
566         * procfs.c (class procfs_target) <pid_to_str>: Change return
567         type.
568         (procfs_target::pid_to_str): Change return type.
569         (procfs_target::attach): Update.
570         (procfs_target::detach): Update.
571         (procfs_target::fetch_registers): Update.
572         (procfs_target::store_registers): Update.
573         (procfs_target::wait): Update.
574         (procfs_target::files_info): Update.
575         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
576         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
577         return type.
578         (nto_procfs_target::pid_to_str): Change return type.
579         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
580         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
581         return type.
582         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
583         (exit_lwp): Update.
584         (attach_proc_task_lwp_callback, get_detach_signal)
585         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
586         (linux_nat_target::resume, wait_lwp, stop_callback)
587         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
588         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
589         (linux_nat_wait_1, resume_stopped_resumed_lwps)
590         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
591         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
592         type.
593         (inf_ptrace_target::attach): Update.
594         (inf_ptrace_target::files_info): Update.
595         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
596         type.
597         (go32_nat_target::pid_to_str): Change return type.
598         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
599         (gnu_nat_target::wait): Update.
600         (gnu_nat_target::wait): Update.
601         (gnu_nat_target::resume): Update.
602         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
603         (fbsd_nat_target::wait): Update.
604         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
605         type.
606         (darwin_nat_target::attach): Update.
607         * corelow.c (class core_target) <pid_to_str>: Change return type.
608         (core_target::pid_to_str): Change return type.
609         * target.c (normal_pid_to_str): Change return type.
610         (default_pid_to_str): Likewise.
611         (target_pid_to_str): Change return type.
612         (target_translate_tls_address): Update.
613         (target_announce_detach): Update.
614         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
615         return type.
616         (bsd_uthread_target::pid_to_str): Change return type.
617         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
618         type.
619         (bsd_kvm_target::pid_to_str): Change return type.
620         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
621         return type.
622         (aix_thread_target::pid_to_str): Change return type.
623         * target.h (struct target_ops) <pid_to_str>: Change return type.
624         (target_pid_to_str, normal_pid_to_str): Likewise.
625         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
626         type.
627         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
628         type.
629         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
630         return type.
631         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
632         type.
633         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
634         type.
635         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
636         return type.
637
638 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
639
640         * NEWS: Mention that the new default MI version is 3.  Mention
641         changes to the output of commands and events that deal with
642         multi-location breakpoints.
643         * breakpoint.c: Include "mi/mi-out.h".
644         (print_one_breakpoint): Change output syntax if using MI version
645         >= 3.
646         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
647         New.
648         (mi_multi_location_breakpoint_output_fixed): New.
649         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
650         (mi_cmd_fix_multi_location_breakpoint_output): New.
651         (mi_multi_location_breakpoint_output_fixed): New.
652         * mi/mi-cmds.c (mi_cmds): Register command
653         -fix-multi-location-breakpoint-output.
654         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
655         interpreter "mi".
656
657 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
658
659         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
660         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
661         instantiate mi_ui_out based on interpreter name.
662         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
663         * mi/mi-main.c (mi_load_progress): Likewise.
664
665 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
666
667         * NEWS: Combine separate "New targets" sections for 8.3.
668
669 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
670
671         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
672         (ppcfbsd_init_abi): Install gdbarch
673         "fetch_tls_load_module_address" and "get_thread_local_address"
674         methods.
675
676 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
677
678         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
679         (riscv_fbsd_init_abi): Install gdbarch
680         "fetch_tls_load_module_address" and "get_thread_local_address"
681         methods.
682
683 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
684
685         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
686         (i386fbsd_init_abi): Install gdbarch
687         "fetch_tls_load_module_address" and "get_thread_local_address"
688         methods.
689
690 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
691
692         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
693         (amd64fbsd_init_abi): Install gdbarch
694         "fetch_tls_load_module_address" and "get_thread_local_address"
695         methods.
696
697 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
698
699         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
700         (struct fbsd_pspace_data): New type.
701         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
702         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
703         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
704         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
705         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
706
707 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
708
709         * gdbtypes.c (lookup_struct_elt): New function.
710         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
711         * gdbtypes.h (struct struct_elt): New type.
712         (lookup_struct_elt): New prototype.
713
714 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
715
716         * gdbtypes.c (lookup_struct_elt_type): Update comment and
717         remove disabled code block.
718
719 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
720
721         * gdbarch.sh (get_thread_local_address): New method.
722         * gdbarch.h, gdbarch.c: Regenerate.
723         * target.c (target_translate_tls_address): Use
724         gdbarch_get_thread_local_address if present instead of
725         target::get_thread_local_address.
726
727 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
728
729         * target.h (target::get_thread_local_address): Update comment.
730
731 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
732
733         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
734         objfile->separate_debug_objfile_backlink if not NULL.
735
736 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
737
738         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
739         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
740         (amd64bsd_store_inferior_registers): Likewise.
741         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
742         Enable segment base registers.
743         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
744         PT_GETFSBASE and PT_GETGSBASE.
745         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
746         PT_SETGSBASE.
747         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
748         segment base registers.
749         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
750
751 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
752
753         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
754         Update calls to i386_target_description to add 'segments'
755         parameter.
756         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
757         add segment base registers.
758         * arch/i386.c (i386_create_target_description): Add 'segments'
759         parameter to enable segment base registers.
760         * arch/i386.h (i386_create_target_description): Likewise.
761         * features/i386/32bit-segments.xml: New file.
762         * features/i386/32bit-segments.c: Generate.
763         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
764         call to i386_target_description to add 'segments' parameter.
765         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
766         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
767         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
768         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
769         if feature is present.
770         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
771         Add 'segments' parameter to call to i386_target_description.
772         (i386_target_description): Add 'segments' parameter to enable
773         segment base registers.
774         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
775         to call to i386_target_description.
776         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
777         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
778         Define I386_NUM_REGS.
779         (i386_target_description): Add 'segments' parameter to enable
780         segment base registers.
781
782 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
783
784         PR/24325
785         * source-cache.c: #undef open and close, to avoid unresolved
786         externals during linking.
787
788 2019-03-12  Tom Tromey  <tromey@adacore.com>
789
790         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
791         const.  Add initializers.
792         (_initialize_remote): Don't initialize ptid globals.
793
794 2019-03-12  Pedro Alves  <palves@redhat.com>
795
796         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
797
798 2019-03-12  Pedro Alves  <palves@redhat.com>
799
800         * cp-name-parser.y (main): Remove unused 'len' variable.
801
802 2019-03-12  Tom Tromey  <tromey@adacore.com>
803
804         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
805         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
806
807 2019-03-12  Tom Tromey  <tromey@adacore.com>
808
809         * linux-nat.c (iterate_over_lwps): Update.
810         (stop_callback): Remove parameter.
811         (stop_wait_callback, detach_callback, resume_set_callback)
812         (select_singlestep_lwp_callback, set_ignore_sigint)
813         (status_callback, resumed_callback, resume_clear_callback)
814         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
815         data parameter.
816         (linux_nat_target::detach, linux_nat_target::resume)
817         (linux_stop_and_wait_all_lwps, select_event_lwp)
818         (linux_nat_filter_event, linux_nat_wait_1)
819         (linux_nat_target::kill, linux_nat_target::stop)
820         (linux_nat_target::stop): Update.
821         (linux_nat_resume_callback): Change type.
822         (resume_stopped_resumed_lwps, count_events_callback)
823         (select_event_lwp_callback): Likewise.
824         (linux_stop_lwp, linux_nat_stop_lwp): Update.
825         * arm-linux-nat.c (struct update_registers_data): Remove.
826         (update_registers_callback): Change type.
827         (arm_linux_insert_hw_breakpoint1): Update.
828         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
829         parameter.
830         (x86_linux_dr_set_addr): Update.
831         (x86_linux_dr_set_control): Update.
832         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
833         (iterate_over_lwps): Use gdb::function_view.
834         * nat/aarch64-linux-hw-point.c (struct
835         aarch64_dr_update_callback_param): Remove.
836         (debug_reg_change_callback): Change type.
837         (aarch64_notify_debug_reg_change): Update.
838         * s390-linux-nat.c (s390_refresh_per_info): Update.
839
840 2019-03-11  Tom Tromey  <tromey@adacore.com>
841
842         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
843         redundant assignment to "this_cu".
844
845 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
846
847         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
848
849 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
850
851         * gdbtypes.c (rank_one_type_parm_set): New function extracted
852         from...
853         (rank_one_type): ... this.
854
855 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
856
857         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
858         from...
859         (rank_one_type): ... this.
860
861 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
862
863         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
864         from...
865         (rank_one_type): ... this.
866
867 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
868
869         * gdbtypes.c (rank_one_type_parm_float): New function extracted
870         from...
871         (rank_one_type): ... this.
872
873 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
874
875         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
876         from...
877         (rank_one_type): ... this.
878
879 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
880
881         * gdbtypes.c (rank_one_type_parm_range): New function extracted
882         from...
883         (rank_one_type): ... this.
884
885 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
886
887         * gdbtypes.c (rank_one_type_parm_char): New function extracted
888         from...
889         (rank_one_type): ... this.
890
891 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
892
893         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
894         from...
895         (rank_one_type): ... this.
896
897 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
898
899         * gdbtypes.c (rank_one_type_parm_int): New function extracted
900         from...
901         (rank_one_type): ... this.
902
903 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
904
905         * gdbtypes.c (rank_one_type_parm_func): New function extracted
906         from...
907         (rank_one_type): ... this.
908
909 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
910
911         * gdbtypes.c (rank_one_type_parm_array): New function extracted
912         from...
913         (rank_one_type): ... this.
914
915 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
916
917         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
918         from...
919         (rank_one_type): ... this.
920
921 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
922
923         * inferior.c (initialize_inferiors): Ensure 'help set/show print
924         inferior-events' shows the example events.
925
926 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
927
928         Support styling on native MS-Windows console
929
930         PR/24315
931         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
932         on MS-Windows if $TERM is not defined.
933
934         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
935
936         * posix-hdep.c (gdb_console_fputs):
937         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
938         functions.
939         * ui-file.h (gdb_console_fputs): Add prototype.
940
941         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
942         back to fputs only if the former returns zero.
943
944 2019-03-07  Tom Tromey  <tom@tromey.com>
945
946         * symmisc.c (print_symbol_bcache_statistics): Update.
947         (print_objfile_statistics): Update.
948         * symfile.c (allocate_symtab): Update.
949         * stabsread.c: Don't include bcache.h.
950         * psymtab.h (struct psymbol_bcache): Don't declare.
951         (class psymtab_storage) <psymbol_cache>: Now a bcache.
952         (psymbol_bcache_init, psymbol_bcache_free)
953         (psymbol_bcache_get_bcache): Don't declare.
954         * psymtab.c (struct psymbol_bcache): Remove.
955         (psymtab_storage::psymtab_storage): Update.
956         (psymtab_storage::~psymtab_storage): Update.
957         (psymbol_bcache_init, psymbol_bcache_free)
958         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
959         (add_psymbol_to_bcache): Update.
960         (allocate_psymtab): Update.
961         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
962         macro_cache>: No longer pointers.
963         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
964         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
965         * macrotab.c (macro_bcache): Update.
966         * macroexp.c: Don't include bcache.h.
967         * gdbtypes.c (check_types_worklist): Update.
968         (types_deeply_equal): Remove TRY/CATCH.  Update.
969         * elfread.c (elf_symtab_read): Update.
970         * dwarf2read.c: Don't include bcache.h.
971         * buildsym.c (buildsym_compunit::get_macro_table): Update.
972         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
973         (print_bcache_statistics, bcache_memory_used): Don't declare.
974         (struct bcache): Move from bcache.c.  Add constructor, destructor,
975         methods.  Rename all data members.
976         * bcache.c (struct bcache): Move to bcache.h.
977         (bcache::expand_hash_table): Rename from expand_hash_table.
978         (bcache): Remove.
979         (bcache::insert): Rename from bcache_full.
980         (bcache::compare): Rename from bcache_compare.
981         (bcache_xmalloc): Remove.
982         (bcache::~bcache): Rename from bcache_xfree.
983         (bcache::print_statistics): Rename from print_bcache_statistics.
984         (bcache::memory_used): Rename from bcache_memory_used.
985
986 2019-03-07  Pedro Alves  <palves@redhat.com>
987
988         * infrun.c (normal_stop): Also check for
989         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
990
991 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
992
993         * f-lang.c (value_from_host_double): Moved to...
994         * value.c (value_from_host_double): ...here.
995         * value.h (value_from_host_double): Declare.
996         * guile/scm-math.c (vlscm_convert_typed_number): Use
997         value_from_host_double.
998         (vlscm_convert_number): Likewise.
999         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
1000         * python/py-value.c (convert_value_from_python): Likewise.
1001
1002 2019-03-06  Tom Tromey  <tom@tromey.com>
1003
1004         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
1005
1006 2019-03-06  Tom Tromey  <tom@tromey.com>
1007
1008         * utils.h (free_current_contents): Don't declare.
1009         * utils.c (free_current_contents): Remove.
1010
1011 2019-03-06  Tom Tromey  <tom@tromey.com>
1012
1013         * top.c (quit_force): Update.
1014         * main.c (captured_command_loop): Update.
1015         * common/new-op.c (operator new): Update.
1016         * common/common-exceptions.c (struct catcher)
1017         <save_cleanup_chain>: Remove member.
1018         (exceptions_state_mc_init): Update.
1019         (exception_try_scope_entry): Return nullptr.
1020         (exception_try_scope_exit, exception_rethrow)
1021         (throw_exception_sjlj, throw_exception_cxx): Update.
1022         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
1023         (all_cleanups, do_cleanups, discard_cleanups)
1024         (discard_final_cleanups, save_cleanups, save_final_cleanups)
1025         (restore_cleanups, restore_final_cleanups): Don't declare.
1026         (do_final_cleanups): Remove parameter.
1027         * common/cleanups.c (cleanup_chain, make_cleanup)
1028         (make_cleanup_dtor, all_cleanups, do_cleanups)
1029         (discard_my_cleanups, discard_cleanups)
1030         (discard_final_cleanups, save_my_cleanups, save_cleanups)
1031         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
1032         (null_cleanup): Remove.
1033         (do_final_cleanups): Remove parameter.
1034
1035 2019-03-06  Tom Tromey  <tom@tromey.com>
1036
1037         * remote.c (remote_target::remote_parse_stop_reply): Use
1038         unique_xmalloc_ptr.
1039
1040 2019-03-06  Tom Tromey  <tom@tromey.com>
1041
1042         * stabsread.c (struct stabs_field_info): Rename from field_info.
1043         <list, fnlist>: Add initializers.
1044         <obstack>: New member.
1045         (read_member_functions, read_struct_fields, read_baseclasses):
1046         Allocate on obstack.  Don't use cleanups.
1047         (read_one_struct_field, read_member_functions, read_struct_fields)
1048         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
1049         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
1050         (read_struct_type): Update.
1051
1052 2019-03-06  Tom Tromey  <tom@tromey.com>
1053
1054         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
1055         * common/filestuff.h (make_cleanup_close): Don't declare.
1056         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
1057         Remove.
1058
1059 2019-03-06  Tom Tromey  <tom@tromey.com>
1060
1061         * solib-aix.c: Use make_scope_exit.
1062
1063 2019-03-06  Tom Tromey  <tom@tromey.com>
1064
1065         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
1066         Use make_scope_exit.
1067
1068 2019-03-06  Tom Tromey  <tom@tromey.com>
1069
1070         * solib-svr4.c (disable_probes_interface): Remove parameter.
1071         (svr4_handle_solib_event): Use make_scope_exit.
1072
1073 2019-03-06  Tom Tromey  <tom@tromey.com>
1074
1075         * remote.c (struct stop_reply_deleter): Remove.
1076         (stop_reply_up): Update.
1077         (struct stop_reply): Derive from notif_event.  Don't typedef.
1078         <regcache>: Now a std::vector.
1079         (stop_reply_xfree): Remove.
1080         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
1081         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
1082         (remote_target::discard_pending_stop_replies): Use delete.
1083         (remote_target::remote_parse_stop_reply): Update.
1084         (remote_target::process_stop_reply): Update.
1085         * remote-notif.h (struct notif_event): Add virtual destructor.
1086         Remove "dtr" member.
1087         (struct notif_client) <alloc_event>: Return a unique_ptr.
1088         (notif_event_xfree): Don't declare.
1089         (notif_event_up): New typedef.
1090         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
1091         (notif_event_xfree, do_notif_event_xfree): Remove.
1092         (remote_notif_state_xfree): Update.
1093
1094 2019-03-06  Tom Tromey  <tom@tromey.com>
1095
1096         * infrun.c (displaced_step_clear_cleanup): Now a
1097         forward_scope_exit type.
1098         (displaced_step_prepare_throw): Update.
1099         (displaced_step_fixup): Update.
1100
1101 2019-03-06  Tom Tromey  <tom@tromey.com>
1102
1103         * inferior.h (class inferior): Update comment.
1104         * gdbthread.h (class thread_info): Update comment.
1105
1106 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
1107             Tom Tromey  <tom@tromey.com>
1108
1109         * stabsread.h (struct stab_section_list): Remove.
1110         (coffstab_build_psymtabs): Update.
1111         * dbxread.c (symbuf_sections): Now a std::vector.
1112         (sect_idx): New global.
1113         (fill_symbuf): Update.
1114         (coffstab_build_psymtabs): Change type of stabsects parameter.
1115         Update.
1116         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
1117         std::vector.
1118         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
1119         (coff_locate_sections): Update.
1120         (coff_symfile_read): Remove cleanups.  Update.
1121         (init_stringtab): Add storage parameter.
1122         (free_stringtab, free_stringtab_cleanup): Remove.
1123         (init_lineno): Add storage parameter.
1124         (free_linetab, free_linetab_cleanup): Remove.
1125
1126 2019-03-06  Pedro Alves  <palves@redhat.com>
1127
1128         * linux-fork.c (fork_info::clobber_regs): Delete.
1129         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
1130         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
1131         comment.  Adjust.
1132         (scoped_switch_fork_info::scoped_switch_fork_info)
1133         (checkpoint_command, linux_fork_context): Adjust
1134         fork_save_infrun_state calls.
1135
1136 2019-03-06  Pedro Alves  <palves@redhat.com>
1137
1138         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
1139         (inf_has_multiple_threads): Return 'bool' and rewrite using
1140         inferior_info::threads().
1141
1142 2019-03-06  Pedro Alves  <palves@redhat.com>
1143
1144         * linux-fork.c: Include <list>.
1145         (fork_list): Now a std::list instance.
1146         (fork_info): Add ctor, dtor, and in-class initialize all fields.
1147         (forks_exist_p, find_last_fork): Adjust.
1148         (new_fork): Delete.
1149         (one_fork_p): New.
1150         (add_fork): Adjust.
1151         (free_fork): Delete, folded into fork_info::~fork_info().
1152         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
1153         Adjust.
1154         (init_fork_list): Delete.
1155         (linux_fork_killall, linux_fork_mourn_inferior)
1156         (linux_fork_detach, info_checkpoints_command): Adjust.
1157         (_initialize_linux_fork): No longer call init_fork_list.
1158
1159 2019-03-06  Pedro Alves  <palves@redhat.com>
1160
1161         * linux-fork.c (new_fork): New, split out of ...
1162         (add_fork): ... this.  Return void.  Move "first fork" special
1163         case from here, to ...
1164         (checkpoint_command): ... here.
1165         * linux-linux.h (add_fork): Return void.
1166
1167 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1168
1169         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
1170
1171 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1172             Chris January  <chris.january@arm.com>
1173             David Lecomber  <david.lecomber@arm.com>
1174
1175         * f-exp.y: New token, UNOP_INTRINSIC.
1176         (exp): New pattern using UNOP_INTRINSIC token.
1177         (f77_keywords): Add 'abs' keyword.
1178         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
1179         (value_from_host_double): New function.
1180         (evaluate_subexp_f): Support UNOP_ABS.
1181
1182 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1183
1184         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
1185         types.
1186
1187 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1188
1189         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
1190         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
1191         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
1192
1193 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1194
1195         * f-exp.y (convert_to_kind_type): Handle more type kinds.
1196
1197 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1198             Chris January  <chris.january@arm.com>
1199
1200         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
1201         * f-exp.y: Define 'KIND' token.
1202         (exp): New pattern for KIND expressions.
1203         (ptype): Handle types with a kind extension.
1204         (direct_abs_decl): Extend to spot kind extensions.
1205         (f77_keywords): Add 'kind' to the list.
1206         (push_kind_type): New function.
1207         (convert_to_kind_type): New function.
1208         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
1209         * parse.c (operator_length_standard): Likewise.
1210         * parser-defs.h (enum type_pieces): Add tp_kind.
1211         * std-operator.def: Add UNOP_KIND.
1212
1213 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1214
1215         * f-exp.y (f_parse): Set yydebug.
1216
1217 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1218
1219         * f-lang.c (evaluate_subexp_f): New function.
1220         (exp_descriptor_f): New global.
1221         (f_language_defn): Use exp_descriptor_f instead of
1222         exp_descriptor_standard.
1223
1224 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1225
1226         * f-exp.y (struct token): Add comments.
1227         (dot_ops): Remove uppercase versions and the end marker.
1228         (f77_keywords): Likewise.
1229         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
1230         entries in the dot_ops array are case insensitive, and use
1231         strncasecmp to compare strings.  Also some whitespace cleanup in
1232         this area.  Similar for the f77_keywords array, except entries in
1233         this list might be case sensitive.
1234
1235 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1236
1237         * f-exp.y (struct f77_boolean_val): Add comments.
1238         (boolean_values): Remove uppercase versions, and end marker.
1239         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
1240         and use strncasecmp to achieve case insensitivity.  Additionally,
1241         perform whitespace cleanup around this code.
1242
1243 2019-03-06  Tom Tromey  <tromey@adacore.com>
1244
1245         * remote-sim.c (gdbsim_target_open): Use result of
1246         gdb_argv::release.
1247
1248 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
1249         Dirk Schubert  <dirk.schubert@arm.com>
1250         Chris January  <chris.january@arm.com>
1251
1252         * eval.c (evaluate_subexp_standard): Call Fortran argument
1253         wrapping logic.
1254         * f-lang.c (struct value): A value which can be passed into a
1255         Fortran function call.
1256         (fortran_argument_convert): Wrap Fortran arguments in a pointer
1257         where appropriate.
1258         (struct type): Value ready for a Fortran function call.
1259         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
1260         is needed.
1261         * f-lang.h (fortran_argument_convert): Declaration.
1262         (fortran_preserve_arg_pointer): Declaration.
1263         * infcall.c (value_arg_coerce): Call Fortran argument logic.
1264
1265 2019-03-05  Tom Tromey  <tromey@adacore.com>
1266
1267         * python/py-prettyprint.c (print_string_repr): Remove #if.
1268         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
1269
1270 2019-03-05  Tom Tromey  <tromey@adacore.com>
1271
1272         * target.c (the_dummy_target): Move later.  Change type to
1273         "dummy_target".
1274         (initialize_targets): Don't initialize the_dummy_target.
1275
1276 2019-03-05  Tom Tromey  <tromey@adacore.com>
1277
1278         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
1279         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
1280
1281 2019-03-05  Tom Tromey  <tromey@adacore.com>
1282
1283         * windows-nat.c (windows_nat_target::attach)
1284         (windows_nat_target::detach): Don't call gdb_flush.
1285         * valprint.c (generic_val_print, val_print, val_print_string):
1286         Don't call gdb_flush.
1287         * utils.c (defaulted_query): Don't call gdb_flush.
1288         * typeprint.c (print_type_scalar): Don't call gdb_flush.
1289         * target.c (target_announce_detach): Don't call gdb_flush.
1290         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
1291         * remote.c (extended_remote_target::attach): Don't call
1292         gdb_flush.
1293         * procfs.c (procfs_target::detach): Don't call gdb_flush.
1294         * printcmd.c (do_examine): Don't call gdb_flush.
1295         (info_display_command): Don't call gdb_flush.
1296         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
1297         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
1298         * memattr.c (info_mem_command): Don't call gdb_flush.
1299         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
1300         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
1301         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
1302         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
1303         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
1304         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
1305         (gnu_nat_target::detach): Don't call gdb_flush.
1306         * f-valprint.c (f_val_print): Don't call gdb_flush.
1307         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
1308         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
1309         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
1310         gdb_flush.
1311         * c-valprint.c (c_val_print): Don't call gdb_flush.
1312         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
1313
1314 2019-03-05  Tom Tromey  <tromey@adacore.com>
1315
1316         * varobj.c (update_dynamic_varobj_children): Update.
1317         (install_default_visualizer): Use reset, not release.
1318         * value.c (set_internalvar): Update.
1319         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
1320         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
1321         ATTRIBUTE_UNUSED_RESULT.
1322
1323 2019-03-05  Tom Tromey  <tromey@adacore.com>
1324
1325         * remote.c (class scoped_remote_fd) <release>: Add
1326         ATTRIBUTE_UNUSED_RESULT.
1327
1328 2019-03-05  Tom Tromey  <tromey@adacore.com>
1329
1330         * macroexp.c (struct macro_buffer) <release>: Add
1331         ATTRIBUTE_UNUSED_RESULT.
1332
1333 2019-03-05  Tom Tromey  <tromey@adacore.com>
1334
1335         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
1336         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
1337         ATTRIBUTE_UNUSED_RESULT.
1338
1339 2019-03-05  Tom Tromey  <tromey@adacore.com>
1340
1341         * common/scoped_fd.h (class scoped_fd) <release>: Add
1342         ATTRIBUTE_UNUSED_RESULT.
1343
1344 2019-03-05  Tom Tromey  <tromey@adacore.com>
1345
1346         * parser-defs.h (struct parser_state) <release>: Add
1347         ATTRIBUTE_UNUSED_RESULT.
1348
1349 2019-03-05  Tom Tromey  <tromey@adacore.com>
1350
1351         * utils.h (class gdb_argv) <release>: Add
1352         ATTRIBUTE_UNUSED_RESULT.
1353         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1354
1355 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1356
1357         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1358         for-loop range, to avoid compiler warnings.
1359
1360         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1361         avoid compiler warnings about unused variables.
1362
1363         * NEWS: Mention end of support for native debugging on MS-Windows
1364         before XP.
1365
1366         PR gdb/24292
1367         * common/netstuff.c:
1368         * gdbserver/gdbreplay.c
1369         * gdbserver/remote-utils.c:
1370         * ser-tcp.c:
1371         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1372         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1373         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1374         'getaddrinfo' and 'freeaddrinfo' were not available before
1375         Windows XP, and mingw.org's MinGW headers by default define
1376         _WIN32_WINNT to 0x500.
1377
1378 2019-03-01  Gary Benson <gbenson@redhat.com>
1379
1380         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1381
1382 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1383             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1384
1385         PR gdb/8527
1386         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1387         set_sigint_trap, clear_sigint_trap.
1388
1389 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1390
1391         * target.c (target_detach): Clear the regcache and the
1392         frame cache.
1393
1394 2019-02-27  Pedro Alves  <palves@redhat.com>
1395
1396         * utils.c (set_screen_size): When we cap the height/width sizes,
1397         tweak the corresponding command variable to show "unlimited":
1398
1399 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1400             Pedro Alves  <palves@redhat.com>
1401
1402         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1403         before calling rl_set_screen_size.
1404
1405 2019-02-27  Tom Tromey  <tromey@adacore.com>
1406
1407         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1408         define.
1409         * python/py-value.c: Remove Python 2.4 workaround.
1410         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1411         workaround.
1412         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1413         Python 2.4 workaround.
1414         * python/python-internal.h: Remove Python 2.4 comment.
1415         (Py_ssize_t): Don't define.
1416         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1417         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1418         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1419         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1420         * python/python.c (do_start_initialization): Remove Python 2.4
1421         workaround.
1422         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1423         (print_children): Remove Python 2.4 workaround.
1424         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1425         workaround.
1426         (CHARBUFFERPROC_NAME): Remove.
1427         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1428         Python 2.4 workaround.
1429
1430 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1431
1432         * NEWS: Note minimum Python version.
1433
1434 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1435
1436         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1437         code from these functions.  Remove corresponding ifdefs.  Use
1438         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1439         Remove gotos and target of gotos.
1440         (infpy_search_memory): Likewise.
1441
1442 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1443
1444         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1445         (hppa_gdbarch_init): Don't register deleted functions with
1446         gdbarch.
1447
1448 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1449
1450         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1451         (h8300_unwind_sp): Delete.
1452         (h8300_dummy_id): Delete.
1453         (h8300_gdbarch_init): Don't register deleted functions with
1454         gdbarch.
1455
1456 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1457
1458         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1459         (ft32_unwind_pc): Delete.
1460         (ft32_unwind_sp): Delete.
1461         (ft32_gdbarch_init): Don't register deleted functions with
1462         gdbarch.
1463
1464 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1465
1466         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1467         (frv_unwind_pc): Delete.
1468         (frv_unwind_sp): Delete.
1469         (frv_gdbarch_init): Don't register deleted functions with
1470         gdbarch.
1471
1472 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1473
1474         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1475         (riscv_unwind_pc): Delete.
1476         (riscv_unwind_sp): Delete.
1477         (riscv_gdbarch_init): Don't register deleted functions with
1478         gdbarch.
1479
1480 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1481
1482         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1483         (csky_unwind_pc): Delete.
1484         (csky_unwind_sp): Delete.
1485         (csky_gdbarch_init): Don't register deleted functions with
1486         gdbarch.
1487
1488 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1489
1490         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1491         (cris_unwind_pc): Delete.
1492         (cris_unwind_sp): Delete.
1493         (cris_gdbarch_init): Don't register deleted functions with
1494         gdbarch.
1495
1496 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1497
1498         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1499         (bfin_unwind_pc): Delete.
1500         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1501
1502 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1503
1504         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1505         (arm_unwind_pc): Delete.
1506         (arm_unwind_sp): Delete.
1507         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1508
1509 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1510
1511         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1512         (arc_unwind_pc): Delete.
1513         (arc_unwind_sp): Delete.
1514         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1515
1516 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1517
1518         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1519         (alpha_unwind_pc): Delete.
1520         (alpha_gdbarch_init): Don't register deleted functions with
1521         gdbarch.
1522
1523 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1524
1525         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1526         (aarch64_unwind_pc): Delete.
1527         (aarch64_unwind_sp): Delete.
1528         (aarch64_gdbarch_init): Don't register deleted functions with
1529         gdbarch.
1530
1531 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1532
1533         * gdbtypes.c (type_align): Don't consider static members when
1534         computing structure alignment.
1535
1536 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1537
1538         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1539         return 0 for other types.
1540         * arch-utils.c (default_type_align): Always return 0.
1541         * gdbarch.h: Regenerate.
1542         * gdbarch.sh (type_align): Extend comment.
1543         * gdbtypes.c (type_align): Add additional comments, always call
1544         gdbarch_type_align before applying the default rules.
1545         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1546         generic code will then apply a suitable default.
1547         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1548         types, return 0 for other types.
1549
1550 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1551
1552         * NEWS: Create a new section for the next release branch.
1553         Rename the section of the current branch, now that it has
1554         been cut.
1555
1556 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1557
1558         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1559         * version.in: Bump version to 8.3.50.DATE-git.
1560
1561 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1562
1563         * aix-thread.c (ptid_cmp): Remove unused variable.
1564         (get_signaled_thread): Likewise.
1565         (store_regs_user_thread): Likewise.
1566         (store_regs_kernel_thread): Likewise.
1567         (fetch_regs_kernel_thread): Remove shadowed variable.
1568
1569 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1570
1571         * features/riscv/32bit-cpu.xml: Add register numbers.
1572         * features/riscv/32bit-fpu.c: Regenerate.
1573         * features/riscv/32bit-fpu.xml: Add register numbers.
1574         * features/riscv/64bit-cpu.xml: Add register numbers.
1575         * features/riscv/64bit-fpu.c: Regenerate.
1576         * features/riscv/64bit-fpu.xml: Add register numbers.
1577
1578 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1579
1580         * NEWS: Mention two argument form of gdb.Value constructor.
1581         * python/py-value.c (convert_buffer_and_type_to_value): New
1582         function.
1583         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1584         Add support for handling an optional second argument.  Call
1585         convert_buffer_and_type_to_value as appropriate.
1586         * python/python-internal.h (Py_buffer_deleter): New struct.
1587         (Py_buffer_up): New typedef.
1588
1589 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1590
1591         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1592         instead of releasing ownership.
1593
1594 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1595
1596         * dwarf2read.c (open_and_init_dwp_file): Call
1597         elf_numsections instead of bfd_count_sections to initialize
1598         dwp_file->num_sections.
1599
1600 2019-02-25  Tom Tromey  <tromey@adacore.com>
1601
1602         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1603
1604 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1605
1606         * gcore.in: Add '--readnever' option when invoking GDB.
1607
1608 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1609
1610         * MAINTAINERS: Update my email address.
1611
1612 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1613
1614         * build-id.c (build_id_to_debug_bfd_1): New function.
1615         (build_id_to_debug_bfd): Look for separate debug file in
1616         sysroot.
1617
1618 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1619
1620         * gdbarch.sh: Update the copyright year range that is placed into
1621         generated files.
1622
1623 2019-02-22  Keith Seitz  <keiths@redhat.com>
1624
1625         PR symtab/23853
1626         * linespec.c (create_sals_line_offset): Search for the default
1627         symtab's filename instead of its fullname.
1628
1629 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1630
1631         * NEWS: Update style defaults.
1632
1633 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1634
1635         * main.c (captured_main_1): Disable styling in batch mode.
1636
1637 2019-02-20  Tom Tromey  <tom@tromey.com>
1638
1639         * symtab.c (symtab_symbol_info): Fix typos.
1640
1641 2019-02-20  Tom Tromey  <tromey@adacore.com>
1642
1643         * findcmd.c (_initialize_mem_search): Use upper case for
1644         metasyntactic variables.
1645
1646 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1647
1648         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1649         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1650
1651 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1652
1653         * top.h (source_file_name): Change to std::string.
1654         * top.c (source_file_name): Likewise.
1655         (command_line_input): Adjust.
1656         * cli/cli-script.c (script_from_file): Adjust.
1657
1658 2019-02-19  Tom Tromey  <tromey@adacore.com>
1659
1660         * ravenscar-thread.c
1661         (ravenscar_thread_target::update_thread_list): Don't call
1662         ada_build_task_list.
1663         * ada-lang.h (ada_build_task_list): Don't declare.
1664         * ada-tasks.c (struct ada_tasks_inferior_data)
1665         <task_list_valid_p>: Now bool.
1666         (read_known_tasks, ada_task_list_changed)
1667         (ada_tasks_invalidate_inferior_data): Update.
1668         (read_known_tasks_array): Return bool.
1669         (read_known_tasks_list): Likewise.
1670         (read_known_tasks): Return void.
1671         (ada_build_task_list): Now static.
1672
1673 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1674
1675         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1676         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1677
1678 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1679
1680         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1681         variant for ada_tasks_pspace_data_handle and
1682         ada_tasks_inferior_data_handle.
1683         (ada_tasks_pspace_data_cleanup): New function.
1684         (ada_tasks_inferior_data_cleanup): New function.
1685
1686 2019-02-17  Tom Tromey  <tom@tromey.com>
1687
1688         * macrotab.h (macro_source_fullname): Return a std::string.
1689         * macrotab.c (macro_include, check_for_redefinition)
1690         (macro_undef, macro_lookup_definition, foreach_macro)
1691         (foreach_macro_in_scope): Update.
1692         (macro_source_fullname): Return a std::string.
1693         * macrocmd.c (show_pp_source_pos): Update.
1694
1695 2019-02-17  Tom Tromey  <tom@tromey.com>
1696
1697         * macrocmd.c (show_pp_source_pos): Style the file names.
1698
1699 2019-02-17  Tom Tromey  <tom@tromey.com>
1700
1701         PR tui/24197:
1702         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1703
1704 2019-02-17  Tom Tromey  <tom@tromey.com>
1705
1706         * ada-lang.c (user_select_syms): Use filtered printing.
1707         * utils.c (wrap_style): New global.
1708         (desired_style): Remove.
1709         (emit_style_escape): Add stream parameter.
1710         (set_output_style, reset_terminal_style, prompt_for_continue):
1711         Update.
1712         (flush_wrap_buffer): Only flush gdb_stdout.
1713         (wrap_here): Set wrap_style.
1714         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1715         treat escape sequences as a character.  Change when wrap buffer is
1716         flushed.
1717         (fputs_styled): Do not set the output style when the default is
1718         requested.
1719         * ui-style.h (struct ui_file_style) <is_default>: New method.
1720         * source.c (print_source_lines_base): Emit escape sequences in one
1721         piece.
1722
1723 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1724
1725         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1726         integers and enumeration types.
1727
1728 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1729
1730         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1731         instead of lookup_symbol_in_language
1732         (do_exact_match): New function.
1733         (ada_get_symbol_name_matcher): Return do_exact_match when
1734         doing a verbatim match.
1735
1736 2019-02-15  Tom Tromey  <tromey@adacore.com>
1737
1738         * ravenscar-thread.c (ravenscar_thread_target::resume)
1739         (ravenscar_thread_target::wait): Special case wildcard requests.
1740
1741 2019-02-15  Tom Tromey  <tromey@adacore.com>
1742
1743         * ravenscar-thread.c (base_ptid): Remove.
1744         (struct ravenscar_thread_target) <close>: New method.
1745         <m_base_ptid>: New member.
1746         <update_inferior_ptid, active_task, task_is_currently_active,
1747         runtime_initialized>: Declare methods.
1748         <ravenscar_thread_target>: Add constructor.
1749         (ravenscar_thread_target::task_is_currently_active)
1750         (ravenscar_thread_target::update_inferior_ptid)
1751         (ravenscar_runtime_initialized): Rename.  Now methods.
1752         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1753         (ravenscar_thread_target::update_thread_list): Update.
1754         (ravenscar_thread_target::active_task): Now method.
1755         (ravenscar_thread_target::store_registers)
1756         (ravenscar_thread_target::prepare_to_store)
1757         (ravenscar_thread_target::prepare_to_store)
1758         (ravenscar_thread_target::mourn_inferior): Update.
1759         (ravenscar_inferior_created): Use "new" to create target.
1760         (ravenscar_thread_target::get_ada_task_ptid): Update.
1761         (_initialize_ravenscar): Don't initialize base_ptid.
1762         (ravenscar_ops): Remove global.
1763
1764 2019-02-15  Tom Tromey  <tromey@adacore.com>
1765
1766         * target.h (push_target): Declare new overload.
1767         * target.c (push_target): New overload, taking an rvalue reference.
1768         * remote.c (remote_target::open_1): Use push_target overload.
1769         * corelow.c (core_target_open): Use push_target overload.
1770
1771 2019-02-15  Tom Tromey  <tromey@adacore.com>
1772
1773         * ravenscar-thread.c (is_ravenscar_task)
1774         (ravenscar_task_is_currently_active): Return bool.
1775         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1776         (_initialize_ravenscar): Remove "(void)".
1777         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1778         Return bool.
1779
1780 2019-02-15  Tom Tromey  <tromey@adacore.com>
1781
1782         * ravenscar-thread.c (ravenscar_runtime_initializer)
1783         (has_ravenscar_runtime, get_running_thread_id)
1784         (ravenscar_thread_target::resume): Fix indentation.
1785
1786 2019-02-15  Tom Tromey  <tromey@adacore.com>
1787
1788         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1789         from ravenscar_arch_ops.
1790         (sparc_ravenscar_ops::fetch_registers)
1791         (sparc_ravenscar_ops::store_registers): Now methods.
1792         (sparc_ravenscar_prepare_to_store): Remove.
1793         (sparc_ravenscar_ops): Redefine.
1794         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1795         methods and destructor.  Remove members.
1796         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1797         (ravenscar_thread_target::store_registers)
1798         (ravenscar_thread_target::prepare_to_store): Update.
1799         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1800         Remove.
1801         (struct ppc_ravenscar_powerpc_ops): Derive from
1802         ravenscar_arch_ops.
1803         (ppc_ravenscar_powerpc_ops::fetch_registers)
1804         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1805         (ppc_ravenscar_powerpc_ops): Redefine.
1806         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1807         (ppc_ravenscar_e500_ops::fetch_registers)
1808         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1809         (ppc_ravenscar_e500_ops): Redefine.
1810         * aarch64-ravenscar-thread.c
1811         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1812         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1813         (aarch64_ravenscar_fetch_registers)
1814         (aarch64_ravenscar_store_registers): Now methods.
1815         (aarch64_ravenscar_ops): Redefine.
1816
1817 2019-02-15  Tom Tromey  <tromey@adacore.com>
1818
1819         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1820         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1821         (ravenscar_thread_target::stopped_by_watchpoint)
1822         (ravenscar_thread_target::stopped_data_address)
1823         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1824
1825 2019-02-15  Tom Tromey  <tromey@adacore.com>
1826
1827         * ravenscar-thread.c: Fix some typos.
1828
1829 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1830             Tom Tromey  <tromey@adacore.com>
1831
1832         * ada-lang.c (ada_exception_sal): Change addr_string to a
1833         std::string.
1834         (create_ada_exception_catchpoint): Update.
1835
1836 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1837             Tom Tromey  <tromey@adacore.com>
1838
1839         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1840         (bp_location_ops): Remove.
1841         (base_breakpoint_allocate_location): Update.
1842         (free_bp_location): Update.
1843         * ada-lang.c (class ada_catchpoint_location)
1844         <ada_catchpoint_location>: Remove ops parameter.
1845         (ada_catchpoint_location_dtor): Remove.
1846         (ada_catchpoint_location_ops): Remove.
1847         (allocate_location_exception): Update.
1848         * breakpoint.h (struct bp_location_ops): Remove.
1849         (class bp_location) <bp_location>: Remove bp_location_ops
1850         parameter.
1851         <~bp_location>: Add destructor.
1852         <ops>: Remove.
1853
1854 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1855             Pedro Alves  <palves@redhat.com>
1856
1857         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1858         'PATH_MAX'.
1859
1860 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1861             Samuel Thibault  <samuel.thibault@gnu.org>
1862             Thomas Schwinge  <thomas@codesourcery.com>
1863
1864         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1865         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1866
1867 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1868
1869         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1870         (check_empty): Use "const char *".
1871
1872         * gnu-nat.c (gnu_nat_target::detach): Instead of
1873         'detach_inferior (pid)' call
1874         'detach_inferior (find_inferior_pid (pid))'.
1875
1876         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1877         'nat/fork-inferior.o'.
1878         * gnu-nat.c: #include "nat/fork-inferior.h".
1879
1880         * gnu-nat.c (gnu_nat_target::detach): Instead of
1881         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1882         * gnu-nat.h: #include "inf-child.h".
1883         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1884         'i386_gnu_nat_target::fetch_registers'.
1885         (gnu_store_registers): Rename/move to
1886         'i386_gnu_nat_target::store_registers'.
1887
1888         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1889         * gnu-nat.h (mach_thread_info): New function.
1890         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1891
1892         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1893
1894 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1895
1896         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1897
1898 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1899
1900         * windows-nat.c (windows_add_thread): Add new parameter
1901         "main_thread_p" with default value set to false.  Update
1902         function documentation as well as all callers.
1903         (windows_delete_thread): Likewise.
1904         (fake_create_process): Update call to windows_add_thread.
1905         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1906         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1907         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1908         call to windows_delete_thread.
1909
1910 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1911
1912         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1913
1914 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1915
1916         * symfile.c (find_separate_debug_file): Use canonical path of
1917         sysroot with child_path instead of gdb_sysroot if it is valid.
1918
1919 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1920
1921         * symfile.c (find_separate_debug_file): Use child_path to
1922         determine if an object file is under a sysroot.
1923
1924 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1925
1926         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1927         unittests/child-path-selftests.c.
1928         * common/pathstuff.c (child_path): New function.
1929         * common/pathstuff.h (child_path): New prototype.
1930         * unittests/child-path-selftests.c: New file.
1931
1932 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1933
1934         * symfile.c (find_separate_debug_file): Look for separate debug
1935         files in debug directories under the sysroot.
1936
1937 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1938
1939         * symtab.h (struct minimal_symbol data_p): New const method.
1940         (struct minimal_symbol text_p): Likewise.
1941         * symtab.c (output_source_filename): Use file name style
1942         to print file name.
1943         (print_symbol_info): Likewise.
1944         (print_msymbol_info): Use address style to print addresses.
1945         Use function name style to print executable text symbols.
1946         (expand_symtab_containing_pc): Use data_p.
1947         (find_pc_sect_compunit_symtab): Likewise.
1948
1949 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1950
1951         * breakpoint.c (describe_other_breakpoints): Use address style
1952         to print addresses.
1953         (say_where): Likewise.
1954
1955 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1956
1957         * ada-typeprint.c (print_func_type): Print function name
1958         style to print function name.
1959         * c-typeprint.c (c_print_type_1): Likewise.
1960
1961 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
1962
1963         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
1964         for execve.
1965
1966 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1967
1968         * c-exp.y (direct_abs_decl): Use emplace_back to record the
1969         type_stack.
1970
1971 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
1972
1973         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
1974         TYPE_CODE_REF types.
1975
1976 2019-02-08  Jim Wilson  <jimw@sifive.com>
1977
1978         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
1979         (riscv_linux_fregset): New.
1980         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
1981
1982 2019-02-07  Tom Tromey  <tom@tromey.com>
1983
1984         * thread.c (thread_cancel_execution_command): Update.
1985         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
1986         methods.
1987         (struct thread_fsm_ops): Remove.
1988         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
1989         (thread_fsm_should_stop, thread_fsm_return_value)
1990         (thread_fsm_set_finished, thread_fsm_finished_p)
1991         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
1992         Don't declare.
1993         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
1994         * infrun.c (clear_proceed_status_thread)
1995         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
1996         (print_stop_event): Update.
1997         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
1998         Add constructor.
1999         (step_command_fsm_ops): Remove.
2000         (new_step_command_fsm): Remove.
2001         (step_1): Update.
2002         (step_command_fsm::should_stop): Rename from
2003         step_command_fsm_should_stop.
2004         (step_command_fsm::clean_up): Rename from
2005         step_command_fsm_clean_up.
2006         (step_command_fsm::do_async_reply_reason): Rename from
2007         step_command_fsm_async_reply_reason.
2008         (struct until_next_fsm): Inherit from thread_fsm.  Add
2009         constructor.
2010         (until_next_fsm_ops): Remove.
2011         (new_until_next_fsm): Remove.
2012         (until_next_fsm::should_stop): Rename from
2013         until_next_fsm_should_stop.
2014         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
2015         (until_next_fsm::do_async_reply_reason): Rename from
2016         until_next_fsm_async_reply_reason.
2017         (struct finish_command_fsm): Inherit from thread_fsm.  Add
2018         constructor.  Change type of breakpoint.
2019         (finish_command_fsm_ops): Remove.
2020         (new_finish_command_fsm): Remove.
2021         (finish_command_fsm::should_stop): Rename from
2022         finish_command_fsm_should_stop.
2023         (finish_command_fsm::clean_up): Rename from
2024         finish_command_fsm_clean_up.
2025         (finish_command_fsm::return_value): Rename from
2026         finish_command_fsm_return_value.
2027         (finish_command_fsm::do_async_reply_reason): Rename from
2028         finish_command_fsm_async_reply_reason.
2029         (finish_command): Update.
2030         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
2031         Add constructor.
2032         (call_thread_fsm_ops): Remove.
2033         (call_thread_fsm::call_thread_fsm): Rename from
2034         new_call_thread_fsm.
2035         (call_thread_fsm::should_stop): Rename from
2036         call_thread_fsm_should_stop.
2037         (call_thread_fsm::should_notify_stop): Rename from
2038         call_thread_fsm_should_notify_stop.
2039         (run_inferior_call, call_function_by_hand_dummy): Update.
2040         * cli/cli-interp.c (should_print_stop_to_console): Update.
2041         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
2042         Add constructor.  Change type of location_breakpoint,
2043         caller_breakpoint.
2044         (until_break_fsm_ops): Remove.
2045         (new_until_break_fsm): Remove.
2046         (until_break_fsm::should_stop): Rename from
2047         until_break_fsm_should_stop.
2048         (until_break_fsm::clean_up): Rename from
2049         until_break_fsm_clean_up.
2050         (until_break_fsm::do_async_reply_reason): Rename from
2051         until_break_fsm_async_reply_reason.
2052         (until_break_command): Update.
2053         * thread-fsm.c: Remove.
2054         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
2055
2056 2019-02-07  Tom Tromey  <tom@tromey.com>
2057
2058         * yy-remap.h: Add include guard.
2059         * xtensa-tdep.h: Add include guard.
2060         * xcoffread.h: Rename include guard.
2061         * varobj-iter.h: Add include guard.
2062         * tui/tui.h: Rename include guard.
2063         * tui/tui-winsource.h: Rename include guard.
2064         * tui/tui-wingeneral.h: Rename include guard.
2065         * tui/tui-windata.h: Rename include guard.
2066         * tui/tui-win.h: Rename include guard.
2067         * tui/tui-stack.h: Rename include guard.
2068         * tui/tui-source.h: Rename include guard.
2069         * tui/tui-regs.h: Rename include guard.
2070         * tui/tui-out.h: Rename include guard.
2071         * tui/tui-layout.h: Rename include guard.
2072         * tui/tui-io.h: Rename include guard.
2073         * tui/tui-hooks.h: Rename include guard.
2074         * tui/tui-file.h: Rename include guard.
2075         * tui/tui-disasm.h: Rename include guard.
2076         * tui/tui-data.h: Rename include guard.
2077         * tui/tui-command.h: Rename include guard.
2078         * tic6x-tdep.h: Add include guard.
2079         * target/waitstatus.h: Rename include guard.
2080         * target/wait.h: Rename include guard.
2081         * target/target.h: Rename include guard.
2082         * target/resume.h: Rename include guard.
2083         * target-float.h: Rename include guard.
2084         * stabsread.h: Add include guard.
2085         * rs6000-tdep.h: Add include guard.
2086         * riscv-fbsd-tdep.h: Add include guard.
2087         * regformats/regdef.h: Rename include guard.
2088         * record.h: Rename include guard.
2089         * python/python.h: Rename include guard.
2090         * python/python-internal.h: Rename include guard.
2091         * python/py-stopevent.h: Rename include guard.
2092         * python/py-ref.h: Rename include guard.
2093         * python/py-record.h: Rename include guard.
2094         * python/py-record-full.h: Rename include guard.
2095         * python/py-record-btrace.h: Rename include guard.
2096         * python/py-instruction.h: Rename include guard.
2097         * python/py-events.h: Rename include guard.
2098         * python/py-event.h: Rename include guard.
2099         * procfs.h: Add include guard.
2100         * proc-utils.h: Add include guard.
2101         * p-lang.h: Add include guard.
2102         * or1k-tdep.h: Rename include guard.
2103         * observable.h: Rename include guard.
2104         * nto-tdep.h: Rename include guard.
2105         * nat/x86-linux.h: Rename include guard.
2106         * nat/x86-linux-dregs.h: Rename include guard.
2107         * nat/x86-gcc-cpuid.h: Add include guard.
2108         * nat/x86-dregs.h: Rename include guard.
2109         * nat/x86-cpuid.h: Rename include guard.
2110         * nat/ppc-linux.h: Rename include guard.
2111         * nat/mips-linux-watch.h: Rename include guard.
2112         * nat/linux-waitpid.h: Rename include guard.
2113         * nat/linux-ptrace.h: Rename include guard.
2114         * nat/linux-procfs.h: Rename include guard.
2115         * nat/linux-osdata.h: Rename include guard.
2116         * nat/linux-nat.h: Rename include guard.
2117         * nat/linux-namespaces.h: Rename include guard.
2118         * nat/linux-btrace.h: Rename include guard.
2119         * nat/glibc_thread_db.h: Rename include guard.
2120         * nat/gdb_thread_db.h: Rename include guard.
2121         * nat/gdb_ptrace.h: Rename include guard.
2122         * nat/fork-inferior.h: Rename include guard.
2123         * nat/amd64-linux-siginfo.h: Rename include guard.
2124         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
2125         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
2126         * nat/aarch64-linux.h: Rename include guard.
2127         * nat/aarch64-linux-hw-point.h: Rename include guard.
2128         * mn10300-tdep.h: Add include guard.
2129         * mips-linux-tdep.h: Add include guard.
2130         * mi/mi-parse.h: Rename include guard.
2131         * mi/mi-out.h: Rename include guard.
2132         * mi/mi-main.h: Rename include guard.
2133         * mi/mi-interp.h: Rename include guard.
2134         * mi/mi-getopt.h: Rename include guard.
2135         * mi/mi-console.h: Rename include guard.
2136         * mi/mi-common.h: Rename include guard.
2137         * mi/mi-cmds.h: Rename include guard.
2138         * mi/mi-cmd-break.h: Rename include guard.
2139         * m2-lang.h: Add include guard.
2140         * location.h: Rename include guard.
2141         * linux-record.h: Rename include guard.
2142         * linux-nat.h: Add include guard.
2143         * linux-fork.h: Add include guard.
2144         * i386-darwin-tdep.h: Rename include guard.
2145         * hppa-linux-offsets.h: Add include guard.
2146         * guile/guile.h: Rename include guard.
2147         * guile/guile-internal.h: Rename include guard.
2148         * gnu-nat.h: Rename include guard.
2149         * gdb-stabs.h: Rename include guard.
2150         * frv-tdep.h: Add include guard.
2151         * f-lang.h: Add include guard.
2152         * event-loop.h: Add include guard.
2153         * darwin-nat.h: Rename include guard.
2154         * cp-abi.h: Rename include guard.
2155         * config/sparc/nm-sol2.h: Rename include guard.
2156         * config/nm-nto.h: Rename include guard.
2157         * config/nm-linux.h: Add include guard.
2158         * config/i386/nm-i386gnu.h: Rename include guard.
2159         * config/djgpp/nl_types.h: Rename include guard.
2160         * config/djgpp/langinfo.h: Rename include guard.
2161         * compile/gcc-cp-plugin.h: Add include guard.
2162         * compile/gcc-c-plugin.h: Add include guard.
2163         * compile/compile.h: Rename include guard.
2164         * compile/compile-object-run.h: Rename include guard.
2165         * compile/compile-object-load.h: Rename include guard.
2166         * compile/compile-internal.h: Rename include guard.
2167         * compile/compile-cplus.h: Rename include guard.
2168         * compile/compile-c.h: Rename include guard.
2169         * common/xml-utils.h: Rename include guard.
2170         * common/x86-xstate.h: Rename include guard.
2171         * common/version.h: Rename include guard.
2172         * common/vec.h: Rename include guard.
2173         * common/tdesc.h: Rename include guard.
2174         * common/selftest.h: Rename include guard.
2175         * common/scoped_restore.h: Rename include guard.
2176         * common/scoped_mmap.h: Rename include guard.
2177         * common/scoped_fd.h: Rename include guard.
2178         * common/safe-iterator.h: Rename include guard.
2179         * common/run-time-clock.h: Rename include guard.
2180         * common/refcounted-object.h: Rename include guard.
2181         * common/queue.h: Rename include guard.
2182         * common/ptid.h: Rename include guard.
2183         * common/print-utils.h: Rename include guard.
2184         * common/preprocessor.h: Rename include guard.
2185         * common/pathstuff.h: Rename include guard.
2186         * common/observable.h: Rename include guard.
2187         * common/netstuff.h: Rename include guard.
2188         * common/job-control.h: Rename include guard.
2189         * common/host-defs.h: Rename include guard.
2190         * common/gdb_wait.h: Rename include guard.
2191         * common/gdb_vecs.h: Rename include guard.
2192         * common/gdb_unlinker.h: Rename include guard.
2193         * common/gdb_unique_ptr.h: Rename include guard.
2194         * common/gdb_tilde_expand.h: Rename include guard.
2195         * common/gdb_sys_time.h: Rename include guard.
2196         * common/gdb_string_view.h: Rename include guard.
2197         * common/gdb_splay_tree.h: Rename include guard.
2198         * common/gdb_setjmp.h: Rename include guard.
2199         * common/gdb_ref_ptr.h: Rename include guard.
2200         * common/gdb_optional.h: Rename include guard.
2201         * common/gdb_locale.h: Rename include guard.
2202         * common/gdb_assert.h: Rename include guard.
2203         * common/filtered-iterator.h: Rename include guard.
2204         * common/filestuff.h: Rename include guard.
2205         * common/fileio.h: Rename include guard.
2206         * common/environ.h: Rename include guard.
2207         * common/common-utils.h: Rename include guard.
2208         * common/common-types.h: Rename include guard.
2209         * common/common-regcache.h: Rename include guard.
2210         * common/common-inferior.h: Rename include guard.
2211         * common/common-gdbthread.h: Rename include guard.
2212         * common/common-exceptions.h: Rename include guard.
2213         * common/common-defs.h: Rename include guard.
2214         * common/common-debug.h: Rename include guard.
2215         * common/cleanups.h: Rename include guard.
2216         * common/buffer.h: Rename include guard.
2217         * common/btrace-common.h: Rename include guard.
2218         * common/break-common.h: Rename include guard.
2219         * cli/cli-utils.h: Rename include guard.
2220         * cli/cli-style.h: Rename include guard.
2221         * cli/cli-setshow.h: Rename include guard.
2222         * cli/cli-script.h: Rename include guard.
2223         * cli/cli-interp.h: Rename include guard.
2224         * cli/cli-decode.h: Rename include guard.
2225         * cli/cli-cmds.h: Rename include guard.
2226         * charset-list.h: Add include guard.
2227         * buildsym-legacy.h: Rename include guard.
2228         * bfin-tdep.h: Add include guard.
2229         * ax.h: Rename include guard.
2230         * arm-linux-tdep.h: Add include guard.
2231         * arm-fbsd-tdep.h: Add include guard.
2232         * arch/xtensa.h: Rename include guard.
2233         * arch/tic6x.h: Add include guard.
2234         * arch/i386.h: Add include guard.
2235         * arch/arm.h: Rename include guard.
2236         * arch/arm-linux.h: Rename include guard.
2237         * arch/arm-get-next-pcs.h: Rename include guard.
2238         * arch/amd64.h: Add include guard.
2239         * arch/aarch64-insn.h: Rename include guard.
2240         * arch-utils.h: Rename include guard.
2241         * annotate.h: Add include guard.
2242         * amd64-darwin-tdep.h: Rename include guard.
2243         * aarch64-linux-tdep.h: Add include guard.
2244         * aarch64-fbsd-tdep.h: Add include guard.
2245         * aarch32-linux-nat.h: Add include guard.
2246
2247 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2248
2249         * macrotab.c (macro_define_internal): New function that
2250         factorizes macro_define_object_internal and macro_define_function
2251         code.
2252         (macro_define_object_internal): Use macro_define_internal.
2253         (macro_define_function): Likewise.
2254
2255 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2256
2257         * macrocmd.c (extract_identifier): Return
2258         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
2259         callers.
2260
2261 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
2262
2263         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
2264
2265 2019-02-05  Tom Tromey  <tom@tromey.com>
2266
2267         * target.c (target_stack::unpush): Move assertion earlier.
2268
2269 2019-01-30  Tom Tromey  <tom@tromey.com>
2270
2271         PR python/23615:
2272         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
2273         (gdbpy_parse_and_eval): Likewise.
2274         * python/python-internal.h (gdbpy_allow_threads): New class.
2275
2276 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
2277
2278         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
2279         (aarch64_fbsd_fpregmap): Move earlier.
2280         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
2281         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2282         instead of individual calls to trad_frame_set_reg_addr.
2283         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
2284         earlier.
2285         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
2286         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2287         instead of individual calls to trad_frame_set_reg_addr.
2288
2289 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
2290
2291         * CONTRIBUTE: Replace contribution list with wiki link.
2292
2293 2019-01-25  Tom Tromey  <tom@tromey.com>
2294
2295         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
2296
2297 2019-01-25  Tom Tromey  <tom@tromey.com>
2298
2299         * xtensa-linux-nat.c: Fix common/ includes.
2300         * xml-support.h: Fix common/ includes.
2301         * xml-support.c: Fix common/ includes.
2302         * x86-linux-nat.c: Fix common/ includes.
2303         * windows-nat.c: Fix common/ includes.
2304         * varobj.h: Fix common/ includes.
2305         * varobj.c: Fix common/ includes.
2306         * value.c: Fix common/ includes.
2307         * valops.c: Fix common/ includes.
2308         * utils.c: Fix common/ includes.
2309         * unittests/xml-utils-selftests.c: Fix common/ includes.
2310         * unittests/utils-selftests.c: Fix common/ includes.
2311         * unittests/unpack-selftests.c: Fix common/ includes.
2312         * unittests/tracepoint-selftests.c: Fix common/ includes.
2313         * unittests/style-selftests.c: Fix common/ includes.
2314         * unittests/string_view-selftests.c: Fix common/ includes.
2315         * unittests/scoped_restore-selftests.c: Fix common/ includes.
2316         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
2317         * unittests/scoped_fd-selftests.c: Fix common/ includes.
2318         * unittests/rsp-low-selftests.c: Fix common/ includes.
2319         * unittests/parse-connection-spec-selftests.c: Fix common/
2320         includes.
2321         * unittests/optional-selftests.c: Fix common/ includes.
2322         * unittests/offset-type-selftests.c: Fix common/ includes.
2323         * unittests/observable-selftests.c: Fix common/ includes.
2324         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
2325         * unittests/memrange-selftests.c: Fix common/ includes.
2326         * unittests/memory-map-selftests.c: Fix common/ includes.
2327         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
2328         * unittests/function-view-selftests.c: Fix common/ includes.
2329         * unittests/environ-selftests.c: Fix common/ includes.
2330         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
2331         * unittests/common-utils-selftests.c: Fix common/ includes.
2332         * unittests/cli-utils-selftests.c: Fix common/ includes.
2333         * unittests/array-view-selftests.c: Fix common/ includes.
2334         * ui-file.c: Fix common/ includes.
2335         * tui/tui-io.c: Fix common/ includes.
2336         * tracepoint.h: Fix common/ includes.
2337         * tracepoint.c: Fix common/ includes.
2338         * tracefile-tfile.c: Fix common/ includes.
2339         * top.h: Fix common/ includes.
2340         * top.c: Fix common/ includes.
2341         * thread.c: Fix common/ includes.
2342         * target/waitstatus.h: Fix common/ includes.
2343         * target/waitstatus.c: Fix common/ includes.
2344         * target.h: Fix common/ includes.
2345         * target.c: Fix common/ includes.
2346         * target-memory.c: Fix common/ includes.
2347         * target-descriptions.c: Fix common/ includes.
2348         * symtab.h: Fix common/ includes.
2349         * symfile.c: Fix common/ includes.
2350         * stap-probe.c: Fix common/ includes.
2351         * spu-linux-nat.c: Fix common/ includes.
2352         * sparc-nat.c: Fix common/ includes.
2353         * source.c: Fix common/ includes.
2354         * solib.c: Fix common/ includes.
2355         * solib-target.c: Fix common/ includes.
2356         * ser-unix.c: Fix common/ includes.
2357         * ser-tcp.c: Fix common/ includes.
2358         * ser-pipe.c: Fix common/ includes.
2359         * ser-base.c: Fix common/ includes.
2360         * selftest-arch.c: Fix common/ includes.
2361         * s12z-tdep.c: Fix common/ includes.
2362         * rust-exp.y: Fix common/ includes.
2363         * rs6000-aix-tdep.c: Fix common/ includes.
2364         * riscv-tdep.c: Fix common/ includes.
2365         * remote.c: Fix common/ includes.
2366         * remote-notif.h: Fix common/ includes.
2367         * remote-fileio.h: Fix common/ includes.
2368         * remote-fileio.c: Fix common/ includes.
2369         * regcache.h: Fix common/ includes.
2370         * regcache.c: Fix common/ includes.
2371         * record-btrace.c: Fix common/ includes.
2372         * python/python.c: Fix common/ includes.
2373         * python/py-type.c: Fix common/ includes.
2374         * python/py-inferior.c: Fix common/ includes.
2375         * progspace.h: Fix common/ includes.
2376         * producer.c: Fix common/ includes.
2377         * procfs.c: Fix common/ includes.
2378         * proc-api.c: Fix common/ includes.
2379         * printcmd.c: Fix common/ includes.
2380         * ppc-linux-nat.c: Fix common/ includes.
2381         * parser-defs.h: Fix common/ includes.
2382         * osdata.c: Fix common/ includes.
2383         * obsd-nat.c: Fix common/ includes.
2384         * nat/x86-linux.c: Fix common/ includes.
2385         * nat/x86-linux-dregs.c: Fix common/ includes.
2386         * nat/x86-dregs.h: Fix common/ includes.
2387         * nat/x86-dregs.c: Fix common/ includes.
2388         * nat/ppc-linux.c: Fix common/ includes.
2389         * nat/mips-linux-watch.h: Fix common/ includes.
2390         * nat/mips-linux-watch.c: Fix common/ includes.
2391         * nat/linux-waitpid.c: Fix common/ includes.
2392         * nat/linux-ptrace.h: Fix common/ includes.
2393         * nat/linux-ptrace.c: Fix common/ includes.
2394         * nat/linux-procfs.c: Fix common/ includes.
2395         * nat/linux-personality.c: Fix common/ includes.
2396         * nat/linux-osdata.c: Fix common/ includes.
2397         * nat/linux-namespaces.c: Fix common/ includes.
2398         * nat/linux-btrace.h: Fix common/ includes.
2399         * nat/linux-btrace.c: Fix common/ includes.
2400         * nat/fork-inferior.c: Fix common/ includes.
2401         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2402         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2403         * nat/aarch64-linux.c: Fix common/ includes.
2404         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2405         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2406         * namespace.h: Fix common/ includes.
2407         * mips-linux-tdep.c: Fix common/ includes.
2408         * minsyms.c: Fix common/ includes.
2409         * mi/mi-parse.h: Fix common/ includes.
2410         * mi/mi-main.c: Fix common/ includes.
2411         * mi/mi-cmd-env.c: Fix common/ includes.
2412         * memrange.h: Fix common/ includes.
2413         * memattr.c: Fix common/ includes.
2414         * maint.h: Fix common/ includes.
2415         * maint.c: Fix common/ includes.
2416         * main.c: Fix common/ includes.
2417         * machoread.c: Fix common/ includes.
2418         * location.c: Fix common/ includes.
2419         * linux-thread-db.c: Fix common/ includes.
2420         * linux-nat.c: Fix common/ includes.
2421         * linux-fork.c: Fix common/ includes.
2422         * inline-frame.c: Fix common/ includes.
2423         * infrun.c: Fix common/ includes.
2424         * inflow.c: Fix common/ includes.
2425         * inferior.h: Fix common/ includes.
2426         * inferior.c: Fix common/ includes.
2427         * infcmd.c: Fix common/ includes.
2428         * inf-ptrace.c: Fix common/ includes.
2429         * inf-child.c: Fix common/ includes.
2430         * ia64-linux-nat.c: Fix common/ includes.
2431         * i387-tdep.c: Fix common/ includes.
2432         * i386-tdep.c: Fix common/ includes.
2433         * i386-linux-tdep.c: Fix common/ includes.
2434         * i386-linux-nat.c: Fix common/ includes.
2435         * i386-go32-tdep.c: Fix common/ includes.
2436         * i386-fbsd-tdep.c: Fix common/ includes.
2437         * i386-fbsd-nat.c: Fix common/ includes.
2438         * guile/scm-type.c: Fix common/ includes.
2439         * guile/guile.c: Fix common/ includes.
2440         * go32-nat.c: Fix common/ includes.
2441         * gnu-nat.c: Fix common/ includes.
2442         * gdbthread.h: Fix common/ includes.
2443         * gdbarch-selftests.c: Fix common/ includes.
2444         * gdb_usleep.c: Fix common/ includes.
2445         * gdb_select.h: Fix common/ includes.
2446         * gdb_bfd.c: Fix common/ includes.
2447         * gcore.c: Fix common/ includes.
2448         * fork-child.c: Fix common/ includes.
2449         * findvar.c: Fix common/ includes.
2450         * fbsd-nat.c: Fix common/ includes.
2451         * event-top.c: Fix common/ includes.
2452         * event-loop.c: Fix common/ includes.
2453         * dwarf2read.c: Fix common/ includes.
2454         * dwarf2loc.c: Fix common/ includes.
2455         * dwarf2-frame.c: Fix common/ includes.
2456         * dwarf-index-cache.c: Fix common/ includes.
2457         * dtrace-probe.c: Fix common/ includes.
2458         * disasm-selftests.c: Fix common/ includes.
2459         * defs.h: Fix common/ includes.
2460         * csky-tdep.c: Fix common/ includes.
2461         * cp-valprint.c: Fix common/ includes.
2462         * cp-support.h: Fix common/ includes.
2463         * cp-support.c: Fix common/ includes.
2464         * corelow.c: Fix common/ includes.
2465         * completer.h: Fix common/ includes.
2466         * completer.c: Fix common/ includes.
2467         * compile/compile.c: Fix common/ includes.
2468         * compile/compile-loc2c.c: Fix common/ includes.
2469         * compile/compile-cplus-types.c: Fix common/ includes.
2470         * compile/compile-cplus-symbols.c: Fix common/ includes.
2471         * command.h: Fix common/ includes.
2472         * cli/cli-dump.c: Fix common/ includes.
2473         * cli/cli-cmds.c: Fix common/ includes.
2474         * charset.c: Fix common/ includes.
2475         * build-id.c: Fix common/ includes.
2476         * btrace.h: Fix common/ includes.
2477         * btrace.c: Fix common/ includes.
2478         * breakpoint.h: Fix common/ includes.
2479         * breakpoint.c: Fix common/ includes.
2480         * ax.h: 
2481         (enum agent_op): Fix common/ includes.
2482         * ax-general.c (struct aop_map): Fix common/ includes.
2483         * ax-gdb.c: Fix common/ includes.
2484         * auxv.c: Fix common/ includes.
2485         * auto-load.c: Fix common/ includes.
2486         * arm-tdep.c: Fix common/ includes.
2487         * arch/riscv.c: Fix common/ includes.
2488         * arch/ppc-linux-common.c: Fix common/ includes.
2489         * arch/i386.c: Fix common/ includes.
2490         * arch/arm.c: Fix common/ includes.
2491         * arch/arm-linux.c: Fix common/ includes.
2492         * arch/arm-get-next-pcs.c: Fix common/ includes.
2493         * arch/amd64.c: Fix common/ includes.
2494         * arch/aarch64.c: Fix common/ includes.
2495         * arch/aarch64-insn.c: Fix common/ includes.
2496         * arch-utils.c: Fix common/ includes.
2497         * amd64-windows-tdep.c: Fix common/ includes.
2498         * amd64-tdep.c: Fix common/ includes.
2499         * amd64-sol2-tdep.c: Fix common/ includes.
2500         * amd64-obsd-tdep.c: Fix common/ includes.
2501         * amd64-nbsd-tdep.c: Fix common/ includes.
2502         * amd64-linux-tdep.c: Fix common/ includes.
2503         * amd64-linux-nat.c: Fix common/ includes.
2504         * amd64-fbsd-tdep.c: Fix common/ includes.
2505         * amd64-fbsd-nat.c: Fix common/ includes.
2506         * amd64-dicos-tdep.c: Fix common/ includes.
2507         * amd64-darwin-tdep.c: Fix common/ includes.
2508         * agent.c: Fix common/ includes.
2509         * ada-lang.h: Fix common/ includes.
2510         * ada-lang.c: Fix common/ includes.
2511         * aarch64-tdep.c: Fix common/ includes.
2512
2513 2019-01-25  Tom Tromey  <tom@tromey.com>
2514
2515         * common/create-version.sh: Use common/version.h.
2516
2517 2019-01-24  Pedro Alves  <palves@redhat.com>
2518
2519         * infrun.c (signal_stop, signal_print, signal_program)
2520         (signal_catch, signal_pass): Now arrays instead of pointers.
2521         (update_signals_program_target, do_target_resume)
2522         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2523         * linux-nat.c (linux_nat_target::pass_signals)
2524         (linux_nat_target::create_inferior, linux_nat_target::attach):
2525         Adjust.
2526         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2527         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2528         * procfs.c (procfs_target::pass_signals): Adjust.
2529         * record-full.c (record_full_target::resume): Adjust.
2530         * remote.c (remote_target::pass_signals)
2531         (remote_target::program_signals): Adjust.
2532         * target-debug.h (target_debug_print_signals): Now takes a
2533         gdb::array_view as parameter.  Adjust.
2534         * target.h (target_ops) <pass_signals, program_signals>: Replace
2535         pointer and length parameters with gdb::array_view.
2536         (target_pass_signals, target_program_signals): Likewise.
2537         * target-delegates.c: Regenerate.
2538
2539 2019-01-24  Pedro Alves  <palves@redhat.com>
2540
2541         * common/forward-scope-exit.h
2542         (forward_scope_exit::forward_scope_exit): Pass arguments to
2543         m_bind_function directly, instead of creating a std::bind and
2544         copying that.
2545
2546 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2547
2548         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2549         for static members.
2550         (pass_in_v_vfp_candidate): Likewise.
2551
2552 2019-01-23  Tom Tromey  <tom@tromey.com>
2553             Pedro Alves  <palves@redhat.com>
2554
2555         * regcache.c (class regcache_invalidator): Remove.
2556         (regcache::raw_write): Use make_scope_exit.
2557
2558 2019-01-23  Tom Tromey  <tom@tromey.com>
2559
2560         * ui-out.h (class ui_out_emit_type): Update comment.
2561
2562 2019-01-23  Tom Tromey  <tom@tromey.com>
2563
2564         * infrun.c (fetch_inferior_event): Update comment.
2565
2566 2019-01-23  Tom Tromey  <tom@tromey.com>
2567             Pedro Alves  <palves@redhat.com>
2568
2569         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2570         parameter.
2571         (fetch_inferior_event): Use SCOPE_EXIT.
2572
2573
2574 2019-01-23  Tom Tromey  <tom@tromey.com>
2575             Pedro Alves  <palves@redhat.com>
2576
2577         * infrun.c (disable_thread_events): Delete.
2578         (stop_all_threads): Use SCOPE_EXIT.
2579
2580 2019-01-23  Tom Tromey  <tom@tromey.com>
2581             Pedro Alves  <palves@redhat.com>
2582
2583         * symfile.c: Include forward-scope-exit.h.
2584         (clear_symtab_users_cleanup): Replace forward declaration with
2585         a FORWARD_SCOPE_EXIT.
2586         (syms_from_objfile_1): Use the forward_scope_exit and
2587         gdb::optional instead of cleanup_function.
2588         (reread_symbols): Use the forward_scope_exit instead of
2589         cleanup_function.
2590         (clear_symtab_users_cleanup): Remove function.
2591
2592 2019-01-23  Tom Tromey  <tom@tromey.com>
2593             Pedro Alves  <palves@redhat.com>
2594
2595         * linux-nat.c: Include scope-exit.h.
2596         (cleanup_target_stop): Remove.
2597         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2598         SCOPE_EXIT.
2599
2600 2019-01-23  Tom Tromey  <tom@tromey.com>
2601             Pedro Alves  <palves@redhat.com>
2602
2603         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2604         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2605
2606 2019-01-23  Tom Tromey  <tom@tromey.com>
2607             Andrew Burgess  <andrew.burgess@embecosm.com>
2608             Pedro Alves  <palves@redhat.com>
2609
2610         * infrun.c (fetch_inferior_event): Use scope_exit.
2611         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2612         * top.c (execute_command): Use scope_exit.
2613         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2614         * utils.c (do_bpstat_clear_actions_cleanup)
2615         (make_bpstat_clear_actions_cleanup): Remove.
2616
2617 2019-01-23  Tom Tromey  <tom@tromey.com>
2618             Pedro Alves  <palves@redhat.com>
2619
2620         * infrun.c: Include "common/scope-exit.h"
2621         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2622         (wait_for_inferior): Use SCOPE_EXIT.
2623         (fetch_inferior_event): Use scope_exit.
2624
2625 2019-01-23  Tom Tromey  <tom@tromey.com>
2626             Pedro Alves  <palves@redhat.com>
2627
2628         * breakpoint.c (create_breakpoint): Remove cleanup.
2629
2630 2019-01-23  Tom Tromey  <tom@tromey.com>
2631             Andrew Burgess  <andrew.burgess@embecosm.com>
2632             Pedro Alves  <palves@redhat.com>
2633
2634 2019-01-23  Pedro Alves  <palves@redhat.com>
2635
2636         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2637
2638 2019-01-23  Pedro Alves  <palves@redhat.com>
2639             Andrew Burgess  <andrew.burgess@embecosm.com>
2640
2641         * gdbthread.h: Include "common/forward-scope-exit.h".
2642         (scoped_finish_thread_state): Redefine custom class in terms of
2643         forward_scope_exit.
2644
2645 2019-01-23  Pedro Alves  <palves@redhat.com>
2646             Andrew Burgess  <andrew.burgess@embecosm.com>
2647
2648         * common/forward-scope-exit.h: New file.
2649
2650 2019-01-23  Pedro Alves  <palves@redhat.com>
2651             Andrew Burgess  <andrew.burgess@embecosm.com>
2652             Tom Tromey  <tom@tromey.com>
2653
2654         * common/scope-exit.h: New file.
2655
2656 2019-01-23  Pedro Alves  <palves@redhat.com>
2657
2658         * common/preprocessor.h (ESC): Rename to ...
2659         (ESC_PARENS): ... this.
2660         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2661         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2662
2663 2019-01-23  Tom Tromey  <tom@tromey.com>
2664
2665         * language.h (class scoped_switch_to_sym_language_if_auto):
2666         Initialize m_lang in both cases.
2667
2668 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2669
2670         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2671         with XCNEW.
2672
2673 2019-01-22  Tom Tromey  <tom@tromey.com>
2674
2675         * corelow.c: Do not include sys/file.h.
2676
2677 2019-01-22  Tom Tromey  <tom@tromey.com>
2678
2679         * tui/tui-wingeneral.h: Include gdb_curses.h.
2680
2681 2019-01-22  Tom Tromey  <tom@tromey.com>
2682
2683         * source-cache.h (class source_cache) <get_source_lines,
2684         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2685
2686 2019-01-22  Tom Tromey  <tom@tromey.com>
2687
2688         * remote-fileio.h (struct remote_target): Declare.
2689
2690 2019-01-22  Tom Tromey  <tom@tromey.com>
2691
2692         * python/py-arch.c: Do not include py-ref.h.
2693         * python/py-bpevent.c: Do not include py-ref.h.
2694         * python/py-cmd.c: Do not include py-ref.h.
2695         * python/py-continueevent.c: Do not include py-ref.h.
2696         * python/py-event.h: Do not include py-ref.h.
2697         * python/py-evtregistry.c: Do not include py-ref.h.
2698         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2699         * python/py-frame.c: Do not include py-ref.h.
2700         * python/py-framefilter.c: Do not include py-ref.h.
2701         * python/py-function.c: Do not include py-ref.h.
2702         * python/py-infevents.c: Do not include py-ref.h.
2703         * python/py-linetable.c: Do not include py-ref.h.
2704         * python/py-objfile.c: Do not include py-ref.h.
2705         * python/py-param.c: Do not include py-ref.h.
2706         * python/py-prettyprint.c: Do not include py-ref.h.
2707         * python/py-progspace.c: Do not include py-ref.h.
2708         * python/py-symbol.c: Do not include py-ref.h.
2709         * python/py-symtab.c: Do not include py-ref.h.
2710         * python/py-type.c: Do not include py-ref.h.
2711         * python/py-unwind.c: Do not include py-ref.h.
2712         * python/py-utils.c: Do not include py-ref.h.
2713         * python/py-value.c: Do not include py-ref.h.
2714         * python/py-varobj.c: Do not include py-ref.h.
2715         * python/py-xmethods.c: Do not include py-ref.h.
2716         * python/python.c: Do not include py-ref.h.
2717         * varobj.c: Do not include py-ref.h.
2718
2719 2019-01-22  Tom Tromey  <tom@tromey.com>
2720
2721         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2722         keyword for bcache.
2723
2724 2019-01-22  Tom Tromey  <tom@tromey.com>
2725
2726         * compile/compile-cplus-types.c: Remove a comment by #include.
2727
2728 2019-01-22  Tom Tromey  <tom@tromey.com>
2729
2730         * compile/gcc-c-plugin.h: Include compile-internal.h.
2731
2732 2019-01-22  Tom Tromey  <tom@tromey.com>
2733
2734         * stabsread.c (EXTERN): Do not define.
2735         (symnum, next_symbol_text_func, processing_gcc_compilation)
2736         (within_function, global_sym_chain, global_stabs)
2737         (previous_stab_code, this_object_header_files)
2738         (n_this_object_header_files)
2739         (n_allocated_this_object_header_files): Define.
2740         * stabsread.h (EXTERN): Never define.  Use "extern".
2741
2742 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2743
2744         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2745         history_value.
2746
2747 2019-01-21  Tom Tromey  <tom@tromey.com>
2748
2749         * ui-out.c: Fix includes.
2750         * tui/tui-source.c: Fix includes.
2751         * target.c: Fix includes.
2752         * remote.c: Fix includes.
2753         * regcache.c: Fix includes.
2754         * python/py-block.c: Fix includes.
2755         * printcmd.c: Fix includes.
2756         * or1k-tdep.c: Fix includes.
2757         * mi/mi-main.c: Fix includes.
2758         * m32r-tdep.c: Fix includes.
2759         * csky-tdep.c: Fix includes.
2760         * compile/compile-cplus-types.c: Fix includes.
2761         * cli/cli-interp.c: Fix includes.
2762
2763 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2764
2765         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2766         for padding.
2767
2768 2019-01-16  Tom Tromey  <tom@tromey.com>
2769
2770         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2771         earlier.
2772         (struct objfile) <msymbols_range>: Move from top level.
2773         <msymbols>: New method.
2774         (class objfile_msymbols): Remove.
2775         * symtab.c (default_collect_symbol_completion_matches_break_on):
2776         Update.
2777         * symmisc.c (dump_msymbols): Update.
2778         * stabsread.c (scan_file_globals): Update.
2779         * objc-lang.c (info_selectors_command, info_classes_command)
2780         (find_methods): Update.
2781         * minsyms.c (find_solib_trampoline_target): Update.
2782         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2783         * coffread.c (coff_symfile_read): Update.
2784         * ada-lang.c (ada_lookup_simple_minsym)
2785         (ada_collect_symbol_completion_matches): Update.
2786
2787 2019-01-16  Tom Tromey  <tom@tromey.com>
2788
2789         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2790         type.  Remove no-argument constructor.
2791         <iterator::operator++>: Simplify.
2792         <begin>: Update.
2793         <end>: Use minimal_symbol_count.
2794
2795 2019-01-16  Tom Tromey  <tom@tromey.com>
2796
2797         * objfiles.h (struct objfile) <psymtabs>: New method.
2798         (class objfile_psymtabs): Remove.
2799         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2800         typedef.
2801         <range>: New method.
2802         (require_partial_symbols): Change return type.
2803         * psymtab.c (require_partial_symbols)
2804         (psym_expand_symtabs_matching): Update.
2805         * mdebugread.c (parse_partial_symbols): Update.
2806         * dbxread.c (dbx_end_psymtab): Update.
2807
2808 2019-01-15  Tom Tromey  <tom@tromey.com>
2809
2810         * symtab.c (lookup_objfile_from_block)
2811         (lookup_symbol_in_objfile_symtabs)
2812         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2813         (find_line_symtab, info_sources_command)
2814         (default_collect_symbol_completion_matches_break_on)
2815         (make_source_files_completion_list): Update.
2816         * symmisc.c (print_objfile_statistics, dump_objfile)
2817         (maintenance_print_symbols, maintenance_info_symtabs)
2818         (maintenance_check_symtabs, maintenance_info_line_tables):
2819         Update.
2820         * source.c (select_source_symtab)
2821         (forget_cached_source_info_for_objfile): Update.
2822         * objfiles.h (class objfile_compunits): Remove.
2823         (struct objfile) <compunits_range>: New typedef.
2824         (compunits): New method.
2825         * objfiles.c (objfile_relocate1): Update.
2826         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2827         * maint.c (count_symtabs_and_blocks): Update.
2828         * linespec.c (iterate_over_all_matching_symtabs): Update.
2829         * cp-support.c (add_symbol_overload_list_qualified): Update.
2830         * coffread.c (coff_symtab_read): Update.
2831         * ada-lang.c (add_nonlocal_symbols)
2832         (ada_collect_symbol_completion_matches)
2833         (ada_add_global_exceptions): Update.
2834
2835 2019-01-15  Tom Tromey  <tom@tromey.com>
2836
2837         * progspace.h (program_space) <objfiles_safe_range>: New
2838         typedef.
2839         <objfiles_safe>: New method.
2840         * objfiles.h (class all_objfiles_safe): Remove.
2841         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2842         * jit.c (jit_inferior_exit_hook): Update.
2843
2844 2019-01-17  Tom Tromey  <tom@tromey.com>
2845
2846         * progspace.h (program_space) <objfiles_range>: New typedef.
2847         <objfiles>: New method.
2848         <objfiles_head>: Rename from objfiles.
2849         (object_files): Update.
2850         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2851         * guile/scm-pretty-print.c
2852         (ppscm_find_pretty_printer_from_objfiles): Update.
2853         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2854         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2855         Update.
2856         * python/py-progspace.c (pspy_get_objfiles): Update.
2857         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2858         Update.
2859         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2860         (objfpy_lookup_objfile_by_build_id): Update.
2861         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2862         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2863         Update.
2864         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2865         (expand_symtab_containing_pc, lookup_objfile_from_block)
2866         (lookup_static_symbol, basic_lookup_transparent_type)
2867         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2868         (find_line_symtab, info_sources_command)
2869         (default_collect_symbol_completion_matches_break_on)
2870         (make_source_files_completion_list, find_main_name): Update.
2871         * symmisc.c (print_symbol_bcache_statistics)
2872         (print_objfile_statistics, maintenance_print_symbols)
2873         (maintenance_print_msymbols, maintenance_print_objfiles)
2874         (maintenance_info_symtabs, maintenance_check_symtabs)
2875         (maintenance_expand_symtabs, maintenance_info_line_tables):
2876         Update.
2877         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2878         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2879         (map_overlay_command, unmap_overlay_command)
2880         (simple_overlay_update, expand_symtabs_matching)
2881         (map_symbol_filenames): Update.
2882         * symfile-debug.c (set_debug_symfile): Update.
2883         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2884         Update.
2885         * source.c (select_source_symtab, forget_cached_source_info):
2886         Update.
2887         * solib.c (solib_read_symbols): Update.
2888         * solib-spu.c (append_ocl_sos): Update.
2889         * psymtab.c (maintenance_print_psymbols)
2890         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2891         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2892         * printcmd.c (info_symbol_command): Update.
2893         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2894         Update.
2895         * objfiles.h (class all_objfiles): Remove.
2896         * objfiles.c (have_partial_symbols, have_full_symbols)
2897         (have_minimal_symbols, qsort_cmp, update_section_map)
2898         (shared_objfile_contains_address_p)
2899         (default_iterate_over_objfiles_in_search_order): Update.
2900         * objc-lang.c (info_selectors_command, info_classes_command)
2901         (find_methods): Update.
2902         * minsyms.c (find_solib_trampoline_target): Update.
2903         * maint.c (maintenance_info_sections)
2904         (maintenance_translate_address, count_symtabs_and_blocks):
2905         Update.
2906         * main.c (captured_main_1): Update.
2907         * linux-thread-db.c (try_thread_db_load_from_pdir)
2908         (has_libpthread): Update.
2909         * linespec.c (iterate_over_all_matching_symtabs)
2910         (search_minsyms_for_name): Update.
2911         * jit.c (jit_find_objf_with_entry_addr): Update.
2912         * hppa-tdep.c (find_unwind_entry)
2913         (hppa_lookup_stub_minimal_symbol): Update.
2914         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2915         Update.
2916         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2917         (elf_gnu_ifunc_resolve_by_got): Update.
2918         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2919         * dwarf-index-write.c (save_gdb_index_command): Update.
2920         * cp-support.c (add_symbol_overload_list_qualified): Update.
2921         * breakpoint.c (create_overlay_event_breakpoint)
2922         (create_longjmp_master_breakpoint)
2923         (create_std_terminate_master_breakpoint)
2924         (create_exception_master_breakpoint): Update.
2925         * blockframe.c (find_pc_partial_function): Update.
2926         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2927         (ada_collect_symbol_completion_matches)
2928         (ada_add_global_exceptions): Update.
2929
2930 2019-01-17  Tom Tromey  <tom@tromey.com>
2931
2932         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2933         declare VEC.
2934         (solib_target_parse_libraries): Change return type.
2935         (library_list_start_segment, library_list_start_section)
2936         (library_list_end_library, library_list_start_library); Update.
2937         (solib_target_free_library_list): Remove.
2938         (solib_target_parse_libraries): Remove cleanup.  Change return
2939         type.
2940         (solib_target_current_sos): Update.
2941
2942 2019-01-17  Tom Tromey  <tromey@bapiya>
2943
2944         * valprint.c: Replace "the the" with "the".
2945         * symtab.c: Replace "the the" with "the".
2946         * solib.c: Replace "the the" with "the".
2947         * solib-dsbt.c: Replace "the the" with "the".
2948         * linespec.c: Replace "the the" with "the".
2949         * dwarf2loc.h: Replace "the the" with "the".
2950         * amd64-windows-tdep.c: Replace "the the" with "the".
2951         * aarch64-tdep.c: Replace "the the" with "the".
2952
2953 2019-01-16  Keith Seitz  <keiths@redhat.com>
2954
2955         PR gdb/23773
2956         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2957         <builder>: Rename to ..
2958         <m_builder>: ... this and make private.
2959         (dwarf2_cu::get_builder): New method.  Change all users of
2960         `builder' to use this method.
2961         (dwarf2_start_symtab): Move to ...
2962         (dwarf2_cu::start_symtab): ... here.  Update all callers
2963         (setup_type_unit_groups): Move to ...
2964         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
2965         callers.
2966         (dwarf2_cu::reset_builder): New method.
2967         (process_full_compunit, process_full_type_unit): Use
2968         dwarf2_cu::reset_builder.
2969         (follow_die_offset): Record the ancestor CU if it is different
2970         from the followed DIE's CU.
2971         (follow_die_sig_1): Likewise.
2972
2973 2019-01-15  Tom Tromey  <tom@tromey.com>
2974
2975         * remote.c (class remote_state) <buf>: Now a char_vector.
2976         <buf_size>: Remove.
2977         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
2978         parameter.
2979         (remote_target::getpkt_or_notif_sane_1)
2980         (remote_target::getpkt_sane)
2981         (remote_target::getpkt_or_notif_sane): Likewise.
2982         (class remote_target) <putpkt>: New overload.
2983         (remote_target::read_frame): Change type of "buf_p".  Remove
2984         sizeof_p parameter.
2985         (packet_ok): New overload.
2986         (packet_check_result): New overload.
2987         Update all uses.
2988
2989 2019-01-14  Tom Tromey  <tom@tromey.com>
2990
2991         * remote-notif.c (handle_notification, remote_notif_ack)
2992         (remote_notif_parse): Make "buf" const.
2993         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
2994         const.
2995         (remote_notif_parse, remote_notif_ack, handle_notification):
2996         Likewise.
2997         * remote.c (remote_notif_stop_parse): Make "buf" const.
2998         (remote_target::remote_parse_stop_reply): Make "buf" const.
2999         (remote_notif_stop_ack): Make "buf" const.
3000
3001 2019-01-14  Tom Tromey  <tom@tromey.com>
3002
3003         * remote.c (remote_console_output): Make parameter const.
3004
3005 2019-01-14  Tom Tromey  <tom@tromey.com>
3006
3007         * target-debug.h (target_debug_print_signals): Constify.
3008         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
3009         * procfs.c (procfs_target::pass_signals): Update.
3010         * linux-nat.c (linux_nat_target::pass_signals): Update.
3011         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
3012         * target-delegates.c: Rebuild.
3013         * remote.c (remote_target::program_signals): Update.
3014         (remote_target::pass_signals): Update.
3015         * target.c (target_pass_signals): Constify argument.
3016         (target_program_signals): Likewise.
3017         * target.h (struct target_ops) <pass_signals, program_signals>:
3018         Constify argument.
3019         (target_pass_signals, target_program_signals): Constify argument.
3020
3021 2019-01-14  Tom Tromey  <tom@tromey.com>
3022
3023         PR tui/28819:
3024         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
3025
3026 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3027
3028         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
3029         field.
3030         * rs6000-tdep.c: Include reggroups.h.
3031         (IS_V_ALIAS_PSEUDOREG): Define.
3032         (rs6000_register_name): Return names for the "vX" aliases.
3033         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
3034         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
3035         aliases.  Call default_register_reggroup_p for all other
3036         pseudo-registers.
3037         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
3038         New functions.
3039         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
3040         Handle "vX" aliases.
3041         (v_alias_pseudo_register_collect): New function.
3042         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
3043         (rs6000_gdbarch_init): Initialize "vX" aliases as
3044         pseudo-registers.  Restore registration of
3045         rs6000_pseudo_register_reggroup_p with
3046         set_tdesc_pseudo_register_reggroup_p.
3047
3048 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
3049
3050         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
3051         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
3052         set_gdbarch_num_pseudo_regs.
3053
3054 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3055
3056         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
3057         Remove arg prefixname, add do_set and do_show.
3058         Add member functions set_list and show_list.
3059         * cli/cli-style.c (class cli_style_option): Update accordingly.
3060         (style_set_list): Move to file scope.
3061         (style_show_list): Likewise.
3062         (set_style): Call help_list.
3063         (show_style): Call cmd_show_list.
3064         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
3065         Update to use the new macro.
3066
3067 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
3068
3069         * ada-lang.c (_initialize_ada_language): Expand the help text
3070         for the "catch exception" command.
3071
3072 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3073
3074         * symtab.c (matching_obj_sections): Initialize obj,
3075         declare it closer to its usage.
3076
3077 2019-01-10  Tom Tromey  <tom@tromey.com>
3078
3079         * thread-iter.h (inf_threads_iterator): Use next_iterator.
3080         (basic_inf_threads_range): Remove.
3081         (inf_threads_range, inf_non_exited_threads_range)
3082         (safe_inf_threads_range): Use next_adapter.
3083
3084 2019-01-10  Keith Seitz  <keiths@redhat.com>
3085
3086         PR gdb/23712
3087         PR symtab/23010
3088         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
3089         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
3090
3091 2019-01-10  Keith Seitz  <keiths@redhat.com>
3092
3093         PR gdb/23712
3094         PR symtab/23010
3095         * dictionary.c (pending_to_vector): Remove.
3096         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3097         Remove _1 suffix, replacing functions of the same name.  Update
3098         all callers.
3099         (dict_create_hashed, dict_create_hashed_expandable)
3100         (dict_create_linear, dict_create_linear_expandable, dict_free)
3101         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
3102         Make functions static.
3103
3104 2019-01-10  Keith Seitz  <keiths@redhat.com>
3105
3106         PR gdb/23712
3107         PR symtab/23010
3108         * dictionary.h (struct dictionary): Replace declaration with
3109         multidictionary.
3110         (dict_create_hashed, dict_create_hashed_expandable)
3111         (dict_create_linear, dict_create_linear_expandable)
3112         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
3113         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
3114         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
3115         taking multidictionary argument.
3116         [ALL_DICT_SYMBOLS]: Update for multidictionary.
3117         * block.h (struct block) <dict>: Change to multidictionary
3118         and rename `multidict'.
3119         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
3120         symmisc.c: Update all dictionary references to multidictionary.
3121
3122 2019-01-10  Keith Seitz  <keiths@redhat.com>
3123
3124         PR gdb/23712
3125         PR symtab/23010
3126         * dictionary.c: Include unordered_map.
3127         (pending_to_vector): New function.
3128         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3129         Rewrite the non-"_1" functions to take vector instead
3130         of linked list.
3131         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
3132         "new" _1 versions of the same name.
3133         (multidictionary): Define.
3134         (std::hash<enum language): New definition.
3135         (collate_pending_symbols_by_language, mdict_create_hashed)
3136         (mdict_create_hashed_expandable, mdict_create_linear)
3137         (mdict_create_linear_expandable, mdict_free)
3138         (find_language_dictionary, create_new_language_dictionary)
3139         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
3140         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
3141         (mdict_size, mdict_empty): New functions.
3142         * dictionary.h (mdict_iterator): Define.
3143
3144 2019-01-10  Pedro Alves  <palves@redhat.com>
3145
3146         * breakpoint.c (read_uploaded_action)
3147         (create_tracepoint_from_upload): Adjust to use
3148         gdb::unique_xmalloc_ptr.
3149         * ctf.c (ctf_write_uploaded_tp):
3150         (SET_ARRAY_FIELD): Use emplace_back.
3151         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
3152         * tracefile-tfile.c (tfile_write_uploaded_tp):
3153         * tracepoint.c (parse_tracepoint_definition): Adjust to use
3154         gdb::unique_xmalloc_ptr.
3155         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
3156         at_string, cond_string, cmd_strings>: Replace char pointers
3157         with gdb::unique_xmalloc_ptr.
3158
3159 2019-01-10  Pedro Alves  <palves@redhat.com>
3160
3161         * solib-target.c (library_list_start_library): Don't xstrdup name.
3162
3163 2019-01-10  Pedro Alves  <palves@redhat.com>
3164
3165         * mdebugread.c (parse_partial_symbols): Use
3166         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
3167
3168 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3169
3170         * linux-fork.c (scoped_switch_fork_info)
3171         <~scoped_switch_fork_info>: Fix incorrect variable name.
3172
3173 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3174
3175         * linux-fork.c (scoped_switch_fork_info)
3176         <scoped_switch_fork_info>: Make explicit.
3177         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
3178
3179 2019-01-10  Tom Tromey  <tom@tromey.com>
3180
3181         * objfiles.h (objfile::reset_psymtabs): Update.
3182         * objfiles.c (objfile::objfile): Update.
3183         * psymtab.h (psymtab_storage::obstack): Update.
3184         (psymtab_storage::m_obstack): Use gdb::optional.
3185         (class psymtab_storage): Update comment.  Remove objfile
3186         parameter.
3187         * psymtab.c (psymtab_storage::psymtab_storage): Update.
3188
3189 2019-01-10  Tom Tromey  <tom@tromey.com>
3190
3191         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
3192         <free_psymtabs>: Now private.
3193         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
3194         (allocate_psymtab): Use new method.
3195
3196 2019-01-10  Tom Tromey  <tom@tromey.com>
3197
3198         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
3199         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
3200         * mdebugread.c (parse_partial_symbols): Use
3201         allocate_dependencies.
3202         * dwarf2read.c (dwarf2_create_include_psymtab): Use
3203         allocate_dependencies.
3204         (process_psymtab_comp_unit_reader)
3205         (build_type_psymtab_dependencies): Likewise.
3206         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
3207
3208 2019-01-10  Tom Tromey  <tom@tromey.com>
3209
3210         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
3211         PSYMBOL_SET_LANGUAGE.
3212         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
3213
3214 2019-01-10  Tom Tromey  <tom@tromey.com>
3215
3216         * psymtab.h (psymtab_storage::obstack): New method.
3217         <m_obstack>: Rename from obstack; now private.
3218         * psymtab.c (psymtab_storage): Update.
3219         * dwarf2read.c (create_addrmap_from_index)
3220         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
3221         Update.
3222
3223 2019-01-10  Tom Tromey  <tom@tromey.com>
3224
3225         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
3226         * objfiles.h (objfile::reset_psymtabs): New method.
3227
3228 2019-01-10  Tom Tromey  <tom@tromey.com>
3229
3230         * symmisc.c (print_symbol_bcache_statistics): Update.
3231         (print_objfile_statistics): Update.
3232         * symfile.c (reread_symbols): Update.
3233         * psymtab.h (class psymtab_storage): New.
3234         * psymtab.c (psymtab_storage): New constructor.
3235         (~psymtab_storage): New destructor.
3236         (require_partial_symbols): Update.
3237         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
3238         (find_pc_sect_psymtab, find_pc_sect_psymbol)
3239         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
3240         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
3241         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
3242         (start_psymtab_common, end_psymtab_common)
3243         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
3244         (allocate_psymtab): Update.
3245         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
3246         Update.
3247         (dump_psymtab_addrmap, maintenance_print_psymbols)
3248         (maintenance_check_psymtabs): Update.
3249         (class objfile_psymtabs): Move to objfiles.h.
3250         * psympriv.h (discard_psymtab): Now inline.
3251         (psymtab_discarder::psymtab_discarder): Update.
3252         (psymtab_discarder::~psymtab_discarder): Update.
3253         (ALL_OBJFILE_PSYMTABS): Rewrite.
3254         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
3255         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
3256         Remove fields.
3257         <partial_symtabs>: New field.
3258         (class objfile_psymtabs): Move from psymtab.h.  Update.
3259         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
3260         psymbol_cache.
3261         (objfile::~objfile): Don't destroy psymbol_cache.
3262         * mdebugread.c (parse_partial_symbols): Update.
3263         * dwarf2read.c (create_addrmap_from_index)
3264         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3265         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
3266         (add_partial_subprogram, dwarf2_ranges_read): Update.
3267         * dwarf-index-write.c (write_address_map)
3268         (write_one_signatured_type, recursively_write_psymbols)
3269         (class debug_names, class debug_names, write_psymtabs_to_index):
3270         Update.
3271
3272 2019-01-10  Tom Tromey  <tom@tromey.com>
3273
3274         * symtab.h (SYMBOL_SET_NAMES): Update.
3275         (symbol_set_names): Update.
3276         (MSYMBOL_SET_NAMES): Update.
3277         * symtab.c (symbol_set_names): Change argument to be an
3278         objfile_per_bfd_storage.
3279         * psymtab.c (add_psymbol_to_bcache): Update.
3280         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
3281
3282 2019-01-10  Tom Tromey  <tom@tromey.com>
3283
3284         * symtab.c (create_demangled_names_hash): Change argument to be an
3285         objfile_per_bfd_storage.
3286         (symbol_set_names): Update.
3287
3288 2019-01-10  Tom Tromey  <tom@tromey.com>
3289
3290         * xcoffread.c (xcoff_initial_scan): Unconditionally call
3291         init_psymbol_list.
3292         * psymtab.c (init_psymbol_list): Do nothing if already called.
3293         * psympriv.h (init_psymbol_list): Add comment.
3294         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
3295         init_psymbol_list.
3296         * dbxread.c (dbx_symfile_read): Unconditionally call
3297         init_psymbol_list.
3298
3299 2019-01-10  Tom Tromey  <tom@tromey.com>
3300
3301         * xcoffread.c (scan_xcoff_symtab): Update.
3302         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
3303         "where".
3304         * mdebugread.c (parse_partial_symbols)
3305         (handle_psymbol_enumerators): Update.
3306         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
3307         * dbxread.c (read_dbx_symtab): Update.
3308         * psympriv.h (psymbol_placement): New enum.
3309         (add_psymbol_to_list): Update.
3310
3311 2019-01-10  Tom Tromey  <tom@tromey.com>
3312
3313         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
3314         static_psymbols parameters.
3315         (scan_xcoff_symtab): Update.
3316         * psymtab.c (start_psymtab_common): Remove global_psymbols and
3317         static_psymbols parameters.
3318         * psympriv.h (start_psymtab_common): Update.
3319         * mdebugread.c (parse_partial_symbols): Update.
3320         * dwarf2read.c (create_partial_symtab): Update.
3321         * dbxread.c (read_dbx_symtab): Update.
3322         (start_psymtab): Remove global_psymbols and static_psymbols
3323         parameters.
3324
3325 2019-01-10  Tom Tromey  <tom@tromey.com>
3326
3327         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
3328         * psymtab.c (allocate_psymtab): Add comment.
3329         * psympriv.h (allocate_psymtab): Add comment.
3330         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
3331         initializations.
3332         * dbxread.c (dbx_end_psymtab): Remove some initializations.
3333
3334 2019-01-10  Tom Tromey  <tom@tromey.com>
3335
3336         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3337         Don't declare.
3338         * mipsread.c: Include mdebugread.h.
3339         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3340         Declare.
3341         * elfread.c: Include mdebugread.h.
3342
3343 2019-01-09  Tom Tromey  <tom@tromey.com>
3344
3345         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3346         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3347         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3348         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3349         (psym_lookup_symbol, psym_find_last_source_symtab)
3350         (psym_forget_cached_source_info, psym_print_stats)
3351         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3352         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3353         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3354         (psym_find_compunit_symtab_by_address)
3355         (maintenance_print_psymbols, maintenance_info_psymtabs)
3356         (maintenance_check_psymtabs): Use ranged for.
3357         * psymtab.h (class objfile_psymtabs): New.
3358         (require_partial_symbols): Return objfile_psymtabs.
3359         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3360
3361 2019-01-09  Tom Tromey  <tom@tromey.com>
3362
3363         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3364         (find_pc_mapped_section, list_overlays_command)
3365         (map_overlay_command, unmap_overlay_command)
3366         (simple_overlay_update): Use all_objfiles.
3367         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3368         * printcmd.c (info_symbol_command): Use all_objfiles.
3369         * objfiles.h (ALL_OBJSECTIONS): Remove.
3370         * maint.c (maintenance_translate_address): Use all_objfiles.
3371         * gcore.c (gcore_create_callback): Use all_objfiles.
3372         (objfile_find_memory_regions): Likewise.
3373
3374 2019-01-09  Tom Tromey  <tom@tromey.com>
3375
3376         * symtab.c (find_line_symtab, info_sources_command)
3377         (make_source_files_completion_list): Use objfile_compunits.
3378         * source.c (select_source_symtab): Use objfile_compunits.
3379         * objfiles.h (struct objfile): Update comment.
3380         (ALL_OBJFILES): Remove.
3381         (ALL_FILETABS): Remove.
3382         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3383         objfile_compunits.
3384
3385 2019-01-09  Tom Tromey  <tom@tromey.com>
3386
3387         * symmisc.c (print_objfile_statistics, dump_objfile)
3388         (maintenance_print_symbols): Use compunit_filetabs.
3389         * source.c (forget_cached_source_info_for_objfile): Use
3390         compunit_filetabs.
3391         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3392         (ALL_FILETABS): Use compunit_filetabs.
3393         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3394         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3395
3396 2019-01-09  Tom Tromey  <tom@tromey.com>
3397
3398         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3399         (compunit_filetabs): New.
3400         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3401         compunit_filetabs.
3402         (info_sources_command, make_source_files_completion_list): Remove
3403         declaration.
3404         * symmisc.c (print_objfile_statistics, dump_objfile)
3405         (maintenance_print_symbols): Remove declaration.
3406         (maintenance_info_symtabs): Use compunit_filetabs.
3407         (maintenance_info_line_tables): Likewise.
3408         * source.c (select_source_symtab): Change local variable name.
3409         (forget_cached_source_info_for_objfile): Remove declaration.
3410         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3411         * objfiles.c (objfile_relocate1): Remove declaration.
3412         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3413         declaration.
3414         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3415         * coffread.c (coff_symtab_read): Remove declaration.
3416         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3417         compunit_filetabs.
3418
3419 2019-01-09  Tom Tromey  <tom@tromey.com>
3420
3421         * symtab.c (lookup_objfile_from_block)
3422         (find_pc_sect_compunit_symtab, search_symbols)
3423         (default_collect_symbol_completion_matches_break_on): Use
3424         objfile_compunits.
3425         * objfiles.h (ALL_COMPUNITS): Remove.
3426         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3427         * cp-support.c (add_symbol_overload_list_qualified): Use
3428         objfile_compunits.
3429         * ada-lang.c (ada_collect_symbol_completion_matches)
3430         (ada_add_global_exceptions): Use objfile_compunits.
3431
3432 2019-01-09  Tom Tromey  <tom@tromey.com>
3433
3434         * source.c (select_source_symtab)
3435         (forget_cached_source_info_for_objfile): Remove declaration.
3436         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3437         declaration.
3438         * maint.c (count_symtabs_and_blocks): Remove declaration.
3439         * cp-support.c (add_symbol_overload_list_qualified): Remove
3440         declaration.
3441         * coffread.c (coff_symtab_read): Remove declaration.
3442         * symtab.c (lookup_symbol_in_objfile_symtabs)
3443         (basic_lookup_transparent_type_1): Use objfile_compunits.
3444         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3445         (info_sources_command, search_symbols)
3446         (default_collect_symbol_completion_matches_break_on)
3447         (make_source_files_completion_list): Remove declaration.
3448         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3449         (ada_collect_symbol_completion_matches)
3450         (ada_add_global_exceptions): Remove declaration.
3451         * linespec.c (iterate_over_all_matching_symtabs): Use
3452         objfile_compunits.
3453         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3454         (class objfile_compunits): New.
3455         (ALL_COMPUNITS): Use objfile_compunits.
3456         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3457         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3458         objfile_compunits.
3459         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3460
3461 2019-01-09  Tom Tromey  <tom@tromey.com>
3462
3463         * symtab.c (search_symbols)
3464         (default_collect_symbol_completion_matches_break_on): Use
3465         objfile_msymbols.
3466         * ada-lang.c (ada_lookup_simple_minsym)
3467         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3468         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3469         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3470         objfile_msymbols.
3471         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3472         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3473         * objc-lang.c (find_methods): Use objfile_msymbols.
3474         (info_selectors_command, info_classes_command): Likewise.
3475         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3476         * objfiles.h (class objfile_msymbols): New.
3477         (ALL_OBJFILE_MSYMBOLS): Remove.
3478         (ALL_MSYMBOLS): Remove.
3479
3480 2019-01-09  Tom Tromey  <tom@tromey.com>
3481
3482         * common/next-iterator.h (next_adapter): Add Iterator template
3483         parameter.
3484         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3485         (class all_objfiles_safe): New.
3486         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3487         * objfiles.c (put_objfile_before): Update comment.
3488         (add_separate_debug_objfile): Likewise.
3489         (free_all_objfiles): Use all_objfiles_safe.
3490         (objfile_purge_solibs): Likewise.
3491
3492 2019-01-09  Tom Tromey  <tom@tromey.com>
3493
3494         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3495         (expand_symtab_containing_pc, lookup_static_symbol)
3496         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3497         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3498         all_objfiles.
3499         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3500         * breakpoint.c (create_overlay_event_breakpoint)
3501         (create_longjmp_master_breakpoint)
3502         (create_std_terminate_master_breakpoint)
3503         (create_exception_master_breakpoint): Use all_objfiles.
3504         * linux-thread-db.c (try_thread_db_load_from_pdir)
3505         (has_libpthread): Use all_objfiles.
3506         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3507         * linespec.c (iterate_over_all_matching_symtabs)
3508         (search_minsyms_for_name): Use all_objfiles.
3509         * maint.c (maintenance_info_sections): Use all_objfiles.
3510         * main.c (captured_main_1): Use all_objfiles.
3511         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3512         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3513         * guile/scm-pretty-print.c
3514         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3515         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3516         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3517         (maintenance_print_msymbols): Use all_objfiles.
3518         * source.c (select_source_symtab): Use all_objfiles.
3519         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3520         * symfile.c (remove_symbol_file_command)
3521         (expand_symtabs_matching, map_symbol_filenames): Use
3522         all_objfiles.
3523         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3524         all_objfiles.
3525         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3526         * objc-lang.c (find_methods): Use all_objfiles.
3527         * objfiles.c (have_partial_symbols, have_full_symbols)
3528         (have_minimal_symbols, qsort_cmp)
3529         (default_iterate_over_objfiles_in_search_order): Use
3530         all_objfiles.
3531         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3532         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3533         (maintenance_check_psymtabs): Use all_objfiles.
3534         (ALL_PSYMTABS): Remove.
3535         * compile/compile-object-run.c (do_module_cleanup): Use
3536         all_objfiles.
3537         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3538         * cp-support.c (add_symbol_overload_list_qualified): Use
3539         all_objfiles.
3540         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3541         Use all_objfiles.
3542         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3543         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3544         all_objfiles.
3545         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3546         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3547         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3548         Uses all_objfiles.
3549         * solib.c (solib_read_symbols): Use all_objfiles
3550
3551 2019-01-09  Tom Tromey  <tom@tromey.com>
3552
3553         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3554         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3555         all_objfiles.
3556         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3557         * symmisc.c (print_symbol_bcache_statistics)
3558         (print_objfile_statistics, maintenance_print_objfiles)
3559         (maintenance_info_symtabs, maintenance_check_symtabs)
3560         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3561         all_objfiles.
3562         * source.c (forget_cached_source_info): Use all_objfiles.
3563         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3564         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3565         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3566         * objfiles.c (update_section_map): Use all_objfiles.
3567         (shared_objfile_contains_address_p): Likewise.
3568         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3569         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3570
3571 2019-01-09  Tom Tromey  <tom@tromey.com>
3572
3573         * common/next-iterator.h: New file.
3574         * objfiles.h (class all_objfiles): New.
3575         (struct objfile_iterator): New.
3576
3577 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3578
3579         * NEWS: Move the description of the changed "frame", "select-frame",
3580          and "info frame" commands to the Changed commands section.
3581
3582 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3583
3584         * gdbtypes.c (check_stub_method_group): Remove handling of old
3585         mangling schemes.
3586         * linespec.c (find_methods): Likewise.
3587         * stabsread.c (read_member_functions): Likewise.
3588         * valops.c (search_struct_method): Likewise.
3589         (value_struct_elt_for_reference): Likewise.
3590         * NEWS: Mention this change.
3591
3592 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3593
3594         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3595         print_source_lines.
3596         * source.c (print_source_lines_base): Update line number check.
3597         (print_source_lines): New function.
3598         (source_lines_range::source_lines_range): New function.
3599         * source.h (class source_lines_range): New class.
3600         (print_source_lines): New declaration.
3601
3602 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3603
3604         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3605
3606 2019-01-08  Tom Tromey  <tom@tromey.com>
3607             Simon Marchi  <simon.marchi@ericsson.com>
3608
3609         PR gdb/24060
3610         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3611         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3612         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3613         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3614         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3615         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3616
3617 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3618
3619         * source.c (select_source_symtab): Move header comment to
3620         declaration in source.h.
3621         (forget_cached_source_info_for_objfile): Likewise.
3622         (forget_cached_source_info): Likewise.
3623         (identify_source_line): Likewise.
3624         * source.h (identify_source_line): Move declaration from symtab.h
3625         and add comment from source.c
3626         (print_source_lines): Likewise.
3627         (forget_cached_source_info_for_objfile): Likewise.
3628         (forget_cached_source_info): Likewise.
3629         (select_source_symtab): Likewise.
3630         (enum print_source_lines_flag): Move definition from symtab.h.
3631         * symtab.h (identify_source_line): Move declaration to source.h.
3632         (print_source_lines): Likewise.
3633         (forget_cached_source_info_for_objfile): Likewise.
3634         (forget_cached_source_info): Likewise.
3635         (select_source_symtab): Likewise.
3636         (enum print_source_lines_flag): Move definition to source.h.
3637         * tui/tui-hooks.c: Add 'source.h' include.
3638
3639 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3640
3641         * source.c (print_source_lines_base): Handle requests to print
3642         reverse line number sequences, and guard against empty lines
3643         string.
3644
3645 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3646
3647         * source.c (print_source_lines_base): Fix skip of '\r' if next
3648         character is '\n'.
3649
3650 2019-01-06  Tom Tromey  <tom@tromey.com>
3651
3652         * c-exp.y (struct c_parse_state) <macro_original_text,
3653         expansion_obstack>: New member.
3654         (macro_original_text, expansion_obstack): Remove globals.
3655         (scan_macro_expansion, scanning_macro_expansion)
3656         (finished_macro_expansion): Update.
3657         (scan_macro_cleanup): Remove.
3658         (yylex, c_parse): Update.
3659
3660 2019-01-06  Tom Tromey  <tom@tromey.com>
3661
3662         * c-exp.y (struct c_parse_state) <strings>: New member.
3663         (operator_stoken): Update.
3664
3665 2019-01-06  Tom Tromey  <tom@tromey.com>
3666
3667         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3668         (union type_stack_elt) <typelist_val>: Now a pointer to
3669         std::vector.
3670         (type_stack_cleanup): Don't declare.
3671         (push_typelist): Update.
3672         * parse.c (pop_typelist): Return a std::vector.
3673         (push_typelist): Take a std::vector.
3674         (follow_types): Update.  Do not free args.
3675         (type_stack_cleanup): Remove.
3676         * c-exp.y (struct c_parse_state): New.
3677         (cpstate): New global.
3678         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3679         (nonempty_typelist): Update.
3680         (func_mod): Create a new vector.
3681         (c_parse): Create a c_parse_state.
3682         (check_parameter_typelist): Do not delete params.
3683         (function_method): Update.  Do not delete type_list.
3684
3685 2019-01-06  Tom Tromey  <tom@tromey.com>
3686
3687         PR gdb/28155:
3688         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3689         check_typedef.
3690         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3691         (print_return_value): Likewise.
3692
3693 2019-01-05  Tom Tromey  <tom@tromey.com>
3694
3695         * contrib/cleanup_check.py: Remove.
3696         * contrib/gcc-with-excheck: Remove.
3697         * contrib/exsummary.py: Remove.
3698         * contrib/excheck.py: Remove.
3699
3700 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3701
3702         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3703         NULL. Initialize tpprev to NULL instead of assigning it
3704         to NULL on the next statement.
3705         * windows-nat.c (windows_delete_thread): Remove check for
3706         main_thread_id before printing thread exit notifications.
3707         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3708         Remove thread ID check against main_thread_id.
3709         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3710         windows_delete_thread.
3711         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3712
3713 2019-01-04  Tom Tromey  <tom@tromey.com>
3714
3715         * compile/compile.c (_initialize_compile): Use upper case for
3716         metasyntactic variables.
3717         * symmisc.c (_initialize_symmisc): Use upper case for
3718         metasyntactic variables.
3719         * psymtab.c (_initialize_psymtab): Use upper case for
3720         metasyntactic variables.
3721         * demangle.c (demangle_command): Use upper case for metasyntactic
3722         variables.
3723         (_initialize_demangler): Likewise.
3724         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3725         variables.
3726
3727 2019-01-03  Tom Tromey  <tom@tromey.com>
3728
3729         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3730
3731 2019-01-03  Tom Tromey  <tom@tromey.com>
3732
3733         * python/py-symtab.c (salpy_str): Update.
3734         (struct salpy_sal_object) <symtab>: Now a PyObject.
3735         (salpy_dealloc): Update.
3736         (del_objfile_sal): Use gdbpy_ref.
3737
3738 2019-01-03  Tom Tromey  <tom@tromey.com>
3739
3740         * python/py-type.c (convert_field): Use new_reference.  Return
3741         gdbpy_ref.
3742         (make_fielditem): Return gdbpy_ref.
3743         (typy_fields): Update.
3744         (typy_getitem): Update.
3745         (field_name): Return gdbpy_ref.  Use new_reference.
3746         (typy_iterator_iternext): Update.
3747
3748 2019-01-03  Tom Tromey  <tom@tromey.com>
3749
3750         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3751
3752 2019-01-03  Tom Tromey  <tom@tromey.com>
3753
3754         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3755         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3756         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3757         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3758         (pspy_set_type_printers): Likewise.
3759         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3760         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3761         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3762         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3763         (objfpy_set_type_printers): Likewise.
3764
3765 2019-01-03  Tom Tromey  <tom@tromey.com>
3766
3767         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3768         (gdbpy_print_stack): Use gdbpy_err_fetch.
3769         * python/python-internal.h (class gdbpy_err_fetch): New class.
3770         (class gdbpy_enter) <m_error_type, m_error_value,
3771         m_error_traceback>: Remove.
3772         <m_error>: New member.
3773         (gdbpy_exception_to_string): Don't declare.
3774         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3775         * python/py-value.c (convert_value_from_python): Use
3776         gdbpy_err_fetch.
3777         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3778         gdbpy_exception_to_string.
3779         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3780         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3781         gdbpy_err_fetch.
3782
3783 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3784
3785         * linux-nat.c (delete_lwp_cleanup): Delete.
3786         (struct lwp_deleter): New struct.
3787         (lwp_info_up): New typedef.
3788         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3789         lwp_info_up.
3790
3791 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3792
3793         * linux-fork.c (class scoped_switch_fork_info): New class.
3794         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3795
3796 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3797
3798         * valops.c (find_overload_match): Remove use of null_cleanup, and
3799         calls to do_cleanups.
3800
3801 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3802
3803         * compile/compile-cplus-types.c
3804         (compile_cplus_instance::decl_name): Handle changes to
3805         cp_func_name.
3806         * cp-support.c (cp_func_name): Update header comment, update
3807         return type.
3808         * cp-support.h (cp_func_name): Update return type in declaration.
3809         * valops.c (find_overload_match): Move temp_func local to top
3810         level of function and change its type.  Use temp_func to hold and
3811         delete temporary string obtained from cp_func_name.
3812
3813 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3814
3815         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3816         gdb::char_vector, remove cleanup, and update uses of `msg`.
3817
3818 2019-01-03  Jim Wilson  <jimw@sifive.com>
3819
3820         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3821
3822 2019-01-02  Tom Tromey  <tom@tromey.com>
3823
3824         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3825         (tdesc_parse_xml): Remove cleanups.
3826         * target-descriptions.h (make_cleanup_free_target_description):
3827         Don't declare.
3828         (target_desc_deleter): New struct.
3829         (target_desc_up): New typedef.
3830         * target-descriptions.c (target_desc_deleter::operator()): Rename
3831         from free_target_description.
3832         (make_cleanup_free_target_description): Remove.
3833
3834 2019-01-02  Tom Tromey  <tom@tromey.com>
3835
3836         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3837         constructor, destructor.
3838         (linespec_parser): Remove typedef.
3839         (~linespec_parser): Rename from linespec_parser_delete.
3840         (linespec_lex_to_end, linespec_complete_label)
3841         (linespec_complete): Update.
3842         (decode_line_full): Remove cleanups.
3843         (decode_line_1): Update.
3844
3845 2019-01-02  Tom Tromey  <tom@tromey.com>
3846
3847         * python/python-internal.h (inferior_to_inferior_object): Change
3848         return type.
3849         * python/py-exitedevent.c (create_exited_event_object): Update.
3850         * python/py-inferior.c (inferior_to_inferior_object): Return
3851         gdbpy_ref.
3852         (python_new_inferior, python_inferior_deleted)
3853         (thread_to_thread_object, delete_thread_object)
3854         (build_inferior_list, gdbpy_selected_inferior): Update.
3855         * python/py-infthread.c (create_thread_object): Update.  Also fail
3856         if inferior_to_inferior_object fails.
3857
3858 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3859
3860         * inferior.h (class inferior) <displaced_step_state>: New field.
3861         * infrun.h (struct displaced_step_state): Move here from
3862         infrun.c.  Initialize fields, add constructor.
3863         <inf>: Remove field.
3864         <reset>: New method.
3865         * infrun.c (struct displaced_step_inferior_state): Move to
3866         infrun.h.
3867         (displaced_step_inferior_states): Remove.
3868         (get_displaced_stepping_state): Adust.
3869         (displaced_step_in_progress_any_inferior): Adjust.
3870         (displaced_step_in_progress_thread): Adjust.
3871         (displaced_step_in_progress): Adjust.
3872         (add_displaced_stepping_state): Remove.
3873         (get_displaced_step_closure_by_addr): Adjust.
3874         (remove_displaced_stepping_state): Remove.
3875         (infrun_inferior_exit): Call displaced_step_state.reset.
3876         (use_displaced_stepping): Don't check for NULL.
3877         (displaced_step_prepare_throw): Call
3878         get_displaced_stepping_state.
3879         (displaced_step_fixup): Don't check for NULL.
3880         (prepare_for_detach): Don't check for NULL.
3881
3882 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3883
3884         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3885          in case of call that did not complete.
3886
3887 2019-01-02  Andrey Utkin  <autkin@undo.io>
3888
3889         * symfile.c (find_separate_debug_file): Fix search of debug files for
3890         remote debuggee.
3891
3892 2019-01-02  Tom Tromey  <tom@tromey.com>
3893
3894         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3895         indentation.
3896         * python/py-frame.c (frapy_older): Remove cast.
3897         (frapy_newer): Likewise.
3898         * python/py-breakpoint.c (local_setattro): Remove cast.
3899         * python/py-arch.c (archpy_name): Remove local variable.
3900         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3901
3902 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3903
3904         * unittests/basic_string_view/element_access/char/empty.cc:
3905         Fix year range in copyright header.
3906
3907 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3908
3909         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3910         Delete.
3911         <operator==>: Update with for removed field.
3912         <hash>: Likewise.
3913         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3914         <isa_features>: ...this.
3915         <abi_features>: New field.
3916         (riscv_isa_flen): Update comment.
3917         (riscv_abi_xlen): New declaration.
3918         (riscv_abi_flen): New declaration.
3919         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3920         isa_features.
3921         (riscv_abi_xlen): New function.
3922         (riscv_isa_flen): Update to get answer from isa_features.
3923         (riscv_abi_flen): New function.
3924         (riscv_has_fp_abi): Update to get answer from abi_features.
3925         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3926         xlen and flen.
3927         (riscv_call_info) <xlen, flen>: Update comment.
3928         (riscv_call_arg_struct): Remove invalid assertions
3929         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3930         is removed.
3931         (riscv_gdbarch_init): Gather isa features and abi features
3932         separately, ensure both match on the gdbarch when reusing an old
3933         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3934         a target with 64-bit float hardware.
3935
3936 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3937
3938         * source.c (search_command_helper): Stop reverse search
3939         when line 1 has been searched.
3940
3941 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3942
3943         * record-full.c (record_full_base_target::close): Rewrite
3944         record_full_core_buf_list free logic.
3945
3946 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3947
3948         * break-catch-syscall.c (print_one_catch_syscall): xfree
3949         the last text.
3950
3951 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3952
3953         * top.c (print_gdb_version): Update Copyright year in version
3954         message.
3955
3956 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3957
3958         Update copyright year range in all GDB files.
3959
3960 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
3961
3962         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
3963
3964 For older changes see ChangeLog-2018.
3965 \f
3966 Local Variables:
3967 mode: change-log
3968 left-margin: 8
3969 fill-column: 74
3970 version-control: never
3971 coding: utf-8
3972 End:
3973