gdb/ChangeLog

   1 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
   2
   3         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
   4         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
   5         NULL, and complain/return if that's the case.
   6
   7 2019-05-15  John Darrington <john@darrington.wattle.id.au>
   8
   9         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
  10         (advance, posn, abstract_read_memory): New functions.
  11         [struct mem_read_abstraction]: New struct.
  12         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
  13
  14 2019-05-14  Tom Tromey  <tromey@adacore.com>
  15
  16         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
  17         value is not lval_memory.
  18
  19 2019-05-14  Tom Tromey  <tromey@adacore.com>
  20
  21         * solib.c (info_sharedlibrary_command): Style the file name.
  22
  23 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
  24
  25         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
  26         (aarch64_vnv_type): Likewise.
  27         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
  28         * common/tdesc.c: Likewise.
  29         * common/tdesc.h (enum tdesc_type_kind): Likewise.
  30         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
  31         * features/aarch64-fpu.xml: Add ieee half view.
  32         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
  33         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
  34         * gdbtypes.h (struct builtin_type): Likewise.
  35         (struct objfile_type): Likewise.
  36
  37 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
  38
  39         * language.c (language_sniff_from_mangled_name): Fix "langauge"
  40         typo.
  41         * location.h (string_to_event_location): Likewise.
  42
  43 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
  44
  45         GDB 8.3 released.
  46
  47 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
  48
  49         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
  50         New variable declaration.
  51         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
  52         New variable.
  53         (print_one_breakpoint): Use ui_out::test_flags and new global
  54         variable to compute use_fixed_output.
  55         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
  56         Remove.
  57         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
  58         (mi_multi_location_breakpoint_output_fixed): Remove.
  59         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
  60         new variable.
  61         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
  62         fix_multi_location_breakpoint_output flag if version >= 3.
  63         * ui-out.h (enum ui_out_flag)
  64         <fix_multi_location_breakpoint_output>: New enumerator.
  65
  66 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
  67
  68         * contrib/cc-with-tweaks.sh: Validate dwz's work.
  69
  70 2019-05-10  Tom Tromey  <tromey@adacore.com>
  71
  72         * ada-lang.c (catch_ada_completer): New function.
  73         (_initialize_ada_language): Use it.
  74
  75 2019-05-10  Tom Tromey  <tromey@adacore.com>
  76
  77         * thread.c (print_thread_info): Make "requested_threads" const.
  78         * gdbthread.h (print_thread_info): Make "requested_threads"
  79         const.
  80         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
  81         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
  82
  83 2019-05-08  Tom Tromey  <tom@tromey.com>
  84
  85         * gdbtypes.c (objfile_type_data): Change type.
  86         (objfile_type, _initialize_gdbtypes): Update.
  87
  88 2019-05-08  Tom Tromey  <tom@tromey.com>
  89
  90         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
  91         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
  92         (_initialize_dwarf2_frame): Update.
  93
  94 2019-05-08  Tom Tromey  <tom@tromey.com>
  95
  96         * objc-lang.c (objc_objfile_data): Change type.
  97         (find_methods): Update.
  98         (_initialize_objc_lang): Remove.
  99
 100 2019-05-08  Tom Tromey  <tom@tromey.com>
 101
 102         * stabsread.c (rs6000_builtin_type_data): Change type.
 103         (rs6000_builtin_type, _initialize_stabsread): Update.
 104
 105 2019-05-08  Tom Tromey  <tom@tromey.com>
 106
 107         * mips-tdep.c (mips_pdr_data): Remove.
 108         (_initialize_mips_tdep): Update.
 109
 110 2019-05-08  Tom Tromey  <tom@tromey.com>
 111
 112         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
 113         (hppa_init_objfile_priv_data, read_unwind_info)
 114         (find_unwind_entry, _initialize_hppa_tdep): Update.
 115
 116 2019-05-08  Tom Tromey  <tom@tromey.com>
 117
 118         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
 119         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
 120         on obstack.
 121         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
 122
 123 2019-05-08  Tom Tromey  <tom@tromey.com>
 124
 125         * mdebugread.c (basic_type_data): Change type.
 126         (basic_type, _initialize_mdebugread): Update.
 127
 128 2019-05-08  Tom Tromey  <tom@tromey.com>
 129
 130         * common/gdb_unique_ptr.h (struct noop_deleter): New.
 131
 132 2019-05-08  Tom Tromey  <tom@tromey.com>
 133
 134         * nto-tdep.c (nto_inferior_data_reg): Change type.
 135         (nto_inferior_data): Update.
 136         (nto_inferior_data_cleanup, nto_new_inferior_data)
 137         (_initialize_nto_tdep): Remove.
 138         * nto-tdep.h (struct nto_inferior_data): Add initializers.
 139
 140 2019-05-08  Tom Tromey  <tom@tromey.com>
 141
 142         * ada-lang.c (struct ada_inferior_data): Add initializers.
 143         (ada_inferior_data): Change type.
 144         (ada_inferior_data_cleanup): Remove.
 145         (get_ada_inferior_data, ada_inferior_exit)
 146         (struct ada_pspace_data): Add initializers, destructor.
 147         (ada_pspace_data_handle): Change type.
 148         (get_ada_pspace_data): Update.
 149         (ada_pspace_data_cleanup): Remove.
 150
 151 2019-05-08  Tom Tromey  <tom@tromey.com>
 152
 153         * coffread.c (struct coff_symfile_info): Add initializers.
 154         (coff_objfile_data_key): Move lower.  Change type.
 155         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
 156         Update.
 157         (coff_free_info): Remove.
 158
 159 2019-05-08  Tom Tromey  <tom@tromey.com>
 160
 161         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
 162         (fbsd_pspace_data_handle): Move lower.  Change type.
 163         (get_fbsd_pspace_data): Update.
 164         (fbsd_pspace_data_cleanup): Remove.
 165         (_initialize_fbsd_tdep): Update.
 166
 167 2019-05-08  Tom Tromey  <tom@tromey.com>
 168
 169         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
 170         (get_ada_tasks_pspace_data): Update.
 171         (ada_tasks_pspace_data_cleanup): Remove.
 172         (_initialize_tasks): Update.
 173         (ada_tasks_inferior_data_handle): Change type.
 174         (get_ada_tasks_inferior_data): Update.
 175         (ada_tasks_inferior_data_cleanup): Remove.
 176         (struct ada_tasks_pspace_data): Add initializers.
 177
 178 2019-05-08  Tom Tromey  <tom@tromey.com>
 179
 180         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
 181         * symfile-debug.c (debug_sym_get_probes): Change type.
 182         * stap-probe.c (handle_stap_probe):
 183         (stap_static_probe_ops::get_probes): Change type.
 184         * probe.h (class static_probe_ops) <get_probes>: Change type.
 185         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
 186         (parse_probes_in_pspace): Update.
 187         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
 188         Update.
 189         (any_static_probe_ops::get_probes): Change type.
 190         * elfread.c (elfread_data): New typedef.
 191         (probe_key): Change type.
 192         (elf_get_probes): Likewise.  Update.
 193         (probe_key_free): Remove.
 194         (_initialize_elfread): Update.
 195         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
 196         Change type.
 197         (dtrace_process_dof_probe, dtrace_process_dof)
 198         (dtrace_static_probe_ops::get_probe): Change type.
 199
 200 2019-05-08  Tom Tromey  <tom@tromey.com>
 201
 202         * xcoffread.c (struct xcoff_symfile_info): Rename from
 203         coff_symfile_info.  Add initializers.
 204         (xcoff_objfile_data_key): Move lower.  Change type.
 205         (XCOFF_DATA): Rewrite.
 206         (xcoff_free_info): Remove.
 207         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
 208         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
 209         (xcoff_initial_scan): Update.
 210
 211 2019-05-08  Tom Tromey  <tom@tromey.com>
 212
 213         * solib-svr4.c (struct svr4_info): Add initializers and
 214         destructor.
 215         <probes_table>: Now an htab_up.
 216         (solib_svr4_pspace_data): Change type.
 217         (free_probes_table): Simplify.
 218         (~svr4_info): Rename from svr4_pspace_data_cleanup.
 219         (get_svr4_info, probes_table_htab_remove_objfile_probes)
 220         (probes_table_remove_objfile_probes, register_solib_event_probe)
 221         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
 222         (_initialize_svr4_solib): Update.
 223
 224 2019-05-08  Tom Tromey  <tom@tromey.com>
 225
 226         * remote.c (remote_pspace_data): Change type.
 227         (remote_pspace_data_cleanup): Remove.
 228         (get_remote_exec_file, set_pspace_remote_exec_file)
 229         (_initialize_remote): Update.
 230
 231 2019-05-08  Tom Tromey  <tom@tromey.com>
 232
 233         * breakpoint.c (breakpoint_objfile_key): Change type.
 234         (get_breakpoint_objfile_data): Update.
 235         (free_breakpoint_objfile_data): Remove.
 236         (_initialize_breakpoint): Update.
 237
 238 2019-05-08  Tom Tromey  <tom@tromey.com>
 239
 240         * linux-tdep.c (struct linux_info): Add initializers.
 241         (linux_inferior_data): Move.  Change type.
 242         (invalidate_linux_cache_inf): Update.
 243         (linux_inferior_data_cleanup): Remove.
 244         (get_linux_inferior_data, _initialize_linux_tdep): Update.
 245
 246 2019-05-08  Tom Tromey  <tom@tromey.com>
 247
 248         * auxv.c (auxv_inferior_data): Move.  Change type.
 249         (auxv_inferior_data_cleanup): Remove.
 250         (invalidate_auxv_cache_inf): Rewrite.
 251         (get_auxv_inferior_data, _initialize_auxv): Update.
 252
 253 2019-05-08  Tom Tromey  <tom@tromey.com>
 254
 255         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
 256         (symfile_debug_objfile_data_key): Change type.
 257         (symfile_debug_installed, debug_qf_has_symbols)
 258         (debug_qf_find_last_source_symtab)
 259         (debug_qf_forget_cached_source_info)
 260         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
 261         (debug_qf_print_stats, debug_qf_dump)
 262         (debug_qf_expand_symtabs_for_function)
 263         (debug_qf_expand_all_symtabs)
 264         (debug_qf_expand_symtabs_with_fullname)
 265         (debug_qf_map_matching_symbols)
 266         (debug_qf_expand_symtabs_matching)
 267         (debug_qf_find_pc_sect_compunit_symtab)
 268         (debug_qf_map_symbol_filenames)
 269         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
 270         (debug_sym_new_init, debug_sym_init, debug_sym_read)
 271         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
 272         (debug_sym_read_linetable, debug_sym_relocate): Update.
 273         (symfile_debug_free_objfile): Remove.
 274         (install_symfile_debug_logging, _initialize_symfile_debug):
 275         Update.
 276
 277 2019-05-08  Tom Tromey  <tom@tromey.com>
 278
 279         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
 280         allocate_on_obstack.
 281         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
 282         (get_dwarf2_per_objfile): Update.
 283         (set_dwarf2_per_objfile): Remove.
 284         (dwarf2_has_info, dwarf2_get_section_info): Update.
 285         (dwarf2_free_objfile): Remove.
 286         (_initialize_dwarf2_read): Update.
 287
 288 2019-05-08  Tom Tromey  <tom@tromey.com>
 289
 290         * auto-load.c (struct auto_load_pspace_info): Add destructor and
 291         initializers.
 292         <unsupported_script_warning_printed,
 293         script_not_found_warning_printed>: Now bool.
 294         (auto_load_pspace_data): Change type.
 295         (~auto_load_pspace_info): Rename from
 296         auto_load_pspace_data_cleanup.
 297         (get_auto_load_pspace_data, init_loaded_scripts_info)
 298         (clear_section_scripts, maybe_print_unsupported_script_warning)
 299         (maybe_print_script_not_found_warning, _initialize_auto_load):
 300         Update.
 301
 302 2019-05-08  Tom Tromey  <tom@tromey.com>
 303
 304         * objfiles.c (objfile_pspace_info): Add destructor and
 305         initializers.
 306         (objfiles_pspace_data): Change type.
 307         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
 308         (get_objfile_pspace_data): Update.
 309         (objfiles_bfd_data): Change type.
 310         (get_objfile_bfd_data): Update.
 311         (objfile_bfd_data_free, _initialize_objfiles): Remove.
 312
 313 2019-05-08  Tom Tromey  <tom@tromey.com>
 314
 315         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
 316         Change type.
 317         (get_catch_syscall_inferior_data): Update.
 318         (catch_syscall_inferior_data_cleanup): Remove.
 319         (_initialize_break_catch_syscall): Update.
 320
 321 2019-05-08  Tom Tromey  <tom@tromey.com>
 322
 323         * inflow.c (struct terminal_info): Add destructor and
 324         initializers.
 325         (inflow_inferior_data): Change type.
 326         (~terminal_info): Rename from inflow_inferior_data_cleanup.
 327         (get_inflow_inferior_data, inflow_inferior_exit)
 328         (swap_terminal_info, _initialize_inflow): Update.
 329
 330 2019-05-08  Tom Tromey  <tom@tromey.com>
 331
 332         * target-dcache.c (target_dcache_cleanup): Remove.
 333         (target_dcache_aspace_key): Change type.
 334         (target_dcache_init_p, target_dcache_invalidate)
 335         (target_dcache_get, target_dcache_get_or_init)
 336         (_initialize_target_dcache): Update.
 337         * dcache.h (struct dcache_deleter): New.
 338
 339 2019-05-08  Tom Tromey  <tom@tromey.com>
 340
 341         * symtab.c (struct symbol_cache): Add destructor and
 342         initializers.
 343         (symbol_cache_key): Move.  Change type.
 344         (make_symbol_cache, free_symbol_cache): Remove.
 345         (get_symbol_cache): Update.
 346         (symbol_cache_cleanup): Remove.
 347         (ALL_PSPACES, symbol_cache_flush)
 348         (maintenance_print_symbol_cache)
 349         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
 350         Update.
 351
 352 2019-05-08  Tom Tromey  <tom@tromey.com>
 353
 354         * symtab.c (struct main_info): Add destructor and initializers.
 355         (main_progspace_key): Move.  Change type.
 356         (get_main_info): Update.
 357         (main_info_cleanup): Remove.
 358         (_initialize_symtab): Update.
 359
 360 2019-05-08  Tom Tromey  <tom@tromey.com>
 361
 362         * registry.h (DECLARE_REGISTRY): Define the _key class.
 363
 364 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 365
 366         * NEWS: Merge two 'New commands' sections.
 367
 368 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 369
 370         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 371         parameter and use Ada language definition instead.
 372         (ada_val_print_ptr): Remove unused language parameter.
 373         (ada_val_print_num): Remove language parameter and use Ada language
 374         definition instead.
 375         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 376         parameter.
 377         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 378         parameter and use Ada language definition instead.
 379         (ada_val_print_1): Update all ada_val_print_xxx calls.
 380         Remove language parameter.
 381         (ada_val_print): Update ada_val_print_1 call.
 382
 383 2019-05-08  Tom Tromey  <tromey@adacore.com>
 384
 385         * remote.c (remote_hw_watchpoint_limit)
 386         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 387         Now static.
 388
 389 2019-05-08  Tom Tromey  <tromey@adacore.com>
 390
 391         * maint.c (_initialize_maint_cmds): Move initialization code to
 392         remote.c.
 393         (watchdog, show_watchdog): Move to remote.c.
 394         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 395         "watchdog" static.
 396         (_initialize_remote): Move initialization code from maint.c.
 397         * defs.h (watchdog): Don't declare.
 398
 399 2019-05-08  Tom Tromey  <tromey@adacore.com>
 400
 401         * tui/tui-interp.c: Include main.h.
 402         * interps.c: Include main.h.
 403         * main.h (interpreter_p): Declare.
 404         * defs.h (interpreter_p): Don't declare.
 405
 406 2019-05-08  Tom Tromey  <tromey@adacore.com>
 407
 408         * dwarf2loc.c: Include dwarf2read.h.
 409         * defs.h (read_unsigned_leb128): Don't declare.
 410         * dwarf2read.h (read_unsigned_leb128): Declare.
 411
 412 2019-05-08  Tom Tromey  <tromey@adacore.com>
 413
 414         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 415         method.
 416
 417 2019-05-08  Tom Tromey  <tromey@adacore.com>
 418
 419         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 420         when no wrap column is set.
 421
 422 2019-05-08  Tom Tromey  <tromey@adacore.com>
 423
 424         * c-lang.c (c_get_string): Handle non-C-style arrays.
 425
 426 2019-05-08  Tom Tromey  <tromey@adacore.com>
 427
 428         * typeprint.c (print_offset_data::update): Print the bit offset,
 429         not the number of bits remaining.
 430
 431 2019-05-08  Tom Tromey  <tromey@adacore.com>
 432
 433         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 434         padding at end of comment.
 435
 436 2019-05-08  Tom Tromey  <tromey@adacore.com>
 437
 438         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 439         Compare main types.
 440
 441 2019-05-06  Tom Tromey  <tom@tromey.com>
 442
 443         * common/scoped_mmap.c: Include common-defs.h.
 444         * common/scoped_mmap.h: Don't include config.h.
 445
 446 2019-05-04  Tom Tromey  <tom@tromey.com>
 447
 448         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 449         (struct aarch64_call_info): Add initializers.
 450         <si>: Now a std::vector.
 451         (pass_on_stack, aarch64_push_dummy_call): Update.
 452
 453 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 454             Tom Tromey  <tom@tromey.com>
 455
 456         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 457         (ppc_threads): Now a std::vector.  Now static.
 458         (hwdebug_find_thread_points_by_tid)
 459         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 460         Update.
 461
 462 2019-05-04  Tom Tromey  <tom@tromey.com>
 463
 464         * arc-tdep.c (arc_tdesc_init): Return bool.
 465
 466 2019-05-04  Tom Tromey  <tom@tromey.com>
 467
 468         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 469         Use gdb_assert_not_reached.
 470
 471 2019-05-04  Tom Tromey  <tom@tromey.com>
 472
 473         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 474         "false".
 475
 476 2019-05-04  Tom Tromey  <tom@tromey.com>
 477
 478         * arc-tdep.c (arc_tdesc_init): Use bool.
 479
 480 2019-05-04  Tom Tromey  <tom@tromey.com>
 481
 482         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 483
 484 2019-05-04  Tom Tromey  <tom@tromey.com>
 485
 486         * cli/cli-cmds.c (valid_command_p): Return bool.
 487
 488 2019-05-04  Tom Tromey  <tom@tromey.com>
 489
 490         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 491         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 492
 493 2019-05-04  Raul Tambre  <raul@tambre.ee>
 494
 495         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 496         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 497         operator for comparison.
 498
 499 2019-05-04  Tom Tromey  <tom@tromey.com>
 500
 501         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 502         (lookup_partial_symbol, print_partial_symbols)
 503         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 504         (psymbol_compare): Update.
 505         (add_psymbol_to_bcache): Clear the entire psymbol.
 506         (maintenance_check_psymtabs): Update.
 507         * psympriv.h (struct partial_symbol): Don't derive from
 508         general_symbol_info.
 509         <obj_section, unrelocated_address, address,
 510         set_unrelocated_address>: Update.
 511         <ginfo>: New member.
 512         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 513         (debug_names::write_psymbols): Update.
 514
 515 2019-05-04  Tom de Vries  <tdevries@suse.de>
 516
 517         * contrib/cc-with-tweaks.sh: Support -n arg.
 518
 519 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 520
 521         * corelow.c (core_target::detach): Ensure frame cache and
 522         register caches are cleared.
 523         inferior.c (exit_inferior_1): Likewise.
 524
 525 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 526             Tom Tromey  <tom@tromey.com>
 527
 528         * dictionary.c (collate_pending_symbols_by_language): Remove
 529         "struct" from foreach.
 530         * symtab.c (lookup_global_symbol_from_objfile)
 531         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 532         foreach.
 533         * ser-tcp.c (net_open): Remove "struct" from foreach.
 534         * objfiles.c (objfile_relocate, objfile_rebase)
 535         (objfile_has_symbols): Remove "struct" from foreach.
 536         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 537         from foreach.
 538         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 539         foreach.
 540         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 541         "struct" from foreach.
 542         * ada-lang.c (create_excep_cond_exprs)
 543         (ada_exception_catchpoint_cond_string): Remove "struct" from
 544         foreach.
 545
 546 2019-05-03  Tom Tromey  <tromey@adacore.com>
 547
 548         * ada-exp.y (convert_char_literal): Check suffix of each
 549         enumerator.
 550
 551 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 552
 553         PR ada/21406:
 554         * ada-exp.y (yywrap): Don't define.
 555         * ada-lex.l (%option): Add noyywrap
 556         (yywrap): Remove.
 557
 558 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 559
 560         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 561         _WIN32_WINNT to the XP level, unless already defined to a higher
 562         level.
 563
 564         * unittests/parse-connection-spec-selftests.c:
 565         * ser-tcp.c:
 566         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 567         override.
 568
 569         * symfile.c (find_separate_debug_file): Remove colon from the
 570         drive spec of DOS/Windows file names of the target, so that the
 571         file name produced from DEBUGDIR and the target's directory will
 572         be valid on DOS/Windows systems.
 573
 574 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 575
 576         * rust-lang.c (val_print_struct): Handle printing structures
 577         containing strings.
 578
 579 2019-05-02  Tom Tromey  <tromey@adacore.com>
 580
 581         * valarith.c (_initialize_valarith): Remove.
 582
 583 2019-05-01  Tom Tromey  <tromey@adacore.com>
 584
 585         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 586         bitfields.
 587
 588 2019-05-01  Tom Tromey  <tromey@adacore.com>
 589
 590         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 591         for big-endian copies.
 592
 593 2019-04-30  Ali Tamur  <tamur@google.com>
 594         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 595         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 596         (read_3_bytes): New function.
 597
 598 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 599
 600         * windows-nat.c (main_thread_id): Delete.
 601         (handle_output_debug_string): Replace main_thread_id by
 602         current_event.dwThreadId.
 603         (fake_create_process): Likewise.
 604         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 605         Do not set main_thread_id.
 606         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 607         current_event.dwThreadId.
 608         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 609
 610 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 611
 612         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 613         Use current_event.dwThreadId instead of main_thread_id.
 614
 615 2019-04-30  Tom Tromey  <tromey@adacore.com>
 616
 617         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 618         (create_excep_cond_exprs): Iterate over program spaces.
 619         (ada_exception_catchpoint_cond_string): Examine all minimal
 620         symbols for exception types.
 621
 622 2019-04-30  Tom Tromey  <tromey@adacore.com>
 623
 624         PR c++/24470:
 625         * dwarf2read.c (process_structure_scope): Handle case where type
 626         has template parameters but no symbol was created.
 627
 628 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 629             Chris January  <chris.january@arm.com>
 630
 631         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 632         qualifier.
 633         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 634
 635 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 636
 637         * f-typeprint.c (f_print_type): Update rules for printing
 638         whitespace.
 639         (f_type_print_varspec_suffix): Likewise.
 640
 641 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 642             Chris January  <chris.january@arm.com>
 643
 644         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 645         function arguments.
 646
 647 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 648
 649         * f-lang.c (build_fortran_types): Change name of void type to
 650         lower case.
 651         * f-typeprint.c (f_type_print_base): Print the name of the void
 652         type, rather than a fixed string.
 653         * f-valprint.c (f_decorations): Use lower case void string.
 654
 655 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 656             Chris January  <chris.january@arm.com>
 657
 658         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 659         types for Fortran.
 660
 661 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 662             Chris January  <chris.january@arm.com>
 663             David Lecomber  <david.lecomber@arm.com>
 664
 665         * f-exp.y (BINOP_INTRINSIC): New token.
 666         (exp): New parser rule handling BINOP_INTRINSIC.
 667         (f77_keywords): Add new builtin procedures.
 668         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 669         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 670         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 671         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 672         (print_unop_subexp_f): New function.
 673         (print_binop_subexp_f): New function.
 674         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 675         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 676         (dump_subexp_body_f): Likewise.
 677         (operator_check_f): Likewise.
 678         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 679         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 680
 681 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 682
 683         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 684         UNOP_KIND.
 685         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 686         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 687         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 688         (operator_length_f): New fuction.
 689         (print_subexp_f): New function.
 690         (op_name_f): New function.
 691         (dump_subexp_body_f): New function.
 692         (operator_check_f): New function.
 693         (exp_descriptor_f): Replace standard expression handling functions
 694         with new functions.
 695         * gdb/fortran-operator.def: New file.
 696         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 697         * gdb/std-operator.def: Remove UNOP_KIND.
 698
 699 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 700
 701         * std-operator.def: Remove unbalanced, stray double quote
 702         character.
 703
 704 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 705             Chris January  <chris.january@arm.com>
 706             Daniel Everett  <daniel.everett@arm.com>
 707             Nick Forrington  <nick.forrington@arm.com>
 708             Richard Bunt  <richard.bunt@arm.com>
 709
 710         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 711         of depth when printing anonymous structs or unions.
 712         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 713         Don't print either the top-level value, or the children if the
 714         max-depth is exceeded.
 715         (ppscm_print_children): When printing the key of a map, allow one
 716         extra level of depth.
 717         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 718         print either the top-level value, or the children if the max-depth
 719         is exceeded.
 720         (print_children): When printing the key of a map, allow one extra
 721         level of depth.
 722         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 723         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 724         (user_print_options): Initialise max_depth field.
 725         (val_print_scalar_or_string_type_p): New function.
 726         (val_print): Check to see if the max depth has been reached.
 727         (val_print_check_max_depth): Define new function.
 728         (show_print_max_depth): New function.
 729         (_initialize_valprint): Add 'print max-depth' option.
 730         * valprint.h (struct value_print_options) <max_depth>: New field.
 731         (val_print_check_max_depth): Declare new function.
 732         * NEWS: Document new feature.
 733
 734 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 735
 736         * ada-lang.c (ada_language_defn): Initialise new field.
 737         * c-lang.c (c_is_string_type_p): New function.
 738         (c_language_defn): Initialise new field.
 739         (cplus_language_defn): Initialise new field.
 740         (asm_language_defn): Initialise new field.
 741         (minimal_language_defn): Initialise new field.
 742         * c-lang.h (c_is_string_type_p): Declare new function.
 743         * d-lang.c (d_language_defn): Initialise new field.
 744         * f-lang.c (f_is_string_type_p): New function.
 745         (f_language_defn): Initialise new field.
 746         * go-lang.c (go_is_string_type_p): New function.
 747         (go_language_defn): Initialise new field.
 748         * language.c (default_is_string_type_p): New function.
 749         (unknown_language_defn): Initialise new field.
 750         (auto_language_defn): Initialise new field.
 751         * language.h (struct language_defn) <la_is_string_type_p>: New
 752         member variable.
 753         (default_is_string_type_p): Declare new function.
 754         * m2-lang.c (m2_language_defn): Initialise new field.
 755         * objc-lang.c (objc_language_defn): Initialise new field.
 756         * opencl-lang.c (opencl_language_defn): Initialise new field.
 757         * p-lang.c (pascal_is_string_type_p): New function.
 758         (pascal_language_defn): Initialise new field.
 759         * rust-lang.c (rust_is_string_type_p): New function.
 760         (rust_language_defn): Initialise new field.
 761
 762 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 763
 764         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 765         New field.
 766         * ada-lang.c (ada_language_defn): Initialise new field.
 767         * c-lang.c (c_language_defn): Likewise.
 768         (cplus_language_defn): Likewise.
 769         (asm_language_defn): Likewise.
 770         (minimal_language_defn): Likewise.
 771         * d-lang.c (d_language_defn): Likewise.
 772         * f-lang.c (f_language_defn): Likewise.
 773         * go-lang.c (go_language_defn): Likewise.
 774         * language.c (unknown_language_defn): Likewise.
 775         (auto_language_defn): Likewise.
 776         * m2-lang.c (m2_language_defn): Likewise.
 777         * objc-lang.c (objc_language_defn): Likewise.
 778         * opencl-lang.c (opencl_language_defn): Likewise.
 779         * p-lang.c (pascal_language_defn): Likewise.
 780         * rust-lang.c (rust_language_defn): Likewise.
 781
 782 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 783
 784         * ada-lang.c (ada_is_character_type): Change return type to bool.
 785         (ada_is_string_type): Likewise.
 786         * ada-lang.h (ada_is_character_type): Update declaration
 787         (ada_is_string_type): Likewise.
 788
 789 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 790
 791         Support style in 'frame|thread apply'
 792
 793         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 794         * record.c (record_start, record_stop): Update callers of
 795         execute_command_to_string with false.
 796         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 797         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 798         methods.
 799         (class string_file): New constructor with term_out parameter.
 800         Override methods term_out and can_emit_style_escape.  New member
 801         term_out.
 802         (class stdio_file): Override can_emit_style_escape.
 803         (class tee_file): Override term_out and can_emit_style_escape.
 804         * utils.h (can_emit_style_escape): Remove.
 805         * utils.c (can_emit_style_escape): Likewise.
 806         Update all callers of can_emit_style_escape (SOMESTREAM) to
 807         SOMESTREAM->can_emit_style_escape.
 808         * source-cache.c (source_cache::get_source_lines): Likewise.
 809         * stack.c (frame_apply_command_count): Call execute_command_to_string
 810         passing the term_out characteristic of the current gdb_stdout.
 811         * thread.c (thr_try_catch_cmd): Likewise.
 812         * top.c (execute_command_to_string): pass term_out parameter
 813         to construct the string_file for the command output.
 814         * ui-file.c (term_cli_styling): New function (most code moved
 815         from utils.c can_emit_style_escape).
 816         (string_file::string_file, string_file::can_emit_style_escape,
 817         stdio_file::can_emit_style_escape, tee_file::term_out,
 818         tee_file::can_emit_style_escape): New functions.
 819
 820 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 821
 822         * NEWS: Mention the new set|show may-call-functions.
 823         * infcall.c (may_call_functions_p): New variable.
 824         (show_may_call_functions_p): New function.
 825         (call_function_by_hand_dummy): Throws an error if not
 826         may-call-functions.
 827         (_initialize_infcall): Call add_setshow_boolean_cmd for
 828         may-call-functions.
 829
 830 2019-04-25  Keith Seitz  <keiths@redhat.com>
 831
 832         PR c++/24367
 833         * cp-support.c (inspect_type): Don't attempt substitutions
 834         of symbol with the same name.
 835
 836 2019-04-25  Tom Tromey  <tromey@adacore.com>
 837
 838         PR gdb/24475:
 839         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 840         static.
 841
 842 2019-04-25  Tom Tromey  <tromey@adacore.com>
 843
 844         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 845         rvalue reference.
 846         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 847         (gdb_xml_parser::parse): Use std::move.
 848         * python/python-internal.h (gdbpy_convert_exception): Take a const
 849         reference.
 850         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 851         std::move.
 852         * python/py-utils.c (gdbpy_convert_exception): Take a const
 853         reference.
 854         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 855         Use std::move.
 856         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 857         Use std::move.
 858         * mi/mi-main.c (mi_print_exception): Take a const reference.
 859         * main.c (handle_command_errors): Take a const reference.
 860         * linespec.c (parse_linespec): Use std::move.
 861         * infcall.c (run_inferior_call): Use std::move.
 862         (call_function_by_hand_dummy): Use std::move.
 863         * exec.c (try_open_exec_file): Use std::move.
 864         * exceptions.h (exception_print, exception_fprintf)
 865         (exception_print_same): Update.
 866         * exceptions.c (print_exception, exception_print)
 867         (exception_fprintf, exception_print_same): Change parameters to
 868         const reference.
 869         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 870         * common/new-op.c: Use std::move.
 871         * common/common-exceptions.h (struct gdb_exception): Add move
 872         constructor.
 873         (struct gdb_exception_error, struct gdb_exception_quit, struct
 874         gdb_quit_bad_alloc): Change constructor to move constructor.
 875         (throw_exception): Change parameter to rvalue reference.
 876         * common/common-exceptions.c (throw_exception): Take rvalue
 877         reference.
 878         * cli/cli-interp.c (safe_execute_command): Use std::move.
 879         * breakpoint.c (insert_bp_location, location_to_sals): Use
 880         std::move.
 881
 882 2019-04-25  Tom Tromey  <tromey@adacore.com>
 883
 884         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 885         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 886         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 887         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 888         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 889         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 890         guile/scm-value.c: Use unpack.
 891         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 892         gdbscm_gdb_exception.
 893         (gdbscm_throw_gdb_exception): Likewise.
 894         (struct gdbscm_gdb_exception): New.
 895         (unpack): New function.
 896         (gdbscm_wrap): Use unpack.
 897
 898 2019-04-25  Tom Tromey  <tromey@adacore.com>
 899
 900         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 901         (gdb_rl_callback_handler): Use std::move.
 902         * common/common-exceptions.h (struct gdb_exception): Add move
 903         assignment operator.
 904         (throw_exception_sjlj): Change "exception" to const reference.
 905         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 906         (throw_exception_sjlj): Change "exception" to const reference.
 907
 908 2019-04-25  Tom Tromey  <tromey@adacore.com>
 909
 910         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 911         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 912         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 913         Update.
 914         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 915         Update.
 916         * mi/mi-interp.c (mi_interp::exec): Update.
 917         * linespec.c (parse_linespec): Update.
 918         * infcall.c (run_inferior_call): Update.
 919         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 920         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 921         (gdbscm_lookup_global_symbol): Update.
 922         * guile/scm-param.c (gdbscm_parameter_value): Update.
 923         * guile/scm-frame.c (gdbscm_frame_read_register)
 924         (gdbscm_frame_read_var): Update.
 925         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 926         * exec.c (try_open_exec_file): Update.
 927         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 928         (gdb_rl_callback_handler): Update.
 929         * common/common-exceptions.h (exception_none): Don't declare.
 930         * common/common-exceptions.c (exception_none): Don't define.
 931         (struct catcher) <exception>: Update.
 932         * cli/cli-interp.c (safe_execute_command): Update.
 933         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 934
 935 2019-04-25  Ali Tamur  <tamur@google.com>
 936
 937         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 938         (read_attribute_value): Likewise.
 939         (dwarf2_read_addr_index): Update comment.
 940         (read_str_index): Add DW_FORM_strx.
 941         (dwarf2_string_attr): Likewise.
 942         (dwarf2_const_value_attr): Likewise.
 943         (dump_die_shallow): Likewise.
 944         (dwarf2_fetch_constant_bytes): Likewise.
 945         (skip_form_bytes): Likewise.
 946         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 947
 948 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 949
 950         PR corefiles/11608
 951         PR corefiles/18187
 952         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 953         OFFSET.  Verify if current mapping contains an ELF header.
 954         (linux_find_memory_regions_full): Adjust call to
 955         dump_mapping_p.
 956
 957 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 958             Kang Li <kanglictf@gmail.com>
 959
 960         PR gdb/21600
 961
 962         * dwarf2-frame.c (read_initial_length): Be consistent about using
 963         unsigned representation of length.
 964         (decode_frame_entry_1): Likewise.  Check for wraparound of
 965         end pointer as well as buffer overflow.
 966
 967 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 968
 969         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 970         "vq".
 971
 972 2019-04-24  Tom Tromey  <tromey@adacore.com>
 973
 974         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 975
 976 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 977
 978         * s12z-tdep.c (s12z_unwind_pc): Delete.
 979         (s12z_unwind_sp): Delete.
 980         (s12z_gdbarch_init): Don't register deleted functions with
 981         gdbarch.
 982
 983 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 984
 985         * rl78-tdep.c (rl78_unwind_sp): Delete.
 986         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 987
 988 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 989
 990         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 991         (xstormy16_unwind_pc): Delete.
 992         (xstormy16_dummy_id): Delete.
 993         (xstormy16_gdbarch_init): Don't register deleted functions with
 994         gdbarch.
 995
 996 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 997
 998         * vax-tdep.c (vax_unwind_pc): Delete.
 999         (vax_gdbarch_init): Don't register deleted function with gdbarch.
1000
1001 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1002
1003         * v850-tdep.c (v850_unwind_sp): Delete.
1004         (v850_unwind_pc): Delete.
1005         (v850_dummy_id): Delete.
1006         (v850_gdbarch_init): Don't register deleted functions with
1007         gdbarch.
1008
1009 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1010
1011         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
1012         (tilegx_unwind_pc): Delete.
1013         (tilegx_unwind_dummy_id): Delete.
1014         (tilegx_gdbarch_init): Don't register deleted functions with
1015         gdbarch.
1016
1017 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1018
1019         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
1020         (tic6x_dummy_id): Delete.
1021         (tic6x_gdbarch_init): Don't register deleted functions with
1022         gdbarch.
1023
1024 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1025
1026         * sparc-tdep.c (sparc_unwind_pc): Delete.
1027         (sparc32_gdbarch_init): Don't register deleted function with
1028         gdbarch.
1029
1030 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1031
1032         * sh-tdep.c (sh_unwind_sp): Delete.
1033         (sh_unwind_pc): Delete.
1034         (sh_dummy_id): Delete.
1035         (sh_gdbarch_init): Don't register deleted functions with
1036         gdbarch.
1037
1038 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1039
1040         * score-tdep.c (score_unwind_sp): Delete.
1041         (score_unwind_pc): Delete.
1042         (score_dummy_id): Delete.
1043         (score_gdbarch_init): Don't register deleted functions with
1044         gdbarch.
1045
1046 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1047
1048         * rx-tdep.c (rx_unwind_pc): Delete.
1049         (rx_unwind_sp): Delete.
1050         (rx_dummy_id): Delete.
1051         (rx_gdbarch_init): Don't register deleted functions with
1052         gdbarch.  Update comment.
1053
1054 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1055
1056         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
1057         (rs6000_dummy_id): Delete.
1058         (rs6000_gdbarch_init): Don't register deleted functions with
1059         gdbarch.
1060
1061 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1062
1063         * or1k-tdep.c (or1k_dummy_id): Delete.
1064         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
1065
1066 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1067
1068         * nios2-tdep.c (nios2_dummy_id): Delete.
1069         (nios2_unwind_sp): Delete.
1070         (nios2_gdbarch_init): Don't register deleted functions with
1071         gdbarch.
1072
1073 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1074
1075         * nds32-tdep.c (nds32_dummy_id): Delete.
1076         (nds32_unwind_pc): Delete.
1077         (nds32_unwind_sp): Delete.
1078         (nds32_gdbarch_init): Don't register deleted functions with
1079         gdbarch.
1080
1081 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1082
1083         * msp430-tdep.c (msp430_unwind_pc): Delete.
1084         (msp430_unwind_sp): Delete.
1085         (msp430_dummy_id): Delete.
1086         (msp430_gdbarch_init): Don't register deleted functions with
1087         gdbarch.
1088
1089 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1090
1091         * moxie-tdep.c (moxie_unwind_sp): Delete.
1092         (moxie_unwind_pc): Delete.
1093         (moxie_dummy_id): Delete.
1094         (moxie_gdbarch_init): Don't register deleted functions with
1095         gdbarch.
1096
1097 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1098
1099         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1100         (mn10300_unwind_pc): Delete.
1101         (mn10300_unwind_sp): Delete.
1102         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1103         mn10300_unwind_sp.
1104         (mn10300_frame_unwind_init): Don't register deleted functions with
1105         gdbarch.
1106
1107 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1108
1109         * mep-tdep.c (mep_unwind_pc): Delete.
1110         (mep_unwind_sp): Delete.
1111         (mep_dummy_id): Delete.
1112         (mep_gdbarch_init): Don't register deleted functions with
1113         gdbarch.
1114
1115 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1116
1117         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1118         (m68hc11_unwind_sp): Delete.
1119         (m68hc11_gdbarch_init): Don't register deleted functions with
1120         gdbarch.
1121
1122 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1123
1124         * m32r-tdep.c (m32r_unwind_sp): Delete.
1125         (m32r_unwind_pc): Delete.
1126         (m32r_dummy_id): Delete.
1127         (m32r_gdbarch_init): Don't register deleted functions with
1128         gdbarch.
1129
1130 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1131
1132         * m32c-tdep.c (m32c_unwind_pc): Delete.
1133         (m32c_unwind_sp): Delete.
1134         (m32c_dummy_id): Delete.
1135         (m32c_gdbarch_init): Don't register deleted functions with
1136         gdbarch.
1137
1138 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1139
1140         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1141         (lm32_unwind_pc): Delete.
1142         (lm32_dummy_id): Delete.
1143         (lm32_gdbarch_init): Don't register deleted functions with
1144         gdbarch.
1145
1146 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1147
1148         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1149         (iq2000_unwind_pc): Delete.
1150         (iq2000_dummy_id): Delete.
1151         (iq2000_gdbarch_init): Don't register deleted functions with
1152         gdbarch.
1153
1154 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1155
1156         * nds32-tdep.c (nds32_type_align): Delete.
1157         (nds32_push_dummy_call): Use type_align instead.
1158
1159 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1160
1161         * arm-tdep.c (arm_type_align): Only handle vector override case.
1162         (arm_push_dummy_call): Use type_align.
1163         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1164
1165 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1166
1167         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1168         case.
1169         (pass_on_stack): Use type_align.
1170         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1171         function.
1172
1173 2019-04-23  Tom Tromey  <tromey@adacore.com>
1174
1175         * dwarf2read.c (line_header::file_name_at): Remove unused
1176         overload.
1177
1178 2019-04-23  Tom de Vries  <tdevries@suse.de>
1179
1180         PR gdb/24438
1181         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1182         invocation.
1183
1184
1185 2019-03-27  Ali Tamur  <tamur@google.com>
1186
1187         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1188         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1189         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1190         (dwarf_expr_context::get_addr_index): Likewise
1191         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1192         (symbol_needs_eval_context::get_addr_index): Likewise
1193         (disassemble_dwarf_expression): Add DW_OP_addrx
1194         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1195         (read_cutu_die_from_dwo): Update comment
1196         (skip_one_die): Add DW_FORM_addrx
1197         (read_attribute_value): Likewise
1198         (var_decode_location): Add DW_OP_addrx
1199         (dwarf2_const_value_attr): Add DW_FORM_addrx
1200         (dump_die_shallow): Likewise
1201         (dwarf2_fetch_constant_bytes): Likewise
1202         (decode_locdesc): Add DW_OP_addrx
1203         (skip_form_bytes): Add DW_FORM_addrx
1204
1205 2019-04-22  Ali Tamur  <tamur@google.com>
1206
1207         * MAINTAINERS (Write After Approval): Add self.
1208
1209 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1210
1211         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1212         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1213         (open_symbol_file_object): Likewise.
1214         (svr4_default_sos): Add info parameter.
1215         (svr4_read_so_list): Likewise.
1216         (svr4_current_sos_direct): Adjust functions calls to pass down
1217         info.
1218         (svr4_current_sos_1): Add info parameter.
1219         (svr4_current_sos): Call get_svr4_info, pass info down to
1220         svr4_current_sos_1.
1221         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1222         get_svr4_info.
1223         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1224         get_svr4_info.
1225         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1226         to get_svr4_info.
1227         (probes_table_remove_objfile_probes): Likewise.
1228         (register_solib_event_probe): Add info parameter.
1229         (solist_update_incremental): Pass info parameter down to
1230         svr4_read_so_list.
1231         (disable_probes_interface): Add info parameter.
1232         (svr4_handle_solib_event): Pass current_program_space to
1233         get_svr4_info.  Adjust disable_probes_interface cleanup.
1234         (svr4_create_probe_breakpoints): Add info parameter, pass it
1235         down to register_solib_event_probe.
1236         (svr4_create_solib_event_breakpoints): Add info parameter,
1237         pass it down to svr4_create_probe_breakpoints.
1238         (enable_break): Pass info down to
1239         svr4_create_solib_event_breakpoints.
1240         (svr4_solib_create_inferior_hook): Pass current_program_space to
1241         get_svr4_info.
1242         (svr4_clear_solib): Likewise.
1243
1244 2019-04-22  Pedro Alves  <palves@redhat.com>
1245
1246         * solib-svr4.c (svr4_free_objfile_observer): New.
1247         (probe_and_action::objfile): New field.
1248         (probes_table_htab_remove_objfile_probes)
1249         (probes_table_remove_objfile_probes): New functions.
1250         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1251         in the new probe_and_action.  Don't store the probe in 'lookup'.
1252         (svr4_create_probe_breakpoints): Pass objfile to
1253         register_solib_event_probe.
1254         (_initialize_svr4_solib): Register a free_objfile observer.
1255
1256 2019-04-19  Tom Tromey  <tom@tromey.com>
1257
1258         * common/queue.h: Remove.
1259
1260 2019-04-19  Tom Tromey  <tom@tromey.com>
1261
1262         * event-loop.c: Don't include "common/queue.h".
1263
1264 2019-04-19  Tom Tromey  <tom@tromey.com>
1265
1266         * remote.c (remote_target): Use delete.
1267         * remote-notif.h: Include <list>, not "common/queue.h".
1268         (notif_client_p): Remove typedef.
1269         (remote_notif_state): Add constructor, destructor, initializer.
1270         <notif_queue>: Now a std::list.
1271         (remote_notif_state_xfree): Don't declare.
1272         * remote-notif.c (remote_notif_process, handle_notification)
1273         (remote_notif_state_allocate): Update.
1274         (~remote_notif_state): Rename from remote_notif_state_xfree.
1275
1276 2019-04-19  Tom Tromey  <tom@tromey.com>
1277
1278         * symfile.c (reread_symbols): Update.
1279         * objfiles.c (objfile_register_static_link)
1280         (objfile_lookup_static_link): Update
1281         (~objfile) Don't delete static_links.
1282         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1283
1284 2019-04-19  Tom Tromey  <tom@tromey.com>
1285
1286         * type-stack.h (struct type_stack) <insert>: Constify string.
1287         * type-stack.c (type_stack::insert): Constify string.
1288         * gdbtypes.h (lookup_template_type): Update.
1289         (address_space_name_to_int): Update.
1290         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1291         const.
1292         (lookup_template_type): Make name const.
1293         * c-exp.y: Update rules.
1294         (lex_one_token, classify_name, classify_inner_name)
1295         (c_print_token): Update.
1296         * p-exp.y: Update rules.
1297         (yylex): Update.
1298         * f-exp.y: Update rules.
1299         (yylex): Update.
1300         * d-exp.y: Update rules.
1301         (lex_one_token, classify_name, classify_inner_name): Update.
1302         * parse.c (write_dollar_variable, copy_name): Return std::string.
1303         * parser-defs.h (copy_name): Change return type.
1304         * m2-exp.y: Update rules.
1305         (yylex): Update.
1306         * go-exp.y (lex_one_token): Update.
1307         Update rules.
1308         (classify_unsafe_function, classify_packaged_name)
1309         (classify_name, yylex): Update.
1310
1311 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1312
1313         * configure.ac: add --enable-source-highlight switch.
1314         * configure: Regenerate.
1315         * top.c (print_gdb_version): plumb --enable-source-highlight
1316         status to "show configuration".
1317
1318 2019-04-19  Tom Tromey  <tromey@adacore.com>
1319
1320         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1321         Check ADA_TYPE_P.
1322         (empty_record, ada_template_to_fixed_record_type_1)
1323         (template_to_static_fixed_type)
1324         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1325         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1326         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1327         macros.
1328
1329 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1330
1331         PR symtab/24423:
1332         * source.c (print_source_lines_base): Advance "iter" when a
1333         control character is seen.
1334
1335 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1336
1337         * inferior.h (struct infcall_suspend_state_deleter):
1338         Catch exception in destructor to avoid crash.
1339
1340 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1341
1342         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1343         close to the add_com "shell".
1344
1345 2019-04-18  Tom Tromey  <tromey@adacore.com>
1346
1347         * process-stratum-target.h (class process_stratum_target)
1348         <stratum>: Add "final".
1349
1350 2019-04-17  Tom Tromey  <tromey@adacore.com>
1351
1352         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1353         against nullptr before use.
1354
1355 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1356
1357         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1358
1359 2019-04-17  Jim Wilson  <jimw@sifive.com>
1360             Andrew Burgess  <andrew.burgess@embecosm.com>
1361
1362         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1363         code read might fail, assume 4-byte breakpoint in that case.
1364
1365 2019-04-15  Leszek Swirski  <leszeks@google.com>
1366
1367         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1368         rather than a hand-rolled POD check when checking for forced MEMORY
1369         classification.
1370
1371 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1372
1373         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1374         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1375         function.
1376         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1377         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1378         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1379         declaration.
1380
1381 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1382
1383         * aarch64-linux-nat.c
1384         (aarch64_linux_nat_target::thread_architecture): Add override.
1385         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1386         each VQ.
1387
1388 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1389
1390         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1391
1392 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1393
1394         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1395         target types of size 96-bits, add some additional comments, and
1396         check that the builtin type we found was the correct size.
1397
1398 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1399
1400         * utils.c (prompt_for_continue): Don't restore the styling at the
1401         end, as applied_style has the wrong value.  This fixes styling in
1402         long lists of file names that are interrupted by the "Continue?"
1403         prompt.
1404
1405 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1406
1407         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1408         * c-lang.c (c_language_defn): Likewise.
1409         (cplus_language_defn): Likewise.
1410         (asm_language_defn): Likewise.
1411         (minimal_language_defn): Likewise.
1412         * d-lang.c (d_language_defn): Likewise.
1413         * f-lang.c (f_language_defn): Likewise.
1414         * go-lang.c (go_language_defn): Likewise.
1415         * language.c (unknown_language_defn): Likewise.
1416         (auto_language_defn): Likewise.
1417         * language.h (struct language_defn): Remove la_magic field.
1418         (LANG_MAGIC): Delete.
1419         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1420         * objc-lang.c (objc_language_defn): Likewise.
1421         * opencl-lang.c (opencl_language_defn): Likewise.
1422         * p-lang.c (pascal_language_defn): Likewise.
1423         * rust-lang.c (rust_language_defn): Likewise.
1424
1425 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1426
1427         * riscv-tdep.c (riscv_type_align): New function.
1428         (riscv_type_alignment): Delete.
1429         (riscv_arg_location): Use 'type_align'.
1430         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1431
1432 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1433
1434         * gdbtypes.c (type_align): A struct with no non-static fields also
1435         has alignment of 1.
1436
1437 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1438
1439         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1440         component to 0.
1441         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1442         member.
1443         (riscv_struct_info::analyse): New implementation using new
1444         analyse_inner member function.
1445         (riscv_struct_info::field_offset): New member function.
1446         (riscv_struct_info::m_offsets): New member variable.
1447         (riscv_struct_info::analyse_inner): New private member function,
1448         takes the old implementation of riscv_struct_info::analyse but
1449         extended to track field offsets.
1450         (riscv_call_arg_struct): Update the struct folding special cases
1451         to handle cases where empty C++ structs, which are non-zero
1452         length, are found.
1453         (riscv_arg_location): Initialise the length of each location, a
1454         non-zero length now indicates the location is in use.
1455         (riscv_push_dummy_call): Allow for the first location having a
1456         non-zero offset when setting up arguments.
1457         (riscv_return_value): Likewise, but for return values.
1458
1459 2019-04-11  Tom Tromey  <tromey@adacore.com>
1460
1461         * utils.c (internal_vproblem): Make "msg" const.
1462
1463 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1464
1465         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1466         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1467         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1468         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1469
1470 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1471
1472         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1473         function.
1474         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1475         of amd64_collect_native_gregset.
1476         (amd64_linux_nat_target::store_registers): Likewise.
1477
1478 2019-04-10  Tom Tromey  <tom@tromey.com>
1479
1480         * symtab.c (lookup_global_symbol_from_objfile)
1481         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1482         * objfiles.h (class separate_debug_iterator): New.
1483         (class separate_debug_range): New.
1484         (struct objfile) <separate_debug_objfiles>: New method.
1485         (objfile_separate_debug_iterate): Don't declare.
1486         * objfiles.c (separate_debug_iterator::operator++): Rename from
1487         objfile_separate_debug_iterate.
1488         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1489         iterator.
1490         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1491         iterator.
1492
1493 2019-04-10  Tom Tromey  <tom@tromey.com>
1494
1495         * symfile.c (reread_symbols): Remove old comment.
1496         * objfiles.c (free_all_objfiles): Fix a typo.
1497
1498 2019-04-10  Tom Tromey  <tom@tromey.com>
1499
1500         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1501         * minsyms.c (lookup_minimal_symbol): Use foreach.
1502         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1503         (lookup_minimal_symbol_solib_trampoline): Likewise.
1504         * symfile.c (reread_symbols): Use foreach.
1505
1506 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1507             Tom Tromey  <tromey@adacore.com>
1508
1509         PR rust/24414:
1510         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1511         (rust_lex_int_test): Change "value" to be LONGEST.
1512         (rust_lex_tests): Add test for long integer literal.
1513
1514 2019-04-09  Tom Tromey  <tromey@adacore.com>
1515
1516         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1517         to bool.
1518         (extended_remote_target::attach): Update.
1519         (remote_target::remote_notice_new_inferior): Update.
1520         (remote_target::add_current_inferior_and_thread): Update.
1521         * inferior.c (exit_inferior_1): Use "false".
1522         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1523
1524 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1525
1526         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1527         the "start" command.
1528
1529 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1530
1531         * python/py-inferior.c (infpy_thread_from_thread_handle):
1532         Adjust comments to reflect renaming of thread_from_thread_handle
1533         to thread_from_handle.  Adjust keywords.  Fix type error message.
1534         (inferior_object_methods): Add thread_from_handle.  Retain
1535         thread_from_thread_handle, but mark it as deprecated.
1536
1537 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1538
1539         * gdbthread.h (find_thread_by_handle): Revise declaration.
1540         * thread.c (find_thread_by_handle): Likewise.  Adjust
1541         implementation too.
1542         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1543         support for buffer objects as handles.
1544
1545 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1546
1547         * python/py-infthread.c (thpy_thread_handle): New function.
1548         (thread_object_methods): Register thpy_thread_handle.
1549
1550 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1551
1552         * gdbthread.h (thread_to_thread_handle): Declare.
1553         * thread.c (gdbtypes.h): Include.
1554         (thread_to_thread_handle): New function.
1555
1556         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1557         (target_thread_info_to_thread_handle): Declare.
1558         * target.c (target_thread_info_to_thread_handle): New function.
1559         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1560         * target-delegates.c: Regenerate.
1561
1562         * linux-thread-db.c (class thread_db_target): Add method
1563         thread_info_to_thread_handle.
1564         (thread_db_target::thread_info_to_thread_handle): Define.
1565         * remote.c (class remote_target): Add new method
1566         thread_info_to_thread_handle.
1567         (remote_target::thread_info_to_thread_handle): Define.
1568
1569 2019-04-08  Pedro Alves  <palves@redhat.com>
1570
1571         * common/common-exceptions.c (throw_exception): Don't create
1572         named object to throw; throw directly.
1573         (throw_it): Likewise.  Don't initialize gdb_exception::message
1574         here, with new; pass FMT and AP to the ctor instead.
1575         * common/common-exceptions.h: Include <string>.
1576         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1577         const char *, va_list)): New ctor.  Use std::make_shared.
1578         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1579         errors)): Delete.
1580         (gdb_exception_error::gdb_exception_error(enum errors, const char
1581         *, va_list)): New.
1582         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1583         Add assertion.
1584         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1585         errors)): Delete.
1586         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1587         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1588         Add assertion.
1589
1590 2019-04-08  Tom Tromey  <tom@tromey.com>
1591
1592         * valops.c (value_rtti_indirect_type): Replace throw_exception
1593         with throw.
1594         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1595         with throw.
1596         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1597         throw.
1598         * target.c (target_translate_tls_address): Replace throw_exception
1599         with throw.
1600         * stack.c (frame_apply_command_count): Replace throw_exception
1601         with throw.
1602         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1603         throw.
1604         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1605         with throw.
1606         * rs6000-tdep.c (rs6000_frame_cache)
1607         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1608         * remote.c: Replace throw_exception with throw.
1609         * record-full.c (record_full_message, record_full_wait_1)
1610         (record_full_restore): Replace throw_exception with throw.
1611         * record-btrace.c:
1612         (get_thread_current_frame_id, record_btrace_start_replaying)
1613         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1614         (cmd_record_btrace_start): Replace throw_exception with throw.
1615         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1616         throw.
1617         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1618         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1619         * linespec.c:
1620         (find_linespec_symbols): Replace throw_exception with throw.
1621         * infrun.c (displaced_step_prepare, resume): Replace
1622         throw_exception with throw.
1623         * infcmd.c (post_create_inferior): Replace throw_exception with
1624         throw.
1625         * inf-loop.c (inferior_event_handler): Replace throw_exception
1626         with throw.
1627         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1628         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1629         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1630         (get_prev_frame_always, get_frame_pc_if_available)
1631         (get_frame_address_in_block_if_available, get_frame_language):
1632         Replace throw_exception with throw.
1633         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1634         throw_exception with throw.
1635         * eval.c (fetch_subexp_value, evaluate_var_value)
1636         (evaluate_funcall, evaluate_subexp_standard): Replace
1637         throw_exception with throw.
1638         * dwarf2loc.c (call_site_find_chain)
1639         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1640         Replace throw_exception with throw.
1641         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1642         with throw.
1643         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1644         throw.
1645         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1646         * completer.c (complete_line_internal): Replace throw_exception
1647         with throw.
1648         * compile/compile-object-run.c (compile_object_run): Replace
1649         throw_exception with throw.
1650         * cli/cli-script.c (process_next_line): Replace throw_exception
1651         with throw.
1652         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1653         (btrace_enable, btrace_maint_update_pt_packets): Replace
1654         throw_exception with throw.
1655         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1656         throw_exception with throw.
1657         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1658         throw_exception with throw.
1659         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1660         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1661         * aarch64-tdep.c (aarch64_make_prologue_cache)
1662         (aarch64_make_stub_cache): Replace throw_exception with throw.
1663
1664 2019-04-08  Tom Tromey  <tom@tromey.com>
1665
1666         * common/common-exceptions.c (throw_exception): Rename from
1667         throw_exception_cxx.  Remove old copy.  Make argument const.
1668         (throw_it): Create and throw exception objects directly.
1669         * common/common-exceptions.h (throw_exception): Make argument
1670         const.
1671         (struct gdb_exception_error): Add constructor.
1672         (struct gdb_exception_quit): Add constructor.
1673
1674 2019-04-08  Tom Tromey  <tom@tromey.com>
1675
1676         * common/common-exceptions.h (exception_rethrow): Don't declare.
1677         (TRY_SJLJ): Update comment.
1678         (TRY, CATCH, END_CATCH): Remove.
1679         * common/common-exceptions.c (exception_rethrow): Remove.
1680
1681 2019-04-08  Tom Tromey  <tom@tromey.com>
1682
1683         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1684         Remove.
1685         (gdb_exception_error): Rename from
1686         gdb_exception_RETURN_MASK_ERROR.
1687         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1688         (gdb_quit_bad_alloc): Update.
1689         * aarch64-tdep.c: Update.
1690         * ada-lang.c: Update.
1691         * ada-typeprint.c: Update.
1692         * ada-valprint.c: Update.
1693         * amd64-tdep.c: Update.
1694         * arch-utils.c: Update.
1695         * break-catch-throw.c: Update.
1696         * breakpoint.c: Update.
1697         * btrace.c: Update.
1698         * c-varobj.c: Update.
1699         * cli/cli-cmds.c: Update.
1700         * cli/cli-interp.c: Update.
1701         * cli/cli-script.c: Update.
1702         * common/common-exceptions.c: Update.
1703         * common/new-op.c: Update.
1704         * common/selftest.c: Update.
1705         * compile/compile-c-symbols.c: Update.
1706         * compile/compile-cplus-symbols.c: Update.
1707         * compile/compile-object-load.c: Update.
1708         * compile/compile-object-run.c: Update.
1709         * completer.c: Update.
1710         * corelow.c: Update.
1711         * cp-abi.c: Update.
1712         * cp-support.c: Update.
1713         * cp-valprint.c: Update.
1714         * darwin-nat.c: Update.
1715         * disasm-selftests.c: Update.
1716         * dtrace-probe.c: Update.
1717         * dwarf-index-cache.c: Update.
1718         * dwarf-index-write.c: Update.
1719         * dwarf2-frame-tailcall.c: Update.
1720         * dwarf2-frame.c: Update.
1721         * dwarf2loc.c: Update.
1722         * dwarf2read.c: Update.
1723         * eval.c: Update.
1724         * event-loop.c: Update.
1725         * event-top.c: Update.
1726         * exec.c: Update.
1727         * f-valprint.c: Update.
1728         * fbsd-tdep.c: Update.
1729         * frame-unwind.c: Update.
1730         * frame.c: Update.
1731         * gdbtypes.c: Update.
1732         * gnu-v3-abi.c: Update.
1733         * guile/guile-internal.h: Update.
1734         * guile/scm-block.c: Update.
1735         * guile/scm-breakpoint.c: Update.
1736         * guile/scm-cmd.c: Update.
1737         * guile/scm-disasm.c: Update.
1738         * guile/scm-frame.c: Update.
1739         * guile/scm-lazy-string.c: Update.
1740         * guile/scm-math.c: Update.
1741         * guile/scm-param.c: Update.
1742         * guile/scm-ports.c: Update.
1743         * guile/scm-pretty-print.c: Update.
1744         * guile/scm-symbol.c: Update.
1745         * guile/scm-symtab.c: Update.
1746         * guile/scm-type.c: Update.
1747         * guile/scm-value.c: Update.
1748         * i386-linux-tdep.c: Update.
1749         * i386-tdep.c: Update.
1750         * inf-loop.c: Update.
1751         * infcall.c: Update.
1752         * infcmd.c: Update.
1753         * infrun.c: Update.
1754         * jit.c: Update.
1755         * language.c: Update.
1756         * linespec.c: Update.
1757         * linux-fork.c: Update.
1758         * linux-nat.c: Update.
1759         * linux-tdep.c: Update.
1760         * linux-thread-db.c: Update.
1761         * main.c: Update.
1762         * mi/mi-cmd-break.c: Update.
1763         * mi/mi-cmd-stack.c: Update.
1764         * mi/mi-interp.c: Update.
1765         * mi/mi-main.c: Update.
1766         * objc-lang.c: Update.
1767         * p-valprint.c: Update.
1768         * parse.c: Update.
1769         * ppc-linux-tdep.c: Update.
1770         * printcmd.c: Update.
1771         * python/py-arch.c: Update.
1772         * python/py-breakpoint.c: Update.
1773         * python/py-cmd.c: Update.
1774         * python/py-finishbreakpoint.c: Update.
1775         * python/py-frame.c: Update.
1776         * python/py-framefilter.c: Update.
1777         * python/py-gdb-readline.c: Update.
1778         * python/py-inferior.c: Update.
1779         * python/py-infthread.c: Update.
1780         * python/py-lazy-string.c: Update.
1781         * python/py-linetable.c: Update.
1782         * python/py-objfile.c: Update.
1783         * python/py-param.c: Update.
1784         * python/py-prettyprint.c: Update.
1785         * python/py-progspace.c: Update.
1786         * python/py-record-btrace.c: Update.
1787         * python/py-record.c: Update.
1788         * python/py-symbol.c: Update.
1789         * python/py-type.c: Update.
1790         * python/py-unwind.c: Update.
1791         * python/py-utils.c: Update.
1792         * python/py-value.c: Update.
1793         * python/python.c: Update.
1794         * record-btrace.c: Update.
1795         * record-full.c: Update.
1796         * remote-fileio.c: Update.
1797         * remote.c: Update.
1798         * riscv-tdep.c: Update.
1799         * rs6000-aix-tdep.c: Update.
1800         * rs6000-tdep.c: Update.
1801         * rust-exp.y: Update.
1802         * rust-lang.c: Update.
1803         * s390-tdep.c: Update.
1804         * selftest-arch.c: Update.
1805         * solib-dsbt.c: Update.
1806         * solib-frv.c: Update.
1807         * solib-spu.c: Update.
1808         * solib-svr4.c: Update.
1809         * solib.c: Update.
1810         * sparc64-linux-tdep.c: Update.
1811         * stack.c: Update.
1812         * symfile-mem.c: Update.
1813         * symmisc.c: Update.
1814         * target.c: Update.
1815         * thread.c: Update.
1816         * top.c: Update.
1817         * tracefile-tfile.c: Update.
1818         * tui/tui.c: Update.
1819         * typeprint.c: Update.
1820         * unittests/cli-utils-selftests.c: Update.
1821         * unittests/parse-connection-spec-selftests.c: Update.
1822         * valops.c: Update.
1823         * valprint.c: Update.
1824         * value.c: Update.
1825         * varobj.c: Update.
1826         * windows-nat.c: Update.
1827         * x86-linux-nat.c: Update.
1828         * xml-support.c: Update.
1829
1830 2019-04-08  Tom Tromey  <tom@tromey.com>
1831
1832         * xml-support.c: Use C++ exception handling.
1833         * x86-linux-nat.c: Use C++ exception handling.
1834         * windows-nat.c: Use C++ exception handling.
1835         * varobj.c: Use C++ exception handling.
1836         * value.c: Use C++ exception handling.
1837         * valprint.c: Use C++ exception handling.
1838         * valops.c: Use C++ exception handling.
1839         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1840         handling.
1841         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1842         * typeprint.c: Use C++ exception handling.
1843         * tui/tui.c: Use C++ exception handling.
1844         * tracefile-tfile.c: Use C++ exception handling.
1845         * top.c: Use C++ exception handling.
1846         * thread.c: Use C++ exception handling.
1847         * target.c: Use C++ exception handling.
1848         * symmisc.c: Use C++ exception handling.
1849         * symfile-mem.c: Use C++ exception handling.
1850         * stack.c: Use C++ exception handling.
1851         * sparc64-linux-tdep.c: Use C++ exception handling.
1852         * solib.c: Use C++ exception handling.
1853         * solib-svr4.c: Use C++ exception handling.
1854         * solib-spu.c: Use C++ exception handling.
1855         * solib-frv.c: Use C++ exception handling.
1856         * solib-dsbt.c: Use C++ exception handling.
1857         * selftest-arch.c: Use C++ exception handling.
1858         * s390-tdep.c: Use C++ exception handling.
1859         * rust-lang.c: Use C++ exception handling.
1860         * rust-exp.y: Use C++ exception handling.
1861         * rs6000-tdep.c: Use C++ exception handling.
1862         * rs6000-aix-tdep.c: Use C++ exception handling.
1863         * riscv-tdep.c: Use C++ exception handling.
1864         * remote.c: Use C++ exception handling.
1865         * remote-fileio.c: Use C++ exception handling.
1866         * record-full.c: Use C++ exception handling.
1867         * record-btrace.c: Use C++ exception handling.
1868         * python/python.c: Use C++ exception handling.
1869         * python/py-value.c: Use C++ exception handling.
1870         * python/py-utils.c: Use C++ exception handling.
1871         * python/py-unwind.c: Use C++ exception handling.
1872         * python/py-type.c: Use C++ exception handling.
1873         * python/py-symbol.c: Use C++ exception handling.
1874         * python/py-record.c: Use C++ exception handling.
1875         * python/py-record-btrace.c: Use C++ exception handling.
1876         * python/py-progspace.c: Use C++ exception handling.
1877         * python/py-prettyprint.c: Use C++ exception handling.
1878         * python/py-param.c: Use C++ exception handling.
1879         * python/py-objfile.c: Use C++ exception handling.
1880         * python/py-linetable.c: Use C++ exception handling.
1881         * python/py-lazy-string.c: Use C++ exception handling.
1882         * python/py-infthread.c: Use C++ exception handling.
1883         * python/py-inferior.c: Use C++ exception handling.
1884         * python/py-gdb-readline.c: Use C++ exception handling.
1885         * python/py-framefilter.c: Use C++ exception handling.
1886         * python/py-frame.c: Use C++ exception handling.
1887         * python/py-finishbreakpoint.c: Use C++ exception handling.
1888         * python/py-cmd.c: Use C++ exception handling.
1889         * python/py-breakpoint.c: Use C++ exception handling.
1890         * python/py-arch.c: Use C++ exception handling.
1891         * printcmd.c: Use C++ exception handling.
1892         * ppc-linux-tdep.c: Use C++ exception handling.
1893         * parse.c: Use C++ exception handling.
1894         * p-valprint.c: Use C++ exception handling.
1895         * objc-lang.c: Use C++ exception handling.
1896         * mi/mi-main.c: Use C++ exception handling.
1897         * mi/mi-interp.c: Use C++ exception handling.
1898         * mi/mi-cmd-stack.c: Use C++ exception handling.
1899         * mi/mi-cmd-break.c: Use C++ exception handling.
1900         * main.c: Use C++ exception handling.
1901         * linux-thread-db.c: Use C++ exception handling.
1902         * linux-tdep.c: Use C++ exception handling.
1903         * linux-nat.c: Use C++ exception handling.
1904         * linux-fork.c: Use C++ exception handling.
1905         * linespec.c: Use C++ exception handling.
1906         * language.c: Use C++ exception handling.
1907         * jit.c: Use C++ exception handling.
1908         * infrun.c: Use C++ exception handling.
1909         * infcmd.c: Use C++ exception handling.
1910         * infcall.c: Use C++ exception handling.
1911         * inf-loop.c: Use C++ exception handling.
1912         * i386-tdep.c: Use C++ exception handling.
1913         * i386-linux-tdep.c: Use C++ exception handling.
1914         * guile/scm-value.c: Use C++ exception handling.
1915         * guile/scm-type.c: Use C++ exception handling.
1916         * guile/scm-symtab.c: Use C++ exception handling.
1917         * guile/scm-symbol.c: Use C++ exception handling.
1918         * guile/scm-pretty-print.c: Use C++ exception handling.
1919         * guile/scm-ports.c: Use C++ exception handling.
1920         * guile/scm-param.c: Use C++ exception handling.
1921         * guile/scm-math.c: Use C++ exception handling.
1922         * guile/scm-lazy-string.c: Use C++ exception handling.
1923         * guile/scm-frame.c: Use C++ exception handling.
1924         * guile/scm-disasm.c: Use C++ exception handling.
1925         * guile/scm-cmd.c: Use C++ exception handling.
1926         * guile/scm-breakpoint.c: Use C++ exception handling.
1927         * guile/scm-block.c: Use C++ exception handling.
1928         * guile/guile-internal.h: Use C++ exception handling.
1929         * gnu-v3-abi.c: Use C++ exception handling.
1930         * gdbtypes.c: Use C++ exception handling.
1931         * frame.c: Use C++ exception handling.
1932         * frame-unwind.c: Use C++ exception handling.
1933         * fbsd-tdep.c: Use C++ exception handling.
1934         * f-valprint.c: Use C++ exception handling.
1935         * exec.c: Use C++ exception handling.
1936         * event-top.c: Use C++ exception handling.
1937         * event-loop.c: Use C++ exception handling.
1938         * eval.c: Use C++ exception handling.
1939         * dwarf2read.c: Use C++ exception handling.
1940         * dwarf2loc.c: Use C++ exception handling.
1941         * dwarf2-frame.c: Use C++ exception handling.
1942         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1943         * dwarf-index-write.c: Use C++ exception handling.
1944         * dwarf-index-cache.c: Use C++ exception handling.
1945         * dtrace-probe.c: Use C++ exception handling.
1946         * disasm-selftests.c: Use C++ exception handling.
1947         * darwin-nat.c: Use C++ exception handling.
1948         * cp-valprint.c: Use C++ exception handling.
1949         * cp-support.c: Use C++ exception handling.
1950         * cp-abi.c: Use C++ exception handling.
1951         * corelow.c: Use C++ exception handling.
1952         * completer.c: Use C++ exception handling.
1953         * compile/compile-object-run.c: Use C++ exception handling.
1954         * compile/compile-object-load.c: Use C++ exception handling.
1955         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1956         * compile/compile-c-symbols.c: Use C++ exception handling.
1957         * common/selftest.c: Use C++ exception handling.
1958         * common/new-op.c: Use C++ exception handling.
1959         * cli/cli-script.c: Use C++ exception handling.
1960         * cli/cli-interp.c: Use C++ exception handling.
1961         * cli/cli-cmds.c: Use C++ exception handling.
1962         * c-varobj.c: Use C++ exception handling.
1963         * btrace.c: Use C++ exception handling.
1964         * breakpoint.c: Use C++ exception handling.
1965         * break-catch-throw.c: Use C++ exception handling.
1966         * arch-utils.c: Use C++ exception handling.
1967         * amd64-tdep.c: Use C++ exception handling.
1968         * ada-valprint.c: Use C++ exception handling.
1969         * ada-typeprint.c: Use C++ exception handling.
1970         * ada-lang.c: Use C++ exception handling.
1971         * aarch64-tdep.c: Use C++ exception handling.
1972
1973 2019-04-08  Tom Tromey  <tom@tromey.com>
1974
1975         * xml-support.c (gdb_xml_parser::parse): Update.
1976         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1977         * value.c (show_convenience): Update.
1978         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1979         (test_parse_flags_qcs): Update.
1980         * thread.c (thr_try_catch_cmd): Update.
1981         * target.c (target_translate_tls_address): Update.
1982         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1983         (info_frame_command_core, frame_apply_command_count): Update.
1984         * rust-exp.y (rust_lex_exception_test): Update.
1985         * riscv-tdep.c (riscv_print_one_register_info): Update.
1986         * remote.c (remote_target::enable_btrace): Update.
1987         * record-btrace.c (record_btrace_enable_warn): Update.
1988         * python/py-utils.c (gdbpy_convert_exception): Update.
1989         * printcmd.c (do_one_display, print_variable_and_value): Update.
1990         * mi/mi-main.c (mi_print_exception): Update.
1991         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1992         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1993         * linux-nat.c (linux_nat_target::attach): Update.
1994         * linux-fork.c (class scoped_switch_fork_info): Update.
1995         * infrun.c (displaced_step_prepare): Update.
1996         * infcall.c (call_function_by_hand_dummy): Update.
1997         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1998         * gnu-v3-abi.c (print_one_vtable): Update.
1999         * frame.c (get_prev_frame_always): Update.
2000         * f-valprint.c (info_common_command_for_block): Update.
2001         * exec.c (try_open_exec_file): Update.
2002         * exceptions.c (print_exception, exception_print)
2003         (exception_fprintf, exception_print_same): Update.
2004         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
2005         * dwarf-index-cache.c (index_cache::store)
2006         (index_cache::lookup_gdb_index): Update.
2007         * darwin-nat.c (maybe_cache_shell): Update.
2008         * cp-valprint.c (cp_print_value_fields): Update.
2009         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
2010         (gcc_cplus_symbol_address): Update.
2011         * compile/compile-c-symbols.c (gcc_convert_symbol)
2012         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
2013         * common/selftest.c: Update.
2014         * common/common-exceptions.h (struct gdb_exception) <message>: Now
2015         a std::string.
2016         (exception_try_scope_entry, exception_try_scope_exit): Don't
2017         declare.
2018         (struct exception_try_scope): Remove.
2019         (TRY): Don't use exception_try_scope.
2020         (struct gdb_exception): Add constructor, operator=.
2021         <what>: New method.
2022         (struct gdb_exception_RETURN_MASK_ALL)
2023         (struct gdb_exception_RETURN_MASK_ERROR)
2024         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
2025         (struct gdb_quit_bad_alloc): Update.
2026         * common/common-exceptions.c (exception_none): Change
2027         initializer.
2028         (struct catcher) <state, exception>: Initialize inline.
2029         <prev>: Remove member.
2030         (current_catcher): Remove.
2031         (catchers): New global.
2032         (exceptions_state_mc_init): Simplify.
2033         (catcher_pop): Remove.
2034         (exceptions_state_mc, exceptions_state_mc_catch): Update.
2035         (try_scope_depth, exception_try_scope_entry)
2036         (exception_try_scope_exit): Remove.
2037         (throw_exception_sjlj): Update.
2038         (exception_messages, exception_messages_size): Remove.
2039         (throw_it): Simplify.
2040         (gdb_exception_sliced_copy): Remove.
2041         (throw_exception_cxx): Update.
2042         * cli/cli-script.c (script_from_file): Update.
2043         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
2044         Update.
2045         * ada-valprint.c (ada_val_print): Update.
2046         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
2047         (create_excep_cond_exprs): Update.
2048
2049 2019-04-08  Tom Tromey  <tom@tromey.com>
2050
2051         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
2052         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
2053         (TRY, CATCH, END_CATCH): Remove some definitions.
2054         * common/common-exceptions.c: Don't use GDB_XCPT.
2055         (catcher_list_size): Remove.
2056         (throw_exception, throw_it): Simplify.
2057
2058 2019-04-05  Tom Tromey  <tom@tromey.com>
2059
2060         Revert the header-sorting patch.
2061         * ft32-tdep.c: Revert.
2062         * frv-tdep.c: Revert.
2063         * frv-linux-tdep.c: Revert.
2064         * frame.c: Revert.
2065         * frame-unwind.c: Revert.
2066         * frame-base.c: Revert.
2067         * fork-child.c: Revert.
2068         * findvar.c: Revert.
2069         * findcmd.c: Revert.
2070         * filesystem.c: Revert.
2071         * filename-seen-cache.h: Revert.
2072         * filename-seen-cache.c: Revert.
2073         * fbsd-tdep.c: Revert.
2074         * fbsd-nat.h: Revert.
2075         * fbsd-nat.c: Revert.
2076         * f-valprint.c: Revert.
2077         * f-typeprint.c: Revert.
2078         * f-lang.c: Revert.
2079         * extension.h: Revert.
2080         * extension.c: Revert.
2081         * extension-priv.h: Revert.
2082         * expprint.c: Revert.
2083         * exec.h: Revert.
2084         * exec.c: Revert.
2085         * exceptions.c: Revert.
2086         * event-top.c: Revert.
2087         * event-loop.c: Revert.
2088         * eval.c: Revert.
2089         * elfread.c: Revert.
2090         * dwarf2read.h: Revert.
2091         * dwarf2read.c: Revert.
2092         * dwarf2loc.c: Revert.
2093         * dwarf2expr.h: Revert.
2094         * dwarf2expr.c: Revert.
2095         * dwarf2-frame.c: Revert.
2096         * dwarf2-frame-tailcall.c: Revert.
2097         * dwarf-index-write.h: Revert.
2098         * dwarf-index-write.c: Revert.
2099         * dwarf-index-common.c: Revert.
2100         * dwarf-index-cache.h: Revert.
2101         * dwarf-index-cache.c: Revert.
2102         * dummy-frame.c: Revert.
2103         * dtrace-probe.c: Revert.
2104         * disasm.h: Revert.
2105         * disasm.c: Revert.
2106         * disasm-selftests.c: Revert.
2107         * dictionary.c: Revert.
2108         * dicos-tdep.c: Revert.
2109         * demangle.c: Revert.
2110         * dcache.h: Revert.
2111         * dcache.c: Revert.
2112         * darwin-nat.h: Revert.
2113         * darwin-nat.c: Revert.
2114         * darwin-nat-info.c: Revert.
2115         * d-valprint.c: Revert.
2116         * d-namespace.c: Revert.
2117         * d-lang.c: Revert.
2118         * ctf.c: Revert.
2119         * csky-tdep.c: Revert.
2120         * csky-linux-tdep.c: Revert.
2121         * cris-tdep.c: Revert.
2122         * cris-linux-tdep.c: Revert.
2123         * cp-valprint.c: Revert.
2124         * cp-support.c: Revert.
2125         * cp-namespace.c: Revert.
2126         * cp-abi.c: Revert.
2127         * corelow.c: Revert.
2128         * corefile.c: Revert.
2129         * continuations.c: Revert.
2130         * completer.h: Revert.
2131         * completer.c: Revert.
2132         * complaints.c: Revert.
2133         * coffread.c: Revert.
2134         * coff-pe-read.c: Revert.
2135         * cli-out.h: Revert.
2136         * cli-out.c: Revert.
2137         * charset.c: Revert.
2138         * c-varobj.c: Revert.
2139         * c-valprint.c: Revert.
2140         * c-typeprint.c: Revert.
2141         * c-lang.c: Revert.
2142         * buildsym.c: Revert.
2143         * buildsym-legacy.c: Revert.
2144         * build-id.h: Revert.
2145         * build-id.c: Revert.
2146         * btrace.c: Revert.
2147         * bsd-uthread.c: Revert.
2148         * breakpoint.h: Revert.
2149         * breakpoint.c: Revert.
2150         * break-catch-throw.c: Revert.
2151         * break-catch-syscall.c: Revert.
2152         * break-catch-sig.c: Revert.
2153         * blockframe.c: Revert.
2154         * block.c: Revert.
2155         * bfin-tdep.c: Revert.
2156         * bfin-linux-tdep.c: Revert.
2157         * bfd-target.c: Revert.
2158         * bcache.c: Revert.
2159         * ax-general.c: Revert.
2160         * ax-gdb.h: Revert.
2161         * ax-gdb.c: Revert.
2162         * avr-tdep.c: Revert.
2163         * auxv.c: Revert.
2164         * auto-load.c: Revert.
2165         * arm-wince-tdep.c: Revert.
2166         * arm-tdep.c: Revert.
2167         * arm-symbian-tdep.c: Revert.
2168         * arm-pikeos-tdep.c: Revert.
2169         * arm-obsd-tdep.c: Revert.
2170         * arm-nbsd-tdep.c: Revert.
2171         * arm-nbsd-nat.c: Revert.
2172         * arm-linux-tdep.c: Revert.
2173         * arm-linux-nat.c: Revert.
2174         * arm-fbsd-tdep.c: Revert.
2175         * arm-fbsd-nat.c: Revert.
2176         * arm-bsd-tdep.c: Revert.
2177         * arch-utils.c: Revert.
2178         * arc-tdep.c: Revert.
2179         * arc-newlib-tdep.c: Revert.
2180         * annotate.h: Revert.
2181         * annotate.c: Revert.
2182         * amd64-windows-tdep.c: Revert.
2183         * amd64-windows-nat.c: Revert.
2184         * amd64-tdep.c: Revert.
2185         * amd64-sol2-tdep.c: Revert.
2186         * amd64-obsd-tdep.c: Revert.
2187         * amd64-obsd-nat.c: Revert.
2188         * amd64-nbsd-tdep.c: Revert.
2189         * amd64-nbsd-nat.c: Revert.
2190         * amd64-nat.c: Revert.
2191         * amd64-linux-tdep.c: Revert.
2192         * amd64-linux-nat.c: Revert.
2193         * amd64-fbsd-tdep.c: Revert.
2194         * amd64-fbsd-nat.c: Revert.
2195         * amd64-dicos-tdep.c: Revert.
2196         * amd64-darwin-tdep.c: Revert.
2197         * amd64-bsd-nat.c: Revert.
2198         * alpha-tdep.c: Revert.
2199         * alpha-obsd-tdep.c: Revert.
2200         * alpha-nbsd-tdep.c: Revert.
2201         * alpha-mdebug-tdep.c: Revert.
2202         * alpha-linux-tdep.c: Revert.
2203         * alpha-linux-nat.c: Revert.
2204         * alpha-bsd-tdep.c: Revert.
2205         * alpha-bsd-nat.c: Revert.
2206         * aix-thread.c: Revert.
2207         * agent.c: Revert.
2208         * addrmap.c: Revert.
2209         * ada-varobj.c: Revert.
2210         * ada-valprint.c: Revert.
2211         * ada-typeprint.c: Revert.
2212         * ada-tasks.c: Revert.
2213         * ada-lang.c: Revert.
2214         * aarch64-tdep.c: Revert.
2215         * aarch64-ravenscar-thread.c: Revert.
2216         * aarch64-newlib-tdep.c: Revert.
2217         * aarch64-linux-tdep.c: Revert.
2218         * aarch64-linux-nat.c: Revert.
2219         * aarch64-fbsd-tdep.c: Revert.
2220         * aarch64-fbsd-nat.c: Revert.
2221         * aarch32-linux-nat.c: Revert.
2222
2223 2019-04-05  Tom Tromey  <tom@tromey.com>
2224
2225         * ft32-tdep.c: Sort headers.
2226         * frv-tdep.c: Sort headers.
2227         * frv-linux-tdep.c: Sort headers.
2228         * frame.c: Sort headers.
2229         * frame-unwind.c: Sort headers.
2230         * frame-base.c: Sort headers.
2231         * fork-child.c: Sort headers.
2232         * findvar.c: Sort headers.
2233         * findcmd.c: Sort headers.
2234         * filesystem.c: Sort headers.
2235         * filename-seen-cache.h: Sort headers.
2236         * filename-seen-cache.c: Sort headers.
2237         * fbsd-tdep.c: Sort headers.
2238         * fbsd-nat.h: Sort headers.
2239         * fbsd-nat.c: Sort headers.
2240         * f-valprint.c: Sort headers.
2241         * f-typeprint.c: Sort headers.
2242         * f-lang.c: Sort headers.
2243         * extension.h: Sort headers.
2244         * extension.c: Sort headers.
2245         * extension-priv.h: Sort headers.
2246         * expprint.c: Sort headers.
2247         * exec.h: Sort headers.
2248         * exec.c: Sort headers.
2249         * exceptions.c: Sort headers.
2250         * event-top.c: Sort headers.
2251         * event-loop.c: Sort headers.
2252         * eval.c: Sort headers.
2253         * elfread.c: Sort headers.
2254         * dwarf2read.h: Sort headers.
2255         * dwarf2read.c: Sort headers.
2256         * dwarf2loc.c: Sort headers.
2257         * dwarf2expr.h: Sort headers.
2258         * dwarf2expr.c: Sort headers.
2259         * dwarf2-frame.c: Sort headers.
2260         * dwarf2-frame-tailcall.c: Sort headers.
2261         * dwarf-index-write.h: Sort headers.
2262         * dwarf-index-write.c: Sort headers.
2263         * dwarf-index-common.c: Sort headers.
2264         * dwarf-index-cache.h: Sort headers.
2265         * dwarf-index-cache.c: Sort headers.
2266         * dummy-frame.c: Sort headers.
2267         * dtrace-probe.c: Sort headers.
2268         * disasm.h: Sort headers.
2269         * disasm.c: Sort headers.
2270         * disasm-selftests.c: Sort headers.
2271         * dictionary.c: Sort headers.
2272         * dicos-tdep.c: Sort headers.
2273         * demangle.c: Sort headers.
2274         * dcache.h: Sort headers.
2275         * dcache.c: Sort headers.
2276         * darwin-nat.h: Sort headers.
2277         * darwin-nat.c: Sort headers.
2278         * darwin-nat-info.c: Sort headers.
2279         * d-valprint.c: Sort headers.
2280         * d-namespace.c: Sort headers.
2281         * d-lang.c: Sort headers.
2282         * ctf.c: Sort headers.
2283         * csky-tdep.c: Sort headers.
2284         * csky-linux-tdep.c: Sort headers.
2285         * cris-tdep.c: Sort headers.
2286         * cris-linux-tdep.c: Sort headers.
2287         * cp-valprint.c: Sort headers.
2288         * cp-support.c: Sort headers.
2289         * cp-namespace.c: Sort headers.
2290         * cp-abi.c: Sort headers.
2291         * corelow.c: Sort headers.
2292         * corefile.c: Sort headers.
2293         * continuations.c: Sort headers.
2294         * completer.h: Sort headers.
2295         * completer.c: Sort headers.
2296         * complaints.c: Sort headers.
2297         * coffread.c: Sort headers.
2298         * coff-pe-read.c: Sort headers.
2299         * cli-out.h: Sort headers.
2300         * cli-out.c: Sort headers.
2301         * charset.c: Sort headers.
2302         * c-varobj.c: Sort headers.
2303         * c-valprint.c: Sort headers.
2304         * c-typeprint.c: Sort headers.
2305         * c-lang.c: Sort headers.
2306         * buildsym.c: Sort headers.
2307         * buildsym-legacy.c: Sort headers.
2308         * build-id.h: Sort headers.
2309         * build-id.c: Sort headers.
2310         * btrace.c: Sort headers.
2311         * bsd-uthread.c: Sort headers.
2312         * breakpoint.h: Sort headers.
2313         * breakpoint.c: Sort headers.
2314         * break-catch-throw.c: Sort headers.
2315         * break-catch-syscall.c: Sort headers.
2316         * break-catch-sig.c: Sort headers.
2317         * blockframe.c: Sort headers.
2318         * block.c: Sort headers.
2319         * bfin-tdep.c: Sort headers.
2320         * bfin-linux-tdep.c: Sort headers.
2321         * bfd-target.c: Sort headers.
2322         * bcache.c: Sort headers.
2323         * ax-general.c: Sort headers.
2324         * ax-gdb.h: Sort headers.
2325         * ax-gdb.c: Sort headers.
2326         * avr-tdep.c: Sort headers.
2327         * auxv.c: Sort headers.
2328         * auto-load.c: Sort headers.
2329         * arm-wince-tdep.c: Sort headers.
2330         * arm-tdep.c: Sort headers.
2331         * arm-symbian-tdep.c: Sort headers.
2332         * arm-pikeos-tdep.c: Sort headers.
2333         * arm-obsd-tdep.c: Sort headers.
2334         * arm-nbsd-tdep.c: Sort headers.
2335         * arm-nbsd-nat.c: Sort headers.
2336         * arm-linux-tdep.c: Sort headers.
2337         * arm-linux-nat.c: Sort headers.
2338         * arm-fbsd-tdep.c: Sort headers.
2339         * arm-fbsd-nat.c: Sort headers.
2340         * arm-bsd-tdep.c: Sort headers.
2341         * arch-utils.c: Sort headers.
2342         * arc-tdep.c: Sort headers.
2343         * arc-newlib-tdep.c: Sort headers.
2344         * annotate.h: Sort headers.
2345         * annotate.c: Sort headers.
2346         * amd64-windows-tdep.c: Sort headers.
2347         * amd64-windows-nat.c: Sort headers.
2348         * amd64-tdep.c: Sort headers.
2349         * amd64-sol2-tdep.c: Sort headers.
2350         * amd64-obsd-tdep.c: Sort headers.
2351         * amd64-obsd-nat.c: Sort headers.
2352         * amd64-nbsd-tdep.c: Sort headers.
2353         * amd64-nbsd-nat.c: Sort headers.
2354         * amd64-nat.c: Sort headers.
2355         * amd64-linux-tdep.c: Sort headers.
2356         * amd64-linux-nat.c: Sort headers.
2357         * amd64-fbsd-tdep.c: Sort headers.
2358         * amd64-fbsd-nat.c: Sort headers.
2359         * amd64-dicos-tdep.c: Sort headers.
2360         * amd64-darwin-tdep.c: Sort headers.
2361         * amd64-bsd-nat.c: Sort headers.
2362         * alpha-tdep.c: Sort headers.
2363         * alpha-obsd-tdep.c: Sort headers.
2364         * alpha-nbsd-tdep.c: Sort headers.
2365         * alpha-mdebug-tdep.c: Sort headers.
2366         * alpha-linux-tdep.c: Sort headers.
2367         * alpha-linux-nat.c: Sort headers.
2368         * alpha-bsd-tdep.c: Sort headers.
2369         * alpha-bsd-nat.c: Sort headers.
2370         * aix-thread.c: Sort headers.
2371         * agent.c: Sort headers.
2372         * addrmap.c: Sort headers.
2373         * ada-varobj.c: Sort headers.
2374         * ada-valprint.c: Sort headers.
2375         * ada-typeprint.c: Sort headers.
2376         * ada-tasks.c: Sort headers.
2377         * ada-lang.c: Sort headers.
2378         * aarch64-tdep.c: Sort headers.
2379         * aarch64-ravenscar-thread.c: Sort headers.
2380         * aarch64-newlib-tdep.c: Sort headers.
2381         * aarch64-linux-tdep.c: Sort headers.
2382         * aarch64-linux-nat.c: Sort headers.
2383         * aarch64-fbsd-tdep.c: Sort headers.
2384         * aarch64-fbsd-nat.c: Sort headers.
2385         * aarch32-linux-nat.c: Sort headers.
2386
2387 2019-04-04  Tom Tromey  <tom@tromey.com>
2388
2389         * varobj.c (varobj_create): Update.
2390         * rust-exp.y (struct rust_parser) <update_innermost_block,
2391         lookup_symbol>: New methods.
2392         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2393         Rename.
2394         (rust_parser::rust_lookup_type)
2395         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2396         * printcmd.c (display_command, do_one_display): Update.
2397         * parser-defs.h (struct parser_state) <parser_state>: Add
2398         "tracker" parameter.
2399         (block_tracker): New member.
2400         (class innermost_block_tracker) <innermost_block_tracker>: Add
2401         "types" parameter.
2402         <reset>: Remove method.
2403         (innermost_block): Don't declare.
2404         (null_post_parser): Update.
2405         * parse.c (innermost_block): Remove global.
2406         (write_dollar_variable): Update.
2407         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2408         Remove "tracker_types" parameter.
2409         (parse_expression): Add "tracker" parameter.
2410         (parse_expression_for_completion): Update.
2411         (null_post_parser): Add "tracker" parameter.
2412         * p-exp.y: Update rules.
2413         * m2-exp.y: Update rules.
2414         * language.h (struct language_defn) <la_post_parser>: Add
2415         "tracker" parameter.
2416         * go-exp.y: Update rules.
2417         * f-exp.y: Update rules.
2418         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2419         parameter.
2420         * d-exp.y: Update rules.
2421         * c-exp.y: Update rules.
2422         * breakpoint.c (set_breakpoint_condition): Create an
2423         innermost_block_tracker.
2424         (watch_command_1): Likewise.
2425         * ada-lang.c (resolve): Add "tracker" parameter.
2426         (resolve_subexp): Likewise.
2427         * ada-exp.y (write_var_from_sym): Update.
2428
2429 2019-04-04  Tom Tromey  <tom@tromey.com>
2430
2431         * type-stack.h: New file.
2432         * type-stack.c: New file.
2433         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2434         type-stack.h.
2435         (insert_into_type_stack, insert_type, push_type, push_type_int)
2436         (insert_type_address_space, pop_type, pop_type_int)
2437         (pop_typelist, pop_type_stack, append_type_stack)
2438         (push_type_stack, get_type_stack, push_typelist)
2439         (follow_type_instance_flags, follow_types): Don't declare.
2440         * parse.c (type_stack): Remove global.
2441         (parse_exp_in_context): Update.
2442         (insert_into_type_stack, insert_type, push_type, push_type_int)
2443         (insert_type_address_space, pop_type, pop_type_int)
2444         (pop_typelist, pop_type_stack, append_type_stack)
2445         (push_type_stack, get_type_stack, push_typelist)
2446         (follow_type_instance_flags, follow_types): Remove (moved to
2447         type-stack.c).
2448         * f-exp.y (type_stack): New global.
2449         Update rules.
2450         (push_kind_type, f_parse): Update.
2451         * d-exp.y (type_stack): New global.
2452         Update rules.
2453         (d_parse): Update.
2454         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2455         Update rules.
2456         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2457         (HFILES_NO_SRCDIR): Add type-stack.h.
2458
2459 2019-04-04  Tom Tromey  <tom@tromey.com>
2460
2461         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2462         (rust_parser::convert_ast_to_expression, rust_parse)
2463         (rust_lex_test_completion, rust_lex_tests): Update.
2464         * parser-defs.h (struct expr_completion_state): New.
2465         (struct parser_state) <parser_state>: Add completion parameter.
2466         <mark_struct_expression, mark_completion_tag>: New methods.
2467         <parse_completion, m_completion_state>: New members.
2468         (prefixify_expression, null_post_parser): Update.
2469         (mark_struct_expression, mark_completion_tag): Don't declare.
2470         * parse.c (parse_completion, expout_last_struct)
2471         (expout_tag_completion_type, expout_completion_name): Remove
2472         globals.
2473         (parser_state::mark_struct_expression)
2474         (parser_state::mark_completion_tag): Now methods.
2475         (prefixify_expression): Add last_struct parameter.
2476         (prefixify_subexp): Likewise.
2477         (parse_exp_1): Update.
2478         (parse_exp_in_context): Add cstate parameter.  Update.
2479         (parse_expression_for_completion): Create an
2480         expr_completion_state.
2481         (null_post_parser): Add "completion" parameter.
2482         * p-exp.y: Update rules.
2483         (yylex): Update.
2484         * language.h (struct language_defn) <la_post_parser>: Add
2485         "completing" parameter.
2486         * go-exp.y: Update rules.
2487         (lex_one_token): Update.
2488         * expression.h (parse_completion): Don't declare.
2489         * d-exp.y: Update rules.
2490         (lex_one_token): Update rules.
2491         * c-exp.y: Update rules.
2492         (lex_one_token): Update.
2493         * ada-lang.c (resolve): Add "parse_completion" parameter.
2494         (resolve_subexp): Likewise.
2495         (ada_resolve_function): Likewise.
2496
2497 2019-04-04  Tom Tromey  <tom@tromey.com>
2498
2499         * parser-defs.h (struct parser_state) <start_arglist,
2500         end_arglist>: New methods.
2501         <arglist_len, m_funcall_chain>: New members.
2502         (arglist_len, start_arglist, end_arglist): Don't declare.
2503         * parse.c (arglist_len, funcall_chain): Remove global.
2504         (start_arglist, end_arglist): Remove functions.
2505         (parse_exp_in_context): Update.
2506         * p-exp.y: Update rules.
2507         * m2-exp.y: Update rules.
2508         * go-exp.y: Update rules.
2509         * f-exp.y: Update rules.
2510         * d-exp.y: Update rules.
2511         * c-exp.y: Update rules.
2512
2513 2019-04-04  Tom Tromey  <tom@tromey.com>
2514
2515         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2516         lex_operator, push_back>: New methods.
2517         Update all rules.
2518         (rust_parser::lex_hex, lex_escape): Rename and update.
2519         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2520         (rust_parser::lex_operator): Rename and update.
2521         (rust_parser::lex_number, rustyylex, rustyyerror)
2522         (rust_lex_test_init, rust_lex_test_sequence)
2523         (rust_lex_test_push_back, rust_lex_tests): Update.
2524         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2525         parameter.
2526         <lexptr, prev_lexptr>: New members.
2527         (lexptr, prev_lexptr): Don't declare.
2528         * parse.c (lexptr, prev_lexptr): Remove globals.
2529         (parse_exp_in_context): Update.
2530         * p-exp.y (yylex, yyerror): Update.
2531         * m2-exp.y (parse_number, yylex, yyerror): Update.
2532         * go-exp.y (lex_one_token, yyerror): Update.
2533         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2534         * d-exp.y (lex_one_token, yyerror): Update.
2535         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2536         (lex_one_token, yyerror): Update.
2537         * ada-lex.l (YY_INPUT): Update.
2538         (rewind_to_char): Update.
2539         * ada-exp.y (yyerror): Update.
2540
2541 2019-04-04  Tom Tromey  <tom@tromey.com>
2542
2543         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2544         * parser-defs.h (struct parser_state) <parser_state>: Add new
2545         parameter.
2546         <comma_terminates>: New member.
2547         (comma_terminates): Don't declare global.
2548         * parse.c (comma_terminates): Remove global.
2549         (parse_exp_in_context): Update.
2550         * p-exp.y (yylex): Update.
2551         * m2-exp.y (yylex): Update.
2552         * go-exp.y (lex_one_token): Update.
2553         * f-exp.y (yylex): Update.
2554         * d-exp.y (lex_one_token): Update.
2555         * c-exp.y (lex_one_token): Update.
2556         * ada-lex.l: Update.
2557
2558 2019-04-04  Tom Tromey  <tom@tromey.com>
2559
2560         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2561         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2562         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2563         * parser-defs.h (paren_depth): Don't declare.
2564         * parse.c (paren_depth): Remove global.
2565         (parse_exp_in_context): Update.
2566         * p-exp.y (paren_depth): New global.
2567         (pascal_parse): Initialize it.
2568         * m2-exp.y (paren_depth): New global.
2569         (m2_parse): Initialize it.
2570         * go-exp.y (paren_depth): New global.
2571         (go_parse): Initialize it.
2572         * f-exp.y (paren_depth): New global.
2573         (f_parse): Initialize it.
2574         * d-exp.y (paren_depth): New global.
2575         (d_parse): Initialize it.
2576         * c-exp.y (paren_depth): New global.
2577         (c_parse): Initialize it.
2578         * ada-lex.l (paren_depth): New global.
2579         (lexer_init): Initialize it.
2580
2581 2019-04-04  Tom Tromey  <tom@tromey.com>
2582
2583         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2584         (rust_parser::convert_ast_to_type)
2585         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2586         * parser-defs.h (struct parser_state) <parser_state>: Add
2587         parameters.  Initialize new members.
2588         <expression_context_block, expression_context_pc>: New members.
2589         * parse.c (expression_context_block, expression_context_pc):
2590         Remove globals.
2591         (parse_exp_in_context): Update.
2592         * p-exp.y: Update all rules.
2593         (yylex): Update.
2594         * m2-exp.y: Update all rules.
2595         (yylex): Update.
2596         * go-exp.y (yylex): Update.
2597         * f-exp.y (yylex): Update.
2598         * d-exp.y: Update all rules.
2599         (yylex): Update.
2600         * c-exp.y: Update all rules.
2601         (lex_one_token, classify_name, yylex, c_parse): Update.
2602         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2603
2604 2019-04-04  Tom Tromey  <tom@tromey.com>
2605
2606         * gdbarch.h, gdbarch.c: Rebuild.
2607         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2608         * stap-probe.h:
2609         (struct stap_parse_info): Replace "parser_state" with
2610         "expr_builder".
2611         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2612         (parser_state): New class.
2613         * parse.c (expr_builder): Rename.
2614         (expr_builder::release): Rename.
2615         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2616         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2617         (write_exp_elt_longcst, write_exp_elt_floatcst)
2618         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2619         (write_exp_string_vector, write_exp_bitstring)
2620         (write_exp_msymbol, mark_struct_expression)
2621         (write_dollar_variable)
2622         (insert_type_address_space, increase_expout_size): Replace
2623         "parser_state" with "expr_builder".
2624         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2625         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2626         "parser_state" with "expr_builder".
2627
2628 2019-04-04  Tom Tromey  <tom@tromey.com>
2629
2630         * rust-exp.y: Replace "parse_language" with method call.
2631         * p-exp.y:
2632         (yylex): Replace "parse_language" with method call.
2633         * m2-exp.y:
2634         (yylex): Replace "parse_language" with method call.
2635         * go-exp.y (classify_name): Replace "parse_language" with method
2636         call.
2637         * f-exp.y (yylex): Replace "parse_language" with method call.
2638         * d-exp.y (lex_one_token): Replace "parse_language" with method
2639         call.
2640         * c-exp.y:
2641         (lex_one_token, classify_name, yylex): Replace "parse_language"
2642         with method call.
2643         * ada-exp.y (find_primitive_type, type_char)
2644         (type_system_address): Replace "parse_language" with method call.
2645
2646 2019-04-04  Tom Tromey  <tom@tromey.com>
2647
2648         * rust-exp.y: Replace "parse_gdbarch" with method call.
2649         * parse.c (write_dollar_variable, insert_type_address_space):
2650         Replace "parse_gdbarch" with method call.
2651         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2652         call.
2653         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2654         call.
2655         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2656         "parse_gdbarch" with method call.
2657         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2658         with method call.
2659         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2660         "parse_gdbarch" with method call.
2661         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2662         "parse_gdbarch" with method call.
2663         * c-exp.y (parse_type, parse_number, classify_name): Replace
2664         "parse_gdbarch" with method call.
2665         * ada-lex.l: Replace "parse_gdbarch" with method call.
2666         * ada-exp.y (parse_type, find_primitive_type, type_char)
2667         (type_system_address): Replace "parse_gdbarch" with method call.
2668
2669 2019-04-04  Tom Tromey  <tom@tromey.com>
2670
2671         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2672         * stap-probe.c (stap_parse_argument): Update.
2673         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2674         initial_size parameter.
2675         * rust-exp.y (rust_lex_tests): Update.
2676         * parse.c (parser_state): Update.
2677         (parse_exp_in_context): Update.
2678         * parser-defs.h (struct parser_state) <parser_state>: Remove
2679         "initial_size" parameter.
2680
2681 2019-04-04  Tom Tromey  <tom@tromey.com>
2682
2683         * parser-defs.h (increase_expout_size): Don't declare.
2684         * parse.c (increase_expout_size): Now static.
2685
2686 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2687
2688         * gnu-nat.c (gnu_nat_target::wait): Fix
2689         target_waitstatus_to_string call.
2690
2691 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2692
2693         * eval.c (evaluate_subexp_standard): Handle internal functions
2694         during Fortran function call handling.
2695
2696 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2697
2698         * NEWS: Mention new internal functions.
2699         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2700         (read_base_type): Use dwarf2_init_complex_target_type.
2701         * value.c (creal_internal_fn): New function.
2702         (cimag_internal_fn): New function.
2703         (_initialize_values): Register new internal functions.
2704
2705 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2706
2707         * infrun.c (stop_all_threads): If debug_infrun, always
2708         trace the wait status after wait_one, using
2709         target_waitstatus_to_string and target_pid_to_str.
2710         (handle_inferior_event): Replace various trace of
2711         wait status kind by a single trace.
2712         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2713         wait status kind image by target_waitstatus_to_string.
2714         * target/waitstatus.c (target_waitstatus_to_string): Fix
2715         obsolete comment.
2716
2717 2019-04-01  Tom Tromey  <tromey@adacore.com>
2718
2719         PR symtab/23331:
2720         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2721
2722 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2723             Pedro Alves  <palves@redhat.com>
2724
2725         * top.c (quit_force): Call 'finalize_values'.
2726         * value.c (finalize_values): New function.
2727         * value.h (finalize_values): Declare.
2728
2729 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2730
2731         * NEWS: Announce $_gdb_major and $_gdb_minor.
2732
2733         * top.c (init_gdb_version_vars): New function.
2734         (gdb_init): Call init_gdb_version_vars.
2735
2736 2019-03-29  Tom Tromey  <tromey@adacore.com>
2737
2738         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2739         help text.  Remove dead code.
2740
2741 2019-03-29  Keith Seitz  <keiths@redhat.com>
2742
2743         From Siddhesh Poyarekar:
2744         * f-lang.h (f77_get_upperbound): Return LONGEST.
2745         (f77_get_lowerbound): Likewise.
2746         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2747         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2748         print them.
2749         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2750         plongest to format print it.
2751         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2752         (f77_get_upperbound): Likewise.
2753         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2754         LOWER_BOUND to LONGEST.
2755         (f77_create_arrayprint_offset_tbl): Likewise.
2756
2757 2019-03-29  Keith Seitz  <keiths@redhat.com>
2758
2759         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2760         %s/pulongest for TYPE_LENGTH instead of %d in format
2761         strings.
2762         * ada-typerint.c (ada_print_type): Likewise.
2763         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2764         * compile/compile-c-support.c (generate_register_struct): Likewise.
2765         * gdbtypes.c (recursive_dump_type): Likewise.
2766         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2767         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2768         instead of %d in format strings.
2769         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2770         to std::min to ULONGEST.
2771         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2772         instead of %d in format strings.
2773         * tracepoint.c (info_scope_command): Likewise.
2774         * typeprint.c (print_offset_data::update)
2775         (print_offset_data::finish): Likewise.
2776         * xtensa-tdep.c (xtensa_store_return_value)
2777         (xtensa_push_dummy_call): Likewise.
2778
2779 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2780
2781         * windows-nat.c (display_selector): Fixed format specifications
2782         for 64-bit Cygwin.
2783
2784 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2785
2786         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2787
2788 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2789
2790         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2791         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2792         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2793         (nios2_linux_init_abi): Install it.
2794
2795 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2796
2797         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2798
2799 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2800
2801         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2802
2803 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2804             Tom Tromey  <tromey@adacore.com>
2805
2806         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2807
2808 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2809
2810         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2811         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2812         method to compute the bounds of range types. Also print "[evaluated]"
2813         if the bounds' values come from a dynamic evaluation.
2814
2815 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2816
2817         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2818         whitespace when pretty printing is on.
2819
2820 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2821
2822         * ppc-linux-nat.c: Add include.
2823
2824 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2825
2826         * NEWS: Mention AArch64 Pointer Authentication.
2827
2828 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2829
2830         * arm-linux-nat.c: Add include.
2831
2832 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2833
2834         * source-cache.c (source_cache::get_source_lines): Re-read
2835         fullname after calling open_source_file.
2836
2837 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2838
2839         * NEWS: Mention TLS support for FreeBSD.
2840
2841 2019-03-25  Tom Tromey  <tromey@adacore.com>
2842
2843         * minsyms.c (BUNCH_SIZE): Update comment.
2844         (~minimal_symbol_reader): Remove old comment.
2845         (compact_minimal_symbols): Update comment.
2846         (minimal_symbol_reader::install): Remove old comment.  Update
2847         other comments.
2848
2849 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2850
2851         * s390-linux-nat.c: Add include.
2852
2853 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2854
2855         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2856         Call linux_get_hwcap.
2857         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2858         Likewise.
2859         (aarch64_linux_get_hwcap): Remove function.
2860         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2861         declaration.
2862         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2863         linux_get_hwcap.
2864         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2865         * linux-tdep.c (linux_get_hwcap): Add function.
2866         (linux_get_hwcap2): Likewise.
2867         * linux-tdep.h (linux_get_hwcap): Add declaration.
2868         (linux_get_hwcap2): Likewise.
2869         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2870         (ppc_linux_get_hwcap2): Likewise.
2871         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2872         linux_get_hwcap.
2873         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2874         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2875         (ppc_linux_nat_target::read_description): Likewise.
2876         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2877         * s390-linux-nat.c: Likewise.
2878         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2879
2880 2019-03-24  Tom Tromey  <tom@tromey.com>
2881
2882         * ada-lang.c (standard_lookup): Simplify initialization.
2883         (ada_lookup_symbol_nonlocal): Simplify return.
2884         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2885         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2886         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2887         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2888         initialization.
2889         * solib.c (solib_global_lookup): Simplify.
2890         * symtab.c (null_block_symbol): Remove.
2891         (symbol_cache_lookup): Simplify returns.
2892         (lookup_language_this): Simplify returns.
2893         (lookup_symbol_aux): Simplify return.
2894         (lookup_local_symbol): Simplify returns.
2895         (lookup_global_symbol_from_objfile): Simplify return.
2896         (lookup_symbol_in_objfile_symtabs)
2897         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2898         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2899         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2900         * cp-namespace.c (cp_lookup_bare_symbol)
2901         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2902         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2903         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2904         (cp_lookup_symbol_via_imports): Simplify initialization.
2905         (find_symbol_in_baseclass): Likewise.
2906         * symtab.h (null_block_symbol): Remove.
2907         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2908         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2909         (d_lookup_symbol_module): Likewise.
2910         (find_symbol_in_baseclass): Simplify initialization.
2911
2912 2019-03-24  Tom Tromey  <tom@tromey.com>
2913
2914         * expression.h: Don't include symtab.h.
2915         (struct block): Forward declare.
2916
2917 2019-03-24  Tom Tromey  <tom@tromey.com>
2918
2919         * c-exp.y (typebase): Remove casts.
2920         * gdbtypes.c (lookup_unsigned_typename, )
2921         (lookup_signed_typename): Remove cast.
2922         * eval.c (parse_to_comma_and_eval): Remove cast.
2923         * parse.c (write_dollar_variable): Remove cast.
2924         * block.h (struct block) <superblock>: Now const.
2925         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2926         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2927         (map_block): Make "block" const.
2928         * symfile.h (struct quick_symbol_functions)
2929         <map_matching_symbols>: Constify block argument to "callback".
2930         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2931         const.
2932         (find_pc_sect_compunit_symtab): Make "b" const.
2933         (find_symbol_at_address): Likewise.
2934         (search_symbols): Likewise.
2935         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2936         (dw2_debug_names_lookup_symbol): Likewise.
2937         (dw2_map_matching_symbols): Update.
2938         * p-valprint.c (pascal_val_print): Remove "block".
2939         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2940         (aux_add_nonlocal_symbols): Make "block" const.
2941         (resolve_subexp): Remove cast.
2942         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2943         const.
2944         (iterate_over_file_blocks): Likewise.
2945         * f-exp.y (%union) <bval>: Remove.
2946         * coffread.c (patch_opaque_types): Make "b" const.
2947         * spu-tdep.c (spu_catch_start): Make "block" const.
2948         * c-valprint.c (print_unpacked_pointer): Remove "block".
2949         * symmisc.c (dump_symtab_1): Make "b" const.
2950         (block_depth): Make "block" const.
2951         * d-exp.y (%union) <bval>: Remove.
2952         * cp-support.h (cp_lookup_rtti_type): Update.
2953         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2954         * psymtab.c (psym_lookup_symbol): Make "block" const.
2955         (maintenance_check_psymtabs): Make "b" const.
2956         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2957         (enumerate_locals, enumerate_args): Update.
2958         * python/py-symtab.c (stpy_global_block): Make "block" const.
2959         (stpy_static_block): Likewise.
2960         * inline-frame.c (block_starting_point_at): Make "new_block"
2961         const.
2962         * block.c (find_block_in_blockvector): Make return type const.
2963         (blockvector_for_pc_sect): Make "b" const.
2964         (find_block_in_blockvector): Make "b" const.
2965
2966 2019-03-23  Tom Tromey  <tom@tromey.com>
2967
2968         * varobj.c (varobj_create): Update.
2969         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2970         * printcmd.c (display_command, do_one_display): Don't reset
2971         innermost_block.
2972         * parser-defs.h (enum innermost_block_tracker_type): Move to
2973         expression.h.
2974         (innermost_block): Update comment.
2975         * parse.c (parse_exp_1): Add tracker_types parameter.
2976         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2977         tracker_types parameter.  Reset innermost_block.
2978         (parse_exp_in_context): Remove.
2979         (parse_expression_for_completion): Update.
2980         * objfiles.c (~objfile): Don't reset expression_context_block or
2981         innermost_block.
2982         * expression.h (enum innermost_block_tracker_type): Move from
2983         parser-defs.h.
2984         (parse_exp_1): Add tracker_types parameter.
2985         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2986         reset innermost_block.
2987
2988 2019-03-23  Tom Tromey  <tom@tromey.com>
2989
2990         * objfiles.h: Include bcache.h.
2991
2992 2019-03-23  Tom Tromey  <tom@tromey.com>
2993
2994         * linespec.c (get_current_search_block): Use
2995         scoped_restore_current_language.
2996         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2997
2998 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2999             Jiong Wang  <jiong.wang@arm.com>
3000
3001         * aarch64-linux-tdep.c
3002         (aarch64_linux_iterate_over_regset_sections): Check for pauth
3003         section.
3004         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
3005
3006 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3007             Jiong Wang  <jiong.wang@arm.com>
3008
3009         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
3010         instructions.
3011         (aarch64_analyze_prologue_test): Add PACIASP test.
3012         (aarch64_prologue_prev_register): Unmask PC value.
3013
3014 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3015             Jiong Wang  <jiong.wang@arm.com>
3016
3017         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
3018         (aarch64_dwarf2_prev_register): Unmask PC value.
3019         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
3020         (aarch64_execute_dwarf_cfa_vendor_op): Check for
3021         DW_CFA_AARCH64_negate_ra_state.
3022         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
3023
3024 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3025             Jiong Wang  <jiong.wang@arm.com>
3026
3027         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
3028         registers.
3029         (aarch64_pseudo_register_name): Likewise.
3030         (aarch64_pseudo_register_type): Likewise.
3031         (aarch64_pseudo_register_reggroup_p): Likewise.
3032         (aarch64_gdbarch_init): Add pauth registers.
3033         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
3034         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
3035         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
3036         (struct gdbarch_tdep): Add regnum for ra_state.
3037
3038 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3039             Jiong Wang  <jiong.wang@arm.com>
3040
3041         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
3042
3043 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3044             Jiong Wang  <jiong.wang@arm.com>
3045
3046         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
3047         function.
3048         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
3049         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
3050         (aarch64_gdbarch_init): Add puth registers.
3051         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
3052         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
3053         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
3054
3055 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3056             Jiong Wang  <jiong.wang@arm.com>
3057
3058         * aarch64-linux-nat.c
3059         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
3060         * aarch64-linux-tdep.c
3061         (aarch64_linux_core_read_description): Likewise.
3062         (aarch64_linux_get_hwcap): New function.
3063         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
3064         (aarch64_linux_get_hwcap): New declaration.
3065
3066 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3067             Jiong Wang  <jiong.wang@arm.com>
3068
3069         * aarch64-linux-nat.c
3070         (aarch64_linux_nat_target::read_description): Add pauth param.
3071         * aarch64-linux-tdep.c
3072         (aarch64_linux_core_read_description): Likewise.
3073         * aarch64-tdep.c (struct target_desc): Add in pauth.
3074         (aarch64_read_description): Add pauth param.
3075         (aarch64_gdbarch_init): Likewise.
3076         * aarch64-tdep.h (aarch64_read_description): Likewise.
3077         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3078         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3079         * features/Makefile: Add new files.
3080         * features/aarch64-pauth.c: New file.
3081         * features/aarch64-pauth.xml: New file.
3082
3083 2019-03-20  Tom Tromey  <tromey@adacore.com>
3084
3085         * infrun.c (handle_inferior_event): Rename from
3086         handle_inferior_event_1.  Create a scoped_value_mark.
3087         (handle_inferior_event): Remove.
3088
3089 2019-03-19  Tom Tromey  <tromey@adacore.com>
3090
3091         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3092         * infrun.h (print_stop_event): Add "displays" parameter.
3093         * infrun.c (print_stop_event): Add "displays" parameter.
3094
3095 2019-03-19  Pedro Alves  <palves@redhat.com>
3096
3097         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3098         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3099         to -1.  Fix TABs vs spaces.
3100         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3101         * tui/tui-out.h (tui_ui_out) Add intro comments.
3102         <m_line, m_start_of_line>: In-class initialize, and add describing
3103         comment.
3104
3105 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3106
3107         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3108         variable names.
3109         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3110
3111 2019-03-18  Pedro Alves  <palves@redhat.com>
3112             Eli Zaretskii <eliz@gnu.org>
3113
3114         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3115         m_line and m_start_of_line.
3116
3117 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3118
3119         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3120         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3121         it returns a newline.  This fixes a regression in TU mode, whereby
3122         the next line is output on the same screen line as the user input.
3123
3124 2019-03-18  Tom Tromey  <tromey@adacore.com>
3125
3126         * minsyms.c (minimal_symbol_reader::install): Remove call to
3127         obstack_blank.
3128
3129 2019-03-18  Pedro Alves  <palves@redhat.com>
3130
3131         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3132         New globals.
3133         (apply_style): New, factored out from ...
3134         (apply_ansi_escape): ... this.  Handle reverse video mode.
3135         (tui_set_reverse_mode): New function.
3136         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3137         * tui/tui-winsource.c (tui_show_source_line): Use
3138         tui_set_reverse_mode instead of setting A_STANDOUT.
3139         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3140         New setter methods.
3141
3142 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3143
3144         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3145         Handle tabs.
3146
3147 2019-03-18  Tom Tromey  <tromey@adacore.com>
3148
3149         * ada-lang.c (empty_array): Add "high" parameter.
3150         (ada_evaluate_subexp): Update.
3151
3152 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3153
3154         * unittests/string_view-selftests.c: Define
3155         _initialize_string_view_selftests unconditionally.
3156
3157 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3158
3159         PR gdb/24350
3160         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3161
3162 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3163
3164         PR gdb/24351
3165         * windows-nat.c (display_selector): Fix format specifiers.
3166
3167 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3168
3169         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3170         tui_refill_source_window instead of tui_refresh_win, to update the
3171         current execution line.  This fixes redisplay of the current line
3172         when stepping through the code with "next" or "step".
3173
3174 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3175
3176         * source-cache.c (source_cache::get_source_lines): Call
3177         find_source_lines to initialize s->nlines.  This fixes vertical
3178         scrolling of TUI source window when the DOWN arrow is pressed.
3179
3180 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3181
3182         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3183         linux-thread-db.c (_initialize_thread_db): Likewise.
3184
3185 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3186
3187         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3188         wclrtoeol in tui_show_source_line".  This reverts changes made in
3189         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3190
3191 2019-03-15  Tom Tromey  <tom@tromey.com>
3192
3193         * symtab.h (struct minimal_symbol): Derive from
3194         general_symbol_info.
3195         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3196         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3197         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3198         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3199         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3200         (MSYMBOL_SEARCH_NAME): Update.
3201         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3202         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3203         * minsyms.c (minimal_symbol_reader::record_full): Update.
3204
3205 2019-03-15  Tom Tromey  <tom@tromey.com>
3206
3207         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3208
3209 2019-03-15  Tom Tromey  <tom@tromey.com>
3210
3211         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3212         unique_xmalloc_ptr.
3213         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3214         Update.
3215         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3216         (build_minimal_symbol_hash_tables)
3217         (minimal_symbol_reader::install): Update.
3218
3219 2019-03-15  Tom Tromey  <tom@tromey.com>
3220
3221         * symtab.c (create_demangled_names_hash): Update.
3222         (symbol_set_names): Update.
3223         * objfiles.h (struct objfile_per_bfd_storage)
3224         <demangled_names_hash>: Now an htab_up.
3225         * objfiles.c (objfile_per_bfd_storage): Simplify.
3226
3227 2019-03-15  Tom Tromey  <tom@tromey.com>
3228
3229         * objfiles.h (struct objfile_per_bfd_storage): Declare
3230         destructor.
3231         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3232         New.
3233         (get_objfile_bfd_data): Use new.  Don't initialize
3234         language_of_main.
3235         (free_objfile_per_bfd_storage): Remove.
3236         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3237
3238 2019-03-15  Tom Tromey  <tom@tromey.com>
3239
3240         * symfile.c (reread_symbols): Update.
3241         * objfiles.c (objfile::objfile): Update.
3242         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3243         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3244         comment.
3245         (minimal_symbol_reader::install): Update.
3246         (terminate_minimal_symbol_table): Remove.
3247         * jit.c (jit_object_close_impl): Update.
3248
3249 2019-03-15  Tom Tromey  <tom@tromey.com>
3250
3251         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3252         initializations.
3253
3254 2019-03-15  Tom Tromey  <tom@tromey.com>
3255
3256         * objfiles.h (struct objfile_per_bfd_storage)
3257         <demangled_hash_languages>: Now a bitset.
3258         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3259         (lookup_minimal_symbol): Update.
3260
3261 2019-03-15  Tom Tromey  <tom@tromey.com>
3262
3263         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3264         Don't return the symbol.
3265         * coffread.c (record_minimal_symbol): Use record_full.
3266
3267 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3268
3269         The MS-Windows port of ncurses fails to switch to a color pair if
3270         one or both of the colors are the implicit default colors.  This
3271         change records the default colors when TUI is initialized, and
3272         then specifies them explicitly when a color pair uses the default
3273         colors.  This allows color styling in TUI mode on MS-Windows.
3274
3275         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3276         ncurses_norm_attr.
3277         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3278         colors in ncurses_norm_attr.
3279         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3280         "none", replace it with the default color recorded in
3281         ncurses_norm_attr.
3282
3283 2019-03-14  Tom Tromey  <tromey@adacore.com>
3284
3285         * source-cache.h (class source_cache) <get_source_lines>: Return
3286         std::string.
3287         * source-cache.c (source_cache::extract_lines): Handle case where
3288         first_pos==npos.  Return std::string.
3289         (source_cache::get_source_lines): Update.
3290
3291 2019-03-14  Tom Tromey  <tromey@adacore.com>
3292
3293         * NEWS: Add item for "style sources" commands.
3294         * source-cache.c (source_cache::get_source_lines): Check
3295         source_styling.
3296         * cli/cli-style.c (source_styling): New global.
3297         (_initialize_cli_style): Add "style sources" commands.
3298         (show_style_sources): New function.
3299         * cli/cli-style.h (source_styling): Declare.
3300
3301 2019-03-14  Pedro Alves  <palves@redhat.com>
3302             Tom Tromey  <tromey@adacore.com>
3303
3304         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3305         * tui/tui-winsource.c (tui_refill_source_window): New function,
3306         from...
3307         (tui_horizontal_source_scroll): ... here.  Move some logic.
3308         * cli/cli-style.c (set_style_enabled): Notify new observable.
3309         * tui/tui-hooks.c (tui_redisplay_source): New function.
3310         (tui_attach_detach_observers): Attach or detach
3311         tui_redisplay_source.
3312         * observable.h (source_styling_changed): New observable.
3313         * observable.c: Define source_styling_changed observable.
3314
3315 2019-03-13  Tom Tromey  <tromey@adacore.com>
3316
3317         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3318         (i386_gnu_nat_target::store_registers): Update.
3319         * target-debug.h (target_debug_print_std_string): New macro.
3320         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3321         * windows-tdep.c (display_one_tib): Update.
3322         * tui/tui-stack.c (tui_make_status_line): Update.
3323         * top.c (print_inferior_quit_action): Update.
3324         * thread.c (thr_try_catch_cmd): Update.
3325         (add_thread_with_info): Update.
3326         (thread_target_id_str): Update.
3327         (thr_try_catch_cmd): Update.
3328         (thread_command): Update.
3329         (thread_find_command): Update.
3330         * record-btrace.c (record_btrace_target::info_record)
3331         (record_btrace_resume_thread, record_btrace_target::resume)
3332         (record_btrace_cancel_resume, record_btrace_step_thread)
3333         (record_btrace_target::wait, record_btrace_target::wait)
3334         (record_btrace_target::wait, record_btrace_target::stop): Update.
3335         * progspace.c (print_program_space): Update.
3336         * process-stratum-target.c
3337         (process_stratum_target::thread_address_space): Update.
3338         * linux-fork.c (linux_fork_mourn_inferior)
3339         (detach_checkpoint_command, info_checkpoints_command)
3340         (linux_fork_context): Update.
3341         (linux_fork_detach): Update.
3342         (class scoped_switch_fork_info): Update.
3343         (delete_checkpoint_command): Update.
3344         * infrun.c (follow_fork_inferior): Update.
3345         (follow_fork_inferior): Update.
3346         (proceed_after_vfork_done): Update.
3347         (handle_vfork_child_exec_or_exit): Update.
3348         (follow_exec): Update.
3349         (displaced_step_prepare_throw): Update.
3350         (displaced_step_restore): Update.
3351         (start_step_over): Update.
3352         (resume_1): Update.
3353         (clear_proceed_status_thread): Update.
3354         (proceed): Update.
3355         (print_target_wait_results): Update.
3356         (do_target_wait): Update.
3357         (context_switch): Update.
3358         (stop_all_threads): Update.
3359         (restart_threads): Update.
3360         (finish_step_over): Update.
3361         (handle_signal_stop): Update.
3362         (switch_back_to_stepped_thread): Update.
3363         (keep_going_pass_signal): Update.
3364         (print_exited_reason): Update.
3365         (normal_stop): Update.
3366         * inferior.c (inferior_pid_to_str): Change return type.
3367         (print_selected_inferior): Update.
3368         (add_inferior): Update.
3369         (detach_inferior): Update.
3370         * dummy-frame.c (fprint_dummy_frames): Update.
3371         * dcache.c (dcache_info_1): Update.
3372         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3373         (btrace_fetch, btrace_clear): Update.
3374         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3375         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3376         type.
3377         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3378         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3379         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3380         * gdbarch.c, gdbarch.h: Rebuild.
3381         * gdbarch.sh (core_pid_to_str): Change return type.
3382         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3383         return type.
3384         (windows_nat_target::pid_to_str): Change return type.
3385         (windows_delete_thread): Update.
3386         (windows_nat_target::attach): Update.
3387         (windows_nat_target::files_info): Update.
3388         * target-delegates.c: Rebuild.
3389         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3390         return type.
3391         (sol_thread_target::pid_to_str): Change return type.
3392         * remote.c (class remote_target) <pid_to_str>: Change return
3393         type.
3394         (remote_target::pid_to_str): Change return type.
3395         (extended_remote_target::attach, remote_target::remote_stop_ns)
3396         (remote_target::remote_notif_remove_queued_reply)
3397         (remote_target::push_stop_reply, remote_target::disable_btrace):
3398         Update.
3399         (extended_remote_target::attach): Update.
3400         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3401         type.
3402         (gdbsim_target::pid_to_str): Change return type.
3403         * ravenscar-thread.c (struct ravenscar_thread_target)
3404         <pid_to_str>: Change return type.
3405         (ravenscar_thread_target::pid_to_str): Change return type.
3406         * procfs.c (class procfs_target) <pid_to_str>: Change return
3407         type.
3408         (procfs_target::pid_to_str): Change return type.
3409         (procfs_target::attach): Update.
3410         (procfs_target::detach): Update.
3411         (procfs_target::fetch_registers): Update.
3412         (procfs_target::store_registers): Update.
3413         (procfs_target::wait): Update.
3414         (procfs_target::files_info): Update.
3415         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3416         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3417         return type.
3418         (nto_procfs_target::pid_to_str): Change return type.
3419         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3420         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3421         return type.
3422         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3423         (exit_lwp): Update.
3424         (attach_proc_task_lwp_callback, get_detach_signal)
3425         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3426         (linux_nat_target::resume, wait_lwp, stop_callback)
3427         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3428         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3429         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3430         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3431         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3432         type.
3433         (inf_ptrace_target::attach): Update.
3434         (inf_ptrace_target::files_info): Update.
3435         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3436         type.
3437         (go32_nat_target::pid_to_str): Change return type.
3438         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3439         (gnu_nat_target::wait): Update.
3440         (gnu_nat_target::wait): Update.
3441         (gnu_nat_target::resume): Update.
3442         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3443         (fbsd_nat_target::wait): Update.
3444         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3445         type.
3446         (darwin_nat_target::attach): Update.
3447         * corelow.c (class core_target) <pid_to_str>: Change return type.
3448         (core_target::pid_to_str): Change return type.
3449         * target.c (normal_pid_to_str): Change return type.
3450         (default_pid_to_str): Likewise.
3451         (target_pid_to_str): Change return type.
3452         (target_translate_tls_address): Update.
3453         (target_announce_detach): Update.
3454         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3455         return type.
3456         (bsd_uthread_target::pid_to_str): Change return type.
3457         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3458         type.
3459         (bsd_kvm_target::pid_to_str): Change return type.
3460         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3461         return type.
3462         (aix_thread_target::pid_to_str): Change return type.
3463         * target.h (struct target_ops) <pid_to_str>: Change return type.
3464         (target_pid_to_str, normal_pid_to_str): Likewise.
3465         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3466         type.
3467         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3468         type.
3469         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3470         return type.
3471         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3472         type.
3473         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3474         type.
3475         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3476         return type.
3477
3478 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3479
3480         * NEWS: Mention that the new default MI version is 3.  Mention
3481         changes to the output of commands and events that deal with
3482         multi-location breakpoints.
3483         * breakpoint.c: Include "mi/mi-out.h".
3484         (print_one_breakpoint): Change output syntax if using MI version
3485         >= 3.
3486         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3487         New.
3488         (mi_multi_location_breakpoint_output_fixed): New.
3489         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3490         (mi_cmd_fix_multi_location_breakpoint_output): New.
3491         (mi_multi_location_breakpoint_output_fixed): New.
3492         * mi/mi-cmds.c (mi_cmds): Register command
3493         -fix-multi-location-breakpoint-output.
3494         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3495         interpreter "mi".
3496
3497 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3498
3499         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3500         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3501         instantiate mi_ui_out based on interpreter name.
3502         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3503         * mi/mi-main.c (mi_load_progress): Likewise.
3504
3505 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3506
3507         * NEWS: Combine separate "New targets" sections for 8.3.
3508
3509 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3510
3511         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3512         (ppcfbsd_init_abi): Install gdbarch
3513         "fetch_tls_load_module_address" and "get_thread_local_address"
3514         methods.
3515
3516 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3517
3518         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3519         (riscv_fbsd_init_abi): Install gdbarch
3520         "fetch_tls_load_module_address" and "get_thread_local_address"
3521         methods.
3522
3523 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3524
3525         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3526         (i386fbsd_init_abi): Install gdbarch
3527         "fetch_tls_load_module_address" and "get_thread_local_address"
3528         methods.
3529
3530 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3531
3532         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3533         (amd64fbsd_init_abi): Install gdbarch
3534         "fetch_tls_load_module_address" and "get_thread_local_address"
3535         methods.
3536
3537 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3538
3539         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3540         (struct fbsd_pspace_data): New type.
3541         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3542         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3543         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3544         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3545         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3546
3547 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3548
3549         * gdbtypes.c (lookup_struct_elt): New function.
3550         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3551         * gdbtypes.h (struct struct_elt): New type.
3552         (lookup_struct_elt): New prototype.
3553
3554 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3555
3556         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3557         remove disabled code block.
3558
3559 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3560
3561         * gdbarch.sh (get_thread_local_address): New method.
3562         * gdbarch.h, gdbarch.c: Regenerate.
3563         * target.c (target_translate_tls_address): Use
3564         gdbarch_get_thread_local_address if present instead of
3565         target::get_thread_local_address.
3566
3567 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3568
3569         * target.h (target::get_thread_local_address): Update comment.
3570
3571 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3572
3573         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3574         objfile->separate_debug_objfile_backlink if not NULL.
3575
3576 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3577
3578         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3579         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3580         (amd64bsd_store_inferior_registers): Likewise.
3581         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3582         Enable segment base registers.
3583         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3584         PT_GETFSBASE and PT_GETGSBASE.
3585         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3586         PT_SETGSBASE.
3587         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3588         segment base registers.
3589         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3590
3591 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3592
3593         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3594         Update calls to i386_target_description to add 'segments'
3595         parameter.
3596         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3597         add segment base registers.
3598         * arch/i386.c (i386_create_target_description): Add 'segments'
3599         parameter to enable segment base registers.
3600         * arch/i386.h (i386_create_target_description): Likewise.
3601         * features/i386/32bit-segments.xml: New file.
3602         * features/i386/32bit-segments.c: Generate.
3603         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3604         call to i386_target_description to add 'segments' parameter.
3605         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3606         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3607         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3608         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3609         if feature is present.
3610         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3611         Add 'segments' parameter to call to i386_target_description.
3612         (i386_target_description): Add 'segments' parameter to enable
3613         segment base registers.
3614         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3615         to call to i386_target_description.
3616         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3617         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3618         Define I386_NUM_REGS.
3619         (i386_target_description): Add 'segments' parameter to enable
3620         segment base registers.
3621
3622 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3623
3624         PR/24325
3625         * source-cache.c: #undef open and close, to avoid unresolved
3626         externals during linking.
3627
3628 2019-03-12  Tom Tromey  <tromey@adacore.com>
3629
3630         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3631         const.  Add initializers.
3632         (_initialize_remote): Don't initialize ptid globals.
3633
3634 2019-03-12  Pedro Alves  <palves@redhat.com>
3635
3636         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3637
3638 2019-03-12  Pedro Alves  <palves@redhat.com>
3639
3640         * cp-name-parser.y (main): Remove unused 'len' variable.
3641
3642 2019-03-12  Tom Tromey  <tromey@adacore.com>
3643
3644         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3645         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3646
3647 2019-03-12  Tom Tromey  <tromey@adacore.com>
3648
3649         * linux-nat.c (iterate_over_lwps): Update.
3650         (stop_callback): Remove parameter.
3651         (stop_wait_callback, detach_callback, resume_set_callback)
3652         (select_singlestep_lwp_callback, set_ignore_sigint)
3653         (status_callback, resumed_callback, resume_clear_callback)
3654         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3655         data parameter.
3656         (linux_nat_target::detach, linux_nat_target::resume)
3657         (linux_stop_and_wait_all_lwps, select_event_lwp)
3658         (linux_nat_filter_event, linux_nat_wait_1)
3659         (linux_nat_target::kill, linux_nat_target::stop)
3660         (linux_nat_target::stop): Update.
3661         (linux_nat_resume_callback): Change type.
3662         (resume_stopped_resumed_lwps, count_events_callback)
3663         (select_event_lwp_callback): Likewise.
3664         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3665         * arm-linux-nat.c (struct update_registers_data): Remove.
3666         (update_registers_callback): Change type.
3667         (arm_linux_insert_hw_breakpoint1): Update.
3668         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3669         parameter.
3670         (x86_linux_dr_set_addr): Update.
3671         (x86_linux_dr_set_control): Update.
3672         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3673         (iterate_over_lwps): Use gdb::function_view.
3674         * nat/aarch64-linux-hw-point.c (struct
3675         aarch64_dr_update_callback_param): Remove.
3676         (debug_reg_change_callback): Change type.
3677         (aarch64_notify_debug_reg_change): Update.
3678         * s390-linux-nat.c (s390_refresh_per_info): Update.
3679
3680 2019-03-11  Tom Tromey  <tromey@adacore.com>
3681
3682         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3683         redundant assignment to "this_cu".
3684
3685 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3686
3687         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3688
3689 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3690
3691         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3692         from...
3693         (rank_one_type): ... this.
3694
3695 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3696
3697         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3698         from...
3699         (rank_one_type): ... this.
3700
3701 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3702
3703         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3704         from...
3705         (rank_one_type): ... this.
3706
3707 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3708
3709         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3710         from...
3711         (rank_one_type): ... this.
3712
3713 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3714
3715         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3716         from...
3717         (rank_one_type): ... this.
3718
3719 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3720
3721         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3722         from...
3723         (rank_one_type): ... this.
3724
3725 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3726
3727         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3728         from...
3729         (rank_one_type): ... this.
3730
3731 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3732
3733         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3734         from...
3735         (rank_one_type): ... this.
3736
3737 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3738
3739         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3740         from...
3741         (rank_one_type): ... this.
3742
3743 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3744
3745         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3746         from...
3747         (rank_one_type): ... this.
3748
3749 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3750
3751         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3752         from...
3753         (rank_one_type): ... this.
3754
3755 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3756
3757         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3758         from...
3759         (rank_one_type): ... this.
3760
3761 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3762
3763         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3764         inferior-events' shows the example events.
3765
3766 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3767
3768         Support styling on native MS-Windows console
3769
3770         PR/24315
3771         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3772         on MS-Windows if $TERM is not defined.
3773
3774         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3775
3776         * posix-hdep.c (gdb_console_fputs):
3777         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3778         functions.
3779         * ui-file.h (gdb_console_fputs): Add prototype.
3780
3781         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3782         back to fputs only if the former returns zero.
3783
3784 2019-03-07  Tom Tromey  <tom@tromey.com>
3785
3786         * symmisc.c (print_symbol_bcache_statistics): Update.
3787         (print_objfile_statistics): Update.
3788         * symfile.c (allocate_symtab): Update.
3789         * stabsread.c: Don't include bcache.h.
3790         * psymtab.h (struct psymbol_bcache): Don't declare.
3791         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3792         (psymbol_bcache_init, psymbol_bcache_free)
3793         (psymbol_bcache_get_bcache): Don't declare.
3794         * psymtab.c (struct psymbol_bcache): Remove.
3795         (psymtab_storage::psymtab_storage): Update.
3796         (psymtab_storage::~psymtab_storage): Update.
3797         (psymbol_bcache_init, psymbol_bcache_free)
3798         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3799         (add_psymbol_to_bcache): Update.
3800         (allocate_psymtab): Update.
3801         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3802         macro_cache>: No longer pointers.
3803         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3804         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3805         * macrotab.c (macro_bcache): Update.
3806         * macroexp.c: Don't include bcache.h.
3807         * gdbtypes.c (check_types_worklist): Update.
3808         (types_deeply_equal): Remove TRY/CATCH.  Update.
3809         * elfread.c (elf_symtab_read): Update.
3810         * dwarf2read.c: Don't include bcache.h.
3811         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3812         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3813         (print_bcache_statistics, bcache_memory_used): Don't declare.
3814         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3815         methods.  Rename all data members.
3816         * bcache.c (struct bcache): Move to bcache.h.
3817         (bcache::expand_hash_table): Rename from expand_hash_table.
3818         (bcache): Remove.
3819         (bcache::insert): Rename from bcache_full.
3820         (bcache::compare): Rename from bcache_compare.
3821         (bcache_xmalloc): Remove.
3822         (bcache::~bcache): Rename from bcache_xfree.
3823         (bcache::print_statistics): Rename from print_bcache_statistics.
3824         (bcache::memory_used): Rename from bcache_memory_used.
3825
3826 2019-03-07  Pedro Alves  <palves@redhat.com>
3827
3828         * infrun.c (normal_stop): Also check for
3829         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3830
3831 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3832
3833         * f-lang.c (value_from_host_double): Moved to...
3834         * value.c (value_from_host_double): ...here.
3835         * value.h (value_from_host_double): Declare.
3836         * guile/scm-math.c (vlscm_convert_typed_number): Use
3837         value_from_host_double.
3838         (vlscm_convert_number): Likewise.
3839         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3840         * python/py-value.c (convert_value_from_python): Likewise.
3841
3842 2019-03-06  Tom Tromey  <tom@tromey.com>
3843
3844         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3845
3846 2019-03-06  Tom Tromey  <tom@tromey.com>
3847
3848         * utils.h (free_current_contents): Don't declare.
3849         * utils.c (free_current_contents): Remove.
3850
3851 2019-03-06  Tom Tromey  <tom@tromey.com>
3852
3853         * top.c (quit_force): Update.
3854         * main.c (captured_command_loop): Update.
3855         * common/new-op.c (operator new): Update.
3856         * common/common-exceptions.c (struct catcher)
3857         <save_cleanup_chain>: Remove member.
3858         (exceptions_state_mc_init): Update.
3859         (exception_try_scope_entry): Return nullptr.
3860         (exception_try_scope_exit, exception_rethrow)
3861         (throw_exception_sjlj, throw_exception_cxx): Update.
3862         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3863         (all_cleanups, do_cleanups, discard_cleanups)
3864         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3865         (restore_cleanups, restore_final_cleanups): Don't declare.
3866         (do_final_cleanups): Remove parameter.
3867         * common/cleanups.c (cleanup_chain, make_cleanup)
3868         (make_cleanup_dtor, all_cleanups, do_cleanups)
3869         (discard_my_cleanups, discard_cleanups)
3870         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3871         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3872         (null_cleanup): Remove.
3873         (do_final_cleanups): Remove parameter.
3874
3875 2019-03-06  Tom Tromey  <tom@tromey.com>
3876
3877         * remote.c (remote_target::remote_parse_stop_reply): Use
3878         unique_xmalloc_ptr.
3879
3880 2019-03-06  Tom Tromey  <tom@tromey.com>
3881
3882         * stabsread.c (struct stabs_field_info): Rename from field_info.
3883         <list, fnlist>: Add initializers.
3884         <obstack>: New member.
3885         (read_member_functions, read_struct_fields, read_baseclasses):
3886         Allocate on obstack.  Don't use cleanups.
3887         (read_one_struct_field, read_member_functions, read_struct_fields)
3888         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3889         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3890         (read_struct_type): Update.
3891
3892 2019-03-06  Tom Tromey  <tom@tromey.com>
3893
3894         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3895         * common/filestuff.h (make_cleanup_close): Don't declare.
3896         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3897         Remove.
3898
3899 2019-03-06  Tom Tromey  <tom@tromey.com>
3900
3901         * solib-aix.c: Use make_scope_exit.
3902
3903 2019-03-06  Tom Tromey  <tom@tromey.com>
3904
3905         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3906         Use make_scope_exit.
3907
3908 2019-03-06  Tom Tromey  <tom@tromey.com>
3909
3910         * solib-svr4.c (disable_probes_interface): Remove parameter.
3911         (svr4_handle_solib_event): Use make_scope_exit.
3912
3913 2019-03-06  Tom Tromey  <tom@tromey.com>
3914
3915         * remote.c (struct stop_reply_deleter): Remove.
3916         (stop_reply_up): Update.
3917         (struct stop_reply): Derive from notif_event.  Don't typedef.
3918         <regcache>: Now a std::vector.
3919         (stop_reply_xfree): Remove.
3920         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3921         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3922         (remote_target::discard_pending_stop_replies): Use delete.
3923         (remote_target::remote_parse_stop_reply): Update.
3924         (remote_target::process_stop_reply): Update.
3925         * remote-notif.h (struct notif_event): Add virtual destructor.
3926         Remove "dtr" member.
3927         (struct notif_client) <alloc_event>: Return a unique_ptr.
3928         (notif_event_xfree): Don't declare.
3929         (notif_event_up): New typedef.
3930         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3931         (notif_event_xfree, do_notif_event_xfree): Remove.
3932         (remote_notif_state_xfree): Update.
3933
3934 2019-03-06  Tom Tromey  <tom@tromey.com>
3935
3936         * infrun.c (displaced_step_clear_cleanup): Now a
3937         forward_scope_exit type.
3938         (displaced_step_prepare_throw): Update.
3939         (displaced_step_fixup): Update.
3940
3941 2019-03-06  Tom Tromey  <tom@tromey.com>
3942
3943         * inferior.h (class inferior): Update comment.
3944         * gdbthread.h (class thread_info): Update comment.
3945
3946 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3947             Tom Tromey  <tom@tromey.com>
3948
3949         * stabsread.h (struct stab_section_list): Remove.
3950         (coffstab_build_psymtabs): Update.
3951         * dbxread.c (symbuf_sections): Now a std::vector.
3952         (sect_idx): New global.
3953         (fill_symbuf): Update.
3954         (coffstab_build_psymtabs): Change type of stabsects parameter.
3955         Update.
3956         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3957         std::vector.
3958         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3959         (coff_locate_sections): Update.
3960         (coff_symfile_read): Remove cleanups.  Update.
3961         (init_stringtab): Add storage parameter.
3962         (free_stringtab, free_stringtab_cleanup): Remove.
3963         (init_lineno): Add storage parameter.
3964         (free_linetab, free_linetab_cleanup): Remove.
3965
3966 2019-03-06  Pedro Alves  <palves@redhat.com>
3967
3968         * linux-fork.c (fork_info::clobber_regs): Delete.
3969         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3970         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3971         comment.  Adjust.
3972         (scoped_switch_fork_info::scoped_switch_fork_info)
3973         (checkpoint_command, linux_fork_context): Adjust
3974         fork_save_infrun_state calls.
3975
3976 2019-03-06  Pedro Alves  <palves@redhat.com>
3977
3978         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3979         (inf_has_multiple_threads): Return 'bool' and rewrite using
3980         inferior_info::threads().
3981
3982 2019-03-06  Pedro Alves  <palves@redhat.com>
3983
3984         * linux-fork.c: Include <list>.
3985         (fork_list): Now a std::list instance.
3986         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3987         (forks_exist_p, find_last_fork): Adjust.
3988         (new_fork): Delete.
3989         (one_fork_p): New.
3990         (add_fork): Adjust.
3991         (free_fork): Delete, folded into fork_info::~fork_info().
3992         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3993         Adjust.
3994         (init_fork_list): Delete.
3995         (linux_fork_killall, linux_fork_mourn_inferior)
3996         (linux_fork_detach, info_checkpoints_command): Adjust.
3997         (_initialize_linux_fork): No longer call init_fork_list.
3998
3999 2019-03-06  Pedro Alves  <palves@redhat.com>
4000
4001         * linux-fork.c (new_fork): New, split out of ...
4002         (add_fork): ... this.  Return void.  Move "first fork" special
4003         case from here, to ...
4004         (checkpoint_command): ... here.
4005         * linux-linux.h (add_fork): Return void.
4006
4007 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4008
4009         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
4010
4011 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4012             Chris January  <chris.january@arm.com>
4013             David Lecomber  <david.lecomber@arm.com>
4014
4015         * f-exp.y: New token, UNOP_INTRINSIC.
4016         (exp): New pattern using UNOP_INTRINSIC token.
4017         (f77_keywords): Add 'abs' keyword.
4018         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
4019         (value_from_host_double): New function.
4020         (evaluate_subexp_f): Support UNOP_ABS.
4021
4022 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4023
4024         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
4025         types.
4026
4027 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4028
4029         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
4030         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
4031         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
4032
4033 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4034
4035         * f-exp.y (convert_to_kind_type): Handle more type kinds.
4036
4037 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4038             Chris January  <chris.january@arm.com>
4039
4040         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
4041         * f-exp.y: Define 'KIND' token.
4042         (exp): New pattern for KIND expressions.
4043         (ptype): Handle types with a kind extension.
4044         (direct_abs_decl): Extend to spot kind extensions.
4045         (f77_keywords): Add 'kind' to the list.
4046         (push_kind_type): New function.
4047         (convert_to_kind_type): New function.
4048         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
4049         * parse.c (operator_length_standard): Likewise.
4050         * parser-defs.h (enum type_pieces): Add tp_kind.
4051         * std-operator.def: Add UNOP_KIND.
4052
4053 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4054
4055         * f-exp.y (f_parse): Set yydebug.
4056
4057 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4058
4059         * f-lang.c (evaluate_subexp_f): New function.
4060         (exp_descriptor_f): New global.
4061         (f_language_defn): Use exp_descriptor_f instead of
4062         exp_descriptor_standard.
4063
4064 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4065
4066         * f-exp.y (struct token): Add comments.
4067         (dot_ops): Remove uppercase versions and the end marker.
4068         (f77_keywords): Likewise.
4069         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
4070         entries in the dot_ops array are case insensitive, and use
4071         strncasecmp to compare strings.  Also some whitespace cleanup in
4072         this area.  Similar for the f77_keywords array, except entries in
4073         this list might be case sensitive.
4074
4075 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4076
4077         * f-exp.y (struct f77_boolean_val): Add comments.
4078         (boolean_values): Remove uppercase versions, and end marker.
4079         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
4080         and use strncasecmp to achieve case insensitivity.  Additionally,
4081         perform whitespace cleanup around this code.
4082
4083 2019-03-06  Tom Tromey  <tromey@adacore.com>
4084
4085         * remote-sim.c (gdbsim_target_open): Use result of
4086         gdb_argv::release.
4087
4088 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4089         Dirk Schubert  <dirk.schubert@arm.com>
4090         Chris January  <chris.january@arm.com>
4091
4092         * eval.c (evaluate_subexp_standard): Call Fortran argument
4093         wrapping logic.
4094         * f-lang.c (struct value): A value which can be passed into a
4095         Fortran function call.
4096         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4097         where appropriate.
4098         (struct type): Value ready for a Fortran function call.
4099         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4100         is needed.
4101         * f-lang.h (fortran_argument_convert): Declaration.
4102         (fortran_preserve_arg_pointer): Declaration.
4103         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4104
4105 2019-03-05  Tom Tromey  <tromey@adacore.com>
4106
4107         * python/py-prettyprint.c (print_string_repr): Remove #if.
4108         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4109
4110 2019-03-05  Tom Tromey  <tromey@adacore.com>
4111
4112         * target.c (the_dummy_target): Move later.  Change type to
4113         "dummy_target".
4114         (initialize_targets): Don't initialize the_dummy_target.
4115
4116 2019-03-05  Tom Tromey  <tromey@adacore.com>
4117
4118         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4119         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4120
4121 2019-03-05  Tom Tromey  <tromey@adacore.com>
4122
4123         * windows-nat.c (windows_nat_target::attach)
4124         (windows_nat_target::detach): Don't call gdb_flush.
4125         * valprint.c (generic_val_print, val_print, val_print_string):
4126         Don't call gdb_flush.
4127         * utils.c (defaulted_query): Don't call gdb_flush.
4128         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4129         * target.c (target_announce_detach): Don't call gdb_flush.
4130         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4131         * remote.c (extended_remote_target::attach): Don't call
4132         gdb_flush.
4133         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4134         * printcmd.c (do_examine): Don't call gdb_flush.
4135         (info_display_command): Don't call gdb_flush.
4136         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4137         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4138         * memattr.c (info_mem_command): Don't call gdb_flush.
4139         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4140         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4141         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4142         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4143         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4144         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4145         (gnu_nat_target::detach): Don't call gdb_flush.
4146         * f-valprint.c (f_val_print): Don't call gdb_flush.
4147         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4148         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4149         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4150         gdb_flush.
4151         * c-valprint.c (c_val_print): Don't call gdb_flush.
4152         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4153
4154 2019-03-05  Tom Tromey  <tromey@adacore.com>
4155
4156         * varobj.c (update_dynamic_varobj_children): Update.
4157         (install_default_visualizer): Use reset, not release.
4158         * value.c (set_internalvar): Update.
4159         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4160         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4161         ATTRIBUTE_UNUSED_RESULT.
4162
4163 2019-03-05  Tom Tromey  <tromey@adacore.com>
4164
4165         * remote.c (class scoped_remote_fd) <release>: Add
4166         ATTRIBUTE_UNUSED_RESULT.
4167
4168 2019-03-05  Tom Tromey  <tromey@adacore.com>
4169
4170         * macroexp.c (struct macro_buffer) <release>: Add
4171         ATTRIBUTE_UNUSED_RESULT.
4172
4173 2019-03-05  Tom Tromey  <tromey@adacore.com>
4174
4175         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4176         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4177         ATTRIBUTE_UNUSED_RESULT.
4178
4179 2019-03-05  Tom Tromey  <tromey@adacore.com>
4180
4181         * common/scoped_fd.h (class scoped_fd) <release>: Add
4182         ATTRIBUTE_UNUSED_RESULT.
4183
4184 2019-03-05  Tom Tromey  <tromey@adacore.com>
4185
4186         * parser-defs.h (struct parser_state) <release>: Add
4187         ATTRIBUTE_UNUSED_RESULT.
4188
4189 2019-03-05  Tom Tromey  <tromey@adacore.com>
4190
4191         * utils.h (class gdb_argv) <release>: Add
4192         ATTRIBUTE_UNUSED_RESULT.
4193         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4194
4195 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4196
4197         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4198         for-loop range, to avoid compiler warnings.
4199
4200         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4201         avoid compiler warnings about unused variables.
4202
4203         * NEWS: Mention end of support for native debugging on MS-Windows
4204         before XP.
4205
4206         PR gdb/24292
4207         * common/netstuff.c:
4208         * gdbserver/gdbreplay.c
4209         * gdbserver/remote-utils.c:
4210         * ser-tcp.c:
4211         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4212         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4213         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4214         'getaddrinfo' and 'freeaddrinfo' were not available before
4215         Windows XP, and mingw.org's MinGW headers by default define
4216         _WIN32_WINNT to 0x500.
4217
4218 2019-03-01  Gary Benson <gbenson@redhat.com>
4219
4220         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4221
4222 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4223             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4224
4225         PR gdb/8527
4226         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4227         set_sigint_trap, clear_sigint_trap.
4228
4229 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4230
4231         * target.c (target_detach): Clear the regcache and the
4232         frame cache.
4233
4234 2019-02-27  Pedro Alves  <palves@redhat.com>
4235
4236         * utils.c (set_screen_size): When we cap the height/width sizes,
4237         tweak the corresponding command variable to show "unlimited":
4238
4239 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4240             Pedro Alves  <palves@redhat.com>
4241
4242         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4243         before calling rl_set_screen_size.
4244
4245 2019-02-27  Tom Tromey  <tromey@adacore.com>
4246
4247         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4248         define.
4249         * python/py-value.c: Remove Python 2.4 workaround.
4250         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4251         workaround.
4252         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4253         Python 2.4 workaround.
4254         * python/python-internal.h: Remove Python 2.4 comment.
4255         (Py_ssize_t): Don't define.
4256         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4257         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4258         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4259         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4260         * python/python.c (do_start_initialization): Remove Python 2.4
4261         workaround.
4262         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4263         (print_children): Remove Python 2.4 workaround.
4264         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4265         workaround.
4266         (CHARBUFFERPROC_NAME): Remove.
4267         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4268         Python 2.4 workaround.
4269
4270 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4271
4272         * NEWS: Note minimum Python version.
4273
4274 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4275
4276         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4277         code from these functions.  Remove corresponding ifdefs.  Use
4278         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4279         Remove gotos and target of gotos.
4280         (infpy_search_memory): Likewise.
4281
4282 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4283
4284         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4285         (hppa_gdbarch_init): Don't register deleted functions with
4286         gdbarch.
4287
4288 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4289
4290         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4291         (h8300_unwind_sp): Delete.
4292         (h8300_dummy_id): Delete.
4293         (h8300_gdbarch_init): Don't register deleted functions with
4294         gdbarch.
4295
4296 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4297
4298         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4299         (ft32_unwind_pc): Delete.
4300         (ft32_unwind_sp): Delete.
4301         (ft32_gdbarch_init): Don't register deleted functions with
4302         gdbarch.
4303
4304 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4305
4306         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4307         (frv_unwind_pc): Delete.
4308         (frv_unwind_sp): Delete.
4309         (frv_gdbarch_init): Don't register deleted functions with
4310         gdbarch.
4311
4312 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4313
4314         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4315         (riscv_unwind_pc): Delete.
4316         (riscv_unwind_sp): Delete.
4317         (riscv_gdbarch_init): Don't register deleted functions with
4318         gdbarch.
4319
4320 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4321
4322         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4323         (csky_unwind_pc): Delete.
4324         (csky_unwind_sp): Delete.
4325         (csky_gdbarch_init): Don't register deleted functions with
4326         gdbarch.
4327
4328 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4329
4330         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4331         (cris_unwind_pc): Delete.
4332         (cris_unwind_sp): Delete.
4333         (cris_gdbarch_init): Don't register deleted functions with
4334         gdbarch.
4335
4336 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4337
4338         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4339         (bfin_unwind_pc): Delete.
4340         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4341
4342 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4343
4344         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4345         (arm_unwind_pc): Delete.
4346         (arm_unwind_sp): Delete.
4347         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4348
4349 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4350
4351         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4352         (arc_unwind_pc): Delete.
4353         (arc_unwind_sp): Delete.
4354         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4355
4356 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4357
4358         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4359         (alpha_unwind_pc): Delete.
4360         (alpha_gdbarch_init): Don't register deleted functions with
4361         gdbarch.
4362
4363 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4364
4365         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4366         (aarch64_unwind_pc): Delete.
4367         (aarch64_unwind_sp): Delete.
4368         (aarch64_gdbarch_init): Don't register deleted functions with
4369         gdbarch.
4370
4371 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4372
4373         * gdbtypes.c (type_align): Don't consider static members when
4374         computing structure alignment.
4375
4376 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4377
4378         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4379         return 0 for other types.
4380         * arch-utils.c (default_type_align): Always return 0.
4381         * gdbarch.h: Regenerate.
4382         * gdbarch.sh (type_align): Extend comment.
4383         * gdbtypes.c (type_align): Add additional comments, always call
4384         gdbarch_type_align before applying the default rules.
4385         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4386         generic code will then apply a suitable default.
4387         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4388         types, return 0 for other types.
4389
4390 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4391
4392         * NEWS: Create a new section for the next release branch.
4393         Rename the section of the current branch, now that it has
4394         been cut.
4395
4396 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4397
4398         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4399         * version.in: Bump version to 8.3.50.DATE-git.
4400
4401 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4402
4403         * aix-thread.c (ptid_cmp): Remove unused variable.
4404         (get_signaled_thread): Likewise.
4405         (store_regs_user_thread): Likewise.
4406         (store_regs_kernel_thread): Likewise.
4407         (fetch_regs_kernel_thread): Remove shadowed variable.
4408
4409 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4410
4411         * features/riscv/32bit-cpu.xml: Add register numbers.
4412         * features/riscv/32bit-fpu.c: Regenerate.
4413         * features/riscv/32bit-fpu.xml: Add register numbers.
4414         * features/riscv/64bit-cpu.xml: Add register numbers.
4415         * features/riscv/64bit-fpu.c: Regenerate.
4416         * features/riscv/64bit-fpu.xml: Add register numbers.
4417
4418 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4419
4420         * NEWS: Mention two argument form of gdb.Value constructor.
4421         * python/py-value.c (convert_buffer_and_type_to_value): New
4422         function.
4423         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4424         Add support for handling an optional second argument.  Call
4425         convert_buffer_and_type_to_value as appropriate.
4426         * python/python-internal.h (Py_buffer_deleter): New struct.
4427         (Py_buffer_up): New typedef.
4428
4429 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4430
4431         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4432         instead of releasing ownership.
4433
4434 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4435
4436         * dwarf2read.c (open_and_init_dwp_file): Call
4437         elf_numsections instead of bfd_count_sections to initialize
4438         dwp_file->num_sections.
4439
4440 2019-02-25  Tom Tromey  <tromey@adacore.com>
4441
4442         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4443
4444 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4445
4446         * gcore.in: Add '--readnever' option when invoking GDB.
4447
4448 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4449
4450         * MAINTAINERS: Update my email address.
4451
4452 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4453
4454         * build-id.c (build_id_to_debug_bfd_1): New function.
4455         (build_id_to_debug_bfd): Look for separate debug file in
4456         sysroot.
4457
4458 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4459
4460         * gdbarch.sh: Update the copyright year range that is placed into
4461         generated files.
4462
4463 2019-02-22  Keith Seitz  <keiths@redhat.com>
4464
4465         PR symtab/23853
4466         * linespec.c (create_sals_line_offset): Search for the default
4467         symtab's filename instead of its fullname.
4468
4469 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4470
4471         * NEWS: Update style defaults.
4472
4473 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4474
4475         * main.c (captured_main_1): Disable styling in batch mode.
4476
4477 2019-02-20  Tom Tromey  <tom@tromey.com>
4478
4479         * symtab.c (symtab_symbol_info): Fix typos.
4480
4481 2019-02-20  Tom Tromey  <tromey@adacore.com>
4482
4483         * findcmd.c (_initialize_mem_search): Use upper case for
4484         metasyntactic variables.
4485
4486 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4487
4488         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4489         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4490
4491 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4492
4493         * top.h (source_file_name): Change to std::string.
4494         * top.c (source_file_name): Likewise.
4495         (command_line_input): Adjust.
4496         * cli/cli-script.c (script_from_file): Adjust.
4497
4498 2019-02-19  Tom Tromey  <tromey@adacore.com>
4499
4500         * ravenscar-thread.c
4501         (ravenscar_thread_target::update_thread_list): Don't call
4502         ada_build_task_list.
4503         * ada-lang.h (ada_build_task_list): Don't declare.
4504         * ada-tasks.c (struct ada_tasks_inferior_data)
4505         <task_list_valid_p>: Now bool.
4506         (read_known_tasks, ada_task_list_changed)
4507         (ada_tasks_invalidate_inferior_data): Update.
4508         (read_known_tasks_array): Return bool.
4509         (read_known_tasks_list): Likewise.
4510         (read_known_tasks): Return void.
4511         (ada_build_task_list): Now static.
4512
4513 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4514
4515         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4516         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4517
4518 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4519
4520         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4521         variant for ada_tasks_pspace_data_handle and
4522         ada_tasks_inferior_data_handle.
4523         (ada_tasks_pspace_data_cleanup): New function.
4524         (ada_tasks_inferior_data_cleanup): New function.
4525
4526 2019-02-17  Tom Tromey  <tom@tromey.com>
4527
4528         * macrotab.h (macro_source_fullname): Return a std::string.
4529         * macrotab.c (macro_include, check_for_redefinition)
4530         (macro_undef, macro_lookup_definition, foreach_macro)
4531         (foreach_macro_in_scope): Update.
4532         (macro_source_fullname): Return a std::string.
4533         * macrocmd.c (show_pp_source_pos): Update.
4534
4535 2019-02-17  Tom Tromey  <tom@tromey.com>
4536
4537         * macrocmd.c (show_pp_source_pos): Style the file names.
4538
4539 2019-02-17  Tom Tromey  <tom@tromey.com>
4540
4541         PR tui/24197:
4542         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4543
4544 2019-02-17  Tom Tromey  <tom@tromey.com>
4545
4546         * ada-lang.c (user_select_syms): Use filtered printing.
4547         * utils.c (wrap_style): New global.
4548         (desired_style): Remove.
4549         (emit_style_escape): Add stream parameter.
4550         (set_output_style, reset_terminal_style, prompt_for_continue):
4551         Update.
4552         (flush_wrap_buffer): Only flush gdb_stdout.
4553         (wrap_here): Set wrap_style.
4554         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4555         treat escape sequences as a character.  Change when wrap buffer is
4556         flushed.
4557         (fputs_styled): Do not set the output style when the default is
4558         requested.
4559         * ui-style.h (struct ui_file_style) <is_default>: New method.
4560         * source.c (print_source_lines_base): Emit escape sequences in one
4561         piece.
4562
4563 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4564
4565         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4566         integers and enumeration types.
4567
4568 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4569
4570         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4571         instead of lookup_symbol_in_language
4572         (do_exact_match): New function.
4573         (ada_get_symbol_name_matcher): Return do_exact_match when
4574         doing a verbatim match.
4575
4576 2019-02-15  Tom Tromey  <tromey@adacore.com>
4577
4578         * ravenscar-thread.c (ravenscar_thread_target::resume)
4579         (ravenscar_thread_target::wait): Special case wildcard requests.
4580
4581 2019-02-15  Tom Tromey  <tromey@adacore.com>
4582
4583         * ravenscar-thread.c (base_ptid): Remove.
4584         (struct ravenscar_thread_target) <close>: New method.
4585         <m_base_ptid>: New member.
4586         <update_inferior_ptid, active_task, task_is_currently_active,
4587         runtime_initialized>: Declare methods.
4588         <ravenscar_thread_target>: Add constructor.
4589         (ravenscar_thread_target::task_is_currently_active)
4590         (ravenscar_thread_target::update_inferior_ptid)
4591         (ravenscar_runtime_initialized): Rename.  Now methods.
4592         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4593         (ravenscar_thread_target::update_thread_list): Update.
4594         (ravenscar_thread_target::active_task): Now method.
4595         (ravenscar_thread_target::store_registers)
4596         (ravenscar_thread_target::prepare_to_store)
4597         (ravenscar_thread_target::prepare_to_store)
4598         (ravenscar_thread_target::mourn_inferior): Update.
4599         (ravenscar_inferior_created): Use "new" to create target.
4600         (ravenscar_thread_target::get_ada_task_ptid): Update.
4601         (_initialize_ravenscar): Don't initialize base_ptid.
4602         (ravenscar_ops): Remove global.
4603
4604 2019-02-15  Tom Tromey  <tromey@adacore.com>
4605
4606         * target.h (push_target): Declare new overload.
4607         * target.c (push_target): New overload, taking an rvalue reference.
4608         * remote.c (remote_target::open_1): Use push_target overload.
4609         * corelow.c (core_target_open): Use push_target overload.
4610
4611 2019-02-15  Tom Tromey  <tromey@adacore.com>
4612
4613         * ravenscar-thread.c (is_ravenscar_task)
4614         (ravenscar_task_is_currently_active): Return bool.
4615         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4616         (_initialize_ravenscar): Remove "(void)".
4617         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4618         Return bool.
4619
4620 2019-02-15  Tom Tromey  <tromey@adacore.com>
4621
4622         * ravenscar-thread.c (ravenscar_runtime_initializer)
4623         (has_ravenscar_runtime, get_running_thread_id)
4624         (ravenscar_thread_target::resume): Fix indentation.
4625
4626 2019-02-15  Tom Tromey  <tromey@adacore.com>
4627
4628         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4629         from ravenscar_arch_ops.
4630         (sparc_ravenscar_ops::fetch_registers)
4631         (sparc_ravenscar_ops::store_registers): Now methods.
4632         (sparc_ravenscar_prepare_to_store): Remove.
4633         (sparc_ravenscar_ops): Redefine.
4634         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4635         methods and destructor.  Remove members.
4636         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4637         (ravenscar_thread_target::store_registers)
4638         (ravenscar_thread_target::prepare_to_store): Update.
4639         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4640         Remove.
4641         (struct ppc_ravenscar_powerpc_ops): Derive from
4642         ravenscar_arch_ops.
4643         (ppc_ravenscar_powerpc_ops::fetch_registers)
4644         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4645         (ppc_ravenscar_powerpc_ops): Redefine.
4646         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4647         (ppc_ravenscar_e500_ops::fetch_registers)
4648         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4649         (ppc_ravenscar_e500_ops): Redefine.
4650         * aarch64-ravenscar-thread.c
4651         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4652         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4653         (aarch64_ravenscar_fetch_registers)
4654         (aarch64_ravenscar_store_registers): Now methods.
4655         (aarch64_ravenscar_ops): Redefine.
4656
4657 2019-02-15  Tom Tromey  <tromey@adacore.com>
4658
4659         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4660         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4661         (ravenscar_thread_target::stopped_by_watchpoint)
4662         (ravenscar_thread_target::stopped_data_address)
4663         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4664
4665 2019-02-15  Tom Tromey  <tromey@adacore.com>
4666
4667         * ravenscar-thread.c: Fix some typos.
4668
4669 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4670             Tom Tromey  <tromey@adacore.com>
4671
4672         * ada-lang.c (ada_exception_sal): Change addr_string to a
4673         std::string.
4674         (create_ada_exception_catchpoint): Update.
4675
4676 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4677             Tom Tromey  <tromey@adacore.com>
4678
4679         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4680         (bp_location_ops): Remove.
4681         (base_breakpoint_allocate_location): Update.
4682         (free_bp_location): Update.
4683         * ada-lang.c (class ada_catchpoint_location)
4684         <ada_catchpoint_location>: Remove ops parameter.
4685         (ada_catchpoint_location_dtor): Remove.
4686         (ada_catchpoint_location_ops): Remove.
4687         (allocate_location_exception): Update.
4688         * breakpoint.h (struct bp_location_ops): Remove.
4689         (class bp_location) <bp_location>: Remove bp_location_ops
4690         parameter.
4691         <~bp_location>: Add destructor.
4692         <ops>: Remove.
4693
4694 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4695             Pedro Alves  <palves@redhat.com>
4696
4697         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4698         'PATH_MAX'.
4699
4700 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4701             Samuel Thibault  <samuel.thibault@gnu.org>
4702             Thomas Schwinge  <thomas@codesourcery.com>
4703
4704         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4705         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4706
4707 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4708
4709         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4710         (check_empty): Use "const char *".
4711
4712         * gnu-nat.c (gnu_nat_target::detach): Instead of
4713         'detach_inferior (pid)' call
4714         'detach_inferior (find_inferior_pid (pid))'.
4715
4716         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4717         'nat/fork-inferior.o'.
4718         * gnu-nat.c: #include "nat/fork-inferior.h".
4719
4720         * gnu-nat.c (gnu_nat_target::detach): Instead of
4721         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4722         * gnu-nat.h: #include "inf-child.h".
4723         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4724         'i386_gnu_nat_target::fetch_registers'.
4725         (gnu_store_registers): Rename/move to
4726         'i386_gnu_nat_target::store_registers'.
4727
4728         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4729         * gnu-nat.h (mach_thread_info): New function.
4730         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4731
4732         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4733
4734 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4735
4736         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4737
4738 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4739
4740         * windows-nat.c (windows_add_thread): Add new parameter
4741         "main_thread_p" with default value set to false.  Update
4742         function documentation as well as all callers.
4743         (windows_delete_thread): Likewise.
4744         (fake_create_process): Update call to windows_add_thread.
4745         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4746         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4747         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4748         call to windows_delete_thread.
4749
4750 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4751
4752         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4753
4754 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4755
4756         * symfile.c (find_separate_debug_file): Use canonical path of
4757         sysroot with child_path instead of gdb_sysroot if it is valid.
4758
4759 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4760
4761         * symfile.c (find_separate_debug_file): Use child_path to
4762         determine if an object file is under a sysroot.
4763
4764 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4765
4766         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4767         unittests/child-path-selftests.c.
4768         * common/pathstuff.c (child_path): New function.
4769         * common/pathstuff.h (child_path): New prototype.
4770         * unittests/child-path-selftests.c: New file.
4771
4772 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4773
4774         * symfile.c (find_separate_debug_file): Look for separate debug
4775         files in debug directories under the sysroot.
4776
4777 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4778
4779         * symtab.h (struct minimal_symbol data_p): New const method.
4780         (struct minimal_symbol text_p): Likewise.
4781         * symtab.c (output_source_filename): Use file name style
4782         to print file name.
4783         (print_symbol_info): Likewise.
4784         (print_msymbol_info): Use address style to print addresses.
4785         Use function name style to print executable text symbols.
4786         (expand_symtab_containing_pc): Use data_p.
4787         (find_pc_sect_compunit_symtab): Likewise.
4788
4789 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4790
4791         * breakpoint.c (describe_other_breakpoints): Use address style
4792         to print addresses.
4793         (say_where): Likewise.
4794
4795 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4796
4797         * ada-typeprint.c (print_func_type): Print function name
4798         style to print function name.
4799         * c-typeprint.c (c_print_type_1): Likewise.
4800
4801 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4802
4803         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4804         for execve.
4805
4806 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4807
4808         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4809         type_stack.
4810
4811 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4812
4813         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4814         TYPE_CODE_REF types.
4815
4816 2019-02-08  Jim Wilson  <jimw@sifive.com>
4817
4818         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4819         (riscv_linux_fregset): New.
4820         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4821
4822 2019-02-07  Tom Tromey  <tom@tromey.com>
4823
4824         * thread.c (thread_cancel_execution_command): Update.
4825         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4826         methods.
4827         (struct thread_fsm_ops): Remove.
4828         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4829         (thread_fsm_should_stop, thread_fsm_return_value)
4830         (thread_fsm_set_finished, thread_fsm_finished_p)
4831         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4832         Don't declare.
4833         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4834         * infrun.c (clear_proceed_status_thread)
4835         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4836         (print_stop_event): Update.
4837         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4838         Add constructor.
4839         (step_command_fsm_ops): Remove.
4840         (new_step_command_fsm): Remove.
4841         (step_1): Update.
4842         (step_command_fsm::should_stop): Rename from
4843         step_command_fsm_should_stop.
4844         (step_command_fsm::clean_up): Rename from
4845         step_command_fsm_clean_up.
4846         (step_command_fsm::do_async_reply_reason): Rename from
4847         step_command_fsm_async_reply_reason.
4848         (struct until_next_fsm): Inherit from thread_fsm.  Add
4849         constructor.
4850         (until_next_fsm_ops): Remove.
4851         (new_until_next_fsm): Remove.
4852         (until_next_fsm::should_stop): Rename from
4853         until_next_fsm_should_stop.
4854         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4855         (until_next_fsm::do_async_reply_reason): Rename from
4856         until_next_fsm_async_reply_reason.
4857         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4858         constructor.  Change type of breakpoint.
4859         (finish_command_fsm_ops): Remove.
4860         (new_finish_command_fsm): Remove.
4861         (finish_command_fsm::should_stop): Rename from
4862         finish_command_fsm_should_stop.
4863         (finish_command_fsm::clean_up): Rename from
4864         finish_command_fsm_clean_up.
4865         (finish_command_fsm::return_value): Rename from
4866         finish_command_fsm_return_value.
4867         (finish_command_fsm::do_async_reply_reason): Rename from
4868         finish_command_fsm_async_reply_reason.
4869         (finish_command): Update.
4870         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4871         Add constructor.
4872         (call_thread_fsm_ops): Remove.
4873         (call_thread_fsm::call_thread_fsm): Rename from
4874         new_call_thread_fsm.
4875         (call_thread_fsm::should_stop): Rename from
4876         call_thread_fsm_should_stop.
4877         (call_thread_fsm::should_notify_stop): Rename from
4878         call_thread_fsm_should_notify_stop.
4879         (run_inferior_call, call_function_by_hand_dummy): Update.
4880         * cli/cli-interp.c (should_print_stop_to_console): Update.
4881         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4882         Add constructor.  Change type of location_breakpoint,
4883         caller_breakpoint.
4884         (until_break_fsm_ops): Remove.
4885         (new_until_break_fsm): Remove.
4886         (until_break_fsm::should_stop): Rename from
4887         until_break_fsm_should_stop.
4888         (until_break_fsm::clean_up): Rename from
4889         until_break_fsm_clean_up.
4890         (until_break_fsm::do_async_reply_reason): Rename from
4891         until_break_fsm_async_reply_reason.
4892         (until_break_command): Update.
4893         * thread-fsm.c: Remove.
4894         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4895
4896 2019-02-07  Tom Tromey  <tom@tromey.com>
4897
4898         * yy-remap.h: Add include guard.
4899         * xtensa-tdep.h: Add include guard.
4900         * xcoffread.h: Rename include guard.
4901         * varobj-iter.h: Add include guard.
4902         * tui/tui.h: Rename include guard.
4903         * tui/tui-winsource.h: Rename include guard.
4904         * tui/tui-wingeneral.h: Rename include guard.
4905         * tui/tui-windata.h: Rename include guard.
4906         * tui/tui-win.h: Rename include guard.
4907         * tui/tui-stack.h: Rename include guard.
4908         * tui/tui-source.h: Rename include guard.
4909         * tui/tui-regs.h: Rename include guard.
4910         * tui/tui-out.h: Rename include guard.
4911         * tui/tui-layout.h: Rename include guard.
4912         * tui/tui-io.h: Rename include guard.
4913         * tui/tui-hooks.h: Rename include guard.
4914         * tui/tui-file.h: Rename include guard.
4915         * tui/tui-disasm.h: Rename include guard.
4916         * tui/tui-data.h: Rename include guard.
4917         * tui/tui-command.h: Rename include guard.
4918         * tic6x-tdep.h: Add include guard.
4919         * target/waitstatus.h: Rename include guard.
4920         * target/wait.h: Rename include guard.
4921         * target/target.h: Rename include guard.
4922         * target/resume.h: Rename include guard.
4923         * target-float.h: Rename include guard.
4924         * stabsread.h: Add include guard.
4925         * rs6000-tdep.h: Add include guard.
4926         * riscv-fbsd-tdep.h: Add include guard.
4927         * regformats/regdef.h: Rename include guard.
4928         * record.h: Rename include guard.
4929         * python/python.h: Rename include guard.
4930         * python/python-internal.h: Rename include guard.
4931         * python/py-stopevent.h: Rename include guard.
4932         * python/py-ref.h: Rename include guard.
4933         * python/py-record.h: Rename include guard.
4934         * python/py-record-full.h: Rename include guard.
4935         * python/py-record-btrace.h: Rename include guard.
4936         * python/py-instruction.h: Rename include guard.
4937         * python/py-events.h: Rename include guard.
4938         * python/py-event.h: Rename include guard.
4939         * procfs.h: Add include guard.
4940         * proc-utils.h: Add include guard.
4941         * p-lang.h: Add include guard.
4942         * or1k-tdep.h: Rename include guard.
4943         * observable.h: Rename include guard.
4944         * nto-tdep.h: Rename include guard.
4945         * nat/x86-linux.h: Rename include guard.
4946         * nat/x86-linux-dregs.h: Rename include guard.
4947         * nat/x86-gcc-cpuid.h: Add include guard.
4948         * nat/x86-dregs.h: Rename include guard.
4949         * nat/x86-cpuid.h: Rename include guard.
4950         * nat/ppc-linux.h: Rename include guard.
4951         * nat/mips-linux-watch.h: Rename include guard.
4952         * nat/linux-waitpid.h: Rename include guard.
4953         * nat/linux-ptrace.h: Rename include guard.
4954         * nat/linux-procfs.h: Rename include guard.
4955         * nat/linux-osdata.h: Rename include guard.
4956         * nat/linux-nat.h: Rename include guard.
4957         * nat/linux-namespaces.h: Rename include guard.
4958         * nat/linux-btrace.h: Rename include guard.
4959         * nat/glibc_thread_db.h: Rename include guard.
4960         * nat/gdb_thread_db.h: Rename include guard.
4961         * nat/gdb_ptrace.h: Rename include guard.
4962         * nat/fork-inferior.h: Rename include guard.
4963         * nat/amd64-linux-siginfo.h: Rename include guard.
4964         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4965         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4966         * nat/aarch64-linux.h: Rename include guard.
4967         * nat/aarch64-linux-hw-point.h: Rename include guard.
4968         * mn10300-tdep.h: Add include guard.
4969         * mips-linux-tdep.h: Add include guard.
4970         * mi/mi-parse.h: Rename include guard.
4971         * mi/mi-out.h: Rename include guard.
4972         * mi/mi-main.h: Rename include guard.
4973         * mi/mi-interp.h: Rename include guard.
4974         * mi/mi-getopt.h: Rename include guard.
4975         * mi/mi-console.h: Rename include guard.
4976         * mi/mi-common.h: Rename include guard.
4977         * mi/mi-cmds.h: Rename include guard.
4978         * mi/mi-cmd-break.h: Rename include guard.
4979         * m2-lang.h: Add include guard.
4980         * location.h: Rename include guard.
4981         * linux-record.h: Rename include guard.
4982         * linux-nat.h: Add include guard.
4983         * linux-fork.h: Add include guard.
4984         * i386-darwin-tdep.h: Rename include guard.
4985         * hppa-linux-offsets.h: Add include guard.
4986         * guile/guile.h: Rename include guard.
4987         * guile/guile-internal.h: Rename include guard.
4988         * gnu-nat.h: Rename include guard.
4989         * gdb-stabs.h: Rename include guard.
4990         * frv-tdep.h: Add include guard.
4991         * f-lang.h: Add include guard.
4992         * event-loop.h: Add include guard.
4993         * darwin-nat.h: Rename include guard.
4994         * cp-abi.h: Rename include guard.
4995         * config/sparc/nm-sol2.h: Rename include guard.
4996         * config/nm-nto.h: Rename include guard.
4997         * config/nm-linux.h: Add include guard.
4998         * config/i386/nm-i386gnu.h: Rename include guard.
4999         * config/djgpp/nl_types.h: Rename include guard.
5000         * config/djgpp/langinfo.h: Rename include guard.
5001         * compile/gcc-cp-plugin.h: Add include guard.
5002         * compile/gcc-c-plugin.h: Add include guard.
5003         * compile/compile.h: Rename include guard.
5004         * compile/compile-object-run.h: Rename include guard.
5005         * compile/compile-object-load.h: Rename include guard.
5006         * compile/compile-internal.h: Rename include guard.
5007         * compile/compile-cplus.h: Rename include guard.
5008         * compile/compile-c.h: Rename include guard.
5009         * common/xml-utils.h: Rename include guard.
5010         * common/x86-xstate.h: Rename include guard.
5011         * common/version.h: Rename include guard.
5012         * common/vec.h: Rename include guard.
5013         * common/tdesc.h: Rename include guard.
5014         * common/selftest.h: Rename include guard.
5015         * common/scoped_restore.h: Rename include guard.
5016         * common/scoped_mmap.h: Rename include guard.
5017         * common/scoped_fd.h: Rename include guard.
5018         * common/safe-iterator.h: Rename include guard.
5019         * common/run-time-clock.h: Rename include guard.
5020         * common/refcounted-object.h: Rename include guard.
5021         * common/queue.h: Rename include guard.
5022         * common/ptid.h: Rename include guard.
5023         * common/print-utils.h: Rename include guard.
5024         * common/preprocessor.h: Rename include guard.
5025         * common/pathstuff.h: Rename include guard.
5026         * common/observable.h: Rename include guard.
5027         * common/netstuff.h: Rename include guard.
5028         * common/job-control.h: Rename include guard.
5029         * common/host-defs.h: Rename include guard.
5030         * common/gdb_wait.h: Rename include guard.
5031         * common/gdb_vecs.h: Rename include guard.
5032         * common/gdb_unlinker.h: Rename include guard.
5033         * common/gdb_unique_ptr.h: Rename include guard.
5034         * common/gdb_tilde_expand.h: Rename include guard.
5035         * common/gdb_sys_time.h: Rename include guard.
5036         * common/gdb_string_view.h: Rename include guard.
5037         * common/gdb_splay_tree.h: Rename include guard.
5038         * common/gdb_setjmp.h: Rename include guard.
5039         * common/gdb_ref_ptr.h: Rename include guard.
5040         * common/gdb_optional.h: Rename include guard.
5041         * common/gdb_locale.h: Rename include guard.
5042         * common/gdb_assert.h: Rename include guard.
5043         * common/filtered-iterator.h: Rename include guard.
5044         * common/filestuff.h: Rename include guard.
5045         * common/fileio.h: Rename include guard.
5046         * common/environ.h: Rename include guard.
5047         * common/common-utils.h: Rename include guard.
5048         * common/common-types.h: Rename include guard.
5049         * common/common-regcache.h: Rename include guard.
5050         * common/common-inferior.h: Rename include guard.
5051         * common/common-gdbthread.h: Rename include guard.
5052         * common/common-exceptions.h: Rename include guard.
5053         * common/common-defs.h: Rename include guard.
5054         * common/common-debug.h: Rename include guard.
5055         * common/cleanups.h: Rename include guard.
5056         * common/buffer.h: Rename include guard.
5057         * common/btrace-common.h: Rename include guard.
5058         * common/break-common.h: Rename include guard.
5059         * cli/cli-utils.h: Rename include guard.
5060         * cli/cli-style.h: Rename include guard.
5061         * cli/cli-setshow.h: Rename include guard.
5062         * cli/cli-script.h: Rename include guard.
5063         * cli/cli-interp.h: Rename include guard.
5064         * cli/cli-decode.h: Rename include guard.
5065         * cli/cli-cmds.h: Rename include guard.
5066         * charset-list.h: Add include guard.
5067         * buildsym-legacy.h: Rename include guard.
5068         * bfin-tdep.h: Add include guard.
5069         * ax.h: Rename include guard.
5070         * arm-linux-tdep.h: Add include guard.
5071         * arm-fbsd-tdep.h: Add include guard.
5072         * arch/xtensa.h: Rename include guard.
5073         * arch/tic6x.h: Add include guard.
5074         * arch/i386.h: Add include guard.
5075         * arch/arm.h: Rename include guard.
5076         * arch/arm-linux.h: Rename include guard.
5077         * arch/arm-get-next-pcs.h: Rename include guard.
5078         * arch/amd64.h: Add include guard.
5079         * arch/aarch64-insn.h: Rename include guard.
5080         * arch-utils.h: Rename include guard.
5081         * annotate.h: Add include guard.
5082         * amd64-darwin-tdep.h: Rename include guard.
5083         * aarch64-linux-tdep.h: Add include guard.
5084         * aarch64-fbsd-tdep.h: Add include guard.
5085         * aarch32-linux-nat.h: Add include guard.
5086
5087 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5088
5089         * macrotab.c (macro_define_internal): New function that
5090         factorizes macro_define_object_internal and macro_define_function
5091         code.
5092         (macro_define_object_internal): Use macro_define_internal.
5093         (macro_define_function): Likewise.
5094
5095 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5096
5097         * macrocmd.c (extract_identifier): Return
5098         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5099         callers.
5100
5101 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5102
5103         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5104
5105 2019-02-05  Tom Tromey  <tom@tromey.com>
5106
5107         * target.c (target_stack::unpush): Move assertion earlier.
5108
5109 2019-01-30  Tom Tromey  <tom@tromey.com>
5110
5111         PR python/23615:
5112         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5113         (gdbpy_parse_and_eval): Likewise.
5114         * python/python-internal.h (gdbpy_allow_threads): New class.
5115
5116 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5117
5118         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5119         (aarch64_fbsd_fpregmap): Move earlier.
5120         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5121         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5122         instead of individual calls to trad_frame_set_reg_addr.
5123         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5124         earlier.
5125         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5126         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5127         instead of individual calls to trad_frame_set_reg_addr.
5128
5129 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5130
5131         * CONTRIBUTE: Replace contribution list with wiki link.
5132
5133 2019-01-25  Tom Tromey  <tom@tromey.com>
5134
5135         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5136
5137 2019-01-25  Tom Tromey  <tom@tromey.com>
5138
5139         * xtensa-linux-nat.c: Fix common/ includes.
5140         * xml-support.h: Fix common/ includes.
5141         * xml-support.c: Fix common/ includes.
5142         * x86-linux-nat.c: Fix common/ includes.
5143         * windows-nat.c: Fix common/ includes.
5144         * varobj.h: Fix common/ includes.
5145         * varobj.c: Fix common/ includes.
5146         * value.c: Fix common/ includes.
5147         * valops.c: Fix common/ includes.
5148         * utils.c: Fix common/ includes.
5149         * unittests/xml-utils-selftests.c: Fix common/ includes.
5150         * unittests/utils-selftests.c: Fix common/ includes.
5151         * unittests/unpack-selftests.c: Fix common/ includes.
5152         * unittests/tracepoint-selftests.c: Fix common/ includes.
5153         * unittests/style-selftests.c: Fix common/ includes.
5154         * unittests/string_view-selftests.c: Fix common/ includes.
5155         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5156         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5157         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5158         * unittests/rsp-low-selftests.c: Fix common/ includes.
5159         * unittests/parse-connection-spec-selftests.c: Fix common/
5160         includes.
5161         * unittests/optional-selftests.c: Fix common/ includes.
5162         * unittests/offset-type-selftests.c: Fix common/ includes.
5163         * unittests/observable-selftests.c: Fix common/ includes.
5164         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5165         * unittests/memrange-selftests.c: Fix common/ includes.
5166         * unittests/memory-map-selftests.c: Fix common/ includes.
5167         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5168         * unittests/function-view-selftests.c: Fix common/ includes.
5169         * unittests/environ-selftests.c: Fix common/ includes.
5170         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5171         * unittests/common-utils-selftests.c: Fix common/ includes.
5172         * unittests/cli-utils-selftests.c: Fix common/ includes.
5173         * unittests/array-view-selftests.c: Fix common/ includes.
5174         * ui-file.c: Fix common/ includes.
5175         * tui/tui-io.c: Fix common/ includes.
5176         * tracepoint.h: Fix common/ includes.
5177         * tracepoint.c: Fix common/ includes.
5178         * tracefile-tfile.c: Fix common/ includes.
5179         * top.h: Fix common/ includes.
5180         * top.c: Fix common/ includes.
5181         * thread.c: Fix common/ includes.
5182         * target/waitstatus.h: Fix common/ includes.
5183         * target/waitstatus.c: Fix common/ includes.
5184         * target.h: Fix common/ includes.
5185         * target.c: Fix common/ includes.
5186         * target-memory.c: Fix common/ includes.
5187         * target-descriptions.c: Fix common/ includes.
5188         * symtab.h: Fix common/ includes.
5189         * symfile.c: Fix common/ includes.
5190         * stap-probe.c: Fix common/ includes.
5191         * spu-linux-nat.c: Fix common/ includes.
5192         * sparc-nat.c: Fix common/ includes.
5193         * source.c: Fix common/ includes.
5194         * solib.c: Fix common/ includes.
5195         * solib-target.c: Fix common/ includes.
5196         * ser-unix.c: Fix common/ includes.
5197         * ser-tcp.c: Fix common/ includes.
5198         * ser-pipe.c: Fix common/ includes.
5199         * ser-base.c: Fix common/ includes.
5200         * selftest-arch.c: Fix common/ includes.
5201         * s12z-tdep.c: Fix common/ includes.
5202         * rust-exp.y: Fix common/ includes.
5203         * rs6000-aix-tdep.c: Fix common/ includes.
5204         * riscv-tdep.c: Fix common/ includes.
5205         * remote.c: Fix common/ includes.
5206         * remote-notif.h: Fix common/ includes.
5207         * remote-fileio.h: Fix common/ includes.
5208         * remote-fileio.c: Fix common/ includes.
5209         * regcache.h: Fix common/ includes.
5210         * regcache.c: Fix common/ includes.
5211         * record-btrace.c: Fix common/ includes.
5212         * python/python.c: Fix common/ includes.
5213         * python/py-type.c: Fix common/ includes.
5214         * python/py-inferior.c: Fix common/ includes.
5215         * progspace.h: Fix common/ includes.
5216         * producer.c: Fix common/ includes.
5217         * procfs.c: Fix common/ includes.
5218         * proc-api.c: Fix common/ includes.
5219         * printcmd.c: Fix common/ includes.
5220         * ppc-linux-nat.c: Fix common/ includes.
5221         * parser-defs.h: Fix common/ includes.
5222         * osdata.c: Fix common/ includes.
5223         * obsd-nat.c: Fix common/ includes.
5224         * nat/x86-linux.c: Fix common/ includes.
5225         * nat/x86-linux-dregs.c: Fix common/ includes.
5226         * nat/x86-dregs.h: Fix common/ includes.
5227         * nat/x86-dregs.c: Fix common/ includes.
5228         * nat/ppc-linux.c: Fix common/ includes.
5229         * nat/mips-linux-watch.h: Fix common/ includes.
5230         * nat/mips-linux-watch.c: Fix common/ includes.
5231         * nat/linux-waitpid.c: Fix common/ includes.
5232         * nat/linux-ptrace.h: Fix common/ includes.
5233         * nat/linux-ptrace.c: Fix common/ includes.
5234         * nat/linux-procfs.c: Fix common/ includes.
5235         * nat/linux-personality.c: Fix common/ includes.
5236         * nat/linux-osdata.c: Fix common/ includes.
5237         * nat/linux-namespaces.c: Fix common/ includes.
5238         * nat/linux-btrace.h: Fix common/ includes.
5239         * nat/linux-btrace.c: Fix common/ includes.
5240         * nat/fork-inferior.c: Fix common/ includes.
5241         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5242         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5243         * nat/aarch64-linux.c: Fix common/ includes.
5244         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5245         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5246         * namespace.h: Fix common/ includes.
5247         * mips-linux-tdep.c: Fix common/ includes.
5248         * minsyms.c: Fix common/ includes.
5249         * mi/mi-parse.h: Fix common/ includes.
5250         * mi/mi-main.c: Fix common/ includes.
5251         * mi/mi-cmd-env.c: Fix common/ includes.
5252         * memrange.h: Fix common/ includes.
5253         * memattr.c: Fix common/ includes.
5254         * maint.h: Fix common/ includes.
5255         * maint.c: Fix common/ includes.
5256         * main.c: Fix common/ includes.
5257         * machoread.c: Fix common/ includes.
5258         * location.c: Fix common/ includes.
5259         * linux-thread-db.c: Fix common/ includes.
5260         * linux-nat.c: Fix common/ includes.
5261         * linux-fork.c: Fix common/ includes.
5262         * inline-frame.c: Fix common/ includes.
5263         * infrun.c: Fix common/ includes.
5264         * inflow.c: Fix common/ includes.
5265         * inferior.h: Fix common/ includes.
5266         * inferior.c: Fix common/ includes.
5267         * infcmd.c: Fix common/ includes.
5268         * inf-ptrace.c: Fix common/ includes.
5269         * inf-child.c: Fix common/ includes.
5270         * ia64-linux-nat.c: Fix common/ includes.
5271         * i387-tdep.c: Fix common/ includes.
5272         * i386-tdep.c: Fix common/ includes.
5273         * i386-linux-tdep.c: Fix common/ includes.
5274         * i386-linux-nat.c: Fix common/ includes.
5275         * i386-go32-tdep.c: Fix common/ includes.
5276         * i386-fbsd-tdep.c: Fix common/ includes.
5277         * i386-fbsd-nat.c: Fix common/ includes.
5278         * guile/scm-type.c: Fix common/ includes.
5279         * guile/guile.c: Fix common/ includes.
5280         * go32-nat.c: Fix common/ includes.
5281         * gnu-nat.c: Fix common/ includes.
5282         * gdbthread.h: Fix common/ includes.
5283         * gdbarch-selftests.c: Fix common/ includes.
5284         * gdb_usleep.c: Fix common/ includes.
5285         * gdb_select.h: Fix common/ includes.
5286         * gdb_bfd.c: Fix common/ includes.
5287         * gcore.c: Fix common/ includes.
5288         * fork-child.c: Fix common/ includes.
5289         * findvar.c: Fix common/ includes.
5290         * fbsd-nat.c: Fix common/ includes.
5291         * event-top.c: Fix common/ includes.
5292         * event-loop.c: Fix common/ includes.
5293         * dwarf2read.c: Fix common/ includes.
5294         * dwarf2loc.c: Fix common/ includes.
5295         * dwarf2-frame.c: Fix common/ includes.
5296         * dwarf-index-cache.c: Fix common/ includes.
5297         * dtrace-probe.c: Fix common/ includes.
5298         * disasm-selftests.c: Fix common/ includes.
5299         * defs.h: Fix common/ includes.
5300         * csky-tdep.c: Fix common/ includes.
5301         * cp-valprint.c: Fix common/ includes.
5302         * cp-support.h: Fix common/ includes.
5303         * cp-support.c: Fix common/ includes.
5304         * corelow.c: Fix common/ includes.
5305         * completer.h: Fix common/ includes.
5306         * completer.c: Fix common/ includes.
5307         * compile/compile.c: Fix common/ includes.
5308         * compile/compile-loc2c.c: Fix common/ includes.
5309         * compile/compile-cplus-types.c: Fix common/ includes.
5310         * compile/compile-cplus-symbols.c: Fix common/ includes.
5311         * command.h: Fix common/ includes.
5312         * cli/cli-dump.c: Fix common/ includes.
5313         * cli/cli-cmds.c: Fix common/ includes.
5314         * charset.c: Fix common/ includes.
5315         * build-id.c: Fix common/ includes.
5316         * btrace.h: Fix common/ includes.
5317         * btrace.c: Fix common/ includes.
5318         * breakpoint.h: Fix common/ includes.
5319         * breakpoint.c: Fix common/ includes.
5320         * ax.h:
5321         (enum agent_op): Fix common/ includes.
5322         * ax-general.c (struct aop_map): Fix common/ includes.
5323         * ax-gdb.c: Fix common/ includes.
5324         * auxv.c: Fix common/ includes.
5325         * auto-load.c: Fix common/ includes.
5326         * arm-tdep.c: Fix common/ includes.
5327         * arch/riscv.c: Fix common/ includes.
5328         * arch/ppc-linux-common.c: Fix common/ includes.
5329         * arch/i386.c: Fix common/ includes.
5330         * arch/arm.c: Fix common/ includes.
5331         * arch/arm-linux.c: Fix common/ includes.
5332         * arch/arm-get-next-pcs.c: Fix common/ includes.
5333         * arch/amd64.c: Fix common/ includes.
5334         * arch/aarch64.c: Fix common/ includes.
5335         * arch/aarch64-insn.c: Fix common/ includes.
5336         * arch-utils.c: Fix common/ includes.
5337         * amd64-windows-tdep.c: Fix common/ includes.
5338         * amd64-tdep.c: Fix common/ includes.
5339         * amd64-sol2-tdep.c: Fix common/ includes.
5340         * amd64-obsd-tdep.c: Fix common/ includes.
5341         * amd64-nbsd-tdep.c: Fix common/ includes.
5342         * amd64-linux-tdep.c: Fix common/ includes.
5343         * amd64-linux-nat.c: Fix common/ includes.
5344         * amd64-fbsd-tdep.c: Fix common/ includes.
5345         * amd64-fbsd-nat.c: Fix common/ includes.
5346         * amd64-dicos-tdep.c: Fix common/ includes.
5347         * amd64-darwin-tdep.c: Fix common/ includes.
5348         * agent.c: Fix common/ includes.
5349         * ada-lang.h: Fix common/ includes.
5350         * ada-lang.c: Fix common/ includes.
5351         * aarch64-tdep.c: Fix common/ includes.
5352
5353 2019-01-25  Tom Tromey  <tom@tromey.com>
5354
5355         * common/create-version.sh: Use common/version.h.
5356
5357 2019-01-24  Pedro Alves  <palves@redhat.com>
5358
5359         * infrun.c (signal_stop, signal_print, signal_program)
5360         (signal_catch, signal_pass): Now arrays instead of pointers.
5361         (update_signals_program_target, do_target_resume)
5362         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5363         * linux-nat.c (linux_nat_target::pass_signals)
5364         (linux_nat_target::create_inferior, linux_nat_target::attach):
5365         Adjust.
5366         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5367         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5368         * procfs.c (procfs_target::pass_signals): Adjust.
5369         * record-full.c (record_full_target::resume): Adjust.
5370         * remote.c (remote_target::pass_signals)
5371         (remote_target::program_signals): Adjust.
5372         * target-debug.h (target_debug_print_signals): Now takes a
5373         gdb::array_view as parameter.  Adjust.
5374         * target.h (target_ops) <pass_signals, program_signals>: Replace
5375         pointer and length parameters with gdb::array_view.
5376         (target_pass_signals, target_program_signals): Likewise.
5377         * target-delegates.c: Regenerate.
5378
5379 2019-01-24  Pedro Alves  <palves@redhat.com>
5380
5381         * common/forward-scope-exit.h
5382         (forward_scope_exit::forward_scope_exit): Pass arguments to
5383         m_bind_function directly, instead of creating a std::bind and
5384         copying that.
5385
5386 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5387
5388         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5389         for static members.
5390         (pass_in_v_vfp_candidate): Likewise.
5391
5392 2019-01-23  Tom Tromey  <tom@tromey.com>
5393             Pedro Alves  <palves@redhat.com>
5394
5395         * regcache.c (class regcache_invalidator): Remove.
5396         (regcache::raw_write): Use make_scope_exit.
5397
5398 2019-01-23  Tom Tromey  <tom@tromey.com>
5399
5400         * ui-out.h (class ui_out_emit_type): Update comment.
5401
5402 2019-01-23  Tom Tromey  <tom@tromey.com>
5403
5404         * infrun.c (fetch_inferior_event): Update comment.
5405
5406 2019-01-23  Tom Tromey  <tom@tromey.com>
5407             Pedro Alves  <palves@redhat.com>
5408
5409         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5410         parameter.
5411         (fetch_inferior_event): Use SCOPE_EXIT.
5412
5413
5414 2019-01-23  Tom Tromey  <tom@tromey.com>
5415             Pedro Alves  <palves@redhat.com>
5416
5417         * infrun.c (disable_thread_events): Delete.
5418         (stop_all_threads): Use SCOPE_EXIT.
5419
5420 2019-01-23  Tom Tromey  <tom@tromey.com>
5421             Pedro Alves  <palves@redhat.com>
5422
5423         * symfile.c: Include forward-scope-exit.h.
5424         (clear_symtab_users_cleanup): Replace forward declaration with
5425         a FORWARD_SCOPE_EXIT.
5426         (syms_from_objfile_1): Use the forward_scope_exit and
5427         gdb::optional instead of cleanup_function.
5428         (reread_symbols): Use the forward_scope_exit instead of
5429         cleanup_function.
5430         (clear_symtab_users_cleanup): Remove function.
5431
5432 2019-01-23  Tom Tromey  <tom@tromey.com>
5433             Pedro Alves  <palves@redhat.com>
5434
5435         * linux-nat.c: Include scope-exit.h.
5436         (cleanup_target_stop): Remove.
5437         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5438         SCOPE_EXIT.
5439
5440 2019-01-23  Tom Tromey  <tom@tromey.com>
5441             Pedro Alves  <palves@redhat.com>
5442
5443         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5444         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5445
5446 2019-01-23  Tom Tromey  <tom@tromey.com>
5447             Andrew Burgess  <andrew.burgess@embecosm.com>
5448             Pedro Alves  <palves@redhat.com>
5449
5450         * infrun.c (fetch_inferior_event): Use scope_exit.
5451         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5452         * top.c (execute_command): Use scope_exit.
5453         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5454         * utils.c (do_bpstat_clear_actions_cleanup)
5455         (make_bpstat_clear_actions_cleanup): Remove.
5456
5457 2019-01-23  Tom Tromey  <tom@tromey.com>
5458             Pedro Alves  <palves@redhat.com>
5459
5460         * infrun.c: Include "common/scope-exit.h"
5461         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5462         (wait_for_inferior): Use SCOPE_EXIT.
5463         (fetch_inferior_event): Use scope_exit.
5464
5465 2019-01-23  Tom Tromey  <tom@tromey.com>
5466             Pedro Alves  <palves@redhat.com>
5467
5468         * breakpoint.c (create_breakpoint): Remove cleanup.
5469
5470 2019-01-23  Tom Tromey  <tom@tromey.com>
5471             Andrew Burgess  <andrew.burgess@embecosm.com>
5472             Pedro Alves  <palves@redhat.com>
5473
5474 2019-01-23  Pedro Alves  <palves@redhat.com>
5475
5476         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5477
5478 2019-01-23  Pedro Alves  <palves@redhat.com>
5479             Andrew Burgess  <andrew.burgess@embecosm.com>
5480
5481         * gdbthread.h: Include "common/forward-scope-exit.h".
5482         (scoped_finish_thread_state): Redefine custom class in terms of
5483         forward_scope_exit.
5484
5485 2019-01-23  Pedro Alves  <palves@redhat.com>
5486             Andrew Burgess  <andrew.burgess@embecosm.com>
5487
5488         * common/forward-scope-exit.h: New file.
5489
5490 2019-01-23  Pedro Alves  <palves@redhat.com>
5491             Andrew Burgess  <andrew.burgess@embecosm.com>
5492             Tom Tromey  <tom@tromey.com>
5493
5494         * common/scope-exit.h: New file.
5495
5496 2019-01-23  Pedro Alves  <palves@redhat.com>
5497
5498         * common/preprocessor.h (ESC): Rename to ...
5499         (ESC_PARENS): ... this.
5500         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5501         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5502
5503 2019-01-23  Tom Tromey  <tom@tromey.com>
5504
5505         * language.h (class scoped_switch_to_sym_language_if_auto):
5506         Initialize m_lang in both cases.
5507
5508 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5509
5510         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5511         with XCNEW.
5512
5513 2019-01-22  Tom Tromey  <tom@tromey.com>
5514
5515         * corelow.c: Do not include sys/file.h.
5516
5517 2019-01-22  Tom Tromey  <tom@tromey.com>
5518
5519         * tui/tui-wingeneral.h: Include gdb_curses.h.
5520
5521 2019-01-22  Tom Tromey  <tom@tromey.com>
5522
5523         * source-cache.h (class source_cache) <get_source_lines,
5524         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5525
5526 2019-01-22  Tom Tromey  <tom@tromey.com>
5527
5528         * remote-fileio.h (struct remote_target): Declare.
5529
5530 2019-01-22  Tom Tromey  <tom@tromey.com>
5531
5532         * python/py-arch.c: Do not include py-ref.h.
5533         * python/py-bpevent.c: Do not include py-ref.h.
5534         * python/py-cmd.c: Do not include py-ref.h.
5535         * python/py-continueevent.c: Do not include py-ref.h.
5536         * python/py-event.h: Do not include py-ref.h.
5537         * python/py-evtregistry.c: Do not include py-ref.h.
5538         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5539         * python/py-frame.c: Do not include py-ref.h.
5540         * python/py-framefilter.c: Do not include py-ref.h.
5541         * python/py-function.c: Do not include py-ref.h.
5542         * python/py-infevents.c: Do not include py-ref.h.
5543         * python/py-linetable.c: Do not include py-ref.h.
5544         * python/py-objfile.c: Do not include py-ref.h.
5545         * python/py-param.c: Do not include py-ref.h.
5546         * python/py-prettyprint.c: Do not include py-ref.h.
5547         * python/py-progspace.c: Do not include py-ref.h.
5548         * python/py-symbol.c: Do not include py-ref.h.
5549         * python/py-symtab.c: Do not include py-ref.h.
5550         * python/py-type.c: Do not include py-ref.h.
5551         * python/py-unwind.c: Do not include py-ref.h.
5552         * python/py-utils.c: Do not include py-ref.h.
5553         * python/py-value.c: Do not include py-ref.h.
5554         * python/py-varobj.c: Do not include py-ref.h.
5555         * python/py-xmethods.c: Do not include py-ref.h.
5556         * python/python.c: Do not include py-ref.h.
5557         * varobj.c: Do not include py-ref.h.
5558
5559 2019-01-22  Tom Tromey  <tom@tromey.com>
5560
5561         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5562         keyword for bcache.
5563
5564 2019-01-22  Tom Tromey  <tom@tromey.com>
5565
5566         * compile/compile-cplus-types.c: Remove a comment by #include.
5567
5568 2019-01-22  Tom Tromey  <tom@tromey.com>
5569
5570         * compile/gcc-c-plugin.h: Include compile-internal.h.
5571
5572 2019-01-22  Tom Tromey  <tom@tromey.com>
5573
5574         * stabsread.c (EXTERN): Do not define.
5575         (symnum, next_symbol_text_func, processing_gcc_compilation)
5576         (within_function, global_sym_chain, global_stabs)
5577         (previous_stab_code, this_object_header_files)
5578         (n_this_object_header_files)
5579         (n_allocated_this_object_header_files): Define.
5580         * stabsread.h (EXTERN): Never define.  Use "extern".
5581
5582 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5583
5584         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5585         history_value.
5586
5587 2019-01-21  Tom Tromey  <tom@tromey.com>
5588
5589         * ui-out.c: Fix includes.
5590         * tui/tui-source.c: Fix includes.
5591         * target.c: Fix includes.
5592         * remote.c: Fix includes.
5593         * regcache.c: Fix includes.
5594         * python/py-block.c: Fix includes.
5595         * printcmd.c: Fix includes.
5596         * or1k-tdep.c: Fix includes.
5597         * mi/mi-main.c: Fix includes.
5598         * m32r-tdep.c: Fix includes.
5599         * csky-tdep.c: Fix includes.
5600         * compile/compile-cplus-types.c: Fix includes.
5601         * cli/cli-interp.c: Fix includes.
5602
5603 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5604
5605         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5606         for padding.
5607
5608 2019-01-16  Tom Tromey  <tom@tromey.com>
5609
5610         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5611         earlier.
5612         (struct objfile) <msymbols_range>: Move from top level.
5613         <msymbols>: New method.
5614         (class objfile_msymbols): Remove.
5615         * symtab.c (default_collect_symbol_completion_matches_break_on):
5616         Update.
5617         * symmisc.c (dump_msymbols): Update.
5618         * stabsread.c (scan_file_globals): Update.
5619         * objc-lang.c (info_selectors_command, info_classes_command)
5620         (find_methods): Update.
5621         * minsyms.c (find_solib_trampoline_target): Update.
5622         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5623         * coffread.c (coff_symfile_read): Update.
5624         * ada-lang.c (ada_lookup_simple_minsym)
5625         (ada_collect_symbol_completion_matches): Update.
5626
5627 2019-01-16  Tom Tromey  <tom@tromey.com>
5628
5629         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5630         type.  Remove no-argument constructor.
5631         <iterator::operator++>: Simplify.
5632         <begin>: Update.
5633         <end>: Use minimal_symbol_count.
5634
5635 2019-01-16  Tom Tromey  <tom@tromey.com>
5636
5637         * objfiles.h (struct objfile) <psymtabs>: New method.
5638         (class objfile_psymtabs): Remove.
5639         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5640         typedef.
5641         <range>: New method.
5642         (require_partial_symbols): Change return type.
5643         * psymtab.c (require_partial_symbols)
5644         (psym_expand_symtabs_matching): Update.
5645         * mdebugread.c (parse_partial_symbols): Update.
5646         * dbxread.c (dbx_end_psymtab): Update.
5647
5648 2019-01-15  Tom Tromey  <tom@tromey.com>
5649
5650         * symtab.c (lookup_objfile_from_block)
5651         (lookup_symbol_in_objfile_symtabs)
5652         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5653         (find_line_symtab, info_sources_command)
5654         (default_collect_symbol_completion_matches_break_on)
5655         (make_source_files_completion_list): Update.
5656         * symmisc.c (print_objfile_statistics, dump_objfile)
5657         (maintenance_print_symbols, maintenance_info_symtabs)
5658         (maintenance_check_symtabs, maintenance_info_line_tables):
5659         Update.
5660         * source.c (select_source_symtab)
5661         (forget_cached_source_info_for_objfile): Update.
5662         * objfiles.h (class objfile_compunits): Remove.
5663         (struct objfile) <compunits_range>: New typedef.
5664         (compunits): New method.
5665         * objfiles.c (objfile_relocate1): Update.
5666         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5667         * maint.c (count_symtabs_and_blocks): Update.
5668         * linespec.c (iterate_over_all_matching_symtabs): Update.
5669         * cp-support.c (add_symbol_overload_list_qualified): Update.
5670         * coffread.c (coff_symtab_read): Update.
5671         * ada-lang.c (add_nonlocal_symbols)
5672         (ada_collect_symbol_completion_matches)
5673         (ada_add_global_exceptions): Update.
5674
5675 2019-01-15  Tom Tromey  <tom@tromey.com>
5676
5677         * progspace.h (program_space) <objfiles_safe_range>: New
5678         typedef.
5679         <objfiles_safe>: New method.
5680         * objfiles.h (class all_objfiles_safe): Remove.
5681         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5682         * jit.c (jit_inferior_exit_hook): Update.
5683
5684 2019-01-17  Tom Tromey  <tom@tromey.com>
5685
5686         * progspace.h (program_space) <objfiles_range>: New typedef.
5687         <objfiles>: New method.
5688         <objfiles_head>: Rename from objfiles.
5689         (object_files): Update.
5690         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5691         * guile/scm-pretty-print.c
5692         (ppscm_find_pretty_printer_from_objfiles): Update.
5693         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5694         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5695         Update.
5696         * python/py-progspace.c (pspy_get_objfiles): Update.
5697         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5698         Update.
5699         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5700         (objfpy_lookup_objfile_by_build_id): Update.
5701         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5702         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5703         Update.
5704         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5705         (expand_symtab_containing_pc, lookup_objfile_from_block)
5706         (lookup_static_symbol, basic_lookup_transparent_type)
5707         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5708         (find_line_symtab, info_sources_command)
5709         (default_collect_symbol_completion_matches_break_on)
5710         (make_source_files_completion_list, find_main_name): Update.
5711         * symmisc.c (print_symbol_bcache_statistics)
5712         (print_objfile_statistics, maintenance_print_symbols)
5713         (maintenance_print_msymbols, maintenance_print_objfiles)
5714         (maintenance_info_symtabs, maintenance_check_symtabs)
5715         (maintenance_expand_symtabs, maintenance_info_line_tables):
5716         Update.
5717         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5718         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5719         (map_overlay_command, unmap_overlay_command)
5720         (simple_overlay_update, expand_symtabs_matching)
5721         (map_symbol_filenames): Update.
5722         * symfile-debug.c (set_debug_symfile): Update.
5723         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5724         Update.
5725         * source.c (select_source_symtab, forget_cached_source_info):
5726         Update.
5727         * solib.c (solib_read_symbols): Update.
5728         * solib-spu.c (append_ocl_sos): Update.
5729         * psymtab.c (maintenance_print_psymbols)
5730         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5731         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5732         * printcmd.c (info_symbol_command): Update.
5733         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5734         Update.
5735         * objfiles.h (class all_objfiles): Remove.
5736         * objfiles.c (have_partial_symbols, have_full_symbols)
5737         (have_minimal_symbols, qsort_cmp, update_section_map)
5738         (shared_objfile_contains_address_p)
5739         (default_iterate_over_objfiles_in_search_order): Update.
5740         * objc-lang.c (info_selectors_command, info_classes_command)
5741         (find_methods): Update.
5742         * minsyms.c (find_solib_trampoline_target): Update.
5743         * maint.c (maintenance_info_sections)
5744         (maintenance_translate_address, count_symtabs_and_blocks):
5745         Update.
5746         * main.c (captured_main_1): Update.
5747         * linux-thread-db.c (try_thread_db_load_from_pdir)
5748         (has_libpthread): Update.
5749         * linespec.c (iterate_over_all_matching_symtabs)
5750         (search_minsyms_for_name): Update.
5751         * jit.c (jit_find_objf_with_entry_addr): Update.
5752         * hppa-tdep.c (find_unwind_entry)
5753         (hppa_lookup_stub_minimal_symbol): Update.
5754         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5755         Update.
5756         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5757         (elf_gnu_ifunc_resolve_by_got): Update.
5758         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5759         * dwarf-index-write.c (save_gdb_index_command): Update.
5760         * cp-support.c (add_symbol_overload_list_qualified): Update.
5761         * breakpoint.c (create_overlay_event_breakpoint)
5762         (create_longjmp_master_breakpoint)
5763         (create_std_terminate_master_breakpoint)
5764         (create_exception_master_breakpoint): Update.
5765         * blockframe.c (find_pc_partial_function): Update.
5766         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5767         (ada_collect_symbol_completion_matches)
5768         (ada_add_global_exceptions): Update.
5769
5770 2019-01-17  Tom Tromey  <tom@tromey.com>
5771
5772         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5773         declare VEC.
5774         (solib_target_parse_libraries): Change return type.
5775         (library_list_start_segment, library_list_start_section)
5776         (library_list_end_library, library_list_start_library); Update.
5777         (solib_target_free_library_list): Remove.
5778         (solib_target_parse_libraries): Remove cleanup.  Change return
5779         type.
5780         (solib_target_current_sos): Update.
5781
5782 2019-01-17  Tom Tromey  <tromey@bapiya>
5783
5784         * valprint.c: Replace "the the" with "the".
5785         * symtab.c: Replace "the the" with "the".
5786         * solib.c: Replace "the the" with "the".
5787         * solib-dsbt.c: Replace "the the" with "the".
5788         * linespec.c: Replace "the the" with "the".
5789         * dwarf2loc.h: Replace "the the" with "the".
5790         * amd64-windows-tdep.c: Replace "the the" with "the".
5791         * aarch64-tdep.c: Replace "the the" with "the".
5792
5793 2019-01-16  Keith Seitz  <keiths@redhat.com>
5794
5795         PR gdb/23773
5796         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5797         <builder>: Rename to ..
5798         <m_builder>: ... this and make private.
5799         (dwarf2_cu::get_builder): New method.  Change all users of
5800         `builder' to use this method.
5801         (dwarf2_start_symtab): Move to ...
5802         (dwarf2_cu::start_symtab): ... here.  Update all callers
5803         (setup_type_unit_groups): Move to ...
5804         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5805         callers.
5806         (dwarf2_cu::reset_builder): New method.
5807         (process_full_compunit, process_full_type_unit): Use
5808         dwarf2_cu::reset_builder.
5809         (follow_die_offset): Record the ancestor CU if it is different
5810         from the followed DIE's CU.
5811         (follow_die_sig_1): Likewise.
5812
5813 2019-01-15  Tom Tromey  <tom@tromey.com>
5814
5815         * remote.c (class remote_state) <buf>: Now a char_vector.
5816         <buf_size>: Remove.
5817         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5818         parameter.
5819         (remote_target::getpkt_or_notif_sane_1)
5820         (remote_target::getpkt_sane)
5821         (remote_target::getpkt_or_notif_sane): Likewise.
5822         (class remote_target) <putpkt>: New overload.
5823         (remote_target::read_frame): Change type of "buf_p".  Remove
5824         sizeof_p parameter.
5825         (packet_ok): New overload.
5826         (packet_check_result): New overload.
5827         Update all uses.
5828
5829 2019-01-14  Tom Tromey  <tom@tromey.com>
5830
5831         * remote-notif.c (handle_notification, remote_notif_ack)
5832         (remote_notif_parse): Make "buf" const.
5833         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5834         const.
5835         (remote_notif_parse, remote_notif_ack, handle_notification):
5836         Likewise.
5837         * remote.c (remote_notif_stop_parse): Make "buf" const.
5838         (remote_target::remote_parse_stop_reply): Make "buf" const.
5839         (remote_notif_stop_ack): Make "buf" const.
5840
5841 2019-01-14  Tom Tromey  <tom@tromey.com>
5842
5843         * remote.c (remote_console_output): Make parameter const.
5844
5845 2019-01-14  Tom Tromey  <tom@tromey.com>
5846
5847         * target-debug.h (target_debug_print_signals): Constify.
5848         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5849         * procfs.c (procfs_target::pass_signals): Update.
5850         * linux-nat.c (linux_nat_target::pass_signals): Update.
5851         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5852         * target-delegates.c: Rebuild.
5853         * remote.c (remote_target::program_signals): Update.
5854         (remote_target::pass_signals): Update.
5855         * target.c (target_pass_signals): Constify argument.
5856         (target_program_signals): Likewise.
5857         * target.h (struct target_ops) <pass_signals, program_signals>:
5858         Constify argument.
5859         (target_pass_signals, target_program_signals): Constify argument.
5860
5861 2019-01-14  Tom Tromey  <tom@tromey.com>
5862
5863         PR tui/28819:
5864         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5865
5866 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5867
5868         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5869         field.
5870         * rs6000-tdep.c: Include reggroups.h.
5871         (IS_V_ALIAS_PSEUDOREG): Define.
5872         (rs6000_register_name): Return names for the "vX" aliases.
5873         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5874         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5875         aliases.  Call default_register_reggroup_p for all other
5876         pseudo-registers.
5877         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5878         New functions.
5879         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5880         Handle "vX" aliases.
5881         (v_alias_pseudo_register_collect): New function.
5882         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5883         (rs6000_gdbarch_init): Initialize "vX" aliases as
5884         pseudo-registers.  Restore registration of
5885         rs6000_pseudo_register_reggroup_p with
5886         set_tdesc_pseudo_register_reggroup_p.
5887
5888 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5889
5890         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5891         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5892         set_gdbarch_num_pseudo_regs.
5893
5894 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5895
5896         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5897         Remove arg prefixname, add do_set and do_show.
5898         Add member functions set_list and show_list.
5899         * cli/cli-style.c (class cli_style_option): Update accordingly.
5900         (style_set_list): Move to file scope.
5901         (style_show_list): Likewise.
5902         (set_style): Call help_list.
5903         (show_style): Call cmd_show_list.
5904         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5905         Update to use the new macro.
5906
5907 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5908
5909         * ada-lang.c (_initialize_ada_language): Expand the help text
5910         for the "catch exception" command.
5911
5912 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5913
5914         * symtab.c (matching_obj_sections): Initialize obj,
5915         declare it closer to its usage.
5916
5917 2019-01-10  Tom Tromey  <tom@tromey.com>
5918
5919         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5920         (basic_inf_threads_range): Remove.
5921         (inf_threads_range, inf_non_exited_threads_range)
5922         (safe_inf_threads_range): Use next_adapter.
5923
5924 2019-01-10  Keith Seitz  <keiths@redhat.com>
5925
5926         PR gdb/23712
5927         PR symtab/23010
5928         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5929         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5930
5931 2019-01-10  Keith Seitz  <keiths@redhat.com>
5932
5933         PR gdb/23712
5934         PR symtab/23010
5935         * dictionary.c (pending_to_vector): Remove.
5936         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5937         Remove _1 suffix, replacing functions of the same name.  Update
5938         all callers.
5939         (dict_create_hashed, dict_create_hashed_expandable)
5940         (dict_create_linear, dict_create_linear_expandable, dict_free)
5941         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5942         Make functions static.
5943
5944 2019-01-10  Keith Seitz  <keiths@redhat.com>
5945
5946         PR gdb/23712
5947         PR symtab/23010
5948         * dictionary.h (struct dictionary): Replace declaration with
5949         multidictionary.
5950         (dict_create_hashed, dict_create_hashed_expandable)
5951         (dict_create_linear, dict_create_linear_expandable)
5952         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5953         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5954         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5955         taking multidictionary argument.
5956         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5957         * block.h (struct block) <dict>: Change to multidictionary
5958         and rename `multidict'.
5959         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5960         symmisc.c: Update all dictionary references to multidictionary.
5961
5962 2019-01-10  Keith Seitz  <keiths@redhat.com>
5963
5964         PR gdb/23712
5965         PR symtab/23010
5966         * dictionary.c: Include unordered_map.
5967         (pending_to_vector): New function.
5968         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5969         Rewrite the non-"_1" functions to take vector instead
5970         of linked list.
5971         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5972         "new" _1 versions of the same name.
5973         (multidictionary): Define.
5974         (std::hash<enum language): New definition.
5975         (collate_pending_symbols_by_language, mdict_create_hashed)
5976         (mdict_create_hashed_expandable, mdict_create_linear)
5977         (mdict_create_linear_expandable, mdict_free)
5978         (find_language_dictionary, create_new_language_dictionary)
5979         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5980         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5981         (mdict_size, mdict_empty): New functions.
5982         * dictionary.h (mdict_iterator): Define.
5983
5984 2019-01-10  Pedro Alves  <palves@redhat.com>
5985
5986         * breakpoint.c (read_uploaded_action)
5987         (create_tracepoint_from_upload): Adjust to use
5988         gdb::unique_xmalloc_ptr.
5989         * ctf.c (ctf_write_uploaded_tp):
5990         (SET_ARRAY_FIELD): Use emplace_back.
5991         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5992         * tracefile-tfile.c (tfile_write_uploaded_tp):
5993         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5994         gdb::unique_xmalloc_ptr.
5995         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5996         at_string, cond_string, cmd_strings>: Replace char pointers
5997         with gdb::unique_xmalloc_ptr.
5998
5999 2019-01-10  Pedro Alves  <palves@redhat.com>
6000
6001         * solib-target.c (library_list_start_library): Don't xstrdup name.
6002
6003 2019-01-10  Pedro Alves  <palves@redhat.com>
6004
6005         * mdebugread.c (parse_partial_symbols): Use
6006         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
6007
6008 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6009
6010         * linux-fork.c (scoped_switch_fork_info)
6011         <~scoped_switch_fork_info>: Fix incorrect variable name.
6012
6013 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6014
6015         * linux-fork.c (scoped_switch_fork_info)
6016         <scoped_switch_fork_info>: Make explicit.
6017         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
6018
6019 2019-01-10  Tom Tromey  <tom@tromey.com>
6020
6021         * objfiles.h (objfile::reset_psymtabs): Update.
6022         * objfiles.c (objfile::objfile): Update.
6023         * psymtab.h (psymtab_storage::obstack): Update.
6024         (psymtab_storage::m_obstack): Use gdb::optional.
6025         (class psymtab_storage): Update comment.  Remove objfile
6026         parameter.
6027         * psymtab.c (psymtab_storage::psymtab_storage): Update.
6028
6029 2019-01-10  Tom Tromey  <tom@tromey.com>
6030
6031         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
6032         <free_psymtabs>: Now private.
6033         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
6034         (allocate_psymtab): Use new method.
6035
6036 2019-01-10  Tom Tromey  <tom@tromey.com>
6037
6038         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
6039         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
6040         * mdebugread.c (parse_partial_symbols): Use
6041         allocate_dependencies.
6042         * dwarf2read.c (dwarf2_create_include_psymtab): Use
6043         allocate_dependencies.
6044         (process_psymtab_comp_unit_reader)
6045         (build_type_psymtab_dependencies): Likewise.
6046         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
6047
6048 2019-01-10  Tom Tromey  <tom@tromey.com>
6049
6050         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
6051         PSYMBOL_SET_LANGUAGE.
6052         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
6053
6054 2019-01-10  Tom Tromey  <tom@tromey.com>
6055
6056         * psymtab.h (psymtab_storage::obstack): New method.
6057         <m_obstack>: Rename from obstack; now private.
6058         * psymtab.c (psymtab_storage): Update.
6059         * dwarf2read.c (create_addrmap_from_index)
6060         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
6061         Update.
6062
6063 2019-01-10  Tom Tromey  <tom@tromey.com>
6064
6065         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
6066         * objfiles.h (objfile::reset_psymtabs): New method.
6067
6068 2019-01-10  Tom Tromey  <tom@tromey.com>
6069
6070         * symmisc.c (print_symbol_bcache_statistics): Update.
6071         (print_objfile_statistics): Update.
6072         * symfile.c (reread_symbols): Update.
6073         * psymtab.h (class psymtab_storage): New.
6074         * psymtab.c (psymtab_storage): New constructor.
6075         (~psymtab_storage): New destructor.
6076         (require_partial_symbols): Update.
6077         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
6078         (find_pc_sect_psymtab, find_pc_sect_psymbol)
6079         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
6080         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
6081         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
6082         (start_psymtab_common, end_psymtab_common)
6083         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
6084         (allocate_psymtab): Update.
6085         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
6086         Update.
6087         (dump_psymtab_addrmap, maintenance_print_psymbols)
6088         (maintenance_check_psymtabs): Update.
6089         (class objfile_psymtabs): Move to objfiles.h.
6090         * psympriv.h (discard_psymtab): Now inline.
6091         (psymtab_discarder::psymtab_discarder): Update.
6092         (psymtab_discarder::~psymtab_discarder): Update.
6093         (ALL_OBJFILE_PSYMTABS): Rewrite.
6094         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6095         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6096         Remove fields.
6097         <partial_symtabs>: New field.
6098         (class objfile_psymtabs): Move from psymtab.h.  Update.
6099         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6100         psymbol_cache.
6101         (objfile::~objfile): Don't destroy psymbol_cache.
6102         * mdebugread.c (parse_partial_symbols): Update.
6103         * dwarf2read.c (create_addrmap_from_index)
6104         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6105         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6106         (add_partial_subprogram, dwarf2_ranges_read): Update.
6107         * dwarf-index-write.c (write_address_map)
6108         (write_one_signatured_type, recursively_write_psymbols)
6109         (class debug_names, class debug_names, write_psymtabs_to_index):
6110         Update.
6111
6112 2019-01-10  Tom Tromey  <tom@tromey.com>
6113
6114         * symtab.h (SYMBOL_SET_NAMES): Update.
6115         (symbol_set_names): Update.
6116         (MSYMBOL_SET_NAMES): Update.
6117         * symtab.c (symbol_set_names): Change argument to be an
6118         objfile_per_bfd_storage.
6119         * psymtab.c (add_psymbol_to_bcache): Update.
6120         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6121
6122 2019-01-10  Tom Tromey  <tom@tromey.com>
6123
6124         * symtab.c (create_demangled_names_hash): Change argument to be an
6125         objfile_per_bfd_storage.
6126         (symbol_set_names): Update.
6127
6128 2019-01-10  Tom Tromey  <tom@tromey.com>
6129
6130         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6131         init_psymbol_list.
6132         * psymtab.c (init_psymbol_list): Do nothing if already called.
6133         * psympriv.h (init_psymbol_list): Add comment.
6134         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6135         init_psymbol_list.
6136         * dbxread.c (dbx_symfile_read): Unconditionally call
6137         init_psymbol_list.
6138
6139 2019-01-10  Tom Tromey  <tom@tromey.com>
6140
6141         * xcoffread.c (scan_xcoff_symtab): Update.
6142         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6143         "where".
6144         * mdebugread.c (parse_partial_symbols)
6145         (handle_psymbol_enumerators): Update.
6146         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6147         * dbxread.c (read_dbx_symtab): Update.
6148         * psympriv.h (psymbol_placement): New enum.
6149         (add_psymbol_to_list): Update.
6150
6151 2019-01-10  Tom Tromey  <tom@tromey.com>
6152
6153         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6154         static_psymbols parameters.
6155         (scan_xcoff_symtab): Update.
6156         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6157         static_psymbols parameters.
6158         * psympriv.h (start_psymtab_common): Update.
6159         * mdebugread.c (parse_partial_symbols): Update.
6160         * dwarf2read.c (create_partial_symtab): Update.
6161         * dbxread.c (read_dbx_symtab): Update.
6162         (start_psymtab): Remove global_psymbols and static_psymbols
6163         parameters.
6164
6165 2019-01-10  Tom Tromey  <tom@tromey.com>
6166
6167         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6168         * psymtab.c (allocate_psymtab): Add comment.
6169         * psympriv.h (allocate_psymtab): Add comment.
6170         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6171         initializations.
6172         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6173
6174 2019-01-10  Tom Tromey  <tom@tromey.com>
6175
6176         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6177         Don't declare.
6178         * mipsread.c: Include mdebugread.h.
6179         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6180         Declare.
6181         * elfread.c: Include mdebugread.h.
6182
6183 2019-01-09  Tom Tromey  <tom@tromey.com>
6184
6185         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6186         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6187         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6188         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6189         (psym_lookup_symbol, psym_find_last_source_symtab)
6190         (psym_forget_cached_source_info, psym_print_stats)
6191         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6192         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6193         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6194         (psym_find_compunit_symtab_by_address)
6195         (maintenance_print_psymbols, maintenance_info_psymtabs)
6196         (maintenance_check_psymtabs): Use ranged for.
6197         * psymtab.h (class objfile_psymtabs): New.
6198         (require_partial_symbols): Return objfile_psymtabs.
6199         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6200
6201 2019-01-09  Tom Tromey  <tom@tromey.com>
6202
6203         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6204         (find_pc_mapped_section, list_overlays_command)
6205         (map_overlay_command, unmap_overlay_command)
6206         (simple_overlay_update): Use all_objfiles.
6207         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6208         * printcmd.c (info_symbol_command): Use all_objfiles.
6209         * objfiles.h (ALL_OBJSECTIONS): Remove.
6210         * maint.c (maintenance_translate_address): Use all_objfiles.
6211         * gcore.c (gcore_create_callback): Use all_objfiles.
6212         (objfile_find_memory_regions): Likewise.
6213
6214 2019-01-09  Tom Tromey  <tom@tromey.com>
6215
6216         * symtab.c (find_line_symtab, info_sources_command)
6217         (make_source_files_completion_list): Use objfile_compunits.
6218         * source.c (select_source_symtab): Use objfile_compunits.
6219         * objfiles.h (struct objfile): Update comment.
6220         (ALL_OBJFILES): Remove.
6221         (ALL_FILETABS): Remove.
6222         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6223         objfile_compunits.
6224
6225 2019-01-09  Tom Tromey  <tom@tromey.com>
6226
6227         * symmisc.c (print_objfile_statistics, dump_objfile)
6228         (maintenance_print_symbols): Use compunit_filetabs.
6229         * source.c (forget_cached_source_info_for_objfile): Use
6230         compunit_filetabs.
6231         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6232         (ALL_FILETABS): Use compunit_filetabs.
6233         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6234         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6235
6236 2019-01-09  Tom Tromey  <tom@tromey.com>
6237
6238         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6239         (compunit_filetabs): New.
6240         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6241         compunit_filetabs.
6242         (info_sources_command, make_source_files_completion_list): Remove
6243         declaration.
6244         * symmisc.c (print_objfile_statistics, dump_objfile)
6245         (maintenance_print_symbols): Remove declaration.
6246         (maintenance_info_symtabs): Use compunit_filetabs.
6247         (maintenance_info_line_tables): Likewise.
6248         * source.c (select_source_symtab): Change local variable name.
6249         (forget_cached_source_info_for_objfile): Remove declaration.
6250         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6251         * objfiles.c (objfile_relocate1): Remove declaration.
6252         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6253         declaration.
6254         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6255         * coffread.c (coff_symtab_read): Remove declaration.
6256         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6257         compunit_filetabs.
6258
6259 2019-01-09  Tom Tromey  <tom@tromey.com>
6260
6261         * symtab.c (lookup_objfile_from_block)
6262         (find_pc_sect_compunit_symtab, search_symbols)
6263         (default_collect_symbol_completion_matches_break_on): Use
6264         objfile_compunits.
6265         * objfiles.h (ALL_COMPUNITS): Remove.
6266         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6267         * cp-support.c (add_symbol_overload_list_qualified): Use
6268         objfile_compunits.
6269         * ada-lang.c (ada_collect_symbol_completion_matches)
6270         (ada_add_global_exceptions): Use objfile_compunits.
6271
6272 2019-01-09  Tom Tromey  <tom@tromey.com>
6273
6274         * source.c (select_source_symtab)
6275         (forget_cached_source_info_for_objfile): Remove declaration.
6276         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6277         declaration.
6278         * maint.c (count_symtabs_and_blocks): Remove declaration.
6279         * cp-support.c (add_symbol_overload_list_qualified): Remove
6280         declaration.
6281         * coffread.c (coff_symtab_read): Remove declaration.
6282         * symtab.c (lookup_symbol_in_objfile_symtabs)
6283         (basic_lookup_transparent_type_1): Use objfile_compunits.
6284         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6285         (info_sources_command, search_symbols)
6286         (default_collect_symbol_completion_matches_break_on)
6287         (make_source_files_completion_list): Remove declaration.
6288         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6289         (ada_collect_symbol_completion_matches)
6290         (ada_add_global_exceptions): Remove declaration.
6291         * linespec.c (iterate_over_all_matching_symtabs): Use
6292         objfile_compunits.
6293         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6294         (class objfile_compunits): New.
6295         (ALL_COMPUNITS): Use objfile_compunits.
6296         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6297         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6298         objfile_compunits.
6299         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6300
6301 2019-01-09  Tom Tromey  <tom@tromey.com>
6302
6303         * symtab.c (search_symbols)
6304         (default_collect_symbol_completion_matches_break_on): Use
6305         objfile_msymbols.
6306         * ada-lang.c (ada_lookup_simple_minsym)
6307         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6308         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6309         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6310         objfile_msymbols.
6311         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6312         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6313         * objc-lang.c (find_methods): Use objfile_msymbols.
6314         (info_selectors_command, info_classes_command): Likewise.
6315         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6316         * objfiles.h (class objfile_msymbols): New.
6317         (ALL_OBJFILE_MSYMBOLS): Remove.
6318         (ALL_MSYMBOLS): Remove.
6319
6320 2019-01-09  Tom Tromey  <tom@tromey.com>
6321
6322         * common/next-iterator.h (next_adapter): Add Iterator template
6323         parameter.
6324         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6325         (class all_objfiles_safe): New.
6326         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6327         * objfiles.c (put_objfile_before): Update comment.
6328         (add_separate_debug_objfile): Likewise.
6329         (free_all_objfiles): Use all_objfiles_safe.
6330         (objfile_purge_solibs): Likewise.
6331
6332 2019-01-09  Tom Tromey  <tom@tromey.com>
6333
6334         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6335         (expand_symtab_containing_pc, lookup_static_symbol)
6336         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6337         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6338         all_objfiles.
6339         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6340         * breakpoint.c (create_overlay_event_breakpoint)
6341         (create_longjmp_master_breakpoint)
6342         (create_std_terminate_master_breakpoint)
6343         (create_exception_master_breakpoint): Use all_objfiles.
6344         * linux-thread-db.c (try_thread_db_load_from_pdir)
6345         (has_libpthread): Use all_objfiles.
6346         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6347         * linespec.c (iterate_over_all_matching_symtabs)
6348         (search_minsyms_for_name): Use all_objfiles.
6349         * maint.c (maintenance_info_sections): Use all_objfiles.
6350         * main.c (captured_main_1): Use all_objfiles.
6351         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6352         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6353         * guile/scm-pretty-print.c
6354         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6355         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6356         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6357         (maintenance_print_msymbols): Use all_objfiles.
6358         * source.c (select_source_symtab): Use all_objfiles.
6359         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6360         * symfile.c (remove_symbol_file_command)
6361         (expand_symtabs_matching, map_symbol_filenames): Use
6362         all_objfiles.
6363         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6364         all_objfiles.
6365         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6366         * objc-lang.c (find_methods): Use all_objfiles.
6367         * objfiles.c (have_partial_symbols, have_full_symbols)
6368         (have_minimal_symbols, qsort_cmp)
6369         (default_iterate_over_objfiles_in_search_order): Use
6370         all_objfiles.
6371         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6372         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6373         (maintenance_check_psymtabs): Use all_objfiles.
6374         (ALL_PSYMTABS): Remove.
6375         * compile/compile-object-run.c (do_module_cleanup): Use
6376         all_objfiles.
6377         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6378         * cp-support.c (add_symbol_overload_list_qualified): Use
6379         all_objfiles.
6380         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6381         Use all_objfiles.
6382         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6383         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6384         all_objfiles.
6385         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6386         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6387         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6388         Uses all_objfiles.
6389         * solib.c (solib_read_symbols): Use all_objfiles
6390
6391 2019-01-09  Tom Tromey  <tom@tromey.com>
6392
6393         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6394         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6395         all_objfiles.
6396         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6397         * symmisc.c (print_symbol_bcache_statistics)
6398         (print_objfile_statistics, maintenance_print_objfiles)
6399         (maintenance_info_symtabs, maintenance_check_symtabs)
6400         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6401         all_objfiles.
6402         * source.c (forget_cached_source_info): Use all_objfiles.
6403         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6404         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6405         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6406         * objfiles.c (update_section_map): Use all_objfiles.
6407         (shared_objfile_contains_address_p): Likewise.
6408         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6409         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6410
6411 2019-01-09  Tom Tromey  <tom@tromey.com>
6412
6413         * common/next-iterator.h: New file.
6414         * objfiles.h (class all_objfiles): New.
6415         (struct objfile_iterator): New.
6416
6417 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6418
6419         * NEWS: Move the description of the changed "frame", "select-frame",
6420          and "info frame" commands to the Changed commands section.
6421
6422 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6423
6424         * gdbtypes.c (check_stub_method_group): Remove handling of old
6425         mangling schemes.
6426         * linespec.c (find_methods): Likewise.
6427         * stabsread.c (read_member_functions): Likewise.
6428         * valops.c (search_struct_method): Likewise.
6429         (value_struct_elt_for_reference): Likewise.
6430         * NEWS: Mention this change.
6431
6432 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6433
6434         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6435         print_source_lines.
6436         * source.c (print_source_lines_base): Update line number check.
6437         (print_source_lines): New function.
6438         (source_lines_range::source_lines_range): New function.
6439         * source.h (class source_lines_range): New class.
6440         (print_source_lines): New declaration.
6441
6442 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6443
6444         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6445
6446 2019-01-08  Tom Tromey  <tom@tromey.com>
6447             Simon Marchi  <simon.marchi@ericsson.com>
6448
6449         PR gdb/24060
6450         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6451         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6452         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6453         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6454         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6455         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6456
6457 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6458
6459         * source.c (select_source_symtab): Move header comment to
6460         declaration in source.h.
6461         (forget_cached_source_info_for_objfile): Likewise.
6462         (forget_cached_source_info): Likewise.
6463         (identify_source_line): Likewise.
6464         * source.h (identify_source_line): Move declaration from symtab.h
6465         and add comment from source.c
6466         (print_source_lines): Likewise.
6467         (forget_cached_source_info_for_objfile): Likewise.
6468         (forget_cached_source_info): Likewise.
6469         (select_source_symtab): Likewise.
6470         (enum print_source_lines_flag): Move definition from symtab.h.
6471         * symtab.h (identify_source_line): Move declaration to source.h.
6472         (print_source_lines): Likewise.
6473         (forget_cached_source_info_for_objfile): Likewise.
6474         (forget_cached_source_info): Likewise.
6475         (select_source_symtab): Likewise.
6476         (enum print_source_lines_flag): Move definition to source.h.
6477         * tui/tui-hooks.c: Add 'source.h' include.
6478
6479 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6480
6481         * source.c (print_source_lines_base): Handle requests to print
6482         reverse line number sequences, and guard against empty lines
6483         string.
6484
6485 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6486
6487         * source.c (print_source_lines_base): Fix skip of '\r' if next
6488         character is '\n'.
6489
6490 2019-01-06  Tom Tromey  <tom@tromey.com>
6491
6492         * c-exp.y (struct c_parse_state) <macro_original_text,
6493         expansion_obstack>: New member.
6494         (macro_original_text, expansion_obstack): Remove globals.
6495         (scan_macro_expansion, scanning_macro_expansion)
6496         (finished_macro_expansion): Update.
6497         (scan_macro_cleanup): Remove.
6498         (yylex, c_parse): Update.
6499
6500 2019-01-06  Tom Tromey  <tom@tromey.com>
6501
6502         * c-exp.y (struct c_parse_state) <strings>: New member.
6503         (operator_stoken): Update.
6504
6505 2019-01-06  Tom Tromey  <tom@tromey.com>
6506
6507         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6508         (union type_stack_elt) <typelist_val>: Now a pointer to
6509         std::vector.
6510         (type_stack_cleanup): Don't declare.
6511         (push_typelist): Update.
6512         * parse.c (pop_typelist): Return a std::vector.
6513         (push_typelist): Take a std::vector.
6514         (follow_types): Update.  Do not free args.
6515         (type_stack_cleanup): Remove.
6516         * c-exp.y (struct c_parse_state): New.
6517         (cpstate): New global.
6518         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6519         (nonempty_typelist): Update.
6520         (func_mod): Create a new vector.
6521         (c_parse): Create a c_parse_state.
6522         (check_parameter_typelist): Do not delete params.
6523         (function_method): Update.  Do not delete type_list.
6524
6525 2019-01-06  Tom Tromey  <tom@tromey.com>
6526
6527         PR gdb/28155:
6528         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6529         check_typedef.
6530         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6531         (print_return_value): Likewise.
6532
6533 2019-01-05  Tom Tromey  <tom@tromey.com>
6534
6535         * contrib/cleanup_check.py: Remove.
6536         * contrib/gcc-with-excheck: Remove.
6537         * contrib/exsummary.py: Remove.
6538         * contrib/excheck.py: Remove.
6539
6540 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6541
6542         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6543         NULL. Initialize tpprev to NULL instead of assigning it
6544         to NULL on the next statement.
6545         * windows-nat.c (windows_delete_thread): Remove check for
6546         main_thread_id before printing thread exit notifications.
6547         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6548         Remove thread ID check against main_thread_id.
6549         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6550         windows_delete_thread.
6551         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6552
6553 2019-01-04  Tom Tromey  <tom@tromey.com>
6554
6555         * compile/compile.c (_initialize_compile): Use upper case for
6556         metasyntactic variables.
6557         * symmisc.c (_initialize_symmisc): Use upper case for
6558         metasyntactic variables.
6559         * psymtab.c (_initialize_psymtab): Use upper case for
6560         metasyntactic variables.
6561         * demangle.c (demangle_command): Use upper case for metasyntactic
6562         variables.
6563         (_initialize_demangler): Likewise.
6564         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6565         variables.
6566
6567 2019-01-03  Tom Tromey  <tom@tromey.com>
6568
6569         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6570
6571 2019-01-03  Tom Tromey  <tom@tromey.com>
6572
6573         * python/py-symtab.c (salpy_str): Update.
6574         (struct salpy_sal_object) <symtab>: Now a PyObject.
6575         (salpy_dealloc): Update.
6576         (del_objfile_sal): Use gdbpy_ref.
6577
6578 2019-01-03  Tom Tromey  <tom@tromey.com>
6579
6580         * python/py-type.c (convert_field): Use new_reference.  Return
6581         gdbpy_ref.
6582         (make_fielditem): Return gdbpy_ref.
6583         (typy_fields): Update.
6584         (typy_getitem): Update.
6585         (field_name): Return gdbpy_ref.  Use new_reference.
6586         (typy_iterator_iternext): Update.
6587
6588 2019-01-03  Tom Tromey  <tom@tromey.com>
6589
6590         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6591
6592 2019-01-03  Tom Tromey  <tom@tromey.com>
6593
6594         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6595         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6596         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6597         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6598         (pspy_set_type_printers): Likewise.
6599         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6600         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6601         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6602         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6603         (objfpy_set_type_printers): Likewise.
6604
6605 2019-01-03  Tom Tromey  <tom@tromey.com>
6606
6607         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6608         (gdbpy_print_stack): Use gdbpy_err_fetch.
6609         * python/python-internal.h (class gdbpy_err_fetch): New class.
6610         (class gdbpy_enter) <m_error_type, m_error_value,
6611         m_error_traceback>: Remove.
6612         <m_error>: New member.
6613         (gdbpy_exception_to_string): Don't declare.
6614         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6615         * python/py-value.c (convert_value_from_python): Use
6616         gdbpy_err_fetch.
6617         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6618         gdbpy_exception_to_string.
6619         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6620         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6621         gdbpy_err_fetch.
6622
6623 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6624
6625         * linux-nat.c (delete_lwp_cleanup): Delete.
6626         (struct lwp_deleter): New struct.
6627         (lwp_info_up): New typedef.
6628         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6629         lwp_info_up.
6630
6631 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6632
6633         * linux-fork.c (class scoped_switch_fork_info): New class.
6634         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6635
6636 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6637
6638         * valops.c (find_overload_match): Remove use of null_cleanup, and
6639         calls to do_cleanups.
6640
6641 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6642
6643         * compile/compile-cplus-types.c
6644         (compile_cplus_instance::decl_name): Handle changes to
6645         cp_func_name.
6646         * cp-support.c (cp_func_name): Update header comment, update
6647         return type.
6648         * cp-support.h (cp_func_name): Update return type in declaration.
6649         * valops.c (find_overload_match): Move temp_func local to top
6650         level of function and change its type.  Use temp_func to hold and
6651         delete temporary string obtained from cp_func_name.
6652
6653 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6654
6655         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6656         gdb::char_vector, remove cleanup, and update uses of `msg`.
6657
6658 2019-01-03  Jim Wilson  <jimw@sifive.com>
6659
6660         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6661
6662 2019-01-02  Tom Tromey  <tom@tromey.com>
6663
6664         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6665         (tdesc_parse_xml): Remove cleanups.
6666         * target-descriptions.h (make_cleanup_free_target_description):
6667         Don't declare.
6668         (target_desc_deleter): New struct.
6669         (target_desc_up): New typedef.
6670         * target-descriptions.c (target_desc_deleter::operator()): Rename
6671         from free_target_description.
6672         (make_cleanup_free_target_description): Remove.
6673
6674 2019-01-02  Tom Tromey  <tom@tromey.com>
6675
6676         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6677         constructor, destructor.
6678         (linespec_parser): Remove typedef.
6679         (~linespec_parser): Rename from linespec_parser_delete.
6680         (linespec_lex_to_end, linespec_complete_label)
6681         (linespec_complete): Update.
6682         (decode_line_full): Remove cleanups.
6683         (decode_line_1): Update.
6684
6685 2019-01-02  Tom Tromey  <tom@tromey.com>
6686
6687         * python/python-internal.h (inferior_to_inferior_object): Change
6688         return type.
6689         * python/py-exitedevent.c (create_exited_event_object): Update.
6690         * python/py-inferior.c (inferior_to_inferior_object): Return
6691         gdbpy_ref.
6692         (python_new_inferior, python_inferior_deleted)
6693         (thread_to_thread_object, delete_thread_object)
6694         (build_inferior_list, gdbpy_selected_inferior): Update.
6695         * python/py-infthread.c (create_thread_object): Update.  Also fail
6696         if inferior_to_inferior_object fails.
6697
6698 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6699
6700         * inferior.h (class inferior) <displaced_step_state>: New field.
6701         * infrun.h (struct displaced_step_state): Move here from
6702         infrun.c.  Initialize fields, add constructor.
6703         <inf>: Remove field.
6704         <reset>: New method.
6705         * infrun.c (struct displaced_step_inferior_state): Move to
6706         infrun.h.
6707         (displaced_step_inferior_states): Remove.
6708         (get_displaced_stepping_state): Adust.
6709         (displaced_step_in_progress_any_inferior): Adjust.
6710         (displaced_step_in_progress_thread): Adjust.
6711         (displaced_step_in_progress): Adjust.
6712         (add_displaced_stepping_state): Remove.
6713         (get_displaced_step_closure_by_addr): Adjust.
6714         (remove_displaced_stepping_state): Remove.
6715         (infrun_inferior_exit): Call displaced_step_state.reset.
6716         (use_displaced_stepping): Don't check for NULL.
6717         (displaced_step_prepare_throw): Call
6718         get_displaced_stepping_state.
6719         (displaced_step_fixup): Don't check for NULL.
6720         (prepare_for_detach): Don't check for NULL.
6721
6722 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6723
6724         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6725          in case of call that did not complete.
6726
6727 2019-01-02  Andrey Utkin  <autkin@undo.io>
6728
6729         * symfile.c (find_separate_debug_file): Fix search of debug files for
6730         remote debuggee.
6731
6732 2019-01-02  Tom Tromey  <tom@tromey.com>
6733
6734         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6735         indentation.
6736         * python/py-frame.c (frapy_older): Remove cast.
6737         (frapy_newer): Likewise.
6738         * python/py-breakpoint.c (local_setattro): Remove cast.
6739         * python/py-arch.c (archpy_name): Remove local variable.
6740         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6741
6742 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6743
6744         * unittests/basic_string_view/element_access/char/empty.cc:
6745         Fix year range in copyright header.
6746
6747 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6748
6749         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6750         Delete.
6751         <operator==>: Update with for removed field.
6752         <hash>: Likewise.
6753         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6754         <isa_features>: ...this.
6755         <abi_features>: New field.
6756         (riscv_isa_flen): Update comment.
6757         (riscv_abi_xlen): New declaration.
6758         (riscv_abi_flen): New declaration.
6759         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6760         isa_features.
6761         (riscv_abi_xlen): New function.
6762         (riscv_isa_flen): Update to get answer from isa_features.
6763         (riscv_abi_flen): New function.
6764         (riscv_has_fp_abi): Update to get answer from abi_features.
6765         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6766         xlen and flen.
6767         (riscv_call_info) <xlen, flen>: Update comment.
6768         (riscv_call_arg_struct): Remove invalid assertions
6769         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6770         is removed.
6771         (riscv_gdbarch_init): Gather isa features and abi features
6772         separately, ensure both match on the gdbarch when reusing an old
6773         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6774         a target with 64-bit float hardware.
6775
6776 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6777
6778         * source.c (search_command_helper): Stop reverse search
6779         when line 1 has been searched.
6780
6781 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6782
6783         * record-full.c (record_full_base_target::close): Rewrite
6784         record_full_core_buf_list free logic.
6785
6786 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6787
6788         * break-catch-syscall.c (print_one_catch_syscall): xfree
6789         the last text.
6790
6791 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6792
6793         * top.c (print_gdb_version): Update Copyright year in version
6794         message.
6795
6796 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6797
6798         Update copyright year range in all GDB files.
6799
6800 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6801
6802         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6803
6804 For older changes see ChangeLog-2018.
6805 \f
6806 Local Variables:
6807 mode: change-log
6808 left-margin: 8
6809 fill-column: 74
6810 version-control: never
6811 coding: utf-8
6812 End:
6813