gdb/ChangeLog

   1 2019-08-30  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
   4         rerender.
   5         (tui_update_locator_fullname, tui_show_frame_info): Don't call
   6         tui_show_locator_content.
   7
   8 2019-08-30  Tom Tromey  <tom@tromey.com>
   9
  10         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
  11         (tui_locator_window::rerender): Rewrite using body of previous
  12         tui_show_locator_content.
  13
  14 2019-08-30  Tom Tromey  <tom@tromey.com>
  15
  16         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
  17         set_locator_fullname>: New methods.
  18         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
  19         Rename from tui_set_locator_fullname.
  20         (tui_locator_window::set_locator_info): Rename from
  21         tui_set_locator_info.  Return bool.
  22         (tui_update_locator_fullname, tui_show_frame_info): Update.
  23
  24 2019-08-30  Tom Tromey  <tom@tromey.com>
  25
  26         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
  27
  28 2019-08-30  Tom Tromey  <tom@tromey.com>
  29
  30         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
  31         call touchwin.
  32
  33 2019-08-30  Tom Tromey  <tom@tromey.com>
  34
  35         * tui/tui-wingeneral.c (box_win): Assume win_info and
  36         win_info->handle cannot be NULL.
  37
  38 2019-08-30  Tom Tromey  <tom@tromey.com>
  39
  40         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
  41         refresh_window>: Declare.
  42         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
  43         resize.
  44         (tui_data_item_window::rerender): Rename from
  45         tui_display_register.
  46         (tui_data_item_window::refresh_window): New method.
  47         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
  48         no-op.
  49
  50 2019-08-30  Tom Tromey  <tom@tromey.com>
  51
  52         * tui/tui-regs.h (struct tui_data_window) <regs_content,
  53         regs_column_count, current_group>: Move later.  Now private.
  54         <get_current_group>: New method.
  55         * tui/tui-regs.c (tui_reg_command): Update.
  56         * tui/tui-layout.c (tui_set_layout): Update.
  57
  58 2019-08-30  Tom Tromey  <tom@tromey.com>
  59
  60         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
  61         (tui_data_window::rerender): Don't call
  62         check_and_display_highlight_if_needed.
  63         (tui_data_window::refresh_all): Remove call to
  64         erase_data_content.
  65
  66 2019-08-30  Tom Tromey  <tom@tromey.com>
  67
  68         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
  69         (tui_data_window::display_registers_from)
  70         (tui_data_window::display_reg_element_at_line)
  71         (tui_data_window::display_registers_from_line): Remove checks of
  72         "empty".
  73
  74 2019-08-30  Tom Tromey  <tom@tromey.com>
  75
  76         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
  77         Don't declare.
  78         * tui/tui-regs.c (tui_data_window::show_registers): Call
  79         rerender.
  80         (tui_data_window::rerender): Rename from display_all_data.
  81         (tui_data_window::rerender): Remove old implementation.
  82
  83 2019-08-30  Tom Tromey  <tom@tromey.com>
  84
  85         * tui/tui-regs.c (tui_data_window::display_all_data): Change
  86         text.
  87         * tui/tui-data.h (NO_DATA_STRING): Remove define.
  88
  89 2019-08-29  Bernhard Wodok  <barto@gmx.net>
  90             Sergio Durigan Junior  <sergiodj@redhat.com>
  91
  92         PR win32/24284
  93         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
  94
  95 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
  96
  97         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
  98         when searching for types.
  99
 100 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 101
 102         * f-lang.c (f_language_defn): Use f_print_typedef.
 103         * f-lang.h (f_print_typedef): Declare.
 104         * f-typeprint.c (f_print_typedef): Define.
 105
 106 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
 107
 108         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
 109
 110 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 111
 112         * cli/cli-utils.c (info_print_options_defs): Delete.
 113         (make_info_print_options_def_group): Delete.
 114         (extract_info_print_options): Delete.
 115         (info_print_command_completer): Delete.
 116         (info_print_args_help): Add extra parameter, and optionally
 117         include text about -n flag.
 118         * cli/cli-utils.h (struct info_print_options): Delete.
 119         (extract_info_print_options): Delete declaration.
 120         (info_print_command_completer): Delete declaration.
 121         (info_print_args_help): Add extra parameter, extend header
 122         comment.
 123         * python/python.c (gdbpy_rbreak): Pass additional parameter to
 124         search_symbols.
 125         * stack.c (struct info_print_options): New type.
 126         (info_print_options_defs): New file scoped variable.
 127         (make_info_print_options_def_group): New static function.
 128         (info_print_command_completer): New static function.
 129         (info_locals_command): Update to use new local functions.
 130         (info_args_command): Likewise.
 131         (_initialize_stack): Add extra parameter to calls to
 132         info_print_args_help.
 133         * symtab.c (search_symbols): Add extra parameter, use this to
 134         possibly excluse non-debug symbols.
 135         (symtab_symbol_info): Add extra parameter, which is passed on to
 136         search_symbols.
 137         (struct info_print_options): New type.
 138         (info_print_options_defs): New file scoped variable.
 139         (make_info_print_options_def_group): New static function.
 140         (info_print_command_completer): New static function.
 141         (info_variables_command): Update to use local functions, and pass
 142         extra parameter through to symtab_symbol_info.
 143         (info_functions_command): Likewise.
 144         (info_types_command): Pass additional argument through to
 145         symtab_symbol_info.
 146         (rbreak_command): Pass extra argument to search_symbols.
 147         (_initialize_symtab): Add extra arguments for calls to
 148         info_print_args_help, and update help text for 'info variables',
 149         'whereis', and 'info functions' commands.
 150         * symtab.h (search_symbols): Add extra argument to declaration.
 151         * NEWS: Mention new flags.
 152
 153 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
 154
 155         * symtab.c (lookup_static_symbol): Call the new function (and move
 156         it down to be next to lookup_global_symbol).
 157         (struct global_sym_lookup_data): Add block_enum member and rename to...
 158         (struct global_or_static_sym_lookup_data): ...this.
 159         (lookup_symbol_global_iterator_cb): Pass block_index instead of
 160         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
 161         (lookup_symbol_global_or_static_iterator_cb): ...this.
 162         (lookup_global_or_static_symbol): New function.
 163         (lookup_global_symbol): Call new function.
 164
 165 2019-08-26  Tom de Vries  <tdevries@suse.de>
 166
 167         PR c++/24852
 168         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
 169         when pc_probe.prob == NULL.
 170
 171 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 172
 173         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
 174         variable symbol_linkage to symbol_linkage_.
 175
 176 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 177
 178         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
 179         represent whether the symbol is static, dynamic, or we don't
 180         know.
 181
 182 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
 183
 184         * gdb/rx-tdep.c (rx_register_names): New.
 185         (rx_register_name): Delete.
 186         (rx_psw_type): Delete.
 187         (rx_fpsw_type): Delete.
 188         (rx_register_type): Delete.
 189         (rx_gdbarch_init): Convert target-descriptions.
 190         (_initialize_rx_tdep): Add initialize_tdesc_rx.
 191         * gdb/features/Makefile: Add rx.xml.
 192         * gdb/features/rx.xml: New.
 193         * gdb/features/rx.c: Generated.
 194         * gdb/NEWS: Mention target description support.
 195
 196 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 197
 198         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
 199         *slot_ptr.
 200
 201 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 202
 203         * configure.ac: Don't check for 'dlfcn.h' (moved to
 204         gdbsupport/common.m4).
 205         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
 206         'gdbsupport/'.
 207         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
 208         * compile/compile-c-support.c: Include
 209         'gdbsupport/gdb-dlfcn.h'.
 210         * gdbsupport/common.m4: Check for 'dlfcn.h'.
 211         * gdb-dlfcn.c: Move to...
 212         * gdbsupport/gdb-dlfcn.c: ... here.
 213         * gdb-dlfcn.h: Move to...
 214         * gdbsupport/gdb-dlfcn.h: ... here.
 215
 216 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
 217
 218         * nios2-tdep.c (struct reg_value): Improve comments.  Make
 219         the offset field signed.
 220
 221 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 222
 223         * python/lib/gdb/__init__.py (_execute_file): New function.
 224         * python/python.c (python_run_simple_file): Call gdb._execute_file
 225         on Windows.
 226
 227 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 228
 229         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
 230         all uses as this was never set to anything but a zero value.
 231
 232 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
 233
 234         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
 235
 236 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
 237
 238         * tui/tui-data.h (tui_gen_win_info): Add an =default
 239         move constructor, required by some GCC versions.
 240
 241 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
 242
 243         * go32-nat.c (go32_sysinfo): Add hygon_p.
 244
 245 2019-08-20  Tom Tromey  <tom@tromey.com>
 246
 247         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
 248         line_from_reg_element_no, first_reg_element_no_inline,
 249         display_all_data, delete_data_content_windows,
 250         erase_data_content>: Now private.
 251
 252 2019-08-20  Tom Tromey  <tom@tromey.com>
 253
 254         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
 255         (tui_unhighlight_win, tui_highlight_win)
 256         (tui_win_info::make_window): Update.
 257         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
 258
 259 2019-08-20  Tom Tromey  <tom@tromey.com>
 260
 261         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 262         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 263         (MAX_PID_WIDTH): Move to tui-stack.c.
 264         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 265         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 266         (MAX_PID_WIDTH): Move from tui-data.h.
 267
 268 2019-08-20  Tom Tromey  <tom@tromey.com>
 269
 270         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
 271         * tui/tui-wingeneral.c (box_win): Change type of win_info.
 272         (box_win): Update.
 273         (tui_gen_win_info::make_window): Rename from tui_make_window.
 274         (tui_win_info::make_window): New method.
 275         (tui_gen_win_info::make_visible): Update.
 276         * tui/tui-source.c (tui_source_window::set_contents): Update.
 277         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
 278         (tui_data_window::display_registers_from): Update.
 279         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 280         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
 281         Declare.
 282         <can_box>: Remove.
 283         <title>: Remove.
 284         (struct tui_win_info) <make_window>: Declare.
 285         <can_box>: Now virtual.
 286         <title>: New member.
 287         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
 288         * tui/tui-command.c (tui_cmd_window::resize): Update.
 289
 290 2019-08-20  Tom Tromey  <tom@tromey.com>
 291
 292         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
 293         * tui/tui-regs.c (tui_data_window::show_registers): Update.
 294         (tui_data_window::check_register_values): Update.
 295
 296 2019-08-20  Tom Tromey  <tom@tromey.com>
 297
 298         * tui/tui-regs.h (struct tui_data_window): Use
 299         DISABLE_COPY_AND_ASSIGN.
 300         <regs_content>: Change type, removing unique_ptr.
 301         <tui_data_window>: Add move constructor.
 302         * tui/tui-regs.c (tui_data_window::show_registers)
 303         (tui_data_window::show_register_group)
 304         (tui_data_window::display_registers_from)
 305         (tui_data_window::display_registers_from)
 306         (tui_data_window::first_data_item_displayed)
 307         (tui_data_window::delete_data_content_windows)
 308         (tui_data_window::rerender, tui_data_window::refresh_window)
 309         (tui_data_window::check_register_values): Update.
 310
 311 2019-08-20  Tom Tromey  <tom@tromey.com>
 312
 313         * tui/tui-regs.h (struct tui_data_window) <show_registers,
 314         show_register_group>: Declare.
 315         (tui_show_register_group): Don't declare.
 316         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
 317         tui_show_registers.
 318         (tui_data_window::show_register_group): Rename from
 319         tui_show_register_group.
 320         (tui_data_window::check_register_values, tui_reg_command):
 321         Update.
 322         * tui/tui-layout.c (tui_set_layout): Update.
 323
 324 2019-08-20  Tom Tromey  <tom@tromey.com>
 325
 326         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
 327         Declare.
 328         (tui_check_register_values): Don't declare.
 329         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
 330         from tui_check_register_values.
 331         * tui/tui-hooks.c (tui_register_changed): Update.
 332
 333 2019-08-20  Tom Tromey  <tom@tromey.com>
 334
 335         * tui/tui-regs.c (tui_reg_layout): Move later.
 336         (tui_show_registers): Don't enable TUI mode or change layout.
 337
 338 2019-08-20  Tom Tromey  <tom@tromey.com>
 339
 340         * tui/tui-regs.h (struct tui_data_item_window)
 341         <~tui_data_item_window>: Remove.
 342         <content>: Now a unique_xmalloc_ptr.
 343         * tui/tui-regs.c (tui_register_format): Return a
 344         unique_xmalloc_ptr.
 345         (tui_get_register): Update.
 346         (~tui_data_item_window): Remove.
 347         (tui_data_window::display_registers_from, tui_display_register):
 348         Update.
 349         * tui/tui-io.h (tui_expand_tabs): Update.
 350         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
 351         Remove "col" parameter.
 352
 353 2019-08-20  Tom Tromey  <tom@tromey.com>
 354
 355         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
 356         field.
 357         * tui/tui-regs.c (~tui_data_item_window): Update.
 358
 359 2019-08-20  Tom Tromey  <tom@tromey.com>
 360
 361         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
 362         earlier.
 363
 364 2019-08-20  Tom Tromey  <tom@tromey.com>
 365
 366         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
 367
 368 2019-08-20  Tom Tromey  <tom@tromey.com>
 369
 370         * tui/tui-source.h (struct tui_source_window): Update.
 371         * tui/tui-regs.c (tui_show_registers): Update.
 372         * tui/tui-disasm.h (struct tui_disasm_window): Update.
 373         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
 374         (NO_REGS_STRING): Remove defines.
 375
 376 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
 377
 378         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
 379         unnecessary thread walk if remote doesn't support the packet.
 380
 381 2019-08-19  Tom Tromey  <tromey@adacore.com>
 382
 383         * python/py-value.c (value_has_field): Fix indentation.
 384
 385 2019-08-19  Tom Tromey  <tromey@adacore.com>
 386
 387         * printcmd.c (do_one_display, info_display_command): Update.
 388         * block.h (contained_in): Return bool.  Add allow_nested
 389         parameter.
 390         * block.c (contained_in): Return bool.  Add allow_nested
 391         parameter.
 392
 393 2019-08-19  Tom Tromey  <tom@tromey.com>
 394
 395         * configure: Rebuild.
 396         * configure.ac: Disallow the combination of -static-libstdc++ and
 397         source highlight.
 398         * source-cache.c (get_language_name): Handle rust.
 399         (source_cache::get_source_lines): Ignore highlighting exceptions.
 400
 401 2019-08-16  Tom Tromey  <tom@tromey.com>
 402
 403         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
 404         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
 405         (struct tui_source_window_base) <make_visible, refresh_window,
 406         resize>: Remove methods.
 407         <execution_info>: Remove field.
 408         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
 409         (tui_show_source_line, tui_source_window_base)
 410         (~tui_source_window_base): Update.
 411         (tui_source_window_base::resize)
 412         (tui_source_window_base::make_visible)
 413         (tui_source_window_base::refresh_window): Remove.
 414         (tui_source_window_base::update_exec_info): Update.
 415         * tui/tui-source.c (tui_source_window::set_contents): Update.
 416         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 417
 418 2019-08-16  Tom Tromey  <tom@tromey.com>
 419
 420         * tui/tui-hooks.c (tui_remove_hooks): Don't set
 421         deprecated_query_hook.
 422
 423 2019-08-16  Tom Tromey  <tom@tromey.com>
 424
 425         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 426         (tui_update_source_windows_with_line): Update.
 427         * tui/tui-source.h (struct tui_source_window)
 428         <show_symtab_source>: Declare.
 429         (tui_show_symtab_source): Don't declare.
 430         * tui/tui-source.c (tui_show_symtab_source): Rename from
 431         tui_show_symtab_source.
 432
 433 2019-08-16  Tom Tromey  <tom@tromey.com>
 434
 435         * tui/tui-winsource.h (struct tui_source_window_base)
 436         <set_contents>: Declare.
 437         * tui/tui-winsource.c
 438         (tui_source_window_base::update_source_window_as_is): Update.
 439         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 440         Declare.
 441         (tui_set_source_content): Don't declare.
 442         * tui/tui-source.c (tui_source_window::set_contents): Rename from
 443         tui_set_source_content.
 444         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 445         Declare.
 446         (tui_set_disassem_content): Don't declare.
 447         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
 448         tui_set_disassem_content.
 449
 450 2019-08-16  Tom Tromey  <tom@tromey.com>
 451
 452         * tui/tui-winsource.h (struct tui_source_window_base)
 453         <update_breakpoint_info>: Declare.
 454         (tui_update_breakpoint_info): Don't declare.
 455         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
 456         (tui_update_all_breakpoint_info): Update.
 457         (tui_source_window_base::update_breakpoint_info): Rename from
 458         tui_update_breakpoint_info.
 459         (tui_source_window_base::update_exec_info): Update.
 460
 461 2019-08-16  Tom Tromey  <tom@tromey.com>
 462
 463         * tui/tui-winsource.h (struct tui_source_window_base)
 464         <update_source_window>: Declare.
 465         (tui_update_source_window): Don't declare.
 466         * tui/tui-winsource.c
 467         (tui_source_window_base::update_source_window): Rename from
 468         tui_update_source_window.
 469         (tui_source_window_base::rerender): Update.
 470         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 471         * tui/tui-disasm.c (tui_show_disassem)
 472         (tui_show_disassem_and_update_source)
 473         (tui_disasm_window::maybe_update): Update.
 474
 475 2019-08-16  Tom Tromey  <tom@tromey.com>
 476
 477         * tui/tui-winsource.h (struct tui_source_window_base)
 478         <update_source_window_as_is>: Declare.
 479         (tui_update_source_window_as_is): Don't declare.
 480         * tui/tui-winsource.c (tui_update_source_window): Update
 481         (tui_source_window_base::update_source_window_as_is): Rename from
 482         tui_update_source_window_as_is.
 483         (tui_source_window_base::refill): Update.
 484         * tui/tui-source.c (tui_show_symtab_source): Update.
 485         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 486         Update.
 487
 488 2019-08-16  Tom Tromey  <tom@tromey.com>
 489
 490         * tui/tui-winsource.h (tui_update_source_window)
 491         (tui_update_source_window_as_is): Remove "noerror" parameter.
 492         * tui/tui-winsource.c (tui_update_source_window)
 493         (tui_update_source_window_as_is): Remove "noerror" parameter.
 494         (tui_update_source_windows_with_addr)
 495         (tui_update_source_windows_with_line)
 496         (tui_source_window_base::rerender)
 497         (tui_source_window_base::refill): Update.
 498         * tui/tui-source.h (tui_set_source_content)
 499         (tui_show_symtab_source): Remove "noerror" parameter.
 500         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 501         parameter.
 502         (tui_show_symtab_source): Likewise.
 503         (tui_source_window::maybe_update): Update.
 504         * tui/tui-disasm.c (tui_show_disassem)
 505         (tui_show_disassem_and_update_source)
 506         (tui_disasm_window::do_scroll_vertical)
 507         (tui_disasm_window::maybe_update): Update.
 508
 509 2019-08-16  Tom Tromey  <tom@tromey.com>
 510
 511         * tui/tui.c (tui_is_window_visible): Update.
 512         * tui/tui-wingeneral.c (tui_make_window)
 513         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 514         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 515         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 516         (tui_set_win_height_command, parse_scrolling_args): Update.
 517         * tui/tui-source.c (tui_source_window::style_changed): Update.
 518         * tui/tui-regs.c (tui_show_registers)
 519         (tui_data_window::first_data_item_displayed)
 520         (tui_data_window::delete_data_content_windows)
 521         (tui_check_register_values, tui_reg_command): Update.
 522         * tui/tui-disasm.c (tui_show_disassem): Update.
 523         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 524         method.
 525         <is_visible>: Remove field.
 526         * tui/tui-data.c (tui_next_win, tui_prev_win)
 527         (tui_delete_invisible_windows): Update.
 528
 529 2019-08-16  Tom Tromey  <tom@tromey.com>
 530
 531         * tui/tui-winsource.h (struct tui_source_window_base)
 532         <m_has_locator>: Remove.
 533         * tui/tui-layout.c (show_source_disasm_command, show_data)
 534         (show_source_or_disasm_and_command): Update.
 535
 536 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 537
 538         * NEWS (Other MI changes): New subsection.
 539         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 540         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 541         * arch-utils.c (default_get_pc_address_flags): New function.
 542         * arch-utils.h (default_get_pc_address_flags): New declaration.
 543         * gdbarch.sh: Add get_pc_address_flags.
 544         * gdbarch.c: Regenerate.
 545         * gdbarch.h: Likewise.
 546         * stack.c (print_pc): New function.
 547         (print_frame_info) (print_frame): Call print_pc.
 548
 549 2019-08-16  Tom de Vries  <tdevries@suse.de>
 550
 551         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 552         print_objfile_section_info.
 553
 554 2019-08-15  Tom Tromey  <tom@tromey.com>
 555
 556         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 557         calling update_cmdwin_start_line.
 558         * tui/tui-winsource.h (struct tui_source_window_base)
 559         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 560         <rerender>: Declare.
 561         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 562         Call rerender.
 563         (tui_source_window_base::set_new_height): Remove.
 564         (tui_source_window_base::rerender): Rename from
 565         do_make_visible_with_new_height.
 566         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 567         resize method.
 568         (tui_win_info::make_invisible_and_set_new_height)
 569         (tui_win_info::make_visible_with_new_height): Remove.
 570         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 571         Declare.
 572         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 573         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 574         do_make_visible_with_new_height>: Don't declare.
 575         <rerender>: Declare.
 576         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 577         set_new_height.
 578         (tui_data_window::do_make_visible_with_new_height): Remove.
 579         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 580         call tui_show_locator_content.
 581         (tui_gen_win_info::resize): Call rerender.
 582         (show_source_or_disasm_and_command): Don't call
 583         tui_show_locator_content.
 584         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 585         method.
 586         (struct tui_win_info) <rerender>: Declare.
 587         <set_new_height, make_invisible_and_set_new_height,
 588         make_visible_with_new_height>: Don't declare.
 589         * tui/tui-data.c (tui_win_list::rerender): New method.
 590         * tui/tui-command.h (struct tui_cmd_window)
 591         <do_make_visible_with_new_height>: Don't declare.
 592         * tui/tui-command.c
 593         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 594
 595 2019-08-15  Tom Tromey  <tromey@adacore.com>
 596
 597         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 598         * ada-lang.c (ada_enum_name): Likewise.
 599
 600 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 601
 602         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 603         leading underscore.
 604         (GdbOutputErrorFile): Likewise.
 605         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 606         accordingly.
 607         (execute_unwinders): Rename to have a leading underscore.
 608         (auto_load_packages): Likewise.
 609         (global scope): Adjust call to auto_load_packages accordingly.
 610         (GdbSetPythonDirectory): Likewise.
 611         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 612         instead of execute_unwinders.
 613
 614 2019-08-15  Tom Tromey  <tom@tromey.com>
 615
 616         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 617         (show_data): Don't change window visibility.
 618         (tui_gen_win_info::resize): Remove special case for command
 619         window.  Use wresize, when available.
 620         (show_source_or_disasm_and_command): Don't change window
 621         visibility.
 622         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 623         <make_visible>: New method.
 624         * tui/tui-command.c (tui_cmd_window::resize): New method.
 625
 626 2019-08-15  Tom Tromey  <tom@tromey.com>
 627
 628         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 629         (struct tui_source_windows): New.
 630         * tui/tui-winsource.c (tui_display_main): Update.
 631         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 632         (new_height_ok, parse_scrolling_args): Update.
 633         * tui/tui-layout.c (show_layout, show_data): Update.
 634         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 635         (tui_add_to_source_windows): Don't declare.
 636         * tui/tui-data.c (source_windows, tui_source_windows)
 637         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 638
 639 2019-08-15  Tom Tromey  <tom@tromey.com>
 640
 641         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 642         Rename from reset.
 643         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 644         * tui/tui-layout.c (show_source_disasm_command, show_data):
 645         Update.
 646         (tui_gen_win_info::resize): Rename.
 647         (show_source_or_disasm_and_command): Update.
 648         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 649         reset.
 650
 651 2019-08-15  Tom Tromey  <tom@tromey.com>
 652
 653         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 654         * tui/tui-interp.c (tui_interp::init): Don't call
 655         tui_initialize_static_data.
 656         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 657
 658 2019-08-15  Tom Tromey  <tom@tromey.com>
 659
 660         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 661         examine tui_win_list.
 662
 663 2019-08-15  Tom Tromey  <tom@tromey.com>
 664
 665         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 666         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 667         tui_clear_source_content.
 668         (tui_clear_source_content): Remove.
 669         (tui_source_window_base::do_erase_source_content): Hoist call to
 670         content.clear().
 671         * tui/tui-stack.c (tui_show_frame_info): Don't call
 672         tui_clear_source_content.
 673
 674 2019-08-15  Tom Tromey  <tom@tromey.com>
 675
 676         * tui/tui-winsource.h (struct tui_source_window_base)
 677         <do_erase_source_content>: New method.
 678         <erase_source_content>: New method.
 679         (tui_erase_source_content): Don't declare.
 680         * tui/tui-winsource.c (tui_clear_source_content): Update.
 681         (tui_source_window_base::do_erase_source_content): Rename from
 682         tui_erase_source_content.
 683         (tui_source_window_base::show_source_content): Update.
 684         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 685         * tui/tui-source.h (struct tui_source_window)
 686         <erase_source_content>: New method.
 687         * tui/tui-disasm.h (struct tui_disasm_window)
 688         <erase_source_content>: New method.
 689
 690 2019-08-15  Tom Tromey  <tom@tromey.com>
 691
 692         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 693         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 694         constructor.
 695         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 696         * tui/tui-source.c (tui_set_source_content): Update.
 697         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 698
 699 2019-08-15  Tom Tromey  <tom@tromey.com>
 700
 701         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 702         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 703         tui-source.c.
 704         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 705         Declare.
 706         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 707         method.
 708         (tui_source_window::maybe_update): Update.
 709
 710 2019-08-15  Tom Tromey  <tom@tromey.com>
 711
 712         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 713         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 714         tui-disasm.c.
 715         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 716         Declare.
 717         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 718         method.
 719         (tui_disasm_window::maybe_update): Update.
 720
 721 2019-08-15  Tom Tromey  <tom@tromey.com>
 722
 723         * tui/tui-winsource.h (struct tui_source_window_base)
 724         <maybe_update>: Declare.
 725         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 726         method.
 727         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 728         Declare.
 729         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 730         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 731         Declare.
 732         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 733
 734 2019-08-15  Tom Tromey  <tom@tromey.com>
 735
 736         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 737
 738 2019-08-15  Tom Tromey  <tom@tromey.com>
 739
 740         * tui/tui-wingeneral.c: Include tui-stack.h.
 741         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 742         (struct tui_locator_window): Move from tui-data.h.
 743         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 744         (tui_initialize_static_data): Move from tui-data.c.
 745         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 746         (struct tui_locator_window): Move to tui-stack.c.
 747         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 748         (tui_initialize_static_data): Move to tui-stack.c.
 749
 750 2019-08-15  Tom Tromey  <tom@tromey.com>
 751
 752         * tui/tui-layout.c (show_source_disasm_command)
 753         (show_source_or_disasm_and_command): Use make_visible method, not
 754         tui_make_window.
 755         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 756         Remove.
 757
 758 2019-08-15  Tom Tromey  <tom@tromey.com>
 759
 760         * tui/tui-wingeneral.h (tui_make_window): Update.
 761         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 762         parameter.
 763         (tui_gen_win_info::make_visible): Update.
 764         * tui/tui-regs.c (tui_data_window::display_registers_from):
 765         Update.
 766         * tui/tui-layout.c (show_source_disasm_command)
 767         (show_source_or_disasm_and_command): Update.
 768         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 769         (enum tui_box): Remove.
 770         (struct tui_win_info) <can_box>: New method.
 771         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 772         method.
 773
 774 2019-08-15  Tom de Vries  <tdevries@suse.de>
 775
 776         * linux-nat-trad.c: Include gdbarch.h.
 777
 778 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 779
 780         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 781         register sizes.
 782
 783 2019-08-14  Tom Tromey  <tromey@adacore.com>
 784
 785         * darwin-nat.c: Include gdbarch.h.
 786         * darwin-nat-info.c: Include gdbarch.h.
 787
 788 2019-08-13  Tom Tromey  <tom@tromey.com>
 789
 790         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 791         Remove.
 792         * tui/tui-data.c (tui_initialize_static_data): Update.
 793
 794 2019-08-13  Tom Tromey  <tom@tromey.com>
 795
 796         * tui/tui-winsource.h (struct tui_exec_info_window)
 797         <~tui_exec_info_window, maybe_allocate_content, get_content,
 798         m_content>: Remove.
 799         (struct tui_source_window_base) <set_exec_info_content,
 800         show_exec_info_content>: Don't declare.
 801         * tui/tui-winsource.c
 802         (tui_exec_info_window::maybe_allocate_content): Remove.
 803         (tui_source_window_base::update_exec_info): Rename from
 804         set_exec_info_content.
 805         (tui_source_window_base::show_exec_info_content)
 806         (tui_source_window_base::update_exec_info): Remove.
 807
 808 2019-08-13  Tom Tromey  <tom@tromey.com>
 809
 810         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 811         declare.
 812         * tui/tui-winsource.c (tui_update_source_window_as_is)
 813         (tui_update_source_windows_with_addr, tui_erase_source_content):
 814         Update.
 815         (tui_clear_exec_info_content): Remove.
 816
 817 2019-08-13  Tom Tromey  <tom@tromey.com>
 818
 819         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 820         declare.
 821         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 822         call tui_erase_exec_info_content.
 823         (tui_clear_exec_info_content): Rename from
 824         tui_erase_exec_info_content.
 825         (tui_clear_exec_info_content): Delete.
 826
 827 2019-08-13  Tom Tromey  <tom@tromey.com>
 828
 829         * tui/tui-winsource.h (struct tui_source_window_base)
 830         <show_exec_info_content>: Declare.
 831         (tui_show_exec_info_content): Don't declare.
 832         * tui/tui-winsource.c
 833         (tui_source_window_base::show_exec_info_content): Rename from
 834         tui_show_exec_info_content.
 835         (tui_source_window_base::update_exec_info): Update.
 836
 837 2019-08-13  Tom Tromey  <tom@tromey.com>
 838
 839         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 840         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 841         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 842         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 843         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 844         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 845         ... here.
 846
 847 2019-08-13  Tom Tromey  <tom@tromey.com>
 848
 849         * tui/tui-winsource.h (struct tui_source_window_base)
 850         <update_exec_info>: Declare.
 851         (tui_update_exec_info): Don't declare.
 852         * tui/tui-winsource.c (tui_update_source_window_as_is)
 853         (tui_source_window_base::refresh_all)
 854         (tui_update_all_breakpoint_info): Update.
 855         (tui_source_window_base::update_exec_info): Rename from
 856         tui_update_exec_info.
 857         * tui/tui-stack.c (tui_show_frame_info): Update.
 858
 859 2019-08-13  Tom Tromey  <tom@tromey.com>
 860
 861         * tui/tui-winsource.h (struct tui_source_window_base)
 862         <set_exec_info_content>: Declare.
 863         (tui_set_exec_info_content): Don't declare.
 864         * tui/tui-winsource.c
 865         (tui_source_window_base::set_exec_info_content): Rename from
 866         tui_set_exec_info_content.
 867         (tui_update_exec_info): Update.
 868
 869 2019-08-13  Tom Tromey  <tom@tromey.com>
 870
 871         * tui/tui-winsource.h (struct tui_source_window_base)
 872         <show_source_content>: Declare.
 873         (tui_show_source_content): Don't declare.
 874         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 875         (tui_source_window_base::show_source_content): Rename from
 876         tui_show_source_content.
 877         (tui_source_window_base::refresh_all): Update.
 878         * tui/tui-layout.c (show_source_disasm_command)
 879         (show_source_or_disasm_and_command): Update.
 880
 881 2019-08-13  Tom Tromey  <tom@tromey.com>
 882
 883         * tui/tui-winsource.c (tui_erase_source_content)
 884         (tui_show_source_content, tui_source_window_base::refresh_all):
 885         Update.
 886         * tui/tui-wingeneral.h
 887         (tui_check_and_display_highlight_if_needed): Don't declare.
 888         * tui/tui-wingeneral.c
 889         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 890         check_and_display_highlight_if_needed.
 891         * tui/tui-win.c (tui_rehighlight_all)
 892         (tui_win_info::make_visible_with_new_height): Update.
 893         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 894         (tui_data_window::erase_data_content)
 895         (tui_data_window::display_all_data): Update.
 896         * tui/tui-data.h (struct tui_win_info)
 897         <check_and_display_highlight_if_needed>: Declare.
 898
 899 2019-08-13  Tom Tromey  <tom@tromey.com>
 900
 901         * tui/tui-win.c (tui_resize_all): Call
 902         tui_delete_invisible_windows.
 903         * tui/tui-layout.c (show_layout): Call
 904         tui_delete_invisible_windows.
 905         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 906         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 907
 908 2019-08-13  Tom Tromey  <tom@tromey.com>
 909
 910         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 911         tui_add_win_to_layout.
 912
 913 2019-08-13  Tom Tromey  <tom@tromey.com>
 914
 915         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 916         * tui/tui-layout.c (tui_default_win_height): Now static.
 917
 918 2019-08-13  Tom Tromey  <tom@tromey.com>
 919
 920         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 921         single switch.
 922         (show_source_disasm_command, show_source_or_disasm_and_command):
 923         Don't check current layout.
 924
 925 2019-08-13  Tom Tromey  <tom@tromey.com>
 926
 927         * tui/tui-wingeneral.c (make_all_visible): Remove.
 928         (tui_make_all_invisible): Simplify.
 929         * tui/tui-layout.c (tui_make_all_invisible): Move from
 930         tui-wingeneral.c; simplify.
 931         (show_layout): Hoist call to tui_make_all_invisible.
 932         (show_data): Don't call tui_make_all_invisible.
 933
 934 2019-08-13  Tom Tromey  <tom@tromey.com>
 935
 936         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 937         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 938
 939 2019-08-13  Tom Tromey  <tom@tromey.com>
 940
 941         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 942         tui-data.c.
 943         (show_source_disasm_command, show_data)
 944         (show_source_or_disasm_and_command): Don't use
 945         tui_set_current_layout_to.
 946         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 947         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 948         tui-layout.c.
 949         (tui_set_current_layout_to): Remove.
 950
 951 2019-08-13  Tom Tromey  <tom@tromey.com>
 952
 953         * tui/tui-layout.c (tui_set_layout): Update.
 954         * tui/tui-data.h (struct tui_layout_def): Remove.
 955         (tui_layout_def): Don't declare.
 956         * tui/tui-data.c (layout_def): Remove.
 957         (tui_layout_def): Remove.
 958
 959 2019-08-13  Tom Tromey  <tom@tromey.com>
 960
 961         * tui/tui-winsource.h (struct tui_source_window_base)
 962         <clear_detail>: No longer "override".
 963         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 964         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 965         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 966         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 967         Remove.
 968         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 969
 970 2019-08-13  Tom Tromey  <tromey@adacore.com>
 971
 972         * tracepoint.c: Don't include readline.h or history.h.
 973
 974 2019-08-12  Tom Tromey  <tom@tromey.com>
 975
 976         * configure: Rebuild.
 977         * configure.ac: Check for readline 7.
 978         * NEWS: Mention readline 7 requirement.
 979         * README: Update.
 980
 981 2019-08-12  Tom Tromey  <tom@tromey.com>
 982
 983         * mingw-hdep.c (gdb_select): Remove readline hack.
 984
 985 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 986
 987         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 988         when the function fails.
 989
 990 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 991
 992         * s390-tdep.c (s390_type_align): New function.
 993         (s390_gdbarch_init): Set it as type_align gdbarch method.
 994
 995 2019-08-09  Tom de Vries  <tdevries@suse.de>
 996
 997         PR gdb/24591
 998         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 999         pc_low with relocation offset.
1000
1001 2019-08-07  Tom Tromey  <tromey@adacore.com>
1002
1003         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1004         (print_frame_args): Update.
1005         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
1006         Update.
1007         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1008         * frame.h (struct frame_arg): Add initializers.
1009         <error>: Now a unique_xmalloc_ptr.
1010
1011 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
1012
1013         * NEWS: Expand the Pointer Authentication entry.
1014         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
1015         (aarch64_frame_unmask_lr): ... to this.
1016         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
1017         Call aarch64_frame_unmask_lr.
1018         * frame.c (struct frame_info): Add "masked" variable.
1019         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
1020         (fprint_frame): Check for masked pc.
1021         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
1022         declarations.
1023         * python/py-framefilter.c (py_print_frame): Check for masked pc.
1024         * stack.c (print_frame): Check for masked pc.
1025
1026 2019-08-06  Tom Tromey  <tom@tromey.com>
1027
1028         * stabsread.c (patch_block_stabs, read_one_struct_field)
1029         (read_enum_type): Use obstack_strndup.
1030         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1031         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1032         * dwarf2read.c (guess_full_die_structure_name)
1033         (anonymous_struct_prefix): Use obstack_strndup.
1034         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1035         * c-exp.y (yylex): Use obstack_strndup.
1036         * ada-exp.y (write_object_renaming, write_ambiguous_var)
1037         (write_var_or_type): Use obstack_strndup.
1038
1039 2019-08-06  Tom Tromey  <tom@tromey.com>
1040
1041         * symfile.c (reread_symbols): Use obstack_strdup.
1042         * stabsread.c (read_type): Use obstack_strdup.
1043         * gdb_obstack.h (obstack_strdup): New overload.
1044         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1045         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1046         (dwarf2_canonicalize_name): Use obstack_strdup.
1047         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1048         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1049         Use obstack_strdup.
1050
1051 2019-08-06  Tom Tromey  <tom@tromey.com>
1052
1053         * gdb_obstack.h (obstack_strdup): Define.
1054         * gdb_obstack.c (obstack_strdup): Don't define.
1055
1056 2019-08-06  Tom Tromey  <tom@tromey.com>
1057
1058         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1059         obstack_strdup.
1060         * typeprint.c (typedef_hash_table::find_global_typedef): Use
1061         obstack_strdup.
1062         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1063         * stabsread.c (common_block_start): Use obstack_strdup.
1064         * objfiles.c (set_objfile_main_name, objfile): Use
1065         obstack_strdup.
1066         * namespace.c (add_using_directive): Use obstack_strdup.
1067         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1068         * jit.c (finalize_symtab): Use obstack_strdup.
1069         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1070         (guess_partial_die_structure_name, partial_die_info::fixup)
1071         (dwarf2_name): Use obstack_strdup.
1072         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1073         obstack_strdup.
1074         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1075         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1076         obstack_strdup.
1077         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1078
1079 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1080
1081         * unittests/help-doc-selftests.c: New file.
1082         * Makefile.in: Add the new file.
1083
1084 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1085
1086         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1087         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
1088         the full first line, except when FOR_VALUE_PREFIX.  In this case,
1089         the trailing '.' is not output, and the first character is uppercased.
1090         (print_help_for_command): Update call to print_doc_line.
1091         (print_doc_of_command): Likewise.
1092         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1093         * cli/cli-option.c (append_indented_doc): Do not append newline.
1094         (build_help_option): Append newline after first appended_indented_doc
1095         only if a second call is done.
1096         (build_help): Append 2 new lines before each option, except the first
1097         one.
1098         * compile/compile.c (_initialize_compile): Add new lines after
1099         %OPTIONS%, when not at the end of the help.
1100         Change help doc or code
1101         producing the help doc to respect the invariants.
1102         * maint-test-options.c (_initialize_maint_test_options): Likewise.
1103         Also removed the new line after 'Options:', as all other commands
1104         do not put an empty line between 'Options:' and the first option.
1105         * printcmd.c (_initialize_printcmd): Likewise.
1106         * stack.c (_initialize_stack): Likewise.
1107         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1108         incorrectly telling COMMAND is optional.
1109         * ada-lang.c (_initialize_ada_language): Change help doc or code
1110         producing the help doc to respect the invariants.
1111         * ada-tasks.c (_initialize_ada_tasks): Likewise.
1112         * breakpoint.c (_initialize_breakpoint): Likewise.
1113         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1114         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1115         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1116         * cli/cli-style.c (cli_style_option::add_setshow_commands,
1117         _initialize_cli_style): Likewise.
1118         * corelow.c (core_target_info): Likewise.
1119         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1120         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1121         * filesystem.c (_initialize_filesystem): Likewise.
1122         * frame.c (_initialize_frame): Likewise.
1123         * gnu-nat.c (add_task_commands): Likewise.
1124         * infcall.c (_initialize_infcall): Likewise.
1125         * infcmd.c (_initialize_infcmd): Likewise.
1126         * interps.c (_initialize_interpreter): Likewise.
1127         * language.c (_initialize_language): Likewise.
1128         * linux-fork.c (_initialize_linux_fork): Likewise.
1129         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1130         * maint.c (_initialize_maint_cmds): Likewise.
1131         * memattr.c (_initialize_mem): Likewise.
1132         * printcmd.c (_initialize_printcmd): Likewise.
1133         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1134         _RegEx): Likewise.
1135         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1136         * record-btrace.c (_initialize_record_btrace): Likewise.
1137         * record-full.c (_initialize_record_full): Likewise.
1138         * record.c (_initialize_record): Likewise.
1139         * regcache-dump.c (_initialize_regcache_dump): Likewise.
1140         * regcache.c (_initialize_regcache): Likewise.
1141         * remote.c (add_packet_config_cmd, init_remote_threadtests,
1142         _initialize_remote): Likewise.
1143         * ser-tcp.c (_initialize_ser_tcp): Likewise.
1144         * serial.c (_initialize_serial): Likewise.
1145         * skip.c (_initialize_step_skip): Likewise.
1146         * source.c (_initialize_source): Likewise.
1147         * stack.c (_initialize_stack): Likewise.
1148         * symfile.c (_initialize_symfile): Likewise.
1149         * symtab.c (_initialize_symtab): Likewise.
1150         * target-descriptions.c (_initialize_target_descriptions): Likewise.
1151         * top.c (init_main): Likewise.
1152         * tracefile-tfile.c (tfile_target_info): Likewise.
1153         * tracepoint.c (_initialize_tracepoint): Likewise.
1154         * tui/tui-win.c (_initialize_tui_win): Likewise.
1155         * utils.c (add_internal_problem_command): Likewise.
1156         * valprint.c (value_print_option_defs): Likewise.
1157
1158 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
1159
1160         PR build/24886
1161         * configure.ac: Drop enable-libmcheck support.
1162         * configure, config.in: Rebuild.
1163         * libmcheck.m4: Remove.
1164         * acinclude.m4: Don't include it.
1165         * Makefile.in: Don't distribute it.
1166         * top.c (print_gdb_configuration): Don't mention it.
1167
1168 2019-08-06  Tom Tromey  <tom@tromey.com>
1169
1170         * utils.c (set_output_style): Sometimes pass stream to
1171         emit_style_escape.
1172         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1173         * record-btrace.c (btrace_insn_history): Update.
1174         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1175         method.
1176         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1177         Update initializers.
1178         <m_uiout>: New field.
1179         <m_di>: Move lower.
1180         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1181         Remove "uiout" parameter.
1182         (dump_insns): Update.
1183         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1184         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1185
1186 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
1187
1188         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1189         (error_in_psymtab_expansion): Likewise.
1190         (lookup_symbol_via_quick_fns): Likewise.
1191         (basic_lookup_transparent_type_quick): Likewise.
1192         (basic_lookup_transparent_type_1): Likewise.
1193
1194 2019-08-06  Tom Tromey  <tromey@adacore.com>
1195
1196         * source.c (last_source_error): Now bool.
1197         (print_source_lines_base): Make "noprint" bool.  Only open
1198         source file when last_source_visited changes.
1199
1200 2019-08-06  Tom Tromey  <tromey@adacore.com>
1201
1202         * annotate.c (annotate_source_line): Use g_source_cache.
1203         * source-cache.c (source_cache::get_plain_source_lines): Change
1204         parameters.  Populate m_offset_cache.
1205         (source_cache::ensure): New method.
1206         (source_cache::get_line_charpos): New method.
1207         (extract_lines): Move lower.  Change parameters.
1208         (source_cache::get_source_lines): Move lower.
1209         * source-cache.h (class source_cache): Update comment.
1210         <get_line_charpos>: New method.
1211         <get_source_lines>: Update comment.
1212         <clear>: Clear m_offset_cache.
1213         <get_plain_source_lines>: Change parameters.
1214         <ensure>: New method
1215         <m_offset_cache>: New member.
1216         * source.c (forget_cached_source_info_for_objfile): Update.
1217         (info_source_command): Use g_source_cache.
1218         (find_source_lines, open_source_file_with_line_charpos): Remove.
1219         (print_source_lines_base, search_command_helper): Use g_source_cache.
1220         * source.h (open_source_file_with_line_charpos): Don't declare.
1221         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1222         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1223         Use g_source_cache.
1224
1225 2019-08-06  Tom Tromey  <tromey@adacore.com>
1226
1227         * source-cache.c (source_cache::get_plain_source_lines):
1228         Remove "first_line" and "last_line" parameters.
1229         (source_cache::get_source_lines): Cache plain text.
1230         * source-cache.h (class source_cache)
1231         <get_plain_source_lines>: Update.
1232
1233 2019-08-06  Tom Tromey  <tromey@adacore.com>
1234
1235         * source-cache.c (extract_lines): No longer a method.
1236         Changed type of parameter.  Include final newline.
1237         (selftests::extract_lines_test): New function.
1238         (_initialize_source_cache): Likewise.
1239         * source-cache.h (class source_cache)
1240         <extract_lines>: Don't declare.
1241
1242 2019-08-06  Tom Tromey  <tromey@adacore.com>
1243
1244         * breakpoint.c (init_breakpoint_sal): Update.
1245         (breakpoint): Update.
1246         * breakpoint.h (struct breakpoint) <filter>: Now a
1247         unique_xmalloc_ptr.
1248
1249 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1250
1251         * NEWS: Mention dictionary access on blocks.
1252         * python/py-block.c (blpy_getitem): New function.
1253         (block_object_as_mapping): New struct.
1254         (block_object_type): Use new struct for tp_as_mapping field.
1255
1256 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1257
1258         * objfiles.h (objfile): Add a comment describing partial symbols.
1259
1260 2019-08-05  Tom Tromey  <tromey@adacore.com>
1261
1262         * compile/compile.c (_initialize_compile): Use _(), not N_().
1263         * thread.c (_initialize_thread): Use _(), not N_().
1264         * stack.c (_initialize_stack): Use _(), not N_().
1265         * printcmd.c (_initialize_printcmd): Use _(), not N_().
1266
1267 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1268
1269         * dwarf2read.c (struct dw2_symtab_iterator):
1270         <want_specific_block>: Remove.
1271         <block_index>: Change type to gdb::optional.
1272         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1273         change type of BLOCK_INDEX parameter to gdb::optional.
1274         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1275         (dw2_lookup_symbol): Don't pass argument for
1276         WANT_SPECIFIC_BLOCK.
1277         (dw2_expand_symtabs_for_function): Don't pass argument for
1278         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1279         (class dw2_debug_names_iterator)
1280         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1281         parameter, change BLOCK_INDEX type to gdb::optional.
1282         <m_want_specific_block>: Remove.
1283         <m_block_index>: Change type to gdb::optional.
1284         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1285         gdb::optional.  Re-write in function of gdb::optional.
1286         (dw2_debug_names_lookup_symbol): Don't pass argument for
1287         WANT_SPECIFIC_BLOCK.
1288         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1289         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1290         BLOCK_INDEX.
1291
1292 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1293
1294         * NEWS: Mention changes to "info sources" command.
1295
1296 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1297
1298         * symtab.c (filename_partial_match_opts): New struct type.
1299         (struct output_source_filename_data): New members
1300         regexp, c_regexp, partial_match.
1301         (output_source_filename): Use new members to decide to print file.
1302         (info_sources_option_defs): New variable.
1303         (make_info_sources_options_def_group, print_info_sources_header,
1304         info_sources_command_completer):
1305         New functions.
1306         (info_sources_command): Read new optional arguments.
1307         (_initialize_symtab): Update info sources help.
1308
1309 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1310
1311         * ada-lang.c (exception_support_info_v0): Renamed from...
1312         (default_exception_support_info): ... this.  Create new
1313         definition for v1.
1314         (ada_has_this_exception_support): Look up catch_handlers_sym.
1315         (ada_exception_support_info_sniffer): Try v0 after default.
1316
1317 2019-08-01  Tom Tromey  <tromey@adacore.com>
1318
1319         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1320         gdbarch.h.
1321
1322 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1323
1324         * s12z-tdep.c: Fix include path for s12z-opc.h.
1325
1326 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1327
1328         * NEWS: Require GNU make 3.82.
1329
1330 2019-07-16  Tom Tromey  <tom@tromey.com>
1331
1332         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1333         declare.
1334
1335 2019-07-30  Tom Tromey  <tromey@adacore.com>
1336
1337         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1338
1339 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1340
1341         * printcmd.c (print_address_symbolic): Print negative offsets.
1342         (build_address_symbolic): Force signed arithmetic when computing
1343         offset.
1344
1345 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1346
1347         PR/24474: Add a function to lookup static variables.
1348         * NEWS: Mention this new function.
1349         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1350         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1351         * python/python.c (python_GdbMethods): Add new function.
1352
1353 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1354
1355         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1356         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1357         (objfpy_lookup_static_symbol): New function.
1358         (objfile_object_methods): Add new functions.
1359
1360 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1361
1362         * NEWS: Mention 'set|show print frame-info'.  Mention new
1363         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1364         backtrace argument.  Mention that python frame filtering code
1365         is now consistent with what 'backtrace' command prints.
1366
1367 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1368
1369         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1370         comments.
1371         (print_frame_info_auto, print_frame_info_source_line,
1372         print_frame_info_location, print_frame_info_source_and_location,
1373         print_frame_info_location_and_address, print_frame_info_short_location):
1374         New declarations.
1375         (struct frame_print_options): New member print_frame_info.
1376         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1377         * stack.h (get_user_print_what_frame_info): New declaration.
1378         (frame_show_address): New declaration.
1379         * stack.c (print_frame_arguments_choices): New value 'presence'.
1380         (print_frame_info_auto, print_frame_info_source_line,
1381         print_frame_info_location, print_frame_info_source_and_location,
1382         print_frame_info_location_and_address, print_frame_info_short_location,
1383         print_frame_info_choices, print_frame_info_print_what): New definitions.
1384         (print_frame_args): Only print dots for args if print frame-arguments
1385         is 'presence'.
1386         (frame_print_option_defs): New element for "frame-info".
1387         (get_user_print_what_frame_info): New function.
1388         (frame_show_address): Make non static.  Move comment to stack.h.
1389         (print_frame_info_to_print_what): New function.
1390         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1391         to decide what to print.
1392         (backtrace_command_1): Handle the new print_frame_arguments_presence
1393         value.
1394         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1395         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1396         (py_print_frame): In non-mi mode, use LOCATION as default for
1397         print_what, similarly to frame information printed directly by
1398         backtrace command. Handle frame-info user option in non MI mode.
1399
1400 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1401
1402         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1403         Add case for debugging 32-bit target on 64-bit host.  Revise
1404         comment.
1405
1406 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1407
1408         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1409         instead of find_function_entry_range_from_pc.
1410
1411 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1412
1413         * stack.c (find_frame_funname): Remove code which preferred
1414         minsym over symtab sym in "certain pathological cases".
1415
1416         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1417         parameter.  Change type of "do_demangle" to bool.
1418         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1419         Pass suitable "prefer_sym_over_minsym" flag to
1420         build_address_symbolic().  Don't output "+" for negative offsets.
1421         * printcmd.c (print_address_symbolic): Update invocation of
1422         build_address_symbolic to include a "prefer_sym_over_minsym"
1423         flag.
1424         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1425         Restrict cases in which use of minimal symbol is preferred to that
1426         of a found symbol.  Update comments.
1427
1428         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1429         for entry pc when entry pc is out of range for that FDE.
1430
1431 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1432
1433         PR gdb/24839:
1434         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1435         type.
1436
1437 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1438
1439         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1440         this function's Python signature.
1441
1442
1443 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1444
1445         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1446         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1447         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1448         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1449         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1450
1451
1452 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1453
1454         * h8300-tdep.c (h8300_register_name_common): New.
1455         h8300_register_name): Use h8300_register_name_common.
1456         (h8300s_register_name): Likewise.
1457         (h8300sx_register_name): Likewise.
1458         (h8300h_register_nam): New.
1459         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1460
1461
1462 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1463
1464         * arm-tdep.c (arm_skip_cmse_entry): New function.
1465         (arm_is_sgstubs_section): New function.
1466         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1467
1468 2019-07-22  Tom Tromey  <tom@tromey.com>
1469
1470         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1471         Don't self-assign.
1472
1473 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1474
1475         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1476         type_print.
1477
1478 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1479
1480         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1481         so that GDB doesn't match any msymbols when searching in the
1482         TYPES_DOMAIN.
1483         (print_symbol_info): Print using typedef_print or type_print based
1484         on the type of the symbol.  Add updated FIXME comment moved from...
1485         (_initialize_symtab): ... move and update FIXME comment to above.
1486
1487 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1488
1489         * NEWS: Mention adding -q option to "info types".
1490         * symtab.c (struct info_types_options): New struct.
1491         (info_types_options_defs): New variable.
1492         (make_info_types_options_def_group): New function.
1493         (info_types_command): Use gdb::option framework to parse options.
1494         (info_types_command_completer): New function.
1495         (_initialize_symtab): Extend the help text on "info types" and
1496         register command completer.
1497
1498 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1499
1500         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1501         (lookup_symbol_in_objfile): Change int to block_enum and add a
1502         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1503
1504 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1505
1506         * MAINTAINERS (Write After Approval): Add self.
1507
1508 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1509
1510         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1511         instruction to the dummy code region.
1512
1513 2019-07-19  Tom Tromey  <tromey@adacore.com>
1514
1515         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1516         (ARGSUSED, PARAMS, __func__): Remove rules.
1517
1518 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1519
1520         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1521         * features/arm/arm-with-iwmmxt.c: Remove.
1522         * features/arm/arm-with-iwmmxt.xml: Remove.
1523         * features/arm/arm-with-m-fpa-layout.c: Remove.
1524         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1525         * features/arm/arm-with-m-vfp-d16.c: Remove.
1526         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1527         * features/arm/arm-with-m.c: Remove.
1528         * features/arm/arm-with-m.xml: Remove.
1529         * features/arm/arm-with-neon.c: Remove.
1530         * features/arm/arm-with-neon.xml: Remove.
1531         * features/arm/arm-with-vfpv2.c: Remove.
1532         * features/arm/arm-with-vfpv2.xml: Remove.
1533         * features/arm/arm-with-vfpv3.c: Remove.
1534         * features/arm/arm-with-vfpv3.xml: Remove.
1535
1536 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1537
1538         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1539
1540 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1541
1542         * arch/aarch32.c (aarch32_create_target_description): Create
1543         target descriptions using features.
1544         * arch/arm.c (arm_create_target_description)
1545         (arm_create_mprofile_target_description): Likewise.
1546         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1547
1548 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1549
1550         * Makefile.in: Add new files.
1551         * aarch32-tdep.c: New file.
1552         * aarch32-tdep.h: New file.
1553         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1554         Call aarch32_read_description.
1555         * arch/aarch32.c: New file.
1556         * arch/aarch32.h: New file.
1557         * arch/arm.c (arm_create_target_description)
1558         (arm_create_mprofile_target_description): New function.
1559         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1560         (arm_create_target_description)
1561         (arm_create_mprofile_target_description): New declaration.
1562         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1563         read_description functions.
1564         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1565         Likewise.
1566         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1567         * arm-tdep.c (tdesc_arm_list): New variable.
1568         (arm_register_g_packet_guesses): Call create description functions.
1569         (arm_read_description) (arm_read_mprofile_description): New
1570         function.
1571         * arm-tdep.h (arm_read_description)
1572         (arm_read_mprofile_description): Add declaration.
1573         * configure.tgt: Add new files.
1574
1575 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1576
1577         * top.c (new_ui_command): Open specified terminal just once.
1578
1579 2019-07-18  Tom Tromey  <tromey@adacore.com>
1580
1581         * symtab.c (main_name): Constify return type.
1582         * symfile.c (set_initial_language): Update.
1583         * symtab.h (main_name): Constify return type.
1584
1585 2019-07-17  Tom Tromey  <tom@tromey.com>
1586
1587         * tui/tui-winsource.c (tui_update_source_window)
1588         (tui_update_source_window_as_is)
1589         (tui_update_source_windows_with_line): Remove return.
1590         * tui/tui-disasm.c (tui_show_disassem)
1591         (tui_show_disassem_and_update_source): Remove return.
1592         * tui/tui.c (tui_reset): Remove return.
1593         * tui/tui-wingeneral.c
1594         (tui_check_and_display_highlight_if_needed): Remove return.
1595
1596 2019-07-17  Tom Tromey  <tom@tromey.com>
1597
1598         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1599
1600 2019-07-17  Tom Tromey  <tom@tromey.com>
1601
1602         * tui/tui-winsource.h (struct tui_exec_info_window)
1603         (struct tui_source_window_base): Move from tui-data.h.
1604         * tui/tui-winsource.c: Move many method definitions from
1605         elsewhere.  Remove "structuring" comments.
1606         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1607         (tui_source_window_base::refresh_window): Move to
1608         tui-winsource.c.
1609         * tui/tui-win.c (tui_source_window_base::refresh_all)
1610         (tui_source_window_base::update_tab_width)
1611         (tui_source_window_base::set_new_height)
1612         (tui_source_window_base::do_make_visible_with_new_height): Move to
1613         tui-winsource.c.
1614         * tui/tui-source.h: Update.
1615         * tui/tui-source.c (tui_source_window_base::reset): Move to
1616         tui-winsource.c.
1617         * tui/tui-disasm.h: Update.
1618         * tui/tui-data.h (struct tui_exec_info_window): Move to
1619         tui-winsource.h.
1620         (struct tui_source_window_base): Likewise.
1621         * tui/tui-data.c (tui_source_window_base::clear_detail)
1622         (tui_source_window_base, ~tui_source_window_base): Move to
1623         tui-winsource.c.
1624
1625 2019-07-17  Tom Tromey  <tom@tromey.com>
1626
1627         * tui/tui-win.c (tui_resize_all)
1628         (tui_source_window_base::update_tab_width)
1629         (tui_adjust_win_heights): Update.
1630         (tui_win_info::make_invisible_and_set_new_height): Rename from
1631         make_invisible_and_set_new_height.
1632         * tui/tui-data.h (struct tui_win_info)
1633         <make_invisible_and_set_new_height>: New method.
1634
1635 2019-07-17  Tom Tromey  <tom@tromey.com>
1636
1637         * tui/tui.c: Update.
1638         * tui/tui-source.h (struct tui_source_window): Move from
1639         tui-data.h.
1640         * tui/tui-layout.c: Update.
1641         * tui/tui-disasm.c: Update.
1642         * tui/tui-data.h (struct tui_source_window): Move to
1643         tui-source.h.
1644
1645 2019-07-17  Tom Tromey  <tom@tromey.com>
1646
1647         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1648         tui-data.h.
1649         * tui/tui-data.h (struct tui_disasm_window): Move to
1650         tui-disasm.h.
1651
1652 2019-07-17  Tom Tromey  <tom@tromey.com>
1653
1654         * tui/tui-regs.h (struct tui_data_item_window): Move from
1655         tui-data.h.
1656         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1657         * tui/tui-data.h (struct tui_data_item_window): Move to
1658         tui-regs.h.
1659         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1660
1661 2019-07-17  Tom Tromey  <tom@tromey.com>
1662
1663         * tui/tui.c: Update.
1664         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1665         (tui_cmd_window::max_height): Move to tui-command.c.
1666         * tui/tui-layout.c: Update.
1667         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1668         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1669         tui-command.c.
1670         * tui/tui-command.h (struct tui_cmd_window): Move from
1671         tui-data.h.
1672         * tui/tui-command.c: Remove "structuring" comments.
1673         (tui_cmd_window::clear_detail)
1674         (tui_cmd_window::do_make_visible_with_new_height)
1675         (tui_cmd_window::max_height): Move from elsewhere.
1676
1677 2019-07-17  Tom Tromey  <tom@tromey.com>
1678
1679         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1680         Now static.
1681         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1682         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1683
1684 2019-07-17  Tom Tromey  <tom@tromey.com>
1685
1686         * tui/tui.c: Update.
1687         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1688         tui-regs.c.
1689         * tui/tui-windata.h: Remove file.
1690         * tui/tui-windata.c: Remove file.
1691         * tui/tui-win.c (tui_data_window::set_new_height)
1692         (tui_data_window::do_make_visible_with_new_height): Move to
1693         tui-regs.c.
1694         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1695         * tui/tui-regs.c: Remove "structuring" comments.
1696         (tui_data_window::first_data_item_displayed)
1697         (tui_data_window::delete_data_content_windows)
1698         (tui_data_window::erase_data_content)
1699         (tui_data_window::display_all_data)
1700         (tui_data_window::refresh_all)
1701         (tui_data_window::do_scroll_vertical)
1702         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1703         (tui_data_window::do_make_visible_with_new_height)
1704         (tui_data_window::refresh_window): Move from elsewhere.
1705         (_initialize_tui_regs): Move to end of file.
1706         * tui/tui-layout.c: Update.
1707         * tui/tui-hooks.c: Update.
1708         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1709         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1710         tui-regs.c.
1711         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1712
1713 2019-07-17  Tom Tromey  <tom@tromey.com>
1714
1715         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1716         seen.
1717
1718 2019-07-17  Tom Tromey  <tom@tromey.com>
1719
1720         * tui/tui-win.c (tui_source_window_base::set_new_height)
1721         (tui_source_window_base::do_make_visible_with_new_height): Use
1722         m_has_locator field directly.
1723         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1724         method.
1725         (struct tui_source_window_base) <has_locator>: Likewise.
1726
1727 2019-07-17  Tom Tromey  <tom@tromey.com>
1728
1729         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1730         Don't declare.
1731         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1732         Remove.
1733         * tui/tui-win.c (tui_source_window_base::set_new_height)
1734         (tui_source_window_base::set_new_height)
1735         (make_invisible_and_set_new_height)
1736         (tui_source_window_base::do_make_visible_with_new_height)
1737         (tui_source_window_base::do_make_visible_with_new_height):
1738         Update.
1739         * tui/tui-layout.c (show_source_disasm_command, show_data)
1740         (show_source_or_disasm_and_command): Update.
1741         * tui/tui-layout.c (show_layout): Update.
1742
1743 2019-07-17  Tom Tromey  <tom@tromey.com>
1744
1745         * tui/tui-layout.c (make_data_window): Remove.
1746         (show_data): Unify creation and re-initialization cases.
1747
1748 2019-07-17  Tom Tromey  <tom@tromey.com>
1749
1750         * tui/tui-layout.c (make_source_window, make_disasm_window):
1751         Remove.
1752         (show_data): Unify creation and re-initialization cases.
1753
1754 2019-07-17  Tom Tromey  <tom@tromey.com>
1755
1756         * tui/tui-layout.c (make_command_window): Remove.
1757         (show_source_disasm_command, show_source_or_disasm_and_command):
1758         Unify creation and re-initialization cases.
1759
1760 2019-07-17  Tom Tromey  <tom@tromey.com>
1761
1762         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1763         creation and re-initialization cases.
1764
1765 2019-07-17  Tom Tromey  <tom@tromey.com>
1766
1767         * tui/tui-regs.c (tui_get_register): Return void.
1768
1769 2019-07-17  Tom Tromey  <tom@tromey.com>
1770
1771         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1772         Simplify.
1773
1774 2019-07-17  Tom Tromey  <tom@tromey.com>
1775
1776         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1777         resetting.
1778
1779 2019-07-17  Tom Tromey  <tom@tromey.com>
1780
1781         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1782         * tui/tui-regs.c (tui_reg_layout): New function.
1783         (tui_show_registers, tui_reg_command): Use it.
1784         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1785         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1786         parameters.
1787         (tui_layout_command): Remove.
1788
1789 2019-07-17  Tom Tromey  <tom@tromey.com>
1790
1791         * tui/tui-layout.h (tui/tui-layout): Return void.
1792         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1793
1794 2019-07-17  Tom Tromey  <tom@tromey.com>
1795
1796         * tui/tui-layout.c (show_source_disasm_command, show_data):
1797         Update.
1798         (reset_locator): Remove.
1799         (show_source_or_disasm_and_command): Update.
1800
1801 2019-07-17  Tom Tromey  <tom@tromey.com>
1802
1803         * tui/tui-source.c (tui_source_window_base::reset): Remove
1804         win_type parameter.
1805         * tui/tui-layout.c (make_command_window, make_source_window)
1806         (make_disasm_window, make_data_window)
1807         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1808         (reset_locator, show_source_or_disasm_and_command): Update.
1809         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1810         win_type parameter.
1811         (struct tui_source_window_base) <reset>: Likewise.
1812
1813 2019-07-17  Tom Tromey  <tom@tromey.com>
1814
1815         * tui/tui-layout.c (show_source_disasm_command): Use
1816         reset_locator.
1817         (reset_locator): New function.
1818         (init_and_make_win): Remove.
1819         (show_source_or_disasm_and_command): Use reset_locator.
1820
1821 2019-07-17  Tom Tromey  <tom@tromey.com>
1822
1823         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1824         condition.
1825         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1826         Remove condition.
1827         * tui/tui-source.c (tui_source_window_base::reset): New method.
1828         * tui/tui-layout.c (make_command_window): Don't call
1829         init_and_make_win.
1830         (make_source_window, make_disasm_window): Don't call
1831         make_source_or_disasm_window.
1832         (make_data_window): Don't call init_and_make_win.  Change calling
1833         convention.
1834         (show_source_disasm_command, show_data): Simplify.
1835         (make_source_or_disasm_window): Remove.
1836         (show_source_or_disasm_and_command): Simplify.
1837         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1838         (struct tui_source_window_base) <reset>: Likewise.
1839         <execution_info>: Remove initializer.
1840         * tui/tui-data.c (tui_source_window_base): Initialize
1841         execution_info.
1842
1843 2019-07-17  Tom Tromey  <tom@tromey.com>
1844
1845         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1846         variable.
1847
1848 2019-07-17  Tom Tromey  <tom@tromey.com>
1849
1850         * tui/tui.c (tui_rl_other_window): Update.
1851         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1852         superclass method first.  Always iterate over regs_content.
1853         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1854         method.
1855         * tui/tui-win.c (tui_set_focus_command): Update.
1856
1857 2019-07-17  Tom Tromey  <tom@tromey.com>
1858
1859         * tui/tui-win.c (tui_set_focus_command): Rename from
1860         tui_set_focus.  Call tui_enable.
1861         (tui_set_focus_command): Remove.
1862
1863 2019-07-17  Tom Tromey  <tom@tromey.com>
1864
1865         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1866         refresh_window.
1867         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1868         touchwin.
1869         (tui_data_window::refresh_window): Call refresh_window on data
1870         items.  Always call superclass refresh_window.
1871         (tui_win_info::refresh): Remove.
1872         (tui_source_window_base::refresh_window): Update.
1873         (tui_refresh_all): Update.
1874         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1875         refresh_window.
1876         (show_source_or_disasm_and_command): Likewise.
1877         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1878         (struct tui_source_window_base) <refresh>: Likewise.
1879
1880 2019-07-17  Tom Tromey  <tom@tromey.com>
1881
1882         * tui/tui-winsource.c (tui_clear_source_content)
1883         (tui_show_source_content): Update.
1884         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1885         whether content is empty.
1886         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1887         Remove.
1888
1889 2019-07-17  Tom Tromey  <tom@tromey.com>
1890
1891         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1892         window's contents.
1893         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1894         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1895
1896 2019-07-17  Tom Tromey  <tom@tromey.com>
1897
1898         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1899         (struct tui_data_item_window): Update.
1900
1901 2019-07-17  Tom Tromey  <tom@tromey.com>
1902
1903         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1904         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1905         defines.
1906
1907 2019-07-17  Tom Tromey  <tom@tromey.com>
1908
1909         * tui/tui-winsource.h (tui_erase_source_content)
1910         (tui_clear_source_content): Remove "display_prompt" parameter.
1911         * tui/tui-winsource.c (tui_update_source_window_as_is)
1912         (tui_update_source_windows_with_addr): Update.
1913         (tui_clear_source_content): Remove "display_prompt" parameter.
1914         (tui_erase_source_content): Likewise.  Simplify.
1915         (tui_show_source_content): Update.
1916         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1917         * tui/tui-stack.c (tui_show_frame_info): Update.
1918         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1919         Remove defines.
1920
1921 2019-07-17  Tom Tromey  <tom@tromey.com>
1922
1923         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1924         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1925         parameter.
1926         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1927         parameter.
1928
1929 2019-07-17  Tom Tromey  <tom@tromey.com>
1930
1931         * tui/tui-winsource.c (tui_clear_source_content)
1932         (tui_show_source_content, tui_show_exec_info_content)
1933         (tui_clear_exec_info_content): Update.
1934         * tui/tui-stack.c (tui_show_locator_content): Update.
1935         (tui_show_frame_info): Update.
1936         * tui/tui-source.h (tui_source_window): Don't declare.
1937         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1938         from tui_source_is_displayed.
1939         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1940         Remove field.
1941         (struct tui_source_window_base) <content_in_use>: New field.  Now
1942         bool.
1943         (struct tui_source_window) <showing_source_p>: New method.
1944         (TUI_SRC_WIN): Change cast.
1945         * tui/tui-data.c (tui_initialize_static_data): Update.
1946
1947 2019-07-17  Tom Tromey  <tom@tromey.com>
1948
1949         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1950         location_matches_p.
1951         * tui/tui-source.c (tui_source_window::location_matches_p): New
1952         method.
1953         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1954         method.
1955         * tui/tui-data.h (struct tui_source_window_base)
1956         <location_matches_p>: New method.
1957         (struct tui_source_window, struct tui_disasm_window)
1958         <location_matches_p>: Likewise.
1959
1960 2019-07-17  Tom Tromey  <tom@tromey.com>
1961
1962         * tui/tui-win.c (tui_set_win_height_command): Rename from
1963         tui_set_win_height.
1964         (tui_set_win_height_command): Remove.
1965
1966 2019-07-17  Tom Tromey  <tom@tromey.com>
1967
1968         * tui/tui-source.c (tui_source_window): New constructor.  Add
1969         observer.
1970         (~tui_source_window): New destructor.
1971         (tui_source_window::style_changed): New method.
1972         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1973         (tui_attach_detach_observers): Update.
1974         * tui/tui-data.h (struct tui_source_window): Make constructor not
1975         inline.  Add destructor.
1976         (struct tui_source_window) <style_changed>: New method.
1977         <m_observable>: New member.
1978
1979 2019-07-17  Tom Tromey  <tom@tromey.com>
1980
1981         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1982         * tui/tui-win.c (tui_resize_all): Fix typo.
1983
1984 2019-07-17  Tom Tromey  <tom@tromey.com>
1985
1986         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1987         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1988         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1989         * tui/tui-win.c (window_name_completer): Use foreach.
1990         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1991         (update_tab_width): Likewise.
1992         * tui/tui-layout.c (show_layout): Update.
1993         * tui/tui-data.h (class tui_window_iterator): New.
1994         (struct all_tui_windows): New.
1995         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1996
1997 2019-07-17  Tom Tromey  <tom@tromey.com>
1998
1999         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
2000         parameter.  Don't reference globals.
2001         (tui_reg_command): Update.
2002
2003 2019-07-17  Tom Tromey  <tom@tromey.com>
2004
2005         * tui/tui-regs.c (tui_show_registers): Simplify.
2006
2007 2019-07-17  Tom Tromey  <tom@tromey.com>
2008
2009         * tui/tui-regs.c (tui_show_registers): Update.
2010         (tui_show_register_group): Add win_info parameter.
2011
2012 2019-07-17  Tom Tromey  <tom@tromey.com>
2013
2014         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
2015         Rename from tui_display_reg_element_at_line.
2016         (tui_data_window::display_registers_from_line): Update.
2017         * tui/tui-data.h (struct tui_data_window)
2018         <display_reg_element_at_line>: New method.
2019
2020 2019-07-17  Tom Tromey  <tom@tromey.com>
2021
2022         * tui/tui-regs.h (tui_display_registers_from)
2023         (tui_display_registers_from_line): Don't declare.
2024         * tui/tui-windata.c (tui_data_window::display_all_data)
2025         (tui_data_window::refresh_all)
2026         (tui_data_window::do_scroll_vertical): Update.
2027         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2028         from tui_display_registers_from.
2029         (tui_display_reg_element_at_line): Update.
2030         (tui_data_window::display_registers_from_line): Rename from
2031         tui_display_registers_from_line.
2032         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2033         display_registers_from_line>: New methods.
2034
2035 2019-07-17  Tom Tromey  <tom@tromey.com>
2036
2037         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2038         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2039         from tui_erase_data_content.
2040         (tui_data_window::display_all_data)
2041         (tui_data_window::refresh_all)
2042         (tui_data_window::do_scroll_vertical): Update.
2043         * tui/tui-regs.c (tui_show_registers): Update.
2044         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2045         New method.
2046
2047 2019-07-17  Tom Tromey  <tom@tromey.com>
2048
2049         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2050         declare.
2051         * tui/tui-windata.c
2052         (tui_data_window::delete_data_content_windows): Rename from
2053         tui_delete_data_content_windows.
2054         (tui_data_window::display_all_data)
2055         (tui_data_window::do_scroll_vertical): Update.
2056         * tui/tui-data.h (struct tui_data_window)
2057         <delete_data_content_windows>: New method.
2058
2059 2019-07-17  Tom Tromey  <tom@tromey.com>
2060
2061         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2062         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2063
2064 2019-07-17  Tom Tromey  <tom@tromey.com>
2065
2066         * tui/tui-windata.h (tui_display_all_data): Don't declare.
2067         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2068         from tui_display_all_data.
2069         * tui/tui-win.c
2070         (tui_data_window::do_make_visible_with_new_height): Update.
2071         * tui/tui-regs.c (tui_show_registers): Update.
2072         * tui/tui-layout.c (tui_set_layout): Update.
2073         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2074         method.
2075
2076 2019-07-17  Tom Tromey  <tom@tromey.com>
2077
2078         * tui/tui-windata.h (tui_display_data_from): Don't declare.
2079         * tui/tui-windata.c (tui_display_data_from): Remove.
2080         (tui_data_window::refresh_all): Update.
2081
2082 2019-07-17  Tom Tromey  <tom@tromey.com>
2083
2084         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2085         * tui/tui-windata.c (tui_display_data_from_line): Remove.
2086         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2087         tui_display_registers_from_line.
2088         * tui/tui-regs.h (tui_display_registers_from_line): Update.
2089         * tui/tui-regs.c (tui_display_registers_from_line): Remove
2090         "force_display" parameter.
2091
2092 2019-07-17  Tom Tromey  <tom@tromey.com>
2093
2094         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2095         declare.
2096         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2097         Rename from tui_first_reg_element_no_inline.
2098         (tui_display_reg_element_at_line)
2099         (tui_display_registers_from_line): Update.
2100         * tui/tui-data.h (struct tui_data_window)
2101         <first_reg_element_no_inline>: New method.
2102
2103 2019-07-17  Tom Tromey  <tom@tromey.com>
2104
2105         * tui/tui-windata.c (tui_display_data_from)
2106         (tui_data_window::do_scroll_vertical): Update.
2107         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2108         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2109         Rename from tui_line_from_reg_element_no.
2110         (tui_display_registers_from_line): Update.
2111         * tui/tui-data.h (struct tui_data_window)
2112         <line_from_reg_element_no>: New method.
2113
2114 2019-07-17  Tom Tromey  <tom@tromey.com>
2115
2116         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2117         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2118         tui_last_regs_line_no.
2119         (tui_display_reg_element_at_line)
2120         (tui_display_registers_from_line): Update.
2121         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2122         method.
2123
2124 2019-07-17  Tom Tromey  <tom@tromey.com>
2125
2126         PR tui/24722:
2127         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2128         (tui_update_breakpoint_info): Add "being_deleted" parameter.
2129         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2130         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2131         (tui_update_breakpoint_info): Likewise.
2132         * tui/tui-hooks.c (tui_event_create_breakpoint)
2133         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2134         Update.
2135
2136 2019-07-17  Tom Tromey  <tom@tromey.com>
2137
2138         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2139
2140 2019-07-17  Tom Tromey  <tom@tromey.com>
2141
2142         * tui/tui-winsource.c (tui_update_source_window_as_is)
2143         (tui_update_source_windows_with_addr): Update.
2144         * tui/tui-source.h (tui_set_source_content)
2145         (tui_show_symtab_source): Add "win_info" parameter.
2146         * tui/tui-source.c (tui_set_source_content): Add "win_info"
2147         parameter.
2148         (tui_show_symtab_source): Likewise.
2149
2150 2019-07-17  Tom Tromey  <tom@tromey.com>
2151
2152         * tui/tui-wingeneral.c
2153         (tui_check_and_display_highlight_if_needed): Check can_highlight.
2154
2155 2019-07-17  Tom Tromey  <tom@tromey.com>
2156
2157         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2158         (struct tui_cmd_window) <can_scroll>: New method.
2159         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2160         method.
2161
2162 2019-07-17  Tom Tromey  <tromey@adacore.com>
2163
2164         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2165         do_field_signed>: Rename.  Change type of "value".
2166         * ui-out.c (ui_out::field_signed): Rename from field_int.
2167         Change type of "value".
2168         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
2169         type of "value".
2170         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2171         do_field_int.  Change type of "value".
2172         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2173         do_field_int.  Change type of "value".
2174         * tracepoint.c (trace_status_mi, tfind_1)
2175         (print_one_static_tracepoint_marker): Update.
2176         * thread.c (print_thread_info_1, print_selected_thread_frame):
2177         Update.
2178         * stack.c (print_frame, print_frame_info): Update.
2179         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2180         Update.
2181         * source.c (print_source_lines_base): Update.
2182         * skip.c (info_skip_command): Update.
2183         * record-btrace.c (btrace_ui_out_decode_error)
2184         (btrace_call_history_src_line): Update.
2185         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2186         Update.
2187         * progspace.c (print_program_space): Update.
2188         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2189         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2190         do_field_int.  Change type of "value".
2191         * mi/mi-out.c (mi_ui_out::do_table_begin)
2192         (mi_ui_out::do_table_header): Update.
2193         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
2194         type of "value".
2195         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2196         (mi_cmd_data_list_changed_registers, output_register)
2197         (mi_cmd_data_read_memory, mi_load_progress)
2198         (mi_cmd_trace_frame_collected): Update.
2199         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2200         Update.
2201         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2202         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2203         (mi_cmd_var_list_children, varobj_update_one): Update.
2204         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2205         (mi_cmd_stack_list_args, list_arg_or_local): Update.
2206         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2207         * inferior.c (print_inferior): Update.
2208         * gdb_bfd.c (print_one_bfd): Update.
2209         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2210         Update.
2211         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2212         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2213         do_field_int.  Change type of "value".
2214         * cli-out.c (cli_ui_out::do_field_signed): Rename from
2215         do_field_int.  Change type of "value".
2216         * breakpoint.c (watchpoint_check, print_breakpoint_location)
2217         (print_one_breakpoint_location, print_it_catch_fork)
2218         (print_one_catch_fork, print_it_catch_vfork)
2219         (print_one_catch_vfork, print_it_catch_solib)
2220         (print_it_catch_exec, print_it_ranged_breakpoint)
2221         (print_mention_watchpoint, print_mention_masked_watchpoint)
2222         (bkpt_print_it, update_static_tracepoint): Update.
2223         * break-catch-throw.c (print_it_exception_catchpoint): Update.
2224         * break-catch-syscall.c (print_it_catch_syscall): Update.
2225         * ada-tasks.c (print_ada_task_info): Update.
2226         * ada-lang.c (print_it_exception, print_mention_exception):
2227         Update.
2228
2229 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2230
2231         PR breakpoints/24541
2232         * gdbarch.c: Regenerate.
2233         * gdbarch.h: Regenerate.
2234         * gdbarch.sh: Adjust return type and parameter types for
2235         'stap_adjust_register'.
2236         (i386_stap_adjust_register): Adjust signature and return new
2237         register name.
2238         * stap-probe.c (stap_parse_register_operand): Adjust use of
2239         'gdbarch_stap_adjust_register'.
2240
2241 2019-07-17  Tom Tromey  <tromey@adacore.com>
2242
2243         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
2244         declare VEC.
2245         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2246         std::vector.
2247         (struct s390_process_info): Add initializers.
2248         (s390_add_process): Use new.
2249         (s390_linux_nat_target::low_forget_process): Use delete.
2250         (s390_linux_nat_target::low_new_fork)
2251         (s390_linux_nat_target::stopped_by_watchpoint)
2252         (s390_linux_nat_target::low_prepare_to_resume)
2253         (s390_linux_nat_target::insert_watchpoint)
2254         (s390_linux_nat_target::insert_hw_breakpoint)
2255         (s390_linux_nat_target::remove_watchpoint)
2256         (s390_linux_nat_target::remove_hw_breakpoint): Update.
2257
2258 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2259
2260         * aarch64-fbsd-nat.c: Include regcache.h.
2261         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2262         argument.
2263         (aarch64_fbsd_nat_target::fetch_registers)
2264         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2265         variable.
2266         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2267
2268 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2269
2270         * fbsd-nat.c: Include gdbarch.h.
2271
2272 2019-07-15  Tom Tromey  <tromey@adacore.com>
2273
2274         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2275
2276 2019-07-15  Tom Tromey  <tromey@adacore.com>
2277
2278         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2279         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2280         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2281         * cli-out.c (cli_ui_out::do_field_int): New method.
2282         * ui-out.c (ui_out::field_unsigned): New method.
2283         * symfile.c (generic_load): Use field_unsigned.
2284         (print_transfer_performance): Likewise.
2285         * record-btrace.c (ui_out_field_uint): Remove.
2286         (btrace_call_history_insn_range, btrace_call_history): Use
2287         field_unsigned.
2288         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2289         field_unsigned.
2290         * ui-out.h (class ui_out) <field_unsigned>: New method.
2291         <do_field_unsigned>: Likewise.
2292
2293 2019-07-15  Tom Tromey  <tromey@adacore.com>
2294
2295         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2296         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2297         * target.c (flash_erase_command): Use field_string.
2298         * infrun.c (print_signal_received_reason): Use field_string.
2299         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2300         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2301         field_string.
2302         * ada-tasks.c (print_ada_task_info): Use field_string.
2303
2304 2019-07-15  Tom Tromey  <tromey@adacore.com>
2305
2306         * target.c (flash_erase_command): Use field_core_addr.
2307         * symfile.c (generic_load): Use field_core_addr.
2308         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2309         Use field_core_addr.
2310         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2311         field_core_addr.
2312
2313 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2314
2315         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2316         value if its desired type is smaller than a CORE_ADDR and signed.
2317
2318 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2319
2320         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2321         of changes to field names, and use new is_reference field to
2322         decide if a property is a reference or not.
2323         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2324         field.
2325         (struct dwarf2_property_baton): Update header comment, rename
2326         'referenced_type' to 'property_type' and update comments.
2327         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2328         default property type, store in property baton, update to take
2329         accound of renamed field.
2330         (read_func_scope): Update call to attr_to_dynamic_prop.
2331         (read_array_type): Likewise.
2332         (dwarf2_per_cu_addr_sized_int_type): New function.
2333         (read_subrange_index_type): Move type finding code to
2334         dwarf2_per_cu_addr_sized_int_type.
2335         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2336         (dwarf2_per_cu_addr_type): New function.
2337         (set_die_type): Update calls to attr_to_dynamic_prop.
2338
2339 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2340
2341         * dwarf2read.c (read_subrange_index_type): New function.
2342         (read_subrange_type): Move code into new function and call it.
2343         * gdbtypes.c (create_range_type): Add some asserts.
2344
2345 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2346
2347         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2348         update return statements.
2349         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2350         declaration, and update comment to match.
2351         * gdbtypes.c (resolve_dynamic_array): Update call to
2352         dwarf2_evaluate_property to match new return type.
2353
2354 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2355
2356         * valarith.c (value_subscripted_rvalue): Change lowerbound
2357         parameter type from int to LONGEST.
2358         * value.h (value_subscripted_rvalue): Likewise in declaration.
2359
2360 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2361
2362         * cli/cli-utils.c (info_print_command_completer): New function.
2363         * cli/cli-utils.h: Add 'completer.h' include, and forward
2364         declaration for 'struct cmd_list_element'.
2365         (info_print_command_completer): Declare.
2366         * stack.c (_initialize_stack): Add completer for 'info locals' and
2367         'info args'.
2368         * symtab.c (_initialize_symtab): Add completer for 'info
2369         variables' and 'info functions'.
2370         * NEWS: Mention completion for additional info commands.
2371
2372 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2373
2374         * cli/cli-utils.c (extract_info_print_args): Delete.
2375         (extract_arg_maybe_quoted): Delete.
2376         (info_print_options_defs): New variable.
2377         (make_info_print_options_def_group): New function.
2378         (extract_info_print_options): Define new function.
2379         * cli/cli-utils.h (extract_info_print_args): Delete.
2380         (struct info_print_options): New structure.
2381         (extract_info_print_options): Declare new function.
2382         * stack.c (info_locals_command): Update to use new
2383         extract_info_print_options, also add a header comment.
2384         (info_args_command): Likewise.
2385         * symtab.c (info_variables_command): Likewise.
2386         (info_functions_command): Likewise.
2387
2388 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2389
2390         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2391         to extract string arguments.
2392         * common/common-utils.c (extract_string_maybe_quoted): New function.
2393         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2394
2395 2019-07-11  Tom Tromey  <tromey@adacore.com>
2396
2397         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2398         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2399         * top.h (gdbinit): Don't declare.
2400         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2401         into...
2402         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2403         * top.c (gdb_init): Don't call init_cli_cmds.
2404         (gdbinit): Remove.
2405         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2406
2407 2019-07-11  Tom Tromey  <tromey@adacore.com>
2408
2409         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2410         after it has been moved.
2411
2412 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2413
2414         * valops.c (value_must_coerce_to_target): Change return type to
2415         bool.
2416         * value.h (value_must_coerce_to_target): Likewise.
2417
2418 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2419
2420         * breakpoint.c (is_hardware_watchpoint): Remove
2421         forward-declaration.
2422         (is_masked_watchpoint): Change return type to bool.
2423         (is_tracepoint): Likewise.
2424         (is_breakpoint): Likewise.
2425         (is_hardware_watchpoint): Likewise.
2426         (is_watchpoint): Likewise.
2427         (is_no_memory_software_watchpoint): Likewise.
2428         (is_catchpoint): Likewise.
2429         (breakpoint_1): Make FILTER parameter's return type bool.
2430         is_masked_watchpoint): Change return type to bool.
2431         (save_breakpoints): Make FILTER parameter's return type bool.
2432         * breakpoint.h (is_breakpoint): Change return type to bool.
2433         (is_watchpoint): Likewise.
2434         (is_catchpoint): Likewise.
2435         (is_tracepoint): Likewise.
2436
2437 2019-07-10  Tom Tromey  <tom@tromey.com>
2438
2439         * defs.h: Don't include gdbarch.h.
2440         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2441         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2442         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2443         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2444         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2445         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2446         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2447         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2448         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2449         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2450         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2451         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2452         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2453         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2454         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2455         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2456         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2457         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2458         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2459         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2460         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2461         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2462         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2463         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2464         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2465         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2466         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2467
2468 2019-07-10  Tom Tromey  <tromey@adacore.com>
2469
2470         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2471         * breakpoint.c (init_ada_exception_breakpoint): Register as
2472         bp_catchpoint.
2473         (print_one_breakpoint_location, print_one_breakpoint): Use
2474         is_ada_exception_catchpoint.
2475         * ada-lang.c (class ada_catchpoint_location): Pass
2476         bp_loc_software_breakpoint to bp_location constructor.
2477         (is_ada_exception_catchpoint): New function.
2478
2479 2019-07-10  Tom Tromey  <tromey@adacore.com>
2480
2481         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2482         VEC.
2483         (struct arm_exidx_entry): New method operator<.
2484         (struct arm_exidx_data) <section_maps>: Change type.
2485         (arm_exidx_data_free): Remove.
2486         (arm_exidx_data_key): Change type.  Move lower.
2487         (arm_exidx_new_objfile): Update.
2488         (arm_compare_exidx_entries): Remove.
2489         (arm_find_exidx_entry, _initialize_arm_tdep)
2490
2491 2019-07-10  Tom Tromey  <tromey@adacore.com>
2492
2493         * solib-spu.c (ocl_program_data_key): Change type.
2494         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2495         Update.
2496
2497 2019-07-10  Tom Tromey  <tromey@adacore.com>
2498
2499         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2500         (struct solib_aix_inferior_data) <library_list>: Change type.
2501         (solib_aix_inferior_data_handle): Change type.
2502         (get_solib_aix_inferior_data): Update.
2503         (solib_aix_free_library_list): Remove.
2504         (library_list_start_library): Update.
2505         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2506         return type.
2507         (solib_aix_get_library_list)
2508         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2509         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2510
2511 2019-07-10  Tom Tromey  <tromey@adacore.com>
2512
2513         * solib-dsbt.c (struct dsbt_info): Add initializers.
2514         (solib_dsbt_pspace_data): Change type.
2515         (dsbt_pspace_data_cleanup): Remove.
2516         (get_dsbt_info, _initialize_dsbt_solib): Update.
2517
2518 2019-07-10  Tom Tromey  <tromey@adacore.com>
2519
2520         * spu-tdep.c (spu_overlay_data): Change type.
2521         (spu_get_overlay_table, spu_overlay_new_objfile)
2522         (_initialize_spu_tdep): Update.
2523
2524 2019-07-10  Tom Tromey  <tromey@adacore.com>
2525
2526         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2527         destructor.
2528         (dbx_objfile_data_key): Change type and declare later.
2529         (DBX_SYMFILE_INFO): Rewrite.
2530         * dbxread.c (dbx_objfile_data_key): Change type.
2531         (dbx_symfile_init): Update.
2532         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2533         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2534         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2535
2536 2019-07-10  Tom Tromey  <tromey@adacore.com>
2537
2538         * jit.c (jit_program_space_key): Change type.  Move lower.
2539         (get_jit_program_space_data): Update.
2540         (jit_program_space_data_cleanup): Remove.
2541         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2542         Update.
2543         (struct jit_program_space_data): Add initializers.
2544
2545 2019-07-10  Tom Tromey  <tromey@adacore.com>
2546
2547         * solib-darwin.c (struct darwin_info): Add initializers.
2548         (solib_darwin_pspace_data): Change type.
2549         (darwin_pspace_data_cleanup): Remove.
2550         (get_darwin_info, _initialize_darwin_solib): Update.
2551
2552 2019-07-10  Tom Tromey  <tromey@adacore.com>
2553
2554         * remote-sim.c (struct sim_inferior_data): Add initializers,
2555         constructor, and destructor.
2556         (sim_inferior_data_key): Change type.  Move lower.
2557         (check_for_duplicate_sim_descriptor): Update.
2558         (get_sim_inferior_data): Use new.  Update.
2559         (~sim_inferior_data_cleanup): Rename from
2560         sim_inferior_data_cleanup.  Simplify.
2561         (gdbsim_close_inferior, simulator_command)
2562         (sim_command_completer, _initialize_remote_sim): Update.
2563         (next_pid, INITIAL_PID): Move earlier.
2564
2565 2019-07-10  Tom Tromey  <tromey@adacore.com>
2566
2567         * python/python-internal.h (create_thread_object): Return
2568         gdbpy_ref.
2569         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2570         * python/py-inferior.c (struct threadlist_entry): Add
2571         constructor.
2572         <thread_obj>: Now a gdbpy_ref.
2573         (thread_to_thread_object): Update.
2574         (add_thread_object): Use new.
2575         (delete_thread_object): Use delete.
2576         (infpy_threads): Update.
2577         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2578         GIL.
2579
2580 2019-07-10  Tom Tromey  <tromey@adacore.com>
2581
2582         * valops.c (value_cast): Specialize error message for Ada.
2583
2584 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2585
2586         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2587
2588 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2589
2590         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2591         bpstat_should_step): Return bool, adjust comments.
2592         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2593         bpstat_should_step): Likewise.
2594
2595 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2596
2597         * features/Makefile: Use feature target descriptions for Arm.
2598         * features/arm/arm-core.c: Generate new file.
2599         * features/arm/arm-fpa.c: Likewise.
2600         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2601         * features/arm/arm-m-profile.c: Likewise.
2602         * features/arm/arm-vfpv2.c: Likewise.
2603         * features/arm/arm-vfpv3.c: Likewise.
2604         * features/arm/xscale-iwmmxt.c: Likewise.
2605         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2606
2607 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2608
2609         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2610         ptrace earlier.
2611
2612 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2613
2614         * features/aarch64-pauth.c: Regenerate.
2615
2616 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2617
2618         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2619         bool.
2620         (bpstat_what): Use false instead of 0.
2621
2622 2019-07-09  Pedro Alves  <palves@redhat.com>
2623
2624         * break-catch-throw.c (is_exception_catchpoint): New.
2625         * breakpoint.c (print_one_breakpoint_location): New parameter
2626         'raw_loc'.  Handle it.  Use
2627         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2628         looking at the breakpoint's type.
2629         (print_one_breakpoint): If handling "maint info breakpoints", also
2630         print locations of exception catchpoints.
2631         * breakpoint.h (is_exception_catchpoint): Declare.
2632
2633 2019-07-09  Pedro Alves  <palves@redhat.com>
2634
2635         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2636         "addr" field.
2637         (allocate_location_exception_catchpoint): New.
2638         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2639         (initialize_throw_catchpoint_ops): Install
2640         allocate_location_exception_catchpoint as allocate_location
2641         method.
2642         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2643         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2644         bp_loc_other.
2645         (breakpoint_address_is_meaningful): Delete.
2646         (bl_address_is_meaningful): New.
2647         (breakpoint_locations_match): Adjust comment.
2648         (bp_location_from_bp_type): New, factored out of...
2649         (bp_location::bp_location(breakpoint *)): ... this.
2650         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2651         factored out of...
2652         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2653         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2654         breakpoint_address_is_meaningful.
2655         (bp_locations_compare): Adjust comment.
2656         (update_global_location_list): Use bl_address_is_meaningful
2657         instead of breakpoint_address_is_meaningful.
2658         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2659         explicit.
2660         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2661         * python/py-breakpoint.c (bppy_get_location): No longer check
2662         whether location is null.
2663
2664 2019-07-09  Pedro Alves  <palves@redhat.com>
2665
2666         PR c++/15468
2667         * breakpoint.c (print_one_breakpoint_location): Remove
2668         single-location assert.
2669
2670 2019-07-09  Tom Tromey  <tom@tromey.com>
2671
2672         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2673         * configure: Rebuild.
2674         * configure.ac: Change common to gdbsupport.
2675         * gdbsupport: Rename from common.
2676         * acinclude.m4: Change common to gdbsupport.
2677         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2678         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2679         gdbsupport.
2680         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2681         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2682         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2683         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2684         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2685         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2686         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2687         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2688         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2689         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2690         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2691         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2692         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2693         coff-pe-read.c, command.h, compile/compile-c-support.c,
2694         compile/compile-c.h, compile/compile-cplus-symbols.c,
2695         compile/compile-cplus-types.c, compile/compile-cplus.h,
2696         compile/compile-loc2c.c, compile/compile.c, completer.c,
2697         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2698         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2699         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2700         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2701         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2702         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2703         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2704         features/aarch64-core.c, features/aarch64-fpu.c,
2705         features/aarch64-pauth.c, features/aarch64-sve.c,
2706         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2707         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2708         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2709         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2710         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2711         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2712         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2713         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2714         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2715         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2716         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2717         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2718         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2719         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2720         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2721         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2722         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2723         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2724         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2725         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2726         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2727         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2728         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2729         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2730         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2731         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2732         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2733         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2734         minsyms.c, mips-linux-tdep.c, namespace.h,
2735         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2736         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2737         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2738         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2739         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2740         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2741         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2742         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2743         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2744         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2745         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2746         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2747         procfs.c, producer.c, progspace.h, psymtab.h,
2748         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2749         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2750         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2751         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2752         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2753         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2754         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2755         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2756         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2757         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2758         target-memory.c, target.c, target.h, target/waitstatus.c,
2759         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2760         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2761         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2762         unittests/array-view-selftests.c,
2763         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2764         unittests/common-utils-selftests.c,
2765         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2766         unittests/format_pieces-selftests.c,
2767         unittests/function-view-selftests.c,
2768         unittests/lookup_name_info-selftests.c,
2769         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2770         unittests/mkdir-recursive-selftests.c,
2771         unittests/observable-selftests.c,
2772         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2773         unittests/parse-connection-spec-selftests.c,
2774         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2775         unittests/scoped_fd-selftests.c,
2776         unittests/scoped_mmap-selftests.c,
2777         unittests/scoped_restore-selftests.c,
2778         unittests/string_view-selftests.c, unittests/style-selftests.c,
2779         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2780         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2781         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2782         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2783         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2784         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2785
2786 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2787
2788         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2789         bool value.
2790         (decode_digits_ordinary): Set explicit_line field in sal.
2791         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2792         symtab_and_line that was set on an explicit line number in
2793         assembler code.  Do always update the recorded symtab and line if
2794         we do skip the prologue.
2795
2796 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2797
2798         * breakpoint.c (set_breakpoint_location_function): Remove
2799         explicit_loc parameter.
2800         (momentary_breakpoint_from_master): Update call to
2801         set_breakpoint_location_function.
2802         (add_location_to_breakpoint): Likewise.
2803
2804 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2805
2806         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2807         required features based on default bfd type when no specific bfd
2808         is present.
2809
2810 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2811
2812         * NEWS: Mention that GDB printf and eval commands can now print
2813         C-style and Ada-style convenience var strings without
2814         calling the inferior.
2815         * printcmd.c (printf_c_string): Locally print GDB internal var
2816         instead of transiting via the inferior.
2817         (printf_wide_c_string): Likewise.
2818
2819 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2820
2821         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2822
2823 2019-07-04  Tom Tromey  <tom@tromey.com>
2824
2825         PR tui/24724:
2826         * tui/tui-winsource.c (tui_clear_source_content): Update.
2827         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2828         (tui_update_breakpoint_info): Update.
2829         (tui_set_exec_info_content): Update.
2830         * tui/tui-source.c (tui_set_source_content_nil): Update.
2831         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2832         has_break.
2833         * tui/tui-data.h (enum tui_bp_flag): New.
2834         (tui_bp_flags): New enum flags type.
2835         (struct tui_source_element) <break_mode>: Change type.  Rename
2836         from has_break.
2837         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2838         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2839         constants.
2840         * tui/tui-winsource.h: Fix comment.
2841
2842 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2843
2844         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2845         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2846         (store_fpregs_to_thread)
2847         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2848         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2849         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2850         (IWMMXT_REGS_SIZE): Add define.
2851         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2852         (fetch_vfp_regs, store_vfp_regs)
2853         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2854         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2855
2856 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2857
2858         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2859         defines.
2860         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2861         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2862         (ARM_INT_REGISTER_SIZE): ...to this.
2863         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2864         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2865         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2866         (arm_linux_collect_gregset, supply_nwfpe_register)
2867         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2868         defines.
2869         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2870         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2871         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2872         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2873         (arm_return_in_memory, arm_store_return_value)
2874         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2875         (arm_record_ld_st_multiple): Likewise.
2876         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2877         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2878
2879 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2880
2881         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2882         AARCH64_DISPLACED_MODIFIED_INSNS.
2883         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2884         (aarch64_displaced_step_copy_insn): Likewise.
2885         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2886         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2887         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2888         ARM_DISPLACED_MODIFIED_INSNS.
2889         * arm-tdep.c (arm_gdbarch_init): Likewise.
2890         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2891         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2892         (struct arm_displaced_step_closure): Use
2893         ARM_DISPLACED_MODIFIED_INSNS.
2894
2895 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2896
2897         * features/Makefile: Remove unused xml files.
2898         * features/aarch64.xml: Remove.
2899         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2900         * features/i386/amd64-avx-avx512.xml: Remove.
2901         * features/i386/amd64-avx-linux.xml: Remove.
2902         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2903         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2904         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2905         * features/i386/amd64-avx-mpx.xml: Remove.
2906         * features/i386/amd64-avx.xml: Remove.
2907         * features/i386/amd64-linux.xml: Remove.
2908         * features/i386/amd64-mpx-linux.xml: Remove.
2909         * features/i386/amd64-mpx.xml: Remove.
2910         * features/i386/amd64.xml: Remove.
2911         * features/i386/i386-avx-avx512-linux.xml: Remove.
2912         * features/i386/i386-avx-avx512.xml: Remove.
2913         * features/i386/i386-avx-linux.xml: Remove.
2914         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2915         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2916         * features/i386/i386-avx-mpx-linux.xml: Remove.
2917         * features/i386/i386-avx-mpx.xml: Remove.
2918         * features/i386/i386-avx.xml: Remove.
2919         * features/i386/i386-linux.xml: Remove.
2920         * features/i386/i386-mmx-linux.xml: Remove.
2921         * features/i386/i386-mmx.xml: Remove.
2922         * features/i386/i386-mpx-linux.xml: Remove.
2923         * features/i386/i386-mpx.xml: Remove.
2924         * features/i386/i386.xml: Remove.
2925         * features/i386/x32-avx-avx512-linux.xml: Remove.
2926         * features/i386/x32-avx-linux.xml: Remove.
2927         * features/i386/x32-linux.xml: Remove.
2928
2929 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2930
2931         * regformats/aarch64.dat: Remove.
2932         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2933         * regformats/i386/amd64-avx-linux.dat: Remove.
2934         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2935         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2936         * regformats/i386/amd64-linux.dat: Remove.
2937         * regformats/i386/amd64-mpx-linux.dat: Remove.
2938         * regformats/i386/amd64.dat: Remove.
2939         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2940         * regformats/i386/i386-avx-linux.dat: Remove.
2941         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2942         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2943         * regformats/i386/i386-linux.dat: Remove.
2944         * regformats/i386/i386-mmx-linux.dat: Remove.
2945         * regformats/i386/i386-mpx-linux.dat: Remove.
2946         * regformats/i386/i386.dat: Remove.
2947         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2948         * regformats/i386/x32-avx-linux.dat: Remove.
2949         * regformats/i386/x32-linux.dat: Remove.
2950
2951 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2952
2953         * aarch64-tdep.c: Remove xml self tests.
2954         * amd64-linux-tdep.c: Likewise.
2955         * amd64-tdep.c: Likewise.
2956         * i386-linux-tdep.c: Likewise.
2957         * i386-tdep.c: Likewise.
2958
2959 2019-07-03  Pedro Alves  <palves@redhat.com>
2960
2961         PR cli/24732
2962         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2963         (pipe_cmd_option_defs): New.
2964         (make_pipe_cmd_options_def_group): New.
2965         (pipe_command): Use gdb::option::process_options.
2966         (pipe_command_completer): New function.
2967         (_initialize_cli_cmds): Install completer for "pipe" command.
2968
2969 2019-07-03  Pedro Alves  <palves@redhat.com>
2970
2971         * cli/cli-option.c (union option_value) <string>: New field.
2972         (struct option_def_and_value): Add ctor, move ctor, dtor and
2973         use DISABLE_COPY_AND_ASSIGN.
2974         (option_def_and_value::clear_value): New.
2975         (parse_option, save_option_value_in_ctx, get_val_type_str)
2976         (add_setshow_cmds_for_options): Handle var_string.
2977         * cli-option.h (union option_def::var_address) <string>: New
2978         field.
2979         (struct string_option_def): New.
2980         * maint-test-options.c (struct test_options_opts): Add default
2981         ctor and use DISABLE_COPY_AND_ASSIGN.
2982         <string_opt>: New field.
2983         (test_options_opts::~test_options_opts): New.
2984         (test_options_opts::dump): Also dump "-string".
2985         (test_options_option_defs): Install "string.
2986
2987 2019-07-03  Pedro Alves  <palves@redhat.com>
2988
2989         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2990         option_value with a null enumeration.
2991         (complete_options): Save the option values in the context.
2992         (save_option_value_in_ctx): New, factored out from ...
2993         (process_options): ... here.
2994         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2995         of the function.
2996         * maint-test-options.c (test_options_opts::dump): New, factored
2997         out from ...
2998         (maintenance_test_options_command_mode): ... here.
2999         (maintenance_test_options_command_completion_result): Delete.
3000         (maintenance_test_options_command_completion_text): Update
3001         comment.
3002         (maintenance_show_test_options_completion_result): Change
3003         prototype.  Just print
3004         maintenance_test_options_command_completion_text.
3005         (save_completion_result): New.
3006         (maintenance_test_options_completer_mode): Pass options context to
3007         complete_options, and then save a dump.
3008         (_initialize_maint_test_options): Use add_cmd to install "maint
3009         show test-options-completion-result".
3010
3011 2019-07-03  Pedro Alves  <palves@redhat.com>
3012
3013         * NEWS (New commands): Mention "with" and "maint with".
3014         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
3015         (with_command, with_command_completer): New.
3016         (pipe_command): Adjust to new repeat_previous
3017         interface.
3018         (_initialize_cli_cmds): Install the "with" command and its "w"
3019         alias.
3020         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
3021         declarations.
3022         * cli/cli-setshow.c (parse_cli_var_uinteger)
3023         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
3024         argument strings for all var_types.
3025         (get_setshow_command_value_string): New, factored out from ...
3026         (do_show_command): ... this.
3027         * cli/cli-setshow.h: Include <string>.
3028         (get_setshow_command_value_string): Declare.
3029         * command.h (repeat_previous): Now returns const char *.  Adjust
3030         comment.
3031         * maint.c: Include "cli/cli-cmds.h".
3032         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3033         (_initialize_maint_cmds): Register the "maintenance with" command.
3034         * top.c (repeat_previous): Move bits from pipe_command here:
3035         Return the saved command line, if any; error out if there's no
3036         command to relaunch.
3037
3038 2019-07-03  Pedro Alves  <palves@redhat.com>
3039
3040         * NEWS (New commands): Mention "maint set/show test-settings"
3041         instead of "maint test-settings".
3042         * maint-test-settings.c (maintenance_test_settings_list): Delete.
3043         (maintenance_test_settings_set_list): Rename to ...
3044         (maintenance_set_test_settings_list): ... this.
3045         (maintenance_test_settings_show_list): Rename to  ...
3046         (maintenance_show_test_settings_list): ... this.
3047         (maintenance_test_settings_cmd): Delete.
3048         (maintenance_test_settings_set_cmd): ...
3049         (maintenance_set_test_settings_cmd): ... this.
3050         (maintenance_test_settings_show_cmd): ...
3051         (maintenance_show_test_settings_cmd): ... this.
3052         (maintenance_test_settings_show_value_cmd):
3053         (maintenance_show_test_settings_value_cmd): ... this.
3054         (_initialize_maint_test_settings): No longer install the "maint
3055         test-settings" prefix command.  Rename "maint test-settings set"
3056         to "maint set test-settings", and "maint test-settings show" to
3057         "maint show test-settings".  Adjust all subcommands.
3058
3059 2019-07-03  Pedro Alves  <palves@redhat.com>
3060
3061         * maint-test-settings.c: Fix file's intro comment.  Replace all
3062         references to "test-options" with references to "test-settings",
3063         in comments.
3064
3065 2019-07-03  Pedro Alves  <palves@redhat.com>
3066
3067         * maint-test-settings.c (maintenance_test_settings_xxx)
3068         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3069         New.
3070         (maintenance_test_settings_enums): Use them.
3071         (maintenance_test_settings_enum): Default to
3072         maintenance_test_settings_xxx.
3073         (_initialize_maint_test_settings): Initialize
3074         MAINTENANCE_TEST_SETTINGS_FILENAME.
3075
3076 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3077
3078         * breakpoint.h (remove_breakpoints_inf): Change return type to
3079         void, move function documentation here.
3080         * breakpoint.c (remove_breakpoints_inf): Change return type to
3081         void, move function documentation to header.
3082
3083 2019-07-02  Pedro Alves  <palves@redhat.com>
3084
3085         * NEWS (Completion improvements): Mention "info threads".
3086         * thread.c (struct info_threads_opts, info_threads_option_defs)
3087         (make_info_threads_options_def_group): New.
3088         (info_threads_command): Use gdb::option::process_options.
3089         (info_threads_command_completer): New.
3090         (_initialize_thread): Use gdb::option::build_help to build the
3091         help text for "info threads".
3092
3093 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3094
3095         * defs.h (generic_load): Move from here...
3096         * symfile.h (generic_load): ... to here.  Rename name parameter
3097         to args.
3098         * symfile.c (generic_load): Add comment.
3099
3100 2019-07-01  Tom Tromey  <tromey@adacore.com>
3101
3102         * dwarf2read.c
3103         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3104         declaration of without_params.  Fix formatting.
3105
3106 2019-07-01  Tom Tromey  <tromey@adacore.com>
3107
3108         * ada-exp.y (find_primitive_type): Update.
3109         * ada-lang.h (ada_lookup_symbol): Update.
3110         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3111         parameter.
3112         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3113
3114 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3115
3116         PR breakpoints/24541
3117         * gdbarch.c: Regenerate.
3118         * gdbarch.h: Regenerate.
3119         * gdbarch.sh: Add 'stap_adjust_register'.
3120         * i386-tdep.c: Include '<unordered_set>'.
3121         (i386_stap_adjust_register): New function.
3122         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3123         * stap-probe.c (stap_parse_register_operand): Call
3124         'gdbarch_stap_adjust_register'.
3125
3126 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3127
3128         PR python/24742
3129         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3130         * python/python.c (do_start_initialization): Use 'xmalloc'
3131         instead of 'PyMem_Malloc'.
3132
3133 2019-06-28  Tom Tromey  <tromey@adacore.com>
3134
3135         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3136         for Ada.
3137
3138 2019-06-27  Tom Tromey  <tromey@adacore.com>
3139
3140         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
3141         objfile_key.
3142         (arm_find_mapping_symbol, arm_record_special_symbol)
3143         (_initialize_arm_tdep): Update.
3144         (arm_objfile_data_free): Remove.
3145
3146 2019-06-27  Tom Tromey  <tromey@adacore.com>
3147
3148         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3149         to cp_print_static_field.
3150
3151 2019-06-26  Tom Tromey  <tromey@adacore.com>
3152
3153         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3154         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3155         declare.
3156
3157 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3158
3159         * features/aarch64-core.c (create_feature_aarch64_core):
3160         Regenerate.
3161         * features/aarch64-core.xml: Add cpsr flags.
3162
3163 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3164
3165         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3166         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3167
3168 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3169
3170         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3171         field.
3172         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3173         use.
3174         (arm_record_special_symbol): Don't insert new symbol in sorted
3175         position, push it at the end.
3176
3177 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3178
3179         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3180         (arm_mapping_symbol_s): Remove.
3181         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3182         (arm_mapping_symbol_vec): New typedef.
3183         (struct arm_per_objfile): Add constructor.
3184         <section_maps>: Change type to
3185         std::unique_ptr<arm_mapping_symbol_vec[]>.
3186         (arm_compare_mapping_symbols): Remove.
3187         (arm_find_mapping_symbol): Adjust to section_maps type change.
3188         (arm_objfile_data_free): Call delete on arm_per_objfile.
3189         (arm_record_special_symbol): Adjust to section_maps type change.
3190         Allocate arm_per_objfile with new.
3191
3192 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3193
3194         * cli/cli-cmds.c (alias_command): Compare the alias prefix
3195         with the command prefix.
3196
3197 2019-06-25  Tom Tromey  <tom@tromey.com>
3198
3199         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3200         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3201
3202 2019-06-25  Tom Tromey  <tom@tromey.com>
3203
3204         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3205         type.
3206         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3207         protected.
3208
3209 2019-06-25  Tom Tromey  <tom@tromey.com>
3210
3211         * tui/tui-winsource.c
3212         (tui_source_window_base::set_is_exec_point_at): Add check against
3213         LOA_ADDRESS.
3214
3215 2019-06-25  Tom Tromey  <tom@tromey.com>
3216
3217         * tui/tui-source.c (tui_set_source_content): Don't check before
3218         xfree.
3219         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3220
3221 2019-06-25  Tom Tromey  <tom@tromey.com>
3222
3223         * tui/tui-winsource.h (tui_update_source_window_as_is)
3224         (tui_alloc_source_buffer, tui_line_is_displayed)
3225         (tui_addr_is_displayed): Change type of win_info.
3226         * tui/tui-winsource.c (tui_update_source_window_as_is)
3227         (tui_clear_source_content, tui_show_source_line)
3228         (tui_show_source_content, tui_source_window_base::refill)
3229         (tui_source_window_base::set_is_exec_point_at)
3230         (tui_source_window_base::set_is_exec_point_at)
3231         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3232         (tui_alloc_source_buffer, tui_line_is_displayed)
3233         (tui_addr_is_displayed): Change type of win_info.  Update.
3234         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3235         (tui_source_window_base::do_make_visible_with_new_height):
3236         Update.
3237         * tui/tui-source.c (tui_set_source_content)
3238         (tui_set_source_content_nil)
3239         (tui_source_window::do_scroll_vertical): Update.
3240         * tui/tui-layout.c (show_layout): Update.
3241         * tui/tui-disasm.c (tui_set_disassem_content)
3242         (tui_disasm_window::do_scroll_vertical): Update.
3243         * tui/tui-data.h (tui_win_content): Remove.
3244         (struct tui_gen_win_info) <content, content_size>: Remove.
3245         (struct tui_source_element): Add initializers and destructor.
3246         (union tui_which_element, struct tui_win_element): Remove.
3247         (struct tui_source_window_base) <content>: New field.
3248         (struct tui_data_window): Remove destructor.
3249         (tui_alloc_content, tui_free_win_content)
3250         (tui_free_all_source_wins_content): Don't declare.
3251         * tui/tui-data.c (tui_initialize_static_data): Update.
3252         (init_content_element, tui_alloc_content): Remove.
3253         (~tui_gen_win_info): Update.
3254         (~tui_data_window, tui_free_all_source_wins_content)
3255         (tui_free_win_content, free_content, free_content_elements):
3256         Remove.
3257
3258 2019-06-25  Tom Tromey  <tom@tromey.com>
3259
3260         * tui/tui-winsource.h (tui_clear_source_content)
3261         (tui_erase_source_content, tui_show_source_content): Change type
3262         of win_info.
3263         * tui/tui-winsource.c (tui_clear_source_content)
3264         (tui_erase_source_content, tui_show_source_content): Change type
3265         of win_info.
3266         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3267         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3268         win_info.
3269         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3270         win_info.
3271         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3272
3273 2019-06-25  Tom Tromey  <tom@tromey.com>
3274
3275         * tui/tui-winsource.c (tui_clear_source_content)
3276         (tui_source_window_base::set_is_exec_point_at): Update.
3277         * tui/tui-source.c (tui_set_source_content_nil): Update.
3278         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3279         a bool.
3280         * tui/tui-data.c (init_content_element): Update.
3281
3282 2019-06-25  Tom Tromey  <tom@tromey.com>
3283
3284         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3285         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3286         * tui/tui-layout.c (init_and_make_win): Update.
3287         * tui/tui.h (enum tui_win_type): Update.
3288         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3289         tui_win_is_auxillary.
3290         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3291         tui_win_is_auxillary.
3292
3293 2019-06-25  Tom Tromey  <tom@tromey.com>
3294
3295         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3296         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3297         (tui_delete_data_content_windows, tui_display_all_data)
3298         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3299         Update.
3300         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3301         * tui/tui-regs.c (tui_last_regs_line_no)
3302         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3303         (tui_show_registers): Update.
3304         (tui_show_register_group): Return void.  Update.
3305         (tui_display_registers_from, tui_display_reg_element_at_line)
3306         (tui_display_registers_from_line, tui_check_register_values):
3307         Update.
3308         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3309         member.
3310         (struct tui_data_window) <regs_content>: Now a std::vector.
3311         <regs_content_count>: Remove.
3312         (tui_add_content_elements, tui_free_data_content): Don't declare.
3313         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3314         (init_content_element): Remove DATA_WIN case.  Add assert.
3315         (tui_add_content_elements): Remove.
3316         (tui_data_window): Update.
3317         (tui_free_data_content): Remove.
3318         (free_content_elements): Remove DATA_WIN case.
3319
3320 2019-06-25  Tom Tromey  <tom@tromey.com>
3321
3322         * tui/tui-data.c (tui_data_item_window): Update.
3323         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3324         * tui/tui-windata.c (tui_display_all_data)
3325         (tui_display_data_from_line): Update.
3326         (tui_check_data_values): Remove.
3327         * tui/tui-regs.c (tui_show_register_group)
3328         (tui_display_reg_element_at_line): Update.
3329         * tui/tui-hooks.c (tui_register_changed)
3330         (tui_refresh_frame_and_register_information): Call
3331         tui_check_register_values.
3332         * tui/tui-data.h (struct tui_data_window) <data_content,
3333         data_content_count, data_type>: Remove.
3334         (enum tui_data_type): Remove.
3335
3336         * tui/tui-data.c (tui_data_window::clear_detail)
3337         (~tui_data_window): Update.
3338
3339 2019-06-25  Tom Tromey  <tom@tromey.com>
3340
3341         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3342         declare.
3343         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3344         Rename from tui_first_data_item_displayed.  Update.
3345         (tui_data_window::refresh_all)
3346         (tui_data_window::do_scroll_vertical): Update.
3347         * tui/tui-data.h (struct tui_data_window)
3348         <first_data_item_displayed>: Declare new method.
3349
3350 2019-06-25  Tom Tromey  <tom@tromey.com>
3351
3352         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3353         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3354         contents...
3355         (tui_initialize_static_data): ...here.
3356
3357 2019-06-25  Tom Tromey  <tom@tromey.com>
3358
3359         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3360         (tui_display_registers_from, tui_check_register_values): Update.
3361         (tui_display_register): Remove win_info parameter; update.
3362         (tui_get_register): Change type of parameters.
3363         * tui/tui-data.h (struct tui_data_element): Remove.
3364         (union tui_which_element) <data>: Remove.
3365         <data_window>: Change type.
3366         (struct tui_data_item_window): New.
3367         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3368         case.  Add assert.
3369         (~tui_data_item_window): New destructor.
3370         (free_content_elements): Remove DATA_ITEM_WIN case.
3371
3372 2019-06-25  Tom Tromey  <tom@tromey.com>
3373
3374         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3375         Remove.
3376
3377 2019-06-25  Tom Tromey  <tom@tromey.com>
3378
3379         * tui/tui-data.h (struct tui_command_element): Remove.
3380         (union tui_which_element) <command>: Remove.
3381         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3382         assert.
3383         (free_content_elements): Remove CMD_WIN case.
3384
3385 2019-06-25  Tom Tromey  <tom@tromey.com>
3386
3387         * tui/tui-layout.c (tui_set_layout): Update.
3388         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3389         * tui/tui-data.c (layout_def): Update.
3390
3391 2019-06-25  Tom Tromey  <tom@tromey.com>
3392
3393         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3394         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3395         (tui_source_window_base::set_new_height): Update.
3396         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3397         Update.
3398         (tui_set_locator_fullname, tui_set_locator_info)
3399         (tui_show_frame_info): Update.
3400         * tui/tui-source.c (tui_set_source_content)
3401         (tui_source_is_displayed): Update.
3402         * tui/tui-layout.c (show_source_disasm_command, show_data)
3403         (show_source_or_disasm_and_command): Update.
3404         * tui/tui-disasm.c (tui_set_disassem_content)
3405         (tui_get_begin_asm_address): Update.
3406         * tui/tui-data.h (struct tui_locator_element): Remove.
3407         (union tui_which_element) <locator>: Remove.
3408         (struct tui_locator_window): New.
3409         (tui_locator_win_info_ptr): Change return type.
3410         * tui/tui-data.c (_locator): Change type.
3411         (tui_locator_win_info_ptr): Change return type.
3412         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3413         (tui_alloc_content): Add assert.
3414
3415 2019-06-25  Tom Tromey  <tom@tromey.com>
3416
3417         * tui/tui-winsource.c
3418         (tui_exec_info_window::maybe_allocate_content): New method.
3419         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3420         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3421         (make_source_or_disasm_window): Add cast.
3422         * tui/tui-data.h (union tui_which_element) <simple_string>:
3423         Remove.
3424         (struct tui_source_info): New.
3425         (struct tui_source_window_base) <execution_info>: Change type.
3426         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3427         case, and add assert.
3428         (tui_alloc_content): Add assert.
3429
3430 2019-06-25  Tom Tromey  <tom@tromey.com>
3431
3432         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3433         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3434         * tui/tui-data.c (tui_alloc_win_info): Remove.
3435
3436 2019-06-25  Tom Tromey  <tom@tromey.com>
3437
3438         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3439         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3440         can_highlight.
3441
3442 2019-06-25  Tom Tromey  <tom@tromey.com>
3443
3444         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3445         make_visible_with_new_height method.
3446         (tui_win_info::make_visible_with_new_height): New method.
3447         (tui_source_window_base::do_make_visible_with_new_height)
3448         (tui_data_window::do_make_visible_with_new_height)
3449         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3450         (make_visible_with_new_height): Remove.
3451         (tui_resize_all, tui_adjust_win_heights): Use
3452         make_visible_with_new_height method.
3453         * tui/tui-data.h (struct tui_win_info)
3454         <do_make_visible_with_new_height, make_visible_with_new_height>:
3455         New methods.
3456         (struct tui_source_window_base, struct tui_data_window)
3457         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3458         methods.
3459
3460 2019-06-25  Tom Tromey  <tom@tromey.com>
3461
3462         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3463         method.
3464         (update_tab_width): Call update_tab_width method.
3465         * tui/tui-data.h (struct tui_win_info)
3466         (struct tui_source_window_base) <update_tab_width>: New methods.
3467
3468 2019-06-25  Tom Tromey  <tom@tromey.com>
3469
3470         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3471         parameter.
3472         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3473         parameter.
3474         (tui_gen_win_info::make_visible): Update.
3475         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3476         parameter.
3477         * tui/tui-data.h (enum tui_box): New enum.
3478         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3479
3480 2019-06-25  Tom Tromey  <tom@tromey.com>
3481
3482         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3483         init_and_make_win for EXEC_INFO_WIN.
3484         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3485         longer inline.
3486         (struct tui_win_info) <~tui_win_info>: Inline.
3487         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3488         Don't declare.
3489         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3490         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3491         Remove.
3492         (tui_initialize_static_data): Update.
3493         (~tui_gen_win_info): Handle more cleanup here.
3494         (~tui_source_window_base): Delete "execution_info".
3495         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3496
3497 2019-06-25  Tom Tromey  <tom@tromey.com>
3498
3499         * tui/tui-layout.c (make_command_window): Don't set
3500         can_highlight.
3501         (show_source_disasm_command): Call the reset method.
3502         (show_data): Don't set can_highlight.  Call the reset method.
3503         (tui_gen_win_info::reset): Rename from init_gen_win_info
3504         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3505         (show_source_or_disasm_and_command): Call the reset method.
3506         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3507         (struct tui_cmd_window): Set can_highlight.
3508
3509 2019-06-25  Tom Tromey  <tom@tromey.com>
3510
3511         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3512         from make_visible.
3513         (tui_make_visible, tui_make_invisible): Rewrite.
3514         (tui_win_info::make_visible): Remove.
3515         (tui_source_window_base::make_visible): Update.
3516         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3517         method.  Moved from...
3518         (struct tui_win_info) <make_visible>: ...here.
3519
3520 2019-06-25  Tom Tromey  <tom@tromey.com>
3521
3522         * tui/tui-winsource.c
3523         (tui_source_window_base::do_scroll_horizontal): Remove direction
3524         parameter.
3525         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3526         direction parameter.
3527         * tui/tui-win.c (tui_win_info::forward_scroll)
3528         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3529         (tui_win_info::right_scroll): Update.
3530         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3531         direction parameter.
3532         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3533         direction parameter.
3534         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3535         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3536         Remove direction parameter.
3537         (struct tui_source_window_base, struct tui_source_window)
3538         (struct tui_disasm_window, struct tui_data_window)
3539         (struct tui_cmd_window): Update.
3540
3541 2019-06-25  Tom Tromey  <tom@tromey.com>
3542
3543         * tui/tui-winsource.h (tui_set_exec_info_content)
3544         (tui_show_exec_info_content, tui_erase_exec_info_content)
3545         (tui_clear_exec_info_content, tui_update_exec_info): Change
3546         argument to tui_source_window_base.
3547         * tui/tui-winsource.c (tui_set_exec_info_content)
3548         (tui_show_exec_info_content, tui_erase_exec_info_content)
3549         (tui_clear_exec_info_content, tui_update_exec_info): Change
3550         argument to tui_source_window_base.
3551
3552 2019-06-25  Tom Tromey  <tom@tromey.com>
3553
3554         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3555         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3556
3557 2019-06-25  Tom Tromey  <tom@tromey.com>
3558
3559         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3560         check.
3561
3562 2019-06-25  Tom Tromey  <tom@tromey.com>
3563
3564         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3565         type to void.
3566         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3567         type to void.
3568         * tui/tui-source.c (tui_set_source_content): Update.
3569         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3570
3571 2019-06-25  Tom Tromey  <tom@tromey.com>
3572
3573         * tui/tui-win.c (window_name_completer, tui_set_focus)
3574         (tui_all_windows_info): Use name method.
3575         * tui/tui-data.h (struct tui_gen_win_info)
3576         (struct tui_source_window, struct tui_disasm_window)
3577         (struct tui_data_window, struct tui_cmd_window) <name>: New
3578         method.
3579         (tui_win_name): Don't declare.
3580         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3581         (tui_win_name): Remove.
3582
3583 2019-06-25  Tom Tromey  <tom@tromey.com>
3584
3585         * tui/tui-winsource.h (tui_update_source_window)
3586         (tui_update_source_window_as_is): Change parameter type.
3587         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3588         to be a tui_source_window_base.
3589         (tui_update_source_window_as_is): Likewise.
3590         * tui/tui-win.c (make_visible_with_new_height): Update.
3591
3592 2019-06-25  Tom Tromey  <tom@tromey.com>
3593
3594         * tui/tui-winsource.c (tui_erase_source_content)
3595         (tui_show_source_content, tui_show_exec_info_content)
3596         (tui_erase_exec_info_content): Use refresh_window method.
3597         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3598         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3599         from tui_refresh_win.
3600         (tui_data_window::refresh_window): New method.
3601         (tui_win_info::refresh, tui_source_window_base::refresh)
3602         (tui_refresh_all): Use refresh_window method.
3603         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3604         method.
3605         * tui/tui-regs.c (tui_display_register): Call refresh_window
3606         method.
3607         * tui/tui-layout.c (show_source_disasm_command)
3608         (show_source_or_disasm_and_command): Call refresh_window method.
3609         * tui/tui-data.h (struct tui_gen_win_info)
3610         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3611         New method.
3612
3613 2019-06-25  Tom Tromey  <tom@tromey.com>
3614
3615         * tui/tui.c (tui_rl_other_window, tui_enable)
3616         (tui_is_window_visible, tui_get_command_dimension): Update.
3617         * tui/tui-winsource.c (tui_update_source_window_as_is)
3618         (tui_clear_source_content, tui_erase_source_content)
3619         (tui_show_source_line, tui_source_window_base::refill)
3620         (tui_source_window_base::do_scroll_horizontal)
3621         (tui_source_window_base::set_is_exec_point_at)
3622         (tui_update_breakpoint_info, tui_set_exec_info_content)
3623         (tui_alloc_source_buffer, tui_line_is_displayed)
3624         (tui_addr_is_displayed): Update.
3625         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3626         (tui_check_and_display_highlight_if_needed)
3627         (tui_win_info::make_visible, tui_win_info::refresh)
3628         (tui_refresh_all): Update.
3629         * tui/tui-windata.c (tui_first_data_item_displayed)
3630         (tui_delete_data_content_windows, tui_erase_data_content)
3631         (tui_display_all_data, tui_data_window::refresh_all)
3632         (tui_check_data_values): Update.
3633         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3634         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3635         (tui_win_info::backward_scroll, tui_refresh_all_win)
3636         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3637         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3638         (tui_source_window_base::set_new_height)
3639         (tui_data_window::set_new_height)
3640         (make_invisible_and_set_new_height)
3641         (make_visible_with_new_height, new_height_ok)
3642         (parse_scrolling_args): Update.
3643         * tui/tui-stack.c (tui_show_frame_info): Update.
3644         * tui/tui-source.c (tui_set_source_content)
3645         (tui_set_source_content_nil, tui_source_is_displayed)
3646         (tui_source_window::do_scroll_vertical): Update.
3647         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3648         (tui_display_registers_from, tui_display_reg_element_at_line)
3649         (tui_check_register_values, tui_reg_command): Update.
3650         * tui/tui-layout.c (tui_default_win_height)
3651         (show_source_disasm_command, show_data, init_and_make_win)
3652         (show_source_or_disasm_and_command): Update.
3653         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3654         (tui_redisplay_readline, tui_mld_flush)
3655         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3656         (tui_getc): Update.
3657         * tui/tui-disasm.c (tui_set_disassem_content)
3658         (tui_disasm_window::do_scroll_vertical): Update.
3659         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3660         Now virtual.
3661         (struct tui_win_info): Derive from tui_gen_win_info.
3662         <~tui_win_info>: Mark as override.
3663         <generic>: Remove member.
3664         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3665         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3666         (~tui_data_window, ~tui_win_info)
3667         (tui_free_all_source_wins_content): Update.
3668         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3669
3670 2019-06-25  Tom Tromey  <tom@tromey.com>
3671
3672         * tui/tui-layout.c (init_and_make_win): Use new.
3673         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3674         destructor, initializers.
3675         (tui_alloc_generic_win_info): Don't declare.
3676         * tui/tui-data.c (_locator): Add argument to constructor.
3677         (source_win, disasm_win): New globals.
3678         (exec_info): Remove.
3679         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3680         Update.
3681         (tui_alloc_generic_win_info): Remove.
3682         (init_content_element): Use new.
3683         (tui_win_info::tui_win_info): Update.
3684         (free_content_elements) <case DATA_WIN>: Use delete.
3685
3686 2019-06-25  Tom Tromey  <tom@tromey.com>
3687
3688         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3689         * tui/tui-windata.c (tui_first_data_item_displayed)
3690         (tui_delete_data_content_windows): Update.
3691         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3692         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3693         (tui_display_registers_from, tui_check_register_values): Update.
3694         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3695         pointer.
3696         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3697         window.
3698         (tui_free_data_content): Update.
3699         (free_content_elements) <case DATA_WIN>: Free the window.
3700
3701 2019-06-25  Tom Tromey  <tom@tromey.com>
3702
3703         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3704         Update.
3705         * tui/tui-layout.c (make_command_window)
3706         (show_source_disasm_command, show_data, init_and_make_win)
3707         (show_source_or_disasm_and_command): Update.
3708         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3709         method.
3710         <can_highight, is_highlighted>: Now bool.
3711         (tui_set_win_highlight): Don't declare.
3712         * tui/tui-data.c (tui_set_win_highlight): Remove.
3713
3714 2019-06-25  Tom Tromey  <tom@tromey.com>
3715
3716         * tui/tui-wingeneral.c (make_visible): Remove check of window
3717         type.
3718
3719 2019-06-25  Tom Tromey  <tom@tromey.com>
3720
3721         * tui/tui-win.c (tui_win_info::max_height)
3722         (tui_cmd_window::max_height): New methods.
3723         (new_height_ok): Call max_height.
3724         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3725         <max_height>: New method.
3726
3727 2019-06-25  Tom Tromey  <tom@tromey.com>
3728
3729         * tui/tui-win.c (tui_source_window_base::set_new_height)
3730         (tui_data_window::set_new_height): New methods.
3731         (make_invisible_and_set_new_height): Call set_new_height method.
3732         * tui/tui-data.h (struct tui_win_info)
3733         (struct tui_source_window_base, struct tui_data_window)
3734         <set_new_height>: New method.
3735
3736 2019-06-25  Tom Tromey  <tom@tromey.com>
3737
3738         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3739         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3740         tui_refresh_data_win.
3741         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3742         method.
3743         (tui_refresh_all_win): Call the refresh_all method.
3744         (tui_set_focus): Likewise.
3745         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3746         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3747         Likewise.
3748
3749 2019-06-25  Tom Tromey  <tom@tromey.com>
3750
3751         * tui/tui-winsource.h (tui_refill_source_window)
3752         (tui_set_is_exec_point_at): Don't declare.
3753         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3754         (tui_source_window_base::refill): Rename from
3755         tui_refill_source_window.
3756         (tui_source_window_base::do_scroll_horizontal): Update.
3757         (tui_source_window_base::set_is_exec_point_at): Rename from
3758         tui_set_is_exec_point_at.
3759         (tui_update_all_breakpoint_info): Update.
3760         * tui/tui-stack.c (tui_show_frame_info): Update.
3761         * tui/tui-layout.c (show_data): Add cast.
3762         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3763         * tui/tui-data.h (struct tui_source_window_base) <refill,
3764         set_is_exec_point_at>: New methods.
3765         (tui_source_windows, tui_add_to_source_windows): Update types.
3766         (tui_add_to_source_windows): Remove redundant declaration.
3767         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3768         (tui_source_windows): Change return type.
3769         (tui_clear_source_windows_detail): Update.
3770         (tui_add_to_source_windows): Change type of parameter.
3771         (tui_free_all_source_wins_content): Update.
3772
3773 2019-06-25  Tom Tromey  <tom@tromey.com>
3774
3775         * tui/tui-wingeneral.c (tui_win_info::refresh)
3776         (tui_source_window_base::refresh): New methods.
3777         (tui_refresh_all): Call the refresh method.
3778         * tui/tui-data.h (struct tui_win_info)
3779         (struct tui_source_window_base) <refresh>: New method.
3780
3781 2019-06-25  Tom Tromey  <tom@tromey.com>
3782
3783         * tui/tui.h (tui_is_window_visible): Return bool.
3784         * tui/tui.c (tui_is_window_visible): Return bool.
3785         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3786         (tui_make_visible, tui_make_invisible)
3787         (tui_win_info::make_visible)
3788         (tui_source_window_base::make_visible, make_all_visible)
3789         (tui_make_all_visible, tui_make_all_invisible): Update.
3790         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3791         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3792         bool.
3793         (struct tui_win_info, struct tui_source_window_base)
3794         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3795         * tui/tui-data.c (tui_init_generic_part): Update.
3796
3797 2019-06-25  Tom Tromey  <tom@tromey.com>
3798
3799         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3800         (tui_source_window_base::make_visible): New methods.
3801         (make_all_visible): Make method call.
3802         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3803         (struct tui_source_window_base, struct tui_cmd_window): Override
3804         make_visible.
3805         (tui_win_is_source_type): Don't declare.
3806         * tui/tui-data.c (tui_win_is_source_type): Remove.
3807
3808 2019-06-25  Tom Tromey  <tom@tromey.com>
3809
3810         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3811         NULL check.
3812
3813 2019-06-25  Tom Tromey  <tom@tromey.com>
3814
3815         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3816         Inline constructor.  Add initializers for members.
3817         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3818         constructors; now inline in class.
3819
3820 2019-06-25  Tom Tromey  <tom@tromey.com>
3821
3822         * tui/tui-regs.c (tui_show_registers): Update.
3823         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3824         bool.
3825         * tui/tui-data.c (tui_data_window::clear_detail)
3826         (tui_data_window): Update.
3827
3828 2019-06-25  Tom Tromey  <tom@tromey.com>
3829
3830         * tui/tui-windata.c (tui_display_all_data)
3831         (tui_display_data_from_line, tui_display_data_from)
3832         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3833         Update.
3834         * tui/tui-regs.c (tui_last_regs_line_no)
3835         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3836         (tui_show_registers, tui_show_register_group)
3837         (tui_display_registers_from, tui_display_reg_element_at_line)
3838         (tui_display_registers_from_line, tui_check_register_values)
3839         (tui_reg_next, tui_reg_prev): Update.
3840         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3841         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3842         tui_data_window.
3843         (struct tui_win_info) <detail>: Remove.  Add new fields from
3844         tui_data_info.
3845         (TUI_DATA_WIN): Add cast.
3846         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3847         (~tui_data_window): Simplify.
3848
3849 2019-06-25  Tom Tromey  <tom@tromey.com>
3850
3851         * tui/tui-layout.c (show_source_disasm_command)
3852         (show_source_or_disasm_and_command): Update.
3853         * tui/tui-io.c (update_cmdwin_start_line)
3854         (tui_redisplay_readline): Update.
3855         * tui/tui-data.h (struct tui_command_info): Remove.
3856         (struct tui_win_info) <detail>: Remove command_info member.
3857         (struct tui_data_window) <start_line>: New member, from
3858         tui_command_info.
3859         (TUI_CMD_WIN): Add casts.
3860
3861 2019-06-25  Tom Tromey  <tom@tromey.com>
3862
3863         * tui/tui-winsource.c (tui_update_source_window)
3864         (tui_refill_source_window)
3865         (tui_source_window_base::do_scroll_horizontal)
3866         (tui_update_breakpoint_info, tui_set_exec_info_content)
3867         (tui_show_exec_info_content, tui_erase_exec_info_content)
3868         (tui_clear_exec_info_content): Update.
3869         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3870         Update.
3871         * tui/tui-win.c (make_invisible_and_set_new_height)
3872         (make_visible_with_new_height): Update.
3873         * tui/tui-source.c (tui_set_source_content)
3874         (tui_show_symtab_source): Update.
3875         * tui/tui-layout.c (extract_display_start_addr)
3876         (show_source_disasm_command, show_data)
3877         (make_source_or_disasm_window)
3878         (show_source_or_disasm_and_command): Update.
3879         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3880         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3881         "gdbarch".
3882         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3883         to tui_source_window_base.
3884         (struct tui_win_info) <detail>: Remove source_info member.
3885         (struct tui_source_window_base) <has_locator>: Inline.
3886         Move contents from tui_source_info; rename has_locator member to
3887         m_has_locator.
3888         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3889         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3890         header file.
3891         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3892         Simplify.
3893         (tui_free_all_source_wins_content): Cast to
3894         tui_source_window_base.
3895
3896 2019-06-25  Tom Tromey  <tom@tromey.com>
3897
3898         * tui/tui-win.c (make_invisible_and_set_new_height)
3899         (make_visible_with_new_height): Call has_locator method.
3900         * tui/tui-layout.c (show_source_disasm_command, show_data)
3901         (show_source_or_disasm_and_command): Update for bool change.
3902         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3903         (tui_win_info) <has_locator>: New method.
3904         (struct tui_source_window_base) <has_locator>: New method.
3905         (tui_win_has_locator): Don't declare.
3906         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3907         from tui_win_has_locator.
3908         (tui_source_window_base): Use false, not FALSE.
3909
3910 2019-06-25  Tom Tromey  <tom@tromey.com>
3911
3912         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3913         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3914         clear_detail method directly.
3915         (tui_clear_win_detail): Remove.
3916
3917 2019-06-25  Tom Tromey  <tom@tromey.com>
3918
3919         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3920         "this", not TUI_DISASM_WIN.
3921
3922 2019-06-25  Tom Tromey  <tom@tromey.com>
3923
3924         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3925         declare.
3926         * tui/tui-winsource.c
3927         (tui_source_window_base::do_scroll_horizontal): Rename from
3928         tui_horizontal_source_scroll.
3929         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3930         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3931         from tui_vertical_data_scroll.
3932         * tui/tui-win.h (tui_scroll): Don't declare.
3933         * tui/tui-win.c (tui_win_info::forward_scroll)
3934         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3935         (tui_win_info::right_scroll): Rename and update.
3936         (tui_scroll_forward_command, tui_scroll_backward_command)
3937         (tui_scroll_left_command, tui_scroll_right_command): Update.
3938         (tui_scroll): Remove.
3939         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3940         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3941         from tui_vertical_source_scroll.
3942         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3943         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3944         from tui_vertical_disassem_scroll.
3945         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3946         do_scroll_horizontal>: New methods.
3947         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3948         Likewise.
3949         (struct tui_source_window_base): Add do_scroll_horizontal.
3950         (struct tui_source_window, struct tui_disasm_window): Add
3951         do_scroll_vertical.
3952         (struct tui_data_window, struct tui_cmd_window): Add
3953         do_scroll_horizontal and do_scroll_vertical.
3954         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3955
3956 2019-06-25  Tom Tromey  <tom@tromey.com>
3957
3958         * tui/tui-data.h (struct tui_source_window_base): New struct.
3959         (struct tui_source_window): Derive from tui_source_window_base.
3960         (struct tui_disasm_window): New struct.
3961         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3962         from tui_source_window::clear_detail.
3963         (tui_source_window_base): Rename from tui_source_window.
3964         (~tui_source_window_base): Rename from ~tui_source_window.
3965         (tui_alloc_win_info): Create a tui_disasm_window.
3966
3967 2019-06-25  Tom Tromey  <tom@tromey.com>
3968
3969         * tui/tui-data.h (struct tui_source_window)
3970         (struct tui_data_window): Declare destructors.
3971         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3972         destructors.
3973         (tui_win_info): Simplify.
3974
3975 2019-06-25  Tom Tromey  <tom@tromey.com>
3976
3977         * tui/tui-winsource.c (tui_display_main)
3978         (tui_update_source_windows_with_addr)
3979         (tui_update_all_breakpoint_info): Update.
3980         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3981         (new_height_ok, parse_scrolling_args): Update.
3982         * tui/tui-stack.c (tui_show_frame_info): Update.
3983         * tui/tui-data.h (struct tui_list): Remove.
3984         (tui_source_windows): Return a reference to a std::vector.
3985         * tui/tui-data.c (source_windows): Now a std::vector.
3986         (tui_source_windows): Change return type.
3987         (tui_clear_source_windows): Rewrite.
3988         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3989         (tui_free_all_source_wins_content): Rewrite.
3990
3991 2019-06-25  Tom Tromey  <tom@tromey.com>
3992
3993         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3994         (struct tui_data_window, struct tui_cmd_window): Declare
3995         clear_detail method.
3996         * tui/tui-data.c (tui_source_window::clear_detail)
3997         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3998         methods.
3999         (tui_clear_win_detail): Simplify.
4000
4001 2019-06-25  Tom Tromey  <tom@tromey.com>
4002
4003         * tui/tui-layout.c (make_source_window, make_disasm_window)
4004         (make_source_or_disasm_window): Remove win_info_ptr parameter.
4005         Return the new window.
4006         (show_source_disasm_command, show_data)
4007         (show_source_or_disasm_and_command): Update.
4008
4009 2019-06-25  Tom Tromey  <tom@tromey.com>
4010
4011         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
4012         parameter.  Return the new window.
4013         (show_source_disasm_command): Update and remove NULL check.
4014         (show_source_or_disasm_and_command): Update.
4015
4016 2019-06-25  Tom Tromey  <tom@tromey.com>
4017
4018         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
4019
4020 2019-06-25  Tom Tromey  <tom@tromey.com>
4021
4022         * tui/tui-data.h (struct tui_win_info): Make constructor
4023         protected.  Make destructor virtual.  Add initializers.
4024         (tui_source_window, tui_data_window, tui_cmd_window): New
4025         classes.
4026         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
4027         constructor.  Add "type" parameter.
4028         (tui_source_window, tui_data_window, tui_cmd_window): New
4029         constructors.
4030         (tui_alloc_win_info): Instantiate the appropriate subclass.
4031
4032 2019-06-25  Tom Tromey  <tom@tromey.com>
4033
4034         * tui/tui-win.c (tui_resize_all): Use delete.
4035         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4036         destructor.
4037         (tui_free_window): Don't declare.
4038         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4039         Update.
4040
4041 2019-06-25  Tom Tromey  <tom@tromey.com>
4042
4043         * tui/tui-data.h (struct tui_win_info): Add constructor.
4044         * tui/tui-data.c (tui_alloc_win_info): Use new.
4045         (tui_free_window): Use delete.
4046
4047 2019-06-22  Tom Tromey  <tom@tromey.com>
4048
4049         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4050         declare.
4051         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4052
4053 2019-06-22  Tom Tromey  <tom@tromey.com>
4054
4055         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4056         declare.
4057         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4058
4059 2019-06-22  Tom de Vries  <tdevries@suse.de>
4060
4061         * dwarf2read.c (create_addrmap_from_aranges)
4062         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4063         instead of '%zu'.
4064
4065 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
4066
4067         * dwarf2read.h (dwarf2_section_info_def): Remove.
4068         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4069         * dwarf2read.c (struct dwo_sections) <types>: Change type to
4070         std::vector<dwarf2_section_info>.
4071         (struct dwo_file) <~dwo_file>: Remove.
4072         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4073         types field.
4074         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4075         (dwarf2_read_debug_names): Likewise.
4076         (create_debug_types_hash_table): Change parameter type to
4077         array_view, adjust code accordingly.
4078         (dwarf2_locate_dwo_sections): Adjust to std::vector.
4079         (partial_die_info::fixup): Likewise.
4080         (determine_prefix): Likewise.
4081         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4082
4083 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4084
4085         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4086         gdb_bfd_ref_ptr.
4087         <~dwo_file>: Remove call to gdb_bfd_unref.
4088         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4089         gdb_bfd_ref_ptr::get.
4090
4091 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4092
4093         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4094         type to htab_up.
4095         * dwarf2read.c (struct dwo_file): Initialize fields.
4096         <~dwo_file>: New.
4097         (free_dwo_file): Remove, move content to ~dwo_file.
4098         (struct dwo_file_deleter): Remove.
4099         (dwo_file_up>: Remove custom deleter.
4100         (free_dwo_files): Remove.
4101         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4102         dwo_files.
4103         (process_skeletonless_type_units): Call unique_ptr::get.
4104         (allocate_dwo_file_hash_table): Add deleter to created hash
4105         table.  Change return type to htab_up.
4106         (lookup_dwo_file_slot): Don't memset dwo_file, call
4107         unique_ptr::get.
4108         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4109         (create_dwo_unit_in_dwp_v2): Likewise.
4110         (open_and_init_dwo_file): Likewise.
4111         (free_dwo_file_from_slot): Remove.
4112
4113 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4114
4115         * dwarf2read.h (struct dwarf2_section_info) <readin,
4116         is_virtual>: Change type to bool.
4117         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4118         true instead of 1.
4119
4120 2019-06-19  Tom Tromey  <tom@tromey.com>
4121
4122         * tui/tui-data.h (tui_init_content_element): Don't declare.
4123
4124 2019-06-19  Tom Tromey  <tom@tromey.com>
4125
4126         * tui/tui-data.h (tui_init_win_info): Don't declare.
4127
4128 2019-06-19  Tom de Vries  <tdevries@suse.de>
4129
4130         * dwarf2read.h (abstract_to_concrete): Change type to
4131         std::unordered_map<sect_offset, std::vector<sect_offset>,
4132         gdb::hash_enum<sect_offset>>.
4133
4134 2019-06-19  Tom Tromey  <tromey@adacore.com>
4135
4136         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4137         EVAL_AVOID_SIDE_EFFECTS specially.
4138
4139 2019-06-19  Tom Tromey  <tromey@adacore.com>
4140
4141         * source-cache.c (highlighter): New global.
4142         (source_cache::get_source_lines): Create a highlighter on demand.
4143
4144 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4145
4146         * defs.h (deprecated_interactive_hook): Delete declaration.
4147         * interps.c (clear_interpreter_hooks): Remove use of
4148         deprecated_interactive_hook.
4149         * top.c (deprecated_interactive_hook): Delete definition.
4150         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4151
4152 2019-06-18  Tom de Vries  <tdevries@suse.de>
4153
4154         PR gdb/24515
4155         * dwarf2read.h (abstract_to_concrete): Change type from
4156         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4157         std::unordered_map<sect_offset, std::vector<sect_offset>>.
4158         * dwarf2read.c (read_variable): Update.
4159         (dwarf2_fetch_die_loc_sect_off): Update.
4160
4161 2019-06-17  Tom de Vries  <tdevries@suse.de>
4162
4163         PR gdb/24617
4164         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4165         accessing parent[parent_len - 1].
4166
4167 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
4168
4169         PR gdb/24364
4170         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4171         call dtrace_process_dof with NULL dof.
4172
4173 2019-06-16  Tom de Vries  <tdevries@suse.de>
4174
4175         PR gdb/24445
4176         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4177
4178 2019-06-16  Tom Tromey  <tom@tromey.com>
4179
4180         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4181         (make_all_visible): Use address of member.
4182
4183 2019-06-16  Tom Tromey  <tom@tromey.com>
4184
4185         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4186         (tui_free_window, free_content, free_content_elements): Remove
4187         unnecessary cast.
4188         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4189         cast.
4190         * tui/tui-regs.c (tui_show_register_group)
4191         (tui_display_registers_from, tui_display_reg_element_at_line):
4192         Remove unnecessary cast.
4193
4194 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
4195
4196         * linux-nat.c (normal_mask): Delete.
4197         (_initialize_linux_nat): Don't initialise normal_mask.
4198
4199 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
4200
4201         PR gdb/24445
4202         * dwarf-index-write.h (write_psymtabs_to_index): Add
4203         dwz_basename parameter.
4204         * dwarf-index-write.c (write_gdbindex): Move file writing to
4205         write_gdbindex_1.  Change return type void.
4206         (assert_file_size): Move up, remove filename parameter.
4207         (write_gdbindex_1): New function.
4208         (write_debug_names): Change return type to void, call
4209         assert_file_size.
4210         (struct index_wip_file): New struct.
4211         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
4212         file logic to index_wip_file.  Write index for dwz file if
4213         needed.
4214         (save_gdb_index_command): Pass basename of dwz file, if present.
4215         * dwarf-index-cache.c (index_cache::store): Obtain and pass
4216         build-id of dwz file, if present.
4217         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4218         (dwarf2_get_dwz_file): Likewise.
4219         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4220         (dwarf2_get_dwz_file): Likewise.
4221
4222 2019-06-16  Tom Tromey  <tom@tromey.com>
4223
4224         * coffread.c (process_coff_symbol): Use xstrdup.
4225         * value.c (create_internalvar): Use xstrdup.
4226
4227 2019-06-16  Tom Tromey  <tom@tromey.com>
4228
4229         * valops.c (value_cast, value_slice): Remove unnecessary cast.
4230         * breakpoint.c (stopin_command, stopat_command)
4231         (until_break_command, decode_location_default): Remove unnecessary
4232         cast.
4233         * utils.c (subset_compare): Remove unnecessary cast.
4234         * ada-lang.c (ada_update_initial_language): Remove unnecessary
4235         cast.
4236         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4237         cast.
4238         * infcmd.c (path_command): Remove unnecessary cast.
4239         * coffread.c (decode_type): Remove unnecessary cast.
4240         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4241         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4242         * tui/tui-stack.c (tui_show_locator_content)
4243         (tui_show_frame_info): Remove unnecessary cast.
4244         * tui/tui-win.c (tui_scroll_forward_command)
4245         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4246         (parse_scrolling_args): Remove unnecessary cast.
4247         * tui/tui-data.c (init_win_info, tui_del_window)
4248         (tui_free_window, tui_del_data_windows, tui_free_data_content)
4249         (free_content_elements): Remove unnecessary cast.
4250         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4251         unnecessary cast.
4252         * tui/tui-source.c (tui_set_source_content)
4253         (tui_vertical_source_scroll): Remove unnecessary cast.
4254         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4255         cast.
4256         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4257         * tui/tui-regs.c (tui_display_registers_from)
4258         (tui_display_register): Remove unnecessary cast.
4259         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4260         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4261         (make_visible): Remove unnecessary cast.
4262         * tui/tui-winsource.c (tui_erase_source_content)
4263         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4264         unnecessary cast.
4265         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4266         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4267         * stabsread.c (read_type, read_array_type, read_range_type):
4268         Remove unnecessary cast.
4269         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4270         (parse_symbol, parse_type, upgrade_type, parse_external)
4271         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4272         unnecessary cast.
4273         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4274
4275 2019-06-16  Tom Tromey  <tom@tromey.com>
4276
4277         * tui/tui-data.c (tui_alloc_generic_win_info)
4278         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4279         checks.
4280
4281 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
4282             Andrew Burgess  <andrew.burgess@embecosm.com>
4283
4284         * f-typeprint.c (f_print_type): Don't return early for not
4285         associated or not allocated types.
4286         (f_type_print_varspec_suffix): Add print_rank parameter and print
4287         ranks of array types in case they dangling.
4288         (f_type_print_base): Add print_rank parameter.
4289
4290 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4291
4292         * NEWS: Mention new MI commands.
4293         * break-catch-throw.c (enum exception_event_kind): Move to
4294         breakpoint.h.
4295         (print_mention_exception_catchpoint): Output text as a single
4296         message.
4297         (catch_exception_command_1): Rename to...
4298         (catch_exception_event): ...this, make non-static, update header
4299         command, and change some parameter types.
4300         (catch_catch_command): Update for changes to
4301         catch_exception_command_1.
4302         (catch_throw_command): Likewise.
4303         (catch_rethrow_command): Likewise.
4304         * breakpoint.c (enum exception_event_kind): Delete.
4305         * breakpoint.h (enum exception_event_kind): Moved here from
4306         break-catch-throw.c.
4307         (catch_exception_event): Declare.
4308         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4309         (mi_cmd_catch_throw): New function.
4310         (mi_cmd_catch_rethrow): New function.
4311         (mi_cmd_catch_catch): New function.
4312         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4313         'catch-catch' entries.
4314         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4315         (mi_cmd_catch_rethrow): Declare.
4316         (mi_cmd_catch_catch): Declare.
4317
4318 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4319
4320         * annotate.c (annotate_source_line): Change return type to void,
4321         update implementation to match.
4322         * annotate.h (annotate_source_line): Change return type to void,
4323         update header comment.
4324         * stack.c (print_frame_info): Don't change what frame information
4325         is printed based on whether annotations are on or not.
4326
4327 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4328
4329         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4330         (annotate_source): Make static.
4331         (annotate_source_line): Moved from source.c and renamed from
4332         identify_source_line.  Update the return type.
4333         * annotate.h (annotate_source): Delete declaration.
4334         (annotate_source_line): Declaration moved from source.h, and
4335         renamed from identify_source_line.  Return type updated.
4336         * source.c (identify_source_line): Moved to annotate.c and renamed
4337         to annotate_source_line.
4338         (info_line_command): Remove check of annotation_level.
4339         * source.h (identify_source_line): Move declaration to annotate.h
4340         and rename to annotate_source_line.
4341         * stack.c: Add 'annotate.h' include.
4342         (print_frame_info): Remove check of annotation_level before
4343         calling annotate_source_line.
4344
4345 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4346
4347         * source-cache.c (source_cache::get_plain_source_lines): Use
4348         open_source_file_with_line_charpos instead of just
4349         open_source_file, remove call to find_source_lines.
4350         (source_cache::get_source_lines): Likewise.
4351         * source.c (find_source_lines): Make static.
4352         (get_filename_and_charpos): Renamed into...
4353         (open_source_file_with_line_charpos): ..this along with changes to
4354         return a scoped_fd, and some other minor clean ups.
4355         (identify_source_line): Use open_source_file_with_line_charpos.
4356         (search_command_helper): Use open_source_file_with_line_charpos
4357         instead of just open_source_file, remove call to
4358         find_source_lines.
4359         * source.h (open_source_file_with_line_charpos): Declare new
4360         function.
4361         (find_source_lines): Delete declaration.
4362
4363 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4364
4365         * source.c (get_filename_and_charpos): Remove fullname
4366         parameter.
4367         (identify_source_line): Update call to get_filename_and_charpos.
4368
4369 2019-06-14  Tom Tromey  <tromey@adacore.com>
4370
4371         PR gdb/24502:
4372         * ui-style.h (skip_ansi_escape): Update comment.
4373         * ui-file.h (class no_terminal_escape_file): New class.
4374         * ui-file.c (no_terminal_escape_file::write)
4375         (no_terminal_escape_file::puts): New methods.
4376         * cli/cli-logging.c (handle_redirections): Use
4377         no_terminal_escape_file.
4378
4379 2019-06-14  Tom Tromey  <tromey@adacore.com>
4380
4381         * NEWS: Move convenience variable news above Python news.
4382
4383 2019-06-14  Tom Tromey  <tom@tromey.com>
4384
4385         * gnulib: Move directory to top-level.
4386         * configure.ac: Don't configure gnulib.
4387         * configure: Rebuild.
4388         * common/common-defs.h: Use new path to gnulib.
4389         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4390         (GNULIB_H): Remove.
4391         (INCGNU): Look in new gnulib location.
4392         (HFILES_NO_SRCDIR): Remove gnulib files.
4393         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4394         (generated_files): Remove GNULIB_H.
4395         ($(LIBGNU), all-lib): Remove targets.
4396         (distclean): Don't mention GNULIB_BUILDDIR.
4397         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4398
4399 2019-06-14  Tom Tromey  <tromey@adacore.com>
4400
4401         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4402         Warn if symbol file does not provide any symbols.
4403
4404 2019-06-14  Tom Tromey  <tromey@adacore.com>
4405
4406         * source.c (find_and_open_source): Respect basenames_may_differ.
4407
4408 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4409
4410         * annotate.c (annotate_breakpoints_invalid): Make use of
4411         scoped_restore_terminal_state.
4412         (annotate_frames_invalid): Likewise.
4413
4414 2019-06-14  Tom Tromey  <tromey@adacore.com>
4415
4416         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4417         allow assignment to an internalvar.
4418
4419 2019-06-14  Tom Tromey  <tromey@adacore.com>
4420
4421         * ada-lex.l: Allow "_" in attribute names.
4422
4423 2019-06-14  Tom Tromey  <tromey@adacore.com>
4424
4425         PR gdb/24653:
4426         * regcache.c (registers_changed): Don't call alloca.
4427         * top.c (execute_command): Don't call alloca.
4428
4429 2019-06-13  Pedro Alves  <palves@redhat.com>
4430
4431         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4432         'expression'.  When parsing an expression, error out if there's
4433         junk after "unlimited".
4434         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4435         (do_set_command): Adjust calls to is_unlimited_literal.
4436
4437 2019-06-13  Pedro Alves  <palves@redhat.com>
4438
4439         * compile/compile.c (make_compile_options_def_group): Add braces
4440         around array_view initializer.
4441         * thread.c (make_thread_apply_all_options_def_group)
4442         (make_thread_apply_all_options_def_group): Likewise.
4443
4444 2019-06-13  Pedro Alves  <palves@redhat.com>
4445
4446         * NEWS (New commands): Mention "maint test-options
4447         require-delimiter", "maint test-options unknown-is-error", "maint
4448         test-options unknown-is-operand" and "maint show
4449         test-options-completion-result".
4450         (New command options, command completion): New section.
4451         (Completion improvements): New section.
4452         Mention that you can abbreviate "unlimited".
4453
4454 2019-06-13  Pedro Alves  <palves@redhat.com>
4455
4456         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4457         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4458         * unittests/cli-utils-selftests.c (test_parse_flags)
4459         (test_parse_flags_qcs): Delete.
4460         (test_cli_utils): Don't call deleted functions.
4461
4462 2019-06-13  Pedro Alves  <palves@redhat.com>
4463
4464         * thread.c: Include "cli/cli-option.h".
4465         (tp_array_compar_ascending): Global.
4466         (tp_array_compar): Delete function.
4467         (tp_array_compar_ascending, tp_array_compar_descending): New
4468         functions.
4469         (ascending_option_def, qcs_flag_option_def)
4470         (thr_qcs_flags_option_defs)
4471         (make_thread_apply_all_options_def_group)
4472         (make_thread_apply_options_def_group): New.
4473         (thread_apply_all_command): Use gdb::option::process_options.
4474         (thread_apply_command_completer)
4475         (thread_apply_all_command_completer): New.
4476         (thread_apply_command): Use gdb::option::process_options.
4477         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4478         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4479         to generate help text of "thread apply".  Adjust "taas"'s help.
4480         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4481         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4482
4483 2019-06-13  Pedro Alves  <palves@redhat.com>
4484
4485         * thread.c (thread_apply_command): Check for invalid TID with
4486         isdigit instead of !isalpha.
4487
4488 2019-06-13  Pedro Alves  <palves@redhat.com>
4489
4490         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4491         (validate_flags_qcs): New.
4492         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4493         (validate_flags_qcs): Declare.
4494         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4495         (make_frame_apply_options_def_group): New.
4496         (frame_apply_command_count): Process options with
4497         gdb::option::process_options.
4498         (frame_apply_completer): New.
4499         (frame_apply_level_completer, frame_apply_all_completer)
4500         (frame_apply_completer): New.
4501         (_initialize_stack): Update help of "frame apply", "frame apply
4502         level", "frame apply all" and "faas" to mention supported options
4503         and install command completers.
4504         * stack.h (frame_apply_all_completer): Declare.
4505         * thread.c: Include "stack.h".
4506         (tfaas_command): Add "--".
4507         (_initialize_thread): Update help "tfaas" to mention supported
4508         options and install command completer.
4509
4510 2019-06-13  Pedro Alves  <palves@redhat.com>
4511
4512         * completer.c (complete_nested_command_line): New.
4513         (gdb_completion_word_break_characters_throw): Add assertion.
4514         * completer.h (complete_nested_command_line): Declare.
4515
4516 2019-06-13  Pedro Alves  <palves@redhat.com>
4517
4518         * stack.c (parse_backtrace_qualifiers): New.
4519         (backtrace_command): Use it.
4520         (backtrace_command_completer): Complete on qualifiers.
4521
4522 2019-06-13  Pedro Alves  <palves@redhat.com>
4523
4524         * frame.c: Include "cli/cli-option.h.
4525         (user_set_backtrace_options): New.
4526         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4527         Delete.
4528         (get_prev_frame): Adjust.
4529         (boolean_option_def, uinteger_option_def)
4530         (set_backtrace_option_defs): New.
4531         (_initialize_frame): Adjust and use
4532         gdb::option::add_setshow_cmds_for_options to install "set
4533         backtrace past-main" and "set backtrace past-entry".
4534         * frame.h: Include "cli/cli-option.h".
4535         (struct frame_print_options): Forward declare.
4536         (print_frame_arguments_all, print_frame_arguments_scalars)
4537         (print_frame_arguments_none): Declare.
4538         (print_entry_values): Delete declaration.
4539         (struct frame_print_options, user_frame_print_options): New.
4540         (struct set_backtrace_options): New.
4541         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4542         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4543         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4544         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4545         (list_args_or_locals): Add frame_print_options parameter.
4546         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4547         * python/py-framefilter.c (enumerate_args): Pass down
4548         USER_FRAME_PRINT_OPTIONS.
4549         * stack.c: Include "cli/cli-option.h".
4550         (print_frame_arguments_all, print_frame_arguments_scalars)
4551         (print_frame_arguments_none): Declare.
4552         (print_raw_frame_arguments, print_entry_values): Delete.
4553         (user_frame_print_options): New.
4554         (boolean_option_def, enum_option_def, frame_print_option_defs):
4555         New.
4556         (struct backtrace_cmd_options): New.
4557         (bt_flag_option_def): New.
4558         (backtrace_command_option_defs): New.
4559         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4560         (print_frame_arg, read_frame_arg, print_frame_args)
4561         (print_frame_info, print_frame): Add frame_print_options parameter
4562         and use it.
4563         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4564         (backtrace_command_1): Add frame_print_options and
4565         backtrace_cmd_options parameters and use them.
4566         (make_backtrace_options_def_group): New.
4567         (backtrace_command): Process command options with
4568         gdb::option::process_options.
4569         (backtrace_command_completer): New.
4570         (_initialize_stack): Extend "backtrace"'s help to mention
4571         supported options.  Install completer for "backtrace".
4572         Install some settings commands with add_setshow_cmds_for_options.
4573
4574 2019-06-13  Pedro Alves  <palves@redhat.com>
4575
4576         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4577         and that "set/show print raw frame-arguments" are now deprecated.
4578
4579         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4580         command.
4581         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4582         * stack.c (_initialize_stack): Install "set/show print
4583         raw-frame-arguments", and deprecate "set/show print raw
4584         frame-arguments".
4585         * valprint.c (_initialize_valprint): Deprecate "set/show print
4586         raw".
4587
4588 2019-06-13  Pedro Alves  <palves@redhat.com>
4589
4590         * compile/compile.c (struct compile_options): New.
4591         (compile_flag_option_def, compile_command_option_defs)
4592         (make_compile_options_def_group): New.
4593         (compile_file_command): Handle options with
4594         gdb::option::process_options.
4595         (compile_file_command_completer): New function.
4596         (compile_code_command): Handle options with
4597         gdb::option::process_options.
4598         (compile_code_command_completer): New function.
4599         (_initialize_compiler): Install completers for "compile code" and
4600         "compile file".  Mention available options in "compile code" and
4601         "compile code"'s help.
4602         * completer.c (advance_to_completion_word): New, factored out from
4603         ...
4604         (advance_to_expression_complete_word_point): ... this.
4605         (advance_to_filename_complete_word_point): New.
4606         * completer.h (advance_to_filename_complete_word_point): New
4607         declaration.
4608
4609 2019-06-13  Pedro Alves  <palves@redhat.com>
4610
4611         * compile/compile.c: Include "cli/cli-option.h".
4612         (compile_print_value): Scope data pointer is now a
4613         value_print_options pointer; adjust.
4614         (compile_print_command): Process options.  Scope data pointer is
4615         now a value_print_options pointer; adjust.
4616         (_initialize_compile): Update "compile print"'s help to include
4617         supported options.  Install a completer for "compile print".
4618         * cp-valprint.c (show_vtblprint, show_objectprint)
4619         (show_static_field_print): Delete.
4620         (_initialize_cp_valprint): Don't install "set print
4621         static-members", "set print vtbl", "set print object" here.
4622         * printcmd.c: Include "cli/cli-option.h" and
4623         "common/gdb_optional.h".
4624         (print_command_parse_format): Rework to fill in a
4625         value_print_options instead of a format_data.
4626         (print_value): Change parameter type from format_data pointer to
4627         value_print_options reference.  Adjust.
4628         (print_command_1): Process options.  Adjust to pass down a
4629         value_print_options.
4630         (print_command_completer): New.
4631         (_initialize_printcmd): Install print_command_completer as
4632         handle_brkchars completer for the "print" command.  Update
4633         "print"'s help to include supported options.
4634         * valprint.c: Include "cli/cli-option.h".
4635         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4636         here from cp-valprint.c.
4637         (boolean_option_def, uinteger_option_def)
4638         (value_print_option_defs, make_value_print_options_def_group):
4639         New.  Use gdb::option::add_setshow_cmds_for_options to install
4640         "set print elements", "set print null-stop", "set print repeats",
4641         "set print pretty", "set print union", "set print array", "set
4642         print address", "set print symbol", "set print array-indexes".
4643         * valprint.h: Include <string> and "cli/cli-option.h".
4644         (make_value_print_options_def_group): Declare.
4645         (print_value): Change parameter type from format_data pointer to
4646         value_print_options reference.
4647         (print_command_completer): Declare.
4648
4649 2019-06-13  Pedro Alves  <palves@redhat.com>
4650
4651         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4652         (COMMON_SFILES): Add maint-test-settings.c.
4653         * cli/cli-decode.c (boolean_enums): New global, factored out from
4654         ...
4655         (add_setshow_boolean_cmd): ... here.
4656         * cli/cli-decode.h (boolean_enums): Declare.
4657         * cli/cli-option.c: New file.
4658         * cli/cli-option.h: New file.
4659         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4660         factored out from ...
4661         (parse_cli_boolean_value(const char *)): ... this.
4662         (is_unlimited_literal): Change parameter type to pointer to
4663         pointer.  Adjust and advance ARG pointer.
4664         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4665         (parse_cli_var_enum): New, factored out from ...
4666         (do_set_command): ... this.  Adjust.
4667         * cli/cli-setshow.h (parse_cli_boolean_value)
4668         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4669         (parse_cli_var_enum): Declare.
4670         * cli/cli-utils.c: Include "cli/cli-option.h".
4671         (get_ulongest): New.
4672         * cli/cli-utils.h (get_ulongest): Declare.
4673         (check_for_argument): New overloads.
4674         * maint-test-options.c: New file.
4675
4676 2019-06-13  Pedro Alves  <palves@redhat.com>
4677
4678         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4679         parse a range if "-" is at the end of the string.
4680
4681 2019-06-13  Pedro Alves  <palves@redhat.com>
4682
4683         * cli/cli-setshow.c (parse_auto_binary_operation)
4684         (parse_cli_boolean_value): Don't allow "o".
4685
4686 2019-06-13  Pedro Alves  <palves@redhat.com>
4687
4688         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4689         * NEWS: Mention maint test-settings KIND.
4690         * maint-test-settings.c: New file.
4691
4692 2019-06-13  Pedro Alves  <palves@redhat.com>
4693
4694         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4695         completer.
4696         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4697         "set" completers.
4698
4699 2019-06-13  Pedro Alves  <palves@redhat.com>
4700
4701         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4702         after item.
4703
4704 2019-06-13  Pedro Alves  <palves@redhat.com>
4705
4706         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4707
4708 2019-06-13  Pedro Alves <palves@redhat.com>
4709
4710         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4711         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4712         call.
4713         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4714         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4715         calls.
4716         (check_for_argument): Skip spaces after argument.
4717
4718 2019-06-13  Pedro Alves  <palves@redhat.com>
4719
4720         * thread.c (thread_apply_command): Adjust TID parsing.
4721         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4722         detected before end of string.
4723         (tid_is_in_list): Error out if LIST is invalid.
4724
4725 2019-06-13  Pedro Alves  <palves@redhat.com>
4726
4727         * completer.c (complete_line_internal_1): Rewind completion word
4728         point.
4729         (completion_tracker::advance_custom_word_point_by): Change
4730         parameter type to int.
4731         * completer.h (completion_tracker::advance_custom_word_point_by):
4732         Likewise.
4733
4734 2019-06-13  Pedro Alves  <palves@redhat.com>
4735
4736         * completer.c (advance_to_completion_word): Handle delimiters.
4737
4738 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4739
4740         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4741
4742 2019-06-11  Tom Tromey  <tom@tromey.com>
4743
4744         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4745         (xmalloc_failed): Move to alloc.c.
4746         * alloc.c: New file.
4747         * Makefile.in (COMMON_SFILES): Add alloc.c.
4748
4749 2019-06-11  Tom Tromey  <tom@tromey.com>
4750
4751         * nat/linux-waitpid.c: Don't include server.h.
4752         (linux_debug): Remove.
4753         (my_waitpid): Update.
4754
4755 2019-06-11  Tom Tromey  <tromey@adacore.com>
4756
4757         * infcall.c (_initialize_infcall): Remove trailing newline from
4758         help.
4759         * user-regs.c (_initialize_user_regs): Remove trailing newline
4760         from help.
4761         * typeprint.c (_initialize_typeprint): Remove trailing newline
4762         from help.
4763         * reverse.c (_initialize_reverse): Remove trailing newlines from
4764         help.
4765         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4766         from help.
4767         * language.c (add_set_language_command): Remove trailing newline
4768         from help.
4769         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4770         help.
4771         * disasm.c (_initialize_disasm): Remove trailing newline from
4772         help.
4773         * top.c (init_main): Remove trailing newline from help.
4774         * interps.c (_initialize_interpreter): Remove trailing newline
4775         from help.
4776         * btrace.c (_initialize_btrace): Remove trailing newlines from
4777         help.
4778         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4779         from help.
4780         * python/python.c (_initialize_python): Remove trailing newline
4781         from help.
4782         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4783         help.
4784         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4785         from help.  Reformat some text.
4786         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4787         from help.
4788         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4789         newline from help.
4790
4791 2019-06-11  Tom Tromey  <tromey@adacore.com>
4792
4793         * darwin-nat.c (darwin_decode_exception_message)
4794         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4795
4796 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4797
4798         * valops.c (value_slice): Check for not allocated or not
4799         associated values.
4800
4801 2019-06-10  Tom de Vries  <tdevries@suse.de>
4802
4803         PR gdb/24618
4804         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4805         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4806         invalid.
4807
4808 2019-06-10  Tom de Vries  <tdevries@suse.de>
4809
4810         PR gdb/24611
4811         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4812         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4813
4814 2019-06-10  Tom de Vries  <tdevries@suse.de>
4815
4816         PR symtab/24545
4817         * symtab.c (struct demangled_name_entry): Add language field.
4818         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4819         static minimal symbol".  Set and use language field.
4820
4821 2019-06-10  Tom Tromey  <tromey@adacore.com>
4822
4823         * ada-lang.c (_initialize_ada_language): Update help text.
4824
4825 2019-06-10  Tom Tromey  <tromey@adacore.com>
4826
4827         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4828         with a newline.
4829         * guile/guile.c (handle_boot_error): Don't end warning with a
4830         newline.
4831         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4832         warning with a newline.
4833         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4834         newline.
4835         (s12z_frame_cache): Likewise.
4836         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4837         a newline.
4838         * solib-svr4.c (disable_probes_interface): Don't end warning with
4839         a newline.
4840         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4841         newline.
4842         * python/python.c (do_finish_initialization): Don't end warning
4843         with a newline.
4844
4845 2019-06-10  Tom Tromey  <tom@tromey.com>
4846
4847         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4848         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4849         gdbpy_enter.
4850
4851 2019-06-10  Tom Tromey  <tromey@adacore.com>
4852
4853         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4854         data.
4855         (elf_new_init): Don't call stabsread_new_init.
4856         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4857         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4858         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4859
4860 2019-06-10  Tom de Vries  <tdevries@suse.de>
4861
4862         PR symtab/16264
4863         PR symtab/24517
4864         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4865
4866 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4867
4868         * source.c (find_and_open_source): Also rewrite relative file
4869         names.
4870
4871 2019-04-26  Amos Bird  <amosbird@gmail.com>
4872
4873         * annotate.c (annotate_thread_exited): Add "thread-exited"
4874         annotation.
4875
4876 2019-06-06  Tom Tromey  <tromey@adacore.com>
4877
4878         * maint.h (class scoped_command_stats): Use
4879         DISABLE_COPY_AND_ASSIGN.
4880         <print_time>: New method.
4881         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4882         print_time.
4883         (scoped_command_stats::print_time): New method.
4884
4885 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4886
4887         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4888         instructions of lengths 6 or 8 bytes.
4889
4890 2019-06-04  Pedro Alves  <palves@redhat.com>
4891
4892         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4893
4894         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4895         * breakpoint.c (condition_completer): Likewise.
4896         * cli/cli-dump.c (scan_expression): Likewise.
4897         * common/filestuff.c (mkdir_recursive): Likewise.
4898         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4899         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4900         (gdb_abspath): Likewise.
4901         * compile/compile-cplus-types.c
4902         (compile_cplus_instance::decl_name): Likewise.
4903         * completer.c (complete_explicit_location):
4904         (signal_completer, reg_or_group_completer_1): Likewise.
4905         * cp-support.c (cp_remove_params_if_any): Likewise.
4906         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4907         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4908         * infcmd.c (strip_bg_char): Likewise.
4909         * linespec.c (copy_token_string): Likewise.
4910         * mi/mi-main.c (output_cores): Likewise.
4911         * psymtab.c (psymtab_search_name):
4912         * symfile.c (test_set_ext_lang_command): Likewise.
4913         * target.c (target_fileio_read_stralloc): Likewise.
4914         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4915         * value.c (complete_internalvar): Likewise.
4916
4917 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4918
4919         Add objfile property to gdb.Type.
4920         * NEWS: Mention Python API addition.
4921         * python/py-type.c (typy_get_objfile): New method.
4922
4923 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4924
4925         * NEWS: Mention the new set|show style [title|highlight].
4926         Mention changes to "show style", "help" and "apropos".
4927
4928 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4929
4930         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4931         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4932         instead of print_help_for_command.
4933         (print_doc_of_command): New function.
4934         (help_list): Add 'apropos -v word' suggestion.
4935         (print_help_for_command): Style the command name using title style.
4936         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4937         (_initialize_cli_cmds): Describe -v in apropos_command help.
4938
4939 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4940
4941         * cli/cli-style.h (cli_style_option): Add name in constructor,
4942         add m_name class member, add constructor with intensity,
4943         add name class function.
4944         (cli_style_option::add_setshow_commands): Remove name argument.
4945         (highlight_style, title_style): New styles.
4946         * cli/cli-style.c (do_show): New function that shows a style
4947         characteristic styling the style name with itself.
4948         (set_style_name): New function.
4949         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4950         Update all callers according to the changes in cli/cli-style.h.
4951         * utils.h (fputs_highlighted): New function.
4952         * utils.c (fputs_highlighted): Likewise.
4953
4954 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4955
4956         * NEWS: Mention new pipe command and new convenience variables.
4957
4958 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4959
4960         * cli/cli-cmds.c (pipe_command): New function.
4961         (_initialize_cli_cmds): Call add_com for pipe_command.
4962         Define | as an alias for pipe.
4963         (exit_status_set_internal_vars): New function.
4964         (shell_escape): Call exit_status_set_internal_vars.
4965         cli/cli-decode.c (find_command_name_length): Recognize | as
4966         a single character command.
4967
4968 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4969
4970         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4971         top.c (execute_command_to_ui_file): New function, mostly a copy
4972         of execute_command_to_string.
4973         (execute_command_to_string): Implement by calling
4974         execute_command_to_ui_file.
4975
4976 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4977
4978         * top.h (saved_command_line): Remove declaration.
4979         * top.c (previous_saved_command_line, previous_repeat_arguments):
4980         New variables.
4981         (saved_command_line): Make static, define together with other
4982         'repeat variables'.
4983         (dont_repeat): Clear repeat_arguments.
4984         (repeat_previous, get_saved_command_line, save_command_line):
4985         New functions.
4986         (gdb_init): Initialize saved_command_line
4987         and previous_saved_command_line.
4988         * main.c (captured_main_1): Remove saved_command_line initialization.
4989         * event-top.c (handle_line_of_input): Update to use
4990         the new 'repeat' related functions instead of direct access to
4991         saved_command_line.
4992         * command.h (repeat_previous, get_saved_command_line,
4993         save_command_line): New declarations.
4994         (dont_repeat): Add comment.
4995
4996 2019-05-30  Tom Tromey  <tromey@adacore.com>
4997
4998         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4999         Fix comment.
5000         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
5001
5002 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
5003
5004         PR cli/24587
5005         * completer.c (complete): Initialize variable word.
5006
5007 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
5008
5009         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5010         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
5011         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
5012         'body' is NULL to the outter 'if', protecting the '!is_define'
5013         situation as well.
5014
5015 2019-05-29  Tom Tromey  <tromey@adacore.com>
5016
5017         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
5018         (dwarf_unknown): New function.
5019         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
5020         (dwarf_type_encoding_name): Use dwarf_unknown.
5021
5022 2019-05-29  Tom Tromey  <tromey@adacore.com>
5023
5024         PR c++/20020:
5025         * cp-valprint.c (cp_print_value_fields): Call
5026         cp_print_static_field inside "try".
5027
5028 2019-05-29  Tom Tromey  <tromey@adacore.com>
5029
5030         * inflow.c (struct terminal_info): Add default operator=.
5031         * configure: Rebuild.
5032         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5033         -Wdeprecated-copy-dtor, -Wredundant-move.
5034
5035 2019-05-29  Tom Tromey  <tromey@adacore.com>
5036
5037         * NEWS: Add entry.
5038         * infcmd.c (print_return_value_1): Handle finish_print
5039         option.
5040         (show_print_finish): New function.
5041         (_initialize_infcmd): Add "set/show print finish" commands.
5042         * valprint.c (user_print_options): Initialize new member.
5043         * valprint.h (struct value_print_options) <finish_print>: New
5044         member.
5045
5046 2019-05-28  Tom Tromey  <tromey@adacore.com>
5047
5048         * ada-lang.c (ada_remove_Xbn_suffix)
5049         (find_old_style_renaming_symbol)
5050         (parse_old_style_renaming): Remove.
5051         (ada_find_renaming_symbol): Don't call
5052         find_old_style_renaming_symbol.
5053         (ada_is_renaming_symbol): Rename from
5054         ada_find_renaming_symbol.  Remove "block" parameter.  Return
5055         bool.  Now static.
5056         (ada_read_var_value): Update and simplify.
5057         * ada-exp.y (write_var_or_type): Remove old code.
5058
5059 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
5060
5061         * event-top.c: Remove include comment.
5062         * inflow.c (class scoped_ignore_sigttou): Move from here...
5063         * inflow.h (class scoped_ignore_sigttou): ...to here.
5064         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5065         * top.c:  Remove include comment.
5066
5067 2019-05-27  Tom Tromey  <tom@tromey.com>
5068
5069         * NEWS: Fix typo.
5070
5071 2019-05-22  Tom Tromey  <tromey@adacore.com>
5072
5073         * target.c (target_follow_exec): Constify parameter.
5074         * target-delegates.c: Rebuild.
5075         * remote.c (remote_target::follow_exec): Constify parameter.
5076         * infrun.c (follow_exec): Constify parameter.
5077         * target.h (struct target_ops) <follow_exec>: Constify parameter.
5078         (target_follow_exec): Likewise.
5079
5080 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5081
5082         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5083         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5084
5085 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5086
5087         * NEWS: Add debugredirect and testsuite sections.
5088
5089 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
5090
5091         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5092         target descriptions using exclusively floating point register name
5093         aliases.
5094
5095 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5096
5097         PR gdb/18644:
5098         * f-lang.c (build_fortran_types): Handle the case where
5099         gdbarch_floatformat_for_type returns a nullptr.
5100
5101 2019-05-21  Tom de Vries  <tdevries@suse.de>
5102
5103         PR cli/24587
5104         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5105
5106 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5107
5108         PR gdb/18644:
5109         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5110         16-byte floats.
5111         * i386-tdep.c (i386_floatformat_for_type): Use
5112         floatformats_ia64_quad for the 16-byte floating point component
5113         within a fortran 32-byte complex number.
5114
5115 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5116
5117         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5118         delete default constructor.
5119         (find_partial_die): Update to return const struct.
5120         (partial_die_parent_scope): Move variable declaration into scope
5121         of its use and change its type to auto.
5122         (guess_partial_die_structure_name): Likewise.
5123         (partial_die_info::fixup): Likewise.
5124
5125 2019-05-17  Tom Tromey  <tromey@adacore.com>
5126
5127         * source.c (find_and_open_source): Remove cast.
5128
5129 2019-05-17  Tom Tromey  <tromey@adacore.com>
5130
5131         * annotate.c (annotate_source): Make "filename" const.
5132         * annotate.h (annotate_source): Use const.
5133
5134 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5135
5136         * disasm.c (set_disassembler_options): Send errors to stderr.
5137
5138 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5139
5140         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5141         (cli_interp_base::set_logging): Check debug_redirect.
5142         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5143         * cli/cli-logging.c (debug_redirect): Add static variable.
5144         (pop_output_files): Add default param.
5145         (handle_redirections): Print debug setting.
5146         (show_logging_command): Likewise.
5147         (_initialize_cli_logging): Add debugredirect command.
5148         * interps.c (current_interp_set_logging): Add debug_redirect
5149         parameter.
5150         * interps.h (set_logging): Add debug_redirect parameter.
5151         (current_interp_set_logging): Likewise.
5152         * mi/mi-common.h: Likewise.
5153         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5154
5155 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5156             Tom Tromey  <tromey@adacore.com>
5157
5158         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5159         directly.
5160         * cli/cli-interp.h (make_logging_output): Remove declaration.
5161         * cli/cli-logging.c (make_logging_output): Remove function.
5162         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5163         directly.
5164         * ui-file.c (tee_file::tee_file): Remove bools.
5165         (tee_file::~tee_file): Remove deletes.
5166         * ui-file.h (tee_file): Remove bools.
5167
5168 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
5169
5170         * mi/mi-cmds.h (mi_cmd_complete): New function.
5171         * mi/mi-main.c (mi_cmd_complete): Likewise.
5172         * mi/mi-cmds.c: Define new MI command -complete.
5173         * NEWS: Mention new -complete command.
5174
5175 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
5176
5177         * completer.h (complete): New function.
5178         * completer.c (complete): Likewise.
5179         * cli/cli-cmds.c: (complete_command): Update to use new complete()
5180         function defined in completer.h.
5181
5182 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
5183
5184         * MAINTAINERS (Write After Approval): Add myself.
5185
5186 2019-05-17  Tom de Vries  <tdevries@suse.de>
5187
5188         PR gdb/24094
5189         * dwarf2read.c (struct cu_partial_die_info): New struct.
5190         (find_partial_die): Return cu_partial_die_info.
5191         (partial_die_parent_scope, guess_partial_die_structure_name)
5192         (partial_die_info::fixup): Handle new return type of find_partial_die.
5193
5194 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5195
5196         * stap-probe.c (stap_parse_register_operand): Make "regname" an
5197         "std::string", simplifying the algorithm.
5198
5199 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5200
5201         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5202         (stap_static_probe_ops::get_probes): Likewise.
5203
5204 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5205
5206         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5207         '-')" and "else if".
5208         (stap_parse_single_operand): Join checks for
5209         "gdbarch_stap_parse_special_token_p" and
5210         "gdbarch_stap_parse_special_token" in the same "if" statement.
5211         Invert check when verifying for operation on register
5212         displacement.
5213
5214 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5215
5216         * stap-probe.c (stap_get_opcode): Update comment.
5217         (stap_get_expected_argument_type): Likewise.
5218         (handle_stap_probe): Likewise.
5219
5220 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5221
5222         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5223         return type to 'bool'.  Adjust comment.  Use 'bool' when
5224         appropriate.
5225         (i386_stap_parse_special_token_three_arg_disp): Likewise.
5226         * stap-probe.c (stap_parse_argument_1): Likewise.
5227         (stap_is_operator): Likewise.
5228         (stap_is_generic_prefix): Likewise.
5229         (stap_is_register_prefix): Likewise.
5230         (stap_is_register_indirection_prefix): Likewise.
5231         (stap_is_integer_prefix): Likewise.
5232         (stap_generic_check_suffix): Likewise.
5233         (stap_check_integer_suffix): Likewise.
5234         (stap_check_register_suffix): Likewise.
5235         (stap_check_register_indirection_suffix): Likewise.
5236         (stap_parse_register_operand): Likewise.
5237         (stap_parse_single_operand): Likewise.
5238         (stap_parse_argument_1): Likewise.
5239         (stap_probe::get_argument_count): Likewise.
5240         (stap_is_operator): Likewise.
5241
5242 2019-05-16  Tom Tromey  <tromey@adacore.com>
5243
5244         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5245         keyword to foreach.
5246
5247 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
5248
5249         * linux-thread-db.c (try_thread_db_load_1): Change return type
5250         to bool.
5251         (try_thread_db_load): Likewise.
5252         (try_thread_db_load_from_pdir_1): Likewise.
5253         (try_thread_db_load_from_pdir): Likewise.
5254         (try_thread_db_load_from_sdir): Likewise.
5255         (try_thread_db_load_from_dir): Likewise.
5256         (thread_db_load_search): Likewise.
5257         (has_libpthread): Likewise.
5258         (thread_db_load): Likewise.
5259
5260 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
5261
5262         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5263         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5264         NULL, and complain/return if that's the case.
5265
5266 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5267
5268         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5269         (advance, posn, abstract_read_memory): New functions.
5270         [struct mem_read_abstraction]: New struct.
5271         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5272
5273 2019-05-14  Tom Tromey  <tromey@adacore.com>
5274
5275         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5276         value is not lval_memory.
5277
5278 2019-05-14  Tom Tromey  <tromey@adacore.com>
5279
5280         * solib.c (info_sharedlibrary_command): Style the file name.
5281
5282 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
5283
5284         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5285         (aarch64_vnv_type): Likewise.
5286         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5287         * common/tdesc.c: Likewise.
5288         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5289         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5290         * features/aarch64-fpu.xml: Add ieee half view.
5291         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5292         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5293         * gdbtypes.h (struct builtin_type): Likewise.
5294         (struct objfile_type): Likewise.
5295
5296 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5297
5298         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5299         typo.
5300         * location.h (string_to_event_location): Likewise.
5301
5302 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5303
5304         GDB 8.3 released.
5305
5306 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5307
5308         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5309         New variable declaration.
5310         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5311         New variable.
5312         (print_one_breakpoint): Use ui_out::test_flags and new global
5313         variable to compute use_fixed_output.
5314         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5315         Remove.
5316         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5317         (mi_multi_location_breakpoint_output_fixed): Remove.
5318         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5319         new variable.
5320         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5321         fix_multi_location_breakpoint_output flag if version >= 3.
5322         * ui-out.h (enum ui_out_flag)
5323         <fix_multi_location_breakpoint_output>: New enumerator.
5324
5325 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5326
5327         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5328
5329 2019-05-10  Tom Tromey  <tromey@adacore.com>
5330
5331         * ada-lang.c (catch_ada_completer): New function.
5332         (_initialize_ada_language): Use it.
5333
5334 2019-05-10  Tom Tromey  <tromey@adacore.com>
5335
5336         * thread.c (print_thread_info): Make "requested_threads" const.
5337         * gdbthread.h (print_thread_info): Make "requested_threads"
5338         const.
5339         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5340         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5341
5342 2019-05-08  Tom Tromey  <tom@tromey.com>
5343
5344         * gdbtypes.c (objfile_type_data): Change type.
5345         (objfile_type, _initialize_gdbtypes): Update.
5346
5347 2019-05-08  Tom Tromey  <tom@tromey.com>
5348
5349         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5350         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5351         (_initialize_dwarf2_frame): Update.
5352
5353 2019-05-08  Tom Tromey  <tom@tromey.com>
5354
5355         * objc-lang.c (objc_objfile_data): Change type.
5356         (find_methods): Update.
5357         (_initialize_objc_lang): Remove.
5358
5359 2019-05-08  Tom Tromey  <tom@tromey.com>
5360
5361         * stabsread.c (rs6000_builtin_type_data): Change type.
5362         (rs6000_builtin_type, _initialize_stabsread): Update.
5363
5364 2019-05-08  Tom Tromey  <tom@tromey.com>
5365
5366         * mips-tdep.c (mips_pdr_data): Remove.
5367         (_initialize_mips_tdep): Update.
5368
5369 2019-05-08  Tom Tromey  <tom@tromey.com>
5370
5371         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5372         (hppa_init_objfile_priv_data, read_unwind_info)
5373         (find_unwind_entry, _initialize_hppa_tdep): Update.
5374
5375 2019-05-08  Tom Tromey  <tom@tromey.com>
5376
5377         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5378         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5379         on obstack.
5380         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5381
5382 2019-05-08  Tom Tromey  <tom@tromey.com>
5383
5384         * mdebugread.c (basic_type_data): Change type.
5385         (basic_type, _initialize_mdebugread): Update.
5386
5387 2019-05-08  Tom Tromey  <tom@tromey.com>
5388
5389         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5390
5391 2019-05-08  Tom Tromey  <tom@tromey.com>
5392
5393         * nto-tdep.c (nto_inferior_data_reg): Change type.
5394         (nto_inferior_data): Update.
5395         (nto_inferior_data_cleanup, nto_new_inferior_data)
5396         (_initialize_nto_tdep): Remove.
5397         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5398
5399 2019-05-08  Tom Tromey  <tom@tromey.com>
5400
5401         * ada-lang.c (struct ada_inferior_data): Add initializers.
5402         (ada_inferior_data): Change type.
5403         (ada_inferior_data_cleanup): Remove.
5404         (get_ada_inferior_data, ada_inferior_exit)
5405         (struct ada_pspace_data): Add initializers, destructor.
5406         (ada_pspace_data_handle): Change type.
5407         (get_ada_pspace_data): Update.
5408         (ada_pspace_data_cleanup): Remove.
5409
5410 2019-05-08  Tom Tromey  <tom@tromey.com>
5411
5412         * coffread.c (struct coff_symfile_info): Add initializers.
5413         (coff_objfile_data_key): Move lower.  Change type.
5414         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5415         Update.
5416         (coff_free_info): Remove.
5417
5418 2019-05-08  Tom Tromey  <tom@tromey.com>
5419
5420         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5421         (fbsd_pspace_data_handle): Move lower.  Change type.
5422         (get_fbsd_pspace_data): Update.
5423         (fbsd_pspace_data_cleanup): Remove.
5424         (_initialize_fbsd_tdep): Update.
5425
5426 2019-05-08  Tom Tromey  <tom@tromey.com>
5427
5428         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5429         (get_ada_tasks_pspace_data): Update.
5430         (ada_tasks_pspace_data_cleanup): Remove.
5431         (_initialize_tasks): Update.
5432         (ada_tasks_inferior_data_handle): Change type.
5433         (get_ada_tasks_inferior_data): Update.
5434         (ada_tasks_inferior_data_cleanup): Remove.
5435         (struct ada_tasks_pspace_data): Add initializers.
5436
5437 2019-05-08  Tom Tromey  <tom@tromey.com>
5438
5439         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5440         * symfile-debug.c (debug_sym_get_probes): Change type.
5441         * stap-probe.c (handle_stap_probe):
5442         (stap_static_probe_ops::get_probes): Change type.
5443         * probe.h (class static_probe_ops) <get_probes>: Change type.
5444         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5445         (parse_probes_in_pspace): Update.
5446         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5447         Update.
5448         (any_static_probe_ops::get_probes): Change type.
5449         * elfread.c (elfread_data): New typedef.
5450         (probe_key): Change type.
5451         (elf_get_probes): Likewise.  Update.
5452         (probe_key_free): Remove.
5453         (_initialize_elfread): Update.
5454         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5455         Change type.
5456         (dtrace_process_dof_probe, dtrace_process_dof)
5457         (dtrace_static_probe_ops::get_probe): Change type.
5458
5459 2019-05-08  Tom Tromey  <tom@tromey.com>
5460
5461         * xcoffread.c (struct xcoff_symfile_info): Rename from
5462         coff_symfile_info.  Add initializers.
5463         (xcoff_objfile_data_key): Move lower.  Change type.
5464         (XCOFF_DATA): Rewrite.
5465         (xcoff_free_info): Remove.
5466         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5467         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5468         (xcoff_initial_scan): Update.
5469
5470 2019-05-08  Tom Tromey  <tom@tromey.com>
5471
5472         * solib-svr4.c (struct svr4_info): Add initializers and
5473         destructor.
5474         <probes_table>: Now an htab_up.
5475         (solib_svr4_pspace_data): Change type.
5476         (free_probes_table): Simplify.
5477         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5478         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5479         (probes_table_remove_objfile_probes, register_solib_event_probe)
5480         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5481         (_initialize_svr4_solib): Update.
5482
5483 2019-05-08  Tom Tromey  <tom@tromey.com>
5484
5485         * remote.c (remote_pspace_data): Change type.
5486         (remote_pspace_data_cleanup): Remove.
5487         (get_remote_exec_file, set_pspace_remote_exec_file)
5488         (_initialize_remote): Update.
5489
5490 2019-05-08  Tom Tromey  <tom@tromey.com>
5491
5492         * breakpoint.c (breakpoint_objfile_key): Change type.
5493         (get_breakpoint_objfile_data): Update.
5494         (free_breakpoint_objfile_data): Remove.
5495         (_initialize_breakpoint): Update.
5496
5497 2019-05-08  Tom Tromey  <tom@tromey.com>
5498
5499         * linux-tdep.c (struct linux_info): Add initializers.
5500         (linux_inferior_data): Move.  Change type.
5501         (invalidate_linux_cache_inf): Update.
5502         (linux_inferior_data_cleanup): Remove.
5503         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5504
5505 2019-05-08  Tom Tromey  <tom@tromey.com>
5506
5507         * auxv.c (auxv_inferior_data): Move.  Change type.
5508         (auxv_inferior_data_cleanup): Remove.
5509         (invalidate_auxv_cache_inf): Rewrite.
5510         (get_auxv_inferior_data, _initialize_auxv): Update.
5511
5512 2019-05-08  Tom Tromey  <tom@tromey.com>
5513
5514         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5515         (symfile_debug_objfile_data_key): Change type.
5516         (symfile_debug_installed, debug_qf_has_symbols)
5517         (debug_qf_find_last_source_symtab)
5518         (debug_qf_forget_cached_source_info)
5519         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5520         (debug_qf_print_stats, debug_qf_dump)
5521         (debug_qf_expand_symtabs_for_function)
5522         (debug_qf_expand_all_symtabs)
5523         (debug_qf_expand_symtabs_with_fullname)
5524         (debug_qf_map_matching_symbols)
5525         (debug_qf_expand_symtabs_matching)
5526         (debug_qf_find_pc_sect_compunit_symtab)
5527         (debug_qf_map_symbol_filenames)
5528         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5529         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5530         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5531         (debug_sym_read_linetable, debug_sym_relocate): Update.
5532         (symfile_debug_free_objfile): Remove.
5533         (install_symfile_debug_logging, _initialize_symfile_debug):
5534         Update.
5535
5536 2019-05-08  Tom Tromey  <tom@tromey.com>
5537
5538         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5539         allocate_on_obstack.
5540         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5541         (get_dwarf2_per_objfile): Update.
5542         (set_dwarf2_per_objfile): Remove.
5543         (dwarf2_has_info, dwarf2_get_section_info): Update.
5544         (dwarf2_free_objfile): Remove.
5545         (_initialize_dwarf2_read): Update.
5546
5547 2019-05-08  Tom Tromey  <tom@tromey.com>
5548
5549         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5550         initializers.
5551         <unsupported_script_warning_printed,
5552         script_not_found_warning_printed>: Now bool.
5553         (auto_load_pspace_data): Change type.
5554         (~auto_load_pspace_info): Rename from
5555         auto_load_pspace_data_cleanup.
5556         (get_auto_load_pspace_data, init_loaded_scripts_info)
5557         (clear_section_scripts, maybe_print_unsupported_script_warning)
5558         (maybe_print_script_not_found_warning, _initialize_auto_load):
5559         Update.
5560
5561 2019-05-08  Tom Tromey  <tom@tromey.com>
5562
5563         * objfiles.c (objfile_pspace_info): Add destructor and
5564         initializers.
5565         (objfiles_pspace_data): Change type.
5566         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5567         (get_objfile_pspace_data): Update.
5568         (objfiles_bfd_data): Change type.
5569         (get_objfile_bfd_data): Update.
5570         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5571
5572 2019-05-08  Tom Tromey  <tom@tromey.com>
5573
5574         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5575         Change type.
5576         (get_catch_syscall_inferior_data): Update.
5577         (catch_syscall_inferior_data_cleanup): Remove.
5578         (_initialize_break_catch_syscall): Update.
5579
5580 2019-05-08  Tom Tromey  <tom@tromey.com>
5581
5582         * inflow.c (struct terminal_info): Add destructor and
5583         initializers.
5584         (inflow_inferior_data): Change type.
5585         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5586         (get_inflow_inferior_data, inflow_inferior_exit)
5587         (swap_terminal_info, _initialize_inflow): Update.
5588
5589 2019-05-08  Tom Tromey  <tom@tromey.com>
5590
5591         * target-dcache.c (target_dcache_cleanup): Remove.
5592         (target_dcache_aspace_key): Change type.
5593         (target_dcache_init_p, target_dcache_invalidate)
5594         (target_dcache_get, target_dcache_get_or_init)
5595         (_initialize_target_dcache): Update.
5596         * dcache.h (struct dcache_deleter): New.
5597
5598 2019-05-08  Tom Tromey  <tom@tromey.com>
5599
5600         * symtab.c (struct symbol_cache): Add destructor and
5601         initializers.
5602         (symbol_cache_key): Move.  Change type.
5603         (make_symbol_cache, free_symbol_cache): Remove.
5604         (get_symbol_cache): Update.
5605         (symbol_cache_cleanup): Remove.
5606         (ALL_PSPACES, symbol_cache_flush)
5607         (maintenance_print_symbol_cache)
5608         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5609         Update.
5610
5611 2019-05-08  Tom Tromey  <tom@tromey.com>
5612
5613         * symtab.c (struct main_info): Add destructor and initializers.
5614         (main_progspace_key): Move.  Change type.
5615         (get_main_info): Update.
5616         (main_info_cleanup): Remove.
5617         (_initialize_symtab): Update.
5618
5619 2019-05-08  Tom Tromey  <tom@tromey.com>
5620
5621         * registry.h (DECLARE_REGISTRY): Define the _key class.
5622
5623 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5624
5625         * NEWS: Merge two 'New commands' sections.
5626
5627 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5628
5629         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5630         parameter and use Ada language definition instead.
5631         (ada_val_print_ptr): Remove unused language parameter.
5632         (ada_val_print_num): Remove language parameter and use Ada language
5633         definition instead.
5634         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5635         parameter.
5636         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5637         parameter and use Ada language definition instead.
5638         (ada_val_print_1): Update all ada_val_print_xxx calls.
5639         Remove language parameter.
5640         (ada_val_print): Update ada_val_print_1 call.
5641
5642 2019-05-08  Tom Tromey  <tromey@adacore.com>
5643
5644         * remote.c (remote_hw_watchpoint_limit)
5645         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5646         Now static.
5647
5648 2019-05-08  Tom Tromey  <tromey@adacore.com>
5649
5650         * maint.c (_initialize_maint_cmds): Move initialization code to
5651         remote.c.
5652         (watchdog, show_watchdog): Move to remote.c.
5653         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5654         "watchdog" static.
5655         (_initialize_remote): Move initialization code from maint.c.
5656         * defs.h (watchdog): Don't declare.
5657
5658 2019-05-08  Tom Tromey  <tromey@adacore.com>
5659
5660         * tui/tui-interp.c: Include main.h.
5661         * interps.c: Include main.h.
5662         * main.h (interpreter_p): Declare.
5663         * defs.h (interpreter_p): Don't declare.
5664
5665 2019-05-08  Tom Tromey  <tromey@adacore.com>
5666
5667         * dwarf2loc.c: Include dwarf2read.h.
5668         * defs.h (read_unsigned_leb128): Don't declare.
5669         * dwarf2read.h (read_unsigned_leb128): Declare.
5670
5671 2019-05-08  Tom Tromey  <tromey@adacore.com>
5672
5673         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5674         method.
5675
5676 2019-05-08  Tom Tromey  <tromey@adacore.com>
5677
5678         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5679         when no wrap column is set.
5680
5681 2019-05-08  Tom Tromey  <tromey@adacore.com>
5682
5683         * c-lang.c (c_get_string): Handle non-C-style arrays.
5684
5685 2019-05-08  Tom Tromey  <tromey@adacore.com>
5686
5687         * typeprint.c (print_offset_data::update): Print the bit offset,
5688         not the number of bits remaining.
5689
5690 2019-05-08  Tom Tromey  <tromey@adacore.com>
5691
5692         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5693         padding at end of comment.
5694
5695 2019-05-08  Tom Tromey  <tromey@adacore.com>
5696
5697         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5698         Compare main types.
5699
5700 2019-05-06  Tom Tromey  <tom@tromey.com>
5701
5702         * common/scoped_mmap.c: Include common-defs.h.
5703         * common/scoped_mmap.h: Don't include config.h.
5704
5705 2019-05-04  Tom Tromey  <tom@tromey.com>
5706
5707         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5708         (struct aarch64_call_info): Add initializers.
5709         <si>: Now a std::vector.
5710         (pass_on_stack, aarch64_push_dummy_call): Update.
5711
5712 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5713             Tom Tromey  <tom@tromey.com>
5714
5715         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5716         (ppc_threads): Now a std::vector.  Now static.
5717         (hwdebug_find_thread_points_by_tid)
5718         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5719         Update.
5720
5721 2019-05-04  Tom Tromey  <tom@tromey.com>
5722
5723         * arc-tdep.c (arc_tdesc_init): Return bool.
5724
5725 2019-05-04  Tom Tromey  <tom@tromey.com>
5726
5727         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5728         Use gdb_assert_not_reached.
5729
5730 2019-05-04  Tom Tromey  <tom@tromey.com>
5731
5732         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5733         "false".
5734
5735 2019-05-04  Tom Tromey  <tom@tromey.com>
5736
5737         * arc-tdep.c (arc_tdesc_init): Use bool.
5738
5739 2019-05-04  Tom Tromey  <tom@tromey.com>
5740
5741         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5742
5743 2019-05-04  Tom Tromey  <tom@tromey.com>
5744
5745         * cli/cli-cmds.c (valid_command_p): Return bool.
5746
5747 2019-05-04  Tom Tromey  <tom@tromey.com>
5748
5749         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5750         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5751
5752 2019-05-04  Raul Tambre  <raul@tambre.ee>
5753
5754         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5755         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5756         operator for comparison.
5757
5758 2019-05-04  Tom Tromey  <tom@tromey.com>
5759
5760         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5761         (lookup_partial_symbol, print_partial_symbols)
5762         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5763         (psymbol_compare): Update.
5764         (add_psymbol_to_bcache): Clear the entire psymbol.
5765         (maintenance_check_psymtabs): Update.
5766         * psympriv.h (struct partial_symbol): Don't derive from
5767         general_symbol_info.
5768         <obj_section, unrelocated_address, address,
5769         set_unrelocated_address>: Update.
5770         <ginfo>: New member.
5771         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5772         (debug_names::write_psymbols): Update.
5773
5774 2019-05-04  Tom de Vries  <tdevries@suse.de>
5775
5776         * contrib/cc-with-tweaks.sh: Support -n arg.
5777
5778 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5779
5780         * corelow.c (core_target::detach): Ensure frame cache and
5781         register caches are cleared.
5782         inferior.c (exit_inferior_1): Likewise.
5783
5784 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5785             Tom Tromey  <tom@tromey.com>
5786
5787         * dictionary.c (collate_pending_symbols_by_language): Remove
5788         "struct" from foreach.
5789         * symtab.c (lookup_global_symbol_from_objfile)
5790         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5791         foreach.
5792         * ser-tcp.c (net_open): Remove "struct" from foreach.
5793         * objfiles.c (objfile_relocate, objfile_rebase)
5794         (objfile_has_symbols): Remove "struct" from foreach.
5795         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5796         from foreach.
5797         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5798         foreach.
5799         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5800         "struct" from foreach.
5801         * ada-lang.c (create_excep_cond_exprs)
5802         (ada_exception_catchpoint_cond_string): Remove "struct" from
5803         foreach.
5804
5805 2019-05-03  Tom Tromey  <tromey@adacore.com>
5806
5807         * ada-exp.y (convert_char_literal): Check suffix of each
5808         enumerator.
5809
5810 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5811
5812         PR ada/21406:
5813         * ada-exp.y (yywrap): Don't define.
5814         * ada-lex.l (%option): Add noyywrap
5815         (yywrap): Remove.
5816
5817 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5818
5819         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5820         _WIN32_WINNT to the XP level, unless already defined to a higher
5821         level.
5822
5823         * unittests/parse-connection-spec-selftests.c:
5824         * ser-tcp.c:
5825         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5826         override.
5827
5828         * symfile.c (find_separate_debug_file): Remove colon from the
5829         drive spec of DOS/Windows file names of the target, so that the
5830         file name produced from DEBUGDIR and the target's directory will
5831         be valid on DOS/Windows systems.
5832
5833 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5834
5835         * rust-lang.c (val_print_struct): Handle printing structures
5836         containing strings.
5837
5838 2019-05-02  Tom Tromey  <tromey@adacore.com>
5839
5840         * valarith.c (_initialize_valarith): Remove.
5841
5842 2019-05-01  Tom Tromey  <tromey@adacore.com>
5843
5844         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5845         bitfields.
5846
5847 2019-05-01  Tom Tromey  <tromey@adacore.com>
5848
5849         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5850         for big-endian copies.
5851
5852 2019-04-30  Ali Tamur  <tamur@google.com>
5853         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5854         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5855         (read_3_bytes): New function.
5856
5857 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5858
5859         * windows-nat.c (main_thread_id): Delete.
5860         (handle_output_debug_string): Replace main_thread_id by
5861         current_event.dwThreadId.
5862         (fake_create_process): Likewise.
5863         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5864         Do not set main_thread_id.
5865         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5866         current_event.dwThreadId.
5867         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5868
5869 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5870
5871         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5872         Use current_event.dwThreadId instead of main_thread_id.
5873
5874 2019-04-30  Tom Tromey  <tromey@adacore.com>
5875
5876         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5877         (create_excep_cond_exprs): Iterate over program spaces.
5878         (ada_exception_catchpoint_cond_string): Examine all minimal
5879         symbols for exception types.
5880
5881 2019-04-30  Tom Tromey  <tromey@adacore.com>
5882
5883         PR c++/24470:
5884         * dwarf2read.c (process_structure_scope): Handle case where type
5885         has template parameters but no symbol was created.
5886
5887 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5888             Chris January  <chris.january@arm.com>
5889
5890         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5891         qualifier.
5892         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5893
5894 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5895
5896         * f-typeprint.c (f_print_type): Update rules for printing
5897         whitespace.
5898         (f_type_print_varspec_suffix): Likewise.
5899
5900 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5901             Chris January  <chris.january@arm.com>
5902
5903         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5904         function arguments.
5905
5906 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5907
5908         * f-lang.c (build_fortran_types): Change name of void type to
5909         lower case.
5910         * f-typeprint.c (f_type_print_base): Print the name of the void
5911         type, rather than a fixed string.
5912         * f-valprint.c (f_decorations): Use lower case void string.
5913
5914 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5915             Chris January  <chris.january@arm.com>
5916
5917         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5918         types for Fortran.
5919
5920 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5921             Chris January  <chris.january@arm.com>
5922             David Lecomber  <david.lecomber@arm.com>
5923
5924         * f-exp.y (BINOP_INTRINSIC): New token.
5925         (exp): New parser rule handling BINOP_INTRINSIC.
5926         (f77_keywords): Add new builtin procedures.
5927         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5928         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5929         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5930         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5931         (print_unop_subexp_f): New function.
5932         (print_binop_subexp_f): New function.
5933         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5934         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5935         (dump_subexp_body_f): Likewise.
5936         (operator_check_f): Likewise.
5937         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5938         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5939
5940 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5941
5942         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5943         UNOP_KIND.
5944         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5945         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5946         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5947         (operator_length_f): New fuction.
5948         (print_subexp_f): New function.
5949         (op_name_f): New function.
5950         (dump_subexp_body_f): New function.
5951         (operator_check_f): New function.
5952         (exp_descriptor_f): Replace standard expression handling functions
5953         with new functions.
5954         * gdb/fortran-operator.def: New file.
5955         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5956         * gdb/std-operator.def: Remove UNOP_KIND.
5957
5958 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5959
5960         * std-operator.def: Remove unbalanced, stray double quote
5961         character.
5962
5963 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5964             Chris January  <chris.january@arm.com>
5965             Daniel Everett  <daniel.everett@arm.com>
5966             Nick Forrington  <nick.forrington@arm.com>
5967             Richard Bunt  <richard.bunt@arm.com>
5968
5969         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5970         of depth when printing anonymous structs or unions.
5971         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5972         Don't print either the top-level value, or the children if the
5973         max-depth is exceeded.
5974         (ppscm_print_children): When printing the key of a map, allow one
5975         extra level of depth.
5976         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5977         print either the top-level value, or the children if the max-depth
5978         is exceeded.
5979         (print_children): When printing the key of a map, allow one extra
5980         level of depth.
5981         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5982         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5983         (user_print_options): Initialise max_depth field.
5984         (val_print_scalar_or_string_type_p): New function.
5985         (val_print): Check to see if the max depth has been reached.
5986         (val_print_check_max_depth): Define new function.
5987         (show_print_max_depth): New function.
5988         (_initialize_valprint): Add 'print max-depth' option.
5989         * valprint.h (struct value_print_options) <max_depth>: New field.
5990         (val_print_check_max_depth): Declare new function.
5991         * NEWS: Document new feature.
5992
5993 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5994
5995         * ada-lang.c (ada_language_defn): Initialise new field.
5996         * c-lang.c (c_is_string_type_p): New function.
5997         (c_language_defn): Initialise new field.
5998         (cplus_language_defn): Initialise new field.
5999         (asm_language_defn): Initialise new field.
6000         (minimal_language_defn): Initialise new field.
6001         * c-lang.h (c_is_string_type_p): Declare new function.
6002         * d-lang.c (d_language_defn): Initialise new field.
6003         * f-lang.c (f_is_string_type_p): New function.
6004         (f_language_defn): Initialise new field.
6005         * go-lang.c (go_is_string_type_p): New function.
6006         (go_language_defn): Initialise new field.
6007         * language.c (default_is_string_type_p): New function.
6008         (unknown_language_defn): Initialise new field.
6009         (auto_language_defn): Initialise new field.
6010         * language.h (struct language_defn) <la_is_string_type_p>: New
6011         member variable.
6012         (default_is_string_type_p): Declare new function.
6013         * m2-lang.c (m2_language_defn): Initialise new field.
6014         * objc-lang.c (objc_language_defn): Initialise new field.
6015         * opencl-lang.c (opencl_language_defn): Initialise new field.
6016         * p-lang.c (pascal_is_string_type_p): New function.
6017         (pascal_language_defn): Initialise new field.
6018         * rust-lang.c (rust_is_string_type_p): New function.
6019         (rust_language_defn): Initialise new field.
6020
6021 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6022
6023         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
6024         New field.
6025         * ada-lang.c (ada_language_defn): Initialise new field.
6026         * c-lang.c (c_language_defn): Likewise.
6027         (cplus_language_defn): Likewise.
6028         (asm_language_defn): Likewise.
6029         (minimal_language_defn): Likewise.
6030         * d-lang.c (d_language_defn): Likewise.
6031         * f-lang.c (f_language_defn): Likewise.
6032         * go-lang.c (go_language_defn): Likewise.
6033         * language.c (unknown_language_defn): Likewise.
6034         (auto_language_defn): Likewise.
6035         * m2-lang.c (m2_language_defn): Likewise.
6036         * objc-lang.c (objc_language_defn): Likewise.
6037         * opencl-lang.c (opencl_language_defn): Likewise.
6038         * p-lang.c (pascal_language_defn): Likewise.
6039         * rust-lang.c (rust_language_defn): Likewise.
6040
6041 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6042
6043         * ada-lang.c (ada_is_character_type): Change return type to bool.
6044         (ada_is_string_type): Likewise.
6045         * ada-lang.h (ada_is_character_type): Update declaration
6046         (ada_is_string_type): Likewise.
6047
6048 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6049
6050         Support style in 'frame|thread apply'
6051
6052         * gdbcmd.h (execute_command_to_string): New term_out parameter.
6053         * record.c (record_start, record_stop): Update callers of
6054         execute_command_to_string with false.
6055         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6056         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6057         methods.
6058         (class string_file): New constructor with term_out parameter.
6059         Override methods term_out and can_emit_style_escape.  New member
6060         term_out.
6061         (class stdio_file): Override can_emit_style_escape.
6062         (class tee_file): Override term_out and can_emit_style_escape.
6063         * utils.h (can_emit_style_escape): Remove.
6064         * utils.c (can_emit_style_escape): Likewise.
6065         Update all callers of can_emit_style_escape (SOMESTREAM) to
6066         SOMESTREAM->can_emit_style_escape.
6067         * source-cache.c (source_cache::get_source_lines): Likewise.
6068         * stack.c (frame_apply_command_count): Call execute_command_to_string
6069         passing the term_out characteristic of the current gdb_stdout.
6070         * thread.c (thr_try_catch_cmd): Likewise.
6071         * top.c (execute_command_to_string): pass term_out parameter
6072         to construct the string_file for the command output.
6073         * ui-file.c (term_cli_styling): New function (most code moved
6074         from utils.c can_emit_style_escape).
6075         (string_file::string_file, string_file::can_emit_style_escape,
6076         stdio_file::can_emit_style_escape, tee_file::term_out,
6077         tee_file::can_emit_style_escape): New functions.
6078
6079 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6080
6081         * NEWS: Mention the new set|show may-call-functions.
6082         * infcall.c (may_call_functions_p): New variable.
6083         (show_may_call_functions_p): New function.
6084         (call_function_by_hand_dummy): Throws an error if not
6085         may-call-functions.
6086         (_initialize_infcall): Call add_setshow_boolean_cmd for
6087         may-call-functions.
6088
6089 2019-04-25  Keith Seitz  <keiths@redhat.com>
6090
6091         PR c++/24367
6092         * cp-support.c (inspect_type): Don't attempt substitutions
6093         of symbol with the same name.
6094
6095 2019-04-25  Tom Tromey  <tromey@adacore.com>
6096
6097         PR gdb/24475:
6098         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6099         static.
6100
6101 2019-04-25  Tom Tromey  <tromey@adacore.com>
6102
6103         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6104         rvalue reference.
6105         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6106         (gdb_xml_parser::parse): Use std::move.
6107         * python/python-internal.h (gdbpy_convert_exception): Take a const
6108         reference.
6109         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6110         std::move.
6111         * python/py-utils.c (gdbpy_convert_exception): Take a const
6112         reference.
6113         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6114         Use std::move.
6115         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6116         Use std::move.
6117         * mi/mi-main.c (mi_print_exception): Take a const reference.
6118         * main.c (handle_command_errors): Take a const reference.
6119         * linespec.c (parse_linespec): Use std::move.
6120         * infcall.c (run_inferior_call): Use std::move.
6121         (call_function_by_hand_dummy): Use std::move.
6122         * exec.c (try_open_exec_file): Use std::move.
6123         * exceptions.h (exception_print, exception_fprintf)
6124         (exception_print_same): Update.
6125         * exceptions.c (print_exception, exception_print)
6126         (exception_fprintf, exception_print_same): Change parameters to
6127         const reference.
6128         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6129         * common/new-op.c: Use std::move.
6130         * common/common-exceptions.h (struct gdb_exception): Add move
6131         constructor.
6132         (struct gdb_exception_error, struct gdb_exception_quit, struct
6133         gdb_quit_bad_alloc): Change constructor to move constructor.
6134         (throw_exception): Change parameter to rvalue reference.
6135         * common/common-exceptions.c (throw_exception): Take rvalue
6136         reference.
6137         * cli/cli-interp.c (safe_execute_command): Use std::move.
6138         * breakpoint.c (insert_bp_location, location_to_sals): Use
6139         std::move.
6140
6141 2019-04-25  Tom Tromey  <tromey@adacore.com>
6142
6143         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6144         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6145         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6146         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6147         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6148         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6149         guile/scm-value.c: Use unpack.
6150         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6151         gdbscm_gdb_exception.
6152         (gdbscm_throw_gdb_exception): Likewise.
6153         (struct gdbscm_gdb_exception): New.
6154         (unpack): New function.
6155         (gdbscm_wrap): Use unpack.
6156
6157 2019-04-25  Tom Tromey  <tromey@adacore.com>
6158
6159         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6160         (gdb_rl_callback_handler): Use std::move.
6161         * common/common-exceptions.h (struct gdb_exception): Add move
6162         assignment operator.
6163         (throw_exception_sjlj): Change "exception" to const reference.
6164         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6165         (throw_exception_sjlj): Change "exception" to const reference.
6166
6167 2019-04-25  Tom Tromey  <tromey@adacore.com>
6168
6169         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6170         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6171         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6172         Update.
6173         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6174         Update.
6175         * mi/mi-interp.c (mi_interp::exec): Update.
6176         * linespec.c (parse_linespec): Update.
6177         * infcall.c (run_inferior_call): Update.
6178         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6179         * guile/scm-symbol.c (gdbscm_lookup_symbol)
6180         (gdbscm_lookup_global_symbol): Update.
6181         * guile/scm-param.c (gdbscm_parameter_value): Update.
6182         * guile/scm-frame.c (gdbscm_frame_read_register)
6183         (gdbscm_frame_read_var): Update.
6184         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6185         * exec.c (try_open_exec_file): Update.
6186         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6187         (gdb_rl_callback_handler): Update.
6188         * common/common-exceptions.h (exception_none): Don't declare.
6189         * common/common-exceptions.c (exception_none): Don't define.
6190         (struct catcher) <exception>: Update.
6191         * cli/cli-interp.c (safe_execute_command): Update.
6192         * breakpoint.c (insert_bp_location, location_to_sals): Update.
6193
6194 2019-04-25  Ali Tamur  <tamur@google.com>
6195
6196         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6197         (read_attribute_value): Likewise.
6198         (dwarf2_read_addr_index): Update comment.
6199         (read_str_index): Add DW_FORM_strx.
6200         (dwarf2_string_attr): Likewise.
6201         (dwarf2_const_value_attr): Likewise.
6202         (dump_die_shallow): Likewise.
6203         (dwarf2_fetch_constant_bytes): Likewise.
6204         (skip_form_bytes): Likewise.
6205         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6206
6207 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
6208
6209         PR corefiles/11608
6210         PR corefiles/18187
6211         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6212         OFFSET.  Verify if current mapping contains an ELF header.
6213         (linux_find_memory_regions_full): Adjust call to
6214         dump_mapping_p.
6215
6216 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
6217             Kang Li <kanglictf@gmail.com>
6218
6219         PR gdb/21600
6220
6221         * dwarf2-frame.c (read_initial_length): Be consistent about using
6222         unsigned representation of length.
6223         (decode_frame_entry_1): Likewise.  Check for wraparound of
6224         end pointer as well as buffer overflow.
6225
6226 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
6227
6228         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6229         "vq".
6230
6231 2019-04-24  Tom Tromey  <tromey@adacore.com>
6232
6233         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6234
6235 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6236
6237         * s12z-tdep.c (s12z_unwind_pc): Delete.
6238         (s12z_unwind_sp): Delete.
6239         (s12z_gdbarch_init): Don't register deleted functions with
6240         gdbarch.
6241
6242 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6243
6244         * rl78-tdep.c (rl78_unwind_sp): Delete.
6245         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6246
6247 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6248
6249         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6250         (xstormy16_unwind_pc): Delete.
6251         (xstormy16_dummy_id): Delete.
6252         (xstormy16_gdbarch_init): Don't register deleted functions with
6253         gdbarch.
6254
6255 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6256
6257         * vax-tdep.c (vax_unwind_pc): Delete.
6258         (vax_gdbarch_init): Don't register deleted function with gdbarch.
6259
6260 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6261
6262         * v850-tdep.c (v850_unwind_sp): Delete.
6263         (v850_unwind_pc): Delete.
6264         (v850_dummy_id): Delete.
6265         (v850_gdbarch_init): Don't register deleted functions with
6266         gdbarch.
6267
6268 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6269
6270         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6271         (tilegx_unwind_pc): Delete.
6272         (tilegx_unwind_dummy_id): Delete.
6273         (tilegx_gdbarch_init): Don't register deleted functions with
6274         gdbarch.
6275
6276 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6277
6278         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6279         (tic6x_dummy_id): Delete.
6280         (tic6x_gdbarch_init): Don't register deleted functions with
6281         gdbarch.
6282
6283 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6284
6285         * sparc-tdep.c (sparc_unwind_pc): Delete.
6286         (sparc32_gdbarch_init): Don't register deleted function with
6287         gdbarch.
6288
6289 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6290
6291         * sh-tdep.c (sh_unwind_sp): Delete.
6292         (sh_unwind_pc): Delete.
6293         (sh_dummy_id): Delete.
6294         (sh_gdbarch_init): Don't register deleted functions with
6295         gdbarch.
6296
6297 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6298
6299         * score-tdep.c (score_unwind_sp): Delete.
6300         (score_unwind_pc): Delete.
6301         (score_dummy_id): Delete.
6302         (score_gdbarch_init): Don't register deleted functions with
6303         gdbarch.
6304
6305 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6306
6307         * rx-tdep.c (rx_unwind_pc): Delete.
6308         (rx_unwind_sp): Delete.
6309         (rx_dummy_id): Delete.
6310         (rx_gdbarch_init): Don't register deleted functions with
6311         gdbarch.  Update comment.
6312
6313 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6314
6315         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6316         (rs6000_dummy_id): Delete.
6317         (rs6000_gdbarch_init): Don't register deleted functions with
6318         gdbarch.
6319
6320 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6321
6322         * or1k-tdep.c (or1k_dummy_id): Delete.
6323         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6324
6325 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6326
6327         * nios2-tdep.c (nios2_dummy_id): Delete.
6328         (nios2_unwind_sp): Delete.
6329         (nios2_gdbarch_init): Don't register deleted functions with
6330         gdbarch.
6331
6332 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6333
6334         * nds32-tdep.c (nds32_dummy_id): Delete.
6335         (nds32_unwind_pc): Delete.
6336         (nds32_unwind_sp): Delete.
6337         (nds32_gdbarch_init): Don't register deleted functions with
6338         gdbarch.
6339
6340 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6341
6342         * msp430-tdep.c (msp430_unwind_pc): Delete.
6343         (msp430_unwind_sp): Delete.
6344         (msp430_dummy_id): Delete.
6345         (msp430_gdbarch_init): Don't register deleted functions with
6346         gdbarch.
6347
6348 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6349
6350         * moxie-tdep.c (moxie_unwind_sp): Delete.
6351         (moxie_unwind_pc): Delete.
6352         (moxie_dummy_id): Delete.
6353         (moxie_gdbarch_init): Don't register deleted functions with
6354         gdbarch.
6355
6356 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6357
6358         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6359         (mn10300_unwind_pc): Delete.
6360         (mn10300_unwind_sp): Delete.
6361         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6362         mn10300_unwind_sp.
6363         (mn10300_frame_unwind_init): Don't register deleted functions with
6364         gdbarch.
6365
6366 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6367
6368         * mep-tdep.c (mep_unwind_pc): Delete.
6369         (mep_unwind_sp): Delete.
6370         (mep_dummy_id): Delete.
6371         (mep_gdbarch_init): Don't register deleted functions with
6372         gdbarch.
6373
6374 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6375
6376         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6377         (m68hc11_unwind_sp): Delete.
6378         (m68hc11_gdbarch_init): Don't register deleted functions with
6379         gdbarch.
6380
6381 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6382
6383         * m32r-tdep.c (m32r_unwind_sp): Delete.
6384         (m32r_unwind_pc): Delete.
6385         (m32r_dummy_id): Delete.
6386         (m32r_gdbarch_init): Don't register deleted functions with
6387         gdbarch.
6388
6389 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6390
6391         * m32c-tdep.c (m32c_unwind_pc): Delete.
6392         (m32c_unwind_sp): Delete.
6393         (m32c_dummy_id): Delete.
6394         (m32c_gdbarch_init): Don't register deleted functions with
6395         gdbarch.
6396
6397 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6398
6399         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6400         (lm32_unwind_pc): Delete.
6401         (lm32_dummy_id): Delete.
6402         (lm32_gdbarch_init): Don't register deleted functions with
6403         gdbarch.
6404
6405 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6406
6407         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6408         (iq2000_unwind_pc): Delete.
6409         (iq2000_dummy_id): Delete.
6410         (iq2000_gdbarch_init): Don't register deleted functions with
6411         gdbarch.
6412
6413 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6414
6415         * nds32-tdep.c (nds32_type_align): Delete.
6416         (nds32_push_dummy_call): Use type_align instead.
6417
6418 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6419
6420         * arm-tdep.c (arm_type_align): Only handle vector override case.
6421         (arm_push_dummy_call): Use type_align.
6422         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6423
6424 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6425
6426         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6427         case.
6428         (pass_on_stack): Use type_align.
6429         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6430         function.
6431
6432 2019-04-23  Tom Tromey  <tromey@adacore.com>
6433
6434         * dwarf2read.c (line_header::file_name_at): Remove unused
6435         overload.
6436
6437 2019-04-23  Tom de Vries  <tdevries@suse.de>
6438
6439         PR gdb/24438
6440         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6441         invocation.
6442
6443
6444 2019-03-27  Ali Tamur  <tamur@google.com>
6445
6446         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6447         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6448         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6449         (dwarf_expr_context::get_addr_index): Likewise
6450         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6451         (symbol_needs_eval_context::get_addr_index): Likewise
6452         (disassemble_dwarf_expression): Add DW_OP_addrx
6453         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6454         (read_cutu_die_from_dwo): Update comment
6455         (skip_one_die): Add DW_FORM_addrx
6456         (read_attribute_value): Likewise
6457         (var_decode_location): Add DW_OP_addrx
6458         (dwarf2_const_value_attr): Add DW_FORM_addrx
6459         (dump_die_shallow): Likewise
6460         (dwarf2_fetch_constant_bytes): Likewise
6461         (decode_locdesc): Add DW_OP_addrx
6462         (skip_form_bytes): Add DW_FORM_addrx
6463
6464 2019-04-22  Ali Tamur  <tamur@google.com>
6465
6466         * MAINTAINERS (Write After Approval): Add self.
6467
6468 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6469
6470         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6471         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6472         (open_symbol_file_object): Likewise.
6473         (svr4_default_sos): Add info parameter.
6474         (svr4_read_so_list): Likewise.
6475         (svr4_current_sos_direct): Adjust functions calls to pass down
6476         info.
6477         (svr4_current_sos_1): Add info parameter.
6478         (svr4_current_sos): Call get_svr4_info, pass info down to
6479         svr4_current_sos_1.
6480         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6481         get_svr4_info.
6482         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6483         get_svr4_info.
6484         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6485         to get_svr4_info.
6486         (probes_table_remove_objfile_probes): Likewise.
6487         (register_solib_event_probe): Add info parameter.
6488         (solist_update_incremental): Pass info parameter down to
6489         svr4_read_so_list.
6490         (disable_probes_interface): Add info parameter.
6491         (svr4_handle_solib_event): Pass current_program_space to
6492         get_svr4_info.  Adjust disable_probes_interface cleanup.
6493         (svr4_create_probe_breakpoints): Add info parameter, pass it
6494         down to register_solib_event_probe.
6495         (svr4_create_solib_event_breakpoints): Add info parameter,
6496         pass it down to svr4_create_probe_breakpoints.
6497         (enable_break): Pass info down to
6498         svr4_create_solib_event_breakpoints.
6499         (svr4_solib_create_inferior_hook): Pass current_program_space to
6500         get_svr4_info.
6501         (svr4_clear_solib): Likewise.
6502
6503 2019-04-22  Pedro Alves  <palves@redhat.com>
6504
6505         * solib-svr4.c (svr4_free_objfile_observer): New.
6506         (probe_and_action::objfile): New field.
6507         (probes_table_htab_remove_objfile_probes)
6508         (probes_table_remove_objfile_probes): New functions.
6509         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6510         in the new probe_and_action.  Don't store the probe in 'lookup'.
6511         (svr4_create_probe_breakpoints): Pass objfile to
6512         register_solib_event_probe.
6513         (_initialize_svr4_solib): Register a free_objfile observer.
6514
6515 2019-04-19  Tom Tromey  <tom@tromey.com>
6516
6517         * common/queue.h: Remove.
6518
6519 2019-04-19  Tom Tromey  <tom@tromey.com>
6520
6521         * event-loop.c: Don't include "common/queue.h".
6522
6523 2019-04-19  Tom Tromey  <tom@tromey.com>
6524
6525         * remote.c (remote_target): Use delete.
6526         * remote-notif.h: Include <list>, not "common/queue.h".
6527         (notif_client_p): Remove typedef.
6528         (remote_notif_state): Add constructor, destructor, initializer.
6529         <notif_queue>: Now a std::list.
6530         (remote_notif_state_xfree): Don't declare.
6531         * remote-notif.c (remote_notif_process, handle_notification)
6532         (remote_notif_state_allocate): Update.
6533         (~remote_notif_state): Rename from remote_notif_state_xfree.
6534
6535 2019-04-19  Tom Tromey  <tom@tromey.com>
6536
6537         * symfile.c (reread_symbols): Update.
6538         * objfiles.c (objfile_register_static_link)
6539         (objfile_lookup_static_link): Update
6540         (~objfile) Don't delete static_links.
6541         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6542
6543 2019-04-19  Tom Tromey  <tom@tromey.com>
6544
6545         * type-stack.h (struct type_stack) <insert>: Constify string.
6546         * type-stack.c (type_stack::insert): Constify string.
6547         * gdbtypes.h (lookup_template_type): Update.
6548         (address_space_name_to_int): Update.
6549         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6550         const.
6551         (lookup_template_type): Make name const.
6552         * c-exp.y: Update rules.
6553         (lex_one_token, classify_name, classify_inner_name)
6554         (c_print_token): Update.
6555         * p-exp.y: Update rules.
6556         (yylex): Update.
6557         * f-exp.y: Update rules.
6558         (yylex): Update.
6559         * d-exp.y: Update rules.
6560         (lex_one_token, classify_name, classify_inner_name): Update.
6561         * parse.c (write_dollar_variable, copy_name): Return std::string.
6562         * parser-defs.h (copy_name): Change return type.
6563         * m2-exp.y: Update rules.
6564         (yylex): Update.
6565         * go-exp.y (lex_one_token): Update.
6566         Update rules.
6567         (classify_unsafe_function, classify_packaged_name)
6568         (classify_name, yylex): Update.
6569
6570 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6571
6572         * configure.ac: add --enable-source-highlight switch.
6573         * configure: Regenerate.
6574         * top.c (print_gdb_version): plumb --enable-source-highlight
6575         status to "show configuration".
6576
6577 2019-04-19  Tom Tromey  <tromey@adacore.com>
6578
6579         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6580         Check ADA_TYPE_P.
6581         (empty_record, ada_template_to_fixed_record_type_1)
6582         (template_to_static_fixed_type)
6583         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6584         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6585         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6586         macros.
6587
6588 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6589
6590         PR symtab/24423:
6591         * source.c (print_source_lines_base): Advance "iter" when a
6592         control character is seen.
6593
6594 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6595
6596         * inferior.h (struct infcall_suspend_state_deleter):
6597         Catch exception in destructor to avoid crash.
6598
6599 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6600
6601         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6602         close to the add_com "shell".
6603
6604 2019-04-18  Tom Tromey  <tromey@adacore.com>
6605
6606         * process-stratum-target.h (class process_stratum_target)
6607         <stratum>: Add "final".
6608
6609 2019-04-17  Tom Tromey  <tromey@adacore.com>
6610
6611         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6612         against nullptr before use.
6613
6614 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6615
6616         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6617
6618 2019-04-17  Jim Wilson  <jimw@sifive.com>
6619             Andrew Burgess  <andrew.burgess@embecosm.com>
6620
6621         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6622         code read might fail, assume 4-byte breakpoint in that case.
6623
6624 2019-04-15  Leszek Swirski  <leszeks@google.com>
6625
6626         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6627         rather than a hand-rolled POD check when checking for forced MEMORY
6628         classification.
6629
6630 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6631
6632         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6633         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6634         function.
6635         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6636         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6637         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6638         declaration.
6639
6640 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6641
6642         * aarch64-linux-nat.c
6643         (aarch64_linux_nat_target::thread_architecture): Add override.
6644         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6645         each VQ.
6646
6647 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6648
6649         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6650
6651 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6652
6653         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6654         target types of size 96-bits, add some additional comments, and
6655         check that the builtin type we found was the correct size.
6656
6657 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6658
6659         * utils.c (prompt_for_continue): Don't restore the styling at the
6660         end, as applied_style has the wrong value.  This fixes styling in
6661         long lists of file names that are interrupted by the "Continue?"
6662         prompt.
6663
6664 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6665
6666         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6667         * c-lang.c (c_language_defn): Likewise.
6668         (cplus_language_defn): Likewise.
6669         (asm_language_defn): Likewise.
6670         (minimal_language_defn): Likewise.
6671         * d-lang.c (d_language_defn): Likewise.
6672         * f-lang.c (f_language_defn): Likewise.
6673         * go-lang.c (go_language_defn): Likewise.
6674         * language.c (unknown_language_defn): Likewise.
6675         (auto_language_defn): Likewise.
6676         * language.h (struct language_defn): Remove la_magic field.
6677         (LANG_MAGIC): Delete.
6678         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6679         * objc-lang.c (objc_language_defn): Likewise.
6680         * opencl-lang.c (opencl_language_defn): Likewise.
6681         * p-lang.c (pascal_language_defn): Likewise.
6682         * rust-lang.c (rust_language_defn): Likewise.
6683
6684 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6685
6686         * riscv-tdep.c (riscv_type_align): New function.
6687         (riscv_type_alignment): Delete.
6688         (riscv_arg_location): Use 'type_align'.
6689         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6690
6691 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6692
6693         * gdbtypes.c (type_align): A struct with no non-static fields also
6694         has alignment of 1.
6695
6696 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6697
6698         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6699         component to 0.
6700         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6701         member.
6702         (riscv_struct_info::analyse): New implementation using new
6703         analyse_inner member function.
6704         (riscv_struct_info::field_offset): New member function.
6705         (riscv_struct_info::m_offsets): New member variable.
6706         (riscv_struct_info::analyse_inner): New private member function,
6707         takes the old implementation of riscv_struct_info::analyse but
6708         extended to track field offsets.
6709         (riscv_call_arg_struct): Update the struct folding special cases
6710         to handle cases where empty C++ structs, which are non-zero
6711         length, are found.
6712         (riscv_arg_location): Initialise the length of each location, a
6713         non-zero length now indicates the location is in use.
6714         (riscv_push_dummy_call): Allow for the first location having a
6715         non-zero offset when setting up arguments.
6716         (riscv_return_value): Likewise, but for return values.
6717
6718 2019-04-11  Tom Tromey  <tromey@adacore.com>
6719
6720         * utils.c (internal_vproblem): Make "msg" const.
6721
6722 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6723
6724         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6725         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6726         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6727         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6728
6729 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6730
6731         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6732         function.
6733         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6734         of amd64_collect_native_gregset.
6735         (amd64_linux_nat_target::store_registers): Likewise.
6736
6737 2019-04-10  Tom Tromey  <tom@tromey.com>
6738
6739         * symtab.c (lookup_global_symbol_from_objfile)
6740         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6741         * objfiles.h (class separate_debug_iterator): New.
6742         (class separate_debug_range): New.
6743         (struct objfile) <separate_debug_objfiles>: New method.
6744         (objfile_separate_debug_iterate): Don't declare.
6745         * objfiles.c (separate_debug_iterator::operator++): Rename from
6746         objfile_separate_debug_iterate.
6747         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6748         iterator.
6749         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6750         iterator.
6751
6752 2019-04-10  Tom Tromey  <tom@tromey.com>
6753
6754         * symfile.c (reread_symbols): Remove old comment.
6755         * objfiles.c (free_all_objfiles): Fix a typo.
6756
6757 2019-04-10  Tom Tromey  <tom@tromey.com>
6758
6759         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6760         * minsyms.c (lookup_minimal_symbol): Use foreach.
6761         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6762         (lookup_minimal_symbol_solib_trampoline): Likewise.
6763         * symfile.c (reread_symbols): Use foreach.
6764
6765 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6766             Tom Tromey  <tromey@adacore.com>
6767
6768         PR rust/24414:
6769         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6770         (rust_lex_int_test): Change "value" to be LONGEST.
6771         (rust_lex_tests): Add test for long integer literal.
6772
6773 2019-04-09  Tom Tromey  <tromey@adacore.com>
6774
6775         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6776         to bool.
6777         (extended_remote_target::attach): Update.
6778         (remote_target::remote_notice_new_inferior): Update.
6779         (remote_target::add_current_inferior_and_thread): Update.
6780         * inferior.c (exit_inferior_1): Use "false".
6781         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6782
6783 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6784
6785         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6786         the "start" command.
6787
6788 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6789
6790         * python/py-inferior.c (infpy_thread_from_thread_handle):
6791         Adjust comments to reflect renaming of thread_from_thread_handle
6792         to thread_from_handle.  Adjust keywords.  Fix type error message.
6793         (inferior_object_methods): Add thread_from_handle.  Retain
6794         thread_from_thread_handle, but mark it as deprecated.
6795
6796 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6797
6798         * gdbthread.h (find_thread_by_handle): Revise declaration.
6799         * thread.c (find_thread_by_handle): Likewise.  Adjust
6800         implementation too.
6801         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6802         support for buffer objects as handles.
6803
6804 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6805
6806         * python/py-infthread.c (thpy_thread_handle): New function.
6807         (thread_object_methods): Register thpy_thread_handle.
6808
6809 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6810
6811         * gdbthread.h (thread_to_thread_handle): Declare.
6812         * thread.c (gdbtypes.h): Include.
6813         (thread_to_thread_handle): New function.
6814
6815         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6816         (target_thread_info_to_thread_handle): Declare.
6817         * target.c (target_thread_info_to_thread_handle): New function.
6818         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6819         * target-delegates.c: Regenerate.
6820
6821         * linux-thread-db.c (class thread_db_target): Add method
6822         thread_info_to_thread_handle.
6823         (thread_db_target::thread_info_to_thread_handle): Define.
6824         * remote.c (class remote_target): Add new method
6825         thread_info_to_thread_handle.
6826         (remote_target::thread_info_to_thread_handle): Define.
6827
6828 2019-04-08  Pedro Alves  <palves@redhat.com>
6829
6830         * common/common-exceptions.c (throw_exception): Don't create
6831         named object to throw; throw directly.
6832         (throw_it): Likewise.  Don't initialize gdb_exception::message
6833         here, with new; pass FMT and AP to the ctor instead.
6834         * common/common-exceptions.h: Include <string>.
6835         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6836         const char *, va_list)): New ctor.  Use std::make_shared.
6837         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6838         errors)): Delete.
6839         (gdb_exception_error::gdb_exception_error(enum errors, const char
6840         *, va_list)): New.
6841         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6842         Add assertion.
6843         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6844         errors)): Delete.
6845         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6846         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6847         Add assertion.
6848
6849 2019-04-08  Tom Tromey  <tom@tromey.com>
6850
6851         * valops.c (value_rtti_indirect_type): Replace throw_exception
6852         with throw.
6853         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6854         with throw.
6855         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6856         throw.
6857         * target.c (target_translate_tls_address): Replace throw_exception
6858         with throw.
6859         * stack.c (frame_apply_command_count): Replace throw_exception
6860         with throw.
6861         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6862         throw.
6863         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6864         with throw.
6865         * rs6000-tdep.c (rs6000_frame_cache)
6866         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6867         * remote.c: Replace throw_exception with throw.
6868         * record-full.c (record_full_message, record_full_wait_1)
6869         (record_full_restore): Replace throw_exception with throw.
6870         * record-btrace.c:
6871         (get_thread_current_frame_id, record_btrace_start_replaying)
6872         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6873         (cmd_record_btrace_start): Replace throw_exception with throw.
6874         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6875         throw.
6876         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6877         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6878         * linespec.c:
6879         (find_linespec_symbols): Replace throw_exception with throw.
6880         * infrun.c (displaced_step_prepare, resume): Replace
6881         throw_exception with throw.
6882         * infcmd.c (post_create_inferior): Replace throw_exception with
6883         throw.
6884         * inf-loop.c (inferior_event_handler): Replace throw_exception
6885         with throw.
6886         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6887         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6888         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6889         (get_prev_frame_always, get_frame_pc_if_available)
6890         (get_frame_address_in_block_if_available, get_frame_language):
6891         Replace throw_exception with throw.
6892         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6893         throw_exception with throw.
6894         * eval.c (fetch_subexp_value, evaluate_var_value)
6895         (evaluate_funcall, evaluate_subexp_standard): Replace
6896         throw_exception with throw.
6897         * dwarf2loc.c (call_site_find_chain)
6898         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6899         Replace throw_exception with throw.
6900         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6901         with throw.
6902         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6903         throw.
6904         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6905         * completer.c (complete_line_internal): Replace throw_exception
6906         with throw.
6907         * compile/compile-object-run.c (compile_object_run): Replace
6908         throw_exception with throw.
6909         * cli/cli-script.c (process_next_line): Replace throw_exception
6910         with throw.
6911         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6912         (btrace_enable, btrace_maint_update_pt_packets): Replace
6913         throw_exception with throw.
6914         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6915         throw_exception with throw.
6916         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6917         throw_exception with throw.
6918         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6919         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6920         * aarch64-tdep.c (aarch64_make_prologue_cache)
6921         (aarch64_make_stub_cache): Replace throw_exception with throw.
6922
6923 2019-04-08  Tom Tromey  <tom@tromey.com>
6924
6925         * common/common-exceptions.c (throw_exception): Rename from
6926         throw_exception_cxx.  Remove old copy.  Make argument const.
6927         (throw_it): Create and throw exception objects directly.
6928         * common/common-exceptions.h (throw_exception): Make argument
6929         const.
6930         (struct gdb_exception_error): Add constructor.
6931         (struct gdb_exception_quit): Add constructor.
6932
6933 2019-04-08  Tom Tromey  <tom@tromey.com>
6934
6935         * common/common-exceptions.h (exception_rethrow): Don't declare.
6936         (TRY_SJLJ): Update comment.
6937         (TRY, CATCH, END_CATCH): Remove.
6938         * common/common-exceptions.c (exception_rethrow): Remove.
6939
6940 2019-04-08  Tom Tromey  <tom@tromey.com>
6941
6942         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6943         Remove.
6944         (gdb_exception_error): Rename from
6945         gdb_exception_RETURN_MASK_ERROR.
6946         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6947         (gdb_quit_bad_alloc): Update.
6948         * aarch64-tdep.c: Update.
6949         * ada-lang.c: Update.
6950         * ada-typeprint.c: Update.
6951         * ada-valprint.c: Update.
6952         * amd64-tdep.c: Update.
6953         * arch-utils.c: Update.
6954         * break-catch-throw.c: Update.
6955         * breakpoint.c: Update.
6956         * btrace.c: Update.
6957         * c-varobj.c: Update.
6958         * cli/cli-cmds.c: Update.
6959         * cli/cli-interp.c: Update.
6960         * cli/cli-script.c: Update.
6961         * common/common-exceptions.c: Update.
6962         * common/new-op.c: Update.
6963         * common/selftest.c: Update.
6964         * compile/compile-c-symbols.c: Update.
6965         * compile/compile-cplus-symbols.c: Update.
6966         * compile/compile-object-load.c: Update.
6967         * compile/compile-object-run.c: Update.
6968         * completer.c: Update.
6969         * corelow.c: Update.
6970         * cp-abi.c: Update.
6971         * cp-support.c: Update.
6972         * cp-valprint.c: Update.
6973         * darwin-nat.c: Update.
6974         * disasm-selftests.c: Update.
6975         * dtrace-probe.c: Update.
6976         * dwarf-index-cache.c: Update.
6977         * dwarf-index-write.c: Update.
6978         * dwarf2-frame-tailcall.c: Update.
6979         * dwarf2-frame.c: Update.
6980         * dwarf2loc.c: Update.
6981         * dwarf2read.c: Update.
6982         * eval.c: Update.
6983         * event-loop.c: Update.
6984         * event-top.c: Update.
6985         * exec.c: Update.
6986         * f-valprint.c: Update.
6987         * fbsd-tdep.c: Update.
6988         * frame-unwind.c: Update.
6989         * frame.c: Update.
6990         * gdbtypes.c: Update.
6991         * gnu-v3-abi.c: Update.
6992         * guile/guile-internal.h: Update.
6993         * guile/scm-block.c: Update.
6994         * guile/scm-breakpoint.c: Update.
6995         * guile/scm-cmd.c: Update.
6996         * guile/scm-disasm.c: Update.
6997         * guile/scm-frame.c: Update.
6998         * guile/scm-lazy-string.c: Update.
6999         * guile/scm-math.c: Update.
7000         * guile/scm-param.c: Update.
7001         * guile/scm-ports.c: Update.
7002         * guile/scm-pretty-print.c: Update.
7003         * guile/scm-symbol.c: Update.
7004         * guile/scm-symtab.c: Update.
7005         * guile/scm-type.c: Update.
7006         * guile/scm-value.c: Update.
7007         * i386-linux-tdep.c: Update.
7008         * i386-tdep.c: Update.
7009         * inf-loop.c: Update.
7010         * infcall.c: Update.
7011         * infcmd.c: Update.
7012         * infrun.c: Update.
7013         * jit.c: Update.
7014         * language.c: Update.
7015         * linespec.c: Update.
7016         * linux-fork.c: Update.
7017         * linux-nat.c: Update.
7018         * linux-tdep.c: Update.
7019         * linux-thread-db.c: Update.
7020         * main.c: Update.
7021         * mi/mi-cmd-break.c: Update.
7022         * mi/mi-cmd-stack.c: Update.
7023         * mi/mi-interp.c: Update.
7024         * mi/mi-main.c: Update.
7025         * objc-lang.c: Update.
7026         * p-valprint.c: Update.
7027         * parse.c: Update.
7028         * ppc-linux-tdep.c: Update.
7029         * printcmd.c: Update.
7030         * python/py-arch.c: Update.
7031         * python/py-breakpoint.c: Update.
7032         * python/py-cmd.c: Update.
7033         * python/py-finishbreakpoint.c: Update.
7034         * python/py-frame.c: Update.
7035         * python/py-framefilter.c: Update.
7036         * python/py-gdb-readline.c: Update.
7037         * python/py-inferior.c: Update.
7038         * python/py-infthread.c: Update.
7039         * python/py-lazy-string.c: Update.
7040         * python/py-linetable.c: Update.
7041         * python/py-objfile.c: Update.
7042         * python/py-param.c: Update.
7043         * python/py-prettyprint.c: Update.
7044         * python/py-progspace.c: Update.
7045         * python/py-record-btrace.c: Update.
7046         * python/py-record.c: Update.
7047         * python/py-symbol.c: Update.
7048         * python/py-type.c: Update.
7049         * python/py-unwind.c: Update.
7050         * python/py-utils.c: Update.
7051         * python/py-value.c: Update.
7052         * python/python.c: Update.
7053         * record-btrace.c: Update.
7054         * record-full.c: Update.
7055         * remote-fileio.c: Update.
7056         * remote.c: Update.
7057         * riscv-tdep.c: Update.
7058         * rs6000-aix-tdep.c: Update.
7059         * rs6000-tdep.c: Update.
7060         * rust-exp.y: Update.
7061         * rust-lang.c: Update.
7062         * s390-tdep.c: Update.
7063         * selftest-arch.c: Update.
7064         * solib-dsbt.c: Update.
7065         * solib-frv.c: Update.
7066         * solib-spu.c: Update.
7067         * solib-svr4.c: Update.
7068         * solib.c: Update.
7069         * sparc64-linux-tdep.c: Update.
7070         * stack.c: Update.
7071         * symfile-mem.c: Update.
7072         * symmisc.c: Update.
7073         * target.c: Update.
7074         * thread.c: Update.
7075         * top.c: Update.
7076         * tracefile-tfile.c: Update.
7077         * tui/tui.c: Update.
7078         * typeprint.c: Update.
7079         * unittests/cli-utils-selftests.c: Update.
7080         * unittests/parse-connection-spec-selftests.c: Update.
7081         * valops.c: Update.
7082         * valprint.c: Update.
7083         * value.c: Update.
7084         * varobj.c: Update.
7085         * windows-nat.c: Update.
7086         * x86-linux-nat.c: Update.
7087         * xml-support.c: Update.
7088
7089 2019-04-08  Tom Tromey  <tom@tromey.com>
7090
7091         * xml-support.c: Use C++ exception handling.
7092         * x86-linux-nat.c: Use C++ exception handling.
7093         * windows-nat.c: Use C++ exception handling.
7094         * varobj.c: Use C++ exception handling.
7095         * value.c: Use C++ exception handling.
7096         * valprint.c: Use C++ exception handling.
7097         * valops.c: Use C++ exception handling.
7098         * unittests/parse-connection-spec-selftests.c: Use C++ exception
7099         handling.
7100         * unittests/cli-utils-selftests.c: Use C++ exception handling.
7101         * typeprint.c: Use C++ exception handling.
7102         * tui/tui.c: Use C++ exception handling.
7103         * tracefile-tfile.c: Use C++ exception handling.
7104         * top.c: Use C++ exception handling.
7105         * thread.c: Use C++ exception handling.
7106         * target.c: Use C++ exception handling.
7107         * symmisc.c: Use C++ exception handling.
7108         * symfile-mem.c: Use C++ exception handling.
7109         * stack.c: Use C++ exception handling.
7110         * sparc64-linux-tdep.c: Use C++ exception handling.
7111         * solib.c: Use C++ exception handling.
7112         * solib-svr4.c: Use C++ exception handling.
7113         * solib-spu.c: Use C++ exception handling.
7114         * solib-frv.c: Use C++ exception handling.
7115         * solib-dsbt.c: Use C++ exception handling.
7116         * selftest-arch.c: Use C++ exception handling.
7117         * s390-tdep.c: Use C++ exception handling.
7118         * rust-lang.c: Use C++ exception handling.
7119         * rust-exp.y: Use C++ exception handling.
7120         * rs6000-tdep.c: Use C++ exception handling.
7121         * rs6000-aix-tdep.c: Use C++ exception handling.
7122         * riscv-tdep.c: Use C++ exception handling.
7123         * remote.c: Use C++ exception handling.
7124         * remote-fileio.c: Use C++ exception handling.
7125         * record-full.c: Use C++ exception handling.
7126         * record-btrace.c: Use C++ exception handling.
7127         * python/python.c: Use C++ exception handling.
7128         * python/py-value.c: Use C++ exception handling.
7129         * python/py-utils.c: Use C++ exception handling.
7130         * python/py-unwind.c: Use C++ exception handling.
7131         * python/py-type.c: Use C++ exception handling.
7132         * python/py-symbol.c: Use C++ exception handling.
7133         * python/py-record.c: Use C++ exception handling.
7134         * python/py-record-btrace.c: Use C++ exception handling.
7135         * python/py-progspace.c: Use C++ exception handling.
7136         * python/py-prettyprint.c: Use C++ exception handling.
7137         * python/py-param.c: Use C++ exception handling.
7138         * python/py-objfile.c: Use C++ exception handling.
7139         * python/py-linetable.c: Use C++ exception handling.
7140         * python/py-lazy-string.c: Use C++ exception handling.
7141         * python/py-infthread.c: Use C++ exception handling.
7142         * python/py-inferior.c: Use C++ exception handling.
7143         * python/py-gdb-readline.c: Use C++ exception handling.
7144         * python/py-framefilter.c: Use C++ exception handling.
7145         * python/py-frame.c: Use C++ exception handling.
7146         * python/py-finishbreakpoint.c: Use C++ exception handling.
7147         * python/py-cmd.c: Use C++ exception handling.
7148         * python/py-breakpoint.c: Use C++ exception handling.
7149         * python/py-arch.c: Use C++ exception handling.
7150         * printcmd.c: Use C++ exception handling.
7151         * ppc-linux-tdep.c: Use C++ exception handling.
7152         * parse.c: Use C++ exception handling.
7153         * p-valprint.c: Use C++ exception handling.
7154         * objc-lang.c: Use C++ exception handling.
7155         * mi/mi-main.c: Use C++ exception handling.
7156         * mi/mi-interp.c: Use C++ exception handling.
7157         * mi/mi-cmd-stack.c: Use C++ exception handling.
7158         * mi/mi-cmd-break.c: Use C++ exception handling.
7159         * main.c: Use C++ exception handling.
7160         * linux-thread-db.c: Use C++ exception handling.
7161         * linux-tdep.c: Use C++ exception handling.
7162         * linux-nat.c: Use C++ exception handling.
7163         * linux-fork.c: Use C++ exception handling.
7164         * linespec.c: Use C++ exception handling.
7165         * language.c: Use C++ exception handling.
7166         * jit.c: Use C++ exception handling.
7167         * infrun.c: Use C++ exception handling.
7168         * infcmd.c: Use C++ exception handling.
7169         * infcall.c: Use C++ exception handling.
7170         * inf-loop.c: Use C++ exception handling.
7171         * i386-tdep.c: Use C++ exception handling.
7172         * i386-linux-tdep.c: Use C++ exception handling.
7173         * guile/scm-value.c: Use C++ exception handling.
7174         * guile/scm-type.c: Use C++ exception handling.
7175         * guile/scm-symtab.c: Use C++ exception handling.
7176         * guile/scm-symbol.c: Use C++ exception handling.
7177         * guile/scm-pretty-print.c: Use C++ exception handling.
7178         * guile/scm-ports.c: Use C++ exception handling.
7179         * guile/scm-param.c: Use C++ exception handling.
7180         * guile/scm-math.c: Use C++ exception handling.
7181         * guile/scm-lazy-string.c: Use C++ exception handling.
7182         * guile/scm-frame.c: Use C++ exception handling.
7183         * guile/scm-disasm.c: Use C++ exception handling.
7184         * guile/scm-cmd.c: Use C++ exception handling.
7185         * guile/scm-breakpoint.c: Use C++ exception handling.
7186         * guile/scm-block.c: Use C++ exception handling.
7187         * guile/guile-internal.h: Use C++ exception handling.
7188         * gnu-v3-abi.c: Use C++ exception handling.
7189         * gdbtypes.c: Use C++ exception handling.
7190         * frame.c: Use C++ exception handling.
7191         * frame-unwind.c: Use C++ exception handling.
7192         * fbsd-tdep.c: Use C++ exception handling.
7193         * f-valprint.c: Use C++ exception handling.
7194         * exec.c: Use C++ exception handling.
7195         * event-top.c: Use C++ exception handling.
7196         * event-loop.c: Use C++ exception handling.
7197         * eval.c: Use C++ exception handling.
7198         * dwarf2read.c: Use C++ exception handling.
7199         * dwarf2loc.c: Use C++ exception handling.
7200         * dwarf2-frame.c: Use C++ exception handling.
7201         * dwarf2-frame-tailcall.c: Use C++ exception handling.
7202         * dwarf-index-write.c: Use C++ exception handling.
7203         * dwarf-index-cache.c: Use C++ exception handling.
7204         * dtrace-probe.c: Use C++ exception handling.
7205         * disasm-selftests.c: Use C++ exception handling.
7206         * darwin-nat.c: Use C++ exception handling.
7207         * cp-valprint.c: Use C++ exception handling.
7208         * cp-support.c: Use C++ exception handling.
7209         * cp-abi.c: Use C++ exception handling.
7210         * corelow.c: Use C++ exception handling.
7211         * completer.c: Use C++ exception handling.
7212         * compile/compile-object-run.c: Use C++ exception handling.
7213         * compile/compile-object-load.c: Use C++ exception handling.
7214         * compile/compile-cplus-symbols.c: Use C++ exception handling.
7215         * compile/compile-c-symbols.c: Use C++ exception handling.
7216         * common/selftest.c: Use C++ exception handling.
7217         * common/new-op.c: Use C++ exception handling.
7218         * cli/cli-script.c: Use C++ exception handling.
7219         * cli/cli-interp.c: Use C++ exception handling.
7220         * cli/cli-cmds.c: Use C++ exception handling.
7221         * c-varobj.c: Use C++ exception handling.
7222         * btrace.c: Use C++ exception handling.
7223         * breakpoint.c: Use C++ exception handling.
7224         * break-catch-throw.c: Use C++ exception handling.
7225         * arch-utils.c: Use C++ exception handling.
7226         * amd64-tdep.c: Use C++ exception handling.
7227         * ada-valprint.c: Use C++ exception handling.
7228         * ada-typeprint.c: Use C++ exception handling.
7229         * ada-lang.c: Use C++ exception handling.
7230         * aarch64-tdep.c: Use C++ exception handling.
7231
7232 2019-04-08  Tom Tromey  <tom@tromey.com>
7233
7234         * xml-support.c (gdb_xml_parser::parse): Update.
7235         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7236         * value.c (show_convenience): Update.
7237         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7238         (test_parse_flags_qcs): Update.
7239         * thread.c (thr_try_catch_cmd): Update.
7240         * target.c (target_translate_tls_address): Update.
7241         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7242         (info_frame_command_core, frame_apply_command_count): Update.
7243         * rust-exp.y (rust_lex_exception_test): Update.
7244         * riscv-tdep.c (riscv_print_one_register_info): Update.
7245         * remote.c (remote_target::enable_btrace): Update.
7246         * record-btrace.c (record_btrace_enable_warn): Update.
7247         * python/py-utils.c (gdbpy_convert_exception): Update.
7248         * printcmd.c (do_one_display, print_variable_and_value): Update.
7249         * mi/mi-main.c (mi_print_exception): Update.
7250         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7251         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7252         * linux-nat.c (linux_nat_target::attach): Update.
7253         * linux-fork.c (class scoped_switch_fork_info): Update.
7254         * infrun.c (displaced_step_prepare): Update.
7255         * infcall.c (call_function_by_hand_dummy): Update.
7256         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7257         * gnu-v3-abi.c (print_one_vtable): Update.
7258         * frame.c (get_prev_frame_always): Update.
7259         * f-valprint.c (info_common_command_for_block): Update.
7260         * exec.c (try_open_exec_file): Update.
7261         * exceptions.c (print_exception, exception_print)
7262         (exception_fprintf, exception_print_same): Update.
7263         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7264         * dwarf-index-cache.c (index_cache::store)
7265         (index_cache::lookup_gdb_index): Update.
7266         * darwin-nat.c (maybe_cache_shell): Update.
7267         * cp-valprint.c (cp_print_value_fields): Update.
7268         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7269         (gcc_cplus_symbol_address): Update.
7270         * compile/compile-c-symbols.c (gcc_convert_symbol)
7271         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7272         * common/selftest.c: Update.
7273         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7274         a std::string.
7275         (exception_try_scope_entry, exception_try_scope_exit): Don't
7276         declare.
7277         (struct exception_try_scope): Remove.
7278         (TRY): Don't use exception_try_scope.
7279         (struct gdb_exception): Add constructor, operator=.
7280         <what>: New method.
7281         (struct gdb_exception_RETURN_MASK_ALL)
7282         (struct gdb_exception_RETURN_MASK_ERROR)
7283         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7284         (struct gdb_quit_bad_alloc): Update.
7285         * common/common-exceptions.c (exception_none): Change
7286         initializer.
7287         (struct catcher) <state, exception>: Initialize inline.
7288         <prev>: Remove member.
7289         (current_catcher): Remove.
7290         (catchers): New global.
7291         (exceptions_state_mc_init): Simplify.
7292         (catcher_pop): Remove.
7293         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7294         (try_scope_depth, exception_try_scope_entry)
7295         (exception_try_scope_exit): Remove.
7296         (throw_exception_sjlj): Update.
7297         (exception_messages, exception_messages_size): Remove.
7298         (throw_it): Simplify.
7299         (gdb_exception_sliced_copy): Remove.
7300         (throw_exception_cxx): Update.
7301         * cli/cli-script.c (script_from_file): Update.
7302         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7303         Update.
7304         * ada-valprint.c (ada_val_print): Update.
7305         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7306         (create_excep_cond_exprs): Update.
7307
7308 2019-04-08  Tom Tromey  <tom@tromey.com>
7309
7310         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7311         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7312         (TRY, CATCH, END_CATCH): Remove some definitions.
7313         * common/common-exceptions.c: Don't use GDB_XCPT.
7314         (catcher_list_size): Remove.
7315         (throw_exception, throw_it): Simplify.
7316
7317 2019-04-05  Tom Tromey  <tom@tromey.com>
7318
7319         Revert the header-sorting patch.
7320         * ft32-tdep.c: Revert.
7321         * frv-tdep.c: Revert.
7322         * frv-linux-tdep.c: Revert.
7323         * frame.c: Revert.
7324         * frame-unwind.c: Revert.
7325         * frame-base.c: Revert.
7326         * fork-child.c: Revert.
7327         * findvar.c: Revert.
7328         * findcmd.c: Revert.
7329         * filesystem.c: Revert.
7330         * filename-seen-cache.h: Revert.
7331         * filename-seen-cache.c: Revert.
7332         * fbsd-tdep.c: Revert.
7333         * fbsd-nat.h: Revert.
7334         * fbsd-nat.c: Revert.
7335         * f-valprint.c: Revert.
7336         * f-typeprint.c: Revert.
7337         * f-lang.c: Revert.
7338         * extension.h: Revert.
7339         * extension.c: Revert.
7340         * extension-priv.h: Revert.
7341         * expprint.c: Revert.
7342         * exec.h: Revert.
7343         * exec.c: Revert.
7344         * exceptions.c: Revert.
7345         * event-top.c: Revert.
7346         * event-loop.c: Revert.
7347         * eval.c: Revert.
7348         * elfread.c: Revert.
7349         * dwarf2read.h: Revert.
7350         * dwarf2read.c: Revert.
7351         * dwarf2loc.c: Revert.
7352         * dwarf2expr.h: Revert.
7353         * dwarf2expr.c: Revert.
7354         * dwarf2-frame.c: Revert.
7355         * dwarf2-frame-tailcall.c: Revert.
7356         * dwarf-index-write.h: Revert.
7357         * dwarf-index-write.c: Revert.
7358         * dwarf-index-common.c: Revert.
7359         * dwarf-index-cache.h: Revert.
7360         * dwarf-index-cache.c: Revert.
7361         * dummy-frame.c: Revert.
7362         * dtrace-probe.c: Revert.
7363         * disasm.h: Revert.
7364         * disasm.c: Revert.
7365         * disasm-selftests.c: Revert.
7366         * dictionary.c: Revert.
7367         * dicos-tdep.c: Revert.
7368         * demangle.c: Revert.
7369         * dcache.h: Revert.
7370         * dcache.c: Revert.
7371         * darwin-nat.h: Revert.
7372         * darwin-nat.c: Revert.
7373         * darwin-nat-info.c: Revert.
7374         * d-valprint.c: Revert.
7375         * d-namespace.c: Revert.
7376         * d-lang.c: Revert.
7377         * ctf.c: Revert.
7378         * csky-tdep.c: Revert.
7379         * csky-linux-tdep.c: Revert.
7380         * cris-tdep.c: Revert.
7381         * cris-linux-tdep.c: Revert.
7382         * cp-valprint.c: Revert.
7383         * cp-support.c: Revert.
7384         * cp-namespace.c: Revert.
7385         * cp-abi.c: Revert.
7386         * corelow.c: Revert.
7387         * corefile.c: Revert.
7388         * continuations.c: Revert.
7389         * completer.h: Revert.
7390         * completer.c: Revert.
7391         * complaints.c: Revert.
7392         * coffread.c: Revert.
7393         * coff-pe-read.c: Revert.
7394         * cli-out.h: Revert.
7395         * cli-out.c: Revert.
7396         * charset.c: Revert.
7397         * c-varobj.c: Revert.
7398         * c-valprint.c: Revert.
7399         * c-typeprint.c: Revert.
7400         * c-lang.c: Revert.
7401         * buildsym.c: Revert.
7402         * buildsym-legacy.c: Revert.
7403         * build-id.h: Revert.
7404         * build-id.c: Revert.
7405         * btrace.c: Revert.
7406         * bsd-uthread.c: Revert.
7407         * breakpoint.h: Revert.
7408         * breakpoint.c: Revert.
7409         * break-catch-throw.c: Revert.
7410         * break-catch-syscall.c: Revert.
7411         * break-catch-sig.c: Revert.
7412         * blockframe.c: Revert.
7413         * block.c: Revert.
7414         * bfin-tdep.c: Revert.
7415         * bfin-linux-tdep.c: Revert.
7416         * bfd-target.c: Revert.
7417         * bcache.c: Revert.
7418         * ax-general.c: Revert.
7419         * ax-gdb.h: Revert.
7420         * ax-gdb.c: Revert.
7421         * avr-tdep.c: Revert.
7422         * auxv.c: Revert.
7423         * auto-load.c: Revert.
7424         * arm-wince-tdep.c: Revert.
7425         * arm-tdep.c: Revert.
7426         * arm-symbian-tdep.c: Revert.
7427         * arm-pikeos-tdep.c: Revert.
7428         * arm-obsd-tdep.c: Revert.
7429         * arm-nbsd-tdep.c: Revert.
7430         * arm-nbsd-nat.c: Revert.
7431         * arm-linux-tdep.c: Revert.
7432         * arm-linux-nat.c: Revert.
7433         * arm-fbsd-tdep.c: Revert.
7434         * arm-fbsd-nat.c: Revert.
7435         * arm-bsd-tdep.c: Revert.
7436         * arch-utils.c: Revert.
7437         * arc-tdep.c: Revert.
7438         * arc-newlib-tdep.c: Revert.
7439         * annotate.h: Revert.
7440         * annotate.c: Revert.
7441         * amd64-windows-tdep.c: Revert.
7442         * amd64-windows-nat.c: Revert.
7443         * amd64-tdep.c: Revert.
7444         * amd64-sol2-tdep.c: Revert.
7445         * amd64-obsd-tdep.c: Revert.
7446         * amd64-obsd-nat.c: Revert.
7447         * amd64-nbsd-tdep.c: Revert.
7448         * amd64-nbsd-nat.c: Revert.
7449         * amd64-nat.c: Revert.
7450         * amd64-linux-tdep.c: Revert.
7451         * amd64-linux-nat.c: Revert.
7452         * amd64-fbsd-tdep.c: Revert.
7453         * amd64-fbsd-nat.c: Revert.
7454         * amd64-dicos-tdep.c: Revert.
7455         * amd64-darwin-tdep.c: Revert.
7456         * amd64-bsd-nat.c: Revert.
7457         * alpha-tdep.c: Revert.
7458         * alpha-obsd-tdep.c: Revert.
7459         * alpha-nbsd-tdep.c: Revert.
7460         * alpha-mdebug-tdep.c: Revert.
7461         * alpha-linux-tdep.c: Revert.
7462         * alpha-linux-nat.c: Revert.
7463         * alpha-bsd-tdep.c: Revert.
7464         * alpha-bsd-nat.c: Revert.
7465         * aix-thread.c: Revert.
7466         * agent.c: Revert.
7467         * addrmap.c: Revert.
7468         * ada-varobj.c: Revert.
7469         * ada-valprint.c: Revert.
7470         * ada-typeprint.c: Revert.
7471         * ada-tasks.c: Revert.
7472         * ada-lang.c: Revert.
7473         * aarch64-tdep.c: Revert.
7474         * aarch64-ravenscar-thread.c: Revert.
7475         * aarch64-newlib-tdep.c: Revert.
7476         * aarch64-linux-tdep.c: Revert.
7477         * aarch64-linux-nat.c: Revert.
7478         * aarch64-fbsd-tdep.c: Revert.
7479         * aarch64-fbsd-nat.c: Revert.
7480         * aarch32-linux-nat.c: Revert.
7481
7482 2019-04-05  Tom Tromey  <tom@tromey.com>
7483
7484         * ft32-tdep.c: Sort headers.
7485         * frv-tdep.c: Sort headers.
7486         * frv-linux-tdep.c: Sort headers.
7487         * frame.c: Sort headers.
7488         * frame-unwind.c: Sort headers.
7489         * frame-base.c: Sort headers.
7490         * fork-child.c: Sort headers.
7491         * findvar.c: Sort headers.
7492         * findcmd.c: Sort headers.
7493         * filesystem.c: Sort headers.
7494         * filename-seen-cache.h: Sort headers.
7495         * filename-seen-cache.c: Sort headers.
7496         * fbsd-tdep.c: Sort headers.
7497         * fbsd-nat.h: Sort headers.
7498         * fbsd-nat.c: Sort headers.
7499         * f-valprint.c: Sort headers.
7500         * f-typeprint.c: Sort headers.
7501         * f-lang.c: Sort headers.
7502         * extension.h: Sort headers.
7503         * extension.c: Sort headers.
7504         * extension-priv.h: Sort headers.
7505         * expprint.c: Sort headers.
7506         * exec.h: Sort headers.
7507         * exec.c: Sort headers.
7508         * exceptions.c: Sort headers.
7509         * event-top.c: Sort headers.
7510         * event-loop.c: Sort headers.
7511         * eval.c: Sort headers.
7512         * elfread.c: Sort headers.
7513         * dwarf2read.h: Sort headers.
7514         * dwarf2read.c: Sort headers.
7515         * dwarf2loc.c: Sort headers.
7516         * dwarf2expr.h: Sort headers.
7517         * dwarf2expr.c: Sort headers.
7518         * dwarf2-frame.c: Sort headers.
7519         * dwarf2-frame-tailcall.c: Sort headers.
7520         * dwarf-index-write.h: Sort headers.
7521         * dwarf-index-write.c: Sort headers.
7522         * dwarf-index-common.c: Sort headers.
7523         * dwarf-index-cache.h: Sort headers.
7524         * dwarf-index-cache.c: Sort headers.
7525         * dummy-frame.c: Sort headers.
7526         * dtrace-probe.c: Sort headers.
7527         * disasm.h: Sort headers.
7528         * disasm.c: Sort headers.
7529         * disasm-selftests.c: Sort headers.
7530         * dictionary.c: Sort headers.
7531         * dicos-tdep.c: Sort headers.
7532         * demangle.c: Sort headers.
7533         * dcache.h: Sort headers.
7534         * dcache.c: Sort headers.
7535         * darwin-nat.h: Sort headers.
7536         * darwin-nat.c: Sort headers.
7537         * darwin-nat-info.c: Sort headers.
7538         * d-valprint.c: Sort headers.
7539         * d-namespace.c: Sort headers.
7540         * d-lang.c: Sort headers.
7541         * ctf.c: Sort headers.
7542         * csky-tdep.c: Sort headers.
7543         * csky-linux-tdep.c: Sort headers.
7544         * cris-tdep.c: Sort headers.
7545         * cris-linux-tdep.c: Sort headers.
7546         * cp-valprint.c: Sort headers.
7547         * cp-support.c: Sort headers.
7548         * cp-namespace.c: Sort headers.
7549         * cp-abi.c: Sort headers.
7550         * corelow.c: Sort headers.
7551         * corefile.c: Sort headers.
7552         * continuations.c: Sort headers.
7553         * completer.h: Sort headers.
7554         * completer.c: Sort headers.
7555         * complaints.c: Sort headers.
7556         * coffread.c: Sort headers.
7557         * coff-pe-read.c: Sort headers.
7558         * cli-out.h: Sort headers.
7559         * cli-out.c: Sort headers.
7560         * charset.c: Sort headers.
7561         * c-varobj.c: Sort headers.
7562         * c-valprint.c: Sort headers.
7563         * c-typeprint.c: Sort headers.
7564         * c-lang.c: Sort headers.
7565         * buildsym.c: Sort headers.
7566         * buildsym-legacy.c: Sort headers.
7567         * build-id.h: Sort headers.
7568         * build-id.c: Sort headers.
7569         * btrace.c: Sort headers.
7570         * bsd-uthread.c: Sort headers.
7571         * breakpoint.h: Sort headers.
7572         * breakpoint.c: Sort headers.
7573         * break-catch-throw.c: Sort headers.
7574         * break-catch-syscall.c: Sort headers.
7575         * break-catch-sig.c: Sort headers.
7576         * blockframe.c: Sort headers.
7577         * block.c: Sort headers.
7578         * bfin-tdep.c: Sort headers.
7579         * bfin-linux-tdep.c: Sort headers.
7580         * bfd-target.c: Sort headers.
7581         * bcache.c: Sort headers.
7582         * ax-general.c: Sort headers.
7583         * ax-gdb.h: Sort headers.
7584         * ax-gdb.c: Sort headers.
7585         * avr-tdep.c: Sort headers.
7586         * auxv.c: Sort headers.
7587         * auto-load.c: Sort headers.
7588         * arm-wince-tdep.c: Sort headers.
7589         * arm-tdep.c: Sort headers.
7590         * arm-symbian-tdep.c: Sort headers.
7591         * arm-pikeos-tdep.c: Sort headers.
7592         * arm-obsd-tdep.c: Sort headers.
7593         * arm-nbsd-tdep.c: Sort headers.
7594         * arm-nbsd-nat.c: Sort headers.
7595         * arm-linux-tdep.c: Sort headers.
7596         * arm-linux-nat.c: Sort headers.
7597         * arm-fbsd-tdep.c: Sort headers.
7598         * arm-fbsd-nat.c: Sort headers.
7599         * arm-bsd-tdep.c: Sort headers.
7600         * arch-utils.c: Sort headers.
7601         * arc-tdep.c: Sort headers.
7602         * arc-newlib-tdep.c: Sort headers.
7603         * annotate.h: Sort headers.
7604         * annotate.c: Sort headers.
7605         * amd64-windows-tdep.c: Sort headers.
7606         * amd64-windows-nat.c: Sort headers.
7607         * amd64-tdep.c: Sort headers.
7608         * amd64-sol2-tdep.c: Sort headers.
7609         * amd64-obsd-tdep.c: Sort headers.
7610         * amd64-obsd-nat.c: Sort headers.
7611         * amd64-nbsd-tdep.c: Sort headers.
7612         * amd64-nbsd-nat.c: Sort headers.
7613         * amd64-nat.c: Sort headers.
7614         * amd64-linux-tdep.c: Sort headers.
7615         * amd64-linux-nat.c: Sort headers.
7616         * amd64-fbsd-tdep.c: Sort headers.
7617         * amd64-fbsd-nat.c: Sort headers.
7618         * amd64-dicos-tdep.c: Sort headers.
7619         * amd64-darwin-tdep.c: Sort headers.
7620         * amd64-bsd-nat.c: Sort headers.
7621         * alpha-tdep.c: Sort headers.
7622         * alpha-obsd-tdep.c: Sort headers.
7623         * alpha-nbsd-tdep.c: Sort headers.
7624         * alpha-mdebug-tdep.c: Sort headers.
7625         * alpha-linux-tdep.c: Sort headers.
7626         * alpha-linux-nat.c: Sort headers.
7627         * alpha-bsd-tdep.c: Sort headers.
7628         * alpha-bsd-nat.c: Sort headers.
7629         * aix-thread.c: Sort headers.
7630         * agent.c: Sort headers.
7631         * addrmap.c: Sort headers.
7632         * ada-varobj.c: Sort headers.
7633         * ada-valprint.c: Sort headers.
7634         * ada-typeprint.c: Sort headers.
7635         * ada-tasks.c: Sort headers.
7636         * ada-lang.c: Sort headers.
7637         * aarch64-tdep.c: Sort headers.
7638         * aarch64-ravenscar-thread.c: Sort headers.
7639         * aarch64-newlib-tdep.c: Sort headers.
7640         * aarch64-linux-tdep.c: Sort headers.
7641         * aarch64-linux-nat.c: Sort headers.
7642         * aarch64-fbsd-tdep.c: Sort headers.
7643         * aarch64-fbsd-nat.c: Sort headers.
7644         * aarch32-linux-nat.c: Sort headers.
7645
7646 2019-04-04  Tom Tromey  <tom@tromey.com>
7647
7648         * varobj.c (varobj_create): Update.
7649         * rust-exp.y (struct rust_parser) <update_innermost_block,
7650         lookup_symbol>: New methods.
7651         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7652         Rename.
7653         (rust_parser::rust_lookup_type)
7654         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7655         * printcmd.c (display_command, do_one_display): Update.
7656         * parser-defs.h (struct parser_state) <parser_state>: Add
7657         "tracker" parameter.
7658         (block_tracker): New member.
7659         (class innermost_block_tracker) <innermost_block_tracker>: Add
7660         "types" parameter.
7661         <reset>: Remove method.
7662         (innermost_block): Don't declare.
7663         (null_post_parser): Update.
7664         * parse.c (innermost_block): Remove global.
7665         (write_dollar_variable): Update.
7666         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7667         Remove "tracker_types" parameter.
7668         (parse_expression): Add "tracker" parameter.
7669         (parse_expression_for_completion): Update.
7670         (null_post_parser): Add "tracker" parameter.
7671         * p-exp.y: Update rules.
7672         * m2-exp.y: Update rules.
7673         * language.h (struct language_defn) <la_post_parser>: Add
7674         "tracker" parameter.
7675         * go-exp.y: Update rules.
7676         * f-exp.y: Update rules.
7677         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7678         parameter.
7679         * d-exp.y: Update rules.
7680         * c-exp.y: Update rules.
7681         * breakpoint.c (set_breakpoint_condition): Create an
7682         innermost_block_tracker.
7683         (watch_command_1): Likewise.
7684         * ada-lang.c (resolve): Add "tracker" parameter.
7685         (resolve_subexp): Likewise.
7686         * ada-exp.y (write_var_from_sym): Update.
7687
7688 2019-04-04  Tom Tromey  <tom@tromey.com>
7689
7690         * type-stack.h: New file.
7691         * type-stack.c: New file.
7692         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7693         type-stack.h.
7694         (insert_into_type_stack, insert_type, push_type, push_type_int)
7695         (insert_type_address_space, pop_type, pop_type_int)
7696         (pop_typelist, pop_type_stack, append_type_stack)
7697         (push_type_stack, get_type_stack, push_typelist)
7698         (follow_type_instance_flags, follow_types): Don't declare.
7699         * parse.c (type_stack): Remove global.
7700         (parse_exp_in_context): Update.
7701         (insert_into_type_stack, insert_type, push_type, push_type_int)
7702         (insert_type_address_space, pop_type, pop_type_int)
7703         (pop_typelist, pop_type_stack, append_type_stack)
7704         (push_type_stack, get_type_stack, push_typelist)
7705         (follow_type_instance_flags, follow_types): Remove (moved to
7706         type-stack.c).
7707         * f-exp.y (type_stack): New global.
7708         Update rules.
7709         (push_kind_type, f_parse): Update.
7710         * d-exp.y (type_stack): New global.
7711         Update rules.
7712         (d_parse): Update.
7713         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7714         Update rules.
7715         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7716         (HFILES_NO_SRCDIR): Add type-stack.h.
7717
7718 2019-04-04  Tom Tromey  <tom@tromey.com>
7719
7720         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7721         (rust_parser::convert_ast_to_expression, rust_parse)
7722         (rust_lex_test_completion, rust_lex_tests): Update.
7723         * parser-defs.h (struct expr_completion_state): New.
7724         (struct parser_state) <parser_state>: Add completion parameter.
7725         <mark_struct_expression, mark_completion_tag>: New methods.
7726         <parse_completion, m_completion_state>: New members.
7727         (prefixify_expression, null_post_parser): Update.
7728         (mark_struct_expression, mark_completion_tag): Don't declare.
7729         * parse.c (parse_completion, expout_last_struct)
7730         (expout_tag_completion_type, expout_completion_name): Remove
7731         globals.
7732         (parser_state::mark_struct_expression)
7733         (parser_state::mark_completion_tag): Now methods.
7734         (prefixify_expression): Add last_struct parameter.
7735         (prefixify_subexp): Likewise.
7736         (parse_exp_1): Update.
7737         (parse_exp_in_context): Add cstate parameter.  Update.
7738         (parse_expression_for_completion): Create an
7739         expr_completion_state.
7740         (null_post_parser): Add "completion" parameter.
7741         * p-exp.y: Update rules.
7742         (yylex): Update.
7743         * language.h (struct language_defn) <la_post_parser>: Add
7744         "completing" parameter.
7745         * go-exp.y: Update rules.
7746         (lex_one_token): Update.
7747         * expression.h (parse_completion): Don't declare.
7748         * d-exp.y: Update rules.
7749         (lex_one_token): Update rules.
7750         * c-exp.y: Update rules.
7751         (lex_one_token): Update.
7752         * ada-lang.c (resolve): Add "parse_completion" parameter.
7753         (resolve_subexp): Likewise.
7754         (ada_resolve_function): Likewise.
7755
7756 2019-04-04  Tom Tromey  <tom@tromey.com>
7757
7758         * parser-defs.h (struct parser_state) <start_arglist,
7759         end_arglist>: New methods.
7760         <arglist_len, m_funcall_chain>: New members.
7761         (arglist_len, start_arglist, end_arglist): Don't declare.
7762         * parse.c (arglist_len, funcall_chain): Remove global.
7763         (start_arglist, end_arglist): Remove functions.
7764         (parse_exp_in_context): Update.
7765         * p-exp.y: Update rules.
7766         * m2-exp.y: Update rules.
7767         * go-exp.y: Update rules.
7768         * f-exp.y: Update rules.
7769         * d-exp.y: Update rules.
7770         * c-exp.y: Update rules.
7771
7772 2019-04-04  Tom Tromey  <tom@tromey.com>
7773
7774         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7775         lex_operator, push_back>: New methods.
7776         Update all rules.
7777         (rust_parser::lex_hex, lex_escape): Rename and update.
7778         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7779         (rust_parser::lex_operator): Rename and update.
7780         (rust_parser::lex_number, rustyylex, rustyyerror)
7781         (rust_lex_test_init, rust_lex_test_sequence)
7782         (rust_lex_test_push_back, rust_lex_tests): Update.
7783         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7784         parameter.
7785         <lexptr, prev_lexptr>: New members.
7786         (lexptr, prev_lexptr): Don't declare.
7787         * parse.c (lexptr, prev_lexptr): Remove globals.
7788         (parse_exp_in_context): Update.
7789         * p-exp.y (yylex, yyerror): Update.
7790         * m2-exp.y (parse_number, yylex, yyerror): Update.
7791         * go-exp.y (lex_one_token, yyerror): Update.
7792         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7793         * d-exp.y (lex_one_token, yyerror): Update.
7794         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7795         (lex_one_token, yyerror): Update.
7796         * ada-lex.l (YY_INPUT): Update.
7797         (rewind_to_char): Update.
7798         * ada-exp.y (yyerror): Update.
7799
7800 2019-04-04  Tom Tromey  <tom@tromey.com>
7801
7802         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7803         * parser-defs.h (struct parser_state) <parser_state>: Add new
7804         parameter.
7805         <comma_terminates>: New member.
7806         (comma_terminates): Don't declare global.
7807         * parse.c (comma_terminates): Remove global.
7808         (parse_exp_in_context): Update.
7809         * p-exp.y (yylex): Update.
7810         * m2-exp.y (yylex): Update.
7811         * go-exp.y (lex_one_token): Update.
7812         * f-exp.y (yylex): Update.
7813         * d-exp.y (lex_one_token): Update.
7814         * c-exp.y (lex_one_token): Update.
7815         * ada-lex.l: Update.
7816
7817 2019-04-04  Tom Tromey  <tom@tromey.com>
7818
7819         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7820         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7821         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7822         * parser-defs.h (paren_depth): Don't declare.
7823         * parse.c (paren_depth): Remove global.
7824         (parse_exp_in_context): Update.
7825         * p-exp.y (paren_depth): New global.
7826         (pascal_parse): Initialize it.
7827         * m2-exp.y (paren_depth): New global.
7828         (m2_parse): Initialize it.
7829         * go-exp.y (paren_depth): New global.
7830         (go_parse): Initialize it.
7831         * f-exp.y (paren_depth): New global.
7832         (f_parse): Initialize it.
7833         * d-exp.y (paren_depth): New global.
7834         (d_parse): Initialize it.
7835         * c-exp.y (paren_depth): New global.
7836         (c_parse): Initialize it.
7837         * ada-lex.l (paren_depth): New global.
7838         (lexer_init): Initialize it.
7839
7840 2019-04-04  Tom Tromey  <tom@tromey.com>
7841
7842         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7843         (rust_parser::convert_ast_to_type)
7844         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7845         * parser-defs.h (struct parser_state) <parser_state>: Add
7846         parameters.  Initialize new members.
7847         <expression_context_block, expression_context_pc>: New members.
7848         * parse.c (expression_context_block, expression_context_pc):
7849         Remove globals.
7850         (parse_exp_in_context): Update.
7851         * p-exp.y: Update all rules.
7852         (yylex): Update.
7853         * m2-exp.y: Update all rules.
7854         (yylex): Update.
7855         * go-exp.y (yylex): Update.
7856         * f-exp.y (yylex): Update.
7857         * d-exp.y: Update all rules.
7858         (yylex): Update.
7859         * c-exp.y: Update all rules.
7860         (lex_one_token, classify_name, yylex, c_parse): Update.
7861         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7862
7863 2019-04-04  Tom Tromey  <tom@tromey.com>
7864
7865         * gdbarch.h, gdbarch.c: Rebuild.
7866         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7867         * stap-probe.h:
7868         (struct stap_parse_info): Replace "parser_state" with
7869         "expr_builder".
7870         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7871         (parser_state): New class.
7872         * parse.c (expr_builder): Rename.
7873         (expr_builder::release): Rename.
7874         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7875         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7876         (write_exp_elt_longcst, write_exp_elt_floatcst)
7877         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7878         (write_exp_string_vector, write_exp_bitstring)
7879         (write_exp_msymbol, mark_struct_expression)
7880         (write_dollar_variable)
7881         (insert_type_address_space, increase_expout_size): Replace
7882         "parser_state" with "expr_builder".
7883         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7884         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7885         "parser_state" with "expr_builder".
7886
7887 2019-04-04  Tom Tromey  <tom@tromey.com>
7888
7889         * rust-exp.y: Replace "parse_language" with method call.
7890         * p-exp.y:
7891         (yylex): Replace "parse_language" with method call.
7892         * m2-exp.y:
7893         (yylex): Replace "parse_language" with method call.
7894         * go-exp.y (classify_name): Replace "parse_language" with method
7895         call.
7896         * f-exp.y (yylex): Replace "parse_language" with method call.
7897         * d-exp.y (lex_one_token): Replace "parse_language" with method
7898         call.
7899         * c-exp.y:
7900         (lex_one_token, classify_name, yylex): Replace "parse_language"
7901         with method call.
7902         * ada-exp.y (find_primitive_type, type_char)
7903         (type_system_address): Replace "parse_language" with method call.
7904
7905 2019-04-04  Tom Tromey  <tom@tromey.com>
7906
7907         * rust-exp.y: Replace "parse_gdbarch" with method call.
7908         * parse.c (write_dollar_variable, insert_type_address_space):
7909         Replace "parse_gdbarch" with method call.
7910         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7911         call.
7912         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7913         call.
7914         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7915         "parse_gdbarch" with method call.
7916         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7917         with method call.
7918         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7919         "parse_gdbarch" with method call.
7920         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7921         "parse_gdbarch" with method call.
7922         * c-exp.y (parse_type, parse_number, classify_name): Replace
7923         "parse_gdbarch" with method call.
7924         * ada-lex.l: Replace "parse_gdbarch" with method call.
7925         * ada-exp.y (parse_type, find_primitive_type, type_char)
7926         (type_system_address): Replace "parse_gdbarch" with method call.
7927
7928 2019-04-04  Tom Tromey  <tom@tromey.com>
7929
7930         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7931         * stap-probe.c (stap_parse_argument): Update.
7932         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7933         initial_size parameter.
7934         * rust-exp.y (rust_lex_tests): Update.
7935         * parse.c (parser_state): Update.
7936         (parse_exp_in_context): Update.
7937         * parser-defs.h (struct parser_state) <parser_state>: Remove
7938         "initial_size" parameter.
7939
7940 2019-04-04  Tom Tromey  <tom@tromey.com>
7941
7942         * parser-defs.h (increase_expout_size): Don't declare.
7943         * parse.c (increase_expout_size): Now static.
7944
7945 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7946
7947         * gnu-nat.c (gnu_nat_target::wait): Fix
7948         target_waitstatus_to_string call.
7949
7950 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7951
7952         * eval.c (evaluate_subexp_standard): Handle internal functions
7953         during Fortran function call handling.
7954
7955 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7956
7957         * NEWS: Mention new internal functions.
7958         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7959         (read_base_type): Use dwarf2_init_complex_target_type.
7960         * value.c (creal_internal_fn): New function.
7961         (cimag_internal_fn): New function.
7962         (_initialize_values): Register new internal functions.
7963
7964 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7965
7966         * infrun.c (stop_all_threads): If debug_infrun, always
7967         trace the wait status after wait_one, using
7968         target_waitstatus_to_string and target_pid_to_str.
7969         (handle_inferior_event): Replace various trace of
7970         wait status kind by a single trace.
7971         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7972         wait status kind image by target_waitstatus_to_string.
7973         * target/waitstatus.c (target_waitstatus_to_string): Fix
7974         obsolete comment.
7975
7976 2019-04-01  Tom Tromey  <tromey@adacore.com>
7977
7978         PR symtab/23331:
7979         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7980
7981 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7982             Pedro Alves  <palves@redhat.com>
7983
7984         * top.c (quit_force): Call 'finalize_values'.
7985         * value.c (finalize_values): New function.
7986         * value.h (finalize_values): Declare.
7987
7988 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7989
7990         * NEWS: Announce $_gdb_major and $_gdb_minor.
7991
7992         * top.c (init_gdb_version_vars): New function.
7993         (gdb_init): Call init_gdb_version_vars.
7994
7995 2019-03-29  Tom Tromey  <tromey@adacore.com>
7996
7997         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7998         help text.  Remove dead code.
7999
8000 2019-03-29  Keith Seitz  <keiths@redhat.com>
8001
8002         From Siddhesh Poyarekar:
8003         * f-lang.h (f77_get_upperbound): Return LONGEST.
8004         (f77_get_lowerbound): Likewise.
8005         * f-typeprint.c (f_type_print_varspec_suffix): Expand
8006         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
8007         print them.
8008         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
8009         plongest to format print it.
8010         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
8011         (f77_get_upperbound): Likewise.
8012         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
8013         LOWER_BOUND to LONGEST.
8014         (f77_create_arrayprint_offset_tbl): Likewise.
8015
8016 2019-03-29  Keith Seitz  <keiths@redhat.com>
8017
8018         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
8019         %s/pulongest for TYPE_LENGTH instead of %d in format
8020         strings.
8021         * ada-typerint.c (ada_print_type): Likewise.
8022         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
8023         * compile/compile-c-support.c (generate_register_struct): Likewise.
8024         * gdbtypes.c (recursive_dump_type): Likewise.
8025         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
8026         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
8027         instead of %d in format strings.
8028         * riscv-tdep.c (riscv_type_alignment): Cast second argument
8029         to std::min to ULONGEST.
8030         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8031         instead of %d in format strings.
8032         * tracepoint.c (info_scope_command): Likewise.
8033         * typeprint.c (print_offset_data::update)
8034         (print_offset_data::finish): Likewise.
8035         * xtensa-tdep.c (xtensa_store_return_value)
8036         (xtensa_push_dummy_call): Likewise.
8037
8038 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
8039
8040         * windows-nat.c (display_selector): Fixed format specifications
8041         for 64-bit Cygwin.
8042
8043 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8044
8045         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8046
8047 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
8048
8049         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8050         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8051         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8052         (nios2_linux_init_abi): Install it.
8053
8054 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8055
8056         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8057
8058 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8059
8060         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8061
8062 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8063             Tom Tromey  <tromey@adacore.com>
8064
8065         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8066
8067 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
8068
8069         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8070         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8071         method to compute the bounds of range types. Also print "[evaluated]"
8072         if the bounds' values come from a dynamic evaluation.
8073
8074 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8075
8076         * cp-valprint.c (cp_print_value_fields): Don't print trailing
8077         whitespace when pretty printing is on.
8078
8079 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8080
8081         * ppc-linux-nat.c: Add include.
8082
8083 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8084
8085         * NEWS: Mention AArch64 Pointer Authentication.
8086
8087 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8088
8089         * arm-linux-nat.c: Add include.
8090
8091 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
8092
8093         * source-cache.c (source_cache::get_source_lines): Re-read
8094         fullname after calling open_source_file.
8095
8096 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
8097
8098         * NEWS: Mention TLS support for FreeBSD.
8099
8100 2019-03-25  Tom Tromey  <tromey@adacore.com>
8101
8102         * minsyms.c (BUNCH_SIZE): Update comment.
8103         (~minimal_symbol_reader): Remove old comment.
8104         (compact_minimal_symbols): Update comment.
8105         (minimal_symbol_reader::install): Remove old comment.  Update
8106         other comments.
8107
8108 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8109
8110         * s390-linux-nat.c: Add include.
8111
8112 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8113
8114         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8115         Call linux_get_hwcap.
8116         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8117         Likewise.
8118         (aarch64_linux_get_hwcap): Remove function.
8119         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8120         declaration.
8121         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8122         linux_get_hwcap.
8123         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8124         * linux-tdep.c (linux_get_hwcap): Add function.
8125         (linux_get_hwcap2): Likewise.
8126         * linux-tdep.h (linux_get_hwcap): Add declaration.
8127         (linux_get_hwcap2): Likewise.
8128         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8129         (ppc_linux_get_hwcap2): Likewise.
8130         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8131         linux_get_hwcap.
8132         (ppc_linux_nat_target::insert_watchpoint): Likewise.
8133         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8134         (ppc_linux_nat_target::read_description): Likewise.
8135         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8136         * s390-linux-nat.c: Likewise.
8137         * s390-linux-tdep.c (s390_core_read_description): Likewise.
8138
8139 2019-03-24  Tom Tromey  <tom@tromey.com>
8140
8141         * ada-lang.c (standard_lookup): Simplify initialization.
8142         (ada_lookup_symbol_nonlocal): Simplify return.
8143         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8144         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8145         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8146         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8147         initialization.
8148         * solib.c (solib_global_lookup): Simplify.
8149         * symtab.c (null_block_symbol): Remove.
8150         (symbol_cache_lookup): Simplify returns.
8151         (lookup_language_this): Simplify returns.
8152         (lookup_symbol_aux): Simplify return.
8153         (lookup_local_symbol): Simplify returns.
8154         (lookup_global_symbol_from_objfile): Simplify return.
8155         (lookup_symbol_in_objfile_symtabs)
8156         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8157         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8158         (lookup_static_symbol, lookup_global_symbol): Simplify return.
8159         * cp-namespace.c (cp_lookup_bare_symbol)
8160         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8161         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8162         (cp_lookup_nested_symbol): Don't use null_block_symbol.
8163         (cp_lookup_symbol_via_imports): Simplify initialization.
8164         (find_symbol_in_baseclass): Likewise.
8165         * symtab.h (null_block_symbol): Remove.
8166         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8167         (d_lookup_nested_symbol, d_lookup_symbol_imports)
8168         (d_lookup_symbol_module): Likewise.
8169         (find_symbol_in_baseclass): Simplify initialization.
8170
8171 2019-03-24  Tom Tromey  <tom@tromey.com>
8172
8173         * expression.h: Don't include symtab.h.
8174         (struct block): Forward declare.
8175
8176 2019-03-24  Tom Tromey  <tom@tromey.com>
8177
8178         * c-exp.y (typebase): Remove casts.
8179         * gdbtypes.c (lookup_unsigned_typename, )
8180         (lookup_signed_typename): Remove cast.
8181         * eval.c (parse_to_comma_and_eval): Remove cast.
8182         * parse.c (write_dollar_variable): Remove cast.
8183         * block.h (struct block) <superblock>: Now const.
8184         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8185         * psymtab.c (psym_map_matching_symbols): Make "block" const.
8186         (map_block): Make "block" const.
8187         * symfile.h (struct quick_symbol_functions)
8188         <map_matching_symbols>: Constify block argument to "callback".
8189         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8190         const.
8191         (find_pc_sect_compunit_symtab): Make "b" const.
8192         (find_symbol_at_address): Likewise.
8193         (search_symbols): Likewise.
8194         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8195         (dw2_debug_names_lookup_symbol): Likewise.
8196         (dw2_map_matching_symbols): Update.
8197         * p-valprint.c (pascal_val_print): Remove "block".
8198         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8199         (aux_add_nonlocal_symbols): Make "block" const.
8200         (resolve_subexp): Remove cast.
8201         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8202         const.
8203         (iterate_over_file_blocks): Likewise.
8204         * f-exp.y (%union) <bval>: Remove.
8205         * coffread.c (patch_opaque_types): Make "b" const.
8206         * spu-tdep.c (spu_catch_start): Make "block" const.
8207         * c-valprint.c (print_unpacked_pointer): Remove "block".
8208         * symmisc.c (dump_symtab_1): Make "b" const.
8209         (block_depth): Make "block" const.
8210         * d-exp.y (%union) <bval>: Remove.
8211         * cp-support.h (cp_lookup_rtti_type): Update.
8212         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8213         * psymtab.c (psym_lookup_symbol): Make "block" const.
8214         (maintenance_check_psymtabs): Make "b" const.
8215         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8216         (enumerate_locals, enumerate_args): Update.
8217         * python/py-symtab.c (stpy_global_block): Make "block" const.
8218         (stpy_static_block): Likewise.
8219         * inline-frame.c (block_starting_point_at): Make "new_block"
8220         const.
8221         * block.c (find_block_in_blockvector): Make return type const.
8222         (blockvector_for_pc_sect): Make "b" const.
8223         (find_block_in_blockvector): Make "b" const.
8224
8225 2019-03-23  Tom Tromey  <tom@tromey.com>
8226
8227         * varobj.c (varobj_create): Update.
8228         * symfile.c (clear_symtab_users): Don't reset innermost_block.
8229         * printcmd.c (display_command, do_one_display): Don't reset
8230         innermost_block.
8231         * parser-defs.h (enum innermost_block_tracker_type): Move to
8232         expression.h.
8233         (innermost_block): Update comment.
8234         * parse.c (parse_exp_1): Add tracker_types parameter.
8235         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
8236         tracker_types parameter.  Reset innermost_block.
8237         (parse_exp_in_context): Remove.
8238         (parse_expression_for_completion): Update.
8239         * objfiles.c (~objfile): Don't reset expression_context_block or
8240         innermost_block.
8241         * expression.h (enum innermost_block_tracker_type): Move from
8242         parser-defs.h.
8243         (parse_exp_1): Add tracker_types parameter.
8244         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8245         reset innermost_block.
8246
8247 2019-03-23  Tom Tromey  <tom@tromey.com>
8248
8249         * objfiles.h: Include bcache.h.
8250
8251 2019-03-23  Tom Tromey  <tom@tromey.com>
8252
8253         * linespec.c (get_current_search_block): Use
8254         scoped_restore_current_language.
8255         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8256
8257 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8258             Jiong Wang  <jiong.wang@arm.com>
8259
8260         * aarch64-linux-tdep.c
8261         (aarch64_linux_iterate_over_regset_sections): Check for pauth
8262         section.
8263         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8264
8265 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8266             Jiong Wang  <jiong.wang@arm.com>
8267
8268         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8269         instructions.
8270         (aarch64_analyze_prologue_test): Add PACIASP test.
8271         (aarch64_prologue_prev_register): Unmask PC value.
8272
8273 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8274             Jiong Wang  <jiong.wang@arm.com>
8275
8276         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8277         (aarch64_dwarf2_prev_register): Unmask PC value.
8278         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8279         (aarch64_execute_dwarf_cfa_vendor_op): Check for
8280         DW_CFA_AARCH64_negate_ra_state.
8281         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8282
8283 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8284             Jiong Wang  <jiong.wang@arm.com>
8285
8286         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8287         registers.
8288         (aarch64_pseudo_register_name): Likewise.
8289         (aarch64_pseudo_register_type): Likewise.
8290         (aarch64_pseudo_register_reggroup_p): Likewise.
8291         (aarch64_gdbarch_init): Add pauth registers.
8292         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8293         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8294         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8295         (struct gdbarch_tdep): Add regnum for ra_state.
8296
8297 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8298             Jiong Wang  <jiong.wang@arm.com>
8299
8300         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8301
8302 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8303             Jiong Wang  <jiong.wang@arm.com>
8304
8305         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8306         function.
8307         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8308         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8309         (aarch64_gdbarch_init): Add puth registers.
8310         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8311         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8312         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8313
8314 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8315             Jiong Wang  <jiong.wang@arm.com>
8316
8317         * aarch64-linux-nat.c
8318         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8319         * aarch64-linux-tdep.c
8320         (aarch64_linux_core_read_description): Likewise.
8321         (aarch64_linux_get_hwcap): New function.
8322         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8323         (aarch64_linux_get_hwcap): New declaration.
8324
8325 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8326             Jiong Wang  <jiong.wang@arm.com>
8327
8328         * aarch64-linux-nat.c
8329         (aarch64_linux_nat_target::read_description): Add pauth param.
8330         * aarch64-linux-tdep.c
8331         (aarch64_linux_core_read_description): Likewise.
8332         * aarch64-tdep.c (struct target_desc): Add in pauth.
8333         (aarch64_read_description): Add pauth param.
8334         (aarch64_gdbarch_init): Likewise.
8335         * aarch64-tdep.h (aarch64_read_description): Likewise.
8336         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8337         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8338         * features/Makefile: Add new files.
8339         * features/aarch64-pauth.c: New file.
8340         * features/aarch64-pauth.xml: New file.
8341
8342 2019-03-20  Tom Tromey  <tromey@adacore.com>
8343
8344         * infrun.c (handle_inferior_event): Rename from
8345         handle_inferior_event_1.  Create a scoped_value_mark.
8346         (handle_inferior_event): Remove.
8347
8348 2019-03-19  Tom Tromey  <tromey@adacore.com>
8349
8350         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8351         * infrun.h (print_stop_event): Add "displays" parameter.
8352         * infrun.c (print_stop_event): Add "displays" parameter.
8353
8354 2019-03-19  Pedro Alves  <palves@redhat.com>
8355
8356         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8357         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8358         to -1.  Fix TABs vs spaces.
8359         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8360         * tui/tui-out.h (tui_ui_out) Add intro comments.
8361         <m_line, m_start_of_line>: In-class initialize, and add describing
8362         comment.
8363
8364 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8365
8366         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8367         variable names.
8368         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8369
8370 2019-03-18  Pedro Alves  <palves@redhat.com>
8371             Eli Zaretskii <eliz@gnu.org>
8372
8373         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8374         m_line and m_start_of_line.
8375
8376 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8377
8378         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8379         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8380         it returns a newline.  This fixes a regression in TU mode, whereby
8381         the next line is output on the same screen line as the user input.
8382
8383 2019-03-18  Tom Tromey  <tromey@adacore.com>
8384
8385         * minsyms.c (minimal_symbol_reader::install): Remove call to
8386         obstack_blank.
8387
8388 2019-03-18  Pedro Alves  <palves@redhat.com>
8389
8390         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8391         New globals.
8392         (apply_style): New, factored out from ...
8393         (apply_ansi_escape): ... this.  Handle reverse video mode.
8394         (tui_set_reverse_mode): New function.
8395         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8396         * tui/tui-winsource.c (tui_show_source_line): Use
8397         tui_set_reverse_mode instead of setting A_STANDOUT.
8398         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8399         New setter methods.
8400
8401 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8402
8403         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8404         Handle tabs.
8405
8406 2019-03-18  Tom Tromey  <tromey@adacore.com>
8407
8408         * ada-lang.c (empty_array): Add "high" parameter.
8409         (ada_evaluate_subexp): Update.
8410
8411 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8412
8413         * unittests/string_view-selftests.c: Define
8414         _initialize_string_view_selftests unconditionally.
8415
8416 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8417
8418         PR gdb/24350
8419         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8420
8421 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8422
8423         PR gdb/24351
8424         * windows-nat.c (display_selector): Fix format specifiers.
8425
8426 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8427
8428         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8429         tui_refill_source_window instead of tui_refresh_win, to update the
8430         current execution line.  This fixes redisplay of the current line
8431         when stepping through the code with "next" or "step".
8432
8433 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8434
8435         * source-cache.c (source_cache::get_source_lines): Call
8436         find_source_lines to initialize s->nlines.  This fixes vertical
8437         scrolling of TUI source window when the DOWN arrow is pressed.
8438
8439 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8440
8441         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8442         linux-thread-db.c (_initialize_thread_db): Likewise.
8443
8444 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8445
8446         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8447         wclrtoeol in tui_show_source_line".  This reverts changes made in
8448         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8449
8450 2019-03-15  Tom Tromey  <tom@tromey.com>
8451
8452         * symtab.h (struct minimal_symbol): Derive from
8453         general_symbol_info.
8454         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8455         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8456         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8457         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8458         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8459         (MSYMBOL_SEARCH_NAME): Update.
8460         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8461         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8462         * minsyms.c (minimal_symbol_reader::record_full): Update.
8463
8464 2019-03-15  Tom Tromey  <tom@tromey.com>
8465
8466         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8467
8468 2019-03-15  Tom Tromey  <tom@tromey.com>
8469
8470         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8471         unique_xmalloc_ptr.
8472         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8473         Update.
8474         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8475         (build_minimal_symbol_hash_tables)
8476         (minimal_symbol_reader::install): Update.
8477
8478 2019-03-15  Tom Tromey  <tom@tromey.com>
8479
8480         * symtab.c (create_demangled_names_hash): Update.
8481         (symbol_set_names): Update.
8482         * objfiles.h (struct objfile_per_bfd_storage)
8483         <demangled_names_hash>: Now an htab_up.
8484         * objfiles.c (objfile_per_bfd_storage): Simplify.
8485
8486 2019-03-15  Tom Tromey  <tom@tromey.com>
8487
8488         * objfiles.h (struct objfile_per_bfd_storage): Declare
8489         destructor.
8490         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8491         New.
8492         (get_objfile_bfd_data): Use new.  Don't initialize
8493         language_of_main.
8494         (free_objfile_per_bfd_storage): Remove.
8495         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8496
8497 2019-03-15  Tom Tromey  <tom@tromey.com>
8498
8499         * symfile.c (reread_symbols): Update.
8500         * objfiles.c (objfile::objfile): Update.
8501         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8502         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8503         comment.
8504         (minimal_symbol_reader::install): Update.
8505         (terminate_minimal_symbol_table): Remove.
8506         * jit.c (jit_object_close_impl): Update.
8507
8508 2019-03-15  Tom Tromey  <tom@tromey.com>
8509
8510         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8511         initializations.
8512
8513 2019-03-15  Tom Tromey  <tom@tromey.com>
8514
8515         * objfiles.h (struct objfile_per_bfd_storage)
8516         <demangled_hash_languages>: Now a bitset.
8517         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8518         (lookup_minimal_symbol): Update.
8519
8520 2019-03-15  Tom Tromey  <tom@tromey.com>
8521
8522         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8523         Don't return the symbol.
8524         * coffread.c (record_minimal_symbol): Use record_full.
8525
8526 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8527
8528         The MS-Windows port of ncurses fails to switch to a color pair if
8529         one or both of the colors are the implicit default colors.  This
8530         change records the default colors when TUI is initialized, and
8531         then specifies them explicitly when a color pair uses the default
8532         colors.  This allows color styling in TUI mode on MS-Windows.
8533
8534         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8535         ncurses_norm_attr.
8536         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8537         colors in ncurses_norm_attr.
8538         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8539         "none", replace it with the default color recorded in
8540         ncurses_norm_attr.
8541
8542 2019-03-14  Tom Tromey  <tromey@adacore.com>
8543
8544         * source-cache.h (class source_cache) <get_source_lines>: Return
8545         std::string.
8546         * source-cache.c (source_cache::extract_lines): Handle case where
8547         first_pos==npos.  Return std::string.
8548         (source_cache::get_source_lines): Update.
8549
8550 2019-03-14  Tom Tromey  <tromey@adacore.com>
8551
8552         * NEWS: Add item for "style sources" commands.
8553         * source-cache.c (source_cache::get_source_lines): Check
8554         source_styling.
8555         * cli/cli-style.c (source_styling): New global.
8556         (_initialize_cli_style): Add "style sources" commands.
8557         (show_style_sources): New function.
8558         * cli/cli-style.h (source_styling): Declare.
8559
8560 2019-03-14  Pedro Alves  <palves@redhat.com>
8561             Tom Tromey  <tromey@adacore.com>
8562
8563         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8564         * tui/tui-winsource.c (tui_refill_source_window): New function,
8565         from...
8566         (tui_horizontal_source_scroll): ... here.  Move some logic.
8567         * cli/cli-style.c (set_style_enabled): Notify new observable.
8568         * tui/tui-hooks.c (tui_redisplay_source): New function.
8569         (tui_attach_detach_observers): Attach or detach
8570         tui_redisplay_source.
8571         * observable.h (source_styling_changed): New observable.
8572         * observable.c: Define source_styling_changed observable.
8573
8574 2019-03-13  Tom Tromey  <tromey@adacore.com>
8575
8576         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8577         (i386_gnu_nat_target::store_registers): Update.
8578         * target-debug.h (target_debug_print_std_string): New macro.
8579         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8580         * windows-tdep.c (display_one_tib): Update.
8581         * tui/tui-stack.c (tui_make_status_line): Update.
8582         * top.c (print_inferior_quit_action): Update.
8583         * thread.c (thr_try_catch_cmd): Update.
8584         (add_thread_with_info): Update.
8585         (thread_target_id_str): Update.
8586         (thr_try_catch_cmd): Update.
8587         (thread_command): Update.
8588         (thread_find_command): Update.
8589         * record-btrace.c (record_btrace_target::info_record)
8590         (record_btrace_resume_thread, record_btrace_target::resume)
8591         (record_btrace_cancel_resume, record_btrace_step_thread)
8592         (record_btrace_target::wait, record_btrace_target::wait)
8593         (record_btrace_target::wait, record_btrace_target::stop): Update.
8594         * progspace.c (print_program_space): Update.
8595         * process-stratum-target.c
8596         (process_stratum_target::thread_address_space): Update.
8597         * linux-fork.c (linux_fork_mourn_inferior)
8598         (detach_checkpoint_command, info_checkpoints_command)
8599         (linux_fork_context): Update.
8600         (linux_fork_detach): Update.
8601         (class scoped_switch_fork_info): Update.
8602         (delete_checkpoint_command): Update.
8603         * infrun.c (follow_fork_inferior): Update.
8604         (follow_fork_inferior): Update.
8605         (proceed_after_vfork_done): Update.
8606         (handle_vfork_child_exec_or_exit): Update.
8607         (follow_exec): Update.
8608         (displaced_step_prepare_throw): Update.
8609         (displaced_step_restore): Update.
8610         (start_step_over): Update.
8611         (resume_1): Update.
8612         (clear_proceed_status_thread): Update.
8613         (proceed): Update.
8614         (print_target_wait_results): Update.
8615         (do_target_wait): Update.
8616         (context_switch): Update.
8617         (stop_all_threads): Update.
8618         (restart_threads): Update.
8619         (finish_step_over): Update.
8620         (handle_signal_stop): Update.
8621         (switch_back_to_stepped_thread): Update.
8622         (keep_going_pass_signal): Update.
8623         (print_exited_reason): Update.
8624         (normal_stop): Update.
8625         * inferior.c (inferior_pid_to_str): Change return type.
8626         (print_selected_inferior): Update.
8627         (add_inferior): Update.
8628         (detach_inferior): Update.
8629         * dummy-frame.c (fprint_dummy_frames): Update.
8630         * dcache.c (dcache_info_1): Update.
8631         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8632         (btrace_fetch, btrace_clear): Update.
8633         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8634         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8635         type.
8636         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8637         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8638         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8639         * gdbarch.c, gdbarch.h: Rebuild.
8640         * gdbarch.sh (core_pid_to_str): Change return type.
8641         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8642         return type.
8643         (windows_nat_target::pid_to_str): Change return type.
8644         (windows_delete_thread): Update.
8645         (windows_nat_target::attach): Update.
8646         (windows_nat_target::files_info): Update.
8647         * target-delegates.c: Rebuild.
8648         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8649         return type.
8650         (sol_thread_target::pid_to_str): Change return type.
8651         * remote.c (class remote_target) <pid_to_str>: Change return
8652         type.
8653         (remote_target::pid_to_str): Change return type.
8654         (extended_remote_target::attach, remote_target::remote_stop_ns)
8655         (remote_target::remote_notif_remove_queued_reply)
8656         (remote_target::push_stop_reply, remote_target::disable_btrace):
8657         Update.
8658         (extended_remote_target::attach): Update.
8659         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8660         type.
8661         (gdbsim_target::pid_to_str): Change return type.
8662         * ravenscar-thread.c (struct ravenscar_thread_target)
8663         <pid_to_str>: Change return type.
8664         (ravenscar_thread_target::pid_to_str): Change return type.
8665         * procfs.c (class procfs_target) <pid_to_str>: Change return
8666         type.
8667         (procfs_target::pid_to_str): Change return type.
8668         (procfs_target::attach): Update.
8669         (procfs_target::detach): Update.
8670         (procfs_target::fetch_registers): Update.
8671         (procfs_target::store_registers): Update.
8672         (procfs_target::wait): Update.
8673         (procfs_target::files_info): Update.
8674         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8675         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8676         return type.
8677         (nto_procfs_target::pid_to_str): Change return type.
8678         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8679         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8680         return type.
8681         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8682         (exit_lwp): Update.
8683         (attach_proc_task_lwp_callback, get_detach_signal)
8684         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8685         (linux_nat_target::resume, wait_lwp, stop_callback)
8686         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8687         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8688         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8689         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8690         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8691         type.
8692         (inf_ptrace_target::attach): Update.
8693         (inf_ptrace_target::files_info): Update.
8694         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8695         type.
8696         (go32_nat_target::pid_to_str): Change return type.
8697         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8698         (gnu_nat_target::wait): Update.
8699         (gnu_nat_target::wait): Update.
8700         (gnu_nat_target::resume): Update.
8701         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8702         (fbsd_nat_target::wait): Update.
8703         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8704         type.
8705         (darwin_nat_target::attach): Update.
8706         * corelow.c (class core_target) <pid_to_str>: Change return type.
8707         (core_target::pid_to_str): Change return type.
8708         * target.c (normal_pid_to_str): Change return type.
8709         (default_pid_to_str): Likewise.
8710         (target_pid_to_str): Change return type.
8711         (target_translate_tls_address): Update.
8712         (target_announce_detach): Update.
8713         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8714         return type.
8715         (bsd_uthread_target::pid_to_str): Change return type.
8716         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8717         type.
8718         (bsd_kvm_target::pid_to_str): Change return type.
8719         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8720         return type.
8721         (aix_thread_target::pid_to_str): Change return type.
8722         * target.h (struct target_ops) <pid_to_str>: Change return type.
8723         (target_pid_to_str, normal_pid_to_str): Likewise.
8724         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8725         type.
8726         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8727         type.
8728         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8729         return type.
8730         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8731         type.
8732         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8733         type.
8734         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8735         return type.
8736
8737 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8738
8739         * NEWS: Mention that the new default MI version is 3.  Mention
8740         changes to the output of commands and events that deal with
8741         multi-location breakpoints.
8742         * breakpoint.c: Include "mi/mi-out.h".
8743         (print_one_breakpoint): Change output syntax if using MI version
8744         >= 3.
8745         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8746         New.
8747         (mi_multi_location_breakpoint_output_fixed): New.
8748         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8749         (mi_cmd_fix_multi_location_breakpoint_output): New.
8750         (mi_multi_location_breakpoint_output_fixed): New.
8751         * mi/mi-cmds.c (mi_cmds): Register command
8752         -fix-multi-location-breakpoint-output.
8753         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8754         interpreter "mi".
8755
8756 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8757
8758         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8759         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8760         instantiate mi_ui_out based on interpreter name.
8761         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8762         * mi/mi-main.c (mi_load_progress): Likewise.
8763
8764 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8765
8766         * NEWS: Combine separate "New targets" sections for 8.3.
8767
8768 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8769
8770         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8771         (ppcfbsd_init_abi): Install gdbarch
8772         "fetch_tls_load_module_address" and "get_thread_local_address"
8773         methods.
8774
8775 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8776
8777         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8778         (riscv_fbsd_init_abi): Install gdbarch
8779         "fetch_tls_load_module_address" and "get_thread_local_address"
8780         methods.
8781
8782 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8783
8784         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8785         (i386fbsd_init_abi): Install gdbarch
8786         "fetch_tls_load_module_address" and "get_thread_local_address"
8787         methods.
8788
8789 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8790
8791         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8792         (amd64fbsd_init_abi): Install gdbarch
8793         "fetch_tls_load_module_address" and "get_thread_local_address"
8794         methods.
8795
8796 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8797
8798         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8799         (struct fbsd_pspace_data): New type.
8800         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8801         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8802         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8803         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8804         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8805
8806 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8807
8808         * gdbtypes.c (lookup_struct_elt): New function.
8809         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8810         * gdbtypes.h (struct struct_elt): New type.
8811         (lookup_struct_elt): New prototype.
8812
8813 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8814
8815         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8816         remove disabled code block.
8817
8818 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8819
8820         * gdbarch.sh (get_thread_local_address): New method.
8821         * gdbarch.h, gdbarch.c: Regenerate.
8822         * target.c (target_translate_tls_address): Use
8823         gdbarch_get_thread_local_address if present instead of
8824         target::get_thread_local_address.
8825
8826 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8827
8828         * target.h (target::get_thread_local_address): Update comment.
8829
8830 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8831
8832         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8833         objfile->separate_debug_objfile_backlink if not NULL.
8834
8835 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8836
8837         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8838         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8839         (amd64bsd_store_inferior_registers): Likewise.
8840         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8841         Enable segment base registers.
8842         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8843         PT_GETFSBASE and PT_GETGSBASE.
8844         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8845         PT_SETGSBASE.
8846         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8847         segment base registers.
8848         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8849
8850 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8851
8852         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8853         Update calls to i386_target_description to add 'segments'
8854         parameter.
8855         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8856         add segment base registers.
8857         * arch/i386.c (i386_create_target_description): Add 'segments'
8858         parameter to enable segment base registers.
8859         * arch/i386.h (i386_create_target_description): Likewise.
8860         * features/i386/32bit-segments.xml: New file.
8861         * features/i386/32bit-segments.c: Generate.
8862         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8863         call to i386_target_description to add 'segments' parameter.
8864         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8865         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8866         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8867         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8868         if feature is present.
8869         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8870         Add 'segments' parameter to call to i386_target_description.
8871         (i386_target_description): Add 'segments' parameter to enable
8872         segment base registers.
8873         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8874         to call to i386_target_description.
8875         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8876         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8877         Define I386_NUM_REGS.
8878         (i386_target_description): Add 'segments' parameter to enable
8879         segment base registers.
8880
8881 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8882
8883         PR/24325
8884         * source-cache.c: #undef open and close, to avoid unresolved
8885         externals during linking.
8886
8887 2019-03-12  Tom Tromey  <tromey@adacore.com>
8888
8889         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8890         const.  Add initializers.
8891         (_initialize_remote): Don't initialize ptid globals.
8892
8893 2019-03-12  Pedro Alves  <palves@redhat.com>
8894
8895         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8896
8897 2019-03-12  Pedro Alves  <palves@redhat.com>
8898
8899         * cp-name-parser.y (main): Remove unused 'len' variable.
8900
8901 2019-03-12  Tom Tromey  <tromey@adacore.com>
8902
8903         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8904         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8905
8906 2019-03-12  Tom Tromey  <tromey@adacore.com>
8907
8908         * linux-nat.c (iterate_over_lwps): Update.
8909         (stop_callback): Remove parameter.
8910         (stop_wait_callback, detach_callback, resume_set_callback)
8911         (select_singlestep_lwp_callback, set_ignore_sigint)
8912         (status_callback, resumed_callback, resume_clear_callback)
8913         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8914         data parameter.
8915         (linux_nat_target::detach, linux_nat_target::resume)
8916         (linux_stop_and_wait_all_lwps, select_event_lwp)
8917         (linux_nat_filter_event, linux_nat_wait_1)
8918         (linux_nat_target::kill, linux_nat_target::stop)
8919         (linux_nat_target::stop): Update.
8920         (linux_nat_resume_callback): Change type.
8921         (resume_stopped_resumed_lwps, count_events_callback)
8922         (select_event_lwp_callback): Likewise.
8923         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8924         * arm-linux-nat.c (struct update_registers_data): Remove.
8925         (update_registers_callback): Change type.
8926         (arm_linux_insert_hw_breakpoint1): Update.
8927         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8928         parameter.
8929         (x86_linux_dr_set_addr): Update.
8930         (x86_linux_dr_set_control): Update.
8931         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8932         (iterate_over_lwps): Use gdb::function_view.
8933         * nat/aarch64-linux-hw-point.c (struct
8934         aarch64_dr_update_callback_param): Remove.
8935         (debug_reg_change_callback): Change type.
8936         (aarch64_notify_debug_reg_change): Update.
8937         * s390-linux-nat.c (s390_refresh_per_info): Update.
8938
8939 2019-03-11  Tom Tromey  <tromey@adacore.com>
8940
8941         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8942         redundant assignment to "this_cu".
8943
8944 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8945
8946         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8947
8948 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8949
8950         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8951         from...
8952         (rank_one_type): ... this.
8953
8954 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8955
8956         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8957         from...
8958         (rank_one_type): ... this.
8959
8960 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8961
8962         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8963         from...
8964         (rank_one_type): ... this.
8965
8966 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8967
8968         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8969         from...
8970         (rank_one_type): ... this.
8971
8972 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8973
8974         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8975         from...
8976         (rank_one_type): ... this.
8977
8978 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8979
8980         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8981         from...
8982         (rank_one_type): ... this.
8983
8984 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8985
8986         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8987         from...
8988         (rank_one_type): ... this.
8989
8990 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8991
8992         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8993         from...
8994         (rank_one_type): ... this.
8995
8996 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8997
8998         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8999         from...
9000         (rank_one_type): ... this.
9001
9002 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9003
9004         * gdbtypes.c (rank_one_type_parm_func): New function extracted
9005         from...
9006         (rank_one_type): ... this.
9007
9008 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9009
9010         * gdbtypes.c (rank_one_type_parm_array): New function extracted
9011         from...
9012         (rank_one_type): ... this.
9013
9014 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9015
9016         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
9017         from...
9018         (rank_one_type): ... this.
9019
9020 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9021
9022         * inferior.c (initialize_inferiors): Ensure 'help set/show print
9023         inferior-events' shows the example events.
9024
9025 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
9026
9027         Support styling on native MS-Windows console
9028
9029         PR/24315
9030         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9031         on MS-Windows if $TERM is not defined.
9032
9033         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9034
9035         * posix-hdep.c (gdb_console_fputs):
9036         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9037         functions.
9038         * ui-file.h (gdb_console_fputs): Add prototype.
9039
9040         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9041         back to fputs only if the former returns zero.
9042
9043 2019-03-07  Tom Tromey  <tom@tromey.com>
9044
9045         * symmisc.c (print_symbol_bcache_statistics): Update.
9046         (print_objfile_statistics): Update.
9047         * symfile.c (allocate_symtab): Update.
9048         * stabsread.c: Don't include bcache.h.
9049         * psymtab.h (struct psymbol_bcache): Don't declare.
9050         (class psymtab_storage) <psymbol_cache>: Now a bcache.
9051         (psymbol_bcache_init, psymbol_bcache_free)
9052         (psymbol_bcache_get_bcache): Don't declare.
9053         * psymtab.c (struct psymbol_bcache): Remove.
9054         (psymtab_storage::psymtab_storage): Update.
9055         (psymtab_storage::~psymtab_storage): Update.
9056         (psymbol_bcache_init, psymbol_bcache_free)
9057         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9058         (add_psymbol_to_bcache): Update.
9059         (allocate_psymtab): Update.
9060         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9061         macro_cache>: No longer pointers.
9062         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9063         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9064         * macrotab.c (macro_bcache): Update.
9065         * macroexp.c: Don't include bcache.h.
9066         * gdbtypes.c (check_types_worklist): Update.
9067         (types_deeply_equal): Remove TRY/CATCH.  Update.
9068         * elfread.c (elf_symtab_read): Update.
9069         * dwarf2read.c: Don't include bcache.h.
9070         * buildsym.c (buildsym_compunit::get_macro_table): Update.
9071         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9072         (print_bcache_statistics, bcache_memory_used): Don't declare.
9073         (struct bcache): Move from bcache.c.  Add constructor, destructor,
9074         methods.  Rename all data members.
9075         * bcache.c (struct bcache): Move to bcache.h.
9076         (bcache::expand_hash_table): Rename from expand_hash_table.
9077         (bcache): Remove.
9078         (bcache::insert): Rename from bcache_full.
9079         (bcache::compare): Rename from bcache_compare.
9080         (bcache_xmalloc): Remove.
9081         (bcache::~bcache): Rename from bcache_xfree.
9082         (bcache::print_statistics): Rename from print_bcache_statistics.
9083         (bcache::memory_used): Rename from bcache_memory_used.
9084
9085 2019-03-07  Pedro Alves  <palves@redhat.com>
9086
9087         * infrun.c (normal_stop): Also check for
9088         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9089
9090 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
9091
9092         * f-lang.c (value_from_host_double): Moved to...
9093         * value.c (value_from_host_double): ...here.
9094         * value.h (value_from_host_double): Declare.
9095         * guile/scm-math.c (vlscm_convert_typed_number): Use
9096         value_from_host_double.
9097         (vlscm_convert_number): Likewise.
9098         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9099         * python/py-value.c (convert_value_from_python): Likewise.
9100
9101 2019-03-06  Tom Tromey  <tom@tromey.com>
9102
9103         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9104
9105 2019-03-06  Tom Tromey  <tom@tromey.com>
9106
9107         * utils.h (free_current_contents): Don't declare.
9108         * utils.c (free_current_contents): Remove.
9109
9110 2019-03-06  Tom Tromey  <tom@tromey.com>
9111
9112         * top.c (quit_force): Update.
9113         * main.c (captured_command_loop): Update.
9114         * common/new-op.c (operator new): Update.
9115         * common/common-exceptions.c (struct catcher)
9116         <save_cleanup_chain>: Remove member.
9117         (exceptions_state_mc_init): Update.
9118         (exception_try_scope_entry): Return nullptr.
9119         (exception_try_scope_exit, exception_rethrow)
9120         (throw_exception_sjlj, throw_exception_cxx): Update.
9121         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9122         (all_cleanups, do_cleanups, discard_cleanups)
9123         (discard_final_cleanups, save_cleanups, save_final_cleanups)
9124         (restore_cleanups, restore_final_cleanups): Don't declare.
9125         (do_final_cleanups): Remove parameter.
9126         * common/cleanups.c (cleanup_chain, make_cleanup)
9127         (make_cleanup_dtor, all_cleanups, do_cleanups)
9128         (discard_my_cleanups, discard_cleanups)
9129         (discard_final_cleanups, save_my_cleanups, save_cleanups)
9130         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9131         (null_cleanup): Remove.
9132         (do_final_cleanups): Remove parameter.
9133
9134 2019-03-06  Tom Tromey  <tom@tromey.com>
9135
9136         * remote.c (remote_target::remote_parse_stop_reply): Use
9137         unique_xmalloc_ptr.
9138
9139 2019-03-06  Tom Tromey  <tom@tromey.com>
9140
9141         * stabsread.c (struct stabs_field_info): Rename from field_info.
9142         <list, fnlist>: Add initializers.
9143         <obstack>: New member.
9144         (read_member_functions, read_struct_fields, read_baseclasses):
9145         Allocate on obstack.  Don't use cleanups.
9146         (read_one_struct_field, read_member_functions, read_struct_fields)
9147         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9148         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9149         (read_struct_type): Update.
9150
9151 2019-03-06  Tom Tromey  <tom@tromey.com>
9152
9153         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9154         * common/filestuff.h (make_cleanup_close): Don't declare.
9155         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9156         Remove.
9157
9158 2019-03-06  Tom Tromey  <tom@tromey.com>
9159
9160         * solib-aix.c: Use make_scope_exit.
9161
9162 2019-03-06  Tom Tromey  <tom@tromey.com>
9163
9164         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9165         Use make_scope_exit.
9166
9167 2019-03-06  Tom Tromey  <tom@tromey.com>
9168
9169         * solib-svr4.c (disable_probes_interface): Remove parameter.
9170         (svr4_handle_solib_event): Use make_scope_exit.
9171
9172 2019-03-06  Tom Tromey  <tom@tromey.com>
9173
9174         * remote.c (struct stop_reply_deleter): Remove.
9175         (stop_reply_up): Update.
9176         (struct stop_reply): Derive from notif_event.  Don't typedef.
9177         <regcache>: Now a std::vector.
9178         (stop_reply_xfree): Remove.
9179         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9180         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
9181         (remote_target::discard_pending_stop_replies): Use delete.
9182         (remote_target::remote_parse_stop_reply): Update.
9183         (remote_target::process_stop_reply): Update.
9184         * remote-notif.h (struct notif_event): Add virtual destructor.
9185         Remove "dtr" member.
9186         (struct notif_client) <alloc_event>: Return a unique_ptr.
9187         (notif_event_xfree): Don't declare.
9188         (notif_event_up): New typedef.
9189         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9190         (notif_event_xfree, do_notif_event_xfree): Remove.
9191         (remote_notif_state_xfree): Update.
9192
9193 2019-03-06  Tom Tromey  <tom@tromey.com>
9194
9195         * infrun.c (displaced_step_clear_cleanup): Now a
9196         forward_scope_exit type.
9197         (displaced_step_prepare_throw): Update.
9198         (displaced_step_fixup): Update.
9199
9200 2019-03-06  Tom Tromey  <tom@tromey.com>
9201
9202         * inferior.h (class inferior): Update comment.
9203         * gdbthread.h (class thread_info): Update comment.
9204
9205 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
9206             Tom Tromey  <tom@tromey.com>
9207
9208         * stabsread.h (struct stab_section_list): Remove.
9209         (coffstab_build_psymtabs): Update.
9210         * dbxread.c (symbuf_sections): Now a std::vector.
9211         (sect_idx): New global.
9212         (fill_symbuf): Update.
9213         (coffstab_build_psymtabs): Change type of stabsects parameter.
9214         Update.
9215         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9216         std::vector.
9217         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9218         (coff_locate_sections): Update.
9219         (coff_symfile_read): Remove cleanups.  Update.
9220         (init_stringtab): Add storage parameter.
9221         (free_stringtab, free_stringtab_cleanup): Remove.
9222         (init_lineno): Add storage parameter.
9223         (free_linetab, free_linetab_cleanup): Remove.
9224
9225 2019-03-06  Pedro Alves  <palves@redhat.com>
9226
9227         * linux-fork.c (fork_info::clobber_regs): Delete.
9228         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9229         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
9230         comment.  Adjust.
9231         (scoped_switch_fork_info::scoped_switch_fork_info)
9232         (checkpoint_command, linux_fork_context): Adjust
9233         fork_save_infrun_state calls.
9234
9235 2019-03-06  Pedro Alves  <palves@redhat.com>
9236
9237         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9238         (inf_has_multiple_threads): Return 'bool' and rewrite using
9239         inferior_info::threads().
9240
9241 2019-03-06  Pedro Alves  <palves@redhat.com>
9242
9243         * linux-fork.c: Include <list>.
9244         (fork_list): Now a std::list instance.
9245         (fork_info): Add ctor, dtor, and in-class initialize all fields.
9246         (forks_exist_p, find_last_fork): Adjust.
9247         (new_fork): Delete.
9248         (one_fork_p): New.
9249         (add_fork): Adjust.
9250         (free_fork): Delete, folded into fork_info::~fork_info().
9251         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9252         Adjust.
9253         (init_fork_list): Delete.
9254         (linux_fork_killall, linux_fork_mourn_inferior)
9255         (linux_fork_detach, info_checkpoints_command): Adjust.
9256         (_initialize_linux_fork): No longer call init_fork_list.
9257
9258 2019-03-06  Pedro Alves  <palves@redhat.com>
9259
9260         * linux-fork.c (new_fork): New, split out of ...
9261         (add_fork): ... this.  Return void.  Move "first fork" special
9262         case from here, to ...
9263         (checkpoint_command): ... here.
9264         * linux-linux.h (add_fork): Return void.
9265
9266 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9267
9268         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9269
9270 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9271             Chris January  <chris.january@arm.com>
9272             David Lecomber  <david.lecomber@arm.com>
9273
9274         * f-exp.y: New token, UNOP_INTRINSIC.
9275         (exp): New pattern using UNOP_INTRINSIC token.
9276         (f77_keywords): Add 'abs' keyword.
9277         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9278         (value_from_host_double): New function.
9279         (evaluate_subexp_f): Support UNOP_ABS.
9280
9281 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9282
9283         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9284         types.
9285
9286 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9287
9288         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9289         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9290         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9291
9292 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9293
9294         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9295
9296 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9297             Chris January  <chris.january@arm.com>
9298
9299         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9300         * f-exp.y: Define 'KIND' token.
9301         (exp): New pattern for KIND expressions.
9302         (ptype): Handle types with a kind extension.
9303         (direct_abs_decl): Extend to spot kind extensions.
9304         (f77_keywords): Add 'kind' to the list.
9305         (push_kind_type): New function.
9306         (convert_to_kind_type): New function.
9307         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9308         * parse.c (operator_length_standard): Likewise.
9309         * parser-defs.h (enum type_pieces): Add tp_kind.
9310         * std-operator.def: Add UNOP_KIND.
9311
9312 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9313
9314         * f-exp.y (f_parse): Set yydebug.
9315
9316 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9317
9318         * f-lang.c (evaluate_subexp_f): New function.
9319         (exp_descriptor_f): New global.
9320         (f_language_defn): Use exp_descriptor_f instead of
9321         exp_descriptor_standard.
9322
9323 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9324
9325         * f-exp.y (struct token): Add comments.
9326         (dot_ops): Remove uppercase versions and the end marker.
9327         (f77_keywords): Likewise.
9328         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9329         entries in the dot_ops array are case insensitive, and use
9330         strncasecmp to compare strings.  Also some whitespace cleanup in
9331         this area.  Similar for the f77_keywords array, except entries in
9332         this list might be case sensitive.
9333
9334 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9335
9336         * f-exp.y (struct f77_boolean_val): Add comments.
9337         (boolean_values): Remove uppercase versions, and end marker.
9338         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9339         and use strncasecmp to achieve case insensitivity.  Additionally,
9340         perform whitespace cleanup around this code.
9341
9342 2019-03-06  Tom Tromey  <tromey@adacore.com>
9343
9344         * remote-sim.c (gdbsim_target_open): Use result of
9345         gdb_argv::release.
9346
9347 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9348         Dirk Schubert  <dirk.schubert@arm.com>
9349         Chris January  <chris.january@arm.com>
9350
9351         * eval.c (evaluate_subexp_standard): Call Fortran argument
9352         wrapping logic.
9353         * f-lang.c (struct value): A value which can be passed into a
9354         Fortran function call.
9355         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9356         where appropriate.
9357         (struct type): Value ready for a Fortran function call.
9358         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9359         is needed.
9360         * f-lang.h (fortran_argument_convert): Declaration.
9361         (fortran_preserve_arg_pointer): Declaration.
9362         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9363
9364 2019-03-05  Tom Tromey  <tromey@adacore.com>
9365
9366         * python/py-prettyprint.c (print_string_repr): Remove #if.
9367         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9368
9369 2019-03-05  Tom Tromey  <tromey@adacore.com>
9370
9371         * target.c (the_dummy_target): Move later.  Change type to
9372         "dummy_target".
9373         (initialize_targets): Don't initialize the_dummy_target.
9374
9375 2019-03-05  Tom Tromey  <tromey@adacore.com>
9376
9377         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9378         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9379
9380 2019-03-05  Tom Tromey  <tromey@adacore.com>
9381
9382         * windows-nat.c (windows_nat_target::attach)
9383         (windows_nat_target::detach): Don't call gdb_flush.
9384         * valprint.c (generic_val_print, val_print, val_print_string):
9385         Don't call gdb_flush.
9386         * utils.c (defaulted_query): Don't call gdb_flush.
9387         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9388         * target.c (target_announce_detach): Don't call gdb_flush.
9389         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9390         * remote.c (extended_remote_target::attach): Don't call
9391         gdb_flush.
9392         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9393         * printcmd.c (do_examine): Don't call gdb_flush.
9394         (info_display_command): Don't call gdb_flush.
9395         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9396         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9397         * memattr.c (info_mem_command): Don't call gdb_flush.
9398         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9399         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9400         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9401         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9402         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9403         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9404         (gnu_nat_target::detach): Don't call gdb_flush.
9405         * f-valprint.c (f_val_print): Don't call gdb_flush.
9406         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9407         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9408         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9409         gdb_flush.
9410         * c-valprint.c (c_val_print): Don't call gdb_flush.
9411         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9412
9413 2019-03-05  Tom Tromey  <tromey@adacore.com>
9414
9415         * varobj.c (update_dynamic_varobj_children): Update.
9416         (install_default_visualizer): Use reset, not release.
9417         * value.c (set_internalvar): Update.
9418         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9419         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9420         ATTRIBUTE_UNUSED_RESULT.
9421
9422 2019-03-05  Tom Tromey  <tromey@adacore.com>
9423
9424         * remote.c (class scoped_remote_fd) <release>: Add
9425         ATTRIBUTE_UNUSED_RESULT.
9426
9427 2019-03-05  Tom Tromey  <tromey@adacore.com>
9428
9429         * macroexp.c (struct macro_buffer) <release>: Add
9430         ATTRIBUTE_UNUSED_RESULT.
9431
9432 2019-03-05  Tom Tromey  <tromey@adacore.com>
9433
9434         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9435         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9436         ATTRIBUTE_UNUSED_RESULT.
9437
9438 2019-03-05  Tom Tromey  <tromey@adacore.com>
9439
9440         * common/scoped_fd.h (class scoped_fd) <release>: Add
9441         ATTRIBUTE_UNUSED_RESULT.
9442
9443 2019-03-05  Tom Tromey  <tromey@adacore.com>
9444
9445         * parser-defs.h (struct parser_state) <release>: Add
9446         ATTRIBUTE_UNUSED_RESULT.
9447
9448 2019-03-05  Tom Tromey  <tromey@adacore.com>
9449
9450         * utils.h (class gdb_argv) <release>: Add
9451         ATTRIBUTE_UNUSED_RESULT.
9452         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9453
9454 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9455
9456         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9457         for-loop range, to avoid compiler warnings.
9458
9459         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9460         avoid compiler warnings about unused variables.
9461
9462         * NEWS: Mention end of support for native debugging on MS-Windows
9463         before XP.
9464
9465         PR gdb/24292
9466         * common/netstuff.c:
9467         * gdbserver/gdbreplay.c
9468         * gdbserver/remote-utils.c:
9469         * ser-tcp.c:
9470         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9471         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9472         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9473         'getaddrinfo' and 'freeaddrinfo' were not available before
9474         Windows XP, and mingw.org's MinGW headers by default define
9475         _WIN32_WINNT to 0x500.
9476
9477 2019-03-01  Gary Benson <gbenson@redhat.com>
9478
9479         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9480
9481 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9482             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9483
9484         PR gdb/8527
9485         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9486         set_sigint_trap, clear_sigint_trap.
9487
9488 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9489
9490         * target.c (target_detach): Clear the regcache and the
9491         frame cache.
9492
9493 2019-02-27  Pedro Alves  <palves@redhat.com>
9494
9495         * utils.c (set_screen_size): When we cap the height/width sizes,
9496         tweak the corresponding command variable to show "unlimited":
9497
9498 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9499             Pedro Alves  <palves@redhat.com>
9500
9501         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9502         before calling rl_set_screen_size.
9503
9504 2019-02-27  Tom Tromey  <tromey@adacore.com>
9505
9506         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9507         define.
9508         * python/py-value.c: Remove Python 2.4 workaround.
9509         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9510         workaround.
9511         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9512         Python 2.4 workaround.
9513         * python/python-internal.h: Remove Python 2.4 comment.
9514         (Py_ssize_t): Don't define.
9515         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9516         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9517         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9518         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9519         * python/python.c (do_start_initialization): Remove Python 2.4
9520         workaround.
9521         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9522         (print_children): Remove Python 2.4 workaround.
9523         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9524         workaround.
9525         (CHARBUFFERPROC_NAME): Remove.
9526         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9527         Python 2.4 workaround.
9528
9529 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9530
9531         * NEWS: Note minimum Python version.
9532
9533 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9534
9535         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9536         code from these functions.  Remove corresponding ifdefs.  Use
9537         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9538         Remove gotos and target of gotos.
9539         (infpy_search_memory): Likewise.
9540
9541 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9542
9543         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9544         (hppa_gdbarch_init): Don't register deleted functions with
9545         gdbarch.
9546
9547 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9548
9549         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9550         (h8300_unwind_sp): Delete.
9551         (h8300_dummy_id): Delete.
9552         (h8300_gdbarch_init): Don't register deleted functions with
9553         gdbarch.
9554
9555 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9556
9557         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9558         (ft32_unwind_pc): Delete.
9559         (ft32_unwind_sp): Delete.
9560         (ft32_gdbarch_init): Don't register deleted functions with
9561         gdbarch.
9562
9563 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9564
9565         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9566         (frv_unwind_pc): Delete.
9567         (frv_unwind_sp): Delete.
9568         (frv_gdbarch_init): Don't register deleted functions with
9569         gdbarch.
9570
9571 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9572
9573         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9574         (riscv_unwind_pc): Delete.
9575         (riscv_unwind_sp): Delete.
9576         (riscv_gdbarch_init): Don't register deleted functions with
9577         gdbarch.
9578
9579 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9580
9581         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9582         (csky_unwind_pc): Delete.
9583         (csky_unwind_sp): Delete.
9584         (csky_gdbarch_init): Don't register deleted functions with
9585         gdbarch.
9586
9587 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9588
9589         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9590         (cris_unwind_pc): Delete.
9591         (cris_unwind_sp): Delete.
9592         (cris_gdbarch_init): Don't register deleted functions with
9593         gdbarch.
9594
9595 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9596
9597         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9598         (bfin_unwind_pc): Delete.
9599         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9600
9601 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9602
9603         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9604         (arm_unwind_pc): Delete.
9605         (arm_unwind_sp): Delete.
9606         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9607
9608 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9609
9610         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9611         (arc_unwind_pc): Delete.
9612         (arc_unwind_sp): Delete.
9613         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9614
9615 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9616
9617         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9618         (alpha_unwind_pc): Delete.
9619         (alpha_gdbarch_init): Don't register deleted functions with
9620         gdbarch.
9621
9622 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9623
9624         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9625         (aarch64_unwind_pc): Delete.
9626         (aarch64_unwind_sp): Delete.
9627         (aarch64_gdbarch_init): Don't register deleted functions with
9628         gdbarch.
9629
9630 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9631
9632         * gdbtypes.c (type_align): Don't consider static members when
9633         computing structure alignment.
9634
9635 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9636
9637         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9638         return 0 for other types.
9639         * arch-utils.c (default_type_align): Always return 0.
9640         * gdbarch.h: Regenerate.
9641         * gdbarch.sh (type_align): Extend comment.
9642         * gdbtypes.c (type_align): Add additional comments, always call
9643         gdbarch_type_align before applying the default rules.
9644         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9645         generic code will then apply a suitable default.
9646         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9647         types, return 0 for other types.
9648
9649 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9650
9651         * NEWS: Create a new section for the next release branch.
9652         Rename the section of the current branch, now that it has
9653         been cut.
9654
9655 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9656
9657         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9658         * version.in: Bump version to 8.3.50.DATE-git.
9659
9660 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9661
9662         * aix-thread.c (ptid_cmp): Remove unused variable.
9663         (get_signaled_thread): Likewise.
9664         (store_regs_user_thread): Likewise.
9665         (store_regs_kernel_thread): Likewise.
9666         (fetch_regs_kernel_thread): Remove shadowed variable.
9667
9668 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9669
9670         * features/riscv/32bit-cpu.xml: Add register numbers.
9671         * features/riscv/32bit-fpu.c: Regenerate.
9672         * features/riscv/32bit-fpu.xml: Add register numbers.
9673         * features/riscv/64bit-cpu.xml: Add register numbers.
9674         * features/riscv/64bit-fpu.c: Regenerate.
9675         * features/riscv/64bit-fpu.xml: Add register numbers.
9676
9677 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9678
9679         * NEWS: Mention two argument form of gdb.Value constructor.
9680         * python/py-value.c (convert_buffer_and_type_to_value): New
9681         function.
9682         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9683         Add support for handling an optional second argument.  Call
9684         convert_buffer_and_type_to_value as appropriate.
9685         * python/python-internal.h (Py_buffer_deleter): New struct.
9686         (Py_buffer_up): New typedef.
9687
9688 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9689
9690         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9691         instead of releasing ownership.
9692
9693 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9694
9695         * dwarf2read.c (open_and_init_dwp_file): Call
9696         elf_numsections instead of bfd_count_sections to initialize
9697         dwp_file->num_sections.
9698
9699 2019-02-25  Tom Tromey  <tromey@adacore.com>
9700
9701         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9702
9703 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9704
9705         * gcore.in: Add '--readnever' option when invoking GDB.
9706
9707 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9708
9709         * MAINTAINERS: Update my email address.
9710
9711 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9712
9713         * build-id.c (build_id_to_debug_bfd_1): New function.
9714         (build_id_to_debug_bfd): Look for separate debug file in
9715         sysroot.
9716
9717 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9718
9719         * gdbarch.sh: Update the copyright year range that is placed into
9720         generated files.
9721
9722 2019-02-22  Keith Seitz  <keiths@redhat.com>
9723
9724         PR symtab/23853
9725         * linespec.c (create_sals_line_offset): Search for the default
9726         symtab's filename instead of its fullname.
9727
9728 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9729
9730         * NEWS: Update style defaults.
9731
9732 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9733
9734         * main.c (captured_main_1): Disable styling in batch mode.
9735
9736 2019-02-20  Tom Tromey  <tom@tromey.com>
9737
9738         * symtab.c (symtab_symbol_info): Fix typos.
9739
9740 2019-02-20  Tom Tromey  <tromey@adacore.com>
9741
9742         * findcmd.c (_initialize_mem_search): Use upper case for
9743         metasyntactic variables.
9744
9745 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9746
9747         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9748         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9749
9750 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9751
9752         * top.h (source_file_name): Change to std::string.
9753         * top.c (source_file_name): Likewise.
9754         (command_line_input): Adjust.
9755         * cli/cli-script.c (script_from_file): Adjust.
9756
9757 2019-02-19  Tom Tromey  <tromey@adacore.com>
9758
9759         * ravenscar-thread.c
9760         (ravenscar_thread_target::update_thread_list): Don't call
9761         ada_build_task_list.
9762         * ada-lang.h (ada_build_task_list): Don't declare.
9763         * ada-tasks.c (struct ada_tasks_inferior_data)
9764         <task_list_valid_p>: Now bool.
9765         (read_known_tasks, ada_task_list_changed)
9766         (ada_tasks_invalidate_inferior_data): Update.
9767         (read_known_tasks_array): Return bool.
9768         (read_known_tasks_list): Likewise.
9769         (read_known_tasks): Return void.
9770         (ada_build_task_list): Now static.
9771
9772 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9773
9774         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9775         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9776
9777 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9778
9779         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9780         variant for ada_tasks_pspace_data_handle and
9781         ada_tasks_inferior_data_handle.
9782         (ada_tasks_pspace_data_cleanup): New function.
9783         (ada_tasks_inferior_data_cleanup): New function.
9784
9785 2019-02-17  Tom Tromey  <tom@tromey.com>
9786
9787         * macrotab.h (macro_source_fullname): Return a std::string.
9788         * macrotab.c (macro_include, check_for_redefinition)
9789         (macro_undef, macro_lookup_definition, foreach_macro)
9790         (foreach_macro_in_scope): Update.
9791         (macro_source_fullname): Return a std::string.
9792         * macrocmd.c (show_pp_source_pos): Update.
9793
9794 2019-02-17  Tom Tromey  <tom@tromey.com>
9795
9796         * macrocmd.c (show_pp_source_pos): Style the file names.
9797
9798 2019-02-17  Tom Tromey  <tom@tromey.com>
9799
9800         PR tui/24197:
9801         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9802
9803 2019-02-17  Tom Tromey  <tom@tromey.com>
9804
9805         * ada-lang.c (user_select_syms): Use filtered printing.
9806         * utils.c (wrap_style): New global.
9807         (desired_style): Remove.
9808         (emit_style_escape): Add stream parameter.
9809         (set_output_style, reset_terminal_style, prompt_for_continue):
9810         Update.
9811         (flush_wrap_buffer): Only flush gdb_stdout.
9812         (wrap_here): Set wrap_style.
9813         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9814         treat escape sequences as a character.  Change when wrap buffer is
9815         flushed.
9816         (fputs_styled): Do not set the output style when the default is
9817         requested.
9818         * ui-style.h (struct ui_file_style) <is_default>: New method.
9819         * source.c (print_source_lines_base): Emit escape sequences in one
9820         piece.
9821
9822 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9823
9824         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9825         integers and enumeration types.
9826
9827 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9828
9829         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9830         instead of lookup_symbol_in_language
9831         (do_exact_match): New function.
9832         (ada_get_symbol_name_matcher): Return do_exact_match when
9833         doing a verbatim match.
9834
9835 2019-02-15  Tom Tromey  <tromey@adacore.com>
9836
9837         * ravenscar-thread.c (ravenscar_thread_target::resume)
9838         (ravenscar_thread_target::wait): Special case wildcard requests.
9839
9840 2019-02-15  Tom Tromey  <tromey@adacore.com>
9841
9842         * ravenscar-thread.c (base_ptid): Remove.
9843         (struct ravenscar_thread_target) <close>: New method.
9844         <m_base_ptid>: New member.
9845         <update_inferior_ptid, active_task, task_is_currently_active,
9846         runtime_initialized>: Declare methods.
9847         <ravenscar_thread_target>: Add constructor.
9848         (ravenscar_thread_target::task_is_currently_active)
9849         (ravenscar_thread_target::update_inferior_ptid)
9850         (ravenscar_runtime_initialized): Rename.  Now methods.
9851         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9852         (ravenscar_thread_target::update_thread_list): Update.
9853         (ravenscar_thread_target::active_task): Now method.
9854         (ravenscar_thread_target::store_registers)
9855         (ravenscar_thread_target::prepare_to_store)
9856         (ravenscar_thread_target::prepare_to_store)
9857         (ravenscar_thread_target::mourn_inferior): Update.
9858         (ravenscar_inferior_created): Use "new" to create target.
9859         (ravenscar_thread_target::get_ada_task_ptid): Update.
9860         (_initialize_ravenscar): Don't initialize base_ptid.
9861         (ravenscar_ops): Remove global.
9862
9863 2019-02-15  Tom Tromey  <tromey@adacore.com>
9864
9865         * target.h (push_target): Declare new overload.
9866         * target.c (push_target): New overload, taking an rvalue reference.
9867         * remote.c (remote_target::open_1): Use push_target overload.
9868         * corelow.c (core_target_open): Use push_target overload.
9869
9870 2019-02-15  Tom Tromey  <tromey@adacore.com>
9871
9872         * ravenscar-thread.c (is_ravenscar_task)
9873         (ravenscar_task_is_currently_active): Return bool.
9874         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9875         (_initialize_ravenscar): Remove "(void)".
9876         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9877         Return bool.
9878
9879 2019-02-15  Tom Tromey  <tromey@adacore.com>
9880
9881         * ravenscar-thread.c (ravenscar_runtime_initializer)
9882         (has_ravenscar_runtime, get_running_thread_id)
9883         (ravenscar_thread_target::resume): Fix indentation.
9884
9885 2019-02-15  Tom Tromey  <tromey@adacore.com>
9886
9887         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9888         from ravenscar_arch_ops.
9889         (sparc_ravenscar_ops::fetch_registers)
9890         (sparc_ravenscar_ops::store_registers): Now methods.
9891         (sparc_ravenscar_prepare_to_store): Remove.
9892         (sparc_ravenscar_ops): Redefine.
9893         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9894         methods and destructor.  Remove members.
9895         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9896         (ravenscar_thread_target::store_registers)
9897         (ravenscar_thread_target::prepare_to_store): Update.
9898         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9899         Remove.
9900         (struct ppc_ravenscar_powerpc_ops): Derive from
9901         ravenscar_arch_ops.
9902         (ppc_ravenscar_powerpc_ops::fetch_registers)
9903         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9904         (ppc_ravenscar_powerpc_ops): Redefine.
9905         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9906         (ppc_ravenscar_e500_ops::fetch_registers)
9907         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9908         (ppc_ravenscar_e500_ops): Redefine.
9909         * aarch64-ravenscar-thread.c
9910         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9911         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9912         (aarch64_ravenscar_fetch_registers)
9913         (aarch64_ravenscar_store_registers): Now methods.
9914         (aarch64_ravenscar_ops): Redefine.
9915
9916 2019-02-15  Tom Tromey  <tromey@adacore.com>
9917
9918         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9919         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9920         (ravenscar_thread_target::stopped_by_watchpoint)
9921         (ravenscar_thread_target::stopped_data_address)
9922         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9923
9924 2019-02-15  Tom Tromey  <tromey@adacore.com>
9925
9926         * ravenscar-thread.c: Fix some typos.
9927
9928 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9929             Tom Tromey  <tromey@adacore.com>
9930
9931         * ada-lang.c (ada_exception_sal): Change addr_string to a
9932         std::string.
9933         (create_ada_exception_catchpoint): Update.
9934
9935 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9936             Tom Tromey  <tromey@adacore.com>
9937
9938         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9939         (bp_location_ops): Remove.
9940         (base_breakpoint_allocate_location): Update.
9941         (free_bp_location): Update.
9942         * ada-lang.c (class ada_catchpoint_location)
9943         <ada_catchpoint_location>: Remove ops parameter.
9944         (ada_catchpoint_location_dtor): Remove.
9945         (ada_catchpoint_location_ops): Remove.
9946         (allocate_location_exception): Update.
9947         * breakpoint.h (struct bp_location_ops): Remove.
9948         (class bp_location) <bp_location>: Remove bp_location_ops
9949         parameter.
9950         <~bp_location>: Add destructor.
9951         <ops>: Remove.
9952
9953 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9954             Pedro Alves  <palves@redhat.com>
9955
9956         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9957         'PATH_MAX'.
9958
9959 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9960             Samuel Thibault  <samuel.thibault@gnu.org>
9961             Thomas Schwinge  <thomas@codesourcery.com>
9962
9963         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9964         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9965
9966 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9967
9968         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9969         (check_empty): Use "const char *".
9970
9971         * gnu-nat.c (gnu_nat_target::detach): Instead of
9972         'detach_inferior (pid)' call
9973         'detach_inferior (find_inferior_pid (pid))'.
9974
9975         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9976         'nat/fork-inferior.o'.
9977         * gnu-nat.c: #include "nat/fork-inferior.h".
9978
9979         * gnu-nat.c (gnu_nat_target::detach): Instead of
9980         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9981         * gnu-nat.h: #include "inf-child.h".
9982         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9983         'i386_gnu_nat_target::fetch_registers'.
9984         (gnu_store_registers): Rename/move to
9985         'i386_gnu_nat_target::store_registers'.
9986
9987         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9988         * gnu-nat.h (mach_thread_info): New function.
9989         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9990
9991         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9992
9993 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9994
9995         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9996
9997 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9998
9999         * windows-nat.c (windows_add_thread): Add new parameter
10000         "main_thread_p" with default value set to false.  Update
10001         function documentation as well as all callers.
10002         (windows_delete_thread): Likewise.
10003         (fake_create_process): Update call to windows_add_thread.
10004         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
10005         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
10006         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
10007         call to windows_delete_thread.
10008
10009 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
10010
10011         * MAINTAINERS: Add Andrew Burgess as global maintainer.
10012
10013 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10014
10015         * symfile.c (find_separate_debug_file): Use canonical path of
10016         sysroot with child_path instead of gdb_sysroot if it is valid.
10017
10018 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10019
10020         * symfile.c (find_separate_debug_file): Use child_path to
10021         determine if an object file is under a sysroot.
10022
10023 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10024
10025         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10026         unittests/child-path-selftests.c.
10027         * common/pathstuff.c (child_path): New function.
10028         * common/pathstuff.h (child_path): New prototype.
10029         * unittests/child-path-selftests.c: New file.
10030
10031 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10032
10033         * symfile.c (find_separate_debug_file): Look for separate debug
10034         files in debug directories under the sysroot.
10035
10036 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10037
10038         * symtab.h (struct minimal_symbol data_p): New const method.
10039         (struct minimal_symbol text_p): Likewise.
10040         * symtab.c (output_source_filename): Use file name style
10041         to print file name.
10042         (print_symbol_info): Likewise.
10043         (print_msymbol_info): Use address style to print addresses.
10044         Use function name style to print executable text symbols.
10045         (expand_symtab_containing_pc): Use data_p.
10046         (find_pc_sect_compunit_symtab): Likewise.
10047
10048 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10049
10050         * breakpoint.c (describe_other_breakpoints): Use address style
10051         to print addresses.
10052         (say_where): Likewise.
10053
10054 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10055
10056         * ada-typeprint.c (print_func_type): Print function name
10057         style to print function name.
10058         * c-typeprint.c (c_print_type_1): Likewise.
10059
10060 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
10061
10062         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10063         for execve.
10064
10065 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10066
10067         * c-exp.y (direct_abs_decl): Use emplace_back to record the
10068         type_stack.
10069
10070 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
10071
10072         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10073         TYPE_CODE_REF types.
10074
10075 2019-02-08  Jim Wilson  <jimw@sifive.com>
10076
10077         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10078         (riscv_linux_fregset): New.
10079         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10080
10081 2019-02-07  Tom Tromey  <tom@tromey.com>
10082
10083         * thread.c (thread_cancel_execution_command): Update.
10084         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10085         methods.
10086         (struct thread_fsm_ops): Remove.
10087         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10088         (thread_fsm_should_stop, thread_fsm_return_value)
10089         (thread_fsm_set_finished, thread_fsm_finished_p)
10090         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10091         Don't declare.
10092         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10093         * infrun.c (clear_proceed_status_thread)
10094         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10095         (print_stop_event): Update.
10096         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10097         Add constructor.
10098         (step_command_fsm_ops): Remove.
10099         (new_step_command_fsm): Remove.
10100         (step_1): Update.
10101         (step_command_fsm::should_stop): Rename from
10102         step_command_fsm_should_stop.
10103         (step_command_fsm::clean_up): Rename from
10104         step_command_fsm_clean_up.
10105         (step_command_fsm::do_async_reply_reason): Rename from
10106         step_command_fsm_async_reply_reason.
10107         (struct until_next_fsm): Inherit from thread_fsm.  Add
10108         constructor.
10109         (until_next_fsm_ops): Remove.
10110         (new_until_next_fsm): Remove.
10111         (until_next_fsm::should_stop): Rename from
10112         until_next_fsm_should_stop.
10113         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10114         (until_next_fsm::do_async_reply_reason): Rename from
10115         until_next_fsm_async_reply_reason.
10116         (struct finish_command_fsm): Inherit from thread_fsm.  Add
10117         constructor.  Change type of breakpoint.
10118         (finish_command_fsm_ops): Remove.
10119         (new_finish_command_fsm): Remove.
10120         (finish_command_fsm::should_stop): Rename from
10121         finish_command_fsm_should_stop.
10122         (finish_command_fsm::clean_up): Rename from
10123         finish_command_fsm_clean_up.
10124         (finish_command_fsm::return_value): Rename from
10125         finish_command_fsm_return_value.
10126         (finish_command_fsm::do_async_reply_reason): Rename from
10127         finish_command_fsm_async_reply_reason.
10128         (finish_command): Update.
10129         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10130         Add constructor.
10131         (call_thread_fsm_ops): Remove.
10132         (call_thread_fsm::call_thread_fsm): Rename from
10133         new_call_thread_fsm.
10134         (call_thread_fsm::should_stop): Rename from
10135         call_thread_fsm_should_stop.
10136         (call_thread_fsm::should_notify_stop): Rename from
10137         call_thread_fsm_should_notify_stop.
10138         (run_inferior_call, call_function_by_hand_dummy): Update.
10139         * cli/cli-interp.c (should_print_stop_to_console): Update.
10140         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10141         Add constructor.  Change type of location_breakpoint,
10142         caller_breakpoint.
10143         (until_break_fsm_ops): Remove.
10144         (new_until_break_fsm): Remove.
10145         (until_break_fsm::should_stop): Rename from
10146         until_break_fsm_should_stop.
10147         (until_break_fsm::clean_up): Rename from
10148         until_break_fsm_clean_up.
10149         (until_break_fsm::do_async_reply_reason): Rename from
10150         until_break_fsm_async_reply_reason.
10151         (until_break_command): Update.
10152         * thread-fsm.c: Remove.
10153         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10154
10155 2019-02-07  Tom Tromey  <tom@tromey.com>
10156
10157         * yy-remap.h: Add include guard.
10158         * xtensa-tdep.h: Add include guard.
10159         * xcoffread.h: Rename include guard.
10160         * varobj-iter.h: Add include guard.
10161         * tui/tui.h: Rename include guard.
10162         * tui/tui-winsource.h: Rename include guard.
10163         * tui/tui-wingeneral.h: Rename include guard.
10164         * tui/tui-windata.h: Rename include guard.
10165         * tui/tui-win.h: Rename include guard.
10166         * tui/tui-stack.h: Rename include guard.
10167         * tui/tui-source.h: Rename include guard.
10168         * tui/tui-regs.h: Rename include guard.
10169         * tui/tui-out.h: Rename include guard.
10170         * tui/tui-layout.h: Rename include guard.
10171         * tui/tui-io.h: Rename include guard.
10172         * tui/tui-hooks.h: Rename include guard.
10173         * tui/tui-file.h: Rename include guard.
10174         * tui/tui-disasm.h: Rename include guard.
10175         * tui/tui-data.h: Rename include guard.
10176         * tui/tui-command.h: Rename include guard.
10177         * tic6x-tdep.h: Add include guard.
10178         * target/waitstatus.h: Rename include guard.
10179         * target/wait.h: Rename include guard.
10180         * target/target.h: Rename include guard.
10181         * target/resume.h: Rename include guard.
10182         * target-float.h: Rename include guard.
10183         * stabsread.h: Add include guard.
10184         * rs6000-tdep.h: Add include guard.
10185         * riscv-fbsd-tdep.h: Add include guard.
10186         * regformats/regdef.h: Rename include guard.
10187         * record.h: Rename include guard.
10188         * python/python.h: Rename include guard.
10189         * python/python-internal.h: Rename include guard.
10190         * python/py-stopevent.h: Rename include guard.
10191         * python/py-ref.h: Rename include guard.
10192         * python/py-record.h: Rename include guard.
10193         * python/py-record-full.h: Rename include guard.
10194         * python/py-record-btrace.h: Rename include guard.
10195         * python/py-instruction.h: Rename include guard.
10196         * python/py-events.h: Rename include guard.
10197         * python/py-event.h: Rename include guard.
10198         * procfs.h: Add include guard.
10199         * proc-utils.h: Add include guard.
10200         * p-lang.h: Add include guard.
10201         * or1k-tdep.h: Rename include guard.
10202         * observable.h: Rename include guard.
10203         * nto-tdep.h: Rename include guard.
10204         * nat/x86-linux.h: Rename include guard.
10205         * nat/x86-linux-dregs.h: Rename include guard.
10206         * nat/x86-gcc-cpuid.h: Add include guard.
10207         * nat/x86-dregs.h: Rename include guard.
10208         * nat/x86-cpuid.h: Rename include guard.
10209         * nat/ppc-linux.h: Rename include guard.
10210         * nat/mips-linux-watch.h: Rename include guard.
10211         * nat/linux-waitpid.h: Rename include guard.
10212         * nat/linux-ptrace.h: Rename include guard.
10213         * nat/linux-procfs.h: Rename include guard.
10214         * nat/linux-osdata.h: Rename include guard.
10215         * nat/linux-nat.h: Rename include guard.
10216         * nat/linux-namespaces.h: Rename include guard.
10217         * nat/linux-btrace.h: Rename include guard.
10218         * nat/glibc_thread_db.h: Rename include guard.
10219         * nat/gdb_thread_db.h: Rename include guard.
10220         * nat/gdb_ptrace.h: Rename include guard.
10221         * nat/fork-inferior.h: Rename include guard.
10222         * nat/amd64-linux-siginfo.h: Rename include guard.
10223         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10224         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10225         * nat/aarch64-linux.h: Rename include guard.
10226         * nat/aarch64-linux-hw-point.h: Rename include guard.
10227         * mn10300-tdep.h: Add include guard.
10228         * mips-linux-tdep.h: Add include guard.
10229         * mi/mi-parse.h: Rename include guard.
10230         * mi/mi-out.h: Rename include guard.
10231         * mi/mi-main.h: Rename include guard.
10232         * mi/mi-interp.h: Rename include guard.
10233         * mi/mi-getopt.h: Rename include guard.
10234         * mi/mi-console.h: Rename include guard.
10235         * mi/mi-common.h: Rename include guard.
10236         * mi/mi-cmds.h: Rename include guard.
10237         * mi/mi-cmd-break.h: Rename include guard.
10238         * m2-lang.h: Add include guard.
10239         * location.h: Rename include guard.
10240         * linux-record.h: Rename include guard.
10241         * linux-nat.h: Add include guard.
10242         * linux-fork.h: Add include guard.
10243         * i386-darwin-tdep.h: Rename include guard.
10244         * hppa-linux-offsets.h: Add include guard.
10245         * guile/guile.h: Rename include guard.
10246         * guile/guile-internal.h: Rename include guard.
10247         * gnu-nat.h: Rename include guard.
10248         * gdb-stabs.h: Rename include guard.
10249         * frv-tdep.h: Add include guard.
10250         * f-lang.h: Add include guard.
10251         * event-loop.h: Add include guard.
10252         * darwin-nat.h: Rename include guard.
10253         * cp-abi.h: Rename include guard.
10254         * config/sparc/nm-sol2.h: Rename include guard.
10255         * config/nm-nto.h: Rename include guard.
10256         * config/nm-linux.h: Add include guard.
10257         * config/i386/nm-i386gnu.h: Rename include guard.
10258         * config/djgpp/nl_types.h: Rename include guard.
10259         * config/djgpp/langinfo.h: Rename include guard.
10260         * compile/gcc-cp-plugin.h: Add include guard.
10261         * compile/gcc-c-plugin.h: Add include guard.
10262         * compile/compile.h: Rename include guard.
10263         * compile/compile-object-run.h: Rename include guard.
10264         * compile/compile-object-load.h: Rename include guard.
10265         * compile/compile-internal.h: Rename include guard.
10266         * compile/compile-cplus.h: Rename include guard.
10267         * compile/compile-c.h: Rename include guard.
10268         * common/xml-utils.h: Rename include guard.
10269         * common/x86-xstate.h: Rename include guard.
10270         * common/version.h: Rename include guard.
10271         * common/vec.h: Rename include guard.
10272         * common/tdesc.h: Rename include guard.
10273         * common/selftest.h: Rename include guard.
10274         * common/scoped_restore.h: Rename include guard.
10275         * common/scoped_mmap.h: Rename include guard.
10276         * common/scoped_fd.h: Rename include guard.
10277         * common/safe-iterator.h: Rename include guard.
10278         * common/run-time-clock.h: Rename include guard.
10279         * common/refcounted-object.h: Rename include guard.
10280         * common/queue.h: Rename include guard.
10281         * common/ptid.h: Rename include guard.
10282         * common/print-utils.h: Rename include guard.
10283         * common/preprocessor.h: Rename include guard.
10284         * common/pathstuff.h: Rename include guard.
10285         * common/observable.h: Rename include guard.
10286         * common/netstuff.h: Rename include guard.
10287         * common/job-control.h: Rename include guard.
10288         * common/host-defs.h: Rename include guard.
10289         * common/gdb_wait.h: Rename include guard.
10290         * common/gdb_vecs.h: Rename include guard.
10291         * common/gdb_unlinker.h: Rename include guard.
10292         * common/gdb_unique_ptr.h: Rename include guard.
10293         * common/gdb_tilde_expand.h: Rename include guard.
10294         * common/gdb_sys_time.h: Rename include guard.
10295         * common/gdb_string_view.h: Rename include guard.
10296         * common/gdb_splay_tree.h: Rename include guard.
10297         * common/gdb_setjmp.h: Rename include guard.
10298         * common/gdb_ref_ptr.h: Rename include guard.
10299         * common/gdb_optional.h: Rename include guard.
10300         * common/gdb_locale.h: Rename include guard.
10301         * common/gdb_assert.h: Rename include guard.
10302         * common/filtered-iterator.h: Rename include guard.
10303         * common/filestuff.h: Rename include guard.
10304         * common/fileio.h: Rename include guard.
10305         * common/environ.h: Rename include guard.
10306         * common/common-utils.h: Rename include guard.
10307         * common/common-types.h: Rename include guard.
10308         * common/common-regcache.h: Rename include guard.
10309         * common/common-inferior.h: Rename include guard.
10310         * common/common-gdbthread.h: Rename include guard.
10311         * common/common-exceptions.h: Rename include guard.
10312         * common/common-defs.h: Rename include guard.
10313         * common/common-debug.h: Rename include guard.
10314         * common/cleanups.h: Rename include guard.
10315         * common/buffer.h: Rename include guard.
10316         * common/btrace-common.h: Rename include guard.
10317         * common/break-common.h: Rename include guard.
10318         * cli/cli-utils.h: Rename include guard.
10319         * cli/cli-style.h: Rename include guard.
10320         * cli/cli-setshow.h: Rename include guard.
10321         * cli/cli-script.h: Rename include guard.
10322         * cli/cli-interp.h: Rename include guard.
10323         * cli/cli-decode.h: Rename include guard.
10324         * cli/cli-cmds.h: Rename include guard.
10325         * charset-list.h: Add include guard.
10326         * buildsym-legacy.h: Rename include guard.
10327         * bfin-tdep.h: Add include guard.
10328         * ax.h: Rename include guard.
10329         * arm-linux-tdep.h: Add include guard.
10330         * arm-fbsd-tdep.h: Add include guard.
10331         * arch/xtensa.h: Rename include guard.
10332         * arch/tic6x.h: Add include guard.
10333         * arch/i386.h: Add include guard.
10334         * arch/arm.h: Rename include guard.
10335         * arch/arm-linux.h: Rename include guard.
10336         * arch/arm-get-next-pcs.h: Rename include guard.
10337         * arch/amd64.h: Add include guard.
10338         * arch/aarch64-insn.h: Rename include guard.
10339         * arch-utils.h: Rename include guard.
10340         * annotate.h: Add include guard.
10341         * amd64-darwin-tdep.h: Rename include guard.
10342         * aarch64-linux-tdep.h: Add include guard.
10343         * aarch64-fbsd-tdep.h: Add include guard.
10344         * aarch32-linux-nat.h: Add include guard.
10345
10346 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10347
10348         * macrotab.c (macro_define_internal): New function that
10349         factorizes macro_define_object_internal and macro_define_function
10350         code.
10351         (macro_define_object_internal): Use macro_define_internal.
10352         (macro_define_function): Likewise.
10353
10354 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10355
10356         * macrocmd.c (extract_identifier): Return
10357         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10358         callers.
10359
10360 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10361
10362         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10363
10364 2019-02-05  Tom Tromey  <tom@tromey.com>
10365
10366         * target.c (target_stack::unpush): Move assertion earlier.
10367
10368 2019-01-30  Tom Tromey  <tom@tromey.com>
10369
10370         PR python/23615:
10371         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10372         (gdbpy_parse_and_eval): Likewise.
10373         * python/python-internal.h (gdbpy_allow_threads): New class.
10374
10375 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10376
10377         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10378         (aarch64_fbsd_fpregmap): Move earlier.
10379         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10380         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10381         instead of individual calls to trad_frame_set_reg_addr.
10382         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10383         earlier.
10384         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10385         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10386         instead of individual calls to trad_frame_set_reg_addr.
10387
10388 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10389
10390         * CONTRIBUTE: Replace contribution list with wiki link.
10391
10392 2019-01-25  Tom Tromey  <tom@tromey.com>
10393
10394         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10395
10396 2019-01-25  Tom Tromey  <tom@tromey.com>
10397
10398         * xtensa-linux-nat.c: Fix common/ includes.
10399         * xml-support.h: Fix common/ includes.
10400         * xml-support.c: Fix common/ includes.
10401         * x86-linux-nat.c: Fix common/ includes.
10402         * windows-nat.c: Fix common/ includes.
10403         * varobj.h: Fix common/ includes.
10404         * varobj.c: Fix common/ includes.
10405         * value.c: Fix common/ includes.
10406         * valops.c: Fix common/ includes.
10407         * utils.c: Fix common/ includes.
10408         * unittests/xml-utils-selftests.c: Fix common/ includes.
10409         * unittests/utils-selftests.c: Fix common/ includes.
10410         * unittests/unpack-selftests.c: Fix common/ includes.
10411         * unittests/tracepoint-selftests.c: Fix common/ includes.
10412         * unittests/style-selftests.c: Fix common/ includes.
10413         * unittests/string_view-selftests.c: Fix common/ includes.
10414         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10415         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10416         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10417         * unittests/rsp-low-selftests.c: Fix common/ includes.
10418         * unittests/parse-connection-spec-selftests.c: Fix common/
10419         includes.
10420         * unittests/optional-selftests.c: Fix common/ includes.
10421         * unittests/offset-type-selftests.c: Fix common/ includes.
10422         * unittests/observable-selftests.c: Fix common/ includes.
10423         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10424         * unittests/memrange-selftests.c: Fix common/ includes.
10425         * unittests/memory-map-selftests.c: Fix common/ includes.
10426         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10427         * unittests/function-view-selftests.c: Fix common/ includes.
10428         * unittests/environ-selftests.c: Fix common/ includes.
10429         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10430         * unittests/common-utils-selftests.c: Fix common/ includes.
10431         * unittests/cli-utils-selftests.c: Fix common/ includes.
10432         * unittests/array-view-selftests.c: Fix common/ includes.
10433         * ui-file.c: Fix common/ includes.
10434         * tui/tui-io.c: Fix common/ includes.
10435         * tracepoint.h: Fix common/ includes.
10436         * tracepoint.c: Fix common/ includes.
10437         * tracefile-tfile.c: Fix common/ includes.
10438         * top.h: Fix common/ includes.
10439         * top.c: Fix common/ includes.
10440         * thread.c: Fix common/ includes.
10441         * target/waitstatus.h: Fix common/ includes.
10442         * target/waitstatus.c: Fix common/ includes.
10443         * target.h: Fix common/ includes.
10444         * target.c: Fix common/ includes.
10445         * target-memory.c: Fix common/ includes.
10446         * target-descriptions.c: Fix common/ includes.
10447         * symtab.h: Fix common/ includes.
10448         * symfile.c: Fix common/ includes.
10449         * stap-probe.c: Fix common/ includes.
10450         * spu-linux-nat.c: Fix common/ includes.
10451         * sparc-nat.c: Fix common/ includes.
10452         * source.c: Fix common/ includes.
10453         * solib.c: Fix common/ includes.
10454         * solib-target.c: Fix common/ includes.
10455         * ser-unix.c: Fix common/ includes.
10456         * ser-tcp.c: Fix common/ includes.
10457         * ser-pipe.c: Fix common/ includes.
10458         * ser-base.c: Fix common/ includes.
10459         * selftest-arch.c: Fix common/ includes.
10460         * s12z-tdep.c: Fix common/ includes.
10461         * rust-exp.y: Fix common/ includes.
10462         * rs6000-aix-tdep.c: Fix common/ includes.
10463         * riscv-tdep.c: Fix common/ includes.
10464         * remote.c: Fix common/ includes.
10465         * remote-notif.h: Fix common/ includes.
10466         * remote-fileio.h: Fix common/ includes.
10467         * remote-fileio.c: Fix common/ includes.
10468         * regcache.h: Fix common/ includes.
10469         * regcache.c: Fix common/ includes.
10470         * record-btrace.c: Fix common/ includes.
10471         * python/python.c: Fix common/ includes.
10472         * python/py-type.c: Fix common/ includes.
10473         * python/py-inferior.c: Fix common/ includes.
10474         * progspace.h: Fix common/ includes.
10475         * producer.c: Fix common/ includes.
10476         * procfs.c: Fix common/ includes.
10477         * proc-api.c: Fix common/ includes.
10478         * printcmd.c: Fix common/ includes.
10479         * ppc-linux-nat.c: Fix common/ includes.
10480         * parser-defs.h: Fix common/ includes.
10481         * osdata.c: Fix common/ includes.
10482         * obsd-nat.c: Fix common/ includes.
10483         * nat/x86-linux.c: Fix common/ includes.
10484         * nat/x86-linux-dregs.c: Fix common/ includes.
10485         * nat/x86-dregs.h: Fix common/ includes.
10486         * nat/x86-dregs.c: Fix common/ includes.
10487         * nat/ppc-linux.c: Fix common/ includes.
10488         * nat/mips-linux-watch.h: Fix common/ includes.
10489         * nat/mips-linux-watch.c: Fix common/ includes.
10490         * nat/linux-waitpid.c: Fix common/ includes.
10491         * nat/linux-ptrace.h: Fix common/ includes.
10492         * nat/linux-ptrace.c: Fix common/ includes.
10493         * nat/linux-procfs.c: Fix common/ includes.
10494         * nat/linux-personality.c: Fix common/ includes.
10495         * nat/linux-osdata.c: Fix common/ includes.
10496         * nat/linux-namespaces.c: Fix common/ includes.
10497         * nat/linux-btrace.h: Fix common/ includes.
10498         * nat/linux-btrace.c: Fix common/ includes.
10499         * nat/fork-inferior.c: Fix common/ includes.
10500         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10501         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10502         * nat/aarch64-linux.c: Fix common/ includes.
10503         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10504         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10505         * namespace.h: Fix common/ includes.
10506         * mips-linux-tdep.c: Fix common/ includes.
10507         * minsyms.c: Fix common/ includes.
10508         * mi/mi-parse.h: Fix common/ includes.
10509         * mi/mi-main.c: Fix common/ includes.
10510         * mi/mi-cmd-env.c: Fix common/ includes.
10511         * memrange.h: Fix common/ includes.
10512         * memattr.c: Fix common/ includes.
10513         * maint.h: Fix common/ includes.
10514         * maint.c: Fix common/ includes.
10515         * main.c: Fix common/ includes.
10516         * machoread.c: Fix common/ includes.
10517         * location.c: Fix common/ includes.
10518         * linux-thread-db.c: Fix common/ includes.
10519         * linux-nat.c: Fix common/ includes.
10520         * linux-fork.c: Fix common/ includes.
10521         * inline-frame.c: Fix common/ includes.
10522         * infrun.c: Fix common/ includes.
10523         * inflow.c: Fix common/ includes.
10524         * inferior.h: Fix common/ includes.
10525         * inferior.c: Fix common/ includes.
10526         * infcmd.c: Fix common/ includes.
10527         * inf-ptrace.c: Fix common/ includes.
10528         * inf-child.c: Fix common/ includes.
10529         * ia64-linux-nat.c: Fix common/ includes.
10530         * i387-tdep.c: Fix common/ includes.
10531         * i386-tdep.c: Fix common/ includes.
10532         * i386-linux-tdep.c: Fix common/ includes.
10533         * i386-linux-nat.c: Fix common/ includes.
10534         * i386-go32-tdep.c: Fix common/ includes.
10535         * i386-fbsd-tdep.c: Fix common/ includes.
10536         * i386-fbsd-nat.c: Fix common/ includes.
10537         * guile/scm-type.c: Fix common/ includes.
10538         * guile/guile.c: Fix common/ includes.
10539         * go32-nat.c: Fix common/ includes.
10540         * gnu-nat.c: Fix common/ includes.
10541         * gdbthread.h: Fix common/ includes.
10542         * gdbarch-selftests.c: Fix common/ includes.
10543         * gdb_usleep.c: Fix common/ includes.
10544         * gdb_select.h: Fix common/ includes.
10545         * gdb_bfd.c: Fix common/ includes.
10546         * gcore.c: Fix common/ includes.
10547         * fork-child.c: Fix common/ includes.
10548         * findvar.c: Fix common/ includes.
10549         * fbsd-nat.c: Fix common/ includes.
10550         * event-top.c: Fix common/ includes.
10551         * event-loop.c: Fix common/ includes.
10552         * dwarf2read.c: Fix common/ includes.
10553         * dwarf2loc.c: Fix common/ includes.
10554         * dwarf2-frame.c: Fix common/ includes.
10555         * dwarf-index-cache.c: Fix common/ includes.
10556         * dtrace-probe.c: Fix common/ includes.
10557         * disasm-selftests.c: Fix common/ includes.
10558         * defs.h: Fix common/ includes.
10559         * csky-tdep.c: Fix common/ includes.
10560         * cp-valprint.c: Fix common/ includes.
10561         * cp-support.h: Fix common/ includes.
10562         * cp-support.c: Fix common/ includes.
10563         * corelow.c: Fix common/ includes.
10564         * completer.h: Fix common/ includes.
10565         * completer.c: Fix common/ includes.
10566         * compile/compile.c: Fix common/ includes.
10567         * compile/compile-loc2c.c: Fix common/ includes.
10568         * compile/compile-cplus-types.c: Fix common/ includes.
10569         * compile/compile-cplus-symbols.c: Fix common/ includes.
10570         * command.h: Fix common/ includes.
10571         * cli/cli-dump.c: Fix common/ includes.
10572         * cli/cli-cmds.c: Fix common/ includes.
10573         * charset.c: Fix common/ includes.
10574         * build-id.c: Fix common/ includes.
10575         * btrace.h: Fix common/ includes.
10576         * btrace.c: Fix common/ includes.
10577         * breakpoint.h: Fix common/ includes.
10578         * breakpoint.c: Fix common/ includes.
10579         * ax.h:
10580         (enum agent_op): Fix common/ includes.
10581         * ax-general.c (struct aop_map): Fix common/ includes.
10582         * ax-gdb.c: Fix common/ includes.
10583         * auxv.c: Fix common/ includes.
10584         * auto-load.c: Fix common/ includes.
10585         * arm-tdep.c: Fix common/ includes.
10586         * arch/riscv.c: Fix common/ includes.
10587         * arch/ppc-linux-common.c: Fix common/ includes.
10588         * arch/i386.c: Fix common/ includes.
10589         * arch/arm.c: Fix common/ includes.
10590         * arch/arm-linux.c: Fix common/ includes.
10591         * arch/arm-get-next-pcs.c: Fix common/ includes.
10592         * arch/amd64.c: Fix common/ includes.
10593         * arch/aarch64.c: Fix common/ includes.
10594         * arch/aarch64-insn.c: Fix common/ includes.
10595         * arch-utils.c: Fix common/ includes.
10596         * amd64-windows-tdep.c: Fix common/ includes.
10597         * amd64-tdep.c: Fix common/ includes.
10598         * amd64-sol2-tdep.c: Fix common/ includes.
10599         * amd64-obsd-tdep.c: Fix common/ includes.
10600         * amd64-nbsd-tdep.c: Fix common/ includes.
10601         * amd64-linux-tdep.c: Fix common/ includes.
10602         * amd64-linux-nat.c: Fix common/ includes.
10603         * amd64-fbsd-tdep.c: Fix common/ includes.
10604         * amd64-fbsd-nat.c: Fix common/ includes.
10605         * amd64-dicos-tdep.c: Fix common/ includes.
10606         * amd64-darwin-tdep.c: Fix common/ includes.
10607         * agent.c: Fix common/ includes.
10608         * ada-lang.h: Fix common/ includes.
10609         * ada-lang.c: Fix common/ includes.
10610         * aarch64-tdep.c: Fix common/ includes.
10611
10612 2019-01-25  Tom Tromey  <tom@tromey.com>
10613
10614         * common/create-version.sh: Use common/version.h.
10615
10616 2019-01-24  Pedro Alves  <palves@redhat.com>
10617
10618         * infrun.c (signal_stop, signal_print, signal_program)
10619         (signal_catch, signal_pass): Now arrays instead of pointers.
10620         (update_signals_program_target, do_target_resume)
10621         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10622         * linux-nat.c (linux_nat_target::pass_signals)
10623         (linux_nat_target::create_inferior, linux_nat_target::attach):
10624         Adjust.
10625         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10626         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10627         * procfs.c (procfs_target::pass_signals): Adjust.
10628         * record-full.c (record_full_target::resume): Adjust.
10629         * remote.c (remote_target::pass_signals)
10630         (remote_target::program_signals): Adjust.
10631         * target-debug.h (target_debug_print_signals): Now takes a
10632         gdb::array_view as parameter.  Adjust.
10633         * target.h (target_ops) <pass_signals, program_signals>: Replace
10634         pointer and length parameters with gdb::array_view.
10635         (target_pass_signals, target_program_signals): Likewise.
10636         * target-delegates.c: Regenerate.
10637
10638 2019-01-24  Pedro Alves  <palves@redhat.com>
10639
10640         * common/forward-scope-exit.h
10641         (forward_scope_exit::forward_scope_exit): Pass arguments to
10642         m_bind_function directly, instead of creating a std::bind and
10643         copying that.
10644
10645 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10646
10647         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10648         for static members.
10649         (pass_in_v_vfp_candidate): Likewise.
10650
10651 2019-01-23  Tom Tromey  <tom@tromey.com>
10652             Pedro Alves  <palves@redhat.com>
10653
10654         * regcache.c (class regcache_invalidator): Remove.
10655         (regcache::raw_write): Use make_scope_exit.
10656
10657 2019-01-23  Tom Tromey  <tom@tromey.com>
10658
10659         * ui-out.h (class ui_out_emit_type): Update comment.
10660
10661 2019-01-23  Tom Tromey  <tom@tromey.com>
10662
10663         * infrun.c (fetch_inferior_event): Update comment.
10664
10665 2019-01-23  Tom Tromey  <tom@tromey.com>
10666             Pedro Alves  <palves@redhat.com>
10667
10668         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10669         parameter.
10670         (fetch_inferior_event): Use SCOPE_EXIT.
10671
10672
10673 2019-01-23  Tom Tromey  <tom@tromey.com>
10674             Pedro Alves  <palves@redhat.com>
10675
10676         * infrun.c (disable_thread_events): Delete.
10677         (stop_all_threads): Use SCOPE_EXIT.
10678
10679 2019-01-23  Tom Tromey  <tom@tromey.com>
10680             Pedro Alves  <palves@redhat.com>
10681
10682         * symfile.c: Include forward-scope-exit.h.
10683         (clear_symtab_users_cleanup): Replace forward declaration with
10684         a FORWARD_SCOPE_EXIT.
10685         (syms_from_objfile_1): Use the forward_scope_exit and
10686         gdb::optional instead of cleanup_function.
10687         (reread_symbols): Use the forward_scope_exit instead of
10688         cleanup_function.
10689         (clear_symtab_users_cleanup): Remove function.
10690
10691 2019-01-23  Tom Tromey  <tom@tromey.com>
10692             Pedro Alves  <palves@redhat.com>
10693
10694         * linux-nat.c: Include scope-exit.h.
10695         (cleanup_target_stop): Remove.
10696         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10697         SCOPE_EXIT.
10698
10699 2019-01-23  Tom Tromey  <tom@tromey.com>
10700             Pedro Alves  <palves@redhat.com>
10701
10702         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10703         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10704
10705 2019-01-23  Tom Tromey  <tom@tromey.com>
10706             Andrew Burgess  <andrew.burgess@embecosm.com>
10707             Pedro Alves  <palves@redhat.com>
10708
10709         * infrun.c (fetch_inferior_event): Use scope_exit.
10710         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10711         * top.c (execute_command): Use scope_exit.
10712         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10713         * utils.c (do_bpstat_clear_actions_cleanup)
10714         (make_bpstat_clear_actions_cleanup): Remove.
10715
10716 2019-01-23  Tom Tromey  <tom@tromey.com>
10717             Pedro Alves  <palves@redhat.com>
10718
10719         * infrun.c: Include "common/scope-exit.h"
10720         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10721         (wait_for_inferior): Use SCOPE_EXIT.
10722         (fetch_inferior_event): Use scope_exit.
10723
10724 2019-01-23  Tom Tromey  <tom@tromey.com>
10725             Pedro Alves  <palves@redhat.com>
10726
10727         * breakpoint.c (create_breakpoint): Remove cleanup.
10728
10729 2019-01-23  Tom Tromey  <tom@tromey.com>
10730             Andrew Burgess  <andrew.burgess@embecosm.com>
10731             Pedro Alves  <palves@redhat.com>
10732
10733 2019-01-23  Pedro Alves  <palves@redhat.com>
10734
10735         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10736
10737 2019-01-23  Pedro Alves  <palves@redhat.com>
10738             Andrew Burgess  <andrew.burgess@embecosm.com>
10739
10740         * gdbthread.h: Include "common/forward-scope-exit.h".
10741         (scoped_finish_thread_state): Redefine custom class in terms of
10742         forward_scope_exit.
10743
10744 2019-01-23  Pedro Alves  <palves@redhat.com>
10745             Andrew Burgess  <andrew.burgess@embecosm.com>
10746
10747         * common/forward-scope-exit.h: New file.
10748
10749 2019-01-23  Pedro Alves  <palves@redhat.com>
10750             Andrew Burgess  <andrew.burgess@embecosm.com>
10751             Tom Tromey  <tom@tromey.com>
10752
10753         * common/scope-exit.h: New file.
10754
10755 2019-01-23  Pedro Alves  <palves@redhat.com>
10756
10757         * common/preprocessor.h (ESC): Rename to ...
10758         (ESC_PARENS): ... this.
10759         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10760         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10761
10762 2019-01-23  Tom Tromey  <tom@tromey.com>
10763
10764         * language.h (class scoped_switch_to_sym_language_if_auto):
10765         Initialize m_lang in both cases.
10766
10767 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10768
10769         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10770         with XCNEW.
10771
10772 2019-01-22  Tom Tromey  <tom@tromey.com>
10773
10774         * corelow.c: Do not include sys/file.h.
10775
10776 2019-01-22  Tom Tromey  <tom@tromey.com>
10777
10778         * tui/tui-wingeneral.h: Include gdb_curses.h.
10779
10780 2019-01-22  Tom Tromey  <tom@tromey.com>
10781
10782         * source-cache.h (class source_cache) <get_source_lines,
10783         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10784
10785 2019-01-22  Tom Tromey  <tom@tromey.com>
10786
10787         * remote-fileio.h (struct remote_target): Declare.
10788
10789 2019-01-22  Tom Tromey  <tom@tromey.com>
10790
10791         * python/py-arch.c: Do not include py-ref.h.
10792         * python/py-bpevent.c: Do not include py-ref.h.
10793         * python/py-cmd.c: Do not include py-ref.h.
10794         * python/py-continueevent.c: Do not include py-ref.h.
10795         * python/py-event.h: Do not include py-ref.h.
10796         * python/py-evtregistry.c: Do not include py-ref.h.
10797         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10798         * python/py-frame.c: Do not include py-ref.h.
10799         * python/py-framefilter.c: Do not include py-ref.h.
10800         * python/py-function.c: Do not include py-ref.h.
10801         * python/py-infevents.c: Do not include py-ref.h.
10802         * python/py-linetable.c: Do not include py-ref.h.
10803         * python/py-objfile.c: Do not include py-ref.h.
10804         * python/py-param.c: Do not include py-ref.h.
10805         * python/py-prettyprint.c: Do not include py-ref.h.
10806         * python/py-progspace.c: Do not include py-ref.h.
10807         * python/py-symbol.c: Do not include py-ref.h.
10808         * python/py-symtab.c: Do not include py-ref.h.
10809         * python/py-type.c: Do not include py-ref.h.
10810         * python/py-unwind.c: Do not include py-ref.h.
10811         * python/py-utils.c: Do not include py-ref.h.
10812         * python/py-value.c: Do not include py-ref.h.
10813         * python/py-varobj.c: Do not include py-ref.h.
10814         * python/py-xmethods.c: Do not include py-ref.h.
10815         * python/python.c: Do not include py-ref.h.
10816         * varobj.c: Do not include py-ref.h.
10817
10818 2019-01-22  Tom Tromey  <tom@tromey.com>
10819
10820         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10821         keyword for bcache.
10822
10823 2019-01-22  Tom Tromey  <tom@tromey.com>
10824
10825         * compile/compile-cplus-types.c: Remove a comment by #include.
10826
10827 2019-01-22  Tom Tromey  <tom@tromey.com>
10828
10829         * compile/gcc-c-plugin.h: Include compile-internal.h.
10830
10831 2019-01-22  Tom Tromey  <tom@tromey.com>
10832
10833         * stabsread.c (EXTERN): Do not define.
10834         (symnum, next_symbol_text_func, processing_gcc_compilation)
10835         (within_function, global_sym_chain, global_stabs)
10836         (previous_stab_code, this_object_header_files)
10837         (n_this_object_header_files)
10838         (n_allocated_this_object_header_files): Define.
10839         * stabsread.h (EXTERN): Never define.  Use "extern".
10840
10841 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10842
10843         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10844         history_value.
10845
10846 2019-01-21  Tom Tromey  <tom@tromey.com>
10847
10848         * ui-out.c: Fix includes.
10849         * tui/tui-source.c: Fix includes.
10850         * target.c: Fix includes.
10851         * remote.c: Fix includes.
10852         * regcache.c: Fix includes.
10853         * python/py-block.c: Fix includes.
10854         * printcmd.c: Fix includes.
10855         * or1k-tdep.c: Fix includes.
10856         * mi/mi-main.c: Fix includes.
10857         * m32r-tdep.c: Fix includes.
10858         * csky-tdep.c: Fix includes.
10859         * compile/compile-cplus-types.c: Fix includes.
10860         * cli/cli-interp.c: Fix includes.
10861
10862 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10863
10864         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10865         for padding.
10866
10867 2019-01-16  Tom Tromey  <tom@tromey.com>
10868
10869         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10870         earlier.
10871         (struct objfile) <msymbols_range>: Move from top level.
10872         <msymbols>: New method.
10873         (class objfile_msymbols): Remove.
10874         * symtab.c (default_collect_symbol_completion_matches_break_on):
10875         Update.
10876         * symmisc.c (dump_msymbols): Update.
10877         * stabsread.c (scan_file_globals): Update.
10878         * objc-lang.c (info_selectors_command, info_classes_command)
10879         (find_methods): Update.
10880         * minsyms.c (find_solib_trampoline_target): Update.
10881         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10882         * coffread.c (coff_symfile_read): Update.
10883         * ada-lang.c (ada_lookup_simple_minsym)
10884         (ada_collect_symbol_completion_matches): Update.
10885
10886 2019-01-16  Tom Tromey  <tom@tromey.com>
10887
10888         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10889         type.  Remove no-argument constructor.
10890         <iterator::operator++>: Simplify.
10891         <begin>: Update.
10892         <end>: Use minimal_symbol_count.
10893
10894 2019-01-16  Tom Tromey  <tom@tromey.com>
10895
10896         * objfiles.h (struct objfile) <psymtabs>: New method.
10897         (class objfile_psymtabs): Remove.
10898         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10899         typedef.
10900         <range>: New method.
10901         (require_partial_symbols): Change return type.
10902         * psymtab.c (require_partial_symbols)
10903         (psym_expand_symtabs_matching): Update.
10904         * mdebugread.c (parse_partial_symbols): Update.
10905         * dbxread.c (dbx_end_psymtab): Update.
10906
10907 2019-01-15  Tom Tromey  <tom@tromey.com>
10908
10909         * symtab.c (lookup_objfile_from_block)
10910         (lookup_symbol_in_objfile_symtabs)
10911         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10912         (find_line_symtab, info_sources_command)
10913         (default_collect_symbol_completion_matches_break_on)
10914         (make_source_files_completion_list): Update.
10915         * symmisc.c (print_objfile_statistics, dump_objfile)
10916         (maintenance_print_symbols, maintenance_info_symtabs)
10917         (maintenance_check_symtabs, maintenance_info_line_tables):
10918         Update.
10919         * source.c (select_source_symtab)
10920         (forget_cached_source_info_for_objfile): Update.
10921         * objfiles.h (class objfile_compunits): Remove.
10922         (struct objfile) <compunits_range>: New typedef.
10923         (compunits): New method.
10924         * objfiles.c (objfile_relocate1): Update.
10925         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10926         * maint.c (count_symtabs_and_blocks): Update.
10927         * linespec.c (iterate_over_all_matching_symtabs): Update.
10928         * cp-support.c (add_symbol_overload_list_qualified): Update.
10929         * coffread.c (coff_symtab_read): Update.
10930         * ada-lang.c (add_nonlocal_symbols)
10931         (ada_collect_symbol_completion_matches)
10932         (ada_add_global_exceptions): Update.
10933
10934 2019-01-15  Tom Tromey  <tom@tromey.com>
10935
10936         * progspace.h (program_space) <objfiles_safe_range>: New
10937         typedef.
10938         <objfiles_safe>: New method.
10939         * objfiles.h (class all_objfiles_safe): Remove.
10940         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10941         * jit.c (jit_inferior_exit_hook): Update.
10942
10943 2019-01-17  Tom Tromey  <tom@tromey.com>
10944
10945         * progspace.h (program_space) <objfiles_range>: New typedef.
10946         <objfiles>: New method.
10947         <objfiles_head>: Rename from objfiles.
10948         (object_files): Update.
10949         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10950         * guile/scm-pretty-print.c
10951         (ppscm_find_pretty_printer_from_objfiles): Update.
10952         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10953         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10954         Update.
10955         * python/py-progspace.c (pspy_get_objfiles): Update.
10956         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10957         Update.
10958         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10959         (objfpy_lookup_objfile_by_build_id): Update.
10960         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10961         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10962         Update.
10963         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10964         (expand_symtab_containing_pc, lookup_objfile_from_block)
10965         (lookup_static_symbol, basic_lookup_transparent_type)
10966         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10967         (find_line_symtab, info_sources_command)
10968         (default_collect_symbol_completion_matches_break_on)
10969         (make_source_files_completion_list, find_main_name): Update.
10970         * symmisc.c (print_symbol_bcache_statistics)
10971         (print_objfile_statistics, maintenance_print_symbols)
10972         (maintenance_print_msymbols, maintenance_print_objfiles)
10973         (maintenance_info_symtabs, maintenance_check_symtabs)
10974         (maintenance_expand_symtabs, maintenance_info_line_tables):
10975         Update.
10976         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10977         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10978         (map_overlay_command, unmap_overlay_command)
10979         (simple_overlay_update, expand_symtabs_matching)
10980         (map_symbol_filenames): Update.
10981         * symfile-debug.c (set_debug_symfile): Update.
10982         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10983         Update.
10984         * source.c (select_source_symtab, forget_cached_source_info):
10985         Update.
10986         * solib.c (solib_read_symbols): Update.
10987         * solib-spu.c (append_ocl_sos): Update.
10988         * psymtab.c (maintenance_print_psymbols)
10989         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10990         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10991         * printcmd.c (info_symbol_command): Update.
10992         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10993         Update.
10994         * objfiles.h (class all_objfiles): Remove.
10995         * objfiles.c (have_partial_symbols, have_full_symbols)
10996         (have_minimal_symbols, qsort_cmp, update_section_map)
10997         (shared_objfile_contains_address_p)
10998         (default_iterate_over_objfiles_in_search_order): Update.
10999         * objc-lang.c (info_selectors_command, info_classes_command)
11000         (find_methods): Update.
11001         * minsyms.c (find_solib_trampoline_target): Update.
11002         * maint.c (maintenance_info_sections)
11003         (maintenance_translate_address, count_symtabs_and_blocks):
11004         Update.
11005         * main.c (captured_main_1): Update.
11006         * linux-thread-db.c (try_thread_db_load_from_pdir)
11007         (has_libpthread): Update.
11008         * linespec.c (iterate_over_all_matching_symtabs)
11009         (search_minsyms_for_name): Update.
11010         * jit.c (jit_find_objf_with_entry_addr): Update.
11011         * hppa-tdep.c (find_unwind_entry)
11012         (hppa_lookup_stub_minimal_symbol): Update.
11013         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
11014         Update.
11015         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11016         (elf_gnu_ifunc_resolve_by_got): Update.
11017         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
11018         * dwarf-index-write.c (save_gdb_index_command): Update.
11019         * cp-support.c (add_symbol_overload_list_qualified): Update.
11020         * breakpoint.c (create_overlay_event_breakpoint)
11021         (create_longjmp_master_breakpoint)
11022         (create_std_terminate_master_breakpoint)
11023         (create_exception_master_breakpoint): Update.
11024         * blockframe.c (find_pc_partial_function): Update.
11025         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
11026         (ada_collect_symbol_completion_matches)
11027         (ada_add_global_exceptions): Update.
11028
11029 2019-01-17  Tom Tromey  <tom@tromey.com>
11030
11031         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
11032         declare VEC.
11033         (solib_target_parse_libraries): Change return type.
11034         (library_list_start_segment, library_list_start_section)
11035         (library_list_end_library, library_list_start_library); Update.
11036         (solib_target_free_library_list): Remove.
11037         (solib_target_parse_libraries): Remove cleanup.  Change return
11038         type.
11039         (solib_target_current_sos): Update.
11040
11041 2019-01-17  Tom Tromey  <tromey@bapiya>
11042
11043         * valprint.c: Replace "the the" with "the".
11044         * symtab.c: Replace "the the" with "the".
11045         * solib.c: Replace "the the" with "the".
11046         * solib-dsbt.c: Replace "the the" with "the".
11047         * linespec.c: Replace "the the" with "the".
11048         * dwarf2loc.h: Replace "the the" with "the".
11049         * amd64-windows-tdep.c: Replace "the the" with "the".
11050         * aarch64-tdep.c: Replace "the the" with "the".
11051
11052 2019-01-16  Keith Seitz  <keiths@redhat.com>
11053
11054         PR gdb/23773
11055         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11056         <builder>: Rename to ..
11057         <m_builder>: ... this and make private.
11058         (dwarf2_cu::get_builder): New method.  Change all users of
11059         `builder' to use this method.
11060         (dwarf2_start_symtab): Move to ...
11061         (dwarf2_cu::start_symtab): ... here.  Update all callers
11062         (setup_type_unit_groups): Move to ...
11063         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
11064         callers.
11065         (dwarf2_cu::reset_builder): New method.
11066         (process_full_compunit, process_full_type_unit): Use
11067         dwarf2_cu::reset_builder.
11068         (follow_die_offset): Record the ancestor CU if it is different
11069         from the followed DIE's CU.
11070         (follow_die_sig_1): Likewise.
11071
11072 2019-01-15  Tom Tromey  <tom@tromey.com>
11073
11074         * remote.c (class remote_state) <buf>: Now a char_vector.
11075         <buf_size>: Remove.
11076         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
11077         parameter.
11078         (remote_target::getpkt_or_notif_sane_1)
11079         (remote_target::getpkt_sane)
11080         (remote_target::getpkt_or_notif_sane): Likewise.
11081         (class remote_target) <putpkt>: New overload.
11082         (remote_target::read_frame): Change type of "buf_p".  Remove
11083         sizeof_p parameter.
11084         (packet_ok): New overload.
11085         (packet_check_result): New overload.
11086         Update all uses.
11087
11088 2019-01-14  Tom Tromey  <tom@tromey.com>
11089
11090         * remote-notif.c (handle_notification, remote_notif_ack)
11091         (remote_notif_parse): Make "buf" const.
11092         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11093         const.
11094         (remote_notif_parse, remote_notif_ack, handle_notification):
11095         Likewise.
11096         * remote.c (remote_notif_stop_parse): Make "buf" const.
11097         (remote_target::remote_parse_stop_reply): Make "buf" const.
11098         (remote_notif_stop_ack): Make "buf" const.
11099
11100 2019-01-14  Tom Tromey  <tom@tromey.com>
11101
11102         * remote.c (remote_console_output): Make parameter const.
11103
11104 2019-01-14  Tom Tromey  <tom@tromey.com>
11105
11106         * target-debug.h (target_debug_print_signals): Constify.
11107         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11108         * procfs.c (procfs_target::pass_signals): Update.
11109         * linux-nat.c (linux_nat_target::pass_signals): Update.
11110         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11111         * target-delegates.c: Rebuild.
11112         * remote.c (remote_target::program_signals): Update.
11113         (remote_target::pass_signals): Update.
11114         * target.c (target_pass_signals): Constify argument.
11115         (target_program_signals): Likewise.
11116         * target.h (struct target_ops) <pass_signals, program_signals>:
11117         Constify argument.
11118         (target_pass_signals, target_program_signals): Constify argument.
11119
11120 2019-01-14  Tom Tromey  <tom@tromey.com>
11121
11122         PR tui/28819:
11123         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11124
11125 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
11126
11127         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11128         field.
11129         * rs6000-tdep.c: Include reggroups.h.
11130         (IS_V_ALIAS_PSEUDOREG): Define.
11131         (rs6000_register_name): Return names for the "vX" aliases.
11132         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11133         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
11134         aliases.  Call default_register_reggroup_p for all other
11135         pseudo-registers.
11136         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11137         New functions.
11138         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11139         Handle "vX" aliases.
11140         (v_alias_pseudo_register_collect): New function.
11141         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11142         (rs6000_gdbarch_init): Initialize "vX" aliases as
11143         pseudo-registers.  Restore registration of
11144         rs6000_pseudo_register_reggroup_p with
11145         set_tdesc_pseudo_register_reggroup_p.
11146
11147 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
11148
11149         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11150         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11151         set_gdbarch_num_pseudo_regs.
11152
11153 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11154
11155         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11156         Remove arg prefixname, add do_set and do_show.
11157         Add member functions set_list and show_list.
11158         * cli/cli-style.c (class cli_style_option): Update accordingly.
11159         (style_set_list): Move to file scope.
11160         (style_show_list): Likewise.
11161         (set_style): Call help_list.
11162         (show_style): Call cmd_show_list.
11163         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11164         Update to use the new macro.
11165
11166 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
11167
11168         * ada-lang.c (_initialize_ada_language): Expand the help text
11169         for the "catch exception" command.
11170
11171 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11172
11173         * symtab.c (matching_obj_sections): Initialize obj,
11174         declare it closer to its usage.
11175
11176 2019-01-10  Tom Tromey  <tom@tromey.com>
11177
11178         * thread-iter.h (inf_threads_iterator): Use next_iterator.
11179         (basic_inf_threads_range): Remove.
11180         (inf_threads_range, inf_non_exited_threads_range)
11181         (safe_inf_threads_range): Use next_adapter.
11182
11183 2019-01-10  Keith Seitz  <keiths@redhat.com>
11184
11185         PR gdb/23712
11186         PR symtab/23010
11187         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11188         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11189
11190 2019-01-10  Keith Seitz  <keiths@redhat.com>
11191
11192         PR gdb/23712
11193         PR symtab/23010
11194         * dictionary.c (pending_to_vector): Remove.
11195         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11196         Remove _1 suffix, replacing functions of the same name.  Update
11197         all callers.
11198         (dict_create_hashed, dict_create_hashed_expandable)
11199         (dict_create_linear, dict_create_linear_expandable, dict_free)
11200         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11201         Make functions static.
11202
11203 2019-01-10  Keith Seitz  <keiths@redhat.com>
11204
11205         PR gdb/23712
11206         PR symtab/23010
11207         * dictionary.h (struct dictionary): Replace declaration with
11208         multidictionary.
11209         (dict_create_hashed, dict_create_hashed_expandable)
11210         (dict_create_linear, dict_create_linear_expandable)
11211         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11212         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11213         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11214         taking multidictionary argument.
11215         [ALL_DICT_SYMBOLS]: Update for multidictionary.
11216         * block.h (struct block) <dict>: Change to multidictionary
11217         and rename `multidict'.
11218         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11219         symmisc.c: Update all dictionary references to multidictionary.
11220
11221 2019-01-10  Keith Seitz  <keiths@redhat.com>
11222
11223         PR gdb/23712
11224         PR symtab/23010
11225         * dictionary.c: Include unordered_map.
11226         (pending_to_vector): New function.
11227         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11228         Rewrite the non-"_1" functions to take vector instead
11229         of linked list.
11230         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11231         "new" _1 versions of the same name.
11232         (multidictionary): Define.
11233         (std::hash<enum language): New definition.
11234         (collate_pending_symbols_by_language, mdict_create_hashed)
11235         (mdict_create_hashed_expandable, mdict_create_linear)
11236         (mdict_create_linear_expandable, mdict_free)
11237         (find_language_dictionary, create_new_language_dictionary)
11238         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11239         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11240         (mdict_size, mdict_empty): New functions.
11241         * dictionary.h (mdict_iterator): Define.
11242
11243 2019-01-10  Pedro Alves  <palves@redhat.com>
11244
11245         * breakpoint.c (read_uploaded_action)
11246         (create_tracepoint_from_upload): Adjust to use
11247         gdb::unique_xmalloc_ptr.
11248         * ctf.c (ctf_write_uploaded_tp):
11249         (SET_ARRAY_FIELD): Use emplace_back.
11250         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11251         * tracefile-tfile.c (tfile_write_uploaded_tp):
11252         * tracepoint.c (parse_tracepoint_definition): Adjust to use
11253         gdb::unique_xmalloc_ptr.
11254         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11255         at_string, cond_string, cmd_strings>: Replace char pointers
11256         with gdb::unique_xmalloc_ptr.
11257
11258 2019-01-10  Pedro Alves  <palves@redhat.com>
11259
11260         * solib-target.c (library_list_start_library): Don't xstrdup name.
11261
11262 2019-01-10  Pedro Alves  <palves@redhat.com>
11263
11264         * mdebugread.c (parse_partial_symbols): Use
11265         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11266
11267 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11268
11269         * linux-fork.c (scoped_switch_fork_info)
11270         <~scoped_switch_fork_info>: Fix incorrect variable name.
11271
11272 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11273
11274         * linux-fork.c (scoped_switch_fork_info)
11275         <scoped_switch_fork_info>: Make explicit.
11276         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11277
11278 2019-01-10  Tom Tromey  <tom@tromey.com>
11279
11280         * objfiles.h (objfile::reset_psymtabs): Update.
11281         * objfiles.c (objfile::objfile): Update.
11282         * psymtab.h (psymtab_storage::obstack): Update.
11283         (psymtab_storage::m_obstack): Use gdb::optional.
11284         (class psymtab_storage): Update comment.  Remove objfile
11285         parameter.
11286         * psymtab.c (psymtab_storage::psymtab_storage): Update.
11287
11288 2019-01-10  Tom Tromey  <tom@tromey.com>
11289
11290         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11291         <free_psymtabs>: Now private.
11292         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11293         (allocate_psymtab): Use new method.
11294
11295 2019-01-10  Tom Tromey  <tom@tromey.com>
11296
11297         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11298         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11299         * mdebugread.c (parse_partial_symbols): Use
11300         allocate_dependencies.
11301         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11302         allocate_dependencies.
11303         (process_psymtab_comp_unit_reader)
11304         (build_type_psymtab_dependencies): Likewise.
11305         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11306
11307 2019-01-10  Tom Tromey  <tom@tromey.com>
11308
11309         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11310         PSYMBOL_SET_LANGUAGE.
11311         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11312
11313 2019-01-10  Tom Tromey  <tom@tromey.com>
11314
11315         * psymtab.h (psymtab_storage::obstack): New method.
11316         <m_obstack>: Rename from obstack; now private.
11317         * psymtab.c (psymtab_storage): Update.
11318         * dwarf2read.c (create_addrmap_from_index)
11319         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11320         Update.
11321
11322 2019-01-10  Tom Tromey  <tom@tromey.com>
11323
11324         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11325         * objfiles.h (objfile::reset_psymtabs): New method.
11326
11327 2019-01-10  Tom Tromey  <tom@tromey.com>
11328
11329         * symmisc.c (print_symbol_bcache_statistics): Update.
11330         (print_objfile_statistics): Update.
11331         * symfile.c (reread_symbols): Update.
11332         * psymtab.h (class psymtab_storage): New.
11333         * psymtab.c (psymtab_storage): New constructor.
11334         (~psymtab_storage): New destructor.
11335         (require_partial_symbols): Update.
11336         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11337         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11338         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11339         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11340         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11341         (start_psymtab_common, end_psymtab_common)
11342         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11343         (allocate_psymtab): Update.
11344         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11345         Update.
11346         (dump_psymtab_addrmap, maintenance_print_psymbols)
11347         (maintenance_check_psymtabs): Update.
11348         (class objfile_psymtabs): Move to objfiles.h.
11349         * psympriv.h (discard_psymtab): Now inline.
11350         (psymtab_discarder::psymtab_discarder): Update.
11351         (psymtab_discarder::~psymtab_discarder): Update.
11352         (ALL_OBJFILE_PSYMTABS): Rewrite.
11353         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11354         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11355         Remove fields.
11356         <partial_symtabs>: New field.
11357         (class objfile_psymtabs): Move from psymtab.h.  Update.
11358         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11359         psymbol_cache.
11360         (objfile::~objfile): Don't destroy psymbol_cache.
11361         * mdebugread.c (parse_partial_symbols): Update.
11362         * dwarf2read.c (create_addrmap_from_index)
11363         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11364         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11365         (add_partial_subprogram, dwarf2_ranges_read): Update.
11366         * dwarf-index-write.c (write_address_map)
11367         (write_one_signatured_type, recursively_write_psymbols)
11368         (class debug_names, class debug_names, write_psymtabs_to_index):
11369         Update.
11370
11371 2019-01-10  Tom Tromey  <tom@tromey.com>
11372
11373         * symtab.h (SYMBOL_SET_NAMES): Update.
11374         (symbol_set_names): Update.
11375         (MSYMBOL_SET_NAMES): Update.
11376         * symtab.c (symbol_set_names): Change argument to be an
11377         objfile_per_bfd_storage.
11378         * psymtab.c (add_psymbol_to_bcache): Update.
11379         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11380
11381 2019-01-10  Tom Tromey  <tom@tromey.com>
11382
11383         * symtab.c (create_demangled_names_hash): Change argument to be an
11384         objfile_per_bfd_storage.
11385         (symbol_set_names): Update.
11386
11387 2019-01-10  Tom Tromey  <tom@tromey.com>
11388
11389         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11390         init_psymbol_list.
11391         * psymtab.c (init_psymbol_list): Do nothing if already called.
11392         * psympriv.h (init_psymbol_list): Add comment.
11393         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11394         init_psymbol_list.
11395         * dbxread.c (dbx_symfile_read): Unconditionally call
11396         init_psymbol_list.
11397
11398 2019-01-10  Tom Tromey  <tom@tromey.com>
11399
11400         * xcoffread.c (scan_xcoff_symtab): Update.
11401         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11402         "where".
11403         * mdebugread.c (parse_partial_symbols)
11404         (handle_psymbol_enumerators): Update.
11405         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11406         * dbxread.c (read_dbx_symtab): Update.
11407         * psympriv.h (psymbol_placement): New enum.
11408         (add_psymbol_to_list): Update.
11409
11410 2019-01-10  Tom Tromey  <tom@tromey.com>
11411
11412         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11413         static_psymbols parameters.
11414         (scan_xcoff_symtab): Update.
11415         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11416         static_psymbols parameters.
11417         * psympriv.h (start_psymtab_common): Update.
11418         * mdebugread.c (parse_partial_symbols): Update.
11419         * dwarf2read.c (create_partial_symtab): Update.
11420         * dbxread.c (read_dbx_symtab): Update.
11421         (start_psymtab): Remove global_psymbols and static_psymbols
11422         parameters.
11423
11424 2019-01-10  Tom Tromey  <tom@tromey.com>
11425
11426         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11427         * psymtab.c (allocate_psymtab): Add comment.
11428         * psympriv.h (allocate_psymtab): Add comment.
11429         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11430         initializations.
11431         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11432
11433 2019-01-10  Tom Tromey  <tom@tromey.com>
11434
11435         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11436         Don't declare.
11437         * mipsread.c: Include mdebugread.h.
11438         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11439         Declare.
11440         * elfread.c: Include mdebugread.h.
11441
11442 2019-01-09  Tom Tromey  <tom@tromey.com>
11443
11444         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11445         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11446         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11447         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11448         (psym_lookup_symbol, psym_find_last_source_symtab)
11449         (psym_forget_cached_source_info, psym_print_stats)
11450         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11451         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11452         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11453         (psym_find_compunit_symtab_by_address)
11454         (maintenance_print_psymbols, maintenance_info_psymtabs)
11455         (maintenance_check_psymtabs): Use ranged for.
11456         * psymtab.h (class objfile_psymtabs): New.
11457         (require_partial_symbols): Return objfile_psymtabs.
11458         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11459
11460 2019-01-09  Tom Tromey  <tom@tromey.com>
11461
11462         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11463         (find_pc_mapped_section, list_overlays_command)
11464         (map_overlay_command, unmap_overlay_command)
11465         (simple_overlay_update): Use all_objfiles.
11466         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11467         * printcmd.c (info_symbol_command): Use all_objfiles.
11468         * objfiles.h (ALL_OBJSECTIONS): Remove.
11469         * maint.c (maintenance_translate_address): Use all_objfiles.
11470         * gcore.c (gcore_create_callback): Use all_objfiles.
11471         (objfile_find_memory_regions): Likewise.
11472
11473 2019-01-09  Tom Tromey  <tom@tromey.com>
11474
11475         * symtab.c (find_line_symtab, info_sources_command)
11476         (make_source_files_completion_list): Use objfile_compunits.
11477         * source.c (select_source_symtab): Use objfile_compunits.
11478         * objfiles.h (struct objfile): Update comment.
11479         (ALL_OBJFILES): Remove.
11480         (ALL_FILETABS): Remove.
11481         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11482         objfile_compunits.
11483
11484 2019-01-09  Tom Tromey  <tom@tromey.com>
11485
11486         * symmisc.c (print_objfile_statistics, dump_objfile)
11487         (maintenance_print_symbols): Use compunit_filetabs.
11488         * source.c (forget_cached_source_info_for_objfile): Use
11489         compunit_filetabs.
11490         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11491         (ALL_FILETABS): Use compunit_filetabs.
11492         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11493         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11494
11495 2019-01-09  Tom Tromey  <tom@tromey.com>
11496
11497         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11498         (compunit_filetabs): New.
11499         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11500         compunit_filetabs.
11501         (info_sources_command, make_source_files_completion_list): Remove
11502         declaration.
11503         * symmisc.c (print_objfile_statistics, dump_objfile)
11504         (maintenance_print_symbols): Remove declaration.
11505         (maintenance_info_symtabs): Use compunit_filetabs.
11506         (maintenance_info_line_tables): Likewise.
11507         * source.c (select_source_symtab): Change local variable name.
11508         (forget_cached_source_info_for_objfile): Remove declaration.
11509         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11510         * objfiles.c (objfile_relocate1): Remove declaration.
11511         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11512         declaration.
11513         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11514         * coffread.c (coff_symtab_read): Remove declaration.
11515         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11516         compunit_filetabs.
11517
11518 2019-01-09  Tom Tromey  <tom@tromey.com>
11519
11520         * symtab.c (lookup_objfile_from_block)
11521         (find_pc_sect_compunit_symtab, search_symbols)
11522         (default_collect_symbol_completion_matches_break_on): Use
11523         objfile_compunits.
11524         * objfiles.h (ALL_COMPUNITS): Remove.
11525         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11526         * cp-support.c (add_symbol_overload_list_qualified): Use
11527         objfile_compunits.
11528         * ada-lang.c (ada_collect_symbol_completion_matches)
11529         (ada_add_global_exceptions): Use objfile_compunits.
11530
11531 2019-01-09  Tom Tromey  <tom@tromey.com>
11532
11533         * source.c (select_source_symtab)
11534         (forget_cached_source_info_for_objfile): Remove declaration.
11535         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11536         declaration.
11537         * maint.c (count_symtabs_and_blocks): Remove declaration.
11538         * cp-support.c (add_symbol_overload_list_qualified): Remove
11539         declaration.
11540         * coffread.c (coff_symtab_read): Remove declaration.
11541         * symtab.c (lookup_symbol_in_objfile_symtabs)
11542         (basic_lookup_transparent_type_1): Use objfile_compunits.
11543         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11544         (info_sources_command, search_symbols)
11545         (default_collect_symbol_completion_matches_break_on)
11546         (make_source_files_completion_list): Remove declaration.
11547         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11548         (ada_collect_symbol_completion_matches)
11549         (ada_add_global_exceptions): Remove declaration.
11550         * linespec.c (iterate_over_all_matching_symtabs): Use
11551         objfile_compunits.
11552         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11553         (class objfile_compunits): New.
11554         (ALL_COMPUNITS): Use objfile_compunits.
11555         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11556         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11557         objfile_compunits.
11558         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11559
11560 2019-01-09  Tom Tromey  <tom@tromey.com>
11561
11562         * symtab.c (search_symbols)
11563         (default_collect_symbol_completion_matches_break_on): Use
11564         objfile_msymbols.
11565         * ada-lang.c (ada_lookup_simple_minsym)
11566         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11567         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11568         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11569         objfile_msymbols.
11570         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11571         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11572         * objc-lang.c (find_methods): Use objfile_msymbols.
11573         (info_selectors_command, info_classes_command): Likewise.
11574         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11575         * objfiles.h (class objfile_msymbols): New.
11576         (ALL_OBJFILE_MSYMBOLS): Remove.
11577         (ALL_MSYMBOLS): Remove.
11578
11579 2019-01-09  Tom Tromey  <tom@tromey.com>
11580
11581         * common/next-iterator.h (next_adapter): Add Iterator template
11582         parameter.
11583         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11584         (class all_objfiles_safe): New.
11585         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11586         * objfiles.c (put_objfile_before): Update comment.
11587         (add_separate_debug_objfile): Likewise.
11588         (free_all_objfiles): Use all_objfiles_safe.
11589         (objfile_purge_solibs): Likewise.
11590
11591 2019-01-09  Tom Tromey  <tom@tromey.com>
11592
11593         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11594         (expand_symtab_containing_pc, lookup_static_symbol)
11595         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11596         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11597         all_objfiles.
11598         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11599         * breakpoint.c (create_overlay_event_breakpoint)
11600         (create_longjmp_master_breakpoint)
11601         (create_std_terminate_master_breakpoint)
11602         (create_exception_master_breakpoint): Use all_objfiles.
11603         * linux-thread-db.c (try_thread_db_load_from_pdir)
11604         (has_libpthread): Use all_objfiles.
11605         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11606         * linespec.c (iterate_over_all_matching_symtabs)
11607         (search_minsyms_for_name): Use all_objfiles.
11608         * maint.c (maintenance_info_sections): Use all_objfiles.
11609         * main.c (captured_main_1): Use all_objfiles.
11610         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11611         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11612         * guile/scm-pretty-print.c
11613         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11614         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11615         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11616         (maintenance_print_msymbols): Use all_objfiles.
11617         * source.c (select_source_symtab): Use all_objfiles.
11618         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11619         * symfile.c (remove_symbol_file_command)
11620         (expand_symtabs_matching, map_symbol_filenames): Use
11621         all_objfiles.
11622         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11623         all_objfiles.
11624         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11625         * objc-lang.c (find_methods): Use all_objfiles.
11626         * objfiles.c (have_partial_symbols, have_full_symbols)
11627         (have_minimal_symbols, qsort_cmp)
11628         (default_iterate_over_objfiles_in_search_order): Use
11629         all_objfiles.
11630         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11631         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11632         (maintenance_check_psymtabs): Use all_objfiles.
11633         (ALL_PSYMTABS): Remove.
11634         * compile/compile-object-run.c (do_module_cleanup): Use
11635         all_objfiles.
11636         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11637         * cp-support.c (add_symbol_overload_list_qualified): Use
11638         all_objfiles.
11639         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11640         Use all_objfiles.
11641         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11642         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11643         all_objfiles.
11644         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11645         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11646         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11647         Uses all_objfiles.
11648         * solib.c (solib_read_symbols): Use all_objfiles
11649
11650 2019-01-09  Tom Tromey  <tom@tromey.com>
11651
11652         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11653         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11654         all_objfiles.
11655         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11656         * symmisc.c (print_symbol_bcache_statistics)
11657         (print_objfile_statistics, maintenance_print_objfiles)
11658         (maintenance_info_symtabs, maintenance_check_symtabs)
11659         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11660         all_objfiles.
11661         * source.c (forget_cached_source_info): Use all_objfiles.
11662         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11663         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11664         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11665         * objfiles.c (update_section_map): Use all_objfiles.
11666         (shared_objfile_contains_address_p): Likewise.
11667         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11668         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11669
11670 2019-01-09  Tom Tromey  <tom@tromey.com>
11671
11672         * common/next-iterator.h: New file.
11673         * objfiles.h (class all_objfiles): New.
11674         (struct objfile_iterator): New.
11675
11676 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11677
11678         * NEWS: Move the description of the changed "frame", "select-frame",
11679          and "info frame" commands to the Changed commands section.
11680
11681 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11682
11683         * gdbtypes.c (check_stub_method_group): Remove handling of old
11684         mangling schemes.
11685         * linespec.c (find_methods): Likewise.
11686         * stabsread.c (read_member_functions): Likewise.
11687         * valops.c (search_struct_method): Likewise.
11688         (value_struct_elt_for_reference): Likewise.
11689         * NEWS: Mention this change.
11690
11691 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11692
11693         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11694         print_source_lines.
11695         * source.c (print_source_lines_base): Update line number check.
11696         (print_source_lines): New function.
11697         (source_lines_range::source_lines_range): New function.
11698         * source.h (class source_lines_range): New class.
11699         (print_source_lines): New declaration.
11700
11701 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11702
11703         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11704
11705 2019-01-08  Tom Tromey  <tom@tromey.com>
11706             Simon Marchi  <simon.marchi@ericsson.com>
11707
11708         PR gdb/24060
11709         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11710         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11711         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11712         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11713         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11714         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11715
11716 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11717
11718         * source.c (select_source_symtab): Move header comment to
11719         declaration in source.h.
11720         (forget_cached_source_info_for_objfile): Likewise.
11721         (forget_cached_source_info): Likewise.
11722         (identify_source_line): Likewise.
11723         * source.h (identify_source_line): Move declaration from symtab.h
11724         and add comment from source.c
11725         (print_source_lines): Likewise.
11726         (forget_cached_source_info_for_objfile): Likewise.
11727         (forget_cached_source_info): Likewise.
11728         (select_source_symtab): Likewise.
11729         (enum print_source_lines_flag): Move definition from symtab.h.
11730         * symtab.h (identify_source_line): Move declaration to source.h.
11731         (print_source_lines): Likewise.
11732         (forget_cached_source_info_for_objfile): Likewise.
11733         (forget_cached_source_info): Likewise.
11734         (select_source_symtab): Likewise.
11735         (enum print_source_lines_flag): Move definition to source.h.
11736         * tui/tui-hooks.c: Add 'source.h' include.
11737
11738 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11739
11740         * source.c (print_source_lines_base): Handle requests to print
11741         reverse line number sequences, and guard against empty lines
11742         string.
11743
11744 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11745
11746         * source.c (print_source_lines_base): Fix skip of '\r' if next
11747         character is '\n'.
11748
11749 2019-01-06  Tom Tromey  <tom@tromey.com>
11750
11751         * c-exp.y (struct c_parse_state) <macro_original_text,
11752         expansion_obstack>: New member.
11753         (macro_original_text, expansion_obstack): Remove globals.
11754         (scan_macro_expansion, scanning_macro_expansion)
11755         (finished_macro_expansion): Update.
11756         (scan_macro_cleanup): Remove.
11757         (yylex, c_parse): Update.
11758
11759 2019-01-06  Tom Tromey  <tom@tromey.com>
11760
11761         * c-exp.y (struct c_parse_state) <strings>: New member.
11762         (operator_stoken): Update.
11763
11764 2019-01-06  Tom Tromey  <tom@tromey.com>
11765
11766         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11767         (union type_stack_elt) <typelist_val>: Now a pointer to
11768         std::vector.
11769         (type_stack_cleanup): Don't declare.
11770         (push_typelist): Update.
11771         * parse.c (pop_typelist): Return a std::vector.
11772         (push_typelist): Take a std::vector.
11773         (follow_types): Update.  Do not free args.
11774         (type_stack_cleanup): Remove.
11775         * c-exp.y (struct c_parse_state): New.
11776         (cpstate): New global.
11777         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11778         (nonempty_typelist): Update.
11779         (func_mod): Create a new vector.
11780         (c_parse): Create a c_parse_state.
11781         (check_parameter_typelist): Do not delete params.
11782         (function_method): Update.  Do not delete type_list.
11783
11784 2019-01-06  Tom Tromey  <tom@tromey.com>
11785
11786         PR gdb/28155:
11787         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11788         check_typedef.
11789         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11790         (print_return_value): Likewise.
11791
11792 2019-01-05  Tom Tromey  <tom@tromey.com>
11793
11794         * contrib/cleanup_check.py: Remove.
11795         * contrib/gcc-with-excheck: Remove.
11796         * contrib/exsummary.py: Remove.
11797         * contrib/excheck.py: Remove.
11798
11799 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11800
11801         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11802         NULL. Initialize tpprev to NULL instead of assigning it
11803         to NULL on the next statement.
11804         * windows-nat.c (windows_delete_thread): Remove check for
11805         main_thread_id before printing thread exit notifications.
11806         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11807         Remove thread ID check against main_thread_id.
11808         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11809         windows_delete_thread.
11810         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11811
11812 2019-01-04  Tom Tromey  <tom@tromey.com>
11813
11814         * compile/compile.c (_initialize_compile): Use upper case for
11815         metasyntactic variables.
11816         * symmisc.c (_initialize_symmisc): Use upper case for
11817         metasyntactic variables.
11818         * psymtab.c (_initialize_psymtab): Use upper case for
11819         metasyntactic variables.
11820         * demangle.c (demangle_command): Use upper case for metasyntactic
11821         variables.
11822         (_initialize_demangler): Likewise.
11823         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11824         variables.
11825
11826 2019-01-03  Tom Tromey  <tom@tromey.com>
11827
11828         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11829
11830 2019-01-03  Tom Tromey  <tom@tromey.com>
11831
11832         * python/py-symtab.c (salpy_str): Update.
11833         (struct salpy_sal_object) <symtab>: Now a PyObject.
11834         (salpy_dealloc): Update.
11835         (del_objfile_sal): Use gdbpy_ref.
11836
11837 2019-01-03  Tom Tromey  <tom@tromey.com>
11838
11839         * python/py-type.c (convert_field): Use new_reference.  Return
11840         gdbpy_ref.
11841         (make_fielditem): Return gdbpy_ref.
11842         (typy_fields): Update.
11843         (typy_getitem): Update.
11844         (field_name): Return gdbpy_ref.  Use new_reference.
11845         (typy_iterator_iternext): Update.
11846
11847 2019-01-03  Tom Tromey  <tom@tromey.com>
11848
11849         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11850
11851 2019-01-03  Tom Tromey  <tom@tromey.com>
11852
11853         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11854         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11855         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11856         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11857         (pspy_set_type_printers): Likewise.
11858         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11859         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11860         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11861         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11862         (objfpy_set_type_printers): Likewise.
11863
11864 2019-01-03  Tom Tromey  <tom@tromey.com>
11865
11866         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11867         (gdbpy_print_stack): Use gdbpy_err_fetch.
11868         * python/python-internal.h (class gdbpy_err_fetch): New class.
11869         (class gdbpy_enter) <m_error_type, m_error_value,
11870         m_error_traceback>: Remove.
11871         <m_error>: New member.
11872         (gdbpy_exception_to_string): Don't declare.
11873         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11874         * python/py-value.c (convert_value_from_python): Use
11875         gdbpy_err_fetch.
11876         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11877         gdbpy_exception_to_string.
11878         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11879         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11880         gdbpy_err_fetch.
11881
11882 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11883
11884         * linux-nat.c (delete_lwp_cleanup): Delete.
11885         (struct lwp_deleter): New struct.
11886         (lwp_info_up): New typedef.
11887         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11888         lwp_info_up.
11889
11890 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11891
11892         * linux-fork.c (class scoped_switch_fork_info): New class.
11893         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11894
11895 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11896
11897         * valops.c (find_overload_match): Remove use of null_cleanup, and
11898         calls to do_cleanups.
11899
11900 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11901
11902         * compile/compile-cplus-types.c
11903         (compile_cplus_instance::decl_name): Handle changes to
11904         cp_func_name.
11905         * cp-support.c (cp_func_name): Update header comment, update
11906         return type.
11907         * cp-support.h (cp_func_name): Update return type in declaration.
11908         * valops.c (find_overload_match): Move temp_func local to top
11909         level of function and change its type.  Use temp_func to hold and
11910         delete temporary string obtained from cp_func_name.
11911
11912 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11913
11914         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11915         gdb::char_vector, remove cleanup, and update uses of `msg`.
11916
11917 2019-01-03  Jim Wilson  <jimw@sifive.com>
11918
11919         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11920
11921 2019-01-02  Tom Tromey  <tom@tromey.com>
11922
11923         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11924         (tdesc_parse_xml): Remove cleanups.
11925         * target-descriptions.h (make_cleanup_free_target_description):
11926         Don't declare.
11927         (target_desc_deleter): New struct.
11928         (target_desc_up): New typedef.
11929         * target-descriptions.c (target_desc_deleter::operator()): Rename
11930         from free_target_description.
11931         (make_cleanup_free_target_description): Remove.
11932
11933 2019-01-02  Tom Tromey  <tom@tromey.com>
11934
11935         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11936         constructor, destructor.
11937         (linespec_parser): Remove typedef.
11938         (~linespec_parser): Rename from linespec_parser_delete.
11939         (linespec_lex_to_end, linespec_complete_label)
11940         (linespec_complete): Update.
11941         (decode_line_full): Remove cleanups.
11942         (decode_line_1): Update.
11943
11944 2019-01-02  Tom Tromey  <tom@tromey.com>
11945
11946         * python/python-internal.h (inferior_to_inferior_object): Change
11947         return type.
11948         * python/py-exitedevent.c (create_exited_event_object): Update.
11949         * python/py-inferior.c (inferior_to_inferior_object): Return
11950         gdbpy_ref.
11951         (python_new_inferior, python_inferior_deleted)
11952         (thread_to_thread_object, delete_thread_object)
11953         (build_inferior_list, gdbpy_selected_inferior): Update.
11954         * python/py-infthread.c (create_thread_object): Update.  Also fail
11955         if inferior_to_inferior_object fails.
11956
11957 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11958
11959         * inferior.h (class inferior) <displaced_step_state>: New field.
11960         * infrun.h (struct displaced_step_state): Move here from
11961         infrun.c.  Initialize fields, add constructor.
11962         <inf>: Remove field.
11963         <reset>: New method.
11964         * infrun.c (struct displaced_step_inferior_state): Move to
11965         infrun.h.
11966         (displaced_step_inferior_states): Remove.
11967         (get_displaced_stepping_state): Adust.
11968         (displaced_step_in_progress_any_inferior): Adjust.
11969         (displaced_step_in_progress_thread): Adjust.
11970         (displaced_step_in_progress): Adjust.
11971         (add_displaced_stepping_state): Remove.
11972         (get_displaced_step_closure_by_addr): Adjust.
11973         (remove_displaced_stepping_state): Remove.
11974         (infrun_inferior_exit): Call displaced_step_state.reset.
11975         (use_displaced_stepping): Don't check for NULL.
11976         (displaced_step_prepare_throw): Call
11977         get_displaced_stepping_state.
11978         (displaced_step_fixup): Don't check for NULL.
11979         (prepare_for_detach): Don't check for NULL.
11980
11981 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11982
11983         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11984          in case of call that did not complete.
11985
11986 2019-01-02  Andrey Utkin  <autkin@undo.io>
11987
11988         * symfile.c (find_separate_debug_file): Fix search of debug files for
11989         remote debuggee.
11990
11991 2019-01-02  Tom Tromey  <tom@tromey.com>
11992
11993         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11994         indentation.
11995         * python/py-frame.c (frapy_older): Remove cast.
11996         (frapy_newer): Likewise.
11997         * python/py-breakpoint.c (local_setattro): Remove cast.
11998         * python/py-arch.c (archpy_name): Remove local variable.
11999         * python/py-type.c (gdbpy_lookup_type): Remove cast.
12000
12001 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
12002
12003         * unittests/basic_string_view/element_access/char/empty.cc:
12004         Fix year range in copyright header.
12005
12006 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12007
12008         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
12009         Delete.
12010         <operator==>: Update with for removed field.
12011         <hash>: Likewise.
12012         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
12013         <isa_features>: ...this.
12014         <abi_features>: New field.
12015         (riscv_isa_flen): Update comment.
12016         (riscv_abi_xlen): New declaration.
12017         (riscv_abi_flen): New declaration.
12018         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
12019         isa_features.
12020         (riscv_abi_xlen): New function.
12021         (riscv_isa_flen): Update to get answer from isa_features.
12022         (riscv_abi_flen): New function.
12023         (riscv_has_fp_abi): Update to get answer from abi_features.
12024         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
12025         xlen and flen.
12026         (riscv_call_info) <xlen, flen>: Update comment.
12027         (riscv_call_arg_struct): Remove invalid assertions
12028         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12029         is removed.
12030         (riscv_gdbarch_init): Gather isa features and abi features
12031         separately, ensure both match on the gdbarch when reusing an old
12032         gdbarch.  Relax an error check to allow 32-bit abi float to run on
12033         a target with 64-bit float hardware.
12034
12035 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12036
12037         * source.c (search_command_helper): Stop reverse search
12038         when line 1 has been searched.
12039
12040 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12041
12042         * record-full.c (record_full_base_target::close): Rewrite
12043         record_full_core_buf_list free logic.
12044
12045 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12046
12047         * break-catch-syscall.c (print_one_catch_syscall): xfree
12048         the last text.
12049
12050 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12051
12052         * top.c (print_gdb_version): Update Copyright year in version
12053         message.
12054
12055 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12056
12057         Update copyright year range in all GDB files.
12058
12059 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
12060
12061         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
12062
12063 For older changes see ChangeLog-2018.
12064 \f
12065 Local Variables:
12066 mode: change-log
12067 left-margin: 8
12068 fill-column: 74
12069 version-control: never
12070 coding: utf-8
12071 End:
12072